* src/s/gnu.h (POSIX_SIGNALS): Remove (again).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1d3823c9
GM
12012-06-13 Glenn Morris <rgm@gnu.org>
2
3 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
4
bfe3e0a2
PE
52012-06-13 Paul Eggert <eggert@cs.ucla.edu>
6
7 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
8 * alloc.c (make_number) [!defined make_number]:
9 Remove, as lisp.h always defines this now.
10 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
11 (roundup_size): Verify that it is a power of 2.
12 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
13 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
14 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
15 -DUSE_LSB_TAG=0, to override the automatically-selected default.
16 USE_LSB_TAG now is always defined to be either 0 or 1.
17 All uses changed.
18 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
19 code works fine either way, and efficiency is not a concern here,
20 as the union type is for debugging, not for production.
21 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
22 Use an inline function on all platforms when using the union type,
23 since this is simpler and 'static inline' can be used portably
24 within Emacs now.
25 (LISP_INITIALLY_ZERO): New macro.
26 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
27 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
28
45fa9c0f
GM
292012-06-12 Glenn Morris <rgm@gnu.org>
30
b4492cba
GM
31 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
32
33 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 34
45fa9c0f
GM
35 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
36 Move BROKEN_SIGIO to configure.
37
38 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
39 Move NO_TERMIO to configure.
40
0e25d334
CY
412012-06-12 Chong Yidong <cyd@gnu.org>
42
43 * image.c (imagemagick_load_image): Use MagickFlattenImage if
44 MagickMergeImageLayers is undefined. Use pixel pusher loop if
45 MagickExportImagePixels is undefined.
46
43682bb6
PE
472012-06-12 Paul Eggert <eggert@cs.ucla.edu>
48
49 * image.c (imagemagick_load_image): Remove unused label.
50
a9be7d2b
GM
512012-06-11 Glenn Morris <rgm@gnu.org>
52
53 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
54 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
55 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
56 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
57
3017f87f
SM
582012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
59
60 * alloc.c (make_byte_code): New function.
61 (Fmake_byte_code): Use it. Don't purify here.
62 * lread.c (read1): Use it as well to avoid extra allocation.
63
1b9b4cf4
CY
642012-06-11 Chong Yidong <cyd@gnu.org>
65
66 * image.c (imagemagick_load_image): Implement transparency.
67
95988fcf
AS
682012-06-10 Andreas Schwab <schwab@linux-m68k.org>
69
70 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
71 account for preceding backslashes. (Bug#11663)
72
cd4eb164
CY
732012-06-09 Chong Yidong <cyd@gnu.org>
74
75 * term.c: Support italics in capable terminals (Bug#9652).
76 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
77 (turn_on_face): Output using TS_enter_italic_mode if available.
78 Don't handle unused blinking and alt-charset cases.
79 (turn_off_face): Handle italic case; discard unused tty_blinking_p
80 and tty_alt_charset_p cases.
81 (tty_capable_p, init_tty): Support italics.
82
83 * termchar.h (struct tty_display_info): Add field for italics.
84 Remove unused blink field.
85
86 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
87 Handle slant.
88
89 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
90 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
91 tty_alt_charset_p. Add tty_italic_p.
92
ff88beb8
MA
932012-06-09 Michael Albinus <michael.albinus@gmx.de>
94
95 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
96 dbus_type_is_basic if available.
97 (xd_extract_signed, xd_extract_unsigned): Rename from
98 extract_signed and extract_unsigned, respectively. Adapt callers.
99
44286096
CY
1002012-06-09 Chong Yidong <cyd@gnu.org>
101
1682701f
CY
102 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
103
44286096
CY
104 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
105 case (Bug#9752).
106
d86feb17
PE
1072012-06-08 Paul Eggert <eggert@cs.ucla.edu>
108
109 * xdisp.c (vmessage): Treat frame message as multibyte.
110 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
111 would generate the diagnostic "Making \302\247 buffer-local while
112 let-bound!".
113
d5c20fe8
EZ
1142012-06-08 Eli Zaretskii <eliz@gnu.org>
115
116 * dispnew.c (showing_window_margins_p): Undo last change, which
117 was done due to an inadvertent commit.
118 (adjust_frame_glyphs_for_frame_redisplay): Do call
119 showing_window_margins_p.
120
513749ee
SM
1212012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
122
123 * eval.c (Fmake_var_non_special): New primitive.
124 (syms_of_eval): Defsubr it.
125 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
126
d4a8f5c1
JB
1272012-06-08 Juanma Barranquero <lekktu@gmail.com>
128
129 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
130 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
131
8bbbc977
EZ
1322012-06-08 Eli Zaretskii <eliz@gnu.org>
133
134 * alloc.c (allocate_vectorlike): Fix last change.
135
f3372c87
DA
1362012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
137
138 Block-based vector allocation of small vectors.
139 * lisp.h (struct vectorlike_header): New field `nbytes',
140 adjust comment accordingly.
141 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
142 to denote vector blocks. Adjust users (live_vector_p,
143 mark_maybe_pointer, valid_lisp_object_p) accordingly.
144 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
145 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
146 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
147 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
148 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
149 (roundup_size): New constant.
150 (struct vector_block): New data type.
151 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 152 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
153 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
154 (sweep_vectors): New functions.
155 (allocate_vectorlike): Return `zero_vector' as the only vector of
156 0 items. Allocate new vector from block if vector size is less than
157 or equal to VBLOCK_BYTES_MAX.
158 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
159 (init_alloc_once): Add call to init_vectors.
160
4f18a4ed
SM
1612012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
162
163 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
164
86f158bc
PE
1652012-06-07 Paul Eggert <eggert@cs.ucla.edu>
166
167 * doprnt.c (doprnt): Truncate multibyte char correctly.
168 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
169 would mishandle a string argument "Xc" if X was a multibyte
170 character of length 2: it would truncate after X's first byte
171 rather than including all of X.
172
c5cfcbe0
CY
1732012-06-06 Chong Yidong <cyd@gnu.org>
174
175 * buffer.c (word_wrap): Doc fix.
176
c05cf390
PE
1772012-06-04 Paul Eggert <eggert@cs.ucla.edu>
178
179 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
180
0c3461de
GM
1812012-06-03 Glenn Morris <rgm@gnu.org>
182
183 * xdisp.c (tool-bar-style): Doc fix.
184
c71232db
UM
1852012-06-03 Ulrich Müller <ulm@gentoo.org>
186
187 * Makefile.in (PAXCTL): Define.
188 (temacs$(EXEEXT)): Disable memory randomization for the temacs
189 binary via PaX flags if the paxctl utility is available.
190 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
191 Restore PaX flags to their default. (Bug#11398)
192
383f7350
CY
1932012-06-03 Chong Yidong <cyd@gnu.org>
194
195 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
196 buffer (Bug#11226).
197
5f2c76c6
CY
1982012-06-03 Chong Yidong <cyd@gnu.org>
199
200 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
201 (note_mode_line_or_margin_highlight): If there is no help echo,
202 use mode-line-default-help-echo. Handle the case where the mouse
203 position is past the end of the mode line string.
204
205 * buffer.c (buffer_local_value_1): New function, split from
206 Fbuffer_local_value; can return Qunbound.
207 (Fbuffer_local_value): Use it.
208 (Vmode_line_format): Docstring tweaks.
209
773d47f6
PE
2102012-06-02 Paul Eggert <eggert@cs.ucla.edu>
211
212 * sysdep.c (system_process_attributes): Improve comment.
213
f2d6a3df
SM
2142012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
215
216 * keyboard.c: Export real-this-command to Elisp.
217 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
218 and DEFVAR it. Update all users.
219
63810350
PE
2202012-06-02 Paul Eggert <eggert@cs.ucla.edu>
221
7bd5c1f4
PE
222 * minibuf.c (Fassoc_string): Remove duplicate declaration.
223
63810350
PE
224 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
225 Convert pctcpu and pctmem to Lisp float properly.
226 Let the compiler fold better, as 100.0/0x8000 is exact.
227
a2821611
AS
2282012-06-02 Andreas Schwab <schwab@linux-m68k.org>
229
230 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
231 cons_block.
232
5fceba1d
PE
2332012-06-01 Paul Eggert <eggert@cs.ucla.edu>
234
235 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
236
c98ff5dd
DA
2372012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
238
239 For a 'struct window', replace some Lisp_Object fields to
240 bitfields where appropriate, remove unused fields.
241 * window.h (struct window): Remove unused 'last_mark_x' and
242 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
243 change it's type from Lisp_Object to bitfield.
244 Change type of 'force_start', 'optional_new_start',
245 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
246 fields from Lisp_Object to bitfield. Adjust users accordingly.
247
ca34e0be
PE
2482012-05-31 Paul Eggert <eggert@cs.ucla.edu>
249
250 Pacify gcc -Wdouble-precision when using Xaw.
251 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
252 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
253 Use 'float' consistently, rather than 'float' in most places
254 and 'double' in a couple of places.
255
efc00ab1 2562012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
257
258 * xdisp.c (handle_stop): Detect whether we have overlay strings
259 loaded by testing it->current.overlay_string_index to be
260 non-negative, instead of checking whether n_overlay_strings is
261 positive. (Bug#11587)
262
efc00ab1 2632012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
264
265 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
266
267 * doc.c (Fsubstitute_command_keys): Doc fix.
268
efc00ab1 2692012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
270
271 * search.c (search_buffer): Remove calls to
272 r_alloc_inhibit_buffer_relocation, as it is now called by
273 maybe_unify_char, which was the cause of relocation of buffer text
274 in bug#11519.
275
efc00ab1 2762012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
277
278 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
279 for the duration of call to load_charset, to avoid problems with
280 callers of maybe_unify_char that access buffer text through C
281 pointers.
282
283 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
284 decrement the inhibition flag, instead of just setting or
285 resetting it.
286
ba93a187
PE
2872012-05-31 Paul Eggert <eggert@cs.ucla.edu>
288
289 Remove obsolete '#define static' cruft.
290 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
291 This #undef was "temporary" in 2000; it is no longer needed
292 now that '#define static' has gone away.
293 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
294 (gray_bitmap_bits): Remove; no longer needed.
295 All uses replaced with definiens.
296 * xterm.c: Include "bitmaps/gray.xbm".
297
9e4bf381
PE
2982012-05-30 Paul Eggert <eggert@cs.ucla.edu>
299
300 Clean up __executable_start, monstartup when --enable-profiling.
301 The following changes affect the code only when profiling.
302 * dispnew.c (__executable_start): Rename from safe_bcopy.
303 Define only on platforms that need it.
304 * emacs.c: Include <sys/gmon.h> when profiling.
305 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
306 (__executable_start): Remove decl, since lisp.h does it now.
307 (safe_bcopy): Remove decl; no longer has that name.
308 (main): Coalesce #if into single bit of code, for simplicity.
309 Cast pointers to uintptr_t, since standard libraries want integers
310 and not pointers.
311 * lisp.h (__executable_start): New decl.
312
32d72c2f
GM
3132012-05-31 Glenn Morris <rgm@gnu.org>
314
315 * image.c (Fimagemagick_types): Doc fix.
316
baac5bc7
JM
3172012-05-30 Jim Meyering <meyering@redhat.com>
318
319 * callproc.c (Fcall_process_region): Include directory component
320 in mkstemp error message (Bug#11586).
321
72cb32cf
PE
3222012-05-30 Paul Eggert <eggert@cs.ucla.edu>
323
324 * alloc.c, lisp.h (make_pure_vector): Now static.
325
61b108cc
SM
3262012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
327
328 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
329 Move to byte-run.el.
330 (Fautoload): Do the hash-doc more carefully.
331 * data.c (Fdefalias): Purify definition, except for keymaps.
332 (Qdefun): Move from eval.c.
333 * lisp.h (Qdefun): Remove.
334 * lread.c (read1): Tiny simplification.
335
471fe23d
TN
3362012-05-29 Troels Nielsen <bn.troels@gmail.com>
337
934f3f58 338 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
339 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
340 Bug#9642, but explicitly check that the buffer the overlay would
341 be moved to is live and rearrange lines to make sure that errors
342 will not put the overlay in an inconsistent state.
343 (Fdelete_overlay): Cosmetics.
344
85d0efd1
EZ
3452012-05-28 Eli Zaretskii <eliz@gnu.org>
346
347 * w32term.c (my_bring_window_to_top): New function.
348 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
349 could be different from the original one.
350 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
351 (Bug#11513)
352
353 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
354 by calling BringWindowToTop.
355
356 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
357 (WM_EMACS_END): Increase by one.
358
da92a98c
PE
3592012-05-28 Paul Eggert <eggert@cs.ucla.edu>
360
361 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
362 This avoids undefined behavior that might cause the eassert
363 to not catch an out-of-range value.
364
74d1f848
JB
3652012-05-28 Juanma Barranquero <lekktu@gmail.com>
366
367 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
368 Update dependencies.
369
9e1a06fc
EZ
3702012-05-27 Eli Zaretskii <eliz@gnu.org>
371
372 * bidi.c (bidi_mirror_char): Fix last change.
373
f3dd7312
AS
3742012-05-27 Andreas Schwab <schwab@linux-m68k.org>
375
376 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
377 when referring to sectname field in printf format.
378
81899c91
PE
3792012-05-27 Paul Eggert <eggert@cs.ucla.edu>
380
57b81a9f
PE
381 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
382 Only r_alloc_inhibit_buffer_relocation needed to be added;
383 the others were already declared.
384
81899c91
PE
385 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
386 before checking whether it's out of range. Put the check inside
387 eassert. See
388 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
389
33017faf 3902012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
391
392 * callproc.c (Fcall_process): Restore a line that was accidentally
393 commented out in the 2011-02-13 change (bug#11547).
394
33017faf 3952012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
396
397 * lisp.h [REL_ALLOC]: Add prototypes for external functions
398 defined on ralloc.c.
399
400 * buffer.c [REL_ALLOC]: Remove prototypes of
401 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
402 they are now on lisp.h.
403
404 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
405
406 * search.c (search_buffer): Use it to inhibit relocation of buffer
407 text while re_search_2 is doing its job, because re_search_2 is
408 passed C pointers to buffer text. (Bug#11519)
409
23415acf
EZ
410 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
411 Update value to 24.
412
44e27368
EZ
413 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
414 state after an additional call to move_it_in_display_line_to, keep
415 the values of it->max_ascent and it->max_descent found for the
416 entire line.
417 (pos_visible_p): Revert the comparison against bottom_y to what it
418 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
419 (Bug#11464)
420
c1892f11
PE
4212012-05-26 Paul Eggert <eggert@cs.ucla.edu>
422
423 Fix coding-related core dumps with gcc -ftrapv.
424 The code was computing A - B, where A and B are pointers, and B is
425 random garbage. This can lead to core dumps on platforms that
426 have special pointer registers, and it also leads to core dumps on
427 x86-64 when compiled with gcc -ftrapv. The fix is to compute
428 A - B only when B is initialized properly.
429 * coding.c (coding_set_source, coding_set_destination): Return void.
430 (coding_change_source, coding_change_destinations): New functions,
431 with the old behaviors of coding_set_source and coding_set_destination.
432 All callers that need an offset changed to use these new functions.
433
eb7afdad
GM
4342012-05-26 Glenn Morris <rgm@gnu.org>
435
436 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
437
f12fdf02
EZ
4382012-05-26 Eli Zaretskii <eliz@gnu.org>
439
53a63be6 440 Extend mouse support on W32 text-mode console.
61b108cc
SM
441 * xdisp.c (draw_row_with_mouse_face):
442 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 443
eb3f6f01 444 * w32console.c: Include window.h.
61b108cc
SM
445 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
446 New functions.
eb3f6f01
EZ
447 (initialize_w32_display): Initialize mouse-highlight data.
448
53a63be6
EZ
449 * w32inevt.c: Include termchar.h and window.h.
450 (do_mouse_event): Support mouse-autoselect-window. When the mouse
451 moves, call note_mouse_highlight. If help_echo changed, call
452 gen_help_event to produce help-echo message in the echo area.
453 Call clear_mouse_face if mouse_face_hidden is set in the mouse
454 highlight info.
455
4cfd81f6
PE
4562012-05-26 Paul Eggert <eggert@cs.ucla.edu>
457
458 * lread.c (read1): Simplify slightly to avoid an overflow warning
459 with GCC 4.7.0 on x86-64.
460
4446092a
EZ
4612012-05-26 Eli Zaretskii <eliz@gnu.org>
462
463 * bidi.c (bidi_mirror_char): Revert last change: an int is
464 definitely wide enough here.
465
42b2a986 4662012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 467
42b2a986 468 Fix integer width and related bugs (Bug#9874).
eb106a49 469 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
470 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
471 (string_bytes, check_sblock, allocate_string_data):
472 (compact_small_strings, Fmake_bool_vector, make_string)
473 (make_unibyte_string, make_multibyte_string)
474 (make_string_from_bytes, make_specified_string)
475 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
476 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
477 (mark_vectorlike):
478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
479 (allocate_pseudovector):
480 Use int, not EMACS_INT, where int is wide enough.
481 (inhibit_garbage_collection, Fgarbage_collect):
482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
483 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
484 int might not be wide enough.
485 (bidi_cache_search, bidi_cache_find, bidi_init_it)
486 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
487 (bidi_at_paragraph_end, bidi_find_paragraph_start)
488 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
489 (bidi_level_of_next_char, bidi_move_to_visually_next):
490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
491 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
492 (Fkill_buffer, Fset_buffer_major_mode)
493 (advance_to_char_boundary, Fbuffer_swap_text)
494 (Fset_buffer_multibyte, overlays_at, overlays_in)
495 (overlay_touches_p, struct sortvec, record_overlay_string)
496 (overlay_strings, recenter_overlay_lists)
497 (adjust_overlays_for_insert, adjust_overlays_for_delete)
498 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
499 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
500 (Foverlay_recenter, last_overlay_modification_hooks_used)
501 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
503 (validate_region): Omit unnecessary test for b <= e,
504 since that's guaranteed by the previous test.
d311d28c
PE
505 (adjust_overlays_for_delete): Avoid pos + length overflow.
506 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
507 (report_overlay_modification):
508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
509 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
510 Omit pointer cast, which isn't needed anyway, and doesn't work
511 after the EMACS_INT -> ptrdiff_t change.
02481186 512 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
513 * buffer.h: Adjust decls to match defn changes elsewhere.
514 (struct buffer_text, struct buffer):
515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
516 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
517 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
518 not int, to avoid needless 32-bit limit on 64-bit hosts.
519 (exec_byte_code): Use tighter memory-full test, one that checks
520 for alloca overflow. Don't compute the address of the object just
521 before an array, as that's not portable. Use EMACS_INT, not
522 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
523 * callint.c (Fcall_interactively):
524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
525 * callproc.c (call_process_kill, Fcall_process):
526 Don't assume pid_t fits into an Emacs fixnum.
527 (call_process_cleanup, Fcall_process, child_setup):
528 Don't assume pid_t fits into int.
529 (call_process_cleanup, Fcall_process, delete_temp_file)
530 (Fcall_process_region):
531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
532 (Fcall_process): Simplify handling of volatile integers.
533 Use int, not EMACS_INT, where int will do.
534 * casefiddle.c (casify_object, casify_region, operate_on_word)
535 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
537 (casify_object): Avoid integer overflow when overallocating buffer.
538 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 539 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
540 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
541 * category.h (CATEGORYP): Don't assume arg is nonnegative.
542 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
543 integers are now checked earlier. All uses replaced with XINT.
544 (ccl_driver):
545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
546 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
547 (ccl_driver, Fregister_code_conversion_map):
548 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
549 (resolve_symbol_ccl_program): Check that vector header is in range.
550 Always copy the vector, so that we can check its contents reliably
551 now rather than having to recheck each instruction as it's being
552 executed. Check that vector words fit in 'int'.
553 (ccl_get_compiled_code, Fregister_ccl_program)
554 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
555 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
556 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
557 contents are in range.
558 (Fccl_execute_on_string): Check that status is in range.
559 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
560 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
561 Accept and return EMACS_INT, not int, because callers can pass values
562 out of 'int' range.
563 (c_string_width, strwidth, lisp_string_width, chars_in_text)
564 (multibyte_chars_in_text, parse_str_as_multibyte)
565 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
566 (str_as_unibyte, str_to_unibyte, string_count_byte8)
567 (string_escape_byte8, Fget_byte):
568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 569 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
570 avoid mishandling large integers.
571 * character.h: Adjust decls to match defn changes elsewhere.
572 * charset.c (load_charset_map_from_file, find_charsets_in_text)
573 (Ffind_charset_region):
574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
575 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
576 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 577 Don't assume fixnum fits in int.
d311d28c
PE
578 (load_charset_map_from_vector, Fmap_charset_chars):
579 Remove now-unnecessary CHECK_NATNUMs.
580 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
581 Don't rely on undefined behavior with signed left shift overflow.
582 Don't assume unsigned int fits into fixnum, or that fixnum fits
583 into unsigned int. Don't require max_code to be a valid fixnum;
584 that's not true for gb10830 4-byte on a 32-bit host. Allow
585 invalid_code to be a cons, for the same reason. Require code_offset
586 to be a character. Avoid int overflow if max_char is close
587 to INT_MAX.
588 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
589 this is intended anyway and avoids some undefined behavior.
590 (load_charset_map): Pass unsigned, not int, as 2nd arg of
591 INDEX_TO_CODE_POINT, as that's what it expects.
592 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
593 * charset.h (DECODE_CHAR): Return int, not unsigned;
594 this is what was intended anyway, and it avoids undefined behavior.
595 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
596 integer-overflow issues.
597 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
598 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
599 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
600 * chartab.c (Fmake_char_table, Fset_char_table_range)
601 (uniprop_get_decoder, uniprop_get_encoder):
602 Don't assume fixnum fits in int.
603 * cmds.c (move_point): New function, that does the gist of
604 Fforward_char and Fbackward_char, but does so while checking
605 for integer overflow more accurately.
c96e5d6a 606 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
607 (Fforward_line, Fend_of_line, internal_self_insert)
608 (internal_self_insert):
609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
610 Fix a FIXME, by checking for integer overflow when calculating
611 target_clm and actual_clm.
612 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 613 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
614 (ASSURE_DESTINATION, coding_alloc_by_realloc)
615 (coding_alloc_by_making_gap, alloc_destination)
616 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
617 (encode_coding_utf_16, detect_coding_emacs_mule)
618 (decode_coding_emacs_mule, encode_coding_emacs_mule)
619 (detect_coding_iso_2022, decode_coding_iso_2022)
620 (encode_invocation_designation, encode_designation_at_bol)
621 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
622 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
623 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
624 (encode_coding_ccl, encode_coding_raw_text)
625 (detect_coding_charset, decode_coding_charset)
626 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
627 (produce_composition, produce_charset, produce_annotation)
628 (decode_coding, handle_composition_annotation)
629 (handle_charset_annotation, consume_chars, decode_coding_gap)
630 (decode_coding_object, encode_coding_object, detect_coding_system)
631 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
632 (code_convert_region, code_convert_string)
8f50130c
PE
633 (Fdefine_coding_system_internal)
634 (coding_set_source, coding_set_destination):
d311d28c
PE
635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
636 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
637 (Fdefine_coding_system_internal):
638 Don't assume fixnums fit in int.
639 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 640 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
641 (Funencodable_char_position, Fcheck_coding_systems_region)
642 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 644 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 645 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 646 Don't access memory outside of the args array.
d311d28c 647 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
648 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
649 result of ENCODE_CHAR.
d311d28c
PE
650 * coding.h: Adjust decls to match defn changes elsewhere.
651 (struct coding_system):
652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
653 * composite.c (get_composition_id, find_composition)
654 (run_composition_function, update_compositions)
655 (compose_text, composition_gstring_put_cache)
656 (composition_gstring_p, composition_gstring_width)
657 (fill_gstring_header, fill_gstring_body, autocmp_chars)
658 (composition_compute_stop_pos, composition_reseat_it)
659 (composition_update_it, struct position_record)
660 (find_automatic_composition, composition_adjust_point)
661 (Fcomposition_get_gstring, Ffind_composition_internal):
662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
663 (update_compositions):
664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
665 * composite.h: Adjust decls to match defn changes elsewhere.
666 (struct composition):
667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
668 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
669 Do not attempt to compute the address of the object just before a
670 buffer; this is not portable.
671 (Faref, Faset):
672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
673 (Faset): Use int, not EMACS_INT, where int is wide enough.
674 (Fstring_to_number): Don't assume fixnums fit in int.
675 (Frem): Don't assume arg is nonnegative.
676 * dbusbind.c (xd_append_arg): Check for integers out of range.
677 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 678 (extract_signed, extract_unsigned): New functions.
243e0530
PE
679 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
680 (xd_get_connection_references): Return ptrdiff_t, not int.
681 All uses changed.
682 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
683 (xd_read_message_1):
684 Use int, not unsigned, where the dbus API uses int.
685 (Fdbus_message_internal): Don't overflow mtype.
686 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
687 * dired.c (directory_files_internal, file_name_completion, scmp)
688 (file_name_completion_stat):
689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
690 (file_name_completion): Don't overflow matchcount.
691 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
692 * dispextern.h: Adjust decls to match defn changes elsewhere.
693 (struct text_pos, struct glyph, struct bidi_saved_info)
694 (struct bidi_string_data, struct bidi_it, struct composition_it)
695 (struct it):
696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
697 (struct display_pos, struct composition_it, struct it):
698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
699 * dispnew.c (increment_matrix_positions)
700 (increment_row_positions, mode_line_string)
701 (marginal_area_string):
702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 703 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
705 (duration_to_sec_usec): New function, to check for overflow better.
706 (Fsleep_for, sit_for): Use it.
707 * doc.c (get_doc_string, store_function_docstring):
708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
709 (get_doc_string, Fsnarf_documentation):
710 Use int, not EMACS_INT, where int is wide enough.
711 (get_doc_string):
712 Use SAFE_ALLOCA, not alloca.
713 Check for overflow when converting EMACS_INT to off_t.
714 * doprnt.c (doprnt):
715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
716 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
717 Don't assume uid_t fits into fixnum.
718 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
719 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
720 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
721 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
722 (general_insert_function)
723 (Finsert_char, make_buffer_string, make_buffer_string_both)
724 (update_buffer_properties, Fbuffer_substring)
725 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
726 (Fsubst_char_in_region, check_translation)
727 (Ftranslate_region_internal, save_restriction_restore, Fformat)
728 (transpose_markers, Ftranspose_regions):
729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
730 (clip_to_bounds): Move to lisp.h as an inline function).
731 (Fconstrain_to_field): Don't assume integers are nonnegative.
732 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
733 (Fsubst_char_in_region, Fsave_restriction):
734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
735 (Femacs_pid): Don't assume pid_t fits into fixnum.
736 (lo_time): Use int, not EMACS_INT, when int suffices.
737 (lisp_time_argument): Check for usec out of range.
738 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
739 (Fuser_login_name, Fuser_full_name): Signal an error
740 if a uid argument is out of range, rather than relying on
741 undefined behavior.
c8d5c857
PE
742 (Fformat_time_string): Remove now-unnecessary check.
743 lisp_time_argument checks for out-of-range usec now.
243e0530 744 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
745 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
746 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
747 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
748 (init_cmdargs, Fdump_emacs):
749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
750 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
751 the bottom (typically) 32 bits of the fixnum.
752 * eval.c (specpdl_size, call_debugger):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 (when_entered_debugger, Fbacktrace_debug):
755 Don't assume fixnum can fit in int.
756 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
757 the object just before a buffer; this is not portable.
758 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
759 (grow_specpdl, unbind_to):
760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
761 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
762 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 763 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
764 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
765 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
767 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
768 (a_write, e_write):
769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
770 (Fcopy_file, non_regular_nbytes, read_non_regular)
771 (Finsert_file_contents):
772 Use int, not EMACS_INT, where int is wide enough.
773 (READ_BUF_SIZE): Verify that it fits in int.
774 (Finsert_file_contents): Check that counts are in proper range,
775 rather than assuming fixnums fit into ptrdiff_t etc.
776 Don't assume fixnums fit into int.
125b3835 777 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
778 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
779 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
780 (string_char_to_byte, string_byte_to_char)
781 (string_make_multibyte, string_to_multibyte)
782 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
783 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
784 (substring_both, Fdelete, internal_equal, Ffillarray)
785 (Fclear_string, mapcar1)
786 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
787 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
788 (larger_vector, make_hash_table, maybe_resize_hash_table)
789 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
790 (Fmaphash, secure_hash):
791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
792 (concat): Check for string index and length overflow.
793 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
794 (Frequire):
795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
796 (larger_vector): New API (vec, incr_min, size_max) replaces old
797 one (vec, new_size, init). This catches size overflow.
798 INIT was removed because it was always Qnil.
799 All callers changed.
800 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
801 the upper bound on a hash table index size.
802 (make_hash_table, maybe_resize_hash_table): Use it.
803 (secure_hash): Computer start_byte and end_byte only after
804 they're known to be in ptrdiff_t range.
805 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
806 (Ffont_get_glyphs, Ffont_at):
807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
808 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
809 (Flist_fonts, Fopen_font):
810 Don't assume fixnum can fit in int.
811 (check_gstring): Don't assume index can fit in int.
812 (font_match_p): Check that fixnum is a character, not a nonnegative
813 fixnum, since the later code needs to stuff it into an int.
814 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
815 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
816 conversion overflow issues.
817 (Fopen_font): Check for integer out of range.
818 (Ffont_get_glyphs): Don't assume index can fit in int.
819 * font.h: Adjust decls to match defn changes elsewhere.
820 * fontset.c (reorder_font_vector): Redo score calculation to avoid
821 integer overflow.
822 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
823 printmax_t, where ptrdiff_t is wide enough.
824 (Finternal_char_font):
825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
826 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
827 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
828 (Fset_frame_position, x_set_frame_parameters)
829 (x_set_line_spacing, x_set_border_width)
830 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
831 Check that fixnums are in proper range for system types.
832 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
834 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
835 Use SAFE_ALLOCA_LISP, not alloca.
836 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
837 intptr_t is wide enough.
838 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
839 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
840 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
841 Check for fixnum out of range.
842 * ftfont.c (ftfont_list): Don't assume index fits in int.
843 Check that fixnums are in proper range for system types.
844 (ftfont_shape_by_flt):
845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
846 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
848 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
849 Check that fixnums are in proper range for system types.
850 * gnutls.h: Adjust decls to match defn changes elsewhere.
851 * gtkutil.c (xg_dialog_run):
852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
853 (update_frame_tool_bar):
854 Check that fixnums are in proper range for system types.
855 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 856 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
857 * indent.c (last_known_column, last_known_column_point):
858 (current_column_bol_cache):
859 (skip_invisible, current_column, check_display_width):
860 (check_display_width, scan_for_column, current_column_1)
861 (Findent_to, Fcurrent_indentation, position_indentation)
862 (indented_beyond_p, Fmove_to_column, compute_motion):
863 (Fcompute_motion, Fvertical_motion):
864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
865 (last_known_column_modified): Use EMACS_INT, not int.
866 (check_display_width):
867 (Fcompute_motion):
868 Check that fixnums and floats are in proper range for system types.
869 (compute_motion): Don't assume index or fixnum fits in int.
870 (compute_motion, Fcompute_motion):
871 Use int, not EMACS_INT, when it is wide enough.
872 (vmotion): Omit local var start_hpos that is always 0; that way
873 we don't need to worry about overflow in expressions involving it.
874 * indent.h: Adjust decls to match defn changes elsewhere.
875 (struct position):
876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
877 Use int, not EMACS_INT, where int is wide enough.
878 Remove unused members ovstring_chars_done and tab_offset;
879 all uses removed.
880 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
881 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
882 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
883 (make_gap, copy_text, insert, insert_and_inherit)
884 (insert_before_markers, insert_before_markers_and_inherit)
885 (insert_1, count_combining_before, count_combining_after)
886 (insert_1_both, insert_from_string)
887 (insert_from_string_before_markers, insert_from_string_1)
888 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
889 (adjust_after_replace, adjust_after_insert, replace_range)
890 (replace_range_2, del_range, del_range_1, del_range_byte)
891 (del_range_both, del_range_2, modify_region)
892 (prepare_to_modify_buffer, signal_before_change)
893 (signal_after_change, Fcombine_after_change_execute):
894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
895 * intervals.c (traverse_intervals, rotate_right, rotate_left)
896 (balance_an_interval, split_interval_right, split_interval_left)
897 (find_interval, next_interval, update_interval)
898 (adjust_intervals_for_insertion, delete_node, delete_interval)
899 (interval_deletion_adjustment, adjust_intervals_for_deletion)
900 (static_offset_intervals, offset_intervals)
901 (merge_interval_right, merge_interval_left, make_new_interval)
902 (graft_intervals_into_buffer, temp_set_point_both)
903 (temp_set_point, set_point, adjust_for_invis_intang)
904 (set_point_both, move_if_not_intangible, get_property_and_range)
905 (get_local_map, copy_intervals, copy_intervals_to_string)
906 (compare_string_intervals, set_intervals_multibyte_1):
907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
908 * intervals.h: Adjust decls to match defn changes elsewhere.
909 (struct interval):
910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
911 * keyboard.c (this_command_key_count, this_single_command_key_start)
912 (before_command_key_count, before_command_echo_length, echo_now)
913 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
914 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
915 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
916 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
918 (last_non_minibuf_size, last_point_position, echo_truncate)
919 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
920 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
921 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
922 (stuff_buffered_input):
923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
924 (last_auto_save, command_loop_1, read_char):
925 Use EMACS_INT, not int, to avoid integer overflow.
926 (record_char): Avoid overflow in total_keys computation.
927 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
928 * keyboard.h: Adjust decls to match defn changes elsewhere.
929 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
930 (Fkey_description, Fdescribe_vector, Flookup_key):
931 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
932 (click_position): New function, to check that positions are in range.
933 (Fcurrent_active_maps):
934 (describe_command):
935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
936 (Faccessible_keymaps, Fkey_description):
937 (preferred_sequence_p):
938 Don't assume fixnum can fit into int.
939 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
940 Check for integer overflow in size calculations.
941 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
942 avoid mishandling large integers.
943 * lisp.h: Adjust decls to match defn changes elsewhere.
944 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
945 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
946 (struct Lisp_Marker):
947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
948 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
949 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
950 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
951 All callers changed.
952 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
953 Assume the arg has valid form, since it always does.
954 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
955 unsigned integer system type.
956 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
957 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
959 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
960 (duration_to_sec_usec): New decl.
961 * lread.c (read_from_string_index, read_from_string_index_byte)
962 (read_from_string_limit, readchar, unreadchar, openp)
963 (read_internal_start, read1, oblookup):
964 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
965 (Fload, readevalloop, Feval_buffer, Feval_region):
966 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
967 (openp): Check for out-of-range argument to 'access'.
968 (read1): Use int, not EMACS_INT, where int is wide enough.
969 Don't assume fixnum fits into int.
6efdadfd 970 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
971 (read_filtered_event): Use duration_to_sec_usec
972 to do proper overflow checking on durations.
d311d28c
PE
973 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
974 in size calculation.
975 (Fexecute_kbd_macro):
976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
978 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
979 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
980 (set_marker_both, set_marker_restricted_both, marker_position)
981 (marker_byte_position, Fbuffer_has_markers_at):
982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
983 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 984 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
985 It now merely ensures that the menu is large enough, without
986 necessarily growing it, as this avoids some integer overflow issues.
987 All callers changed.
988 (keymap_panes, parse_single_submenu, Fx_popup_menu):
989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
990 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
991 Use SAFE_ALLOCA_LISP, not alloca.
992 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
993 to EMACS_INT. Check that fixnums are in proper range for system types.
994 * minibuf.c (minibuf_prompt_width, string_to_object)
995 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
996 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
998 (get_minibuffer, read_minibuf_unwind):
999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1000 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1001 this simplifies overflow checking. All callers changed.
1002 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1003 (Ftest_completion):
1004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1005 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1006 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1007 Check that fixnums are in proper range for system types.
1008 (Fx_create_frame, Fx_show_tip):
1009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1010 * nsfont.m (ns_findfonts, nsfont_list_family):
1011 Don't assume fixnum fits in long.
1012 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1014 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1015 wide enough.
17fdb222 1016 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1017 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1018 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1019 (PRINTDECLARE, PRINTPREPARE):
1020 (strout, print_string):
1021 (print, print_preprocess, print_check_string_charset_prop)
1022 (print_object):
1023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1024 (PRINTDECLARE):
1025 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1027 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1028 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1029 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1030 (print_error_message): Use SAFE_ALLOCA, not alloca.
1031 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1032 (print_depth, new_backquote_output, print_number_index):
1033 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1034 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1035 (Fset_process_window_size, Fformat_network_address)
1036 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1037 (sigchld_handler):
d311d28c 1038 Check that fixnums are in proper range for system types.
d44287d4 1039 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1040 Check for process-ids out of pid_t range rather than relying on
1041 undefined behavior.
e4d81efc 1042 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1043 (Fformat_network_address, read_process_output, send_process)
1044 (Fprocess_send_region, status_notify):
1045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1046 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1047 (wait_reading_process_output, read_process_output, exec_sentinel):
1048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1049 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1050 (Faccept_process_output): Use duration_to_sec_usec to do proper
1051 overflow checking on durations.
dde14581
PE
1052 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1053 Don't assume pid_t fits in int.
02481186
PE
1054 * process.h (struct Lisp_Process): Members tick and update_tick
1055 are now of type EMACS_INT, not int.
b62b53e8
PE
1056 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1057 configured --with-wide-int.
d311d28c
PE
1058 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1059 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1060 * search.c (looking_at_1, string_match_1):
1061 (fast_string_match, fast_c_string_match_ignore_case)
1062 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1063 (scan_newline, find_before_next_newline, search_command)
1064 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1065 (set_search_regs, wordify):
1066 (Freplace_match):
1067 (Fmatch_data):
1068 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1069 (string_match_1, search_buffer, set_search_regs):
1070 (Fmatch_data):
1071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1072 (wordify): Check for overflow in size calculation.
1073 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1074 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1075 Check that fixnums are in proper range for system types.
1076 * sound.c (struct sound_device)
1077 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1079 (Fplay_sound_internal):
1080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1081 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1082 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1083 (Fparse_partial_sexp):
1084 Don't assume fixnums can fit in int.
1085 (struct lisp_parse_state, find_start_pos, find_start_value)
1086 (find_start_value_byte, find_start_begv)
1087 (update_syntax_table, char_quoted, dec_bytepos)
1088 (find_defun_start, prev_char_comend_first, back_comment):
1089 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1090 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1092 (Finternal_describe_syntax_value): Check that match_lisp is a
1093 character, not an integer, since the code stuffs it into int.
1094 (scan_words, scan_sexps_forward):
1095 Check that fixnums are in proper range for system types.
1096 (Fforward_word):
1097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1098 (scan_sexps_forward):
1099 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1100 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1101 * syntax.h: Adjust decls to match defn changes elsewhere.
1102 (struct gl_state_s):
1103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1104 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1105 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1106 * sysdep.c (wait_for_termination_1, wait_for_termination)
1107 (interruptible_wait_for_termination, mkdir):
1108 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1109 (emacs_read, emacs_write):
1110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1111 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1112 and double all fit in int.
d311d28c
PE
1113 * term.c (set_tty_color_mode):
1114 Check that fixnums are in proper range for system types.
1115 * termhooks.h (struct input_event):
1116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1117 * textprop.c (validate_interval_range, interval_of)
1118 (Fadd_text_properties, set_text_properties_1)
1119 (Fremove_text_properties, Fremove_list_of_text_properties)
1120 (Ftext_property_any, Ftext_property_not_all)
1121 (copy_text_properties, text_property_list, extend_property_ranges)
1122 (verify_interval_modification):
1123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1124 (Fnext_single_char_property_change)
1125 (Fprevious_single_char_property_change):
1126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1127 (copy_text_properties):
1128 Check for integer overflow in index calculation.
d311d28c
PE
1129 * undo.c (last_boundary_position, record_point, record_insert)
1130 (record_delete, record_marker_adjustment, record_change)
1131 (record_property_change):
1132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1133 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1134 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1135 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1136 (Fx_hide_tip, Fx_file_dialog):
1137 * w32menu.c (set_frame_menubar):
1138 Use ptrdiff_t, not int, for consistency with rest of code.
1139 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1140 (select_window, Fdelete_other_windows_internal)
1141 (window_scroll_pixel_based, window_scroll_line_based)
1142 (Frecenter, Fset_window_configuration):
1143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1144 (Fset_window_hscroll, run_window_configuration_change_hook)
1145 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1146 (Fscroll_other_window, Frecenter):
d311d28c
PE
1147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1148 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1149 Don't assume fixnum fits in int.
1150 (Fset_window_scroll_bars):
1151 Check that fixnums are in proper range for system types.
1152 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1153 (string_pos, c_string_pos, number_of_chars, init_iterator)
1154 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1155 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1156 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1157 (face_before_or_after_it_pos, handle_invisible_prop)
1158 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1159 (display_prop_intangible_p, string_buffer_position_lim)
1160 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1161 (get_overlay_strings_1, get_overlay_strings)
1162 (iterate_out_of_display_property, forward_to_next_line_start)
1163 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1164 (get_next_display_element, set_iterator_to_next)
1165 (get_visually_first_element, compute_stop_pos_backwards)
1166 (handle_stop_backwards, next_element_from_buffer)
1167 (move_it_in_display_line_to, move_it_in_display_line)
1168 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1169 (add_to_log, message_dolog, message_log_check_duplicate)
1170 (message2, message2_nolog, message3, message3_nolog
1171 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1172 (current_message_1, truncate_echo_area, truncate_message_1)
1173 (set_message, set_message_1, store_mode_line_noprop)
1174 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1175 (text_outside_line_unchanged_p, check_point_in_composition)
1176 (reconsider_clip_changes)
1177 (redisplay_internal, set_cursor_from_row, try_scrolling)
1178 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1179 (redisplay_window, find_last_unchanged_at_beg_row)
1180 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1181 (trailing_whitespace_p, find_row_edges, display_line)
1182 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1183 (display_mode_element, store_mode_line_string)
1184 (pint2str, pint2hrstr, decode_mode_spec)
1185 (display_count_lines, display_string, draw_glyphs)
1186 (x_produce_glyphs, x_insert_glyphs)
1187 (rows_from_pos_range, mouse_face_from_buffer_pos)
1188 (fast_find_string_pos, mouse_face_from_string_pos)
1189 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1191 (safe_call, init_from_display_pos, handle_fontified_prop)
1192 (handle_single_display_spec, load_overlay_strings)
1193 (with_echo_area_buffer, setup_echo_area_for_printing)
1194 (display_echo_area, echo_area_display)
1195 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1196 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1197 (redisplay_window, dump_glyph_row, display_mode_line)
1198 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1199 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1201 (handle_single_display_spec, build_desired_tool_bar_string)
1202 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1203 (get_specified_cursor_type):
1204 Check that fixnums are in proper range for system types.
1205 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1206 (Flookup_image_map):
1207 Don't assume fixnums fit in int.
1208 (compare_overlay_entries):
1209 Avoid mishandling comparisons due to subtraction overflow.
1210 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1211 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1212 (handle_tool_bar_click):
1213 Use int, not unsigned, since we prefer signed and the signedness
1214 doesn't matter here.
1215 (get_next_display_element, next_element_from_display_vector):
1216 Use int, not EMACS_INT, when int is wide enough.
1217 (start_hourglass): Use duration_to_sec_usec to do proper
1218 overflow checking on durations.
1219 * xfaces.c (Fbitmap_spec_p):
1220 Check that fixnums are in proper range for system types.
1221 (compare_fonts_by_sort_order):
1222 Avoid mishandling comparisons due to subtraction overflow.
1223 (Fx_family_fonts, realize_basic_faces):
1224 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1225 (Fx_family_fonts):
1226 Don't assume fixnum fits in int.
1227 Use SAFE_ALLOCA_LISP, not alloca.
1228 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1229 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1230 (face_at_buffer_position, face_for_overlay_string)
1231 (face_at_string_position):
1232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1233 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1234 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1235 (Fx_show_tip):
1236 Check that fixnums are in proper range for system types.
1237 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1238 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1239 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1240 (Fx_change_window_property): Don't assume fixnums fit in int.
1241 * xfont.c (xfont_chars_supported):
1242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1243 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1244 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1246 * xml.c (parse_region):
1247 * xrdb.c (magic_file_p):
1248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1249 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1250 (x_get_local_selection, x_reply_selection_request)
1251 (x_handle_selection_request, wait_for_property_change):
1252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1253 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1254 short is wide enough.
1255 (x_send_client_event): Don't assume fixnum fits in int.
1256 * xterm.c (x_x_to_emacs_modifiers):
1257 Don't assume EMACS_INT overflows nicely into int.
1258 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1259 may come from Lisp.
1260 (handle_one_xevent): NATNUMP can eval its arg twice.
1261 (x_connection_closed):
1262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1263 * xterm.h: Adjust decls to match defn changes elsewhere.
1264 (struct scroll_bar): Use struct vectorlike_header
1265 rather than rolling our own approximation.
1266 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1267
c6574eb5
GM
12682012-05-25 Glenn Morris <rgm@gnu.org>
1269
1270 * lisp.mk (lisp): Update for more files being compiled now.
1271
e8d32c7e
SM
12722012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1273
48def666
SM
1274 * lread.c: Remove `read_pure' which makes no difference.
1275 (read_pure): Remove var.
1276 (unreadpure): Remove function.
1277 (readevalloop): Don't call read_list with -1 flag.
1278 (read1, read_vector): Don't test read_pure any more.
1279 (read_list): Simplify.
1280
e8d32c7e
SM
1281 * fileio.c, character.h: Minor style tweaks.
1282
4b2addb7
DA
12832012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1284
1285 * window.h (clip_changed): Remove useless declaration.
1286
584461b2
JB
12872012-05-22 Juanma Barranquero <lekktu@gmail.com>
1288
1289 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1290 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1291
34374650
PE
12922012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 Remove src/m/*.
1295 This directory predates autoconf and is no longer needed nowadays.
1296 Move its few remaining bits of functionality to where they're needed.
1297 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1298 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1299 * m/template.h: Remove.
1300 * Makefile.in (M_FILE): Remove. All uses removed.
1301 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1302 * lisp.h (USE_LSB_TAG):
1303 * mem-limits.h (EXCEEDS_LISP_PTR):
1304 Use VAL_MAX, not VALBITS, in #if.
1305 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1306 (EMACS_UINT): Define unconditionally now.
1307 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1308 (BITS_PER_EMACS_INT): New constants, replacing
1309 what used to be in config.h, but not useful in #if.
1310 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1311 define them any more.
1312 (VAL_MAX): New macro.
1313 (VALMASK): Use it.
1314 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1315 BITS_PER_EMACS_INT, in #if.
1316 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1317 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1318 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1319 * s/ms-w32.h (DATA_START):
1320 Move here from removed file m/intel386.h.
1321 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1322 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1323
261cb4bb
PE
13242012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 Assume C89 or later.
1327 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1328 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1329 (xrealloc):
1330 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1331 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1332 * textprop.c, tparam.c (NULL): Remove.
1333 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1334 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1335 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1336 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1337 * xterm.c (input_signal_count): Assume volatile works.
1338
ff23cd9f
KB
13392012-05-21 Ken Brown <kbrown@cornell.edu>
1340
1341 * xgselect.c (xg_select): Fix first argument in call to 'select'
1342 (bug#11508).
1343
1b170bc6
KB
13442012-05-20 Ken Brown <kbrown@cornell.edu>
1345
1346 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1347 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1348
b2f4d39f
KB
13492012-05-19 Ken Brown <kbrown@cornell.edu>
1350
1351 * xfns.c (x_in_use): Remove `static' qualifier.
1352 * xterm.h (x_in_use): Declare.
1353 * xgselect.c: Include xterm.h.
1354 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1355 and `display_arg' (bug#9754).
1356
003fdae2
PE
13572012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1358
9232a6d9
PE
1359 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1360
003fdae2
PE
1361 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1362 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1363
784b56e2
EZ
13642012-05-18 Eli Zaretskii <eliz@gnu.org>
1365
1366 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1367
1368 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1369 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1370
1371 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1372 reference to image_cache->refcount.
1373 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1374
a0a79cde
JL
13752012-05-17 Juri Linkov <juri@jurta.org>
1376
1377 * search.c (Fword_search_regexp, Fword_search_backward)
1378 (Fword_search_forward, Fword_search_backward_lax)
1379 (Fword_search_forward_lax): Move functions to isearch.el
1380 (bug#10145, bug#11381).
1381
b0572523
PE
13822012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1383
1384 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1385
9660f5fc
SM
13862012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1387
1388 * lread.c (init_obarray): Declare Qt and Qnil as special.
1389
4374de83
GM
13902012-05-14 Glenn Morris <rgm@gnu.org>
1391
1392 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1393 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1394
dc44c39a
PE
13952012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1396
078c97cb
PE
1397 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1398
dc44c39a
PE
1399 * unexaix.c: Port to more-recent AIX compilers.
1400 (report_error, report_error_1, make_hdr, copy_sym)
1401 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1402 Make arguments const char *, not char *, to avoid violations of C
1403 standard and to fix some AIX warnings reported by Gilles Pion.
1404
e18afed7 14052012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1406
1407 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1408 already have overlays loaded.
1409 (handle_single_display_spec): Before returning without displaying
1410 fringe bitmap, synchronize the bidi iterator with the main display
1411 iterator, by calling iterate_out_of_display_property.
1412 (iterate_out_of_display_property): Detect buffer iteration by
1413 testing that it->string is a Lisp string.
1414 (get_next_display_element): When the current object is exhausted,
1415 and there's something on it->stack, call set_iterator_to_next to
1416 proceed with what's on the stack, instead of returning zero.
1417 (set_iterator_to_next): If called at the end of a Lisp string,
1418 proceed to consider_string_end without incrementing string
1419 position. Don't increment display vector index past the end of
1420 the display vector. (Bug#11417)
c8fb9dc6
EZ
1421 (pos_visible_p): Don't report a position visible when move_it_to
1422 stopped at the last line of window, which happens to be scanned
1423 backwards by the bidi iteration. (Bug#11464)
ac268e67 1424
e18afed7 14252012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1426
1427 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1428 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1429 are on a TTY, and thus unable to display on the fringes.
1430 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1431 so we need to signal to the caller that this is a "replacing"
1432 display spec. This fixes display when the spec is invalid or we
1433 are on a TTY.
1434
e18afed7 14352012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1436
1437 * unexaix.c (make_hdr): Fix typo in prototype.
1438 This bug broke the build on AIX. Problem reported by Gilles Pion.
1439
9d0a235a
MA
14402012-05-14 Michael Albinus <michael.albinus@gmx.de>
1441
1442 * keyboard.c (kbd_buffer_get_event): Read special events also in
1443 batch mode. (Bug#11415)
1444
9e6b06ed
GM
14452012-05-12 Glenn Morris <rgm@gnu.org>
1446
1447 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1448
c1a1d7a3
EZ
14492012-05-12 Eli Zaretskii <eliz@gnu.org>
1450
1451 * lisp.mk (lisp): Add newcomment.elc.
1452
3fe7cdc8
GM
14532012-05-12 Glenn Morris <rgm@gnu.org>
1454
1455 * Makefile.in (MKDIR_P): New, set by configure.
1456 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1457
53f7d2c0
PE
14582012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1459
1460 Remove unused function hourglass_started.
1461 * dispextern.h (hourglass_started):
1462 * w32fns.c (hourglass_started):
1463 * xdisp.c (hourglass_started): Remove.
1464
75aafb17
JB
14652012-05-10 Juanma Barranquero <lekktu@gmail.com>
1466
1467 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1468 Update dependencies.
1469
12959e8e
PE
14702012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1471
97107e2e
PE
1472 * xgselect.c (xg_select): Put maxfds+1 into a var.
1473 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1474
12959e8e
PE
1475 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1476
836d29b3
DA
14772012-05-10 Dave Abrahams <dave@boostpro.com>
1478
1479 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1480 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1481
5cb67954
MA
14822012-05-09 Michael Albinus <michael.albinus@gmx.de>
1483
1484 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1485 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1486 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1487 Initialize xd_registered_buses.
1488
3478ec45
PE
14892012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1490
b263a6b0
PE
1491 Untag more efficiently if USE_LSB_TAG.
1492 This is based on a proposal by YAMAMOTO Mitsuharu in
1493 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1494 For an admittedly artificial (nth 8000 longlist) benchmark on
1495 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1496 Emacs's overall text size by 1%.
1497 * lisp.h (XUNTAG): New macro.
1498 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1499 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1500 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1501 * eval.c (Fautoload):
1502 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1503 * frame.h (XFRAME): Use XUNTAG.
1504
3478ec45
PE
1505 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1506 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1507 Remove unportable assumptions about print widths of types like
1508 dbus_uint32_t.
1509 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1510 intptr_t when converting between pointer and integer, to avoid GCC
1511 warnings about wrong width.
1512
666b903b 15132012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1514
1515 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1516 stack for each reader_thread, instead of defaulting to 8MB
1517 determined by the linker. This avoids failures in creating
1518 subprocesses on Windows 7, see the discussion in this thread:
1519 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1520
b120cc17
JC
15212012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1522
1523 Fix up display of the *Minibuf-0* buffer in the mini window.
1524 * keyboard.c (read_char): Don't clear the echo area if there's no
1525 message to clear.
1526 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1527 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1528
9a4b36f8
MA
15292012-05-07 Michael Albinus <michael.albinus@gmx.de>
1530
1531 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1532 batch mode.
1533
e5f9458f
CY
15342012-05-06 Chong Yidong <cyd@gnu.org>
1535
1536 * lisp.mk (lisp): Update.
1537
eceeb5fc 15382012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1539
1540 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1541
71873e2b
SM
15422012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1543
1544 * data.c (PUT_ERROR): New macro.
1545 (syms_of_data): Use it. Add new error type `user-error'.
1546 * undo.c (user_error): New function.
1547 (Fprimitive_undo): Use it.
1548 * print.c (print_error_message): Adjust print style for `user-error'.
1549 * keyboard.c (user_error): New function.
1550 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1551
ab0fa4e4
PE
15522012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 Do not limit current-time-string to years 1000..9999.
1555 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1556 (Fcurrent_time_string): Support any year that is supported by the
1557 underlying localtime representation. Don't use asctime, as it
1558 has undefined behavior for years outside the range -999..9999.
1559
7ed806a7
PE
15602012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 Fix race conditions involving setenv, gmtime, localtime, asctime.
1563 Without this fix, interrupts could mess up code that uses these
1564 nonreentrant functions, since setting TZ invalidates existing
1565 tm_zone or tzname values, and since most of these functions return
1566 pointers to static storage.
1567 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1568 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1569 Grow the critical sections to include not just invoking
1570 localtime/gmtime, but also accessing these functions' results
1571 including their tm_zone values if any, and any related TZ setting.
1572 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1573 so that the struct tm is saved in the critical section.
1574 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1575 motivated by the fact that memory allocation needs to be outside
1576 the critical section.
1577
0c16dfed
DA
15782012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1579
1580 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1581 with RESET_INTERVAL.
1582
1583 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1584 Remove duplicated buffer name initialization.
1585
3f83ace8
JM
15862012-05-02 Jim Meyering <jim@meyering.net>
1587
1588 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1589
c7b8541e
JM
1590 * xfns.c (x_window): Use xstrdup (Bug#11375).
1591
90207a15 15922012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1593
1594 * xdisp.c (pos_visible_p): If already at a newline from the
1595 display string before the 'while' loop, don't walk back the glyphs
1596 from it3.glyph_row. Solves assertion violation when the display
1597 string begins with a newline (egg.el). (Bug#11367)
1598
b593d6a9
AH
15992012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1600
1601 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1602 Move to simple.el.
1603
4737362e
GM
16042012-05-01 Glenn Morris <rgm@gnu.org>
1605
99cf43f9
GM
1606 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1607 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1608 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1609 All were removed before 23.1.
1610
9311dcff
GM
1611 * dispnew.c: Remove HAVE_LIBNCURSES test;
1612 it is always true on relevant platforms.
1613
4d5c6349
GM
1614 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1615 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1616
4737362e
GM
1617 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1618
74dd3a6b
AS
16192012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1620
1621 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1622 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1623 Remove.
1624
13c379ee
PE
16252012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1626
1627 Do not avoid creating empty evaporating overlays (Bug#9642).
1628 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1629 That is, do not delete an evaporating overlay if it becomes
1630 empty after its bounds are adjusted to fit within its buffer.
1631 This fix caused other problems, and I'm reverting it until we get
1632 to the bottom of them.
1633
a8e7d6d7 16342012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1635
1636 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1637
a8e7d6d7 16382012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1639
1640 * xdisp.c (pos_visible_p): If the window start position is beyond
1641 ZV, start the display from buffer beginning. Prevents assertion
1642 violation in init_iterator when the minibuffer window is scrolled
1643 via the scroll bar.
1644
1645 * window.c (window_scroll_pixel_based): Likewise.
1646
a8e7d6d7 16472012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1648
1649 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1650
a8e7d6d7 16512012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1652
1653 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1654 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1655
a8e7d6d7 16562012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1657
b593d6a9
AH
1658 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1659 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1660
1c6900d9
EZ
16612012-04-26 Eli Zaretskii <eliz@gnu.org>
1662
4c3fa1d9
EZ
1663 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1664 display element, check also the underlying string or buffer
1665 character. (Bug#11341)
1666
1c6900d9
EZ
1667 * w32menu.c: Include w32heap.h.
1668 (add_menu_item): If the call to AppendMenuW (via
1669 unicode_append_menu) fails, disable Unicode menus only if we are
1670 running on Windows 9X/Me.
1671
42bf8205
AS
16722012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1673
1674 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1675 (xgetint): Add missing shift for LSB tags.
1676
b1bac16e
MR
16772012-04-24 Martin Rudalics <rudalics@gmx.at>
1678
1679 * keyboard.c (read_char): Don't wipe echo area for select window
1680 events: These might get delayed via `mouse-autoselect-window'
1681 (Bug#11304).
1682
d69621cc
JB
16832012-04-24 Juanma Barranquero <lekktu@gmail.com>
1684
1685 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1686 manipulation of :loaded-from data.
1687
02fd101b
JB
16882012-04-23 Juanma Barranquero <lekktu@gmail.com>
1689
1690 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1691 now a cons (bug#11311).
1692
888bec30
PE
16932012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1694
89a438bd
PE
1695 Do not create empty overlays with the evaporate property (Bug#9642).
1696 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1697 if it becomes empty after its bounds are adjusted to fit within
1698 its buffer. Without this fix, in a nonempty buffer (let ((o
1699 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1700 yields an empty overlay that has the evaporate property, which is
1701 not supposed to happen.
1702
1068fe4d
PE
1703 Fix minor GTK3 problems found by static checking.
1704 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1705 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1706 (struct _EmacsFixedClass, emacs_fixed_get_type):
1707 Move decls here from emacsgtkfixed.h, since they needn't be public.
1708 (emacs_fixed_get_type): Now static.
1709 (emacs_fixed_class_init): Omit unused local.
1710 (emacs_fixed_child_type): Remove; unused.
1711 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1712 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1713 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1714 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1715 (EMACS_FIXED_GET_CLASS): Remove; unused.
1716 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1717
888bec30
PE
1718 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1719 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1720
de85e130
PE
17212012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1722
d0baac98 1723 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1724 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1725 (__malloc_size_t, __malloc_ptrdiff_t):
1726 Remove. All uses removed, replaced by the definiens if needed,
1727 since we can assume C89 or better now.
1728 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1729 (protect_malloc_state, align, get_contiguous_space)
1730 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1731 (malloc_atfork_handler_child, malloc_enable_thread)
1732 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1733 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1734 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1735 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1736 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1737 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1738 Define using prototypes, not old style.
1739 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1740 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1741 (align): Don't assume that signed integer overflow wraps around.
1742 Omit unused local var.
1743 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1744 (_free_internal_nolock, memalign, mallochook, reallochook):
1745 Omit no-longer-needed casts.
1746 (valloc): Use getpagesize, not __getpagesize.
1747 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1748 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1749
de85e130
PE
1750 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1751
dcbf5805
MA
17522012-04-22 Michael Albinus <michael.albinus@gmx.de>
1753
1754 Move functions from C to Lisp. Make non-blocking method calls
1755 the default. Implement further D-Bus standard interfaces.
1756
1757 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1758 (QCdbus_request_name_allow_replacement)
1759 (QCdbus_request_name_replace_existing)
1760 (QCdbus_request_name_do_not_queue)
1761 (QCdbus_request_name_reply_primary_owner)
1762 (QCdbus_request_name_reply_in_queue)
1763 (QCdbus_request_name_reply_exists)
1764 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1765 (QCdbus_registered_serial, QCdbus_registered_method)
1766 (QCdbus_registered_signal): New Lisp objects.
1767 (XD_DEBUG_MESSAGE): Use sizeof.
1768 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1769 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1770 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1771 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1772 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1773 (xd_signature, xd_append_arg): Allow float for integer types.
1774 (xd_get_connection_references): New function.
b593d6a9
AH
1775 (xd_get_connection_address): Rename from xd_initialize.
1776 Return cached address.
dcbf5805
MA
1777 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1778 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1779 level.
1780 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1781 Return number of refcounts.
dcbf5805
MA
1782 (Fdbus_get_unique_name): Make stronger parameter check.
1783 (Fdbus_message_internal): New defun.
1784 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1785 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1786 (Fdbus_send_signal, Fdbus_register_service)
1787 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1788 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1789 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1790 (Vdbus_compiled_version, Vdbus_runtime_version)
1791 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1792 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1793 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1794 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1795 Adapt docstring.
dcbf5805 1796
52828e02
PE
17972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1798
da05bc4c
PE
1799 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1800 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1801 Do not assume ptrdiff_t is the same width as 'int'.
1802
52828e02
PE
1803 * alloc.c: Handle unusual debugging option combinations.
1804 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1805 since the two debugging options are incompatible.
1806 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1807 is defined.
1808 (mem_init, mem_insert, mem_insert_fixup):
1809 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1810 (NEED_MEM_INSERT): Remove; no longer needed.
1811
f01769f9
LL
18122012-04-22 Leo Liu <sdl.web@gmail.com>
1813
1814 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1815
5790543d
PE
18162012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1817
1818 * sysdep.c [__FreeBSD__]: Minor cleanups.
1819 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1820 Use Emacs indenting style more consistently. Avoid some casts.
1821 Use 'double' consistently rather than mixing 'float' and 'double'.
1822
b91b7e4d
EW
18232012-04-21 Eduard Wiebe <usenet@pusto.de>
1824
b593d6a9
AH
1825 * sysdep.c (list_system_processes, system_process_attributes):
1826 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1827
6114eb15
AS
18282012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1829
1830 * lisp.mk (lisp): Update.
1831
2f38dff7
PE
18322012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1833
1834 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1835 It is never used otherwise.
1836
4ae29f89
SM
18372012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1838
1839 * print.c (print_preprocess): Only check print_depth if print-circle
1840 is nil.
1841 (print_object): Check for cycles even when print-circle is nil and
1842 print-gensym is t, but only check print_depth if print-circle is nil.
1843
f30d612a
CY
18442012-04-20 Chong Yidong <cyd@gnu.org>
1845
1846 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1847 set the status to "failed" and ensure that sentinel is run.
1848
c07a4c0b 18492012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1850
1851 * process.c (Fset_process_inherit_coding_system_flag)
1852 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1853 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1854
c07a4c0b 18552012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1856
1857 * xdisp.c (string_buffer_position_lim): Limit starting position to
1858 BEGV.
1859 (set_cursor_from_row): If called for a mode-line or header-line
1860 row, return zero immediately.
1861 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1862 farther than the first row after the header line, if any.
1863 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1864 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1865
c07a4c0b 18662012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1867
4ae29f89
SM
1868 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1869 (bug#11238).
ad3a2b41 1870
c07a4c0b 18712012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 18722012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1873
1874 configure: new option --enable-gcc-warnings (Bug#11207)
1875 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1876 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1877 (ALL_CFLAGS): Use new macros rather than old.
1878 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1879 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1880 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1881 -Wunused-result, -Wunused-variable. This should go away once
1882 the Emacs and Gnulib regex code is merged.
1883 (xmalloc, xrealloc): Now static.
1884
aba027e8
PE
18852012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1886
1887 * dired.c (Fsystem_groups): Remove unused local.
1888
e5a36063
GM
18892012-04-17 Glenn Morris <rgm@gnu.org>
1890
1891 * dired.c (Fsystem_users): Doc fix.
1892
316411f0
DA
18932012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1894
1895 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1896 (syms_of_dired): Add them.
1897
9426aba4
PE
18982012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1899
b62a57be
PE
1900 Fix minor alloc.c problems found by static checking.
1901 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1902 New extern decls, to avoid calling undeclared functions.
1903 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1904 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1905 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1906 (NEED_MEM_INSERT): New macro.
1907 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1908 Remove one incorrect comment and fix another.
b62a57be 1909
3539f31f
PE
1910 Fix minor ralloc.c problems found by static checking.
1911 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1912 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1913 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1914 (r_alloc_sbrk): Now static.
1915
a041960a
PE
1916 Improve ralloc.c interface checking.
1917 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1918 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1919 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1920 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1921 [REL_ALLOC]: ... to here, to check interface.
1922 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1923 Remove decls. This fixes an "It stinks!".
1924
9426aba4
PE
1925 * alloc.c (which_symbols): Fix alignment issue / type clash.
1926
d55c12ed
AS
19272012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1928
1929 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1930 (struct Lisp_Misc_Any): Likewise.
1931 (struct Lisp_Free): Likewise.
1932 * alloc.c (union aligned_Lisp_Symbol): Define.
1933 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1934 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1935 (union aligned_Lisp_Misc): Define.
1936 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1937 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1938 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1939
b948ce8b
PE
19402012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1943 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1944 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1945 * s/netbsd.h, s/sol2-6.h:
1946 Remove definition of GC_MARK_STACK, since the default now works.
1947 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1948 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1949 no longer the default.
1950 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1951
35dc09a1 19522012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1953
35dc09a1
GM
1954 * lread.c (lisp_file_lexically_bound_p):
1955 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1956
35dc09a1
GM
19572012-04-14 Eli Zaretskii <eliz@gnu.org>
1958
1959 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1960 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1961
19622012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1963
1964 * nsterm.m (constrainFrameRect): Always constrain when there is only
1965 one screen (Bug#10962).
1966
bcd86815
KB
19672012-04-13 Ken Brown <kbrown@cornell.edu>
1968
1969 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1970
c25df26e
RT
19712012-04-13 Reuben Thomas <rrt@sc3d.org>
1972
1973 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1974
0fc59f1e
DC
19752012-04-11 Daniel Colascione <dancol@dancol.org>
1976
1977 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1978 against is gone. It's better to use vfork now so that when Cygwin
1979 gains a new, working vfork, we use it automatically (bug#10398).
1980
de8c03dc
SM
19812012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1982
1983 * window.c (save_window_save): Obey window-point-insertion-type.
1984
2f097256
GM
19852012-04-11 Glenn Morris <rgm@gnu.org>
1986
1987 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1988
453b951e
SM
19892012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1990
1991 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1992
75f1671a 19932012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1994
1995 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1996 (force_quit_count): New var.
1997 (handle_interrupt): Use it.
1998
2a8ce227
JB
19992012-04-10 Juanma Barranquero <lekktu@gmail.com>
2000
2001 * w32.c (w32_delayed_load): Record the full path of the library
2002 being loaded (bug#10424).
2003
935396c0
GM
20042012-04-09 Glenn Morris <rgm@gnu.org>
2005
05920a43
GM
2006 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2007 not just in the obarray, before snarfing them. (Bug#11036)
2008
935396c0
GM
2009 * Makefile.in ($(leimdir)/leim-list.el):
2010 Pass EMACS rather than BUILT_EMACS.
2011
a18ecafa
TZ
20122012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2013
2014 * process.c (make_process):
2015 * process.h: Add integer `gnutls_handshakes_tried' member to
2016 process struct.
2017
6bbef4e5
JC
2018 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2019 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2020
2021 * gnutls.c (gnutls_log_function2i): Convenience log function.
2022 (emacs_gnutls_read): Use new log functions,
2023 `gnutls_handshakes_tried' process member, and
2024 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2025 attempts per process (connection).
2026
b4d3bc10
CY
20272012-04-09 Chong Yidong <cyd@gnu.org>
2028
2029 * eval.c (Fuser_variable_p, user_variable_p_eh)
2030 (lisp_indirect_variable): Functions deleted.
2031 (Fdefvar): Caller changed.
2032
2033 * callint.c (Finteractive, Fcall_interactively):
2034 * minibuf.c (Fread_variable): Callers changed.
2035
70f4d973
EZ
20362012-04-09 Eli Zaretskii <eliz@gnu.org>
2037
2038 * xdisp.c (set_cursor_from_row): If the display string appears in
2039 the buffer at position that is closer to point than the position
2040 after the display string, display the cursor on the first glyph of
2041 the display string. Fixes cursor display when a 'display' text
2042 property immediately follows invisible text. (Bug#11094)
2043
cb3c2e3e
PE
20442012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 composite.c: use 'double' consistently
2047 * composite.c (get_composition_id): Use 'double' consistently
2048 instead of converting 'float' to 'double' and vice versa; this is
2049 easier to understand and avoids a GCC warning.
2050
fd06db5d
GM
20512012-04-09 Glenn Morris <rgm@gnu.org>
2052
50fe702a
GM
2053 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2054 preparation for dumping it with emacs. (Bug#4789)
2055 (leimdir): New variable.
2056 ($(leimdir)/leim-list.el): New rule.
2057 (emacs$(EXEEXT)): Depend on leim-list.el.
2058
fd06db5d
GM
2059 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2060 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2061 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2062
55c131ee
AS
20632012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2064
2065 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2066 proper alignment.
2067
9209588f
JB
20682012-04-07 Juanma Barranquero <lekktu@gmail.com>
2069
2070 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2071 Remove unused local variable.
2072
e3fb2efb
PE
20732012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2074
2075 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2076 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2077 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2078 objects, as mark_maybe_pointer will catch them otherwise.
2079 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2080 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2081
b5385551
PE
20822012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2083
2084 Fix typo that broke non-Windows builds.
2085 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2086
9078ead6
EZ
20872012-04-07 Eli Zaretskii <eliz@gnu.org>
2088
2089 Support building on MS-Windows with libxml2.
2090
2091 * makefile.w32-in (OBJ2): Add xml.$(O).
2092 (GLOBAL_SOURCES): Add xml.c.
2093 ($(BLD)/xml.$(O)): New dependency list.
2094
2095 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2096 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2097 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2098 [!WINDOWSNT]: New macros.
2099 (init_libxml2_functions, libxml2_loaded_p): New functions.
2100 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2101 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2102 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2103 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2104 linked in).
6bbef4e5
JC
2105 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2106 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2107 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2108
2109 * emacs.c: Don't include libxml/parser.h.
2110 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2111 xmlCleanupParser directly.
2112
2113 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2114
3811fdf3
EZ
21152012-04-07 Eli Zaretskii <eliz@gnu.org>
2116
2117 * indent.c (Fvertical_motion): If there is a display string at
2118 point, use it.vpos to compute how many lines to backtrack after
2119 move_it_to point. (Bug#11133)
2120
2f8e16b2
EZ
21212012-04-06 Eli Zaretskii <eliz@gnu.org>
2122
2123 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2124 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2125 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2126 macros related to unification of CJK characters. For the details,
2127 see the discussion following the message here:
2128 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2129
3d439cd1
CY
21302012-04-04 Chong Yidong <cyd@gnu.org>
2131
2132 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2133
8bc53d00
EZ
21342012-04-01 Eli Zaretskii <eliz@gnu.org>
2135
2136 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2137 instead of alloca. (Bug#11138)
2138
3b0512a3
AS
21392012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2140
2141 * w32menu.c (is_simple_dialog): Properly check lisp types.
2142 (Bug#11141)
2143
8427ddd2
EZ
21442012-03-31 Eli Zaretskii <eliz@gnu.org>
2145
979022ef
EZ
2146 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2147 position we get to after a call to move_it_to fails the
2148 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2149 only if we wind up in a string from display property. (Bug#11063)
2150
a6b1c7cc
EZ
2151 * window.c (Fdelete_other_windows_internal): Invalidate the row
2152 and column information about mouse highlight, so that redisplay
2153 restores it after reallocating the glyph matrices. (Bug#7464)
2154
8427ddd2
EZ
2155 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2156 string comes from a `display' text property, use the buffer
2157 position of that property as if we actually saw that position in
2158 the row's glyphs.
697ba24b
EZ
2159 (move_it_by_lines): Remove the assertion that
2160 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2161 violated when there's a before-string at the beginning of a line.
2162 (Bug#11063)
8427ddd2 2163
65a0a738
EZ
21642012-03-30 Eli Zaretskii <eliz@gnu.org>
2165
2166 * xdisp.c (append_space_for_newline): If the default face was
2167 remapped, use the remapped face for the appended newline.
2168 (extend_face_to_end_of_line): Use the remapped default face for
2169 extending the face to the end of the line.
2170 (display_line): Call extend_face_to_end_of_line when the default
2171 face was remapped. (Bug#11068)
2172
581355cc
EZ
21732012-03-29 Eli Zaretskii <eliz@gnu.org>
2174
2175 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2176
e8fc049f
SM
21772012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2178
2179 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2180
4fb9a543
GM
21812012-03-27 Glenn Morris <rgm@gnu.org>
2182
2183 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2184 Doc fixes.
2185
679910f1
KH
21862012-03-26 Kenichi Handa <handa@m17n.org>
2187
2188 * dispextern.h (struct glyph): Fix previous change. Change the
2189 bit length of glyphless.ch to 25 (Bug#11082).
2190
90d49b7f
CY
21912012-03-26 Chong Yidong <cyd@gnu.org>
2192
2193 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2194 (command_loop_1): Use it; inhibit selection update for
2195 handle-select-window too (Bug#8996).
2196
f514f6f0
FP
21972012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2198
e8fc049f 2199 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2200
bf43fa51
KH
22012012-03-25 Kenichi Handa <handa@m17n.org>
2202
2203 * dispextern.h (struct glyph): Change the bit length of
2204 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2205
8a0c01dd
EZ
22062012-03-24 Eli Zaretskii <eliz@gnu.org>
2207
2208 * s/ms-w32.h (tzname): Include time.h before redirecting to
2209 _tzname. Fixes the MSVC build. (Bug#9960)
2210
7d1c3a76
AS
22112012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2212
8ed79523
AS
2213 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2214 characters.
2215
7d1c3a76
AS
2216 * xterm.c (XTread_socket): Only modify handling_signal if
2217 !SYNC_INPUT. (Bug#11080)
2218
e99a9b8b
EZ
22192012-03-23 Eli Zaretskii <eliz@gnu.org>
2220
2221 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2222 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2223 when fetching a multibyte character consumes more bytes than
2224 CHAR_BYTES returns, due to unification of CJK characters in
2225 string_char. (Bug#11073)
2226
5063c0e1
TN
22272012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2228
2229 * process.c (wait_reading_process_output): Handle pty disconnect
2230 by refraining from sending oneself a SIGCHLD (bug#10933).
2231
9f851fbd
CY
22322012-03-22 Chong Yidong <cyd@gnu.org>
2233
2234 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2235
5063c0e1 2236 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2237 Mark string as coming from a prefix property.
2238 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2239 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2240
fb5b8aca
CY
22412012-03-21 Chong Yidong <cyd@gnu.org>
2242
2243 * xfaces.c (Vface_remapping_alist): Doc fix.
2244
62356a1b
EZ
22452012-03-20 Eli Zaretskii <eliz@gnu.org>
2246
2247 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2248 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2249 Doc fixes.
62356a1b 2250
025de85b
CY
22512012-03-20 Chong Yidong <cyd@gnu.org>
2252
2253 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2254 to reflect default non-nil value of redisplay-dont-pause.
2255
4827f94e
KH
22562012-03-19 Kenichi Handa <handa@m17n.org>
2257
2258 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2259 it fit in a valid range (Bug#11003).
2260
e50a24a2
EZ
22612012-03-18 Eli Zaretskii <eliz@gnu.org>
2262
2263 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2264 that is not from display property, accept the row as a "cursor
2265 row" if one of the string's character has a non-nil `cursor'
2266 property. Fixes cursor positioning when there are newlines in
2267 overlay strings, e.g. in icomplete.el. (Bug#11035)
2268
9af5ed87
PE
22692012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2270
2271 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2272
d1f55f16
CY
22732012-03-12 Chong Yidong <cyd@gnu.org>
2274
2275 * eval.c (inhibit_lisp_code): Rename from
2276 inhibit_window_configuration_change_hook; move from window.c.
2277
2278 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2279 * window.c (run_window_configuration_change_hook)
2280 (syms_of_window): Callers changed.
2281
66c5eebd
CY
22822012-03-11 Chong Yidong <cyd@gnu.org>
2283
413df973
CY
2284 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2285
66c5eebd
CY
2286 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2287
1de11f56
CY
22882012-03-10 Chong Yidong <cyd@gnu.org>
2289
2290 * frame.c (other_visible_frames): Don't assume the selected frame
2291 is visible (Bug#10955).
2292
cae07000
SM
22932012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2294
2295 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2296
89c94350
JD
22972012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2298
2299 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2300 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2301 zero (Bug#10954).
2302
999dd333
GM
23032012-03-03 Glenn Morris <rgm@gnu.org>
2304
01a6dcc8 2305 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2306
de0100f2
EZ
23072012-03-02 Eli Zaretskii <eliz@gnu.org>
2308
2309 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2310 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2311 (redisplay_window, next_element_from_string): Fix typos in
2312 comments.
3e441275
EZ
2313 (redisplay_window): Pass to move_it_vertically the margin in
2314 pixels, not in screen lines.
de0100f2 2315
96a72ee9
GM
23162012-03-02 Glenn Morris <rgm@gnu.org>
2317
2318 * buffer.c (buffer-list-update-hook): Doc fix.
2319
312508d7
EZ
23202012-02-29 Eli Zaretskii <eliz@gnu.org>
2321
2322 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2323 push_it before setting up the iterator for the first overlay
2324 string, even if we have an empty string loaded.
2325 (next_overlay_string): If there's an empty string on the iterator
2326 stack, pop the stack. (Bug#10903)
2327
27f3c637
PE
23282012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2329
2330 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2331 Suggested by Stefan Monnier in
2332 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2333 * alloc.c (widen_to_Lisp_Object): New static function.
2334 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2335 and widening them to Lisp_Objects. This would work even if
2336 USE_LSB_TAG is defined and wide integers are used, which might
2337 happen in a future version of Emacs.
2338
3c9dfce6
CY
23392012-02-25 Chong Yidong <cyd@gnu.org>
2340
fa74b241
CY
2341 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2342 Doc fix.
2343
3c9dfce6
CY
2344 * xselect.c (Fx_selection_exists_p): Doc fix.
2345 (x_clipboard_manager_save_all): Print an informative message
2346 before saving to clipboard manager.
2347
9486df08
CY
23482012-02-24 Chong Yidong <cyd@gnu.org>
2349
2350 * keyboard.c (process_special_events): Handle all X selection
2351 requests in kbd_buffer, not just the next one (Bug#8869).
2352
f01d3321
CY
23532012-02-23 Chong Yidong <cyd@gnu.org>
2354
2355 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2356 call when setting menu-bar-lines and tool-bar-lines parameters.
2357 (unwind_create_frame_1): New helper function.
2358
2359 * window.c (inhibit_window_configuration_change_hook): New var.
2360 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2361 (syms_of_window): Initialize it.
f01d3321 2362
86b847b6
CY
23632012-02-22 Chong Yidong <cyd@gnu.org>
2364
2365 * xterm.c (x_draw_image_relief): Add missing type check for
2366 Vtool_bar_button_margin (Bug#10743).
2367
a59225b1
CY
23682012-02-21 Chong Yidong <cyd@gnu.org>
2369
2370 * fileio.c (Vfile_name_handler_alist): Doc fix.
2371
2372 * buffer.c (Fget_file_buffer): Protect against invalid file
2373 handler return value.
2374
310f5bd4
PE
23752012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2376
cb3a28cc
PE
2377 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2378 when computing $valmask.
2379
310f5bd4
PE
2380 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2381 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2382 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2383 It's useless in that case, and it can cause problems on hosts
2384 that allocate halves of EMACS_INT values separately.
2385 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2386 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2387 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2388 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2389 it avoids undefined behavior on hosts where shifting right by more
2390 than the word width has undefined behavior.
2391
2375c96a
CY
23922012-02-19 Chong Yidong <cyd@gnu.org>
2393
2394 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2395 (Funhandled_file_name_directory, Ffile_name_as_directory)
2396 (Fdirectory_file_name, Fexpand_file_name)
2397 (Fsubstitute_in_file_name): Protect against invalid file handler
2398 return values (Bug#10845).
2399
3eb49e71
EZ
24002012-02-18 Eli Zaretskii <eliz@gnu.org>
2401
2402 * .gdbinit (pitx): Fix incorrect references to fields of the
2403 iterator stack.
2404
7b926f3f
CY
24052012-02-17 Chong Yidong <cyd@gnu.org>
2406
2407 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2408
11273115
PE
24092012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2410
2411 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2412 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2413
c3a70e2b
CY
24142012-02-15 Chong Yidong <cyd@gnu.org>
2415
2416 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2417 marked as special. Also, starting docstrings with * is obsolete.
2418
0ca43699
AS
24192012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2420
2421 * gnutls.c (emacs_gnutls_write): Fix last change.
2422
2e8f3c56
LI
24232012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2424
2425 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2426 send_process.
2427
af70074f
SM
24282012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2429
2430 * keymap.c (Fsingle_key_description): Handle char ranges.
2431
95986d52
CY
24322012-02-12 Chong Yidong <cyd@gnu.org>
2433
afd83bd1
CY
2434 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2435 as that creates a dangerous corner case.
2436
95986d52
CY
2437 * window.c (Fdelete_window_internal): Invalidate the mouse
2438 highlight (Bug#9904).
2439
bd7da63e
GM
24402012-02-12 Glenn Morris <rgm@gnu.org>
2441
2442 * xselect.c (Fx_own_selection_internal)
2443 (Fx_get_selection_internal, Fx_disown_selection_internal)
2444 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2445 * nsselect.m (Fx_own_selection_internal)
2446 (Fx_disown_selection_internal, Fx_selection_exists_p)
2447 (Fx_selection_owner_p, Fx_get_selection_internal):
2448 Sync docs and argument specs with the xselect.c versions.
2449
77abcbc2
LI
24502012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2451
2452 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2453
90b671e2
EZ
24542012-02-11 Eli Zaretskii <eliz@gnu.org>
2455
1c0ca0b7
EZ
2456 * w32select.c (Fx_selection_exists_p): Sync doc string and
2457 argument list with xselect.c. (Bug#10783)
2458
2459 * w16select.c (Fx_selection_exists_p): Sync doc string and
2460 argument list with xselect.c. (Bug#10783)
90b671e2 2461
49241268
GM
24622012-02-10 Glenn Morris <rgm@gnu.org>
2463
2464 * fns.c (Fsecure_hash): Doc fix.
2465
f998bbe7 24662012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2467
2468 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2469
0992bd9c
CY
24702012-02-07 Chong Yidong <cyd@gnu.org>
2471
2472 * buffer.c (Fbuffer_local_variables)
2473 (buffer_lisp_local_variables): Handle unbound vars correctly;
2474 don't let Qunbound leak into Lisp.
2475
af008560
GM
24762012-02-07 Glenn Morris <rgm@gnu.org>
2477
dd605cc4
GM
2478 * image.c (Fimagemagick_types): Doc fix.
2479
af008560
GM
2480 * image.c (imagemagick-render-type): Change it from a lisp object
2481 to an integer. Move the doc here from the lisp manual.
2482 Treat all values not equal to 0 the same.
2483
1449fa1d
CY
24842012-02-06 Chong Yidong <cyd@gnu.org>
2485
2486 * doc.c (store_function_docstring): Avoid applying docstring of
2487 alias to base function (Bug#2603).
2488
3723ec07
AS
24892012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2490
2491 * .gdbinit (pp1, pv1): Remove redundant defines.
2492 (pr): Use pp.
2493
79c1cc1e
CY
24942012-02-04 Chong Yidong <cyd@gnu.org>
2495
2496 * nsterm.m: Declare a global (Bug#10694).
2497
d7f29f8e
EZ
24982012-02-04 Eli Zaretskii <eliz@gnu.org>
2499
cae07000
SM
2500 * w32.c (get_emacs_configuration_options):
2501 Include --enable-checking, if specified, in the return value.
d7f29f8e 2502
3b95a6f9
MR
25032012-02-04 Martin Rudalics <rudalics@gmx.at>
2504
2505 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2506 after rounding frame sizes. (Bug#9723)
2507
d6fa96a6
EZ
25082012-02-04 Eli Zaretskii <eliz@gnu.org>
2509
2510 * keyboard.c (adjust_point_for_property): Don't position point
2511 before BEGV. (Bug#10696)
2512
df0b2940
PE
25132012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2514
2515 Handle overflow when computing char display width (Bug#9496).
2516 * character.c (char_width): Return EMACS_INT, not int.
2517 (char_width, c_string_width): Check for overflow when
2518 computing the width; this is possible now that individual
2519 characters can have unbounded width. Problem introduced
2520 by merge from Emacs 23 on 2012-01-19.
2521
6bee44d6
MA
25222012-02-02 Michael Albinus <michael.albinus@gmx.de>
2523
2524 * dbusbind.c (Fdbus_register_method): Mention the return value
2525 :ignore in the docstring.
2526
44f92739
GM
25272012-02-02 Glenn Morris <rgm@gnu.org>
2528
1b9f60cc
GM
2529 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2530
44f92739
GM
2531 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2532 Unconditionally set to t. (Bug#10673)
2533 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2534 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2535 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2536
c5d3843c
KH
25372012-02-02 Kenichi Handa <handa@m17n.org>
2538
2539 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2540 0, do not call append_composite_glyph.
2541
159462d4 25422012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2543
2544 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2545 NULL (Bug#6988).
2546 (x_produce_glyphs): If the component of a composition is a null
2547 string, set it->pixel_width to 1 to avoid zero-width glyph.
2548
78cef877
EZ
25492012-02-01 Eli Zaretskii <eliz@gnu.org>
2550
2551 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2552 first 2 arguments are identical. This makes inserting large
2553 output from a subprocess an order of magnitude faster on
2554 MS-Windows, where all sbrk'ed memory is always contiguous.
2555
97897668
GM
25562012-01-31 Glenn Morris <rgm@gnu.org>
2557
2558 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2559 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2560 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2561
31fd3586
GM
25622012-01-29 Glenn Morris <rgm@gnu.org>
2563
2564 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2565
0e24a8b2
CY
25662012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2567
2568 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2569
cc0adcb0
CY
25702012-01-28 Chong Yidong <cyd@gnu.org>
2571
2572 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2573
acc28cb9
CY
25742012-01-26 Chong Yidong <cyd@gnu.org>
2575
9c69cfb7
CY
2576 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2577
acc28cb9
CY
2578 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2579 repeat counts (Bug#10507).
2580
48da7392
GM
25812012-01-26 Glenn Morris <rgm@gnu.org>
2582
2583 * lread.c (syms_of_lread): Doc fix.
2584
14af5f7f
CY
25852012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2586
2587 * coding.c (encode_designation_at_bol): Change return value to
2588 EMACS_INT.
2589
0b21c100
CY
25902012-01-25 Chong Yidong <cyd@gnu.org>
2591
2592 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2593
3c2907f7
CY
25942012-01-21 Chong Yidong <cyd@gnu.org>
2595
2596 * floatfns.c (Fcopysign): Make the second argument non-optional,
2597 since nil is not allowed anyway.
2598
959ad23f
AS
25992012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2600
2601 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2602 (send_process): Likewise.
2603
34a02f46
MR
26042012-01-19 Martin Rudalics <rudalics@gmx.at>
2605
2606 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2607 (Vwindow_persistent_parameters): Do not use Qstate.
2608 Rewrite doc-strings.
34a02f46 2609
1259009a 26102012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2611
2612 * character.c (char_width): New function.
70d4fdf6
GM
2613 (Fchar_width, c_string_width, lisp_string_width):
2614 Use char_width (Bug#9496).
25ed9e61 2615
6a6ee00d
MR
26162012-01-16 Martin Rudalics <rudalics@gmx.at>
2617
2618 * window.c (Vwindow_persistent_parameters): New variable.
2619 (Fset_window_configuration, save_window_save): Handle persistent
2620 window parameters.
2621
c85efaf7
EZ
26222012-01-14 Eli Zaretskii <eliz@gnu.org>
2623
2624 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2625 thrashing the stack of the thread. (Bug#9087)
2626
5944709e
PE
26272012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2628
2629 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2630
e71f5d99
EZ
26312012-01-11 Eli Zaretskii <eliz@gnu.org>
2632
2633 * xdisp.c (rows_from_pos_range): Handle the case where the
2634 highlight ends on a newline. (Bug#10464)
2635 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2636 he end column for display of highlight that ends on a newline
2637 before a R2L line.
2638
ce316182
GM
26392012-01-11 Glenn Morris <rgm@gnu.org>
2640
2641 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2642 from load-path also when installation-directory is nil. (Bug#10208)
2643
5b43da69
GM
26442012-01-10 Glenn Morris <rgm@gnu.org>
2645
74cc8ff9
GM
2646 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2647
7d8d6e4e
GM
2648 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2649 Update template values to be closer to their typical values these days.
5b43da69 2650
a0db8d43
EZ
26512012-01-09 Eli Zaretskii <eliz@gnu.org>
2652
2653 * xdisp.c (rows_from_pos_range): Accept additional argument
2654 DISP_STRING, and accept any glyph in a row whose object is that
2655 string as eligible for mouse highlight. Fixes mouse highlight of
2656 display strings from overlays. (Bug#10464)
2657
9a0115ab 26582012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2659
b9110d6a 2660 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2661 * fileio.c (auto_saving_dir_umask): New static var.
2662 (Fmake_directory_internal): Use it.
2663 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2664 creating the directory. The old code temporarily assigns
2665 too-generous permissions to the directory.
2666 (do_auto_save_eh): Clear it.
b9110d6a 2667 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2668 that the var is always cleared.
2669
6c1bd3f3
EZ
26702012-01-07 Eli Zaretskii <eliz@gnu.org>
2671
2672 * search.c (scan_buffer): Pass character positions to
2673 know_region_cache, not byte positions. (Bug#6540)
2674
069d2b50
L
26752012-01-07 LynX <_LynX@bk.ru> (tiny change)
2676
2677 * w32.c (sys_rename): Report EXDEV when rename of a directory
2678 fails because the target is on another logical disk. (Bug#10284)
2679
75bf0d33
DB
26802012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2681
2682 * xterm.c (x_embed_request_focus): New function.
2683
2684 * xterm.h: Add prototype.
2685
2686 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2687
1c6e5a32
GM
26882012-01-05 Glenn Morris <rgm@gnu.org>
2689
2690 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2691
651e947e
EZ
26922012-01-01 Eli Zaretskii <eliz@gnu.org>
2693
2694 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2695 Load gnutls_transport_set_lowat only if GnuTLS version is below
2696 2.11.1.
2697 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2698 GnuTLS versions below 2.11.1.
2699
3778cdd8
AL
27002011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2701
2702 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2703 to the doc string advising against its use for altering the way
2704 windows are scrolled.
2705
0e5317f7
KH
27062011-12-28 Kenichi Handa <handa@m17n.org>
2707
2708 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2709 coding-system ASCII compatible only when it does not produce BOM
2710 on encoding (Bug#10383).
2711
93d5ca1f
JD
27122011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2713
2714 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2715 can scroll.
2716 (create_and_show_popup_menu): Always use menu_position_func for
2717 Gtk3 (Bug#10361).
2718
ca22b785
AS
27192011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2720
2721 * callint.c (Fcall_interactively): Don't truncate prompt string.
2722
d048e1e6
EZ
27232011-12-23 Eli Zaretskii <eliz@gnu.org>
2724
2725 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2726 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2727 resumed from there (after widening). (Bug#10360)
d048e1e6 2728
5ccaba1f
JD
27292011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2730
2731 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2732
204ee57f
JD
27332011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2734
b81d40f0
JB
2735 * nsterm.m (x_free_frame_resources):
2736 Release f->output_data.ns->miniimage.
204ee57f
JD
2737 (ns_index_color): Fix indentation. Do not retain
2738 color_table->colors[i].
2739
2740 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2741 before returning.
2742
2743 * nsfns.m (x_set_background_color): Assign return value from
2744 ns_index_color to face-background instead of NSColor*.
2745 (ns_implicitly_set_icon_type): Fix indentation.
2746 Change assignment in for loop to comparison.
2747
2748 * emacs.c (ns_pool): New variable.
2749 (main): Assign ns_pool.
2750 (Fkill_emacs): Call ns_release_autorelease_pool.
2751
2752 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2753 autorelease fdesc, release fdAttrs and tdict.
2754 (ns_get_covering_families): Release charset.
2755 (ns_findfonts): Release NSFontDescriptor created with new.
2756 (ns_uni_to_glyphs): Fix indentation.
2757 (setString): Release attrStr before assigning new value.
2758
c803b2b7
JD
27592011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2760
678f4426
JD
2761 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2762 and NS_IMPL_COCOA.
2763 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2764 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2765
cd394be1 27662011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2767
5fecd5fc
JD
2768 * nsterm.m (ns_term_init): Subscribe for notifications
2769 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2770 to method trackingNotification in EmacsMenu.
2771
2772 * nsmenu.m (trackingMenu): New variable.
3771cb17 2773 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2774 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2775 from Aquamacs (Bug#7030).
678f4426
JD
2776
27772011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2778
c803b2b7
JD
2779 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2780 (symbol_to_nsstring): Fix indentation.
2781 (ns_symbol_to_pb): New function.
cae07000
SM
2782 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2783 (Fns_rotate_cut_buffers_internal): Remove.
2784 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2785 Fns_store_cut_buffer_internal.
2786 (ns_get_foreign_selection, Fx_own_selection_internal)
2787 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2788 (Fns_get_selection_internal, Fns_store_selection_internal):
2789 Use ns_symbol_to_pb and check if return value is nil.
2790 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2791 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2792 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2793 renamed to Sns_store_selection_internal.
2794 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2795 and remove this function.
2796 (ns_handle_selection_clear): Remove, never used.
2797 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2798 here.
2799
e1b01a3a
KB
28002011-12-17 Ken Brown <kbrown@cornell.edu>
2801
2802 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2803 GID is unknown (Bug#10257).
2804
2adb6e85
PE
28052011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2806
2807 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2808 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2809 which caused a build failure on GNU/Linux IA-64. This problem was
2810 introduced by my 2011-10-07 patch.
2811
d1d7b339
JL
28122011-12-15 Juri Linkov <juri@jurta.org>
2813
2814 * image.c (imagemagick_error): New function. (Bug#10112)
2815 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2816 Use `imagemagick_error' where ImageMagick functions return
2817 `MagickFalse'.
2818 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2819 proper order.
2820
100d5755
KH
28212011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2822
2823 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2824 fill background (Bug#8992).
2825
454592a6
MR
28262011-12-13 Martin Rudalics <rudalics@gmx.at>
2827
2828 * window.c (Vwindow_combination_resize)
2829 (Vwindow_combination_limit): Use t instead of non-nil in
2830 doc-strings.
61d4b438
MR
2831 (Vrecenter_redisplay): Add first sentence of doc-string on
2832 separate line.
53524d93 2833 (Frecenter): Fix doc-string typo.
454592a6 2834
3633e3aa
KH
28352011-12-11 Kenichi Handa <handa@m17n.org>
2836
2837 * coding.c (Funencodable_char_position): Pay attention to the
2838 buffer text relocation (Bug#9389).
2839
7b9d523a 28402011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2841
7b9d523a
JD
2842 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2843 gtk_init (Bug#10100).
2844
b73189c6
EZ
28452011-12-10 Eli Zaretskii <eliz@gnu.org>
2846
2847 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2848 IT->string is nil. (Bug#10263)
2849
f7dfe5d6
JD
28502011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2851
83faebb4
JD
2852 * nsterm.h (x_free_frame_resources): Declare.
2853
f7dfe5d6
JD
2854 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2855 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2856
2857 * nsterm.h (ns_get_defaults_value): Declare.
2858
2859 * nsterm.m (ns_default): Call ns_get_defaults_value.
2860
7cd4e72c
EZ
28612011-12-09 Eli Zaretskii <eliz@gnu.org>
2862
2863 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2864 (Bug#10170)
2865
b34d7317
YM
28662011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2867
2868 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2869 that where the value of an _OBJC_* symbol points to is in the .bss
2870 section (Bug#10240).
2871
76470ad1
KH
28722011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2873
2874 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2875 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2876
745fff94
KH
28772011-12-08 Kenichi Handa <handa@m17n.org>
2878
2879 * ftfont.c (get_adstyle_property): Fix previous change
2880 (Bug#10233).
2881
6e44397c
JB
28822011-12-07 Juanma Barranquero <lekktu@gmail.com>
2883
2884 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2885 dirs from the default value of EMACSLOADPATH (bug#10208).
2886
7efa6272
GM
28872011-12-07 Glenn Morris <rgm@gnu.org>
2888
2889 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2890 installation and source directories as well. (Bug#10208)
2891
f6fc4d87
CY
28922011-12-06 Chong Yidong <cyd@gnu.org>
2893
2894 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2895
2bf26180
GM
28962011-12-06 Glenn Morris <rgm@gnu.org>
2897
2898 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2899 as an error, not just -1. (Bug#10217)
2900
3a6ad4f0
CY
29012011-12-05 Chong Yidong <cyd@gnu.org>
2902
2903 * keyboard.c (process_special_events): New function.
2904 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2905
75a3b399
PE
29062011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2907
2908 * coding.c (encode_designation_at_bol): Don't use uninitialized
2909 local variable (Bug#9318).
2910
c3c9e25e
KH
29112011-12-05 Kenichi Handa <handa@m17n.org>
2912
2913 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2914 return Qnil (Bug#8046, Bug#10193).
2915
5eb05ea3
KH
29162011-12-05 Kenichi Handa <handa@m17n.org>
2917
2918 * coding.c (encode_designation_at_bol): New args charbuf_end and
2919 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2920 (coding_set_source): Return how many bytes coding->source was
2921 relocated.
2922 (coding_set_destination): Return how many bytes
2923 coding->destination was relocated.
2924 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2925 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2926
29272011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2928
2929 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2930 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2931 macro (Bug#9318).
2932
29332011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2934
2935 The following changes are to fix Bug#9318.
2936
a79703f5 2937 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2938 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2939 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2940 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2941
7dbda6df
JB
29422011-12-05 Juanma Barranquero <lekktu@gmail.com>
2943
2944 * lisp.h (process_quit_flag): Fix external declaration.
2945
6d5eb5b0
SM
29462011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2947
2948 Don't macro-inline non-performance-critical code.
2949 * eval.c (process_quit_flag): New function.
2950 * lisp.h (QUIT): Use it.
2951
a0c3fad0
JD
29522011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2953
2954 * nsfns.m (get_geometry_from_preferences): New function.
2955 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2956
6c07aac2
AS
29572011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2958
2959 * emacs.c (Qkill_emacs): Define.
2960 (syms_of_emacs): Initialize it.
2961 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2962 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2963 (quit_throw_to_read_char): Add parameter `from_signal'.
2964 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2965 * lisp.h (QUIT): Call Fkill_emacs if requested.
2966
c052ead4
JD
29672011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2968
2969 * widget.c (update_wm_hints): Return if wmshell is null.
2970 (widget_update_wm_size_hints): New function.
2971
2972 * widget.h (widget_update_wm_size_hints): Declare.
2973
2974 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2975 widget_update_wm_size_hints (Bug#10104).
2976
9e49252b
EZ
29772011-12-03 Eli Zaretskii <eliz@gnu.org>
2978
2979 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2980 before a newline, prepare the bidi iterator for consuming the
2981 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2982 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2983
02b16839
JL
29842011-12-02 Juri Linkov <juri@jurta.org>
2985
2986 * search.c (Fword_search_regexp): New Lisp function created from
2987 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2988 (Fword_search_backward, Fword_search_forward)
2989 (Fword_search_backward_lax, Fword_search_forward_lax):
2990 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2991 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2992
0068070e
SM
29932011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2994
2995 * fileio.c (Finsert_file_contents): Move after-change-function call
2996 to before the "handled:" label, since all "goto handled" appear in
2997 cases where the *-change-functions have already been properly called
2998 (bug#10117).
2999
3360a3fc
AS
30002011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3001
3002 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3003 waiting for input. (Bug#10169)
3004
73d6c093
EZ
30052011-11-30 Eli Zaretskii <eliz@gnu.org>
3006
3007 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3008 verifies glyph row's hash code--we have just reallocated the
3009 glyphs, so their contents can be complete garbage. (Bug#10164)
3010
febe6bea
JB
30112011-11-30 Juanma Barranquero <lekktu@gmail.com>
3012
3013 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3014
801a4313
EZ
30152011-11-30 Eli Zaretskii <eliz@gnu.org>
3016
3017 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3018 attributes are tested _before_ calling verify_row_hash, to protect
3019 against GCC re-ordering of the tests. (Bug#10164)
3020
2b56b87e
JD
30212011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3022
3023 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3024
3025 * xterm.c (handle_one_xevent): Only set async_visible and friends
3026 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3027 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3028 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3029
dbf31225
PE
30302011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3033 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3034 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3035 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3036 All uses changed to use GCPRO1 etc.
3037 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3038 Revert to old implementation (i.e., before 2011-03-11).
3039
1305621b
YM
30402011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3041
3042 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3043 of scroll runs so as to avoid assigning disabled bogus rows and
3044 unnecessary graphics copy operations.
3045
8c9afb46
EZ
30462011-11-27 Eli Zaretskii <eliz@gnu.org>
3047
3048 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3049 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3050 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3051 (malloc, free, realloc, calloc): Redirect to e_* only when
3052 compiling Emacs.
3053
3054 * lisp.h (GCTYPEBITS): Move before first use.
3055 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3056 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3057 this macro definition.
3058
3059 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3060 _MSC_VER.
3061
54e9e3bf
JD
30622011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3063
6d5eb5b0
SM
3064 * gtkutil.c (xg_create_frame_widgets):
3065 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3066 present with Gtk+ 2.0.
3067
83aca1cb
PE
30682011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3069
3070 * fileio.c (Finsert_file_contents): Undo previous change; see
3071 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3072
5b76caa4
PE
30732011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 Rename locals to avoid shadowing.
3076 * fileio.c (Finsert_file_contents):
3077 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3078 * process.c (wait_reading_process_output):
3079 Rename inner 'proc' to 'p' to avoid shadowing.
3080 Indent for consistency with usual Emacs style.
3081
8c535114
EZ
30822011-11-25 Eli Zaretskii <eliz@gnu.org>
3083
3084 * xdisp.c (redisplay_window): If cursor row is not fully visible
3085 after recentering, and scroll-conservatively is set to a large
3086 number, scroll window by a few more lines to make the cursor fully
3087 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3088 (start_display): Don't move to the next line if the display should
3089 start at a newline that is part of a display vector or an overlay
3090 string. (Bug#10119)
8c535114 3091
fa4fdb5c
JL
30922011-11-24 Juri Linkov <juri@jurta.org>
3093
3094 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3095 after the `MagickPingImage' call. (Bug#10112)
3096
90ec88df
CY
30972011-11-23 Chong Yidong <cyd@gnu.org>
3098
3099 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3100
56e2e794
MR
31012011-11-23 Martin Rudalics <rudalics@gmx.at>
3102
3103 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3104 making another buffer current. (Bug#10114)
3105
b6e64c41
GM
31062011-11-23 Glenn Morris <rgm@gnu.org>
3107
3108 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3109
6b21de18
CY
31102011-11-23 Chong Yidong <cyd@gnu.org>
3111
3112 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3113 using it (Bug#5984).
3114
b12cd789
EZ
31152011-11-22 Eli Zaretskii <eliz@gnu.org>
3116
3117 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3118 and header-lines, as they don't have one computed for them.
3119 (Bug#10098)
3120
3121 * .gdbinit (prow): Make displayed values more self-explaining.
3122 Add row's hash code.
3123
261b6fd4
LMI
31242011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3125
3126 * process.c (wait_reading_process_output): Fix asynchrounous
3127 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3128 (wait_reading_process_output): Add comment and URL.
261b6fd4 3129
e7cfd277
JD
31302011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3131
3132 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3133
a9b9b7f5
CY
31342011-11-21 Chong Yidong <cyd@gnu.org>
3135
3136 * window.c (Fnext_window, Fprevious_window): Doc fix.
3137
b0d15b4f
SM
31382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3139
3140 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3141
fe7a3057
JB
31422011-11-20 Juanma Barranquero <lekktu@gmail.com>
3143
3144 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3145
d2999b1a
MR
31462011-11-20 Martin Rudalics <rudalics@gmx.at>
3147
3148 * window.c (Fset_window_combination_limit): Rename argument
3149 STATUS to LIMIT.
3150 (Vwindow_combination_limit): Remove "status" from doc-string.
3151
d5ff9cd0
AS
31522011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3153
3154 * m/ibms390.h: Remove.
3155 * m/ibms390x.h: Don't include "ibms390.h".
3156
a5bb9bd3
SM
31572011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3158
3159 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3160 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3161
cd1181db
JB
31622011-11-20 Juanma Barranquero <lekktu@gmail.com>
3163
3164 * casetab.c (Fset_case_table):
3165 * charset.c (Fcharset_after): Fix typos.
3166
615a3b8d 31672011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3168
17e845af
PE
3169 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3170 Otherwise, valgrind does not work on some platforms.
3171 Problem reported by Andreas Schwab in
6a0bf43d
PE
3172 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3173 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3174 is set, removing the need for VIRT_ADDRESS_VARIES.
3175 (PURE_P): Use a more-efficient implementation that needs just one
3176 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3177 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3178 to 4 (xorl, subq, cmpq, setbe).
3179 * alloc.c (pure): Always extern now, since that's the
3180 VIRT_ADDR_VARIES behavior.
3181 (PURE_POINTER_P): Use a single comparison, not two, for
3182 consistency with the new puresize.h.
3183 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3184 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3185 Remove VIRT_ADDR_VARIES no longer needed.
3186
f8fe6f96
EZ
31872011-11-19 Eli Zaretskii <eliz@gnu.org>
3188
3189 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3190 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3191 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3192 behave as if the cursor position were at the window margin.
3193
3194 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3195 and the cursor position is out of bounds, behave as if the cursor
3196 position were at the window margin. (Bug#10075)
3197
df05a53c
CY
31982011-11-18 Chong Yidong <cyd@gnu.org>
3199
3200 * window.c (Fwindow_combination_limit): Make first argument
3201 non-optional, since it is meaningless for live windows like the
3202 selected window.
61ccba97 3203
2071918e
DA
32042011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3205
3206 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3207
b50a28de
SM
32082011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3209
3210 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3211 (graft_intervals_into_buffer): Simplify.
3212
015137db
EZ
32132011-11-18 Eli Zaretskii <eliz@gnu.org>
3214
3215 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3216 hash values of the two rows.
3217 (copy_row_except_pointers): Preserve the used[] arrays and the
3218 hash values of the two rows. (Bug#10035)
68c95424 3219 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3220
3221 * xdisp.c (row_hash): New function, body extracted from
3222 compute_line_metrics.
3223 (compute_line_metrics): Call row_hash, instead of computing the
3224 hash code inline.
3225
3226 * dispnew.c (verify_row_hash): Call row_hash for computing the
3227 hash code of a row, instead of duplicating code from xdisp.c.
3228
3229 * dispextern.h (row_hash): Add prototype.
3230
a2addb04
TH
32312011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3232
3233 * frame.c (delete_frame): Don't delete the terminal when the last
3234 X frame is closed if emacs is built with GTK toolkit.
3235
df85d315
JB
32362011-11-17 Juanma Barranquero <lekktu@gmail.com>
3237
3238 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3239
a0c2d0ae
MR
32402011-11-17 Martin Rudalics <rudalics@gmx.at>
3241
3242 * window.c (Vwindow_splits): Rename to
3243 Vwindow_combination_resize. Suggested by Juri Linkov.
3244 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3245 of Vwindow_splits.
3246
58179cce
JB
32472011-11-16 Juanma Barranquero <lekktu@gmail.com>
3248
7877f373
JB
3249 * nsfns.m (Fns_font_name):
3250 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3251
b6f67890
MR
32522011-11-16 Martin Rudalics <rudalics@gmx.at>
3253
3254 * window.h (window): Rename slot "nest" to "combination_limit".
3255 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3256 (Fset_window_nest): Rename to Fset_window_combination_limit.
3257 (Vwindow_nest): Rename to Vwindow_combination_limit.
3258 (recombine_windows, make_parent_window, make_window)
3259 (Fsplit_window_internal, saved_window)
3260 (Fset_window_configuration, save_window_save): Rename all
3261 occurrences of window_nest to window_combination_limit.
3262
c7015153
JB
32632011-11-15 Juanma Barranquero <lekktu@gmail.com>
3264
3265 * image.c (imagemagick_load_image): Fix typo.
3266
322ad6ec
EZ
32672011-11-14 Eli Zaretskii <eliz@gnu.org>
3268
3269 * xdisp.c (display_line): Move the call to
3270 highlight_trailing_whitespace before the call to
3271 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3272 faces of all the glyphs to compute ROW's hash value.
3273 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3274
f067b8ec
JB
32752011-11-14 Juanma Barranquero <lekktu@gmail.com>
3276
3277 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3278 just return (bug#10044).
3279
1e5b2111
EZ
32802011-11-12 Eli Zaretskii <eliz@gnu.org>
3281
7ef3cbd5
EZ
3282 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3283 with user-defined heap size. Bump the default size of the temacs
3284 heap to 27MB, to avoid memory warning when running temacs.
3285 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3286
1e5b2111
EZ
3287 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3288 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3289 (verify_row_hash) [XASSERTS]: New function.
3290 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3291 that the hash value of glyph rows is correct.
1e5b2111 3292
89d61221
MR
32932011-11-12 Martin Rudalics <rudalics@gmx.at>
3294
3295 * window.h (window): Remove splits slot.
3296 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3297 (Fdelete_other_windows_internal, make_parent_window)
3298 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3299 (Fset_window_configuration, save_window_save): Don't deal with
3300 split status of windows.
3301 (saved_window): Remove splits slot.
3302 (Vwindow_splits): Rewrite doc-string.
3303
97f18cc8
JD
33042011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3305
3306 * xfns.c (unwind_create_frame):
3307 * nsfns.m (unwind_create_frame):
3308 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3309 Vframe_list (Bug#9999).
3310
22a648b4
DA
33112011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3312
0b381c7e 3313 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3314
659afede
KH
33152011-11-11 Kenichi Handa <handa@m17n.org>
3316
3317 * callproc.c (Fcall_process): Set the member dst_multibyte of
3318 process_coding.
3319
9ac0394b
KH
33202011-11-11 Johan Bockgård <bojohan@gnu.org>
3321
3322 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3323 avoid a crash (bug#9496).
3324
2fbdc249
CY
33252011-11-09 Chong Yidong <cyd@gnu.org>
3326
3327 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3328 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3329
ac6b1f81
PE
33302011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3331
3332 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3333
09db192c
PE
33342011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3335
3336 Avoid some portability problems by eschewing 'extern inline' functions.
3337 The trivial performance wins aren't worth the portability hassles; see
3338 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3339 et seq.
3340 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3341 (window_box_width, window_box_left, window_box_left_offset)
3342 (window_box_right, window_box_right_offset): Undo previous change,
3343 by removing the "extern"s.
3344 * intervals.c (adjust_intervals_for_insertion)
3345 (adjust_intervals_for_deletion): Undo previous change,
3346 making these static again.
3347 (offset_intervals, temp_set_point_both, temp_set_point)
3348 (copy_intervals_to_string): No longer inline.
3349 * xdisp.c (window_text_bottom_y, window_box_width)
3350 (window_box_height, window_box_left_offset)
3351 (window_box_right_offset, window_box_left, window_box_right)
3352 (window_box): No longer inline.
3353
105216ed
CY
33542011-11-08 Chong Yidong <cyd@gnu.org>
3355
3356 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3357 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3358 Signal an error if not a live window.
105216ed
CY
3359 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3360 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3361
ae9e237f
JB
33622011-11-07 Juanma Barranquero <lekktu@gmail.com>
3363
3364 * lisp.h (syms_of_abbrev): Remove declaration.
3365 Reported by CHENG Gao <chenggao@royau.me>.
3366
c7aa8333
EZ
33672011-11-07 Eli Zaretskii <eliz@gnu.org>
3368
3369 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3370 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3371 of temacs in GUI mode.
3372
be7f5545
MR
33732011-11-07 Martin Rudalics <rudalics@gmx.at>
3374
3375 * window.h: Declare delete_all_child_windows instead of
3376 delete_all_subwindows.
3377 * window.c (Fwindow_nest, Fset_window_nest)
3378 (Fset_window_new_total, Fset_window_new_normal)
3379 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3380 (delete_all_subwindows): Rename to delete_all_child_windows.
3381 (Fdelete_other_windows_internal, Fset_window_configuration):
3382 Call delete_all_child_windows instead of delete_all_subwindows.
3383 * frame.c (delete_frame): Call delete_all_child_windows instead
3384 of delete_all_subwindows.
3385
ca78dc43
PE
33862011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3387
3388 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3389 This is also needed for porting to any host where GC_MARK_STACK is
3390 not GC_MAKE_GCPROS_NOOPS.
3391 (which_symbols): Use it.
3392
a0241d01
KH
33932011-11-07 Kenichi Handa <handa@m17n.org>
3394
3395 * coding.c (coding_set_destination): Check coding->src_pos only
3396 when coding->src_object is a buffer (bug#9910).
3397
3398 * process.c (send_process): Set the member src_multibyte of coding
3399 to 0 (bug#9911) when sending a unibyte text.
3400
3401 * callproc.c (Fcall_process): Set the member src_multibyte of
3402 process_coding to 0 (bug#9912).
3403
a64bfdfa 34042011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3405
3406 * xmenu.c (cleanup_widget_value_tree): New function.
3407 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3408 calling free_menubar_widget_value_tree directly (Bug#9830).
3409
cb41b32a
PE
34102011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3411
3412 Fix some portability problems with 'inline'.
3413 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3414 (window_box_width, window_box_left, window_box_left_offset)
3415 (window_box_right, window_box_right_offset): Declare extern.
3416 Otherwise, these inline functions do not conform to C99 and
3417 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3418 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3419 * intervals.c (adjust_intervals_for_insertion)
3420 (adjust_intervals_for_deletion): Now extern, because otherwise the
3421 extern inline functions 'offset_intervals' couldn't refer to it.
3422 (static_offset_intervals): Remove.
3423 (offset_intervals): Rewrite using the old contents of
3424 static_offset_intervals. The old version didn't conform to C99
3425 because an extern inline function contained a reference to an
3426 identifier with static linkage.
3427
b7041366
AS
34282011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3429
3430 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3431 GC.
3432
88a37c4d
EZ
34332011-11-06 Eli Zaretskii <eliz@gnu.org>
3434
3435 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3436 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3437 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3438 return Qleft_to_right.
3439
49745b39
CY
34402011-11-06 Chong Yidong <cyd@gnu.org>
3441
3442 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3443 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3444 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3445 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3446 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3447 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3448 (Fwindow_vscroll): Doc fix.
3449 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3450 argument, since it makes no sense to pass a live window and for
3451 consistency with window-child.
3452
1f05cd82
CS
34532011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3454
3455 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3456 support MSVC.
3457
22610910
JR
34582011-11-05 Jason Rumney <jasonr@gnu.org>
3459
3460 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3461 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3462 fonts (Bug#6029).
3463 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3464 bitwise arithmetic preventing use of unicode-sip and non-truetype
3465 opentype fonts.
3466
a06776b2
EZ
34672011-11-05 Eli Zaretskii <eliz@gnu.org>
3468
3ad924ba
EZ
3469 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3470 "emacs"-only part.
3471
a06776b2
EZ
3472 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3473 initialization code to keep similarity to xfns.c after changes
3474 from 2011-11-05.
3475
c9e7db78
JD
34762011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3477
a97f8f3f
JD
3478 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3479 (unwind_create_frame): New function (Bug#9943).
3480 (Fx_create_frame): Restructure code to be more similar to the one in
3481 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3482 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3483 Move terminal->reference_count++ just before making the frame official
3484 (Bug#9943).
3485
3486 * nsterm.m (x_free_frame_resources): New function.
3487 (x_destroy_window): Move code to x_free_frame_resources.
3488
c9e7db78 3489 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3490 (Fx_create_frame, x_create_tip_frame):
3491 Move terminal->reference_count++ just before making the frame
75f1671a 3492 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3493 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3494
a6fc3b5c
EZ
34952011-11-05 Eli Zaretskii <eliz@gnu.org>
3496
3497 Support MSVC build with newer versions of Visual Studio.
3498 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3499 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3500 nt/gmake.defs.
3501
3502 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3503 which are not supported by MSVC.
3504 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3505 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3506 bitfields.
3507 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3508 types in bitfields.
3509 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3510
3511 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3512
58179cce 35132011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3514
3515 Support MSVC build with newer versions of Visual Studio.
3516 * w32.c: Don't include w32api.h for MSVC.
3517 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3518
3519 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3520 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3521 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3522 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3523 e_* cousins.
3524 (alloca) [_MSC_VER]: Define to _alloca.
3525
3526 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3527
3528 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3529
a58c13ed
EZ
35302011-11-04 Eli Zaretskii <eliz@gnu.org>
3531
3532 * xdisp.c (note_mouse_highlight): If either of
3533 previous/next-single-property-change returns nil, treat that as
3534 the beginning or the end of the buffer. (Bug#9955)
3535
fe0b6370
JD
35362011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3537
a58c13ed 3538 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3539 label is not null (Bug#9951).
3540 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3541 may be NULL.
3542
89bd5ee1
EZ
35432011-11-04 Eli Zaretskii <eliz@gnu.org>
3544
3545 * window.c (Fwindow_body_size): Mention in the doc string that the
3546 return value is in frame's canonical units. (Bug#9949)
3547
84c3edb9
EZ
35482011-11-03 Eli Zaretskii <eliz@gnu.org>
3549
4e2fb5c7
EZ
3550 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3551
84c3edb9 3552 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3553 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3554 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3555
bc17a887
EZ
35562011-11-01 Eli Zaretskii <eliz@gnu.org>
3557
3558 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3559 Don't stop backward scan on the continuation glyph, even though
3560 its CHARPOS is positive.
6d5eb5b0
SM
3561 (mouse_face_from_buffer_pos, note_mouse_highlight):
3562 Rename cover_string to disp_string.
bc17a887 3563
4ee88440
MR
35642011-11-01 Martin Rudalics <rudalics@gmx.at>
3565
3566 * window.c (temp_output_buffer_show): Don't use
3567 Vtemp_buffer_show_specifiers.
3568 (Vtemp_buffer_show_specifiers): Remove unused variable.
3569
c2ff3c02
EZ
35702011-10-30 Eli Zaretskii <eliz@gnu.org>
3571
3572 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3573 past the beginning of the current glyph matrix.
3574
58179cce 35752011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3576
3577 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3578 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3579 HAVE_GTK3 (Bug#9869).
b77a6a7f 3580
3b574623
JD
3581 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3582 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3583
b77a6a7f
JD
3584 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3585
3586 * xterm.c: Declare x_handle_net_wm_state to return int.
3587 (handle_one_xevent): Check if we are iconified but don't have
3588 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3589 (get_current_wm_state): Return non-zero if not hidden,
3590 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3591 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3592 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3593 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3594
196e41e4
PE
35952011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3598 so that this new function doesn't get optimized away by a
3599 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3600
021f2e1a
AS
36012011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3602
3603 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3604
8b058d44
EZ
36052011-10-29 Eli Zaretskii <eliz@gnu.org>
3606
3607 Fix the `xbytecode' command.
3608 * .gdbinit (xprintbytestr): New command.
b50a28de 3609 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3610 (xbytecode): Print the byte-code string as well.
3611
4452fb80
EZ
36122011-10-29 Kim Storm <storm@cua.dk>
3613
8b058d44
EZ
3614 * alloc.c (which_symbols): New function.
3615
21b72067
AS
36162011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3617
3618 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3619 line. (Bug#9903)
3620
83ed7b5c
GM
36212011-10-29 Glenn Morris <rgm@gnu.org>
3622
3623 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3624 Not clear what it was for, and it causes various bugs. (Bug#9839)
3625
5a7a728b
EZ
36262011-10-28 Eli Zaretskii <eliz@gnu.org>
3627
3628 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3629 possible random value that matches one of those tested as
3630 condition to clear the mouse face.
3631
d3d0842f
CY
36322011-10-28 Chong Yidong <cyd@gnu.org>
3633
3634 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3635
31b39d13
DN
36362011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3637
3638 * window.c (make_window): Initialize phys_cursor_on_p.
3639
9aba6043
SM
36402011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3641
3642 * lisp.h (struct Lisp_Symbol): Update comments.
3643
c20992f4
JB
36442011-10-28 Juanma Barranquero <lekktu@gmail.com>
3645
3646 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3647
db4f02f2
EZ
36482011-10-28 Eli Zaretskii <eliz@gnu.org>
3649
3650 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3651 <oslsachem@gmail.com> for helping to debug this.
3652
3653 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3654 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3655 (g_b_init_get_glyph_outline_w): New static variables.
3656 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3657 (GetGlyphOutlineW_Proc): New typedefs.
3658 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3659 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3660 New functions.
3661 (w32font_open_internal, compute_metrics):
3662 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3663 instead of calling the "wide" APIs directly.
3664
3665 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3666
3667 * w32.h (syms_of_w32font): Add prototype.
3668
87e68db4
JB
36692011-10-27 Juanma Barranquero <lekktu@gmail.com>
3670
3671 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3672 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3673 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3674 (Fmove_to_window_line): Doc fix.
3675
435c1d67
CY
36762011-10-27 Chong Yidong <cyd@gnu.org>
3677
3678 * process.c (make_process): Set gnutls_state to NULL.
3679
3680 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3681 non-NULL, regardless of GNUTLS_INITSTAGE.
3682 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3683 an error. Set process slots as soon as we allocate them.
3684
3685 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3686
9c6c6f49
CY
36872011-10-27 Chong Yidong <cyd@gnu.org>
3688
9aba6043
SM
3689 * gnutls.c (emacs_gnutls_deinit): New function.
3690 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3691 (Fgnutls_deinit, Fgnutls_boot): Use it.
3692
3693 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3694 (deactivate_process): Call emacs_gnutls_deinit.
3695
657d08d3
JB
36962011-10-27 Juanma Barranquero <lekktu@gmail.com>
3697
3698 * image.c (x_create_x_image_and_pixmap):
3699 * w32.c (sys_rename, w32_delayed_load):
3700 * w32font.c (fill_in_logfont):
3701 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3702
5430d399
JB
37032011-10-26 Juanma Barranquero <lekktu@gmail.com>
3704
3705 * w32fns.c (w32_default_color_map): New function,
3706 extracted from Fw32_default_color_map.
a7ef684b 3707 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3708
fe0055fa
PE
37092011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3710
3711 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3712
e6346438
SM
37132011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3714
3715 * keyboard.c (test_undefined): New function (bug#9751).
3716 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3717
e112cc37
ET
37182011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3719
3720 * sysdep.c (init_sys_modes): Fix the check for the controlling
3721 terminal (Bug#6649).
3722
7b5d6677
EZ
37232011-10-20 Eli Zaretskii <eliz@gnu.org>
3724
3725 * dispextern.h (struct bidi_it): New member next_en_type.
3726
3727 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3728 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3729 current character, check also for next_en_type being WEAK_EN.
3730 (bidi_resolve_weak): Don't enter the expensive loop if the current
3731 position is before next_en_pos. Record the bidi type of the first
3732 non-ET, non-BN character we find, in addition to its position.
3733 (bidi_level_of_next_char): Invalidate next_en_type when
3734 next_en_pos is over-stepped.
3735
7da0b018
PE
37362011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3737
3738 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3739 * editfns.c: Rewrite current-time-zone so that it invokes
3740 the equivalent of (format-time-string "%Z") to get the time zone name.
3741 This fixes a bug when the time zone name contains characters that
3742 need converting from the system time locale to Emacs internal format.
3743 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3744 that patch fixed format-time-string to do the conversion, but
3745 I forgot to fix current-time-zone.
3746 (format_time_string): New function, containing most of
3747 what Fformat_time_string used to contain.
3748 (Fformat_time_string): Rewrite in terms of format_time_string.
3749 This doesn't change this function's behavior.
3750 (current-time-zone): Rewrite to use format_time_string.
3751 This fixes the bug reported by Michael Schierl in
3752 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3753 Jason Rumney's 2007-06-07 change worked around this bug, but
3754 didn't fix it.
3755 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3756
8547b010
EZ
37572011-10-19 Eli Zaretskii <eliz@gnu.org>
3758
3759 * xdisp.c (start_display): If the character at POS is displayed
3760 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3761 (try_window_reusing_current_matrix): If a line ends in a display
3762 vector or the next line starts in a display vector, continue
3763 redrawing the window even though the character position of
3764 start_row was reached.
8547b010
EZ
3765 (Bug#9771, part 2)
3766
4e948d15
CY
37672011-10-18 Chong Yidong <cyd@gnu.org>
3768
3769 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3770 with nobreak-char-display too.
3771
4787455f
EZ
37722011-10-18 Eli Zaretskii <eliz@gnu.org>
3773
3774 Fix part 3 of bug#9771.
3775 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3776 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3777 non-neutral characters if the current character is a paragraph
3778 separator (a.k.a. Newline). This avoids running the same
3779 expensive loop twice, once when we consume the preceding newline
3780 and the other time when the line actually needs to be displayed.
3781 Avoid the loop when we see neutrals on the base embedding level
3782 following a character whose directionality is the same as the
3783 paragraph's. This avoids running the expensive loop when a line
3784 ends in a long sequence of neutrals, like control characters.
3785 Add assertion against STRONG_AL type. Slightly rearrange code
3786 that determines the type of a neutral given the first non-neutral
3787 that follows it.
3788 (bidi_level_of_next_char): Set next_en_pos to zero when
3789 invalidating its info.
3790
2c91f553
EZ
37912011-10-17 Eli Zaretskii <eliz@gnu.org>
3792
3793 * xdisp.c (push_display_prop): Determine whether to record string
3794 or buffer position by IT->string, not by IT->method. Allow
3795 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3796 (move_it_vertically_backward): Don't look for character position
3797 immediately after the newline when in a continuation line.
3798 (Bug#9771, part 1)
2c91f553 3799
c7b08b0d
MR
38002011-10-15 Martin Rudalics <rudalics@gmx.at>
3801
3802 * window.c (coordinates_in_window): Rewrite and delabelize
3803 vertical border check. (Bug#5357) (Bug#9618)
3804
6b02f655
SM
38052011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3806
3807 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3808 errors in XSetWindowBorder (bug#9310).
3809
81d40c92
DA
38102011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3811
3812 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3813 avoid crash when xmalloc overrun checking is enabled.
3814
d4172c3b
EZ
38152011-10-13 Eli Zaretskii <eliz@gnu.org>
3816
3817 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3818 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3819 cursor motion with <left> and <right> arrow keys.
3820
3821 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3822 some callers set that themselves.
3823
b00eea75
EZ
38242011-10-12 Eli Zaretskii <eliz@gnu.org>
3825
3826 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3827 display string and the previous row comes from the same string and
3828 is empty. (Bug#9739) (Bug#9738)
3829
8fe012c4
SM
38302011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3831
3832 * doc.c (get_doc_string): Encode file name (bug#9735).
3833
0074aef2
EZ
38342011-10-12 Eli Zaretskii <eliz@gnu.org>
3835
79beb178
EZ
3836 * bidi.c (bidi_level_of_next_char):
3837 * xdisp.c (get_visually_first_element): Remove old incorrect
3838 comments regarding the Unicode Line Separator character.
3839
0074aef2
EZ
3840 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3841
6e4b3fbe
DA
38422011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3843
3844 * alloc.c (Fgc_status): Do not access beyond zombies array
3845 boundary if nzombies > MAX_ZOMBIES.
3846 * alloc.c (dump_zombies): Add missing format specifier.
3847
0324f3af
PE
38482011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3849
b5525cac
PE
3850 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3851 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3852
0324f3af
PE
3853 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3854 Some packages use them to denote characters with modifiers.
3855
e9b5f888
AS
38562011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3857
3858 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3859 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3860 matching a pp-number. Rename parameter var to var1.
3861
127827c0
SM
38622011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3863
3864 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3865
c8fd3bd0
GM
38662011-10-08 Glenn Morris <rgm@gnu.org>
3867
3868 * callint.c (Fcall_interactively): Give a more explicit error for the
3869 'c' case with a non-character input. (Bug#8479)
3870
352ec8ff
EZ
38712011-10-08 Eli Zaretskii <eliz@gnu.org>
3872
03669ccb
EZ
3873 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3874 lines.
7061c986
EZ
3875 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3876 lines that are hscrolled on the left.
03669ccb 3877
352ec8ff
EZ
3878 * dispnew.c (buffer_posn_from_coords): Account for a possible
3879 presence of header-line. (Bug#4426)
3880
a66cfb1c
SM
38812011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3882
6b02f655
SM
3883 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3884 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3885
7c5ee88e
PE
38862011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3887
3888 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3889 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3890 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3891 this makes Emacs dump core during garbage collection on rare
3892 occasions. sizeof is obviously inferior to offsetof here, so
3893 stick with offsetof.
3894 (GC_POINTER_ALIGNMENT): New macro.
3895 (mark_memory): Omit 3rd (offset) arg; caller changed.
3896 Don't assume EMACS_INT alignment is the same as pointer alignment.
3897
df1bbe5b
SM
38982011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3899
3900 * keyboard.c (read_key_sequence_remapped): New var.
3901 (read_key_sequence): Compute remapping in the right buffer.
3902 (command_loop_1): Use read_key_sequence's remapping directly.
3903
51553db6
SM
39042011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3905
32c1fffd
SM
3906 * dired.c (file_name_completion): Don't expand file name.
3907 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3908 before checking file name handler.
3909
51553db6
SM
3910 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3911 they've been requested explicitly (bug#9591).
3912
b6bd1599 39132011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3914
3915 * keymap.c (Fsingle_key_description): Use make_specified_string
3916 instead of build_string to build string from push_key_description.
3917 (Bug#5193)
3918
f701dc2a
PE
39192011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3920
4222c55d
PE
3921 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3922 This fixes a Y2038 bug on 64-bit hosts.
3923 * buffer.c (reset_buffer):
3924 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3925 (Fclear_buffer_auto_save_failure):
3926 Use 0, not -1, to represent an unset failure time, since time_t
3927 might not be signed.
3928
f701dc2a
PE
3929 Remove dependency on glibc malloc internals.
3930 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3931 Move back here from lisp.h, but with their new implementations.
3932 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3933 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3934 * charset.c (charset_table_init): New static var.
3935 (syms_of_charset): Use it instead of xmalloc. This removes a
3936 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3937 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3938 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3939 Move back to alloc.c.
3940 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3941 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3942
9ceebf39
JD
39432011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3944
3945 * nsterm.m (windowDidResize): Call x_set_window_size only when
3946 ns_in_resize is true. Otherwise set pixelwidth/height and
3947 call change_frame_size (Bug#9628).
3948
cb993c58
PE
39492011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3950
3930c88b
PE
3951 Port --enable-checking=all to Fedora 14 x86-64.
3952 * charset.c (syms_of_charset): Also account for glibc malloc's
3953 internal overhead when calculating the initial malloc maximum.
3954
cb993c58
PE
3955 Port --enable-checking=all to Fedora 14 x86.
3956 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3957 Move to lisp.h.
3958 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3959 (overrun_check_realloc, overrun_check_free):
3960 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3961 That way, xmalloc returns a properly-aligned pointer even if
3962 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3963 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3964 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3965 into account when calculating the initial malloc maximum.
3966 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3967 Move here from alloc.c, so that charset.c can use it too.
3968 Properly align; the old code wasn't right for common 32-bit hosts
3969 when configured with --enable-checking=all.
3970 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3971 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3972
31bed486
EZ
39732011-09-29 Eli Zaretskii <eliz@gnu.org>
3974
04c70788 3975 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3976 use EDOM.
3977
fbcaa2f3
EZ
39782011-09-28 Eli Zaretskii <eliz@gnu.org>
3979
3980 * xdisp.c (compute_display_string_end): If there's no display
3981 string at CHARPOS, return -1.
3982
3983 * bidi.c (bidi_fetch_char): When compute_display_string_end
3984 returns a negative value, treat the character as a normal
3985 character not covered by a display string. (Bug#9624)
3986
a239d4e9
JB
39872011-09-28 Juanma Barranquero <lekktu@gmail.com>
3988
3989 * lread.c (Fread_from_string): Fix typo in docstring.
3990
88652fd5
EZ
39912011-09-27 Eli Zaretskii <eliz@gnu.org>
3992
3993 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3994 newline, reseat the iterator instead of bidi-iterating there one
3995 character at a time. (Bug#9610)
32c1fffd
SM
3996 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3997 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3998
ed497dd4
AS
39992011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4000
4001 * lread.c (readevalloop): Use correct code for NBSP.
4002 (read1): Likewise. (Bug#9608)
4003
b2bf61aa
MA
40042011-09-25 Michael Albinus <michael.albinus@gmx.de>
4005
4006 * dbusbind.c (Fdbus_register_signal): When service is not
4007 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4008
32bbb17c
GM
40092011-09-25 Glenn Morris <rgm@gnu.org>
4010
4011 * buffer.c (truncate-lines): Doc fix.
4012
94e0933e
CY
40132011-09-24 Chong Yidong <cyd@stupidchicken.com>
4014
4015 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4016 (Fset_window_next_buffers): Doc fix.
4017
cddde921
GM
40182011-09-24 Glenn Morris <rgm@gnu.org>
4019
4020 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4021
1260aef1
PE
40222011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4023
25b4bfa0
PE
4024 Fix minor problems found by static checking.
4025 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4026 * indent.c (Fvertical_motion): Fix == vs = typo.
4027
e3cbd34b
EZ
40282011-09-24 Eli Zaretskii <eliz@gnu.org>
4029
a66cfb1c
SM
4030 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4031 Default value is now t. Doc fix.
6bf7006f 4032
e3cbd34b 4033 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4034 logic when moving up, not only when moving down. Fix the
e3cbd34b 4035 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4036 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4037
4038 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4039 CHARPOS is covered by a display string which includes newlines.
4040 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4041 is covered by a display string with embedded newlines.
4042
a3de0cbd
MA
40432011-09-24 Michael Albinus <michael.albinus@gmx.de>
4044
4045 * dbusbind.c (Fdbus_register_signal): Add match rule to
4046 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4047 (Fdbus_register_method, Vdbus_registered_objects_table):
4048 Fix docstring.
a3de0cbd 4049
b260039d
JM
40502011-09-24 Jim Meyering <meyering@redhat.com>
4051
32c1fffd 4052 do not ignore write error for any output size
b260039d
JM
4053 The previous change was incomplete.
4054 While it makes emacs --batch detect the vast majority of stdout
4055 write failures, errors were still ignored whenever the output size is
4056 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4057 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4058 && echo FAIL: ignored write error
4059 FAIL: ignored write error
4060 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4061 && echo FAIL: ignored write error
4062 FAIL: ignored write error
4063 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4064
8eca8a7c
AS
40652011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4066
4067 * emacs.c (Fkill_emacs): In noninteractive mode exit
4068 non-successfully if a write error occurred on stdout. (Bug#9574)
4069
3341db62
EZ
40702011-09-21 Eli Zaretskii <eliz@gnu.org>
4071
4072 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4073 the xassert test.
4074
4075 * dispextern.h (struct it): Update the comment documenting what
4076 can it->OBJECT be.
4077
8c203dbf
EZ
40782011-09-20 Eli Zaretskii <eliz@gnu.org>
4079
4080 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4081 a display string, extend search for cursor position to end of row.
4082 (find_row_edges): If the row ends in a newline from a display
4083 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4084 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4085 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4086 non-empty line. Fixes confusing cursor motion with arrow keys at
4087 the beginning of a line that starts with whitespace.
8c203dbf 4088
a4824228
LMI
40892011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4090
4091 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4092 (bug#9493).
4093
33ed493b
CY
40942011-09-18 Chong Yidong <cyd@stupidchicken.com>
4095
4096 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4097 boolean (Bug#9154).
4098
56cd55c8
EZ
40992011-09-18 Eli Zaretskii <eliz@gnu.org>
4100
4101 * xdisp.c (display_line): Record maximum and minimum buffer
4102 positions even if no glyphs were produced (e.g., by a zero-width
4103 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4104 buffer positions that will be removed from the glyph row because
4105 they don't fit.
c02dcedf
EZ
4106 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4107 column is beyond frame width: don't subtract 1 "pixel" when
4108 computing width of the stretch.
3e62b7e0
EZ
4109 (reseat_at_next_visible_line_start): Undo the change made on
4110 2011-09-17 that saved paragraph information and restored it after
4111 the call to `reseat'. (Bug#9545)
56cd55c8 4112
5ed99d36 41132011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4114
4115 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4116 and turn window cursor on if cleared (Bug#9415).
4117
5ed99d36 41182011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4119
4120 * search.c (boyer_moore): Take unibyte characters from pattern
4121 literally. (Bug#9458)
4122
9bade7b2
EZ
41232011-09-18 Eli Zaretskii <eliz@gnu.org>
4124
4125 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4126
e5e9d610
PE
41272011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4128
87e4427a
PE
4129 Fix minor problem found by static checking.
4130 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4131 initialized, to pacify gcc -Wuninitialized.
4132
e5e9d610
PE
4133 * fileio.c: Report proper errno when syscall falls.
4134 (Finsert_file_contents): Save and restore errno,
4135 so that report_file_error outputs the correct diagnostic.
4136 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4137
a1674f0b
EZ
41382011-09-18 Eli Zaretskii <eliz@gnu.org>
4139
4140 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4141
fbfb6dd4
EZ
41422011-09-17 Eli Zaretskii <eliz@gnu.org>
4143
4144 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4145 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4146
bb187662
EZ
41472011-09-17 Eli Zaretskii <eliz@gnu.org>
4148
1137e8b8 4149 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4150 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4151
4152 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4153 (bidi_find_paragraph_start): Search back for paragraph beginning
4154 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4155 (bidi_move_to_visually_next): Only trigger paragraph-related
4156 computations when the last character is a newline or at EOB, not
4157 just any NEUTRAL_B. (Bug#9470)
4158
bb187662
EZ
4159 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4160 truncated lines if point is covered by a display string. (Bug#9524)
4161
2e621251
PE
41622011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4163
4164 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4165 (cons_to_x_long): New function.
4166 (lisp_data_to_selection_data): Use it. Correct the test for
4167 short-versus-long data; it was negated. Break out of vector
4168 loop, for efficiency, when a long datum is discovered.
4169
91a15bc6
SM
41702011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4171
4172 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4173
b41c3a35
EZ
41742011-09-16 Eli Zaretskii <eliz@gnu.org>
4175
4176 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4177 GCC PR/17406) by declaring this function with external scope.
4178
7812ba2d
PE
41792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4180
4181 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4182 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4183
cf7edc2a
AS
41842011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4185
4186 * editfns.c (Fformat): Correctly handle text properties on "%%".
4187
bd01620e
EZ
41882011-09-15 Eli Zaretskii <eliz@gnu.org>
4189
4190 * xterm.c (x_draw_composite_glyph_string_foreground):
4191 * w32term.c (x_draw_composite_glyph_string_foreground):
4192 * term.c (encode_terminal_code):
4193 * composite.c (composition_update_it, get_composition_id):
4194 * xdisp.c (get_next_display_element)
4195 (fill_composite_glyph_string): Add comments about special meaning
4196 of TAB characters in a composition.
4197
a02719a3
PE
41982011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4199
4200 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4201 This occurs when processing a multibyte format.
4202 Problem reported by Wolfgang Jenker.
a02719a3 4203
72589a3c
JB
42042011-09-15 Johan Bockgård <bojohan@gnu.org>
4205
4206 * xdisp.c (try_cursor_movement): Only check for exact match if
4207 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4208
1c14176c
PE
42092011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4210
4211 Remove unused external symbols.
4212 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4213 * xdisp.c (calc_pixel_width_or_height): Now static.
4214 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4215 * indent.c (check_display_width):
4216 * w32term.c: Fix comment to match code.
4217 * xterm.c, xterm.h (x_catching_errors): Remove.
4218
d2eea5b5
PE
42192011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4220
4221 * xselect.c: Use signed conversions more consistently (Bug#9498).
4222 (selection_data_to_lisp_data): Assume incoming selection data are
4223 signed integers, not unsigned. This is to be consistent with
4224 outgoing selection data, which was modified to use signed integers
4225 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4226 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4227 expects long, not unsigned long.
4228
46888499
EZ
42292011-09-14 Eli Zaretskii <eliz@gnu.org>
4230
4231 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4232 computation of loop end. Reported by Johan Bockgård
4233 <bojohan@gnu.org>.
4234
ef8ef9fb
CY
42352011-09-13 Chong Yidong <cyd@stupidchicken.com>
4236
4237 * frame.c (Fother_visible_frames_p): Function deleted.
4238
fa819fed
EZ
42392011-09-12 Eli Zaretskii <eliz@gnu.org>
4240
4241 * indent.c (compute_motion): Process display vector front to back
4242 rather than the other way around. (Bug#2496)
4243
2ba8e008
SM
42442011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4245
4246 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4247
20f53c69
CY
42482011-09-11 Chong Yidong <cyd@stupidchicken.com>
4249
4250 * minibuf.c (Fread_from_minibuffer): Doc fix.
4251
d562d7a4
EZ
42522011-09-11 Eli Zaretskii <eliz@gnu.org>
4253
4254 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4255 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4256
1c4d7f3d
LMI
42572011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4258
4259 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4260 value for non-existent files.
4261
b885bf36
EZ
42622011-09-11 Eli Zaretskii <eliz@gnu.org>
4263
4264 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4265 set its "size" to -1. This will set the modtime_size field of
4266 the corresponding buffer to -1, which is what
4267 verify-visited-file-modtime expects for files that do not exist.
4268 (Bug#9139)
4269
6612f0bf
PE
42702011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4271
4272 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4273 here ...
4274 * lisp.h: ... from here. push_key_description is no longer
4275 defined in keyboard.c, so its declaration should not be in
4276 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4277 logically belongs with push_key_description.
4278
dfb3f755
PE
42792011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4280
4281 * buffer.h: Include <sys/types.h> instead of <time.h>.
4282 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4283 Problem reported by Herbert J. Skuhra.
4284
3134906c
LMI
42852011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4286
4287 * xml.c (parse_region): Make the parsing work for
4288 non-comment-starting XML files again (bug#9144).
4289
8d903f4e
AS
42902011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4291
4292 * image.c (gif_load): Fix calculation of bottom and right corner.
4293 (Bug#9468)
4294
80ad64f4
EZ
42952011-09-10 Eli Zaretskii <eliz@gnu.org>
4296
4297 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4298 redisplay in small windows.
4299
208a048d
EZ
43002011-09-09 Eli Zaretskii <eliz@gnu.org>
4301
4302 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4303
9b1c252e
MR
43042011-09-08 Martin Rudalics <rudalics@gmx.at>
4305
4306 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4307 Operate on live windows only.
4308
2949f33b
JB
43092011-09-08 Juanma Barranquero <lekktu@gmail.com>
4310
4311 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4312
e08dcafd
EZ
43132011-09-07 Eli Zaretskii <eliz@gnu.org>
4314
4315 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4316 only under bidi iteration.
4317
115b96bd
JD
43182011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4319
4320 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4321
c8199d0f
PE
43222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4323
4324 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4325 Without this fix, the command to link temacs failed due to an
4326 undefined symbol __builtin_isnan. This is because
4327 /usr/include/iso/math_c99.h #defines isnan(x) to
4328 __builtin_isnan(x), but the bundled gcc, which identifies itself
4329 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4330 a __builtin_isnan.
4331 * floatfns.c (isnan): #undef, and then #define to a clone of
4332 what's in data.c.
4333 (Fisnan): Always define, since it's always available now.
4334 (syms_of_floatfns): Always define isnan at the Lisp level.
4335
e39b275c 43362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4337
4338 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4339
b2db44d9 43402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4341
f4af5137 4342 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4343 The previous code assumed that file offsets (off_t values) fit in
4344 EMACS_INT variables, which is not true on typical 32-bit hosts.
4345 The code messed up by falsely reporting buffer overflow in cases
4346 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4347 when "big" contains more than 2**29 bytes, even though this
4348 inserts just one byte and does not overflow the buffer.
4349 (Finsert_file_contents): Store file offsets as off_t
4350 values, not as EMACS_INT values. Check for overflow when
4351 converting between EMACS_INT and off_t. When checking for
4352 buffer overflow or for overlap, take the offsets into account.
4353 Don't use EMACS_INT for small values where int suffices.
4354 When checking for overlap, fix a typo: ZV was used where
4355 ZV_BYTE was intended.
4356 (Fwrite_region): Don't assume off_t fits into 'long'.
4357 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4358
ecfc0a49
MA
43592011-09-05 Michael Albinus <michael.albinus@gmx.de>
4360
4361 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4362
6511acf2 43632011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4364
0999621a 4365 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4366
4367 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4368 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4369 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4370 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4371 (modify_event_symbol): Do not assume that the length of
4372 name_alist_or_stem is safe to alloca and fits in int.
4373 (Fexecute_extended_command): Likewise for function name and binding.
4374 (Frecursion_depth): Wrap around reliably on integer overflow.
4375 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4376 since some callers pass EMACS_INT values.
4377 (Fsingle_key_description): Don't crash if symbol name contains more
4378 than MAX_ALLOCA bytes.
4379 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4380 (get_minibuffer): Arg is now EMACS_INT, not int.
4381 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4382 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4383 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4384
2be7d702
PE
4385 * dbusbind.c (signature_cat): New function.
4386 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4387 Do not overrun buffer; instead, report string overflow.
4388
9d1df220
PE
4389 * dispnew.c (add_window_display_history): Don't overrun buffer.
4390 Truncate instead; this is OK since it's just a log.
4391
33ef5c64
PE
4392 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4393 even if the time zone offset is outlandishly large.
4394 Don't mishandle offset == INT_MIN.
4395
66c6fdd5
PE
4396 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4397 when creating daemon; the previous buffer-overflow check was incorrect.
4398
d749b01b
PE
4399 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4400 which has the guts of the old verror function.
4401
b5cd1905
PE
4402 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4403 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4404
6e1a67fb
PE
4405 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4406 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4407 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4408 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4409 length of string rather than counting it via multiple sprintfs;
4410 that's simpler and more reliable.
c21721cc
PE
4411 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4412 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4413 sprintf, in case result does not fit in int.
4414
c57b67fc
PE
4415 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4416 (fontset_from_font): Print it.
4417
8a401434
PE
4418 * frame.c (tty_frame_count): Now printmax_t, not int.
4419 (make_terminal_frame, set_term_frame_name): Print it.
4420 (x_report_frame_params): In X, window IDs are unsigned long,
4421 not signed long, so print them as unsigned.
4422 (validate_x_resource_name): Check for implausibly long names,
4423 and don't assume name length fits in 'int'.
4424 (x_get_resource_string): Don't blindly alloca invocation name;
4425 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4426 not fit in int.
4427
6e1a67fb
PE
4428 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4429 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4430 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4431
0df02bf3
PE
4432 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4433 Use esprintf, not sprintf, in case result does not fit in int.
4434
48e30793
PE
4435 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4436 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4437 it as a large positive number.
4438 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4439 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4440
a66ff6d8
PE
4441 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4442 in case result does not fit in int.
4443
aca216ff
PE
4444 * print.c (float_to_string): Detect width overflow more reliably.
4445 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4446 buffer overrun. Don't assume list length fits in 'int'. Treat
4447 print length of 0 as 0, not as infinity; to be consistent with other
4448 uses of print length in this function. Don't overflow print length
4449 index. Don't assume hash table size fits in 'long', or that
4450 vectorlike size fits in 'unsigned long'.
4451
31c286f7
PE
4452 * process.c (make_process): Use printmax_t, not int, to format
4453 process-name gensyms.
4454
55e5faa1
PE
4455 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4456
80f2e268
PE
4457 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4458 to avoid potential buffer overrun.
4459
670741ab
PE
4460 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4461 if X resource line is longer than 512 bytes.
4462
b7163a50
PE
4463 * xfns.c (x_window): Make sprintf buffer a bit bigger
4464 to avoid potential buffer overrun.
4465
ae58ff1f
PE
4466 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4467
c43c8a6a
PE
4468 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4469
3f8236f4
PE
44702011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4471
53e9fe90 4472 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4473 Without these, Emacs silently mishandles large integers sometimes.
4474 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4475 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4476
6511acf2
PE
4477 * xdisp.c (try_window_id): Check Emacs fixnum range before
4478 converting to 'int'.
806add1d 4479
6511acf2 4480 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4481 Check that an Emacs fixnum is in range before assigning it to 'int'.
4482 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4483 values converted from Emacs fixnums.
4484 (Frecenter): Don't wrap around a line count if it is out of 'int'
4485 range; instead, treat it as an extreme value.
4486 (Fset_window_configuration, compare_window_configurations):
4487 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4488
6511acf2
PE
4489 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4490 that can exceed INT_MAX. Check that EMACS_INT value is in range
4491 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4492 (match_limit): Don't assume that a fixnum can fit in 'int'.
4493
6511acf2 4494 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4495 exceed INT_MAX.
4496
6511acf2 4497 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4498 (Fvertical_motion): Don't wrap around LINES values that don't fit
4499 in 'int'. Instead, treat them as extreme values. This is good
4500 enough for windows, which can't have more than INT_MAX lines anyway.
4501
fcb901a7
LMI
45022011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4503
0f2f6b6d
LMI
4504 * Require libxml/parser.h to avoid compilation warning.
4505
fcb901a7
LMI
4506 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4507
4508 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4509 since this reportedly can destroy thread storage.
4510
6e20a0d4
CY
45112011-08-30 Chong Yidong <cyd@stupidchicken.com>
4512
4513 * syntax.c (find_defun_start): Update all cache variables if
4514 exiting early (Bug#9401).
4515
148ae00e
EZ
45162011-08-30 Eli Zaretskii <eliz@gnu.org>
4517
f6cfbd8f
EZ
4518 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4519
148ae00e
EZ
4520 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4521 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4522 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4523
4524 * term.c (tty_append_glyph): New function.
4525 (produce_stretch_glyph): Static function and its prototype deleted.
4526
a66cfb1c
SM
4527 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4528 Add prototypes.
148ae00e 4529
c4a07a4c
PE
45302011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4531
4532 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4533 when checking :margin (Bug#9390).
4534 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4535 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4536 so that the name doesn't mislead. All uses changed.
4537
6bc8cd65
JB
45382011-08-28 Johan Bockgård <bojohan@gnu.org>
4539
4540 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4541 set_tty_hooks.
4542
dca4927e
EZ
45432011-08-27 Eli Zaretskii <eliz@gnu.org>
4544
4545 * xdisp.c (move_it_to): Don't bail out early when reaching
4546 position beyond to_charpos, if we are scanning backwards.
4547 (move_it_vertically_backward): When DY == 0, make sure we get to
4548 the first character in the line after the newline.
4549
f2cad773
PE
45502011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4551
4552 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4553 (ccl_driver): Do not generate an out-of-range pointer.
4554 (Fccl_execute_on_string): Remove unnecessary check for
4555 integer overflow, noted by Stefan Monnier in
4556 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4557 Remove a FIXME that didn't need fixing.
4558 Simplify the newly-introduced buffer reallocation code.
4559
0cae2cdb
JB
45602011-08-27 Juanma Barranquero <lekktu@gmail.com>
4561
4562 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4563
5fc295a4 45642011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4565
70c60eb2 4566 Integer and memory overflow issues (Bug#9196).
726e0ab1 4567
d31850da
PE
4568 * doc.c (get_doc_string): Rework so that
4569 get_doc_string_buffer_size is the actual buffer size, rather than
4570 being 1 less than the actual buffer size; this makes xpalloc more
4571 convenient.
4572
a69fbedb
PE
4573 * image.c (x_allocate_bitmap_record, cache_image):
4574 * xselect.c (Fx_register_dnd_atom):
4575 Simplify previous changes by using xpalloc.
4576
fe5c5d37
PE
4577 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4578 since either will do and ptrdiff_t is convenient with xpalloc.
4579
0065d054
PE
4580 * charset.c (charset_table_size)
4581 (struct charset_sort_data.priority): Now ptrdiff_t.
4582 (charset_compare): Don't overflow if priorities differ greatly.
4583 (Fsort_charsets): Don't assume list length fits in int.
4584 Check for size-calculation overflow when allocating sort data.
4585 (syms_of_charset): Allocate an initial charset table that is
4586 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4587
4588 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4589
4590 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4591 The actual value is always <= INT_MAX, and leaving it unsigned made
4592 overflow checking harder.
4593
4594 * dispextern.h (struct glyph_matrix.rows_allocated)
4595 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4596 with xpalloc. The values are still always <= INT_MAX.
4597
4598 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4599
4600 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4601 (SAFE_NALLOCA): New macro.
4602
4603 * region-cache.c (struct boundary.pos, find_cache_boundary)
4604 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4605 (set_cache_region, invalidate_region_cache)
4606 (revalidate_region_cache, know_region_cache, region_cache_forward)
4607 (region_cache_backward, pp_cache):
4608 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4609 so that ptrdiff_t * can be passed to xpalloc.
4610 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4611 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4612 (pp_cache): Don't assume cache_len fits in int.
4613 * region-cache.h: Adjust extern decls to match.
4614
4615 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4616 EMACS_INT, since either will do, for xpalloc.
4617
4618 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4619 (xnmalloc, xnrealloc, xpalloc): New functions.
4620
726e0ab1
PE
4621 * bidi.c (bidi_shelve_header_size): New constant.
4622 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4623 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4624
51f30bc5 4625 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4626 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4627 (overlay_strings):
4628 Don't update size of array until after memory allocation succeeds,
4629 because xmalloc/xrealloc may not return.
0065d054
PE
4630 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4631 now that we have proper integer overflow checking.
4632 (record_overlay_string, overlay_strings): Catch overflows when
4633 calculating size of overlay_str_buf.
726e0ab1 4634
0065d054
PE
4635 * callproc.c (Fcall_process): Check for size overflow when
4636 calculating size of args2.
4637 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4638 Normally we prefer signed values, but sticking with ptrdiff_t would
4639 require adding more-complicated checks.
726e0ab1
PE
4640
4641 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4642 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4643 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4644 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4645
4646 * character.c (Fstring): Check for size-calculation overflow.
4647
4648 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4649 unnecessary integer overflow. Check for size overflow.
4650 (encode_coding_object): Don't update size until xmalloc succeeds.
4651
4652 * composite.c (get_composition_id): Check for overflow in glyph
4653 length calculations.
4654
4655 Integer and memory overflow fixes for display code.
4656 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4657 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4658 (scrolling_window): Check for overflow in size calculations.
4659 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4660 Don't assume glyph table len fits in int.
4661 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4662 (row_table_size): Now ptrdiff_t, not int.
4663 (scrolling_window): Avoid overflow in size calculations.
4664 Don't update size until allocation succeeds.
4665 * fns.c (concat): Check for overflow in size calculations.
4666 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4667 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4668 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4669
4670 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4671 (get_doc_string): Check for size calculation overflow.
4672 Don't update size until allocation succeeds.
4673 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4674 EMACS_INT, where ptrdiff_t will do.
4675 (Fsubstitute_command_keys): Check for string overflow.
4676
4677 * editfns.c (set_time_zone_rule): Don't assume environment length
4678 fits in int.
4679 (message_length): Now ptrdiff_t, not int.
4680 (Fmessage_box): Don't update size until allocation succeeds.
4681 Don't assume message length fits in int.
4682 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4683
0065d054
PE
4684 * emacs.c (main): Do not reallocate argv, since there is a null at
4685 the end that can be overwritten, and this way there's no need to
4686 worry about size-calculation overflow.
4687 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4688
4689 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4690 alloc succeeds.
4691 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4692
4693 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4694 (x_set_scroll_bar_width, x_figure_window_size):
4695 Check for integer overflow.
4696 (x_set_alpha): Do not assume XINT fits in int.
4697
4698 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4699 This is for the members text_lines, text_cols, total_lines, total_cols,
4700 where the system imposes an 'int' limit.
4701
4702 * fringe.c (Fdefine_fringe_bitmap):
4703 Don't update size until alloc works.
4704
4705 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4706 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4707
4708 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4709 Check for size-calculation overflow.
4710 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4711 do, as we prefer signed integers.
4712 (id_to_widget.max_size, id_to_widget.used)
4713 (xg_store_widget_in_map, xg_remove_widget_from_map)
4714 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4715 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4716 Use and return ptrdiff_t, not int.
4717 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4718 * gtkutil.h: Change prototypes to match the above.
4719
4720 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4721 are duplicate now that they've been promoted to lisp.h.
4722 (x_allocate_bitmap_record, x_alloc_image_color)
4723 (make_image_cache, cache_image, xpm_load):
4724 Don't update size until alloc is done.
4725 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4726 (x_detect_edges):
3256efce 4727 Check for size calculation overflow.
726e0ab1
PE
4728 (ct_colors_allocated_max): New constant.
4729 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4730 overflow.
3256efce 4731
726e0ab1
PE
4732 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4733 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4734 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4735 Use ptrdiff_t, not int, to count maps.
4736 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4737 calculations. Don't update size until allocation succeeds.
4738 Redo calculations to avoid overflow.
726e0ab1
PE
4739 * keyboard.h: Change prototypes to match the above.
4740
4741 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4742 to count maps.
4743 (current_minor_maps): Check for size calculation overflow.
4744 * keymap.h: Change prototypes to match the above.
4745
4746 * lread.c (read1, init_obarray): Don't update size until alloc done.
4747
4748 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4749 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4750
726e0ab1
PE
4751 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4752 Now ptrdiff_t, not int.
4753 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4754 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4755
4756 * process.c (Fnetwork_interface_list): Check for overflow
4757 in size calculation.
4758
4759 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4760
4761 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4762 overflow. Don't bother calling xmalloc when xrealloc will do.
4763
4764 * search.c (Freplace_match): Check for size calculation overflow.
4765 (Fset_match_data): Don't assume list lengths fit in 'int'.
4766
4767 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4768 for command line length. Do not attempt to address one before the
4769 beginning of an array, as that's not portable.
4770
4771 * term.c (max_frame_lines): Remove; unused.
4772 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4773 not int.
4774 (encode_terminal_code, calculate_costs): Check for size
4775 calculation overflow.
4776 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4777 table lengths and related sizes. Don't update size until alloc
4778 done. Redo calculations to avoid overflow.
4779 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4780
4781 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4782 subtracting pointers.
4783 (gobble_line): Check for overflow more carefully. Don't update size
4784 until alloc done.
4785
4786 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4787 Don't update size until alloc done.
4788 Redo size calculations to avoid overflow.
4789 Check for size calculation overflow.
0065d054 4790 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4791
4792 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4793 Use ptrdiff_t, not int, for sizes.
4794 (store_mode_line_noprop_char): Don't update size until alloc done.
4795
0065d054
PE
4796 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4797 Use ptrdiff_t, not int, for sizes.
4798 (Finternal_make_lisp_face, cache_face):
4799 Check for size calculation overflow.
4800 (cache_face): Treat size calculation overflows as if they were
4801 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4802
4803 * xfns.c (x_encode_text, x_set_name_internal)
4804 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4805 sizes, since they can exceed INT_MAX in size. Check for size
4806 calculation overflow.
4807
0065d054
PE
4808 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4809 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4810 Don't update size until alloc done.
4811
0065d054 4812 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4813 as sprintf is limited to int lengths.
1d526e2f 4814
252c5ee1
PE
4815 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4816 (X_LONG_MIN): New macros.
864d7ce7
PE
4817 Use them to make the following changes clearer.
4818 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4819 This change doesn't affect the value now, but it may help remind
4820 future maintainers not to raise the value too much later.
4821 (SELECTION_QUANTUM): Remove, replacing with ...
4822 (selection_quantum): ... new function, which avoids overflow.
4823 All uses changed.
4824 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4825 assumption that selection length fits in 'int'.
4826 (x_reply_selection_request, x_handle_selection_request)
4827 (x_get_window_property, receive_incremental_selection)
4828 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4829 (lisp_data_to_selection_data, clean_local_selection_data):
4830 Use ptrdiff_t, not int, to record length of selection.
4831 (x_reply_selection_request, x_get_window_property)
4832 (receive_incremental_selection, x_property_data_to_lisp):
4833 Redo calculations to avoid overflow.
4834 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4835 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4836 something.
4837 (x_get_window_property, receive_incremental_selection)
4838 (lisp_data_to_selection_data, x_property_data_to_lisp):
4839 Check for size-calculation overflow.
4840 (x_get_window_property, receive_incremental_selection)
4841 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4842 Don't store size until memory allocation succeeds.
4843 (x_get_window_property): Plug memory leak on memory exhaustion.
4844 Don't double-block input; malloc is safe here. Don't assume 2**34
4845 - 4 fits in unsigned long. Add an xassert to check
4846 XGetWindowProperty overflow. Be more careful about overflow
4847 calculations, and distinguish size from memory overflow better.
4848 (receive_incremental_selection): When tracing, don't assume
4849 unsigned int is less than INT_MAX.
4850 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4851 harmful) conversions of unsigned short to int.
4852 (lisp_data_to_selection_data): Don't assume that integers
4853 in the range -65535 through -1 fit in an X unsigned short.
4854 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4855 result parameters unless successful. Rely on cons_to_unsigned
4856 to report problems with elements; the old code wasn't right anyway.
4857 (x_check_property_data): Check for int overflow; we cannot use
4858 a wider type due to X limits.
4859 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4860
726e0ab1 4861 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4862
0065d054
PE
4863 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4864 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4865 (x_color_cells): Don't store size until memory allocation succeeds.
4866 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4867 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4868 (x_term_init): Don't assume length fits in int (sprintf is limited
4869 to int size).
bc18e09d 4870
ebfa62c0
PE
4871 Use ptrdiff_t for composition IDs.
4872 * character.c (lisp_string_width):
4873 * composite.c (composition_table_size, n_compositions)
4874 (get_composition_id, composition_gstring_from_id):
4875 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4876 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4877 * window.c (Frecenter):
4878 Use ptrdiff_t, not int, for composition IDs.
4879 * composite.c (get_composition_id): Check for integer overflow.
4880 * composite.h: Adjust prototypes to match the above changes.
4881
d3411f89
PE
4882 Use ptrdiff_t for hash table indexes.
4883 * category.c (hash_get_category_set):
4884 * ccl.c (ccl_driver):
4885 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4886 * coding.c (coding_system_charset_list, detect_coding_system):
4887 * coding.h (struct coding_system.id):
4888 * composite.c (get_composition_id, gstring_lookup_cache):
4889 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4890 * image.c (xpm_get_color_table_h):
4891 * lisp.h (hash_lookup, hash_put):
4892 * minibuf.c (Ftest_completion):
4893 Use ptrdiff_t for hash table indexes, not int (which is too
4894 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4895 32-bit --with-wide-int hosts).
4896
e097a6fa
PE
4897 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4898 Add a FIXME comment about memory leaks.
4899 (syms_of_charset): Don't assume xmalloc returns.
4900
5637687f
PE
4901 Don't assume that stated character widths fit in int.
4902 * character.c (Fchar_width, c_string_width, lisp_string_width):
4903 * character.h (CHAR_WIDTH):
4904 * indent.c (MULTIBYTE_BYTES_WIDTH):
4905 Use sanitize_char_width to avoid undefined and/or bad behavior
4906 with outlandish widths.
a66cfb1c 4907 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4908 now that we have two such functions. All uses changed.
4909 (sanitize_char_width): New inline function.
4910
a2271ba2
PE
4911 Don't assume that tab-width fits in int.
4912 * character.h (sanitize_width): New inline function.
4913 (SANE_TAB_WIDTH): New macro.
4914 (ASCII_CHAR_WIDTH): Use it.
4915 * indent.c (sane_tab_width): Remove. All uses replaced by
4916 SANE_TAB_WIDTH (current_buffer).
4917 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4918
18c52557
PE
4919 * fileio.c: Integer overflow issues with file modes.
4920 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4921
caeeedc1
PE
4922 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4923 Remove unreachable code.
4924 (read_hex, load_charset_map_from_file): Check for integer overflow.
4925
6df6ae42 4926 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4927 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4928 (x_send_scroll_bar_event): Likewise. Check that the size does not
4929 exceed limits imposed by XClientMessageEvent, as well as the usual
4930 ptrdiff_t and size_t limits.
4931
b13995db
PE
4932 * keyboard.c: Overflow, signedness and related fixes.
4933 (make_lispy_movement): Use same integer type in forward decl
4934 that is used in the definition.
4935 (read_key_sequence, keyremap_step):
4936 Change bufsize argument back to int, undoing my 2011-03-30 change.
4937 We prefer signed types, and int is wide enough here.
4938 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4939 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4940 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4941 length, not size_t. Use ptrdiff_t for index, not int.
4942 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4943 possibility of integer overflow.
4944
13464394
PE
4945 Overflow, signedness and related fixes for images.
4946
4947 * dispextern.h (struct it.stack[0].u.image.image_id)
4948 (struct_it.image_id, struct image.id, struct image_cache.size)
4949 (struct image_cache.used, struct image_cache.ref_count):
4950 * gtkutil.c (update_frame_tool_bar):
4951 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4952 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4953 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4954 * nsmenu.m (update_frame_tool_bar):
4955 * xdisp.c (calc_pixel_width_or_height):
4956 * xfns.c (image_cache_refcount):
4957 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4958 on typical 64-bit hosts.
4959
4960 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4961 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4962 Omit unnecessary casts to int.
4963 (parse_image_spec): Check that integers fall into 'int' range
4964 when the callers expect that.
4965 (image_ascent): Redo ascent calculation to avoid int overflow.
4966 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4967 (lookup_image): Remove unnecessary tests.
4968 (xbm_image_p): Locals are now of int, not EMACS_INT,
4969 since parse_image_check makes sure they fit into int.
4970 (png_load, gif_load, svg_load_image):
4971 Prefer int to unsigned where either will do.
4972 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4973 old tiff_error_handler and tiff_warning_handler.
4974 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4975 stack buffer overflows. It uses only the features of vsnprintf
4976 that are common to both POSIX and native Microsoft.
4977 (tiff_error_handler, tiff_warning_handler): Use it.
4978 (tiff_load, gif_load, imagemagick_load_image):
4979 Don't assume :index value fits in 'int'.
4980 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4981 (imagemagick_load_image): Check that crop parameters fit into
4982 the integer types that MagickCropImage accepts. Don't assume
4983 Vimagemagick_render_type has a nonnegative value. Don't assume
4984 size_t fits in 'long'.
4985 (gs_load): Use printmax_t to print the widest integers possible.
4986 Check for integer overflow when computing image height and width.
4987
c11821d4
EZ
49882011-08-26 Eli Zaretskii <eliz@gnu.org>
4989
4990 * xdisp.c (redisplay_window): Don't force window start if point
4991 will be invisible in the resulting window. (Bug#9324)
4992
0c95fcf7
EZ
49932011-08-25 Eli Zaretskii <eliz@gnu.org>
4994
4995 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4996 the display spec is of the form `(space ...)'.
4997 (handle_display_spec): Return the value returned by
4998 handle_single_display_spec, not just 1 or zero.
4999 (handle_single_display_spec): If the display spec is of the form
5000 `(space ...)', and specifies display in the text area, return 2
5001 rather than 1.
fee65a97 5002 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5003 accurately, and prefer exact match for point under bidi.
5004 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5005
5006 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5007 into disp_prop; all users changed.
5008
5009 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5010 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5011 for the text covered by the display property.
5012
e4ed06f1
CY
50132011-08-25 Chong Yidong <cyd@stupidchicken.com>
5014
5015 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5016 Change return value to nil.
5017 (Frecord_buffer): Delete unused function.
5018
f67cdd7f
EZ
50192011-08-24 Eli Zaretskii <eliz@gnu.org>
5020
5980d4c6
EZ
5021 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5022 buffers, return left-to-right.
8610fe8b
EZ
5023 (set_cursor_from_row): Consider candidate row a win if its glyph
5024 represents a newline and point is on that newline. Fixes cursor
5025 positioning on the newline at EOL of R2L text within L2R
5026 paragraph, and vice versa.
5027 (try_cursor_movement): Check continued rows, in addition to
5028 continuation rows. Fixes unwarranted scroll when point enters a
5029 continued line of R2L text within an L2R paragraph, or vice versa.
5030 (cursor_row_p): Consider the case of point being equal to
5031 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5032 from the end of a short line to the beginning of a continued line
5033 of R2L text within L2R paragraph.
5034 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5035 composed characters.
5980d4c6 5036
f67cdd7f
EZ
5037 * bidi.c (bidi_check_type): Use xassert.
5038 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5039 members.
5040
bca633fb
EZ
50412011-08-23 Eli Zaretskii <eliz@gnu.org>
5042
5043 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5044 a character.
5045
4a5885a7
CY
50462011-08-23 Chong Yidong <cyd@stupidchicken.com>
5047
5048 * nsfont.m (ns_otf_to_script): Fix typo.
5049
0902a04e
KH
50502011-08-22 Kenichi Handa <handa@m17n.org>
5051
5052 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5053 extra slot even if the purpose is char-code-property-table.
5054
1a2e6670
EZ
50552011-08-23 Eli Zaretskii <eliz@gnu.org>
5056
8ddde651
EZ
5057 * xdisp.c (redisplay_window): When computing centering_position,
5058 account for the height of the header line. (Bug#8874)
5059
425cc014
EZ
5060 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5061 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5062 candidate is selected by the mouse, and that candidate has a
5063 composed character under the mouse.
5064
1a2e6670
EZ
5065 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5066 coordinates reported by pos-visible-in-window-p for a composed
5067 character in column zero.
5068
8b76d6f8
SM
50692011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5070
5071 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5072
dac347dd
EZ
50732011-08-22 Eli Zaretskii <eliz@gnu.org>
5074
5075 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5076 consider it a hit if to_charpos is anywhere in the range of the
5077 composed buffer positions.
5078
e013fb34
CY
50792011-08-22 Chong Yidong <cyd@stupidchicken.com>
5080
5081 * image.c (gif_load): Don't assume that each subimage has the same
5082 dimensions as the base image. Handle disposal method that is
5083 "undefined" by the gif spec (Bug#9335).
5084
bd1ba3e8
CY
50852011-08-20 Chong Yidong <cyd@stupidchicken.com>
5086
5087 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5088 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5089
54a1215b
EZ
50902011-08-19 Eli Zaretskii <eliz@gnu.org>
5091
823564e5
EZ
5092 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5093 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5094 from an Org mode buffer to a Speedbar frame.
5095
54a1215b
EZ
5096 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5097 a composition, take its buffer position from IT->cmp_it.charpos.
5098 Fixes cursor positioning at the beginning of a line that begins
5099 with a composed character.
5100
9778ebcc
EZ
51012011-08-18 Eli Zaretskii <eliz@gnu.org>
5102
0be6ee06
EZ
5103 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5104 character bidirectional type, use STRONG_L instead. Fixes crashes
5105 in a buffer produced by `describe-categories'.
5106
9778ebcc
EZ
5107 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5108 members before the level stack, so they would be saved and
5109 restored when copying iterator state. Fixes incorrect reordering
5110 around TABs covered by display properties.
5111
156bffbe
AS
51122011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5113
6b02f655 5114 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5115
72ad093b
CY
51162011-08-17 Chong Yidong <cyd@stupidchicken.com>
5117
5118 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5119 (internal_condition_case_2, internal_condition_case_n):
5120 Remove unnecessary aborts (Bug#9081).
72ad093b 5121
35774242
EZ
51222011-08-17 Eli Zaretskii <eliz@gnu.org>
5123
5124 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5125 has no `load' handler, try opening the file locally. (Bug#9311)
5126
db76dd85
KB
51272011-08-16 Ken Brown <kbrown@cornell.edu>
5128
5129 * gmalloc.c: Expand comment.
5130
b215eee5
EZ
51312011-08-16 Eli Zaretskii <eliz@gnu.org>
5132
5133 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5134 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5135
a4579d33
KB
51362011-08-16 Ken Brown <kbrown@cornell.edu>
5137
5138 Fix memory allocation problems in Cygwin build (Bug#9273).
5139
5140 * unexcw.c ( __malloc_initialized): Declare external variable.
5141 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5142
8b76d6f8
SM
5143 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5144 New variables.
a4579d33
KB
5145 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5146 dumped emacs.
5147 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5148 in the static heap.
5149 [CYGWIN] (special_realloc): New function.
5150 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5151 requests to realloc storage in the static heap.
5152
3ebec551
PE
51532011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5154
5155 * bidi.c (bidi_initialize): Remove unused local.
5156
9fd8be00
EZ
51572011-08-15 Eli Zaretskii <eliz@gnu.org>
5158
6b02f655
SM
5159 * bidimirror.h:
5160 * biditype.h: Remove file.
5161 * makefile.w32-in ($(BLD)/bidi.$(O)):
5162 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5163
5164 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5165
5166 * chartab.c: Improve commentary for the uniprop_table API.
5167
32413314
EZ
5168 * bidi.c (bidi_paragraph_init): Support zero value of
5169 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5170 (bidi_initialize): Use uniprop_table instead of including
5171 biditype.h and bidimirror.h.
32413314 5172
9fd8be00
EZ
5173 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5174 coordinates of the iterator when restoring from ppos_it.
5175 (Bug#9296)
5176
5cf2b69b
KH
51772011-08-14 Kenichi Handa <handa@m17n.org>
5178
5179 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5180 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5181
daf17d00
EZ
51822011-08-14 Eli Zaretskii <eliz@gnu.org>
5183
5184 * xdisp.c (move_it_in_display_line_to): Don't invoke
5185 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5186 ppos_it. Fixes vertical cursor motion when line beginning is
5187 covered by an image. (Bug#9296)
5188
08e3161a
JD
51892011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5190
5191 * nsterm.h (ns_run_ascript): Declare.
5192 (NSAPP_DATA2_RUNASSCRIPT): Define.
5193
5194 * nsfns.m (as_script, as_result, as_status): New static variables.
5195 (ns_run_ascript): New function.
5e617bc2 5196 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5197 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5198 the event loop. Get status from as_status (Bug#7276).
5199
5200 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5201 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5202 the event loop (Bug#7276).
5203
a3720aa2
AS
52042011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5205
5206 * gnutls.c (QCgnutls_bootprop_priority)
5207 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5208 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5209 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5210 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5211 (QCgnutls_bootprop_verify_hostname_error)
5212 (QCgnutls_bootprop_callbacks_verify): Rename from
5213 Qgnutls_bootprop_..., all uses changed.
5214
5215 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5216 uses changed.
5217
0a0d27fb
PE
52182011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5219
19d5c50c
PE
5220 * xfaces.c (Qframe_set_background_mode): Now static.
5221 * dispextern.h (Qframe_set_background_mode): Remove decl.
5222
0a0d27fb
PE
5223 * process.c (Fnetwork_interface_info): Declare local only if needed.
5224
377538cb
JD
52252011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5226
5227 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5228 (Fnetwork_interface_list): Allocate in increments of bytes instead
5229 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5230 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5231 sockaddr.
5232 (struct ifflag_def): notrailers is smart on OSX.
5233 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5234 Get hardware address with getifaddrs if available.
5235
08fff70c
EZ
52362011-08-12 Eli Zaretskii <eliz@gnu.org>
5237
5238 * xdisp.c (iterate_out_of_display_property): xassert that
5239 IT->position is set to within IT->object's boundaries. Break from
5240 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5241 when IT->position is set up wrongly due to some bug.
5242 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5243 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5244 entry. Force push_it to save on the stack the current
5245 buffer/string position, to be restored by pop_it. Fix flags in
5246 the iterator structure wrt the object coming from a display
5247 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5248 properties. (Bug#9284)
5249
7be1c708 52502011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5251
7be1c708
CY
5252 * fontset.c (fontset_get_font_group): Add proper type checks.
5253 (Bug#9172)
aac0c6e3 5254
7be1c708 52552011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5256
7be1c708
CY
5257 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5258 and LC_VERSION_MIN_MACOSX.
5259 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5260 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5261
97bb72a6
EZ
52622011-08-08 Eli Zaretskii <eliz@gnu.org>
5263
5264 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5265 no-display-properties-and-no-overlays under bidi display.
5266 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5267 properties and overlays.
97bb72a6 5268
d5617611
CY
52692011-08-08 Chong Yidong <cyd@stupidchicken.com>
5270
37e11a63
CY
5271 * editfns.c (Fset_time_zone_rule): Document relationship with the
5272 setenv function.
5273
d5617611
CY
5274 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5275 the font entity extracted from the cache (Bug#8109).
5276
58872834
CY
52772011-08-07 Chong Yidong <cyd@stupidchicken.com>
5278
5279 * composite.c (autocmp_chars): Don't reset point. That is done by
5280 restore_point_unwind (Bug#5984).
5281
75bfc667
JL
52822011-08-07 Juri Linkov <juri@jurta.org>
5283
5284 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5285 to show the arg `TIME' instead of `TIMEVAL'.
5286
d1410150
EZ
52872011-08-06 Eli Zaretskii <eliz@gnu.org>
5288
5289 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5290 display property strides EOL and includes a newline, as in
5291 longlines-mode. (Bug#9254)
75b771e4
EZ
5292 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5293 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5294
5295 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5296 is non-zero, even if the data buffer is NULL. Fixes a crash in
5297 vertical-motion with longlines-mode. (Bug#9254)
5298
35928349
EZ
52992011-08-05 Eli Zaretskii <eliz@gnu.org>
5300
ec7cc85b
EZ
5301 * bidi.c <bidi_cache_total_alloc>: Now static.
5302 (bidi_initialize): Initialize bidi_cache_total_alloc.
5303
8b76d6f8 5304 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5305 cache. (Bug#9221)
5306
5307 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5308 amount allocated this far in `bidi_cache_total_alloc'.
5309 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5310 non-zero, only free the data buffer without restoring the cache
5311 contents. All callers changed.
5312
5313 * dispextern.h (bidi_unshelve_cache): Update prototype.
5314
5315 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5316 (move_it_in_display_line, move_it_to)
5317 (move_it_vertically_backward, move_it_by_lines): Replace the call
5318 to xfree to an equivalent call to bidi_unshelve_cache.
5319 (move_it_in_display_line_to): Fix logic of returning
412b6358 5320 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5321
e2e2423b
EZ
53222011-08-05 Eli Zaretskii <eliz@gnu.org>
5323
5324 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5325 came from a string character with a `cursor' property. (Bug#9229)
5326
ae9e757a
JD
53272011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5328
5329 * Makefile.in (LIB_PTHREAD): New variable.
5330 (LIBES): Add LIB_PTHREAD (Bug#9216).
5331
5332 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5333 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5334
213bd7f2
AS
53352011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5336
6b02f655 5337 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5338
99aaf75f
JD
53392011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5340
5341 * xterm.c (x_find_topmost_parent): New function.
5342 (x_set_frame_alpha): Find topmost parent window with
5343 x_find_topmost_parent and set the property there also (bug#9181).
5344 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5345
c74e9d86
PE
53462011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5347
5348 * callproc.c (Fcall_process): Avoid vfork clobbering
5349 the local vars buffer, coding_systems, current_dir.
5350
640c8776
SM
53512011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5352
5353 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5354
f26d0e4c
PE
53552011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5356
8a10d76c
PE
5357 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5358 so that it is not optimized away.
5359
f26d0e4c
PE
5360 * xdisp.c (compute_display_string_pos): Remove unused local.
5361
55439c61
EZ
53622011-08-02 Eli Zaretskii <eliz@gnu.org>
5363
5364 Fix slow cursor motion and scrolling in large buffers with
5365 selective display, like Org Mode buffers. (Bug#9218)
5366
5367 * dispextern.h (struct bidi_it): New member disp_prop_p.
5368
5369 * xdisp.c: Remove one-slot cache of display string positions.
5370 (compute_display_string_pos): Accept an additional argument
5e617bc2 5371 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5372 for a display string or property. If found, set DISP_PROP_P
5373 non-zero.
5374
5375 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5376 DISP_PROP_P, and pass it to compute_display_string_pos.
5377 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5378 non-zero. All callers of bidi_fetch_char changed.
5379
fb33fa43
SM
53802011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5381
5382 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5383
b099e063
DM
53842010-12-03 Don March <don@ohspite.net>
5385
5386 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5387 last character M-[char] is translated to ESC [char] (bug#7541).
5388
5cc7f7af
KH
53892011-08-02 Kenichi Handa <handa@m17n.org>
5390
d0fffa3f 5391 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5392
5393 * chartab.c (uniprop_table): Make it non-static.
5394
525d5e6e
EZ
53952011-08-01 Eli Zaretskii <eliz@gnu.org>
5396
5397 * xdisp.c (forward_to_next_line_start): Accept additional argument
5398 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5399 on the newline.
5400 (reseat_at_next_visible_line_start): Use the bidi iterator state
5401 returned by forward_to_next_line_start to restore the state of
5402 it->bidi_it after backing up to previous newline. (Bug#9212)
5403
31011111
AS
54042011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5405
5406 * regex.c (re_comp): Protoize.
5407 (re_exec): Fix return type.
5408 (regexec): Fix type of `ret'. (Bug#9203)
5409
476371c4
PE
54102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5411
e5d76069
PE
5412 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5413 This is needed if max-image-size is a floating-point number.
5414
9a79b20c
AS
54152011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5416
5417 * print.c (print_object): Print empty symbol as ##.
5418
5419 * lread.c (read1): Read ## as empty symbol.
5420
d8c2fa78
AA
54212011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5422
5423 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5424 setting frame foreground color (Bug#9175).
5425 (x_set_background_color): Likewise.
5426
ffe57a7a
AA
5427 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5428 contents (Bug#9176).
5429 (EmacsTooltip -init): Remove bezels and add shadows to
5430 tooltip windows.
5431
bf3492a5
AA
5432 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5433 or scroll bar (Bug#8470).
5434
d55e9c53
AA
5435 * nsfont.m (nsfont_open): Remove assignment to voffset and
5436 unnecessary vars hshink, expand, hd, full_height, min_height.
5437 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5438
5439 * nsterm.h (nsfont_info): Remove voffset field.
5440
d8c2fa78 54412011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5442
5443 Implement strike-through and overline on NextStep (Bug#8863).
5444
5445 * nsfont.m (nsfont_open): Use underline position provided by font,
5446 instead of hard-coded value of 2.
5447 (nsfont_draw): Call ns_draw_text_decoration instead.
5448
5449 * nsterm.h: Add declaration for ns_draw_text_decoration.
5450
5451 * nsterm.m (ns_draw_text_decoration): New function for drawing
5452 underline, overline, and strike-through.
5453 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5454 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5455 accommodate underlining, etc.
4843aac3 5456
4cc60b9b
EZ
54572011-07-28 Eli Zaretskii <eliz@gnu.org>
5458
bc7ece87
EZ
5459 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5460 default.
4cc60b9b 5461
476371c4
PE
54622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5463
66606eea
PE
5464 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5465 Without this fix, if a signal arrives just after memory fills up,
5466 'malloc' might be invoked reentrantly.
5467
476371c4
PE
5468 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5469 In other words, assume that every image size is allowed, on non-X
5470 hosts. This assumption is probably wrong, but it lets Emacs compile.
5471
f3fcc40d
AS
54722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5473
5474 * regex.c (re_iswctype): Convert return values to boolean.
5475
350c992f
EZ
54762011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5477
5478 * xdisp.c (compute_display_string_pos): Don't use cached display
5479 string position if the buffer had its restriction changed.
5480 (Bug#9184)
5481
5266b4bb
PE
54822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5483
5484 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5485
2573a837 54862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5487
41f55ccd 5488 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5489
39e378da
PE
5490 * bidi.c: Integer size and overflow fixes.
5491 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5492 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5493 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5494 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5495 (bidi_find_other_level_edge):
5496 Use ptrdiff_t instead of EMACS_INT where either will do.
5497 This works better on 32-bit hosts configured --with-wide-int.
5498 (bidi_cache_ensure_space): Check for size-calculation overflow.
5499 Use % rather than repeated addition, for better worst-case speed.
5500 Don't set bidi_cache_size until after xrealloc returns, because it
5501 might not return.
5502 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5503 (bidi_cache_ensure_space): Also check that the bidi cache size
5504 does not exceed that of the largest Lisp string or buffer. See Eli
5505 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5506
5e927815
PE
5507 * alloc.c (__malloc_size_t): Remove.
5508 All uses replaced by size_t. See Andreas Schwab's note
5509 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5510
ca4aa935
PE
5511 * image.c: Improve checking for integer overflow.
5512 (check_image_size): Assume that f is nonnull, since
5513 it is always nonnull in practice. This is one less thing to
5514 worry about when checking for integer overflow later.
5515 (x_check_image_size): New function, which checks for integer
5516 overflow issues inside X.
5517 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5518 This removes the need for a memory_full check.
5519 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5520 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5521 (xbm_read_bitmap_data): Change locals back to 'int', since
5522 their values must fit in 'int'.
5523 (xpm_load_image, png_load, tiff_load):
5524 Invoke x_create_x_image_and_pixmap earlier,
5525 to avoid much needless work if the image is too large.
5526 (tiff_load): Treat overly large images as if
5527 x_create_x_image_and_pixmap failed, not as malloc failures.
5528 (gs_load): Use x_check_image_size.
5529
5f8f9cc2
PE
5530 * gtkutil.c: Omit integer casts.
5531 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5532 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5533
5adf60bc
PE
5534 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5535
c8907a93
PE
5536 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5537 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5538 would wrongly return t on a 64-bit host.
5539
e3c25c68
PE
5540 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5541 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5542 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5543 and therefore cause GCC to emit a bogus diagnostic in some cases.
5544
3f791afe
PE
5545 * image.c: Integer signedness and overflow and related fixes.
5546 This is not an exhaustive set of fixes, but it's time to
5547 record what I've got.
5548 (lookup_pixel_color, check_image_size): Remove redundant decls.
5549 (check_image_size): Don't assume that arbitrary EMACS_INT values
5550 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5551 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5552 (tiff_load, imagemagick_load_image):
5553 Check for overflow in size calculations.
5554 (x_create_x_image_and_pixmap): Remove unnecessary test for
5555 xmalloc returning NULL; that can't happen.
5556 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5557 (xpm_color_bucket): Use better integer hashing function.
5558 (xpm_cache_color): Don't possibly over-allocate memory.
5559 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5560 (gif_memory_source):
5561 Use ptrdiff_t, not int or size_t, to record sizes.
5562 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5563 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5564 either works, as we prefer signed integers.
5565 (tiff_read_from_memory, tiff_write_from_memory):
5566 Return tsize_t, not size_t, since that's what the TIFF API wants.
5567 (tiff_read_from_memory): Don't fail simply because the read would
5568 go past EOF; instead, return a short read.
5569 (tiff_load): Omit no-longer-needed casts.
5570 (Fimagemagick_types): Don't assume size fits into 'int'.
5571
3cc5a532
PE
5572 Improve hashing quality when configured --with-wide-int.
5573 * fns.c (hash_string): New function, taken from sxhash_string.
5574 Do not discard information about ASCII character case; this
5575 discarding is no longer needed.
5576 (sxhash-string): Use it. Change sig to match it. Caller changed.
5577 * lisp.h: Declare it.
5578 * lread.c (hash_string): Remove, since we now use fns.c's version.
5579 The fns.c version returns a wider integer if --with-wide-int is
5580 specified, so this should help the quality of the hashing a bit.
5581
b312a492
PE
5582 * emacs.c: Integer overflow minor fix.
5583 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5584 Define only if GNU_LINUX.
5585 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5586
dfd153ae
PE
5587 * dispnew.c: Integer signedness and overflow fixes.
5588 Remove unnecessary forward decls, that were a maintenance hassle.
5589 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5590 All uses changed.
5591 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5592 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5593 (prepare_desired_row, line_draw_cost):
5594 Use int, not unsigned, where either works.
5595 (save_current_matrix, restore_current_matrix):
5596 Use ptrdiff_t, not size_t, where either works.
5597 (init_display): Check for overflow more accurately, and without
5598 relying on undefined behavior.
5599
a81d11a3
PE
5600 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5601 Remove, replacing with the new symbols in lisp.h. All uses changed.
5602 * fileio.c (make_temp_name):
5603 * filelock.c (lock_file_1, lock_file):
5604 * xdisp.c (message_dolog):
5605 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5606 Use pMd etc. instead.
5607 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5608 replacing the pWIDE etc. symbols removed from editfns.c.
5609
3300e6fd
PE
5610 * keyboard.h (num_input_events): Now uintmax_t.
5611 This is (very slightly) less likely to mess up due to wraparound.
5612 All uses changed.
5613
fd05c7e9
PE
5614 * buffer.c: Integer signedness fixes.
5615 (alloc_buffer_text, enlarge_buffer_text):
5616 Use ptrdiff_t rather than size_t when either will do, as we prefer
5617 signed integers.
5618
903fe15d
PE
5619 * alloc.c: Integer signedness and overflow fixes.
5620 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5621 (__malloc_size_t): Default to size_t, not to int.
5622 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5623 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5624 Prefer ptrdiff_t to size_t when either would do, as we prefer
5625 signed integers.
5626 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5627 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5628 Now const. Initialize with values that are in range even if char
5629 is signed.
5630 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5631 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5632 These functions do the right thing with sizes > 2**32.
5633 (check_depth): Now ptrdiff_t, not int.
5634 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5635 Adjust to new way of storing sizes. Check for size overflow bugs
5636 in rest of code.
5637 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5638 slightly wrong anyway, as it missed one instance of
5639 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5640 (refill_memory_reserve): Omit needless cast to size_t.
5641 (mark_object_loop_halt): Mark as externally visible.
5642
ac82cc6a
PE
5643 * xselect.c: Integer signedness and overflow fixes.
5644 (Fx_register_dnd_atom, x_handle_dnd_message):
5645 Use ptrdiff_t, not size_t, since we prefer signed.
5646 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5647 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5648 x_dnd_atoms_size and x_dnd_atoms_length.
5649
c2d1e36d
PE
5650 * doprnt.c: Prefer signed to unsigned when either works.
5651 * eval.c (verror):
5652 * doprnt.c (doprnt):
5653 * lisp.h (doprnt):
5654 * xdisp.c (vmessage):
5655 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5656 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5657 prefer signed arithmetic to avoid comparison confusion.
5658 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5659 but is a bit tricky.
5660
0e926e56
PE
5661 Assume freestanding C89 headers, string.h, stdlib.h.
5662 * data.c, doprnt.c, floatfns.c, print.c:
5663 Include float.h unconditionally.
5664 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5665 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5666 * regex.c: Likewise for stddef.h, string.h.
5667 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5668 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5669 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5670 (STDC_HEADERS): Remove obsolete defines.
5671 * sysdep.c: Include limits.h unconditionally.
5672
9cfdb3ec
PE
5673 Assume support for memcmp, memcpy, memmove, memset.
5674 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5675 * regex.c (memcmp, memcpy):
5676 Remove; we assume C89 now.
5677
5678 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5679 (__malloc_safe_bcopy): Remove; no longer needed.
5680
cf950e6b 5681 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5682 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5683 well either way, and we prefer signed to unsigned.
5684
dbf38e02
LMI
56852011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5686
5687 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5688 closes the connection while we're reading (bug#9182).
5689
d6f0886c 56902011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5691
d6f0886c
JD
5692 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5693 are specified (Bug#9168).
24e0f6b1 5694
2eb1f9e6
PE
56952011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5696
5697 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5698 Found by GCC static checking and --with-wide-int on a 32-bit host.
5699
22381272 57002011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5701
5702 * xdisp.c (compute_display_string_pos): Fix logic of caching
5703 previous display string position. Initialize cached_prev_pos to
5704 -1. Fixes slow-down at the beginning of a buffer.
5705
f25e39b4
EZ
57062011-07-24 Eli Zaretskii <eliz@gnu.org>
5707
5708 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5709 for attrs[LFACE_FONTSET_INDEX].
5710
04c4b52e
PE
57112011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5712
5713 * xml.c (parse_region): Remove unused local
5714 that was recently introduced.
5715
c1734fbd
EZ
57162011-07-23 Eli Zaretskii <eliz@gnu.org>
5717
be18c5a5
EZ
5718 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5719 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5720
c1734fbd
EZ
5721 * xdisp.c (move_it_in_display_line_to): Record the best matching
5722 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5723 exit if none of the characters scanned was an exact match.
5724 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5725 when exact match is impossible due to invisible text, and the
5726 lines are truncated.
5727
a258d627
JD
57282011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5729
5730 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5731 for OSX >= 10.7.
5732
b6d5a689
EZ
57332011-07-22 Eli Zaretskii <eliz@gnu.org>
5734
0f74f785
EZ
5735 Fix a significant slow-down of cursor motion with C-n, C-p,
5736 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5737 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5738 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5739 (next_element_from_buffer): Call compute_stop_pos_backwards to
5740 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5741 base_level_stop.
5742 (reseat): Don't look for prev_stop, as that could mean a very long
5743 run.
5744 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5745 <cached_disp_overlay_modiff>: Cache for last found display string
5746 position.
551918c1 5747 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5748 about the same buffer in the same area of character positions, and
5749 the buffer wasn't changed since the time the display string
5750 position was cached.
551918c1 5751
b2d0c91a
EZ
57522011-07-22 Eli Zaretskii <eliz@gnu.org>
5753
5754 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5755 is an integer, which is important for empty lines. (Bug#9149)
5756
043604ee
CY
57572011-07-22 Chong Yidong <cyd@stupidchicken.com>
5758
5759 * frame.c (Fmodify_frame_parameters): In tty case, update the
5760 default face if necessary (Bug#4238).
5761
da4adb04
CY
57622011-07-21 Chong Yidong <cyd@stupidchicken.com>
5763
5764 * editfns.c (Fstring_to_char): No need to explain what a character
5765 is in the docstring (Bug#6576).
5766
9abd0532
LMI
57672011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5768
5769 * xml.c (parse_region): Make sure we always return a tree.
5770
36881d16
HK
57712011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5772
5773 * xml.c (parse_region): If a document contains only comments,
5774 return that, too.
5775
1e98674d
LMI
57762011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5777
5778 * xml.c (make_dom): Return comments, too.
5779
590bd467
PE
57802011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5781
5782 Port to OpenBSD.
5783 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5784 and the surrounding thread.
5785 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5786 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5787 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5788 timer goes off.
5789 * s/openbsd.h (BROKEN_SIGIO): Define.
5790 * unexelf.c (unexec) [__OpenBSD__]:
5791 Don't update the .mdebug section of the Alpha COFF symbol table.
5792
f41628b2
LMI
57932011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5794
5795 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5796 (bug#8460).
5797
b59b67c5
PE
57982011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5799
15e3a074
PE
5800 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5801 This fixes some race conditions on the permissions of any newly
5802 created file.
5803
41bed37d
PE
5804 * alloc.c (valid_pointer_p): Use pipe, not open.
5805 This fixes some permissions issues when debugging.
5806
b59b67c5
PE
5807 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5808 If fchown fails to set both uid and gid, try to set just gid,
5809 as that is sometimes allowed. Adjust the file's mode to eliminate
5810 setuid or setgid bits that are inappropriate if fchown fails.
5811
925a6be7
SM
58122011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5813
5814 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5815 to compare Lisp_Objects.
5816 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5817 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5818 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5819
52968808
AS
58202011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5821
0a6a104b
AS
5822 * lread.c (read_integer): Unread even EOF character.
5823 (read1): Likewise. Properly record start position of symbol.
5824
52968808
AS
5825 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5826 symbol character follows.
5827
9e381cdd
PE
58282011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5829
5830 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5831 This works around a problem with the previous change to Fcopy_file.
5832 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5833 and without this change, GCC might complain about discarding
5834 fchown's return value.
5835
b5641435
JB
58362011-07-16 Juanma Barranquero <lekktu@gmail.com>
5837
5838 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5839
a8031457
PE
58402011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5841
5842 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5843
dd889327
LMI
58442011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5845
750c33f7
LMI
5846 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5847 it's used from the C level.
5848
dd889327
LMI
5849 * process.c: Use the same condition for POLL_FOR_INPUT in both
5850 keyboard.c and process.c (bug#1858).
5851
87e86684
LM
58522011-07-09 Lawrence Mitchell <wence@gmx.li>
5853
5854 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5855 (Fgnutls_boot): Use it.
5856
64348f40
AS
58572011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5858
5859 * doc.c (Fsubstitute_command_keys): Revert last change.
5860
1d698799
LMI
58612011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5862
f863868c
LMI
5863 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5864 quotes the next character, and doesn't affect other longer
5865 sequences (bug#8935).
5866
1d698799
LMI
5867 * lread.c (syms_of_lread): Clarify that is isn't only
5868 `eval-buffer' and `eval-defun' that's affected by
5869 `lexical-binding' (bug#8460).
5870
aa4b6df6
EZ
58712011-07-15 Eli Zaretskii <eliz@gnu.org>
5872
5873 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5874 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5875
5d856da6
PE
58762011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5877
ad6042bb
PE
5878 Fix minor problems found by static checking.
5879 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5880 (elsz): Now a signed constant, not a size_t var. We prefer signed
5881 types to unsigned, to avoid integer comparison confusion. Without
5882 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5883 "cannot optimize loop, the loop counter may overflow", a symptom
5884 of the confusion.
f00bbb22 5885 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5886 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5887
6468f31c
LMI
58882011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5889
49080b10
LMI
5890 * search.c (Fre_search_backward): Mention `case-fold-search' in
5891 all the re_search_* functions (bug#8138).
5892
6468f31c
LMI
5893 * keyboard.c (Fopen_dribble_file): Document when the file is
5894 closed (bug#8056).
5895
c965adc5
EZ
58962011-07-14 Eli Zaretskii <eliz@gnu.org>
5897
df9733bf
EZ
5898 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5899 bidi_cache_idx.
5900
0bb23927
EZ
5901 Support bidi reordering of display and overlay strings.
5902 * xdisp.c (compute_display_string_pos)
5903 (compute_display_string_end): Accept additional argument STRING.
5904 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5905 (reseat_to_string): Initialize bidi_it->string.s and
5906 bidi_it->string.schars.
5907 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5908 NULL (avoids a crash in bidi_paragraph_init).
5909 Initialize itb.string.lstring.
0bb23927
EZ
5910 (init_iterator): Call bidi_init_it only of a valid
5911 buffer position was specified. Initialize paragraph_embedding to
5912 L2R.
5913 (reseat_to_string): Initialize the bidi iterator.
5914 (display_string): If we need to ignore text properties of
5915 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5916 original value of -1 will not work with bidi.)
5917 (compute_display_string_pos): First arg is now struct
5918 `text_pos *'; all callers changed. Support display properties on
5919 Lisp strings.
5920 (compute_display_string_end): Support display properties on Lisp
5921 strings.
5922 (init_iterator, reseat_1, reseat_to_string): Initialize the
5923 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5924 when iterating on a string not from display properties).
640c8776
SM
5925 (compute_display_string_pos, compute_display_string_end):
5926 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5927 arrow keys.
5928 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5929 base_level_stop; instead, set base_level_stop to BEGV.
5930 Fixes crashes in vertical-motion.
0bb23927
EZ
5931 (next_element_from_buffer): Improve commentary for when
5932 the iterator is before prev_stop.
5933 (init_iterator): Initialize bidi_p from the default value of
5934 bidi-display-reordering, not from buffer-local value. Use the
5935 buffer-local value only if initializing for buffer iteration.
5936 (handle_invisible_prop): Support invisible properties on strings
5937 that are being bidi-reordered.
5938 (set_iterator_to_next): Support bidi reordering of C strings and
5939 Lisp strings.
5940 (next_element_from_string): Support bidi reordering of Lisp
5941 strings.
5942 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5943 (display_string): Support display of R2L glyph rows.
5944 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5945 (init_iterator): Don't initialize it->bidi_p for strings
5946 here.
5947 (reseat_to_string): Initialize it->bidi_p for strings here.
5948 (next_element_from_string, next_element_from_c_string)
5949 (next_element_from_buffer): Add xassert's for correspondence
5950 between IT's object being iterated and it->bidi_it.string
5951 structure.
5952 (face_before_or_after_it_pos): Support bidi iteration.
5953 (next_element_from_c_string): Handle the case of the first string
5954 character that is not the first one in the visual order.
5955 (get_visually_first_element): New function, refactored from common
5956 parts of next_element_from_buffer, next_element_from_string, and
5957 next_element_from_c_string.
5958 (tool_bar_lines_needed, redisplay_tool_bar)
5959 (display_menu_bar): Force left-to-right direction. Add a FIXME
5960 comment for making that be controlled by a user option.
5961 (push_it, pop_it): Save and restore the state of the
5962 bidi iterator. Save and restore the bidi_p flag.
5963 (pop_it): Iterate out of display property for string iteration as
5964 well.
5965 (iterate_out_of_display_property): Support iteration over strings.
5966 (handle_single_display_spec): Set up it->bidi_it for iteration
5967 over a display string, and call bidi_init_it.
5968 (handle_single_display_spec, next_overlay_string)
5969 (get_overlay_strings_1, push_display_prop): Set up the bidi
5970 iterator for displaying display or overlay strings.
5971 (forward_to_next_line_start): Don't use the shortcut if
5972 bidi-iterating.
5973 (back_to_previous_visible_line_start): If handle_display_prop
5974 pushed the iterator stack, restore the internal state of the bidi
5975 iterator by calling bidi_pop_it same number of times.
5976 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5977 and we are bidi-iterating, don't decrement the iterator position;
5978 instead, set the first_elt flag in the bidi iterator, to produce
5979 the same effect.
5980 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5981 (push_display_prop): xassert that we are iterating a buffer.
5982 (push_it, pop_it): Save and restore paragraph_embedding member.
5983 (handle_single_display_spec, next_overlay_string)
5984 (get_overlay_strings_1, reseat_1, reseat_to_string)
5985 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5986 correctly. Don't assume unibyte strings are not bidi-reordered.
5987 (compute_display_string_pos)
5988 (compute_display_string_end): Fix handling the case of C string.
5989 (push_it, pop_it): Save and restore from_disp_prop_p.
5990 (handle_single_display_spec, push_display_prop): Set the
5991 from_disp_prop_p flag.
5992 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5993 (pop_it): Call iterate_out_of_display_property only if we are
5994 popping after iteration over a string that came from a display
5995 property. Fix a typo in popping stretch info. Add an assertion
5996 for verifying that the iterator position is in sync with the bidi
5997 iterator.
5998 (handle_single_display_spec, get_overlay_strings_1)
5999 (push_display_prop): Fix initialization of paragraph direction for
6000 string when that of the parent object is not yet determined.
6001 (reseat_1): Call bidi_init_it to resync the bidi
6002 iterator with IT's position. (Bug#7616)
6003 (find_row_edges): If ROW->start.pos gives position
6004 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6005 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6006 Reset the from_disp_prop_p flag.
6007 (SAVE_IT, RESTORE_IT): New macros.
6008 (pos_visible_p, face_before_or_after_it_pos)
6009 (back_to_previous_visible_line_start)
6010 (move_it_in_display_line_to, move_it_in_display_line)
6011 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6012 (try_scrolling, redisplay_window, display_line): Use them when
6013 saving a temporary copy of the iterator and restoring it back.
6014 (back_to_previous_visible_line_start, reseat_1)
6015 (init_iterator): Empty the bidi cache "stack".
6016 (move_it_in_display_line_to): If iterator ended up at
6017 EOL, but we never saw any buffer positions smaller than
6018 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6019 motion in bidi-reordered lines.
6020 (move_it_in_display_line_to): Record prev_method and prev_pos
6021 immediately before the call to set_iterator_to_next. Fixes cursor
6022 motion in bidi-reordered lines with stretch glyphs and strings
6023 displayed in margins. (Bug#8133) (Bug#8867)
6024 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6025 TO_CHARPOS.
640c8776
SM
6026 (pos_visible_p): Support positions in bidi-reordered lines.
6027 Save and restore bidi cache.
0bb23927
EZ
6028
6029 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6030 (bidi_paragraph_info): Delete unused struct.
6031 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6032 (bidi_cache_start): New variable.
6033 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6034 to zero.
6035 (bidi_cache_fetch_state, bidi_cache_search)
6036 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6037 (bidi_cache_find, bidi_peek_at_next_level)
6038 (bidi_level_of_next_char, bidi_find_other_level_edge)
6039 (bidi_move_to_visually_next): Compare cache index with
6040 bidi_cache_start rather than with zero.
6041 (bidi_fetch_char): Accept new argument STRING; all callers
6042 changed. Support iteration over a string. Support strings with
6043 display properties. Support unibyte strings. Fix the type of
6044 `len' according to what STRING_CHAR_AND_LENGTH expects.
6045 (bidi_paragraph_init, bidi_resolve_explicit_1)
6046 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6047 (bidi_level_of_next_char, bidi_move_to_visually_next):
6048 Support iteration over a string.
0bb23927
EZ
6049 (bidi_set_sor_type, bidi_resolve_explicit_1)
6050 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6051 can now be zero (for strings); special values 0 and -1 were
6052 changed to -1 and -2, respectively.
6053 (bidi_char_at_pos): New function.
6054 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6055 Call it instead of FETCH_MULTIBYTE_CHAR.
6056 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6057 initialized to valid values.
6058 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6059 values.
6060 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6061 the test for valid cached positions. Fix the logic for looking up
6062 the sentinel state in the cache. GCPRO the Lisp string we are
6063 iterating.
6064 (bidi_push_it, bidi_pop_it): New functions.
6065 (bidi_initialize): Initialize the bidi cache start stack pointer.
6066 (bidi_cache_ensure_space): New function, refactored from part of
6067 bidi_cache_iterator_state. Don't assume the required size is just
6068 one BIDI_CACHE_CHUNK away.
6069 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6070 (bidi_count_bytes, bidi_char_at_pos): New functions.
6071 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6072 always valid if bidi_cache_idx is valid.
6073 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6074 is valid if it's going to be used.
6075 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6076 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6077 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6078 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6079 (bidi_find_other_level_edge, bidi_cache_start_stack):
6080 All variables related to cache indices are now EMACS_INT.
c965adc5 6081
0bb23927
EZ
6082 * dispextern.h (struct bidi_string_data): New structure.
6083 (struct bidi_it): New member `string'. Make flag members be 1-bit
6084 fields, and put them last in the struct.
640c8776
SM
6085 (compute_display_string_pos, compute_display_string_end):
6086 Update prototypes.
0bb23927
EZ
6087 (bidi_push_it, bidi_pop_it): Add prototypes.
6088 (struct iterator_stack_entry): New members bidi_p,
6089 paragraph_embedding, and from_disp_prop_p.
6090 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6091 (bidi_shelve_cache, bidi_unshelve_cache):
6092 Declare prototypes.
0bb23927
EZ
6093
6094 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6095 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6096 and vector-like objects.
6097
6098 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6099 cache around display iteration.
6100
6101 * window.c (Fwindow_end, window_scroll_pixel_based)
6102 (displayed_window_lines, Frecenter): Save and restore the bidi
6103 cache around display iteration.
6104
3bbd2265
LMI
61052011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6106
6107 * editfns.c (Fdelete_region): Clarify the use of the named
6108 parameters (bug#6788).
6109
adc47434
MR
61102011-07-14 Martin Rudalics <rudalics@gmx.at>
6111
6112 * indent.c (Fvertical_motion): Set and restore w->pointm when
6113 saving and restoring the window's buffer (Bug#9006).
6114
837c31f8
LMI
61152011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6116
6117 * editfns.c (Fstring_to_char): Clarify just what is returned
6118 (bug#6576). Text by Eli Zaretskii.
6119
ac389d0c
JB
61202011-07-13 Juanma Barranquero <lekktu@gmail.com>
6121
6122 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6123
0be0ce47
EZ
61242011-07-13 Eli Zaretskii <eliz@gnu.org>
6125
6126 * buffer.c (mmap_find): Fix a typo.
6127
cd18e7e3
JB
61282011-07-13 Johan Bockgård <bojohan@gnu.org>
6129
6130 Fix execution of x selection hooks.
6131 * xselect.c (Qx_lost_selection_functions)
6132 (Qx_sent_selection_functions): New vars.
6133 (syms_of_xselect): DEFSYM them.
6134 (x_handle_selection_request): Pass Qx_sent_selection_functions
6135 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6136 (x_handle_selection_clear,x_clear_frame_selections):
6137 Pass Qx_lost_selection_functions rather than
6138 Vx_lost_selection_functions to Frun_hook_with_args.
6139
47ea7f44
PE
61402011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6141
ac389d0c 6142 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6143 The old code sometimes used this field without initializing it.
6144
47ea7f44
PE
6145 * alloc.c (gc_sweep): Don't read past end of array.
6146 In theory, the old code could also have corrupted Emacs internals,
6147 though it'd be very unlikely.
6148
bc985c87
AS
61492011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6150
6151 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6152 argument. (Bug#4026)
bc985c87 6153
0cf34688
LMI
61542011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6155
b3dadd76
LMI
6156 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6157 key" (bug#4257).
6158
0cf34688
LMI
6159 * window.c (Fset_window_start): Doc fix (bug#4199).
6160 (Fset_window_hscroll): Ditto.
6161
270768cd
PE
61622011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6163
077e3dda 6164 Fix minor new problems caught by GCC 4.6.1.
270768cd 6165 * term.c (init_tty): Remove unused local.
490011a6 6166 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6167 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6168 not used otherwise.
270768cd 6169
b1f58454
CY
61702011-07-12 Chong Yidong <cyd@stupidchicken.com>
6171
6172 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6173
22b9578d
LMI
61742011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6175
6e70ab07
LMI
6176 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6177 are the mini-buffer and the echo area (bug#3320).
6178
22b9578d
LMI
6179 * term.c (init_tty): Remove support for supdup, c10 and perq
6180 terminals, which are no longer supported (bug#1482).
6181
8974cc9f
JB
61822011-07-10 Johan Bockgård <bojohan@gnu.org>
6183
6184 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6185
a560d974
JD
61862011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6187
6188 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6189 for non-popups (Bug#3642).
6190
1dae0f0a
AS
61912011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6192
268c2c36 6193 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6194 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6195 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6196 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6197 * data.c (fmod): Likewise.
6198 * dispnew.c (swap_glyphs_in_rows): Likewise.
6199 * emacs.c (memory_warning_signal): Likewise.
6200 * floatfns.c (float_error): Likewise.
6201 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6202 (otf_open, font_otf_capability, generate_otf_features)
6203 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6204 Likewise.
6205 * image.c (pbm_read_file): Likewise.
6206 * indent.c (string_display_width): Likewise.
6207 * intervals.c (check_for_interval, search_for_interval)
6208 (inc_interval_count, count_intervals, root_interval)
6209 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6210 * lread.c (defalias): Likewise.
268c2c36 6211 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6212 * regex.c (set_image_of_range_1, set_image_of_range)
6213 (regex_grow_registers): Likewise.
6214 * sysdep.c (strerror): Likewise.
6215 * termcap.c (valid_filename_p, tprint, main): Likewise.
6216 * tparam.c (main): Likewise.
6217 * unexhp9k800.c (run_time_remap, save_data_space)
6218 (update_file_ptrs, read_header, write_header, calculate_checksum)
6219 (copy_file, copy_rest, display_header): Likewise.
6220 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6221 Likewise.
6222 * xdisp.c (check_it): Likewise.
6223 * xfaces.c (register_color, unregister_color, unregister_colors):
6224 Likewise.
6225 * xfns.c (print_fontset_result): Likewise.
6226 * xrdb.c (member, fatal, main): Likewise.
6227
99033785
PE
62282011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6229
6230 Fix minor problems found by static checking (Bug#9031).
6231 * chartab.c (char_table_set_range, map_sub_char_table):
6232 Remove unused locals.
6233 (uniprop_table): Now static.
6234 * composite.c (_work_char): Remove unused static var.
6235
9cb2ac56
JB
62362011-07-09 Juanma Barranquero <lekktu@gmail.com>
6237
6238 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6239
f25661f0
JD
62402011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6241
6242 * gtkutil.c (qttip_cb): Remove code without function.
6243
8278c4fe
EZ
62442011-07-09 Eli Zaretskii <eliz@gnu.org>
6245
6246 * w32.c (pthread_sigmask): New stub.
6247
1692ae2d 62482011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6249
8a6ebd58 6250 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6251 sigprocmask is portable only for single-threaded applications, and
6252 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6253 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6254 (LIBES): Use it.
6255 * callproc.c (Fcall_process):
6256 * process.c (create_process):
6257 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6258 Use pthread_sigmask, not sigprocmask.
123403e4 6259
1b854618
JD
62602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6261
6262 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6263 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6264 wrong (Bug#8591).
6265
3fe4b549
JD
62662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6267
0ce7e563
JD
6268 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6269 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6270 (xg_hide_tooltip): Fix comment.
6271
3fe4b549
JD
6272 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6273 in registerServicesMenuSendTypes.
6274 (validRequestorForSendType): Don't check ns_return_types.
6275
6276 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6277 ns_return_type.
6278
5df75e47
JR
62792011-07-08 Jason Rumney <jasonr@gnu.org>
6280
22610910
JR
6281 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6282 SH_SHOW for hidden windows (Bug#5482).
6283
5df75e47
JR
6284 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6285 frame struct members of non-existent frames (Bug#6284).
6286
699c10bd
JD
62872011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6288
4393663b
JD
6289 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6290 variable firstTime not needed on OSX >= 10.6.
6291 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6292 >= 10.5. Use setKnobProportion, setDoubleValue.
6293
6294 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6295 (MAC_OS_X_VERSION_10_5): Define if not defined.
6296 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6297 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6298 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6299
6300 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6301 cString and lossyCString on OSX >= 10.4
6302
58179cce 6303 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6304 sizeToFit on OSX >= 10.2.
6305
6306 * nsimage.m (allocInitFromFile): Don't use deprecated method
6307 bestRepresentationForDevice on OSX >= 10.6.
6308
6309 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6310 to avoid warning.
6311
6312 * emacs.c: Declare unexec_init_emacs_zone.
6313
a63e0781
JD
6314 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6315
699c10bd
JD
6316 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6317
6318 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6319 on svcsMenu (Bug#8842).
6320
6321 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6322 ns_return_types.
6323 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6324
6325 * nsterm.m (QUTF8_STRING): Declare.
6326 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6327 (validRequestorForSendType): Return type is (id).
6328 Change indexOfObjectIdenticalTo to indexOfObject.
6329 Check if we have local selection before returning self (Bug#8842).
6330 (writeSelectionToPasteboard): Put local selection into paste board
6331 if we have a local selection (Bug#8842).
6332 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6333
6334 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6335 (ns_get_local_selection): Declare.
6336
54e10184
LMI
63372011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6338
9888ff71
LMI
6339 * keymap.c (describe_map_tree): Don't insert a double newline at
6340 the end of the buffer (bug#1169) and return whether we inserted
6341 something.
6342
54e10184
LMI
6343 * callint.c (Fcall_interactively): Change "reading args" to
6344 "providing args" to try to clarify what it does (bug#1010).
6345
15fa4783
KH
63462011-07-07 Kenichi Handa <handa@m17n.org>
6347
6348 * composite.c (composition_compute_stop_pos): Ignore a static
6349 composition starting before CHARPOS (Bug#8915).
6350
6351 * xdisp.c (handle_composition_prop): Likewise.
6352
a8815b00
EZ
63532011-07-07 Eli Zaretskii <eliz@gnu.org>
6354
6355 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6356 (Bug#9015)
6357
ef7b981d 63582011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6359
6360 * character.h (unicode_category_t): New enum type.
6361
6362 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6363 (Qchar_code_property_table): New variable.
6364 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6365 (UNIPROP_COMPRESSED_FORM_P): New macros.
6366 (char_table_ascii): Uncompress the compressed values.
6367 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6368 Uncompress the compressed values.
ac389d0c 6369 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6370 (char_table_ref_and_range): Uncompress the compressed values.
6371 (sub_char_table_set): New arg is_uniprop. Callers changed.
6372 Uncompress the compressed values.
6373 (sub_char_table_set_range): Args changed. Callers changed.
6374 (char_table_set_range): Adjuted for the above change.
6375 (map_sub_char_table): Delete args default_val and parent. Add arg
6376 top. Give decoded values to a Lisp function.
640c8776 6377 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6378 values to a Lisp function. Gcpro more variables.
6379 (uniprop_table_uncompress)
6380 (uniprop_decode_value_run_length): New functions.
6381 (uniprop_decoder, uniprop_decoder_count): New variables.
6382 (uniprop_get_decoder, uniprop_encode_value_character)
6383 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6384 New functions.
6385 (uniprop_encoder, uniprop_encoder_count): New variables.
6386 (uniprop_get_encoder, uniprop_table)
6387 (Funicode_property_table_internal, Fget_unicode_property_internal)
6388 (Fput_unicode_property_internal): New functions.
6389 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6390 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6391 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6392 char-code-property-alist.
6393
640c8776 6394 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6395 Vunicode_category_table.
6396
640c8776 6397 * font.c (font_range): Adjust for the change of
c805dec0
KH
6398 Vunicode_category_table.
6399
76b397fb
DN
64002011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6401
6402 * m/iris4d.h: Remove file, move contents ...
6403 * s/irix6-5.h: ... here.
6404
22b4128e
PE
64052011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6406
6407 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6408 * alloc.c (mark_buffer):
6409 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6410 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6411 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6412 This isn't true in general, and it's particularly not true
6413 if Emacs is configured with --with-wide-int.
6414 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6415 New macros, used in the buffer.c change.
6416
869795d6
JD
64172011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6418
6419 * xsettings.c: Use both GConf and GSettings if both are available.
6420 (store_config_changed_event): Add comment.
6421 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6422 (store_tool_bar_style_changed): New functions.
5e617bc2 6423 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6424 (struct xsettings): Move font inside HAVE_XFT.
6425 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6426 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6427 Move inside HAVE_XFT.
640c8776 6428 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6429 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6430 also.
6431 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6432 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6433 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6434 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6435 (parse_settings): Move check for font inside HAVE_XFT.
6436 (read_settings, apply_xft_settings): Add comment.
6437 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6438 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6439 call store_font_name_changed.
6440 (xft_settings_event): Add comment.
6441 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6442 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6443 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6444 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6445 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6446 (xsettings_get_system_font, xsettings_get_system_normal_font):
6447 Add comment.
869795d6 6448
d8ed26bd
PE
64492011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6450
6451 Random fixes. E.g., (random) never returned negative values.
6452 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6453 subseconds part to the entropy, as that's a bit more random.
6454 Prefer signed to unsigned, since the signedness doesn't matter and
6455 in general we prefer signed. When given a limit, use a
6456 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6457 latter isn't right if USE_2_TAGS_FOR_INTS.
6458 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6459 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6460
cabf1cac
SM
64612011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6462
6463 * textprop.c (text_property_stickiness):
6464 Obey Vtext_property_default_nonsticky.
6465 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6466 * w32fns.c (syms_of_w32fns):
6467 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6468
6e9b2be9
PE
64692011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6470
6471 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6472 This is more efficient than Ffile_directory_p and avoids a minor race.
6473
90186c68
LMI
64742011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6475
7c301272
LMI
6476 * buffer.c (Foverlay_put): Say what the return value is
6477 (bug#7835).
6478
c4f2d8d4
LMI
6479 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6480 is a directory before asking whether to use the file name
6481 (bug#7564).
ad637907
LMI
6482 (barf_or_query_if_file_exists): Make the "File is a directory"
6483 error be more correct.
c4f2d8d4 6484
90186c68
LMI
6485 * fns.c (Frequire): Remove the mention of the .gz files, since
6486 that's installation-specific, but keep the mention of
6487 `get-load-suffixes'.
6488
da64016e
PE
64892011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6490
6491 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6492 Report string overflow if the output is too long.
6493
7d47b580
JB
64942011-07-04 Juanma Barranquero <lekktu@gmail.com>
6495
a555cb87
JB
6496 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6497 (syms_of_gnutls): Remove duplicate DEFSYM for
6498 Qgnutls_bootprop_verify_hostname_error, an error for
6499 Qgnutls_bootprop_verify_error (which is no longer used).
6500
7d47b580
JB
6501 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6502 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6503 Also (re)move comments that are misplaced or no longer relevant.
6504
1e49bfab
LMI
65052011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6506
6507 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6508
1485f4c0
CY
65092011-07-03 Chong Yidong <cyd@stupidchicken.com>
6510
6511 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6512 and background color parameters if they have been changed.
6513
a9ab721e
LMI
65142011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6515
6516 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6517
cf7cff57
PE
65182011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6519
2e13213d
PE
6520 * xsettings.c (SYSTEM_FONT): Define only when used.
6521 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6522
cf7cff57
PE
6523 * keymap.c (access_keymap_1): Now static.
6524
7a8e04f7
CY
65252011-07-02 Chong Yidong <cyd@stupidchicken.com>
6526
6527 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6528 leave any prefix arg for the up event (Bug#1586).
6529
61352f62
LMI
65302011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6531
69bb1ef7
LMI
6532 * lread.c (syms_of_lread): Mention single symbols defined by
6533 `defvar' or `defconst' (bug#7154).
6534
61352f62 6535 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6536 (Frequire): Mention get-load-suffixes.
61352f62 6537
28545e04
MR
65382011-07-02 Martin Rudalics <rudalics@gmx.at>
6539
6540 * window.h (window): Remove clone_number slot.
6541 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6542 Remove.
6543 (make_parent_window, make_window, saved_window)
6544 (Fset_window_configuration, save_window_save): Don't deal with
6545 clone numbers.
6546 * buffer.c (Qclone_number): Remove declaration.
6547 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6548
3349e122
SM
65492011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6550
6551 Add multiple inheritance to keymaps.
6552 * keymap.c (Fmake_composed_keymap): New function.
6553 (Fset_keymap_parent): Simplify.
6554 (fix_submap_inheritance): Remove.
6555 (access_keymap_1): New function extracted from access_keymap to handle
6556 embedded parents and handle lists of maps.
6557 (access_keymap): Use it.
6558 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6559 (Fcopy_keymap): Handle embedded parents.
6560 (Fcommand_remapping, define_as_prefix): Simplify.
6561 (Fkey_binding): Simplify.
6562 (syms_of_keymap): Move minibuffer-local-completion-map,
6563 minibuffer-local-filename-completion-map,
6564 minibuffer-local-must-match-map, and
6565 minibuffer-local-filename-must-match-map to Elisp.
6566 (syms_of_keymap): Defsubr make-composed-keymap.
6567 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6568 (parse_menu_item): Trivial simplification.
6569
3279eb87
GM
65702011-07-01 Glenn Morris <rgm@gnu.org>
6571
6572 * Makefile.in (SETTINGS_LIBS): Fix typo.
6573
4550efdf
KI
65742011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6575
6576 * coding.c (Fencode_coding_string): Record the last coding system
6577 used, as the function doc string says (bug#8738).
6578
0949d2b6
JD
65792011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6580
6581 * xsettings.c (store_monospaced_changed): Take new font as arg and
6582 check for change against current_mono_font.
6583 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6584 (emacs_settings_constructor, emacs_settings_get_property)
6585 (emacs_settings_set_property, emacs_settings_class_init)
6586 (emacs_settings_init, gsettings_obj): Remove.
6587 (something_changedCB): New function for HAVE_GSETTINGS.
6588 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6589 with value as argument.
6590 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6591 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6592 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6593 "changed".
6594
6595 * xgselect.c: Add defined (HAVE_GSETTINGS).
6596 (xgselect_initialize): Ditto.
6597
6598 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6599 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6600 xg_select.
6601
bbc6b304
PE
66022011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6603
6604 * eval.c (struct backtrace): Simplify and port the data structure.
6605 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6606 signed bit field, as this assumption is not portable and it makes
6607 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6608 "char debug_on_exit : 1" as this is not portable either; instead,
6609 use the portable "unsigned int debug_on_exit : 1". Remove unused
6610 member evalargs. Remove obsolete comments about cc bombing out.
6611
9851bfc5
JD
66122011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6613
51bb811f 6614 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6615 Let HAVE_GSETTINGS override HAVE_GCONF.
6616 (store_monospaced_changed): New function.
6617 (EMACS_SETTINGS): A new type derived from GObject to handle
6618 GSettings notifications.
6619 (emacs_settings_constructor, emacs_settings_get_property)
6620 (emacs_settings_set_property, emacs_settings_class_init):
6621 New functions.
6622 (gsettings_client, gsettings_obj): New variables.
6623 (GSETTINGS_SCHEMA): New define.
6624 (something_changedCB): Call store_monospaced_changed.
6625 (init_gsettings): New function.
6626 (xsettings_initialize): Call init_gsettings.
6627 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6628 to NULL.
6629
640c8776 6630 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6631 GCONF_CFLAGS/LIBS.
6632
5386012d
MR
66332011-06-29 Martin Rudalics <rudalics@gmx.at>
6634
6635 * window.c (resize_root_window, grow_mini_window)
6636 (shrink_mini_window): Rename Qresize_root_window to
6637 Qwindow_resize_root_window and Qresize_root_window_vertically to
6638 Qwindow_resize_root_window_vertically.
6639
f13e0b08
PE
66402011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6641
6642 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6643
94515237
JB
66442011-06-27 Juanma Barranquero <lekktu@gmail.com>
6645
6646 * makefile.w32-in: Redesign dependencies so they reflect more
6647 clearly which files are directly included by each source file,
6648 and not through other includes.
6649
e43b6e43
MR
66502011-06-27 Martin Rudalics <rudalics@gmx.at>
6651
6652 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6653 (sort_overlays, overlay_strings): When an overlay's clone number
6654 matches the window's clone number process the overlay even if
6655 the overlay's window property doesn't match the current window.
6656
d68443dc
MR
6657 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6658 (Fwindow_hchild): Rename to Fwindow_left_child.
6659 (Fwindow_next): Rename to Fwindow_next_sibling.
6660 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6661 (resize_window_check): Rename to window_resize_check.
6662 (resize_window_apply): Rename to window_resize_apply.
6663 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6664 (Fdelete_other_windows_internal, resize_frame_windows)
6665 (Fsplit_window_internal, Fdelete_window_internal)
6666 (grow_mini_window, shrink_mini_window)
6667 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6668
c7e73be5
JD
66692011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6670
6671 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6672 (emacs_fixed_set_min_size): Remove.
6673 (emacs_fixed_new): Take frame as argument.
6674
6675 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6676 (_EmacsFixedPrivate): Remove minwidth/height.
6677 Add struct frame *f.
6678 (emacs_fixed_init): Initialize priv->f.
6679 (get_parent_class, emacs_fixed_set_min_size): Remove.
6680 (emacs_fixed_new): Set priv->f to argument.
6681 (emacs_fixed_get_preferred_width)
6682 (emacs_fixed_get_preferred_height): Use min_width/height from
6683 frames size_hint to set minimum and natural (Bug#8919).
6684 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6685 and use min_width/height from frames size_hint to set
6686 min_width/height (Bug#8919).
6687
6688 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6689 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6690 Fix indentation.
c7e73be5 6691
cf99dcf8
EZ
66922011-06-26 Eli Zaretskii <eliz@gnu.org>
6693
6694 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6695 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6696 called at ZV.
6697
029529ac
CY
66982011-06-26 Chong Yidong <cyd@stupidchicken.com>
6699
6700 * process.c (wait_reading_process_output): Bypass select if
6701 waiting for a cell while ignoring keyboard input, and input is
6702 pending. Suggested by Jan Djärv (Bug#8869).
6703
7a7ef429
PE
67042011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6705
6706 Use gnulib's dup2 module instead of rolling our own.
6707 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6708
11fdef7d 67092011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6710
6711 * dispnew.c (scrolling_window): Before scrolling, turn off a
6712 mouse-highlight in the window being scrolled.
6713
cd3520a4
JB
67142011-06-24 Juanma Barranquero <lekktu@gmail.com>
6715
6716 Move DEFSYM to lisp.h and use everywhere.
6717
6718 * character.h (DEFSYM): Move declaration...
6719 * lisp.h (DEFSYM): ...here.
6720
6721 * gnutls.c:
6722 * minibuf.c:
6723 * w32menu.c:
6724 * w32proc.c:
6725 * w32select.c: Don't include character.h.
6726
6727 * alloc.c (syms_of_alloc):
6728 * buffer.c (syms_of_buffer):
6729 * bytecode.c (syms_of_bytecode):
6730 * callint.c (syms_of_callint):
6731 * casefiddle.c (syms_of_casefiddle):
6732 * casetab.c (init_casetab_once):
6733 * category.c (init_category_once, syms_of_category):
6734 * ccl.c (syms_of_ccl):
6735 * cmds.c (syms_of_cmds):
6736 * composite.c (syms_of_composite):
6737 * dbusbind.c (syms_of_dbusbind):
6738 * dired.c (syms_of_dired):
6739 * dispnew.c (syms_of_display):
6740 * doc.c (syms_of_doc):
6741 * editfns.c (syms_of_editfns):
6742 * emacs.c (syms_of_emacs):
6743 * eval.c (syms_of_eval):
6744 * fileio.c (syms_of_fileio):
6745 * fns.c (syms_of_fns):
6746 * frame.c (syms_of_frame):
6747 * fringe.c (syms_of_fringe):
6748 * insdel.c (syms_of_insdel):
6749 * keymap.c (syms_of_keymap):
6750 * lread.c (init_obarray, syms_of_lread):
6751 * macros.c (syms_of_macros):
6752 * msdos.c (syms_of_msdos):
6753 * print.c (syms_of_print):
6754 * process.c (syms_of_process):
6755 * search.c (syms_of_search):
6756 * sound.c (syms_of_sound):
6757 * syntax.c (init_syntax_once, syms_of_syntax):
6758 * terminal.c (syms_of_terminal):
6759 * textprop.c (syms_of_textprop):
6760 * undo.c (syms_of_undo):
6761 * w32.c (globals_of_w32):
6762 * window.c (syms_of_window):
6763 * xdisp.c (syms_of_xdisp):
6764 * xfaces.c (syms_of_xfaces):
6765 * xfns.c (syms_of_xfns):
6766 * xmenu.c (syms_of_xmenu):
6767 * xsettings.c (syms_of_xsettings):
6768 * xterm.c (syms_of_xterm): Use DEFSYM.
6769
4228cf16
TZ
67702011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6771
cd3520a4 6772 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6773
7fcccf1e
PE
67742011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6775
7efb4e0e
PE
6776 Integer and buffer overflow fixes (Bug#8873).
6777
ff5844ad
PE
6778 * print.c (printchar, strout): Check for string overflow.
6779 (PRINTPREPARE, printchar, strout):
6780 Don't set size unless allocation succeeds.
6781
90532f02
PE
6782 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6783 for sizes. Check for string overflow more accurately.
6784 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6785
6d84508d
PE
6786 * macros.c: Integer and buffer overflow fixes.
6787 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6788 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6789 Use ptrdiff_t, not int, for sizes.
6790 Don't increment bufsize until after realloc succeeds.
6791 Check for size-calculation overflow.
6792 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6793
437b2cb4
PE
6794 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6795
8b9ac8b4
PE
6796 * lread.c: Integer overflow fixes.
6797 (read_integer): Radix is now EMACS_INT, not int,
6798 to improve quality of diagnostics for out-of-range radices.
6799 Calculate buffer size correctly for out-of-range radices.
6800 (read1): Check for integer overflow in radices, and in
6801 read-circle numbers.
82cb60d3
PE
6802 (read_escape): Avoid int overflow.
6803 (Fload, openp, read_buffer_size, read1)
6804 (substitute_object_recurse, read_vector, read_list, map_obarray):
6805 Use ptrdiff_t, not int, for sizes.
6806 (read1): Use EMACS_INT, not int, for sizes.
20270765 6807 Check for size overflow.
8b9ac8b4 6808
7fcccf1e
PE
6809 * image.c (cache_image): Check for size arithmetic overflow.
6810
bfbbd7e7
PE
6811 * lread.c: Integer overflow issues.
6812 (saved_doc_string_size, saved_doc_string_length)
6813 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6814 Now ptrdiff_t, not int.
6815 (read1): Don't assume doc string length fits in int. Check for
6816 out-of-range doc string lengths.
6817 (read_list): Don't assume file position fits in int.
39019e54 6818 (read_escape): Check for hex character overflow.
bfbbd7e7 6819
4e323265
LL
68202011-06-22 Leo Liu <sdl.web@gmail.com>
6821
6822 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6823 Move to minibuffer.el.
6824
85fece3e
PE
68252011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6826
20b84ce9 6827 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6828 The following patches are for when GLYPH_DEBUG && !XASSERT.
6829 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6830 * dispnew.c (flush_stdout):
6831 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6832 Mark as externally visible.
6833 * dispnew.c (check_window_matrix_pointers): Now static.
6834 * dispnew.c (window_to_frame_vpos):
6835 * xfns.c (unwind_create_frame):
6836 * xterm.c (x_check_font): Remove unused local.
6837 * scroll.c (CHECK_BOUNDS):
6838 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6839 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6840 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6841 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6842 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6843 Now static.
6844 (debug_method_add): Use va_list and vsprintf rather than relying
6845 on undefined behavior with wrong number of arguments.
6846 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6847 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6848 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6849 since we're not interested in debugging glyphs with old libraries.
6850 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6851 GCC 4.6.0's static checking.
6852
0766b489
PE
68532011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6854
31fd4b32
PE
6855 Integer overflow and signedness fixes (Bug#8873).
6856 A few related buffer overrun fixes, too.
6857
b79e8648
PE
6858 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6859
0766b489
PE
6860 * dispextern.h (struct face.stipple):
6861 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6862 (x_bitmap_mask, x_allocate_bitmap_record)
6863 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6864 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6865 (x_create_bitmap_from_xpm_data):
6866 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6867 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6868 (.bitmaps_last):
6869 * xfaces.c (load_pixmap):
6870 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6871 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6872 (.bitmaps_last, struct x_output.icon_bitmap):
6873 Use ptrdiff_t, not int, for bitmap indexes.
6874 (x_allocate_bitmap_record): Check for size overflow.
6875 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6876
b081724f
PE
6877 Use ptrdiff_t, not int, for overlay counts.
6878 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6879 * editfns.c (overlays_around, get_pos_property):
6880 * textprop.c (get_char_property_and_overlay):
6881 * xdisp.c (next_overlay_change, note_mouse_highlight):
6882 * xfaces.c (face_at_buffer_position):
21514da7
PE
6883 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6884 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6885 (Fnext_overlay_change, Fprevious_overlay_change)
6886 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6887 Use ptrdiff_t, not int, for sizes.
21514da7 6888 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6889
3de73e5e
PE
6890 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6891
2606c57b
PE
6892 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6893 (x_session_initialize): Do not assume string length fits in int.
6894
aaafe47a
PE
6895 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6896 This is unlikely, but can occur if DPI is outlandish.
6897
2674ddc8 6898 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6899 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6900
28154962
PE
6901 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6902 * xrdb.c (magic_file_p, search_magic_path):
6903 Omit last arg SUFFIX; it was always 0. All callers changed.
6904 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6905
7de51af5
PE
6906 * xfont.c (xfont_match): Avoid need for strlen.
6907
25ed6cc3
PE
6908 * xfns.c: Don't assume strlen fits in int.
6909 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6910
4eab31dd
PE
6911 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6912 not unsigned long, as we prefer signed integers. All callers changed.
6913 Detect integer overflow in repeat count.
6914 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6915 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6916
171e2a58
PE
6917 * termcap.c: Don't assume sizes fit in int and never overflow.
6918 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6919 (gobble_line): Check for size-calculation overflow.
6920
ad39faca 6921 * minibuf.c (Fread_buffer):
6e5bb2dc 6922 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6923 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6924 Don't assume string length fits in int.
6925
52c61c22 6926 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6927 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6928
b5b8c9e5
PE
6929 * font.c: Don't assume string length fits in int.
6930 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6931 Use ptrdiff_t, not int.
ccd6111c
PE
6932 (font_intern_prop): Don't assume string length fits in int.
6933 Don't assume integer property fits in fixnum.
6934 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6935
882f0d81 6936 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6937 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6938 Reformulate so as not to need the command string.
6939 Invoke gzip -cd rather than gunzip, as it's more portable.
6940 (lock_info_type, lock_file_1, lock_file):
6941 Don't assume pid_t and time_t fit in unsigned long.
6942 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6943 (current_lock_owner): Prefer signed type for sizes.
6944 Use memcpy, not strncpy, where memcpy is what is really wanted.
6945 Don't assume (via atoi) that time_t and pid_t fit in int.
6946 Check for time_t and/or pid_t out of range, e.g., via a network share.
6947 Don't alloca where an auto var works fine.
6948
93f4cf88
PE
6949 * fileio.c: Fix some integer overflow issues.
6950 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6951 Don't assume string length fits in int.
6952 (directory_file_name): Don't assume string length fits in long.
6953 (make_temp_name): Don't assume pid fits in int, or that its print
6954 length is less than 20.
6955
f3e92b69
PE
6956 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6957
1bfdaf10
PE
6958 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6959
35016e9a
PE
6960 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6961
3d1e65a1
PE
6962 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6963 We prefer signed integers, even for size calculations.
6964
0b963a93
PE
6965 * emacs.c: Don't assume string length fits in 'int'.
6966 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6967 (main): Don't invoke strlen when not needed.
6968
573f4b54
PE
6969 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6970 (XD_DEBUG_MESSAGE): Don't waste a byte.
6971
989f33ba
PE
6972 * callproc.c (getenv_internal_1, getenv_internal)
6973 (Fgetenv_internal):
965d34eb
PE
6974 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6975
e4d29b33
PE
6976 * lread.c (invalid_syntax): Omit length argument.
6977 All uses changed. This doesn't fix a bug, but it simplifies the
6978 code away from its former Hollerith-constant appearance, and it's
6979 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6980 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6981
eb49b136
PE
6982 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6983 This didn't break anything, but it didn't help either.
6984 It's confusing to put a bogus integer in a place where the actual
6985 value does not matter.
9f62aeb1 6986 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6987 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6988
15375a22
PE
6989 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6990 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6991 implementation.
b61cc01c
PE
6992 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6993 We prefer signed types, and the value cannot exceed the EMACS_INT
6994 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6995 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6996 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6997 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6998
53b2623d
PE
6999 * indent.c (sane_tab_width): New function.
7000 (current_column, scan_for_column, Findent_to, position_indentation)
7001 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7002 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7003
51cab52b 7004 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7005
f2ed8a70
PE
7006 * lisp.h (lint_assume): New macro.
7007 * composite.c (composition_gstring_put_cache):
7008 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7009
abe80cc6
PE
7010 * editfns.c, insdel.c:
7011 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7012
b02c740e
PE
7013 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7014
ebc96716
PE
7015 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7016
b4e50fa0 7017 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7018 Use much-faster test for byte-length change.
311d5d7c 7019 Don't assume string byte-length fits in 'int'.
a4cf38e4 7020 Check that character arg fits in 'int'.
85461888 7021 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7022
c0c1ee9f
PE
7023 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7024
a498d7f4
PE
7025 * fns.c (concat): Catch string overflow earlier.
7026 Do not rely on integer wraparound.
7027
51cab52b
PE
7028 * dispextern.h (struct it.overlay_strings_charpos)
7029 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7030 * xdisp.c (forward_to_next_line_start)
7031 (back_to_previous_visible_line_start)
7032 (reseat_at_next_visible_line_start, next_element_from_buffer):
7033 Don't arbitrarily truncate the value of 'selective' to int.
7034
76031fad
PE
7035 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7036
5eb55db9
PE
7037 * composite.c: Don't truncate sizes to 'int'.
7038 (composition_gstring_p, composition_reseat_it)
7039 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7040 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7041 not EMACS_UINT, for indexes.
5eb55db9 7042
0703a717
PE
7043 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7044
d6202519
PE
7045 * buffer.c: Include <verify.h>.
7046 (struct sortvec.priority, struct sortstr.priority):
8961a454 7047 Now EMACS_INT, not int.
c20998a7 7048 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7049 (struct sortstr.size, record_overlay_string)
7050 (struct sortstrlist.size, struct sortlist.used):
7051 Don't truncate size to int.
7052 (record_overlay_string): Check for size-calculation overflow.
d6202519 7053 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7054
d5a19415
JM
70552011-06-22 Jim Meyering <meyering@redhat.com>
7056
029529ac 7057 Don't leak an XBM-image-sized buffer
d5a19415
JM
7058 * image.c (xbm_load): Free the image buffer after using it.
7059
a9041e6c
PE
70602011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7061
7062 Port to Sun C.
7063 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7064 that Sun C diagnosed.
7065 * fns.c (secure_hash): Fix pointer signedness issue.
7066 * intervals.c (static_offset_intervals): New function.
7067 (offset_intervals): Use it.
7068
7f3f739f
LL
70692011-06-21 Leo Liu <sdl.web@gmail.com>
7070
7071 * deps.mk (fns.o):
7072 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7073 sha512.h.
7074
7075 * fns.c (secure_hash): Rename from crypto_hash_function and change
7076 the first arg to accept symbols.
5b66d427 7077 (Fsecure_hash): New primitive.
7f3f739f
LL
7078 (syms_of_fns): New symbols.
7079
76147d94
DD
70802011-06-20 Deniz Dogan <deniz@dogan.se>
7081
7082 * process.c (Fset_process_buffer): Clarify return value in
7083 docstring.
7084
7d7d0045
CY
70852011-06-18 Chong Yidong <cyd@stupidchicken.com>
7086
7087 * dispnew.c (add_window_display_history): Use BVAR.
7088
7089 * xdisp.c (debug_method_add): Use BVAR.
7090 (check_window_end, dump_glyph_matrix, dump_glyph)
7091 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7092
7093 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7094 Likewise.
7095
7096 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7097 check till after the cache is created in init_frame_faces.
7098
ff2bc410
SM
70992011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7100
7101 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7102
28177add
PE
71032011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7104
dd3482fe
PE
7105 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7106 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7107 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7108
393d71f3 7109 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7110 * fileio.c (Finsert_file_contents):
7111 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7112 Remove the old (too-loose) buffer overflow checks.
7113 They weren't needed, since make_gap checks for buffer overflow.
7114 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7115 The old code merely checked for Emacs fixnum overflow, and relied
7116 on undefined (wraparound) behavior. The new code avoids undefined
7117 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7118
2e6813b0 7119 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7120 Tune. Don't use wider integers than needed. Don't use alloca.
7121 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7122
599a9e4f
PE
7123 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7124
99561444
PE
7125 * insdel.c, lisp.h (buffer_overflow): New function.
7126 (insert_from_buffer_1, replace_range, replace_range_2):
7127 * insdel.c (make_gap_larger):
7128 * editfns.c (Finsert_char):
7129 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7130
28177add
PE
7131 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7132
e69dafad
PE
71332011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7134
4baa020d 7135 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7136
b1c46f02
PE
7137 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7138 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7139
e69dafad
PE
7140 * fileio.c: Don't assume EMACS_INT fits in off_t.
7141 (emacs_lseek): New static function.
7142 (Finsert_file_contents, Fwrite_region): Use it.
7143 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7144
566684ea
PE
7145 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7146
e6966cd6
PE
7147 * fns.c: Don't overflow int when computing a list length.
7148 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7149 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7150 truncation on 64-bit hosts. Check for QUIT every
7151 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7152 faster and is responsive enough.
7153 (Flength): Report an error instead of overflowing an integer.
7154 (Fsafe_length): Return a float if the value is not representable
7155 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7156 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7157 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7158
dd0b0efb
PE
7159 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7160 (header_size, word_size): New constants.
7161 (allocate_vectorlike): Don't check size overflow here.
7162 (allocate_vector): Check it here instead, since this is the only
7163 caller of allocate_vectorlike that could cause overflow.
7164 Check that the new vector's length is representable as a fixnum.
7165
86fe5cfe
PE
7166 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7167 The previous code was bogus. For example, next_almost_prime (32)
7168 returned 39, which is undesirable as it is a multiple of 3; and
7169 next_almost_prime (24) returned 25, which is a multiple of 5 so
7170 why was the code bothering to check for multiples of 7?
7171
80e88859
PE
7172 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7173
4a2f0ad6
PE
7174 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7175
f66c7cf8
PE
7176 Variadic C functions now count arguments with ptrdiff_t.
7177 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7178 Back then I didn't know that the Emacs coding style prefers signed int.
7179 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7180 were being counted with int, which may truncate counts on 64-bit
7181 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7182 * lisp.h (struct Lisp_Subr.function.aMANY)
7183 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7184 Arg counts are now ptrdiff_t, not size_t.
7185 All variadic functions and their callers changed accordingly.
7186 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7187 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7188 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7189 * callint.c (Fcall_interactively): Check arg count for overflow,
7190 to avoid potential buffer overrun. Use signed char, not 'int',
7191 for 'varies' array, so that we needn't bother to check its size
7192 calculation for overflow.
7193 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7194 * eval.c (apply_lambda):
7195 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7196 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7197 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7198
a1759b76
PE
7199 * callint.c (Fcall_interactively): Don't use index var as event count.
7200
d96be9fc
PE
7201 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7202 * mem-limits.h (SIZE): Remove; no longer used.
7203
a690a978 7204 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7205
578c21e6
PE
7206 Remove unnecessary casts.
7207 * xterm.c (x_term_init):
7208 * xfns.c (x_set_border_pixel):
7209 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7210 These aren't needed now that we assume ANSI C.
7211
96f53c6c
PE
7212 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7213 It's more likely to cause problems (due to unsigned overflow)
7214 than to cure them.
7215
83c77d31
PE
7216 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7217
ee2079f1
PE
7218 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7219
6da65536
PE
7220 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7221
7147c4a4
PE
7222 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7223
193e32d9
PE
7224 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7225
e5533da6
PE
7226 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7227
9910e595
PE
7228 GLYPH_CODE_FACE returns EMACS_INT, not int.
7229 * dispextern.h (merge_faces):
7230 * xfaces.c (merge_faces):
01103c44
PE
7231 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7232 Don't assume EMACS_INT fits in int.
9910e595 7233
2638320e
PE
7234 * character.h (CHAR_VALID_P): Remove unused parameter.
7235 * fontset.c, lisp.h, xdisp.c: All uses changed.
7236
045eb8d9
PE
7237 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7238
c1f134b5
PE
7239 * fns.c (concat): Minor tuning based on overflow analysis.
7240 This doesn't fix any bugs. Use int to hold character, instead
7241 of constantly refetching from Emacs object. Use XFASTINT, not
7242 XINT, for value known to be a character. Don't bother comparing
7243 a single byte to 0400, as it's always less.
7244
395fcb93 7245 * floatfns.c (Fexpt):
327eeec8
PE
7246 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7247
abbd3d23
PE
7248 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7249 for characters.
7250
684a03ef
PE
7251 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7252
0fed43f3
PE
7253 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7254 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7255 incorrectly succeed when S was a string, because 4294967386 was
7256 truncated before it was used.
7257
8fd02eb7
PE
7258 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7259 Otherwise, an out-of-range integer could cause undefined behavior
7260 on a 64-bit host.
7261
f8c86b69
PE
7262 * composite.c: Use int, not EMACS_INT, for characters.
7263 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7264 EMACS_INT, for values that are known to be in character range.
7265 This doesn't fix any bugs but is the usual style inside Emacs and
7266 may generate better code on 32-bit machines.
7267
34206dd2
PE
7268 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7269 This is for reasons similar to the recent CHAR_STRING fix.
7270 * charset.c (Fencode_char): Check that character arg is actually
7271 a character. Pass an int to ENCODE_CHAR.
7272 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7273 wider than 'int', as a compile-time check to prevent future regressions
7274 in this area.
7275
c5958d4c 7276 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7277
7278 Make sure a 64-bit char is never passed to CHAR_STRING.
7279 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7280 by silently ignoring the top 32 bits, allowing some values
7281 that were far too large to be valid characters.
7282 * character.h: Include <verify.h>.
7283 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7284 arguments are no wider than unsigned, as a compile-time check
7285 to prevent future regressions in this area.
7286 * data.c (Faset):
01103c44 7287 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7288 (Fsubst_char_in_region):
7289 * fns.c (concat):
7290 * xdisp.c (decode_mode_spec_coding):
7291 Adjust to CHAR_STRING's new requirement.
7292 * editfns.c (Finsert_char, Fsubst_char_in_region):
7293 * fns.c (concat): Check that character args are actually
7294 characters. Without this test, these functions did the wrong
7295 thing with wildly out-of-range values on 64-bit hosts.
7296
d37ca623
PE
7297 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7298 These casts should not be needed on 32-bit hosts, either.
7299 * keyboard.c (read_char):
7300 * lread.c (Fload): Remove casts to unsigned.
7301
ea204efb
PE
7302 * lisp.h (UNSIGNED_CMP): New macro.
7303 This fixes comparison bugs on 64-bit hosts.
7304 (ASCII_CHAR_P): Use it.
7305 * casefiddle.c (casify_object):
01103c44 7306 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7307 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7308 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7309 * dispextern.h (FACE_FROM_ID):
7310 * keyboard.c (read_char): Use UNSIGNED_CMP.
7311
41cb286c
PE
7312 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7313 not to EMACS_INT, to avoid GCC warning.
7314
4a1b9832
PE
7315 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7316
55daad71
PE
7317 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7318 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7319 isn't needed on 32-bit machines.
8f95c75c 7320
01103c44
PE
7321 * buffer.c (Fgenerate_new_buffer_name):
7322 Use EMACS_INT for count, not int.
0ceccced 7323 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7324
7325 * data.c (Qcompiled_function): Now static.
7326
c6f072e7
PE
7327 * window.c (window_body_lines): Now static.
7328
20ce5912
PE
7329 * image.c (gif_load): Rename local to avoid shadowing.
7330
9c4c5f81
PE
7331 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7332 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7333 * alloc.c (make_save_value): Integer argument is now of type
7334 ptrdiff_t, not int.
7335 (mark_object): Use ptrdiff_t, not int.
7336 * lisp.h (pD): New macro.
7337 * print.c (print_object): Use it.
7338
c0c5c8ae
PE
7339 * alloc.c: Use EMACS_INT, not int, to count objects.
7340 (total_conses, total_markers, total_symbols, total_vector_size)
7341 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7342 (total_free_floats, total_floats, total_free_intervals)
7343 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7344 Now EMACS_INT, not int. All uses changed.
7345 (Fgarbage_collect): Compute overall total using a double, so that
7346 integer overflow is less likely to be a problem. Check for overflow
7347 when converting back to an integer.
5a25e253
PE
7348 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7349 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7350 These were 'int' variables that could overflow on 64-bit hosts;
7351 they were never used, so remove them instead of repairing them.
211a0b2a 7352 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7353 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7354 Previously, this ceilinged at INT_MAX, but that doesn't work on
7355 64-bit machines.
e46bb31a 7356 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7357
c78baabf 7358 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7359 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7360 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7361 when a (possibly-narrower) signed value would do just as well.
7362 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7363
c9d624c6
PE
7364 * alloc.c: Catch some string size overflows that we were missing.
7365 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7366 for convenience in STRING_BYTES_MAX.
7367 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7368 The definition here is exact; the one in lisp.h was approximate.
7369 (allocate_string_data): Check for string overflow. This catches
7370 some instances we weren't catching before. Also, it catches
7371 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7372 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7373 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7374
c9d624c6
PE
7375 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7376 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7377 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7378
353032ce
PE
7379 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7380
2bccce07
PE
7381 * alloc.c (Fmake_string): Check for out-of-range init.
7382
0ac30604
SM
73832011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7384
7385 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7386
c195f2de
JD
73872011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7388
7389 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7390 xg_get_default_scrollbar_width.
7391
7392 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7393 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7394 (style_changed_cb): Call update_theme_scrollbar_width and call
7395 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7396 all frames (Bug#8505).
7397 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7398 Call gtk_window_set_resizable if HAVE_GTK3.
7399 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7400 and height if HAVE_GTK3 (Bug#8505).
7401 (scroll_bar_width_for_theme): New variable.
7402 (update_theme_scrollbar_width): New function.
7403 (xg_get_default_scrollbar_width): Move code to
7404 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7405 (xg_initialize): Call update_theme_scrollbar_width.
7406
7407 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7408
7409 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7410
e10ac9f1
MR
74112011-06-12 Martin Rudalics <rudalics@gmx.at>
7412
7413 * frame.c (make_frame): Call other_buffer_safely instead of
7414 other_buffer.
7415
7416 * window.c (temp_output_buffer_show): Call display_buffer with
7417 second argument Vtemp_buffer_show_specifiers and reset latter
7418 immediately after the call.
7419 (Vtemp_buffer_show_specifiers): New variable.
7420 (auto_window_vscroll_p, next_screen_context_lines)
7421 (Vscroll_preserve_screen_position): Remove leading asterisks from
7422 doc-strings.
7423
2d3c217e 74242011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7425
7b7f97e8 7426 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7427 * buffer.c (Qclone_number): Remove for now, as it's unused.
7428 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7429 (record_buffer): Remove unused local.
7430 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7431 (set_frame_buffer_list): Remove; unused.
7432 * frame.h (other_visible_frames): Remove decl.
7433 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7434 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7435 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7436 if HAVE_GPM.
7437 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7438 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7439 Define only if HAVE_GPM.
7440 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7441 (update_hints_inhibit): Remove; never set. All uses removed.
7442 * widgetprv.h (emacsFrameClassRec): Remove decl.
7443 * window.c (delete_deletable_window): Now returns void, since it
7444 wasn't returning anything.
7445 (compare_window_configurations): Remove unused locals.
7446 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7447 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7448 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7449 the same widths as pointers. This follows up on the 2011-05-06 patch.
7450 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7451 * xterm.h: Likewise.
7452 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7453
1384b89e
JB
74542011-06-12 Juanma Barranquero <lekktu@gmail.com>
7455
7456 * makefile.w32-in: Update dependencies.
7457 (LISP_H): Add lib/intprops.h.
7458
1100a63c
CY
74592011-06-11 Chong Yidong <cyd@stupidchicken.com>
7460
7461 * image.c (gif_load): Add animation frame delay to the metadata.
7462 (syms_of_image): Use DEFSYM. New symbol `delay'.
7463
6198ccd0
MR
74642011-06-11 Martin Rudalics <rudalics@gmx.at>
7465
7466 * window.c (delete_deletable_window): Re-add.
7467 (Fset_window_configuration): Rewrite to handle dead buffers and
7468 consequently deletable windows.
7469 (window_tree, Fwindow_tree): Remove. Supply functionality in
7470 window.el.
7471 (compare_window_configurations): Simplify code.
7472
b6e3633c
AS
74732011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7474
1ab0dee5
AS
7475 * image.c (imagemagick_load_image): Fix type mismatch.
7476 (Fimagemagick_types): Likewise.
7477
b6e3633c
AS
7478 * window.h (replace_buffer_in_windows): Declare.
7479
9397e56f
MR
74802011-06-11 Martin Rudalics <rudalics@gmx.at>
7481
7482 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7483 Qclone_number. Remove external declaration of Qdelete_window.
7484 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7485 code.
640c8776
SM
7486 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7487 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7488 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7489 buffer list implementation.
7490 (other_buffer_safely): New function.
7491 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7492 calls to replace_buffer_in_windows and
7493 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7494 if allowed.
7495 (record_buffer): Inhibit quitting and rewrite using quittable
7496 functions. Run Qbuffer_list_update_hook if allowed.
7497 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7498 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7499 Move switch-to-buffer to window.el.
9397e56f
MR
7500 (bury-buffer): Move to window.el.
7501 (Vbuffer_list_update_hook): New variable.
7502
7503 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7504 section.
7505
7506 * window.h (resize_frame_windows): Move up in code.
7507 (Fwindow_frame): Remove EXFUN.
7508 (replace_buffer_in_all_windows): Remove prototype.
7509 (replace_buffer_in_windows_safely): Add prototype.
7510
7511 * window.c: Declare Qdelete_window static again. Move down
7512 declaration of select_count.
7513 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7514 (Fother_window): Move to window.el.
7515 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7516 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7517 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7518 window.el.
7519 (replace_buffer_in_windows): Implement by calling
7520 Qreplace_buffer_in_windows.
7521 (replace_buffer_in_all_windows): Remove with some functionality
7522 moved into replace_buffer_in_windows_safely.
7523 (replace_buffer_in_windows_safely): New function.
7524 (select_window_norecord, select_frame_norecord): Move in front
7525 of run_window_configuration_change_hook. Remove now obsolete
7526 declarations.
640c8776
SM
7527 (Fset_window_buffer): Rewrite doc-string.
7528 Call Qrecord_window_buffer.
9397e56f
MR
7529 (keys_of_window): Move binding for other-window to window.el.
7530
b50691aa
CY
75312011-06-11 Chong Yidong <cyd@stupidchicken.com>
7532
7533 * dispextern.h (struct image): Replace data member, whose int_val
7534 and ptr_val fields were not used by anything, with a single
7535 lisp_val object.
7536
7537 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7538 (gif_clear_image, gif_load, imagemagick_load_image)
7539 (gs_clear_image, gs_load): Callers changed.
7540
3f754b86
PE
75412011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7542
cca69397
PE
7543 * buffer.h: Include <time.h>, for time_t.
7544 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7545
109e28d0
PE
7546 Fix minor problems found by static checking.
7547
60737f02
PE
7548 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7549
4b66faf3
PE
7550 Make identifiers static if they are not used in other modules.
7551 * data.c (Qcompiled_function, Qframe, Qvector):
7552 * image.c (QimageMagick, Qsvg):
7553 * minibuf.c (Qmetadata):
7554 * window.c (resize_window_check, resize_root_window): Now static.
7555 * window.h (resize_window_check, resize_root_window): Remove decls.
7556
109e28d0
PE
7557 * window.c (window_deletion_count, delete_deletable_window):
7558 Remove; unused.
46a4ce9e
PE
7559 (window_body_lines): Now static.
7560 (Fdelete_other_windows_internal): Mark vars as initialized.
7561 Make sure 'resize_failed' is initialized.
7562 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7563 (resize_window_apply): Remove unused local.
7564 * window.h (delete_deletable_window): Remove decl.
7565
109e28d0 7566 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7567 (imagemagick_load_image): Fix pointer signedness problem by changing
7568 last arg from unsigned char * to char *. All uses changed.
7569 Also, fix a local for similar reasons.
7570 Remove unused locals. Remove locals to avoid shadowing.
7571 (fn_rsvg_handle_free): Remove; unused.
7572 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7573 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7574
3f754b86
PE
7575 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7576
2547adb1
CY
75772011-06-10 Chong Yidong <cyd@stupidchicken.com>
7578
7579 * image.c (gif_load): Fix omitted cast error introduced by
7580 2011-06-06 change.
7581
2c8e37d4
MR
75822011-06-10 Martin Rudalics <rudalics@gmx.at>
7583
7584 * window.h (resize_proportionally, orig_total_lines)
7585 (orig_top_line): Remove from window structure.
7586 (set_window_height, set_window_width, change_window_heights)
7587 (Fdelete_window): Remove prototypes.
7588 (resize_frame_windows): Remove duplicate declaration.
7589
440a42e3
EZ
75902011-06-10 Eli Zaretskii <eliz@gnu.org>
7591
7592 * window.h (resize_frame_windows, resize_window_check)
7593 (delete_deletable_window, resize_root_window)
7594 (resize_frame_windows): Declare prototypes.
7595
7596 * window.c (resize_window_apply): Make definition be "static" to
7597 match the prototype.
7598
562dd5e9
MR
75992011-06-10 Martin Rudalics <rudalics@gmx.at>
7600
7601 * window.c: Remove declarations of Qwindow_size_fixed,
7602 window_min_size_1, window_min_size_2, window_min_size,
7603 size_window, window_fixed_size_p, enlarge_window, delete_window.
7604 Remove static from declaration of Qdelete_window, it's
7605 temporarily needed by Fbury_buffer.
7606 (replace_window): Don't assign orig_top_line and
7607 orig_total_lines.
7608 (Fdelete_window, delete_window): Remove. Window deletion is
7609 handled by window.el.
640c8776
SM
7610 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7611 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7612 (Fdelete_other_windows): Remove. Deleting other windows is
7613 handled by window.el.
7614 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7615 handled in window.el.
7616 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7617 Window minimum sizes are handled in window.el.
7618 (shrink_windows, size_window, set_window_height)
7619 (set_window_width, change_window_heights, window_height)
7620 (window_width, CURBEG, CURSIZE, enlarge_window)
7621 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7622 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7623 handled in window.el.
7624 (make_dummy_parent): Rename to make_parent_window and give it a
7625 second argument horflag.
7626 (make_window): Don't set resize_proportionally any more.
7627 (Fsplit_window): Remove. Windows are split in window.el.
7628 (save_restore_action, save_restore_orig_size)
7629 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7630 Resize mini windows in window.el.
7631 (grow_mini_window, shrink_mini_window): Implement by calling
7632 Qresize_root_window_vertically, resize_window_check and
7633 resize_window_apply.
640c8776
SM
7634 (saved_window, Fset_window_configuration, save_window_save):
7635 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7636 resize_proportionally.
7637 (window_min_height, window_min_width): Move to window.el.
7638 (keys_of_window): Move bindings for delete-other-windows,
7639 split-window, delete-window and enlarge-window to window.el.
7640
7641 * buffer.c: Temporarily extern Qdelete_window.
7642 (Fbury_buffer): Temporarily call Qdelete_window instead of
7643 Fdelete_window (Fbury_buffer will move to window.el soon).
7644
7645 * frame.c (set_menu_bar_lines_1): Remove code handling
7646 orig_top_line and orig_total_lines.
7647
7648 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7649 set_window_height but set heights directly.
7650 (change_frame_size_1): Use resize_frame_windows.
7651
7652 * xdisp.c (init_xdisp): Don't use set_window_height but set
7653 heights directly.
7654
640c8776
SM
7655 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7656 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7657 run_window_configuration_change_hook.
7658
7659 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7660 instead of change_window_heights and run
7661 run_window_configuration_change_hook.
7662
1a13852e
MR
76632011-06-09 Martin Rudalics <rudalics@gmx.at>
7664
7665 * window.c (replace_window): Rename second argument REPLACEMENT to
7666 NEW. New third argument SETFLAG. Rewrite.
7667 (delete_window, make_dummy_parent): Call replace_window with
7668 third argument 1.
7669 (window_list_1): Move down in code.
7670 (run_window_configuration_change_hook): Move set_buffer part
7671 before select_frame_norecord part in order to unwind correctly.
7672 Rename count1 to count.
7673 (recombine_windows, delete_deletable_window, resize_root_window)
7674 (Fdelete_other_windows_internal)
7675 (Frun_window_configuration_change_hook, make_parent_window)
7676 (resize_window_check, resize_window_apply, Fresize_window_apply)
7677 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7678 (Fdelete_window_internal, Fresize_mini_window_internal):
7679 New functions.
1a13852e
MR
7680 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7681
f3d1777e
MR
76822011-06-08 Martin Rudalics <rudalics@gmx.at>
7683
496e208e
MR
7684 * window.h (window): Add some new members to window structure -
7685 normal_lines, normal_cols, new_total, new_normal, clone_number,
7686 splits, nest, prev_buffers, next_buffers.
7687 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7688 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7689
f3d1777e
MR
7690 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7691 Remove.
496e208e
MR
7692 (make_dummy_parent): Set new members of windows structure.
7693 (make_window): Move down in code. Handle new members of window
7694 structure.
7695 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7696 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7697 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7698 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7699 (Fset_window_next_buffers, Fset_window_clone_number):
7700 New functions.
496e208e
MR
7701 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7702 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7703 Doc-string fixes.
7704 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7705 Argument WINDOW can be now internal window too.
7706 (Fwindow_use_time): Move up in code.
7707 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7708 Rewrite doc-string.
7709 (Fset_window_configuration, saved_window)
7710 (Fcurrent_window_configuration, save_window_save): Handle new
7711 members of window structure.
b9e809c2
MR
7712 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7713 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7714 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7715 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7716 Qget_mru_window, Qresize_root_window,
7717 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7718 Qauto_buffer_name; staticpro them.
f3d1777e 7719
abde8f8c
MR
77202011-06-07 Martin Rudalics <rudalics@gmx.at>
7721
7722 * window.c (Fwindow_total_size, Fwindow_left_column)
7723 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7724 (Fwindow_list_1): New functions.
7725 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7726 (Fwindow_width, Fscroll_left, Fscroll_right):
7727 Use window_body_cols instead of window_box_text_cols.
7728 (delete_window, Fset_window_configuration):
7729 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7730 (delete_all_subwindows): Take a window as argument and not a
7731 structure. Rewrite.
190b47e6
MR
7732 (window_loop): Remove handling of GET_LRU_WINDOW and
7733 GET_LARGEST_WINDOW.
7734 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7735
7736 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7737 window_box_text_cols. delete_all_subwindows now takes a
7738 Lisp_Object as argument.
abde8f8c 7739
640c8776
SM
7740 * indent.c (compute_motion, Fcompute_motion):
7741 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7742
fa8a67e6
MR
7743 * frame.c (delete_frame): Call delete_all_subwindows with root
7744 window as argument.
7745
a54e3482
DC
77462011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7747
7748 * fns.c (Fputhash): Document return value.
7749
60002bf5
CY
77502011-06-06 Chong Yidong <cyd@stupidchicken.com>
7751
7752 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7753
0c671da6 77542011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7755
b862a52a 7756 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7757
be44ca6c
PE
7758 Check for overflow when converting integer to cons and back.
7759 * charset.c (Fdefine_charset_internal, Fdecode_char):
7760 Use cons_to_unsigned to catch overflow.
7761 (Fencode_char): Use INTEGER_TO_CONS.
7762 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7763 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7764 * data.c (long_to_cons, cons_to_long): Remove.
7765 (cons_to_unsigned, cons_to_signed): New functions.
7766 These signal an error for invalid or out-of-range values.
7767 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7768 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7769 * font.c (Ffont_variation_glyphs):
7770 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7771 * lisp.h: Include <intprops.h>.
7772 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7773 (cons_to_signed, cons_to_unsigned): New decls.
7774 (long_to_cons, cons_to_long): Remove decls.
7775 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7776 (Fprimitive_undo): Use CONS_TO_INTEGER.
7777 * xfns.c (Fx_window_property): Likewise.
7778 * xselect.c: Include <limits.h>.
7779 (x_own_selection, selection_data_to_lisp_data):
7780 Use INTEGER_TO_CONS.
7781 (x_handle_selection_request, x_handle_selection_clear)
7782 (x_get_foreign_selection, Fx_disown_selection_internal)
7783 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7784 (lisp_data_to_selection_data): Use cons_to_unsigned.
7785 (x_fill_property_data): Use cons_to_signed.
7786 Report values out of range.
7787
d1f3d2af
PE
7788 Check for buffer and string overflow more precisely.
7789 * buffer.h (BUF_BYTES_MAX): New macro.
7790 * lisp.h (STRING_BYTES_MAX): New macro.
7791 * alloc.c (Fmake_string):
7792 * character.c (string_escape_byte8):
7793 * coding.c (coding_alloc_by_realloc):
7794 * doprnt.c (doprnt):
7795 * editfns.c (Fformat):
7796 * eval.c (verror):
7797 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7798 since they may not be the same number.
7799 * editfns.c (Finsert_char):
7800 * fileio.c (Finsert_file_contents):
7801 Likewise for BUF_BYTES_MAX.
7802
dd52fcea
PE
7803 * image.c: Use ptrdiff_t, not int, for sizes.
7804 (slurp_file): Switch from int to ptrdiff_t.
7805 All uses changed.
7806 (slurp_file): Check that file size fits in both size_t (for
7807 malloc) and ptrdiff_t (for sanity and safety).
7808
7f9bbdbb
PE
7809 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7810 if b->modtime has its maximal value.
7811
dfe18f82
PE
7812 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7813
84acfcf0
PE
7814 Don't assume time_t can fit into int.
7815 * buffer.h (struct buffer.modtime): Now time_t, not int.
7816 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7817 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7818
ccd9a01a
PE
7819 Minor fixes for signed vs unsigned integers.
7820 * character.h (MAYBE_UNIFY_CHAR):
7821 * charset.c (maybe_unify_char):
7822 * keyboard.c (read_char, reorder_modifiers):
7823 XINT -> XFASTINT, since the integer must be nonnegative.
7824 * ftfont.c (ftfont_spec_pattern):
7825 * keymap.c (access_keymap, silly_event_symbol_error):
7826 XUINT -> XFASTINT, since the integer must be nonnegative.
7827 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7828 since it makes no difference and we prefer signed.
7829 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7830 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7831 nonnegative.
7832
d6d100dd
SM
78332011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7834
7835 * window.h (Fwindow_frame): Declare.
7836
2b6148e4
PE
78372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7838
7839 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7840 (SPARE_MEMORY): Always define.
7841 (LARGE_REQUEST): Remove.
7842 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7843
f230ecc9
MR
78442011-06-06 Martin Rudalics <rudalics@gmx.at>
7845
727e958e
MR
7846 * lisp.h: Move EXFUNS for Fframe_root_window,
7847 Fframe_first_window and Fset_frame_selected_window to window.h.
7848
7849 * window.h: Move EXFUNS for Fframe_root_window,
7850 Fframe_first_window and Fset_frame_selected_window here from
7851 lisp.h.
7852
7853 * frame.c (Fwindow_frame, Fframe_first_window)
7854 (Fframe_root_window, Fframe_selected_window)
7855 (Fset_frame_selected_window): Move to window.c.
7856 (Factive_minibuffer_window): Move to minibuf.c.
7857 (Fother_visible_frames_p): New function.
7858
7859 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7860
f230ecc9
MR
7861 * window.c (decode_window, decode_any_window): Move up in code.
7862 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7863 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7864 (Fwindow_buffer): Move up and rewrite doc-string.
7865 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7866 (Fwindow_prev): New functions.
727e958e
MR
7867 (Fwindow_frame): Move here from frame.c. Accept any window as
7868 argument.
7869 (Fframe_root_window, Fframe_first_window)
7870 (Fframe_selected_window): Move here from frame.c. Accept frame
7871 or arbitrary window as argument. Update doc-strings.
7872 (Fminibuffer_window): Move up in code.
7873 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7874 (Fset_frame_selected_window): Move here from frame.c.
7875 Marginal rewrite.
727e958e
MR
7876 (Fselected_window, select_window, Fselect_window): Move up in
7877 code. Minor doc-string fixes.
f230ecc9 7878
4d09bcf6
PE
78792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7880
7881 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7882 Do not assume that spare memory exists; that assumption is valid
7883 only if SYSTEM_MALLOC.
7884 (LARGE_REQUEST): New macro, so that the issue of large requests
7885 is separated from the issue of spare memory.
7886
810928a2
AS
78872011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7888
172418ad
AS
7889 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7890 format. (Bug#8806)
7891
43f862f7
AS
7892 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7893
810928a2
AS
7894 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7895 before statements.
7896
a059fe24
JD
78972011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7898
7899 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7900
7901 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7902
7903 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7904 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7905
989bf368
JB
79062011-06-05 Juanma Barranquero <lekktu@gmail.com>
7907
7908 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7909
4b80f674
CY
79102011-06-04 Chong Yidong <cyd@stupidchicken.com>
7911
7912 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7913 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7914 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7915 New error handlers.
4b80f674
CY
7916 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7917 Obey Vx_select_enable_clipboard_manager. Catch errors in
7918 x_clipboard_manager_save (Bug#8779).
7919 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7920 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7921
99a33b77 79222011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7923
7924 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7925
99a33b77 79262011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7927
7928 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7929 in the current matrix if keep_current_p is non-zero.
7930
8264569d
EZ
79312011-06-04 Eli Zaretskii <eliz@gnu.org>
7932
7933 * bidi.c (bidi_level_of_next_char): Fix last change.
7934
57f97249
EZ
79352011-06-03 Eli Zaretskii <eliz@gnu.org>
7936
fec2107c 7937 Support bidi reordering of text covered by display properties.
57f97249 7938
fec2107c
EZ
7939 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7940 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7941 (bidi_cache_search, bidi_cache_iterator_state)
7942 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7943 (bidi_level_of_next_char, bidi_move_to_visually_next):
7944 Support character positions inside a run of characters covered by a
fec2107c
EZ
7945 display string.
7946 (bidi_paragraph_init, bidi_resolve_explicit_1)
7947 (bidi_level_of_next_char): Call bidi_fetch_char and
7948 bidi_fetch_char_advance instead of FETCH_CHAR and
7949 FETCH_CHAR_ADVANCE.
7950 (bidi_init_it): Initialize new members.
7951 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7952 definitions.
7953 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7954 instead of using explicit *_CHAR codes.
d6d100dd
SM
7955 (bidi_resolve_explicit, bidi_resolve_weak):
7956 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7957 bidirectional text is supported only in multibyte buffers.
7958 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7959 it to initialize the frame_window_p member of struct bidi_it.
7960 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7961 (bidi_resolve_explicit, bidi_resolve_weak)
7962 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7963 bidi_it->nchars is non-positive.
7964 (bidi_level_of_next_char): Don't try to lookup the cache for the
7965 next/previous character if nothing is cached there yet, or if we
7966 were just reseat()'ed to a new position.
c40e2fb2 7967
0e14fe90
EZ
7968 * xdisp.c (set_cursor_from_row): Set start and stop points
7969 according to the row's direction when priming the loop that looks
7970 for the glyph on which to display cursor.
7971 (single_display_spec_intangible_p): Function deleted.
7972 (display_prop_intangible_p): Reimplement to call
7973 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7974 Accept 3 additional arguments needed by handle_display_spec.
7975 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7976 values: lists, `(when COND...)' forms, etc.
7977 (single_display_spec_string_p): Support property values that are
7978 lists with the argument STRING its top-level element.
7979 (display_prop_string_p): Fix the condition for processing a
7980 property that is a list to be consistent with handle_display_spec.
fec2107c 7981 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7982 last portion of handle_display_prop.
7983 (compute_display_string_pos): Accept additional argument
7984 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7985 value of a `display' property is a "replacing spec".
7986 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7987 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7988 the display property, but just return a value indicating whether
7989 the display property will replace the characters it covers.
7990 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7991 frame_window_p members of struct bidi_it.
d6d100dd
SM
7992 (compute_display_string_pos, compute_display_string_end):
7993 New functions.
fec2107c
EZ
7994 (push_it): Accept second argument POSITION, where pop_it should
7995 jump to continue iteration.
7996 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7997
fec2107c
EZ
7998 * keyboard.c (adjust_point_for_property): Adjust the call to
7999 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8000
8001 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8002 (bidi_init_it): Update prototypes.
8003 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8004 (compute_display_string_pos, compute_display_string_end):
8005 Declare prototypes.
fec2107c
EZ
8006 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8007 EMACS_INT.
fc6f18ce 8008
40087514 80092011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8010
57f53182
PE
8011 Malloc failure behavior now depends on size of allocation.
8012 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8013 * lisp.h: Change signatures accordingly.
8014 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8015 All callers changed. (Bug#8762)
8016
8017 * gnutls.c: Use Emacs's memory allocators.
8018 Without this change, the gnutls library would invoke malloc etc.
8019 directly, which causes problems on non-SYNC_INPUT hosts, and which
8020 runs afoul of improving memory_full behavior. (Bug#8761)
8021 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8022 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8023 xfree instead of the default malloc, realloc, free.
8024 (Fgnutls_boot): No need to check for memory allocation failure,
8025 since xmalloc does that for us.
8026
ac32cd99 8027 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8028 * category.c (hash_get_category_set):
8029 * ccl.c (ccl_driver):
8030 * charset.c (Fdefine_charset_internal):
8031 * charset.h (struct charset.hash_index):
8032 * composite.c (get_composition_id, gstring_lookup_cache)
8033 (composition_gstring_put_cache):
8034 * composite.h (struct composition.hash_index):
8035 * dispextern.h (struct image.hash):
8036 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8037 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8038 (hashfn_equal, hashfn_user_defined, make_hash_table)
8039 (maybe_resize_hash_table, hash_lookup, hash_put)
8040 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8041 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8042 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8043 * image.c (make_image, search_image_cache, lookup_image)
8044 (xpm_put_color_table_h):
8045 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8046 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8047 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8048 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8049 * alloc.c (allocate_vectorlike):
8050 Check for overflow in vector size calculations.
8051 * ccl.c (ccl_driver):
8052 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8053 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8054 need to be updated by these changes.
40087514
PE
8055 * fns.c (make_hash_table, maybe_resize_hash_table):
8056 Check for integer overflow with large hash tables.
0de4bb68
PE
8057 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8058 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8059 (SXHASH_REDUCE): New macro.
8060 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8061 Use it instead of discarding useful hash info with large hash values.
8062 (sxhash_float): New function.
8063 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8064 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8065 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8066 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8067 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8068 Adjust signatures to match updated version of code.
8069 (consing_since_gc): Now EMACS_INT, since a single hash table can
8070 use more than INT_MAX bytes.
8071
698d32e2
DN
80722011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8073
8074 Make it possible to build with GCC-4.6+ -O2 -flto.
8075
8076 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8077
fd6fa53f
SM
80782011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8079
8080 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8081 Call minibuffer-inactive-mode.
8082
864db017
JB
80832011-05-31 Juanma Barranquero <lekktu@gmail.com>
8084
8085 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8086 Update dependencies.
8087
2ad0baf4
DN
80882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8089
8090 * data.c (init_data): Remove code for UTS, this system is not
8091 supported anymore.
8092
4fcc2638
DN
80932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8094
8095 Don't force ./temacs to start in terminal mode.
8096
8097 * frame.c (make_initial_frame): Initialize faces in all cases, not
8098 only when CANNOT_DUMP is defined.
8099 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8100
c56e0fd5
DN
81012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8102
8103 * dispnew.c (add_window_display_history): Use const for the string
8104 pointer. Remove declaration, not needed.
8105
333d54da 81062011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8107
55d4c1b2 8108 Use 'inline', not 'INLINE'.
333d54da 8109 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8110 * alloc.c, fontset.c (INLINE): Remove.
8111 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8112 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8113 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8114 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8115 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8116
738db178
DN
81172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8118
8119 Make it possible to run ./temacs.
8120
8121 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8122 syms_of_callproc does the same thing. Remove test for
8123 "initialized", do it in the caller.
8124 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8125
620c53a6
SM
81262011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8127
8128 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8129 (read_minibuf): Use get_minibuffer.
8130 (syms_of_minibuf): Use DEFSYM.
8131 (Qmetadata): New var.
8132 * data.c (Qbuffer): Don't make it static.
8133 (syms_of_data): Use DEFSYM.
8134
e003a292
PE
81352011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8136
8137 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8138 (CCL_CODE_MIN): New macro.
8139
ed008a6d
PE
81402011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8141
3687c2ef
PE
8142 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8143
ed008a6d
PE
8144 * eval.c (Qdebug): Now static.
8145 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8146 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8147 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8148
d66c4c7c
CY
81492011-05-29 Chong Yidong <cyd@stupidchicken.com>
8150
8151 * image.c: Various fixes to ImageMagick code comments.
8152 (Fimagemagick_types): Doc fix.
8153
5fbc2025
PE
81542011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8155
0196f88a
PE
8156 Minor fixes prompted by GCC 4.6.0 warnings.
8157
8158 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8159
5fbc2025
PE
8160 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8161 (x_clipboard_manager_save_all): Move extern decl to ...
8162 * xterm.h: ... here, so that it can be checked for consistency.
8163
1dd3c2d9
CY
81642011-05-29 Chong Yidong <cyd@stupidchicken.com>
8165
8166 * xselect.c (x_clipboard_manager_save_frame)
8167 (x_clipboard_manager_save_all): New functions.
8168 (Fx_clipboard_manager_save): Lisp function deleted.
8169
8170 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8171 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8172
8173 * xterm.h: Update prototype.
8174
5ba6571d
WX
81752011-05-28 William Xu <william.xwl@gmail.com>
8176
8177 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8178 exiting (Bug#8239).
8179
3eaff834
JM
81802011-05-28 Jim Meyering <meyering@redhat.com>
8181
e1900994 8182 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8183 * fns.c (to_uchar): Define.
8184 (crypto_hash_function): Use it to convert some newly-signed
8185 variables to unsigned, to avoid sign-extension bugs. For example,
8186 without this change, (md5 "truc") would evaluate to
8187 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8188 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8189 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8190
0f6990a7
PE
81912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8192
8193 Integer overflow fixes.
c8a9ca5a 8194
08686060
PE
8195 * dbusbind.c: Serial number integer overflow fixes.
8196 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8197 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8198 to hold a serial number that is too large for a fixnum.
8199 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8200 Check for serial numbers out of range. Decode any serial number
59568bf0 8201 that was so large that it became a float. (Bug#8722)
08686060 8202
2d1fc3c7
PE
8203 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8204 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8205 Use XFASTINT rather than XUINT when numbers are nonnegative.
8206 (xd_append_arg, Fdbus_method_return_internal):
8207 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8208 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8209 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8210 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8211 (Bug#8722)
2d1fc3c7 8212
c8a9ca5a
PE
8213 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8214
519e1d69
PE
8215 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8216
6df6ae42 8217 ccl: Add integer overflow checks.
30569699
PE
8218 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8219 (IN_INT_RANGE): New macros.
8220 (ccl_driver): Use them to check for integer overflow when
8221 decoding a CCL program. Many of the new checks are whether XINT (x)
8222 fits in int; it doesn't always, on 64-bit hosts. The new version
8223 doesn't catch all possible integer overflows, but it's an
847044ea 8224 improvement. (Bug#8719)
30569699 8225
c11285dc
PE
8226 * alloc.c (make_event_array): Use XINT, not XUINT.
8227 There's no need for unsigned here.
8228
fdccd48e
PE
8229 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8230 This follows up to the 2011-05-06 change that substituted uintptr_t
8231 for EMACS_INT. This case wasn't caught back then.
8232
37910ab2
PE
8233 Rework Fformat to avoid integer overflow issues.
8234 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8235 now (part of C89). Include <verify.h>.
8236 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8237 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8238 (Fformat): Avoid the prepass trying to compute sizes; it was only
8239 approximate and thus did not catch overflow reliably. Instead, walk
8240 through the format just once, formatting and computing sizes as we go,
8241 checking for integer overflow at every step, and allocating a larger
8242 buffer as needed. Keep track separately whether the format is
8243 multibyte. Keep only the most-recently calculated precision, rather
8244 than them all. Record whether each argument has been converted to
8245 string. Use EMACS_INT, not int, for byte and char and arg counts.
8246 Support field widths and precisions larger than INT_MAX. Avoid
8247 sprintf's undefined behavior with conversion specifications such as %#d
8248 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8249 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8250 formatting out-of-range floating point numbers with int
9173deec 8251 formats. (Bug#8668)
37910ab2 8252
2e6578fb
PE
8253 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8254
0ae6bdee
PE
8255 * data.c: Avoid integer truncation in expressions involving floats.
8256 * data.c: Include <intprops.h>.
8257 (arith_driver): When there's an integer overflow in an expression
8258 involving floating point, convert the integers to floating point
8259 so that the resulting value does not suffer from catastrophic
8260 integer truncation. For example, on a 64-bit host (* 4
8261 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8262 Do not rely on undefined behavior after integer overflow.
8263
de883a70
PE
8264 merge count_size_as_multibyte, parse_str_to_multibyte
8265 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8266 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8267 Check for integer overflow.
8268 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8269 since it's now a duplicate of the other. This is more of
8270 a character than a buffer op, so better that it's in character.c.
8271 * fns.c, print.c: Adjust to above changes.
8272
2ff916cb
PE
82732011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8274
8275 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8276
f1b54466
PE
82772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8278
fb1ac845
PE
8279 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8280 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8281 (x_clipboard_manager_save): Now static.
8282 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8283
f1b54466
PE
8284 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8285 (crypto_hash_function): Now static.
8286 Fix pointer signedness problems. Avoid unnecessary initializations.
8287
a9f737ee
CY
82882011-05-27 Chong Yidong <cyd@stupidchicken.com>
8289
8290 * termhooks.h (Vselection_alist): Make it terminal-local.
8291
8292 * terminal.c (create_terminal): Initialize it.
8293
8294 * xselect.c: Support for clipboard managers.
8295 (Vselection_alist): Move to termhooks.h as terminal-local var.
8296 (LOCAL_SELECTION): New macro.
8297 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8298 (symbol_to_x_atom): Remove gratuitous arg.
8299 (x_handle_selection_request, lisp_data_to_selection_data)
8300 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8301 (x_own_selection, x_get_local_selection, x_convert_selection):
8302 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8303 (some_frame_on_display): Delete unused function.
8304 (Fx_own_selection_internal, Fx_get_selection_internal)
8305 (Fx_disown_selection_internal, Fx_selection_owner_p)
8306 (Fx_selection_exists_p): New optional frame arg.
8307 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8308 (x_handle_selection_clear): Don't treat other terminals with the
8309 same keyboard specially. Use the terminal-local Vselection_alist.
8310 (x_clear_frame_selections): Use Frun_hook_with_args.
8311
8312 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8313
8314 * xterm.h: Add support for those atoms.
8315
e067f0c1
CY
83162011-05-26 Chong Yidong <cyd@stupidchicken.com>
8317
8318 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8319 (converted_selections, conversion_fail_tag): New global variables.
8320 (x_selection_request_lisp_error): Free the above.
8321 (x_get_local_selection): Remove unnecessary code.
8322 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8323 of converted selections stored in converted_selections.
8324 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8325 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8326 (x_convert_selection): New function.
8327 (x_handle_selection_event): Simplify.
8328 (x_get_foreign_selection): Don't ignore incoming requests while
8329 waiting for an answer; this will fail when we implement
8330 SAVE_TARGETS, and seems unnecessary anyway.
8331 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8332 (Vx_sent_selection_functions): Doc fix.
8333
0f4aebc0
LL
83342011-05-26 Leo Liu <sdl.web@gmail.com>
8335
8336 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8337
e61124cd
YM
83382011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8339
8340 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8341
8342 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8343 for fringe update if it has periodic bitmap.
ac389d0c 8344 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8345 and fringe_bitmap_periodic_p.
8346
8347 * fringe.c (get_fringe_bitmap_data): New function.
8348 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8349 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8350 row. Mark glyph row for fringe update if periodicity changed.
8351
8352 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8353 for fringe update unless it has periodic bitmap.
8354
f16d9837
KH
83552011-05-25 Kenichi Handa <handa@m17n.org>
8356
8357 * xdisp.c (get_next_display_element): Set correct it->face_id for
8358 a static composition.
8359
e1b90ef6
LL
83602011-05-24 Leo Liu <sdl.web@gmail.com>
8361
8362 * deps.mk (fns.o):
8363 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8364
8365 * fns.c (crypto_hash_function, Fsha1): New function.
8366 (Fmd5): Use crypto_hash_function.
8367 (syms_of_fns): Add Ssha1.
8368
7400048f
PE
83692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8370
8371 * gnutls.c: Remove unused macros.
8372 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8373 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8374 Remove macros that are defined and never used.
8375 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8376
abb71cf4
CY
83772011-05-22 Chong Yidong <cyd@stupidchicken.com>
8378
8379 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8380 (Fx_get_selection_internal): Minor cleanup.
8381 (Fx_own_selection_internal): Rename arguments for consistency with
8382 select.el.
8383
6307db39
PE
83842011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8385
8386 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8387
f3d4e0a4
CY
83882011-05-22 Chong Yidong <cyd@stupidchicken.com>
8389
8390 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8391
4d8ade89
YM
83922011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8393
8394 * dispnew.c (scrolling_window): Don't exclude the case that the
8395 last enabled row in the desired matrix touches the bottom boundary.
8396
32078c8d
GM
83972011-05-21 Glenn Morris <rgm@gnu.org>
8398
8399 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8400 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8401 and add some more files.
32078c8d 8402
7285dc67
EZ
84032011-05-20 Eli Zaretskii <eliz@gnu.org>
8404
8405 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8406 report_file_error introduced by the change from 2011-05-07.
8407
89d1bd22
PE
84082011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8409
8410 * systime.h (Time): Define only if emacs is defined.
8411 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8412 where the include path doesn't have X11/X.h by default. See
8413 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8414
cd394be1 84152011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8416
8417 * composite.c (find_automatic_composition): Fix previous change.
8418
b9704ad9
GM
84192011-05-20 Glenn Morris <rgm@gnu.org>
8420
8421 * lisp.mk: New file, split from Makefile.in.
8422 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8423 (shortlisp): Remove.
8424 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8425
4a720484
GM
84262011-05-19 Glenn Morris <rgm@gnu.org>
8427
8428 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8429 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8430 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8431 (lisp): Set the order to that of loadup.el.
8432 (shortlisp): Make it a copy of $lisp.
8433 (SOME_MACHINE_LISP): Remove.
8434 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8435 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8436
a28d4396
KH
84372011-05-18 Kenichi Handa <handa@m17n.org>
8438
8439 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8440 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8441 (find_automatic_composition): Mostly rewrite for efficiency.
8442
a2b1fa8e
JB
84432011-05-18 Juanma Barranquero <lekktu@gmail.com>
8444
8445 * makefile.w32-in: Update dependencies.
8446
8e1f5610
CS
84472011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8448
8449 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8450 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8451
7025ee00 84522011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8453
cdfa6eab
PE
8454 Fix some integer overflow issues, such as string length overflow.
8455
06d6db33
PE
8456 * insdel.c (count_size_as_multibyte): Check for string overflow.
8457
2b4560a8
PE
8458 * character.c (lisp_string_width): Check for string overflow.
8459 Use EMACS_INT, not int, for string indexes and lengths; in
8460 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8461 the resulting string length overflows an EMACS_INT; instead,
8462 report a string overflow if no precision given. When checking for
8463 precision exhaustion, use a check that cannot possibly have
8464 integer overflow. (Bug#8675)
8465 * character.h (lisp_string_width): Adjust to new signature.
8466
cb93f9be
PE
8467 * alloc.c (string_overflow): New function.
8468 (Fmake_string): Use it. This doesn't change behavior, but saves
8469 a few bytes and will simplify future changes.
8470 * character.c (string_escape_byte8): Likewise.
8471 * lisp.h (string_overflow): New decl.
8472
1a1f3366
PE
8473 Fixups, following up to the user-interface timestamp change.
8474 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8475 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8476 * msdos.c (mouse_get_pos): Likewise.
8477 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8478 * w32gui.h (Time): Define by including "systime.h" rather than by
8479 declaring it ourselves. (Bug#8664)
8480
d4e3e4d3
PE
8481 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8482 * image.c (clear_image_cache): Likewise.
8483
f6a24d19
PE
8484 * term.c (term_mouse_position): Don't assume time_t wraparound.
8485
08dc5ae6
PE
8486 Be more systematic about user-interface timestamps.
8487 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8488 and sometimes 'EMACS_UINT', to represent these timestamps.
8489 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8490 This makes the code easier to follow, and makes it easier to catch
8491 integer overflow bugs such as Bug#8664.
8492 * frame.c (Fmouse_position, Fmouse_pixel_position):
8493 Use Time, not unsigned long, for user-interface timestamps.
8494 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8495 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8496 * keyboard.h (last_event_timestamp): Likewise.
8497 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8498 * menu.h (xmenu_show): Likewise.
8499 * term.c (term_mouse_position): Likewise.
8500 * termhooks.h (struct input_event.timestamp): Likewise.
8501 (struct terminal.mouse_position_hook): Likewise.
8502 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8503 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8504 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8505 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8506 what it was before.
8507 * menu.h, termhooks.h: Include "systime.h", for Time.
8508
8e55734a
PE
8509 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8510 Don't assume that the difference between two unsigned long values
8511 can fit into an integer. At this point, we know button_down_time
8512 <= event->timestamp, so the difference must be nonnegative, so
8513 there's no need to cast the result if double-click-time is
8514 nonnegative, as it should be; check that it's nonnegative, just in
8515 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8516 apart (about 25 days). (Bug#8664)
8e55734a 8517
841f1b75 8518 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8519 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8520
3e26f69c
PE
8521 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8522 that always fit in int. Use a sentinel instead of a counter, to
8523 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8524 * frame.h (struct frame): Use int for menu_bar_items_used
8525 instead of EMACS_INT, since it always fits in int.
3e26f69c 8526
5cc152c0
PE
8527 * menu.c (grow_menu_items): Check for int overflow.
8528
d89eb65e
PE
8529 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8530
5235bd3e
PE
8531 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8532 Before, the code was not consistent. These values cannot exceed
8533 2**31 - 1 so there's no need to make them unsigned.
8534 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8535 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8536 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8537 as modifiers.
8538 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8539
bc827e23
PE
8540 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8541 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8542 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8543 presumably because the widths might not match.
8544
78eb494e
PE
8545 * window.c (size_window): Avoid needless test at loop start.
8546
04f2d78b
CB
85472011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8548
8549 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8550
d2fc7e3d 85512011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8552
8553 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8554
d2fc7e3d 85552011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8556
8557 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8558 `width' to `bar_area_x' and `bar_area_width', respectively.
8559 (x_scroll_run): Take account of fringe background extension.
8560
04f2d78b
CB
8561 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8562 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8563 `bar_area_width', respectively.
8564 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8565 background extension.
8566
79b70037
GM
85672011-05-10 Jim Meyering <meyering@redhat.com>
8568
8569 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8570
2f142cc5
JB
85712011-05-10 Juanma Barranquero <lekktu@gmail.com>
8572
8573 * image.c (Finit_image_library): Return t for built-in image types,
8574 like pbm and xbm. (Bug#8640)
8575
57679c86
AS
85762011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8577
8578 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8579
888c9e86
EZ
85802011-05-07 Eli Zaretskii <eliz@gnu.org>
8581
b0512a1d
EZ
8582 * w32console.c (Fset_screen_color): Doc fix.
8583 (Fget_screen_color): New function.
8584 (syms_of_ntterm): Defsubr it.
8585
7285dc67
EZ
8586 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8587 unlink the temporary file if Fcall_process didn't create it in the
8588 first place.
8589 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8590 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8591 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8592 cue to call_process_cleanup not to close that handle.
8593
4d3fcc8e
BK
85942011-05-07 Ben Key <bkey76@gmail.com>
8595
8596 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8597 one of two shell specific rules, either bootstrap-temacs-CMD or
8598 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8599 to the previous implementation of the bootstrap-temacs rule.
8600 The bootstrap-temacs-CMD rule is similar to the previous
8601 implementation of the bootstrap-temacs rule except that it
8602 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8603 variable.
8604
8605 These changes, along with some changes to nt/configure.bat,
8606 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8607 earlier fix to add support for --cflags and --ldflags options
8608 that include quotes so that it works whether make uses cmd or
8609 sh as the shell.
8610
b4289b64
MA
86112011-05-06 Michael Albinus <michael.albinus@gmx.de>
8612
8613 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8614 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8615 is a constant.
8616 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8617 a string. Handle both cases.
8618 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8619 (Fdbus_register_method): Use Qinvalid_function.
8620
af4c0e28
JB
86212011-05-06 Juanma Barranquero <lekktu@gmail.com>
8622
8623 * makefile.w32-in: Update dependencies.
8624 (LISP_H): Add inttypes.h and stdin.h.
8625 (PROCESS_H): Add unistd.h.
8626
c51453d9
EZ
86272011-05-06 Eli Zaretskii <eliz@gnu.org>
8628
8629 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8630 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8631
8ff0ac3c 86322011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8633
4c4b566b
PE
8634 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8635
aab2b9b5
PE
8636 * term.c (vfatal): Remove stray call to va_end.
8637 It's not needed and the C Standard doesn't allow it here anyway.
8638
c378da0b
PE
8639 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8640 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8641
288b08c7
PE
8642 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8643 bytes.
8644
e3601888
PE
8645 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8646
db6c0e74
PE
8647 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8648
dd5963ea
PE
8649 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8650
88c9450f
PE
8651 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8652
2f9442b8
PE
8653 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8654
c032b5f8
PE
8655 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8656 * charset.c (Fdefine_charset_internal): Don't initialize
8657 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8658 32-bit int (Bug#8600).
a108c10b
PE
8659
8660 * lread.c (read_integer): Be more consistent with string-to-number.
8661 Use string_to_number to do the actual conversion; this avoids
8662 rounding errors and fixes some other screwups. Without this fix,
8663 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8664 (digit_to_number): Move earlier, for benefit of read_integer.
8665 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8666 not a digit in any supported base. (Bug#8602)
a108c10b 8667
ad5f9eea
PE
8668 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8669
aec1708a
PE
8670 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8671 to match comment at start of function. This also removes a
8672 GCC warning about overflow in a 32+64-bit port.
8673
47be4ab5
PE
8674 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8675
371cac43
PE
8676 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8677 Reported by Stefan Monnier in
8678 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8679 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8680 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8681
d01a7826
PE
8682 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8683 (EMACS_UINTPTR): Likewise, with uintptr_t.
8684
7fd47d5c
PE
8685 * lisp.h: Prefer 64-bit EMACS_INT if available.
8686 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8687 on 32-bit hosts that have 64-bit int, so that they can access
8688 large files.
122b0c86
PE
8689 However, temporarily disable this change unless the temporary
8690 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8691
8727937b
PE
8692 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8693
8ac068ac
PE
8694 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8695 This removes an assumption that EMACS_INT and long are the same
8696 width as pointers. The assumption is true for Emacs porting targets
8697 now, but we want to make other targets possible.
8698 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8699 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8700 In the rest of the code, change types of integers that hold casted
8701 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8702 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8703 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8704 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8705 No need to cast type when ORing.
8706 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8707 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8708 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8709 assume EMACS_INT is the same width as char *.
8710 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8711 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8712 Remove no-longer-needed casts.
8713 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8714 (xg_tool_bar_help_callback, xg_make_tool_item):
8715 Use EMACS_INTPTR to hold an integer
8716 that will be cast to void *; this can avoid a GCC warning
8717 if EMACS_INT is not the same width as void *.
8718 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8719 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8720 (current_message_1, set_message_1):
8721 Use a local to convert to proper width without a cast.
8722 * xmenu.c (dialog_selection_callback): Likewise.
8723
ede49d71
PE
8724 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8725 Also, don't assume VALBITS / RAND_BITS is less than 5,
8726 and don't rely on undefined behavior when shifting a 1 left into
8727 the sign bit.
8728 * lisp.h (get_random): Change signature to match.
8729
2f30ecd0
PE
8730 * lread.c (hash_string): Use size_t, not int, for hash computation.
8731 Normally we prefer signed values; but hashing is special, because
8732 it's better to use unsigned division on hash table sizes so that
8733 the remainder is nonnegative. Also, size_t is the natural width
8734 for hashing into memory. The previous code used 'int', which doesn't
8735 retain enough info to hash well into very large tables.
8736 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8737
2a866e7b
PE
8738 * dbusbind.c: Don't possibly lose pointer info when converting.
8739 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8740 Use XPNTR rather than XHASH, so that the high-order bits of
8741 the pointer aren't lost when converting through void *.
8742
51639eac
PE
8743 * eval.c (Fautoload): Don't double-shift a pointer.
8744
92394119
PE
8745 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8746
dbdb9a7c
JB
87472011-05-06 Juanma Barranquero <lekktu@gmail.com>
8748
8749 * gnutls.c (DEF_GNUTLS_FN):
8750 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8751
db7a0b4f
AS
87522011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8753
8754 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8755 marker. (Bug#8610)
8756
cd394be1 87572011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8758
8759 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8760 New version that can reserve upto 2GB of heap space.
8761
f7ff1b0f 87622011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8763
8764 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8765
639c109b
TZ
87662011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8767
8768 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8769 `gnutls_certificate_set_x509_key_file'.
8770
d2127135
JB
87712011-05-05 Juanma Barranquero <lekktu@gmail.com>
8772
8773 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8774 Update dependencies.
8775
e968f4f3
JB
87762011-05-04 Juanma Barranquero <lekktu@gmail.com>
8777
8778 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8779 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8780 Remove unused parameter `fildes'.
8781 * process.c (read_process_output, send_process): Don't pass it.
8782
84d358f0
JB
87832011-05-04 Juanma Barranquero <lekktu@gmail.com>
8784
8785 Fix previous change: the library cache is defined in w32.c.
8786 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8787 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8788
0898ca10
JB
87892011-05-04 Juanma Barranquero <lekktu@gmail.com>
8790
8791 Implement dynamic loading of GnuTLS on Windows.
8792
8793 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8794 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8795 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8796 Declare.
8797
8798 * gnutls.c (Qgnutls_dll): Define.
8799 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8800 (gnutls_*): Declare function pointers.
8801 (init_gnutls_functions): New function to initialize function pointers.
8802 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8803 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8804 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8805 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8806 (emacs_gnutls_write, emacs_gnutls_read)
8807 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8808 (Fgnutls_available_p): New function.
8809 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8810 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8811 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8812
8813 * image.c: Include w32.h.
8814 (Vimage_type_cache): Delete.
8815 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8816 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8817 (w32_delayed_load): Move to w32.c.
8818
8819 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8820
8821 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8822 (w32_delayed_load): Move from image.c. When loading a library, record
8823 its filename in the :loaded-from property of the library id.
8824 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8825 Initialize and staticpro them.
8826 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8827
8828 * process.c: Include lisp.h before w32.h, not after.
8829 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8830 instead of gnutls_record_check_pending.
8831
8832 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8833
ff4de4aa
TZ
88342011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8835
8836 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8837 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8838 as passed in.
8839
abe95abb
JD
88402011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8841
8842 * xterm.c (x_set_frame_alpha): Do not set property on anything
8843 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8844
e16e55d4
JB
88452011-05-02 Juanma Barranquero <lekktu@gmail.com>
8846
8847 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8848
bafcf6a5
JB
88492011-05-02 Juanma Barranquero <lekktu@gmail.com>
8850
8851 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8852 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8853 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8854 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8855 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8856 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8857 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8858 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8859 (Qgnutls_bootprop_callbacks_verify): Make static.
8860
e7a6747f
AS
88612011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8862
19ed11ba
AS
8863 * callproc.c: Indentation fixup.
8864
e7a6747f 8865 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8866 (wait_for_termination, interruptible_wait_for_termination):
8867 Move after wait_for_termination_1.
e7a6747f 8868
1ef14cb4
LMI
88692011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8870
8871 * sysdep.c (interruptible_wait_for_termination): New function
8872 which is like wait_for_termination, but allows keyboard
8873 interruptions.
8874
8875 * callproc.c (Fcall_process): Add (:file "file") as an option for
8876 the STDOUT buffer.
8877 (Fcall_process_region): Ditto.
8878
330d880c
EZ
88792011-04-30 Eli Zaretskii <eliz@gnu.org>
8880
8db90b73
EZ
8881 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8882 rather than `XVECTOR (FOO)->size'.
8883
330d880c
EZ
8884 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8885 inttypes.h, as a gnulib replacement is used if it not available in
8886 system headers.
8887
15cbd324
EZ
88882011-04-21 Eli Zaretskii <eliz@gnu.org>
8889
8890 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8891 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8892 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8893
8894 * coding.c (coding_alloc_by_realloc): Error out if destination
8895 will grow beyond MOST_POSITIVE_FIXNUM.
8896 (decode_coding_emacs_mule): Abort if there isn't enough place in
8897 charbuf for the composition carryover bytes. Reserve an extra
8898 space for up to 2 characters produced in a loop.
8899 (decode_coding_iso_2022): Abort if there isn't enough place in
8900 charbuf for the composition carryover bytes.
8901
89022011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8903
ae940cca
EZ
8904 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8905 aborting when %lld or %lll format is passed.
8906 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8907 %llo or %llx format is passed. (Bug#8545)
8908
03ab8921
EZ
8909 * window.c (window_scroll_line_based): Use a marker instead of
8910 simple variables to record original value of point. (Bug#7952)
8911
afda1437
EZ
8912 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8913 produced by %s or %c overflows available buffer space. (Bug#8545)
8914
f76dee0c
PE
89152011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8916
8917 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8918 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8919
fdc5744d
JB
89202011-04-28 Juanma Barranquero <lekktu@gmail.com>
8921
8922 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8923
638f053a
JB
89242011-04-28 Juanma Barranquero <lekktu@gmail.com>
8925
8926 * keyboard.c (Qdelayed_warnings_hook): Define.
8927 (command_loop_1): Run `delayed-warnings-hook'
8928 if Vdelayed_warnings_list is non-nil.
8929 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8930 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8931
d178f871
EZ
89322011-04-28 Eli Zaretskii <eliz@gnu.org>
8933
8934 * doprnt.c (doprnt): Don't return value smaller than the buffer
8935 size if the message was truncated. (Bug#8545).
8936
b124fd93
JB
89372011-04-28 Juanma Barranquero <lekktu@gmail.com>
8938
8939 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8940 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8941
e810457d
PE
89422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8943
8944 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8945
ea51cceb
JB
89462011-04-27 Juanma Barranquero <lekktu@gmail.com>
8947
8948 * makefile.w32-in: Update dependencies.
8949
94dcfacf
EZ
89502011-04-27 Eli Zaretskii <eliz@gnu.org>
8951
8952 Improve `doprnt' and its usage. (Bug#8545)
8953 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8954 `format_end'. Remove support for %l as a conversion specifier.
8955 Don't use xrealloc. Improve diagnostics when the %l size modifier
8956 is used. Update the commentary.
8957
8958 * eval.c (verror): Simplify calculation of size_t.
8959
8960 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8961 messages.
8962
f61f41d7
PE
89632011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8964
8965 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8966 change.
8967
96fb4434
PE
89682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8969
8970 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8971 This makes this file independent of the recent pseudovector change.
8972
671875da 89732011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8974
69e9b5a3
PE
8975 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8976
b5f869a7 8977 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8978 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8979 Remove unused local.
c8926152 8980 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8981
841a1577 8982 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8983 GCC 4.6.0 optimizes based on type-based alias analysis.
8984 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8985 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8986 != &v->size, and therefore "v->size = 1; b->size = 2; return
8987 v->size;" must therefore return 1. This assumption is incorrect
8988 for Emacs, since it type-puns struct Lisp_Vector * with many other
8989 types. To fix this problem, this patch adds a new type struct
f904488f 8990 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8991 and pseudovectors, and helps optimizing compilers not get fooled
8992 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8993 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8994 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8995 the size member.
eab3844f
PE
8996 (XSETPVECTYPE): Rewrite in terms of new macro.
8997 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8998 This is a bit clearer, and further avoids the possibility of
8999 undesirable aliasing.
9000 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9001 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9002 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9003 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9004 (ASIZE): Now uses header.size rather than size.
9005 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9006 to avoid the hassle of writing XVECTOR (foo)->header.size.
9007 (struct vectorlike_header): New type.
eab3844f
PE
9008 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9009 object, to help avoid aliasing.
9010 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9011 (SUBRP): Likewise, since Lisp_Subr is a special case.
9012 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9013 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9014 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9015 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9016 changed to be "header.size" and "header.next".
9017 * buffer.h (struct buffer): Likewise.
9018 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9019 * frame.h (struct frame): Likewise.
9020 * process.h (struct Lisp_Process): Likewise.
9021 * termhooks.h (struct terminal): Likewise.
9022 * window.c (struct save_window_data, struct saved_window): Likewise.
9023 * window.h (struct window): Likewise.
9024 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9025 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9026 * buffer.c (init_buffer_once): Likewise.
9027 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9028 special case.
9029 * process.c (Fformat_network_address): Use local var for size,
9030 for brevity.
9031
0df1eac5
PE
9032 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9033
847ab9d1 9034 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9035 * data.c (atof): Remove decl; no longer used or needed.
9036 (digit_to_number): Move to lread.c.
9037 (Fstring_to_number): Use new string_to_number function, to be
9038 consistent with how the Lisp reader treats infinities and NaNs.
9039 Do not assume that floating-point numbers represent EMACS_INT
9040 without losing information; this is not true on most 64-bit hosts.
9041 Avoid double-rounding errors, by insisting on integers when
9042 parsing non-base-10 numbers, as the documentation specifies.
9043 * lisp.h (string_to_number): New decl, replacing ...
9044 (isfloat_string): Remove.
bc0a5c13 9045 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9046 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9047 appears to have been a coding error. Similarly, do not accept
9048 strings like +-1e0 as floating point numbers. Do not report
9049 overflow for integer overflows unless the base is not 10 which
9050 means we have no simple and reliable way to continue.
9051 Break out the floating-point parsing into a new
9052 function string_to_number, so that Fstring_to_number parses
9053 floating point numbers consistently with the Lisp reader.
04f2d78b 9054 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9055 (E_CHAR, EXP_INT): Remove, replacing with ...
9056 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9057 (string_to_number): New function, replacing isfloat_string.
9058 This function checks for valid syntax and produces the resulting
9059 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9060 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9061 so that overflow for non-base-10 numbers is reported only when
9062 there's no portable and simple way to convert to floating point.
452f4150 9063
67769ffc
PE
9064 * textprop.c (set_text_properties_1): Rewrite for clarity,
9065 and to avoid GCC warning about integer overflow.
9066
c20db43f
PE
9067 * intervals.h (struct interval): Use EMACS_INT for members
9068 where EMACS_UINT might cause problems. See
9069 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9070 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9071 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9072 All uses changed.
37aa2f85
PE
9073 (offset_intervals): Tell GCC not to worry about length overflow
9074 when negating a negative length.
c20db43f 9075
2538aa2f
PE
9076 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9077 (overrun_check_free): Likewise.
9078
f2d3008d
PE
9079 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9080 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9081 word size.
9082
ec8df744
PE
9083 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9084 (gnutls_make_error): Rename local to avoid shadowing.
9085 (gnutls_emacs_global_deinit): ifdef out; not used.
9086 (Fgnutls_boot): Use const for pointer to readonly storage.
9087 Comment out unused local. Fix pointer signedness problems.
9088
640ee02d
PE
9089 * lread.c (openp): Don't stuff size_t into an 'int'.
9090 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9091 about possible signed overflow.
9092
6048fb2a
PE
9093 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9094 (GDK_KEY_g): Don't define if already defined.
9095 (xg_prepare_tooltip): Avoid pointer signedness problem.
9096 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9097
fa3c87e1
PE
9098 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9099 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9100
2172544b
PE
9101 * xfns.c (Fx_window_property): Simplify a bit,
9102 to make a bit faster and to avoid GCC 4.6.0 warning.
9103 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9104
9b821a21
PE
9105 * fns.c (internal_equal): Don't assume size_t fits in int.
9106
3c616cfa
PE
9107 * alloc.c (compact_small_strings): Tighten assertion a little.
9108
c2982e87
PE
9109 Replace pEd with more-general pI, and fix some printf arg casts.
9110 * lisp.h (pI): New macro, generalizing old pEd macro to other
9111 conversion specifiers. For example, use "...%"pI"d..." rather
9112 than "...%"pEd"...".
9113 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9114 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9115 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9116 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9117 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9118 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9119 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9120 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9121 64-bit hosts.
9122 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9123 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9124 * print.c (safe_debug_print, print_object): Likewise.
9125 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9126 to int.
6f04d126
PE
9127 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9128 avoiding the 0 flag, which is not portable.
c2982e87
PE
9129 * process.c (Fmake_network_process): Use pI to avoid cast.
9130 * region-cache.c (pp_cache): Likewise.
9131 * xdisp.c (decode_mode_spec): Likewise.
9132 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9133 behavior on 64-bit hosts with printf arg.
6f04d126 9134 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9135 (x_stop_queuing_selection_requests): Likewise.
9136 (x_get_window_property): Don't truncate byte count to an 'int'
9137 when tracing.
0b432f21 9138
5e073ec7
PE
9139 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9140 here, since it parses constructs like leading '-' and spaces,
9141 which are not wanted; and it overflows with large numbers.
9142 Instead, simply match F[0-9]+, which is what is wanted anyway.
9143
36372bf9
PE
9144 * alloc.c: Remove unportable assumptions about struct layout.
9145 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9146 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9147 (allocate_vectorlike, make_pure_vector): Use the new macros,
9148 plus offsetof, to remove unportable assumptions about struct layout.
9149 These assumptions hold on all porting targets that I know of, but
9150 they are not guaranteed, they're easy to remove, and removing them
9151 makes further changes easier.
9152
0b432f21
PE
9153 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9154 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9155 (string_overrun_cookie): Now const. Use initializers that
9156 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9157 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9158 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9159 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9160 multiple of sizeof (EMACS_INT); it need not be, if
9161 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9162 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9163
895009e1
JB
91642011-04-26 Juanma Barranquero <lekktu@gmail.com>
9165
9166 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9167
6a7a1b0b
TZ
91682011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9169
9170 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9171 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9172 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9173
841a1577 91742011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9175
9176 * lisp.h (Qdebug): List symbol.
895009e1 9177 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9178 * keyboard.c (debug-on-event): New variable.
9179 (handle_user_signal): Break into debugger when debug-on-event
9180 matches the current signal symbol.
9181
f2d3ba6f
DN
91822011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9183
9184 * alloc.c (check_sblock, check_string_bytes)
9185 (check_string_free_list): Convert to standard C.
9186
42ce4c63
TZ
91872011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9188
9189 * w32.c (emacs_gnutls_push): Fix typo.
9190
825cd63c
EZ
91912011-04-25 Eli Zaretskii <eliz@gnu.org>
9192
fb11d64d
EZ
9193 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9194 "cast to pointer from integer of different size".
9195
825cd63c
EZ
9196 Improve doprnt and its use in verror. (Bug#8545)
9197 * doprnt.c (doprnt): Document the set of format control sequences
9198 supported by the function. Use SAFE_ALLOCA instead of always
9199 using `alloca'.
9200
9201 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9202 is one byte too soon. Don't use xrealloc; instead xfree and
9203 xmalloc anew.
9204
e061a11b
TZ
92052011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9206
9207 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9208 callbacks stage.
9209
9210 * gnutls.c: Renamed global_initialized to
9211 gnutls_global_initialized. Added internals for the
9212 :verify-hostname-error, :verify-error, and :verify-flags
9213 parameters of `gnutls-boot' and documented those parameters in the
9214 docstring. Start callback support.
9173deec
JB
9215 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9216 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9217 on error. Return error code.
e061a11b
TZ
9218 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9219 (emacs_gnutls_read): Likewise.
9220 (Fgnutls_boot): Return handshake error code.
9221 (emacs_gnutls_handle_error): New function.
9222 (wsaerror_to_errno): Likewise.
9223
9224 * w32.h (emacs_gnutls_pull): Add prototype.
9225 (emacs_gnutls_push): Likewise.
9226
9227 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9228 (emacs_gnutls_push): Likewise.
9229
92302011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9231
9232 * process.c (wait_reading_process_output): Check if GnuTLS
9233 buffered some data internally if no FDs are set for TLS
9234 connections.
9235
9236 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9237 (LIBS): Link to USER_LIBS.
9238 ($(BLD)/gnutls.$(0)): New target.
9239
fa6996bc
EZ
92402011-04-24 Eli Zaretskii <eliz@gnu.org>
9241
eb35682e
EZ
9242 * xdisp.c (handle_single_display_spec): Rename the
9243 display_replaced_before_p argument into display_replaced_p, to
9244 make it consistent with the commentary. Fix typos in the
9245 commentary.
9246
e2ad650c
EZ
9247 * textprop.c (syms_of_textprop): Remove dead code.
9248 (copy_text_properties): Delete obsolete commentary about an
9249 interface that was deleted long ago. Fix typos in the description
9250 of arguments.
9251
1b2de274
EZ
9252 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9253 to changes in oldXMenu/XMenu.h from 2011-04-16.
9254 <menu_help_message, prev_menu_help_message>: Constify.
9255 (IT_menu_make_room): menu->help_text is now `const char **';
9256 adjust.
9257
9258 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9259 to changes in oldXMenu/XMenu.h from 2011-04-16.
9260 (struct XMenu): Declare `help_text' `const char **'.
9261
9262 * xfaces.c <Qunspecified>: Make extern again.
9263
9264 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9265 required by POSIX.
1b2de274 9266
762b15be
EZ
9267 * doc.c (get_doc_string): Improve the format passed to `error'.
9268
9269 * doprnt.c (doprnt): Improve commentary.
9270
9271 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9272
9273 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9274 them with etags.
9275
f1052e5d
EZ
9276 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9277 changes in globals.h immediately force recompilation.
762b15be
EZ
9278 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9279 $(CURDIR)/s/ms-w32.h.
9280 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9281
fa6996bc
EZ
9282 * character.c (Fchar_direction): Function deleted.
9283 (syms_of_character): Don't defsubr it.
9284 <char-direction-table>: Deleted.
9285
e6c3da20
EZ
92862011-04-23 Eli Zaretskii <eliz@gnu.org>
9287
9288 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9289 * doprnt.c: Include limits.h.
9290 (SIZE_MAX): New macro.
04f2d78b
CB
9291 (doprnt): Return a size_t value. 2nd arg is now size_t.
9292 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9293 Improve overflow protection. Support `l' modifier for integer
9294 conversions. Support %l conversion. Don't assume an EMACS_INT
9295 argument for integer conversions and for %c.
9296
9297 * lisp.h (doprnt): Restore prototype.
9298
9299 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9300 $(SRC)/character.h.
9301
9302 * Makefile.in (base_obj): Add back doprnt.o.
9303
9304 * deps.mk (doprnt.o): Add back prerequisites.
9305 (callint.o): Depend on character.h.
9306
9307 * eval.c (internal_lisp_condition_case): Include the handler
9308 representation in the error message.
9309 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9310 when breaking from the loop.
9311
9312 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9313
9314 * callint.c (Fcall_interactively): When displaying error message
9315 about invalid control letter, pass the character's codepoint, not
9316 a pointer to its multibyte form. Improve display of the character
9317 in octal and display also its hex code.
9318
9319 * character.c (char_string): Use %x to display the (unsigned)
9320 codepoint of an invalid character, to avoid displaying a bogus
9321 negative value.
9322
9323 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9324 `error', not SYMBOL_NAME itself.
9325
9326 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9327 character arguments to `error'.
9328
9329 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9330 to `error' in error message about FINAL_CHAR argument. Make sure
9331 FINAL_CHAR is a character, and use %c when it is passed as
9332 argument to `error'.
9333
4ffd0d6b 93342011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9335
9336 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9337
9338 * w32.c: Include <time.h>.
9339 (sys_localtime): New function.
9340
4ffd0d6b 93412011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9342
9343 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9344
4ffd0d6b 9345 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9346
4ffd0d6b 93472011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9348
4ffd0d6b
GM
9349 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9350 zombies (Bug#8467).
aac0c6e3 9351
04c56954
EZ
93522011-04-19 Eli Zaretskii <eliz@gnu.org>
9353
9354 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9355 gl_state.e_property when gl_state.object is Qt.
9356
9357 * insdel.c (make_gap_larger): Remove limitation of buffer size
9358 to <= INT_MAX.
9359
16a43933
CY
93602011-04-18 Chong Yidong <cyd@stupidchicken.com>
9361
9362 * xdisp.c (lookup_glyphless_char_display)
9363 (produce_glyphless_glyph): Handle cons cell entry in
9364 glyphless-char-display.
9365 (Vglyphless_char_display): Document it.
9366
9367 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9368 glyphless-char-display.
9369
4581706e
CY
93702011-04-17 Chong Yidong <cyd@stupidchicken.com>
9371
9372 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9373
9374 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9375
9376 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9377 definition for no-X builds.
9378
4887c6e2 93792011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9380
fd35b6f9
PE
9381 Static checks with GCC 4.6.0 and non-default toolkits.
9382
5c1ccb01
PE
9383 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9384
006c5daa
PE
9385 * process.c (keyboard_bit_set): Define only if SIGIO.
9386 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9387 (send_process): Repair possible setjmp clobbering.
9388
efc736d3
PE
9389 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9390
4e2fe2e6
PE
9391 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9392
f97334a2
PE
9393 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9394
4e75f29d
PE
9395 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9396 Define only if needed.
9397
90efadd1
PE
9398 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9399 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9400 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9401
3c647824
PE
9402 * dispextern.h (struct redisplay_interface): Rename param
9403 to avoid shadowing.
e264f262 9404 * termhooks.h (struct terminal): Likewise.
761383f4 9405 * xterm.c (xembed_send_message): Likewise.
3c647824 9406
b58c5c4a
PE
9407 * insdel.c (make_gap_smaller): Define only if
9408 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9409
cad59032
PE
9410 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9411 it.
9412
c339dc2e
PE
9413 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9414 so that we aren't warned about unused symbols.
9415
91a3e27b
PE
9416 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9417
399c71d3 9418 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9419
8ffc96f5
PE
9420 * xfns.c (x_real_positions): Mark locals as initialized.
9421
eef9bc79
PE
9422 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9423
098db9dd
PE
9424 * xterm.c: Fix problems found by static analysis with other toolkits.
9425 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9426 (x_dispatch_event): Declare static if USE_GTK, and
9427 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9428 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9429 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9430 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9431 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9432
eb18f6cc
PE
9433 * xmenu.c (menu_help_callback): Pointer type fixes.
9434 Use const pointers when pointing at readonly data. Avoid pointer
9435 signedness clashes.
9436 (FALSE): Remove unused macro.
9437 (update_frame_menubar): Remove unused decl.
9438
1fe72bf8
PE
9439 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9440
60d9e1db
PE
9441 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9442 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9443 (single_menu_item): Rename local to avoid shadowing.
9444
39261c26
PE
9445 * keyboard.c (make_lispy_event): Remove unused local var.
9446
018c5e19
PE
9447 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9448 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9449
63d2b86e
PE
9450 * bitmaps: Change bitmaps from unsigned char back to the X11
9451 compatible char. Avoid the old compiler warnings about
9452 out-of-range initializers by using, for example, '\xab' rather
9453 than 0xab.
9454
aefd87e1
PE
9455 * xgselect.c (xgselect_initialize): Check vs interface
9456 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9457
bf501fb9
PE
9458 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9459
e9829fdf
PE
9460 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9461 to read-only memory.
9462
1086c095
PE
9463 * fns.c (vector): Remove; this old hack is no longer needed.
9464
2baccd04 9465 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9466 Remove unused var.
dde42981 9467 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9468
72391843 9469 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9470
436c16df 9471 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9472 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9473 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9474
92bb796d 9475 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9476 (x_term_init): Remove local to avoid shadowing.
92bb796d 9477
764430a3 9478 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9479
9480 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9481 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9482
d1dfb56c
EZ
94832011-04-16 Eli Zaretskii <eliz@gnu.org>
9484
c4354cb4
EZ
9485 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9486
d1dfb56c
EZ
9487 Fix regex.c, syntax.c and friends for buffers > 2GB.
9488 * syntax.h (struct gl_state_s): Declare character position members
9489 EMACS_INT.
9490
9491 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9492
04f2d78b
CB
9493 * textprop.c (verify_interval_modification, interval_of):
9494 Declare arguments EMACS_INT.
d1dfb56c
EZ
9495
9496 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9497 EMACS_INT.
9498
9499 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9500
9501 * indent.c (Fvertical_motion): Local variable it_start is now
9502 EMACS_INT.
9503
9504 * regex.c (re_match, re_match_2, re_match_2_internal)
9505 (bcmp_translate, regcomp, regexec, print_double_string)
9506 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9507 (re_compile_pattern, re_exec): Declare arguments and local
9508 variables `size_t' and `ssize_t' and return values `regoff_t', as
9509 appropriate.
9510 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9511 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9512 <compile_stack_type>: `size' and `avail' are now `size_t'.
9513
9514 * regex.h <regoff_t>: Use ssize_t, not int.
9515 (re_search, re_search_2, re_match, re_match_2): Arguments that
9516 specify buffer/string position and length are now ssize_t and
9517 size_t. Return type is regoff_t.
9518
613052cd
BK
95192011-04-16 Ben Key <bkey76@gmail.com>
9520
9521 * nsfont.m: Fixed bugs in ns_get_family and
9522 ns_descriptor_to_entity that were caused by using free to
9523 deallocate memory blocks that were allocated by xmalloc (via
9524 xstrdup). This caused Emacs to crash when compiled with
9525 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9526 --enable-checking=xmallocoverrun). xfree is now used to
9527 deallocate these memory blocks.
9528
4170f62f 95292011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9530
71b41406
PE
9531 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9532
9587a89d
PE
9533 emacs_write: Accept and return EMACS_INT for sizes.
9534 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9535 et seq.
9536 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9537 Accept and return EMACS_INT.
9538 (emacs_gnutls_write): Return the number of bytes written on
9539 partial writes.
9540 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9541 (emacs_read, emacs_write): Remove check for negative size, as the
9542 Emacs source code has been audited now.
9587a89d
PE
9543 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9544 (emacs_read, emacs_write): Use it.
273a5f82
PE
9545 * process.c (send_process): Adjust to the new signatures of
9546 emacs_write and emacs_gnutls_write. Do not attempt to store
9547 a byte offset into an 'int'; it might overflow.
9587a89d 9548 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9549
3e047f51
PE
9550 * sound.c: Don't assume sizes fit in 'int'.
9551 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9552 Return EMACS_INT, not int.
3e047f51 9553 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9554 Accept EMACS_INT, not int.
9555 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9556 record read return values.
9557
cc39a9db
BK
95582011-04-15 Ben Key <bkey76@gmail.com>
9559
c9d0ec6d
JB
9560 * keyboard.c (Qundefined): Don't declare static since it is used
9561 in nsfns.m.
9562 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9563 static since they are used in nsfont.m.
cc39a9db 9564
6c60eb9f
SM
95652011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9566
9567 * process.c (Qprocessp): Don't declare static.
9568 * lisp.h (Qprocessp): Declare again.
9569
7990b61a
JB
95702011-04-15 Juanma Barranquero <lekktu@gmail.com>
9571
9572 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9573
5d4cb038
PE
95742011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9575
8bd7b830 9576 Improve C-level modularity by making more things 'static'.
cd64ea1d 9577
e3b27b31
PE
9578 Don't publish debugger-only interfaces to other modules.
9579 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9580 (verify_bytepos, count_markers): Move decls to the only modules
9581 that need them.
9582 * region-cache.h (pp_cache): Likewise.
9583 * window.h (check_all_windows): Likewise.
9584 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9585
5d4cb038
PE
9586 * sysdep.c (croak): Now static, if
9587 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9588 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9589
9590 * alloc.c (refill_memory_reserve): Now static if
9591 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9592 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9593
e87b6180
PE
9594 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9595 Define only if USE_LUCID.
9596
ac64929e
PE
9597 * xrdb.c (x_customization_string, x_rm_string): Now static.
9598
6f37259d
PE
9599 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9600 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9601
1683e3ab
PE
9602 * xdisp.c (draw_row_with_mouse_face): Now static.
9603 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9604
de9c2632
PE
9605 * window.h (check_all_windows): Mark externally visible.
9606
2b96acb7
PE
9607 * window.c (window_deletion_count): Now static.
9608
9609 * undo.c: Make symbols static if they're not exported.
9610 (last_undo_buffer, last_boundary_position, pending_boundary):
9611 Now static.
9612
50436f33
PE
9613 * textprop.c (interval_insert_behind_hooks): Now static.
9614 (interval_insert_in_front_hooks): Likewise.
9615
64520e5c
PE
9616 * term.c: Make symbols static if they're not exported.
9617 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9618 (max_frame_lines, tty_set_terminal_modes):
9619 (tty_reset_terminal_modes, tty_turn_off_highlight):
9620 (get_tty_terminal): Now static.
9621 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9622 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9623 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9624 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9625 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9626
1fa53021
PE
9627 * sysdep.c: Make symbols static if they're not exported.
9628 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9629 Now static.
9630 (sigprocmask_set, full_mask): Remove; unused.
9631 (wait_debugging): Mark as visible.
9632 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9633 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9634
d4b43b22
PE
9635 * syntax.c (syntax_temp): Define only if !__GNUC__.
9636
b7c513d0
PE
9637 * sound.c (current_sound_device, current_sound): Now static.
9638
989b29ad
PE
9639 * search.c (searchbufs, searchbuf_head): Now static.
9640
13a55a78
PE
9641 * scroll.c (scroll_cost): Remove; unused.
9642 * dispextern.h (scroll_cost): Remove decl.
9643
de68a1fc
PE
9644 * region-cache.h (pp_cache): Mark as externally visible.
9645
40ccffa6
PE
9646 * process.c: Make symbols static if they're not exported.
9647 (process_tick, update_tick, create_process, chan_process):
9648 (Vprocess_alist, proc_buffered_char, datagram_access):
9649 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9650 (deactivate_process): Mark defn as static, as well as decl.
9651 * lisp.h (create_process): Remove decl.
9652 * process.h (chan_process, Vprocess_alist): Remove decls.
9653
ad64fc97
PE
9654 * print.c: Make symbols static if they're not exported.
9655 (print_depth, new_backquote_output, being_printed, print_buffer):
9656 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9657 (print_interval, print_number_index, initial_stderr_stream):
9658 Now static.
9659 * lisp.h (Fprinc): Remove decl.
9660 (debug_output_compilation_hack): Mark as externally visible.
9661
adddb265
PE
9662 * sysdep.c (croak): Move decl from here to syssignal.h.
9663 * syssignal.h (croak): Put it here, so the API can be checked when
9664 'croak' is called from dissociate_if_controlling_tty.
9665
1717ede2
PE
9666 * minibuf.c: Make symbols static if they're not exported.
9667 (minibuf_save_list, choose_minibuf_frame): Now static.
9668 * lisp.h (choose_minibuf_frame): Remove decl.
9669
fa5fb2bc
PE
9670 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9671
1e3890d1
PE
9672 * lread.c: Make symbols static if they're not exported.
9673 (read_objects, initial_obarray, oblookup_last_bucket_number):
9674 Now static.
9675 (make_symbol): Remove; unused.
9676 * lisp.h (initial_obarray, make_symbol): Remove decls.
9677
8a1414fa
PE
9678 * keyboard.c: Make symbols static if they're not exported.
9679 (single_kboard, recent_keys_index, total_keys, recent_keys):
9680 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9681 (this_single_command_key_start, echoing, last_auto_save):
9682 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9683 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9684 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9685 (Vlispy_mouse_stem, double_click_count):
9686 Now static.
9687 (force_auto_save_soon): Define only if SIGDANGER.
9688 (ignore_mouse_drag_p): Now static if
9689 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9690 (print_help): Remove; unused.
9691 (stop_character, last_timer_event): Mark as externally visible.
9692 * keyboard.h (ignore_mouse_drag_p): Declare only if
9693 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9694 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9695 * lisp.h (echoing): Remove decl.
9696 (force_auto_save_soon): Declare only if SIGDANGER.
9697 * xdisp.c (redisplay_window): Simplify code, to make it more
9698 obvious that ignore_mouse_drag_p is not accessed if !defined
9699 USE_GTK && !defined HAVE_NS.
9700
93ea6e8f
PE
9701 * intervals.c: Make symbols static if they're not exported.
9702 (merge_properties_sticky, merge_interval_right, delete_interval):
9703 Now static.
9704 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9705
77382fcc
PE
9706 * insdel.c: Make symbols static if they're not exported.
9707 However, leave prepare_to_modify_buffer alone. It's never
9708 called from outside this function, but that appears to be a bug.
9709 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9710 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9711 (adjust_after_replace_noundo): Remove; unused.
9712 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9713 (signal_before_change): Remove decls.
77382fcc 9714
9306c32e
PE
9715 * indent.c (val_compute_motion, val_vmotion): Now static.
9716
cd44d2eb
PE
9717 * image.c: Make symbols static if they're not exported.
9718 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9719 if USE_GTK.
9720 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9721 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9722
ad9a7a06
PE
9723 * fringe.c (standard_bitmaps): Now static.
9724 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9725
81626931
PE
9726 * frame.c: Make symbols static if they're not exported.
9727 (x_report_frame_params, make_terminal_frame): Now static.
9728 (get_frame_param): Now static, unless HAVE_NS.
9729 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9730 (x_get_resource_string): Remove; not used.
9731 * frame.h (make_terminal_frame, x_report_frame_params):
9732 (x_get_resource_string); Remove decls.
9733 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9734 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9735
239f9db9
PE
9736 * font.c, fontset.c: Make symbols static if they're not exported.
9737 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9738 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9739 * font.c (font_close_object): Now static.
9740 * font.h (font_close_object): Remove.
9741 * fontset.c (FONTSET_OBJLIST): Remove.
9742 (free_realized_fontset) #if-0 the body, which does nothing.
9743 (face_suitable_for_char_p): #if-0, as it's never called.
9744 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9745 * xfaces.c (face_at_string_position):
9746 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9747 since 0 is always ASCII.
9748
dfcf3579
PE
9749 * fns.c (weak_hash_tables): Now static.
9750
5045092b
PE
9751 * fileio.c: Make symbols static if they're not exported.
9752 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9753 (Vwrite_region_annotation_buffers): Now static.
9754
57a96f5c
PE
9755 * eval.c: Make symbols static if they're not exported.
9756 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9757 * lisp.h (backtrace_list): Remove decl.
9758
35f08c38
PE
9759 * emacs.c: Make symbols static if they're not exported.
9760 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9761 (fatal_error_code, fatal_error_signal_hook, standard_args):
9762 Now static.
9763 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9764 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9765 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9766 * lisp.h (fatal_error_signal_hook): Remove decl.
9767 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9768
f44bd759
PE
9769 * editfns.c: Move a (normally-unused) function to its only use.
9770 * editfns.c, lisp.h (get_operating_system_release): Remove.
9771 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9772 worth the hassle of breaking this out.
9773
b532497d
PE
9774 * xterm.c: Make symbols static if they're not exported.
9775 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9776 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9777 (x_destroy_window, x_delete_display):
9778 Now static.
9779 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9780 (x_mouse_leave): Remove; unused.
9781 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9782 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9783 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9784 Remove decls.
9785 (x_mouse_leave): Declare only if WINDOWSNT.
9786 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9787 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9788 USE_X_TOOLKIT.
9789
1675728f
PE
9790 * ftxfont.c: Make symbols static if they're not exported.
9791 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9792 HAVE_FREETYPE.
9793 * font.h (ftxfont_driver): Likewise.
9794
e4cebfca
PE
9795 * xfns.c: Make symbols static if they're not exported.
9796 (x_last_font_name, x_display_info_for_name):
9797 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9798 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9799 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9800 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9801 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9802 (last_show_tip_args): Now static.
9803 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9804 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9805 (x_screen_planes): Remove; unused.
9806 * dispextern.h (x_screen_planes): Remove decl.
9807
5bf46f05
PE
9808 * dispnew.c: Make symbols static if they're not exported.
9809 * dispextern.h (redraw_garbaged_frames, scrolling):
9810 (increment_row_positions): Remove.
9811 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9812 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9813 Now static.
9814 (redraw_garbaged_frames): Remove; unused.
9815
435f4c28
PE
9816 * xfaces.c: Make symbols static if they're not exported.
9817 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9818 Remove decls.
9819 * xterm.h (defined_color): Remove decls.
9820 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9821 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9822 (menu_face_changed_default, defined_color, free_realized_face):
9823 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9824 (ascii_face_of_lisp_face): Remove; unused.
9825
8524aef3
PE
9826 * xdisp.c: Make symbols static if they're not exported.
9827 * dispextern.h (scratch_glyph_row, window_box_edges):
9828 (glyph_to_pixel_coords, set_cursor_from_row):
9829 (get_next_display_element, set_iterator_to_next):
9830 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9831 (show_mouse_face): Remove decls
9832 * frame.h (message_buf_print): Likewise.
9833 * lisp.h (pop_message, set_message, check_point_in_composition):
9834 Likewise.
9835 * xterm.h (set_vertical_scroll_bar): Likewise.
9836 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9837 (message_buf_print, scratch_glyph_row, displayed_buffer):
9838 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9839 (get_next_display_element, show_mouse_face, window_box_edges):
9840 (frame_to_window_pixel_xy, check_point_in_composition):
9841 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9842 (glyph_to_pixel_coords): Remove; unused.
9843
16390cd2
PE
9844 * dired.c (file_name_completion): Now static.
9845
9846 * dbusbind.c (xd_in_read_queued_messages): Now static.
9847
a25f4dfa
PE
9848 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9849 * data.c (circular_list_error): Remove.
9850
14a9c8df
PE
9851 * commands.h (last_point_position, last_point_position_buffer):
9852 (last_point_position_window): Remove decls.
9853 * keyboard.c: Make these variables static.
9854
04f2d78b
CB
9855 * coding.h (coding, code_convert_region, encode_coding_gap):
9856 Remove decls.
74ab6df5
PE
9857 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9858 (iso_code_class, detect_coding, code_convert_region): Now static.
9859 (encode_coding_gap): Remove; unused.
9860
38dfbee1
PE
9861 * chartab.c (chartab_chars, chartab_bits): Now static.
9862
a2cb4e63
PE
9863 * charset.h (charset_iso_8859_1): Remove decl.
9864 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9865 Now static.
9866
127198fd
PE
9867 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9868 * ccl.c (Vccl_program_table): Now static.
9869 (check_ccl_update): Remove; unused.
9870
d85b608f
PE
9871 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9872 * category.h: ... from here.
9873 * category.c (check_category_table, set_category_set): Now static.
9874
31cd66f3
PE
9875 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9876 * lisp.h: Remove these decls.
9877
c358e587
PE
9878 * buffer.c (buffer_count): Remove unused var.
9879
e78aecca
PE
9880 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9881 so that it's not optimized away.
9882 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9883 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9884 exported only to the debugger.
9885
e192d7d3 9886 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9887 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9888
92470028
PE
9889 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9890 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9891 was inaccessible from Lisp.
9892 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9893 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9894
244ed907
PE
9895 alloc.c: Import and export fewer symbols, and remove unused items.
9896 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9897 is defined.
9898 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9899 it's not optimized away by whole-program optimization.
9900 (message_enable_multibyte, free_misc): Remove.
9901 (catchlist, handlerlist, mark_backtrace):
9902 Declare only if BYTE_MARK_STACK.
9903 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9904 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9905 (message_enable_multibyte): Remove decl.
9906 (free_misc, interval_free_list, float_block, float_block_index):
9907 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9908 (cons_free_list, last_marked_index):
9909 Now static.
9910 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9911 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9912 (mark_backtrace): Define only if BYTE_MARK_STACK.
9913 * xdisp.c (message_enable_multibyte): Now static.
9914
61c2b50e 9915 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9916 This makes it easier for human readers (and static analyzers)
9917 to see whether these variables are used from other modules.
9918 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9919 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9920 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9921 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9922 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9923 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9924 * xmenu.c, xselect.c:
9925 Declare Q* vars static if they are not used in other modules.
9926 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9927 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9928 Remove decls of unexported vars.
9929 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9930
95c82688
PE
9931 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9932
16a97296
PE
9933 Make Emacs functions such as Fatom 'static' by default.
9934 This makes it easier for human readers (and static analyzers)
9935 to see whether these functions can be called from other modules.
9936 DEFUN now defines a static function. To make the function external
9937 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9938 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9939 (Finit_image_library):
16a97296
PE
9940 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9941 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9942 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9943 Remove decls, since these functions are now static.
9944 (Funintern, Fget_internal_run_time): New decls, since these functions
9945 were already external.
95c82688 9946
16a97296
PE
9947 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9948 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9949 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9950 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9951 * keyboard.c, keymap.c, lread.c:
9952 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9953 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9954 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9955 Mark functions with DEFUE instead of DEFUN,
9956 if they are used in other modules.
9957 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9958 decls for now-static functions.
9959 * buffer.h (Fdelete_overlay): Remove decl.
9960 * callproc.c (Fgetenv_internal): Mark as internal.
9961 * composite.c (Fremove_list_of_text_properties): Remove decl.
9962 (Fcomposition_get_gstring): New forward static decl.
9963 * composite.h (Fcomposite_get_gstring): Remove decl.
9964 * dired.c (Ffile_attributes): New forward static decl.
9965 * doc.c (Fdocumntation_property): New forward static decl.
9966 * eval.c (Ffetch_bytecode): New forward static decl.
9967 (Funintern): Remove extern decl; now in .h file where it belongs.
9968 * fileio.c (Fmake_symbolic_link): New forward static decl.
9969 * image.c (Finit_image_library): New forward static decl.
9970 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9971 * intervals.h (Fprevious_property_change):
9972 (Fremove_list_of_text_properties): Remove decls.
9973 * keyboard.c (Fthis_command_keys): Remove decl.
9974 (Fcommand_execute): New forward static decl.
9975 * keymap.c (Flookup_key): New forward static decl.
9976 (Fcopy_keymap): Now static.
9977 * keymap.h (Flookup_key): Remove decl.
9978 * process.c (Fget_process): New forward static decl.
9979 (Fprocess_datagram_address): Mark as internal.
9980 * syntax.c (Fsyntax_table_p): New forward static decl.
9981 (skip_chars): Remove duplicate decl.
9982 * textprop.c (Fprevious_property_change): New forward static decl.
9983 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9984 Now internal.
9985 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9986 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9987
785bbd42
PE
9988 * editfns.c (Fformat): Remove unreachable code.
9989
8b913b57
AS
99902011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9991
9992 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9993 change. (Bug#8496)
9994
a6744a35
EZ
99952011-04-13 Eli Zaretskii <eliz@gnu.org>
9996
9997 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9998 when at ZV. (Bug#8487)
9999
e7974947
AS
100002011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10001
baad03f0
AS
10002 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10003 (Bug#8437)
10004 * keyboard.c (parse_tool_bar_item): Likewise.
10005 * sound.c (sound_cleanup, alsa_close): Likewise.
10006 * termcap.c (tgetent): Likewise.
10007 * xfns.c (x_default_font_parameter): Likewise.
10008 * xsettings.c (read_and_apply_settings): Likewise.
10009
e7974947
AS
10010 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10011 (overrun_check_free): Protoize.
10012
28272684
PE
100132011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10014
10015 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10016 since callers should never pass a negative size.
10017 Change the signature to match that of plain 'read' and 'write'; see
10018 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10019 * lisp.h: Update prototypes of emacs_write and emacs_read.
10020
11997c76
EZ
100212011-04-11 Eli Zaretskii <eliz@gnu.org>
10022
10023 * xdisp.c (redisplay_window): Don't try to determine the character
10024 position of the scroll margin if the window start point w->startp
e896f03c 10025 is outside the buffer's accessible region. (Bug#8468)
11997c76 10026
8a2cbd72
EZ
100272011-04-10 Eli Zaretskii <eliz@gnu.org>
10028
10029 Fix write-region and its subroutines for buffers > 2GB.
10030 * fileio.c (a_write, e_write): Modify declaration of arguments and
10031 local variables to support buffers larger than 2GB.
10032 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10033
10034 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10035 argument, local variables, and return value.
10036
10037 * lisp.h: Update prototypes of emacs_write and emacs_read.
10038
10039 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10040
4073e537 100412011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10042
1ebfdcb6
PE
10043 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10044
b2ded58d
PE
10045 Fix more problems found by GCC 4.6.0's static checks.
10046
7d66342c
PE
10047 * xdisp.c (vmessage): Use a better test for character truncation.
10048
bbf47d44
PE
10049 * charset.c (load_charset_map): <, not <=, for optimization,
10050 and to avoid potential problems with integer overflow.
9248994d 10051 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10052 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10053 * editfns.c (Fformat): Likewise.
1e69125e 10054 * syntax.c (skip_chars): Likewise.
3befa583 10055
e3019616
PE
10056 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10057 This also lets GCC 4.6.0 generate slightly better loop code.
10058
becfa255
PE
10059 * callint.c (Fcall_interactively): <, not <=, for optimization.
10060 (Fcall_interactively): Count the number of arguments produced,
10061 not the number of arguments given. This is simpler and lets GCC
10062 4.6.0 generate slightly better code.
10063
dae0cd48
PE
10064 * ftfont.c: Distingish more carefully between FcChar8 and char.
10065 The previous code passed unsigned char * to a functions like
10066 strlen and xstrcasecmp that expect char *, which does not
10067 conform to the C standard.
10068 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10069 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10070 char * when the C standard requires it.
10071
76032d70
PE
10072 * keyboard.c (read_char): Remove unused var.
10073
eb3f1cc8
PE
10074 * eval.c: Port to Windows vsnprintf (Bug#8435).
10075 Include <limits.h>.
10076 (SIZE_MAX): Define if the headers do not.
10077 (verror): Do not give up if vsnprintf returns a negative count.
10078 Instead, grow the buffer. This ports to Windows vsnprintf, which
10079 does not conform to C99. Problem reported by Eli Zaretskii.
10080 Also, simplify the allocation scheme, by avoiding the need for
10081 calling realloc, and removing the ALLOCATED variable.
10082
70476b54
PE
10083 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10084
12020a9e
PE
10085 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10086 But keep the doprint source code for now, as we might revamp it
10087 and use it again (Bug#8435).
ea6c7ae6
PE
10088 * lisp.h (doprnt): Remove.
10089 * Makefile.in (base_obj): Remove doprnt.o.
10090 * deps.mk (doprnt.o): Remove.
10091
5fdb398c
PE
10092 error: Print 32- and 64-bit integers portably (Bug#8435).
10093 Without this change, on typical 64-bit hosts error ("...%d...", N)
10094 was used to print both 32- and 64-bit integers N, which relied on
10095 undefined behavior.
61bdb816 10096 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10097 * lisp.h (error, verror): Mark as printf-like functions.
10098 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10099 Report overflow in size calculations when allocating printf buffer.
10100 Do not truncate output string at its first null byte.
10101 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10102 Truncate the output at a character boundary, since vsnprintf does not
10103 do that.
10104 * charset.c (check_iso_charset_parameter): Convert internal
10105 character to string before calling 'error', since %c now has the
10106 printf meaning.
10107 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10108 overflow when computing char to be passed to 'error'. Do not
10109 pass Lisp_Object to 'error'; pass the integer instead.
10110 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10111 formatted with plain %d.
10112
b189fa66
PE
10113 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10114
bff87ef0
PE
10115 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10116
7e2cac20
PE
10117 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10118
ce4d90b5
PE
10119 * xterm.c (x_catch_errors): Remove duplicate declaration.
10120
266c9547
PE
10121 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10122
79c49ad2
PE
10123 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10124
368f4090
JM
101252011-04-10 Jim Meyering <meyering@redhat.com>
10126
10127 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10128 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10129 return ssize_t not "int", and use size_t as the buffer length.
10130 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10131 * gnutls.h: Update declarations.
10132 * process.c (read_process_output): Use ssize_t, to match.
10133 (send_process): Likewise.
10134
a32d4040
CY
101352011-04-09 Chong Yidong <cyd@stupidchicken.com>
10136
10137 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10138
8546720e 101392011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10140
04f2d78b
CB
10141 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10142 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10143
8546720e
GM
10144 * xterm.c (handle_one_xevent):
10145 * xmenu.c (create_and_show_popup_menu):
10146 * xselect.c (x_decline_selection_request)
10147 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10148
0a2f5c1a 101492011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10150
10151 Fix some uses of `int' instead of EMACS_INT.
10152 * search.c (string_match_1, fast_string_match)
10153 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10154 (scan_buffer, find_next_newline_no_quit)
10155 (find_before_next_newline, search_command, Freplace_match)
10156 (Fmatch_data): Make some `int' variables be EMACS_INT.
10157
10158 * xdisp.c (display_count_lines): 3rd argument and return value now
10159 EMACS_INT. All callers changed.
10160 (pint2hrstr): Last argument is now EMACS_INT.
10161
10162 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10163 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10164 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10165 (decode_coding_utf_16, decode_coding_emacs_mule)
10166 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10167 (decode_coding_ccl, decode_coding_charset)
10168 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10169 (decode_coding_iso_2022, decode_coding_emacs_mule)
10170 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10171 <char_offset, last_offset>: Declare EMACS_INT.
10172 (encode_coding_utf_8, encode_coding_utf_16)
10173 (encode_coding_emacs_mule, encode_invocation_designation)
10174 (encode_designation_at_bol, encode_coding_iso_2022)
10175 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10176 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10177 Declare EMACS_INT.
10178 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10179 (encode_invocation_designation): Last argument P_NCHARS is now
10180 EMACS_INT.
10181 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10182 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10183
10184 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10185 All users changed.
10186
10187 * ccl.c (Fccl_execute_on_string): Declare some variables
10188 EMACS_INT.
10189
8546720e 101902011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10191
10192 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10193
4e19a977
CS
101942011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10195
10196 * process.c (Fformat_network_address): Doc fix.
10197
87302331
R
101982011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10199
ee7683eb 10200 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10201
cbb59342
CY
102022011-04-08 Chong Yidong <cyd@stupidchicken.com>
10203
10204 * keyboard.c (read_char): Call Lisp function help-form-show,
10205 instead of using internal_with_output_to_temp_buffer.
10206 (Qhelp_form_show): New var.
e0d38eeb 10207 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10208
10209 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10210
10211 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10212
e67a13ab
CY
102132011-04-06 Chong Yidong <cyd@stupidchicken.com>
10214
04f2d78b
CB
10215 * process.c (Flist_processes): Remove to Lisp.
10216 (list_processes_1): Delete.
e67a13ab 10217
973f782d
EZ
102182011-04-06 Eli Zaretskii <eliz@gnu.org>
10219
7c106b1e
EZ
10220 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10221
973f782d
EZ
10222 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10223
41cf7d1a 102242011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10225
ca23cc88
PE
10226 Fix more problems found by GCC 4.6.0's static checks.
10227
f390e2d5
PE
10228 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10229
42eea0d0
PE
10230 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10231
b69769da 10232 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10233
f9541e84
PE
10234 * xdisp.c (vmessage): Mark as a printf-like function.
10235
13841b55
PE
10236 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10237
c136c10f
PE
10238 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10239
5e2d4a30
PE
10240 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10241 printf-like functions.
10242 (tiff_load): Add casts to remove these marks before passing them
10243 to system-supplied API.
10244
583f48b9
PE
10245 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10246
b25d760e
PE
10247 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10248 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10249 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10250 directly, rather than having caller test rule sign. This avoids
10251 some unnecessary tests.
10252 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10253 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10254 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10255
bc7b6697 10256 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10257 (xfont_open): Avoid unnecessary tests.
bc7b6697 10258
27ccc379
PE
10259 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10260
dcd5c89a
PE
10261 * composite.h, composite.c (composition_gstring_put_cache):
10262 Use EMACS_INT, not int, for length.
10263
b13a45c6
PE
10264 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10265 breaking out part of COMPOSITION_DECODE_RULE.
10266 (COMPOSITION_DECODE_RULE): Use it.
10267 * composite.c (get_composition_id): Remove unused local vars,
10268 by using the new macro.
10269
1e792e4d
PE
10270 * textprop.c (set_text_properties_1): Change while to do-while,
10271 since the condition is always true at first.
10272
dc6c6455 10273 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10274 (interval_deletion_adjustment): Return unsigned value.
10275 All uses changed.
dc6c6455 10276
aba7731a
PE
10277 * process.c (list_processes_1, create_pty, read_process_output):
10278 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10279 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10280 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10281 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10282 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10283
fdfc4bf3
PE
10284 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10285
fca8fe46 10286 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10287 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10288
06a0259a 10289 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10290 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10291 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10292
e7b9e80f
PE
10293 * print.c (print_error_message): Avoid int overflow.
10294
56201685
PE
10295 * font.c (font_list_entities): Redo for clarity,
10296 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10297
78834453 10298 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10299 (font_score): Avoid potential overflow in diff calculation.
78834453 10300
0bc0b309 10301 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10302 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10303
e610eaca
PE
10304 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10305
b895abce
PE
10306 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10307 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10308 can always succeed if overflow has undefined behavior.
10309
1f1d9321 10310 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10311 (wordify): Omit three unnecessary tests.
1f1d9321 10312
c59478bc
PE
10313 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10314 All callers changed. This avoids the need for an unused var.
10315
79b73827
PE
10316 * casefiddle.c (casify_region): Remove var that is set but not used.
10317
a4db5dfe
PE
10318 * dired.c (file_name_completion): Remove var that is set but not used.
10319
43aae36e
PE
10320 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10321
2a47c44d 10322 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10323 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10324
a37c69bf
PE
10325 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10326 Check for integer overflow on size calculations.
10327
328ab8e7
PE
10328 * buffer.c (Fprevious_overlay_change): Remove var that is set
10329 but not used.
10330
e5a2a5cb
PE
10331 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10332 Remove vars that are set but not used.
8d84a6eb 10333 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10334 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10335
a60e5f68
PE
10336 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10337
f661cb61 10338 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10339 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10340
f0397f5a
PE
10341 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10342 that are set but not used.
10343
8664db06 10344 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10345 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10346
6abdaa4a
PE
10347 * xselect.c (x_get_local_selection, x_handle_property_notify):
10348 Remove vars that are set but not used.
10349
0ce7538d 10350 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10351 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10352
9ae848fc
PE
10353 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10354 Remove var that is set but not used.
0b918413
PE
10355 (scroll_bar_windows_size): Now size_t, not int.
10356 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10357 Check for overflow.
9ae848fc 10358
a5a62657
PE
10359 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10360 (map_tty_color) [!defined MSDOS]: Likewise.
10361
5c5cdd39
PE
10362 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10363
66ebf983
PE
10364 * coding.c: Remove vars that are set but not used.
10365 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10366 All callers changed.
10367 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10368 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10369 (decode_coding_charset): Remove vars that are set but not used.
10370
1be4d761
PE
10371 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10372 that is set but not used.
10373
47553fa8
PE
10374 * print.c (print_object): Remove var that is set but not used.
10375
1f7196bf 10376 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10377 The gnulib version avoids calling malloc in the usual case,
10378 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10379 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10380 * filelock.c (current_lock_owner): Likewise.
10381 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10382 * sysdep.c: Include allocator.h, careadlinkat.h.
10383 (emacs_no_realloc_allocator): New static constant.
10384 (emacs_readlink): New function.
fdb61804
PE
10385 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10386 ../lib/careadlinkat.h.
d1fdcab7 10387
f84c17c7
SM
103882011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10389
10390 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10391 first non-nil return value).
10392
ef3862ad
JD
103932011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10394
10395 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10396 if not defined (Bug#8403).
10397
376a7006
JB
103982011-04-02 Juanma Barranquero <lekktu@gmail.com>
10399
10400 * xdisp.c (display_count_lines): Remove parameter `start',
10401 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10402 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10403 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10404 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10405 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10406 and thereabouts. All callers changed.
10407 (get_per_char_metric): Remove parameter `f', unused since
10408 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10409
6ca3801d
JM
104102011-04-02 Jim Meyering <meyering@redhat.com>
10411
10412 do not dereference NULL upon failed strdup
10413 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10414 (ns_get_family): Likewise.
10415
d8e2b5ba
JB
104162011-04-02 Juanma Barranquero <lekktu@gmail.com>
10417
10418 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10419
8c74fcbd
JD
104202011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10421
10422 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10423 later (Bug#8403).
10424
7200d79c
SM
104252011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10426
03408648 10427 Add lexical binding.
7200d79c 10428
03408648
SM
10429 * window.c (Ftemp_output_buffer_show): New fun.
10430 (Fsave_window_excursion):
10431 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10432
10433 * lread.c (lisp_file_lexically_bound_p): New function.
10434 (Fload): Bind Qlexical_binding.
10435 (readevalloop): Remove `evalfun' arg.
10436 Bind Qinternal_interpreter_environment.
10437 (Feval_buffer): Bind Qlexical_binding.
10438 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10439 Mark as dynamic.
10440 (syms_of_lread): Declare `lexical-binding'.
10441
10442 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10443
10444 * keyboard.c (eval_dyn): New fun.
10445 (menu_item_eval_property): Use it.
ca105506
SM
10446
10447 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10448
03408648
SM
10449 * fns.c (concat, mapcar1): Accept byte-code-functions.
10450
10451 * eval.c (Fsetq): Handle lexical vars.
10452 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10453 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10454 (FletX, Flet): Obey lexical binding.
10455 (Fcommandp): Handle closures.
10456 (Feval): New `lexical' arg.
10457 (eval_sub): New function extracted from Feval. Use it almost
10458 everywhere where Feval was used. Look up vars in lexical env.
10459 Handle closures.
10460 (Ffunctionp): Move from subr.el.
10461 (Ffuncall): Handle closures.
10462 (apply_lambda): Remove `eval_flags'.
10463 (funcall_lambda): Handle closures and new byte-code-functions.
10464 (Fspecial_variable_p): New function.
10465 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10466 but without exporting it to Lisp.
23aba0ea 10467
23aba0ea 10468 * doc.c (Fdocumentation, store_function_docstring):
03408648 10469 * data.c (Finteractive_form): Handle closures.
23aba0ea 10470
03408648
SM
10471 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10472 interactive spec.
ba83908c 10473
04f2d78b
CB
10474 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10475 New byte-codes.
03408648
SM
10476 (exec_byte_code): New function extracted from Fbyte_code to handle new
10477 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10478
03408648 10479 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10480
03408648 10481 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10482
e2abce01
JB
104832011-03-31 Juanma Barranquero <lekktu@gmail.com>
10484
10485 * xdisp.c (redisplay_internal): Fix prototype.
10486
63696a73 104872011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10488
63696a73 10489 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10490 (try_scrolling): Use it when setting scroll_limit.
10491 Limit scrolling to 100 screen lines.
63696a73
EZ
10492 (redisplay_window): Even when falling back on "recentering",
10493 position point in the window according to scroll-conservatively,
10494 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10495
10496 (try_scrolling): When point is above the window, allow searching
10497 as far as scroll_max, or one screenful, to compute vertical
10498 distance from PT to the scroll margin position. This prevents
10499 try_scrolling from unnecessarily failing when
10500 scroll-conservatively is set to a value slightly larger than the
10501 window height. Clean up the case of PT below the margin at bottom
10502 of window: scroll_max can no longer be INT_MAX. When aggressive
10503 scrolling is in use, don't let point enter the opposite scroll
10504 margin as result of the scroll.
10505 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10506 threshold of 100 lines for never-recentering scrolling.
10507
e4cc2dfc
JB
105082011-03-31 Juanma Barranquero <lekktu@gmail.com>
10509
10510 * dispextern.h (move_it_by_lines):
10511 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10512 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10513 (message_log_check_duplicate): Remove parameters `prev_bol' and
10514 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10515 (redisplay_internal): Remove parameter `preserve_echo_area',
10516 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10517
10518 * indent.c (Fvertical_motion):
10519 * window.c (window_scroll_pixel_based, Frecenter):
10520 Don't pass `need_y_p' to `move_it_by_lines'.
10521
1c470562
SM
105222011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10523
44f230aa
SM
10524 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10525 steal a few bits to be more compact.
10526 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10527 Remove unneeded casts.
10528
1c470562
SM
10529 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10530
888adce9
ZK
105312011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10532
10533 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10534 binding" message (bug#7967).
10535
f838ed7b
PE
105362011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10537
77861b95
PE
10538 Fix more problems found by GCC 4.6.0's static checks.
10539
de6dbc14
PE
10540 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10541 Remove unused local var.
10542
f838ed7b
PE
10543 * editfns.c (Fmessage_box): Remove unused local var.
10544
792c7b2b
PE
10545 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10546 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10547 Omit unused local vars.
c499e557 10548 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10549 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10550 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10551 Omit unused local var.
10552
ba0165e1
PE
10553 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10554 Don't assume string length fits in int.
32ad8845 10555 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10556 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10557
3c59b4c9
PE
10558 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10559 instead of alloca (Bug#8344).
10560
a3eed478 10561 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10562 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10563
eb4d412d
PE
10564 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10565
1658b401
PE
10566 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10567 concerns.
10568
10569 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10570
10571 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10572
9a2c6e05
PE
10573 * keyboard.c (syms_of_keyboard): Use the same style as later
10574 in this function when indexing through an array. This also
10575 works around GCC bug 48267.
10576
03d0a109
PE
10577 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10578
44f730c8
PE
10579 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10580
fe75f926
PE
10581 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10582 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10583
ffa8c828
PE
10584 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10585 This avoids undefined behavior on integer overflow, and is a bit
10586 more convenient anyway since it is compared to a size_t variable.
10587
c5101a77
PE
10588 Variadic C functions now count arguments with size_t, not int.
10589 This avoids an unnecessary limitation on 64-bit machines, which
10590 caused (substring ...) to crash on large vectors (Bug#8344).
10591 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10592 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10593 All variadic functions and their callers changed accordingly.
c5101a77
PE
10594 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10595 * data.c (arith_driver, float_arith_driver): Likewise.
10596 * editfns.c (general_insert_function): Likewise.
10597 * eval.c (struct backtrace.nargs, interactive_p)
10598 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10599 (funcall_lambda, mark_backtrace): Likewise.
10600 * fns.c (concat): Likewise.
10601 * frame.c (x_set_frame_parameters): Likewise.
10602 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10603 0 if not found, not -1. All callers changed.
10604
dd3f25f7
PE
10605 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10606 (stack_copy_size): Now size_t, not int.
10607 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10608
461c2ab9
JB
106092011-03-28 Juanma Barranquero <lekktu@gmail.com>
10610
10611 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10612 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10613 All callers changed.
10614
10615 * lisp.h (multibyte_char_to_unibyte):
10616 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10617 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10618 * character.h (CHAR_TO_BYTE8):
10619 * cmds.c (internal_self_insert):
10620 * editfns.c (general_insert_function):
10621 * keymap.c (push_key_description):
10622 * search.c (Freplace_match):
10623 * xdisp.c (message_dolog, set_message_1): All callers changed.
10624
f6d62986
SM
106252011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10626
10627 * keyboard.c (safe_run_hook_funcall): New function.
10628 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10629 don't set the hook to nil, but remove the offending function instead.
10630 (Qcommand_hook_internal): Remove, unused.
10631 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10632 Vcommand_hook_internal.
10633
10634 * eval.c (enum run_hooks_condition): Remove.
10635 (funcall_nil, funcall_not): New functions.
10636 (run_hook_with_args): Call each function through a `funcall' argument.
10637 Remove `cond' argument, now redundant.
10638 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10639 (Frun_hook_with_args_until_failure): Adjust accordingly.
10640 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10641
1db5b1ad
JB
106422011-03-28 Juanma Barranquero <lekktu@gmail.com>
10643
10644 * dispextern.h (string_buffer_position): Remove declaration.
10645
10646 * print.c (strout): Remove parameter `multibyte', unused since
10647 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10648
10649 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10650 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10651 All callers changed.
10652
10653 * w32.c (_wsa_errlist): Use braces for struct initializers.
10654
10655 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10656 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10657 All callers changed.
10658 (string_buffer_position): Likewise. Also, make static (it's never
10659 used outside xdisp.c).
10660 (cursor_row_p): Remove parameter `w', unused since
10661 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10662 (decode_mode_spec): Remove parameter `precision', introduced during
10663 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10664 All callers changed.
10665
5ffb62aa
JD
106662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10667
10668 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10669
461c2ab9 106702011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10671
10672 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10673 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10674 (ns_update_auto_hide_menu_bar): New functions.
10675 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10676 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10677 ns_constrain_all_frames.
10678 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10679 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10680
5c380ffb
JD
106812011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10682
10683 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10684
9af30bdf
GM
106852011-03-27 Glenn Morris <rgm@gnu.org>
10686
10687 * syssignal.h: Replace RETSIGTYPE with void.
10688 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10689 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10690 Replace SIGTYPE with void everywhere.
10691 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10692 * s/template.h (SIGTYPE): Remove commented out definition.
10693
e2abce01
JB
106942011-03-26 Eli Zaretskii <eliz@gnu.org>
10695
10696 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10697 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10698
f868cd8a
JB
106992011-03-26 Juanma Barranquero <lekktu@gmail.com>
10700
59eb0929
JB
10701 * w32.c (read_unc_volume): Use parameter `henum', instead of
10702 global variable `wget_enum_handle'.
10703
10704 * keymap.c (describe_vector): Remove parameters `indices' and
10705 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10706 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10707
f868cd8a
JB
10708 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10709
10710 * keyboard.c (timer_check): Remove parameter `do_it_now',
10711 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10712 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10713 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10714
10715 * keyboard.c (read_char):
10716 * w32menu.c (w32_menu_display_help):
10717 * xmenu.c (show_help_event, menu_help_callback):
10718 Adjust calls to `show_help_echo'.
10719
10720 * gtkutil.c (xg_maybe_add_timer):
10721 * keyboard.c (readable_events):
10722 * process.c (wait_reading_process_output):
10723 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10724
10725 * insdel.c (adjust_markers_gap_motion):
10726 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10727 (gap_left, gap_right): Don't call it.
10728
2ecf6fdb
CY
107292011-03-25 Chong Yidong <cyd@stupidchicken.com>
10730
10731 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10732 incurred during fontification.
10733
6b1f9ba4
JB
107342011-03-25 Juanma Barranquero <lekktu@gmail.com>
10735
10736 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10737 (DEFVAR_PER_BUFFER): Don't pass it.
10738
10739 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10740 (scrolling_window): Don't pass it.
10741
0f4a96b5
JB
107422011-03-25 Juanma Barranquero <lekktu@gmail.com>
10743
10744 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10745
10746 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10747 and `suffix'.
10748 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10749 of variables specific to SELinux and computation of `encoded_absname'.
10750
10751 * image.c (XPutPixel): Remove unused variable `height'.
10752
10753 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10754
10755 * unexw32.c (get_section_info): Remove unused variable `section'.
10756
10757 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10758 (system_process_attributes): Remove unused variable `sess'.
10759 (sys_read): Remove unused variable `err'.
10760
10761 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10762 (w32_wnd_proc): Remove unused variable `isdead'.
10763 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10764 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10765 (x_create_tip_frame): Remove unused variable `tem'.
10766
10767 * w32inevt.c (w32_console_read_socket):
10768 Remove unused variable `no_events'.
10769
10770 * w32term.c (x_draw_composite_glyph_string_foreground):
10771 Remove unused variable `width'.
10772
1149507c
JB
107732011-03-24 Juanma Barranquero <lekktu@gmail.com>
10774
10775 * w32term.c (x_set_glyph_string_clipping):
10776 Don't pass uninitialized region to CombineRgn.
10777
9c88f339
JB
107782011-03-23 Juanma Barranquero <lekktu@gmail.com>
10779
10780 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10781 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10782 (Fx_close_connection): Remove unused variable `i'.
10783
10784 * w32font.c (w32font_draw): Return number of glyphs.
10785 (w32font_open_internal): Remove unused variable `i'.
10786 (w32font_driver): Add missing initializer.
10787
10788 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10789 (fill_in_menu): Remove unused variable `items_added'.
10790
10791 * w32term.c (last_mouse_press_frame): Remove static global variable.
10792 (w32_clip_to_row): Remove unused variable `f'.
10793 (x_delete_terminal): Remove unused variable `i'.
10794
10795 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10796 (NOTHING): Remove unused static global variable.
10797 (uniscribe_check_otf): Remove unused variable `table'.
10798 (uniscribe_font_driver): Add missing initializers.
10799
dee091a3
JD
108002011-03-23 Julien Danjou <julien@danjou.info>
10801
10802 * term.c (Fsuspend_tty, Fresume_tty):
10803 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10804 * window.c (temp_output_buffer_show):
10805 * insdel.c (signal_before_change):
10806 * frame.c (Fhandle_switch_frame):
10807 * fileio.c (Fdo_auto_save):
10808 * emacs.c (Fkill_emacs):
10809 * editfns.c (save_excursion_restore):
10810 * cmds.c (internal_self_insert):
10811 * callint.c (Fcall_interactively):
10812 * buffer.c (Fkill_all_local_variables):
10813 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10814 Use Frun_hooks.
0f4a96b5 10815 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10816 unconditionally since it does the check itself.
dee091a3 10817
2c520ab5 108182011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10819
c9c49752
PE
10820 Fix more problems found by GCC 4.5.2's static checks.
10821
8abc3f12
PE
10822 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10823 the first time through the loop, since we know p0 < p1 then.
10824 This also avoids a gcc -Wstrict-overflow warning.
10825
a2d26660
PE
10826 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10827 leading to a memory leak, possible in functions like
10828 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10829 of objects (Bug#8318).
a2d26660 10830
916c72e9
PE
10831 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10832 that could (at least in theory) be that large.
10833
19ab8a18
PE
10834 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10835 This is less likely to overflow, and avoids undefined behavior if
10836 overflow does occur. All callers changed. Use strtoul to scan
10837 for the unsigned long integer.
b7cbbd6f
PE
10838 (pint2hrstr): Simplify and tune code slightly.
10839 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10840
f0641eff
PE
10841 * scroll.c (do_scrolling): Work around GCC bug 48228.
10842 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10843
7f650bb9
PE
10844 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10845 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10846 (validate_x_resource_name): Simplify count usage.
10847 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10848
37dd57d1
PE
10849 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10850 fail (Bug#8306).
81e56e61 10851
699979fc 10852 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10853
401bf9b4
PE
10854 * process.c (Fmake_network_process): Use socklen_t, not int,
10855 where POSIX says socklen_t is required in portable programs.
10856 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10857 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10858 (Fmake_network_process, server_accept_connection):
10859 (wait_reading_process_output, read_process_output):
10860 Likewise.
10861
b93aacde
PE
10862 * process.c: Rename or move locals to avoid shadowing.
10863 (list_processes_1, Fmake_network_process):
10864 (read_process_output_error_handler, exec_sentinel_error_handler):
10865 Rename or move locals.
4dc343ee 10866 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10867 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10868 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10869 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10870 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10871
af8a867c 10872 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10873 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10874 Include tparam.h instead, since it declares them.
af8a867c
PE
10875 * cm.h (PC): Remove extern decl; tparam.h now does this.
10876 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10877 * terminfo.c: Include tparam.h, to check interfaces.
10878 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10879 (tparam): Adjust signature to match interface in tparam.h;
10880 this removes some undefined behavior. Check that outstring and len
10881 are zero, which they always are with Emacs.
10882 * tparam.h (PC, BC, UP): New extern decls.
10883
0248044d 10884 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10885 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10886
8ff096c1 10887 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10888 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10889 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10890 (ftfont_list): Remove unused local.
49eaafba
PE
10891 (get_adstyle_property, ftfont_pattern_entity):
10892 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10893 Rename locals to avoid shadowing.
8ff096c1 10894
e2be39f6
PE
10895 * xfont.c (xfont_list_family): Mark var as initialized.
10896
c9735e30
PE
10897 * xml.c (make_dom): Now static.
10898
8f5201ae
PE
10899 * composite.c (composition_compute_stop_pos): Rename local to
10900 avoid shadowing.
b246f932
PE
10901 (composition_reseat_it): Remove unused locals.
10902 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10903 (composition_update_it): Mark var as initialized.
11b61122
PE
10904 (find_automatic_composition): Mark vars as initialized,
10905 with a FIXME (Bug#8290).
8f5201ae 10906
760fbc2c
PE
10907 character.h: Rename locals to avoid shadowing.
10908 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10909 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10910 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10911 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10912 to avoid shadowing.
10913
ff08eb85
PE
10914 * textprop.c (property_change_between_p): Remove; unused.
10915
fc7bf025
PE
10916 * intervals.c (interval_start_pos): Now static.
10917
235d7abc
PE
10918 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10919
44f230aa
SM
10920 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10921 Rename locals to avoid shadowing.
3e7d6594 10922
50060332
PE
10923 * sound.c (wav_play, au_play, Fplay_sound_internal):
10924 Fix pointer signedness.
d01f234b 10925 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10926 (wav_play): Initialize a variable to 0, to prevent undefined
10927 behavior (Bug#8278).
50060332 10928
c4fc4e30
PE
10929 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10930
918436ed
PE
10931 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10932
c939f91b
PE
10933 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10934 clobbering (Bug#8298).
b9c7f648
PE
10935 * sysdep.c (sys_subshell): Likewise.
10936 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10937
6bd8c144
PE
10938 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10939 This should get cleaned up, so that child_setup has the
10940 same signature on all platforms.
10941
7710357c 10942 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10943 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10944
c59da222
CY
109452011-03-22 Chong Yidong <cyd@stupidchicken.com>
10946
10947 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10948 not to be necessary, and produces flickering.
10949
66b87493
GM
109502011-03-20 Glenn Morris <rgm@gnu.org>
10951
10952 * config.in: Remove file.
10953
45b6f6d5
JB
109542011-03-20 Juanma Barranquero <lekktu@gmail.com>
10955
10956 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10957 are now in src/globals.h.
10958 (syms_of_minibuf): Remove spurious & from previous change.
10959
cd394be1 109602011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10961
10962 * minibuf.c (completing-read-function): New variable.
10963 (completing-read-default): Rename from completing-read.
10964 (completing-read): Call completing-read-function.
10965
b14e3e21
CY
109662011-03-19 Juanma Barranquero <lekktu@gmail.com>
10967
10968 * xfaces.c (Fx_load_color_file):
10969 Read color file from absolute filename (bug#8250).
10970
f2b726e6
JB
109712011-03-19 Juanma Barranquero <lekktu@gmail.com>
10972
10973 * makefile.w32-in: Update dependencies.
10974
09f6ff02
EZ
109752011-03-17 Eli Zaretskii <eliz@gnu.org>
10976
10977 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10978
29a6015a
PE
109792011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10980
a3a6c54e
PE
10981 Fix more problems found by GCC 4.5.2's static checks.
10982
b766f867
PE
10983 * process.c (make_serial_process_unwind, send_process_trap):
10984 (sigchld_handler): Now static.
10985
be02381c
PE
10986 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10987 That way, the code declares only the vars that it needs.
10988 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10989 * s/cygwin.h (PTY_ITERATION): Likewise.
10990 * s/darwin.h (PTY_ITERATION): Likewise.
10991 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10992
57048744
PE
10993 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10994 * process.c (allocate_pty): Don't declare stb unless it's needed.
10995
7914961c 10996 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10997 (CONSTANTLIM): Remove; unused.
10998 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10999 Define only if needed.
7914961c 11000
b3967b18
PE
11001 * unexelf.c (unexec): Name an expression,
11002 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11003 Use a different way to cause a compilation error if anyone uses
11004 n rather than nn, a way that does not involve shadowing.
73366a00 11005 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11006
29a6015a
PE
11007 * deps.mk (unexalpha.o): Remove; unused.
11008
43cfc33e 11009 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11010 * unexec.h: New file.
ce701a33
PE
11011 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11012 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11013 Depend on unexec.h.
11014 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11015 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11016 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11017 Change as necessary to match prototype in unexec.h.
ce701a33 11018
01f44d5a
PE
11019 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11020 shadowing.
4f63c6bb 11021 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11022
a6670b0b
PE
11023 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11024 Rename locals to avoid shadowing.
11025
cef2010d 11026 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11027 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11028
d4d7173a
PE
11029 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11030
f08b802a
PE
11031 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11032 warning when compiling print.c.
11033
3ddb0639
PE
11034 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11035 instead of using an uninitialized var.
5ad03b97 11036 (font_sort_entities): Mark var as initialized.
3ddb0639 11037
170a2692
PE
11038 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11039
e663c700
PE
11040 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11041 pointers to constants.
89bc529a 11042 (font_parse_fcname): Remove unused vars.
7b81e2d0 11043 (font_delete_unmatched): Now static.
ea838e10 11044 (font_get_spec): Remove; unused.
13a547c6
PE
11045 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11046 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11047 Rename or move locals to avoid shadowing.
e663c700 11048
2a80c887 11049 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11050 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11051
1384fa33 11052 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11053 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11054
8b2c52e9
PE
11055 * alloc.c (mark_backtrace): Move decl from here ...
11056 * lisp.h: ... to here, so that it can be checked.
11057
475545b5 11058 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11059 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11060 (lisp_indirect_variable): Name an expression,
11061 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11062 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11063
b1349114 11064 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11065 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11066 Use const pointer when appropriate.
b1349114 11067
a2928364
PE
11068 * lisp.h (get_system_name, get_operating_system_release):
11069 Move decls here, to check interfaces.
11070 * process.c (get_operating_system_release): Move decl to lisp.h.
11071 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11072 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11073 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11074 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11075 (Fformat_time_string, Fencode_time, Finsert_char):
11076 (Ftranslate_region_internal, Fformat):
11077 Rename or remove local vars to avoid shadowing.
9710023e 11078 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11079
a415e694
PE
11080 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11081 avoid shadowing.
11082
8ef4622d
PE
11083 * lisp.h (eassert): Check that the argument compiles, even if
11084 ENABLE_CHECKING is not defined.
11085
946f9a5b
PE
11086 * data.c (Findirect_variable): Name an expression, to avoid
11087 gcc -Wbad-function-cast warning.
112396d6 11088 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11089 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11090 (Fmake_variable_buffer_local, Fmake_local_variable):
11091 Mark variables as initialized.
52746918 11092 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11093
e5aab7e7 11094 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11095 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11096 Rename locals to avoid shadowing.
dff45157
PE
11097 (mark_stack): Move local variables into the #ifdef region where
11098 they're used.
7bc26fdb
PE
11099 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11100 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11101 needed otherwise.
11102 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11103 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11104 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11105
e5aab7e7
PE
11106 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11107 avoids undefined behavior in theory.
11108
4da60324
PE
11109 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11110
88043301
PE
11111 Use functions, not macros, for up- and down-casing (Bug#8254).
11112 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11113 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11114 to use the following functions instead of these macros.
11115 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11116 EMACS_INT, since callers assume the returned value fits in int.
11117 (upcase1): Likewise, for UPCASE_TABLE.
11118 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11119 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11120 the race-condition problem in the old DOWNCASE.
88043301 11121
19ed5445
PE
11122 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11123 Rename locals to avoid shadowing.
11124 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11125 (regex_compile, re_search_2, re_match_2_internal):
11126 Remove unused local vars.
952db0d7
PE
11127 (FREE_VAR): Rewrite so as not to use empty "else",
11128 which gcc can warn about.
da053e48 11129 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11130 (RETALLOC_IF): Define only if needed.
11131 (WORDCHAR_P): Likewise. This one is never needed, but is used
11132 only in a comment talking about a compiler bug, so put inside
11133 the #if 0 of that comment.
11134 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11135 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11136 Remove; unused.
19ed5445 11137
1f3561e4 11138 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11139 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11140 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11141
ded6f8f7
PE
11142 * search.c (simple_search): Remove unused var.
11143
dbd37a95
PE
11144 * dired.c (compile_pattern): Move decl from here ...
11145 * lisp.h: ... to here, so that it can be checked.
11146 (struct re_registers): New forward decl.
11147
7e47afad
PE
11148 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11149
85f24f61
PE
11150 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11151 All uses changed.
11152 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11153 Rename locals to avoid shadowing.
5671df8f 11154 (Fvertical_motion): Mark locals as initialized.
85f24f61 11155
181aa2be 11156 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11157 (casify_region): Mark local as initialized.
181aa2be 11158
930d429c
PE
11159 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11160
7082eac6
PE
11161 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11162 New macros, so that the caller can use some names other than
11163 gcpro1, gcpro2, etc.
11164 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11165 of the new macros.
11166 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11167 argument, for consistency with GCPRO2_VAR, etc: it is now the
11168 prefix of the variable, not the variable itself. All uses
11169 changed.
38b2c076
PE
11170 * dired.c (directory_files_internal, file_name_completion):
11171 Rename locals to avoid shadowing.
11172
15206ed9
PE
11173 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11174 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11175 dired.c's scmp function, had undefined behavior.
11176 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11177 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11178 * buffer.h: ... to here, because these macros use current_buffer,
11179 and the new implementation with inline functions needs to have
11180 current_buffer in scope now, rather than later when the macros
11181 are used.
11182 (downcase, upcase1): New static inline functions.
11183 (DOWNCASE, UPCASE1): Reimplement using these functions.
11184 This avoids undefined behavior in expressions like
11185 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11186 from race conditions in accessing the global variables
11187 case_temp1 and case_temp2.
11188 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11189 * lisp.h (case_temp1, case_temp2): Remove their decls.
11190 * character.h (ASCII_CHAR_P): Move from here ...
11191 * lisp.h: ... to here, so that the inline functions mentioned
11192 above can use them.
11193
4a6bea26
PE
11194 * dired.c (directory_files_internal_unwind): Now static.
11195
f14b7e14
PE
11196 * fileio.c (file_name_as_directory, directory_file_name):
11197 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11198 Now static.
2893f146
PE
11199 (file_name_as_directory): Use const pointers when appropriate.
11200 (Fexpand_file_name): Likewise. In particular, newdir might
11201 point at constant storage, so make it a const pointer.
fd4ead52 11202 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11203 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11204 signedness issues.
f839df0c
PE
11205 (Fset_file_times, Finsert_file_contents, auto_save_error):
11206 Rename locals to avoid shadowing.
f14b7e14 11207
5716756e 11208 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11209 (Ftry_completion, Fall_completions): Rename or remove locals
11210 to avoid shadowing.
5716756e 11211
b4c3046a
PE
11212 * marker.c (bytepos_to_charpos): Remove; unused.
11213
b45db522
PE
11214 * lisp.h (verify_bytepos, count_markers): New decls,
11215 so that gcc does not warn that these functions aren't declared.
11216
85876d07
PE
11217 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11218 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11219 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11220 (copy_text): Remove unused local var.
85876d07 11221
03d78a21 11222 * filelock.c (within_one_second): Now static.
b3dd38ab 11223 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11224
5df8f01b
PE
11225 * buffer.c (fix_overlays_before): Mark locals as initialized.
11226 (fix_start_end_in_overlays): Likewise. This function should be
11227 simplified by using pointers-to-pointers, but that's a different
11228 matter.
b1d876f1 11229 (switch_to_buffer_1): Now static.
8f54f30a
PE
11230 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11231 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11232
a70072c9 11233 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11234 Fix pointer signedness issue.
edced198
PE
11235 (sys_subshell): Mark local as volatile if checking for lint,
11236 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11237 (MAXPATHLEN): Define only if needed.
a70072c9 11238
a0977c44
PE
11239 * process.c (serial_open, serial_configure): Move decls from here ...
11240 * systty.h: ... to here, so that they can be checked.
11241
a884fdcc
PE
11242 * fns.c (get_random, seed_random): Move extern decls from here ...
11243 * lisp.h: ... to here, so that they can be checked.
11244
604efe86 11245 * sysdep.c (reset_io): Now static.
b8950c94 11246 (wait_for_termination_signal): Remove; unused.
604efe86 11247
38fc62d9
PE
11248 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11249 (copy_keymap_item, append_key, push_text_char_description):
11250 Now static.
1004a21a 11251 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11252 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11253 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11254 (describe_map_tree):
11255 Rename locals to avoid shadowing.
38fc62d9 11256
2f2650da
PE
11257 * keyboard.c: Declare functions static if they are not used elsewhere.
11258 (echo_char, echo_dash, cmd_error, top_level_2):
11259 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11260 (read_char, kbd_buffer_get_event, make_lispy_position):
11261 (make_lispy_event, make_lispy_movement, apply_modifiers):
11262 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11263 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11264 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11265 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11266 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11267
a053e86c 11268 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11269 (mark_kboards): Move decl here ...
11270 * alloc.c (mark_kboards): ... from here.
a053e86c 11271
4752793e
PE
11272 * lisp.h (force_auto_save_soon): New decl.
11273
74f10ca7 11274 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11275 (DEFINE_DUMMY_FUNCTION): New macro.
11276 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11277 Use it.
c03cd23f
PE
11278 (main): Add casts to avoid warnings
11279 if GCC considers string literals to be constants.
74f10ca7 11280
022e70d4
PE
11281 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11282
59d6fe83
PE
11283 * dbusbind.c: Pointer signedness fixes.
11284 (xd_signature, xd_append_arg, xd_initialize):
11285 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11286 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11287 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11288 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11289
78320123
PE
11290 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11291 if GCC considers string literals to be constants.
49cebcca 11292 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11293
35ac2a97
SM
112942011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11295
fb103ca9
SM
11296 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11297 (print_preprocess, print_object): New macro to fix last change.
11298
35ac2a97
SM
11299 * print.c (print_preprocess): Don't forget font objects.
11300
62973b41
JB
113012011-03-16 Juanma Barranquero <lekktu@gmail.com>
11302
11303 * emacs.c (USAGE3): Doc fixes.
11304
0e48bb22
AS
113052011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11306
11307 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11308 structure.
11309
7684e57b
JB
113102011-03-14 Juanma Barranquero <lekktu@gmail.com>
11311
11312 * lisp.h (VWindow_system, Qfile_name_history):
11313 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11314 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11315 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11316
11317 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11318 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11319
11320 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11321 * w32console.c (detect_input_pending, read_input_pending)
11322 (encode_terminal_code):
11323 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11324 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11325 (w32_system_caret_y, Qfile_name_history):
11326 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11327 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11328 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11329 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11330 * w32proc.c (Qlocal, report_file_error):
11331 * w32term.c (Vwindow_system, updating_frame):
11332 * w32uniscribe.c (initialized, uniscribe_font_driver):
11333 Remove unneeded extern declarations.
11334
2aa46d6c
CY
113352011-03-14 Chong Yidong <cyd@stupidchicken.com>
11336
c96bbc66 11337 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11338
cffc6f3b
CY
113392011-03-13 Chong Yidong <cyd@stupidchicken.com>
11340
11341 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11342 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11343 These macros can no longer be used for assignment.
11344
44f230aa
SM
11345 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11346 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11347 (record_buffer_markers, fetch_buffer_markers): New functions for
11348 recording and fetching special buffer markers.
11349 (set_buffer_internal_1, set_buffer_temp): Use them.
11350
11351 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11352
11353 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11354
11355 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11356 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11357
11358 * xdisp.c (hscroll_window_tree):
11359 (reconsider_clip_changes): Use PT instead of BUF_PT.
11360
d251f04b
EZ
113612011-03-13 Eli Zaretskii <eliz@gnu.org>
11362
11363 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11364 $(EMACS_ROOT)/lib/intprops.h.
11365
f0c77cd1
PE
113662011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11367
3eca4629
PE
11368 Fix more problems found by GCC 4.5.2's static checks.
11369
7c86ee98
PE
11370 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11371 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11372 (xg_free_frame_widgets): Make it clear that a local variable is
11373 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11374 (gdk_window_get_screen): Make it clear that this macro is needed
11375 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11376 (int_gtk_range_get_value): New function, which avoids a diagnostic
11377 from gcc -Wbad-function-cast.
11378 (xg_set_toolkit_scroll_bar_thumb): Use it.
11379 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11380 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11381 (get_utf8_string, xg_get_file_with_chooser):
11382 Rename locals to avoid shadowing.
11383 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11384
41729b81
PE
11385 * xgselect.c (xg_select): Remove unused var.
11386
f0c77cd1
PE
11387 * image.c (four_corners_best): Mark locals as initialized.
11388 (gif_load): Initialize transparent_p to zero (Bug#8238).
11389 Mark another local as initialized.
ec6cf4c6 11390 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11391
ce0ad53d 11392 * image.c (clear_image_cache): Now static.
d5d5a617 11393 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11394 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11395 (x_edge_detection): Remove unnecessary cast that
11396 gcc -Wbad-function-cast diagnoses.
2037898d 11397 (gif_load): Fix pointer signedness.
6ae141d6
PE
11398 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11399 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11400
33383987 114012011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11402
d32df629
PE
11403 Improve quality of tests for time stamp overflow.
11404 For example, without this patch (encode-time 0 0 0 1 1
11405 1152921504606846976) returns the obviously-bogus value (-948597
11406 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11407 reports time overflow. See
11408 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11409 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11410 * editfns.c: Include limits.h and intprops.h.
11411 (TIME_T_MIN, TIME_T_MAX): New macros.
11412 (time_overflow): Move earlier, to before first use.
11413 (hi_time, lo_time): New functions, for an accurate test for
11414 out-of-range times.
11415 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11416 (Fget_internal_run_time): Don't assume time_t fits in int.
11417 (make_time): Use list2 instead of Fcons twice.
11418 (Fdecode_time): More accurate test for out-of-range times.
11419 (check_tm_member): New function.
11420 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11421 (lisp_time_argument): Don't rely on undefined left-shift and
11422 right-shift behavior when checking for time stamp overflow.
8be6f318 11423
fe31d94c
PE
11424 * editfns.c (time_overflow): New function, refactoring common code.
11425 (Fformat_time_string, Fdecode_time, Fencode_time):
11426 (Fcurrent_time_string): Use it.
11427
8be6f318
PE
11428 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11429 * dired.c (make_time): Move to ...
11430 * editfns.c (make_time): ... here.
11431 * systime.h: Note the move.
11432
09d9db2c 114332011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11434
126bc0dc
YM
11435 * fringe.c (update_window_fringes): Remove unused variables.
11436
c47cbdfd
YM
11437 * unexmacosx.c (copy_data_segment): Also copy __got section.
11438 (Bug#8223)
11439
7ac80be9
EZ
114402011-03-12 Eli Zaretskii <eliz@gnu.org>
11441
c96bbc66 11442 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11443 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11444 Constify `char *' arguments and their references according to
11445 prototypes in tparam.h.
11446
ecb0f94d 11447 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11448
7ac80be9
EZ
11449 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11450 Adapt all references accordingly.
11451
11452 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11453
ef1fd07e
TT
114542011-03-11 Tom Tromey <tromey@redhat.com>
11455
11456 * buffer.c (syms_of_buffer): Remove obsolete comment.
11457
7ef4b50c
EZ
114582011-03-11 Eli Zaretskii <eliz@gnu.org>
11459
11460 * termhooks.h (encode_terminal_code): Declare prototype.
11461
11462 * msdos.c (encode_terminal_code): Don't declare prototype.
11463
11464 * term.c (encode_terminal_code): Now external again, used by
11465 w32console.c and msdos.c.
11466
44f230aa
SM
11467 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11468 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11469
4b1ec863 114702011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11471
1714f52b 11472 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11473
4b1ec863
PE
11474 * fringe.c (update_window_fringes): Mark locals as initialized
11475 (Bug#8227).
11476 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11477
524c7aa6
PE
11478 * alloc.c (mark_fringe_data): Move decl from here ...
11479 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11480 to check its interface.
11481 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11482
a5c0af81 11483 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11484 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11485 (fontset_font): Mark local as initialized.
a9a06e0b 11486 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11487
b4716021
PE
11488 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11489
811e9bac 11490 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11491 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11492 (x_own_selection, Fx_disown_selection_internal): Rename locals
11493 to avoid shadowing.
11494 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11495
7e3ab302
PE
11496 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11497 so that the caller can use some name other than gcpro1.
11498 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11499 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11500 (Fx_backspace_delete_keys_p):
11501 Use them to avoid shadowing, and rename vars to avoid shadowing.
11502 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11503 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11504 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11505 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11506 Remove unused locals.
7e3ab302
PE
11507 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11508 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11509 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11510 macros.
f78faa98 11511
e2b13473
PE
11512 * xterm.h (x_mouse_leave): New decl.
11513
77f23912
PE
11514 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11515 Remove unused functions.
cdf4ba58
PE
11516 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11517 (x_calc_absolute_position): Now static.
7411c686 11518 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11519 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11520 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11521 unless they are used.
38d0b34a
PE
11522 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11523 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11524 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11525 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11526 (x_error_catcher, x_connection_closed, x_error_handler):
11527 (x_error_quitter, xembed_send_message, x_iconify_frame):
11528 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11529 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11530 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11531
44f230aa
SM
11532 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11533 Rename or move locals to avoid shadowing.
6b463e58 11534 (tty_defined_color, merge_face_heights): Now static.
5967d051 11535 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11536 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11537 does not deduce is never used uninitialized.
73719eba
PE
11538 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11539 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11540
426994c3 11541 * terminal.c (store_terminal_param): Now static.
5489860b 11542
032f1620 11543 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11544 (set_frame_menubar): Remove unused local.
d4323972 11545 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11546 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11547 since they might point to immutable storage.
281585b0
PE
11548 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11549 since it's unused otherwise.
032f1620 11550
367c19e5 11551 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11552 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11553 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11554 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11555 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11556 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11557 does not deduce are never used uninitialized.
70739cbe 11558
07b48fa9
PE
11559 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11560
8868a238 11561 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11562 * window.c (window_loop, size_window):
11563 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11564
7e5cf297 11565 * window.c (display_buffer): Now static.
d6550a9f
PE
11566 (size_window): Mark variables that gcc -Wuninitialized
11567 does not deduce are never used uninitialized.
a586633d
PE
11568 * window.h (check_all_windows): New decl, to forestall
11569 gcc -Wmissing-prototypes diagnostic.
5b555da1 11570 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11571
f6095868
PE
11572 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11573 shadowing.
11574 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11575 Include <limits.h>.
11576 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11577 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11578 (load_charset_map): Mark variables that gcc -Wuninitialized
11579 does not deduce are never used uninitialized.
53df7c11 11580 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11581
f38b440c
PE
11582 * coding.c (coding_set_source, coding_set_destination):
11583 Use "else { /* comment */ }" rather than "else /* comment */;"
11584 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11585 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11586 a block, when the outer 'i' will do.
11587 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11588 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11589 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11590 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11591 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11592 Rename locals to avoid shadowing.
11593 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11594 * coding.c (emacs_mule_char, encode_invocation_designation):
11595 Now static, since they're not used elsewhere.
413bb2db 11596 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11597 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11598 (decode_coding_emacs_mule): Mark variables that gcc
11599 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11600 (detect_coding_iso_2022): Initialize a local variable that might
11601 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11602 this initialization is needed. (Bug#8211)
5f58e762
PE
11603 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11604 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11605 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11606 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11607 Remove unused macros.
f38b440c 11608
232b38b9 11609 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11610 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11611 * character.c (string_count_byte8): Likewise.
232b38b9 11612
fb90da1b
PE
11613 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11614 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11615
fb93dbc2
PE
11616 * chartab.c (copy_sub_char_table): Now static, since it's not used
11617 elsewhere.
5c156ace
PE
11618 (sub_char_table_ref_and_range, char_table_ref_and_range):
11619 Rename locals to avoid shadowing.
bbcd0949 11620 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11621
7d3b3862 11622 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11623 (BIDI_BOB): Remove unused macro.
7d3b3862 11624
6be7d3da
PE
11625 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11626 deduce are never used uninitialized.
c2ed9c8b 11627 * term.c (encode_terminal_code): Likewise.
6be7d3da 11628
75f8807f 11629 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11630
50938595
PE
11631 * tparam.h: New file.
11632 * term.c, tparam.h: Include it.
11633 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11634 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11635 Move these decls to tparam.h, and make them agree with what
11636 is actually in tparam.c. The previous trick of using incompatible
11637 decls in different modules does not conform to the C standard.
11638 All callers of tparam changed to use tparam's actual API.
11639 * tparam.c (tparam1, tparam, tgoto):
11640 Use const pointers where appropriate.
11641
fbceeba2
PE
11642 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11643 * cm.h (struct cm): Likewise.
11644 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11645 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11646 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11647 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11648 (turn_on_face, init_tty): Likewise.
11649 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11650
7f3f1250
PE
11651 * term.c (term_mouse_position): Rename local to avoid shadowing.
11652
e6ca6543
PE
11653 * alloc.c (mark_ttys): Move decl from here ...
11654 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11655
c40f8d15
AS
116562011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11657
11658 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11659
cfe0661d
JB
116602011-03-09 Juanma Barranquero <lekktu@gmail.com>
11661
11662 * search.c (compile_pattern_1): Remove argument regp, unused since
11663 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11664 (compile_pattern): Don't pass it.
11665
0afb4571
J
116662011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11667
11668 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11669 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11670 for ! HAVE_GTK3.
11671 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11672
11673 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11674
11675 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11676 gdk_window_get_screen, gdk_window_get_geometry,
11677 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11678 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11679 (xg_get_pixbuf_from_pixmap): New function.
11680 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11681 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11682 Call xg_get_pixbuf_from_pixmap instead of
11683 gdk_pixbuf_get_from_drawable.
11684 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11685 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11686 (xg_check_special_colors): Use GtkStyleContext and its functions
11687 for HAVE_GTK3.
11688 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11689 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11690 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11691 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11692 Call gtk_widget_get_preferred_size.
0afb4571
J
11693 (xg_frame_resized): gdk_window_get_geometry only takes 5
11694 parameters.
44f230aa
SM
11695 (xg_win_to_widget, xg_event_is_for_menubar):
11696 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11697 (xg_set_widget_bg): New function.
11698 (delete_cb): New function.
895009e1 11699 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11700 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11701 (xg_set_background_color): Call xg_set_widget_bg.
11702 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11703 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11704 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11705 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11706 if ! HAVE_GTK3.
11707 (update_frame_tool_bar): Call gtk_widget_hide.
11708 (xg_initialize): Use GDK_KEY_g.
11709
11710 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11711 if ! HAVE_GTK3
11712 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11713
11714 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11715 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11716 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11717
1c2cc4ef
JB
117182011-03-08 Juanma Barranquero <lekktu@gmail.com>
11719
11720 * w32xfns.c (select_palette): Check success of RealizePalette against
11721 GDI_ERROR, not zero.
11722
33383987 11723See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11724
11725;; Local Variables:
11726;; coding: utf-8
aac0c6e3
MR
11727;; End:
11728
2f097256 11729 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11730
11731 This file is part of GNU Emacs.
11732
11733 GNU Emacs is free software: you can redistribute it and/or modify
11734 it under the terms of the GNU General Public License as published by
11735 the Free Software Foundation, either version 3 of the License, or
11736 (at your option) any later version.
11737
11738 GNU Emacs is distributed in the hope that it will be useful,
11739 but WITHOUT ANY WARRANTY; without even the implied warranty of
11740 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11741 GNU General Public License for more details.
11742
11743 You should have received a copy of the GNU General Public License
11744 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.