2012-01-05 Michael R. Mauger <mmaug@yahoo.com>
[bpt/emacs.git] / src / ChangeLog
CommitLineData
651e947e
EZ
12012-01-01 Eli Zaretskii <eliz@gnu.org>
2
3 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4 Load gnutls_transport_set_lowat only if GnuTLS version is below
5 2.11.1.
6 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
7 GnuTLS versions below 2.11.1.
8
3778cdd8
AL
92011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
10
11 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
12 to the doc string advising against its use for altering the way
13 windows are scrolled.
14
0e5317f7
KH
152011-12-28 Kenichi Handa <handa@m17n.org>
16
17 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
18 coding-system ASCII compatible only when it does not produce BOM
19 on encoding (Bug#10383).
20
93d5ca1f
JD
212011-12-26 Jan Djärv <jan.h.d@swipnet.se>
22
23 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
24 can scroll.
25 (create_and_show_popup_menu): Always use menu_position_func for
26 Gtk3 (Bug#10361).
27
ca22b785
AS
282011-12-24 Andreas Schwab <schwab@linux-m68k.org>
29
30 * callint.c (Fcall_interactively): Don't truncate prompt string.
31
d048e1e6
EZ
322011-12-23 Eli Zaretskii <eliz@gnu.org>
33
34 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
35 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 36 resumed from there (after widening). (Bug#10360)
d048e1e6 37
5ccaba1f
JD
382011-12-22 Jan Djärv <jan.h.d@swipnet.se>
39
40 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
41
204ee57f
JD
422011-12-21 Jan Djärv <jan.h.d@swipnet.se>
43
b81d40f0
JB
44 * nsterm.m (x_free_frame_resources):
45 Release f->output_data.ns->miniimage.
204ee57f
JD
46 (ns_index_color): Fix indentation. Do not retain
47 color_table->colors[i].
48
49 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
50 before returning.
51
52 * nsfns.m (x_set_background_color): Assign return value from
53 ns_index_color to face-background instead of NSColor*.
54 (ns_implicitly_set_icon_type): Fix indentation.
55 Change assignment in for loop to comparison.
56
57 * emacs.c (ns_pool): New variable.
58 (main): Assign ns_pool.
59 (Fkill_emacs): Call ns_release_autorelease_pool.
60
61 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
62 autorelease fdesc, release fdAttrs and tdict.
63 (ns_get_covering_families): Release charset.
64 (ns_findfonts): Release NSFontDescriptor created with new.
65 (ns_uni_to_glyphs): Fix indentation.
66 (setString): Release attrStr before assigning new value.
67
c803b2b7
JD
682011-12-18 Jan Djärv <jan.h.d@swipnet.se>
69
678f4426
JD
70 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
71 and NS_IMPL_COCOA.
72 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
73 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
74
752011-12-18 David Reitter <reitter@cmu.edu>
76
5fecd5fc
JD
77 * nsterm.m (ns_term_init): Subscribe for notifications
78 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
79 to method trackingNotification in EmacsMenu.
80
81 * nsmenu.m (trackingMenu): New variable.
3771cb17 82 (trackingNotification): New method (from Aquamacs).
5fecd5fc 83 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 84 from Aquamacs (Bug#7030).
678f4426
JD
85
862011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 87
c803b2b7
JD
88 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
89 (symbol_to_nsstring): Fix indentation.
90 (ns_symbol_to_pb): New function.
91 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
92 (Fns_rotate_cut_buffers_internal): Removed.
93 (Fns_store_selection_internal): Renamed from
94 Fns_store_cut_buffer_internal.
95 (ns_get_foreign_selection, Fx_own_selection_internal)
96 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
97 (Fns_get_selection_internal, Fns_store_selection_internal):
98 Use ns_symbol_to_pb and check if return value is nil.
99 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
100 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
101 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
102 renamed to Sns_store_selection_internal.
103 (ns_handle_selection_request): Move code to Fx_own_selection_internal
104 and remove this function.
105 (ns_handle_selection_clear): Remove, never used.
106 (Fx_own_selection_internal): Move code from ns_handle_selection_request
107 here.
108
e1b01a3a
KB
1092011-12-17 Ken Brown <kbrown@cornell.edu>
110
111 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
112 GID is unknown (Bug#10257).
113
2adb6e85
PE
1142011-12-17 Paul Eggert <eggert@cs.ucla.edu>
115
116 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
117 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
118 which caused a build failure on GNU/Linux IA-64. This problem was
119 introduced by my 2011-10-07 patch.
120
d1d7b339
JL
1212011-12-15 Juri Linkov <juri@jurta.org>
122
123 * image.c (imagemagick_error): New function. (Bug#10112)
124 (imagemagick_load_image): Comment out `MagickSetResolution' call.
125 Use `imagemagick_error' where ImageMagick functions return
126 `MagickFalse'.
127 (Fimagemagick_types): Add `Fnreverse' to return the list in the
128 proper order.
129
100d5755
KH
1302011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
131
132 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
133 fill background (Bug#8992).
134
454592a6
MR
1352011-12-13 Martin Rudalics <rudalics@gmx.at>
136
137 * window.c (Vwindow_combination_resize)
138 (Vwindow_combination_limit): Use t instead of non-nil in
139 doc-strings.
61d4b438
MR
140 (Vrecenter_redisplay): Add first sentence of doc-string on
141 separate line.
53524d93 142 (Frecenter): Fix doc-string typo.
454592a6 143
3633e3aa
KH
1442011-12-11 Kenichi Handa <handa@m17n.org>
145
146 * coding.c (Funencodable_char_position): Pay attention to the
147 buffer text relocation (Bug#9389).
148
7b9d523a
JD
1492011-12-10 Jan Djärv <jan.h.d@swipnet.se>
150
151 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
152 gtk_init (Bug#10100).
153
b73189c6
EZ
1542011-12-10 Eli Zaretskii <eliz@gnu.org>
155
156 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
157 IT->string is nil. (Bug#10263)
158
f7dfe5d6
JD
1592011-12-10 Jan Djärv <jan.h.d@swipnet.se>
160
83faebb4
JD
161 * nsterm.h (x_free_frame_resources): Declare.
162
f7dfe5d6
JD
163 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
164 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
165
166 * nsterm.h (ns_get_defaults_value): Declare.
167
168 * nsterm.m (ns_default): Call ns_get_defaults_value.
169
7cd4e72c
EZ
1702011-12-09 Eli Zaretskii <eliz@gnu.org>
171
172 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
173 (Bug#10170)
174
b34d7317
YM
1752011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
176
177 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
178 that where the value of an _OBJC_* symbol points to is in the .bss
179 section (Bug#10240).
180
76470ad1
KH
1812011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
182
183 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 184 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 185
745fff94
KH
1862011-12-08 Kenichi Handa <handa@m17n.org>
187
188 * ftfont.c (get_adstyle_property): Fix previous change
189 (Bug#10233).
190
6e44397c
JB
1912011-12-07 Juanma Barranquero <lekktu@gmail.com>
192
193 * w32.c (init_environment): If no_site_lisp, remove site-lisp
194 dirs from the default value of EMACSLOADPATH (bug#10208).
195
7efa6272
GM
1962011-12-07 Glenn Morris <rgm@gnu.org>
197
198 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
199 installation and source directories as well. (Bug#10208)
200
f6fc4d87
CY
2012011-12-06 Chong Yidong <cyd@gnu.org>
202
203 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
204
2bf26180
GM
2052011-12-06 Glenn Morris <rgm@gnu.org>
206
207 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
208 as an error, not just -1. (Bug#10217)
209
3a6ad4f0
CY
2102011-12-05 Chong Yidong <cyd@gnu.org>
211
212 * keyboard.c (process_special_events): New function.
213 (swallow_events, Finput_pending_p): Use it (Bug#10195).
214
75a3b399
PE
2152011-12-05 Paul Eggert <eggert@cs.ucla.edu>
216
217 * coding.c (encode_designation_at_bol): Don't use uninitialized
218 local variable (Bug#9318).
219
c3c9e25e
KH
2202011-12-05 Kenichi Handa <handa@m17n.org>
221
222 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
223 return Qnil (Bug#8046, Bug#10193).
224
5eb05ea3
KH
2252011-12-05 Kenichi Handa <handa@m17n.org>
226
227 * coding.c (encode_designation_at_bol): New args charbuf_end and
228 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
229 (coding_set_source): Return how many bytes coding->source was
230 relocated.
231 (coding_set_destination): Return how many bytes
232 coding->destination was relocated.
233 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
234 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
235
2362011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
237
238 * coding.c (CODING_CHAR_CHARSET_P): New macro.
239 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
240 macro (Bug#9318).
241
2422011-12-05 Andreas Schwab <schwab@linux-m68k.org>
243
244 The following changes are to fix Bug#9318.
245
a79703f5 246 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
247 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
248 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 249 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 250
7dbda6df
JB
2512011-12-05 Juanma Barranquero <lekktu@gmail.com>
252
253 * lisp.h (process_quit_flag): Fix external declaration.
254
6d5eb5b0
SM
2552011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
256
257 Don't macro-inline non-performance-critical code.
258 * eval.c (process_quit_flag): New function.
259 * lisp.h (QUIT): Use it.
260
a0c3fad0
JD
2612011-12-04 Jan Djärv <jan.h.d@swipnet.se>
262
263 * nsfns.m (get_geometry_from_preferences): New function.
264 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
265
6c07aac2
AS
2662011-12-04 Andreas Schwab <schwab@linux-m68k.org>
267
268 * emacs.c (Qkill_emacs): Define.
269 (syms_of_emacs): Initialize it.
270 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
271 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
272 (quit_throw_to_read_char): Add parameter `from_signal'.
273 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
274 * lisp.h (QUIT): Call Fkill_emacs if requested.
275
c052ead4
JD
2762011-12-03 Jan Djärv <jan.h.d@swipnet.se>
277
278 * widget.c (update_wm_hints): Return if wmshell is null.
279 (widget_update_wm_size_hints): New function.
280
281 * widget.h (widget_update_wm_size_hints): Declare.
282
283 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
284 widget_update_wm_size_hints (Bug#10104).
285
9e49252b
EZ
2862011-12-03 Eli Zaretskii <eliz@gnu.org>
287
288 * xdisp.c (handle_invisible_prop): If the invisible text ends just
289 before a newline, prepare the bidi iterator for consuming the
290 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 291 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 292
02b16839
JL
2932011-12-02 Juri Linkov <juri@jurta.org>
294
295 * search.c (Fword_search_regexp): New Lisp function created from
296 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
297 (Fword_search_backward, Fword_search_forward)
298 (Fword_search_backward_lax, Fword_search_forward_lax):
299 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
300 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
301
0068070e
SM
3022011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
303
304 * fileio.c (Finsert_file_contents): Move after-change-function call
305 to before the "handled:" label, since all "goto handled" appear in
306 cases where the *-change-functions have already been properly called
307 (bug#10117).
308
3360a3fc
AS
3092011-12-01 Andreas Schwab <schwab@linux-m68k.org>
310
311 * keyboard.c (interrupt_signal): Don't call kill-emacs when
312 waiting for input. (Bug#10169)
313
73d6c093
EZ
3142011-11-30 Eli Zaretskii <eliz@gnu.org>
315
316 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
317 verifies glyph row's hash code--we have just reallocated the
318 glyphs, so their contents can be complete garbage. (Bug#10164)
319
febe6bea
JB
3202011-11-30 Juanma Barranquero <lekktu@gmail.com>
321
322 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
323
801a4313
EZ
3242011-11-30 Eli Zaretskii <eliz@gnu.org>
325
326 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
327 attributes are tested _before_ calling verify_row_hash, to protect
328 against GCC re-ordering of the tests. (Bug#10164)
329
2b56b87e
JD
3302011-11-29 Jan Djärv <jan.h.d@swipnet.se>
331
332 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
333
334 * xterm.c (handle_one_xevent): Only set async_visible and friends
335 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 336 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
337 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
338
dbf31225
PE
3392011-11-28 Paul Eggert <eggert@cs.ucla.edu>
340
341 Remove GCPRO-related macros that exist only to avoid shadowing locals.
342 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
343 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
344 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
345 All uses changed to use GCPRO1 etc.
346 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
347 Revert to old implementation (i.e., before 2011-03-11).
348
1305621b
YM
3492011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
350
351 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
352 of scroll runs so as to avoid assigning disabled bogus rows and
353 unnecessary graphics copy operations.
354
8c9afb46
EZ
3552011-11-27 Eli Zaretskii <eliz@gnu.org>
356
357 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
358 (snprintf) [_MSC_VER]: Redirect to _snprintf.
359 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
360 (malloc, free, realloc, calloc): Redirect to e_* only when
361 compiling Emacs.
362
363 * lisp.h (GCTYPEBITS): Move before first use.
364 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
365 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
366 this macro definition.
367
368 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
369 _MSC_VER.
370
54e9e3bf
JD
3712011-11-27 Jan Djärv <jan.h.d@swipnet.se>
372
6d5eb5b0
SM
373 * gtkutil.c (xg_create_frame_widgets):
374 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
375 present with Gtk+ 2.0.
376
83aca1cb
PE
3772011-11-26 Paul Eggert <eggert@cs.ucla.edu>
378
379 * fileio.c (Finsert_file_contents): Undo previous change; see
380 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
381
5b76caa4
PE
3822011-11-26 Paul Eggert <eggert@cs.ucla.edu>
383
384 Rename locals to avoid shadowing.
385 * fileio.c (Finsert_file_contents):
386 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
387 * process.c (wait_reading_process_output):
388 Rename inner 'proc' to 'p' to avoid shadowing.
389 Indent for consistency with usual Emacs style.
390
8c535114
EZ
3912011-11-25 Eli Zaretskii <eliz@gnu.org>
392
393 * xdisp.c (redisplay_window): If cursor row is not fully visible
394 after recentering, and scroll-conservatively is set to a large
395 number, scroll window by a few more lines to make the cursor fully
396 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
397 (start_display): Don't move to the next line if the display should
398 start at a newline that is part of a display vector or an overlay
399 string. (Bug#10119)
8c535114 400
fa4fdb5c
JL
4012011-11-24 Juri Linkov <juri@jurta.org>
402
403 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
404 after the `MagickPingImage' call. (Bug#10112)
405
90ec88df
CY
4062011-11-23 Chong Yidong <cyd@gnu.org>
407
408 * window.c (Fcoordinates_in_window_p): Accept only live windows.
409
56e2e794
MR
4102011-11-23 Martin Rudalics <rudalics@gmx.at>
411
412 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
413 making another buffer current. (Bug#10114)
414
b6e64c41
GM
4152011-11-23 Glenn Morris <rgm@gnu.org>
416
417 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
418
6b21de18
CY
4192011-11-23 Chong Yidong <cyd@gnu.org>
420
421 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
422 using it (Bug#5984).
423
b12cd789
EZ
4242011-11-22 Eli Zaretskii <eliz@gnu.org>
425
426 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
427 and header-lines, as they don't have one computed for them.
428 (Bug#10098)
429
430 * .gdbinit (prow): Make displayed values more self-explaining.
431 Add row's hash code.
432
261b6fd4
LMI
4332011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
434
435 * process.c (wait_reading_process_output): Fix asynchrounous
436 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 437 (wait_reading_process_output): Add comment and URL.
261b6fd4 438
e7cfd277
JD
4392011-11-21 Jan Djärv <jan.h.d@swipnet.se>
440
441 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
442
a9b9b7f5
CY
4432011-11-21 Chong Yidong <cyd@gnu.org>
444
445 * window.c (Fnext_window, Fprevious_window): Doc fix.
446
b0d15b4f
SM
4472011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
448
449 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
450
fe7a3057
JB
4512011-11-20 Juanma Barranquero <lekktu@gmail.com>
452
453 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
454
d2999b1a
MR
4552011-11-20 Martin Rudalics <rudalics@gmx.at>
456
457 * window.c (Fset_window_combination_limit): Rename argument
458 STATUS to LIMIT.
459 (Vwindow_combination_limit): Remove "status" from doc-string.
460
d5ff9cd0
AS
4612011-11-20 Andreas Schwab <schwab@linux-m68k.org>
462
463 * m/ibms390.h: Remove.
464 * m/ibms390x.h: Don't include "ibms390.h".
465
a5bb9bd3
SM
4662011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
467
468 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
469 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
470
cd1181db
JB
4712011-11-20 Juanma Barranquero <lekktu@gmail.com>
472
473 * casetab.c (Fset_case_table):
474 * charset.c (Fcharset_after): Fix typos.
475
615a3b8d 4762011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 477
17e845af
PE
478 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
479 Otherwise, valgrind does not work on some platforms.
480 Problem reported by Andreas Schwab in
6a0bf43d
PE
481 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
482 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
483 is set, removing the need for VIRT_ADDRESS_VARIES.
484 (PURE_P): Use a more-efficient implementation that needs just one
485 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
486 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
487 to 4 (xorl, subq, cmpq, setbe).
488 * alloc.c (pure): Always extern now, since that's the
489 VIRT_ADDR_VARIES behavior.
490 (PURE_POINTER_P): Use a single comparison, not two, for
491 consistency with the new puresize.h.
492 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
493 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
494 Remove VIRT_ADDR_VARIES no longer needed.
495
f8fe6f96
EZ
4962011-11-19 Eli Zaretskii <eliz@gnu.org>
497
498 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
499 (erase_phys_cursor, update_window_cursor, show_mouse_face)
500 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
501 behave as if the cursor position were at the window margin.
502
503 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
504 and the cursor position is out of bounds, behave as if the cursor
505 position were at the window margin. (Bug#10075)
506
df05a53c
CY
5072011-11-18 Chong Yidong <cyd@gnu.org>
508
509 * window.c (Fwindow_combination_limit): Make first argument
510 non-optional, since it is meaningless for live windows like the
511 selected window.
512
2071918e
DA
5132011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
514
515 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
516
b50a28de
SM
5172011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
518
519 * intervals.c: Fix grafting over the whole buffer (bug#10071).
520 (graft_intervals_into_buffer): Simplify.
521
015137db
EZ
5222011-11-18 Eli Zaretskii <eliz@gnu.org>
523
524 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
525 hash values of the two rows.
526 (copy_row_except_pointers): Preserve the used[] arrays and the
527 hash values of the two rows. (Bug#10035)
68c95424 528 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
529
530 * xdisp.c (row_hash): New function, body extracted from
531 compute_line_metrics.
532 (compute_line_metrics): Call row_hash, instead of computing the
533 hash code inline.
534
535 * dispnew.c (verify_row_hash): Call row_hash for computing the
536 hash code of a row, instead of duplicating code from xdisp.c.
537
538 * dispextern.h (row_hash): Add prototype.
539
a2addb04
TH
5402011-11-18 Tassilo Horn <tassilo@member.fsf.org>
541
542 * frame.c (delete_frame): Don't delete the terminal when the last
543 X frame is closed if emacs is built with GTK toolkit.
544
df85d315
JB
5452011-11-17 Juanma Barranquero <lekktu@gmail.com>
546
547 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
548
a0c2d0ae
MR
5492011-11-17 Martin Rudalics <rudalics@gmx.at>
550
551 * window.c (Vwindow_splits): Rename to
552 Vwindow_combination_resize. Suggested by Juri Linkov.
553 (Fsplit_window_internal): Use Vwindow_combination_resize instead
554 of Vwindow_splits.
555
58179cce
JB
5562011-11-16 Juanma Barranquero <lekktu@gmail.com>
557
7877f373
JB
558 * nsfns.m (Fns_font_name):
559 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 560
b6f67890
MR
5612011-11-16 Martin Rudalics <rudalics@gmx.at>
562
563 * window.h (window): Rename slot "nest" to "combination_limit".
564 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
565 (Fset_window_nest): Rename to Fset_window_combination_limit.
566 (Vwindow_nest): Rename to Vwindow_combination_limit.
567 (recombine_windows, make_parent_window, make_window)
568 (Fsplit_window_internal, saved_window)
569 (Fset_window_configuration, save_window_save): Rename all
570 occurrences of window_nest to window_combination_limit.
571
c7015153
JB
5722011-11-15 Juanma Barranquero <lekktu@gmail.com>
573
574 * image.c (imagemagick_load_image): Fix typo.
575
322ad6ec
EZ
5762011-11-14 Eli Zaretskii <eliz@gnu.org>
577
578 * xdisp.c (display_line): Move the call to
579 highlight_trailing_whitespace before the call to
580 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
581 faces of all the glyphs to compute ROW's hash value.
582 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 583
f067b8ec
JB
5842011-11-14 Juanma Barranquero <lekktu@gmail.com>
585
586 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
587 just return (bug#10044).
588
1e5b2111
EZ
5892011-11-12 Eli Zaretskii <eliz@gnu.org>
590
7ef3cbd5
EZ
591 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
592 with user-defined heap size. Bump the default size of the temacs
593 heap to 27MB, to avoid memory warning when running temacs.
594 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
595
1e5b2111
EZ
596 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
597 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
598 (verify_row_hash) [XASSERTS]: New function.
599 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
600 that the hash value of glyph rows is correct.
1e5b2111 601
89d61221
MR
6022011-11-12 Martin Rudalics <rudalics@gmx.at>
603
604 * window.h (window): Remove splits slot.
605 * window.c (Fwindow_splits, Fset_window_splits): Remove.
606 (Fdelete_other_windows_internal, make_parent_window)
607 (make_window, Fsplit_window_internal, Fdelete_window_internal)
608 (Fset_window_configuration, save_window_save): Don't deal with
609 split status of windows.
610 (saved_window): Remove splits slot.
611 (Vwindow_splits): Rewrite doc-string.
612
97f18cc8
JD
6132011-11-11 Jan Djärv <jan.h.d@swipnet.se>
614
615 * xfns.c (unwind_create_frame):
616 * nsfns.m (unwind_create_frame):
617 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
618 Vframe_list (Bug#9999).
619
22a648b4
DA
6202011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
621
0b381c7e 622 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 623
659afede
KH
6242011-11-11 Kenichi Handa <handa@m17n.org>
625
626 * callproc.c (Fcall_process): Set the member dst_multibyte of
627 process_coding.
628
9ac0394b
KH
6292011-11-11 Johan Bockgård <bojohan@gnu.org>
630
631 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
632 avoid a crash (bug#9496).
633
2fbdc249
CY
6342011-11-09 Chong Yidong <cyd@gnu.org>
635
636 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
637 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
638
ac6b1f81
PE
6392011-11-08 Paul Eggert <eggert@cs.ucla.edu>
640
641 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
642
09db192c
PE
6432011-11-08 Paul Eggert <eggert@cs.ucla.edu>
644
645 Avoid some portability problems by eschewing 'extern inline' functions.
646 The trivial performance wins aren't worth the portability hassles; see
647 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
648 et seq.
649 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
650 (window_box_width, window_box_left, window_box_left_offset)
651 (window_box_right, window_box_right_offset): Undo previous change,
652 by removing the "extern"s.
653 * intervals.c (adjust_intervals_for_insertion)
654 (adjust_intervals_for_deletion): Undo previous change,
655 making these static again.
656 (offset_intervals, temp_set_point_both, temp_set_point)
657 (copy_intervals_to_string): No longer inline.
658 * xdisp.c (window_text_bottom_y, window_box_width)
659 (window_box_height, window_box_left_offset)
660 (window_box_right_offset, window_box_left, window_box_right)
661 (window_box): No longer inline.
662
105216ed
CY
6632011-11-08 Chong Yidong <cyd@gnu.org>
664
665 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
666 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
667 Signal an error if not a live window.
105216ed
CY
668 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
669 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
670
ae9e237f
JB
6712011-11-07 Juanma Barranquero <lekktu@gmail.com>
672
673 * lisp.h (syms_of_abbrev): Remove declaration.
674 Reported by CHENG Gao <chenggao@royau.me>.
675
c7aa8333
EZ
6762011-11-07 Eli Zaretskii <eliz@gnu.org>
677
678 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
679 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
680 of temacs in GUI mode.
681
be7f5545
MR
6822011-11-07 Martin Rudalics <rudalics@gmx.at>
683
684 * window.h: Declare delete_all_child_windows instead of
685 delete_all_subwindows.
686 * window.c (Fwindow_nest, Fset_window_nest)
687 (Fset_window_new_total, Fset_window_new_normal)
688 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
689 (delete_all_subwindows): Rename to delete_all_child_windows.
690 (Fdelete_other_windows_internal, Fset_window_configuration):
691 Call delete_all_child_windows instead of delete_all_subwindows.
692 * frame.c (delete_frame): Call delete_all_child_windows instead
693 of delete_all_subwindows.
694
ca78dc43
PE
6952011-11-07 Paul Eggert <eggert@cs.ucla.edu>
696
697 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
698 This is also needed for porting to any host where GC_MARK_STACK is
699 not GC_MAKE_GCPROS_NOOPS.
700 (which_symbols): Use it.
701
a0241d01
KH
7022011-11-07 Kenichi Handa <handa@m17n.org>
703
704 * coding.c (coding_set_destination): Check coding->src_pos only
705 when coding->src_object is a buffer (bug#9910).
706
707 * process.c (send_process): Set the member src_multibyte of coding
708 to 0 (bug#9911) when sending a unibyte text.
709
710 * callproc.c (Fcall_process): Set the member src_multibyte of
711 process_coding to 0 (bug#9912).
712
a64bfdfa 7132011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
714
715 * xmenu.c (cleanup_widget_value_tree): New function.
716 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
717 calling free_menubar_widget_value_tree directly (Bug#9830).
718
cb41b32a
PE
7192011-11-06 Paul Eggert <eggert@cs.ucla.edu>
720
721 Fix some portability problems with 'inline'.
722 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
723 (window_box_width, window_box_left, window_box_left_offset)
724 (window_box_right, window_box_right_offset): Declare extern.
725 Otherwise, these inline functions do not conform to C99 and
726 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
727 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
728 * intervals.c (adjust_intervals_for_insertion)
729 (adjust_intervals_for_deletion): Now extern, because otherwise the
730 extern inline functions 'offset_intervals' couldn't refer to it.
731 (static_offset_intervals): Remove.
732 (offset_intervals): Rewrite using the old contents of
733 static_offset_intervals. The old version didn't conform to C99
734 because an extern inline function contained a reference to an
735 identifier with static linkage.
736
b7041366
AS
7372011-11-06 Andreas Schwab <schwab@linux-m68k.org>
738
739 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
740 GC.
741
88a37c4d
EZ
7422011-11-06 Eli Zaretskii <eliz@gnu.org>
743
744 * xdisp.c (init_iterator, reseat_to_string): Don't set the
745 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
746 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
747 return Qleft_to_right.
748
49745b39
CY
7492011-11-06 Chong Yidong <cyd@gnu.org>
750
751 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
752 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
753 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
754 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
755 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
756 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
757 (Fwindow_vscroll): Doc fix.
758 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
759 argument, since it makes no sense to pass a live window and for
760 consistency with window-child.
761
1f05cd82
CS
7622011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
763
764 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
765 support MSVC.
766
22610910
JR
7672011-11-05 Jason Rumney <jasonr@gnu.org>
768
769 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
770 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
771 fonts (Bug#6029).
772 (add_font_entity_to_list): Fix logic errors in mixed boolean and
773 bitwise arithmetic preventing use of unicode-sip and non-truetype
774 opentype fonts.
775
a06776b2
EZ
7762011-11-05 Eli Zaretskii <eliz@gnu.org>
777
3ad924ba
EZ
778 * s/ms-w32.h (fstat, stat, utime): Move redirections to
779 "emacs"-only part.
780
a06776b2
EZ
781 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
782 initialization code to keep similarity to xfns.c after changes
783 from 2011-11-05.
784
c9e7db78
JD
7852011-11-05 Jan Djärv <jan.h.d@swipnet.se>
786
a97f8f3f
JD
787 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
788 (unwind_create_frame): New function (Bug#9943).
789 (Fx_create_frame): Restructure code to be more similar to the one in
790 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
791 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
792 Move terminal->reference_count++ just before making the frame official
793 (Bug#9943).
794
795 * nsterm.m (x_free_frame_resources): New function.
796 (x_destroy_window): Move code to x_free_frame_resources.
797
c9e7db78 798 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
799 (Fx_create_frame, x_create_tip_frame):
800 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
801 official. Move initialization of image_cache_refcount and
802 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
803
a6fc3b5c
EZ
8042011-11-05 Eli Zaretskii <eliz@gnu.org>
805
806 Support MSVC build with newer versions of Visual Studio.
807 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
808 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
809 nt/gmake.defs.
810
811 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
812 which are not supported by MSVC.
813 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
814 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
815 bitfields.
816 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
817 types in bitfields.
818 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
819
820 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
821
58179cce 8222011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
823
824 Support MSVC build with newer versions of Visual Studio.
825 * w32.c: Don't include w32api.h for MSVC.
826 (init_environment) [_MSC_VER]: Call sys_access, not _access.
827
828 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
829 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
830 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
831 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
832 e_* cousins.
833 (alloca) [_MSC_VER]: Define to _alloca.
834
835 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
836
837 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
838
a58c13ed
EZ
8392011-11-04 Eli Zaretskii <eliz@gnu.org>
840
841 * xdisp.c (note_mouse_highlight): If either of
842 previous/next-single-property-change returns nil, treat that as
843 the beginning or the end of the buffer. (Bug#9955)
844
fe0b6370
JD
8452011-11-04 Jan Djärv <jan.h.d@swipnet.se>
846
a58c13ed 847 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
848 label is not null (Bug#9951).
849 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
850 may be NULL.
851
89bd5ee1
EZ
8522011-11-04 Eli Zaretskii <eliz@gnu.org>
853
854 * window.c (Fwindow_body_size): Mention in the doc string that the
855 return value is in frame's canonical units. (Bug#9949)
856
84c3edb9
EZ
8572011-11-03 Eli Zaretskii <eliz@gnu.org>
858
4e2fb5c7
EZ
859 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
860
84c3edb9 861 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 862 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 863 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 864
bc17a887
EZ
8652011-11-01 Eli Zaretskii <eliz@gnu.org>
866
867 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
868 Don't stop backward scan on the continuation glyph, even though
869 its CHARPOS is positive.
6d5eb5b0
SM
870 (mouse_face_from_buffer_pos, note_mouse_highlight):
871 Rename cover_string to disp_string.
bc17a887 872
4ee88440
MR
8732011-11-01 Martin Rudalics <rudalics@gmx.at>
874
875 * window.c (temp_output_buffer_show): Don't use
876 Vtemp_buffer_show_specifiers.
877 (Vtemp_buffer_show_specifiers): Remove unused variable.
878
c2ff3c02
EZ
8792011-10-30 Eli Zaretskii <eliz@gnu.org>
880
881 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
882 past the beginning of the current glyph matrix.
883
58179cce 8842011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
885
886 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
887 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
888 HAVE_GTK3 (Bug#9869).
b77a6a7f 889
3b574623
JD
890 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
891 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
892
b77a6a7f
JD
893 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
894
895 * xterm.c: Declare x_handle_net_wm_state to return int.
896 (handle_one_xevent): Check if we are iconified but don't have
897 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
898 (get_current_wm_state): Return non-zero if not hidden,
899 check for _NET_WM_STATE_HIDDEN (Bug#9893).
900 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
901 (x_handle_net_wm_state): Return what get_current_wm_state returns.
902 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
903
196e41e4
PE
9042011-10-29 Paul Eggert <eggert@cs.ucla.edu>
905
906 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
907 so that this new function doesn't get optimized away by a
908 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
909
021f2e1a
AS
9102011-10-29 Andreas Schwab <schwab@linux-m68k.org>
911
912 * frame.h (MOUSE_HL_INFO): Remove excess parens.
913
8b058d44
EZ
9142011-10-29 Eli Zaretskii <eliz@gnu.org>
915
916 Fix the `xbytecode' command.
917 * .gdbinit (xprintbytestr): New command.
b50a28de 918 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
919 (xbytecode): Print the byte-code string as well.
920
4452fb80
EZ
9212011-10-29 Kim Storm <storm@cua.dk>
922
8b058d44
EZ
923 * alloc.c (which_symbols): New function.
924
21b72067
AS
9252011-10-29 Andreas Schwab <schwab@linux-m68k.org>
926
927 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
928 line. (Bug#9903)
929
83ed7b5c
GM
9302011-10-29 Glenn Morris <rgm@gnu.org>
931
932 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
933 Not clear what it was for, and it causes various bugs. (Bug#9839)
934
5a7a728b
EZ
9352011-10-28 Eli Zaretskii <eliz@gnu.org>
936
937 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
938 possible random value that matches one of those tested as
939 condition to clear the mouse face.
940
d3d0842f
CY
9412011-10-28 Chong Yidong <cyd@gnu.org>
942
943 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
944
31b39d13
DN
9452011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
946
947 * window.c (make_window): Initialize phys_cursor_on_p.
948
9aba6043
SM
9492011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
950
951 * lisp.h (struct Lisp_Symbol): Update comments.
952
c20992f4
JB
9532011-10-28 Juanma Barranquero <lekktu@gmail.com>
954
955 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
956
db4f02f2
EZ
9572011-10-28 Eli Zaretskii <eliz@gnu.org>
958
959 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
960 <oslsachem@gmail.com> for helping to debug this.
961
962 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
963 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
964 (g_b_init_get_glyph_outline_w): New static variables.
965 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
966 (GetGlyphOutlineW_Proc): New typedefs.
967 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
968 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
969 New functions.
970 (w32font_open_internal, compute_metrics):
971 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
972 instead of calling the "wide" APIs directly.
973
974 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
975
976 * w32.h (syms_of_w32font): Add prototype.
977
87e68db4
JB
9782011-10-27 Juanma Barranquero <lekktu@gmail.com>
979
980 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
981 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
982 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
983 (Fmove_to_window_line): Doc fix.
984
435c1d67
CY
9852011-10-27 Chong Yidong <cyd@gnu.org>
986
987 * process.c (make_process): Set gnutls_state to NULL.
988
989 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
990 non-NULL, regardless of GNUTLS_INITSTAGE.
991 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
992 an error. Set process slots as soon as we allocate them.
993
994 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
995
9c6c6f49
CY
9962011-10-27 Chong Yidong <cyd@gnu.org>
997
9aba6043
SM
998 * gnutls.c (emacs_gnutls_deinit): New function.
999 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1000 (Fgnutls_deinit, Fgnutls_boot): Use it.
1001
1002 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1003 (deactivate_process): Call emacs_gnutls_deinit.
1004
657d08d3
JB
10052011-10-27 Juanma Barranquero <lekktu@gmail.com>
1006
1007 * image.c (x_create_x_image_and_pixmap):
1008 * w32.c (sys_rename, w32_delayed_load):
1009 * w32font.c (fill_in_logfont):
1010 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1011
5430d399
JB
10122011-10-26 Juanma Barranquero <lekktu@gmail.com>
1013
1014 * w32fns.c (w32_default_color_map): New function,
1015 extracted from Fw32_default_color_map.
a7ef684b 1016 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1017
fe0055fa
PE
10182011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1019
1020 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1021
e6346438
SM
10222011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1023
1024 * keyboard.c (test_undefined): New function (bug#9751).
1025 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1026
e112cc37
ET
10272011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1028
1029 * sysdep.c (init_sys_modes): Fix the check for the controlling
1030 terminal (Bug#6649).
1031
7b5d6677
EZ
10322011-10-20 Eli Zaretskii <eliz@gnu.org>
1033
1034 * dispextern.h (struct bidi_it): New member next_en_type.
1035
1036 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1037 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1038 current character, check also for next_en_type being WEAK_EN.
1039 (bidi_resolve_weak): Don't enter the expensive loop if the current
1040 position is before next_en_pos. Record the bidi type of the first
1041 non-ET, non-BN character we find, in addition to its position.
1042 (bidi_level_of_next_char): Invalidate next_en_type when
1043 next_en_pos is over-stepped.
1044
7da0b018
PE
10452011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1046
1047 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1048 * editfns.c: Rewrite current-time-zone so that it invokes
1049 the equivalent of (format-time-string "%Z") to get the time zone name.
1050 This fixes a bug when the time zone name contains characters that
1051 need converting from the system time locale to Emacs internal format.
1052 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1053 that patch fixed format-time-string to do the conversion, but
1054 I forgot to fix current-time-zone.
1055 (format_time_string): New function, containing most of
1056 what Fformat_time_string used to contain.
1057 (Fformat_time_string): Rewrite in terms of format_time_string.
1058 This doesn't change this function's behavior.
1059 (current-time-zone): Rewrite to use format_time_string.
1060 This fixes the bug reported by Michael Schierl in
1061 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1062 Jason Rumney's 2007-06-07 change worked around this bug, but
1063 didn't fix it.
1064 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1065
8547b010
EZ
10662011-10-19 Eli Zaretskii <eliz@gnu.org>
1067
1068 * xdisp.c (start_display): If the character at POS is displayed
1069 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1070 (try_window_reusing_current_matrix): If a line ends in a display
1071 vector or the next line starts in a display vector, continue
1072 redrawing the window even though the character position of
1073 start_row was reached.
8547b010
EZ
1074 (Bug#9771, part 2)
1075
4e948d15
CY
10762011-10-18 Chong Yidong <cyd@gnu.org>
1077
1078 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1079 with nobreak-char-display too.
1080
4787455f
EZ
10812011-10-18 Eli Zaretskii <eliz@gnu.org>
1082
1083 Fix part 3 of bug#9771.
1084 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1085 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1086 non-neutral characters if the current character is a paragraph
1087 separator (a.k.a. Newline). This avoids running the same
1088 expensive loop twice, once when we consume the preceding newline
1089 and the other time when the line actually needs to be displayed.
1090 Avoid the loop when we see neutrals on the base embedding level
1091 following a character whose directionality is the same as the
1092 paragraph's. This avoids running the expensive loop when a line
1093 ends in a long sequence of neutrals, like control characters.
1094 Add assertion against STRONG_AL type. Slightly rearrange code
1095 that determines the type of a neutral given the first non-neutral
1096 that follows it.
1097 (bidi_level_of_next_char): Set next_en_pos to zero when
1098 invalidating its info.
1099
2c91f553
EZ
11002011-10-17 Eli Zaretskii <eliz@gnu.org>
1101
1102 * xdisp.c (push_display_prop): Determine whether to record string
1103 or buffer position by IT->string, not by IT->method. Allow
1104 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1105 (move_it_vertically_backward): Don't look for character position
1106 immediately after the newline when in a continuation line.
1107 (Bug#9771, part 1)
2c91f553 1108
c7b08b0d
MR
11092011-10-15 Martin Rudalics <rudalics@gmx.at>
1110
1111 * window.c (coordinates_in_window): Rewrite and delabelize
1112 vertical border check. (Bug#5357) (Bug#9618)
1113
6b02f655
SM
11142011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1115
1116 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1117 errors in XSetWindowBorder (bug#9310).
1118
81d40c92
DA
11192011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1120
1121 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1122 avoid crash when xmalloc overrun checking is enabled.
1123
d4172c3b
EZ
11242011-10-13 Eli Zaretskii <eliz@gnu.org>
1125
1126 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1127 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1128 cursor motion with <left> and <right> arrow keys.
1129
1130 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1131 some callers set that themselves.
1132
b00eea75
EZ
11332011-10-12 Eli Zaretskii <eliz@gnu.org>
1134
1135 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1136 display string and the previous row comes from the same string and
1137 is empty. (Bug#9739) (Bug#9738)
1138
8fe012c4
SM
11392011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1140
1141 * doc.c (get_doc_string): Encode file name (bug#9735).
1142
0074aef2
EZ
11432011-10-12 Eli Zaretskii <eliz@gnu.org>
1144
79beb178
EZ
1145 * bidi.c (bidi_level_of_next_char):
1146 * xdisp.c (get_visually_first_element): Remove old incorrect
1147 comments regarding the Unicode Line Separator character.
1148
0074aef2
EZ
1149 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1150
6e4b3fbe
DA
11512011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1152
1153 * alloc.c (Fgc_status): Do not access beyond zombies array
1154 boundary if nzombies > MAX_ZOMBIES.
1155 * alloc.c (dump_zombies): Add missing format specifier.
1156
0324f3af
PE
11572011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1158
b5525cac
PE
1159 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1160 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1161
0324f3af
PE
1162 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1163 Some packages use them to denote characters with modifiers.
1164
e9b5f888
AS
11652011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1166
1167 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1168 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1169 matching a pp-number. Rename parameter var to var1.
1170
127827c0
SM
11712011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1172
1173 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1174
c8fd3bd0
GM
11752011-10-08 Glenn Morris <rgm@gnu.org>
1176
1177 * callint.c (Fcall_interactively): Give a more explicit error for the
1178 'c' case with a non-character input. (Bug#8479)
1179
352ec8ff
EZ
11802011-10-08 Eli Zaretskii <eliz@gnu.org>
1181
03669ccb
EZ
1182 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1183 lines.
7061c986
EZ
1184 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1185 lines that are hscrolled on the left.
03669ccb 1186
352ec8ff
EZ
1187 * dispnew.c (buffer_posn_from_coords): Account for a possible
1188 presence of header-line. (Bug#4426)
1189
a66cfb1c
SM
11902011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1191
6b02f655
SM
1192 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1193 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1194
7c5ee88e
PE
11952011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1196
1197 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1198 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1199 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1200 this makes Emacs dump core during garbage collection on rare
1201 occasions. sizeof is obviously inferior to offsetof here, so
1202 stick with offsetof.
1203 (GC_POINTER_ALIGNMENT): New macro.
1204 (mark_memory): Omit 3rd (offset) arg; caller changed.
1205 Don't assume EMACS_INT alignment is the same as pointer alignment.
1206
df1bbe5b
SM
12072011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1208
1209 * keyboard.c (read_key_sequence_remapped): New var.
1210 (read_key_sequence): Compute remapping in the right buffer.
1211 (command_loop_1): Use read_key_sequence's remapping directly.
1212
51553db6
SM
12132011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1214
32c1fffd
SM
1215 * dired.c (file_name_completion): Don't expand file name.
1216 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1217 before checking file name handler.
1218
51553db6
SM
1219 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1220 they've been requested explicitly (bug#9591).
1221
b6bd1599 12222011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1223
1224 * keymap.c (Fsingle_key_description): Use make_specified_string
1225 instead of build_string to build string from push_key_description.
1226 (Bug#5193)
1227
f701dc2a
PE
12282011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1229
4222c55d
PE
1230 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1231 This fixes a Y2038 bug on 64-bit hosts.
1232 * buffer.c (reset_buffer):
1233 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1234 (Fclear_buffer_auto_save_failure):
1235 Use 0, not -1, to represent an unset failure time, since time_t
1236 might not be signed.
1237
f701dc2a
PE
1238 Remove dependency on glibc malloc internals.
1239 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1240 Move back here from lisp.h, but with their new implementations.
1241 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1242 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1243 * charset.c (charset_table_init): New static var.
1244 (syms_of_charset): Use it instead of xmalloc. This removes a
1245 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1246 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1247 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1248 Move back to alloc.c.
1249 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1250 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1251
9ceebf39
JD
12522011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1253
1254 * nsterm.m (windowDidResize): Call x_set_window_size only when
1255 ns_in_resize is true. Otherwise set pixelwidth/height and
1256 call change_frame_size (Bug#9628).
1257
cb993c58
PE
12582011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1259
3930c88b
PE
1260 Port --enable-checking=all to Fedora 14 x86-64.
1261 * charset.c (syms_of_charset): Also account for glibc malloc's
1262 internal overhead when calculating the initial malloc maximum.
1263
cb993c58
PE
1264 Port --enable-checking=all to Fedora 14 x86.
1265 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1266 Move to lisp.h.
1267 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1268 (overrun_check_realloc, overrun_check_free):
1269 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1270 That way, xmalloc returns a properly-aligned pointer even if
1271 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1272 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1273 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1274 into account when calculating the initial malloc maximum.
1275 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1276 Move here from alloc.c, so that charset.c can use it too.
1277 Properly align; the old code wasn't right for common 32-bit hosts
1278 when configured with --enable-checking=all.
1279 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1280 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1281
31bed486
EZ
12822011-09-29 Eli Zaretskii <eliz@gnu.org>
1283
04c70788 1284 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1285 use EDOM.
1286
fbcaa2f3
EZ
12872011-09-28 Eli Zaretskii <eliz@gnu.org>
1288
1289 * xdisp.c (compute_display_string_end): If there's no display
1290 string at CHARPOS, return -1.
1291
1292 * bidi.c (bidi_fetch_char): When compute_display_string_end
1293 returns a negative value, treat the character as a normal
1294 character not covered by a display string. (Bug#9624)
1295
a239d4e9
JB
12962011-09-28 Juanma Barranquero <lekktu@gmail.com>
1297
1298 * lread.c (Fread_from_string): Fix typo in docstring.
1299
88652fd5
EZ
13002011-09-27 Eli Zaretskii <eliz@gnu.org>
1301
1302 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1303 newline, reseat the iterator instead of bidi-iterating there one
1304 character at a time. (Bug#9610)
32c1fffd
SM
1305 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1306 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1307
ed497dd4
AS
13082011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1309
1310 * lread.c (readevalloop): Use correct code for NBSP.
1311 (read1): Likewise. (Bug#9608)
1312
b2bf61aa
MA
13132011-09-25 Michael Albinus <michael.albinus@gmx.de>
1314
1315 * dbusbind.c (Fdbus_register_signal): When service is not
1316 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1317
32bbb17c
GM
13182011-09-25 Glenn Morris <rgm@gnu.org>
1319
1320 * buffer.c (truncate-lines): Doc fix.
1321
94e0933e
CY
13222011-09-24 Chong Yidong <cyd@stupidchicken.com>
1323
1324 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1325 (Fset_window_next_buffers): Doc fix.
1326
cddde921
GM
13272011-09-24 Glenn Morris <rgm@gnu.org>
1328
1329 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1330
1260aef1
PE
13312011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1332
25b4bfa0
PE
1333 Fix minor problems found by static checking.
1334 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1335 * indent.c (Fvertical_motion): Fix == vs = typo.
1336
e3cbd34b
EZ
13372011-09-24 Eli Zaretskii <eliz@gnu.org>
1338
a66cfb1c
SM
1339 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1340 Default value is now t. Doc fix.
6bf7006f 1341
e3cbd34b 1342 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1343 logic when moving up, not only when moving down. Fix the
e3cbd34b 1344 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1345 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1346
1347 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1348 CHARPOS is covered by a display string which includes newlines.
1349 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1350 is covered by a display string with embedded newlines.
1351
a3de0cbd
MA
13522011-09-24 Michael Albinus <michael.albinus@gmx.de>
1353
1354 * dbusbind.c (Fdbus_register_signal): Add match rule to
1355 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1356 (Fdbus_register_method, Vdbus_registered_objects_table):
1357 Fix docstring.
a3de0cbd 1358
b260039d
JM
13592011-09-24 Jim Meyering <meyering@redhat.com>
1360
32c1fffd 1361 do not ignore write error for any output size
b260039d
JM
1362 The previous change was incomplete.
1363 While it makes emacs --batch detect the vast majority of stdout
1364 write failures, errors were still ignored whenever the output size is
1365 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1366 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1367 && echo FAIL: ignored write error
1368 FAIL: ignored write error
1369 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1370 && echo FAIL: ignored write error
1371 FAIL: ignored write error
1372 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1373
8eca8a7c
AS
13742011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1375
1376 * emacs.c (Fkill_emacs): In noninteractive mode exit
1377 non-successfully if a write error occurred on stdout. (Bug#9574)
1378
3341db62
EZ
13792011-09-21 Eli Zaretskii <eliz@gnu.org>
1380
1381 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1382 the xassert test.
1383
1384 * dispextern.h (struct it): Update the comment documenting what
1385 can it->OBJECT be.
1386
8c203dbf
EZ
13872011-09-20 Eli Zaretskii <eliz@gnu.org>
1388
1389 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1390 a display string, extend search for cursor position to end of row.
1391 (find_row_edges): If the row ends in a newline from a display
1392 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1393 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1394 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1395 non-empty line. Fixes confusing cursor motion with arrow keys at
1396 the beginning of a line that starts with whitespace.
8c203dbf 1397
a4824228
LMI
13982011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1399
1400 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1401 (bug#9493).
1402
33ed493b
CY
14032011-09-18 Chong Yidong <cyd@stupidchicken.com>
1404
1405 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1406 boolean (Bug#9154).
1407
56cd55c8
EZ
14082011-09-18 Eli Zaretskii <eliz@gnu.org>
1409
1410 * xdisp.c (display_line): Record maximum and minimum buffer
1411 positions even if no glyphs were produced (e.g., by a zero-width
1412 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1413 buffer positions that will be removed from the glyph row because
1414 they don't fit.
c02dcedf
EZ
1415 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1416 column is beyond frame width: don't subtract 1 "pixel" when
1417 computing width of the stretch.
3e62b7e0
EZ
1418 (reseat_at_next_visible_line_start): Undo the change made on
1419 2011-09-17 that saved paragraph information and restored it after
1420 the call to `reseat'. (Bug#9545)
56cd55c8 1421
5ed99d36 14222011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1423
1424 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1425 and turn window cursor on if cleared (Bug#9415).
1426
5ed99d36 14272011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1428
1429 * search.c (boyer_moore): Take unibyte characters from pattern
1430 literally. (Bug#9458)
1431
9bade7b2
EZ
14322011-09-18 Eli Zaretskii <eliz@gnu.org>
1433
1434 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1435
e5e9d610
PE
14362011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1437
87e4427a
PE
1438 Fix minor problem found by static checking.
1439 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1440 initialized, to pacify gcc -Wuninitialized.
1441
e5e9d610
PE
1442 * fileio.c: Report proper errno when syscall falls.
1443 (Finsert_file_contents): Save and restore errno,
1444 so that report_file_error outputs the correct diagnostic.
1445 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1446
a1674f0b
EZ
14472011-09-18 Eli Zaretskii <eliz@gnu.org>
1448
1449 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1450
fbfb6dd4
EZ
14512011-09-17 Eli Zaretskii <eliz@gnu.org>
1452
1453 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1454 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1455
bb187662
EZ
14562011-09-17 Eli Zaretskii <eliz@gnu.org>
1457
1137e8b8 1458 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1459 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1460
1461 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1462 (bidi_find_paragraph_start): Search back for paragraph beginning
1463 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1464 (bidi_move_to_visually_next): Only trigger paragraph-related
1465 computations when the last character is a newline or at EOB, not
1466 just any NEUTRAL_B. (Bug#9470)
1467
bb187662
EZ
1468 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1469 truncated lines if point is covered by a display string. (Bug#9524)
1470
2e621251
PE
14712011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1472
1473 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1474 (cons_to_x_long): New function.
1475 (lisp_data_to_selection_data): Use it. Correct the test for
1476 short-versus-long data; it was negated. Break out of vector
1477 loop, for efficiency, when a long datum is discovered.
1478
91a15bc6
SM
14792011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1480
1481 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1482
b41c3a35
EZ
14832011-09-16 Eli Zaretskii <eliz@gnu.org>
1484
1485 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1486 GCC PR/17406) by declaring this function with external scope.
1487
7812ba2d
PE
14882011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1489
1490 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1491 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1492
cf7edc2a
AS
14932011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1494
1495 * editfns.c (Fformat): Correctly handle text properties on "%%".
1496
bd01620e
EZ
14972011-09-15 Eli Zaretskii <eliz@gnu.org>
1498
1499 * xterm.c (x_draw_composite_glyph_string_foreground):
1500 * w32term.c (x_draw_composite_glyph_string_foreground):
1501 * term.c (encode_terminal_code):
1502 * composite.c (composition_update_it, get_composition_id):
1503 * xdisp.c (get_next_display_element)
1504 (fill_composite_glyph_string): Add comments about special meaning
1505 of TAB characters in a composition.
1506
a02719a3
PE
15072011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1510 This occurs when processing a multibyte format.
1511 Problem reported by Wolfgang Jenker.
a02719a3 1512
72589a3c
JB
15132011-09-15 Johan Bockgård <bojohan@gnu.org>
1514
1515 * xdisp.c (try_cursor_movement): Only check for exact match if
1516 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1517
1c14176c
PE
15182011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 Remove unused external symbols.
1521 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1522 * xdisp.c (calc_pixel_width_or_height): Now static.
1523 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1524 * indent.c (check_display_width):
1525 * w32term.c: Fix comment to match code.
1526 * xterm.c, xterm.h (x_catching_errors): Remove.
1527
d2eea5b5
PE
15282011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1529
1530 * xselect.c: Use signed conversions more consistently (Bug#9498).
1531 (selection_data_to_lisp_data): Assume incoming selection data are
1532 signed integers, not unsigned. This is to be consistent with
1533 outgoing selection data, which was modified to use signed integers
1534 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1535 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1536 expects long, not unsigned long.
1537
46888499
EZ
15382011-09-14 Eli Zaretskii <eliz@gnu.org>
1539
1540 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1541 computation of loop end. Reported by Johan Bockgård
1542 <bojohan@gnu.org>.
1543
ef8ef9fb
CY
15442011-09-13 Chong Yidong <cyd@stupidchicken.com>
1545
1546 * frame.c (Fother_visible_frames_p): Function deleted.
1547
fa819fed
EZ
15482011-09-12 Eli Zaretskii <eliz@gnu.org>
1549
1550 * indent.c (compute_motion): Process display vector front to back
1551 rather than the other way around. (Bug#2496)
1552
2ba8e008
SM
15532011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1554
1555 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1556
20f53c69
CY
15572011-09-11 Chong Yidong <cyd@stupidchicken.com>
1558
1559 * minibuf.c (Fread_from_minibuffer): Doc fix.
1560
d562d7a4
EZ
15612011-09-11 Eli Zaretskii <eliz@gnu.org>
1562
1563 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1564 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1565
1c4d7f3d
LMI
15662011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1567
1568 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1569 value for non-existent files.
1570
b885bf36
EZ
15712011-09-11 Eli Zaretskii <eliz@gnu.org>
1572
1573 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1574 set its "size" to -1. This will set the modtime_size field of
1575 the corresponding buffer to -1, which is what
1576 verify-visited-file-modtime expects for files that do not exist.
1577 (Bug#9139)
1578
6612f0bf
PE
15792011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1582 here ...
1583 * lisp.h: ... from here. push_key_description is no longer
1584 defined in keyboard.c, so its declaration should not be in
1585 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1586 logically belongs with push_key_description.
1587
dfb3f755
PE
15882011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1589
1590 * buffer.h: Include <sys/types.h> instead of <time.h>.
1591 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1592 Problem reported by Herbert J. Skuhra.
1593
3134906c
LMI
15942011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1595
1596 * xml.c (parse_region): Make the parsing work for
1597 non-comment-starting XML files again (bug#9144).
1598
8d903f4e
AS
15992011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1600
1601 * image.c (gif_load): Fix calculation of bottom and right corner.
1602 (Bug#9468)
1603
80ad64f4
EZ
16042011-09-10 Eli Zaretskii <eliz@gnu.org>
1605
1606 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1607 redisplay in small windows.
1608
208a048d
EZ
16092011-09-09 Eli Zaretskii <eliz@gnu.org>
1610
1611 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1612
9b1c252e
MR
16132011-09-08 Martin Rudalics <rudalics@gmx.at>
1614
1615 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1616 Operate on live windows only.
1617
2949f33b
JB
16182011-09-08 Juanma Barranquero <lekktu@gmail.com>
1619
1620 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1621
e08dcafd
EZ
16222011-09-07 Eli Zaretskii <eliz@gnu.org>
1623
1624 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1625 only under bidi iteration.
1626
115b96bd
JD
16272011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1628
1629 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1630
c8199d0f
PE
16312011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1632
1633 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1634 Without this fix, the command to link temacs failed due to an
1635 undefined symbol __builtin_isnan. This is because
1636 /usr/include/iso/math_c99.h #defines isnan(x) to
1637 __builtin_isnan(x), but the bundled gcc, which identifies itself
1638 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1639 a __builtin_isnan.
1640 * floatfns.c (isnan): #undef, and then #define to a clone of
1641 what's in data.c.
1642 (Fisnan): Always define, since it's always available now.
1643 (syms_of_floatfns): Always define isnan at the Lisp level.
1644
e39b275c 16452011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1646
1647 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1648
b2db44d9 16492011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1650
f4af5137 1651 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1652 The previous code assumed that file offsets (off_t values) fit in
1653 EMACS_INT variables, which is not true on typical 32-bit hosts.
1654 The code messed up by falsely reporting buffer overflow in cases
1655 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1656 when "big" contains more than 2**29 bytes, even though this
1657 inserts just one byte and does not overflow the buffer.
1658 (Finsert_file_contents): Store file offsets as off_t
1659 values, not as EMACS_INT values. Check for overflow when
1660 converting between EMACS_INT and off_t. When checking for
1661 buffer overflow or for overlap, take the offsets into account.
1662 Don't use EMACS_INT for small values where int suffices.
1663 When checking for overlap, fix a typo: ZV was used where
1664 ZV_BYTE was intended.
1665 (Fwrite_region): Don't assume off_t fits into 'long'.
1666 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1667
ecfc0a49
MA
16682011-09-05 Michael Albinus <michael.albinus@gmx.de>
1669
1670 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1671
6511acf2 16722011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1673
0999621a 1674 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1675
1676 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1677 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1678 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1679 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1680 (modify_event_symbol): Do not assume that the length of
1681 name_alist_or_stem is safe to alloca and fits in int.
1682 (Fexecute_extended_command): Likewise for function name and binding.
1683 (Frecursion_depth): Wrap around reliably on integer overflow.
1684 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1685 since some callers pass EMACS_INT values.
1686 (Fsingle_key_description): Don't crash if symbol name contains more
1687 than MAX_ALLOCA bytes.
1688 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1689 (get_minibuffer): Arg is now EMACS_INT, not int.
1690 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1691 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1692 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1693
2be7d702
PE
1694 * dbusbind.c (signature_cat): New function.
1695 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1696 Do not overrun buffer; instead, report string overflow.
1697
9d1df220
PE
1698 * dispnew.c (add_window_display_history): Don't overrun buffer.
1699 Truncate instead; this is OK since it's just a log.
1700
33ef5c64
PE
1701 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1702 even if the time zone offset is outlandishly large.
1703 Don't mishandle offset == INT_MIN.
1704
66c6fdd5
PE
1705 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1706 when creating daemon; the previous buffer-overflow check was incorrect.
1707
d749b01b
PE
1708 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1709 which has the guts of the old verror function.
1710
b5cd1905
PE
1711 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1712 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1713
6e1a67fb
PE
1714 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1715 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1716 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1717 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1718 length of string rather than counting it via multiple sprintfs;
1719 that's simpler and more reliable.
c21721cc
PE
1720 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1721 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1722 sprintf, in case result does not fit in int.
1723
c57b67fc
PE
1724 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1725 (fontset_from_font): Print it.
1726
8a401434
PE
1727 * frame.c (tty_frame_count): Now printmax_t, not int.
1728 (make_terminal_frame, set_term_frame_name): Print it.
1729 (x_report_frame_params): In X, window IDs are unsigned long,
1730 not signed long, so print them as unsigned.
1731 (validate_x_resource_name): Check for implausibly long names,
1732 and don't assume name length fits in 'int'.
1733 (x_get_resource_string): Don't blindly alloca invocation name;
1734 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1735 not fit in int.
1736
6e1a67fb
PE
1737 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1738 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1739 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1740
0df02bf3
PE
1741 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1742 Use esprintf, not sprintf, in case result does not fit in int.
1743
48e30793
PE
1744 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1745 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1746 it as a large positive number.
1747 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1748 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1749
a66ff6d8
PE
1750 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1751 in case result does not fit in int.
1752
aca216ff
PE
1753 * print.c (float_to_string): Detect width overflow more reliably.
1754 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1755 buffer overrun. Don't assume list length fits in 'int'. Treat
1756 print length of 0 as 0, not as infinity; to be consistent with other
1757 uses of print length in this function. Don't overflow print length
1758 index. Don't assume hash table size fits in 'long', or that
1759 vectorlike size fits in 'unsigned long'.
1760
31c286f7
PE
1761 * process.c (make_process): Use printmax_t, not int, to format
1762 process-name gensyms.
1763
55e5faa1
PE
1764 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1765
80f2e268
PE
1766 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1767 to avoid potential buffer overrun.
1768
670741ab
PE
1769 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1770 if X resource line is longer than 512 bytes.
1771
b7163a50
PE
1772 * xfns.c (x_window): Make sprintf buffer a bit bigger
1773 to avoid potential buffer overrun.
1774
ae58ff1f
PE
1775 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1776
c43c8a6a
PE
1777 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1778
3f8236f4
PE
17792011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1780
53e9fe90 1781 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1782 Without these, Emacs silently mishandles large integers sometimes.
1783 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1784 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1785
6511acf2
PE
1786 * xdisp.c (try_window_id): Check Emacs fixnum range before
1787 converting to 'int'.
806add1d 1788
6511acf2 1789 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1790 Check that an Emacs fixnum is in range before assigning it to 'int'.
1791 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1792 values converted from Emacs fixnums.
1793 (Frecenter): Don't wrap around a line count if it is out of 'int'
1794 range; instead, treat it as an extreme value.
1795 (Fset_window_configuration, compare_window_configurations):
1796 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1797
6511acf2
PE
1798 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1799 that can exceed INT_MAX. Check that EMACS_INT value is in range
1800 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1801 (match_limit): Don't assume that a fixnum can fit in 'int'.
1802
6511acf2 1803 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1804 exceed INT_MAX.
1805
6511acf2 1806 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1807 (Fvertical_motion): Don't wrap around LINES values that don't fit
1808 in 'int'. Instead, treat them as extreme values. This is good
1809 enough for windows, which can't have more than INT_MAX lines anyway.
1810
fcb901a7
LMI
18112011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1812
0f2f6b6d
LMI
1813 * Require libxml/parser.h to avoid compilation warning.
1814
fcb901a7
LMI
1815 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1816
1817 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1818 since this reportedly can destroy thread storage.
1819
6e20a0d4
CY
18202011-08-30 Chong Yidong <cyd@stupidchicken.com>
1821
1822 * syntax.c (find_defun_start): Update all cache variables if
1823 exiting early (Bug#9401).
1824
148ae00e
EZ
18252011-08-30 Eli Zaretskii <eliz@gnu.org>
1826
f6cfbd8f
EZ
1827 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1828
148ae00e
EZ
1829 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1830 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1831 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1832
1833 * term.c (tty_append_glyph): New function.
1834 (produce_stretch_glyph): Static function and its prototype deleted.
1835
a66cfb1c
SM
1836 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1837 Add prototypes.
148ae00e 1838
c4a07a4c
PE
18392011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1842 when checking :margin (Bug#9390).
1843 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1844 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1845 so that the name doesn't mislead. All uses changed.
1846
6bc8cd65
JB
18472011-08-28 Johan Bockgård <bojohan@gnu.org>
1848
1849 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1850 set_tty_hooks.
1851
dca4927e
EZ
18522011-08-27 Eli Zaretskii <eliz@gnu.org>
1853
1854 * xdisp.c (move_it_to): Don't bail out early when reaching
1855 position beyond to_charpos, if we are scanning backwards.
1856 (move_it_vertically_backward): When DY == 0, make sure we get to
1857 the first character in the line after the newline.
1858
f2cad773
PE
18592011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1860
1861 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1862 (ccl_driver): Do not generate an out-of-range pointer.
1863 (Fccl_execute_on_string): Remove unnecessary check for
1864 integer overflow, noted by Stefan Monnier in
1865 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1866 Remove a FIXME that didn't need fixing.
1867 Simplify the newly-introduced buffer reallocation code.
1868
0cae2cdb
JB
18692011-08-27 Juanma Barranquero <lekktu@gmail.com>
1870
1871 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1872
5fc295a4 18732011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1874
70c60eb2 1875 Integer and memory overflow issues (Bug#9196).
726e0ab1 1876
d31850da
PE
1877 * doc.c (get_doc_string): Rework so that
1878 get_doc_string_buffer_size is the actual buffer size, rather than
1879 being 1 less than the actual buffer size; this makes xpalloc more
1880 convenient.
1881
a69fbedb
PE
1882 * image.c (x_allocate_bitmap_record, cache_image):
1883 * xselect.c (Fx_register_dnd_atom):
1884 Simplify previous changes by using xpalloc.
1885
fe5c5d37
PE
1886 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1887 since either will do and ptrdiff_t is convenient with xpalloc.
1888
0065d054
PE
1889 * charset.c (charset_table_size)
1890 (struct charset_sort_data.priority): Now ptrdiff_t.
1891 (charset_compare): Don't overflow if priorities differ greatly.
1892 (Fsort_charsets): Don't assume list length fits in int.
1893 Check for size-calculation overflow when allocating sort data.
1894 (syms_of_charset): Allocate an initial charset table that is
1895 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1896
1897 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1898
1899 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1900 The actual value is always <= INT_MAX, and leaving it unsigned made
1901 overflow checking harder.
1902
1903 * dispextern.h (struct glyph_matrix.rows_allocated)
1904 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1905 with xpalloc. The values are still always <= INT_MAX.
1906
1907 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1908
1909 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1910 (SAFE_NALLOCA): New macro.
1911
1912 * region-cache.c (struct boundary.pos, find_cache_boundary)
1913 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1914 (set_cache_region, invalidate_region_cache)
1915 (revalidate_region_cache, know_region_cache, region_cache_forward)
1916 (region_cache_backward, pp_cache):
1917 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1918 so that ptrdiff_t * can be passed to xpalloc.
1919 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1920 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1921 (pp_cache): Don't assume cache_len fits in int.
1922 * region-cache.h: Adjust extern decls to match.
1923
1924 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1925 EMACS_INT, since either will do, for xpalloc.
1926
1927 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1928 (xnmalloc, xnrealloc, xpalloc): New functions.
1929
726e0ab1
PE
1930 * bidi.c (bidi_shelve_header_size): New constant.
1931 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1932 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1933
51f30bc5 1934 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1935 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1936 (overlay_strings):
1937 Don't update size of array until after memory allocation succeeds,
1938 because xmalloc/xrealloc may not return.
0065d054
PE
1939 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1940 now that we have proper integer overflow checking.
1941 (record_overlay_string, overlay_strings): Catch overflows when
1942 calculating size of overlay_str_buf.
726e0ab1 1943
0065d054
PE
1944 * callproc.c (Fcall_process): Check for size overflow when
1945 calculating size of args2.
1946 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1947 Normally we prefer signed values, but sticking with ptrdiff_t would
1948 require adding more-complicated checks.
726e0ab1
PE
1949
1950 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1951 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1952 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1953 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1954
1955 * character.c (Fstring): Check for size-calculation overflow.
1956
1957 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1958 unnecessary integer overflow. Check for size overflow.
1959 (encode_coding_object): Don't update size until xmalloc succeeds.
1960
1961 * composite.c (get_composition_id): Check for overflow in glyph
1962 length calculations.
1963
1964 Integer and memory overflow fixes for display code.
1965 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1966 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1967 (scrolling_window): Check for overflow in size calculations.
1968 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1969 Don't assume glyph table len fits in int.
1970 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1971 (row_table_size): Now ptrdiff_t, not int.
1972 (scrolling_window): Avoid overflow in size calculations.
1973 Don't update size until allocation succeeds.
1974 * fns.c (concat): Check for overflow in size calculations.
1975 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1976 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1977 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1978
1979 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1980 (get_doc_string): Check for size calculation overflow.
1981 Don't update size until allocation succeeds.
1982 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1983 EMACS_INT, where ptrdiff_t will do.
1984 (Fsubstitute_command_keys): Check for string overflow.
1985
1986 * editfns.c (set_time_zone_rule): Don't assume environment length
1987 fits in int.
1988 (message_length): Now ptrdiff_t, not int.
1989 (Fmessage_box): Don't update size until allocation succeeds.
1990 Don't assume message length fits in int.
1991 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1992
0065d054
PE
1993 * emacs.c (main): Do not reallocate argv, since there is a null at
1994 the end that can be overwritten, and this way there's no need to
1995 worry about size-calculation overflow.
1996 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1997
1998 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1999 alloc succeeds.
2000 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2001
2002 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2003 (x_set_scroll_bar_width, x_figure_window_size):
2004 Check for integer overflow.
2005 (x_set_alpha): Do not assume XINT fits in int.
2006
2007 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2008 This is for the members text_lines, text_cols, total_lines, total_cols,
2009 where the system imposes an 'int' limit.
2010
2011 * fringe.c (Fdefine_fringe_bitmap):
2012 Don't update size until alloc works.
2013
2014 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2015 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2016
2017 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2018 Check for size-calculation overflow.
2019 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2020 do, as we prefer signed integers.
2021 (id_to_widget.max_size, id_to_widget.used)
2022 (xg_store_widget_in_map, xg_remove_widget_from_map)
2023 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2024 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2025 Use and return ptrdiff_t, not int.
2026 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2027 * gtkutil.h: Change prototypes to match the above.
2028
2029 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2030 are duplicate now that they've been promoted to lisp.h.
2031 (x_allocate_bitmap_record, x_alloc_image_color)
2032 (make_image_cache, cache_image, xpm_load):
2033 Don't update size until alloc is done.
2034 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2035 (x_detect_edges):
3256efce 2036 Check for size calculation overflow.
726e0ab1
PE
2037 (ct_colors_allocated_max): New constant.
2038 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2039 overflow.
3256efce 2040
726e0ab1
PE
2041 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2042 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2043 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2044 Use ptrdiff_t, not int, to count maps.
2045 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2046 calculations. Don't update size until allocation succeeds.
2047 Redo calculations to avoid overflow.
726e0ab1
PE
2048 * keyboard.h: Change prototypes to match the above.
2049
2050 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2051 to count maps.
2052 (current_minor_maps): Check for size calculation overflow.
2053 * keymap.h: Change prototypes to match the above.
2054
2055 * lread.c (read1, init_obarray): Don't update size until alloc done.
2056
2057 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2058 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2059
726e0ab1
PE
2060 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2061 Now ptrdiff_t, not int.
2062 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2063 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2064
2065 * process.c (Fnetwork_interface_list): Check for overflow
2066 in size calculation.
2067
2068 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2069
2070 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2071 overflow. Don't bother calling xmalloc when xrealloc will do.
2072
2073 * search.c (Freplace_match): Check for size calculation overflow.
2074 (Fset_match_data): Don't assume list lengths fit in 'int'.
2075
2076 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2077 for command line length. Do not attempt to address one before the
2078 beginning of an array, as that's not portable.
2079
2080 * term.c (max_frame_lines): Remove; unused.
2081 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2082 not int.
2083 (encode_terminal_code, calculate_costs): Check for size
2084 calculation overflow.
2085 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2086 table lengths and related sizes. Don't update size until alloc
2087 done. Redo calculations to avoid overflow.
2088 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2089
2090 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2091 subtracting pointers.
2092 (gobble_line): Check for overflow more carefully. Don't update size
2093 until alloc done.
2094
2095 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2096 Don't update size until alloc done.
2097 Redo size calculations to avoid overflow.
2098 Check for size calculation overflow.
0065d054 2099 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2100
2101 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2102 Use ptrdiff_t, not int, for sizes.
2103 (store_mode_line_noprop_char): Don't update size until alloc done.
2104
0065d054
PE
2105 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2106 Use ptrdiff_t, not int, for sizes.
2107 (Finternal_make_lisp_face, cache_face):
2108 Check for size calculation overflow.
2109 (cache_face): Treat size calculation overflows as if they were
2110 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2111
2112 * xfns.c (x_encode_text, x_set_name_internal)
2113 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2114 sizes, since they can exceed INT_MAX in size. Check for size
2115 calculation overflow.
2116
0065d054
PE
2117 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2118 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2119 Don't update size until alloc done.
2120
0065d054 2121 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2122 as sprintf is limited to int lengths.
1d526e2f 2123
252c5ee1
PE
2124 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2125 (X_LONG_MIN): New macros.
864d7ce7
PE
2126 Use them to make the following changes clearer.
2127 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2128 This change doesn't affect the value now, but it may help remind
2129 future maintainers not to raise the value too much later.
2130 (SELECTION_QUANTUM): Remove, replacing with ...
2131 (selection_quantum): ... new function, which avoids overflow.
2132 All uses changed.
2133 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2134 assumption that selection length fits in 'int'.
2135 (x_reply_selection_request, x_handle_selection_request)
2136 (x_get_window_property, receive_incremental_selection)
2137 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2138 (lisp_data_to_selection_data, clean_local_selection_data):
2139 Use ptrdiff_t, not int, to record length of selection.
2140 (x_reply_selection_request, x_get_window_property)
2141 (receive_incremental_selection, x_property_data_to_lisp):
2142 Redo calculations to avoid overflow.
2143 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2144 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2145 something.
2146 (x_get_window_property, receive_incremental_selection)
2147 (lisp_data_to_selection_data, x_property_data_to_lisp):
2148 Check for size-calculation overflow.
2149 (x_get_window_property, receive_incremental_selection)
2150 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2151 Don't store size until memory allocation succeeds.
2152 (x_get_window_property): Plug memory leak on memory exhaustion.
2153 Don't double-block input; malloc is safe here. Don't assume 2**34
2154 - 4 fits in unsigned long. Add an xassert to check
2155 XGetWindowProperty overflow. Be more careful about overflow
2156 calculations, and distinguish size from memory overflow better.
2157 (receive_incremental_selection): When tracing, don't assume
2158 unsigned int is less than INT_MAX.
2159 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2160 harmful) conversions of unsigned short to int.
2161 (lisp_data_to_selection_data): Don't assume that integers
2162 in the range -65535 through -1 fit in an X unsigned short.
2163 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2164 result parameters unless successful. Rely on cons_to_unsigned
2165 to report problems with elements; the old code wasn't right anyway.
2166 (x_check_property_data): Check for int overflow; we cannot use
2167 a wider type due to X limits.
2168 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2169
726e0ab1 2170 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2171
0065d054
PE
2172 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2173 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2174 (x_color_cells): Don't store size until memory allocation succeeds.
2175 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2176 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2177 (x_term_init): Don't assume length fits in int (sprintf is limited
2178 to int size).
bc18e09d 2179
ebfa62c0
PE
2180 Use ptrdiff_t for composition IDs.
2181 * character.c (lisp_string_width):
2182 * composite.c (composition_table_size, n_compositions)
2183 (get_composition_id, composition_gstring_from_id):
2184 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2185 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2186 * window.c (Frecenter):
2187 Use ptrdiff_t, not int, for composition IDs.
2188 * composite.c (get_composition_id): Check for integer overflow.
2189 * composite.h: Adjust prototypes to match the above changes.
2190
d3411f89
PE
2191 Use ptrdiff_t for hash table indexes.
2192 * category.c (hash_get_category_set):
2193 * ccl.c (ccl_driver):
2194 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2195 * coding.c (coding_system_charset_list, detect_coding_system):
2196 * coding.h (struct coding_system.id):
2197 * composite.c (get_composition_id, gstring_lookup_cache):
2198 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2199 * image.c (xpm_get_color_table_h):
2200 * lisp.h (hash_lookup, hash_put):
2201 * minibuf.c (Ftest_completion):
2202 Use ptrdiff_t for hash table indexes, not int (which is too
2203 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2204 32-bit --with-wide-int hosts).
2205
e097a6fa
PE
2206 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2207 Add a FIXME comment about memory leaks.
2208 (syms_of_charset): Don't assume xmalloc returns.
2209
5637687f
PE
2210 Don't assume that stated character widths fit in int.
2211 * character.c (Fchar_width, c_string_width, lisp_string_width):
2212 * character.h (CHAR_WIDTH):
2213 * indent.c (MULTIBYTE_BYTES_WIDTH):
2214 Use sanitize_char_width to avoid undefined and/or bad behavior
2215 with outlandish widths.
a66cfb1c 2216 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2217 now that we have two such functions. All uses changed.
2218 (sanitize_char_width): New inline function.
2219
a2271ba2
PE
2220 Don't assume that tab-width fits in int.
2221 * character.h (sanitize_width): New inline function.
2222 (SANE_TAB_WIDTH): New macro.
2223 (ASCII_CHAR_WIDTH): Use it.
2224 * indent.c (sane_tab_width): Remove. All uses replaced by
2225 SANE_TAB_WIDTH (current_buffer).
2226 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2227
18c52557
PE
2228 * fileio.c: Integer overflow issues with file modes.
2229 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2230
caeeedc1
PE
2231 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2232 Remove unreachable code.
2233 (read_hex, load_charset_map_from_file): Check for integer overflow.
2234
50849c52
PE
2235 * xterm.c: don't go over XClientMessageEvent limit
2236 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2237 (x_send_scroll_bar_event): Likewise. Check that the size does not
2238 exceed limits imposed by XClientMessageEvent, as well as the usual
2239 ptrdiff_t and size_t limits.
2240
b13995db
PE
2241 * keyboard.c: Overflow, signedness and related fixes.
2242 (make_lispy_movement): Use same integer type in forward decl
2243 that is used in the definition.
2244 (read_key_sequence, keyremap_step):
2245 Change bufsize argument back to int, undoing my 2011-03-30 change.
2246 We prefer signed types, and int is wide enough here.
2247 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2248 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2249 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2250 length, not size_t. Use ptrdiff_t for index, not int.
2251 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2252 possibility of integer overflow.
2253
13464394
PE
2254 Overflow, signedness and related fixes for images.
2255
2256 * dispextern.h (struct it.stack[0].u.image.image_id)
2257 (struct_it.image_id, struct image.id, struct image_cache.size)
2258 (struct image_cache.used, struct image_cache.ref_count):
2259 * gtkutil.c (update_frame_tool_bar):
2260 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2261 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2262 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2263 * nsmenu.m (update_frame_tool_bar):
2264 * xdisp.c (calc_pixel_width_or_height):
2265 * xfns.c (image_cache_refcount):
2266 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2267 on typical 64-bit hosts.
2268
2269 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2270 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2271 Omit unnecessary casts to int.
2272 (parse_image_spec): Check that integers fall into 'int' range
2273 when the callers expect that.
2274 (image_ascent): Redo ascent calculation to avoid int overflow.
2275 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2276 (lookup_image): Remove unnecessary tests.
2277 (xbm_image_p): Locals are now of int, not EMACS_INT,
2278 since parse_image_check makes sure they fit into int.
2279 (png_load, gif_load, svg_load_image):
2280 Prefer int to unsigned where either will do.
2281 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2282 old tiff_error_handler and tiff_warning_handler.
2283 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2284 stack buffer overflows. It uses only the features of vsnprintf
2285 that are common to both POSIX and native Microsoft.
2286 (tiff_error_handler, tiff_warning_handler): Use it.
2287 (tiff_load, gif_load, imagemagick_load_image):
2288 Don't assume :index value fits in 'int'.
2289 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2290 (imagemagick_load_image): Check that crop parameters fit into
2291 the integer types that MagickCropImage accepts. Don't assume
2292 Vimagemagick_render_type has a nonnegative value. Don't assume
2293 size_t fits in 'long'.
2294 (gs_load): Use printmax_t to print the widest integers possible.
2295 Check for integer overflow when computing image height and width.
2296
c11821d4
EZ
22972011-08-26 Eli Zaretskii <eliz@gnu.org>
2298
2299 * xdisp.c (redisplay_window): Don't force window start if point
2300 will be invisible in the resulting window. (Bug#9324)
2301
0c95fcf7
EZ
23022011-08-25 Eli Zaretskii <eliz@gnu.org>
2303
2304 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2305 the display spec is of the form `(space ...)'.
2306 (handle_display_spec): Return the value returned by
2307 handle_single_display_spec, not just 1 or zero.
2308 (handle_single_display_spec): If the display spec is of the form
2309 `(space ...)', and specifies display in the text area, return 2
2310 rather than 1.
fee65a97 2311 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2312 accurately, and prefer exact match for point under bidi.
2313 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2314
2315 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2316 into disp_prop; all users changed.
2317
2318 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2319 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2320 for the text covered by the display property.
2321
e4ed06f1
CY
23222011-08-25 Chong Yidong <cyd@stupidchicken.com>
2323
2324 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2325 Change return value to nil.
2326 (Frecord_buffer): Delete unused function.
2327
f67cdd7f
EZ
23282011-08-24 Eli Zaretskii <eliz@gnu.org>
2329
5980d4c6
EZ
2330 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2331 buffers, return left-to-right.
8610fe8b
EZ
2332 (set_cursor_from_row): Consider candidate row a win if its glyph
2333 represents a newline and point is on that newline. Fixes cursor
2334 positioning on the newline at EOL of R2L text within L2R
2335 paragraph, and vice versa.
2336 (try_cursor_movement): Check continued rows, in addition to
2337 continuation rows. Fixes unwarranted scroll when point enters a
2338 continued line of R2L text within an L2R paragraph, or vice versa.
2339 (cursor_row_p): Consider the case of point being equal to
2340 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2341 from the end of a short line to the beginning of a continued line
2342 of R2L text within L2R paragraph.
2343 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2344 composed characters.
5980d4c6 2345
f67cdd7f
EZ
2346 * bidi.c (bidi_check_type): Use xassert.
2347 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2348 members.
2349
bca633fb
EZ
23502011-08-23 Eli Zaretskii <eliz@gnu.org>
2351
2352 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2353 a character.
2354
4a5885a7
CY
23552011-08-23 Chong Yidong <cyd@stupidchicken.com>
2356
2357 * nsfont.m (ns_otf_to_script): Fix typo.
2358
0902a04e
KH
23592011-08-22 Kenichi Handa <handa@m17n.org>
2360
2361 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2362 extra slot even if the purpose is char-code-property-table.
2363
1a2e6670
EZ
23642011-08-23 Eli Zaretskii <eliz@gnu.org>
2365
8ddde651
EZ
2366 * xdisp.c (redisplay_window): When computing centering_position,
2367 account for the height of the header line. (Bug#8874)
2368
425cc014
EZ
2369 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2370 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2371 candidate is selected by the mouse, and that candidate has a
2372 composed character under the mouse.
2373
1a2e6670
EZ
2374 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2375 coordinates reported by pos-visible-in-window-p for a composed
2376 character in column zero.
2377
8b76d6f8
SM
23782011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2379
2380 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2381
dac347dd
EZ
23822011-08-22 Eli Zaretskii <eliz@gnu.org>
2383
2384 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2385 consider it a hit if to_charpos is anywhere in the range of the
2386 composed buffer positions.
2387
e013fb34
CY
23882011-08-22 Chong Yidong <cyd@stupidchicken.com>
2389
2390 * image.c (gif_load): Don't assume that each subimage has the same
2391 dimensions as the base image. Handle disposal method that is
2392 "undefined" by the gif spec (Bug#9335).
2393
bd1ba3e8
CY
23942011-08-20 Chong Yidong <cyd@stupidchicken.com>
2395
2396 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2397 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2398
54a1215b
EZ
23992011-08-19 Eli Zaretskii <eliz@gnu.org>
2400
823564e5
EZ
2401 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2402 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2403 from an Org mode buffer to a Speedbar frame.
2404
54a1215b
EZ
2405 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2406 a composition, take its buffer position from IT->cmp_it.charpos.
2407 Fixes cursor positioning at the beginning of a line that begins
2408 with a composed character.
2409
9778ebcc
EZ
24102011-08-18 Eli Zaretskii <eliz@gnu.org>
2411
0be6ee06
EZ
2412 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2413 character bidirectional type, use STRONG_L instead. Fixes crashes
2414 in a buffer produced by `describe-categories'.
2415
9778ebcc
EZ
2416 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2417 members before the level stack, so they would be saved and
2418 restored when copying iterator state. Fixes incorrect reordering
2419 around TABs covered by display properties.
2420
156bffbe
AS
24212011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2422
6b02f655 2423 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2424
72ad093b
CY
24252011-08-17 Chong Yidong <cyd@stupidchicken.com>
2426
2427 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2428 (internal_condition_case_2, internal_condition_case_n):
2429 Remove unnecessary aborts (Bug#9081).
72ad093b 2430
35774242
EZ
24312011-08-17 Eli Zaretskii <eliz@gnu.org>
2432
2433 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2434 has no `load' handler, try opening the file locally. (Bug#9311)
2435
db76dd85
KB
24362011-08-16 Ken Brown <kbrown@cornell.edu>
2437
2438 * gmalloc.c: Expand comment.
2439
b215eee5
EZ
24402011-08-16 Eli Zaretskii <eliz@gnu.org>
2441
2442 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2443 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2444
a4579d33
KB
24452011-08-16 Ken Brown <kbrown@cornell.edu>
2446
2447 Fix memory allocation problems in Cygwin build (Bug#9273).
2448
2449 * unexcw.c ( __malloc_initialized): Declare external variable.
2450 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2451
8b76d6f8
SM
2452 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2453 New variables.
a4579d33
KB
2454 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2455 dumped emacs.
2456 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2457 in the static heap.
2458 [CYGWIN] (special_realloc): New function.
2459 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2460 requests to realloc storage in the static heap.
2461
3ebec551
PE
24622011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 * bidi.c (bidi_initialize): Remove unused local.
2465
9fd8be00
EZ
24662011-08-15 Eli Zaretskii <eliz@gnu.org>
2467
6b02f655
SM
2468 * bidimirror.h:
2469 * biditype.h: Remove file.
2470 * makefile.w32-in ($(BLD)/bidi.$(O)):
2471 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2472
2473 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2474
2475 * chartab.c: Improve commentary for the uniprop_table API.
2476
32413314
EZ
2477 * bidi.c (bidi_paragraph_init): Support zero value of
2478 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2479 (bidi_initialize): Use uniprop_table instead of including
2480 biditype.h and bidimirror.h.
32413314 2481
9fd8be00
EZ
2482 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2483 coordinates of the iterator when restoring from ppos_it.
2484 (Bug#9296)
2485
5cf2b69b
KH
24862011-08-14 Kenichi Handa <handa@m17n.org>
2487
2488 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2489 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2490
daf17d00
EZ
24912011-08-14 Eli Zaretskii <eliz@gnu.org>
2492
2493 * xdisp.c (move_it_in_display_line_to): Don't invoke
2494 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2495 ppos_it. Fixes vertical cursor motion when line beginning is
2496 covered by an image. (Bug#9296)
2497
08e3161a
JD
24982011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2499
2500 * nsterm.h (ns_run_ascript): Declare.
2501 (NSAPP_DATA2_RUNASSCRIPT): Define.
2502
2503 * nsfns.m (as_script, as_result, as_status): New static variables.
2504 (ns_run_ascript): New function.
5e617bc2 2505 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2506 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2507 the event loop. Get status from as_status (Bug#7276).
2508
2509 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2510 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2511 the event loop (Bug#7276).
2512
a3720aa2
AS
25132011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2514
2515 * gnutls.c (QCgnutls_bootprop_priority)
2516 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2517 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2518 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2519 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2520 (QCgnutls_bootprop_verify_hostname_error)
2521 (QCgnutls_bootprop_callbacks_verify): Rename from
2522 Qgnutls_bootprop_..., all uses changed.
2523
2524 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2525 uses changed.
2526
0a0d27fb
PE
25272011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2528
19d5c50c
PE
2529 * xfaces.c (Qframe_set_background_mode): Now static.
2530 * dispextern.h (Qframe_set_background_mode): Remove decl.
2531
0a0d27fb
PE
2532 * process.c (Fnetwork_interface_info): Declare local only if needed.
2533
377538cb
JD
25342011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2535
2536 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2537 (Fnetwork_interface_list): Allocate in increments of bytes instead
2538 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2539 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2540 sockaddr.
2541 (struct ifflag_def): notrailers is smart on OSX.
2542 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2543 Get hardware address with getifaddrs if available.
2544
08fff70c
EZ
25452011-08-12 Eli Zaretskii <eliz@gnu.org>
2546
2547 * xdisp.c (iterate_out_of_display_property): xassert that
2548 IT->position is set to within IT->object's boundaries. Break from
2549 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2550 when IT->position is set up wrongly due to some bug.
2551 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2552 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2553 entry. Force push_it to save on the stack the current
2554 buffer/string position, to be restored by pop_it. Fix flags in
2555 the iterator structure wrt the object coming from a display
2556 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2557 properties. (Bug#9284)
2558
7be1c708 25592011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2560
7be1c708
CY
2561 * fontset.c (fontset_get_font_group): Add proper type checks.
2562 (Bug#9172)
aac0c6e3 2563
7be1c708 25642011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2565
7be1c708
CY
2566 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2567 and LC_VERSION_MIN_MACOSX.
2568 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2569 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2570
97bb72a6
EZ
25712011-08-08 Eli Zaretskii <eliz@gnu.org>
2572
2573 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2574 no-display-properties-and-no-overlays under bidi display.
2575 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2576 properties and overlays.
97bb72a6 2577
d5617611
CY
25782011-08-08 Chong Yidong <cyd@stupidchicken.com>
2579
37e11a63
CY
2580 * editfns.c (Fset_time_zone_rule): Document relationship with the
2581 setenv function.
2582
d5617611
CY
2583 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2584 the font entity extracted from the cache (Bug#8109).
2585
58872834
CY
25862011-08-07 Chong Yidong <cyd@stupidchicken.com>
2587
2588 * composite.c (autocmp_chars): Don't reset point. That is done by
2589 restore_point_unwind (Bug#5984).
2590
75bfc667
JL
25912011-08-07 Juri Linkov <juri@jurta.org>
2592
2593 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2594 to show the arg `TIME' instead of `TIMEVAL'.
2595
d1410150
EZ
25962011-08-06 Eli Zaretskii <eliz@gnu.org>
2597
2598 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2599 display property strides EOL and includes a newline, as in
2600 longlines-mode. (Bug#9254)
75b771e4
EZ
2601 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2602 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2603
2604 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2605 is non-zero, even if the data buffer is NULL. Fixes a crash in
2606 vertical-motion with longlines-mode. (Bug#9254)
2607
35928349
EZ
26082011-08-05 Eli Zaretskii <eliz@gnu.org>
2609
ec7cc85b
EZ
2610 * bidi.c <bidi_cache_total_alloc>: Now static.
2611 (bidi_initialize): Initialize bidi_cache_total_alloc.
2612
8b76d6f8 2613 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2614 cache. (Bug#9221)
2615
2616 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2617 amount allocated this far in `bidi_cache_total_alloc'.
2618 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2619 non-zero, only free the data buffer without restoring the cache
2620 contents. All callers changed.
2621
2622 * dispextern.h (bidi_unshelve_cache): Update prototype.
2623
2624 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2625 (move_it_in_display_line, move_it_to)
2626 (move_it_vertically_backward, move_it_by_lines): Replace the call
2627 to xfree to an equivalent call to bidi_unshelve_cache.
2628 (move_it_in_display_line_to): Fix logic of returning
412b6358 2629 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2630
e2e2423b
EZ
26312011-08-05 Eli Zaretskii <eliz@gnu.org>
2632
2633 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2634 came from a string character with a `cursor' property. (Bug#9229)
2635
ae9e757a
JD
26362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2637
2638 * Makefile.in (LIB_PTHREAD): New variable.
2639 (LIBES): Add LIB_PTHREAD (Bug#9216).
2640
2641 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2642 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2643
213bd7f2
AS
26442011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2645
6b02f655 2646 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2647
99aaf75f
JD
26482011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2649
2650 * xterm.c (x_find_topmost_parent): New function.
2651 (x_set_frame_alpha): Find topmost parent window with
2652 x_find_topmost_parent and set the property there also (bug#9181).
2653 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2654
c74e9d86
PE
26552011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2656
2657 * callproc.c (Fcall_process): Avoid vfork clobbering
2658 the local vars buffer, coding_systems, current_dir.
2659
640c8776
SM
26602011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2661
2662 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2663
f26d0e4c
PE
26642011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2665
8a10d76c
PE
2666 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2667 so that it is not optimized away.
2668
f26d0e4c
PE
2669 * xdisp.c (compute_display_string_pos): Remove unused local.
2670
55439c61
EZ
26712011-08-02 Eli Zaretskii <eliz@gnu.org>
2672
2673 Fix slow cursor motion and scrolling in large buffers with
2674 selective display, like Org Mode buffers. (Bug#9218)
2675
2676 * dispextern.h (struct bidi_it): New member disp_prop_p.
2677
2678 * xdisp.c: Remove one-slot cache of display string positions.
2679 (compute_display_string_pos): Accept an additional argument
5e617bc2 2680 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2681 for a display string or property. If found, set DISP_PROP_P
2682 non-zero.
2683
2684 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2685 DISP_PROP_P, and pass it to compute_display_string_pos.
2686 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2687 non-zero. All callers of bidi_fetch_char changed.
2688
fb33fa43
SM
26892011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2690
2691 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2692
b099e063
DM
26932010-12-03 Don March <don@ohspite.net>
2694
2695 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2696 last character M-[char] is translated to ESC [char] (bug#7541).
2697
5cc7f7af
KH
26982011-08-02 Kenichi Handa <handa@m17n.org>
2699
d0fffa3f 2700 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2701
2702 * chartab.c (uniprop_table): Make it non-static.
2703
525d5e6e
EZ
27042011-08-01 Eli Zaretskii <eliz@gnu.org>
2705
2706 * xdisp.c (forward_to_next_line_start): Accept additional argument
2707 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2708 on the newline.
2709 (reseat_at_next_visible_line_start): Use the bidi iterator state
2710 returned by forward_to_next_line_start to restore the state of
2711 it->bidi_it after backing up to previous newline. (Bug#9212)
2712
31011111
AS
27132011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2714
2715 * regex.c (re_comp): Protoize.
2716 (re_exec): Fix return type.
2717 (regexec): Fix type of `ret'. (Bug#9203)
2718
476371c4
PE
27192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2720
e5d76069
PE
2721 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2722 This is needed if max-image-size is a floating-point number.
2723
9a79b20c
AS
27242011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2725
2726 * print.c (print_object): Print empty symbol as ##.
2727
2728 * lread.c (read1): Read ## as empty symbol.
2729
d8c2fa78
AA
27302011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2731
2732 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2733 setting frame foreground color (Bug#9175).
2734 (x_set_background_color): Likewise.
2735
ffe57a7a
AA
2736 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2737 contents (Bug#9176).
2738 (EmacsTooltip -init): Remove bezels and add shadows to
2739 tooltip windows.
2740
bf3492a5
AA
2741 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2742 or scroll bar (Bug#8470).
2743
d55e9c53
AA
2744 * nsfont.m (nsfont_open): Remove assignment to voffset and
2745 unnecessary vars hshink, expand, hd, full_height, min_height.
2746 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2747
2748 * nsterm.h (nsfont_info): Remove voffset field.
2749
d8c2fa78 27502011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2751
2752 Implement strike-through and overline on NextStep (Bug#8863).
2753
2754 * nsfont.m (nsfont_open): Use underline position provided by font,
2755 instead of hard-coded value of 2.
2756 (nsfont_draw): Call ns_draw_text_decoration instead.
2757
2758 * nsterm.h: Add declaration for ns_draw_text_decoration.
2759
2760 * nsterm.m (ns_draw_text_decoration): New function for drawing
2761 underline, overline, and strike-through.
2762 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2763 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2764 accommodate underlining, etc.
4843aac3 2765
4cc60b9b
EZ
27662011-07-28 Eli Zaretskii <eliz@gnu.org>
2767
bc7ece87
EZ
2768 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2769 default.
4cc60b9b 2770
476371c4
PE
27712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2772
66606eea
PE
2773 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2774 Without this fix, if a signal arrives just after memory fills up,
2775 'malloc' might be invoked reentrantly.
2776
476371c4
PE
2777 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2778 In other words, assume that every image size is allowed, on non-X
2779 hosts. This assumption is probably wrong, but it lets Emacs compile.
2780
f3fcc40d
AS
27812011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2782
2783 * regex.c (re_iswctype): Convert return values to boolean.
2784
350c992f
EZ
27852011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2786
2787 * xdisp.c (compute_display_string_pos): Don't use cached display
2788 string position if the buffer had its restriction changed.
2789 (Bug#9184)
2790
5266b4bb
PE
27912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2794
2573a837 27952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2796
41f55ccd 2797 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2798
39e378da
PE
2799 * bidi.c: Integer size and overflow fixes.
2800 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2801 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2802 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2803 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2804 (bidi_find_other_level_edge):
2805 Use ptrdiff_t instead of EMACS_INT where either will do.
2806 This works better on 32-bit hosts configured --with-wide-int.
2807 (bidi_cache_ensure_space): Check for size-calculation overflow.
2808 Use % rather than repeated addition, for better worst-case speed.
2809 Don't set bidi_cache_size until after xrealloc returns, because it
2810 might not return.
2811 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2812 (bidi_cache_ensure_space): Also check that the bidi cache size
2813 does not exceed that of the largest Lisp string or buffer. See Eli
2814 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2815
5e927815
PE
2816 * alloc.c (__malloc_size_t): Remove.
2817 All uses replaced by size_t. See Andreas Schwab's note
2818 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2819
ca4aa935
PE
2820 * image.c: Improve checking for integer overflow.
2821 (check_image_size): Assume that f is nonnull, since
2822 it is always nonnull in practice. This is one less thing to
2823 worry about when checking for integer overflow later.
2824 (x_check_image_size): New function, which checks for integer
2825 overflow issues inside X.
2826 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2827 This removes the need for a memory_full check.
2828 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2829 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2830 (xbm_read_bitmap_data): Change locals back to 'int', since
2831 their values must fit in 'int'.
2832 (xpm_load_image, png_load, tiff_load):
2833 Invoke x_create_x_image_and_pixmap earlier,
2834 to avoid much needless work if the image is too large.
2835 (tiff_load): Treat overly large images as if
2836 x_create_x_image_and_pixmap failed, not as malloc failures.
2837 (gs_load): Use x_check_image_size.
2838
5f8f9cc2
PE
2839 * gtkutil.c: Omit integer casts.
2840 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2841 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2842
5adf60bc
PE
2843 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2844
c8907a93
PE
2845 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2846 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2847 would wrongly return t on a 64-bit host.
2848
e3c25c68
PE
2849 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2850 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2851 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2852 and therefore cause GCC to emit a bogus diagnostic in some cases.
2853
3f791afe
PE
2854 * image.c: Integer signedness and overflow and related fixes.
2855 This is not an exhaustive set of fixes, but it's time to
2856 record what I've got.
2857 (lookup_pixel_color, check_image_size): Remove redundant decls.
2858 (check_image_size): Don't assume that arbitrary EMACS_INT values
2859 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2860 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2861 (tiff_load, imagemagick_load_image):
2862 Check for overflow in size calculations.
2863 (x_create_x_image_and_pixmap): Remove unnecessary test for
2864 xmalloc returning NULL; that can't happen.
2865 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2866 (xpm_color_bucket): Use better integer hashing function.
2867 (xpm_cache_color): Don't possibly over-allocate memory.
2868 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2869 (gif_memory_source):
2870 Use ptrdiff_t, not int or size_t, to record sizes.
2871 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2872 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2873 either works, as we prefer signed integers.
2874 (tiff_read_from_memory, tiff_write_from_memory):
2875 Return tsize_t, not size_t, since that's what the TIFF API wants.
2876 (tiff_read_from_memory): Don't fail simply because the read would
2877 go past EOF; instead, return a short read.
2878 (tiff_load): Omit no-longer-needed casts.
2879 (Fimagemagick_types): Don't assume size fits into 'int'.
2880
3cc5a532
PE
2881 Improve hashing quality when configured --with-wide-int.
2882 * fns.c (hash_string): New function, taken from sxhash_string.
2883 Do not discard information about ASCII character case; this
2884 discarding is no longer needed.
2885 (sxhash-string): Use it. Change sig to match it. Caller changed.
2886 * lisp.h: Declare it.
2887 * lread.c (hash_string): Remove, since we now use fns.c's version.
2888 The fns.c version returns a wider integer if --with-wide-int is
2889 specified, so this should help the quality of the hashing a bit.
2890
b312a492
PE
2891 * emacs.c: Integer overflow minor fix.
2892 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2893 Define only if GNU_LINUX.
2894 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2895
dfd153ae
PE
2896 * dispnew.c: Integer signedness and overflow fixes.
2897 Remove unnecessary forward decls, that were a maintenance hassle.
2898 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2899 All uses changed.
2900 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2901 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2902 (prepare_desired_row, line_draw_cost):
2903 Use int, not unsigned, where either works.
2904 (save_current_matrix, restore_current_matrix):
2905 Use ptrdiff_t, not size_t, where either works.
2906 (init_display): Check for overflow more accurately, and without
2907 relying on undefined behavior.
2908
a81d11a3
PE
2909 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2910 Remove, replacing with the new symbols in lisp.h. All uses changed.
2911 * fileio.c (make_temp_name):
2912 * filelock.c (lock_file_1, lock_file):
2913 * xdisp.c (message_dolog):
2914 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2915 Use pMd etc. instead.
2916 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2917 replacing the pWIDE etc. symbols removed from editfns.c.
2918
3300e6fd
PE
2919 * keyboard.h (num_input_events): Now uintmax_t.
2920 This is (very slightly) less likely to mess up due to wraparound.
2921 All uses changed.
2922
fd05c7e9
PE
2923 * buffer.c: Integer signedness fixes.
2924 (alloc_buffer_text, enlarge_buffer_text):
2925 Use ptrdiff_t rather than size_t when either will do, as we prefer
2926 signed integers.
2927
903fe15d
PE
2928 * alloc.c: Integer signedness and overflow fixes.
2929 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2930 (__malloc_size_t): Default to size_t, not to int.
2931 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2932 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2933 Prefer ptrdiff_t to size_t when either would do, as we prefer
2934 signed integers.
2935 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2936 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2937 Now const. Initialize with values that are in range even if char
2938 is signed.
2939 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2940 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2941 These functions do the right thing with sizes > 2**32.
2942 (check_depth): Now ptrdiff_t, not int.
2943 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2944 Adjust to new way of storing sizes. Check for size overflow bugs
2945 in rest of code.
2946 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2947 slightly wrong anyway, as it missed one instance of
2948 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2949 (refill_memory_reserve): Omit needless cast to size_t.
2950 (mark_object_loop_halt): Mark as externally visible.
2951
ac82cc6a
PE
2952 * xselect.c: Integer signedness and overflow fixes.
2953 (Fx_register_dnd_atom, x_handle_dnd_message):
2954 Use ptrdiff_t, not size_t, since we prefer signed.
2955 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2956 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2957 x_dnd_atoms_size and x_dnd_atoms_length.
2958
c2d1e36d
PE
2959 * doprnt.c: Prefer signed to unsigned when either works.
2960 * eval.c (verror):
2961 * doprnt.c (doprnt):
2962 * lisp.h (doprnt):
2963 * xdisp.c (vmessage):
2964 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2965 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2966 prefer signed arithmetic to avoid comparison confusion.
2967 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2968 but is a bit tricky.
2969
0e926e56
PE
2970 Assume freestanding C89 headers, string.h, stdlib.h.
2971 * data.c, doprnt.c, floatfns.c, print.c:
2972 Include float.h unconditionally.
2973 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2974 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2975 * regex.c: Likewise for stddef.h, string.h.
2976 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2977 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2978 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2979 (STDC_HEADERS): Remove obsolete defines.
2980 * sysdep.c: Include limits.h unconditionally.
2981
9cfdb3ec
PE
2982 Assume support for memcmp, memcpy, memmove, memset.
2983 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2984 * regex.c (memcmp, memcpy):
2985 Remove; we assume C89 now.
2986
2987 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2988 (__malloc_safe_bcopy): Remove; no longer needed.
2989
cf950e6b 2990 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2991 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2992 well either way, and we prefer signed to unsigned.
2993
dbf38e02
LMI
29942011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2995
2996 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2997 closes the connection while we're reading (bug#9182).
2998
d6f0886c 29992011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3000
d6f0886c
JD
3001 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3002 are specified (Bug#9168).
24e0f6b1 3003
2eb1f9e6
PE
30042011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3005
3006 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3007 Found by GCC static checking and --with-wide-int on a 32-bit host.
3008
22381272 30092011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3010
3011 * xdisp.c (compute_display_string_pos): Fix logic of caching
3012 previous display string position. Initialize cached_prev_pos to
3013 -1. Fixes slow-down at the beginning of a buffer.
3014
f25e39b4
EZ
30152011-07-24 Eli Zaretskii <eliz@gnu.org>
3016
3017 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3018 for attrs[LFACE_FONTSET_INDEX].
3019
04c4b52e
PE
30202011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3021
3022 * xml.c (parse_region): Remove unused local
3023 that was recently introduced.
3024
c1734fbd
EZ
30252011-07-23 Eli Zaretskii <eliz@gnu.org>
3026
be18c5a5
EZ
3027 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3028 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3029
c1734fbd
EZ
3030 * xdisp.c (move_it_in_display_line_to): Record the best matching
3031 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3032 exit if none of the characters scanned was an exact match.
3033 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3034 when exact match is impossible due to invisible text, and the
3035 lines are truncated.
3036
a258d627
JD
30372011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3038
3039 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3040 for OSX >= 10.7.
3041
b6d5a689
EZ
30422011-07-22 Eli Zaretskii <eliz@gnu.org>
3043
0f74f785
EZ
3044 Fix a significant slow-down of cursor motion with C-n, C-p,
3045 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3046 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3047 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3048 (next_element_from_buffer): Call compute_stop_pos_backwards to
3049 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3050 base_level_stop.
3051 (reseat): Don't look for prev_stop, as that could mean a very long
3052 run.
3053 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3054 <cached_disp_overlay_modiff>: Cache for last found display string
3055 position.
551918c1 3056 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3057 about the same buffer in the same area of character positions, and
3058 the buffer wasn't changed since the time the display string
3059 position was cached.
551918c1 3060
b2d0c91a
EZ
30612011-07-22 Eli Zaretskii <eliz@gnu.org>
3062
3063 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3064 is an integer, which is important for empty lines. (Bug#9149)
3065
043604ee
CY
30662011-07-22 Chong Yidong <cyd@stupidchicken.com>
3067
3068 * frame.c (Fmodify_frame_parameters): In tty case, update the
3069 default face if necessary (Bug#4238).
3070
da4adb04
CY
30712011-07-21 Chong Yidong <cyd@stupidchicken.com>
3072
3073 * editfns.c (Fstring_to_char): No need to explain what a character
3074 is in the docstring (Bug#6576).
3075
9abd0532
LMI
30762011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3077
3078 * xml.c (parse_region): Make sure we always return a tree.
3079
36881d16
HK
30802011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3081
3082 * xml.c (parse_region): If a document contains only comments,
3083 return that, too.
3084
1e98674d
LMI
30852011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3086
3087 * xml.c (make_dom): Return comments, too.
3088
590bd467
PE
30892011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3090
3091 Port to OpenBSD.
3092 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3093 and the surrounding thread.
3094 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3095 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3096 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3097 timer goes off.
3098 * s/openbsd.h (BROKEN_SIGIO): Define.
3099 * unexelf.c (unexec) [__OpenBSD__]:
3100 Don't update the .mdebug section of the Alpha COFF symbol table.
3101
f41628b2
LMI
31022011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3103
3104 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3105 (bug#8460).
3106
b59b67c5
PE
31072011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3108
15e3a074
PE
3109 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3110 This fixes some race conditions on the permissions of any newly
3111 created file.
3112
41bed37d
PE
3113 * alloc.c (valid_pointer_p): Use pipe, not open.
3114 This fixes some permissions issues when debugging.
3115
b59b67c5
PE
3116 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3117 If fchown fails to set both uid and gid, try to set just gid,
3118 as that is sometimes allowed. Adjust the file's mode to eliminate
3119 setuid or setgid bits that are inappropriate if fchown fails.
3120
925a6be7
SM
31212011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3122
3123 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3124 to compare Lisp_Objects.
3125 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3126 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3127 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3128
52968808
AS
31292011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3130
0a6a104b
AS
3131 * lread.c (read_integer): Unread even EOF character.
3132 (read1): Likewise. Properly record start position of symbol.
3133
52968808
AS
3134 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3135 symbol character follows.
3136
9e381cdd
PE
31372011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3138
3139 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3140 This works around a problem with the previous change to Fcopy_file.
3141 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3142 and without this change, GCC might complain about discarding
3143 fchown's return value.
3144
b5641435
JB
31452011-07-16 Juanma Barranquero <lekktu@gmail.com>
3146
3147 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3148
a8031457
PE
31492011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3150
3151 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3152
dd889327
LMI
31532011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3154
750c33f7
LMI
3155 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3156 it's used from the C level.
3157
dd889327
LMI
3158 * process.c: Use the same condition for POLL_FOR_INPUT in both
3159 keyboard.c and process.c (bug#1858).
3160
87e86684
LM
31612011-07-09 Lawrence Mitchell <wence@gmx.li>
3162
3163 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3164 (Fgnutls_boot): Use it.
3165
64348f40
AS
31662011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3167
3168 * doc.c (Fsubstitute_command_keys): Revert last change.
3169
1d698799
LMI
31702011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3171
f863868c
LMI
3172 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3173 quotes the next character, and doesn't affect other longer
3174 sequences (bug#8935).
3175
1d698799
LMI
3176 * lread.c (syms_of_lread): Clarify that is isn't only
3177 `eval-buffer' and `eval-defun' that's affected by
3178 `lexical-binding' (bug#8460).
3179
aa4b6df6
EZ
31802011-07-15 Eli Zaretskii <eliz@gnu.org>
3181
3182 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3183 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3184
5d856da6
PE
31852011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3186
ad6042bb
PE
3187 Fix minor problems found by static checking.
3188 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3189 (elsz): Now a signed constant, not a size_t var. We prefer signed
3190 types to unsigned, to avoid integer comparison confusion. Without
3191 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3192 "cannot optimize loop, the loop counter may overflow", a symptom
3193 of the confusion.
f00bbb22 3194 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3195 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3196
6468f31c
LMI
31972011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3198
49080b10
LMI
3199 * search.c (Fre_search_backward): Mention `case-fold-search' in
3200 all the re_search_* functions (bug#8138).
3201
6468f31c
LMI
3202 * keyboard.c (Fopen_dribble_file): Document when the file is
3203 closed (bug#8056).
3204
c965adc5
EZ
32052011-07-14 Eli Zaretskii <eliz@gnu.org>
3206
df9733bf
EZ
3207 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3208 bidi_cache_idx.
3209
0bb23927
EZ
3210 Support bidi reordering of display and overlay strings.
3211 * xdisp.c (compute_display_string_pos)
3212 (compute_display_string_end): Accept additional argument STRING.
3213 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3214 (reseat_to_string): Initialize bidi_it->string.s and
3215 bidi_it->string.schars.
3216 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3217 NULL (avoids a crash in bidi_paragraph_init).
3218 Initialize itb.string.lstring.
0bb23927
EZ
3219 (init_iterator): Call bidi_init_it only of a valid
3220 buffer position was specified. Initialize paragraph_embedding to
3221 L2R.
3222 (reseat_to_string): Initialize the bidi iterator.
3223 (display_string): If we need to ignore text properties of
3224 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3225 original value of -1 will not work with bidi.)
3226 (compute_display_string_pos): First arg is now struct
3227 `text_pos *'; all callers changed. Support display properties on
3228 Lisp strings.
3229 (compute_display_string_end): Support display properties on Lisp
3230 strings.
3231 (init_iterator, reseat_1, reseat_to_string): Initialize the
3232 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3233 when iterating on a string not from display properties).
640c8776
SM
3234 (compute_display_string_pos, compute_display_string_end):
3235 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3236 arrow keys.
3237 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3238 base_level_stop; instead, set base_level_stop to BEGV.
3239 Fixes crashes in vertical-motion.
0bb23927
EZ
3240 (next_element_from_buffer): Improve commentary for when
3241 the iterator is before prev_stop.
3242 (init_iterator): Initialize bidi_p from the default value of
3243 bidi-display-reordering, not from buffer-local value. Use the
3244 buffer-local value only if initializing for buffer iteration.
3245 (handle_invisible_prop): Support invisible properties on strings
3246 that are being bidi-reordered.
3247 (set_iterator_to_next): Support bidi reordering of C strings and
3248 Lisp strings.
3249 (next_element_from_string): Support bidi reordering of Lisp
3250 strings.
3251 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3252 (display_string): Support display of R2L glyph rows.
3253 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3254 (init_iterator): Don't initialize it->bidi_p for strings
3255 here.
3256 (reseat_to_string): Initialize it->bidi_p for strings here.
3257 (next_element_from_string, next_element_from_c_string)
3258 (next_element_from_buffer): Add xassert's for correspondence
3259 between IT's object being iterated and it->bidi_it.string
3260 structure.
3261 (face_before_or_after_it_pos): Support bidi iteration.
3262 (next_element_from_c_string): Handle the case of the first string
3263 character that is not the first one in the visual order.
3264 (get_visually_first_element): New function, refactored from common
3265 parts of next_element_from_buffer, next_element_from_string, and
3266 next_element_from_c_string.
3267 (tool_bar_lines_needed, redisplay_tool_bar)
3268 (display_menu_bar): Force left-to-right direction. Add a FIXME
3269 comment for making that be controlled by a user option.
3270 (push_it, pop_it): Save and restore the state of the
3271 bidi iterator. Save and restore the bidi_p flag.
3272 (pop_it): Iterate out of display property for string iteration as
3273 well.
3274 (iterate_out_of_display_property): Support iteration over strings.
3275 (handle_single_display_spec): Set up it->bidi_it for iteration
3276 over a display string, and call bidi_init_it.
3277 (handle_single_display_spec, next_overlay_string)
3278 (get_overlay_strings_1, push_display_prop): Set up the bidi
3279 iterator for displaying display or overlay strings.
3280 (forward_to_next_line_start): Don't use the shortcut if
3281 bidi-iterating.
3282 (back_to_previous_visible_line_start): If handle_display_prop
3283 pushed the iterator stack, restore the internal state of the bidi
3284 iterator by calling bidi_pop_it same number of times.
3285 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3286 and we are bidi-iterating, don't decrement the iterator position;
3287 instead, set the first_elt flag in the bidi iterator, to produce
3288 the same effect.
3289 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3290 (push_display_prop): xassert that we are iterating a buffer.
3291 (push_it, pop_it): Save and restore paragraph_embedding member.
3292 (handle_single_display_spec, next_overlay_string)
3293 (get_overlay_strings_1, reseat_1, reseat_to_string)
3294 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3295 correctly. Don't assume unibyte strings are not bidi-reordered.
3296 (compute_display_string_pos)
3297 (compute_display_string_end): Fix handling the case of C string.
3298 (push_it, pop_it): Save and restore from_disp_prop_p.
3299 (handle_single_display_spec, push_display_prop): Set the
3300 from_disp_prop_p flag.
3301 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3302 (pop_it): Call iterate_out_of_display_property only if we are
3303 popping after iteration over a string that came from a display
3304 property. Fix a typo in popping stretch info. Add an assertion
3305 for verifying that the iterator position is in sync with the bidi
3306 iterator.
3307 (handle_single_display_spec, get_overlay_strings_1)
3308 (push_display_prop): Fix initialization of paragraph direction for
3309 string when that of the parent object is not yet determined.
3310 (reseat_1): Call bidi_init_it to resync the bidi
3311 iterator with IT's position. (Bug#7616)
3312 (find_row_edges): If ROW->start.pos gives position
3313 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3314 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3315 Reset the from_disp_prop_p flag.
3316 (SAVE_IT, RESTORE_IT): New macros.
3317 (pos_visible_p, face_before_or_after_it_pos)
3318 (back_to_previous_visible_line_start)
3319 (move_it_in_display_line_to, move_it_in_display_line)
3320 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3321 (try_scrolling, redisplay_window, display_line): Use them when
3322 saving a temporary copy of the iterator and restoring it back.
3323 (back_to_previous_visible_line_start, reseat_1)
3324 (init_iterator): Empty the bidi cache "stack".
3325 (move_it_in_display_line_to): If iterator ended up at
3326 EOL, but we never saw any buffer positions smaller than
3327 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3328 motion in bidi-reordered lines.
3329 (move_it_in_display_line_to): Record prev_method and prev_pos
3330 immediately before the call to set_iterator_to_next. Fixes cursor
3331 motion in bidi-reordered lines with stretch glyphs and strings
3332 displayed in margins. (Bug#8133) (Bug#8867)
3333 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3334 TO_CHARPOS.
640c8776
SM
3335 (pos_visible_p): Support positions in bidi-reordered lines.
3336 Save and restore bidi cache.
0bb23927
EZ
3337
3338 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3339 (bidi_paragraph_info): Delete unused struct.
3340 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3341 (bidi_cache_start): New variable.
3342 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3343 to zero.
3344 (bidi_cache_fetch_state, bidi_cache_search)
3345 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3346 (bidi_cache_find, bidi_peek_at_next_level)
3347 (bidi_level_of_next_char, bidi_find_other_level_edge)
3348 (bidi_move_to_visually_next): Compare cache index with
3349 bidi_cache_start rather than with zero.
3350 (bidi_fetch_char): Accept new argument STRING; all callers
3351 changed. Support iteration over a string. Support strings with
3352 display properties. Support unibyte strings. Fix the type of
3353 `len' according to what STRING_CHAR_AND_LENGTH expects.
3354 (bidi_paragraph_init, bidi_resolve_explicit_1)
3355 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3356 (bidi_level_of_next_char, bidi_move_to_visually_next):
3357 Support iteration over a string.
0bb23927
EZ
3358 (bidi_set_sor_type, bidi_resolve_explicit_1)
3359 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3360 can now be zero (for strings); special values 0 and -1 were
3361 changed to -1 and -2, respectively.
3362 (bidi_char_at_pos): New function.
3363 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3364 Call it instead of FETCH_MULTIBYTE_CHAR.
3365 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3366 initialized to valid values.
3367 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3368 values.
3369 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3370 the test for valid cached positions. Fix the logic for looking up
3371 the sentinel state in the cache. GCPRO the Lisp string we are
3372 iterating.
3373 (bidi_push_it, bidi_pop_it): New functions.
3374 (bidi_initialize): Initialize the bidi cache start stack pointer.
3375 (bidi_cache_ensure_space): New function, refactored from part of
3376 bidi_cache_iterator_state. Don't assume the required size is just
3377 one BIDI_CACHE_CHUNK away.
3378 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3379 (bidi_count_bytes, bidi_char_at_pos): New functions.
3380 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3381 always valid if bidi_cache_idx is valid.
3382 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3383 is valid if it's going to be used.
3384 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3385 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3386 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3387 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3388 (bidi_find_other_level_edge, bidi_cache_start_stack):
3389 All variables related to cache indices are now EMACS_INT.
c965adc5 3390
0bb23927
EZ
3391 * dispextern.h (struct bidi_string_data): New structure.
3392 (struct bidi_it): New member `string'. Make flag members be 1-bit
3393 fields, and put them last in the struct.
640c8776
SM
3394 (compute_display_string_pos, compute_display_string_end):
3395 Update prototypes.
0bb23927
EZ
3396 (bidi_push_it, bidi_pop_it): Add prototypes.
3397 (struct iterator_stack_entry): New members bidi_p,
3398 paragraph_embedding, and from_disp_prop_p.
3399 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3400 (bidi_shelve_cache, bidi_unshelve_cache):
3401 Declare prototypes.
0bb23927
EZ
3402
3403 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3404 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3405 and vector-like objects.
3406
3407 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3408 cache around display iteration.
3409
3410 * window.c (Fwindow_end, window_scroll_pixel_based)
3411 (displayed_window_lines, Frecenter): Save and restore the bidi
3412 cache around display iteration.
3413
3bbd2265
LMI
34142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3415
3416 * editfns.c (Fdelete_region): Clarify the use of the named
3417 parameters (bug#6788).
3418
adc47434
MR
34192011-07-14 Martin Rudalics <rudalics@gmx.at>
3420
3421 * indent.c (Fvertical_motion): Set and restore w->pointm when
3422 saving and restoring the window's buffer (Bug#9006).
3423
837c31f8
LMI
34242011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3425
3426 * editfns.c (Fstring_to_char): Clarify just what is returned
3427 (bug#6576). Text by Eli Zaretskii.
3428
ac389d0c
JB
34292011-07-13 Juanma Barranquero <lekktu@gmail.com>
3430
3431 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3432
0be0ce47
EZ
34332011-07-13 Eli Zaretskii <eliz@gnu.org>
3434
3435 * buffer.c (mmap_find): Fix a typo.
3436
cd18e7e3
JB
34372011-07-13 Johan Bockgård <bojohan@gnu.org>
3438
3439 Fix execution of x selection hooks.
3440 * xselect.c (Qx_lost_selection_functions)
3441 (Qx_sent_selection_functions): New vars.
3442 (syms_of_xselect): DEFSYM them.
3443 (x_handle_selection_request): Pass Qx_sent_selection_functions
3444 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3445 (x_handle_selection_clear,x_clear_frame_selections):
3446 Pass Qx_lost_selection_functions rather than
3447 Vx_lost_selection_functions to Frun_hook_with_args.
3448
47ea7f44
PE
34492011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3450
ac389d0c 3451 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3452 The old code sometimes used this field without initializing it.
3453
47ea7f44
PE
3454 * alloc.c (gc_sweep): Don't read past end of array.
3455 In theory, the old code could also have corrupted Emacs internals,
3456 though it'd be very unlikely.
3457
bc985c87
AS
34582011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3459
3460 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3461 argument. (Bug#4026)
bc985c87 3462
0cf34688
LMI
34632011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3464
b3dadd76
LMI
3465 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3466 key" (bug#4257).
3467
0cf34688
LMI
3468 * window.c (Fset_window_start): Doc fix (bug#4199).
3469 (Fset_window_hscroll): Ditto.
3470
270768cd
PE
34712011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3472
077e3dda 3473 Fix minor new problems caught by GCC 4.6.1.
270768cd 3474 * term.c (init_tty): Remove unused local.
490011a6 3475 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3476 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3477 not used otherwise.
270768cd 3478
b1f58454
CY
34792011-07-12 Chong Yidong <cyd@stupidchicken.com>
3480
3481 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3482
22b9578d
LMI
34832011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3484
6e70ab07
LMI
3485 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3486 are the mini-buffer and the echo area (bug#3320).
3487
22b9578d
LMI
3488 * term.c (init_tty): Remove support for supdup, c10 and perq
3489 terminals, which are no longer supported (bug#1482).
3490
8974cc9f
JB
34912011-07-10 Johan Bockgård <bojohan@gnu.org>
3492
3493 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3494
a560d974
JD
34952011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3496
3497 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3498 for non-popups (Bug#3642).
3499
1dae0f0a
AS
35002011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3501
268c2c36 3502 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3503 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3504 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3505 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3506 * data.c (fmod): Likewise.
3507 * dispnew.c (swap_glyphs_in_rows): Likewise.
3508 * emacs.c (memory_warning_signal): Likewise.
3509 * floatfns.c (float_error): Likewise.
3510 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3511 (otf_open, font_otf_capability, generate_otf_features)
3512 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3513 Likewise.
3514 * image.c (pbm_read_file): Likewise.
3515 * indent.c (string_display_width): Likewise.
3516 * intervals.c (check_for_interval, search_for_interval)
3517 (inc_interval_count, count_intervals, root_interval)
3518 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3519 * lread.c (defalias): Likewise.
268c2c36 3520 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3521 * regex.c (set_image_of_range_1, set_image_of_range)
3522 (regex_grow_registers): Likewise.
3523 * sysdep.c (strerror): Likewise.
3524 * termcap.c (valid_filename_p, tprint, main): Likewise.
3525 * tparam.c (main): Likewise.
3526 * unexhp9k800.c (run_time_remap, save_data_space)
3527 (update_file_ptrs, read_header, write_header, calculate_checksum)
3528 (copy_file, copy_rest, display_header): Likewise.
3529 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3530 Likewise.
3531 * xdisp.c (check_it): Likewise.
3532 * xfaces.c (register_color, unregister_color, unregister_colors):
3533 Likewise.
3534 * xfns.c (print_fontset_result): Likewise.
3535 * xrdb.c (member, fatal, main): Likewise.
3536
99033785
PE
35372011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3538
3539 Fix minor problems found by static checking (Bug#9031).
3540 * chartab.c (char_table_set_range, map_sub_char_table):
3541 Remove unused locals.
3542 (uniprop_table): Now static.
3543 * composite.c (_work_char): Remove unused static var.
3544
9cb2ac56
JB
35452011-07-09 Juanma Barranquero <lekktu@gmail.com>
3546
3547 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3548
f25661f0
JD
35492011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3550
3551 * gtkutil.c (qttip_cb): Remove code without function.
3552
8278c4fe
EZ
35532011-07-09 Eli Zaretskii <eliz@gnu.org>
3554
3555 * w32.c (pthread_sigmask): New stub.
3556
1692ae2d 35572011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3558
8a6ebd58 3559 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3560 sigprocmask is portable only for single-threaded applications, and
3561 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3562 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3563 (LIBES): Use it.
3564 * callproc.c (Fcall_process):
3565 * process.c (create_process):
3566 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3567 Use pthread_sigmask, not sigprocmask.
123403e4 3568
1b854618
JD
35692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3570
3571 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3572 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3573 wrong (Bug#8591).
3574
3fe4b549
JD
35752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3576
0ce7e563
JD
3577 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3578 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3579 (xg_hide_tooltip): Fix comment.
3580
3fe4b549
JD
3581 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3582 in registerServicesMenuSendTypes.
3583 (validRequestorForSendType): Don't check ns_return_types.
3584
3585 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3586 ns_return_type.
3587
5df75e47
JR
35882011-07-08 Jason Rumney <jasonr@gnu.org>
3589
22610910
JR
3590 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3591 SH_SHOW for hidden windows (Bug#5482).
3592
5df75e47
JR
3593 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3594 frame struct members of non-existent frames (Bug#6284).
3595
699c10bd
JD
35962011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3597
4393663b
JD
3598 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3599 variable firstTime not needed on OSX >= 10.6.
3600 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3601 >= 10.5. Use setKnobProportion, setDoubleValue.
3602
3603 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3604 (MAC_OS_X_VERSION_10_5): Define if not defined.
3605 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3606 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3607 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3608
3609 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3610 cString and lossyCString on OSX >= 10.4
3611
58179cce 3612 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3613 sizeToFit on OSX >= 10.2.
3614
3615 * nsimage.m (allocInitFromFile): Don't use deprecated method
3616 bestRepresentationForDevice on OSX >= 10.6.
3617
3618 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3619 to avoid warning.
3620
3621 * emacs.c: Declare unexec_init_emacs_zone.
3622
a63e0781
JD
3623 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3624
699c10bd
JD
3625 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3626
3627 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3628 on svcsMenu (Bug#8842).
3629
3630 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3631 ns_return_types.
3632 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3633
3634 * nsterm.m (QUTF8_STRING): Declare.
3635 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3636 (validRequestorForSendType): Return type is (id).
3637 Change indexOfObjectIdenticalTo to indexOfObject.
3638 Check if we have local selection before returning self (Bug#8842).
3639 (writeSelectionToPasteboard): Put local selection into paste board
3640 if we have a local selection (Bug#8842).
3641 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3642
3643 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3644 (ns_get_local_selection): Declare.
3645
54e10184
LMI
36462011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3647
9888ff71
LMI
3648 * keymap.c (describe_map_tree): Don't insert a double newline at
3649 the end of the buffer (bug#1169) and return whether we inserted
3650 something.
3651
54e10184
LMI
3652 * callint.c (Fcall_interactively): Change "reading args" to
3653 "providing args" to try to clarify what it does (bug#1010).
3654
15fa4783
KH
36552011-07-07 Kenichi Handa <handa@m17n.org>
3656
3657 * composite.c (composition_compute_stop_pos): Ignore a static
3658 composition starting before CHARPOS (Bug#8915).
3659
3660 * xdisp.c (handle_composition_prop): Likewise.
3661
a8815b00
EZ
36622011-07-07 Eli Zaretskii <eliz@gnu.org>
3663
3664 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3665 (Bug#9015)
3666
ef7b981d 36672011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3668
3669 * character.h (unicode_category_t): New enum type.
3670
3671 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3672 (Qchar_code_property_table): New variable.
3673 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3674 (UNIPROP_COMPRESSED_FORM_P): New macros.
3675 (char_table_ascii): Uncompress the compressed values.
3676 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3677 Uncompress the compressed values.
ac389d0c 3678 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3679 (char_table_ref_and_range): Uncompress the compressed values.
3680 (sub_char_table_set): New arg is_uniprop. Callers changed.
3681 Uncompress the compressed values.
3682 (sub_char_table_set_range): Args changed. Callers changed.
3683 (char_table_set_range): Adjuted for the above change.
3684 (map_sub_char_table): Delete args default_val and parent. Add arg
3685 top. Give decoded values to a Lisp function.
640c8776 3686 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3687 values to a Lisp function. Gcpro more variables.
3688 (uniprop_table_uncompress)
3689 (uniprop_decode_value_run_length): New functions.
3690 (uniprop_decoder, uniprop_decoder_count): New variables.
3691 (uniprop_get_decoder, uniprop_encode_value_character)
3692 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3693 New functions.
3694 (uniprop_encoder, uniprop_encoder_count): New variables.
3695 (uniprop_get_encoder, uniprop_table)
3696 (Funicode_property_table_internal, Fget_unicode_property_internal)
3697 (Fput_unicode_property_internal): New functions.
3698 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3699 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3700 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3701 char-code-property-alist.
3702
640c8776 3703 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3704 Vunicode_category_table.
3705
640c8776 3706 * font.c (font_range): Adjust for the change of
c805dec0
KH
3707 Vunicode_category_table.
3708
76b397fb
DN
37092011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3710
3711 * m/iris4d.h: Remove file, move contents ...
3712 * s/irix6-5.h: ... here.
3713
22b4128e
PE
37142011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3715
3716 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3717 * alloc.c (mark_buffer):
3718 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3719 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3720 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3721 This isn't true in general, and it's particularly not true
3722 if Emacs is configured with --with-wide-int.
3723 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3724 New macros, used in the buffer.c change.
3725
869795d6
JD
37262011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3727
3728 * xsettings.c: Use both GConf and GSettings if both are available.
3729 (store_config_changed_event): Add comment.
3730 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3731 (store_tool_bar_style_changed): New functions.
5e617bc2 3732 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3733 (struct xsettings): Move font inside HAVE_XFT.
3734 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3735 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3736 Move inside HAVE_XFT.
640c8776 3737 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3738 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3739 also.
3740 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3741 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3742 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3743 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3744 (parse_settings): Move check for font inside HAVE_XFT.
3745 (read_settings, apply_xft_settings): Add comment.
3746 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3747 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3748 call store_font_name_changed.
3749 (xft_settings_event): Add comment.
3750 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3751 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3752 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3753 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3754 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3755 (xsettings_get_system_font, xsettings_get_system_normal_font):
3756 Add comment.
869795d6 3757
d8ed26bd
PE
37582011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3759
3760 Random fixes. E.g., (random) never returned negative values.
3761 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3762 subseconds part to the entropy, as that's a bit more random.
3763 Prefer signed to unsigned, since the signedness doesn't matter and
3764 in general we prefer signed. When given a limit, use a
3765 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3766 latter isn't right if USE_2_TAGS_FOR_INTS.
3767 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3768 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3769
cabf1cac
SM
37702011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3771
3772 * textprop.c (text_property_stickiness):
3773 Obey Vtext_property_default_nonsticky.
3774 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3775 * w32fns.c (syms_of_w32fns):
3776 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3777
6e9b2be9
PE
37782011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3779
3780 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3781 This is more efficient than Ffile_directory_p and avoids a minor race.
3782
90186c68
LMI
37832011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3784
7c301272
LMI
3785 * buffer.c (Foverlay_put): Say what the return value is
3786 (bug#7835).
3787
c4f2d8d4
LMI
3788 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3789 is a directory before asking whether to use the file name
3790 (bug#7564).
ad637907
LMI
3791 (barf_or_query_if_file_exists): Make the "File is a directory"
3792 error be more correct.
c4f2d8d4 3793
90186c68
LMI
3794 * fns.c (Frequire): Remove the mention of the .gz files, since
3795 that's installation-specific, but keep the mention of
3796 `get-load-suffixes'.
3797
da64016e
PE
37982011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3799
3800 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3801 Report string overflow if the output is too long.
3802
7d47b580
JB
38032011-07-04 Juanma Barranquero <lekktu@gmail.com>
3804
a555cb87
JB
3805 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3806 (syms_of_gnutls): Remove duplicate DEFSYM for
3807 Qgnutls_bootprop_verify_hostname_error, an error for
3808 Qgnutls_bootprop_verify_error (which is no longer used).
3809
7d47b580
JB
3810 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3811 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3812 Also (re)move comments that are misplaced or no longer relevant.
3813
1e49bfab
LMI
38142011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3815
3816 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3817
1485f4c0
CY
38182011-07-03 Chong Yidong <cyd@stupidchicken.com>
3819
3820 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3821 and background color parameters if they have been changed.
3822
a9ab721e
LMI
38232011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3824
3825 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3826
cf7cff57
PE
38272011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3828
2e13213d
PE
3829 * xsettings.c (SYSTEM_FONT): Define only when used.
3830 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3831
cf7cff57
PE
3832 * keymap.c (access_keymap_1): Now static.
3833
7a8e04f7
CY
38342011-07-02 Chong Yidong <cyd@stupidchicken.com>
3835
3836 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3837 leave any prefix arg for the up event (Bug#1586).
3838
61352f62
LMI
38392011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3840
69bb1ef7
LMI
3841 * lread.c (syms_of_lread): Mention single symbols defined by
3842 `defvar' or `defconst' (bug#7154).
3843
61352f62 3844 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3845 (Frequire): Mention get-load-suffixes.
61352f62 3846
28545e04
MR
38472011-07-02 Martin Rudalics <rudalics@gmx.at>
3848
3849 * window.h (window): Remove clone_number slot.
3850 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3851 Remove.
3852 (make_parent_window, make_window, saved_window)
3853 (Fset_window_configuration, save_window_save): Don't deal with
3854 clone numbers.
3855 * buffer.c (Qclone_number): Remove declaration.
3856 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3857
3349e122
SM
38582011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3859
3860 Add multiple inheritance to keymaps.
3861 * keymap.c (Fmake_composed_keymap): New function.
3862 (Fset_keymap_parent): Simplify.
3863 (fix_submap_inheritance): Remove.
3864 (access_keymap_1): New function extracted from access_keymap to handle
3865 embedded parents and handle lists of maps.
3866 (access_keymap): Use it.
3867 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3868 (Fcopy_keymap): Handle embedded parents.
3869 (Fcommand_remapping, define_as_prefix): Simplify.
3870 (Fkey_binding): Simplify.
3871 (syms_of_keymap): Move minibuffer-local-completion-map,
3872 minibuffer-local-filename-completion-map,
3873 minibuffer-local-must-match-map, and
3874 minibuffer-local-filename-must-match-map to Elisp.
3875 (syms_of_keymap): Defsubr make-composed-keymap.
3876 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3877 (parse_menu_item): Trivial simplification.
3878
3279eb87
GM
38792011-07-01 Glenn Morris <rgm@gnu.org>
3880
3881 * Makefile.in (SETTINGS_LIBS): Fix typo.
3882
4550efdf
KI
38832011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3884
3885 * coding.c (Fencode_coding_string): Record the last coding system
3886 used, as the function doc string says (bug#8738).
3887
0949d2b6
JD
38882011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3889
3890 * xsettings.c (store_monospaced_changed): Take new font as arg and
3891 check for change against current_mono_font.
3892 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3893 (emacs_settings_constructor, emacs_settings_get_property)
3894 (emacs_settings_set_property, emacs_settings_class_init)
3895 (emacs_settings_init, gsettings_obj): Remove.
3896 (something_changedCB): New function for HAVE_GSETTINGS.
3897 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3898 with value as argument.
3899 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3900 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3901 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3902 "changed".
3903
3904 * xgselect.c: Add defined (HAVE_GSETTINGS).
3905 (xgselect_initialize): Ditto.
3906
3907 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3908 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3909 xg_select.
3910
bbc6b304
PE
39112011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3912
3913 * eval.c (struct backtrace): Simplify and port the data structure.
3914 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3915 signed bit field, as this assumption is not portable and it makes
3916 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3917 "char debug_on_exit : 1" as this is not portable either; instead,
3918 use the portable "unsigned int debug_on_exit : 1". Remove unused
3919 member evalargs. Remove obsolete comments about cc bombing out.
3920
9851bfc5
JD
39212011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3922
51bb811f 3923 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3924 Let HAVE_GSETTINGS override HAVE_GCONF.
3925 (store_monospaced_changed): New function.
3926 (EMACS_SETTINGS): A new type derived from GObject to handle
3927 GSettings notifications.
3928 (emacs_settings_constructor, emacs_settings_get_property)
3929 (emacs_settings_set_property, emacs_settings_class_init):
3930 New functions.
3931 (gsettings_client, gsettings_obj): New variables.
3932 (GSETTINGS_SCHEMA): New define.
3933 (something_changedCB): Call store_monospaced_changed.
3934 (init_gsettings): New function.
3935 (xsettings_initialize): Call init_gsettings.
3936 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3937 to NULL.
3938
640c8776 3939 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3940 GCONF_CFLAGS/LIBS.
3941
5386012d
MR
39422011-06-29 Martin Rudalics <rudalics@gmx.at>
3943
3944 * window.c (resize_root_window, grow_mini_window)
3945 (shrink_mini_window): Rename Qresize_root_window to
3946 Qwindow_resize_root_window and Qresize_root_window_vertically to
3947 Qwindow_resize_root_window_vertically.
3948
f13e0b08
PE
39492011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3950
3951 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3952
94515237
JB
39532011-06-27 Juanma Barranquero <lekktu@gmail.com>
3954
3955 * makefile.w32-in: Redesign dependencies so they reflect more
3956 clearly which files are directly included by each source file,
3957 and not through other includes.
3958
e43b6e43
MR
39592011-06-27 Martin Rudalics <rudalics@gmx.at>
3960
3961 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3962 (sort_overlays, overlay_strings): When an overlay's clone number
3963 matches the window's clone number process the overlay even if
3964 the overlay's window property doesn't match the current window.
3965
d68443dc
MR
3966 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3967 (Fwindow_hchild): Rename to Fwindow_left_child.
3968 (Fwindow_next): Rename to Fwindow_next_sibling.
3969 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3970 (resize_window_check): Rename to window_resize_check.
3971 (resize_window_apply): Rename to window_resize_apply.
3972 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3973 (Fdelete_other_windows_internal, resize_frame_windows)
3974 (Fsplit_window_internal, Fdelete_window_internal)
3975 (grow_mini_window, shrink_mini_window)
3976 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3977
c7e73be5
JD
39782011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3979
3980 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3981 (emacs_fixed_set_min_size): Remove.
3982 (emacs_fixed_new): Take frame as argument.
3983
3984 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3985 (_EmacsFixedPrivate): Remove minwidth/height.
3986 Add struct frame *f.
3987 (emacs_fixed_init): Initialize priv->f.
3988 (get_parent_class, emacs_fixed_set_min_size): Remove.
3989 (emacs_fixed_new): Set priv->f to argument.
3990 (emacs_fixed_get_preferred_width)
3991 (emacs_fixed_get_preferred_height): Use min_width/height from
3992 frames size_hint to set minimum and natural (Bug#8919).
3993 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3994 and use min_width/height from frames size_hint to set
3995 min_width/height (Bug#8919).
3996
3997 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3998 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3999 Fix indentation.
c7e73be5 4000
cf99dcf8
EZ
40012011-06-26 Eli Zaretskii <eliz@gnu.org>
4002
4003 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4004 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4005 called at ZV.
4006
029529ac
CY
40072011-06-26 Chong Yidong <cyd@stupidchicken.com>
4008
4009 * process.c (wait_reading_process_output): Bypass select if
4010 waiting for a cell while ignoring keyboard input, and input is
4011 pending. Suggested by Jan Djärv (Bug#8869).
4012
7a7ef429
PE
40132011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4014
4015 Use gnulib's dup2 module instead of rolling our own.
4016 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4017
11fdef7d 40182011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4019
4020 * dispnew.c (scrolling_window): Before scrolling, turn off a
4021 mouse-highlight in the window being scrolled.
4022
cd3520a4
JB
40232011-06-24 Juanma Barranquero <lekktu@gmail.com>
4024
4025 Move DEFSYM to lisp.h and use everywhere.
4026
4027 * character.h (DEFSYM): Move declaration...
4028 * lisp.h (DEFSYM): ...here.
4029
4030 * gnutls.c:
4031 * minibuf.c:
4032 * w32menu.c:
4033 * w32proc.c:
4034 * w32select.c: Don't include character.h.
4035
4036 * alloc.c (syms_of_alloc):
4037 * buffer.c (syms_of_buffer):
4038 * bytecode.c (syms_of_bytecode):
4039 * callint.c (syms_of_callint):
4040 * casefiddle.c (syms_of_casefiddle):
4041 * casetab.c (init_casetab_once):
4042 * category.c (init_category_once, syms_of_category):
4043 * ccl.c (syms_of_ccl):
4044 * cmds.c (syms_of_cmds):
4045 * composite.c (syms_of_composite):
4046 * dbusbind.c (syms_of_dbusbind):
4047 * dired.c (syms_of_dired):
4048 * dispnew.c (syms_of_display):
4049 * doc.c (syms_of_doc):
4050 * editfns.c (syms_of_editfns):
4051 * emacs.c (syms_of_emacs):
4052 * eval.c (syms_of_eval):
4053 * fileio.c (syms_of_fileio):
4054 * fns.c (syms_of_fns):
4055 * frame.c (syms_of_frame):
4056 * fringe.c (syms_of_fringe):
4057 * insdel.c (syms_of_insdel):
4058 * keymap.c (syms_of_keymap):
4059 * lread.c (init_obarray, syms_of_lread):
4060 * macros.c (syms_of_macros):
4061 * msdos.c (syms_of_msdos):
4062 * print.c (syms_of_print):
4063 * process.c (syms_of_process):
4064 * search.c (syms_of_search):
4065 * sound.c (syms_of_sound):
4066 * syntax.c (init_syntax_once, syms_of_syntax):
4067 * terminal.c (syms_of_terminal):
4068 * textprop.c (syms_of_textprop):
4069 * undo.c (syms_of_undo):
4070 * w32.c (globals_of_w32):
4071 * window.c (syms_of_window):
4072 * xdisp.c (syms_of_xdisp):
4073 * xfaces.c (syms_of_xfaces):
4074 * xfns.c (syms_of_xfns):
4075 * xmenu.c (syms_of_xmenu):
4076 * xsettings.c (syms_of_xsettings):
4077 * xterm.c (syms_of_xterm): Use DEFSYM.
4078
4228cf16
TZ
40792011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4080
cd3520a4 4081 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4082
7fcccf1e
PE
40832011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4084
7efb4e0e
PE
4085 Integer and buffer overflow fixes (Bug#8873).
4086
ff5844ad
PE
4087 * print.c (printchar, strout): Check for string overflow.
4088 (PRINTPREPARE, printchar, strout):
4089 Don't set size unless allocation succeeds.
4090
90532f02
PE
4091 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4092 for sizes. Check for string overflow more accurately.
4093 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4094
6d84508d
PE
4095 * macros.c: Integer and buffer overflow fixes.
4096 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4097 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4098 Use ptrdiff_t, not int, for sizes.
4099 Don't increment bufsize until after realloc succeeds.
4100 Check for size-calculation overflow.
4101 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4102
437b2cb4
PE
4103 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4104
8b9ac8b4
PE
4105 * lread.c: Integer overflow fixes.
4106 (read_integer): Radix is now EMACS_INT, not int,
4107 to improve quality of diagnostics for out-of-range radices.
4108 Calculate buffer size correctly for out-of-range radices.
4109 (read1): Check for integer overflow in radices, and in
4110 read-circle numbers.
82cb60d3
PE
4111 (read_escape): Avoid int overflow.
4112 (Fload, openp, read_buffer_size, read1)
4113 (substitute_object_recurse, read_vector, read_list, map_obarray):
4114 Use ptrdiff_t, not int, for sizes.
4115 (read1): Use EMACS_INT, not int, for sizes.
20270765 4116 Check for size overflow.
8b9ac8b4 4117
7fcccf1e
PE
4118 * image.c (cache_image): Check for size arithmetic overflow.
4119
bfbbd7e7
PE
4120 * lread.c: Integer overflow issues.
4121 (saved_doc_string_size, saved_doc_string_length)
4122 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4123 Now ptrdiff_t, not int.
4124 (read1): Don't assume doc string length fits in int. Check for
4125 out-of-range doc string lengths.
4126 (read_list): Don't assume file position fits in int.
39019e54 4127 (read_escape): Check for hex character overflow.
bfbbd7e7 4128
4e323265
LL
41292011-06-22 Leo Liu <sdl.web@gmail.com>
4130
4131 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4132 Move to minibuffer.el.
4133
85fece3e
PE
41342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4135
20b84ce9 4136 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4137 The following patches are for when GLYPH_DEBUG && !XASSERT.
4138 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4139 * dispnew.c (flush_stdout):
4140 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4141 Mark as externally visible.
4142 * dispnew.c (check_window_matrix_pointers): Now static.
4143 * dispnew.c (window_to_frame_vpos):
4144 * xfns.c (unwind_create_frame):
4145 * xterm.c (x_check_font): Remove unused local.
4146 * scroll.c (CHECK_BOUNDS):
4147 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4148 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4149 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4150 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4151 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4152 Now static.
4153 (debug_method_add): Use va_list and vsprintf rather than relying
4154 on undefined behavior with wrong number of arguments.
4155 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4156 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4157 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4158 since we're not interested in debugging glyphs with old libraries.
4159 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4160 GCC 4.6.0's static checking.
4161
0766b489
PE
41622011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4163
31fd4b32
PE
4164 Integer overflow and signedness fixes (Bug#8873).
4165 A few related buffer overrun fixes, too.
4166
b79e8648
PE
4167 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4168
0766b489
PE
4169 * dispextern.h (struct face.stipple):
4170 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4171 (x_bitmap_mask, x_allocate_bitmap_record)
4172 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4173 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4174 (x_create_bitmap_from_xpm_data):
4175 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4176 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4177 (.bitmaps_last):
4178 * xfaces.c (load_pixmap):
4179 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4180 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4181 (.bitmaps_last, struct x_output.icon_bitmap):
4182 Use ptrdiff_t, not int, for bitmap indexes.
4183 (x_allocate_bitmap_record): Check for size overflow.
4184 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4185
b081724f
PE
4186 Use ptrdiff_t, not int, for overlay counts.
4187 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4188 * editfns.c (overlays_around, get_pos_property):
4189 * textprop.c (get_char_property_and_overlay):
4190 * xdisp.c (next_overlay_change, note_mouse_highlight):
4191 * xfaces.c (face_at_buffer_position):
21514da7
PE
4192 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4193 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4194 (Fnext_overlay_change, Fprevious_overlay_change)
4195 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4196 Use ptrdiff_t, not int, for sizes.
21514da7 4197 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4198
3de73e5e
PE
4199 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4200
2606c57b
PE
4201 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4202 (x_session_initialize): Do not assume string length fits in int.
4203
aaafe47a
PE
4204 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4205 This is unlikely, but can occur if DPI is outlandish.
4206
2674ddc8 4207 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4208 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4209
28154962
PE
4210 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4211 * xrdb.c (magic_file_p, search_magic_path):
4212 Omit last arg SUFFIX; it was always 0. All callers changed.
4213 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4214
7de51af5
PE
4215 * xfont.c (xfont_match): Avoid need for strlen.
4216
25ed6cc3
PE
4217 * xfns.c: Don't assume strlen fits in int.
4218 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4219
4eab31dd
PE
4220 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4221 not unsigned long, as we prefer signed integers. All callers changed.
4222 Detect integer overflow in repeat count.
4223 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4224 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4225
171e2a58
PE
4226 * termcap.c: Don't assume sizes fit in int and never overflow.
4227 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4228 (gobble_line): Check for size-calculation overflow.
4229
ad39faca 4230 * minibuf.c (Fread_buffer):
6e5bb2dc 4231 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4232 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4233 Don't assume string length fits in int.
4234
52c61c22 4235 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4236 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4237
b5b8c9e5
PE
4238 * font.c: Don't assume string length fits in int.
4239 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4240 Use ptrdiff_t, not int.
ccd6111c
PE
4241 (font_intern_prop): Don't assume string length fits in int.
4242 Don't assume integer property fits in fixnum.
4243 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4244
882f0d81 4245 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4246 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4247 Reformulate so as not to need the command string.
4248 Invoke gzip -cd rather than gunzip, as it's more portable.
4249 (lock_info_type, lock_file_1, lock_file):
4250 Don't assume pid_t and time_t fit in unsigned long.
4251 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4252 (current_lock_owner): Prefer signed type for sizes.
4253 Use memcpy, not strncpy, where memcpy is what is really wanted.
4254 Don't assume (via atoi) that time_t and pid_t fit in int.
4255 Check for time_t and/or pid_t out of range, e.g., via a network share.
4256 Don't alloca where an auto var works fine.
4257
93f4cf88
PE
4258 * fileio.c: Fix some integer overflow issues.
4259 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4260 Don't assume string length fits in int.
4261 (directory_file_name): Don't assume string length fits in long.
4262 (make_temp_name): Don't assume pid fits in int, or that its print
4263 length is less than 20.
4264
f3e92b69
PE
4265 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4266
1bfdaf10
PE
4267 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4268
35016e9a
PE
4269 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4270
3d1e65a1
PE
4271 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4272 We prefer signed integers, even for size calculations.
4273
0b963a93
PE
4274 * emacs.c: Don't assume string length fits in 'int'.
4275 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4276 (main): Don't invoke strlen when not needed.
4277
573f4b54
PE
4278 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4279 (XD_DEBUG_MESSAGE): Don't waste a byte.
4280
989f33ba
PE
4281 * callproc.c (getenv_internal_1, getenv_internal)
4282 (Fgetenv_internal):
965d34eb
PE
4283 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4284
e4d29b33
PE
4285 * lread.c (invalid_syntax): Omit length argument.
4286 All uses changed. This doesn't fix a bug, but it simplifies the
4287 code away from its former Hollerith-constant appearance, and it's
4288 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4289 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4290
eb49b136
PE
4291 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4292 This didn't break anything, but it didn't help either.
4293 It's confusing to put a bogus integer in a place where the actual
4294 value does not matter.
9f62aeb1 4295 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4296 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4297
15375a22
PE
4298 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4299 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4300 implementation.
b61cc01c
PE
4301 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4302 We prefer signed types, and the value cannot exceed the EMACS_INT
4303 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4304 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4305 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4306 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4307
53b2623d
PE
4308 * indent.c (sane_tab_width): New function.
4309 (current_column, scan_for_column, Findent_to, position_indentation)
4310 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4311 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4312
51cab52b 4313 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4314
f2ed8a70
PE
4315 * lisp.h (lint_assume): New macro.
4316 * composite.c (composition_gstring_put_cache):
4317 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4318
abe80cc6
PE
4319 * editfns.c, insdel.c:
4320 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4321
b02c740e
PE
4322 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4323
ebc96716
PE
4324 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4325
b4e50fa0 4326 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4327 Use much-faster test for byte-length change.
311d5d7c 4328 Don't assume string byte-length fits in 'int'.
a4cf38e4 4329 Check that character arg fits in 'int'.
85461888 4330 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4331
c0c1ee9f
PE
4332 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4333
a498d7f4
PE
4334 * fns.c (concat): Catch string overflow earlier.
4335 Do not rely on integer wraparound.
4336
51cab52b
PE
4337 * dispextern.h (struct it.overlay_strings_charpos)
4338 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4339 * xdisp.c (forward_to_next_line_start)
4340 (back_to_previous_visible_line_start)
4341 (reseat_at_next_visible_line_start, next_element_from_buffer):
4342 Don't arbitrarily truncate the value of 'selective' to int.
4343
76031fad
PE
4344 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4345
5eb55db9
PE
4346 * composite.c: Don't truncate sizes to 'int'.
4347 (composition_gstring_p, composition_reseat_it)
4348 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4349 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4350 not EMACS_UINT, for indexes.
5eb55db9 4351
0703a717
PE
4352 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4353
d6202519
PE
4354 * buffer.c: Include <verify.h>.
4355 (struct sortvec.priority, struct sortstr.priority):
8961a454 4356 Now EMACS_INT, not int.
c20998a7 4357 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4358 (struct sortstr.size, record_overlay_string)
4359 (struct sortstrlist.size, struct sortlist.used):
4360 Don't truncate size to int.
4361 (record_overlay_string): Check for size-calculation overflow.
d6202519 4362 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4363
d5a19415
JM
43642011-06-22 Jim Meyering <meyering@redhat.com>
4365
029529ac 4366 Don't leak an XBM-image-sized buffer
d5a19415
JM
4367 * image.c (xbm_load): Free the image buffer after using it.
4368
a9041e6c
PE
43692011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4370
4371 Port to Sun C.
4372 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4373 that Sun C diagnosed.
4374 * fns.c (secure_hash): Fix pointer signedness issue.
4375 * intervals.c (static_offset_intervals): New function.
4376 (offset_intervals): Use it.
4377
7f3f739f
LL
43782011-06-21 Leo Liu <sdl.web@gmail.com>
4379
4380 * deps.mk (fns.o):
4381 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4382 sha512.h.
4383
4384 * fns.c (secure_hash): Rename from crypto_hash_function and change
4385 the first arg to accept symbols.
5b66d427 4386 (Fsecure_hash): New primitive.
7f3f739f
LL
4387 (syms_of_fns): New symbols.
4388
76147d94
DD
43892011-06-20 Deniz Dogan <deniz@dogan.se>
4390
4391 * process.c (Fset_process_buffer): Clarify return value in
4392 docstring.
4393
7d7d0045
CY
43942011-06-18 Chong Yidong <cyd@stupidchicken.com>
4395
4396 * dispnew.c (add_window_display_history): Use BVAR.
4397
4398 * xdisp.c (debug_method_add): Use BVAR.
4399 (check_window_end, dump_glyph_matrix, dump_glyph)
4400 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4401
4402 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4403 Likewise.
4404
4405 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4406 check till after the cache is created in init_frame_faces.
4407
ff2bc410
SM
44082011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4409
4410 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4411
28177add
PE
44122011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4413
dd3482fe
PE
4414 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4415 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4416 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4417
393d71f3 4418 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4419 * fileio.c (Finsert_file_contents):
4420 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4421 Remove the old (too-loose) buffer overflow checks.
4422 They weren't needed, since make_gap checks for buffer overflow.
4423 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4424 The old code merely checked for Emacs fixnum overflow, and relied
4425 on undefined (wraparound) behavior. The new code avoids undefined
4426 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4427
2e6813b0 4428 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4429 Tune. Don't use wider integers than needed. Don't use alloca.
4430 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4431
599a9e4f
PE
4432 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4433
99561444
PE
4434 * insdel.c, lisp.h (buffer_overflow): New function.
4435 (insert_from_buffer_1, replace_range, replace_range_2):
4436 * insdel.c (make_gap_larger):
4437 * editfns.c (Finsert_char):
4438 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4439
28177add
PE
4440 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4441
e69dafad
PE
44422011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4443
4baa020d 4444 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4445
b1c46f02
PE
4446 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4447 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4448
e69dafad
PE
4449 * fileio.c: Don't assume EMACS_INT fits in off_t.
4450 (emacs_lseek): New static function.
4451 (Finsert_file_contents, Fwrite_region): Use it.
4452 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4453
566684ea
PE
4454 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4455
e6966cd6
PE
4456 * fns.c: Don't overflow int when computing a list length.
4457 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4458 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4459 truncation on 64-bit hosts. Check for QUIT every
4460 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4461 faster and is responsive enough.
4462 (Flength): Report an error instead of overflowing an integer.
4463 (Fsafe_length): Return a float if the value is not representable
4464 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4465 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4466 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4467
dd0b0efb
PE
4468 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4469 (header_size, word_size): New constants.
4470 (allocate_vectorlike): Don't check size overflow here.
4471 (allocate_vector): Check it here instead, since this is the only
4472 caller of allocate_vectorlike that could cause overflow.
4473 Check that the new vector's length is representable as a fixnum.
4474
86fe5cfe
PE
4475 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4476 The previous code was bogus. For example, next_almost_prime (32)
4477 returned 39, which is undesirable as it is a multiple of 3; and
4478 next_almost_prime (24) returned 25, which is a multiple of 5 so
4479 why was the code bothering to check for multiples of 7?
4480
80e88859
PE
4481 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4482
4a2f0ad6
PE
4483 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4484
f66c7cf8
PE
4485 Variadic C functions now count arguments with ptrdiff_t.
4486 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4487 Back then I didn't know that the Emacs coding style prefers signed int.
4488 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4489 were being counted with int, which may truncate counts on 64-bit
4490 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4491 * lisp.h (struct Lisp_Subr.function.aMANY)
4492 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4493 Arg counts are now ptrdiff_t, not size_t.
4494 All variadic functions and their callers changed accordingly.
4495 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4496 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4497 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4498 * callint.c (Fcall_interactively): Check arg count for overflow,
4499 to avoid potential buffer overrun. Use signed char, not 'int',
4500 for 'varies' array, so that we needn't bother to check its size
4501 calculation for overflow.
4502 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4503 * eval.c (apply_lambda):
4504 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4505 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4506 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4507
a1759b76
PE
4508 * callint.c (Fcall_interactively): Don't use index var as event count.
4509
d96be9fc
PE
4510 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4511 * mem-limits.h (SIZE): Remove; no longer used.
4512
a690a978 4513 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4514
578c21e6
PE
4515 Remove unnecessary casts.
4516 * xterm.c (x_term_init):
4517 * xfns.c (x_set_border_pixel):
4518 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4519 These aren't needed now that we assume ANSI C.
4520
96f53c6c
PE
4521 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4522 It's more likely to cause problems (due to unsigned overflow)
4523 than to cure them.
4524
83c77d31
PE
4525 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4526
ee2079f1
PE
4527 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4528
6da65536
PE
4529 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4530
7147c4a4
PE
4531 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4532
193e32d9
PE
4533 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4534
e5533da6
PE
4535 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4536
9910e595
PE
4537 GLYPH_CODE_FACE returns EMACS_INT, not int.
4538 * dispextern.h (merge_faces):
4539 * xfaces.c (merge_faces):
01103c44
PE
4540 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4541 Don't assume EMACS_INT fits in int.
9910e595 4542
2638320e
PE
4543 * character.h (CHAR_VALID_P): Remove unused parameter.
4544 * fontset.c, lisp.h, xdisp.c: All uses changed.
4545
045eb8d9
PE
4546 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4547
c1f134b5
PE
4548 * fns.c (concat): Minor tuning based on overflow analysis.
4549 This doesn't fix any bugs. Use int to hold character, instead
4550 of constantly refetching from Emacs object. Use XFASTINT, not
4551 XINT, for value known to be a character. Don't bother comparing
4552 a single byte to 0400, as it's always less.
4553
395fcb93 4554 * floatfns.c (Fexpt):
327eeec8
PE
4555 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4556
abbd3d23
PE
4557 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4558 for characters.
4559
684a03ef
PE
4560 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4561
0fed43f3
PE
4562 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4563 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4564 incorrectly succeed when S was a string, because 4294967386 was
4565 truncated before it was used.
4566
8fd02eb7
PE
4567 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4568 Otherwise, an out-of-range integer could cause undefined behavior
4569 on a 64-bit host.
4570
f8c86b69
PE
4571 * composite.c: Use int, not EMACS_INT, for characters.
4572 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4573 EMACS_INT, for values that are known to be in character range.
4574 This doesn't fix any bugs but is the usual style inside Emacs and
4575 may generate better code on 32-bit machines.
4576
34206dd2
PE
4577 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4578 This is for reasons similar to the recent CHAR_STRING fix.
4579 * charset.c (Fencode_char): Check that character arg is actually
4580 a character. Pass an int to ENCODE_CHAR.
4581 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4582 wider than 'int', as a compile-time check to prevent future regressions
4583 in this area.
4584
c5958d4c 4585 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4586
4587 Make sure a 64-bit char is never passed to CHAR_STRING.
4588 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4589 by silently ignoring the top 32 bits, allowing some values
4590 that were far too large to be valid characters.
4591 * character.h: Include <verify.h>.
4592 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4593 arguments are no wider than unsigned, as a compile-time check
4594 to prevent future regressions in this area.
4595 * data.c (Faset):
01103c44 4596 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4597 (Fsubst_char_in_region):
4598 * fns.c (concat):
4599 * xdisp.c (decode_mode_spec_coding):
4600 Adjust to CHAR_STRING's new requirement.
4601 * editfns.c (Finsert_char, Fsubst_char_in_region):
4602 * fns.c (concat): Check that character args are actually
4603 characters. Without this test, these functions did the wrong
4604 thing with wildly out-of-range values on 64-bit hosts.
4605
d37ca623
PE
4606 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4607 These casts should not be needed on 32-bit hosts, either.
4608 * keyboard.c (read_char):
4609 * lread.c (Fload): Remove casts to unsigned.
4610
ea204efb
PE
4611 * lisp.h (UNSIGNED_CMP): New macro.
4612 This fixes comparison bugs on 64-bit hosts.
4613 (ASCII_CHAR_P): Use it.
4614 * casefiddle.c (casify_object):
01103c44 4615 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4616 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4617 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4618 * dispextern.h (FACE_FROM_ID):
4619 * keyboard.c (read_char): Use UNSIGNED_CMP.
4620
41cb286c
PE
4621 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4622 not to EMACS_INT, to avoid GCC warning.
4623
4a1b9832
PE
4624 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4625
55daad71
PE
4626 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4627 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4628 isn't needed on 32-bit machines.
8f95c75c 4629
01103c44
PE
4630 * buffer.c (Fgenerate_new_buffer_name):
4631 Use EMACS_INT for count, not int.
0ceccced 4632 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4633
4634 * data.c (Qcompiled_function): Now static.
4635
c6f072e7
PE
4636 * window.c (window_body_lines): Now static.
4637
20ce5912
PE
4638 * image.c (gif_load): Rename local to avoid shadowing.
4639
9c4c5f81
PE
4640 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4641 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4642 * alloc.c (make_save_value): Integer argument is now of type
4643 ptrdiff_t, not int.
4644 (mark_object): Use ptrdiff_t, not int.
4645 * lisp.h (pD): New macro.
4646 * print.c (print_object): Use it.
4647
c0c5c8ae
PE
4648 * alloc.c: Use EMACS_INT, not int, to count objects.
4649 (total_conses, total_markers, total_symbols, total_vector_size)
4650 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4651 (total_free_floats, total_floats, total_free_intervals)
4652 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4653 Now EMACS_INT, not int. All uses changed.
4654 (Fgarbage_collect): Compute overall total using a double, so that
4655 integer overflow is less likely to be a problem. Check for overflow
4656 when converting back to an integer.
5a25e253
PE
4657 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4658 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4659 These were 'int' variables that could overflow on 64-bit hosts;
4660 they were never used, so remove them instead of repairing them.
211a0b2a 4661 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4662 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4663 Previously, this ceilinged at INT_MAX, but that doesn't work on
4664 64-bit machines.
e46bb31a 4665 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4666
c78baabf 4667 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4668 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4669 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4670 when a (possibly-narrower) signed value would do just as well.
4671 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4672
c9d624c6
PE
4673 * alloc.c: Catch some string size overflows that we were missing.
4674 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4675 for convenience in STRING_BYTES_MAX.
4676 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4677 The definition here is exact; the one in lisp.h was approximate.
4678 (allocate_string_data): Check for string overflow. This catches
4679 some instances we weren't catching before. Also, it catches
4680 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4681 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4682 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4683
c9d624c6
PE
4684 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4685 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4686 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4687
353032ce
PE
4688 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4689
2bccce07
PE
4690 * alloc.c (Fmake_string): Check for out-of-range init.
4691
0ac30604
SM
46922011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4693
4694 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4695
c195f2de
JD
46962011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4697
4698 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4699 xg_get_default_scrollbar_width.
4700
4701 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4702 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4703 (style_changed_cb): Call update_theme_scrollbar_width and call
4704 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4705 all frames (Bug#8505).
4706 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4707 Call gtk_window_set_resizable if HAVE_GTK3.
4708 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4709 and height if HAVE_GTK3 (Bug#8505).
4710 (scroll_bar_width_for_theme): New variable.
4711 (update_theme_scrollbar_width): New function.
4712 (xg_get_default_scrollbar_width): Move code to
4713 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4714 (xg_initialize): Call update_theme_scrollbar_width.
4715
4716 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4717
4718 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4719
e10ac9f1
MR
47202011-06-12 Martin Rudalics <rudalics@gmx.at>
4721
4722 * frame.c (make_frame): Call other_buffer_safely instead of
4723 other_buffer.
4724
4725 * window.c (temp_output_buffer_show): Call display_buffer with
4726 second argument Vtemp_buffer_show_specifiers and reset latter
4727 immediately after the call.
4728 (Vtemp_buffer_show_specifiers): New variable.
4729 (auto_window_vscroll_p, next_screen_context_lines)
4730 (Vscroll_preserve_screen_position): Remove leading asterisks from
4731 doc-strings.
4732
2d3c217e 47332011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4734
7b7f97e8 4735 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4736 * buffer.c (Qclone_number): Remove for now, as it's unused.
4737 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4738 (record_buffer): Remove unused local.
4739 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4740 (set_frame_buffer_list): Remove; unused.
4741 * frame.h (other_visible_frames): Remove decl.
4742 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4743 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4744 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4745 if HAVE_GPM.
4746 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4747 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4748 Define only if HAVE_GPM.
4749 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4750 (update_hints_inhibit): Remove; never set. All uses removed.
4751 * widgetprv.h (emacsFrameClassRec): Remove decl.
4752 * window.c (delete_deletable_window): Now returns void, since it
4753 wasn't returning anything.
4754 (compare_window_configurations): Remove unused locals.
4755 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4756 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4757 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4758 the same widths as pointers. This follows up on the 2011-05-06 patch.
4759 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4760 * xterm.h: Likewise.
4761 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4762
1384b89e
JB
47632011-06-12 Juanma Barranquero <lekktu@gmail.com>
4764
4765 * makefile.w32-in: Update dependencies.
4766 (LISP_H): Add lib/intprops.h.
4767
1100a63c
CY
47682011-06-11 Chong Yidong <cyd@stupidchicken.com>
4769
4770 * image.c (gif_load): Add animation frame delay to the metadata.
4771 (syms_of_image): Use DEFSYM. New symbol `delay'.
4772
6198ccd0
MR
47732011-06-11 Martin Rudalics <rudalics@gmx.at>
4774
4775 * window.c (delete_deletable_window): Re-add.
4776 (Fset_window_configuration): Rewrite to handle dead buffers and
4777 consequently deletable windows.
4778 (window_tree, Fwindow_tree): Remove. Supply functionality in
4779 window.el.
4780 (compare_window_configurations): Simplify code.
4781
b6e3633c
AS
47822011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4783
1ab0dee5
AS
4784 * image.c (imagemagick_load_image): Fix type mismatch.
4785 (Fimagemagick_types): Likewise.
4786
b6e3633c
AS
4787 * window.h (replace_buffer_in_windows): Declare.
4788
9397e56f
MR
47892011-06-11 Martin Rudalics <rudalics@gmx.at>
4790
4791 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4792 Qclone_number. Remove external declaration of Qdelete_window.
4793 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4794 code.
640c8776
SM
4795 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4796 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4797 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4798 buffer list implementation.
4799 (other_buffer_safely): New function.
4800 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4801 calls to replace_buffer_in_windows and
4802 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4803 if allowed.
4804 (record_buffer): Inhibit quitting and rewrite using quittable
4805 functions. Run Qbuffer_list_update_hook if allowed.
4806 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4807 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4808 Move switch-to-buffer to window.el.
9397e56f
MR
4809 (bury-buffer): Move to window.el.
4810 (Vbuffer_list_update_hook): New variable.
4811
4812 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4813 section.
4814
4815 * window.h (resize_frame_windows): Move up in code.
4816 (Fwindow_frame): Remove EXFUN.
4817 (replace_buffer_in_all_windows): Remove prototype.
4818 (replace_buffer_in_windows_safely): Add prototype.
4819
4820 * window.c: Declare Qdelete_window static again. Move down
4821 declaration of select_count.
4822 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4823 (Fother_window): Move to window.el.
4824 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4825 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4826 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4827 window.el.
4828 (replace_buffer_in_windows): Implement by calling
4829 Qreplace_buffer_in_windows.
4830 (replace_buffer_in_all_windows): Remove with some functionality
4831 moved into replace_buffer_in_windows_safely.
4832 (replace_buffer_in_windows_safely): New function.
4833 (select_window_norecord, select_frame_norecord): Move in front
4834 of run_window_configuration_change_hook. Remove now obsolete
4835 declarations.
640c8776
SM
4836 (Fset_window_buffer): Rewrite doc-string.
4837 Call Qrecord_window_buffer.
9397e56f
MR
4838 (keys_of_window): Move binding for other-window to window.el.
4839
b50691aa
CY
48402011-06-11 Chong Yidong <cyd@stupidchicken.com>
4841
4842 * dispextern.h (struct image): Replace data member, whose int_val
4843 and ptr_val fields were not used by anything, with a single
4844 lisp_val object.
4845
4846 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4847 (gif_clear_image, gif_load, imagemagick_load_image)
4848 (gs_clear_image, gs_load): Callers changed.
4849
3f754b86
PE
48502011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4851
cca69397
PE
4852 * buffer.h: Include <time.h>, for time_t.
4853 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4854
109e28d0
PE
4855 Fix minor problems found by static checking.
4856
60737f02
PE
4857 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4858
4b66faf3
PE
4859 Make identifiers static if they are not used in other modules.
4860 * data.c (Qcompiled_function, Qframe, Qvector):
4861 * image.c (QimageMagick, Qsvg):
4862 * minibuf.c (Qmetadata):
4863 * window.c (resize_window_check, resize_root_window): Now static.
4864 * window.h (resize_window_check, resize_root_window): Remove decls.
4865
109e28d0
PE
4866 * window.c (window_deletion_count, delete_deletable_window):
4867 Remove; unused.
46a4ce9e
PE
4868 (window_body_lines): Now static.
4869 (Fdelete_other_windows_internal): Mark vars as initialized.
4870 Make sure 'resize_failed' is initialized.
4871 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4872 (resize_window_apply): Remove unused local.
4873 * window.h (delete_deletable_window): Remove decl.
4874
109e28d0 4875 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4876 (imagemagick_load_image): Fix pointer signedness problem by changing
4877 last arg from unsigned char * to char *. All uses changed.
4878 Also, fix a local for similar reasons.
4879 Remove unused locals. Remove locals to avoid shadowing.
4880 (fn_rsvg_handle_free): Remove; unused.
4881 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4882 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4883
3f754b86
PE
4884 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4885
2547adb1
CY
48862011-06-10 Chong Yidong <cyd@stupidchicken.com>
4887
4888 * image.c (gif_load): Fix omitted cast error introduced by
4889 2011-06-06 change.
4890
2c8e37d4
MR
48912011-06-10 Martin Rudalics <rudalics@gmx.at>
4892
4893 * window.h (resize_proportionally, orig_total_lines)
4894 (orig_top_line): Remove from window structure.
4895 (set_window_height, set_window_width, change_window_heights)
4896 (Fdelete_window): Remove prototypes.
4897 (resize_frame_windows): Remove duplicate declaration.
4898
440a42e3
EZ
48992011-06-10 Eli Zaretskii <eliz@gnu.org>
4900
4901 * window.h (resize_frame_windows, resize_window_check)
4902 (delete_deletable_window, resize_root_window)
4903 (resize_frame_windows): Declare prototypes.
4904
4905 * window.c (resize_window_apply): Make definition be "static" to
4906 match the prototype.
4907
562dd5e9
MR
49082011-06-10 Martin Rudalics <rudalics@gmx.at>
4909
4910 * window.c: Remove declarations of Qwindow_size_fixed,
4911 window_min_size_1, window_min_size_2, window_min_size,
4912 size_window, window_fixed_size_p, enlarge_window, delete_window.
4913 Remove static from declaration of Qdelete_window, it's
4914 temporarily needed by Fbury_buffer.
4915 (replace_window): Don't assign orig_top_line and
4916 orig_total_lines.
4917 (Fdelete_window, delete_window): Remove. Window deletion is
4918 handled by window.el.
640c8776
SM
4919 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4920 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4921 (Fdelete_other_windows): Remove. Deleting other windows is
4922 handled by window.el.
4923 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4924 handled in window.el.
4925 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4926 Window minimum sizes are handled in window.el.
4927 (shrink_windows, size_window, set_window_height)
4928 (set_window_width, change_window_heights, window_height)
4929 (window_width, CURBEG, CURSIZE, enlarge_window)
4930 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4931 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4932 handled in window.el.
4933 (make_dummy_parent): Rename to make_parent_window and give it a
4934 second argument horflag.
4935 (make_window): Don't set resize_proportionally any more.
4936 (Fsplit_window): Remove. Windows are split in window.el.
4937 (save_restore_action, save_restore_orig_size)
4938 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4939 Resize mini windows in window.el.
4940 (grow_mini_window, shrink_mini_window): Implement by calling
4941 Qresize_root_window_vertically, resize_window_check and
4942 resize_window_apply.
640c8776
SM
4943 (saved_window, Fset_window_configuration, save_window_save):
4944 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4945 resize_proportionally.
4946 (window_min_height, window_min_width): Move to window.el.
4947 (keys_of_window): Move bindings for delete-other-windows,
4948 split-window, delete-window and enlarge-window to window.el.
4949
4950 * buffer.c: Temporarily extern Qdelete_window.
4951 (Fbury_buffer): Temporarily call Qdelete_window instead of
4952 Fdelete_window (Fbury_buffer will move to window.el soon).
4953
4954 * frame.c (set_menu_bar_lines_1): Remove code handling
4955 orig_top_line and orig_total_lines.
4956
4957 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4958 set_window_height but set heights directly.
4959 (change_frame_size_1): Use resize_frame_windows.
4960
4961 * xdisp.c (init_xdisp): Don't use set_window_height but set
4962 heights directly.
4963
640c8776
SM
4964 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4965 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4966 run_window_configuration_change_hook.
4967
4968 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4969 instead of change_window_heights and run
4970 run_window_configuration_change_hook.
4971
1a13852e
MR
49722011-06-09 Martin Rudalics <rudalics@gmx.at>
4973
4974 * window.c (replace_window): Rename second argument REPLACEMENT to
4975 NEW. New third argument SETFLAG. Rewrite.
4976 (delete_window, make_dummy_parent): Call replace_window with
4977 third argument 1.
4978 (window_list_1): Move down in code.
4979 (run_window_configuration_change_hook): Move set_buffer part
4980 before select_frame_norecord part in order to unwind correctly.
4981 Rename count1 to count.
4982 (recombine_windows, delete_deletable_window, resize_root_window)
4983 (Fdelete_other_windows_internal)
4984 (Frun_window_configuration_change_hook, make_parent_window)
4985 (resize_window_check, resize_window_apply, Fresize_window_apply)
4986 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4987 (Fdelete_window_internal, Fresize_mini_window_internal):
4988 New functions.
1a13852e
MR
4989 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4990
f3d1777e
MR
49912011-06-08 Martin Rudalics <rudalics@gmx.at>
4992
496e208e
MR
4993 * window.h (window): Add some new members to window structure -
4994 normal_lines, normal_cols, new_total, new_normal, clone_number,
4995 splits, nest, prev_buffers, next_buffers.
4996 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4997 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4998
f3d1777e
MR
4999 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5000 Remove.
496e208e
MR
5001 (make_dummy_parent): Set new members of windows structure.
5002 (make_window): Move down in code. Handle new members of window
5003 structure.
5004 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5005 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5006 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5007 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5008 (Fset_window_next_buffers, Fset_window_clone_number):
5009 New functions.
496e208e
MR
5010 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5011 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5012 Doc-string fixes.
5013 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5014 Argument WINDOW can be now internal window too.
5015 (Fwindow_use_time): Move up in code.
5016 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5017 Rewrite doc-string.
5018 (Fset_window_configuration, saved_window)
5019 (Fcurrent_window_configuration, save_window_save): Handle new
5020 members of window structure.
b9e809c2
MR
5021 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5022 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5023 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5024 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5025 Qget_mru_window, Qresize_root_window,
5026 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5027 Qauto_buffer_name; staticpro them.
f3d1777e 5028
abde8f8c
MR
50292011-06-07 Martin Rudalics <rudalics@gmx.at>
5030
5031 * window.c (Fwindow_total_size, Fwindow_left_column)
5032 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5033 (Fwindow_list_1): New functions.
5034 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5035 (Fwindow_width, Fscroll_left, Fscroll_right):
5036 Use window_body_cols instead of window_box_text_cols.
5037 (delete_window, Fset_window_configuration):
5038 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5039 (delete_all_subwindows): Take a window as argument and not a
5040 structure. Rewrite.
190b47e6
MR
5041 (window_loop): Remove handling of GET_LRU_WINDOW and
5042 GET_LARGEST_WINDOW.
5043 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5044
5045 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5046 window_box_text_cols. delete_all_subwindows now takes a
5047 Lisp_Object as argument.
abde8f8c 5048
640c8776
SM
5049 * indent.c (compute_motion, Fcompute_motion):
5050 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5051
fa8a67e6
MR
5052 * frame.c (delete_frame): Call delete_all_subwindows with root
5053 window as argument.
5054
a54e3482
DC
50552011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5056
5057 * fns.c (Fputhash): Document return value.
5058
60002bf5
CY
50592011-06-06 Chong Yidong <cyd@stupidchicken.com>
5060
5061 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5062
0c671da6 50632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5064
b862a52a 5065 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5066
be44ca6c
PE
5067 Check for overflow when converting integer to cons and back.
5068 * charset.c (Fdefine_charset_internal, Fdecode_char):
5069 Use cons_to_unsigned to catch overflow.
5070 (Fencode_char): Use INTEGER_TO_CONS.
5071 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5072 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5073 * data.c (long_to_cons, cons_to_long): Remove.
5074 (cons_to_unsigned, cons_to_signed): New functions.
5075 These signal an error for invalid or out-of-range values.
5076 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5077 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5078 * font.c (Ffont_variation_glyphs):
5079 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5080 * lisp.h: Include <intprops.h>.
5081 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5082 (cons_to_signed, cons_to_unsigned): New decls.
5083 (long_to_cons, cons_to_long): Remove decls.
5084 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5085 (Fprimitive_undo): Use CONS_TO_INTEGER.
5086 * xfns.c (Fx_window_property): Likewise.
5087 * xselect.c: Include <limits.h>.
5088 (x_own_selection, selection_data_to_lisp_data):
5089 Use INTEGER_TO_CONS.
5090 (x_handle_selection_request, x_handle_selection_clear)
5091 (x_get_foreign_selection, Fx_disown_selection_internal)
5092 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5093 (lisp_data_to_selection_data): Use cons_to_unsigned.
5094 (x_fill_property_data): Use cons_to_signed.
5095 Report values out of range.
5096
d1f3d2af
PE
5097 Check for buffer and string overflow more precisely.
5098 * buffer.h (BUF_BYTES_MAX): New macro.
5099 * lisp.h (STRING_BYTES_MAX): New macro.
5100 * alloc.c (Fmake_string):
5101 * character.c (string_escape_byte8):
5102 * coding.c (coding_alloc_by_realloc):
5103 * doprnt.c (doprnt):
5104 * editfns.c (Fformat):
5105 * eval.c (verror):
5106 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5107 since they may not be the same number.
5108 * editfns.c (Finsert_char):
5109 * fileio.c (Finsert_file_contents):
5110 Likewise for BUF_BYTES_MAX.
5111
dd52fcea
PE
5112 * image.c: Use ptrdiff_t, not int, for sizes.
5113 (slurp_file): Switch from int to ptrdiff_t.
5114 All uses changed.
5115 (slurp_file): Check that file size fits in both size_t (for
5116 malloc) and ptrdiff_t (for sanity and safety).
5117
7f9bbdbb
PE
5118 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5119 if b->modtime has its maximal value.
5120
dfe18f82
PE
5121 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5122
84acfcf0
PE
5123 Don't assume time_t can fit into int.
5124 * buffer.h (struct buffer.modtime): Now time_t, not int.
5125 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5126 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5127
ccd9a01a
PE
5128 Minor fixes for signed vs unsigned integers.
5129 * character.h (MAYBE_UNIFY_CHAR):
5130 * charset.c (maybe_unify_char):
5131 * keyboard.c (read_char, reorder_modifiers):
5132 XINT -> XFASTINT, since the integer must be nonnegative.
5133 * ftfont.c (ftfont_spec_pattern):
5134 * keymap.c (access_keymap, silly_event_symbol_error):
5135 XUINT -> XFASTINT, since the integer must be nonnegative.
5136 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5137 since it makes no difference and we prefer signed.
5138 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5139 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5140 nonnegative.
5141
d6d100dd
SM
51422011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5143
5144 * window.h (Fwindow_frame): Declare.
5145
2b6148e4
PE
51462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5147
5148 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5149 (SPARE_MEMORY): Always define.
5150 (LARGE_REQUEST): Remove.
5151 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5152
f230ecc9
MR
51532011-06-06 Martin Rudalics <rudalics@gmx.at>
5154
727e958e
MR
5155 * lisp.h: Move EXFUNS for Fframe_root_window,
5156 Fframe_first_window and Fset_frame_selected_window to window.h.
5157
5158 * window.h: Move EXFUNS for Fframe_root_window,
5159 Fframe_first_window and Fset_frame_selected_window here from
5160 lisp.h.
5161
5162 * frame.c (Fwindow_frame, Fframe_first_window)
5163 (Fframe_root_window, Fframe_selected_window)
5164 (Fset_frame_selected_window): Move to window.c.
5165 (Factive_minibuffer_window): Move to minibuf.c.
5166 (Fother_visible_frames_p): New function.
5167
5168 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5169
f230ecc9
MR
5170 * window.c (decode_window, decode_any_window): Move up in code.
5171 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5172 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5173 (Fwindow_buffer): Move up and rewrite doc-string.
5174 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5175 (Fwindow_prev): New functions.
727e958e
MR
5176 (Fwindow_frame): Move here from frame.c. Accept any window as
5177 argument.
5178 (Fframe_root_window, Fframe_first_window)
5179 (Fframe_selected_window): Move here from frame.c. Accept frame
5180 or arbitrary window as argument. Update doc-strings.
5181 (Fminibuffer_window): Move up in code.
5182 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5183 (Fset_frame_selected_window): Move here from frame.c.
5184 Marginal rewrite.
727e958e
MR
5185 (Fselected_window, select_window, Fselect_window): Move up in
5186 code. Minor doc-string fixes.
f230ecc9 5187
4d09bcf6
PE
51882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5189
5190 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5191 Do not assume that spare memory exists; that assumption is valid
5192 only if SYSTEM_MALLOC.
5193 (LARGE_REQUEST): New macro, so that the issue of large requests
5194 is separated from the issue of spare memory.
5195
810928a2
AS
51962011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5197
172418ad
AS
5198 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5199 format. (Bug#8806)
5200
43f862f7
AS
5201 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5202
810928a2
AS
5203 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5204 before statements.
5205
a059fe24
JD
52062011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5207
5208 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5209
5210 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5211
5212 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5213 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5214
989bf368
JB
52152011-06-05 Juanma Barranquero <lekktu@gmail.com>
5216
5217 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5218
4b80f674
CY
52192011-06-04 Chong Yidong <cyd@stupidchicken.com>
5220
5221 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5222 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5223 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5224 New error handlers.
4b80f674
CY
5225 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5226 Obey Vx_select_enable_clipboard_manager. Catch errors in
5227 x_clipboard_manager_save (Bug#8779).
5228 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5229 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5230
99a33b77 52312011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5232
5233 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5234
99a33b77 52352011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5236
5237 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5238 in the current matrix if keep_current_p is non-zero.
5239
8264569d
EZ
52402011-06-04 Eli Zaretskii <eliz@gnu.org>
5241
5242 * bidi.c (bidi_level_of_next_char): Fix last change.
5243
57f97249
EZ
52442011-06-03 Eli Zaretskii <eliz@gnu.org>
5245
fec2107c 5246 Support bidi reordering of text covered by display properties.
57f97249 5247
fec2107c
EZ
5248 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5249 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5250 (bidi_cache_search, bidi_cache_iterator_state)
5251 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5252 (bidi_level_of_next_char, bidi_move_to_visually_next):
5253 Support character positions inside a run of characters covered by a
fec2107c
EZ
5254 display string.
5255 (bidi_paragraph_init, bidi_resolve_explicit_1)
5256 (bidi_level_of_next_char): Call bidi_fetch_char and
5257 bidi_fetch_char_advance instead of FETCH_CHAR and
5258 FETCH_CHAR_ADVANCE.
5259 (bidi_init_it): Initialize new members.
5260 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5261 definitions.
5262 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5263 instead of using explicit *_CHAR codes.
d6d100dd
SM
5264 (bidi_resolve_explicit, bidi_resolve_weak):
5265 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5266 bidirectional text is supported only in multibyte buffers.
5267 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5268 it to initialize the frame_window_p member of struct bidi_it.
5269 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5270 (bidi_resolve_explicit, bidi_resolve_weak)
5271 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5272 bidi_it->nchars is non-positive.
5273 (bidi_level_of_next_char): Don't try to lookup the cache for the
5274 next/previous character if nothing is cached there yet, or if we
5275 were just reseat()'ed to a new position.
c40e2fb2 5276
0e14fe90
EZ
5277 * xdisp.c (set_cursor_from_row): Set start and stop points
5278 according to the row's direction when priming the loop that looks
5279 for the glyph on which to display cursor.
5280 (single_display_spec_intangible_p): Function deleted.
5281 (display_prop_intangible_p): Reimplement to call
5282 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5283 Accept 3 additional arguments needed by handle_display_spec.
5284 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5285 values: lists, `(when COND...)' forms, etc.
5286 (single_display_spec_string_p): Support property values that are
5287 lists with the argument STRING its top-level element.
5288 (display_prop_string_p): Fix the condition for processing a
5289 property that is a list to be consistent with handle_display_spec.
fec2107c 5290 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5291 last portion of handle_display_prop.
5292 (compute_display_string_pos): Accept additional argument
5293 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5294 value of a `display' property is a "replacing spec".
5295 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5296 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5297 the display property, but just return a value indicating whether
5298 the display property will replace the characters it covers.
5299 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5300 frame_window_p members of struct bidi_it.
d6d100dd
SM
5301 (compute_display_string_pos, compute_display_string_end):
5302 New functions.
fec2107c
EZ
5303 (push_it): Accept second argument POSITION, where pop_it should
5304 jump to continue iteration.
5305 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5306
fec2107c
EZ
5307 * keyboard.c (adjust_point_for_property): Adjust the call to
5308 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5309
5310 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5311 (bidi_init_it): Update prototypes.
5312 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5313 (compute_display_string_pos, compute_display_string_end):
5314 Declare prototypes.
fec2107c
EZ
5315 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5316 EMACS_INT.
fc6f18ce 5317
40087514 53182011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5319
57f53182
PE
5320 Malloc failure behavior now depends on size of allocation.
5321 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5322 * lisp.h: Change signatures accordingly.
5323 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5324 All callers changed. (Bug#8762)
5325
5326 * gnutls.c: Use Emacs's memory allocators.
5327 Without this change, the gnutls library would invoke malloc etc.
5328 directly, which causes problems on non-SYNC_INPUT hosts, and which
5329 runs afoul of improving memory_full behavior. (Bug#8761)
5330 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5331 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5332 xfree instead of the default malloc, realloc, free.
5333 (Fgnutls_boot): No need to check for memory allocation failure,
5334 since xmalloc does that for us.
5335
ac32cd99 5336 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5337 * category.c (hash_get_category_set):
5338 * ccl.c (ccl_driver):
5339 * charset.c (Fdefine_charset_internal):
5340 * charset.h (struct charset.hash_index):
5341 * composite.c (get_composition_id, gstring_lookup_cache)
5342 (composition_gstring_put_cache):
5343 * composite.h (struct composition.hash_index):
5344 * dispextern.h (struct image.hash):
5345 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5346 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5347 (hashfn_equal, hashfn_user_defined, make_hash_table)
5348 (maybe_resize_hash_table, hash_lookup, hash_put)
5349 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5350 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5351 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5352 * image.c (make_image, search_image_cache, lookup_image)
5353 (xpm_put_color_table_h):
5354 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5355 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5356 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5357 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5358 * alloc.c (allocate_vectorlike):
5359 Check for overflow in vector size calculations.
5360 * ccl.c (ccl_driver):
5361 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5362 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5363 need to be updated by these changes.
40087514
PE
5364 * fns.c (make_hash_table, maybe_resize_hash_table):
5365 Check for integer overflow with large hash tables.
0de4bb68
PE
5366 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5367 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5368 (SXHASH_REDUCE): New macro.
5369 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5370 Use it instead of discarding useful hash info with large hash values.
5371 (sxhash_float): New function.
5372 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5373 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5374 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5375 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5376 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5377 Adjust signatures to match updated version of code.
5378 (consing_since_gc): Now EMACS_INT, since a single hash table can
5379 use more than INT_MAX bytes.
5380
698d32e2
DN
53812011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5382
5383 Make it possible to build with GCC-4.6+ -O2 -flto.
5384
5385 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5386
fd6fa53f
SM
53872011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5388
5389 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5390 Call minibuffer-inactive-mode.
5391
864db017
JB
53922011-05-31 Juanma Barranquero <lekktu@gmail.com>
5393
5394 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5395 Update dependencies.
5396
2ad0baf4
DN
53972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5398
5399 * data.c (init_data): Remove code for UTS, this system is not
5400 supported anymore.
5401
4fcc2638
DN
54022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5403
5404 Don't force ./temacs to start in terminal mode.
5405
5406 * frame.c (make_initial_frame): Initialize faces in all cases, not
5407 only when CANNOT_DUMP is defined.
5408 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5409
c56e0fd5
DN
54102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5411
5412 * dispnew.c (add_window_display_history): Use const for the string
5413 pointer. Remove declaration, not needed.
5414
333d54da 54152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5416
55d4c1b2 5417 Use 'inline', not 'INLINE'.
333d54da 5418 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5419 * alloc.c, fontset.c (INLINE): Remove.
5420 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5421 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5422 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5423 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5424 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5425
738db178
DN
54262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5427
5428 Make it possible to run ./temacs.
5429
5430 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5431 syms_of_callproc does the same thing. Remove test for
5432 "initialized", do it in the caller.
5433 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5434
620c53a6
SM
54352011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5436
5437 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5438 (read_minibuf): Use get_minibuffer.
5439 (syms_of_minibuf): Use DEFSYM.
5440 (Qmetadata): New var.
5441 * data.c (Qbuffer): Don't make it static.
5442 (syms_of_data): Use DEFSYM.
5443
e003a292
PE
54442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5445
5446 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5447 (CCL_CODE_MIN): New macro.
5448
ed008a6d
PE
54492011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5450
3687c2ef
PE
5451 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5452
ed008a6d
PE
5453 * eval.c (Qdebug): Now static.
5454 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5455 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5456 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5457
d66c4c7c
CY
54582011-05-29 Chong Yidong <cyd@stupidchicken.com>
5459
5460 * image.c: Various fixes to ImageMagick code comments.
5461 (Fimagemagick_types): Doc fix.
5462
5fbc2025
PE
54632011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5464
0196f88a
PE
5465 Minor fixes prompted by GCC 4.6.0 warnings.
5466
5467 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5468
5fbc2025
PE
5469 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5470 (x_clipboard_manager_save_all): Move extern decl to ...
5471 * xterm.h: ... here, so that it can be checked for consistency.
5472
1dd3c2d9
CY
54732011-05-29 Chong Yidong <cyd@stupidchicken.com>
5474
5475 * xselect.c (x_clipboard_manager_save_frame)
5476 (x_clipboard_manager_save_all): New functions.
5477 (Fx_clipboard_manager_save): Lisp function deleted.
5478
5479 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5480 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5481
5482 * xterm.h: Update prototype.
5483
5ba6571d
WX
54842011-05-28 William Xu <william.xwl@gmail.com>
5485
5486 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5487 exiting (Bug#8239).
5488
3eaff834
JM
54892011-05-28 Jim Meyering <meyering@redhat.com>
5490
e1900994 5491 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5492 * fns.c (to_uchar): Define.
5493 (crypto_hash_function): Use it to convert some newly-signed
5494 variables to unsigned, to avoid sign-extension bugs. For example,
5495 without this change, (md5 "truc") would evaluate to
5496 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5497 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5498 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5499
0f6990a7
PE
55002011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5501
5502 Integer overflow fixes.
c8a9ca5a 5503
08686060
PE
5504 * dbusbind.c: Serial number integer overflow fixes.
5505 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5506 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5507 to hold a serial number that is too large for a fixnum.
5508 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5509 Check for serial numbers out of range. Decode any serial number
59568bf0 5510 that was so large that it became a float. (Bug#8722)
08686060 5511
2d1fc3c7
PE
5512 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5513 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5514 Use XFASTINT rather than XUINT when numbers are nonnegative.
5515 (xd_append_arg, Fdbus_method_return_internal):
5516 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5517 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5518 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5519 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5520 (Bug#8722)
2d1fc3c7 5521
c8a9ca5a
PE
5522 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5523
519e1d69
PE
5524 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5525
30569699
PE
5526 ccl: add integer overflow checks
5527 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5528 (IN_INT_RANGE): New macros.
5529 (ccl_driver): Use them to check for integer overflow when
5530 decoding a CCL program. Many of the new checks are whether XINT (x)
5531 fits in int; it doesn't always, on 64-bit hosts. The new version
5532 doesn't catch all possible integer overflows, but it's an
847044ea 5533 improvement. (Bug#8719)
30569699 5534
c11285dc
PE
5535 * alloc.c (make_event_array): Use XINT, not XUINT.
5536 There's no need for unsigned here.
5537
fdccd48e
PE
5538 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5539 This follows up to the 2011-05-06 change that substituted uintptr_t
5540 for EMACS_INT. This case wasn't caught back then.
5541
37910ab2
PE
5542 Rework Fformat to avoid integer overflow issues.
5543 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5544 now (part of C89). Include <verify.h>.
5545 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5546 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5547 (Fformat): Avoid the prepass trying to compute sizes; it was only
5548 approximate and thus did not catch overflow reliably. Instead, walk
5549 through the format just once, formatting and computing sizes as we go,
5550 checking for integer overflow at every step, and allocating a larger
5551 buffer as needed. Keep track separately whether the format is
5552 multibyte. Keep only the most-recently calculated precision, rather
5553 than them all. Record whether each argument has been converted to
5554 string. Use EMACS_INT, not int, for byte and char and arg counts.
5555 Support field widths and precisions larger than INT_MAX. Avoid
5556 sprintf's undefined behavior with conversion specifications such as %#d
5557 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5558 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5559 formatting out-of-range floating point numbers with int
9173deec 5560 formats. (Bug#8668)
37910ab2 5561
2e6578fb
PE
5562 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5563
0ae6bdee
PE
5564 * data.c: Avoid integer truncation in expressions involving floats.
5565 * data.c: Include <intprops.h>.
5566 (arith_driver): When there's an integer overflow in an expression
5567 involving floating point, convert the integers to floating point
5568 so that the resulting value does not suffer from catastrophic
5569 integer truncation. For example, on a 64-bit host (* 4
5570 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5571 Do not rely on undefined behavior after integer overflow.
5572
de883a70
PE
5573 merge count_size_as_multibyte, parse_str_to_multibyte
5574 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5575 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5576 Check for integer overflow.
5577 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5578 since it's now a duplicate of the other. This is more of
5579 a character than a buffer op, so better that it's in character.c.
5580 * fns.c, print.c: Adjust to above changes.
5581
2ff916cb
PE
55822011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5583
5584 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5585
f1b54466
PE
55862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5587
fb1ac845
PE
5588 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5589 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5590 (x_clipboard_manager_save): Now static.
5591 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5592
f1b54466
PE
5593 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5594 (crypto_hash_function): Now static.
5595 Fix pointer signedness problems. Avoid unnecessary initializations.
5596
a9f737ee
CY
55972011-05-27 Chong Yidong <cyd@stupidchicken.com>
5598
5599 * termhooks.h (Vselection_alist): Make it terminal-local.
5600
5601 * terminal.c (create_terminal): Initialize it.
5602
5603 * xselect.c: Support for clipboard managers.
5604 (Vselection_alist): Move to termhooks.h as terminal-local var.
5605 (LOCAL_SELECTION): New macro.
5606 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5607 (symbol_to_x_atom): Remove gratuitous arg.
5608 (x_handle_selection_request, lisp_data_to_selection_data)
5609 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5610 (x_own_selection, x_get_local_selection, x_convert_selection):
5611 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5612 (some_frame_on_display): Delete unused function.
5613 (Fx_own_selection_internal, Fx_get_selection_internal)
5614 (Fx_disown_selection_internal, Fx_selection_owner_p)
5615 (Fx_selection_exists_p): New optional frame arg.
5616 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5617 (x_handle_selection_clear): Don't treat other terminals with the
5618 same keyboard specially. Use the terminal-local Vselection_alist.
5619 (x_clear_frame_selections): Use Frun_hook_with_args.
5620
5621 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5622
5623 * xterm.h: Add support for those atoms.
5624
e067f0c1
CY
56252011-05-26 Chong Yidong <cyd@stupidchicken.com>
5626
5627 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5628 (converted_selections, conversion_fail_tag): New global variables.
5629 (x_selection_request_lisp_error): Free the above.
5630 (x_get_local_selection): Remove unnecessary code.
5631 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5632 of converted selections stored in converted_selections.
5633 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5634 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5635 (x_convert_selection): New function.
5636 (x_handle_selection_event): Simplify.
5637 (x_get_foreign_selection): Don't ignore incoming requests while
5638 waiting for an answer; this will fail when we implement
5639 SAVE_TARGETS, and seems unnecessary anyway.
5640 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5641 (Vx_sent_selection_functions): Doc fix.
5642
0f4aebc0
LL
56432011-05-26 Leo Liu <sdl.web@gmail.com>
5644
5645 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5646
e61124cd
YM
56472011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5648
5649 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5650
5651 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5652 for fringe update if it has periodic bitmap.
ac389d0c 5653 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5654 and fringe_bitmap_periodic_p.
5655
5656 * fringe.c (get_fringe_bitmap_data): New function.
5657 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5658 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5659 row. Mark glyph row for fringe update if periodicity changed.
5660
5661 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5662 for fringe update unless it has periodic bitmap.
5663
f16d9837
KH
56642011-05-25 Kenichi Handa <handa@m17n.org>
5665
5666 * xdisp.c (get_next_display_element): Set correct it->face_id for
5667 a static composition.
5668
e1b90ef6
LL
56692011-05-24 Leo Liu <sdl.web@gmail.com>
5670
5671 * deps.mk (fns.o):
5672 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5673
5674 * fns.c (crypto_hash_function, Fsha1): New function.
5675 (Fmd5): Use crypto_hash_function.
5676 (syms_of_fns): Add Ssha1.
5677
7400048f
PE
56782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5679
5680 * gnutls.c: Remove unused macros.
5681 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5682 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5683 Remove macros that are defined and never used.
5684 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5685
abb71cf4
CY
56862011-05-22 Chong Yidong <cyd@stupidchicken.com>
5687
5688 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5689 (Fx_get_selection_internal): Minor cleanup.
5690 (Fx_own_selection_internal): Rename arguments for consistency with
5691 select.el.
5692
6307db39
PE
56932011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5694
5695 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5696
f3d4e0a4
CY
56972011-05-22 Chong Yidong <cyd@stupidchicken.com>
5698
5699 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5700
4d8ade89
YM
57012011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5702
5703 * dispnew.c (scrolling_window): Don't exclude the case that the
5704 last enabled row in the desired matrix touches the bottom boundary.
5705
32078c8d
GM
57062011-05-21 Glenn Morris <rgm@gnu.org>
5707
5708 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5709 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5710 and add some more files.
32078c8d 5711
7285dc67
EZ
57122011-05-20 Eli Zaretskii <eliz@gnu.org>
5713
5714 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5715 report_file_error introduced by the change from 2011-05-07.
5716
89d1bd22
PE
57172011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5718
5719 * systime.h (Time): Define only if emacs is defined.
5720 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5721 where the include path doesn't have X11/X.h by default. See
5722 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5723
e23640bb 57242011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5725
5726 * composite.c (find_automatic_composition): Fix previous change.
5727
b9704ad9
GM
57282011-05-20 Glenn Morris <rgm@gnu.org>
5729
5730 * lisp.mk: New file, split from Makefile.in.
5731 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5732 (shortlisp): Remove.
5733 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5734
4a720484
GM
57352011-05-19 Glenn Morris <rgm@gnu.org>
5736
5737 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5738 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5739 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5740 (lisp): Set the order to that of loadup.el.
5741 (shortlisp): Make it a copy of $lisp.
5742 (SOME_MACHINE_LISP): Remove.
5743 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5744 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5745
a28d4396
KH
57462011-05-18 Kenichi Handa <handa@m17n.org>
5747
5748 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5749 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5750 (find_automatic_composition): Mostly rewrite for efficiency.
5751
a2b1fa8e
JB
57522011-05-18 Juanma Barranquero <lekktu@gmail.com>
5753
5754 * makefile.w32-in: Update dependencies.
5755
8e1f5610
CS
57562011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5757
5758 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5759 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5760
7025ee00 57612011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5762
cdfa6eab
PE
5763 Fix some integer overflow issues, such as string length overflow.
5764
06d6db33
PE
5765 * insdel.c (count_size_as_multibyte): Check for string overflow.
5766
2b4560a8
PE
5767 * character.c (lisp_string_width): Check for string overflow.
5768 Use EMACS_INT, not int, for string indexes and lengths; in
5769 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5770 the resulting string length overflows an EMACS_INT; instead,
5771 report a string overflow if no precision given. When checking for
5772 precision exhaustion, use a check that cannot possibly have
5773 integer overflow. (Bug#8675)
5774 * character.h (lisp_string_width): Adjust to new signature.
5775
cb93f9be
PE
5776 * alloc.c (string_overflow): New function.
5777 (Fmake_string): Use it. This doesn't change behavior, but saves
5778 a few bytes and will simplify future changes.
5779 * character.c (string_escape_byte8): Likewise.
5780 * lisp.h (string_overflow): New decl.
5781
1a1f3366
PE
5782 Fixups, following up to the user-interface timestamp change.
5783 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5784 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5785 * msdos.c (mouse_get_pos): Likewise.
5786 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5787 * w32gui.h (Time): Define by including "systime.h" rather than by
5788 declaring it ourselves. (Bug#8664)
5789
d4e3e4d3
PE
5790 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5791 * image.c (clear_image_cache): Likewise.
5792
f6a24d19
PE
5793 * term.c (term_mouse_position): Don't assume time_t wraparound.
5794
08dc5ae6
PE
5795 Be more systematic about user-interface timestamps.
5796 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5797 and sometimes 'EMACS_UINT', to represent these timestamps.
5798 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5799 This makes the code easier to follow, and makes it easier to catch
5800 integer overflow bugs such as Bug#8664.
5801 * frame.c (Fmouse_position, Fmouse_pixel_position):
5802 Use Time, not unsigned long, for user-interface timestamps.
5803 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5804 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5805 * keyboard.h (last_event_timestamp): Likewise.
5806 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5807 * menu.h (xmenu_show): Likewise.
5808 * term.c (term_mouse_position): Likewise.
5809 * termhooks.h (struct input_event.timestamp): Likewise.
5810 (struct terminal.mouse_position_hook): Likewise.
5811 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5812 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5813 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5814 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5815 what it was before.
5816 * menu.h, termhooks.h: Include "systime.h", for Time.
5817
8e55734a
PE
5818 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5819 Don't assume that the difference between two unsigned long values
5820 can fit into an integer. At this point, we know button_down_time
5821 <= event->timestamp, so the difference must be nonnegative, so
5822 there's no need to cast the result if double-click-time is
5823 nonnegative, as it should be; check that it's nonnegative, just in
5824 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5825 apart (about 25 days). (Bug#8664)
8e55734a 5826
841f1b75 5827 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5828 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5829
3e26f69c
PE
5830 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5831 that always fit in int. Use a sentinel instead of a counter, to
5832 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5833 * frame.h (struct frame): Use int for menu_bar_items_used
5834 instead of EMACS_INT, since it always fits in int.
3e26f69c 5835
5cc152c0
PE
5836 * menu.c (grow_menu_items): Check for int overflow.
5837
d89eb65e
PE
5838 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5839
5235bd3e
PE
5840 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5841 Before, the code was not consistent. These values cannot exceed
5842 2**31 - 1 so there's no need to make them unsigned.
5843 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5844 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5845 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5846 as modifiers.
5847 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5848
bc827e23
PE
5849 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5850 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5851 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5852 presumably because the widths might not match.
5853
78eb494e
PE
5854 * window.c (size_window): Avoid needless test at loop start.
5855
04f2d78b
CB
58562011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5857
5858 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5859
d2fc7e3d 58602011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5861
5862 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5863
d2fc7e3d 58642011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5865
5866 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5867 `width' to `bar_area_x' and `bar_area_width', respectively.
5868 (x_scroll_run): Take account of fringe background extension.
5869
04f2d78b
CB
5870 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5871 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5872 `bar_area_width', respectively.
5873 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5874 background extension.
5875
79b70037
GM
58762011-05-10 Jim Meyering <meyering@redhat.com>
5877
5878 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5879
2f142cc5
JB
58802011-05-10 Juanma Barranquero <lekktu@gmail.com>
5881
5882 * image.c (Finit_image_library): Return t for built-in image types,
5883 like pbm and xbm. (Bug#8640)
5884
57679c86
AS
58852011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5886
5887 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5888
888c9e86
EZ
58892011-05-07 Eli Zaretskii <eliz@gnu.org>
5890
b0512a1d
EZ
5891 * w32console.c (Fset_screen_color): Doc fix.
5892 (Fget_screen_color): New function.
5893 (syms_of_ntterm): Defsubr it.
5894
7285dc67
EZ
5895 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5896 unlink the temporary file if Fcall_process didn't create it in the
5897 first place.
5898 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5899 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5900 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5901 cue to call_process_cleanup not to close that handle.
5902
4d3fcc8e
BK
59032011-05-07 Ben Key <bkey76@gmail.com>
5904
5905 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5906 one of two shell specific rules, either bootstrap-temacs-CMD or
5907 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5908 to the previous implementation of the bootstrap-temacs rule.
5909 The bootstrap-temacs-CMD rule is similar to the previous
5910 implementation of the bootstrap-temacs rule except that it
5911 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5912 variable.
5913
5914 These changes, along with some changes to nt/configure.bat,
5915 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5916 earlier fix to add support for --cflags and --ldflags options
5917 that include quotes so that it works whether make uses cmd or
5918 sh as the shell.
5919
b4289b64
MA
59202011-05-06 Michael Albinus <michael.albinus@gmx.de>
5921
5922 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5923 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5924 is a constant.
5925 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5926 a string. Handle both cases.
5927 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5928 (Fdbus_register_method): Use Qinvalid_function.
5929
af4c0e28
JB
59302011-05-06 Juanma Barranquero <lekktu@gmail.com>
5931
5932 * makefile.w32-in: Update dependencies.
5933 (LISP_H): Add inttypes.h and stdin.h.
5934 (PROCESS_H): Add unistd.h.
5935
c51453d9
EZ
59362011-05-06 Eli Zaretskii <eliz@gnu.org>
5937
5938 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5939 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5940
8ff0ac3c 59412011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5942
4c4b566b
PE
5943 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5944
aab2b9b5
PE
5945 * term.c (vfatal): Remove stray call to va_end.
5946 It's not needed and the C Standard doesn't allow it here anyway.
5947
c378da0b
PE
5948 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5949 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5950
288b08c7
PE
5951 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5952 bytes.
5953
e3601888
PE
5954 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5955
db6c0e74
PE
5956 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5957
dd5963ea
PE
5958 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5959
88c9450f
PE
5960 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5961
2f9442b8
PE
5962 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5963
c032b5f8
PE
5964 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5965 * charset.c (Fdefine_charset_internal): Don't initialize
5966 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5967 32-bit int (Bug#8600).
a108c10b
PE
5968
5969 * lread.c (read_integer): Be more consistent with string-to-number.
5970 Use string_to_number to do the actual conversion; this avoids
5971 rounding errors and fixes some other screwups. Without this fix,
5972 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5973 (digit_to_number): Move earlier, for benefit of read_integer.
5974 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5975 not a digit in any supported base. (Bug#8602)
a108c10b 5976
ad5f9eea
PE
5977 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5978
aec1708a
PE
5979 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5980 to match comment at start of function. This also removes a
5981 GCC warning about overflow in a 32+64-bit port.
5982
47be4ab5
PE
5983 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5984
371cac43
PE
5985 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5986 Reported by Stefan Monnier in
5987 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5988 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5989 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5990
d01a7826
PE
5991 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5992 (EMACS_UINTPTR): Likewise, with uintptr_t.
5993
7fd47d5c
PE
5994 * lisp.h: Prefer 64-bit EMACS_INT if available.
5995 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5996 on 32-bit hosts that have 64-bit int, so that they can access
5997 large files.
122b0c86
PE
5998 However, temporarily disable this change unless the temporary
5999 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6000
8727937b
PE
6001 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6002
8ac068ac
PE
6003 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6004 This removes an assumption that EMACS_INT and long are the same
6005 width as pointers. The assumption is true for Emacs porting targets
6006 now, but we want to make other targets possible.
6007 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6008 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6009 In the rest of the code, change types of integers that hold casted
6010 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6011 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6012 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6013 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6014 No need to cast type when ORing.
6015 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6016 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6017 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6018 assume EMACS_INT is the same width as char *.
6019 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6020 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6021 Remove no-longer-needed casts.
6022 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6023 (xg_tool_bar_help_callback, xg_make_tool_item):
6024 Use EMACS_INTPTR to hold an integer
6025 that will be cast to void *; this can avoid a GCC warning
6026 if EMACS_INT is not the same width as void *.
6027 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6028 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6029 (current_message_1, set_message_1):
6030 Use a local to convert to proper width without a cast.
6031 * xmenu.c (dialog_selection_callback): Likewise.
6032
ede49d71
PE
6033 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6034 Also, don't assume VALBITS / RAND_BITS is less than 5,
6035 and don't rely on undefined behavior when shifting a 1 left into
6036 the sign bit.
6037 * lisp.h (get_random): Change signature to match.
6038
2f30ecd0
PE
6039 * lread.c (hash_string): Use size_t, not int, for hash computation.
6040 Normally we prefer signed values; but hashing is special, because
6041 it's better to use unsigned division on hash table sizes so that
6042 the remainder is nonnegative. Also, size_t is the natural width
6043 for hashing into memory. The previous code used 'int', which doesn't
6044 retain enough info to hash well into very large tables.
6045 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6046
2a866e7b
PE
6047 * dbusbind.c: Don't possibly lose pointer info when converting.
6048 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6049 Use XPNTR rather than XHASH, so that the high-order bits of
6050 the pointer aren't lost when converting through void *.
6051
51639eac
PE
6052 * eval.c (Fautoload): Don't double-shift a pointer.
6053
92394119
PE
6054 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6055
dbdb9a7c
JB
60562011-05-06 Juanma Barranquero <lekktu@gmail.com>
6057
6058 * gnutls.c (DEF_GNUTLS_FN):
6059 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6060
db7a0b4f
AS
60612011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6062
6063 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6064 marker. (Bug#8610)
6065
f7ff1b0f 60662011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6067
6068 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6069 New version that can reserve upto 2GB of heap space.
6070
f7ff1b0f 60712011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6072
6073 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6074
639c109b
TZ
60752011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6076
6077 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6078 `gnutls_certificate_set_x509_key_file'.
6079
d2127135
JB
60802011-05-05 Juanma Barranquero <lekktu@gmail.com>
6081
6082 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6083 Update dependencies.
6084
e968f4f3
JB
60852011-05-04 Juanma Barranquero <lekktu@gmail.com>
6086
6087 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6088 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6089 Remove unused parameter `fildes'.
6090 * process.c (read_process_output, send_process): Don't pass it.
6091
84d358f0
JB
60922011-05-04 Juanma Barranquero <lekktu@gmail.com>
6093
6094 Fix previous change: the library cache is defined in w32.c.
6095 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6096 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6097
0898ca10
JB
60982011-05-04 Juanma Barranquero <lekktu@gmail.com>
6099
6100 Implement dynamic loading of GnuTLS on Windows.
6101
6102 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6103 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6104 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6105 Declare.
6106
6107 * gnutls.c (Qgnutls_dll): Define.
6108 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6109 (gnutls_*): Declare function pointers.
6110 (init_gnutls_functions): New function to initialize function pointers.
6111 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6112 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6113 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6114 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6115 (emacs_gnutls_write, emacs_gnutls_read)
6116 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6117 (Fgnutls_available_p): New function.
6118 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6119 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6120 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6121
6122 * image.c: Include w32.h.
6123 (Vimage_type_cache): Delete.
6124 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6125 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6126 (w32_delayed_load): Move to w32.c.
6127
6128 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6129
6130 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6131 (w32_delayed_load): Move from image.c. When loading a library, record
6132 its filename in the :loaded-from property of the library id.
6133 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6134 Initialize and staticpro them.
6135 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6136
6137 * process.c: Include lisp.h before w32.h, not after.
6138 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6139 instead of gnutls_record_check_pending.
6140
6141 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6142
ff4de4aa
TZ
61432011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6144
6145 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6146 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6147 as passed in.
6148
abe95abb
JD
61492011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6150
6151 * xterm.c (x_set_frame_alpha): Do not set property on anything
6152 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6153
e16e55d4
JB
61542011-05-02 Juanma Barranquero <lekktu@gmail.com>
6155
6156 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6157
bafcf6a5
JB
61582011-05-02 Juanma Barranquero <lekktu@gmail.com>
6159
6160 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6161 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6162 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6163 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6164 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6165 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6166 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6167 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6168 (Qgnutls_bootprop_callbacks_verify): Make static.
6169
e7a6747f
AS
61702011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6171
19ed11ba
AS
6172 * callproc.c: Indentation fixup.
6173
e7a6747f 6174 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6175 (wait_for_termination, interruptible_wait_for_termination):
6176 Move after wait_for_termination_1.
e7a6747f 6177
1ef14cb4
LMI
61782011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6179
6180 * sysdep.c (interruptible_wait_for_termination): New function
6181 which is like wait_for_termination, but allows keyboard
6182 interruptions.
6183
6184 * callproc.c (Fcall_process): Add (:file "file") as an option for
6185 the STDOUT buffer.
6186 (Fcall_process_region): Ditto.
6187
330d880c
EZ
61882011-04-30 Eli Zaretskii <eliz@gnu.org>
6189
8db90b73
EZ
6190 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6191 rather than `XVECTOR (FOO)->size'.
6192
330d880c
EZ
6193 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6194 inttypes.h, as a gnulib replacement is used if it not available in
6195 system headers.
6196
15cbd324
EZ
61972011-04-21 Eli Zaretskii <eliz@gnu.org>
6198
6199 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6200 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6201 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6202
6203 * coding.c (coding_alloc_by_realloc): Error out if destination
6204 will grow beyond MOST_POSITIVE_FIXNUM.
6205 (decode_coding_emacs_mule): Abort if there isn't enough place in
6206 charbuf for the composition carryover bytes. Reserve an extra
6207 space for up to 2 characters produced in a loop.
6208 (decode_coding_iso_2022): Abort if there isn't enough place in
6209 charbuf for the composition carryover bytes.
6210
62112011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6212
ae940cca
EZ
6213 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6214 aborting when %lld or %lll format is passed.
6215 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6216 %llo or %llx format is passed. (Bug#8545)
6217
03ab8921
EZ
6218 * window.c (window_scroll_line_based): Use a marker instead of
6219 simple variables to record original value of point. (Bug#7952)
6220
afda1437
EZ
6221 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6222 produced by %s or %c overflows available buffer space. (Bug#8545)
6223
f76dee0c
PE
62242011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6225
6226 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6227 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6228
fdc5744d
JB
62292011-04-28 Juanma Barranquero <lekktu@gmail.com>
6230
6231 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6232
638f053a
JB
62332011-04-28 Juanma Barranquero <lekktu@gmail.com>
6234
6235 * keyboard.c (Qdelayed_warnings_hook): Define.
6236 (command_loop_1): Run `delayed-warnings-hook'
6237 if Vdelayed_warnings_list is non-nil.
6238 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6239 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6240
d178f871
EZ
62412011-04-28 Eli Zaretskii <eliz@gnu.org>
6242
6243 * doprnt.c (doprnt): Don't return value smaller than the buffer
6244 size if the message was truncated. (Bug#8545).
6245
b124fd93
JB
62462011-04-28 Juanma Barranquero <lekktu@gmail.com>
6247
6248 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6249 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6250
e810457d
PE
62512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6252
6253 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6254
ea51cceb
JB
62552011-04-27 Juanma Barranquero <lekktu@gmail.com>
6256
6257 * makefile.w32-in: Update dependencies.
6258
94dcfacf
EZ
62592011-04-27 Eli Zaretskii <eliz@gnu.org>
6260
6261 Improve `doprnt' and its usage. (Bug#8545)
6262 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6263 `format_end'. Remove support for %l as a conversion specifier.
6264 Don't use xrealloc. Improve diagnostics when the %l size modifier
6265 is used. Update the commentary.
6266
6267 * eval.c (verror): Simplify calculation of size_t.
6268
6269 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6270 messages.
6271
f61f41d7
PE
62722011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6273
6274 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6275 change.
6276
96fb4434
PE
62772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6278
6279 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6280 This makes this file independent of the recent pseudovector change.
6281
671875da 62822011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6283
69e9b5a3
PE
6284 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6285
b5f869a7 6286 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6287 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6288 Remove unused local.
c8926152 6289 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6290
841a1577 6291 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6292 GCC 4.6.0 optimizes based on type-based alias analysis.
6293 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6294 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6295 != &v->size, and therefore "v->size = 1; b->size = 2; return
6296 v->size;" must therefore return 1. This assumption is incorrect
6297 for Emacs, since it type-puns struct Lisp_Vector * with many other
6298 types. To fix this problem, this patch adds a new type struct
f904488f 6299 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6300 and pseudovectors, and helps optimizing compilers not get fooled
6301 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6302 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6303 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6304 the size member.
eab3844f
PE
6305 (XSETPVECTYPE): Rewrite in terms of new macro.
6306 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6307 This is a bit clearer, and further avoids the possibility of
6308 undesirable aliasing.
6309 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6310 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6311 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6312 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6313 (ASIZE): Now uses header.size rather than size.
6314 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6315 to avoid the hassle of writing XVECTOR (foo)->header.size.
6316 (struct vectorlike_header): New type.
eab3844f
PE
6317 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6318 object, to help avoid aliasing.
6319 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6320 (SUBRP): Likewise, since Lisp_Subr is a special case.
6321 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6322 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6323 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6324 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6325 changed to be "header.size" and "header.next".
6326 * buffer.h (struct buffer): Likewise.
6327 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6328 * frame.h (struct frame): Likewise.
6329 * process.h (struct Lisp_Process): Likewise.
6330 * termhooks.h (struct terminal): Likewise.
6331 * window.c (struct save_window_data, struct saved_window): Likewise.
6332 * window.h (struct window): Likewise.
6333 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6334 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6335 * buffer.c (init_buffer_once): Likewise.
6336 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6337 special case.
6338 * process.c (Fformat_network_address): Use local var for size,
6339 for brevity.
6340
0df1eac5
PE
6341 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6342
847ab9d1 6343 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6344 * data.c (atof): Remove decl; no longer used or needed.
6345 (digit_to_number): Move to lread.c.
6346 (Fstring_to_number): Use new string_to_number function, to be
6347 consistent with how the Lisp reader treats infinities and NaNs.
6348 Do not assume that floating-point numbers represent EMACS_INT
6349 without losing information; this is not true on most 64-bit hosts.
6350 Avoid double-rounding errors, by insisting on integers when
6351 parsing non-base-10 numbers, as the documentation specifies.
6352 * lisp.h (string_to_number): New decl, replacing ...
6353 (isfloat_string): Remove.
bc0a5c13 6354 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6355 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6356 appears to have been a coding error. Similarly, do not accept
6357 strings like +-1e0 as floating point numbers. Do not report
6358 overflow for integer overflows unless the base is not 10 which
6359 means we have no simple and reliable way to continue.
6360 Break out the floating-point parsing into a new
6361 function string_to_number, so that Fstring_to_number parses
6362 floating point numbers consistently with the Lisp reader.
04f2d78b 6363 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6364 (E_CHAR, EXP_INT): Remove, replacing with ...
6365 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6366 (string_to_number): New function, replacing isfloat_string.
6367 This function checks for valid syntax and produces the resulting
6368 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6369 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6370 so that overflow for non-base-10 numbers is reported only when
6371 there's no portable and simple way to convert to floating point.
452f4150 6372
67769ffc
PE
6373 * textprop.c (set_text_properties_1): Rewrite for clarity,
6374 and to avoid GCC warning about integer overflow.
6375
c20db43f
PE
6376 * intervals.h (struct interval): Use EMACS_INT for members
6377 where EMACS_UINT might cause problems. See
6378 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6379 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6380 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6381 All uses changed.
37aa2f85
PE
6382 (offset_intervals): Tell GCC not to worry about length overflow
6383 when negating a negative length.
c20db43f 6384
2538aa2f
PE
6385 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6386 (overrun_check_free): Likewise.
6387
f2d3008d
PE
6388 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6389 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6390 word size.
6391
ec8df744
PE
6392 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6393 (gnutls_make_error): Rename local to avoid shadowing.
6394 (gnutls_emacs_global_deinit): ifdef out; not used.
6395 (Fgnutls_boot): Use const for pointer to readonly storage.
6396 Comment out unused local. Fix pointer signedness problems.
6397
640ee02d
PE
6398 * lread.c (openp): Don't stuff size_t into an 'int'.
6399 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6400 about possible signed overflow.
6401
6048fb2a
PE
6402 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6403 (GDK_KEY_g): Don't define if already defined.
6404 (xg_prepare_tooltip): Avoid pointer signedness problem.
6405 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6406
fa3c87e1
PE
6407 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6408 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6409
2172544b
PE
6410 * xfns.c (Fx_window_property): Simplify a bit,
6411 to make a bit faster and to avoid GCC 4.6.0 warning.
6412 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6413
9b821a21
PE
6414 * fns.c (internal_equal): Don't assume size_t fits in int.
6415
3c616cfa
PE
6416 * alloc.c (compact_small_strings): Tighten assertion a little.
6417
c2982e87
PE
6418 Replace pEd with more-general pI, and fix some printf arg casts.
6419 * lisp.h (pI): New macro, generalizing old pEd macro to other
6420 conversion specifiers. For example, use "...%"pI"d..." rather
6421 than "...%"pEd"...".
6422 (pEd): Remove. All uses replaced with similar uses of pI.
6423 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6424 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6425 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6426 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6427 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6428 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6429 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6430 64-bit hosts.
6431 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6432 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6433 * print.c (safe_debug_print, print_object): Likewise.
6434 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6435 to int.
6f04d126
PE
6436 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6437 avoiding the 0 flag, which is not portable.
c2982e87
PE
6438 * process.c (Fmake_network_process): Use pI to avoid cast.
6439 * region-cache.c (pp_cache): Likewise.
6440 * xdisp.c (decode_mode_spec): Likewise.
6441 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6442 behavior on 64-bit hosts with printf arg.
6f04d126 6443 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6444 (x_stop_queuing_selection_requests): Likewise.
6445 (x_get_window_property): Don't truncate byte count to an 'int'
6446 when tracing.
0b432f21 6447
5e073ec7
PE
6448 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6449 here, since it parses constructs like leading '-' and spaces,
6450 which are not wanted; and it overflows with large numbers.
6451 Instead, simply match F[0-9]+, which is what is wanted anyway.
6452
36372bf9
PE
6453 * alloc.c: Remove unportable assumptions about struct layout.
6454 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6455 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6456 (allocate_vectorlike, make_pure_vector): Use the new macros,
6457 plus offsetof, to remove unportable assumptions about struct layout.
6458 These assumptions hold on all porting targets that I know of, but
6459 they are not guaranteed, they're easy to remove, and removing them
6460 makes further changes easier.
6461
0b432f21
PE
6462 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6463 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6464 (string_overrun_cookie): Now const. Use initializers that
6465 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6466 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6467 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6468 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6469 multiple of sizeof (EMACS_INT); it need not be, if
6470 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6471 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6472
895009e1
JB
64732011-04-26 Juanma Barranquero <lekktu@gmail.com>
6474
6475 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6476
6a7a1b0b
TZ
64772011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6478
6479 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6480 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6481 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6482
841a1577 64832011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6484
6485 * lisp.h (Qdebug): List symbol.
895009e1 6486 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6487 * keyboard.c (debug-on-event): New variable.
6488 (handle_user_signal): Break into debugger when debug-on-event
6489 matches the current signal symbol.
6490
f2d3ba6f
DN
64912011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6492
6493 * alloc.c (check_sblock, check_string_bytes)
6494 (check_string_free_list): Convert to standard C.
6495
42ce4c63
TZ
64962011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6497
6498 * w32.c (emacs_gnutls_push): Fix typo.
6499
825cd63c
EZ
65002011-04-25 Eli Zaretskii <eliz@gnu.org>
6501
fb11d64d
EZ
6502 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6503 "cast to pointer from integer of different size".
6504
825cd63c
EZ
6505 Improve doprnt and its use in verror. (Bug#8545)
6506 * doprnt.c (doprnt): Document the set of format control sequences
6507 supported by the function. Use SAFE_ALLOCA instead of always
6508 using `alloca'.
6509
6510 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6511 is one byte too soon. Don't use xrealloc; instead xfree and
6512 xmalloc anew.
6513
e061a11b
TZ
65142011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6515
6516 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6517 callbacks stage.
6518
6519 * gnutls.c: Renamed global_initialized to
6520 gnutls_global_initialized. Added internals for the
6521 :verify-hostname-error, :verify-error, and :verify-flags
6522 parameters of `gnutls-boot' and documented those parameters in the
6523 docstring. Start callback support.
9173deec
JB
6524 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6525 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6526 on error. Return error code.
e061a11b
TZ
6527 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6528 (emacs_gnutls_read): Likewise.
6529 (Fgnutls_boot): Return handshake error code.
6530 (emacs_gnutls_handle_error): New function.
6531 (wsaerror_to_errno): Likewise.
6532
6533 * w32.h (emacs_gnutls_pull): Add prototype.
6534 (emacs_gnutls_push): Likewise.
6535
6536 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6537 (emacs_gnutls_push): Likewise.
6538
65392011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6540
6541 * process.c (wait_reading_process_output): Check if GnuTLS
6542 buffered some data internally if no FDs are set for TLS
6543 connections.
6544
6545 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6546 (LIBS): Link to USER_LIBS.
6547 ($(BLD)/gnutls.$(0)): New target.
6548
fa6996bc
EZ
65492011-04-24 Eli Zaretskii <eliz@gnu.org>
6550
eb35682e
EZ
6551 * xdisp.c (handle_single_display_spec): Rename the
6552 display_replaced_before_p argument into display_replaced_p, to
6553 make it consistent with the commentary. Fix typos in the
6554 commentary.
6555
e2ad650c
EZ
6556 * textprop.c (syms_of_textprop): Remove dead code.
6557 (copy_text_properties): Delete obsolete commentary about an
6558 interface that was deleted long ago. Fix typos in the description
6559 of arguments.
6560
1b2de274
EZ
6561 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6562 to changes in oldXMenu/XMenu.h from 2011-04-16.
6563 <menu_help_message, prev_menu_help_message>: Constify.
6564 (IT_menu_make_room): menu->help_text is now `const char **';
6565 adjust.
6566
6567 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6568 to changes in oldXMenu/XMenu.h from 2011-04-16.
6569 (struct XMenu): Declare `help_text' `const char **'.
6570
6571 * xfaces.c <Qunspecified>: Make extern again.
6572
6573 * syntax.c: Include sys/types.h before including regex.h, as
6574 required by Posix.
6575
762b15be
EZ
6576 * doc.c (get_doc_string): Improve the format passed to `error'.
6577
6578 * doprnt.c (doprnt): Improve commentary.
6579
6580 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6581
6582 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6583 them with etags.
6584
f1052e5d
EZ
6585 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6586 changes in globals.h immediately force recompilation.
762b15be
EZ
6587 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6588 $(CURDIR)/s/ms-w32.h.
6589 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6590
fa6996bc
EZ
6591 * character.c (Fchar_direction): Function deleted.
6592 (syms_of_character): Don't defsubr it.
6593 <char-direction-table>: Deleted.
6594
e6c3da20
EZ
65952011-04-23 Eli Zaretskii <eliz@gnu.org>
6596
6597 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6598 * doprnt.c: Include limits.h.
6599 (SIZE_MAX): New macro.
04f2d78b
CB
6600 (doprnt): Return a size_t value. 2nd arg is now size_t.
6601 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6602 Improve overflow protection. Support `l' modifier for integer
6603 conversions. Support %l conversion. Don't assume an EMACS_INT
6604 argument for integer conversions and for %c.
6605
6606 * lisp.h (doprnt): Restore prototype.
6607
6608 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6609 $(SRC)/character.h.
6610
6611 * Makefile.in (base_obj): Add back doprnt.o.
6612
6613 * deps.mk (doprnt.o): Add back prerequisites.
6614 (callint.o): Depend on character.h.
6615
6616 * eval.c (internal_lisp_condition_case): Include the handler
6617 representation in the error message.
6618 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6619 when breaking from the loop.
6620
6621 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6622
6623 * callint.c (Fcall_interactively): When displaying error message
6624 about invalid control letter, pass the character's codepoint, not
6625 a pointer to its multibyte form. Improve display of the character
6626 in octal and display also its hex code.
6627
6628 * character.c (char_string): Use %x to display the (unsigned)
6629 codepoint of an invalid character, to avoid displaying a bogus
6630 negative value.
6631
6632 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6633 `error', not SYMBOL_NAME itself.
6634
6635 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6636 character arguments to `error'.
6637
6638 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6639 to `error' in error message about FINAL_CHAR argument. Make sure
6640 FINAL_CHAR is a character, and use %c when it is passed as
6641 argument to `error'.
6642
4ffd0d6b 66432011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6644
6645 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6646
6647 * w32.c: Include <time.h>.
6648 (sys_localtime): New function.
6649
4ffd0d6b 66502011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6651
6652 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6653
4ffd0d6b 6654 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6655
4ffd0d6b 66562011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6657
4ffd0d6b
GM
6658 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6659 zombies (Bug#8467).
aac0c6e3 6660
04c56954
EZ
66612011-04-19 Eli Zaretskii <eliz@gnu.org>
6662
6663 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6664 gl_state.e_property when gl_state.object is Qt.
6665
6666 * insdel.c (make_gap_larger): Remove limitation of buffer size
6667 to <= INT_MAX.
6668
16a43933
CY
66692011-04-18 Chong Yidong <cyd@stupidchicken.com>
6670
6671 * xdisp.c (lookup_glyphless_char_display)
6672 (produce_glyphless_glyph): Handle cons cell entry in
6673 glyphless-char-display.
6674 (Vglyphless_char_display): Document it.
6675
6676 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6677 glyphless-char-display.
6678
4581706e
CY
66792011-04-17 Chong Yidong <cyd@stupidchicken.com>
6680
6681 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6682
6683 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6684
6685 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6686 definition for no-X builds.
6687
4887c6e2 66882011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6689
fd35b6f9
PE
6690 Static checks with GCC 4.6.0 and non-default toolkits.
6691
5c1ccb01
PE
6692 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6693
006c5daa
PE
6694 * process.c (keyboard_bit_set): Define only if SIGIO.
6695 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6696 (send_process): Repair possible setjmp clobbering.
6697
efc736d3
PE
6698 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6699
4e2fe2e6
PE
6700 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6701
f97334a2
PE
6702 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6703
4e75f29d
PE
6704 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6705 Define only if needed.
6706
90efadd1
PE
6707 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6708 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6709 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6710
3c647824
PE
6711 * dispextern.h (struct redisplay_interface): Rename param
6712 to avoid shadowing.
e264f262 6713 * termhooks.h (struct terminal): Likewise.
761383f4 6714 * xterm.c (xembed_send_message): Likewise.
3c647824 6715
b58c5c4a
PE
6716 * insdel.c (make_gap_smaller): Define only if
6717 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6718
cad59032
PE
6719 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6720 it.
6721
c339dc2e
PE
6722 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6723 so that we aren't warned about unused symbols.
6724
91a3e27b
PE
6725 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6726
399c71d3 6727 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6728
8ffc96f5
PE
6729 * xfns.c (x_real_positions): Mark locals as initialized.
6730
eef9bc79
PE
6731 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6732
098db9dd
PE
6733 * xterm.c: Fix problems found by static analysis with other toolkits.
6734 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6735 (x_dispatch_event): Declare static if USE_GTK, and
6736 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6737 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6738 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6739 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6740 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6741
eb18f6cc
PE
6742 * xmenu.c (menu_help_callback): Pointer type fixes.
6743 Use const pointers when pointing at readonly data. Avoid pointer
6744 signedness clashes.
6745 (FALSE): Remove unused macro.
6746 (update_frame_menubar): Remove unused decl.
6747
1fe72bf8
PE
6748 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6749
60d9e1db
PE
6750 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6751 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6752 (single_menu_item): Rename local to avoid shadowing.
6753
39261c26
PE
6754 * keyboard.c (make_lispy_event): Remove unused local var.
6755
018c5e19
PE
6756 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6757 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6758
63d2b86e
PE
6759 * bitmaps: Change bitmaps from unsigned char back to the X11
6760 compatible char. Avoid the old compiler warnings about
6761 out-of-range initializers by using, for example, '\xab' rather
6762 than 0xab.
6763
aefd87e1
PE
6764 * xgselect.c (xgselect_initialize): Check vs interface
6765 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6766
bf501fb9
PE
6767 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6768
e9829fdf
PE
6769 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6770 to read-only memory.
6771
1086c095
PE
6772 * fns.c (vector): Remove; this old hack is no longer needed.
6773
2baccd04 6774 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6775 Remove unused var.
dde42981 6776 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6777
72391843 6778 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6779
436c16df 6780 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6781 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6782 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6783
92bb796d 6784 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6785 (x_term_init): Remove local to avoid shadowing.
92bb796d 6786
764430a3 6787 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6788
6789 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6790 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6791
d1dfb56c
EZ
67922011-04-16 Eli Zaretskii <eliz@gnu.org>
6793
c4354cb4
EZ
6794 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6795
d1dfb56c
EZ
6796 Fix regex.c, syntax.c and friends for buffers > 2GB.
6797 * syntax.h (struct gl_state_s): Declare character position members
6798 EMACS_INT.
6799
6800 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6801
04f2d78b
CB
6802 * textprop.c (verify_interval_modification, interval_of):
6803 Declare arguments EMACS_INT.
d1dfb56c
EZ
6804
6805 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6806 EMACS_INT.
6807
6808 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6809
6810 * indent.c (Fvertical_motion): Local variable it_start is now
6811 EMACS_INT.
6812
6813 * regex.c (re_match, re_match_2, re_match_2_internal)
6814 (bcmp_translate, regcomp, regexec, print_double_string)
6815 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6816 (re_compile_pattern, re_exec): Declare arguments and local
6817 variables `size_t' and `ssize_t' and return values `regoff_t', as
6818 appropriate.
6819 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6820 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6821 <compile_stack_type>: `size' and `avail' are now `size_t'.
6822
6823 * regex.h <regoff_t>: Use ssize_t, not int.
6824 (re_search, re_search_2, re_match, re_match_2): Arguments that
6825 specify buffer/string position and length are now ssize_t and
6826 size_t. Return type is regoff_t.
6827
613052cd
BK
68282011-04-16 Ben Key <bkey76@gmail.com>
6829
6830 * nsfont.m: Fixed bugs in ns_get_family and
6831 ns_descriptor_to_entity that were caused by using free to
6832 deallocate memory blocks that were allocated by xmalloc (via
6833 xstrdup). This caused Emacs to crash when compiled with
6834 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6835 --enable-checking=xmallocoverrun). xfree is now used to
6836 deallocate these memory blocks.
6837
4170f62f 68382011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6839
71b41406
PE
6840 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6841
9587a89d
PE
6842 emacs_write: Accept and return EMACS_INT for sizes.
6843 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6844 et seq.
6845 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6846 Accept and return EMACS_INT.
6847 (emacs_gnutls_write): Return the number of bytes written on
6848 partial writes.
6849 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6850 (emacs_read, emacs_write): Remove check for negative size, as the
6851 Emacs source code has been audited now.
9587a89d
PE
6852 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6853 (emacs_read, emacs_write): Use it.
273a5f82
PE
6854 * process.c (send_process): Adjust to the new signatures of
6855 emacs_write and emacs_gnutls_write. Do not attempt to store
6856 a byte offset into an 'int'; it might overflow.
9587a89d 6857 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6858
3e047f51
PE
6859 * sound.c: Don't assume sizes fit in 'int'.
6860 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6861 Return EMACS_INT, not int.
3e047f51 6862 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6863 Accept EMACS_INT, not int.
6864 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6865 record read return values.
6866
cc39a9db
BK
68672011-04-15 Ben Key <bkey76@gmail.com>
6868
c9d0ec6d
JB
6869 * keyboard.c (Qundefined): Don't declare static since it is used
6870 in nsfns.m.
6871 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6872 static since they are used in nsfont.m.
cc39a9db 6873
6c60eb9f
SM
68742011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6875
6876 * process.c (Qprocessp): Don't declare static.
6877 * lisp.h (Qprocessp): Declare again.
6878
7990b61a
JB
68792011-04-15 Juanma Barranquero <lekktu@gmail.com>
6880
6881 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6882
5d4cb038
PE
68832011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6884
8bd7b830 6885 Improve C-level modularity by making more things 'static'.
cd64ea1d 6886
e3b27b31
PE
6887 Don't publish debugger-only interfaces to other modules.
6888 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6889 (verify_bytepos, count_markers): Move decls to the only modules
6890 that need them.
6891 * region-cache.h (pp_cache): Likewise.
6892 * window.h (check_all_windows): Likewise.
6893 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6894
5d4cb038
PE
6895 * sysdep.c (croak): Now static, if
6896 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6897 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6898
6899 * alloc.c (refill_memory_reserve): Now static if
6900 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6901 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6902
e87b6180
PE
6903 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6904 Define only if USE_LUCID.
6905
ac64929e
PE
6906 * xrdb.c (x_customization_string, x_rm_string): Now static.
6907
6f37259d
PE
6908 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6909 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6910
1683e3ab
PE
6911 * xdisp.c (draw_row_with_mouse_face): Now static.
6912 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6913
de9c2632
PE
6914 * window.h (check_all_windows): Mark externally visible.
6915
2b96acb7
PE
6916 * window.c (window_deletion_count): Now static.
6917
6918 * undo.c: Make symbols static if they're not exported.
6919 (last_undo_buffer, last_boundary_position, pending_boundary):
6920 Now static.
6921
50436f33
PE
6922 * textprop.c (interval_insert_behind_hooks): Now static.
6923 (interval_insert_in_front_hooks): Likewise.
6924
64520e5c
PE
6925 * term.c: Make symbols static if they're not exported.
6926 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6927 (max_frame_lines, tty_set_terminal_modes):
6928 (tty_reset_terminal_modes, tty_turn_off_highlight):
6929 (get_tty_terminal): Now static.
6930 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6931 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6932 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6933 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6934 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6935
1fa53021
PE
6936 * sysdep.c: Make symbols static if they're not exported.
6937 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6938 Now static.
6939 (sigprocmask_set, full_mask): Remove; unused.
6940 (wait_debugging): Mark as visible.
6941 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6942 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6943
d4b43b22
PE
6944 * syntax.c (syntax_temp): Define only if !__GNUC__.
6945
b7c513d0
PE
6946 * sound.c (current_sound_device, current_sound): Now static.
6947
989b29ad
PE
6948 * search.c (searchbufs, searchbuf_head): Now static.
6949
13a55a78
PE
6950 * scroll.c (scroll_cost): Remove; unused.
6951 * dispextern.h (scroll_cost): Remove decl.
6952
de68a1fc
PE
6953 * region-cache.h (pp_cache): Mark as externally visible.
6954
40ccffa6
PE
6955 * process.c: Make symbols static if they're not exported.
6956 (process_tick, update_tick, create_process, chan_process):
6957 (Vprocess_alist, proc_buffered_char, datagram_access):
6958 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6959 (deactivate_process): Mark defn as static, as well as decl.
6960 * lisp.h (create_process): Remove decl.
6961 * process.h (chan_process, Vprocess_alist): Remove decls.
6962
ad64fc97
PE
6963 * print.c: Make symbols static if they're not exported.
6964 (print_depth, new_backquote_output, being_printed, print_buffer):
6965 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6966 (print_interval, print_number_index, initial_stderr_stream):
6967 Now static.
6968 * lisp.h (Fprinc): Remove decl.
6969 (debug_output_compilation_hack): Mark as externally visible.
6970
adddb265
PE
6971 * sysdep.c (croak): Move decl from here to syssignal.h.
6972 * syssignal.h (croak): Put it here, so the API can be checked when
6973 'croak' is called from dissociate_if_controlling_tty.
6974
1717ede2
PE
6975 * minibuf.c: Make symbols static if they're not exported.
6976 (minibuf_save_list, choose_minibuf_frame): Now static.
6977 * lisp.h (choose_minibuf_frame): Remove decl.
6978
fa5fb2bc
PE
6979 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6980
1e3890d1
PE
6981 * lread.c: Make symbols static if they're not exported.
6982 (read_objects, initial_obarray, oblookup_last_bucket_number):
6983 Now static.
6984 (make_symbol): Remove; unused.
6985 * lisp.h (initial_obarray, make_symbol): Remove decls.
6986
8a1414fa
PE
6987 * keyboard.c: Make symbols static if they're not exported.
6988 (single_kboard, recent_keys_index, total_keys, recent_keys):
6989 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6990 (this_single_command_key_start, echoing, last_auto_save):
6991 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6992 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6993 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6994 (Vlispy_mouse_stem, double_click_count):
6995 Now static.
6996 (force_auto_save_soon): Define only if SIGDANGER.
6997 (ignore_mouse_drag_p): Now static if
6998 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6999 (print_help): Remove; unused.
7000 (stop_character, last_timer_event): Mark as externally visible.
7001 * keyboard.h (ignore_mouse_drag_p): Declare only if
7002 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7003 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7004 * lisp.h (echoing): Remove decl.
7005 (force_auto_save_soon): Declare only if SIGDANGER.
7006 * xdisp.c (redisplay_window): Simplify code, to make it more
7007 obvious that ignore_mouse_drag_p is not accessed if !defined
7008 USE_GTK && !defined HAVE_NS.
7009
93ea6e8f
PE
7010 * intervals.c: Make symbols static if they're not exported.
7011 (merge_properties_sticky, merge_interval_right, delete_interval):
7012 Now static.
7013 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7014
77382fcc
PE
7015 * insdel.c: Make symbols static if they're not exported.
7016 However, leave prepare_to_modify_buffer alone. It's never
7017 called from outside this function, but that appears to be a bug.
7018 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7019 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7020 (adjust_after_replace_noundo): Remove; unused.
7021 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7022 (signal_before_change): Remove decls.
77382fcc 7023
9306c32e
PE
7024 * indent.c (val_compute_motion, val_vmotion): Now static.
7025
cd44d2eb
PE
7026 * image.c: Make symbols static if they're not exported.
7027 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7028 if USE_GTK.
7029 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7030 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7031
ad9a7a06
PE
7032 * fringe.c (standard_bitmaps): Now static.
7033 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7034
81626931
PE
7035 * frame.c: Make symbols static if they're not exported.
7036 (x_report_frame_params, make_terminal_frame): Now static.
7037 (get_frame_param): Now static, unless HAVE_NS.
7038 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7039 (x_get_resource_string): Remove; not used.
7040 * frame.h (make_terminal_frame, x_report_frame_params):
7041 (x_get_resource_string); Remove decls.
7042 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7043 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7044
239f9db9
PE
7045 * font.c, fontset.c: Make symbols static if they're not exported.
7046 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7047 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7048 * font.c (font_close_object): Now static.
7049 * font.h (font_close_object): Remove.
7050 * fontset.c (FONTSET_OBJLIST): Remove.
7051 (free_realized_fontset) #if-0 the body, which does nothing.
7052 (face_suitable_for_char_p): #if-0, as it's never called.
7053 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7054 * xfaces.c (face_at_string_position):
7055 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7056 since 0 is always ASCII.
7057
dfcf3579
PE
7058 * fns.c (weak_hash_tables): Now static.
7059
5045092b
PE
7060 * fileio.c: Make symbols static if they're not exported.
7061 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7062 (Vwrite_region_annotation_buffers): Now static.
7063
57a96f5c
PE
7064 * eval.c: Make symbols static if they're not exported.
7065 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7066 * lisp.h (backtrace_list): Remove decl.
7067
35f08c38
PE
7068 * emacs.c: Make symbols static if they're not exported.
7069 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7070 (fatal_error_code, fatal_error_signal_hook, standard_args):
7071 Now static.
7072 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7073 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7074 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7075 * lisp.h (fatal_error_signal_hook): Remove decl.
7076 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7077
f44bd759
PE
7078 * editfns.c: Move a (normally-unused) function to its only use.
7079 * editfns.c, lisp.h (get_operating_system_release): Remove.
7080 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7081 worth the hassle of breaking this out.
7082
b532497d
PE
7083 * xterm.c: Make symbols static if they're not exported.
7084 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7085 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7086 (x_destroy_window, x_delete_display):
7087 Now static.
7088 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7089 (x_mouse_leave): Remove; unused.
7090 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7091 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7092 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7093 Remove decls.
7094 (x_mouse_leave): Declare only if WINDOWSNT.
7095 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7096 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7097 USE_X_TOOLKIT.
7098
1675728f
PE
7099 * ftxfont.c: Make symbols static if they're not exported.
7100 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7101 HAVE_FREETYPE.
7102 * font.h (ftxfont_driver): Likewise.
7103
e4cebfca
PE
7104 * xfns.c: Make symbols static if they're not exported.
7105 (x_last_font_name, x_display_info_for_name):
7106 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7107 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7108 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7109 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7110 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7111 (last_show_tip_args): Now static.
7112 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7113 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7114 (x_screen_planes): Remove; unused.
7115 * dispextern.h (x_screen_planes): Remove decl.
7116
5bf46f05
PE
7117 * dispnew.c: Make symbols static if they're not exported.
7118 * dispextern.h (redraw_garbaged_frames, scrolling):
7119 (increment_row_positions): Remove.
7120 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7121 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7122 Now static.
7123 (redraw_garbaged_frames): Remove; unused.
7124
435f4c28
PE
7125 * xfaces.c: Make symbols static if they're not exported.
7126 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7127 Remove decls.
7128 * xterm.h (defined_color): Remove decls.
7129 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7130 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7131 (menu_face_changed_default, defined_color, free_realized_face):
7132 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7133 (ascii_face_of_lisp_face): Remove; unused.
7134
8524aef3
PE
7135 * xdisp.c: Make symbols static if they're not exported.
7136 * dispextern.h (scratch_glyph_row, window_box_edges):
7137 (glyph_to_pixel_coords, set_cursor_from_row):
7138 (get_next_display_element, set_iterator_to_next):
7139 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7140 (show_mouse_face): Remove decls
7141 * frame.h (message_buf_print): Likewise.
7142 * lisp.h (pop_message, set_message, check_point_in_composition):
7143 Likewise.
7144 * xterm.h (set_vertical_scroll_bar): Likewise.
7145 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7146 (message_buf_print, scratch_glyph_row, displayed_buffer):
7147 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7148 (get_next_display_element, show_mouse_face, window_box_edges):
7149 (frame_to_window_pixel_xy, check_point_in_composition):
7150 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7151 (glyph_to_pixel_coords): Remove; unused.
7152
16390cd2
PE
7153 * dired.c (file_name_completion): Now static.
7154
7155 * dbusbind.c (xd_in_read_queued_messages): Now static.
7156
a25f4dfa
PE
7157 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7158 * data.c (circular_list_error): Remove.
7159
14a9c8df
PE
7160 * commands.h (last_point_position, last_point_position_buffer):
7161 (last_point_position_window): Remove decls.
7162 * keyboard.c: Make these variables static.
7163
04f2d78b
CB
7164 * coding.h (coding, code_convert_region, encode_coding_gap):
7165 Remove decls.
74ab6df5
PE
7166 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7167 (iso_code_class, detect_coding, code_convert_region): Now static.
7168 (encode_coding_gap): Remove; unused.
7169
38dfbee1
PE
7170 * chartab.c (chartab_chars, chartab_bits): Now static.
7171
a2cb4e63
PE
7172 * charset.h (charset_iso_8859_1): Remove decl.
7173 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7174 Now static.
7175
127198fd
PE
7176 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7177 * ccl.c (Vccl_program_table): Now static.
7178 (check_ccl_update): Remove; unused.
7179
d85b608f
PE
7180 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7181 * category.h: ... from here.
7182 * category.c (check_category_table, set_category_set): Now static.
7183
31cd66f3
PE
7184 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7185 * lisp.h: Remove these decls.
7186
c358e587
PE
7187 * buffer.c (buffer_count): Remove unused var.
7188
e78aecca
PE
7189 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7190 so that it's not optimized away.
7191 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7192 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7193 exported only to the debugger.
7194
e192d7d3 7195 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7196 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7197
92470028
PE
7198 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7199 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7200 was inaccessible from Lisp.
7201 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7202 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7203
244ed907
PE
7204 alloc.c: Import and export fewer symbols, and remove unused items.
7205 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7206 is defined.
7207 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7208 it's not optimized away by whole-program optimization.
7209 (message_enable_multibyte, free_misc): Remove.
7210 (catchlist, handlerlist, mark_backtrace):
7211 Declare only if BYTE_MARK_STACK.
7212 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7213 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7214 (message_enable_multibyte): Remove decl.
7215 (free_misc, interval_free_list, float_block, float_block_index):
7216 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7217 (cons_free_list, last_marked_index):
7218 Now static.
7219 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7220 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7221 (mark_backtrace): Define only if BYTE_MARK_STACK.
7222 * xdisp.c (message_enable_multibyte): Now static.
7223
61c2b50e 7224 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7225 This makes it easier for human readers (and static analyzers)
7226 to see whether these variables are used from other modules.
7227 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7228 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7229 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7230 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7231 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7232 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7233 * xmenu.c, xselect.c:
7234 Declare Q* vars static if they are not used in other modules.
7235 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7236 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7237 Remove decls of unexported vars.
7238 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7239
95c82688
PE
7240 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7241
16a97296
PE
7242 Make Emacs functions such as Fatom 'static' by default.
7243 This makes it easier for human readers (and static analyzers)
7244 to see whether these functions can be called from other modules.
7245 DEFUN now defines a static function. To make the function external
7246 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7247 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7248 (Finit_image_library):
16a97296
PE
7249 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7250 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7251 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7252 Remove decls, since these functions are now static.
7253 (Funintern, Fget_internal_run_time): New decls, since these functions
7254 were already external.
95c82688 7255
16a97296
PE
7256 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7257 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7258 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7259 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7260 * keyboard.c, keymap.c, lread.c:
7261 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7262 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7263 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7264 Mark functions with DEFUE instead of DEFUN,
7265 if they are used in other modules.
7266 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7267 decls for now-static functions.
7268 * buffer.h (Fdelete_overlay): Remove decl.
7269 * callproc.c (Fgetenv_internal): Mark as internal.
7270 * composite.c (Fremove_list_of_text_properties): Remove decl.
7271 (Fcomposition_get_gstring): New forward static decl.
7272 * composite.h (Fcomposite_get_gstring): Remove decl.
7273 * dired.c (Ffile_attributes): New forward static decl.
7274 * doc.c (Fdocumntation_property): New forward static decl.
7275 * eval.c (Ffetch_bytecode): New forward static decl.
7276 (Funintern): Remove extern decl; now in .h file where it belongs.
7277 * fileio.c (Fmake_symbolic_link): New forward static decl.
7278 * image.c (Finit_image_library): New forward static decl.
7279 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7280 * intervals.h (Fprevious_property_change):
7281 (Fremove_list_of_text_properties): Remove decls.
7282 * keyboard.c (Fthis_command_keys): Remove decl.
7283 (Fcommand_execute): New forward static decl.
7284 * keymap.c (Flookup_key): New forward static decl.
7285 (Fcopy_keymap): Now static.
7286 * keymap.h (Flookup_key): Remove decl.
7287 * process.c (Fget_process): New forward static decl.
7288 (Fprocess_datagram_address): Mark as internal.
7289 * syntax.c (Fsyntax_table_p): New forward static decl.
7290 (skip_chars): Remove duplicate decl.
7291 * textprop.c (Fprevious_property_change): New forward static decl.
7292 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7293 Now internal.
7294 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7295 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7296
785bbd42
PE
7297 * editfns.c (Fformat): Remove unreachable code.
7298
8b913b57
AS
72992011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7300
7301 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7302 change. (Bug#8496)
7303
a6744a35
EZ
73042011-04-13 Eli Zaretskii <eliz@gnu.org>
7305
7306 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7307 when at ZV. (Bug#8487)
7308
e7974947
AS
73092011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7310
baad03f0
AS
7311 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7312 (Bug#8437)
7313 * keyboard.c (parse_tool_bar_item): Likewise.
7314 * sound.c (sound_cleanup, alsa_close): Likewise.
7315 * termcap.c (tgetent): Likewise.
7316 * xfns.c (x_default_font_parameter): Likewise.
7317 * xsettings.c (read_and_apply_settings): Likewise.
7318
e7974947
AS
7319 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7320 (overrun_check_free): Protoize.
7321
28272684
PE
73222011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7323
7324 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7325 since callers should never pass a negative size.
7326 Change the signature to match that of plain 'read' and 'write'; see
7327 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7328 * lisp.h: Update prototypes of emacs_write and emacs_read.
7329
11997c76
EZ
73302011-04-11 Eli Zaretskii <eliz@gnu.org>
7331
7332 * xdisp.c (redisplay_window): Don't try to determine the character
7333 position of the scroll margin if the window start point w->startp
e896f03c 7334 is outside the buffer's accessible region. (Bug#8468)
11997c76 7335
8a2cbd72
EZ
73362011-04-10 Eli Zaretskii <eliz@gnu.org>
7337
7338 Fix write-region and its subroutines for buffers > 2GB.
7339 * fileio.c (a_write, e_write): Modify declaration of arguments and
7340 local variables to support buffers larger than 2GB.
7341 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7342
7343 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7344 argument, local variables, and return value.
7345
7346 * lisp.h: Update prototypes of emacs_write and emacs_read.
7347
7348 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7349
4073e537 73502011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7351
1ebfdcb6
PE
7352 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7353
b2ded58d
PE
7354 Fix more problems found by GCC 4.6.0's static checks.
7355
7d66342c
PE
7356 * xdisp.c (vmessage): Use a better test for character truncation.
7357
bbf47d44
PE
7358 * charset.c (load_charset_map): <, not <=, for optimization,
7359 and to avoid potential problems with integer overflow.
9248994d 7360 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7361 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7362 * editfns.c (Fformat): Likewise.
1e69125e 7363 * syntax.c (skip_chars): Likewise.
3befa583 7364
e3019616
PE
7365 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7366 This also lets GCC 4.6.0 generate slightly better loop code.
7367
becfa255
PE
7368 * callint.c (Fcall_interactively): <, not <=, for optimization.
7369 (Fcall_interactively): Count the number of arguments produced,
7370 not the number of arguments given. This is simpler and lets GCC
7371 4.6.0 generate slightly better code.
7372
dae0cd48
PE
7373 * ftfont.c: Distingish more carefully between FcChar8 and char.
7374 The previous code passed unsigned char * to a functions like
7375 strlen and xstrcasecmp that expect char *, which does not
7376 conform to the C standard.
7377 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7378 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7379 char * when the C standard requires it.
7380
76032d70
PE
7381 * keyboard.c (read_char): Remove unused var.
7382
eb3f1cc8
PE
7383 * eval.c: Port to Windows vsnprintf (Bug#8435).
7384 Include <limits.h>.
7385 (SIZE_MAX): Define if the headers do not.
7386 (verror): Do not give up if vsnprintf returns a negative count.
7387 Instead, grow the buffer. This ports to Windows vsnprintf, which
7388 does not conform to C99. Problem reported by Eli Zaretskii.
7389 Also, simplify the allocation scheme, by avoiding the need for
7390 calling realloc, and removing the ALLOCATED variable.
7391
70476b54
PE
7392 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7393
12020a9e
PE
7394 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7395 But keep the doprint source code for now, as we might revamp it
7396 and use it again (Bug#8435).
ea6c7ae6
PE
7397 * lisp.h (doprnt): Remove.
7398 * Makefile.in (base_obj): Remove doprnt.o.
7399 * deps.mk (doprnt.o): Remove.
7400
5fdb398c
PE
7401 error: Print 32- and 64-bit integers portably (Bug#8435).
7402 Without this change, on typical 64-bit hosts error ("...%d...", N)
7403 was used to print both 32- and 64-bit integers N, which relied on
7404 undefined behavior.
7405 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7406 New macro.
7407 * lisp.h (error, verror): Mark as printf-like functions.
7408 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7409 Report overflow in size calculations when allocating printf buffer.
7410 Do not truncate output string at its first null byte.
7411 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7412 Truncate the output at a character boundary, since vsnprintf does not
7413 do that.
7414 * charset.c (check_iso_charset_parameter): Convert internal
7415 character to string before calling 'error', since %c now has the
7416 printf meaning.
7417 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7418 overflow when computing char to be passed to 'error'. Do not
7419 pass Lisp_Object to 'error'; pass the integer instead.
7420 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7421 formatted with plain %d.
7422
b189fa66
PE
7423 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7424
bff87ef0
PE
7425 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7426
7e2cac20
PE
7427 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7428
ce4d90b5
PE
7429 * xterm.c (x_catch_errors): Remove duplicate declaration.
7430
266c9547
PE
7431 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7432
79c49ad2
PE
7433 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7434
368f4090
JM
74352011-04-10 Jim Meyering <meyering@redhat.com>
7436
7437 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7438 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7439 return ssize_t not "int", and use size_t as the buffer length.
7440 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7441 * gnutls.h: Update declarations.
7442 * process.c (read_process_output): Use ssize_t, to match.
7443 (send_process): Likewise.
7444
a32d4040
CY
74452011-04-09 Chong Yidong <cyd@stupidchicken.com>
7446
7447 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7448
8546720e 74492011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7450
04f2d78b
CB
7451 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7452 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7453
8546720e
GM
7454 * xterm.c (handle_one_xevent):
7455 * xmenu.c (create_and_show_popup_menu):
7456 * xselect.c (x_decline_selection_request)
7457 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7458
0a2f5c1a 74592011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7460
7461 Fix some uses of `int' instead of EMACS_INT.
7462 * search.c (string_match_1, fast_string_match)
7463 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7464 (scan_buffer, find_next_newline_no_quit)
7465 (find_before_next_newline, search_command, Freplace_match)
7466 (Fmatch_data): Make some `int' variables be EMACS_INT.
7467
7468 * xdisp.c (display_count_lines): 3rd argument and return value now
7469 EMACS_INT. All callers changed.
7470 (pint2hrstr): Last argument is now EMACS_INT.
7471
7472 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7473 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7474 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7475 (decode_coding_utf_16, decode_coding_emacs_mule)
7476 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7477 (decode_coding_ccl, decode_coding_charset)
7478 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7479 (decode_coding_iso_2022, decode_coding_emacs_mule)
7480 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7481 <char_offset, last_offset>: Declare EMACS_INT.
7482 (encode_coding_utf_8, encode_coding_utf_16)
7483 (encode_coding_emacs_mule, encode_invocation_designation)
7484 (encode_designation_at_bol, encode_coding_iso_2022)
7485 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7486 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7487 Declare EMACS_INT.
7488 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7489 (encode_invocation_designation): Last argument P_NCHARS is now
7490 EMACS_INT.
7491 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7492 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7493
7494 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7495 All users changed.
7496
7497 * ccl.c (Fccl_execute_on_string): Declare some variables
7498 EMACS_INT.
7499
8546720e 75002011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7501
7502 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7503
4e19a977
CS
75042011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7505
7506 * process.c (Fformat_network_address): Doc fix.
7507
87302331
R
75082011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7509
ee7683eb 7510 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7511
cbb59342
CY
75122011-04-08 Chong Yidong <cyd@stupidchicken.com>
7513
7514 * keyboard.c (read_char): Call Lisp function help-form-show,
7515 instead of using internal_with_output_to_temp_buffer.
7516 (Qhelp_form_show): New var.
e0d38eeb 7517 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7518
7519 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7520
7521 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7522
e67a13ab
CY
75232011-04-06 Chong Yidong <cyd@stupidchicken.com>
7524
04f2d78b
CB
7525 * process.c (Flist_processes): Remove to Lisp.
7526 (list_processes_1): Delete.
e67a13ab 7527
973f782d
EZ
75282011-04-06 Eli Zaretskii <eliz@gnu.org>
7529
7c106b1e
EZ
7530 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7531
973f782d
EZ
7532 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7533
41cf7d1a 75342011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7535
ca23cc88
PE
7536 Fix more problems found by GCC 4.6.0's static checks.
7537
f390e2d5
PE
7538 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7539
42eea0d0
PE
7540 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7541
b69769da 7542 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7543
f9541e84
PE
7544 * xdisp.c (vmessage): Mark as a printf-like function.
7545
13841b55
PE
7546 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7547
c136c10f
PE
7548 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7549
5e2d4a30
PE
7550 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7551 printf-like functions.
7552 (tiff_load): Add casts to remove these marks before passing them
7553 to system-supplied API.
7554
583f48b9
PE
7555 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7556
b25d760e
PE
7557 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7558 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7559 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7560 directly, rather than having caller test rule sign. This avoids
7561 some unnecessary tests.
7562 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7563 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7564 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7565
bc7b6697 7566 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7567 (xfont_open): Avoid unnecessary tests.
bc7b6697 7568
27ccc379
PE
7569 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7570
dcd5c89a
PE
7571 * composite.h, composite.c (composition_gstring_put_cache):
7572 Use EMACS_INT, not int, for length.
7573
b13a45c6
PE
7574 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7575 breaking out part of COMPOSITION_DECODE_RULE.
7576 (COMPOSITION_DECODE_RULE): Use it.
7577 * composite.c (get_composition_id): Remove unused local vars,
7578 by using the new macro.
7579
1e792e4d
PE
7580 * textprop.c (set_text_properties_1): Change while to do-while,
7581 since the condition is always true at first.
7582
dc6c6455 7583 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7584 (interval_deletion_adjustment): Return unsigned value.
7585 All uses changed.
dc6c6455 7586
aba7731a
PE
7587 * process.c (list_processes_1, create_pty, read_process_output):
7588 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7589 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7590 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7591 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7592 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7593
fdfc4bf3
PE
7594 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7595
fca8fe46 7596 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7597 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7598
06a0259a 7599 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7600 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7601 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7602
e7b9e80f
PE
7603 * print.c (print_error_message): Avoid int overflow.
7604
56201685
PE
7605 * font.c (font_list_entities): Redo for clarity,
7606 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7607
78834453 7608 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7609 (font_score): Avoid potential overflow in diff calculation.
78834453 7610
0bc0b309 7611 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7612 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7613
e610eaca
PE
7614 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7615
b895abce
PE
7616 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7617 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7618 can always succeed if overflow has undefined behavior.
7619
1f1d9321 7620 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7621 (wordify): Omit three unnecessary tests.
1f1d9321 7622
c59478bc
PE
7623 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7624 All callers changed. This avoids the need for an unused var.
7625
79b73827
PE
7626 * casefiddle.c (casify_region): Remove var that is set but not used.
7627
a4db5dfe
PE
7628 * dired.c (file_name_completion): Remove var that is set but not used.
7629
43aae36e
PE
7630 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7631
2a47c44d 7632 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7633 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7634
a37c69bf
PE
7635 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7636 Check for integer overflow on size calculations.
7637
328ab8e7
PE
7638 * buffer.c (Fprevious_overlay_change): Remove var that is set
7639 but not used.
7640
e5a2a5cb
PE
7641 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7642 Remove vars that are set but not used.
8d84a6eb 7643 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7644 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7645
a60e5f68
PE
7646 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7647
f661cb61 7648 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7649 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7650
f0397f5a
PE
7651 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7652 that are set but not used.
7653
8664db06 7654 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7655 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7656
6abdaa4a
PE
7657 * xselect.c (x_get_local_selection, x_handle_property_notify):
7658 Remove vars that are set but not used.
7659
0ce7538d 7660 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7661 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7662
9ae848fc
PE
7663 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7664 Remove var that is set but not used.
0b918413
PE
7665 (scroll_bar_windows_size): Now size_t, not int.
7666 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7667 Check for overflow.
9ae848fc 7668
a5a62657
PE
7669 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7670 (map_tty_color) [!defined MSDOS]: Likewise.
7671
5c5cdd39
PE
7672 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7673
66ebf983
PE
7674 * coding.c: Remove vars that are set but not used.
7675 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7676 All callers changed.
7677 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7678 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7679 (decode_coding_charset): Remove vars that are set but not used.
7680
1be4d761
PE
7681 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7682 that is set but not used.
7683
47553fa8
PE
7684 * print.c (print_object): Remove var that is set but not used.
7685
1f7196bf 7686 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7687 The gnulib version avoids calling malloc in the usual case,
7688 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7689 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7690 * filelock.c (current_lock_owner): Likewise.
7691 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7692 * sysdep.c: Include allocator.h, careadlinkat.h.
7693 (emacs_no_realloc_allocator): New static constant.
7694 (emacs_readlink): New function.
fdb61804
PE
7695 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7696 ../lib/careadlinkat.h.
d1fdcab7 7697
f84c17c7
SM
76982011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7699
7700 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7701 first non-nil return value).
7702
ef3862ad
JD
77032011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7704
7705 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7706 if not defined (Bug#8403).
7707
376a7006
JB
77082011-04-02 Juanma Barranquero <lekktu@gmail.com>
7709
7710 * xdisp.c (display_count_lines): Remove parameter `start',
7711 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7712 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7713 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7714 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7715 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7716 and thereabouts. All callers changed.
7717 (get_per_char_metric): Remove parameter `f', unused since
7718 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7719
6ca3801d
JM
77202011-04-02 Jim Meyering <meyering@redhat.com>
7721
7722 do not dereference NULL upon failed strdup
7723 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7724 (ns_get_family): Likewise.
7725
d8e2b5ba
JB
77262011-04-02 Juanma Barranquero <lekktu@gmail.com>
7727
7728 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7729
8c74fcbd
JD
77302011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7731
7732 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7733 later (Bug#8403).
7734
7200d79c
SM
77352011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7736
03408648 7737 Add lexical binding.
7200d79c 7738
03408648
SM
7739 * window.c (Ftemp_output_buffer_show): New fun.
7740 (Fsave_window_excursion):
7741 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7742
7743 * lread.c (lisp_file_lexically_bound_p): New function.
7744 (Fload): Bind Qlexical_binding.
7745 (readevalloop): Remove `evalfun' arg.
7746 Bind Qinternal_interpreter_environment.
7747 (Feval_buffer): Bind Qlexical_binding.
7748 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7749 Mark as dynamic.
7750 (syms_of_lread): Declare `lexical-binding'.
7751
7752 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7753
7754 * keyboard.c (eval_dyn): New fun.
7755 (menu_item_eval_property): Use it.
ca105506
SM
7756
7757 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7758
03408648
SM
7759 * fns.c (concat, mapcar1): Accept byte-code-functions.
7760
7761 * eval.c (Fsetq): Handle lexical vars.
7762 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7763 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7764 (FletX, Flet): Obey lexical binding.
7765 (Fcommandp): Handle closures.
7766 (Feval): New `lexical' arg.
7767 (eval_sub): New function extracted from Feval. Use it almost
7768 everywhere where Feval was used. Look up vars in lexical env.
7769 Handle closures.
7770 (Ffunctionp): Move from subr.el.
7771 (Ffuncall): Handle closures.
7772 (apply_lambda): Remove `eval_flags'.
7773 (funcall_lambda): Handle closures and new byte-code-functions.
7774 (Fspecial_variable_p): New function.
7775 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7776 but without exporting it to Lisp.
23aba0ea 7777
23aba0ea 7778 * doc.c (Fdocumentation, store_function_docstring):
03408648 7779 * data.c (Finteractive_form): Handle closures.
23aba0ea 7780
03408648
SM
7781 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7782 interactive spec.
ba83908c 7783
04f2d78b
CB
7784 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7785 New byte-codes.
03408648
SM
7786 (exec_byte_code): New function extracted from Fbyte_code to handle new
7787 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7788
03408648 7789 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7790
03408648 7791 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7792
e2abce01
JB
77932011-03-31 Juanma Barranquero <lekktu@gmail.com>
7794
7795 * xdisp.c (redisplay_internal): Fix prototype.
7796
63696a73 77972011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7798
63696a73 7799 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7800 (try_scrolling): Use it when setting scroll_limit.
7801 Limit scrolling to 100 screen lines.
63696a73
EZ
7802 (redisplay_window): Even when falling back on "recentering",
7803 position point in the window according to scroll-conservatively,
7804 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7805
7806 (try_scrolling): When point is above the window, allow searching
7807 as far as scroll_max, or one screenful, to compute vertical
7808 distance from PT to the scroll margin position. This prevents
7809 try_scrolling from unnecessarily failing when
7810 scroll-conservatively is set to a value slightly larger than the
7811 window height. Clean up the case of PT below the margin at bottom
7812 of window: scroll_max can no longer be INT_MAX. When aggressive
7813 scrolling is in use, don't let point enter the opposite scroll
7814 margin as result of the scroll.
7815 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7816 threshold of 100 lines for never-recentering scrolling.
7817
e4cc2dfc
JB
78182011-03-31 Juanma Barranquero <lekktu@gmail.com>
7819
7820 * dispextern.h (move_it_by_lines):
7821 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7822 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7823 (message_log_check_duplicate): Remove parameters `prev_bol' and
7824 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7825 (redisplay_internal): Remove parameter `preserve_echo_area',
7826 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7827
7828 * indent.c (Fvertical_motion):
7829 * window.c (window_scroll_pixel_based, Frecenter):
7830 Don't pass `need_y_p' to `move_it_by_lines'.
7831
1c470562
SM
78322011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7833
44f230aa
SM
7834 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7835 steal a few bits to be more compact.
7836 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7837 Remove unneeded casts.
7838
1c470562
SM
7839 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7840
888adce9
ZK
78412011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7842
7843 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7844 binding" message (bug#7967).
7845
f838ed7b
PE
78462011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7847
77861b95
PE
7848 Fix more problems found by GCC 4.6.0's static checks.
7849
de6dbc14
PE
7850 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7851 Remove unused local var.
7852
f838ed7b
PE
7853 * editfns.c (Fmessage_box): Remove unused local var.
7854
792c7b2b
PE
7855 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7856 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7857 Omit unused local vars.
c499e557 7858 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7859 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7860 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7861 Omit unused local var.
7862
ba0165e1
PE
7863 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7864 Don't assume string length fits in int.
32ad8845 7865 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7866 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7867
3c59b4c9
PE
7868 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7869 instead of alloca (Bug#8344).
7870
a3eed478 7871 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7872 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7873
eb4d412d
PE
7874 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7875
1658b401
PE
7876 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7877 concerns.
7878
7879 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7880
7881 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7882
9a2c6e05
PE
7883 * keyboard.c (syms_of_keyboard): Use the same style as later
7884 in this function when indexing through an array. This also
7885 works around GCC bug 48267.
7886
03d0a109
PE
7887 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7888
44f730c8
PE
7889 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7890
fe75f926
PE
7891 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7892 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7893
ffa8c828
PE
7894 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7895 This avoids undefined behavior on integer overflow, and is a bit
7896 more convenient anyway since it is compared to a size_t variable.
7897
c5101a77
PE
7898 Variadic C functions now count arguments with size_t, not int.
7899 This avoids an unnecessary limitation on 64-bit machines, which
7900 caused (substring ...) to crash on large vectors (Bug#8344).
7901 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7902 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7903 All variadic functions and their callers changed accordingly.
c5101a77
PE
7904 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7905 * data.c (arith_driver, float_arith_driver): Likewise.
7906 * editfns.c (general_insert_function): Likewise.
7907 * eval.c (struct backtrace.nargs, interactive_p)
7908 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7909 (funcall_lambda, mark_backtrace): Likewise.
7910 * fns.c (concat): Likewise.
7911 * frame.c (x_set_frame_parameters): Likewise.
7912 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7913 0 if not found, not -1. All callers changed.
7914
dd3f25f7
PE
7915 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7916 (stack_copy_size): Now size_t, not int.
7917 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7918
461c2ab9
JB
79192011-03-28 Juanma Barranquero <lekktu@gmail.com>
7920
7921 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7922 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7923 All callers changed.
7924
7925 * lisp.h (multibyte_char_to_unibyte):
7926 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7927 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7928 * character.h (CHAR_TO_BYTE8):
7929 * cmds.c (internal_self_insert):
7930 * editfns.c (general_insert_function):
7931 * keymap.c (push_key_description):
7932 * search.c (Freplace_match):
7933 * xdisp.c (message_dolog, set_message_1): All callers changed.
7934
f6d62986
SM
79352011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7936
7937 * keyboard.c (safe_run_hook_funcall): New function.
7938 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7939 don't set the hook to nil, but remove the offending function instead.
7940 (Qcommand_hook_internal): Remove, unused.
7941 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7942 Vcommand_hook_internal.
7943
7944 * eval.c (enum run_hooks_condition): Remove.
7945 (funcall_nil, funcall_not): New functions.
7946 (run_hook_with_args): Call each function through a `funcall' argument.
7947 Remove `cond' argument, now redundant.
7948 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7949 (Frun_hook_with_args_until_failure): Adjust accordingly.
7950 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7951
1db5b1ad
JB
79522011-03-28 Juanma Barranquero <lekktu@gmail.com>
7953
7954 * dispextern.h (string_buffer_position): Remove declaration.
7955
7956 * print.c (strout): Remove parameter `multibyte', unused since
7957 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7958
7959 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7960 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7961 All callers changed.
7962
7963 * w32.c (_wsa_errlist): Use braces for struct initializers.
7964
7965 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7966 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7967 All callers changed.
7968 (string_buffer_position): Likewise. Also, make static (it's never
7969 used outside xdisp.c).
7970 (cursor_row_p): Remove parameter `w', unused since
7971 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7972 (decode_mode_spec): Remove parameter `precision', introduced during
7973 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7974 All callers changed.
7975
5ffb62aa
JD
79762011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7977
7978 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7979
461c2ab9 79802011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7981
7982 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7983 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7984 (ns_update_auto_hide_menu_bar): New functions.
7985 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7986 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7987 ns_constrain_all_frames.
7988 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7989 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7990
5c380ffb
JD
79912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7992
7993 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7994
9af30bdf
GM
79952011-03-27 Glenn Morris <rgm@gnu.org>
7996
7997 * syssignal.h: Replace RETSIGTYPE with void.
7998 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7999 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8000 Replace SIGTYPE with void everywhere.
8001 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8002 * s/template.h (SIGTYPE): Remove commented out definition.
8003
e2abce01
JB
80042011-03-26 Eli Zaretskii <eliz@gnu.org>
8005
8006 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8007 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8008
f868cd8a
JB
80092011-03-26 Juanma Barranquero <lekktu@gmail.com>
8010
59eb0929
JB
8011 * w32.c (read_unc_volume): Use parameter `henum', instead of
8012 global variable `wget_enum_handle'.
8013
8014 * keymap.c (describe_vector): Remove parameters `indices' and
8015 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8016 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8017
f868cd8a
JB
8018 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8019
8020 * keyboard.c (timer_check): Remove parameter `do_it_now',
8021 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8022 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8023 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8024
8025 * keyboard.c (read_char):
8026 * w32menu.c (w32_menu_display_help):
8027 * xmenu.c (show_help_event, menu_help_callback):
8028 Adjust calls to `show_help_echo'.
8029
8030 * gtkutil.c (xg_maybe_add_timer):
8031 * keyboard.c (readable_events):
8032 * process.c (wait_reading_process_output):
8033 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8034
8035 * insdel.c (adjust_markers_gap_motion):
8036 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8037 (gap_left, gap_right): Don't call it.
8038
2ecf6fdb
CY
80392011-03-25 Chong Yidong <cyd@stupidchicken.com>
8040
8041 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8042 incurred during fontification.
8043
6b1f9ba4
JB
80442011-03-25 Juanma Barranquero <lekktu@gmail.com>
8045
8046 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8047 (DEFVAR_PER_BUFFER): Don't pass it.
8048
8049 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8050 (scrolling_window): Don't pass it.
8051
0f4a96b5
JB
80522011-03-25 Juanma Barranquero <lekktu@gmail.com>
8053
8054 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8055
8056 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8057 and `suffix'.
8058 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8059 of variables specific to SELinux and computation of `encoded_absname'.
8060
8061 * image.c (XPutPixel): Remove unused variable `height'.
8062
8063 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8064
8065 * unexw32.c (get_section_info): Remove unused variable `section'.
8066
8067 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8068 (system_process_attributes): Remove unused variable `sess'.
8069 (sys_read): Remove unused variable `err'.
8070
8071 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8072 (w32_wnd_proc): Remove unused variable `isdead'.
8073 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8074 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8075 (x_create_tip_frame): Remove unused variable `tem'.
8076
8077 * w32inevt.c (w32_console_read_socket):
8078 Remove unused variable `no_events'.
8079
8080 * w32term.c (x_draw_composite_glyph_string_foreground):
8081 Remove unused variable `width'.
8082
1149507c
JB
80832011-03-24 Juanma Barranquero <lekktu@gmail.com>
8084
8085 * w32term.c (x_set_glyph_string_clipping):
8086 Don't pass uninitialized region to CombineRgn.
8087
9c88f339
JB
80882011-03-23 Juanma Barranquero <lekktu@gmail.com>
8089
8090 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8091 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8092 (Fx_close_connection): Remove unused variable `i'.
8093
8094 * w32font.c (w32font_draw): Return number of glyphs.
8095 (w32font_open_internal): Remove unused variable `i'.
8096 (w32font_driver): Add missing initializer.
8097
8098 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8099 (fill_in_menu): Remove unused variable `items_added'.
8100
8101 * w32term.c (last_mouse_press_frame): Remove static global variable.
8102 (w32_clip_to_row): Remove unused variable `f'.
8103 (x_delete_terminal): Remove unused variable `i'.
8104
8105 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8106 (NOTHING): Remove unused static global variable.
8107 (uniscribe_check_otf): Remove unused variable `table'.
8108 (uniscribe_font_driver): Add missing initializers.
8109
dee091a3
JD
81102011-03-23 Julien Danjou <julien@danjou.info>
8111
8112 * term.c (Fsuspend_tty, Fresume_tty):
8113 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8114 * window.c (temp_output_buffer_show):
8115 * insdel.c (signal_before_change):
8116 * frame.c (Fhandle_switch_frame):
8117 * fileio.c (Fdo_auto_save):
8118 * emacs.c (Fkill_emacs):
8119 * editfns.c (save_excursion_restore):
8120 * cmds.c (internal_self_insert):
8121 * callint.c (Fcall_interactively):
8122 * buffer.c (Fkill_all_local_variables):
8123 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8124 Use Frun_hooks.
0f4a96b5 8125 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8126 unconditionally since it does the check itself.
dee091a3 8127
2c520ab5 81282011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8129
c9c49752
PE
8130 Fix more problems found by GCC 4.5.2's static checks.
8131
8abc3f12
PE
8132 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8133 the first time through the loop, since we know p0 < p1 then.
8134 This also avoids a gcc -Wstrict-overflow warning.
8135
a2d26660
PE
8136 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8137 leading to a memory leak, possible in functions like
8138 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8139 of objects (Bug#8318).
a2d26660 8140
916c72e9
PE
8141 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8142 that could (at least in theory) be that large.
8143
19ab8a18
PE
8144 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8145 This is less likely to overflow, and avoids undefined behavior if
8146 overflow does occur. All callers changed. Use strtoul to scan
8147 for the unsigned long integer.
b7cbbd6f
PE
8148 (pint2hrstr): Simplify and tune code slightly.
8149 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8150
f0641eff
PE
8151 * scroll.c (do_scrolling): Work around GCC bug 48228.
8152 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8153
7f650bb9
PE
8154 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8155 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8156 (validate_x_resource_name): Simplify count usage.
8157 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8158
37dd57d1
PE
8159 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8160 fail (Bug#8306).
81e56e61 8161
699979fc 8162 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8163
401bf9b4
PE
8164 * process.c (Fmake_network_process): Use socklen_t, not int,
8165 where POSIX says socklen_t is required in portable programs.
8166 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8167 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8168 (Fmake_network_process, server_accept_connection):
8169 (wait_reading_process_output, read_process_output):
8170 Likewise.
8171
b93aacde
PE
8172 * process.c: Rename or move locals to avoid shadowing.
8173 (list_processes_1, Fmake_network_process):
8174 (read_process_output_error_handler, exec_sentinel_error_handler):
8175 Rename or move locals.
4dc343ee 8176 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8177 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8178 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8179 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8180 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8181
af8a867c 8182 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8183 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8184 Include tparam.h instead, since it declares them.
af8a867c
PE
8185 * cm.h (PC): Remove extern decl; tparam.h now does this.
8186 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8187 * terminfo.c: Include tparam.h, to check interfaces.
8188 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8189 (tparam): Adjust signature to match interface in tparam.h;
8190 this removes some undefined behavior. Check that outstring and len
8191 are zero, which they always are with Emacs.
8192 * tparam.h (PC, BC, UP): New extern decls.
8193
0248044d 8194 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8195 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8196
8ff096c1 8197 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8198 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8199 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8200 (ftfont_list): Remove unused local.
49eaafba
PE
8201 (get_adstyle_property, ftfont_pattern_entity):
8202 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8203 Rename locals to avoid shadowing.
8ff096c1 8204
e2be39f6
PE
8205 * xfont.c (xfont_list_family): Mark var as initialized.
8206
c9735e30
PE
8207 * xml.c (make_dom): Now static.
8208
8f5201ae
PE
8209 * composite.c (composition_compute_stop_pos): Rename local to
8210 avoid shadowing.
b246f932
PE
8211 (composition_reseat_it): Remove unused locals.
8212 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8213 (composition_update_it): Mark var as initialized.
11b61122
PE
8214 (find_automatic_composition): Mark vars as initialized,
8215 with a FIXME (Bug#8290).
8f5201ae 8216
760fbc2c
PE
8217 character.h: Rename locals to avoid shadowing.
8218 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8219 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8220 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8221 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8222 to avoid shadowing.
8223
ff08eb85
PE
8224 * textprop.c (property_change_between_p): Remove; unused.
8225
fc7bf025
PE
8226 * intervals.c (interval_start_pos): Now static.
8227
235d7abc
PE
8228 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8229
44f230aa
SM
8230 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8231 Rename locals to avoid shadowing.
3e7d6594 8232
50060332
PE
8233 * sound.c (wav_play, au_play, Fplay_sound_internal):
8234 Fix pointer signedness.
d01f234b 8235 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8236 (wav_play): Initialize a variable to 0, to prevent undefined
8237 behavior (Bug#8278).
50060332 8238
c4fc4e30
PE
8239 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8240
918436ed
PE
8241 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8242
c939f91b
PE
8243 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8244 clobbering (Bug#8298).
b9c7f648
PE
8245 * sysdep.c (sys_subshell): Likewise.
8246 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8247
6bd8c144
PE
8248 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8249 This should get cleaned up, so that child_setup has the
8250 same signature on all platforms.
8251
7710357c 8252 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8253 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8254
c59da222
CY
82552011-03-22 Chong Yidong <cyd@stupidchicken.com>
8256
8257 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8258 not to be necessary, and produces flickering.
8259
66b87493
GM
82602011-03-20 Glenn Morris <rgm@gnu.org>
8261
8262 * config.in: Remove file.
8263
45b6f6d5
JB
82642011-03-20 Juanma Barranquero <lekktu@gmail.com>
8265
8266 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8267 are now in src/globals.h.
8268 (syms_of_minibuf): Remove spurious & from previous change.
8269
3ec03f7e
LL
82702011-03-20 Leo <sdl.web@gmail.com>
8271
8272 * minibuf.c (completing-read-function): New variable.
8273 (completing-read-default): Rename from completing-read.
8274 (completing-read): Call completing-read-function.
8275
b14e3e21
CY
82762011-03-19 Juanma Barranquero <lekktu@gmail.com>
8277
8278 * xfaces.c (Fx_load_color_file):
8279 Read color file from absolute filename (bug#8250).
8280
f2b726e6
JB
82812011-03-19 Juanma Barranquero <lekktu@gmail.com>
8282
8283 * makefile.w32-in: Update dependencies.
8284
09f6ff02
EZ
82852011-03-17 Eli Zaretskii <eliz@gnu.org>
8286
8287 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8288
29a6015a
PE
82892011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8290
a3a6c54e
PE
8291 Fix more problems found by GCC 4.5.2's static checks.
8292
b766f867
PE
8293 * process.c (make_serial_process_unwind, send_process_trap):
8294 (sigchld_handler): Now static.
8295
be02381c
PE
8296 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8297 That way, the code declares only the vars that it needs.
8298 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8299 * s/cygwin.h (PTY_ITERATION): Likewise.
8300 * s/darwin.h (PTY_ITERATION): Likewise.
8301 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8302
57048744
PE
8303 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8304 * process.c (allocate_pty): Don't declare stb unless it's needed.
8305
7914961c 8306 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8307 (CONSTANTLIM): Remove; unused.
8308 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8309 Define only if needed.
7914961c 8310
b3967b18
PE
8311 * unexelf.c (unexec): Name an expression,
8312 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8313 Use a different way to cause a compilation error if anyone uses
8314 n rather than nn, a way that does not involve shadowing.
73366a00 8315 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8316
29a6015a
PE
8317 * deps.mk (unexalpha.o): Remove; unused.
8318
43cfc33e 8319 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8320 * unexec.h: New file.
ce701a33
PE
8321 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8322 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8323 Depend on unexec.h.
8324 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8325 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8326 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8327 Change as necessary to match prototype in unexec.h.
ce701a33 8328
01f44d5a
PE
8329 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8330 shadowing.
4f63c6bb 8331 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8332
a6670b0b
PE
8333 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8334 Rename locals to avoid shadowing.
8335
cef2010d 8336 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8337 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8338
d4d7173a
PE
8339 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8340
f08b802a
PE
8341 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8342 warning when compiling print.c.
8343
3ddb0639
PE
8344 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8345 instead of using an uninitialized var.
5ad03b97 8346 (font_sort_entities): Mark var as initialized.
3ddb0639 8347
170a2692
PE
8348 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8349
e663c700
PE
8350 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8351 pointers to constants.
89bc529a 8352 (font_parse_fcname): Remove unused vars.
7b81e2d0 8353 (font_delete_unmatched): Now static.
ea838e10 8354 (font_get_spec): Remove; unused.
13a547c6
PE
8355 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8356 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8357 Rename or move locals to avoid shadowing.
e663c700 8358
2a80c887 8359 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8360 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8361
1384fa33 8362 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8363 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8364
8b2c52e9
PE
8365 * alloc.c (mark_backtrace): Move decl from here ...
8366 * lisp.h: ... to here, so that it can be checked.
8367
475545b5 8368 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8369 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8370 (lisp_indirect_variable): Name an expression,
8371 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8372 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8373
b1349114 8374 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8375 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8376 Use const pointer when appropriate.
b1349114 8377
a2928364
PE
8378 * lisp.h (get_system_name, get_operating_system_release):
8379 Move decls here, to check interfaces.
8380 * process.c (get_operating_system_release): Move decl to lisp.h.
8381 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8382 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8383 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8384 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8385 (Fformat_time_string, Fencode_time, Finsert_char):
8386 (Ftranslate_region_internal, Fformat):
8387 Rename or remove local vars to avoid shadowing.
9710023e 8388 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8389
a415e694
PE
8390 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8391 avoid shadowing.
8392
8ef4622d
PE
8393 * lisp.h (eassert): Check that the argument compiles, even if
8394 ENABLE_CHECKING is not defined.
8395
946f9a5b
PE
8396 * data.c (Findirect_variable): Name an expression, to avoid
8397 gcc -Wbad-function-cast warning.
112396d6 8398 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8399 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8400 (Fmake_variable_buffer_local, Fmake_local_variable):
8401 Mark variables as initialized.
52746918 8402 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8403
e5aab7e7 8404 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8405 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8406 Rename locals to avoid shadowing.
dff45157
PE
8407 (mark_stack): Move local variables into the #ifdef region where
8408 they're used.
7bc26fdb
PE
8409 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8410 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8411 needed otherwise.
8412 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8413 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8414 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8415
e5aab7e7
PE
8416 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8417 avoids undefined behavior in theory.
8418
4da60324
PE
8419 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8420
88043301
PE
8421 Use functions, not macros, for up- and down-casing (Bug#8254).
8422 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8423 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8424 to use the following functions instead of these macros.
8425 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8426 EMACS_INT, since callers assume the returned value fits in int.
8427 (upcase1): Likewise, for UPCASE_TABLE.
8428 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8429 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8430 the race-condition problem in the old DOWNCASE.
88043301 8431
19ed5445
PE
8432 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8433 Rename locals to avoid shadowing.
8434 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8435 (regex_compile, re_search_2, re_match_2_internal):
8436 Remove unused local vars.
952db0d7
PE
8437 (FREE_VAR): Rewrite so as not to use empty "else",
8438 which gcc can warn about.
da053e48 8439 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8440 (RETALLOC_IF): Define only if needed.
8441 (WORDCHAR_P): Likewise. This one is never needed, but is used
8442 only in a comment talking about a compiler bug, so put inside
8443 the #if 0 of that comment.
8444 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8445 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8446 Remove; unused.
19ed5445 8447
1f3561e4 8448 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8449 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8450 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8451
ded6f8f7
PE
8452 * search.c (simple_search): Remove unused var.
8453
dbd37a95
PE
8454 * dired.c (compile_pattern): Move decl from here ...
8455 * lisp.h: ... to here, so that it can be checked.
8456 (struct re_registers): New forward decl.
8457
7e47afad
PE
8458 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8459
85f24f61
PE
8460 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8461 All uses changed.
8462 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8463 Rename locals to avoid shadowing.
5671df8f 8464 (Fvertical_motion): Mark locals as initialized.
85f24f61 8465
181aa2be 8466 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8467 (casify_region): Mark local as initialized.
181aa2be 8468
930d429c
PE
8469 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8470
7082eac6
PE
8471 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8472 New macros, so that the caller can use some names other than
8473 gcpro1, gcpro2, etc.
8474 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8475 of the new macros.
8476 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8477 argument, for consistency with GCPRO2_VAR, etc: it is now the
8478 prefix of the variable, not the variable itself. All uses
8479 changed.
38b2c076
PE
8480 * dired.c (directory_files_internal, file_name_completion):
8481 Rename locals to avoid shadowing.
8482
15206ed9
PE
8483 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8484 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8485 dired.c's scmp function, had undefined behavior.
8486 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8487 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8488 * buffer.h: ... to here, because these macros use current_buffer,
8489 and the new implementation with inline functions needs to have
8490 current_buffer in scope now, rather than later when the macros
8491 are used.
8492 (downcase, upcase1): New static inline functions.
8493 (DOWNCASE, UPCASE1): Reimplement using these functions.
8494 This avoids undefined behavior in expressions like
8495 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8496 from race conditions in accessing the global variables
8497 case_temp1 and case_temp2.
8498 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8499 * lisp.h (case_temp1, case_temp2): Remove their decls.
8500 * character.h (ASCII_CHAR_P): Move from here ...
8501 * lisp.h: ... to here, so that the inline functions mentioned
8502 above can use them.
8503
4a6bea26
PE
8504 * dired.c (directory_files_internal_unwind): Now static.
8505
f14b7e14
PE
8506 * fileio.c (file_name_as_directory, directory_file_name):
8507 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8508 Now static.
2893f146
PE
8509 (file_name_as_directory): Use const pointers when appropriate.
8510 (Fexpand_file_name): Likewise. In particular, newdir might
8511 point at constant storage, so make it a const pointer.
fd4ead52 8512 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8513 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8514 signedness issues.
f839df0c
PE
8515 (Fset_file_times, Finsert_file_contents, auto_save_error):
8516 Rename locals to avoid shadowing.
f14b7e14 8517
5716756e 8518 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8519 (Ftry_completion, Fall_completions): Rename or remove locals
8520 to avoid shadowing.
5716756e 8521
b4c3046a
PE
8522 * marker.c (bytepos_to_charpos): Remove; unused.
8523
b45db522
PE
8524 * lisp.h (verify_bytepos, count_markers): New decls,
8525 so that gcc does not warn that these functions aren't declared.
8526
85876d07
PE
8527 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8528 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8529 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8530 (copy_text): Remove unused local var.
85876d07 8531
03d78a21 8532 * filelock.c (within_one_second): Now static.
b3dd38ab 8533 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8534
5df8f01b
PE
8535 * buffer.c (fix_overlays_before): Mark locals as initialized.
8536 (fix_start_end_in_overlays): Likewise. This function should be
8537 simplified by using pointers-to-pointers, but that's a different
8538 matter.
b1d876f1 8539 (switch_to_buffer_1): Now static.
8f54f30a
PE
8540 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8541 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8542
a70072c9 8543 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8544 Fix pointer signedness issue.
edced198
PE
8545 (sys_subshell): Mark local as volatile if checking for lint,
8546 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8547 (MAXPATHLEN): Define only if needed.
a70072c9 8548
a0977c44
PE
8549 * process.c (serial_open, serial_configure): Move decls from here ...
8550 * systty.h: ... to here, so that they can be checked.
8551
a884fdcc
PE
8552 * fns.c (get_random, seed_random): Move extern decls from here ...
8553 * lisp.h: ... to here, so that they can be checked.
8554
604efe86 8555 * sysdep.c (reset_io): Now static.
b8950c94 8556 (wait_for_termination_signal): Remove; unused.
604efe86 8557
38fc62d9
PE
8558 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8559 (copy_keymap_item, append_key, push_text_char_description):
8560 Now static.
1004a21a 8561 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8562 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8563 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8564 (describe_map_tree):
8565 Rename locals to avoid shadowing.
38fc62d9 8566
2f2650da
PE
8567 * keyboard.c: Declare functions static if they are not used elsewhere.
8568 (echo_char, echo_dash, cmd_error, top_level_2):
8569 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8570 (read_char, kbd_buffer_get_event, make_lispy_position):
8571 (make_lispy_event, make_lispy_movement, apply_modifiers):
8572 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8573 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8574 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8575 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8576 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8577
a053e86c 8578 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8579 (mark_kboards): Move decl here ...
8580 * alloc.c (mark_kboards): ... from here.
a053e86c 8581
4752793e
PE
8582 * lisp.h (force_auto_save_soon): New decl.
8583
74f10ca7 8584 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8585 (DEFINE_DUMMY_FUNCTION): New macro.
8586 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8587 Use it.
c03cd23f
PE
8588 (main): Add casts to avoid warnings
8589 if GCC considers string literals to be constants.
74f10ca7 8590
022e70d4
PE
8591 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8592
59d6fe83
PE
8593 * dbusbind.c: Pointer signedness fixes.
8594 (xd_signature, xd_append_arg, xd_initialize):
8595 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8596 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8597 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8598 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8599
78320123
PE
8600 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8601 if GCC considers string literals to be constants.
49cebcca 8602 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8603
35ac2a97
SM
86042011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8605
fb103ca9
SM
8606 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8607 (print_preprocess, print_object): New macro to fix last change.
8608
35ac2a97
SM
8609 * print.c (print_preprocess): Don't forget font objects.
8610
62973b41
JB
86112011-03-16 Juanma Barranquero <lekktu@gmail.com>
8612
8613 * emacs.c (USAGE3): Doc fixes.
8614
0e48bb22
AS
86152011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8616
8617 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8618 structure.
8619
7684e57b
JB
86202011-03-14 Juanma Barranquero <lekktu@gmail.com>
8621
8622 * lisp.h (VWindow_system, Qfile_name_history):
8623 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8624 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8625 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8626
8627 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8628 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8629
8630 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8631 * w32console.c (detect_input_pending, read_input_pending)
8632 (encode_terminal_code):
8633 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8634 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8635 (w32_system_caret_y, Qfile_name_history):
8636 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8637 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8638 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8639 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8640 * w32proc.c (Qlocal, report_file_error):
8641 * w32term.c (Vwindow_system, updating_frame):
8642 * w32uniscribe.c (initialized, uniscribe_font_driver):
8643 Remove unneeded extern declarations.
8644
2aa46d6c
CY
86452011-03-14 Chong Yidong <cyd@stupidchicken.com>
8646
c96bbc66 8647 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8648
cffc6f3b
CY
86492011-03-13 Chong Yidong <cyd@stupidchicken.com>
8650
8651 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8652 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8653 These macros can no longer be used for assignment.
8654
44f230aa
SM
8655 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8656 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8657 (record_buffer_markers, fetch_buffer_markers): New functions for
8658 recording and fetching special buffer markers.
8659 (set_buffer_internal_1, set_buffer_temp): Use them.
8660
8661 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8662
8663 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8664
8665 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8666 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8667
8668 * xdisp.c (hscroll_window_tree):
8669 (reconsider_clip_changes): Use PT instead of BUF_PT.
8670
d251f04b
EZ
86712011-03-13 Eli Zaretskii <eliz@gnu.org>
8672
8673 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8674 $(EMACS_ROOT)/lib/intprops.h.
8675
f0c77cd1
PE
86762011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8677
3eca4629
PE
8678 Fix more problems found by GCC 4.5.2's static checks.
8679
7c86ee98
PE
8680 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8681 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8682 (xg_free_frame_widgets): Make it clear that a local variable is
8683 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8684 (gdk_window_get_screen): Make it clear that this macro is needed
8685 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8686 (int_gtk_range_get_value): New function, which avoids a diagnostic
8687 from gcc -Wbad-function-cast.
8688 (xg_set_toolkit_scroll_bar_thumb): Use it.
8689 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8690 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8691 (get_utf8_string, xg_get_file_with_chooser):
8692 Rename locals to avoid shadowing.
8693 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8694
41729b81
PE
8695 * xgselect.c (xg_select): Remove unused var.
8696
f0c77cd1
PE
8697 * image.c (four_corners_best): Mark locals as initialized.
8698 (gif_load): Initialize transparent_p to zero (Bug#8238).
8699 Mark another local as initialized.
ec6cf4c6 8700 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8701
ce0ad53d 8702 * image.c (clear_image_cache): Now static.
d5d5a617 8703 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8704 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8705 (x_edge_detection): Remove unnecessary cast that
8706 gcc -Wbad-function-cast diagnoses.
2037898d 8707 (gif_load): Fix pointer signedness.
6ae141d6
PE
8708 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8709 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8710
33383987 87112011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8712
d32df629
PE
8713 Improve quality of tests for time stamp overflow.
8714 For example, without this patch (encode-time 0 0 0 1 1
8715 1152921504606846976) returns the obviously-bogus value (-948597
8716 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8717 reports time overflow. See
8718 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8719 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8720 * editfns.c: Include limits.h and intprops.h.
8721 (TIME_T_MIN, TIME_T_MAX): New macros.
8722 (time_overflow): Move earlier, to before first use.
8723 (hi_time, lo_time): New functions, for an accurate test for
8724 out-of-range times.
8725 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8726 (Fget_internal_run_time): Don't assume time_t fits in int.
8727 (make_time): Use list2 instead of Fcons twice.
8728 (Fdecode_time): More accurate test for out-of-range times.
8729 (check_tm_member): New function.
8730 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8731 (lisp_time_argument): Don't rely on undefined left-shift and
8732 right-shift behavior when checking for time stamp overflow.
8be6f318 8733
fe31d94c
PE
8734 * editfns.c (time_overflow): New function, refactoring common code.
8735 (Fformat_time_string, Fdecode_time, Fencode_time):
8736 (Fcurrent_time_string): Use it.
8737
8be6f318
PE
8738 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8739 * dired.c (make_time): Move to ...
8740 * editfns.c (make_time): ... here.
8741 * systime.h: Note the move.
8742
09d9db2c 87432011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8744
126bc0dc
YM
8745 * fringe.c (update_window_fringes): Remove unused variables.
8746
c47cbdfd
YM
8747 * unexmacosx.c (copy_data_segment): Also copy __got section.
8748 (Bug#8223)
8749
7ac80be9
EZ
87502011-03-12 Eli Zaretskii <eliz@gnu.org>
8751
c96bbc66 8752 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8753 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8754 Constify `char *' arguments and their references according to
8755 prototypes in tparam.h.
8756
ecb0f94d 8757 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8758
7ac80be9
EZ
8759 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8760 Adapt all references accordingly.
8761
8762 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8763
ef1fd07e
TT
87642011-03-11 Tom Tromey <tromey@redhat.com>
8765
8766 * buffer.c (syms_of_buffer): Remove obsolete comment.
8767
7ef4b50c
EZ
87682011-03-11 Eli Zaretskii <eliz@gnu.org>
8769
8770 * termhooks.h (encode_terminal_code): Declare prototype.
8771
8772 * msdos.c (encode_terminal_code): Don't declare prototype.
8773
8774 * term.c (encode_terminal_code): Now external again, used by
8775 w32console.c and msdos.c.
8776
44f230aa
SM
8777 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8778 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8779
4b1ec863 87802011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8781
1714f52b 8782 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8783
4b1ec863
PE
8784 * fringe.c (update_window_fringes): Mark locals as initialized
8785 (Bug#8227).
8786 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8787
524c7aa6
PE
8788 * alloc.c (mark_fringe_data): Move decl from here ...
8789 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8790 to check its interface.
8791 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8792
a5c0af81 8793 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8794 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8795 (fontset_font): Mark local as initialized.
a9a06e0b 8796 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8797
b4716021
PE
8798 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8799
811e9bac 8800 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8801 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8802 (x_own_selection, Fx_disown_selection_internal): Rename locals
8803 to avoid shadowing.
8804 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8805
7e3ab302
PE
8806 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8807 so that the caller can use some name other than gcpro1.
8808 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8809 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8810 (Fx_backspace_delete_keys_p):
8811 Use them to avoid shadowing, and rename vars to avoid shadowing.
8812 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8813 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8814 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8815 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8816 Remove unused locals.
7e3ab302
PE
8817 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8818 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8819 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8820 macros.
f78faa98 8821
e2b13473
PE
8822 * xterm.h (x_mouse_leave): New decl.
8823
77f23912
PE
8824 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8825 Remove unused functions.
cdf4ba58
PE
8826 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8827 (x_calc_absolute_position): Now static.
7411c686 8828 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8829 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8830 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8831 unless they are used.
38d0b34a
PE
8832 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8833 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8834 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8835 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8836 (x_error_catcher, x_connection_closed, x_error_handler):
8837 (x_error_quitter, xembed_send_message, x_iconify_frame):
8838 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8839 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8840 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8841
44f230aa
SM
8842 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8843 Rename or move locals to avoid shadowing.
6b463e58 8844 (tty_defined_color, merge_face_heights): Now static.
5967d051 8845 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8846 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8847 does not deduce is never used uninitialized.
73719eba
PE
8848 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8849 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8850
426994c3 8851 * terminal.c (store_terminal_param): Now static.
5489860b 8852
032f1620 8853 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8854 (set_frame_menubar): Remove unused local.
d4323972 8855 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8856 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8857 since they might point to immutable storage.
281585b0
PE
8858 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8859 since it's unused otherwise.
032f1620 8860
367c19e5 8861 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8862 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8863 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8864 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8865 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8866 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8867 does not deduce are never used uninitialized.
70739cbe 8868
07b48fa9
PE
8869 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8870
8868a238 8871 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8872 * window.c (window_loop, size_window):
8873 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8874
7e5cf297 8875 * window.c (display_buffer): Now static.
d6550a9f
PE
8876 (size_window): Mark variables that gcc -Wuninitialized
8877 does not deduce are never used uninitialized.
a586633d
PE
8878 * window.h (check_all_windows): New decl, to forestall
8879 gcc -Wmissing-prototypes diagnostic.
5b555da1 8880 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8881
f6095868
PE
8882 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8883 shadowing.
8884 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8885 Include <limits.h>.
8886 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8887 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8888 (load_charset_map): Mark variables that gcc -Wuninitialized
8889 does not deduce are never used uninitialized.
53df7c11 8890 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8891
f38b440c
PE
8892 * coding.c (coding_set_source, coding_set_destination):
8893 Use "else { /* comment */ }" rather than "else /* comment */;"
8894 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8895 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8896 a block, when the outer 'i' will do.
8897 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8898 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8899 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8900 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8901 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8902 Rename locals to avoid shadowing.
8903 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8904 * coding.c (emacs_mule_char, encode_invocation_designation):
8905 Now static, since they're not used elsewhere.
413bb2db 8906 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8907 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8908 (decode_coding_emacs_mule): Mark variables that gcc
8909 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8910 (detect_coding_iso_2022): Initialize a local variable that might
8911 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8912 this initialization is needed. (Bug#8211)
5f58e762
PE
8913 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8914 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8915 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8916 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8917 Remove unused macros.
f38b440c 8918
232b38b9 8919 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8920 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8921 * character.c (string_count_byte8): Likewise.
232b38b9 8922
fb90da1b
PE
8923 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8924 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8925
fb93dbc2
PE
8926 * chartab.c (copy_sub_char_table): Now static, since it's not used
8927 elsewhere.
5c156ace
PE
8928 (sub_char_table_ref_and_range, char_table_ref_and_range):
8929 Rename locals to avoid shadowing.
bbcd0949 8930 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8931
7d3b3862 8932 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8933 (BIDI_BOB): Remove unused macro.
7d3b3862 8934
6be7d3da
PE
8935 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8936 deduce are never used uninitialized.
c2ed9c8b 8937 * term.c (encode_terminal_code): Likewise.
6be7d3da 8938
75f8807f 8939 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8940
50938595
PE
8941 * tparam.h: New file.
8942 * term.c, tparam.h: Include it.
8943 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8944 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8945 Move these decls to tparam.h, and make them agree with what
8946 is actually in tparam.c. The previous trick of using incompatible
8947 decls in different modules does not conform to the C standard.
8948 All callers of tparam changed to use tparam's actual API.
8949 * tparam.c (tparam1, tparam, tgoto):
8950 Use const pointers where appropriate.
8951
fbceeba2
PE
8952 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8953 * cm.h (struct cm): Likewise.
8954 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8955 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8956 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8957 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8958 (turn_on_face, init_tty): Likewise.
8959 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8960
7f3f1250
PE
8961 * term.c (term_mouse_position): Rename local to avoid shadowing.
8962
e6ca6543
PE
8963 * alloc.c (mark_ttys): Move decl from here ...
8964 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8965
c40f8d15
AS
89662011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8967
8968 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8969
cfe0661d
JB
89702011-03-09 Juanma Barranquero <lekktu@gmail.com>
8971
8972 * search.c (compile_pattern_1): Remove argument regp, unused since
8973 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8974 (compile_pattern): Don't pass it.
8975
0afb4571
J
89762011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8977
8978 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8979 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8980 for ! HAVE_GTK3.
8981 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8982
8983 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8984
8985 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8986 gdk_window_get_screen, gdk_window_get_geometry,
8987 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8988 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8989 (xg_get_pixbuf_from_pixmap): New function.
8990 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8991 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8992 Call xg_get_pixbuf_from_pixmap instead of
8993 gdk_pixbuf_get_from_drawable.
8994 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8995 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8996 (xg_check_special_colors): Use GtkStyleContext and its functions
8997 for HAVE_GTK3.
8998 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8999 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9000 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9001 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9002 Call gtk_widget_get_preferred_size.
0afb4571
J
9003 (xg_frame_resized): gdk_window_get_geometry only takes 5
9004 parameters.
44f230aa
SM
9005 (xg_win_to_widget, xg_event_is_for_menubar):
9006 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9007 (xg_set_widget_bg): New function.
9008 (delete_cb): New function.
895009e1 9009 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9010 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9011 (xg_set_background_color): Call xg_set_widget_bg.
9012 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9013 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9014 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9015 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9016 if ! HAVE_GTK3.
9017 (update_frame_tool_bar): Call gtk_widget_hide.
9018 (xg_initialize): Use GDK_KEY_g.
9019
9020 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9021 if ! HAVE_GTK3
9022 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9023
9024 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9025 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9026 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9027
1c2cc4ef
JB
90282011-03-08 Juanma Barranquero <lekktu@gmail.com>
9029
9030 * w32xfns.c (select_palette): Check success of RealizePalette against
9031 GDI_ERROR, not zero.
9032
33383987 9033See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9034
9035;; Local Variables:
9036;; coding: utf-8
aac0c6e3
MR
9037;; End:
9038
33383987 9039 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
9040
9041 This file is part of GNU Emacs.
9042
9043 GNU Emacs is free software: you can redistribute it and/or modify
9044 it under the terms of the GNU General Public License as published by
9045 the Free Software Foundation, either version 3 of the License, or
9046 (at your option) any later version.
9047
9048 GNU Emacs is distributed in the hope that it will be useful,
9049 but WITHOUT ANY WARRANTY; without even the implied warranty of
9050 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9051 GNU General Public License for more details.
9052
9053 You should have received a copy of the GNU General Public License
9054 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.