Remove unused member of struct x_output and struct w32_output.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8b96a52c
DA
12012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Remove unused member of struct x_output and struct w32_output.
4 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
5 * w32term.h (struct w32_output): Likewise.
6
b4444c8a
JD
72012-08-30 Jan Djärv <jan.h.d@swipnet.se>
8
9 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
10 does not become zero (Bug#12234).
11
b98521db
PE
122012-08-30 Paul Eggert <eggert@cs.ucla.edu>
13
14 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
15 for GCC 4.7.1 x86-64.
16
31d02438
GM
172012-08-30 Glenn Morris <rgm@gnu.org>
18
19 * lread.c (init_lread): For out-of-tree builds, only add the
20 source directory's site-lisp dir to the load-path if it exists,
21 consistent with in-tree builds. (Bug#12302)
22
7f8941d8
JD
232012-08-28 Jan Djärv <jan.h.d@swipnet.se>
24
25 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
26 button_values to NULL. Call setStykeMask so dialogs get a close button.
27 (windowShouldClose:): Set window_closed.
28 (dealloc): New member, free button_values.
29 (process_dialog:): Make member function. Remove window argument,
30 replace window with self. Count buttons and allocate and store values
31 in button_values.
32 (addButton:value:row:): value is int with the name tag. Call setTag
33 with tag. Remove return self, declare return value as void.
34 (addString:row:): Remove return self, declare return value as void.
35 (addSplit): Remove return self, declare return value as void.
36 (clicked:): Remove return self, declare return value as void.
37 Set dialog_return to button_values[seltag]. Code formatting change.
38 (initFromContents:isQuestion:): Adjust call to process_dialog.
39 Code formatting change.
40 (timeout_handler:): Set timer_fired to YES.
41 (runDialogAt:): Set timer_fired to NO.
42 Handle click on close button as quit.
43
44 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
45 Add window_closed and button_values. Add void as return value for
46 add(Button|String|Split). addButton takes int instead of Lisp_Object.
47 Add process_dialog as new member.
48
eada0861 492012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 50
eada0861
GM
51 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
52 is not one of the heaps we manage. (Bug#12242)
53
542012-08-28 Glenn Morris <rgm@gnu.org>
55
56 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
57
457294dd
MR
582012-08-28 Martin Rudalics <rudalics@gmx.at>
59
60 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
61 auto-buffer-name window parameter. Install revision of reverted
62 fix.
457294dd 63
4f2daf31
DA
642012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
65
66 Do not allow to set major mode for a dead buffer.
67 * buffer.c (Fset_buffer_major_mode): Signal an error
68 if the buffer is dead.
69 (Fother_buffer, other_buffer_safely): Remove redundant
70 nested declaration.
71
66322887
DA
722012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
73
74 Always use set_buffer_if_live to restore original buffer at unwind.
75 * buffer.h (record_unwind_current_buffer): New function.
76 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
77 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
78 * undo.c, window.c: Adjust users.
79 * buffer.c (set_buffer_if_live): Fix comment.
80
a3d794a1
DA
812012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
82
83 Fix usage of set_buffer_internal.
84 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
85 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
86 * coding.c (decode_coding): Omit redundant test.
87 * fileio.c (decide_coding_unwind): Likewise.
88 * fns.c (secure_hash): Likewise.
89 * insdel.c (modify_region): Likewise.
90 * keyboard.c (command_loop_1): Likewise.
91 * print.c (PRINTFINISH): Likewise.
92 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
93
59ea14cd
PE
942012-08-27 Paul Eggert <eggert@cs.ucla.edu>
95
96 * dispnew.c: Use bool for boolean.
97 (frame_garbaged, display_completed, delayed_size_change)
98 (fonts_changed_p, add_window_display_history)
99 (add_frame_display_history, verify_row_hash)
100 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
101 (row_equal_p, realloc_glyph_pool)
102 (allocate_matrices_for_frame_redisplay)
103 (showing_window_margins_p)
104 (adjust_frame_glyphs_for_frame_redisplay)
105 (build_frame_matrix_from_leaf_window, make_current)
106 (mirrored_line_dance, mirror_line_dance, update_frame)
107 (update_window_tree, update_single_window)
108 (check_current_matrix_flags, update_window, update_text_area)
109 (update_window_line, set_window_update_flags, scrolling_window)
110 (update_frame_1, scrolling, buffer_posn_from_coords)
111 (do_pending_window_change, change_frame_size)
112 (change_frame_size_1, sit_for):
113 Use bool for boolean.
114 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
115 and remove last int (actually boolean) argument, which was always 0.
116 All callers changed.
117 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
118 * dispextern.h (struct composition_it): Use bool for boolean.
119 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
120 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
121 * dired.c (file_name_completion):
122 Use bool for boolean. (This was missed in an earlier change.)
123
95072a94
MR
1242012-08-27 Martin Rudalics <rudalics@gmx.at>
125
126 * window.c (Fset_window_configuration): Revert first part of
127 last change.
128
0f19feff
JD
1292012-08-27 Jan Djärv <jan.h.d@swipnet.se>
130
131 * nsterm.h (NSPanel): New class variable dialog_return.
132
133 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
134 dialog_return.
135 (windowShouldClose:): Use stop instead of stopModalWithCode.
136 (clicked:): Ditto, and also set dialog_return (Bug#12258).
137 (timeout_handler:): Use stop instead of abortModal. Send a dummy
138 event.
139 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
140 modal loop returns.
141
f10fe38f
PE
1422012-08-27 Paul Eggert <eggert@cs.ucla.edu>
143
de1339b0
PE
144 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
145 * composite.c (find_composition, composition_gstring_p)
146 (composition_reseat_it, find_automatic_composition):
147 * data.c (let_shadows_buffer_binding_p)
148 (let_shadows_global_binding_p, set_internal, make_blv)
149 (Fmake_variable_buffer_local, Fmake_local_variable)
150 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
151 (cons_to_signed, arith_driver):
152 * dbusbind.c (xd_in_read_queued_messages):
153 * dired.c (directory_files_internal, file_name_completion):
154 Use bool for booleans.
155 * dired.c (file_name_completion):
156 * process.h (fd_callback):
157 Omit int (actually boolean) argument. It wasn't being used.
158 All uses changed.
159 * composite.h, lisp.h: Reflect above API changes.
160
f10fe38f
PE
161 * cmds.c, coding.c: Use bool for booleans.
162 * cmds.c (move_point, Fself_insert_command):
163 * coding.h (struct composition status, struct coding_system):
164 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
165 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
166 (emacs_mule_char, decode_coding_emacs_mule)
167 (encode_coding_emacs_mule, detect_coding_iso_2022)
168 (decode_coding_iso_2022, encode_invocation_designation)
169 (encode_designation_at_bol, encode_coding_iso_2022)
170 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
171 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
172 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
173 (encode_coding_raw_text, detect_coding_charset)
174 (decode_coding_charset, encode_coding_charset, detect_eol)
175 (detect_coding, get_translation_table, produce_chars)
176 (consume_chars, reused_workbuf_in_use)
177 (make_conversion_work_buffer, code_conversion_save)
178 (decode_coding_object, encode_coding_object)
179 (detect_coding_system, char_encodable_p)
180 (Funencodable_char_position, code_convert_region)
181 (code_convert_string, code_convert_string_norecord)
182 (Fset_coding_system_priority):
183 * fileio.c (Finsert_file_contents):
184 Use bool for booleans.
185 * coding.h, lisp.h: Reflect above API changes.
186 * coding.c: Remove unnecessary static function decls.
187 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
188 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
189 not a boolean 'int', since callers never look at the return value.
190 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
191 * coding.h (decoding_buffer_size, encoding_buffer_size)
192 (emacs_mule_string_char): Remove unused extern decls.
193 (struct iso_2022_spec, struct coding_system):
194 Use 'unsigned int : 1' for boolean fields, since there's more than one.
195 (struct emacs_mule_spec): Remove unused field 'full_support'.
196 All initializations removed.
197 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
198
5474c384
DA
1992012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
200
f10fe38f 201 Fix spare memory change (Bug#12286).
5474c384
DA
202 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
203 (valid_lisp_object_p): Likewise.
204
c4b6914d
MR
2052012-08-27 Martin Rudalics <rudalics@gmx.at>
206
207 * window.c (Fset_window_configuration): Record any window's old
208 buffer if it's replaced (see Bug#8789). If the new current
209 buffer doesn't appear in the selected window, go to its old
210 point (Bug#12208).
211
35aaa1ea
DA
2122012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
213
214 Special MEM_TYPE_SPARE to denote reserved memory.
215 * alloc.c (enum mem_type): New memory type.
216 (refill_memory_reserve): Use new type for spare memory.
217 This prevents live_cons_p and live_string_p from incorrect
218 detection of uninitialized objects from spare memory as live.
219
6af64513
PE
2202012-08-26 Paul Eggert <eggert@cs.ucla.edu>
221
8b2e00a3
PE
222 Spelling fixes.
223 * Makefile.in (.PHONY): versioclean -> versionclean.
224
b52d6985
PE
225 Remove unused external symbols.
226 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
227 * window.c (Qwindow_valid_p, decode_valid_window):
228 Now static, not extern.
229 * data.c (Qinterval): Remove; unused.
230 (syms_of_data): Do not define 'interval'.
231 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
232 * window.h (decode_valid_window):
233 Remove decls.
234
d5172d4f
PE
235 * character.c, charset.c, chartab.c: Use bool for booleans.
236 * character.c (lisp_string_width, string_count_byte8)
237 (string_escape_byte8):
238 * charset.c (charset_map_loaded, load_charset_map, read_hex):
239 (load_charset_map_from_file, map_charset_chars)
240 (Fdefine_charset_internal, define_charset_internal)
241 (Fdeclare_equiv_charset, find_charsets_in_text)
242 (Ffind_charset_region, char_charset, Fiso_charset):
243 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
244 (sub_char_table_set, sub_char_table_set_range)
245 (char_table_set_range, optimize_sub_char_table)
246 (map_sub_char_table):
247 Use bool for boolean.
248 * character.c (str_to_unibyte): Omit last boolean argument; it was
249 always 0. All callers changed.
250 * character.h, charset.h: Adjust to match previous changes.
251 * character.h (char_printable_p): Remove decl of nonexistent function.
252 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
253 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
254 are all boolean, so make them single-bit bitfields.
255
6af64513
PE
256 * lisp.h (ASET): Remove attempt to detect side effects.
257 It was meant to be temporary and it often doesn't work,
258 because when IDX has side effects the behavior of IDX==IDX
259 is undefined. See Stefan Monnier in
260 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
261
e1f29348
BR
2622012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
263
264 * lisp.h (functionp): New function (extracted from Ffunctionp).
265 (FUNCTIONP): Use it.
266 * eval.c (Ffunctionp): Use it.
267
17c05d74
PE
2682012-08-25 Paul Eggert <eggert@cs.ucla.edu>
269
0f46bc75
PE
270 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
271 as that's faster and simpler than static storage. Don't bother
272 with the g_main_context_query overhead if g_main_context_pending
273 says no events are pending.
274 (gfds, gfds_size): Remove these static vars.
275 (xgselect_initialize): Remove; no longer needed.
276 All uses and decls removed.
277
ee4c0f69
PE
278 * emacs.c (fatal_error_signal_hook): Remove.
279 All uses removed. This leftover from old code was always 0.
280
17c05d74
PE
281 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
282 * casefiddle.c (casify_object, casify_region):
283 * casetab.c (set_case_table):
284 * category.c, category.h (word_boundary_p):
285 * category.h (CHAR_HAS_CATEGORY):
286 Use bool for booleans, instead of int.
287
391ceac5
EZ
2882012-08-25 Eli Zaretskii <eliz@gnu.org>
289
290 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
291
2f221583
PE
2922012-08-25 Paul Eggert <eggert@cs.ucla.edu>
293
f4a681b0
PE
294 On assertion failure, print backtrace if available.
295 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
296 (die) [ENABLE_CHECKING]: Print a backtrace if available.
297 * Makefile.in (LIB_EXECINFO): New macro.
298 (LIBES): Use it.
299
2f221583
PE
300 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
301 * bytecode.c (exec_byte_code):
302 * callint.c (check_mark, Fcall_interactively):
303 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
304 (getenv_internal, sync_process_alive, call_process_exited):
305 * lisp.h (USE_SAFE_ALLOCA):
306 Use bool for booleans, instead of int.
307 * lisp.h, process.h: Adjust prototypes to match above changes.
308 * callint.c (Fcall_interactively): Don't assume the mark's
309 offset fits in 'int'.
310
37ef52bb
PE
3112012-08-24 Paul Eggert <eggert@cs.ucla.edu>
312
313 * buffer.c, buffer.h: Use bool for boolean.
314 * buffer.c (reset_buffer_local_variables)
315 (buffer_lisp_local_variables, Fset_buffer_modified_p)
316 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
317 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
318 (overlay_touches_p, overlay_strings, Foverlay_put)
319 (report_overlay_modification, call_overlay_mod_hooks):
320 (mmap_enlarge, mmap_set_vars):
321 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
322 Use bool for booleans, instead of int.
323 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
324 since the 1-or-0 return value is always ignored anyway.
325 (mmap_initialized_p):
326 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
327 * buffer.h, lisp.h: Adjust prototypes to match above changes.
328
2cc21167
PE
3292012-08-23 Paul Eggert <eggert@cs.ucla.edu>
330
331 * bidi.c: Use bool for boolean.
332 This is a bit more readable, and makes the text segment of bidi.o
333 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
334 Presumably it's faster too.
335 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
336 Now bool.
337 (bidi_cache_find_level_change, bidi_cache_iterator_state)
338 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
339 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
340 (bidi_explicit_dir_char, bidi_level_of_next_char)
341 (bidi_find_other_level_edge, bidi_move_to_visually_next):
342 Use bool for booleans, instead of int.
343 * dispextern.h (bidi_init_it, bidi_paragraph_init)
344 (bidi_unshelve_cache): Adjust decls to match code.
345
7db4ddf4
MR
3462012-08-23 Martin Rudalics <rudalics@gmx.at>
347
348 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
349 argument.
350
b1bb8011
PE
3512012-08-23 Paul Eggert <eggert@cs.ucla.edu>
352
353 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
354 * atimer.h: Include <stdbool.h>.
355
ff687885
DN
3562012-08-22 Dan Nicolaescu <dann@gnu.org>
357
358 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
359 compile time tests instead of run time tests on systems that do
360 not use them.
361 (FRAME_MAC_P): Remove leftover from deleted code.
362 * frame.c (syms_of_frame): Remove leftover from deleted code.
363
4ce7a138
JD
3642012-08-22 Jan Djärv <jan.h.d@swipnet.se>
365
366 * nsterm.m (insertText:): Don't clear modifiers if code is space.
367
d733ec6d
PE
3682012-08-22 Paul Eggert <eggert@cs.ucla.edu>
369
370 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
371 Otherwise, the compiler complains about (A?B:C) where B is void
372 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
373 (fontset_add): Return void, for FONTSET_ADD.
374
d0d2d26f
PE
3752012-08-21 Paul Eggert <eggert@cs.ucla.edu>
376
fce31d69
PE
377 * alloc.c: Use bool for booleans.
378 (gc_in_progress, abort_on_gc)
379 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
380 (dont_register_blocks) [GC_MALLOC_CHECK]:
381 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
382 (check_string_bytes, make_specified_string, memory_full)
383 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
384 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
385 (mark_stack, valid_pointer_p, make_pure_string)
386 (Fgarbage_collect, survives_gc_p, gc_sweep):
387 Use bool for booleans, instead of int.
388 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
389 Remove unused local.
390 * alloc.c (PURE_POINTER_P):
391 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
392 * editfns.c (Fformat):
393 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
394 (Fdo_auto_save):
395 * fns.c (sweep_weak_table):
396 * lisp.h (suppress_checking, push_message, survives_gc_p)
397 (make_pure_string, gc_in_progress, abort_on_gc):
398 * lread.c (readchar, read1):
399 * print.c (Fprin1_to_string):
400 * xdisp.c (push_message):
401 Use bool for booleans affected directly or indirectly by
402 alloc.c's changes.
403
d0d2d26f
PE
404 Make recently-introduced setters macros.
405 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
406 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
407 (set_fontset_default, set_fontset_fallback): Rename from their
408 upper-case counterparts, and make them functions rather than macros.
409 This is more consistent with the other recently-introduced setters.
410 These don't need to be inline, since they're local.
411
d18e2bb6
JD
4122012-08-21 Jan Djärv <jan.h.d@swipnet.se>
413
414 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
415 the loop (Bug#12247).
416
1b9d9d16
PE
4172012-08-21 Paul Eggert <eggert@cs.ucla.edu>
418
419 * lisp.h (vcopy): Use memcpy rather than our own loop.
420 This fixes a performance regression introduced by the recent
421 addition of vcopy. This means 'vcopy' will need to be modified
422 for a copying collector, but that's OK. Also, tighten the
423 checking in the assertion.
424
b2f09701
EZ
4252012-08-21 Eli Zaretskii <eliz@gnu.org>
426
427 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
428 components for RTL text (Bug#11860). Adjust X-OFFSET of each
429 non-base glyph for the width of the base character, according to
e1f29348
BR
430 what x_draw_composite_glyph_string_foreground expects.
431 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
432 expectations, to produce correct width of the composed character.
433 Reverse the sign of the DU offset produced by ScriptPlace.
434
9b994fed
PE
4352012-08-21 Paul Eggert <eggert@cs.ucla.edu>
436
437 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
438
086ca913
DA
4392012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
440
441 Avoid direct writes to contents member of struct Lisp_Vector.
442 * lisp.h (vcopy): New function to copy data into vector.
443 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
444 * fns.c (Ffillarray): Use ASET.
445 * keyboard.c (timer_check_2): Use AREF and ASET.
446 (append_tool_bar_item, Frecent_keys): Use vcopy.
447 * lread.c (read_vector): Use ASET.
448 * msdos.c (Frecent_doskeys): Use vcopy.
449 * xface.c (Finternal_copy_lisp_face): Use vcopy.
450 (Finternal_merge_in_global_face): Use ASET and vcopy.
451 * xfont.c (xfont_list_pattern): Likewise.
452
5481664a
MR
4532012-08-21 Martin Rudalics <rudalics@gmx.at>
454
455 * window.c (Fwindow_point): For the selected window always return
456 the position of its buffer's point.
457 (Fset_window_point): For the selected window always go in its
458 buffer to the specified position.
459
6d470bdd
DA
4602012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
461
462 Setter macros for fontsets.
463 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
464 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
465 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
466 Adjust users.
467
24564fe1
GM
4682012-08-20 Glenn Morris <rgm@gnu.org>
469
470 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
471 Don't assume that `ln -f' works.
472
0a05a035
EZ
4732012-08-20 Eli Zaretskii <eliz@gnu.org>
474
475 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
476 and later about non-assignments with no effect. See discussion at
477 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
478 details.
479
e46f2325
DA
4802012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
481
482 Inline setter functions for Lisp_Objects slots of struct specbinding.
483 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
484 Adjust users.
485
734fbd86
MR
4862012-08-20 Martin Rudalics <rudalics@gmx.at>
487
488 * window.c (select_window): Always make selected window's buffer
489 current.
490
f1a95992
DA
4912012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
492
493 Use AREF and ASET for docstrings of category tables.
494 * category.h (CATEGORY_DOCSTRING): Use AREF.
495 (SET_CATEGORY_DOCSTRING): Use ASET.
496 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
497
e83064be
DA
4982012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
499
500 Inline setter functions for hash table members.
501 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
502 (set_hash_hash, set_hash_index): Rename with _slot suffix.
503 (set_hash_key_and_value, set_hash_index, set_hash_next)
504 (set_hash_hash): New functions.
505 * charset.c, fns.c: Adjust users.
506
4ce60d2e
DA
5072012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
508
509 Inline getter and setter functions for per-buffer values.
510 * buffer.h (per_buffer_default, set_per_buffer_default)
511 (per_buffer_value, set_per_buffer_value): New functions.
512 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
513 * buffer.c, data.c: Adjust users.
514
c06c9690
JB
5152012-08-20 Juanma Barranquero <lekktu@gmail.com>
516
517 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
518
32bd4250
PE
5192012-08-19 Paul Eggert <eggert@cs.ucla.edu>
520
bad03192 521 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
522 as gnulib does this if the system doesn't.
523 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
524 Remove declaration. MS-Windows declares it on stdlib.h which is
525 included by conf_post.h.
b69a6d22
PE
526 * emacs.c (environ) [DOUG_LEA_MALLOC]:
527 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
528 * vm-limit.c: Include <unistd.h>, for 'environ'.
529
22d7feb2
PE
530 * unexaix.c, unexcoff.c: Include "mem-limits.h".
531 (start_of_data): Remove decl; mem-limits.h provides it.
532
32bd4250
PE
533 * xdisp.c (handle_invisible_prop): Make it a bit faster
534 and avoid a gcc -Wmaybe-uninitialized diagnostic.
535
450809af
CY
5362012-08-19 Chong Yidong <cyd@gnu.org>
537
538 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
539 ends (Bug#3874).
540
9e677988
AS
5412012-08-19 Andreas Schwab <schwab@linux-m68k.org>
542
6b1319ce
AS
543 * .gdbinit: Use call instead of set when calling a function in the
544 inferior.
545
9e677988
AS
546 * data.c (set_internal): Don't use set_blv_found.
547 (Fkill_local_variable): Likewise.
548
d7191076
AA
5492012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
550
551 * nsfont.m (ns_ascii_average_width): Ensure the string
552 ascii_printable is initialized with a null-terminated character
553 array. Otherwise, it can contain undesired extra characters.
554
e757f1c6
PE
5552012-08-18 Paul Eggert <eggert@cs.ucla.edu>
556
557 port new setting code to Sun C 5.8 2005/10/13
558 * chartab.c, lisp.h (char_table_set, char_table_set_range):
559 Return void, not Lisp_Object. Otherwise, the compiler
560 complains about (A?B:C) where B is void and C is Lisp_Object
561 when compiling CHAR_TABLE_SET, due to the recent change to
562 the API of sub_char_table_set_contents.
563
a999ce26
CY
5642012-08-18 Chong Yidong <cyd@gnu.org>
565
566 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
567 for the string case (Bug#3874).
568
3f22b86f
PE
5692012-08-18 Paul Eggert <eggert@cs.ucla.edu>
570
39eb03f1
PE
571 * buffer.h (BSET): Remove (Bug#12215).
572 Replace all uses with calls to new setter functions.
573 (bset_bidi_paragraph_direction, bset_case_canon_table)
574 (bset_case_eqv_table, bset_directory, bset_display_count)
575 (bset_display_time, bset_downcase_table)
576 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
577 (bset_last_selected_window, bset_local_var_alist)
578 (bset_mark_active, bset_point_before_scroll, bset_read_only)
579 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
580 (bset_width_table):
581 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
582 (bset_auto_fill_function, bset_auto_save_file_format)
583 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
584 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
585 (bset_cache_long_line_scans, bset_case_fold_search)
586 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
587 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
588 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
589 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
590 (bset_header_line_format, bset_indicate_buffer_boundaries)
591 (bset_indicate_empty_lines, bset_invisibility_spec)
592 (bset_left_fringe_width, bset_major_mode, bset_mark)
593 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
594 (bset_name, bset_overwrite_mode, bset_pt_marker)
595 (bset_right_fringe_width, bset_save_length)
596 (bset_scroll_bar_width, bset_scroll_down_aggressively)
597 (bset_scroll_up_aggressively, bset_selective_display)
598 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
599 (bset_word_wrap, bset_zv_marker):
600 * category.c (bset_category_table):
601 * syntax.c (bset_syntax_table):
602 New setter functions.
603
6a09a33b
PE
604 * process.h (PSET): Remove (Bug#12215).
605 Replace all uses with calls to new setter functions.
606 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
607 (PROCESS_INLINE): New macro.
608 (pset_childp): New setter function.
609 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
610 * process.c (PROCESS_INLINE):
611 Define to EXTERN_INLINE, so that the corresponding functions
612 are compiled into code.
613 (pset_buffer, pset_command, pset_decode_coding_system)
614 (pset_decoding_buf, pset_encode_coding_system)
615 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
616 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
617 (pset_type, pset_write_queue): New setter functions.
618
e8c17b81
PE
619 * window.h (WSET): Remove (Bug#12215).
620 Replace all uses with calls to new setter functions.
621 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
622 (WINDOW_INLINE): New macro.
623 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
624 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
625 (wset_total_lines, wset_vertical_scroll_bar)
626 (wset_window_end_pos, wset_window_end_valid)
627 (wset_window_end_vpos): New setter functions.
628 * window.c (WINDOW_INLINE):
629 Define to EXTERN_INLINE, so that the corresponding functions
630 are compiled into code.
631 (wset_combination_limit, wset_dedicated, wset_display_table)
632 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
633 (wset_new_normal, wset_new_total, wset_next_buffers)
634 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
635 (wset_prev_buffers, wset_right_fringe_width)
636 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
637 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
638 (wset_window_parameters):
639 * xdisp.c (wset_base_line_number, wset_base_line_pos)
640 (wset_column_number_displayed, wset_region_showing):
641 New setter functions.
642
3f22b86f
PE
643 * termhooks.h (TSET): Remove (Bug#12215).
644 Replace all uses with calls to new setter functions.
645 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
646 (TERMHOOKS_INLINE): New macro.
647 (tset_charset_list, tset_selection_alist): New setter functions.
648 * terminal.c (TERMHOOKS_INLINE):
649 Define to EXTERN_INLINE, so that the corresponding functions
650 are compiled into code.
651 (tset_param_alist): New setter function.
652
742af32f
PE
6532012-08-17 Paul Eggert <eggert@cs.ucla.edu>
654
15dbb4d6
PE
655 * keyboard.h (KSET): Remove (Bug#12215).
656 Replace all uses with calls to new setter functions.
657 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
658 (KEYBOARD_INLINE): New macro.
659 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
660 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
661 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
662 New setter functions.
663 * keyboard.c (KEYBOARD_INLINE):
664 Define to EXTERN_INLINE, so that the corresponding functions
665 are compiled into code.
666 (kset_echo_string, kset_kbd_queue)
667 (kset_keyboard_translate_table, kset_last_prefix_arg)
668 (kset_last_repeatable_command, kset_local_function_key_map)
669 (kset_overriding_terminal_local_map, kset_real_last_command)
670 (kset_system_key_syms): New setter functions.
671
f00af5b1
PE
672 * frame.h (FSET): Remove (Bug#12215).
673 Replace all uses with calls to new setter functions.
674 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
675 (FRAME_INLINE): New macro.
676 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
677 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
678 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
679 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
680 (fset_param_alist, fset_root_window, fset_scroll_bars)
681 (fset_selected_window, fset_title, fset_tool_bar_items)
682 (fset_tool_bar_position, fset_tool_bar_window): New functions.
683 * frame.c (FRAME_INLINE):
684 Define to EXTERN_INLINE, so that the corresponding functions
685 are compiled into code.
686 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
687
0c94c8d6
PE
688 A few more naming-convention fixes for getters and setters.
689 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
690 and rename from buffer_overlays_set_before.
691 (set_buffer_overlays_after): Move here from buffer.h, and rename
692 from buffer_overlays_set_after.
693 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
694 All uses changed.
695 (set_buffer_intervals): Rename from buffer_set_intervals.
696 * intervals.c (set_interval_object): Move here from intervals.h,
697 and rename from interval_set_object.
698 (set_interval_left): Move here from intervals.h, and rename from
699 interval_set_left.
700 (set_interval_right): Move here from intervals.h, and rename from
701 interval_set_right.
702 (copy_interval_parent): Move here from intervals.h, and rename from
703 interval_copy_parent.
704 * intervals.h (set_interval_parent): Rename from interval_set_parent.
705 (set_interval_plist): Rename from interval_set_plist.
706 Return void, not Lisp_Object, since no caller uses the result.
707 * lisp.h (string_intervals): Rename from string_get_intervals.
708 (set_string_intervals): Rename from string_set_intervals.
709
34dabdb7
PE
710 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
711 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 712 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
713 All uses changed. See the end of
714 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
715
742af32f
PE
716 * lisp.h (CSET): Remove (Bug#12215).
717 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
718 (set_char_table_purpose): New functions,
719 replacing CSET. All uses changed. For example, replace
720 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 721 "set_char_table_parent (char_table, parent);".
742af32f
PE
722 The old version was confusing because it used the same name
723 'parent' for two different things.
724
a04e2c62
DA
7252012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
726
727 Functions to get and set Lisp_Object fields of buffer-local variables.
728 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
729 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
730 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
731 * data.c, eval.c, frame.c: Adjust users.
732
383dcbf9
CY
7332012-08-17 Chong Yidong <cyd@gnu.org>
734
735 * xfaces.c (merge_face_vectors): If the target font specfies a
736 font spec, make the font's attributes take precedence over
737 directly-specified attributes.
738 (merge_face_ref): Recognize :font.
739
44386687
DA
7402012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
741
742 Do not use memcpy for copying intervals.
743 * intervals.c (reproduce_interval): New function.
744 (reproduce_tree, reproduce_tree_obj): Use it.
745 (reproduce_tree_obj): Remove prototype.
746
927c7216
PE
7472012-08-17 Paul Eggert <eggert@cs.ucla.edu>
748
749 * lisp.h (duration_to_sec_usec): Remove unused decl.
750
93044f7b
AA
7512012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
752
753 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
754 to an allocated instance of NSString, not to the class itself.
755
9851e4a5
JB
7562012-08-17 Juanma Barranquero <lekktu@gmail.com>
757
758 * makefile.w32-in (C_CTYPE_H): New macro.
759 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
760 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
761 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
762
620f13b0
PE
7632012-08-16 Paul Eggert <eggert@cs.ucla.edu>
764
765 Use ASCII tests for character types.
766 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
767 * xfns.c, xterm.c:
768 Don't include <ctype.h>; was not needed.
769 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
770 * sysdep.c, xfaces.c:
771 Include <c-ctype.h> instead of <ctype.h>.
772 * nsterm.m: Include <c-ctype.h>.
773 * charset.c (read_hex):
774 * doc.c (Fsnarf_documentation):
775 * fileio.c (IS_DRIVE) [WINDOWSNT]:
776 (DRIVE_LETTER) [DOS_NT]:
777 (Ffile_name_directory, Fexpand_file_name)
778 (Fsubstitute_in_file_name):
779 * font.c (font_parse_xlfd, font_parse_fcname):
780 * frame.c (x_set_font_backend):
781 * gtkutil.c (xg_get_font):
782 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
783 * nsimage.m (hexchar):
784 * nsterm.m (ns_xlfd_to_fontname):
785 * sysdep.c (system_process_attributes):
786 * xfaces.c (hash_string_case_insensitive):
787 Use C-locale tests instead of locale-specific tests for character
788 types, since we want the ASCII interpretation here, not the
789 interpretation suitable for whatever happens to be the current locale.
790
52162052
MR
7912012-08-16 Martin Rudalics <rudalics@gmx.at>
792
793 Consistently check windows for validity/liveness
794 (Bug#11984, Bug#12025, Bug#12026).
795 * lisp.h (CHECK_VALID_WINDOW): New macro.
796 * window.c (decode_window): Rename to decode_live_window.
797 (decode_valid_window, Fwindow_valid_p): New functions.
798 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
799 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
800 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
801 (Fwindow_prev_sibling, Fwindow_combination_limit)
802 (Fset_window_combination_limit, Fwindow_use_time)
803 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
804 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
805 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
806 (Fwindow_hscroll, Fset_window_hscroll)
807 (Fwindow_redisplay_end_trigger)
808 (Fset_window_redisplay_end_trigger, Fwindow_edges)
809 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
810 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
811 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
812 (Fwindow_end, Fset_window_point, Fset_window_start)
813 (Fpos_visible_in_window_p, Fwindow_line_height)
814 (Fwindow_dedicated_p, Fset_window_dedicated_p)
815 (Fwindow_prev_buffers, Fset_window_prev_buffers)
816 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
817 (Fset_window_parameter, Fwindow_display_table)
818 (Fset_window_display_table, Fdelete_other_windows_internal)
819 (Fset_window_buffer, Fset_window_new_total)
820 (Fset_window_new_normal, Fdelete_window_internal)
821 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
822 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
823 (Fwindow_scroll_bars): Check whether argument window is a valid or
824 live window. Update doc-strings.
825 (syms_of_window): New symbol Qwindow_valid_p.
826 * keyboard.c (Fposn_at_x_y): Check whether argument
827 frame_or_window denotes a valid window.
828
2751c80f
DA
8292012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
830
831 Fix previous char table change.
832 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
833 * chartab.c (optimize_sub_char_table): Likewise.
834
032a42c8
CY
8352012-08-16 Chong Yidong <cyd@gnu.org>
836
a2d19368
CY
837 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
838
032a42c8
CY
839 * xfont.c (xfont_open):
840 * xftfont.c (xftfont_open): Set the font's max_width field.
841
842 * nsfont.m (nsfont_open): Similar to the Xft backend, set
843 min_width to space_width and average_width to the average over
844 printable ASCII characters.
845 (ns_char_width): Code cleanup.
846 (ns_ascii_average_width): New utility function.
847
848 * font.h (struct font): Update comments.
849
a098c930
DA
8502012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
851
032a42c8 852 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
853 * lisp.h (CSET): New macro.
854 (char_table_set_extras, char_table_set_contents)
855 (sub_char_table_set_contents): New function.
856 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
857 * syntax.c: Adjust users.
858
8be3a09c
SM
8592012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
860
861 * eval.c (eval_sub): Bind lexical-binding.
862 * lread.c (Qlexical_binding): Make non-static.
863
ac4845a6
JD
8642012-08-15 Jan Djärv <jan.h.d@swipnet.se>
865
ddee6515
JD
866 * nsmenu.m (popupSession): Remove.
867 (pop_down_menu): Remove endModalSession.
868 (timeout_handler:): New method.
869 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
870 Call runModalForWindow. Check timer_fired when it returns.
871 If not set, cancel timer and break out of loop.
872 Otherwise loop again, with a new timeout.
873
874 * nsterm.m: Include fcntl.h if present.
875 (fd_entry, t_readfds, inNsSelect): Remove.
876 (select_writefds, select_valid, select_timeout, selfds)
877 (select_mutex, apploopnr): Add.
878 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
879 Otherwise call kbd_buffer_store_event.
880 (ns_send_appdefined): Remove release of fd_entry.
881 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
882 Increment and decrement apploopnr.
883 (ns_select): If no file descriptors, just do a NSTimer.
884 Otherwise copy read/write masks and start select thread (fd_handler).
885 Start main loop and wait for application defined event.
886 Inform select thread to stop selecting after main loop is exited.
887 (ns_term_init): Create selfds pipe and set non-blocking.
888 Initialize select_mutex. Start the select thread (fd_handler).
889 (fd_handler:): Loop forever, wait for info from the main thread
890 to either start or stop selecting. When select returns, send
891 and appdefined event.
892 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
893 If not call kbd_buffer_store_event.
894
895 * nsterm.h (EmacsApp): fd_handler takes id argument.
896 (EmacsDialogPanel): Add timer_fired and timeout_handler.
897
ac4845a6
JD
898 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
899
eb424fe3
EZ
9002012-08-15 Eli Zaretskii <eliz@gnu.org>
901
902 * region-cache.c (move_cache_gap): Update gap_len using the actual
903 growth of the boundaries array. Do not change cache_len.
904 (Bug#12196)
905
4e6a86c6
DA
9062012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
907
908 Generalize and cleanup font subsystem checks.
909 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
910 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
911 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 912
5bf192ca
DA
9132012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
914
915 * gtkutil.c (xg_get_font): Use pango_units_to_double.
916
f2045622
CY
9172012-08-15 Chong Yidong <cyd@gnu.org>
918
8be3a09c
SM
919 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
920 When using the new font chooser, use gtk_font_chooser_get_font_desc to
921 extract the font descriptor instead of just the font name.
922 In that case, return a font spec instead of a string.
f2045622
CY
923 (x_last_font_name): Move to this file from xfns.c.
924
925 * xfns.c (Fx_select_font): The return value can also be a font
926 spec. Move x_last_font_name management to gtkutil.c.
927
928 * xfaces.c: Make font weight and style symbols non-static.
929
7f6feb56
SM
9302012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
931
932 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
933 (bug#12117).
934
fecbd8ff
SM
9352012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
936
937 * alloc.c (Fgarbage_collect): Use plural form consistently.
938
9b8d5165
EZ
9392012-08-14 Eli Zaretskii <eliz@gnu.org>
940
941 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
942 iteration through the command loop. Fixes a problem whereby mouse
943 movements are ignored until the first mouse click.
944
f5d9e83a
PE
9452012-08-14 Paul Eggert <eggert@cs.ucla.edu>
946
947 Use bool, not int, for Lisp booleans.
948 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
949 makes Emacs a bit smaller and presumably a bit faster.
950 * lisp.h: Include <stdbool.h>.
951 (struct Lisp_Boolfwd, defvar_bool):
952 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
953 * regex.c [!emacs]: Include <stdbool.h>.
954 (false, true): Remove; <stdbool.h> does this for us now.
955
55802e4a
CY
9562012-08-14 Chong Yidong <cyd@gnu.org>
957
4abcdac8
CY
958 * character.c (Fcharacterp): Doc fix (Bug#12076).
959
960 * data.c (Findirect_variable): Doc fix (Bug#11040).
961
55802e4a
CY
962 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
963
964 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 965 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 966
8e99d072
BR
9672012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
968
969 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
970 (bug#12022).
971
08908aca
MR
9722012-08-14 Martin Rudalics <rudalics@gmx.at>
973
974 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
975 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
976 * minibuf.c (choose_minibuf_frame, read_minibuf):
977 * w32fns.c (x_create_tip_frame):
978 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
979 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
980
56120d6f
PE
9812012-08-14 Paul Eggert <eggert@cs.ucla.edu>
982
983 * intervals.c (offset_intervals): Remove obsolete comment.
984
67b77c0b
AS
9852012-08-14 Andreas Schwab <schwab@linux-m68k.org>
986
987 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
988
f48b82fd
GR
9892012-08-14 Gergely Risko <gergely@risko.hu>
990
991 * coding.c (decode_coding): Record buffer modification before
992 disabling undo_list (Bug#11773).
993
fd318b54
DA
9942012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
995
996 Revert and cleanup some recent overlay changes.
997 * buffer.h (enum overlay_type): Remove.
998 (buffer_get_overlays, buffer_set_overlays): Likewise.
999 (buffer_set_overlays_before, buffer_set_overlays_after):
1000 New function. Adjust users.
1001 (unchain_both): Add eassert.
1002
41a62dd9
DA
10032012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1004
1005 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
1006
5884c324
PE
10072012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 * gtkutil.c (xg_mark_data): Don't assume C99.
1010
ca06f160
JD
10112012-08-13 Jan Djärv <jan.h.d@swipnet.se>
1012
1013 * gtkutil.c (xg_frame_tb_info): New struct.
1014 (TB_INFO_KEY): New define.
1015 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
1016 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
1017 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
1018 if not present.
1019 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
1020 is up to date. Otherwise store new data.
1021 (free_frame_tool_bar): Free xg_frame_tb_info if present.
1022
7864a3f7
DA
10232012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1024
1025 Use KSET for write access to Lisp_Object members of struct kboard.
1026 * keyboard.h (KSET): New macro.
1027 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
1028 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
1029 * xterm.c: Adjust users.
1030
4c31be61
DA
10312012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1032
1033 Use BSET for write access to Lisp_Object members of struct buffer.
1034 * buffer.h (BSET): New macro.
1035 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
1036 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
1037 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
1038 * window.c, xdisp.c, xfns.c: Adjust users.
1039
14ae4239
BT
10402012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
1041
1042 * lread.c (syms_of_lread): Initialize Vlexical_binding.
1043
32bcadb4
JD
10442012-08-11 Jan Djärv <jan.h.d@swipnet.se>
1045
3d29b2ce
JD
1046 * nsterm.m (not_in_argv): New function.
1047 (application:openFile, application:openTempFile:):
1048 (application:openFileWithoutUI:, application:openFiles:): Open file
1049 if not_in_argv returns non-zero (bug#12171).
1050
32bcadb4 1051 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
1052 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
1053 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
1054 (xg_get_font_name): Use those functions/macros here.
1055 Reported by Frans Oilinki <moilinki@gmail.com>.
1056
9ff9402d 10572012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
1058
1059 * unexmacosx.c (copy_data_segment): Copy initialized data in
1060 statically linked libraries from input file rather than memory.
1061
db74a5fc
YM
1062 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
1063 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
1064 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
1065
25e65510
GM
10662012-08-10 Glenn Morris <rgm@gnu.org>
1067
1068 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
1069 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
1070
7961135c
DA
10712012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1072
1073 Fix last change to allow compilation with low optimization levels.
1074 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
1075 Reported by Jan Djärv <jan.h.d@swipnet.se>.
1076
42b3a444
DA
10772012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1078
1079 Use common inline syntax in intervals.h.
1080 * intervals.h (INTERVALS_INLINE): New macro.
1081 Change all users from LISP_INLINE.
1082
9fb0c957
DA
10832012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1084
1085 Define Qnone once for all platforms.
1086 * frame.c (Qnone): Define here.
1087 (syms_of_frame): DEFSYM it.
1088 * lisp.h (Qnone): New declaration.
1089 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
1090 * xfns.c: Remove duplication. Adjust users.
1091
65e8ee52
DA
10922012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1093
1094 Remove unused macros from intervals.h.
1095 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
1096 * intervals.c: Adjust comment.
1097
9b855fd6
EZ
10982012-08-10 Eli Zaretskii <eliz@gnu.org>
1099
1100 * w32fns.c <w32_unicode_gui>: New static variable.
1101 (globals_of_w32fns): Initialize it according to os_subtype.
1102 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
1103 testing os_subtype.
1104
39cb9e56 11052012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
1106 Eli Zaretskii <eliz@gnu.org>
1107
1108 Fix bug #10299 with Unicode characters sent by customized
1109 keyboards created by MSKLC.
1110 * w32fns.c (INIT_WINDOW_CLASS): New macro.
1111 (w32_init_class): Use it to initialize the Emacs class with either
1112 ANSI or Unicode API calls.
1113 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
1114 later.
1115 (w32_wnd_proc): If the character code sent by WM_CHAR or
1116 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
1117 original message. Call DefWindowProcW on NT and later.
1118
9374581a
GM
11192012-08-10 Glenn Morris <rgm@gnu.org>
1120
4b94e8cf
GM
1121 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
1122
9374581a
GM
1123 * lisp.h (DIRECTORY_SEP): Let configure set it.
1124
a2752828
DA
11252012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1126
1127 Use TSET for write access to Lisp_Object slots of struct terminal.
1128 * termhooks.h (TSET): New macro.
1129 * coding.c, terminal.c, xselect.c: Adjust users.
1130
cc92c454
SM
11312012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
1132
1133 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
1134 the failing expression, include them in the error message.
1135 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
1136 * lisp.h (internal_condition_case_n): Update declaration.
1137
4cb3e6b3
DA
11382012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1139
1140 Inline functions to examine and change buffer overlays.
1141 * buffer.c (unchain_both): New function.
1142 * buffer.h (buffer_get_overlays, buffer_set_overlays):
1143 (buffer_has_overlays): New function.
1144 (enum overlay_type): New enum.
1145 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
1146 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
1147
8707c1e5
DA
11482012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1149
1150 Inline functions to examine and change buffer intervals.
1151 * alloc.c (mark_interval_tree): Remove.
1152 (MARK_INTERVAL_TREE): Simplify.
1153 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
1154 * intervals.c (buffer_balance_intervals): New function.
1155 (graft_intervals_into_buffer): Adjust indentation.
1156 (set_intervals_multibyte): Simplify.
1157 * buffer.h (BUF_INTERVALS): Remove.
1158 (buffer_get_intervals, buffer_set_intervals): New function.
1159 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
1160 * intervals.c, textprop.c: Adjust users.
1161
ad8c997f
DA
11622012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1163
1164 Inline functions to examine and change string intervals.
1165 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
1166 (string_get_intervals, string_set_intervals): New function.
1167 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1168 * lread.c, print.c, textprop.c: Adjust users.
1169
32ac3a6b
GM
11702012-08-08 Glenn Morris <rgm@gnu.org>
1171
1172 * lisp.mk (lisp): Remove language/persian.elc.
1173
77c7bcb1
DA
11742012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1175
1176 Cleanup intervals.
1177 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
1178 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
1179 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
1180 Adjust comment. Move under #if 0.
77c7bcb1
DA
1181 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1182 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
1183
9c08a8d4
DA
11842012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1185
1186 Check total length of intervals with eassert.
1187 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
1188 * intervals.c: Change all users to eassert.
1189
26d16b35
EZ
11902012-08-07 Eli Zaretskii <eliz@gnu.org>
1191
14ae4239
BT
1192 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
1193 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
1194 INTERNAL_FIELD in Lisp_Cons.
1195
c644523b
DA
11962012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1197
1198 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
1199 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
1200 name since all xname users are fixed long time ago. Do not
1201 use INTERNAL_FIELD.
1202 (set_symbol_name, set_symbol_function, set_symbol_plist):
1203 (set_symbol_next, set_overlay_plist): New function.
1204 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
1205 (struct Lisp_Overlay): Likewise.
1206 (CVAR, MVAR, SVAR): Remove.
1207 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
1208 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
1209 * xterm.c: Adjust users.
1210 * .gdbinit: Change to use name field of struct Lisp_Symbol
1211 where appropriate.
1212
6a3d20cc
DA
12132012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1214
1215 Basic functions to set Lisp_Object and pointer slots of intervals.
1216 * intervals.h (interval_set_parent, interval_set_object):
1217 (interval_set_left, interval_set_right, interval_set_plist):
1218 (interval_copy_parent): New function.
1219 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
1220 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
1221 Adjust indentation.
6a3d20cc
DA
1222 (INTERVAL_SIZE): Remove. Adjust users.
1223 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
1224
4d2b044c
DA
12252012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1226
1227 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
1228 * process.h (PGET): Remove.
1229 (struct Lisp_Process): Do not use INTERNAL_FIELD.
1230 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1231
d3d50620
DA
12322012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1233
1234 Drop WGET and revert read access to Lisp_Objects slots of struct window.
1235 * window.h (WGET): Remove.
1236 (struct window): Do not use INTERNAL_FIELD.
1237 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1238 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1239 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1240 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1241 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1242 Adjust users.
1243
d10a51dc
CY
12442012-08-07 Chong Yidong <cyd@gnu.org>
1245
1246 * window.c (Fwindow_edges, Fwindow_pixel_edges)
1247 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
1248 (Fdelete_window_internal): Signal an error if the window is not on
1249 a live frame (Bug#12025).
1250
e69b0960
DA
12512012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1252
1253 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
1254 * frame.h (FGET): Remove.
1255 (struct frame): Do not use INTERNAL_FIELD.
1256 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1257 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1258 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1259 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1260
25a20a3a
JB
12612012-08-06 Juanma Barranquero <lekktu@gmail.com>
1262
1263 * w32.c: Silence compiler warnings.
1264 (map_w32_filename): Remove unused variable `is_fat'.
1265 (chase_symlinks): Add parentheses around expression.
1266
1c6f11f4
GM
12672012-08-06 Glenn Morris <rgm@gnu.org>
1268
1db4583a
GM
1269 * sysdep.c: Respect BROKEN_GETWD.
1270
1c6f11f4
GM
1271 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
1272 Let configure handle it.
1273 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
1274
2b90362b
DA
12752012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1276
1277 Use GCALIGNMENT where appropriate.
1278 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
1279 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
1280 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
1281
5f50daf2
EZ
12822012-08-06 Eli Zaretskii <eliz@gnu.org>
1283
14ae4239
BT
1284 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
1285 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 1286
cbcc7007
SM
12872012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
1288
1289 * buffer.h (struct buffer): Revert `indirections' to a simple int;
1290 that should be sufficient for everyone.
1291
4d365fa4
JD
12922012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1293
1294 * keyboard.c (timer_check_2): Add break so timer_check returns next
1295 timeout.
1296
dd86bd82
DA
12972012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 Fix Windows build errors introduced after converting to WGET and WSET.
1300 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
1301 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1302
054e1668
JD
13032012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1304
1305 * nsterm.m (ns_frame_rehighlight): Use FSET.
1306
1307 * nsmenu.m (ns_update_menubar): Use FSET.
1308
21238f11
DA
13092012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1310
1311 Separate read and write access to Lisp_Object slots of Lisp_Process.
1312 * process.h (PGET, PSET): New macros similar to AREF and ASET.
1313 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1314
077288cf
DA
13152012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1316
1317 Separate read and write access to Lisp_Object slots of struct window.
1318 * window.h (WGET, WSET): New macros similar to AREF and ASET.
1319 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1320 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1321 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1322 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1323 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1324 Adjust users.
1325
71688bd7
DA
13262012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1327
1328 Fix Windows build errors introduced after converting to FGET and FSET.
1329 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
1330 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
1331 (w32_judge_scroll_bars): Change to use FSET.
1332 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1333
f99bac93
DA
13342012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1335
1336 Fix replacement typo.
1337 * window.c (replace_window): Set root_window instead of
1338 selected_window. This fixes a total window subsystem
1339 malfunction reported by Bastien Guerry <bzg@gnu.org>.
1340
8c2a0f2d
GM
13412012-08-06 Glenn Morris <rgm@gnu.org>
1342
1343 * lisp.mk (lisp): Add language/persian.elc.
1344
edd74c35
DA
13452012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1346
1347 Separate read and write access to Lisp_Object slots of struct frame.
1348 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
1349 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1350 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1351 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1352 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1353
8671676c
AS
13542012-08-05 Andreas Schwab <schwab@linux-m68k.org>
1355
1356 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
1357
663e2b3f
DA
13582012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1359
1360 Generalize common compile-time constants.
1361 * lisp.h (header_size, bool_header_size, word_size): Now here.
1362 (struct Lisp_Vector): Add comment.
1363 (struct Lisp_Bool_Vector): Move up to define handy constants.
1364 (VECSIZE, PSEUDOVECSIZE): Simplify.
1365 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
1366 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
1367 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
1368 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
1369 * xfont.c, xmenu.c: Use word_size where appropriate.
1370
d32e47af
LM
13712012-08-05 Lawrence Mitchell <wence@gmx.li>
1372
1373 * search.c (Freplace_match): Treat \? in the replacement text
1374 literally (Bug#8161).
1375
e5d9c0d1
CY
13762012-08-05 Chong Yidong <cyd@gnu.org>
1377
1378 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
1379 * frame.c (Vdelete_frame_functions):
1380 * emacs.c (Vkill_emacs_hook): Doc fix.
1381
8da0576b
EZ
13822012-08-04 Eli Zaretskii <eliz@gnu.org>
1383
1384 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
1385 --with-x-toolkit=no builds.
1386 Reported by Carsten Mattner <carstenmattner@gmail.com>.
1387
02676e5d
CY
13882012-08-04 Chong Yidong <cyd@gnu.org>
1389
1390 * syntax.c (Fmodify_syntax_entry): Doc fix.
1391
97147da9
EZ
13922012-08-04 Eli Zaretskii <eliz@gnu.org>
1393
76151e2c
EZ
1394 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
1395 * w32.c (init_environment): Change the default values of many
1396 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
1397 them into environment when they were not already defined.
1398 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 1399 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
1400 (check_windows_init_file): Now external, not static.
1401 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
1402 called when Vload_path is already set up.
1403
1404 * w32.h (check_windows_init_file): Add prototype.
1405
1406 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
1407 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
1408 compatibility with Posix platforms.
1409 (main): Move the call to check_windows_init_file to here from
1410 w32.c.
1411 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
1412 any, in the DEFALT argument into the root of the Emacs build or
1413 installation tree, as appropriate.
1414
1415 * callproc.c (init_callproc_1): Call decode_env_path instead of
1416 doing its equivalent by hand.
1417 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
1418 the code that sets Vexec_path run on MS-Windows.
1419
1420 * lread.c (init_lread): Add comments to #ifdef's.
1421
97147da9
EZ
1422 * msdos.c (dos_set_window_size, IT_update_begin)
1423 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
1424 instead of direct references.
1425
185ee146
PE
14262012-08-04 Paul Eggert <eggert@cs.ucla.edu>
1427
1428 Export DEFAULT_REHASH_* to GDB.
1429 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
1430 Now constants, not macros.
1431
8834c57a
PE
14322012-08-03 Paul Eggert <eggert@cs.ucla.edu>
1433
98c6f1e3
PE
1434 Remove unnecessary casts involving pointers.
1435 These casts are no longer needed now that we assume C89 or later,
1436 since they involve casting to or from void *.
1437 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
1438 (make_pure_float, make_pure_vector):
1439 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
1440 * macros.c (Fstart_kbd_macro):
1441 * menu.c (find_and_return_menu_selection):
1442 * minibuf.c (read_minibuf_noninteractive):
1443 * sysdep.c (closedir):
1444 * xdisp.c (x_produce_glyphs):
1445 * xfaces.c (compare_fonts_by_sort_order):
1446 * xfns.c (x_real_positions, select_visual):
1447 * xselect.c (x_stop_queuing_selection_requests)
1448 (x_get_window_property, x_get_window_property_as_lisp_data):
1449 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
1450 Remove unnecessary pointer casts.
1451 * alloc.c (record_xmalloc): New function.
1452 * lisp.h (record_xmalloc): New decl.
1453 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
1454 more like a function. This is because the pointer cast is not
1455 needed. All uses changed.
1456 * print.c (print_string, print_error_message): Avoid length recalc.
1457
8834c57a
PE
1458 Improve fix for macroexp crash with debugging (Bug#12118).
1459 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
1460 ARRAY_MARK_FLAG when checking subscripts, because ASET is
1461 not supposed to be invoked from the garbage collector.
1462 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
1463 (gc_aset): New function, which is like ASET but can be
1464 used in the garbage collector.
1465 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1466 (set_hash_index): Use it instead of ASET.
1467
6dad7178
EZ
14682012-08-03 Eli Zaretskii <eliz@gnu.org>
1469
1470 Support symlinks on latest versions of MS-Windows.
1471 * w32.c: Include winioctl.h and aclapi.h.
1472 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
1473 (revert_to_self): Forward declarations of static functions.
1474 <static BOOL g_b_init_get_security_info>:
1475 <g_b_init_create_symbolic_link>: New static flags.
1476 (globals_of_w32): Initialize them to zero.
1477 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
1478 (map_w32_filename): Improve commentary. Simplify switch.
1479 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
1480 headers (most versions of MinGW w32api don't).
1481 (get_security_info, create_symbolic_link)
1482 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
1483 New functions.
1484 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
1485 in the argument file name.
1486 (sys_access): Call unc_volume_file_attributes only if
1487 GetFileAttributes fails with network-related error codes.
1488 (sys_rename): Diagnose renaming of a symlink when the user doesn't
1489 have the required privileges.
14ae4239 1490 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
1491 get_file_security_desc.
1492 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
1493 with addition of handling of symlinks and support for 'lstat'.
1494 If possible, get file's attributes and security information by
6dad7178
EZ
1495 handle, not by name. Produce S_IFLNK bit for symlinks, when
1496 called from 'lstat'.
1497 (stat, lstat): New functions, call 'stat_worker'.
1498 (symlink, readlink, careadlinkat): Rewritten to create and resolve
1499 symlinks when the underlying filesystem supports them.
1500
f162bcc3
PE
15012012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1502
79ea6c20
PE
1503 Fix macroexp crash on Windows with debugging (Bug#12118).
1504 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
1505 checking subscripts; problem introduced with the recent
1506 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
1507 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
1508 since it's used in non-static inline functions now.
1509
c0ce93fd
PE
1510 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
1511 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 1512
f162bcc3
PE
1513 Use C99-style 'extern inline' if available.
1514 * buffer.h (BUFFER_INLINE):
1515 * category.h (CATEGORY_INLINE):
1516 * character.h (CHARACTER_INLINE):
1517 * charset.h (CHARSET_INLINE):
1518 * composite.h (COMPOSITE_INLINE):
1519 * dispextern.h (DISPEXTERN_INLINE):
1520 * lisp.h (LISP_INLINE):
1521 * systime.h (SYSTIME_INLINE):
1522 New macro, replacing 'static inline' in this header.
1523 * buffer.h, category.h, character.h, charset.h, composite.h:
1524 * dispextern.h, lisp.h, systime.h:
1525 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1526 * alloc.c (LISP_INLINE):
1527 * buffer.c (BUFFER_INLINE):
1528 * category.c (CATEGORY_INLINE):
1529 * character.c (CHARACTER_INLINE):
1530 * charset.c (CHARSET_INLINE):
1531 * composite.c (COMPOSITE_INLINE):
1532 * dispnew.c (DISPEXTERN_INLINE):
1533 * sysdep.c (SYSTIME_INLINE):
1534 Define to EXTERN_INLINE, so that the corresponding functions
1535 are compiled into code.
1536 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
1537 (INLINE_HEADER_END): New macros.
1538 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
1539 since it's used in non-static inline functions now.
a8333d03 1540 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 1541
837b365b
GM
15422012-08-02 Glenn Morris <rgm@gnu.org>
1543
d66b744d
GM
1544 * s/: Remove empty directory.
1545
837b365b
GM
1546 * s/ms-w32.h: Move to ../nt/inc.
1547 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
1548 Update for new ms-w32.h location.
1549
13294f95
PE
15502012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1551
1552 Port to Solaris 8.
1553 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
1554
90df0db3
GM
15552012-08-02 Glenn Morris <rgm@gnu.org>
1556
1557 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
1558 hard-coding the path separator.
1559
4939150c
PE
15602012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
1563 This how ASET and AREF are supposed to work, and makes
1564 it easier to think about future improvements. See
1565 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
1566 * charset.h (set_charset_attr): New function.
1567 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
1568 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
1569 (aref_addr): New function. All uses of &AREF(...) changed.
1570 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1571 (set_hash_index): New functions. All lvalue-style uses of
1572 HASH_KEY etc. changed.
1573 * keyboard.c (set_prop): New function. All lvalue-style uses
1574 of PROP changed.
1575
947b2afd
AA
15762012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
1577
1578 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
1579 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1580 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
1581 * nsfns.m (ns_set_name_as_filename): Likewise.
1582 * nsmenu.m (ns_update_menubar): Likewise.
1583 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
1584
4f5d0325
EZ
15852012-08-01 Eli Zaretskii <eliz@gnu.org>
1586
2008beae
EZ
1587 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
1588 Adapt to latest changes in field names of the corresponding Lisp
288479f6 1589 objects.
2008beae 1590
4f5d0325
EZ
1591 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
1592
fe3cc771
GM
15932012-08-01 Glenn Morris <rgm@gnu.org>
1594
1595 * s/msdos.h: Remove file.
1596 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
1597 * Makefile.in (S_FILE): Remove.
1598 (config_h): Remove S_FILE.
1599
c90acc54
JB
16002012-08-01 Juanma Barranquero <lekktu@gmail.com>
1601
1602 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
1603 Remove; moved to nt/config.nt.
1604
d8a05828
DA
16052012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1606
1607 Use INTERNAL_FIELD for conses and overlays.
1608 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
1609 Remove obsolete comment.
1610 (MVAR): New macro.
1611 (struct Lisp_Overlay): Use INTERNAL_FIELD.
1612 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
1613
8271d590
DA
16142012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1615
1616 Use INTERNAL_FIELD for symbols.
1617 * lisp.h (SVAR): New macro. Adjust users.
1618 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
1619 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
1620
3193acd2
DA
16212012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1622
1623 Use INTERNAL_FIELD for processes.
1624 * process.h (PVAR): New macro. Adjust style.
1625 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
1626 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
1627
3a45383a
DA
16282012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1629
1630 Use INTERNAL_FIELD for windows.
1631 * window.h (WVAR): New macro.
1632 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
1633 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1634 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1635 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
1636 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
1637 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1638
c1dbc63c
PE
16392012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1640
1641 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
1642
5c0c0e8a
GM
16432012-08-01 Glenn Morris <rgm@gnu.org>
1644
1645 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
1646 Move to configure.ac.
1647
552a99b4
JB
16482012-08-01 Juanma Barranquero <lekktu@gmail.com>
1649
1650 * makefile.w32-in (CONFIG_H): Update dependencies.
1651 (CONF_POST_H): New macro.
1652
1653 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
1654
8d8e2dfe
GM
16552012-07-31 Glenn Morris <rgm@gnu.org>
1656
bc96620a
GM
1657 * Makefile.in (S_FILE): No longer set by configure.
1658
476b1b2d
GM
1659 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
1660 is available.
1661 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
1662
b2c7a106
GM
1663 * process.h (NULL_DEVICE):
1664 * emacs.c (SEPCHAR):
1665 * editfns.c (USER_FULL_NAME): Let configure set them.
1666
d53d062a
GM
1667 * s/README, s/template.h: Remove files.
1668
4515017f
GM
1669 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
1670
8d8e2dfe
GM
1671 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
1672 Move to configure.ac.
1673
5b20b3cc
EZ
16742012-07-31 Eli Zaretskii <eliz@gnu.org>
1675
1e0afd9a
EZ
1676 * .gdbinit (xframe): Adapt to introduction of FVAR and the
1677 resulting renaming of 'struct frame' members.
1678
5b20b3cc
EZ
1679 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
1680
1681 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
1682 after introduction of FVAR.
1683
f1310128
JD
16842012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1685
79e721e0
JD
1686 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
1687
1688 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
1689 instead of compositeToPoint.
1690 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
1691
8d7c7eed 1692 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 1693
e34f7f79
DA
16942012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1695
1696 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
1697 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 1698 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
1699 (BVAR): Change to use INTERNAL_FIELD.
1700 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
1701 (KVAR): Change to use INTERNAL_FIELD.
1702 * frame.h (FVAR): New macro.
1703 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
1704 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
1705 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
1706 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
1707 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1708
c09bfb2f
DA
17092012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1710
1711 Miscellaneous fixes for non-default X toolkits.
1712 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
1713 * xterm.c (x_frame_of_widget): Remove redundant prototype.
1714 Move under #ifdef USE_LUCID.
1715 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
1716 definition and usage to avoid warnings.
1717
14c114ae
JD
17182012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1719
1720 * nsterm.m (openFiles): Fix previous checkin.
1721
3bd21e82
PE
17222012-07-31 Paul Eggert <eggert@cs.ucla.edu>
1723
1724 * indent.c (compute_motion): Remove unused local.
1725
c1529ded
GM
17262012-07-31 Glenn Morris <rgm@gnu.org>
1727
400d5621
GM
1728 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
1729
268e2432
GM
1730 * conf_post.h [USG5_4]:
1731 Move remaining contents of s/usg5-4-common.h here.
1732 * s/usg5-4-common.h: Remove file.
1733
7552f3ee
GM
1734 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
1735 * s/irix6-5.h: Remove file.
1736
6a381852
GM
1737 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
1738 * s/darwin.h: Remove file.
1739
c1529ded
GM
1740 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
1741 * s/hpux10-20.h: Remove file, which is now empty.
1742
b429a4ee
GM
17432012-07-30 Glenn Morris <rgm@gnu.org>
1744
1745 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
1746 * Makefile.in (config_h): Add conf_post.h.
1747 * makefile.w32-in (CONFIG_H): Add conf_post.h.
1748
adff3182
JD
17492012-07-30 Jan Djärv <jan.h.d@swipnet.se>
1750
1751 * nsterm.m (ns_do_open_file): New variable.
b9031d69 1752 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
1753 (openFile, openTempFile, openFileWithoutUI, openFiles):
1754 Open files only if ns_do_open_file.
adff3182 1755
c32af1e4
PE
17562012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1757
7393bcbb
PE
1758 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
1759 This no-op macro hasn't been needed for many years.
1760 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
1761
c32af1e4
PE
1762 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
1763 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
1764 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
1765 gdb_make_enums_visible.
1766 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
1767 (DIRECTORY_SEP): Now a constant, not a macro.
1768
302fc036
EZ
17692012-07-30 Eli Zaretskii <eliz@gnu.org>
1770
1771 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
1772 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
1773
1774 * w32term.c <w32_keyboard_codepage>: Renamed from
1775 keyboard_codepage and now external. All users changed.
1776
1777 * w32term.h: Add declaration of w32_keyboard_codepage.
1778
1779 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
1780 the codepage to translate keys to Unicode. If this argument is
1781 -1, use the value returned by GetConsoleCP. All callers changed.
1782
88fb40b4
PE
17832012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1784
0aee6912
PE
1785 Update .PHONY listings in makefiles.
1786 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
1787 bootstrap-clean, distclean, maintainer-clean, versioclean,
1788 extraclean, frc.
1789
88fb40b4
PE
1790 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
1791 This is a bit clearer. Fix some commentary typos.
1792
0a763bd1
GM
17932012-07-30 Glenn Morris <rgm@gnu.org>
1794
32bac6d6
GM
1795 * s/netbsd.h: Let configure include signal.h if needed.
1796 Remove file, which is now empty.
1797
b65e7c46
GM
1798 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
1799 Let configure set them.
1800 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
1801 No more need to undefine.
0a763bd1 1802
169304bd
AS
18032012-07-30 Andreas Schwab <schwab@linux-m68k.org>
1804
1805 * keymap.c (Fkey_description): Don't remove 0x80 bit from
1806 non-single-byte char when adding meta modifier. (Bug#12090)
1807
6cd7a139
DA
18082012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1809
1810 Convert safe_call to use variable number of arguments.
1811 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
1812 (safe_call2): Fix comment.
1813 * lisp.h (safe_call): Adjust prototype.
1814 * coding.c (encode_coding_object): Change to use safe_call2.
1815 * xfaces.c (merge_face_heights): Change to use safe_call1.
1816
d34d6ffc
GM
18172012-07-30 Glenn Morris <rgm@gnu.org>
1818
7b8a48e4 1819 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 1820 does that unconditionally. Remove file, which is now empty.
7b8a48e4 1821
d34d6ffc
GM
1822 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
1823 Remove empty files.
1824
03a660a6
PE
18252012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1826
1827 Export to GDB most of lisp.h's remaining object-like macros.
1828 * lisp.h (min, max): Move earlier, because they're used earlier now.
1829 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
1830 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
1831 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
1832 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
1833 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
1834 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
1835 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
1836 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
1837 Now constants, for GDB. They need not be macros.
1838 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
1839 Now constants, for GDB, as well as macros, for static initializers.
1840 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
1841 Move to after the definition of struct Lisp_Char_Table,
1842 since the former now needs that type defined.
1843 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
1844 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
1845 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
1846 New enums, for gdb_make_enums_visible.
1847 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 1848 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
1849 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
1850 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
1851 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
1852 enum maxargs, enum MAX_ALLOCA.
1853 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
1854 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
1855 no longer needed, now that they are done in lisp.h.
1856
e499d0ee
DA
18572012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1858
1859 Cleanup string bytes checking.
1860 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
1861 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
1862 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
1863 (check_sblock, compact_small_strings): Simplify.
1864
d5040d2d
PE
18652012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
1868 These macros are confusing and no longer need to be defined, as
1869 the enum values now suffice. All uses replaced with definiens.
1870 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
1871
7f259ae6
JB
18722012-07-29 Juanma Barranquero <lekktu@gmail.com>
1873
1874 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
1875 ($(BLD)/w32console.$(O)): Update dependencies.
1876
7e63e0c3
DA
18772012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1878
1879 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
1880 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
1881 time. Adjust users.
1882 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
1883
ffd817eb
JD
18842012-07-29 Jan Djärv <jan.h.d@swipnet.se>
1885
1886 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
1887 setting sitelisp (Bug#12010).
1888
417a7a0e
EZ
18892012-07-29 Eli Zaretskii <eliz@gnu.org>
1890
14ae4239 1891 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
1892
1893 * w32heap.c (cache_system_info):
1894 * w32.c (sys_rename):
1895 * w32proc.c (find_child_console, sys_kill): All users changed.
1896
387d4d92
PE
18972012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1898
1899 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
1900
55a6cca6
EZ
19012012-07-29 Eli Zaretskii <eliz@gnu.org>
1902
1903 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
1904
dbcf001c
DA
19052012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1906
1907 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1908 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1909 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1910
e2688e4a
DA
19112012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1912
1913 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1914 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1915 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1916 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1917 (replace_range, replace_range_2, del_range_2): Change to eassert.
1918 * marker.c (byte_char_debug_check): Adjust style.
1919
b46a6a83
PE
19202012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1921
1922 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1923 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1924 long-ago-commented-out code that talks about "WIN32".
1925 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1926 All uses changed.
1927
e32a5799
PE
19282012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1929
1930 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1931 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1932 Simplify by using alignof.
1933 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1934 * lisp.h: Include <stdalign.h>.
1935 (GCALIGNMENT): New macro and constant.
1936 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1937 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1938 (stdalign): New macro, if not already defined.
1939
df81cd29
EZ
19402012-07-28 Eli Zaretskii <eliz@gnu.org>
1941
01bd1b0d
EZ
1942 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1943 * w32inevt.c: Include w32inevt.h.
1944 (w32_read_console_input): New inline function, calls either
1945 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1946 w32_console_unicode_input.
1947 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1948 (w32_kbd_patch_key, key_event): Use the codepage returned by
1949 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1950 (key_event): use uChar.UnicodeChar only if
1951 w32_console_unicode_input is non-zero.
1952
1953 * w32console.c: Include w32heap.h.
1954 <w32_console_unicode_input>: New global variable.
1955 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1956 family of Windows, zero otherwise.
1957
1958 * w32inevt.h: Declare w32_console_unicode_input.
1959
df81cd29
EZ
1960 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1961 --without-x. (Bug#11742)
1962
c20fdd9e
PE
19632012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1964
1965 Adjust GDB to reflect pvec_type changes (Bug#12036).
1966 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1967 2012-07-04 changes to pseudovector representation.
1968 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1969
32770973 19702012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1971
1972 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1973 bus address.
1974 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1975
3438fe21
EZ
19762012-07-27 Eli Zaretskii <eliz@gnu.org>
1977
bcfbc9de
EZ
1978 * alloc.c (listn): Fix the order the arguments are consed onto the
1979 list.
1980
3438fe21
EZ
1981 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1982 enumeration constants, as PURE and HEAP are too general, and clash
1983 with other headers and sources, such as gmalloc.c and the
1984 MS-Windows system headers. All users changed.
1985
eeaea515
DA
19862012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1987
1988 Revert last save_excursion_save and save_excursion_restore changes.
1989 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1990 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1991
073c88c2
DA
19922012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1993
1994 Fix recently-introduced typos in Windows port.
1995 Reported by Martin Rudalics <rudalics@gmx.at>.
1996 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1997 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1998
4706125e
PE
19992012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 Improve GDB symbol export (Bug#12036).
2002 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
2003 arms of an 'if', not using conditional expressions; otherwise GDB
2004 complains about the types in the unevaluated arm when the argument
2005 is an integer literal.
2006 (xgetint): Simplify expression.
2007 * alloc.c (gdb_make_enums_visible): New constant. This ports to
2008 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
2009 Zaretskii in <http://bugs.gnu.org/12036#13>.
2010 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
2011 needed now that we have gdb_make_enums_visible.
2012 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
2013 (enum enum_USE_LSB_TAG):
2014 New enum types, packaging up enums that need to be exported to GDB.
2015
694b6c97
DA
20162012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2017
2018 Utility function to make a list from specified amount of objects.
2019 * lisp.h (enum constype): New datatype.
2020 (listn): New prototype.
2021 * alloc.c (listn): New function.
2022 (Fmemory_use_count, syms_of_alloc): Use it.
2023 * buffer.c (syms_of_buffer): Likewise.
2024 * callint.c (syms_of_callint): Likewise.
2025 * charset.c (define_charset_internal): Likewise.
2026 * coding.c (syms_of_coding): Likewise.
2027 * keymap.c (syms_of_keymap): Likewise.
2028 * search.c (syms_of_search): Likewise.
2029 * syntax.c (syms_of_syntax): Likewise.
2030 * w32.c (init_environment): Likewise.
2031 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
2032 * xdisp.c (syms_of_xdisp): Likewise.
2033 * xfns.c (syms_of_xfns): Likewise.
2034
6195f384
DA
20352012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2036
2037 Fast save_excursion_save and save_excursion_restore.
2038 * lisp.h (struct Lisp_Excursion): New data type.
2039 (PVEC_EXCURSION): New pseudovector type.
2040 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
2041 to deal with it. Adjust comments.
2042 (init_marker, attach_marker): New prototype.
2043 (unchain_marker): Adjust prototype.
2044 * marker.c (attach_marker): Change to global.
2045 (init_marker): New function.
2046 * alloc.c (Fmake_marker, build_marker): Use it.
2047 (build_marker): More easserts.
2048 (mark_object): Handle struct Lisp_Excursion.
2049 * editfns.c (save_excursion_save, save_excursion_restore):
2050 Reimplement to use struct Lisp_Excursion. Add comments.
2051
5eceb8fb
PE
20522012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 Fix export of symbols to GDB (Bug#12036).
2055 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
2056 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
2057 emacs.c, as this is a more-suitable home. Had this been done earlier
2058 the fix for 12036 would have avoided some of the problems noted in
2059 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
2060 would have been more obvious.
562157c8
PE
2061 * emacs.c: Do not include <verify.h>; no longer needed.
2062 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
2063 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
2064 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2065 Remove; now done in lisp.h.
2066 * lisp.h (PUBLISH_TO_GDB): New macro.
2067 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
2068 (DATA_SEG_BITS): Use it.
2069 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
2070 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
2071 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
2072 not be usable in #if. This simplifies things.
2073
d6749401
JB
20742012-07-26 Juanma Barranquero <lekktu@gmail.com>
2075
2076 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
2077
1781b9e9
PE
20782012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2079
d89518db 2080 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
2081 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
2082 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
2083 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
2084 Adjust to changes in lisp.h and emacs.c, by using
2085 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
2086 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
2087 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
2088 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
2089 instead of gdb_valbits.
2090 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
2091 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
2092 instead of gdb_array_mark_flag.
2093 (xboolvector): Get size from $->size, not $->header.size.
2094 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
2095 (xreload, hook-run, hookpost-run): Remove.
2096 * emacs.c: Include <verify.h>.
2097 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
2098 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
2099 Remove.
2100 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
2101 (gdb_USE_LSB_TAG): New enum constants.
2102 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2103 Also define these as enum constants, so they're visible to GDB.
2104 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
2105 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
2106 as constants, so they're visible to GDB.
2107 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
2108 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
2109 Now enum constants, not macros, so they're visible to GDB.
2110 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
2111 more convenient now. All uses changed.
2112 (VALMASK) [USE_LSB_TAG]: Also define in this case.
2113 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
2114
3628596a
DA
21152012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
2116
2117 Explicitly free restriction data that are not needed anymore.
2118 * editfns.c (save_restriction_restore): Free restriction data.
2119
7abaf5cc
SM
21202012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2121
2122 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
2123 add argument, tune behavior, and adjust all callers.
2124
71f88e00
PE
21252012-07-25 Paul Eggert <eggert@cs.ucla.edu>
2126
2127 Use typedef for EMACS_INT, EMACS_UINT.
2128 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
2129 than macros. This simplifies debugging in the usual case, since
2130 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
2131 and it allows expressions involving EMACS_INT casts.
2132 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
2133
57ec3034
JD
21342012-07-25 Jan Djärv <jan.h.d@swipnet.se>
2135
2136 * nsterm.m (ns_read_socket): Return early if there is a modal
2137 window (Bug#12043).
2138
8137e7b3
MR
21392012-07-25 Martin Rudalics <rudalics@gmx.at>
2140
2141 * frame.c (Fredirect_frame_focus): In doc-string don't mention
2142 that FOCUS-FRAME can be omitted.
2143
04e9897c
DA
21442012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
2145
2146 Adjust buffer text indirection counters at the end of Fkill_buffer.
2147 * buffer.c (Fkill_buffer): Adjust indirection counters when the
2148 buffer is definitely dead. This should really fix an issue reported
2149 by Christoph Scholtes again. (Bug#12007).
2150 (init_buffer_once): Initialize indirection counters of
2151 buffer_defaults and buffer_local_symbols (for sanity and safety).
2152
8a0484e1
EZ
21532012-07-24 Eli Zaretskii <eliz@gnu.org>
2154
2155 * xdisp.c (init_iterator): Don't compute dimensions of truncation
2156 and continuation glyphs on tooltip frames, leave them at zero.
2157 Avoids continued lines in tooltips. (Bug#11832)
2158
fa691a83
DA
21592012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
2160
2161 Simplify copy_overlay.
04e9897c 2162 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
2163 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
2164
436bc8e0
EZ
21652012-07-23 Eli Zaretskii <eliz@gnu.org>
2166
2167 * print.c (print_object): Don't crash when a frame's name is nil
2168 or invalid. (Bug#12025)
2169
2170 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
2171 it signals an error when a tooltip frame is being created.
2172
d7a7fda3
DA
21732012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
2174
2175 Cleanup miscellaneous objects allocation and initialization.
2176 * alloc.c (allocate_misc): Change to static. Add argument to
2177 specify the subtype. Adjust comment and users.
2178 (build_overlay): New function.
2179 * buffer.c (copy_overlays, Fmake_overlay): Use it.
2180 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
2181 (allocate_misc): Remove prototype.
2182 (build_overlay): Add prototype.
2183
21842012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
2185
2186 Swap buffer text indirection counters in Fbuffer_swap_text.
2187 * buffer.c (Fbuffer_swap_text): Swap indirections too.
2188 This avoids crash reported by Christoph Scholtes at
2189 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
2190
9d7fa573
JD
21912012-07-22 Jan Djärv <jan.h.d@swipnet.se>
2192
2193 * nsmenu.m (Popdown_data): New struct.
2194 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
2195 free Popdown_data.
2196 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
2197 (initWithContentRect): Make imgView and contentView non-static
2198 and autorelease them. Also autorelease img and matrix (Bug#12005).
2199 (dealloc): Remove (Bug#12005).
2200
0dd6d66d
DA
22012012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2202
2203 Adjust consing_since_gc when objects are explicitly freed.
2204 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
2205 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
2206 (free_cons, free_misc): Subtract object size from consing_since_gc.
2207
d36d71df
DA
22082012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2209
2210 Simplify and cleanup markers positioning code.
2211 * marker.c (attach_marker): More useful eassert.
2212 (live_buffer, set_marker_internal): New function.
2213 (Fset_marker, set_marker_restricted): Use set_marker_internal.
2214 (set_marker_both, set_marker_restricted_both): Use live_buffer.
2215
fb9ea40f
PE
22162012-07-22 Paul Eggert <eggert@cs.ucla.edu>
2217
2218 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
2219 as it's limited by the amount of memory, not by INT_MAX.
2220
2d5c5f7d
EZ
22212012-07-21 Eli Zaretskii <eliz@gnu.org>
2222
07fb592e
EZ
2223 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
2224 in special-event-map. See the discussion at
2225 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
2226 for the reasons.
2227
37a9eac8 2228 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
2229 info.dwItemData. Fixes crashes on 64-bit Windows.
2230 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 2231
c4328746
JD
22322012-07-21 Jan Djärv <jan.h.d@swipnet.se>
2233
2234 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 2235 (conversationIdentifier): Return value is NSInteger.
784051c4 2236 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 2237
6e5d1c12
CY
22382012-07-21 Chong Yidong <cyd@gnu.org>
2239
2240 * window.c (decode_any_window): Signal an error if the window is
2241 on a dead frame (Bug#11984).
2242
9928463d
DA
22432012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2244
2245 Add indirection counting to speed up Fkill_buffer.
2246 * buffer.h (struct buffer): New member.
2247 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
2248 (Fmake_indirect_buffer): Set indirection counter to -1, increment
2249 base buffer indirection counter.
2250 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
2251 (Fkill_buffer): Adjust indirection counters as needed, don't walk
2252 through buffer list if indirection counter is 0.
2253
f8643a6b
DA
22542012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2255
2256 Extend the value returned by Fgarbage_collect with heap statistics.
2257 * alloc.c (Qheap): New symbol.
2258 (syms_of_alloc): DEFSYM it.
2259 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
2260 (Fmemory_free): Remove.
2261 (syms_of_alloc): Don't defsubr it.
2262 * buffer.c (Fcompact_buffer): Remove.
2263 (syms_of_buffer): Don't defsubr it.
2264
dac616ff
DA
22652012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2266
2267 Make maybe_gc inline.
2268 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
2269 * lisp.h (consing_since_gc, gc_relative_threshold)
2270 (memory_full_cons_threshold): Revert declaration.
2271 (maybe_gc): Remove prototype, define as inline.
2272 * alloc.c: Remove old commented-out code.
2273 (consing_since_gc, gc_relative_threshold)
2274 (memory_full_cons_threshold): Revert to global.
2275 (maybe_gc): Remove.
2276
d7ea76b4
DA
22772012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2278
2279 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
2280 * lisp.h (build_unibyte_string): New function.
2281 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
2282 * sysdep.c, w32fns.c, xfns.c: Use it.
2283 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
2284 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
2285 Adjust users accordingly.
2286 * font.h (font_open_by_name): Adjust prototype.
2287
765e61e3
DA
22882012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2289
2290 Cleanup calls to Fgarbage_collect.
2291 * lisp.h (maybe_gc): New prototype.
2292 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2293 Remove declarations.
2294 * alloc.c (maybe_gc): New function.
2295 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2296 Make them static.
2297 * bytecode.c (MAYBE_GC): Use maybe_gc.
2298 * eval.c (eval_sub, Ffuncall): Likewise.
2299 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
2300 to avoid dependency from auto-save feature.
2301
52b852c7
PE
23022012-07-19 Paul Eggert <eggert@cs.ucla.edu>
2303
2304 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
2305 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
2306 'for_each_per_buffer_object_at'.
2307 All uses changed. It's better to use upper-case for macros that
2308 cannot be implemented as functions, to give the reader a clue
2309 that they're special.
2310
5db81e33
SM
23112012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
2312
2313 * alloc.c (Fgarbage_collect): Tweak docstring.
2314
5b835e1d
DA
23152012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2316
2317 Tweak the value returned from Fgarbage_collect again.
2318 * alloc.c (Fgarbage_collect): New return value, as confirmed in
2319 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
2320 Adjust documentation.
2321 (total_vector_bytes): Rename to total_vector_slots, adjust
2322 accounting.
2323 (total_free_vector_bytes): Rename to total_free_vector_slots,
2324 adjust accounting.
2325 (Qstring_bytes, Qvector_slots): New symbols.
2326 (syms_of_alloc): DEFSYM them.
2327
9cd47b72
DA
23282012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2329
2330 Buffer compaction primitive which may be used from Lisp.
2331 * buffer.c (compact_buffer, Fcompact_buffer): New function.
2332 (syms_of_buffer): Register Fcompact_buffer.
2333 * alloc.c (Fgarbage_collect): Use compact_buffer.
2334 * buffer.h (compact_buffer): New prototype.
2335 (struct buffer_text): New member.
2336
d17337e5
DA
23372012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2338
2339 New macro to iterate over all buffers, miscellaneous cleanups.
2340 * lisp.h (all_buffers): Remove declaration.
2341 * buffer.h (all_buffers): Add declaration, with comment.
2342 (for_each_buffer): New macro.
2343 * alloc.c (Fgarbage_collect, mark_object): Use it.
2344 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
2345 (init_buffer): Likewise.
2346 * data.c (Fset_default): Likewise.
2347 * coding.c (code_conversion_restore): Remove redundant check
2348 for dead buffer.
2349 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
2350
60cfd278
AS
23512012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2352
2353 Fix bug that created negative-length intervals.
2354 * intervals.c (merge_interval_right, merge_interval_left):
2355 Do not zero out this interval if it is absorbed by its children,
2356 as this interval's total length doesn't change in that case. See
2357 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
2358
d06714cb
PE
23592012-07-18 Paul Eggert <eggert@cs.ucla.edu>
2360
83713154
PE
2361 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
2362 when invoking (make-bool-vector N t) and N is a positive
2363 multiple of 8 -- the last 8 bits were mistakenly cleared.
2364
d06714cb
PE
2365 Remove some struct layout assumptions in bool vectors.
2366 * alloc.c (bool_header_size): New constant.
2367 (header_size, word_size): Move earlier, as they're now used earlier.
2368 Use 'word_size' in a few more places, where it's appropriate.
2369 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
2370 padding before the data member of a bool vector.
2371 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
2372 than doing the check by hand with an abort ().
2373
464d5a5e
SM
23742012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2375
5fbc0409
SM
2376 * eval.c (Fdefvar): Don't check constants since we only set the var if
2377 it's not yet defined anyway (bug#11904).
2378
464d5a5e
SM
2379 * lisp.h (last_undo_boundary): Declare new var.
2380 * keyboard.c (command_loop_1): Set it.
2381 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
2382 were auto-added by the command loop (bug#11774).
2383
8dc2e44a
AS
23842012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2385
2386 * w32font.c (Qsymbol): Remove local definition.
2387 (syms_of_w32font): Don't DEFSYM it.
2388
169925ec
DA
23892012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2390
2391 Fix sweep_vectors to handle large bool vectors correctly.
2392 * alloc.c (sweep_vectors): Account total_vector_bytes for
2393 bool vectors larger than VBLOCK_BYTES_MAX.
2394
5fbfb018
CY
23952012-07-18 Chong Yidong <cyd@gnu.org>
2396
2397 * frame.c (x_set_frame_parameters): Revert bogus change introduced
2398 in 2012-05-25 commit by Paul Eggert (Bug#11738).
2399
3ab6e069
DA
24002012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2401
2402 Return more descriptive data from Fgarbage_collect.
2403 Suggested by Stefan Monnier in
2404 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
2405 * alloc.c (bounded_number): New function.
2406 (total_buffers, total_vectors): New variable.
2407 (total_string_size): Rename to total_string_bytes, adjust users.
2408 (total_vector_size): Rename to total_vector_bytes, adjust users.
2409 (sweep_vectors): Account total_vectors and total_vector_bytes.
2410 (Fgarbage_collect): New return value. Adjust documentation.
2411 (gc_sweep): Account total_buffers.
2412 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
2413 (VECTOR_SIZE): Remove.
2414 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
2415 (Qinterval, Qmisc): New symbols.
2416 (syms_of_data): Initialize them.
2417 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
2418 (Qcons, Qbuffer): New declarations.
2419
6d02fe5b
PE
24202012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2421
2422 * alloc.c (Fmemory_free): Account for memory-free's own storage.
2423 Round up, not down. Improve doc.
2424
b7ffe040
DA
24252012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2426
2427 Restore old code in allocate_string_data to avoid Faset breakage.
2428 Reported by Julien Danjou <julien@danjou.info> in
2429 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
2430 * alloc.c (allocate_string_data): Restore old code with minor
2431 adjustments, fix comment to explain this subtle issue.
2432
4dc7c8d5
SM
24332012-07-17 Eli Zaretskii <eliz@gnu.org>
2434
2435 Remove FILE_SYSTEM_CASE.
2436 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
2437
2438 * fileio.c (FILE_SYSTEM_CASE): Don't define.
2439 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
2440 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
2441 call-process-region passes it through expand-file-name.
2442
2443 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
2444
24452012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2446
2447 Fix crash when creating indirect buffer (Bug#11917)
2448 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
2449 Don't handle unbound variables specially if non-zero.
2450 (Fbuffer_local_variables): Pass zero.
2451 (clone_per_buffer_values): Pass non-zero.
2452
24532012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2454
2455 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
2456 to make the loop interruptible.
2457
24582012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2459
2460 * gnutls.c (emacs_gnutls_handshake): Only retry if
2461 GNUTLS_E_INTERRUPTED.
2462
cce7fefc
DA
24632012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2464
2465 Cleanup and convert miscellaneous checks to eassert.
2466 * alloc.c (mark_interval): Fix comment, partially rephrase
2467 old comment from intervals.h (see below).
2468 * intervals.c (find_interval, adjust_intervals_for_insertion)
2469 (delete_interval, adjust_intervals_for_deletion)
2470 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
2471 Convert to eassert.
2472 (adjust_intervals_for_insertion, make_new_interval):
2473 Remove obsolete and unused code.
2474 * intervals.h (struct interval): Remove obsolete comment.
2475 * textprotp.c (erase_properties): Remove unused code.
2476 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
2477 (Fremove_list_of_text_properties): Convert to eassert.
2478
9ea10cc3
CY
24792012-07-17 Chong Yidong <cyd@gnu.org>
2480
2481 * editfns.c (Finsert_char): Doc fix.
2482
3900d5de
DA
24832012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2484
2485 Fix previous change to make Fmemory_free always accurate.
2486 * alloc.c (make_interval): Update total_free_intervals.
2487 (make_float): Likewise for total_free_floats.
2488 (free_cons, Fcons): Likewise for total_free_conses.
2489 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
2490 Likewise for total_free_vector_bytes.
2491 (Fmake_symbol): Likewise for total_free_symbols.
2492 (bytes_free): Remove.
2493
7098646f
DA
24942012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2495
2496 Simple free memory accounting feature.
2497 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
2498 (sweep_vectors): Accumulate size of free vectors.
2499 (Fgarbage_collect): Setup bytes_free.
2500 (Fmemory_free): New function.
2501 (syms_of_alloc): Register it.
2502
22657b40
DA
25032012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2504
2505 Cleanup overlays checking.
2506 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
2507 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
2508 eassert and OVERLAYP.
2509 (sort_overlays): Change to use OVERLAYP.
2510
ddfc8813
RK
25112012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
2512
2513 * editfns.c (Finsert_char): Make it interactive, and make the
2514 second arg optional. Copy interactive spec and docstring from
2515 ucs-insert.
2516
7c26cf3c
PE
25172012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2518
2519 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
2520 Unlike the other wrapped functions, fabs has an unspecified
2521 effect on errno.
2522
5d127af9
JD
25232012-07-16 Jan Djärv <jan.h.d@swipnet.se>
2524
2525 * nsterm.m (keyDown): Interpret flags without left/right bits
2526 as the left key (Bug#11670).
2527
6a0dd1d7
DA
25282012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2529
2530 Remove empty and useless init functions.
2531 * lisp.h (init_character_once, init_fns, init_image)
2532 (init_filelock, init_sound): Remove prototype.
2533 * character.c (init_character_once): Remove.
2534 * filelock.c (init_filelock): Likewise.
2535 * fns.c (init_fns): Likewise.
2536 * image.c (init_image): Likewise.
2537 * sound.c (init_sound): Likewise.
2538 * emacs.c (main): Adjust accordingly.
2539
7a6136fd
DA
25402012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2541
2542 * gtkutil.h: Tiny cleanups.
2543 (use_old_gtk_file_dialog): Remove useless declaration.
2544 (xg_uses_old_file_dialog): Add suggested const attribute.
2545
ce811ad9
EZ
25462012-07-15 Eli Zaretskii <eliz@gnu.org>
2547
2548 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
2549 (bidi_paragraph_init): Use it to limit search forward for a strong
2550 directional character in abnormally large paragraphs full of
2551 neutral or weak characters. (Bug#11943)
2552
c9adfeaa
SF
25532012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
2554
2555 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
2556 the toolbar (Bug#9451).
2557 (xg_make_tool_item): Give the widget event box a transparent
2558 background.
2559
fff62aa9
DA
25602012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2561
2562 Cleanup basic allocation variables and functions.
2563 * alloc.c (ignore_warnings, init_intervals, init_float)
2564 (init_cons, init_symbol, init_marker): Remove.
2565 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
2566 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
2567 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
2568 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
2569 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
2570 (staticidx, init_alloc_once, init_strings, free_ablock):
2571 Remove redundant initialization.
2572 * fns.c (init_weak_hash_tables): Remove.
2573 * lisp.h (init_weak_hash_tables): Remove prototype.
2574
9730daca
DA
25752012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2576
2577 Use zero_vector where appropriate.
2578 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
2579 accordingly.
2580 * lisp.h (zero_vector): New declaration.
2581 * font.c (null_vector): Remove.
2582 (syms_of_font): Remove initialization and staticpro.
2583 (font_list_entities, font_find_for_lface): Change to use zero_vector.
2584 * keymap.c (Faccessible_keymaps): Likewise.
2585
2e2d2a13
LL
25862012-07-15 Leo Liu <sdl.web@gmail.com>
2587
2588 * fringe.c: Fix typo in comments.
2589
cd276f6e
LL
25902012-07-14 Leo Liu <sdl.web@gmail.com>
2591
2592 * fringe.c: Add a new bitmap exclamation-mark.
2593
5a1131d9
EZ
25942012-07-14 Eli Zaretskii <eliz@gnu.org>
2595
2596 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
2597
2598 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
2599 (HAVE_MENUS): Don't define, defined by editing config.in with
2600 msdos/sed2v2.inp.
2601 (GMALLOC_INHIBIT_VALLOC): Don't define.
2602 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
2603
22e983b7
JB
26042012-07-14 Juanma Barranquero <lekktu@gmail.com>
2605
2606 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
2607
5b3f250f
GM
26082012-07-14 Glenn Morris <rgm@gnu.org>
2609
2610 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
2611 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
2612 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
2613
33d63ff4
GM
26142012-07-13 Glenn Morris <rgm@gnu.org>
2615
5b633342
GM
2616 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
2617
33d63ff4
GM
2618 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
2619 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
2620
b55b9f85
JD
26212012-07-13 Jan Djärv <jan.h.d@swipnet.se>
2622
0dc8cf50
JD
2623 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
2624 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
2625 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
2626 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
2627 where appropriate.
2628 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
2629 as boolean expression.
2630 (x_set_window_size): Remove unused variable toolbar.
2631 (ns_get_color_default, ns_mod_to_lisp): Remove.
2632 (ns_mouse_position): Remove unused variables xchar and ychar.
2633 (ns_compute_glyph_string_overhangs): Remove unused variable face.
2634 (ns_set_vertical_scroll_bar): Remove unused variable count.
2635 (ns_delete_terminal): Remove unused variable i.
2636 (ns_term_init): Remove unused variables r, g and b.
2637 (mouseDown): Remove unused variable window.
2638 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
2639 (initFrameFromEmacs): Remove unused variable vbextra.
2640 (mouseEntered): Remove unused variables p and dpyinfo.
2641 (mouseExited): Remove unused variables p and r.
2642 (ns_define_frame_cursor, ns_clear_frame_area)
2643 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
2644 (menuDown): Assign [sender tag] to variable and cast the variable.
2645
2646 * nsterm.h (menuDown): Add id as type to argument sender.
2647 (ns_display_info_for_name): Add Lisp_Object argument.
2648 (ns_term_init): Add Lisp_Object argument.
2649 (ns_map_event_to_object): Add void argument.
2650 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
2651 prototype with arguments and only declare if __OBJC__.
2652 (nxatoms_of_nsselect): Add void argument.
2653 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
2654 (ns_alloc_autorelease_pool): Add void argument.
2655 (ns_release_autorelease_pool): Add void* argument.
2656 (ns_get_defaults_value): Add const char* argument.
2657
2658 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
2659 (initFromContents): Use SSDATA where appropriate.
2660 (ns_update_menubar): Add braces to ambigous if-else.
2661 (initWithTitle): Put () around assignment in if statement.
2662 (ns_menu_show): Remove unused variables window and keymap.
2663 (update_frame_tool_bar): Remove unused variable selected_p.
2664 (initWithContentRect): Remove unused variable this_cmd_name.
2665
2666 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
2667 appropriate.
2668 (setXBMColor): Remove unused variable len.
2669 (setPixmapData): Put () around assignment in loop statement.
2670
2671 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
2672 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
2673 where appropriate.
2674 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
2675 around assignment in loop statement.
2676 (nsfont_open): Remove unused variable i.
2677 (nsfont_open): Remove unused variable len.
2678 (nsfont_draw): Remove unused variable cs.
2679
2680 * nsfns.m (x_set_icon_name, ns_set_name_internal)
2681 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
2682 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
2683 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
2684 (Fns_font_name, Fns_perform_service)
2685 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
2686 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
2687 (ns_set_name): Remove unused variable view.
2688 (x_set_menu_bar_lines): Remove unused variable olines.
2689 (x_set_tool_bar_lines): Remove unused variable root_window.
2690 (Fns_list_colors): Put () around assignment in while statement.
2691 (Fns_perform_service): Remove unused variable len.
2692 (Fns_display_usable_bounds): Remove unused variable top.
2693 (syms_of_nsfns): Remove unused variable i.
2694
b55b9f85
JD
2695 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
2696 memcpy (Bug#11907).
2697
ed9265fc 26982012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
2699
2700 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
2701 and free it with DestroyExceptionInfo (Bug#11558).
2702
ef099b57
JB
27032012-07-13 Juanma Barranquero <lekktu@gmail.com>
2704
2705 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
2706 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
2707 Set here, not in nt/config.nt.
2708
ea814a5d
EZ
27092012-07-13 Eli Zaretskii <eliz@gnu.org>
2710
2711 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
2712 cursor overflow into the last glyph on display line when the right
2713 fringe is off. (Bug#11832)
2714
1a952767
PE
27152012-07-13 Paul Eggert <eggert@cs.ucla.edu>
2716
2717 * xdisp.c (produce_special_glyphs): Now static.
2718 * dispextern.h (produce_special_glyphs): Remove decl.
2719
983188fd
GM
27202012-07-13 Glenn Morris <rgm@gnu.org>
2721
8d7c7eed 2722 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
2723 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
2724
983188fd
GM
2725 * s/usg5-4-common.h (USG, USG5):
2726 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
2727 * s/sol2-6.h (SOLARIS2):
2728 * s/irix6-5.h (IRIX6_5):
2729 * s/hpux10-20.h (USG, USG5, HPUX):
2730 * s/gnu-linux.h (USG, GNU_LINUX):
2731 * s/freebsd.h (BSD_SYSTEM):
2732 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
2733 * s/cygwin.h (CYGWIN):
2734 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
2735 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
2736
d1e68667 27372012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
2738
2739 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 2740
6de0e799
GM
27412012-07-13 Glenn Morris <rgm@gnu.org>
2742
739ae010
GM
2743 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
2744
dbee5793
GM
2745 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
2746
6de0e799
GM
2747 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
2748 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
2749
b82da769
GM
27502012-07-12 Glenn Morris <rgm@gnu.org>
2751
4fae5a7a 2752 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
2753
2754 * process.c (init_process_emacs): Rename from init_process.
2755 The old name is also the name of a Mach system call.
2756 * lisp.h, emacs.c: Update for this name change.
2757 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
2758 longer needed.
2759
5a979817
EZ
27602012-07-12 Eli Zaretskii <eliz@gnu.org>
2761
2762 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
2763 memmove call that removes glyphs covered by the left truncation
2764 glyph. Improve commentary.
2765 (display_line): Fix display of continuation glyphs on GUI frames
2766 when the right fringe is turned off and variable-size fonts are
2767 used in the window. Move the code that appends a stretch glyph to
2768 produce_special_glyphs, so that it could be used for truncation
2769 and continuation glyphs alike.
2770 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
2771 glyph of a suitably computed width, to align the special glyphs at
2772 the window margin. Code moved from display_line. (Bug#11832)
2773
3e91a053
GM
27742012-07-12 Glenn Morris <rgm@gnu.org>
2775
ba9e4b84
GM
2776 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
2777
2778 * s/gnu-linux.h, s/hpux10-20.h:
2779 Do not unconditionally define HAVE_XRMSETDATABASE.
2780
3e91a053
GM
2781 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
2782
b300b1f4
PE
27832012-07-12 Paul Eggert <eggert@cs.ucla.edu>
2784
2785 Fix typos that broke OS X build.
2786 Reported by Randal L. Schwartz in
2787 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
2788 * nsterm.m (ns_timeout): Add missing local decl.
2789 (ns_get_color): snprintf -> sprintf, to fix typo.
2790
6e777848
GM
27912012-07-12 Glenn Morris <rgm@gnu.org>
2792
3f922c37
GM
2793 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
2794 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
2795 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
2796 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
2797
0ab7b23a
GM
2798 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
2799 Move PTY_OPEN to configure.
2800
6e777848
GM
2801 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2802 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
2803 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
2804
4a7edc24
DA
28052012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
2806
2807 Use empty_unibyte_string where applicable.
2808 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
2809 * lread.c (read1): Likewise.
2810 * xsettings.c (syms_of_xsettings): Likewise.
2811
308aab79
GM
28122012-07-12 Glenn Morris <rgm@gnu.org>
2813
42bd1719
GM
2814 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
2815 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
2816 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
2817 * s/hpux10-20.h (RUN_TIME_REMAP):
2818 * s/bsd-common.h (TABDLY): Move to configure.
2819
2820 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
2821
2822 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
2823
ea0bbd17 2824 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 2825 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
2826
2827 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 2828
308aab79
GM
2829 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
2830 * s/template.h: Move NARROWPROTO to configure.
2831
ee1cf5cf
GM
28322012-07-11 Glenn Morris <rgm@gnu.org>
2833
30fe9bf4
GM
2834 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
2835 unused since 2011-01-17 change to systty.h.
2836
ee1cf5cf
GM
2837 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
2838 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2839 Move HAVE_PTYS and HAVE_SOCKETS to configure.
2840
63e47e07
PE
28412012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2842
2843 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
2844
c43fb4c3
GM
28452012-07-11 Glenn Morris <rgm@gnu.org>
2846
2847 * s/darwin.h, s/gnu-linux.h, s/template.h:
2848 Move INTERRUPT_INPUT to configure.
2849
e8df9267
DA
28502012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2851
2852 Minor adjustments to interning code.
2853 * lisp.h (intern, intern_c_string): Redefine as static inline
2854 wrappers for intern_1 and intern_c_string_1, respectively.
2855 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
2856 * lread.c (intern_1, intern_c_string_1, oblookup):
2857 Simplify Vobarray checking.
e8df9267
DA
2858 * font.c (font_intern_prop): Likewise. Adjust comment.
2859 * w32font.c (intern_font_name): Likewise.
2860
34348bd4
AS
28612012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2862
d96a1e0c
AS
2863 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
2864
34348bd4
AS
2865 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
2866 of Fcar/Fcdr if possible.
2867 * font.c (check_otf_features): Likewise.
2868 * fontset.c (Fnew_fontset): Likewise.
2869 * gnutls.c (Fgnutls_boot): Likewise.
2870 * minibuf.c (read_minibuf): Likewise.
2871 * msdos.c (IT_set_frame_parameters): Likewise.
2872 * xmenu.c (Fx_popup_dialog): Likewise.
2873 * w32menu.c (Fx_popup_dialog): Likewise.
2874
c8add24e
GM
28752012-07-11 Glenn Morris <rgm@gnu.org>
2876
4b575b3c
GM
2877 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
2878 since nothing has defined it on these platforms.
2879
09f4e3b0
GM
2880 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
2881 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
2882
172bedef
GM
2883 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2884 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2885 Move CLASH_DETECTION to configure.
2886
249685df
GM
2887 * s/gnu.h: Remove file, which is now empty.
2888
c8add24e
GM
2889 * s/gnu.h, s/gnu-linux.h:
2890 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
2891
b41253a3
JW
28922012-07-11 John Wiegley <johnw@newartisans.com>
2893
2894 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
2895 function attribute, so we only use it if it exists in the
2896 compiler.
2897
d923b542
DA
28982012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2899
2900 Avoid call to strlen in fast_c_string_match_ignore_case.
2901 * search.c (fast_c_string_match_ignore_case): Change to use
2902 length argument. Adjust users accordingly.
2903 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
2904
5ebbef1d
PE
29052012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2906
bb352260
PE
2907 Assume mkdir, rmdir.
2908 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2909 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2910
57054ddd
PE
2911 Assume rename.
2912 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2913
b747d3f7
PE
2914 Assume perror.
2915 * s/hpux10-20.h (HAVE_PERROR): Remove.
2916 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2917 Remove dummy definition, as this problem was obsolete long ago.
2918
5ebbef1d
PE
2919 Assume strerror.
2920 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2921
984e7f30
DA
29222012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2923
2924 Avoid calls to strlen in font processing functions.
2925 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2926 (font_open_by_name): Change to use length argument.
2927 Adjust users accordingly.
d923b542
DA
2928 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2929 Adjust prototypes.
2930 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2931 Change to return ptrdiff_t.
984e7f30
DA
2932 (xfont_list_pattern, xfont_match): Use length returned by
2933 xfont_decode_coding_xlfd.
2934 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2935
20e94fdd
GM
29362012-07-11 Glenn Morris <rgm@gnu.org>
2937
9d596af3
GM
2938 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2939 Move DONT_REOPEN_PTY to configure.
2940
20e94fdd
GM
2941 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2942 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2943
e99a530f
PE
29442012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2945
22ffb973
PE
2946 Remove "#define unix" that is no longer needed (Bug#11905).
2947 * s/aix4-2.h (unix): Remove; no longer needed.
2948
e9a9ae03
PE
2949 EMACS_TIME simplification (Bug#11875).
2950 This replaces macros (which typically do not work in GDB)
2951 with functions, typedefs and enums, making the code easier to debug.
2952 The functional style also makes code easier to read and maintain.
2953 * systime.h: Include <sys/time.h> on all hosts, not just if
2954 WINDOWSNT, since 'struct timeval' is needed in general.
2955 (EMACS_TIME): Now a typedef, not a macro.
2956 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2957 not macros.
2958 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2959 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2960 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2961 (EMACS_TIME_LE): Now functions, not macros.
2962 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2963 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2964 which are not functions. All uses rewritten to use:
2965 (make_emacs_time): New function.
2966 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2967 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2968 not functions. All uses rewritten to use the following, respectively:
2969 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2970 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2971 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2972 * fileio.c (Fcopy_file):
2973 * xterm.c (XTflash): Get the current time closer to when it's used.
2974 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2975
ffacb126
PE
2976 * bytecode.c (targets): Suppress -Woverride-init warnings.
2977
e99a530f
PE
2978 Simplify by avoiding confusing use of strncpy etc.
2979 * doc.c (Fsnarf_documentation):
2980 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2981 * frame.c (Fmake_terminal_frame):
2982 * gtkutil.c (get_utf8_string):
2983 * lread.c (openp):
2984 * nsmenu.m (ns_update_menubar):
2985 * regex.c (regerror):
2986 Prefer memcpy to strncpy and strncat when either will do.
2987 * fileio.c (Fsubstitute_in_file_name):
2988 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2989 (menu_separator_name_p):
2990 * nsmenu.m (ns_update_menubar):
2991 Prefer memcmp to strncmp when either will do.
2992 * nsterm.m: Include <ftoastr.h>.
2993 (ns_get_color):
2994 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2995 Prefer snprintf to strncpy.
2996 * nsterm.m (ns_term_init):
2997 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2998 * nsterm.m (ns_term_init):
2999 Avoid the need for strncpy, by using build_string or
3000 make_unibyte_string directly. Use dtoastr, not snprintf.
3001 * process.c (Fmake_network_process): Diagnose service names that
3002 are too long, rather than silently truncating them or creating
3003 non-null-terminated names.
3004 (Fnetwork_interface_info): Likewise, for interface names.
3005 * sysdep.c (system_process_attributes) [GNU_LINUX]:
3006 Prefer sprintf to strncat.
3007 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
3008 Prefer vsnprintf to vsprintf + strncpy.
3009
c59592b3
GM
30102012-07-10 Glenn Morris <rgm@gnu.org>
3011
3012 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
3013 Clarify fallback case.
3014
7d7bbefd
DA
30152012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3016
3017 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
3018 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
3019 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 3020 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
3021 where argument type is known to be a Lisp_Cons.
3022
3a4c8000
TT
30232012-07-10 Tom Tromey <tromey@redhat.com>
3024
3025 * bytecode.c (BYTE_CODE_THREADED): New macro.
3026 (BYTE_CODES): New macro. Replaces all old byte-code defines.
3027 (enum byte_code_op): New type.
3028 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
3029 (exec_byte_code): Use them. Use token threading when applicable.
3030
2a0213a6
DA
30312012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3032
3033 Optimize pure C strings initialization.
3034 * lisp.h (make_pure_string): Fix prototype.
3035 (build_pure_c_string): New function, defined as static inline. This
3036 provides a better opportunity to optimize away calls to strlen when
3037 the function is called with compile-time constant argument.
3038 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
3039 argument, adjust users accordingly. Use build_pure_c_string where
3040 appropriate.
3041 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
3042 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
3043 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
3044
cb1caeaf
DA
30452012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3046
3047 Avoid calls to strlen in miscellaneous functions.
3048 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
3049 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
3050 * lread.c (openp): Likewise.
3051
c293e30c
DA
30522012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3053
3054 Avoid calls to strlen in path processing functions.
3055 * fileio.c (file_name_as_directory): Add comment. Change to add
3056 srclen argument and return the length of result. Adjust users
3057 accordingly.
3058 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
3059 swap 1st and 2nd arguments to obey the common convention.
3060 Adjust users accordingly.
c293e30c
DA
3061 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
3062
9e059e3f
GM
30632012-07-10 Glenn Morris <rgm@gnu.org>
3064
d02eb359
GM
3065 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
3066 Move PENDING_OUTPUT_COUNT definition to configure.
3067
882cf227
GM
3068 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
3069 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
3070 * s/gnu.h (DATA_START): Move definitions to configure.
3071
af6e839f
GM
3072 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
3073 We include usg5-4-common.h, which defines them both.
3074
40289a12
GM
3075 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
3076 O_RDONLY already includes it).
3077
9e059e3f
GM
3078 Stop ns builds setting the EMACSLOADPATH environment variable.
3079 * nsterm.m (ns_load_path): Rename from ns_init_paths.
3080 Now it does not set EMACSLOADPATH, just returns the load-path string.
3081 * nsterm.h: Update accordingly.
3082 * lread.c [HAVE_NS]: Include nsterm.h.
3083 (init_lread) [HAVE_NS]: Use ns_load_path.
3084 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
3085
7c4e8ec0
GM
30862012-07-09 Glenn Morris <rgm@gnu.org>
3087
d4f600ff
GM
3088 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
3089 since the included bsd-common.h does so.
3090
cbb31951
GM
3091 Stop ns builds setting the EMACSPATH environment variable.
3092 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
3093 (ns_init_paths): Do not set EMACSPATH.
3094 * nsterm.h (ns_exec_path): Add it.
3095 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
3096 Use ns_exec_path.
3097
7c4e8ec0
GM
3098 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
3099
26bccfae
PE
31002012-07-09 Paul Eggert <eggert@cs.ucla.edu>
3101
a0bee46f
PE
3102 * process.c (wait_reading_process_output): 'waitchannels' was unset
3103 when read_kbd || !NILP (wait_for_cell); fix this.
3104
5994c183
PE
3105 Add GCC-style 'const' attribute to functions that can use it.
3106 * character.h (char_resolve_modifier_mask):
3107 * keyboard.h (make_ctrl_char):
3108 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
3109 (init_character_once, next_almost_prime, init_fns, init_image)
3110 (flush_pending_output, init_sound):
3111 * mem-limits.h (start_of_data):
3112 * menu.h (finish_menu_items):
3113 Add ATTRIBUTE_CONST.
3114 * emacs.c (DEFINE_DUMMY_FUNCTION):
3115 Declare the dummy function with ATTRIBUTE_CONST.
3116 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
3117 Add decls with ATTRIBUTE_CONST.
3118
26bccfae
PE
3119 Minor improvements to make_formatted_string.
3120 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
3121 where int is good enough, as vsprintf returns an int.
3122 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
3123
a8290ec3
DA
31242012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3125
3126 Use make_formatted_string to avoid double length calculation.
3127 * lisp.h (make_formatted_string): New prototype.
3128 * alloc.c (make_formatted_string): New function.
3129 * buffer.c (Fgenerate_new_buffer_name): Use it.
3130 * dbus.c (syms_of_dbusbind): Likewise.
3131 * editfns.c (Fcurrent_time_zone): Likewise.
3132 * filelock.c (get_boot_time): Likewise.
3133 * frame.c (make_terminal_frame, set_term_frame_name)
3134 (x_report_frame_params): Likewise.
3135 * image.c (gs_load): Likewise.
3136 * minibuf.c (get_minibuffer): Likewise.
3137 * msdos.c (dos_set_window_size): Likewise.
3138 * process.c (make_process): Likewise.
3139 * xdisp.c (ensure_echo_area_buffers): Likewise.
3140 * xsettings.c (apply_xft_settings): Likewise.
3141
d01ba2f1
GM
31422012-07-09 Glenn Morris <rgm@gnu.org>
3143
3144 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
3145 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
3146 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
3147 * nsterm.h (ns_etc_directory): Add it.
3148 * callproc.c [HAVE_NS]: Include nsterm.h.
3149 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
3150
f1f924b6
DA
31512012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3152
3153 Move marker debugging code under MARKER_DEBUG.
3154 * marker.c (MARKER_DEBUG): Move marker debugging code under
3155 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
3156 for bootstrap with --enable-checking (~3x slowdown reported
3157 by Juanma Barranquero <lekktu@gmail.com>).
3158 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
3159
ab531b66
PE
31602012-07-08 Paul Eggert <eggert@cs.ucla.edu>
3161
3162 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
3163 See <http://bugs.gnu.org/11825#29>.
3164
c4b3bc8a
EZ
31652012-07-08 Eli Zaretskii <eliz@gnu.org>
3166
3167 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
3168 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
3169 (display_line): Add commentary about displaying truncation glyphs
3170 on GUI frames.
3171 (produce_special_glyphs): Move here from term.c.
3172
3173 * term.c (produce_special_glyphs): Move to xdisp.c.
3174
3175 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
3176 section.
c4b3bc8a 3177
b676b881
AS
31782012-07-07 Andreas Schwab <schwab@linux-m68k.org>
3179
f17c5273
AS
3180 * xdisp.c (display_line): Avoid warning about implicit declaration
3181 of FRAME_FONT.
3182
298819b9
AS
3183 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
3184
b676b881
AS
3185 * lisp.h: Remove empty conditional.
3186
6045c4fd
PE
31872012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3188
b3350bf9
PE
3189 * lread.c (load_path_check): Now static.
3190
6045c4fd
PE
3191 Fix some minor --with-ns problems found by static checking.
3192 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
3193 (x_set_font) [!HAVE_X_WINDOWS]:
3194 * image.c (xpm_load_image) [HAVE_NS]:
3195 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
3196 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
3197 Remove unused local.
3198 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
3199 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
3200 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
3201 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
3202 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
3203 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
3204 Fix pointer signedness problem.
3205 * xfaces.c (FRAME_X_FONT_TABLE):
3206 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
3207
929e7845
GM
32082012-07-07 Glenn Morris <rgm@gnu.org>
3209
3210 * lread.c (load_path_check): New function, split from init_lread.
3211 (init_lread): Reorganize. Motivation:
3212 If EMACSLOADPATH is set, check/warn about that rather than the
3213 defaults, which we are not going to use. Hence we can remove
3214 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
3215 Don't warn if site-lisp directories are missing.
3216 If not installed, start from a blank load-path, since
3217 PATH_LOADSEARCH refers to the eventual installation directories.
3218
58dd0aa4
EZ
32192012-07-07 Eli Zaretskii <eliz@gnu.org>
3220
3221 Support truncation and continuation glyphs on GUI frames, when
3222 fringes are disabled. (Bug#11832)
3223 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
3224 continuation glyphs even if on GUI frames.
3225 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
3226 or both, are absent.
3227 (start_display, move_it_in_display_line_to): Handle the case of a
3228 GUI frame without a fringe to display continuation or truncation
3229 glyphs.
3230 (insert_left_trunc_glyphs): Support GUI frames: make sure
3231 truncation glyphs overwrite enough glyphs from the current line to
3232 have sufficient space in pixels.
3233 (display_line): Support truncation and continuation glyphs on GUI
3234 frames. If some spare pixels are left on the line after inserting
3235 the truncation glyphs, fill that space with a stretch glyph of a
3236 suitably computed width.
3237
3238 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
3239 produce_glyphs, to support GUI sessions.
3240
31571fd7
PE
32412012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3242
5a16b9bc
PE
3243 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
3244
f3047c75
PE
3245 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
3246
31571fd7
PE
3247 Do not require float-time's arg to fit in time_t (Bug#11825).
3248 This works better on hosts where time_t is unsigned, and where
3249 float-time is applied to the (negative) difference between two times.
3250 * editfns.c (decode_time_components): Last arg is now double *,
3251 not int *, and means to store all the result as a double, without
3252 worrying about whether the seconds part fits in time_t.
3253 All callers changed.
3254 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
3255 All callers changed.
3256 (Ffloat_time): Do not fail merely because the specified time falls
3257 outside of time_t range.
3258
4516fbef
GM
32592012-07-07 Glenn Morris <rgm@gnu.org>
3260
3261 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
3262 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
3263 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
3264
07adc2c6
JB
32652012-07-07 Juanma Barranquero <lekktu@gmail.com>
3266
3267 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
3268 Update dependencies.
3269
3270 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
3271
fd573f31
PE
32722012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3273
fee5959d
PE
3274 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
3275 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
3276 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
3277 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
3278 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
3279 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
3280
fd573f31
PE
3281 * xfont.c (compare_font_names): Redo to omit the need for casts.
3282
ddadbc0e
AS
32832012-07-06 Andreas Schwab <schwab@linux-m68k.org>
3284
fca8d6b6
AS
3285 * xfns.c (Fx_change_window_property): Doc fix.
3286 * w32fns.c (Fx_change_window_property): Doc fix.
3287
ddadbc0e
AS
3288 * w32fns.c (Fx_window_property): Accept the same arguments as the
3289 X Windows version. Doc fix.
3290 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
3291
ed9265fc 32922012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
3293 Eli Zaretskii <eliz@gnu.org>
3294
3295 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
3296 Windows-specific code from nt/config.nt moved here.
3297 Obsolete settings removed.
3298
216ee680
PE
32992012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3300
3301 * process.c: Avoid unnecessary calls to gettime.
3302 (wait_reading_process_output): Don't get the time of day
3303 when gobbling data immediately and not waiting, as there's no need
3304 for it in that case. This removes a FIXME.
3305
bdd091e4
JD
33062012-07-06 Jan Djärv <jan.h.d@swipnet.se>
3307
3308 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
3309 is defined (Bug#11768).
3310
9d44f8ce
DA
33112012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3312
3313 Fix marker debugging code.
3314 * marker.c (byte_char_debug_check): Do not perform the check
3315 if buffer is not multibyte.
090bd7cb
JB
3316 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3317 Call byte_char_debug_check with correct arguments.
9d44f8ce 3318
90fc4786
DA
33192012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3320
3321 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
3322 * marker.c (byte_char_debug_check, count_markers):
3323 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
3324 (byte_debug_flag): Remove.
3325 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3326 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
3327
7b7ae965
DA
33282012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3329
4e57b342
DA
3330 Avoid code repetition in marker-related functions.
3331 * marker.c (attach_marker): New function.
3332 (Fset_marker, set_marker_restricted, set_marker_both)
3333 (set_marker_restricted_both): Use it.
3334 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
3335 Consistently rename charno to charpos.
3336 (marker_position): Add eassert.
3337 (marker_byte_position): Convert to eassert.
3338
33392012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3340
3341 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 3342 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 3343 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 3344
657924ff
DA
33452012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3346
3347 Introduce fast path for the widely used marker operation.
3348 * alloc.c (build_marker): New function.
3349 * lisp.h (build_marker): New prototype.
3350 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
3351 * composite.c (autocmp_chars): Likewise.
3352 * editfns.c (buildmark): Remove.
3353 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
3354 (save_restriction_save): Use build_marker.
3355 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
3356 * window.c (save_window_save): Likewise.
3357
041a49a6
DA
33582012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3359
3360 Do not use Fdelete_overlay in delete_all_overlays
3361 to avoid redundant calls to unchain_overlay.
3362 * buffer.c (drop_overlay): New function.
3363 (delete_all_overlays, Fdelete_overlay): Use it.
3364 * minibuf.c (get_minibuffer): Fix comment.
3365
7dca65a4
PE
33662012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3367
3368 Port to OpenBSD 5.1 amd64.
3369 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
3370 This is needed for OpenBSD, and should be harmless on all BSD systems.
3371 Also, include <sys/sysctl.h>, as it should be available on all
3372 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
3373 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
3374 use p_pid member, not kp_proc.pid.
3375
8eb876e2
GM
33762012-07-06 Glenn Morris <rgm@gnu.org>
3377
3378 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
3379
38182d90
PE
33802012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 More xmalloc and related cleanup.
3383 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
3384 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
3385 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
3386 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
3387 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
3388 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
3389 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
3390 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
3391 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
3392 * xterm.c:
3393 Omit needless casts involving void * pointers and allocation.
3394 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
3395 as the former is more robust if P's type is changed.
3396 Prefer xzalloc to xmalloc + memset 0.
3397 Simplify malloc-or-realloc to realloc.
3398 Don't worry about xmalloc returning a null pointer.
3399 Prefer xstrdup to xmalloc + strcpy.
3400 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
3401 growing it.
3402 * keyboard.c (apply_modifiers_uncached): Prefer local array to
3403 alloca of a constant.
3404
6dd5a677
EZ
34052012-07-05 Eli Zaretskii <eliz@gnu.org>
3406
3407 * xdisp.c (display_line): Fix horizontal pixel coordinates when
3408 hscroll is larger than the line width. Fixes long and futile
3409 looping inside extend_face_to_end_of_line (on a TTY) producing
3410 glyphs that are not needed and thrown away.
3411
6b312f0f
DA
34122012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3413
3414 * marker.c (set_marker_restricted_both): Simplify by using
3415 clip_to_bounds.
3416
f520ef9b
PE
34172012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3418
3419 * editfns.c (region_limit): Simplify by using clip_to_bounds.
3420
383b7c95
JD
34212012-07-05 Jan Djärv <jan.h.d@swipnet.se>
3422
3423 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
3424 not defined (Bug#11768).
3425 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
3426 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
3427 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
3428 followed by gtk_box_set_homogeneous (Bug#11768).
3429 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
3430 (update_theme_scrollbar_width, xg_create_scroll_bar):
3431 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
3432 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
3433 (is_box_type): New function (Bug#11768).
3434 (xg_tool_item_stale_p): Call is_box_type.
5293d758 3435 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
3436 with default display (Bug#11768).
3437
d6e7bf45
EZ
34382012-07-05 Eli Zaretskii <eliz@gnu.org>
3439
3440 * xdisp.c (window_hscroll_limited): New function.
3441 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
3442 coordinates when window's hscroll is set to insanely large
3443 values. (Bug#11857)
3444
431391ec
JB
34452012-07-05 Juanma Barranquero <lekktu@gmail.com>
3446
3447 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
3448 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
3449
23f86fce
DA
34502012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3451
3452 Cleanup xmalloc.
3453 * lisp.h (xzalloc): New prototype. Omit needless casts.
3454 * alloc.c (xzalloc): New function. Omit needless casts.
3455 * charset.c: Omit needless casts. Convert all calls to
3456 xmalloc with following memset to xzalloc.
3457 * dispnew.c: Likewise.
3458 * fringe.c: Likewise.
3459 * image.c: Likewise.
3460 * sound.c: Likewise.
3461 * term.c: Likewise.
3462 * w32fns.c: Likewise.
3463 * w32font.c: Likewise.
3464 * w32term.c: Likewise.
3465 * xfaces.c: Likewise.
3466 * xfns.c: Likewise.
3467 * xterm.c: Likewise.
3468 * atimer.c: Omit needless casts.
3469 * buffer.c: Likewise.
3470 * callproc.c: Likewise.
3471 * ccl.c: Likewise.
3472 * coding.c: Likewise.
3473 * composite.c: Likewise.
3474 * doc.c: Likewise.
3475 * doprnt.c: Likewise.
3476 * editfns.c: Likewise.
3477 * emacs.c: Likewise.
3478 * eval.c: Likewise.
3479 * filelock.c: Likewise.
3480 * fns.c: Likewise.
3481 * gtkutil.c: Likewise.
3482 * keyboard.c: Likewise.
3483 * lisp.h: Likewise.
3484 * lread.c: Likewise.
3485 * minibuf.c: Likewise.
3486 * msdos.c: Likewise.
3487 * print.c: Likewise.
3488 * process.c: Likewise.
3489 * region-cache.c: Likewise.
3490 * search.c: Likewise.
3491 * sysdep.c: Likewise.
3492 * termcap.c: Likewise.
3493 * terminal.c: Likewise.
3494 * tparam.c: Likewise.
3495 * w16select.c: Likewise.
3496 * w32.c: Likewise.
3497 * w32reg.c: Likewise.
3498 * w32select.c: Likewise.
3499 * w32uniscribe.c: Likewise.
3500 * widget.c: Likewise.
3501 * xdisp.c: Likewise.
3502 * xmenu.c: Likewise.
3503 * xrdb.c: Likewise.
3504 * xselect.c: Likewise.
3505
0497dc44
PE
35062012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3507
3508 * fileio.c (time_error_value): Check the right error number.
3509 Problem reported by Troels Nielsen in
3510 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
3511
356e7178
PE
35122012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3513
4e71fd89
PE
3514 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
3515 This should be fixed in a better way; see Eli Zaretskii in
3516 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
3517 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
3518
f0941253
PE
3519 * fileio.c (time_error_value): Rename from special_mtime.
3520 The old name's problems were noted by Eli Zaretskii in
3521 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
3522
065c9eb4
PE
3523 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
3524 This variable's comment says Emacs needs at least one GDB-visible
3525 symbol of type enum pvec_type, to work around GDB problems.
3526 The symbol's value doesn't matter.
3527
356e7178
PE
3528 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
3529 that causes compilation to fail on pre-C99 compilers.
3530
ed9265fc 35312012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
3532
3533 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
3534 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
3535
3884d954
DA
35362012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3537
d209e2fb 3538 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
3539 headers for buffer_defaults and buffer_local_symbols.
3540 Reported by Juanma Barranquero <lekktu@gmail.com>.
3541
ee28be33
SM
35422012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3543
3544 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
3545 * lisp.h (enum pvec_type): Use fewer bits.
3546 (PSEUDOVECTOR_SIZE_BITS): New constant.
3547 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
3548 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
3549 change in pvec_type.
3550 (PSEUDOVECTOR_TYPEP): New macro.
3551 (TYPED_PSEUDOVECTORP): Use it.
3552 * fns.c (internal_equal): Adapt code to extract pvectype.
3553 * emacs.c (gdb_pvec_type): Update type.
3554 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
3555 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
3556 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
3557 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
3558 (sweep_vectors): Use it. Use local var `total_bytes' instead of
3559 abusing vector->header.next.nbytes.
3560 (live_vector_p): Use PVEC_TYPE.
3561 (mark_object): Adapt code to extract pvectype. Use switch.
3562
c7f2cd7f
PE
35632012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3564
3565 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
3566 Tighten new eassert a bit.
3567
8ce70ed2
DA
35682012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3569
3570 Fix compilation with --enable-gcc-warnings and -O1
3571 optimization level.
3572 * doprnt.c (doprnt): Change type of tem to int, initialize
3573 to avoid compiler warning. Add eassert.
3574 * search.c (simple_search): Initialize match_byte to avoid
3575 compiler warning. Add eassert.
3576
dea7f1e5
PE
35772012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3578
24a212eb
PE
3579 Avoid weird behavior with large horizontal scrolls.
3580 Without this change, for example, large hscroll values would
3581 mess up Emacs's display on Fedora 15 x86, presumably due to
3582 overflows in int calculations in the display code.
3583 Also, if buffers had long lines, Emacs would freeze.
3584 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
3585 (set_window_hscroll): New function, containing the old guts of
3586 Fset_window_hscroll. Return the clipped value.
3587 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
3588 This avoids the need to check against PTRDIFF_MAX.
3589
dea7f1e5
PE
3590 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
3591
76046526
DA
35922012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3593
3594 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
3595
39adff0d
PE
35962012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3597
63807d47
PE
3598 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
3599 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
3600 since GCC 4.4.6 issues a bogus warning for them.
3601
39adff0d
PE
3602 Fix bugs in file timestamp newness comparisons.
3603 * fileio.c (Ffile_newer_than_file_p):
3604 * lread.c (Fload): Use full timestamp resolution of files,
3605 not just the 1-second resolution, so that files that are only
3606 slightly newer still count as newer.
3607 * fileio.c (Ffile_newer_than_file_p): Don't assume file
3608 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
3609
dbeed9a6
PE
36102012-07-03 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 * fileio.c: Improve handling of file time marker. (Bug#11852)
3613 (special_mtime): New function.
3614 (Finsert_file_contents, Fverify_visited_file_modtime):
3615 Use it to set special mtime values consistently.
3616
636334d6
AS
36172012-07-03 Andreas Schwab <schwab@linux-m68k.org>
3618
3619 * fileio.c (Finsert_file_contents): Properly handle st_mtime
3620 marker for non-existing file. (Bug#11852)
3621
e2017fe2
GM
36222012-07-03 Glenn Morris <rgm@gnu.org>
3623
3624 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
3625 and did not make it into globals.h).
3626
404dbd37
TT
36272012-07-03 Tom Tromey <tromey@redhat.com>
3628
3629 * window.c (Fset_window_margins, Fset_window_fringes)
3630 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
3631 * textprop.c (Fprevious_property_change): No longer static.
3632 * syntax.c (Fsyntax_table_p): No longer static.
3633 * process.c (Fget_process, Fprocess_datagram_address): No longer
3634 static.
3635 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
3636 * keyboard.c (Fcommand_execute): No longer static.
3637 Remove EXFUN.
3638 * insdel.c (Fcombine_after_change_execute): No longer static.
3639 * image.c (Finit_image_library): No longer static.
3640 * fileio.c (Fmake_symbolic_link): No longer static.
3641 * eval.c (Ffetch_bytecode): No longer static.
3642 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
3643 * doc.c (Fdocumentation_property, Fsnarf_documentation):
3644 No longer static.
404dbd37
TT
3645 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
3646 static.
3647 * dired.c (Ffile_attributes): No longer static.
3648 * composite.c (Fcomposition_get_gstring): No longer static.
3649 * callproc.c (Fgetenv_internal): No longer static.
3650
3651 * ccl.h: Remove EXFUNs.
3652 * buffer.h: Remove EXFUNs.
3653 * dispextern.h: Remove EXFUNs.
3654 * intervals.h: Remove EXFUNs.
3655 * fontset.h: Remove EXFUN.
3656 * font.h: Remove EXFUNs.
3657 * dosfns.c (system_process_attributes): Remove EXFUN.
3658 * keymap.h: Remove EXFUNs.
3659 * lisp.h: Remove EXFUNs.
3660 * w32term.h: Remove EXFUNs.
3661 * window.h: Remove EXFUNs.
3662 * xsettings.h: Remove EXFUN.
3663 * xterm.h: Remove EXFUN.
3664
8e4fd1e1
GM
36652012-07-03 Glenn Morris <rgm@gnu.org>
3666
3667 * lisp.h (Frandom): Make it visible to C.
3668 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
3669 buffer for invisible buffers. (Bug#1229)
3670
ca95b3eb
DA
36712012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3672
3673 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
3674 values which aren't power of 2.
14ae4239
BT
3675 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
3676 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
3677 accordingly.
3678
7555c33f
SM
36792012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
3680
3681 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
3682
3683 * alloc.c (mark_object): Revert part of last patch to use `switch'.
3684
d12e8f5a
DA
36852012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3686
3687 * alloc.c (allocate_vector_block): Remove redundant
3688 calls to mallopt if DOUG_LEA_MALLOC is defined.
3689 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
3690 avoid calls to mallopt if zero_vector is returned.
3691
296094c3
DA
36922012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3693
3694 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
3695 is enabled, avoid dereferencing NULL current_sblock if
3696 running undumped.
3697
36429c89
DA
36982012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3699
3700 Cleanup basic buffer management.
3701 * buffer.h (struct buffer): Change layout to use generic vector
3702 marking code. Fix some comments. Change type of 'clip_changed'
3703 to bitfield. Remove unused #ifndef old.
3704 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
3705 (GET_OVERLAYS_AT): Fix indentation.
3706 (for_each_per_buffer_object_at): New macro.
3707 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
3708 (Fbuffer_local_variables): Use it.
3709 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
3710 * alloc.c (allocate_buffer): Adjust to match new layout of
3711 struct buffer. Fix comment.
3712 (mark_overlay): New function.
3713 (mark_buffer): Use it. Use mark_vectorlike to mark normal
3714 Lisp area of struct buffer.
3715 (mark_object): Use it. Adjust marking of misc objects
3716 and related comments.
3717
3b3e4cac
PE
37182012-07-02 Paul Eggert <eggert@cs.ucla.edu>
3719
3720 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
3721 wrapper that is not needed because the wrapped code is a no-op (zero
3722 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
3723 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
3724
cf5c0175
DA
37252012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
3726
3727 * alloc.c (mark_buffer): Simplify. Remove prototype.
3728 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 3729 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
3730 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
3731 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 3732
ca26824c
GM
37332012-06-30 Glenn Morris <rgm@gnu.org>
3734
2e4c5312
GM
3735 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
3736
ca26824c
GM
3737 * epaths.in (PATH_SITELOADSEARCH): New.
3738 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
3739 This is rather than relying on --enable-locallisppath elements
3740 having "site-lisp" in their names. (Bug#10208#25, 11658)
3741
0d23c240
EZ
37422012-06-30 Eli Zaretskii <eliz@gnu.org>
3743
c9240d7a
EZ
3744 * w32proc.c (sys_select): Accept and ignore one more argument.
3745
3746 * w32.c (emacs_gnutls_pull): Call select with one more argument.
3747
0d23c240 3748 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 3749 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
3750
3751 * sysdep.c: Don't include dos.h and dosfns.h.
3752
3753 * process.c (sys_select):
3754 * msdos.c (sys_select): Accept one more argument and ignore it.
3755
3756 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
3757 adapt data types and code to that.
3758
3759 * dosfns.c:
3760 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
3761 which clashes with the gnulib function of the same name.
3762
af5a5a98
AS
37632012-06-30 Andreas Schwab <schwab@linux-m68k.org>
3764
c5e4379c
AS
3765 * font.c (font_style_to_value, font_style_symbolic)
3766 (font_prop_validate_style): Add type checks for values in
3767 font_style_table.
3768
af5a5a98
AS
3769 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
3770 argument.
3771 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
3772 uses.
3773
8d38f461
EZ
37742012-06-29 Eli Zaretskii <eliz@gnu.org>
3775
2e5a6631
EZ
3776 * xdisp.c (try_window_id): Undo last change.
3777
8d38f461
EZ
3778 * w32.c (getwd): Adjust commentary about startup_dir.
3779 (init_environment): Always call sys_access, even in non-MSVC
3780 builds. Don't chdir to the directory of the Emacs executable.
3781 This undoes code from 1997 which was justified by the need to
3782 "avoid conflicts when removing and renaming directories". But its
3783 downside was that every relative file name was being interpreted
3784 relative to the directory of the Emacs executable, which can never
3785 be TRT. In particular, it broke sys_access when called with
3786 relative file names.
3787 (sys_access): Map GetLastError to errno.
3788
2af3565e
DA
37892012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3790
3791 * window.h (struct window): Change type of 'fringes_outside_margins'
3792 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 3793 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
3794 Adjust comment.
3795 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
3796 to ptrdiff_t.
3797
c8d3a25c 37982012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 3799
c8d3a25c
GM
3800 * gnutls.c (emacs_gnutls_handshake):
3801 Add QUIT to make the loop interruptible.
57570cd3 3802
c8d3a25c 38032012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 3804
c8d3a25c
GM
3805 * charset.c (init_charset): Make lack of etc/charsets fatal.
3806
3e984ee8
DA
38072012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3808
3809 * editfns.c (region_limit): Fix type mismatch.
3810
ef884f23
DA
38112012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3812
3813 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
3814 undefined. Convert from xassert to eassert.
3815 * nsmenu.m: Convert from xassert to eassert.
3816 * nsterm.m: Likewise.
3817
7d7e0027
SM
38182012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
3819
3820 * editfns.c (region_limit): Clip to narrowing (bug#11770).
3821
aa754e6a
PE
38222012-06-28 Paul Eggert <eggert@cs.ucla.edu>
3823
3824 Avoid integer overflow on scroll-left and scroll-right.
3825 * window.c (HSCROLL_MAX): New macro.
3826 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
3827 overflow when requested scroll falls outside ptrdiff_t range.
3828
80b00b08
DA
38292012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3830
3831 * window.h (struct window): Change type of 'hscroll',
3832 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
3833 'last_modified' and 'last_overlay_modified' to EMACS_INT.
3834 Adjust users accordingly.
3835 * xdisp.c (try_cursor_movement): Replace type check with eassert.
3836 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
3837 from EMACS_INT to ptrdiff_t.
3838 (make_window): Omit redundant initialization.
3839
62b2bcf6
JB
38402012-06-28 Juanma Barranquero <lekktu@gmail.com>
3841
3842 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
3843
45942c7d
DA
38442012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3845
3846 * window.h (struct window): Change type of 'use_time' and
3847 'sequence_number' from Lisp_Object to int.
3848 * frame.c (make_frame): Adjust users accordingly.
3849 * print.c (print_object): Likewise.
3850 * window.c (select_window, Fwindow_use_time, make_parent_window)
3851 (make_window): Likewise.
3852
e509cfa6
DA
38532012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3854
3855 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
3856 enabled with --enable-checking=[all,glyphs] configure option.
3857 Fix GLYPH_DEBUG usage assuming that it may be undefined,
3858 adjust comments accordingly.
3859 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
3860 undefined, adjust comments accordingly.
3861 * image.c: Likewise.
3862 * scroll.c: Likewise.
3863 * w32fns.c: Likewise.
3864 * w32term.c: Likewise.
3865 * xdisp.c: Likewise.
3866 * xfaces.c: Likewise.
3867 * xfns.c: Likewise.
3868 * xterm.c: Likewise.
3869
a54e2c05
DA
38702012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3871
3872 Generalize run-time debugging checks.
3873 * dispextern.h (XASSERTS): Remove.
3874 * fontset.c (xassert): Remove.
3875 Convert from xassert to eassert.
3876 * alloc.c: Convert from xassert to eassert.
3877 * bidi.c: Likewise.
3878 * dispnew.c: Likewise.
3879 * fns.c: Likewise.
3880 * fringe.c: Likewise.
3881 * ftfont.c: Likewise.
3882 * gtkutil.c: Likewise.
3883 * image.c: Likewise.
3884 * keyboard.c: Likewise.
3885 * menu.c: Likewise.
3886 * process.c: Likewise.
3887 * scroll.c: Likewise.
3888 * sound.c: Likewise.
3889 * term.c: Likewise.
3890 * w32console.c: Likewise.
3891 * w32fns.c: Likewise.
3892 * w32term.c: Likewise.
3893 * window.c: Likewise.
3894 * xdisp.c: Likewise.
3895 * xfaces.c: Likewise.
3896 * xfns.c: Likewise.
3897 * xselect.c: Likewise.
3898 * xterm.c: Likewise.
3899
1ec4b7b2
SM
39002012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
3901
3902 * fns.c (maybe_resize_hash_table): Output message when growing the
3903 purify-hashtable.
3904
2014308a
DA
39052012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3906
3907 * alloc.c (allocate_string_data): Remove dead code.
3908 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3909 avoid GCC warning about unused macro.
3910
246155eb
DA
39112012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3912
3913 * alloc.c (allocate_string): Omit intervals initialization.
3914 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3915 as in make_pure_string and make_pure_c_string.
3916
43184b7b
DA
39172012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3918
d209e2fb 3919 * alloc.c (allocate_string): Fix last change.
43184b7b 3920
3fe6dd74
DA
39212012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3922
d209e2fb 3923 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3924 to memset, add explicit initialization where appropriate.
3925
1ba6038a
GM
39262012-06-27 Glenn Morris <rgm@gnu.org>
3927
3928 * lisp.mk (lisp): Remove paths.elc.
3929
c89926a5
CY
39302012-06-27 Chong Yidong <cyd@gnu.org>
3931
3932 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3933
ed6b3510
JW
39342012-06-26 John Wiegley <johnw@newartisans.com>
3935
1ec4b7b2 3936 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3937 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3938
ed6b3510
JW
3939 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3940 when building with Clang.
3941
8edd4a2b
SM
39422012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3943
3944 * eval.c (Fapply): Allow calling it with a single argument.
3945
f6f62d1b
EZ
39462012-06-26 Eli Zaretskii <eliz@gnu.org>
3947
3948 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3949 _stricmp and _strnicmp.
3950 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3951
62efea5e
DA
39522012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3953
3954 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3955 allocated window.
3956 (allocate_process): Likewise for new process.
8edd4a2b 3957 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3958 (allocate_frame): Likewise.
3959 * frame.c (make_frame): Omit redundant initialization.
3960 * window.c (make_parent_window): Use memset.
3961 (make_window): Omit redundant initialization.
3962 * process.c (make_process): Omit redundant initialization.
3963 * terminal.c (create_terminal): Likewise.
3964
42997f4d
DA
39652012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3966
3967 * term.c (delete_tty): Remove redundant call to memset.
3968
1130ecfc
DA
39692012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3970
3971 * alloc.c: Remove build_string.
3972 * lisp.h: Define build_string as static inline. This provides
3973 a better opportunity to optimize away calls to strlen when the
3974 function is called with compile-time constant argument.
3975 * image.c (imagemagick_error): Convert to build_string.
3976 * w32proc.c (sys_spawnve): Likewise.
3977 * xterm.c (x_term_init): Likewise.
3978
cf38a720
PE
39792012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3980
99027bdd
PE
3981 Use sprintf return value instead of invoking strlen on result.
3982 In the old days this wasn't portable, since some sprintf
3983 implementations returned char *. But they died out years ago and
3984 Emacs already assumes sprintf returns int.
3985 Similarly for float_to_string.
3986 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3987 * ccl.c (ccl_driver):
3988 * character.c (string_escape_byte8):
3989 * data.c (Fnumber_to_string):
3990 * doprnt.c (doprnt):
3991 * print.c (print_object):
3992 * xdisp.c (message_dolog):
3993 * xfns.c (syms_of_xfns):
3994 Use sprintf or float_to_string result to avoid need to call strlen.
3995 * data.c (Fnumber_to_string):
3996 Use make_unibyte_string, since the string must be ASCII.
3997 * lisp.h, print.c (float_to_string): Now returns int length.
3998 * term.c (produce_glyphless_glyph):
3999 Use sprintf result rather than recomputing it.
4000
cf38a720
PE
4001 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
4002 * Makefile.in (ALL_CFLAGS):
4003 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
4004 * gmalloc.c, regex.c: Include <config.h> unconditionally.
4005
3511c784
DA
40062012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4007
0a08eb21 4008 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
4009 strcasecmp if available.
4010 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
4011
fb7da12e
AS
40122012-06-25 Andreas Schwab <schwab@linux-m68k.org>
4013
4014 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
4015 Avoid comma operator.
4016 * menu.c (push_submenu_start, push_submenu_end)
4017 (push_left_right_boundary, push_menu_pane): Likewise.
4018 * msdos.c (dos_rawgetc): Likewise.
4019
afa2ffd8
DA
40202012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4021
4022 * xfns.c (xic_create_fontsetname): Remove redundant calls
4023 to memset.
4024
b3b4476b
PE
40252012-06-25 Paul Eggert <eggert@cs.ucla.edu>
4026
4495ff38
PE
4027 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4028 sprintf already null-terminates its output.
4029
b3b4476b
PE
4030 * xfns.c (x_window): Remove redundant cast.
4031
b00876c9
DA
40322012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4033
4034 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4035 `const char *' to `char *' to avoid compiler warning.
4036
d188e26b
PE
40372012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4038
885d1d74
PE
4039 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4040 instead of truncating it to 63 (admittedly a generous limit).
4041
d188e26b
PE
4042 * process.c: Fix spelling and caps in comments.
4043
e2f560b1
DN
40442012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
4045
e86db54b 4046 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
4047 * sysdep.c (setpgrp): Remove definition, not used in this file.
4048
7583a3a1
JB
40492012-06-24 Juanma Barranquero <lekktu@gmail.com>
4050
4051 * makefile.w32-in: Update dependencies.
4052
696056c2
EZ
40532012-06-24 Eli Zaretskii <eliz@gnu.org>
4054
4055 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4056 (SYSTIME_H): Add nt/inc/sys/time.h.
4057
4058 * systime.h [WINDOWSNT]: Include sys/time.h.
4059
4060 * s/ms-w32.h (struct timespec): Definition moved from
4061 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
4062
845ca893
PE
40632012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4064
4065 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
4066 * buffer.h (buffer_slot_type_mismatch):
4067 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4068 * eval.c (unwind_to_catch):
4069 * image.c (my_png_error, my_error_exit):
4070 * keyboard.c (quit_throw_to_read_char, user_error)
4071 (Fexit_recursive_edit, Fabort_recursive_edit):
4072 * lisp.h (die, args_out_of_range, args_out_of_range_3)
4073 (wrong_type_argument, buffer_overflow, __executable_start)
4074 (memory_full, buffer_memory_full, string_overflow, Fthrow)
4075 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
4076 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
4077 (fatal):
4078 (child_setup) [!DOS_NT]:
4079 * lread.c (end_of_file_error, invalid_syntax):
4080 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4081 * puresize.h (pure_write_error):
4082 * search.c (matcher_overflow):
4083 * sound.c (sound_perror, alsa_sound_perror):
4084 * sysdep.c, syssignal.h (croak):
4085 * term.c (maybe_fatal, vfatal):
4086 * textprop.c (text_read_only):
4087 * undo.c (user_error):
4088 * unexmacosx.c (unexec_error):
4089 * xterm.c (x_ins_del_lines, x_delete_glyphs):
4090 Use _Noreturn rather than NO_RETURN.
4091 No need for separate decl merely because of _Noreturn.
4092 * sound.c (sound_warning, parse_sound):
4093 Remove unnecessary forward decls.
4094
f1dd8073
PE
40952012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4096
4097 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
4098 * lisp.h (WAIT_READING_MAX): New macro.
4099 * dispnew.c (Fsleep_for, sit_for):
4100 * keyboard.c (kbd_buffer_get_event):
4101 * process.c (Faccept_process_output):
4102 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
4103 This improves on the previous patch, which introduced a bug
4104 when time_t is unsigned and as wide as intmax_t.
4105 See <http://bugs.gnu.org/9000#51>.
4106
b82c1755
EZ
41072012-06-23 Eli Zaretskii <eliz@gnu.org>
4108
4109 * dispnew.c (sit_for, Fsleep_for):
4110 * keyboard.c (kbd_buffer_get_event):
4111 * process.c (Faccept_process_output): Avoid compiler warnings when
4112 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
4113
ca300656
JB
41142012-06-23 Juanma Barranquero <lekktu@gmail.com>
4115
049ec95b
JB
4116 * makefile.w32-in: Update dependencies.
4117
ca300656
JB
4118 * w32.c (ltime): Add return type and declare static.
4119 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
4120
db7b8d06
PE
41212012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4122
4123 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
4124 Privately reported by Herbert J. Skuhra.
4125 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
4126 All uses changed.
4127 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
4128 not make_lisp_timeval, when the argument is of type EMACS_TIME.
4129
0bd8297f
EZ
41302012-06-23 Eli Zaretskii <eliz@gnu.org>
4131
96512555
EZ
4132 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
4133 last argument of make_unibyte_string.
4134
0bd8297f
EZ
4135 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
4136 language ID in the event parameters.
4137
4138 * w32term.c (w32_read_socket): Put the new keyboard codepage into
4139 event.code, not the obscure "character set ID".
4140
63def6b6
CY
41412012-06-23 Chong Yidong <cyd@gnu.org>
4142
4143 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
4144
e8a02204
EZ
41452012-06-23 Eli Zaretskii <eliz@gnu.org>
4146
388cdec0
EZ
4147 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
4148 * w32.c (fdutimens): New function.
4149
4150 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
4151
4152 * s/ms-w32.h (pselect): Redirect to sys_select.
4153
4154 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
4155
e8a02204
EZ
4156 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
4157 in the logic of incrementing and decrementing the value of
4158 use_relocatable_buffers.
4159
d054f3fb
PE
41602012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4161
4162 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
4163 Privately reported by Herbert J. Skuhra.
4164 [__FreeBSD__]: Remove "*/" typo after "#include".
4165 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
4166 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
4167 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
4168 Don't assume EMACS_TIME and struct timeval are the same type.
4169
d35af63c
PE
41702012-06-22 Paul Eggert <eggert@cs.ucla.edu>
4171
4172 Support higher-resolution time stamps (Bug#9000).
4173 The time stamps are only nanosecond-resolution at the C level,
4174 since that's the best that any real-world system supports now.
4175 But they are picosecond-resolution at the Lisp level, as that's
4176 easy, and leaves room for future OS improvements.
4177
4178 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
4179 (LIBES): Use it.
4180
4181 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
4182 Don't get current time unless it's needed.
4183
4184 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
4185 now provides it if it's absent.
4186 (start_atimer): Port to higher-res time stamps.
4187 Check for time stamp overflow. Don't get current time more
4188 often than is needed.
4189
4190 * buffer.h (struct buffer): Buffer modtime now has high resolution.
4191 Include systime.h, not time.h.
4192 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
4193
4194 * dired.c: Include stat-time.h.
4195 (Ffile-attributes): File times now have higher resolution.
4196
4197 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
4198 (struct image): Timestamp now has higher resolution.
4199
4200 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
4201 has at least microseconds now. All uses removed.
4202 (update_frame, update_single_window, update_window, update_frame_1)
4203 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 4204 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
4205
4206 * editfns.c (time_overflow): Now extern.
4207 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
4208 (float-time, Fformat_time_string, Fcurrent_time_string)
4209 (Fcurrent_time_zone): Accept and generate higher-resolution
4210 time stamps.
4211 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
4212 (decode_time_components, lisp_seconds_argument): New functions.
4213 (make_time): Now static.
4214 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
4215 Report an error if the time is invalid, rather than having the caller
4216 do that.
4217
4218 * fileio.c: Include <stat-time.h>
4219 (Fcopy_file): Copy higher-resolution time stamps.
4220 Prefer to set the time stamp via a file descriptor if that works.
4221 (Fset_file_times, Finsert_file_contents, Fwrite_region)
4222 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
4223 (Fvisited_file_modtime, Fset_visited_file_modtime):
4224 Support higher-resolution time stamps.
4225
4226 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
4227
4228 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
4229
4230 * image.c (prepare_image_for_display, clear_image_cache)
4231 (lookup_image): Port to higer-resolution time stamps.
4232
4233 * keyboard.c (start_polling, bind_polling_period):
4234 Check for time stamp overflow.
4235 (read_char, kbd_buffer_get_event, timer_start_idle)
4236 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
4237 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
4238 Port to higher-resolution time stamps. Do not assume time_t is signed.
4239 (decode_timer): New function. Timers are now vectors of length 9,
4240 not 8, to accommodate the picosecond component.
4241 (timer_check_2): Use it.
4242
4243 * nsterm.m (select_timeout, timeval_subtract): Remove.
4244 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
4245 as they're a bit more accurate and handle overflow better.
4246 (ns_select): Change prototype to be compatible with pselect.
4247 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
4248 * nsterm.h (ns_select): Adjust prototype.
4249
4250 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
4251 us-resolution time stamps.
4252 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
4253
4254 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
4255
4256 * lisp.h (time_overflow): New decl.
4257 (wait_reading_process_output): First arg is now intmax_t, not int,
4258 to accommodate larger waits.
4259
4260 * process.h (struct Lisp_Process.read_output_delay):
4261 Now counts nanoseconds, not microseconds.
4262 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
4263 EMACS_HAS_USECS.
4264 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
4265 (wait_reading_process_output):
4266 Port to ns-resolution time stamps.
4267 (Faccept_process_output, wait_reading_process_output):
4268 Check for time stamp overflow. Do not assume time_t is signed.
4269 (select_wrapper): Remove; we now use pselect.
4270 (Fprocess_attributes): Now generates ns-resolution time stamps.
4271
4272 * sysdep.c: Include utimens.h. Don't include utime.h
4273 or worry about struct utimbuf; gnulib does that for us now.
4274 (gettimeofday): Remove; gnulib provides a substitute.
4275 (make_timeval): New function.
4276 (set_file_times): Now sets ns-resolution time stamps.
4277 New arg FD; all uses changed.
4278 (time_from_jiffies, ltime_from_jiffies, get_up_time)
4279 (system_process_attributes):
4280 Now returns ns-resolution time stamp. All uses changed.
4281 Check for time stamp overflow.
4282
4283 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
4284 provides a substitute now.
4285
4286 * systime.h: Include timespec.h rather than sys/time.h and time.h,
4287 since it guarantees struct timespec.
4288 (EMACS_TIME): Now struct timespec, so that we can support
4289 ns-resolution time stamps.
4290 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
4291 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
4292 (EMACS_USECS): Remove.
4293 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
4294 so multiply the arg by 1000 before storing it.
4295 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
4296 New macros.
4297 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
4298 Port to ns-resolution time stamps.
4299 (EMACS_TIME_NEG_P): Remove; replaced by....
4300 (EMACS_TIME_SIGN): New macro.
4301 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
4302 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
4303 (set_file_times, make_time, lisp_time_argument): Adjust signature.
4304 (make_timeval, make_lisp_time, decode_time_components): New decls.
4305 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
4306 that it mishandled time_t overflow. You can't compare by subtracting!
4307 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
4308 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
4309
4310 * term.c: Include <sys/time.h>.
4311 (timeval_to_Time): New function, for proper overflow wraparound.
4312 (term_mouse_position, term_mouse_click): Use it.
4313
4314 * undo.c (record_first_change): Support higher-resolution time stamps
4315 in the undo buffer.
4316 (Fprimitive_undo): Use them when restoring time stamps.
4317
4318 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
4319 (w32_get_internal_run_time):
4320 Port to higher-resolution Emacs time stamps.
4321 (ltime): Now accepts single 64-bit integer, as that's more convenient
4322 for callers.
4323
4324 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
4325
4326 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
4327 for compatibility with pselect. Support ns-resolution time stamps.
4328
4329 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
4330
4331 * xselect.c (wait_for_property_change, x_get_foreign_selection):
4332 Check for time stamp overflow, and support ns-resolution time stamps.
4333
4334 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
4335 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
4336 (timeval_subtract): Remove; no longer needed.
4337 (XTflash, XTring_bell, x_wait_for_event):
4338 Port to ns-resolution time stamps. Don't assume time_t is signed.
4339
b6a92dfe
CY
43402012-06-22 Chong Yidong <cyd@gnu.org>
4341
4342 * xdisp.c (x_consider_frame_title): Revert last change.
4343
d251c37c
EZ
43442012-06-22 Eli Zaretskii <eliz@gnu.org>
4345
4346 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
4347 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
4348 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
4349 staticidx goes up to 1597 out of 1600 = 0x640.)
4350
f10deafb
PE
43512012-06-20 Paul Eggert <eggert@cs.ucla.edu>
4352
4353 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
4354 Otherwise, the umask might be mistakenly 0 while handling input signals.
4355
ec6de1e2
SM
43562012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
4357
4358 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
4359
28be1ada
DA
43602012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
4361
4362 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
4363 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
4364 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
4365 access to `contents' member of Lisp_Vector objects with AREF and ASET
4366 where appropriate.
4367
c6bf3022
CY
43682012-06-19 Chong Yidong <cyd@gnu.org>
4369
4370 * frame.c (delete_frame): When selecting a frame on a different
4371 text terminal, do not alter the terminal's top-frame.
4372
4373 * xdisp.c (format_mode_line_unwind_data): Record the target
4374 frame's selected window and its terminal's top-frame.
4375 (unwind_format_mode_line): Restore them.
4376 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
4377 Callers changed.
4378 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
4379 since tty frames can be explicitly named.
4380 (prepare_menu_bars): Likewise.
4381
4382 * term.c (Ftty_top_frame): New function.
4383
defd4196
PE
43842012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4385
4386 Port byte-code-meter to modern targets.
4387 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
4388 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 4389 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
4390 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
4391 (METER_1, METER_2): Simplify.
4392
1053a871
SM
43932012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
4394
4395 * data.c (Fdefalias): Return `symbol' (bug#11686).
4396
b7e8d081
MR
43972012-06-18 Martin Rudalics <rudalics@gmx.at>
4398
4399 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
4400 gets killed during executing of this function (Bug#11665).
4401 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
4402 (Vkill_buffer_query_functions): In doc-string say that functions
4403 run by this hook should not change the current buffer.
4404
7ea2b339
PE
44052012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4406
4407 Fix recently-introduced process.c problems found by static checking.
4408 * process.c (write_queue_push, write_queue_pop, send_process):
4409 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
4410 (write_queue_pop): Fix pointer signedness problem.
4411 (send_process): Remove unused local.
4412
96a313a1
CY
44132012-06-17 Chong Yidong <cyd@gnu.org>
4414
4415 * xdisp.c (redisplay_internal): No need to redisplay terminal
4416 frames that are not on top.
4417
20ca2e94
TN
44182012-06-17 Troels Nielsen <bn.troels@gmail.com>
4419
4420 * process.c (make_process): Initialize write_queue.
4421 (write_queue_push, write_queue_pop): New functions.
4422 (send_process): Use them to maintain correct ordering of process
4423 writes (Bug#10815).
4424
9a900ca9
PE
44252012-06-17 Paul Eggert <eggert@cs.ucla.edu>
4426
310fbfa8
PE
4427 * lisp.h (eassert): Assume C89 or later.
4428 This removes the need for CHECK.
4429 (CHECK): Remove. Its comments about always evaluating its
4430 argument were confusing, as 'eassert' typically does not evaluate
4431 its argument.
4432
27bb1ca4
PE
4433 * coding.c (produce_chars): Use ptrdiff_t, not int.
4434
9a900ca9
PE
4435 * xterm.c (x_draw_underwave): Check for integer overflow.
4436 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
4437
41b7f8bc 44382012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
4439
4440 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
4441 referenced (Bug#11583).
4442
9b0e3eba
AA
44432012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
4444
4445 Implement wave-style variant of underlining.
4446 * dispextern.h (face_underline_type): New enum.
4447 (face): Add field for underline type.
4448 * nsterm.m (ns_draw_underwave): New function.
4449 (ns_draw_text_decoration): Use it.
4450 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
4451 New functions.
4452 (x_draw_glyph_string): Use them.
4453 * xfaces.c (Qline, Qwave): New Lisp objects.
4454 (check_lface_attrs, merge_face_ref)
1053a871
SM
4455 (Finternal_set_lisp_face_attribute, realize_x_face):
4456 Handle wave-style underline face attributes.
9b0e3eba
AA
4457 * xterm.c (x_draw_underwave): New function.
4458 (x_draw_glyph_string): Use it.
4459
0fb52f11
JB
44602012-06-16 Juanma Barranquero <lekktu@gmail.com>
4461
4462 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
4463 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
4464 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
4465 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
4466 ($(BLD)/w32select.$(O)): Update dependencies.
4467
e5560ff7
AS
44682012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4469
4470 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
4471 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
4472 * character.c (_fetch_multibyte_char_p): Remove.
4473 * alloc.c: Include "character.h" before "buffer.h".
4474 * bidi.c: Likewise.
4475 * buffer.c: Likewise.
4476 * bytecode.c: Likewise.
4477 * callint.c: Likewise.
4478 * callproc.c: Likewise.
4479 * casefiddle.c: Likewise.
4480 * casetab.c: Likewise.
4481 * category.c: Likewise.
4482 * cmds.c: Likewise.
4483 * coding.c: Likewise.
4484 * composite.c: Likewise.
4485 * dired.c: Likewise.
4486 * dispnew.c: Likewise.
4487 * doc.c: Likewise.
4488 * dosfns.c: Likewise.
4489 * editfns.c: Likewise.
4490 * emacs.c: Likewise.
4491 * fileio.c: Likewise.
4492 * filelock.c: Likewise.
4493 * font.c: Likewise.
4494 * fontset.c: Likewise.
4495 * fringe.c: Likewise.
4496 * indent.c: Likewise.
4497 * insdel.c: Likewise.
4498 * intervals.c: Likewise.
4499 * keyboard.c: Likewise.
4500 * keymap.c: Likewise.
4501 * lread.c: Likewise.
4502 * macros.c: Likewise.
4503 * marker.c: Likewise.
4504 * minibuf.c: Likewise.
4505 * nsfns.m: Likewise.
4506 * nsmenu.m: Likewise.
4507 * print.c: Likewise.
4508 * process.c: Likewise.
4509 * regex.c: Likewise.
4510 * region-cache.c: Likewise.
4511 * search.c: Likewise.
4512 * syntax.c: Likewise.
4513 * term.c: Likewise.
4514 * textprop.c: Likewise.
4515 * undo.c: Likewise.
4516 * unexsol.c: Likewise.
4517 * w16select.c: Likewise.
4518 * w32fns.c: Likewise.
4519 * w32menu.c: Likewise.
4520 * window.c: Likewise.
4521 * xdisp.c: Likewise.
4522 * xfns.c: Likewise.
4523 * xmenu.c: Likewise.
4524 * xml.c: Likewise.
4525 * xselect.c: Likewise.
4526
2f07e6af
EZ
45272012-06-16 Eli Zaretskii <eliz@gnu.org>
4528
1053a871
SM
4529 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
4530 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 4531 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
4532 row.
4533 (handle_face_prop): Use chunk-relative overlay string index when
4534 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
4535 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
4536 the rightmost. (Bug#11720)
2f07e6af 4537
29b83cec
AS
45382012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4539
4540 * category.h (CHAR_HAS_CATEGORY): Define as inline.
4541 (CATEGORY_MEMBER): Enforce 1/0 value.
4542 * category.c (_temp_category_set): Remove.
4543
4c5501e9
EZ
45442012-06-16 Eli Zaretskii <eliz@gnu.org>
4545
4546 * window.c (Fdelete_other_windows_internal)
4547 (Fdelete_window_internal): Don't access frame's mouse highlight
4548 info of the initial frame. (Bug#11677)
4549
2b570124
PE
45502012-06-14 Paul Eggert <eggert@cs.ucla.edu>
4551
e93864f9
PE
4552 * .gdbinit (xgetint): Fix recently-introduced paren typo.
4553 Assume USE_2_TAGS_FOR_INTS.
4554 (xreload): Adjust $tagmask width to match recent lisp.h change.
4555
2b570124
PE
4556 Simplify lisp.h in minor ways that should not affect code.
4557 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
4558 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
4559 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
4560 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
4561 (INTTYPEBITS): New macro, for clarity.
4562 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
4563 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
4564 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
4565 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
4566 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
4567
81755f69
JB
45682012-06-13 Juanma Barranquero <lekktu@gmail.com>
4569
4570 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
4571
16192a57
GM
45722012-06-13 Glenn Morris <rgm@gnu.org>
4573
4574 * s/bsd-common.h (BSD4_3):
4575 * s/usg5-4-common.h (USG5_4): No longer define; unused.
4576
646b5f55
AS
45772012-06-13 Andreas Schwab <schwab@linux-m68k.org>
4578
4579 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
4580 instead of union.
4581 (XLI, XIL): Define.
1053a871
SM
4582 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
4583 Use them.
4584 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 4585 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 4586 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
4587 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
4588 * frame.c (delete_frame): Remove outdated comment.
4589 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
4590 USE_LISP_UNION_TYPE.
4591 (Fw32_unregister_hot_key): Likewise.
4592 (Fw32_toggle_lock_key): Likewise.
4593 * w32menu.c (add_menu_item): Likewise.
4594 (w32_menu_display_help): Use XIL instead of checking
4595 USE_LISP_UNION_TYPE.
4596 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
4597 (init_heap): Likewise.
4598 * w32term.c (w32_read_socket): Update comment.
4599
1d3823c9
GM
46002012-06-13 Glenn Morris <rgm@gnu.org>
4601
c62ff706
GM
4602 * s/usg5-4-common.h, src/s/unixware.h:
4603 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
4604
1d3823c9
GM
4605 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
4606
bfe3e0a2
PE
46072012-06-13 Paul Eggert <eggert@cs.ucla.edu>
4608
4609 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
4610 * alloc.c (make_number) [!defined make_number]:
4611 Remove, as lisp.h always defines this now.
4612 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
4613 (roundup_size): Verify that it is a power of 2.
4614 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
4615 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
4616 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
4617 -DUSE_LSB_TAG=0, to override the automatically-selected default.
4618 USE_LSB_TAG now is always defined to be either 0 or 1.
4619 All uses changed.
4620 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
4621 code works fine either way, and efficiency is not a concern here,
4622 as the union type is for debugging, not for production.
4623 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
4624 Use an inline function on all platforms when using the union type,
4625 since this is simpler and 'static inline' can be used portably
4626 within Emacs now.
4627 (LISP_INITIALLY_ZERO): New macro.
4628 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
4629 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
4630
45fa9c0f
GM
46312012-06-12 Glenn Morris <rgm@gnu.org>
4632
b4492cba
GM
4633 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
4634
4635 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 4636
45fa9c0f
GM
4637 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
4638 Move BROKEN_SIGIO to configure.
4639
4640 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
4641 Move NO_TERMIO to configure.
4642
0e25d334
CY
46432012-06-12 Chong Yidong <cyd@gnu.org>
4644
4645 * image.c (imagemagick_load_image): Use MagickFlattenImage if
4646 MagickMergeImageLayers is undefined. Use pixel pusher loop if
4647 MagickExportImagePixels is undefined.
4648
43682bb6
PE
46492012-06-12 Paul Eggert <eggert@cs.ucla.edu>
4650
4651 * image.c (imagemagick_load_image): Remove unused label.
4652
a9be7d2b
GM
46532012-06-11 Glenn Morris <rgm@gnu.org>
4654
4655 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4656 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
4657 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
4658 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
4659
3017f87f
SM
46602012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
4661
4662 * alloc.c (make_byte_code): New function.
4663 (Fmake_byte_code): Use it. Don't purify here.
4664 * lread.c (read1): Use it as well to avoid extra allocation.
4665
1b9b4cf4
CY
46662012-06-11 Chong Yidong <cyd@gnu.org>
4667
4668 * image.c (imagemagick_load_image): Implement transparency.
4669
95988fcf
AS
46702012-06-10 Andreas Schwab <schwab@linux-m68k.org>
4671
4672 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
4673 account for preceding backslashes. (Bug#11663)
4674
cd4eb164
CY
46752012-06-09 Chong Yidong <cyd@gnu.org>
4676
4677 * term.c: Support italics in capable terminals (Bug#9652).
4678 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
4679 (turn_on_face): Output using TS_enter_italic_mode if available.
4680 Don't handle unused blinking and alt-charset cases.
4681 (turn_off_face): Handle italic case; discard unused tty_blinking_p
4682 and tty_alt_charset_p cases.
4683 (tty_capable_p, init_tty): Support italics.
4684
4685 * termchar.h (struct tty_display_info): Add field for italics.
4686 Remove unused blink field.
4687
4688 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
4689 Handle slant.
4690
4691 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
4692 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
4693 tty_alt_charset_p. Add tty_italic_p.
4694
ff88beb8
MA
46952012-06-09 Michael Albinus <michael.albinus@gmx.de>
4696
4697 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
4698 dbus_type_is_basic if available.
4699 (xd_extract_signed, xd_extract_unsigned): Rename from
4700 extract_signed and extract_unsigned, respectively. Adapt callers.
4701
44286096
CY
47022012-06-09 Chong Yidong <cyd@gnu.org>
4703
1682701f
CY
4704 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
4705
44286096
CY
4706 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
4707 case (Bug#9752).
4708
d86feb17
PE
47092012-06-08 Paul Eggert <eggert@cs.ucla.edu>
4710
4711 * xdisp.c (vmessage): Treat frame message as multibyte.
4712 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
4713 would generate the diagnostic "Making \302\247 buffer-local while
4714 let-bound!".
4715
d5c20fe8
EZ
47162012-06-08 Eli Zaretskii <eliz@gnu.org>
4717
4718 * dispnew.c (showing_window_margins_p): Undo last change, which
4719 was done due to an inadvertent commit.
4720 (adjust_frame_glyphs_for_frame_redisplay): Do call
4721 showing_window_margins_p.
4722
513749ee
SM
47232012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4724
4725 * eval.c (Fmake_var_non_special): New primitive.
4726 (syms_of_eval): Defsubr it.
4727 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
4728
d4a8f5c1
JB
47292012-06-08 Juanma Barranquero <lekktu@gmail.com>
4730
4731 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
4732 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
4733
8bbbc977
EZ
47342012-06-08 Eli Zaretskii <eliz@gnu.org>
4735
4736 * alloc.c (allocate_vectorlike): Fix last change.
4737
f3372c87
DA
47382012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
4739
4740 Block-based vector allocation of small vectors.
4741 * lisp.h (struct vectorlike_header): New field `nbytes',
4742 adjust comment accordingly.
4743 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
4744 to denote vector blocks. Adjust users (live_vector_p,
4745 mark_maybe_pointer, valid_lisp_object_p) accordingly.
4746 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
4747 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
4748 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
4749 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
4750 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
4751 (roundup_size): New constant.
4752 (struct vector_block): New data type.
4753 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 4754 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
4755 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
4756 (sweep_vectors): New functions.
4757 (allocate_vectorlike): Return `zero_vector' as the only vector of
4758 0 items. Allocate new vector from block if vector size is less than
4759 or equal to VBLOCK_BYTES_MAX.
4760 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
4761 (init_alloc_once): Add call to init_vectors.
4762
4f18a4ed
SM
47632012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4764
4765 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
4766
86f158bc
PE
47672012-06-07 Paul Eggert <eggert@cs.ucla.edu>
4768
4769 * doprnt.c (doprnt): Truncate multibyte char correctly.
4770 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
4771 would mishandle a string argument "Xc" if X was a multibyte
4772 character of length 2: it would truncate after X's first byte
4773 rather than including all of X.
4774
c5cfcbe0
CY
47752012-06-06 Chong Yidong <cyd@gnu.org>
4776
4777 * buffer.c (word_wrap): Doc fix.
4778
c05cf390
PE
47792012-06-04 Paul Eggert <eggert@cs.ucla.edu>
4780
4781 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
4782
0c3461de
GM
47832012-06-03 Glenn Morris <rgm@gnu.org>
4784
4785 * xdisp.c (tool-bar-style): Doc fix.
4786
c71232db
UM
47872012-06-03 Ulrich Müller <ulm@gentoo.org>
4788
4789 * Makefile.in (PAXCTL): Define.
4790 (temacs$(EXEEXT)): Disable memory randomization for the temacs
4791 binary via PaX flags if the paxctl utility is available.
4792 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
4793 Restore PaX flags to their default. (Bug#11398)
4794
383f7350
CY
47952012-06-03 Chong Yidong <cyd@gnu.org>
4796
4797 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
4798 buffer (Bug#11226).
4799
5f2c76c6
CY
48002012-06-03 Chong Yidong <cyd@gnu.org>
4801
4802 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
4803 (note_mode_line_or_margin_highlight): If there is no help echo,
4804 use mode-line-default-help-echo. Handle the case where the mouse
4805 position is past the end of the mode line string.
4806
4807 * buffer.c (buffer_local_value_1): New function, split from
4808 Fbuffer_local_value; can return Qunbound.
4809 (Fbuffer_local_value): Use it.
4810 (Vmode_line_format): Docstring tweaks.
4811
773d47f6
PE
48122012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4813
4814 * sysdep.c (system_process_attributes): Improve comment.
4815
f2d6a3df
SM
48162012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
4817
4818 * keyboard.c: Export real-this-command to Elisp.
4819 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
4820 and DEFVAR it. Update all users.
4821
63810350
PE
48222012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4823
7bd5c1f4
PE
4824 * minibuf.c (Fassoc_string): Remove duplicate declaration.
4825
63810350
PE
4826 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
4827 Convert pctcpu and pctmem to Lisp float properly.
4828 Let the compiler fold better, as 100.0/0x8000 is exact.
4829
a2821611
AS
48302012-06-02 Andreas Schwab <schwab@linux-m68k.org>
4831
4832 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
4833 cons_block.
4834
5fceba1d
PE
48352012-06-01 Paul Eggert <eggert@cs.ucla.edu>
4836
4837 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
4838
c98ff5dd
DA
48392012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
4840
4841 For a 'struct window', replace some Lisp_Object fields to
4842 bitfields where appropriate, remove unused fields.
4843 * window.h (struct window): Remove unused 'last_mark_x' and
4844 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
4845 change it's type from Lisp_Object to bitfield.
4846 Change type of 'force_start', 'optional_new_start',
4847 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
4848 fields from Lisp_Object to bitfield. Adjust users accordingly.
4849
ca34e0be
PE
48502012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4851
4852 Pacify gcc -Wdouble-precision when using Xaw.
4853 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
4854 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
4855 Use 'float' consistently, rather than 'float' in most places
4856 and 'double' in a couple of places.
4857
efc00ab1 48582012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
4859
4860 * xdisp.c (handle_stop): Detect whether we have overlay strings
4861 loaded by testing it->current.overlay_string_index to be
4862 non-negative, instead of checking whether n_overlay_strings is
4863 positive. (Bug#11587)
4864
efc00ab1 48652012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
4866
4867 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
4868
4869 * doc.c (Fsubstitute_command_keys): Doc fix.
4870
efc00ab1 48712012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
4872
4873 * search.c (search_buffer): Remove calls to
4874 r_alloc_inhibit_buffer_relocation, as it is now called by
4875 maybe_unify_char, which was the cause of relocation of buffer text
4876 in bug#11519.
4877
efc00ab1 48782012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
4879
4880 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4881 for the duration of call to load_charset, to avoid problems with
4882 callers of maybe_unify_char that access buffer text through C
4883 pointers.
4884
4885 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
4886 decrement the inhibition flag, instead of just setting or
4887 resetting it.
4888
ba93a187
PE
48892012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4890
4891 Remove obsolete '#define static' cruft.
4892 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
4893 This #undef was "temporary" in 2000; it is no longer needed
4894 now that '#define static' has gone away.
4895 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
4896 (gray_bitmap_bits): Remove; no longer needed.
4897 All uses replaced with definiens.
4898 * xterm.c: Include "bitmaps/gray.xbm".
4899
9e4bf381
PE
49002012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4901
4902 Clean up __executable_start, monstartup when --enable-profiling.
4903 The following changes affect the code only when profiling.
4904 * dispnew.c (__executable_start): Rename from safe_bcopy.
4905 Define only on platforms that need it.
4906 * emacs.c: Include <sys/gmon.h> when profiling.
4907 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4908 (__executable_start): Remove decl, since lisp.h does it now.
4909 (safe_bcopy): Remove decl; no longer has that name.
4910 (main): Coalesce #if into single bit of code, for simplicity.
4911 Cast pointers to uintptr_t, since standard libraries want integers
4912 and not pointers.
4913 * lisp.h (__executable_start): New decl.
4914
32d72c2f
GM
49152012-05-31 Glenn Morris <rgm@gnu.org>
4916
4917 * image.c (Fimagemagick_types): Doc fix.
4918
baac5bc7
JM
49192012-05-30 Jim Meyering <meyering@redhat.com>
4920
4921 * callproc.c (Fcall_process_region): Include directory component
4922 in mkstemp error message (Bug#11586).
4923
72cb32cf
PE
49242012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4925
4926 * alloc.c, lisp.h (make_pure_vector): Now static.
4927
61b108cc
SM
49282012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4929
4930 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4931 Move to byte-run.el.
4932 (Fautoload): Do the hash-doc more carefully.
4933 * data.c (Fdefalias): Purify definition, except for keymaps.
4934 (Qdefun): Move from eval.c.
4935 * lisp.h (Qdefun): Remove.
4936 * lread.c (read1): Tiny simplification.
4937
471fe23d
TN
49382012-05-29 Troels Nielsen <bn.troels@gmail.com>
4939
934f3f58 4940 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4941 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4942 Bug#9642, but explicitly check that the buffer the overlay would
4943 be moved to is live and rearrange lines to make sure that errors
4944 will not put the overlay in an inconsistent state.
4945 (Fdelete_overlay): Cosmetics.
4946
85d0efd1
EZ
49472012-05-28 Eli Zaretskii <eliz@gnu.org>
4948
4949 * w32term.c (my_bring_window_to_top): New function.
4950 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4951 could be different from the original one.
4952 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4953 (Bug#11513)
4954
4955 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4956 by calling BringWindowToTop.
4957
4958 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4959 (WM_EMACS_END): Increase by one.
4960
da92a98c
PE
49612012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4962
4963 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4964 This avoids undefined behavior that might cause the eassert
4965 to not catch an out-of-range value.
4966
74d1f848
JB
49672012-05-28 Juanma Barranquero <lekktu@gmail.com>
4968
4969 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4970 Update dependencies.
4971
9e1a06fc
EZ
49722012-05-27 Eli Zaretskii <eliz@gnu.org>
4973
4974 * bidi.c (bidi_mirror_char): Fix last change.
4975
f3dd7312
AS
49762012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4977
4978 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4979 when referring to sectname field in printf format.
4980
81899c91
PE
49812012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4982
57b81a9f
PE
4983 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4984 Only r_alloc_inhibit_buffer_relocation needed to be added;
4985 the others were already declared.
4986
81899c91
PE
4987 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4988 before checking whether it's out of range. Put the check inside
4989 eassert. See
4990 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4991
33017faf 49922012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4993
4994 * callproc.c (Fcall_process): Restore a line that was accidentally
4995 commented out in the 2011-02-13 change (bug#11547).
4996
33017faf 49972012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4998
4999 * lisp.h [REL_ALLOC]: Add prototypes for external functions
5000 defined on ralloc.c.
5001
5002 * buffer.c [REL_ALLOC]: Remove prototypes of
5003 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
5004 they are now on lisp.h.
5005
5006 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
5007
5008 * search.c (search_buffer): Use it to inhibit relocation of buffer
5009 text while re_search_2 is doing its job, because re_search_2 is
5010 passed C pointers to buffer text. (Bug#11519)
5011
23415acf
EZ
5012 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
5013 Update value to 24.
5014
44e27368
EZ
5015 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
5016 state after an additional call to move_it_in_display_line_to, keep
5017 the values of it->max_ascent and it->max_descent found for the
5018 entire line.
5019 (pos_visible_p): Revert the comparison against bottom_y to what it
5020 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
5021 (Bug#11464)
5022
c1892f11
PE
50232012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5024
5025 Fix coding-related core dumps with gcc -ftrapv.
5026 The code was computing A - B, where A and B are pointers, and B is
5027 random garbage. This can lead to core dumps on platforms that
5028 have special pointer registers, and it also leads to core dumps on
5029 x86-64 when compiled with gcc -ftrapv. The fix is to compute
5030 A - B only when B is initialized properly.
5031 * coding.c (coding_set_source, coding_set_destination): Return void.
5032 (coding_change_source, coding_change_destinations): New functions,
5033 with the old behaviors of coding_set_source and coding_set_destination.
5034 All callers that need an offset changed to use these new functions.
5035
eb7afdad
GM
50362012-05-26 Glenn Morris <rgm@gnu.org>
5037
5038 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5039
f12fdf02
EZ
50402012-05-26 Eli Zaretskii <eliz@gnu.org>
5041
53a63be6 5042 Extend mouse support on W32 text-mode console.
61b108cc
SM
5043 * xdisp.c (draw_row_with_mouse_face):
5044 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 5045
eb3f6f01 5046 * w32console.c: Include window.h.
61b108cc
SM
5047 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
5048 New functions.
eb3f6f01
EZ
5049 (initialize_w32_display): Initialize mouse-highlight data.
5050
53a63be6
EZ
5051 * w32inevt.c: Include termchar.h and window.h.
5052 (do_mouse_event): Support mouse-autoselect-window. When the mouse
5053 moves, call note_mouse_highlight. If help_echo changed, call
5054 gen_help_event to produce help-echo message in the echo area.
5055 Call clear_mouse_face if mouse_face_hidden is set in the mouse
5056 highlight info.
5057
4cfd81f6
PE
50582012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5059
5060 * lread.c (read1): Simplify slightly to avoid an overflow warning
5061 with GCC 4.7.0 on x86-64.
5062
4446092a
EZ
50632012-05-26 Eli Zaretskii <eliz@gnu.org>
5064
5065 * bidi.c (bidi_mirror_char): Revert last change: an int is
5066 definitely wide enough here.
5067
42b2a986 50682012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 5069
42b2a986 5070 Fix integer width and related bugs (Bug#9874).
eb106a49 5071 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5072 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5073 (string_bytes, check_sblock, allocate_string_data):
5074 (compact_small_strings, Fmake_bool_vector, make_string)
5075 (make_unibyte_string, make_multibyte_string)
5076 (make_string_from_bytes, make_specified_string)
5077 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
5078 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
5079 (mark_vectorlike):
5080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5081 (allocate_pseudovector):
5082 Use int, not EMACS_INT, where int is wide enough.
5083 (inhibit_garbage_collection, Fgarbage_collect):
5084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5085 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
5086 int might not be wide enough.
5087 (bidi_cache_search, bidi_cache_find, bidi_init_it)
5088 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
5089 (bidi_at_paragraph_end, bidi_find_paragraph_start)
5090 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5091 (bidi_level_of_next_char, bidi_move_to_visually_next):
5092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5093 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
5094 (Fkill_buffer, Fset_buffer_major_mode)
5095 (advance_to_char_boundary, Fbuffer_swap_text)
5096 (Fset_buffer_multibyte, overlays_at, overlays_in)
5097 (overlay_touches_p, struct sortvec, record_overlay_string)
5098 (overlay_strings, recenter_overlay_lists)
5099 (adjust_overlays_for_insert, adjust_overlays_for_delete)
5100 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
5101 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
5102 (Foverlay_recenter, last_overlay_modification_hooks_used)
5103 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
5104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
5105 (validate_region): Omit unnecessary test for b <= e,
5106 since that's guaranteed by the previous test.
d311d28c
PE
5107 (adjust_overlays_for_delete): Avoid pos + length overflow.
5108 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
5109 (report_overlay_modification):
5110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5111 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
5112 Omit pointer cast, which isn't needed anyway, and doesn't work
5113 after the EMACS_INT -> ptrdiff_t change.
02481186 5114 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
5115 * buffer.h: Adjust decls to match defn changes elsewhere.
5116 (struct buffer_text, struct buffer):
5117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5118 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
5119 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
5120 not int, to avoid needless 32-bit limit on 64-bit hosts.
5121 (exec_byte_code): Use tighter memory-full test, one that checks
5122 for alloca overflow. Don't compute the address of the object just
5123 before an array, as that's not portable. Use EMACS_INT, not
5124 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
5125 * callint.c (Fcall_interactively):
5126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5127 * callproc.c (call_process_kill, Fcall_process):
5128 Don't assume pid_t fits into an Emacs fixnum.
5129 (call_process_cleanup, Fcall_process, child_setup):
5130 Don't assume pid_t fits into int.
5131 (call_process_cleanup, Fcall_process, delete_temp_file)
5132 (Fcall_process_region):
5133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5134 (Fcall_process): Simplify handling of volatile integers.
5135 Use int, not EMACS_INT, where int will do.
5136 * casefiddle.c (casify_object, casify_region, operate_on_word)
5137 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
5138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5139 (casify_object): Avoid integer overflow when overallocating buffer.
5140 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 5141 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
5142 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
5143 * category.h (CATEGORYP): Don't assume arg is nonnegative.
5144 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
5145 integers are now checked earlier. All uses replaced with XINT.
5146 (ccl_driver):
5147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5148 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
5149 (ccl_driver, Fregister_code_conversion_map):
5150 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
5151 (resolve_symbol_ccl_program): Check that vector header is in range.
5152 Always copy the vector, so that we can check its contents reliably
5153 now rather than having to recheck each instruction as it's being
5154 executed. Check that vector words fit in 'int'.
5155 (ccl_get_compiled_code, Fregister_ccl_program)
5156 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
5157 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
5158 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
5159 contents are in range.
5160 (Fccl_execute_on_string): Check that status is in range.
5161 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
5162 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
5163 Accept and return EMACS_INT, not int, because callers can pass values
5164 out of 'int' range.
5165 (c_string_width, strwidth, lisp_string_width, chars_in_text)
5166 (multibyte_chars_in_text, parse_str_as_multibyte)
5167 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
5168 (str_as_unibyte, str_to_unibyte, string_count_byte8)
5169 (string_escape_byte8, Fget_byte):
5170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 5171 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
5172 avoid mishandling large integers.
5173 * character.h: Adjust decls to match defn changes elsewhere.
5174 * charset.c (load_charset_map_from_file, find_charsets_in_text)
5175 (Ffind_charset_region):
5176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5177 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
5178 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 5179 Don't assume fixnum fits in int.
d311d28c
PE
5180 (load_charset_map_from_vector, Fmap_charset_chars):
5181 Remove now-unnecessary CHECK_NATNUMs.
5182 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
5183 Don't rely on undefined behavior with signed left shift overflow.
5184 Don't assume unsigned int fits into fixnum, or that fixnum fits
5185 into unsigned int. Don't require max_code to be a valid fixnum;
5186 that's not true for gb10830 4-byte on a 32-bit host. Allow
5187 invalid_code to be a cons, for the same reason. Require code_offset
5188 to be a character. Avoid int overflow if max_char is close
5189 to INT_MAX.
5190 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
5191 this is intended anyway and avoids some undefined behavior.
5192 (load_charset_map): Pass unsigned, not int, as 2nd arg of
5193 INDEX_TO_CODE_POINT, as that's what it expects.
5194 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
5195 * charset.h (DECODE_CHAR): Return int, not unsigned;
5196 this is what was intended anyway, and it avoids undefined behavior.
5197 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
5198 integer-overflow issues.
5199 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
5200 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
5201 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
5202 * chartab.c (Fmake_char_table, Fset_char_table_range)
5203 (uniprop_get_decoder, uniprop_get_encoder):
5204 Don't assume fixnum fits in int.
5205 * cmds.c (move_point): New function, that does the gist of
5206 Fforward_char and Fbackward_char, but does so while checking
5207 for integer overflow more accurately.
c96e5d6a 5208 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
5209 (Fforward_line, Fend_of_line, internal_self_insert)
5210 (internal_self_insert):
5211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5212 Fix a FIXME, by checking for integer overflow when calculating
5213 target_clm and actual_clm.
5214 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 5215 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
5216 (ASSURE_DESTINATION, coding_alloc_by_realloc)
5217 (coding_alloc_by_making_gap, alloc_destination)
5218 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
5219 (encode_coding_utf_16, detect_coding_emacs_mule)
5220 (decode_coding_emacs_mule, encode_coding_emacs_mule)
5221 (detect_coding_iso_2022, decode_coding_iso_2022)
5222 (encode_invocation_designation, encode_designation_at_bol)
5223 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5224 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
5225 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
5226 (encode_coding_ccl, encode_coding_raw_text)
5227 (detect_coding_charset, decode_coding_charset)
5228 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
5229 (produce_composition, produce_charset, produce_annotation)
5230 (decode_coding, handle_composition_annotation)
5231 (handle_charset_annotation, consume_chars, decode_coding_gap)
5232 (decode_coding_object, encode_coding_object, detect_coding_system)
5233 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
5234 (code_convert_region, code_convert_string)
8f50130c
PE
5235 (Fdefine_coding_system_internal)
5236 (coding_set_source, coding_set_destination):
d311d28c
PE
5237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5238 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
5239 (Fdefine_coding_system_internal):
5240 Don't assume fixnums fit in int.
5241 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 5242 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
5243 (Funencodable_char_position, Fcheck_coding_systems_region)
5244 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 5245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 5246 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 5247 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 5248 Don't access memory outside of the args array.
d311d28c 5249 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
5250 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
5251 result of ENCODE_CHAR.
d311d28c
PE
5252 * coding.h: Adjust decls to match defn changes elsewhere.
5253 (struct coding_system):
5254 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5255 * composite.c (get_composition_id, find_composition)
5256 (run_composition_function, update_compositions)
5257 (compose_text, composition_gstring_put_cache)
5258 (composition_gstring_p, composition_gstring_width)
5259 (fill_gstring_header, fill_gstring_body, autocmp_chars)
5260 (composition_compute_stop_pos, composition_reseat_it)
5261 (composition_update_it, struct position_record)
5262 (find_automatic_composition, composition_adjust_point)
5263 (Fcomposition_get_gstring, Ffind_composition_internal):
5264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5265 (update_compositions):
5266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5267 * composite.h: Adjust decls to match defn changes elsewhere.
5268 (struct composition):
5269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5270 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
5271 Do not attempt to compute the address of the object just before a
5272 buffer; this is not portable.
5273 (Faref, Faset):
5274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5275 (Faset): Use int, not EMACS_INT, where int is wide enough.
5276 (Fstring_to_number): Don't assume fixnums fit in int.
5277 (Frem): Don't assume arg is nonnegative.
5278 * dbusbind.c (xd_append_arg): Check for integers out of range.
5279 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 5280 (extract_signed, extract_unsigned): New functions.
243e0530
PE
5281 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
5282 (xd_get_connection_references): Return ptrdiff_t, not int.
5283 All uses changed.
5284 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
5285 (xd_read_message_1):
5286 Use int, not unsigned, where the dbus API uses int.
5287 (Fdbus_message_internal): Don't overflow mtype.
5288 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
5289 * dired.c (directory_files_internal, file_name_completion, scmp)
5290 (file_name_completion_stat):
5291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5292 (file_name_completion): Don't overflow matchcount.
5293 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
5294 * dispextern.h: Adjust decls to match defn changes elsewhere.
5295 (struct text_pos, struct glyph, struct bidi_saved_info)
5296 (struct bidi_string_data, struct bidi_it, struct composition_it)
5297 (struct it):
5298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5299 (struct display_pos, struct composition_it, struct it):
5300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5301 * dispnew.c (increment_matrix_positions)
5302 (increment_row_positions, mode_line_string)
5303 (marginal_area_string):
5304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 5305 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
5306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5307 (duration_to_sec_usec): New function, to check for overflow better.
5308 (Fsleep_for, sit_for): Use it.
5309 * doc.c (get_doc_string, store_function_docstring):
5310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5311 (get_doc_string, Fsnarf_documentation):
5312 Use int, not EMACS_INT, where int is wide enough.
5313 (get_doc_string):
5314 Use SAFE_ALLOCA, not alloca.
5315 Check for overflow when converting EMACS_INT to off_t.
5316 * doprnt.c (doprnt):
5317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5318 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
5319 Don't assume uid_t fits into fixnum.
5320 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
5321 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
5322 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
5323 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
5324 (general_insert_function)
5325 (Finsert_char, make_buffer_string, make_buffer_string_both)
5326 (update_buffer_properties, Fbuffer_substring)
5327 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
5328 (Fsubst_char_in_region, check_translation)
5329 (Ftranslate_region_internal, save_restriction_restore, Fformat)
5330 (transpose_markers, Ftranspose_regions):
5331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5332 (clip_to_bounds): Move to lisp.h as an inline function).
5333 (Fconstrain_to_field): Don't assume integers are nonnegative.
5334 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
5335 (Fsubst_char_in_region, Fsave_restriction):
5336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5337 (Femacs_pid): Don't assume pid_t fits into fixnum.
5338 (lo_time): Use int, not EMACS_INT, when int suffices.
5339 (lisp_time_argument): Check for usec out of range.
5340 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
5341 (Fuser_login_name, Fuser_full_name): Signal an error
5342 if a uid argument is out of range, rather than relying on
5343 undefined behavior.
c8d5c857
PE
5344 (Fformat_time_string): Remove now-unnecessary check.
5345 lisp_time_argument checks for out-of-range usec now.
243e0530 5346 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
5347 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
5348 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
5349 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
5350 (init_cmdargs, Fdump_emacs):
5351 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5352 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
5353 the bottom (typically) 32 bits of the fixnum.
5354 * eval.c (specpdl_size, call_debugger):
5355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5356 (when_entered_debugger, Fbacktrace_debug):
5357 Don't assume fixnum can fit in int.
5358 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
5359 the object just before a buffer; this is not portable.
5360 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
5361 (grow_specpdl, unbind_to):
5362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5363 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
5364 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 5365 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
5366 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
5367 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
5368 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5369 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
5370 (a_write, e_write):
5371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5372 (Fcopy_file, non_regular_nbytes, read_non_regular)
5373 (Finsert_file_contents):
5374 Use int, not EMACS_INT, where int is wide enough.
5375 (READ_BUF_SIZE): Verify that it fits in int.
5376 (Finsert_file_contents): Check that counts are in proper range,
5377 rather than assuming fixnums fit into ptrdiff_t etc.
5378 Don't assume fixnums fit into int.
125b3835 5379 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
5380 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
5381 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
5382 (string_char_to_byte, string_byte_to_char)
5383 (string_make_multibyte, string_to_multibyte)
5384 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
5385 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
5386 (substring_both, Fdelete, internal_equal, Ffillarray)
5387 (Fclear_string, mapcar1)
5388 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
5389 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
5390 (larger_vector, make_hash_table, maybe_resize_hash_table)
5391 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
5392 (Fmaphash, secure_hash):
5393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5394 (concat): Check for string index and length overflow.
5395 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
5396 (Frequire):
5397 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5398 (larger_vector): New API (vec, incr_min, size_max) replaces old
5399 one (vec, new_size, init). This catches size overflow.
5400 INIT was removed because it was always Qnil.
5401 All callers changed.
5402 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
5403 the upper bound on a hash table index size.
5404 (make_hash_table, maybe_resize_hash_table): Use it.
5405 (secure_hash): Computer start_byte and end_byte only after
5406 they're known to be in ptrdiff_t range.
5407 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
5408 (Ffont_get_glyphs, Ffont_at):
5409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5410 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
5411 (Flist_fonts, Fopen_font):
5412 Don't assume fixnum can fit in int.
5413 (check_gstring): Don't assume index can fit in int.
5414 (font_match_p): Check that fixnum is a character, not a nonnegative
5415 fixnum, since the later code needs to stuff it into an int.
5416 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
5417 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
5418 conversion overflow issues.
5419 (Fopen_font): Check for integer out of range.
5420 (Ffont_get_glyphs): Don't assume index can fit in int.
5421 * font.h: Adjust decls to match defn changes elsewhere.
5422 * fontset.c (reorder_font_vector): Redo score calculation to avoid
5423 integer overflow.
5424 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
5425 printmax_t, where ptrdiff_t is wide enough.
5426 (Finternal_char_font):
5427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5428 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
5429 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
5430 (Fset_frame_position, x_set_frame_parameters)
5431 (x_set_line_spacing, x_set_border_width)
5432 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
5433 Check that fixnums are in proper range for system types.
5434 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
5435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5436 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
5437 Use SAFE_ALLOCA_LISP, not alloca.
5438 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
5439 intptr_t is wide enough.
5440 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
5441 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
5442 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
5443 Check for fixnum out of range.
5444 * ftfont.c (ftfont_list): Don't assume index fits in int.
5445 Check that fixnums are in proper range for system types.
5446 (ftfont_shape_by_flt):
5447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
5448 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5450 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
5451 Check that fixnums are in proper range for system types.
5452 * gnutls.h: Adjust decls to match defn changes elsewhere.
5453 * gtkutil.c (xg_dialog_run):
5454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5455 (update_frame_tool_bar):
5456 Check that fixnums are in proper range for system types.
5457 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 5458 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
5459 * indent.c (last_known_column, last_known_column_point):
5460 (current_column_bol_cache):
5461 (skip_invisible, current_column, check_display_width):
5462 (check_display_width, scan_for_column, current_column_1)
5463 (Findent_to, Fcurrent_indentation, position_indentation)
5464 (indented_beyond_p, Fmove_to_column, compute_motion):
5465 (Fcompute_motion, Fvertical_motion):
5466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5467 (last_known_column_modified): Use EMACS_INT, not int.
5468 (check_display_width):
5469 (Fcompute_motion):
5470 Check that fixnums and floats are in proper range for system types.
5471 (compute_motion): Don't assume index or fixnum fits in int.
5472 (compute_motion, Fcompute_motion):
5473 Use int, not EMACS_INT, when it is wide enough.
5474 (vmotion): Omit local var start_hpos that is always 0; that way
5475 we don't need to worry about overflow in expressions involving it.
5476 * indent.h: Adjust decls to match defn changes elsewhere.
5477 (struct position):
5478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5479 Use int, not EMACS_INT, where int is wide enough.
5480 Remove unused members ovstring_chars_done and tab_offset;
5481 all uses removed.
5482 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
5483 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
5484 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
5485 (make_gap, copy_text, insert, insert_and_inherit)
5486 (insert_before_markers, insert_before_markers_and_inherit)
5487 (insert_1, count_combining_before, count_combining_after)
5488 (insert_1_both, insert_from_string)
5489 (insert_from_string_before_markers, insert_from_string_1)
5490 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
5491 (adjust_after_replace, adjust_after_insert, replace_range)
5492 (replace_range_2, del_range, del_range_1, del_range_byte)
5493 (del_range_both, del_range_2, modify_region)
5494 (prepare_to_modify_buffer, signal_before_change)
5495 (signal_after_change, Fcombine_after_change_execute):
5496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5497 * intervals.c (traverse_intervals, rotate_right, rotate_left)
5498 (balance_an_interval, split_interval_right, split_interval_left)
5499 (find_interval, next_interval, update_interval)
5500 (adjust_intervals_for_insertion, delete_node, delete_interval)
5501 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5502 (static_offset_intervals, offset_intervals)
5503 (merge_interval_right, merge_interval_left, make_new_interval)
5504 (graft_intervals_into_buffer, temp_set_point_both)
5505 (temp_set_point, set_point, adjust_for_invis_intang)
5506 (set_point_both, move_if_not_intangible, get_property_and_range)
5507 (get_local_map, copy_intervals, copy_intervals_to_string)
5508 (compare_string_intervals, set_intervals_multibyte_1):
5509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5510 * intervals.h: Adjust decls to match defn changes elsewhere.
5511 (struct interval):
5512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5513 * keyboard.c (this_command_key_count, this_single_command_key_start)
5514 (before_command_key_count, before_command_echo_length, echo_now)
5515 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
5516 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
5517 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
5518 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
5519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5520 (last_non_minibuf_size, last_point_position, echo_truncate)
5521 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
5522 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
5523 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
5524 (stuff_buffered_input):
5525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5526 (last_auto_save, command_loop_1, read_char):
5527 Use EMACS_INT, not int, to avoid integer overflow.
5528 (record_char): Avoid overflow in total_keys computation.
5529 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
5530 * keyboard.h: Adjust decls to match defn changes elsewhere.
5531 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
5532 (Fkey_description, Fdescribe_vector, Flookup_key):
5533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5534 (click_position): New function, to check that positions are in range.
5535 (Fcurrent_active_maps):
5536 (describe_command):
5537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5538 (Faccessible_keymaps, Fkey_description):
5539 (preferred_sequence_p):
5540 Don't assume fixnum can fit into int.
5541 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
5542 Check for integer overflow in size calculations.
5543 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
5544 avoid mishandling large integers.
5545 * lisp.h: Adjust decls to match defn changes elsewhere.
5546 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
5547 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
5548 (struct Lisp_Marker):
5549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5550 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
5551 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
5552 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
5553 All callers changed.
5554 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
5555 Assume the arg has valid form, since it always does.
5556 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
5557 unsigned integer system type.
5558 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
5559 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
5560 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5561 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
5562 (duration_to_sec_usec): New decl.
5563 * lread.c (read_from_string_index, read_from_string_index_byte)
5564 (read_from_string_limit, readchar, unreadchar, openp)
5565 (read_internal_start, read1, oblookup):
5566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5567 (Fload, readevalloop, Feval_buffer, Feval_region):
5568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5569 (openp): Check for out-of-range argument to 'access'.
5570 (read1): Use int, not EMACS_INT, where int is wide enough.
5571 Don't assume fixnum fits into int.
6efdadfd 5572 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
5573 (read_filtered_event): Use duration_to_sec_usec
5574 to do proper overflow checking on durations.
d311d28c
PE
5575 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
5576 in size calculation.
5577 (Fexecute_kbd_macro):
5578 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5579 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
5580 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
5581 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
5582 (set_marker_both, set_marker_restricted_both, marker_position)
5583 (marker_byte_position, Fbuffer_has_markers_at):
5584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5585 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 5586 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
5587 It now merely ensures that the menu is large enough, without
5588 necessarily growing it, as this avoids some integer overflow issues.
5589 All callers changed.
5590 (keymap_panes, parse_single_submenu, Fx_popup_menu):
5591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5592 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
5593 Use SAFE_ALLOCA_LISP, not alloca.
5594 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
5595 to EMACS_INT. Check that fixnums are in proper range for system types.
5596 * minibuf.c (minibuf_prompt_width, string_to_object)
5597 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
5598 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
5599 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5600 (get_minibuffer, read_minibuf_unwind):
5601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5602 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
5603 this simplifies overflow checking. All callers changed.
5604 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
5605 (Ftest_completion):
5606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5607 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
5608 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
5609 Check that fixnums are in proper range for system types.
5610 (Fx_create_frame, Fx_show_tip):
5611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5612 * nsfont.m (ns_findfonts, nsfont_list_family):
5613 Don't assume fixnum fits in long.
5614 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
5615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5616 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
5617 wide enough.
17fdb222 5618 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
5619 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5620 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
5621 (PRINTDECLARE, PRINTPREPARE):
5622 (strout, print_string):
5623 (print, print_preprocess, print_check_string_charset_prop)
5624 (print_object):
5625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5626 (PRINTDECLARE):
5627 (temp_output_buffer_setup, Fprin1_to_string, print_object):
5628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5629 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 5630 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 5631 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
5632 (print_error_message): Use SAFE_ALLOCA, not alloca.
5633 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
5634 (print_depth, new_backquote_output, print_number_index):
5635 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
5636 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
5637 (Fset_process_window_size, Fformat_network_address)
5638 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 5639 (sigchld_handler):
d311d28c 5640 Check that fixnums are in proper range for system types.
d44287d4 5641 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
5642 Check for process-ids out of pid_t range rather than relying on
5643 undefined behavior.
e4d81efc 5644 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
5645 (Fformat_network_address, read_process_output, send_process)
5646 (Fprocess_send_region, status_notify):
5647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5648 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
5649 (wait_reading_process_output, read_process_output, exec_sentinel):
5650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5651 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
5652 (Faccept_process_output): Use duration_to_sec_usec to do proper
5653 overflow checking on durations.
dde14581
PE
5654 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
5655 Don't assume pid_t fits in int.
02481186
PE
5656 * process.h (struct Lisp_Process): Members tick and update_tick
5657 are now of type EMACS_INT, not int.
b62b53e8
PE
5658 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
5659 configured --with-wide-int.
d311d28c
PE
5660 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
5661 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
5662 * search.c (looking_at_1, string_match_1):
5663 (fast_string_match, fast_c_string_match_ignore_case)
5664 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
5665 (scan_newline, find_before_next_newline, search_command)
5666 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
5667 (set_search_regs, wordify):
5668 (Freplace_match):
5669 (Fmatch_data):
5670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5671 (string_match_1, search_buffer, set_search_regs):
5672 (Fmatch_data):
5673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5674 (wordify): Check for overflow in size calculation.
5675 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
5676 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
5677 Check that fixnums are in proper range for system types.
5678 * sound.c (struct sound_device)
5679 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
5680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5681 (Fplay_sound_internal):
5682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 5683 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
5684 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
5685 (Fparse_partial_sexp):
5686 Don't assume fixnums can fit in int.
5687 (struct lisp_parse_state, find_start_pos, find_start_value)
5688 (find_start_value_byte, find_start_begv)
5689 (update_syntax_table, char_quoted, dec_bytepos)
5690 (find_defun_start, prev_char_comend_first, back_comment):
5691 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
5692 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
5693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5694 (Finternal_describe_syntax_value): Check that match_lisp is a
5695 character, not an integer, since the code stuffs it into int.
5696 (scan_words, scan_sexps_forward):
5697 Check that fixnums are in proper range for system types.
5698 (Fforward_word):
5699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5700 (scan_sexps_forward):
5701 Use CHARACTERP, not INTEGERP, since the value must fit into int.
5702 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
5703 * syntax.h: Adjust decls to match defn changes elsewhere.
5704 (struct gl_state_s):
5705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
5706 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
5707 MOST_POSITIVE_FIXNUM.
d311d28c
PE
5708 * sysdep.c (wait_for_termination_1, wait_for_termination)
5709 (interruptible_wait_for_termination, mkdir):
5710 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
5711 (emacs_read, emacs_write):
5712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
5713 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
5714 and double all fit in int.
d311d28c
PE
5715 * term.c (set_tty_color_mode):
5716 Check that fixnums are in proper range for system types.
5717 * termhooks.h (struct input_event):
5718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5719 * textprop.c (validate_interval_range, interval_of)
5720 (Fadd_text_properties, set_text_properties_1)
5721 (Fremove_text_properties, Fremove_list_of_text_properties)
5722 (Ftext_property_any, Ftext_property_not_all)
5723 (copy_text_properties, text_property_list, extend_property_ranges)
5724 (verify_interval_modification):
5725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5726 (Fnext_single_char_property_change)
5727 (Fprevious_single_char_property_change):
5728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
5729 (copy_text_properties):
5730 Check for integer overflow in index calculation.
d311d28c
PE
5731 * undo.c (last_boundary_position, record_point, record_insert)
5732 (record_delete, record_marker_adjustment, record_change)
5733 (record_property_change):
5734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5735 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
5736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5737 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5738 (Fx_hide_tip, Fx_file_dialog):
5739 * w32menu.c (set_frame_menubar):
5740 Use ptrdiff_t, not int, for consistency with rest of code.
5741 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
5742 (select_window, Fdelete_other_windows_internal)
5743 (window_scroll_pixel_based, window_scroll_line_based)
5744 (Frecenter, Fset_window_configuration):
5745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5746 (Fset_window_hscroll, run_window_configuration_change_hook)
5747 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 5748 (Fscroll_other_window, Frecenter):
d311d28c
PE
5749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5750 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
5751 Don't assume fixnum fits in int.
5752 (Fset_window_scroll_bars):
5753 Check that fixnums are in proper range for system types.
5754 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
5755 (string_pos, c_string_pos, number_of_chars, init_iterator)
5756 (in_ellipses_for_invisible_text_p, init_from_display_pos)
5757 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
5758 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
5759 (face_before_or_after_it_pos, handle_invisible_prop)
5760 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
5761 (display_prop_intangible_p, string_buffer_position_lim)
5762 (string_buffer_position, handle_composition_prop, load_overlay_strings)
5763 (get_overlay_strings_1, get_overlay_strings)
5764 (iterate_out_of_display_property, forward_to_next_line_start)
5765 (back_to_previous_visible_line_start, reseat, reseat_to_string)
5766 (get_next_display_element, set_iterator_to_next)
5767 (get_visually_first_element, compute_stop_pos_backwards)
5768 (handle_stop_backwards, next_element_from_buffer)
5769 (move_it_in_display_line_to, move_it_in_display_line)
5770 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5771 (add_to_log, message_dolog, message_log_check_duplicate)
5772 (message2, message2_nolog, message3, message3_nolog
5773 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
5774 (current_message_1, truncate_echo_area, truncate_message_1)
5775 (set_message, set_message_1, store_mode_line_noprop)
5776 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
5777 (text_outside_line_unchanged_p, check_point_in_composition)
5778 (reconsider_clip_changes)
5779 (redisplay_internal, set_cursor_from_row, try_scrolling)
5780 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
5781 (redisplay_window, find_last_unchanged_at_beg_row)
5782 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
5783 (trailing_whitespace_p, find_row_edges, display_line)
5784 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
5785 (display_mode_element, store_mode_line_string)
5786 (pint2str, pint2hrstr, decode_mode_spec)
5787 (display_count_lines, display_string, draw_glyphs)
5788 (x_produce_glyphs, x_insert_glyphs)
5789 (rows_from_pos_range, mouse_face_from_buffer_pos)
5790 (fast_find_string_pos, mouse_face_from_string_pos)
5791 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5793 (safe_call, init_from_display_pos, handle_fontified_prop)
5794 (handle_single_display_spec, load_overlay_strings)
5795 (with_echo_area_buffer, setup_echo_area_for_printing)
5796 (display_echo_area, echo_area_display)
5797 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
5798 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
5799 (redisplay_window, dump_glyph_row, display_mode_line)
5800 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 5801 (handle_display_spec, display_prop_string_p):
d311d28c
PE
5802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5803 (handle_single_display_spec, build_desired_tool_bar_string)
5804 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
5805 (get_specified_cursor_type):
5806 Check that fixnums are in proper range for system types.
5807 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
5808 (Flookup_image_map):
5809 Don't assume fixnums fit in int.
5810 (compare_overlay_entries):
5811 Avoid mishandling comparisons due to subtraction overflow.
5812 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
5813 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
5814 (handle_tool_bar_click):
5815 Use int, not unsigned, since we prefer signed and the signedness
5816 doesn't matter here.
5817 (get_next_display_element, next_element_from_display_vector):
5818 Use int, not EMACS_INT, when int is wide enough.
5819 (start_hourglass): Use duration_to_sec_usec to do proper
5820 overflow checking on durations.
5821 * xfaces.c (Fbitmap_spec_p):
5822 Check that fixnums are in proper range for system types.
5823 (compare_fonts_by_sort_order):
5824 Avoid mishandling comparisons due to subtraction overflow.
5825 (Fx_family_fonts, realize_basic_faces):
5826 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5827 (Fx_family_fonts):
5828 Don't assume fixnum fits in int.
5829 Use SAFE_ALLOCA_LISP, not alloca.
5830 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
5831 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
5832 (face_at_buffer_position, face_for_overlay_string)
5833 (face_at_string_position):
5834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5835 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
5836 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
5837 (Fx_show_tip):
5838 Check that fixnums are in proper range for system types.
5839 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5840 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
5841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5842 (Fx_change_window_property): Don't assume fixnums fit in int.
5843 * xfont.c (xfont_chars_supported):
5844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5845 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
5846 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
5847 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5848 * xml.c (parse_region):
5849 * xrdb.c (magic_file_p):
5850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5851 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
5852 (x_get_local_selection, x_reply_selection_request)
5853 (x_handle_selection_request, wait_for_property_change):
5854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5855 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
5856 short is wide enough.
5857 (x_send_client_event): Don't assume fixnum fits in int.
5858 * xterm.c (x_x_to_emacs_modifiers):
5859 Don't assume EMACS_INT overflows nicely into int.
5860 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
5861 may come from Lisp.
5862 (handle_one_xevent): NATNUMP can eval its arg twice.
5863 (x_connection_closed):
5864 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5865 * xterm.h: Adjust decls to match defn changes elsewhere.
5866 (struct scroll_bar): Use struct vectorlike_header
5867 rather than rolling our own approximation.
5868 (SCROLL_BAR_VEC_SIZE): Remove; not used.
5869
c6574eb5
GM
58702012-05-25 Glenn Morris <rgm@gnu.org>
5871
5872 * lisp.mk (lisp): Update for more files being compiled now.
5873
e8d32c7e
SM
58742012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
5875
48def666
SM
5876 * lread.c: Remove `read_pure' which makes no difference.
5877 (read_pure): Remove var.
5878 (unreadpure): Remove function.
5879 (readevalloop): Don't call read_list with -1 flag.
5880 (read1, read_vector): Don't test read_pure any more.
5881 (read_list): Simplify.
5882
e8d32c7e
SM
5883 * fileio.c, character.h: Minor style tweaks.
5884
4b2addb7
DA
58852012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
5886
5887 * window.h (clip_changed): Remove useless declaration.
5888
584461b2
JB
58892012-05-22 Juanma Barranquero <lekktu@gmail.com>
5890
5891 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
5892 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
5893
34374650
PE
58942012-05-22 Paul Eggert <eggert@cs.ucla.edu>
5895
5896 Remove src/m/*.
5897 This directory predates autoconf and is no longer needed nowadays.
5898 Move its few remaining bits of functionality to where they're needed.
5899 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
5900 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
5901 * m/template.h: Remove.
5902 * Makefile.in (M_FILE): Remove. All uses removed.
5903 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
5904 * lisp.h (USE_LSB_TAG):
5905 * mem-limits.h (EXCEEDS_LISP_PTR):
5906 Use VAL_MAX, not VALBITS, in #if.
5907 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5908 (EMACS_UINT): Define unconditionally now.
5909 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5910 (BITS_PER_EMACS_INT): New constants, replacing
5911 what used to be in config.h, but not useful in #if.
5912 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5913 define them any more.
5914 (VAL_MAX): New macro.
5915 (VALMASK): Use it.
5916 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5917 BITS_PER_EMACS_INT, in #if.
5918 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5919 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5920 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5921 * s/ms-w32.h (DATA_START):
5922 Move here from removed file m/intel386.h.
5923 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5924 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5925
261cb4bb
PE
59262012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5927
5928 Assume C89 or later.
5929 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5930 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5931 (xrealloc):
5932 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5933 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5934 * textprop.c, tparam.c (NULL): Remove.
5935 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5936 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5937 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5938 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5939 * xterm.c (input_signal_count): Assume volatile works.
5940
ff23cd9f
KB
59412012-05-21 Ken Brown <kbrown@cornell.edu>
5942
5943 * xgselect.c (xg_select): Fix first argument in call to 'select'
5944 (bug#11508).
5945
1b170bc6
KB
59462012-05-20 Ken Brown <kbrown@cornell.edu>
5947
5948 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5949 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5950
b2f4d39f
KB
59512012-05-19 Ken Brown <kbrown@cornell.edu>
5952
5953 * xfns.c (x_in_use): Remove `static' qualifier.
5954 * xterm.h (x_in_use): Declare.
5955 * xgselect.c: Include xterm.h.
5956 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5957 and `display_arg' (bug#9754).
5958
003fdae2
PE
59592012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5960
9232a6d9
PE
5961 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5962
003fdae2
PE
5963 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5964 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5965
784b56e2
EZ
59662012-05-18 Eli Zaretskii <eliz@gnu.org>
5967
5968 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5969
5970 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5971 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5972
5973 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5974 reference to image_cache->refcount.
5975 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5976
a0a79cde
JL
59772012-05-17 Juri Linkov <juri@jurta.org>
5978
5979 * search.c (Fword_search_regexp, Fword_search_backward)
5980 (Fword_search_forward, Fword_search_backward_lax)
5981 (Fword_search_forward_lax): Move functions to isearch.el
5982 (bug#10145, bug#11381).
5983
b0572523
PE
59842012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5985
5986 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5987
9660f5fc
SM
59882012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5989
5990 * lread.c (init_obarray): Declare Qt and Qnil as special.
5991
4374de83
GM
59922012-05-14 Glenn Morris <rgm@gnu.org>
5993
5994 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5995 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5996
dc44c39a
PE
59972012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5998
078c97cb
PE
5999 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
6000
dc44c39a
PE
6001 * unexaix.c: Port to more-recent AIX compilers.
6002 (report_error, report_error_1, make_hdr, copy_sym)
6003 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
6004 Make arguments const char *, not char *, to avoid violations of C
6005 standard and to fix some AIX warnings reported by Gilles Pion.
6006
e18afed7 60072012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
6008
6009 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
6010 already have overlays loaded.
6011 (handle_single_display_spec): Before returning without displaying
6012 fringe bitmap, synchronize the bidi iterator with the main display
6013 iterator, by calling iterate_out_of_display_property.
6014 (iterate_out_of_display_property): Detect buffer iteration by
6015 testing that it->string is a Lisp string.
6016 (get_next_display_element): When the current object is exhausted,
6017 and there's something on it->stack, call set_iterator_to_next to
6018 proceed with what's on the stack, instead of returning zero.
6019 (set_iterator_to_next): If called at the end of a Lisp string,
6020 proceed to consider_string_end without incrementing string
6021 position. Don't increment display vector index past the end of
6022 the display vector. (Bug#11417)
c8fb9dc6
EZ
6023 (pos_visible_p): Don't report a position visible when move_it_to
6024 stopped at the last line of window, which happens to be scanned
6025 backwards by the bidi iteration. (Bug#11464)
ac268e67 6026
e18afed7 60272012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
6028
6029 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
6030 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
6031 are on a TTY, and thus unable to display on the fringes.
6032 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
6033 so we need to signal to the caller that this is a "replacing"
6034 display spec. This fixes display when the spec is invalid or we
6035 are on a TTY.
6036
e18afed7 60372012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
6038
6039 * unexaix.c (make_hdr): Fix typo in prototype.
6040 This bug broke the build on AIX. Problem reported by Gilles Pion.
6041
9d0a235a
MA
60422012-05-14 Michael Albinus <michael.albinus@gmx.de>
6043
6044 * keyboard.c (kbd_buffer_get_event): Read special events also in
6045 batch mode. (Bug#11415)
6046
9e6b06ed
GM
60472012-05-12 Glenn Morris <rgm@gnu.org>
6048
6049 * ns.mk: Update for ns_appbindir no longer having trailing "/".
6050
c1a1d7a3
EZ
60512012-05-12 Eli Zaretskii <eliz@gnu.org>
6052
6053 * lisp.mk (lisp): Add newcomment.elc.
6054
3fe7cdc8
GM
60552012-05-12 Glenn Morris <rgm@gnu.org>
6056
6057 * Makefile.in (MKDIR_P): New, set by configure.
6058 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
6059
53f7d2c0
PE
60602012-05-11 Paul Eggert <eggert@cs.ucla.edu>
6061
6062 Remove unused function hourglass_started.
6063 * dispextern.h (hourglass_started):
6064 * w32fns.c (hourglass_started):
6065 * xdisp.c (hourglass_started): Remove.
6066
75aafb17
JB
60672012-05-10 Juanma Barranquero <lekktu@gmail.com>
6068
6069 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
6070 Update dependencies.
6071
12959e8e
PE
60722012-05-10 Paul Eggert <eggert@cs.ucla.edu>
6073
97107e2e
PE
6074 * xgselect.c (xg_select): Put maxfds+1 into a var.
6075 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
6076
12959e8e
PE
6077 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
6078
836d29b3
DA
60792012-05-10 Dave Abrahams <dave@boostpro.com>
6080
6081 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
6082 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
6083
5cb67954
MA
60842012-05-09 Michael Albinus <michael.albinus@gmx.de>
6085
6086 * dbusbind.c (xd_registered_buses): New internal Lisp object.
6087 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
6088 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
6089 Initialize xd_registered_buses.
6090
3478ec45
PE
60912012-05-09 Paul Eggert <eggert@cs.ucla.edu>
6092
b263a6b0
PE
6093 Untag more efficiently if USE_LSB_TAG.
6094 This is based on a proposal by YAMAMOTO Mitsuharu in
6095 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
6096 For an admittedly artificial (nth 8000 longlist) benchmark on
6097 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
6098 Emacs's overall text size by 1%.
6099 * lisp.h (XUNTAG): New macro.
6100 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
6101 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
6102 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
6103 * eval.c (Fautoload):
6104 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
6105 * frame.h (XFRAME): Use XUNTAG.
6106
3478ec45
PE
6107 Port recent dbusbind.c changes to 32-bit --with-wide-int.
6108 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
6109 Remove unportable assumptions about print widths of types like
6110 dbus_uint32_t.
6111 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
6112 intptr_t when converting between pointer and integer, to avoid GCC
6113 warnings about wrong width.
6114
666b903b 61152012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
6116
6117 * w32proc.c (new_child): Force Windows to reserve only 64KB of
6118 stack for each reader_thread, instead of defaulting to 8MB
6119 determined by the linker. This avoids failures in creating
6120 subprocesses on Windows 7, see the discussion in this thread:
6121 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
6122
b120cc17
JC
61232012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
6124
6125 Fix up display of the *Minibuf-0* buffer in the mini window.
6126 * keyboard.c (read_char): Don't clear the echo area if there's no
6127 message to clear.
6128 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 6129 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 6130
9a4b36f8
MA
61312012-05-07 Michael Albinus <michael.albinus@gmx.de>
6132
6133 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
6134 batch mode.
6135
e5f9458f
CY
61362012-05-06 Chong Yidong <cyd@gnu.org>
6137
6138 * lisp.mk (lisp): Update.
6139
eceeb5fc 61402012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
6141
6142 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
6143
71873e2b
SM
61442012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
6145
6146 * data.c (PUT_ERROR): New macro.
6147 (syms_of_data): Use it. Add new error type `user-error'.
6148 * undo.c (user_error): New function.
6149 (Fprimitive_undo): Use it.
6150 * print.c (print_error_message): Adjust print style for `user-error'.
6151 * keyboard.c (user_error): New function.
6152 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
6153
ab0fa4e4
PE
61542012-05-03 Paul Eggert <eggert@cs.ucla.edu>
6155
6156 Do not limit current-time-string to years 1000..9999.
6157 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
6158 (Fcurrent_time_string): Support any year that is supported by the
6159 underlying localtime representation. Don't use asctime, as it
6160 has undefined behavior for years outside the range -999..9999.
6161
7ed806a7
PE
61622012-05-02 Paul Eggert <eggert@cs.ucla.edu>
6163
6164 Fix race conditions involving setenv, gmtime, localtime, asctime.
6165 Without this fix, interrupts could mess up code that uses these
6166 nonreentrant functions, since setting TZ invalidates existing
6167 tm_zone or tzname values, and since most of these functions return
6168 pointers to static storage.
6169 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
6170 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
6171 Grow the critical sections to include not just invoking
6172 localtime/gmtime, but also accessing these functions' results
6173 including their tm_zone values if any, and any related TZ setting.
6174 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
6175 so that the struct tm is saved in the critical section.
6176 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
6177 motivated by the fact that memory allocation needs to be outside
6178 the critical section.
6179
0c16dfed
DA
61802012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
6181
6182 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
6183 with RESET_INTERVAL.
6184
6185 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6186 Remove duplicated buffer name initialization.
6187
3f83ace8
JM
61882012-05-02 Jim Meyering <jim@meyering.net>
6189
6190 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
6191
c7b8541e
JM
6192 * xfns.c (x_window): Use xstrdup (Bug#11375).
6193
90207a15 61942012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
6195
6196 * xdisp.c (pos_visible_p): If already at a newline from the
6197 display string before the 'while' loop, don't walk back the glyphs
6198 from it3.glyph_row. Solves assertion violation when the display
6199 string begins with a newline (egg.el). (Bug#11367)
6200
b593d6a9
AH
62012012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
6202
6203 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
6204 Move to simple.el.
6205
4737362e
GM
62062012-05-01 Glenn Morris <rgm@gnu.org>
6207
99cf43f9
GM
6208 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
6209 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
6210 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
6211 All were removed before 23.1.
6212
9311dcff
GM
6213 * dispnew.c: Remove HAVE_LIBNCURSES test;
6214 it is always true on relevant platforms.
6215
4d5c6349
GM
6216 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
6217 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
6218
4737362e
GM
6219 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
6220
74dd3a6b
AS
62212012-04-30 Andreas Schwab <schwab@linux-m68k.org>
6222
6223 * .gdbinit (xpr): Remove checks for no longer existing misc types.
6224 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
6225 Remove.
6226
13c379ee
PE
62272012-04-28 Paul Eggert <eggert@cs.ucla.edu>
6228
6229 Do not avoid creating empty evaporating overlays (Bug#9642).
6230 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
6231 That is, do not delete an evaporating overlay if it becomes
6232 empty after its bounds are adjusted to fit within its buffer.
6233 This fix caused other problems, and I'm reverting it until we get
6234 to the bottom of them.
6235
a8e7d6d7 62362012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
6237
6238 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
6239
a8e7d6d7 62402012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
6241
6242 * xdisp.c (pos_visible_p): If the window start position is beyond
6243 ZV, start the display from buffer beginning. Prevents assertion
6244 violation in init_iterator when the minibuffer window is scrolled
6245 via the scroll bar.
6246
6247 * window.c (window_scroll_pixel_based): Likewise.
6248
a8e7d6d7 62492012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
6250
6251 * keymap.c (where_is_internal): Doc fix (Bug#10872).
6252
a8e7d6d7 62532012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
6254
6255 * fileio.c (Fcopy_file, Fset_file_selinux_context):
6256 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
6257
a8e7d6d7 62582012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 6259
b593d6a9
AH
6260 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
6261 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 6262
1c6900d9
EZ
62632012-04-26 Eli Zaretskii <eliz@gnu.org>
6264
4c3fa1d9
EZ
6265 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
6266 display element, check also the underlying string or buffer
6267 character. (Bug#11341)
6268
1c6900d9
EZ
6269 * w32menu.c: Include w32heap.h.
6270 (add_menu_item): If the call to AppendMenuW (via
6271 unicode_append_menu) fails, disable Unicode menus only if we are
6272 running on Windows 9X/Me.
6273
42bf8205
AS
62742012-04-24 Andreas Schwab <schwab@linux-m68k.org>
6275
6276 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
6277 (xgetint): Add missing shift for LSB tags.
6278
b1bac16e
MR
62792012-04-24 Martin Rudalics <rudalics@gmx.at>
6280
6281 * keyboard.c (read_char): Don't wipe echo area for select window
6282 events: These might get delayed via `mouse-autoselect-window'
6283 (Bug#11304).
6284
d69621cc
JB
62852012-04-24 Juanma Barranquero <lekktu@gmail.com>
6286
6287 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
6288 manipulation of :loaded-from data.
6289
02fd101b
JB
62902012-04-23 Juanma Barranquero <lekktu@gmail.com>
6291
6292 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
6293 now a cons (bug#11311).
6294
888bec30
PE
62952012-04-23 Paul Eggert <eggert@cs.ucla.edu>
6296
89a438bd
PE
6297 Do not create empty overlays with the evaporate property (Bug#9642).
6298 * buffer.c (Fmove_overlay): Delete an evaporating overlay
6299 if it becomes empty after its bounds are adjusted to fit within
6300 its buffer. Without this fix, in a nonempty buffer (let ((o
6301 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
6302 yields an empty overlay that has the evaporate property, which is
6303 not supposed to happen.
6304
1068fe4d
PE
6305 Fix minor GTK3 problems found by static checking.
6306 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6307 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6308 (struct _EmacsFixedClass, emacs_fixed_get_type):
6309 Move decls here from emacsgtkfixed.h, since they needn't be public.
6310 (emacs_fixed_get_type): Now static.
6311 (emacs_fixed_class_init): Omit unused local.
6312 (emacs_fixed_child_type): Remove; unused.
6313 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6314 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6315 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
6316 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
6317 (EMACS_FIXED_GET_CLASS): Remove; unused.
6318 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
6319
888bec30
PE
6320 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
6321 Problem reported by Juanma Barranquero for Windows -Wunused-function.
6322
de85e130
PE
63232012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6324
d0baac98 6325 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 6326 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
6327 (__malloc_size_t, __malloc_ptrdiff_t):
6328 Remove. All uses removed, replaced by the definiens if needed,
6329 since we can assume C89 or better now.
6330 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
6331 (protect_malloc_state, align, get_contiguous_space)
6332 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
6333 (malloc_atfork_handler_child, malloc_enable_thread)
6334 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
6335 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
6336 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
6337 (special_realloc, _realloc_internal_nolock, _realloc_internal)
6338 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
6339 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
6340 Define using prototypes, not old style.
6341 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
6342 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
6343 (align): Don't assume that signed integer overflow wraps around.
6344 Omit unused local var.
6345 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
6346 (_free_internal_nolock, memalign, mallochook, reallochook):
6347 Omit no-longer-needed casts.
6348 (valloc): Use getpagesize, not __getpagesize.
6349 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
6350 (struct hdr): The 'magic' member is now size_t, not unsigned long.
6351
de85e130
PE
6352 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
6353
dcbf5805
MA
63542012-04-22 Michael Albinus <michael.albinus@gmx.de>
6355
6356 Move functions from C to Lisp. Make non-blocking method calls
6357 the default. Implement further D-Bus standard interfaces.
6358
6359 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
6360 (QCdbus_request_name_allow_replacement)
6361 (QCdbus_request_name_replace_existing)
6362 (QCdbus_request_name_do_not_queue)
6363 (QCdbus_request_name_reply_primary_owner)
6364 (QCdbus_request_name_reply_in_queue)
6365 (QCdbus_request_name_reply_exists)
6366 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
6367 (QCdbus_registered_serial, QCdbus_registered_method)
6368 (QCdbus_registered_signal): New Lisp objects.
6369 (XD_DEBUG_MESSAGE): Use sizeof.
6370 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
6371 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
6372 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
6373 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
6374 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
6375 (xd_signature, xd_append_arg): Allow float for integer types.
6376 (xd_get_connection_references): New function.
b593d6a9
AH
6377 (xd_get_connection_address): Rename from xd_initialize.
6378 Return cached address.
dcbf5805
MA
6379 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
6380 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
6381 level.
6382 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 6383 Return number of refcounts.
dcbf5805
MA
6384 (Fdbus_get_unique_name): Make stronger parameter check.
6385 (Fdbus_message_internal): New defun.
6386 (Fdbus_call_method, Fdbus_call_method_asynchronously)
6387 (Fdbus_method_return_internal, Fdbus_method_error_internal)
6388 (Fdbus_send_signal, Fdbus_register_service)
6389 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
6390 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
6391 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
6392 (Vdbus_compiled_version, Vdbus_runtime_version)
6393 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
6394 (Vdbus_message_type_method_return, Vdbus_message_type_error)
6395 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
6396 (Vdbus_registered_buses, Vdbus_registered_objects_table):
6397 Adapt docstring.
dcbf5805 6398
52828e02
PE
63992012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6400
da05bc4c
PE
6401 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
6402 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
6403 Do not assume ptrdiff_t is the same width as 'int'.
6404
52828e02
PE
6405 * alloc.c: Handle unusual debugging option combinations.
6406 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
6407 since the two debugging options are incompatible.
6408 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
6409 is defined.
6410 (mem_init, mem_insert, mem_insert_fixup):
6411 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
6412 (NEED_MEM_INSERT): Remove; no longer needed.
6413
f01769f9
LL
64142012-04-22 Leo Liu <sdl.web@gmail.com>
6415
6416 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
6417
5790543d
PE
64182012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6419
6420 * sysdep.c [__FreeBSD__]: Minor cleanups.
6421 (list_system_processes, system_process_attributes) [__FreeBSD__]:
6422 Use Emacs indenting style more consistently. Avoid some casts.
6423 Use 'double' consistently rather than mixing 'float' and 'double'.
6424
b91b7e4d
EW
64252012-04-21 Eduard Wiebe <usenet@pusto.de>
6426
b593d6a9
AH
6427 * sysdep.c (list_system_processes, system_process_attributes):
6428 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 6429
6114eb15
AS
64302012-04-21 Andreas Schwab <schwab@linux-m68k.org>
6431
6432 * lisp.mk (lisp): Update.
6433
2f38dff7
PE
64342012-04-20 Paul Eggert <eggert@cs.ucla.edu>
6435
6436 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
6437 It is never used otherwise.
6438
4ae29f89
SM
64392012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
6440
6441 * print.c (print_preprocess): Only check print_depth if print-circle
6442 is nil.
6443 (print_object): Check for cycles even when print-circle is nil and
6444 print-gensym is t, but only check print_depth if print-circle is nil.
6445
f30d612a
CY
64462012-04-20 Chong Yidong <cyd@gnu.org>
6447
6448 * process.c (wait_reading_process_output): If EIO occurs on a pty,
6449 set the status to "failed" and ensure that sentinel is run.
6450
c07a4c0b 64512012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
6452
6453 * process.c (Fset_process_inherit_coding_system_flag)
6454 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 6455 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 6456
c07a4c0b 64572012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
6458
6459 * xdisp.c (string_buffer_position_lim): Limit starting position to
6460 BEGV.
6461 (set_cursor_from_row): If called for a mode-line or header-line
6462 row, return zero immediately.
6463 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
6464 farther than the first row after the header line, if any.
6465 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
6466 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
6467
c07a4c0b 64682012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6469
4ae29f89
SM
6470 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
6471 (bug#11238).
ad3a2b41 6472
c07a4c0b 64732012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 64742012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
6475
6476 configure: new option --enable-gcc-warnings (Bug#11207)
6477 * Makefile.in (C_WARNINGS_SWITCH): Remove.
6478 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
6479 (ALL_CFLAGS): Use new macros rather than old.
6480 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
6481 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
6482 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
6483 -Wunused-result, -Wunused-variable. This should go away once
6484 the Emacs and Gnulib regex code is merged.
6485 (xmalloc, xrealloc): Now static.
6486
aba027e8
PE
64872012-04-17 Paul Eggert <eggert@cs.ucla.edu>
6488
6489 * dired.c (Fsystem_groups): Remove unused local.
6490
e5a36063
GM
64912012-04-17 Glenn Morris <rgm@gnu.org>
6492
6493 * dired.c (Fsystem_users): Doc fix.
6494
316411f0
DA
64952012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
6496
6497 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
6498 (syms_of_dired): Add them.
6499
9426aba4
PE
65002012-04-16 Paul Eggert <eggert@cs.ucla.edu>
6501
b62a57be
PE
6502 Fix minor alloc.c problems found by static checking.
6503 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
6504 New extern decls, to avoid calling undeclared functions.
6505 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
6506 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
6507 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
6508 (NEED_MEM_INSERT): New macro.
6509 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 6510 Remove one incorrect comment and fix another.
b62a57be 6511
3539f31f
PE
6512 Fix minor ralloc.c problems found by static checking.
6513 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6514 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
6515 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
6516 (r_alloc_sbrk): Now static.
6517
a041960a
PE
6518 Improve ralloc.c interface checking.
6519 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6520 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
6521 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
6522 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
6523 [REL_ALLOC]: ... to here, to check interface.
6524 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
6525 Remove decls. This fixes an "It stinks!".
6526
9426aba4
PE
6527 * alloc.c (which_symbols): Fix alignment issue / type clash.
6528
d55c12ed
AS
65292012-04-15 Andreas Schwab <schwab@linux-m68k.org>
6530
6531 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
6532 (struct Lisp_Misc_Any): Likewise.
6533 (struct Lisp_Free): Likewise.
6534 * alloc.c (union aligned_Lisp_Symbol): Define.
6535 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
6536 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
6537 (union aligned_Lisp_Misc): Define.
6538 (MARKER_BLOCK_SIZE, struct marker_block): Use union
6539 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 6540 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 6541
b948ce8b
PE
65422012-04-14 Paul Eggert <eggert@cs.ucla.edu>
6543
6544 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
6545 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
6546 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
6547 * s/netbsd.h, s/sol2-6.h:
6548 Remove definition of GC_MARK_STACK, since the default now works.
6549 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
6550 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
6551 no longer the default.
6552 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
6553
35dc09a1 65542012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6555
35dc09a1
GM
6556 * lread.c (lisp_file_lexically_bound_p):
6557 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 6558
35dc09a1
GM
65592012-04-14 Eli Zaretskii <eliz@gnu.org>
6560
6561 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
6562 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
6563
65642012-04-14 Jan Djärv <jan.h.d@swipnet.se>
6565
6566 * nsterm.m (constrainFrameRect): Always constrain when there is only
6567 one screen (Bug#10962).
6568
bcd86815
KB
65692012-04-13 Ken Brown <kbrown@cornell.edu>
6570
6571 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
6572
c25df26e
RT
65732012-04-13 Reuben Thomas <rrt@sc3d.org>
6574
6575 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
6576
0fc59f1e
DC
65772012-04-11 Daniel Colascione <dancol@dancol.org>
6578
6579 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
6580 against is gone. It's better to use vfork now so that when Cygwin
6581 gains a new, working vfork, we use it automatically (bug#10398).
6582
de8c03dc
SM
65832012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6584
6585 * window.c (save_window_save): Obey window-point-insertion-type.
6586
2f097256
GM
65872012-04-11 Glenn Morris <rgm@gnu.org>
6588
6589 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
6590
453b951e
SM
65912012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6592
6593 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
6594
75f1671a 65952012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
6596
6597 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
6598 (force_quit_count): New var.
6599 (handle_interrupt): Use it.
6600
2a8ce227
JB
66012012-04-10 Juanma Barranquero <lekktu@gmail.com>
6602
6603 * w32.c (w32_delayed_load): Record the full path of the library
6604 being loaded (bug#10424).
6605
935396c0
GM
66062012-04-09 Glenn Morris <rgm@gnu.org>
6607
05920a43
GM
6608 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
6609 not just in the obarray, before snarfing them. (Bug#11036)
6610
935396c0
GM
6611 * Makefile.in ($(leimdir)/leim-list.el):
6612 Pass EMACS rather than BUILT_EMACS.
6613
a18ecafa
TZ
66142012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
6615
6616 * process.c (make_process):
6617 * process.h: Add integer `gnutls_handshakes_tried' member to
6618 process struct.
6619
6bbef4e5
JC
6620 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
6621 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
6622
6623 * gnutls.c (gnutls_log_function2i): Convenience log function.
6624 (emacs_gnutls_read): Use new log functions,
6625 `gnutls_handshakes_tried' process member, and
6626 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
6627 attempts per process (connection).
6628
b4d3bc10
CY
66292012-04-09 Chong Yidong <cyd@gnu.org>
6630
6631 * eval.c (Fuser_variable_p, user_variable_p_eh)
6632 (lisp_indirect_variable): Functions deleted.
6633 (Fdefvar): Caller changed.
6634
6635 * callint.c (Finteractive, Fcall_interactively):
6636 * minibuf.c (Fread_variable): Callers changed.
6637
70f4d973
EZ
66382012-04-09 Eli Zaretskii <eliz@gnu.org>
6639
6640 * xdisp.c (set_cursor_from_row): If the display string appears in
6641 the buffer at position that is closer to point than the position
6642 after the display string, display the cursor on the first glyph of
6643 the display string. Fixes cursor display when a 'display' text
6644 property immediately follows invisible text. (Bug#11094)
6645
cb3c2e3e
PE
66462012-04-09 Paul Eggert <eggert@cs.ucla.edu>
6647
6648 composite.c: use 'double' consistently
6649 * composite.c (get_composition_id): Use 'double' consistently
6650 instead of converting 'float' to 'double' and vice versa; this is
6651 easier to understand and avoids a GCC warning.
6652
fd06db5d
GM
66532012-04-09 Glenn Morris <rgm@gnu.org>
6654
50fe702a
GM
6655 * Makefile.in: Generate leim-list with bootstrap-emacs, in
6656 preparation for dumping it with emacs. (Bug#4789)
6657 (leimdir): New variable.
6658 ($(leimdir)/leim-list.el): New rule.
6659 (emacs$(EXEEXT)): Depend on leim-list.el.
6660
fd06db5d
GM
6661 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
6662 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
6663 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
6664
55c131ee
AS
66652012-04-08 Andreas Schwab <schwab@linux-m68k.org>
6666
6667 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
6668 proper alignment.
6669
9209588f
JB
66702012-04-07 Juanma Barranquero <lekktu@gmail.com>
6671
6672 * xml.c (init_libxml2_functions) [WINDOWSNT]:
6673 Remove unused local variable.
6674
e3fb2efb
PE
66752012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6676
6677 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
6678 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
6679 (mark_memory): Mark Lisp_Objects only if pointers might hide in
6680 objects, as mark_maybe_pointer will catch them otherwise.
6681 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
6682 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
6683
b5385551
PE
66842012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6685
6686 Fix typo that broke non-Windows builds.
6687 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
6688
9078ead6
EZ
66892012-04-07 Eli Zaretskii <eliz@gnu.org>
6690
6691 Support building on MS-Windows with libxml2.
6692
6693 * makefile.w32-in (OBJ2): Add xml.$(O).
6694 (GLOBAL_SOURCES): Add xml.c.
6695 ($(BLD)/xml.$(O)): New dependency list.
6696
6697 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
6698 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
6699 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
6700 [!WINDOWSNT]: New macros.
6701 (init_libxml2_functions, libxml2_loaded_p): New functions.
6702 (parse_region): Call fn_xmlCheckVersion instead of using the macro
6703 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
6704 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
6705 Calls xmlCleanupParser only if libxml2 was loaded (or statically
6706 linked in).
6bbef4e5
JC
6707 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
6708 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
6709 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
6710
6711 * emacs.c: Don't include libxml/parser.h.
6712 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
6713 xmlCleanupParser directly.
6714
6715 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
6716
3811fdf3
EZ
67172012-04-07 Eli Zaretskii <eliz@gnu.org>
6718
6719 * indent.c (Fvertical_motion): If there is a display string at
6720 point, use it.vpos to compute how many lines to backtrack after
6721 move_it_to point. (Bug#11133)
6722
2f8e16b2
EZ
67232012-04-06 Eli Zaretskii <eliz@gnu.org>
6724
6725 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
6726 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
6727 about subtle differences between FETCH_CHAR* and STRING_CHAR*
6728 macros related to unification of CJK characters. For the details,
6729 see the discussion following the message here:
6730 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
6731
3d439cd1
CY
67322012-04-04 Chong Yidong <cyd@gnu.org>
6733
6734 * keyboard.c (Vdelayed_warnings_list): Doc fix.
6735
8bc53d00
EZ
67362012-04-01 Eli Zaretskii <eliz@gnu.org>
6737
6738 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
6739 instead of alloca. (Bug#11138)
6740
3b0512a3
AS
67412012-04-01 Andreas Schwab <schwab@linux-m68k.org>
6742
6743 * w32menu.c (is_simple_dialog): Properly check lisp types.
6744 (Bug#11141)
6745
8427ddd2
EZ
67462012-03-31 Eli Zaretskii <eliz@gnu.org>
6747
979022ef
EZ
6748 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
6749 position we get to after a call to move_it_to fails the
6750 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
6751 only if we wind up in a string from display property. (Bug#11063)
6752
a6b1c7cc
EZ
6753 * window.c (Fdelete_other_windows_internal): Invalidate the row
6754 and column information about mouse highlight, so that redisplay
6755 restores it after reallocating the glyph matrices. (Bug#7464)
6756
8427ddd2
EZ
6757 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
6758 string comes from a `display' text property, use the buffer
6759 position of that property as if we actually saw that position in
6760 the row's glyphs.
697ba24b
EZ
6761 (move_it_by_lines): Remove the assertion that
6762 "it->current_x == 0 && it->hpos == 0" which can be legitimately
6763 violated when there's a before-string at the beginning of a line.
6764 (Bug#11063)
8427ddd2 6765
65a0a738
EZ
67662012-03-30 Eli Zaretskii <eliz@gnu.org>
6767
6768 * xdisp.c (append_space_for_newline): If the default face was
6769 remapped, use the remapped face for the appended newline.
6770 (extend_face_to_end_of_line): Use the remapped default face for
6771 extending the face to the end of the line.
6772 (display_line): Call extend_face_to_end_of_line when the default
6773 face was remapped. (Bug#11068)
6774
581355cc
EZ
67752012-03-29 Eli Zaretskii <eliz@gnu.org>
6776
6777 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
6778
e8fc049f
SM
67792012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6780
6781 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
6782
4fb9a543
GM
67832012-03-27 Glenn Morris <rgm@gnu.org>
6784
6785 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
6786 Doc fixes.
6787
679910f1
KH
67882012-03-26 Kenichi Handa <handa@m17n.org>
6789
6790 * dispextern.h (struct glyph): Fix previous change. Change the
6791 bit length of glyphless.ch to 25 (Bug#11082).
6792
90d49b7f
CY
67932012-03-26 Chong Yidong <cyd@gnu.org>
6794
6795 * keyboard.c (Vselection_inhibit_update_commands): New variable.
6796 (command_loop_1): Use it; inhibit selection update for
6797 handle-select-window too (Bug#8996).
6798
f514f6f0
FP
67992012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
6800
e8fc049f 6801 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 6802
bf43fa51
KH
68032012-03-25 Kenichi Handa <handa@m17n.org>
6804
6805 * dispextern.h (struct glyph): Change the bit length of
6806 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
6807
8a0c01dd
EZ
68082012-03-24 Eli Zaretskii <eliz@gnu.org>
6809
6810 * s/ms-w32.h (tzname): Include time.h before redirecting to
6811 _tzname. Fixes the MSVC build. (Bug#9960)
6812
7d1c3a76
AS
68132012-03-24 Andreas Schwab <schwab@linux-m68k.org>
6814
8ed79523
AS
6815 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
6816 characters.
6817
7d1c3a76
AS
6818 * xterm.c (XTread_socket): Only modify handling_signal if
6819 !SYNC_INPUT. (Bug#11080)
6820
e99a9b8b
EZ
68212012-03-23 Eli Zaretskii <eliz@gnu.org>
6822
6823 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
6824 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
6825 when fetching a multibyte character consumes more bytes than
6826 CHAR_BYTES returns, due to unification of CJK characters in
6827 string_char. (Bug#11073)
6828
5063c0e1
TN
68292012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
6830
6831 * process.c (wait_reading_process_output): Handle pty disconnect
6832 by refraining from sending oneself a SIGCHLD (bug#10933).
6833
9f851fbd
CY
68342012-03-22 Chong Yidong <cyd@gnu.org>
6835
6836 * dispextern.h (struct it): New member string_from_prefix_prop_p.
6837
5063c0e1 6838 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
6839 Mark string as coming from a prefix property.
6840 (handle_face_prop): Use default face for prefix strings (Bug#4281).
6841 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
6842
fb5b8aca
CY
68432012-03-21 Chong Yidong <cyd@gnu.org>
6844
6845 * xfaces.c (Vface_remapping_alist): Doc fix.
6846
62356a1b
EZ
68472012-03-20 Eli Zaretskii <eliz@gnu.org>
6848
6849 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
6850 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
6851 Doc fixes.
62356a1b 6852
025de85b
CY
68532012-03-20 Chong Yidong <cyd@gnu.org>
6854
6855 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
6856 to reflect default non-nil value of redisplay-dont-pause.
6857
4827f94e
KH
68582012-03-19 Kenichi Handa <handa@m17n.org>
6859
6860 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
6861 it fit in a valid range (Bug#11003).
6862
e50a24a2
EZ
68632012-03-18 Eli Zaretskii <eliz@gnu.org>
6864
6865 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
6866 that is not from display property, accept the row as a "cursor
6867 row" if one of the string's character has a non-nil `cursor'
6868 property. Fixes cursor positioning when there are newlines in
6869 overlay strings, e.g. in icomplete.el. (Bug#11035)
6870
9af5ed87
PE
68712012-03-12 Paul Eggert <eggert@cs.ucla.edu>
6872
6873 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
6874
d1f55f16
CY
68752012-03-12 Chong Yidong <cyd@gnu.org>
6876
6877 * eval.c (inhibit_lisp_code): Rename from
6878 inhibit_window_configuration_change_hook; move from window.c.
6879
6880 * xfns.c (unwind_create_frame_1, Fx_create_frame):
6881 * window.c (run_window_configuration_change_hook)
6882 (syms_of_window): Callers changed.
6883
66c5eebd
CY
68842012-03-11 Chong Yidong <cyd@gnu.org>
6885
413df973
CY
6886 * keymap.c (Fkey_description): Doc fix (Bug#9700).
6887
66c5eebd
CY
6888 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
6889
1de11f56
CY
68902012-03-10 Chong Yidong <cyd@gnu.org>
6891
6892 * frame.c (other_visible_frames): Don't assume the selected frame
6893 is visible (Bug#10955).
6894
cae07000
SM
68952012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
6896
6897 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
6898
89c94350
JD
68992012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6900
6901 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
6902 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
6903 zero (Bug#10954).
6904
999dd333
GM
69052012-03-03 Glenn Morris <rgm@gnu.org>
6906
01a6dcc8 6907 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6908
de0100f2
EZ
69092012-03-02 Eli Zaretskii <eliz@gnu.org>
6910
6911 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6912 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6913 (redisplay_window, next_element_from_string): Fix typos in
6914 comments.
3e441275
EZ
6915 (redisplay_window): Pass to move_it_vertically the margin in
6916 pixels, not in screen lines.
de0100f2 6917
96a72ee9
GM
69182012-03-02 Glenn Morris <rgm@gnu.org>
6919
6920 * buffer.c (buffer-list-update-hook): Doc fix.
6921
312508d7
EZ
69222012-02-29 Eli Zaretskii <eliz@gnu.org>
6923
6924 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6925 push_it before setting up the iterator for the first overlay
6926 string, even if we have an empty string loaded.
6927 (next_overlay_string): If there's an empty string on the iterator
6928 stack, pop the stack. (Bug#10903)
6929
27f3c637
PE
69302012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6931
6932 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6933 Suggested by Stefan Monnier in
6934 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6935 * alloc.c (widen_to_Lisp_Object): New static function.
6936 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6937 and widening them to Lisp_Objects. This would work even if
6938 USE_LSB_TAG is defined and wide integers are used, which might
6939 happen in a future version of Emacs.
6940
3c9dfce6
CY
69412012-02-25 Chong Yidong <cyd@gnu.org>
6942
fa74b241
CY
6943 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6944 Doc fix.
6945
3c9dfce6
CY
6946 * xselect.c (Fx_selection_exists_p): Doc fix.
6947 (x_clipboard_manager_save_all): Print an informative message
6948 before saving to clipboard manager.
6949
9486df08
CY
69502012-02-24 Chong Yidong <cyd@gnu.org>
6951
6952 * keyboard.c (process_special_events): Handle all X selection
6953 requests in kbd_buffer, not just the next one (Bug#8869).
6954
f01d3321
CY
69552012-02-23 Chong Yidong <cyd@gnu.org>
6956
6957 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6958 call when setting menu-bar-lines and tool-bar-lines parameters.
6959 (unwind_create_frame_1): New helper function.
6960
6961 * window.c (inhibit_window_configuration_change_hook): New var.
6962 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6963 (syms_of_window): Initialize it.
f01d3321 6964
86b847b6
CY
69652012-02-22 Chong Yidong <cyd@gnu.org>
6966
6967 * xterm.c (x_draw_image_relief): Add missing type check for
6968 Vtool_bar_button_margin (Bug#10743).
6969
a59225b1
CY
69702012-02-21 Chong Yidong <cyd@gnu.org>
6971
6972 * fileio.c (Vfile_name_handler_alist): Doc fix.
6973
6974 * buffer.c (Fget_file_buffer): Protect against invalid file
6975 handler return value.
6976
310f5bd4
PE
69772012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6978
cb3a28cc
PE
6979 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6980 when computing $valmask.
6981
310f5bd4
PE
6982 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6983 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6984 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6985 It's useless in that case, and it can cause problems on hosts
6986 that allocate halves of EMACS_INT values separately.
6987 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6988 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6989 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6990 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6991 it avoids undefined behavior on hosts where shifting right by more
6992 than the word width has undefined behavior.
6993
2375c96a
CY
69942012-02-19 Chong Yidong <cyd@gnu.org>
6995
6996 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6997 (Funhandled_file_name_directory, Ffile_name_as_directory)
6998 (Fdirectory_file_name, Fexpand_file_name)
6999 (Fsubstitute_in_file_name): Protect against invalid file handler
7000 return values (Bug#10845).
7001
3eb49e71
EZ
70022012-02-18 Eli Zaretskii <eliz@gnu.org>
7003
7004 * .gdbinit (pitx): Fix incorrect references to fields of the
7005 iterator stack.
7006
7b926f3f
CY
70072012-02-17 Chong Yidong <cyd@gnu.org>
7008
7009 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
7010
11273115
PE
70112012-02-15 Paul Eggert <eggert@cs.ucla.edu>
7012
7013 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
7014 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
7015
c3a70e2b
CY
70162012-02-15 Chong Yidong <cyd@gnu.org>
7017
7018 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
7019 marked as special. Also, starting docstrings with * is obsolete.
7020
0ca43699
AS
70212012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7022
7023 * gnutls.c (emacs_gnutls_write): Fix last change.
7024
2e8f3c56
LI
70252012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
7026
7027 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
7028 send_process.
7029
af70074f
SM
70302012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
7031
7032 * keymap.c (Fsingle_key_description): Handle char ranges.
7033
95986d52
CY
70342012-02-12 Chong Yidong <cyd@gnu.org>
7035
afd83bd1
CY
7036 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
7037 as that creates a dangerous corner case.
7038
95986d52
CY
7039 * window.c (Fdelete_window_internal): Invalidate the mouse
7040 highlight (Bug#9904).
7041
bd7da63e
GM
70422012-02-12 Glenn Morris <rgm@gnu.org>
7043
7044 * xselect.c (Fx_own_selection_internal)
7045 (Fx_get_selection_internal, Fx_disown_selection_internal)
7046 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
7047 * nsselect.m (Fx_own_selection_internal)
7048 (Fx_disown_selection_internal, Fx_selection_exists_p)
7049 (Fx_selection_owner_p, Fx_get_selection_internal):
7050 Sync docs and argument specs with the xselect.c versions.
7051
77abcbc2
LI
70522012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
7053
7054 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
7055
90b671e2
EZ
70562012-02-11 Eli Zaretskii <eliz@gnu.org>
7057
1c0ca0b7
EZ
7058 * w32select.c (Fx_selection_exists_p): Sync doc string and
7059 argument list with xselect.c. (Bug#10783)
7060
7061 * w16select.c (Fx_selection_exists_p): Sync doc string and
7062 argument list with xselect.c. (Bug#10783)
90b671e2 7063
49241268
GM
70642012-02-10 Glenn Morris <rgm@gnu.org>
7065
7066 * fns.c (Fsecure_hash): Doc fix.
7067
f998bbe7 70682012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
7069
7070 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
7071
0992bd9c
CY
70722012-02-07 Chong Yidong <cyd@gnu.org>
7073
7074 * buffer.c (Fbuffer_local_variables)
7075 (buffer_lisp_local_variables): Handle unbound vars correctly;
7076 don't let Qunbound leak into Lisp.
7077
af008560
GM
70782012-02-07 Glenn Morris <rgm@gnu.org>
7079
dd605cc4
GM
7080 * image.c (Fimagemagick_types): Doc fix.
7081
af008560
GM
7082 * image.c (imagemagick-render-type): Change it from a lisp object
7083 to an integer. Move the doc here from the lisp manual.
7084 Treat all values not equal to 0 the same.
7085
1449fa1d
CY
70862012-02-06 Chong Yidong <cyd@gnu.org>
7087
7088 * doc.c (store_function_docstring): Avoid applying docstring of
7089 alias to base function (Bug#2603).
7090
3723ec07
AS
70912012-02-04 Andreas Schwab <schwab@linux-m68k.org>
7092
7093 * .gdbinit (pp1, pv1): Remove redundant defines.
7094 (pr): Use pp.
7095
79c1cc1e
CY
70962012-02-04 Chong Yidong <cyd@gnu.org>
7097
7098 * nsterm.m: Declare a global (Bug#10694).
7099
d7f29f8e
EZ
71002012-02-04 Eli Zaretskii <eliz@gnu.org>
7101
cae07000
SM
7102 * w32.c (get_emacs_configuration_options):
7103 Include --enable-checking, if specified, in the return value.
d7f29f8e 7104
3b95a6f9
MR
71052012-02-04 Martin Rudalics <rudalics@gmx.at>
7106
7107 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
7108 after rounding frame sizes. (Bug#9723)
7109
d6fa96a6
EZ
71102012-02-04 Eli Zaretskii <eliz@gnu.org>
7111
7112 * keyboard.c (adjust_point_for_property): Don't position point
7113 before BEGV. (Bug#10696)
7114
df0b2940
PE
71152012-02-03 Paul Eggert <eggert@cs.ucla.edu>
7116
7117 Handle overflow when computing char display width (Bug#9496).
7118 * character.c (char_width): Return EMACS_INT, not int.
7119 (char_width, c_string_width): Check for overflow when
7120 computing the width; this is possible now that individual
7121 characters can have unbounded width. Problem introduced
7122 by merge from Emacs 23 on 2012-01-19.
7123
6bee44d6
MA
71242012-02-02 Michael Albinus <michael.albinus@gmx.de>
7125
7126 * dbusbind.c (Fdbus_register_method): Mention the return value
7127 :ignore in the docstring.
7128
44f92739
GM
71292012-02-02 Glenn Morris <rgm@gnu.org>
7130
1b9f60cc
GM
7131 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
7132
44f92739
GM
7133 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7134 Unconditionally set to t. (Bug#10673)
7135 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7136 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
7137 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
7138
c5d3843c
KH
71392012-02-02 Kenichi Handa <handa@m17n.org>
7140
7141 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
7142 0, do not call append_composite_glyph.
7143
159462d4 71442012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
7145
7146 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
7147 NULL (Bug#6988).
7148 (x_produce_glyphs): If the component of a composition is a null
7149 string, set it->pixel_width to 1 to avoid zero-width glyph.
7150
78cef877
EZ
71512012-02-01 Eli Zaretskii <eliz@gnu.org>
7152
7153 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
7154 first 2 arguments are identical. This makes inserting large
7155 output from a subprocess an order of magnitude faster on
7156 MS-Windows, where all sbrk'ed memory is always contiguous.
7157
97897668
GM
71582012-01-31 Glenn Morris <rgm@gnu.org>
7159
7160 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 7161 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
7162 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
7163
31fd3586
GM
71642012-01-29 Glenn Morris <rgm@gnu.org>
7165
7166 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
7167
0e24a8b2
CY
71682012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
7169
7170 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
7171
cc0adcb0
CY
71722012-01-28 Chong Yidong <cyd@gnu.org>
7173
7174 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
7175
acc28cb9
CY
71762012-01-26 Chong Yidong <cyd@gnu.org>
7177
9c69cfb7
CY
7178 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
7179
acc28cb9
CY
7180 * search.c (Fsearch_forward, Fsearch_backward): Document negative
7181 repeat counts (Bug#10507).
7182
48da7392
GM
71832012-01-26 Glenn Morris <rgm@gnu.org>
7184
7185 * lread.c (syms_of_lread): Doc fix.
7186
14af5f7f
CY
71872012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
7188
7189 * coding.c (encode_designation_at_bol): Change return value to
7190 EMACS_INT.
7191
0b21c100
CY
71922012-01-25 Chong Yidong <cyd@gnu.org>
7193
7194 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
7195
3c2907f7
CY
71962012-01-21 Chong Yidong <cyd@gnu.org>
7197
7198 * floatfns.c (Fcopysign): Make the second argument non-optional,
7199 since nil is not allowed anyway.
7200
959ad23f
AS
72012012-01-21 Andreas Schwab <schwab@linux-m68k.org>
7202
7203 * process.c (read_process_output): Use p instead of XPROCESS (proc).
7204 (send_process): Likewise.
7205
34a02f46
MR
72062012-01-19 Martin Rudalics <rudalics@gmx.at>
7207
7208 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
7209 (Vwindow_persistent_parameters): Do not use Qstate.
7210 Rewrite doc-strings.
34a02f46 7211
1259009a 72122012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
7213
7214 * character.c (char_width): New function.
70d4fdf6
GM
7215 (Fchar_width, c_string_width, lisp_string_width):
7216 Use char_width (Bug#9496).
25ed9e61 7217
6a6ee00d
MR
72182012-01-16 Martin Rudalics <rudalics@gmx.at>
7219
7220 * window.c (Vwindow_persistent_parameters): New variable.
7221 (Fset_window_configuration, save_window_save): Handle persistent
7222 window parameters.
7223
c85efaf7
EZ
72242012-01-14 Eli Zaretskii <eliz@gnu.org>
7225
7226 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
7227 thrashing the stack of the thread. (Bug#9087)
7228
5944709e
PE
72292012-01-12 Paul Eggert <eggert@cs.ucla.edu>
7230
7231 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
7232
e71f5d99
EZ
72332012-01-11 Eli Zaretskii <eliz@gnu.org>
7234
7235 * xdisp.c (rows_from_pos_range): Handle the case where the
7236 highlight ends on a newline. (Bug#10464)
7237 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
7238 he end column for display of highlight that ends on a newline
7239 before a R2L line.
7240
ce316182
GM
72412012-01-11 Glenn Morris <rgm@gnu.org>
7242
7243 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
7244 from load-path also when installation-directory is nil. (Bug#10208)
7245
5b43da69
GM
72462012-01-10 Glenn Morris <rgm@gnu.org>
7247
74cc8ff9
GM
7248 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
7249
7d8d6e4e
GM
7250 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
7251 Update template values to be closer to their typical values these days.
5b43da69 7252
a0db8d43
EZ
72532012-01-09 Eli Zaretskii <eliz@gnu.org>
7254
7255 * xdisp.c (rows_from_pos_range): Accept additional argument
7256 DISP_STRING, and accept any glyph in a row whose object is that
7257 string as eligible for mouse highlight. Fixes mouse highlight of
7258 display strings from overlays. (Bug#10464)
7259
9a0115ab 72602012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 7261
b9110d6a 7262 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
7263 * fileio.c (auto_saving_dir_umask): New static var.
7264 (Fmake_directory_internal): Use it.
7265 (do_auto_save_make_dir): Set it, instead of invoking chmod after
7266 creating the directory. The old code temporarily assigns
7267 too-generous permissions to the directory.
7268 (do_auto_save_eh): Clear it.
b9110d6a 7269 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
7270 that the var is always cleared.
7271
6c1bd3f3
EZ
72722012-01-07 Eli Zaretskii <eliz@gnu.org>
7273
7274 * search.c (scan_buffer): Pass character positions to
7275 know_region_cache, not byte positions. (Bug#6540)
7276
069d2b50
L
72772012-01-07 LynX <_LynX@bk.ru> (tiny change)
7278
7279 * w32.c (sys_rename): Report EXDEV when rename of a directory
7280 fails because the target is on another logical disk. (Bug#10284)
7281
75bf0d33
DB
72822012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
7283
7284 * xterm.c (x_embed_request_focus): New function.
7285
7286 * xterm.h: Add prototype.
7287
7288 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
7289
1c6e5a32
GM
72902012-01-05 Glenn Morris <rgm@gnu.org>
7291
7292 * emacs.c (emacs_copyright): Update short copyright year to 2012.
7293
651e947e
EZ
72942012-01-01 Eli Zaretskii <eliz@gnu.org>
7295
7296 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
7297 Load gnutls_transport_set_lowat only if GnuTLS version is below
7298 2.11.1.
7299 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
7300 GnuTLS versions below 2.11.1.
7301
3778cdd8
AL
73022011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
7303
7304 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
7305 to the doc string advising against its use for altering the way
7306 windows are scrolled.
7307
0e5317f7
KH
73082011-12-28 Kenichi Handa <handa@m17n.org>
7309
7310 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
7311 coding-system ASCII compatible only when it does not produce BOM
7312 on encoding (Bug#10383).
7313
93d5ca1f
JD
73142011-12-26 Jan Djärv <jan.h.d@swipnet.se>
7315
7316 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
7317 can scroll.
7318 (create_and_show_popup_menu): Always use menu_position_func for
7319 Gtk3 (Bug#10361).
7320
ca22b785
AS
73212011-12-24 Andreas Schwab <schwab@linux-m68k.org>
7322
7323 * callint.c (Fcall_interactively): Don't truncate prompt string.
7324
d048e1e6
EZ
73252011-12-23 Eli Zaretskii <eliz@gnu.org>
7326
7327 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
7328 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 7329 resumed from there (after widening). (Bug#10360)
d048e1e6 7330
5ccaba1f
JD
73312011-12-22 Jan Djärv <jan.h.d@swipnet.se>
7332
7333 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
7334
204ee57f
JD
73352011-12-21 Jan Djärv <jan.h.d@swipnet.se>
7336
b81d40f0
JB
7337 * nsterm.m (x_free_frame_resources):
7338 Release f->output_data.ns->miniimage.
204ee57f
JD
7339 (ns_index_color): Fix indentation. Do not retain
7340 color_table->colors[i].
7341
7342 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
7343 before returning.
7344
7345 * nsfns.m (x_set_background_color): Assign return value from
7346 ns_index_color to face-background instead of NSColor*.
7347 (ns_implicitly_set_icon_type): Fix indentation.
7348 Change assignment in for loop to comparison.
7349
7350 * emacs.c (ns_pool): New variable.
7351 (main): Assign ns_pool.
7352 (Fkill_emacs): Call ns_release_autorelease_pool.
7353
7354 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
7355 autorelease fdesc, release fdAttrs and tdict.
7356 (ns_get_covering_families): Release charset.
7357 (ns_findfonts): Release NSFontDescriptor created with new.
7358 (ns_uni_to_glyphs): Fix indentation.
7359 (setString): Release attrStr before assigning new value.
7360
c803b2b7
JD
73612011-12-18 Jan Djärv <jan.h.d@swipnet.se>
7362
678f4426
JD
7363 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
7364 and NS_IMPL_COCOA.
7365 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
7366 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
7367
cd394be1 73682011-12-18 David Reitter <reitter@cmu.edu>
678f4426 7369
5fecd5fc
JD
7370 * nsterm.m (ns_term_init): Subscribe for notifications
7371 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
7372 to method trackingNotification in EmacsMenu.
7373
7374 * nsmenu.m (trackingMenu): New variable.
3771cb17 7375 (trackingNotification): New method (from Aquamacs).
5fecd5fc 7376 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 7377 from Aquamacs (Bug#7030).
678f4426
JD
7378
73792011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 7380
c803b2b7
JD
7381 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
7382 (symbol_to_nsstring): Fix indentation.
7383 (ns_symbol_to_pb): New function.
cae07000
SM
7384 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
7385 (Fns_rotate_cut_buffers_internal): Remove.
7386 (Fns_store_selection_internal): Rename from
c803b2b7
JD
7387 Fns_store_cut_buffer_internal.
7388 (ns_get_foreign_selection, Fx_own_selection_internal)
7389 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
7390 (Fns_get_selection_internal, Fns_store_selection_internal):
7391 Use ns_symbol_to_pb and check if return value is nil.
7392 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
7393 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
7394 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
7395 renamed to Sns_store_selection_internal.
7396 (ns_handle_selection_request): Move code to Fx_own_selection_internal
7397 and remove this function.
7398 (ns_handle_selection_clear): Remove, never used.
7399 (Fx_own_selection_internal): Move code from ns_handle_selection_request
7400 here.
7401
e1b01a3a
KB
74022011-12-17 Ken Brown <kbrown@cornell.edu>
7403
7404 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
7405 GID is unknown (Bug#10257).
7406
2adb6e85
PE
74072011-12-17 Paul Eggert <eggert@cs.ucla.edu>
7408
7409 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
7410 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
7411 which caused a build failure on GNU/Linux IA-64. This problem was
7412 introduced by my 2011-10-07 patch.
7413
d1d7b339
JL
74142011-12-15 Juri Linkov <juri@jurta.org>
7415
7416 * image.c (imagemagick_error): New function. (Bug#10112)
7417 (imagemagick_load_image): Comment out `MagickSetResolution' call.
7418 Use `imagemagick_error' where ImageMagick functions return
7419 `MagickFalse'.
7420 (Fimagemagick_types): Add `Fnreverse' to return the list in the
7421 proper order.
7422
100d5755
KH
74232011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7424
7425 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
7426 fill background (Bug#8992).
7427
454592a6
MR
74282011-12-13 Martin Rudalics <rudalics@gmx.at>
7429
7430 * window.c (Vwindow_combination_resize)
7431 (Vwindow_combination_limit): Use t instead of non-nil in
7432 doc-strings.
61d4b438
MR
7433 (Vrecenter_redisplay): Add first sentence of doc-string on
7434 separate line.
53524d93 7435 (Frecenter): Fix doc-string typo.
454592a6 7436
3633e3aa
KH
74372011-12-11 Kenichi Handa <handa@m17n.org>
7438
7439 * coding.c (Funencodable_char_position): Pay attention to the
7440 buffer text relocation (Bug#9389).
7441
7b9d523a 74422011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 7443
7b9d523a
JD
7444 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
7445 gtk_init (Bug#10100).
7446
b73189c6
EZ
74472011-12-10 Eli Zaretskii <eliz@gnu.org>
7448
7449 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
7450 IT->string is nil. (Bug#10263)
7451
f7dfe5d6
JD
74522011-12-10 Jan Djärv <jan.h.d@swipnet.se>
7453
83faebb4
JD
7454 * nsterm.h (x_free_frame_resources): Declare.
7455
f7dfe5d6
JD
7456 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
7457 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
7458
7459 * nsterm.h (ns_get_defaults_value): Declare.
7460
7461 * nsterm.m (ns_default): Call ns_get_defaults_value.
7462
7cd4e72c
EZ
74632011-12-09 Eli Zaretskii <eliz@gnu.org>
7464
7465 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
7466 (Bug#10170)
7467
b34d7317
YM
74682011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7469
7470 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
7471 that where the value of an _OBJC_* symbol points to is in the .bss
7472 section (Bug#10240).
7473
76470ad1
KH
74742011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7475
7476 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 7477 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 7478
745fff94
KH
74792011-12-08 Kenichi Handa <handa@m17n.org>
7480
7481 * ftfont.c (get_adstyle_property): Fix previous change
7482 (Bug#10233).
7483
6e44397c
JB
74842011-12-07 Juanma Barranquero <lekktu@gmail.com>
7485
7486 * w32.c (init_environment): If no_site_lisp, remove site-lisp
7487 dirs from the default value of EMACSLOADPATH (bug#10208).
7488
7efa6272
GM
74892011-12-07 Glenn Morris <rgm@gnu.org>
7490
7491 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
7492 installation and source directories as well. (Bug#10208)
7493
f6fc4d87
CY
74942011-12-06 Chong Yidong <cyd@gnu.org>
7495
7496 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
7497
2bf26180
GM
74982011-12-06 Glenn Morris <rgm@gnu.org>
7499
7500 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
7501 as an error, not just -1. (Bug#10217)
7502
3a6ad4f0
CY
75032011-12-05 Chong Yidong <cyd@gnu.org>
7504
7505 * keyboard.c (process_special_events): New function.
7506 (swallow_events, Finput_pending_p): Use it (Bug#10195).
7507
75a3b399
PE
75082011-12-05 Paul Eggert <eggert@cs.ucla.edu>
7509
7510 * coding.c (encode_designation_at_bol): Don't use uninitialized
7511 local variable (Bug#9318).
7512
c3c9e25e
KH
75132011-12-05 Kenichi Handa <handa@m17n.org>
7514
7515 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
7516 return Qnil (Bug#8046, Bug#10193).
7517
5eb05ea3
KH
75182011-12-05 Kenichi Handa <handa@m17n.org>
7519
7520 * coding.c (encode_designation_at_bol): New args charbuf_end and
7521 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
7522 (coding_set_source): Return how many bytes coding->source was
7523 relocated.
7524 (coding_set_destination): Return how many bytes
7525 coding->destination was relocated.
7526 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 7527 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
7528
75292011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7530
7531 * coding.c (CODING_CHAR_CHARSET_P): New macro.
7532 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
7533 macro (Bug#9318).
7534
75352011-12-05 Andreas Schwab <schwab@linux-m68k.org>
7536
7537 The following changes are to fix Bug#9318.
7538
a79703f5 7539 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
7540 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
7541 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 7542 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 7543
7dbda6df
JB
75442011-12-05 Juanma Barranquero <lekktu@gmail.com>
7545
7546 * lisp.h (process_quit_flag): Fix external declaration.
7547
6d5eb5b0
SM
75482011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
7549
7550 Don't macro-inline non-performance-critical code.
7551 * eval.c (process_quit_flag): New function.
7552 * lisp.h (QUIT): Use it.
7553
a0c3fad0
JD
75542011-12-04 Jan Djärv <jan.h.d@swipnet.se>
7555
7556 * nsfns.m (get_geometry_from_preferences): New function.
7557 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
7558
6c07aac2
AS
75592011-12-04 Andreas Schwab <schwab@linux-m68k.org>
7560
7561 * emacs.c (Qkill_emacs): Define.
7562 (syms_of_emacs): Initialize it.
7563 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
7564 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
7565 (quit_throw_to_read_char): Add parameter `from_signal'.
7566 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
7567 * lisp.h (QUIT): Call Fkill_emacs if requested.
7568
c052ead4
JD
75692011-12-03 Jan Djärv <jan.h.d@swipnet.se>
7570
7571 * widget.c (update_wm_hints): Return if wmshell is null.
7572 (widget_update_wm_size_hints): New function.
7573
7574 * widget.h (widget_update_wm_size_hints): Declare.
7575
7576 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
7577 widget_update_wm_size_hints (Bug#10104).
7578
9e49252b
EZ
75792011-12-03 Eli Zaretskii <eliz@gnu.org>
7580
7581 * xdisp.c (handle_invisible_prop): If the invisible text ends just
7582 before a newline, prepare the bidi iterator for consuming the
7583 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 7584 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 7585
02b16839
JL
75862011-12-02 Juri Linkov <juri@jurta.org>
7587
7588 * search.c (Fword_search_regexp): New Lisp function created from
7589 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
7590 (Fword_search_backward, Fword_search_forward)
7591 (Fword_search_backward_lax, Fword_search_forward_lax):
7592 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
7593 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
7594
0068070e
SM
75952011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
7596
7597 * fileio.c (Finsert_file_contents): Move after-change-function call
7598 to before the "handled:" label, since all "goto handled" appear in
7599 cases where the *-change-functions have already been properly called
7600 (bug#10117).
7601
3360a3fc
AS
76022011-12-01 Andreas Schwab <schwab@linux-m68k.org>
7603
7604 * keyboard.c (interrupt_signal): Don't call kill-emacs when
7605 waiting for input. (Bug#10169)
7606
73d6c093
EZ
76072011-11-30 Eli Zaretskii <eliz@gnu.org>
7608
7609 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
7610 verifies glyph row's hash code--we have just reallocated the
7611 glyphs, so their contents can be complete garbage. (Bug#10164)
7612
febe6bea
JB
76132011-11-30 Juanma Barranquero <lekktu@gmail.com>
7614
7615 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
7616
801a4313
EZ
76172011-11-30 Eli Zaretskii <eliz@gnu.org>
7618
7619 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
7620 attributes are tested _before_ calling verify_row_hash, to protect
7621 against GCC re-ordering of the tests. (Bug#10164)
7622
2b56b87e
JD
76232011-11-29 Jan Djärv <jan.h.d@swipnet.se>
7624
7625 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
7626
7627 * xterm.c (handle_one_xevent): Only set async_visible and friends
7628 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 7629 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
7630 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
7631
dbf31225
PE
76322011-11-28 Paul Eggert <eggert@cs.ucla.edu>
7633
7634 Remove GCPRO-related macros that exist only to avoid shadowing locals.
7635 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
7636 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
7637 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7638 All uses changed to use GCPRO1 etc.
7639 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
7640 Revert to old implementation (i.e., before 2011-03-11).
7641
1305621b
YM
76422011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7643
7644 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
7645 of scroll runs so as to avoid assigning disabled bogus rows and
7646 unnecessary graphics copy operations.
7647
8c9afb46
EZ
76482011-11-27 Eli Zaretskii <eliz@gnu.org>
7649
7650 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
7651 (snprintf) [_MSC_VER]: Redirect to _snprintf.
7652 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
7653 (malloc, free, realloc, calloc): Redirect to e_* only when
7654 compiling Emacs.
7655
7656 * lisp.h (GCTYPEBITS): Move before first use.
7657 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
7658 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
7659 this macro definition.
7660
7661 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
7662 _MSC_VER.
7663
54e9e3bf
JD
76642011-11-27 Jan Djärv <jan.h.d@swipnet.se>
7665
6d5eb5b0
SM
7666 * gtkutil.c (xg_create_frame_widgets):
7667 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
7668 present with Gtk+ 2.0.
7669
83aca1cb
PE
76702011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7671
7672 * fileio.c (Finsert_file_contents): Undo previous change; see
7673 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7674
5b76caa4
PE
76752011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7676
7677 Rename locals to avoid shadowing.
7678 * fileio.c (Finsert_file_contents):
7679 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
7680 * process.c (wait_reading_process_output):
7681 Rename inner 'proc' to 'p' to avoid shadowing.
7682 Indent for consistency with usual Emacs style.
7683
8c535114
EZ
76842011-11-25 Eli Zaretskii <eliz@gnu.org>
7685
7686 * xdisp.c (redisplay_window): If cursor row is not fully visible
7687 after recentering, and scroll-conservatively is set to a large
7688 number, scroll window by a few more lines to make the cursor fully
7689 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
7690 (start_display): Don't move to the next line if the display should
7691 start at a newline that is part of a display vector or an overlay
7692 string. (Bug#10119)
8c535114 7693
fa4fdb5c
JL
76942011-11-24 Juri Linkov <juri@jurta.org>
7695
7696 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
7697 after the `MagickPingImage' call. (Bug#10112)
7698
90ec88df
CY
76992011-11-23 Chong Yidong <cyd@gnu.org>
7700
7701 * window.c (Fcoordinates_in_window_p): Accept only live windows.
7702
56e2e794
MR
77032011-11-23 Martin Rudalics <rudalics@gmx.at>
7704
7705 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
7706 making another buffer current. (Bug#10114)
7707
b6e64c41
GM
77082011-11-23 Glenn Morris <rgm@gnu.org>
7709
7710 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
7711
6b21de18
CY
77122011-11-23 Chong Yidong <cyd@gnu.org>
7713
7714 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
7715 using it (Bug#5984).
7716
b12cd789
EZ
77172011-11-22 Eli Zaretskii <eliz@gnu.org>
7718
7719 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
7720 and header-lines, as they don't have one computed for them.
7721 (Bug#10098)
7722
7723 * .gdbinit (prow): Make displayed values more self-explaining.
7724 Add row's hash code.
7725
261b6fd4
LMI
77262011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
7727
7728 * process.c (wait_reading_process_output): Fix asynchrounous
7729 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 7730 (wait_reading_process_output): Add comment and URL.
261b6fd4 7731
e7cfd277
JD
77322011-11-21 Jan Djärv <jan.h.d@swipnet.se>
7733
7734 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
7735
a9b9b7f5
CY
77362011-11-21 Chong Yidong <cyd@gnu.org>
7737
7738 * window.c (Fnext_window, Fprevious_window): Doc fix.
7739
b0d15b4f
SM
77402011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7741
7742 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
7743
fe7a3057
JB
77442011-11-20 Juanma Barranquero <lekktu@gmail.com>
7745
7746 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
7747
d2999b1a
MR
77482011-11-20 Martin Rudalics <rudalics@gmx.at>
7749
7750 * window.c (Fset_window_combination_limit): Rename argument
7751 STATUS to LIMIT.
7752 (Vwindow_combination_limit): Remove "status" from doc-string.
7753
d5ff9cd0
AS
77542011-11-20 Andreas Schwab <schwab@linux-m68k.org>
7755
7756 * m/ibms390.h: Remove.
7757 * m/ibms390x.h: Don't include "ibms390.h".
7758
a5bb9bd3
SM
77592011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7760
7761 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
7762 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
7763
cd1181db
JB
77642011-11-20 Juanma Barranquero <lekktu@gmail.com>
7765
7766 * casetab.c (Fset_case_table):
7767 * charset.c (Fcharset_after): Fix typos.
7768
615a3b8d 77692011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 7770
17e845af
PE
7771 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
7772 Otherwise, valgrind does not work on some platforms.
7773 Problem reported by Andreas Schwab in
6a0bf43d
PE
7774 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
7775 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
7776 is set, removing the need for VIRT_ADDRESS_VARIES.
7777 (PURE_P): Use a more-efficient implementation that needs just one
7778 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
7779 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
7780 to 4 (xorl, subq, cmpq, setbe).
7781 * alloc.c (pure): Always extern now, since that's the
7782 VIRT_ADDR_VARIES behavior.
7783 (PURE_POINTER_P): Use a single comparison, not two, for
7784 consistency with the new puresize.h.
7785 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
7786 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
7787 Remove VIRT_ADDR_VARIES no longer needed.
7788
f8fe6f96
EZ
77892011-11-19 Eli Zaretskii <eliz@gnu.org>
7790
7791 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
7792 (erase_phys_cursor, update_window_cursor, show_mouse_face)
7793 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
7794 behave as if the cursor position were at the window margin.
7795
7796 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
7797 and the cursor position is out of bounds, behave as if the cursor
7798 position were at the window margin. (Bug#10075)
7799
df05a53c
CY
78002011-11-18 Chong Yidong <cyd@gnu.org>
7801
7802 * window.c (Fwindow_combination_limit): Make first argument
7803 non-optional, since it is meaningless for live windows like the
7804 selected window.
61ccba97 7805
2071918e
DA
78062011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
7807
7808 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
7809
b50a28de
SM
78102011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
7811
7812 * intervals.c: Fix grafting over the whole buffer (bug#10071).
7813 (graft_intervals_into_buffer): Simplify.
7814
015137db
EZ
78152011-11-18 Eli Zaretskii <eliz@gnu.org>
7816
7817 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
7818 hash values of the two rows.
7819 (copy_row_except_pointers): Preserve the used[] arrays and the
7820 hash values of the two rows. (Bug#10035)
68c95424 7821 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
7822
7823 * xdisp.c (row_hash): New function, body extracted from
7824 compute_line_metrics.
7825 (compute_line_metrics): Call row_hash, instead of computing the
7826 hash code inline.
7827
7828 * dispnew.c (verify_row_hash): Call row_hash for computing the
7829 hash code of a row, instead of duplicating code from xdisp.c.
7830
7831 * dispextern.h (row_hash): Add prototype.
7832
a2addb04
TH
78332011-11-18 Tassilo Horn <tassilo@member.fsf.org>
7834
7835 * frame.c (delete_frame): Don't delete the terminal when the last
7836 X frame is closed if emacs is built with GTK toolkit.
7837
df85d315
JB
78382011-11-17 Juanma Barranquero <lekktu@gmail.com>
7839
7840 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
7841
a0c2d0ae
MR
78422011-11-17 Martin Rudalics <rudalics@gmx.at>
7843
7844 * window.c (Vwindow_splits): Rename to
7845 Vwindow_combination_resize. Suggested by Juri Linkov.
7846 (Fsplit_window_internal): Use Vwindow_combination_resize instead
7847 of Vwindow_splits.
7848
58179cce
JB
78492011-11-16 Juanma Barranquero <lekktu@gmail.com>
7850
7877f373
JB
7851 * nsfns.m (Fns_font_name):
7852 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 7853
b6f67890
MR
78542011-11-16 Martin Rudalics <rudalics@gmx.at>
7855
7856 * window.h (window): Rename slot "nest" to "combination_limit".
7857 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
7858 (Fset_window_nest): Rename to Fset_window_combination_limit.
7859 (Vwindow_nest): Rename to Vwindow_combination_limit.
7860 (recombine_windows, make_parent_window, make_window)
7861 (Fsplit_window_internal, saved_window)
7862 (Fset_window_configuration, save_window_save): Rename all
7863 occurrences of window_nest to window_combination_limit.
7864
c7015153
JB
78652011-11-15 Juanma Barranquero <lekktu@gmail.com>
7866
7867 * image.c (imagemagick_load_image): Fix typo.
7868
322ad6ec
EZ
78692011-11-14 Eli Zaretskii <eliz@gnu.org>
7870
7871 * xdisp.c (display_line): Move the call to
7872 highlight_trailing_whitespace before the call to
7873 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
7874 faces of all the glyphs to compute ROW's hash value.
7875 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 7876
f067b8ec
JB
78772011-11-14 Juanma Barranquero <lekktu@gmail.com>
7878
7879 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
7880 just return (bug#10044).
7881
1e5b2111
EZ
78822011-11-12 Eli Zaretskii <eliz@gnu.org>
7883
7ef3cbd5
EZ
7884 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
7885 with user-defined heap size. Bump the default size of the temacs
7886 heap to 27MB, to avoid memory warning when running temacs.
7887 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
7888
1e5b2111
EZ
7889 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
7890 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
7891 (verify_row_hash) [XASSERTS]: New function.
7892 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
7893 that the hash value of glyph rows is correct.
1e5b2111 7894
89d61221
MR
78952011-11-12 Martin Rudalics <rudalics@gmx.at>
7896
7897 * window.h (window): Remove splits slot.
7898 * window.c (Fwindow_splits, Fset_window_splits): Remove.
7899 (Fdelete_other_windows_internal, make_parent_window)
7900 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7901 (Fset_window_configuration, save_window_save): Don't deal with
7902 split status of windows.
7903 (saved_window): Remove splits slot.
7904 (Vwindow_splits): Rewrite doc-string.
7905
97f18cc8
JD
79062011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7907
7908 * xfns.c (unwind_create_frame):
7909 * nsfns.m (unwind_create_frame):
7910 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7911 Vframe_list (Bug#9999).
7912
22a648b4
DA
79132011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7914
0b381c7e 7915 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7916
659afede
KH
79172011-11-11 Kenichi Handa <handa@m17n.org>
7918
7919 * callproc.c (Fcall_process): Set the member dst_multibyte of
7920 process_coding.
7921
9ac0394b
KH
79222011-11-11 Johan Bockgård <bojohan@gnu.org>
7923
7924 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7925 avoid a crash (bug#9496).
7926
2fbdc249
CY
79272011-11-09 Chong Yidong <cyd@gnu.org>
7928
7929 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7930 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7931
ac6b1f81
PE
79322011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7933
7934 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7935
09db192c
PE
79362011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7937
7938 Avoid some portability problems by eschewing 'extern inline' functions.
7939 The trivial performance wins aren't worth the portability hassles; see
7940 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7941 et seq.
7942 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7943 (window_box_width, window_box_left, window_box_left_offset)
7944 (window_box_right, window_box_right_offset): Undo previous change,
7945 by removing the "extern"s.
7946 * intervals.c (adjust_intervals_for_insertion)
7947 (adjust_intervals_for_deletion): Undo previous change,
7948 making these static again.
7949 (offset_intervals, temp_set_point_both, temp_set_point)
7950 (copy_intervals_to_string): No longer inline.
7951 * xdisp.c (window_text_bottom_y, window_box_width)
7952 (window_box_height, window_box_left_offset)
7953 (window_box_right_offset, window_box_left, window_box_right)
7954 (window_box): No longer inline.
7955
105216ed
CY
79562011-11-08 Chong Yidong <cyd@gnu.org>
7957
7958 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7959 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7960 Signal an error if not a live window.
105216ed
CY
7961 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7962 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7963
ae9e237f
JB
79642011-11-07 Juanma Barranquero <lekktu@gmail.com>
7965
7966 * lisp.h (syms_of_abbrev): Remove declaration.
7967 Reported by CHENG Gao <chenggao@royau.me>.
7968
c7aa8333
EZ
79692011-11-07 Eli Zaretskii <eliz@gnu.org>
7970
7971 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7972 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7973 of temacs in GUI mode.
7974
be7f5545
MR
79752011-11-07 Martin Rudalics <rudalics@gmx.at>
7976
7977 * window.h: Declare delete_all_child_windows instead of
7978 delete_all_subwindows.
7979 * window.c (Fwindow_nest, Fset_window_nest)
7980 (Fset_window_new_total, Fset_window_new_normal)
7981 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7982 (delete_all_subwindows): Rename to delete_all_child_windows.
7983 (Fdelete_other_windows_internal, Fset_window_configuration):
7984 Call delete_all_child_windows instead of delete_all_subwindows.
7985 * frame.c (delete_frame): Call delete_all_child_windows instead
7986 of delete_all_subwindows.
7987
ca78dc43
PE
79882011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7989
7990 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7991 This is also needed for porting to any host where GC_MARK_STACK is
7992 not GC_MAKE_GCPROS_NOOPS.
7993 (which_symbols): Use it.
7994
a0241d01
KH
79952011-11-07 Kenichi Handa <handa@m17n.org>
7996
7997 * coding.c (coding_set_destination): Check coding->src_pos only
7998 when coding->src_object is a buffer (bug#9910).
7999
8000 * process.c (send_process): Set the member src_multibyte of coding
8001 to 0 (bug#9911) when sending a unibyte text.
8002
8003 * callproc.c (Fcall_process): Set the member src_multibyte of
8004 process_coding to 0 (bug#9912).
8005
a64bfdfa 80062011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
8007
8008 * xmenu.c (cleanup_widget_value_tree): New function.
8009 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
8010 calling free_menubar_widget_value_tree directly (Bug#9830).
8011
cb41b32a
PE
80122011-11-06 Paul Eggert <eggert@cs.ucla.edu>
8013
8014 Fix some portability problems with 'inline'.
8015 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8016 (window_box_width, window_box_left, window_box_left_offset)
8017 (window_box_right, window_box_right_offset): Declare extern.
8018 Otherwise, these inline functions do not conform to C99 and
8019 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
8020 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
8021 * intervals.c (adjust_intervals_for_insertion)
8022 (adjust_intervals_for_deletion): Now extern, because otherwise the
8023 extern inline functions 'offset_intervals' couldn't refer to it.
8024 (static_offset_intervals): Remove.
8025 (offset_intervals): Rewrite using the old contents of
8026 static_offset_intervals. The old version didn't conform to C99
8027 because an extern inline function contained a reference to an
8028 identifier with static linkage.
8029
b7041366
AS
80302011-11-06 Andreas Schwab <schwab@linux-m68k.org>
8031
8032 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
8033 GC.
8034
88a37c4d
EZ
80352011-11-06 Eli Zaretskii <eliz@gnu.org>
8036
8037 * xdisp.c (init_iterator, reseat_to_string): Don't set the
8038 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
8039 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8040 return Qleft_to_right.
8041
49745b39
CY
80422011-11-06 Chong Yidong <cyd@gnu.org>
8043
8044 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
8045 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
8046 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
8047 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
8048 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
8049 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
8050 (Fwindow_vscroll): Doc fix.
8051 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
8052 argument, since it makes no sense to pass a live window and for
8053 consistency with window-child.
8054
1f05cd82
CS
80552011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
8056
8057 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
8058 support MSVC.
8059
22610910
JR
80602011-11-05 Jason Rumney <jasonr@gnu.org>
8061
8062 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
8063 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
8064 fonts (Bug#6029).
8065 (add_font_entity_to_list): Fix logic errors in mixed boolean and
8066 bitwise arithmetic preventing use of unicode-sip and non-truetype
8067 opentype fonts.
8068
a06776b2
EZ
80692011-11-05 Eli Zaretskii <eliz@gnu.org>
8070
3ad924ba
EZ
8071 * s/ms-w32.h (fstat, stat, utime): Move redirections to
8072 "emacs"-only part.
8073
a06776b2
EZ
8074 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
8075 initialization code to keep similarity to xfns.c after changes
8076 from 2011-11-05.
8077
c9e7db78
JD
80782011-11-05 Jan Djärv <jan.h.d@swipnet.se>
8079
a97f8f3f
JD
8080 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
8081 (unwind_create_frame): New function (Bug#9943).
8082 (Fx_create_frame): Restructure code to be more similar to the one in
8083 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
8084 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
8085 Move terminal->reference_count++ just before making the frame official
8086 (Bug#9943).
8087
8088 * nsterm.m (x_free_frame_resources): New function.
8089 (x_destroy_window): Move code to x_free_frame_resources.
8090
c9e7db78 8091 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
8092 (Fx_create_frame, x_create_tip_frame):
8093 Move terminal->reference_count++ just before making the frame
75f1671a 8094 official. Move initialization of image_cache_refcount and
c9e7db78
JD
8095 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
8096
a6fc3b5c
EZ
80972011-11-05 Eli Zaretskii <eliz@gnu.org>
8098
8099 Support MSVC build with newer versions of Visual Studio.
8100 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
8101 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
8102 nt/gmake.defs.
8103
8104 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
8105 which are not supported by MSVC.
8106 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
8107 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
8108 bitfields.
8109 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
8110 types in bitfields.
8111 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
8112
8113 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
8114
58179cce 81152011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
8116
8117 Support MSVC build with newer versions of Visual Studio.
8118 * w32.c: Don't include w32api.h for MSVC.
8119 (init_environment) [_MSC_VER]: Call sys_access, not _access.
8120
8121 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
8122 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
8123 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
8124 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
8125 e_* cousins.
8126 (alloca) [_MSC_VER]: Define to _alloca.
8127
8128 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
8129
8130 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
8131
a58c13ed
EZ
81322011-11-04 Eli Zaretskii <eliz@gnu.org>
8133
8134 * xdisp.c (note_mouse_highlight): If either of
8135 previous/next-single-property-change returns nil, treat that as
8136 the beginning or the end of the buffer. (Bug#9955)
8137
fe0b6370
JD
81382011-11-04 Jan Djärv <jan.h.d@swipnet.se>
8139
a58c13ed 8140 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
8141 label is not null (Bug#9951).
8142 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
8143 may be NULL.
8144
89bd5ee1
EZ
81452011-11-04 Eli Zaretskii <eliz@gnu.org>
8146
8147 * window.c (Fwindow_body_size): Mention in the doc string that the
8148 return value is in frame's canonical units. (Bug#9949)
8149
84c3edb9
EZ
81502011-11-03 Eli Zaretskii <eliz@gnu.org>
8151
4e2fb5c7
EZ
8152 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
8153
84c3edb9 8154 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 8155 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 8156 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 8157
bc17a887
EZ
81582011-11-01 Eli Zaretskii <eliz@gnu.org>
8159
8160 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
8161 Don't stop backward scan on the continuation glyph, even though
8162 its CHARPOS is positive.
6d5eb5b0
SM
8163 (mouse_face_from_buffer_pos, note_mouse_highlight):
8164 Rename cover_string to disp_string.
bc17a887 8165
4ee88440
MR
81662011-11-01 Martin Rudalics <rudalics@gmx.at>
8167
8168 * window.c (temp_output_buffer_show): Don't use
8169 Vtemp_buffer_show_specifiers.
8170 (Vtemp_buffer_show_specifiers): Remove unused variable.
8171
c2ff3c02
EZ
81722011-10-30 Eli Zaretskii <eliz@gnu.org>
8173
8174 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
8175 past the beginning of the current glyph matrix.
8176
58179cce 81772011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
8178
8179 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
8180 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
8181 HAVE_GTK3 (Bug#9869).
b77a6a7f 8182
3b574623
JD
8183 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
8184 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
8185
b77a6a7f
JD
8186 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
8187
8188 * xterm.c: Declare x_handle_net_wm_state to return int.
8189 (handle_one_xevent): Check if we are iconified but don't have
8190 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
8191 (get_current_wm_state): Return non-zero if not hidden,
8192 check for _NET_WM_STATE_HIDDEN (Bug#9893).
8193 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
8194 (x_handle_net_wm_state): Return what get_current_wm_state returns.
8195 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
8196
196e41e4
PE
81972011-10-29 Paul Eggert <eggert@cs.ucla.edu>
8198
8199 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
8200 so that this new function doesn't get optimized away by a
8201 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
8202
021f2e1a
AS
82032011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8204
8205 * frame.h (MOUSE_HL_INFO): Remove excess parens.
8206
8b058d44
EZ
82072011-10-29 Eli Zaretskii <eliz@gnu.org>
8208
8209 Fix the `xbytecode' command.
8210 * .gdbinit (xprintbytestr): New command.
b50a28de 8211 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
8212 (xbytecode): Print the byte-code string as well.
8213
4452fb80
EZ
82142011-10-29 Kim Storm <storm@cua.dk>
8215
8b058d44
EZ
8216 * alloc.c (which_symbols): New function.
8217
21b72067
AS
82182011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8219
8220 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
8221 line. (Bug#9903)
8222
83ed7b5c
GM
82232011-10-29 Glenn Morris <rgm@gnu.org>
8224
8225 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
8226 Not clear what it was for, and it causes various bugs. (Bug#9839)
8227
5a7a728b
EZ
82282011-10-28 Eli Zaretskii <eliz@gnu.org>
8229
8230 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
8231 possible random value that matches one of those tested as
8232 condition to clear the mouse face.
8233
d3d0842f
CY
82342011-10-28 Chong Yidong <cyd@gnu.org>
8235
8236 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
8237
31b39d13
DN
82382011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
8239
8240 * window.c (make_window): Initialize phys_cursor_on_p.
8241
9aba6043
SM
82422011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
8243
8244 * lisp.h (struct Lisp_Symbol): Update comments.
8245
c20992f4
JB
82462011-10-28 Juanma Barranquero <lekktu@gmail.com>
8247
8248 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
8249
db4f02f2
EZ
82502011-10-28 Eli Zaretskii <eliz@gnu.org>
8251
8252 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
8253 <oslsachem@gmail.com> for helping to debug this.
8254
8255 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
8256 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
8257 (g_b_init_get_glyph_outline_w): New static variables.
8258 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
8259 (GetGlyphOutlineW_Proc): New typedefs.
8260 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
8261 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
8262 New functions.
8263 (w32font_open_internal, compute_metrics):
8264 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
8265 instead of calling the "wide" APIs directly.
8266
8267 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
8268
8269 * w32.h (syms_of_w32font): Add prototype.
8270
87e68db4
JB
82712011-10-27 Juanma Barranquero <lekktu@gmail.com>
8272
8273 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
8274 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
8275 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
8276 (Fmove_to_window_line): Doc fix.
8277
435c1d67
CY
82782011-10-27 Chong Yidong <cyd@gnu.org>
8279
8280 * process.c (make_process): Set gnutls_state to NULL.
8281
8282 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
8283 non-NULL, regardless of GNUTLS_INITSTAGE.
8284 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
8285 an error. Set process slots as soon as we allocate them.
8286
8287 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
8288
9c6c6f49
CY
82892011-10-27 Chong Yidong <cyd@gnu.org>
8290
9aba6043
SM
8291 * gnutls.c (emacs_gnutls_deinit): New function.
8292 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
8293 (Fgnutls_deinit, Fgnutls_boot): Use it.
8294
8295 * process.c (make_process): Initialize GnuTLS credentials to NULL.
8296 (deactivate_process): Call emacs_gnutls_deinit.
8297
657d08d3
JB
82982011-10-27 Juanma Barranquero <lekktu@gmail.com>
8299
8300 * image.c (x_create_x_image_and_pixmap):
8301 * w32.c (sys_rename, w32_delayed_load):
8302 * w32font.c (fill_in_logfont):
8303 * w32reg.c (x_get_string_resource): Silence compiler warnings.
8304
5430d399
JB
83052011-10-26 Juanma Barranquero <lekktu@gmail.com>
8306
8307 * w32fns.c (w32_default_color_map): New function,
8308 extracted from Fw32_default_color_map.
a7ef684b 8309 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 8310
fe0055fa
PE
83112011-10-25 Paul Eggert <eggert@cs.ucla.edu>
8312
8313 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
8314
e6346438
SM
83152011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
8316
8317 * keyboard.c (test_undefined): New function (bug#9751).
8318 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
8319
e112cc37
ET
83202011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
8321
8322 * sysdep.c (init_sys_modes): Fix the check for the controlling
8323 terminal (Bug#6649).
8324
7b5d6677
EZ
83252011-10-20 Eli Zaretskii <eliz@gnu.org>
8326
8327 * dispextern.h (struct bidi_it): New member next_en_type.
8328
8329 * bidi.c (bidi_line_init): Initialize the next_en_type member.
8330 (bidi_resolve_explicit_1): When next_en_pos is valid for the
8331 current character, check also for next_en_type being WEAK_EN.
8332 (bidi_resolve_weak): Don't enter the expensive loop if the current
8333 position is before next_en_pos. Record the bidi type of the first
8334 non-ET, non-BN character we find, in addition to its position.
8335 (bidi_level_of_next_char): Invalidate next_en_type when
8336 next_en_pos is over-stepped.
8337
7da0b018
PE
83382011-10-20 Paul Eggert <eggert@cs.ucla.edu>
8339
8340 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
8341 * editfns.c: Rewrite current-time-zone so that it invokes
8342 the equivalent of (format-time-string "%Z") to get the time zone name.
8343 This fixes a bug when the time zone name contains characters that
8344 need converting from the system time locale to Emacs internal format.
8345 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
8346 that patch fixed format-time-string to do the conversion, but
8347 I forgot to fix current-time-zone.
8348 (format_time_string): New function, containing most of
8349 what Fformat_time_string used to contain.
8350 (Fformat_time_string): Rewrite in terms of format_time_string.
8351 This doesn't change this function's behavior.
8352 (current-time-zone): Rewrite to use format_time_string.
8353 This fixes the bug reported by Michael Schierl in
8354 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
8355 Jason Rumney's 2007-06-07 change worked around this bug, but
8356 didn't fix it.
8357 * systime.h (tzname, timezone): Remove no-longer-used declarations.
8358
8547b010
EZ
83592011-10-19 Eli Zaretskii <eliz@gnu.org>
8360
8361 * xdisp.c (start_display): If the character at POS is displayed
8362 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
8363 (try_window_reusing_current_matrix): If a line ends in a display
8364 vector or the next line starts in a display vector, continue
8365 redrawing the window even though the character position of
8366 start_row was reached.
8547b010
EZ
8367 (Bug#9771, part 2)
8368
4e948d15
CY
83692011-10-18 Chong Yidong <cyd@gnu.org>
8370
8371 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
8372 with nobreak-char-display too.
8373
4787455f
EZ
83742011-10-18 Eli Zaretskii <eliz@gnu.org>
8375
8376 Fix part 3 of bug#9771.
8377 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
8378 (bidi_resolve_neutral): Don't enter the expensive loop looking for
8379 non-neutral characters if the current character is a paragraph
8380 separator (a.k.a. Newline). This avoids running the same
8381 expensive loop twice, once when we consume the preceding newline
8382 and the other time when the line actually needs to be displayed.
8383 Avoid the loop when we see neutrals on the base embedding level
8384 following a character whose directionality is the same as the
8385 paragraph's. This avoids running the expensive loop when a line
8386 ends in a long sequence of neutrals, like control characters.
8387 Add assertion against STRONG_AL type. Slightly rearrange code
8388 that determines the type of a neutral given the first non-neutral
8389 that follows it.
8390 (bidi_level_of_next_char): Set next_en_pos to zero when
8391 invalidating its info.
8392
2c91f553
EZ
83932011-10-17 Eli Zaretskii <eliz@gnu.org>
8394
8395 * xdisp.c (push_display_prop): Determine whether to record string
8396 or buffer position by IT->string, not by IT->method. Allow
8397 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
8398 (move_it_vertically_backward): Don't look for character position
8399 immediately after the newline when in a continuation line.
8400 (Bug#9771, part 1)
2c91f553 8401
c7b08b0d
MR
84022011-10-15 Martin Rudalics <rudalics@gmx.at>
8403
8404 * window.c (coordinates_in_window): Rewrite and delabelize
8405 vertical border check. (Bug#5357) (Bug#9618)
8406
6b02f655
SM
84072011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
8408
8409 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
8410 errors in XSetWindowBorder (bug#9310).
8411
81d40c92
DA
84122011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
8413
8414 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
8415 avoid crash when xmalloc overrun checking is enabled.
8416
d4172c3b
EZ
84172011-10-13 Eli Zaretskii <eliz@gnu.org>
8418
8419 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
8420 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
8421 cursor motion with <left> and <right> arrow keys.
8422
8423 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
8424 some callers set that themselves.
8425
b00eea75
EZ
84262011-10-12 Eli Zaretskii <eliz@gnu.org>
8427
8428 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
8429 display string and the previous row comes from the same string and
8430 is empty. (Bug#9739) (Bug#9738)
8431
8fe012c4
SM
84322011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
8433
8434 * doc.c (get_doc_string): Encode file name (bug#9735).
8435
0074aef2
EZ
84362011-10-12 Eli Zaretskii <eliz@gnu.org>
8437
79beb178
EZ
8438 * bidi.c (bidi_level_of_next_char):
8439 * xdisp.c (get_visually_first_element): Remove old incorrect
8440 comments regarding the Unicode Line Separator character.
8441
0074aef2
EZ
8442 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
8443
6e4b3fbe
DA
84442011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
8445
8446 * alloc.c (Fgc_status): Do not access beyond zombies array
8447 boundary if nzombies > MAX_ZOMBIES.
8448 * alloc.c (dump_zombies): Add missing format specifier.
8449
0324f3af
PE
84502011-10-12 Paul Eggert <eggert@cs.ucla.edu>
8451
b5525cac
PE
8452 * xdisp.c (set_cursor_from_row): Simplify conditionals,
8453 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
8454
0324f3af
PE
8455 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
8456 Some packages use them to denote characters with modifiers.
8457
e9b5f888
AS
84582011-10-11 Andreas Schwab <schwab@linux-m68k.org>
8459
8460 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
8461 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
8462 matching a pp-number. Rename parameter var to var1.
8463
127827c0
SM
84642011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
8465
8466 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
8467
c8fd3bd0
GM
84682011-10-08 Glenn Morris <rgm@gnu.org>
8469
8470 * callint.c (Fcall_interactively): Give a more explicit error for the
8471 'c' case with a non-character input. (Bug#8479)
8472
352ec8ff
EZ
84732011-10-08 Eli Zaretskii <eliz@gnu.org>
8474
03669ccb
EZ
8475 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
8476 lines.
7061c986
EZ
8477 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
8478 lines that are hscrolled on the left.
03669ccb 8479
352ec8ff
EZ
8480 * dispnew.c (buffer_posn_from_coords): Account for a possible
8481 presence of header-line. (Bug#4426)
8482
a66cfb1c
SM
84832011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
8484
6b02f655
SM
8485 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
8486 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 8487
7c5ee88e
PE
84882011-10-07 Paul Eggert <eggert@cs.ucla.edu>
8489
8490 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
8491 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
8492 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
8493 this makes Emacs dump core during garbage collection on rare
8494 occasions. sizeof is obviously inferior to offsetof here, so
8495 stick with offsetof.
8496 (GC_POINTER_ALIGNMENT): New macro.
8497 (mark_memory): Omit 3rd (offset) arg; caller changed.
8498 Don't assume EMACS_INT alignment is the same as pointer alignment.
8499
df1bbe5b
SM
85002011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
8501
8502 * keyboard.c (read_key_sequence_remapped): New var.
8503 (read_key_sequence): Compute remapping in the right buffer.
8504 (command_loop_1): Use read_key_sequence's remapping directly.
8505
51553db6
SM
85062011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
8507
32c1fffd
SM
8508 * dired.c (file_name_completion): Don't expand file name.
8509 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
8510 before checking file name handler.
8511
51553db6
SM
8512 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
8513 they've been requested explicitly (bug#9591).
8514
b6bd1599 85152011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
8516
8517 * keymap.c (Fsingle_key_description): Use make_specified_string
8518 instead of build_string to build string from push_key_description.
8519 (Bug#5193)
8520
f701dc2a
PE
85212011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8522
4222c55d
PE
8523 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
8524 This fixes a Y2038 bug on 64-bit hosts.
8525 * buffer.c (reset_buffer):
8526 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
8527 (Fclear_buffer_auto_save_failure):
8528 Use 0, not -1, to represent an unset failure time, since time_t
8529 might not be signed.
8530
f701dc2a
PE
8531 Remove dependency on glibc malloc internals.
8532 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8533 Move back here from lisp.h, but with their new implementations.
8534 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8535 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
8536 * charset.c (charset_table_init): New static var.
8537 (syms_of_charset): Use it instead of xmalloc. This removes a
8538 dependency on glibc malloc internals. See Eli Zaretskii's comment in
8539 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
8540 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8541 Move back to alloc.c.
8542 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8543 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
8544
9ceebf39
JD
85452011-09-30 Jan Djärv <jan.h.d@swipnet.se>
8546
8547 * nsterm.m (windowDidResize): Call x_set_window_size only when
8548 ns_in_resize is true. Otherwise set pixelwidth/height and
8549 call change_frame_size (Bug#9628).
8550
cb993c58
PE
85512011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8552
3930c88b
PE
8553 Port --enable-checking=all to Fedora 14 x86-64.
8554 * charset.c (syms_of_charset): Also account for glibc malloc's
8555 internal overhead when calculating the initial malloc maximum.
8556
cb993c58
PE
8557 Port --enable-checking=all to Fedora 14 x86.
8558 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8559 Move to lisp.h.
8560 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
8561 (overrun_check_realloc, overrun_check_free):
8562 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
8563 That way, xmalloc returns a properly-aligned pointer even if
8564 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
8565 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
8566 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
8567 into account when calculating the initial malloc maximum.
8568 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8569 Move here from alloc.c, so that charset.c can use it too.
8570 Properly align; the old code wasn't right for common 32-bit hosts
8571 when configured with --enable-checking=all.
8572 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8573 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
8574
31bed486
EZ
85752011-09-29 Eli Zaretskii <eliz@gnu.org>
8576
04c70788 8577 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
8578 use EDOM.
8579
fbcaa2f3
EZ
85802011-09-28 Eli Zaretskii <eliz@gnu.org>
8581
8582 * xdisp.c (compute_display_string_end): If there's no display
8583 string at CHARPOS, return -1.
8584
8585 * bidi.c (bidi_fetch_char): When compute_display_string_end
8586 returns a negative value, treat the character as a normal
8587 character not covered by a display string. (Bug#9624)
8588
a239d4e9
JB
85892011-09-28 Juanma Barranquero <lekktu@gmail.com>
8590
8591 * lread.c (Fread_from_string): Fix typo in docstring.
8592
88652fd5
EZ
85932011-09-27 Eli Zaretskii <eliz@gnu.org>
8594
8595 * xdisp.c (handle_invisible_prop): If invisible text ends on a
8596 newline, reseat the iterator instead of bidi-iterating there one
8597 character at a time. (Bug#9610)
32c1fffd
SM
8598 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
8599 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 8600
ed497dd4
AS
86012011-09-27 Andreas Schwab <schwab@linux-m68k.org>
8602
8603 * lread.c (readevalloop): Use correct code for NBSP.
8604 (read1): Likewise. (Bug#9608)
8605
b2bf61aa
MA
86062011-09-25 Michael Albinus <michael.albinus@gmx.de>
8607
8608 * dbusbind.c (Fdbus_register_signal): When service is not
8609 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
8610
32bbb17c
GM
86112011-09-25 Glenn Morris <rgm@gnu.org>
8612
8613 * buffer.c (truncate-lines): Doc fix.
8614
94e0933e
CY
86152011-09-24 Chong Yidong <cyd@stupidchicken.com>
8616
8617 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
8618 (Fset_window_next_buffers): Doc fix.
8619
cddde921
GM
86202011-09-24 Glenn Morris <rgm@gnu.org>
8621
8622 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
8623
1260aef1
PE
86242011-09-24 Paul Eggert <eggert@cs.ucla.edu>
8625
25b4bfa0
PE
8626 Fix minor problems found by static checking.
8627 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
8628 * indent.c (Fvertical_motion): Fix == vs = typo.
8629
e3cbd34b
EZ
86302011-09-24 Eli Zaretskii <eliz@gnu.org>
8631
a66cfb1c
SM
8632 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
8633 Default value is now t. Doc fix.
6bf7006f 8634
e3cbd34b 8635 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 8636 logic when moving up, not only when moving down. Fix the
e3cbd34b 8637 confusing name and values of the it_overshoot_expected variable;
32c1fffd 8638 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
8639
8640 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
8641 CHARPOS is covered by a display string which includes newlines.
8642 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
8643 is covered by a display string with embedded newlines.
8644
a3de0cbd
MA
86452011-09-24 Michael Albinus <michael.albinus@gmx.de>
8646
8647 * dbusbind.c (Fdbus_register_signal): Add match rule to
8648 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
8649 (Fdbus_register_method, Vdbus_registered_objects_table):
8650 Fix docstring.
a3de0cbd 8651
b260039d
JM
86522011-09-24 Jim Meyering <meyering@redhat.com>
8653
32c1fffd 8654 do not ignore write error for any output size
b260039d
JM
8655 The previous change was incomplete.
8656 While it makes emacs --batch detect the vast majority of stdout
8657 write failures, errors were still ignored whenever the output size is
8658 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
8659 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
8660 && echo FAIL: ignored write error
8661 FAIL: ignored write error
8662 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
8663 && echo FAIL: ignored write error
8664 FAIL: ignored write error
8665 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
8666
8eca8a7c
AS
86672011-09-23 Andreas Schwab <schwab@linux-m68k.org>
8668
8669 * emacs.c (Fkill_emacs): In noninteractive mode exit
8670 non-successfully if a write error occurred on stdout. (Bug#9574)
8671
3341db62
EZ
86722011-09-21 Eli Zaretskii <eliz@gnu.org>
8673
8674 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
8675 the xassert test.
8676
8677 * dispextern.h (struct it): Update the comment documenting what
8678 can it->OBJECT be.
8679
8c203dbf
EZ
86802011-09-20 Eli Zaretskii <eliz@gnu.org>
8681
8682 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
8683 a display string, extend search for cursor position to end of row.
8684 (find_row_edges): If the row ends in a newline from a display
8685 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
8686 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
8687 (Fcurrent_bidi_paragraph_direction): Fix search for previous
8688 non-empty line. Fixes confusing cursor motion with arrow keys at
8689 the beginning of a line that starts with whitespace.
8c203dbf 8690
a4824228
LMI
86912011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8692
8693 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
8694 (bug#9493).
8695
33ed493b
CY
86962011-09-18 Chong Yidong <cyd@stupidchicken.com>
8697
8698 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
8699 boolean (Bug#9154).
8700
56cd55c8
EZ
87012011-09-18 Eli Zaretskii <eliz@gnu.org>
8702
8703 * xdisp.c (display_line): Record maximum and minimum buffer
8704 positions even if no glyphs were produced (e.g., by a zero-width
8705 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
8706 buffer positions that will be removed from the glyph row because
8707 they don't fit.
c02dcedf
EZ
8708 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
8709 column is beyond frame width: don't subtract 1 "pixel" when
8710 computing width of the stretch.
3e62b7e0
EZ
8711 (reseat_at_next_visible_line_start): Undo the change made on
8712 2011-09-17 that saved paragraph information and restored it after
8713 the call to `reseat'. (Bug#9545)
56cd55c8 8714
5ed99d36 87152011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
8716
8717 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
8718 and turn window cursor on if cleared (Bug#9415).
8719
5ed99d36 87202011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
8721
8722 * search.c (boyer_moore): Take unibyte characters from pattern
8723 literally. (Bug#9458)
8724
9bade7b2
EZ
87252011-09-18 Eli Zaretskii <eliz@gnu.org>
8726
8727 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
8728
e5e9d610
PE
87292011-09-18 Paul Eggert <eggert@cs.ucla.edu>
8730
87e4427a
PE
8731 Fix minor problem found by static checking.
8732 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
8733 initialized, to pacify gcc -Wuninitialized.
8734
e5e9d610
PE
8735 * fileio.c: Report proper errno when syscall falls.
8736 (Finsert_file_contents): Save and restore errno,
8737 so that report_file_error outputs the correct diagnostic.
8738 (Fwrite_region) [CLASH_DETECTION]: Likewise.
8739
a1674f0b
EZ
87402011-09-18 Eli Zaretskii <eliz@gnu.org>
8741
8742 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
8743
fbfb6dd4
EZ
87442011-09-17 Eli Zaretskii <eliz@gnu.org>
8745
8746 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
8747 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
8748
bb187662
EZ
87492011-09-17 Eli Zaretskii <eliz@gnu.org>
8750
1137e8b8 8751 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 8752 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
8753
8754 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
8755 (bidi_find_paragraph_start): Search back for paragraph beginning
8756 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
8757 (bidi_move_to_visually_next): Only trigger paragraph-related
8758 computations when the last character is a newline or at EOB, not
8759 just any NEUTRAL_B. (Bug#9470)
8760
bb187662
EZ
8761 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
8762 truncated lines if point is covered by a display string. (Bug#9524)
8763
2e621251
PE
87642011-09-16 Paul Eggert <eggert@cs.ucla.edu>
8765
8766 * xselect.c: Relax test for outgoing X longs (Bug#9498).
8767 (cons_to_x_long): New function.
8768 (lisp_data_to_selection_data): Use it. Correct the test for
8769 short-versus-long data; it was negated. Break out of vector
8770 loop, for efficiency, when a long datum is discovered.
8771
91a15bc6
SM
87722011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
8773
8774 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
8775
b41c3a35
EZ
87762011-09-16 Eli Zaretskii <eliz@gnu.org>
8777
8778 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
8779 GCC PR/17406) by declaring this function with external scope.
8780
7812ba2d
PE
87812011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8782
8783 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
8784 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
8785
cf7edc2a
AS
87862011-09-15 Andreas Schwab <schwab@linux-m68k.org>
8787
8788 * editfns.c (Fformat): Correctly handle text properties on "%%".
8789
bd01620e
EZ
87902011-09-15 Eli Zaretskii <eliz@gnu.org>
8791
8792 * xterm.c (x_draw_composite_glyph_string_foreground):
8793 * w32term.c (x_draw_composite_glyph_string_foreground):
8794 * term.c (encode_terminal_code):
8795 * composite.c (composition_update_it, get_composition_id):
8796 * xdisp.c (get_next_display_element)
8797 (fill_composite_glyph_string): Add comments about special meaning
8798 of TAB characters in a composition.
8799
a02719a3
PE
88002011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8801
8802 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
8803 This occurs when processing a multibyte format.
8804 Problem reported by Wolfgang Jenker.
a02719a3 8805
72589a3c
JB
88062011-09-15 Johan Bockgård <bojohan@gnu.org>
8807
8808 * xdisp.c (try_cursor_movement): Only check for exact match if
8809 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
8810
1c14176c
PE
88112011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8812
8813 Remove unused external symbols.
8814 * dispextern.h (calc_pixel_width_or_height): Remove decl.
8815 * xdisp.c (calc_pixel_width_or_height): Now static.
8816 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
8817 * indent.c (check_display_width):
8818 * w32term.c: Fix comment to match code.
8819 * xterm.c, xterm.h (x_catching_errors): Remove.
8820
d2eea5b5
PE
88212011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8822
8823 * xselect.c: Use signed conversions more consistently (Bug#9498).
8824 (selection_data_to_lisp_data): Assume incoming selection data are
8825 signed integers, not unsigned. This is to be consistent with
8826 outgoing selection data, which was modified to use signed integers
8827 in as part of the fix to Bug#9196 in response to Jan D.'s comment
8828 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
8829 expects long, not unsigned long.
8830
46888499
EZ
88312011-09-14 Eli Zaretskii <eliz@gnu.org>
8832
8833 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
8834 computation of loop end. Reported by Johan Bockgård
8835 <bojohan@gnu.org>.
8836
ef8ef9fb
CY
88372011-09-13 Chong Yidong <cyd@stupidchicken.com>
8838
8839 * frame.c (Fother_visible_frames_p): Function deleted.
8840
fa819fed
EZ
88412011-09-12 Eli Zaretskii <eliz@gnu.org>
8842
8843 * indent.c (compute_motion): Process display vector front to back
8844 rather than the other way around. (Bug#2496)
8845
2ba8e008
SM
88462011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
8847
8848 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
8849
20f53c69
CY
88502011-09-11 Chong Yidong <cyd@stupidchicken.com>
8851
8852 * minibuf.c (Fread_from_minibuffer): Doc fix.
8853
d562d7a4
EZ
88542011-09-11 Eli Zaretskii <eliz@gnu.org>
8855
8856 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
8857 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
8858
1c4d7f3d
LMI
88592011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8860
8861 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
8862 value for non-existent files.
8863
b885bf36
EZ
88642011-09-11 Eli Zaretskii <eliz@gnu.org>
8865
8866 * fileio.c (Finsert_file_contents): If the file cannot be opened,
8867 set its "size" to -1. This will set the modtime_size field of
8868 the corresponding buffer to -1, which is what
8869 verify-visited-file-modtime expects for files that do not exist.
8870 (Bug#9139)
8871
6612f0bf
PE
88722011-09-11 Paul Eggert <eggert@cs.ucla.edu>
8873
8874 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
8875 here ...
8876 * lisp.h: ... from here. push_key_description is no longer
8877 defined in keyboard.c, so its declaration should not be in
8878 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
8879 logically belongs with push_key_description.
8880
dfb3f755
PE
88812011-09-10 Paul Eggert <eggert@cs.ucla.edu>
8882
8883 * buffer.h: Include <sys/types.h> instead of <time.h>.
8884 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
8885 Problem reported by Herbert J. Skuhra.
8886
3134906c
LMI
88872011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8888
8889 * xml.c (parse_region): Make the parsing work for
8890 non-comment-starting XML files again (bug#9144).
8891
8d903f4e
AS
88922011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8893
8894 * image.c (gif_load): Fix calculation of bottom and right corner.
8895 (Bug#9468)
8896
80ad64f4
EZ
88972011-09-10 Eli Zaretskii <eliz@gnu.org>
8898
8899 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
8900 redisplay in small windows.
8901
208a048d
EZ
89022011-09-09 Eli Zaretskii <eliz@gnu.org>
8903
8904 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
8905
9b1c252e
MR
89062011-09-08 Martin Rudalics <rudalics@gmx.at>
8907
8908 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8909 Operate on live windows only.
8910
2949f33b
JB
89112011-09-08 Juanma Barranquero <lekktu@gmail.com>
8912
8913 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8914
e08dcafd
EZ
89152011-09-07 Eli Zaretskii <eliz@gnu.org>
8916
8917 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8918 only under bidi iteration.
8919
115b96bd
JD
89202011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8921
8922 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8923
c8199d0f
PE
89242011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8925
8926 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8927 Without this fix, the command to link temacs failed due to an
8928 undefined symbol __builtin_isnan. This is because
8929 /usr/include/iso/math_c99.h #defines isnan(x) to
8930 __builtin_isnan(x), but the bundled gcc, which identifies itself
8931 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8932 a __builtin_isnan.
8933 * floatfns.c (isnan): #undef, and then #define to a clone of
8934 what's in data.c.
8935 (Fisnan): Always define, since it's always available now.
8936 (syms_of_floatfns): Always define isnan at the Lisp level.
8937
e39b275c 89382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8939
8940 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8941
b2db44d9 89422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8943
f4af5137 8944 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8945 The previous code assumed that file offsets (off_t values) fit in
8946 EMACS_INT variables, which is not true on typical 32-bit hosts.
8947 The code messed up by falsely reporting buffer overflow in cases
8948 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8949 when "big" contains more than 2**29 bytes, even though this
8950 inserts just one byte and does not overflow the buffer.
8951 (Finsert_file_contents): Store file offsets as off_t
8952 values, not as EMACS_INT values. Check for overflow when
8953 converting between EMACS_INT and off_t. When checking for
8954 buffer overflow or for overlap, take the offsets into account.
8955 Don't use EMACS_INT for small values where int suffices.
8956 When checking for overlap, fix a typo: ZV was used where
8957 ZV_BYTE was intended.
8958 (Fwrite_region): Don't assume off_t fits into 'long'.
8959 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8960
ecfc0a49
MA
89612011-09-05 Michael Albinus <michael.albinus@gmx.de>
8962
8963 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8964
6511acf2 89652011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8966
0999621a 8967 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8968
8969 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8970 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8971 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8972 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8973 (modify_event_symbol): Do not assume that the length of
8974 name_alist_or_stem is safe to alloca and fits in int.
8975 (Fexecute_extended_command): Likewise for function name and binding.
8976 (Frecursion_depth): Wrap around reliably on integer overflow.
8977 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8978 since some callers pass EMACS_INT values.
8979 (Fsingle_key_description): Don't crash if symbol name contains more
8980 than MAX_ALLOCA bytes.
8981 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8982 (get_minibuffer): Arg is now EMACS_INT, not int.
8983 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8984 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8985 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8986
2be7d702
PE
8987 * dbusbind.c (signature_cat): New function.
8988 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8989 Do not overrun buffer; instead, report string overflow.
8990
9d1df220
PE
8991 * dispnew.c (add_window_display_history): Don't overrun buffer.
8992 Truncate instead; this is OK since it's just a log.
8993
33ef5c64
PE
8994 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8995 even if the time zone offset is outlandishly large.
8996 Don't mishandle offset == INT_MIN.
8997
66c6fdd5
PE
8998 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8999 when creating daemon; the previous buffer-overflow check was incorrect.
9000
d749b01b
PE
9001 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
9002 which has the guts of the old verror function.
9003
b5cd1905
PE
9004 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
9005 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
9006
6e1a67fb
PE
9007 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
9008 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 9009 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 9010 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
9011 length of string rather than counting it via multiple sprintfs;
9012 that's simpler and more reliable.
c21721cc
PE
9013 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
9014 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
9015 sprintf, in case result does not fit in int.
9016
c57b67fc
PE
9017 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
9018 (fontset_from_font): Print it.
9019
8a401434
PE
9020 * frame.c (tty_frame_count): Now printmax_t, not int.
9021 (make_terminal_frame, set_term_frame_name): Print it.
9022 (x_report_frame_params): In X, window IDs are unsigned long,
9023 not signed long, so print them as unsigned.
9024 (validate_x_resource_name): Check for implausibly long names,
9025 and don't assume name length fits in 'int'.
9026 (x_get_resource_string): Don't blindly alloca invocation name;
9027 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
9028 not fit in int.
9029
6e1a67fb
PE
9030 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
9031 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
9032 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
9033
0df02bf3
PE
9034 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
9035 Use esprintf, not sprintf, in case result does not fit in int.
9036
48e30793
PE
9037 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9038 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
9039 it as a large positive number.
9040 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
9041 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9042
a66ff6d8
PE
9043 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
9044 in case result does not fit in int.
9045
aca216ff
PE
9046 * print.c (float_to_string): Detect width overflow more reliably.
9047 (print_object): Make sprintf buffer a bit bigger, to avoid potential
9048 buffer overrun. Don't assume list length fits in 'int'. Treat
9049 print length of 0 as 0, not as infinity; to be consistent with other
9050 uses of print length in this function. Don't overflow print length
9051 index. Don't assume hash table size fits in 'long', or that
9052 vectorlike size fits in 'unsigned long'.
9053
31c286f7
PE
9054 * process.c (make_process): Use printmax_t, not int, to format
9055 process-name gensyms.
9056
55e5faa1
PE
9057 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
9058
80f2e268
PE
9059 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
9060 to avoid potential buffer overrun.
9061
670741ab
PE
9062 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
9063 if X resource line is longer than 512 bytes.
9064
b7163a50
PE
9065 * xfns.c (x_window): Make sprintf buffer a bit bigger
9066 to avoid potential buffer overrun.
9067
ae58ff1f
PE
9068 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
9069
c43c8a6a
PE
9070 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
9071
3f8236f4
PE
90722011-09-04 Paul Eggert <eggert@cs.ucla.edu>
9073
53e9fe90 9074 Integer overflow fixes for scrolling, etc.
6511acf2
PE
9075 Without these, Emacs silently mishandles large integers sometimes.
9076 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
9077 it were "C-u 1 M-x recenter" on a typical 64-bit host.
9078
6511acf2
PE
9079 * xdisp.c (try_window_id): Check Emacs fixnum range before
9080 converting to 'int'.
806add1d 9081
6511acf2 9082 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
9083 Check that an Emacs fixnum is in range before assigning it to 'int'.
9084 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
9085 values converted from Emacs fixnums.
9086 (Frecenter): Don't wrap around a line count if it is out of 'int'
9087 range; instead, treat it as an extreme value.
9088 (Fset_window_configuration, compare_window_configurations):
9089 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
9090
6511acf2
PE
9091 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
9092 that can exceed INT_MAX. Check that EMACS_INT value is in range
9093 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
9094 (match_limit): Don't assume that a fixnum can fit in 'int'.
9095
6511acf2 9096 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
9097 exceed INT_MAX.
9098
6511acf2 9099 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
9100 (Fvertical_motion): Don't wrap around LINES values that don't fit
9101 in 'int'. Instead, treat them as extreme values. This is good
9102 enough for windows, which can't have more than INT_MAX lines anyway.
9103
fcb901a7
LMI
91042011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9105
0f2f6b6d
LMI
9106 * Require libxml/parser.h to avoid compilation warning.
9107
fcb901a7
LMI
9108 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
9109
9110 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
9111 since this reportedly can destroy thread storage.
9112
6e20a0d4
CY
91132011-08-30 Chong Yidong <cyd@stupidchicken.com>
9114
9115 * syntax.c (find_defun_start): Update all cache variables if
9116 exiting early (Bug#9401).
9117
148ae00e
EZ
91182011-08-30 Eli Zaretskii <eliz@gnu.org>
9119
f6cfbd8f
EZ
9120 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
9121
148ae00e
EZ
9122 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
9123 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
9124 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
9125
9126 * term.c (tty_append_glyph): New function.
9127 (produce_stretch_glyph): Static function and its prototype deleted.
9128
a66cfb1c
SM
9129 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
9130 Add prototypes.
148ae00e 9131
c4a07a4c
PE
91322011-08-29 Paul Eggert <eggert@cs.ucla.edu>
9133
9134 * image.c (parse_image_spec): Check for nonnegative, not for positive,
9135 when checking :margin (Bug#9390).
9136 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 9137 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
9138 so that the name doesn't mislead. All uses changed.
9139
6bc8cd65
JB
91402011-08-28 Johan Bockgård <bojohan@gnu.org>
9141
9142 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
9143 set_tty_hooks.
9144
dca4927e
EZ
91452011-08-27 Eli Zaretskii <eliz@gnu.org>
9146
9147 * xdisp.c (move_it_to): Don't bail out early when reaching
9148 position beyond to_charpos, if we are scanning backwards.
9149 (move_it_vertically_backward): When DY == 0, make sure we get to
9150 the first character in the line after the newline.
9151
f2cad773
PE
91522011-08-27 Paul Eggert <eggert@cs.ucla.edu>
9153
9154 * ccl.c: Improve and simplify overflow checking (Bug#9196).
9155 (ccl_driver): Do not generate an out-of-range pointer.
9156 (Fccl_execute_on_string): Remove unnecessary check for
9157 integer overflow, noted by Stefan Monnier in
9158 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
9159 Remove a FIXME that didn't need fixing.
9160 Simplify the newly-introduced buffer reallocation code.
9161
0cae2cdb
JB
91622011-08-27 Juanma Barranquero <lekktu@gmail.com>
9163
9164 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
9165
5fc295a4 91662011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 9167
70c60eb2 9168 Integer and memory overflow issues (Bug#9196).
726e0ab1 9169
d31850da
PE
9170 * doc.c (get_doc_string): Rework so that
9171 get_doc_string_buffer_size is the actual buffer size, rather than
9172 being 1 less than the actual buffer size; this makes xpalloc more
9173 convenient.
9174
a69fbedb
PE
9175 * image.c (x_allocate_bitmap_record, cache_image):
9176 * xselect.c (Fx_register_dnd_atom):
9177 Simplify previous changes by using xpalloc.
9178
fe5c5d37
PE
9179 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
9180 since either will do and ptrdiff_t is convenient with xpalloc.
9181
0065d054
PE
9182 * charset.c (charset_table_size)
9183 (struct charset_sort_data.priority): Now ptrdiff_t.
9184 (charset_compare): Don't overflow if priorities differ greatly.
9185 (Fsort_charsets): Don't assume list length fits in int.
9186 Check for size-calculation overflow when allocating sort data.
9187 (syms_of_charset): Allocate an initial charset table that is
9188 just under 64 KiB, to avoid problems with glibc malloc and mmap.
9189
9190 * cmds.c (internal_self_insert): Check for size-calculation overflow.
9191
9192 * composite.h (struct composition.glyph_len): Now int, not unsigned.
9193 The actual value is always <= INT_MAX, and leaving it unsigned made
9194 overflow checking harder.
9195
9196 * dispextern.h (struct glyph_matrix.rows_allocated)
9197 (struct face_cache.size): Now ptrdiff_t, for convenience in use
9198 with xpalloc. The values are still always <= INT_MAX.
9199
9200 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
9201
9202 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
9203 (SAFE_NALLOCA): New macro.
9204
9205 * region-cache.c (struct boundary.pos, find_cache_boundary)
9206 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
9207 (set_cache_region, invalidate_region_cache)
9208 (revalidate_region_cache, know_region_cache, region_cache_forward)
9209 (region_cache_backward, pp_cache):
9210 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
9211 so that ptrdiff_t * can be passed to xpalloc.
9212 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
9213 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
9214 (pp_cache): Don't assume cache_len fits in int.
9215 * region-cache.h: Adjust extern decls to match.
9216
9217 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
9218 EMACS_INT, since either will do, for xpalloc.
9219
9220 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
9221 (xnmalloc, xnrealloc, xpalloc): New functions.
9222
726e0ab1
PE
9223 * bidi.c (bidi_shelve_header_size): New constant.
9224 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
9225 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
9226
51f30bc5 9227 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
9228 * buffer.c (overlays_at, overlays_in, record_overlay_string)
9229 (overlay_strings):
9230 Don't update size of array until after memory allocation succeeds,
9231 because xmalloc/xrealloc may not return.
0065d054
PE
9232 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
9233 now that we have proper integer overflow checking.
9234 (record_overlay_string, overlay_strings): Catch overflows when
9235 calculating size of overlay_str_buf.
726e0ab1 9236
0065d054
PE
9237 * callproc.c (Fcall_process): Check for size overflow when
9238 calculating size of args2.
9239 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
9240 Normally we prefer signed values, but sticking with ptrdiff_t would
9241 require adding more-complicated checks.
726e0ab1
PE
9242
9243 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
9244 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
9245 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 9246 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
9247
9248 * character.c (Fstring): Check for size-calculation overflow.
9249
9250 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
9251 unnecessary integer overflow. Check for size overflow.
9252 (encode_coding_object): Don't update size until xmalloc succeeds.
9253
9254 * composite.c (get_composition_id): Check for overflow in glyph
9255 length calculations.
9256
9257 Integer and memory overflow fixes for display code.
9258 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
9259 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
9260 (scrolling_window): Check for overflow in size calculations.
9261 (line_draw_cost, realloc_glyph_pool, add_row_entry):
9262 Don't assume glyph table len fits in int.
9263 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
9264 (row_table_size): Now ptrdiff_t, not int.
9265 (scrolling_window): Avoid overflow in size calculations.
9266 Don't update size until allocation succeeds.
9267 * fns.c (concat): Check for overflow in size calculations.
9268 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
9269 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9270 (NEXT_ALMOST_PRIME_LIMIT): New constant.
9271
9272 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
9273 (get_doc_string): Check for size calculation overflow.
9274 Don't update size until allocation succeeds.
9275 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
9276 EMACS_INT, where ptrdiff_t will do.
9277 (Fsubstitute_command_keys): Check for string overflow.
9278
9279 * editfns.c (set_time_zone_rule): Don't assume environment length
9280 fits in int.
9281 (message_length): Now ptrdiff_t, not int.
9282 (Fmessage_box): Don't update size until allocation succeeds.
9283 Don't assume message length fits in int.
9284 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
9285
0065d054
PE
9286 * emacs.c (main): Do not reallocate argv, since there is a null at
9287 the end that can be overwritten, and this way there's no need to
9288 worry about size-calculation overflow.
9289 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
9290
9291 * eval.c (init_eval_once, grow_specpdl): Don't update size until
9292 alloc succeeds.
9293 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
9294
9295 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
9296 (x_set_scroll_bar_width, x_figure_window_size):
9297 Check for integer overflow.
9298 (x_set_alpha): Do not assume XINT fits in int.
9299
9300 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
9301 This is for the members text_lines, text_cols, total_lines, total_cols,
9302 where the system imposes an 'int' limit.
9303
9304 * fringe.c (Fdefine_fringe_bitmap):
9305 Don't update size until alloc works.
9306
9307 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
9308 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
9309
9310 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
9311 Check for size-calculation overflow.
9312 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
9313 do, as we prefer signed integers.
9314 (id_to_widget.max_size, id_to_widget.used)
9315 (xg_store_widget_in_map, xg_remove_widget_from_map)
9316 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
9317 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
9318 Use and return ptrdiff_t, not int.
9319 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
9320 * gtkutil.h: Change prototypes to match the above.
9321
9322 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
9323 are duplicate now that they've been promoted to lisp.h.
9324 (x_allocate_bitmap_record, x_alloc_image_color)
9325 (make_image_cache, cache_image, xpm_load):
9326 Don't update size until alloc is done.
9327 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
9328 (x_detect_edges):
3256efce 9329 Check for size calculation overflow.
726e0ab1
PE
9330 (ct_colors_allocated_max): New constant.
9331 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
9332 overflow.
3256efce 9333
726e0ab1
PE
9334 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
9335 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
9336 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
9337 Use ptrdiff_t, not int, to count maps.
9338 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
9339 calculations. Don't update size until allocation succeeds.
9340 Redo calculations to avoid overflow.
726e0ab1
PE
9341 * keyboard.h: Change prototypes to match the above.
9342
9343 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
9344 to count maps.
9345 (current_minor_maps): Check for size calculation overflow.
9346 * keymap.h: Change prototypes to match the above.
9347
9348 * lread.c (read1, init_obarray): Don't update size until alloc done.
9349
9350 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
9351 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
9352
726e0ab1
PE
9353 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
9354 Now ptrdiff_t, not int.
9355 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
9356 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
9357
9358 * process.c (Fnetwork_interface_list): Check for overflow
9359 in size calculation.
9360
9361 * region-cache.c (move_cache_gap): Check for size calculation overflow.
9362
9363 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
9364 overflow. Don't bother calling xmalloc when xrealloc will do.
9365
9366 * search.c (Freplace_match): Check for size calculation overflow.
9367 (Fset_match_data): Don't assume list lengths fit in 'int'.
9368
9369 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
9370 for command line length. Do not attempt to address one before the
9371 beginning of an array, as that's not portable.
9372
9373 * term.c (max_frame_lines): Remove; unused.
9374 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
9375 not int.
9376 (encode_terminal_code, calculate_costs): Check for size
9377 calculation overflow.
9378 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
9379 table lengths and related sizes. Don't update size until alloc
9380 done. Redo calculations to avoid overflow.
9381 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
9382
9383 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
9384 subtracting pointers.
9385 (gobble_line): Check for overflow more carefully. Don't update size
9386 until alloc done.
9387
9388 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
9389 Don't update size until alloc done.
9390 Redo size calculations to avoid overflow.
9391 Check for size calculation overflow.
0065d054 9392 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
9393
9394 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
9395 Use ptrdiff_t, not int, for sizes.
9396 (store_mode_line_noprop_char): Don't update size until alloc done.
9397
0065d054
PE
9398 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
9399 Use ptrdiff_t, not int, for sizes.
9400 (Finternal_make_lisp_face, cache_face):
9401 Check for size calculation overflow.
9402 (cache_face): Treat size calculation overflows as if they were
9403 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
9404
9405 * xfns.c (x_encode_text, x_set_name_internal)
9406 (Fx_change_window_property): Use ptrdiff_t, not int, to count
9407 sizes, since they can exceed INT_MAX in size. Check for size
9408 calculation overflow.
9409
0065d054
PE
9410 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
9411 (xg_select): Check for size calculation overflow.
726e0ab1
PE
9412 Don't update size until alloc done.
9413
0065d054 9414 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 9415 as sprintf is limited to int lengths.
1d526e2f 9416
252c5ee1
PE
9417 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
9418 (X_LONG_MIN): New macros.
864d7ce7
PE
9419 Use them to make the following changes clearer.
9420 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
9421 This change doesn't affect the value now, but it may help remind
9422 future maintainers not to raise the value too much later.
9423 (SELECTION_QUANTUM): Remove, replacing with ...
9424 (selection_quantum): ... new function, which avoids overflow.
9425 All uses changed.
9426 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
9427 assumption that selection length fits in 'int'.
9428 (x_reply_selection_request, x_handle_selection_request)
9429 (x_get_window_property, receive_incremental_selection)
9430 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
9431 (lisp_data_to_selection_data, clean_local_selection_data):
9432 Use ptrdiff_t, not int, to record length of selection.
9433 (x_reply_selection_request, x_get_window_property)
9434 (receive_incremental_selection, x_property_data_to_lisp):
9435 Redo calculations to avoid overflow.
9436 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 9437 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
9438 something.
9439 (x_get_window_property, receive_incremental_selection)
9440 (lisp_data_to_selection_data, x_property_data_to_lisp):
9441 Check for size-calculation overflow.
9442 (x_get_window_property, receive_incremental_selection)
9443 (lisp_data_to_selection_data, Fx_register_dnd_atom):
9444 Don't store size until memory allocation succeeds.
9445 (x_get_window_property): Plug memory leak on memory exhaustion.
9446 Don't double-block input; malloc is safe here. Don't assume 2**34
9447 - 4 fits in unsigned long. Add an xassert to check
9448 XGetWindowProperty overflow. Be more careful about overflow
9449 calculations, and distinguish size from memory overflow better.
9450 (receive_incremental_selection): When tracing, don't assume
9451 unsigned int is less than INT_MAX.
9452 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
9453 harmful) conversions of unsigned short to int.
9454 (lisp_data_to_selection_data): Don't assume that integers
9455 in the range -65535 through -1 fit in an X unsigned short.
9456 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
9457 result parameters unless successful. Rely on cons_to_unsigned
9458 to report problems with elements; the old code wasn't right anyway.
9459 (x_check_property_data): Check for int overflow; we cannot use
9460 a wider type due to X limits.
9461 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
9462
726e0ab1 9463 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 9464
0065d054
PE
9465 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
9466 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
9467 (x_color_cells): Don't store size until memory allocation succeeds.
9468 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 9469 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
9470 (x_term_init): Don't assume length fits in int (sprintf is limited
9471 to int size).
bc18e09d 9472
ebfa62c0
PE
9473 Use ptrdiff_t for composition IDs.
9474 * character.c (lisp_string_width):
9475 * composite.c (composition_table_size, n_compositions)
9476 (get_composition_id, composition_gstring_from_id):
9477 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
9478 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
9479 * window.c (Frecenter):
9480 Use ptrdiff_t, not int, for composition IDs.
9481 * composite.c (get_composition_id): Check for integer overflow.
9482 * composite.h: Adjust prototypes to match the above changes.
9483
d3411f89
PE
9484 Use ptrdiff_t for hash table indexes.
9485 * category.c (hash_get_category_set):
9486 * ccl.c (ccl_driver):
9487 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
9488 * coding.c (coding_system_charset_list, detect_coding_system):
9489 * coding.h (struct coding_system.id):
9490 * composite.c (get_composition_id, gstring_lookup_cache):
9491 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
9492 * image.c (xpm_get_color_table_h):
9493 * lisp.h (hash_lookup, hash_put):
9494 * minibuf.c (Ftest_completion):
9495 Use ptrdiff_t for hash table indexes, not int (which is too
9496 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
9497 32-bit --with-wide-int hosts).
9498
e097a6fa
PE
9499 * charset.c (Fdefine_charset_internal): Check for integer overflow.
9500 Add a FIXME comment about memory leaks.
9501 (syms_of_charset): Don't assume xmalloc returns.
9502
5637687f
PE
9503 Don't assume that stated character widths fit in int.
9504 * character.c (Fchar_width, c_string_width, lisp_string_width):
9505 * character.h (CHAR_WIDTH):
9506 * indent.c (MULTIBYTE_BYTES_WIDTH):
9507 Use sanitize_char_width to avoid undefined and/or bad behavior
9508 with outlandish widths.
a66cfb1c 9509 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
9510 now that we have two such functions. All uses changed.
9511 (sanitize_char_width): New inline function.
9512
a2271ba2
PE
9513 Don't assume that tab-width fits in int.
9514 * character.h (sanitize_width): New inline function.
9515 (SANE_TAB_WIDTH): New macro.
9516 (ASCII_CHAR_WIDTH): Use it.
9517 * indent.c (sane_tab_width): Remove. All uses replaced by
9518 SANE_TAB_WIDTH (current_buffer).
9519 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
9520
18c52557
PE
9521 * fileio.c: Integer overflow issues with file modes.
9522 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
9523
caeeedc1
PE
9524 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
9525 Remove unreachable code.
9526 (read_hex, load_charset_map_from_file): Check for integer overflow.
9527
6df6ae42 9528 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
9529 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
9530 (x_send_scroll_bar_event): Likewise. Check that the size does not
9531 exceed limits imposed by XClientMessageEvent, as well as the usual
9532 ptrdiff_t and size_t limits.
9533
b13995db
PE
9534 * keyboard.c: Overflow, signedness and related fixes.
9535 (make_lispy_movement): Use same integer type in forward decl
9536 that is used in the definition.
9537 (read_key_sequence, keyremap_step):
9538 Change bufsize argument back to int, undoing my 2011-03-30 change.
9539 We prefer signed types, and int is wide enough here.
9540 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
9541 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
9542 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
9543 length, not size_t. Use ptrdiff_t for index, not int.
9544 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
9545 possibility of integer overflow.
9546
13464394
PE
9547 Overflow, signedness and related fixes for images.
9548
9549 * dispextern.h (struct it.stack[0].u.image.image_id)
9550 (struct_it.image_id, struct image.id, struct image_cache.size)
9551 (struct image_cache.used, struct image_cache.ref_count):
9552 * gtkutil.c (update_frame_tool_bar):
9553 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
9554 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
9555 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
9556 * nsmenu.m (update_frame_tool_bar):
9557 * xdisp.c (calc_pixel_width_or_height):
9558 * xfns.c (image_cache_refcount):
9559 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
9560 on typical 64-bit hosts.
9561
9562 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9563 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
9564 Omit unnecessary casts to int.
9565 (parse_image_spec): Check that integers fall into 'int' range
9566 when the callers expect that.
9567 (image_ascent): Redo ascent calculation to avoid int overflow.
9568 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
9569 (lookup_image): Remove unnecessary tests.
9570 (xbm_image_p): Locals are now of int, not EMACS_INT,
9571 since parse_image_check makes sure they fit into int.
9572 (png_load, gif_load, svg_load_image):
9573 Prefer int to unsigned where either will do.
9574 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
9575 old tiff_error_handler and tiff_warning_handler.
9576 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
9577 stack buffer overflows. It uses only the features of vsnprintf
9578 that are common to both POSIX and native Microsoft.
9579 (tiff_error_handler, tiff_warning_handler): Use it.
9580 (tiff_load, gif_load, imagemagick_load_image):
9581 Don't assume :index value fits in 'int'.
9582 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
9583 (imagemagick_load_image): Check that crop parameters fit into
9584 the integer types that MagickCropImage accepts. Don't assume
9585 Vimagemagick_render_type has a nonnegative value. Don't assume
9586 size_t fits in 'long'.
9587 (gs_load): Use printmax_t to print the widest integers possible.
9588 Check for integer overflow when computing image height and width.
9589
c11821d4
EZ
95902011-08-26 Eli Zaretskii <eliz@gnu.org>
9591
9592 * xdisp.c (redisplay_window): Don't force window start if point
9593 will be invisible in the resulting window. (Bug#9324)
9594
0c95fcf7
EZ
95952011-08-25 Eli Zaretskii <eliz@gnu.org>
9596
9597 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
9598 the display spec is of the form `(space ...)'.
9599 (handle_display_spec): Return the value returned by
9600 handle_single_display_spec, not just 1 or zero.
9601 (handle_single_display_spec): If the display spec is of the form
9602 `(space ...)', and specifies display in the text area, return 2
9603 rather than 1.
fee65a97 9604 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
9605 accurately, and prefer exact match for point under bidi.
9606 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
9607
9608 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
9609 into disp_prop; all users changed.
9610
9611 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
9612 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
9613 for the text covered by the display property.
9614
e4ed06f1
CY
96152011-08-25 Chong Yidong <cyd@stupidchicken.com>
9616
9617 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
9618 Change return value to nil.
9619 (Frecord_buffer): Delete unused function.
9620
f67cdd7f
EZ
96212011-08-24 Eli Zaretskii <eliz@gnu.org>
9622
5980d4c6
EZ
9623 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
9624 buffers, return left-to-right.
8610fe8b
EZ
9625 (set_cursor_from_row): Consider candidate row a win if its glyph
9626 represents a newline and point is on that newline. Fixes cursor
9627 positioning on the newline at EOL of R2L text within L2R
9628 paragraph, and vice versa.
9629 (try_cursor_movement): Check continued rows, in addition to
9630 continuation rows. Fixes unwarranted scroll when point enters a
9631 continued line of R2L text within an L2R paragraph, or vice versa.
9632 (cursor_row_p): Consider the case of point being equal to
9633 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
9634 from the end of a short line to the beginning of a continued line
9635 of R2L text within L2R paragraph.
9636 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
9637 composed characters.
5980d4c6 9638
f67cdd7f
EZ
9639 * bidi.c (bidi_check_type): Use xassert.
9640 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
9641 members.
9642
bca633fb
EZ
96432011-08-23 Eli Zaretskii <eliz@gnu.org>
9644
9645 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
9646 a character.
9647
4a5885a7
CY
96482011-08-23 Chong Yidong <cyd@stupidchicken.com>
9649
9650 * nsfont.m (ns_otf_to_script): Fix typo.
9651
0902a04e
KH
96522011-08-22 Kenichi Handa <handa@m17n.org>
9653
9654 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
9655 extra slot even if the purpose is char-code-property-table.
9656
1a2e6670
EZ
96572011-08-23 Eli Zaretskii <eliz@gnu.org>
9658
8ddde651
EZ
9659 * xdisp.c (redisplay_window): When computing centering_position,
9660 account for the height of the header line. (Bug#8874)
9661
425cc014
EZ
9662 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
9663 instead of CHAR_TO_BYTE. Fixes a crash when a completion
9664 candidate is selected by the mouse, and that candidate has a
9665 composed character under the mouse.
9666
1a2e6670
EZ
9667 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
9668 coordinates reported by pos-visible-in-window-p for a composed
9669 character in column zero.
9670
8b76d6f8
SM
96712011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
9672
9673 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
9674
dac347dd
EZ
96752011-08-22 Eli Zaretskii <eliz@gnu.org>
9676
9677 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
9678 consider it a hit if to_charpos is anywhere in the range of the
9679 composed buffer positions.
9680
e013fb34
CY
96812011-08-22 Chong Yidong <cyd@stupidchicken.com>
9682
9683 * image.c (gif_load): Don't assume that each subimage has the same
9684 dimensions as the base image. Handle disposal method that is
9685 "undefined" by the gif spec (Bug#9335).
9686
bd1ba3e8
CY
96872011-08-20 Chong Yidong <cyd@stupidchicken.com>
9688
9689 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 9690 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 9691
54a1215b
EZ
96922011-08-19 Eli Zaretskii <eliz@gnu.org>
9693
823564e5
EZ
9694 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
9695 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
9696 from an Org mode buffer to a Speedbar frame.
9697
54a1215b
EZ
9698 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
9699 a composition, take its buffer position from IT->cmp_it.charpos.
9700 Fixes cursor positioning at the beginning of a line that begins
9701 with a composed character.
9702
9778ebcc
EZ
97032011-08-18 Eli Zaretskii <eliz@gnu.org>
9704
0be6ee06
EZ
9705 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
9706 character bidirectional type, use STRONG_L instead. Fixes crashes
9707 in a buffer produced by `describe-categories'.
9708
9778ebcc
EZ
9709 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
9710 members before the level stack, so they would be saved and
9711 restored when copying iterator state. Fixes incorrect reordering
9712 around TABs covered by display properties.
9713
156bffbe
AS
97142011-08-18 Andreas Schwab <schwab@linux-m68k.org>
9715
6b02f655 9716 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 9717
72ad093b
CY
97182011-08-17 Chong Yidong <cyd@stupidchicken.com>
9719
9720 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
9721 (internal_condition_case_2, internal_condition_case_n):
9722 Remove unnecessary aborts (Bug#9081).
72ad093b 9723
35774242
EZ
97242011-08-17 Eli Zaretskii <eliz@gnu.org>
9725
9726 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
9727 has no `load' handler, try opening the file locally. (Bug#9311)
9728
db76dd85
KB
97292011-08-16 Ken Brown <kbrown@cornell.edu>
9730
9731 * gmalloc.c: Expand comment.
9732
b215eee5
EZ
97332011-08-16 Eli Zaretskii <eliz@gnu.org>
9734
9735 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
9736 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
9737
a4579d33
KB
97382011-08-16 Ken Brown <kbrown@cornell.edu>
9739
9740 Fix memory allocation problems in Cygwin build (Bug#9273).
9741
9742 * unexcw.c ( __malloc_initialized): Declare external variable.
9743 (fixup_executable): Force the dumped emacs to reinitialize malloc.
9744
8b76d6f8
SM
9745 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
9746 New variables.
a4579d33
KB
9747 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
9748 dumped emacs.
9749 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
9750 in the static heap.
9751 [CYGWIN] (special_realloc): New function.
9752 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
9753 requests to realloc storage in the static heap.
9754
3ebec551
PE
97552011-08-15 Paul Eggert <eggert@cs.ucla.edu>
9756
9757 * bidi.c (bidi_initialize): Remove unused local.
9758
9fd8be00
EZ
97592011-08-15 Eli Zaretskii <eliz@gnu.org>
9760
6b02f655
SM
9761 * bidimirror.h:
9762 * biditype.h: Remove file.
9763 * makefile.w32-in ($(BLD)/bidi.$(O)):
9764 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
9765
9766 * dispextern.h: Fix a typo in the comment to bidi_type_t.
9767
9768 * chartab.c: Improve commentary for the uniprop_table API.
9769
32413314
EZ
9770 * bidi.c (bidi_paragraph_init): Support zero value of
9771 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
9772 (bidi_initialize): Use uniprop_table instead of including
9773 biditype.h and bidimirror.h.
32413314 9774
9fd8be00
EZ
9775 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
9776 coordinates of the iterator when restoring from ppos_it.
9777 (Bug#9296)
9778
5cf2b69b
KH
97792011-08-14 Kenichi Handa <handa@m17n.org>
9780
9781 * process.c (create_process): Call setup_process_coding_systems
72ad093b 9782 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 9783
daf17d00
EZ
97842011-08-14 Eli Zaretskii <eliz@gnu.org>
9785
9786 * xdisp.c (move_it_in_display_line_to): Don't invoke
9787 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
9788 ppos_it. Fixes vertical cursor motion when line beginning is
9789 covered by an image. (Bug#9296)
9790
08e3161a
JD
97912011-08-14 Jan Djärv <jan.h.d@swipnet.se>
9792
9793 * nsterm.h (ns_run_ascript): Declare.
9794 (NSAPP_DATA2_RUNASSCRIPT): Define.
9795
9796 * nsfns.m (as_script, as_result, as_status): New static variables.
9797 (ns_run_ascript): New function.
5e617bc2 9798 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
9799 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
9800 the event loop. Get status from as_status (Bug#7276).
9801
9802 * nsterm.m (sendEvent): If event is NSApplicationDefined and
9803 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
9804 the event loop (Bug#7276).
9805
a3720aa2
AS
98062011-08-14 Andreas Schwab <schwab@linux-m68k.org>
9807
9808 * gnutls.c (QCgnutls_bootprop_priority)
9809 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
9810 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
9811 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
9812 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
9813 (QCgnutls_bootprop_verify_hostname_error)
9814 (QCgnutls_bootprop_callbacks_verify): Rename from
9815 Qgnutls_bootprop_..., all uses changed.
9816
9817 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
9818 uses changed.
9819
0a0d27fb
PE
98202011-08-14 Paul Eggert <eggert@cs.ucla.edu>
9821
19d5c50c
PE
9822 * xfaces.c (Qframe_set_background_mode): Now static.
9823 * dispextern.h (Qframe_set_background_mode): Remove decl.
9824
0a0d27fb
PE
9825 * process.c (Fnetwork_interface_info): Declare local only if needed.
9826
377538cb
JD
98272011-08-13 Jan Djärv <jan.h.d@swipnet.se>
9828
9829 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
9830 (Fnetwork_interface_list): Allocate in increments of bytes instead
9831 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
9832 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
9833 sockaddr.
9834 (struct ifflag_def): notrailers is smart on OSX.
9835 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
9836 Get hardware address with getifaddrs if available.
9837
08fff70c
EZ
98382011-08-12 Eli Zaretskii <eliz@gnu.org>
9839
9840 * xdisp.c (iterate_out_of_display_property): xassert that
9841 IT->position is set to within IT->object's boundaries. Break from
9842 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
9843 when IT->position is set up wrongly due to some bug.
9844 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
9845 (push_display_prop): Allow GET_FROM_STRING as IT->method on
9846 entry. Force push_it to save on the stack the current
9847 buffer/string position, to be restored by pop_it. Fix flags in
9848 the iterator structure wrt the object coming from a display
9849 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
9850 properties. (Bug#9284)
9851
7be1c708 98522011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 9853
7be1c708
CY
9854 * fontset.c (fontset_get_font_group): Add proper type checks.
9855 (Bug#9172)
aac0c6e3 9856
7be1c708 98572011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 9858
7be1c708
CY
9859 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
9860 and LC_VERSION_MIN_MACOSX.
9861 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
9862 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 9863
97bb72a6
EZ
98642011-08-08 Eli Zaretskii <eliz@gnu.org>
9865
9866 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
9867 no-display-properties-and-no-overlays under bidi display.
9868 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 9869 properties and overlays.
97bb72a6 9870
d5617611
CY
98712011-08-08 Chong Yidong <cyd@stupidchicken.com>
9872
37e11a63
CY
9873 * editfns.c (Fset_time_zone_rule): Document relationship with the
9874 setenv function.
9875
d5617611
CY
9876 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
9877 the font entity extracted from the cache (Bug#8109).
9878
58872834
CY
98792011-08-07 Chong Yidong <cyd@stupidchicken.com>
9880
9881 * composite.c (autocmp_chars): Don't reset point. That is done by
9882 restore_point_unwind (Bug#5984).
9883
75bfc667
JL
98842011-08-07 Juri Linkov <juri@jurta.org>
9885
9886 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
9887 to show the arg `TIME' instead of `TIMEVAL'.
9888
d1410150
EZ
98892011-08-06 Eli Zaretskii <eliz@gnu.org>
9890
9891 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9892 display property strides EOL and includes a newline, as in
9893 longlines-mode. (Bug#9254)
75b771e4
EZ
9894 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
9895 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
9896
9897 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
9898 is non-zero, even if the data buffer is NULL. Fixes a crash in
9899 vertical-motion with longlines-mode. (Bug#9254)
9900
35928349
EZ
99012011-08-05 Eli Zaretskii <eliz@gnu.org>
9902
ec7cc85b
EZ
9903 * bidi.c <bidi_cache_total_alloc>: Now static.
9904 (bidi_initialize): Initialize bidi_cache_total_alloc.
9905
8b76d6f8 9906 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9907 cache. (Bug#9221)
9908
9909 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9910 amount allocated this far in `bidi_cache_total_alloc'.
9911 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9912 non-zero, only free the data buffer without restoring the cache
9913 contents. All callers changed.
9914
9915 * dispextern.h (bidi_unshelve_cache): Update prototype.
9916
9917 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9918 (move_it_in_display_line, move_it_to)
9919 (move_it_vertically_backward, move_it_by_lines): Replace the call
9920 to xfree to an equivalent call to bidi_unshelve_cache.
9921 (move_it_in_display_line_to): Fix logic of returning
412b6358 9922 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9923
e2e2423b
EZ
99242011-08-05 Eli Zaretskii <eliz@gnu.org>
9925
9926 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9927 came from a string character with a `cursor' property. (Bug#9229)
9928
ae9e757a
JD
99292011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9930
9931 * Makefile.in (LIB_PTHREAD): New variable.
9932 (LIBES): Add LIB_PTHREAD (Bug#9216).
9933
9934 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9935 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9936
213bd7f2
AS
99372011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9938
6b02f655 9939 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9940
99aaf75f
JD
99412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9942
9943 * xterm.c (x_find_topmost_parent): New function.
9944 (x_set_frame_alpha): Find topmost parent window with
9945 x_find_topmost_parent and set the property there also (bug#9181).
9946 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9947
c74e9d86
PE
99482011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9949
9950 * callproc.c (Fcall_process): Avoid vfork clobbering
9951 the local vars buffer, coding_systems, current_dir.
9952
640c8776
SM
99532011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9954
9955 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9956
f26d0e4c
PE
99572011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9958
8a10d76c
PE
9959 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9960 so that it is not optimized away.
9961
f26d0e4c
PE
9962 * xdisp.c (compute_display_string_pos): Remove unused local.
9963
55439c61
EZ
99642011-08-02 Eli Zaretskii <eliz@gnu.org>
9965
9966 Fix slow cursor motion and scrolling in large buffers with
9967 selective display, like Org Mode buffers. (Bug#9218)
9968
9969 * dispextern.h (struct bidi_it): New member disp_prop_p.
9970
9971 * xdisp.c: Remove one-slot cache of display string positions.
9972 (compute_display_string_pos): Accept an additional argument
5e617bc2 9973 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9974 for a display string or property. If found, set DISP_PROP_P
9975 non-zero.
9976
9977 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9978 DISP_PROP_P, and pass it to compute_display_string_pos.
9979 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9980 non-zero. All callers of bidi_fetch_char changed.
9981
fb33fa43
SM
99822011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9983
9984 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9985
b099e063
DM
99862010-12-03 Don March <don@ohspite.net>
9987
9988 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9989 last character M-[char] is translated to ESC [char] (bug#7541).
9990
5cc7f7af
KH
99912011-08-02 Kenichi Handa <handa@m17n.org>
9992
d0fffa3f 9993 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9994
9995 * chartab.c (uniprop_table): Make it non-static.
9996
525d5e6e
EZ
99972011-08-01 Eli Zaretskii <eliz@gnu.org>
9998
9999 * xdisp.c (forward_to_next_line_start): Accept additional argument
10000 BIDI_IT_PREV, and store into it the state of the bidi iterator had
10001 on the newline.
10002 (reseat_at_next_visible_line_start): Use the bidi iterator state
10003 returned by forward_to_next_line_start to restore the state of
10004 it->bidi_it after backing up to previous newline. (Bug#9212)
10005
31011111
AS
100062011-07-30 Andreas Schwab <schwab@linux-m68k.org>
10007
10008 * regex.c (re_comp): Protoize.
10009 (re_exec): Fix return type.
10010 (regexec): Fix type of `ret'. (Bug#9203)
10011
476371c4
PE
100122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10013
e5d76069
PE
10014 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
10015 This is needed if max-image-size is a floating-point number.
10016
9a79b20c
AS
100172011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10018
10019 * print.c (print_object): Print empty symbol as ##.
10020
10021 * lread.c (read1): Read ## as empty symbol.
10022
d8c2fa78
AA
100232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
10024
10025 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10026 setting frame foreground color (Bug#9175).
10027 (x_set_background_color): Likewise.
10028
ffe57a7a
AA
10029 * nsmenu.m (-setText): Size tooltip dimensions precisely to
10030 contents (Bug#9176).
10031 (EmacsTooltip -init): Remove bezels and add shadows to
10032 tooltip windows.
10033
bf3492a5
AA
10034 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
10035 or scroll bar (Bug#8470).
10036
d55e9c53
AA
10037 * nsfont.m (nsfont_open): Remove assignment to voffset and
10038 unnecessary vars hshink, expand, hd, full_height, min_height.
10039 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
10040
10041 * nsterm.h (nsfont_info): Remove voffset field.
10042
d8c2fa78 100432011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
10044
10045 Implement strike-through and overline on NextStep (Bug#8863).
10046
10047 * nsfont.m (nsfont_open): Use underline position provided by font,
10048 instead of hard-coded value of 2.
10049 (nsfont_draw): Call ns_draw_text_decoration instead.
10050
10051 * nsterm.h: Add declaration for ns_draw_text_decoration.
10052
10053 * nsterm.m (ns_draw_text_decoration): New function for drawing
10054 underline, overline, and strike-through.
10055 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
10056 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 10057 accommodate underlining, etc.
4843aac3 10058
4cc60b9b
EZ
100592011-07-28 Eli Zaretskii <eliz@gnu.org>
10060
bc7ece87
EZ
10061 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
10062 default.
4cc60b9b 10063
476371c4
PE
100642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10065
66606eea
PE
10066 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
10067 Without this fix, if a signal arrives just after memory fills up,
10068 'malloc' might be invoked reentrantly.
10069
476371c4
PE
10070 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
10071 In other words, assume that every image size is allowed, on non-X
10072 hosts. This assumption is probably wrong, but it lets Emacs compile.
10073
f3fcc40d
AS
100742011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10075
10076 * regex.c (re_iswctype): Convert return values to boolean.
10077
350c992f
EZ
100782011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
10079
10080 * xdisp.c (compute_display_string_pos): Don't use cached display
10081 string position if the buffer had its restriction changed.
10082 (Bug#9184)
10083
5266b4bb
PE
100842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10085
10086 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10087
2573a837 100882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 10089
41f55ccd 10090 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 10091
39e378da
PE
10092 * bidi.c: Integer size and overflow fixes.
10093 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
10094 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
10095 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10096 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
10097 (bidi_find_other_level_edge):
10098 Use ptrdiff_t instead of EMACS_INT where either will do.
10099 This works better on 32-bit hosts configured --with-wide-int.
10100 (bidi_cache_ensure_space): Check for size-calculation overflow.
10101 Use % rather than repeated addition, for better worst-case speed.
10102 Don't set bidi_cache_size until after xrealloc returns, because it
10103 might not return.
10104 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
10105 (bidi_cache_ensure_space): Also check that the bidi cache size
10106 does not exceed that of the largest Lisp string or buffer. See Eli
10107 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 10108
5e927815
PE
10109 * alloc.c (__malloc_size_t): Remove.
10110 All uses replaced by size_t. See Andreas Schwab's note
10111 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
10112
ca4aa935
PE
10113 * image.c: Improve checking for integer overflow.
10114 (check_image_size): Assume that f is nonnull, since
10115 it is always nonnull in practice. This is one less thing to
10116 worry about when checking for integer overflow later.
10117 (x_check_image_size): New function, which checks for integer
10118 overflow issues inside X.
10119 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
10120 This removes the need for a memory_full check.
10121 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
10122 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
10123 (xbm_read_bitmap_data): Change locals back to 'int', since
10124 their values must fit in 'int'.
10125 (xpm_load_image, png_load, tiff_load):
10126 Invoke x_create_x_image_and_pixmap earlier,
10127 to avoid much needless work if the image is too large.
10128 (tiff_load): Treat overly large images as if
10129 x_create_x_image_and_pixmap failed, not as malloc failures.
10130 (gs_load): Use x_check_image_size.
10131
5f8f9cc2
PE
10132 * gtkutil.c: Omit integer casts.
10133 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
10134 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
10135
5adf60bc
PE
10136 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
10137
c8907a93
PE
10138 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
10139 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
10140 would wrongly return t on a 64-bit host.
10141
e3c25c68
PE
10142 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
10143 The plain *_OVERFLOW macros run afoul of GCC bug 49705
10144 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
10145 and therefore cause GCC to emit a bogus diagnostic in some cases.
10146
3f791afe
PE
10147 * image.c: Integer signedness and overflow and related fixes.
10148 This is not an exhaustive set of fixes, but it's time to
10149 record what I've got.
10150 (lookup_pixel_color, check_image_size): Remove redundant decls.
10151 (check_image_size): Don't assume that arbitrary EMACS_INT values
10152 fit in 'int', or that arbitrary 'double' values fit in 'int'.
10153 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
10154 (tiff_load, imagemagick_load_image):
10155 Check for overflow in size calculations.
10156 (x_create_x_image_and_pixmap): Remove unnecessary test for
10157 xmalloc returning NULL; that can't happen.
10158 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
10159 (xpm_color_bucket): Use better integer hashing function.
10160 (xpm_cache_color): Don't possibly over-allocate memory.
10161 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
10162 (gif_memory_source):
10163 Use ptrdiff_t, not int or size_t, to record sizes.
10164 (png_load): Don't assume values greater than 2**31 fit in 'int'.
10165 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
10166 either works, as we prefer signed integers.
10167 (tiff_read_from_memory, tiff_write_from_memory):
10168 Return tsize_t, not size_t, since that's what the TIFF API wants.
10169 (tiff_read_from_memory): Don't fail simply because the read would
10170 go past EOF; instead, return a short read.
10171 (tiff_load): Omit no-longer-needed casts.
10172 (Fimagemagick_types): Don't assume size fits into 'int'.
10173
3cc5a532
PE
10174 Improve hashing quality when configured --with-wide-int.
10175 * fns.c (hash_string): New function, taken from sxhash_string.
10176 Do not discard information about ASCII character case; this
10177 discarding is no longer needed.
10178 (sxhash-string): Use it. Change sig to match it. Caller changed.
10179 * lisp.h: Declare it.
10180 * lread.c (hash_string): Remove, since we now use fns.c's version.
10181 The fns.c version returns a wider integer if --with-wide-int is
10182 specified, so this should help the quality of the hashing a bit.
10183
b312a492
PE
10184 * emacs.c: Integer overflow minor fix.
10185 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
10186 Define only if GNU_LINUX.
10187 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
10188
dfd153ae
PE
10189 * dispnew.c: Integer signedness and overflow fixes.
10190 Remove unnecessary forward decls, that were a maintenance hassle.
10191 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
10192 All uses changed.
10193 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
10194 (scrolling_window): Use ptrdiff_t, not int, for byte count.
10195 (prepare_desired_row, line_draw_cost):
10196 Use int, not unsigned, where either works.
10197 (save_current_matrix, restore_current_matrix):
10198 Use ptrdiff_t, not size_t, where either works.
10199 (init_display): Check for overflow more accurately, and without
10200 relying on undefined behavior.
10201
a81d11a3
PE
10202 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
10203 Remove, replacing with the new symbols in lisp.h. All uses changed.
10204 * fileio.c (make_temp_name):
10205 * filelock.c (lock_file_1, lock_file):
10206 * xdisp.c (message_dolog):
10207 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
10208 Use pMd etc. instead.
10209 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
10210 replacing the pWIDE etc. symbols removed from editfns.c.
10211
3300e6fd
PE
10212 * keyboard.h (num_input_events): Now uintmax_t.
10213 This is (very slightly) less likely to mess up due to wraparound.
10214 All uses changed.
10215
fd05c7e9
PE
10216 * buffer.c: Integer signedness fixes.
10217 (alloc_buffer_text, enlarge_buffer_text):
10218 Use ptrdiff_t rather than size_t when either will do, as we prefer
10219 signed integers.
10220
903fe15d
PE
10221 * alloc.c: Integer signedness and overflow fixes.
10222 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
10223 (__malloc_size_t): Default to size_t, not to int.
10224 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
10225 (Fgarbage_collect, mark_object_loop_halt, mark_object):
10226 Prefer ptrdiff_t to size_t when either would do, as we prefer
10227 signed integers.
10228 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
10229 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
10230 Now const. Initialize with values that are in range even if char
10231 is signed.
10232 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
10233 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
10234 These functions do the right thing with sizes > 2**32.
10235 (check_depth): Now ptrdiff_t, not int.
10236 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
10237 Adjust to new way of storing sizes. Check for size overflow bugs
10238 in rest of code.
10239 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
10240 slightly wrong anyway, as it missed one instance of
10241 XMALLOC_OVERRUN_CHECK_OVERHEAD.
10242 (refill_memory_reserve): Omit needless cast to size_t.
10243 (mark_object_loop_halt): Mark as externally visible.
10244
ac82cc6a
PE
10245 * xselect.c: Integer signedness and overflow fixes.
10246 (Fx_register_dnd_atom, x_handle_dnd_message):
10247 Use ptrdiff_t, not size_t, since we prefer signed.
10248 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
10249 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
10250 x_dnd_atoms_size and x_dnd_atoms_length.
10251
c2d1e36d
PE
10252 * doprnt.c: Prefer signed to unsigned when either works.
10253 * eval.c (verror):
10254 * doprnt.c (doprnt):
10255 * lisp.h (doprnt):
10256 * xdisp.c (vmessage):
10257 Use ptrdiff_t, not size_t, when using or implementing doprnt,
10258 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
10259 prefer signed arithmetic to avoid comparison confusion.
10260 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
10261 but is a bit tricky.
10262
0e926e56
PE
10263 Assume freestanding C89 headers, string.h, stdlib.h.
10264 * data.c, doprnt.c, floatfns.c, print.c:
10265 Include float.h unconditionally.
10266 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
10267 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
10268 * regex.c: Likewise for stddef.h, string.h.
10269 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
10270 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
10271 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
10272 (STDC_HEADERS): Remove obsolete defines.
10273 * sysdep.c: Include limits.h unconditionally.
10274
9cfdb3ec
PE
10275 Assume support for memcmp, memcpy, memmove, memset.
10276 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
10277 * regex.c (memcmp, memcpy):
10278 Remove; we assume C89 now.
10279
10280 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
10281 (__malloc_safe_bcopy): Remove; no longer needed.
10282
cf950e6b 10283 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
10284 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
10285 well either way, and we prefer signed to unsigned.
10286
dbf38e02
LMI
102872011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
10288
10289 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
10290 closes the connection while we're reading (bug#9182).
10291
d6f0886c 102922011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 10293
d6f0886c
JD
10294 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
10295 are specified (Bug#9168).
24e0f6b1 10296
2eb1f9e6
PE
102972011-07-25 Paul Eggert <eggert@cs.ucla.edu>
10298
10299 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
10300 Found by GCC static checking and --with-wide-int on a 32-bit host.
10301
22381272 103022011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
10303
10304 * xdisp.c (compute_display_string_pos): Fix logic of caching
10305 previous display string position. Initialize cached_prev_pos to
10306 -1. Fixes slow-down at the beginning of a buffer.
10307
f25e39b4
EZ
103082011-07-24 Eli Zaretskii <eliz@gnu.org>
10309
10310 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
10311 for attrs[LFACE_FONTSET_INDEX].
10312
04c4b52e
PE
103132011-07-23 Paul Eggert <eggert@cs.ucla.edu>
10314
10315 * xml.c (parse_region): Remove unused local
10316 that was recently introduced.
10317
c1734fbd
EZ
103182011-07-23 Eli Zaretskii <eliz@gnu.org>
10319
be18c5a5
EZ
10320 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
10321 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
10322
c1734fbd
EZ
10323 * xdisp.c (move_it_in_display_line_to): Record the best matching
10324 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
10325 exit if none of the characters scanned was an exact match.
10326 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
10327 when exact match is impossible due to invisible text, and the
10328 lines are truncated.
10329
a258d627
JD
103302011-07-23 Jan Djärv <jan.h.d@swipnet.se>
10331
10332 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
10333 for OSX >= 10.7.
10334
b6d5a689
EZ
103352011-07-22 Eli Zaretskii <eliz@gnu.org>
10336
0f74f785
EZ
10337 Fix a significant slow-down of cursor motion with C-n, C-p,
10338 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
10339 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 10340 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
10341 (next_element_from_buffer): Call compute_stop_pos_backwards to
10342 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
10343 base_level_stop.
10344 (reseat): Don't look for prev_stop, as that could mean a very long
10345 run.
10346 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
10347 <cached_disp_overlay_modiff>: Cache for last found display string
10348 position.
551918c1 10349 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
10350 about the same buffer in the same area of character positions, and
10351 the buffer wasn't changed since the time the display string
10352 position was cached.
551918c1 10353
b2d0c91a
EZ
103542011-07-22 Eli Zaretskii <eliz@gnu.org>
10355
10356 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
10357 is an integer, which is important for empty lines. (Bug#9149)
10358
043604ee
CY
103592011-07-22 Chong Yidong <cyd@stupidchicken.com>
10360
10361 * frame.c (Fmodify_frame_parameters): In tty case, update the
10362 default face if necessary (Bug#4238).
10363
da4adb04
CY
103642011-07-21 Chong Yidong <cyd@stupidchicken.com>
10365
10366 * editfns.c (Fstring_to_char): No need to explain what a character
10367 is in the docstring (Bug#6576).
10368
9abd0532
LMI
103692011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10370
10371 * xml.c (parse_region): Make sure we always return a tree.
10372
36881d16
HK
103732011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
10374
10375 * xml.c (parse_region): If a document contains only comments,
10376 return that, too.
10377
1e98674d
LMI
103782011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10379
10380 * xml.c (make_dom): Return comments, too.
10381
590bd467
PE
103822011-07-19 Paul Eggert <eggert@cs.ucla.edu>
10383
10384 Port to OpenBSD.
10385 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
10386 and the surrounding thread.
10387 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
10388 rather than fgets, and retry after EINTR. Otherwise, 'emacs
10389 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
10390 timer goes off.
10391 * s/openbsd.h (BROKEN_SIGIO): Define.
10392 * unexelf.c (unexec) [__OpenBSD__]:
10393 Don't update the .mdebug section of the Alpha COFF symbol table.
10394
f41628b2
LMI
103952011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10396
10397 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
10398 (bug#8460).
10399
b59b67c5
PE
104002011-07-18 Paul Eggert <eggert@cs.ucla.edu>
10401
15e3a074
PE
10402 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
10403 This fixes some race conditions on the permissions of any newly
10404 created file.
10405
41bed37d
PE
10406 * alloc.c (valid_pointer_p): Use pipe, not open.
10407 This fixes some permissions issues when debugging.
10408
b59b67c5
PE
10409 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
10410 If fchown fails to set both uid and gid, try to set just gid,
10411 as that is sometimes allowed. Adjust the file's mode to eliminate
10412 setuid or setgid bits that are inappropriate if fchown fails.
10413
925a6be7
SM
104142011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
10415
10416 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
10417 to compare Lisp_Objects.
10418 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
10419 global_gnutls_log_level, don't mistake it for a Lisp_Object.
10420 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
10421
52968808
AS
104222011-07-17 Andreas Schwab <schwab@linux-m68k.org>
10423
0a6a104b
AS
10424 * lread.c (read_integer): Unread even EOF character.
10425 (read1): Likewise. Properly record start position of symbol.
10426
52968808
AS
10427 * lread.c (read1): Read `#:' as empty uninterned symbol if no
10428 symbol character follows.
10429
9e381cdd
PE
104302011-07-17 Paul Eggert <eggert@cs.ucla.edu>
10431
10432 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
10433 This works around a problem with the previous change to Fcopy_file.
10434 Recent glibc declares fchown with __attribute__((warn_unused_result)),
10435 and without this change, GCC might complain about discarding
10436 fchown's return value.
10437
b5641435
JB
104382011-07-16 Juanma Barranquero <lekktu@gmail.com>
10439
10440 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
10441
a8031457
PE
104422011-07-16 Paul Eggert <eggert@cs.ucla.edu>
10443
10444 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
10445
dd889327
LMI
104462011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
10447
750c33f7
LMI
10448 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
10449 it's used from the C level.
10450
dd889327
LMI
10451 * process.c: Use the same condition for POLL_FOR_INPUT in both
10452 keyboard.c and process.c (bug#1858).
10453
87e86684
LM
104542011-07-09 Lawrence Mitchell <wence@gmx.li>
10455
10456 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
10457 (Fgnutls_boot): Use it.
10458
64348f40
AS
104592011-07-15 Andreas Schwab <schwab@linux-m68k.org>
10460
10461 * doc.c (Fsubstitute_command_keys): Revert last change.
10462
1d698799
LMI
104632011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
10464
f863868c
LMI
10465 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
10466 quotes the next character, and doesn't affect other longer
10467 sequences (bug#8935).
10468
1d698799
LMI
10469 * lread.c (syms_of_lread): Clarify that is isn't only
10470 `eval-buffer' and `eval-defun' that's affected by
10471 `lexical-binding' (bug#8460).
10472
aa4b6df6
EZ
104732011-07-15 Eli Zaretskii <eliz@gnu.org>
10474
10475 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 10476 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 10477
5d856da6
PE
104782011-07-14 Paul Eggert <eggert@cs.ucla.edu>
10479
ad6042bb
PE
10480 Fix minor problems found by static checking.
10481 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
10482 (elsz): Now a signed constant, not a size_t var. We prefer signed
10483 types to unsigned, to avoid integer comparison confusion. Without
10484 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
10485 "cannot optimize loop, the loop counter may overflow", a symptom
10486 of the confusion.
f00bbb22 10487 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
10488 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
10489
6468f31c
LMI
104902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10491
49080b10
LMI
10492 * search.c (Fre_search_backward): Mention `case-fold-search' in
10493 all the re_search_* functions (bug#8138).
10494
6468f31c
LMI
10495 * keyboard.c (Fopen_dribble_file): Document when the file is
10496 closed (bug#8056).
10497
c965adc5
EZ
104982011-07-14 Eli Zaretskii <eliz@gnu.org>
10499
df9733bf
EZ
10500 * bidi.c (bidi_dump_cached_states): Fix format of displaying
10501 bidi_cache_idx.
10502
0bb23927
EZ
10503 Support bidi reordering of display and overlay strings.
10504 * xdisp.c (compute_display_string_pos)
10505 (compute_display_string_end): Accept additional argument STRING.
10506 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
10507 (reseat_to_string): Initialize bidi_it->string.s and
10508 bidi_it->string.schars.
10509 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
10510 NULL (avoids a crash in bidi_paragraph_init).
10511 Initialize itb.string.lstring.
0bb23927
EZ
10512 (init_iterator): Call bidi_init_it only of a valid
10513 buffer position was specified. Initialize paragraph_embedding to
10514 L2R.
10515 (reseat_to_string): Initialize the bidi iterator.
10516 (display_string): If we need to ignore text properties of
10517 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
10518 original value of -1 will not work with bidi.)
10519 (compute_display_string_pos): First arg is now struct
10520 `text_pos *'; all callers changed. Support display properties on
10521 Lisp strings.
10522 (compute_display_string_end): Support display properties on Lisp
10523 strings.
10524 (init_iterator, reseat_1, reseat_to_string): Initialize the
10525 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
10526 when iterating on a string not from display properties).
640c8776
SM
10527 (compute_display_string_pos, compute_display_string_end):
10528 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
10529 arrow keys.
10530 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
10531 base_level_stop; instead, set base_level_stop to BEGV.
10532 Fixes crashes in vertical-motion.
0bb23927
EZ
10533 (next_element_from_buffer): Improve commentary for when
10534 the iterator is before prev_stop.
10535 (init_iterator): Initialize bidi_p from the default value of
10536 bidi-display-reordering, not from buffer-local value. Use the
10537 buffer-local value only if initializing for buffer iteration.
10538 (handle_invisible_prop): Support invisible properties on strings
10539 that are being bidi-reordered.
10540 (set_iterator_to_next): Support bidi reordering of C strings and
10541 Lisp strings.
10542 (next_element_from_string): Support bidi reordering of Lisp
10543 strings.
10544 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
10545 (display_string): Support display of R2L glyph rows.
10546 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
10547 (init_iterator): Don't initialize it->bidi_p for strings
10548 here.
10549 (reseat_to_string): Initialize it->bidi_p for strings here.
10550 (next_element_from_string, next_element_from_c_string)
10551 (next_element_from_buffer): Add xassert's for correspondence
10552 between IT's object being iterated and it->bidi_it.string
10553 structure.
10554 (face_before_or_after_it_pos): Support bidi iteration.
10555 (next_element_from_c_string): Handle the case of the first string
10556 character that is not the first one in the visual order.
10557 (get_visually_first_element): New function, refactored from common
10558 parts of next_element_from_buffer, next_element_from_string, and
10559 next_element_from_c_string.
10560 (tool_bar_lines_needed, redisplay_tool_bar)
10561 (display_menu_bar): Force left-to-right direction. Add a FIXME
10562 comment for making that be controlled by a user option.
10563 (push_it, pop_it): Save and restore the state of the
10564 bidi iterator. Save and restore the bidi_p flag.
10565 (pop_it): Iterate out of display property for string iteration as
10566 well.
10567 (iterate_out_of_display_property): Support iteration over strings.
10568 (handle_single_display_spec): Set up it->bidi_it for iteration
10569 over a display string, and call bidi_init_it.
10570 (handle_single_display_spec, next_overlay_string)
10571 (get_overlay_strings_1, push_display_prop): Set up the bidi
10572 iterator for displaying display or overlay strings.
10573 (forward_to_next_line_start): Don't use the shortcut if
10574 bidi-iterating.
10575 (back_to_previous_visible_line_start): If handle_display_prop
10576 pushed the iterator stack, restore the internal state of the bidi
10577 iterator by calling bidi_pop_it same number of times.
10578 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
10579 and we are bidi-iterating, don't decrement the iterator position;
10580 instead, set the first_elt flag in the bidi iterator, to produce
10581 the same effect.
10582 (reseat_1): Remove redundant setting of string_from_display_prop_p.
10583 (push_display_prop): xassert that we are iterating a buffer.
10584 (push_it, pop_it): Save and restore paragraph_embedding member.
10585 (handle_single_display_spec, next_overlay_string)
10586 (get_overlay_strings_1, reseat_1, reseat_to_string)
10587 (push_display_prop): Set up the `unibyte' member of bidi_it.string
10588 correctly. Don't assume unibyte strings are not bidi-reordered.
10589 (compute_display_string_pos)
10590 (compute_display_string_end): Fix handling the case of C string.
10591 (push_it, pop_it): Save and restore from_disp_prop_p.
10592 (handle_single_display_spec, push_display_prop): Set the
10593 from_disp_prop_p flag.
10594 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
10595 (pop_it): Call iterate_out_of_display_property only if we are
10596 popping after iteration over a string that came from a display
10597 property. Fix a typo in popping stretch info. Add an assertion
10598 for verifying that the iterator position is in sync with the bidi
10599 iterator.
10600 (handle_single_display_spec, get_overlay_strings_1)
10601 (push_display_prop): Fix initialization of paragraph direction for
10602 string when that of the parent object is not yet determined.
10603 (reseat_1): Call bidi_init_it to resync the bidi
10604 iterator with IT's position. (Bug#7616)
10605 (find_row_edges): If ROW->start.pos gives position
10606 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
10607 (handle_stop, back_to_previous_visible_line_start, reseat_1):
10608 Reset the from_disp_prop_p flag.
10609 (SAVE_IT, RESTORE_IT): New macros.
10610 (pos_visible_p, face_before_or_after_it_pos)
10611 (back_to_previous_visible_line_start)
10612 (move_it_in_display_line_to, move_it_in_display_line)
10613 (move_it_to, move_it_vertically_backward, move_it_by_lines)
10614 (try_scrolling, redisplay_window, display_line): Use them when
10615 saving a temporary copy of the iterator and restoring it back.
10616 (back_to_previous_visible_line_start, reseat_1)
10617 (init_iterator): Empty the bidi cache "stack".
10618 (move_it_in_display_line_to): If iterator ended up at
10619 EOL, but we never saw any buffer positions smaller than
10620 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
10621 motion in bidi-reordered lines.
10622 (move_it_in_display_line_to): Record prev_method and prev_pos
10623 immediately before the call to set_iterator_to_next. Fixes cursor
10624 motion in bidi-reordered lines with stretch glyphs and strings
10625 displayed in margins. (Bug#8133) (Bug#8867)
10626 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
10627 TO_CHARPOS.
640c8776
SM
10628 (pos_visible_p): Support positions in bidi-reordered lines.
10629 Save and restore bidi cache.
0bb23927
EZ
10630
10631 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
10632 (bidi_paragraph_info): Delete unused struct.
10633 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
10634 (bidi_cache_start): New variable.
10635 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
10636 to zero.
10637 (bidi_cache_fetch_state, bidi_cache_search)
10638 (bidi_cache_find_level_change, bidi_cache_iterator_state)
10639 (bidi_cache_find, bidi_peek_at_next_level)
10640 (bidi_level_of_next_char, bidi_find_other_level_edge)
10641 (bidi_move_to_visually_next): Compare cache index with
10642 bidi_cache_start rather than with zero.
10643 (bidi_fetch_char): Accept new argument STRING; all callers
10644 changed. Support iteration over a string. Support strings with
10645 display properties. Support unibyte strings. Fix the type of
10646 `len' according to what STRING_CHAR_AND_LENGTH expects.
10647 (bidi_paragraph_init, bidi_resolve_explicit_1)
10648 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
10649 (bidi_level_of_next_char, bidi_move_to_visually_next):
10650 Support iteration over a string.
0bb23927
EZ
10651 (bidi_set_sor_type, bidi_resolve_explicit_1)
10652 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
10653 can now be zero (for strings); special values 0 and -1 were
10654 changed to -1 and -2, respectively.
10655 (bidi_char_at_pos): New function.
10656 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
10657 Call it instead of FETCH_MULTIBYTE_CHAR.
10658 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
10659 initialized to valid values.
10660 (bidi_init_it): Don't initialize charpos and bytepos with invalid
10661 values.
10662 (bidi_level_of_next_char): Allow the sentinel "position" to pass
10663 the test for valid cached positions. Fix the logic for looking up
10664 the sentinel state in the cache. GCPRO the Lisp string we are
10665 iterating.
10666 (bidi_push_it, bidi_pop_it): New functions.
10667 (bidi_initialize): Initialize the bidi cache start stack pointer.
10668 (bidi_cache_ensure_space): New function, refactored from part of
10669 bidi_cache_iterator_state. Don't assume the required size is just
10670 one BIDI_CACHE_CHUNK away.
10671 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
10672 (bidi_count_bytes, bidi_char_at_pos): New functions.
10673 (bidi_cache_search): Don't assume bidi_cache_last_idx is
10674 always valid if bidi_cache_idx is valid.
10675 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
10676 is valid if it's going to be used.
10677 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
10678 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
10679 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10680 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
10681 (bidi_find_other_level_edge, bidi_cache_start_stack):
10682 All variables related to cache indices are now EMACS_INT.
c965adc5 10683
0bb23927
EZ
10684 * dispextern.h (struct bidi_string_data): New structure.
10685 (struct bidi_it): New member `string'. Make flag members be 1-bit
10686 fields, and put them last in the struct.
640c8776
SM
10687 (compute_display_string_pos, compute_display_string_end):
10688 Update prototypes.
0bb23927
EZ
10689 (bidi_push_it, bidi_pop_it): Add prototypes.
10690 (struct iterator_stack_entry): New members bidi_p,
10691 paragraph_embedding, and from_disp_prop_p.
10692 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
10693 (bidi_shelve_cache, bidi_unshelve_cache):
10694 Declare prototypes.
0bb23927
EZ
10695
10696 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
10697 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
10698 and vector-like objects.
10699
10700 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
10701 cache around display iteration.
10702
10703 * window.c (Fwindow_end, window_scroll_pixel_based)
10704 (displayed_window_lines, Frecenter): Save and restore the bidi
10705 cache around display iteration.
10706
3bbd2265
LMI
107072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10708
10709 * editfns.c (Fdelete_region): Clarify the use of the named
10710 parameters (bug#6788).
10711
adc47434
MR
107122011-07-14 Martin Rudalics <rudalics@gmx.at>
10713
10714 * indent.c (Fvertical_motion): Set and restore w->pointm when
10715 saving and restoring the window's buffer (Bug#9006).
10716
837c31f8
LMI
107172011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
10718
10719 * editfns.c (Fstring_to_char): Clarify just what is returned
10720 (bug#6576). Text by Eli Zaretskii.
10721
ac389d0c
JB
107222011-07-13 Juanma Barranquero <lekktu@gmail.com>
10723
10724 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
10725
0be0ce47
EZ
107262011-07-13 Eli Zaretskii <eliz@gnu.org>
10727
10728 * buffer.c (mmap_find): Fix a typo.
10729
cd18e7e3
JB
107302011-07-13 Johan Bockgård <bojohan@gnu.org>
10731
10732 Fix execution of x selection hooks.
10733 * xselect.c (Qx_lost_selection_functions)
10734 (Qx_sent_selection_functions): New vars.
10735 (syms_of_xselect): DEFSYM them.
10736 (x_handle_selection_request): Pass Qx_sent_selection_functions
10737 rather than Vx_sent_selection_functions to Frun_hook_with_args.
10738 (x_handle_selection_clear,x_clear_frame_selections):
10739 Pass Qx_lost_selection_functions rather than
10740 Vx_lost_selection_functions to Frun_hook_with_args.
10741
47ea7f44
PE
107422011-07-13 Paul Eggert <eggert@cs.ucla.edu>
10743
ac389d0c 10744 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
10745 The old code sometimes used this field without initializing it.
10746
47ea7f44
PE
10747 * alloc.c (gc_sweep): Don't read past end of array.
10748 In theory, the old code could also have corrupted Emacs internals,
10749 though it'd be very unlikely.
10750
bc985c87
AS
107512011-07-12 Andreas Schwab <schwab@linux-m68k.org>
10752
10753 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 10754 argument. (Bug#4026)
bc985c87 10755
0cf34688
LMI
107562011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
10757
b3dadd76
LMI
10758 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
10759 key" (bug#4257).
10760
0cf34688
LMI
10761 * window.c (Fset_window_start): Doc fix (bug#4199).
10762 (Fset_window_hscroll): Ditto.
10763
270768cd
PE
107642011-07-12 Paul Eggert <eggert@cs.ucla.edu>
10765
077e3dda 10766 Fix minor new problems caught by GCC 4.6.1.
270768cd 10767 * term.c (init_tty): Remove unused local.
490011a6 10768 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 10769 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 10770 not used otherwise.
270768cd 10771
b1f58454
CY
107722011-07-12 Chong Yidong <cyd@stupidchicken.com>
10773
10774 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
10775
22b9578d
LMI
107762011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10777
6e70ab07
LMI
10778 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
10779 are the mini-buffer and the echo area (bug#3320).
10780
22b9578d
LMI
10781 * term.c (init_tty): Remove support for supdup, c10 and perq
10782 terminals, which are no longer supported (bug#1482).
10783
8974cc9f
JB
107842011-07-10 Johan Bockgård <bojohan@gnu.org>
10785
10786 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
10787
a560d974
JD
107882011-07-10 Jan Djärv <jan.h.d@swipnet.se>
10789
10790 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
10791 for non-popups (Bug#3642).
10792
1dae0f0a
AS
107932011-07-10 Andreas Schwab <schwab@linux-m68k.org>
10794
268c2c36 10795 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 10796 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
10797 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
10798 * cm.c (losecursor): Likewise.
1dae0f0a
AS
10799 * data.c (fmod): Likewise.
10800 * dispnew.c (swap_glyphs_in_rows): Likewise.
10801 * emacs.c (memory_warning_signal): Likewise.
10802 * floatfns.c (float_error): Likewise.
10803 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
10804 (otf_open, font_otf_capability, generate_otf_features)
10805 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
10806 Likewise.
10807 * image.c (pbm_read_file): Likewise.
10808 * indent.c (string_display_width): Likewise.
10809 * intervals.c (check_for_interval, search_for_interval)
10810 (inc_interval_count, count_intervals, root_interval)
10811 (adjust_intervals_for_insertion, make_new_interval): Likewise.
10812 * lread.c (defalias): Likewise.
268c2c36 10813 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
10814 * regex.c (set_image_of_range_1, set_image_of_range)
10815 (regex_grow_registers): Likewise.
10816 * sysdep.c (strerror): Likewise.
10817 * termcap.c (valid_filename_p, tprint, main): Likewise.
10818 * tparam.c (main): Likewise.
10819 * unexhp9k800.c (run_time_remap, save_data_space)
10820 (update_file_ptrs, read_header, write_header, calculate_checksum)
10821 (copy_file, copy_rest, display_header): Likewise.
10822 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
10823 Likewise.
10824 * xdisp.c (check_it): Likewise.
10825 * xfaces.c (register_color, unregister_color, unregister_colors):
10826 Likewise.
10827 * xfns.c (print_fontset_result): Likewise.
10828 * xrdb.c (member, fatal, main): Likewise.
10829
99033785
PE
108302011-07-10 Paul Eggert <eggert@cs.ucla.edu>
10831
10832 Fix minor problems found by static checking (Bug#9031).
10833 * chartab.c (char_table_set_range, map_sub_char_table):
10834 Remove unused locals.
10835 (uniprop_table): Now static.
10836 * composite.c (_work_char): Remove unused static var.
10837
9cb2ac56
JB
108382011-07-09 Juanma Barranquero <lekktu@gmail.com>
10839
10840 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
10841
f25661f0
JD
108422011-07-09 Jan Djärv <jan.h.d@swipnet.se>
10843
10844 * gtkutil.c (qttip_cb): Remove code without function.
10845
8278c4fe
EZ
108462011-07-09 Eli Zaretskii <eliz@gnu.org>
10847
10848 * w32.c (pthread_sigmask): New stub.
10849
1692ae2d 108502011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 10851
8a6ebd58 10852 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
10853 sigprocmask is portable only for single-threaded applications, and
10854 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
10855 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
10856 (LIBES): Use it.
10857 * callproc.c (Fcall_process):
10858 * process.c (create_process):
10859 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
10860 Use pthread_sigmask, not sigprocmask.
123403e4 10861
1b854618
JD
108622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10863
10864 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
10865 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
10866 wrong (Bug#8591).
10867
3fe4b549
JD
108682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10869
0ce7e563
JD
10870 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10871 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
10872 (xg_hide_tooltip): Fix comment.
10873
3fe4b549
JD
10874 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
10875 in registerServicesMenuSendTypes.
10876 (validRequestorForSendType): Don't check ns_return_types.
10877
10878 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
10879 ns_return_type.
10880
5df75e47
JR
108812011-07-08 Jason Rumney <jasonr@gnu.org>
10882
22610910
JR
10883 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
10884 SH_SHOW for hidden windows (Bug#5482).
10885
5df75e47
JR
10886 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
10887 frame struct members of non-existent frames (Bug#6284).
10888
699c10bd
JD
108892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10890
4393663b
JD
10891 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
10892 variable firstTime not needed on OSX >= 10.6.
10893 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
10894 >= 10.5. Use setKnobProportion, setDoubleValue.
10895
10896 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
10897 (MAC_OS_X_VERSION_10_5): Define if not defined.
10898 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
10899 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
10900 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
10901
10902 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 10903 cString and lossyCString on OSX >= 10.4.
4393663b 10904
58179cce 10905 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10906 sizeToFit on OSX >= 10.2.
10907
10908 * nsimage.m (allocInitFromFile): Don't use deprecated method
10909 bestRepresentationForDevice on OSX >= 10.6.
10910
10911 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10912 to avoid warning.
10913
10914 * emacs.c: Declare unexec_init_emacs_zone.
10915
a63e0781
JD
10916 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10917
699c10bd
JD
10918 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10919
10920 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10921 on svcsMenu (Bug#8842).
10922
10923 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10924 ns_return_types.
10925 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10926
10927 * nsterm.m (QUTF8_STRING): Declare.
10928 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10929 (validRequestorForSendType): Return type is (id).
10930 Change indexOfObjectIdenticalTo to indexOfObject.
10931 Check if we have local selection before returning self (Bug#8842).
10932 (writeSelectionToPasteboard): Put local selection into paste board
10933 if we have a local selection (Bug#8842).
10934 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10935
10936 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10937 (ns_get_local_selection): Declare.
10938
54e10184
LMI
109392011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10940
9888ff71
LMI
10941 * keymap.c (describe_map_tree): Don't insert a double newline at
10942 the end of the buffer (bug#1169) and return whether we inserted
10943 something.
10944
54e10184
LMI
10945 * callint.c (Fcall_interactively): Change "reading args" to
10946 "providing args" to try to clarify what it does (bug#1010).
10947
15fa4783
KH
109482011-07-07 Kenichi Handa <handa@m17n.org>
10949
10950 * composite.c (composition_compute_stop_pos): Ignore a static
10951 composition starting before CHARPOS (Bug#8915).
10952
10953 * xdisp.c (handle_composition_prop): Likewise.
10954
a8815b00
EZ
109552011-07-07 Eli Zaretskii <eliz@gnu.org>
10956
10957 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10958 (Bug#9015)
10959
ef7b981d 109602011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10961
10962 * character.h (unicode_category_t): New enum type.
10963
10964 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10965 (Qchar_code_property_table): New variable.
10966 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10967 (UNIPROP_COMPRESSED_FORM_P): New macros.
10968 (char_table_ascii): Uncompress the compressed values.
10969 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10970 Uncompress the compressed values.
ac389d0c 10971 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10972 (char_table_ref_and_range): Uncompress the compressed values.
10973 (sub_char_table_set): New arg is_uniprop. Callers changed.
10974 Uncompress the compressed values.
10975 (sub_char_table_set_range): Args changed. Callers changed.
10976 (char_table_set_range): Adjuted for the above change.
10977 (map_sub_char_table): Delete args default_val and parent. Add arg
10978 top. Give decoded values to a Lisp function.
640c8776 10979 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10980 values to a Lisp function. Gcpro more variables.
10981 (uniprop_table_uncompress)
10982 (uniprop_decode_value_run_length): New functions.
10983 (uniprop_decoder, uniprop_decoder_count): New variables.
10984 (uniprop_get_decoder, uniprop_encode_value_character)
10985 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10986 New functions.
10987 (uniprop_encoder, uniprop_encoder_count): New variables.
10988 (uniprop_get_encoder, uniprop_table)
10989 (Funicode_property_table_internal, Fget_unicode_property_internal)
10990 (Fput_unicode_property_internal): New functions.
10991 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10992 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10993 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10994 char-code-property-alist.
10995
640c8776 10996 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10997 Vunicode_category_table.
10998
640c8776 10999 * font.c (font_range): Adjust for the change of
c805dec0
KH
11000 Vunicode_category_table.
11001
76b397fb
DN
110022011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
11003
11004 * m/iris4d.h: Remove file, move contents ...
11005 * s/irix6-5.h: ... here.
11006
22b4128e
PE
110072011-07-06 Paul Eggert <eggert@cs.ucla.edu>
11008
11009 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
11010 * alloc.c (mark_buffer):
11011 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
11012 (clone_per_buffer_values): Don't assume that
22b4128e
PE
11013 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
11014 This isn't true in general, and it's particularly not true
11015 if Emacs is configured with --with-wide-int.
11016 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
11017 New macros, used in the buffer.c change.
11018
869795d6
JD
110192011-07-05 Jan Djärv <jan.h.d@swipnet.se>
11020
11021 * xsettings.c: Use both GConf and GSettings if both are available.
11022 (store_config_changed_event): Add comment.
11023 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
11024 (store_tool_bar_style_changed): New functions.
5e617bc2 11025 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
11026 (struct xsettings): Move font inside HAVE_XFT.
11027 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 11028 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 11029 Move inside HAVE_XFT.
640c8776 11030 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
11031 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
11032 also.
11033 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 11034 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 11035 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
11036 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
11037 (parse_settings): Move check for font inside HAVE_XFT.
11038 (read_settings, apply_xft_settings): Add comment.
11039 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
11040 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
11041 call store_font_name_changed.
11042 (xft_settings_event): Add comment.
11043 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
11044 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
11045 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
11046 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
11047 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
11048 (xsettings_get_system_font, xsettings_get_system_normal_font):
11049 Add comment.
869795d6 11050
d8ed26bd
PE
110512011-07-05 Paul Eggert <eggert@cs.ucla.edu>
11052
11053 Random fixes. E.g., (random) never returned negative values.
11054 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
11055 subseconds part to the entropy, as that's a bit more random.
11056 Prefer signed to unsigned, since the signedness doesn't matter and
11057 in general we prefer signed. When given a limit, use a
11058 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
11059 latter isn't right if USE_2_TAGS_FOR_INTS.
11060 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
11061 not 0..VALMASK. Don't discard "excess" bits that random () returns.
11062
cabf1cac
SM
110632011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
11064
11065 * textprop.c (text_property_stickiness):
11066 Obey Vtext_property_default_nonsticky.
11067 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
11068 * w32fns.c (syms_of_w32fns):
11069 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
11070
6e9b2be9
PE
110712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11072
11073 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
11074 This is more efficient than Ffile_directory_p and avoids a minor race.
11075
90186c68
LMI
110762011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
11077
7c301272
LMI
11078 * buffer.c (Foverlay_put): Say what the return value is
11079 (bug#7835).
11080
c4f2d8d4
LMI
11081 * fileio.c (barf_or_query_if_file_exists): Check first if the file
11082 is a directory before asking whether to use the file name
11083 (bug#7564).
ad637907
LMI
11084 (barf_or_query_if_file_exists): Make the "File is a directory"
11085 error be more correct.
c4f2d8d4 11086
90186c68
LMI
11087 * fns.c (Frequire): Remove the mention of the .gz files, since
11088 that's installation-specific, but keep the mention of
11089 `get-load-suffixes'.
11090
da64016e
PE
110912011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11092
11093 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
11094 Report string overflow if the output is too long.
11095
7d47b580
JB
110962011-07-04 Juanma Barranquero <lekktu@gmail.com>
11097
a555cb87
JB
11098 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
11099 (syms_of_gnutls): Remove duplicate DEFSYM for
11100 Qgnutls_bootprop_verify_hostname_error, an error for
11101 Qgnutls_bootprop_verify_error (which is no longer used).
11102
7d47b580
JB
11103 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
11104 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
11105 Also (re)move comments that are misplaced or no longer relevant.
11106
1e49bfab
LMI
111072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11108
11109 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
11110
1485f4c0
CY
111112011-07-03 Chong Yidong <cyd@stupidchicken.com>
11112
11113 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
11114 and background color parameters if they have been changed.
11115
a9ab721e
LMI
111162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11117
11118 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
11119
cf7cff57
PE
111202011-07-03 Paul Eggert <eggert@cs.ucla.edu>
11121
2e13213d
PE
11122 * xsettings.c (SYSTEM_FONT): Define only when used.
11123 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
11124
cf7cff57
PE
11125 * keymap.c (access_keymap_1): Now static.
11126
7a8e04f7
CY
111272011-07-02 Chong Yidong <cyd@stupidchicken.com>
11128
11129 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
11130 leave any prefix arg for the up event (Bug#1586).
11131
61352f62
LMI
111322011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
11133
69bb1ef7
LMI
11134 * lread.c (syms_of_lread): Mention single symbols defined by
11135 `defvar' or `defconst' (bug#7154).
11136
61352f62 11137 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 11138 (Frequire): Mention get-load-suffixes.
61352f62 11139
28545e04
MR
111402011-07-02 Martin Rudalics <rudalics@gmx.at>
11141
11142 * window.h (window): Remove clone_number slot.
11143 * window.c (Fwindow_clone_number, Fset_window_clone_number):
11144 Remove.
11145 (make_parent_window, make_window, saved_window)
11146 (Fset_window_configuration, save_window_save): Don't deal with
11147 clone numbers.
11148 * buffer.c (Qclone_number): Remove declaration.
11149 (sort_overlays, overlay_strings): Don't deal with clone numbers.
11150
3349e122
SM
111512011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
11152
11153 Add multiple inheritance to keymaps.
11154 * keymap.c (Fmake_composed_keymap): New function.
11155 (Fset_keymap_parent): Simplify.
11156 (fix_submap_inheritance): Remove.
11157 (access_keymap_1): New function extracted from access_keymap to handle
11158 embedded parents and handle lists of maps.
11159 (access_keymap): Use it.
11160 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
11161 (Fcopy_keymap): Handle embedded parents.
11162 (Fcommand_remapping, define_as_prefix): Simplify.
11163 (Fkey_binding): Simplify.
11164 (syms_of_keymap): Move minibuffer-local-completion-map,
11165 minibuffer-local-filename-completion-map,
11166 minibuffer-local-must-match-map, and
11167 minibuffer-local-filename-must-match-map to Elisp.
11168 (syms_of_keymap): Defsubr make-composed-keymap.
11169 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
11170 (parse_menu_item): Trivial simplification.
11171
3279eb87
GM
111722011-07-01 Glenn Morris <rgm@gnu.org>
11173
11174 * Makefile.in (SETTINGS_LIBS): Fix typo.
11175
39cb9e56 111762011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
11177
11178 * coding.c (Fencode_coding_string): Record the last coding system
11179 used, as the function doc string says (bug#8738).
11180
0949d2b6
JD
111812011-07-01 Jan Djärv <jan.h.d@swipnet.se>
11182
11183 * xsettings.c (store_monospaced_changed): Take new font as arg and
11184 check for change against current_mono_font.
11185 (EMACS_TYPE_SETTINGS): Remove this and related defines.
11186 (emacs_settings_constructor, emacs_settings_get_property)
11187 (emacs_settings_set_property, emacs_settings_class_init)
11188 (emacs_settings_init, gsettings_obj): Remove.
11189 (something_changedCB): New function for HAVE_GSETTINGS.
11190 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
11191 with value as argument.
11192 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
11193 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 11194 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
11195 "changed".
11196
11197 * xgselect.c: Add defined (HAVE_GSETTINGS).
11198 (xgselect_initialize): Ditto.
11199
11200 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
11201 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
11202 xg_select.
11203
bbc6b304
PE
112042011-07-01 Paul Eggert <eggert@cs.ucla.edu>
11205
11206 * eval.c (struct backtrace): Simplify and port the data structure.
11207 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
11208 signed bit field, as this assumption is not portable and it makes
11209 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
11210 "char debug_on_exit : 1" as this is not portable either; instead,
11211 use the portable "unsigned int debug_on_exit : 1". Remove unused
11212 member evalargs. Remove obsolete comments about cc bombing out.
11213
9851bfc5
JD
112142011-06-30 Jan Djärv <jan.h.d@swipnet.se>
11215
51bb811f 11216 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
11217 Let HAVE_GSETTINGS override HAVE_GCONF.
11218 (store_monospaced_changed): New function.
11219 (EMACS_SETTINGS): A new type derived from GObject to handle
11220 GSettings notifications.
11221 (emacs_settings_constructor, emacs_settings_get_property)
11222 (emacs_settings_set_property, emacs_settings_class_init):
11223 New functions.
11224 (gsettings_client, gsettings_obj): New variables.
11225 (GSETTINGS_SCHEMA): New define.
11226 (something_changedCB): Call store_monospaced_changed.
11227 (init_gsettings): New function.
11228 (xsettings_initialize): Call init_gsettings.
11229 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
11230 to NULL.
11231
640c8776 11232 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
11233 GCONF_CFLAGS/LIBS.
11234
5386012d
MR
112352011-06-29 Martin Rudalics <rudalics@gmx.at>
11236
11237 * window.c (resize_root_window, grow_mini_window)
11238 (shrink_mini_window): Rename Qresize_root_window to
11239 Qwindow_resize_root_window and Qresize_root_window_vertically to
11240 Qwindow_resize_root_window_vertically.
11241
f13e0b08
PE
112422011-06-28 Paul Eggert <eggert@cs.ucla.edu>
11243
11244 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
11245
94515237
JB
112462011-06-27 Juanma Barranquero <lekktu@gmail.com>
11247
11248 * makefile.w32-in: Redesign dependencies so they reflect more
11249 clearly which files are directly included by each source file,
11250 and not through other includes.
11251
e43b6e43
MR
112522011-06-27 Martin Rudalics <rudalics@gmx.at>
11253
11254 * buffer.c (Qclone_number): Declare static and DEFSYM it.
11255 (sort_overlays, overlay_strings): When an overlay's clone number
11256 matches the window's clone number process the overlay even if
11257 the overlay's window property doesn't match the current window.
11258
d68443dc
MR
11259 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
11260 (Fwindow_hchild): Rename to Fwindow_left_child.
11261 (Fwindow_next): Rename to Fwindow_next_sibling.
11262 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
11263 (resize_window_check): Rename to window_resize_check.
11264 (resize_window_apply): Rename to window_resize_apply.
11265 (Fresize_window_apply): Rename to Fwindow_resize_apply.
11266 (Fdelete_other_windows_internal, resize_frame_windows)
11267 (Fsplit_window_internal, Fdelete_window_internal)
11268 (grow_mini_window, shrink_mini_window)
11269 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 11270
c7e73be5
JD
112712011-06-26 Jan Djärv <jan.h.d@swipnet.se>
11272
11273 * emacsgtkfixed.h: State that this is only used with Gtk+3.
11274 (emacs_fixed_set_min_size): Remove.
11275 (emacs_fixed_new): Take frame as argument.
11276
11277 * emacsgtkfixed.c: State that this is only used with Gtk+3.
11278 (_EmacsFixedPrivate): Remove minwidth/height.
11279 Add struct frame *f.
11280 (emacs_fixed_init): Initialize priv->f.
11281 (get_parent_class, emacs_fixed_set_min_size): Remove.
11282 (emacs_fixed_new): Set priv->f to argument.
11283 (emacs_fixed_get_preferred_width)
11284 (emacs_fixed_get_preferred_height): Use min_width/height from
11285 frames size_hint to set minimum and natural (Bug#8919).
11286 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
11287 and use min_width/height from frames size_hint to set
11288 min_width/height (Bug#8919).
11289
11290 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
11291 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
11292 Fix indentation.
c7e73be5 11293
cf99dcf8
EZ
112942011-06-26 Eli Zaretskii <eliz@gnu.org>
11295
11296 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
11297 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
11298 called at ZV.
11299
029529ac
CY
113002011-06-26 Chong Yidong <cyd@stupidchicken.com>
11301
11302 * process.c (wait_reading_process_output): Bypass select if
11303 waiting for a cell while ignoring keyboard input, and input is
11304 pending. Suggested by Jan Djärv (Bug#8869).
11305
7a7ef429
PE
113062011-06-25 Paul Eggert <eggert@cs.ucla.edu>
11307
11308 Use gnulib's dup2 module instead of rolling our own.
11309 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
11310
11fdef7d 113112011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
11312
11313 * dispnew.c (scrolling_window): Before scrolling, turn off a
11314 mouse-highlight in the window being scrolled.
11315
cd3520a4
JB
113162011-06-24 Juanma Barranquero <lekktu@gmail.com>
11317
11318 Move DEFSYM to lisp.h and use everywhere.
11319
11320 * character.h (DEFSYM): Move declaration...
11321 * lisp.h (DEFSYM): ...here.
11322
11323 * gnutls.c:
11324 * minibuf.c:
11325 * w32menu.c:
11326 * w32proc.c:
11327 * w32select.c: Don't include character.h.
11328
11329 * alloc.c (syms_of_alloc):
11330 * buffer.c (syms_of_buffer):
11331 * bytecode.c (syms_of_bytecode):
11332 * callint.c (syms_of_callint):
11333 * casefiddle.c (syms_of_casefiddle):
11334 * casetab.c (init_casetab_once):
11335 * category.c (init_category_once, syms_of_category):
11336 * ccl.c (syms_of_ccl):
11337 * cmds.c (syms_of_cmds):
11338 * composite.c (syms_of_composite):
11339 * dbusbind.c (syms_of_dbusbind):
11340 * dired.c (syms_of_dired):
11341 * dispnew.c (syms_of_display):
11342 * doc.c (syms_of_doc):
11343 * editfns.c (syms_of_editfns):
11344 * emacs.c (syms_of_emacs):
11345 * eval.c (syms_of_eval):
11346 * fileio.c (syms_of_fileio):
11347 * fns.c (syms_of_fns):
11348 * frame.c (syms_of_frame):
11349 * fringe.c (syms_of_fringe):
11350 * insdel.c (syms_of_insdel):
11351 * keymap.c (syms_of_keymap):
11352 * lread.c (init_obarray, syms_of_lread):
11353 * macros.c (syms_of_macros):
11354 * msdos.c (syms_of_msdos):
11355 * print.c (syms_of_print):
11356 * process.c (syms_of_process):
11357 * search.c (syms_of_search):
11358 * sound.c (syms_of_sound):
11359 * syntax.c (init_syntax_once, syms_of_syntax):
11360 * terminal.c (syms_of_terminal):
11361 * textprop.c (syms_of_textprop):
11362 * undo.c (syms_of_undo):
11363 * w32.c (globals_of_w32):
11364 * window.c (syms_of_window):
11365 * xdisp.c (syms_of_xdisp):
11366 * xfaces.c (syms_of_xfaces):
11367 * xfns.c (syms_of_xfns):
11368 * xmenu.c (syms_of_xmenu):
11369 * xsettings.c (syms_of_xsettings):
11370 * xterm.c (syms_of_xterm): Use DEFSYM.
11371
4228cf16
TZ
113722011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
11373
cd3520a4 11374 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 11375
7fcccf1e
PE
113762011-06-23 Paul Eggert <eggert@cs.ucla.edu>
11377
7efb4e0e
PE
11378 Integer and buffer overflow fixes (Bug#8873).
11379
ff5844ad
PE
11380 * print.c (printchar, strout): Check for string overflow.
11381 (PRINTPREPARE, printchar, strout):
11382 Don't set size unless allocation succeeds.
11383
90532f02
PE
11384 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
11385 for sizes. Check for string overflow more accurately.
11386 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
11387
6d84508d
PE
11388 * macros.c: Integer and buffer overflow fixes.
11389 * keyboard.h (struct keyboard.kbd_macro_bufsize):
11390 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
11391 Use ptrdiff_t, not int, for sizes.
11392 Don't increment bufsize until after realloc succeeds.
11393 Check for size-calculation overflow.
11394 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
11395
437b2cb4
PE
11396 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
11397
8b9ac8b4
PE
11398 * lread.c: Integer overflow fixes.
11399 (read_integer): Radix is now EMACS_INT, not int,
11400 to improve quality of diagnostics for out-of-range radices.
11401 Calculate buffer size correctly for out-of-range radices.
11402 (read1): Check for integer overflow in radices, and in
11403 read-circle numbers.
82cb60d3
PE
11404 (read_escape): Avoid int overflow.
11405 (Fload, openp, read_buffer_size, read1)
11406 (substitute_object_recurse, read_vector, read_list, map_obarray):
11407 Use ptrdiff_t, not int, for sizes.
11408 (read1): Use EMACS_INT, not int, for sizes.
20270765 11409 Check for size overflow.
8b9ac8b4 11410
7fcccf1e
PE
11411 * image.c (cache_image): Check for size arithmetic overflow.
11412
bfbbd7e7
PE
11413 * lread.c: Integer overflow issues.
11414 (saved_doc_string_size, saved_doc_string_length)
11415 (prev_saved_doc_string_size, prev_saved_doc_string_length):
11416 Now ptrdiff_t, not int.
11417 (read1): Don't assume doc string length fits in int. Check for
11418 out-of-range doc string lengths.
11419 (read_list): Don't assume file position fits in int.
39019e54 11420 (read_escape): Check for hex character overflow.
bfbbd7e7 11421
4e323265
LL
114222011-06-22 Leo Liu <sdl.web@gmail.com>
11423
11424 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
11425 Move to minibuffer.el.
11426
85fece3e
PE
114272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11428
20b84ce9 11429 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
11430 The following patches are for when GLYPH_DEBUG && !XASSERT.
11431 * dispextern.h (trace_redisplay_p, dump_glyph_string):
11432 * dispnew.c (flush_stdout):
11433 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
11434 Mark as externally visible.
11435 * dispnew.c (check_window_matrix_pointers): Now static.
11436 * dispnew.c (window_to_frame_vpos):
11437 * xfns.c (unwind_create_frame):
11438 * xterm.c (x_check_font): Remove unused local.
11439 * scroll.c (CHECK_BOUNDS):
11440 * xfaces.c (cache_fache): Rename local to avoid shadowing.
11441 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
11442 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
11443 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
11444 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
11445 Now static.
11446 (debug_method_add): Use va_list and vsprintf rather than relying
11447 on undefined behavior with wrong number of arguments.
11448 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
11449 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
11450 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
11451 since we're not interested in debugging glyphs with old libraries.
11452 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
11453 GCC 4.6.0's static checking.
11454
0766b489
PE
114552011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11456
31fd4b32
PE
11457 Integer overflow and signedness fixes (Bug#8873).
11458 A few related buffer overrun fixes, too.
11459
b79e8648
PE
11460 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
11461
0766b489
PE
11462 * dispextern.h (struct face.stipple):
11463 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
11464 (x_bitmap_mask, x_allocate_bitmap_record)
11465 (x_create_bitmap_from_data, x_create_bitmap_from_file)
11466 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
11467 (x_create_bitmap_from_xpm_data):
11468 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
11469 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
11470 (.bitmaps_last):
11471 * xfaces.c (load_pixmap):
11472 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
11473 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
11474 (.bitmaps_last, struct x_output.icon_bitmap):
11475 Use ptrdiff_t, not int, for bitmap indexes.
11476 (x_allocate_bitmap_record): Check for size overflow.
11477 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
11478
b081724f
PE
11479 Use ptrdiff_t, not int, for overlay counts.
11480 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
11481 * editfns.c (overlays_around, get_pos_property):
11482 * textprop.c (get_char_property_and_overlay):
11483 * xdisp.c (next_overlay_change, note_mouse_highlight):
11484 * xfaces.c (face_at_buffer_position):
21514da7
PE
11485 * buffer.c (OVERLAY_COUNT_MAX): New macro.
11486 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
11487 (Fnext_overlay_change, Fprevious_overlay_change)
11488 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 11489 Use ptrdiff_t, not int, for sizes.
21514da7 11490 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 11491
3de73e5e
PE
11492 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
11493
2606c57b
PE
11494 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
11495 (x_session_initialize): Do not assume string length fits in int.
11496
aaafe47a
PE
11497 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
11498 This is unlikely, but can occur if DPI is outlandish.
11499
2674ddc8 11500 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
11501 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
11502
28154962
PE
11503 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
11504 * xrdb.c (magic_file_p, search_magic_path):
11505 Omit last arg SUFFIX; it was always 0. All callers changed.
11506 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
11507
7de51af5
PE
11508 * xfont.c (xfont_match): Avoid need for strlen.
11509
25ed6cc3
PE
11510 * xfns.c: Don't assume strlen fits in int.
11511 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
11512
4eab31dd
PE
11513 * xdisp.c (message_log_check_duplicate): Return intmax_t,
11514 not unsigned long, as we prefer signed integers. All callers changed.
11515 Detect integer overflow in repeat count.
11516 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 11517 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 11518
171e2a58
PE
11519 * termcap.c: Don't assume sizes fit in int and never overflow.
11520 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
11521 (gobble_line): Check for size-calculation overflow.
11522
ad39faca 11523 * minibuf.c (Fread_buffer):
6e5bb2dc 11524 * lread.c (intern, intern_c_string):
74ca2eb3
PE
11525 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
11526 Don't assume string length fits in int.
11527
52c61c22 11528 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
11529 * gtkutil.c (style_changed_cb): Avoid need for strlen.
11530
b5b8c9e5
PE
11531 * font.c: Don't assume string length fits in int.
11532 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
11533 Use ptrdiff_t, not int.
ccd6111c
PE
11534 (font_intern_prop): Don't assume string length fits in int.
11535 Don't assume integer property fits in fixnum.
11536 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 11537
882f0d81 11538 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 11539 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
11540 Reformulate so as not to need the command string.
11541 Invoke gzip -cd rather than gunzip, as it's more portable.
11542 (lock_info_type, lock_file_1, lock_file):
11543 Don't assume pid_t and time_t fit in unsigned long.
11544 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
11545 (current_lock_owner): Prefer signed type for sizes.
11546 Use memcpy, not strncpy, where memcpy is what is really wanted.
11547 Don't assume (via atoi) that time_t and pid_t fit in int.
11548 Check for time_t and/or pid_t out of range, e.g., via a network share.
11549 Don't alloca where an auto var works fine.
11550
93f4cf88
PE
11551 * fileio.c: Fix some integer overflow issues.
11552 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
11553 Don't assume string length fits in int.
11554 (directory_file_name): Don't assume string length fits in long.
11555 (make_temp_name): Don't assume pid fits in int, or that its print
11556 length is less than 20.
11557
f3e92b69
PE
11558 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
11559
1bfdaf10
PE
11560 * coding.c (make_subsidiaries): Don't assume string length fits in int.
11561
35016e9a
PE
11562 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
11563
3d1e65a1
PE
11564 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
11565 We prefer signed integers, even for size calculations.
11566
0b963a93
PE
11567 * emacs.c: Don't assume string length fits in 'int'.
11568 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
11569 (main): Don't invoke strlen when not needed.
11570
573f4b54
PE
11571 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
11572 (XD_DEBUG_MESSAGE): Don't waste a byte.
11573
989f33ba
PE
11574 * callproc.c (getenv_internal_1, getenv_internal)
11575 (Fgetenv_internal):
965d34eb
PE
11576 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
11577
e4d29b33
PE
11578 * lread.c (invalid_syntax): Omit length argument.
11579 All uses changed. This doesn't fix a bug, but it simplifies the
11580 code away from its former Hollerith-constant appearance, and it's
11581 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 11582 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 11583
eb49b136
PE
11584 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
11585 This didn't break anything, but it didn't help either.
11586 It's confusing to put a bogus integer in a place where the actual
11587 value does not matter.
9f62aeb1 11588 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 11589 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 11590
15375a22
PE
11591 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
11592 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
11593 implementation.
b61cc01c
PE
11594 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
11595 We prefer signed types, and the value cannot exceed the EMACS_INT
11596 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
11597 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
11598 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
11599 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 11600
53b2623d
PE
11601 * indent.c (sane_tab_width): New function.
11602 (current_column, scan_for_column, Findent_to, position_indentation)
11603 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 11604 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 11605
51cab52b 11606 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 11607
f2ed8a70
PE
11608 * lisp.h (lint_assume): New macro.
11609 * composite.c (composition_gstring_put_cache):
11610 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
11611
abe80cc6
PE
11612 * editfns.c, insdel.c:
11613 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 11614
b02c740e
PE
11615 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
11616
ebc96716
PE
11617 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
11618
b4e50fa0 11619 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 11620 Use much-faster test for byte-length change.
311d5d7c 11621 Don't assume string byte-length fits in 'int'.
a4cf38e4 11622 Check that character arg fits in 'int'.
85461888 11623 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 11624
c0c1ee9f
PE
11625 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
11626
a498d7f4
PE
11627 * fns.c (concat): Catch string overflow earlier.
11628 Do not rely on integer wraparound.
11629
51cab52b
PE
11630 * dispextern.h (struct it.overlay_strings_charpos)
11631 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
11632 * xdisp.c (forward_to_next_line_start)
11633 (back_to_previous_visible_line_start)
11634 (reseat_at_next_visible_line_start, next_element_from_buffer):
11635 Don't arbitrarily truncate the value of 'selective' to int.
11636
76031fad
PE
11637 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
11638
5eb55db9
PE
11639 * composite.c: Don't truncate sizes to 'int'.
11640 (composition_gstring_p, composition_reseat_it)
11641 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
11642 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
11643 not EMACS_UINT, for indexes.
5eb55db9 11644
0703a717
PE
11645 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
11646
d6202519
PE
11647 * buffer.c: Include <verify.h>.
11648 (struct sortvec.priority, struct sortstr.priority):
8961a454 11649 Now EMACS_INT, not int.
c20998a7 11650 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
11651 (struct sortstr.size, record_overlay_string)
11652 (struct sortstrlist.size, struct sortlist.used):
11653 Don't truncate size to int.
11654 (record_overlay_string): Check for size-calculation overflow.
d6202519 11655 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 11656
d5a19415
JM
116572011-06-22 Jim Meyering <meyering@redhat.com>
11658
029529ac 11659 Don't leak an XBM-image-sized buffer
d5a19415
JM
11660 * image.c (xbm_load): Free the image buffer after using it.
11661
a9041e6c
PE
116622011-06-21 Paul Eggert <eggert@cs.ucla.edu>
11663
11664 Port to Sun C.
11665 * composite.c (find_automatic_composition): Omit needless 'return 0;'
11666 that Sun C diagnosed.
11667 * fns.c (secure_hash): Fix pointer signedness issue.
11668 * intervals.c (static_offset_intervals): New function.
11669 (offset_intervals): Use it.
11670
7f3f739f
LL
116712011-06-21 Leo Liu <sdl.web@gmail.com>
11672
11673 * deps.mk (fns.o):
11674 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
11675 sha512.h.
11676
11677 * fns.c (secure_hash): Rename from crypto_hash_function and change
11678 the first arg to accept symbols.
5b66d427 11679 (Fsecure_hash): New primitive.
7f3f739f
LL
11680 (syms_of_fns): New symbols.
11681
76147d94
DD
116822011-06-20 Deniz Dogan <deniz@dogan.se>
11683
11684 * process.c (Fset_process_buffer): Clarify return value in
11685 docstring.
11686
7d7d0045
CY
116872011-06-18 Chong Yidong <cyd@stupidchicken.com>
11688
11689 * dispnew.c (add_window_display_history): Use BVAR.
11690
11691 * xdisp.c (debug_method_add): Use BVAR.
11692 (check_window_end, dump_glyph_matrix, dump_glyph)
11693 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
11694
11695 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
11696 Likewise.
11697
11698 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
11699 check till after the cache is created in init_frame_faces.
11700
ff2bc410
SM
117012011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
11702
11703 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
11704
28177add
PE
117052011-06-16 Paul Eggert <eggert@cs.ucla.edu>
11706
dd3482fe
PE
11707 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
11708 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
11709 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
11710
393d71f3 11711 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
11712 * fileio.c (Finsert_file_contents):
11713 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
11714 Remove the old (too-loose) buffer overflow checks.
11715 They weren't needed, since make_gap checks for buffer overflow.
11716 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
11717 The old code merely checked for Emacs fixnum overflow, and relied
11718 on undefined (wraparound) behavior. The new code avoids undefined
11719 behavior, and also checks for ptrdiff_t and/or size_t overflow.
11720
2e6813b0 11721 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
11722 Tune. Don't use wider integers than needed. Don't use alloca.
11723 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 11724
599a9e4f
PE
11725 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
11726
99561444
PE
11727 * insdel.c, lisp.h (buffer_overflow): New function.
11728 (insert_from_buffer_1, replace_range, replace_range_2):
11729 * insdel.c (make_gap_larger):
11730 * editfns.c (Finsert_char):
11731 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
11732
28177add
PE
11733 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
11734
e69dafad
PE
117352011-06-15 Paul Eggert <eggert@cs.ucla.edu>
11736
4baa020d 11737 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 11738
b1c46f02
PE
11739 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
11740 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
11741
e69dafad
PE
11742 * fileio.c: Don't assume EMACS_INT fits in off_t.
11743 (emacs_lseek): New static function.
11744 (Finsert_file_contents, Fwrite_region): Use it.
11745 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
11746
566684ea
PE
11747 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
11748
e6966cd6
PE
11749 * fns.c: Don't overflow int when computing a list length.
11750 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
11751 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
11752 truncation on 64-bit hosts. Check for QUIT every
11753 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
11754 faster and is responsive enough.
11755 (Flength): Report an error instead of overflowing an integer.
11756 (Fsafe_length): Return a float if the value is not representable
11757 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 11758 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 11759 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 11760
dd0b0efb
PE
11761 * alloc.c: Check that resized vectors' lengths fit in fixnums.
11762 (header_size, word_size): New constants.
11763 (allocate_vectorlike): Don't check size overflow here.
11764 (allocate_vector): Check it here instead, since this is the only
11765 caller of allocate_vectorlike that could cause overflow.
11766 Check that the new vector's length is representable as a fixnum.
11767
86fe5cfe
PE
11768 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
11769 The previous code was bogus. For example, next_almost_prime (32)
11770 returned 39, which is undesirable as it is a multiple of 3; and
11771 next_almost_prime (24) returned 25, which is a multiple of 5 so
11772 why was the code bothering to check for multiples of 7?
11773
80e88859
PE
11774 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
11775
4a2f0ad6
PE
11776 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
11777
f66c7cf8
PE
11778 Variadic C functions now count arguments with ptrdiff_t.
11779 This partly undoes my 2011-03-30 change, which replaced int with size_t.
11780 Back then I didn't know that the Emacs coding style prefers signed int.
11781 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
11782 were being counted with int, which may truncate counts on 64-bit
11783 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
11784 * lisp.h (struct Lisp_Subr.function.aMANY)
11785 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
11786 Arg counts are now ptrdiff_t, not size_t.
11787 All variadic functions and their callers changed accordingly.
11788 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
11789 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
11790 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
11791 * callint.c (Fcall_interactively): Check arg count for overflow,
11792 to avoid potential buffer overrun. Use signed char, not 'int',
11793 for 'varies' array, so that we needn't bother to check its size
11794 calculation for overflow.
11795 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
11796 * eval.c (apply_lambda):
11797 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
11798 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
11799 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
11800
a1759b76
PE
11801 * callint.c (Fcall_interactively): Don't use index var as event count.
11802
d96be9fc
PE
11803 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
11804 * mem-limits.h (SIZE): Remove; no longer used.
11805
a690a978 11806 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 11807
578c21e6
PE
11808 Remove unnecessary casts.
11809 * xterm.c (x_term_init):
11810 * xfns.c (x_set_border_pixel):
11811 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11812 These aren't needed now that we assume ANSI C.
11813
96f53c6c
PE
11814 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
11815 It's more likely to cause problems (due to unsigned overflow)
11816 than to cure them.
11817
83c77d31
PE
11818 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
11819
ee2079f1
PE
11820 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
11821
6da65536
PE
11822 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
11823
7147c4a4
PE
11824 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
11825
193e32d9
PE
11826 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
11827
e5533da6
PE
11828 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
11829
9910e595
PE
11830 GLYPH_CODE_FACE returns EMACS_INT, not int.
11831 * dispextern.h (merge_faces):
11832 * xfaces.c (merge_faces):
01103c44
PE
11833 * xdisp.c (get_next_display_element, next_element_from_display_vector):
11834 Don't assume EMACS_INT fits in int.
9910e595 11835
2638320e
PE
11836 * character.h (CHAR_VALID_P): Remove unused parameter.
11837 * fontset.c, lisp.h, xdisp.c: All uses changed.
11838
045eb8d9
PE
11839 * editfns.c (Ftranslate_region_internal): Omit redundant test.
11840
c1f134b5
PE
11841 * fns.c (concat): Minor tuning based on overflow analysis.
11842 This doesn't fix any bugs. Use int to hold character, instead
11843 of constantly refetching from Emacs object. Use XFASTINT, not
11844 XINT, for value known to be a character. Don't bother comparing
11845 a single byte to 0400, as it's always less.
11846
395fcb93 11847 * floatfns.c (Fexpt):
327eeec8
PE
11848 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
11849
abbd3d23
PE
11850 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
11851 for characters.
11852
684a03ef
PE
11853 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
11854
0fed43f3
PE
11855 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
11856 Without this fix, on a 64-bit host (aset S 0 4294967386) would
11857 incorrectly succeed when S was a string, because 4294967386 was
11858 truncated before it was used.
11859
8fd02eb7
PE
11860 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
11861 Otherwise, an out-of-range integer could cause undefined behavior
11862 on a 64-bit host.
11863
f8c86b69
PE
11864 * composite.c: Use int, not EMACS_INT, for characters.
11865 (fill_gstring_body, composition_compute_stop_pos): Use int, not
11866 EMACS_INT, for values that are known to be in character range.
11867 This doesn't fix any bugs but is the usual style inside Emacs and
11868 may generate better code on 32-bit machines.
11869
34206dd2
PE
11870 Make sure a 64-bit char is never passed to ENCODE_CHAR.
11871 This is for reasons similar to the recent CHAR_STRING fix.
11872 * charset.c (Fencode_char): Check that character arg is actually
11873 a character. Pass an int to ENCODE_CHAR.
11874 * charset.h (ENCODE_CHAR): Verify that the character argument is no
11875 wider than 'int', as a compile-time check to prevent future regressions
11876 in this area.
11877
c5958d4c 11878 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
11879
11880 Make sure a 64-bit char is never passed to CHAR_STRING.
11881 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
11882 by silently ignoring the top 32 bits, allowing some values
11883 that were far too large to be valid characters.
11884 * character.h: Include <verify.h>.
11885 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
11886 arguments are no wider than unsigned, as a compile-time check
11887 to prevent future regressions in this area.
11888 * data.c (Faset):
01103c44 11889 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
11890 (Fsubst_char_in_region):
11891 * fns.c (concat):
11892 * xdisp.c (decode_mode_spec_coding):
11893 Adjust to CHAR_STRING's new requirement.
11894 * editfns.c (Finsert_char, Fsubst_char_in_region):
11895 * fns.c (concat): Check that character args are actually
11896 characters. Without this test, these functions did the wrong
11897 thing with wildly out-of-range values on 64-bit hosts.
11898
d37ca623
PE
11899 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
11900 These casts should not be needed on 32-bit hosts, either.
11901 * keyboard.c (read_char):
11902 * lread.c (Fload): Remove casts to unsigned.
11903
ea204efb
PE
11904 * lisp.h (UNSIGNED_CMP): New macro.
11905 This fixes comparison bugs on 64-bit hosts.
11906 (ASCII_CHAR_P): Use it.
11907 * casefiddle.c (casify_object):
01103c44 11908 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11909 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11910 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11911 * dispextern.h (FACE_FROM_ID):
11912 * keyboard.c (read_char): Use UNSIGNED_CMP.
11913
41cb286c
PE
11914 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11915 not to EMACS_INT, to avoid GCC warning.
11916
4a1b9832
PE
11917 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11918
55daad71
PE
11919 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11920 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11921 isn't needed on 32-bit machines.
8f95c75c 11922
01103c44
PE
11923 * buffer.c (Fgenerate_new_buffer_name):
11924 Use EMACS_INT for count, not int.
0ceccced 11925 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11926
11927 * data.c (Qcompiled_function): Now static.
11928
c6f072e7
PE
11929 * window.c (window_body_lines): Now static.
11930
20ce5912
PE
11931 * image.c (gif_load): Rename local to avoid shadowing.
11932
9c4c5f81
PE
11933 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11934 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11935 * alloc.c (make_save_value): Integer argument is now of type
11936 ptrdiff_t, not int.
11937 (mark_object): Use ptrdiff_t, not int.
11938 * lisp.h (pD): New macro.
11939 * print.c (print_object): Use it.
11940
c0c5c8ae
PE
11941 * alloc.c: Use EMACS_INT, not int, to count objects.
11942 (total_conses, total_markers, total_symbols, total_vector_size)
11943 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11944 (total_free_floats, total_floats, total_free_intervals)
11945 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11946 Now EMACS_INT, not int. All uses changed.
11947 (Fgarbage_collect): Compute overall total using a double, so that
11948 integer overflow is less likely to be a problem. Check for overflow
11949 when converting back to an integer.
5a25e253
PE
11950 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11951 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11952 These were 'int' variables that could overflow on 64-bit hosts;
11953 they were never used, so remove them instead of repairing them.
211a0b2a 11954 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11955 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11956 Previously, this ceilinged at INT_MAX, but that doesn't work on
11957 64-bit machines.
e46bb31a 11958 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11959
c78baabf 11960 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11961 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11962 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11963 when a (possibly-narrower) signed value would do just as well.
11964 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11965
c9d624c6
PE
11966 * alloc.c: Catch some string size overflows that we were missing.
11967 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11968 for convenience in STRING_BYTES_MAX.
11969 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11970 The definition here is exact; the one in lisp.h was approximate.
11971 (allocate_string_data): Check for string overflow. This catches
11972 some instances we weren't catching before. Also, it catches
11973 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11974 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11975 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11976
c9d624c6
PE
11977 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11978 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11979 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11980
353032ce
PE
11981 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11982
2bccce07
PE
11983 * alloc.c (Fmake_string): Check for out-of-range init.
11984
0ac30604
SM
119852011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11986
11987 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11988
c195f2de
JD
119892011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11990
11991 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11992 xg_get_default_scrollbar_width.
11993
11994 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11995 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11996 (style_changed_cb): Call update_theme_scrollbar_width and call
11997 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11998 all frames (Bug#8505).
11999 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
12000 Call gtk_window_set_resizable if HAVE_GTK3.
12001 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
12002 and height if HAVE_GTK3 (Bug#8505).
12003 (scroll_bar_width_for_theme): New variable.
12004 (update_theme_scrollbar_width): New function.
12005 (xg_get_default_scrollbar_width): Move code to
12006 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
12007 (xg_initialize): Call update_theme_scrollbar_width.
12008
12009 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
12010
12011 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
12012
e10ac9f1
MR
120132011-06-12 Martin Rudalics <rudalics@gmx.at>
12014
12015 * frame.c (make_frame): Call other_buffer_safely instead of
12016 other_buffer.
12017
12018 * window.c (temp_output_buffer_show): Call display_buffer with
12019 second argument Vtemp_buffer_show_specifiers and reset latter
12020 immediately after the call.
12021 (Vtemp_buffer_show_specifiers): New variable.
12022 (auto_window_vscroll_p, next_screen_context_lines)
12023 (Vscroll_preserve_screen_position): Remove leading asterisks from
12024 doc-strings.
12025
2d3c217e 120262011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 12027
7b7f97e8 12028 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
12029 * buffer.c (Qclone_number): Remove for now, as it's unused.
12030 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
12031 (record_buffer): Remove unused local.
12032 * frame.c (other_visible_frames, frame_buffer_list): Now static.
12033 (set_frame_buffer_list): Remove; unused.
12034 * frame.h (other_visible_frames): Remove decl.
12035 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
12036 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12037 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12038 if HAVE_GPM.
12039 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
12040 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
12041 Define only if HAVE_GPM.
12042 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
12043 (update_hints_inhibit): Remove; never set. All uses removed.
12044 * widgetprv.h (emacsFrameClassRec): Remove decl.
12045 * window.c (delete_deletable_window): Now returns void, since it
12046 wasn't returning anything.
12047 (compare_window_configurations): Remove unused locals.
12048 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
12049 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
12050 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
12051 the same widths as pointers. This follows up on the 2011-05-06 patch.
12052 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
12053 * xterm.h: Likewise.
12054 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
12055
1384b89e
JB
120562011-06-12 Juanma Barranquero <lekktu@gmail.com>
12057
12058 * makefile.w32-in: Update dependencies.
12059 (LISP_H): Add lib/intprops.h.
12060
1100a63c
CY
120612011-06-11 Chong Yidong <cyd@stupidchicken.com>
12062
12063 * image.c (gif_load): Add animation frame delay to the metadata.
12064 (syms_of_image): Use DEFSYM. New symbol `delay'.
12065
6198ccd0
MR
120662011-06-11 Martin Rudalics <rudalics@gmx.at>
12067
12068 * window.c (delete_deletable_window): Re-add.
12069 (Fset_window_configuration): Rewrite to handle dead buffers and
12070 consequently deletable windows.
12071 (window_tree, Fwindow_tree): Remove. Supply functionality in
12072 window.el.
12073 (compare_window_configurations): Simplify code.
12074
b6e3633c
AS
120752011-06-11 Andreas Schwab <schwab@linux-m68k.org>
12076
1ab0dee5
AS
12077 * image.c (imagemagick_load_image): Fix type mismatch.
12078 (Fimagemagick_types): Likewise.
12079
b6e3633c
AS
12080 * window.h (replace_buffer_in_windows): Declare.
12081
9397e56f
MR
120822011-06-11 Martin Rudalics <rudalics@gmx.at>
12083
12084 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
12085 Qclone_number. Remove external declaration of Qdelete_window.
12086 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
12087 code.
640c8776
SM
12088 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
12089 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
12090 (Fother_buffer): Rewrite doc-string. Major rewrite for new
12091 buffer list implementation.
12092 (other_buffer_safely): New function.
12093 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
12094 calls to replace_buffer_in_windows and
12095 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
12096 if allowed.
12097 (record_buffer): Inhibit quitting and rewrite using quittable
12098 functions. Run Qbuffer_list_update_hook if allowed.
12099 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
12100 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
12101 Move switch-to-buffer to window.el.
9397e56f
MR
12102 (bury-buffer): Move to window.el.
12103 (Vbuffer_list_update_hook): New variable.
12104
12105 * lisp.h (other_buffer_safely): Add prototype in buffer.c
12106 section.
12107
12108 * window.h (resize_frame_windows): Move up in code.
12109 (Fwindow_frame): Remove EXFUN.
12110 (replace_buffer_in_all_windows): Remove prototype.
12111 (replace_buffer_in_windows_safely): Add prototype.
12112
12113 * window.c: Declare Qdelete_window static again. Move down
12114 declaration of select_count.
12115 (Fnext_window, Fprevious_window): Rewrite doc-strings.
12116 (Fother_window): Move to window.el.
12117 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
12118 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
12119 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
12120 window.el.
12121 (replace_buffer_in_windows): Implement by calling
12122 Qreplace_buffer_in_windows.
12123 (replace_buffer_in_all_windows): Remove with some functionality
12124 moved into replace_buffer_in_windows_safely.
12125 (replace_buffer_in_windows_safely): New function.
12126 (select_window_norecord, select_frame_norecord): Move in front
12127 of run_window_configuration_change_hook. Remove now obsolete
12128 declarations.
640c8776
SM
12129 (Fset_window_buffer): Rewrite doc-string.
12130 Call Qrecord_window_buffer.
9397e56f
MR
12131 (keys_of_window): Move binding for other-window to window.el.
12132
b50691aa
CY
121332011-06-11 Chong Yidong <cyd@stupidchicken.com>
12134
12135 * dispextern.h (struct image): Replace data member, whose int_val
12136 and ptr_val fields were not used by anything, with a single
12137 lisp_val object.
12138
12139 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
12140 (gif_clear_image, gif_load, imagemagick_load_image)
12141 (gs_clear_image, gs_load): Callers changed.
12142
3f754b86
PE
121432011-06-10 Paul Eggert <eggert@cs.ucla.edu>
12144
cca69397
PE
12145 * buffer.h: Include <time.h>, for time_t.
12146 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
12147
109e28d0
PE
12148 Fix minor problems found by static checking.
12149
60737f02
PE
12150 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
12151
4b66faf3
PE
12152 Make identifiers static if they are not used in other modules.
12153 * data.c (Qcompiled_function, Qframe, Qvector):
12154 * image.c (QimageMagick, Qsvg):
12155 * minibuf.c (Qmetadata):
12156 * window.c (resize_window_check, resize_root_window): Now static.
12157 * window.h (resize_window_check, resize_root_window): Remove decls.
12158
109e28d0
PE
12159 * window.c (window_deletion_count, delete_deletable_window):
12160 Remove; unused.
46a4ce9e
PE
12161 (window_body_lines): Now static.
12162 (Fdelete_other_windows_internal): Mark vars as initialized.
12163 Make sure 'resize_failed' is initialized.
12164 (run_window_configuration_change_hook): Rename local to avoid shadowing.
12165 (resize_window_apply): Remove unused local.
12166 * window.h (delete_deletable_window): Remove decl.
12167
109e28d0 12168 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
12169 (imagemagick_load_image): Fix pointer signedness problem by changing
12170 last arg from unsigned char * to char *. All uses changed.
12171 Also, fix a local for similar reasons.
12172 Remove unused locals. Remove locals to avoid shadowing.
12173 (fn_rsvg_handle_free): Remove; unused.
12174 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 12175 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 12176
3f754b86
PE
12177 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
12178
2547adb1
CY
121792011-06-10 Chong Yidong <cyd@stupidchicken.com>
12180
12181 * image.c (gif_load): Fix omitted cast error introduced by
12182 2011-06-06 change.
12183
2c8e37d4
MR
121842011-06-10 Martin Rudalics <rudalics@gmx.at>
12185
12186 * window.h (resize_proportionally, orig_total_lines)
12187 (orig_top_line): Remove from window structure.
12188 (set_window_height, set_window_width, change_window_heights)
12189 (Fdelete_window): Remove prototypes.
12190 (resize_frame_windows): Remove duplicate declaration.
12191
440a42e3
EZ
121922011-06-10 Eli Zaretskii <eliz@gnu.org>
12193
12194 * window.h (resize_frame_windows, resize_window_check)
12195 (delete_deletable_window, resize_root_window)
12196 (resize_frame_windows): Declare prototypes.
12197
12198 * window.c (resize_window_apply): Make definition be "static" to
12199 match the prototype.
12200
562dd5e9
MR
122012011-06-10 Martin Rudalics <rudalics@gmx.at>
12202
12203 * window.c: Remove declarations of Qwindow_size_fixed,
12204 window_min_size_1, window_min_size_2, window_min_size,
12205 size_window, window_fixed_size_p, enlarge_window, delete_window.
12206 Remove static from declaration of Qdelete_window, it's
12207 temporarily needed by Fbury_buffer.
12208 (replace_window): Don't assign orig_top_line and
12209 orig_total_lines.
12210 (Fdelete_window, delete_window): Remove. Window deletion is
12211 handled by window.el.
640c8776
SM
12212 (window_loop): Remove DELETE_OTHER_WINDOWS case.
12213 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
12214 (Fdelete_other_windows): Remove. Deleting other windows is
12215 handled by window.el.
12216 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
12217 handled in window.el.
12218 (window_min_size_2, window_min_size_1, window_min_size): Remove.
12219 Window minimum sizes are handled in window.el.
12220 (shrink_windows, size_window, set_window_height)
12221 (set_window_width, change_window_heights, window_height)
12222 (window_width, CURBEG, CURSIZE, enlarge_window)
12223 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
12224 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
12225 handled in window.el.
12226 (make_dummy_parent): Rename to make_parent_window and give it a
12227 second argument horflag.
12228 (make_window): Don't set resize_proportionally any more.
12229 (Fsplit_window): Remove. Windows are split in window.el.
12230 (save_restore_action, save_restore_orig_size)
12231 (shrink_window_lowest_first, save_restore_orig_size): Remove.
12232 Resize mini windows in window.el.
12233 (grow_mini_window, shrink_mini_window): Implement by calling
12234 Qresize_root_window_vertically, resize_window_check and
12235 resize_window_apply.
640c8776
SM
12236 (saved_window, Fset_window_configuration, save_window_save):
12237 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
12238 resize_proportionally.
12239 (window_min_height, window_min_width): Move to window.el.
12240 (keys_of_window): Move bindings for delete-other-windows,
12241 split-window, delete-window and enlarge-window to window.el.
12242
12243 * buffer.c: Temporarily extern Qdelete_window.
12244 (Fbury_buffer): Temporarily call Qdelete_window instead of
12245 Fdelete_window (Fbury_buffer will move to window.el soon).
12246
12247 * frame.c (set_menu_bar_lines_1): Remove code handling
12248 orig_top_line and orig_total_lines.
12249
12250 * dispnew.c (adjust_frame_glyphs_initially): Don't use
12251 set_window_height but set heights directly.
12252 (change_frame_size_1): Use resize_frame_windows.
12253
12254 * xdisp.c (init_xdisp): Don't use set_window_height but set
12255 heights directly.
12256
640c8776
SM
12257 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
12258 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
12259 run_window_configuration_change_hook.
12260
12261 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
12262 instead of change_window_heights and run
12263 run_window_configuration_change_hook.
12264
1a13852e
MR
122652011-06-09 Martin Rudalics <rudalics@gmx.at>
12266
12267 * window.c (replace_window): Rename second argument REPLACEMENT to
12268 NEW. New third argument SETFLAG. Rewrite.
12269 (delete_window, make_dummy_parent): Call replace_window with
12270 third argument 1.
12271 (window_list_1): Move down in code.
12272 (run_window_configuration_change_hook): Move set_buffer part
12273 before select_frame_norecord part in order to unwind correctly.
12274 Rename count1 to count.
12275 (recombine_windows, delete_deletable_window, resize_root_window)
12276 (Fdelete_other_windows_internal)
12277 (Frun_window_configuration_change_hook, make_parent_window)
12278 (resize_window_check, resize_window_apply, Fresize_window_apply)
12279 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
12280 (Fdelete_window_internal, Fresize_mini_window_internal):
12281 New functions.
1a13852e
MR
12282 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
12283
f3d1777e
MR
122842011-06-08 Martin Rudalics <rudalics@gmx.at>
12285
496e208e
MR
12286 * window.h (window): Add some new members to window structure -
12287 normal_lines, normal_cols, new_total, new_normal, clone_number,
12288 splits, nest, prev_buffers, next_buffers.
12289 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 12290 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 12291
f3d1777e
MR
12292 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
12293 Remove.
496e208e
MR
12294 (make_dummy_parent): Set new members of windows structure.
12295 (make_window): Move down in code. Handle new members of window
12296 structure.
12297 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
12298 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
12299 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
12300 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
12301 (Fset_window_next_buffers, Fset_window_clone_number):
12302 New functions.
496e208e
MR
12303 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
12304 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
12305 Doc-string fixes.
12306 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
12307 Argument WINDOW can be now internal window too.
12308 (Fwindow_use_time): Move up in code.
12309 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
12310 Rewrite doc-string.
12311 (Fset_window_configuration, saved_window)
12312 (Fcurrent_window_configuration, save_window_save): Handle new
12313 members of window structure.
b9e809c2
MR
12314 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
12315 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
12316 (syms_of_window): New Lisp objects Qrecord_window_buffer,
12317 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
12318 Qget_mru_window, Qresize_root_window,
12319 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
12320 Qauto_buffer_name; staticpro them.
f3d1777e 12321
abde8f8c
MR
123222011-06-07 Martin Rudalics <rudalics@gmx.at>
12323
12324 * window.c (Fwindow_total_size, Fwindow_left_column)
12325 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
12326 (Fwindow_list_1): New functions.
12327 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
12328 (Fwindow_width, Fscroll_left, Fscroll_right):
12329 Use window_body_cols instead of window_box_text_cols.
12330 (delete_window, Fset_window_configuration):
12331 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
12332 (delete_all_subwindows): Take a window as argument and not a
12333 structure. Rewrite.
190b47e6
MR
12334 (window_loop): Remove handling of GET_LRU_WINDOW and
12335 GET_LARGEST_WINDOW.
12336 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
12337
12338 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
12339 window_box_text_cols. delete_all_subwindows now takes a
12340 Lisp_Object as argument.
abde8f8c 12341
640c8776
SM
12342 * indent.c (compute_motion, Fcompute_motion):
12343 Use window_body_cols instead of window_box_text_cols.
abde8f8c 12344
fa8a67e6
MR
12345 * frame.c (delete_frame): Call delete_all_subwindows with root
12346 window as argument.
12347
a54e3482
DC
123482011-06-07 Daniel Colascione <dan.colascione@gmail.com>
12349
12350 * fns.c (Fputhash): Document return value.
12351
60002bf5
CY
123522011-06-06 Chong Yidong <cyd@stupidchicken.com>
12353
12354 * image.c (gif_load): Implement gif89a spec "no disposal" method.
12355
0c671da6 123562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 12357
b862a52a 12358 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 12359
be44ca6c
PE
12360 Check for overflow when converting integer to cons and back.
12361 * charset.c (Fdefine_charset_internal, Fdecode_char):
12362 Use cons_to_unsigned to catch overflow.
12363 (Fencode_char): Use INTEGER_TO_CONS.
12364 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
12365 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
12366 * data.c (long_to_cons, cons_to_long): Remove.
12367 (cons_to_unsigned, cons_to_signed): New functions.
12368 These signal an error for invalid or out-of-range values.
12369 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
12370 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
12371 * font.c (Ffont_variation_glyphs):
12372 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
12373 * lisp.h: Include <intprops.h>.
12374 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
12375 (cons_to_signed, cons_to_unsigned): New decls.
12376 (long_to_cons, cons_to_long): Remove decls.
12377 * undo.c (record_first_change): Use INTEGER_TO_CONS.
12378 (Fprimitive_undo): Use CONS_TO_INTEGER.
12379 * xfns.c (Fx_window_property): Likewise.
12380 * xselect.c: Include <limits.h>.
12381 (x_own_selection, selection_data_to_lisp_data):
12382 Use INTEGER_TO_CONS.
12383 (x_handle_selection_request, x_handle_selection_clear)
12384 (x_get_foreign_selection, Fx_disown_selection_internal)
12385 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
12386 (lisp_data_to_selection_data): Use cons_to_unsigned.
12387 (x_fill_property_data): Use cons_to_signed.
12388 Report values out of range.
12389
d1f3d2af
PE
12390 Check for buffer and string overflow more precisely.
12391 * buffer.h (BUF_BYTES_MAX): New macro.
12392 * lisp.h (STRING_BYTES_MAX): New macro.
12393 * alloc.c (Fmake_string):
12394 * character.c (string_escape_byte8):
12395 * coding.c (coding_alloc_by_realloc):
12396 * doprnt.c (doprnt):
12397 * editfns.c (Fformat):
12398 * eval.c (verror):
12399 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
12400 since they may not be the same number.
12401 * editfns.c (Finsert_char):
12402 * fileio.c (Finsert_file_contents):
12403 Likewise for BUF_BYTES_MAX.
12404
dd52fcea
PE
12405 * image.c: Use ptrdiff_t, not int, for sizes.
12406 (slurp_file): Switch from int to ptrdiff_t.
12407 All uses changed.
12408 (slurp_file): Check that file size fits in both size_t (for
12409 malloc) and ptrdiff_t (for sanity and safety).
12410
7f9bbdbb
PE
12411 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
12412 if b->modtime has its maximal value.
12413
dfe18f82
PE
12414 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
12415
84acfcf0
PE
12416 Don't assume time_t can fit into int.
12417 * buffer.h (struct buffer.modtime): Now time_t, not int.
12418 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
12419 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
12420
ccd9a01a
PE
12421 Minor fixes for signed vs unsigned integers.
12422 * character.h (MAYBE_UNIFY_CHAR):
12423 * charset.c (maybe_unify_char):
12424 * keyboard.c (read_char, reorder_modifiers):
12425 XINT -> XFASTINT, since the integer must be nonnegative.
12426 * ftfont.c (ftfont_spec_pattern):
12427 * keymap.c (access_keymap, silly_event_symbol_error):
12428 XUINT -> XFASTINT, since the integer must be nonnegative.
12429 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
12430 since it makes no difference and we prefer signed.
12431 * keyboard.c (record_char): Use XUINT when all the neighbors do.
12432 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
12433 nonnegative.
12434
d6d100dd
SM
124352011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
12436
12437 * window.h (Fwindow_frame): Declare.
12438
2b6148e4
PE
124392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12440
12441 * alloc.c: Simplify handling of large-request failures (Bug#8800).
12442 (SPARE_MEMORY): Always define.
12443 (LARGE_REQUEST): Remove.
12444 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
12445
f230ecc9
MR
124462011-06-06 Martin Rudalics <rudalics@gmx.at>
12447
727e958e
MR
12448 * lisp.h: Move EXFUNS for Fframe_root_window,
12449 Fframe_first_window and Fset_frame_selected_window to window.h.
12450
12451 * window.h: Move EXFUNS for Fframe_root_window,
12452 Fframe_first_window and Fset_frame_selected_window here from
12453 lisp.h.
12454
12455 * frame.c (Fwindow_frame, Fframe_first_window)
12456 (Fframe_root_window, Fframe_selected_window)
12457 (Fset_frame_selected_window): Move to window.c.
12458 (Factive_minibuffer_window): Move to minibuf.c.
12459 (Fother_visible_frames_p): New function.
12460
12461 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
12462
f230ecc9
MR
12463 * window.c (decode_window, decode_any_window): Move up in code.
12464 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
12465 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
12466 (Fwindow_buffer): Move up and rewrite doc-string.
12467 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
12468 (Fwindow_prev): New functions.
727e958e
MR
12469 (Fwindow_frame): Move here from frame.c. Accept any window as
12470 argument.
12471 (Fframe_root_window, Fframe_first_window)
12472 (Fframe_selected_window): Move here from frame.c. Accept frame
12473 or arbitrary window as argument. Update doc-strings.
12474 (Fminibuffer_window): Move up in code.
12475 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
12476 (Fset_frame_selected_window): Move here from frame.c.
12477 Marginal rewrite.
727e958e
MR
12478 (Fselected_window, select_window, Fselect_window): Move up in
12479 code. Minor doc-string fixes.
f230ecc9 12480
4d09bcf6
PE
124812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12482
12483 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
12484 Do not assume that spare memory exists; that assumption is valid
12485 only if SYSTEM_MALLOC.
12486 (LARGE_REQUEST): New macro, so that the issue of large requests
12487 is separated from the issue of spare memory.
12488
810928a2
AS
124892011-06-05 Andreas Schwab <schwab@linux-m68k.org>
12490
172418ad
AS
12491 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
12492 format. (Bug#8806)
12493
43f862f7
AS
12494 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
12495
810928a2
AS
12496 * xfns.c (x_set_scroll_bar_default_width): Move declarations
12497 before statements.
12498
a059fe24
JD
124992011-06-05 Jan Djärv <jan.h.d@swipnet.se>
12500
12501 * gtkutil.c (xg_get_default_scrollbar_width): New function.
12502
12503 * gtkutil.h: Declare xg_get_default_scrollbar_width.
12504
12505 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
12506 min width by calling x_set_scroll_bar_default_width (Bug#8505).
12507
989bf368
JB
125082011-06-05 Juanma Barranquero <lekktu@gmail.com>
12509
12510 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
12511
4b80f674
CY
125122011-06-04 Chong Yidong <cyd@stupidchicken.com>
12513
12514 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
12515 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
12516 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
12517 New error handlers.
4b80f674
CY
12518 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
12519 Obey Vx_select_enable_clipboard_manager. Catch errors in
12520 x_clipboard_manager_save (Bug#8779).
12521 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 12522 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 12523
99a33b77 125242011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
12525
12526 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
12527
99a33b77 125282011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
12529
12530 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
12531 in the current matrix if keep_current_p is non-zero.
12532
8264569d
EZ
125332011-06-04 Eli Zaretskii <eliz@gnu.org>
12534
12535 * bidi.c (bidi_level_of_next_char): Fix last change.
12536
57f97249
EZ
125372011-06-03 Eli Zaretskii <eliz@gnu.org>
12538
fec2107c 12539 Support bidi reordering of text covered by display properties.
57f97249 12540
fec2107c
EZ
12541 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
12542 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
12543 (bidi_cache_search, bidi_cache_iterator_state)
12544 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
12545 (bidi_level_of_next_char, bidi_move_to_visually_next):
12546 Support character positions inside a run of characters covered by a
fec2107c
EZ
12547 display string.
12548 (bidi_paragraph_init, bidi_resolve_explicit_1)
12549 (bidi_level_of_next_char): Call bidi_fetch_char and
12550 bidi_fetch_char_advance instead of FETCH_CHAR and
12551 FETCH_CHAR_ADVANCE.
12552 (bidi_init_it): Initialize new members.
12553 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
12554 definitions.
12555 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
12556 instead of using explicit *_CHAR codes.
d6d100dd
SM
12557 (bidi_resolve_explicit, bidi_resolve_weak):
12558 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
12559 bidirectional text is supported only in multibyte buffers.
12560 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
12561 it to initialize the frame_window_p member of struct bidi_it.
12562 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
12563 (bidi_resolve_explicit, bidi_resolve_weak)
12564 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
12565 bidi_it->nchars is non-positive.
12566 (bidi_level_of_next_char): Don't try to lookup the cache for the
12567 next/previous character if nothing is cached there yet, or if we
12568 were just reseat()'ed to a new position.
c40e2fb2 12569
0e14fe90
EZ
12570 * xdisp.c (set_cursor_from_row): Set start and stop points
12571 according to the row's direction when priming the loop that looks
12572 for the glyph on which to display cursor.
12573 (single_display_spec_intangible_p): Function deleted.
12574 (display_prop_intangible_p): Reimplement to call
12575 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
12576 Accept 3 additional arguments needed by handle_display_spec.
12577 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
12578 values: lists, `(when COND...)' forms, etc.
12579 (single_display_spec_string_p): Support property values that are
12580 lists with the argument STRING its top-level element.
12581 (display_prop_string_p): Fix the condition for processing a
12582 property that is a list to be consistent with handle_display_spec.
fec2107c 12583 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
12584 last portion of handle_display_prop.
12585 (compute_display_string_pos): Accept additional argument
12586 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
12587 value of a `display' property is a "replacing spec".
12588 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
12589 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
12590 the display property, but just return a value indicating whether
12591 the display property will replace the characters it covers.
12592 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
12593 frame_window_p members of struct bidi_it.
d6d100dd
SM
12594 (compute_display_string_pos, compute_display_string_end):
12595 New functions.
fec2107c
EZ
12596 (push_it): Accept second argument POSITION, where pop_it should
12597 jump to continue iteration.
12598 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 12599
fec2107c
EZ
12600 * keyboard.c (adjust_point_for_property): Adjust the call to
12601 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
12602
12603 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
12604 (bidi_init_it): Update prototypes.
12605 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
12606 (compute_display_string_pos, compute_display_string_end):
12607 Declare prototypes.
fec2107c
EZ
12608 (struct bidi_it): New members nchars and disp_pos. ch_len is now
12609 EMACS_INT.
fc6f18ce 12610
40087514 126112011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 12612
57f53182
PE
12613 Malloc failure behavior now depends on size of allocation.
12614 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
12615 * lisp.h: Change signatures accordingly.
12616 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
12617 All callers changed. (Bug#8762)
12618
12619 * gnutls.c: Use Emacs's memory allocators.
12620 Without this change, the gnutls library would invoke malloc etc.
12621 directly, which causes problems on non-SYNC_INPUT hosts, and which
12622 runs afoul of improving memory_full behavior. (Bug#8761)
12623 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
12624 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
12625 xfree instead of the default malloc, realloc, free.
12626 (Fgnutls_boot): No need to check for memory allocation failure,
12627 since xmalloc does that for us.
12628
ac32cd99 12629 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
12630 * category.c (hash_get_category_set):
12631 * ccl.c (ccl_driver):
12632 * charset.c (Fdefine_charset_internal):
12633 * charset.h (struct charset.hash_index):
12634 * composite.c (get_composition_id, gstring_lookup_cache)
12635 (composition_gstring_put_cache):
12636 * composite.h (struct composition.hash_index):
12637 * dispextern.h (struct image.hash):
12638 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
12639 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
12640 (hashfn_equal, hashfn_user_defined, make_hash_table)
12641 (maybe_resize_hash_table, hash_lookup, hash_put)
12642 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
12643 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
12644 (Fsxhash, Fgethash, Fputhash, Fmaphash):
12645 * image.c (make_image, search_image_cache, lookup_image)
12646 (xpm_put_color_table_h):
12647 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 12648 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 12649 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 12650 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
12651 * alloc.c (allocate_vectorlike):
12652 Check for overflow in vector size calculations.
12653 * ccl.c (ccl_driver):
12654 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
12655 * fns.c, image.c: Remove unnecessary static decls that would otherwise
12656 need to be updated by these changes.
40087514
PE
12657 * fns.c (make_hash_table, maybe_resize_hash_table):
12658 Check for integer overflow with large hash tables.
0de4bb68
PE
12659 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
12660 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
12661 (SXHASH_REDUCE): New macro.
12662 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
12663 Use it instead of discarding useful hash info with large hash values.
12664 (sxhash_float): New function.
12665 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
12666 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
12667 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
12668 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
12669 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
12670 Adjust signatures to match updated version of code.
12671 (consing_since_gc): Now EMACS_INT, since a single hash table can
12672 use more than INT_MAX bytes.
12673
698d32e2
DN
126742011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
12675
12676 Make it possible to build with GCC-4.6+ -O2 -flto.
12677
12678 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
12679
fd6fa53f
SM
126802011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
12681
12682 * minibuf.c (get_minibuffer, read_minibuf_unwind):
12683 Call minibuffer-inactive-mode.
12684
864db017
JB
126852011-05-31 Juanma Barranquero <lekktu@gmail.com>
12686
12687 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
12688 Update dependencies.
12689
2ad0baf4
DN
126902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12691
12692 * data.c (init_data): Remove code for UTS, this system is not
12693 supported anymore.
12694
4fcc2638
DN
126952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12696
12697 Don't force ./temacs to start in terminal mode.
12698
12699 * frame.c (make_initial_frame): Initialize faces in all cases, not
12700 only when CANNOT_DUMP is defined.
12701 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
12702
c56e0fd5
DN
127032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12704
12705 * dispnew.c (add_window_display_history): Use const for the string
12706 pointer. Remove declaration, not needed.
12707
333d54da 127082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 12709
55d4c1b2 12710 Use 'inline', not 'INLINE'.
333d54da 12711 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
12712 * alloc.c, fontset.c (INLINE): Remove.
12713 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
12714 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
12715 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
12716 * gmalloc.c (register_heapinfo): Use inline unconditionally.
12717 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
12718
738db178
DN
127192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12720
12721 Make it possible to run ./temacs.
12722
12723 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
12724 syms_of_callproc does the same thing. Remove test for
12725 "initialized", do it in the caller.
12726 * emacs.c (main): Avoid calling set_initial_environment when dumping.
12727
620c53a6
SM
127282011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
12729
12730 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
12731 (read_minibuf): Use get_minibuffer.
12732 (syms_of_minibuf): Use DEFSYM.
12733 (Qmetadata): New var.
12734 * data.c (Qbuffer): Don't make it static.
12735 (syms_of_data): Use DEFSYM.
12736
e003a292
PE
127372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
12738
12739 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
12740 (CCL_CODE_MIN): New macro.
12741
ed008a6d
PE
127422011-05-30 Paul Eggert <eggert@cs.ucla.edu>
12743
3687c2ef
PE
12744 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
12745
ed008a6d
PE
12746 * eval.c (Qdebug): Now static.
12747 * lisp.h (Qdebug): Remove decl. This reverts a part of the
12748 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
12749 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
12750
d66c4c7c
CY
127512011-05-29 Chong Yidong <cyd@stupidchicken.com>
12752
12753 * image.c: Various fixes to ImageMagick code comments.
12754 (Fimagemagick_types): Doc fix.
12755
5fbc2025
PE
127562011-05-29 Paul Eggert <eggert@cs.ucla.edu>
12757
0196f88a
PE
12758 Minor fixes prompted by GCC 4.6.0 warnings.
12759
12760 * xselect.c (converted_selections, conversion_fail_tag): Now static.
12761
5fbc2025
PE
12762 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
12763 (x_clipboard_manager_save_all): Move extern decl to ...
12764 * xterm.h: ... here, so that it can be checked for consistency.
12765
1dd3c2d9
CY
127662011-05-29 Chong Yidong <cyd@stupidchicken.com>
12767
12768 * xselect.c (x_clipboard_manager_save_frame)
12769 (x_clipboard_manager_save_all): New functions.
12770 (Fx_clipboard_manager_save): Lisp function deleted.
12771
12772 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
12773 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
12774
12775 * xterm.h: Update prototype.
12776
5ba6571d
WX
127772011-05-28 William Xu <william.xwl@gmail.com>
12778
12779 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
12780 exiting (Bug#8239).
12781
3eaff834
JM
127822011-05-28 Jim Meyering <meyering@redhat.com>
12783
e1900994 12784 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
12785 * fns.c (to_uchar): Define.
12786 (crypto_hash_function): Use it to convert some newly-signed
12787 variables to unsigned, to avoid sign-extension bugs. For example,
12788 without this change, (md5 "truc") would evaluate to
12789 45723a2aff78ff4fff7fff1114760e62 rather than the expected
12790 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 12791 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 12792
0f6990a7
PE
127932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12794
12795 Integer overflow fixes.
c8a9ca5a 12796
08686060
PE
12797 * dbusbind.c: Serial number integer overflow fixes.
12798 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
12799 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
12800 to hold a serial number that is too large for a fixnum.
12801 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12802 Check for serial numbers out of range. Decode any serial number
59568bf0 12803 that was so large that it became a float. (Bug#8722)
08686060 12804
2d1fc3c7
PE
12805 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
12806 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12807 Use XFASTINT rather than XUINT when numbers are nonnegative.
12808 (xd_append_arg, Fdbus_method_return_internal):
12809 (Fdbus_method_error_internal): Likewise. Also, for unsigned
12810 arguments, check that Lisp number is nonnegative, rather than
59568bf0 12811 silently wrapping negative numbers around. (Bug#8722)
30217ff0 12812 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 12813 (Bug#8722)
2d1fc3c7 12814
c8a9ca5a
PE
12815 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
12816
519e1d69
PE
12817 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
12818
6df6ae42 12819 ccl: Add integer overflow checks.
30569699
PE
12820 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
12821 (IN_INT_RANGE): New macros.
12822 (ccl_driver): Use them to check for integer overflow when
12823 decoding a CCL program. Many of the new checks are whether XINT (x)
12824 fits in int; it doesn't always, on 64-bit hosts. The new version
12825 doesn't catch all possible integer overflows, but it's an
847044ea 12826 improvement. (Bug#8719)
30569699 12827
c11285dc
PE
12828 * alloc.c (make_event_array): Use XINT, not XUINT.
12829 There's no need for unsigned here.
12830
fdccd48e
PE
12831 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
12832 This follows up to the 2011-05-06 change that substituted uintptr_t
12833 for EMACS_INT. This case wasn't caught back then.
12834
37910ab2
PE
12835 Rework Fformat to avoid integer overflow issues.
12836 * editfns.c: Include <float.h> unconditionally, as it's everywhere
12837 now (part of C89). Include <verify.h>.
12838 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
12839 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
12840 (Fformat): Avoid the prepass trying to compute sizes; it was only
12841 approximate and thus did not catch overflow reliably. Instead, walk
12842 through the format just once, formatting and computing sizes as we go,
12843 checking for integer overflow at every step, and allocating a larger
12844 buffer as needed. Keep track separately whether the format is
12845 multibyte. Keep only the most-recently calculated precision, rather
12846 than them all. Record whether each argument has been converted to
12847 string. Use EMACS_INT, not int, for byte and char and arg counts.
12848 Support field widths and precisions larger than INT_MAX. Avoid
12849 sprintf's undefined behavior with conversion specifications such as %#d
12850 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
12851 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
12852 formatting out-of-range floating point numbers with int
9173deec 12853 formats. (Bug#8668)
37910ab2 12854
2e6578fb
PE
12855 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
12856
0ae6bdee
PE
12857 * data.c: Avoid integer truncation in expressions involving floats.
12858 * data.c: Include <intprops.h>.
12859 (arith_driver): When there's an integer overflow in an expression
12860 involving floating point, convert the integers to floating point
12861 so that the resulting value does not suffer from catastrophic
12862 integer truncation. For example, on a 64-bit host (* 4
12863 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
12864 Do not rely on undefined behavior after integer overflow.
12865
de883a70
PE
12866 merge count_size_as_multibyte, parse_str_to_multibyte
12867 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 12868 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
12869 Check for integer overflow.
12870 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
12871 since it's now a duplicate of the other. This is more of
12872 a character than a buffer op, so better that it's in character.c.
12873 * fns.c, print.c: Adjust to above changes.
12874
2ff916cb
PE
128752011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
12876
12877 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
12878
f1b54466
PE
128792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12880
fb1ac845
PE
12881 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12882 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
12883 (x_clipboard_manager_save): Now static.
12884 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
12885
f1b54466
PE
12886 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12887 (crypto_hash_function): Now static.
12888 Fix pointer signedness problems. Avoid unnecessary initializations.
12889
a9f737ee
CY
128902011-05-27 Chong Yidong <cyd@stupidchicken.com>
12891
12892 * termhooks.h (Vselection_alist): Make it terminal-local.
12893
12894 * terminal.c (create_terminal): Initialize it.
12895
12896 * xselect.c: Support for clipboard managers.
12897 (Vselection_alist): Move to termhooks.h as terminal-local var.
12898 (LOCAL_SELECTION): New macro.
12899 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
12900 (symbol_to_x_atom): Remove gratuitous arg.
12901 (x_handle_selection_request, lisp_data_to_selection_data)
12902 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
12903 (x_own_selection, x_get_local_selection, x_convert_selection):
12904 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
12905 (some_frame_on_display): Delete unused function.
12906 (Fx_own_selection_internal, Fx_get_selection_internal)
12907 (Fx_disown_selection_internal, Fx_selection_owner_p)
12908 (Fx_selection_exists_p): New optional frame arg.
12909 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12910 (x_handle_selection_clear): Don't treat other terminals with the
12911 same keyboard specially. Use the terminal-local Vselection_alist.
12912 (x_clear_frame_selections): Use Frun_hook_with_args.
12913
12914 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12915
12916 * xterm.h: Add support for those atoms.
12917
e067f0c1
CY
129182011-05-26 Chong Yidong <cyd@stupidchicken.com>
12919
12920 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12921 (converted_selections, conversion_fail_tag): New global variables.
12922 (x_selection_request_lisp_error): Free the above.
12923 (x_get_local_selection): Remove unnecessary code.
12924 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12925 of converted selections stored in converted_selections.
12926 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12927 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12928 (x_convert_selection): New function.
12929 (x_handle_selection_event): Simplify.
12930 (x_get_foreign_selection): Don't ignore incoming requests while
12931 waiting for an answer; this will fail when we implement
12932 SAVE_TARGETS, and seems unnecessary anyway.
12933 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12934 (Vx_sent_selection_functions): Doc fix.
12935
0f4aebc0
LL
129362011-05-26 Leo Liu <sdl.web@gmail.com>
12937
12938 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12939
e61124cd
YM
129402011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12941
12942 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12943
12944 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12945 for fringe update if it has periodic bitmap.
ac389d0c 12946 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12947 and fringe_bitmap_periodic_p.
12948
12949 * fringe.c (get_fringe_bitmap_data): New function.
12950 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12951 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12952 row. Mark glyph row for fringe update if periodicity changed.
12953
12954 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12955 for fringe update unless it has periodic bitmap.
12956
f16d9837
KH
129572011-05-25 Kenichi Handa <handa@m17n.org>
12958
12959 * xdisp.c (get_next_display_element): Set correct it->face_id for
12960 a static composition.
12961
e1b90ef6
LL
129622011-05-24 Leo Liu <sdl.web@gmail.com>
12963
12964 * deps.mk (fns.o):
12965 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12966
12967 * fns.c (crypto_hash_function, Fsha1): New function.
12968 (Fmd5): Use crypto_hash_function.
12969 (syms_of_fns): Add Ssha1.
12970
7400048f
PE
129712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12972
12973 * gnutls.c: Remove unused macros.
12974 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12975 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12976 Remove macros that are defined and never used.
12977 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12978
abb71cf4
CY
129792011-05-22 Chong Yidong <cyd@stupidchicken.com>
12980
12981 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12982 (Fx_get_selection_internal): Minor cleanup.
12983 (Fx_own_selection_internal): Rename arguments for consistency with
12984 select.el.
12985
6307db39
PE
129862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12987
12988 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12989
f3d4e0a4
CY
129902011-05-22 Chong Yidong <cyd@stupidchicken.com>
12991
12992 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12993
4d8ade89
YM
129942011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12995
12996 * dispnew.c (scrolling_window): Don't exclude the case that the
12997 last enabled row in the desired matrix touches the bottom boundary.
12998
32078c8d
GM
129992011-05-21 Glenn Morris <rgm@gnu.org>
13000
13001 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
13002 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
13003 and add some more files.
32078c8d 13004
7285dc67
EZ
130052011-05-20 Eli Zaretskii <eliz@gnu.org>
13006
13007 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
13008 report_file_error introduced by the change from 2011-05-07.
13009
89d1bd22
PE
130102011-05-20 Paul Eggert <eggert@cs.ucla.edu>
13011
13012 * systime.h (Time): Define only if emacs is defined.
13013 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
13014 where the include path doesn't have X11/X.h by default. See
13015 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
13016
cd394be1 130172011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
13018
13019 * composite.c (find_automatic_composition): Fix previous change.
13020
b9704ad9
GM
130212011-05-20 Glenn Morris <rgm@gnu.org>
13022
13023 * lisp.mk: New file, split from Makefile.in.
13024 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
13025 (shortlisp): Remove.
13026 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
13027
4a720484
GM
130282011-05-19 Glenn Morris <rgm@gnu.org>
13029
13030 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
13031 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
13032 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
13033 (lisp): Set the order to that of loadup.el.
13034 (shortlisp): Make it a copy of $lisp.
13035 (SOME_MACHINE_LISP): Remove.
13036 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
13037 Use just $shortlisp, not $SOME_MACHINE_LISP too.
13038
a28d4396
KH
130392011-05-18 Kenichi Handa <handa@m17n.org>
13040
13041 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
13042 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
13043 (find_automatic_composition): Mostly rewrite for efficiency.
13044
a2b1fa8e
JB
130452011-05-18 Juanma Barranquero <lekktu@gmail.com>
13046
13047 * makefile.w32-in: Update dependencies.
13048
8e1f5610
CS
130492011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
13050
13051 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 13052 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 13053
7025ee00 130542011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 13055
cdfa6eab
PE
13056 Fix some integer overflow issues, such as string length overflow.
13057
06d6db33
PE
13058 * insdel.c (count_size_as_multibyte): Check for string overflow.
13059
2b4560a8
PE
13060 * character.c (lisp_string_width): Check for string overflow.
13061 Use EMACS_INT, not int, for string indexes and lengths; in
13062 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
13063 the resulting string length overflows an EMACS_INT; instead,
13064 report a string overflow if no precision given. When checking for
13065 precision exhaustion, use a check that cannot possibly have
13066 integer overflow. (Bug#8675)
13067 * character.h (lisp_string_width): Adjust to new signature.
13068
cb93f9be
PE
13069 * alloc.c (string_overflow): New function.
13070 (Fmake_string): Use it. This doesn't change behavior, but saves
13071 a few bytes and will simplify future changes.
13072 * character.c (string_escape_byte8): Likewise.
13073 * lisp.h (string_overflow): New decl.
13074
1a1f3366
PE
13075 Fixups, following up to the user-interface timestamp change.
13076 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
13077 for UI timestamps, instead of unsigned long.
9fbd6841
PE
13078 * msdos.c (mouse_get_pos): Likewise.
13079 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
13080 * w32gui.h (Time): Define by including "systime.h" rather than by
13081 declaring it ourselves. (Bug#8664)
13082
d4e3e4d3
PE
13083 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
13084 * image.c (clear_image_cache): Likewise.
13085
f6a24d19
PE
13086 * term.c (term_mouse_position): Don't assume time_t wraparound.
13087
08dc5ae6
PE
13088 Be more systematic about user-interface timestamps.
13089 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
13090 and sometimes 'EMACS_UINT', to represent these timestamps.
13091 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
13092 This makes the code easier to follow, and makes it easier to catch
13093 integer overflow bugs such as Bug#8664.
13094 * frame.c (Fmouse_position, Fmouse_pixel_position):
13095 Use Time, not unsigned long, for user-interface timestamps.
13096 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
13097 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
13098 * keyboard.h (last_event_timestamp): Likewise.
13099 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
13100 * menu.h (xmenu_show): Likewise.
13101 * term.c (term_mouse_position): Likewise.
13102 * termhooks.h (struct input_event.timestamp): Likewise.
13103 (struct terminal.mouse_position_hook): Likewise.
13104 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
13105 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
13106 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
13107 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
13108 what it was before.
13109 * menu.h, termhooks.h: Include "systime.h", for Time.
13110
8e55734a
PE
13111 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
13112 Don't assume that the difference between two unsigned long values
13113 can fit into an integer. At this point, we know button_down_time
13114 <= event->timestamp, so the difference must be nonnegative, so
13115 there's no need to cast the result if double-click-time is
13116 nonnegative, as it should be; check that it's nonnegative, just in
13117 case. This bug is triggered when events are more than 2**31 ms
86db42d2 13118 apart (about 25 days). (Bug#8664)
8e55734a 13119
841f1b75 13120 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 13121 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 13122
3e26f69c
PE
13123 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
13124 that always fit in int. Use a sentinel instead of a counter, to
13125 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
13126 * frame.h (struct frame): Use int for menu_bar_items_used
13127 instead of EMACS_INT, since it always fits in int.
3e26f69c 13128
5cc152c0
PE
13129 * menu.c (grow_menu_items): Check for int overflow.
13130
d89eb65e
PE
13131 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
13132
5235bd3e
PE
13133 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
13134 Before, the code was not consistent. These values cannot exceed
13135 2**31 - 1 so there's no need to make them unsigned.
13136 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
13137 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
13138 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
13139 as modifiers.
13140 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
13141
bc827e23
PE
13142 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
13143 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
13144 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
13145 presumably because the widths might not match.
13146
78eb494e
PE
13147 * window.c (size_window): Avoid needless test at loop start.
13148
04f2d78b
CB
131492011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
13150
13151 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
13152
d2fc7e3d 131532011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
13154
13155 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
13156
d2fc7e3d 131572011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
13158
13159 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
13160 `width' to `bar_area_x' and `bar_area_width', respectively.
13161 (x_scroll_run): Take account of fringe background extension.
13162
04f2d78b
CB
13163 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
13164 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
13165 `bar_area_width', respectively.
13166 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
13167 background extension.
13168
79b70037
GM
131692011-05-10 Jim Meyering <meyering@redhat.com>
13170
13171 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
13172
2f142cc5
JB
131732011-05-10 Juanma Barranquero <lekktu@gmail.com>
13174
13175 * image.c (Finit_image_library): Return t for built-in image types,
13176 like pbm and xbm. (Bug#8640)
13177
57679c86
AS
131782011-05-09 Andreas Schwab <schwab@linux-m68k.org>
13179
13180 * w32menu.c (set_frame_menubar): Fix submenu allocation.
13181
888c9e86
EZ
131822011-05-07 Eli Zaretskii <eliz@gnu.org>
13183
b0512a1d
EZ
13184 * w32console.c (Fset_screen_color): Doc fix.
13185 (Fget_screen_color): New function.
13186 (syms_of_ntterm): Defsubr it.
13187
7285dc67
EZ
13188 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
13189 unlink the temporary file if Fcall_process didn't create it in the
13190 first place.
13191 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
13192 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
13193 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
13194 cue to call_process_cleanup not to close that handle.
13195
4d3fcc8e
BK
131962011-05-07 Ben Key <bkey76@gmail.com>
13197
13198 * makefile.w32-in: The bootstrap-temacs rule now makes use of
13199 one of two shell specific rules, either bootstrap-temacs-CMD or
13200 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
13201 to the previous implementation of the bootstrap-temacs rule.
13202 The bootstrap-temacs-CMD rule is similar to the previous
13203 implementation of the bootstrap-temacs rule except that it
13204 makes use of the ESC_CFLAGS variable instead of the CFLAGS
13205 variable.
13206
13207 These changes, along with some changes to nt/configure.bat,
13208 nt/gmake.defs, and nt/nmake.defs, are required to extend my
13209 earlier fix to add support for --cflags and --ldflags options
13210 that include quotes so that it works whether make uses cmd or
13211 sh as the shell.
13212
b4289b64
MA
132132011-05-06 Michael Albinus <michael.albinus@gmx.de>
13214
13215 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
13216 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
13217 is a constant.
13218 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
13219 a string. Handle both cases.
13220 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
13221 (Fdbus_register_method): Use Qinvalid_function.
13222
af4c0e28
JB
132232011-05-06 Juanma Barranquero <lekktu@gmail.com>
13224
13225 * makefile.w32-in: Update dependencies.
13226 (LISP_H): Add inttypes.h and stdin.h.
13227 (PROCESS_H): Add unistd.h.
13228
c51453d9
EZ
132292011-05-06 Eli Zaretskii <eliz@gnu.org>
13230
13231 * lread.c: Include limits.h (fixes the MS-Windows build broken by
13232 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
13233
8ff0ac3c 132342011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 13235
4c4b566b
PE
13236 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
13237
aab2b9b5
PE
13238 * term.c (vfatal): Remove stray call to va_end.
13239 It's not needed and the C Standard doesn't allow it here anyway.
13240
c378da0b
PE
13241 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
13242 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
13243
288b08c7
PE
13244 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
13245 bytes.
13246
e3601888
PE
13247 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
13248
db6c0e74
PE
13249 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
13250
dd5963ea
PE
13251 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
13252
88c9450f
PE
13253 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
13254
2f9442b8
PE
13255 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
13256
c032b5f8
PE
13257 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
13258 * charset.c (Fdefine_charset_internal): Don't initialize
13259 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 13260 32-bit int (Bug#8600).
a108c10b
PE
13261
13262 * lread.c (read_integer): Be more consistent with string-to-number.
13263 Use string_to_number to do the actual conversion; this avoids
13264 rounding errors and fixes some other screwups. Without this fix,
13265 for example, #x1fffffffffffffff was misread as -2305843009213693952.
13266 (digit_to_number): Move earlier, for benefit of read_integer.
13267 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 13268 not a digit in any supported base. (Bug#8602)
a108c10b 13269
ad5f9eea
PE
13270 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
13271
aec1708a
PE
13272 * dispnew.c (scrolling_window): Return 1 if we scrolled,
13273 to match comment at start of function. This also removes a
13274 GCC warning about overflow in a 32+64-bit port.
13275
47be4ab5
PE
13276 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
13277
371cac43
PE
13278 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
13279 Reported by Stefan Monnier in
13280 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
13281 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13282 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 13283
d01a7826
PE
13284 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
13285 (EMACS_UINTPTR): Likewise, with uintptr_t.
13286
7fd47d5c
PE
13287 * lisp.h: Prefer 64-bit EMACS_INT if available.
13288 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
13289 on 32-bit hosts that have 64-bit int, so that they can access
13290 large files.
122b0c86
PE
13291 However, temporarily disable this change unless the temporary
13292 symbol WIDE_EMACS_INT is defined.
7fd47d5c 13293
8727937b
PE
13294 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
13295
8ac068ac
PE
13296 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
13297 This removes an assumption that EMACS_INT and long are the same
13298 width as pointers. The assumption is true for Emacs porting targets
13299 now, but we want to make other targets possible.
13300 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
13301 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
13302 In the rest of the code, change types of integers that hold casted
13303 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
13304 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
13305 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
13306 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
13307 No need to cast type when ORing.
13308 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
13309 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
13310 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
13311 assume EMACS_INT is the same width as char *.
13312 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
13313 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
13314 Remove no-longer-needed casts.
13315 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
13316 (xg_tool_bar_help_callback, xg_make_tool_item):
13317 Use EMACS_INTPTR to hold an integer
13318 that will be cast to void *; this can avoid a GCC warning
13319 if EMACS_INT is not the same width as void *.
13320 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
13321 * xdisp.c (display_echo_area_1, resize_mini_window_1):
13322 (current_message_1, set_message_1):
13323 Use a local to convert to proper width without a cast.
13324 * xmenu.c (dialog_selection_callback): Likewise.
13325
ede49d71
PE
13326 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
13327 Also, don't assume VALBITS / RAND_BITS is less than 5,
13328 and don't rely on undefined behavior when shifting a 1 left into
13329 the sign bit.
13330 * lisp.h (get_random): Change signature to match.
13331
2f30ecd0
PE
13332 * lread.c (hash_string): Use size_t, not int, for hash computation.
13333 Normally we prefer signed values; but hashing is special, because
13334 it's better to use unsigned division on hash table sizes so that
13335 the remainder is nonnegative. Also, size_t is the natural width
13336 for hashing into memory. The previous code used 'int', which doesn't
13337 retain enough info to hash well into very large tables.
13338 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
13339
2a866e7b
PE
13340 * dbusbind.c: Don't possibly lose pointer info when converting.
13341 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13342 Use XPNTR rather than XHASH, so that the high-order bits of
13343 the pointer aren't lost when converting through void *.
13344
51639eac
PE
13345 * eval.c (Fautoload): Don't double-shift a pointer.
13346
92394119
PE
13347 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
13348
dbdb9a7c
JB
133492011-05-06 Juanma Barranquero <lekktu@gmail.com>
13350
13351 * gnutls.c (DEF_GNUTLS_FN):
13352 * image.c (DEF_IMGLIB_FN): Make function pointers static.
13353
db7a0b4f
AS
133542011-05-05 Andreas Schwab <schwab@linux-m68k.org>
13355
13356 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
13357 marker. (Bug#8610)
13358
cd394be1 133592011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
13360
13361 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
13362 New version that can reserve upto 2GB of heap space.
13363
f7ff1b0f 133642011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
13365
13366 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
13367
639c109b
TZ
133682011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
13369
13370 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
13371 `gnutls_certificate_set_x509_key_file'.
13372
d2127135
JB
133732011-05-05 Juanma Barranquero <lekktu@gmail.com>
13374
13375 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
13376 Update dependencies.
13377
e968f4f3
JB
133782011-05-04 Juanma Barranquero <lekktu@gmail.com>
13379
13380 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
13381 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
13382 Remove unused parameter `fildes'.
13383 * process.c (read_process_output, send_process): Don't pass it.
13384
84d358f0
JB
133852011-05-04 Juanma Barranquero <lekktu@gmail.com>
13386
13387 Fix previous change: the library cache is defined in w32.c.
13388 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
13389 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
13390
0898ca10
JB
133912011-05-04 Juanma Barranquero <lekktu@gmail.com>
13392
13393 Implement dynamic loading of GnuTLS on Windows.
13394
13395 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
13396 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
13397 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13398 Declare.
13399
13400 * gnutls.c (Qgnutls_dll): Define.
13401 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
13402 (gnutls_*): Declare function pointers.
13403 (init_gnutls_functions): New function to initialize function pointers.
13404 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
13405 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
13406 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13407 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
13408 (emacs_gnutls_write, emacs_gnutls_read)
13409 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
13410 (Fgnutls_available_p): New function.
13411 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
13412 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
13413 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
13414
13415 * image.c: Include w32.h.
13416 (Vimage_type_cache): Delete.
13417 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
13418 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
13419 (w32_delayed_load): Move to w32.c.
13420
13421 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
13422
13423 * w32.c (QCloaded_from, Vlibrary_cache): Define.
13424 (w32_delayed_load): Move from image.c. When loading a library, record
13425 its filename in the :loaded-from property of the library id.
13426 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
13427 Initialize and staticpro them.
13428 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
13429
13430 * process.c: Include lisp.h before w32.h, not after.
13431 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
13432 instead of gnutls_record_check_pending.
13433
13434 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
13435
ff4de4aa
TZ
134362011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
13437
13438 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
13439 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
13440 as passed in.
13441
abe95abb
JD
134422011-05-03 Jan Djärv <jan.h.d@swipnet.se>
13443
13444 * xterm.c (x_set_frame_alpha): Do not set property on anything
13445 else than FRAME_X_OUTER_WINDOW (Bug#8608).
13446
e16e55d4
JB
134472011-05-02 Juanma Barranquero <lekktu@gmail.com>
13448
13449 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
13450
bafcf6a5
JB
134512011-05-02 Juanma Barranquero <lekktu@gmail.com>
13452
13453 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
13454 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
13455 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
13456 (gnutls_global_initialized, Qgnutls_bootprop_priority)
13457 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
13458 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
13459 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
13460 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
13461 (Qgnutls_bootprop_callbacks_verify): Make static.
13462
e7a6747f
AS
134632011-05-01 Andreas Schwab <schwab@linux-m68k.org>
13464
19ed11ba
AS
13465 * callproc.c: Indentation fixup.
13466
e7a6747f 13467 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
13468 (wait_for_termination, interruptible_wait_for_termination):
13469 Move after wait_for_termination_1.
e7a6747f 13470
1ef14cb4
LMI
134712011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
13472
13473 * sysdep.c (interruptible_wait_for_termination): New function
13474 which is like wait_for_termination, but allows keyboard
13475 interruptions.
13476
13477 * callproc.c (Fcall_process): Add (:file "file") as an option for
13478 the STDOUT buffer.
13479 (Fcall_process_region): Ditto.
13480
330d880c
EZ
134812011-04-30 Eli Zaretskii <eliz@gnu.org>
13482
8db90b73
EZ
13483 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
13484 rather than `XVECTOR (FOO)->size'.
13485
330d880c
EZ
13486 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
13487 inttypes.h, as a gnulib replacement is used if it not available in
13488 system headers.
13489
15cbd324
EZ
134902011-04-21 Eli Zaretskii <eliz@gnu.org>
13491
13492 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
13493 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
13494 of MOST_POSITIVE_FIXNUM. (Bug#8528)
13495
13496 * coding.c (coding_alloc_by_realloc): Error out if destination
13497 will grow beyond MOST_POSITIVE_FIXNUM.
13498 (decode_coding_emacs_mule): Abort if there isn't enough place in
13499 charbuf for the composition carryover bytes. Reserve an extra
13500 space for up to 2 characters produced in a loop.
13501 (decode_coding_iso_2022): Abort if there isn't enough place in
13502 charbuf for the composition carryover bytes.
13503
135042011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 13505
ae940cca
EZ
13506 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
13507 aborting when %lld or %lll format is passed.
13508 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
13509 %llo or %llx format is passed. (Bug#8545)
13510
03ab8921
EZ
13511 * window.c (window_scroll_line_based): Use a marker instead of
13512 simple variables to record original value of point. (Bug#7952)
13513
afda1437
EZ
13514 * doprnt.c (doprnt): Fix the case where a multibyte sequence
13515 produced by %s or %c overflows available buffer space. (Bug#8545)
13516
f76dee0c
PE
135172011-04-28 Paul Eggert <eggert@cs.ucla.edu>
13518
13519 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 13520 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 13521
fdc5744d
JB
135222011-04-28 Juanma Barranquero <lekktu@gmail.com>
13523
13524 * w32.c (init_environment): Warn about defaulting HOME to C:\.
13525
638f053a
JB
135262011-04-28 Juanma Barranquero <lekktu@gmail.com>
13527
13528 * keyboard.c (Qdelayed_warnings_hook): Define.
13529 (command_loop_1): Run `delayed-warnings-hook'
13530 if Vdelayed_warnings_list is non-nil.
13531 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
13532 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
13533
d178f871
EZ
135342011-04-28 Eli Zaretskii <eliz@gnu.org>
13535
13536 * doprnt.c (doprnt): Don't return value smaller than the buffer
13537 size if the message was truncated. (Bug#8545).
13538
b124fd93
JB
135392011-04-28 Juanma Barranquero <lekktu@gmail.com>
13540
13541 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
13542 (Fx_window_property): #if-0 the whole functions, not just the bodies.
13543
e810457d
PE
135442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13545
13546 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
13547
ea51cceb
JB
135482011-04-27 Juanma Barranquero <lekktu@gmail.com>
13549
13550 * makefile.w32-in: Update dependencies.
13551
94dcfacf
EZ
135522011-04-27 Eli Zaretskii <eliz@gnu.org>
13553
13554 Improve `doprnt' and its usage. (Bug#8545)
13555 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
13556 `format_end'. Remove support for %l as a conversion specifier.
13557 Don't use xrealloc. Improve diagnostics when the %l size modifier
13558 is used. Update the commentary.
13559
13560 * eval.c (verror): Simplify calculation of size_t.
13561
13562 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
13563 messages.
13564
f61f41d7
PE
135652011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
13566
13567 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
13568 change.
13569
96fb4434
PE
135702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13571
13572 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
13573 This makes this file independent of the recent pseudovector change.
13574
671875da 135752011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 13576
69e9b5a3
PE
13577 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
13578
b5f869a7 13579 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 13580 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 13581 Remove unused local.
c8926152 13582 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 13583
841a1577 13584 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
13585 GCC 4.6.0 optimizes based on type-based alias analysis.
13586 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
13587 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
13588 != &v->size, and therefore "v->size = 1; b->size = 2; return
13589 v->size;" must therefore return 1. This assumption is incorrect
13590 for Emacs, since it type-puns struct Lisp_Vector * with many other
13591 types. To fix this problem, this patch adds a new type struct
f904488f 13592 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
13593 and pseudovectors, and helps optimizing compilers not get fooled
13594 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
13595 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
13596 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
13597 the size member.
eab3844f
PE
13598 (XSETPVECTYPE): Rewrite in terms of new macro.
13599 (XSETPVECTYPESIZE): New macro, specifying both type and size.
13600 This is a bit clearer, and further avoids the possibility of
13601 undesirable aliasing.
13602 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 13603 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
13604 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
13605 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
13606 (ASIZE): Now uses header.size rather than size.
13607 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
13608 to avoid the hassle of writing XVECTOR (foo)->header.size.
13609 (struct vectorlike_header): New type.
eab3844f
PE
13610 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
13611 object, to help avoid aliasing.
13612 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
13613 (SUBRP): Likewise, since Lisp_Subr is a special case.
13614 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
13615 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
13616 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 13617 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
13618 changed to be "header.size" and "header.next".
13619 * buffer.h (struct buffer): Likewise.
13620 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
13621 * frame.h (struct frame): Likewise.
13622 * process.h (struct Lisp_Process): Likewise.
13623 * termhooks.h (struct terminal): Likewise.
13624 * window.c (struct save_window_data, struct saved_window): Likewise.
13625 * window.h (struct window): Likewise.
13626 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
13627 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
13628 * buffer.c (init_buffer_once): Likewise.
13629 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
13630 special case.
13631 * process.c (Fformat_network_address): Use local var for size,
13632 for brevity.
13633
0df1eac5
PE
13634 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
13635
847ab9d1 13636 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
13637 * data.c (atof): Remove decl; no longer used or needed.
13638 (digit_to_number): Move to lread.c.
13639 (Fstring_to_number): Use new string_to_number function, to be
13640 consistent with how the Lisp reader treats infinities and NaNs.
13641 Do not assume that floating-point numbers represent EMACS_INT
13642 without losing information; this is not true on most 64-bit hosts.
13643 Avoid double-rounding errors, by insisting on integers when
13644 parsing non-base-10 numbers, as the documentation specifies.
13645 * lisp.h (string_to_number): New decl, replacing ...
13646 (isfloat_string): Remove.
bc0a5c13 13647 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 13648 (read1): Do not accept +. and -. as integers; this
452f4150
PE
13649 appears to have been a coding error. Similarly, do not accept
13650 strings like +-1e0 as floating point numbers. Do not report
13651 overflow for integer overflows unless the base is not 10 which
13652 means we have no simple and reliable way to continue.
13653 Break out the floating-point parsing into a new
13654 function string_to_number, so that Fstring_to_number parses
13655 floating point numbers consistently with the Lisp reader.
04f2d78b 13656 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
13657 (E_CHAR, EXP_INT): Remove, replacing with ...
13658 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
13659 (string_to_number): New function, replacing isfloat_string.
13660 This function checks for valid syntax and produces the resulting
13661 Lisp float number too. Rework it so that string-to-number
bc0a5c13 13662 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
13663 so that overflow for non-base-10 numbers is reported only when
13664 there's no portable and simple way to convert to floating point.
452f4150 13665
67769ffc
PE
13666 * textprop.c (set_text_properties_1): Rewrite for clarity,
13667 and to avoid GCC warning about integer overflow.
13668
c20db43f
PE
13669 * intervals.h (struct interval): Use EMACS_INT for members
13670 where EMACS_UINT might cause problems. See
13671 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
13672 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
13673 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
13674 All uses changed.
37aa2f85
PE
13675 (offset_intervals): Tell GCC not to worry about length overflow
13676 when negating a negative length.
c20db43f 13677
2538aa2f
PE
13678 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
13679 (overrun_check_free): Likewise.
13680
f2d3008d
PE
13681 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
13682 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
13683 word size.
13684
ec8df744
PE
13685 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13686 (gnutls_make_error): Rename local to avoid shadowing.
13687 (gnutls_emacs_global_deinit): ifdef out; not used.
13688 (Fgnutls_boot): Use const for pointer to readonly storage.
13689 Comment out unused local. Fix pointer signedness problems.
13690
640ee02d
PE
13691 * lread.c (openp): Don't stuff size_t into an 'int'.
13692 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
13693 about possible signed overflow.
13694
6048fb2a
PE
13695 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13696 (GDK_KEY_g): Don't define if already defined.
13697 (xg_prepare_tooltip): Avoid pointer signedness problem.
13698 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
13699
fa3c87e1
PE
13700 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
13701 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
13702
2172544b
PE
13703 * xfns.c (Fx_window_property): Simplify a bit,
13704 to make a bit faster and to avoid GCC 4.6.0 warning.
13705 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
13706
9b821a21
PE
13707 * fns.c (internal_equal): Don't assume size_t fits in int.
13708
3c616cfa
PE
13709 * alloc.c (compact_small_strings): Tighten assertion a little.
13710
c2982e87
PE
13711 Replace pEd with more-general pI, and fix some printf arg casts.
13712 * lisp.h (pI): New macro, generalizing old pEd macro to other
13713 conversion specifiers. For example, use "...%"pI"d..." rather
13714 than "...%"pEd"...".
13715 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 13716 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
13717 * alloc.c (check_pure_size): Don't overflow by converting size to int.
13718 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
13719 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
13720 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
13721 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
13722 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
13723 64-bit hosts.
13724 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
13725 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
13726 * print.c (safe_debug_print, print_object): Likewise.
13727 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
13728 to int.
6f04d126
PE
13729 Use pI instead of if-then-else-abort. Use %p to avoid casts,
13730 avoiding the 0 flag, which is not portable.
c2982e87
PE
13731 * process.c (Fmake_network_process): Use pI to avoid cast.
13732 * region-cache.c (pp_cache): Likewise.
13733 * xdisp.c (decode_mode_spec): Likewise.
13734 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
13735 behavior on 64-bit hosts with printf arg.
6f04d126 13736 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
13737 (x_stop_queuing_selection_requests): Likewise.
13738 (x_get_window_property): Don't truncate byte count to an 'int'
13739 when tracing.
0b432f21 13740
5e073ec7
PE
13741 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
13742 here, since it parses constructs like leading '-' and spaces,
13743 which are not wanted; and it overflows with large numbers.
13744 Instead, simply match F[0-9]+, which is what is wanted anyway.
13745
36372bf9
PE
13746 * alloc.c: Remove unportable assumptions about struct layout.
13747 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
13748 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
13749 (allocate_vectorlike, make_pure_vector): Use the new macros,
13750 plus offsetof, to remove unportable assumptions about struct layout.
13751 These assumptions hold on all porting targets that I know of, but
13752 they are not guaranteed, they're easy to remove, and removing them
13753 makes further changes easier.
13754
0b432f21
PE
13755 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
13756 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
13757 (string_overrun_cookie): Now const. Use initializers that
13758 don't formally overflow signed char, to avoid warnings.
000098c1
PE
13759 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
13760 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
13761 (allocate_buffer): Don't assume sizeof (struct buffer) is a
13762 multiple of sizeof (EMACS_INT); it need not be, if
13763 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 13764 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 13765
895009e1
JB
137662011-04-26 Juanma Barranquero <lekktu@gmail.com>
13767
13768 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
13769
6a7a1b0b
TZ
137702011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
13771
13772 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 13773 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
13774 Reported by Paul Eggert <eggert@cs.ucla.edu>.
13775
841a1577 137762011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
13777
13778 * lisp.h (Qdebug): List symbol.
895009e1 13779 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
13780 * keyboard.c (debug-on-event): New variable.
13781 (handle_user_signal): Break into debugger when debug-on-event
13782 matches the current signal symbol.
13783
f2d3ba6f
DN
137842011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
13785
13786 * alloc.c (check_sblock, check_string_bytes)
13787 (check_string_free_list): Convert to standard C.
13788
42ce4c63
TZ
137892011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
13790
13791 * w32.c (emacs_gnutls_push): Fix typo.
13792
825cd63c
EZ
137932011-04-25 Eli Zaretskii <eliz@gnu.org>
13794
fb11d64d
EZ
13795 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
13796 "cast to pointer from integer of different size".
13797
825cd63c
EZ
13798 Improve doprnt and its use in verror. (Bug#8545)
13799 * doprnt.c (doprnt): Document the set of format control sequences
13800 supported by the function. Use SAFE_ALLOCA instead of always
13801 using `alloca'.
13802
13803 * eval.c (verror): Don't limit the buffer size at size_max-1, that
13804 is one byte too soon. Don't use xrealloc; instead xfree and
13805 xmalloc anew.
13806
e061a11b
TZ
138072011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
13808
13809 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
13810 callbacks stage.
13811
13812 * gnutls.c: Renamed global_initialized to
13813 gnutls_global_initialized. Added internals for the
13814 :verify-hostname-error, :verify-error, and :verify-flags
13815 parameters of `gnutls-boot' and documented those parameters in the
13816 docstring. Start callback support.
9173deec
JB
13817 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
13818 unless a fatal error occurred. Call gnutls_alert_send_appropriate
13819 on error. Return error code.
e061a11b
TZ
13820 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
13821 (emacs_gnutls_read): Likewise.
13822 (Fgnutls_boot): Return handshake error code.
13823 (emacs_gnutls_handle_error): New function.
13824 (wsaerror_to_errno): Likewise.
13825
13826 * w32.h (emacs_gnutls_pull): Add prototype.
13827 (emacs_gnutls_push): Likewise.
13828
13829 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
13830 (emacs_gnutls_push): Likewise.
13831
138322011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
13833
13834 * process.c (wait_reading_process_output): Check if GnuTLS
13835 buffered some data internally if no FDs are set for TLS
13836 connections.
13837
13838 * makefile.w32-in (OBJ2): Add gnutls.$(O).
13839 (LIBS): Link to USER_LIBS.
13840 ($(BLD)/gnutls.$(0)): New target.
13841
fa6996bc
EZ
138422011-04-24 Eli Zaretskii <eliz@gnu.org>
13843
eb35682e
EZ
13844 * xdisp.c (handle_single_display_spec): Rename the
13845 display_replaced_before_p argument into display_replaced_p, to
13846 make it consistent with the commentary. Fix typos in the
13847 commentary.
13848
e2ad650c
EZ
13849 * textprop.c (syms_of_textprop): Remove dead code.
13850 (copy_text_properties): Delete obsolete commentary about an
13851 interface that was deleted long ago. Fix typos in the description
13852 of arguments.
13853
1b2de274
EZ
13854 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
13855 to changes in oldXMenu/XMenu.h from 2011-04-16.
13856 <menu_help_message, prev_menu_help_message>: Constify.
13857 (IT_menu_make_room): menu->help_text is now `const char **';
13858 adjust.
13859
13860 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
13861 to changes in oldXMenu/XMenu.h from 2011-04-16.
13862 (struct XMenu): Declare `help_text' `const char **'.
13863
13864 * xfaces.c <Qunspecified>: Make extern again.
13865
13866 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 13867 required by POSIX.
1b2de274 13868
762b15be
EZ
13869 * doc.c (get_doc_string): Improve the format passed to `error'.
13870
13871 * doprnt.c (doprnt): Improve commentary.
13872
13873 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
13874
13875 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
13876 them with etags.
13877
f1052e5d
EZ
13878 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13879 changes in globals.h immediately force recompilation.
762b15be
EZ
13880 (TAGS): Depend on $(CURDIR)/m/intel386.h and
13881 $(CURDIR)/s/ms-w32.h.
13882 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 13883
fa6996bc
EZ
13884 * character.c (Fchar_direction): Function deleted.
13885 (syms_of_character): Don't defsubr it.
13886 <char-direction-table>: Deleted.
13887
e6c3da20
EZ
138882011-04-23 Eli Zaretskii <eliz@gnu.org>
13889
13890 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
13891 * doprnt.c: Include limits.h.
13892 (SIZE_MAX): New macro.
04f2d78b
CB
13893 (doprnt): Return a size_t value. 2nd arg is now size_t.
13894 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
13895 Improve overflow protection. Support `l' modifier for integer
13896 conversions. Support %l conversion. Don't assume an EMACS_INT
13897 argument for integer conversions and for %c.
13898
13899 * lisp.h (doprnt): Restore prototype.
13900
13901 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
13902 $(SRC)/character.h.
13903
13904 * Makefile.in (base_obj): Add back doprnt.o.
13905
13906 * deps.mk (doprnt.o): Add back prerequisites.
13907 (callint.o): Depend on character.h.
13908
13909 * eval.c (internal_lisp_condition_case): Include the handler
13910 representation in the error message.
13911 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13912 when breaking from the loop.
13913
13914 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13915
13916 * callint.c (Fcall_interactively): When displaying error message
13917 about invalid control letter, pass the character's codepoint, not
13918 a pointer to its multibyte form. Improve display of the character
13919 in octal and display also its hex code.
13920
13921 * character.c (char_string): Use %x to display the (unsigned)
13922 codepoint of an invalid character, to avoid displaying a bogus
13923 negative value.
13924
13925 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13926 `error', not SYMBOL_NAME itself.
13927
13928 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13929 character arguments to `error'.
13930
13931 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13932 to `error' in error message about FINAL_CHAR argument. Make sure
13933 FINAL_CHAR is a character, and use %c when it is passed as
13934 argument to `error'.
13935
4ffd0d6b 139362011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13937
13938 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13939
13940 * w32.c: Include <time.h>.
13941 (sys_localtime): New function.
13942
4ffd0d6b 139432011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13944
13945 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13946
4ffd0d6b 13947 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13948
4ffd0d6b 139492011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13950
4ffd0d6b
GM
13951 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13952 zombies (Bug#8467).
aac0c6e3 13953
04c56954
EZ
139542011-04-19 Eli Zaretskii <eliz@gnu.org>
13955
13956 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13957 gl_state.e_property when gl_state.object is Qt.
13958
13959 * insdel.c (make_gap_larger): Remove limitation of buffer size
13960 to <= INT_MAX.
13961
16a43933
CY
139622011-04-18 Chong Yidong <cyd@stupidchicken.com>
13963
13964 * xdisp.c (lookup_glyphless_char_display)
13965 (produce_glyphless_glyph): Handle cons cell entry in
13966 glyphless-char-display.
13967 (Vglyphless_char_display): Document it.
13968
13969 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13970 glyphless-char-display.
13971
4581706e
CY
139722011-04-17 Chong Yidong <cyd@stupidchicken.com>
13973
13974 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13975
13976 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13977
13978 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13979 definition for no-X builds.
13980
4887c6e2 139812011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13982
fd35b6f9
PE
13983 Static checks with GCC 4.6.0 and non-default toolkits.
13984
5c1ccb01
PE
13985 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13986
006c5daa
PE
13987 * process.c (keyboard_bit_set): Define only if SIGIO.
13988 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13989 (send_process): Repair possible setjmp clobbering.
13990
efc736d3
PE
13991 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13992
4e2fe2e6
PE
13993 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13994
f97334a2
PE
13995 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13996
4e75f29d
PE
13997 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13998 Define only if needed.
13999
90efadd1
PE
14000 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
14001 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 14002 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 14003
3c647824
PE
14004 * dispextern.h (struct redisplay_interface): Rename param
14005 to avoid shadowing.
e264f262 14006 * termhooks.h (struct terminal): Likewise.
761383f4 14007 * xterm.c (xembed_send_message): Likewise.
3c647824 14008
b58c5c4a
PE
14009 * insdel.c (make_gap_smaller): Define only if
14010 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
14011
cad59032
PE
14012 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
14013 it.
14014
c339dc2e
PE
14015 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
14016 so that we aren't warned about unused symbols.
14017
91a3e27b
PE
14018 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
14019
399c71d3 14020 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 14021
8ffc96f5
PE
14022 * xfns.c (x_real_positions): Mark locals as initialized.
14023
eef9bc79
PE
14024 * xmenu.c (xmenu_show): Don't use uninitialized vars.
14025
098db9dd
PE
14026 * xterm.c: Fix problems found by static analysis with other toolkits.
14027 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
14028 (x_dispatch_event): Declare static if USE_GTK, and
14029 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 14030 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 14031 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
14032 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
14033 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 14034
eb18f6cc
PE
14035 * xmenu.c (menu_help_callback): Pointer type fixes.
14036 Use const pointers when pointing at readonly data. Avoid pointer
14037 signedness clashes.
14038 (FALSE): Remove unused macro.
14039 (update_frame_menubar): Remove unused decl.
14040
1fe72bf8
PE
14041 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
14042
60d9e1db
PE
14043 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
14044 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
14045 (single_menu_item): Rename local to avoid shadowing.
14046
39261c26
PE
14047 * keyboard.c (make_lispy_event): Remove unused local var.
14048
018c5e19
PE
14049 * frame.c, frame.h (x_get_resource_string): Bring this back, but
14050 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
14051
63d2b86e
PE
14052 * bitmaps: Change bitmaps from unsigned char back to the X11
14053 compatible char. Avoid the old compiler warnings about
14054 out-of-range initializers by using, for example, '\xab' rather
14055 than 0xab.
14056
aefd87e1
PE
14057 * xgselect.c (xgselect_initialize): Check vs interface
14058 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
14059
bf501fb9
PE
14060 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
14061
e9829fdf
PE
14062 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
14063 to read-only memory.
14064
1086c095
PE
14065 * fns.c (vector): Remove; this old hack is no longer needed.
14066
2baccd04 14067 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 14068 Remove unused var.
dde42981 14069 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 14070
72391843 14071 * xrdb.c (x_load_resources): Omit unused local.
3565b346 14072
436c16df 14073 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 14074 (x_window): Rename locals to avoid shadowing.
dc5ddd85 14075 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 14076
92bb796d 14077 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 14078 (x_term_init): Remove local to avoid shadowing.
92bb796d 14079
764430a3 14080 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
14081
14082 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
14083 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
14084
d1dfb56c
EZ
140852011-04-16 Eli Zaretskii <eliz@gnu.org>
14086
c4354cb4
EZ
14087 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
14088
d1dfb56c
EZ
14089 Fix regex.c, syntax.c and friends for buffers > 2GB.
14090 * syntax.h (struct gl_state_s): Declare character position members
14091 EMACS_INT.
14092
14093 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
14094
04f2d78b
CB
14095 * textprop.c (verify_interval_modification, interval_of):
14096 Declare arguments EMACS_INT.
d1dfb56c
EZ
14097
14098 * intervals.c (adjust_intervals_for_insertion): Declare arguments
14099 EMACS_INT.
14100
14101 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
14102
14103 * indent.c (Fvertical_motion): Local variable it_start is now
14104 EMACS_INT.
14105
14106 * regex.c (re_match, re_match_2, re_match_2_internal)
14107 (bcmp_translate, regcomp, regexec, print_double_string)
14108 (group_in_compile_stack, re_search, re_search_2, regex_compile)
14109 (re_compile_pattern, re_exec): Declare arguments and local
14110 variables `size_t' and `ssize_t' and return values `regoff_t', as
14111 appropriate.
14112 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
14113 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
14114 <compile_stack_type>: `size' and `avail' are now `size_t'.
14115
14116 * regex.h <regoff_t>: Use ssize_t, not int.
14117 (re_search, re_search_2, re_match, re_match_2): Arguments that
14118 specify buffer/string position and length are now ssize_t and
14119 size_t. Return type is regoff_t.
14120
613052cd
BK
141212011-04-16 Ben Key <bkey76@gmail.com>
14122
14123 * nsfont.m: Fixed bugs in ns_get_family and
14124 ns_descriptor_to_entity that were caused by using free to
14125 deallocate memory blocks that were allocated by xmalloc (via
14126 xstrdup). This caused Emacs to crash when compiled with
14127 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
14128 --enable-checking=xmallocoverrun). xfree is now used to
14129 deallocate these memory blocks.
14130
4170f62f 141312011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 14132
71b41406
PE
14133 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
14134
9587a89d
PE
14135 emacs_write: Accept and return EMACS_INT for sizes.
14136 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
14137 et seq.
14138 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
14139 Accept and return EMACS_INT.
14140 (emacs_gnutls_write): Return the number of bytes written on
14141 partial writes.
14142 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
14143 (emacs_read, emacs_write): Remove check for negative size, as the
14144 Emacs source code has been audited now.
9587a89d
PE
14145 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
14146 (emacs_read, emacs_write): Use it.
273a5f82
PE
14147 * process.c (send_process): Adjust to the new signatures of
14148 emacs_write and emacs_gnutls_write. Do not attempt to store
14149 a byte offset into an 'int'; it might overflow.
9587a89d 14150 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 14151
3e047f51
PE
14152 * sound.c: Don't assume sizes fit in 'int'.
14153 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 14154 Return EMACS_INT, not int.
3e047f51 14155 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
14156 Accept EMACS_INT, not int.
14157 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
14158 record read return values.
14159
cc39a9db
BK
141602011-04-15 Ben Key <bkey76@gmail.com>
14161
c9d0ec6d
JB
14162 * keyboard.c (Qundefined): Don't declare static since it is used
14163 in nsfns.m.
14164 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
14165 static since they are used in nsfont.m.
cc39a9db 14166
6c60eb9f
SM
141672011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
14168
14169 * process.c (Qprocessp): Don't declare static.
14170 * lisp.h (Qprocessp): Declare again.
14171
7990b61a
JB
141722011-04-15 Juanma Barranquero <lekktu@gmail.com>
14173
14174 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
14175
5d4cb038
PE
141762011-04-14 Paul Eggert <eggert@cs.ucla.edu>
14177
8bd7b830 14178 Improve C-level modularity by making more things 'static'.
cd64ea1d 14179
e3b27b31
PE
14180 Don't publish debugger-only interfaces to other modules.
14181 * lisp.h (safe_debug_print, debug_output_compilation_hack):
14182 (verify_bytepos, count_markers): Move decls to the only modules
14183 that need them.
14184 * region-cache.h (pp_cache): Likewise.
14185 * window.h (check_all_windows): Likewise.
14186 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
14187
5d4cb038
PE
14188 * sysdep.c (croak): Now static, if
14189 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
14190 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
14191
14192 * alloc.c (refill_memory_reserve): Now static if
14193 !defined REL_ALLOC || defined SYSTEM_MALLOC.
14194 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 14195
e87b6180
PE
14196 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
14197 Define only if USE_LUCID.
14198
ac64929e
PE
14199 * xrdb.c (x_customization_string, x_rm_string): Now static.
14200
6f37259d
PE
14201 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
14202 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
14203
1683e3ab
PE
14204 * xdisp.c (draw_row_with_mouse_face): Now static.
14205 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
14206
de9c2632
PE
14207 * window.h (check_all_windows): Mark externally visible.
14208
2b96acb7
PE
14209 * window.c (window_deletion_count): Now static.
14210
14211 * undo.c: Make symbols static if they're not exported.
14212 (last_undo_buffer, last_boundary_position, pending_boundary):
14213 Now static.
14214
50436f33
PE
14215 * textprop.c (interval_insert_behind_hooks): Now static.
14216 (interval_insert_in_front_hooks): Likewise.
14217
64520e5c
PE
14218 * term.c: Make symbols static if they're not exported.
14219 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
14220 (max_frame_lines, tty_set_terminal_modes):
14221 (tty_reset_terminal_modes, tty_turn_off_highlight):
14222 (get_tty_terminal): Now static.
14223 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
14224 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 14225 HAVE_WINDOW_SYSTEM.
64520e5c
PE
14226 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
14227 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
14228
1fa53021
PE
14229 * sysdep.c: Make symbols static if they're not exported.
14230 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
14231 Now static.
14232 (sigprocmask_set, full_mask): Remove; unused.
14233 (wait_debugging): Mark as visible.
14234 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
14235 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
14236
d4b43b22
PE
14237 * syntax.c (syntax_temp): Define only if !__GNUC__.
14238
b7c513d0
PE
14239 * sound.c (current_sound_device, current_sound): Now static.
14240
989b29ad
PE
14241 * search.c (searchbufs, searchbuf_head): Now static.
14242
13a55a78
PE
14243 * scroll.c (scroll_cost): Remove; unused.
14244 * dispextern.h (scroll_cost): Remove decl.
14245
de68a1fc
PE
14246 * region-cache.h (pp_cache): Mark as externally visible.
14247
40ccffa6
PE
14248 * process.c: Make symbols static if they're not exported.
14249 (process_tick, update_tick, create_process, chan_process):
14250 (Vprocess_alist, proc_buffered_char, datagram_access):
14251 (fd_callback_data, send_process_frame, process_sent_to): Now static.
14252 (deactivate_process): Mark defn as static, as well as decl.
14253 * lisp.h (create_process): Remove decl.
14254 * process.h (chan_process, Vprocess_alist): Remove decls.
14255
ad64fc97
PE
14256 * print.c: Make symbols static if they're not exported.
14257 (print_depth, new_backquote_output, being_printed, print_buffer):
14258 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
14259 (print_interval, print_number_index, initial_stderr_stream):
14260 Now static.
14261 * lisp.h (Fprinc): Remove decl.
14262 (debug_output_compilation_hack): Mark as externally visible.
14263
adddb265
PE
14264 * sysdep.c (croak): Move decl from here to syssignal.h.
14265 * syssignal.h (croak): Put it here, so the API can be checked when
14266 'croak' is called from dissociate_if_controlling_tty.
14267
1717ede2
PE
14268 * minibuf.c: Make symbols static if they're not exported.
14269 (minibuf_save_list, choose_minibuf_frame): Now static.
14270 * lisp.h (choose_minibuf_frame): Remove decl.
14271
fa5fb2bc
PE
14272 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
14273
1e3890d1
PE
14274 * lread.c: Make symbols static if they're not exported.
14275 (read_objects, initial_obarray, oblookup_last_bucket_number):
14276 Now static.
14277 (make_symbol): Remove; unused.
14278 * lisp.h (initial_obarray, make_symbol): Remove decls.
14279
8a1414fa
PE
14280 * keyboard.c: Make symbols static if they're not exported.
14281 (single_kboard, recent_keys_index, total_keys, recent_keys):
14282 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
14283 (this_single_command_key_start, echoing, last_auto_save):
14284 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
14285 (command_loop, echo_now, keyboard_init_hook, help_char_p):
14286 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
14287 (Vlispy_mouse_stem, double_click_count):
14288 Now static.
14289 (force_auto_save_soon): Define only if SIGDANGER.
14290 (ignore_mouse_drag_p): Now static if
14291 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
14292 (print_help): Remove; unused.
14293 (stop_character, last_timer_event): Mark as externally visible.
14294 * keyboard.h (ignore_mouse_drag_p): Declare only if
14295 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
14296 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
14297 * lisp.h (echoing): Remove decl.
14298 (force_auto_save_soon): Declare only if SIGDANGER.
14299 * xdisp.c (redisplay_window): Simplify code, to make it more
14300 obvious that ignore_mouse_drag_p is not accessed if !defined
14301 USE_GTK && !defined HAVE_NS.
14302
93ea6e8f
PE
14303 * intervals.c: Make symbols static if they're not exported.
14304 (merge_properties_sticky, merge_interval_right, delete_interval):
14305 Now static.
14306 * intervals.h (merge_interval_right, delete_interval): Remove decls.
14307
77382fcc
PE
14308 * insdel.c: Make symbols static if they're not exported.
14309 However, leave prepare_to_modify_buffer alone. It's never
14310 called from outside this function, but that appears to be a bug.
14311 (combine_after_change_list, combine_after_change_buffer):
4889fc82 14312 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
14313 (adjust_after_replace_noundo): Remove; unused.
14314 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 14315 (signal_before_change): Remove decls.
77382fcc 14316
9306c32e
PE
14317 * indent.c (val_compute_motion, val_vmotion): Now static.
14318
cd44d2eb
PE
14319 * image.c: Make symbols static if they're not exported.
14320 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
14321 if USE_GTK.
14322 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
14323 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
14324
ad9a7a06
PE
14325 * fringe.c (standard_bitmaps): Now static.
14326 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
14327
81626931
PE
14328 * frame.c: Make symbols static if they're not exported.
14329 (x_report_frame_params, make_terminal_frame): Now static.
14330 (get_frame_param): Now static, unless HAVE_NS.
14331 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
14332 (x_get_resource_string): Remove; not used.
14333 * frame.h (make_terminal_frame, x_report_frame_params):
14334 (x_get_resource_string); Remove decls.
14335 (x_fullscreen_adjust): Declare only if WINDOWSNT.
14336 * lisp.h (get_frame_param): Declare only if HAVE_NS.
14337
239f9db9
PE
14338 * font.c, fontset.c: Make symbols static if they're not exported.
14339 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
14340 (FACE_SUITABLE_FOR_CHAR_P): Use it.
14341 * font.c (font_close_object): Now static.
14342 * font.h (font_close_object): Remove.
14343 * fontset.c (FONTSET_OBJLIST): Remove.
14344 (free_realized_fontset) #if-0 the body, which does nothing.
14345 (face_suitable_for_char_p): #if-0, as it's never called.
14346 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
14347 * xfaces.c (face_at_string_position):
14348 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
14349 since 0 is always ASCII.
14350
dfcf3579
PE
14351 * fns.c (weak_hash_tables): Now static.
14352
5045092b
PE
14353 * fileio.c: Make symbols static if they're not exported.
14354 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
14355 (Vwrite_region_annotation_buffers): Now static.
14356
57a96f5c
PE
14357 * eval.c: Make symbols static if they're not exported.
14358 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
14359 * lisp.h (backtrace_list): Remove decl.
14360
35f08c38
PE
14361 * emacs.c: Make symbols static if they're not exported.
14362 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
14363 (fatal_error_code, fatal_error_signal_hook, standard_args):
14364 Now static.
14365 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
14366 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
14367 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
14368 * lisp.h (fatal_error_signal_hook): Remove decl.
14369 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
14370
f44bd759
PE
14371 * editfns.c: Move a (normally-unused) function to its only use.
14372 * editfns.c, lisp.h (get_operating_system_release): Remove.
14373 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
14374 worth the hassle of breaking this out.
14375
b532497d
PE
14376 * xterm.c: Make symbols static if they're not exported.
14377 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
14378 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
14379 (x_destroy_window, x_delete_display):
14380 Now static.
14381 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
14382 (x_mouse_leave): Remove; unused.
14383 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
14384 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
14385 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
14386 Remove decls.
14387 (x_mouse_leave): Declare only if WINDOWSNT.
14388 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
14389 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
14390 USE_X_TOOLKIT.
14391
1675728f
PE
14392 * ftxfont.c: Make symbols static if they're not exported.
14393 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
14394 HAVE_FREETYPE.
14395 * font.h (ftxfont_driver): Likewise.
14396
e4cebfca
PE
14397 * xfns.c: Make symbols static if they're not exported.
14398 (x_last_font_name, x_display_info_for_name):
14399 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
14400 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
14401 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
14402 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
14403 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
14404 (last_show_tip_args): Now static.
14405 (xic_defaut_fontset, xic_create_fontsetname): Define only if
14406 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
14407 (x_screen_planes): Remove; unused.
14408 * dispextern.h (x_screen_planes): Remove decl.
14409
5bf46f05
PE
14410 * dispnew.c: Make symbols static if they're not exported.
14411 * dispextern.h (redraw_garbaged_frames, scrolling):
14412 (increment_row_positions): Remove.
14413 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
14414 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
14415 Now static.
14416 (redraw_garbaged_frames): Remove; unused.
14417
435f4c28
PE
14418 * xfaces.c: Make symbols static if they're not exported.
14419 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
14420 Remove decls.
14421 * xterm.h (defined_color): Remove decls.
14422 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
14423 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
14424 (menu_face_changed_default, defined_color, free_realized_face):
14425 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
14426 (ascii_face_of_lisp_face): Remove; unused.
14427
8524aef3
PE
14428 * xdisp.c: Make symbols static if they're not exported.
14429 * dispextern.h (scratch_glyph_row, window_box_edges):
14430 (glyph_to_pixel_coords, set_cursor_from_row):
14431 (get_next_display_element, set_iterator_to_next):
14432 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
14433 (show_mouse_face): Remove decls
14434 * frame.h (message_buf_print): Likewise.
14435 * lisp.h (pop_message, set_message, check_point_in_composition):
14436 Likewise.
14437 * xterm.h (set_vertical_scroll_bar): Likewise.
14438 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
14439 (message_buf_print, scratch_glyph_row, displayed_buffer):
14440 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
14441 (get_next_display_element, show_mouse_face, window_box_edges):
14442 (frame_to_window_pixel_xy, check_point_in_composition):
14443 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
14444 (glyph_to_pixel_coords): Remove; unused.
14445
16390cd2
PE
14446 * dired.c (file_name_completion): Now static.
14447
14448 * dbusbind.c (xd_in_read_queued_messages): Now static.
14449
a25f4dfa
PE
14450 * lisp.h (circular_list_error, FOREACH): Remove; unused.
14451 * data.c (circular_list_error): Remove.
14452
14a9c8df
PE
14453 * commands.h (last_point_position, last_point_position_buffer):
14454 (last_point_position_window): Remove decls.
14455 * keyboard.c: Make these variables static.
14456
04f2d78b
CB
14457 * coding.h (coding, code_convert_region, encode_coding_gap):
14458 Remove decls.
74ab6df5
PE
14459 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
14460 (iso_code_class, detect_coding, code_convert_region): Now static.
14461 (encode_coding_gap): Remove; unused.
14462
38dfbee1
PE
14463 * chartab.c (chartab_chars, chartab_bits): Now static.
14464
a2cb4e63
PE
14465 * charset.h (charset_iso_8859_1): Remove decl.
14466 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
14467 Now static.
14468
127198fd
PE
14469 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
14470 * ccl.c (Vccl_program_table): Now static.
14471 (check_ccl_update): Remove; unused.
14472
d85b608f
PE
14473 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
14474 * category.h: ... from here.
14475 * category.c (check_category_table, set_category_set): Now static.
14476
31cd66f3
PE
14477 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
14478 * lisp.h: Remove these decls.
14479
c358e587
PE
14480 * buffer.c (buffer_count): Remove unused var.
14481
e78aecca
PE
14482 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
14483 so that it's not optimized away.
14484 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
14485 * dispextern.h (bidi_dump_cached_states): Remove, since it's
14486 exported only to the debugger.
14487
e192d7d3 14488 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 14489 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 14490
92470028
PE
14491 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
14492 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
14493 was inaccessible from Lisp.
14494 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
14495 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
14496
244ed907
PE
14497 alloc.c: Import and export fewer symbols, and remove unused items.
14498 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
14499 is defined.
14500 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
14501 it's not optimized away by whole-program optimization.
14502 (message_enable_multibyte, free_misc): Remove.
14503 (catchlist, handlerlist, mark_backtrace):
14504 Declare only if BYTE_MARK_STACK.
14505 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
14506 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
14507 (message_enable_multibyte): Remove decl.
14508 (free_misc, interval_free_list, float_block, float_block_index):
14509 (n_float_blocks, float_free_list, cons_block, cons_block_index):
14510 (cons_free_list, last_marked_index):
14511 Now static.
14512 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
14513 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
14514 (mark_backtrace): Define only if BYTE_MARK_STACK.
14515 * xdisp.c (message_enable_multibyte): Now static.
14516
61c2b50e 14517 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
14518 This makes it easier for human readers (and static analyzers)
14519 to see whether these variables are used from other modules.
14520 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
14521 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
14522 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
14523 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
14524 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
14525 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
14526 * xmenu.c, xselect.c:
14527 Declare Q* vars static if they are not used in other modules.
14528 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
14529 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
14530 Remove decls of unexported vars.
14531 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
14532
95c82688
PE
14533 * lisp.h (DEFINE_FUNC): Make sname 'static'.
14534
16a97296
PE
14535 Make Emacs functions such as Fatom 'static' by default.
14536 This makes it easier for human readers (and static analyzers)
14537 to see whether these functions can be called from other modules.
14538 DEFUN now defines a static function. To make the function external
14539 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
14540 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
14541 (Finit_image_library):
16a97296
PE
14542 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
14543 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
14544 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
14545 Remove decls, since these functions are now static.
14546 (Funintern, Fget_internal_run_time): New decls, since these functions
14547 were already external.
95c82688 14548
16a97296
PE
14549 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
14550 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
14551 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
14552 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
14553 * keyboard.c, keymap.c, lread.c:
14554 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
14555 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
14556 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
14557 Mark functions with DEFUE instead of DEFUN,
14558 if they are used in other modules.
14559 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
14560 decls for now-static functions.
14561 * buffer.h (Fdelete_overlay): Remove decl.
14562 * callproc.c (Fgetenv_internal): Mark as internal.
14563 * composite.c (Fremove_list_of_text_properties): Remove decl.
14564 (Fcomposition_get_gstring): New forward static decl.
14565 * composite.h (Fcomposite_get_gstring): Remove decl.
14566 * dired.c (Ffile_attributes): New forward static decl.
14567 * doc.c (Fdocumntation_property): New forward static decl.
14568 * eval.c (Ffetch_bytecode): New forward static decl.
14569 (Funintern): Remove extern decl; now in .h file where it belongs.
14570 * fileio.c (Fmake_symbolic_link): New forward static decl.
14571 * image.c (Finit_image_library): New forward static decl.
14572 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
14573 * intervals.h (Fprevious_property_change):
14574 (Fremove_list_of_text_properties): Remove decls.
14575 * keyboard.c (Fthis_command_keys): Remove decl.
14576 (Fcommand_execute): New forward static decl.
14577 * keymap.c (Flookup_key): New forward static decl.
14578 (Fcopy_keymap): Now static.
14579 * keymap.h (Flookup_key): Remove decl.
14580 * process.c (Fget_process): New forward static decl.
14581 (Fprocess_datagram_address): Mark as internal.
14582 * syntax.c (Fsyntax_table_p): New forward static decl.
14583 (skip_chars): Remove duplicate decl.
14584 * textprop.c (Fprevious_property_change): New forward static decl.
14585 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
14586 Now internal.
14587 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
14588 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
14589
785bbd42
PE
14590 * editfns.c (Fformat): Remove unreachable code.
14591
8b913b57
AS
145922011-04-14 Andreas Schwab <schwab@linux-m68k.org>
14593
14594 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
14595 change. (Bug#8496)
14596
a6744a35
EZ
145972011-04-13 Eli Zaretskii <eliz@gnu.org>
14598
14599 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
14600 when at ZV. (Bug#8487)
14601
e7974947
AS
146022011-04-12 Andreas Schwab <schwab@linux-m68k.org>
14603
baad03f0
AS
14604 * charset.c (Fclear_charset_maps): Use xfree instead of free.
14605 (Bug#8437)
14606 * keyboard.c (parse_tool_bar_item): Likewise.
14607 * sound.c (sound_cleanup, alsa_close): Likewise.
14608 * termcap.c (tgetent): Likewise.
14609 * xfns.c (x_default_font_parameter): Likewise.
14610 * xsettings.c (read_and_apply_settings): Likewise.
14611
e7974947
AS
14612 * alloc.c (overrun_check_malloc, overrun_check_realloc)
14613 (overrun_check_free): Protoize.
14614
28272684
PE
146152011-04-12 Paul Eggert <eggert@cs.ucla.edu>
14616
14617 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
14618 since callers should never pass a negative size.
14619 Change the signature to match that of plain 'read' and 'write'; see
14620 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
14621 * lisp.h: Update prototypes of emacs_write and emacs_read.
14622
11997c76
EZ
146232011-04-11 Eli Zaretskii <eliz@gnu.org>
14624
14625 * xdisp.c (redisplay_window): Don't try to determine the character
14626 position of the scroll margin if the window start point w->startp
e896f03c 14627 is outside the buffer's accessible region. (Bug#8468)
11997c76 14628
8a2cbd72
EZ
146292011-04-10 Eli Zaretskii <eliz@gnu.org>
14630
14631 Fix write-region and its subroutines for buffers > 2GB.
14632 * fileio.c (a_write, e_write): Modify declaration of arguments and
14633 local variables to support buffers larger than 2GB.
14634 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
14635
14636 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
14637 argument, local variables, and return value.
14638
14639 * lisp.h: Update prototypes of emacs_write and emacs_read.
14640
14641 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
14642
4073e537 146432011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 14644
1ebfdcb6
PE
14645 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
14646
b2ded58d
PE
14647 Fix more problems found by GCC 4.6.0's static checks.
14648
7d66342c
PE
14649 * xdisp.c (vmessage): Use a better test for character truncation.
14650
bbf47d44
PE
14651 * charset.c (load_charset_map): <, not <=, for optimization,
14652 and to avoid potential problems with integer overflow.
9248994d 14653 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 14654 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 14655 * editfns.c (Fformat): Likewise.
1e69125e 14656 * syntax.c (skip_chars): Likewise.
3befa583 14657
e3019616
PE
14658 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
14659 This also lets GCC 4.6.0 generate slightly better loop code.
14660
becfa255
PE
14661 * callint.c (Fcall_interactively): <, not <=, for optimization.
14662 (Fcall_interactively): Count the number of arguments produced,
14663 not the number of arguments given. This is simpler and lets GCC
14664 4.6.0 generate slightly better code.
14665
dae0cd48
PE
14666 * ftfont.c: Distingish more carefully between FcChar8 and char.
14667 The previous code passed unsigned char * to a functions like
14668 strlen and xstrcasecmp that expect char *, which does not
14669 conform to the C standard.
14670 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
14671 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
14672 char * when the C standard requires it.
14673
76032d70
PE
14674 * keyboard.c (read_char): Remove unused var.
14675
eb3f1cc8
PE
14676 * eval.c: Port to Windows vsnprintf (Bug#8435).
14677 Include <limits.h>.
14678 (SIZE_MAX): Define if the headers do not.
14679 (verror): Do not give up if vsnprintf returns a negative count.
14680 Instead, grow the buffer. This ports to Windows vsnprintf, which
14681 does not conform to C99. Problem reported by Eli Zaretskii.
14682 Also, simplify the allocation scheme, by avoiding the need for
14683 calling realloc, and removing the ALLOCATED variable.
14684
70476b54
PE
14685 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
14686
12020a9e
PE
14687 Remove invocations of doprnt, as Emacs now uses vsnprintf.
14688 But keep the doprint source code for now, as we might revamp it
14689 and use it again (Bug#8435).
ea6c7ae6
PE
14690 * lisp.h (doprnt): Remove.
14691 * Makefile.in (base_obj): Remove doprnt.o.
14692 * deps.mk (doprnt.o): Remove.
14693
5fdb398c
PE
14694 error: Print 32- and 64-bit integers portably (Bug#8435).
14695 Without this change, on typical 64-bit hosts error ("...%d...", N)
14696 was used to print both 32- and 64-bit integers N, which relied on
14697 undefined behavior.
61bdb816 14698 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
14699 * lisp.h (error, verror): Mark as printf-like functions.
14700 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
14701 Report overflow in size calculations when allocating printf buffer.
14702 Do not truncate output string at its first null byte.
14703 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
14704 Truncate the output at a character boundary, since vsnprintf does not
14705 do that.
14706 * charset.c (check_iso_charset_parameter): Convert internal
14707 character to string before calling 'error', since %c now has the
14708 printf meaning.
14709 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
14710 overflow when computing char to be passed to 'error'. Do not
14711 pass Lisp_Object to 'error'; pass the integer instead.
14712 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
14713 formatted with plain %d.
14714
b189fa66
PE
14715 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
14716
bff87ef0
PE
14717 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
14718
7e2cac20
PE
14719 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
14720
ce4d90b5
PE
14721 * xterm.c (x_catch_errors): Remove duplicate declaration.
14722
266c9547
PE
14723 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
14724
79c49ad2
PE
14725 * xdisp.c, lisp.h (message_nolog): Remove; unused.
14726
368f4090
JM
147272011-04-10 Jim Meyering <meyering@redhat.com>
14728
14729 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
14730 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
14731 return ssize_t not "int", and use size_t as the buffer length.
14732 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
14733 * gnutls.h: Update declarations.
14734 * process.c (read_process_output): Use ssize_t, to match.
14735 (send_process): Likewise.
14736
a32d4040
CY
147372011-04-09 Chong Yidong <cyd@stupidchicken.com>
14738
14739 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
14740
8546720e 147412011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 14742
04f2d78b
CB
14743 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
14744 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 14745
8546720e
GM
14746 * xterm.c (handle_one_xevent):
14747 * xmenu.c (create_and_show_popup_menu):
14748 * xselect.c (x_decline_selection_request)
14749 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 14750
0a2f5c1a 147512011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
14752
14753 Fix some uses of `int' instead of EMACS_INT.
14754 * search.c (string_match_1, fast_string_match)
14755 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
14756 (scan_buffer, find_next_newline_no_quit)
14757 (find_before_next_newline, search_command, Freplace_match)
14758 (Fmatch_data): Make some `int' variables be EMACS_INT.
14759
14760 * xdisp.c (display_count_lines): 3rd argument and return value now
14761 EMACS_INT. All callers changed.
14762 (pint2hrstr): Last argument is now EMACS_INT.
14763
14764 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
14765 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
14766 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
14767 (decode_coding_utf_16, decode_coding_emacs_mule)
14768 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
14769 (decode_coding_ccl, decode_coding_charset)
14770 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
14771 (decode_coding_iso_2022, decode_coding_emacs_mule)
14772 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
14773 <char_offset, last_offset>: Declare EMACS_INT.
14774 (encode_coding_utf_8, encode_coding_utf_16)
14775 (encode_coding_emacs_mule, encode_invocation_designation)
14776 (encode_designation_at_bol, encode_coding_iso_2022)
14777 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
14778 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
14779 Declare EMACS_INT.
14780 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
14781 (encode_invocation_designation): Last argument P_NCHARS is now
14782 EMACS_INT.
14783 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
14784 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
14785
14786 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
14787 All users changed.
14788
14789 * ccl.c (Fccl_execute_on_string): Declare some variables
14790 EMACS_INT.
14791
8546720e 147922011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
14793
14794 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
14795
4e19a977
CS
147962011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
14797
14798 * process.c (Fformat_network_address): Doc fix.
14799
87302331
R
148002011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
14801
ee7683eb 14802 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 14803
cbb59342
CY
148042011-04-08 Chong Yidong <cyd@stupidchicken.com>
14805
14806 * keyboard.c (read_char): Call Lisp function help-form-show,
14807 instead of using internal_with_output_to_temp_buffer.
14808 (Qhelp_form_show): New var.
e0d38eeb 14809 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
14810
14811 * print.c (internal_with_output_to_temp_buffer): Function deleted.
14812
14813 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
14814
e67a13ab
CY
148152011-04-06 Chong Yidong <cyd@stupidchicken.com>
14816
04f2d78b
CB
14817 * process.c (Flist_processes): Remove to Lisp.
14818 (list_processes_1): Delete.
e67a13ab 14819
973f782d
EZ
148202011-04-06 Eli Zaretskii <eliz@gnu.org>
14821
7c106b1e
EZ
14822 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
14823
973f782d
EZ
14824 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
14825
41cf7d1a 148262011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 14827
ca23cc88
PE
14828 Fix more problems found by GCC 4.6.0's static checks.
14829
f390e2d5
PE
14830 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
14831
42eea0d0
PE
14832 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
14833
b69769da 14834 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 14835
f9541e84
PE
14836 * xdisp.c (vmessage): Mark as a printf-like function.
14837
13841b55
PE
14838 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
14839
c136c10f
PE
14840 * sound.c (sound_warning): Don't crash if arg contains a printf format.
14841
5e2d4a30
PE
14842 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
14843 printf-like functions.
14844 (tiff_load): Add casts to remove these marks before passing them
14845 to system-supplied API.
14846
583f48b9
PE
14847 * eval.c (Fsignal): Remove excess argument to 'fatal'.
14848
b25d760e
PE
14849 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
14850 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
14851 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
14852 directly, rather than having caller test rule sign. This avoids
14853 some unnecessary tests.
14854 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
14855 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
14856 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 14857
bc7b6697 14858 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 14859 (xfont_open): Avoid unnecessary tests.
bc7b6697 14860
27ccc379
PE
14861 * composite.c (composition_gstring_put_cache): Use unsigned integer.
14862
dcd5c89a
PE
14863 * composite.h, composite.c (composition_gstring_put_cache):
14864 Use EMACS_INT, not int, for length.
14865
b13a45c6
PE
14866 * composite.h (COMPOSITION_DECODE_REFS): New macro,
14867 breaking out part of COMPOSITION_DECODE_RULE.
14868 (COMPOSITION_DECODE_RULE): Use it.
14869 * composite.c (get_composition_id): Remove unused local vars,
14870 by using the new macro.
14871
1e792e4d
PE
14872 * textprop.c (set_text_properties_1): Change while to do-while,
14873 since the condition is always true at first.
14874
dc6c6455 14875 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
14876 (interval_deletion_adjustment): Return unsigned value.
14877 All uses changed.
dc6c6455 14878
aba7731a
PE
14879 * process.c (list_processes_1, create_pty, read_process_output):
14880 (exec_sentinel): Remove vars that were set but not used.
afd4052b 14881 (create_pty): Remove unnecessary "volatile"s.
bc57d757 14882 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 14883 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 14884 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 14885
fdfc4bf3
PE
14886 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
14887
fca8fe46 14888 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 14889 (update_syntax_table): Use unsigned instead of int.
fca8fe46 14890
06a0259a 14891 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 14892 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 14893 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 14894
e7b9e80f
PE
14895 * print.c (print_error_message): Avoid int overflow.
14896
56201685
PE
14897 * font.c (font_list_entities): Redo for clarity,
14898 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
14899
78834453 14900 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 14901 (font_score): Avoid potential overflow in diff calculation.
78834453 14902
0bc0b309 14903 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 14904 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 14905
e610eaca
PE
14906 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14907
b895abce
PE
14908 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14909 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14910 can always succeed if overflow has undefined behavior.
14911
1f1d9321 14912 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14913 (wordify): Omit three unnecessary tests.
1f1d9321 14914
c59478bc
PE
14915 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14916 All callers changed. This avoids the need for an unused var.
14917
79b73827
PE
14918 * casefiddle.c (casify_region): Remove var that is set but not used.
14919
a4db5dfe
PE
14920 * dired.c (file_name_completion): Remove var that is set but not used.
14921
43aae36e
PE
14922 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14923
2a47c44d 14924 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14925 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14926
a37c69bf
PE
14927 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14928 Check for integer overflow on size calculations.
14929
328ab8e7
PE
14930 * buffer.c (Fprevious_overlay_change): Remove var that is set
14931 but not used.
14932
e5a2a5cb
PE
14933 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14934 Remove vars that are set but not used.
8d84a6eb 14935 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14936 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14937
a60e5f68
PE
14938 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14939
f661cb61 14940 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14941 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14942
f0397f5a
PE
14943 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14944 that are set but not used.
14945
8664db06 14946 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14947 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14948
6abdaa4a
PE
14949 * xselect.c (x_get_local_selection, x_handle_property_notify):
14950 Remove vars that are set but not used.
14951
0ce7538d 14952 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14953 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14954
9ae848fc
PE
14955 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14956 Remove var that is set but not used.
0b918413
PE
14957 (scroll_bar_windows_size): Now size_t, not int.
14958 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14959 Check for overflow.
9ae848fc 14960
a5a62657
PE
14961 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14962 (map_tty_color) [!defined MSDOS]: Likewise.
14963
5c5cdd39
PE
14964 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14965
66ebf983
PE
14966 * coding.c: Remove vars that are set but not used.
14967 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14968 All callers changed.
14969 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14970 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14971 (decode_coding_charset): Remove vars that are set but not used.
14972
1be4d761
PE
14973 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14974 that is set but not used.
14975
47553fa8
PE
14976 * print.c (print_object): Remove var that is set but not used.
14977
1f7196bf 14978 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14979 The gnulib version avoids calling malloc in the usual case,
14980 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14981 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14982 * filelock.c (current_lock_owner): Likewise.
14983 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14984 * sysdep.c: Include allocator.h, careadlinkat.h.
14985 (emacs_no_realloc_allocator): New static constant.
14986 (emacs_readlink): New function.
fdb61804
PE
14987 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14988 ../lib/careadlinkat.h.
d1fdcab7 14989
f84c17c7
SM
149902011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14991
14992 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14993 first non-nil return value).
14994
ef3862ad
JD
149952011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14996
14997 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14998 if not defined (Bug#8403).
14999
376a7006
JB
150002011-04-02 Juanma Barranquero <lekktu@gmail.com>
15001
15002 * xdisp.c (display_count_lines): Remove parameter `start',
15003 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15004 (get_char_face_and_encoding): Remove parameter `multibyte_p',
15005 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15006 (fill_stretch_glyph_string): Remove parameters `row' and `area',
15007 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
15008 and thereabouts. All callers changed.
15009 (get_per_char_metric): Remove parameter `f', unused since
15010 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15011
6ca3801d
JM
150122011-04-02 Jim Meyering <meyering@redhat.com>
15013
15014 do not dereference NULL upon failed strdup
15015 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
15016 (ns_get_family): Likewise.
15017
d8e2b5ba
JB
150182011-04-02 Juanma Barranquero <lekktu@gmail.com>
15019
15020 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
15021
8c74fcbd
JD
150222011-04-02 Jan Djärv <jan.h.d@swipnet.se>
15023
15024 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
15025 later (Bug#8403).
15026
7200d79c
SM
150272011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
15028
03408648 15029 Add lexical binding.
7200d79c 15030
03408648
SM
15031 * window.c (Ftemp_output_buffer_show): New fun.
15032 (Fsave_window_excursion):
15033 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
15034
15035 * lread.c (lisp_file_lexically_bound_p): New function.
15036 (Fload): Bind Qlexical_binding.
15037 (readevalloop): Remove `evalfun' arg.
15038 Bind Qinternal_interpreter_environment.
15039 (Feval_buffer): Bind Qlexical_binding.
15040 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
15041 Mark as dynamic.
15042 (syms_of_lread): Declare `lexical-binding'.
15043
15044 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
15045
15046 * keyboard.c (eval_dyn): New fun.
15047 (menu_item_eval_property): Use it.
ca105506
SM
15048
15049 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 15050
03408648
SM
15051 * fns.c (concat, mapcar1): Accept byte-code-functions.
15052
15053 * eval.c (Fsetq): Handle lexical vars.
15054 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
15055 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
15056 (FletX, Flet): Obey lexical binding.
15057 (Fcommandp): Handle closures.
15058 (Feval): New `lexical' arg.
15059 (eval_sub): New function extracted from Feval. Use it almost
15060 everywhere where Feval was used. Look up vars in lexical env.
15061 Handle closures.
15062 (Ffunctionp): Move from subr.el.
15063 (Ffuncall): Handle closures.
15064 (apply_lambda): Remove `eval_flags'.
15065 (funcall_lambda): Handle closures and new byte-code-functions.
15066 (Fspecial_variable_p): New function.
15067 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
15068 but without exporting it to Lisp.
23aba0ea 15069
23aba0ea 15070 * doc.c (Fdocumentation, store_function_docstring):
03408648 15071 * data.c (Finteractive_form): Handle closures.
23aba0ea 15072
03408648
SM
15073 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
15074 interactive spec.
ba83908c 15075
04f2d78b
CB
15076 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
15077 New byte-codes.
03408648
SM
15078 (exec_byte_code): New function extracted from Fbyte_code to handle new
15079 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 15080
03408648 15081 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 15082
03408648 15083 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 15084
e2abce01
JB
150852011-03-31 Juanma Barranquero <lekktu@gmail.com>
15086
15087 * xdisp.c (redisplay_internal): Fix prototype.
15088
63696a73 150892011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 15090
63696a73 15091 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
15092 (try_scrolling): Use it when setting scroll_limit.
15093 Limit scrolling to 100 screen lines.
63696a73
EZ
15094 (redisplay_window): Even when falling back on "recentering",
15095 position point in the window according to scroll-conservatively,
15096 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
15097
15098 (try_scrolling): When point is above the window, allow searching
15099 as far as scroll_max, or one screenful, to compute vertical
15100 distance from PT to the scroll margin position. This prevents
15101 try_scrolling from unnecessarily failing when
15102 scroll-conservatively is set to a value slightly larger than the
15103 window height. Clean up the case of PT below the margin at bottom
15104 of window: scroll_max can no longer be INT_MAX. When aggressive
15105 scrolling is in use, don't let point enter the opposite scroll
15106 margin as result of the scroll.
15107 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
15108 threshold of 100 lines for never-recentering scrolling.
15109
e4cc2dfc
JB
151102011-03-31 Juanma Barranquero <lekktu@gmail.com>
15111
15112 * dispextern.h (move_it_by_lines):
15113 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
15114 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
15115 (message_log_check_duplicate): Remove parameters `prev_bol' and
15116 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15117 (redisplay_internal): Remove parameter `preserve_echo_area',
15118 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
15119
15120 * indent.c (Fvertical_motion):
15121 * window.c (window_scroll_pixel_based, Frecenter):
15122 Don't pass `need_y_p' to `move_it_by_lines'.
15123
1c470562
SM
151242011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
15125
44f230aa
SM
15126 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
15127 steal a few bits to be more compact.
15128 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
15129 Remove unneeded casts.
15130
1c470562
SM
15131 * bytecode.c (Fbyte_code): CAR and CDR can GC.
15132
888adce9
ZK
151332011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
15134
15135 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
15136 binding" message (bug#7967).
15137
f838ed7b
PE
151382011-03-30 Paul Eggert <eggert@cs.ucla.edu>
15139
77861b95
PE
15140 Fix more problems found by GCC 4.6.0's static checks.
15141
de6dbc14
PE
15142 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
15143 Remove unused local var.
15144
f838ed7b
PE
15145 * editfns.c (Fmessage_box): Remove unused local var.
15146
792c7b2b
PE
15147 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
15148 (note_mode_line_or_margin_highlight, note_mouse_highlight):
15149 Omit unused local vars.
c499e557 15150 * window.c (shrink_windows): Omit unused local var.
b01a1c29 15151 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
15152 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
15153 Omit unused local var.
15154
ba0165e1
PE
15155 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
15156 Don't assume string length fits in int.
32ad8845 15157 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 15158 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 15159
3c59b4c9
PE
15160 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
15161 instead of alloca (Bug#8344).
15162
a3eed478 15163 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 15164 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 15165
eb4d412d
PE
15166 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
15167
1658b401
PE
15168 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
15169 concerns.
15170
15171 * term.c (produce_glyphless_glyph): Remove unnecessary test.
15172
15173 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 15174
9a2c6e05
PE
15175 * keyboard.c (syms_of_keyboard): Use the same style as later
15176 in this function when indexing through an array. This also
15177 works around GCC bug 48267.
15178
03d0a109
PE
15179 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
15180
44f730c8
PE
15181 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
15182
fe75f926
PE
15183 * chartab.c (sub_char_table_ref_and_range): Redo for slight
15184 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
15185
ffa8c828
PE
15186 * keyboard.c, keyboard.h (num_input_events): Now size_t.
15187 This avoids undefined behavior on integer overflow, and is a bit
15188 more convenient anyway since it is compared to a size_t variable.
15189
c5101a77
PE
15190 Variadic C functions now count arguments with size_t, not int.
15191 This avoids an unnecessary limitation on 64-bit machines, which
15192 caused (substring ...) to crash on large vectors (Bug#8344).
15193 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
15194 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 15195 All variadic functions and their callers changed accordingly.
c5101a77
PE
15196 (struct gcpro.nvars): Now size_t, not int. All uses changed.
15197 * data.c (arith_driver, float_arith_driver): Likewise.
15198 * editfns.c (general_insert_function): Likewise.
15199 * eval.c (struct backtrace.nargs, interactive_p)
15200 (internal_condition_case_n, run_hook_with_args, apply_lambda)
15201 (funcall_lambda, mark_backtrace): Likewise.
15202 * fns.c (concat): Likewise.
15203 * frame.c (x_set_frame_parameters): Likewise.
15204 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
15205 0 if not found, not -1. All callers changed.
15206
dd3f25f7
PE
15207 * alloc.c (garbage_collect): Don't assume stack size fits in int.
15208 (stack_copy_size): Now size_t, not int.
15209 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
15210
461c2ab9
JB
152112011-03-28 Juanma Barranquero <lekktu@gmail.com>
15212
15213 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
15214 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15215 All callers changed.
15216
15217 * lisp.h (multibyte_char_to_unibyte):
15218 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
15219 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15220 * character.h (CHAR_TO_BYTE8):
15221 * cmds.c (internal_self_insert):
15222 * editfns.c (general_insert_function):
15223 * keymap.c (push_key_description):
15224 * search.c (Freplace_match):
15225 * xdisp.c (message_dolog, set_message_1): All callers changed.
15226
f6d62986
SM
152272011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
15228
15229 * keyboard.c (safe_run_hook_funcall): New function.
15230 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
15231 don't set the hook to nil, but remove the offending function instead.
15232 (Qcommand_hook_internal): Remove, unused.
15233 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
15234 Vcommand_hook_internal.
15235
15236 * eval.c (enum run_hooks_condition): Remove.
15237 (funcall_nil, funcall_not): New functions.
15238 (run_hook_with_args): Call each function through a `funcall' argument.
15239 Remove `cond' argument, now redundant.
15240 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
15241 (Frun_hook_with_args_until_failure): Adjust accordingly.
15242 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
15243
1db5b1ad
JB
152442011-03-28 Juanma Barranquero <lekktu@gmail.com>
15245
15246 * dispextern.h (string_buffer_position): Remove declaration.
15247
15248 * print.c (strout): Remove parameter `multibyte', unused since
15249 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
15250
15251 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
15252 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
15253 All callers changed.
15254
15255 * w32.c (_wsa_errlist): Use braces for struct initializers.
15256
15257 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
15258 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
15259 All callers changed.
15260 (string_buffer_position): Likewise. Also, make static (it's never
15261 used outside xdisp.c).
15262 (cursor_row_p): Remove parameter `w', unused since
15263 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
15264 (decode_mode_spec): Remove parameter `precision', introduced during
15265 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
15266 All callers changed.
15267
5ffb62aa
JD
152682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15269
15270 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
15271
461c2ab9 152722011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
15273
15274 * nsterm.m (ns_menu_bar_is_hidden): New variable.
15275 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
15276 (ns_update_auto_hide_menu_bar): New functions.
15277 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
15278 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
15279 ns_constrain_all_frames.
15280 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
15281 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
15282
5c380ffb
JD
152832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15284
15285 * nsmenu.m (runDialogAt): Remove argument to timer_check.
15286
9af30bdf
GM
152872011-03-27 Glenn Morris <rgm@gnu.org>
15288
15289 * syssignal.h: Replace RETSIGTYPE with void.
15290 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
15291 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
15292 Replace SIGTYPE with void everywhere.
15293 * s/usg5-4-common.h (SIGTYPE): Remove definition.
15294 * s/template.h (SIGTYPE): Remove commented out definition.
15295
e2abce01
JB
152962011-03-26 Eli Zaretskii <eliz@gnu.org>
15297
15298 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
15299 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
15300
f868cd8a
JB
153012011-03-26 Juanma Barranquero <lekktu@gmail.com>
15302
59eb0929
JB
15303 * w32.c (read_unc_volume): Use parameter `henum', instead of
15304 global variable `wget_enum_handle'.
15305
15306 * keymap.c (describe_vector): Remove parameters `indices' and
15307 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
15308 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
15309
f868cd8a
JB
15310 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
15311
15312 * keyboard.c (timer_check): Remove parameter `do_it_now',
15313 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
15314 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
15315 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
15316
15317 * keyboard.c (read_char):
15318 * w32menu.c (w32_menu_display_help):
15319 * xmenu.c (show_help_event, menu_help_callback):
15320 Adjust calls to `show_help_echo'.
15321
15322 * gtkutil.c (xg_maybe_add_timer):
15323 * keyboard.c (readable_events):
15324 * process.c (wait_reading_process_output):
15325 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
15326
15327 * insdel.c (adjust_markers_gap_motion):
15328 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
15329 (gap_left, gap_right): Don't call it.
15330
2ecf6fdb
CY
153312011-03-25 Chong Yidong <cyd@stupidchicken.com>
15332
15333 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
15334 incurred during fontification.
15335
6b1f9ba4
JB
153362011-03-25 Juanma Barranquero <lekktu@gmail.com>
15337
15338 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
15339 (DEFVAR_PER_BUFFER): Don't pass it.
15340
15341 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
15342 (scrolling_window): Don't pass it.
15343
0f4a96b5
JB
153442011-03-25 Juanma Barranquero <lekktu@gmail.com>
15345
15346 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
15347
15348 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
15349 and `suffix'.
15350 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
15351 of variables specific to SELinux and computation of `encoded_absname'.
15352
15353 * image.c (XPutPixel): Remove unused variable `height'.
15354
15355 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
15356
15357 * unexw32.c (get_section_info): Remove unused variable `section'.
15358
15359 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
15360 (system_process_attributes): Remove unused variable `sess'.
15361 (sys_read): Remove unused variable `err'.
15362
15363 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
15364 (w32_wnd_proc): Remove unused variable `isdead'.
15365 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
15366 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
15367 (x_create_tip_frame): Remove unused variable `tem'.
15368
15369 * w32inevt.c (w32_console_read_socket):
15370 Remove unused variable `no_events'.
15371
15372 * w32term.c (x_draw_composite_glyph_string_foreground):
15373 Remove unused variable `width'.
15374
1149507c
JB
153752011-03-24 Juanma Barranquero <lekktu@gmail.com>
15376
15377 * w32term.c (x_set_glyph_string_clipping):
15378 Don't pass uninitialized region to CombineRgn.
15379
9c88f339
JB
153802011-03-23 Juanma Barranquero <lekktu@gmail.com>
15381
15382 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
15383 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
15384 (Fx_close_connection): Remove unused variable `i'.
15385
15386 * w32font.c (w32font_draw): Return number of glyphs.
15387 (w32font_open_internal): Remove unused variable `i'.
15388 (w32font_driver): Add missing initializer.
15389
15390 * w32menu.c (utf8to16): Remove unused variable `utf16'.
15391 (fill_in_menu): Remove unused variable `items_added'.
15392
15393 * w32term.c (last_mouse_press_frame): Remove static global variable.
15394 (w32_clip_to_row): Remove unused variable `f'.
15395 (x_delete_terminal): Remove unused variable `i'.
15396
15397 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
15398 (NOTHING): Remove unused static global variable.
15399 (uniscribe_check_otf): Remove unused variable `table'.
15400 (uniscribe_font_driver): Add missing initializers.
15401
dee091a3
JD
154022011-03-23 Julien Danjou <julien@danjou.info>
15403
15404 * term.c (Fsuspend_tty, Fresume_tty):
15405 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
15406 * window.c (temp_output_buffer_show):
15407 * insdel.c (signal_before_change):
15408 * frame.c (Fhandle_switch_frame):
15409 * fileio.c (Fdo_auto_save):
15410 * emacs.c (Fkill_emacs):
15411 * editfns.c (save_excursion_restore):
15412 * cmds.c (internal_self_insert):
15413 * callint.c (Fcall_interactively):
15414 * buffer.c (Fkill_all_local_variables):
15415 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
15416 Use Frun_hooks.
0f4a96b5 15417 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 15418 unconditionally since it does the check itself.
dee091a3 15419
2c520ab5 154202011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 15421
c9c49752
PE
15422 Fix more problems found by GCC 4.5.2's static checks.
15423
8abc3f12
PE
15424 * coding.c (encode_coding_raw_text): Avoid unnecessary test
15425 the first time through the loop, since we know p0 < p1 then.
15426 This also avoids a gcc -Wstrict-overflow warning.
15427
a2d26660
PE
15428 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
15429 leading to a memory leak, possible in functions like
15430 load_charset_map_from_file that can allocate an unbounded number
b12ef411 15431 of objects (Bug#8318).
a2d26660 15432
916c72e9
PE
15433 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
15434 that could (at least in theory) be that large.
15435
19ab8a18
PE
15436 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
15437 This is less likely to overflow, and avoids undefined behavior if
15438 overflow does occur. All callers changed. Use strtoul to scan
15439 for the unsigned long integer.
b7cbbd6f
PE
15440 (pint2hrstr): Simplify and tune code slightly.
15441 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 15442
f0641eff
PE
15443 * scroll.c (do_scrolling): Work around GCC bug 48228.
15444 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
15445
7f650bb9
PE
15446 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
15447 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
15448 (validate_x_resource_name): Simplify count usage.
15449 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 15450
37dd57d1
PE
15451 * fileio.c (Fcopy_file): Report error if fchown or fchmod
15452 fail (Bug#8306).
81e56e61 15453
699979fc 15454 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 15455
401bf9b4
PE
15456 * process.c (Fmake_network_process): Use socklen_t, not int,
15457 where POSIX says socklen_t is required in portable programs.
15458 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 15459 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
15460 (Fmake_network_process, server_accept_connection):
15461 (wait_reading_process_output, read_process_output):
15462 Likewise.
15463
b93aacde
PE
15464 * process.c: Rename or move locals to avoid shadowing.
15465 (list_processes_1, Fmake_network_process):
15466 (read_process_output_error_handler, exec_sentinel_error_handler):
15467 Rename or move locals.
4dc343ee 15468 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 15469 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 15470 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 15471 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 15472 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 15473
af8a867c 15474 Make tparam.h and terminfo.c consistent.
44f230aa
SM
15475 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
15476 Include tparam.h instead, since it declares them.
af8a867c
PE
15477 * cm.h (PC): Remove extern decl; tparam.h now does this.
15478 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
15479 * terminfo.c: Include tparam.h, to check interfaces.
15480 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
15481 (tparam): Adjust signature to match interface in tparam.h;
15482 this removes some undefined behavior. Check that outstring and len
15483 are zero, which they always are with Emacs.
15484 * tparam.h (PC, BC, UP): New extern decls.
15485
0248044d 15486 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 15487 (xftfont_open): Rename locals to avoid shadowing.
0248044d 15488
8ff096c1 15489 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
15490 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
15491 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 15492 (ftfont_list): Remove unused local.
49eaafba
PE
15493 (get_adstyle_property, ftfont_pattern_entity):
15494 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
15495 Rename locals to avoid shadowing.
8ff096c1 15496
e2be39f6
PE
15497 * xfont.c (xfont_list_family): Mark var as initialized.
15498
c9735e30
PE
15499 * xml.c (make_dom): Now static.
15500
8f5201ae
PE
15501 * composite.c (composition_compute_stop_pos): Rename local to
15502 avoid shadowing.
b246f932
PE
15503 (composition_reseat_it): Remove unused locals.
15504 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 15505 (composition_update_it): Mark var as initialized.
11b61122
PE
15506 (find_automatic_composition): Mark vars as initialized,
15507 with a FIXME (Bug#8290).
8f5201ae 15508
760fbc2c
PE
15509 character.h: Rename locals to avoid shadowing.
15510 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
15511 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
15512 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
15513 (BUF_DEC_POS): Be more systematic about renaming local temporaries
15514 to avoid shadowing.
15515
ff08eb85
PE
15516 * textprop.c (property_change_between_p): Remove; unused.
15517
fc7bf025
PE
15518 * intervals.c (interval_start_pos): Now static.
15519
235d7abc
PE
15520 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
15521
44f230aa
SM
15522 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
15523 Rename locals to avoid shadowing.
3e7d6594 15524
50060332
PE
15525 * sound.c (wav_play, au_play, Fplay_sound_internal):
15526 Fix pointer signedness.
d01f234b 15527 (alsa_choose_format): Remove unused local var.
c83b8872
PE
15528 (wav_play): Initialize a variable to 0, to prevent undefined
15529 behavior (Bug#8278).
50060332 15530
c4fc4e30
PE
15531 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
15532
918436ed
PE
15533 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
15534
c939f91b
PE
15535 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
15536 clobbering (Bug#8298).
b9c7f648
PE
15537 * sysdep.c (sys_subshell): Likewise.
15538 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 15539
6bd8c144
PE
15540 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
15541 This should get cleaned up, so that child_setup has the
15542 same signature on all platforms.
15543
7710357c 15544 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 15545 (relocate_fd): Rename locals to avoid shadowing.
7710357c 15546
c59da222
CY
155472011-03-22 Chong Yidong <cyd@stupidchicken.com>
15548
15549 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
15550 not to be necessary, and produces flickering.
15551
66b87493
GM
155522011-03-20 Glenn Morris <rgm@gnu.org>
15553
15554 * config.in: Remove file.
15555
45b6f6d5
JB
155562011-03-20 Juanma Barranquero <lekktu@gmail.com>
15557
15558 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
15559 are now in src/globals.h.
15560 (syms_of_minibuf): Remove spurious & from previous change.
15561
cd394be1 155622011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
15563
15564 * minibuf.c (completing-read-function): New variable.
15565 (completing-read-default): Rename from completing-read.
15566 (completing-read): Call completing-read-function.
15567
b14e3e21
CY
155682011-03-19 Juanma Barranquero <lekktu@gmail.com>
15569
15570 * xfaces.c (Fx_load_color_file):
15571 Read color file from absolute filename (bug#8250).
15572
f2b726e6
JB
155732011-03-19 Juanma Barranquero <lekktu@gmail.com>
15574
15575 * makefile.w32-in: Update dependencies.
15576
09f6ff02
EZ
155772011-03-17 Eli Zaretskii <eliz@gnu.org>
15578
15579 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
15580
29a6015a
PE
155812011-03-17 Paul Eggert <eggert@cs.ucla.edu>
15582
a3a6c54e
PE
15583 Fix more problems found by GCC 4.5.2's static checks.
15584
b766f867
PE
15585 * process.c (make_serial_process_unwind, send_process_trap):
15586 (sigchld_handler): Now static.
15587
be02381c
PE
15588 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
15589 That way, the code declares only the vars that it needs.
15590 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
15591 * s/cygwin.h (PTY_ITERATION): Likewise.
15592 * s/darwin.h (PTY_ITERATION): Likewise.
15593 * s/gnu-linux.h (PTY_ITERATION): Likewise.
15594
57048744
PE
15595 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
15596 * process.c (allocate_pty): Don't declare stb unless it's needed.
15597
7914961c 15598 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
15599 (CONSTANTLIM): Remove; unused.
15600 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
15601 Define only if needed.
7914961c 15602
b3967b18
PE
15603 * unexelf.c (unexec): Name an expression,
15604 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
15605 Use a different way to cause a compilation error if anyone uses
15606 n rather than nn, a way that does not involve shadowing.
73366a00 15607 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 15608
29a6015a
PE
15609 * deps.mk (unexalpha.o): Remove; unused.
15610
43cfc33e 15611 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 15612 * unexec.h: New file.
ce701a33
PE
15613 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
15614 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
15615 Depend on unexec.h.
15616 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
15617 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
15618 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 15619 Change as necessary to match prototype in unexec.h.
ce701a33 15620
01f44d5a
PE
15621 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
15622 shadowing.
4f63c6bb 15623 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 15624
a6670b0b
PE
15625 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
15626 Rename locals to avoid shadowing.
15627
cef2010d 15628 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 15629 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 15630
d4d7173a
PE
15631 * print.c (Fredirect_debugging_output): Fix pointer signedess.
15632
f08b802a
PE
15633 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
15634 warning when compiling print.c.
15635
3ddb0639
PE
15636 * font.c (font_unparse_fcname): Abort in an "impossible" situation
15637 instead of using an uninitialized var.
5ad03b97 15638 (font_sort_entities): Mark var as initialized.
3ddb0639 15639
170a2692
PE
15640 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
15641
e663c700
PE
15642 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
15643 pointers to constants.
89bc529a 15644 (font_parse_fcname): Remove unused vars.
7b81e2d0 15645 (font_delete_unmatched): Now static.
ea838e10 15646 (font_get_spec): Remove; unused.
13a547c6
PE
15647 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
15648 (font_update_drivers, Ffont_get_glyphs, font_add_log):
15649 Rename or move locals to avoid shadowing.
e663c700 15650
2a80c887 15651 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 15652 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 15653
1384fa33 15654 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 15655 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 15656
8b2c52e9
PE
15657 * alloc.c (mark_backtrace): Move decl from here ...
15658 * lisp.h: ... to here, so that it can be checked.
15659
475545b5 15660 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 15661 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
15662 (lisp_indirect_variable): Name an expression,
15663 to avoid gcc -Wbad-function-cast warning.
1faed8ae 15664 (Fdefvar): Rename locals to avoid shadowing.
475545b5 15665
b1349114 15666 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 15667 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 15668 Use const pointer when appropriate.
b1349114 15669
a2928364
PE
15670 * lisp.h (get_system_name, get_operating_system_release):
15671 Move decls here, to check interfaces.
15672 * process.c (get_operating_system_release): Move decl to lisp.h.
15673 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
15674 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
15675 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
15676 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
15677 (Fformat_time_string, Fencode_time, Finsert_char):
15678 (Ftranslate_region_internal, Fformat):
15679 Rename or remove local vars to avoid shadowing.
9710023e 15680 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 15681
a415e694
PE
15682 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
15683 avoid shadowing.
15684
8ef4622d
PE
15685 * lisp.h (eassert): Check that the argument compiles, even if
15686 ENABLE_CHECKING is not defined.
15687
946f9a5b
PE
15688 * data.c (Findirect_variable): Name an expression, to avoid
15689 gcc -Wbad-function-cast warning.
112396d6 15690 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 15691 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
15692 (Fmake_variable_buffer_local, Fmake_local_variable):
15693 Mark variables as initialized.
52746918 15694 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 15695
e5aab7e7 15696 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
15697 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
15698 Rename locals to avoid shadowing.
dff45157
PE
15699 (mark_stack): Move local variables into the #ifdef region where
15700 they're used.
7bc26fdb
PE
15701 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
15702 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
15703 needed otherwise.
15704 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
15705 (GC_STRING_CHARS): Remove; not used.
d40d4be1 15706 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 15707
e5aab7e7
PE
15708 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
15709 avoids undefined behavior in theory.
15710
4da60324
PE
15711 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
15712
88043301
PE
15713 Use functions, not macros, for up- and down-casing (Bug#8254).
15714 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15715 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
15716 to use the following functions instead of these macros.
15717 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
15718 EMACS_INT, since callers assume the returned value fits in int.
15719 (upcase1): Likewise, for UPCASE_TABLE.
15720 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 15721 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 15722 the race-condition problem in the old DOWNCASE.
88043301 15723
19ed5445
PE
15724 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
15725 Rename locals to avoid shadowing.
15726 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
15727 (regex_compile, re_search_2, re_match_2_internal):
15728 Remove unused local vars.
952db0d7
PE
15729 (FREE_VAR): Rewrite so as not to use empty "else",
15730 which gcc can warn about.
da053e48 15731 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
15732 (RETALLOC_IF): Define only if needed.
15733 (WORDCHAR_P): Likewise. This one is never needed, but is used
15734 only in a comment talking about a compiler bug, so put inside
15735 the #if 0 of that comment.
15736 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
15737 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
15738 Remove; unused.
19ed5445 15739
1f3561e4 15740 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
15741 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
15742 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 15743
ded6f8f7
PE
15744 * search.c (simple_search): Remove unused var.
15745
dbd37a95
PE
15746 * dired.c (compile_pattern): Move decl from here ...
15747 * lisp.h: ... to here, so that it can be checked.
15748 (struct re_registers): New forward decl.
15749
7e47afad
PE
15750 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
15751
85f24f61
PE
15752 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
15753 All uses changed.
15754 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
15755 Rename locals to avoid shadowing.
5671df8f 15756 (Fvertical_motion): Mark locals as initialized.
85f24f61 15757
181aa2be 15758 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 15759 (casify_region): Mark local as initialized.
181aa2be 15760
930d429c
PE
15761 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
15762
7082eac6
PE
15763 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
15764 New macros, so that the caller can use some names other than
15765 gcpro1, gcpro2, etc.
15766 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
15767 of the new macros.
15768 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
15769 argument, for consistency with GCPRO2_VAR, etc: it is now the
15770 prefix of the variable, not the variable itself. All uses
15771 changed.
38b2c076
PE
15772 * dired.c (directory_files_internal, file_name_completion):
15773 Rename locals to avoid shadowing.
15774
15206ed9
PE
15775 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
15776 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
15777 dired.c's scmp function, had undefined behavior.
15778 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15779 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
15780 * buffer.h: ... to here, because these macros use current_buffer,
15781 and the new implementation with inline functions needs to have
15782 current_buffer in scope now, rather than later when the macros
15783 are used.
15784 (downcase, upcase1): New static inline functions.
15785 (DOWNCASE, UPCASE1): Reimplement using these functions.
15786 This avoids undefined behavior in expressions like
15787 DOWNCASE (x) == DOWNCASE (y), which previously suffered
15788 from race conditions in accessing the global variables
15789 case_temp1 and case_temp2.
15790 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
15791 * lisp.h (case_temp1, case_temp2): Remove their decls.
15792 * character.h (ASCII_CHAR_P): Move from here ...
15793 * lisp.h: ... to here, so that the inline functions mentioned
15794 above can use them.
15795
4a6bea26
PE
15796 * dired.c (directory_files_internal_unwind): Now static.
15797
f14b7e14
PE
15798 * fileio.c (file_name_as_directory, directory_file_name):
15799 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
15800 Now static.
2893f146
PE
15801 (file_name_as_directory): Use const pointers when appropriate.
15802 (Fexpand_file_name): Likewise. In particular, newdir might
15803 point at constant storage, so make it a const pointer.
fd4ead52 15804 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
15805 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
15806 signedness issues.
f839df0c
PE
15807 (Fset_file_times, Finsert_file_contents, auto_save_error):
15808 Rename locals to avoid shadowing.
f14b7e14 15809
5716756e 15810 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
15811 (Ftry_completion, Fall_completions): Rename or remove locals
15812 to avoid shadowing.
5716756e 15813
b4c3046a
PE
15814 * marker.c (bytepos_to_charpos): Remove; unused.
15815
b45db522
PE
15816 * lisp.h (verify_bytepos, count_markers): New decls,
15817 so that gcc does not warn that these functions aren't declared.
15818
85876d07
PE
15819 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
15820 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 15821 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 15822 (copy_text): Remove unused local var.
85876d07 15823
03d78a21 15824 * filelock.c (within_one_second): Now static.
b3dd38ab 15825 (lock_file_1): Rename local to avoid shadowing.
03d78a21 15826
5df8f01b
PE
15827 * buffer.c (fix_overlays_before): Mark locals as initialized.
15828 (fix_start_end_in_overlays): Likewise. This function should be
15829 simplified by using pointers-to-pointers, but that's a different
15830 matter.
b1d876f1 15831 (switch_to_buffer_1): Now static.
8f54f30a
PE
15832 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
15833 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 15834
a70072c9 15835 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 15836 Fix pointer signedness issue.
edced198
PE
15837 (sys_subshell): Mark local as volatile if checking for lint,
15838 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 15839 (MAXPATHLEN): Define only if needed.
a70072c9 15840
a0977c44
PE
15841 * process.c (serial_open, serial_configure): Move decls from here ...
15842 * systty.h: ... to here, so that they can be checked.
15843
a884fdcc
PE
15844 * fns.c (get_random, seed_random): Move extern decls from here ...
15845 * lisp.h: ... to here, so that they can be checked.
15846
604efe86 15847 * sysdep.c (reset_io): Now static.
b8950c94 15848 (wait_for_termination_signal): Remove; unused.
604efe86 15849
38fc62d9
PE
15850 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
15851 (copy_keymap_item, append_key, push_text_char_description):
15852 Now static.
1004a21a 15853 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 15854 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
15855 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
15856 (describe_map_tree):
15857 Rename locals to avoid shadowing.
38fc62d9 15858
2f2650da
PE
15859 * keyboard.c: Declare functions static if they are not used elsewhere.
15860 (echo_char, echo_dash, cmd_error, top_level_2):
15861 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
15862 (read_char, kbd_buffer_get_event, make_lispy_position):
15863 (make_lispy_event, make_lispy_movement, apply_modifiers):
15864 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
15865 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
15866 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 15867 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 15868 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 15869
a053e86c 15870 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
15871 (mark_kboards): Move decl here ...
15872 * alloc.c (mark_kboards): ... from here.
a053e86c 15873
4752793e
PE
15874 * lisp.h (force_auto_save_soon): New decl.
15875
74f10ca7 15876 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
15877 (DEFINE_DUMMY_FUNCTION): New macro.
15878 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
15879 Use it.
c03cd23f
PE
15880 (main): Add casts to avoid warnings
15881 if GCC considers string literals to be constants.
74f10ca7 15882
022e70d4
PE
15883 * lisp.h (fatal_error_signal): Add decl, since it's exported.
15884
59d6fe83
PE
15885 * dbusbind.c: Pointer signedness fixes.
15886 (xd_signature, xd_append_arg, xd_initialize):
15887 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15888 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15889 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
15890 (Fdbus_register_signal): Use SSDATA when the context wants char *.
15891
78320123
PE
15892 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
15893 if GCC considers string literals to be constants.
49cebcca 15894 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 15895
35ac2a97
SM
158962011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
15897
fb103ca9
SM
15898 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
15899 (print_preprocess, print_object): New macro to fix last change.
15900
35ac2a97
SM
15901 * print.c (print_preprocess): Don't forget font objects.
15902
62973b41
JB
159032011-03-16 Juanma Barranquero <lekktu@gmail.com>
15904
15905 * emacs.c (USAGE3): Doc fixes.
15906
0e48bb22
AS
159072011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15908
15909 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15910 structure.
15911
7684e57b
JB
159122011-03-14 Juanma Barranquero <lekktu@gmail.com>
15913
15914 * lisp.h (VWindow_system, Qfile_name_history):
15915 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15916 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15917 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15918
15919 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15920 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15921
15922 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15923 * w32console.c (detect_input_pending, read_input_pending)
15924 (encode_terminal_code):
15925 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15926 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15927 (w32_system_caret_y, Qfile_name_history):
15928 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15929 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15930 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15931 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15932 * w32proc.c (Qlocal, report_file_error):
15933 * w32term.c (Vwindow_system, updating_frame):
15934 * w32uniscribe.c (initialized, uniscribe_font_driver):
15935 Remove unneeded extern declarations.
15936
2aa46d6c
CY
159372011-03-14 Chong Yidong <cyd@stupidchicken.com>
15938
c96bbc66 15939 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15940
cffc6f3b
CY
159412011-03-13 Chong Yidong <cyd@stupidchicken.com>
15942
15943 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15944 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15945 These macros can no longer be used for assignment.
15946
44f230aa
SM
15947 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15948 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15949 (record_buffer_markers, fetch_buffer_markers): New functions for
15950 recording and fetching special buffer markers.
15951 (set_buffer_internal_1, set_buffer_temp): Use them.
15952
15953 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15954
15955 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15956
15957 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15958 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15959
15960 * xdisp.c (hscroll_window_tree):
15961 (reconsider_clip_changes): Use PT instead of BUF_PT.
15962
d251f04b
EZ
159632011-03-13 Eli Zaretskii <eliz@gnu.org>
15964
15965 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15966 $(EMACS_ROOT)/lib/intprops.h.
15967
f0c77cd1
PE
159682011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15969
3eca4629
PE
15970 Fix more problems found by GCC 4.5.2's static checks.
15971
7c86ee98
PE
15972 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15973 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15974 (xg_free_frame_widgets): Make it clear that a local variable is
15975 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15976 (gdk_window_get_screen): Make it clear that this macro is needed
15977 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15978 (int_gtk_range_get_value): New function, which avoids a diagnostic
15979 from gcc -Wbad-function-cast.
15980 (xg_set_toolkit_scroll_bar_thumb): Use it.
15981 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15982 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15983 (get_utf8_string, xg_get_file_with_chooser):
15984 Rename locals to avoid shadowing.
15985 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15986
41729b81
PE
15987 * xgselect.c (xg_select): Remove unused var.
15988
f0c77cd1
PE
15989 * image.c (four_corners_best): Mark locals as initialized.
15990 (gif_load): Initialize transparent_p to zero (Bug#8238).
15991 Mark another local as initialized.
ec6cf4c6 15992 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15993
ce0ad53d 15994 * image.c (clear_image_cache): Now static.
d5d5a617 15995 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15996 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15997 (x_edge_detection): Remove unnecessary cast that
15998 gcc -Wbad-function-cast diagnoses.
2037898d 15999 (gif_load): Fix pointer signedness.
6ae141d6
PE
16000 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
16001 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 16002
33383987 160032011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 16004
d32df629
PE
16005 Improve quality of tests for time stamp overflow.
16006 For example, without this patch (encode-time 0 0 0 1 1
16007 1152921504606846976) returns the obviously-bogus value (-948597
16008 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
16009 reports time overflow. See
16010 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
16011 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
16012 * editfns.c: Include limits.h and intprops.h.
16013 (TIME_T_MIN, TIME_T_MAX): New macros.
16014 (time_overflow): Move earlier, to before first use.
16015 (hi_time, lo_time): New functions, for an accurate test for
16016 out-of-range times.
16017 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
16018 (Fget_internal_run_time): Don't assume time_t fits in int.
16019 (make_time): Use list2 instead of Fcons twice.
16020 (Fdecode_time): More accurate test for out-of-range times.
16021 (check_tm_member): New function.
16022 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
16023 (lisp_time_argument): Don't rely on undefined left-shift and
16024 right-shift behavior when checking for time stamp overflow.
8be6f318 16025
fe31d94c
PE
16026 * editfns.c (time_overflow): New function, refactoring common code.
16027 (Fformat_time_string, Fdecode_time, Fencode_time):
16028 (Fcurrent_time_string): Use it.
16029
8be6f318
PE
16030 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
16031 * dired.c (make_time): Move to ...
16032 * editfns.c (make_time): ... here.
16033 * systime.h: Note the move.
16034
09d9db2c 160352011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 16036
126bc0dc
YM
16037 * fringe.c (update_window_fringes): Remove unused variables.
16038
c47cbdfd
YM
16039 * unexmacosx.c (copy_data_segment): Also copy __got section.
16040 (Bug#8223)
16041
7ac80be9
EZ
160422011-03-12 Eli Zaretskii <eliz@gnu.org>
16043
c96bbc66 16044 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
16045 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
16046 Constify `char *' arguments and their references according to
16047 prototypes in tparam.h.
16048
ecb0f94d 16049 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 16050
7ac80be9
EZ
16051 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
16052 Adapt all references accordingly.
16053
16054 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
16055
ef1fd07e
TT
160562011-03-11 Tom Tromey <tromey@redhat.com>
16057
16058 * buffer.c (syms_of_buffer): Remove obsolete comment.
16059
7ef4b50c
EZ
160602011-03-11 Eli Zaretskii <eliz@gnu.org>
16061
16062 * termhooks.h (encode_terminal_code): Declare prototype.
16063
16064 * msdos.c (encode_terminal_code): Don't declare prototype.
16065
16066 * term.c (encode_terminal_code): Now external again, used by
16067 w32console.c and msdos.c.
16068
44f230aa
SM
16069 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
16070 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 16071
4b1ec863 160722011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 16073
1714f52b 16074 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 16075
4b1ec863
PE
16076 * fringe.c (update_window_fringes): Mark locals as initialized
16077 (Bug#8227).
16078 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 16079
524c7aa6
PE
16080 * alloc.c (mark_fringe_data): Move decl from here ...
16081 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
16082 to check its interface.
16083 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
16084
a5c0af81 16085 * fontset.c (free_realized_fontset): Now static.
7519b8cd 16086 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 16087 (fontset_font): Mark local as initialized.
a9a06e0b 16088 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 16089
b4716021
PE
16090 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
16091
811e9bac 16092 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 16093 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
16094 (x_own_selection, Fx_disown_selection_internal): Rename locals
16095 to avoid shadowing.
16096 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 16097
7e3ab302
PE
16098 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
16099 so that the caller can use some name other than gcpro1.
16100 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
16101 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16102 (Fx_backspace_delete_keys_p):
16103 Use them to avoid shadowing, and rename vars to avoid shadowing.
16104 (x_decode_color, x_set_name, x_window): Now static.
6b437900 16105 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 16106 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
16107 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
16108 Remove unused locals.
7e3ab302
PE
16109 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16110 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
16111 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
16112 macros.
f78faa98 16113
e2b13473
PE
16114 * xterm.h (x_mouse_leave): New decl.
16115
77f23912
PE
16116 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
16117 Remove unused functions.
cdf4ba58
PE
16118 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
16119 (x_calc_absolute_position): Now static.
7411c686 16120 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 16121 Don't declare local "event" unless it's used.
ed7bf3a5
PE
16122 (x_iconify_frame, x_free_frame_resources): Don't declare locals
16123 unless they are used.
38d0b34a
PE
16124 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
16125 (x_fatal_error_signal): Remove; not used.
a6067996
PE
16126 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
16127 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
16128 (x_error_catcher, x_connection_closed, x_error_handler):
16129 (x_error_quitter, xembed_send_message, x_iconify_frame):
16130 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 16131 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 16132 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 16133
44f230aa
SM
16134 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
16135 Rename or move locals to avoid shadowing.
6b463e58 16136 (tty_defined_color, merge_face_heights): Now static.
5967d051 16137 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
16138 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
16139 does not deduce is never used uninitialized.
73719eba
PE
16140 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
16141 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 16142
426994c3 16143 * terminal.c (store_terminal_param): Now static.
5489860b 16144
032f1620 16145 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 16146 (set_frame_menubar): Remove unused local.
d4323972 16147 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
16148 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
16149 since they might point to immutable storage.
281585b0
PE
16150 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
16151 since it's unused otherwise.
032f1620 16152
367c19e5 16153 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 16154 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
16155 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
16156 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 16157 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
16158 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
16159 does not deduce are never used uninitialized.
70739cbe 16160
07b48fa9
PE
16161 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
16162
8868a238 16163 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
16164 * window.c (window_loop, size_window):
16165 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 16166
7e5cf297 16167 * window.c (display_buffer): Now static.
d6550a9f
PE
16168 (size_window): Mark variables that gcc -Wuninitialized
16169 does not deduce are never used uninitialized.
a586633d
PE
16170 * window.h (check_all_windows): New decl, to forestall
16171 gcc -Wmissing-prototypes diagnostic.
5b555da1 16172 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 16173
f6095868
PE
16174 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
16175 shadowing.
16176 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
16177 Include <limits.h>.
16178 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
16179 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
16180 (load_charset_map): Mark variables that gcc -Wuninitialized
16181 does not deduce are never used uninitialized.
53df7c11 16182 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 16183
f38b440c
PE
16184 * coding.c (coding_set_source, coding_set_destination):
16185 Use "else { /* comment */ }" rather than "else /* comment */;"
16186 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
16187 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
16188 a block, when the outer 'i' will do.
16189 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
16190 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
16191 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
16192 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
16193 (Fdecode_sjis_char, Fdefine_coding_system_internal):
16194 Rename locals to avoid shadowing.
16195 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
16196 * coding.c (emacs_mule_char, encode_invocation_designation):
16197 Now static, since they're not used elsewhere.
413bb2db 16198 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 16199 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
16200 (decode_coding_emacs_mule): Mark variables that gcc
16201 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
16202 (detect_coding_iso_2022): Initialize a local variable that might
16203 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 16204 this initialization is needed. (Bug#8211)
5f58e762
PE
16205 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
16206 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
16207 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
16208 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
16209 Remove unused macros.
f38b440c 16210
232b38b9 16211 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 16212 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 16213 * character.c (string_count_byte8): Likewise.
232b38b9 16214
fb90da1b
PE
16215 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
16216 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
16217
fb93dbc2
PE
16218 * chartab.c (copy_sub_char_table): Now static, since it's not used
16219 elsewhere.
5c156ace
PE
16220 (sub_char_table_ref_and_range, char_table_ref_and_range):
16221 Rename locals to avoid shadowing.
bbcd0949 16222 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 16223
7d3b3862 16224 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 16225 (BIDI_BOB): Remove unused macro.
7d3b3862 16226
6be7d3da
PE
16227 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
16228 deduce are never used uninitialized.
c2ed9c8b 16229 * term.c (encode_terminal_code): Likewise.
6be7d3da 16230
75f8807f 16231 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 16232
50938595
PE
16233 * tparam.h: New file.
16234 * term.c, tparam.h: Include it.
16235 * deps.mk (term.o, tparam.o): Depend on tparam.h.
16236 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
16237 Move these decls to tparam.h, and make them agree with what
16238 is actually in tparam.c. The previous trick of using incompatible
16239 decls in different modules does not conform to the C standard.
16240 All callers of tparam changed to use tparam's actual API.
16241 * tparam.c (tparam1, tparam, tgoto):
16242 Use const pointers where appropriate.
16243
fbceeba2
PE
16244 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
16245 * cm.h (struct cm): Likewise.
16246 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
16247 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
16248 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
16249 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
16250 (turn_on_face, init_tty): Likewise.
16251 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 16252
7f3f1250
PE
16253 * term.c (term_mouse_position): Rename local to avoid shadowing.
16254
e6ca6543
PE
16255 * alloc.c (mark_ttys): Move decl from here ...
16256 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
16257
c40f8d15
AS
162582011-03-11 Andreas Schwab <schwab@linux-m68k.org>
16259
16260 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
16261
cfe0661d
JB
162622011-03-09 Juanma Barranquero <lekktu@gmail.com>
16263
16264 * search.c (compile_pattern_1): Remove argument regp, unused since
16265 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
16266 (compile_pattern): Don't pass it.
16267
0afb4571
J
162682011-03-08 Jan Djärv <jan.h.d@swipnet.se>
16269
16270 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
16271 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
16272 for ! HAVE_GTK3.
16273 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
16274
16275 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
16276
16277 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
16278 gdk_window_get_screen, gdk_window_get_geometry,
16279 gdk_x11_window_lookup_for_display and GDK_KEY_g.
16280 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
16281 (xg_get_pixbuf_from_pixmap): New function.
16282 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
16283 to Pixmap, take frame as parameter, remove GdkColormap parameter.
16284 Call xg_get_pixbuf_from_pixmap instead of
16285 gdk_pixbuf_get_from_drawable.
16286 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
16287 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
16288 (xg_check_special_colors): Use GtkStyleContext and its functions
16289 for HAVE_GTK3.
16290 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
16291 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
16292 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
16293 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
16294 Call gtk_widget_get_preferred_size.
0afb4571
J
16295 (xg_frame_resized): gdk_window_get_geometry only takes 5
16296 parameters.
44f230aa
SM
16297 (xg_win_to_widget, xg_event_is_for_menubar):
16298 Call gdk_x11_window_lookup_for_display.
0afb4571
J
16299 (xg_set_widget_bg): New function.
16300 (delete_cb): New function.
895009e1 16301 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 16302 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
16303 (xg_set_background_color): Call xg_set_widget_bg.
16304 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
16305 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
16306 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
16307 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
16308 if ! HAVE_GTK3.
16309 (update_frame_tool_bar): Call gtk_widget_hide.
16310 (xg_initialize): Use GDK_KEY_g.
16311
16312 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
16313 if ! HAVE_GTK3
16314 (x_session_initialize): Call gdk_x11_set_sm_client_id.
16315
16316 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
16317 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
16318 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
16319
1c2cc4ef
JB
163202011-03-08 Juanma Barranquero <lekktu@gmail.com>
16321
16322 * w32xfns.c (select_palette): Check success of RealizePalette against
16323 GDI_ERROR, not zero.
16324
33383987 16325See ChangeLog.11 for earlier changes.
aac0c6e3
MR
16326
16327;; Local Variables:
16328;; coding: utf-8
aac0c6e3
MR
16329;; End:
16330
2f097256 16331 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
16332
16333 This file is part of GNU Emacs.
16334
16335 GNU Emacs is free software: you can redistribute it and/or modify
16336 it under the terms of the GNU General Public License as published by
16337 the Free Software Foundation, either version 3 of the License, or
16338 (at your option) any later version.
16339
16340 GNU Emacs is distributed in the hope that it will be useful,
16341 but WITHOUT ANY WARRANTY; without even the implied warranty of
16342 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16343 GNU General Public License for more details.
16344
16345 You should have received a copy of the GNU General Public License
16346 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.