Fix previous fix of Bug#5849.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
56cd55c8
EZ
12011-09-18 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (display_line): Record maximum and minimum buffer
4 positions even if no glyphs were produced (e.g., by a zero-width
5 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6 buffer positions that will be removed from the glyph row because
7 they don't fit.
8
5ed99d36 92011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
10
11 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
12 and turn window cursor on if cleared (Bug#9415).
13
5ed99d36 142011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
15
16 * search.c (boyer_moore): Take unibyte characters from pattern
17 literally. (Bug#9458)
18
9bade7b2
EZ
192011-09-18 Eli Zaretskii <eliz@gnu.org>
20
21 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
22
e5e9d610
PE
232011-09-18 Paul Eggert <eggert@cs.ucla.edu>
24
87e4427a
PE
25 Fix minor problem found by static checking.
26 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
27 initialized, to pacify gcc -Wuninitialized.
28
e5e9d610
PE
29 * fileio.c: Report proper errno when syscall falls.
30 (Finsert_file_contents): Save and restore errno,
31 so that report_file_error outputs the correct diagnostic.
32 (Fwrite_region) [CLASH_DETECTION]: Likewise.
33
a1674f0b
EZ
342011-09-18 Eli Zaretskii <eliz@gnu.org>
35
36 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
37
fbfb6dd4
EZ
382011-09-17 Eli Zaretskii <eliz@gnu.org>
39
40 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
41 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
42
bb187662
EZ
432011-09-17 Eli Zaretskii <eliz@gnu.org>
44
1137e8b8
EZ
45 * xdisp.c (reseat_at_next_visible_line_start): Keep information
46 about the current paragraph and restore it after the call to
47 reseat.
48
49 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
50 (bidi_find_paragraph_start): Search back for paragraph beginning
51 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
52 (bidi_move_to_visually_next): Only trigger paragraph-related
53 computations when the last character is a newline or at EOB, not
54 just any NEUTRAL_B. (Bug#9470)
55
bb187662
EZ
56 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
57 truncated lines if point is covered by a display string. (Bug#9524)
58
2e621251
PE
592011-09-16 Paul Eggert <eggert@cs.ucla.edu>
60
61 * xselect.c: Relax test for outgoing X longs (Bug#9498).
62 (cons_to_x_long): New function.
63 (lisp_data_to_selection_data): Use it. Correct the test for
64 short-versus-long data; it was negated. Break out of vector
65 loop, for efficiency, when a long datum is discovered.
66
91a15bc6
SM
672011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
68
69 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
70
b41c3a35
EZ
712011-09-16 Eli Zaretskii <eliz@gnu.org>
72
73 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
74 GCC PR/17406) by declaring this function with external scope.
75
7812ba2d
PE
762011-09-15 Paul Eggert <eggert@cs.ucla.edu>
77
78 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
79 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
80
cf7edc2a
AS
812011-09-15 Andreas Schwab <schwab@linux-m68k.org>
82
83 * editfns.c (Fformat): Correctly handle text properties on "%%".
84
bd01620e
EZ
852011-09-15 Eli Zaretskii <eliz@gnu.org>
86
87 * xterm.c (x_draw_composite_glyph_string_foreground):
88 * w32term.c (x_draw_composite_glyph_string_foreground):
89 * term.c (encode_terminal_code):
90 * composite.c (composition_update_it, get_composition_id):
91 * xdisp.c (get_next_display_element)
92 (fill_composite_glyph_string): Add comments about special meaning
93 of TAB characters in a composition.
94
a02719a3
PE
952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
96
97 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
98 This occurs when processing a multibyte format.
99 Problem reported by Wolfgang Jenker.
a02719a3 100
72589a3c
JB
1012011-09-15 Johan Bockgård <bojohan@gnu.org>
102
103 * xdisp.c (try_cursor_movement): Only check for exact match if
104 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
105
1c14176c
PE
1062011-09-14 Paul Eggert <eggert@cs.ucla.edu>
107
108 Remove unused external symbols.
109 * dispextern.h (calc_pixel_width_or_height): Remove decl.
110 * xdisp.c (calc_pixel_width_or_height): Now static.
111 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
112 * indent.c (check_display_width):
113 * w32term.c: Fix comment to match code.
114 * xterm.c, xterm.h (x_catching_errors): Remove.
115
d2eea5b5
PE
1162011-09-14 Paul Eggert <eggert@cs.ucla.edu>
117
118 * xselect.c: Use signed conversions more consistently (Bug#9498).
119 (selection_data_to_lisp_data): Assume incoming selection data are
120 signed integers, not unsigned. This is to be consistent with
121 outgoing selection data, which was modified to use signed integers
122 in as part of the fix to Bug#9196 in response to Jan D.'s comment
123 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
124 expects long, not unsigned long.
125
46888499
EZ
1262011-09-14 Eli Zaretskii <eliz@gnu.org>
127
128 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
129 computation of loop end. Reported by Johan Bockgård
130 <bojohan@gnu.org>.
131
ef8ef9fb
CY
1322011-09-13 Chong Yidong <cyd@stupidchicken.com>
133
134 * frame.c (Fother_visible_frames_p): Function deleted.
135
fa819fed
EZ
1362011-09-12 Eli Zaretskii <eliz@gnu.org>
137
138 * indent.c (compute_motion): Process display vector front to back
139 rather than the other way around. (Bug#2496)
140
2ba8e008
SM
1412011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
142
143 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
144
20f53c69
CY
1452011-09-11 Chong Yidong <cyd@stupidchicken.com>
146
147 * minibuf.c (Fread_from_minibuffer): Doc fix.
148
d562d7a4
EZ
1492011-09-11 Eli Zaretskii <eliz@gnu.org>
150
151 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
152 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
153
1c4d7f3d
LMI
1542011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
155
156 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
157 value for non-existent files.
158
b885bf36
EZ
1592011-09-11 Eli Zaretskii <eliz@gnu.org>
160
161 * fileio.c (Finsert_file_contents): If the file cannot be opened,
162 set its "size" to -1. This will set the modtime_size field of
163 the corresponding buffer to -1, which is what
164 verify-visited-file-modtime expects for files that do not exist.
165 (Bug#9139)
166
6612f0bf
PE
1672011-09-11 Paul Eggert <eggert@cs.ucla.edu>
168
169 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
170 here ...
171 * lisp.h: ... from here. push_key_description is no longer
172 defined in keyboard.c, so its declaration should not be in
173 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
174 logically belongs with push_key_description.
175
dfb3f755
PE
1762011-09-10 Paul Eggert <eggert@cs.ucla.edu>
177
178 * buffer.h: Include <sys/types.h> instead of <time.h>.
179 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
180 Problem reported by Herbert J. Skuhra.
181
3134906c
LMI
1822011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
183
184 * xml.c (parse_region): Make the parsing work for
185 non-comment-starting XML files again (bug#9144).
186
8d903f4e
AS
1872011-09-10 Andreas Schwab <schwab@linux-m68k.org>
188
189 * image.c (gif_load): Fix calculation of bottom and right corner.
190 (Bug#9468)
191
80ad64f4
EZ
1922011-09-10 Eli Zaretskii <eliz@gnu.org>
193
194 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
195 redisplay in small windows.
196
208a048d
EZ
1972011-09-09 Eli Zaretskii <eliz@gnu.org>
198
199 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
200
9b1c252e
MR
2012011-09-08 Martin Rudalics <rudalics@gmx.at>
202
203 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
204 Operate on live windows only.
205
2949f33b
JB
2062011-09-08 Juanma Barranquero <lekktu@gmail.com>
207
208 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
209
e08dcafd
EZ
2102011-09-07 Eli Zaretskii <eliz@gnu.org>
211
212 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
213 only under bidi iteration.
214
115b96bd
JD
2152011-09-07 Jan Djärv <jan.h.d@swipnet.se>
216
217 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
218
c8199d0f
PE
2192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
220
221 isnan: Fix porting problem to Solaris 10 with bundled gcc.
222 Without this fix, the command to link temacs failed due to an
223 undefined symbol __builtin_isnan. This is because
224 /usr/include/iso/math_c99.h #defines isnan(x) to
225 __builtin_isnan(x), but the bundled gcc, which identifies itself
226 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
227 a __builtin_isnan.
228 * floatfns.c (isnan): #undef, and then #define to a clone of
229 what's in data.c.
230 (Fisnan): Always define, since it's always available now.
231 (syms_of_floatfns): Always define isnan at the Lisp level.
232
e39b275c 2332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
234
235 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
236
b2db44d9 2372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 238
f4af5137 239 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
240 The previous code assumed that file offsets (off_t values) fit in
241 EMACS_INT variables, which is not true on typical 32-bit hosts.
242 The code messed up by falsely reporting buffer overflow in cases
243 such as (insert-file-contents "big" nil 1 2) into an empty buffer
244 when "big" contains more than 2**29 bytes, even though this
245 inserts just one byte and does not overflow the buffer.
246 (Finsert_file_contents): Store file offsets as off_t
247 values, not as EMACS_INT values. Check for overflow when
248 converting between EMACS_INT and off_t. When checking for
249 buffer overflow or for overlap, take the offsets into account.
250 Don't use EMACS_INT for small values where int suffices.
251 When checking for overlap, fix a typo: ZV was used where
252 ZV_BYTE was intended.
253 (Fwrite_region): Don't assume off_t fits into 'long'.
254 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
255
ecfc0a49
MA
2562011-09-05 Michael Albinus <michael.albinus@gmx.de>
257
258 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
259
6511acf2 2602011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 261
0999621a 262 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
263
264 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 265 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
266 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
267 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
268 (modify_event_symbol): Do not assume that the length of
269 name_alist_or_stem is safe to alloca and fits in int.
270 (Fexecute_extended_command): Likewise for function name and binding.
271 (Frecursion_depth): Wrap around reliably on integer overflow.
272 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
273 since some callers pass EMACS_INT values.
274 (Fsingle_key_description): Don't crash if symbol name contains more
275 than MAX_ALLOCA bytes.
276 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
277 (get_minibuffer): Arg is now EMACS_INT, not int.
278 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 279 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
280 * window.h (command_loop_level, minibuf_level): Reflect API changes.
281
2be7d702
PE
282 * dbusbind.c (signature_cat): New function.
283 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
284 Do not overrun buffer; instead, report string overflow.
285
9d1df220
PE
286 * dispnew.c (add_window_display_history): Don't overrun buffer.
287 Truncate instead; this is OK since it's just a log.
288
33ef5c64
PE
289 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
290 even if the time zone offset is outlandishly large.
291 Don't mishandle offset == INT_MIN.
292
66c6fdd5
PE
293 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
294 when creating daemon; the previous buffer-overflow check was incorrect.
295
d749b01b
PE
296 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
297 which has the guts of the old verror function.
298
b5cd1905
PE
299 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
300 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
301
6e1a67fb
PE
302 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
303 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 304 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 305 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
306 length of string rather than counting it via multiple sprintfs;
307 that's simpler and more reliable.
c21721cc
PE
308 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
309 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
310 sprintf, in case result does not fit in int.
311
c57b67fc
PE
312 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
313 (fontset_from_font): Print it.
314
8a401434
PE
315 * frame.c (tty_frame_count): Now printmax_t, not int.
316 (make_terminal_frame, set_term_frame_name): Print it.
317 (x_report_frame_params): In X, window IDs are unsigned long,
318 not signed long, so print them as unsigned.
319 (validate_x_resource_name): Check for implausibly long names,
320 and don't assume name length fits in 'int'.
321 (x_get_resource_string): Don't blindly alloca invocation name;
322 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
323 not fit in int.
324
6e1a67fb
PE
325 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
326 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
327 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
328
0df02bf3
PE
329 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
330 Use esprintf, not sprintf, in case result does not fit in int.
331
48e30793
PE
332 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
333 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
334 it as a large positive number.
335 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
336 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
337
a66ff6d8
PE
338 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
339 in case result does not fit in int.
340
aca216ff
PE
341 * print.c (float_to_string): Detect width overflow more reliably.
342 (print_object): Make sprintf buffer a bit bigger, to avoid potential
343 buffer overrun. Don't assume list length fits in 'int'. Treat
344 print length of 0 as 0, not as infinity; to be consistent with other
345 uses of print length in this function. Don't overflow print length
346 index. Don't assume hash table size fits in 'long', or that
347 vectorlike size fits in 'unsigned long'.
348
31c286f7
PE
349 * process.c (make_process): Use printmax_t, not int, to format
350 process-name gensyms.
351
55e5faa1
PE
352 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
353
80f2e268
PE
354 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
355 to avoid potential buffer overrun.
356
670741ab
PE
357 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
358 if X resource line is longer than 512 bytes.
359
b7163a50
PE
360 * xfns.c (x_window): Make sprintf buffer a bit bigger
361 to avoid potential buffer overrun.
362
ae58ff1f
PE
363 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
364
c43c8a6a
PE
365 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
366
3f8236f4
PE
3672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
368
53e9fe90 369 Integer overflow fixes for scrolling, etc.
6511acf2
PE
370 Without these, Emacs silently mishandles large integers sometimes.
371 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
372 it were "C-u 1 M-x recenter" on a typical 64-bit host.
373
6511acf2
PE
374 * xdisp.c (try_window_id): Check Emacs fixnum range before
375 converting to 'int'.
806add1d 376
6511acf2 377 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
378 Check that an Emacs fixnum is in range before assigning it to 'int'.
379 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
380 values converted from Emacs fixnums.
381 (Frecenter): Don't wrap around a line count if it is out of 'int'
382 range; instead, treat it as an extreme value.
383 (Fset_window_configuration, compare_window_configurations):
384 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
385
6511acf2
PE
386 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
387 that can exceed INT_MAX. Check that EMACS_INT value is in range
388 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
389 (match_limit): Don't assume that a fixnum can fit in 'int'.
390
6511acf2 391 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
392 exceed INT_MAX.
393
6511acf2 394 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
395 (Fvertical_motion): Don't wrap around LINES values that don't fit
396 in 'int'. Instead, treat them as extreme values. This is good
397 enough for windows, which can't have more than INT_MAX lines anyway.
398
fcb901a7
LMI
3992011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
400
0f2f6b6d
LMI
401 * Require libxml/parser.h to avoid compilation warning.
402
fcb901a7
LMI
403 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
404
405 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
406 since this reportedly can destroy thread storage.
407
6e20a0d4
CY
4082011-08-30 Chong Yidong <cyd@stupidchicken.com>
409
410 * syntax.c (find_defun_start): Update all cache variables if
411 exiting early (Bug#9401).
412
148ae00e
EZ
4132011-08-30 Eli Zaretskii <eliz@gnu.org>
414
f6cfbd8f
EZ
415 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
416
148ae00e
EZ
417 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
418 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
419 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
420
421 * term.c (tty_append_glyph): New function.
422 (produce_stretch_glyph): Static function and its prototype deleted.
423
424 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
425 prototypes.
426
c4a07a4c
PE
4272011-08-29 Paul Eggert <eggert@cs.ucla.edu>
428
429 * image.c (parse_image_spec): Check for nonnegative, not for positive,
430 when checking :margin (Bug#9390).
431 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
432 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
433 so that the name doesn't mislead. All uses changed.
434
6bc8cd65
JB
4352011-08-28 Johan Bockgård <bojohan@gnu.org>
436
437 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
438 set_tty_hooks.
439
dca4927e
EZ
4402011-08-27 Eli Zaretskii <eliz@gnu.org>
441
442 * xdisp.c (move_it_to): Don't bail out early when reaching
443 position beyond to_charpos, if we are scanning backwards.
444 (move_it_vertically_backward): When DY == 0, make sure we get to
445 the first character in the line after the newline.
446
f2cad773
PE
4472011-08-27 Paul Eggert <eggert@cs.ucla.edu>
448
449 * ccl.c: Improve and simplify overflow checking (Bug#9196).
450 (ccl_driver): Do not generate an out-of-range pointer.
451 (Fccl_execute_on_string): Remove unnecessary check for
452 integer overflow, noted by Stefan Monnier in
453 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
454 Remove a FIXME that didn't need fixing.
455 Simplify the newly-introduced buffer reallocation code.
456
0cae2cdb
JB
4572011-08-27 Juanma Barranquero <lekktu@gmail.com>
458
459 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
460
5fc295a4 4612011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 462
70c60eb2 463 Integer and memory overflow issues (Bug#9196).
726e0ab1 464
d31850da
PE
465 * doc.c (get_doc_string): Rework so that
466 get_doc_string_buffer_size is the actual buffer size, rather than
467 being 1 less than the actual buffer size; this makes xpalloc more
468 convenient.
469
a69fbedb
PE
470 * image.c (x_allocate_bitmap_record, cache_image):
471 * xselect.c (Fx_register_dnd_atom):
472 Simplify previous changes by using xpalloc.
473
fe5c5d37
PE
474 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
475 since either will do and ptrdiff_t is convenient with xpalloc.
476
0065d054
PE
477 * charset.c (charset_table_size)
478 (struct charset_sort_data.priority): Now ptrdiff_t.
479 (charset_compare): Don't overflow if priorities differ greatly.
480 (Fsort_charsets): Don't assume list length fits in int.
481 Check for size-calculation overflow when allocating sort data.
482 (syms_of_charset): Allocate an initial charset table that is
483 just under 64 KiB, to avoid problems with glibc malloc and mmap.
484
485 * cmds.c (internal_self_insert): Check for size-calculation overflow.
486
487 * composite.h (struct composition.glyph_len): Now int, not unsigned.
488 The actual value is always <= INT_MAX, and leaving it unsigned made
489 overflow checking harder.
490
491 * dispextern.h (struct glyph_matrix.rows_allocated)
492 (struct face_cache.size): Now ptrdiff_t, for convenience in use
493 with xpalloc. The values are still always <= INT_MAX.
494
495 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
496
497 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
498 (SAFE_NALLOCA): New macro.
499
500 * region-cache.c (struct boundary.pos, find_cache_boundary)
501 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
502 (set_cache_region, invalidate_region_cache)
503 (revalidate_region_cache, know_region_cache, region_cache_forward)
504 (region_cache_backward, pp_cache):
505 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
506 so that ptrdiff_t * can be passed to xpalloc.
507 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
508 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
509 (pp_cache): Don't assume cache_len fits in int.
510 * region-cache.h: Adjust extern decls to match.
511
512 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
513 EMACS_INT, since either will do, for xpalloc.
514
515 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
516 (xnmalloc, xnrealloc, xpalloc): New functions.
517
726e0ab1
PE
518 * bidi.c (bidi_shelve_header_size): New constant.
519 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
520 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
521
51f30bc5 522 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
523 * buffer.c (overlays_at, overlays_in, record_overlay_string)
524 (overlay_strings):
525 Don't update size of array until after memory allocation succeeds,
526 because xmalloc/xrealloc may not return.
0065d054
PE
527 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
528 now that we have proper integer overflow checking.
529 (record_overlay_string, overlay_strings): Catch overflows when
530 calculating size of overlay_str_buf.
726e0ab1 531
0065d054
PE
532 * callproc.c (Fcall_process): Check for size overflow when
533 calculating size of args2.
534 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
535 Normally we prefer signed values, but sticking with ptrdiff_t would
536 require adding more-complicated checks.
726e0ab1
PE
537
538 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
539 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
540 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 541 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
542
543 * character.c (Fstring): Check for size-calculation overflow.
544
545 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
546 unnecessary integer overflow. Check for size overflow.
547 (encode_coding_object): Don't update size until xmalloc succeeds.
548
549 * composite.c (get_composition_id): Check for overflow in glyph
550 length calculations.
551
552 Integer and memory overflow fixes for display code.
553 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
554 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
555 (scrolling_window): Check for overflow in size calculations.
556 (line_draw_cost, realloc_glyph_pool, add_row_entry):
557 Don't assume glyph table len fits in int.
558 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
559 (row_table_size): Now ptrdiff_t, not int.
560 (scrolling_window): Avoid overflow in size calculations.
561 Don't update size until allocation succeeds.
562 * fns.c (concat): Check for overflow in size calculations.
563 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
564 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
565 (NEXT_ALMOST_PRIME_LIMIT): New constant.
566
567 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
568 (get_doc_string): Check for size calculation overflow.
569 Don't update size until allocation succeeds.
570 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
571 EMACS_INT, where ptrdiff_t will do.
572 (Fsubstitute_command_keys): Check for string overflow.
573
574 * editfns.c (set_time_zone_rule): Don't assume environment length
575 fits in int.
576 (message_length): Now ptrdiff_t, not int.
577 (Fmessage_box): Don't update size until allocation succeeds.
578 Don't assume message length fits in int.
579 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
580
0065d054
PE
581 * emacs.c (main): Do not reallocate argv, since there is a null at
582 the end that can be overwritten, and this way there's no need to
583 worry about size-calculation overflow.
584 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
585
586 * eval.c (init_eval_once, grow_specpdl): Don't update size until
587 alloc succeeds.
588 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
589
590 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
591 (x_set_scroll_bar_width, x_figure_window_size):
592 Check for integer overflow.
593 (x_set_alpha): Do not assume XINT fits in int.
594
595 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
596 This is for the members text_lines, text_cols, total_lines, total_cols,
597 where the system imposes an 'int' limit.
598
599 * fringe.c (Fdefine_fringe_bitmap):
600 Don't update size until alloc works.
601
602 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
603 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
604
605 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
606 Check for size-calculation overflow.
607 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
608 do, as we prefer signed integers.
609 (id_to_widget.max_size, id_to_widget.used)
610 (xg_store_widget_in_map, xg_remove_widget_from_map)
611 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
612 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
613 Use and return ptrdiff_t, not int.
614 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
615 * gtkutil.h: Change prototypes to match the above.
616
617 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
618 are duplicate now that they've been promoted to lisp.h.
619 (x_allocate_bitmap_record, x_alloc_image_color)
620 (make_image_cache, cache_image, xpm_load):
621 Don't update size until alloc is done.
622 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
623 (x_detect_edges):
3256efce 624 Check for size calculation overflow.
726e0ab1
PE
625 (ct_colors_allocated_max): New constant.
626 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
627 overflow.
3256efce 628
726e0ab1
PE
629 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
630 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
631 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
632 Use ptrdiff_t, not int, to count maps.
633 (read_char_minibuf_menu_prompt): Check for overflow in size
634 calculations. Don't update size until allocation succeeds. Redo
635 calculations to avoid overflow.
636 * keyboard.h: Change prototypes to match the above.
637
638 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
639 to count maps.
640 (current_minor_maps): Check for size calculation overflow.
641 * keymap.h: Change prototypes to match the above.
642
643 * lread.c (read1, init_obarray): Don't update size until alloc done.
644
645 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
646 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
647
726e0ab1
PE
648 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
649 Now ptrdiff_t, not int.
650 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
651 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
652
653 * process.c (Fnetwork_interface_list): Check for overflow
654 in size calculation.
655
656 * region-cache.c (move_cache_gap): Check for size calculation overflow.
657
658 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
659 overflow. Don't bother calling xmalloc when xrealloc will do.
660
661 * search.c (Freplace_match): Check for size calculation overflow.
662 (Fset_match_data): Don't assume list lengths fit in 'int'.
663
664 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
665 for command line length. Do not attempt to address one before the
666 beginning of an array, as that's not portable.
667
668 * term.c (max_frame_lines): Remove; unused.
669 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
670 not int.
671 (encode_terminal_code, calculate_costs): Check for size
672 calculation overflow.
673 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
674 table lengths and related sizes. Don't update size until alloc
675 done. Redo calculations to avoid overflow.
676 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
677
678 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
679 subtracting pointers.
680 (gobble_line): Check for overflow more carefully. Don't update size
681 until alloc done.
682
683 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
684 Don't update size until alloc done.
685 Redo size calculations to avoid overflow.
686 Check for size calculation overflow.
0065d054 687 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
688
689 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
690 Use ptrdiff_t, not int, for sizes.
691 (store_mode_line_noprop_char): Don't update size until alloc done.
692
0065d054
PE
693 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
694 Use ptrdiff_t, not int, for sizes.
695 (Finternal_make_lisp_face, cache_face):
696 Check for size calculation overflow.
697 (cache_face): Treat size calculation overflows as if they were
698 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
699
700 * xfns.c (x_encode_text, x_set_name_internal)
701 (Fx_change_window_property): Use ptrdiff_t, not int, to count
702 sizes, since they can exceed INT_MAX in size. Check for size
703 calculation overflow.
704
0065d054
PE
705 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
706 (xg_select): Check for size calculation overflow.
726e0ab1
PE
707 Don't update size until alloc done.
708
0065d054 709 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 710 as sprintf is limited to int lengths.
1d526e2f 711
252c5ee1
PE
712 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
713 (X_LONG_MIN): New macros.
864d7ce7
PE
714 Use them to make the following changes clearer.
715 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
716 This change doesn't affect the value now, but it may help remind
717 future maintainers not to raise the value too much later.
718 (SELECTION_QUANTUM): Remove, replacing with ...
719 (selection_quantum): ... new function, which avoids overflow.
720 All uses changed.
721 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
722 assumption that selection length fits in 'int'.
723 (x_reply_selection_request, x_handle_selection_request)
724 (x_get_window_property, receive_incremental_selection)
725 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
726 (lisp_data_to_selection_data, clean_local_selection_data):
727 Use ptrdiff_t, not int, to record length of selection.
728 (x_reply_selection_request, x_get_window_property)
729 (receive_incremental_selection, x_property_data_to_lisp):
730 Redo calculations to avoid overflow.
731 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 732 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
733 something.
734 (x_get_window_property, receive_incremental_selection)
735 (lisp_data_to_selection_data, x_property_data_to_lisp):
736 Check for size-calculation overflow.
737 (x_get_window_property, receive_incremental_selection)
738 (lisp_data_to_selection_data, Fx_register_dnd_atom):
739 Don't store size until memory allocation succeeds.
740 (x_get_window_property): Plug memory leak on memory exhaustion.
741 Don't double-block input; malloc is safe here. Don't assume 2**34
742 - 4 fits in unsigned long. Add an xassert to check
743 XGetWindowProperty overflow. Be more careful about overflow
744 calculations, and distinguish size from memory overflow better.
745 (receive_incremental_selection): When tracing, don't assume
746 unsigned int is less than INT_MAX.
747 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
748 harmful) conversions of unsigned short to int.
749 (lisp_data_to_selection_data): Don't assume that integers
750 in the range -65535 through -1 fit in an X unsigned short.
751 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
752 result parameters unless successful. Rely on cons_to_unsigned
753 to report problems with elements; the old code wasn't right anyway.
754 (x_check_property_data): Check for int overflow; we cannot use
755 a wider type due to X limits.
756 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
757
726e0ab1 758 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 759
0065d054
PE
760 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
761 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
762 (x_color_cells): Don't store size until memory allocation succeeds.
763 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 764 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
765 (x_term_init): Don't assume length fits in int (sprintf is limited
766 to int size).
bc18e09d 767
ebfa62c0
PE
768 Use ptrdiff_t for composition IDs.
769 * character.c (lisp_string_width):
770 * composite.c (composition_table_size, n_compositions)
771 (get_composition_id, composition_gstring_from_id):
772 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
773 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
774 * window.c (Frecenter):
775 Use ptrdiff_t, not int, for composition IDs.
776 * composite.c (get_composition_id): Check for integer overflow.
777 * composite.h: Adjust prototypes to match the above changes.
778
d3411f89
PE
779 Use ptrdiff_t for hash table indexes.
780 * category.c (hash_get_category_set):
781 * ccl.c (ccl_driver):
782 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
783 * coding.c (coding_system_charset_list, detect_coding_system):
784 * coding.h (struct coding_system.id):
785 * composite.c (get_composition_id, gstring_lookup_cache):
786 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
787 * image.c (xpm_get_color_table_h):
788 * lisp.h (hash_lookup, hash_put):
789 * minibuf.c (Ftest_completion):
790 Use ptrdiff_t for hash table indexes, not int (which is too
791 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
792 32-bit --with-wide-int hosts).
793
e097a6fa
PE
794 * charset.c (Fdefine_charset_internal): Check for integer overflow.
795 Add a FIXME comment about memory leaks.
796 (syms_of_charset): Don't assume xmalloc returns.
797
5637687f
PE
798 Don't assume that stated character widths fit in int.
799 * character.c (Fchar_width, c_string_width, lisp_string_width):
800 * character.h (CHAR_WIDTH):
801 * indent.c (MULTIBYTE_BYTES_WIDTH):
802 Use sanitize_char_width to avoid undefined and/or bad behavior
803 with outlandish widths.
804 * character.h (sanitize_tab_width): Renamed from sanitize_width,
805 now that we have two such functions. All uses changed.
806 (sanitize_char_width): New inline function.
807
a2271ba2
PE
808 Don't assume that tab-width fits in int.
809 * character.h (sanitize_width): New inline function.
810 (SANE_TAB_WIDTH): New macro.
811 (ASCII_CHAR_WIDTH): Use it.
812 * indent.c (sane_tab_width): Remove. All uses replaced by
813 SANE_TAB_WIDTH (current_buffer).
814 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
815
18c52557
PE
816 * fileio.c: Integer overflow issues with file modes.
817 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
818
caeeedc1
PE
819 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
820 Remove unreachable code.
821 (read_hex, load_charset_map_from_file): Check for integer overflow.
822
50849c52
PE
823 * xterm.c: don't go over XClientMessageEvent limit
824 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
825 (x_send_scroll_bar_event): Likewise. Check that the size does not
826 exceed limits imposed by XClientMessageEvent, as well as the usual
827 ptrdiff_t and size_t limits.
828
b13995db
PE
829 * keyboard.c: Overflow, signedness and related fixes.
830 (make_lispy_movement): Use same integer type in forward decl
831 that is used in the definition.
832 (read_key_sequence, keyremap_step):
833 Change bufsize argument back to int, undoing my 2011-03-30 change.
834 We prefer signed types, and int is wide enough here.
835 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
836 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
837 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
838 length, not size_t. Use ptrdiff_t for index, not int.
839 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
840 possibility of integer overflow.
841
13464394
PE
842 Overflow, signedness and related fixes for images.
843
844 * dispextern.h (struct it.stack[0].u.image.image_id)
845 (struct_it.image_id, struct image.id, struct image_cache.size)
846 (struct image_cache.used, struct image_cache.ref_count):
847 * gtkutil.c (update_frame_tool_bar):
848 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
849 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
850 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
851 * nsmenu.m (update_frame_tool_bar):
852 * xdisp.c (calc_pixel_width_or_height):
853 * xfns.c (image_cache_refcount):
854 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
855 on typical 64-bit hosts.
856
857 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
858 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
859 Omit unnecessary casts to int.
860 (parse_image_spec): Check that integers fall into 'int' range
861 when the callers expect that.
862 (image_ascent): Redo ascent calculation to avoid int overflow.
863 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
864 (lookup_image): Remove unnecessary tests.
865 (xbm_image_p): Locals are now of int, not EMACS_INT,
866 since parse_image_check makes sure they fit into int.
867 (png_load, gif_load, svg_load_image):
868 Prefer int to unsigned where either will do.
869 (tiff_handler): New function, combining the cores of the
870 old tiff_error_handler and tiff_warning_handler. This
871 function is rewritten to use vsnprintf and thereby avoid
872 stack buffer overflows. It uses only the features of vsnprintf
873 that are common to both POSIX and native Microsoft.
874 (tiff_error_handler, tiff_warning_handler): Use it.
875 (tiff_load, gif_load, imagemagick_load_image):
876 Don't assume :index value fits in 'int'.
877 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
878 (imagemagick_load_image): Check that crop parameters fit into
879 the integer types that MagickCropImage accepts. Don't assume
880 Vimagemagick_render_type has a nonnegative value. Don't assume
881 size_t fits in 'long'.
882 (gs_load): Use printmax_t to print the widest integers possible.
883 Check for integer overflow when computing image height and width.
884
c11821d4
EZ
8852011-08-26 Eli Zaretskii <eliz@gnu.org>
886
887 * xdisp.c (redisplay_window): Don't force window start if point
888 will be invisible in the resulting window. (Bug#9324)
889
0c95fcf7
EZ
8902011-08-25 Eli Zaretskii <eliz@gnu.org>
891
892 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
893 the display spec is of the form `(space ...)'.
894 (handle_display_spec): Return the value returned by
895 handle_single_display_spec, not just 1 or zero.
896 (handle_single_display_spec): If the display spec is of the form
897 `(space ...)', and specifies display in the text area, return 2
898 rather than 1.
fee65a97 899 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
900 accurately, and prefer exact match for point under bidi. Don't
901 advance `row' beyond the last row of the window.
0c95fcf7
EZ
902
903 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
904 into disp_prop; all users changed.
905
906 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
907 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
908 for the text covered by the display property.
909
e4ed06f1
CY
9102011-08-25 Chong Yidong <cyd@stupidchicken.com>
911
912 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
913 Change return value to nil.
914 (Frecord_buffer): Delete unused function.
915
f67cdd7f
EZ
9162011-08-24 Eli Zaretskii <eliz@gnu.org>
917
5980d4c6
EZ
918 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
919 buffers, return left-to-right.
8610fe8b
EZ
920 (set_cursor_from_row): Consider candidate row a win if its glyph
921 represents a newline and point is on that newline. Fixes cursor
922 positioning on the newline at EOL of R2L text within L2R
923 paragraph, and vice versa.
924 (try_cursor_movement): Check continued rows, in addition to
925 continuation rows. Fixes unwarranted scroll when point enters a
926 continued line of R2L text within an L2R paragraph, or vice versa.
927 (cursor_row_p): Consider the case of point being equal to
928 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
929 from the end of a short line to the beginning of a continued line
930 of R2L text within L2R paragraph.
931 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
932 composed characters.
5980d4c6 933
f67cdd7f
EZ
934 * bidi.c (bidi_check_type): Use xassert.
935 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
936 members.
937
bca633fb
EZ
9382011-08-23 Eli Zaretskii <eliz@gnu.org>
939
940 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
941 a character.
942
4a5885a7
CY
9432011-08-23 Chong Yidong <cyd@stupidchicken.com>
944
945 * nsfont.m (ns_otf_to_script): Fix typo.
946
0902a04e
KH
9472011-08-22 Kenichi Handa <handa@m17n.org>
948
949 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
950 extra slot even if the purpose is char-code-property-table.
951
1a2e6670
EZ
9522011-08-23 Eli Zaretskii <eliz@gnu.org>
953
8ddde651
EZ
954 * xdisp.c (redisplay_window): When computing centering_position,
955 account for the height of the header line. (Bug#8874)
956
425cc014
EZ
957 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
958 instead of CHAR_TO_BYTE. Fixes a crash when a completion
959 candidate is selected by the mouse, and that candidate has a
960 composed character under the mouse.
961
1a2e6670
EZ
962 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
963 coordinates reported by pos-visible-in-window-p for a composed
964 character in column zero.
965
8b76d6f8
SM
9662011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
967
968 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
969
dac347dd
EZ
9702011-08-22 Eli Zaretskii <eliz@gnu.org>
971
972 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
973 consider it a hit if to_charpos is anywhere in the range of the
974 composed buffer positions.
975
e013fb34
CY
9762011-08-22 Chong Yidong <cyd@stupidchicken.com>
977
978 * image.c (gif_load): Don't assume that each subimage has the same
979 dimensions as the base image. Handle disposal method that is
980 "undefined" by the gif spec (Bug#9335).
981
bd1ba3e8
CY
9822011-08-20 Chong Yidong <cyd@stupidchicken.com>
983
984 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 985 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 986
54a1215b
EZ
9872011-08-19 Eli Zaretskii <eliz@gnu.org>
988
823564e5
EZ
989 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
990 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
991 from an Org mode buffer to a Speedbar frame.
992
54a1215b
EZ
993 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
994 a composition, take its buffer position from IT->cmp_it.charpos.
995 Fixes cursor positioning at the beginning of a line that begins
996 with a composed character.
997
9778ebcc
EZ
9982011-08-18 Eli Zaretskii <eliz@gnu.org>
999
0be6ee06
EZ
1000 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1001 character bidirectional type, use STRONG_L instead. Fixes crashes
1002 in a buffer produced by `describe-categories'.
1003
9778ebcc
EZ
1004 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1005 members before the level stack, so they would be saved and
1006 restored when copying iterator state. Fixes incorrect reordering
1007 around TABs covered by display properties.
1008
156bffbe
AS
10092011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1010
1011 * process.c (Fnetwork_interface_list): Correctly determine buffer
1012 size.
1013
72ad093b
CY
10142011-08-17 Chong Yidong <cyd@stupidchicken.com>
1015
1016 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1017 (internal_condition_case_2, internal_condition_case_n):
1018 Remove unnecessary aborts (Bug#9081).
72ad093b 1019
35774242
EZ
10202011-08-17 Eli Zaretskii <eliz@gnu.org>
1021
1022 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1023 has no `load' handler, try opening the file locally. (Bug#9311)
1024
db76dd85
KB
10252011-08-16 Ken Brown <kbrown@cornell.edu>
1026
1027 * gmalloc.c: Expand comment.
1028
b215eee5
EZ
10292011-08-16 Eli Zaretskii <eliz@gnu.org>
1030
1031 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1032 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1033
a4579d33
KB
10342011-08-16 Ken Brown <kbrown@cornell.edu>
1035
1036 Fix memory allocation problems in Cygwin build (Bug#9273).
1037
1038 * unexcw.c ( __malloc_initialized): Declare external variable.
1039 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1040
8b76d6f8
SM
1041 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1042 New variables.
a4579d33
KB
1043 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1044 dumped emacs.
1045 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1046 in the static heap.
1047 [CYGWIN] (special_realloc): New function.
1048 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1049 requests to realloc storage in the static heap.
1050
3ebec551
PE
10512011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1052
1053 * bidi.c (bidi_initialize): Remove unused local.
1054
9fd8be00
EZ
10552011-08-15 Eli Zaretskii <eliz@gnu.org>
1056
474a8465
EZ
1057 * biditype.h: File removed.
1058
1059 * bidimirror.h: File removed.
1060
1061 * deps.mk (bidi.o): Remove biditype.h and
1062 bidimirror.h.
1063
1064 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1065 bidimirror.h.
1066
1067 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1068
1069 * chartab.c: Improve commentary for the uniprop_table API.
1070
32413314
EZ
1071 * bidi.c (bidi_paragraph_init): Support zero value of
1072 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1073 (bidi_initialize): Use uniprop_table instead of including
1074 biditype.h and bidimirror.h.
32413314 1075
9fd8be00
EZ
1076 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1077 coordinates of the iterator when restoring from ppos_it.
1078 (Bug#9296)
1079
5cf2b69b
KH
10802011-08-14 Kenichi Handa <handa@m17n.org>
1081
1082 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1083 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1084
daf17d00
EZ
10852011-08-14 Eli Zaretskii <eliz@gnu.org>
1086
1087 * xdisp.c (move_it_in_display_line_to): Don't invoke
1088 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1089 ppos_it. Fixes vertical cursor motion when line beginning is
1090 covered by an image. (Bug#9296)
1091
08e3161a
JD
10922011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1093
1094 * nsterm.h (ns_run_ascript): Declare.
1095 (NSAPP_DATA2_RUNASSCRIPT): Define.
1096
1097 * nsfns.m (as_script, as_result, as_status): New static variables.
1098 (ns_run_ascript): New function.
5e617bc2 1099 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1100 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1101 the event loop. Get status from as_status (Bug#7276).
1102
1103 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1104 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1105 the event loop (Bug#7276).
1106
a3720aa2
AS
11072011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1108
1109 * gnutls.c (QCgnutls_bootprop_priority)
1110 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1111 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1112 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1113 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1114 (QCgnutls_bootprop_verify_hostname_error)
1115 (QCgnutls_bootprop_callbacks_verify): Rename from
1116 Qgnutls_bootprop_..., all uses changed.
1117
1118 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1119 uses changed.
1120
0a0d27fb
PE
11212011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1122
19d5c50c
PE
1123 * xfaces.c (Qframe_set_background_mode): Now static.
1124 * dispextern.h (Qframe_set_background_mode): Remove decl.
1125
0a0d27fb
PE
1126 * process.c (Fnetwork_interface_info): Declare local only if needed.
1127
377538cb
JD
11282011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1129
1130 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1131 (Fnetwork_interface_list): Allocate in increments of bytes instead
1132 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1133 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1134 sockaddr.
1135 (struct ifflag_def): notrailers is smart on OSX.
1136 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1137 Get hardware address with getifaddrs if available.
1138
08fff70c
EZ
11392011-08-12 Eli Zaretskii <eliz@gnu.org>
1140
1141 * xdisp.c (iterate_out_of_display_property): xassert that
1142 IT->position is set to within IT->object's boundaries. Break from
1143 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1144 when IT->position is set up wrongly due to some bug.
1145 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1146 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1147 entry. Force push_it to save on the stack the current
1148 buffer/string position, to be restored by pop_it. Fix flags in
1149 the iterator structure wrt the object coming from a display
1150 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1151 properties. (Bug#9284)
1152
7be1c708 11532011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1154
7be1c708
CY
1155 * fontset.c (fontset_get_font_group): Add proper type checks.
1156 (Bug#9172)
aac0c6e3 1157
7be1c708 11582011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1159
7be1c708
CY
1160 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1161 and LC_VERSION_MIN_MACOSX.
1162 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1163 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1164
97bb72a6
EZ
11652011-08-08 Eli Zaretskii <eliz@gnu.org>
1166
1167 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1168 no-display-properties-and-no-overlays under bidi display.
1169 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1170 properties and overlays.
97bb72a6 1171
d5617611
CY
11722011-08-08 Chong Yidong <cyd@stupidchicken.com>
1173
37e11a63
CY
1174 * editfns.c (Fset_time_zone_rule): Document relationship with the
1175 setenv function.
1176
d5617611
CY
1177 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1178 the font entity extracted from the cache (Bug#8109).
1179
58872834
CY
11802011-08-07 Chong Yidong <cyd@stupidchicken.com>
1181
1182 * composite.c (autocmp_chars): Don't reset point. That is done by
1183 restore_point_unwind (Bug#5984).
1184
75bfc667
JL
11852011-08-07 Juri Linkov <juri@jurta.org>
1186
1187 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1188 to show the arg `TIME' instead of `TIMEVAL'.
1189
d1410150
EZ
11902011-08-06 Eli Zaretskii <eliz@gnu.org>
1191
1192 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1193 display property strides EOL and includes a newline, as in
1194 longlines-mode. (Bug#9254)
75b771e4
EZ
1195 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1196 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1197
1198 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1199 is non-zero, even if the data buffer is NULL. Fixes a crash in
1200 vertical-motion with longlines-mode. (Bug#9254)
1201
35928349
EZ
12022011-08-05 Eli Zaretskii <eliz@gnu.org>
1203
ec7cc85b
EZ
1204 * bidi.c <bidi_cache_total_alloc>: Now static.
1205 (bidi_initialize): Initialize bidi_cache_total_alloc.
1206
8b76d6f8 1207 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1208 cache. (Bug#9221)
1209
1210 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1211 amount allocated this far in `bidi_cache_total_alloc'.
1212 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1213 non-zero, only free the data buffer without restoring the cache
1214 contents. All callers changed.
1215
1216 * dispextern.h (bidi_unshelve_cache): Update prototype.
1217
1218 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1219 (move_it_in_display_line, move_it_to)
1220 (move_it_vertically_backward, move_it_by_lines): Replace the call
1221 to xfree to an equivalent call to bidi_unshelve_cache.
1222 (move_it_in_display_line_to): Fix logic of returning
412b6358 1223 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1224
e2e2423b
EZ
12252011-08-05 Eli Zaretskii <eliz@gnu.org>
1226
1227 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1228 came from a string character with a `cursor' property. (Bug#9229)
1229
ae9e757a
JD
12302011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1231
1232 * Makefile.in (LIB_PTHREAD): New variable.
1233 (LIBES): Add LIB_PTHREAD (Bug#9216).
1234
1235 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1236 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1237
213bd7f2
AS
12382011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1239
1240 * regex.c (re_iswctype): Remove some redundant boolean
1241 conversions.
1242
99aaf75f
JD
12432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1244
1245 * xterm.c (x_find_topmost_parent): New function.
1246 (x_set_frame_alpha): Find topmost parent window with
1247 x_find_topmost_parent and set the property there also (bug#9181).
1248 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1249
c74e9d86
PE
12502011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 * callproc.c (Fcall_process): Avoid vfork clobbering
1253 the local vars buffer, coding_systems, current_dir.
1254
640c8776
SM
12552011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1256
1257 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1258
f26d0e4c
PE
12592011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1260
8a10d76c
PE
1261 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1262 so that it is not optimized away.
1263
f26d0e4c
PE
1264 * xdisp.c (compute_display_string_pos): Remove unused local.
1265
55439c61
EZ
12662011-08-02 Eli Zaretskii <eliz@gnu.org>
1267
1268 Fix slow cursor motion and scrolling in large buffers with
1269 selective display, like Org Mode buffers. (Bug#9218)
1270
1271 * dispextern.h (struct bidi_it): New member disp_prop_p.
1272
1273 * xdisp.c: Remove one-slot cache of display string positions.
1274 (compute_display_string_pos): Accept an additional argument
5e617bc2 1275 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1276 for a display string or property. If found, set DISP_PROP_P
1277 non-zero.
1278
1279 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1280 DISP_PROP_P, and pass it to compute_display_string_pos.
1281 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1282 non-zero. All callers of bidi_fetch_char changed.
1283
fb33fa43
SM
12842011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1285
1286 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1287
b099e063
DM
12882010-12-03 Don March <don@ohspite.net>
1289
1290 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1291 last character M-[char] is translated to ESC [char] (bug#7541).
1292
5cc7f7af
KH
12932011-08-02 Kenichi Handa <handa@m17n.org>
1294
d0fffa3f 1295 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1296
1297 * chartab.c (uniprop_table): Make it non-static.
1298
525d5e6e
EZ
12992011-08-01 Eli Zaretskii <eliz@gnu.org>
1300
1301 * xdisp.c (forward_to_next_line_start): Accept additional argument
1302 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1303 on the newline.
1304 (reseat_at_next_visible_line_start): Use the bidi iterator state
1305 returned by forward_to_next_line_start to restore the state of
1306 it->bidi_it after backing up to previous newline. (Bug#9212)
1307
31011111
AS
13082011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1309
1310 * regex.c (re_comp): Protoize.
1311 (re_exec): Fix return type.
1312 (regexec): Fix type of `ret'. (Bug#9203)
1313
476371c4
PE
13142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1315
e5d76069
PE
1316 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1317 This is needed if max-image-size is a floating-point number.
1318
9a79b20c
AS
13192011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1320
1321 * print.c (print_object): Print empty symbol as ##.
1322
1323 * lread.c (read1): Read ## as empty symbol.
1324
d8c2fa78
AA
13252011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1326
1327 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1328 setting frame foreground color (Bug#9175).
1329 (x_set_background_color): Likewise.
1330
ffe57a7a
AA
1331 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1332 contents (Bug#9176).
1333 (EmacsTooltip -init): Remove bezels and add shadows to
1334 tooltip windows.
1335
bf3492a5
AA
1336 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1337 or scroll bar (Bug#8470).
1338
d55e9c53
AA
1339 * nsfont.m (nsfont_open): Remove assignment to voffset and
1340 unnecessary vars hshink, expand, hd, full_height, min_height.
1341 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1342
1343 * nsterm.h (nsfont_info): Remove voffset field.
1344
d8c2fa78 13452011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1346
1347 Implement strike-through and overline on NextStep (Bug#8863).
1348
1349 * nsfont.m (nsfont_open): Use underline position provided by font,
1350 instead of hard-coded value of 2.
1351 (nsfont_draw): Call ns_draw_text_decoration instead.
1352
1353 * nsterm.h: Add declaration for ns_draw_text_decoration.
1354
1355 * nsterm.m (ns_draw_text_decoration): New function for drawing
1356 underline, overline, and strike-through.
1357 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1358 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1359 accommodate underlining, etc.
4843aac3 1360
4cc60b9b
EZ
13612011-07-28 Eli Zaretskii <eliz@gnu.org>
1362
bc7ece87
EZ
1363 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1364 default.
4cc60b9b 1365
476371c4
PE
13662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1367
66606eea
PE
1368 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1369 Without this fix, if a signal arrives just after memory fills up,
1370 'malloc' might be invoked reentrantly.
1371
476371c4
PE
1372 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1373 In other words, assume that every image size is allowed, on non-X
1374 hosts. This assumption is probably wrong, but it lets Emacs compile.
1375
f3fcc40d
AS
13762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1377
1378 * regex.c (re_iswctype): Convert return values to boolean.
1379
350c992f
EZ
13802011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1381
1382 * xdisp.c (compute_display_string_pos): Don't use cached display
1383 string position if the buffer had its restriction changed.
1384 (Bug#9184)
1385
5266b4bb
PE
13862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1389
2573a837 13902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1391
41f55ccd 1392 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1393
39e378da
PE
1394 * bidi.c: Integer size and overflow fixes.
1395 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1396 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1397 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1398 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1399 (bidi_find_other_level_edge):
1400 Use ptrdiff_t instead of EMACS_INT where either will do.
1401 This works better on 32-bit hosts configured --with-wide-int.
1402 (bidi_cache_ensure_space): Check for size-calculation overflow.
1403 Use % rather than repeated addition, for better worst-case speed.
1404 Don't set bidi_cache_size until after xrealloc returns, because it
1405 might not return.
1406 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1407 (bidi_cache_ensure_space): Also check that the bidi cache size
1408 does not exceed that of the largest Lisp string or buffer. See Eli
1409 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1410
5e927815
PE
1411 * alloc.c (__malloc_size_t): Remove.
1412 All uses replaced by size_t. See Andreas Schwab's note
1413 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1414
ca4aa935
PE
1415 * image.c: Improve checking for integer overflow.
1416 (check_image_size): Assume that f is nonnull, since
1417 it is always nonnull in practice. This is one less thing to
1418 worry about when checking for integer overflow later.
1419 (x_check_image_size): New function, which checks for integer
1420 overflow issues inside X.
1421 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1422 This removes the need for a memory_full check.
1423 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1424 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1425 (xbm_read_bitmap_data): Change locals back to 'int', since
1426 their values must fit in 'int'.
1427 (xpm_load_image, png_load, tiff_load):
1428 Invoke x_create_x_image_and_pixmap earlier,
1429 to avoid much needless work if the image is too large.
1430 (tiff_load): Treat overly large images as if
1431 x_create_x_image_and_pixmap failed, not as malloc failures.
1432 (gs_load): Use x_check_image_size.
1433
5f8f9cc2
PE
1434 * gtkutil.c: Omit integer casts.
1435 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1436 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1437
5adf60bc
PE
1438 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1439
c8907a93
PE
1440 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1441 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1442 would wrongly return t on a 64-bit host.
1443
e3c25c68
PE
1444 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1445 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1446 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1447 and therefore cause GCC to emit a bogus diagnostic in some cases.
1448
3f791afe
PE
1449 * image.c: Integer signedness and overflow and related fixes.
1450 This is not an exhaustive set of fixes, but it's time to
1451 record what I've got.
1452 (lookup_pixel_color, check_image_size): Remove redundant decls.
1453 (check_image_size): Don't assume that arbitrary EMACS_INT values
1454 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1455 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1456 (tiff_load, imagemagick_load_image):
1457 Check for overflow in size calculations.
1458 (x_create_x_image_and_pixmap): Remove unnecessary test for
1459 xmalloc returning NULL; that can't happen.
1460 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1461 (xpm_color_bucket): Use better integer hashing function.
1462 (xpm_cache_color): Don't possibly over-allocate memory.
1463 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1464 (gif_memory_source):
1465 Use ptrdiff_t, not int or size_t, to record sizes.
1466 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1467 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1468 either works, as we prefer signed integers.
1469 (tiff_read_from_memory, tiff_write_from_memory):
1470 Return tsize_t, not size_t, since that's what the TIFF API wants.
1471 (tiff_read_from_memory): Don't fail simply because the read would
1472 go past EOF; instead, return a short read.
1473 (tiff_load): Omit no-longer-needed casts.
1474 (Fimagemagick_types): Don't assume size fits into 'int'.
1475
3cc5a532
PE
1476 Improve hashing quality when configured --with-wide-int.
1477 * fns.c (hash_string): New function, taken from sxhash_string.
1478 Do not discard information about ASCII character case; this
1479 discarding is no longer needed.
1480 (sxhash-string): Use it. Change sig to match it. Caller changed.
1481 * lisp.h: Declare it.
1482 * lread.c (hash_string): Remove, since we now use fns.c's version.
1483 The fns.c version returns a wider integer if --with-wide-int is
1484 specified, so this should help the quality of the hashing a bit.
1485
b312a492
PE
1486 * emacs.c: Integer overflow minor fix.
1487 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1488 Define only if GNU_LINUX.
1489 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1490
dfd153ae
PE
1491 * dispnew.c: Integer signedness and overflow fixes.
1492 Remove unnecessary forward decls, that were a maintenance hassle.
1493 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1494 All uses changed.
1495 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1496 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1497 (prepare_desired_row, line_draw_cost):
1498 Use int, not unsigned, where either works.
1499 (save_current_matrix, restore_current_matrix):
1500 Use ptrdiff_t, not size_t, where either works.
1501 (init_display): Check for overflow more accurately, and without
1502 relying on undefined behavior.
1503
a81d11a3
PE
1504 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1505 Remove, replacing with the new symbols in lisp.h. All uses changed.
1506 * fileio.c (make_temp_name):
1507 * filelock.c (lock_file_1, lock_file):
1508 * xdisp.c (message_dolog):
1509 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1510 Use pMd etc. instead.
1511 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1512 replacing the pWIDE etc. symbols removed from editfns.c.
1513
3300e6fd
PE
1514 * keyboard.h (num_input_events): Now uintmax_t.
1515 This is (very slightly) less likely to mess up due to wraparound.
1516 All uses changed.
1517
fd05c7e9
PE
1518 * buffer.c: Integer signedness fixes.
1519 (alloc_buffer_text, enlarge_buffer_text):
1520 Use ptrdiff_t rather than size_t when either will do, as we prefer
1521 signed integers.
1522
903fe15d
PE
1523 * alloc.c: Integer signedness and overflow fixes.
1524 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1525 (__malloc_size_t): Default to size_t, not to int.
1526 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1527 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1528 Prefer ptrdiff_t to size_t when either would do, as we prefer
1529 signed integers.
1530 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1531 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1532 Now const. Initialize with values that are in range even if char
1533 is signed.
1534 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1535 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1536 These functions do the right thing with sizes > 2**32.
1537 (check_depth): Now ptrdiff_t, not int.
1538 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1539 Adjust to new way of storing sizes. Check for size overflow bugs
1540 in rest of code.
1541 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1542 slightly wrong anyway, as it missed one instance of
1543 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1544 (refill_memory_reserve): Omit needless cast to size_t.
1545 (mark_object_loop_halt): Mark as externally visible.
1546
ac82cc6a
PE
1547 * xselect.c: Integer signedness and overflow fixes.
1548 (Fx_register_dnd_atom, x_handle_dnd_message):
1549 Use ptrdiff_t, not size_t, since we prefer signed.
1550 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1551 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1552 x_dnd_atoms_size and x_dnd_atoms_length.
1553
c2d1e36d
PE
1554 * doprnt.c: Prefer signed to unsigned when either works.
1555 * eval.c (verror):
1556 * doprnt.c (doprnt):
1557 * lisp.h (doprnt):
1558 * xdisp.c (vmessage):
1559 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1560 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1561 prefer signed arithmetic to avoid comparison confusion.
1562 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1563 but is a bit tricky.
1564
0e926e56
PE
1565 Assume freestanding C89 headers, string.h, stdlib.h.
1566 * data.c, doprnt.c, floatfns.c, print.c:
1567 Include float.h unconditionally.
1568 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1569 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1570 * regex.c: Likewise for stddef.h, string.h.
1571 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1572 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1573 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1574 (STDC_HEADERS): Remove obsolete defines.
1575 * sysdep.c: Include limits.h unconditionally.
1576
9cfdb3ec
PE
1577 Assume support for memcmp, memcpy, memmove, memset.
1578 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1579 * regex.c (memcmp, memcpy):
1580 Remove; we assume C89 now.
1581
1582 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1583 (__malloc_safe_bcopy): Remove; no longer needed.
1584
cf950e6b 1585 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1586 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1587 well either way, and we prefer signed to unsigned.
1588
dbf38e02
LMI
15892011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1590
1591 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1592 closes the connection while we're reading (bug#9182).
1593
d6f0886c 15942011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1595
d6f0886c
JD
1596 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1597 are specified (Bug#9168).
24e0f6b1 1598
2eb1f9e6
PE
15992011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1600
1601 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1602 Found by GCC static checking and --with-wide-int on a 32-bit host.
1603
22381272 16042011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1605
1606 * xdisp.c (compute_display_string_pos): Fix logic of caching
1607 previous display string position. Initialize cached_prev_pos to
1608 -1. Fixes slow-down at the beginning of a buffer.
1609
f25e39b4
EZ
16102011-07-24 Eli Zaretskii <eliz@gnu.org>
1611
1612 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1613 for attrs[LFACE_FONTSET_INDEX].
1614
04c4b52e
PE
16152011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1616
1617 * xml.c (parse_region): Remove unused local
1618 that was recently introduced.
1619
c1734fbd
EZ
16202011-07-23 Eli Zaretskii <eliz@gnu.org>
1621
be18c5a5
EZ
1622 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1623 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1624
c1734fbd
EZ
1625 * xdisp.c (move_it_in_display_line_to): Record the best matching
1626 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1627 exit if none of the characters scanned was an exact match.
1628 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1629 when exact match is impossible due to invisible text, and the
1630 lines are truncated.
1631
a258d627
JD
16322011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1633
1634 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1635 for OSX >= 10.7.
1636
b6d5a689
EZ
16372011-07-22 Eli Zaretskii <eliz@gnu.org>
1638
0f74f785
EZ
1639 Fix a significant slow-down of cursor motion with C-n, C-p,
1640 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1641 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1642 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1643 (next_element_from_buffer): Call compute_stop_pos_backwards to
1644 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1645 base_level_stop.
1646 (reseat): Don't look for prev_stop, as that could mean a very long
1647 run.
1648 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1649 <cached_disp_overlay_modiff>: Cache for last found display string
1650 position.
551918c1 1651 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1652 about the same buffer in the same area of character positions, and
1653 the buffer wasn't changed since the time the display string
1654 position was cached.
551918c1 1655
b2d0c91a
EZ
16562011-07-22 Eli Zaretskii <eliz@gnu.org>
1657
1658 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1659 is an integer, which is important for empty lines. (Bug#9149)
1660
043604ee
CY
16612011-07-22 Chong Yidong <cyd@stupidchicken.com>
1662
1663 * frame.c (Fmodify_frame_parameters): In tty case, update the
1664 default face if necessary (Bug#4238).
1665
da4adb04
CY
16662011-07-21 Chong Yidong <cyd@stupidchicken.com>
1667
1668 * editfns.c (Fstring_to_char): No need to explain what a character
1669 is in the docstring (Bug#6576).
1670
9abd0532
LMI
16712011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1672
1673 * xml.c (parse_region): Make sure we always return a tree.
1674
36881d16
HK
16752011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1676
1677 * xml.c (parse_region): If a document contains only comments,
1678 return that, too.
1679
1e98674d
LMI
16802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1681
1682 * xml.c (make_dom): Return comments, too.
1683
590bd467
PE
16842011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1685
1686 Port to OpenBSD.
1687 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1688 and the surrounding thread.
1689 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1690 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1691 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1692 timer goes off.
1693 * s/openbsd.h (BROKEN_SIGIO): Define.
1694 * unexelf.c (unexec) [__OpenBSD__]:
1695 Don't update the .mdebug section of the Alpha COFF symbol table.
1696
f41628b2
LMI
16972011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1698
1699 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1700 (bug#8460).
1701
b59b67c5
PE
17022011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1703
15e3a074
PE
1704 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1705 This fixes some race conditions on the permissions of any newly
1706 created file.
1707
41bed37d
PE
1708 * alloc.c (valid_pointer_p): Use pipe, not open.
1709 This fixes some permissions issues when debugging.
1710
b59b67c5
PE
1711 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1712 If fchown fails to set both uid and gid, try to set just gid,
1713 as that is sometimes allowed. Adjust the file's mode to eliminate
1714 setuid or setgid bits that are inappropriate if fchown fails.
1715
925a6be7
SM
17162011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1717
1718 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1719 to compare Lisp_Objects.
1720 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1721 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1722 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1723
52968808
AS
17242011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1725
0a6a104b
AS
1726 * lread.c (read_integer): Unread even EOF character.
1727 (read1): Likewise. Properly record start position of symbol.
1728
52968808
AS
1729 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1730 symbol character follows.
1731
9e381cdd
PE
17322011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1733
1734 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1735 This works around a problem with the previous change to Fcopy_file.
1736 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1737 and without this change, GCC might complain about discarding
1738 fchown's return value.
1739
b5641435
JB
17402011-07-16 Juanma Barranquero <lekktu@gmail.com>
1741
1742 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1743
a8031457
PE
17442011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1747
dd889327
LMI
17482011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1749
750c33f7
LMI
1750 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1751 it's used from the C level.
1752
dd889327
LMI
1753 * process.c: Use the same condition for POLL_FOR_INPUT in both
1754 keyboard.c and process.c (bug#1858).
1755
87e86684
LM
17562011-07-09 Lawrence Mitchell <wence@gmx.li>
1757
1758 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1759 (Fgnutls_boot): Use it.
1760
64348f40
AS
17612011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1762
1763 * doc.c (Fsubstitute_command_keys): Revert last change.
1764
1d698799
LMI
17652011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1766
f863868c
LMI
1767 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1768 quotes the next character, and doesn't affect other longer
1769 sequences (bug#8935).
1770
1d698799
LMI
1771 * lread.c (syms_of_lread): Clarify that is isn't only
1772 `eval-buffer' and `eval-defun' that's affected by
1773 `lexical-binding' (bug#8460).
1774
aa4b6df6
EZ
17752011-07-15 Eli Zaretskii <eliz@gnu.org>
1776
1777 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1778 bidi redisplay when a line includes both an image and is
1779 truncated.
1780
5d856da6
PE
17812011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1782
ad6042bb
PE
1783 Fix minor problems found by static checking.
1784 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1785 (elsz): Now a signed constant, not a size_t var. We prefer signed
1786 types to unsigned, to avoid integer comparison confusion. Without
1787 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1788 "cannot optimize loop, the loop counter may overflow", a symptom
1789 of the confusion.
f00bbb22 1790 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1791 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1792
6468f31c
LMI
17932011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1794
49080b10
LMI
1795 * search.c (Fre_search_backward): Mention `case-fold-search' in
1796 all the re_search_* functions (bug#8138).
1797
6468f31c
LMI
1798 * keyboard.c (Fopen_dribble_file): Document when the file is
1799 closed (bug#8056).
1800
c965adc5
EZ
18012011-07-14 Eli Zaretskii <eliz@gnu.org>
1802
df9733bf
EZ
1803 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1804 bidi_cache_idx.
1805
0bb23927
EZ
1806 Support bidi reordering of display and overlay strings.
1807 * xdisp.c (compute_display_string_pos)
1808 (compute_display_string_end): Accept additional argument STRING.
1809 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1810 (reseat_to_string): Initialize bidi_it->string.s and
1811 bidi_it->string.schars.
1812 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1813 NULL (avoids a crash in bidi_paragraph_init).
1814 Initialize itb.string.lstring.
0bb23927
EZ
1815 (init_iterator): Call bidi_init_it only of a valid
1816 buffer position was specified. Initialize paragraph_embedding to
1817 L2R.
1818 (reseat_to_string): Initialize the bidi iterator.
1819 (display_string): If we need to ignore text properties of
1820 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1821 original value of -1 will not work with bidi.)
1822 (compute_display_string_pos): First arg is now struct
1823 `text_pos *'; all callers changed. Support display properties on
1824 Lisp strings.
1825 (compute_display_string_end): Support display properties on Lisp
1826 strings.
1827 (init_iterator, reseat_1, reseat_to_string): Initialize the
1828 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1829 when iterating on a string not from display properties).
640c8776
SM
1830 (compute_display_string_pos, compute_display_string_end):
1831 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1832 arrow keys.
1833 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1834 base_level_stop; instead, set base_level_stop to BEGV.
1835 Fixes crashes in vertical-motion.
0bb23927
EZ
1836 (next_element_from_buffer): Improve commentary for when
1837 the iterator is before prev_stop.
1838 (init_iterator): Initialize bidi_p from the default value of
1839 bidi-display-reordering, not from buffer-local value. Use the
1840 buffer-local value only if initializing for buffer iteration.
1841 (handle_invisible_prop): Support invisible properties on strings
1842 that are being bidi-reordered.
1843 (set_iterator_to_next): Support bidi reordering of C strings and
1844 Lisp strings.
1845 (next_element_from_string): Support bidi reordering of Lisp
1846 strings.
1847 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1848 (display_string): Support display of R2L glyph rows.
1849 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1850 (init_iterator): Don't initialize it->bidi_p for strings
1851 here.
1852 (reseat_to_string): Initialize it->bidi_p for strings here.
1853 (next_element_from_string, next_element_from_c_string)
1854 (next_element_from_buffer): Add xassert's for correspondence
1855 between IT's object being iterated and it->bidi_it.string
1856 structure.
1857 (face_before_or_after_it_pos): Support bidi iteration.
1858 (next_element_from_c_string): Handle the case of the first string
1859 character that is not the first one in the visual order.
1860 (get_visually_first_element): New function, refactored from common
1861 parts of next_element_from_buffer, next_element_from_string, and
1862 next_element_from_c_string.
1863 (tool_bar_lines_needed, redisplay_tool_bar)
1864 (display_menu_bar): Force left-to-right direction. Add a FIXME
1865 comment for making that be controlled by a user option.
1866 (push_it, pop_it): Save and restore the state of the
1867 bidi iterator. Save and restore the bidi_p flag.
1868 (pop_it): Iterate out of display property for string iteration as
1869 well.
1870 (iterate_out_of_display_property): Support iteration over strings.
1871 (handle_single_display_spec): Set up it->bidi_it for iteration
1872 over a display string, and call bidi_init_it.
1873 (handle_single_display_spec, next_overlay_string)
1874 (get_overlay_strings_1, push_display_prop): Set up the bidi
1875 iterator for displaying display or overlay strings.
1876 (forward_to_next_line_start): Don't use the shortcut if
1877 bidi-iterating.
1878 (back_to_previous_visible_line_start): If handle_display_prop
1879 pushed the iterator stack, restore the internal state of the bidi
1880 iterator by calling bidi_pop_it same number of times.
1881 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1882 and we are bidi-iterating, don't decrement the iterator position;
1883 instead, set the first_elt flag in the bidi iterator, to produce
1884 the same effect.
1885 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1886 (push_display_prop): xassert that we are iterating a buffer.
1887 (push_it, pop_it): Save and restore paragraph_embedding member.
1888 (handle_single_display_spec, next_overlay_string)
1889 (get_overlay_strings_1, reseat_1, reseat_to_string)
1890 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1891 correctly. Don't assume unibyte strings are not bidi-reordered.
1892 (compute_display_string_pos)
1893 (compute_display_string_end): Fix handling the case of C string.
1894 (push_it, pop_it): Save and restore from_disp_prop_p.
1895 (handle_single_display_spec, push_display_prop): Set the
1896 from_disp_prop_p flag.
1897 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1898 (pop_it): Call iterate_out_of_display_property only if we are
1899 popping after iteration over a string that came from a display
1900 property. Fix a typo in popping stretch info. Add an assertion
1901 for verifying that the iterator position is in sync with the bidi
1902 iterator.
1903 (handle_single_display_spec, get_overlay_strings_1)
1904 (push_display_prop): Fix initialization of paragraph direction for
1905 string when that of the parent object is not yet determined.
1906 (reseat_1): Call bidi_init_it to resync the bidi
1907 iterator with IT's position. (Bug#7616)
1908 (find_row_edges): If ROW->start.pos gives position
1909 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1910 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1911 Reset the from_disp_prop_p flag.
1912 (SAVE_IT, RESTORE_IT): New macros.
1913 (pos_visible_p, face_before_or_after_it_pos)
1914 (back_to_previous_visible_line_start)
1915 (move_it_in_display_line_to, move_it_in_display_line)
1916 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1917 (try_scrolling, redisplay_window, display_line): Use them when
1918 saving a temporary copy of the iterator and restoring it back.
1919 (back_to_previous_visible_line_start, reseat_1)
1920 (init_iterator): Empty the bidi cache "stack".
1921 (move_it_in_display_line_to): If iterator ended up at
1922 EOL, but we never saw any buffer positions smaller than
1923 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1924 motion in bidi-reordered lines.
1925 (move_it_in_display_line_to): Record prev_method and prev_pos
1926 immediately before the call to set_iterator_to_next. Fixes cursor
1927 motion in bidi-reordered lines with stretch glyphs and strings
1928 displayed in margins. (Bug#8133) (Bug#8867)
1929 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1930 TO_CHARPOS.
640c8776
SM
1931 (pos_visible_p): Support positions in bidi-reordered lines.
1932 Save and restore bidi cache.
0bb23927
EZ
1933
1934 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1935 (bidi_paragraph_info): Delete unused struct.
1936 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1937 (bidi_cache_start): New variable.
1938 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1939 to zero.
1940 (bidi_cache_fetch_state, bidi_cache_search)
1941 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1942 (bidi_cache_find, bidi_peek_at_next_level)
1943 (bidi_level_of_next_char, bidi_find_other_level_edge)
1944 (bidi_move_to_visually_next): Compare cache index with
1945 bidi_cache_start rather than with zero.
1946 (bidi_fetch_char): Accept new argument STRING; all callers
1947 changed. Support iteration over a string. Support strings with
1948 display properties. Support unibyte strings. Fix the type of
1949 `len' according to what STRING_CHAR_AND_LENGTH expects.
1950 (bidi_paragraph_init, bidi_resolve_explicit_1)
1951 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1952 (bidi_level_of_next_char, bidi_move_to_visually_next):
1953 Support iteration over a string.
0bb23927
EZ
1954 (bidi_set_sor_type, bidi_resolve_explicit_1)
1955 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1956 can now be zero (for strings); special values 0 and -1 were
1957 changed to -1 and -2, respectively.
1958 (bidi_char_at_pos): New function.
1959 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1960 Call it instead of FETCH_MULTIBYTE_CHAR.
1961 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1962 initialized to valid values.
1963 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1964 values.
1965 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1966 the test for valid cached positions. Fix the logic for looking up
1967 the sentinel state in the cache. GCPRO the Lisp string we are
1968 iterating.
1969 (bidi_push_it, bidi_pop_it): New functions.
1970 (bidi_initialize): Initialize the bidi cache start stack pointer.
1971 (bidi_cache_ensure_space): New function, refactored from part of
1972 bidi_cache_iterator_state. Don't assume the required size is just
1973 one BIDI_CACHE_CHUNK away.
1974 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1975 (bidi_count_bytes, bidi_char_at_pos): New functions.
1976 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1977 always valid if bidi_cache_idx is valid.
1978 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1979 is valid if it's going to be used.
1980 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1981 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1982 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1983 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1984 (bidi_find_other_level_edge, bidi_cache_start_stack):
1985 All variables related to cache indices are now EMACS_INT.
c965adc5 1986
0bb23927
EZ
1987 * dispextern.h (struct bidi_string_data): New structure.
1988 (struct bidi_it): New member `string'. Make flag members be 1-bit
1989 fields, and put them last in the struct.
640c8776
SM
1990 (compute_display_string_pos, compute_display_string_end):
1991 Update prototypes.
0bb23927
EZ
1992 (bidi_push_it, bidi_pop_it): Add prototypes.
1993 (struct iterator_stack_entry): New members bidi_p,
1994 paragraph_embedding, and from_disp_prop_p.
1995 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1996 (bidi_shelve_cache, bidi_unshelve_cache):
1997 Declare prototypes.
0bb23927
EZ
1998
1999 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2000 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2001 and vector-like objects.
2002
2003 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2004 cache around display iteration.
2005
2006 * window.c (Fwindow_end, window_scroll_pixel_based)
2007 (displayed_window_lines, Frecenter): Save and restore the bidi
2008 cache around display iteration.
2009
3bbd2265
LMI
20102011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2011
2012 * editfns.c (Fdelete_region): Clarify the use of the named
2013 parameters (bug#6788).
2014
adc47434
MR
20152011-07-14 Martin Rudalics <rudalics@gmx.at>
2016
2017 * indent.c (Fvertical_motion): Set and restore w->pointm when
2018 saving and restoring the window's buffer (Bug#9006).
2019
837c31f8
LMI
20202011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2021
2022 * editfns.c (Fstring_to_char): Clarify just what is returned
2023 (bug#6576). Text by Eli Zaretskii.
2024
ac389d0c
JB
20252011-07-13 Juanma Barranquero <lekktu@gmail.com>
2026
2027 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2028
0be0ce47
EZ
20292011-07-13 Eli Zaretskii <eliz@gnu.org>
2030
2031 * buffer.c (mmap_find): Fix a typo.
2032
cd18e7e3
JB
20332011-07-13 Johan Bockgård <bojohan@gnu.org>
2034
2035 Fix execution of x selection hooks.
2036 * xselect.c (Qx_lost_selection_functions)
2037 (Qx_sent_selection_functions): New vars.
2038 (syms_of_xselect): DEFSYM them.
2039 (x_handle_selection_request): Pass Qx_sent_selection_functions
2040 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2041 (x_handle_selection_clear,x_clear_frame_selections):
2042 Pass Qx_lost_selection_functions rather than
2043 Vx_lost_selection_functions to Frun_hook_with_args.
2044
47ea7f44
PE
20452011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2046
ac389d0c 2047 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2048 The old code sometimes used this field without initializing it.
2049
47ea7f44
PE
2050 * alloc.c (gc_sweep): Don't read past end of array.
2051 In theory, the old code could also have corrupted Emacs internals,
2052 though it'd be very unlikely.
2053
bc985c87
AS
20542011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2055
2056 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2057 argument. (Bug#4026)
bc985c87 2058
0cf34688
LMI
20592011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2060
b3dadd76
LMI
2061 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2062 key" (bug#4257).
2063
0cf34688
LMI
2064 * window.c (Fset_window_start): Doc fix (bug#4199).
2065 (Fset_window_hscroll): Ditto.
2066
270768cd
PE
20672011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2068
077e3dda 2069 Fix minor new problems caught by GCC 4.6.1.
270768cd 2070 * term.c (init_tty): Remove unused local.
490011a6 2071 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2072 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2073 not used otherwise.
270768cd 2074
b1f58454
CY
20752011-07-12 Chong Yidong <cyd@stupidchicken.com>
2076
2077 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2078
22b9578d
LMI
20792011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2080
6e70ab07
LMI
2081 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2082 are the mini-buffer and the echo area (bug#3320).
2083
22b9578d
LMI
2084 * term.c (init_tty): Remove support for supdup, c10 and perq
2085 terminals, which are no longer supported (bug#1482).
2086
8974cc9f
JB
20872011-07-10 Johan Bockgård <bojohan@gnu.org>
2088
2089 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2090
a560d974
JD
20912011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2092
2093 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2094 for non-popups (Bug#3642).
2095
1dae0f0a
AS
20962011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2097
268c2c36 2098 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2099 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2100 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2101 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2102 * data.c (fmod): Likewise.
2103 * dispnew.c (swap_glyphs_in_rows): Likewise.
2104 * emacs.c (memory_warning_signal): Likewise.
2105 * floatfns.c (float_error): Likewise.
2106 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2107 (otf_open, font_otf_capability, generate_otf_features)
2108 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2109 Likewise.
2110 * image.c (pbm_read_file): Likewise.
2111 * indent.c (string_display_width): Likewise.
2112 * intervals.c (check_for_interval, search_for_interval)
2113 (inc_interval_count, count_intervals, root_interval)
2114 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2115 * lread.c (defalias): Likewise.
268c2c36 2116 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2117 * regex.c (set_image_of_range_1, set_image_of_range)
2118 (regex_grow_registers): Likewise.
2119 * sysdep.c (strerror): Likewise.
2120 * termcap.c (valid_filename_p, tprint, main): Likewise.
2121 * tparam.c (main): Likewise.
2122 * unexhp9k800.c (run_time_remap, save_data_space)
2123 (update_file_ptrs, read_header, write_header, calculate_checksum)
2124 (copy_file, copy_rest, display_header): Likewise.
2125 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2126 Likewise.
2127 * xdisp.c (check_it): Likewise.
2128 * xfaces.c (register_color, unregister_color, unregister_colors):
2129 Likewise.
2130 * xfns.c (print_fontset_result): Likewise.
2131 * xrdb.c (member, fatal, main): Likewise.
2132
99033785
PE
21332011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2134
2135 Fix minor problems found by static checking (Bug#9031).
2136 * chartab.c (char_table_set_range, map_sub_char_table):
2137 Remove unused locals.
2138 (uniprop_table): Now static.
2139 * composite.c (_work_char): Remove unused static var.
2140
9cb2ac56
JB
21412011-07-09 Juanma Barranquero <lekktu@gmail.com>
2142
2143 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2144
f25661f0
JD
21452011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2146
2147 * gtkutil.c (qttip_cb): Remove code without function.
2148
8278c4fe
EZ
21492011-07-09 Eli Zaretskii <eliz@gnu.org>
2150
2151 * w32.c (pthread_sigmask): New stub.
2152
1692ae2d 21532011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2154
8a6ebd58 2155 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2156 sigprocmask is portable only for single-threaded applications, and
2157 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2158 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2159 (LIBES): Use it.
2160 * callproc.c (Fcall_process):
2161 * process.c (create_process):
2162 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2163 Use pthread_sigmask, not sigprocmask.
123403e4 2164
1b854618
JD
21652011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2166
2167 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2168 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2169 wrong (Bug#8591).
2170
3fe4b549
JD
21712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2172
0ce7e563
JD
2173 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2174 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2175 (xg_hide_tooltip): Fix comment.
2176
3fe4b549
JD
2177 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2178 in registerServicesMenuSendTypes.
2179 (validRequestorForSendType): Don't check ns_return_types.
2180
2181 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2182 ns_return_type.
2183
5df75e47
JR
21842011-07-08 Jason Rumney <jasonr@gnu.org>
2185
2186 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2187 frame struct members of non-existent frames (Bug#6284).
2188
699c10bd
JD
21892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2190
4393663b
JD
2191 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2192 variable firstTime not needed on OSX >= 10.6.
2193 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2194 >= 10.5. Use setKnobProportion, setDoubleValue.
2195
2196 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2197 (MAC_OS_X_VERSION_10_5): Define if not defined.
2198 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2199 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2200 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2201
2202 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2203 cString and lossyCString on OSX >= 10.4
2204
2205 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2206 sizeToFit on OSX >= 10.2.
2207
2208 * nsimage.m (allocInitFromFile): Don't use deprecated method
2209 bestRepresentationForDevice on OSX >= 10.6.
2210
2211 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2212 to avoid warning.
2213
2214 * emacs.c: Declare unexec_init_emacs_zone.
2215
a63e0781
JD
2216 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2217
699c10bd
JD
2218 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2219
2220 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2221 on svcsMenu (Bug#8842).
2222
2223 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2224 ns_return_types.
2225 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2226
2227 * nsterm.m (QUTF8_STRING): Declare.
2228 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2229 (validRequestorForSendType): Return type is (id).
2230 Change indexOfObjectIdenticalTo to indexOfObject.
2231 Check if we have local selection before returning self (Bug#8842).
2232 (writeSelectionToPasteboard): Put local selection into paste board
2233 if we have a local selection (Bug#8842).
2234 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2235
2236 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2237 (ns_get_local_selection): Declare.
2238
54e10184
LMI
22392011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2240
9888ff71
LMI
2241 * keymap.c (describe_map_tree): Don't insert a double newline at
2242 the end of the buffer (bug#1169) and return whether we inserted
2243 something.
2244
54e10184
LMI
2245 * callint.c (Fcall_interactively): Change "reading args" to
2246 "providing args" to try to clarify what it does (bug#1010).
2247
15fa4783
KH
22482011-07-07 Kenichi Handa <handa@m17n.org>
2249
2250 * composite.c (composition_compute_stop_pos): Ignore a static
2251 composition starting before CHARPOS (Bug#8915).
2252
2253 * xdisp.c (handle_composition_prop): Likewise.
2254
a8815b00
EZ
22552011-07-07 Eli Zaretskii <eliz@gnu.org>
2256
2257 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2258 (Bug#9015)
2259
ef7b981d 22602011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2261
2262 * character.h (unicode_category_t): New enum type.
2263
2264 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2265 (Qchar_code_property_table): New variable.
2266 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2267 (UNIPROP_COMPRESSED_FORM_P): New macros.
2268 (char_table_ascii): Uncompress the compressed values.
2269 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2270 Uncompress the compressed values.
ac389d0c 2271 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2272 (char_table_ref_and_range): Uncompress the compressed values.
2273 (sub_char_table_set): New arg is_uniprop. Callers changed.
2274 Uncompress the compressed values.
2275 (sub_char_table_set_range): Args changed. Callers changed.
2276 (char_table_set_range): Adjuted for the above change.
2277 (map_sub_char_table): Delete args default_val and parent. Add arg
2278 top. Give decoded values to a Lisp function.
640c8776 2279 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2280 values to a Lisp function. Gcpro more variables.
2281 (uniprop_table_uncompress)
2282 (uniprop_decode_value_run_length): New functions.
2283 (uniprop_decoder, uniprop_decoder_count): New variables.
2284 (uniprop_get_decoder, uniprop_encode_value_character)
2285 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2286 New functions.
2287 (uniprop_encoder, uniprop_encoder_count): New variables.
2288 (uniprop_get_encoder, uniprop_table)
2289 (Funicode_property_table_internal, Fget_unicode_property_internal)
2290 (Fput_unicode_property_internal): New functions.
2291 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2292 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2293 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2294 char-code-property-alist.
2295
640c8776 2296 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2297 Vunicode_category_table.
2298
640c8776 2299 * font.c (font_range): Adjust for the change of
c805dec0
KH
2300 Vunicode_category_table.
2301
76b397fb
DN
23022011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2303
2304 * m/iris4d.h: Remove file, move contents ...
2305 * s/irix6-5.h: ... here.
2306
22b4128e
PE
23072011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2310 * alloc.c (mark_buffer):
2311 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2312 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2313 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2314 This isn't true in general, and it's particularly not true
2315 if Emacs is configured with --with-wide-int.
2316 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2317 New macros, used in the buffer.c change.
2318
869795d6
JD
23192011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2320
2321 * xsettings.c: Use both GConf and GSettings if both are available.
2322 (store_config_changed_event): Add comment.
2323 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2324 (store_tool_bar_style_changed): New functions.
5e617bc2 2325 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2326 (struct xsettings): Move font inside HAVE_XFT.
2327 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2328 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2329 Move inside HAVE_XFT.
640c8776 2330 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2331 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2332 also.
2333 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2334 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2335 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2336 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2337 (parse_settings): Move check for font inside HAVE_XFT.
2338 (read_settings, apply_xft_settings): Add comment.
2339 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2340 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2341 call store_font_name_changed.
2342 (xft_settings_event): Add comment.
2343 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2344 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2345 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2346 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2347 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2348 (xsettings_get_system_font, xsettings_get_system_normal_font):
2349 Add comment.
869795d6 2350
d8ed26bd
PE
23512011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 Random fixes. E.g., (random) never returned negative values.
2354 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2355 subseconds part to the entropy, as that's a bit more random.
2356 Prefer signed to unsigned, since the signedness doesn't matter and
2357 in general we prefer signed. When given a limit, use a
2358 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2359 latter isn't right if USE_2_TAGS_FOR_INTS.
2360 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2361 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2362
cabf1cac
SM
23632011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2364
2365 * textprop.c (text_property_stickiness):
2366 Obey Vtext_property_default_nonsticky.
2367 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2368 * w32fns.c (syms_of_w32fns):
2369 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2370
6e9b2be9
PE
23712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2372
2373 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2374 This is more efficient than Ffile_directory_p and avoids a minor race.
2375
90186c68
LMI
23762011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2377
7c301272
LMI
2378 * buffer.c (Foverlay_put): Say what the return value is
2379 (bug#7835).
2380
c4f2d8d4
LMI
2381 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2382 is a directory before asking whether to use the file name
2383 (bug#7564).
ad637907
LMI
2384 (barf_or_query_if_file_exists): Make the "File is a directory"
2385 error be more correct.
c4f2d8d4 2386
90186c68
LMI
2387 * fns.c (Frequire): Remove the mention of the .gz files, since
2388 that's installation-specific, but keep the mention of
2389 `get-load-suffixes'.
2390
da64016e
PE
23912011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2394 Report string overflow if the output is too long.
2395
7d47b580
JB
23962011-07-04 Juanma Barranquero <lekktu@gmail.com>
2397
a555cb87
JB
2398 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2399 (syms_of_gnutls): Remove duplicate DEFSYM for
2400 Qgnutls_bootprop_verify_hostname_error, an error for
2401 Qgnutls_bootprop_verify_error (which is no longer used).
2402
7d47b580
JB
2403 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2404 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2405 Also (re)move comments that are misplaced or no longer relevant.
2406
1e49bfab
LMI
24072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2408
2409 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2410
1485f4c0
CY
24112011-07-03 Chong Yidong <cyd@stupidchicken.com>
2412
2413 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2414 and background color parameters if they have been changed.
2415
a9ab721e
LMI
24162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2417
2418 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2419
cf7cff57
PE
24202011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2421
2e13213d
PE
2422 * xsettings.c (SYSTEM_FONT): Define only when used.
2423 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2424
cf7cff57
PE
2425 * keymap.c (access_keymap_1): Now static.
2426
7a8e04f7
CY
24272011-07-02 Chong Yidong <cyd@stupidchicken.com>
2428
2429 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2430 leave any prefix arg for the up event (Bug#1586).
2431
61352f62
LMI
24322011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2433
69bb1ef7
LMI
2434 * lread.c (syms_of_lread): Mention single symbols defined by
2435 `defvar' or `defconst' (bug#7154).
2436
61352f62 2437 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2438 (Frequire): Mention get-load-suffixes.
61352f62 2439
28545e04
MR
24402011-07-02 Martin Rudalics <rudalics@gmx.at>
2441
2442 * window.h (window): Remove clone_number slot.
2443 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2444 Remove.
2445 (make_parent_window, make_window, saved_window)
2446 (Fset_window_configuration, save_window_save): Don't deal with
2447 clone numbers.
2448 * buffer.c (Qclone_number): Remove declaration.
2449 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2450
3349e122
SM
24512011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2452
2453 Add multiple inheritance to keymaps.
2454 * keymap.c (Fmake_composed_keymap): New function.
2455 (Fset_keymap_parent): Simplify.
2456 (fix_submap_inheritance): Remove.
2457 (access_keymap_1): New function extracted from access_keymap to handle
2458 embedded parents and handle lists of maps.
2459 (access_keymap): Use it.
2460 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2461 (Fcopy_keymap): Handle embedded parents.
2462 (Fcommand_remapping, define_as_prefix): Simplify.
2463 (Fkey_binding): Simplify.
2464 (syms_of_keymap): Move minibuffer-local-completion-map,
2465 minibuffer-local-filename-completion-map,
2466 minibuffer-local-must-match-map, and
2467 minibuffer-local-filename-must-match-map to Elisp.
2468 (syms_of_keymap): Defsubr make-composed-keymap.
2469 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2470 (parse_menu_item): Trivial simplification.
2471
3279eb87
GM
24722011-07-01 Glenn Morris <rgm@gnu.org>
2473
2474 * Makefile.in (SETTINGS_LIBS): Fix typo.
2475
4550efdf
KI
24762011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2477
2478 * coding.c (Fencode_coding_string): Record the last coding system
2479 used, as the function doc string says (bug#8738).
2480
0949d2b6
JD
24812011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2482
2483 * xsettings.c (store_monospaced_changed): Take new font as arg and
2484 check for change against current_mono_font.
2485 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2486 (emacs_settings_constructor, emacs_settings_get_property)
2487 (emacs_settings_set_property, emacs_settings_class_init)
2488 (emacs_settings_init, gsettings_obj): Remove.
2489 (something_changedCB): New function for HAVE_GSETTINGS.
2490 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2491 with value as argument.
2492 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2493 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2494 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2495 "changed".
2496
2497 * xgselect.c: Add defined (HAVE_GSETTINGS).
2498 (xgselect_initialize): Ditto.
2499
2500 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2501 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2502 xg_select.
2503
bbc6b304
PE
25042011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2505
2506 * eval.c (struct backtrace): Simplify and port the data structure.
2507 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2508 signed bit field, as this assumption is not portable and it makes
2509 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2510 "char debug_on_exit : 1" as this is not portable either; instead,
2511 use the portable "unsigned int debug_on_exit : 1". Remove unused
2512 member evalargs. Remove obsolete comments about cc bombing out.
2513
9851bfc5
JD
25142011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2515
51bb811f 2516 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2517 Let HAVE_GSETTINGS override HAVE_GCONF.
2518 (store_monospaced_changed): New function.
2519 (EMACS_SETTINGS): A new type derived from GObject to handle
2520 GSettings notifications.
2521 (emacs_settings_constructor, emacs_settings_get_property)
2522 (emacs_settings_set_property, emacs_settings_class_init):
2523 New functions.
2524 (gsettings_client, gsettings_obj): New variables.
2525 (GSETTINGS_SCHEMA): New define.
2526 (something_changedCB): Call store_monospaced_changed.
2527 (init_gsettings): New function.
2528 (xsettings_initialize): Call init_gsettings.
2529 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2530 to NULL.
2531
640c8776 2532 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2533 GCONF_CFLAGS/LIBS.
2534
5386012d
MR
25352011-06-29 Martin Rudalics <rudalics@gmx.at>
2536
2537 * window.c (resize_root_window, grow_mini_window)
2538 (shrink_mini_window): Rename Qresize_root_window to
2539 Qwindow_resize_root_window and Qresize_root_window_vertically to
2540 Qwindow_resize_root_window_vertically.
2541
f13e0b08
PE
25422011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2543
2544 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2545
94515237
JB
25462011-06-27 Juanma Barranquero <lekktu@gmail.com>
2547
2548 * makefile.w32-in: Redesign dependencies so they reflect more
2549 clearly which files are directly included by each source file,
2550 and not through other includes.
2551
e43b6e43
MR
25522011-06-27 Martin Rudalics <rudalics@gmx.at>
2553
2554 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2555 (sort_overlays, overlay_strings): When an overlay's clone number
2556 matches the window's clone number process the overlay even if
2557 the overlay's window property doesn't match the current window.
2558
d68443dc
MR
2559 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2560 (Fwindow_hchild): Rename to Fwindow_left_child.
2561 (Fwindow_next): Rename to Fwindow_next_sibling.
2562 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2563 (resize_window_check): Rename to window_resize_check.
2564 (resize_window_apply): Rename to window_resize_apply.
2565 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2566 (Fdelete_other_windows_internal, resize_frame_windows)
2567 (Fsplit_window_internal, Fdelete_window_internal)
2568 (grow_mini_window, shrink_mini_window)
2569 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2570
c7e73be5
JD
25712011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2572
2573 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2574 (emacs_fixed_set_min_size): Remove.
2575 (emacs_fixed_new): Take frame as argument.
2576
2577 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2578 (_EmacsFixedPrivate): Remove minwidth/height.
2579 Add struct frame *f.
2580 (emacs_fixed_init): Initialize priv->f.
2581 (get_parent_class, emacs_fixed_set_min_size): Remove.
2582 (emacs_fixed_new): Set priv->f to argument.
2583 (emacs_fixed_get_preferred_width)
2584 (emacs_fixed_get_preferred_height): Use min_width/height from
2585 frames size_hint to set minimum and natural (Bug#8919).
2586 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2587 and use min_width/height from frames size_hint to set
2588 min_width/height (Bug#8919).
2589
2590 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2591 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2592 Fix indentation.
c7e73be5 2593
cf99dcf8
EZ
25942011-06-26 Eli Zaretskii <eliz@gnu.org>
2595
2596 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2597 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2598 called at ZV.
2599
029529ac
CY
26002011-06-26 Chong Yidong <cyd@stupidchicken.com>
2601
2602 * process.c (wait_reading_process_output): Bypass select if
2603 waiting for a cell while ignoring keyboard input, and input is
2604 pending. Suggested by Jan Djärv (Bug#8869).
2605
7a7ef429
PE
26062011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 Use gnulib's dup2 module instead of rolling our own.
2609 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2610
11fdef7d 26112011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2612
2613 * dispnew.c (scrolling_window): Before scrolling, turn off a
2614 mouse-highlight in the window being scrolled.
2615
cd3520a4
JB
26162011-06-24 Juanma Barranquero <lekktu@gmail.com>
2617
2618 Move DEFSYM to lisp.h and use everywhere.
2619
2620 * character.h (DEFSYM): Move declaration...
2621 * lisp.h (DEFSYM): ...here.
2622
2623 * gnutls.c:
2624 * minibuf.c:
2625 * w32menu.c:
2626 * w32proc.c:
2627 * w32select.c: Don't include character.h.
2628
2629 * alloc.c (syms_of_alloc):
2630 * buffer.c (syms_of_buffer):
2631 * bytecode.c (syms_of_bytecode):
2632 * callint.c (syms_of_callint):
2633 * casefiddle.c (syms_of_casefiddle):
2634 * casetab.c (init_casetab_once):
2635 * category.c (init_category_once, syms_of_category):
2636 * ccl.c (syms_of_ccl):
2637 * cmds.c (syms_of_cmds):
2638 * composite.c (syms_of_composite):
2639 * dbusbind.c (syms_of_dbusbind):
2640 * dired.c (syms_of_dired):
2641 * dispnew.c (syms_of_display):
2642 * doc.c (syms_of_doc):
2643 * editfns.c (syms_of_editfns):
2644 * emacs.c (syms_of_emacs):
2645 * eval.c (syms_of_eval):
2646 * fileio.c (syms_of_fileio):
2647 * fns.c (syms_of_fns):
2648 * frame.c (syms_of_frame):
2649 * fringe.c (syms_of_fringe):
2650 * insdel.c (syms_of_insdel):
2651 * keymap.c (syms_of_keymap):
2652 * lread.c (init_obarray, syms_of_lread):
2653 * macros.c (syms_of_macros):
2654 * msdos.c (syms_of_msdos):
2655 * print.c (syms_of_print):
2656 * process.c (syms_of_process):
2657 * search.c (syms_of_search):
2658 * sound.c (syms_of_sound):
2659 * syntax.c (init_syntax_once, syms_of_syntax):
2660 * terminal.c (syms_of_terminal):
2661 * textprop.c (syms_of_textprop):
2662 * undo.c (syms_of_undo):
2663 * w32.c (globals_of_w32):
2664 * window.c (syms_of_window):
2665 * xdisp.c (syms_of_xdisp):
2666 * xfaces.c (syms_of_xfaces):
2667 * xfns.c (syms_of_xfns):
2668 * xmenu.c (syms_of_xmenu):
2669 * xsettings.c (syms_of_xsettings):
2670 * xterm.c (syms_of_xterm): Use DEFSYM.
2671
4228cf16
TZ
26722011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2673
cd3520a4 2674 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2675
7fcccf1e
PE
26762011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2677
7efb4e0e
PE
2678 Integer and buffer overflow fixes (Bug#8873).
2679
ff5844ad
PE
2680 * print.c (printchar, strout): Check for string overflow.
2681 (PRINTPREPARE, printchar, strout):
2682 Don't set size unless allocation succeeds.
2683
90532f02
PE
2684 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2685 for sizes. Check for string overflow more accurately.
2686 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2687
6d84508d
PE
2688 * macros.c: Integer and buffer overflow fixes.
2689 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2690 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2691 Use ptrdiff_t, not int, for sizes.
2692 Don't increment bufsize until after realloc succeeds.
2693 Check for size-calculation overflow.
2694 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2695
437b2cb4
PE
2696 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2697
8b9ac8b4
PE
2698 * lread.c: Integer overflow fixes.
2699 (read_integer): Radix is now EMACS_INT, not int,
2700 to improve quality of diagnostics for out-of-range radices.
2701 Calculate buffer size correctly for out-of-range radices.
2702 (read1): Check for integer overflow in radices, and in
2703 read-circle numbers.
82cb60d3
PE
2704 (read_escape): Avoid int overflow.
2705 (Fload, openp, read_buffer_size, read1)
2706 (substitute_object_recurse, read_vector, read_list, map_obarray):
2707 Use ptrdiff_t, not int, for sizes.
2708 (read1): Use EMACS_INT, not int, for sizes.
20270765 2709 Check for size overflow.
8b9ac8b4 2710
7fcccf1e
PE
2711 * image.c (cache_image): Check for size arithmetic overflow.
2712
bfbbd7e7
PE
2713 * lread.c: Integer overflow issues.
2714 (saved_doc_string_size, saved_doc_string_length)
2715 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2716 Now ptrdiff_t, not int.
2717 (read1): Don't assume doc string length fits in int. Check for
2718 out-of-range doc string lengths.
2719 (read_list): Don't assume file position fits in int.
39019e54 2720 (read_escape): Check for hex character overflow.
bfbbd7e7 2721
4e323265
LL
27222011-06-22 Leo Liu <sdl.web@gmail.com>
2723
2724 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2725 Move to minibuffer.el.
2726
85fece3e
PE
27272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2728
20b84ce9 2729 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2730 The following patches are for when GLYPH_DEBUG && !XASSERT.
2731 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2732 * dispnew.c (flush_stdout):
2733 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2734 Mark as externally visible.
2735 * dispnew.c (check_window_matrix_pointers): Now static.
2736 * dispnew.c (window_to_frame_vpos):
2737 * xfns.c (unwind_create_frame):
2738 * xterm.c (x_check_font): Remove unused local.
2739 * scroll.c (CHECK_BOUNDS):
2740 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2741 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2742 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2743 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2744 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2745 Now static.
2746 (debug_method_add): Use va_list and vsprintf rather than relying
2747 on undefined behavior with wrong number of arguments.
2748 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2749 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2750 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2751 since we're not interested in debugging glyphs with old libraries.
2752 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2753 GCC 4.6.0's static checking.
2754
0766b489
PE
27552011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2756
31fd4b32
PE
2757 Integer overflow and signedness fixes (Bug#8873).
2758 A few related buffer overrun fixes, too.
2759
b79e8648
PE
2760 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2761
0766b489
PE
2762 * dispextern.h (struct face.stipple):
2763 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2764 (x_bitmap_mask, x_allocate_bitmap_record)
2765 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2766 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2767 (x_create_bitmap_from_xpm_data):
2768 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2769 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2770 (.bitmaps_last):
2771 * xfaces.c (load_pixmap):
2772 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2773 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2774 (.bitmaps_last, struct x_output.icon_bitmap):
2775 Use ptrdiff_t, not int, for bitmap indexes.
2776 (x_allocate_bitmap_record): Check for size overflow.
2777 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2778
b081724f
PE
2779 Use ptrdiff_t, not int, for overlay counts.
2780 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2781 * editfns.c (overlays_around, get_pos_property):
2782 * textprop.c (get_char_property_and_overlay):
2783 * xdisp.c (next_overlay_change, note_mouse_highlight):
2784 * xfaces.c (face_at_buffer_position):
21514da7
PE
2785 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2786 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2787 (Fnext_overlay_change, Fprevious_overlay_change)
2788 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2789 Use ptrdiff_t, not int, for sizes.
21514da7 2790 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2791
3de73e5e
PE
2792 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2793
2606c57b
PE
2794 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2795 (x_session_initialize): Do not assume string length fits in int.
2796
aaafe47a
PE
2797 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2798 This is unlikely, but can occur if DPI is outlandish.
2799
2674ddc8 2800 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2801 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2802
28154962
PE
2803 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2804 * xrdb.c (magic_file_p, search_magic_path):
2805 Omit last arg SUFFIX; it was always 0. All callers changed.
2806 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2807
7de51af5
PE
2808 * xfont.c (xfont_match): Avoid need for strlen.
2809
25ed6cc3
PE
2810 * xfns.c: Don't assume strlen fits in int.
2811 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2812
4eab31dd
PE
2813 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2814 not unsigned long, as we prefer signed integers. All callers changed.
2815 Detect integer overflow in repeat count.
2816 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2817 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2818
171e2a58
PE
2819 * termcap.c: Don't assume sizes fit in int and never overflow.
2820 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2821 (gobble_line): Check for size-calculation overflow.
2822
ad39faca 2823 * minibuf.c (Fread_buffer):
6e5bb2dc 2824 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2825 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2826 Don't assume string length fits in int.
2827
52c61c22 2828 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2829 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2830
b5b8c9e5
PE
2831 * font.c: Don't assume string length fits in int.
2832 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2833 Use ptrdiff_t, not int.
ccd6111c
PE
2834 (font_intern_prop): Don't assume string length fits in int.
2835 Don't assume integer property fits in fixnum.
2836 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2837
882f0d81 2838 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2839 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2840 Reformulate so as not to need the command string.
2841 Invoke gzip -cd rather than gunzip, as it's more portable.
2842 (lock_info_type, lock_file_1, lock_file):
2843 Don't assume pid_t and time_t fit in unsigned long.
2844 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2845 (current_lock_owner): Prefer signed type for sizes.
2846 Use memcpy, not strncpy, where memcpy is what is really wanted.
2847 Don't assume (via atoi) that time_t and pid_t fit in int.
2848 Check for time_t and/or pid_t out of range, e.g., via a network share.
2849 Don't alloca where an auto var works fine.
2850
93f4cf88
PE
2851 * fileio.c: Fix some integer overflow issues.
2852 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2853 Don't assume string length fits in int.
2854 (directory_file_name): Don't assume string length fits in long.
2855 (make_temp_name): Don't assume pid fits in int, or that its print
2856 length is less than 20.
2857
f3e92b69
PE
2858 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2859
1bfdaf10
PE
2860 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2861
35016e9a
PE
2862 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2863
3d1e65a1
PE
2864 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2865 We prefer signed integers, even for size calculations.
2866
0b963a93
PE
2867 * emacs.c: Don't assume string length fits in 'int'.
2868 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2869 (main): Don't invoke strlen when not needed.
2870
573f4b54
PE
2871 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2872 (XD_DEBUG_MESSAGE): Don't waste a byte.
2873
989f33ba
PE
2874 * callproc.c (getenv_internal_1, getenv_internal)
2875 (Fgetenv_internal):
965d34eb
PE
2876 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2877
e4d29b33
PE
2878 * lread.c (invalid_syntax): Omit length argument.
2879 All uses changed. This doesn't fix a bug, but it simplifies the
2880 code away from its former Hollerith-constant appearance, and it's
2881 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2882 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2883
eb49b136
PE
2884 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2885 This didn't break anything, but it didn't help either.
2886 It's confusing to put a bogus integer in a place where the actual
2887 value does not matter.
9f62aeb1 2888 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2889 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2890
15375a22
PE
2891 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2892 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2893 implementation.
b61cc01c
PE
2894 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2895 We prefer signed types, and the value cannot exceed the EMACS_INT
2896 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2897 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2898 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2899 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2900
53b2623d
PE
2901 * indent.c (sane_tab_width): New function.
2902 (current_column, scan_for_column, Findent_to, position_indentation)
2903 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2904 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2905
51cab52b 2906 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2907
f2ed8a70
PE
2908 * lisp.h (lint_assume): New macro.
2909 * composite.c (composition_gstring_put_cache):
2910 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2911
abe80cc6
PE
2912 * editfns.c, insdel.c:
2913 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2914
b02c740e
PE
2915 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2916
ebc96716
PE
2917 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2918
b4e50fa0 2919 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2920 Use much-faster test for byte-length change.
311d5d7c 2921 Don't assume string byte-length fits in 'int'.
a4cf38e4 2922 Check that character arg fits in 'int'.
85461888 2923 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2924
c0c1ee9f
PE
2925 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2926
a498d7f4
PE
2927 * fns.c (concat): Catch string overflow earlier.
2928 Do not rely on integer wraparound.
2929
51cab52b
PE
2930 * dispextern.h (struct it.overlay_strings_charpos)
2931 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2932 * xdisp.c (forward_to_next_line_start)
2933 (back_to_previous_visible_line_start)
2934 (reseat_at_next_visible_line_start, next_element_from_buffer):
2935 Don't arbitrarily truncate the value of 'selective' to int.
2936
76031fad
PE
2937 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2938
5eb55db9
PE
2939 * composite.c: Don't truncate sizes to 'int'.
2940 (composition_gstring_p, composition_reseat_it)
2941 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2942 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2943 not EMACS_UINT, for indexes.
5eb55db9 2944
0703a717
PE
2945 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2946
d6202519
PE
2947 * buffer.c: Include <verify.h>.
2948 (struct sortvec.priority, struct sortstr.priority):
8961a454 2949 Now EMACS_INT, not int.
c20998a7 2950 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2951 (struct sortstr.size, record_overlay_string)
2952 (struct sortstrlist.size, struct sortlist.used):
2953 Don't truncate size to int.
2954 (record_overlay_string): Check for size-calculation overflow.
d6202519 2955 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2956
d5a19415
JM
29572011-06-22 Jim Meyering <meyering@redhat.com>
2958
029529ac 2959 Don't leak an XBM-image-sized buffer
d5a19415
JM
2960 * image.c (xbm_load): Free the image buffer after using it.
2961
a9041e6c
PE
29622011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2963
2964 Port to Sun C.
2965 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2966 that Sun C diagnosed.
2967 * fns.c (secure_hash): Fix pointer signedness issue.
2968 * intervals.c (static_offset_intervals): New function.
2969 (offset_intervals): Use it.
2970
7f3f739f
LL
29712011-06-21 Leo Liu <sdl.web@gmail.com>
2972
2973 * deps.mk (fns.o):
2974 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2975 sha512.h.
2976
2977 * fns.c (secure_hash): Rename from crypto_hash_function and change
2978 the first arg to accept symbols.
5b66d427 2979 (Fsecure_hash): New primitive.
7f3f739f
LL
2980 (syms_of_fns): New symbols.
2981
76147d94
DD
29822011-06-20 Deniz Dogan <deniz@dogan.se>
2983
2984 * process.c (Fset_process_buffer): Clarify return value in
2985 docstring.
2986
7d7d0045
CY
29872011-06-18 Chong Yidong <cyd@stupidchicken.com>
2988
2989 * dispnew.c (add_window_display_history): Use BVAR.
2990
2991 * xdisp.c (debug_method_add): Use BVAR.
2992 (check_window_end, dump_glyph_matrix, dump_glyph)
2993 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2994
2995 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2996 Likewise.
2997
2998 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2999 check till after the cache is created in init_frame_faces.
3000
ff2bc410
SM
30012011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3002
3003 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3004
28177add
PE
30052011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3006
dd3482fe
PE
3007 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3008 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3009 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3010
393d71f3 3011 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3012 * fileio.c (Finsert_file_contents):
3013 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3014 Remove the old (too-loose) buffer overflow checks.
3015 They weren't needed, since make_gap checks for buffer overflow.
3016 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3017 The old code merely checked for Emacs fixnum overflow, and relied
3018 on undefined (wraparound) behavior. The new code avoids undefined
3019 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3020
2e6813b0 3021 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3022 Tune. Don't use wider integers than needed. Don't use alloca.
3023 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3024
599a9e4f
PE
3025 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3026
99561444
PE
3027 * insdel.c, lisp.h (buffer_overflow): New function.
3028 (insert_from_buffer_1, replace_range, replace_range_2):
3029 * insdel.c (make_gap_larger):
3030 * editfns.c (Finsert_char):
3031 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3032
28177add
PE
3033 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3034
e69dafad
PE
30352011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3036
a7af7fde 3037 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3038
b1c46f02
PE
3039 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3040 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3041
e69dafad
PE
3042 * fileio.c: Don't assume EMACS_INT fits in off_t.
3043 (emacs_lseek): New static function.
3044 (Finsert_file_contents, Fwrite_region): Use it.
3045 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3046
566684ea
PE
3047 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3048
e6966cd6
PE
3049 * fns.c: Don't overflow int when computing a list length.
3050 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3051 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3052 truncation on 64-bit hosts. Check for QUIT every
3053 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3054 faster and is responsive enough.
3055 (Flength): Report an error instead of overflowing an integer.
3056 (Fsafe_length): Return a float if the value is not representable
3057 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3058 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3059 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3060
dd0b0efb
PE
3061 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3062 (header_size, word_size): New constants.
3063 (allocate_vectorlike): Don't check size overflow here.
3064 (allocate_vector): Check it here instead, since this is the only
3065 caller of allocate_vectorlike that could cause overflow.
3066 Check that the new vector's length is representable as a fixnum.
3067
86fe5cfe
PE
3068 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3069 The previous code was bogus. For example, next_almost_prime (32)
3070 returned 39, which is undesirable as it is a multiple of 3; and
3071 next_almost_prime (24) returned 25, which is a multiple of 5 so
3072 why was the code bothering to check for multiples of 7?
3073
80e88859
PE
3074 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3075
4a2f0ad6
PE
3076 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3077
f66c7cf8
PE
3078 Variadic C functions now count arguments with ptrdiff_t.
3079 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3080 Back then I didn't know that the Emacs coding style prefers signed int.
3081 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3082 were being counted with int, which may truncate counts on 64-bit
3083 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3084 * lisp.h (struct Lisp_Subr.function.aMANY)
3085 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3086 Arg counts are now ptrdiff_t, not size_t.
3087 All variadic functions and their callers changed accordingly.
3088 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3089 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3090 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3091 * callint.c (Fcall_interactively): Check arg count for overflow,
3092 to avoid potential buffer overrun. Use signed char, not 'int',
3093 for 'varies' array, so that we needn't bother to check its size
3094 calculation for overflow.
3095 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3096 * eval.c (apply_lambda):
3097 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3098 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3099 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3100
a1759b76
PE
3101 * callint.c (Fcall_interactively): Don't use index var as event count.
3102
d96be9fc
PE
3103 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3104 * mem-limits.h (SIZE): Remove; no longer used.
3105
a690a978 3106 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3107
578c21e6
PE
3108 Remove unnecessary casts.
3109 * xterm.c (x_term_init):
3110 * xfns.c (x_set_border_pixel):
3111 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3112 These aren't needed now that we assume ANSI C.
3113
96f53c6c
PE
3114 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3115 It's more likely to cause problems (due to unsigned overflow)
3116 than to cure them.
3117
83c77d31
PE
3118 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3119
ee2079f1
PE
3120 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3121
6da65536
PE
3122 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3123
7147c4a4
PE
3124 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3125
193e32d9
PE
3126 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3127
e5533da6
PE
3128 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3129
9910e595
PE
3130 GLYPH_CODE_FACE returns EMACS_INT, not int.
3131 * dispextern.h (merge_faces):
3132 * xfaces.c (merge_faces):
01103c44
PE
3133 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3134 Don't assume EMACS_INT fits in int.
9910e595 3135
2638320e
PE
3136 * character.h (CHAR_VALID_P): Remove unused parameter.
3137 * fontset.c, lisp.h, xdisp.c: All uses changed.
3138
045eb8d9
PE
3139 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3140
c1f134b5
PE
3141 * fns.c (concat): Minor tuning based on overflow analysis.
3142 This doesn't fix any bugs. Use int to hold character, instead
3143 of constantly refetching from Emacs object. Use XFASTINT, not
3144 XINT, for value known to be a character. Don't bother comparing
3145 a single byte to 0400, as it's always less.
3146
395fcb93 3147 * floatfns.c (Fexpt):
327eeec8
PE
3148 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3149
abbd3d23
PE
3150 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3151 for characters.
3152
684a03ef
PE
3153 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3154
0fed43f3
PE
3155 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3156 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3157 incorrectly succeed when S was a string, because 4294967386 was
3158 truncated before it was used.
3159
8fd02eb7
PE
3160 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3161 Otherwise, an out-of-range integer could cause undefined behavior
3162 on a 64-bit host.
3163
f8c86b69
PE
3164 * composite.c: Use int, not EMACS_INT, for characters.
3165 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3166 EMACS_INT, for values that are known to be in character range.
3167 This doesn't fix any bugs but is the usual style inside Emacs and
3168 may generate better code on 32-bit machines.
3169
34206dd2
PE
3170 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3171 This is for reasons similar to the recent CHAR_STRING fix.
3172 * charset.c (Fencode_char): Check that character arg is actually
3173 a character. Pass an int to ENCODE_CHAR.
3174 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3175 wider than 'int', as a compile-time check to prevent future regressions
3176 in this area.
3177
c5958d4c 3178 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3179
3180 Make sure a 64-bit char is never passed to CHAR_STRING.
3181 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3182 by silently ignoring the top 32 bits, allowing some values
3183 that were far too large to be valid characters.
3184 * character.h: Include <verify.h>.
3185 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3186 arguments are no wider than unsigned, as a compile-time check
3187 to prevent future regressions in this area.
3188 * data.c (Faset):
01103c44 3189 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3190 (Fsubst_char_in_region):
3191 * fns.c (concat):
3192 * xdisp.c (decode_mode_spec_coding):
3193 Adjust to CHAR_STRING's new requirement.
3194 * editfns.c (Finsert_char, Fsubst_char_in_region):
3195 * fns.c (concat): Check that character args are actually
3196 characters. Without this test, these functions did the wrong
3197 thing with wildly out-of-range values on 64-bit hosts.
3198
d37ca623
PE
3199 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3200 These casts should not be needed on 32-bit hosts, either.
3201 * keyboard.c (read_char):
3202 * lread.c (Fload): Remove casts to unsigned.
3203
ea204efb
PE
3204 * lisp.h (UNSIGNED_CMP): New macro.
3205 This fixes comparison bugs on 64-bit hosts.
3206 (ASCII_CHAR_P): Use it.
3207 * casefiddle.c (casify_object):
01103c44 3208 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3209 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3210 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3211 * dispextern.h (FACE_FROM_ID):
3212 * keyboard.c (read_char): Use UNSIGNED_CMP.
3213
41cb286c
PE
3214 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3215 not to EMACS_INT, to avoid GCC warning.
3216
4a1b9832
PE
3217 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3218
55daad71
PE
3219 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3220 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3221 isn't needed on 32-bit machines.
8f95c75c 3222
01103c44
PE
3223 * buffer.c (Fgenerate_new_buffer_name):
3224 Use EMACS_INT for count, not int.
0ceccced 3225 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3226
3227 * data.c (Qcompiled_function): Now static.
3228
c6f072e7
PE
3229 * window.c (window_body_lines): Now static.
3230
20ce5912
PE
3231 * image.c (gif_load): Rename local to avoid shadowing.
3232
9c4c5f81
PE
3233 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3234 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3235 * alloc.c (make_save_value): Integer argument is now of type
3236 ptrdiff_t, not int.
3237 (mark_object): Use ptrdiff_t, not int.
3238 * lisp.h (pD): New macro.
3239 * print.c (print_object): Use it.
3240
c0c5c8ae
PE
3241 * alloc.c: Use EMACS_INT, not int, to count objects.
3242 (total_conses, total_markers, total_symbols, total_vector_size)
3243 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3244 (total_free_floats, total_floats, total_free_intervals)
3245 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3246 Now EMACS_INT, not int. All uses changed.
3247 (Fgarbage_collect): Compute overall total using a double, so that
3248 integer overflow is less likely to be a problem. Check for overflow
3249 when converting back to an integer.
5a25e253
PE
3250 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3251 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3252 These were 'int' variables that could overflow on 64-bit hosts;
3253 they were never used, so remove them instead of repairing them.
211a0b2a 3254 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3255 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3256 Previously, this ceilinged at INT_MAX, but that doesn't work on
3257 64-bit machines.
e46bb31a 3258 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3259
c78baabf 3260 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3261 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3262 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3263 when a (possibly-narrower) signed value would do just as well.
3264 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3265
c9d624c6
PE
3266 * alloc.c: Catch some string size overflows that we were missing.
3267 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3268 for convenience in STRING_BYTES_MAX.
3269 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3270 The definition here is exact; the one in lisp.h was approximate.
3271 (allocate_string_data): Check for string overflow. This catches
3272 some instances we weren't catching before. Also, it catches
3273 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3274 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3275 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3276
c9d624c6
PE
3277 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3278 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3279 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3280
353032ce
PE
3281 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3282
2bccce07
PE
3283 * alloc.c (Fmake_string): Check for out-of-range init.
3284
0ac30604
SM
32852011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3286
3287 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3288
c195f2de
JD
32892011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3290
3291 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3292 xg_get_default_scrollbar_width.
3293
3294 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3295 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3296 (style_changed_cb): Call update_theme_scrollbar_width and call
3297 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3298 all frames (Bug#8505).
3299 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3300 Call gtk_window_set_resizable if HAVE_GTK3.
3301 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3302 and height if HAVE_GTK3 (Bug#8505).
3303 (scroll_bar_width_for_theme): New variable.
3304 (update_theme_scrollbar_width): New function.
3305 (xg_get_default_scrollbar_width): Move code to
3306 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3307 (xg_initialize): Call update_theme_scrollbar_width.
3308
3309 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3310
3311 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3312
e10ac9f1
MR
33132011-06-12 Martin Rudalics <rudalics@gmx.at>
3314
3315 * frame.c (make_frame): Call other_buffer_safely instead of
3316 other_buffer.
3317
3318 * window.c (temp_output_buffer_show): Call display_buffer with
3319 second argument Vtemp_buffer_show_specifiers and reset latter
3320 immediately after the call.
3321 (Vtemp_buffer_show_specifiers): New variable.
3322 (auto_window_vscroll_p, next_screen_context_lines)
3323 (Vscroll_preserve_screen_position): Remove leading asterisks from
3324 doc-strings.
3325
2d3c217e 33262011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3327
7b7f97e8 3328 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3329 * buffer.c (Qclone_number): Remove for now, as it's unused.
3330 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3331 (record_buffer): Remove unused local.
3332 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3333 (set_frame_buffer_list): Remove; unused.
3334 * frame.h (other_visible_frames): Remove decl.
3335 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3336 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3337 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3338 if HAVE_GPM.
3339 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3340 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3341 Define only if HAVE_GPM.
3342 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3343 (update_hints_inhibit): Remove; never set. All uses removed.
3344 * widgetprv.h (emacsFrameClassRec): Remove decl.
3345 * window.c (delete_deletable_window): Now returns void, since it
3346 wasn't returning anything.
3347 (compare_window_configurations): Remove unused locals.
3348 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3349 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3350 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3351 the same widths as pointers. This follows up on the 2011-05-06 patch.
3352 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3353 * xterm.h: Likewise.
3354 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3355
1384b89e
JB
33562011-06-12 Juanma Barranquero <lekktu@gmail.com>
3357
3358 * makefile.w32-in: Update dependencies.
3359 (LISP_H): Add lib/intprops.h.
3360
1100a63c
CY
33612011-06-11 Chong Yidong <cyd@stupidchicken.com>
3362
3363 * image.c (gif_load): Add animation frame delay to the metadata.
3364 (syms_of_image): Use DEFSYM. New symbol `delay'.
3365
6198ccd0
MR
33662011-06-11 Martin Rudalics <rudalics@gmx.at>
3367
3368 * window.c (delete_deletable_window): Re-add.
3369 (Fset_window_configuration): Rewrite to handle dead buffers and
3370 consequently deletable windows.
3371 (window_tree, Fwindow_tree): Remove. Supply functionality in
3372 window.el.
3373 (compare_window_configurations): Simplify code.
3374
b6e3633c
AS
33752011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3376
1ab0dee5
AS
3377 * image.c (imagemagick_load_image): Fix type mismatch.
3378 (Fimagemagick_types): Likewise.
3379
b6e3633c
AS
3380 * window.h (replace_buffer_in_windows): Declare.
3381
9397e56f
MR
33822011-06-11 Martin Rudalics <rudalics@gmx.at>
3383
3384 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3385 Qclone_number. Remove external declaration of Qdelete_window.
3386 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3387 code.
640c8776
SM
3388 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3389 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3390 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3391 buffer list implementation.
3392 (other_buffer_safely): New function.
3393 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3394 calls to replace_buffer_in_windows and
3395 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3396 if allowed.
3397 (record_buffer): Inhibit quitting and rewrite using quittable
3398 functions. Run Qbuffer_list_update_hook if allowed.
3399 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3400 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3401 Move switch-to-buffer to window.el.
9397e56f
MR
3402 (bury-buffer): Move to window.el.
3403 (Vbuffer_list_update_hook): New variable.
3404
3405 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3406 section.
3407
3408 * window.h (resize_frame_windows): Move up in code.
3409 (Fwindow_frame): Remove EXFUN.
3410 (replace_buffer_in_all_windows): Remove prototype.
3411 (replace_buffer_in_windows_safely): Add prototype.
3412
3413 * window.c: Declare Qdelete_window static again. Move down
3414 declaration of select_count.
3415 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3416 (Fother_window): Move to window.el.
3417 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3418 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3419 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3420 window.el.
3421 (replace_buffer_in_windows): Implement by calling
3422 Qreplace_buffer_in_windows.
3423 (replace_buffer_in_all_windows): Remove with some functionality
3424 moved into replace_buffer_in_windows_safely.
3425 (replace_buffer_in_windows_safely): New function.
3426 (select_window_norecord, select_frame_norecord): Move in front
3427 of run_window_configuration_change_hook. Remove now obsolete
3428 declarations.
640c8776
SM
3429 (Fset_window_buffer): Rewrite doc-string.
3430 Call Qrecord_window_buffer.
9397e56f
MR
3431 (keys_of_window): Move binding for other-window to window.el.
3432
b50691aa
CY
34332011-06-11 Chong Yidong <cyd@stupidchicken.com>
3434
3435 * dispextern.h (struct image): Replace data member, whose int_val
3436 and ptr_val fields were not used by anything, with a single
3437 lisp_val object.
3438
3439 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3440 (gif_clear_image, gif_load, imagemagick_load_image)
3441 (gs_clear_image, gs_load): Callers changed.
3442
3f754b86
PE
34432011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3444
cca69397
PE
3445 * buffer.h: Include <time.h>, for time_t.
3446 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3447
109e28d0
PE
3448 Fix minor problems found by static checking.
3449
60737f02
PE
3450 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3451
4b66faf3
PE
3452 Make identifiers static if they are not used in other modules.
3453 * data.c (Qcompiled_function, Qframe, Qvector):
3454 * image.c (QimageMagick, Qsvg):
3455 * minibuf.c (Qmetadata):
3456 * window.c (resize_window_check, resize_root_window): Now static.
3457 * window.h (resize_window_check, resize_root_window): Remove decls.
3458
109e28d0
PE
3459 * window.c (window_deletion_count, delete_deletable_window):
3460 Remove; unused.
46a4ce9e
PE
3461 (window_body_lines): Now static.
3462 (Fdelete_other_windows_internal): Mark vars as initialized.
3463 Make sure 'resize_failed' is initialized.
3464 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3465 (resize_window_apply): Remove unused local.
3466 * window.h (delete_deletable_window): Remove decl.
3467
109e28d0 3468 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3469 (imagemagick_load_image): Fix pointer signedness problem by changing
3470 last arg from unsigned char * to char *. All uses changed.
3471 Also, fix a local for similar reasons.
3472 Remove unused locals. Remove locals to avoid shadowing.
3473 (fn_rsvg_handle_free): Remove; unused.
3474 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3475 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3476
3f754b86
PE
3477 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3478
2547adb1
CY
34792011-06-10 Chong Yidong <cyd@stupidchicken.com>
3480
3481 * image.c (gif_load): Fix omitted cast error introduced by
3482 2011-06-06 change.
3483
2c8e37d4
MR
34842011-06-10 Martin Rudalics <rudalics@gmx.at>
3485
3486 * window.h (resize_proportionally, orig_total_lines)
3487 (orig_top_line): Remove from window structure.
3488 (set_window_height, set_window_width, change_window_heights)
3489 (Fdelete_window): Remove prototypes.
3490 (resize_frame_windows): Remove duplicate declaration.
3491
440a42e3
EZ
34922011-06-10 Eli Zaretskii <eliz@gnu.org>
3493
3494 * window.h (resize_frame_windows, resize_window_check)
3495 (delete_deletable_window, resize_root_window)
3496 (resize_frame_windows): Declare prototypes.
3497
3498 * window.c (resize_window_apply): Make definition be "static" to
3499 match the prototype.
3500
562dd5e9
MR
35012011-06-10 Martin Rudalics <rudalics@gmx.at>
3502
3503 * window.c: Remove declarations of Qwindow_size_fixed,
3504 window_min_size_1, window_min_size_2, window_min_size,
3505 size_window, window_fixed_size_p, enlarge_window, delete_window.
3506 Remove static from declaration of Qdelete_window, it's
3507 temporarily needed by Fbury_buffer.
3508 (replace_window): Don't assign orig_top_line and
3509 orig_total_lines.
3510 (Fdelete_window, delete_window): Remove. Window deletion is
3511 handled by window.el.
640c8776
SM
3512 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3513 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3514 (Fdelete_other_windows): Remove. Deleting other windows is
3515 handled by window.el.
3516 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3517 handled in window.el.
3518 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3519 Window minimum sizes are handled in window.el.
3520 (shrink_windows, size_window, set_window_height)
3521 (set_window_width, change_window_heights, window_height)
3522 (window_width, CURBEG, CURSIZE, enlarge_window)
3523 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3524 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3525 handled in window.el.
3526 (make_dummy_parent): Rename to make_parent_window and give it a
3527 second argument horflag.
3528 (make_window): Don't set resize_proportionally any more.
3529 (Fsplit_window): Remove. Windows are split in window.el.
3530 (save_restore_action, save_restore_orig_size)
3531 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3532 Resize mini windows in window.el.
3533 (grow_mini_window, shrink_mini_window): Implement by calling
3534 Qresize_root_window_vertically, resize_window_check and
3535 resize_window_apply.
640c8776
SM
3536 (saved_window, Fset_window_configuration, save_window_save):
3537 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3538 resize_proportionally.
3539 (window_min_height, window_min_width): Move to window.el.
3540 (keys_of_window): Move bindings for delete-other-windows,
3541 split-window, delete-window and enlarge-window to window.el.
3542
3543 * buffer.c: Temporarily extern Qdelete_window.
3544 (Fbury_buffer): Temporarily call Qdelete_window instead of
3545 Fdelete_window (Fbury_buffer will move to window.el soon).
3546
3547 * frame.c (set_menu_bar_lines_1): Remove code handling
3548 orig_top_line and orig_total_lines.
3549
3550 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3551 set_window_height but set heights directly.
3552 (change_frame_size_1): Use resize_frame_windows.
3553
3554 * xdisp.c (init_xdisp): Don't use set_window_height but set
3555 heights directly.
3556
640c8776
SM
3557 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3558 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3559 run_window_configuration_change_hook.
3560
3561 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3562 instead of change_window_heights and run
3563 run_window_configuration_change_hook.
3564
1a13852e
MR
35652011-06-09 Martin Rudalics <rudalics@gmx.at>
3566
3567 * window.c (replace_window): Rename second argument REPLACEMENT to
3568 NEW. New third argument SETFLAG. Rewrite.
3569 (delete_window, make_dummy_parent): Call replace_window with
3570 third argument 1.
3571 (window_list_1): Move down in code.
3572 (run_window_configuration_change_hook): Move set_buffer part
3573 before select_frame_norecord part in order to unwind correctly.
3574 Rename count1 to count.
3575 (recombine_windows, delete_deletable_window, resize_root_window)
3576 (Fdelete_other_windows_internal)
3577 (Frun_window_configuration_change_hook, make_parent_window)
3578 (resize_window_check, resize_window_apply, Fresize_window_apply)
3579 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3580 (Fdelete_window_internal, Fresize_mini_window_internal):
3581 New functions.
1a13852e
MR
3582 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3583
f3d1777e
MR
35842011-06-08 Martin Rudalics <rudalics@gmx.at>
3585
496e208e
MR
3586 * window.h (window): Add some new members to window structure -
3587 normal_lines, normal_cols, new_total, new_normal, clone_number,
3588 splits, nest, prev_buffers, next_buffers.
3589 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3590 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3591
f3d1777e
MR
3592 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3593 Remove.
496e208e
MR
3594 (make_dummy_parent): Set new members of windows structure.
3595 (make_window): Move down in code. Handle new members of window
3596 structure.
3597 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3598 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3599 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3600 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3601 (Fset_window_next_buffers, Fset_window_clone_number):
3602 New functions.
496e208e
MR
3603 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3604 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3605 Doc-string fixes.
3606 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3607 Argument WINDOW can be now internal window too.
3608 (Fwindow_use_time): Move up in code.
3609 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3610 Rewrite doc-string.
3611 (Fset_window_configuration, saved_window)
3612 (Fcurrent_window_configuration, save_window_save): Handle new
3613 members of window structure.
b9e809c2
MR
3614 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3615 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3616 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3617 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3618 Qget_mru_window, Qresize_root_window,
3619 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3620 Qauto_buffer_name; staticpro them.
f3d1777e 3621
abde8f8c
MR
36222011-06-07 Martin Rudalics <rudalics@gmx.at>
3623
3624 * window.c (Fwindow_total_size, Fwindow_left_column)
3625 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3626 (Fwindow_list_1): New functions.
3627 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3628 (Fwindow_width, Fscroll_left, Fscroll_right):
3629 Use window_body_cols instead of window_box_text_cols.
3630 (delete_window, Fset_window_configuration):
3631 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3632 (delete_all_subwindows): Take a window as argument and not a
3633 structure. Rewrite.
190b47e6
MR
3634 (window_loop): Remove handling of GET_LRU_WINDOW and
3635 GET_LARGEST_WINDOW.
3636 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3637
3638 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3639 window_box_text_cols. delete_all_subwindows now takes a
3640 Lisp_Object as argument.
abde8f8c 3641
640c8776
SM
3642 * indent.c (compute_motion, Fcompute_motion):
3643 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3644
fa8a67e6
MR
3645 * frame.c (delete_frame): Call delete_all_subwindows with root
3646 window as argument.
3647
a54e3482
DC
36482011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3649
3650 * fns.c (Fputhash): Document return value.
3651
60002bf5
CY
36522011-06-06 Chong Yidong <cyd@stupidchicken.com>
3653
3654 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3655
0c671da6 36562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3657
b862a52a 3658 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3659
be44ca6c
PE
3660 Check for overflow when converting integer to cons and back.
3661 * charset.c (Fdefine_charset_internal, Fdecode_char):
3662 Use cons_to_unsigned to catch overflow.
3663 (Fencode_char): Use INTEGER_TO_CONS.
3664 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3665 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3666 * data.c (long_to_cons, cons_to_long): Remove.
3667 (cons_to_unsigned, cons_to_signed): New functions.
3668 These signal an error for invalid or out-of-range values.
3669 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3670 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3671 * font.c (Ffont_variation_glyphs):
3672 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3673 * lisp.h: Include <intprops.h>.
3674 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3675 (cons_to_signed, cons_to_unsigned): New decls.
3676 (long_to_cons, cons_to_long): Remove decls.
3677 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3678 (Fprimitive_undo): Use CONS_TO_INTEGER.
3679 * xfns.c (Fx_window_property): Likewise.
3680 * xselect.c: Include <limits.h>.
3681 (x_own_selection, selection_data_to_lisp_data):
3682 Use INTEGER_TO_CONS.
3683 (x_handle_selection_request, x_handle_selection_clear)
3684 (x_get_foreign_selection, Fx_disown_selection_internal)
3685 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3686 (lisp_data_to_selection_data): Use cons_to_unsigned.
3687 (x_fill_property_data): Use cons_to_signed.
3688 Report values out of range.
3689
d1f3d2af
PE
3690 Check for buffer and string overflow more precisely.
3691 * buffer.h (BUF_BYTES_MAX): New macro.
3692 * lisp.h (STRING_BYTES_MAX): New macro.
3693 * alloc.c (Fmake_string):
3694 * character.c (string_escape_byte8):
3695 * coding.c (coding_alloc_by_realloc):
3696 * doprnt.c (doprnt):
3697 * editfns.c (Fformat):
3698 * eval.c (verror):
3699 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3700 since they may not be the same number.
3701 * editfns.c (Finsert_char):
3702 * fileio.c (Finsert_file_contents):
3703 Likewise for BUF_BYTES_MAX.
3704
dd52fcea
PE
3705 * image.c: Use ptrdiff_t, not int, for sizes.
3706 (slurp_file): Switch from int to ptrdiff_t.
3707 All uses changed.
3708 (slurp_file): Check that file size fits in both size_t (for
3709 malloc) and ptrdiff_t (for sanity and safety).
3710
7f9bbdbb
PE
3711 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3712 if b->modtime has its maximal value.
3713
dfe18f82
PE
3714 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3715
84acfcf0
PE
3716 Don't assume time_t can fit into int.
3717 * buffer.h (struct buffer.modtime): Now time_t, not int.
3718 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3719 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3720
ccd9a01a
PE
3721 Minor fixes for signed vs unsigned integers.
3722 * character.h (MAYBE_UNIFY_CHAR):
3723 * charset.c (maybe_unify_char):
3724 * keyboard.c (read_char, reorder_modifiers):
3725 XINT -> XFASTINT, since the integer must be nonnegative.
3726 * ftfont.c (ftfont_spec_pattern):
3727 * keymap.c (access_keymap, silly_event_symbol_error):
3728 XUINT -> XFASTINT, since the integer must be nonnegative.
3729 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3730 since it makes no difference and we prefer signed.
3731 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3732 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3733 nonnegative.
3734
d6d100dd
SM
37352011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3736
3737 * window.h (Fwindow_frame): Declare.
3738
2b6148e4
PE
37392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3740
3741 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3742 (SPARE_MEMORY): Always define.
3743 (LARGE_REQUEST): Remove.
3744 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3745
f230ecc9
MR
37462011-06-06 Martin Rudalics <rudalics@gmx.at>
3747
727e958e
MR
3748 * lisp.h: Move EXFUNS for Fframe_root_window,
3749 Fframe_first_window and Fset_frame_selected_window to window.h.
3750
3751 * window.h: Move EXFUNS for Fframe_root_window,
3752 Fframe_first_window and Fset_frame_selected_window here from
3753 lisp.h.
3754
3755 * frame.c (Fwindow_frame, Fframe_first_window)
3756 (Fframe_root_window, Fframe_selected_window)
3757 (Fset_frame_selected_window): Move to window.c.
3758 (Factive_minibuffer_window): Move to minibuf.c.
3759 (Fother_visible_frames_p): New function.
3760
3761 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3762
f230ecc9
MR
3763 * window.c (decode_window, decode_any_window): Move up in code.
3764 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3765 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3766 (Fwindow_buffer): Move up and rewrite doc-string.
3767 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3768 (Fwindow_prev): New functions.
727e958e
MR
3769 (Fwindow_frame): Move here from frame.c. Accept any window as
3770 argument.
3771 (Fframe_root_window, Fframe_first_window)
3772 (Fframe_selected_window): Move here from frame.c. Accept frame
3773 or arbitrary window as argument. Update doc-strings.
3774 (Fminibuffer_window): Move up in code.
3775 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3776 (Fset_frame_selected_window): Move here from frame.c.
3777 Marginal rewrite.
727e958e
MR
3778 (Fselected_window, select_window, Fselect_window): Move up in
3779 code. Minor doc-string fixes.
f230ecc9 3780
4d09bcf6
PE
37812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3782
3783 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3784 Do not assume that spare memory exists; that assumption is valid
3785 only if SYSTEM_MALLOC.
3786 (LARGE_REQUEST): New macro, so that the issue of large requests
3787 is separated from the issue of spare memory.
3788
810928a2
AS
37892011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3790
172418ad
AS
3791 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3792 format. (Bug#8806)
3793
43f862f7
AS
3794 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3795
810928a2
AS
3796 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3797 before statements.
3798
a059fe24
JD
37992011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3800
3801 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3802
3803 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3804
3805 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3806 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3807
989bf368
JB
38082011-06-05 Juanma Barranquero <lekktu@gmail.com>
3809
3810 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3811
4b80f674
CY
38122011-06-04 Chong Yidong <cyd@stupidchicken.com>
3813
3814 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3815 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3816 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3817 New error handlers.
4b80f674
CY
3818 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3819 Obey Vx_select_enable_clipboard_manager. Catch errors in
3820 x_clipboard_manager_save (Bug#8779).
3821 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3822 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3823
99a33b77 38242011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3825
3826 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3827
99a33b77 38282011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3829
3830 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3831 in the current matrix if keep_current_p is non-zero.
3832
8264569d
EZ
38332011-06-04 Eli Zaretskii <eliz@gnu.org>
3834
3835 * bidi.c (bidi_level_of_next_char): Fix last change.
3836
57f97249
EZ
38372011-06-03 Eli Zaretskii <eliz@gnu.org>
3838
fec2107c 3839 Support bidi reordering of text covered by display properties.
57f97249 3840
fec2107c
EZ
3841 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3842 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3843 (bidi_cache_search, bidi_cache_iterator_state)
3844 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3845 (bidi_level_of_next_char, bidi_move_to_visually_next):
3846 Support character positions inside a run of characters covered by a
fec2107c
EZ
3847 display string.
3848 (bidi_paragraph_init, bidi_resolve_explicit_1)
3849 (bidi_level_of_next_char): Call bidi_fetch_char and
3850 bidi_fetch_char_advance instead of FETCH_CHAR and
3851 FETCH_CHAR_ADVANCE.
3852 (bidi_init_it): Initialize new members.
3853 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3854 definitions.
3855 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3856 instead of using explicit *_CHAR codes.
d6d100dd
SM
3857 (bidi_resolve_explicit, bidi_resolve_weak):
3858 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3859 bidirectional text is supported only in multibyte buffers.
3860 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3861 it to initialize the frame_window_p member of struct bidi_it.
3862 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3863 (bidi_resolve_explicit, bidi_resolve_weak)
3864 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3865 bidi_it->nchars is non-positive.
3866 (bidi_level_of_next_char): Don't try to lookup the cache for the
3867 next/previous character if nothing is cached there yet, or if we
3868 were just reseat()'ed to a new position.
c40e2fb2 3869
0e14fe90
EZ
3870 * xdisp.c (set_cursor_from_row): Set start and stop points
3871 according to the row's direction when priming the loop that looks
3872 for the glyph on which to display cursor.
3873 (single_display_spec_intangible_p): Function deleted.
3874 (display_prop_intangible_p): Reimplement to call
3875 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3876 Accept 3 additional arguments needed by handle_display_spec.
3877 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3878 values: lists, `(when COND...)' forms, etc.
3879 (single_display_spec_string_p): Support property values that are
3880 lists with the argument STRING its top-level element.
3881 (display_prop_string_p): Fix the condition for processing a
3882 property that is a list to be consistent with handle_display_spec.
fec2107c 3883 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3884 last portion of handle_display_prop.
3885 (compute_display_string_pos): Accept additional argument
3886 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3887 value of a `display' property is a "replacing spec".
3888 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3889 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3890 the display property, but just return a value indicating whether
3891 the display property will replace the characters it covers.
3892 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3893 frame_window_p members of struct bidi_it.
d6d100dd
SM
3894 (compute_display_string_pos, compute_display_string_end):
3895 New functions.
fec2107c
EZ
3896 (push_it): Accept second argument POSITION, where pop_it should
3897 jump to continue iteration.
3898 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3899
fec2107c
EZ
3900 * keyboard.c (adjust_point_for_property): Adjust the call to
3901 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3902
3903 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3904 (bidi_init_it): Update prototypes.
3905 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3906 (compute_display_string_pos, compute_display_string_end):
3907 Declare prototypes.
fec2107c
EZ
3908 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3909 EMACS_INT.
fc6f18ce 3910
40087514 39112011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3912
57f53182
PE
3913 Malloc failure behavior now depends on size of allocation.
3914 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3915 * lisp.h: Change signatures accordingly.
3916 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3917 All callers changed. (Bug#8762)
3918
3919 * gnutls.c: Use Emacs's memory allocators.
3920 Without this change, the gnutls library would invoke malloc etc.
3921 directly, which causes problems on non-SYNC_INPUT hosts, and which
3922 runs afoul of improving memory_full behavior. (Bug#8761)
3923 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3924 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3925 xfree instead of the default malloc, realloc, free.
3926 (Fgnutls_boot): No need to check for memory allocation failure,
3927 since xmalloc does that for us.
3928
ac32cd99 3929 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3930 * category.c (hash_get_category_set):
3931 * ccl.c (ccl_driver):
3932 * charset.c (Fdefine_charset_internal):
3933 * charset.h (struct charset.hash_index):
3934 * composite.c (get_composition_id, gstring_lookup_cache)
3935 (composition_gstring_put_cache):
3936 * composite.h (struct composition.hash_index):
3937 * dispextern.h (struct image.hash):
3938 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3939 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3940 (hashfn_equal, hashfn_user_defined, make_hash_table)
3941 (maybe_resize_hash_table, hash_lookup, hash_put)
3942 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3943 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3944 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3945 * image.c (make_image, search_image_cache, lookup_image)
3946 (xpm_put_color_table_h):
3947 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3948 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3949 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3950 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3951 * alloc.c (allocate_vectorlike):
3952 Check for overflow in vector size calculations.
3953 * ccl.c (ccl_driver):
3954 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3955 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3956 need to be updated by these changes.
40087514
PE
3957 * fns.c (make_hash_table, maybe_resize_hash_table):
3958 Check for integer overflow with large hash tables.
0de4bb68
PE
3959 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3960 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3961 (SXHASH_REDUCE): New macro.
3962 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3963 Use it instead of discarding useful hash info with large hash values.
3964 (sxhash_float): New function.
3965 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3966 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3967 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3968 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3969 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3970 Adjust signatures to match updated version of code.
3971 (consing_since_gc): Now EMACS_INT, since a single hash table can
3972 use more than INT_MAX bytes.
3973
698d32e2
DN
39742011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3975
3976 Make it possible to build with GCC-4.6+ -O2 -flto.
3977
3978 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3979
fd6fa53f
SM
39802011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3981
3982 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3983 Call minibuffer-inactive-mode.
3984
864db017
JB
39852011-05-31 Juanma Barranquero <lekktu@gmail.com>
3986
3987 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3988 Update dependencies.
3989
2ad0baf4
DN
39902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3991
3992 * data.c (init_data): Remove code for UTS, this system is not
3993 supported anymore.
3994
4fcc2638
DN
39952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3996
3997 Don't force ./temacs to start in terminal mode.
3998
3999 * frame.c (make_initial_frame): Initialize faces in all cases, not
4000 only when CANNOT_DUMP is defined.
4001 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4002
c56e0fd5
DN
40032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4004
4005 * dispnew.c (add_window_display_history): Use const for the string
4006 pointer. Remove declaration, not needed.
4007
333d54da 40082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4009
55d4c1b2 4010 Use 'inline', not 'INLINE'.
333d54da 4011 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4012 * alloc.c, fontset.c (INLINE): Remove.
4013 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4014 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4015 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4016 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4017 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4018
738db178
DN
40192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4020
4021 Make it possible to run ./temacs.
4022
4023 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4024 syms_of_callproc does the same thing. Remove test for
4025 "initialized", do it in the caller.
4026 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4027
620c53a6
SM
40282011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4029
4030 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4031 (read_minibuf): Use get_minibuffer.
4032 (syms_of_minibuf): Use DEFSYM.
4033 (Qmetadata): New var.
4034 * data.c (Qbuffer): Don't make it static.
4035 (syms_of_data): Use DEFSYM.
4036
e003a292
PE
40372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4038
4039 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4040 (CCL_CODE_MIN): New macro.
4041
ed008a6d
PE
40422011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4043
3687c2ef
PE
4044 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4045
ed008a6d
PE
4046 * eval.c (Qdebug): Now static.
4047 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4048 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4049 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4050
d66c4c7c
CY
40512011-05-29 Chong Yidong <cyd@stupidchicken.com>
4052
4053 * image.c: Various fixes to ImageMagick code comments.
4054 (Fimagemagick_types): Doc fix.
4055
5fbc2025
PE
40562011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4057
0196f88a
PE
4058 Minor fixes prompted by GCC 4.6.0 warnings.
4059
4060 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4061
5fbc2025
PE
4062 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4063 (x_clipboard_manager_save_all): Move extern decl to ...
4064 * xterm.h: ... here, so that it can be checked for consistency.
4065
1dd3c2d9
CY
40662011-05-29 Chong Yidong <cyd@stupidchicken.com>
4067
4068 * xselect.c (x_clipboard_manager_save_frame)
4069 (x_clipboard_manager_save_all): New functions.
4070 (Fx_clipboard_manager_save): Lisp function deleted.
4071
4072 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4073 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4074
4075 * xterm.h: Update prototype.
4076
5ba6571d
WX
40772011-05-28 William Xu <william.xwl@gmail.com>
4078
4079 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4080 exiting (Bug#8239).
4081
3eaff834
JM
40822011-05-28 Jim Meyering <meyering@redhat.com>
4083
e1900994 4084 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4085 * fns.c (to_uchar): Define.
4086 (crypto_hash_function): Use it to convert some newly-signed
4087 variables to unsigned, to avoid sign-extension bugs. For example,
4088 without this change, (md5 "truc") would evaluate to
4089 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4090 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4091 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4092
0f6990a7
PE
40932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4094
4095 Integer overflow fixes.
c8a9ca5a 4096
08686060
PE
4097 * dbusbind.c: Serial number integer overflow fixes.
4098 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4099 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4100 to hold a serial number that is too large for a fixnum.
4101 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4102 Check for serial numbers out of range. Decode any serial number
59568bf0 4103 that was so large that it became a float. (Bug#8722)
08686060 4104
2d1fc3c7
PE
4105 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4106 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4107 Use XFASTINT rather than XUINT when numbers are nonnegative.
4108 (xd_append_arg, Fdbus_method_return_internal):
4109 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4110 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4111 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4112 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4113 (Bug#8722)
2d1fc3c7 4114
c8a9ca5a
PE
4115 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4116
519e1d69
PE
4117 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4118
30569699
PE
4119 ccl: add integer overflow checks
4120 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4121 (IN_INT_RANGE): New macros.
4122 (ccl_driver): Use them to check for integer overflow when
4123 decoding a CCL program. Many of the new checks are whether XINT (x)
4124 fits in int; it doesn't always, on 64-bit hosts. The new version
4125 doesn't catch all possible integer overflows, but it's an
847044ea 4126 improvement. (Bug#8719)
30569699 4127
c11285dc
PE
4128 * alloc.c (make_event_array): Use XINT, not XUINT.
4129 There's no need for unsigned here.
4130
fdccd48e
PE
4131 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4132 This follows up to the 2011-05-06 change that substituted uintptr_t
4133 for EMACS_INT. This case wasn't caught back then.
4134
37910ab2
PE
4135 Rework Fformat to avoid integer overflow issues.
4136 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4137 now (part of C89). Include <verify.h>.
4138 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4139 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4140 (Fformat): Avoid the prepass trying to compute sizes; it was only
4141 approximate and thus did not catch overflow reliably. Instead, walk
4142 through the format just once, formatting and computing sizes as we go,
4143 checking for integer overflow at every step, and allocating a larger
4144 buffer as needed. Keep track separately whether the format is
4145 multibyte. Keep only the most-recently calculated precision, rather
4146 than them all. Record whether each argument has been converted to
4147 string. Use EMACS_INT, not int, for byte and char and arg counts.
4148 Support field widths and precisions larger than INT_MAX. Avoid
4149 sprintf's undefined behavior with conversion specifications such as %#d
4150 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4151 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4152 formatting out-of-range floating point numbers with int
9173deec 4153 formats. (Bug#8668)
37910ab2 4154
2e6578fb
PE
4155 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4156
0ae6bdee
PE
4157 * data.c: Avoid integer truncation in expressions involving floats.
4158 * data.c: Include <intprops.h>.
4159 (arith_driver): When there's an integer overflow in an expression
4160 involving floating point, convert the integers to floating point
4161 so that the resulting value does not suffer from catastrophic
4162 integer truncation. For example, on a 64-bit host (* 4
4163 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4164 Do not rely on undefined behavior after integer overflow.
4165
de883a70
PE
4166 merge count_size_as_multibyte, parse_str_to_multibyte
4167 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4168 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4169 Check for integer overflow.
4170 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4171 since it's now a duplicate of the other. This is more of
4172 a character than a buffer op, so better that it's in character.c.
4173 * fns.c, print.c: Adjust to above changes.
4174
2ff916cb
PE
41752011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4176
4177 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4178
f1b54466
PE
41792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4180
fb1ac845
PE
4181 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4182 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4183 (x_clipboard_manager_save): Now static.
4184 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4185
f1b54466
PE
4186 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4187 (crypto_hash_function): Now static.
4188 Fix pointer signedness problems. Avoid unnecessary initializations.
4189
a9f737ee
CY
41902011-05-27 Chong Yidong <cyd@stupidchicken.com>
4191
4192 * termhooks.h (Vselection_alist): Make it terminal-local.
4193
4194 * terminal.c (create_terminal): Initialize it.
4195
4196 * xselect.c: Support for clipboard managers.
4197 (Vselection_alist): Move to termhooks.h as terminal-local var.
4198 (LOCAL_SELECTION): New macro.
4199 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4200 (symbol_to_x_atom): Remove gratuitous arg.
4201 (x_handle_selection_request, lisp_data_to_selection_data)
4202 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4203 (x_own_selection, x_get_local_selection, x_convert_selection):
4204 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4205 (some_frame_on_display): Delete unused function.
4206 (Fx_own_selection_internal, Fx_get_selection_internal)
4207 (Fx_disown_selection_internal, Fx_selection_owner_p)
4208 (Fx_selection_exists_p): New optional frame arg.
4209 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4210 (x_handle_selection_clear): Don't treat other terminals with the
4211 same keyboard specially. Use the terminal-local Vselection_alist.
4212 (x_clear_frame_selections): Use Frun_hook_with_args.
4213
4214 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4215
4216 * xterm.h: Add support for those atoms.
4217
e067f0c1
CY
42182011-05-26 Chong Yidong <cyd@stupidchicken.com>
4219
4220 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4221 (converted_selections, conversion_fail_tag): New global variables.
4222 (x_selection_request_lisp_error): Free the above.
4223 (x_get_local_selection): Remove unnecessary code.
4224 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4225 of converted selections stored in converted_selections.
4226 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4227 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4228 (x_convert_selection): New function.
4229 (x_handle_selection_event): Simplify.
4230 (x_get_foreign_selection): Don't ignore incoming requests while
4231 waiting for an answer; this will fail when we implement
4232 SAVE_TARGETS, and seems unnecessary anyway.
4233 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4234 (Vx_sent_selection_functions): Doc fix.
4235
0f4aebc0
LL
42362011-05-26 Leo Liu <sdl.web@gmail.com>
4237
4238 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4239
e61124cd
YM
42402011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4241
4242 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4243
4244 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4245 for fringe update if it has periodic bitmap.
ac389d0c 4246 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4247 and fringe_bitmap_periodic_p.
4248
4249 * fringe.c (get_fringe_bitmap_data): New function.
4250 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4251 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4252 row. Mark glyph row for fringe update if periodicity changed.
4253
4254 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4255 for fringe update unless it has periodic bitmap.
4256
f16d9837
KH
42572011-05-25 Kenichi Handa <handa@m17n.org>
4258
4259 * xdisp.c (get_next_display_element): Set correct it->face_id for
4260 a static composition.
4261
e1b90ef6
LL
42622011-05-24 Leo Liu <sdl.web@gmail.com>
4263
4264 * deps.mk (fns.o):
4265 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4266
4267 * fns.c (crypto_hash_function, Fsha1): New function.
4268 (Fmd5): Use crypto_hash_function.
4269 (syms_of_fns): Add Ssha1.
4270
7400048f
PE
42712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4272
4273 * gnutls.c: Remove unused macros.
4274 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4275 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4276 Remove macros that are defined and never used.
4277 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4278
abb71cf4
CY
42792011-05-22 Chong Yidong <cyd@stupidchicken.com>
4280
4281 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4282 (Fx_get_selection_internal): Minor cleanup.
4283 (Fx_own_selection_internal): Rename arguments for consistency with
4284 select.el.
4285
6307db39
PE
42862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4287
4288 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4289
f3d4e0a4
CY
42902011-05-22 Chong Yidong <cyd@stupidchicken.com>
4291
4292 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4293
4d8ade89
YM
42942011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4295
4296 * dispnew.c (scrolling_window): Don't exclude the case that the
4297 last enabled row in the desired matrix touches the bottom boundary.
4298
32078c8d
GM
42992011-05-21 Glenn Morris <rgm@gnu.org>
4300
4301 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4302 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4303 and add some more files.
32078c8d 4304
7285dc67
EZ
43052011-05-20 Eli Zaretskii <eliz@gnu.org>
4306
4307 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4308 report_file_error introduced by the change from 2011-05-07.
4309
89d1bd22
PE
43102011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4311
4312 * systime.h (Time): Define only if emacs is defined.
4313 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4314 where the include path doesn't have X11/X.h by default. See
4315 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4316
e23640bb 43172011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4318
4319 * composite.c (find_automatic_composition): Fix previous change.
4320
b9704ad9
GM
43212011-05-20 Glenn Morris <rgm@gnu.org>
4322
4323 * lisp.mk: New file, split from Makefile.in.
4324 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4325 (shortlisp): Remove.
4326 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4327
4a720484
GM
43282011-05-19 Glenn Morris <rgm@gnu.org>
4329
4330 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4331 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4332 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4333 (lisp): Set the order to that of loadup.el.
4334 (shortlisp): Make it a copy of $lisp.
4335 (SOME_MACHINE_LISP): Remove.
4336 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4337 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4338
a28d4396
KH
43392011-05-18 Kenichi Handa <handa@m17n.org>
4340
4341 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4342 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4343 (find_automatic_composition): Mostly rewrite for efficiency.
4344
a2b1fa8e
JB
43452011-05-18 Juanma Barranquero <lekktu@gmail.com>
4346
4347 * makefile.w32-in: Update dependencies.
4348
8e1f5610
CS
43492011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4350
4351 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4352 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4353
7025ee00 43542011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4355
cdfa6eab
PE
4356 Fix some integer overflow issues, such as string length overflow.
4357
06d6db33
PE
4358 * insdel.c (count_size_as_multibyte): Check for string overflow.
4359
2b4560a8
PE
4360 * character.c (lisp_string_width): Check for string overflow.
4361 Use EMACS_INT, not int, for string indexes and lengths; in
4362 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4363 the resulting string length overflows an EMACS_INT; instead,
4364 report a string overflow if no precision given. When checking for
4365 precision exhaustion, use a check that cannot possibly have
4366 integer overflow. (Bug#8675)
4367 * character.h (lisp_string_width): Adjust to new signature.
4368
cb93f9be
PE
4369 * alloc.c (string_overflow): New function.
4370 (Fmake_string): Use it. This doesn't change behavior, but saves
4371 a few bytes and will simplify future changes.
4372 * character.c (string_escape_byte8): Likewise.
4373 * lisp.h (string_overflow): New decl.
4374
1a1f3366
PE
4375 Fixups, following up to the user-interface timestamp change.
4376 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4377 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4378 * msdos.c (mouse_get_pos): Likewise.
4379 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4380 * w32gui.h (Time): Define by including "systime.h" rather than by
4381 declaring it ourselves. (Bug#8664)
4382
d4e3e4d3
PE
4383 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4384 * image.c (clear_image_cache): Likewise.
4385
f6a24d19
PE
4386 * term.c (term_mouse_position): Don't assume time_t wraparound.
4387
08dc5ae6
PE
4388 Be more systematic about user-interface timestamps.
4389 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4390 and sometimes 'EMACS_UINT', to represent these timestamps.
4391 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4392 This makes the code easier to follow, and makes it easier to catch
4393 integer overflow bugs such as Bug#8664.
4394 * frame.c (Fmouse_position, Fmouse_pixel_position):
4395 Use Time, not unsigned long, for user-interface timestamps.
4396 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4397 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4398 * keyboard.h (last_event_timestamp): Likewise.
4399 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4400 * menu.h (xmenu_show): Likewise.
4401 * term.c (term_mouse_position): Likewise.
4402 * termhooks.h (struct input_event.timestamp): Likewise.
4403 (struct terminal.mouse_position_hook): Likewise.
4404 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4405 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4406 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4407 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4408 what it was before.
4409 * menu.h, termhooks.h: Include "systime.h", for Time.
4410
8e55734a
PE
4411 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4412 Don't assume that the difference between two unsigned long values
4413 can fit into an integer. At this point, we know button_down_time
4414 <= event->timestamp, so the difference must be nonnegative, so
4415 there's no need to cast the result if double-click-time is
4416 nonnegative, as it should be; check that it's nonnegative, just in
4417 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4418 apart (about 25 days). (Bug#8664)
8e55734a 4419
841f1b75 4420 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4421 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4422
3e26f69c
PE
4423 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4424 that always fit in int. Use a sentinel instead of a counter, to
4425 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4426 * frame.h (struct frame): Use int for menu_bar_items_used
4427 instead of EMACS_INT, since it always fits in int.
3e26f69c 4428
5cc152c0
PE
4429 * menu.c (grow_menu_items): Check for int overflow.
4430
d89eb65e
PE
4431 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4432
5235bd3e
PE
4433 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4434 Before, the code was not consistent. These values cannot exceed
4435 2**31 - 1 so there's no need to make them unsigned.
4436 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4437 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4438 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4439 as modifiers.
4440 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4441
bc827e23
PE
4442 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4443 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4444 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4445 presumably because the widths might not match.
4446
78eb494e
PE
4447 * window.c (size_window): Avoid needless test at loop start.
4448
04f2d78b
CB
44492011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4450
4451 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4452
d2fc7e3d 44532011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4454
4455 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4456
d2fc7e3d 44572011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4458
4459 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4460 `width' to `bar_area_x' and `bar_area_width', respectively.
4461 (x_scroll_run): Take account of fringe background extension.
4462
04f2d78b
CB
4463 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4464 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4465 `bar_area_width', respectively.
4466 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4467 background extension.
4468
79b70037
GM
44692011-05-10 Jim Meyering <meyering@redhat.com>
4470
4471 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4472
2f142cc5
JB
44732011-05-10 Juanma Barranquero <lekktu@gmail.com>
4474
4475 * image.c (Finit_image_library): Return t for built-in image types,
4476 like pbm and xbm. (Bug#8640)
4477
57679c86
AS
44782011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4479
4480 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4481
888c9e86
EZ
44822011-05-07 Eli Zaretskii <eliz@gnu.org>
4483
b0512a1d
EZ
4484 * w32console.c (Fset_screen_color): Doc fix.
4485 (Fget_screen_color): New function.
4486 (syms_of_ntterm): Defsubr it.
4487
7285dc67
EZ
4488 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4489 unlink the temporary file if Fcall_process didn't create it in the
4490 first place.
4491 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4492 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4493 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4494 cue to call_process_cleanup not to close that handle.
4495
4d3fcc8e
BK
44962011-05-07 Ben Key <bkey76@gmail.com>
4497
4498 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4499 one of two shell specific rules, either bootstrap-temacs-CMD or
4500 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4501 to the previous implementation of the bootstrap-temacs rule.
4502 The bootstrap-temacs-CMD rule is similar to the previous
4503 implementation of the bootstrap-temacs rule except that it
4504 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4505 variable.
4506
4507 These changes, along with some changes to nt/configure.bat,
4508 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4509 earlier fix to add support for --cflags and --ldflags options
4510 that include quotes so that it works whether make uses cmd or
4511 sh as the shell.
4512
b4289b64
MA
45132011-05-06 Michael Albinus <michael.albinus@gmx.de>
4514
4515 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4516 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4517 is a constant.
4518 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4519 a string. Handle both cases.
4520 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4521 (Fdbus_register_method): Use Qinvalid_function.
4522
af4c0e28
JB
45232011-05-06 Juanma Barranquero <lekktu@gmail.com>
4524
4525 * makefile.w32-in: Update dependencies.
4526 (LISP_H): Add inttypes.h and stdin.h.
4527 (PROCESS_H): Add unistd.h.
4528
c51453d9
EZ
45292011-05-06 Eli Zaretskii <eliz@gnu.org>
4530
4531 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4532 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4533
8ff0ac3c 45342011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4535
4c4b566b
PE
4536 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4537
aab2b9b5
PE
4538 * term.c (vfatal): Remove stray call to va_end.
4539 It's not needed and the C Standard doesn't allow it here anyway.
4540
c378da0b
PE
4541 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4542 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4543
288b08c7
PE
4544 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4545 bytes.
4546
e3601888
PE
4547 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4548
db6c0e74
PE
4549 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4550
dd5963ea
PE
4551 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4552
88c9450f
PE
4553 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4554
2f9442b8
PE
4555 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4556
c032b5f8
PE
4557 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4558 * charset.c (Fdefine_charset_internal): Don't initialize
4559 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4560 32-bit int (Bug#8600).
a108c10b
PE
4561
4562 * lread.c (read_integer): Be more consistent with string-to-number.
4563 Use string_to_number to do the actual conversion; this avoids
4564 rounding errors and fixes some other screwups. Without this fix,
4565 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4566 (digit_to_number): Move earlier, for benefit of read_integer.
4567 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4568 not a digit in any supported base. (Bug#8602)
a108c10b 4569
ad5f9eea
PE
4570 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4571
aec1708a
PE
4572 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4573 to match comment at start of function. This also removes a
4574 GCC warning about overflow in a 32+64-bit port.
4575
47be4ab5
PE
4576 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4577
371cac43
PE
4578 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4579 Reported by Stefan Monnier in
4580 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4581 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4582 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4583
d01a7826
PE
4584 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4585 (EMACS_UINTPTR): Likewise, with uintptr_t.
4586
7fd47d5c
PE
4587 * lisp.h: Prefer 64-bit EMACS_INT if available.
4588 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4589 on 32-bit hosts that have 64-bit int, so that they can access
4590 large files.
122b0c86
PE
4591 However, temporarily disable this change unless the temporary
4592 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4593
8727937b
PE
4594 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4595
8ac068ac
PE
4596 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4597 This removes an assumption that EMACS_INT and long are the same
4598 width as pointers. The assumption is true for Emacs porting targets
4599 now, but we want to make other targets possible.
4600 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4601 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4602 In the rest of the code, change types of integers that hold casted
4603 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4604 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4605 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4606 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4607 No need to cast type when ORing.
4608 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4609 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4610 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4611 assume EMACS_INT is the same width as char *.
4612 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4613 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4614 Remove no-longer-needed casts.
4615 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4616 (xg_tool_bar_help_callback, xg_make_tool_item):
4617 Use EMACS_INTPTR to hold an integer
4618 that will be cast to void *; this can avoid a GCC warning
4619 if EMACS_INT is not the same width as void *.
4620 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4621 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4622 (current_message_1, set_message_1):
4623 Use a local to convert to proper width without a cast.
4624 * xmenu.c (dialog_selection_callback): Likewise.
4625
ede49d71
PE
4626 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4627 Also, don't assume VALBITS / RAND_BITS is less than 5,
4628 and don't rely on undefined behavior when shifting a 1 left into
4629 the sign bit.
4630 * lisp.h (get_random): Change signature to match.
4631
2f30ecd0
PE
4632 * lread.c (hash_string): Use size_t, not int, for hash computation.
4633 Normally we prefer signed values; but hashing is special, because
4634 it's better to use unsigned division on hash table sizes so that
4635 the remainder is nonnegative. Also, size_t is the natural width
4636 for hashing into memory. The previous code used 'int', which doesn't
4637 retain enough info to hash well into very large tables.
4638 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4639
2a866e7b
PE
4640 * dbusbind.c: Don't possibly lose pointer info when converting.
4641 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4642 Use XPNTR rather than XHASH, so that the high-order bits of
4643 the pointer aren't lost when converting through void *.
4644
51639eac
PE
4645 * eval.c (Fautoload): Don't double-shift a pointer.
4646
92394119
PE
4647 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4648
dbdb9a7c
JB
46492011-05-06 Juanma Barranquero <lekktu@gmail.com>
4650
4651 * gnutls.c (DEF_GNUTLS_FN):
4652 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4653
db7a0b4f
AS
46542011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4655
4656 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4657 marker. (Bug#8610)
4658
f7ff1b0f 46592011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4660
4661 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4662 New version that can reserve upto 2GB of heap space.
4663
f7ff1b0f 46642011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4665
4666 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4667
639c109b
TZ
46682011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4669
4670 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4671 `gnutls_certificate_set_x509_key_file'.
4672
d2127135
JB
46732011-05-05 Juanma Barranquero <lekktu@gmail.com>
4674
4675 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4676 Update dependencies.
4677
e968f4f3
JB
46782011-05-04 Juanma Barranquero <lekktu@gmail.com>
4679
4680 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4681 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4682 Remove unused parameter `fildes'.
4683 * process.c (read_process_output, send_process): Don't pass it.
4684
84d358f0
JB
46852011-05-04 Juanma Barranquero <lekktu@gmail.com>
4686
4687 Fix previous change: the library cache is defined in w32.c.
4688 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4689 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4690
0898ca10
JB
46912011-05-04 Juanma Barranquero <lekktu@gmail.com>
4692
4693 Implement dynamic loading of GnuTLS on Windows.
4694
4695 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4696 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4697 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4698 Declare.
4699
4700 * gnutls.c (Qgnutls_dll): Define.
4701 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4702 (gnutls_*): Declare function pointers.
4703 (init_gnutls_functions): New function to initialize function pointers.
4704 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4705 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4706 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4707 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4708 (emacs_gnutls_write, emacs_gnutls_read)
4709 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4710 (Fgnutls_available_p): New function.
4711 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4712 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4713 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4714
4715 * image.c: Include w32.h.
4716 (Vimage_type_cache): Delete.
4717 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4718 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4719 (w32_delayed_load): Move to w32.c.
4720
4721 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4722
4723 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4724 (w32_delayed_load): Move from image.c. When loading a library, record
4725 its filename in the :loaded-from property of the library id.
4726 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4727 Initialize and staticpro them.
4728 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4729
4730 * process.c: Include lisp.h before w32.h, not after.
4731 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4732 instead of gnutls_record_check_pending.
4733
4734 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4735
ff4de4aa
TZ
47362011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4737
4738 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4739 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4740 as passed in.
4741
abe95abb
JD
47422011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4743
4744 * xterm.c (x_set_frame_alpha): Do not set property on anything
4745 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4746
e16e55d4
JB
47472011-05-02 Juanma Barranquero <lekktu@gmail.com>
4748
4749 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4750
bafcf6a5
JB
47512011-05-02 Juanma Barranquero <lekktu@gmail.com>
4752
4753 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4754 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4755 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4756 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4757 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4758 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4759 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4760 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4761 (Qgnutls_bootprop_callbacks_verify): Make static.
4762
e7a6747f
AS
47632011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4764
19ed11ba
AS
4765 * callproc.c: Indentation fixup.
4766
e7a6747f 4767 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4768 (wait_for_termination, interruptible_wait_for_termination):
4769 Move after wait_for_termination_1.
e7a6747f 4770
1ef14cb4
LMI
47712011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4772
4773 * sysdep.c (interruptible_wait_for_termination): New function
4774 which is like wait_for_termination, but allows keyboard
4775 interruptions.
4776
4777 * callproc.c (Fcall_process): Add (:file "file") as an option for
4778 the STDOUT buffer.
4779 (Fcall_process_region): Ditto.
4780
330d880c
EZ
47812011-04-30 Eli Zaretskii <eliz@gnu.org>
4782
8db90b73
EZ
4783 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4784 rather than `XVECTOR (FOO)->size'.
4785
330d880c
EZ
4786 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4787 inttypes.h, as a gnulib replacement is used if it not available in
4788 system headers.
4789
15cbd324
EZ
47902011-04-21 Eli Zaretskii <eliz@gnu.org>
4791
4792 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4793 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4794 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4795
4796 * coding.c (coding_alloc_by_realloc): Error out if destination
4797 will grow beyond MOST_POSITIVE_FIXNUM.
4798 (decode_coding_emacs_mule): Abort if there isn't enough place in
4799 charbuf for the composition carryover bytes. Reserve an extra
4800 space for up to 2 characters produced in a loop.
4801 (decode_coding_iso_2022): Abort if there isn't enough place in
4802 charbuf for the composition carryover bytes.
4803
48042011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4805
ae940cca
EZ
4806 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4807 aborting when %lld or %lll format is passed.
4808 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4809 %llo or %llx format is passed. (Bug#8545)
4810
03ab8921
EZ
4811 * window.c (window_scroll_line_based): Use a marker instead of
4812 simple variables to record original value of point. (Bug#7952)
4813
afda1437
EZ
4814 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4815 produced by %s or %c overflows available buffer space. (Bug#8545)
4816
f76dee0c
PE
48172011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4818
4819 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4820 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4821
fdc5744d
JB
48222011-04-28 Juanma Barranquero <lekktu@gmail.com>
4823
4824 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4825
638f053a
JB
48262011-04-28 Juanma Barranquero <lekktu@gmail.com>
4827
4828 * keyboard.c (Qdelayed_warnings_hook): Define.
4829 (command_loop_1): Run `delayed-warnings-hook'
4830 if Vdelayed_warnings_list is non-nil.
4831 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4832 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4833
d178f871
EZ
48342011-04-28 Eli Zaretskii <eliz@gnu.org>
4835
4836 * doprnt.c (doprnt): Don't return value smaller than the buffer
4837 size if the message was truncated. (Bug#8545).
4838
b124fd93
JB
48392011-04-28 Juanma Barranquero <lekktu@gmail.com>
4840
4841 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4842 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4843
e810457d
PE
48442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4845
4846 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4847
ea51cceb
JB
48482011-04-27 Juanma Barranquero <lekktu@gmail.com>
4849
4850 * makefile.w32-in: Update dependencies.
4851
94dcfacf
EZ
48522011-04-27 Eli Zaretskii <eliz@gnu.org>
4853
4854 Improve `doprnt' and its usage. (Bug#8545)
4855 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4856 `format_end'. Remove support for %l as a conversion specifier.
4857 Don't use xrealloc. Improve diagnostics when the %l size modifier
4858 is used. Update the commentary.
4859
4860 * eval.c (verror): Simplify calculation of size_t.
4861
4862 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4863 messages.
4864
f61f41d7
PE
48652011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4866
4867 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4868 change.
4869
96fb4434
PE
48702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4871
4872 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4873 This makes this file independent of the recent pseudovector change.
4874
671875da 48752011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4876
69e9b5a3
PE
4877 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4878
b5f869a7 4879 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4880 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4881 Remove unused local.
c8926152 4882 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4883
841a1577 4884 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4885 GCC 4.6.0 optimizes based on type-based alias analysis.
4886 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4887 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4888 != &v->size, and therefore "v->size = 1; b->size = 2; return
4889 v->size;" must therefore return 1. This assumption is incorrect
4890 for Emacs, since it type-puns struct Lisp_Vector * with many other
4891 types. To fix this problem, this patch adds a new type struct
f904488f 4892 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4893 and pseudovectors, and helps optimizing compilers not get fooled
4894 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4895 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4896 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4897 the size member.
eab3844f
PE
4898 (XSETPVECTYPE): Rewrite in terms of new macro.
4899 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4900 This is a bit clearer, and further avoids the possibility of
4901 undesirable aliasing.
4902 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4903 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4904 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4905 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4906 (ASIZE): Now uses header.size rather than size.
4907 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4908 to avoid the hassle of writing XVECTOR (foo)->header.size.
4909 (struct vectorlike_header): New type.
eab3844f
PE
4910 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4911 object, to help avoid aliasing.
4912 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4913 (SUBRP): Likewise, since Lisp_Subr is a special case.
4914 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4915 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4916 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4917 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4918 changed to be "header.size" and "header.next".
4919 * buffer.h (struct buffer): Likewise.
4920 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4921 * frame.h (struct frame): Likewise.
4922 * process.h (struct Lisp_Process): Likewise.
4923 * termhooks.h (struct terminal): Likewise.
4924 * window.c (struct save_window_data, struct saved_window): Likewise.
4925 * window.h (struct window): Likewise.
4926 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4927 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4928 * buffer.c (init_buffer_once): Likewise.
4929 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4930 special case.
4931 * process.c (Fformat_network_address): Use local var for size,
4932 for brevity.
4933
0df1eac5
PE
4934 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4935
847ab9d1 4936 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4937 * data.c (atof): Remove decl; no longer used or needed.
4938 (digit_to_number): Move to lread.c.
4939 (Fstring_to_number): Use new string_to_number function, to be
4940 consistent with how the Lisp reader treats infinities and NaNs.
4941 Do not assume that floating-point numbers represent EMACS_INT
4942 without losing information; this is not true on most 64-bit hosts.
4943 Avoid double-rounding errors, by insisting on integers when
4944 parsing non-base-10 numbers, as the documentation specifies.
4945 * lisp.h (string_to_number): New decl, replacing ...
4946 (isfloat_string): Remove.
bc0a5c13 4947 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4948 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4949 appears to have been a coding error. Similarly, do not accept
4950 strings like +-1e0 as floating point numbers. Do not report
4951 overflow for integer overflows unless the base is not 10 which
4952 means we have no simple and reliable way to continue.
4953 Break out the floating-point parsing into a new
4954 function string_to_number, so that Fstring_to_number parses
4955 floating point numbers consistently with the Lisp reader.
04f2d78b 4956 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4957 (E_CHAR, EXP_INT): Remove, replacing with ...
4958 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4959 (string_to_number): New function, replacing isfloat_string.
4960 This function checks for valid syntax and produces the resulting
4961 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4962 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4963 so that overflow for non-base-10 numbers is reported only when
4964 there's no portable and simple way to convert to floating point.
452f4150 4965
67769ffc
PE
4966 * textprop.c (set_text_properties_1): Rewrite for clarity,
4967 and to avoid GCC warning about integer overflow.
4968
c20db43f
PE
4969 * intervals.h (struct interval): Use EMACS_INT for members
4970 where EMACS_UINT might cause problems. See
4971 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4972 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4973 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4974 All uses changed.
37aa2f85
PE
4975 (offset_intervals): Tell GCC not to worry about length overflow
4976 when negating a negative length.
c20db43f 4977
2538aa2f
PE
4978 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4979 (overrun_check_free): Likewise.
4980
f2d3008d
PE
4981 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4982 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4983 word size.
4984
ec8df744
PE
4985 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4986 (gnutls_make_error): Rename local to avoid shadowing.
4987 (gnutls_emacs_global_deinit): ifdef out; not used.
4988 (Fgnutls_boot): Use const for pointer to readonly storage.
4989 Comment out unused local. Fix pointer signedness problems.
4990
640ee02d
PE
4991 * lread.c (openp): Don't stuff size_t into an 'int'.
4992 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4993 about possible signed overflow.
4994
6048fb2a
PE
4995 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4996 (GDK_KEY_g): Don't define if already defined.
4997 (xg_prepare_tooltip): Avoid pointer signedness problem.
4998 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4999
fa3c87e1
PE
5000 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5001 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5002
2172544b
PE
5003 * xfns.c (Fx_window_property): Simplify a bit,
5004 to make a bit faster and to avoid GCC 4.6.0 warning.
5005 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5006
9b821a21
PE
5007 * fns.c (internal_equal): Don't assume size_t fits in int.
5008
3c616cfa
PE
5009 * alloc.c (compact_small_strings): Tighten assertion a little.
5010
c2982e87
PE
5011 Replace pEd with more-general pI, and fix some printf arg casts.
5012 * lisp.h (pI): New macro, generalizing old pEd macro to other
5013 conversion specifiers. For example, use "...%"pI"d..." rather
5014 than "...%"pEd"...".
5015 (pEd): Remove. All uses replaced with similar uses of pI.
5016 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5017 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5018 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5019 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5020 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5021 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5022 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5023 64-bit hosts.
5024 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5025 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5026 * print.c (safe_debug_print, print_object): Likewise.
5027 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5028 to int.
6f04d126
PE
5029 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5030 avoiding the 0 flag, which is not portable.
c2982e87
PE
5031 * process.c (Fmake_network_process): Use pI to avoid cast.
5032 * region-cache.c (pp_cache): Likewise.
5033 * xdisp.c (decode_mode_spec): Likewise.
5034 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5035 behavior on 64-bit hosts with printf arg.
6f04d126 5036 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5037 (x_stop_queuing_selection_requests): Likewise.
5038 (x_get_window_property): Don't truncate byte count to an 'int'
5039 when tracing.
0b432f21 5040
5e073ec7
PE
5041 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5042 here, since it parses constructs like leading '-' and spaces,
5043 which are not wanted; and it overflows with large numbers.
5044 Instead, simply match F[0-9]+, which is what is wanted anyway.
5045
36372bf9
PE
5046 * alloc.c: Remove unportable assumptions about struct layout.
5047 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5048 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5049 (allocate_vectorlike, make_pure_vector): Use the new macros,
5050 plus offsetof, to remove unportable assumptions about struct layout.
5051 These assumptions hold on all porting targets that I know of, but
5052 they are not guaranteed, they're easy to remove, and removing them
5053 makes further changes easier.
5054
0b432f21
PE
5055 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5056 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5057 (string_overrun_cookie): Now const. Use initializers that
5058 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5059 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5060 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5061 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5062 multiple of sizeof (EMACS_INT); it need not be, if
5063 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5064 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5065
895009e1
JB
50662011-04-26 Juanma Barranquero <lekktu@gmail.com>
5067
5068 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5069
6a7a1b0b
TZ
50702011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5071
5072 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5073 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5074 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5075
841a1577 50762011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5077
5078 * lisp.h (Qdebug): List symbol.
895009e1 5079 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5080 * keyboard.c (debug-on-event): New variable.
5081 (handle_user_signal): Break into debugger when debug-on-event
5082 matches the current signal symbol.
5083
f2d3ba6f
DN
50842011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5085
5086 * alloc.c (check_sblock, check_string_bytes)
5087 (check_string_free_list): Convert to standard C.
5088
42ce4c63
TZ
50892011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5090
5091 * w32.c (emacs_gnutls_push): Fix typo.
5092
825cd63c
EZ
50932011-04-25 Eli Zaretskii <eliz@gnu.org>
5094
fb11d64d
EZ
5095 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5096 "cast to pointer from integer of different size".
5097
825cd63c
EZ
5098 Improve doprnt and its use in verror. (Bug#8545)
5099 * doprnt.c (doprnt): Document the set of format control sequences
5100 supported by the function. Use SAFE_ALLOCA instead of always
5101 using `alloca'.
5102
5103 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5104 is one byte too soon. Don't use xrealloc; instead xfree and
5105 xmalloc anew.
5106
e061a11b
TZ
51072011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5108
5109 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5110 callbacks stage.
5111
5112 * gnutls.c: Renamed global_initialized to
5113 gnutls_global_initialized. Added internals for the
5114 :verify-hostname-error, :verify-error, and :verify-flags
5115 parameters of `gnutls-boot' and documented those parameters in the
5116 docstring. Start callback support.
9173deec
JB
5117 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5118 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5119 on error. Return error code.
e061a11b
TZ
5120 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5121 (emacs_gnutls_read): Likewise.
5122 (Fgnutls_boot): Return handshake error code.
5123 (emacs_gnutls_handle_error): New function.
5124 (wsaerror_to_errno): Likewise.
5125
5126 * w32.h (emacs_gnutls_pull): Add prototype.
5127 (emacs_gnutls_push): Likewise.
5128
5129 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5130 (emacs_gnutls_push): Likewise.
5131
51322011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5133
5134 * process.c (wait_reading_process_output): Check if GnuTLS
5135 buffered some data internally if no FDs are set for TLS
5136 connections.
5137
5138 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5139 (LIBS): Link to USER_LIBS.
5140 ($(BLD)/gnutls.$(0)): New target.
5141
fa6996bc
EZ
51422011-04-24 Eli Zaretskii <eliz@gnu.org>
5143
eb35682e
EZ
5144 * xdisp.c (handle_single_display_spec): Rename the
5145 display_replaced_before_p argument into display_replaced_p, to
5146 make it consistent with the commentary. Fix typos in the
5147 commentary.
5148
e2ad650c
EZ
5149 * textprop.c (syms_of_textprop): Remove dead code.
5150 (copy_text_properties): Delete obsolete commentary about an
5151 interface that was deleted long ago. Fix typos in the description
5152 of arguments.
5153
1b2de274
EZ
5154 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5155 to changes in oldXMenu/XMenu.h from 2011-04-16.
5156 <menu_help_message, prev_menu_help_message>: Constify.
5157 (IT_menu_make_room): menu->help_text is now `const char **';
5158 adjust.
5159
5160 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5161 to changes in oldXMenu/XMenu.h from 2011-04-16.
5162 (struct XMenu): Declare `help_text' `const char **'.
5163
5164 * xfaces.c <Qunspecified>: Make extern again.
5165
5166 * syntax.c: Include sys/types.h before including regex.h, as
5167 required by Posix.
5168
762b15be
EZ
5169 * doc.c (get_doc_string): Improve the format passed to `error'.
5170
5171 * doprnt.c (doprnt): Improve commentary.
5172
5173 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5174
5175 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5176 them with etags.
5177
f1052e5d
EZ
5178 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5179 changes in globals.h immediately force recompilation.
762b15be
EZ
5180 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5181 $(CURDIR)/s/ms-w32.h.
5182 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5183
fa6996bc
EZ
5184 * character.c (Fchar_direction): Function deleted.
5185 (syms_of_character): Don't defsubr it.
5186 <char-direction-table>: Deleted.
5187
e6c3da20
EZ
51882011-04-23 Eli Zaretskii <eliz@gnu.org>
5189
5190 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5191 * doprnt.c: Include limits.h.
5192 (SIZE_MAX): New macro.
04f2d78b
CB
5193 (doprnt): Return a size_t value. 2nd arg is now size_t.
5194 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5195 Improve overflow protection. Support `l' modifier for integer
5196 conversions. Support %l conversion. Don't assume an EMACS_INT
5197 argument for integer conversions and for %c.
5198
5199 * lisp.h (doprnt): Restore prototype.
5200
5201 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5202 $(SRC)/character.h.
5203
5204 * Makefile.in (base_obj): Add back doprnt.o.
5205
5206 * deps.mk (doprnt.o): Add back prerequisites.
5207 (callint.o): Depend on character.h.
5208
5209 * eval.c (internal_lisp_condition_case): Include the handler
5210 representation in the error message.
5211 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5212 when breaking from the loop.
5213
5214 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5215
5216 * callint.c (Fcall_interactively): When displaying error message
5217 about invalid control letter, pass the character's codepoint, not
5218 a pointer to its multibyte form. Improve display of the character
5219 in octal and display also its hex code.
5220
5221 * character.c (char_string): Use %x to display the (unsigned)
5222 codepoint of an invalid character, to avoid displaying a bogus
5223 negative value.
5224
5225 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5226 `error', not SYMBOL_NAME itself.
5227
5228 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5229 character arguments to `error'.
5230
5231 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5232 to `error' in error message about FINAL_CHAR argument. Make sure
5233 FINAL_CHAR is a character, and use %c when it is passed as
5234 argument to `error'.
5235
4ffd0d6b 52362011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5237
5238 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5239
5240 * w32.c: Include <time.h>.
5241 (sys_localtime): New function.
5242
4ffd0d6b 52432011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5244
5245 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5246
4ffd0d6b 5247 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5248
4ffd0d6b 52492011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5250
4ffd0d6b
GM
5251 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5252 zombies (Bug#8467).
aac0c6e3 5253
04c56954
EZ
52542011-04-19 Eli Zaretskii <eliz@gnu.org>
5255
5256 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5257 gl_state.e_property when gl_state.object is Qt.
5258
5259 * insdel.c (make_gap_larger): Remove limitation of buffer size
5260 to <= INT_MAX.
5261
16a43933
CY
52622011-04-18 Chong Yidong <cyd@stupidchicken.com>
5263
5264 * xdisp.c (lookup_glyphless_char_display)
5265 (produce_glyphless_glyph): Handle cons cell entry in
5266 glyphless-char-display.
5267 (Vglyphless_char_display): Document it.
5268
5269 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5270 glyphless-char-display.
5271
4581706e
CY
52722011-04-17 Chong Yidong <cyd@stupidchicken.com>
5273
5274 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5275
5276 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5277
5278 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5279 definition for no-X builds.
5280
4887c6e2 52812011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5282
fd35b6f9
PE
5283 Static checks with GCC 4.6.0 and non-default toolkits.
5284
5c1ccb01
PE
5285 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5286
006c5daa
PE
5287 * process.c (keyboard_bit_set): Define only if SIGIO.
5288 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5289 (send_process): Repair possible setjmp clobbering.
5290
efc736d3
PE
5291 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5292
4e2fe2e6
PE
5293 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5294
f97334a2
PE
5295 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5296
4e75f29d
PE
5297 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5298 Define only if needed.
5299
90efadd1
PE
5300 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5301 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5302 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5303
3c647824
PE
5304 * dispextern.h (struct redisplay_interface): Rename param
5305 to avoid shadowing.
e264f262 5306 * termhooks.h (struct terminal): Likewise.
761383f4 5307 * xterm.c (xembed_send_message): Likewise.
3c647824 5308
b58c5c4a
PE
5309 * insdel.c (make_gap_smaller): Define only if
5310 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5311
cad59032
PE
5312 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5313 it.
5314
c339dc2e
PE
5315 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5316 so that we aren't warned about unused symbols.
5317
91a3e27b
PE
5318 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5319
399c71d3 5320 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5321
8ffc96f5
PE
5322 * xfns.c (x_real_positions): Mark locals as initialized.
5323
eef9bc79
PE
5324 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5325
098db9dd
PE
5326 * xterm.c: Fix problems found by static analysis with other toolkits.
5327 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5328 (x_dispatch_event): Declare static if USE_GTK, and
5329 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5330 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5331 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5332 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5333 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5334
eb18f6cc
PE
5335 * xmenu.c (menu_help_callback): Pointer type fixes.
5336 Use const pointers when pointing at readonly data. Avoid pointer
5337 signedness clashes.
5338 (FALSE): Remove unused macro.
5339 (update_frame_menubar): Remove unused decl.
5340
1fe72bf8
PE
5341 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5342
60d9e1db
PE
5343 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5344 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5345 (single_menu_item): Rename local to avoid shadowing.
5346
39261c26
PE
5347 * keyboard.c (make_lispy_event): Remove unused local var.
5348
018c5e19
PE
5349 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5350 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5351
63d2b86e
PE
5352 * bitmaps: Change bitmaps from unsigned char back to the X11
5353 compatible char. Avoid the old compiler warnings about
5354 out-of-range initializers by using, for example, '\xab' rather
5355 than 0xab.
5356
aefd87e1
PE
5357 * xgselect.c (xgselect_initialize): Check vs interface
5358 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5359
bf501fb9
PE
5360 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5361
e9829fdf
PE
5362 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5363 to read-only memory.
5364
1086c095
PE
5365 * fns.c (vector): Remove; this old hack is no longer needed.
5366
2baccd04 5367 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5368 Remove unused var.
dde42981 5369 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5370
72391843 5371 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5372
436c16df 5373 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5374 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5375 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5376
92bb796d 5377 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5378 (x_term_init): Remove local to avoid shadowing.
92bb796d 5379
764430a3 5380 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5381
5382 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5383 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5384
d1dfb56c
EZ
53852011-04-16 Eli Zaretskii <eliz@gnu.org>
5386
c4354cb4
EZ
5387 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5388
d1dfb56c
EZ
5389 Fix regex.c, syntax.c and friends for buffers > 2GB.
5390 * syntax.h (struct gl_state_s): Declare character position members
5391 EMACS_INT.
5392
5393 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5394
04f2d78b
CB
5395 * textprop.c (verify_interval_modification, interval_of):
5396 Declare arguments EMACS_INT.
d1dfb56c
EZ
5397
5398 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5399 EMACS_INT.
5400
5401 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5402
5403 * indent.c (Fvertical_motion): Local variable it_start is now
5404 EMACS_INT.
5405
5406 * regex.c (re_match, re_match_2, re_match_2_internal)
5407 (bcmp_translate, regcomp, regexec, print_double_string)
5408 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5409 (re_compile_pattern, re_exec): Declare arguments and local
5410 variables `size_t' and `ssize_t' and return values `regoff_t', as
5411 appropriate.
5412 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5413 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5414 <compile_stack_type>: `size' and `avail' are now `size_t'.
5415
5416 * regex.h <regoff_t>: Use ssize_t, not int.
5417 (re_search, re_search_2, re_match, re_match_2): Arguments that
5418 specify buffer/string position and length are now ssize_t and
5419 size_t. Return type is regoff_t.
5420
613052cd
BK
54212011-04-16 Ben Key <bkey76@gmail.com>
5422
5423 * nsfont.m: Fixed bugs in ns_get_family and
5424 ns_descriptor_to_entity that were caused by using free to
5425 deallocate memory blocks that were allocated by xmalloc (via
5426 xstrdup). This caused Emacs to crash when compiled with
5427 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5428 --enable-checking=xmallocoverrun). xfree is now used to
5429 deallocate these memory blocks.
5430
4170f62f 54312011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5432
71b41406
PE
5433 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5434
9587a89d
PE
5435 emacs_write: Accept and return EMACS_INT for sizes.
5436 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5437 et seq.
5438 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5439 Accept and return EMACS_INT.
5440 (emacs_gnutls_write): Return the number of bytes written on
5441 partial writes.
5442 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5443 (emacs_read, emacs_write): Remove check for negative size, as the
5444 Emacs source code has been audited now.
9587a89d
PE
5445 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5446 (emacs_read, emacs_write): Use it.
273a5f82
PE
5447 * process.c (send_process): Adjust to the new signatures of
5448 emacs_write and emacs_gnutls_write. Do not attempt to store
5449 a byte offset into an 'int'; it might overflow.
9587a89d 5450 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5451
3e047f51
PE
5452 * sound.c: Don't assume sizes fit in 'int'.
5453 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5454 Return EMACS_INT, not int.
3e047f51 5455 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5456 Accept EMACS_INT, not int.
5457 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5458 record read return values.
5459
cc39a9db
BK
54602011-04-15 Ben Key <bkey76@gmail.com>
5461
c9d0ec6d
JB
5462 * keyboard.c (Qundefined): Don't declare static since it is used
5463 in nsfns.m.
5464 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5465 static since they are used in nsfont.m.
cc39a9db 5466
6c60eb9f
SM
54672011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5468
5469 * process.c (Qprocessp): Don't declare static.
5470 * lisp.h (Qprocessp): Declare again.
5471
7990b61a
JB
54722011-04-15 Juanma Barranquero <lekktu@gmail.com>
5473
5474 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5475
5d4cb038
PE
54762011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5477
8bd7b830 5478 Improve C-level modularity by making more things 'static'.
cd64ea1d 5479
e3b27b31
PE
5480 Don't publish debugger-only interfaces to other modules.
5481 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5482 (verify_bytepos, count_markers): Move decls to the only modules
5483 that need them.
5484 * region-cache.h (pp_cache): Likewise.
5485 * window.h (check_all_windows): Likewise.
5486 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5487
5d4cb038
PE
5488 * sysdep.c (croak): Now static, if
5489 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5490 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5491
5492 * alloc.c (refill_memory_reserve): Now static if
5493 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5494 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5495
e87b6180
PE
5496 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5497 Define only if USE_LUCID.
5498
ac64929e
PE
5499 * xrdb.c (x_customization_string, x_rm_string): Now static.
5500
6f37259d
PE
5501 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5502 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5503
1683e3ab
PE
5504 * xdisp.c (draw_row_with_mouse_face): Now static.
5505 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5506
de9c2632
PE
5507 * window.h (check_all_windows): Mark externally visible.
5508
2b96acb7
PE
5509 * window.c (window_deletion_count): Now static.
5510
5511 * undo.c: Make symbols static if they're not exported.
5512 (last_undo_buffer, last_boundary_position, pending_boundary):
5513 Now static.
5514
50436f33
PE
5515 * textprop.c (interval_insert_behind_hooks): Now static.
5516 (interval_insert_in_front_hooks): Likewise.
5517
64520e5c
PE
5518 * term.c: Make symbols static if they're not exported.
5519 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5520 (max_frame_lines, tty_set_terminal_modes):
5521 (tty_reset_terminal_modes, tty_turn_off_highlight):
5522 (get_tty_terminal): Now static.
5523 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5524 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5525 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5526 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5527 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5528
1fa53021
PE
5529 * sysdep.c: Make symbols static if they're not exported.
5530 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5531 Now static.
5532 (sigprocmask_set, full_mask): Remove; unused.
5533 (wait_debugging): Mark as visible.
5534 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5535 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5536
d4b43b22
PE
5537 * syntax.c (syntax_temp): Define only if !__GNUC__.
5538
b7c513d0
PE
5539 * sound.c (current_sound_device, current_sound): Now static.
5540
989b29ad
PE
5541 * search.c (searchbufs, searchbuf_head): Now static.
5542
13a55a78
PE
5543 * scroll.c (scroll_cost): Remove; unused.
5544 * dispextern.h (scroll_cost): Remove decl.
5545
de68a1fc
PE
5546 * region-cache.h (pp_cache): Mark as externally visible.
5547
40ccffa6
PE
5548 * process.c: Make symbols static if they're not exported.
5549 (process_tick, update_tick, create_process, chan_process):
5550 (Vprocess_alist, proc_buffered_char, datagram_access):
5551 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5552 (deactivate_process): Mark defn as static, as well as decl.
5553 * lisp.h (create_process): Remove decl.
5554 * process.h (chan_process, Vprocess_alist): Remove decls.
5555
ad64fc97
PE
5556 * print.c: Make symbols static if they're not exported.
5557 (print_depth, new_backquote_output, being_printed, print_buffer):
5558 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5559 (print_interval, print_number_index, initial_stderr_stream):
5560 Now static.
5561 * lisp.h (Fprinc): Remove decl.
5562 (debug_output_compilation_hack): Mark as externally visible.
5563
adddb265
PE
5564 * sysdep.c (croak): Move decl from here to syssignal.h.
5565 * syssignal.h (croak): Put it here, so the API can be checked when
5566 'croak' is called from dissociate_if_controlling_tty.
5567
1717ede2
PE
5568 * minibuf.c: Make symbols static if they're not exported.
5569 (minibuf_save_list, choose_minibuf_frame): Now static.
5570 * lisp.h (choose_minibuf_frame): Remove decl.
5571
fa5fb2bc
PE
5572 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5573
1e3890d1
PE
5574 * lread.c: Make symbols static if they're not exported.
5575 (read_objects, initial_obarray, oblookup_last_bucket_number):
5576 Now static.
5577 (make_symbol): Remove; unused.
5578 * lisp.h (initial_obarray, make_symbol): Remove decls.
5579
8a1414fa
PE
5580 * keyboard.c: Make symbols static if they're not exported.
5581 (single_kboard, recent_keys_index, total_keys, recent_keys):
5582 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5583 (this_single_command_key_start, echoing, last_auto_save):
5584 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5585 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5586 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5587 (Vlispy_mouse_stem, double_click_count):
5588 Now static.
5589 (force_auto_save_soon): Define only if SIGDANGER.
5590 (ignore_mouse_drag_p): Now static if
5591 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5592 (print_help): Remove; unused.
5593 (stop_character, last_timer_event): Mark as externally visible.
5594 * keyboard.h (ignore_mouse_drag_p): Declare only if
5595 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5596 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5597 * lisp.h (echoing): Remove decl.
5598 (force_auto_save_soon): Declare only if SIGDANGER.
5599 * xdisp.c (redisplay_window): Simplify code, to make it more
5600 obvious that ignore_mouse_drag_p is not accessed if !defined
5601 USE_GTK && !defined HAVE_NS.
5602
93ea6e8f
PE
5603 * intervals.c: Make symbols static if they're not exported.
5604 (merge_properties_sticky, merge_interval_right, delete_interval):
5605 Now static.
5606 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5607
77382fcc
PE
5608 * insdel.c: Make symbols static if they're not exported.
5609 However, leave prepare_to_modify_buffer alone. It's never
5610 called from outside this function, but that appears to be a bug.
5611 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5612 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5613 (adjust_after_replace_noundo): Remove; unused.
5614 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5615 (signal_before_change): Remove decls.
77382fcc 5616
9306c32e
PE
5617 * indent.c (val_compute_motion, val_vmotion): Now static.
5618
cd44d2eb
PE
5619 * image.c: Make symbols static if they're not exported.
5620 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5621 if USE_GTK.
5622 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5623 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5624
ad9a7a06
PE
5625 * fringe.c (standard_bitmaps): Now static.
5626 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5627
81626931
PE
5628 * frame.c: Make symbols static if they're not exported.
5629 (x_report_frame_params, make_terminal_frame): Now static.
5630 (get_frame_param): Now static, unless HAVE_NS.
5631 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5632 (x_get_resource_string): Remove; not used.
5633 * frame.h (make_terminal_frame, x_report_frame_params):
5634 (x_get_resource_string); Remove decls.
5635 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5636 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5637
239f9db9
PE
5638 * font.c, fontset.c: Make symbols static if they're not exported.
5639 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5640 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5641 * font.c (font_close_object): Now static.
5642 * font.h (font_close_object): Remove.
5643 * fontset.c (FONTSET_OBJLIST): Remove.
5644 (free_realized_fontset) #if-0 the body, which does nothing.
5645 (face_suitable_for_char_p): #if-0, as it's never called.
5646 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5647 * xfaces.c (face_at_string_position):
5648 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5649 since 0 is always ASCII.
5650
dfcf3579
PE
5651 * fns.c (weak_hash_tables): Now static.
5652
5045092b
PE
5653 * fileio.c: Make symbols static if they're not exported.
5654 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5655 (Vwrite_region_annotation_buffers): Now static.
5656
57a96f5c
PE
5657 * eval.c: Make symbols static if they're not exported.
5658 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5659 * lisp.h (backtrace_list): Remove decl.
5660
35f08c38
PE
5661 * emacs.c: Make symbols static if they're not exported.
5662 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5663 (fatal_error_code, fatal_error_signal_hook, standard_args):
5664 Now static.
5665 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5666 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5667 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5668 * lisp.h (fatal_error_signal_hook): Remove decl.
5669 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5670
f44bd759
PE
5671 * editfns.c: Move a (normally-unused) function to its only use.
5672 * editfns.c, lisp.h (get_operating_system_release): Remove.
5673 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5674 worth the hassle of breaking this out.
5675
b532497d
PE
5676 * xterm.c: Make symbols static if they're not exported.
5677 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5678 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5679 (x_destroy_window, x_delete_display):
5680 Now static.
5681 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5682 (x_mouse_leave): Remove; unused.
5683 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5684 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5685 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5686 Remove decls.
5687 (x_mouse_leave): Declare only if WINDOWSNT.
5688 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5689 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5690 USE_X_TOOLKIT.
5691
1675728f
PE
5692 * ftxfont.c: Make symbols static if they're not exported.
5693 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5694 HAVE_FREETYPE.
5695 * font.h (ftxfont_driver): Likewise.
5696
e4cebfca
PE
5697 * xfns.c: Make symbols static if they're not exported.
5698 (x_last_font_name, x_display_info_for_name):
5699 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5700 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5701 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5702 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5703 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5704 (last_show_tip_args): Now static.
5705 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5706 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5707 (x_screen_planes): Remove; unused.
5708 * dispextern.h (x_screen_planes): Remove decl.
5709
5bf46f05
PE
5710 * dispnew.c: Make symbols static if they're not exported.
5711 * dispextern.h (redraw_garbaged_frames, scrolling):
5712 (increment_row_positions): Remove.
5713 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5714 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5715 Now static.
5716 (redraw_garbaged_frames): Remove; unused.
5717
435f4c28
PE
5718 * xfaces.c: Make symbols static if they're not exported.
5719 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5720 Remove decls.
5721 * xterm.h (defined_color): Remove decls.
5722 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5723 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5724 (menu_face_changed_default, defined_color, free_realized_face):
5725 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5726 (ascii_face_of_lisp_face): Remove; unused.
5727
8524aef3
PE
5728 * xdisp.c: Make symbols static if they're not exported.
5729 * dispextern.h (scratch_glyph_row, window_box_edges):
5730 (glyph_to_pixel_coords, set_cursor_from_row):
5731 (get_next_display_element, set_iterator_to_next):
5732 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5733 (show_mouse_face): Remove decls
5734 * frame.h (message_buf_print): Likewise.
5735 * lisp.h (pop_message, set_message, check_point_in_composition):
5736 Likewise.
5737 * xterm.h (set_vertical_scroll_bar): Likewise.
5738 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5739 (message_buf_print, scratch_glyph_row, displayed_buffer):
5740 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5741 (get_next_display_element, show_mouse_face, window_box_edges):
5742 (frame_to_window_pixel_xy, check_point_in_composition):
5743 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5744 (glyph_to_pixel_coords): Remove; unused.
5745
16390cd2
PE
5746 * dired.c (file_name_completion): Now static.
5747
5748 * dbusbind.c (xd_in_read_queued_messages): Now static.
5749
a25f4dfa
PE
5750 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5751 * data.c (circular_list_error): Remove.
5752
14a9c8df
PE
5753 * commands.h (last_point_position, last_point_position_buffer):
5754 (last_point_position_window): Remove decls.
5755 * keyboard.c: Make these variables static.
5756
04f2d78b
CB
5757 * coding.h (coding, code_convert_region, encode_coding_gap):
5758 Remove decls.
74ab6df5
PE
5759 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5760 (iso_code_class, detect_coding, code_convert_region): Now static.
5761 (encode_coding_gap): Remove; unused.
5762
38dfbee1
PE
5763 * chartab.c (chartab_chars, chartab_bits): Now static.
5764
a2cb4e63
PE
5765 * charset.h (charset_iso_8859_1): Remove decl.
5766 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5767 Now static.
5768
127198fd
PE
5769 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5770 * ccl.c (Vccl_program_table): Now static.
5771 (check_ccl_update): Remove; unused.
5772
d85b608f
PE
5773 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5774 * category.h: ... from here.
5775 * category.c (check_category_table, set_category_set): Now static.
5776
31cd66f3
PE
5777 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5778 * lisp.h: Remove these decls.
5779
c358e587
PE
5780 * buffer.c (buffer_count): Remove unused var.
5781
e78aecca
PE
5782 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5783 so that it's not optimized away.
5784 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5785 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5786 exported only to the debugger.
5787
e192d7d3 5788 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5789 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5790
92470028
PE
5791 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5792 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5793 was inaccessible from Lisp.
5794 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5795 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5796
244ed907
PE
5797 alloc.c: Import and export fewer symbols, and remove unused items.
5798 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5799 is defined.
5800 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5801 it's not optimized away by whole-program optimization.
5802 (message_enable_multibyte, free_misc): Remove.
5803 (catchlist, handlerlist, mark_backtrace):
5804 Declare only if BYTE_MARK_STACK.
5805 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5806 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5807 (message_enable_multibyte): Remove decl.
5808 (free_misc, interval_free_list, float_block, float_block_index):
5809 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5810 (cons_free_list, last_marked_index):
5811 Now static.
5812 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5813 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5814 (mark_backtrace): Define only if BYTE_MARK_STACK.
5815 * xdisp.c (message_enable_multibyte): Now static.
5816
61c2b50e 5817 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5818 This makes it easier for human readers (and static analyzers)
5819 to see whether these variables are used from other modules.
5820 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5821 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5822 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5823 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5824 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5825 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5826 * xmenu.c, xselect.c:
5827 Declare Q* vars static if they are not used in other modules.
5828 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5829 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5830 Remove decls of unexported vars.
5831 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5832
95c82688
PE
5833 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5834
16a97296
PE
5835 Make Emacs functions such as Fatom 'static' by default.
5836 This makes it easier for human readers (and static analyzers)
5837 to see whether these functions can be called from other modules.
5838 DEFUN now defines a static function. To make the function external
5839 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5840 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5841 (Finit_image_library):
16a97296
PE
5842 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5843 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5844 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5845 Remove decls, since these functions are now static.
5846 (Funintern, Fget_internal_run_time): New decls, since these functions
5847 were already external.
95c82688 5848
16a97296
PE
5849 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5850 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5851 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5852 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5853 * keyboard.c, keymap.c, lread.c:
5854 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5855 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5856 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5857 Mark functions with DEFUE instead of DEFUN,
5858 if they are used in other modules.
5859 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5860 decls for now-static functions.
5861 * buffer.h (Fdelete_overlay): Remove decl.
5862 * callproc.c (Fgetenv_internal): Mark as internal.
5863 * composite.c (Fremove_list_of_text_properties): Remove decl.
5864 (Fcomposition_get_gstring): New forward static decl.
5865 * composite.h (Fcomposite_get_gstring): Remove decl.
5866 * dired.c (Ffile_attributes): New forward static decl.
5867 * doc.c (Fdocumntation_property): New forward static decl.
5868 * eval.c (Ffetch_bytecode): New forward static decl.
5869 (Funintern): Remove extern decl; now in .h file where it belongs.
5870 * fileio.c (Fmake_symbolic_link): New forward static decl.
5871 * image.c (Finit_image_library): New forward static decl.
5872 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5873 * intervals.h (Fprevious_property_change):
5874 (Fremove_list_of_text_properties): Remove decls.
5875 * keyboard.c (Fthis_command_keys): Remove decl.
5876 (Fcommand_execute): New forward static decl.
5877 * keymap.c (Flookup_key): New forward static decl.
5878 (Fcopy_keymap): Now static.
5879 * keymap.h (Flookup_key): Remove decl.
5880 * process.c (Fget_process): New forward static decl.
5881 (Fprocess_datagram_address): Mark as internal.
5882 * syntax.c (Fsyntax_table_p): New forward static decl.
5883 (skip_chars): Remove duplicate decl.
5884 * textprop.c (Fprevious_property_change): New forward static decl.
5885 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5886 Now internal.
5887 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5888 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5889
785bbd42
PE
5890 * editfns.c (Fformat): Remove unreachable code.
5891
8b913b57
AS
58922011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5893
5894 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5895 change. (Bug#8496)
5896
a6744a35
EZ
58972011-04-13 Eli Zaretskii <eliz@gnu.org>
5898
5899 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5900 when at ZV. (Bug#8487)
5901
e7974947
AS
59022011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5903
baad03f0
AS
5904 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5905 (Bug#8437)
5906 * keyboard.c (parse_tool_bar_item): Likewise.
5907 * sound.c (sound_cleanup, alsa_close): Likewise.
5908 * termcap.c (tgetent): Likewise.
5909 * xfns.c (x_default_font_parameter): Likewise.
5910 * xsettings.c (read_and_apply_settings): Likewise.
5911
e7974947
AS
5912 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5913 (overrun_check_free): Protoize.
5914
28272684
PE
59152011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5916
5917 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5918 since callers should never pass a negative size.
5919 Change the signature to match that of plain 'read' and 'write'; see
5920 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5921 * lisp.h: Update prototypes of emacs_write and emacs_read.
5922
11997c76
EZ
59232011-04-11 Eli Zaretskii <eliz@gnu.org>
5924
5925 * xdisp.c (redisplay_window): Don't try to determine the character
5926 position of the scroll margin if the window start point w->startp
e896f03c 5927 is outside the buffer's accessible region. (Bug#8468)
11997c76 5928
8a2cbd72
EZ
59292011-04-10 Eli Zaretskii <eliz@gnu.org>
5930
5931 Fix write-region and its subroutines for buffers > 2GB.
5932 * fileio.c (a_write, e_write): Modify declaration of arguments and
5933 local variables to support buffers larger than 2GB.
5934 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5935
5936 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5937 argument, local variables, and return value.
5938
5939 * lisp.h: Update prototypes of emacs_write and emacs_read.
5940
5941 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5942
4073e537 59432011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5944
1ebfdcb6
PE
5945 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5946
b2ded58d
PE
5947 Fix more problems found by GCC 4.6.0's static checks.
5948
7d66342c
PE
5949 * xdisp.c (vmessage): Use a better test for character truncation.
5950
bbf47d44
PE
5951 * charset.c (load_charset_map): <, not <=, for optimization,
5952 and to avoid potential problems with integer overflow.
9248994d 5953 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5954 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5955 * editfns.c (Fformat): Likewise.
1e69125e 5956 * syntax.c (skip_chars): Likewise.
3befa583 5957
e3019616
PE
5958 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5959 This also lets GCC 4.6.0 generate slightly better loop code.
5960
becfa255
PE
5961 * callint.c (Fcall_interactively): <, not <=, for optimization.
5962 (Fcall_interactively): Count the number of arguments produced,
5963 not the number of arguments given. This is simpler and lets GCC
5964 4.6.0 generate slightly better code.
5965
dae0cd48
PE
5966 * ftfont.c: Distingish more carefully between FcChar8 and char.
5967 The previous code passed unsigned char * to a functions like
5968 strlen and xstrcasecmp that expect char *, which does not
5969 conform to the C standard.
5970 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5971 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5972 char * when the C standard requires it.
5973
76032d70
PE
5974 * keyboard.c (read_char): Remove unused var.
5975
eb3f1cc8
PE
5976 * eval.c: Port to Windows vsnprintf (Bug#8435).
5977 Include <limits.h>.
5978 (SIZE_MAX): Define if the headers do not.
5979 (verror): Do not give up if vsnprintf returns a negative count.
5980 Instead, grow the buffer. This ports to Windows vsnprintf, which
5981 does not conform to C99. Problem reported by Eli Zaretskii.
5982 Also, simplify the allocation scheme, by avoiding the need for
5983 calling realloc, and removing the ALLOCATED variable.
5984
70476b54
PE
5985 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5986
12020a9e
PE
5987 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5988 But keep the doprint source code for now, as we might revamp it
5989 and use it again (Bug#8435).
ea6c7ae6
PE
5990 * lisp.h (doprnt): Remove.
5991 * Makefile.in (base_obj): Remove doprnt.o.
5992 * deps.mk (doprnt.o): Remove.
5993
5fdb398c
PE
5994 error: Print 32- and 64-bit integers portably (Bug#8435).
5995 Without this change, on typical 64-bit hosts error ("...%d...", N)
5996 was used to print both 32- and 64-bit integers N, which relied on
5997 undefined behavior.
5998 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5999 New macro.
6000 * lisp.h (error, verror): Mark as printf-like functions.
6001 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6002 Report overflow in size calculations when allocating printf buffer.
6003 Do not truncate output string at its first null byte.
6004 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6005 Truncate the output at a character boundary, since vsnprintf does not
6006 do that.
6007 * charset.c (check_iso_charset_parameter): Convert internal
6008 character to string before calling 'error', since %c now has the
6009 printf meaning.
6010 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6011 overflow when computing char to be passed to 'error'. Do not
6012 pass Lisp_Object to 'error'; pass the integer instead.
6013 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6014 formatted with plain %d.
6015
b189fa66
PE
6016 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6017
bff87ef0
PE
6018 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6019
7e2cac20
PE
6020 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6021
ce4d90b5
PE
6022 * xterm.c (x_catch_errors): Remove duplicate declaration.
6023
266c9547
PE
6024 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6025
79c49ad2
PE
6026 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6027
368f4090
JM
60282011-04-10 Jim Meyering <meyering@redhat.com>
6029
6030 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6031 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6032 return ssize_t not "int", and use size_t as the buffer length.
6033 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6034 * gnutls.h: Update declarations.
6035 * process.c (read_process_output): Use ssize_t, to match.
6036 (send_process): Likewise.
6037
a32d4040
CY
60382011-04-09 Chong Yidong <cyd@stupidchicken.com>
6039
6040 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6041
8546720e 60422011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6043
04f2d78b
CB
6044 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6045 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6046
8546720e
GM
6047 * xterm.c (handle_one_xevent):
6048 * xmenu.c (create_and_show_popup_menu):
6049 * xselect.c (x_decline_selection_request)
6050 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6051
0a2f5c1a 60522011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6053
6054 Fix some uses of `int' instead of EMACS_INT.
6055 * search.c (string_match_1, fast_string_match)
6056 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6057 (scan_buffer, find_next_newline_no_quit)
6058 (find_before_next_newline, search_command, Freplace_match)
6059 (Fmatch_data): Make some `int' variables be EMACS_INT.
6060
6061 * xdisp.c (display_count_lines): 3rd argument and return value now
6062 EMACS_INT. All callers changed.
6063 (pint2hrstr): Last argument is now EMACS_INT.
6064
6065 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6066 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6067 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6068 (decode_coding_utf_16, decode_coding_emacs_mule)
6069 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6070 (decode_coding_ccl, decode_coding_charset)
6071 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6072 (decode_coding_iso_2022, decode_coding_emacs_mule)
6073 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6074 <char_offset, last_offset>: Declare EMACS_INT.
6075 (encode_coding_utf_8, encode_coding_utf_16)
6076 (encode_coding_emacs_mule, encode_invocation_designation)
6077 (encode_designation_at_bol, encode_coding_iso_2022)
6078 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6079 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6080 Declare EMACS_INT.
6081 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6082 (encode_invocation_designation): Last argument P_NCHARS is now
6083 EMACS_INT.
6084 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6085 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6086
6087 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6088 All users changed.
6089
6090 * ccl.c (Fccl_execute_on_string): Declare some variables
6091 EMACS_INT.
6092
8546720e 60932011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6094
6095 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6096
4e19a977
CS
60972011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6098
6099 * process.c (Fformat_network_address): Doc fix.
6100
87302331
R
61012011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6102
6103 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6104
cbb59342
CY
61052011-04-08 Chong Yidong <cyd@stupidchicken.com>
6106
6107 * keyboard.c (read_char): Call Lisp function help-form-show,
6108 instead of using internal_with_output_to_temp_buffer.
6109 (Qhelp_form_show): New var.
e0d38eeb 6110 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6111
6112 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6113
6114 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6115
e67a13ab
CY
61162011-04-06 Chong Yidong <cyd@stupidchicken.com>
6117
04f2d78b
CB
6118 * process.c (Flist_processes): Remove to Lisp.
6119 (list_processes_1): Delete.
e67a13ab 6120
973f782d
EZ
61212011-04-06 Eli Zaretskii <eliz@gnu.org>
6122
7c106b1e
EZ
6123 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6124
973f782d
EZ
6125 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6126
41cf7d1a 61272011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6128
ca23cc88
PE
6129 Fix more problems found by GCC 4.6.0's static checks.
6130
f390e2d5
PE
6131 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6132
42eea0d0
PE
6133 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6134
b69769da 6135 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6136
f9541e84
PE
6137 * xdisp.c (vmessage): Mark as a printf-like function.
6138
13841b55
PE
6139 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6140
c136c10f
PE
6141 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6142
5e2d4a30
PE
6143 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6144 printf-like functions.
6145 (tiff_load): Add casts to remove these marks before passing them
6146 to system-supplied API.
6147
583f48b9
PE
6148 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6149
b25d760e
PE
6150 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6151 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6152 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6153 directly, rather than having caller test rule sign. This avoids
6154 some unnecessary tests.
6155 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6156 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6157 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6158
bc7b6697 6159 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6160 (xfont_open): Avoid unnecessary tests.
bc7b6697 6161
27ccc379
PE
6162 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6163
dcd5c89a
PE
6164 * composite.h, composite.c (composition_gstring_put_cache):
6165 Use EMACS_INT, not int, for length.
6166
b13a45c6
PE
6167 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6168 breaking out part of COMPOSITION_DECODE_RULE.
6169 (COMPOSITION_DECODE_RULE): Use it.
6170 * composite.c (get_composition_id): Remove unused local vars,
6171 by using the new macro.
6172
1e792e4d
PE
6173 * textprop.c (set_text_properties_1): Change while to do-while,
6174 since the condition is always true at first.
6175
dc6c6455 6176 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6177 (interval_deletion_adjustment): Return unsigned value.
6178 All uses changed.
dc6c6455 6179
aba7731a
PE
6180 * process.c (list_processes_1, create_pty, read_process_output):
6181 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6182 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6183 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6184 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6185 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6186
fdfc4bf3
PE
6187 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6188
fca8fe46 6189 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6190 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6191
06a0259a 6192 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6193 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6194 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6195
e7b9e80f
PE
6196 * print.c (print_error_message): Avoid int overflow.
6197
56201685
PE
6198 * font.c (font_list_entities): Redo for clarity,
6199 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6200
78834453 6201 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6202 (font_score): Avoid potential overflow in diff calculation.
78834453 6203
0bc0b309 6204 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6205 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6206
e610eaca
PE
6207 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6208
b895abce
PE
6209 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6210 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6211 can always succeed if overflow has undefined behavior.
6212
1f1d9321 6213 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6214 (wordify): Omit three unnecessary tests.
1f1d9321 6215
c59478bc
PE
6216 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6217 All callers changed. This avoids the need for an unused var.
6218
79b73827
PE
6219 * casefiddle.c (casify_region): Remove var that is set but not used.
6220
a4db5dfe
PE
6221 * dired.c (file_name_completion): Remove var that is set but not used.
6222
43aae36e
PE
6223 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6224
2a47c44d 6225 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6226 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6227
a37c69bf
PE
6228 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6229 Check for integer overflow on size calculations.
6230
328ab8e7
PE
6231 * buffer.c (Fprevious_overlay_change): Remove var that is set
6232 but not used.
6233
e5a2a5cb
PE
6234 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6235 Remove vars that are set but not used.
8d84a6eb 6236 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6237 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6238
a60e5f68
PE
6239 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6240
f661cb61 6241 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6242 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6243
f0397f5a
PE
6244 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6245 that are set but not used.
6246
8664db06 6247 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6248 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6249
6abdaa4a
PE
6250 * xselect.c (x_get_local_selection, x_handle_property_notify):
6251 Remove vars that are set but not used.
6252
0ce7538d 6253 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6254 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6255
9ae848fc
PE
6256 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6257 Remove var that is set but not used.
0b918413
PE
6258 (scroll_bar_windows_size): Now size_t, not int.
6259 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6260 Check for overflow.
9ae848fc 6261
a5a62657
PE
6262 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6263 (map_tty_color) [!defined MSDOS]: Likewise.
6264
5c5cdd39
PE
6265 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6266
66ebf983
PE
6267 * coding.c: Remove vars that are set but not used.
6268 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6269 All callers changed.
6270 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6271 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6272 (decode_coding_charset): Remove vars that are set but not used.
6273
1be4d761
PE
6274 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6275 that is set but not used.
6276
47553fa8
PE
6277 * print.c (print_object): Remove var that is set but not used.
6278
1f7196bf 6279 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6280 The gnulib version avoids calling malloc in the usual case,
6281 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6282 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6283 * filelock.c (current_lock_owner): Likewise.
6284 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6285 * sysdep.c: Include allocator.h, careadlinkat.h.
6286 (emacs_no_realloc_allocator): New static constant.
6287 (emacs_readlink): New function.
fdb61804
PE
6288 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6289 ../lib/careadlinkat.h.
d1fdcab7 6290
f84c17c7
SM
62912011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6292
6293 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6294 first non-nil return value).
6295
ef3862ad
JD
62962011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6297
6298 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6299 if not defined (Bug#8403).
6300
376a7006
JB
63012011-04-02 Juanma Barranquero <lekktu@gmail.com>
6302
6303 * xdisp.c (display_count_lines): Remove parameter `start',
6304 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6305 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6306 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6307 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6308 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6309 and thereabouts. All callers changed.
6310 (get_per_char_metric): Remove parameter `f', unused since
6311 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6312
6ca3801d
JM
63132011-04-02 Jim Meyering <meyering@redhat.com>
6314
6315 do not dereference NULL upon failed strdup
6316 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6317 (ns_get_family): Likewise.
6318
d8e2b5ba
JB
63192011-04-02 Juanma Barranquero <lekktu@gmail.com>
6320
6321 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6322
8c74fcbd
JD
63232011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6324
6325 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6326 later (Bug#8403).
6327
7200d79c
SM
63282011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6329
03408648 6330 Add lexical binding.
7200d79c 6331
03408648
SM
6332 * window.c (Ftemp_output_buffer_show): New fun.
6333 (Fsave_window_excursion):
6334 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6335
6336 * lread.c (lisp_file_lexically_bound_p): New function.
6337 (Fload): Bind Qlexical_binding.
6338 (readevalloop): Remove `evalfun' arg.
6339 Bind Qinternal_interpreter_environment.
6340 (Feval_buffer): Bind Qlexical_binding.
6341 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6342 Mark as dynamic.
6343 (syms_of_lread): Declare `lexical-binding'.
6344
6345 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6346
6347 * keyboard.c (eval_dyn): New fun.
6348 (menu_item_eval_property): Use it.
ca105506
SM
6349
6350 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6351
03408648
SM
6352 * fns.c (concat, mapcar1): Accept byte-code-functions.
6353
6354 * eval.c (Fsetq): Handle lexical vars.
6355 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6356 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6357 (FletX, Flet): Obey lexical binding.
6358 (Fcommandp): Handle closures.
6359 (Feval): New `lexical' arg.
6360 (eval_sub): New function extracted from Feval. Use it almost
6361 everywhere where Feval was used. Look up vars in lexical env.
6362 Handle closures.
6363 (Ffunctionp): Move from subr.el.
6364 (Ffuncall): Handle closures.
6365 (apply_lambda): Remove `eval_flags'.
6366 (funcall_lambda): Handle closures and new byte-code-functions.
6367 (Fspecial_variable_p): New function.
6368 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6369 but without exporting it to Lisp.
23aba0ea 6370
23aba0ea 6371 * doc.c (Fdocumentation, store_function_docstring):
03408648 6372 * data.c (Finteractive_form): Handle closures.
23aba0ea 6373
03408648
SM
6374 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6375 interactive spec.
ba83908c 6376
04f2d78b
CB
6377 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6378 New byte-codes.
03408648
SM
6379 (exec_byte_code): New function extracted from Fbyte_code to handle new
6380 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6381
03408648 6382 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6383
03408648 6384 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6385
e2abce01
JB
63862011-03-31 Juanma Barranquero <lekktu@gmail.com>
6387
6388 * xdisp.c (redisplay_internal): Fix prototype.
6389
63696a73 63902011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6391
63696a73 6392 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6393 (try_scrolling): Use it when setting scroll_limit.
6394 Limit scrolling to 100 screen lines.
63696a73
EZ
6395 (redisplay_window): Even when falling back on "recentering",
6396 position point in the window according to scroll-conservatively,
6397 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6398
6399 (try_scrolling): When point is above the window, allow searching
6400 as far as scroll_max, or one screenful, to compute vertical
6401 distance from PT to the scroll margin position. This prevents
6402 try_scrolling from unnecessarily failing when
6403 scroll-conservatively is set to a value slightly larger than the
6404 window height. Clean up the case of PT below the margin at bottom
6405 of window: scroll_max can no longer be INT_MAX. When aggressive
6406 scrolling is in use, don't let point enter the opposite scroll
6407 margin as result of the scroll.
6408 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6409 threshold of 100 lines for never-recentering scrolling.
6410
e4cc2dfc
JB
64112011-03-31 Juanma Barranquero <lekktu@gmail.com>
6412
6413 * dispextern.h (move_it_by_lines):
6414 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6415 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6416 (message_log_check_duplicate): Remove parameters `prev_bol' and
6417 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6418 (redisplay_internal): Remove parameter `preserve_echo_area',
6419 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6420
6421 * indent.c (Fvertical_motion):
6422 * window.c (window_scroll_pixel_based, Frecenter):
6423 Don't pass `need_y_p' to `move_it_by_lines'.
6424
1c470562
SM
64252011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6426
44f230aa
SM
6427 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6428 steal a few bits to be more compact.
6429 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6430 Remove unneeded casts.
6431
1c470562
SM
6432 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6433
888adce9
ZK
64342011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6435
6436 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6437 binding" message (bug#7967).
6438
f838ed7b
PE
64392011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6440
77861b95
PE
6441 Fix more problems found by GCC 4.6.0's static checks.
6442
de6dbc14
PE
6443 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6444 Remove unused local var.
6445
f838ed7b
PE
6446 * editfns.c (Fmessage_box): Remove unused local var.
6447
792c7b2b
PE
6448 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6449 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6450 Omit unused local vars.
c499e557 6451 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6452 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6453 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6454 Omit unused local var.
6455
ba0165e1
PE
6456 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6457 Don't assume string length fits in int.
32ad8845 6458 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6459 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6460
3c59b4c9
PE
6461 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6462 instead of alloca (Bug#8344).
6463
a3eed478 6464 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6465 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6466
eb4d412d
PE
6467 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6468
1658b401
PE
6469 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6470 concerns.
6471
6472 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6473
6474 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6475
9a2c6e05
PE
6476 * keyboard.c (syms_of_keyboard): Use the same style as later
6477 in this function when indexing through an array. This also
6478 works around GCC bug 48267.
6479
03d0a109
PE
6480 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6481
44f730c8
PE
6482 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6483
fe75f926
PE
6484 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6485 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6486
ffa8c828
PE
6487 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6488 This avoids undefined behavior on integer overflow, and is a bit
6489 more convenient anyway since it is compared to a size_t variable.
6490
c5101a77
PE
6491 Variadic C functions now count arguments with size_t, not int.
6492 This avoids an unnecessary limitation on 64-bit machines, which
6493 caused (substring ...) to crash on large vectors (Bug#8344).
6494 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6495 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6496 All variadic functions and their callers changed accordingly.
c5101a77
PE
6497 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6498 * data.c (arith_driver, float_arith_driver): Likewise.
6499 * editfns.c (general_insert_function): Likewise.
6500 * eval.c (struct backtrace.nargs, interactive_p)
6501 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6502 (funcall_lambda, mark_backtrace): Likewise.
6503 * fns.c (concat): Likewise.
6504 * frame.c (x_set_frame_parameters): Likewise.
6505 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6506 0 if not found, not -1. All callers changed.
6507
dd3f25f7
PE
6508 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6509 (stack_copy_size): Now size_t, not int.
6510 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6511
461c2ab9
JB
65122011-03-28 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6515 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6516 All callers changed.
6517
6518 * lisp.h (multibyte_char_to_unibyte):
6519 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6520 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6521 * character.h (CHAR_TO_BYTE8):
6522 * cmds.c (internal_self_insert):
6523 * editfns.c (general_insert_function):
6524 * keymap.c (push_key_description):
6525 * search.c (Freplace_match):
6526 * xdisp.c (message_dolog, set_message_1): All callers changed.
6527
f6d62986
SM
65282011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6529
6530 * keyboard.c (safe_run_hook_funcall): New function.
6531 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6532 don't set the hook to nil, but remove the offending function instead.
6533 (Qcommand_hook_internal): Remove, unused.
6534 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6535 Vcommand_hook_internal.
6536
6537 * eval.c (enum run_hooks_condition): Remove.
6538 (funcall_nil, funcall_not): New functions.
6539 (run_hook_with_args): Call each function through a `funcall' argument.
6540 Remove `cond' argument, now redundant.
6541 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6542 (Frun_hook_with_args_until_failure): Adjust accordingly.
6543 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6544
1db5b1ad
JB
65452011-03-28 Juanma Barranquero <lekktu@gmail.com>
6546
6547 * dispextern.h (string_buffer_position): Remove declaration.
6548
6549 * print.c (strout): Remove parameter `multibyte', unused since
6550 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6551
6552 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6553 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6554 All callers changed.
6555
6556 * w32.c (_wsa_errlist): Use braces for struct initializers.
6557
6558 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6559 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6560 All callers changed.
6561 (string_buffer_position): Likewise. Also, make static (it's never
6562 used outside xdisp.c).
6563 (cursor_row_p): Remove parameter `w', unused since
6564 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6565 (decode_mode_spec): Remove parameter `precision', introduced during
6566 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6567 All callers changed.
6568
5ffb62aa
JD
65692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6570
6571 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6572
461c2ab9 65732011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6574
6575 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6576 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6577 (ns_update_auto_hide_menu_bar): New functions.
6578 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6579 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6580 ns_constrain_all_frames.
6581 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6582 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6583
5c380ffb
JD
65842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6585
6586 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6587
9af30bdf
GM
65882011-03-27 Glenn Morris <rgm@gnu.org>
6589
6590 * syssignal.h: Replace RETSIGTYPE with void.
6591 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6592 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6593 Replace SIGTYPE with void everywhere.
6594 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6595 * s/template.h (SIGTYPE): Remove commented out definition.
6596
e2abce01
JB
65972011-03-26 Eli Zaretskii <eliz@gnu.org>
6598
6599 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6600 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6601
f868cd8a
JB
66022011-03-26 Juanma Barranquero <lekktu@gmail.com>
6603
59eb0929
JB
6604 * w32.c (read_unc_volume): Use parameter `henum', instead of
6605 global variable `wget_enum_handle'.
6606
6607 * keymap.c (describe_vector): Remove parameters `indices' and
6608 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6609 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6610
f868cd8a
JB
6611 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6612
6613 * keyboard.c (timer_check): Remove parameter `do_it_now',
6614 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6615 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6616 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6617
6618 * keyboard.c (read_char):
6619 * w32menu.c (w32_menu_display_help):
6620 * xmenu.c (show_help_event, menu_help_callback):
6621 Adjust calls to `show_help_echo'.
6622
6623 * gtkutil.c (xg_maybe_add_timer):
6624 * keyboard.c (readable_events):
6625 * process.c (wait_reading_process_output):
6626 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6627
6628 * insdel.c (adjust_markers_gap_motion):
6629 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6630 (gap_left, gap_right): Don't call it.
6631
2ecf6fdb
CY
66322011-03-25 Chong Yidong <cyd@stupidchicken.com>
6633
6634 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6635 incurred during fontification.
6636
6b1f9ba4
JB
66372011-03-25 Juanma Barranquero <lekktu@gmail.com>
6638
6639 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6640 (DEFVAR_PER_BUFFER): Don't pass it.
6641
6642 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6643 (scrolling_window): Don't pass it.
6644
0f4a96b5
JB
66452011-03-25 Juanma Barranquero <lekktu@gmail.com>
6646
6647 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6648
6649 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6650 and `suffix'.
6651 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6652 of variables specific to SELinux and computation of `encoded_absname'.
6653
6654 * image.c (XPutPixel): Remove unused variable `height'.
6655
6656 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6657
6658 * unexw32.c (get_section_info): Remove unused variable `section'.
6659
6660 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6661 (system_process_attributes): Remove unused variable `sess'.
6662 (sys_read): Remove unused variable `err'.
6663
6664 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6665 (w32_wnd_proc): Remove unused variable `isdead'.
6666 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6667 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6668 (x_create_tip_frame): Remove unused variable `tem'.
6669
6670 * w32inevt.c (w32_console_read_socket):
6671 Remove unused variable `no_events'.
6672
6673 * w32term.c (x_draw_composite_glyph_string_foreground):
6674 Remove unused variable `width'.
6675
1149507c
JB
66762011-03-24 Juanma Barranquero <lekktu@gmail.com>
6677
6678 * w32term.c (x_set_glyph_string_clipping):
6679 Don't pass uninitialized region to CombineRgn.
6680
9c88f339
JB
66812011-03-23 Juanma Barranquero <lekktu@gmail.com>
6682
6683 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6684 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6685 (Fx_close_connection): Remove unused variable `i'.
6686
6687 * w32font.c (w32font_draw): Return number of glyphs.
6688 (w32font_open_internal): Remove unused variable `i'.
6689 (w32font_driver): Add missing initializer.
6690
6691 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6692 (fill_in_menu): Remove unused variable `items_added'.
6693
6694 * w32term.c (last_mouse_press_frame): Remove static global variable.
6695 (w32_clip_to_row): Remove unused variable `f'.
6696 (x_delete_terminal): Remove unused variable `i'.
6697
6698 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6699 (NOTHING): Remove unused static global variable.
6700 (uniscribe_check_otf): Remove unused variable `table'.
6701 (uniscribe_font_driver): Add missing initializers.
6702
dee091a3
JD
67032011-03-23 Julien Danjou <julien@danjou.info>
6704
6705 * term.c (Fsuspend_tty, Fresume_tty):
6706 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6707 * window.c (temp_output_buffer_show):
6708 * insdel.c (signal_before_change):
6709 * frame.c (Fhandle_switch_frame):
6710 * fileio.c (Fdo_auto_save):
6711 * emacs.c (Fkill_emacs):
6712 * editfns.c (save_excursion_restore):
6713 * cmds.c (internal_self_insert):
6714 * callint.c (Fcall_interactively):
6715 * buffer.c (Fkill_all_local_variables):
6716 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6717 Use Frun_hooks.
0f4a96b5 6718 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6719 unconditionnaly since it does the check itself.
6720
2c520ab5 67212011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6722
c9c49752
PE
6723 Fix more problems found by GCC 4.5.2's static checks.
6724
8abc3f12
PE
6725 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6726 the first time through the loop, since we know p0 < p1 then.
6727 This also avoids a gcc -Wstrict-overflow warning.
6728
a2d26660
PE
6729 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6730 leading to a memory leak, possible in functions like
6731 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6732 of objects (Bug#8318).
a2d26660 6733
916c72e9
PE
6734 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6735 that could (at least in theory) be that large.
6736
19ab8a18
PE
6737 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6738 This is less likely to overflow, and avoids undefined behavior if
6739 overflow does occur. All callers changed. Use strtoul to scan
6740 for the unsigned long integer.
b7cbbd6f
PE
6741 (pint2hrstr): Simplify and tune code slightly.
6742 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6743
f0641eff
PE
6744 * scroll.c (do_scrolling): Work around GCC bug 48228.
6745 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6746
7f650bb9
PE
6747 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6748 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6749 (validate_x_resource_name): Simplify count usage.
6750 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6751
37dd57d1
PE
6752 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6753 fail (Bug#8306).
81e56e61 6754
699979fc 6755 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6756
401bf9b4
PE
6757 * process.c (Fmake_network_process): Use socklen_t, not int,
6758 where POSIX says socklen_t is required in portable programs.
6759 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6760 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6761 (Fmake_network_process, server_accept_connection):
6762 (wait_reading_process_output, read_process_output):
6763 Likewise.
6764
b93aacde
PE
6765 * process.c: Rename or move locals to avoid shadowing.
6766 (list_processes_1, Fmake_network_process):
6767 (read_process_output_error_handler, exec_sentinel_error_handler):
6768 Rename or move locals.
4dc343ee 6769 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6770 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6771 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6772 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6773 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6774
af8a867c 6775 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6776 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6777 Include tparam.h instead, since it declares them.
af8a867c
PE
6778 * cm.h (PC): Remove extern decl; tparam.h now does this.
6779 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6780 * terminfo.c: Include tparam.h, to check interfaces.
6781 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6782 (tparam): Adjust signature to match interface in tparam.h;
6783 this removes some undefined behavior. Check that outstring and len
6784 are zero, which they always are with Emacs.
6785 * tparam.h (PC, BC, UP): New extern decls.
6786
0248044d 6787 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6788 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6789
8ff096c1 6790 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6791 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6792 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6793 (ftfont_list): Remove unused local.
49eaafba
PE
6794 (get_adstyle_property, ftfont_pattern_entity):
6795 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6796 Rename locals to avoid shadowing.
8ff096c1 6797
e2be39f6
PE
6798 * xfont.c (xfont_list_family): Mark var as initialized.
6799
c9735e30
PE
6800 * xml.c (make_dom): Now static.
6801
8f5201ae
PE
6802 * composite.c (composition_compute_stop_pos): Rename local to
6803 avoid shadowing.
b246f932
PE
6804 (composition_reseat_it): Remove unused locals.
6805 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6806 (composition_update_it): Mark var as initialized.
11b61122
PE
6807 (find_automatic_composition): Mark vars as initialized,
6808 with a FIXME (Bug#8290).
8f5201ae 6809
760fbc2c
PE
6810 character.h: Rename locals to avoid shadowing.
6811 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6812 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6813 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6814 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6815 to avoid shadowing.
6816
ff08eb85
PE
6817 * textprop.c (property_change_between_p): Remove; unused.
6818
fc7bf025
PE
6819 * intervals.c (interval_start_pos): Now static.
6820
235d7abc
PE
6821 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6822
44f230aa
SM
6823 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6824 Rename locals to avoid shadowing.
3e7d6594 6825
50060332
PE
6826 * sound.c (wav_play, au_play, Fplay_sound_internal):
6827 Fix pointer signedness.
d01f234b 6828 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6829 (wav_play): Initialize a variable to 0, to prevent undefined
6830 behavior (Bug#8278).
50060332 6831
c4fc4e30
PE
6832 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6833
918436ed
PE
6834 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6835
c939f91b
PE
6836 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6837 clobbering (Bug#8298).
b9c7f648
PE
6838 * sysdep.c (sys_subshell): Likewise.
6839 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6840
6bd8c144
PE
6841 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6842 This should get cleaned up, so that child_setup has the
6843 same signature on all platforms.
6844
7710357c 6845 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6846 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6847
c59da222
CY
68482011-03-22 Chong Yidong <cyd@stupidchicken.com>
6849
6850 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6851 not to be necessary, and produces flickering.
6852
66b87493
GM
68532011-03-20 Glenn Morris <rgm@gnu.org>
6854
6855 * config.in: Remove file.
6856
45b6f6d5
JB
68572011-03-20 Juanma Barranquero <lekktu@gmail.com>
6858
6859 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6860 are now in src/globals.h.
6861 (syms_of_minibuf): Remove spurious & from previous change.
6862
3ec03f7e
LL
68632011-03-20 Leo <sdl.web@gmail.com>
6864
6865 * minibuf.c (completing-read-function): New variable.
6866 (completing-read-default): Rename from completing-read.
6867 (completing-read): Call completing-read-function.
6868
b14e3e21
CY
68692011-03-19 Juanma Barranquero <lekktu@gmail.com>
6870
6871 * xfaces.c (Fx_load_color_file):
6872 Read color file from absolute filename (bug#8250).
6873
f2b726e6
JB
68742011-03-19 Juanma Barranquero <lekktu@gmail.com>
6875
6876 * makefile.w32-in: Update dependencies.
6877
09f6ff02
EZ
68782011-03-17 Eli Zaretskii <eliz@gnu.org>
6879
6880 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6881
29a6015a
PE
68822011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6883
a3a6c54e
PE
6884 Fix more problems found by GCC 4.5.2's static checks.
6885
b766f867
PE
6886 * process.c (make_serial_process_unwind, send_process_trap):
6887 (sigchld_handler): Now static.
6888
be02381c
PE
6889 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6890 That way, the code declares only the vars that it needs.
6891 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6892 * s/cygwin.h (PTY_ITERATION): Likewise.
6893 * s/darwin.h (PTY_ITERATION): Likewise.
6894 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6895
57048744
PE
6896 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6897 * process.c (allocate_pty): Don't declare stb unless it's needed.
6898
7914961c 6899 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6900 (CONSTANTLIM): Remove; unused.
6901 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6902 Define only if needed.
7914961c 6903
b3967b18
PE
6904 * unexelf.c (unexec): Name an expression,
6905 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6906 Use a different way to cause a compilation error if anyone uses
6907 n rather than nn, a way that does not involve shadowing.
73366a00 6908 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6909
29a6015a
PE
6910 * deps.mk (unexalpha.o): Remove; unused.
6911
43cfc33e 6912 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6913 * unexec.h: New file.
ce701a33
PE
6914 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6915 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6916 Depend on unexec.h.
6917 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6918 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6919 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6920 Change as necessary to match prototype in unexec.h.
ce701a33 6921
01f44d5a
PE
6922 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6923 shadowing.
4f63c6bb 6924 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6925
a6670b0b
PE
6926 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6927 Rename locals to avoid shadowing.
6928
cef2010d 6929 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6930 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6931
d4d7173a
PE
6932 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6933
f08b802a
PE
6934 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6935 warning when compiling print.c.
6936
3ddb0639
PE
6937 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6938 instead of using an uninitialized var.
5ad03b97 6939 (font_sort_entities): Mark var as initialized.
3ddb0639 6940
170a2692
PE
6941 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6942
e663c700
PE
6943 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6944 pointers to constants.
89bc529a 6945 (font_parse_fcname): Remove unused vars.
7b81e2d0 6946 (font_delete_unmatched): Now static.
ea838e10 6947 (font_get_spec): Remove; unused.
13a547c6
PE
6948 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6949 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6950 Rename or move locals to avoid shadowing.
e663c700 6951
2a80c887 6952 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6953 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6954
1384fa33 6955 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6956 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6957
8b2c52e9
PE
6958 * alloc.c (mark_backtrace): Move decl from here ...
6959 * lisp.h: ... to here, so that it can be checked.
6960
475545b5 6961 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6962 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6963 (lisp_indirect_variable): Name an expression,
6964 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6965 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6966
b1349114 6967 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6968 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6969 Use const pointer when appropriate.
b1349114 6970
a2928364
PE
6971 * lisp.h (get_system_name, get_operating_system_release):
6972 Move decls here, to check interfaces.
6973 * process.c (get_operating_system_release): Move decl to lisp.h.
6974 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6975 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6976 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6977 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6978 (Fformat_time_string, Fencode_time, Finsert_char):
6979 (Ftranslate_region_internal, Fformat):
6980 Rename or remove local vars to avoid shadowing.
9710023e 6981 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6982
a415e694
PE
6983 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6984 avoid shadowing.
6985
8ef4622d
PE
6986 * lisp.h (eassert): Check that the argument compiles, even if
6987 ENABLE_CHECKING is not defined.
6988
946f9a5b
PE
6989 * data.c (Findirect_variable): Name an expression, to avoid
6990 gcc -Wbad-function-cast warning.
112396d6 6991 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6992 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6993 (Fmake_variable_buffer_local, Fmake_local_variable):
6994 Mark variables as initialized.
52746918 6995 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6996
e5aab7e7 6997 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6998 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6999 Rename locals to avoid shadowing.
dff45157
PE
7000 (mark_stack): Move local variables into the #ifdef region where
7001 they're used.
7bc26fdb
PE
7002 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7003 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7004 needed otherwise.
7005 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7006 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7007 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7008
e5aab7e7
PE
7009 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7010 avoids undefined behavior in theory.
7011
4da60324
PE
7012 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7013
88043301
PE
7014 Use functions, not macros, for up- and down-casing (Bug#8254).
7015 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7016 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7017 to use the following functions instead of these macros.
7018 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7019 EMACS_INT, since callers assume the returned value fits in int.
7020 (upcase1): Likewise, for UPCASE_TABLE.
7021 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7022 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7023 the race-condition problem in the old DOWNCASE.
88043301 7024
19ed5445
PE
7025 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7026 Rename locals to avoid shadowing.
7027 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7028 (regex_compile, re_search_2, re_match_2_internal):
7029 Remove unused local vars.
952db0d7
PE
7030 (FREE_VAR): Rewrite so as not to use empty "else",
7031 which gcc can warn about.
da053e48 7032 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7033 (RETALLOC_IF): Define only if needed.
7034 (WORDCHAR_P): Likewise. This one is never needed, but is used
7035 only in a comment talking about a compiler bug, so put inside
7036 the #if 0 of that comment.
7037 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7038 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7039 Remove; unused.
19ed5445 7040
1f3561e4 7041 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7042 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7043 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7044
ded6f8f7
PE
7045 * search.c (simple_search): Remove unused var.
7046
dbd37a95
PE
7047 * dired.c (compile_pattern): Move decl from here ...
7048 * lisp.h: ... to here, so that it can be checked.
7049 (struct re_registers): New forward decl.
7050
7e47afad
PE
7051 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7052
85f24f61
PE
7053 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7054 All uses changed.
7055 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7056 Rename locals to avoid shadowing.
5671df8f 7057 (Fvertical_motion): Mark locals as initialized.
85f24f61 7058
181aa2be 7059 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7060 (casify_region): Mark local as initialized.
181aa2be 7061
930d429c
PE
7062 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7063
7082eac6
PE
7064 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7065 New macros, so that the caller can use some names other than
7066 gcpro1, gcpro2, etc.
7067 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7068 of the new macros.
7069 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7070 argument, for consistency with GCPRO2_VAR, etc: it is now the
7071 prefix of the variable, not the variable itself. All uses
7072 changed.
38b2c076
PE
7073 * dired.c (directory_files_internal, file_name_completion):
7074 Rename locals to avoid shadowing.
7075
15206ed9
PE
7076 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7077 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7078 dired.c's scmp function, had undefined behavior.
7079 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7080 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7081 * buffer.h: ... to here, because these macros use current_buffer,
7082 and the new implementation with inline functions needs to have
7083 current_buffer in scope now, rather than later when the macros
7084 are used.
7085 (downcase, upcase1): New static inline functions.
7086 (DOWNCASE, UPCASE1): Reimplement using these functions.
7087 This avoids undefined behavior in expressions like
7088 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7089 from race conditions in accessing the global variables
7090 case_temp1 and case_temp2.
7091 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7092 * lisp.h (case_temp1, case_temp2): Remove their decls.
7093 * character.h (ASCII_CHAR_P): Move from here ...
7094 * lisp.h: ... to here, so that the inline functions mentioned
7095 above can use them.
7096
4a6bea26
PE
7097 * dired.c (directory_files_internal_unwind): Now static.
7098
f14b7e14
PE
7099 * fileio.c (file_name_as_directory, directory_file_name):
7100 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7101 Now static.
2893f146
PE
7102 (file_name_as_directory): Use const pointers when appropriate.
7103 (Fexpand_file_name): Likewise. In particular, newdir might
7104 point at constant storage, so make it a const pointer.
fd4ead52 7105 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7106 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7107 signedness issues.
f839df0c
PE
7108 (Fset_file_times, Finsert_file_contents, auto_save_error):
7109 Rename locals to avoid shadowing.
f14b7e14 7110
5716756e 7111 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7112 (Ftry_completion, Fall_completions): Rename or remove locals
7113 to avoid shadowing.
5716756e 7114
b4c3046a
PE
7115 * marker.c (bytepos_to_charpos): Remove; unused.
7116
b45db522
PE
7117 * lisp.h (verify_bytepos, count_markers): New decls,
7118 so that gcc does not warn that these functions aren't declared.
7119
85876d07
PE
7120 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7121 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7122 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7123 (copy_text): Remove unused local var.
85876d07 7124
03d78a21 7125 * filelock.c (within_one_second): Now static.
b3dd38ab 7126 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7127
5df8f01b
PE
7128 * buffer.c (fix_overlays_before): Mark locals as initialized.
7129 (fix_start_end_in_overlays): Likewise. This function should be
7130 simplified by using pointers-to-pointers, but that's a different
7131 matter.
b1d876f1 7132 (switch_to_buffer_1): Now static.
8f54f30a
PE
7133 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7134 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7135
a70072c9 7136 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7137 Fix pointer signedness issue.
edced198
PE
7138 (sys_subshell): Mark local as volatile if checking for lint,
7139 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7140 (MAXPATHLEN): Define only if needed.
a70072c9 7141
a0977c44
PE
7142 * process.c (serial_open, serial_configure): Move decls from here ...
7143 * systty.h: ... to here, so that they can be checked.
7144
a884fdcc
PE
7145 * fns.c (get_random, seed_random): Move extern decls from here ...
7146 * lisp.h: ... to here, so that they can be checked.
7147
604efe86 7148 * sysdep.c (reset_io): Now static.
b8950c94 7149 (wait_for_termination_signal): Remove; unused.
604efe86 7150
38fc62d9
PE
7151 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7152 (copy_keymap_item, append_key, push_text_char_description):
7153 Now static.
1004a21a 7154 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7155 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7156 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7157 (describe_map_tree):
7158 Rename locals to avoid shadowing.
38fc62d9 7159
2f2650da
PE
7160 * keyboard.c: Declare functions static if they are not used elsewhere.
7161 (echo_char, echo_dash, cmd_error, top_level_2):
7162 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7163 (read_char, kbd_buffer_get_event, make_lispy_position):
7164 (make_lispy_event, make_lispy_movement, apply_modifiers):
7165 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7166 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7167 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7168 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7169 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7170
a053e86c 7171 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7172 (mark_kboards): Move decl here ...
7173 * alloc.c (mark_kboards): ... from here.
a053e86c 7174
4752793e
PE
7175 * lisp.h (force_auto_save_soon): New decl.
7176
74f10ca7 7177 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7178 (DEFINE_DUMMY_FUNCTION): New macro.
7179 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7180 Use it.
c03cd23f
PE
7181 (main): Add casts to avoid warnings
7182 if GCC considers string literals to be constants.
74f10ca7 7183
022e70d4
PE
7184 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7185
59d6fe83
PE
7186 * dbusbind.c: Pointer signedness fixes.
7187 (xd_signature, xd_append_arg, xd_initialize):
7188 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7189 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7190 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7191 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7192
78320123
PE
7193 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7194 if GCC considers string literals to be constants.
49cebcca 7195 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7196
35ac2a97
SM
71972011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7198
fb103ca9
SM
7199 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7200 (print_preprocess, print_object): New macro to fix last change.
7201
35ac2a97
SM
7202 * print.c (print_preprocess): Don't forget font objects.
7203
62973b41
JB
72042011-03-16 Juanma Barranquero <lekktu@gmail.com>
7205
7206 * emacs.c (USAGE3): Doc fixes.
7207
0e48bb22
AS
72082011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7209
7210 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7211 structure.
7212
7684e57b
JB
72132011-03-14 Juanma Barranquero <lekktu@gmail.com>
7214
7215 * lisp.h (VWindow_system, Qfile_name_history):
7216 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7217 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7218 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7219
7220 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7221 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7222
7223 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7224 * w32console.c (detect_input_pending, read_input_pending)
7225 (encode_terminal_code):
7226 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7227 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7228 (w32_system_caret_y, Qfile_name_history):
7229 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7230 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7231 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7232 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7233 * w32proc.c (Qlocal, report_file_error):
7234 * w32term.c (Vwindow_system, updating_frame):
7235 * w32uniscribe.c (initialized, uniscribe_font_driver):
7236 Remove unneeded extern declarations.
7237
2aa46d6c
CY
72382011-03-14 Chong Yidong <cyd@stupidchicken.com>
7239
c96bbc66 7240 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7241
cffc6f3b
CY
72422011-03-13 Chong Yidong <cyd@stupidchicken.com>
7243
7244 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7245 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7246 These macros can no longer be used for assignment.
7247
44f230aa
SM
7248 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7249 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7250 (record_buffer_markers, fetch_buffer_markers): New functions for
7251 recording and fetching special buffer markers.
7252 (set_buffer_internal_1, set_buffer_temp): Use them.
7253
7254 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7255
7256 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7257
7258 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7259 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7260
7261 * xdisp.c (hscroll_window_tree):
7262 (reconsider_clip_changes): Use PT instead of BUF_PT.
7263
d251f04b
EZ
72642011-03-13 Eli Zaretskii <eliz@gnu.org>
7265
7266 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7267 $(EMACS_ROOT)/lib/intprops.h.
7268
f0c77cd1
PE
72692011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7270
3eca4629
PE
7271 Fix more problems found by GCC 4.5.2's static checks.
7272
7c86ee98
PE
7273 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7274 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7275 (xg_free_frame_widgets): Make it clear that a local variable is
7276 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7277 (gdk_window_get_screen): Make it clear that this macro is needed
7278 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7279 (int_gtk_range_get_value): New function, which avoids a diagnostic
7280 from gcc -Wbad-function-cast.
7281 (xg_set_toolkit_scroll_bar_thumb): Use it.
7282 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7283 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7284 (get_utf8_string, xg_get_file_with_chooser):
7285 Rename locals to avoid shadowing.
7286 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7287
41729b81
PE
7288 * xgselect.c (xg_select): Remove unused var.
7289
f0c77cd1
PE
7290 * image.c (four_corners_best): Mark locals as initialized.
7291 (gif_load): Initialize transparent_p to zero (Bug#8238).
7292 Mark another local as initialized.
ec6cf4c6 7293 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7294
ce0ad53d 7295 * image.c (clear_image_cache): Now static.
d5d5a617 7296 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7297 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7298 (x_edge_detection): Remove unnecessary cast that
7299 gcc -Wbad-function-cast diagnoses.
2037898d 7300 (gif_load): Fix pointer signedness.
6ae141d6
PE
7301 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7302 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7303
33383987 73042011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7305
d32df629
PE
7306 Improve quality of tests for time stamp overflow.
7307 For example, without this patch (encode-time 0 0 0 1 1
7308 1152921504606846976) returns the obviously-bogus value (-948597
7309 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7310 reports time overflow. See
7311 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7312 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7313 * editfns.c: Include limits.h and intprops.h.
7314 (TIME_T_MIN, TIME_T_MAX): New macros.
7315 (time_overflow): Move earlier, to before first use.
7316 (hi_time, lo_time): New functions, for an accurate test for
7317 out-of-range times.
7318 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7319 (Fget_internal_run_time): Don't assume time_t fits in int.
7320 (make_time): Use list2 instead of Fcons twice.
7321 (Fdecode_time): More accurate test for out-of-range times.
7322 (check_tm_member): New function.
7323 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7324 (lisp_time_argument): Don't rely on undefined left-shift and
7325 right-shift behavior when checking for time stamp overflow.
8be6f318 7326
fe31d94c
PE
7327 * editfns.c (time_overflow): New function, refactoring common code.
7328 (Fformat_time_string, Fdecode_time, Fencode_time):
7329 (Fcurrent_time_string): Use it.
7330
8be6f318
PE
7331 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7332 * dired.c (make_time): Move to ...
7333 * editfns.c (make_time): ... here.
7334 * systime.h: Note the move.
7335
09d9db2c 73362011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7337
126bc0dc
YM
7338 * fringe.c (update_window_fringes): Remove unused variables.
7339
c47cbdfd
YM
7340 * unexmacosx.c (copy_data_segment): Also copy __got section.
7341 (Bug#8223)
7342
7ac80be9
EZ
73432011-03-12 Eli Zaretskii <eliz@gnu.org>
7344
c96bbc66 7345 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7346 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7347 Constify `char *' arguments and their references according to
7348 prototypes in tparam.h.
7349
ecb0f94d 7350 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7351
7ac80be9
EZ
7352 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7353 Adapt all references accordingly.
7354
7355 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7356
ef1fd07e
TT
73572011-03-11 Tom Tromey <tromey@redhat.com>
7358
7359 * buffer.c (syms_of_buffer): Remove obsolete comment.
7360
7ef4b50c
EZ
73612011-03-11 Eli Zaretskii <eliz@gnu.org>
7362
7363 * termhooks.h (encode_terminal_code): Declare prototype.
7364
7365 * msdos.c (encode_terminal_code): Don't declare prototype.
7366
7367 * term.c (encode_terminal_code): Now external again, used by
7368 w32console.c and msdos.c.
7369
44f230aa
SM
7370 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7371 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7372
4b1ec863 73732011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7374
1714f52b 7375 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7376
4b1ec863
PE
7377 * fringe.c (update_window_fringes): Mark locals as initialized
7378 (Bug#8227).
7379 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7380
524c7aa6
PE
7381 * alloc.c (mark_fringe_data): Move decl from here ...
7382 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7383 to check its interface.
7384 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7385
a5c0af81 7386 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7387 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7388 (fontset_font): Mark local as initialized.
a9a06e0b 7389 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7390
b4716021
PE
7391 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7392
811e9bac 7393 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7394 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7395 (x_own_selection, Fx_disown_selection_internal): Rename locals
7396 to avoid shadowing.
7397 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7398
7e3ab302
PE
7399 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7400 so that the caller can use some name other than gcpro1.
7401 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7402 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7403 (Fx_backspace_delete_keys_p):
7404 Use them to avoid shadowing, and rename vars to avoid shadowing.
7405 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7406 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7407 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7408 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7409 Remove unused locals.
7e3ab302
PE
7410 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7411 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7412 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7413 macros.
f78faa98 7414
e2b13473
PE
7415 * xterm.h (x_mouse_leave): New decl.
7416
77f23912
PE
7417 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7418 Remove unused functions.
cdf4ba58
PE
7419 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7420 (x_calc_absolute_position): Now static.
7411c686 7421 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7422 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7423 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7424 unless they are used.
38d0b34a
PE
7425 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7426 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7427 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7428 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7429 (x_error_catcher, x_connection_closed, x_error_handler):
7430 (x_error_quitter, xembed_send_message, x_iconify_frame):
7431 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7432 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7433 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7434
44f230aa
SM
7435 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7436 Rename or move locals to avoid shadowing.
6b463e58 7437 (tty_defined_color, merge_face_heights): Now static.
5967d051 7438 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7439 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7440 does not deduce is never used uninitialized.
73719eba
PE
7441 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7442 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7443
426994c3 7444 * terminal.c (store_terminal_param): Now static.
5489860b 7445
032f1620 7446 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7447 (set_frame_menubar): Remove unused local.
d4323972 7448 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7449 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7450 since they might point to immutable storage.
281585b0
PE
7451 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7452 since it's unused otherwise.
032f1620 7453
367c19e5 7454 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7455 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7456 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7457 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7458 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7459 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7460 does not deduce are never used uninitialized.
70739cbe 7461
07b48fa9
PE
7462 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7463
8868a238 7464 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7465 * window.c (window_loop, size_window):
7466 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7467
7e5cf297 7468 * window.c (display_buffer): Now static.
d6550a9f
PE
7469 (size_window): Mark variables that gcc -Wuninitialized
7470 does not deduce are never used uninitialized.
a586633d
PE
7471 * window.h (check_all_windows): New decl, to forestall
7472 gcc -Wmissing-prototypes diagnostic.
5b555da1 7473 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7474
f6095868
PE
7475 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7476 shadowing.
7477 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7478 Include <limits.h>.
7479 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7480 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7481 (load_charset_map): Mark variables that gcc -Wuninitialized
7482 does not deduce are never used uninitialized.
53df7c11 7483 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7484
f38b440c
PE
7485 * coding.c (coding_set_source, coding_set_destination):
7486 Use "else { /* comment */ }" rather than "else /* comment */;"
7487 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7488 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7489 a block, when the outer 'i' will do.
7490 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7491 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7492 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7493 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7494 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7495 Rename locals to avoid shadowing.
7496 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7497 * coding.c (emacs_mule_char, encode_invocation_designation):
7498 Now static, since they're not used elsewhere.
413bb2db 7499 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7500 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7501 (decode_coding_emacs_mule): Mark variables that gcc
7502 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7503 (detect_coding_iso_2022): Initialize a local variable that might
7504 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7505 this initialization is needed. (Bug#8211)
5f58e762
PE
7506 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7507 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7508 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7509 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7510 Remove unused macros.
f38b440c 7511
232b38b9 7512 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7513 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7514 * character.c (string_count_byte8): Likewise.
232b38b9 7515
fb90da1b
PE
7516 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7517 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7518
fb93dbc2
PE
7519 * chartab.c (copy_sub_char_table): Now static, since it's not used
7520 elsewhere.
5c156ace
PE
7521 (sub_char_table_ref_and_range, char_table_ref_and_range):
7522 Rename locals to avoid shadowing.
bbcd0949 7523 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7524
7d3b3862 7525 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7526 (BIDI_BOB): Remove unused macro.
7d3b3862 7527
6be7d3da
PE
7528 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7529 deduce are never used uninitialized.
c2ed9c8b 7530 * term.c (encode_terminal_code): Likewise.
6be7d3da 7531
75f8807f 7532 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7533
50938595
PE
7534 * tparam.h: New file.
7535 * term.c, tparam.h: Include it.
7536 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7537 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7538 Move these decls to tparam.h, and make them agree with what
7539 is actually in tparam.c. The previous trick of using incompatible
7540 decls in different modules does not conform to the C standard.
7541 All callers of tparam changed to use tparam's actual API.
7542 * tparam.c (tparam1, tparam, tgoto):
7543 Use const pointers where appropriate.
7544
fbceeba2
PE
7545 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7546 * cm.h (struct cm): Likewise.
7547 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7548 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7549 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7550 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7551 (turn_on_face, init_tty): Likewise.
7552 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7553
7f3f1250
PE
7554 * term.c (term_mouse_position): Rename local to avoid shadowing.
7555
e6ca6543
PE
7556 * alloc.c (mark_ttys): Move decl from here ...
7557 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7558
c40f8d15
AS
75592011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7560
7561 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7562
cfe0661d
JB
75632011-03-09 Juanma Barranquero <lekktu@gmail.com>
7564
7565 * search.c (compile_pattern_1): Remove argument regp, unused since
7566 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7567 (compile_pattern): Don't pass it.
7568
0afb4571
J
75692011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7570
7571 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7572 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7573 for ! HAVE_GTK3.
7574 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7575
7576 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7577
7578 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7579 gdk_window_get_screen, gdk_window_get_geometry,
7580 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7581 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7582 (xg_get_pixbuf_from_pixmap): New function.
7583 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7584 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7585 Call xg_get_pixbuf_from_pixmap instead of
7586 gdk_pixbuf_get_from_drawable.
7587 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7588 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7589 (xg_check_special_colors): Use GtkStyleContext and its functions
7590 for HAVE_GTK3.
7591 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7592 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7593 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7594 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7595 Call gtk_widget_get_preferred_size.
0afb4571
J
7596 (xg_frame_resized): gdk_window_get_geometry only takes 5
7597 parameters.
44f230aa
SM
7598 (xg_win_to_widget, xg_event_is_for_menubar):
7599 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7600 (xg_set_widget_bg): New function.
7601 (delete_cb): New function.
895009e1 7602 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7603 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7604 (xg_set_background_color): Call xg_set_widget_bg.
7605 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7606 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7607 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7608 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7609 if ! HAVE_GTK3.
7610 (update_frame_tool_bar): Call gtk_widget_hide.
7611 (xg_initialize): Use GDK_KEY_g.
7612
7613 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7614 if ! HAVE_GTK3
7615 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7616
7617 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7618 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7619 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7620
1c2cc4ef
JB
76212011-03-08 Juanma Barranquero <lekktu@gmail.com>
7622
7623 * w32xfns.c (select_palette): Check success of RealizePalette against
7624 GDI_ERROR, not zero.
7625
33383987 7626See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7627
7628;; Local Variables:
7629;; coding: utf-8
aac0c6e3
MR
7630;; End:
7631
33383987 7632 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7633
7634 This file is part of GNU Emacs.
7635
7636 GNU Emacs is free software: you can redistribute it and/or modify
7637 it under the terms of the GNU General Public License as published by
7638 the Free Software Foundation, either version 3 of the License, or
7639 (at your option) any later version.
7640
7641 GNU Emacs is distributed in the hope that it will be useful,
7642 but WITHOUT ANY WARRANTY; without even the implied warranty of
7643 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7644 GNU General Public License for more details.
7645
7646 You should have received a copy of the GNU General Public License
7647 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.