* lisp/mail/rmailout.el (rmail-output-read-file-name): Trap errors
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4ce60d2e
DA
12012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Inline getter and setter functions for per-buffer values.
4 * buffer.h (per_buffer_default, set_per_buffer_default)
5 (per_buffer_value, set_per_buffer_value): New functions.
6 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
7 * buffer.c, data.c: Adjust users.
8
c06c9690
JB
92012-08-20 Juanma Barranquero <lekktu@gmail.com>
10
11 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
12
32bd4250
PE
132012-08-19 Paul Eggert <eggert@cs.ucla.edu>
14
bad03192 15 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
16 as gnulib does this if the system doesn't.
17 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
18 * emacs.c (environ) [DOUG_LEA_MALLOC]:
19 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
20 * vm-limit.c: Include <unistd.h>, for 'environ'.
21
22d7feb2
PE
22 * unexaix.c, unexcoff.c: Include "mem-limits.h".
23 (start_of_data): Remove decl; mem-limits.h provides it.
24
32bd4250
PE
25 * xdisp.c (handle_invisible_prop): Make it a bit faster
26 and avoid a gcc -Wmaybe-uninitialized diagnostic.
27
450809af
CY
282012-08-19 Chong Yidong <cyd@gnu.org>
29
30 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
31 ends (Bug#3874).
32
9e677988
AS
332012-08-19 Andreas Schwab <schwab@linux-m68k.org>
34
6b1319ce
AS
35 * .gdbinit: Use call instead of set when calling a function in the
36 inferior.
37
9e677988
AS
38 * data.c (set_internal): Don't use set_blv_found.
39 (Fkill_local_variable): Likewise.
40
d7191076
AA
412012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
42
43 * nsfont.m (ns_ascii_average_width): Ensure the string
44 ascii_printable is initialized with a null-terminated character
45 array. Otherwise, it can contain undesired extra characters.
46
e757f1c6
PE
472012-08-18 Paul Eggert <eggert@cs.ucla.edu>
48
49 port new setting code to Sun C 5.8 2005/10/13
50 * chartab.c, lisp.h (char_table_set, char_table_set_range):
51 Return void, not Lisp_Object. Otherwise, the compiler
52 complains about (A?B:C) where B is void and C is Lisp_Object
53 when compiling CHAR_TABLE_SET, due to the recent change to
54 the API of sub_char_table_set_contents.
55
a999ce26
CY
562012-08-18 Chong Yidong <cyd@gnu.org>
57
58 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
59 for the string case (Bug#3874).
60
3f22b86f
PE
612012-08-18 Paul Eggert <eggert@cs.ucla.edu>
62
39eb03f1
PE
63 * buffer.h (BSET): Remove (Bug#12215).
64 Replace all uses with calls to new setter functions.
65 (bset_bidi_paragraph_direction, bset_case_canon_table)
66 (bset_case_eqv_table, bset_directory, bset_display_count)
67 (bset_display_time, bset_downcase_table)
68 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
69 (bset_last_selected_window, bset_local_var_alist)
70 (bset_mark_active, bset_point_before_scroll, bset_read_only)
71 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
72 (bset_width_table):
73 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
74 (bset_auto_fill_function, bset_auto_save_file_format)
75 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
76 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
77 (bset_cache_long_line_scans, bset_case_fold_search)
78 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
79 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
80 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
81 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
82 (bset_header_line_format, bset_indicate_buffer_boundaries)
83 (bset_indicate_empty_lines, bset_invisibility_spec)
84 (bset_left_fringe_width, bset_major_mode, bset_mark)
85 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
86 (bset_name, bset_overwrite_mode, bset_pt_marker)
87 (bset_right_fringe_width, bset_save_length)
88 (bset_scroll_bar_width, bset_scroll_down_aggressively)
89 (bset_scroll_up_aggressively, bset_selective_display)
90 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
91 (bset_word_wrap, bset_zv_marker):
92 * category.c (bset_category_table):
93 * syntax.c (bset_syntax_table):
94 New setter functions.
95
6a09a33b
PE
96 * process.h (PSET): Remove (Bug#12215).
97 Replace all uses with calls to new setter functions.
98 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
99 (PROCESS_INLINE): New macro.
100 (pset_childp): New setter function.
101 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
102 * process.c (PROCESS_INLINE):
103 Define to EXTERN_INLINE, so that the corresponding functions
104 are compiled into code.
105 (pset_buffer, pset_command, pset_decode_coding_system)
106 (pset_decoding_buf, pset_encode_coding_system)
107 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
108 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
109 (pset_type, pset_write_queue): New setter functions.
110
e8c17b81
PE
111 * window.h (WSET): Remove (Bug#12215).
112 Replace all uses with calls to new setter functions.
113 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
114 (WINDOW_INLINE): New macro.
115 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
116 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
117 (wset_total_lines, wset_vertical_scroll_bar)
118 (wset_window_end_pos, wset_window_end_valid)
119 (wset_window_end_vpos): New setter functions.
120 * window.c (WINDOW_INLINE):
121 Define to EXTERN_INLINE, so that the corresponding functions
122 are compiled into code.
123 (wset_combination_limit, wset_dedicated, wset_display_table)
124 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
125 (wset_new_normal, wset_new_total, wset_next_buffers)
126 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
127 (wset_prev_buffers, wset_right_fringe_width)
128 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
129 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
130 (wset_window_parameters):
131 * xdisp.c (wset_base_line_number, wset_base_line_pos)
132 (wset_column_number_displayed, wset_region_showing):
133 New setter functions.
134
3f22b86f
PE
135 * termhooks.h (TSET): Remove (Bug#12215).
136 Replace all uses with calls to new setter functions.
137 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
138 (TERMHOOKS_INLINE): New macro.
139 (tset_charset_list, tset_selection_alist): New setter functions.
140 * terminal.c (TERMHOOKS_INLINE):
141 Define to EXTERN_INLINE, so that the corresponding functions
142 are compiled into code.
143 (tset_param_alist): New setter function.
144
742af32f
PE
1452012-08-17 Paul Eggert <eggert@cs.ucla.edu>
146
15dbb4d6
PE
147 * keyboard.h (KSET): Remove (Bug#12215).
148 Replace all uses with calls to new setter functions.
149 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
150 (KEYBOARD_INLINE): New macro.
151 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
152 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
153 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
154 New setter functions.
155 * keyboard.c (KEYBOARD_INLINE):
156 Define to EXTERN_INLINE, so that the corresponding functions
157 are compiled into code.
158 (kset_echo_string, kset_kbd_queue)
159 (kset_keyboard_translate_table, kset_last_prefix_arg)
160 (kset_last_repeatable_command, kset_local_function_key_map)
161 (kset_overriding_terminal_local_map, kset_real_last_command)
162 (kset_system_key_syms): New setter functions.
163
f00af5b1
PE
164 * frame.h (FSET): Remove (Bug#12215).
165 Replace all uses with calls to new setter functions.
166 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
167 (FRAME_INLINE): New macro.
168 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
169 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
170 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
171 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
172 (fset_param_alist, fset_root_window, fset_scroll_bars)
173 (fset_selected_window, fset_title, fset_tool_bar_items)
174 (fset_tool_bar_position, fset_tool_bar_window): New functions.
175 * frame.c (FRAME_INLINE):
176 Define to EXTERN_INLINE, so that the corresponding functions
177 are compiled into code.
178 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
179
0c94c8d6
PE
180 A few more naming-convention fixes for getters and setters.
181 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
182 and rename from buffer_overlays_set_before.
183 (set_buffer_overlays_after): Move here from buffer.h, and rename
184 from buffer_overlays_set_after.
185 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
186 All uses changed.
187 (set_buffer_intervals): Rename from buffer_set_intervals.
188 * intervals.c (set_interval_object): Move here from intervals.h,
189 and rename from interval_set_object.
190 (set_interval_left): Move here from intervals.h, and rename from
191 interval_set_left.
192 (set_interval_right): Move here from intervals.h, and rename from
193 interval_set_right.
194 (copy_interval_parent): Move here from intervals.h, and rename from
195 interval_copy_parent.
196 * intervals.h (set_interval_parent): Rename from interval_set_parent.
197 (set_interval_plist): Rename from interval_set_plist.
198 Return void, not Lisp_Object, since no caller uses the result.
199 * lisp.h (string_intervals): Rename from string_get_intervals.
200 (set_string_intervals): Rename from string_set_intervals.
201
34dabdb7
PE
202 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
203 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 204 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
205 All uses changed. See the end of
206 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
207
742af32f
PE
208 * lisp.h (CSET): Remove (Bug#12215).
209 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
210 (set_char_table_purpose): New functions,
211 replacing CSET. All uses changed. For example, replace
212 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 213 "set_char_table_parent (char_table, parent);".
742af32f
PE
214 The old version was confusing because it used the same name
215 'parent' for two different things.
216
a04e2c62
DA
2172012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
218
219 Functions to get and set Lisp_Object fields of buffer-local variables.
220 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
221 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
222 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
223 * data.c, eval.c, frame.c: Adjust users.
224
383dcbf9
CY
2252012-08-17 Chong Yidong <cyd@gnu.org>
226
227 * xfaces.c (merge_face_vectors): If the target font specfies a
228 font spec, make the font's attributes take precedence over
229 directly-specified attributes.
230 (merge_face_ref): Recognize :font.
231
44386687
DA
2322012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
233
234 Do not use memcpy for copying intervals.
235 * intervals.c (reproduce_interval): New function.
236 (reproduce_tree, reproduce_tree_obj): Use it.
237 (reproduce_tree_obj): Remove prototype.
238
927c7216
PE
2392012-08-17 Paul Eggert <eggert@cs.ucla.edu>
240
241 * lisp.h (duration_to_sec_usec): Remove unused decl.
242
93044f7b
AA
2432012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
244
245 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
246 to an allocated instance of NSString, not to the class itself.
247
9851e4a5
JB
2482012-08-17 Juanma Barranquero <lekktu@gmail.com>
249
250 * makefile.w32-in (C_CTYPE_H): New macro.
251 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
252 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
253 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
254
620f13b0
PE
2552012-08-16 Paul Eggert <eggert@cs.ucla.edu>
256
257 Use ASCII tests for character types.
258 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
259 * xfns.c, xterm.c:
260 Don't include <ctype.h>; was not needed.
261 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
262 * sysdep.c, xfaces.c:
263 Include <c-ctype.h> instead of <ctype.h>.
264 * nsterm.m: Include <c-ctype.h>.
265 * charset.c (read_hex):
266 * doc.c (Fsnarf_documentation):
267 * fileio.c (IS_DRIVE) [WINDOWSNT]:
268 (DRIVE_LETTER) [DOS_NT]:
269 (Ffile_name_directory, Fexpand_file_name)
270 (Fsubstitute_in_file_name):
271 * font.c (font_parse_xlfd, font_parse_fcname):
272 * frame.c (x_set_font_backend):
273 * gtkutil.c (xg_get_font):
274 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
275 * nsimage.m (hexchar):
276 * nsterm.m (ns_xlfd_to_fontname):
277 * sysdep.c (system_process_attributes):
278 * xfaces.c (hash_string_case_insensitive):
279 Use C-locale tests instead of locale-specific tests for character
280 types, since we want the ASCII interpretation here, not the
281 interpretation suitable for whatever happens to be the current locale.
282
52162052
MR
2832012-08-16 Martin Rudalics <rudalics@gmx.at>
284
285 Consistently check windows for validity/liveness
286 (Bug#11984, Bug#12025, Bug#12026).
287 * lisp.h (CHECK_VALID_WINDOW): New macro.
288 * window.c (decode_window): Rename to decode_live_window.
289 (decode_valid_window, Fwindow_valid_p): New functions.
290 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
291 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
292 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
293 (Fwindow_prev_sibling, Fwindow_combination_limit)
294 (Fset_window_combination_limit, Fwindow_use_time)
295 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
296 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
297 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
298 (Fwindow_hscroll, Fset_window_hscroll)
299 (Fwindow_redisplay_end_trigger)
300 (Fset_window_redisplay_end_trigger, Fwindow_edges)
301 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
302 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
303 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
304 (Fwindow_end, Fset_window_point, Fset_window_start)
305 (Fpos_visible_in_window_p, Fwindow_line_height)
306 (Fwindow_dedicated_p, Fset_window_dedicated_p)
307 (Fwindow_prev_buffers, Fset_window_prev_buffers)
308 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
309 (Fset_window_parameter, Fwindow_display_table)
310 (Fset_window_display_table, Fdelete_other_windows_internal)
311 (Fset_window_buffer, Fset_window_new_total)
312 (Fset_window_new_normal, Fdelete_window_internal)
313 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
314 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
315 (Fwindow_scroll_bars): Check whether argument window is a valid or
316 live window. Update doc-strings.
317 (syms_of_window): New symbol Qwindow_valid_p.
318 * keyboard.c (Fposn_at_x_y): Check whether argument
319 frame_or_window denotes a valid window.
320
2751c80f
DA
3212012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
322
323 Fix previous char table change.
324 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
325 * chartab.c (optimize_sub_char_table): Likewise.
326
032a42c8
CY
3272012-08-16 Chong Yidong <cyd@gnu.org>
328
a2d19368
CY
329 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
330
032a42c8
CY
331 * xfont.c (xfont_open):
332 * xftfont.c (xftfont_open): Set the font's max_width field.
333
334 * nsfont.m (nsfont_open): Similar to the Xft backend, set
335 min_width to space_width and average_width to the average over
336 printable ASCII characters.
337 (ns_char_width): Code cleanup.
338 (ns_ascii_average_width): New utility function.
339
340 * font.h (struct font): Update comments.
341
a098c930
DA
3422012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
343
032a42c8 344 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
345 * lisp.h (CSET): New macro.
346 (char_table_set_extras, char_table_set_contents)
347 (sub_char_table_set_contents): New function.
348 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
349 * syntax.c: Adjust users.
350
8be3a09c
SM
3512012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
352
353 * eval.c (eval_sub): Bind lexical-binding.
354 * lread.c (Qlexical_binding): Make non-static.
355
ac4845a6
JD
3562012-08-15 Jan Djärv <jan.h.d@swipnet.se>
357
ddee6515
JD
358 * nsmenu.m (popupSession): Remove.
359 (pop_down_menu): Remove endModalSession.
360 (timeout_handler:): New method.
361 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
362 Call runModalForWindow. Check timer_fired when it returns.
363 If not set, cancel timer and break out of loop.
364 Otherwise loop again, with a new timeout.
365
366 * nsterm.m: Include fcntl.h if present.
367 (fd_entry, t_readfds, inNsSelect): Remove.
368 (select_writefds, select_valid, select_timeout, selfds)
369 (select_mutex, apploopnr): Add.
370 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
371 Otherwise call kbd_buffer_store_event.
372 (ns_send_appdefined): Remove release of fd_entry.
373 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
374 Increment and decrement apploopnr.
375 (ns_select): If no file descriptors, just do a NSTimer.
376 Otherwise copy read/write masks and start select thread (fd_handler).
377 Start main loop and wait for application defined event.
378 Inform select thread to stop selecting after main loop is exited.
379 (ns_term_init): Create selfds pipe and set non-blocking.
380 Initialize select_mutex. Start the select thread (fd_handler).
381 (fd_handler:): Loop forever, wait for info from the main thread
382 to either start or stop selecting. When select returns, send
383 and appdefined event.
384 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
385 If not call kbd_buffer_store_event.
386
387 * nsterm.h (EmacsApp): fd_handler takes id argument.
388 (EmacsDialogPanel): Add timer_fired and timeout_handler.
389
ac4845a6
JD
390 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
391
eb424fe3
EZ
3922012-08-15 Eli Zaretskii <eliz@gnu.org>
393
394 * region-cache.c (move_cache_gap): Update gap_len using the actual
395 growth of the boundaries array. Do not change cache_len.
396 (Bug#12196)
397
4e6a86c6
DA
3982012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
399
400 Generalize and cleanup font subsystem checks.
401 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
402 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
403 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 404
5bf192ca
DA
4052012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
406
407 * gtkutil.c (xg_get_font): Use pango_units_to_double.
408
f2045622
CY
4092012-08-15 Chong Yidong <cyd@gnu.org>
410
8be3a09c
SM
411 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
412 When using the new font chooser, use gtk_font_chooser_get_font_desc to
413 extract the font descriptor instead of just the font name.
414 In that case, return a font spec instead of a string.
f2045622
CY
415 (x_last_font_name): Move to this file from xfns.c.
416
417 * xfns.c (Fx_select_font): The return value can also be a font
418 spec. Move x_last_font_name management to gtkutil.c.
419
420 * xfaces.c: Make font weight and style symbols non-static.
421
7f6feb56
SM
4222012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
423
424 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
425 (bug#12117).
426
fecbd8ff
SM
4272012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
428
429 * alloc.c (Fgarbage_collect): Use plural form consistently.
430
9b8d5165
EZ
4312012-08-14 Eli Zaretskii <eliz@gnu.org>
432
433 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
434 iteration through the command loop. Fixes a problem whereby mouse
435 movements are ignored until the first mouse click.
436
f5d9e83a
PE
4372012-08-14 Paul Eggert <eggert@cs.ucla.edu>
438
439 Use bool, not int, for Lisp booleans.
440 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
441 makes Emacs a bit smaller and presumably a bit faster.
442 * lisp.h: Include <stdbool.h>.
443 (struct Lisp_Boolfwd, defvar_bool):
444 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
445 * regex.c [!emacs]: Include <stdbool.h>.
446 (false, true): Remove; <stdbool.h> does this for us now.
447
55802e4a
CY
4482012-08-14 Chong Yidong <cyd@gnu.org>
449
4abcdac8
CY
450 * character.c (Fcharacterp): Doc fix (Bug#12076).
451
452 * data.c (Findirect_variable): Doc fix (Bug#11040).
453
55802e4a
CY
454 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
455
456 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 457 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 458
8e99d072
BR
4592012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
460
461 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
462 (bug#12022).
463
08908aca
MR
4642012-08-14 Martin Rudalics <rudalics@gmx.at>
465
466 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
467 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
468 * minibuf.c (choose_minibuf_frame, read_minibuf):
469 * w32fns.c (x_create_tip_frame):
470 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
471 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
472
56120d6f
PE
4732012-08-14 Paul Eggert <eggert@cs.ucla.edu>
474
475 * intervals.c (offset_intervals): Remove obsolete comment.
476
67b77c0b
AS
4772012-08-14 Andreas Schwab <schwab@linux-m68k.org>
478
479 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
480
f48b82fd
GR
4812012-08-14 Gergely Risko <gergely@risko.hu>
482
483 * coding.c (decode_coding): Record buffer modification before
484 disabling undo_list (Bug#11773).
485
fd318b54
DA
4862012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
487
488 Revert and cleanup some recent overlay changes.
489 * buffer.h (enum overlay_type): Remove.
490 (buffer_get_overlays, buffer_set_overlays): Likewise.
491 (buffer_set_overlays_before, buffer_set_overlays_after):
492 New function. Adjust users.
493 (unchain_both): Add eassert.
494
41a62dd9
DA
4952012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
496
497 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
498
5884c324
PE
4992012-08-14 Paul Eggert <eggert@cs.ucla.edu>
500
501 * gtkutil.c (xg_mark_data): Don't assume C99.
502
ca06f160
JD
5032012-08-13 Jan Djärv <jan.h.d@swipnet.se>
504
505 * gtkutil.c (xg_frame_tb_info): New struct.
506 (TB_INFO_KEY): New define.
507 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
508 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
509 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
510 if not present.
511 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
512 is up to date. Otherwise store new data.
513 (free_frame_tool_bar): Free xg_frame_tb_info if present.
514
7864a3f7
DA
5152012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
516
517 Use KSET for write access to Lisp_Object members of struct kboard.
518 * keyboard.h (KSET): New macro.
519 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
520 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
521 * xterm.c: Adjust users.
522
4c31be61
DA
5232012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
524
525 Use BSET for write access to Lisp_Object members of struct buffer.
526 * buffer.h (BSET): New macro.
527 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
528 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
529 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
530 * window.c, xdisp.c, xfns.c: Adjust users.
531
14ae4239
BT
5322012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
533
534 * lread.c (syms_of_lread): Initialize Vlexical_binding.
535
32bcadb4
JD
5362012-08-11 Jan Djärv <jan.h.d@swipnet.se>
537
3d29b2ce
JD
538 * nsterm.m (not_in_argv): New function.
539 (application:openFile, application:openTempFile:):
540 (application:openFileWithoutUI:, application:openFiles:): Open file
541 if not_in_argv returns non-zero (bug#12171).
542
32bcadb4 543 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
544 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
545 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
546 (xg_get_font_name): Use those functions/macros here.
547 Reported by Frans Oilinki <moilinki@gmail.com>.
548
9ff9402d 5492012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
550
551 * unexmacosx.c (copy_data_segment): Copy initialized data in
552 statically linked libraries from input file rather than memory.
553
db74a5fc
YM
554 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
555 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
556 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
557
25e65510
GM
5582012-08-10 Glenn Morris <rgm@gnu.org>
559
560 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
561 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
562
7961135c
DA
5632012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
564
565 Fix last change to allow compilation with low optimization levels.
566 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
567 Reported by Jan Djärv <jan.h.d@swipnet.se>.
568
42b3a444
DA
5692012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
570
571 Use common inline syntax in intervals.h.
572 * intervals.h (INTERVALS_INLINE): New macro.
573 Change all users from LISP_INLINE.
574
9fb0c957
DA
5752012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Define Qnone once for all platforms.
578 * frame.c (Qnone): Define here.
579 (syms_of_frame): DEFSYM it.
580 * lisp.h (Qnone): New declaration.
581 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
582 * xfns.c: Remove duplication. Adjust users.
583
65e8ee52
DA
5842012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Remove unused macros from intervals.h.
587 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
588 * intervals.c: Adjust comment.
589
9b855fd6
EZ
5902012-08-10 Eli Zaretskii <eliz@gnu.org>
591
592 * w32fns.c <w32_unicode_gui>: New static variable.
593 (globals_of_w32fns): Initialize it according to os_subtype.
594 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
595 testing os_subtype.
596
39cb9e56 5972012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
598 Eli Zaretskii <eliz@gnu.org>
599
600 Fix bug #10299 with Unicode characters sent by customized
601 keyboards created by MSKLC.
602 * w32fns.c (INIT_WINDOW_CLASS): New macro.
603 (w32_init_class): Use it to initialize the Emacs class with either
604 ANSI or Unicode API calls.
605 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
606 later.
607 (w32_wnd_proc): If the character code sent by WM_CHAR or
608 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
609 original message. Call DefWindowProcW on NT and later.
610
9374581a
GM
6112012-08-10 Glenn Morris <rgm@gnu.org>
612
4b94e8cf
GM
613 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
614
9374581a
GM
615 * lisp.h (DIRECTORY_SEP): Let configure set it.
616
a2752828
DA
6172012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
618
619 Use TSET for write access to Lisp_Object slots of struct terminal.
620 * termhooks.h (TSET): New macro.
621 * coding.c, terminal.c, xselect.c: Adjust users.
622
cc92c454
SM
6232012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
624
625 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
626 the failing expression, include them in the error message.
627 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
628 * lisp.h (internal_condition_case_n): Update declaration.
629
4cb3e6b3
DA
6302012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
631
632 Inline functions to examine and change buffer overlays.
633 * buffer.c (unchain_both): New function.
634 * buffer.h (buffer_get_overlays, buffer_set_overlays):
635 (buffer_has_overlays): New function.
636 (enum overlay_type): New enum.
637 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
638 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
639
8707c1e5
DA
6402012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
641
642 Inline functions to examine and change buffer intervals.
643 * alloc.c (mark_interval_tree): Remove.
644 (MARK_INTERVAL_TREE): Simplify.
645 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
646 * intervals.c (buffer_balance_intervals): New function.
647 (graft_intervals_into_buffer): Adjust indentation.
648 (set_intervals_multibyte): Simplify.
649 * buffer.h (BUF_INTERVALS): Remove.
650 (buffer_get_intervals, buffer_set_intervals): New function.
651 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
652 * intervals.c, textprop.c: Adjust users.
653
ad8c997f
DA
6542012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
655
656 Inline functions to examine and change string intervals.
657 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
658 (string_get_intervals, string_set_intervals): New function.
659 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
660 * lread.c, print.c, textprop.c: Adjust users.
661
32ac3a6b
GM
6622012-08-08 Glenn Morris <rgm@gnu.org>
663
664 * lisp.mk (lisp): Remove language/persian.elc.
665
77c7bcb1
DA
6662012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
667
668 Cleanup intervals.
669 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
670 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
671 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
672 Adjust comment. Move under #if 0.
77c7bcb1
DA
673 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
674 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
675
9c08a8d4
DA
6762012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
677
678 Check total length of intervals with eassert.
679 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
680 * intervals.c: Change all users to eassert.
681
26d16b35
EZ
6822012-08-07 Eli Zaretskii <eliz@gnu.org>
683
14ae4239
BT
684 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
685 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
686 INTERNAL_FIELD in Lisp_Cons.
687
c644523b
DA
6882012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
689
690 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
691 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
692 name since all xname users are fixed long time ago. Do not
693 use INTERNAL_FIELD.
694 (set_symbol_name, set_symbol_function, set_symbol_plist):
695 (set_symbol_next, set_overlay_plist): New function.
696 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
697 (struct Lisp_Overlay): Likewise.
698 (CVAR, MVAR, SVAR): Remove.
699 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
700 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
701 * xterm.c: Adjust users.
702 * .gdbinit: Change to use name field of struct Lisp_Symbol
703 where appropriate.
704
6a3d20cc
DA
7052012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
706
707 Basic functions to set Lisp_Object and pointer slots of intervals.
708 * intervals.h (interval_set_parent, interval_set_object):
709 (interval_set_left, interval_set_right, interval_set_plist):
710 (interval_copy_parent): New function.
711 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
712 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
713 Adjust indentation.
6a3d20cc
DA
714 (INTERVAL_SIZE): Remove. Adjust users.
715 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
716
4d2b044c
DA
7172012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
718
719 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
720 * process.h (PGET): Remove.
721 (struct Lisp_Process): Do not use INTERNAL_FIELD.
722 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
723
d3d50620
DA
7242012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
725
726 Drop WGET and revert read access to Lisp_Objects slots of struct window.
727 * window.h (WGET): Remove.
728 (struct window): Do not use INTERNAL_FIELD.
729 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
730 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
731 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
732 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
733 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
734 Adjust users.
735
d10a51dc
CY
7362012-08-07 Chong Yidong <cyd@gnu.org>
737
738 * window.c (Fwindow_edges, Fwindow_pixel_edges)
739 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
740 (Fdelete_window_internal): Signal an error if the window is not on
741 a live frame (Bug#12025).
742
e69b0960
DA
7432012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
744
745 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
746 * frame.h (FGET): Remove.
747 (struct frame): Do not use INTERNAL_FIELD.
748 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
749 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
750 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
751 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
752
25a20a3a
JB
7532012-08-06 Juanma Barranquero <lekktu@gmail.com>
754
755 * w32.c: Silence compiler warnings.
756 (map_w32_filename): Remove unused variable `is_fat'.
757 (chase_symlinks): Add parentheses around expression.
758
1c6f11f4
GM
7592012-08-06 Glenn Morris <rgm@gnu.org>
760
1db4583a
GM
761 * sysdep.c: Respect BROKEN_GETWD.
762
1c6f11f4
GM
763 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
764 Let configure handle it.
765 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
766
2b90362b
DA
7672012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
768
769 Use GCALIGNMENT where appropriate.
770 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
771 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
772 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
773
5f50daf2
EZ
7742012-08-06 Eli Zaretskii <eliz@gnu.org>
775
14ae4239
BT
776 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
777 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 778
cbcc7007
SM
7792012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
780
781 * buffer.h (struct buffer): Revert `indirections' to a simple int;
782 that should be sufficient for everyone.
783
4d365fa4
JD
7842012-08-06 Jan Djärv <jan.h.d@swipnet.se>
785
786 * keyboard.c (timer_check_2): Add break so timer_check returns next
787 timeout.
788
dd86bd82
DA
7892012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
790
791 Fix Windows build errors introduced after converting to WGET and WSET.
792 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
793 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
794
054e1668
JD
7952012-08-06 Jan Djärv <jan.h.d@swipnet.se>
796
797 * nsterm.m (ns_frame_rehighlight): Use FSET.
798
799 * nsmenu.m (ns_update_menubar): Use FSET.
800
21238f11
DA
8012012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
802
803 Separate read and write access to Lisp_Object slots of Lisp_Process.
804 * process.h (PGET, PSET): New macros similar to AREF and ASET.
805 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
806
077288cf
DA
8072012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
808
809 Separate read and write access to Lisp_Object slots of struct window.
810 * window.h (WGET, WSET): New macros similar to AREF and ASET.
811 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
812 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
813 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
814 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
815 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
816 Adjust users.
817
71688bd7
DA
8182012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
819
820 Fix Windows build errors introduced after converting to FGET and FSET.
821 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
822 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
823 (w32_judge_scroll_bars): Change to use FSET.
824 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
825
f99bac93
DA
8262012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
827
828 Fix replacement typo.
829 * window.c (replace_window): Set root_window instead of
830 selected_window. This fixes a total window subsystem
831 malfunction reported by Bastien Guerry <bzg@gnu.org>.
832
8c2a0f2d
GM
8332012-08-06 Glenn Morris <rgm@gnu.org>
834
835 * lisp.mk (lisp): Add language/persian.elc.
836
edd74c35
DA
8372012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
838
839 Separate read and write access to Lisp_Object slots of struct frame.
840 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
841 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
842 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
843 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
844 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
845
8671676c
AS
8462012-08-05 Andreas Schwab <schwab@linux-m68k.org>
847
848 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
849
663e2b3f
DA
8502012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
851
852 Generalize common compile-time constants.
853 * lisp.h (header_size, bool_header_size, word_size): Now here.
854 (struct Lisp_Vector): Add comment.
855 (struct Lisp_Bool_Vector): Move up to define handy constants.
856 (VECSIZE, PSEUDOVECSIZE): Simplify.
857 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
858 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
859 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
860 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
861 * xfont.c, xmenu.c: Use word_size where appropriate.
862
d32e47af
LM
8632012-08-05 Lawrence Mitchell <wence@gmx.li>
864
865 * search.c (Freplace_match): Treat \? in the replacement text
866 literally (Bug#8161).
867
e5d9c0d1
CY
8682012-08-05 Chong Yidong <cyd@gnu.org>
869
870 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
871 * frame.c (Vdelete_frame_functions):
872 * emacs.c (Vkill_emacs_hook): Doc fix.
873
8da0576b
EZ
8742012-08-04 Eli Zaretskii <eliz@gnu.org>
875
876 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
877 --with-x-toolkit=no builds.
878 Reported by Carsten Mattner <carstenmattner@gmail.com>.
879
02676e5d
CY
8802012-08-04 Chong Yidong <cyd@gnu.org>
881
882 * syntax.c (Fmodify_syntax_entry): Doc fix.
883
97147da9
EZ
8842012-08-04 Eli Zaretskii <eliz@gnu.org>
885
76151e2c
EZ
886 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
887 * w32.c (init_environment): Change the default values of many
888 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
889 them into environment when they were not already defined.
890 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 891 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
892 (check_windows_init_file): Now external, not static.
893 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
894 called when Vload_path is already set up.
895
896 * w32.h (check_windows_init_file): Add prototype.
897
898 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
899 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
900 compatibility with Posix platforms.
901 (main): Move the call to check_windows_init_file to here from
902 w32.c.
903 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
904 any, in the DEFALT argument into the root of the Emacs build or
905 installation tree, as appropriate.
906
907 * callproc.c (init_callproc_1): Call decode_env_path instead of
908 doing its equivalent by hand.
909 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
910 the code that sets Vexec_path run on MS-Windows.
911
912 * lread.c (init_lread): Add comments to #ifdef's.
913
97147da9
EZ
914 * msdos.c (dos_set_window_size, IT_update_begin)
915 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
916 instead of direct references.
917
185ee146
PE
9182012-08-04 Paul Eggert <eggert@cs.ucla.edu>
919
920 Export DEFAULT_REHASH_* to GDB.
921 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
922 Now constants, not macros.
923
8834c57a
PE
9242012-08-03 Paul Eggert <eggert@cs.ucla.edu>
925
98c6f1e3
PE
926 Remove unnecessary casts involving pointers.
927 These casts are no longer needed now that we assume C89 or later,
928 since they involve casting to or from void *.
929 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
930 (make_pure_float, make_pure_vector):
931 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
932 * macros.c (Fstart_kbd_macro):
933 * menu.c (find_and_return_menu_selection):
934 * minibuf.c (read_minibuf_noninteractive):
935 * sysdep.c (closedir):
936 * xdisp.c (x_produce_glyphs):
937 * xfaces.c (compare_fonts_by_sort_order):
938 * xfns.c (x_real_positions, select_visual):
939 * xselect.c (x_stop_queuing_selection_requests)
940 (x_get_window_property, x_get_window_property_as_lisp_data):
941 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
942 Remove unnecessary pointer casts.
943 * alloc.c (record_xmalloc): New function.
944 * lisp.h (record_xmalloc): New decl.
945 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
946 more like a function. This is because the pointer cast is not
947 needed. All uses changed.
948 * print.c (print_string, print_error_message): Avoid length recalc.
949
8834c57a
PE
950 Improve fix for macroexp crash with debugging (Bug#12118).
951 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
952 ARRAY_MARK_FLAG when checking subscripts, because ASET is
953 not supposed to be invoked from the garbage collector.
954 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
955 (gc_aset): New function, which is like ASET but can be
956 used in the garbage collector.
957 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
958 (set_hash_index): Use it instead of ASET.
959
6dad7178
EZ
9602012-08-03 Eli Zaretskii <eliz@gnu.org>
961
962 Support symlinks on latest versions of MS-Windows.
963 * w32.c: Include winioctl.h and aclapi.h.
964 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
965 (revert_to_self): Forward declarations of static functions.
966 <static BOOL g_b_init_get_security_info>:
967 <g_b_init_create_symbolic_link>: New static flags.
968 (globals_of_w32): Initialize them to zero.
969 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
970 (map_w32_filename): Improve commentary. Simplify switch.
971 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
972 headers (most versions of MinGW w32api don't).
973 (get_security_info, create_symbolic_link)
974 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
975 New functions.
976 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
977 in the argument file name.
978 (sys_access): Call unc_volume_file_attributes only if
979 GetFileAttributes fails with network-related error codes.
980 (sys_rename): Diagnose renaming of a symlink when the user doesn't
981 have the required privileges.
14ae4239 982 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
983 get_file_security_desc.
984 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
985 with addition of handling of symlinks and support for 'lstat'.
986 If possible, get file's attributes and security information by
6dad7178
EZ
987 handle, not by name. Produce S_IFLNK bit for symlinks, when
988 called from 'lstat'.
989 (stat, lstat): New functions, call 'stat_worker'.
990 (symlink, readlink, careadlinkat): Rewritten to create and resolve
991 symlinks when the underlying filesystem supports them.
992
f162bcc3
PE
9932012-08-02 Paul Eggert <eggert@cs.ucla.edu>
994
79ea6c20
PE
995 Fix macroexp crash on Windows with debugging (Bug#12118).
996 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
997 checking subscripts; problem introduced with the recent
998 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
999 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
1000 since it's used in non-static inline functions now.
1001
c0ce93fd
PE
1002 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
1003 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 1004
f162bcc3
PE
1005 Use C99-style 'extern inline' if available.
1006 * buffer.h (BUFFER_INLINE):
1007 * category.h (CATEGORY_INLINE):
1008 * character.h (CHARACTER_INLINE):
1009 * charset.h (CHARSET_INLINE):
1010 * composite.h (COMPOSITE_INLINE):
1011 * dispextern.h (DISPEXTERN_INLINE):
1012 * lisp.h (LISP_INLINE):
1013 * systime.h (SYSTIME_INLINE):
1014 New macro, replacing 'static inline' in this header.
1015 * buffer.h, category.h, character.h, charset.h, composite.h:
1016 * dispextern.h, lisp.h, systime.h:
1017 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1018 * alloc.c (LISP_INLINE):
1019 * buffer.c (BUFFER_INLINE):
1020 * category.c (CATEGORY_INLINE):
1021 * character.c (CHARACTER_INLINE):
1022 * charset.c (CHARSET_INLINE):
1023 * composite.c (COMPOSITE_INLINE):
1024 * dispnew.c (DISPEXTERN_INLINE):
1025 * sysdep.c (SYSTIME_INLINE):
1026 Define to EXTERN_INLINE, so that the corresponding functions
1027 are compiled into code.
1028 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
1029 (INLINE_HEADER_END): New macros.
1030 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
1031 since it's used in non-static inline functions now.
a8333d03 1032 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 1033
837b365b
GM
10342012-08-02 Glenn Morris <rgm@gnu.org>
1035
d66b744d
GM
1036 * s/: Remove empty directory.
1037
837b365b
GM
1038 * s/ms-w32.h: Move to ../nt/inc.
1039 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
1040 Update for new ms-w32.h location.
1041
13294f95
PE
10422012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1043
1044 Port to Solaris 8.
1045 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
1046
90df0db3
GM
10472012-08-02 Glenn Morris <rgm@gnu.org>
1048
1049 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
1050 hard-coding the path separator.
1051
4939150c
PE
10522012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1053
1054 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
1055 This how ASET and AREF are supposed to work, and makes
1056 it easier to think about future improvements. See
1057 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
1058 * charset.h (set_charset_attr): New function.
1059 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
1060 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
1061 (aref_addr): New function. All uses of &AREF(...) changed.
1062 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1063 (set_hash_index): New functions. All lvalue-style uses of
1064 HASH_KEY etc. changed.
1065 * keyboard.c (set_prop): New function. All lvalue-style uses
1066 of PROP changed.
1067
947b2afd
AA
10682012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
1069
1070 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
1071 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1072 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
1073 * nsfns.m (ns_set_name_as_filename): Likewise.
1074 * nsmenu.m (ns_update_menubar): Likewise.
1075 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
1076
4f5d0325
EZ
10772012-08-01 Eli Zaretskii <eliz@gnu.org>
1078
2008beae
EZ
1079 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
1080 Adapt to latest changes in field names of the corresponding Lisp
288479f6 1081 objects.
2008beae 1082
4f5d0325
EZ
1083 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
1084
fe3cc771
GM
10852012-08-01 Glenn Morris <rgm@gnu.org>
1086
1087 * s/msdos.h: Remove file.
1088 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
1089 * Makefile.in (S_FILE): Remove.
1090 (config_h): Remove S_FILE.
1091
c90acc54
JB
10922012-08-01 Juanma Barranquero <lekktu@gmail.com>
1093
1094 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
1095 Remove; moved to nt/config.nt.
1096
d8a05828
DA
10972012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 Use INTERNAL_FIELD for conses and overlays.
1100 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
1101 Remove obsolete comment.
1102 (MVAR): New macro.
1103 (struct Lisp_Overlay): Use INTERNAL_FIELD.
1104 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
1105
8271d590
DA
11062012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1107
1108 Use INTERNAL_FIELD for symbols.
1109 * lisp.h (SVAR): New macro. Adjust users.
1110 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
1111 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
1112
3193acd2
DA
11132012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1114
1115 Use INTERNAL_FIELD for processes.
1116 * process.h (PVAR): New macro. Adjust style.
1117 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
1118 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
1119
3a45383a
DA
11202012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1121
1122 Use INTERNAL_FIELD for windows.
1123 * window.h (WVAR): New macro.
1124 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
1125 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1126 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1127 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
1128 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
1129 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1130
c1dbc63c
PE
11312012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1132
1133 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
1134
5c0c0e8a
GM
11352012-08-01 Glenn Morris <rgm@gnu.org>
1136
1137 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
1138 Move to configure.ac.
1139
552a99b4
JB
11402012-08-01 Juanma Barranquero <lekktu@gmail.com>
1141
1142 * makefile.w32-in (CONFIG_H): Update dependencies.
1143 (CONF_POST_H): New macro.
1144
1145 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
1146
8d8e2dfe
GM
11472012-07-31 Glenn Morris <rgm@gnu.org>
1148
bc96620a
GM
1149 * Makefile.in (S_FILE): No longer set by configure.
1150
476b1b2d
GM
1151 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
1152 is available.
1153 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
1154
b2c7a106
GM
1155 * process.h (NULL_DEVICE):
1156 * emacs.c (SEPCHAR):
1157 * editfns.c (USER_FULL_NAME): Let configure set them.
1158
d53d062a
GM
1159 * s/README, s/template.h: Remove files.
1160
4515017f
GM
1161 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
1162
8d8e2dfe
GM
1163 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
1164 Move to configure.ac.
1165
5b20b3cc
EZ
11662012-07-31 Eli Zaretskii <eliz@gnu.org>
1167
1e0afd9a
EZ
1168 * .gdbinit (xframe): Adapt to introduction of FVAR and the
1169 resulting renaming of 'struct frame' members.
1170
5b20b3cc
EZ
1171 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
1172
1173 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
1174 after introduction of FVAR.
1175
f1310128
JD
11762012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1177
79e721e0
JD
1178 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
1179
1180 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
1181 instead of compositeToPoint.
1182 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
1183
8d7c7eed 1184 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 1185
e34f7f79
DA
11862012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1187
1188 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
1189 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 1190 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
1191 (BVAR): Change to use INTERNAL_FIELD.
1192 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
1193 (KVAR): Change to use INTERNAL_FIELD.
1194 * frame.h (FVAR): New macro.
1195 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
1196 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
1197 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
1198 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
1199 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1200
c09bfb2f
DA
12012012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1202
1203 Miscellaneous fixes for non-default X toolkits.
1204 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
1205 * xterm.c (x_frame_of_widget): Remove redundant prototype.
1206 Move under #ifdef USE_LUCID.
1207 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
1208 definition and usage to avoid warnings.
1209
14c114ae
JD
12102012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1211
1212 * nsterm.m (openFiles): Fix previous checkin.
1213
3bd21e82
PE
12142012-07-31 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 * indent.c (compute_motion): Remove unused local.
1217
c1529ded
GM
12182012-07-31 Glenn Morris <rgm@gnu.org>
1219
400d5621
GM
1220 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
1221
268e2432
GM
1222 * conf_post.h [USG5_4]:
1223 Move remaining contents of s/usg5-4-common.h here.
1224 * s/usg5-4-common.h: Remove file.
1225
7552f3ee
GM
1226 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
1227 * s/irix6-5.h: Remove file.
1228
6a381852
GM
1229 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
1230 * s/darwin.h: Remove file.
1231
c1529ded
GM
1232 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
1233 * s/hpux10-20.h: Remove file, which is now empty.
1234
b429a4ee
GM
12352012-07-30 Glenn Morris <rgm@gnu.org>
1236
1237 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
1238 * Makefile.in (config_h): Add conf_post.h.
1239 * makefile.w32-in (CONFIG_H): Add conf_post.h.
1240
adff3182
JD
12412012-07-30 Jan Djärv <jan.h.d@swipnet.se>
1242
1243 * nsterm.m (ns_do_open_file): New variable.
b9031d69 1244 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
1245 (openFile, openTempFile, openFileWithoutUI, openFiles):
1246 Open files only if ns_do_open_file.
adff3182 1247
c32af1e4
PE
12482012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1249
7393bcbb
PE
1250 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
1251 This no-op macro hasn't been needed for many years.
1252 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
1253
c32af1e4
PE
1254 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
1255 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
1256 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
1257 gdb_make_enums_visible.
1258 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
1259 (DIRECTORY_SEP): Now a constant, not a macro.
1260
302fc036
EZ
12612012-07-30 Eli Zaretskii <eliz@gnu.org>
1262
1263 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
1264 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
1265
1266 * w32term.c <w32_keyboard_codepage>: Renamed from
1267 keyboard_codepage and now external. All users changed.
1268
1269 * w32term.h: Add declaration of w32_keyboard_codepage.
1270
1271 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
1272 the codepage to translate keys to Unicode. If this argument is
1273 -1, use the value returned by GetConsoleCP. All callers changed.
1274
88fb40b4
PE
12752012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1276
0aee6912
PE
1277 Update .PHONY listings in makefiles.
1278 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
1279 bootstrap-clean, distclean, maintainer-clean, versioclean,
1280 extraclean, frc.
1281
88fb40b4
PE
1282 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
1283 This is a bit clearer. Fix some commentary typos.
1284
0a763bd1
GM
12852012-07-30 Glenn Morris <rgm@gnu.org>
1286
32bac6d6
GM
1287 * s/netbsd.h: Let configure include signal.h if needed.
1288 Remove file, which is now empty.
1289
b65e7c46
GM
1290 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
1291 Let configure set them.
1292 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
1293 No more need to undefine.
0a763bd1 1294
169304bd
AS
12952012-07-30 Andreas Schwab <schwab@linux-m68k.org>
1296
1297 * keymap.c (Fkey_description): Don't remove 0x80 bit from
1298 non-single-byte char when adding meta modifier. (Bug#12090)
1299
6cd7a139
DA
13002012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1301
1302 Convert safe_call to use variable number of arguments.
1303 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
1304 (safe_call2): Fix comment.
1305 * lisp.h (safe_call): Adjust prototype.
1306 * coding.c (encode_coding_object): Change to use safe_call2.
1307 * xfaces.c (merge_face_heights): Change to use safe_call1.
1308
d34d6ffc
GM
13092012-07-30 Glenn Morris <rgm@gnu.org>
1310
7b8a48e4 1311 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 1312 does that unconditionally. Remove file, which is now empty.
7b8a48e4 1313
d34d6ffc
GM
1314 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
1315 Remove empty files.
1316
03a660a6
PE
13172012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 Export to GDB most of lisp.h's remaining object-like macros.
1320 * lisp.h (min, max): Move earlier, because they're used earlier now.
1321 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
1322 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
1323 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
1324 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
1325 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
1326 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
1327 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
1328 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
1329 Now constants, for GDB. They need not be macros.
1330 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
1331 Now constants, for GDB, as well as macros, for static initializers.
1332 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
1333 Move to after the definition of struct Lisp_Char_Table,
1334 since the former now needs that type defined.
1335 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
1336 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
1337 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
1338 New enums, for gdb_make_enums_visible.
1339 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 1340 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
1341 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
1342 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
1343 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
1344 enum maxargs, enum MAX_ALLOCA.
1345 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
1346 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
1347 no longer needed, now that they are done in lisp.h.
1348
e499d0ee
DA
13492012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1350
1351 Cleanup string bytes checking.
1352 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
1353 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
1354 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
1355 (check_sblock, compact_small_strings): Simplify.
1356
d5040d2d
PE
13572012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
1360 These macros are confusing and no longer need to be defined, as
1361 the enum values now suffice. All uses replaced with definiens.
1362 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
1363
7f259ae6
JB
13642012-07-29 Juanma Barranquero <lekktu@gmail.com>
1365
1366 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
1367 ($(BLD)/w32console.$(O)): Update dependencies.
1368
7e63e0c3
DA
13692012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1370
1371 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
1372 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
1373 time. Adjust users.
1374 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
1375
ffd817eb
JD
13762012-07-29 Jan Djärv <jan.h.d@swipnet.se>
1377
1378 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
1379 setting sitelisp (Bug#12010).
1380
417a7a0e
EZ
13812012-07-29 Eli Zaretskii <eliz@gnu.org>
1382
14ae4239 1383 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
1384
1385 * w32heap.c (cache_system_info):
1386 * w32.c (sys_rename):
1387 * w32proc.c (find_child_console, sys_kill): All users changed.
1388
387d4d92
PE
13892012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1390
1391 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
1392
55a6cca6
EZ
13932012-07-29 Eli Zaretskii <eliz@gnu.org>
1394
1395 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
1396
dbcf001c
DA
13972012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1398
1399 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1400 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1401 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1402
e2688e4a
DA
14032012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1404
1405 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1406 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1407 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1408 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1409 (replace_range, replace_range_2, del_range_2): Change to eassert.
1410 * marker.c (byte_char_debug_check): Adjust style.
1411
b46a6a83
PE
14122012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1415 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1416 long-ago-commented-out code that talks about "WIN32".
1417 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1418 All uses changed.
1419
e32a5799
PE
14202012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1421
1422 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1423 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1424 Simplify by using alignof.
1425 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1426 * lisp.h: Include <stdalign.h>.
1427 (GCALIGNMENT): New macro and constant.
1428 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1429 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1430 (stdalign): New macro, if not already defined.
1431
df81cd29
EZ
14322012-07-28 Eli Zaretskii <eliz@gnu.org>
1433
01bd1b0d
EZ
1434 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1435 * w32inevt.c: Include w32inevt.h.
1436 (w32_read_console_input): New inline function, calls either
1437 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1438 w32_console_unicode_input.
1439 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1440 (w32_kbd_patch_key, key_event): Use the codepage returned by
1441 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1442 (key_event): use uChar.UnicodeChar only if
1443 w32_console_unicode_input is non-zero.
1444
1445 * w32console.c: Include w32heap.h.
1446 <w32_console_unicode_input>: New global variable.
1447 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1448 family of Windows, zero otherwise.
1449
1450 * w32inevt.h: Declare w32_console_unicode_input.
1451
df81cd29
EZ
1452 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1453 --without-x. (Bug#11742)
1454
c20fdd9e
PE
14552012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1456
1457 Adjust GDB to reflect pvec_type changes (Bug#12036).
1458 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1459 2012-07-04 changes to pseudovector representation.
1460 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1461
32770973 14622012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1463
1464 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1465 bus address.
1466 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1467
3438fe21
EZ
14682012-07-27 Eli Zaretskii <eliz@gnu.org>
1469
bcfbc9de
EZ
1470 * alloc.c (listn): Fix the order the arguments are consed onto the
1471 list.
1472
3438fe21
EZ
1473 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1474 enumeration constants, as PURE and HEAP are too general, and clash
1475 with other headers and sources, such as gmalloc.c and the
1476 MS-Windows system headers. All users changed.
1477
eeaea515
DA
14782012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1479
1480 Revert last save_excursion_save and save_excursion_restore changes.
1481 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1482 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1483
073c88c2
DA
14842012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1485
1486 Fix recently-introduced typos in Windows port.
1487 Reported by Martin Rudalics <rudalics@gmx.at>.
1488 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1489 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1490
4706125e
PE
14912012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1492
1493 Improve GDB symbol export (Bug#12036).
1494 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1495 arms of an 'if', not using conditional expressions; otherwise GDB
1496 complains about the types in the unevaluated arm when the argument
1497 is an integer literal.
1498 (xgetint): Simplify expression.
1499 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1500 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1501 Zaretskii in <http://bugs.gnu.org/12036#13>.
1502 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1503 needed now that we have gdb_make_enums_visible.
1504 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1505 (enum enum_USE_LSB_TAG):
1506 New enum types, packaging up enums that need to be exported to GDB.
1507
694b6c97
DA
15082012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1509
1510 Utility function to make a list from specified amount of objects.
1511 * lisp.h (enum constype): New datatype.
1512 (listn): New prototype.
1513 * alloc.c (listn): New function.
1514 (Fmemory_use_count, syms_of_alloc): Use it.
1515 * buffer.c (syms_of_buffer): Likewise.
1516 * callint.c (syms_of_callint): Likewise.
1517 * charset.c (define_charset_internal): Likewise.
1518 * coding.c (syms_of_coding): Likewise.
1519 * keymap.c (syms_of_keymap): Likewise.
1520 * search.c (syms_of_search): Likewise.
1521 * syntax.c (syms_of_syntax): Likewise.
1522 * w32.c (init_environment): Likewise.
1523 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1524 * xdisp.c (syms_of_xdisp): Likewise.
1525 * xfns.c (syms_of_xfns): Likewise.
1526
6195f384
DA
15272012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1528
1529 Fast save_excursion_save and save_excursion_restore.
1530 * lisp.h (struct Lisp_Excursion): New data type.
1531 (PVEC_EXCURSION): New pseudovector type.
1532 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1533 to deal with it. Adjust comments.
1534 (init_marker, attach_marker): New prototype.
1535 (unchain_marker): Adjust prototype.
1536 * marker.c (attach_marker): Change to global.
1537 (init_marker): New function.
1538 * alloc.c (Fmake_marker, build_marker): Use it.
1539 (build_marker): More easserts.
1540 (mark_object): Handle struct Lisp_Excursion.
1541 * editfns.c (save_excursion_save, save_excursion_restore):
1542 Reimplement to use struct Lisp_Excursion. Add comments.
1543
5eceb8fb
PE
15442012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1545
1546 Fix export of symbols to GDB (Bug#12036).
1547 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1548 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1549 emacs.c, as this is a more-suitable home. Had this been done earlier
1550 the fix for 12036 would have avoided some of the problems noted in
1551 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1552 would have been more obvious.
562157c8
PE
1553 * emacs.c: Do not include <verify.h>; no longer needed.
1554 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1555 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1556 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1557 Remove; now done in lisp.h.
1558 * lisp.h (PUBLISH_TO_GDB): New macro.
1559 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1560 (DATA_SEG_BITS): Use it.
1561 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1562 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1563 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1564 not be usable in #if. This simplifies things.
1565
d6749401
JB
15662012-07-26 Juanma Barranquero <lekktu@gmail.com>
1567
1568 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1569
1781b9e9
PE
15702012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1571
d89518db 1572 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1573 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1574 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1575 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1576 Adjust to changes in lisp.h and emacs.c, by using
1577 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1578 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1579 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1580 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1581 instead of gdb_valbits.
1582 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1583 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1584 instead of gdb_array_mark_flag.
1585 (xboolvector): Get size from $->size, not $->header.size.
1586 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1587 (xreload, hook-run, hookpost-run): Remove.
1588 * emacs.c: Include <verify.h>.
1589 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1590 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1591 Remove.
1592 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1593 (gdb_USE_LSB_TAG): New enum constants.
1594 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1595 Also define these as enum constants, so they're visible to GDB.
1596 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1597 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1598 as constants, so they're visible to GDB.
1599 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1600 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1601 Now enum constants, not macros, so they're visible to GDB.
1602 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1603 more convenient now. All uses changed.
1604 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1605 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1606
3628596a
DA
16072012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1608
1609 Explicitly free restriction data that are not needed anymore.
1610 * editfns.c (save_restriction_restore): Free restriction data.
1611
7abaf5cc
SM
16122012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1613
1614 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1615 add argument, tune behavior, and adjust all callers.
1616
71f88e00
PE
16172012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1618
1619 Use typedef for EMACS_INT, EMACS_UINT.
1620 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1621 than macros. This simplifies debugging in the usual case, since
1622 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1623 and it allows expressions involving EMACS_INT casts.
1624 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1625
57ec3034
JD
16262012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1627
1628 * nsterm.m (ns_read_socket): Return early if there is a modal
1629 window (Bug#12043).
1630
8137e7b3
MR
16312012-07-25 Martin Rudalics <rudalics@gmx.at>
1632
1633 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1634 that FOCUS-FRAME can be omitted.
1635
04e9897c
DA
16362012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1637
1638 Adjust buffer text indirection counters at the end of Fkill_buffer.
1639 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1640 buffer is definitely dead. This should really fix an issue reported
1641 by Christoph Scholtes again. (Bug#12007).
1642 (init_buffer_once): Initialize indirection counters of
1643 buffer_defaults and buffer_local_symbols (for sanity and safety).
1644
8a0484e1
EZ
16452012-07-24 Eli Zaretskii <eliz@gnu.org>
1646
1647 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1648 and continuation glyphs on tooltip frames, leave them at zero.
1649 Avoids continued lines in tooltips. (Bug#11832)
1650
fa691a83
DA
16512012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1652
1653 Simplify copy_overlay.
04e9897c 1654 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1655 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1656
436bc8e0
EZ
16572012-07-23 Eli Zaretskii <eliz@gnu.org>
1658
1659 * print.c (print_object): Don't crash when a frame's name is nil
1660 or invalid. (Bug#12025)
1661
1662 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1663 it signals an error when a tooltip frame is being created.
1664
d7a7fda3
DA
16652012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1666
1667 Cleanup miscellaneous objects allocation and initialization.
1668 * alloc.c (allocate_misc): Change to static. Add argument to
1669 specify the subtype. Adjust comment and users.
1670 (build_overlay): New function.
1671 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1672 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1673 (allocate_misc): Remove prototype.
1674 (build_overlay): Add prototype.
1675
16762012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1677
1678 Swap buffer text indirection counters in Fbuffer_swap_text.
1679 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1680 This avoids crash reported by Christoph Scholtes at
1681 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1682
9d7fa573
JD
16832012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1684
1685 * nsmenu.m (Popdown_data): New struct.
1686 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1687 free Popdown_data.
1688 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1689 (initWithContentRect): Make imgView and contentView non-static
1690 and autorelease them. Also autorelease img and matrix (Bug#12005).
1691 (dealloc): Remove (Bug#12005).
1692
0dd6d66d
DA
16932012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1694
1695 Adjust consing_since_gc when objects are explicitly freed.
1696 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1697 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1698 (free_cons, free_misc): Subtract object size from consing_since_gc.
1699
d36d71df
DA
17002012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1701
1702 Simplify and cleanup markers positioning code.
1703 * marker.c (attach_marker): More useful eassert.
1704 (live_buffer, set_marker_internal): New function.
1705 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1706 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1707
fb9ea40f
PE
17082012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1711 as it's limited by the amount of memory, not by INT_MAX.
1712
2d5c5f7d
EZ
17132012-07-21 Eli Zaretskii <eliz@gnu.org>
1714
07fb592e
EZ
1715 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1716 in special-event-map. See the discussion at
1717 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1718 for the reasons.
1719
37a9eac8 1720 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1721 info.dwItemData. Fixes crashes on 64-bit Windows.
1722 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1723
c4328746
JD
17242012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1725
1726 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1727 (conversationIdentifier): Return value is NSInteger.
784051c4 1728 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1729
6e5d1c12
CY
17302012-07-21 Chong Yidong <cyd@gnu.org>
1731
1732 * window.c (decode_any_window): Signal an error if the window is
1733 on a dead frame (Bug#11984).
1734
9928463d
DA
17352012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1736
1737 Add indirection counting to speed up Fkill_buffer.
1738 * buffer.h (struct buffer): New member.
1739 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1740 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1741 base buffer indirection counter.
1742 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1743 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1744 through buffer list if indirection counter is 0.
1745
f8643a6b
DA
17462012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1747
1748 Extend the value returned by Fgarbage_collect with heap statistics.
1749 * alloc.c (Qheap): New symbol.
1750 (syms_of_alloc): DEFSYM it.
1751 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1752 (Fmemory_free): Remove.
1753 (syms_of_alloc): Don't defsubr it.
1754 * buffer.c (Fcompact_buffer): Remove.
1755 (syms_of_buffer): Don't defsubr it.
1756
dac616ff
DA
17572012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1758
1759 Make maybe_gc inline.
1760 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1761 * lisp.h (consing_since_gc, gc_relative_threshold)
1762 (memory_full_cons_threshold): Revert declaration.
1763 (maybe_gc): Remove prototype, define as inline.
1764 * alloc.c: Remove old commented-out code.
1765 (consing_since_gc, gc_relative_threshold)
1766 (memory_full_cons_threshold): Revert to global.
1767 (maybe_gc): Remove.
1768
d7ea76b4
DA
17692012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1770
1771 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1772 * lisp.h (build_unibyte_string): New function.
1773 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1774 * sysdep.c, w32fns.c, xfns.c: Use it.
1775 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1776 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1777 Adjust users accordingly.
1778 * font.h (font_open_by_name): Adjust prototype.
1779
765e61e3
DA
17802012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1781
1782 Cleanup calls to Fgarbage_collect.
1783 * lisp.h (maybe_gc): New prototype.
1784 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1785 Remove declarations.
1786 * alloc.c (maybe_gc): New function.
1787 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1788 Make them static.
1789 * bytecode.c (MAYBE_GC): Use maybe_gc.
1790 * eval.c (eval_sub, Ffuncall): Likewise.
1791 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1792 to avoid dependency from auto-save feature.
1793
52b852c7
PE
17942012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1795
1796 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1797 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1798 'for_each_per_buffer_object_at'.
1799 All uses changed. It's better to use upper-case for macros that
1800 cannot be implemented as functions, to give the reader a clue
1801 that they're special.
1802
5db81e33
SM
18032012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1804
1805 * alloc.c (Fgarbage_collect): Tweak docstring.
1806
5b835e1d
DA
18072012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1808
1809 Tweak the value returned from Fgarbage_collect again.
1810 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1811 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1812 Adjust documentation.
1813 (total_vector_bytes): Rename to total_vector_slots, adjust
1814 accounting.
1815 (total_free_vector_bytes): Rename to total_free_vector_slots,
1816 adjust accounting.
1817 (Qstring_bytes, Qvector_slots): New symbols.
1818 (syms_of_alloc): DEFSYM them.
1819
9cd47b72
DA
18202012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1821
1822 Buffer compaction primitive which may be used from Lisp.
1823 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1824 (syms_of_buffer): Register Fcompact_buffer.
1825 * alloc.c (Fgarbage_collect): Use compact_buffer.
1826 * buffer.h (compact_buffer): New prototype.
1827 (struct buffer_text): New member.
1828
d17337e5
DA
18292012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1830
1831 New macro to iterate over all buffers, miscellaneous cleanups.
1832 * lisp.h (all_buffers): Remove declaration.
1833 * buffer.h (all_buffers): Add declaration, with comment.
1834 (for_each_buffer): New macro.
1835 * alloc.c (Fgarbage_collect, mark_object): Use it.
1836 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1837 (init_buffer): Likewise.
1838 * data.c (Fset_default): Likewise.
1839 * coding.c (code_conversion_restore): Remove redundant check
1840 for dead buffer.
1841 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1842
60cfd278
AS
18432012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1844
1845 Fix bug that created negative-length intervals.
1846 * intervals.c (merge_interval_right, merge_interval_left):
1847 Do not zero out this interval if it is absorbed by its children,
1848 as this interval's total length doesn't change in that case. See
1849 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1850
d06714cb
PE
18512012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1852
83713154
PE
1853 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1854 when invoking (make-bool-vector N t) and N is a positive
1855 multiple of 8 -- the last 8 bits were mistakenly cleared.
1856
d06714cb
PE
1857 Remove some struct layout assumptions in bool vectors.
1858 * alloc.c (bool_header_size): New constant.
1859 (header_size, word_size): Move earlier, as they're now used earlier.
1860 Use 'word_size' in a few more places, where it's appropriate.
1861 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1862 padding before the data member of a bool vector.
1863 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1864 than doing the check by hand with an abort ().
1865
464d5a5e
SM
18662012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1867
5fbc0409
SM
1868 * eval.c (Fdefvar): Don't check constants since we only set the var if
1869 it's not yet defined anyway (bug#11904).
1870
464d5a5e
SM
1871 * lisp.h (last_undo_boundary): Declare new var.
1872 * keyboard.c (command_loop_1): Set it.
1873 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1874 were auto-added by the command loop (bug#11774).
1875
8dc2e44a
AS
18762012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1877
1878 * w32font.c (Qsymbol): Remove local definition.
1879 (syms_of_w32font): Don't DEFSYM it.
1880
169925ec
DA
18812012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1882
1883 Fix sweep_vectors to handle large bool vectors correctly.
1884 * alloc.c (sweep_vectors): Account total_vector_bytes for
1885 bool vectors larger than VBLOCK_BYTES_MAX.
1886
5fbfb018
CY
18872012-07-18 Chong Yidong <cyd@gnu.org>
1888
1889 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1890 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1891
3ab6e069
DA
18922012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1893
1894 Return more descriptive data from Fgarbage_collect.
1895 Suggested by Stefan Monnier in
1896 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1897 * alloc.c (bounded_number): New function.
1898 (total_buffers, total_vectors): New variable.
1899 (total_string_size): Rename to total_string_bytes, adjust users.
1900 (total_vector_size): Rename to total_vector_bytes, adjust users.
1901 (sweep_vectors): Account total_vectors and total_vector_bytes.
1902 (Fgarbage_collect): New return value. Adjust documentation.
1903 (gc_sweep): Account total_buffers.
1904 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1905 (VECTOR_SIZE): Remove.
1906 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1907 (Qinterval, Qmisc): New symbols.
1908 (syms_of_data): Initialize them.
1909 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1910 (Qcons, Qbuffer): New declarations.
1911
6d02fe5b
PE
19122012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1915 Round up, not down. Improve doc.
1916
b7ffe040
DA
19172012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1918
1919 Restore old code in allocate_string_data to avoid Faset breakage.
1920 Reported by Julien Danjou <julien@danjou.info> in
1921 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1922 * alloc.c (allocate_string_data): Restore old code with minor
1923 adjustments, fix comment to explain this subtle issue.
1924
4dc7c8d5
SM
19252012-07-17 Eli Zaretskii <eliz@gnu.org>
1926
1927 Remove FILE_SYSTEM_CASE.
1928 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1929
1930 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1931 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1932 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1933 call-process-region passes it through expand-file-name.
1934
1935 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1936
19372012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1938
1939 Fix crash when creating indirect buffer (Bug#11917)
1940 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1941 Don't handle unbound variables specially if non-zero.
1942 (Fbuffer_local_variables): Pass zero.
1943 (clone_per_buffer_values): Pass non-zero.
1944
19452012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1946
1947 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1948 to make the loop interruptible.
1949
19502012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1951
1952 * gnutls.c (emacs_gnutls_handshake): Only retry if
1953 GNUTLS_E_INTERRUPTED.
1954
cce7fefc
DA
19552012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1956
1957 Cleanup and convert miscellaneous checks to eassert.
1958 * alloc.c (mark_interval): Fix comment, partially rephrase
1959 old comment from intervals.h (see below).
1960 * intervals.c (find_interval, adjust_intervals_for_insertion)
1961 (delete_interval, adjust_intervals_for_deletion)
1962 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1963 Convert to eassert.
1964 (adjust_intervals_for_insertion, make_new_interval):
1965 Remove obsolete and unused code.
1966 * intervals.h (struct interval): Remove obsolete comment.
1967 * textprotp.c (erase_properties): Remove unused code.
1968 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1969 (Fremove_list_of_text_properties): Convert to eassert.
1970
9ea10cc3
CY
19712012-07-17 Chong Yidong <cyd@gnu.org>
1972
1973 * editfns.c (Finsert_char): Doc fix.
1974
3900d5de
DA
19752012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1976
1977 Fix previous change to make Fmemory_free always accurate.
1978 * alloc.c (make_interval): Update total_free_intervals.
1979 (make_float): Likewise for total_free_floats.
1980 (free_cons, Fcons): Likewise for total_free_conses.
1981 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1982 Likewise for total_free_vector_bytes.
1983 (Fmake_symbol): Likewise for total_free_symbols.
1984 (bytes_free): Remove.
1985
7098646f
DA
19862012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1987
1988 Simple free memory accounting feature.
1989 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1990 (sweep_vectors): Accumulate size of free vectors.
1991 (Fgarbage_collect): Setup bytes_free.
1992 (Fmemory_free): New function.
1993 (syms_of_alloc): Register it.
1994
22657b40
DA
19952012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1996
1997 Cleanup overlays checking.
1998 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1999 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
2000 eassert and OVERLAYP.
2001 (sort_overlays): Change to use OVERLAYP.
2002
ddfc8813
RK
20032012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
2004
2005 * editfns.c (Finsert_char): Make it interactive, and make the
2006 second arg optional. Copy interactive spec and docstring from
2007 ucs-insert.
2008
7c26cf3c
PE
20092012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
2012 Unlike the other wrapped functions, fabs has an unspecified
2013 effect on errno.
2014
5d127af9
JD
20152012-07-16 Jan Djärv <jan.h.d@swipnet.se>
2016
2017 * nsterm.m (keyDown): Interpret flags without left/right bits
2018 as the left key (Bug#11670).
2019
6a0dd1d7
DA
20202012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2021
2022 Remove empty and useless init functions.
2023 * lisp.h (init_character_once, init_fns, init_image)
2024 (init_filelock, init_sound): Remove prototype.
2025 * character.c (init_character_once): Remove.
2026 * filelock.c (init_filelock): Likewise.
2027 * fns.c (init_fns): Likewise.
2028 * image.c (init_image): Likewise.
2029 * sound.c (init_sound): Likewise.
2030 * emacs.c (main): Adjust accordingly.
2031
7a6136fd
DA
20322012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2033
2034 * gtkutil.h: Tiny cleanups.
2035 (use_old_gtk_file_dialog): Remove useless declaration.
2036 (xg_uses_old_file_dialog): Add suggested const attribute.
2037
ce811ad9
EZ
20382012-07-15 Eli Zaretskii <eliz@gnu.org>
2039
2040 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
2041 (bidi_paragraph_init): Use it to limit search forward for a strong
2042 directional character in abnormally large paragraphs full of
2043 neutral or weak characters. (Bug#11943)
2044
c9adfeaa
SF
20452012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
2046
2047 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
2048 the toolbar (Bug#9451).
2049 (xg_make_tool_item): Give the widget event box a transparent
2050 background.
2051
fff62aa9
DA
20522012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2053
2054 Cleanup basic allocation variables and functions.
2055 * alloc.c (ignore_warnings, init_intervals, init_float)
2056 (init_cons, init_symbol, init_marker): Remove.
2057 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
2058 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
2059 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
2060 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
2061 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
2062 (staticidx, init_alloc_once, init_strings, free_ablock):
2063 Remove redundant initialization.
2064 * fns.c (init_weak_hash_tables): Remove.
2065 * lisp.h (init_weak_hash_tables): Remove prototype.
2066
9730daca
DA
20672012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2068
2069 Use zero_vector where appropriate.
2070 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
2071 accordingly.
2072 * lisp.h (zero_vector): New declaration.
2073 * font.c (null_vector): Remove.
2074 (syms_of_font): Remove initialization and staticpro.
2075 (font_list_entities, font_find_for_lface): Change to use zero_vector.
2076 * keymap.c (Faccessible_keymaps): Likewise.
2077
2e2d2a13
LL
20782012-07-15 Leo Liu <sdl.web@gmail.com>
2079
2080 * fringe.c: Fix typo in comments.
2081
cd276f6e
LL
20822012-07-14 Leo Liu <sdl.web@gmail.com>
2083
2084 * fringe.c: Add a new bitmap exclamation-mark.
2085
5a1131d9
EZ
20862012-07-14 Eli Zaretskii <eliz@gnu.org>
2087
2088 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
2089
2090 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
2091 (HAVE_MENUS): Don't define, defined by editing config.in with
2092 msdos/sed2v2.inp.
2093 (GMALLOC_INHIBIT_VALLOC): Don't define.
2094 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
2095
22e983b7
JB
20962012-07-14 Juanma Barranquero <lekktu@gmail.com>
2097
2098 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
2099
5b3f250f
GM
21002012-07-14 Glenn Morris <rgm@gnu.org>
2101
2102 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
2103 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
2104 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
2105
33d63ff4
GM
21062012-07-13 Glenn Morris <rgm@gnu.org>
2107
5b633342
GM
2108 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
2109
33d63ff4
GM
2110 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
2111 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
2112
b55b9f85
JD
21132012-07-13 Jan Djärv <jan.h.d@swipnet.se>
2114
0dc8cf50
JD
2115 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
2116 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
2117 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
2118 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
2119 where appropriate.
2120 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
2121 as boolean expression.
2122 (x_set_window_size): Remove unused variable toolbar.
2123 (ns_get_color_default, ns_mod_to_lisp): Remove.
2124 (ns_mouse_position): Remove unused variables xchar and ychar.
2125 (ns_compute_glyph_string_overhangs): Remove unused variable face.
2126 (ns_set_vertical_scroll_bar): Remove unused variable count.
2127 (ns_delete_terminal): Remove unused variable i.
2128 (ns_term_init): Remove unused variables r, g and b.
2129 (mouseDown): Remove unused variable window.
2130 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
2131 (initFrameFromEmacs): Remove unused variable vbextra.
2132 (mouseEntered): Remove unused variables p and dpyinfo.
2133 (mouseExited): Remove unused variables p and r.
2134 (ns_define_frame_cursor, ns_clear_frame_area)
2135 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
2136 (menuDown): Assign [sender tag] to variable and cast the variable.
2137
2138 * nsterm.h (menuDown): Add id as type to argument sender.
2139 (ns_display_info_for_name): Add Lisp_Object argument.
2140 (ns_term_init): Add Lisp_Object argument.
2141 (ns_map_event_to_object): Add void argument.
2142 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
2143 prototype with arguments and only declare if __OBJC__.
2144 (nxatoms_of_nsselect): Add void argument.
2145 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
2146 (ns_alloc_autorelease_pool): Add void argument.
2147 (ns_release_autorelease_pool): Add void* argument.
2148 (ns_get_defaults_value): Add const char* argument.
2149
2150 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
2151 (initFromContents): Use SSDATA where appropriate.
2152 (ns_update_menubar): Add braces to ambigous if-else.
2153 (initWithTitle): Put () around assignment in if statement.
2154 (ns_menu_show): Remove unused variables window and keymap.
2155 (update_frame_tool_bar): Remove unused variable selected_p.
2156 (initWithContentRect): Remove unused variable this_cmd_name.
2157
2158 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
2159 appropriate.
2160 (setXBMColor): Remove unused variable len.
2161 (setPixmapData): Put () around assignment in loop statement.
2162
2163 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
2164 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
2165 where appropriate.
2166 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
2167 around assignment in loop statement.
2168 (nsfont_open): Remove unused variable i.
2169 (nsfont_open): Remove unused variable len.
2170 (nsfont_draw): Remove unused variable cs.
2171
2172 * nsfns.m (x_set_icon_name, ns_set_name_internal)
2173 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
2174 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
2175 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
2176 (Fns_font_name, Fns_perform_service)
2177 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
2178 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
2179 (ns_set_name): Remove unused variable view.
2180 (x_set_menu_bar_lines): Remove unused variable olines.
2181 (x_set_tool_bar_lines): Remove unused variable root_window.
2182 (Fns_list_colors): Put () around assignment in while statement.
2183 (Fns_perform_service): Remove unused variable len.
2184 (Fns_display_usable_bounds): Remove unused variable top.
2185 (syms_of_nsfns): Remove unused variable i.
2186
b55b9f85
JD
2187 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
2188 memcpy (Bug#11907).
2189
ed9265fc 21902012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
2191
2192 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
2193 and free it with DestroyExceptionInfo (Bug#11558).
2194
ef099b57
JB
21952012-07-13 Juanma Barranquero <lekktu@gmail.com>
2196
2197 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
2198 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
2199 Set here, not in nt/config.nt.
2200
ea814a5d
EZ
22012012-07-13 Eli Zaretskii <eliz@gnu.org>
2202
2203 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
2204 cursor overflow into the last glyph on display line when the right
2205 fringe is off. (Bug#11832)
2206
1a952767
PE
22072012-07-13 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 * xdisp.c (produce_special_glyphs): Now static.
2210 * dispextern.h (produce_special_glyphs): Remove decl.
2211
983188fd
GM
22122012-07-13 Glenn Morris <rgm@gnu.org>
2213
8d7c7eed 2214 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
2215 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
2216
983188fd
GM
2217 * s/usg5-4-common.h (USG, USG5):
2218 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
2219 * s/sol2-6.h (SOLARIS2):
2220 * s/irix6-5.h (IRIX6_5):
2221 * s/hpux10-20.h (USG, USG5, HPUX):
2222 * s/gnu-linux.h (USG, GNU_LINUX):
2223 * s/freebsd.h (BSD_SYSTEM):
2224 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
2225 * s/cygwin.h (CYGWIN):
2226 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
2227 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
2228
d1e68667 22292012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
2230
2231 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 2232
6de0e799
GM
22332012-07-13 Glenn Morris <rgm@gnu.org>
2234
739ae010
GM
2235 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
2236
dbee5793
GM
2237 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
2238
6de0e799
GM
2239 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
2240 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
2241
b82da769
GM
22422012-07-12 Glenn Morris <rgm@gnu.org>
2243
4fae5a7a 2244 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
2245
2246 * process.c (init_process_emacs): Rename from init_process.
2247 The old name is also the name of a Mach system call.
2248 * lisp.h, emacs.c: Update for this name change.
2249 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
2250 longer needed.
2251
5a979817
EZ
22522012-07-12 Eli Zaretskii <eliz@gnu.org>
2253
2254 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
2255 memmove call that removes glyphs covered by the left truncation
2256 glyph. Improve commentary.
2257 (display_line): Fix display of continuation glyphs on GUI frames
2258 when the right fringe is turned off and variable-size fonts are
2259 used in the window. Move the code that appends a stretch glyph to
2260 produce_special_glyphs, so that it could be used for truncation
2261 and continuation glyphs alike.
2262 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
2263 glyph of a suitably computed width, to align the special glyphs at
2264 the window margin. Code moved from display_line. (Bug#11832)
2265
3e91a053
GM
22662012-07-12 Glenn Morris <rgm@gnu.org>
2267
ba9e4b84
GM
2268 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
2269
2270 * s/gnu-linux.h, s/hpux10-20.h:
2271 Do not unconditionally define HAVE_XRMSETDATABASE.
2272
3e91a053
GM
2273 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
2274
b300b1f4
PE
22752012-07-12 Paul Eggert <eggert@cs.ucla.edu>
2276
2277 Fix typos that broke OS X build.
2278 Reported by Randal L. Schwartz in
2279 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
2280 * nsterm.m (ns_timeout): Add missing local decl.
2281 (ns_get_color): snprintf -> sprintf, to fix typo.
2282
6e777848
GM
22832012-07-12 Glenn Morris <rgm@gnu.org>
2284
3f922c37
GM
2285 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
2286 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
2287 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
2288 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
2289
0ab7b23a
GM
2290 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
2291 Move PTY_OPEN to configure.
2292
6e777848
GM
2293 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2294 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
2295 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
2296
4a7edc24
DA
22972012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
2298
2299 Use empty_unibyte_string where applicable.
2300 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
2301 * lread.c (read1): Likewise.
2302 * xsettings.c (syms_of_xsettings): Likewise.
2303
308aab79
GM
23042012-07-12 Glenn Morris <rgm@gnu.org>
2305
42bd1719
GM
2306 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
2307 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
2308 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
2309 * s/hpux10-20.h (RUN_TIME_REMAP):
2310 * s/bsd-common.h (TABDLY): Move to configure.
2311
2312 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
2313
2314 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
2315
ea0bbd17 2316 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 2317 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
2318
2319 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 2320
308aab79
GM
2321 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
2322 * s/template.h: Move NARROWPROTO to configure.
2323
ee1cf5cf
GM
23242012-07-11 Glenn Morris <rgm@gnu.org>
2325
30fe9bf4
GM
2326 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
2327 unused since 2011-01-17 change to systty.h.
2328
ee1cf5cf
GM
2329 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
2330 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2331 Move HAVE_PTYS and HAVE_SOCKETS to configure.
2332
63e47e07
PE
23332012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2334
2335 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
2336
c43fb4c3
GM
23372012-07-11 Glenn Morris <rgm@gnu.org>
2338
2339 * s/darwin.h, s/gnu-linux.h, s/template.h:
2340 Move INTERRUPT_INPUT to configure.
2341
e8df9267
DA
23422012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2343
2344 Minor adjustments to interning code.
2345 * lisp.h (intern, intern_c_string): Redefine as static inline
2346 wrappers for intern_1 and intern_c_string_1, respectively.
2347 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
2348 * lread.c (intern_1, intern_c_string_1, oblookup):
2349 Simplify Vobarray checking.
e8df9267
DA
2350 * font.c (font_intern_prop): Likewise. Adjust comment.
2351 * w32font.c (intern_font_name): Likewise.
2352
34348bd4
AS
23532012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2354
d96a1e0c
AS
2355 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
2356
34348bd4
AS
2357 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
2358 of Fcar/Fcdr if possible.
2359 * font.c (check_otf_features): Likewise.
2360 * fontset.c (Fnew_fontset): Likewise.
2361 * gnutls.c (Fgnutls_boot): Likewise.
2362 * minibuf.c (read_minibuf): Likewise.
2363 * msdos.c (IT_set_frame_parameters): Likewise.
2364 * xmenu.c (Fx_popup_dialog): Likewise.
2365 * w32menu.c (Fx_popup_dialog): Likewise.
2366
c8add24e
GM
23672012-07-11 Glenn Morris <rgm@gnu.org>
2368
4b575b3c
GM
2369 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
2370 since nothing has defined it on these platforms.
2371
09f4e3b0
GM
2372 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
2373 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
2374
172bedef
GM
2375 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2376 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2377 Move CLASH_DETECTION to configure.
2378
249685df
GM
2379 * s/gnu.h: Remove file, which is now empty.
2380
c8add24e
GM
2381 * s/gnu.h, s/gnu-linux.h:
2382 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
2383
b41253a3
JW
23842012-07-11 John Wiegley <johnw@newartisans.com>
2385
2386 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
2387 function attribute, so we only use it if it exists in the
2388 compiler.
2389
d923b542
DA
23902012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2391
2392 Avoid call to strlen in fast_c_string_match_ignore_case.
2393 * search.c (fast_c_string_match_ignore_case): Change to use
2394 length argument. Adjust users accordingly.
2395 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
2396
5ebbef1d
PE
23972012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2398
bb352260
PE
2399 Assume mkdir, rmdir.
2400 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2401 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2402
57054ddd
PE
2403 Assume rename.
2404 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2405
b747d3f7
PE
2406 Assume perror.
2407 * s/hpux10-20.h (HAVE_PERROR): Remove.
2408 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2409 Remove dummy definition, as this problem was obsolete long ago.
2410
5ebbef1d
PE
2411 Assume strerror.
2412 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2413
984e7f30
DA
24142012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2415
2416 Avoid calls to strlen in font processing functions.
2417 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2418 (font_open_by_name): Change to use length argument.
2419 Adjust users accordingly.
d923b542
DA
2420 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2421 Adjust prototypes.
2422 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2423 Change to return ptrdiff_t.
984e7f30
DA
2424 (xfont_list_pattern, xfont_match): Use length returned by
2425 xfont_decode_coding_xlfd.
2426 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2427
20e94fdd
GM
24282012-07-11 Glenn Morris <rgm@gnu.org>
2429
9d596af3
GM
2430 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2431 Move DONT_REOPEN_PTY to configure.
2432
20e94fdd
GM
2433 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2434 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2435
e99a530f
PE
24362012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2437
22ffb973
PE
2438 Remove "#define unix" that is no longer needed (Bug#11905).
2439 * s/aix4-2.h (unix): Remove; no longer needed.
2440
e9a9ae03
PE
2441 EMACS_TIME simplification (Bug#11875).
2442 This replaces macros (which typically do not work in GDB)
2443 with functions, typedefs and enums, making the code easier to debug.
2444 The functional style also makes code easier to read and maintain.
2445 * systime.h: Include <sys/time.h> on all hosts, not just if
2446 WINDOWSNT, since 'struct timeval' is needed in general.
2447 (EMACS_TIME): Now a typedef, not a macro.
2448 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2449 not macros.
2450 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2451 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2452 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2453 (EMACS_TIME_LE): Now functions, not macros.
2454 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2455 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2456 which are not functions. All uses rewritten to use:
2457 (make_emacs_time): New function.
2458 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2459 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2460 not functions. All uses rewritten to use the following, respectively:
2461 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2462 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2463 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2464 * fileio.c (Fcopy_file):
2465 * xterm.c (XTflash): Get the current time closer to when it's used.
2466 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2467
ffacb126
PE
2468 * bytecode.c (targets): Suppress -Woverride-init warnings.
2469
e99a530f
PE
2470 Simplify by avoiding confusing use of strncpy etc.
2471 * doc.c (Fsnarf_documentation):
2472 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2473 * frame.c (Fmake_terminal_frame):
2474 * gtkutil.c (get_utf8_string):
2475 * lread.c (openp):
2476 * nsmenu.m (ns_update_menubar):
2477 * regex.c (regerror):
2478 Prefer memcpy to strncpy and strncat when either will do.
2479 * fileio.c (Fsubstitute_in_file_name):
2480 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2481 (menu_separator_name_p):
2482 * nsmenu.m (ns_update_menubar):
2483 Prefer memcmp to strncmp when either will do.
2484 * nsterm.m: Include <ftoastr.h>.
2485 (ns_get_color):
2486 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2487 Prefer snprintf to strncpy.
2488 * nsterm.m (ns_term_init):
2489 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2490 * nsterm.m (ns_term_init):
2491 Avoid the need for strncpy, by using build_string or
2492 make_unibyte_string directly. Use dtoastr, not snprintf.
2493 * process.c (Fmake_network_process): Diagnose service names that
2494 are too long, rather than silently truncating them or creating
2495 non-null-terminated names.
2496 (Fnetwork_interface_info): Likewise, for interface names.
2497 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2498 Prefer sprintf to strncat.
2499 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2500 Prefer vsnprintf to vsprintf + strncpy.
2501
c59592b3
GM
25022012-07-10 Glenn Morris <rgm@gnu.org>
2503
2504 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2505 Clarify fallback case.
2506
7d7bbefd
DA
25072012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2508
2509 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2510 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2511 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2512 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2513 where argument type is known to be a Lisp_Cons.
2514
3a4c8000
TT
25152012-07-10 Tom Tromey <tromey@redhat.com>
2516
2517 * bytecode.c (BYTE_CODE_THREADED): New macro.
2518 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2519 (enum byte_code_op): New type.
2520 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2521 (exec_byte_code): Use them. Use token threading when applicable.
2522
2a0213a6
DA
25232012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2524
2525 Optimize pure C strings initialization.
2526 * lisp.h (make_pure_string): Fix prototype.
2527 (build_pure_c_string): New function, defined as static inline. This
2528 provides a better opportunity to optimize away calls to strlen when
2529 the function is called with compile-time constant argument.
2530 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2531 argument, adjust users accordingly. Use build_pure_c_string where
2532 appropriate.
2533 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2534 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2535 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2536
cb1caeaf
DA
25372012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2538
2539 Avoid calls to strlen in miscellaneous functions.
2540 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2541 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2542 * lread.c (openp): Likewise.
2543
c293e30c
DA
25442012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2545
2546 Avoid calls to strlen in path processing functions.
2547 * fileio.c (file_name_as_directory): Add comment. Change to add
2548 srclen argument and return the length of result. Adjust users
2549 accordingly.
2550 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2551 swap 1st and 2nd arguments to obey the common convention.
2552 Adjust users accordingly.
c293e30c
DA
2553 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2554
9e059e3f
GM
25552012-07-10 Glenn Morris <rgm@gnu.org>
2556
d02eb359
GM
2557 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2558 Move PENDING_OUTPUT_COUNT definition to configure.
2559
882cf227
GM
2560 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2561 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2562 * s/gnu.h (DATA_START): Move definitions to configure.
2563
af6e839f
GM
2564 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2565 We include usg5-4-common.h, which defines them both.
2566
40289a12
GM
2567 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2568 O_RDONLY already includes it).
2569
9e059e3f
GM
2570 Stop ns builds setting the EMACSLOADPATH environment variable.
2571 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2572 Now it does not set EMACSLOADPATH, just returns the load-path string.
2573 * nsterm.h: Update accordingly.
2574 * lread.c [HAVE_NS]: Include nsterm.h.
2575 (init_lread) [HAVE_NS]: Use ns_load_path.
2576 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2577
7c4e8ec0
GM
25782012-07-09 Glenn Morris <rgm@gnu.org>
2579
d4f600ff
GM
2580 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2581 since the included bsd-common.h does so.
2582
cbb31951
GM
2583 Stop ns builds setting the EMACSPATH environment variable.
2584 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2585 (ns_init_paths): Do not set EMACSPATH.
2586 * nsterm.h (ns_exec_path): Add it.
2587 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2588 Use ns_exec_path.
2589
7c4e8ec0
GM
2590 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2591
26bccfae
PE
25922012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2593
a0bee46f
PE
2594 * process.c (wait_reading_process_output): 'waitchannels' was unset
2595 when read_kbd || !NILP (wait_for_cell); fix this.
2596
5994c183
PE
2597 Add GCC-style 'const' attribute to functions that can use it.
2598 * character.h (char_resolve_modifier_mask):
2599 * keyboard.h (make_ctrl_char):
2600 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2601 (init_character_once, next_almost_prime, init_fns, init_image)
2602 (flush_pending_output, init_sound):
2603 * mem-limits.h (start_of_data):
2604 * menu.h (finish_menu_items):
2605 Add ATTRIBUTE_CONST.
2606 * emacs.c (DEFINE_DUMMY_FUNCTION):
2607 Declare the dummy function with ATTRIBUTE_CONST.
2608 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2609 Add decls with ATTRIBUTE_CONST.
2610
26bccfae
PE
2611 Minor improvements to make_formatted_string.
2612 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2613 where int is good enough, as vsprintf returns an int.
2614 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2615
a8290ec3
DA
26162012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2617
2618 Use make_formatted_string to avoid double length calculation.
2619 * lisp.h (make_formatted_string): New prototype.
2620 * alloc.c (make_formatted_string): New function.
2621 * buffer.c (Fgenerate_new_buffer_name): Use it.
2622 * dbus.c (syms_of_dbusbind): Likewise.
2623 * editfns.c (Fcurrent_time_zone): Likewise.
2624 * filelock.c (get_boot_time): Likewise.
2625 * frame.c (make_terminal_frame, set_term_frame_name)
2626 (x_report_frame_params): Likewise.
2627 * image.c (gs_load): Likewise.
2628 * minibuf.c (get_minibuffer): Likewise.
2629 * msdos.c (dos_set_window_size): Likewise.
2630 * process.c (make_process): Likewise.
2631 * xdisp.c (ensure_echo_area_buffers): Likewise.
2632 * xsettings.c (apply_xft_settings): Likewise.
2633
d01ba2f1
GM
26342012-07-09 Glenn Morris <rgm@gnu.org>
2635
2636 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2637 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2638 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2639 * nsterm.h (ns_etc_directory): Add it.
2640 * callproc.c [HAVE_NS]: Include nsterm.h.
2641 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2642
f1f924b6
DA
26432012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2644
2645 Move marker debugging code under MARKER_DEBUG.
2646 * marker.c (MARKER_DEBUG): Move marker debugging code under
2647 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2648 for bootstrap with --enable-checking (~3x slowdown reported
2649 by Juanma Barranquero <lekktu@gmail.com>).
2650 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2651
ab531b66
PE
26522012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2653
2654 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2655 See <http://bugs.gnu.org/11825#29>.
2656
c4b3bc8a
EZ
26572012-07-08 Eli Zaretskii <eliz@gnu.org>
2658
2659 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2660 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2661 (display_line): Add commentary about displaying truncation glyphs
2662 on GUI frames.
2663 (produce_special_glyphs): Move here from term.c.
2664
2665 * term.c (produce_special_glyphs): Move to xdisp.c.
2666
2667 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2668 section.
c4b3bc8a 2669
b676b881
AS
26702012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2671
f17c5273
AS
2672 * xdisp.c (display_line): Avoid warning about implicit declaration
2673 of FRAME_FONT.
2674
298819b9
AS
2675 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2676
b676b881
AS
2677 * lisp.h: Remove empty conditional.
2678
6045c4fd
PE
26792012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2680
b3350bf9
PE
2681 * lread.c (load_path_check): Now static.
2682
6045c4fd
PE
2683 Fix some minor --with-ns problems found by static checking.
2684 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2685 (x_set_font) [!HAVE_X_WINDOWS]:
2686 * image.c (xpm_load_image) [HAVE_NS]:
2687 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2688 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2689 Remove unused local.
2690 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2691 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2692 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2693 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2694 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2695 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2696 Fix pointer signedness problem.
2697 * xfaces.c (FRAME_X_FONT_TABLE):
2698 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2699
929e7845
GM
27002012-07-07 Glenn Morris <rgm@gnu.org>
2701
2702 * lread.c (load_path_check): New function, split from init_lread.
2703 (init_lread): Reorganize. Motivation:
2704 If EMACSLOADPATH is set, check/warn about that rather than the
2705 defaults, which we are not going to use. Hence we can remove
2706 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2707 Don't warn if site-lisp directories are missing.
2708 If not installed, start from a blank load-path, since
2709 PATH_LOADSEARCH refers to the eventual installation directories.
2710
58dd0aa4
EZ
27112012-07-07 Eli Zaretskii <eliz@gnu.org>
2712
2713 Support truncation and continuation glyphs on GUI frames, when
2714 fringes are disabled. (Bug#11832)
2715 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2716 continuation glyphs even if on GUI frames.
2717 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2718 or both, are absent.
2719 (start_display, move_it_in_display_line_to): Handle the case of a
2720 GUI frame without a fringe to display continuation or truncation
2721 glyphs.
2722 (insert_left_trunc_glyphs): Support GUI frames: make sure
2723 truncation glyphs overwrite enough glyphs from the current line to
2724 have sufficient space in pixels.
2725 (display_line): Support truncation and continuation glyphs on GUI
2726 frames. If some spare pixels are left on the line after inserting
2727 the truncation glyphs, fill that space with a stretch glyph of a
2728 suitably computed width.
2729
2730 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2731 produce_glyphs, to support GUI sessions.
2732
31571fd7
PE
27332012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2734
5a16b9bc
PE
2735 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2736
f3047c75
PE
2737 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2738
31571fd7
PE
2739 Do not require float-time's arg to fit in time_t (Bug#11825).
2740 This works better on hosts where time_t is unsigned, and where
2741 float-time is applied to the (negative) difference between two times.
2742 * editfns.c (decode_time_components): Last arg is now double *,
2743 not int *, and means to store all the result as a double, without
2744 worrying about whether the seconds part fits in time_t.
2745 All callers changed.
2746 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2747 All callers changed.
2748 (Ffloat_time): Do not fail merely because the specified time falls
2749 outside of time_t range.
2750
4516fbef
GM
27512012-07-07 Glenn Morris <rgm@gnu.org>
2752
2753 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2754 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2755 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2756
07adc2c6
JB
27572012-07-07 Juanma Barranquero <lekktu@gmail.com>
2758
2759 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2760 Update dependencies.
2761
2762 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2763
fd573f31
PE
27642012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2765
fee5959d
PE
2766 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2767 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2768 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2769 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2770 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2771 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2772
fd573f31
PE
2773 * xfont.c (compare_font_names): Redo to omit the need for casts.
2774
ddadbc0e
AS
27752012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2776
fca8d6b6
AS
2777 * xfns.c (Fx_change_window_property): Doc fix.
2778 * w32fns.c (Fx_change_window_property): Doc fix.
2779
ddadbc0e
AS
2780 * w32fns.c (Fx_window_property): Accept the same arguments as the
2781 X Windows version. Doc fix.
2782 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2783
ed9265fc 27842012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2785 Eli Zaretskii <eliz@gnu.org>
2786
2787 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2788 Windows-specific code from nt/config.nt moved here.
2789 Obsolete settings removed.
2790
216ee680
PE
27912012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 * process.c: Avoid unnecessary calls to gettime.
2794 (wait_reading_process_output): Don't get the time of day
2795 when gobbling data immediately and not waiting, as there's no need
2796 for it in that case. This removes a FIXME.
2797
bdd091e4
JD
27982012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2799
2800 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2801 is defined (Bug#11768).
2802
9d44f8ce
DA
28032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2804
2805 Fix marker debugging code.
2806 * marker.c (byte_char_debug_check): Do not perform the check
2807 if buffer is not multibyte.
090bd7cb
JB
2808 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2809 Call byte_char_debug_check with correct arguments.
9d44f8ce 2810
90fc4786
DA
28112012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2812
2813 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2814 * marker.c (byte_char_debug_check, count_markers):
2815 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2816 (byte_debug_flag): Remove.
2817 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2818 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2819
7b7ae965
DA
28202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2821
4e57b342
DA
2822 Avoid code repetition in marker-related functions.
2823 * marker.c (attach_marker): New function.
2824 (Fset_marker, set_marker_restricted, set_marker_both)
2825 (set_marker_restricted_both): Use it.
2826 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2827 Consistently rename charno to charpos.
2828 (marker_position): Add eassert.
2829 (marker_byte_position): Convert to eassert.
2830
28312012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2832
2833 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2834 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2835 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2836
657924ff
DA
28372012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2838
2839 Introduce fast path for the widely used marker operation.
2840 * alloc.c (build_marker): New function.
2841 * lisp.h (build_marker): New prototype.
2842 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2843 * composite.c (autocmp_chars): Likewise.
2844 * editfns.c (buildmark): Remove.
2845 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2846 (save_restriction_save): Use build_marker.
2847 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2848 * window.c (save_window_save): Likewise.
2849
041a49a6
DA
28502012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2851
2852 Do not use Fdelete_overlay in delete_all_overlays
2853 to avoid redundant calls to unchain_overlay.
2854 * buffer.c (drop_overlay): New function.
2855 (delete_all_overlays, Fdelete_overlay): Use it.
2856 * minibuf.c (get_minibuffer): Fix comment.
2857
7dca65a4
PE
28582012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2859
2860 Port to OpenBSD 5.1 amd64.
2861 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2862 This is needed for OpenBSD, and should be harmless on all BSD systems.
2863 Also, include <sys/sysctl.h>, as it should be available on all
2864 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2865 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2866 use p_pid member, not kp_proc.pid.
2867
8eb876e2
GM
28682012-07-06 Glenn Morris <rgm@gnu.org>
2869
2870 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2871
38182d90
PE
28722012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2873
2874 More xmalloc and related cleanup.
2875 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2876 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2877 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2878 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2879 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2880 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2881 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2882 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2883 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2884 * xterm.c:
2885 Omit needless casts involving void * pointers and allocation.
2886 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2887 as the former is more robust if P's type is changed.
2888 Prefer xzalloc to xmalloc + memset 0.
2889 Simplify malloc-or-realloc to realloc.
2890 Don't worry about xmalloc returning a null pointer.
2891 Prefer xstrdup to xmalloc + strcpy.
2892 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2893 growing it.
2894 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2895 alloca of a constant.
2896
6dd5a677
EZ
28972012-07-05 Eli Zaretskii <eliz@gnu.org>
2898
2899 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2900 hscroll is larger than the line width. Fixes long and futile
2901 looping inside extend_face_to_end_of_line (on a TTY) producing
2902 glyphs that are not needed and thrown away.
2903
6b312f0f
DA
29042012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2905
2906 * marker.c (set_marker_restricted_both): Simplify by using
2907 clip_to_bounds.
2908
f520ef9b
PE
29092012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2910
2911 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2912
383b7c95
JD
29132012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2914
2915 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2916 not defined (Bug#11768).
2917 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2918 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2919 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2920 followed by gtk_box_set_homogeneous (Bug#11768).
2921 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2922 (update_theme_scrollbar_width, xg_create_scroll_bar):
2923 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2924 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2925 (is_box_type): New function (Bug#11768).
2926 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2927 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2928 with default display (Bug#11768).
2929
d6e7bf45
EZ
29302012-07-05 Eli Zaretskii <eliz@gnu.org>
2931
2932 * xdisp.c (window_hscroll_limited): New function.
2933 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2934 coordinates when window's hscroll is set to insanely large
2935 values. (Bug#11857)
2936
431391ec
JB
29372012-07-05 Juanma Barranquero <lekktu@gmail.com>
2938
2939 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2940 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2941
23f86fce
DA
29422012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2943
2944 Cleanup xmalloc.
2945 * lisp.h (xzalloc): New prototype. Omit needless casts.
2946 * alloc.c (xzalloc): New function. Omit needless casts.
2947 * charset.c: Omit needless casts. Convert all calls to
2948 xmalloc with following memset to xzalloc.
2949 * dispnew.c: Likewise.
2950 * fringe.c: Likewise.
2951 * image.c: Likewise.
2952 * sound.c: Likewise.
2953 * term.c: Likewise.
2954 * w32fns.c: Likewise.
2955 * w32font.c: Likewise.
2956 * w32term.c: Likewise.
2957 * xfaces.c: Likewise.
2958 * xfns.c: Likewise.
2959 * xterm.c: Likewise.
2960 * atimer.c: Omit needless casts.
2961 * buffer.c: Likewise.
2962 * callproc.c: Likewise.
2963 * ccl.c: Likewise.
2964 * coding.c: Likewise.
2965 * composite.c: Likewise.
2966 * doc.c: Likewise.
2967 * doprnt.c: Likewise.
2968 * editfns.c: Likewise.
2969 * emacs.c: Likewise.
2970 * eval.c: Likewise.
2971 * filelock.c: Likewise.
2972 * fns.c: Likewise.
2973 * gtkutil.c: Likewise.
2974 * keyboard.c: Likewise.
2975 * lisp.h: Likewise.
2976 * lread.c: Likewise.
2977 * minibuf.c: Likewise.
2978 * msdos.c: Likewise.
2979 * print.c: Likewise.
2980 * process.c: Likewise.
2981 * region-cache.c: Likewise.
2982 * search.c: Likewise.
2983 * sysdep.c: Likewise.
2984 * termcap.c: Likewise.
2985 * terminal.c: Likewise.
2986 * tparam.c: Likewise.
2987 * w16select.c: Likewise.
2988 * w32.c: Likewise.
2989 * w32reg.c: Likewise.
2990 * w32select.c: Likewise.
2991 * w32uniscribe.c: Likewise.
2992 * widget.c: Likewise.
2993 * xdisp.c: Likewise.
2994 * xmenu.c: Likewise.
2995 * xrdb.c: Likewise.
2996 * xselect.c: Likewise.
2997
0497dc44
PE
29982012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2999
3000 * fileio.c (time_error_value): Check the right error number.
3001 Problem reported by Troels Nielsen in
3002 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
3003
356e7178
PE
30042012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3005
4e71fd89
PE
3006 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
3007 This should be fixed in a better way; see Eli Zaretskii in
3008 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
3009 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
3010
f0941253
PE
3011 * fileio.c (time_error_value): Rename from special_mtime.
3012 The old name's problems were noted by Eli Zaretskii in
3013 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
3014
065c9eb4
PE
3015 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
3016 This variable's comment says Emacs needs at least one GDB-visible
3017 symbol of type enum pvec_type, to work around GDB problems.
3018 The symbol's value doesn't matter.
3019
356e7178
PE
3020 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
3021 that causes compilation to fail on pre-C99 compilers.
3022
ed9265fc 30232012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
3024
3025 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
3026 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
3027
3884d954
DA
30282012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3029
d209e2fb 3030 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
3031 headers for buffer_defaults and buffer_local_symbols.
3032 Reported by Juanma Barranquero <lekktu@gmail.com>.
3033
ee28be33
SM
30342012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3035
3036 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
3037 * lisp.h (enum pvec_type): Use fewer bits.
3038 (PSEUDOVECTOR_SIZE_BITS): New constant.
3039 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
3040 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
3041 change in pvec_type.
3042 (PSEUDOVECTOR_TYPEP): New macro.
3043 (TYPED_PSEUDOVECTORP): Use it.
3044 * fns.c (internal_equal): Adapt code to extract pvectype.
3045 * emacs.c (gdb_pvec_type): Update type.
3046 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
3047 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
3048 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
3049 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
3050 (sweep_vectors): Use it. Use local var `total_bytes' instead of
3051 abusing vector->header.next.nbytes.
3052 (live_vector_p): Use PVEC_TYPE.
3053 (mark_object): Adapt code to extract pvectype. Use switch.
3054
c7f2cd7f
PE
30552012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3056
3057 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
3058 Tighten new eassert a bit.
3059
8ce70ed2
DA
30602012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3061
3062 Fix compilation with --enable-gcc-warnings and -O1
3063 optimization level.
3064 * doprnt.c (doprnt): Change type of tem to int, initialize
3065 to avoid compiler warning. Add eassert.
3066 * search.c (simple_search): Initialize match_byte to avoid
3067 compiler warning. Add eassert.
3068
dea7f1e5
PE
30692012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3070
24a212eb
PE
3071 Avoid weird behavior with large horizontal scrolls.
3072 Without this change, for example, large hscroll values would
3073 mess up Emacs's display on Fedora 15 x86, presumably due to
3074 overflows in int calculations in the display code.
3075 Also, if buffers had long lines, Emacs would freeze.
3076 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
3077 (set_window_hscroll): New function, containing the old guts of
3078 Fset_window_hscroll. Return the clipped value.
3079 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
3080 This avoids the need to check against PTRDIFF_MAX.
3081
dea7f1e5
PE
3082 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
3083
76046526
DA
30842012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3085
3086 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
3087
39adff0d
PE
30882012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3089
63807d47
PE
3090 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
3091 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
3092 since GCC 4.4.6 issues a bogus warning for them.
3093
39adff0d
PE
3094 Fix bugs in file timestamp newness comparisons.
3095 * fileio.c (Ffile_newer_than_file_p):
3096 * lread.c (Fload): Use full timestamp resolution of files,
3097 not just the 1-second resolution, so that files that are only
3098 slightly newer still count as newer.
3099 * fileio.c (Ffile_newer_than_file_p): Don't assume file
3100 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
3101
dbeed9a6
PE
31022012-07-03 Paul Eggert <eggert@cs.ucla.edu>
3103
3104 * fileio.c: Improve handling of file time marker. (Bug#11852)
3105 (special_mtime): New function.
3106 (Finsert_file_contents, Fverify_visited_file_modtime):
3107 Use it to set special mtime values consistently.
3108
636334d6
AS
31092012-07-03 Andreas Schwab <schwab@linux-m68k.org>
3110
3111 * fileio.c (Finsert_file_contents): Properly handle st_mtime
3112 marker for non-existing file. (Bug#11852)
3113
e2017fe2
GM
31142012-07-03 Glenn Morris <rgm@gnu.org>
3115
3116 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
3117 and did not make it into globals.h).
3118
404dbd37
TT
31192012-07-03 Tom Tromey <tromey@redhat.com>
3120
3121 * window.c (Fset_window_margins, Fset_window_fringes)
3122 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
3123 * textprop.c (Fprevious_property_change): No longer static.
3124 * syntax.c (Fsyntax_table_p): No longer static.
3125 * process.c (Fget_process, Fprocess_datagram_address): No longer
3126 static.
3127 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
3128 * keyboard.c (Fcommand_execute): No longer static.
3129 Remove EXFUN.
3130 * insdel.c (Fcombine_after_change_execute): No longer static.
3131 * image.c (Finit_image_library): No longer static.
3132 * fileio.c (Fmake_symbolic_link): No longer static.
3133 * eval.c (Ffetch_bytecode): No longer static.
3134 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
3135 * doc.c (Fdocumentation_property, Fsnarf_documentation):
3136 No longer static.
404dbd37
TT
3137 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
3138 static.
3139 * dired.c (Ffile_attributes): No longer static.
3140 * composite.c (Fcomposition_get_gstring): No longer static.
3141 * callproc.c (Fgetenv_internal): No longer static.
3142
3143 * ccl.h: Remove EXFUNs.
3144 * buffer.h: Remove EXFUNs.
3145 * dispextern.h: Remove EXFUNs.
3146 * intervals.h: Remove EXFUNs.
3147 * fontset.h: Remove EXFUN.
3148 * font.h: Remove EXFUNs.
3149 * dosfns.c (system_process_attributes): Remove EXFUN.
3150 * keymap.h: Remove EXFUNs.
3151 * lisp.h: Remove EXFUNs.
3152 * w32term.h: Remove EXFUNs.
3153 * window.h: Remove EXFUNs.
3154 * xsettings.h: Remove EXFUN.
3155 * xterm.h: Remove EXFUN.
3156
8e4fd1e1
GM
31572012-07-03 Glenn Morris <rgm@gnu.org>
3158
3159 * lisp.h (Frandom): Make it visible to C.
3160 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
3161 buffer for invisible buffers. (Bug#1229)
3162
ca95b3eb
DA
31632012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3164
3165 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
3166 values which aren't power of 2.
14ae4239
BT
3167 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
3168 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
3169 accordingly.
3170
7555c33f
SM
31712012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
3172
3173 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
3174
3175 * alloc.c (mark_object): Revert part of last patch to use `switch'.
3176
d12e8f5a
DA
31772012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3178
3179 * alloc.c (allocate_vector_block): Remove redundant
3180 calls to mallopt if DOUG_LEA_MALLOC is defined.
3181 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
3182 avoid calls to mallopt if zero_vector is returned.
3183
296094c3
DA
31842012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3185
3186 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
3187 is enabled, avoid dereferencing NULL current_sblock if
3188 running undumped.
3189
36429c89
DA
31902012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3191
3192 Cleanup basic buffer management.
3193 * buffer.h (struct buffer): Change layout to use generic vector
3194 marking code. Fix some comments. Change type of 'clip_changed'
3195 to bitfield. Remove unused #ifndef old.
3196 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
3197 (GET_OVERLAYS_AT): Fix indentation.
3198 (for_each_per_buffer_object_at): New macro.
3199 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
3200 (Fbuffer_local_variables): Use it.
3201 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
3202 * alloc.c (allocate_buffer): Adjust to match new layout of
3203 struct buffer. Fix comment.
3204 (mark_overlay): New function.
3205 (mark_buffer): Use it. Use mark_vectorlike to mark normal
3206 Lisp area of struct buffer.
3207 (mark_object): Use it. Adjust marking of misc objects
3208 and related comments.
3209
3b3e4cac
PE
32102012-07-02 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
3213 wrapper that is not needed because the wrapped code is a no-op (zero
3214 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
3215 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
3216
cf5c0175
DA
32172012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
3218
3219 * alloc.c (mark_buffer): Simplify. Remove prototype.
3220 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 3221 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
3222 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
3223 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 3224
ca26824c
GM
32252012-06-30 Glenn Morris <rgm@gnu.org>
3226
2e4c5312
GM
3227 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
3228
ca26824c
GM
3229 * epaths.in (PATH_SITELOADSEARCH): New.
3230 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
3231 This is rather than relying on --enable-locallisppath elements
3232 having "site-lisp" in their names. (Bug#10208#25, 11658)
3233
0d23c240
EZ
32342012-06-30 Eli Zaretskii <eliz@gnu.org>
3235
c9240d7a
EZ
3236 * w32proc.c (sys_select): Accept and ignore one more argument.
3237
3238 * w32.c (emacs_gnutls_pull): Call select with one more argument.
3239
0d23c240 3240 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 3241 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
3242
3243 * sysdep.c: Don't include dos.h and dosfns.h.
3244
3245 * process.c (sys_select):
3246 * msdos.c (sys_select): Accept one more argument and ignore it.
3247
3248 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
3249 adapt data types and code to that.
3250
3251 * dosfns.c:
3252 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
3253 which clashes with the gnulib function of the same name.
3254
af5a5a98
AS
32552012-06-30 Andreas Schwab <schwab@linux-m68k.org>
3256
c5e4379c
AS
3257 * font.c (font_style_to_value, font_style_symbolic)
3258 (font_prop_validate_style): Add type checks for values in
3259 font_style_table.
3260
af5a5a98
AS
3261 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
3262 argument.
3263 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
3264 uses.
3265
8d38f461
EZ
32662012-06-29 Eli Zaretskii <eliz@gnu.org>
3267
2e5a6631
EZ
3268 * xdisp.c (try_window_id): Undo last change.
3269
8d38f461
EZ
3270 * w32.c (getwd): Adjust commentary about startup_dir.
3271 (init_environment): Always call sys_access, even in non-MSVC
3272 builds. Don't chdir to the directory of the Emacs executable.
3273 This undoes code from 1997 which was justified by the need to
3274 "avoid conflicts when removing and renaming directories". But its
3275 downside was that every relative file name was being interpreted
3276 relative to the directory of the Emacs executable, which can never
3277 be TRT. In particular, it broke sys_access when called with
3278 relative file names.
3279 (sys_access): Map GetLastError to errno.
3280
2af3565e
DA
32812012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3282
3283 * window.h (struct window): Change type of 'fringes_outside_margins'
3284 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 3285 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
3286 Adjust comment.
3287 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
3288 to ptrdiff_t.
3289
c8d3a25c 32902012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 3291
c8d3a25c
GM
3292 * gnutls.c (emacs_gnutls_handshake):
3293 Add QUIT to make the loop interruptible.
57570cd3 3294
c8d3a25c 32952012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 3296
c8d3a25c
GM
3297 * charset.c (init_charset): Make lack of etc/charsets fatal.
3298
3e984ee8
DA
32992012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3300
3301 * editfns.c (region_limit): Fix type mismatch.
3302
ef884f23
DA
33032012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3304
3305 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
3306 undefined. Convert from xassert to eassert.
3307 * nsmenu.m: Convert from xassert to eassert.
3308 * nsterm.m: Likewise.
3309
7d7e0027
SM
33102012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
3311
3312 * editfns.c (region_limit): Clip to narrowing (bug#11770).
3313
aa754e6a
PE
33142012-06-28 Paul Eggert <eggert@cs.ucla.edu>
3315
3316 Avoid integer overflow on scroll-left and scroll-right.
3317 * window.c (HSCROLL_MAX): New macro.
3318 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
3319 overflow when requested scroll falls outside ptrdiff_t range.
3320
80b00b08
DA
33212012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3322
3323 * window.h (struct window): Change type of 'hscroll',
3324 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
3325 'last_modified' and 'last_overlay_modified' to EMACS_INT.
3326 Adjust users accordingly.
3327 * xdisp.c (try_cursor_movement): Replace type check with eassert.
3328 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
3329 from EMACS_INT to ptrdiff_t.
3330 (make_window): Omit redundant initialization.
3331
62b2bcf6
JB
33322012-06-28 Juanma Barranquero <lekktu@gmail.com>
3333
3334 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
3335
45942c7d
DA
33362012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3337
3338 * window.h (struct window): Change type of 'use_time' and
3339 'sequence_number' from Lisp_Object to int.
3340 * frame.c (make_frame): Adjust users accordingly.
3341 * print.c (print_object): Likewise.
3342 * window.c (select_window, Fwindow_use_time, make_parent_window)
3343 (make_window): Likewise.
3344
e509cfa6
DA
33452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3346
3347 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
3348 enabled with --enable-checking=[all,glyphs] configure option.
3349 Fix GLYPH_DEBUG usage assuming that it may be undefined,
3350 adjust comments accordingly.
3351 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
3352 undefined, adjust comments accordingly.
3353 * image.c: Likewise.
3354 * scroll.c: Likewise.
3355 * w32fns.c: Likewise.
3356 * w32term.c: Likewise.
3357 * xdisp.c: Likewise.
3358 * xfaces.c: Likewise.
3359 * xfns.c: Likewise.
3360 * xterm.c: Likewise.
3361
a54e2c05
DA
33622012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3363
3364 Generalize run-time debugging checks.
3365 * dispextern.h (XASSERTS): Remove.
3366 * fontset.c (xassert): Remove.
3367 Convert from xassert to eassert.
3368 * alloc.c: Convert from xassert to eassert.
3369 * bidi.c: Likewise.
3370 * dispnew.c: Likewise.
3371 * fns.c: Likewise.
3372 * fringe.c: Likewise.
3373 * ftfont.c: Likewise.
3374 * gtkutil.c: Likewise.
3375 * image.c: Likewise.
3376 * keyboard.c: Likewise.
3377 * menu.c: Likewise.
3378 * process.c: Likewise.
3379 * scroll.c: Likewise.
3380 * sound.c: Likewise.
3381 * term.c: Likewise.
3382 * w32console.c: Likewise.
3383 * w32fns.c: Likewise.
3384 * w32term.c: Likewise.
3385 * window.c: Likewise.
3386 * xdisp.c: Likewise.
3387 * xfaces.c: Likewise.
3388 * xfns.c: Likewise.
3389 * xselect.c: Likewise.
3390 * xterm.c: Likewise.
3391
1ec4b7b2
SM
33922012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
3393
3394 * fns.c (maybe_resize_hash_table): Output message when growing the
3395 purify-hashtable.
3396
2014308a
DA
33972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3398
3399 * alloc.c (allocate_string_data): Remove dead code.
3400 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3401 avoid GCC warning about unused macro.
3402
246155eb
DA
34032012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3404
3405 * alloc.c (allocate_string): Omit intervals initialization.
3406 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3407 as in make_pure_string and make_pure_c_string.
3408
43184b7b
DA
34092012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3410
d209e2fb 3411 * alloc.c (allocate_string): Fix last change.
43184b7b 3412
3fe6dd74
DA
34132012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3414
d209e2fb 3415 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3416 to memset, add explicit initialization where appropriate.
3417
1ba6038a
GM
34182012-06-27 Glenn Morris <rgm@gnu.org>
3419
3420 * lisp.mk (lisp): Remove paths.elc.
3421
c89926a5
CY
34222012-06-27 Chong Yidong <cyd@gnu.org>
3423
3424 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3425
ed6b3510
JW
34262012-06-26 John Wiegley <johnw@newartisans.com>
3427
1ec4b7b2 3428 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3429 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3430
ed6b3510
JW
3431 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3432 when building with Clang.
3433
8edd4a2b
SM
34342012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3435
3436 * eval.c (Fapply): Allow calling it with a single argument.
3437
f6f62d1b
EZ
34382012-06-26 Eli Zaretskii <eliz@gnu.org>
3439
3440 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3441 _stricmp and _strnicmp.
3442 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3443
62efea5e
DA
34442012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3445
3446 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3447 allocated window.
3448 (allocate_process): Likewise for new process.
8edd4a2b 3449 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3450 (allocate_frame): Likewise.
3451 * frame.c (make_frame): Omit redundant initialization.
3452 * window.c (make_parent_window): Use memset.
3453 (make_window): Omit redundant initialization.
3454 * process.c (make_process): Omit redundant initialization.
3455 * terminal.c (create_terminal): Likewise.
3456
42997f4d
DA
34572012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3458
3459 * term.c (delete_tty): Remove redundant call to memset.
3460
1130ecfc
DA
34612012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3462
3463 * alloc.c: Remove build_string.
3464 * lisp.h: Define build_string as static inline. This provides
3465 a better opportunity to optimize away calls to strlen when the
3466 function is called with compile-time constant argument.
3467 * image.c (imagemagick_error): Convert to build_string.
3468 * w32proc.c (sys_spawnve): Likewise.
3469 * xterm.c (x_term_init): Likewise.
3470
cf38a720
PE
34712012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3472
99027bdd
PE
3473 Use sprintf return value instead of invoking strlen on result.
3474 In the old days this wasn't portable, since some sprintf
3475 implementations returned char *. But they died out years ago and
3476 Emacs already assumes sprintf returns int.
3477 Similarly for float_to_string.
3478 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3479 * ccl.c (ccl_driver):
3480 * character.c (string_escape_byte8):
3481 * data.c (Fnumber_to_string):
3482 * doprnt.c (doprnt):
3483 * print.c (print_object):
3484 * xdisp.c (message_dolog):
3485 * xfns.c (syms_of_xfns):
3486 Use sprintf or float_to_string result to avoid need to call strlen.
3487 * data.c (Fnumber_to_string):
3488 Use make_unibyte_string, since the string must be ASCII.
3489 * lisp.h, print.c (float_to_string): Now returns int length.
3490 * term.c (produce_glyphless_glyph):
3491 Use sprintf result rather than recomputing it.
3492
cf38a720
PE
3493 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3494 * Makefile.in (ALL_CFLAGS):
3495 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3496 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3497
3511c784
DA
34982012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3499
0a08eb21 3500 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3501 strcasecmp if available.
3502 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3503
fb7da12e
AS
35042012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3505
3506 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3507 Avoid comma operator.
3508 * menu.c (push_submenu_start, push_submenu_end)
3509 (push_left_right_boundary, push_menu_pane): Likewise.
3510 * msdos.c (dos_rawgetc): Likewise.
3511
afa2ffd8
DA
35122012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3513
3514 * xfns.c (xic_create_fontsetname): Remove redundant calls
3515 to memset.
3516
b3b4476b
PE
35172012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3518
4495ff38
PE
3519 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3520 sprintf already null-terminates its output.
3521
b3b4476b
PE
3522 * xfns.c (x_window): Remove redundant cast.
3523
b00876c9
DA
35242012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3525
3526 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3527 `const char *' to `char *' to avoid compiler warning.
3528
d188e26b
PE
35292012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3530
885d1d74
PE
3531 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3532 instead of truncating it to 63 (admittedly a generous limit).
3533
d188e26b
PE
3534 * process.c: Fix spelling and caps in comments.
3535
e2f560b1
DN
35362012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3537
e86db54b 3538 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3539 * sysdep.c (setpgrp): Remove definition, not used in this file.
3540
7583a3a1
JB
35412012-06-24 Juanma Barranquero <lekktu@gmail.com>
3542
3543 * makefile.w32-in: Update dependencies.
3544
696056c2
EZ
35452012-06-24 Eli Zaretskii <eliz@gnu.org>
3546
3547 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3548 (SYSTIME_H): Add nt/inc/sys/time.h.
3549
3550 * systime.h [WINDOWSNT]: Include sys/time.h.
3551
3552 * s/ms-w32.h (struct timespec): Definition moved from
3553 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3554
845ca893
PE
35552012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3556
3557 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3558 * buffer.h (buffer_slot_type_mismatch):
3559 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3560 * eval.c (unwind_to_catch):
3561 * image.c (my_png_error, my_error_exit):
3562 * keyboard.c (quit_throw_to_read_char, user_error)
3563 (Fexit_recursive_edit, Fabort_recursive_edit):
3564 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3565 (wrong_type_argument, buffer_overflow, __executable_start)
3566 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3567 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3568 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3569 (fatal):
3570 (child_setup) [!DOS_NT]:
3571 * lread.c (end_of_file_error, invalid_syntax):
3572 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3573 * puresize.h (pure_write_error):
3574 * search.c (matcher_overflow):
3575 * sound.c (sound_perror, alsa_sound_perror):
3576 * sysdep.c, syssignal.h (croak):
3577 * term.c (maybe_fatal, vfatal):
3578 * textprop.c (text_read_only):
3579 * undo.c (user_error):
3580 * unexmacosx.c (unexec_error):
3581 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3582 Use _Noreturn rather than NO_RETURN.
3583 No need for separate decl merely because of _Noreturn.
3584 * sound.c (sound_warning, parse_sound):
3585 Remove unnecessary forward decls.
3586
f1dd8073
PE
35872012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3588
3589 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3590 * lisp.h (WAIT_READING_MAX): New macro.
3591 * dispnew.c (Fsleep_for, sit_for):
3592 * keyboard.c (kbd_buffer_get_event):
3593 * process.c (Faccept_process_output):
3594 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3595 This improves on the previous patch, which introduced a bug
3596 when time_t is unsigned and as wide as intmax_t.
3597 See <http://bugs.gnu.org/9000#51>.
3598
b82c1755
EZ
35992012-06-23 Eli Zaretskii <eliz@gnu.org>
3600
3601 * dispnew.c (sit_for, Fsleep_for):
3602 * keyboard.c (kbd_buffer_get_event):
3603 * process.c (Faccept_process_output): Avoid compiler warnings when
3604 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3605
ca300656
JB
36062012-06-23 Juanma Barranquero <lekktu@gmail.com>
3607
049ec95b
JB
3608 * makefile.w32-in: Update dependencies.
3609
ca300656
JB
3610 * w32.c (ltime): Add return type and declare static.
3611 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3612
db7b8d06
PE
36132012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3614
3615 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3616 Privately reported by Herbert J. Skuhra.
3617 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3618 All uses changed.
3619 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3620 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3621
0bd8297f
EZ
36222012-06-23 Eli Zaretskii <eliz@gnu.org>
3623
96512555
EZ
3624 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3625 last argument of make_unibyte_string.
3626
0bd8297f
EZ
3627 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3628 language ID in the event parameters.
3629
3630 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3631 event.code, not the obscure "character set ID".
3632
63def6b6
CY
36332012-06-23 Chong Yidong <cyd@gnu.org>
3634
3635 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3636
e8a02204
EZ
36372012-06-23 Eli Zaretskii <eliz@gnu.org>
3638
388cdec0
EZ
3639 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3640 * w32.c (fdutimens): New function.
3641
3642 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3643
3644 * s/ms-w32.h (pselect): Redirect to sys_select.
3645
3646 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3647
e8a02204
EZ
3648 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3649 in the logic of incrementing and decrementing the value of
3650 use_relocatable_buffers.
3651
d054f3fb
PE
36522012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3653
3654 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3655 Privately reported by Herbert J. Skuhra.
3656 [__FreeBSD__]: Remove "*/" typo after "#include".
3657 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3658 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3659 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3660 Don't assume EMACS_TIME and struct timeval are the same type.
3661
d35af63c
PE
36622012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3663
3664 Support higher-resolution time stamps (Bug#9000).
3665 The time stamps are only nanosecond-resolution at the C level,
3666 since that's the best that any real-world system supports now.
3667 But they are picosecond-resolution at the Lisp level, as that's
3668 easy, and leaves room for future OS improvements.
3669
3670 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3671 (LIBES): Use it.
3672
3673 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3674 Don't get current time unless it's needed.
3675
3676 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3677 now provides it if it's absent.
3678 (start_atimer): Port to higher-res time stamps.
3679 Check for time stamp overflow. Don't get current time more
3680 often than is needed.
3681
3682 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3683 Include systime.h, not time.h.
3684 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3685
3686 * dired.c: Include stat-time.h.
3687 (Ffile-attributes): File times now have higher resolution.
3688
3689 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3690 (struct image): Timestamp now has higher resolution.
3691
3692 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3693 has at least microseconds now. All uses removed.
3694 (update_frame, update_single_window, update_window, update_frame_1)
3695 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 3696 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
3697
3698 * editfns.c (time_overflow): Now extern.
3699 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3700 (float-time, Fformat_time_string, Fcurrent_time_string)
3701 (Fcurrent_time_zone): Accept and generate higher-resolution
3702 time stamps.
3703 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3704 (decode_time_components, lisp_seconds_argument): New functions.
3705 (make_time): Now static.
3706 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3707 Report an error if the time is invalid, rather than having the caller
3708 do that.
3709
3710 * fileio.c: Include <stat-time.h>
3711 (Fcopy_file): Copy higher-resolution time stamps.
3712 Prefer to set the time stamp via a file descriptor if that works.
3713 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3714 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3715 (Fvisited_file_modtime, Fset_visited_file_modtime):
3716 Support higher-resolution time stamps.
3717
3718 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3719
3720 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3721
3722 * image.c (prepare_image_for_display, clear_image_cache)
3723 (lookup_image): Port to higer-resolution time stamps.
3724
3725 * keyboard.c (start_polling, bind_polling_period):
3726 Check for time stamp overflow.
3727 (read_char, kbd_buffer_get_event, timer_start_idle)
3728 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3729 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3730 Port to higher-resolution time stamps. Do not assume time_t is signed.
3731 (decode_timer): New function. Timers are now vectors of length 9,
3732 not 8, to accommodate the picosecond component.
3733 (timer_check_2): Use it.
3734
3735 * nsterm.m (select_timeout, timeval_subtract): Remove.
3736 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3737 as they're a bit more accurate and handle overflow better.
3738 (ns_select): Change prototype to be compatible with pselect.
3739 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3740 * nsterm.h (ns_select): Adjust prototype.
3741
3742 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3743 us-resolution time stamps.
3744 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3745
3746 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3747
3748 * lisp.h (time_overflow): New decl.
3749 (wait_reading_process_output): First arg is now intmax_t, not int,
3750 to accommodate larger waits.
3751
3752 * process.h (struct Lisp_Process.read_output_delay):
3753 Now counts nanoseconds, not microseconds.
3754 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3755 EMACS_HAS_USECS.
3756 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3757 (wait_reading_process_output):
3758 Port to ns-resolution time stamps.
3759 (Faccept_process_output, wait_reading_process_output):
3760 Check for time stamp overflow. Do not assume time_t is signed.
3761 (select_wrapper): Remove; we now use pselect.
3762 (Fprocess_attributes): Now generates ns-resolution time stamps.
3763
3764 * sysdep.c: Include utimens.h. Don't include utime.h
3765 or worry about struct utimbuf; gnulib does that for us now.
3766 (gettimeofday): Remove; gnulib provides a substitute.
3767 (make_timeval): New function.
3768 (set_file_times): Now sets ns-resolution time stamps.
3769 New arg FD; all uses changed.
3770 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3771 (system_process_attributes):
3772 Now returns ns-resolution time stamp. All uses changed.
3773 Check for time stamp overflow.
3774
3775 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3776 provides a substitute now.
3777
3778 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3779 since it guarantees struct timespec.
3780 (EMACS_TIME): Now struct timespec, so that we can support
3781 ns-resolution time stamps.
3782 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3783 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3784 (EMACS_USECS): Remove.
3785 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3786 so multiply the arg by 1000 before storing it.
3787 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3788 New macros.
3789 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3790 Port to ns-resolution time stamps.
3791 (EMACS_TIME_NEG_P): Remove; replaced by....
3792 (EMACS_TIME_SIGN): New macro.
3793 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3794 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3795 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3796 (make_timeval, make_lisp_time, decode_time_components): New decls.
3797 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3798 that it mishandled time_t overflow. You can't compare by subtracting!
3799 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3800 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3801
3802 * term.c: Include <sys/time.h>.
3803 (timeval_to_Time): New function, for proper overflow wraparound.
3804 (term_mouse_position, term_mouse_click): Use it.
3805
3806 * undo.c (record_first_change): Support higher-resolution time stamps
3807 in the undo buffer.
3808 (Fprimitive_undo): Use them when restoring time stamps.
3809
3810 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3811 (w32_get_internal_run_time):
3812 Port to higher-resolution Emacs time stamps.
3813 (ltime): Now accepts single 64-bit integer, as that's more convenient
3814 for callers.
3815
3816 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3817
3818 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3819 for compatibility with pselect. Support ns-resolution time stamps.
3820
3821 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3822
3823 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3824 Check for time stamp overflow, and support ns-resolution time stamps.
3825
3826 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3827 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3828 (timeval_subtract): Remove; no longer needed.
3829 (XTflash, XTring_bell, x_wait_for_event):
3830 Port to ns-resolution time stamps. Don't assume time_t is signed.
3831
b6a92dfe
CY
38322012-06-22 Chong Yidong <cyd@gnu.org>
3833
3834 * xdisp.c (x_consider_frame_title): Revert last change.
3835
d251c37c
EZ
38362012-06-22 Eli Zaretskii <eliz@gnu.org>
3837
3838 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3839 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3840 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3841 staticidx goes up to 1597 out of 1600 = 0x640.)
3842
f10deafb
PE
38432012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3844
3845 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3846 Otherwise, the umask might be mistakenly 0 while handling input signals.
3847
ec6de1e2
SM
38482012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3849
3850 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3851
28be1ada
DA
38522012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3853
3854 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3855 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3856 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3857 access to `contents' member of Lisp_Vector objects with AREF and ASET
3858 where appropriate.
3859
c6bf3022
CY
38602012-06-19 Chong Yidong <cyd@gnu.org>
3861
3862 * frame.c (delete_frame): When selecting a frame on a different
3863 text terminal, do not alter the terminal's top-frame.
3864
3865 * xdisp.c (format_mode_line_unwind_data): Record the target
3866 frame's selected window and its terminal's top-frame.
3867 (unwind_format_mode_line): Restore them.
3868 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3869 Callers changed.
3870 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3871 since tty frames can be explicitly named.
3872 (prepare_menu_bars): Likewise.
3873
3874 * term.c (Ftty_top_frame): New function.
3875
defd4196
PE
38762012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3877
3878 Port byte-code-meter to modern targets.
3879 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3880 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3881 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3882 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3883 (METER_1, METER_2): Simplify.
3884
1053a871
SM
38852012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3886
3887 * data.c (Fdefalias): Return `symbol' (bug#11686).
3888
b7e8d081
MR
38892012-06-18 Martin Rudalics <rudalics@gmx.at>
3890
3891 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3892 gets killed during executing of this function (Bug#11665).
3893 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3894 (Vkill_buffer_query_functions): In doc-string say that functions
3895 run by this hook should not change the current buffer.
3896
7ea2b339
PE
38972012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3898
3899 Fix recently-introduced process.c problems found by static checking.
3900 * process.c (write_queue_push, write_queue_pop, send_process):
3901 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3902 (write_queue_pop): Fix pointer signedness problem.
3903 (send_process): Remove unused local.
3904
96a313a1
CY
39052012-06-17 Chong Yidong <cyd@gnu.org>
3906
3907 * xdisp.c (redisplay_internal): No need to redisplay terminal
3908 frames that are not on top.
3909
20ca2e94
TN
39102012-06-17 Troels Nielsen <bn.troels@gmail.com>
3911
3912 * process.c (make_process): Initialize write_queue.
3913 (write_queue_push, write_queue_pop): New functions.
3914 (send_process): Use them to maintain correct ordering of process
3915 writes (Bug#10815).
3916
9a900ca9
PE
39172012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3918
310fbfa8
PE
3919 * lisp.h (eassert): Assume C89 or later.
3920 This removes the need for CHECK.
3921 (CHECK): Remove. Its comments about always evaluating its
3922 argument were confusing, as 'eassert' typically does not evaluate
3923 its argument.
3924
27bb1ca4
PE
3925 * coding.c (produce_chars): Use ptrdiff_t, not int.
3926
9a900ca9
PE
3927 * xterm.c (x_draw_underwave): Check for integer overflow.
3928 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3929
41b7f8bc 39302012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3931
3932 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3933 referenced (Bug#11583).
3934
9b0e3eba
AA
39352012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3936
3937 Implement wave-style variant of underlining.
3938 * dispextern.h (face_underline_type): New enum.
3939 (face): Add field for underline type.
3940 * nsterm.m (ns_draw_underwave): New function.
3941 (ns_draw_text_decoration): Use it.
3942 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3943 New functions.
3944 (x_draw_glyph_string): Use them.
3945 * xfaces.c (Qline, Qwave): New Lisp objects.
3946 (check_lface_attrs, merge_face_ref)
1053a871
SM
3947 (Finternal_set_lisp_face_attribute, realize_x_face):
3948 Handle wave-style underline face attributes.
9b0e3eba
AA
3949 * xterm.c (x_draw_underwave): New function.
3950 (x_draw_glyph_string): Use it.
3951
0fb52f11
JB
39522012-06-16 Juanma Barranquero <lekktu@gmail.com>
3953
3954 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3955 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3956 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3957 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3958 ($(BLD)/w32select.$(O)): Update dependencies.
3959
e5560ff7
AS
39602012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3961
3962 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3963 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3964 * character.c (_fetch_multibyte_char_p): Remove.
3965 * alloc.c: Include "character.h" before "buffer.h".
3966 * bidi.c: Likewise.
3967 * buffer.c: Likewise.
3968 * bytecode.c: Likewise.
3969 * callint.c: Likewise.
3970 * callproc.c: Likewise.
3971 * casefiddle.c: Likewise.
3972 * casetab.c: Likewise.
3973 * category.c: Likewise.
3974 * cmds.c: Likewise.
3975 * coding.c: Likewise.
3976 * composite.c: Likewise.
3977 * dired.c: Likewise.
3978 * dispnew.c: Likewise.
3979 * doc.c: Likewise.
3980 * dosfns.c: Likewise.
3981 * editfns.c: Likewise.
3982 * emacs.c: Likewise.
3983 * fileio.c: Likewise.
3984 * filelock.c: Likewise.
3985 * font.c: Likewise.
3986 * fontset.c: Likewise.
3987 * fringe.c: Likewise.
3988 * indent.c: Likewise.
3989 * insdel.c: Likewise.
3990 * intervals.c: Likewise.
3991 * keyboard.c: Likewise.
3992 * keymap.c: Likewise.
3993 * lread.c: Likewise.
3994 * macros.c: Likewise.
3995 * marker.c: Likewise.
3996 * minibuf.c: Likewise.
3997 * nsfns.m: Likewise.
3998 * nsmenu.m: Likewise.
3999 * print.c: Likewise.
4000 * process.c: Likewise.
4001 * regex.c: Likewise.
4002 * region-cache.c: Likewise.
4003 * search.c: Likewise.
4004 * syntax.c: Likewise.
4005 * term.c: Likewise.
4006 * textprop.c: Likewise.
4007 * undo.c: Likewise.
4008 * unexsol.c: Likewise.
4009 * w16select.c: Likewise.
4010 * w32fns.c: Likewise.
4011 * w32menu.c: Likewise.
4012 * window.c: Likewise.
4013 * xdisp.c: Likewise.
4014 * xfns.c: Likewise.
4015 * xmenu.c: Likewise.
4016 * xml.c: Likewise.
4017 * xselect.c: Likewise.
4018
2f07e6af
EZ
40192012-06-16 Eli Zaretskii <eliz@gnu.org>
4020
1053a871
SM
4021 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
4022 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 4023 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
4024 row.
4025 (handle_face_prop): Use chunk-relative overlay string index when
4026 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
4027 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
4028 the rightmost. (Bug#11720)
2f07e6af 4029
29b83cec
AS
40302012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4031
4032 * category.h (CHAR_HAS_CATEGORY): Define as inline.
4033 (CATEGORY_MEMBER): Enforce 1/0 value.
4034 * category.c (_temp_category_set): Remove.
4035
4c5501e9
EZ
40362012-06-16 Eli Zaretskii <eliz@gnu.org>
4037
4038 * window.c (Fdelete_other_windows_internal)
4039 (Fdelete_window_internal): Don't access frame's mouse highlight
4040 info of the initial frame. (Bug#11677)
4041
2b570124
PE
40422012-06-14 Paul Eggert <eggert@cs.ucla.edu>
4043
e93864f9
PE
4044 * .gdbinit (xgetint): Fix recently-introduced paren typo.
4045 Assume USE_2_TAGS_FOR_INTS.
4046 (xreload): Adjust $tagmask width to match recent lisp.h change.
4047
2b570124
PE
4048 Simplify lisp.h in minor ways that should not affect code.
4049 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
4050 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
4051 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
4052 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
4053 (INTTYPEBITS): New macro, for clarity.
4054 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
4055 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
4056 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
4057 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
4058 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
4059
81755f69
JB
40602012-06-13 Juanma Barranquero <lekktu@gmail.com>
4061
4062 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
4063
16192a57
GM
40642012-06-13 Glenn Morris <rgm@gnu.org>
4065
4066 * s/bsd-common.h (BSD4_3):
4067 * s/usg5-4-common.h (USG5_4): No longer define; unused.
4068
646b5f55
AS
40692012-06-13 Andreas Schwab <schwab@linux-m68k.org>
4070
4071 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
4072 instead of union.
4073 (XLI, XIL): Define.
1053a871
SM
4074 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
4075 Use them.
4076 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 4077 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 4078 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
4079 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
4080 * frame.c (delete_frame): Remove outdated comment.
4081 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
4082 USE_LISP_UNION_TYPE.
4083 (Fw32_unregister_hot_key): Likewise.
4084 (Fw32_toggle_lock_key): Likewise.
4085 * w32menu.c (add_menu_item): Likewise.
4086 (w32_menu_display_help): Use XIL instead of checking
4087 USE_LISP_UNION_TYPE.
4088 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
4089 (init_heap): Likewise.
4090 * w32term.c (w32_read_socket): Update comment.
4091
1d3823c9
GM
40922012-06-13 Glenn Morris <rgm@gnu.org>
4093
c62ff706
GM
4094 * s/usg5-4-common.h, src/s/unixware.h:
4095 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
4096
1d3823c9
GM
4097 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
4098
bfe3e0a2
PE
40992012-06-13 Paul Eggert <eggert@cs.ucla.edu>
4100
4101 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
4102 * alloc.c (make_number) [!defined make_number]:
4103 Remove, as lisp.h always defines this now.
4104 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
4105 (roundup_size): Verify that it is a power of 2.
4106 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
4107 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
4108 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
4109 -DUSE_LSB_TAG=0, to override the automatically-selected default.
4110 USE_LSB_TAG now is always defined to be either 0 or 1.
4111 All uses changed.
4112 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
4113 code works fine either way, and efficiency is not a concern here,
4114 as the union type is for debugging, not for production.
4115 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
4116 Use an inline function on all platforms when using the union type,
4117 since this is simpler and 'static inline' can be used portably
4118 within Emacs now.
4119 (LISP_INITIALLY_ZERO): New macro.
4120 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
4121 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
4122
45fa9c0f
GM
41232012-06-12 Glenn Morris <rgm@gnu.org>
4124
b4492cba
GM
4125 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
4126
4127 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 4128
45fa9c0f
GM
4129 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
4130 Move BROKEN_SIGIO to configure.
4131
4132 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
4133 Move NO_TERMIO to configure.
4134
0e25d334
CY
41352012-06-12 Chong Yidong <cyd@gnu.org>
4136
4137 * image.c (imagemagick_load_image): Use MagickFlattenImage if
4138 MagickMergeImageLayers is undefined. Use pixel pusher loop if
4139 MagickExportImagePixels is undefined.
4140
43682bb6
PE
41412012-06-12 Paul Eggert <eggert@cs.ucla.edu>
4142
4143 * image.c (imagemagick_load_image): Remove unused label.
4144
a9be7d2b
GM
41452012-06-11 Glenn Morris <rgm@gnu.org>
4146
4147 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4148 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
4149 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
4150 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
4151
3017f87f
SM
41522012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
4153
4154 * alloc.c (make_byte_code): New function.
4155 (Fmake_byte_code): Use it. Don't purify here.
4156 * lread.c (read1): Use it as well to avoid extra allocation.
4157
1b9b4cf4
CY
41582012-06-11 Chong Yidong <cyd@gnu.org>
4159
4160 * image.c (imagemagick_load_image): Implement transparency.
4161
95988fcf
AS
41622012-06-10 Andreas Schwab <schwab@linux-m68k.org>
4163
4164 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
4165 account for preceding backslashes. (Bug#11663)
4166
cd4eb164
CY
41672012-06-09 Chong Yidong <cyd@gnu.org>
4168
4169 * term.c: Support italics in capable terminals (Bug#9652).
4170 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
4171 (turn_on_face): Output using TS_enter_italic_mode if available.
4172 Don't handle unused blinking and alt-charset cases.
4173 (turn_off_face): Handle italic case; discard unused tty_blinking_p
4174 and tty_alt_charset_p cases.
4175 (tty_capable_p, init_tty): Support italics.
4176
4177 * termchar.h (struct tty_display_info): Add field for italics.
4178 Remove unused blink field.
4179
4180 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
4181 Handle slant.
4182
4183 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
4184 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
4185 tty_alt_charset_p. Add tty_italic_p.
4186
ff88beb8
MA
41872012-06-09 Michael Albinus <michael.albinus@gmx.de>
4188
4189 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
4190 dbus_type_is_basic if available.
4191 (xd_extract_signed, xd_extract_unsigned): Rename from
4192 extract_signed and extract_unsigned, respectively. Adapt callers.
4193
44286096
CY
41942012-06-09 Chong Yidong <cyd@gnu.org>
4195
1682701f
CY
4196 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
4197
44286096
CY
4198 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
4199 case (Bug#9752).
4200
d86feb17
PE
42012012-06-08 Paul Eggert <eggert@cs.ucla.edu>
4202
4203 * xdisp.c (vmessage): Treat frame message as multibyte.
4204 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
4205 would generate the diagnostic "Making \302\247 buffer-local while
4206 let-bound!".
4207
d5c20fe8
EZ
42082012-06-08 Eli Zaretskii <eliz@gnu.org>
4209
4210 * dispnew.c (showing_window_margins_p): Undo last change, which
4211 was done due to an inadvertent commit.
4212 (adjust_frame_glyphs_for_frame_redisplay): Do call
4213 showing_window_margins_p.
4214
513749ee
SM
42152012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4216
4217 * eval.c (Fmake_var_non_special): New primitive.
4218 (syms_of_eval): Defsubr it.
4219 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
4220
d4a8f5c1
JB
42212012-06-08 Juanma Barranquero <lekktu@gmail.com>
4222
4223 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
4224 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
4225
8bbbc977
EZ
42262012-06-08 Eli Zaretskii <eliz@gnu.org>
4227
4228 * alloc.c (allocate_vectorlike): Fix last change.
4229
f3372c87
DA
42302012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
4231
4232 Block-based vector allocation of small vectors.
4233 * lisp.h (struct vectorlike_header): New field `nbytes',
4234 adjust comment accordingly.
4235 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
4236 to denote vector blocks. Adjust users (live_vector_p,
4237 mark_maybe_pointer, valid_lisp_object_p) accordingly.
4238 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
4239 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
4240 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
4241 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
4242 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
4243 (roundup_size): New constant.
4244 (struct vector_block): New data type.
4245 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 4246 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
4247 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
4248 (sweep_vectors): New functions.
4249 (allocate_vectorlike): Return `zero_vector' as the only vector of
4250 0 items. Allocate new vector from block if vector size is less than
4251 or equal to VBLOCK_BYTES_MAX.
4252 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
4253 (init_alloc_once): Add call to init_vectors.
4254
4f18a4ed
SM
42552012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4256
4257 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
4258
86f158bc
PE
42592012-06-07 Paul Eggert <eggert@cs.ucla.edu>
4260
4261 * doprnt.c (doprnt): Truncate multibyte char correctly.
4262 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
4263 would mishandle a string argument "Xc" if X was a multibyte
4264 character of length 2: it would truncate after X's first byte
4265 rather than including all of X.
4266
c5cfcbe0
CY
42672012-06-06 Chong Yidong <cyd@gnu.org>
4268
4269 * buffer.c (word_wrap): Doc fix.
4270
c05cf390
PE
42712012-06-04 Paul Eggert <eggert@cs.ucla.edu>
4272
4273 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
4274
0c3461de
GM
42752012-06-03 Glenn Morris <rgm@gnu.org>
4276
4277 * xdisp.c (tool-bar-style): Doc fix.
4278
c71232db
UM
42792012-06-03 Ulrich Müller <ulm@gentoo.org>
4280
4281 * Makefile.in (PAXCTL): Define.
4282 (temacs$(EXEEXT)): Disable memory randomization for the temacs
4283 binary via PaX flags if the paxctl utility is available.
4284 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
4285 Restore PaX flags to their default. (Bug#11398)
4286
383f7350
CY
42872012-06-03 Chong Yidong <cyd@gnu.org>
4288
4289 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
4290 buffer (Bug#11226).
4291
5f2c76c6
CY
42922012-06-03 Chong Yidong <cyd@gnu.org>
4293
4294 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
4295 (note_mode_line_or_margin_highlight): If there is no help echo,
4296 use mode-line-default-help-echo. Handle the case where the mouse
4297 position is past the end of the mode line string.
4298
4299 * buffer.c (buffer_local_value_1): New function, split from
4300 Fbuffer_local_value; can return Qunbound.
4301 (Fbuffer_local_value): Use it.
4302 (Vmode_line_format): Docstring tweaks.
4303
773d47f6
PE
43042012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4305
4306 * sysdep.c (system_process_attributes): Improve comment.
4307
f2d6a3df
SM
43082012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
4309
4310 * keyboard.c: Export real-this-command to Elisp.
4311 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
4312 and DEFVAR it. Update all users.
4313
63810350
PE
43142012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4315
7bd5c1f4
PE
4316 * minibuf.c (Fassoc_string): Remove duplicate declaration.
4317
63810350
PE
4318 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
4319 Convert pctcpu and pctmem to Lisp float properly.
4320 Let the compiler fold better, as 100.0/0x8000 is exact.
4321
a2821611
AS
43222012-06-02 Andreas Schwab <schwab@linux-m68k.org>
4323
4324 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
4325 cons_block.
4326
5fceba1d
PE
43272012-06-01 Paul Eggert <eggert@cs.ucla.edu>
4328
4329 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
4330
c98ff5dd
DA
43312012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
4332
4333 For a 'struct window', replace some Lisp_Object fields to
4334 bitfields where appropriate, remove unused fields.
4335 * window.h (struct window): Remove unused 'last_mark_x' and
4336 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
4337 change it's type from Lisp_Object to bitfield.
4338 Change type of 'force_start', 'optional_new_start',
4339 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
4340 fields from Lisp_Object to bitfield. Adjust users accordingly.
4341
ca34e0be
PE
43422012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 Pacify gcc -Wdouble-precision when using Xaw.
4345 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
4346 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
4347 Use 'float' consistently, rather than 'float' in most places
4348 and 'double' in a couple of places.
4349
efc00ab1 43502012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
4351
4352 * xdisp.c (handle_stop): Detect whether we have overlay strings
4353 loaded by testing it->current.overlay_string_index to be
4354 non-negative, instead of checking whether n_overlay_strings is
4355 positive. (Bug#11587)
4356
efc00ab1 43572012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
4358
4359 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
4360
4361 * doc.c (Fsubstitute_command_keys): Doc fix.
4362
efc00ab1 43632012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
4364
4365 * search.c (search_buffer): Remove calls to
4366 r_alloc_inhibit_buffer_relocation, as it is now called by
4367 maybe_unify_char, which was the cause of relocation of buffer text
4368 in bug#11519.
4369
efc00ab1 43702012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
4371
4372 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4373 for the duration of call to load_charset, to avoid problems with
4374 callers of maybe_unify_char that access buffer text through C
4375 pointers.
4376
4377 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
4378 decrement the inhibition flag, instead of just setting or
4379 resetting it.
4380
ba93a187
PE
43812012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4382
4383 Remove obsolete '#define static' cruft.
4384 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
4385 This #undef was "temporary" in 2000; it is no longer needed
4386 now that '#define static' has gone away.
4387 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
4388 (gray_bitmap_bits): Remove; no longer needed.
4389 All uses replaced with definiens.
4390 * xterm.c: Include "bitmaps/gray.xbm".
4391
9e4bf381
PE
43922012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4393
4394 Clean up __executable_start, monstartup when --enable-profiling.
4395 The following changes affect the code only when profiling.
4396 * dispnew.c (__executable_start): Rename from safe_bcopy.
4397 Define only on platforms that need it.
4398 * emacs.c: Include <sys/gmon.h> when profiling.
4399 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4400 (__executable_start): Remove decl, since lisp.h does it now.
4401 (safe_bcopy): Remove decl; no longer has that name.
4402 (main): Coalesce #if into single bit of code, for simplicity.
4403 Cast pointers to uintptr_t, since standard libraries want integers
4404 and not pointers.
4405 * lisp.h (__executable_start): New decl.
4406
32d72c2f
GM
44072012-05-31 Glenn Morris <rgm@gnu.org>
4408
4409 * image.c (Fimagemagick_types): Doc fix.
4410
baac5bc7
JM
44112012-05-30 Jim Meyering <meyering@redhat.com>
4412
4413 * callproc.c (Fcall_process_region): Include directory component
4414 in mkstemp error message (Bug#11586).
4415
72cb32cf
PE
44162012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4417
4418 * alloc.c, lisp.h (make_pure_vector): Now static.
4419
61b108cc
SM
44202012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4421
4422 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4423 Move to byte-run.el.
4424 (Fautoload): Do the hash-doc more carefully.
4425 * data.c (Fdefalias): Purify definition, except for keymaps.
4426 (Qdefun): Move from eval.c.
4427 * lisp.h (Qdefun): Remove.
4428 * lread.c (read1): Tiny simplification.
4429
471fe23d
TN
44302012-05-29 Troels Nielsen <bn.troels@gmail.com>
4431
934f3f58 4432 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4433 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4434 Bug#9642, but explicitly check that the buffer the overlay would
4435 be moved to is live and rearrange lines to make sure that errors
4436 will not put the overlay in an inconsistent state.
4437 (Fdelete_overlay): Cosmetics.
4438
85d0efd1
EZ
44392012-05-28 Eli Zaretskii <eliz@gnu.org>
4440
4441 * w32term.c (my_bring_window_to_top): New function.
4442 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4443 could be different from the original one.
4444 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4445 (Bug#11513)
4446
4447 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4448 by calling BringWindowToTop.
4449
4450 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4451 (WM_EMACS_END): Increase by one.
4452
da92a98c
PE
44532012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4454
4455 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4456 This avoids undefined behavior that might cause the eassert
4457 to not catch an out-of-range value.
4458
74d1f848
JB
44592012-05-28 Juanma Barranquero <lekktu@gmail.com>
4460
4461 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4462 Update dependencies.
4463
9e1a06fc
EZ
44642012-05-27 Eli Zaretskii <eliz@gnu.org>
4465
4466 * bidi.c (bidi_mirror_char): Fix last change.
4467
f3dd7312
AS
44682012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4469
4470 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4471 when referring to sectname field in printf format.
4472
81899c91
PE
44732012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4474
57b81a9f
PE
4475 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4476 Only r_alloc_inhibit_buffer_relocation needed to be added;
4477 the others were already declared.
4478
81899c91
PE
4479 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4480 before checking whether it's out of range. Put the check inside
4481 eassert. See
4482 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4483
33017faf 44842012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4485
4486 * callproc.c (Fcall_process): Restore a line that was accidentally
4487 commented out in the 2011-02-13 change (bug#11547).
4488
33017faf 44892012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4490
4491 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4492 defined on ralloc.c.
4493
4494 * buffer.c [REL_ALLOC]: Remove prototypes of
4495 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4496 they are now on lisp.h.
4497
4498 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4499
4500 * search.c (search_buffer): Use it to inhibit relocation of buffer
4501 text while re_search_2 is doing its job, because re_search_2 is
4502 passed C pointers to buffer text. (Bug#11519)
4503
23415acf
EZ
4504 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4505 Update value to 24.
4506
44e27368
EZ
4507 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4508 state after an additional call to move_it_in_display_line_to, keep
4509 the values of it->max_ascent and it->max_descent found for the
4510 entire line.
4511 (pos_visible_p): Revert the comparison against bottom_y to what it
4512 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4513 (Bug#11464)
4514
c1892f11
PE
45152012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4516
4517 Fix coding-related core dumps with gcc -ftrapv.
4518 The code was computing A - B, where A and B are pointers, and B is
4519 random garbage. This can lead to core dumps on platforms that
4520 have special pointer registers, and it also leads to core dumps on
4521 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4522 A - B only when B is initialized properly.
4523 * coding.c (coding_set_source, coding_set_destination): Return void.
4524 (coding_change_source, coding_change_destinations): New functions,
4525 with the old behaviors of coding_set_source and coding_set_destination.
4526 All callers that need an offset changed to use these new functions.
4527
eb7afdad
GM
45282012-05-26 Glenn Morris <rgm@gnu.org>
4529
4530 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4531
f12fdf02
EZ
45322012-05-26 Eli Zaretskii <eliz@gnu.org>
4533
53a63be6 4534 Extend mouse support on W32 text-mode console.
61b108cc
SM
4535 * xdisp.c (draw_row_with_mouse_face):
4536 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4537
eb3f6f01 4538 * w32console.c: Include window.h.
61b108cc
SM
4539 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4540 New functions.
eb3f6f01
EZ
4541 (initialize_w32_display): Initialize mouse-highlight data.
4542
53a63be6
EZ
4543 * w32inevt.c: Include termchar.h and window.h.
4544 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4545 moves, call note_mouse_highlight. If help_echo changed, call
4546 gen_help_event to produce help-echo message in the echo area.
4547 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4548 highlight info.
4549
4cfd81f6
PE
45502012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4551
4552 * lread.c (read1): Simplify slightly to avoid an overflow warning
4553 with GCC 4.7.0 on x86-64.
4554
4446092a
EZ
45552012-05-26 Eli Zaretskii <eliz@gnu.org>
4556
4557 * bidi.c (bidi_mirror_char): Revert last change: an int is
4558 definitely wide enough here.
4559
42b2a986 45602012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4561
42b2a986 4562 Fix integer width and related bugs (Bug#9874).
eb106a49 4563 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4564 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4565 (string_bytes, check_sblock, allocate_string_data):
4566 (compact_small_strings, Fmake_bool_vector, make_string)
4567 (make_unibyte_string, make_multibyte_string)
4568 (make_string_from_bytes, make_specified_string)
4569 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4570 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4571 (mark_vectorlike):
4572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4573 (allocate_pseudovector):
4574 Use int, not EMACS_INT, where int is wide enough.
4575 (inhibit_garbage_collection, Fgarbage_collect):
4576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4577 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4578 int might not be wide enough.
4579 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4580 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4581 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4582 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4583 (bidi_level_of_next_char, bidi_move_to_visually_next):
4584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4585 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4586 (Fkill_buffer, Fset_buffer_major_mode)
4587 (advance_to_char_boundary, Fbuffer_swap_text)
4588 (Fset_buffer_multibyte, overlays_at, overlays_in)
4589 (overlay_touches_p, struct sortvec, record_overlay_string)
4590 (overlay_strings, recenter_overlay_lists)
4591 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4592 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4593 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4594 (Foverlay_recenter, last_overlay_modification_hooks_used)
4595 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4597 (validate_region): Omit unnecessary test for b <= e,
4598 since that's guaranteed by the previous test.
d311d28c
PE
4599 (adjust_overlays_for_delete): Avoid pos + length overflow.
4600 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4601 (report_overlay_modification):
4602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4603 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4604 Omit pointer cast, which isn't needed anyway, and doesn't work
4605 after the EMACS_INT -> ptrdiff_t change.
02481186 4606 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4607 * buffer.h: Adjust decls to match defn changes elsewhere.
4608 (struct buffer_text, struct buffer):
4609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4610 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4611 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4612 not int, to avoid needless 32-bit limit on 64-bit hosts.
4613 (exec_byte_code): Use tighter memory-full test, one that checks
4614 for alloca overflow. Don't compute the address of the object just
4615 before an array, as that's not portable. Use EMACS_INT, not
4616 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4617 * callint.c (Fcall_interactively):
4618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4619 * callproc.c (call_process_kill, Fcall_process):
4620 Don't assume pid_t fits into an Emacs fixnum.
4621 (call_process_cleanup, Fcall_process, child_setup):
4622 Don't assume pid_t fits into int.
4623 (call_process_cleanup, Fcall_process, delete_temp_file)
4624 (Fcall_process_region):
4625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4626 (Fcall_process): Simplify handling of volatile integers.
4627 Use int, not EMACS_INT, where int will do.
4628 * casefiddle.c (casify_object, casify_region, operate_on_word)
4629 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4631 (casify_object): Avoid integer overflow when overallocating buffer.
4632 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4633 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4634 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4635 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4636 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4637 integers are now checked earlier. All uses replaced with XINT.
4638 (ccl_driver):
4639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4640 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4641 (ccl_driver, Fregister_code_conversion_map):
4642 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4643 (resolve_symbol_ccl_program): Check that vector header is in range.
4644 Always copy the vector, so that we can check its contents reliably
4645 now rather than having to recheck each instruction as it's being
4646 executed. Check that vector words fit in 'int'.
4647 (ccl_get_compiled_code, Fregister_ccl_program)
4648 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4649 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4650 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4651 contents are in range.
4652 (Fccl_execute_on_string): Check that status is in range.
4653 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4654 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4655 Accept and return EMACS_INT, not int, because callers can pass values
4656 out of 'int' range.
4657 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4658 (multibyte_chars_in_text, parse_str_as_multibyte)
4659 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4660 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4661 (string_escape_byte8, Fget_byte):
4662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4663 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4664 avoid mishandling large integers.
4665 * character.h: Adjust decls to match defn changes elsewhere.
4666 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4667 (Ffind_charset_region):
4668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4669 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4670 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4671 Don't assume fixnum fits in int.
d311d28c
PE
4672 (load_charset_map_from_vector, Fmap_charset_chars):
4673 Remove now-unnecessary CHECK_NATNUMs.
4674 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4675 Don't rely on undefined behavior with signed left shift overflow.
4676 Don't assume unsigned int fits into fixnum, or that fixnum fits
4677 into unsigned int. Don't require max_code to be a valid fixnum;
4678 that's not true for gb10830 4-byte on a 32-bit host. Allow
4679 invalid_code to be a cons, for the same reason. Require code_offset
4680 to be a character. Avoid int overflow if max_char is close
4681 to INT_MAX.
4682 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4683 this is intended anyway and avoids some undefined behavior.
4684 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4685 INDEX_TO_CODE_POINT, as that's what it expects.
4686 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4687 * charset.h (DECODE_CHAR): Return int, not unsigned;
4688 this is what was intended anyway, and it avoids undefined behavior.
4689 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4690 integer-overflow issues.
4691 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4692 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4693 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4694 * chartab.c (Fmake_char_table, Fset_char_table_range)
4695 (uniprop_get_decoder, uniprop_get_encoder):
4696 Don't assume fixnum fits in int.
4697 * cmds.c (move_point): New function, that does the gist of
4698 Fforward_char and Fbackward_char, but does so while checking
4699 for integer overflow more accurately.
c96e5d6a 4700 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4701 (Fforward_line, Fend_of_line, internal_self_insert)
4702 (internal_self_insert):
4703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4704 Fix a FIXME, by checking for integer overflow when calculating
4705 target_clm and actual_clm.
4706 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4707 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4708 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4709 (coding_alloc_by_making_gap, alloc_destination)
4710 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4711 (encode_coding_utf_16, detect_coding_emacs_mule)
4712 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4713 (detect_coding_iso_2022, decode_coding_iso_2022)
4714 (encode_invocation_designation, encode_designation_at_bol)
4715 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4716 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4717 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4718 (encode_coding_ccl, encode_coding_raw_text)
4719 (detect_coding_charset, decode_coding_charset)
4720 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4721 (produce_composition, produce_charset, produce_annotation)
4722 (decode_coding, handle_composition_annotation)
4723 (handle_charset_annotation, consume_chars, decode_coding_gap)
4724 (decode_coding_object, encode_coding_object, detect_coding_system)
4725 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4726 (code_convert_region, code_convert_string)
8f50130c
PE
4727 (Fdefine_coding_system_internal)
4728 (coding_set_source, coding_set_destination):
d311d28c
PE
4729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4730 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4731 (Fdefine_coding_system_internal):
4732 Don't assume fixnums fit in int.
4733 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4734 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4735 (Funencodable_char_position, Fcheck_coding_systems_region)
4736 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4738 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4739 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4740 Don't access memory outside of the args array.
d311d28c 4741 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4742 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4743 result of ENCODE_CHAR.
d311d28c
PE
4744 * coding.h: Adjust decls to match defn changes elsewhere.
4745 (struct coding_system):
4746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4747 * composite.c (get_composition_id, find_composition)
4748 (run_composition_function, update_compositions)
4749 (compose_text, composition_gstring_put_cache)
4750 (composition_gstring_p, composition_gstring_width)
4751 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4752 (composition_compute_stop_pos, composition_reseat_it)
4753 (composition_update_it, struct position_record)
4754 (find_automatic_composition, composition_adjust_point)
4755 (Fcomposition_get_gstring, Ffind_composition_internal):
4756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4757 (update_compositions):
4758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4759 * composite.h: Adjust decls to match defn changes elsewhere.
4760 (struct composition):
4761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4762 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4763 Do not attempt to compute the address of the object just before a
4764 buffer; this is not portable.
4765 (Faref, Faset):
4766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4767 (Faset): Use int, not EMACS_INT, where int is wide enough.
4768 (Fstring_to_number): Don't assume fixnums fit in int.
4769 (Frem): Don't assume arg is nonnegative.
4770 * dbusbind.c (xd_append_arg): Check for integers out of range.
4771 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4772 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4773 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4774 (xd_get_connection_references): Return ptrdiff_t, not int.
4775 All uses changed.
4776 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4777 (xd_read_message_1):
4778 Use int, not unsigned, where the dbus API uses int.
4779 (Fdbus_message_internal): Don't overflow mtype.
4780 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4781 * dired.c (directory_files_internal, file_name_completion, scmp)
4782 (file_name_completion_stat):
4783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4784 (file_name_completion): Don't overflow matchcount.
4785 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4786 * dispextern.h: Adjust decls to match defn changes elsewhere.
4787 (struct text_pos, struct glyph, struct bidi_saved_info)
4788 (struct bidi_string_data, struct bidi_it, struct composition_it)
4789 (struct it):
4790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4791 (struct display_pos, struct composition_it, struct it):
4792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4793 * dispnew.c (increment_matrix_positions)
4794 (increment_row_positions, mode_line_string)
4795 (marginal_area_string):
4796 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4797 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4799 (duration_to_sec_usec): New function, to check for overflow better.
4800 (Fsleep_for, sit_for): Use it.
4801 * doc.c (get_doc_string, store_function_docstring):
4802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4803 (get_doc_string, Fsnarf_documentation):
4804 Use int, not EMACS_INT, where int is wide enough.
4805 (get_doc_string):
4806 Use SAFE_ALLOCA, not alloca.
4807 Check for overflow when converting EMACS_INT to off_t.
4808 * doprnt.c (doprnt):
4809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4810 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4811 Don't assume uid_t fits into fixnum.
4812 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4813 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4814 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4815 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4816 (general_insert_function)
4817 (Finsert_char, make_buffer_string, make_buffer_string_both)
4818 (update_buffer_properties, Fbuffer_substring)
4819 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4820 (Fsubst_char_in_region, check_translation)
4821 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4822 (transpose_markers, Ftranspose_regions):
4823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4824 (clip_to_bounds): Move to lisp.h as an inline function).
4825 (Fconstrain_to_field): Don't assume integers are nonnegative.
4826 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4827 (Fsubst_char_in_region, Fsave_restriction):
4828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4829 (Femacs_pid): Don't assume pid_t fits into fixnum.
4830 (lo_time): Use int, not EMACS_INT, when int suffices.
4831 (lisp_time_argument): Check for usec out of range.
4832 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4833 (Fuser_login_name, Fuser_full_name): Signal an error
4834 if a uid argument is out of range, rather than relying on
4835 undefined behavior.
c8d5c857
PE
4836 (Fformat_time_string): Remove now-unnecessary check.
4837 lisp_time_argument checks for out-of-range usec now.
243e0530 4838 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4839 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4840 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4841 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4842 (init_cmdargs, Fdump_emacs):
4843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4844 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4845 the bottom (typically) 32 bits of the fixnum.
4846 * eval.c (specpdl_size, call_debugger):
4847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4848 (when_entered_debugger, Fbacktrace_debug):
4849 Don't assume fixnum can fit in int.
4850 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4851 the object just before a buffer; this is not portable.
4852 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4853 (grow_specpdl, unbind_to):
4854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4855 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4856 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4857 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4858 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4859 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4861 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4862 (a_write, e_write):
4863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4864 (Fcopy_file, non_regular_nbytes, read_non_regular)
4865 (Finsert_file_contents):
4866 Use int, not EMACS_INT, where int is wide enough.
4867 (READ_BUF_SIZE): Verify that it fits in int.
4868 (Finsert_file_contents): Check that counts are in proper range,
4869 rather than assuming fixnums fit into ptrdiff_t etc.
4870 Don't assume fixnums fit into int.
125b3835 4871 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4872 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4873 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4874 (string_char_to_byte, string_byte_to_char)
4875 (string_make_multibyte, string_to_multibyte)
4876 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4877 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4878 (substring_both, Fdelete, internal_equal, Ffillarray)
4879 (Fclear_string, mapcar1)
4880 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4881 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4882 (larger_vector, make_hash_table, maybe_resize_hash_table)
4883 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4884 (Fmaphash, secure_hash):
4885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4886 (concat): Check for string index and length overflow.
4887 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4888 (Frequire):
4889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4890 (larger_vector): New API (vec, incr_min, size_max) replaces old
4891 one (vec, new_size, init). This catches size overflow.
4892 INIT was removed because it was always Qnil.
4893 All callers changed.
4894 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4895 the upper bound on a hash table index size.
4896 (make_hash_table, maybe_resize_hash_table): Use it.
4897 (secure_hash): Computer start_byte and end_byte only after
4898 they're known to be in ptrdiff_t range.
4899 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4900 (Ffont_get_glyphs, Ffont_at):
4901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4902 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4903 (Flist_fonts, Fopen_font):
4904 Don't assume fixnum can fit in int.
4905 (check_gstring): Don't assume index can fit in int.
4906 (font_match_p): Check that fixnum is a character, not a nonnegative
4907 fixnum, since the later code needs to stuff it into an int.
4908 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4909 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4910 conversion overflow issues.
4911 (Fopen_font): Check for integer out of range.
4912 (Ffont_get_glyphs): Don't assume index can fit in int.
4913 * font.h: Adjust decls to match defn changes elsewhere.
4914 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4915 integer overflow.
4916 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4917 printmax_t, where ptrdiff_t is wide enough.
4918 (Finternal_char_font):
4919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4920 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4921 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4922 (Fset_frame_position, x_set_frame_parameters)
4923 (x_set_line_spacing, x_set_border_width)
4924 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4925 Check that fixnums are in proper range for system types.
4926 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4928 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4929 Use SAFE_ALLOCA_LISP, not alloca.
4930 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4931 intptr_t is wide enough.
4932 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4933 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4934 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4935 Check for fixnum out of range.
4936 * ftfont.c (ftfont_list): Don't assume index fits in int.
4937 Check that fixnums are in proper range for system types.
4938 (ftfont_shape_by_flt):
4939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4940 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4942 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4943 Check that fixnums are in proper range for system types.
4944 * gnutls.h: Adjust decls to match defn changes elsewhere.
4945 * gtkutil.c (xg_dialog_run):
4946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4947 (update_frame_tool_bar):
4948 Check that fixnums are in proper range for system types.
4949 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4950 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4951 * indent.c (last_known_column, last_known_column_point):
4952 (current_column_bol_cache):
4953 (skip_invisible, current_column, check_display_width):
4954 (check_display_width, scan_for_column, current_column_1)
4955 (Findent_to, Fcurrent_indentation, position_indentation)
4956 (indented_beyond_p, Fmove_to_column, compute_motion):
4957 (Fcompute_motion, Fvertical_motion):
4958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4959 (last_known_column_modified): Use EMACS_INT, not int.
4960 (check_display_width):
4961 (Fcompute_motion):
4962 Check that fixnums and floats are in proper range for system types.
4963 (compute_motion): Don't assume index or fixnum fits in int.
4964 (compute_motion, Fcompute_motion):
4965 Use int, not EMACS_INT, when it is wide enough.
4966 (vmotion): Omit local var start_hpos that is always 0; that way
4967 we don't need to worry about overflow in expressions involving it.
4968 * indent.h: Adjust decls to match defn changes elsewhere.
4969 (struct position):
4970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4971 Use int, not EMACS_INT, where int is wide enough.
4972 Remove unused members ovstring_chars_done and tab_offset;
4973 all uses removed.
4974 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4975 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4976 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4977 (make_gap, copy_text, insert, insert_and_inherit)
4978 (insert_before_markers, insert_before_markers_and_inherit)
4979 (insert_1, count_combining_before, count_combining_after)
4980 (insert_1_both, insert_from_string)
4981 (insert_from_string_before_markers, insert_from_string_1)
4982 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4983 (adjust_after_replace, adjust_after_insert, replace_range)
4984 (replace_range_2, del_range, del_range_1, del_range_byte)
4985 (del_range_both, del_range_2, modify_region)
4986 (prepare_to_modify_buffer, signal_before_change)
4987 (signal_after_change, Fcombine_after_change_execute):
4988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4989 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4990 (balance_an_interval, split_interval_right, split_interval_left)
4991 (find_interval, next_interval, update_interval)
4992 (adjust_intervals_for_insertion, delete_node, delete_interval)
4993 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4994 (static_offset_intervals, offset_intervals)
4995 (merge_interval_right, merge_interval_left, make_new_interval)
4996 (graft_intervals_into_buffer, temp_set_point_both)
4997 (temp_set_point, set_point, adjust_for_invis_intang)
4998 (set_point_both, move_if_not_intangible, get_property_and_range)
4999 (get_local_map, copy_intervals, copy_intervals_to_string)
5000 (compare_string_intervals, set_intervals_multibyte_1):
5001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5002 * intervals.h: Adjust decls to match defn changes elsewhere.
5003 (struct interval):
5004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5005 * keyboard.c (this_command_key_count, this_single_command_key_start)
5006 (before_command_key_count, before_command_echo_length, echo_now)
5007 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
5008 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
5009 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
5010 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
5011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5012 (last_non_minibuf_size, last_point_position, echo_truncate)
5013 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
5014 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
5015 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
5016 (stuff_buffered_input):
5017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5018 (last_auto_save, command_loop_1, read_char):
5019 Use EMACS_INT, not int, to avoid integer overflow.
5020 (record_char): Avoid overflow in total_keys computation.
5021 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
5022 * keyboard.h: Adjust decls to match defn changes elsewhere.
5023 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
5024 (Fkey_description, Fdescribe_vector, Flookup_key):
5025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5026 (click_position): New function, to check that positions are in range.
5027 (Fcurrent_active_maps):
5028 (describe_command):
5029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5030 (Faccessible_keymaps, Fkey_description):
5031 (preferred_sequence_p):
5032 Don't assume fixnum can fit into int.
5033 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
5034 Check for integer overflow in size calculations.
5035 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
5036 avoid mishandling large integers.
5037 * lisp.h: Adjust decls to match defn changes elsewhere.
5038 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
5039 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
5040 (struct Lisp_Marker):
5041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5042 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
5043 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
5044 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
5045 All callers changed.
5046 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
5047 Assume the arg has valid form, since it always does.
5048 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
5049 unsigned integer system type.
5050 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
5051 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
5052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5053 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
5054 (duration_to_sec_usec): New decl.
5055 * lread.c (read_from_string_index, read_from_string_index_byte)
5056 (read_from_string_limit, readchar, unreadchar, openp)
5057 (read_internal_start, read1, oblookup):
5058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5059 (Fload, readevalloop, Feval_buffer, Feval_region):
5060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5061 (openp): Check for out-of-range argument to 'access'.
5062 (read1): Use int, not EMACS_INT, where int is wide enough.
5063 Don't assume fixnum fits into int.
6efdadfd 5064 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
5065 (read_filtered_event): Use duration_to_sec_usec
5066 to do proper overflow checking on durations.
d311d28c
PE
5067 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
5068 in size calculation.
5069 (Fexecute_kbd_macro):
5070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5071 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
5072 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
5073 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
5074 (set_marker_both, set_marker_restricted_both, marker_position)
5075 (marker_byte_position, Fbuffer_has_markers_at):
5076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5077 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 5078 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
5079 It now merely ensures that the menu is large enough, without
5080 necessarily growing it, as this avoids some integer overflow issues.
5081 All callers changed.
5082 (keymap_panes, parse_single_submenu, Fx_popup_menu):
5083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5084 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
5085 Use SAFE_ALLOCA_LISP, not alloca.
5086 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
5087 to EMACS_INT. Check that fixnums are in proper range for system types.
5088 * minibuf.c (minibuf_prompt_width, string_to_object)
5089 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
5090 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
5091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5092 (get_minibuffer, read_minibuf_unwind):
5093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5094 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
5095 this simplifies overflow checking. All callers changed.
5096 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
5097 (Ftest_completion):
5098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5099 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
5100 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
5101 Check that fixnums are in proper range for system types.
5102 (Fx_create_frame, Fx_show_tip):
5103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5104 * nsfont.m (ns_findfonts, nsfont_list_family):
5105 Don't assume fixnum fits in long.
5106 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
5107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5108 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
5109 wide enough.
17fdb222 5110 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
5111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5112 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
5113 (PRINTDECLARE, PRINTPREPARE):
5114 (strout, print_string):
5115 (print, print_preprocess, print_check_string_charset_prop)
5116 (print_object):
5117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5118 (PRINTDECLARE):
5119 (temp_output_buffer_setup, Fprin1_to_string, print_object):
5120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5121 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 5122 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 5123 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
5124 (print_error_message): Use SAFE_ALLOCA, not alloca.
5125 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
5126 (print_depth, new_backquote_output, print_number_index):
5127 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
5128 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
5129 (Fset_process_window_size, Fformat_network_address)
5130 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 5131 (sigchld_handler):
d311d28c 5132 Check that fixnums are in proper range for system types.
d44287d4 5133 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
5134 Check for process-ids out of pid_t range rather than relying on
5135 undefined behavior.
e4d81efc 5136 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
5137 (Fformat_network_address, read_process_output, send_process)
5138 (Fprocess_send_region, status_notify):
5139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5140 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
5141 (wait_reading_process_output, read_process_output, exec_sentinel):
5142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5143 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
5144 (Faccept_process_output): Use duration_to_sec_usec to do proper
5145 overflow checking on durations.
dde14581
PE
5146 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
5147 Don't assume pid_t fits in int.
02481186
PE
5148 * process.h (struct Lisp_Process): Members tick and update_tick
5149 are now of type EMACS_INT, not int.
b62b53e8
PE
5150 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
5151 configured --with-wide-int.
d311d28c
PE
5152 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
5153 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
5154 * search.c (looking_at_1, string_match_1):
5155 (fast_string_match, fast_c_string_match_ignore_case)
5156 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
5157 (scan_newline, find_before_next_newline, search_command)
5158 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
5159 (set_search_regs, wordify):
5160 (Freplace_match):
5161 (Fmatch_data):
5162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5163 (string_match_1, search_buffer, set_search_regs):
5164 (Fmatch_data):
5165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5166 (wordify): Check for overflow in size calculation.
5167 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
5168 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
5169 Check that fixnums are in proper range for system types.
5170 * sound.c (struct sound_device)
5171 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
5172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5173 (Fplay_sound_internal):
5174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 5175 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
5176 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
5177 (Fparse_partial_sexp):
5178 Don't assume fixnums can fit in int.
5179 (struct lisp_parse_state, find_start_pos, find_start_value)
5180 (find_start_value_byte, find_start_begv)
5181 (update_syntax_table, char_quoted, dec_bytepos)
5182 (find_defun_start, prev_char_comend_first, back_comment):
5183 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
5184 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
5185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5186 (Finternal_describe_syntax_value): Check that match_lisp is a
5187 character, not an integer, since the code stuffs it into int.
5188 (scan_words, scan_sexps_forward):
5189 Check that fixnums are in proper range for system types.
5190 (Fforward_word):
5191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5192 (scan_sexps_forward):
5193 Use CHARACTERP, not INTEGERP, since the value must fit into int.
5194 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
5195 * syntax.h: Adjust decls to match defn changes elsewhere.
5196 (struct gl_state_s):
5197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
5198 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
5199 MOST_POSITIVE_FIXNUM.
d311d28c
PE
5200 * sysdep.c (wait_for_termination_1, wait_for_termination)
5201 (interruptible_wait_for_termination, mkdir):
5202 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
5203 (emacs_read, emacs_write):
5204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
5205 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
5206 and double all fit in int.
d311d28c
PE
5207 * term.c (set_tty_color_mode):
5208 Check that fixnums are in proper range for system types.
5209 * termhooks.h (struct input_event):
5210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5211 * textprop.c (validate_interval_range, interval_of)
5212 (Fadd_text_properties, set_text_properties_1)
5213 (Fremove_text_properties, Fremove_list_of_text_properties)
5214 (Ftext_property_any, Ftext_property_not_all)
5215 (copy_text_properties, text_property_list, extend_property_ranges)
5216 (verify_interval_modification):
5217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5218 (Fnext_single_char_property_change)
5219 (Fprevious_single_char_property_change):
5220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
5221 (copy_text_properties):
5222 Check for integer overflow in index calculation.
d311d28c
PE
5223 * undo.c (last_boundary_position, record_point, record_insert)
5224 (record_delete, record_marker_adjustment, record_change)
5225 (record_property_change):
5226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5227 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
5228 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5229 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5230 (Fx_hide_tip, Fx_file_dialog):
5231 * w32menu.c (set_frame_menubar):
5232 Use ptrdiff_t, not int, for consistency with rest of code.
5233 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
5234 (select_window, Fdelete_other_windows_internal)
5235 (window_scroll_pixel_based, window_scroll_line_based)
5236 (Frecenter, Fset_window_configuration):
5237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5238 (Fset_window_hscroll, run_window_configuration_change_hook)
5239 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 5240 (Fscroll_other_window, Frecenter):
d311d28c
PE
5241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5242 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
5243 Don't assume fixnum fits in int.
5244 (Fset_window_scroll_bars):
5245 Check that fixnums are in proper range for system types.
5246 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
5247 (string_pos, c_string_pos, number_of_chars, init_iterator)
5248 (in_ellipses_for_invisible_text_p, init_from_display_pos)
5249 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
5250 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
5251 (face_before_or_after_it_pos, handle_invisible_prop)
5252 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
5253 (display_prop_intangible_p, string_buffer_position_lim)
5254 (string_buffer_position, handle_composition_prop, load_overlay_strings)
5255 (get_overlay_strings_1, get_overlay_strings)
5256 (iterate_out_of_display_property, forward_to_next_line_start)
5257 (back_to_previous_visible_line_start, reseat, reseat_to_string)
5258 (get_next_display_element, set_iterator_to_next)
5259 (get_visually_first_element, compute_stop_pos_backwards)
5260 (handle_stop_backwards, next_element_from_buffer)
5261 (move_it_in_display_line_to, move_it_in_display_line)
5262 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5263 (add_to_log, message_dolog, message_log_check_duplicate)
5264 (message2, message2_nolog, message3, message3_nolog
5265 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
5266 (current_message_1, truncate_echo_area, truncate_message_1)
5267 (set_message, set_message_1, store_mode_line_noprop)
5268 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
5269 (text_outside_line_unchanged_p, check_point_in_composition)
5270 (reconsider_clip_changes)
5271 (redisplay_internal, set_cursor_from_row, try_scrolling)
5272 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
5273 (redisplay_window, find_last_unchanged_at_beg_row)
5274 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
5275 (trailing_whitespace_p, find_row_edges, display_line)
5276 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
5277 (display_mode_element, store_mode_line_string)
5278 (pint2str, pint2hrstr, decode_mode_spec)
5279 (display_count_lines, display_string, draw_glyphs)
5280 (x_produce_glyphs, x_insert_glyphs)
5281 (rows_from_pos_range, mouse_face_from_buffer_pos)
5282 (fast_find_string_pos, mouse_face_from_string_pos)
5283 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5285 (safe_call, init_from_display_pos, handle_fontified_prop)
5286 (handle_single_display_spec, load_overlay_strings)
5287 (with_echo_area_buffer, setup_echo_area_for_printing)
5288 (display_echo_area, echo_area_display)
5289 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
5290 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
5291 (redisplay_window, dump_glyph_row, display_mode_line)
5292 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 5293 (handle_display_spec, display_prop_string_p):
d311d28c
PE
5294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5295 (handle_single_display_spec, build_desired_tool_bar_string)
5296 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
5297 (get_specified_cursor_type):
5298 Check that fixnums are in proper range for system types.
5299 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
5300 (Flookup_image_map):
5301 Don't assume fixnums fit in int.
5302 (compare_overlay_entries):
5303 Avoid mishandling comparisons due to subtraction overflow.
5304 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
5305 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
5306 (handle_tool_bar_click):
5307 Use int, not unsigned, since we prefer signed and the signedness
5308 doesn't matter here.
5309 (get_next_display_element, next_element_from_display_vector):
5310 Use int, not EMACS_INT, when int is wide enough.
5311 (start_hourglass): Use duration_to_sec_usec to do proper
5312 overflow checking on durations.
5313 * xfaces.c (Fbitmap_spec_p):
5314 Check that fixnums are in proper range for system types.
5315 (compare_fonts_by_sort_order):
5316 Avoid mishandling comparisons due to subtraction overflow.
5317 (Fx_family_fonts, realize_basic_faces):
5318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5319 (Fx_family_fonts):
5320 Don't assume fixnum fits in int.
5321 Use SAFE_ALLOCA_LISP, not alloca.
5322 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
5323 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
5324 (face_at_buffer_position, face_for_overlay_string)
5325 (face_at_string_position):
5326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5327 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
5328 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
5329 (Fx_show_tip):
5330 Check that fixnums are in proper range for system types.
5331 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5332 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
5333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5334 (Fx_change_window_property): Don't assume fixnums fit in int.
5335 * xfont.c (xfont_chars_supported):
5336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5337 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
5338 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
5339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5340 * xml.c (parse_region):
5341 * xrdb.c (magic_file_p):
5342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5343 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
5344 (x_get_local_selection, x_reply_selection_request)
5345 (x_handle_selection_request, wait_for_property_change):
5346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5347 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
5348 short is wide enough.
5349 (x_send_client_event): Don't assume fixnum fits in int.
5350 * xterm.c (x_x_to_emacs_modifiers):
5351 Don't assume EMACS_INT overflows nicely into int.
5352 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
5353 may come from Lisp.
5354 (handle_one_xevent): NATNUMP can eval its arg twice.
5355 (x_connection_closed):
5356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5357 * xterm.h: Adjust decls to match defn changes elsewhere.
5358 (struct scroll_bar): Use struct vectorlike_header
5359 rather than rolling our own approximation.
5360 (SCROLL_BAR_VEC_SIZE): Remove; not used.
5361
c6574eb5
GM
53622012-05-25 Glenn Morris <rgm@gnu.org>
5363
5364 * lisp.mk (lisp): Update for more files being compiled now.
5365
e8d32c7e
SM
53662012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
5367
48def666
SM
5368 * lread.c: Remove `read_pure' which makes no difference.
5369 (read_pure): Remove var.
5370 (unreadpure): Remove function.
5371 (readevalloop): Don't call read_list with -1 flag.
5372 (read1, read_vector): Don't test read_pure any more.
5373 (read_list): Simplify.
5374
e8d32c7e
SM
5375 * fileio.c, character.h: Minor style tweaks.
5376
4b2addb7
DA
53772012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
5378
5379 * window.h (clip_changed): Remove useless declaration.
5380
584461b2
JB
53812012-05-22 Juanma Barranquero <lekktu@gmail.com>
5382
5383 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
5384 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
5385
34374650
PE
53862012-05-22 Paul Eggert <eggert@cs.ucla.edu>
5387
5388 Remove src/m/*.
5389 This directory predates autoconf and is no longer needed nowadays.
5390 Move its few remaining bits of functionality to where they're needed.
5391 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
5392 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
5393 * m/template.h: Remove.
5394 * Makefile.in (M_FILE): Remove. All uses removed.
5395 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
5396 * lisp.h (USE_LSB_TAG):
5397 * mem-limits.h (EXCEEDS_LISP_PTR):
5398 Use VAL_MAX, not VALBITS, in #if.
5399 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5400 (EMACS_UINT): Define unconditionally now.
5401 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5402 (BITS_PER_EMACS_INT): New constants, replacing
5403 what used to be in config.h, but not useful in #if.
5404 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5405 define them any more.
5406 (VAL_MAX): New macro.
5407 (VALMASK): Use it.
5408 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5409 BITS_PER_EMACS_INT, in #if.
5410 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5411 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5412 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5413 * s/ms-w32.h (DATA_START):
5414 Move here from removed file m/intel386.h.
5415 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5416 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5417
261cb4bb
PE
54182012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5419
5420 Assume C89 or later.
5421 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5422 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5423 (xrealloc):
5424 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5425 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5426 * textprop.c, tparam.c (NULL): Remove.
5427 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5428 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5429 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5430 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5431 * xterm.c (input_signal_count): Assume volatile works.
5432
ff23cd9f
KB
54332012-05-21 Ken Brown <kbrown@cornell.edu>
5434
5435 * xgselect.c (xg_select): Fix first argument in call to 'select'
5436 (bug#11508).
5437
1b170bc6
KB
54382012-05-20 Ken Brown <kbrown@cornell.edu>
5439
5440 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5441 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5442
b2f4d39f
KB
54432012-05-19 Ken Brown <kbrown@cornell.edu>
5444
5445 * xfns.c (x_in_use): Remove `static' qualifier.
5446 * xterm.h (x_in_use): Declare.
5447 * xgselect.c: Include xterm.h.
5448 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5449 and `display_arg' (bug#9754).
5450
003fdae2
PE
54512012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5452
9232a6d9
PE
5453 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5454
003fdae2
PE
5455 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5456 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5457
784b56e2
EZ
54582012-05-18 Eli Zaretskii <eliz@gnu.org>
5459
5460 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5461
5462 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5463 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5464
5465 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5466 reference to image_cache->refcount.
5467 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5468
a0a79cde
JL
54692012-05-17 Juri Linkov <juri@jurta.org>
5470
5471 * search.c (Fword_search_regexp, Fword_search_backward)
5472 (Fword_search_forward, Fword_search_backward_lax)
5473 (Fword_search_forward_lax): Move functions to isearch.el
5474 (bug#10145, bug#11381).
5475
b0572523
PE
54762012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5477
5478 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5479
9660f5fc
SM
54802012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5481
5482 * lread.c (init_obarray): Declare Qt and Qnil as special.
5483
4374de83
GM
54842012-05-14 Glenn Morris <rgm@gnu.org>
5485
5486 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5487 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5488
dc44c39a
PE
54892012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5490
078c97cb
PE
5491 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5492
dc44c39a
PE
5493 * unexaix.c: Port to more-recent AIX compilers.
5494 (report_error, report_error_1, make_hdr, copy_sym)
5495 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5496 Make arguments const char *, not char *, to avoid violations of C
5497 standard and to fix some AIX warnings reported by Gilles Pion.
5498
e18afed7 54992012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5500
5501 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5502 already have overlays loaded.
5503 (handle_single_display_spec): Before returning without displaying
5504 fringe bitmap, synchronize the bidi iterator with the main display
5505 iterator, by calling iterate_out_of_display_property.
5506 (iterate_out_of_display_property): Detect buffer iteration by
5507 testing that it->string is a Lisp string.
5508 (get_next_display_element): When the current object is exhausted,
5509 and there's something on it->stack, call set_iterator_to_next to
5510 proceed with what's on the stack, instead of returning zero.
5511 (set_iterator_to_next): If called at the end of a Lisp string,
5512 proceed to consider_string_end without incrementing string
5513 position. Don't increment display vector index past the end of
5514 the display vector. (Bug#11417)
c8fb9dc6
EZ
5515 (pos_visible_p): Don't report a position visible when move_it_to
5516 stopped at the last line of window, which happens to be scanned
5517 backwards by the bidi iteration. (Bug#11464)
ac268e67 5518
e18afed7 55192012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5520
5521 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5522 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5523 are on a TTY, and thus unable to display on the fringes.
5524 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5525 so we need to signal to the caller that this is a "replacing"
5526 display spec. This fixes display when the spec is invalid or we
5527 are on a TTY.
5528
e18afed7 55292012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5530
5531 * unexaix.c (make_hdr): Fix typo in prototype.
5532 This bug broke the build on AIX. Problem reported by Gilles Pion.
5533
9d0a235a
MA
55342012-05-14 Michael Albinus <michael.albinus@gmx.de>
5535
5536 * keyboard.c (kbd_buffer_get_event): Read special events also in
5537 batch mode. (Bug#11415)
5538
9e6b06ed
GM
55392012-05-12 Glenn Morris <rgm@gnu.org>
5540
5541 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5542
c1a1d7a3
EZ
55432012-05-12 Eli Zaretskii <eliz@gnu.org>
5544
5545 * lisp.mk (lisp): Add newcomment.elc.
5546
3fe7cdc8
GM
55472012-05-12 Glenn Morris <rgm@gnu.org>
5548
5549 * Makefile.in (MKDIR_P): New, set by configure.
5550 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5551
53f7d2c0
PE
55522012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5553
5554 Remove unused function hourglass_started.
5555 * dispextern.h (hourglass_started):
5556 * w32fns.c (hourglass_started):
5557 * xdisp.c (hourglass_started): Remove.
5558
75aafb17
JB
55592012-05-10 Juanma Barranquero <lekktu@gmail.com>
5560
5561 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5562 Update dependencies.
5563
12959e8e
PE
55642012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5565
97107e2e
PE
5566 * xgselect.c (xg_select): Put maxfds+1 into a var.
5567 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5568
12959e8e
PE
5569 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5570
836d29b3
DA
55712012-05-10 Dave Abrahams <dave@boostpro.com>
5572
5573 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5574 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5575
5cb67954
MA
55762012-05-09 Michael Albinus <michael.albinus@gmx.de>
5577
5578 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5579 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5580 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5581 Initialize xd_registered_buses.
5582
3478ec45
PE
55832012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5584
b263a6b0
PE
5585 Untag more efficiently if USE_LSB_TAG.
5586 This is based on a proposal by YAMAMOTO Mitsuharu in
5587 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5588 For an admittedly artificial (nth 8000 longlist) benchmark on
5589 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5590 Emacs's overall text size by 1%.
5591 * lisp.h (XUNTAG): New macro.
5592 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5593 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5594 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5595 * eval.c (Fautoload):
5596 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5597 * frame.h (XFRAME): Use XUNTAG.
5598
3478ec45
PE
5599 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5600 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5601 Remove unportable assumptions about print widths of types like
5602 dbus_uint32_t.
5603 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5604 intptr_t when converting between pointer and integer, to avoid GCC
5605 warnings about wrong width.
5606
666b903b 56072012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5608
5609 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5610 stack for each reader_thread, instead of defaulting to 8MB
5611 determined by the linker. This avoids failures in creating
5612 subprocesses on Windows 7, see the discussion in this thread:
5613 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5614
b120cc17
JC
56152012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5616
5617 Fix up display of the *Minibuf-0* buffer in the mini window.
5618 * keyboard.c (read_char): Don't clear the echo area if there's no
5619 message to clear.
5620 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5621 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5622
9a4b36f8
MA
56232012-05-07 Michael Albinus <michael.albinus@gmx.de>
5624
5625 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5626 batch mode.
5627
e5f9458f
CY
56282012-05-06 Chong Yidong <cyd@gnu.org>
5629
5630 * lisp.mk (lisp): Update.
5631
eceeb5fc 56322012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5633
5634 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5635
71873e2b
SM
56362012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5637
5638 * data.c (PUT_ERROR): New macro.
5639 (syms_of_data): Use it. Add new error type `user-error'.
5640 * undo.c (user_error): New function.
5641 (Fprimitive_undo): Use it.
5642 * print.c (print_error_message): Adjust print style for `user-error'.
5643 * keyboard.c (user_error): New function.
5644 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5645
ab0fa4e4
PE
56462012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5647
5648 Do not limit current-time-string to years 1000..9999.
5649 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5650 (Fcurrent_time_string): Support any year that is supported by the
5651 underlying localtime representation. Don't use asctime, as it
5652 has undefined behavior for years outside the range -999..9999.
5653
7ed806a7
PE
56542012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5655
5656 Fix race conditions involving setenv, gmtime, localtime, asctime.
5657 Without this fix, interrupts could mess up code that uses these
5658 nonreentrant functions, since setting TZ invalidates existing
5659 tm_zone or tzname values, and since most of these functions return
5660 pointers to static storage.
5661 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5662 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5663 Grow the critical sections to include not just invoking
5664 localtime/gmtime, but also accessing these functions' results
5665 including their tm_zone values if any, and any related TZ setting.
5666 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5667 so that the struct tm is saved in the critical section.
5668 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5669 motivated by the fact that memory allocation needs to be outside
5670 the critical section.
5671
0c16dfed
DA
56722012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5673
5674 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5675 with RESET_INTERVAL.
5676
5677 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5678 Remove duplicated buffer name initialization.
5679
3f83ace8
JM
56802012-05-02 Jim Meyering <jim@meyering.net>
5681
5682 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5683
c7b8541e
JM
5684 * xfns.c (x_window): Use xstrdup (Bug#11375).
5685
90207a15 56862012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5687
5688 * xdisp.c (pos_visible_p): If already at a newline from the
5689 display string before the 'while' loop, don't walk back the glyphs
5690 from it3.glyph_row. Solves assertion violation when the display
5691 string begins with a newline (egg.el). (Bug#11367)
5692
b593d6a9
AH
56932012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5694
5695 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5696 Move to simple.el.
5697
4737362e
GM
56982012-05-01 Glenn Morris <rgm@gnu.org>
5699
99cf43f9
GM
5700 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5701 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5702 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5703 All were removed before 23.1.
5704
9311dcff
GM
5705 * dispnew.c: Remove HAVE_LIBNCURSES test;
5706 it is always true on relevant platforms.
5707
4d5c6349
GM
5708 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5709 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5710
4737362e
GM
5711 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5712
74dd3a6b
AS
57132012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5714
5715 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5716 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5717 Remove.
5718
13c379ee
PE
57192012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5720
5721 Do not avoid creating empty evaporating overlays (Bug#9642).
5722 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5723 That is, do not delete an evaporating overlay if it becomes
5724 empty after its bounds are adjusted to fit within its buffer.
5725 This fix caused other problems, and I'm reverting it until we get
5726 to the bottom of them.
5727
a8e7d6d7 57282012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5729
5730 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5731
a8e7d6d7 57322012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5733
5734 * xdisp.c (pos_visible_p): If the window start position is beyond
5735 ZV, start the display from buffer beginning. Prevents assertion
5736 violation in init_iterator when the minibuffer window is scrolled
5737 via the scroll bar.
5738
5739 * window.c (window_scroll_pixel_based): Likewise.
5740
a8e7d6d7 57412012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5742
5743 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5744
a8e7d6d7 57452012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5746
5747 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5748 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5749
a8e7d6d7 57502012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5751
b593d6a9
AH
5752 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5753 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5754
1c6900d9
EZ
57552012-04-26 Eli Zaretskii <eliz@gnu.org>
5756
4c3fa1d9
EZ
5757 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5758 display element, check also the underlying string or buffer
5759 character. (Bug#11341)
5760
1c6900d9
EZ
5761 * w32menu.c: Include w32heap.h.
5762 (add_menu_item): If the call to AppendMenuW (via
5763 unicode_append_menu) fails, disable Unicode menus only if we are
5764 running on Windows 9X/Me.
5765
42bf8205
AS
57662012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5767
5768 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5769 (xgetint): Add missing shift for LSB tags.
5770
b1bac16e
MR
57712012-04-24 Martin Rudalics <rudalics@gmx.at>
5772
5773 * keyboard.c (read_char): Don't wipe echo area for select window
5774 events: These might get delayed via `mouse-autoselect-window'
5775 (Bug#11304).
5776
d69621cc
JB
57772012-04-24 Juanma Barranquero <lekktu@gmail.com>
5778
5779 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5780 manipulation of :loaded-from data.
5781
02fd101b
JB
57822012-04-23 Juanma Barranquero <lekktu@gmail.com>
5783
5784 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5785 now a cons (bug#11311).
5786
888bec30
PE
57872012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5788
89a438bd
PE
5789 Do not create empty overlays with the evaporate property (Bug#9642).
5790 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5791 if it becomes empty after its bounds are adjusted to fit within
5792 its buffer. Without this fix, in a nonempty buffer (let ((o
5793 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5794 yields an empty overlay that has the evaporate property, which is
5795 not supposed to happen.
5796
1068fe4d
PE
5797 Fix minor GTK3 problems found by static checking.
5798 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5799 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5800 (struct _EmacsFixedClass, emacs_fixed_get_type):
5801 Move decls here from emacsgtkfixed.h, since they needn't be public.
5802 (emacs_fixed_get_type): Now static.
5803 (emacs_fixed_class_init): Omit unused local.
5804 (emacs_fixed_child_type): Remove; unused.
5805 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5806 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5807 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5808 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5809 (EMACS_FIXED_GET_CLASS): Remove; unused.
5810 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5811
888bec30
PE
5812 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5813 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5814
de85e130
PE
58152012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5816
d0baac98 5817 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5818 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5819 (__malloc_size_t, __malloc_ptrdiff_t):
5820 Remove. All uses removed, replaced by the definiens if needed,
5821 since we can assume C89 or better now.
5822 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5823 (protect_malloc_state, align, get_contiguous_space)
5824 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5825 (malloc_atfork_handler_child, malloc_enable_thread)
5826 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5827 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5828 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5829 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5830 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5831 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5832 Define using prototypes, not old style.
5833 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5834 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5835 (align): Don't assume that signed integer overflow wraps around.
5836 Omit unused local var.
5837 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5838 (_free_internal_nolock, memalign, mallochook, reallochook):
5839 Omit no-longer-needed casts.
5840 (valloc): Use getpagesize, not __getpagesize.
5841 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5842 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5843
de85e130
PE
5844 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5845
dcbf5805
MA
58462012-04-22 Michael Albinus <michael.albinus@gmx.de>
5847
5848 Move functions from C to Lisp. Make non-blocking method calls
5849 the default. Implement further D-Bus standard interfaces.
5850
5851 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5852 (QCdbus_request_name_allow_replacement)
5853 (QCdbus_request_name_replace_existing)
5854 (QCdbus_request_name_do_not_queue)
5855 (QCdbus_request_name_reply_primary_owner)
5856 (QCdbus_request_name_reply_in_queue)
5857 (QCdbus_request_name_reply_exists)
5858 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5859 (QCdbus_registered_serial, QCdbus_registered_method)
5860 (QCdbus_registered_signal): New Lisp objects.
5861 (XD_DEBUG_MESSAGE): Use sizeof.
5862 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5863 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5864 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5865 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5866 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5867 (xd_signature, xd_append_arg): Allow float for integer types.
5868 (xd_get_connection_references): New function.
b593d6a9
AH
5869 (xd_get_connection_address): Rename from xd_initialize.
5870 Return cached address.
dcbf5805
MA
5871 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5872 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5873 level.
5874 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5875 Return number of refcounts.
dcbf5805
MA
5876 (Fdbus_get_unique_name): Make stronger parameter check.
5877 (Fdbus_message_internal): New defun.
5878 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5879 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5880 (Fdbus_send_signal, Fdbus_register_service)
5881 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5882 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5883 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5884 (Vdbus_compiled_version, Vdbus_runtime_version)
5885 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5886 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5887 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5888 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5889 Adapt docstring.
dcbf5805 5890
52828e02
PE
58912012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5892
da05bc4c
PE
5893 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5894 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5895 Do not assume ptrdiff_t is the same width as 'int'.
5896
52828e02
PE
5897 * alloc.c: Handle unusual debugging option combinations.
5898 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5899 since the two debugging options are incompatible.
5900 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5901 is defined.
5902 (mem_init, mem_insert, mem_insert_fixup):
5903 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5904 (NEED_MEM_INSERT): Remove; no longer needed.
5905
f01769f9
LL
59062012-04-22 Leo Liu <sdl.web@gmail.com>
5907
5908 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5909
5790543d
PE
59102012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5911
5912 * sysdep.c [__FreeBSD__]: Minor cleanups.
5913 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5914 Use Emacs indenting style more consistently. Avoid some casts.
5915 Use 'double' consistently rather than mixing 'float' and 'double'.
5916
b91b7e4d
EW
59172012-04-21 Eduard Wiebe <usenet@pusto.de>
5918
b593d6a9
AH
5919 * sysdep.c (list_system_processes, system_process_attributes):
5920 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5921
6114eb15
AS
59222012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5923
5924 * lisp.mk (lisp): Update.
5925
2f38dff7
PE
59262012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5927
5928 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5929 It is never used otherwise.
5930
4ae29f89
SM
59312012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5932
5933 * print.c (print_preprocess): Only check print_depth if print-circle
5934 is nil.
5935 (print_object): Check for cycles even when print-circle is nil and
5936 print-gensym is t, but only check print_depth if print-circle is nil.
5937
f30d612a
CY
59382012-04-20 Chong Yidong <cyd@gnu.org>
5939
5940 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5941 set the status to "failed" and ensure that sentinel is run.
5942
c07a4c0b 59432012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5944
5945 * process.c (Fset_process_inherit_coding_system_flag)
5946 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5947 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5948
c07a4c0b 59492012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5950
5951 * xdisp.c (string_buffer_position_lim): Limit starting position to
5952 BEGV.
5953 (set_cursor_from_row): If called for a mode-line or header-line
5954 row, return zero immediately.
5955 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5956 farther than the first row after the header line, if any.
5957 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5958 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5959
c07a4c0b 59602012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5961
4ae29f89
SM
5962 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5963 (bug#11238).
ad3a2b41 5964
c07a4c0b 59652012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 59662012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5967
5968 configure: new option --enable-gcc-warnings (Bug#11207)
5969 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5970 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5971 (ALL_CFLAGS): Use new macros rather than old.
5972 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5973 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5974 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5975 -Wunused-result, -Wunused-variable. This should go away once
5976 the Emacs and Gnulib regex code is merged.
5977 (xmalloc, xrealloc): Now static.
5978
aba027e8
PE
59792012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5980
5981 * dired.c (Fsystem_groups): Remove unused local.
5982
e5a36063
GM
59832012-04-17 Glenn Morris <rgm@gnu.org>
5984
5985 * dired.c (Fsystem_users): Doc fix.
5986
316411f0
DA
59872012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5988
5989 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5990 (syms_of_dired): Add them.
5991
9426aba4
PE
59922012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5993
b62a57be
PE
5994 Fix minor alloc.c problems found by static checking.
5995 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5996 New extern decls, to avoid calling undeclared functions.
5997 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5998 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5999 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
6000 (NEED_MEM_INSERT): New macro.
6001 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 6002 Remove one incorrect comment and fix another.
b62a57be 6003
3539f31f
PE
6004 Fix minor ralloc.c problems found by static checking.
6005 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6006 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
6007 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
6008 (r_alloc_sbrk): Now static.
6009
a041960a
PE
6010 Improve ralloc.c interface checking.
6011 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6012 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
6013 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
6014 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
6015 [REL_ALLOC]: ... to here, to check interface.
6016 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
6017 Remove decls. This fixes an "It stinks!".
6018
9426aba4
PE
6019 * alloc.c (which_symbols): Fix alignment issue / type clash.
6020
d55c12ed
AS
60212012-04-15 Andreas Schwab <schwab@linux-m68k.org>
6022
6023 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
6024 (struct Lisp_Misc_Any): Likewise.
6025 (struct Lisp_Free): Likewise.
6026 * alloc.c (union aligned_Lisp_Symbol): Define.
6027 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
6028 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
6029 (union aligned_Lisp_Misc): Define.
6030 (MARKER_BLOCK_SIZE, struct marker_block): Use union
6031 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 6032 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 6033
b948ce8b
PE
60342012-04-14 Paul Eggert <eggert@cs.ucla.edu>
6035
6036 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
6037 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
6038 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
6039 * s/netbsd.h, s/sol2-6.h:
6040 Remove definition of GC_MARK_STACK, since the default now works.
6041 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
6042 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
6043 no longer the default.
6044 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
6045
35dc09a1 60462012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6047
35dc09a1
GM
6048 * lread.c (lisp_file_lexically_bound_p):
6049 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 6050
35dc09a1
GM
60512012-04-14 Eli Zaretskii <eliz@gnu.org>
6052
6053 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
6054 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
6055
60562012-04-14 Jan Djärv <jan.h.d@swipnet.se>
6057
6058 * nsterm.m (constrainFrameRect): Always constrain when there is only
6059 one screen (Bug#10962).
6060
bcd86815
KB
60612012-04-13 Ken Brown <kbrown@cornell.edu>
6062
6063 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
6064
c25df26e
RT
60652012-04-13 Reuben Thomas <rrt@sc3d.org>
6066
6067 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
6068
0fc59f1e
DC
60692012-04-11 Daniel Colascione <dancol@dancol.org>
6070
6071 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
6072 against is gone. It's better to use vfork now so that when Cygwin
6073 gains a new, working vfork, we use it automatically (bug#10398).
6074
de8c03dc
SM
60752012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6076
6077 * window.c (save_window_save): Obey window-point-insertion-type.
6078
2f097256
GM
60792012-04-11 Glenn Morris <rgm@gnu.org>
6080
6081 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
6082
453b951e
SM
60832012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6084
6085 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
6086
75f1671a 60872012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
6088
6089 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
6090 (force_quit_count): New var.
6091 (handle_interrupt): Use it.
6092
2a8ce227
JB
60932012-04-10 Juanma Barranquero <lekktu@gmail.com>
6094
6095 * w32.c (w32_delayed_load): Record the full path of the library
6096 being loaded (bug#10424).
6097
935396c0
GM
60982012-04-09 Glenn Morris <rgm@gnu.org>
6099
05920a43
GM
6100 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
6101 not just in the obarray, before snarfing them. (Bug#11036)
6102
935396c0
GM
6103 * Makefile.in ($(leimdir)/leim-list.el):
6104 Pass EMACS rather than BUILT_EMACS.
6105
a18ecafa
TZ
61062012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
6107
6108 * process.c (make_process):
6109 * process.h: Add integer `gnutls_handshakes_tried' member to
6110 process struct.
6111
6bbef4e5
JC
6112 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
6113 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
6114
6115 * gnutls.c (gnutls_log_function2i): Convenience log function.
6116 (emacs_gnutls_read): Use new log functions,
6117 `gnutls_handshakes_tried' process member, and
6118 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
6119 attempts per process (connection).
6120
b4d3bc10
CY
61212012-04-09 Chong Yidong <cyd@gnu.org>
6122
6123 * eval.c (Fuser_variable_p, user_variable_p_eh)
6124 (lisp_indirect_variable): Functions deleted.
6125 (Fdefvar): Caller changed.
6126
6127 * callint.c (Finteractive, Fcall_interactively):
6128 * minibuf.c (Fread_variable): Callers changed.
6129
70f4d973
EZ
61302012-04-09 Eli Zaretskii <eliz@gnu.org>
6131
6132 * xdisp.c (set_cursor_from_row): If the display string appears in
6133 the buffer at position that is closer to point than the position
6134 after the display string, display the cursor on the first glyph of
6135 the display string. Fixes cursor display when a 'display' text
6136 property immediately follows invisible text. (Bug#11094)
6137
cb3c2e3e
PE
61382012-04-09 Paul Eggert <eggert@cs.ucla.edu>
6139
6140 composite.c: use 'double' consistently
6141 * composite.c (get_composition_id): Use 'double' consistently
6142 instead of converting 'float' to 'double' and vice versa; this is
6143 easier to understand and avoids a GCC warning.
6144
fd06db5d
GM
61452012-04-09 Glenn Morris <rgm@gnu.org>
6146
50fe702a
GM
6147 * Makefile.in: Generate leim-list with bootstrap-emacs, in
6148 preparation for dumping it with emacs. (Bug#4789)
6149 (leimdir): New variable.
6150 ($(leimdir)/leim-list.el): New rule.
6151 (emacs$(EXEEXT)): Depend on leim-list.el.
6152
fd06db5d
GM
6153 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
6154 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
6155 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
6156
55c131ee
AS
61572012-04-08 Andreas Schwab <schwab@linux-m68k.org>
6158
6159 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
6160 proper alignment.
6161
9209588f
JB
61622012-04-07 Juanma Barranquero <lekktu@gmail.com>
6163
6164 * xml.c (init_libxml2_functions) [WINDOWSNT]:
6165 Remove unused local variable.
6166
e3fb2efb
PE
61672012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6168
6169 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
6170 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
6171 (mark_memory): Mark Lisp_Objects only if pointers might hide in
6172 objects, as mark_maybe_pointer will catch them otherwise.
6173 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
6174 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
6175
b5385551
PE
61762012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6177
6178 Fix typo that broke non-Windows builds.
6179 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
6180
9078ead6
EZ
61812012-04-07 Eli Zaretskii <eliz@gnu.org>
6182
6183 Support building on MS-Windows with libxml2.
6184
6185 * makefile.w32-in (OBJ2): Add xml.$(O).
6186 (GLOBAL_SOURCES): Add xml.c.
6187 ($(BLD)/xml.$(O)): New dependency list.
6188
6189 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
6190 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
6191 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
6192 [!WINDOWSNT]: New macros.
6193 (init_libxml2_functions, libxml2_loaded_p): New functions.
6194 (parse_region): Call fn_xmlCheckVersion instead of using the macro
6195 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
6196 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
6197 Calls xmlCleanupParser only if libxml2 was loaded (or statically
6198 linked in).
6bbef4e5
JC
6199 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
6200 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
6201 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
6202
6203 * emacs.c: Don't include libxml/parser.h.
6204 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
6205 xmlCleanupParser directly.
6206
6207 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
6208
3811fdf3
EZ
62092012-04-07 Eli Zaretskii <eliz@gnu.org>
6210
6211 * indent.c (Fvertical_motion): If there is a display string at
6212 point, use it.vpos to compute how many lines to backtrack after
6213 move_it_to point. (Bug#11133)
6214
2f8e16b2
EZ
62152012-04-06 Eli Zaretskii <eliz@gnu.org>
6216
6217 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
6218 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
6219 about subtle differences between FETCH_CHAR* and STRING_CHAR*
6220 macros related to unification of CJK characters. For the details,
6221 see the discussion following the message here:
6222 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
6223
3d439cd1
CY
62242012-04-04 Chong Yidong <cyd@gnu.org>
6225
6226 * keyboard.c (Vdelayed_warnings_list): Doc fix.
6227
8bc53d00
EZ
62282012-04-01 Eli Zaretskii <eliz@gnu.org>
6229
6230 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
6231 instead of alloca. (Bug#11138)
6232
3b0512a3
AS
62332012-04-01 Andreas Schwab <schwab@linux-m68k.org>
6234
6235 * w32menu.c (is_simple_dialog): Properly check lisp types.
6236 (Bug#11141)
6237
8427ddd2
EZ
62382012-03-31 Eli Zaretskii <eliz@gnu.org>
6239
979022ef
EZ
6240 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
6241 position we get to after a call to move_it_to fails the
6242 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
6243 only if we wind up in a string from display property. (Bug#11063)
6244
a6b1c7cc
EZ
6245 * window.c (Fdelete_other_windows_internal): Invalidate the row
6246 and column information about mouse highlight, so that redisplay
6247 restores it after reallocating the glyph matrices. (Bug#7464)
6248
8427ddd2
EZ
6249 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
6250 string comes from a `display' text property, use the buffer
6251 position of that property as if we actually saw that position in
6252 the row's glyphs.
697ba24b
EZ
6253 (move_it_by_lines): Remove the assertion that
6254 "it->current_x == 0 && it->hpos == 0" which can be legitimately
6255 violated when there's a before-string at the beginning of a line.
6256 (Bug#11063)
8427ddd2 6257
65a0a738
EZ
62582012-03-30 Eli Zaretskii <eliz@gnu.org>
6259
6260 * xdisp.c (append_space_for_newline): If the default face was
6261 remapped, use the remapped face for the appended newline.
6262 (extend_face_to_end_of_line): Use the remapped default face for
6263 extending the face to the end of the line.
6264 (display_line): Call extend_face_to_end_of_line when the default
6265 face was remapped. (Bug#11068)
6266
581355cc
EZ
62672012-03-29 Eli Zaretskii <eliz@gnu.org>
6268
6269 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
6270
e8fc049f
SM
62712012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6272
6273 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
6274
4fb9a543
GM
62752012-03-27 Glenn Morris <rgm@gnu.org>
6276
6277 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
6278 Doc fixes.
6279
679910f1
KH
62802012-03-26 Kenichi Handa <handa@m17n.org>
6281
6282 * dispextern.h (struct glyph): Fix previous change. Change the
6283 bit length of glyphless.ch to 25 (Bug#11082).
6284
90d49b7f
CY
62852012-03-26 Chong Yidong <cyd@gnu.org>
6286
6287 * keyboard.c (Vselection_inhibit_update_commands): New variable.
6288 (command_loop_1): Use it; inhibit selection update for
6289 handle-select-window too (Bug#8996).
6290
f514f6f0
FP
62912012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
6292
e8fc049f 6293 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 6294
bf43fa51
KH
62952012-03-25 Kenichi Handa <handa@m17n.org>
6296
6297 * dispextern.h (struct glyph): Change the bit length of
6298 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
6299
8a0c01dd
EZ
63002012-03-24 Eli Zaretskii <eliz@gnu.org>
6301
6302 * s/ms-w32.h (tzname): Include time.h before redirecting to
6303 _tzname. Fixes the MSVC build. (Bug#9960)
6304
7d1c3a76
AS
63052012-03-24 Andreas Schwab <schwab@linux-m68k.org>
6306
8ed79523
AS
6307 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
6308 characters.
6309
7d1c3a76
AS
6310 * xterm.c (XTread_socket): Only modify handling_signal if
6311 !SYNC_INPUT. (Bug#11080)
6312
e99a9b8b
EZ
63132012-03-23 Eli Zaretskii <eliz@gnu.org>
6314
6315 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
6316 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
6317 when fetching a multibyte character consumes more bytes than
6318 CHAR_BYTES returns, due to unification of CJK characters in
6319 string_char. (Bug#11073)
6320
5063c0e1
TN
63212012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
6322
6323 * process.c (wait_reading_process_output): Handle pty disconnect
6324 by refraining from sending oneself a SIGCHLD (bug#10933).
6325
9f851fbd
CY
63262012-03-22 Chong Yidong <cyd@gnu.org>
6327
6328 * dispextern.h (struct it): New member string_from_prefix_prop_p.
6329
5063c0e1 6330 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
6331 Mark string as coming from a prefix property.
6332 (handle_face_prop): Use default face for prefix strings (Bug#4281).
6333 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
6334
fb5b8aca
CY
63352012-03-21 Chong Yidong <cyd@gnu.org>
6336
6337 * xfaces.c (Vface_remapping_alist): Doc fix.
6338
62356a1b
EZ
63392012-03-20 Eli Zaretskii <eliz@gnu.org>
6340
6341 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
6342 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
6343 Doc fixes.
62356a1b 6344
025de85b
CY
63452012-03-20 Chong Yidong <cyd@gnu.org>
6346
6347 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
6348 to reflect default non-nil value of redisplay-dont-pause.
6349
4827f94e
KH
63502012-03-19 Kenichi Handa <handa@m17n.org>
6351
6352 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
6353 it fit in a valid range (Bug#11003).
6354
e50a24a2
EZ
63552012-03-18 Eli Zaretskii <eliz@gnu.org>
6356
6357 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
6358 that is not from display property, accept the row as a "cursor
6359 row" if one of the string's character has a non-nil `cursor'
6360 property. Fixes cursor positioning when there are newlines in
6361 overlay strings, e.g. in icomplete.el. (Bug#11035)
6362
9af5ed87
PE
63632012-03-12 Paul Eggert <eggert@cs.ucla.edu>
6364
6365 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
6366
d1f55f16
CY
63672012-03-12 Chong Yidong <cyd@gnu.org>
6368
6369 * eval.c (inhibit_lisp_code): Rename from
6370 inhibit_window_configuration_change_hook; move from window.c.
6371
6372 * xfns.c (unwind_create_frame_1, Fx_create_frame):
6373 * window.c (run_window_configuration_change_hook)
6374 (syms_of_window): Callers changed.
6375
66c5eebd
CY
63762012-03-11 Chong Yidong <cyd@gnu.org>
6377
413df973
CY
6378 * keymap.c (Fkey_description): Doc fix (Bug#9700).
6379
66c5eebd
CY
6380 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
6381
1de11f56
CY
63822012-03-10 Chong Yidong <cyd@gnu.org>
6383
6384 * frame.c (other_visible_frames): Don't assume the selected frame
6385 is visible (Bug#10955).
6386
cae07000
SM
63872012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
6388
6389 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
6390
89c94350
JD
63912012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6392
6393 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
6394 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
6395 zero (Bug#10954).
6396
999dd333
GM
63972012-03-03 Glenn Morris <rgm@gnu.org>
6398
01a6dcc8 6399 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6400
de0100f2
EZ
64012012-03-02 Eli Zaretskii <eliz@gnu.org>
6402
6403 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6404 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6405 (redisplay_window, next_element_from_string): Fix typos in
6406 comments.
3e441275
EZ
6407 (redisplay_window): Pass to move_it_vertically the margin in
6408 pixels, not in screen lines.
de0100f2 6409
96a72ee9
GM
64102012-03-02 Glenn Morris <rgm@gnu.org>
6411
6412 * buffer.c (buffer-list-update-hook): Doc fix.
6413
312508d7
EZ
64142012-02-29 Eli Zaretskii <eliz@gnu.org>
6415
6416 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6417 push_it before setting up the iterator for the first overlay
6418 string, even if we have an empty string loaded.
6419 (next_overlay_string): If there's an empty string on the iterator
6420 stack, pop the stack. (Bug#10903)
6421
27f3c637
PE
64222012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6423
6424 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6425 Suggested by Stefan Monnier in
6426 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6427 * alloc.c (widen_to_Lisp_Object): New static function.
6428 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6429 and widening them to Lisp_Objects. This would work even if
6430 USE_LSB_TAG is defined and wide integers are used, which might
6431 happen in a future version of Emacs.
6432
3c9dfce6
CY
64332012-02-25 Chong Yidong <cyd@gnu.org>
6434
fa74b241
CY
6435 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6436 Doc fix.
6437
3c9dfce6
CY
6438 * xselect.c (Fx_selection_exists_p): Doc fix.
6439 (x_clipboard_manager_save_all): Print an informative message
6440 before saving to clipboard manager.
6441
9486df08
CY
64422012-02-24 Chong Yidong <cyd@gnu.org>
6443
6444 * keyboard.c (process_special_events): Handle all X selection
6445 requests in kbd_buffer, not just the next one (Bug#8869).
6446
f01d3321
CY
64472012-02-23 Chong Yidong <cyd@gnu.org>
6448
6449 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6450 call when setting menu-bar-lines and tool-bar-lines parameters.
6451 (unwind_create_frame_1): New helper function.
6452
6453 * window.c (inhibit_window_configuration_change_hook): New var.
6454 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6455 (syms_of_window): Initialize it.
f01d3321 6456
86b847b6
CY
64572012-02-22 Chong Yidong <cyd@gnu.org>
6458
6459 * xterm.c (x_draw_image_relief): Add missing type check for
6460 Vtool_bar_button_margin (Bug#10743).
6461
a59225b1
CY
64622012-02-21 Chong Yidong <cyd@gnu.org>
6463
6464 * fileio.c (Vfile_name_handler_alist): Doc fix.
6465
6466 * buffer.c (Fget_file_buffer): Protect against invalid file
6467 handler return value.
6468
310f5bd4
PE
64692012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6470
cb3a28cc
PE
6471 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6472 when computing $valmask.
6473
310f5bd4
PE
6474 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6475 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6476 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6477 It's useless in that case, and it can cause problems on hosts
6478 that allocate halves of EMACS_INT values separately.
6479 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6480 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6481 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6482 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6483 it avoids undefined behavior on hosts where shifting right by more
6484 than the word width has undefined behavior.
6485
2375c96a
CY
64862012-02-19 Chong Yidong <cyd@gnu.org>
6487
6488 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6489 (Funhandled_file_name_directory, Ffile_name_as_directory)
6490 (Fdirectory_file_name, Fexpand_file_name)
6491 (Fsubstitute_in_file_name): Protect against invalid file handler
6492 return values (Bug#10845).
6493
3eb49e71
EZ
64942012-02-18 Eli Zaretskii <eliz@gnu.org>
6495
6496 * .gdbinit (pitx): Fix incorrect references to fields of the
6497 iterator stack.
6498
7b926f3f
CY
64992012-02-17 Chong Yidong <cyd@gnu.org>
6500
6501 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6502
11273115
PE
65032012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6504
6505 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6506 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6507
c3a70e2b
CY
65082012-02-15 Chong Yidong <cyd@gnu.org>
6509
6510 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6511 marked as special. Also, starting docstrings with * is obsolete.
6512
0ca43699
AS
65132012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6514
6515 * gnutls.c (emacs_gnutls_write): Fix last change.
6516
2e8f3c56
LI
65172012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6518
6519 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6520 send_process.
6521
af70074f
SM
65222012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6523
6524 * keymap.c (Fsingle_key_description): Handle char ranges.
6525
95986d52
CY
65262012-02-12 Chong Yidong <cyd@gnu.org>
6527
afd83bd1
CY
6528 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6529 as that creates a dangerous corner case.
6530
95986d52
CY
6531 * window.c (Fdelete_window_internal): Invalidate the mouse
6532 highlight (Bug#9904).
6533
bd7da63e
GM
65342012-02-12 Glenn Morris <rgm@gnu.org>
6535
6536 * xselect.c (Fx_own_selection_internal)
6537 (Fx_get_selection_internal, Fx_disown_selection_internal)
6538 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6539 * nsselect.m (Fx_own_selection_internal)
6540 (Fx_disown_selection_internal, Fx_selection_exists_p)
6541 (Fx_selection_owner_p, Fx_get_selection_internal):
6542 Sync docs and argument specs with the xselect.c versions.
6543
77abcbc2
LI
65442012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6545
6546 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6547
90b671e2
EZ
65482012-02-11 Eli Zaretskii <eliz@gnu.org>
6549
1c0ca0b7
EZ
6550 * w32select.c (Fx_selection_exists_p): Sync doc string and
6551 argument list with xselect.c. (Bug#10783)
6552
6553 * w16select.c (Fx_selection_exists_p): Sync doc string and
6554 argument list with xselect.c. (Bug#10783)
90b671e2 6555
49241268
GM
65562012-02-10 Glenn Morris <rgm@gnu.org>
6557
6558 * fns.c (Fsecure_hash): Doc fix.
6559
f998bbe7 65602012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6561
6562 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6563
0992bd9c
CY
65642012-02-07 Chong Yidong <cyd@gnu.org>
6565
6566 * buffer.c (Fbuffer_local_variables)
6567 (buffer_lisp_local_variables): Handle unbound vars correctly;
6568 don't let Qunbound leak into Lisp.
6569
af008560
GM
65702012-02-07 Glenn Morris <rgm@gnu.org>
6571
dd605cc4
GM
6572 * image.c (Fimagemagick_types): Doc fix.
6573
af008560
GM
6574 * image.c (imagemagick-render-type): Change it from a lisp object
6575 to an integer. Move the doc here from the lisp manual.
6576 Treat all values not equal to 0 the same.
6577
1449fa1d
CY
65782012-02-06 Chong Yidong <cyd@gnu.org>
6579
6580 * doc.c (store_function_docstring): Avoid applying docstring of
6581 alias to base function (Bug#2603).
6582
3723ec07
AS
65832012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6584
6585 * .gdbinit (pp1, pv1): Remove redundant defines.
6586 (pr): Use pp.
6587
79c1cc1e
CY
65882012-02-04 Chong Yidong <cyd@gnu.org>
6589
6590 * nsterm.m: Declare a global (Bug#10694).
6591
d7f29f8e
EZ
65922012-02-04 Eli Zaretskii <eliz@gnu.org>
6593
cae07000
SM
6594 * w32.c (get_emacs_configuration_options):
6595 Include --enable-checking, if specified, in the return value.
d7f29f8e 6596
3b95a6f9
MR
65972012-02-04 Martin Rudalics <rudalics@gmx.at>
6598
6599 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6600 after rounding frame sizes. (Bug#9723)
6601
d6fa96a6
EZ
66022012-02-04 Eli Zaretskii <eliz@gnu.org>
6603
6604 * keyboard.c (adjust_point_for_property): Don't position point
6605 before BEGV. (Bug#10696)
6606
df0b2940
PE
66072012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6608
6609 Handle overflow when computing char display width (Bug#9496).
6610 * character.c (char_width): Return EMACS_INT, not int.
6611 (char_width, c_string_width): Check for overflow when
6612 computing the width; this is possible now that individual
6613 characters can have unbounded width. Problem introduced
6614 by merge from Emacs 23 on 2012-01-19.
6615
6bee44d6
MA
66162012-02-02 Michael Albinus <michael.albinus@gmx.de>
6617
6618 * dbusbind.c (Fdbus_register_method): Mention the return value
6619 :ignore in the docstring.
6620
44f92739
GM
66212012-02-02 Glenn Morris <rgm@gnu.org>
6622
1b9f60cc
GM
6623 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6624
44f92739
GM
6625 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6626 Unconditionally set to t. (Bug#10673)
6627 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6628 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6629 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6630
c5d3843c
KH
66312012-02-02 Kenichi Handa <handa@m17n.org>
6632
6633 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6634 0, do not call append_composite_glyph.
6635
159462d4 66362012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6637
6638 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6639 NULL (Bug#6988).
6640 (x_produce_glyphs): If the component of a composition is a null
6641 string, set it->pixel_width to 1 to avoid zero-width glyph.
6642
78cef877
EZ
66432012-02-01 Eli Zaretskii <eliz@gnu.org>
6644
6645 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6646 first 2 arguments are identical. This makes inserting large
6647 output from a subprocess an order of magnitude faster on
6648 MS-Windows, where all sbrk'ed memory is always contiguous.
6649
97897668
GM
66502012-01-31 Glenn Morris <rgm@gnu.org>
6651
6652 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6653 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6654 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6655
31fd3586
GM
66562012-01-29 Glenn Morris <rgm@gnu.org>
6657
6658 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6659
0e24a8b2
CY
66602012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6661
6662 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6663
cc0adcb0
CY
66642012-01-28 Chong Yidong <cyd@gnu.org>
6665
6666 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6667
acc28cb9
CY
66682012-01-26 Chong Yidong <cyd@gnu.org>
6669
9c69cfb7
CY
6670 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6671
acc28cb9
CY
6672 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6673 repeat counts (Bug#10507).
6674
48da7392
GM
66752012-01-26 Glenn Morris <rgm@gnu.org>
6676
6677 * lread.c (syms_of_lread): Doc fix.
6678
14af5f7f
CY
66792012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6680
6681 * coding.c (encode_designation_at_bol): Change return value to
6682 EMACS_INT.
6683
0b21c100
CY
66842012-01-25 Chong Yidong <cyd@gnu.org>
6685
6686 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6687
3c2907f7
CY
66882012-01-21 Chong Yidong <cyd@gnu.org>
6689
6690 * floatfns.c (Fcopysign): Make the second argument non-optional,
6691 since nil is not allowed anyway.
6692
959ad23f
AS
66932012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6694
6695 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6696 (send_process): Likewise.
6697
34a02f46
MR
66982012-01-19 Martin Rudalics <rudalics@gmx.at>
6699
6700 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6701 (Vwindow_persistent_parameters): Do not use Qstate.
6702 Rewrite doc-strings.
34a02f46 6703
1259009a 67042012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6705
6706 * character.c (char_width): New function.
70d4fdf6
GM
6707 (Fchar_width, c_string_width, lisp_string_width):
6708 Use char_width (Bug#9496).
25ed9e61 6709
6a6ee00d
MR
67102012-01-16 Martin Rudalics <rudalics@gmx.at>
6711
6712 * window.c (Vwindow_persistent_parameters): New variable.
6713 (Fset_window_configuration, save_window_save): Handle persistent
6714 window parameters.
6715
c85efaf7
EZ
67162012-01-14 Eli Zaretskii <eliz@gnu.org>
6717
6718 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6719 thrashing the stack of the thread. (Bug#9087)
6720
5944709e
PE
67212012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6722
6723 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6724
e71f5d99
EZ
67252012-01-11 Eli Zaretskii <eliz@gnu.org>
6726
6727 * xdisp.c (rows_from_pos_range): Handle the case where the
6728 highlight ends on a newline. (Bug#10464)
6729 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6730 he end column for display of highlight that ends on a newline
6731 before a R2L line.
6732
ce316182
GM
67332012-01-11 Glenn Morris <rgm@gnu.org>
6734
6735 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6736 from load-path also when installation-directory is nil. (Bug#10208)
6737
5b43da69
GM
67382012-01-10 Glenn Morris <rgm@gnu.org>
6739
74cc8ff9
GM
6740 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6741
7d8d6e4e
GM
6742 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6743 Update template values to be closer to their typical values these days.
5b43da69 6744
a0db8d43
EZ
67452012-01-09 Eli Zaretskii <eliz@gnu.org>
6746
6747 * xdisp.c (rows_from_pos_range): Accept additional argument
6748 DISP_STRING, and accept any glyph in a row whose object is that
6749 string as eligible for mouse highlight. Fixes mouse highlight of
6750 display strings from overlays. (Bug#10464)
6751
9a0115ab 67522012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6753
b9110d6a 6754 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6755 * fileio.c (auto_saving_dir_umask): New static var.
6756 (Fmake_directory_internal): Use it.
6757 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6758 creating the directory. The old code temporarily assigns
6759 too-generous permissions to the directory.
6760 (do_auto_save_eh): Clear it.
b9110d6a 6761 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6762 that the var is always cleared.
6763
6c1bd3f3
EZ
67642012-01-07 Eli Zaretskii <eliz@gnu.org>
6765
6766 * search.c (scan_buffer): Pass character positions to
6767 know_region_cache, not byte positions. (Bug#6540)
6768
069d2b50
L
67692012-01-07 LynX <_LynX@bk.ru> (tiny change)
6770
6771 * w32.c (sys_rename): Report EXDEV when rename of a directory
6772 fails because the target is on another logical disk. (Bug#10284)
6773
75bf0d33
DB
67742012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6775
6776 * xterm.c (x_embed_request_focus): New function.
6777
6778 * xterm.h: Add prototype.
6779
6780 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6781
1c6e5a32
GM
67822012-01-05 Glenn Morris <rgm@gnu.org>
6783
6784 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6785
651e947e
EZ
67862012-01-01 Eli Zaretskii <eliz@gnu.org>
6787
6788 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6789 Load gnutls_transport_set_lowat only if GnuTLS version is below
6790 2.11.1.
6791 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6792 GnuTLS versions below 2.11.1.
6793
3778cdd8
AL
67942011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6795
6796 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6797 to the doc string advising against its use for altering the way
6798 windows are scrolled.
6799
0e5317f7
KH
68002011-12-28 Kenichi Handa <handa@m17n.org>
6801
6802 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6803 coding-system ASCII compatible only when it does not produce BOM
6804 on encoding (Bug#10383).
6805
93d5ca1f
JD
68062011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6807
6808 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6809 can scroll.
6810 (create_and_show_popup_menu): Always use menu_position_func for
6811 Gtk3 (Bug#10361).
6812
ca22b785
AS
68132011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6814
6815 * callint.c (Fcall_interactively): Don't truncate prompt string.
6816
d048e1e6
EZ
68172011-12-23 Eli Zaretskii <eliz@gnu.org>
6818
6819 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6820 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6821 resumed from there (after widening). (Bug#10360)
d048e1e6 6822
5ccaba1f
JD
68232011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6824
6825 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6826
204ee57f
JD
68272011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6828
b81d40f0
JB
6829 * nsterm.m (x_free_frame_resources):
6830 Release f->output_data.ns->miniimage.
204ee57f
JD
6831 (ns_index_color): Fix indentation. Do not retain
6832 color_table->colors[i].
6833
6834 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6835 before returning.
6836
6837 * nsfns.m (x_set_background_color): Assign return value from
6838 ns_index_color to face-background instead of NSColor*.
6839 (ns_implicitly_set_icon_type): Fix indentation.
6840 Change assignment in for loop to comparison.
6841
6842 * emacs.c (ns_pool): New variable.
6843 (main): Assign ns_pool.
6844 (Fkill_emacs): Call ns_release_autorelease_pool.
6845
6846 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6847 autorelease fdesc, release fdAttrs and tdict.
6848 (ns_get_covering_families): Release charset.
6849 (ns_findfonts): Release NSFontDescriptor created with new.
6850 (ns_uni_to_glyphs): Fix indentation.
6851 (setString): Release attrStr before assigning new value.
6852
c803b2b7
JD
68532011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6854
678f4426
JD
6855 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6856 and NS_IMPL_COCOA.
6857 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6858 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6859
cd394be1 68602011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6861
5fecd5fc
JD
6862 * nsterm.m (ns_term_init): Subscribe for notifications
6863 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6864 to method trackingNotification in EmacsMenu.
6865
6866 * nsmenu.m (trackingMenu): New variable.
3771cb17 6867 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6868 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6869 from Aquamacs (Bug#7030).
678f4426
JD
6870
68712011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6872
c803b2b7
JD
6873 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6874 (symbol_to_nsstring): Fix indentation.
6875 (ns_symbol_to_pb): New function.
cae07000
SM
6876 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6877 (Fns_rotate_cut_buffers_internal): Remove.
6878 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6879 Fns_store_cut_buffer_internal.
6880 (ns_get_foreign_selection, Fx_own_selection_internal)
6881 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6882 (Fns_get_selection_internal, Fns_store_selection_internal):
6883 Use ns_symbol_to_pb and check if return value is nil.
6884 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6885 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6886 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6887 renamed to Sns_store_selection_internal.
6888 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6889 and remove this function.
6890 (ns_handle_selection_clear): Remove, never used.
6891 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6892 here.
6893
e1b01a3a
KB
68942011-12-17 Ken Brown <kbrown@cornell.edu>
6895
6896 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6897 GID is unknown (Bug#10257).
6898
2adb6e85
PE
68992011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6900
6901 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6902 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6903 which caused a build failure on GNU/Linux IA-64. This problem was
6904 introduced by my 2011-10-07 patch.
6905
d1d7b339
JL
69062011-12-15 Juri Linkov <juri@jurta.org>
6907
6908 * image.c (imagemagick_error): New function. (Bug#10112)
6909 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6910 Use `imagemagick_error' where ImageMagick functions return
6911 `MagickFalse'.
6912 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6913 proper order.
6914
100d5755
KH
69152011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6916
6917 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6918 fill background (Bug#8992).
6919
454592a6
MR
69202011-12-13 Martin Rudalics <rudalics@gmx.at>
6921
6922 * window.c (Vwindow_combination_resize)
6923 (Vwindow_combination_limit): Use t instead of non-nil in
6924 doc-strings.
61d4b438
MR
6925 (Vrecenter_redisplay): Add first sentence of doc-string on
6926 separate line.
53524d93 6927 (Frecenter): Fix doc-string typo.
454592a6 6928
3633e3aa
KH
69292011-12-11 Kenichi Handa <handa@m17n.org>
6930
6931 * coding.c (Funencodable_char_position): Pay attention to the
6932 buffer text relocation (Bug#9389).
6933
7b9d523a 69342011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6935
7b9d523a
JD
6936 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6937 gtk_init (Bug#10100).
6938
b73189c6
EZ
69392011-12-10 Eli Zaretskii <eliz@gnu.org>
6940
6941 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6942 IT->string is nil. (Bug#10263)
6943
f7dfe5d6
JD
69442011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6945
83faebb4
JD
6946 * nsterm.h (x_free_frame_resources): Declare.
6947
f7dfe5d6
JD
6948 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6949 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6950
6951 * nsterm.h (ns_get_defaults_value): Declare.
6952
6953 * nsterm.m (ns_default): Call ns_get_defaults_value.
6954
7cd4e72c
EZ
69552011-12-09 Eli Zaretskii <eliz@gnu.org>
6956
6957 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6958 (Bug#10170)
6959
b34d7317
YM
69602011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6961
6962 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6963 that where the value of an _OBJC_* symbol points to is in the .bss
6964 section (Bug#10240).
6965
76470ad1
KH
69662011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6967
6968 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6969 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6970
745fff94
KH
69712011-12-08 Kenichi Handa <handa@m17n.org>
6972
6973 * ftfont.c (get_adstyle_property): Fix previous change
6974 (Bug#10233).
6975
6e44397c
JB
69762011-12-07 Juanma Barranquero <lekktu@gmail.com>
6977
6978 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6979 dirs from the default value of EMACSLOADPATH (bug#10208).
6980
7efa6272
GM
69812011-12-07 Glenn Morris <rgm@gnu.org>
6982
6983 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6984 installation and source directories as well. (Bug#10208)
6985
f6fc4d87
CY
69862011-12-06 Chong Yidong <cyd@gnu.org>
6987
6988 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6989
2bf26180
GM
69902011-12-06 Glenn Morris <rgm@gnu.org>
6991
6992 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6993 as an error, not just -1. (Bug#10217)
6994
3a6ad4f0
CY
69952011-12-05 Chong Yidong <cyd@gnu.org>
6996
6997 * keyboard.c (process_special_events): New function.
6998 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6999
75a3b399
PE
70002011-12-05 Paul Eggert <eggert@cs.ucla.edu>
7001
7002 * coding.c (encode_designation_at_bol): Don't use uninitialized
7003 local variable (Bug#9318).
7004
c3c9e25e
KH
70052011-12-05 Kenichi Handa <handa@m17n.org>
7006
7007 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
7008 return Qnil (Bug#8046, Bug#10193).
7009
5eb05ea3
KH
70102011-12-05 Kenichi Handa <handa@m17n.org>
7011
7012 * coding.c (encode_designation_at_bol): New args charbuf_end and
7013 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
7014 (coding_set_source): Return how many bytes coding->source was
7015 relocated.
7016 (coding_set_destination): Return how many bytes
7017 coding->destination was relocated.
7018 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 7019 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
7020
70212011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7022
7023 * coding.c (CODING_CHAR_CHARSET_P): New macro.
7024 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
7025 macro (Bug#9318).
7026
70272011-12-05 Andreas Schwab <schwab@linux-m68k.org>
7028
7029 The following changes are to fix Bug#9318.
7030
a79703f5 7031 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
7032 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
7033 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 7034 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 7035
7dbda6df
JB
70362011-12-05 Juanma Barranquero <lekktu@gmail.com>
7037
7038 * lisp.h (process_quit_flag): Fix external declaration.
7039
6d5eb5b0
SM
70402011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
7041
7042 Don't macro-inline non-performance-critical code.
7043 * eval.c (process_quit_flag): New function.
7044 * lisp.h (QUIT): Use it.
7045
a0c3fad0
JD
70462011-12-04 Jan Djärv <jan.h.d@swipnet.se>
7047
7048 * nsfns.m (get_geometry_from_preferences): New function.
7049 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
7050
6c07aac2
AS
70512011-12-04 Andreas Schwab <schwab@linux-m68k.org>
7052
7053 * emacs.c (Qkill_emacs): Define.
7054 (syms_of_emacs): Initialize it.
7055 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
7056 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
7057 (quit_throw_to_read_char): Add parameter `from_signal'.
7058 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
7059 * lisp.h (QUIT): Call Fkill_emacs if requested.
7060
c052ead4
JD
70612011-12-03 Jan Djärv <jan.h.d@swipnet.se>
7062
7063 * widget.c (update_wm_hints): Return if wmshell is null.
7064 (widget_update_wm_size_hints): New function.
7065
7066 * widget.h (widget_update_wm_size_hints): Declare.
7067
7068 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
7069 widget_update_wm_size_hints (Bug#10104).
7070
9e49252b
EZ
70712011-12-03 Eli Zaretskii <eliz@gnu.org>
7072
7073 * xdisp.c (handle_invisible_prop): If the invisible text ends just
7074 before a newline, prepare the bidi iterator for consuming the
7075 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 7076 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 7077
02b16839
JL
70782011-12-02 Juri Linkov <juri@jurta.org>
7079
7080 * search.c (Fword_search_regexp): New Lisp function created from
7081 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
7082 (Fword_search_backward, Fword_search_forward)
7083 (Fword_search_backward_lax, Fword_search_forward_lax):
7084 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
7085 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
7086
0068070e
SM
70872011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
7088
7089 * fileio.c (Finsert_file_contents): Move after-change-function call
7090 to before the "handled:" label, since all "goto handled" appear in
7091 cases where the *-change-functions have already been properly called
7092 (bug#10117).
7093
3360a3fc
AS
70942011-12-01 Andreas Schwab <schwab@linux-m68k.org>
7095
7096 * keyboard.c (interrupt_signal): Don't call kill-emacs when
7097 waiting for input. (Bug#10169)
7098
73d6c093
EZ
70992011-11-30 Eli Zaretskii <eliz@gnu.org>
7100
7101 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
7102 verifies glyph row's hash code--we have just reallocated the
7103 glyphs, so their contents can be complete garbage. (Bug#10164)
7104
febe6bea
JB
71052011-11-30 Juanma Barranquero <lekktu@gmail.com>
7106
7107 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
7108
801a4313
EZ
71092011-11-30 Eli Zaretskii <eliz@gnu.org>
7110
7111 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
7112 attributes are tested _before_ calling verify_row_hash, to protect
7113 against GCC re-ordering of the tests. (Bug#10164)
7114
2b56b87e
JD
71152011-11-29 Jan Djärv <jan.h.d@swipnet.se>
7116
7117 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
7118
7119 * xterm.c (handle_one_xevent): Only set async_visible and friends
7120 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 7121 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
7122 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
7123
dbf31225
PE
71242011-11-28 Paul Eggert <eggert@cs.ucla.edu>
7125
7126 Remove GCPRO-related macros that exist only to avoid shadowing locals.
7127 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
7128 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
7129 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7130 All uses changed to use GCPRO1 etc.
7131 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
7132 Revert to old implementation (i.e., before 2011-03-11).
7133
1305621b
YM
71342011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7135
7136 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
7137 of scroll runs so as to avoid assigning disabled bogus rows and
7138 unnecessary graphics copy operations.
7139
8c9afb46
EZ
71402011-11-27 Eli Zaretskii <eliz@gnu.org>
7141
7142 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
7143 (snprintf) [_MSC_VER]: Redirect to _snprintf.
7144 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
7145 (malloc, free, realloc, calloc): Redirect to e_* only when
7146 compiling Emacs.
7147
7148 * lisp.h (GCTYPEBITS): Move before first use.
7149 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
7150 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
7151 this macro definition.
7152
7153 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
7154 _MSC_VER.
7155
54e9e3bf
JD
71562011-11-27 Jan Djärv <jan.h.d@swipnet.se>
7157
6d5eb5b0
SM
7158 * gtkutil.c (xg_create_frame_widgets):
7159 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
7160 present with Gtk+ 2.0.
7161
83aca1cb
PE
71622011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7163
7164 * fileio.c (Finsert_file_contents): Undo previous change; see
7165 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7166
5b76caa4
PE
71672011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7168
7169 Rename locals to avoid shadowing.
7170 * fileio.c (Finsert_file_contents):
7171 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
7172 * process.c (wait_reading_process_output):
7173 Rename inner 'proc' to 'p' to avoid shadowing.
7174 Indent for consistency with usual Emacs style.
7175
8c535114
EZ
71762011-11-25 Eli Zaretskii <eliz@gnu.org>
7177
7178 * xdisp.c (redisplay_window): If cursor row is not fully visible
7179 after recentering, and scroll-conservatively is set to a large
7180 number, scroll window by a few more lines to make the cursor fully
7181 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
7182 (start_display): Don't move to the next line if the display should
7183 start at a newline that is part of a display vector or an overlay
7184 string. (Bug#10119)
8c535114 7185
fa4fdb5c
JL
71862011-11-24 Juri Linkov <juri@jurta.org>
7187
7188 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
7189 after the `MagickPingImage' call. (Bug#10112)
7190
90ec88df
CY
71912011-11-23 Chong Yidong <cyd@gnu.org>
7192
7193 * window.c (Fcoordinates_in_window_p): Accept only live windows.
7194
56e2e794
MR
71952011-11-23 Martin Rudalics <rudalics@gmx.at>
7196
7197 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
7198 making another buffer current. (Bug#10114)
7199
b6e64c41
GM
72002011-11-23 Glenn Morris <rgm@gnu.org>
7201
7202 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
7203
6b21de18
CY
72042011-11-23 Chong Yidong <cyd@gnu.org>
7205
7206 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
7207 using it (Bug#5984).
7208
b12cd789
EZ
72092011-11-22 Eli Zaretskii <eliz@gnu.org>
7210
7211 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
7212 and header-lines, as they don't have one computed for them.
7213 (Bug#10098)
7214
7215 * .gdbinit (prow): Make displayed values more self-explaining.
7216 Add row's hash code.
7217
261b6fd4
LMI
72182011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
7219
7220 * process.c (wait_reading_process_output): Fix asynchrounous
7221 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 7222 (wait_reading_process_output): Add comment and URL.
261b6fd4 7223
e7cfd277
JD
72242011-11-21 Jan Djärv <jan.h.d@swipnet.se>
7225
7226 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
7227
a9b9b7f5
CY
72282011-11-21 Chong Yidong <cyd@gnu.org>
7229
7230 * window.c (Fnext_window, Fprevious_window): Doc fix.
7231
b0d15b4f
SM
72322011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7233
7234 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
7235
fe7a3057
JB
72362011-11-20 Juanma Barranquero <lekktu@gmail.com>
7237
7238 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
7239
d2999b1a
MR
72402011-11-20 Martin Rudalics <rudalics@gmx.at>
7241
7242 * window.c (Fset_window_combination_limit): Rename argument
7243 STATUS to LIMIT.
7244 (Vwindow_combination_limit): Remove "status" from doc-string.
7245
d5ff9cd0
AS
72462011-11-20 Andreas Schwab <schwab@linux-m68k.org>
7247
7248 * m/ibms390.h: Remove.
7249 * m/ibms390x.h: Don't include "ibms390.h".
7250
a5bb9bd3
SM
72512011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7252
7253 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
7254 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
7255
cd1181db
JB
72562011-11-20 Juanma Barranquero <lekktu@gmail.com>
7257
7258 * casetab.c (Fset_case_table):
7259 * charset.c (Fcharset_after): Fix typos.
7260
615a3b8d 72612011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 7262
17e845af
PE
7263 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
7264 Otherwise, valgrind does not work on some platforms.
7265 Problem reported by Andreas Schwab in
6a0bf43d
PE
7266 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
7267 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
7268 is set, removing the need for VIRT_ADDRESS_VARIES.
7269 (PURE_P): Use a more-efficient implementation that needs just one
7270 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
7271 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
7272 to 4 (xorl, subq, cmpq, setbe).
7273 * alloc.c (pure): Always extern now, since that's the
7274 VIRT_ADDR_VARIES behavior.
7275 (PURE_POINTER_P): Use a single comparison, not two, for
7276 consistency with the new puresize.h.
7277 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
7278 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
7279 Remove VIRT_ADDR_VARIES no longer needed.
7280
f8fe6f96
EZ
72812011-11-19 Eli Zaretskii <eliz@gnu.org>
7282
7283 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
7284 (erase_phys_cursor, update_window_cursor, show_mouse_face)
7285 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
7286 behave as if the cursor position were at the window margin.
7287
7288 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
7289 and the cursor position is out of bounds, behave as if the cursor
7290 position were at the window margin. (Bug#10075)
7291
df05a53c
CY
72922011-11-18 Chong Yidong <cyd@gnu.org>
7293
7294 * window.c (Fwindow_combination_limit): Make first argument
7295 non-optional, since it is meaningless for live windows like the
7296 selected window.
61ccba97 7297
2071918e
DA
72982011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
7299
7300 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
7301
b50a28de
SM
73022011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
7303
7304 * intervals.c: Fix grafting over the whole buffer (bug#10071).
7305 (graft_intervals_into_buffer): Simplify.
7306
015137db
EZ
73072011-11-18 Eli Zaretskii <eliz@gnu.org>
7308
7309 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
7310 hash values of the two rows.
7311 (copy_row_except_pointers): Preserve the used[] arrays and the
7312 hash values of the two rows. (Bug#10035)
68c95424 7313 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
7314
7315 * xdisp.c (row_hash): New function, body extracted from
7316 compute_line_metrics.
7317 (compute_line_metrics): Call row_hash, instead of computing the
7318 hash code inline.
7319
7320 * dispnew.c (verify_row_hash): Call row_hash for computing the
7321 hash code of a row, instead of duplicating code from xdisp.c.
7322
7323 * dispextern.h (row_hash): Add prototype.
7324
a2addb04
TH
73252011-11-18 Tassilo Horn <tassilo@member.fsf.org>
7326
7327 * frame.c (delete_frame): Don't delete the terminal when the last
7328 X frame is closed if emacs is built with GTK toolkit.
7329
df85d315
JB
73302011-11-17 Juanma Barranquero <lekktu@gmail.com>
7331
7332 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
7333
a0c2d0ae
MR
73342011-11-17 Martin Rudalics <rudalics@gmx.at>
7335
7336 * window.c (Vwindow_splits): Rename to
7337 Vwindow_combination_resize. Suggested by Juri Linkov.
7338 (Fsplit_window_internal): Use Vwindow_combination_resize instead
7339 of Vwindow_splits.
7340
58179cce
JB
73412011-11-16 Juanma Barranquero <lekktu@gmail.com>
7342
7877f373
JB
7343 * nsfns.m (Fns_font_name):
7344 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 7345
b6f67890
MR
73462011-11-16 Martin Rudalics <rudalics@gmx.at>
7347
7348 * window.h (window): Rename slot "nest" to "combination_limit".
7349 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
7350 (Fset_window_nest): Rename to Fset_window_combination_limit.
7351 (Vwindow_nest): Rename to Vwindow_combination_limit.
7352 (recombine_windows, make_parent_window, make_window)
7353 (Fsplit_window_internal, saved_window)
7354 (Fset_window_configuration, save_window_save): Rename all
7355 occurrences of window_nest to window_combination_limit.
7356
c7015153
JB
73572011-11-15 Juanma Barranquero <lekktu@gmail.com>
7358
7359 * image.c (imagemagick_load_image): Fix typo.
7360
322ad6ec
EZ
73612011-11-14 Eli Zaretskii <eliz@gnu.org>
7362
7363 * xdisp.c (display_line): Move the call to
7364 highlight_trailing_whitespace before the call to
7365 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
7366 faces of all the glyphs to compute ROW's hash value.
7367 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 7368
f067b8ec
JB
73692011-11-14 Juanma Barranquero <lekktu@gmail.com>
7370
7371 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
7372 just return (bug#10044).
7373
1e5b2111
EZ
73742011-11-12 Eli Zaretskii <eliz@gnu.org>
7375
7ef3cbd5
EZ
7376 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
7377 with user-defined heap size. Bump the default size of the temacs
7378 heap to 27MB, to avoid memory warning when running temacs.
7379 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
7380
1e5b2111
EZ
7381 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
7382 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
7383 (verify_row_hash) [XASSERTS]: New function.
7384 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
7385 that the hash value of glyph rows is correct.
1e5b2111 7386
89d61221
MR
73872011-11-12 Martin Rudalics <rudalics@gmx.at>
7388
7389 * window.h (window): Remove splits slot.
7390 * window.c (Fwindow_splits, Fset_window_splits): Remove.
7391 (Fdelete_other_windows_internal, make_parent_window)
7392 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7393 (Fset_window_configuration, save_window_save): Don't deal with
7394 split status of windows.
7395 (saved_window): Remove splits slot.
7396 (Vwindow_splits): Rewrite doc-string.
7397
97f18cc8
JD
73982011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7399
7400 * xfns.c (unwind_create_frame):
7401 * nsfns.m (unwind_create_frame):
7402 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7403 Vframe_list (Bug#9999).
7404
22a648b4
DA
74052011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7406
0b381c7e 7407 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7408
659afede
KH
74092011-11-11 Kenichi Handa <handa@m17n.org>
7410
7411 * callproc.c (Fcall_process): Set the member dst_multibyte of
7412 process_coding.
7413
9ac0394b
KH
74142011-11-11 Johan Bockgård <bojohan@gnu.org>
7415
7416 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7417 avoid a crash (bug#9496).
7418
2fbdc249
CY
74192011-11-09 Chong Yidong <cyd@gnu.org>
7420
7421 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7422 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7423
ac6b1f81
PE
74242011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7425
7426 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7427
09db192c
PE
74282011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7429
7430 Avoid some portability problems by eschewing 'extern inline' functions.
7431 The trivial performance wins aren't worth the portability hassles; see
7432 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7433 et seq.
7434 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7435 (window_box_width, window_box_left, window_box_left_offset)
7436 (window_box_right, window_box_right_offset): Undo previous change,
7437 by removing the "extern"s.
7438 * intervals.c (adjust_intervals_for_insertion)
7439 (adjust_intervals_for_deletion): Undo previous change,
7440 making these static again.
7441 (offset_intervals, temp_set_point_both, temp_set_point)
7442 (copy_intervals_to_string): No longer inline.
7443 * xdisp.c (window_text_bottom_y, window_box_width)
7444 (window_box_height, window_box_left_offset)
7445 (window_box_right_offset, window_box_left, window_box_right)
7446 (window_box): No longer inline.
7447
105216ed
CY
74482011-11-08 Chong Yidong <cyd@gnu.org>
7449
7450 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7451 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7452 Signal an error if not a live window.
105216ed
CY
7453 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7454 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7455
ae9e237f
JB
74562011-11-07 Juanma Barranquero <lekktu@gmail.com>
7457
7458 * lisp.h (syms_of_abbrev): Remove declaration.
7459 Reported by CHENG Gao <chenggao@royau.me>.
7460
c7aa8333
EZ
74612011-11-07 Eli Zaretskii <eliz@gnu.org>
7462
7463 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7464 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7465 of temacs in GUI mode.
7466
be7f5545
MR
74672011-11-07 Martin Rudalics <rudalics@gmx.at>
7468
7469 * window.h: Declare delete_all_child_windows instead of
7470 delete_all_subwindows.
7471 * window.c (Fwindow_nest, Fset_window_nest)
7472 (Fset_window_new_total, Fset_window_new_normal)
7473 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7474 (delete_all_subwindows): Rename to delete_all_child_windows.
7475 (Fdelete_other_windows_internal, Fset_window_configuration):
7476 Call delete_all_child_windows instead of delete_all_subwindows.
7477 * frame.c (delete_frame): Call delete_all_child_windows instead
7478 of delete_all_subwindows.
7479
ca78dc43
PE
74802011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7481
7482 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7483 This is also needed for porting to any host where GC_MARK_STACK is
7484 not GC_MAKE_GCPROS_NOOPS.
7485 (which_symbols): Use it.
7486
a0241d01
KH
74872011-11-07 Kenichi Handa <handa@m17n.org>
7488
7489 * coding.c (coding_set_destination): Check coding->src_pos only
7490 when coding->src_object is a buffer (bug#9910).
7491
7492 * process.c (send_process): Set the member src_multibyte of coding
7493 to 0 (bug#9911) when sending a unibyte text.
7494
7495 * callproc.c (Fcall_process): Set the member src_multibyte of
7496 process_coding to 0 (bug#9912).
7497
a64bfdfa 74982011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7499
7500 * xmenu.c (cleanup_widget_value_tree): New function.
7501 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7502 calling free_menubar_widget_value_tree directly (Bug#9830).
7503
cb41b32a
PE
75042011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7505
7506 Fix some portability problems with 'inline'.
7507 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7508 (window_box_width, window_box_left, window_box_left_offset)
7509 (window_box_right, window_box_right_offset): Declare extern.
7510 Otherwise, these inline functions do not conform to C99 and
7511 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7512 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7513 * intervals.c (adjust_intervals_for_insertion)
7514 (adjust_intervals_for_deletion): Now extern, because otherwise the
7515 extern inline functions 'offset_intervals' couldn't refer to it.
7516 (static_offset_intervals): Remove.
7517 (offset_intervals): Rewrite using the old contents of
7518 static_offset_intervals. The old version didn't conform to C99
7519 because an extern inline function contained a reference to an
7520 identifier with static linkage.
7521
b7041366
AS
75222011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7523
7524 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7525 GC.
7526
88a37c4d
EZ
75272011-11-06 Eli Zaretskii <eliz@gnu.org>
7528
7529 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7530 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7531 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7532 return Qleft_to_right.
7533
49745b39
CY
75342011-11-06 Chong Yidong <cyd@gnu.org>
7535
7536 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7537 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7538 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7539 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7540 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7541 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7542 (Fwindow_vscroll): Doc fix.
7543 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7544 argument, since it makes no sense to pass a live window and for
7545 consistency with window-child.
7546
1f05cd82
CS
75472011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7548
7549 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7550 support MSVC.
7551
22610910
JR
75522011-11-05 Jason Rumney <jasonr@gnu.org>
7553
7554 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7555 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7556 fonts (Bug#6029).
7557 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7558 bitwise arithmetic preventing use of unicode-sip and non-truetype
7559 opentype fonts.
7560
a06776b2
EZ
75612011-11-05 Eli Zaretskii <eliz@gnu.org>
7562
3ad924ba
EZ
7563 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7564 "emacs"-only part.
7565
a06776b2
EZ
7566 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7567 initialization code to keep similarity to xfns.c after changes
7568 from 2011-11-05.
7569
c9e7db78
JD
75702011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7571
a97f8f3f
JD
7572 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7573 (unwind_create_frame): New function (Bug#9943).
7574 (Fx_create_frame): Restructure code to be more similar to the one in
7575 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7576 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7577 Move terminal->reference_count++ just before making the frame official
7578 (Bug#9943).
7579
7580 * nsterm.m (x_free_frame_resources): New function.
7581 (x_destroy_window): Move code to x_free_frame_resources.
7582
c9e7db78 7583 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7584 (Fx_create_frame, x_create_tip_frame):
7585 Move terminal->reference_count++ just before making the frame
75f1671a 7586 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7587 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7588
a6fc3b5c
EZ
75892011-11-05 Eli Zaretskii <eliz@gnu.org>
7590
7591 Support MSVC build with newer versions of Visual Studio.
7592 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7593 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7594 nt/gmake.defs.
7595
7596 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7597 which are not supported by MSVC.
7598 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7599 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7600 bitfields.
7601 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7602 types in bitfields.
7603 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7604
7605 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7606
58179cce 76072011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7608
7609 Support MSVC build with newer versions of Visual Studio.
7610 * w32.c: Don't include w32api.h for MSVC.
7611 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7612
7613 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7614 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7615 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7616 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7617 e_* cousins.
7618 (alloca) [_MSC_VER]: Define to _alloca.
7619
7620 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7621
7622 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7623
a58c13ed
EZ
76242011-11-04 Eli Zaretskii <eliz@gnu.org>
7625
7626 * xdisp.c (note_mouse_highlight): If either of
7627 previous/next-single-property-change returns nil, treat that as
7628 the beginning or the end of the buffer. (Bug#9955)
7629
fe0b6370
JD
76302011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7631
a58c13ed 7632 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7633 label is not null (Bug#9951).
7634 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7635 may be NULL.
7636
89bd5ee1
EZ
76372011-11-04 Eli Zaretskii <eliz@gnu.org>
7638
7639 * window.c (Fwindow_body_size): Mention in the doc string that the
7640 return value is in frame's canonical units. (Bug#9949)
7641
84c3edb9
EZ
76422011-11-03 Eli Zaretskii <eliz@gnu.org>
7643
4e2fb5c7
EZ
7644 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7645
84c3edb9 7646 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7647 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7648 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7649
bc17a887
EZ
76502011-11-01 Eli Zaretskii <eliz@gnu.org>
7651
7652 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7653 Don't stop backward scan on the continuation glyph, even though
7654 its CHARPOS is positive.
6d5eb5b0
SM
7655 (mouse_face_from_buffer_pos, note_mouse_highlight):
7656 Rename cover_string to disp_string.
bc17a887 7657
4ee88440
MR
76582011-11-01 Martin Rudalics <rudalics@gmx.at>
7659
7660 * window.c (temp_output_buffer_show): Don't use
7661 Vtemp_buffer_show_specifiers.
7662 (Vtemp_buffer_show_specifiers): Remove unused variable.
7663
c2ff3c02
EZ
76642011-10-30 Eli Zaretskii <eliz@gnu.org>
7665
7666 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7667 past the beginning of the current glyph matrix.
7668
58179cce 76692011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7670
7671 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7672 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7673 HAVE_GTK3 (Bug#9869).
b77a6a7f 7674
3b574623
JD
7675 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7676 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7677
b77a6a7f
JD
7678 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7679
7680 * xterm.c: Declare x_handle_net_wm_state to return int.
7681 (handle_one_xevent): Check if we are iconified but don't have
7682 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7683 (get_current_wm_state): Return non-zero if not hidden,
7684 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7685 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7686 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7687 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7688
196e41e4
PE
76892011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7690
7691 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7692 so that this new function doesn't get optimized away by a
7693 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7694
021f2e1a
AS
76952011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7696
7697 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7698
8b058d44
EZ
76992011-10-29 Eli Zaretskii <eliz@gnu.org>
7700
7701 Fix the `xbytecode' command.
7702 * .gdbinit (xprintbytestr): New command.
b50a28de 7703 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7704 (xbytecode): Print the byte-code string as well.
7705
4452fb80
EZ
77062011-10-29 Kim Storm <storm@cua.dk>
7707
8b058d44
EZ
7708 * alloc.c (which_symbols): New function.
7709
21b72067
AS
77102011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7711
7712 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7713 line. (Bug#9903)
7714
83ed7b5c
GM
77152011-10-29 Glenn Morris <rgm@gnu.org>
7716
7717 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7718 Not clear what it was for, and it causes various bugs. (Bug#9839)
7719
5a7a728b
EZ
77202011-10-28 Eli Zaretskii <eliz@gnu.org>
7721
7722 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7723 possible random value that matches one of those tested as
7724 condition to clear the mouse face.
7725
d3d0842f
CY
77262011-10-28 Chong Yidong <cyd@gnu.org>
7727
7728 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7729
31b39d13
DN
77302011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7731
7732 * window.c (make_window): Initialize phys_cursor_on_p.
7733
9aba6043
SM
77342011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7735
7736 * lisp.h (struct Lisp_Symbol): Update comments.
7737
c20992f4
JB
77382011-10-28 Juanma Barranquero <lekktu@gmail.com>
7739
7740 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7741
db4f02f2
EZ
77422011-10-28 Eli Zaretskii <eliz@gnu.org>
7743
7744 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7745 <oslsachem@gmail.com> for helping to debug this.
7746
7747 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7748 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7749 (g_b_init_get_glyph_outline_w): New static variables.
7750 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7751 (GetGlyphOutlineW_Proc): New typedefs.
7752 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7753 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7754 New functions.
7755 (w32font_open_internal, compute_metrics):
7756 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7757 instead of calling the "wide" APIs directly.
7758
7759 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7760
7761 * w32.h (syms_of_w32font): Add prototype.
7762
87e68db4
JB
77632011-10-27 Juanma Barranquero <lekktu@gmail.com>
7764
7765 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7766 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7767 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7768 (Fmove_to_window_line): Doc fix.
7769
435c1d67
CY
77702011-10-27 Chong Yidong <cyd@gnu.org>
7771
7772 * process.c (make_process): Set gnutls_state to NULL.
7773
7774 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7775 non-NULL, regardless of GNUTLS_INITSTAGE.
7776 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7777 an error. Set process slots as soon as we allocate them.
7778
7779 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7780
9c6c6f49
CY
77812011-10-27 Chong Yidong <cyd@gnu.org>
7782
9aba6043
SM
7783 * gnutls.c (emacs_gnutls_deinit): New function.
7784 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7785 (Fgnutls_deinit, Fgnutls_boot): Use it.
7786
7787 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7788 (deactivate_process): Call emacs_gnutls_deinit.
7789
657d08d3
JB
77902011-10-27 Juanma Barranquero <lekktu@gmail.com>
7791
7792 * image.c (x_create_x_image_and_pixmap):
7793 * w32.c (sys_rename, w32_delayed_load):
7794 * w32font.c (fill_in_logfont):
7795 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7796
5430d399
JB
77972011-10-26 Juanma Barranquero <lekktu@gmail.com>
7798
7799 * w32fns.c (w32_default_color_map): New function,
7800 extracted from Fw32_default_color_map.
a7ef684b 7801 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7802
fe0055fa
PE
78032011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7804
7805 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7806
e6346438
SM
78072011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7808
7809 * keyboard.c (test_undefined): New function (bug#9751).
7810 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7811
e112cc37
ET
78122011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7813
7814 * sysdep.c (init_sys_modes): Fix the check for the controlling
7815 terminal (Bug#6649).
7816
7b5d6677
EZ
78172011-10-20 Eli Zaretskii <eliz@gnu.org>
7818
7819 * dispextern.h (struct bidi_it): New member next_en_type.
7820
7821 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7822 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7823 current character, check also for next_en_type being WEAK_EN.
7824 (bidi_resolve_weak): Don't enter the expensive loop if the current
7825 position is before next_en_pos. Record the bidi type of the first
7826 non-ET, non-BN character we find, in addition to its position.
7827 (bidi_level_of_next_char): Invalidate next_en_type when
7828 next_en_pos is over-stepped.
7829
7da0b018
PE
78302011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7831
7832 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7833 * editfns.c: Rewrite current-time-zone so that it invokes
7834 the equivalent of (format-time-string "%Z") to get the time zone name.
7835 This fixes a bug when the time zone name contains characters that
7836 need converting from the system time locale to Emacs internal format.
7837 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7838 that patch fixed format-time-string to do the conversion, but
7839 I forgot to fix current-time-zone.
7840 (format_time_string): New function, containing most of
7841 what Fformat_time_string used to contain.
7842 (Fformat_time_string): Rewrite in terms of format_time_string.
7843 This doesn't change this function's behavior.
7844 (current-time-zone): Rewrite to use format_time_string.
7845 This fixes the bug reported by Michael Schierl in
7846 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7847 Jason Rumney's 2007-06-07 change worked around this bug, but
7848 didn't fix it.
7849 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7850
8547b010
EZ
78512011-10-19 Eli Zaretskii <eliz@gnu.org>
7852
7853 * xdisp.c (start_display): If the character at POS is displayed
7854 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7855 (try_window_reusing_current_matrix): If a line ends in a display
7856 vector or the next line starts in a display vector, continue
7857 redrawing the window even though the character position of
7858 start_row was reached.
8547b010
EZ
7859 (Bug#9771, part 2)
7860
4e948d15
CY
78612011-10-18 Chong Yidong <cyd@gnu.org>
7862
7863 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7864 with nobreak-char-display too.
7865
4787455f
EZ
78662011-10-18 Eli Zaretskii <eliz@gnu.org>
7867
7868 Fix part 3 of bug#9771.
7869 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7870 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7871 non-neutral characters if the current character is a paragraph
7872 separator (a.k.a. Newline). This avoids running the same
7873 expensive loop twice, once when we consume the preceding newline
7874 and the other time when the line actually needs to be displayed.
7875 Avoid the loop when we see neutrals on the base embedding level
7876 following a character whose directionality is the same as the
7877 paragraph's. This avoids running the expensive loop when a line
7878 ends in a long sequence of neutrals, like control characters.
7879 Add assertion against STRONG_AL type. Slightly rearrange code
7880 that determines the type of a neutral given the first non-neutral
7881 that follows it.
7882 (bidi_level_of_next_char): Set next_en_pos to zero when
7883 invalidating its info.
7884
2c91f553
EZ
78852011-10-17 Eli Zaretskii <eliz@gnu.org>
7886
7887 * xdisp.c (push_display_prop): Determine whether to record string
7888 or buffer position by IT->string, not by IT->method. Allow
7889 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7890 (move_it_vertically_backward): Don't look for character position
7891 immediately after the newline when in a continuation line.
7892 (Bug#9771, part 1)
2c91f553 7893
c7b08b0d
MR
78942011-10-15 Martin Rudalics <rudalics@gmx.at>
7895
7896 * window.c (coordinates_in_window): Rewrite and delabelize
7897 vertical border check. (Bug#5357) (Bug#9618)
7898
6b02f655
SM
78992011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7900
7901 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7902 errors in XSetWindowBorder (bug#9310).
7903
81d40c92
DA
79042011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7905
7906 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7907 avoid crash when xmalloc overrun checking is enabled.
7908
d4172c3b
EZ
79092011-10-13 Eli Zaretskii <eliz@gnu.org>
7910
7911 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7912 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7913 cursor motion with <left> and <right> arrow keys.
7914
7915 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7916 some callers set that themselves.
7917
b00eea75
EZ
79182011-10-12 Eli Zaretskii <eliz@gnu.org>
7919
7920 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7921 display string and the previous row comes from the same string and
7922 is empty. (Bug#9739) (Bug#9738)
7923
8fe012c4
SM
79242011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7925
7926 * doc.c (get_doc_string): Encode file name (bug#9735).
7927
0074aef2
EZ
79282011-10-12 Eli Zaretskii <eliz@gnu.org>
7929
79beb178
EZ
7930 * bidi.c (bidi_level_of_next_char):
7931 * xdisp.c (get_visually_first_element): Remove old incorrect
7932 comments regarding the Unicode Line Separator character.
7933
0074aef2
EZ
7934 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7935
6e4b3fbe
DA
79362011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7937
7938 * alloc.c (Fgc_status): Do not access beyond zombies array
7939 boundary if nzombies > MAX_ZOMBIES.
7940 * alloc.c (dump_zombies): Add missing format specifier.
7941
0324f3af
PE
79422011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7943
b5525cac
PE
7944 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7945 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7946
0324f3af
PE
7947 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7948 Some packages use them to denote characters with modifiers.
7949
e9b5f888
AS
79502011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7951
7952 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7953 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7954 matching a pp-number. Rename parameter var to var1.
7955
127827c0
SM
79562011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7957
7958 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7959
c8fd3bd0
GM
79602011-10-08 Glenn Morris <rgm@gnu.org>
7961
7962 * callint.c (Fcall_interactively): Give a more explicit error for the
7963 'c' case with a non-character input. (Bug#8479)
7964
352ec8ff
EZ
79652011-10-08 Eli Zaretskii <eliz@gnu.org>
7966
03669ccb
EZ
7967 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7968 lines.
7061c986
EZ
7969 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7970 lines that are hscrolled on the left.
03669ccb 7971
352ec8ff
EZ
7972 * dispnew.c (buffer_posn_from_coords): Account for a possible
7973 presence of header-line. (Bug#4426)
7974
a66cfb1c
SM
79752011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7976
6b02f655
SM
7977 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7978 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7979
7c5ee88e
PE
79802011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7981
7982 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7983 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7984 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7985 this makes Emacs dump core during garbage collection on rare
7986 occasions. sizeof is obviously inferior to offsetof here, so
7987 stick with offsetof.
7988 (GC_POINTER_ALIGNMENT): New macro.
7989 (mark_memory): Omit 3rd (offset) arg; caller changed.
7990 Don't assume EMACS_INT alignment is the same as pointer alignment.
7991
df1bbe5b
SM
79922011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7993
7994 * keyboard.c (read_key_sequence_remapped): New var.
7995 (read_key_sequence): Compute remapping in the right buffer.
7996 (command_loop_1): Use read_key_sequence's remapping directly.
7997
51553db6
SM
79982011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7999
32c1fffd
SM
8000 * dired.c (file_name_completion): Don't expand file name.
8001 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
8002 before checking file name handler.
8003
51553db6
SM
8004 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
8005 they've been requested explicitly (bug#9591).
8006
b6bd1599 80072011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
8008
8009 * keymap.c (Fsingle_key_description): Use make_specified_string
8010 instead of build_string to build string from push_key_description.
8011 (Bug#5193)
8012
f701dc2a
PE
80132011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8014
4222c55d
PE
8015 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
8016 This fixes a Y2038 bug on 64-bit hosts.
8017 * buffer.c (reset_buffer):
8018 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
8019 (Fclear_buffer_auto_save_failure):
8020 Use 0, not -1, to represent an unset failure time, since time_t
8021 might not be signed.
8022
f701dc2a
PE
8023 Remove dependency on glibc malloc internals.
8024 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8025 Move back here from lisp.h, but with their new implementations.
8026 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8027 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
8028 * charset.c (charset_table_init): New static var.
8029 (syms_of_charset): Use it instead of xmalloc. This removes a
8030 dependency on glibc malloc internals. See Eli Zaretskii's comment in
8031 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
8032 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8033 Move back to alloc.c.
8034 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8035 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
8036
9ceebf39
JD
80372011-09-30 Jan Djärv <jan.h.d@swipnet.se>
8038
8039 * nsterm.m (windowDidResize): Call x_set_window_size only when
8040 ns_in_resize is true. Otherwise set pixelwidth/height and
8041 call change_frame_size (Bug#9628).
8042
cb993c58
PE
80432011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8044
3930c88b
PE
8045 Port --enable-checking=all to Fedora 14 x86-64.
8046 * charset.c (syms_of_charset): Also account for glibc malloc's
8047 internal overhead when calculating the initial malloc maximum.
8048
cb993c58
PE
8049 Port --enable-checking=all to Fedora 14 x86.
8050 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8051 Move to lisp.h.
8052 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
8053 (overrun_check_realloc, overrun_check_free):
8054 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
8055 That way, xmalloc returns a properly-aligned pointer even if
8056 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
8057 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
8058 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
8059 into account when calculating the initial malloc maximum.
8060 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8061 Move here from alloc.c, so that charset.c can use it too.
8062 Properly align; the old code wasn't right for common 32-bit hosts
8063 when configured with --enable-checking=all.
8064 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8065 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
8066
31bed486
EZ
80672011-09-29 Eli Zaretskii <eliz@gnu.org>
8068
04c70788 8069 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
8070 use EDOM.
8071
fbcaa2f3
EZ
80722011-09-28 Eli Zaretskii <eliz@gnu.org>
8073
8074 * xdisp.c (compute_display_string_end): If there's no display
8075 string at CHARPOS, return -1.
8076
8077 * bidi.c (bidi_fetch_char): When compute_display_string_end
8078 returns a negative value, treat the character as a normal
8079 character not covered by a display string. (Bug#9624)
8080
a239d4e9
JB
80812011-09-28 Juanma Barranquero <lekktu@gmail.com>
8082
8083 * lread.c (Fread_from_string): Fix typo in docstring.
8084
88652fd5
EZ
80852011-09-27 Eli Zaretskii <eliz@gnu.org>
8086
8087 * xdisp.c (handle_invisible_prop): If invisible text ends on a
8088 newline, reseat the iterator instead of bidi-iterating there one
8089 character at a time. (Bug#9610)
32c1fffd
SM
8090 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
8091 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 8092
ed497dd4
AS
80932011-09-27 Andreas Schwab <schwab@linux-m68k.org>
8094
8095 * lread.c (readevalloop): Use correct code for NBSP.
8096 (read1): Likewise. (Bug#9608)
8097
b2bf61aa
MA
80982011-09-25 Michael Albinus <michael.albinus@gmx.de>
8099
8100 * dbusbind.c (Fdbus_register_signal): When service is not
8101 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
8102
32bbb17c
GM
81032011-09-25 Glenn Morris <rgm@gnu.org>
8104
8105 * buffer.c (truncate-lines): Doc fix.
8106
94e0933e
CY
81072011-09-24 Chong Yidong <cyd@stupidchicken.com>
8108
8109 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
8110 (Fset_window_next_buffers): Doc fix.
8111
cddde921
GM
81122011-09-24 Glenn Morris <rgm@gnu.org>
8113
8114 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
8115
1260aef1
PE
81162011-09-24 Paul Eggert <eggert@cs.ucla.edu>
8117
25b4bfa0
PE
8118 Fix minor problems found by static checking.
8119 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
8120 * indent.c (Fvertical_motion): Fix == vs = typo.
8121
e3cbd34b
EZ
81222011-09-24 Eli Zaretskii <eliz@gnu.org>
8123
a66cfb1c
SM
8124 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
8125 Default value is now t. Doc fix.
6bf7006f 8126
e3cbd34b 8127 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 8128 logic when moving up, not only when moving down. Fix the
e3cbd34b 8129 confusing name and values of the it_overshoot_expected variable;
32c1fffd 8130 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
8131
8132 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
8133 CHARPOS is covered by a display string which includes newlines.
8134 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
8135 is covered by a display string with embedded newlines.
8136
a3de0cbd
MA
81372011-09-24 Michael Albinus <michael.albinus@gmx.de>
8138
8139 * dbusbind.c (Fdbus_register_signal): Add match rule to
8140 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
8141 (Fdbus_register_method, Vdbus_registered_objects_table):
8142 Fix docstring.
a3de0cbd 8143
b260039d
JM
81442011-09-24 Jim Meyering <meyering@redhat.com>
8145
32c1fffd 8146 do not ignore write error for any output size
b260039d
JM
8147 The previous change was incomplete.
8148 While it makes emacs --batch detect the vast majority of stdout
8149 write failures, errors were still ignored whenever the output size is
8150 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
8151 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
8152 && echo FAIL: ignored write error
8153 FAIL: ignored write error
8154 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
8155 && echo FAIL: ignored write error
8156 FAIL: ignored write error
8157 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
8158
8eca8a7c
AS
81592011-09-23 Andreas Schwab <schwab@linux-m68k.org>
8160
8161 * emacs.c (Fkill_emacs): In noninteractive mode exit
8162 non-successfully if a write error occurred on stdout. (Bug#9574)
8163
3341db62
EZ
81642011-09-21 Eli Zaretskii <eliz@gnu.org>
8165
8166 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
8167 the xassert test.
8168
8169 * dispextern.h (struct it): Update the comment documenting what
8170 can it->OBJECT be.
8171
8c203dbf
EZ
81722011-09-20 Eli Zaretskii <eliz@gnu.org>
8173
8174 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
8175 a display string, extend search for cursor position to end of row.
8176 (find_row_edges): If the row ends in a newline from a display
8177 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
8178 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
8179 (Fcurrent_bidi_paragraph_direction): Fix search for previous
8180 non-empty line. Fixes confusing cursor motion with arrow keys at
8181 the beginning of a line that starts with whitespace.
8c203dbf 8182
a4824228
LMI
81832011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8184
8185 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
8186 (bug#9493).
8187
33ed493b
CY
81882011-09-18 Chong Yidong <cyd@stupidchicken.com>
8189
8190 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
8191 boolean (Bug#9154).
8192
56cd55c8
EZ
81932011-09-18 Eli Zaretskii <eliz@gnu.org>
8194
8195 * xdisp.c (display_line): Record maximum and minimum buffer
8196 positions even if no glyphs were produced (e.g., by a zero-width
8197 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
8198 buffer positions that will be removed from the glyph row because
8199 they don't fit.
c02dcedf
EZ
8200 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
8201 column is beyond frame width: don't subtract 1 "pixel" when
8202 computing width of the stretch.
3e62b7e0
EZ
8203 (reseat_at_next_visible_line_start): Undo the change made on
8204 2011-09-17 that saved paragraph information and restored it after
8205 the call to `reseat'. (Bug#9545)
56cd55c8 8206
5ed99d36 82072011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
8208
8209 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
8210 and turn window cursor on if cleared (Bug#9415).
8211
5ed99d36 82122011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
8213
8214 * search.c (boyer_moore): Take unibyte characters from pattern
8215 literally. (Bug#9458)
8216
9bade7b2
EZ
82172011-09-18 Eli Zaretskii <eliz@gnu.org>
8218
8219 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
8220
e5e9d610
PE
82212011-09-18 Paul Eggert <eggert@cs.ucla.edu>
8222
87e4427a
PE
8223 Fix minor problem found by static checking.
8224 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
8225 initialized, to pacify gcc -Wuninitialized.
8226
e5e9d610
PE
8227 * fileio.c: Report proper errno when syscall falls.
8228 (Finsert_file_contents): Save and restore errno,
8229 so that report_file_error outputs the correct diagnostic.
8230 (Fwrite_region) [CLASH_DETECTION]: Likewise.
8231
a1674f0b
EZ
82322011-09-18 Eli Zaretskii <eliz@gnu.org>
8233
8234 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
8235
fbfb6dd4
EZ
82362011-09-17 Eli Zaretskii <eliz@gnu.org>
8237
8238 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
8239 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
8240
bb187662
EZ
82412011-09-17 Eli Zaretskii <eliz@gnu.org>
8242
1137e8b8 8243 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 8244 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
8245
8246 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
8247 (bidi_find_paragraph_start): Search back for paragraph beginning
8248 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
8249 (bidi_move_to_visually_next): Only trigger paragraph-related
8250 computations when the last character is a newline or at EOB, not
8251 just any NEUTRAL_B. (Bug#9470)
8252
bb187662
EZ
8253 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
8254 truncated lines if point is covered by a display string. (Bug#9524)
8255
2e621251
PE
82562011-09-16 Paul Eggert <eggert@cs.ucla.edu>
8257
8258 * xselect.c: Relax test for outgoing X longs (Bug#9498).
8259 (cons_to_x_long): New function.
8260 (lisp_data_to_selection_data): Use it. Correct the test for
8261 short-versus-long data; it was negated. Break out of vector
8262 loop, for efficiency, when a long datum is discovered.
8263
91a15bc6
SM
82642011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
8265
8266 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
8267
b41c3a35
EZ
82682011-09-16 Eli Zaretskii <eliz@gnu.org>
8269
8270 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
8271 GCC PR/17406) by declaring this function with external scope.
8272
7812ba2d
PE
82732011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8274
8275 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
8276 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
8277
cf7edc2a
AS
82782011-09-15 Andreas Schwab <schwab@linux-m68k.org>
8279
8280 * editfns.c (Fformat): Correctly handle text properties on "%%".
8281
bd01620e
EZ
82822011-09-15 Eli Zaretskii <eliz@gnu.org>
8283
8284 * xterm.c (x_draw_composite_glyph_string_foreground):
8285 * w32term.c (x_draw_composite_glyph_string_foreground):
8286 * term.c (encode_terminal_code):
8287 * composite.c (composition_update_it, get_composition_id):
8288 * xdisp.c (get_next_display_element)
8289 (fill_composite_glyph_string): Add comments about special meaning
8290 of TAB characters in a composition.
8291
a02719a3
PE
82922011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8293
8294 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
8295 This occurs when processing a multibyte format.
8296 Problem reported by Wolfgang Jenker.
a02719a3 8297
72589a3c
JB
82982011-09-15 Johan Bockgård <bojohan@gnu.org>
8299
8300 * xdisp.c (try_cursor_movement): Only check for exact match if
8301 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
8302
1c14176c
PE
83032011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8304
8305 Remove unused external symbols.
8306 * dispextern.h (calc_pixel_width_or_height): Remove decl.
8307 * xdisp.c (calc_pixel_width_or_height): Now static.
8308 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
8309 * indent.c (check_display_width):
8310 * w32term.c: Fix comment to match code.
8311 * xterm.c, xterm.h (x_catching_errors): Remove.
8312
d2eea5b5
PE
83132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8314
8315 * xselect.c: Use signed conversions more consistently (Bug#9498).
8316 (selection_data_to_lisp_data): Assume incoming selection data are
8317 signed integers, not unsigned. This is to be consistent with
8318 outgoing selection data, which was modified to use signed integers
8319 in as part of the fix to Bug#9196 in response to Jan D.'s comment
8320 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
8321 expects long, not unsigned long.
8322
46888499
EZ
83232011-09-14 Eli Zaretskii <eliz@gnu.org>
8324
8325 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
8326 computation of loop end. Reported by Johan Bockgård
8327 <bojohan@gnu.org>.
8328
ef8ef9fb
CY
83292011-09-13 Chong Yidong <cyd@stupidchicken.com>
8330
8331 * frame.c (Fother_visible_frames_p): Function deleted.
8332
fa819fed
EZ
83332011-09-12 Eli Zaretskii <eliz@gnu.org>
8334
8335 * indent.c (compute_motion): Process display vector front to back
8336 rather than the other way around. (Bug#2496)
8337
2ba8e008
SM
83382011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
8339
8340 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
8341
20f53c69
CY
83422011-09-11 Chong Yidong <cyd@stupidchicken.com>
8343
8344 * minibuf.c (Fread_from_minibuffer): Doc fix.
8345
d562d7a4
EZ
83462011-09-11 Eli Zaretskii <eliz@gnu.org>
8347
8348 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
8349 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
8350
1c4d7f3d
LMI
83512011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8352
8353 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
8354 value for non-existent files.
8355
b885bf36
EZ
83562011-09-11 Eli Zaretskii <eliz@gnu.org>
8357
8358 * fileio.c (Finsert_file_contents): If the file cannot be opened,
8359 set its "size" to -1. This will set the modtime_size field of
8360 the corresponding buffer to -1, which is what
8361 verify-visited-file-modtime expects for files that do not exist.
8362 (Bug#9139)
8363
6612f0bf
PE
83642011-09-11 Paul Eggert <eggert@cs.ucla.edu>
8365
8366 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
8367 here ...
8368 * lisp.h: ... from here. push_key_description is no longer
8369 defined in keyboard.c, so its declaration should not be in
8370 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
8371 logically belongs with push_key_description.
8372
dfb3f755
PE
83732011-09-10 Paul Eggert <eggert@cs.ucla.edu>
8374
8375 * buffer.h: Include <sys/types.h> instead of <time.h>.
8376 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
8377 Problem reported by Herbert J. Skuhra.
8378
3134906c
LMI
83792011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8380
8381 * xml.c (parse_region): Make the parsing work for
8382 non-comment-starting XML files again (bug#9144).
8383
8d903f4e
AS
83842011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8385
8386 * image.c (gif_load): Fix calculation of bottom and right corner.
8387 (Bug#9468)
8388
80ad64f4
EZ
83892011-09-10 Eli Zaretskii <eliz@gnu.org>
8390
8391 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
8392 redisplay in small windows.
8393
208a048d
EZ
83942011-09-09 Eli Zaretskii <eliz@gnu.org>
8395
8396 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
8397
9b1c252e
MR
83982011-09-08 Martin Rudalics <rudalics@gmx.at>
8399
8400 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8401 Operate on live windows only.
8402
2949f33b
JB
84032011-09-08 Juanma Barranquero <lekktu@gmail.com>
8404
8405 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8406
e08dcafd
EZ
84072011-09-07 Eli Zaretskii <eliz@gnu.org>
8408
8409 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8410 only under bidi iteration.
8411
115b96bd
JD
84122011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8413
8414 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8415
c8199d0f
PE
84162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8417
8418 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8419 Without this fix, the command to link temacs failed due to an
8420 undefined symbol __builtin_isnan. This is because
8421 /usr/include/iso/math_c99.h #defines isnan(x) to
8422 __builtin_isnan(x), but the bundled gcc, which identifies itself
8423 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8424 a __builtin_isnan.
8425 * floatfns.c (isnan): #undef, and then #define to a clone of
8426 what's in data.c.
8427 (Fisnan): Always define, since it's always available now.
8428 (syms_of_floatfns): Always define isnan at the Lisp level.
8429
e39b275c 84302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8431
8432 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8433
b2db44d9 84342011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8435
f4af5137 8436 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8437 The previous code assumed that file offsets (off_t values) fit in
8438 EMACS_INT variables, which is not true on typical 32-bit hosts.
8439 The code messed up by falsely reporting buffer overflow in cases
8440 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8441 when "big" contains more than 2**29 bytes, even though this
8442 inserts just one byte and does not overflow the buffer.
8443 (Finsert_file_contents): Store file offsets as off_t
8444 values, not as EMACS_INT values. Check for overflow when
8445 converting between EMACS_INT and off_t. When checking for
8446 buffer overflow or for overlap, take the offsets into account.
8447 Don't use EMACS_INT for small values where int suffices.
8448 When checking for overlap, fix a typo: ZV was used where
8449 ZV_BYTE was intended.
8450 (Fwrite_region): Don't assume off_t fits into 'long'.
8451 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8452
ecfc0a49
MA
84532011-09-05 Michael Albinus <michael.albinus@gmx.de>
8454
8455 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8456
6511acf2 84572011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8458
0999621a 8459 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8460
8461 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8462 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8463 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8464 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8465 (modify_event_symbol): Do not assume that the length of
8466 name_alist_or_stem is safe to alloca and fits in int.
8467 (Fexecute_extended_command): Likewise for function name and binding.
8468 (Frecursion_depth): Wrap around reliably on integer overflow.
8469 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8470 since some callers pass EMACS_INT values.
8471 (Fsingle_key_description): Don't crash if symbol name contains more
8472 than MAX_ALLOCA bytes.
8473 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8474 (get_minibuffer): Arg is now EMACS_INT, not int.
8475 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8476 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8477 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8478
2be7d702
PE
8479 * dbusbind.c (signature_cat): New function.
8480 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8481 Do not overrun buffer; instead, report string overflow.
8482
9d1df220
PE
8483 * dispnew.c (add_window_display_history): Don't overrun buffer.
8484 Truncate instead; this is OK since it's just a log.
8485
33ef5c64
PE
8486 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8487 even if the time zone offset is outlandishly large.
8488 Don't mishandle offset == INT_MIN.
8489
66c6fdd5
PE
8490 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8491 when creating daemon; the previous buffer-overflow check was incorrect.
8492
d749b01b
PE
8493 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8494 which has the guts of the old verror function.
8495
b5cd1905
PE
8496 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8497 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8498
6e1a67fb
PE
8499 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8500 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8501 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8502 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8503 length of string rather than counting it via multiple sprintfs;
8504 that's simpler and more reliable.
c21721cc
PE
8505 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8506 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8507 sprintf, in case result does not fit in int.
8508
c57b67fc
PE
8509 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8510 (fontset_from_font): Print it.
8511
8a401434
PE
8512 * frame.c (tty_frame_count): Now printmax_t, not int.
8513 (make_terminal_frame, set_term_frame_name): Print it.
8514 (x_report_frame_params): In X, window IDs are unsigned long,
8515 not signed long, so print them as unsigned.
8516 (validate_x_resource_name): Check for implausibly long names,
8517 and don't assume name length fits in 'int'.
8518 (x_get_resource_string): Don't blindly alloca invocation name;
8519 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8520 not fit in int.
8521
6e1a67fb
PE
8522 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8523 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8524 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8525
0df02bf3
PE
8526 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8527 Use esprintf, not sprintf, in case result does not fit in int.
8528
48e30793
PE
8529 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8530 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8531 it as a large positive number.
8532 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8533 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8534
a66ff6d8
PE
8535 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8536 in case result does not fit in int.
8537
aca216ff
PE
8538 * print.c (float_to_string): Detect width overflow more reliably.
8539 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8540 buffer overrun. Don't assume list length fits in 'int'. Treat
8541 print length of 0 as 0, not as infinity; to be consistent with other
8542 uses of print length in this function. Don't overflow print length
8543 index. Don't assume hash table size fits in 'long', or that
8544 vectorlike size fits in 'unsigned long'.
8545
31c286f7
PE
8546 * process.c (make_process): Use printmax_t, not int, to format
8547 process-name gensyms.
8548
55e5faa1
PE
8549 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8550
80f2e268
PE
8551 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8552 to avoid potential buffer overrun.
8553
670741ab
PE
8554 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8555 if X resource line is longer than 512 bytes.
8556
b7163a50
PE
8557 * xfns.c (x_window): Make sprintf buffer a bit bigger
8558 to avoid potential buffer overrun.
8559
ae58ff1f
PE
8560 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8561
c43c8a6a
PE
8562 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8563
3f8236f4
PE
85642011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8565
53e9fe90 8566 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8567 Without these, Emacs silently mishandles large integers sometimes.
8568 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8569 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8570
6511acf2
PE
8571 * xdisp.c (try_window_id): Check Emacs fixnum range before
8572 converting to 'int'.
806add1d 8573
6511acf2 8574 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8575 Check that an Emacs fixnum is in range before assigning it to 'int'.
8576 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8577 values converted from Emacs fixnums.
8578 (Frecenter): Don't wrap around a line count if it is out of 'int'
8579 range; instead, treat it as an extreme value.
8580 (Fset_window_configuration, compare_window_configurations):
8581 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8582
6511acf2
PE
8583 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8584 that can exceed INT_MAX. Check that EMACS_INT value is in range
8585 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8586 (match_limit): Don't assume that a fixnum can fit in 'int'.
8587
6511acf2 8588 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8589 exceed INT_MAX.
8590
6511acf2 8591 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8592 (Fvertical_motion): Don't wrap around LINES values that don't fit
8593 in 'int'. Instead, treat them as extreme values. This is good
8594 enough for windows, which can't have more than INT_MAX lines anyway.
8595
fcb901a7
LMI
85962011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8597
0f2f6b6d
LMI
8598 * Require libxml/parser.h to avoid compilation warning.
8599
fcb901a7
LMI
8600 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8601
8602 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8603 since this reportedly can destroy thread storage.
8604
6e20a0d4
CY
86052011-08-30 Chong Yidong <cyd@stupidchicken.com>
8606
8607 * syntax.c (find_defun_start): Update all cache variables if
8608 exiting early (Bug#9401).
8609
148ae00e
EZ
86102011-08-30 Eli Zaretskii <eliz@gnu.org>
8611
f6cfbd8f
EZ
8612 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8613
148ae00e
EZ
8614 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8615 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8616 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8617
8618 * term.c (tty_append_glyph): New function.
8619 (produce_stretch_glyph): Static function and its prototype deleted.
8620
a66cfb1c
SM
8621 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8622 Add prototypes.
148ae00e 8623
c4a07a4c
PE
86242011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8625
8626 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8627 when checking :margin (Bug#9390).
8628 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8629 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8630 so that the name doesn't mislead. All uses changed.
8631
6bc8cd65
JB
86322011-08-28 Johan Bockgård <bojohan@gnu.org>
8633
8634 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8635 set_tty_hooks.
8636
dca4927e
EZ
86372011-08-27 Eli Zaretskii <eliz@gnu.org>
8638
8639 * xdisp.c (move_it_to): Don't bail out early when reaching
8640 position beyond to_charpos, if we are scanning backwards.
8641 (move_it_vertically_backward): When DY == 0, make sure we get to
8642 the first character in the line after the newline.
8643
f2cad773
PE
86442011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8645
8646 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8647 (ccl_driver): Do not generate an out-of-range pointer.
8648 (Fccl_execute_on_string): Remove unnecessary check for
8649 integer overflow, noted by Stefan Monnier in
8650 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8651 Remove a FIXME that didn't need fixing.
8652 Simplify the newly-introduced buffer reallocation code.
8653
0cae2cdb
JB
86542011-08-27 Juanma Barranquero <lekktu@gmail.com>
8655
8656 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8657
5fc295a4 86582011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8659
70c60eb2 8660 Integer and memory overflow issues (Bug#9196).
726e0ab1 8661
d31850da
PE
8662 * doc.c (get_doc_string): Rework so that
8663 get_doc_string_buffer_size is the actual buffer size, rather than
8664 being 1 less than the actual buffer size; this makes xpalloc more
8665 convenient.
8666
a69fbedb
PE
8667 * image.c (x_allocate_bitmap_record, cache_image):
8668 * xselect.c (Fx_register_dnd_atom):
8669 Simplify previous changes by using xpalloc.
8670
fe5c5d37
PE
8671 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8672 since either will do and ptrdiff_t is convenient with xpalloc.
8673
0065d054
PE
8674 * charset.c (charset_table_size)
8675 (struct charset_sort_data.priority): Now ptrdiff_t.
8676 (charset_compare): Don't overflow if priorities differ greatly.
8677 (Fsort_charsets): Don't assume list length fits in int.
8678 Check for size-calculation overflow when allocating sort data.
8679 (syms_of_charset): Allocate an initial charset table that is
8680 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8681
8682 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8683
8684 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8685 The actual value is always <= INT_MAX, and leaving it unsigned made
8686 overflow checking harder.
8687
8688 * dispextern.h (struct glyph_matrix.rows_allocated)
8689 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8690 with xpalloc. The values are still always <= INT_MAX.
8691
8692 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8693
8694 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8695 (SAFE_NALLOCA): New macro.
8696
8697 * region-cache.c (struct boundary.pos, find_cache_boundary)
8698 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8699 (set_cache_region, invalidate_region_cache)
8700 (revalidate_region_cache, know_region_cache, region_cache_forward)
8701 (region_cache_backward, pp_cache):
8702 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8703 so that ptrdiff_t * can be passed to xpalloc.
8704 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8705 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8706 (pp_cache): Don't assume cache_len fits in int.
8707 * region-cache.h: Adjust extern decls to match.
8708
8709 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8710 EMACS_INT, since either will do, for xpalloc.
8711
8712 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8713 (xnmalloc, xnrealloc, xpalloc): New functions.
8714
726e0ab1
PE
8715 * bidi.c (bidi_shelve_header_size): New constant.
8716 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8717 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8718
51f30bc5 8719 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8720 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8721 (overlay_strings):
8722 Don't update size of array until after memory allocation succeeds,
8723 because xmalloc/xrealloc may not return.
0065d054
PE
8724 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8725 now that we have proper integer overflow checking.
8726 (record_overlay_string, overlay_strings): Catch overflows when
8727 calculating size of overlay_str_buf.
726e0ab1 8728
0065d054
PE
8729 * callproc.c (Fcall_process): Check for size overflow when
8730 calculating size of args2.
8731 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8732 Normally we prefer signed values, but sticking with ptrdiff_t would
8733 require adding more-complicated checks.
726e0ab1
PE
8734
8735 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8736 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8737 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8738 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8739
8740 * character.c (Fstring): Check for size-calculation overflow.
8741
8742 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8743 unnecessary integer overflow. Check for size overflow.
8744 (encode_coding_object): Don't update size until xmalloc succeeds.
8745
8746 * composite.c (get_composition_id): Check for overflow in glyph
8747 length calculations.
8748
8749 Integer and memory overflow fixes for display code.
8750 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8751 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8752 (scrolling_window): Check for overflow in size calculations.
8753 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8754 Don't assume glyph table len fits in int.
8755 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8756 (row_table_size): Now ptrdiff_t, not int.
8757 (scrolling_window): Avoid overflow in size calculations.
8758 Don't update size until allocation succeeds.
8759 * fns.c (concat): Check for overflow in size calculations.
8760 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8761 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8762 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8763
8764 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8765 (get_doc_string): Check for size calculation overflow.
8766 Don't update size until allocation succeeds.
8767 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8768 EMACS_INT, where ptrdiff_t will do.
8769 (Fsubstitute_command_keys): Check for string overflow.
8770
8771 * editfns.c (set_time_zone_rule): Don't assume environment length
8772 fits in int.
8773 (message_length): Now ptrdiff_t, not int.
8774 (Fmessage_box): Don't update size until allocation succeeds.
8775 Don't assume message length fits in int.
8776 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8777
0065d054
PE
8778 * emacs.c (main): Do not reallocate argv, since there is a null at
8779 the end that can be overwritten, and this way there's no need to
8780 worry about size-calculation overflow.
8781 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8782
8783 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8784 alloc succeeds.
8785 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8786
8787 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8788 (x_set_scroll_bar_width, x_figure_window_size):
8789 Check for integer overflow.
8790 (x_set_alpha): Do not assume XINT fits in int.
8791
8792 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8793 This is for the members text_lines, text_cols, total_lines, total_cols,
8794 where the system imposes an 'int' limit.
8795
8796 * fringe.c (Fdefine_fringe_bitmap):
8797 Don't update size until alloc works.
8798
8799 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8800 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8801
8802 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8803 Check for size-calculation overflow.
8804 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8805 do, as we prefer signed integers.
8806 (id_to_widget.max_size, id_to_widget.used)
8807 (xg_store_widget_in_map, xg_remove_widget_from_map)
8808 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8809 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8810 Use and return ptrdiff_t, not int.
8811 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8812 * gtkutil.h: Change prototypes to match the above.
8813
8814 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8815 are duplicate now that they've been promoted to lisp.h.
8816 (x_allocate_bitmap_record, x_alloc_image_color)
8817 (make_image_cache, cache_image, xpm_load):
8818 Don't update size until alloc is done.
8819 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8820 (x_detect_edges):
3256efce 8821 Check for size calculation overflow.
726e0ab1
PE
8822 (ct_colors_allocated_max): New constant.
8823 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8824 overflow.
3256efce 8825
726e0ab1
PE
8826 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8827 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8828 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8829 Use ptrdiff_t, not int, to count maps.
8830 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8831 calculations. Don't update size until allocation succeeds.
8832 Redo calculations to avoid overflow.
726e0ab1
PE
8833 * keyboard.h: Change prototypes to match the above.
8834
8835 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8836 to count maps.
8837 (current_minor_maps): Check for size calculation overflow.
8838 * keymap.h: Change prototypes to match the above.
8839
8840 * lread.c (read1, init_obarray): Don't update size until alloc done.
8841
8842 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8843 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8844
726e0ab1
PE
8845 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8846 Now ptrdiff_t, not int.
8847 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8848 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8849
8850 * process.c (Fnetwork_interface_list): Check for overflow
8851 in size calculation.
8852
8853 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8854
8855 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8856 overflow. Don't bother calling xmalloc when xrealloc will do.
8857
8858 * search.c (Freplace_match): Check for size calculation overflow.
8859 (Fset_match_data): Don't assume list lengths fit in 'int'.
8860
8861 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8862 for command line length. Do not attempt to address one before the
8863 beginning of an array, as that's not portable.
8864
8865 * term.c (max_frame_lines): Remove; unused.
8866 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8867 not int.
8868 (encode_terminal_code, calculate_costs): Check for size
8869 calculation overflow.
8870 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8871 table lengths and related sizes. Don't update size until alloc
8872 done. Redo calculations to avoid overflow.
8873 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8874
8875 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8876 subtracting pointers.
8877 (gobble_line): Check for overflow more carefully. Don't update size
8878 until alloc done.
8879
8880 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8881 Don't update size until alloc done.
8882 Redo size calculations to avoid overflow.
8883 Check for size calculation overflow.
0065d054 8884 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8885
8886 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8887 Use ptrdiff_t, not int, for sizes.
8888 (store_mode_line_noprop_char): Don't update size until alloc done.
8889
0065d054
PE
8890 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8891 Use ptrdiff_t, not int, for sizes.
8892 (Finternal_make_lisp_face, cache_face):
8893 Check for size calculation overflow.
8894 (cache_face): Treat size calculation overflows as if they were
8895 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8896
8897 * xfns.c (x_encode_text, x_set_name_internal)
8898 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8899 sizes, since they can exceed INT_MAX in size. Check for size
8900 calculation overflow.
8901
0065d054
PE
8902 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8903 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8904 Don't update size until alloc done.
8905
0065d054 8906 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8907 as sprintf is limited to int lengths.
1d526e2f 8908
252c5ee1
PE
8909 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8910 (X_LONG_MIN): New macros.
864d7ce7
PE
8911 Use them to make the following changes clearer.
8912 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8913 This change doesn't affect the value now, but it may help remind
8914 future maintainers not to raise the value too much later.
8915 (SELECTION_QUANTUM): Remove, replacing with ...
8916 (selection_quantum): ... new function, which avoids overflow.
8917 All uses changed.
8918 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8919 assumption that selection length fits in 'int'.
8920 (x_reply_selection_request, x_handle_selection_request)
8921 (x_get_window_property, receive_incremental_selection)
8922 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8923 (lisp_data_to_selection_data, clean_local_selection_data):
8924 Use ptrdiff_t, not int, to record length of selection.
8925 (x_reply_selection_request, x_get_window_property)
8926 (receive_incremental_selection, x_property_data_to_lisp):
8927 Redo calculations to avoid overflow.
8928 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8929 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8930 something.
8931 (x_get_window_property, receive_incremental_selection)
8932 (lisp_data_to_selection_data, x_property_data_to_lisp):
8933 Check for size-calculation overflow.
8934 (x_get_window_property, receive_incremental_selection)
8935 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8936 Don't store size until memory allocation succeeds.
8937 (x_get_window_property): Plug memory leak on memory exhaustion.
8938 Don't double-block input; malloc is safe here. Don't assume 2**34
8939 - 4 fits in unsigned long. Add an xassert to check
8940 XGetWindowProperty overflow. Be more careful about overflow
8941 calculations, and distinguish size from memory overflow better.
8942 (receive_incremental_selection): When tracing, don't assume
8943 unsigned int is less than INT_MAX.
8944 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8945 harmful) conversions of unsigned short to int.
8946 (lisp_data_to_selection_data): Don't assume that integers
8947 in the range -65535 through -1 fit in an X unsigned short.
8948 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8949 result parameters unless successful. Rely on cons_to_unsigned
8950 to report problems with elements; the old code wasn't right anyway.
8951 (x_check_property_data): Check for int overflow; we cannot use
8952 a wider type due to X limits.
8953 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8954
726e0ab1 8955 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8956
0065d054
PE
8957 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8958 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8959 (x_color_cells): Don't store size until memory allocation succeeds.
8960 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8961 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8962 (x_term_init): Don't assume length fits in int (sprintf is limited
8963 to int size).
bc18e09d 8964
ebfa62c0
PE
8965 Use ptrdiff_t for composition IDs.
8966 * character.c (lisp_string_width):
8967 * composite.c (composition_table_size, n_compositions)
8968 (get_composition_id, composition_gstring_from_id):
8969 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8970 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8971 * window.c (Frecenter):
8972 Use ptrdiff_t, not int, for composition IDs.
8973 * composite.c (get_composition_id): Check for integer overflow.
8974 * composite.h: Adjust prototypes to match the above changes.
8975
d3411f89
PE
8976 Use ptrdiff_t for hash table indexes.
8977 * category.c (hash_get_category_set):
8978 * ccl.c (ccl_driver):
8979 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8980 * coding.c (coding_system_charset_list, detect_coding_system):
8981 * coding.h (struct coding_system.id):
8982 * composite.c (get_composition_id, gstring_lookup_cache):
8983 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8984 * image.c (xpm_get_color_table_h):
8985 * lisp.h (hash_lookup, hash_put):
8986 * minibuf.c (Ftest_completion):
8987 Use ptrdiff_t for hash table indexes, not int (which is too
8988 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8989 32-bit --with-wide-int hosts).
8990
e097a6fa
PE
8991 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8992 Add a FIXME comment about memory leaks.
8993 (syms_of_charset): Don't assume xmalloc returns.
8994
5637687f
PE
8995 Don't assume that stated character widths fit in int.
8996 * character.c (Fchar_width, c_string_width, lisp_string_width):
8997 * character.h (CHAR_WIDTH):
8998 * indent.c (MULTIBYTE_BYTES_WIDTH):
8999 Use sanitize_char_width to avoid undefined and/or bad behavior
9000 with outlandish widths.
a66cfb1c 9001 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
9002 now that we have two such functions. All uses changed.
9003 (sanitize_char_width): New inline function.
9004
a2271ba2
PE
9005 Don't assume that tab-width fits in int.
9006 * character.h (sanitize_width): New inline function.
9007 (SANE_TAB_WIDTH): New macro.
9008 (ASCII_CHAR_WIDTH): Use it.
9009 * indent.c (sane_tab_width): Remove. All uses replaced by
9010 SANE_TAB_WIDTH (current_buffer).
9011 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
9012
18c52557
PE
9013 * fileio.c: Integer overflow issues with file modes.
9014 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
9015
caeeedc1
PE
9016 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
9017 Remove unreachable code.
9018 (read_hex, load_charset_map_from_file): Check for integer overflow.
9019
6df6ae42 9020 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
9021 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
9022 (x_send_scroll_bar_event): Likewise. Check that the size does not
9023 exceed limits imposed by XClientMessageEvent, as well as the usual
9024 ptrdiff_t and size_t limits.
9025
b13995db
PE
9026 * keyboard.c: Overflow, signedness and related fixes.
9027 (make_lispy_movement): Use same integer type in forward decl
9028 that is used in the definition.
9029 (read_key_sequence, keyremap_step):
9030 Change bufsize argument back to int, undoing my 2011-03-30 change.
9031 We prefer signed types, and int is wide enough here.
9032 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
9033 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
9034 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
9035 length, not size_t. Use ptrdiff_t for index, not int.
9036 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
9037 possibility of integer overflow.
9038
13464394
PE
9039 Overflow, signedness and related fixes for images.
9040
9041 * dispextern.h (struct it.stack[0].u.image.image_id)
9042 (struct_it.image_id, struct image.id, struct image_cache.size)
9043 (struct image_cache.used, struct image_cache.ref_count):
9044 * gtkutil.c (update_frame_tool_bar):
9045 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
9046 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
9047 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
9048 * nsmenu.m (update_frame_tool_bar):
9049 * xdisp.c (calc_pixel_width_or_height):
9050 * xfns.c (image_cache_refcount):
9051 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
9052 on typical 64-bit hosts.
9053
9054 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9055 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
9056 Omit unnecessary casts to int.
9057 (parse_image_spec): Check that integers fall into 'int' range
9058 when the callers expect that.
9059 (image_ascent): Redo ascent calculation to avoid int overflow.
9060 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
9061 (lookup_image): Remove unnecessary tests.
9062 (xbm_image_p): Locals are now of int, not EMACS_INT,
9063 since parse_image_check makes sure they fit into int.
9064 (png_load, gif_load, svg_load_image):
9065 Prefer int to unsigned where either will do.
9066 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
9067 old tiff_error_handler and tiff_warning_handler.
9068 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
9069 stack buffer overflows. It uses only the features of vsnprintf
9070 that are common to both POSIX and native Microsoft.
9071 (tiff_error_handler, tiff_warning_handler): Use it.
9072 (tiff_load, gif_load, imagemagick_load_image):
9073 Don't assume :index value fits in 'int'.
9074 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
9075 (imagemagick_load_image): Check that crop parameters fit into
9076 the integer types that MagickCropImage accepts. Don't assume
9077 Vimagemagick_render_type has a nonnegative value. Don't assume
9078 size_t fits in 'long'.
9079 (gs_load): Use printmax_t to print the widest integers possible.
9080 Check for integer overflow when computing image height and width.
9081
c11821d4
EZ
90822011-08-26 Eli Zaretskii <eliz@gnu.org>
9083
9084 * xdisp.c (redisplay_window): Don't force window start if point
9085 will be invisible in the resulting window. (Bug#9324)
9086
0c95fcf7
EZ
90872011-08-25 Eli Zaretskii <eliz@gnu.org>
9088
9089 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
9090 the display spec is of the form `(space ...)'.
9091 (handle_display_spec): Return the value returned by
9092 handle_single_display_spec, not just 1 or zero.
9093 (handle_single_display_spec): If the display spec is of the form
9094 `(space ...)', and specifies display in the text area, return 2
9095 rather than 1.
fee65a97 9096 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
9097 accurately, and prefer exact match for point under bidi.
9098 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
9099
9100 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
9101 into disp_prop; all users changed.
9102
9103 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
9104 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
9105 for the text covered by the display property.
9106
e4ed06f1
CY
91072011-08-25 Chong Yidong <cyd@stupidchicken.com>
9108
9109 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
9110 Change return value to nil.
9111 (Frecord_buffer): Delete unused function.
9112
f67cdd7f
EZ
91132011-08-24 Eli Zaretskii <eliz@gnu.org>
9114
5980d4c6
EZ
9115 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
9116 buffers, return left-to-right.
8610fe8b
EZ
9117 (set_cursor_from_row): Consider candidate row a win if its glyph
9118 represents a newline and point is on that newline. Fixes cursor
9119 positioning on the newline at EOL of R2L text within L2R
9120 paragraph, and vice versa.
9121 (try_cursor_movement): Check continued rows, in addition to
9122 continuation rows. Fixes unwarranted scroll when point enters a
9123 continued line of R2L text within an L2R paragraph, or vice versa.
9124 (cursor_row_p): Consider the case of point being equal to
9125 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
9126 from the end of a short line to the beginning of a continued line
9127 of R2L text within L2R paragraph.
9128 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
9129 composed characters.
5980d4c6 9130
f67cdd7f
EZ
9131 * bidi.c (bidi_check_type): Use xassert.
9132 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
9133 members.
9134
bca633fb
EZ
91352011-08-23 Eli Zaretskii <eliz@gnu.org>
9136
9137 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
9138 a character.
9139
4a5885a7
CY
91402011-08-23 Chong Yidong <cyd@stupidchicken.com>
9141
9142 * nsfont.m (ns_otf_to_script): Fix typo.
9143
0902a04e
KH
91442011-08-22 Kenichi Handa <handa@m17n.org>
9145
9146 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
9147 extra slot even if the purpose is char-code-property-table.
9148
1a2e6670
EZ
91492011-08-23 Eli Zaretskii <eliz@gnu.org>
9150
8ddde651
EZ
9151 * xdisp.c (redisplay_window): When computing centering_position,
9152 account for the height of the header line. (Bug#8874)
9153
425cc014
EZ
9154 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
9155 instead of CHAR_TO_BYTE. Fixes a crash when a completion
9156 candidate is selected by the mouse, and that candidate has a
9157 composed character under the mouse.
9158
1a2e6670
EZ
9159 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
9160 coordinates reported by pos-visible-in-window-p for a composed
9161 character in column zero.
9162
8b76d6f8
SM
91632011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
9164
9165 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
9166
dac347dd
EZ
91672011-08-22 Eli Zaretskii <eliz@gnu.org>
9168
9169 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
9170 consider it a hit if to_charpos is anywhere in the range of the
9171 composed buffer positions.
9172
e013fb34
CY
91732011-08-22 Chong Yidong <cyd@stupidchicken.com>
9174
9175 * image.c (gif_load): Don't assume that each subimage has the same
9176 dimensions as the base image. Handle disposal method that is
9177 "undefined" by the gif spec (Bug#9335).
9178
bd1ba3e8
CY
91792011-08-20 Chong Yidong <cyd@stupidchicken.com>
9180
9181 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 9182 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 9183
54a1215b
EZ
91842011-08-19 Eli Zaretskii <eliz@gnu.org>
9185
823564e5
EZ
9186 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
9187 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
9188 from an Org mode buffer to a Speedbar frame.
9189
54a1215b
EZ
9190 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
9191 a composition, take its buffer position from IT->cmp_it.charpos.
9192 Fixes cursor positioning at the beginning of a line that begins
9193 with a composed character.
9194
9778ebcc
EZ
91952011-08-18 Eli Zaretskii <eliz@gnu.org>
9196
0be6ee06
EZ
9197 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
9198 character bidirectional type, use STRONG_L instead. Fixes crashes
9199 in a buffer produced by `describe-categories'.
9200
9778ebcc
EZ
9201 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
9202 members before the level stack, so they would be saved and
9203 restored when copying iterator state. Fixes incorrect reordering
9204 around TABs covered by display properties.
9205
156bffbe
AS
92062011-08-18 Andreas Schwab <schwab@linux-m68k.org>
9207
6b02f655 9208 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 9209
72ad093b
CY
92102011-08-17 Chong Yidong <cyd@stupidchicken.com>
9211
9212 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
9213 (internal_condition_case_2, internal_condition_case_n):
9214 Remove unnecessary aborts (Bug#9081).
72ad093b 9215
35774242
EZ
92162011-08-17 Eli Zaretskii <eliz@gnu.org>
9217
9218 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
9219 has no `load' handler, try opening the file locally. (Bug#9311)
9220
db76dd85
KB
92212011-08-16 Ken Brown <kbrown@cornell.edu>
9222
9223 * gmalloc.c: Expand comment.
9224
b215eee5
EZ
92252011-08-16 Eli Zaretskii <eliz@gnu.org>
9226
9227 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
9228 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
9229
a4579d33
KB
92302011-08-16 Ken Brown <kbrown@cornell.edu>
9231
9232 Fix memory allocation problems in Cygwin build (Bug#9273).
9233
9234 * unexcw.c ( __malloc_initialized): Declare external variable.
9235 (fixup_executable): Force the dumped emacs to reinitialize malloc.
9236
8b76d6f8
SM
9237 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
9238 New variables.
a4579d33
KB
9239 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
9240 dumped emacs.
9241 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
9242 in the static heap.
9243 [CYGWIN] (special_realloc): New function.
9244 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
9245 requests to realloc storage in the static heap.
9246
3ebec551
PE
92472011-08-15 Paul Eggert <eggert@cs.ucla.edu>
9248
9249 * bidi.c (bidi_initialize): Remove unused local.
9250
9fd8be00
EZ
92512011-08-15 Eli Zaretskii <eliz@gnu.org>
9252
6b02f655
SM
9253 * bidimirror.h:
9254 * biditype.h: Remove file.
9255 * makefile.w32-in ($(BLD)/bidi.$(O)):
9256 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
9257
9258 * dispextern.h: Fix a typo in the comment to bidi_type_t.
9259
9260 * chartab.c: Improve commentary for the uniprop_table API.
9261
32413314
EZ
9262 * bidi.c (bidi_paragraph_init): Support zero value of
9263 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
9264 (bidi_initialize): Use uniprop_table instead of including
9265 biditype.h and bidimirror.h.
32413314 9266
9fd8be00
EZ
9267 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
9268 coordinates of the iterator when restoring from ppos_it.
9269 (Bug#9296)
9270
5cf2b69b
KH
92712011-08-14 Kenichi Handa <handa@m17n.org>
9272
9273 * process.c (create_process): Call setup_process_coding_systems
72ad093b 9274 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 9275
daf17d00
EZ
92762011-08-14 Eli Zaretskii <eliz@gnu.org>
9277
9278 * xdisp.c (move_it_in_display_line_to): Don't invoke
9279 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
9280 ppos_it. Fixes vertical cursor motion when line beginning is
9281 covered by an image. (Bug#9296)
9282
08e3161a
JD
92832011-08-14 Jan Djärv <jan.h.d@swipnet.se>
9284
9285 * nsterm.h (ns_run_ascript): Declare.
9286 (NSAPP_DATA2_RUNASSCRIPT): Define.
9287
9288 * nsfns.m (as_script, as_result, as_status): New static variables.
9289 (ns_run_ascript): New function.
5e617bc2 9290 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
9291 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
9292 the event loop. Get status from as_status (Bug#7276).
9293
9294 * nsterm.m (sendEvent): If event is NSApplicationDefined and
9295 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
9296 the event loop (Bug#7276).
9297
a3720aa2
AS
92982011-08-14 Andreas Schwab <schwab@linux-m68k.org>
9299
9300 * gnutls.c (QCgnutls_bootprop_priority)
9301 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
9302 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
9303 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
9304 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
9305 (QCgnutls_bootprop_verify_hostname_error)
9306 (QCgnutls_bootprop_callbacks_verify): Rename from
9307 Qgnutls_bootprop_..., all uses changed.
9308
9309 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
9310 uses changed.
9311
0a0d27fb
PE
93122011-08-14 Paul Eggert <eggert@cs.ucla.edu>
9313
19d5c50c
PE
9314 * xfaces.c (Qframe_set_background_mode): Now static.
9315 * dispextern.h (Qframe_set_background_mode): Remove decl.
9316
0a0d27fb
PE
9317 * process.c (Fnetwork_interface_info): Declare local only if needed.
9318
377538cb
JD
93192011-08-13 Jan Djärv <jan.h.d@swipnet.se>
9320
9321 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
9322 (Fnetwork_interface_list): Allocate in increments of bytes instead
9323 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
9324 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
9325 sockaddr.
9326 (struct ifflag_def): notrailers is smart on OSX.
9327 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
9328 Get hardware address with getifaddrs if available.
9329
08fff70c
EZ
93302011-08-12 Eli Zaretskii <eliz@gnu.org>
9331
9332 * xdisp.c (iterate_out_of_display_property): xassert that
9333 IT->position is set to within IT->object's boundaries. Break from
9334 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
9335 when IT->position is set up wrongly due to some bug.
9336 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
9337 (push_display_prop): Allow GET_FROM_STRING as IT->method on
9338 entry. Force push_it to save on the stack the current
9339 buffer/string position, to be restored by pop_it. Fix flags in
9340 the iterator structure wrt the object coming from a display
9341 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
9342 properties. (Bug#9284)
9343
7be1c708 93442011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 9345
7be1c708
CY
9346 * fontset.c (fontset_get_font_group): Add proper type checks.
9347 (Bug#9172)
aac0c6e3 9348
7be1c708 93492011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 9350
7be1c708
CY
9351 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
9352 and LC_VERSION_MIN_MACOSX.
9353 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
9354 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 9355
97bb72a6
EZ
93562011-08-08 Eli Zaretskii <eliz@gnu.org>
9357
9358 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
9359 no-display-properties-and-no-overlays under bidi display.
9360 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 9361 properties and overlays.
97bb72a6 9362
d5617611
CY
93632011-08-08 Chong Yidong <cyd@stupidchicken.com>
9364
37e11a63
CY
9365 * editfns.c (Fset_time_zone_rule): Document relationship with the
9366 setenv function.
9367
d5617611
CY
9368 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
9369 the font entity extracted from the cache (Bug#8109).
9370
58872834
CY
93712011-08-07 Chong Yidong <cyd@stupidchicken.com>
9372
9373 * composite.c (autocmp_chars): Don't reset point. That is done by
9374 restore_point_unwind (Bug#5984).
9375
75bfc667
JL
93762011-08-07 Juri Linkov <juri@jurta.org>
9377
9378 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
9379 to show the arg `TIME' instead of `TIMEVAL'.
9380
d1410150
EZ
93812011-08-06 Eli Zaretskii <eliz@gnu.org>
9382
9383 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9384 display property strides EOL and includes a newline, as in
9385 longlines-mode. (Bug#9254)
75b771e4
EZ
9386 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
9387 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
9388
9389 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
9390 is non-zero, even if the data buffer is NULL. Fixes a crash in
9391 vertical-motion with longlines-mode. (Bug#9254)
9392
35928349
EZ
93932011-08-05 Eli Zaretskii <eliz@gnu.org>
9394
ec7cc85b
EZ
9395 * bidi.c <bidi_cache_total_alloc>: Now static.
9396 (bidi_initialize): Initialize bidi_cache_total_alloc.
9397
8b76d6f8 9398 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9399 cache. (Bug#9221)
9400
9401 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9402 amount allocated this far in `bidi_cache_total_alloc'.
9403 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9404 non-zero, only free the data buffer without restoring the cache
9405 contents. All callers changed.
9406
9407 * dispextern.h (bidi_unshelve_cache): Update prototype.
9408
9409 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9410 (move_it_in_display_line, move_it_to)
9411 (move_it_vertically_backward, move_it_by_lines): Replace the call
9412 to xfree to an equivalent call to bidi_unshelve_cache.
9413 (move_it_in_display_line_to): Fix logic of returning
412b6358 9414 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9415
e2e2423b
EZ
94162011-08-05 Eli Zaretskii <eliz@gnu.org>
9417
9418 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9419 came from a string character with a `cursor' property. (Bug#9229)
9420
ae9e757a
JD
94212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9422
9423 * Makefile.in (LIB_PTHREAD): New variable.
9424 (LIBES): Add LIB_PTHREAD (Bug#9216).
9425
9426 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9427 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9428
213bd7f2
AS
94292011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9430
6b02f655 9431 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9432
99aaf75f
JD
94332011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9434
9435 * xterm.c (x_find_topmost_parent): New function.
9436 (x_set_frame_alpha): Find topmost parent window with
9437 x_find_topmost_parent and set the property there also (bug#9181).
9438 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9439
c74e9d86
PE
94402011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9441
9442 * callproc.c (Fcall_process): Avoid vfork clobbering
9443 the local vars buffer, coding_systems, current_dir.
9444
640c8776
SM
94452011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9446
9447 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9448
f26d0e4c
PE
94492011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9450
8a10d76c
PE
9451 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9452 so that it is not optimized away.
9453
f26d0e4c
PE
9454 * xdisp.c (compute_display_string_pos): Remove unused local.
9455
55439c61
EZ
94562011-08-02 Eli Zaretskii <eliz@gnu.org>
9457
9458 Fix slow cursor motion and scrolling in large buffers with
9459 selective display, like Org Mode buffers. (Bug#9218)
9460
9461 * dispextern.h (struct bidi_it): New member disp_prop_p.
9462
9463 * xdisp.c: Remove one-slot cache of display string positions.
9464 (compute_display_string_pos): Accept an additional argument
5e617bc2 9465 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9466 for a display string or property. If found, set DISP_PROP_P
9467 non-zero.
9468
9469 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9470 DISP_PROP_P, and pass it to compute_display_string_pos.
9471 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9472 non-zero. All callers of bidi_fetch_char changed.
9473
fb33fa43
SM
94742011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9475
9476 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9477
b099e063
DM
94782010-12-03 Don March <don@ohspite.net>
9479
9480 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9481 last character M-[char] is translated to ESC [char] (bug#7541).
9482
5cc7f7af
KH
94832011-08-02 Kenichi Handa <handa@m17n.org>
9484
d0fffa3f 9485 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9486
9487 * chartab.c (uniprop_table): Make it non-static.
9488
525d5e6e
EZ
94892011-08-01 Eli Zaretskii <eliz@gnu.org>
9490
9491 * xdisp.c (forward_to_next_line_start): Accept additional argument
9492 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9493 on the newline.
9494 (reseat_at_next_visible_line_start): Use the bidi iterator state
9495 returned by forward_to_next_line_start to restore the state of
9496 it->bidi_it after backing up to previous newline. (Bug#9212)
9497
31011111
AS
94982011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9499
9500 * regex.c (re_comp): Protoize.
9501 (re_exec): Fix return type.
9502 (regexec): Fix type of `ret'. (Bug#9203)
9503
476371c4
PE
95042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9505
e5d76069
PE
9506 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9507 This is needed if max-image-size is a floating-point number.
9508
9a79b20c
AS
95092011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9510
9511 * print.c (print_object): Print empty symbol as ##.
9512
9513 * lread.c (read1): Read ## as empty symbol.
9514
d8c2fa78
AA
95152011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9516
9517 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9518 setting frame foreground color (Bug#9175).
9519 (x_set_background_color): Likewise.
9520
ffe57a7a
AA
9521 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9522 contents (Bug#9176).
9523 (EmacsTooltip -init): Remove bezels and add shadows to
9524 tooltip windows.
9525
bf3492a5
AA
9526 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9527 or scroll bar (Bug#8470).
9528
d55e9c53
AA
9529 * nsfont.m (nsfont_open): Remove assignment to voffset and
9530 unnecessary vars hshink, expand, hd, full_height, min_height.
9531 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9532
9533 * nsterm.h (nsfont_info): Remove voffset field.
9534
d8c2fa78 95352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9536
9537 Implement strike-through and overline on NextStep (Bug#8863).
9538
9539 * nsfont.m (nsfont_open): Use underline position provided by font,
9540 instead of hard-coded value of 2.
9541 (nsfont_draw): Call ns_draw_text_decoration instead.
9542
9543 * nsterm.h: Add declaration for ns_draw_text_decoration.
9544
9545 * nsterm.m (ns_draw_text_decoration): New function for drawing
9546 underline, overline, and strike-through.
9547 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9548 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9549 accommodate underlining, etc.
4843aac3 9550
4cc60b9b
EZ
95512011-07-28 Eli Zaretskii <eliz@gnu.org>
9552
bc7ece87
EZ
9553 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9554 default.
4cc60b9b 9555
476371c4
PE
95562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9557
66606eea
PE
9558 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9559 Without this fix, if a signal arrives just after memory fills up,
9560 'malloc' might be invoked reentrantly.
9561
476371c4
PE
9562 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9563 In other words, assume that every image size is allowed, on non-X
9564 hosts. This assumption is probably wrong, but it lets Emacs compile.
9565
f3fcc40d
AS
95662011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9567
9568 * regex.c (re_iswctype): Convert return values to boolean.
9569
350c992f
EZ
95702011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9571
9572 * xdisp.c (compute_display_string_pos): Don't use cached display
9573 string position if the buffer had its restriction changed.
9574 (Bug#9184)
9575
5266b4bb
PE
95762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9577
9578 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9579
2573a837 95802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9581
41f55ccd 9582 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9583
39e378da
PE
9584 * bidi.c: Integer size and overflow fixes.
9585 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9586 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9587 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9588 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9589 (bidi_find_other_level_edge):
9590 Use ptrdiff_t instead of EMACS_INT where either will do.
9591 This works better on 32-bit hosts configured --with-wide-int.
9592 (bidi_cache_ensure_space): Check for size-calculation overflow.
9593 Use % rather than repeated addition, for better worst-case speed.
9594 Don't set bidi_cache_size until after xrealloc returns, because it
9595 might not return.
9596 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9597 (bidi_cache_ensure_space): Also check that the bidi cache size
9598 does not exceed that of the largest Lisp string or buffer. See Eli
9599 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9600
5e927815
PE
9601 * alloc.c (__malloc_size_t): Remove.
9602 All uses replaced by size_t. See Andreas Schwab's note
9603 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9604
ca4aa935
PE
9605 * image.c: Improve checking for integer overflow.
9606 (check_image_size): Assume that f is nonnull, since
9607 it is always nonnull in practice. This is one less thing to
9608 worry about when checking for integer overflow later.
9609 (x_check_image_size): New function, which checks for integer
9610 overflow issues inside X.
9611 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9612 This removes the need for a memory_full check.
9613 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9614 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9615 (xbm_read_bitmap_data): Change locals back to 'int', since
9616 their values must fit in 'int'.
9617 (xpm_load_image, png_load, tiff_load):
9618 Invoke x_create_x_image_and_pixmap earlier,
9619 to avoid much needless work if the image is too large.
9620 (tiff_load): Treat overly large images as if
9621 x_create_x_image_and_pixmap failed, not as malloc failures.
9622 (gs_load): Use x_check_image_size.
9623
5f8f9cc2
PE
9624 * gtkutil.c: Omit integer casts.
9625 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9626 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9627
5adf60bc
PE
9628 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9629
c8907a93
PE
9630 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9631 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9632 would wrongly return t on a 64-bit host.
9633
e3c25c68
PE
9634 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9635 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9636 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9637 and therefore cause GCC to emit a bogus diagnostic in some cases.
9638
3f791afe
PE
9639 * image.c: Integer signedness and overflow and related fixes.
9640 This is not an exhaustive set of fixes, but it's time to
9641 record what I've got.
9642 (lookup_pixel_color, check_image_size): Remove redundant decls.
9643 (check_image_size): Don't assume that arbitrary EMACS_INT values
9644 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9645 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9646 (tiff_load, imagemagick_load_image):
9647 Check for overflow in size calculations.
9648 (x_create_x_image_and_pixmap): Remove unnecessary test for
9649 xmalloc returning NULL; that can't happen.
9650 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9651 (xpm_color_bucket): Use better integer hashing function.
9652 (xpm_cache_color): Don't possibly over-allocate memory.
9653 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9654 (gif_memory_source):
9655 Use ptrdiff_t, not int or size_t, to record sizes.
9656 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9657 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9658 either works, as we prefer signed integers.
9659 (tiff_read_from_memory, tiff_write_from_memory):
9660 Return tsize_t, not size_t, since that's what the TIFF API wants.
9661 (tiff_read_from_memory): Don't fail simply because the read would
9662 go past EOF; instead, return a short read.
9663 (tiff_load): Omit no-longer-needed casts.
9664 (Fimagemagick_types): Don't assume size fits into 'int'.
9665
3cc5a532
PE
9666 Improve hashing quality when configured --with-wide-int.
9667 * fns.c (hash_string): New function, taken from sxhash_string.
9668 Do not discard information about ASCII character case; this
9669 discarding is no longer needed.
9670 (sxhash-string): Use it. Change sig to match it. Caller changed.
9671 * lisp.h: Declare it.
9672 * lread.c (hash_string): Remove, since we now use fns.c's version.
9673 The fns.c version returns a wider integer if --with-wide-int is
9674 specified, so this should help the quality of the hashing a bit.
9675
b312a492
PE
9676 * emacs.c: Integer overflow minor fix.
9677 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9678 Define only if GNU_LINUX.
9679 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9680
dfd153ae
PE
9681 * dispnew.c: Integer signedness and overflow fixes.
9682 Remove unnecessary forward decls, that were a maintenance hassle.
9683 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9684 All uses changed.
9685 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9686 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9687 (prepare_desired_row, line_draw_cost):
9688 Use int, not unsigned, where either works.
9689 (save_current_matrix, restore_current_matrix):
9690 Use ptrdiff_t, not size_t, where either works.
9691 (init_display): Check for overflow more accurately, and without
9692 relying on undefined behavior.
9693
a81d11a3
PE
9694 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9695 Remove, replacing with the new symbols in lisp.h. All uses changed.
9696 * fileio.c (make_temp_name):
9697 * filelock.c (lock_file_1, lock_file):
9698 * xdisp.c (message_dolog):
9699 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9700 Use pMd etc. instead.
9701 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9702 replacing the pWIDE etc. symbols removed from editfns.c.
9703
3300e6fd
PE
9704 * keyboard.h (num_input_events): Now uintmax_t.
9705 This is (very slightly) less likely to mess up due to wraparound.
9706 All uses changed.
9707
fd05c7e9
PE
9708 * buffer.c: Integer signedness fixes.
9709 (alloc_buffer_text, enlarge_buffer_text):
9710 Use ptrdiff_t rather than size_t when either will do, as we prefer
9711 signed integers.
9712
903fe15d
PE
9713 * alloc.c: Integer signedness and overflow fixes.
9714 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9715 (__malloc_size_t): Default to size_t, not to int.
9716 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9717 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9718 Prefer ptrdiff_t to size_t when either would do, as we prefer
9719 signed integers.
9720 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9721 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9722 Now const. Initialize with values that are in range even if char
9723 is signed.
9724 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9725 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9726 These functions do the right thing with sizes > 2**32.
9727 (check_depth): Now ptrdiff_t, not int.
9728 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9729 Adjust to new way of storing sizes. Check for size overflow bugs
9730 in rest of code.
9731 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9732 slightly wrong anyway, as it missed one instance of
9733 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9734 (refill_memory_reserve): Omit needless cast to size_t.
9735 (mark_object_loop_halt): Mark as externally visible.
9736
ac82cc6a
PE
9737 * xselect.c: Integer signedness and overflow fixes.
9738 (Fx_register_dnd_atom, x_handle_dnd_message):
9739 Use ptrdiff_t, not size_t, since we prefer signed.
9740 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9741 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9742 x_dnd_atoms_size and x_dnd_atoms_length.
9743
c2d1e36d
PE
9744 * doprnt.c: Prefer signed to unsigned when either works.
9745 * eval.c (verror):
9746 * doprnt.c (doprnt):
9747 * lisp.h (doprnt):
9748 * xdisp.c (vmessage):
9749 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9750 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9751 prefer signed arithmetic to avoid comparison confusion.
9752 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9753 but is a bit tricky.
9754
0e926e56
PE
9755 Assume freestanding C89 headers, string.h, stdlib.h.
9756 * data.c, doprnt.c, floatfns.c, print.c:
9757 Include float.h unconditionally.
9758 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9759 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9760 * regex.c: Likewise for stddef.h, string.h.
9761 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9762 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9763 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9764 (STDC_HEADERS): Remove obsolete defines.
9765 * sysdep.c: Include limits.h unconditionally.
9766
9cfdb3ec
PE
9767 Assume support for memcmp, memcpy, memmove, memset.
9768 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9769 * regex.c (memcmp, memcpy):
9770 Remove; we assume C89 now.
9771
9772 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9773 (__malloc_safe_bcopy): Remove; no longer needed.
9774
cf950e6b 9775 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9776 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9777 well either way, and we prefer signed to unsigned.
9778
dbf38e02
LMI
97792011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9780
9781 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9782 closes the connection while we're reading (bug#9182).
9783
d6f0886c 97842011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9785
d6f0886c
JD
9786 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9787 are specified (Bug#9168).
24e0f6b1 9788
2eb1f9e6
PE
97892011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9790
9791 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9792 Found by GCC static checking and --with-wide-int on a 32-bit host.
9793
22381272 97942011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9795
9796 * xdisp.c (compute_display_string_pos): Fix logic of caching
9797 previous display string position. Initialize cached_prev_pos to
9798 -1. Fixes slow-down at the beginning of a buffer.
9799
f25e39b4
EZ
98002011-07-24 Eli Zaretskii <eliz@gnu.org>
9801
9802 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9803 for attrs[LFACE_FONTSET_INDEX].
9804
04c4b52e
PE
98052011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9806
9807 * xml.c (parse_region): Remove unused local
9808 that was recently introduced.
9809
c1734fbd
EZ
98102011-07-23 Eli Zaretskii <eliz@gnu.org>
9811
be18c5a5
EZ
9812 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9813 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9814
c1734fbd
EZ
9815 * xdisp.c (move_it_in_display_line_to): Record the best matching
9816 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9817 exit if none of the characters scanned was an exact match.
9818 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9819 when exact match is impossible due to invisible text, and the
9820 lines are truncated.
9821
a258d627
JD
98222011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9823
9824 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9825 for OSX >= 10.7.
9826
b6d5a689
EZ
98272011-07-22 Eli Zaretskii <eliz@gnu.org>
9828
0f74f785
EZ
9829 Fix a significant slow-down of cursor motion with C-n, C-p,
9830 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9831 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9832 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9833 (next_element_from_buffer): Call compute_stop_pos_backwards to
9834 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9835 base_level_stop.
9836 (reseat): Don't look for prev_stop, as that could mean a very long
9837 run.
9838 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9839 <cached_disp_overlay_modiff>: Cache for last found display string
9840 position.
551918c1 9841 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9842 about the same buffer in the same area of character positions, and
9843 the buffer wasn't changed since the time the display string
9844 position was cached.
551918c1 9845
b2d0c91a
EZ
98462011-07-22 Eli Zaretskii <eliz@gnu.org>
9847
9848 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9849 is an integer, which is important for empty lines. (Bug#9149)
9850
043604ee
CY
98512011-07-22 Chong Yidong <cyd@stupidchicken.com>
9852
9853 * frame.c (Fmodify_frame_parameters): In tty case, update the
9854 default face if necessary (Bug#4238).
9855
da4adb04
CY
98562011-07-21 Chong Yidong <cyd@stupidchicken.com>
9857
9858 * editfns.c (Fstring_to_char): No need to explain what a character
9859 is in the docstring (Bug#6576).
9860
9abd0532
LMI
98612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9862
9863 * xml.c (parse_region): Make sure we always return a tree.
9864
36881d16
HK
98652011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9866
9867 * xml.c (parse_region): If a document contains only comments,
9868 return that, too.
9869
1e98674d
LMI
98702011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9871
9872 * xml.c (make_dom): Return comments, too.
9873
590bd467
PE
98742011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9875
9876 Port to OpenBSD.
9877 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9878 and the surrounding thread.
9879 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9880 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9881 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9882 timer goes off.
9883 * s/openbsd.h (BROKEN_SIGIO): Define.
9884 * unexelf.c (unexec) [__OpenBSD__]:
9885 Don't update the .mdebug section of the Alpha COFF symbol table.
9886
f41628b2
LMI
98872011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9888
9889 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9890 (bug#8460).
9891
b59b67c5
PE
98922011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9893
15e3a074
PE
9894 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9895 This fixes some race conditions on the permissions of any newly
9896 created file.
9897
41bed37d
PE
9898 * alloc.c (valid_pointer_p): Use pipe, not open.
9899 This fixes some permissions issues when debugging.
9900
b59b67c5
PE
9901 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9902 If fchown fails to set both uid and gid, try to set just gid,
9903 as that is sometimes allowed. Adjust the file's mode to eliminate
9904 setuid or setgid bits that are inappropriate if fchown fails.
9905
925a6be7
SM
99062011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9907
9908 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9909 to compare Lisp_Objects.
9910 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9911 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9912 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9913
52968808
AS
99142011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9915
0a6a104b
AS
9916 * lread.c (read_integer): Unread even EOF character.
9917 (read1): Likewise. Properly record start position of symbol.
9918
52968808
AS
9919 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9920 symbol character follows.
9921
9e381cdd
PE
99222011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9923
9924 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9925 This works around a problem with the previous change to Fcopy_file.
9926 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9927 and without this change, GCC might complain about discarding
9928 fchown's return value.
9929
b5641435
JB
99302011-07-16 Juanma Barranquero <lekktu@gmail.com>
9931
9932 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9933
a8031457
PE
99342011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9935
9936 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9937
dd889327
LMI
99382011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9939
750c33f7
LMI
9940 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9941 it's used from the C level.
9942
dd889327
LMI
9943 * process.c: Use the same condition for POLL_FOR_INPUT in both
9944 keyboard.c and process.c (bug#1858).
9945
87e86684
LM
99462011-07-09 Lawrence Mitchell <wence@gmx.li>
9947
9948 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9949 (Fgnutls_boot): Use it.
9950
64348f40
AS
99512011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9952
9953 * doc.c (Fsubstitute_command_keys): Revert last change.
9954
1d698799
LMI
99552011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9956
f863868c
LMI
9957 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9958 quotes the next character, and doesn't affect other longer
9959 sequences (bug#8935).
9960
1d698799
LMI
9961 * lread.c (syms_of_lread): Clarify that is isn't only
9962 `eval-buffer' and `eval-defun' that's affected by
9963 `lexical-binding' (bug#8460).
9964
aa4b6df6
EZ
99652011-07-15 Eli Zaretskii <eliz@gnu.org>
9966
9967 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9968 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9969
5d856da6
PE
99702011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9971
ad6042bb
PE
9972 Fix minor problems found by static checking.
9973 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9974 (elsz): Now a signed constant, not a size_t var. We prefer signed
9975 types to unsigned, to avoid integer comparison confusion. Without
9976 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9977 "cannot optimize loop, the loop counter may overflow", a symptom
9978 of the confusion.
f00bbb22 9979 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9980 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9981
6468f31c
LMI
99822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9983
49080b10
LMI
9984 * search.c (Fre_search_backward): Mention `case-fold-search' in
9985 all the re_search_* functions (bug#8138).
9986
6468f31c
LMI
9987 * keyboard.c (Fopen_dribble_file): Document when the file is
9988 closed (bug#8056).
9989
c965adc5
EZ
99902011-07-14 Eli Zaretskii <eliz@gnu.org>
9991
df9733bf
EZ
9992 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9993 bidi_cache_idx.
9994
0bb23927
EZ
9995 Support bidi reordering of display and overlay strings.
9996 * xdisp.c (compute_display_string_pos)
9997 (compute_display_string_end): Accept additional argument STRING.
9998 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9999 (reseat_to_string): Initialize bidi_it->string.s and
10000 bidi_it->string.schars.
10001 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
10002 NULL (avoids a crash in bidi_paragraph_init).
10003 Initialize itb.string.lstring.
0bb23927
EZ
10004 (init_iterator): Call bidi_init_it only of a valid
10005 buffer position was specified. Initialize paragraph_embedding to
10006 L2R.
10007 (reseat_to_string): Initialize the bidi iterator.
10008 (display_string): If we need to ignore text properties of
10009 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
10010 original value of -1 will not work with bidi.)
10011 (compute_display_string_pos): First arg is now struct
10012 `text_pos *'; all callers changed. Support display properties on
10013 Lisp strings.
10014 (compute_display_string_end): Support display properties on Lisp
10015 strings.
10016 (init_iterator, reseat_1, reseat_to_string): Initialize the
10017 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
10018 when iterating on a string not from display properties).
640c8776
SM
10019 (compute_display_string_pos, compute_display_string_end):
10020 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
10021 arrow keys.
10022 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
10023 base_level_stop; instead, set base_level_stop to BEGV.
10024 Fixes crashes in vertical-motion.
0bb23927
EZ
10025 (next_element_from_buffer): Improve commentary for when
10026 the iterator is before prev_stop.
10027 (init_iterator): Initialize bidi_p from the default value of
10028 bidi-display-reordering, not from buffer-local value. Use the
10029 buffer-local value only if initializing for buffer iteration.
10030 (handle_invisible_prop): Support invisible properties on strings
10031 that are being bidi-reordered.
10032 (set_iterator_to_next): Support bidi reordering of C strings and
10033 Lisp strings.
10034 (next_element_from_string): Support bidi reordering of Lisp
10035 strings.
10036 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
10037 (display_string): Support display of R2L glyph rows.
10038 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
10039 (init_iterator): Don't initialize it->bidi_p for strings
10040 here.
10041 (reseat_to_string): Initialize it->bidi_p for strings here.
10042 (next_element_from_string, next_element_from_c_string)
10043 (next_element_from_buffer): Add xassert's for correspondence
10044 between IT's object being iterated and it->bidi_it.string
10045 structure.
10046 (face_before_or_after_it_pos): Support bidi iteration.
10047 (next_element_from_c_string): Handle the case of the first string
10048 character that is not the first one in the visual order.
10049 (get_visually_first_element): New function, refactored from common
10050 parts of next_element_from_buffer, next_element_from_string, and
10051 next_element_from_c_string.
10052 (tool_bar_lines_needed, redisplay_tool_bar)
10053 (display_menu_bar): Force left-to-right direction. Add a FIXME
10054 comment for making that be controlled by a user option.
10055 (push_it, pop_it): Save and restore the state of the
10056 bidi iterator. Save and restore the bidi_p flag.
10057 (pop_it): Iterate out of display property for string iteration as
10058 well.
10059 (iterate_out_of_display_property): Support iteration over strings.
10060 (handle_single_display_spec): Set up it->bidi_it for iteration
10061 over a display string, and call bidi_init_it.
10062 (handle_single_display_spec, next_overlay_string)
10063 (get_overlay_strings_1, push_display_prop): Set up the bidi
10064 iterator for displaying display or overlay strings.
10065 (forward_to_next_line_start): Don't use the shortcut if
10066 bidi-iterating.
10067 (back_to_previous_visible_line_start): If handle_display_prop
10068 pushed the iterator stack, restore the internal state of the bidi
10069 iterator by calling bidi_pop_it same number of times.
10070 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
10071 and we are bidi-iterating, don't decrement the iterator position;
10072 instead, set the first_elt flag in the bidi iterator, to produce
10073 the same effect.
10074 (reseat_1): Remove redundant setting of string_from_display_prop_p.
10075 (push_display_prop): xassert that we are iterating a buffer.
10076 (push_it, pop_it): Save and restore paragraph_embedding member.
10077 (handle_single_display_spec, next_overlay_string)
10078 (get_overlay_strings_1, reseat_1, reseat_to_string)
10079 (push_display_prop): Set up the `unibyte' member of bidi_it.string
10080 correctly. Don't assume unibyte strings are not bidi-reordered.
10081 (compute_display_string_pos)
10082 (compute_display_string_end): Fix handling the case of C string.
10083 (push_it, pop_it): Save and restore from_disp_prop_p.
10084 (handle_single_display_spec, push_display_prop): Set the
10085 from_disp_prop_p flag.
10086 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
10087 (pop_it): Call iterate_out_of_display_property only if we are
10088 popping after iteration over a string that came from a display
10089 property. Fix a typo in popping stretch info. Add an assertion
10090 for verifying that the iterator position is in sync with the bidi
10091 iterator.
10092 (handle_single_display_spec, get_overlay_strings_1)
10093 (push_display_prop): Fix initialization of paragraph direction for
10094 string when that of the parent object is not yet determined.
10095 (reseat_1): Call bidi_init_it to resync the bidi
10096 iterator with IT's position. (Bug#7616)
10097 (find_row_edges): If ROW->start.pos gives position
10098 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
10099 (handle_stop, back_to_previous_visible_line_start, reseat_1):
10100 Reset the from_disp_prop_p flag.
10101 (SAVE_IT, RESTORE_IT): New macros.
10102 (pos_visible_p, face_before_or_after_it_pos)
10103 (back_to_previous_visible_line_start)
10104 (move_it_in_display_line_to, move_it_in_display_line)
10105 (move_it_to, move_it_vertically_backward, move_it_by_lines)
10106 (try_scrolling, redisplay_window, display_line): Use them when
10107 saving a temporary copy of the iterator and restoring it back.
10108 (back_to_previous_visible_line_start, reseat_1)
10109 (init_iterator): Empty the bidi cache "stack".
10110 (move_it_in_display_line_to): If iterator ended up at
10111 EOL, but we never saw any buffer positions smaller than
10112 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
10113 motion in bidi-reordered lines.
10114 (move_it_in_display_line_to): Record prev_method and prev_pos
10115 immediately before the call to set_iterator_to_next. Fixes cursor
10116 motion in bidi-reordered lines with stretch glyphs and strings
10117 displayed in margins. (Bug#8133) (Bug#8867)
10118 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
10119 TO_CHARPOS.
640c8776
SM
10120 (pos_visible_p): Support positions in bidi-reordered lines.
10121 Save and restore bidi cache.
0bb23927
EZ
10122
10123 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
10124 (bidi_paragraph_info): Delete unused struct.
10125 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
10126 (bidi_cache_start): New variable.
10127 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
10128 to zero.
10129 (bidi_cache_fetch_state, bidi_cache_search)
10130 (bidi_cache_find_level_change, bidi_cache_iterator_state)
10131 (bidi_cache_find, bidi_peek_at_next_level)
10132 (bidi_level_of_next_char, bidi_find_other_level_edge)
10133 (bidi_move_to_visually_next): Compare cache index with
10134 bidi_cache_start rather than with zero.
10135 (bidi_fetch_char): Accept new argument STRING; all callers
10136 changed. Support iteration over a string. Support strings with
10137 display properties. Support unibyte strings. Fix the type of
10138 `len' according to what STRING_CHAR_AND_LENGTH expects.
10139 (bidi_paragraph_init, bidi_resolve_explicit_1)
10140 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
10141 (bidi_level_of_next_char, bidi_move_to_visually_next):
10142 Support iteration over a string.
0bb23927
EZ
10143 (bidi_set_sor_type, bidi_resolve_explicit_1)
10144 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
10145 can now be zero (for strings); special values 0 and -1 were
10146 changed to -1 and -2, respectively.
10147 (bidi_char_at_pos): New function.
10148 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
10149 Call it instead of FETCH_MULTIBYTE_CHAR.
10150 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
10151 initialized to valid values.
10152 (bidi_init_it): Don't initialize charpos and bytepos with invalid
10153 values.
10154 (bidi_level_of_next_char): Allow the sentinel "position" to pass
10155 the test for valid cached positions. Fix the logic for looking up
10156 the sentinel state in the cache. GCPRO the Lisp string we are
10157 iterating.
10158 (bidi_push_it, bidi_pop_it): New functions.
10159 (bidi_initialize): Initialize the bidi cache start stack pointer.
10160 (bidi_cache_ensure_space): New function, refactored from part of
10161 bidi_cache_iterator_state. Don't assume the required size is just
10162 one BIDI_CACHE_CHUNK away.
10163 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
10164 (bidi_count_bytes, bidi_char_at_pos): New functions.
10165 (bidi_cache_search): Don't assume bidi_cache_last_idx is
10166 always valid if bidi_cache_idx is valid.
10167 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
10168 is valid if it's going to be used.
10169 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
10170 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
10171 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10172 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
10173 (bidi_find_other_level_edge, bidi_cache_start_stack):
10174 All variables related to cache indices are now EMACS_INT.
c965adc5 10175
0bb23927
EZ
10176 * dispextern.h (struct bidi_string_data): New structure.
10177 (struct bidi_it): New member `string'. Make flag members be 1-bit
10178 fields, and put them last in the struct.
640c8776
SM
10179 (compute_display_string_pos, compute_display_string_end):
10180 Update prototypes.
0bb23927
EZ
10181 (bidi_push_it, bidi_pop_it): Add prototypes.
10182 (struct iterator_stack_entry): New members bidi_p,
10183 paragraph_embedding, and from_disp_prop_p.
10184 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
10185 (bidi_shelve_cache, bidi_unshelve_cache):
10186 Declare prototypes.
0bb23927
EZ
10187
10188 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
10189 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
10190 and vector-like objects.
10191
10192 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
10193 cache around display iteration.
10194
10195 * window.c (Fwindow_end, window_scroll_pixel_based)
10196 (displayed_window_lines, Frecenter): Save and restore the bidi
10197 cache around display iteration.
10198
3bbd2265
LMI
101992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10200
10201 * editfns.c (Fdelete_region): Clarify the use of the named
10202 parameters (bug#6788).
10203
adc47434
MR
102042011-07-14 Martin Rudalics <rudalics@gmx.at>
10205
10206 * indent.c (Fvertical_motion): Set and restore w->pointm when
10207 saving and restoring the window's buffer (Bug#9006).
10208
837c31f8
LMI
102092011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
10210
10211 * editfns.c (Fstring_to_char): Clarify just what is returned
10212 (bug#6576). Text by Eli Zaretskii.
10213
ac389d0c
JB
102142011-07-13 Juanma Barranquero <lekktu@gmail.com>
10215
10216 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
10217
0be0ce47
EZ
102182011-07-13 Eli Zaretskii <eliz@gnu.org>
10219
10220 * buffer.c (mmap_find): Fix a typo.
10221
cd18e7e3
JB
102222011-07-13 Johan Bockgård <bojohan@gnu.org>
10223
10224 Fix execution of x selection hooks.
10225 * xselect.c (Qx_lost_selection_functions)
10226 (Qx_sent_selection_functions): New vars.
10227 (syms_of_xselect): DEFSYM them.
10228 (x_handle_selection_request): Pass Qx_sent_selection_functions
10229 rather than Vx_sent_selection_functions to Frun_hook_with_args.
10230 (x_handle_selection_clear,x_clear_frame_selections):
10231 Pass Qx_lost_selection_functions rather than
10232 Vx_lost_selection_functions to Frun_hook_with_args.
10233
47ea7f44
PE
102342011-07-13 Paul Eggert <eggert@cs.ucla.edu>
10235
ac389d0c 10236 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
10237 The old code sometimes used this field without initializing it.
10238
47ea7f44
PE
10239 * alloc.c (gc_sweep): Don't read past end of array.
10240 In theory, the old code could also have corrupted Emacs internals,
10241 though it'd be very unlikely.
10242
bc985c87
AS
102432011-07-12 Andreas Schwab <schwab@linux-m68k.org>
10244
10245 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 10246 argument. (Bug#4026)
bc985c87 10247
0cf34688
LMI
102482011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
10249
b3dadd76
LMI
10250 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
10251 key" (bug#4257).
10252
0cf34688
LMI
10253 * window.c (Fset_window_start): Doc fix (bug#4199).
10254 (Fset_window_hscroll): Ditto.
10255
270768cd
PE
102562011-07-12 Paul Eggert <eggert@cs.ucla.edu>
10257
077e3dda 10258 Fix minor new problems caught by GCC 4.6.1.
270768cd 10259 * term.c (init_tty): Remove unused local.
490011a6 10260 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 10261 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 10262 not used otherwise.
270768cd 10263
b1f58454
CY
102642011-07-12 Chong Yidong <cyd@stupidchicken.com>
10265
10266 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
10267
22b9578d
LMI
102682011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10269
6e70ab07
LMI
10270 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
10271 are the mini-buffer and the echo area (bug#3320).
10272
22b9578d
LMI
10273 * term.c (init_tty): Remove support for supdup, c10 and perq
10274 terminals, which are no longer supported (bug#1482).
10275
8974cc9f
JB
102762011-07-10 Johan Bockgård <bojohan@gnu.org>
10277
10278 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
10279
a560d974
JD
102802011-07-10 Jan Djärv <jan.h.d@swipnet.se>
10281
10282 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
10283 for non-popups (Bug#3642).
10284
1dae0f0a
AS
102852011-07-10 Andreas Schwab <schwab@linux-m68k.org>
10286
268c2c36 10287 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 10288 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
10289 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
10290 * cm.c (losecursor): Likewise.
1dae0f0a
AS
10291 * data.c (fmod): Likewise.
10292 * dispnew.c (swap_glyphs_in_rows): Likewise.
10293 * emacs.c (memory_warning_signal): Likewise.
10294 * floatfns.c (float_error): Likewise.
10295 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
10296 (otf_open, font_otf_capability, generate_otf_features)
10297 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
10298 Likewise.
10299 * image.c (pbm_read_file): Likewise.
10300 * indent.c (string_display_width): Likewise.
10301 * intervals.c (check_for_interval, search_for_interval)
10302 (inc_interval_count, count_intervals, root_interval)
10303 (adjust_intervals_for_insertion, make_new_interval): Likewise.
10304 * lread.c (defalias): Likewise.
268c2c36 10305 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
10306 * regex.c (set_image_of_range_1, set_image_of_range)
10307 (regex_grow_registers): Likewise.
10308 * sysdep.c (strerror): Likewise.
10309 * termcap.c (valid_filename_p, tprint, main): Likewise.
10310 * tparam.c (main): Likewise.
10311 * unexhp9k800.c (run_time_remap, save_data_space)
10312 (update_file_ptrs, read_header, write_header, calculate_checksum)
10313 (copy_file, copy_rest, display_header): Likewise.
10314 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
10315 Likewise.
10316 * xdisp.c (check_it): Likewise.
10317 * xfaces.c (register_color, unregister_color, unregister_colors):
10318 Likewise.
10319 * xfns.c (print_fontset_result): Likewise.
10320 * xrdb.c (member, fatal, main): Likewise.
10321
99033785
PE
103222011-07-10 Paul Eggert <eggert@cs.ucla.edu>
10323
10324 Fix minor problems found by static checking (Bug#9031).
10325 * chartab.c (char_table_set_range, map_sub_char_table):
10326 Remove unused locals.
10327 (uniprop_table): Now static.
10328 * composite.c (_work_char): Remove unused static var.
10329
9cb2ac56
JB
103302011-07-09 Juanma Barranquero <lekktu@gmail.com>
10331
10332 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
10333
f25661f0
JD
103342011-07-09 Jan Djärv <jan.h.d@swipnet.se>
10335
10336 * gtkutil.c (qttip_cb): Remove code without function.
10337
8278c4fe
EZ
103382011-07-09 Eli Zaretskii <eliz@gnu.org>
10339
10340 * w32.c (pthread_sigmask): New stub.
10341
1692ae2d 103422011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 10343
8a6ebd58 10344 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
10345 sigprocmask is portable only for single-threaded applications, and
10346 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
10347 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
10348 (LIBES): Use it.
10349 * callproc.c (Fcall_process):
10350 * process.c (create_process):
10351 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
10352 Use pthread_sigmask, not sigprocmask.
123403e4 10353
1b854618
JD
103542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10355
10356 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
10357 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
10358 wrong (Bug#8591).
10359
3fe4b549
JD
103602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10361
0ce7e563
JD
10362 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10363 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
10364 (xg_hide_tooltip): Fix comment.
10365
3fe4b549
JD
10366 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
10367 in registerServicesMenuSendTypes.
10368 (validRequestorForSendType): Don't check ns_return_types.
10369
10370 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
10371 ns_return_type.
10372
5df75e47
JR
103732011-07-08 Jason Rumney <jasonr@gnu.org>
10374
22610910
JR
10375 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
10376 SH_SHOW for hidden windows (Bug#5482).
10377
5df75e47
JR
10378 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
10379 frame struct members of non-existent frames (Bug#6284).
10380
699c10bd
JD
103812011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10382
4393663b
JD
10383 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
10384 variable firstTime not needed on OSX >= 10.6.
10385 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
10386 >= 10.5. Use setKnobProportion, setDoubleValue.
10387
10388 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
10389 (MAC_OS_X_VERSION_10_5): Define if not defined.
10390 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
10391 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
10392 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
10393
10394 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 10395 cString and lossyCString on OSX >= 10.4.
4393663b 10396
58179cce 10397 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10398 sizeToFit on OSX >= 10.2.
10399
10400 * nsimage.m (allocInitFromFile): Don't use deprecated method
10401 bestRepresentationForDevice on OSX >= 10.6.
10402
10403 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10404 to avoid warning.
10405
10406 * emacs.c: Declare unexec_init_emacs_zone.
10407
a63e0781
JD
10408 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10409
699c10bd
JD
10410 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10411
10412 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10413 on svcsMenu (Bug#8842).
10414
10415 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10416 ns_return_types.
10417 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10418
10419 * nsterm.m (QUTF8_STRING): Declare.
10420 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10421 (validRequestorForSendType): Return type is (id).
10422 Change indexOfObjectIdenticalTo to indexOfObject.
10423 Check if we have local selection before returning self (Bug#8842).
10424 (writeSelectionToPasteboard): Put local selection into paste board
10425 if we have a local selection (Bug#8842).
10426 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10427
10428 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10429 (ns_get_local_selection): Declare.
10430
54e10184
LMI
104312011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10432
9888ff71
LMI
10433 * keymap.c (describe_map_tree): Don't insert a double newline at
10434 the end of the buffer (bug#1169) and return whether we inserted
10435 something.
10436
54e10184
LMI
10437 * callint.c (Fcall_interactively): Change "reading args" to
10438 "providing args" to try to clarify what it does (bug#1010).
10439
15fa4783
KH
104402011-07-07 Kenichi Handa <handa@m17n.org>
10441
10442 * composite.c (composition_compute_stop_pos): Ignore a static
10443 composition starting before CHARPOS (Bug#8915).
10444
10445 * xdisp.c (handle_composition_prop): Likewise.
10446
a8815b00
EZ
104472011-07-07 Eli Zaretskii <eliz@gnu.org>
10448
10449 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10450 (Bug#9015)
10451
ef7b981d 104522011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10453
10454 * character.h (unicode_category_t): New enum type.
10455
10456 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10457 (Qchar_code_property_table): New variable.
10458 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10459 (UNIPROP_COMPRESSED_FORM_P): New macros.
10460 (char_table_ascii): Uncompress the compressed values.
10461 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10462 Uncompress the compressed values.
ac389d0c 10463 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10464 (char_table_ref_and_range): Uncompress the compressed values.
10465 (sub_char_table_set): New arg is_uniprop. Callers changed.
10466 Uncompress the compressed values.
10467 (sub_char_table_set_range): Args changed. Callers changed.
10468 (char_table_set_range): Adjuted for the above change.
10469 (map_sub_char_table): Delete args default_val and parent. Add arg
10470 top. Give decoded values to a Lisp function.
640c8776 10471 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10472 values to a Lisp function. Gcpro more variables.
10473 (uniprop_table_uncompress)
10474 (uniprop_decode_value_run_length): New functions.
10475 (uniprop_decoder, uniprop_decoder_count): New variables.
10476 (uniprop_get_decoder, uniprop_encode_value_character)
10477 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10478 New functions.
10479 (uniprop_encoder, uniprop_encoder_count): New variables.
10480 (uniprop_get_encoder, uniprop_table)
10481 (Funicode_property_table_internal, Fget_unicode_property_internal)
10482 (Fput_unicode_property_internal): New functions.
10483 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10484 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10485 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10486 char-code-property-alist.
10487
640c8776 10488 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10489 Vunicode_category_table.
10490
640c8776 10491 * font.c (font_range): Adjust for the change of
c805dec0
KH
10492 Vunicode_category_table.
10493
76b397fb
DN
104942011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10495
10496 * m/iris4d.h: Remove file, move contents ...
10497 * s/irix6-5.h: ... here.
10498
22b4128e
PE
104992011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10500
10501 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10502 * alloc.c (mark_buffer):
10503 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10504 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10505 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10506 This isn't true in general, and it's particularly not true
10507 if Emacs is configured with --with-wide-int.
10508 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10509 New macros, used in the buffer.c change.
10510
869795d6
JD
105112011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10512
10513 * xsettings.c: Use both GConf and GSettings if both are available.
10514 (store_config_changed_event): Add comment.
10515 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10516 (store_tool_bar_style_changed): New functions.
5e617bc2 10517 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10518 (struct xsettings): Move font inside HAVE_XFT.
10519 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10520 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10521 Move inside HAVE_XFT.
640c8776 10522 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10523 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10524 also.
10525 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10526 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10527 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10528 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10529 (parse_settings): Move check for font inside HAVE_XFT.
10530 (read_settings, apply_xft_settings): Add comment.
10531 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10532 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10533 call store_font_name_changed.
10534 (xft_settings_event): Add comment.
10535 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10536 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10537 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10538 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10539 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10540 (xsettings_get_system_font, xsettings_get_system_normal_font):
10541 Add comment.
869795d6 10542
d8ed26bd
PE
105432011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10544
10545 Random fixes. E.g., (random) never returned negative values.
10546 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10547 subseconds part to the entropy, as that's a bit more random.
10548 Prefer signed to unsigned, since the signedness doesn't matter and
10549 in general we prefer signed. When given a limit, use a
10550 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10551 latter isn't right if USE_2_TAGS_FOR_INTS.
10552 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10553 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10554
cabf1cac
SM
105552011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10556
10557 * textprop.c (text_property_stickiness):
10558 Obey Vtext_property_default_nonsticky.
10559 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10560 * w32fns.c (syms_of_w32fns):
10561 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10562
6e9b2be9
PE
105632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10564
10565 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10566 This is more efficient than Ffile_directory_p and avoids a minor race.
10567
90186c68
LMI
105682011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10569
7c301272
LMI
10570 * buffer.c (Foverlay_put): Say what the return value is
10571 (bug#7835).
10572
c4f2d8d4
LMI
10573 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10574 is a directory before asking whether to use the file name
10575 (bug#7564).
ad637907
LMI
10576 (barf_or_query_if_file_exists): Make the "File is a directory"
10577 error be more correct.
c4f2d8d4 10578
90186c68
LMI
10579 * fns.c (Frequire): Remove the mention of the .gz files, since
10580 that's installation-specific, but keep the mention of
10581 `get-load-suffixes'.
10582
da64016e
PE
105832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10584
10585 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10586 Report string overflow if the output is too long.
10587
7d47b580
JB
105882011-07-04 Juanma Barranquero <lekktu@gmail.com>
10589
a555cb87
JB
10590 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10591 (syms_of_gnutls): Remove duplicate DEFSYM for
10592 Qgnutls_bootprop_verify_hostname_error, an error for
10593 Qgnutls_bootprop_verify_error (which is no longer used).
10594
7d47b580
JB
10595 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10596 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10597 Also (re)move comments that are misplaced or no longer relevant.
10598
1e49bfab
LMI
105992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10600
10601 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10602
1485f4c0
CY
106032011-07-03 Chong Yidong <cyd@stupidchicken.com>
10604
10605 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10606 and background color parameters if they have been changed.
10607
a9ab721e
LMI
106082011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10609
10610 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10611
cf7cff57
PE
106122011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10613
2e13213d
PE
10614 * xsettings.c (SYSTEM_FONT): Define only when used.
10615 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10616
cf7cff57
PE
10617 * keymap.c (access_keymap_1): Now static.
10618
7a8e04f7
CY
106192011-07-02 Chong Yidong <cyd@stupidchicken.com>
10620
10621 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10622 leave any prefix arg for the up event (Bug#1586).
10623
61352f62
LMI
106242011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10625
69bb1ef7
LMI
10626 * lread.c (syms_of_lread): Mention single symbols defined by
10627 `defvar' or `defconst' (bug#7154).
10628
61352f62 10629 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10630 (Frequire): Mention get-load-suffixes.
61352f62 10631
28545e04
MR
106322011-07-02 Martin Rudalics <rudalics@gmx.at>
10633
10634 * window.h (window): Remove clone_number slot.
10635 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10636 Remove.
10637 (make_parent_window, make_window, saved_window)
10638 (Fset_window_configuration, save_window_save): Don't deal with
10639 clone numbers.
10640 * buffer.c (Qclone_number): Remove declaration.
10641 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10642
3349e122
SM
106432011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10644
10645 Add multiple inheritance to keymaps.
10646 * keymap.c (Fmake_composed_keymap): New function.
10647 (Fset_keymap_parent): Simplify.
10648 (fix_submap_inheritance): Remove.
10649 (access_keymap_1): New function extracted from access_keymap to handle
10650 embedded parents and handle lists of maps.
10651 (access_keymap): Use it.
10652 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10653 (Fcopy_keymap): Handle embedded parents.
10654 (Fcommand_remapping, define_as_prefix): Simplify.
10655 (Fkey_binding): Simplify.
10656 (syms_of_keymap): Move minibuffer-local-completion-map,
10657 minibuffer-local-filename-completion-map,
10658 minibuffer-local-must-match-map, and
10659 minibuffer-local-filename-must-match-map to Elisp.
10660 (syms_of_keymap): Defsubr make-composed-keymap.
10661 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10662 (parse_menu_item): Trivial simplification.
10663
3279eb87
GM
106642011-07-01 Glenn Morris <rgm@gnu.org>
10665
10666 * Makefile.in (SETTINGS_LIBS): Fix typo.
10667
39cb9e56 106682011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10669
10670 * coding.c (Fencode_coding_string): Record the last coding system
10671 used, as the function doc string says (bug#8738).
10672
0949d2b6
JD
106732011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10674
10675 * xsettings.c (store_monospaced_changed): Take new font as arg and
10676 check for change against current_mono_font.
10677 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10678 (emacs_settings_constructor, emacs_settings_get_property)
10679 (emacs_settings_set_property, emacs_settings_class_init)
10680 (emacs_settings_init, gsettings_obj): Remove.
10681 (something_changedCB): New function for HAVE_GSETTINGS.
10682 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10683 with value as argument.
10684 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10685 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10686 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10687 "changed".
10688
10689 * xgselect.c: Add defined (HAVE_GSETTINGS).
10690 (xgselect_initialize): Ditto.
10691
10692 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10693 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10694 xg_select.
10695
bbc6b304
PE
106962011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10697
10698 * eval.c (struct backtrace): Simplify and port the data structure.
10699 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10700 signed bit field, as this assumption is not portable and it makes
10701 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10702 "char debug_on_exit : 1" as this is not portable either; instead,
10703 use the portable "unsigned int debug_on_exit : 1". Remove unused
10704 member evalargs. Remove obsolete comments about cc bombing out.
10705
9851bfc5
JD
107062011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10707
51bb811f 10708 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10709 Let HAVE_GSETTINGS override HAVE_GCONF.
10710 (store_monospaced_changed): New function.
10711 (EMACS_SETTINGS): A new type derived from GObject to handle
10712 GSettings notifications.
10713 (emacs_settings_constructor, emacs_settings_get_property)
10714 (emacs_settings_set_property, emacs_settings_class_init):
10715 New functions.
10716 (gsettings_client, gsettings_obj): New variables.
10717 (GSETTINGS_SCHEMA): New define.
10718 (something_changedCB): Call store_monospaced_changed.
10719 (init_gsettings): New function.
10720 (xsettings_initialize): Call init_gsettings.
10721 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10722 to NULL.
10723
640c8776 10724 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10725 GCONF_CFLAGS/LIBS.
10726
5386012d
MR
107272011-06-29 Martin Rudalics <rudalics@gmx.at>
10728
10729 * window.c (resize_root_window, grow_mini_window)
10730 (shrink_mini_window): Rename Qresize_root_window to
10731 Qwindow_resize_root_window and Qresize_root_window_vertically to
10732 Qwindow_resize_root_window_vertically.
10733
f13e0b08
PE
107342011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10735
10736 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10737
94515237
JB
107382011-06-27 Juanma Barranquero <lekktu@gmail.com>
10739
10740 * makefile.w32-in: Redesign dependencies so they reflect more
10741 clearly which files are directly included by each source file,
10742 and not through other includes.
10743
e43b6e43
MR
107442011-06-27 Martin Rudalics <rudalics@gmx.at>
10745
10746 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10747 (sort_overlays, overlay_strings): When an overlay's clone number
10748 matches the window's clone number process the overlay even if
10749 the overlay's window property doesn't match the current window.
10750
d68443dc
MR
10751 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10752 (Fwindow_hchild): Rename to Fwindow_left_child.
10753 (Fwindow_next): Rename to Fwindow_next_sibling.
10754 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10755 (resize_window_check): Rename to window_resize_check.
10756 (resize_window_apply): Rename to window_resize_apply.
10757 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10758 (Fdelete_other_windows_internal, resize_frame_windows)
10759 (Fsplit_window_internal, Fdelete_window_internal)
10760 (grow_mini_window, shrink_mini_window)
10761 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10762
c7e73be5
JD
107632011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10764
10765 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10766 (emacs_fixed_set_min_size): Remove.
10767 (emacs_fixed_new): Take frame as argument.
10768
10769 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10770 (_EmacsFixedPrivate): Remove minwidth/height.
10771 Add struct frame *f.
10772 (emacs_fixed_init): Initialize priv->f.
10773 (get_parent_class, emacs_fixed_set_min_size): Remove.
10774 (emacs_fixed_new): Set priv->f to argument.
10775 (emacs_fixed_get_preferred_width)
10776 (emacs_fixed_get_preferred_height): Use min_width/height from
10777 frames size_hint to set minimum and natural (Bug#8919).
10778 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10779 and use min_width/height from frames size_hint to set
10780 min_width/height (Bug#8919).
10781
10782 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10783 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10784 Fix indentation.
c7e73be5 10785
cf99dcf8
EZ
107862011-06-26 Eli Zaretskii <eliz@gnu.org>
10787
10788 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10789 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10790 called at ZV.
10791
029529ac
CY
107922011-06-26 Chong Yidong <cyd@stupidchicken.com>
10793
10794 * process.c (wait_reading_process_output): Bypass select if
10795 waiting for a cell while ignoring keyboard input, and input is
10796 pending. Suggested by Jan Djärv (Bug#8869).
10797
7a7ef429
PE
107982011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10799
10800 Use gnulib's dup2 module instead of rolling our own.
10801 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10802
11fdef7d 108032011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10804
10805 * dispnew.c (scrolling_window): Before scrolling, turn off a
10806 mouse-highlight in the window being scrolled.
10807
cd3520a4
JB
108082011-06-24 Juanma Barranquero <lekktu@gmail.com>
10809
10810 Move DEFSYM to lisp.h and use everywhere.
10811
10812 * character.h (DEFSYM): Move declaration...
10813 * lisp.h (DEFSYM): ...here.
10814
10815 * gnutls.c:
10816 * minibuf.c:
10817 * w32menu.c:
10818 * w32proc.c:
10819 * w32select.c: Don't include character.h.
10820
10821 * alloc.c (syms_of_alloc):
10822 * buffer.c (syms_of_buffer):
10823 * bytecode.c (syms_of_bytecode):
10824 * callint.c (syms_of_callint):
10825 * casefiddle.c (syms_of_casefiddle):
10826 * casetab.c (init_casetab_once):
10827 * category.c (init_category_once, syms_of_category):
10828 * ccl.c (syms_of_ccl):
10829 * cmds.c (syms_of_cmds):
10830 * composite.c (syms_of_composite):
10831 * dbusbind.c (syms_of_dbusbind):
10832 * dired.c (syms_of_dired):
10833 * dispnew.c (syms_of_display):
10834 * doc.c (syms_of_doc):
10835 * editfns.c (syms_of_editfns):
10836 * emacs.c (syms_of_emacs):
10837 * eval.c (syms_of_eval):
10838 * fileio.c (syms_of_fileio):
10839 * fns.c (syms_of_fns):
10840 * frame.c (syms_of_frame):
10841 * fringe.c (syms_of_fringe):
10842 * insdel.c (syms_of_insdel):
10843 * keymap.c (syms_of_keymap):
10844 * lread.c (init_obarray, syms_of_lread):
10845 * macros.c (syms_of_macros):
10846 * msdos.c (syms_of_msdos):
10847 * print.c (syms_of_print):
10848 * process.c (syms_of_process):
10849 * search.c (syms_of_search):
10850 * sound.c (syms_of_sound):
10851 * syntax.c (init_syntax_once, syms_of_syntax):
10852 * terminal.c (syms_of_terminal):
10853 * textprop.c (syms_of_textprop):
10854 * undo.c (syms_of_undo):
10855 * w32.c (globals_of_w32):
10856 * window.c (syms_of_window):
10857 * xdisp.c (syms_of_xdisp):
10858 * xfaces.c (syms_of_xfaces):
10859 * xfns.c (syms_of_xfns):
10860 * xmenu.c (syms_of_xmenu):
10861 * xsettings.c (syms_of_xsettings):
10862 * xterm.c (syms_of_xterm): Use DEFSYM.
10863
4228cf16
TZ
108642011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10865
cd3520a4 10866 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10867
7fcccf1e
PE
108682011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10869
7efb4e0e
PE
10870 Integer and buffer overflow fixes (Bug#8873).
10871
ff5844ad
PE
10872 * print.c (printchar, strout): Check for string overflow.
10873 (PRINTPREPARE, printchar, strout):
10874 Don't set size unless allocation succeeds.
10875
90532f02
PE
10876 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10877 for sizes. Check for string overflow more accurately.
10878 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10879
6d84508d
PE
10880 * macros.c: Integer and buffer overflow fixes.
10881 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10882 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10883 Use ptrdiff_t, not int, for sizes.
10884 Don't increment bufsize until after realloc succeeds.
10885 Check for size-calculation overflow.
10886 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10887
437b2cb4
PE
10888 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10889
8b9ac8b4
PE
10890 * lread.c: Integer overflow fixes.
10891 (read_integer): Radix is now EMACS_INT, not int,
10892 to improve quality of diagnostics for out-of-range radices.
10893 Calculate buffer size correctly for out-of-range radices.
10894 (read1): Check for integer overflow in radices, and in
10895 read-circle numbers.
82cb60d3
PE
10896 (read_escape): Avoid int overflow.
10897 (Fload, openp, read_buffer_size, read1)
10898 (substitute_object_recurse, read_vector, read_list, map_obarray):
10899 Use ptrdiff_t, not int, for sizes.
10900 (read1): Use EMACS_INT, not int, for sizes.
20270765 10901 Check for size overflow.
8b9ac8b4 10902
7fcccf1e
PE
10903 * image.c (cache_image): Check for size arithmetic overflow.
10904
bfbbd7e7
PE
10905 * lread.c: Integer overflow issues.
10906 (saved_doc_string_size, saved_doc_string_length)
10907 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10908 Now ptrdiff_t, not int.
10909 (read1): Don't assume doc string length fits in int. Check for
10910 out-of-range doc string lengths.
10911 (read_list): Don't assume file position fits in int.
39019e54 10912 (read_escape): Check for hex character overflow.
bfbbd7e7 10913
4e323265
LL
109142011-06-22 Leo Liu <sdl.web@gmail.com>
10915
10916 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10917 Move to minibuffer.el.
10918
85fece3e
PE
109192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10920
20b84ce9 10921 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10922 The following patches are for when GLYPH_DEBUG && !XASSERT.
10923 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10924 * dispnew.c (flush_stdout):
10925 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10926 Mark as externally visible.
10927 * dispnew.c (check_window_matrix_pointers): Now static.
10928 * dispnew.c (window_to_frame_vpos):
10929 * xfns.c (unwind_create_frame):
10930 * xterm.c (x_check_font): Remove unused local.
10931 * scroll.c (CHECK_BOUNDS):
10932 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10933 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10934 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10935 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10936 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10937 Now static.
10938 (debug_method_add): Use va_list and vsprintf rather than relying
10939 on undefined behavior with wrong number of arguments.
10940 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10941 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10942 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10943 since we're not interested in debugging glyphs with old libraries.
10944 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10945 GCC 4.6.0's static checking.
10946
0766b489
PE
109472011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10948
31fd4b32
PE
10949 Integer overflow and signedness fixes (Bug#8873).
10950 A few related buffer overrun fixes, too.
10951
b79e8648
PE
10952 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10953
0766b489
PE
10954 * dispextern.h (struct face.stipple):
10955 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10956 (x_bitmap_mask, x_allocate_bitmap_record)
10957 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10958 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10959 (x_create_bitmap_from_xpm_data):
10960 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10961 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10962 (.bitmaps_last):
10963 * xfaces.c (load_pixmap):
10964 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10965 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10966 (.bitmaps_last, struct x_output.icon_bitmap):
10967 Use ptrdiff_t, not int, for bitmap indexes.
10968 (x_allocate_bitmap_record): Check for size overflow.
10969 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10970
b081724f
PE
10971 Use ptrdiff_t, not int, for overlay counts.
10972 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10973 * editfns.c (overlays_around, get_pos_property):
10974 * textprop.c (get_char_property_and_overlay):
10975 * xdisp.c (next_overlay_change, note_mouse_highlight):
10976 * xfaces.c (face_at_buffer_position):
21514da7
PE
10977 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10978 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10979 (Fnext_overlay_change, Fprevious_overlay_change)
10980 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10981 Use ptrdiff_t, not int, for sizes.
21514da7 10982 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10983
3de73e5e
PE
10984 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10985
2606c57b
PE
10986 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10987 (x_session_initialize): Do not assume string length fits in int.
10988
aaafe47a
PE
10989 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10990 This is unlikely, but can occur if DPI is outlandish.
10991
2674ddc8 10992 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10993 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10994
28154962
PE
10995 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10996 * xrdb.c (magic_file_p, search_magic_path):
10997 Omit last arg SUFFIX; it was always 0. All callers changed.
10998 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10999
7de51af5
PE
11000 * xfont.c (xfont_match): Avoid need for strlen.
11001
25ed6cc3
PE
11002 * xfns.c: Don't assume strlen fits in int.
11003 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
11004
4eab31dd
PE
11005 * xdisp.c (message_log_check_duplicate): Return intmax_t,
11006 not unsigned long, as we prefer signed integers. All callers changed.
11007 Detect integer overflow in repeat count.
11008 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 11009 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 11010
171e2a58
PE
11011 * termcap.c: Don't assume sizes fit in int and never overflow.
11012 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
11013 (gobble_line): Check for size-calculation overflow.
11014
ad39faca 11015 * minibuf.c (Fread_buffer):
6e5bb2dc 11016 * lread.c (intern, intern_c_string):
74ca2eb3
PE
11017 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
11018 Don't assume string length fits in int.
11019
52c61c22 11020 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
11021 * gtkutil.c (style_changed_cb): Avoid need for strlen.
11022
b5b8c9e5
PE
11023 * font.c: Don't assume string length fits in int.
11024 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
11025 Use ptrdiff_t, not int.
ccd6111c
PE
11026 (font_intern_prop): Don't assume string length fits in int.
11027 Don't assume integer property fits in fixnum.
11028 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 11029
882f0d81 11030 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 11031 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
11032 Reformulate so as not to need the command string.
11033 Invoke gzip -cd rather than gunzip, as it's more portable.
11034 (lock_info_type, lock_file_1, lock_file):
11035 Don't assume pid_t and time_t fit in unsigned long.
11036 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
11037 (current_lock_owner): Prefer signed type for sizes.
11038 Use memcpy, not strncpy, where memcpy is what is really wanted.
11039 Don't assume (via atoi) that time_t and pid_t fit in int.
11040 Check for time_t and/or pid_t out of range, e.g., via a network share.
11041 Don't alloca where an auto var works fine.
11042
93f4cf88
PE
11043 * fileio.c: Fix some integer overflow issues.
11044 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
11045 Don't assume string length fits in int.
11046 (directory_file_name): Don't assume string length fits in long.
11047 (make_temp_name): Don't assume pid fits in int, or that its print
11048 length is less than 20.
11049
f3e92b69
PE
11050 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
11051
1bfdaf10
PE
11052 * coding.c (make_subsidiaries): Don't assume string length fits in int.
11053
35016e9a
PE
11054 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
11055
3d1e65a1
PE
11056 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
11057 We prefer signed integers, even for size calculations.
11058
0b963a93
PE
11059 * emacs.c: Don't assume string length fits in 'int'.
11060 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
11061 (main): Don't invoke strlen when not needed.
11062
573f4b54
PE
11063 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
11064 (XD_DEBUG_MESSAGE): Don't waste a byte.
11065
989f33ba
PE
11066 * callproc.c (getenv_internal_1, getenv_internal)
11067 (Fgetenv_internal):
965d34eb
PE
11068 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
11069
e4d29b33
PE
11070 * lread.c (invalid_syntax): Omit length argument.
11071 All uses changed. This doesn't fix a bug, but it simplifies the
11072 code away from its former Hollerith-constant appearance, and it's
11073 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 11074 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 11075
eb49b136
PE
11076 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
11077 This didn't break anything, but it didn't help either.
11078 It's confusing to put a bogus integer in a place where the actual
11079 value does not matter.
9f62aeb1 11080 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 11081 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 11082
15375a22
PE
11083 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
11084 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
11085 implementation.
b61cc01c
PE
11086 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
11087 We prefer signed types, and the value cannot exceed the EMACS_INT
11088 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
11089 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
11090 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
11091 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 11092
53b2623d
PE
11093 * indent.c (sane_tab_width): New function.
11094 (current_column, scan_for_column, Findent_to, position_indentation)
11095 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 11096 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 11097
51cab52b 11098 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 11099
f2ed8a70
PE
11100 * lisp.h (lint_assume): New macro.
11101 * composite.c (composition_gstring_put_cache):
11102 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
11103
abe80cc6
PE
11104 * editfns.c, insdel.c:
11105 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 11106
b02c740e
PE
11107 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
11108
ebc96716
PE
11109 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
11110
b4e50fa0 11111 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 11112 Use much-faster test for byte-length change.
311d5d7c 11113 Don't assume string byte-length fits in 'int'.
a4cf38e4 11114 Check that character arg fits in 'int'.
85461888 11115 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 11116
c0c1ee9f
PE
11117 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
11118
a498d7f4
PE
11119 * fns.c (concat): Catch string overflow earlier.
11120 Do not rely on integer wraparound.
11121
51cab52b
PE
11122 * dispextern.h (struct it.overlay_strings_charpos)
11123 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
11124 * xdisp.c (forward_to_next_line_start)
11125 (back_to_previous_visible_line_start)
11126 (reseat_at_next_visible_line_start, next_element_from_buffer):
11127 Don't arbitrarily truncate the value of 'selective' to int.
11128
76031fad
PE
11129 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
11130
5eb55db9
PE
11131 * composite.c: Don't truncate sizes to 'int'.
11132 (composition_gstring_p, composition_reseat_it)
11133 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
11134 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
11135 not EMACS_UINT, for indexes.
5eb55db9 11136
0703a717
PE
11137 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
11138
d6202519
PE
11139 * buffer.c: Include <verify.h>.
11140 (struct sortvec.priority, struct sortstr.priority):
8961a454 11141 Now EMACS_INT, not int.
c20998a7 11142 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
11143 (struct sortstr.size, record_overlay_string)
11144 (struct sortstrlist.size, struct sortlist.used):
11145 Don't truncate size to int.
11146 (record_overlay_string): Check for size-calculation overflow.
d6202519 11147 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 11148
d5a19415
JM
111492011-06-22 Jim Meyering <meyering@redhat.com>
11150
029529ac 11151 Don't leak an XBM-image-sized buffer
d5a19415
JM
11152 * image.c (xbm_load): Free the image buffer after using it.
11153
a9041e6c
PE
111542011-06-21 Paul Eggert <eggert@cs.ucla.edu>
11155
11156 Port to Sun C.
11157 * composite.c (find_automatic_composition): Omit needless 'return 0;'
11158 that Sun C diagnosed.
11159 * fns.c (secure_hash): Fix pointer signedness issue.
11160 * intervals.c (static_offset_intervals): New function.
11161 (offset_intervals): Use it.
11162
7f3f739f
LL
111632011-06-21 Leo Liu <sdl.web@gmail.com>
11164
11165 * deps.mk (fns.o):
11166 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
11167 sha512.h.
11168
11169 * fns.c (secure_hash): Rename from crypto_hash_function and change
11170 the first arg to accept symbols.
5b66d427 11171 (Fsecure_hash): New primitive.
7f3f739f
LL
11172 (syms_of_fns): New symbols.
11173
76147d94
DD
111742011-06-20 Deniz Dogan <deniz@dogan.se>
11175
11176 * process.c (Fset_process_buffer): Clarify return value in
11177 docstring.
11178
7d7d0045
CY
111792011-06-18 Chong Yidong <cyd@stupidchicken.com>
11180
11181 * dispnew.c (add_window_display_history): Use BVAR.
11182
11183 * xdisp.c (debug_method_add): Use BVAR.
11184 (check_window_end, dump_glyph_matrix, dump_glyph)
11185 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
11186
11187 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
11188 Likewise.
11189
11190 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
11191 check till after the cache is created in init_frame_faces.
11192
ff2bc410
SM
111932011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
11194
11195 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
11196
28177add
PE
111972011-06-16 Paul Eggert <eggert@cs.ucla.edu>
11198
dd3482fe
PE
11199 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
11200 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
11201 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
11202
393d71f3 11203 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
11204 * fileio.c (Finsert_file_contents):
11205 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
11206 Remove the old (too-loose) buffer overflow checks.
11207 They weren't needed, since make_gap checks for buffer overflow.
11208 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
11209 The old code merely checked for Emacs fixnum overflow, and relied
11210 on undefined (wraparound) behavior. The new code avoids undefined
11211 behavior, and also checks for ptrdiff_t and/or size_t overflow.
11212
2e6813b0 11213 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
11214 Tune. Don't use wider integers than needed. Don't use alloca.
11215 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 11216
599a9e4f
PE
11217 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
11218
99561444
PE
11219 * insdel.c, lisp.h (buffer_overflow): New function.
11220 (insert_from_buffer_1, replace_range, replace_range_2):
11221 * insdel.c (make_gap_larger):
11222 * editfns.c (Finsert_char):
11223 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
11224
28177add
PE
11225 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
11226
e69dafad
PE
112272011-06-15 Paul Eggert <eggert@cs.ucla.edu>
11228
4baa020d 11229 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 11230
b1c46f02
PE
11231 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
11232 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
11233
e69dafad
PE
11234 * fileio.c: Don't assume EMACS_INT fits in off_t.
11235 (emacs_lseek): New static function.
11236 (Finsert_file_contents, Fwrite_region): Use it.
11237 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
11238
566684ea
PE
11239 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
11240
e6966cd6
PE
11241 * fns.c: Don't overflow int when computing a list length.
11242 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
11243 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
11244 truncation on 64-bit hosts. Check for QUIT every
11245 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
11246 faster and is responsive enough.
11247 (Flength): Report an error instead of overflowing an integer.
11248 (Fsafe_length): Return a float if the value is not representable
11249 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 11250 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 11251 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 11252
dd0b0efb
PE
11253 * alloc.c: Check that resized vectors' lengths fit in fixnums.
11254 (header_size, word_size): New constants.
11255 (allocate_vectorlike): Don't check size overflow here.
11256 (allocate_vector): Check it here instead, since this is the only
11257 caller of allocate_vectorlike that could cause overflow.
11258 Check that the new vector's length is representable as a fixnum.
11259
86fe5cfe
PE
11260 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
11261 The previous code was bogus. For example, next_almost_prime (32)
11262 returned 39, which is undesirable as it is a multiple of 3; and
11263 next_almost_prime (24) returned 25, which is a multiple of 5 so
11264 why was the code bothering to check for multiples of 7?
11265
80e88859
PE
11266 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
11267
4a2f0ad6
PE
11268 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
11269
f66c7cf8
PE
11270 Variadic C functions now count arguments with ptrdiff_t.
11271 This partly undoes my 2011-03-30 change, which replaced int with size_t.
11272 Back then I didn't know that the Emacs coding style prefers signed int.
11273 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
11274 were being counted with int, which may truncate counts on 64-bit
11275 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
11276 * lisp.h (struct Lisp_Subr.function.aMANY)
11277 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
11278 Arg counts are now ptrdiff_t, not size_t.
11279 All variadic functions and their callers changed accordingly.
11280 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
11281 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
11282 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
11283 * callint.c (Fcall_interactively): Check arg count for overflow,
11284 to avoid potential buffer overrun. Use signed char, not 'int',
11285 for 'varies' array, so that we needn't bother to check its size
11286 calculation for overflow.
11287 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
11288 * eval.c (apply_lambda):
11289 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
11290 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
11291 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
11292
a1759b76
PE
11293 * callint.c (Fcall_interactively): Don't use index var as event count.
11294
d96be9fc
PE
11295 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
11296 * mem-limits.h (SIZE): Remove; no longer used.
11297
a690a978 11298 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 11299
578c21e6
PE
11300 Remove unnecessary casts.
11301 * xterm.c (x_term_init):
11302 * xfns.c (x_set_border_pixel):
11303 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11304 These aren't needed now that we assume ANSI C.
11305
96f53c6c
PE
11306 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
11307 It's more likely to cause problems (due to unsigned overflow)
11308 than to cure them.
11309
83c77d31
PE
11310 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
11311
ee2079f1
PE
11312 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
11313
6da65536
PE
11314 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
11315
7147c4a4
PE
11316 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
11317
193e32d9
PE
11318 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
11319
e5533da6
PE
11320 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
11321
9910e595
PE
11322 GLYPH_CODE_FACE returns EMACS_INT, not int.
11323 * dispextern.h (merge_faces):
11324 * xfaces.c (merge_faces):
01103c44
PE
11325 * xdisp.c (get_next_display_element, next_element_from_display_vector):
11326 Don't assume EMACS_INT fits in int.
9910e595 11327
2638320e
PE
11328 * character.h (CHAR_VALID_P): Remove unused parameter.
11329 * fontset.c, lisp.h, xdisp.c: All uses changed.
11330
045eb8d9
PE
11331 * editfns.c (Ftranslate_region_internal): Omit redundant test.
11332
c1f134b5
PE
11333 * fns.c (concat): Minor tuning based on overflow analysis.
11334 This doesn't fix any bugs. Use int to hold character, instead
11335 of constantly refetching from Emacs object. Use XFASTINT, not
11336 XINT, for value known to be a character. Don't bother comparing
11337 a single byte to 0400, as it's always less.
11338
395fcb93 11339 * floatfns.c (Fexpt):
327eeec8
PE
11340 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
11341
abbd3d23
PE
11342 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
11343 for characters.
11344
684a03ef
PE
11345 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
11346
0fed43f3
PE
11347 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
11348 Without this fix, on a 64-bit host (aset S 0 4294967386) would
11349 incorrectly succeed when S was a string, because 4294967386 was
11350 truncated before it was used.
11351
8fd02eb7
PE
11352 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
11353 Otherwise, an out-of-range integer could cause undefined behavior
11354 on a 64-bit host.
11355
f8c86b69
PE
11356 * composite.c: Use int, not EMACS_INT, for characters.
11357 (fill_gstring_body, composition_compute_stop_pos): Use int, not
11358 EMACS_INT, for values that are known to be in character range.
11359 This doesn't fix any bugs but is the usual style inside Emacs and
11360 may generate better code on 32-bit machines.
11361
34206dd2
PE
11362 Make sure a 64-bit char is never passed to ENCODE_CHAR.
11363 This is for reasons similar to the recent CHAR_STRING fix.
11364 * charset.c (Fencode_char): Check that character arg is actually
11365 a character. Pass an int to ENCODE_CHAR.
11366 * charset.h (ENCODE_CHAR): Verify that the character argument is no
11367 wider than 'int', as a compile-time check to prevent future regressions
11368 in this area.
11369
c5958d4c 11370 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
11371
11372 Make sure a 64-bit char is never passed to CHAR_STRING.
11373 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
11374 by silently ignoring the top 32 bits, allowing some values
11375 that were far too large to be valid characters.
11376 * character.h: Include <verify.h>.
11377 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
11378 arguments are no wider than unsigned, as a compile-time check
11379 to prevent future regressions in this area.
11380 * data.c (Faset):
01103c44 11381 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
11382 (Fsubst_char_in_region):
11383 * fns.c (concat):
11384 * xdisp.c (decode_mode_spec_coding):
11385 Adjust to CHAR_STRING's new requirement.
11386 * editfns.c (Finsert_char, Fsubst_char_in_region):
11387 * fns.c (concat): Check that character args are actually
11388 characters. Without this test, these functions did the wrong
11389 thing with wildly out-of-range values on 64-bit hosts.
11390
d37ca623
PE
11391 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
11392 These casts should not be needed on 32-bit hosts, either.
11393 * keyboard.c (read_char):
11394 * lread.c (Fload): Remove casts to unsigned.
11395
ea204efb
PE
11396 * lisp.h (UNSIGNED_CMP): New macro.
11397 This fixes comparison bugs on 64-bit hosts.
11398 (ASCII_CHAR_P): Use it.
11399 * casefiddle.c (casify_object):
01103c44 11400 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11401 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11402 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11403 * dispextern.h (FACE_FROM_ID):
11404 * keyboard.c (read_char): Use UNSIGNED_CMP.
11405
41cb286c
PE
11406 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11407 not to EMACS_INT, to avoid GCC warning.
11408
4a1b9832
PE
11409 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11410
55daad71
PE
11411 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11412 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11413 isn't needed on 32-bit machines.
8f95c75c 11414
01103c44
PE
11415 * buffer.c (Fgenerate_new_buffer_name):
11416 Use EMACS_INT for count, not int.
0ceccced 11417 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11418
11419 * data.c (Qcompiled_function): Now static.
11420
c6f072e7
PE
11421 * window.c (window_body_lines): Now static.
11422
20ce5912
PE
11423 * image.c (gif_load): Rename local to avoid shadowing.
11424
9c4c5f81
PE
11425 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11426 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11427 * alloc.c (make_save_value): Integer argument is now of type
11428 ptrdiff_t, not int.
11429 (mark_object): Use ptrdiff_t, not int.
11430 * lisp.h (pD): New macro.
11431 * print.c (print_object): Use it.
11432
c0c5c8ae
PE
11433 * alloc.c: Use EMACS_INT, not int, to count objects.
11434 (total_conses, total_markers, total_symbols, total_vector_size)
11435 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11436 (total_free_floats, total_floats, total_free_intervals)
11437 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11438 Now EMACS_INT, not int. All uses changed.
11439 (Fgarbage_collect): Compute overall total using a double, so that
11440 integer overflow is less likely to be a problem. Check for overflow
11441 when converting back to an integer.
5a25e253
PE
11442 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11443 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11444 These were 'int' variables that could overflow on 64-bit hosts;
11445 they were never used, so remove them instead of repairing them.
211a0b2a 11446 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11447 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11448 Previously, this ceilinged at INT_MAX, but that doesn't work on
11449 64-bit machines.
e46bb31a 11450 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11451
c78baabf 11452 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11453 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11454 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11455 when a (possibly-narrower) signed value would do just as well.
11456 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11457
c9d624c6
PE
11458 * alloc.c: Catch some string size overflows that we were missing.
11459 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11460 for convenience in STRING_BYTES_MAX.
11461 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11462 The definition here is exact; the one in lisp.h was approximate.
11463 (allocate_string_data): Check for string overflow. This catches
11464 some instances we weren't catching before. Also, it catches
11465 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11466 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11467 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11468
c9d624c6
PE
11469 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11470 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11471 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11472
353032ce
PE
11473 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11474
2bccce07
PE
11475 * alloc.c (Fmake_string): Check for out-of-range init.
11476
0ac30604
SM
114772011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11478
11479 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11480
c195f2de
JD
114812011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11482
11483 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11484 xg_get_default_scrollbar_width.
11485
11486 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11487 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11488 (style_changed_cb): Call update_theme_scrollbar_width and call
11489 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11490 all frames (Bug#8505).
11491 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11492 Call gtk_window_set_resizable if HAVE_GTK3.
11493 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11494 and height if HAVE_GTK3 (Bug#8505).
11495 (scroll_bar_width_for_theme): New variable.
11496 (update_theme_scrollbar_width): New function.
11497 (xg_get_default_scrollbar_width): Move code to
11498 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11499 (xg_initialize): Call update_theme_scrollbar_width.
11500
11501 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11502
11503 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11504
e10ac9f1
MR
115052011-06-12 Martin Rudalics <rudalics@gmx.at>
11506
11507 * frame.c (make_frame): Call other_buffer_safely instead of
11508 other_buffer.
11509
11510 * window.c (temp_output_buffer_show): Call display_buffer with
11511 second argument Vtemp_buffer_show_specifiers and reset latter
11512 immediately after the call.
11513 (Vtemp_buffer_show_specifiers): New variable.
11514 (auto_window_vscroll_p, next_screen_context_lines)
11515 (Vscroll_preserve_screen_position): Remove leading asterisks from
11516 doc-strings.
11517
2d3c217e 115182011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11519
7b7f97e8 11520 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11521 * buffer.c (Qclone_number): Remove for now, as it's unused.
11522 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11523 (record_buffer): Remove unused local.
11524 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11525 (set_frame_buffer_list): Remove; unused.
11526 * frame.h (other_visible_frames): Remove decl.
11527 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11528 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11529 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11530 if HAVE_GPM.
11531 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11532 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11533 Define only if HAVE_GPM.
11534 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11535 (update_hints_inhibit): Remove; never set. All uses removed.
11536 * widgetprv.h (emacsFrameClassRec): Remove decl.
11537 * window.c (delete_deletable_window): Now returns void, since it
11538 wasn't returning anything.
11539 (compare_window_configurations): Remove unused locals.
11540 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11541 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11542 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11543 the same widths as pointers. This follows up on the 2011-05-06 patch.
11544 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11545 * xterm.h: Likewise.
11546 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11547
1384b89e
JB
115482011-06-12 Juanma Barranquero <lekktu@gmail.com>
11549
11550 * makefile.w32-in: Update dependencies.
11551 (LISP_H): Add lib/intprops.h.
11552
1100a63c
CY
115532011-06-11 Chong Yidong <cyd@stupidchicken.com>
11554
11555 * image.c (gif_load): Add animation frame delay to the metadata.
11556 (syms_of_image): Use DEFSYM. New symbol `delay'.
11557
6198ccd0
MR
115582011-06-11 Martin Rudalics <rudalics@gmx.at>
11559
11560 * window.c (delete_deletable_window): Re-add.
11561 (Fset_window_configuration): Rewrite to handle dead buffers and
11562 consequently deletable windows.
11563 (window_tree, Fwindow_tree): Remove. Supply functionality in
11564 window.el.
11565 (compare_window_configurations): Simplify code.
11566
b6e3633c
AS
115672011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11568
1ab0dee5
AS
11569 * image.c (imagemagick_load_image): Fix type mismatch.
11570 (Fimagemagick_types): Likewise.
11571
b6e3633c
AS
11572 * window.h (replace_buffer_in_windows): Declare.
11573
9397e56f
MR
115742011-06-11 Martin Rudalics <rudalics@gmx.at>
11575
11576 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11577 Qclone_number. Remove external declaration of Qdelete_window.
11578 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11579 code.
640c8776
SM
11580 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11581 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11582 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11583 buffer list implementation.
11584 (other_buffer_safely): New function.
11585 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11586 calls to replace_buffer_in_windows and
11587 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11588 if allowed.
11589 (record_buffer): Inhibit quitting and rewrite using quittable
11590 functions. Run Qbuffer_list_update_hook if allowed.
11591 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11592 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11593 Move switch-to-buffer to window.el.
9397e56f
MR
11594 (bury-buffer): Move to window.el.
11595 (Vbuffer_list_update_hook): New variable.
11596
11597 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11598 section.
11599
11600 * window.h (resize_frame_windows): Move up in code.
11601 (Fwindow_frame): Remove EXFUN.
11602 (replace_buffer_in_all_windows): Remove prototype.
11603 (replace_buffer_in_windows_safely): Add prototype.
11604
11605 * window.c: Declare Qdelete_window static again. Move down
11606 declaration of select_count.
11607 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11608 (Fother_window): Move to window.el.
11609 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11610 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11611 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11612 window.el.
11613 (replace_buffer_in_windows): Implement by calling
11614 Qreplace_buffer_in_windows.
11615 (replace_buffer_in_all_windows): Remove with some functionality
11616 moved into replace_buffer_in_windows_safely.
11617 (replace_buffer_in_windows_safely): New function.
11618 (select_window_norecord, select_frame_norecord): Move in front
11619 of run_window_configuration_change_hook. Remove now obsolete
11620 declarations.
640c8776
SM
11621 (Fset_window_buffer): Rewrite doc-string.
11622 Call Qrecord_window_buffer.
9397e56f
MR
11623 (keys_of_window): Move binding for other-window to window.el.
11624
b50691aa
CY
116252011-06-11 Chong Yidong <cyd@stupidchicken.com>
11626
11627 * dispextern.h (struct image): Replace data member, whose int_val
11628 and ptr_val fields were not used by anything, with a single
11629 lisp_val object.
11630
11631 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11632 (gif_clear_image, gif_load, imagemagick_load_image)
11633 (gs_clear_image, gs_load): Callers changed.
11634
3f754b86
PE
116352011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11636
cca69397
PE
11637 * buffer.h: Include <time.h>, for time_t.
11638 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11639
109e28d0
PE
11640 Fix minor problems found by static checking.
11641
60737f02
PE
11642 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11643
4b66faf3
PE
11644 Make identifiers static if they are not used in other modules.
11645 * data.c (Qcompiled_function, Qframe, Qvector):
11646 * image.c (QimageMagick, Qsvg):
11647 * minibuf.c (Qmetadata):
11648 * window.c (resize_window_check, resize_root_window): Now static.
11649 * window.h (resize_window_check, resize_root_window): Remove decls.
11650
109e28d0
PE
11651 * window.c (window_deletion_count, delete_deletable_window):
11652 Remove; unused.
46a4ce9e
PE
11653 (window_body_lines): Now static.
11654 (Fdelete_other_windows_internal): Mark vars as initialized.
11655 Make sure 'resize_failed' is initialized.
11656 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11657 (resize_window_apply): Remove unused local.
11658 * window.h (delete_deletable_window): Remove decl.
11659
109e28d0 11660 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11661 (imagemagick_load_image): Fix pointer signedness problem by changing
11662 last arg from unsigned char * to char *. All uses changed.
11663 Also, fix a local for similar reasons.
11664 Remove unused locals. Remove locals to avoid shadowing.
11665 (fn_rsvg_handle_free): Remove; unused.
11666 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11667 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11668
3f754b86
PE
11669 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11670
2547adb1
CY
116712011-06-10 Chong Yidong <cyd@stupidchicken.com>
11672
11673 * image.c (gif_load): Fix omitted cast error introduced by
11674 2011-06-06 change.
11675
2c8e37d4
MR
116762011-06-10 Martin Rudalics <rudalics@gmx.at>
11677
11678 * window.h (resize_proportionally, orig_total_lines)
11679 (orig_top_line): Remove from window structure.
11680 (set_window_height, set_window_width, change_window_heights)
11681 (Fdelete_window): Remove prototypes.
11682 (resize_frame_windows): Remove duplicate declaration.
11683
440a42e3
EZ
116842011-06-10 Eli Zaretskii <eliz@gnu.org>
11685
11686 * window.h (resize_frame_windows, resize_window_check)
11687 (delete_deletable_window, resize_root_window)
11688 (resize_frame_windows): Declare prototypes.
11689
11690 * window.c (resize_window_apply): Make definition be "static" to
11691 match the prototype.
11692
562dd5e9
MR
116932011-06-10 Martin Rudalics <rudalics@gmx.at>
11694
11695 * window.c: Remove declarations of Qwindow_size_fixed,
11696 window_min_size_1, window_min_size_2, window_min_size,
11697 size_window, window_fixed_size_p, enlarge_window, delete_window.
11698 Remove static from declaration of Qdelete_window, it's
11699 temporarily needed by Fbury_buffer.
11700 (replace_window): Don't assign orig_top_line and
11701 orig_total_lines.
11702 (Fdelete_window, delete_window): Remove. Window deletion is
11703 handled by window.el.
640c8776
SM
11704 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11705 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11706 (Fdelete_other_windows): Remove. Deleting other windows is
11707 handled by window.el.
11708 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11709 handled in window.el.
11710 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11711 Window minimum sizes are handled in window.el.
11712 (shrink_windows, size_window, set_window_height)
11713 (set_window_width, change_window_heights, window_height)
11714 (window_width, CURBEG, CURSIZE, enlarge_window)
11715 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11716 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11717 handled in window.el.
11718 (make_dummy_parent): Rename to make_parent_window and give it a
11719 second argument horflag.
11720 (make_window): Don't set resize_proportionally any more.
11721 (Fsplit_window): Remove. Windows are split in window.el.
11722 (save_restore_action, save_restore_orig_size)
11723 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11724 Resize mini windows in window.el.
11725 (grow_mini_window, shrink_mini_window): Implement by calling
11726 Qresize_root_window_vertically, resize_window_check and
11727 resize_window_apply.
640c8776
SM
11728 (saved_window, Fset_window_configuration, save_window_save):
11729 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11730 resize_proportionally.
11731 (window_min_height, window_min_width): Move to window.el.
11732 (keys_of_window): Move bindings for delete-other-windows,
11733 split-window, delete-window and enlarge-window to window.el.
11734
11735 * buffer.c: Temporarily extern Qdelete_window.
11736 (Fbury_buffer): Temporarily call Qdelete_window instead of
11737 Fdelete_window (Fbury_buffer will move to window.el soon).
11738
11739 * frame.c (set_menu_bar_lines_1): Remove code handling
11740 orig_top_line and orig_total_lines.
11741
11742 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11743 set_window_height but set heights directly.
11744 (change_frame_size_1): Use resize_frame_windows.
11745
11746 * xdisp.c (init_xdisp): Don't use set_window_height but set
11747 heights directly.
11748
640c8776
SM
11749 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11750 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11751 run_window_configuration_change_hook.
11752
11753 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11754 instead of change_window_heights and run
11755 run_window_configuration_change_hook.
11756
1a13852e
MR
117572011-06-09 Martin Rudalics <rudalics@gmx.at>
11758
11759 * window.c (replace_window): Rename second argument REPLACEMENT to
11760 NEW. New third argument SETFLAG. Rewrite.
11761 (delete_window, make_dummy_parent): Call replace_window with
11762 third argument 1.
11763 (window_list_1): Move down in code.
11764 (run_window_configuration_change_hook): Move set_buffer part
11765 before select_frame_norecord part in order to unwind correctly.
11766 Rename count1 to count.
11767 (recombine_windows, delete_deletable_window, resize_root_window)
11768 (Fdelete_other_windows_internal)
11769 (Frun_window_configuration_change_hook, make_parent_window)
11770 (resize_window_check, resize_window_apply, Fresize_window_apply)
11771 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11772 (Fdelete_window_internal, Fresize_mini_window_internal):
11773 New functions.
1a13852e
MR
11774 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11775
f3d1777e
MR
117762011-06-08 Martin Rudalics <rudalics@gmx.at>
11777
496e208e
MR
11778 * window.h (window): Add some new members to window structure -
11779 normal_lines, normal_cols, new_total, new_normal, clone_number,
11780 splits, nest, prev_buffers, next_buffers.
11781 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11782 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11783
f3d1777e
MR
11784 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11785 Remove.
496e208e
MR
11786 (make_dummy_parent): Set new members of windows structure.
11787 (make_window): Move down in code. Handle new members of window
11788 structure.
11789 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11790 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11791 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11792 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11793 (Fset_window_next_buffers, Fset_window_clone_number):
11794 New functions.
496e208e
MR
11795 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11796 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11797 Doc-string fixes.
11798 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11799 Argument WINDOW can be now internal window too.
11800 (Fwindow_use_time): Move up in code.
11801 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11802 Rewrite doc-string.
11803 (Fset_window_configuration, saved_window)
11804 (Fcurrent_window_configuration, save_window_save): Handle new
11805 members of window structure.
b9e809c2
MR
11806 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11807 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11808 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11809 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11810 Qget_mru_window, Qresize_root_window,
11811 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11812 Qauto_buffer_name; staticpro them.
f3d1777e 11813
abde8f8c
MR
118142011-06-07 Martin Rudalics <rudalics@gmx.at>
11815
11816 * window.c (Fwindow_total_size, Fwindow_left_column)
11817 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11818 (Fwindow_list_1): New functions.
11819 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11820 (Fwindow_width, Fscroll_left, Fscroll_right):
11821 Use window_body_cols instead of window_box_text_cols.
11822 (delete_window, Fset_window_configuration):
11823 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11824 (delete_all_subwindows): Take a window as argument and not a
11825 structure. Rewrite.
190b47e6
MR
11826 (window_loop): Remove handling of GET_LRU_WINDOW and
11827 GET_LARGEST_WINDOW.
11828 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11829
11830 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11831 window_box_text_cols. delete_all_subwindows now takes a
11832 Lisp_Object as argument.
abde8f8c 11833
640c8776
SM
11834 * indent.c (compute_motion, Fcompute_motion):
11835 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11836
fa8a67e6
MR
11837 * frame.c (delete_frame): Call delete_all_subwindows with root
11838 window as argument.
11839
a54e3482
DC
118402011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11841
11842 * fns.c (Fputhash): Document return value.
11843
60002bf5
CY
118442011-06-06 Chong Yidong <cyd@stupidchicken.com>
11845
11846 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11847
0c671da6 118482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11849
b862a52a 11850 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11851
be44ca6c
PE
11852 Check for overflow when converting integer to cons and back.
11853 * charset.c (Fdefine_charset_internal, Fdecode_char):
11854 Use cons_to_unsigned to catch overflow.
11855 (Fencode_char): Use INTEGER_TO_CONS.
11856 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11857 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11858 * data.c (long_to_cons, cons_to_long): Remove.
11859 (cons_to_unsigned, cons_to_signed): New functions.
11860 These signal an error for invalid or out-of-range values.
11861 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11862 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11863 * font.c (Ffont_variation_glyphs):
11864 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11865 * lisp.h: Include <intprops.h>.
11866 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11867 (cons_to_signed, cons_to_unsigned): New decls.
11868 (long_to_cons, cons_to_long): Remove decls.
11869 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11870 (Fprimitive_undo): Use CONS_TO_INTEGER.
11871 * xfns.c (Fx_window_property): Likewise.
11872 * xselect.c: Include <limits.h>.
11873 (x_own_selection, selection_data_to_lisp_data):
11874 Use INTEGER_TO_CONS.
11875 (x_handle_selection_request, x_handle_selection_clear)
11876 (x_get_foreign_selection, Fx_disown_selection_internal)
11877 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11878 (lisp_data_to_selection_data): Use cons_to_unsigned.
11879 (x_fill_property_data): Use cons_to_signed.
11880 Report values out of range.
11881
d1f3d2af
PE
11882 Check for buffer and string overflow more precisely.
11883 * buffer.h (BUF_BYTES_MAX): New macro.
11884 * lisp.h (STRING_BYTES_MAX): New macro.
11885 * alloc.c (Fmake_string):
11886 * character.c (string_escape_byte8):
11887 * coding.c (coding_alloc_by_realloc):
11888 * doprnt.c (doprnt):
11889 * editfns.c (Fformat):
11890 * eval.c (verror):
11891 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11892 since they may not be the same number.
11893 * editfns.c (Finsert_char):
11894 * fileio.c (Finsert_file_contents):
11895 Likewise for BUF_BYTES_MAX.
11896
dd52fcea
PE
11897 * image.c: Use ptrdiff_t, not int, for sizes.
11898 (slurp_file): Switch from int to ptrdiff_t.
11899 All uses changed.
11900 (slurp_file): Check that file size fits in both size_t (for
11901 malloc) and ptrdiff_t (for sanity and safety).
11902
7f9bbdbb
PE
11903 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11904 if b->modtime has its maximal value.
11905
dfe18f82
PE
11906 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11907
84acfcf0
PE
11908 Don't assume time_t can fit into int.
11909 * buffer.h (struct buffer.modtime): Now time_t, not int.
11910 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11911 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11912
ccd9a01a
PE
11913 Minor fixes for signed vs unsigned integers.
11914 * character.h (MAYBE_UNIFY_CHAR):
11915 * charset.c (maybe_unify_char):
11916 * keyboard.c (read_char, reorder_modifiers):
11917 XINT -> XFASTINT, since the integer must be nonnegative.
11918 * ftfont.c (ftfont_spec_pattern):
11919 * keymap.c (access_keymap, silly_event_symbol_error):
11920 XUINT -> XFASTINT, since the integer must be nonnegative.
11921 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11922 since it makes no difference and we prefer signed.
11923 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11924 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11925 nonnegative.
11926
d6d100dd
SM
119272011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11928
11929 * window.h (Fwindow_frame): Declare.
11930
2b6148e4
PE
119312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11932
11933 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11934 (SPARE_MEMORY): Always define.
11935 (LARGE_REQUEST): Remove.
11936 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11937
f230ecc9
MR
119382011-06-06 Martin Rudalics <rudalics@gmx.at>
11939
727e958e
MR
11940 * lisp.h: Move EXFUNS for Fframe_root_window,
11941 Fframe_first_window and Fset_frame_selected_window to window.h.
11942
11943 * window.h: Move EXFUNS for Fframe_root_window,
11944 Fframe_first_window and Fset_frame_selected_window here from
11945 lisp.h.
11946
11947 * frame.c (Fwindow_frame, Fframe_first_window)
11948 (Fframe_root_window, Fframe_selected_window)
11949 (Fset_frame_selected_window): Move to window.c.
11950 (Factive_minibuffer_window): Move to minibuf.c.
11951 (Fother_visible_frames_p): New function.
11952
11953 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11954
f230ecc9
MR
11955 * window.c (decode_window, decode_any_window): Move up in code.
11956 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11957 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11958 (Fwindow_buffer): Move up and rewrite doc-string.
11959 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11960 (Fwindow_prev): New functions.
727e958e
MR
11961 (Fwindow_frame): Move here from frame.c. Accept any window as
11962 argument.
11963 (Fframe_root_window, Fframe_first_window)
11964 (Fframe_selected_window): Move here from frame.c. Accept frame
11965 or arbitrary window as argument. Update doc-strings.
11966 (Fminibuffer_window): Move up in code.
11967 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11968 (Fset_frame_selected_window): Move here from frame.c.
11969 Marginal rewrite.
727e958e
MR
11970 (Fselected_window, select_window, Fselect_window): Move up in
11971 code. Minor doc-string fixes.
f230ecc9 11972
4d09bcf6
PE
119732011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11974
11975 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11976 Do not assume that spare memory exists; that assumption is valid
11977 only if SYSTEM_MALLOC.
11978 (LARGE_REQUEST): New macro, so that the issue of large requests
11979 is separated from the issue of spare memory.
11980
810928a2
AS
119812011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11982
172418ad
AS
11983 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11984 format. (Bug#8806)
11985
43f862f7
AS
11986 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11987
810928a2
AS
11988 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11989 before statements.
11990
a059fe24
JD
119912011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11992
11993 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11994
11995 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11996
11997 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11998 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11999
989bf368
JB
120002011-06-05 Juanma Barranquero <lekktu@gmail.com>
12001
12002 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
12003
4b80f674
CY
120042011-06-04 Chong Yidong <cyd@stupidchicken.com>
12005
12006 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
12007 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
12008 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
12009 New error handlers.
4b80f674
CY
12010 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
12011 Obey Vx_select_enable_clipboard_manager. Catch errors in
12012 x_clipboard_manager_save (Bug#8779).
12013 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 12014 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 12015
99a33b77 120162011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
12017
12018 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
12019
99a33b77 120202011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
12021
12022 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
12023 in the current matrix if keep_current_p is non-zero.
12024
8264569d
EZ
120252011-06-04 Eli Zaretskii <eliz@gnu.org>
12026
12027 * bidi.c (bidi_level_of_next_char): Fix last change.
12028
57f97249
EZ
120292011-06-03 Eli Zaretskii <eliz@gnu.org>
12030
fec2107c 12031 Support bidi reordering of text covered by display properties.
57f97249 12032
fec2107c
EZ
12033 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
12034 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
12035 (bidi_cache_search, bidi_cache_iterator_state)
12036 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
12037 (bidi_level_of_next_char, bidi_move_to_visually_next):
12038 Support character positions inside a run of characters covered by a
fec2107c
EZ
12039 display string.
12040 (bidi_paragraph_init, bidi_resolve_explicit_1)
12041 (bidi_level_of_next_char): Call bidi_fetch_char and
12042 bidi_fetch_char_advance instead of FETCH_CHAR and
12043 FETCH_CHAR_ADVANCE.
12044 (bidi_init_it): Initialize new members.
12045 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
12046 definitions.
12047 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
12048 instead of using explicit *_CHAR codes.
d6d100dd
SM
12049 (bidi_resolve_explicit, bidi_resolve_weak):
12050 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
12051 bidirectional text is supported only in multibyte buffers.
12052 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
12053 it to initialize the frame_window_p member of struct bidi_it.
12054 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
12055 (bidi_resolve_explicit, bidi_resolve_weak)
12056 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
12057 bidi_it->nchars is non-positive.
12058 (bidi_level_of_next_char): Don't try to lookup the cache for the
12059 next/previous character if nothing is cached there yet, or if we
12060 were just reseat()'ed to a new position.
c40e2fb2 12061
0e14fe90
EZ
12062 * xdisp.c (set_cursor_from_row): Set start and stop points
12063 according to the row's direction when priming the loop that looks
12064 for the glyph on which to display cursor.
12065 (single_display_spec_intangible_p): Function deleted.
12066 (display_prop_intangible_p): Reimplement to call
12067 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
12068 Accept 3 additional arguments needed by handle_display_spec.
12069 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
12070 values: lists, `(when COND...)' forms, etc.
12071 (single_display_spec_string_p): Support property values that are
12072 lists with the argument STRING its top-level element.
12073 (display_prop_string_p): Fix the condition for processing a
12074 property that is a list to be consistent with handle_display_spec.
fec2107c 12075 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
12076 last portion of handle_display_prop.
12077 (compute_display_string_pos): Accept additional argument
12078 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
12079 value of a `display' property is a "replacing spec".
12080 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
12081 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
12082 the display property, but just return a value indicating whether
12083 the display property will replace the characters it covers.
12084 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
12085 frame_window_p members of struct bidi_it.
d6d100dd
SM
12086 (compute_display_string_pos, compute_display_string_end):
12087 New functions.
fec2107c
EZ
12088 (push_it): Accept second argument POSITION, where pop_it should
12089 jump to continue iteration.
12090 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 12091
fec2107c
EZ
12092 * keyboard.c (adjust_point_for_property): Adjust the call to
12093 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
12094
12095 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
12096 (bidi_init_it): Update prototypes.
12097 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
12098 (compute_display_string_pos, compute_display_string_end):
12099 Declare prototypes.
fec2107c
EZ
12100 (struct bidi_it): New members nchars and disp_pos. ch_len is now
12101 EMACS_INT.
fc6f18ce 12102
40087514 121032011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 12104
57f53182
PE
12105 Malloc failure behavior now depends on size of allocation.
12106 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
12107 * lisp.h: Change signatures accordingly.
12108 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
12109 All callers changed. (Bug#8762)
12110
12111 * gnutls.c: Use Emacs's memory allocators.
12112 Without this change, the gnutls library would invoke malloc etc.
12113 directly, which causes problems on non-SYNC_INPUT hosts, and which
12114 runs afoul of improving memory_full behavior. (Bug#8761)
12115 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
12116 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
12117 xfree instead of the default malloc, realloc, free.
12118 (Fgnutls_boot): No need to check for memory allocation failure,
12119 since xmalloc does that for us.
12120
ac32cd99 12121 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
12122 * category.c (hash_get_category_set):
12123 * ccl.c (ccl_driver):
12124 * charset.c (Fdefine_charset_internal):
12125 * charset.h (struct charset.hash_index):
12126 * composite.c (get_composition_id, gstring_lookup_cache)
12127 (composition_gstring_put_cache):
12128 * composite.h (struct composition.hash_index):
12129 * dispextern.h (struct image.hash):
12130 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
12131 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
12132 (hashfn_equal, hashfn_user_defined, make_hash_table)
12133 (maybe_resize_hash_table, hash_lookup, hash_put)
12134 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
12135 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
12136 (Fsxhash, Fgethash, Fputhash, Fmaphash):
12137 * image.c (make_image, search_image_cache, lookup_image)
12138 (xpm_put_color_table_h):
12139 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 12140 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 12141 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 12142 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
12143 * alloc.c (allocate_vectorlike):
12144 Check for overflow in vector size calculations.
12145 * ccl.c (ccl_driver):
12146 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
12147 * fns.c, image.c: Remove unnecessary static decls that would otherwise
12148 need to be updated by these changes.
40087514
PE
12149 * fns.c (make_hash_table, maybe_resize_hash_table):
12150 Check for integer overflow with large hash tables.
0de4bb68
PE
12151 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
12152 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
12153 (SXHASH_REDUCE): New macro.
12154 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
12155 Use it instead of discarding useful hash info with large hash values.
12156 (sxhash_float): New function.
12157 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
12158 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
12159 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
12160 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
12161 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
12162 Adjust signatures to match updated version of code.
12163 (consing_since_gc): Now EMACS_INT, since a single hash table can
12164 use more than INT_MAX bytes.
12165
698d32e2
DN
121662011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
12167
12168 Make it possible to build with GCC-4.6+ -O2 -flto.
12169
12170 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
12171
fd6fa53f
SM
121722011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
12173
12174 * minibuf.c (get_minibuffer, read_minibuf_unwind):
12175 Call minibuffer-inactive-mode.
12176
864db017
JB
121772011-05-31 Juanma Barranquero <lekktu@gmail.com>
12178
12179 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
12180 Update dependencies.
12181
2ad0baf4
DN
121822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12183
12184 * data.c (init_data): Remove code for UTS, this system is not
12185 supported anymore.
12186
4fcc2638
DN
121872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12188
12189 Don't force ./temacs to start in terminal mode.
12190
12191 * frame.c (make_initial_frame): Initialize faces in all cases, not
12192 only when CANNOT_DUMP is defined.
12193 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
12194
c56e0fd5
DN
121952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12196
12197 * dispnew.c (add_window_display_history): Use const for the string
12198 pointer. Remove declaration, not needed.
12199
333d54da 122002011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 12201
55d4c1b2 12202 Use 'inline', not 'INLINE'.
333d54da 12203 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
12204 * alloc.c, fontset.c (INLINE): Remove.
12205 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
12206 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
12207 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
12208 * gmalloc.c (register_heapinfo): Use inline unconditionally.
12209 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
12210
738db178
DN
122112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12212
12213 Make it possible to run ./temacs.
12214
12215 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
12216 syms_of_callproc does the same thing. Remove test for
12217 "initialized", do it in the caller.
12218 * emacs.c (main): Avoid calling set_initial_environment when dumping.
12219
620c53a6
SM
122202011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
12221
12222 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
12223 (read_minibuf): Use get_minibuffer.
12224 (syms_of_minibuf): Use DEFSYM.
12225 (Qmetadata): New var.
12226 * data.c (Qbuffer): Don't make it static.
12227 (syms_of_data): Use DEFSYM.
12228
e003a292
PE
122292011-05-31 Paul Eggert <eggert@cs.ucla.edu>
12230
12231 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
12232 (CCL_CODE_MIN): New macro.
12233
ed008a6d
PE
122342011-05-30 Paul Eggert <eggert@cs.ucla.edu>
12235
3687c2ef
PE
12236 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
12237
ed008a6d
PE
12238 * eval.c (Qdebug): Now static.
12239 * lisp.h (Qdebug): Remove decl. This reverts a part of the
12240 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
12241 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
12242
d66c4c7c
CY
122432011-05-29 Chong Yidong <cyd@stupidchicken.com>
12244
12245 * image.c: Various fixes to ImageMagick code comments.
12246 (Fimagemagick_types): Doc fix.
12247
5fbc2025
PE
122482011-05-29 Paul Eggert <eggert@cs.ucla.edu>
12249
0196f88a
PE
12250 Minor fixes prompted by GCC 4.6.0 warnings.
12251
12252 * xselect.c (converted_selections, conversion_fail_tag): Now static.
12253
5fbc2025
PE
12254 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
12255 (x_clipboard_manager_save_all): Move extern decl to ...
12256 * xterm.h: ... here, so that it can be checked for consistency.
12257
1dd3c2d9
CY
122582011-05-29 Chong Yidong <cyd@stupidchicken.com>
12259
12260 * xselect.c (x_clipboard_manager_save_frame)
12261 (x_clipboard_manager_save_all): New functions.
12262 (Fx_clipboard_manager_save): Lisp function deleted.
12263
12264 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
12265 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
12266
12267 * xterm.h: Update prototype.
12268
5ba6571d
WX
122692011-05-28 William Xu <william.xwl@gmail.com>
12270
12271 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
12272 exiting (Bug#8239).
12273
3eaff834
JM
122742011-05-28 Jim Meyering <meyering@redhat.com>
12275
e1900994 12276 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
12277 * fns.c (to_uchar): Define.
12278 (crypto_hash_function): Use it to convert some newly-signed
12279 variables to unsigned, to avoid sign-extension bugs. For example,
12280 without this change, (md5 "truc") would evaluate to
12281 45723a2aff78ff4fff7fff1114760e62 rather than the expected
12282 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 12283 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 12284
0f6990a7
PE
122852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12286
12287 Integer overflow fixes.
c8a9ca5a 12288
08686060
PE
12289 * dbusbind.c: Serial number integer overflow fixes.
12290 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
12291 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
12292 to hold a serial number that is too large for a fixnum.
12293 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12294 Check for serial numbers out of range. Decode any serial number
59568bf0 12295 that was so large that it became a float. (Bug#8722)
08686060 12296
2d1fc3c7
PE
12297 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
12298 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12299 Use XFASTINT rather than XUINT when numbers are nonnegative.
12300 (xd_append_arg, Fdbus_method_return_internal):
12301 (Fdbus_method_error_internal): Likewise. Also, for unsigned
12302 arguments, check that Lisp number is nonnegative, rather than
59568bf0 12303 silently wrapping negative numbers around. (Bug#8722)
30217ff0 12304 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 12305 (Bug#8722)
2d1fc3c7 12306
c8a9ca5a
PE
12307 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
12308
519e1d69
PE
12309 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
12310
6df6ae42 12311 ccl: Add integer overflow checks.
30569699
PE
12312 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
12313 (IN_INT_RANGE): New macros.
12314 (ccl_driver): Use them to check for integer overflow when
12315 decoding a CCL program. Many of the new checks are whether XINT (x)
12316 fits in int; it doesn't always, on 64-bit hosts. The new version
12317 doesn't catch all possible integer overflows, but it's an
847044ea 12318 improvement. (Bug#8719)
30569699 12319
c11285dc
PE
12320 * alloc.c (make_event_array): Use XINT, not XUINT.
12321 There's no need for unsigned here.
12322
fdccd48e
PE
12323 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
12324 This follows up to the 2011-05-06 change that substituted uintptr_t
12325 for EMACS_INT. This case wasn't caught back then.
12326
37910ab2
PE
12327 Rework Fformat to avoid integer overflow issues.
12328 * editfns.c: Include <float.h> unconditionally, as it's everywhere
12329 now (part of C89). Include <verify.h>.
12330 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
12331 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
12332 (Fformat): Avoid the prepass trying to compute sizes; it was only
12333 approximate and thus did not catch overflow reliably. Instead, walk
12334 through the format just once, formatting and computing sizes as we go,
12335 checking for integer overflow at every step, and allocating a larger
12336 buffer as needed. Keep track separately whether the format is
12337 multibyte. Keep only the most-recently calculated precision, rather
12338 than them all. Record whether each argument has been converted to
12339 string. Use EMACS_INT, not int, for byte and char and arg counts.
12340 Support field widths and precisions larger than INT_MAX. Avoid
12341 sprintf's undefined behavior with conversion specifications such as %#d
12342 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
12343 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
12344 formatting out-of-range floating point numbers with int
9173deec 12345 formats. (Bug#8668)
37910ab2 12346
2e6578fb
PE
12347 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
12348
0ae6bdee
PE
12349 * data.c: Avoid integer truncation in expressions involving floats.
12350 * data.c: Include <intprops.h>.
12351 (arith_driver): When there's an integer overflow in an expression
12352 involving floating point, convert the integers to floating point
12353 so that the resulting value does not suffer from catastrophic
12354 integer truncation. For example, on a 64-bit host (* 4
12355 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
12356 Do not rely on undefined behavior after integer overflow.
12357
de883a70
PE
12358 merge count_size_as_multibyte, parse_str_to_multibyte
12359 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 12360 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
12361 Check for integer overflow.
12362 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
12363 since it's now a duplicate of the other. This is more of
12364 a character than a buffer op, so better that it's in character.c.
12365 * fns.c, print.c: Adjust to above changes.
12366
2ff916cb
PE
123672011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
12368
12369 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
12370
f1b54466
PE
123712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12372
fb1ac845
PE
12373 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12374 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
12375 (x_clipboard_manager_save): Now static.
12376 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
12377
f1b54466
PE
12378 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12379 (crypto_hash_function): Now static.
12380 Fix pointer signedness problems. Avoid unnecessary initializations.
12381
a9f737ee
CY
123822011-05-27 Chong Yidong <cyd@stupidchicken.com>
12383
12384 * termhooks.h (Vselection_alist): Make it terminal-local.
12385
12386 * terminal.c (create_terminal): Initialize it.
12387
12388 * xselect.c: Support for clipboard managers.
12389 (Vselection_alist): Move to termhooks.h as terminal-local var.
12390 (LOCAL_SELECTION): New macro.
12391 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
12392 (symbol_to_x_atom): Remove gratuitous arg.
12393 (x_handle_selection_request, lisp_data_to_selection_data)
12394 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
12395 (x_own_selection, x_get_local_selection, x_convert_selection):
12396 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
12397 (some_frame_on_display): Delete unused function.
12398 (Fx_own_selection_internal, Fx_get_selection_internal)
12399 (Fx_disown_selection_internal, Fx_selection_owner_p)
12400 (Fx_selection_exists_p): New optional frame arg.
12401 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12402 (x_handle_selection_clear): Don't treat other terminals with the
12403 same keyboard specially. Use the terminal-local Vselection_alist.
12404 (x_clear_frame_selections): Use Frun_hook_with_args.
12405
12406 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12407
12408 * xterm.h: Add support for those atoms.
12409
e067f0c1
CY
124102011-05-26 Chong Yidong <cyd@stupidchicken.com>
12411
12412 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12413 (converted_selections, conversion_fail_tag): New global variables.
12414 (x_selection_request_lisp_error): Free the above.
12415 (x_get_local_selection): Remove unnecessary code.
12416 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12417 of converted selections stored in converted_selections.
12418 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12419 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12420 (x_convert_selection): New function.
12421 (x_handle_selection_event): Simplify.
12422 (x_get_foreign_selection): Don't ignore incoming requests while
12423 waiting for an answer; this will fail when we implement
12424 SAVE_TARGETS, and seems unnecessary anyway.
12425 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12426 (Vx_sent_selection_functions): Doc fix.
12427
0f4aebc0
LL
124282011-05-26 Leo Liu <sdl.web@gmail.com>
12429
12430 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12431
e61124cd
YM
124322011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12433
12434 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12435
12436 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12437 for fringe update if it has periodic bitmap.
ac389d0c 12438 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12439 and fringe_bitmap_periodic_p.
12440
12441 * fringe.c (get_fringe_bitmap_data): New function.
12442 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12443 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12444 row. Mark glyph row for fringe update if periodicity changed.
12445
12446 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12447 for fringe update unless it has periodic bitmap.
12448
f16d9837
KH
124492011-05-25 Kenichi Handa <handa@m17n.org>
12450
12451 * xdisp.c (get_next_display_element): Set correct it->face_id for
12452 a static composition.
12453
e1b90ef6
LL
124542011-05-24 Leo Liu <sdl.web@gmail.com>
12455
12456 * deps.mk (fns.o):
12457 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12458
12459 * fns.c (crypto_hash_function, Fsha1): New function.
12460 (Fmd5): Use crypto_hash_function.
12461 (syms_of_fns): Add Ssha1.
12462
7400048f
PE
124632011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12464
12465 * gnutls.c: Remove unused macros.
12466 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12467 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12468 Remove macros that are defined and never used.
12469 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12470
abb71cf4
CY
124712011-05-22 Chong Yidong <cyd@stupidchicken.com>
12472
12473 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12474 (Fx_get_selection_internal): Minor cleanup.
12475 (Fx_own_selection_internal): Rename arguments for consistency with
12476 select.el.
12477
6307db39
PE
124782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12479
12480 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12481
f3d4e0a4
CY
124822011-05-22 Chong Yidong <cyd@stupidchicken.com>
12483
12484 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12485
4d8ade89
YM
124862011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12487
12488 * dispnew.c (scrolling_window): Don't exclude the case that the
12489 last enabled row in the desired matrix touches the bottom boundary.
12490
32078c8d
GM
124912011-05-21 Glenn Morris <rgm@gnu.org>
12492
12493 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12494 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12495 and add some more files.
32078c8d 12496
7285dc67
EZ
124972011-05-20 Eli Zaretskii <eliz@gnu.org>
12498
12499 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12500 report_file_error introduced by the change from 2011-05-07.
12501
89d1bd22
PE
125022011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12503
12504 * systime.h (Time): Define only if emacs is defined.
12505 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12506 where the include path doesn't have X11/X.h by default. See
12507 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12508
cd394be1 125092011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12510
12511 * composite.c (find_automatic_composition): Fix previous change.
12512
b9704ad9
GM
125132011-05-20 Glenn Morris <rgm@gnu.org>
12514
12515 * lisp.mk: New file, split from Makefile.in.
12516 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12517 (shortlisp): Remove.
12518 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12519
4a720484
GM
125202011-05-19 Glenn Morris <rgm@gnu.org>
12521
12522 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12523 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12524 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12525 (lisp): Set the order to that of loadup.el.
12526 (shortlisp): Make it a copy of $lisp.
12527 (SOME_MACHINE_LISP): Remove.
12528 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12529 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12530
a28d4396
KH
125312011-05-18 Kenichi Handa <handa@m17n.org>
12532
12533 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12534 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12535 (find_automatic_composition): Mostly rewrite for efficiency.
12536
a2b1fa8e
JB
125372011-05-18 Juanma Barranquero <lekktu@gmail.com>
12538
12539 * makefile.w32-in: Update dependencies.
12540
8e1f5610
CS
125412011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12542
12543 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12544 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12545
7025ee00 125462011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12547
cdfa6eab
PE
12548 Fix some integer overflow issues, such as string length overflow.
12549
06d6db33
PE
12550 * insdel.c (count_size_as_multibyte): Check for string overflow.
12551
2b4560a8
PE
12552 * character.c (lisp_string_width): Check for string overflow.
12553 Use EMACS_INT, not int, for string indexes and lengths; in
12554 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12555 the resulting string length overflows an EMACS_INT; instead,
12556 report a string overflow if no precision given. When checking for
12557 precision exhaustion, use a check that cannot possibly have
12558 integer overflow. (Bug#8675)
12559 * character.h (lisp_string_width): Adjust to new signature.
12560
cb93f9be
PE
12561 * alloc.c (string_overflow): New function.
12562 (Fmake_string): Use it. This doesn't change behavior, but saves
12563 a few bytes and will simplify future changes.
12564 * character.c (string_escape_byte8): Likewise.
12565 * lisp.h (string_overflow): New decl.
12566
1a1f3366
PE
12567 Fixups, following up to the user-interface timestamp change.
12568 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12569 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12570 * msdos.c (mouse_get_pos): Likewise.
12571 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12572 * w32gui.h (Time): Define by including "systime.h" rather than by
12573 declaring it ourselves. (Bug#8664)
12574
d4e3e4d3
PE
12575 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12576 * image.c (clear_image_cache): Likewise.
12577
f6a24d19
PE
12578 * term.c (term_mouse_position): Don't assume time_t wraparound.
12579
08dc5ae6
PE
12580 Be more systematic about user-interface timestamps.
12581 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12582 and sometimes 'EMACS_UINT', to represent these timestamps.
12583 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12584 This makes the code easier to follow, and makes it easier to catch
12585 integer overflow bugs such as Bug#8664.
12586 * frame.c (Fmouse_position, Fmouse_pixel_position):
12587 Use Time, not unsigned long, for user-interface timestamps.
12588 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12589 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12590 * keyboard.h (last_event_timestamp): Likewise.
12591 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12592 * menu.h (xmenu_show): Likewise.
12593 * term.c (term_mouse_position): Likewise.
12594 * termhooks.h (struct input_event.timestamp): Likewise.
12595 (struct terminal.mouse_position_hook): Likewise.
12596 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12597 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12598 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12599 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12600 what it was before.
12601 * menu.h, termhooks.h: Include "systime.h", for Time.
12602
8e55734a
PE
12603 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12604 Don't assume that the difference between two unsigned long values
12605 can fit into an integer. At this point, we know button_down_time
12606 <= event->timestamp, so the difference must be nonnegative, so
12607 there's no need to cast the result if double-click-time is
12608 nonnegative, as it should be; check that it's nonnegative, just in
12609 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12610 apart (about 25 days). (Bug#8664)
8e55734a 12611
841f1b75 12612 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12613 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12614
3e26f69c
PE
12615 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12616 that always fit in int. Use a sentinel instead of a counter, to
12617 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12618 * frame.h (struct frame): Use int for menu_bar_items_used
12619 instead of EMACS_INT, since it always fits in int.
3e26f69c 12620
5cc152c0
PE
12621 * menu.c (grow_menu_items): Check for int overflow.
12622
d89eb65e
PE
12623 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12624
5235bd3e
PE
12625 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12626 Before, the code was not consistent. These values cannot exceed
12627 2**31 - 1 so there's no need to make them unsigned.
12628 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12629 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12630 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12631 as modifiers.
12632 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12633
bc827e23
PE
12634 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12635 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12636 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12637 presumably because the widths might not match.
12638
78eb494e
PE
12639 * window.c (size_window): Avoid needless test at loop start.
12640
04f2d78b
CB
126412011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12642
12643 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12644
d2fc7e3d 126452011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12646
12647 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12648
d2fc7e3d 126492011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12650
12651 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12652 `width' to `bar_area_x' and `bar_area_width', respectively.
12653 (x_scroll_run): Take account of fringe background extension.
12654
04f2d78b
CB
12655 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12656 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12657 `bar_area_width', respectively.
12658 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12659 background extension.
12660
79b70037
GM
126612011-05-10 Jim Meyering <meyering@redhat.com>
12662
12663 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12664
2f142cc5
JB
126652011-05-10 Juanma Barranquero <lekktu@gmail.com>
12666
12667 * image.c (Finit_image_library): Return t for built-in image types,
12668 like pbm and xbm. (Bug#8640)
12669
57679c86
AS
126702011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12671
12672 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12673
888c9e86
EZ
126742011-05-07 Eli Zaretskii <eliz@gnu.org>
12675
b0512a1d
EZ
12676 * w32console.c (Fset_screen_color): Doc fix.
12677 (Fget_screen_color): New function.
12678 (syms_of_ntterm): Defsubr it.
12679
7285dc67
EZ
12680 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12681 unlink the temporary file if Fcall_process didn't create it in the
12682 first place.
12683 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12684 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12685 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12686 cue to call_process_cleanup not to close that handle.
12687
4d3fcc8e
BK
126882011-05-07 Ben Key <bkey76@gmail.com>
12689
12690 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12691 one of two shell specific rules, either bootstrap-temacs-CMD or
12692 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12693 to the previous implementation of the bootstrap-temacs rule.
12694 The bootstrap-temacs-CMD rule is similar to the previous
12695 implementation of the bootstrap-temacs rule except that it
12696 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12697 variable.
12698
12699 These changes, along with some changes to nt/configure.bat,
12700 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12701 earlier fix to add support for --cflags and --ldflags options
12702 that include quotes so that it works whether make uses cmd or
12703 sh as the shell.
12704
b4289b64
MA
127052011-05-06 Michael Albinus <michael.albinus@gmx.de>
12706
12707 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12708 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12709 is a constant.
12710 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12711 a string. Handle both cases.
12712 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12713 (Fdbus_register_method): Use Qinvalid_function.
12714
af4c0e28
JB
127152011-05-06 Juanma Barranquero <lekktu@gmail.com>
12716
12717 * makefile.w32-in: Update dependencies.
12718 (LISP_H): Add inttypes.h and stdin.h.
12719 (PROCESS_H): Add unistd.h.
12720
c51453d9
EZ
127212011-05-06 Eli Zaretskii <eliz@gnu.org>
12722
12723 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12724 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12725
8ff0ac3c 127262011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12727
4c4b566b
PE
12728 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12729
aab2b9b5
PE
12730 * term.c (vfatal): Remove stray call to va_end.
12731 It's not needed and the C Standard doesn't allow it here anyway.
12732
c378da0b
PE
12733 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12734 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12735
288b08c7
PE
12736 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12737 bytes.
12738
e3601888
PE
12739 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12740
db6c0e74
PE
12741 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12742
dd5963ea
PE
12743 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12744
88c9450f
PE
12745 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12746
2f9442b8
PE
12747 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12748
c032b5f8
PE
12749 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12750 * charset.c (Fdefine_charset_internal): Don't initialize
12751 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12752 32-bit int (Bug#8600).
a108c10b
PE
12753
12754 * lread.c (read_integer): Be more consistent with string-to-number.
12755 Use string_to_number to do the actual conversion; this avoids
12756 rounding errors and fixes some other screwups. Without this fix,
12757 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12758 (digit_to_number): Move earlier, for benefit of read_integer.
12759 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12760 not a digit in any supported base. (Bug#8602)
a108c10b 12761
ad5f9eea
PE
12762 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12763
aec1708a
PE
12764 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12765 to match comment at start of function. This also removes a
12766 GCC warning about overflow in a 32+64-bit port.
12767
47be4ab5
PE
12768 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12769
371cac43
PE
12770 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12771 Reported by Stefan Monnier in
12772 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12773 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12774 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12775
d01a7826
PE
12776 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12777 (EMACS_UINTPTR): Likewise, with uintptr_t.
12778
7fd47d5c
PE
12779 * lisp.h: Prefer 64-bit EMACS_INT if available.
12780 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12781 on 32-bit hosts that have 64-bit int, so that they can access
12782 large files.
122b0c86
PE
12783 However, temporarily disable this change unless the temporary
12784 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12785
8727937b
PE
12786 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12787
8ac068ac
PE
12788 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12789 This removes an assumption that EMACS_INT and long are the same
12790 width as pointers. The assumption is true for Emacs porting targets
12791 now, but we want to make other targets possible.
12792 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12793 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12794 In the rest of the code, change types of integers that hold casted
12795 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12796 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12797 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12798 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12799 No need to cast type when ORing.
12800 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12801 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12802 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12803 assume EMACS_INT is the same width as char *.
12804 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12805 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12806 Remove no-longer-needed casts.
12807 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12808 (xg_tool_bar_help_callback, xg_make_tool_item):
12809 Use EMACS_INTPTR to hold an integer
12810 that will be cast to void *; this can avoid a GCC warning
12811 if EMACS_INT is not the same width as void *.
12812 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12813 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12814 (current_message_1, set_message_1):
12815 Use a local to convert to proper width without a cast.
12816 * xmenu.c (dialog_selection_callback): Likewise.
12817
ede49d71
PE
12818 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12819 Also, don't assume VALBITS / RAND_BITS is less than 5,
12820 and don't rely on undefined behavior when shifting a 1 left into
12821 the sign bit.
12822 * lisp.h (get_random): Change signature to match.
12823
2f30ecd0
PE
12824 * lread.c (hash_string): Use size_t, not int, for hash computation.
12825 Normally we prefer signed values; but hashing is special, because
12826 it's better to use unsigned division on hash table sizes so that
12827 the remainder is nonnegative. Also, size_t is the natural width
12828 for hashing into memory. The previous code used 'int', which doesn't
12829 retain enough info to hash well into very large tables.
12830 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12831
2a866e7b
PE
12832 * dbusbind.c: Don't possibly lose pointer info when converting.
12833 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12834 Use XPNTR rather than XHASH, so that the high-order bits of
12835 the pointer aren't lost when converting through void *.
12836
51639eac
PE
12837 * eval.c (Fautoload): Don't double-shift a pointer.
12838
92394119
PE
12839 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12840
dbdb9a7c
JB
128412011-05-06 Juanma Barranquero <lekktu@gmail.com>
12842
12843 * gnutls.c (DEF_GNUTLS_FN):
12844 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12845
db7a0b4f
AS
128462011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12847
12848 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12849 marker. (Bug#8610)
12850
cd394be1 128512011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12852
12853 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12854 New version that can reserve upto 2GB of heap space.
12855
f7ff1b0f 128562011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12857
12858 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12859
639c109b
TZ
128602011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12861
12862 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12863 `gnutls_certificate_set_x509_key_file'.
12864
d2127135
JB
128652011-05-05 Juanma Barranquero <lekktu@gmail.com>
12866
12867 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12868 Update dependencies.
12869
e968f4f3
JB
128702011-05-04 Juanma Barranquero <lekktu@gmail.com>
12871
12872 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12873 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12874 Remove unused parameter `fildes'.
12875 * process.c (read_process_output, send_process): Don't pass it.
12876
84d358f0
JB
128772011-05-04 Juanma Barranquero <lekktu@gmail.com>
12878
12879 Fix previous change: the library cache is defined in w32.c.
12880 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12881 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12882
0898ca10
JB
128832011-05-04 Juanma Barranquero <lekktu@gmail.com>
12884
12885 Implement dynamic loading of GnuTLS on Windows.
12886
12887 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12888 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12889 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12890 Declare.
12891
12892 * gnutls.c (Qgnutls_dll): Define.
12893 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12894 (gnutls_*): Declare function pointers.
12895 (init_gnutls_functions): New function to initialize function pointers.
12896 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12897 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12898 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12899 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12900 (emacs_gnutls_write, emacs_gnutls_read)
12901 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12902 (Fgnutls_available_p): New function.
12903 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12904 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12905 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12906
12907 * image.c: Include w32.h.
12908 (Vimage_type_cache): Delete.
12909 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12910 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12911 (w32_delayed_load): Move to w32.c.
12912
12913 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12914
12915 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12916 (w32_delayed_load): Move from image.c. When loading a library, record
12917 its filename in the :loaded-from property of the library id.
12918 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12919 Initialize and staticpro them.
12920 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12921
12922 * process.c: Include lisp.h before w32.h, not after.
12923 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12924 instead of gnutls_record_check_pending.
12925
12926 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12927
ff4de4aa
TZ
129282011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12929
12930 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12931 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12932 as passed in.
12933
abe95abb
JD
129342011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12935
12936 * xterm.c (x_set_frame_alpha): Do not set property on anything
12937 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12938
e16e55d4
JB
129392011-05-02 Juanma Barranquero <lekktu@gmail.com>
12940
12941 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12942
bafcf6a5
JB
129432011-05-02 Juanma Barranquero <lekktu@gmail.com>
12944
12945 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12946 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12947 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12948 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12949 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12950 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12951 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12952 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12953 (Qgnutls_bootprop_callbacks_verify): Make static.
12954
e7a6747f
AS
129552011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12956
19ed11ba
AS
12957 * callproc.c: Indentation fixup.
12958
e7a6747f 12959 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12960 (wait_for_termination, interruptible_wait_for_termination):
12961 Move after wait_for_termination_1.
e7a6747f 12962
1ef14cb4
LMI
129632011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12964
12965 * sysdep.c (interruptible_wait_for_termination): New function
12966 which is like wait_for_termination, but allows keyboard
12967 interruptions.
12968
12969 * callproc.c (Fcall_process): Add (:file "file") as an option for
12970 the STDOUT buffer.
12971 (Fcall_process_region): Ditto.
12972
330d880c
EZ
129732011-04-30 Eli Zaretskii <eliz@gnu.org>
12974
8db90b73
EZ
12975 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12976 rather than `XVECTOR (FOO)->size'.
12977
330d880c
EZ
12978 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12979 inttypes.h, as a gnulib replacement is used if it not available in
12980 system headers.
12981
15cbd324
EZ
129822011-04-21 Eli Zaretskii <eliz@gnu.org>
12983
12984 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12985 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12986 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12987
12988 * coding.c (coding_alloc_by_realloc): Error out if destination
12989 will grow beyond MOST_POSITIVE_FIXNUM.
12990 (decode_coding_emacs_mule): Abort if there isn't enough place in
12991 charbuf for the composition carryover bytes. Reserve an extra
12992 space for up to 2 characters produced in a loop.
12993 (decode_coding_iso_2022): Abort if there isn't enough place in
12994 charbuf for the composition carryover bytes.
12995
129962011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12997
ae940cca
EZ
12998 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12999 aborting when %lld or %lll format is passed.
13000 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
13001 %llo or %llx format is passed. (Bug#8545)
13002
03ab8921
EZ
13003 * window.c (window_scroll_line_based): Use a marker instead of
13004 simple variables to record original value of point. (Bug#7952)
13005
afda1437
EZ
13006 * doprnt.c (doprnt): Fix the case where a multibyte sequence
13007 produced by %s or %c overflows available buffer space. (Bug#8545)
13008
f76dee0c
PE
130092011-04-28 Paul Eggert <eggert@cs.ucla.edu>
13010
13011 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 13012 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 13013
fdc5744d
JB
130142011-04-28 Juanma Barranquero <lekktu@gmail.com>
13015
13016 * w32.c (init_environment): Warn about defaulting HOME to C:\.
13017
638f053a
JB
130182011-04-28 Juanma Barranquero <lekktu@gmail.com>
13019
13020 * keyboard.c (Qdelayed_warnings_hook): Define.
13021 (command_loop_1): Run `delayed-warnings-hook'
13022 if Vdelayed_warnings_list is non-nil.
13023 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
13024 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
13025
d178f871
EZ
130262011-04-28 Eli Zaretskii <eliz@gnu.org>
13027
13028 * doprnt.c (doprnt): Don't return value smaller than the buffer
13029 size if the message was truncated. (Bug#8545).
13030
b124fd93
JB
130312011-04-28 Juanma Barranquero <lekktu@gmail.com>
13032
13033 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
13034 (Fx_window_property): #if-0 the whole functions, not just the bodies.
13035
e810457d
PE
130362011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13037
13038 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
13039
ea51cceb
JB
130402011-04-27 Juanma Barranquero <lekktu@gmail.com>
13041
13042 * makefile.w32-in: Update dependencies.
13043
94dcfacf
EZ
130442011-04-27 Eli Zaretskii <eliz@gnu.org>
13045
13046 Improve `doprnt' and its usage. (Bug#8545)
13047 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
13048 `format_end'. Remove support for %l as a conversion specifier.
13049 Don't use xrealloc. Improve diagnostics when the %l size modifier
13050 is used. Update the commentary.
13051
13052 * eval.c (verror): Simplify calculation of size_t.
13053
13054 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
13055 messages.
13056
f61f41d7
PE
130572011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
13058
13059 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
13060 change.
13061
96fb4434
PE
130622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13063
13064 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
13065 This makes this file independent of the recent pseudovector change.
13066
671875da 130672011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 13068
69e9b5a3
PE
13069 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
13070
b5f869a7 13071 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 13072 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 13073 Remove unused local.
c8926152 13074 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 13075
841a1577 13076 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
13077 GCC 4.6.0 optimizes based on type-based alias analysis.
13078 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
13079 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
13080 != &v->size, and therefore "v->size = 1; b->size = 2; return
13081 v->size;" must therefore return 1. This assumption is incorrect
13082 for Emacs, since it type-puns struct Lisp_Vector * with many other
13083 types. To fix this problem, this patch adds a new type struct
f904488f 13084 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
13085 and pseudovectors, and helps optimizing compilers not get fooled
13086 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
13087 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
13088 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
13089 the size member.
eab3844f
PE
13090 (XSETPVECTYPE): Rewrite in terms of new macro.
13091 (XSETPVECTYPESIZE): New macro, specifying both type and size.
13092 This is a bit clearer, and further avoids the possibility of
13093 undesirable aliasing.
13094 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 13095 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
13096 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
13097 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
13098 (ASIZE): Now uses header.size rather than size.
13099 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
13100 to avoid the hassle of writing XVECTOR (foo)->header.size.
13101 (struct vectorlike_header): New type.
eab3844f
PE
13102 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
13103 object, to help avoid aliasing.
13104 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
13105 (SUBRP): Likewise, since Lisp_Subr is a special case.
13106 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
13107 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
13108 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 13109 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
13110 changed to be "header.size" and "header.next".
13111 * buffer.h (struct buffer): Likewise.
13112 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
13113 * frame.h (struct frame): Likewise.
13114 * process.h (struct Lisp_Process): Likewise.
13115 * termhooks.h (struct terminal): Likewise.
13116 * window.c (struct save_window_data, struct saved_window): Likewise.
13117 * window.h (struct window): Likewise.
13118 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
13119 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
13120 * buffer.c (init_buffer_once): Likewise.
13121 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
13122 special case.
13123 * process.c (Fformat_network_address): Use local var for size,
13124 for brevity.
13125
0df1eac5
PE
13126 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
13127
847ab9d1 13128 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
13129 * data.c (atof): Remove decl; no longer used or needed.
13130 (digit_to_number): Move to lread.c.
13131 (Fstring_to_number): Use new string_to_number function, to be
13132 consistent with how the Lisp reader treats infinities and NaNs.
13133 Do not assume that floating-point numbers represent EMACS_INT
13134 without losing information; this is not true on most 64-bit hosts.
13135 Avoid double-rounding errors, by insisting on integers when
13136 parsing non-base-10 numbers, as the documentation specifies.
13137 * lisp.h (string_to_number): New decl, replacing ...
13138 (isfloat_string): Remove.
bc0a5c13 13139 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 13140 (read1): Do not accept +. and -. as integers; this
452f4150
PE
13141 appears to have been a coding error. Similarly, do not accept
13142 strings like +-1e0 as floating point numbers. Do not report
13143 overflow for integer overflows unless the base is not 10 which
13144 means we have no simple and reliable way to continue.
13145 Break out the floating-point parsing into a new
13146 function string_to_number, so that Fstring_to_number parses
13147 floating point numbers consistently with the Lisp reader.
04f2d78b 13148 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
13149 (E_CHAR, EXP_INT): Remove, replacing with ...
13150 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
13151 (string_to_number): New function, replacing isfloat_string.
13152 This function checks for valid syntax and produces the resulting
13153 Lisp float number too. Rework it so that string-to-number
bc0a5c13 13154 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
13155 so that overflow for non-base-10 numbers is reported only when
13156 there's no portable and simple way to convert to floating point.
452f4150 13157
67769ffc
PE
13158 * textprop.c (set_text_properties_1): Rewrite for clarity,
13159 and to avoid GCC warning about integer overflow.
13160
c20db43f
PE
13161 * intervals.h (struct interval): Use EMACS_INT for members
13162 where EMACS_UINT might cause problems. See
13163 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
13164 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
13165 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
13166 All uses changed.
37aa2f85
PE
13167 (offset_intervals): Tell GCC not to worry about length overflow
13168 when negating a negative length.
c20db43f 13169
2538aa2f
PE
13170 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
13171 (overrun_check_free): Likewise.
13172
f2d3008d
PE
13173 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
13174 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
13175 word size.
13176
ec8df744
PE
13177 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13178 (gnutls_make_error): Rename local to avoid shadowing.
13179 (gnutls_emacs_global_deinit): ifdef out; not used.
13180 (Fgnutls_boot): Use const for pointer to readonly storage.
13181 Comment out unused local. Fix pointer signedness problems.
13182
640ee02d
PE
13183 * lread.c (openp): Don't stuff size_t into an 'int'.
13184 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
13185 about possible signed overflow.
13186
6048fb2a
PE
13187 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13188 (GDK_KEY_g): Don't define if already defined.
13189 (xg_prepare_tooltip): Avoid pointer signedness problem.
13190 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
13191
fa3c87e1
PE
13192 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
13193 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
13194
2172544b
PE
13195 * xfns.c (Fx_window_property): Simplify a bit,
13196 to make a bit faster and to avoid GCC 4.6.0 warning.
13197 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
13198
9b821a21
PE
13199 * fns.c (internal_equal): Don't assume size_t fits in int.
13200
3c616cfa
PE
13201 * alloc.c (compact_small_strings): Tighten assertion a little.
13202
c2982e87
PE
13203 Replace pEd with more-general pI, and fix some printf arg casts.
13204 * lisp.h (pI): New macro, generalizing old pEd macro to other
13205 conversion specifiers. For example, use "...%"pI"d..." rather
13206 than "...%"pEd"...".
13207 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 13208 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
13209 * alloc.c (check_pure_size): Don't overflow by converting size to int.
13210 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
13211 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
13212 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
13213 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
13214 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
13215 64-bit hosts.
13216 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
13217 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
13218 * print.c (safe_debug_print, print_object): Likewise.
13219 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
13220 to int.
6f04d126
PE
13221 Use pI instead of if-then-else-abort. Use %p to avoid casts,
13222 avoiding the 0 flag, which is not portable.
c2982e87
PE
13223 * process.c (Fmake_network_process): Use pI to avoid cast.
13224 * region-cache.c (pp_cache): Likewise.
13225 * xdisp.c (decode_mode_spec): Likewise.
13226 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
13227 behavior on 64-bit hosts with printf arg.
6f04d126 13228 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
13229 (x_stop_queuing_selection_requests): Likewise.
13230 (x_get_window_property): Don't truncate byte count to an 'int'
13231 when tracing.
0b432f21 13232
5e073ec7
PE
13233 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
13234 here, since it parses constructs like leading '-' and spaces,
13235 which are not wanted; and it overflows with large numbers.
13236 Instead, simply match F[0-9]+, which is what is wanted anyway.
13237
36372bf9
PE
13238 * alloc.c: Remove unportable assumptions about struct layout.
13239 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
13240 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
13241 (allocate_vectorlike, make_pure_vector): Use the new macros,
13242 plus offsetof, to remove unportable assumptions about struct layout.
13243 These assumptions hold on all porting targets that I know of, but
13244 they are not guaranteed, they're easy to remove, and removing them
13245 makes further changes easier.
13246
0b432f21
PE
13247 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
13248 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
13249 (string_overrun_cookie): Now const. Use initializers that
13250 don't formally overflow signed char, to avoid warnings.
000098c1
PE
13251 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
13252 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
13253 (allocate_buffer): Don't assume sizeof (struct buffer) is a
13254 multiple of sizeof (EMACS_INT); it need not be, if
13255 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 13256 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 13257
895009e1
JB
132582011-04-26 Juanma Barranquero <lekktu@gmail.com>
13259
13260 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
13261
6a7a1b0b
TZ
132622011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
13263
13264 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 13265 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
13266 Reported by Paul Eggert <eggert@cs.ucla.edu>.
13267
841a1577 132682011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
13269
13270 * lisp.h (Qdebug): List symbol.
895009e1 13271 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
13272 * keyboard.c (debug-on-event): New variable.
13273 (handle_user_signal): Break into debugger when debug-on-event
13274 matches the current signal symbol.
13275
f2d3ba6f
DN
132762011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
13277
13278 * alloc.c (check_sblock, check_string_bytes)
13279 (check_string_free_list): Convert to standard C.
13280
42ce4c63
TZ
132812011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
13282
13283 * w32.c (emacs_gnutls_push): Fix typo.
13284
825cd63c
EZ
132852011-04-25 Eli Zaretskii <eliz@gnu.org>
13286
fb11d64d
EZ
13287 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
13288 "cast to pointer from integer of different size".
13289
825cd63c
EZ
13290 Improve doprnt and its use in verror. (Bug#8545)
13291 * doprnt.c (doprnt): Document the set of format control sequences
13292 supported by the function. Use SAFE_ALLOCA instead of always
13293 using `alloca'.
13294
13295 * eval.c (verror): Don't limit the buffer size at size_max-1, that
13296 is one byte too soon. Don't use xrealloc; instead xfree and
13297 xmalloc anew.
13298
e061a11b
TZ
132992011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
13300
13301 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
13302 callbacks stage.
13303
13304 * gnutls.c: Renamed global_initialized to
13305 gnutls_global_initialized. Added internals for the
13306 :verify-hostname-error, :verify-error, and :verify-flags
13307 parameters of `gnutls-boot' and documented those parameters in the
13308 docstring. Start callback support.
9173deec
JB
13309 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
13310 unless a fatal error occurred. Call gnutls_alert_send_appropriate
13311 on error. Return error code.
e061a11b
TZ
13312 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
13313 (emacs_gnutls_read): Likewise.
13314 (Fgnutls_boot): Return handshake error code.
13315 (emacs_gnutls_handle_error): New function.
13316 (wsaerror_to_errno): Likewise.
13317
13318 * w32.h (emacs_gnutls_pull): Add prototype.
13319 (emacs_gnutls_push): Likewise.
13320
13321 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
13322 (emacs_gnutls_push): Likewise.
13323
133242011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
13325
13326 * process.c (wait_reading_process_output): Check if GnuTLS
13327 buffered some data internally if no FDs are set for TLS
13328 connections.
13329
13330 * makefile.w32-in (OBJ2): Add gnutls.$(O).
13331 (LIBS): Link to USER_LIBS.
13332 ($(BLD)/gnutls.$(0)): New target.
13333
fa6996bc
EZ
133342011-04-24 Eli Zaretskii <eliz@gnu.org>
13335
eb35682e
EZ
13336 * xdisp.c (handle_single_display_spec): Rename the
13337 display_replaced_before_p argument into display_replaced_p, to
13338 make it consistent with the commentary. Fix typos in the
13339 commentary.
13340
e2ad650c
EZ
13341 * textprop.c (syms_of_textprop): Remove dead code.
13342 (copy_text_properties): Delete obsolete commentary about an
13343 interface that was deleted long ago. Fix typos in the description
13344 of arguments.
13345
1b2de274
EZ
13346 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
13347 to changes in oldXMenu/XMenu.h from 2011-04-16.
13348 <menu_help_message, prev_menu_help_message>: Constify.
13349 (IT_menu_make_room): menu->help_text is now `const char **';
13350 adjust.
13351
13352 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
13353 to changes in oldXMenu/XMenu.h from 2011-04-16.
13354 (struct XMenu): Declare `help_text' `const char **'.
13355
13356 * xfaces.c <Qunspecified>: Make extern again.
13357
13358 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 13359 required by POSIX.
1b2de274 13360
762b15be
EZ
13361 * doc.c (get_doc_string): Improve the format passed to `error'.
13362
13363 * doprnt.c (doprnt): Improve commentary.
13364
13365 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
13366
13367 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
13368 them with etags.
13369
f1052e5d
EZ
13370 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13371 changes in globals.h immediately force recompilation.
762b15be
EZ
13372 (TAGS): Depend on $(CURDIR)/m/intel386.h and
13373 $(CURDIR)/s/ms-w32.h.
13374 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 13375
fa6996bc
EZ
13376 * character.c (Fchar_direction): Function deleted.
13377 (syms_of_character): Don't defsubr it.
13378 <char-direction-table>: Deleted.
13379
e6c3da20
EZ
133802011-04-23 Eli Zaretskii <eliz@gnu.org>
13381
13382 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
13383 * doprnt.c: Include limits.h.
13384 (SIZE_MAX): New macro.
04f2d78b
CB
13385 (doprnt): Return a size_t value. 2nd arg is now size_t.
13386 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
13387 Improve overflow protection. Support `l' modifier for integer
13388 conversions. Support %l conversion. Don't assume an EMACS_INT
13389 argument for integer conversions and for %c.
13390
13391 * lisp.h (doprnt): Restore prototype.
13392
13393 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
13394 $(SRC)/character.h.
13395
13396 * Makefile.in (base_obj): Add back doprnt.o.
13397
13398 * deps.mk (doprnt.o): Add back prerequisites.
13399 (callint.o): Depend on character.h.
13400
13401 * eval.c (internal_lisp_condition_case): Include the handler
13402 representation in the error message.
13403 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13404 when breaking from the loop.
13405
13406 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13407
13408 * callint.c (Fcall_interactively): When displaying error message
13409 about invalid control letter, pass the character's codepoint, not
13410 a pointer to its multibyte form. Improve display of the character
13411 in octal and display also its hex code.
13412
13413 * character.c (char_string): Use %x to display the (unsigned)
13414 codepoint of an invalid character, to avoid displaying a bogus
13415 negative value.
13416
13417 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13418 `error', not SYMBOL_NAME itself.
13419
13420 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13421 character arguments to `error'.
13422
13423 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13424 to `error' in error message about FINAL_CHAR argument. Make sure
13425 FINAL_CHAR is a character, and use %c when it is passed as
13426 argument to `error'.
13427
4ffd0d6b 134282011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13429
13430 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13431
13432 * w32.c: Include <time.h>.
13433 (sys_localtime): New function.
13434
4ffd0d6b 134352011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13436
13437 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13438
4ffd0d6b 13439 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13440
4ffd0d6b 134412011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13442
4ffd0d6b
GM
13443 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13444 zombies (Bug#8467).
aac0c6e3 13445
04c56954
EZ
134462011-04-19 Eli Zaretskii <eliz@gnu.org>
13447
13448 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13449 gl_state.e_property when gl_state.object is Qt.
13450
13451 * insdel.c (make_gap_larger): Remove limitation of buffer size
13452 to <= INT_MAX.
13453
16a43933
CY
134542011-04-18 Chong Yidong <cyd@stupidchicken.com>
13455
13456 * xdisp.c (lookup_glyphless_char_display)
13457 (produce_glyphless_glyph): Handle cons cell entry in
13458 glyphless-char-display.
13459 (Vglyphless_char_display): Document it.
13460
13461 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13462 glyphless-char-display.
13463
4581706e
CY
134642011-04-17 Chong Yidong <cyd@stupidchicken.com>
13465
13466 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13467
13468 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13469
13470 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13471 definition for no-X builds.
13472
4887c6e2 134732011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13474
fd35b6f9
PE
13475 Static checks with GCC 4.6.0 and non-default toolkits.
13476
5c1ccb01
PE
13477 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13478
006c5daa
PE
13479 * process.c (keyboard_bit_set): Define only if SIGIO.
13480 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13481 (send_process): Repair possible setjmp clobbering.
13482
efc736d3
PE
13483 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13484
4e2fe2e6
PE
13485 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13486
f97334a2
PE
13487 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13488
4e75f29d
PE
13489 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13490 Define only if needed.
13491
90efadd1
PE
13492 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13493 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13494 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13495
3c647824
PE
13496 * dispextern.h (struct redisplay_interface): Rename param
13497 to avoid shadowing.
e264f262 13498 * termhooks.h (struct terminal): Likewise.
761383f4 13499 * xterm.c (xembed_send_message): Likewise.
3c647824 13500
b58c5c4a
PE
13501 * insdel.c (make_gap_smaller): Define only if
13502 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13503
cad59032
PE
13504 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13505 it.
13506
c339dc2e
PE
13507 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13508 so that we aren't warned about unused symbols.
13509
91a3e27b
PE
13510 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13511
399c71d3 13512 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13513
8ffc96f5
PE
13514 * xfns.c (x_real_positions): Mark locals as initialized.
13515
eef9bc79
PE
13516 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13517
098db9dd
PE
13518 * xterm.c: Fix problems found by static analysis with other toolkits.
13519 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13520 (x_dispatch_event): Declare static if USE_GTK, and
13521 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13522 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13523 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13524 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13525 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13526
eb18f6cc
PE
13527 * xmenu.c (menu_help_callback): Pointer type fixes.
13528 Use const pointers when pointing at readonly data. Avoid pointer
13529 signedness clashes.
13530 (FALSE): Remove unused macro.
13531 (update_frame_menubar): Remove unused decl.
13532
1fe72bf8
PE
13533 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13534
60d9e1db
PE
13535 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13536 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13537 (single_menu_item): Rename local to avoid shadowing.
13538
39261c26
PE
13539 * keyboard.c (make_lispy_event): Remove unused local var.
13540
018c5e19
PE
13541 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13542 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13543
63d2b86e
PE
13544 * bitmaps: Change bitmaps from unsigned char back to the X11
13545 compatible char. Avoid the old compiler warnings about
13546 out-of-range initializers by using, for example, '\xab' rather
13547 than 0xab.
13548
aefd87e1
PE
13549 * xgselect.c (xgselect_initialize): Check vs interface
13550 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13551
bf501fb9
PE
13552 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13553
e9829fdf
PE
13554 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13555 to read-only memory.
13556
1086c095
PE
13557 * fns.c (vector): Remove; this old hack is no longer needed.
13558
2baccd04 13559 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13560 Remove unused var.
dde42981 13561 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13562
72391843 13563 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13564
436c16df 13565 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13566 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13567 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13568
92bb796d 13569 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13570 (x_term_init): Remove local to avoid shadowing.
92bb796d 13571
764430a3 13572 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13573
13574 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13575 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13576
d1dfb56c
EZ
135772011-04-16 Eli Zaretskii <eliz@gnu.org>
13578
c4354cb4
EZ
13579 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13580
d1dfb56c
EZ
13581 Fix regex.c, syntax.c and friends for buffers > 2GB.
13582 * syntax.h (struct gl_state_s): Declare character position members
13583 EMACS_INT.
13584
13585 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13586
04f2d78b
CB
13587 * textprop.c (verify_interval_modification, interval_of):
13588 Declare arguments EMACS_INT.
d1dfb56c
EZ
13589
13590 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13591 EMACS_INT.
13592
13593 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13594
13595 * indent.c (Fvertical_motion): Local variable it_start is now
13596 EMACS_INT.
13597
13598 * regex.c (re_match, re_match_2, re_match_2_internal)
13599 (bcmp_translate, regcomp, regexec, print_double_string)
13600 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13601 (re_compile_pattern, re_exec): Declare arguments and local
13602 variables `size_t' and `ssize_t' and return values `regoff_t', as
13603 appropriate.
13604 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13605 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13606 <compile_stack_type>: `size' and `avail' are now `size_t'.
13607
13608 * regex.h <regoff_t>: Use ssize_t, not int.
13609 (re_search, re_search_2, re_match, re_match_2): Arguments that
13610 specify buffer/string position and length are now ssize_t and
13611 size_t. Return type is regoff_t.
13612
613052cd
BK
136132011-04-16 Ben Key <bkey76@gmail.com>
13614
13615 * nsfont.m: Fixed bugs in ns_get_family and
13616 ns_descriptor_to_entity that were caused by using free to
13617 deallocate memory blocks that were allocated by xmalloc (via
13618 xstrdup). This caused Emacs to crash when compiled with
13619 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13620 --enable-checking=xmallocoverrun). xfree is now used to
13621 deallocate these memory blocks.
13622
4170f62f 136232011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13624
71b41406
PE
13625 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13626
9587a89d
PE
13627 emacs_write: Accept and return EMACS_INT for sizes.
13628 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13629 et seq.
13630 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13631 Accept and return EMACS_INT.
13632 (emacs_gnutls_write): Return the number of bytes written on
13633 partial writes.
13634 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13635 (emacs_read, emacs_write): Remove check for negative size, as the
13636 Emacs source code has been audited now.
9587a89d
PE
13637 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13638 (emacs_read, emacs_write): Use it.
273a5f82
PE
13639 * process.c (send_process): Adjust to the new signatures of
13640 emacs_write and emacs_gnutls_write. Do not attempt to store
13641 a byte offset into an 'int'; it might overflow.
9587a89d 13642 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13643
3e047f51
PE
13644 * sound.c: Don't assume sizes fit in 'int'.
13645 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13646 Return EMACS_INT, not int.
3e047f51 13647 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13648 Accept EMACS_INT, not int.
13649 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13650 record read return values.
13651
cc39a9db
BK
136522011-04-15 Ben Key <bkey76@gmail.com>
13653
c9d0ec6d
JB
13654 * keyboard.c (Qundefined): Don't declare static since it is used
13655 in nsfns.m.
13656 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13657 static since they are used in nsfont.m.
cc39a9db 13658
6c60eb9f
SM
136592011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13660
13661 * process.c (Qprocessp): Don't declare static.
13662 * lisp.h (Qprocessp): Declare again.
13663
7990b61a
JB
136642011-04-15 Juanma Barranquero <lekktu@gmail.com>
13665
13666 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13667
5d4cb038
PE
136682011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13669
8bd7b830 13670 Improve C-level modularity by making more things 'static'.
cd64ea1d 13671
e3b27b31
PE
13672 Don't publish debugger-only interfaces to other modules.
13673 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13674 (verify_bytepos, count_markers): Move decls to the only modules
13675 that need them.
13676 * region-cache.h (pp_cache): Likewise.
13677 * window.h (check_all_windows): Likewise.
13678 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13679
5d4cb038
PE
13680 * sysdep.c (croak): Now static, if
13681 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13682 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13683
13684 * alloc.c (refill_memory_reserve): Now static if
13685 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13686 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13687
e87b6180
PE
13688 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13689 Define only if USE_LUCID.
13690
ac64929e
PE
13691 * xrdb.c (x_customization_string, x_rm_string): Now static.
13692
6f37259d
PE
13693 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13694 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13695
1683e3ab
PE
13696 * xdisp.c (draw_row_with_mouse_face): Now static.
13697 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13698
de9c2632
PE
13699 * window.h (check_all_windows): Mark externally visible.
13700
2b96acb7
PE
13701 * window.c (window_deletion_count): Now static.
13702
13703 * undo.c: Make symbols static if they're not exported.
13704 (last_undo_buffer, last_boundary_position, pending_boundary):
13705 Now static.
13706
50436f33
PE
13707 * textprop.c (interval_insert_behind_hooks): Now static.
13708 (interval_insert_in_front_hooks): Likewise.
13709
64520e5c
PE
13710 * term.c: Make symbols static if they're not exported.
13711 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13712 (max_frame_lines, tty_set_terminal_modes):
13713 (tty_reset_terminal_modes, tty_turn_off_highlight):
13714 (get_tty_terminal): Now static.
13715 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13716 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13717 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13718 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13719 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13720
1fa53021
PE
13721 * sysdep.c: Make symbols static if they're not exported.
13722 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13723 Now static.
13724 (sigprocmask_set, full_mask): Remove; unused.
13725 (wait_debugging): Mark as visible.
13726 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13727 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13728
d4b43b22
PE
13729 * syntax.c (syntax_temp): Define only if !__GNUC__.
13730
b7c513d0
PE
13731 * sound.c (current_sound_device, current_sound): Now static.
13732
989b29ad
PE
13733 * search.c (searchbufs, searchbuf_head): Now static.
13734
13a55a78
PE
13735 * scroll.c (scroll_cost): Remove; unused.
13736 * dispextern.h (scroll_cost): Remove decl.
13737
de68a1fc
PE
13738 * region-cache.h (pp_cache): Mark as externally visible.
13739
40ccffa6
PE
13740 * process.c: Make symbols static if they're not exported.
13741 (process_tick, update_tick, create_process, chan_process):
13742 (Vprocess_alist, proc_buffered_char, datagram_access):
13743 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13744 (deactivate_process): Mark defn as static, as well as decl.
13745 * lisp.h (create_process): Remove decl.
13746 * process.h (chan_process, Vprocess_alist): Remove decls.
13747
ad64fc97
PE
13748 * print.c: Make symbols static if they're not exported.
13749 (print_depth, new_backquote_output, being_printed, print_buffer):
13750 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13751 (print_interval, print_number_index, initial_stderr_stream):
13752 Now static.
13753 * lisp.h (Fprinc): Remove decl.
13754 (debug_output_compilation_hack): Mark as externally visible.
13755
adddb265
PE
13756 * sysdep.c (croak): Move decl from here to syssignal.h.
13757 * syssignal.h (croak): Put it here, so the API can be checked when
13758 'croak' is called from dissociate_if_controlling_tty.
13759
1717ede2
PE
13760 * minibuf.c: Make symbols static if they're not exported.
13761 (minibuf_save_list, choose_minibuf_frame): Now static.
13762 * lisp.h (choose_minibuf_frame): Remove decl.
13763
fa5fb2bc
PE
13764 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13765
1e3890d1
PE
13766 * lread.c: Make symbols static if they're not exported.
13767 (read_objects, initial_obarray, oblookup_last_bucket_number):
13768 Now static.
13769 (make_symbol): Remove; unused.
13770 * lisp.h (initial_obarray, make_symbol): Remove decls.
13771
8a1414fa
PE
13772 * keyboard.c: Make symbols static if they're not exported.
13773 (single_kboard, recent_keys_index, total_keys, recent_keys):
13774 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13775 (this_single_command_key_start, echoing, last_auto_save):
13776 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13777 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13778 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13779 (Vlispy_mouse_stem, double_click_count):
13780 Now static.
13781 (force_auto_save_soon): Define only if SIGDANGER.
13782 (ignore_mouse_drag_p): Now static if
13783 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13784 (print_help): Remove; unused.
13785 (stop_character, last_timer_event): Mark as externally visible.
13786 * keyboard.h (ignore_mouse_drag_p): Declare only if
13787 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13788 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13789 * lisp.h (echoing): Remove decl.
13790 (force_auto_save_soon): Declare only if SIGDANGER.
13791 * xdisp.c (redisplay_window): Simplify code, to make it more
13792 obvious that ignore_mouse_drag_p is not accessed if !defined
13793 USE_GTK && !defined HAVE_NS.
13794
93ea6e8f
PE
13795 * intervals.c: Make symbols static if they're not exported.
13796 (merge_properties_sticky, merge_interval_right, delete_interval):
13797 Now static.
13798 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13799
77382fcc
PE
13800 * insdel.c: Make symbols static if they're not exported.
13801 However, leave prepare_to_modify_buffer alone. It's never
13802 called from outside this function, but that appears to be a bug.
13803 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13804 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13805 (adjust_after_replace_noundo): Remove; unused.
13806 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13807 (signal_before_change): Remove decls.
77382fcc 13808
9306c32e
PE
13809 * indent.c (val_compute_motion, val_vmotion): Now static.
13810
cd44d2eb
PE
13811 * image.c: Make symbols static if they're not exported.
13812 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13813 if USE_GTK.
13814 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13815 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13816
ad9a7a06
PE
13817 * fringe.c (standard_bitmaps): Now static.
13818 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13819
81626931
PE
13820 * frame.c: Make symbols static if they're not exported.
13821 (x_report_frame_params, make_terminal_frame): Now static.
13822 (get_frame_param): Now static, unless HAVE_NS.
13823 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13824 (x_get_resource_string): Remove; not used.
13825 * frame.h (make_terminal_frame, x_report_frame_params):
13826 (x_get_resource_string); Remove decls.
13827 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13828 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13829
239f9db9
PE
13830 * font.c, fontset.c: Make symbols static if they're not exported.
13831 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13832 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13833 * font.c (font_close_object): Now static.
13834 * font.h (font_close_object): Remove.
13835 * fontset.c (FONTSET_OBJLIST): Remove.
13836 (free_realized_fontset) #if-0 the body, which does nothing.
13837 (face_suitable_for_char_p): #if-0, as it's never called.
13838 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13839 * xfaces.c (face_at_string_position):
13840 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13841 since 0 is always ASCII.
13842
dfcf3579
PE
13843 * fns.c (weak_hash_tables): Now static.
13844
5045092b
PE
13845 * fileio.c: Make symbols static if they're not exported.
13846 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13847 (Vwrite_region_annotation_buffers): Now static.
13848
57a96f5c
PE
13849 * eval.c: Make symbols static if they're not exported.
13850 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13851 * lisp.h (backtrace_list): Remove decl.
13852
35f08c38
PE
13853 * emacs.c: Make symbols static if they're not exported.
13854 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13855 (fatal_error_code, fatal_error_signal_hook, standard_args):
13856 Now static.
13857 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13858 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13859 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13860 * lisp.h (fatal_error_signal_hook): Remove decl.
13861 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13862
f44bd759
PE
13863 * editfns.c: Move a (normally-unused) function to its only use.
13864 * editfns.c, lisp.h (get_operating_system_release): Remove.
13865 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13866 worth the hassle of breaking this out.
13867
b532497d
PE
13868 * xterm.c: Make symbols static if they're not exported.
13869 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13870 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13871 (x_destroy_window, x_delete_display):
13872 Now static.
13873 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13874 (x_mouse_leave): Remove; unused.
13875 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13876 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13877 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13878 Remove decls.
13879 (x_mouse_leave): Declare only if WINDOWSNT.
13880 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13881 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13882 USE_X_TOOLKIT.
13883
1675728f
PE
13884 * ftxfont.c: Make symbols static if they're not exported.
13885 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13886 HAVE_FREETYPE.
13887 * font.h (ftxfont_driver): Likewise.
13888
e4cebfca
PE
13889 * xfns.c: Make symbols static if they're not exported.
13890 (x_last_font_name, x_display_info_for_name):
13891 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13892 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13893 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13894 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13895 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13896 (last_show_tip_args): Now static.
13897 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13898 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13899 (x_screen_planes): Remove; unused.
13900 * dispextern.h (x_screen_planes): Remove decl.
13901
5bf46f05
PE
13902 * dispnew.c: Make symbols static if they're not exported.
13903 * dispextern.h (redraw_garbaged_frames, scrolling):
13904 (increment_row_positions): Remove.
13905 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13906 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13907 Now static.
13908 (redraw_garbaged_frames): Remove; unused.
13909
435f4c28
PE
13910 * xfaces.c: Make symbols static if they're not exported.
13911 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13912 Remove decls.
13913 * xterm.h (defined_color): Remove decls.
13914 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13915 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13916 (menu_face_changed_default, defined_color, free_realized_face):
13917 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13918 (ascii_face_of_lisp_face): Remove; unused.
13919
8524aef3
PE
13920 * xdisp.c: Make symbols static if they're not exported.
13921 * dispextern.h (scratch_glyph_row, window_box_edges):
13922 (glyph_to_pixel_coords, set_cursor_from_row):
13923 (get_next_display_element, set_iterator_to_next):
13924 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13925 (show_mouse_face): Remove decls
13926 * frame.h (message_buf_print): Likewise.
13927 * lisp.h (pop_message, set_message, check_point_in_composition):
13928 Likewise.
13929 * xterm.h (set_vertical_scroll_bar): Likewise.
13930 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13931 (message_buf_print, scratch_glyph_row, displayed_buffer):
13932 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13933 (get_next_display_element, show_mouse_face, window_box_edges):
13934 (frame_to_window_pixel_xy, check_point_in_composition):
13935 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13936 (glyph_to_pixel_coords): Remove; unused.
13937
16390cd2
PE
13938 * dired.c (file_name_completion): Now static.
13939
13940 * dbusbind.c (xd_in_read_queued_messages): Now static.
13941
a25f4dfa
PE
13942 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13943 * data.c (circular_list_error): Remove.
13944
14a9c8df
PE
13945 * commands.h (last_point_position, last_point_position_buffer):
13946 (last_point_position_window): Remove decls.
13947 * keyboard.c: Make these variables static.
13948
04f2d78b
CB
13949 * coding.h (coding, code_convert_region, encode_coding_gap):
13950 Remove decls.
74ab6df5
PE
13951 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13952 (iso_code_class, detect_coding, code_convert_region): Now static.
13953 (encode_coding_gap): Remove; unused.
13954
38dfbee1
PE
13955 * chartab.c (chartab_chars, chartab_bits): Now static.
13956
a2cb4e63
PE
13957 * charset.h (charset_iso_8859_1): Remove decl.
13958 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13959 Now static.
13960
127198fd
PE
13961 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13962 * ccl.c (Vccl_program_table): Now static.
13963 (check_ccl_update): Remove; unused.
13964
d85b608f
PE
13965 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13966 * category.h: ... from here.
13967 * category.c (check_category_table, set_category_set): Now static.
13968
31cd66f3
PE
13969 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13970 * lisp.h: Remove these decls.
13971
c358e587
PE
13972 * buffer.c (buffer_count): Remove unused var.
13973
e78aecca
PE
13974 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13975 so that it's not optimized away.
13976 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13977 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13978 exported only to the debugger.
13979
e192d7d3 13980 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13981 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13982
92470028
PE
13983 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13984 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13985 was inaccessible from Lisp.
13986 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13987 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13988
244ed907
PE
13989 alloc.c: Import and export fewer symbols, and remove unused items.
13990 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13991 is defined.
13992 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13993 it's not optimized away by whole-program optimization.
13994 (message_enable_multibyte, free_misc): Remove.
13995 (catchlist, handlerlist, mark_backtrace):
13996 Declare only if BYTE_MARK_STACK.
13997 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13998 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13999 (message_enable_multibyte): Remove decl.
14000 (free_misc, interval_free_list, float_block, float_block_index):
14001 (n_float_blocks, float_free_list, cons_block, cons_block_index):
14002 (cons_free_list, last_marked_index):
14003 Now static.
14004 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
14005 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
14006 (mark_backtrace): Define only if BYTE_MARK_STACK.
14007 * xdisp.c (message_enable_multibyte): Now static.
14008
61c2b50e 14009 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
14010 This makes it easier for human readers (and static analyzers)
14011 to see whether these variables are used from other modules.
14012 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
14013 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
14014 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
14015 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
14016 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
14017 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
14018 * xmenu.c, xselect.c:
14019 Declare Q* vars static if they are not used in other modules.
14020 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
14021 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
14022 Remove decls of unexported vars.
14023 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
14024
95c82688
PE
14025 * lisp.h (DEFINE_FUNC): Make sname 'static'.
14026
16a97296
PE
14027 Make Emacs functions such as Fatom 'static' by default.
14028 This makes it easier for human readers (and static analyzers)
14029 to see whether these functions can be called from other modules.
14030 DEFUN now defines a static function. To make the function external
14031 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
14032 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
14033 (Finit_image_library):
16a97296
PE
14034 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
14035 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
14036 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
14037 Remove decls, since these functions are now static.
14038 (Funintern, Fget_internal_run_time): New decls, since these functions
14039 were already external.
95c82688 14040
16a97296
PE
14041 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
14042 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
14043 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
14044 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
14045 * keyboard.c, keymap.c, lread.c:
14046 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
14047 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
14048 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
14049 Mark functions with DEFUE instead of DEFUN,
14050 if they are used in other modules.
14051 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
14052 decls for now-static functions.
14053 * buffer.h (Fdelete_overlay): Remove decl.
14054 * callproc.c (Fgetenv_internal): Mark as internal.
14055 * composite.c (Fremove_list_of_text_properties): Remove decl.
14056 (Fcomposition_get_gstring): New forward static decl.
14057 * composite.h (Fcomposite_get_gstring): Remove decl.
14058 * dired.c (Ffile_attributes): New forward static decl.
14059 * doc.c (Fdocumntation_property): New forward static decl.
14060 * eval.c (Ffetch_bytecode): New forward static decl.
14061 (Funintern): Remove extern decl; now in .h file where it belongs.
14062 * fileio.c (Fmake_symbolic_link): New forward static decl.
14063 * image.c (Finit_image_library): New forward static decl.
14064 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
14065 * intervals.h (Fprevious_property_change):
14066 (Fremove_list_of_text_properties): Remove decls.
14067 * keyboard.c (Fthis_command_keys): Remove decl.
14068 (Fcommand_execute): New forward static decl.
14069 * keymap.c (Flookup_key): New forward static decl.
14070 (Fcopy_keymap): Now static.
14071 * keymap.h (Flookup_key): Remove decl.
14072 * process.c (Fget_process): New forward static decl.
14073 (Fprocess_datagram_address): Mark as internal.
14074 * syntax.c (Fsyntax_table_p): New forward static decl.
14075 (skip_chars): Remove duplicate decl.
14076 * textprop.c (Fprevious_property_change): New forward static decl.
14077 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
14078 Now internal.
14079 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
14080 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
14081
785bbd42
PE
14082 * editfns.c (Fformat): Remove unreachable code.
14083
8b913b57
AS
140842011-04-14 Andreas Schwab <schwab@linux-m68k.org>
14085
14086 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
14087 change. (Bug#8496)
14088
a6744a35
EZ
140892011-04-13 Eli Zaretskii <eliz@gnu.org>
14090
14091 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
14092 when at ZV. (Bug#8487)
14093
e7974947
AS
140942011-04-12 Andreas Schwab <schwab@linux-m68k.org>
14095
baad03f0
AS
14096 * charset.c (Fclear_charset_maps): Use xfree instead of free.
14097 (Bug#8437)
14098 * keyboard.c (parse_tool_bar_item): Likewise.
14099 * sound.c (sound_cleanup, alsa_close): Likewise.
14100 * termcap.c (tgetent): Likewise.
14101 * xfns.c (x_default_font_parameter): Likewise.
14102 * xsettings.c (read_and_apply_settings): Likewise.
14103
e7974947
AS
14104 * alloc.c (overrun_check_malloc, overrun_check_realloc)
14105 (overrun_check_free): Protoize.
14106
28272684
PE
141072011-04-12 Paul Eggert <eggert@cs.ucla.edu>
14108
14109 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
14110 since callers should never pass a negative size.
14111 Change the signature to match that of plain 'read' and 'write'; see
14112 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
14113 * lisp.h: Update prototypes of emacs_write and emacs_read.
14114
11997c76
EZ
141152011-04-11 Eli Zaretskii <eliz@gnu.org>
14116
14117 * xdisp.c (redisplay_window): Don't try to determine the character
14118 position of the scroll margin if the window start point w->startp
e896f03c 14119 is outside the buffer's accessible region. (Bug#8468)
11997c76 14120
8a2cbd72
EZ
141212011-04-10 Eli Zaretskii <eliz@gnu.org>
14122
14123 Fix write-region and its subroutines for buffers > 2GB.
14124 * fileio.c (a_write, e_write): Modify declaration of arguments and
14125 local variables to support buffers larger than 2GB.
14126 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
14127
14128 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
14129 argument, local variables, and return value.
14130
14131 * lisp.h: Update prototypes of emacs_write and emacs_read.
14132
14133 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
14134
4073e537 141352011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 14136
1ebfdcb6
PE
14137 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
14138
b2ded58d
PE
14139 Fix more problems found by GCC 4.6.0's static checks.
14140
7d66342c
PE
14141 * xdisp.c (vmessage): Use a better test for character truncation.
14142
bbf47d44
PE
14143 * charset.c (load_charset_map): <, not <=, for optimization,
14144 and to avoid potential problems with integer overflow.
9248994d 14145 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 14146 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 14147 * editfns.c (Fformat): Likewise.
1e69125e 14148 * syntax.c (skip_chars): Likewise.
3befa583 14149
e3019616
PE
14150 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
14151 This also lets GCC 4.6.0 generate slightly better loop code.
14152
becfa255
PE
14153 * callint.c (Fcall_interactively): <, not <=, for optimization.
14154 (Fcall_interactively): Count the number of arguments produced,
14155 not the number of arguments given. This is simpler and lets GCC
14156 4.6.0 generate slightly better code.
14157
dae0cd48
PE
14158 * ftfont.c: Distingish more carefully between FcChar8 and char.
14159 The previous code passed unsigned char * to a functions like
14160 strlen and xstrcasecmp that expect char *, which does not
14161 conform to the C standard.
14162 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
14163 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
14164 char * when the C standard requires it.
14165
76032d70
PE
14166 * keyboard.c (read_char): Remove unused var.
14167
eb3f1cc8
PE
14168 * eval.c: Port to Windows vsnprintf (Bug#8435).
14169 Include <limits.h>.
14170 (SIZE_MAX): Define if the headers do not.
14171 (verror): Do not give up if vsnprintf returns a negative count.
14172 Instead, grow the buffer. This ports to Windows vsnprintf, which
14173 does not conform to C99. Problem reported by Eli Zaretskii.
14174 Also, simplify the allocation scheme, by avoiding the need for
14175 calling realloc, and removing the ALLOCATED variable.
14176
70476b54
PE
14177 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
14178
12020a9e
PE
14179 Remove invocations of doprnt, as Emacs now uses vsnprintf.
14180 But keep the doprint source code for now, as we might revamp it
14181 and use it again (Bug#8435).
ea6c7ae6
PE
14182 * lisp.h (doprnt): Remove.
14183 * Makefile.in (base_obj): Remove doprnt.o.
14184 * deps.mk (doprnt.o): Remove.
14185
5fdb398c
PE
14186 error: Print 32- and 64-bit integers portably (Bug#8435).
14187 Without this change, on typical 64-bit hosts error ("...%d...", N)
14188 was used to print both 32- and 64-bit integers N, which relied on
14189 undefined behavior.
61bdb816 14190 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
14191 * lisp.h (error, verror): Mark as printf-like functions.
14192 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
14193 Report overflow in size calculations when allocating printf buffer.
14194 Do not truncate output string at its first null byte.
14195 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
14196 Truncate the output at a character boundary, since vsnprintf does not
14197 do that.
14198 * charset.c (check_iso_charset_parameter): Convert internal
14199 character to string before calling 'error', since %c now has the
14200 printf meaning.
14201 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
14202 overflow when computing char to be passed to 'error'. Do not
14203 pass Lisp_Object to 'error'; pass the integer instead.
14204 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
14205 formatted with plain %d.
14206
b189fa66
PE
14207 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
14208
bff87ef0
PE
14209 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
14210
7e2cac20
PE
14211 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
14212
ce4d90b5
PE
14213 * xterm.c (x_catch_errors): Remove duplicate declaration.
14214
266c9547
PE
14215 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
14216
79c49ad2
PE
14217 * xdisp.c, lisp.h (message_nolog): Remove; unused.
14218
368f4090
JM
142192011-04-10 Jim Meyering <meyering@redhat.com>
14220
14221 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
14222 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
14223 return ssize_t not "int", and use size_t as the buffer length.
14224 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
14225 * gnutls.h: Update declarations.
14226 * process.c (read_process_output): Use ssize_t, to match.
14227 (send_process): Likewise.
14228
a32d4040
CY
142292011-04-09 Chong Yidong <cyd@stupidchicken.com>
14230
14231 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
14232
8546720e 142332011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 14234
04f2d78b
CB
14235 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
14236 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 14237
8546720e
GM
14238 * xterm.c (handle_one_xevent):
14239 * xmenu.c (create_and_show_popup_menu):
14240 * xselect.c (x_decline_selection_request)
14241 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 14242
0a2f5c1a 142432011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
14244
14245 Fix some uses of `int' instead of EMACS_INT.
14246 * search.c (string_match_1, fast_string_match)
14247 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
14248 (scan_buffer, find_next_newline_no_quit)
14249 (find_before_next_newline, search_command, Freplace_match)
14250 (Fmatch_data): Make some `int' variables be EMACS_INT.
14251
14252 * xdisp.c (display_count_lines): 3rd argument and return value now
14253 EMACS_INT. All callers changed.
14254 (pint2hrstr): Last argument is now EMACS_INT.
14255
14256 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
14257 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
14258 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
14259 (decode_coding_utf_16, decode_coding_emacs_mule)
14260 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
14261 (decode_coding_ccl, decode_coding_charset)
14262 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
14263 (decode_coding_iso_2022, decode_coding_emacs_mule)
14264 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
14265 <char_offset, last_offset>: Declare EMACS_INT.
14266 (encode_coding_utf_8, encode_coding_utf_16)
14267 (encode_coding_emacs_mule, encode_invocation_designation)
14268 (encode_designation_at_bol, encode_coding_iso_2022)
14269 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
14270 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
14271 Declare EMACS_INT.
14272 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
14273 (encode_invocation_designation): Last argument P_NCHARS is now
14274 EMACS_INT.
14275 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
14276 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
14277
14278 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
14279 All users changed.
14280
14281 * ccl.c (Fccl_execute_on_string): Declare some variables
14282 EMACS_INT.
14283
8546720e 142842011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
14285
14286 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
14287
4e19a977
CS
142882011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
14289
14290 * process.c (Fformat_network_address): Doc fix.
14291
87302331
R
142922011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
14293
ee7683eb 14294 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 14295
cbb59342
CY
142962011-04-08 Chong Yidong <cyd@stupidchicken.com>
14297
14298 * keyboard.c (read_char): Call Lisp function help-form-show,
14299 instead of using internal_with_output_to_temp_buffer.
14300 (Qhelp_form_show): New var.
e0d38eeb 14301 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
14302
14303 * print.c (internal_with_output_to_temp_buffer): Function deleted.
14304
14305 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
14306
e67a13ab
CY
143072011-04-06 Chong Yidong <cyd@stupidchicken.com>
14308
04f2d78b
CB
14309 * process.c (Flist_processes): Remove to Lisp.
14310 (list_processes_1): Delete.
e67a13ab 14311
973f782d
EZ
143122011-04-06 Eli Zaretskii <eliz@gnu.org>
14313
7c106b1e
EZ
14314 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
14315
973f782d
EZ
14316 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
14317
41cf7d1a 143182011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 14319
ca23cc88
PE
14320 Fix more problems found by GCC 4.6.0's static checks.
14321
f390e2d5
PE
14322 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
14323
42eea0d0
PE
14324 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
14325
b69769da 14326 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 14327
f9541e84
PE
14328 * xdisp.c (vmessage): Mark as a printf-like function.
14329
13841b55
PE
14330 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
14331
c136c10f
PE
14332 * sound.c (sound_warning): Don't crash if arg contains a printf format.
14333
5e2d4a30
PE
14334 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
14335 printf-like functions.
14336 (tiff_load): Add casts to remove these marks before passing them
14337 to system-supplied API.
14338
583f48b9
PE
14339 * eval.c (Fsignal): Remove excess argument to 'fatal'.
14340
b25d760e
PE
14341 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
14342 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
14343 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
14344 directly, rather than having caller test rule sign. This avoids
14345 some unnecessary tests.
14346 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
14347 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
14348 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 14349
bc7b6697 14350 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 14351 (xfont_open): Avoid unnecessary tests.
bc7b6697 14352
27ccc379
PE
14353 * composite.c (composition_gstring_put_cache): Use unsigned integer.
14354
dcd5c89a
PE
14355 * composite.h, composite.c (composition_gstring_put_cache):
14356 Use EMACS_INT, not int, for length.
14357
b13a45c6
PE
14358 * composite.h (COMPOSITION_DECODE_REFS): New macro,
14359 breaking out part of COMPOSITION_DECODE_RULE.
14360 (COMPOSITION_DECODE_RULE): Use it.
14361 * composite.c (get_composition_id): Remove unused local vars,
14362 by using the new macro.
14363
1e792e4d
PE
14364 * textprop.c (set_text_properties_1): Change while to do-while,
14365 since the condition is always true at first.
14366
dc6c6455 14367 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
14368 (interval_deletion_adjustment): Return unsigned value.
14369 All uses changed.
dc6c6455 14370
aba7731a
PE
14371 * process.c (list_processes_1, create_pty, read_process_output):
14372 (exec_sentinel): Remove vars that were set but not used.
afd4052b 14373 (create_pty): Remove unnecessary "volatile"s.
bc57d757 14374 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 14375 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 14376 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 14377
fdfc4bf3
PE
14378 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
14379
fca8fe46 14380 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 14381 (update_syntax_table): Use unsigned instead of int.
fca8fe46 14382
06a0259a 14383 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 14384 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 14385 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 14386
e7b9e80f
PE
14387 * print.c (print_error_message): Avoid int overflow.
14388
56201685
PE
14389 * font.c (font_list_entities): Redo for clarity,
14390 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
14391
78834453 14392 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 14393 (font_score): Avoid potential overflow in diff calculation.
78834453 14394
0bc0b309 14395 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 14396 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 14397
e610eaca
PE
14398 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14399
b895abce
PE
14400 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14401 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14402 can always succeed if overflow has undefined behavior.
14403
1f1d9321 14404 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14405 (wordify): Omit three unnecessary tests.
1f1d9321 14406
c59478bc
PE
14407 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14408 All callers changed. This avoids the need for an unused var.
14409
79b73827
PE
14410 * casefiddle.c (casify_region): Remove var that is set but not used.
14411
a4db5dfe
PE
14412 * dired.c (file_name_completion): Remove var that is set but not used.
14413
43aae36e
PE
14414 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14415
2a47c44d 14416 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14417 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14418
a37c69bf
PE
14419 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14420 Check for integer overflow on size calculations.
14421
328ab8e7
PE
14422 * buffer.c (Fprevious_overlay_change): Remove var that is set
14423 but not used.
14424
e5a2a5cb
PE
14425 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14426 Remove vars that are set but not used.
8d84a6eb 14427 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14428 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14429
a60e5f68
PE
14430 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14431
f661cb61 14432 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14433 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14434
f0397f5a
PE
14435 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14436 that are set but not used.
14437
8664db06 14438 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14439 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14440
6abdaa4a
PE
14441 * xselect.c (x_get_local_selection, x_handle_property_notify):
14442 Remove vars that are set but not used.
14443
0ce7538d 14444 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14445 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14446
9ae848fc
PE
14447 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14448 Remove var that is set but not used.
0b918413
PE
14449 (scroll_bar_windows_size): Now size_t, not int.
14450 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14451 Check for overflow.
9ae848fc 14452
a5a62657
PE
14453 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14454 (map_tty_color) [!defined MSDOS]: Likewise.
14455
5c5cdd39
PE
14456 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14457
66ebf983
PE
14458 * coding.c: Remove vars that are set but not used.
14459 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14460 All callers changed.
14461 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14462 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14463 (decode_coding_charset): Remove vars that are set but not used.
14464
1be4d761
PE
14465 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14466 that is set but not used.
14467
47553fa8
PE
14468 * print.c (print_object): Remove var that is set but not used.
14469
1f7196bf 14470 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14471 The gnulib version avoids calling malloc in the usual case,
14472 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14473 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14474 * filelock.c (current_lock_owner): Likewise.
14475 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14476 * sysdep.c: Include allocator.h, careadlinkat.h.
14477 (emacs_no_realloc_allocator): New static constant.
14478 (emacs_readlink): New function.
fdb61804
PE
14479 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14480 ../lib/careadlinkat.h.
d1fdcab7 14481
f84c17c7
SM
144822011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14483
14484 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14485 first non-nil return value).
14486
ef3862ad
JD
144872011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14488
14489 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14490 if not defined (Bug#8403).
14491
376a7006
JB
144922011-04-02 Juanma Barranquero <lekktu@gmail.com>
14493
14494 * xdisp.c (display_count_lines): Remove parameter `start',
14495 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14496 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14497 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14498 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14499 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14500 and thereabouts. All callers changed.
14501 (get_per_char_metric): Remove parameter `f', unused since
14502 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14503
6ca3801d
JM
145042011-04-02 Jim Meyering <meyering@redhat.com>
14505
14506 do not dereference NULL upon failed strdup
14507 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14508 (ns_get_family): Likewise.
14509
d8e2b5ba
JB
145102011-04-02 Juanma Barranquero <lekktu@gmail.com>
14511
14512 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14513
8c74fcbd
JD
145142011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14515
14516 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14517 later (Bug#8403).
14518
7200d79c
SM
145192011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14520
03408648 14521 Add lexical binding.
7200d79c 14522
03408648
SM
14523 * window.c (Ftemp_output_buffer_show): New fun.
14524 (Fsave_window_excursion):
14525 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14526
14527 * lread.c (lisp_file_lexically_bound_p): New function.
14528 (Fload): Bind Qlexical_binding.
14529 (readevalloop): Remove `evalfun' arg.
14530 Bind Qinternal_interpreter_environment.
14531 (Feval_buffer): Bind Qlexical_binding.
14532 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14533 Mark as dynamic.
14534 (syms_of_lread): Declare `lexical-binding'.
14535
14536 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14537
14538 * keyboard.c (eval_dyn): New fun.
14539 (menu_item_eval_property): Use it.
ca105506
SM
14540
14541 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14542
03408648
SM
14543 * fns.c (concat, mapcar1): Accept byte-code-functions.
14544
14545 * eval.c (Fsetq): Handle lexical vars.
14546 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14547 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14548 (FletX, Flet): Obey lexical binding.
14549 (Fcommandp): Handle closures.
14550 (Feval): New `lexical' arg.
14551 (eval_sub): New function extracted from Feval. Use it almost
14552 everywhere where Feval was used. Look up vars in lexical env.
14553 Handle closures.
14554 (Ffunctionp): Move from subr.el.
14555 (Ffuncall): Handle closures.
14556 (apply_lambda): Remove `eval_flags'.
14557 (funcall_lambda): Handle closures and new byte-code-functions.
14558 (Fspecial_variable_p): New function.
14559 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14560 but without exporting it to Lisp.
23aba0ea 14561
23aba0ea 14562 * doc.c (Fdocumentation, store_function_docstring):
03408648 14563 * data.c (Finteractive_form): Handle closures.
23aba0ea 14564
03408648
SM
14565 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14566 interactive spec.
ba83908c 14567
04f2d78b
CB
14568 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14569 New byte-codes.
03408648
SM
14570 (exec_byte_code): New function extracted from Fbyte_code to handle new
14571 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14572
03408648 14573 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14574
03408648 14575 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14576
e2abce01
JB
145772011-03-31 Juanma Barranquero <lekktu@gmail.com>
14578
14579 * xdisp.c (redisplay_internal): Fix prototype.
14580
63696a73 145812011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14582
63696a73 14583 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14584 (try_scrolling): Use it when setting scroll_limit.
14585 Limit scrolling to 100 screen lines.
63696a73
EZ
14586 (redisplay_window): Even when falling back on "recentering",
14587 position point in the window according to scroll-conservatively,
14588 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14589
14590 (try_scrolling): When point is above the window, allow searching
14591 as far as scroll_max, or one screenful, to compute vertical
14592 distance from PT to the scroll margin position. This prevents
14593 try_scrolling from unnecessarily failing when
14594 scroll-conservatively is set to a value slightly larger than the
14595 window height. Clean up the case of PT below the margin at bottom
14596 of window: scroll_max can no longer be INT_MAX. When aggressive
14597 scrolling is in use, don't let point enter the opposite scroll
14598 margin as result of the scroll.
14599 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14600 threshold of 100 lines for never-recentering scrolling.
14601
e4cc2dfc
JB
146022011-03-31 Juanma Barranquero <lekktu@gmail.com>
14603
14604 * dispextern.h (move_it_by_lines):
14605 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14606 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14607 (message_log_check_duplicate): Remove parameters `prev_bol' and
14608 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14609 (redisplay_internal): Remove parameter `preserve_echo_area',
14610 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14611
14612 * indent.c (Fvertical_motion):
14613 * window.c (window_scroll_pixel_based, Frecenter):
14614 Don't pass `need_y_p' to `move_it_by_lines'.
14615
1c470562
SM
146162011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14617
44f230aa
SM
14618 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14619 steal a few bits to be more compact.
14620 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14621 Remove unneeded casts.
14622
1c470562
SM
14623 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14624
888adce9
ZK
146252011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14626
14627 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14628 binding" message (bug#7967).
14629
f838ed7b
PE
146302011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14631
77861b95
PE
14632 Fix more problems found by GCC 4.6.0's static checks.
14633
de6dbc14
PE
14634 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14635 Remove unused local var.
14636
f838ed7b
PE
14637 * editfns.c (Fmessage_box): Remove unused local var.
14638
792c7b2b
PE
14639 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14640 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14641 Omit unused local vars.
c499e557 14642 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14643 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14644 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14645 Omit unused local var.
14646
ba0165e1
PE
14647 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14648 Don't assume string length fits in int.
32ad8845 14649 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14650 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14651
3c59b4c9
PE
14652 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14653 instead of alloca (Bug#8344).
14654
a3eed478 14655 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14656 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14657
eb4d412d
PE
14658 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14659
1658b401
PE
14660 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14661 concerns.
14662
14663 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14664
14665 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14666
9a2c6e05
PE
14667 * keyboard.c (syms_of_keyboard): Use the same style as later
14668 in this function when indexing through an array. This also
14669 works around GCC bug 48267.
14670
03d0a109
PE
14671 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14672
44f730c8
PE
14673 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14674
fe75f926
PE
14675 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14676 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14677
ffa8c828
PE
14678 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14679 This avoids undefined behavior on integer overflow, and is a bit
14680 more convenient anyway since it is compared to a size_t variable.
14681
c5101a77
PE
14682 Variadic C functions now count arguments with size_t, not int.
14683 This avoids an unnecessary limitation on 64-bit machines, which
14684 caused (substring ...) to crash on large vectors (Bug#8344).
14685 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14686 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14687 All variadic functions and their callers changed accordingly.
c5101a77
PE
14688 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14689 * data.c (arith_driver, float_arith_driver): Likewise.
14690 * editfns.c (general_insert_function): Likewise.
14691 * eval.c (struct backtrace.nargs, interactive_p)
14692 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14693 (funcall_lambda, mark_backtrace): Likewise.
14694 * fns.c (concat): Likewise.
14695 * frame.c (x_set_frame_parameters): Likewise.
14696 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14697 0 if not found, not -1. All callers changed.
14698
dd3f25f7
PE
14699 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14700 (stack_copy_size): Now size_t, not int.
14701 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14702
461c2ab9
JB
147032011-03-28 Juanma Barranquero <lekktu@gmail.com>
14704
14705 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14706 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14707 All callers changed.
14708
14709 * lisp.h (multibyte_char_to_unibyte):
14710 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14711 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14712 * character.h (CHAR_TO_BYTE8):
14713 * cmds.c (internal_self_insert):
14714 * editfns.c (general_insert_function):
14715 * keymap.c (push_key_description):
14716 * search.c (Freplace_match):
14717 * xdisp.c (message_dolog, set_message_1): All callers changed.
14718
f6d62986
SM
147192011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14720
14721 * keyboard.c (safe_run_hook_funcall): New function.
14722 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14723 don't set the hook to nil, but remove the offending function instead.
14724 (Qcommand_hook_internal): Remove, unused.
14725 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14726 Vcommand_hook_internal.
14727
14728 * eval.c (enum run_hooks_condition): Remove.
14729 (funcall_nil, funcall_not): New functions.
14730 (run_hook_with_args): Call each function through a `funcall' argument.
14731 Remove `cond' argument, now redundant.
14732 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14733 (Frun_hook_with_args_until_failure): Adjust accordingly.
14734 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14735
1db5b1ad
JB
147362011-03-28 Juanma Barranquero <lekktu@gmail.com>
14737
14738 * dispextern.h (string_buffer_position): Remove declaration.
14739
14740 * print.c (strout): Remove parameter `multibyte', unused since
14741 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14742
14743 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14744 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14745 All callers changed.
14746
14747 * w32.c (_wsa_errlist): Use braces for struct initializers.
14748
14749 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14750 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14751 All callers changed.
14752 (string_buffer_position): Likewise. Also, make static (it's never
14753 used outside xdisp.c).
14754 (cursor_row_p): Remove parameter `w', unused since
14755 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14756 (decode_mode_spec): Remove parameter `precision', introduced during
14757 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14758 All callers changed.
14759
5ffb62aa
JD
147602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14761
14762 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14763
461c2ab9 147642011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14765
14766 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14767 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14768 (ns_update_auto_hide_menu_bar): New functions.
14769 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14770 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14771 ns_constrain_all_frames.
14772 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14773 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14774
5c380ffb
JD
147752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14776
14777 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14778
9af30bdf
GM
147792011-03-27 Glenn Morris <rgm@gnu.org>
14780
14781 * syssignal.h: Replace RETSIGTYPE with void.
14782 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14783 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14784 Replace SIGTYPE with void everywhere.
14785 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14786 * s/template.h (SIGTYPE): Remove commented out definition.
14787
e2abce01
JB
147882011-03-26 Eli Zaretskii <eliz@gnu.org>
14789
14790 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14791 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14792
f868cd8a
JB
147932011-03-26 Juanma Barranquero <lekktu@gmail.com>
14794
59eb0929
JB
14795 * w32.c (read_unc_volume): Use parameter `henum', instead of
14796 global variable `wget_enum_handle'.
14797
14798 * keymap.c (describe_vector): Remove parameters `indices' and
14799 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14800 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14801
f868cd8a
JB
14802 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14803
14804 * keyboard.c (timer_check): Remove parameter `do_it_now',
14805 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14806 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14807 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14808
14809 * keyboard.c (read_char):
14810 * w32menu.c (w32_menu_display_help):
14811 * xmenu.c (show_help_event, menu_help_callback):
14812 Adjust calls to `show_help_echo'.
14813
14814 * gtkutil.c (xg_maybe_add_timer):
14815 * keyboard.c (readable_events):
14816 * process.c (wait_reading_process_output):
14817 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14818
14819 * insdel.c (adjust_markers_gap_motion):
14820 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14821 (gap_left, gap_right): Don't call it.
14822
2ecf6fdb
CY
148232011-03-25 Chong Yidong <cyd@stupidchicken.com>
14824
14825 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14826 incurred during fontification.
14827
6b1f9ba4
JB
148282011-03-25 Juanma Barranquero <lekktu@gmail.com>
14829
14830 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14831 (DEFVAR_PER_BUFFER): Don't pass it.
14832
14833 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14834 (scrolling_window): Don't pass it.
14835
0f4a96b5
JB
148362011-03-25 Juanma Barranquero <lekktu@gmail.com>
14837
14838 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14839
14840 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14841 and `suffix'.
14842 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14843 of variables specific to SELinux and computation of `encoded_absname'.
14844
14845 * image.c (XPutPixel): Remove unused variable `height'.
14846
14847 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14848
14849 * unexw32.c (get_section_info): Remove unused variable `section'.
14850
14851 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14852 (system_process_attributes): Remove unused variable `sess'.
14853 (sys_read): Remove unused variable `err'.
14854
14855 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14856 (w32_wnd_proc): Remove unused variable `isdead'.
14857 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14858 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14859 (x_create_tip_frame): Remove unused variable `tem'.
14860
14861 * w32inevt.c (w32_console_read_socket):
14862 Remove unused variable `no_events'.
14863
14864 * w32term.c (x_draw_composite_glyph_string_foreground):
14865 Remove unused variable `width'.
14866
1149507c
JB
148672011-03-24 Juanma Barranquero <lekktu@gmail.com>
14868
14869 * w32term.c (x_set_glyph_string_clipping):
14870 Don't pass uninitialized region to CombineRgn.
14871
9c88f339
JB
148722011-03-23 Juanma Barranquero <lekktu@gmail.com>
14873
14874 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14875 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14876 (Fx_close_connection): Remove unused variable `i'.
14877
14878 * w32font.c (w32font_draw): Return number of glyphs.
14879 (w32font_open_internal): Remove unused variable `i'.
14880 (w32font_driver): Add missing initializer.
14881
14882 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14883 (fill_in_menu): Remove unused variable `items_added'.
14884
14885 * w32term.c (last_mouse_press_frame): Remove static global variable.
14886 (w32_clip_to_row): Remove unused variable `f'.
14887 (x_delete_terminal): Remove unused variable `i'.
14888
14889 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14890 (NOTHING): Remove unused static global variable.
14891 (uniscribe_check_otf): Remove unused variable `table'.
14892 (uniscribe_font_driver): Add missing initializers.
14893
dee091a3
JD
148942011-03-23 Julien Danjou <julien@danjou.info>
14895
14896 * term.c (Fsuspend_tty, Fresume_tty):
14897 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14898 * window.c (temp_output_buffer_show):
14899 * insdel.c (signal_before_change):
14900 * frame.c (Fhandle_switch_frame):
14901 * fileio.c (Fdo_auto_save):
14902 * emacs.c (Fkill_emacs):
14903 * editfns.c (save_excursion_restore):
14904 * cmds.c (internal_self_insert):
14905 * callint.c (Fcall_interactively):
14906 * buffer.c (Fkill_all_local_variables):
14907 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14908 Use Frun_hooks.
0f4a96b5 14909 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14910 unconditionally since it does the check itself.
dee091a3 14911
2c520ab5 149122011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14913
c9c49752
PE
14914 Fix more problems found by GCC 4.5.2's static checks.
14915
8abc3f12
PE
14916 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14917 the first time through the loop, since we know p0 < p1 then.
14918 This also avoids a gcc -Wstrict-overflow warning.
14919
a2d26660
PE
14920 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14921 leading to a memory leak, possible in functions like
14922 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14923 of objects (Bug#8318).
a2d26660 14924
916c72e9
PE
14925 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14926 that could (at least in theory) be that large.
14927
19ab8a18
PE
14928 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14929 This is less likely to overflow, and avoids undefined behavior if
14930 overflow does occur. All callers changed. Use strtoul to scan
14931 for the unsigned long integer.
b7cbbd6f
PE
14932 (pint2hrstr): Simplify and tune code slightly.
14933 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14934
f0641eff
PE
14935 * scroll.c (do_scrolling): Work around GCC bug 48228.
14936 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14937
7f650bb9
PE
14938 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14939 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14940 (validate_x_resource_name): Simplify count usage.
14941 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14942
37dd57d1
PE
14943 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14944 fail (Bug#8306).
81e56e61 14945
699979fc 14946 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14947
401bf9b4
PE
14948 * process.c (Fmake_network_process): Use socklen_t, not int,
14949 where POSIX says socklen_t is required in portable programs.
14950 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14951 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14952 (Fmake_network_process, server_accept_connection):
14953 (wait_reading_process_output, read_process_output):
14954 Likewise.
14955
b93aacde
PE
14956 * process.c: Rename or move locals to avoid shadowing.
14957 (list_processes_1, Fmake_network_process):
14958 (read_process_output_error_handler, exec_sentinel_error_handler):
14959 Rename or move locals.
4dc343ee 14960 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14961 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14962 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14963 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14964 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14965
af8a867c 14966 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14967 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14968 Include tparam.h instead, since it declares them.
af8a867c
PE
14969 * cm.h (PC): Remove extern decl; tparam.h now does this.
14970 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14971 * terminfo.c: Include tparam.h, to check interfaces.
14972 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14973 (tparam): Adjust signature to match interface in tparam.h;
14974 this removes some undefined behavior. Check that outstring and len
14975 are zero, which they always are with Emacs.
14976 * tparam.h (PC, BC, UP): New extern decls.
14977
0248044d 14978 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14979 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14980
8ff096c1 14981 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14982 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14983 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14984 (ftfont_list): Remove unused local.
49eaafba
PE
14985 (get_adstyle_property, ftfont_pattern_entity):
14986 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14987 Rename locals to avoid shadowing.
8ff096c1 14988
e2be39f6
PE
14989 * xfont.c (xfont_list_family): Mark var as initialized.
14990
c9735e30
PE
14991 * xml.c (make_dom): Now static.
14992
8f5201ae
PE
14993 * composite.c (composition_compute_stop_pos): Rename local to
14994 avoid shadowing.
b246f932
PE
14995 (composition_reseat_it): Remove unused locals.
14996 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14997 (composition_update_it): Mark var as initialized.
11b61122
PE
14998 (find_automatic_composition): Mark vars as initialized,
14999 with a FIXME (Bug#8290).
8f5201ae 15000
760fbc2c
PE
15001 character.h: Rename locals to avoid shadowing.
15002 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
15003 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
15004 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
15005 (BUF_DEC_POS): Be more systematic about renaming local temporaries
15006 to avoid shadowing.
15007
ff08eb85
PE
15008 * textprop.c (property_change_between_p): Remove; unused.
15009
fc7bf025
PE
15010 * intervals.c (interval_start_pos): Now static.
15011
235d7abc
PE
15012 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
15013
44f230aa
SM
15014 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
15015 Rename locals to avoid shadowing.
3e7d6594 15016
50060332
PE
15017 * sound.c (wav_play, au_play, Fplay_sound_internal):
15018 Fix pointer signedness.
d01f234b 15019 (alsa_choose_format): Remove unused local var.
c83b8872
PE
15020 (wav_play): Initialize a variable to 0, to prevent undefined
15021 behavior (Bug#8278).
50060332 15022
c4fc4e30
PE
15023 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
15024
918436ed
PE
15025 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
15026
c939f91b
PE
15027 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
15028 clobbering (Bug#8298).
b9c7f648
PE
15029 * sysdep.c (sys_subshell): Likewise.
15030 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 15031
6bd8c144
PE
15032 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
15033 This should get cleaned up, so that child_setup has the
15034 same signature on all platforms.
15035
7710357c 15036 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 15037 (relocate_fd): Rename locals to avoid shadowing.
7710357c 15038
c59da222
CY
150392011-03-22 Chong Yidong <cyd@stupidchicken.com>
15040
15041 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
15042 not to be necessary, and produces flickering.
15043
66b87493
GM
150442011-03-20 Glenn Morris <rgm@gnu.org>
15045
15046 * config.in: Remove file.
15047
45b6f6d5
JB
150482011-03-20 Juanma Barranquero <lekktu@gmail.com>
15049
15050 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
15051 are now in src/globals.h.
15052 (syms_of_minibuf): Remove spurious & from previous change.
15053
cd394be1 150542011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
15055
15056 * minibuf.c (completing-read-function): New variable.
15057 (completing-read-default): Rename from completing-read.
15058 (completing-read): Call completing-read-function.
15059
b14e3e21
CY
150602011-03-19 Juanma Barranquero <lekktu@gmail.com>
15061
15062 * xfaces.c (Fx_load_color_file):
15063 Read color file from absolute filename (bug#8250).
15064
f2b726e6
JB
150652011-03-19 Juanma Barranquero <lekktu@gmail.com>
15066
15067 * makefile.w32-in: Update dependencies.
15068
09f6ff02
EZ
150692011-03-17 Eli Zaretskii <eliz@gnu.org>
15070
15071 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
15072
29a6015a
PE
150732011-03-17 Paul Eggert <eggert@cs.ucla.edu>
15074
a3a6c54e
PE
15075 Fix more problems found by GCC 4.5.2's static checks.
15076
b766f867
PE
15077 * process.c (make_serial_process_unwind, send_process_trap):
15078 (sigchld_handler): Now static.
15079
be02381c
PE
15080 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
15081 That way, the code declares only the vars that it needs.
15082 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
15083 * s/cygwin.h (PTY_ITERATION): Likewise.
15084 * s/darwin.h (PTY_ITERATION): Likewise.
15085 * s/gnu-linux.h (PTY_ITERATION): Likewise.
15086
57048744
PE
15087 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
15088 * process.c (allocate_pty): Don't declare stb unless it's needed.
15089
7914961c 15090 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
15091 (CONSTANTLIM): Remove; unused.
15092 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
15093 Define only if needed.
7914961c 15094
b3967b18
PE
15095 * unexelf.c (unexec): Name an expression,
15096 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
15097 Use a different way to cause a compilation error if anyone uses
15098 n rather than nn, a way that does not involve shadowing.
73366a00 15099 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 15100
29a6015a
PE
15101 * deps.mk (unexalpha.o): Remove; unused.
15102
43cfc33e 15103 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 15104 * unexec.h: New file.
ce701a33
PE
15105 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
15106 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
15107 Depend on unexec.h.
15108 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
15109 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
15110 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 15111 Change as necessary to match prototype in unexec.h.
ce701a33 15112
01f44d5a
PE
15113 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
15114 shadowing.
4f63c6bb 15115 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 15116
a6670b0b
PE
15117 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
15118 Rename locals to avoid shadowing.
15119
cef2010d 15120 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 15121 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 15122
d4d7173a
PE
15123 * print.c (Fredirect_debugging_output): Fix pointer signedess.
15124
f08b802a
PE
15125 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
15126 warning when compiling print.c.
15127
3ddb0639
PE
15128 * font.c (font_unparse_fcname): Abort in an "impossible" situation
15129 instead of using an uninitialized var.
5ad03b97 15130 (font_sort_entities): Mark var as initialized.
3ddb0639 15131
170a2692
PE
15132 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
15133
e663c700
PE
15134 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
15135 pointers to constants.
89bc529a 15136 (font_parse_fcname): Remove unused vars.
7b81e2d0 15137 (font_delete_unmatched): Now static.
ea838e10 15138 (font_get_spec): Remove; unused.
13a547c6
PE
15139 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
15140 (font_update_drivers, Ffont_get_glyphs, font_add_log):
15141 Rename or move locals to avoid shadowing.
e663c700 15142
2a80c887 15143 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 15144 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 15145
1384fa33 15146 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 15147 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 15148
8b2c52e9
PE
15149 * alloc.c (mark_backtrace): Move decl from here ...
15150 * lisp.h: ... to here, so that it can be checked.
15151
475545b5 15152 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 15153 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
15154 (lisp_indirect_variable): Name an expression,
15155 to avoid gcc -Wbad-function-cast warning.
1faed8ae 15156 (Fdefvar): Rename locals to avoid shadowing.
475545b5 15157
b1349114 15158 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 15159 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 15160 Use const pointer when appropriate.
b1349114 15161
a2928364
PE
15162 * lisp.h (get_system_name, get_operating_system_release):
15163 Move decls here, to check interfaces.
15164 * process.c (get_operating_system_release): Move decl to lisp.h.
15165 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
15166 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
15167 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
15168 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
15169 (Fformat_time_string, Fencode_time, Finsert_char):
15170 (Ftranslate_region_internal, Fformat):
15171 Rename or remove local vars to avoid shadowing.
9710023e 15172 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 15173
a415e694
PE
15174 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
15175 avoid shadowing.
15176
8ef4622d
PE
15177 * lisp.h (eassert): Check that the argument compiles, even if
15178 ENABLE_CHECKING is not defined.
15179
946f9a5b
PE
15180 * data.c (Findirect_variable): Name an expression, to avoid
15181 gcc -Wbad-function-cast warning.
112396d6 15182 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 15183 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
15184 (Fmake_variable_buffer_local, Fmake_local_variable):
15185 Mark variables as initialized.
52746918 15186 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 15187
e5aab7e7 15188 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
15189 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
15190 Rename locals to avoid shadowing.
dff45157
PE
15191 (mark_stack): Move local variables into the #ifdef region where
15192 they're used.
7bc26fdb
PE
15193 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
15194 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
15195 needed otherwise.
15196 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
15197 (GC_STRING_CHARS): Remove; not used.
d40d4be1 15198 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 15199
e5aab7e7
PE
15200 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
15201 avoids undefined behavior in theory.
15202
4da60324
PE
15203 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
15204
88043301
PE
15205 Use functions, not macros, for up- and down-casing (Bug#8254).
15206 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15207 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
15208 to use the following functions instead of these macros.
15209 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
15210 EMACS_INT, since callers assume the returned value fits in int.
15211 (upcase1): Likewise, for UPCASE_TABLE.
15212 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 15213 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 15214 the race-condition problem in the old DOWNCASE.
88043301 15215
19ed5445
PE
15216 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
15217 Rename locals to avoid shadowing.
15218 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
15219 (regex_compile, re_search_2, re_match_2_internal):
15220 Remove unused local vars.
952db0d7
PE
15221 (FREE_VAR): Rewrite so as not to use empty "else",
15222 which gcc can warn about.
da053e48 15223 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
15224 (RETALLOC_IF): Define only if needed.
15225 (WORDCHAR_P): Likewise. This one is never needed, but is used
15226 only in a comment talking about a compiler bug, so put inside
15227 the #if 0 of that comment.
15228 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
15229 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
15230 Remove; unused.
19ed5445 15231
1f3561e4 15232 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
15233 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
15234 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 15235
ded6f8f7
PE
15236 * search.c (simple_search): Remove unused var.
15237
dbd37a95
PE
15238 * dired.c (compile_pattern): Move decl from here ...
15239 * lisp.h: ... to here, so that it can be checked.
15240 (struct re_registers): New forward decl.
15241
7e47afad
PE
15242 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
15243
85f24f61
PE
15244 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
15245 All uses changed.
15246 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
15247 Rename locals to avoid shadowing.
5671df8f 15248 (Fvertical_motion): Mark locals as initialized.
85f24f61 15249
181aa2be 15250 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 15251 (casify_region): Mark local as initialized.
181aa2be 15252
930d429c
PE
15253 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
15254
7082eac6
PE
15255 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
15256 New macros, so that the caller can use some names other than
15257 gcpro1, gcpro2, etc.
15258 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
15259 of the new macros.
15260 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
15261 argument, for consistency with GCPRO2_VAR, etc: it is now the
15262 prefix of the variable, not the variable itself. All uses
15263 changed.
38b2c076
PE
15264 * dired.c (directory_files_internal, file_name_completion):
15265 Rename locals to avoid shadowing.
15266
15206ed9
PE
15267 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
15268 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
15269 dired.c's scmp function, had undefined behavior.
15270 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15271 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
15272 * buffer.h: ... to here, because these macros use current_buffer,
15273 and the new implementation with inline functions needs to have
15274 current_buffer in scope now, rather than later when the macros
15275 are used.
15276 (downcase, upcase1): New static inline functions.
15277 (DOWNCASE, UPCASE1): Reimplement using these functions.
15278 This avoids undefined behavior in expressions like
15279 DOWNCASE (x) == DOWNCASE (y), which previously suffered
15280 from race conditions in accessing the global variables
15281 case_temp1 and case_temp2.
15282 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
15283 * lisp.h (case_temp1, case_temp2): Remove their decls.
15284 * character.h (ASCII_CHAR_P): Move from here ...
15285 * lisp.h: ... to here, so that the inline functions mentioned
15286 above can use them.
15287
4a6bea26
PE
15288 * dired.c (directory_files_internal_unwind): Now static.
15289
f14b7e14
PE
15290 * fileio.c (file_name_as_directory, directory_file_name):
15291 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
15292 Now static.
2893f146
PE
15293 (file_name_as_directory): Use const pointers when appropriate.
15294 (Fexpand_file_name): Likewise. In particular, newdir might
15295 point at constant storage, so make it a const pointer.
fd4ead52 15296 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
15297 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
15298 signedness issues.
f839df0c
PE
15299 (Fset_file_times, Finsert_file_contents, auto_save_error):
15300 Rename locals to avoid shadowing.
f14b7e14 15301
5716756e 15302 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
15303 (Ftry_completion, Fall_completions): Rename or remove locals
15304 to avoid shadowing.
5716756e 15305
b4c3046a
PE
15306 * marker.c (bytepos_to_charpos): Remove; unused.
15307
b45db522
PE
15308 * lisp.h (verify_bytepos, count_markers): New decls,
15309 so that gcc does not warn that these functions aren't declared.
15310
85876d07
PE
15311 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
15312 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 15313 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 15314 (copy_text): Remove unused local var.
85876d07 15315
03d78a21 15316 * filelock.c (within_one_second): Now static.
b3dd38ab 15317 (lock_file_1): Rename local to avoid shadowing.
03d78a21 15318
5df8f01b
PE
15319 * buffer.c (fix_overlays_before): Mark locals as initialized.
15320 (fix_start_end_in_overlays): Likewise. This function should be
15321 simplified by using pointers-to-pointers, but that's a different
15322 matter.
b1d876f1 15323 (switch_to_buffer_1): Now static.
8f54f30a
PE
15324 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
15325 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 15326
a70072c9 15327 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 15328 Fix pointer signedness issue.
edced198
PE
15329 (sys_subshell): Mark local as volatile if checking for lint,
15330 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 15331 (MAXPATHLEN): Define only if needed.
a70072c9 15332
a0977c44
PE
15333 * process.c (serial_open, serial_configure): Move decls from here ...
15334 * systty.h: ... to here, so that they can be checked.
15335
a884fdcc
PE
15336 * fns.c (get_random, seed_random): Move extern decls from here ...
15337 * lisp.h: ... to here, so that they can be checked.
15338
604efe86 15339 * sysdep.c (reset_io): Now static.
b8950c94 15340 (wait_for_termination_signal): Remove; unused.
604efe86 15341
38fc62d9
PE
15342 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
15343 (copy_keymap_item, append_key, push_text_char_description):
15344 Now static.
1004a21a 15345 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 15346 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
15347 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
15348 (describe_map_tree):
15349 Rename locals to avoid shadowing.
38fc62d9 15350
2f2650da
PE
15351 * keyboard.c: Declare functions static if they are not used elsewhere.
15352 (echo_char, echo_dash, cmd_error, top_level_2):
15353 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
15354 (read_char, kbd_buffer_get_event, make_lispy_position):
15355 (make_lispy_event, make_lispy_movement, apply_modifiers):
15356 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
15357 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
15358 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 15359 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 15360 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 15361
a053e86c 15362 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
15363 (mark_kboards): Move decl here ...
15364 * alloc.c (mark_kboards): ... from here.
a053e86c 15365
4752793e
PE
15366 * lisp.h (force_auto_save_soon): New decl.
15367
74f10ca7 15368 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
15369 (DEFINE_DUMMY_FUNCTION): New macro.
15370 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
15371 Use it.
c03cd23f
PE
15372 (main): Add casts to avoid warnings
15373 if GCC considers string literals to be constants.
74f10ca7 15374
022e70d4
PE
15375 * lisp.h (fatal_error_signal): Add decl, since it's exported.
15376
59d6fe83
PE
15377 * dbusbind.c: Pointer signedness fixes.
15378 (xd_signature, xd_append_arg, xd_initialize):
15379 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15380 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15381 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
15382 (Fdbus_register_signal): Use SSDATA when the context wants char *.
15383
78320123
PE
15384 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
15385 if GCC considers string literals to be constants.
49cebcca 15386 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 15387
35ac2a97
SM
153882011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
15389
fb103ca9
SM
15390 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
15391 (print_preprocess, print_object): New macro to fix last change.
15392
35ac2a97
SM
15393 * print.c (print_preprocess): Don't forget font objects.
15394
62973b41
JB
153952011-03-16 Juanma Barranquero <lekktu@gmail.com>
15396
15397 * emacs.c (USAGE3): Doc fixes.
15398
0e48bb22
AS
153992011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15400
15401 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15402 structure.
15403
7684e57b
JB
154042011-03-14 Juanma Barranquero <lekktu@gmail.com>
15405
15406 * lisp.h (VWindow_system, Qfile_name_history):
15407 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15408 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15409 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15410
15411 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15412 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15413
15414 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15415 * w32console.c (detect_input_pending, read_input_pending)
15416 (encode_terminal_code):
15417 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15418 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15419 (w32_system_caret_y, Qfile_name_history):
15420 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15421 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15422 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15423 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15424 * w32proc.c (Qlocal, report_file_error):
15425 * w32term.c (Vwindow_system, updating_frame):
15426 * w32uniscribe.c (initialized, uniscribe_font_driver):
15427 Remove unneeded extern declarations.
15428
2aa46d6c
CY
154292011-03-14 Chong Yidong <cyd@stupidchicken.com>
15430
c96bbc66 15431 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15432
cffc6f3b
CY
154332011-03-13 Chong Yidong <cyd@stupidchicken.com>
15434
15435 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15436 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15437 These macros can no longer be used for assignment.
15438
44f230aa
SM
15439 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15440 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15441 (record_buffer_markers, fetch_buffer_markers): New functions for
15442 recording and fetching special buffer markers.
15443 (set_buffer_internal_1, set_buffer_temp): Use them.
15444
15445 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15446
15447 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15448
15449 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15450 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15451
15452 * xdisp.c (hscroll_window_tree):
15453 (reconsider_clip_changes): Use PT instead of BUF_PT.
15454
d251f04b
EZ
154552011-03-13 Eli Zaretskii <eliz@gnu.org>
15456
15457 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15458 $(EMACS_ROOT)/lib/intprops.h.
15459
f0c77cd1
PE
154602011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15461
3eca4629
PE
15462 Fix more problems found by GCC 4.5.2's static checks.
15463
7c86ee98
PE
15464 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15465 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15466 (xg_free_frame_widgets): Make it clear that a local variable is
15467 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15468 (gdk_window_get_screen): Make it clear that this macro is needed
15469 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15470 (int_gtk_range_get_value): New function, which avoids a diagnostic
15471 from gcc -Wbad-function-cast.
15472 (xg_set_toolkit_scroll_bar_thumb): Use it.
15473 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15474 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15475 (get_utf8_string, xg_get_file_with_chooser):
15476 Rename locals to avoid shadowing.
15477 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15478
41729b81
PE
15479 * xgselect.c (xg_select): Remove unused var.
15480
f0c77cd1
PE
15481 * image.c (four_corners_best): Mark locals as initialized.
15482 (gif_load): Initialize transparent_p to zero (Bug#8238).
15483 Mark another local as initialized.
ec6cf4c6 15484 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15485
ce0ad53d 15486 * image.c (clear_image_cache): Now static.
d5d5a617 15487 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15488 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15489 (x_edge_detection): Remove unnecessary cast that
15490 gcc -Wbad-function-cast diagnoses.
2037898d 15491 (gif_load): Fix pointer signedness.
6ae141d6
PE
15492 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15493 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15494
33383987 154952011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15496
d32df629
PE
15497 Improve quality of tests for time stamp overflow.
15498 For example, without this patch (encode-time 0 0 0 1 1
15499 1152921504606846976) returns the obviously-bogus value (-948597
15500 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15501 reports time overflow. See
15502 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15503 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15504 * editfns.c: Include limits.h and intprops.h.
15505 (TIME_T_MIN, TIME_T_MAX): New macros.
15506 (time_overflow): Move earlier, to before first use.
15507 (hi_time, lo_time): New functions, for an accurate test for
15508 out-of-range times.
15509 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15510 (Fget_internal_run_time): Don't assume time_t fits in int.
15511 (make_time): Use list2 instead of Fcons twice.
15512 (Fdecode_time): More accurate test for out-of-range times.
15513 (check_tm_member): New function.
15514 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15515 (lisp_time_argument): Don't rely on undefined left-shift and
15516 right-shift behavior when checking for time stamp overflow.
8be6f318 15517
fe31d94c
PE
15518 * editfns.c (time_overflow): New function, refactoring common code.
15519 (Fformat_time_string, Fdecode_time, Fencode_time):
15520 (Fcurrent_time_string): Use it.
15521
8be6f318
PE
15522 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15523 * dired.c (make_time): Move to ...
15524 * editfns.c (make_time): ... here.
15525 * systime.h: Note the move.
15526
09d9db2c 155272011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15528
126bc0dc
YM
15529 * fringe.c (update_window_fringes): Remove unused variables.
15530
c47cbdfd
YM
15531 * unexmacosx.c (copy_data_segment): Also copy __got section.
15532 (Bug#8223)
15533
7ac80be9
EZ
155342011-03-12 Eli Zaretskii <eliz@gnu.org>
15535
c96bbc66 15536 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15537 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15538 Constify `char *' arguments and their references according to
15539 prototypes in tparam.h.
15540
ecb0f94d 15541 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15542
7ac80be9
EZ
15543 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15544 Adapt all references accordingly.
15545
15546 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15547
ef1fd07e
TT
155482011-03-11 Tom Tromey <tromey@redhat.com>
15549
15550 * buffer.c (syms_of_buffer): Remove obsolete comment.
15551
7ef4b50c
EZ
155522011-03-11 Eli Zaretskii <eliz@gnu.org>
15553
15554 * termhooks.h (encode_terminal_code): Declare prototype.
15555
15556 * msdos.c (encode_terminal_code): Don't declare prototype.
15557
15558 * term.c (encode_terminal_code): Now external again, used by
15559 w32console.c and msdos.c.
15560
44f230aa
SM
15561 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15562 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15563
4b1ec863 155642011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15565
1714f52b 15566 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15567
4b1ec863
PE
15568 * fringe.c (update_window_fringes): Mark locals as initialized
15569 (Bug#8227).
15570 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15571
524c7aa6
PE
15572 * alloc.c (mark_fringe_data): Move decl from here ...
15573 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15574 to check its interface.
15575 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15576
a5c0af81 15577 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15578 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15579 (fontset_font): Mark local as initialized.
a9a06e0b 15580 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15581
b4716021
PE
15582 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15583
811e9bac 15584 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15585 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15586 (x_own_selection, Fx_disown_selection_internal): Rename locals
15587 to avoid shadowing.
15588 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15589
7e3ab302
PE
15590 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15591 so that the caller can use some name other than gcpro1.
15592 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15593 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15594 (Fx_backspace_delete_keys_p):
15595 Use them to avoid shadowing, and rename vars to avoid shadowing.
15596 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15597 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15598 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15599 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15600 Remove unused locals.
7e3ab302
PE
15601 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15602 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15603 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15604 macros.
f78faa98 15605
e2b13473
PE
15606 * xterm.h (x_mouse_leave): New decl.
15607
77f23912
PE
15608 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15609 Remove unused functions.
cdf4ba58
PE
15610 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15611 (x_calc_absolute_position): Now static.
7411c686 15612 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15613 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15614 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15615 unless they are used.
38d0b34a
PE
15616 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15617 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15618 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15619 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15620 (x_error_catcher, x_connection_closed, x_error_handler):
15621 (x_error_quitter, xembed_send_message, x_iconify_frame):
15622 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15623 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15624 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15625
44f230aa
SM
15626 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15627 Rename or move locals to avoid shadowing.
6b463e58 15628 (tty_defined_color, merge_face_heights): Now static.
5967d051 15629 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15630 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15631 does not deduce is never used uninitialized.
73719eba
PE
15632 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15633 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15634
426994c3 15635 * terminal.c (store_terminal_param): Now static.
5489860b 15636
032f1620 15637 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15638 (set_frame_menubar): Remove unused local.
d4323972 15639 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15640 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15641 since they might point to immutable storage.
281585b0
PE
15642 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15643 since it's unused otherwise.
032f1620 15644
367c19e5 15645 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15646 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15647 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15648 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15649 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15650 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15651 does not deduce are never used uninitialized.
70739cbe 15652
07b48fa9
PE
15653 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15654
8868a238 15655 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15656 * window.c (window_loop, size_window):
15657 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15658
7e5cf297 15659 * window.c (display_buffer): Now static.
d6550a9f
PE
15660 (size_window): Mark variables that gcc -Wuninitialized
15661 does not deduce are never used uninitialized.
a586633d
PE
15662 * window.h (check_all_windows): New decl, to forestall
15663 gcc -Wmissing-prototypes diagnostic.
5b555da1 15664 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15665
f6095868
PE
15666 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15667 shadowing.
15668 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15669 Include <limits.h>.
15670 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15671 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15672 (load_charset_map): Mark variables that gcc -Wuninitialized
15673 does not deduce are never used uninitialized.
53df7c11 15674 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15675
f38b440c
PE
15676 * coding.c (coding_set_source, coding_set_destination):
15677 Use "else { /* comment */ }" rather than "else /* comment */;"
15678 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15679 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15680 a block, when the outer 'i' will do.
15681 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15682 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15683 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15684 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15685 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15686 Rename locals to avoid shadowing.
15687 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15688 * coding.c (emacs_mule_char, encode_invocation_designation):
15689 Now static, since they're not used elsewhere.
413bb2db 15690 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15691 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15692 (decode_coding_emacs_mule): Mark variables that gcc
15693 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15694 (detect_coding_iso_2022): Initialize a local variable that might
15695 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15696 this initialization is needed. (Bug#8211)
5f58e762
PE
15697 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15698 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15699 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15700 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15701 Remove unused macros.
f38b440c 15702
232b38b9 15703 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15704 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15705 * character.c (string_count_byte8): Likewise.
232b38b9 15706
fb90da1b
PE
15707 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15708 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15709
fb93dbc2
PE
15710 * chartab.c (copy_sub_char_table): Now static, since it's not used
15711 elsewhere.
5c156ace
PE
15712 (sub_char_table_ref_and_range, char_table_ref_and_range):
15713 Rename locals to avoid shadowing.
bbcd0949 15714 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15715
7d3b3862 15716 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15717 (BIDI_BOB): Remove unused macro.
7d3b3862 15718
6be7d3da
PE
15719 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15720 deduce are never used uninitialized.
c2ed9c8b 15721 * term.c (encode_terminal_code): Likewise.
6be7d3da 15722
75f8807f 15723 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15724
50938595
PE
15725 * tparam.h: New file.
15726 * term.c, tparam.h: Include it.
15727 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15728 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15729 Move these decls to tparam.h, and make them agree with what
15730 is actually in tparam.c. The previous trick of using incompatible
15731 decls in different modules does not conform to the C standard.
15732 All callers of tparam changed to use tparam's actual API.
15733 * tparam.c (tparam1, tparam, tgoto):
15734 Use const pointers where appropriate.
15735
fbceeba2
PE
15736 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15737 * cm.h (struct cm): Likewise.
15738 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15739 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15740 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15741 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15742 (turn_on_face, init_tty): Likewise.
15743 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15744
7f3f1250
PE
15745 * term.c (term_mouse_position): Rename local to avoid shadowing.
15746
e6ca6543
PE
15747 * alloc.c (mark_ttys): Move decl from here ...
15748 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15749
c40f8d15
AS
157502011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15751
15752 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15753
cfe0661d
JB
157542011-03-09 Juanma Barranquero <lekktu@gmail.com>
15755
15756 * search.c (compile_pattern_1): Remove argument regp, unused since
15757 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15758 (compile_pattern): Don't pass it.
15759
0afb4571
J
157602011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15761
15762 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15763 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15764 for ! HAVE_GTK3.
15765 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15766
15767 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15768
15769 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15770 gdk_window_get_screen, gdk_window_get_geometry,
15771 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15772 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15773 (xg_get_pixbuf_from_pixmap): New function.
15774 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15775 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15776 Call xg_get_pixbuf_from_pixmap instead of
15777 gdk_pixbuf_get_from_drawable.
15778 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15779 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15780 (xg_check_special_colors): Use GtkStyleContext and its functions
15781 for HAVE_GTK3.
15782 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15783 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15784 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15785 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15786 Call gtk_widget_get_preferred_size.
0afb4571
J
15787 (xg_frame_resized): gdk_window_get_geometry only takes 5
15788 parameters.
44f230aa
SM
15789 (xg_win_to_widget, xg_event_is_for_menubar):
15790 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15791 (xg_set_widget_bg): New function.
15792 (delete_cb): New function.
895009e1 15793 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15794 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15795 (xg_set_background_color): Call xg_set_widget_bg.
15796 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15797 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15798 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15799 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15800 if ! HAVE_GTK3.
15801 (update_frame_tool_bar): Call gtk_widget_hide.
15802 (xg_initialize): Use GDK_KEY_g.
15803
15804 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15805 if ! HAVE_GTK3
15806 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15807
15808 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15809 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15810 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15811
1c2cc4ef
JB
158122011-03-08 Juanma Barranquero <lekktu@gmail.com>
15813
15814 * w32xfns.c (select_palette): Check success of RealizePalette against
15815 GDI_ERROR, not zero.
15816
33383987 15817See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15818
15819;; Local Variables:
15820;; coding: utf-8
aac0c6e3
MR
15821;; End:
15822
2f097256 15823 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15824
15825 This file is part of GNU Emacs.
15826
15827 GNU Emacs is free software: you can redistribute it and/or modify
15828 it under the terms of the GNU General Public License as published by
15829 the Free Software Foundation, either version 3 of the License, or
15830 (at your option) any later version.
15831
15832 GNU Emacs is distributed in the hope that it will be useful,
15833 but WITHOUT ANY WARRANTY; without even the implied warranty of
15834 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15835 GNU General Public License for more details.
15836
15837 You should have received a copy of the GNU General Public License
15838 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.