Move SIGNALS_VIA_CHARACTERS from src/s to configure
[bpt/emacs.git] / src / ChangeLog
CommitLineData
34348bd4
AS
12012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2
d96a1e0c
AS
3 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
4
34348bd4
AS
5 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
6 of Fcar/Fcdr if possible.
7 * font.c (check_otf_features): Likewise.
8 * fontset.c (Fnew_fontset): Likewise.
9 * gnutls.c (Fgnutls_boot): Likewise.
10 * minibuf.c (read_minibuf): Likewise.
11 * msdos.c (IT_set_frame_parameters): Likewise.
12 * xmenu.c (Fx_popup_dialog): Likewise.
13 * w32menu.c (Fx_popup_dialog): Likewise.
14
c8add24e
GM
152012-07-11 Glenn Morris <rgm@gnu.org>
16
09f4e3b0
GM
17 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
18 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
19
172bedef
GM
20 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
21 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
22 Move CLASH_DETECTION to configure.
23
249685df
GM
24 * s/gnu.h: Remove file, which is now empty.
25
c8add24e
GM
26 * s/gnu.h, s/gnu-linux.h:
27 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
28
b41253a3
JW
292012-07-11 John Wiegley <johnw@newartisans.com>
30
31 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
32 function attribute, so we only use it if it exists in the
33 compiler.
34
d923b542
DA
352012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
36
37 Avoid call to strlen in fast_c_string_match_ignore_case.
38 * search.c (fast_c_string_match_ignore_case): Change to use
39 length argument. Adjust users accordingly.
40 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
41
5ebbef1d
PE
422012-07-11 Paul Eggert <eggert@cs.ucla.edu>
43
bb352260
PE
44 Assume mkdir, rmdir.
45 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
46 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
47
57054ddd
PE
48 Assume rename.
49 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
50
b747d3f7
PE
51 Assume perror.
52 * s/hpux10-20.h (HAVE_PERROR): Remove.
53 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
54 Remove dummy definition, as this problem was obsolete long ago.
55
5ebbef1d
PE
56 Assume strerror.
57 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
58
984e7f30
DA
592012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
60
61 Avoid calls to strlen in font processing functions.
62 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 63 (font_open_by_name): Change to use length argument. Adjust
984e7f30 64 users accordingly.
d923b542
DA
65 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
66 Adjust prototypes.
67 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
68 Change to return ptrdiff_t.
984e7f30
DA
69 (xfont_list_pattern, xfont_match): Use length returned by
70 xfont_decode_coding_xlfd.
71 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
72
20e94fdd
GM
732012-07-11 Glenn Morris <rgm@gnu.org>
74
9d596af3
GM
75 * s/darwin.h, s/freebsd.h, s/netbsd.h:
76 Move DONT_REOPEN_PTY to configure.
77
20e94fdd
GM
78 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
79 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
80
e99a530f
PE
812012-07-10 Paul Eggert <eggert@cs.ucla.edu>
82
22ffb973
PE
83 Remove "#define unix" that is no longer needed (Bug#11905).
84 * s/aix4-2.h (unix): Remove; no longer needed.
85
e9a9ae03
PE
86 EMACS_TIME simplification (Bug#11875).
87 This replaces macros (which typically do not work in GDB)
88 with functions, typedefs and enums, making the code easier to debug.
89 The functional style also makes code easier to read and maintain.
90 * systime.h: Include <sys/time.h> on all hosts, not just if
91 WINDOWSNT, since 'struct timeval' is needed in general.
92 (EMACS_TIME): Now a typedef, not a macro.
93 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
94 not macros.
95 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
96 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
97 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
98 (EMACS_TIME_LE): Now functions, not macros.
99 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
100 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
101 which are not functions. All uses rewritten to use:
102 (make_emacs_time): New function.
103 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
104 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
105 not functions. All uses rewritten to use the following, respectively:
106 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
107 (add_emacs_time, sub_emacs_time): New functions.
108 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
109 * fileio.c (Fcopy_file):
110 * xterm.c (XTflash): Get the current time closer to when it's used.
111 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
112
ffacb126
PE
113 * bytecode.c (targets): Suppress -Woverride-init warnings.
114
e99a530f
PE
115 Simplify by avoiding confusing use of strncpy etc.
116 * doc.c (Fsnarf_documentation):
117 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
118 * frame.c (Fmake_terminal_frame):
119 * gtkutil.c (get_utf8_string):
120 * lread.c (openp):
121 * nsmenu.m (ns_update_menubar):
122 * regex.c (regerror):
123 Prefer memcpy to strncpy and strncat when either will do.
124 * fileio.c (Fsubstitute_in_file_name):
125 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
126 (menu_separator_name_p):
127 * nsmenu.m (ns_update_menubar):
128 Prefer memcmp to strncmp when either will do.
129 * nsterm.m: Include <ftoastr.h>.
130 (ns_get_color):
131 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
132 Prefer snprintf to strncpy.
133 * nsterm.m (ns_term_init):
134 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
135 * nsterm.m (ns_term_init):
136 Avoid the need for strncpy, by using build_string or
137 make_unibyte_string directly. Use dtoastr, not snprintf.
138 * process.c (Fmake_network_process): Diagnose service names that
139 are too long, rather than silently truncating them or creating
140 non-null-terminated names.
141 (Fnetwork_interface_info): Likewise, for interface names.
142 * sysdep.c (system_process_attributes) [GNU_LINUX]:
143 Prefer sprintf to strncat.
144 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
145 Prefer vsnprintf to vsprintf + strncpy.
146
c59592b3
GM
1472012-07-10 Glenn Morris <rgm@gnu.org>
148
149 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
150 Clarify fallback case.
151
7d7bbefd
DA
1522012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
153
154 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
155 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
156 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 157 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
158 where argument type is known to be a Lisp_Cons.
159
3a4c8000
TT
1602012-07-10 Tom Tromey <tromey@redhat.com>
161
162 * bytecode.c (BYTE_CODE_THREADED): New macro.
163 (BYTE_CODES): New macro. Replaces all old byte-code defines.
164 (enum byte_code_op): New type.
165 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
166 (exec_byte_code): Use them. Use token threading when applicable.
167
2a0213a6
DA
1682012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
169
170 Optimize pure C strings initialization.
171 * lisp.h (make_pure_string): Fix prototype.
172 (build_pure_c_string): New function, defined as static inline. This
173 provides a better opportunity to optimize away calls to strlen when
174 the function is called with compile-time constant argument.
175 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
176 argument, adjust users accordingly. Use build_pure_c_string where
177 appropriate.
178 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
179 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
180 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
181
cb1caeaf
DA
1822012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
183
184 Avoid calls to strlen in miscellaneous functions.
185 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
186 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
187 * lread.c (openp): Likewise.
188
c293e30c
DA
1892012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
190
191 Avoid calls to strlen in path processing functions.
192 * fileio.c (file_name_as_directory): Add comment. Change to add
193 srclen argument and return the length of result. Adjust users
194 accordingly.
195 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 196 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
197 users accordingly.
198 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
199
9e059e3f
GM
2002012-07-10 Glenn Morris <rgm@gnu.org>
201
d02eb359
GM
202 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
203 Move PENDING_OUTPUT_COUNT definition to configure.
204
882cf227
GM
205 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
206 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
207 * s/gnu.h (DATA_START): Move definitions to configure.
208
af6e839f
GM
209 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
210 We include usg5-4-common.h, which defines them both.
211
40289a12
GM
212 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
213 O_RDONLY already includes it).
214
9e059e3f
GM
215 Stop ns builds setting the EMACSLOADPATH environment variable.
216 * nsterm.m (ns_load_path): Rename from ns_init_paths.
217 Now it does not set EMACSLOADPATH, just returns the load-path string.
218 * nsterm.h: Update accordingly.
219 * lread.c [HAVE_NS]: Include nsterm.h.
220 (init_lread) [HAVE_NS]: Use ns_load_path.
221 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
222
7c4e8ec0
GM
2232012-07-09 Glenn Morris <rgm@gnu.org>
224
d4f600ff
GM
225 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
226 since the included bsd-common.h does so.
227
cbb31951
GM
228 Stop ns builds setting the EMACSPATH environment variable.
229 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
230 (ns_init_paths): Do not set EMACSPATH.
231 * nsterm.h (ns_exec_path): Add it.
232 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
233 Use ns_exec_path.
234
7c4e8ec0
GM
235 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
236
26bccfae
PE
2372012-07-09 Paul Eggert <eggert@cs.ucla.edu>
238
a0bee46f
PE
239 * process.c (wait_reading_process_output): 'waitchannels' was unset
240 when read_kbd || !NILP (wait_for_cell); fix this.
241
5994c183
PE
242 Add GCC-style 'const' attribute to functions that can use it.
243 * character.h (char_resolve_modifier_mask):
244 * keyboard.h (make_ctrl_char):
245 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
246 (init_character_once, next_almost_prime, init_fns, init_image)
247 (flush_pending_output, init_sound):
248 * mem-limits.h (start_of_data):
249 * menu.h (finish_menu_items):
250 Add ATTRIBUTE_CONST.
251 * emacs.c (DEFINE_DUMMY_FUNCTION):
252 Declare the dummy function with ATTRIBUTE_CONST.
253 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
254 Add decls with ATTRIBUTE_CONST.
255
26bccfae
PE
256 Minor improvements to make_formatted_string.
257 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
258 where int is good enough, as vsprintf returns an int.
259 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
260
a8290ec3
DA
2612012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
262
263 Use make_formatted_string to avoid double length calculation.
264 * lisp.h (make_formatted_string): New prototype.
265 * alloc.c (make_formatted_string): New function.
266 * buffer.c (Fgenerate_new_buffer_name): Use it.
267 * dbus.c (syms_of_dbusbind): Likewise.
268 * editfns.c (Fcurrent_time_zone): Likewise.
269 * filelock.c (get_boot_time): Likewise.
270 * frame.c (make_terminal_frame, set_term_frame_name)
271 (x_report_frame_params): Likewise.
272 * image.c (gs_load): Likewise.
273 * minibuf.c (get_minibuffer): Likewise.
274 * msdos.c (dos_set_window_size): Likewise.
275 * process.c (make_process): Likewise.
276 * xdisp.c (ensure_echo_area_buffers): Likewise.
277 * xsettings.c (apply_xft_settings): Likewise.
278
d01ba2f1
GM
2792012-07-09 Glenn Morris <rgm@gnu.org>
280
281 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
282 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
283 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
284 * nsterm.h (ns_etc_directory): Add it.
285 * callproc.c [HAVE_NS]: Include nsterm.h.
286 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
287
f1f924b6
DA
2882012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
289
290 Move marker debugging code under MARKER_DEBUG.
291 * marker.c (MARKER_DEBUG): Move marker debugging code under
292 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
293 for bootstrap with --enable-checking (~3x slowdown reported
294 by Juanma Barranquero <lekktu@gmail.com>).
295 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
296
ab531b66
PE
2972012-07-08 Paul Eggert <eggert@cs.ucla.edu>
298
299 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
300 See <http://bugs.gnu.org/11825#29>.
301
c4b3bc8a
EZ
3022012-07-08 Eli Zaretskii <eliz@gnu.org>
303
304 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
305 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
306 (display_line): Add commentary about displaying truncation glyphs
307 on GUI frames.
308 (produce_special_glyphs): Move here from term.c.
309
310 * term.c (produce_special_glyphs): Move to xdisp.c.
311
312 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
313 section.
c4b3bc8a 314
b676b881
AS
3152012-07-07 Andreas Schwab <schwab@linux-m68k.org>
316
f17c5273
AS
317 * xdisp.c (display_line): Avoid warning about implicit declaration
318 of FRAME_FONT.
319
298819b9
AS
320 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
321
b676b881
AS
322 * lisp.h: Remove empty conditional.
323
6045c4fd
PE
3242012-07-07 Paul Eggert <eggert@cs.ucla.edu>
325
b3350bf9
PE
326 * lread.c (load_path_check): Now static.
327
6045c4fd
PE
328 Fix some minor --with-ns problems found by static checking.
329 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
330 (x_set_font) [!HAVE_X_WINDOWS]:
331 * image.c (xpm_load_image) [HAVE_NS]:
332 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
333 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
334 Remove unused local.
335 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
336 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
337 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
338 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
339 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
340 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
341 Fix pointer signedness problem.
342 * xfaces.c (FRAME_X_FONT_TABLE):
343 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
344
929e7845
GM
3452012-07-07 Glenn Morris <rgm@gnu.org>
346
347 * lread.c (load_path_check): New function, split from init_lread.
348 (init_lread): Reorganize. Motivation:
349 If EMACSLOADPATH is set, check/warn about that rather than the
350 defaults, which we are not going to use. Hence we can remove
351 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
352 Don't warn if site-lisp directories are missing.
353 If not installed, start from a blank load-path, since
354 PATH_LOADSEARCH refers to the eventual installation directories.
355
58dd0aa4
EZ
3562012-07-07 Eli Zaretskii <eliz@gnu.org>
357
358 Support truncation and continuation glyphs on GUI frames, when
359 fringes are disabled. (Bug#11832)
360 * xdisp.c (init_iterator): Get dimensions of truncation and
361 continuation glyphs even if on GUI frames. Adjust
362 it->last_visible_x on GUI frames when the left or right fringes,
363 or both, are absent.
364 (start_display, move_it_in_display_line_to): Handle the case of a
365 GUI frame without a fringe to display continuation or truncation
366 glyphs.
367 (insert_left_trunc_glyphs): Support GUI frames: make sure
368 truncation glyphs overwrite enough glyphs from the current line to
369 have sufficient space in pixels.
370 (display_line): Support truncation and continuation glyphs on GUI
371 frames. If some spare pixels are left on the line after inserting
372 the truncation glyphs, fill that space with a stretch glyph of a
373 suitably computed width.
374
375 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
376 produce_glyphs, to support GUI sessions.
377
31571fd7
PE
3782012-07-07 Paul Eggert <eggert@cs.ucla.edu>
379
5a16b9bc
PE
380 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
381
f3047c75
PE
382 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
383
31571fd7
PE
384 Do not require float-time's arg to fit in time_t (Bug#11825).
385 This works better on hosts where time_t is unsigned, and where
386 float-time is applied to the (negative) difference between two times.
387 * editfns.c (decode_time_components): Last arg is now double *,
388 not int *, and means to store all the result as a double, without
389 worrying about whether the seconds part fits in time_t.
390 All callers changed.
391 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
392 All callers changed.
393 (Ffloat_time): Do not fail merely because the specified time falls
394 outside of time_t range.
395
4516fbef
GM
3962012-07-07 Glenn Morris <rgm@gnu.org>
397
398 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
399 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
400 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
401
07adc2c6
JB
4022012-07-07 Juanma Barranquero <lekktu@gmail.com>
403
404 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
405 Update dependencies.
406
407 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
408
fd573f31
PE
4092012-07-06 Paul Eggert <eggert@cs.ucla.edu>
410
fee5959d
PE
411 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
412 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
413 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
414 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
415 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
416 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
417
fd573f31
PE
418 * xfont.c (compare_font_names): Redo to omit the need for casts.
419
ddadbc0e
AS
4202012-07-06 Andreas Schwab <schwab@linux-m68k.org>
421
fca8d6b6
AS
422 * xfns.c (Fx_change_window_property): Doc fix.
423 * w32fns.c (Fx_change_window_property): Doc fix.
424
ddadbc0e
AS
425 * w32fns.c (Fx_window_property): Accept the same arguments as the
426 X Windows version. Doc fix.
427 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
428
f247498e
JB
4292012-07-06 Juanma Barranquero <lekktu@gmail.com>
430 Eli Zaretskii <eliz@gnu.org>
431
432 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
433 Windows-specific code from nt/config.nt moved here.
434 Obsolete settings removed.
435
216ee680
PE
4362012-07-06 Paul Eggert <eggert@cs.ucla.edu>
437
438 * process.c: Avoid unnecessary calls to gettime.
439 (wait_reading_process_output): Don't get the time of day
440 when gobbling data immediately and not waiting, as there's no need
441 for it in that case. This removes a FIXME.
442
bdd091e4
JD
4432012-07-06 Jan Djärv <jan.h.d@swipnet.se>
444
445 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
446 is defined (Bug#11768).
447
9d44f8ce
DA
4482012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
449
450 Fix marker debugging code.
451 * marker.c (byte_char_debug_check): Do not perform the check
452 if buffer is not multibyte.
090bd7cb
JB
453 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
454 Call byte_char_debug_check with correct arguments.
9d44f8ce 455
90fc4786
DA
4562012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
457
458 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
459 * marker.c (byte_char_debug_check, count_markers):
460 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
461 (byte_debug_flag): Remove.
462 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
463 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
464
7b7ae965
DA
4652012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
466
4e57b342
DA
467 Avoid code repetition in marker-related functions.
468 * marker.c (attach_marker): New function.
469 (Fset_marker, set_marker_restricted, set_marker_both)
470 (set_marker_restricted_both): Use it.
471 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
472 Consistently rename charno to charpos.
473 (marker_position): Add eassert.
474 (marker_byte_position): Convert to eassert.
475
4762012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
477
478 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 479 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 480 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 481
657924ff
DA
4822012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
483
484 Introduce fast path for the widely used marker operation.
485 * alloc.c (build_marker): New function.
486 * lisp.h (build_marker): New prototype.
487 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
488 * composite.c (autocmp_chars): Likewise.
489 * editfns.c (buildmark): Remove.
490 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
491 (save_restriction_save): Use build_marker.
492 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
493 * window.c (save_window_save): Likewise.
494
041a49a6
DA
4952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
496
497 Do not use Fdelete_overlay in delete_all_overlays
498 to avoid redundant calls to unchain_overlay.
499 * buffer.c (drop_overlay): New function.
500 (delete_all_overlays, Fdelete_overlay): Use it.
501 * minibuf.c (get_minibuffer): Fix comment.
502
7dca65a4
PE
5032012-07-06 Paul Eggert <eggert@cs.ucla.edu>
504
505 Port to OpenBSD 5.1 amd64.
506 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
507 This is needed for OpenBSD, and should be harmless on all BSD systems.
508 Also, include <sys/sysctl.h>, as it should be available on all
509 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
510 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
511 use p_pid member, not kp_proc.pid.
512
8eb876e2
GM
5132012-07-06 Glenn Morris <rgm@gnu.org>
514
515 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
516
38182d90
PE
5172012-07-05 Paul Eggert <eggert@cs.ucla.edu>
518
519 More xmalloc and related cleanup.
520 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
521 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
522 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
523 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
524 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
525 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
526 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
527 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
528 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
529 * xterm.c:
530 Omit needless casts involving void * pointers and allocation.
531 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
532 as the former is more robust if P's type is changed.
533 Prefer xzalloc to xmalloc + memset 0.
534 Simplify malloc-or-realloc to realloc.
535 Don't worry about xmalloc returning a null pointer.
536 Prefer xstrdup to xmalloc + strcpy.
537 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
538 growing it.
539 * keyboard.c (apply_modifiers_uncached): Prefer local array to
540 alloca of a constant.
541
6dd5a677
EZ
5422012-07-05 Eli Zaretskii <eliz@gnu.org>
543
544 * xdisp.c (display_line): Fix horizontal pixel coordinates when
545 hscroll is larger than the line width. Fixes long and futile
546 looping inside extend_face_to_end_of_line (on a TTY) producing
547 glyphs that are not needed and thrown away.
548
6b312f0f
DA
5492012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
550
551 * marker.c (set_marker_restricted_both): Simplify by using
552 clip_to_bounds.
553
f520ef9b
PE
5542012-07-05 Paul Eggert <eggert@cs.ucla.edu>
555
556 * editfns.c (region_limit): Simplify by using clip_to_bounds.
557
383b7c95
JD
5582012-07-05 Jan Djärv <jan.h.d@swipnet.se>
559
560 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
561 not defined (Bug#11768).
562 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
563 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
564 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
565 followed by gtk_box_set_homogeneous (Bug#11768).
566 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
567 (update_theme_scrollbar_width, xg_create_scroll_bar):
568 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
569 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
570 (is_box_type): New function (Bug#11768).
571 (xg_tool_item_stale_p): Call is_box_type.
5293d758 572 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
573 with default display (Bug#11768).
574
d6e7bf45
EZ
5752012-07-05 Eli Zaretskii <eliz@gnu.org>
576
577 * xdisp.c (window_hscroll_limited): New function.
578 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
579 coordinates when window's hscroll is set to insanely large
580 values. (Bug#11857)
581
431391ec
JB
5822012-07-05 Juanma Barranquero <lekktu@gmail.com>
583
584 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
585 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
586
23f86fce
DA
5872012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
588
589 Cleanup xmalloc.
590 * lisp.h (xzalloc): New prototype. Omit needless casts.
591 * alloc.c (xzalloc): New function. Omit needless casts.
592 * charset.c: Omit needless casts. Convert all calls to
593 xmalloc with following memset to xzalloc.
594 * dispnew.c: Likewise.
595 * fringe.c: Likewise.
596 * image.c: Likewise.
597 * sound.c: Likewise.
598 * term.c: Likewise.
599 * w32fns.c: Likewise.
600 * w32font.c: Likewise.
601 * w32term.c: Likewise.
602 * xfaces.c: Likewise.
603 * xfns.c: Likewise.
604 * xterm.c: Likewise.
605 * atimer.c: Omit needless casts.
606 * buffer.c: Likewise.
607 * callproc.c: Likewise.
608 * ccl.c: Likewise.
609 * coding.c: Likewise.
610 * composite.c: Likewise.
611 * doc.c: Likewise.
612 * doprnt.c: Likewise.
613 * editfns.c: Likewise.
614 * emacs.c: Likewise.
615 * eval.c: Likewise.
616 * filelock.c: Likewise.
617 * fns.c: Likewise.
618 * gtkutil.c: Likewise.
619 * keyboard.c: Likewise.
620 * lisp.h: Likewise.
621 * lread.c: Likewise.
622 * minibuf.c: Likewise.
623 * msdos.c: Likewise.
624 * print.c: Likewise.
625 * process.c: Likewise.
626 * region-cache.c: Likewise.
627 * search.c: Likewise.
628 * sysdep.c: Likewise.
629 * termcap.c: Likewise.
630 * terminal.c: Likewise.
631 * tparam.c: Likewise.
632 * w16select.c: Likewise.
633 * w32.c: Likewise.
634 * w32reg.c: Likewise.
635 * w32select.c: Likewise.
636 * w32uniscribe.c: Likewise.
637 * widget.c: Likewise.
638 * xdisp.c: Likewise.
639 * xmenu.c: Likewise.
640 * xrdb.c: Likewise.
641 * xselect.c: Likewise.
642
0497dc44
PE
6432012-07-05 Paul Eggert <eggert@cs.ucla.edu>
644
645 * fileio.c (time_error_value): Check the right error number.
646 Problem reported by Troels Nielsen in
647 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
648
356e7178
PE
6492012-07-04 Paul Eggert <eggert@cs.ucla.edu>
650
4e71fd89
PE
651 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
652 This should be fixed in a better way; see Eli Zaretskii in
653 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
654 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
655
f0941253
PE
656 * fileio.c (time_error_value): Rename from special_mtime.
657 The old name's problems were noted by Eli Zaretskii in
658 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
659
065c9eb4
PE
660 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
661 This variable's comment says Emacs needs at least one GDB-visible
662 symbol of type enum pvec_type, to work around GDB problems.
663 The symbol's value doesn't matter.
664
356e7178
PE
665 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
666 that causes compilation to fail on pre-C99 compilers.
667
95f61aa2
JB
6682012-07-04 Juanma Barranquero <lekktu@gmail.com>
669
670 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
671 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
672
3884d954
DA
6732012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
674
d209e2fb 675 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
676 headers for buffer_defaults and buffer_local_symbols.
677 Reported by Juanma Barranquero <lekktu@gmail.com>.
678
ee28be33
SM
6792012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
680
681 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
682 * lisp.h (enum pvec_type): Use fewer bits.
683 (PSEUDOVECTOR_SIZE_BITS): New constant.
684 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
685 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
686 change in pvec_type.
687 (PSEUDOVECTOR_TYPEP): New macro.
688 (TYPED_PSEUDOVECTORP): Use it.
689 * fns.c (internal_equal): Adapt code to extract pvectype.
690 * emacs.c (gdb_pvec_type): Update type.
691 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
692 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
693 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
694 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
695 (sweep_vectors): Use it. Use local var `total_bytes' instead of
696 abusing vector->header.next.nbytes.
697 (live_vector_p): Use PVEC_TYPE.
698 (mark_object): Adapt code to extract pvectype. Use switch.
699
c7f2cd7f
PE
7002012-07-04 Paul Eggert <eggert@cs.ucla.edu>
701
702 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
703 Tighten new eassert a bit.
704
8ce70ed2
DA
7052012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
706
707 Fix compilation with --enable-gcc-warnings and -O1
708 optimization level.
709 * doprnt.c (doprnt): Change type of tem to int, initialize
710 to avoid compiler warning. Add eassert.
711 * search.c (simple_search): Initialize match_byte to avoid
712 compiler warning. Add eassert.
713
dea7f1e5
PE
7142012-07-04 Paul Eggert <eggert@cs.ucla.edu>
715
24a212eb
PE
716 Avoid weird behavior with large horizontal scrolls.
717 Without this change, for example, large hscroll values would
718 mess up Emacs's display on Fedora 15 x86, presumably due to
719 overflows in int calculations in the display code.
720 Also, if buffers had long lines, Emacs would freeze.
721 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
722 (set_window_hscroll): New function, containing the old guts of
723 Fset_window_hscroll. Return the clipped value.
724 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
725 This avoids the need to check against PTRDIFF_MAX.
726
dea7f1e5
PE
727 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
728
76046526
DA
7292012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
730
731 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
732
39adff0d
PE
7332012-07-04 Paul Eggert <eggert@cs.ucla.edu>
734
63807d47
PE
735 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
736 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
737 since GCC 4.4.6 issues a bogus warning for them.
738
39adff0d
PE
739 Fix bugs in file timestamp newness comparisons.
740 * fileio.c (Ffile_newer_than_file_p):
741 * lread.c (Fload): Use full timestamp resolution of files,
742 not just the 1-second resolution, so that files that are only
743 slightly newer still count as newer.
744 * fileio.c (Ffile_newer_than_file_p): Don't assume file
745 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
746
dbeed9a6
PE
7472012-07-03 Paul Eggert <eggert@cs.ucla.edu>
748
749 * fileio.c: Improve handling of file time marker. (Bug#11852)
750 (special_mtime): New function.
751 (Finsert_file_contents, Fverify_visited_file_modtime):
752 Use it to set special mtime values consistently.
753
636334d6
AS
7542012-07-03 Andreas Schwab <schwab@linux-m68k.org>
755
756 * fileio.c (Finsert_file_contents): Properly handle st_mtime
757 marker for non-existing file. (Bug#11852)
758
e2017fe2
GM
7592012-07-03 Glenn Morris <rgm@gnu.org>
760
761 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
762 and did not make it into globals.h).
763
404dbd37
TT
7642012-07-03 Tom Tromey <tromey@redhat.com>
765
766 * window.c (Fset_window_margins, Fset_window_fringes)
767 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
768 * textprop.c (Fprevious_property_change): No longer static.
769 * syntax.c (Fsyntax_table_p): No longer static.
770 * process.c (Fget_process, Fprocess_datagram_address): No longer
771 static.
772 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
773 * keyboard.c (Fcommand_execute): No longer static.
774 Remove EXFUN.
775 * insdel.c (Fcombine_after_change_execute): No longer static.
776 * image.c (Finit_image_library): No longer static.
777 * fileio.c (Fmake_symbolic_link): No longer static.
778 * eval.c (Ffetch_bytecode): No longer static.
779 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
780 * doc.c (Fdocumentation_property, Fsnarf_documentation):
781 No longer static.
404dbd37
TT
782 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
783 static.
784 * dired.c (Ffile_attributes): No longer static.
785 * composite.c (Fcomposition_get_gstring): No longer static.
786 * callproc.c (Fgetenv_internal): No longer static.
787
788 * ccl.h: Remove EXFUNs.
789 * buffer.h: Remove EXFUNs.
790 * dispextern.h: Remove EXFUNs.
791 * intervals.h: Remove EXFUNs.
792 * fontset.h: Remove EXFUN.
793 * font.h: Remove EXFUNs.
794 * dosfns.c (system_process_attributes): Remove EXFUN.
795 * keymap.h: Remove EXFUNs.
796 * lisp.h: Remove EXFUNs.
797 * w32term.h: Remove EXFUNs.
798 * window.h: Remove EXFUNs.
799 * xsettings.h: Remove EXFUN.
800 * xterm.h: Remove EXFUN.
801
8e4fd1e1
GM
8022012-07-03 Glenn Morris <rgm@gnu.org>
803
804 * lisp.h (Frandom): Make it visible to C.
805 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
806 buffer for invisible buffers. (Bug#1229)
807
ca95b3eb
DA
8082012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
809
810 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
811 values which aren't power of 2.
812 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
813 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
814 accordingly.
815
7555c33f
SM
8162012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
817
818 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
819
820 * alloc.c (mark_object): Revert part of last patch to use `switch'.
821
d12e8f5a
DA
8222012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
823
824 * alloc.c (allocate_vector_block): Remove redundant
825 calls to mallopt if DOUG_LEA_MALLOC is defined.
826 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
827 avoid calls to mallopt if zero_vector is returned.
828
296094c3
DA
8292012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
830
831 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
832 is enabled, avoid dereferencing NULL current_sblock if
833 running undumped.
834
36429c89
DA
8352012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
836
837 Cleanup basic buffer management.
838 * buffer.h (struct buffer): Change layout to use generic vector
839 marking code. Fix some comments. Change type of 'clip_changed'
840 to bitfield. Remove unused #ifndef old.
841 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
842 (GET_OVERLAYS_AT): Fix indentation.
843 (for_each_per_buffer_object_at): New macro.
844 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
845 (Fbuffer_local_variables): Use it.
846 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
847 * alloc.c (allocate_buffer): Adjust to match new layout of
848 struct buffer. Fix comment.
849 (mark_overlay): New function.
850 (mark_buffer): Use it. Use mark_vectorlike to mark normal
851 Lisp area of struct buffer.
852 (mark_object): Use it. Adjust marking of misc objects
853 and related comments.
854
3b3e4cac
PE
8552012-07-02 Paul Eggert <eggert@cs.ucla.edu>
856
857 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
858 wrapper that is not needed because the wrapped code is a no-op (zero
859 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
860 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
861
cf5c0175
DA
8622012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
863
864 * alloc.c (mark_buffer): Simplify. Remove prototype.
865 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 866 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
867 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
868 redundant calls to mark_vectorlike for bool vectors.
869
ca26824c
GM
8702012-06-30 Glenn Morris <rgm@gnu.org>
871
2e4c5312
GM
872 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
873
ca26824c
GM
874 * epaths.in (PATH_SITELOADSEARCH): New.
875 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
876 This is rather than relying on --enable-locallisppath elements
877 having "site-lisp" in their names. (Bug#10208#25, 11658)
878
0d23c240
EZ
8792012-06-30 Eli Zaretskii <eliz@gnu.org>
880
c9240d7a
EZ
881 * w32proc.c (sys_select): Accept and ignore one more argument.
882
883 * w32.c (emacs_gnutls_pull): Call select with one more argument.
884
0d23c240 885 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 886 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
887
888 * sysdep.c: Don't include dos.h and dosfns.h.
889
890 * process.c (sys_select):
891 * msdos.c (sys_select): Accept one more argument and ignore it.
892
893 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
894 adapt data types and code to that.
895
896 * dosfns.c:
897 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
898 which clashes with the gnulib function of the same name.
899
af5a5a98
AS
9002012-06-30 Andreas Schwab <schwab@linux-m68k.org>
901
c5e4379c
AS
902 * font.c (font_style_to_value, font_style_symbolic)
903 (font_prop_validate_style): Add type checks for values in
904 font_style_table.
905
af5a5a98
AS
906 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
907 argument.
908 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
909 uses.
910
8d38f461
EZ
9112012-06-29 Eli Zaretskii <eliz@gnu.org>
912
2e5a6631
EZ
913 * xdisp.c (try_window_id): Undo last change.
914
8d38f461
EZ
915 * w32.c (getwd): Adjust commentary about startup_dir.
916 (init_environment): Always call sys_access, even in non-MSVC
917 builds. Don't chdir to the directory of the Emacs executable.
918 This undoes code from 1997 which was justified by the need to
919 "avoid conflicts when removing and renaming directories". But its
920 downside was that every relative file name was being interpreted
921 relative to the directory of the Emacs executable, which can never
922 be TRT. In particular, it broke sys_access when called with
923 relative file names.
924 (sys_access): Map GetLastError to errno.
925
2af3565e
DA
9262012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
927
928 * window.h (struct window): Change type of 'fringes_outside_margins'
929 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 930 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
931 Adjust comment.
932 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
933 to ptrdiff_t.
934
c8d3a25c 9352012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 936
c8d3a25c
GM
937 * gnutls.c (emacs_gnutls_handshake):
938 Add QUIT to make the loop interruptible.
57570cd3 939
c8d3a25c 9402012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 941
c8d3a25c
GM
942 * charset.c (init_charset): Make lack of etc/charsets fatal.
943
3e984ee8
DA
9442012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
945
946 * editfns.c (region_limit): Fix type mismatch.
947
ef884f23
DA
9482012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
949
950 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
951 undefined. Convert from xassert to eassert.
952 * nsmenu.m: Convert from xassert to eassert.
953 * nsterm.m: Likewise.
954
7d7e0027
SM
9552012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
956
957 * editfns.c (region_limit): Clip to narrowing (bug#11770).
958
aa754e6a
PE
9592012-06-28 Paul Eggert <eggert@cs.ucla.edu>
960
961 Avoid integer overflow on scroll-left and scroll-right.
962 * window.c (HSCROLL_MAX): New macro.
963 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
964 overflow when requested scroll falls outside ptrdiff_t range.
965
80b00b08
DA
9662012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
967
968 * window.h (struct window): Change type of 'hscroll',
969 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
970 'last_modified' and 'last_overlay_modified' to EMACS_INT.
971 Adjust users accordingly.
972 * xdisp.c (try_cursor_movement): Replace type check with eassert.
973 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
974 from EMACS_INT to ptrdiff_t.
975 (make_window): Omit redundant initialization.
976
62b2bcf6
JB
9772012-06-28 Juanma Barranquero <lekktu@gmail.com>
978
979 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
980
45942c7d
DA
9812012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
982
983 * window.h (struct window): Change type of 'use_time' and
984 'sequence_number' from Lisp_Object to int.
985 * frame.c (make_frame): Adjust users accordingly.
986 * print.c (print_object): Likewise.
987 * window.c (select_window, Fwindow_use_time, make_parent_window)
988 (make_window): Likewise.
989
e509cfa6
DA
9902012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
991
992 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
993 enabled with --enable-checking=[all,glyphs] configure option.
994 Fix GLYPH_DEBUG usage assuming that it may be undefined,
995 adjust comments accordingly.
996 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
997 undefined, adjust comments accordingly.
998 * image.c: Likewise.
999 * scroll.c: Likewise.
1000 * w32fns.c: Likewise.
1001 * w32term.c: Likewise.
1002 * xdisp.c: Likewise.
1003 * xfaces.c: Likewise.
1004 * xfns.c: Likewise.
1005 * xterm.c: Likewise.
1006
a54e2c05
DA
10072012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1008
1009 Generalize run-time debugging checks.
1010 * dispextern.h (XASSERTS): Remove.
1011 * fontset.c (xassert): Remove.
1012 Convert from xassert to eassert.
1013 * alloc.c: Convert from xassert to eassert.
1014 * bidi.c: Likewise.
1015 * dispnew.c: Likewise.
1016 * fns.c: Likewise.
1017 * fringe.c: Likewise.
1018 * ftfont.c: Likewise.
1019 * gtkutil.c: Likewise.
1020 * image.c: Likewise.
1021 * keyboard.c: Likewise.
1022 * menu.c: Likewise.
1023 * process.c: Likewise.
1024 * scroll.c: Likewise.
1025 * sound.c: Likewise.
1026 * term.c: Likewise.
1027 * w32console.c: Likewise.
1028 * w32fns.c: Likewise.
1029 * w32term.c: Likewise.
1030 * window.c: Likewise.
1031 * xdisp.c: Likewise.
1032 * xfaces.c: Likewise.
1033 * xfns.c: Likewise.
1034 * xselect.c: Likewise.
1035 * xterm.c: Likewise.
1036
1ec4b7b2
SM
10372012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1038
1039 * fns.c (maybe_resize_hash_table): Output message when growing the
1040 purify-hashtable.
1041
2014308a
DA
10422012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1043
1044 * alloc.c (allocate_string_data): Remove dead code.
1045 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1046 avoid GCC warning about unused macro.
1047
246155eb
DA
10482012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1049
1050 * alloc.c (allocate_string): Omit intervals initialization.
1051 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1052 as in make_pure_string and make_pure_c_string.
1053
43184b7b
DA
10542012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1055
d209e2fb 1056 * alloc.c (allocate_string): Fix last change.
43184b7b 1057
3fe6dd74
DA
10582012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1059
d209e2fb 1060 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1061 to memset, add explicit initialization where appropriate.
1062
1ba6038a
GM
10632012-06-27 Glenn Morris <rgm@gnu.org>
1064
1065 * lisp.mk (lisp): Remove paths.elc.
1066
c89926a5
CY
10672012-06-27 Chong Yidong <cyd@gnu.org>
1068
1069 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1070
ed6b3510
JW
10712012-06-26 John Wiegley <johnw@newartisans.com>
1072
1ec4b7b2 1073 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1074 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1075
ed6b3510
JW
1076 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1077 when building with Clang.
1078
8edd4a2b
SM
10792012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1080
1081 * eval.c (Fapply): Allow calling it with a single argument.
1082
f6f62d1b
EZ
10832012-06-26 Eli Zaretskii <eliz@gnu.org>
1084
1085 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1086 _stricmp and _strnicmp.
1087 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1088
62efea5e
DA
10892012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1090
1091 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1092 allocated window.
1093 (allocate_process): Likewise for new process.
8edd4a2b 1094 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1095 (allocate_frame): Likewise.
1096 * frame.c (make_frame): Omit redundant initialization.
1097 * window.c (make_parent_window): Use memset.
1098 (make_window): Omit redundant initialization.
1099 * process.c (make_process): Omit redundant initialization.
1100 * terminal.c (create_terminal): Likewise.
1101
42997f4d
DA
11022012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1103
1104 * term.c (delete_tty): Remove redundant call to memset.
1105
1130ecfc
DA
11062012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1107
1108 * alloc.c: Remove build_string.
1109 * lisp.h: Define build_string as static inline. This provides
1110 a better opportunity to optimize away calls to strlen when the
1111 function is called with compile-time constant argument.
1112 * image.c (imagemagick_error): Convert to build_string.
1113 * w32proc.c (sys_spawnve): Likewise.
1114 * xterm.c (x_term_init): Likewise.
1115
cf38a720
PE
11162012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1117
99027bdd
PE
1118 Use sprintf return value instead of invoking strlen on result.
1119 In the old days this wasn't portable, since some sprintf
1120 implementations returned char *. But they died out years ago and
1121 Emacs already assumes sprintf returns int.
1122 Similarly for float_to_string.
1123 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1124 * ccl.c (ccl_driver):
1125 * character.c (string_escape_byte8):
1126 * data.c (Fnumber_to_string):
1127 * doprnt.c (doprnt):
1128 * print.c (print_object):
1129 * xdisp.c (message_dolog):
1130 * xfns.c (syms_of_xfns):
1131 Use sprintf or float_to_string result to avoid need to call strlen.
1132 * data.c (Fnumber_to_string):
1133 Use make_unibyte_string, since the string must be ASCII.
1134 * lisp.h, print.c (float_to_string): Now returns int length.
1135 * term.c (produce_glyphless_glyph):
1136 Use sprintf result rather than recomputing it.
1137
cf38a720
PE
1138 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1139 * Makefile.in (ALL_CFLAGS):
1140 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1141 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1142
3511c784
DA
11432012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1144
0a08eb21 1145 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1146 strcasecmp if available.
1147 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1148
fb7da12e
AS
11492012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1150
1151 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1152 Avoid comma operator.
1153 * menu.c (push_submenu_start, push_submenu_end)
1154 (push_left_right_boundary, push_menu_pane): Likewise.
1155 * msdos.c (dos_rawgetc): Likewise.
1156
afa2ffd8
DA
11572012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1158
1159 * xfns.c (xic_create_fontsetname): Remove redundant calls
1160 to memset.
1161
b3b4476b
PE
11622012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1163
4495ff38
PE
1164 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1165 sprintf already null-terminates its output.
1166
b3b4476b
PE
1167 * xfns.c (x_window): Remove redundant cast.
1168
b00876c9
DA
11692012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1170
1171 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1172 `const char *' to `char *' to avoid compiler warning.
1173
d188e26b
PE
11742012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1175
885d1d74
PE
1176 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1177 instead of truncating it to 63 (admittedly a generous limit).
1178
d188e26b
PE
1179 * process.c: Fix spelling and caps in comments.
1180
e2f560b1
DN
11812012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1182
e86db54b 1183 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1184 * sysdep.c (setpgrp): Remove definition, not used in this file.
1185
7583a3a1
JB
11862012-06-24 Juanma Barranquero <lekktu@gmail.com>
1187
1188 * makefile.w32-in: Update dependencies.
1189
696056c2
EZ
11902012-06-24 Eli Zaretskii <eliz@gnu.org>
1191
1192 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1193 (SYSTIME_H): Add nt/inc/sys/time.h.
1194
1195 * systime.h [WINDOWSNT]: Include sys/time.h.
1196
1197 * s/ms-w32.h (struct timespec): Definition moved from
1198 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1199
845ca893
PE
12002012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1201
1202 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1203 * buffer.h (buffer_slot_type_mismatch):
1204 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1205 * eval.c (unwind_to_catch):
1206 * image.c (my_png_error, my_error_exit):
1207 * keyboard.c (quit_throw_to_read_char, user_error)
1208 (Fexit_recursive_edit, Fabort_recursive_edit):
1209 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1210 (wrong_type_argument, buffer_overflow, __executable_start)
1211 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1212 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1213 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1214 (fatal):
1215 (child_setup) [!DOS_NT]:
1216 * lread.c (end_of_file_error, invalid_syntax):
1217 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1218 * puresize.h (pure_write_error):
1219 * search.c (matcher_overflow):
1220 * sound.c (sound_perror, alsa_sound_perror):
1221 * sysdep.c, syssignal.h (croak):
1222 * term.c (maybe_fatal, vfatal):
1223 * textprop.c (text_read_only):
1224 * undo.c (user_error):
1225 * unexmacosx.c (unexec_error):
1226 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1227 Use _Noreturn rather than NO_RETURN.
1228 No need for separate decl merely because of _Noreturn.
1229 * sound.c (sound_warning, parse_sound):
1230 Remove unnecessary forward decls.
1231
f1dd8073
PE
12322012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1235 * lisp.h (WAIT_READING_MAX): New macro.
1236 * dispnew.c (Fsleep_for, sit_for):
1237 * keyboard.c (kbd_buffer_get_event):
1238 * process.c (Faccept_process_output):
1239 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1240 This improves on the previous patch, which introduced a bug
1241 when time_t is unsigned and as wide as intmax_t.
1242 See <http://bugs.gnu.org/9000#51>.
1243
b82c1755
EZ
12442012-06-23 Eli Zaretskii <eliz@gnu.org>
1245
1246 * dispnew.c (sit_for, Fsleep_for):
1247 * keyboard.c (kbd_buffer_get_event):
1248 * process.c (Faccept_process_output): Avoid compiler warnings when
1249 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1250
ca300656
JB
12512012-06-23 Juanma Barranquero <lekktu@gmail.com>
1252
049ec95b
JB
1253 * makefile.w32-in: Update dependencies.
1254
ca300656
JB
1255 * w32.c (ltime): Add return type and declare static.
1256 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1257
db7b8d06
PE
12582012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1261 Privately reported by Herbert J. Skuhra.
1262 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1263 All uses changed.
1264 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1265 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1266
0bd8297f
EZ
12672012-06-23 Eli Zaretskii <eliz@gnu.org>
1268
96512555
EZ
1269 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1270 last argument of make_unibyte_string.
1271
0bd8297f
EZ
1272 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1273 language ID in the event parameters.
1274
1275 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1276 event.code, not the obscure "character set ID".
1277
63def6b6
CY
12782012-06-23 Chong Yidong <cyd@gnu.org>
1279
1280 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1281
e8a02204
EZ
12822012-06-23 Eli Zaretskii <eliz@gnu.org>
1283
388cdec0
EZ
1284 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1285 * w32.c (fdutimens): New function.
1286
1287 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1288
1289 * s/ms-w32.h (pselect): Redirect to sys_select.
1290
1291 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1292
e8a02204
EZ
1293 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1294 in the logic of incrementing and decrementing the value of
1295 use_relocatable_buffers.
1296
d054f3fb
PE
12972012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1298
1299 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1300 Privately reported by Herbert J. Skuhra.
1301 [__FreeBSD__]: Remove "*/" typo after "#include".
1302 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1303 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1304 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1305 Don't assume EMACS_TIME and struct timeval are the same type.
1306
d35af63c
PE
13072012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1308
1309 Support higher-resolution time stamps (Bug#9000).
1310 The time stamps are only nanosecond-resolution at the C level,
1311 since that's the best that any real-world system supports now.
1312 But they are picosecond-resolution at the Lisp level, as that's
1313 easy, and leaves room for future OS improvements.
1314
1315 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1316 (LIBES): Use it.
1317
1318 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1319 Don't get current time unless it's needed.
1320
1321 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1322 now provides it if it's absent.
1323 (start_atimer): Port to higher-res time stamps.
1324 Check for time stamp overflow. Don't get current time more
1325 often than is needed.
1326
1327 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1328 Include systime.h, not time.h.
1329 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1330
1331 * dired.c: Include stat-time.h.
1332 (Ffile-attributes): File times now have higher resolution.
1333
1334 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1335 (struct image): Timestamp now has higher resolution.
1336
1337 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1338 has at least microseconds now. All uses removed.
1339 (update_frame, update_single_window, update_window, update_frame_1)
1340 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1341
1342 * editfns.c (time_overflow): Now extern.
1343 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1344 (float-time, Fformat_time_string, Fcurrent_time_string)
1345 (Fcurrent_time_zone): Accept and generate higher-resolution
1346 time stamps.
1347 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1348 (decode_time_components, lisp_seconds_argument): New functions.
1349 (make_time): Now static.
1350 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1351 Report an error if the time is invalid, rather than having the caller
1352 do that.
1353
1354 * fileio.c: Include <stat-time.h>
1355 (Fcopy_file): Copy higher-resolution time stamps.
1356 Prefer to set the time stamp via a file descriptor if that works.
1357 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1358 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1359 (Fvisited_file_modtime, Fset_visited_file_modtime):
1360 Support higher-resolution time stamps.
1361
1362 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1363
1364 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1365
1366 * image.c (prepare_image_for_display, clear_image_cache)
1367 (lookup_image): Port to higer-resolution time stamps.
1368
1369 * keyboard.c (start_polling, bind_polling_period):
1370 Check for time stamp overflow.
1371 (read_char, kbd_buffer_get_event, timer_start_idle)
1372 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1373 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1374 Port to higher-resolution time stamps. Do not assume time_t is signed.
1375 (decode_timer): New function. Timers are now vectors of length 9,
1376 not 8, to accommodate the picosecond component.
1377 (timer_check_2): Use it.
1378
1379 * nsterm.m (select_timeout, timeval_subtract): Remove.
1380 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1381 as they're a bit more accurate and handle overflow better.
1382 (ns_select): Change prototype to be compatible with pselect.
1383 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1384 * nsterm.h (ns_select): Adjust prototype.
1385
1386 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1387 us-resolution time stamps.
1388 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1389
1390 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1391
1392 * lisp.h (time_overflow): New decl.
1393 (wait_reading_process_output): First arg is now intmax_t, not int,
1394 to accommodate larger waits.
1395
1396 * process.h (struct Lisp_Process.read_output_delay):
1397 Now counts nanoseconds, not microseconds.
1398 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1399 EMACS_HAS_USECS.
1400 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1401 (wait_reading_process_output):
1402 Port to ns-resolution time stamps.
1403 (Faccept_process_output, wait_reading_process_output):
1404 Check for time stamp overflow. Do not assume time_t is signed.
1405 (select_wrapper): Remove; we now use pselect.
1406 (Fprocess_attributes): Now generates ns-resolution time stamps.
1407
1408 * sysdep.c: Include utimens.h. Don't include utime.h
1409 or worry about struct utimbuf; gnulib does that for us now.
1410 (gettimeofday): Remove; gnulib provides a substitute.
1411 (make_timeval): New function.
1412 (set_file_times): Now sets ns-resolution time stamps.
1413 New arg FD; all uses changed.
1414 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1415 (system_process_attributes):
1416 Now returns ns-resolution time stamp. All uses changed.
1417 Check for time stamp overflow.
1418
1419 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1420 provides a substitute now.
1421
1422 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1423 since it guarantees struct timespec.
1424 (EMACS_TIME): Now struct timespec, so that we can support
1425 ns-resolution time stamps.
1426 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1427 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1428 (EMACS_USECS): Remove.
1429 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1430 so multiply the arg by 1000 before storing it.
1431 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1432 New macros.
1433 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1434 Port to ns-resolution time stamps.
1435 (EMACS_TIME_NEG_P): Remove; replaced by....
1436 (EMACS_TIME_SIGN): New macro.
1437 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1438 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1439 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1440 (make_timeval, make_lisp_time, decode_time_components): New decls.
1441 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1442 that it mishandled time_t overflow. You can't compare by subtracting!
1443 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1444 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1445
1446 * term.c: Include <sys/time.h>.
1447 (timeval_to_Time): New function, for proper overflow wraparound.
1448 (term_mouse_position, term_mouse_click): Use it.
1449
1450 * undo.c (record_first_change): Support higher-resolution time stamps
1451 in the undo buffer.
1452 (Fprimitive_undo): Use them when restoring time stamps.
1453
1454 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1455 (w32_get_internal_run_time):
1456 Port to higher-resolution Emacs time stamps.
1457 (ltime): Now accepts single 64-bit integer, as that's more convenient
1458 for callers.
1459
1460 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1461
1462 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1463 for compatibility with pselect. Support ns-resolution time stamps.
1464
1465 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1466
1467 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1468 Check for time stamp overflow, and support ns-resolution time stamps.
1469
1470 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1471 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1472 (timeval_subtract): Remove; no longer needed.
1473 (XTflash, XTring_bell, x_wait_for_event):
1474 Port to ns-resolution time stamps. Don't assume time_t is signed.
1475
b6a92dfe
CY
14762012-06-22 Chong Yidong <cyd@gnu.org>
1477
1478 * xdisp.c (x_consider_frame_title): Revert last change.
1479
d251c37c
EZ
14802012-06-22 Eli Zaretskii <eliz@gnu.org>
1481
1482 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1483 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1484 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1485 staticidx goes up to 1597 out of 1600 = 0x640.)
1486
f10deafb
PE
14872012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1488
1489 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1490 Otherwise, the umask might be mistakenly 0 while handling input signals.
1491
ec6de1e2
SM
14922012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1493
1494 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1495
28be1ada
DA
14962012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1497
1498 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1499 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1500 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1501 access to `contents' member of Lisp_Vector objects with AREF and ASET
1502 where appropriate.
1503
c6bf3022
CY
15042012-06-19 Chong Yidong <cyd@gnu.org>
1505
1506 * frame.c (delete_frame): When selecting a frame on a different
1507 text terminal, do not alter the terminal's top-frame.
1508
1509 * xdisp.c (format_mode_line_unwind_data): Record the target
1510 frame's selected window and its terminal's top-frame.
1511 (unwind_format_mode_line): Restore them.
1512 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1513 Callers changed.
1514 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1515 since tty frames can be explicitly named.
1516 (prepare_menu_bars): Likewise.
1517
1518 * term.c (Ftty_top_frame): New function.
1519
defd4196
PE
15202012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1521
1522 Port byte-code-meter to modern targets.
1523 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1524 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1525 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1526 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1527 (METER_1, METER_2): Simplify.
1528
1053a871
SM
15292012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1530
1531 * data.c (Fdefalias): Return `symbol' (bug#11686).
1532
b7e8d081
MR
15332012-06-18 Martin Rudalics <rudalics@gmx.at>
1534
1535 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1536 gets killed during executing of this function (Bug#11665).
1537 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1538 (Vkill_buffer_query_functions): In doc-string say that functions
1539 run by this hook should not change the current buffer.
1540
7ea2b339
PE
15412012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 Fix recently-introduced process.c problems found by static checking.
1544 * process.c (write_queue_push, write_queue_pop, send_process):
1545 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1546 (write_queue_pop): Fix pointer signedness problem.
1547 (send_process): Remove unused local.
1548
96a313a1
CY
15492012-06-17 Chong Yidong <cyd@gnu.org>
1550
1551 * xdisp.c (redisplay_internal): No need to redisplay terminal
1552 frames that are not on top.
1553
20ca2e94
TN
15542012-06-17 Troels Nielsen <bn.troels@gmail.com>
1555
1556 * process.c (make_process): Initialize write_queue.
1557 (write_queue_push, write_queue_pop): New functions.
1558 (send_process): Use them to maintain correct ordering of process
1559 writes (Bug#10815).
1560
9a900ca9
PE
15612012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1562
310fbfa8
PE
1563 * lisp.h (eassert): Assume C89 or later.
1564 This removes the need for CHECK.
1565 (CHECK): Remove. Its comments about always evaluating its
1566 argument were confusing, as 'eassert' typically does not evaluate
1567 its argument.
1568
27bb1ca4
PE
1569 * coding.c (produce_chars): Use ptrdiff_t, not int.
1570
9a900ca9
PE
1571 * xterm.c (x_draw_underwave): Check for integer overflow.
1572 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1573
41b7f8bc 15742012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1575
1576 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1577 referenced (Bug#11583).
1578
9b0e3eba
AA
15792012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1580
1581 Implement wave-style variant of underlining.
1582 * dispextern.h (face_underline_type): New enum.
1583 (face): Add field for underline type.
1584 * nsterm.m (ns_draw_underwave): New function.
1585 (ns_draw_text_decoration): Use it.
1586 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1587 New functions.
1588 (x_draw_glyph_string): Use them.
1589 * xfaces.c (Qline, Qwave): New Lisp objects.
1590 (check_lface_attrs, merge_face_ref)
1053a871
SM
1591 (Finternal_set_lisp_face_attribute, realize_x_face):
1592 Handle wave-style underline face attributes.
9b0e3eba
AA
1593 * xterm.c (x_draw_underwave): New function.
1594 (x_draw_glyph_string): Use it.
1595
0fb52f11
JB
15962012-06-16 Juanma Barranquero <lekktu@gmail.com>
1597
1598 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1599 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1600 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1601 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1602 ($(BLD)/w32select.$(O)): Update dependencies.
1603
e5560ff7
AS
16042012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1605
1606 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1607 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1608 * character.c (_fetch_multibyte_char_p): Remove.
1609 * alloc.c: Include "character.h" before "buffer.h".
1610 * bidi.c: Likewise.
1611 * buffer.c: Likewise.
1612 * bytecode.c: Likewise.
1613 * callint.c: Likewise.
1614 * callproc.c: Likewise.
1615 * casefiddle.c: Likewise.
1616 * casetab.c: Likewise.
1617 * category.c: Likewise.
1618 * cmds.c: Likewise.
1619 * coding.c: Likewise.
1620 * composite.c: Likewise.
1621 * dired.c: Likewise.
1622 * dispnew.c: Likewise.
1623 * doc.c: Likewise.
1624 * dosfns.c: Likewise.
1625 * editfns.c: Likewise.
1626 * emacs.c: Likewise.
1627 * fileio.c: Likewise.
1628 * filelock.c: Likewise.
1629 * font.c: Likewise.
1630 * fontset.c: Likewise.
1631 * fringe.c: Likewise.
1632 * indent.c: Likewise.
1633 * insdel.c: Likewise.
1634 * intervals.c: Likewise.
1635 * keyboard.c: Likewise.
1636 * keymap.c: Likewise.
1637 * lread.c: Likewise.
1638 * macros.c: Likewise.
1639 * marker.c: Likewise.
1640 * minibuf.c: Likewise.
1641 * nsfns.m: Likewise.
1642 * nsmenu.m: Likewise.
1643 * print.c: Likewise.
1644 * process.c: Likewise.
1645 * regex.c: Likewise.
1646 * region-cache.c: Likewise.
1647 * search.c: Likewise.
1648 * syntax.c: Likewise.
1649 * term.c: Likewise.
1650 * textprop.c: Likewise.
1651 * undo.c: Likewise.
1652 * unexsol.c: Likewise.
1653 * w16select.c: Likewise.
1654 * w32fns.c: Likewise.
1655 * w32menu.c: Likewise.
1656 * window.c: Likewise.
1657 * xdisp.c: Likewise.
1658 * xfns.c: Likewise.
1659 * xmenu.c: Likewise.
1660 * xml.c: Likewise.
1661 * xselect.c: Likewise.
1662
2f07e6af
EZ
16632012-06-16 Eli Zaretskii <eliz@gnu.org>
1664
1053a871
SM
1665 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1666 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1667 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1668 row.
1669 (handle_face_prop): Use chunk-relative overlay string index when
1670 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1671 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1672 the rightmost. (Bug#11720)
2f07e6af 1673
29b83cec
AS
16742012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1675
1676 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1677 (CATEGORY_MEMBER): Enforce 1/0 value.
1678 * category.c (_temp_category_set): Remove.
1679
4c5501e9
EZ
16802012-06-16 Eli Zaretskii <eliz@gnu.org>
1681
1682 * window.c (Fdelete_other_windows_internal)
1683 (Fdelete_window_internal): Don't access frame's mouse highlight
1684 info of the initial frame. (Bug#11677)
1685
2b570124
PE
16862012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1687
e93864f9
PE
1688 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1689 Assume USE_2_TAGS_FOR_INTS.
1690 (xreload): Adjust $tagmask width to match recent lisp.h change.
1691
2b570124
PE
1692 Simplify lisp.h in minor ways that should not affect code.
1693 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1694 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1695 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1696 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1697 (INTTYPEBITS): New macro, for clarity.
1698 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1699 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1700 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1701 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1702 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1703
81755f69
JB
17042012-06-13 Juanma Barranquero <lekktu@gmail.com>
1705
1706 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1707
16192a57
GM
17082012-06-13 Glenn Morris <rgm@gnu.org>
1709
1710 * s/bsd-common.h (BSD4_3):
1711 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1712
646b5f55
AS
17132012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1714
1715 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1716 instead of union.
1717 (XLI, XIL): Define.
1053a871
SM
1718 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1719 Use them.
1720 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1721 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1722 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1723 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1724 * frame.c (delete_frame): Remove outdated comment.
1725 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1726 USE_LISP_UNION_TYPE.
1727 (Fw32_unregister_hot_key): Likewise.
1728 (Fw32_toggle_lock_key): Likewise.
1729 * w32menu.c (add_menu_item): Likewise.
1730 (w32_menu_display_help): Use XIL instead of checking
1731 USE_LISP_UNION_TYPE.
1732 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1733 (init_heap): Likewise.
1734 * w32term.c (w32_read_socket): Update comment.
1735
1d3823c9
GM
17362012-06-13 Glenn Morris <rgm@gnu.org>
1737
c62ff706
GM
1738 * s/usg5-4-common.h, src/s/unixware.h:
1739 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1740
1d3823c9
GM
1741 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1742
bfe3e0a2
PE
17432012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1746 * alloc.c (make_number) [!defined make_number]:
1747 Remove, as lisp.h always defines this now.
1748 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1749 (roundup_size): Verify that it is a power of 2.
1750 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1751 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1752 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1753 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1754 USE_LSB_TAG now is always defined to be either 0 or 1.
1755 All uses changed.
1756 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1757 code works fine either way, and efficiency is not a concern here,
1758 as the union type is for debugging, not for production.
1759 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1760 Use an inline function on all platforms when using the union type,
1761 since this is simpler and 'static inline' can be used portably
1762 within Emacs now.
1763 (LISP_INITIALLY_ZERO): New macro.
1764 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1765 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1766
45fa9c0f
GM
17672012-06-12 Glenn Morris <rgm@gnu.org>
1768
b4492cba
GM
1769 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1770
1771 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1772
45fa9c0f
GM
1773 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1774 Move BROKEN_SIGIO to configure.
1775
1776 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1777 Move NO_TERMIO to configure.
1778
0e25d334
CY
17792012-06-12 Chong Yidong <cyd@gnu.org>
1780
1781 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1782 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1783 MagickExportImagePixels is undefined.
1784
43682bb6
PE
17852012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 * image.c (imagemagick_load_image): Remove unused label.
1788
a9be7d2b
GM
17892012-06-11 Glenn Morris <rgm@gnu.org>
1790
1791 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1792 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1793 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1794 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1795
3017f87f
SM
17962012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1797
1798 * alloc.c (make_byte_code): New function.
1799 (Fmake_byte_code): Use it. Don't purify here.
1800 * lread.c (read1): Use it as well to avoid extra allocation.
1801
1b9b4cf4
CY
18022012-06-11 Chong Yidong <cyd@gnu.org>
1803
1804 * image.c (imagemagick_load_image): Implement transparency.
1805
95988fcf
AS
18062012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1807
1808 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1809 account for preceding backslashes. (Bug#11663)
1810
cd4eb164
CY
18112012-06-09 Chong Yidong <cyd@gnu.org>
1812
1813 * term.c: Support italics in capable terminals (Bug#9652).
1814 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1815 (turn_on_face): Output using TS_enter_italic_mode if available.
1816 Don't handle unused blinking and alt-charset cases.
1817 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1818 and tty_alt_charset_p cases.
1819 (tty_capable_p, init_tty): Support italics.
1820
1821 * termchar.h (struct tty_display_info): Add field for italics.
1822 Remove unused blink field.
1823
1824 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1825 Handle slant.
1826
1827 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1828 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1829 tty_alt_charset_p. Add tty_italic_p.
1830
ff88beb8
MA
18312012-06-09 Michael Albinus <michael.albinus@gmx.de>
1832
1833 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1834 dbus_type_is_basic if available.
1835 (xd_extract_signed, xd_extract_unsigned): Rename from
1836 extract_signed and extract_unsigned, respectively. Adapt callers.
1837
44286096
CY
18382012-06-09 Chong Yidong <cyd@gnu.org>
1839
1682701f
CY
1840 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1841
44286096
CY
1842 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1843 case (Bug#9752).
1844
d86feb17
PE
18452012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1846
1847 * xdisp.c (vmessage): Treat frame message as multibyte.
1848 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1849 would generate the diagnostic "Making \302\247 buffer-local while
1850 let-bound!".
1851
d5c20fe8
EZ
18522012-06-08 Eli Zaretskii <eliz@gnu.org>
1853
1854 * dispnew.c (showing_window_margins_p): Undo last change, which
1855 was done due to an inadvertent commit.
1856 (adjust_frame_glyphs_for_frame_redisplay): Do call
1857 showing_window_margins_p.
1858
513749ee
SM
18592012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1860
1861 * eval.c (Fmake_var_non_special): New primitive.
1862 (syms_of_eval): Defsubr it.
1863 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1864
d4a8f5c1
JB
18652012-06-08 Juanma Barranquero <lekktu@gmail.com>
1866
1867 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1868 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1869
8bbbc977
EZ
18702012-06-08 Eli Zaretskii <eliz@gnu.org>
1871
1872 * alloc.c (allocate_vectorlike): Fix last change.
1873
f3372c87
DA
18742012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1875
1876 Block-based vector allocation of small vectors.
1877 * lisp.h (struct vectorlike_header): New field `nbytes',
1878 adjust comment accordingly.
1879 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1880 to denote vector blocks. Adjust users (live_vector_p,
1881 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1882 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1883 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1884 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1885 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1886 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1887 (roundup_size): New constant.
1888 (struct vector_block): New data type.
1889 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1890 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1891 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1892 (sweep_vectors): New functions.
1893 (allocate_vectorlike): Return `zero_vector' as the only vector of
1894 0 items. Allocate new vector from block if vector size is less than
1895 or equal to VBLOCK_BYTES_MAX.
1896 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1897 (init_alloc_once): Add call to init_vectors.
1898
4f18a4ed
SM
18992012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1900
1901 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1902
86f158bc
PE
19032012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1904
1905 * doprnt.c (doprnt): Truncate multibyte char correctly.
1906 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1907 would mishandle a string argument "Xc" if X was a multibyte
1908 character of length 2: it would truncate after X's first byte
1909 rather than including all of X.
1910
c5cfcbe0
CY
19112012-06-06 Chong Yidong <cyd@gnu.org>
1912
1913 * buffer.c (word_wrap): Doc fix.
1914
c05cf390
PE
19152012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1916
1917 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1918
0c3461de
GM
19192012-06-03 Glenn Morris <rgm@gnu.org>
1920
1921 * xdisp.c (tool-bar-style): Doc fix.
1922
c71232db
UM
19232012-06-03 Ulrich Müller <ulm@gentoo.org>
1924
1925 * Makefile.in (PAXCTL): Define.
1926 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1927 binary via PaX flags if the paxctl utility is available.
1928 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1929 Restore PaX flags to their default. (Bug#11398)
1930
383f7350
CY
19312012-06-03 Chong Yidong <cyd@gnu.org>
1932
1933 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1934 buffer (Bug#11226).
1935
5f2c76c6
CY
19362012-06-03 Chong Yidong <cyd@gnu.org>
1937
1938 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1939 (note_mode_line_or_margin_highlight): If there is no help echo,
1940 use mode-line-default-help-echo. Handle the case where the mouse
1941 position is past the end of the mode line string.
1942
1943 * buffer.c (buffer_local_value_1): New function, split from
1944 Fbuffer_local_value; can return Qunbound.
1945 (Fbuffer_local_value): Use it.
1946 (Vmode_line_format): Docstring tweaks.
1947
773d47f6
PE
19482012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 * sysdep.c (system_process_attributes): Improve comment.
1951
f2d6a3df
SM
19522012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1953
1954 * keyboard.c: Export real-this-command to Elisp.
1955 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1956 and DEFVAR it. Update all users.
1957
63810350
PE
19582012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1959
7bd5c1f4
PE
1960 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1961
63810350
PE
1962 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1963 Convert pctcpu and pctmem to Lisp float properly.
1964 Let the compiler fold better, as 100.0/0x8000 is exact.
1965
a2821611
AS
19662012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1967
1968 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1969 cons_block.
1970
5fceba1d
PE
19712012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1972
1973 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1974
c98ff5dd
DA
19752012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1976
1977 For a 'struct window', replace some Lisp_Object fields to
1978 bitfields where appropriate, remove unused fields.
1979 * window.h (struct window): Remove unused 'last_mark_x' and
1980 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1981 change it's type from Lisp_Object to bitfield.
1982 Change type of 'force_start', 'optional_new_start',
1983 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1984 fields from Lisp_Object to bitfield. Adjust users accordingly.
1985
ca34e0be
PE
19862012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1987
1988 Pacify gcc -Wdouble-precision when using Xaw.
1989 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1990 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1991 Use 'float' consistently, rather than 'float' in most places
1992 and 'double' in a couple of places.
1993
efc00ab1 19942012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1995
1996 * xdisp.c (handle_stop): Detect whether we have overlay strings
1997 loaded by testing it->current.overlay_string_index to be
1998 non-negative, instead of checking whether n_overlay_strings is
1999 positive. (Bug#11587)
2000
efc00ab1 20012012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2002
2003 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2004
2005 * doc.c (Fsubstitute_command_keys): Doc fix.
2006
efc00ab1 20072012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2008
2009 * search.c (search_buffer): Remove calls to
2010 r_alloc_inhibit_buffer_relocation, as it is now called by
2011 maybe_unify_char, which was the cause of relocation of buffer text
2012 in bug#11519.
2013
efc00ab1 20142012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2015
2016 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2017 for the duration of call to load_charset, to avoid problems with
2018 callers of maybe_unify_char that access buffer text through C
2019 pointers.
2020
2021 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2022 decrement the inhibition flag, instead of just setting or
2023 resetting it.
2024
ba93a187
PE
20252012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 Remove obsolete '#define static' cruft.
2028 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2029 This #undef was "temporary" in 2000; it is no longer needed
2030 now that '#define static' has gone away.
2031 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2032 (gray_bitmap_bits): Remove; no longer needed.
2033 All uses replaced with definiens.
2034 * xterm.c: Include "bitmaps/gray.xbm".
2035
9e4bf381
PE
20362012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 Clean up __executable_start, monstartup when --enable-profiling.
2039 The following changes affect the code only when profiling.
2040 * dispnew.c (__executable_start): Rename from safe_bcopy.
2041 Define only on platforms that need it.
2042 * emacs.c: Include <sys/gmon.h> when profiling.
2043 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2044 (__executable_start): Remove decl, since lisp.h does it now.
2045 (safe_bcopy): Remove decl; no longer has that name.
2046 (main): Coalesce #if into single bit of code, for simplicity.
2047 Cast pointers to uintptr_t, since standard libraries want integers
2048 and not pointers.
2049 * lisp.h (__executable_start): New decl.
2050
32d72c2f
GM
20512012-05-31 Glenn Morris <rgm@gnu.org>
2052
2053 * image.c (Fimagemagick_types): Doc fix.
2054
baac5bc7
JM
20552012-05-30 Jim Meyering <meyering@redhat.com>
2056
2057 * callproc.c (Fcall_process_region): Include directory component
2058 in mkstemp error message (Bug#11586).
2059
72cb32cf
PE
20602012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2061
2062 * alloc.c, lisp.h (make_pure_vector): Now static.
2063
61b108cc
SM
20642012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2065
2066 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2067 Move to byte-run.el.
2068 (Fautoload): Do the hash-doc more carefully.
2069 * data.c (Fdefalias): Purify definition, except for keymaps.
2070 (Qdefun): Move from eval.c.
2071 * lisp.h (Qdefun): Remove.
2072 * lread.c (read1): Tiny simplification.
2073
471fe23d
TN
20742012-05-29 Troels Nielsen <bn.troels@gmail.com>
2075
934f3f58 2076 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2077 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2078 Bug#9642, but explicitly check that the buffer the overlay would
2079 be moved to is live and rearrange lines to make sure that errors
2080 will not put the overlay in an inconsistent state.
2081 (Fdelete_overlay): Cosmetics.
2082
85d0efd1
EZ
20832012-05-28 Eli Zaretskii <eliz@gnu.org>
2084
2085 * w32term.c (my_bring_window_to_top): New function.
2086 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2087 could be different from the original one.
2088 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2089 (Bug#11513)
2090
2091 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2092 by calling BringWindowToTop.
2093
2094 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2095 (WM_EMACS_END): Increase by one.
2096
da92a98c
PE
20972012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2098
2099 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2100 This avoids undefined behavior that might cause the eassert
2101 to not catch an out-of-range value.
2102
74d1f848
JB
21032012-05-28 Juanma Barranquero <lekktu@gmail.com>
2104
2105 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2106 Update dependencies.
2107
9e1a06fc
EZ
21082012-05-27 Eli Zaretskii <eliz@gnu.org>
2109
2110 * bidi.c (bidi_mirror_char): Fix last change.
2111
f3dd7312
AS
21122012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2113
2114 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2115 when referring to sectname field in printf format.
2116
81899c91
PE
21172012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2118
57b81a9f
PE
2119 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2120 Only r_alloc_inhibit_buffer_relocation needed to be added;
2121 the others were already declared.
2122
81899c91
PE
2123 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2124 before checking whether it's out of range. Put the check inside
2125 eassert. See
2126 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2127
33017faf 21282012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2129
2130 * callproc.c (Fcall_process): Restore a line that was accidentally
2131 commented out in the 2011-02-13 change (bug#11547).
2132
33017faf 21332012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2134
2135 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2136 defined on ralloc.c.
2137
2138 * buffer.c [REL_ALLOC]: Remove prototypes of
2139 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2140 they are now on lisp.h.
2141
2142 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2143
2144 * search.c (search_buffer): Use it to inhibit relocation of buffer
2145 text while re_search_2 is doing its job, because re_search_2 is
2146 passed C pointers to buffer text. (Bug#11519)
2147
23415acf
EZ
2148 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2149 Update value to 24.
2150
44e27368
EZ
2151 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2152 state after an additional call to move_it_in_display_line_to, keep
2153 the values of it->max_ascent and it->max_descent found for the
2154 entire line.
2155 (pos_visible_p): Revert the comparison against bottom_y to what it
2156 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2157 (Bug#11464)
2158
c1892f11
PE
21592012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2160
2161 Fix coding-related core dumps with gcc -ftrapv.
2162 The code was computing A - B, where A and B are pointers, and B is
2163 random garbage. This can lead to core dumps on platforms that
2164 have special pointer registers, and it also leads to core dumps on
2165 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2166 A - B only when B is initialized properly.
2167 * coding.c (coding_set_source, coding_set_destination): Return void.
2168 (coding_change_source, coding_change_destinations): New functions,
2169 with the old behaviors of coding_set_source and coding_set_destination.
2170 All callers that need an offset changed to use these new functions.
2171
eb7afdad
GM
21722012-05-26 Glenn Morris <rgm@gnu.org>
2173
2174 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2175
f12fdf02
EZ
21762012-05-26 Eli Zaretskii <eliz@gnu.org>
2177
53a63be6 2178 Extend mouse support on W32 text-mode console.
61b108cc
SM
2179 * xdisp.c (draw_row_with_mouse_face):
2180 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2181
eb3f6f01 2182 * w32console.c: Include window.h.
61b108cc
SM
2183 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2184 New functions.
eb3f6f01
EZ
2185 (initialize_w32_display): Initialize mouse-highlight data.
2186
53a63be6
EZ
2187 * w32inevt.c: Include termchar.h and window.h.
2188 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2189 moves, call note_mouse_highlight. If help_echo changed, call
2190 gen_help_event to produce help-echo message in the echo area.
2191 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2192 highlight info.
2193
4cfd81f6
PE
21942012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2195
2196 * lread.c (read1): Simplify slightly to avoid an overflow warning
2197 with GCC 4.7.0 on x86-64.
2198
4446092a
EZ
21992012-05-26 Eli Zaretskii <eliz@gnu.org>
2200
2201 * bidi.c (bidi_mirror_char): Revert last change: an int is
2202 definitely wide enough here.
2203
42b2a986 22042012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2205
42b2a986 2206 Fix integer width and related bugs (Bug#9874).
eb106a49 2207 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2208 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2209 (string_bytes, check_sblock, allocate_string_data):
2210 (compact_small_strings, Fmake_bool_vector, make_string)
2211 (make_unibyte_string, make_multibyte_string)
2212 (make_string_from_bytes, make_specified_string)
2213 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2214 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2215 (mark_vectorlike):
2216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2217 (allocate_pseudovector):
2218 Use int, not EMACS_INT, where int is wide enough.
2219 (inhibit_garbage_collection, Fgarbage_collect):
2220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2221 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2222 int might not be wide enough.
2223 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2224 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2225 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2226 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2227 (bidi_level_of_next_char, bidi_move_to_visually_next):
2228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2229 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2230 (Fkill_buffer, Fset_buffer_major_mode)
2231 (advance_to_char_boundary, Fbuffer_swap_text)
2232 (Fset_buffer_multibyte, overlays_at, overlays_in)
2233 (overlay_touches_p, struct sortvec, record_overlay_string)
2234 (overlay_strings, recenter_overlay_lists)
2235 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2236 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2237 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2238 (Foverlay_recenter, last_overlay_modification_hooks_used)
2239 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2241 (validate_region): Omit unnecessary test for b <= e,
2242 since that's guaranteed by the previous test.
d311d28c
PE
2243 (adjust_overlays_for_delete): Avoid pos + length overflow.
2244 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2245 (report_overlay_modification):
2246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2247 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2248 Omit pointer cast, which isn't needed anyway, and doesn't work
2249 after the EMACS_INT -> ptrdiff_t change.
02481186 2250 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2251 * buffer.h: Adjust decls to match defn changes elsewhere.
2252 (struct buffer_text, struct buffer):
2253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2254 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2255 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2256 not int, to avoid needless 32-bit limit on 64-bit hosts.
2257 (exec_byte_code): Use tighter memory-full test, one that checks
2258 for alloca overflow. Don't compute the address of the object just
2259 before an array, as that's not portable. Use EMACS_INT, not
2260 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2261 * callint.c (Fcall_interactively):
2262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2263 * callproc.c (call_process_kill, Fcall_process):
2264 Don't assume pid_t fits into an Emacs fixnum.
2265 (call_process_cleanup, Fcall_process, child_setup):
2266 Don't assume pid_t fits into int.
2267 (call_process_cleanup, Fcall_process, delete_temp_file)
2268 (Fcall_process_region):
2269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2270 (Fcall_process): Simplify handling of volatile integers.
2271 Use int, not EMACS_INT, where int will do.
2272 * casefiddle.c (casify_object, casify_region, operate_on_word)
2273 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2275 (casify_object): Avoid integer overflow when overallocating buffer.
2276 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2277 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2278 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2279 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2280 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2281 integers are now checked earlier. All uses replaced with XINT.
2282 (ccl_driver):
2283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2284 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2285 (ccl_driver, Fregister_code_conversion_map):
2286 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2287 (resolve_symbol_ccl_program): Check that vector header is in range.
2288 Always copy the vector, so that we can check its contents reliably
2289 now rather than having to recheck each instruction as it's being
2290 executed. Check that vector words fit in 'int'.
2291 (ccl_get_compiled_code, Fregister_ccl_program)
2292 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2293 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2294 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2295 contents are in range.
2296 (Fccl_execute_on_string): Check that status is in range.
2297 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2298 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2299 Accept and return EMACS_INT, not int, because callers can pass values
2300 out of 'int' range.
2301 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2302 (multibyte_chars_in_text, parse_str_as_multibyte)
2303 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2304 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2305 (string_escape_byte8, Fget_byte):
2306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2307 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2308 avoid mishandling large integers.
2309 * character.h: Adjust decls to match defn changes elsewhere.
2310 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2311 (Ffind_charset_region):
2312 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2313 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2314 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2315 Don't assume fixnum fits in int.
d311d28c
PE
2316 (load_charset_map_from_vector, Fmap_charset_chars):
2317 Remove now-unnecessary CHECK_NATNUMs.
2318 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2319 Don't rely on undefined behavior with signed left shift overflow.
2320 Don't assume unsigned int fits into fixnum, or that fixnum fits
2321 into unsigned int. Don't require max_code to be a valid fixnum;
2322 that's not true for gb10830 4-byte on a 32-bit host. Allow
2323 invalid_code to be a cons, for the same reason. Require code_offset
2324 to be a character. Avoid int overflow if max_char is close
2325 to INT_MAX.
2326 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2327 this is intended anyway and avoids some undefined behavior.
2328 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2329 INDEX_TO_CODE_POINT, as that's what it expects.
2330 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2331 * charset.h (DECODE_CHAR): Return int, not unsigned;
2332 this is what was intended anyway, and it avoids undefined behavior.
2333 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2334 integer-overflow issues.
2335 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2336 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2337 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2338 * chartab.c (Fmake_char_table, Fset_char_table_range)
2339 (uniprop_get_decoder, uniprop_get_encoder):
2340 Don't assume fixnum fits in int.
2341 * cmds.c (move_point): New function, that does the gist of
2342 Fforward_char and Fbackward_char, but does so while checking
2343 for integer overflow more accurately.
c96e5d6a 2344 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2345 (Fforward_line, Fend_of_line, internal_self_insert)
2346 (internal_self_insert):
2347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2348 Fix a FIXME, by checking for integer overflow when calculating
2349 target_clm and actual_clm.
2350 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2351 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2352 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2353 (coding_alloc_by_making_gap, alloc_destination)
2354 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2355 (encode_coding_utf_16, detect_coding_emacs_mule)
2356 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2357 (detect_coding_iso_2022, decode_coding_iso_2022)
2358 (encode_invocation_designation, encode_designation_at_bol)
2359 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2360 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2361 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2362 (encode_coding_ccl, encode_coding_raw_text)
2363 (detect_coding_charset, decode_coding_charset)
2364 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2365 (produce_composition, produce_charset, produce_annotation)
2366 (decode_coding, handle_composition_annotation)
2367 (handle_charset_annotation, consume_chars, decode_coding_gap)
2368 (decode_coding_object, encode_coding_object, detect_coding_system)
2369 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2370 (code_convert_region, code_convert_string)
8f50130c
PE
2371 (Fdefine_coding_system_internal)
2372 (coding_set_source, coding_set_destination):
d311d28c
PE
2373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2374 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2375 (Fdefine_coding_system_internal):
2376 Don't assume fixnums fit in int.
2377 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2378 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2379 (Funencodable_char_position, Fcheck_coding_systems_region)
2380 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2382 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2383 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2384 Don't access memory outside of the args array.
d311d28c 2385 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2386 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2387 result of ENCODE_CHAR.
d311d28c
PE
2388 * coding.h: Adjust decls to match defn changes elsewhere.
2389 (struct coding_system):
2390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2391 * composite.c (get_composition_id, find_composition)
2392 (run_composition_function, update_compositions)
2393 (compose_text, composition_gstring_put_cache)
2394 (composition_gstring_p, composition_gstring_width)
2395 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2396 (composition_compute_stop_pos, composition_reseat_it)
2397 (composition_update_it, struct position_record)
2398 (find_automatic_composition, composition_adjust_point)
2399 (Fcomposition_get_gstring, Ffind_composition_internal):
2400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2401 (update_compositions):
2402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2403 * composite.h: Adjust decls to match defn changes elsewhere.
2404 (struct composition):
2405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2406 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2407 Do not attempt to compute the address of the object just before a
2408 buffer; this is not portable.
2409 (Faref, Faset):
2410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2411 (Faset): Use int, not EMACS_INT, where int is wide enough.
2412 (Fstring_to_number): Don't assume fixnums fit in int.
2413 (Frem): Don't assume arg is nonnegative.
2414 * dbusbind.c (xd_append_arg): Check for integers out of range.
2415 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2416 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2417 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2418 (xd_get_connection_references): Return ptrdiff_t, not int.
2419 All uses changed.
2420 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2421 (xd_read_message_1):
2422 Use int, not unsigned, where the dbus API uses int.
2423 (Fdbus_message_internal): Don't overflow mtype.
2424 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2425 * dired.c (directory_files_internal, file_name_completion, scmp)
2426 (file_name_completion_stat):
2427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2428 (file_name_completion): Don't overflow matchcount.
2429 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2430 * dispextern.h: Adjust decls to match defn changes elsewhere.
2431 (struct text_pos, struct glyph, struct bidi_saved_info)
2432 (struct bidi_string_data, struct bidi_it, struct composition_it)
2433 (struct it):
2434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2435 (struct display_pos, struct composition_it, struct it):
2436 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2437 * dispnew.c (increment_matrix_positions)
2438 (increment_row_positions, mode_line_string)
2439 (marginal_area_string):
2440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2441 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2443 (duration_to_sec_usec): New function, to check for overflow better.
2444 (Fsleep_for, sit_for): Use it.
2445 * doc.c (get_doc_string, store_function_docstring):
2446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2447 (get_doc_string, Fsnarf_documentation):
2448 Use int, not EMACS_INT, where int is wide enough.
2449 (get_doc_string):
2450 Use SAFE_ALLOCA, not alloca.
2451 Check for overflow when converting EMACS_INT to off_t.
2452 * doprnt.c (doprnt):
2453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2454 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2455 Don't assume uid_t fits into fixnum.
2456 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2457 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2458 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2459 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2460 (general_insert_function)
2461 (Finsert_char, make_buffer_string, make_buffer_string_both)
2462 (update_buffer_properties, Fbuffer_substring)
2463 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2464 (Fsubst_char_in_region, check_translation)
2465 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2466 (transpose_markers, Ftranspose_regions):
2467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2468 (clip_to_bounds): Move to lisp.h as an inline function).
2469 (Fconstrain_to_field): Don't assume integers are nonnegative.
2470 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2471 (Fsubst_char_in_region, Fsave_restriction):
2472 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2473 (Femacs_pid): Don't assume pid_t fits into fixnum.
2474 (lo_time): Use int, not EMACS_INT, when int suffices.
2475 (lisp_time_argument): Check for usec out of range.
2476 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2477 (Fuser_login_name, Fuser_full_name): Signal an error
2478 if a uid argument is out of range, rather than relying on
2479 undefined behavior.
c8d5c857
PE
2480 (Fformat_time_string): Remove now-unnecessary check.
2481 lisp_time_argument checks for out-of-range usec now.
243e0530 2482 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2483 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2484 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2485 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2486 (init_cmdargs, Fdump_emacs):
2487 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2488 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2489 the bottom (typically) 32 bits of the fixnum.
2490 * eval.c (specpdl_size, call_debugger):
2491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2492 (when_entered_debugger, Fbacktrace_debug):
2493 Don't assume fixnum can fit in int.
2494 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2495 the object just before a buffer; this is not portable.
2496 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2497 (grow_specpdl, unbind_to):
2498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2499 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2500 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2501 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2502 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2503 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2505 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2506 (a_write, e_write):
2507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2508 (Fcopy_file, non_regular_nbytes, read_non_regular)
2509 (Finsert_file_contents):
2510 Use int, not EMACS_INT, where int is wide enough.
2511 (READ_BUF_SIZE): Verify that it fits in int.
2512 (Finsert_file_contents): Check that counts are in proper range,
2513 rather than assuming fixnums fit into ptrdiff_t etc.
2514 Don't assume fixnums fit into int.
125b3835 2515 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2516 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2517 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2518 (string_char_to_byte, string_byte_to_char)
2519 (string_make_multibyte, string_to_multibyte)
2520 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2521 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2522 (substring_both, Fdelete, internal_equal, Ffillarray)
2523 (Fclear_string, mapcar1)
2524 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2525 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2526 (larger_vector, make_hash_table, maybe_resize_hash_table)
2527 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2528 (Fmaphash, secure_hash):
2529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2530 (concat): Check for string index and length overflow.
2531 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2532 (Frequire):
2533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2534 (larger_vector): New API (vec, incr_min, size_max) replaces old
2535 one (vec, new_size, init). This catches size overflow.
2536 INIT was removed because it was always Qnil.
2537 All callers changed.
2538 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2539 the upper bound on a hash table index size.
2540 (make_hash_table, maybe_resize_hash_table): Use it.
2541 (secure_hash): Computer start_byte and end_byte only after
2542 they're known to be in ptrdiff_t range.
2543 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2544 (Ffont_get_glyphs, Ffont_at):
2545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2546 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2547 (Flist_fonts, Fopen_font):
2548 Don't assume fixnum can fit in int.
2549 (check_gstring): Don't assume index can fit in int.
2550 (font_match_p): Check that fixnum is a character, not a nonnegative
2551 fixnum, since the later code needs to stuff it into an int.
2552 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2553 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2554 conversion overflow issues.
2555 (Fopen_font): Check for integer out of range.
2556 (Ffont_get_glyphs): Don't assume index can fit in int.
2557 * font.h: Adjust decls to match defn changes elsewhere.
2558 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2559 integer overflow.
2560 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2561 printmax_t, where ptrdiff_t is wide enough.
2562 (Finternal_char_font):
2563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2564 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2565 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2566 (Fset_frame_position, x_set_frame_parameters)
2567 (x_set_line_spacing, x_set_border_width)
2568 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2569 Check that fixnums are in proper range for system types.
2570 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2572 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2573 Use SAFE_ALLOCA_LISP, not alloca.
2574 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2575 intptr_t is wide enough.
2576 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2577 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2578 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2579 Check for fixnum out of range.
2580 * ftfont.c (ftfont_list): Don't assume index fits in int.
2581 Check that fixnums are in proper range for system types.
2582 (ftfont_shape_by_flt):
2583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2584 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2586 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2587 Check that fixnums are in proper range for system types.
2588 * gnutls.h: Adjust decls to match defn changes elsewhere.
2589 * gtkutil.c (xg_dialog_run):
2590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2591 (update_frame_tool_bar):
2592 Check that fixnums are in proper range for system types.
2593 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2594 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2595 * indent.c (last_known_column, last_known_column_point):
2596 (current_column_bol_cache):
2597 (skip_invisible, current_column, check_display_width):
2598 (check_display_width, scan_for_column, current_column_1)
2599 (Findent_to, Fcurrent_indentation, position_indentation)
2600 (indented_beyond_p, Fmove_to_column, compute_motion):
2601 (Fcompute_motion, Fvertical_motion):
2602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2603 (last_known_column_modified): Use EMACS_INT, not int.
2604 (check_display_width):
2605 (Fcompute_motion):
2606 Check that fixnums and floats are in proper range for system types.
2607 (compute_motion): Don't assume index or fixnum fits in int.
2608 (compute_motion, Fcompute_motion):
2609 Use int, not EMACS_INT, when it is wide enough.
2610 (vmotion): Omit local var start_hpos that is always 0; that way
2611 we don't need to worry about overflow in expressions involving it.
2612 * indent.h: Adjust decls to match defn changes elsewhere.
2613 (struct position):
2614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2615 Use int, not EMACS_INT, where int is wide enough.
2616 Remove unused members ovstring_chars_done and tab_offset;
2617 all uses removed.
2618 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2619 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2620 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2621 (make_gap, copy_text, insert, insert_and_inherit)
2622 (insert_before_markers, insert_before_markers_and_inherit)
2623 (insert_1, count_combining_before, count_combining_after)
2624 (insert_1_both, insert_from_string)
2625 (insert_from_string_before_markers, insert_from_string_1)
2626 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2627 (adjust_after_replace, adjust_after_insert, replace_range)
2628 (replace_range_2, del_range, del_range_1, del_range_byte)
2629 (del_range_both, del_range_2, modify_region)
2630 (prepare_to_modify_buffer, signal_before_change)
2631 (signal_after_change, Fcombine_after_change_execute):
2632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2633 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2634 (balance_an_interval, split_interval_right, split_interval_left)
2635 (find_interval, next_interval, update_interval)
2636 (adjust_intervals_for_insertion, delete_node, delete_interval)
2637 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2638 (static_offset_intervals, offset_intervals)
2639 (merge_interval_right, merge_interval_left, make_new_interval)
2640 (graft_intervals_into_buffer, temp_set_point_both)
2641 (temp_set_point, set_point, adjust_for_invis_intang)
2642 (set_point_both, move_if_not_intangible, get_property_and_range)
2643 (get_local_map, copy_intervals, copy_intervals_to_string)
2644 (compare_string_intervals, set_intervals_multibyte_1):
2645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2646 * intervals.h: Adjust decls to match defn changes elsewhere.
2647 (struct interval):
2648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2649 * keyboard.c (this_command_key_count, this_single_command_key_start)
2650 (before_command_key_count, before_command_echo_length, echo_now)
2651 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2652 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2653 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2654 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2656 (last_non_minibuf_size, last_point_position, echo_truncate)
2657 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2658 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2659 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2660 (stuff_buffered_input):
2661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2662 (last_auto_save, command_loop_1, read_char):
2663 Use EMACS_INT, not int, to avoid integer overflow.
2664 (record_char): Avoid overflow in total_keys computation.
2665 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2666 * keyboard.h: Adjust decls to match defn changes elsewhere.
2667 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2668 (Fkey_description, Fdescribe_vector, Flookup_key):
2669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2670 (click_position): New function, to check that positions are in range.
2671 (Fcurrent_active_maps):
2672 (describe_command):
2673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2674 (Faccessible_keymaps, Fkey_description):
2675 (preferred_sequence_p):
2676 Don't assume fixnum can fit into int.
2677 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2678 Check for integer overflow in size calculations.
2679 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2680 avoid mishandling large integers.
2681 * lisp.h: Adjust decls to match defn changes elsewhere.
2682 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2683 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2684 (struct Lisp_Marker):
2685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2686 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2687 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2688 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2689 All callers changed.
2690 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2691 Assume the arg has valid form, since it always does.
2692 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2693 unsigned integer system type.
2694 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2695 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2697 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2698 (duration_to_sec_usec): New decl.
2699 * lread.c (read_from_string_index, read_from_string_index_byte)
2700 (read_from_string_limit, readchar, unreadchar, openp)
2701 (read_internal_start, read1, oblookup):
2702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2703 (Fload, readevalloop, Feval_buffer, Feval_region):
2704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2705 (openp): Check for out-of-range argument to 'access'.
2706 (read1): Use int, not EMACS_INT, where int is wide enough.
2707 Don't assume fixnum fits into int.
6efdadfd 2708 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2709 (read_filtered_event): Use duration_to_sec_usec
2710 to do proper overflow checking on durations.
d311d28c
PE
2711 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2712 in size calculation.
2713 (Fexecute_kbd_macro):
2714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2715 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2716 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2717 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2718 (set_marker_both, set_marker_restricted_both, marker_position)
2719 (marker_byte_position, Fbuffer_has_markers_at):
2720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2721 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2722 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2723 It now merely ensures that the menu is large enough, without
2724 necessarily growing it, as this avoids some integer overflow issues.
2725 All callers changed.
2726 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2728 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2729 Use SAFE_ALLOCA_LISP, not alloca.
2730 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2731 to EMACS_INT. Check that fixnums are in proper range for system types.
2732 * minibuf.c (minibuf_prompt_width, string_to_object)
2733 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2734 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2736 (get_minibuffer, read_minibuf_unwind):
2737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2738 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2739 this simplifies overflow checking. All callers changed.
2740 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2741 (Ftest_completion):
2742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2743 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2744 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2745 Check that fixnums are in proper range for system types.
2746 (Fx_create_frame, Fx_show_tip):
2747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2748 * nsfont.m (ns_findfonts, nsfont_list_family):
2749 Don't assume fixnum fits in long.
2750 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2752 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2753 wide enough.
17fdb222 2754 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2756 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2757 (PRINTDECLARE, PRINTPREPARE):
2758 (strout, print_string):
2759 (print, print_preprocess, print_check_string_charset_prop)
2760 (print_object):
2761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2762 (PRINTDECLARE):
2763 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2765 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2766 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2767 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2768 (print_error_message): Use SAFE_ALLOCA, not alloca.
2769 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2770 (print_depth, new_backquote_output, print_number_index):
2771 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2772 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2773 (Fset_process_window_size, Fformat_network_address)
2774 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2775 (sigchld_handler):
d311d28c 2776 Check that fixnums are in proper range for system types.
d44287d4 2777 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2778 Check for process-ids out of pid_t range rather than relying on
2779 undefined behavior.
e4d81efc 2780 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2781 (Fformat_network_address, read_process_output, send_process)
2782 (Fprocess_send_region, status_notify):
2783 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2784 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2785 (wait_reading_process_output, read_process_output, exec_sentinel):
2786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2787 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2788 (Faccept_process_output): Use duration_to_sec_usec to do proper
2789 overflow checking on durations.
dde14581
PE
2790 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2791 Don't assume pid_t fits in int.
02481186
PE
2792 * process.h (struct Lisp_Process): Members tick and update_tick
2793 are now of type EMACS_INT, not int.
b62b53e8
PE
2794 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2795 configured --with-wide-int.
d311d28c
PE
2796 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2797 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2798 * search.c (looking_at_1, string_match_1):
2799 (fast_string_match, fast_c_string_match_ignore_case)
2800 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2801 (scan_newline, find_before_next_newline, search_command)
2802 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2803 (set_search_regs, wordify):
2804 (Freplace_match):
2805 (Fmatch_data):
2806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2807 (string_match_1, search_buffer, set_search_regs):
2808 (Fmatch_data):
2809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2810 (wordify): Check for overflow in size calculation.
2811 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2812 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2813 Check that fixnums are in proper range for system types.
2814 * sound.c (struct sound_device)
2815 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2817 (Fplay_sound_internal):
2818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2819 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2820 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2821 (Fparse_partial_sexp):
2822 Don't assume fixnums can fit in int.
2823 (struct lisp_parse_state, find_start_pos, find_start_value)
2824 (find_start_value_byte, find_start_begv)
2825 (update_syntax_table, char_quoted, dec_bytepos)
2826 (find_defun_start, prev_char_comend_first, back_comment):
2827 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2828 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2830 (Finternal_describe_syntax_value): Check that match_lisp is a
2831 character, not an integer, since the code stuffs it into int.
2832 (scan_words, scan_sexps_forward):
2833 Check that fixnums are in proper range for system types.
2834 (Fforward_word):
2835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2836 (scan_sexps_forward):
2837 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2838 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2839 * syntax.h: Adjust decls to match defn changes elsewhere.
2840 (struct gl_state_s):
2841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2842 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2843 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2844 * sysdep.c (wait_for_termination_1, wait_for_termination)
2845 (interruptible_wait_for_termination, mkdir):
2846 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2847 (emacs_read, emacs_write):
2848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2849 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2850 and double all fit in int.
d311d28c
PE
2851 * term.c (set_tty_color_mode):
2852 Check that fixnums are in proper range for system types.
2853 * termhooks.h (struct input_event):
2854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2855 * textprop.c (validate_interval_range, interval_of)
2856 (Fadd_text_properties, set_text_properties_1)
2857 (Fremove_text_properties, Fremove_list_of_text_properties)
2858 (Ftext_property_any, Ftext_property_not_all)
2859 (copy_text_properties, text_property_list, extend_property_ranges)
2860 (verify_interval_modification):
2861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2862 (Fnext_single_char_property_change)
2863 (Fprevious_single_char_property_change):
2864 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2865 (copy_text_properties):
2866 Check for integer overflow in index calculation.
d311d28c
PE
2867 * undo.c (last_boundary_position, record_point, record_insert)
2868 (record_delete, record_marker_adjustment, record_change)
2869 (record_property_change):
2870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2871 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2873 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2874 (Fx_hide_tip, Fx_file_dialog):
2875 * w32menu.c (set_frame_menubar):
2876 Use ptrdiff_t, not int, for consistency with rest of code.
2877 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2878 (select_window, Fdelete_other_windows_internal)
2879 (window_scroll_pixel_based, window_scroll_line_based)
2880 (Frecenter, Fset_window_configuration):
2881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2882 (Fset_window_hscroll, run_window_configuration_change_hook)
2883 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2884 (Fscroll_other_window, Frecenter):
d311d28c
PE
2885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2886 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2887 Don't assume fixnum fits in int.
2888 (Fset_window_scroll_bars):
2889 Check that fixnums are in proper range for system types.
2890 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2891 (string_pos, c_string_pos, number_of_chars, init_iterator)
2892 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2893 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2894 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2895 (face_before_or_after_it_pos, handle_invisible_prop)
2896 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2897 (display_prop_intangible_p, string_buffer_position_lim)
2898 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2899 (get_overlay_strings_1, get_overlay_strings)
2900 (iterate_out_of_display_property, forward_to_next_line_start)
2901 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2902 (get_next_display_element, set_iterator_to_next)
2903 (get_visually_first_element, compute_stop_pos_backwards)
2904 (handle_stop_backwards, next_element_from_buffer)
2905 (move_it_in_display_line_to, move_it_in_display_line)
2906 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2907 (add_to_log, message_dolog, message_log_check_duplicate)
2908 (message2, message2_nolog, message3, message3_nolog
2909 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2910 (current_message_1, truncate_echo_area, truncate_message_1)
2911 (set_message, set_message_1, store_mode_line_noprop)
2912 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2913 (text_outside_line_unchanged_p, check_point_in_composition)
2914 (reconsider_clip_changes)
2915 (redisplay_internal, set_cursor_from_row, try_scrolling)
2916 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2917 (redisplay_window, find_last_unchanged_at_beg_row)
2918 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2919 (trailing_whitespace_p, find_row_edges, display_line)
2920 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2921 (display_mode_element, store_mode_line_string)
2922 (pint2str, pint2hrstr, decode_mode_spec)
2923 (display_count_lines, display_string, draw_glyphs)
2924 (x_produce_glyphs, x_insert_glyphs)
2925 (rows_from_pos_range, mouse_face_from_buffer_pos)
2926 (fast_find_string_pos, mouse_face_from_string_pos)
2927 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2929 (safe_call, init_from_display_pos, handle_fontified_prop)
2930 (handle_single_display_spec, load_overlay_strings)
2931 (with_echo_area_buffer, setup_echo_area_for_printing)
2932 (display_echo_area, echo_area_display)
2933 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2934 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2935 (redisplay_window, dump_glyph_row, display_mode_line)
2936 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2937 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2939 (handle_single_display_spec, build_desired_tool_bar_string)
2940 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2941 (get_specified_cursor_type):
2942 Check that fixnums are in proper range for system types.
2943 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2944 (Flookup_image_map):
2945 Don't assume fixnums fit in int.
2946 (compare_overlay_entries):
2947 Avoid mishandling comparisons due to subtraction overflow.
2948 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2949 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2950 (handle_tool_bar_click):
2951 Use int, not unsigned, since we prefer signed and the signedness
2952 doesn't matter here.
2953 (get_next_display_element, next_element_from_display_vector):
2954 Use int, not EMACS_INT, when int is wide enough.
2955 (start_hourglass): Use duration_to_sec_usec to do proper
2956 overflow checking on durations.
2957 * xfaces.c (Fbitmap_spec_p):
2958 Check that fixnums are in proper range for system types.
2959 (compare_fonts_by_sort_order):
2960 Avoid mishandling comparisons due to subtraction overflow.
2961 (Fx_family_fonts, realize_basic_faces):
2962 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2963 (Fx_family_fonts):
2964 Don't assume fixnum fits in int.
2965 Use SAFE_ALLOCA_LISP, not alloca.
2966 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2967 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2968 (face_at_buffer_position, face_for_overlay_string)
2969 (face_at_string_position):
2970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2971 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2972 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2973 (Fx_show_tip):
2974 Check that fixnums are in proper range for system types.
2975 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2976 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2978 (Fx_change_window_property): Don't assume fixnums fit in int.
2979 * xfont.c (xfont_chars_supported):
2980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2981 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2982 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2984 * xml.c (parse_region):
2985 * xrdb.c (magic_file_p):
2986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2987 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2988 (x_get_local_selection, x_reply_selection_request)
2989 (x_handle_selection_request, wait_for_property_change):
2990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2991 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2992 short is wide enough.
2993 (x_send_client_event): Don't assume fixnum fits in int.
2994 * xterm.c (x_x_to_emacs_modifiers):
2995 Don't assume EMACS_INT overflows nicely into int.
2996 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2997 may come from Lisp.
2998 (handle_one_xevent): NATNUMP can eval its arg twice.
2999 (x_connection_closed):
3000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3001 * xterm.h: Adjust decls to match defn changes elsewhere.
3002 (struct scroll_bar): Use struct vectorlike_header
3003 rather than rolling our own approximation.
3004 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3005
c6574eb5
GM
30062012-05-25 Glenn Morris <rgm@gnu.org>
3007
3008 * lisp.mk (lisp): Update for more files being compiled now.
3009
e8d32c7e
SM
30102012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3011
48def666
SM
3012 * lread.c: Remove `read_pure' which makes no difference.
3013 (read_pure): Remove var.
3014 (unreadpure): Remove function.
3015 (readevalloop): Don't call read_list with -1 flag.
3016 (read1, read_vector): Don't test read_pure any more.
3017 (read_list): Simplify.
3018
e8d32c7e
SM
3019 * fileio.c, character.h: Minor style tweaks.
3020
4b2addb7
DA
30212012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3022
3023 * window.h (clip_changed): Remove useless declaration.
3024
584461b2
JB
30252012-05-22 Juanma Barranquero <lekktu@gmail.com>
3026
3027 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3028 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3029
34374650
PE
30302012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 Remove src/m/*.
3033 This directory predates autoconf and is no longer needed nowadays.
3034 Move its few remaining bits of functionality to where they're needed.
3035 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3036 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3037 * m/template.h: Remove.
3038 * Makefile.in (M_FILE): Remove. All uses removed.
3039 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3040 * lisp.h (USE_LSB_TAG):
3041 * mem-limits.h (EXCEEDS_LISP_PTR):
3042 Use VAL_MAX, not VALBITS, in #if.
3043 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3044 (EMACS_UINT): Define unconditionally now.
3045 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3046 (BITS_PER_EMACS_INT): New constants, replacing
3047 what used to be in config.h, but not useful in #if.
3048 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3049 define them any more.
3050 (VAL_MAX): New macro.
3051 (VALMASK): Use it.
3052 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3053 BITS_PER_EMACS_INT, in #if.
3054 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3055 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3056 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3057 * s/ms-w32.h (DATA_START):
3058 Move here from removed file m/intel386.h.
3059 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3060 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3061
261cb4bb
PE
30622012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 Assume C89 or later.
3065 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3066 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3067 (xrealloc):
3068 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3069 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3070 * textprop.c, tparam.c (NULL): Remove.
3071 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3072 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3073 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3074 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3075 * xterm.c (input_signal_count): Assume volatile works.
3076
ff23cd9f
KB
30772012-05-21 Ken Brown <kbrown@cornell.edu>
3078
3079 * xgselect.c (xg_select): Fix first argument in call to 'select'
3080 (bug#11508).
3081
1b170bc6
KB
30822012-05-20 Ken Brown <kbrown@cornell.edu>
3083
3084 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3085 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3086
b2f4d39f
KB
30872012-05-19 Ken Brown <kbrown@cornell.edu>
3088
3089 * xfns.c (x_in_use): Remove `static' qualifier.
3090 * xterm.h (x_in_use): Declare.
3091 * xgselect.c: Include xterm.h.
3092 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3093 and `display_arg' (bug#9754).
3094
003fdae2
PE
30952012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3096
9232a6d9
PE
3097 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3098
003fdae2
PE
3099 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3100 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3101
784b56e2
EZ
31022012-05-18 Eli Zaretskii <eliz@gnu.org>
3103
3104 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3105
3106 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3107 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3108
3109 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3110 reference to image_cache->refcount.
3111 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3112
a0a79cde
JL
31132012-05-17 Juri Linkov <juri@jurta.org>
3114
3115 * search.c (Fword_search_regexp, Fword_search_backward)
3116 (Fword_search_forward, Fword_search_backward_lax)
3117 (Fword_search_forward_lax): Move functions to isearch.el
3118 (bug#10145, bug#11381).
3119
b0572523
PE
31202012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3121
3122 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3123
9660f5fc
SM
31242012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3125
3126 * lread.c (init_obarray): Declare Qt and Qnil as special.
3127
4374de83
GM
31282012-05-14 Glenn Morris <rgm@gnu.org>
3129
3130 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3131 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3132
dc44c39a
PE
31332012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3134
078c97cb
PE
3135 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3136
dc44c39a
PE
3137 * unexaix.c: Port to more-recent AIX compilers.
3138 (report_error, report_error_1, make_hdr, copy_sym)
3139 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3140 Make arguments const char *, not char *, to avoid violations of C
3141 standard and to fix some AIX warnings reported by Gilles Pion.
3142
e18afed7 31432012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3144
3145 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3146 already have overlays loaded.
3147 (handle_single_display_spec): Before returning without displaying
3148 fringe bitmap, synchronize the bidi iterator with the main display
3149 iterator, by calling iterate_out_of_display_property.
3150 (iterate_out_of_display_property): Detect buffer iteration by
3151 testing that it->string is a Lisp string.
3152 (get_next_display_element): When the current object is exhausted,
3153 and there's something on it->stack, call set_iterator_to_next to
3154 proceed with what's on the stack, instead of returning zero.
3155 (set_iterator_to_next): If called at the end of a Lisp string,
3156 proceed to consider_string_end without incrementing string
3157 position. Don't increment display vector index past the end of
3158 the display vector. (Bug#11417)
c8fb9dc6
EZ
3159 (pos_visible_p): Don't report a position visible when move_it_to
3160 stopped at the last line of window, which happens to be scanned
3161 backwards by the bidi iteration. (Bug#11464)
ac268e67 3162
e18afed7 31632012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3164
3165 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3166 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3167 are on a TTY, and thus unable to display on the fringes.
3168 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3169 so we need to signal to the caller that this is a "replacing"
3170 display spec. This fixes display when the spec is invalid or we
3171 are on a TTY.
3172
e18afed7 31732012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3174
3175 * unexaix.c (make_hdr): Fix typo in prototype.
3176 This bug broke the build on AIX. Problem reported by Gilles Pion.
3177
9d0a235a
MA
31782012-05-14 Michael Albinus <michael.albinus@gmx.de>
3179
3180 * keyboard.c (kbd_buffer_get_event): Read special events also in
3181 batch mode. (Bug#11415)
3182
9e6b06ed
GM
31832012-05-12 Glenn Morris <rgm@gnu.org>
3184
3185 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3186
c1a1d7a3
EZ
31872012-05-12 Eli Zaretskii <eliz@gnu.org>
3188
3189 * lisp.mk (lisp): Add newcomment.elc.
3190
3fe7cdc8
GM
31912012-05-12 Glenn Morris <rgm@gnu.org>
3192
3193 * Makefile.in (MKDIR_P): New, set by configure.
3194 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3195
53f7d2c0
PE
31962012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3197
3198 Remove unused function hourglass_started.
3199 * dispextern.h (hourglass_started):
3200 * w32fns.c (hourglass_started):
3201 * xdisp.c (hourglass_started): Remove.
3202
75aafb17
JB
32032012-05-10 Juanma Barranquero <lekktu@gmail.com>
3204
3205 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3206 Update dependencies.
3207
12959e8e
PE
32082012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3209
97107e2e
PE
3210 * xgselect.c (xg_select): Put maxfds+1 into a var.
3211 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3212
12959e8e
PE
3213 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3214
836d29b3
DA
32152012-05-10 Dave Abrahams <dave@boostpro.com>
3216
3217 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3218 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3219
5cb67954
MA
32202012-05-09 Michael Albinus <michael.albinus@gmx.de>
3221
3222 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3223 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3224 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3225 Initialize xd_registered_buses.
3226
3478ec45
PE
32272012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3228
b263a6b0
PE
3229 Untag more efficiently if USE_LSB_TAG.
3230 This is based on a proposal by YAMAMOTO Mitsuharu in
3231 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3232 For an admittedly artificial (nth 8000 longlist) benchmark on
3233 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3234 Emacs's overall text size by 1%.
3235 * lisp.h (XUNTAG): New macro.
3236 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3237 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3238 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3239 * eval.c (Fautoload):
3240 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3241 * frame.h (XFRAME): Use XUNTAG.
3242
3478ec45
PE
3243 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3244 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3245 Remove unportable assumptions about print widths of types like
3246 dbus_uint32_t.
3247 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3248 intptr_t when converting between pointer and integer, to avoid GCC
3249 warnings about wrong width.
3250
666b903b 32512012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3252
3253 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3254 stack for each reader_thread, instead of defaulting to 8MB
3255 determined by the linker. This avoids failures in creating
3256 subprocesses on Windows 7, see the discussion in this thread:
3257 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3258
b120cc17
JC
32592012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3260
3261 Fix up display of the *Minibuf-0* buffer in the mini window.
3262 * keyboard.c (read_char): Don't clear the echo area if there's no
3263 message to clear.
3264 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3265 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3266
9a4b36f8
MA
32672012-05-07 Michael Albinus <michael.albinus@gmx.de>
3268
3269 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3270 batch mode.
3271
e5f9458f
CY
32722012-05-06 Chong Yidong <cyd@gnu.org>
3273
3274 * lisp.mk (lisp): Update.
3275
eceeb5fc 32762012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3277
3278 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3279
71873e2b
SM
32802012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3281
3282 * data.c (PUT_ERROR): New macro.
3283 (syms_of_data): Use it. Add new error type `user-error'.
3284 * undo.c (user_error): New function.
3285 (Fprimitive_undo): Use it.
3286 * print.c (print_error_message): Adjust print style for `user-error'.
3287 * keyboard.c (user_error): New function.
3288 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3289
ab0fa4e4
PE
32902012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3291
3292 Do not limit current-time-string to years 1000..9999.
3293 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3294 (Fcurrent_time_string): Support any year that is supported by the
3295 underlying localtime representation. Don't use asctime, as it
3296 has undefined behavior for years outside the range -999..9999.
3297
7ed806a7
PE
32982012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3299
3300 Fix race conditions involving setenv, gmtime, localtime, asctime.
3301 Without this fix, interrupts could mess up code that uses these
3302 nonreentrant functions, since setting TZ invalidates existing
3303 tm_zone or tzname values, and since most of these functions return
3304 pointers to static storage.
3305 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3306 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3307 Grow the critical sections to include not just invoking
3308 localtime/gmtime, but also accessing these functions' results
3309 including their tm_zone values if any, and any related TZ setting.
3310 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3311 so that the struct tm is saved in the critical section.
3312 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3313 motivated by the fact that memory allocation needs to be outside
3314 the critical section.
3315
0c16dfed
DA
33162012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3317
3318 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3319 with RESET_INTERVAL.
3320
3321 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3322 Remove duplicated buffer name initialization.
3323
3f83ace8
JM
33242012-05-02 Jim Meyering <jim@meyering.net>
3325
3326 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3327
c7b8541e
JM
3328 * xfns.c (x_window): Use xstrdup (Bug#11375).
3329
90207a15 33302012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3331
3332 * xdisp.c (pos_visible_p): If already at a newline from the
3333 display string before the 'while' loop, don't walk back the glyphs
3334 from it3.glyph_row. Solves assertion violation when the display
3335 string begins with a newline (egg.el). (Bug#11367)
3336
b593d6a9
AH
33372012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3338
3339 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3340 Move to simple.el.
3341
4737362e
GM
33422012-05-01 Glenn Morris <rgm@gnu.org>
3343
99cf43f9
GM
3344 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3345 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3346 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3347 All were removed before 23.1.
3348
9311dcff
GM
3349 * dispnew.c: Remove HAVE_LIBNCURSES test;
3350 it is always true on relevant platforms.
3351
4d5c6349
GM
3352 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3353 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3354
4737362e
GM
3355 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3356
74dd3a6b
AS
33572012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3358
3359 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3360 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3361 Remove.
3362
13c379ee
PE
33632012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3364
3365 Do not avoid creating empty evaporating overlays (Bug#9642).
3366 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3367 That is, do not delete an evaporating overlay if it becomes
3368 empty after its bounds are adjusted to fit within its buffer.
3369 This fix caused other problems, and I'm reverting it until we get
3370 to the bottom of them.
3371
a8e7d6d7 33722012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3373
3374 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3375
a8e7d6d7 33762012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3377
3378 * xdisp.c (pos_visible_p): If the window start position is beyond
3379 ZV, start the display from buffer beginning. Prevents assertion
3380 violation in init_iterator when the minibuffer window is scrolled
3381 via the scroll bar.
3382
3383 * window.c (window_scroll_pixel_based): Likewise.
3384
a8e7d6d7 33852012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3386
3387 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3388
a8e7d6d7 33892012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3390
3391 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3392 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3393
a8e7d6d7 33942012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3395
b593d6a9
AH
3396 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3397 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3398
1c6900d9
EZ
33992012-04-26 Eli Zaretskii <eliz@gnu.org>
3400
4c3fa1d9
EZ
3401 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3402 display element, check also the underlying string or buffer
3403 character. (Bug#11341)
3404
1c6900d9
EZ
3405 * w32menu.c: Include w32heap.h.
3406 (add_menu_item): If the call to AppendMenuW (via
3407 unicode_append_menu) fails, disable Unicode menus only if we are
3408 running on Windows 9X/Me.
3409
42bf8205
AS
34102012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3411
3412 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3413 (xgetint): Add missing shift for LSB tags.
3414
b1bac16e
MR
34152012-04-24 Martin Rudalics <rudalics@gmx.at>
3416
3417 * keyboard.c (read_char): Don't wipe echo area for select window
3418 events: These might get delayed via `mouse-autoselect-window'
3419 (Bug#11304).
3420
d69621cc
JB
34212012-04-24 Juanma Barranquero <lekktu@gmail.com>
3422
3423 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3424 manipulation of :loaded-from data.
3425
02fd101b
JB
34262012-04-23 Juanma Barranquero <lekktu@gmail.com>
3427
3428 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3429 now a cons (bug#11311).
3430
888bec30
PE
34312012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3432
89a438bd
PE
3433 Do not create empty overlays with the evaporate property (Bug#9642).
3434 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3435 if it becomes empty after its bounds are adjusted to fit within
3436 its buffer. Without this fix, in a nonempty buffer (let ((o
3437 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3438 yields an empty overlay that has the evaporate property, which is
3439 not supposed to happen.
3440
1068fe4d
PE
3441 Fix minor GTK3 problems found by static checking.
3442 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3443 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3444 (struct _EmacsFixedClass, emacs_fixed_get_type):
3445 Move decls here from emacsgtkfixed.h, since they needn't be public.
3446 (emacs_fixed_get_type): Now static.
3447 (emacs_fixed_class_init): Omit unused local.
3448 (emacs_fixed_child_type): Remove; unused.
3449 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3450 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3451 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3452 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3453 (EMACS_FIXED_GET_CLASS): Remove; unused.
3454 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3455
888bec30
PE
3456 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3457 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3458
de85e130
PE
34592012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3460
d0baac98 3461 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3462 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3463 (__malloc_size_t, __malloc_ptrdiff_t):
3464 Remove. All uses removed, replaced by the definiens if needed,
3465 since we can assume C89 or better now.
3466 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3467 (protect_malloc_state, align, get_contiguous_space)
3468 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3469 (malloc_atfork_handler_child, malloc_enable_thread)
3470 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3471 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3472 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3473 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3474 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3475 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3476 Define using prototypes, not old style.
3477 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3478 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3479 (align): Don't assume that signed integer overflow wraps around.
3480 Omit unused local var.
3481 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3482 (_free_internal_nolock, memalign, mallochook, reallochook):
3483 Omit no-longer-needed casts.
3484 (valloc): Use getpagesize, not __getpagesize.
3485 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3486 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3487
de85e130
PE
3488 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3489
dcbf5805
MA
34902012-04-22 Michael Albinus <michael.albinus@gmx.de>
3491
3492 Move functions from C to Lisp. Make non-blocking method calls
3493 the default. Implement further D-Bus standard interfaces.
3494
3495 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3496 (QCdbus_request_name_allow_replacement)
3497 (QCdbus_request_name_replace_existing)
3498 (QCdbus_request_name_do_not_queue)
3499 (QCdbus_request_name_reply_primary_owner)
3500 (QCdbus_request_name_reply_in_queue)
3501 (QCdbus_request_name_reply_exists)
3502 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3503 (QCdbus_registered_serial, QCdbus_registered_method)
3504 (QCdbus_registered_signal): New Lisp objects.
3505 (XD_DEBUG_MESSAGE): Use sizeof.
3506 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3507 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3508 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3509 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3510 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3511 (xd_signature, xd_append_arg): Allow float for integer types.
3512 (xd_get_connection_references): New function.
b593d6a9
AH
3513 (xd_get_connection_address): Rename from xd_initialize.
3514 Return cached address.
dcbf5805
MA
3515 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3516 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3517 level.
3518 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3519 Return number of refcounts.
dcbf5805
MA
3520 (Fdbus_get_unique_name): Make stronger parameter check.
3521 (Fdbus_message_internal): New defun.
3522 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3523 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3524 (Fdbus_send_signal, Fdbus_register_service)
3525 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3526 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3527 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3528 (Vdbus_compiled_version, Vdbus_runtime_version)
3529 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3530 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3531 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3532 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3533 Adapt docstring.
dcbf5805 3534
52828e02
PE
35352012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3536
da05bc4c
PE
3537 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3538 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3539 Do not assume ptrdiff_t is the same width as 'int'.
3540
52828e02
PE
3541 * alloc.c: Handle unusual debugging option combinations.
3542 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3543 since the two debugging options are incompatible.
3544 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3545 is defined.
3546 (mem_init, mem_insert, mem_insert_fixup):
3547 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3548 (NEED_MEM_INSERT): Remove; no longer needed.
3549
f01769f9
LL
35502012-04-22 Leo Liu <sdl.web@gmail.com>
3551
3552 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3553
5790543d
PE
35542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3555
3556 * sysdep.c [__FreeBSD__]: Minor cleanups.
3557 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3558 Use Emacs indenting style more consistently. Avoid some casts.
3559 Use 'double' consistently rather than mixing 'float' and 'double'.
3560
b91b7e4d
EW
35612012-04-21 Eduard Wiebe <usenet@pusto.de>
3562
b593d6a9
AH
3563 * sysdep.c (list_system_processes, system_process_attributes):
3564 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3565
6114eb15
AS
35662012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3567
3568 * lisp.mk (lisp): Update.
3569
2f38dff7
PE
35702012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3571
3572 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3573 It is never used otherwise.
3574
4ae29f89
SM
35752012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3576
3577 * print.c (print_preprocess): Only check print_depth if print-circle
3578 is nil.
3579 (print_object): Check for cycles even when print-circle is nil and
3580 print-gensym is t, but only check print_depth if print-circle is nil.
3581
f30d612a
CY
35822012-04-20 Chong Yidong <cyd@gnu.org>
3583
3584 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3585 set the status to "failed" and ensure that sentinel is run.
3586
c07a4c0b 35872012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3588
3589 * process.c (Fset_process_inherit_coding_system_flag)
3590 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3591 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3592
c07a4c0b 35932012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3594
3595 * xdisp.c (string_buffer_position_lim): Limit starting position to
3596 BEGV.
3597 (set_cursor_from_row): If called for a mode-line or header-line
3598 row, return zero immediately.
3599 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3600 farther than the first row after the header line, if any.
3601 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3602 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3603
c07a4c0b 36042012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3605
4ae29f89
SM
3606 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3607 (bug#11238).
ad3a2b41 3608
c07a4c0b 36092012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 36102012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3611
3612 configure: new option --enable-gcc-warnings (Bug#11207)
3613 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3614 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3615 (ALL_CFLAGS): Use new macros rather than old.
3616 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3617 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3618 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3619 -Wunused-result, -Wunused-variable. This should go away once
3620 the Emacs and Gnulib regex code is merged.
3621 (xmalloc, xrealloc): Now static.
3622
aba027e8
PE
36232012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3624
3625 * dired.c (Fsystem_groups): Remove unused local.
3626
e5a36063
GM
36272012-04-17 Glenn Morris <rgm@gnu.org>
3628
3629 * dired.c (Fsystem_users): Doc fix.
3630
316411f0
DA
36312012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3632
3633 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3634 (syms_of_dired): Add them.
3635
9426aba4
PE
36362012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3637
b62a57be
PE
3638 Fix minor alloc.c problems found by static checking.
3639 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3640 New extern decls, to avoid calling undeclared functions.
3641 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3642 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3643 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3644 (NEED_MEM_INSERT): New macro.
3645 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3646 Remove one incorrect comment and fix another.
b62a57be 3647
3539f31f
PE
3648 Fix minor ralloc.c problems found by static checking.
3649 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3650 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3651 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3652 (r_alloc_sbrk): Now static.
3653
a041960a
PE
3654 Improve ralloc.c interface checking.
3655 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3656 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3657 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3658 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3659 [REL_ALLOC]: ... to here, to check interface.
3660 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3661 Remove decls. This fixes an "It stinks!".
3662
9426aba4
PE
3663 * alloc.c (which_symbols): Fix alignment issue / type clash.
3664
d55c12ed
AS
36652012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3666
3667 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3668 (struct Lisp_Misc_Any): Likewise.
3669 (struct Lisp_Free): Likewise.
3670 * alloc.c (union aligned_Lisp_Symbol): Define.
3671 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3672 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3673 (union aligned_Lisp_Misc): Define.
3674 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3675 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3676 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3677
b948ce8b
PE
36782012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3679
3680 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3681 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3682 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3683 * s/netbsd.h, s/sol2-6.h:
3684 Remove definition of GC_MARK_STACK, since the default now works.
3685 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3686 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3687 no longer the default.
3688 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3689
35dc09a1 36902012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3691
35dc09a1
GM
3692 * lread.c (lisp_file_lexically_bound_p):
3693 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3694
35dc09a1
GM
36952012-04-14 Eli Zaretskii <eliz@gnu.org>
3696
3697 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3698 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3699
37002012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3701
3702 * nsterm.m (constrainFrameRect): Always constrain when there is only
3703 one screen (Bug#10962).
3704
bcd86815
KB
37052012-04-13 Ken Brown <kbrown@cornell.edu>
3706
3707 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3708
c25df26e
RT
37092012-04-13 Reuben Thomas <rrt@sc3d.org>
3710
3711 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3712
0fc59f1e
DC
37132012-04-11 Daniel Colascione <dancol@dancol.org>
3714
3715 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3716 against is gone. It's better to use vfork now so that when Cygwin
3717 gains a new, working vfork, we use it automatically (bug#10398).
3718
de8c03dc
SM
37192012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3720
3721 * window.c (save_window_save): Obey window-point-insertion-type.
3722
2f097256
GM
37232012-04-11 Glenn Morris <rgm@gnu.org>
3724
3725 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3726
453b951e
SM
37272012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3728
3729 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3730
75f1671a 37312012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3732
3733 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3734 (force_quit_count): New var.
3735 (handle_interrupt): Use it.
3736
2a8ce227
JB
37372012-04-10 Juanma Barranquero <lekktu@gmail.com>
3738
3739 * w32.c (w32_delayed_load): Record the full path of the library
3740 being loaded (bug#10424).
3741
935396c0
GM
37422012-04-09 Glenn Morris <rgm@gnu.org>
3743
05920a43
GM
3744 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3745 not just in the obarray, before snarfing them. (Bug#11036)
3746
935396c0
GM
3747 * Makefile.in ($(leimdir)/leim-list.el):
3748 Pass EMACS rather than BUILT_EMACS.
3749
a18ecafa
TZ
37502012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3751
3752 * process.c (make_process):
3753 * process.h: Add integer `gnutls_handshakes_tried' member to
3754 process struct.
3755
6bbef4e5
JC
3756 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3757 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3758
3759 * gnutls.c (gnutls_log_function2i): Convenience log function.
3760 (emacs_gnutls_read): Use new log functions,
3761 `gnutls_handshakes_tried' process member, and
3762 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3763 attempts per process (connection).
3764
b4d3bc10
CY
37652012-04-09 Chong Yidong <cyd@gnu.org>
3766
3767 * eval.c (Fuser_variable_p, user_variable_p_eh)
3768 (lisp_indirect_variable): Functions deleted.
3769 (Fdefvar): Caller changed.
3770
3771 * callint.c (Finteractive, Fcall_interactively):
3772 * minibuf.c (Fread_variable): Callers changed.
3773
70f4d973
EZ
37742012-04-09 Eli Zaretskii <eliz@gnu.org>
3775
3776 * xdisp.c (set_cursor_from_row): If the display string appears in
3777 the buffer at position that is closer to point than the position
3778 after the display string, display the cursor on the first glyph of
3779 the display string. Fixes cursor display when a 'display' text
3780 property immediately follows invisible text. (Bug#11094)
3781
cb3c2e3e
PE
37822012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3783
3784 composite.c: use 'double' consistently
3785 * composite.c (get_composition_id): Use 'double' consistently
3786 instead of converting 'float' to 'double' and vice versa; this is
3787 easier to understand and avoids a GCC warning.
3788
fd06db5d
GM
37892012-04-09 Glenn Morris <rgm@gnu.org>
3790
50fe702a
GM
3791 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3792 preparation for dumping it with emacs. (Bug#4789)
3793 (leimdir): New variable.
3794 ($(leimdir)/leim-list.el): New rule.
3795 (emacs$(EXEEXT)): Depend on leim-list.el.
3796
fd06db5d
GM
3797 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3798 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3799 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3800
55c131ee
AS
38012012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3802
3803 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3804 proper alignment.
3805
9209588f
JB
38062012-04-07 Juanma Barranquero <lekktu@gmail.com>
3807
3808 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3809 Remove unused local variable.
3810
e3fb2efb
PE
38112012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3812
3813 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3814 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3815 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3816 objects, as mark_maybe_pointer will catch them otherwise.
3817 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3818 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3819
b5385551
PE
38202012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3821
3822 Fix typo that broke non-Windows builds.
3823 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3824
9078ead6
EZ
38252012-04-07 Eli Zaretskii <eliz@gnu.org>
3826
3827 Support building on MS-Windows with libxml2.
3828
3829 * makefile.w32-in (OBJ2): Add xml.$(O).
3830 (GLOBAL_SOURCES): Add xml.c.
3831 ($(BLD)/xml.$(O)): New dependency list.
3832
3833 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3834 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3835 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3836 [!WINDOWSNT]: New macros.
3837 (init_libxml2_functions, libxml2_loaded_p): New functions.
3838 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3839 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3840 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3841 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3842 linked in).
6bbef4e5
JC
3843 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3844 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3845 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3846
3847 * emacs.c: Don't include libxml/parser.h.
3848 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3849 xmlCleanupParser directly.
3850
3851 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3852
3811fdf3
EZ
38532012-04-07 Eli Zaretskii <eliz@gnu.org>
3854
3855 * indent.c (Fvertical_motion): If there is a display string at
3856 point, use it.vpos to compute how many lines to backtrack after
3857 move_it_to point. (Bug#11133)
3858
2f8e16b2
EZ
38592012-04-06 Eli Zaretskii <eliz@gnu.org>
3860
3861 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3862 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3863 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3864 macros related to unification of CJK characters. For the details,
3865 see the discussion following the message here:
3866 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3867
3d439cd1
CY
38682012-04-04 Chong Yidong <cyd@gnu.org>
3869
3870 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3871
8bc53d00
EZ
38722012-04-01 Eli Zaretskii <eliz@gnu.org>
3873
3874 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3875 instead of alloca. (Bug#11138)
3876
3b0512a3
AS
38772012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3878
3879 * w32menu.c (is_simple_dialog): Properly check lisp types.
3880 (Bug#11141)
3881
8427ddd2
EZ
38822012-03-31 Eli Zaretskii <eliz@gnu.org>
3883
979022ef
EZ
3884 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3885 position we get to after a call to move_it_to fails the
3886 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3887 only if we wind up in a string from display property. (Bug#11063)
3888
a6b1c7cc
EZ
3889 * window.c (Fdelete_other_windows_internal): Invalidate the row
3890 and column information about mouse highlight, so that redisplay
3891 restores it after reallocating the glyph matrices. (Bug#7464)
3892
8427ddd2
EZ
3893 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3894 string comes from a `display' text property, use the buffer
3895 position of that property as if we actually saw that position in
3896 the row's glyphs.
697ba24b
EZ
3897 (move_it_by_lines): Remove the assertion that
3898 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3899 violated when there's a before-string at the beginning of a line.
3900 (Bug#11063)
8427ddd2 3901
65a0a738
EZ
39022012-03-30 Eli Zaretskii <eliz@gnu.org>
3903
3904 * xdisp.c (append_space_for_newline): If the default face was
3905 remapped, use the remapped face for the appended newline.
3906 (extend_face_to_end_of_line): Use the remapped default face for
3907 extending the face to the end of the line.
3908 (display_line): Call extend_face_to_end_of_line when the default
3909 face was remapped. (Bug#11068)
3910
581355cc
EZ
39112012-03-29 Eli Zaretskii <eliz@gnu.org>
3912
3913 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3914
e8fc049f
SM
39152012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3916
3917 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3918
4fb9a543
GM
39192012-03-27 Glenn Morris <rgm@gnu.org>
3920
3921 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3922 Doc fixes.
3923
679910f1
KH
39242012-03-26 Kenichi Handa <handa@m17n.org>
3925
3926 * dispextern.h (struct glyph): Fix previous change. Change the
3927 bit length of glyphless.ch to 25 (Bug#11082).
3928
90d49b7f
CY
39292012-03-26 Chong Yidong <cyd@gnu.org>
3930
3931 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3932 (command_loop_1): Use it; inhibit selection update for
3933 handle-select-window too (Bug#8996).
3934
f514f6f0
FP
39352012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3936
e8fc049f 3937 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3938
bf43fa51
KH
39392012-03-25 Kenichi Handa <handa@m17n.org>
3940
3941 * dispextern.h (struct glyph): Change the bit length of
3942 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3943
8a0c01dd
EZ
39442012-03-24 Eli Zaretskii <eliz@gnu.org>
3945
3946 * s/ms-w32.h (tzname): Include time.h before redirecting to
3947 _tzname. Fixes the MSVC build. (Bug#9960)
3948
7d1c3a76
AS
39492012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3950
8ed79523
AS
3951 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3952 characters.
3953
7d1c3a76
AS
3954 * xterm.c (XTread_socket): Only modify handling_signal if
3955 !SYNC_INPUT. (Bug#11080)
3956
e99a9b8b
EZ
39572012-03-23 Eli Zaretskii <eliz@gnu.org>
3958
3959 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3960 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3961 when fetching a multibyte character consumes more bytes than
3962 CHAR_BYTES returns, due to unification of CJK characters in
3963 string_char. (Bug#11073)
3964
5063c0e1
TN
39652012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3966
3967 * process.c (wait_reading_process_output): Handle pty disconnect
3968 by refraining from sending oneself a SIGCHLD (bug#10933).
3969
9f851fbd
CY
39702012-03-22 Chong Yidong <cyd@gnu.org>
3971
3972 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3973
5063c0e1 3974 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3975 Mark string as coming from a prefix property.
3976 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3977 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3978
fb5b8aca
CY
39792012-03-21 Chong Yidong <cyd@gnu.org>
3980
3981 * xfaces.c (Vface_remapping_alist): Doc fix.
3982
62356a1b
EZ
39832012-03-20 Eli Zaretskii <eliz@gnu.org>
3984
3985 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3986 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3987 Doc fixes.
62356a1b 3988
025de85b
CY
39892012-03-20 Chong Yidong <cyd@gnu.org>
3990
3991 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3992 to reflect default non-nil value of redisplay-dont-pause.
3993
4827f94e
KH
39942012-03-19 Kenichi Handa <handa@m17n.org>
3995
3996 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3997 it fit in a valid range (Bug#11003).
3998
e50a24a2
EZ
39992012-03-18 Eli Zaretskii <eliz@gnu.org>
4000
4001 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4002 that is not from display property, accept the row as a "cursor
4003 row" if one of the string's character has a non-nil `cursor'
4004 property. Fixes cursor positioning when there are newlines in
4005 overlay strings, e.g. in icomplete.el. (Bug#11035)
4006
9af5ed87
PE
40072012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4008
4009 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4010
d1f55f16
CY
40112012-03-12 Chong Yidong <cyd@gnu.org>
4012
4013 * eval.c (inhibit_lisp_code): Rename from
4014 inhibit_window_configuration_change_hook; move from window.c.
4015
4016 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4017 * window.c (run_window_configuration_change_hook)
4018 (syms_of_window): Callers changed.
4019
66c5eebd
CY
40202012-03-11 Chong Yidong <cyd@gnu.org>
4021
413df973
CY
4022 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4023
66c5eebd
CY
4024 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4025
1de11f56
CY
40262012-03-10 Chong Yidong <cyd@gnu.org>
4027
4028 * frame.c (other_visible_frames): Don't assume the selected frame
4029 is visible (Bug#10955).
4030
cae07000
SM
40312012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4032
4033 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4034
89c94350
JD
40352012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4036
4037 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4038 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4039 zero (Bug#10954).
4040
999dd333
GM
40412012-03-03 Glenn Morris <rgm@gnu.org>
4042
01a6dcc8 4043 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4044
de0100f2
EZ
40452012-03-02 Eli Zaretskii <eliz@gnu.org>
4046
4047 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4048 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4049 (redisplay_window, next_element_from_string): Fix typos in
4050 comments.
3e441275
EZ
4051 (redisplay_window): Pass to move_it_vertically the margin in
4052 pixels, not in screen lines.
de0100f2 4053
96a72ee9
GM
40542012-03-02 Glenn Morris <rgm@gnu.org>
4055
4056 * buffer.c (buffer-list-update-hook): Doc fix.
4057
312508d7
EZ
40582012-02-29 Eli Zaretskii <eliz@gnu.org>
4059
4060 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4061 push_it before setting up the iterator for the first overlay
4062 string, even if we have an empty string loaded.
4063 (next_overlay_string): If there's an empty string on the iterator
4064 stack, pop the stack. (Bug#10903)
4065
27f3c637
PE
40662012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4067
4068 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4069 Suggested by Stefan Monnier in
4070 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4071 * alloc.c (widen_to_Lisp_Object): New static function.
4072 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4073 and widening them to Lisp_Objects. This would work even if
4074 USE_LSB_TAG is defined and wide integers are used, which might
4075 happen in a future version of Emacs.
4076
3c9dfce6
CY
40772012-02-25 Chong Yidong <cyd@gnu.org>
4078
fa74b241
CY
4079 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4080 Doc fix.
4081
3c9dfce6
CY
4082 * xselect.c (Fx_selection_exists_p): Doc fix.
4083 (x_clipboard_manager_save_all): Print an informative message
4084 before saving to clipboard manager.
4085
9486df08
CY
40862012-02-24 Chong Yidong <cyd@gnu.org>
4087
4088 * keyboard.c (process_special_events): Handle all X selection
4089 requests in kbd_buffer, not just the next one (Bug#8869).
4090
f01d3321
CY
40912012-02-23 Chong Yidong <cyd@gnu.org>
4092
4093 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4094 call when setting menu-bar-lines and tool-bar-lines parameters.
4095 (unwind_create_frame_1): New helper function.
4096
4097 * window.c (inhibit_window_configuration_change_hook): New var.
4098 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4099 (syms_of_window): Initialize it.
f01d3321 4100
86b847b6
CY
41012012-02-22 Chong Yidong <cyd@gnu.org>
4102
4103 * xterm.c (x_draw_image_relief): Add missing type check for
4104 Vtool_bar_button_margin (Bug#10743).
4105
a59225b1
CY
41062012-02-21 Chong Yidong <cyd@gnu.org>
4107
4108 * fileio.c (Vfile_name_handler_alist): Doc fix.
4109
4110 * buffer.c (Fget_file_buffer): Protect against invalid file
4111 handler return value.
4112
310f5bd4
PE
41132012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4114
cb3a28cc
PE
4115 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4116 when computing $valmask.
4117
310f5bd4
PE
4118 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4119 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4120 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4121 It's useless in that case, and it can cause problems on hosts
4122 that allocate halves of EMACS_INT values separately.
4123 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4124 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4125 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4126 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4127 it avoids undefined behavior on hosts where shifting right by more
4128 than the word width has undefined behavior.
4129
2375c96a
CY
41302012-02-19 Chong Yidong <cyd@gnu.org>
4131
4132 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4133 (Funhandled_file_name_directory, Ffile_name_as_directory)
4134 (Fdirectory_file_name, Fexpand_file_name)
4135 (Fsubstitute_in_file_name): Protect against invalid file handler
4136 return values (Bug#10845).
4137
3eb49e71
EZ
41382012-02-18 Eli Zaretskii <eliz@gnu.org>
4139
4140 * .gdbinit (pitx): Fix incorrect references to fields of the
4141 iterator stack.
4142
7b926f3f
CY
41432012-02-17 Chong Yidong <cyd@gnu.org>
4144
4145 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4146
11273115
PE
41472012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4148
4149 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4150 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4151
c3a70e2b
CY
41522012-02-15 Chong Yidong <cyd@gnu.org>
4153
4154 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4155 marked as special. Also, starting docstrings with * is obsolete.
4156
0ca43699
AS
41572012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4158
4159 * gnutls.c (emacs_gnutls_write): Fix last change.
4160
2e8f3c56
LI
41612012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4162
4163 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4164 send_process.
4165
af70074f
SM
41662012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4167
4168 * keymap.c (Fsingle_key_description): Handle char ranges.
4169
95986d52
CY
41702012-02-12 Chong Yidong <cyd@gnu.org>
4171
afd83bd1
CY
4172 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4173 as that creates a dangerous corner case.
4174
95986d52
CY
4175 * window.c (Fdelete_window_internal): Invalidate the mouse
4176 highlight (Bug#9904).
4177
bd7da63e
GM
41782012-02-12 Glenn Morris <rgm@gnu.org>
4179
4180 * xselect.c (Fx_own_selection_internal)
4181 (Fx_get_selection_internal, Fx_disown_selection_internal)
4182 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4183 * nsselect.m (Fx_own_selection_internal)
4184 (Fx_disown_selection_internal, Fx_selection_exists_p)
4185 (Fx_selection_owner_p, Fx_get_selection_internal):
4186 Sync docs and argument specs with the xselect.c versions.
4187
77abcbc2
LI
41882012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4189
4190 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4191
90b671e2
EZ
41922012-02-11 Eli Zaretskii <eliz@gnu.org>
4193
1c0ca0b7
EZ
4194 * w32select.c (Fx_selection_exists_p): Sync doc string and
4195 argument list with xselect.c. (Bug#10783)
4196
4197 * w16select.c (Fx_selection_exists_p): Sync doc string and
4198 argument list with xselect.c. (Bug#10783)
90b671e2 4199
49241268
GM
42002012-02-10 Glenn Morris <rgm@gnu.org>
4201
4202 * fns.c (Fsecure_hash): Doc fix.
4203
f998bbe7 42042012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4205
4206 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4207
0992bd9c
CY
42082012-02-07 Chong Yidong <cyd@gnu.org>
4209
4210 * buffer.c (Fbuffer_local_variables)
4211 (buffer_lisp_local_variables): Handle unbound vars correctly;
4212 don't let Qunbound leak into Lisp.
4213
af008560
GM
42142012-02-07 Glenn Morris <rgm@gnu.org>
4215
dd605cc4
GM
4216 * image.c (Fimagemagick_types): Doc fix.
4217
af008560
GM
4218 * image.c (imagemagick-render-type): Change it from a lisp object
4219 to an integer. Move the doc here from the lisp manual.
4220 Treat all values not equal to 0 the same.
4221
1449fa1d
CY
42222012-02-06 Chong Yidong <cyd@gnu.org>
4223
4224 * doc.c (store_function_docstring): Avoid applying docstring of
4225 alias to base function (Bug#2603).
4226
3723ec07
AS
42272012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4228
4229 * .gdbinit (pp1, pv1): Remove redundant defines.
4230 (pr): Use pp.
4231
79c1cc1e
CY
42322012-02-04 Chong Yidong <cyd@gnu.org>
4233
4234 * nsterm.m: Declare a global (Bug#10694).
4235
d7f29f8e
EZ
42362012-02-04 Eli Zaretskii <eliz@gnu.org>
4237
cae07000
SM
4238 * w32.c (get_emacs_configuration_options):
4239 Include --enable-checking, if specified, in the return value.
d7f29f8e 4240
3b95a6f9
MR
42412012-02-04 Martin Rudalics <rudalics@gmx.at>
4242
4243 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4244 after rounding frame sizes. (Bug#9723)
4245
d6fa96a6
EZ
42462012-02-04 Eli Zaretskii <eliz@gnu.org>
4247
4248 * keyboard.c (adjust_point_for_property): Don't position point
4249 before BEGV. (Bug#10696)
4250
df0b2940
PE
42512012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4252
4253 Handle overflow when computing char display width (Bug#9496).
4254 * character.c (char_width): Return EMACS_INT, not int.
4255 (char_width, c_string_width): Check for overflow when
4256 computing the width; this is possible now that individual
4257 characters can have unbounded width. Problem introduced
4258 by merge from Emacs 23 on 2012-01-19.
4259
6bee44d6
MA
42602012-02-02 Michael Albinus <michael.albinus@gmx.de>
4261
4262 * dbusbind.c (Fdbus_register_method): Mention the return value
4263 :ignore in the docstring.
4264
44f92739
GM
42652012-02-02 Glenn Morris <rgm@gnu.org>
4266
1b9f60cc
GM
4267 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4268
44f92739
GM
4269 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4270 Unconditionally set to t. (Bug#10673)
4271 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4272 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4273 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4274
c5d3843c
KH
42752012-02-02 Kenichi Handa <handa@m17n.org>
4276
4277 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4278 0, do not call append_composite_glyph.
4279
159462d4 42802012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4281
4282 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4283 NULL (Bug#6988).
4284 (x_produce_glyphs): If the component of a composition is a null
4285 string, set it->pixel_width to 1 to avoid zero-width glyph.
4286
78cef877
EZ
42872012-02-01 Eli Zaretskii <eliz@gnu.org>
4288
4289 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4290 first 2 arguments are identical. This makes inserting large
4291 output from a subprocess an order of magnitude faster on
4292 MS-Windows, where all sbrk'ed memory is always contiguous.
4293
97897668
GM
42942012-01-31 Glenn Morris <rgm@gnu.org>
4295
4296 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4297 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4298 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4299
31fd3586
GM
43002012-01-29 Glenn Morris <rgm@gnu.org>
4301
4302 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4303
0e24a8b2
CY
43042012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4305
4306 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4307
cc0adcb0
CY
43082012-01-28 Chong Yidong <cyd@gnu.org>
4309
4310 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4311
acc28cb9
CY
43122012-01-26 Chong Yidong <cyd@gnu.org>
4313
9c69cfb7
CY
4314 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4315
acc28cb9
CY
4316 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4317 repeat counts (Bug#10507).
4318
48da7392
GM
43192012-01-26 Glenn Morris <rgm@gnu.org>
4320
4321 * lread.c (syms_of_lread): Doc fix.
4322
14af5f7f
CY
43232012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4324
4325 * coding.c (encode_designation_at_bol): Change return value to
4326 EMACS_INT.
4327
0b21c100
CY
43282012-01-25 Chong Yidong <cyd@gnu.org>
4329
4330 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4331
3c2907f7
CY
43322012-01-21 Chong Yidong <cyd@gnu.org>
4333
4334 * floatfns.c (Fcopysign): Make the second argument non-optional,
4335 since nil is not allowed anyway.
4336
959ad23f
AS
43372012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4338
4339 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4340 (send_process): Likewise.
4341
34a02f46
MR
43422012-01-19 Martin Rudalics <rudalics@gmx.at>
4343
4344 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4345 (Vwindow_persistent_parameters): Do not use Qstate.
4346 Rewrite doc-strings.
34a02f46 4347
1259009a 43482012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4349
4350 * character.c (char_width): New function.
70d4fdf6
GM
4351 (Fchar_width, c_string_width, lisp_string_width):
4352 Use char_width (Bug#9496).
25ed9e61 4353
6a6ee00d
MR
43542012-01-16 Martin Rudalics <rudalics@gmx.at>
4355
4356 * window.c (Vwindow_persistent_parameters): New variable.
4357 (Fset_window_configuration, save_window_save): Handle persistent
4358 window parameters.
4359
c85efaf7
EZ
43602012-01-14 Eli Zaretskii <eliz@gnu.org>
4361
4362 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4363 thrashing the stack of the thread. (Bug#9087)
4364
5944709e
PE
43652012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4366
4367 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4368
e71f5d99
EZ
43692012-01-11 Eli Zaretskii <eliz@gnu.org>
4370
4371 * xdisp.c (rows_from_pos_range): Handle the case where the
4372 highlight ends on a newline. (Bug#10464)
4373 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4374 he end column for display of highlight that ends on a newline
4375 before a R2L line.
4376
ce316182
GM
43772012-01-11 Glenn Morris <rgm@gnu.org>
4378
4379 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4380 from load-path also when installation-directory is nil. (Bug#10208)
4381
5b43da69
GM
43822012-01-10 Glenn Morris <rgm@gnu.org>
4383
74cc8ff9
GM
4384 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4385
7d8d6e4e
GM
4386 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4387 Update template values to be closer to their typical values these days.
5b43da69 4388
a0db8d43
EZ
43892012-01-09 Eli Zaretskii <eliz@gnu.org>
4390
4391 * xdisp.c (rows_from_pos_range): Accept additional argument
4392 DISP_STRING, and accept any glyph in a row whose object is that
4393 string as eligible for mouse highlight. Fixes mouse highlight of
4394 display strings from overlays. (Bug#10464)
4395
9a0115ab 43962012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4397
b9110d6a 4398 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4399 * fileio.c (auto_saving_dir_umask): New static var.
4400 (Fmake_directory_internal): Use it.
4401 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4402 creating the directory. The old code temporarily assigns
4403 too-generous permissions to the directory.
4404 (do_auto_save_eh): Clear it.
b9110d6a 4405 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4406 that the var is always cleared.
4407
6c1bd3f3
EZ
44082012-01-07 Eli Zaretskii <eliz@gnu.org>
4409
4410 * search.c (scan_buffer): Pass character positions to
4411 know_region_cache, not byte positions. (Bug#6540)
4412
069d2b50
L
44132012-01-07 LynX <_LynX@bk.ru> (tiny change)
4414
4415 * w32.c (sys_rename): Report EXDEV when rename of a directory
4416 fails because the target is on another logical disk. (Bug#10284)
4417
75bf0d33
DB
44182012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4419
4420 * xterm.c (x_embed_request_focus): New function.
4421
4422 * xterm.h: Add prototype.
4423
4424 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4425
1c6e5a32
GM
44262012-01-05 Glenn Morris <rgm@gnu.org>
4427
4428 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4429
651e947e
EZ
44302012-01-01 Eli Zaretskii <eliz@gnu.org>
4431
4432 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4433 Load gnutls_transport_set_lowat only if GnuTLS version is below
4434 2.11.1.
4435 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4436 GnuTLS versions below 2.11.1.
4437
3778cdd8
AL
44382011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4439
4440 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4441 to the doc string advising against its use for altering the way
4442 windows are scrolled.
4443
0e5317f7
KH
44442011-12-28 Kenichi Handa <handa@m17n.org>
4445
4446 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4447 coding-system ASCII compatible only when it does not produce BOM
4448 on encoding (Bug#10383).
4449
93d5ca1f
JD
44502011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4451
4452 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4453 can scroll.
4454 (create_and_show_popup_menu): Always use menu_position_func for
4455 Gtk3 (Bug#10361).
4456
ca22b785
AS
44572011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4458
4459 * callint.c (Fcall_interactively): Don't truncate prompt string.
4460
d048e1e6
EZ
44612011-12-23 Eli Zaretskii <eliz@gnu.org>
4462
4463 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4464 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4465 resumed from there (after widening). (Bug#10360)
d048e1e6 4466
5ccaba1f
JD
44672011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4468
4469 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4470
204ee57f
JD
44712011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4472
b81d40f0
JB
4473 * nsterm.m (x_free_frame_resources):
4474 Release f->output_data.ns->miniimage.
204ee57f
JD
4475 (ns_index_color): Fix indentation. Do not retain
4476 color_table->colors[i].
4477
4478 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4479 before returning.
4480
4481 * nsfns.m (x_set_background_color): Assign return value from
4482 ns_index_color to face-background instead of NSColor*.
4483 (ns_implicitly_set_icon_type): Fix indentation.
4484 Change assignment in for loop to comparison.
4485
4486 * emacs.c (ns_pool): New variable.
4487 (main): Assign ns_pool.
4488 (Fkill_emacs): Call ns_release_autorelease_pool.
4489
4490 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4491 autorelease fdesc, release fdAttrs and tdict.
4492 (ns_get_covering_families): Release charset.
4493 (ns_findfonts): Release NSFontDescriptor created with new.
4494 (ns_uni_to_glyphs): Fix indentation.
4495 (setString): Release attrStr before assigning new value.
4496
c803b2b7
JD
44972011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4498
678f4426
JD
4499 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4500 and NS_IMPL_COCOA.
4501 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4502 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4503
cd394be1 45042011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4505
5fecd5fc
JD
4506 * nsterm.m (ns_term_init): Subscribe for notifications
4507 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4508 to method trackingNotification in EmacsMenu.
4509
4510 * nsmenu.m (trackingMenu): New variable.
3771cb17 4511 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4512 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4513 from Aquamacs (Bug#7030).
678f4426
JD
4514
45152011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4516
c803b2b7
JD
4517 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4518 (symbol_to_nsstring): Fix indentation.
4519 (ns_symbol_to_pb): New function.
cae07000
SM
4520 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4521 (Fns_rotate_cut_buffers_internal): Remove.
4522 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4523 Fns_store_cut_buffer_internal.
4524 (ns_get_foreign_selection, Fx_own_selection_internal)
4525 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4526 (Fns_get_selection_internal, Fns_store_selection_internal):
4527 Use ns_symbol_to_pb and check if return value is nil.
4528 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4529 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4530 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4531 renamed to Sns_store_selection_internal.
4532 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4533 and remove this function.
4534 (ns_handle_selection_clear): Remove, never used.
4535 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4536 here.
4537
e1b01a3a
KB
45382011-12-17 Ken Brown <kbrown@cornell.edu>
4539
4540 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4541 GID is unknown (Bug#10257).
4542
2adb6e85
PE
45432011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4544
4545 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4546 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4547 which caused a build failure on GNU/Linux IA-64. This problem was
4548 introduced by my 2011-10-07 patch.
4549
d1d7b339
JL
45502011-12-15 Juri Linkov <juri@jurta.org>
4551
4552 * image.c (imagemagick_error): New function. (Bug#10112)
4553 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4554 Use `imagemagick_error' where ImageMagick functions return
4555 `MagickFalse'.
4556 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4557 proper order.
4558
100d5755
KH
45592011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4560
4561 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4562 fill background (Bug#8992).
4563
454592a6
MR
45642011-12-13 Martin Rudalics <rudalics@gmx.at>
4565
4566 * window.c (Vwindow_combination_resize)
4567 (Vwindow_combination_limit): Use t instead of non-nil in
4568 doc-strings.
61d4b438
MR
4569 (Vrecenter_redisplay): Add first sentence of doc-string on
4570 separate line.
53524d93 4571 (Frecenter): Fix doc-string typo.
454592a6 4572
3633e3aa
KH
45732011-12-11 Kenichi Handa <handa@m17n.org>
4574
4575 * coding.c (Funencodable_char_position): Pay attention to the
4576 buffer text relocation (Bug#9389).
4577
7b9d523a 45782011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4579
7b9d523a
JD
4580 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4581 gtk_init (Bug#10100).
4582
b73189c6
EZ
45832011-12-10 Eli Zaretskii <eliz@gnu.org>
4584
4585 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4586 IT->string is nil. (Bug#10263)
4587
f7dfe5d6
JD
45882011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4589
83faebb4
JD
4590 * nsterm.h (x_free_frame_resources): Declare.
4591
f7dfe5d6
JD
4592 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4593 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4594
4595 * nsterm.h (ns_get_defaults_value): Declare.
4596
4597 * nsterm.m (ns_default): Call ns_get_defaults_value.
4598
7cd4e72c
EZ
45992011-12-09 Eli Zaretskii <eliz@gnu.org>
4600
4601 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4602 (Bug#10170)
4603
b34d7317
YM
46042011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4605
4606 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4607 that where the value of an _OBJC_* symbol points to is in the .bss
4608 section (Bug#10240).
4609
76470ad1
KH
46102011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4611
4612 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4613 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4614
745fff94
KH
46152011-12-08 Kenichi Handa <handa@m17n.org>
4616
4617 * ftfont.c (get_adstyle_property): Fix previous change
4618 (Bug#10233).
4619
6e44397c
JB
46202011-12-07 Juanma Barranquero <lekktu@gmail.com>
4621
4622 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4623 dirs from the default value of EMACSLOADPATH (bug#10208).
4624
7efa6272
GM
46252011-12-07 Glenn Morris <rgm@gnu.org>
4626
4627 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4628 installation and source directories as well. (Bug#10208)
4629
f6fc4d87
CY
46302011-12-06 Chong Yidong <cyd@gnu.org>
4631
4632 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4633
2bf26180
GM
46342011-12-06 Glenn Morris <rgm@gnu.org>
4635
4636 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4637 as an error, not just -1. (Bug#10217)
4638
3a6ad4f0
CY
46392011-12-05 Chong Yidong <cyd@gnu.org>
4640
4641 * keyboard.c (process_special_events): New function.
4642 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4643
75a3b399
PE
46442011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4645
4646 * coding.c (encode_designation_at_bol): Don't use uninitialized
4647 local variable (Bug#9318).
4648
c3c9e25e
KH
46492011-12-05 Kenichi Handa <handa@m17n.org>
4650
4651 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4652 return Qnil (Bug#8046, Bug#10193).
4653
5eb05ea3
KH
46542011-12-05 Kenichi Handa <handa@m17n.org>
4655
4656 * coding.c (encode_designation_at_bol): New args charbuf_end and
4657 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4658 (coding_set_source): Return how many bytes coding->source was
4659 relocated.
4660 (coding_set_destination): Return how many bytes
4661 coding->destination was relocated.
4662 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4663 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4664
46652011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4666
4667 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4668 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4669 macro (Bug#9318).
4670
46712011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4672
4673 The following changes are to fix Bug#9318.
4674
a79703f5 4675 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4676 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4677 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4678 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4679
7dbda6df
JB
46802011-12-05 Juanma Barranquero <lekktu@gmail.com>
4681
4682 * lisp.h (process_quit_flag): Fix external declaration.
4683
6d5eb5b0
SM
46842011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4685
4686 Don't macro-inline non-performance-critical code.
4687 * eval.c (process_quit_flag): New function.
4688 * lisp.h (QUIT): Use it.
4689
a0c3fad0
JD
46902011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4691
4692 * nsfns.m (get_geometry_from_preferences): New function.
4693 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4694
6c07aac2
AS
46952011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4696
4697 * emacs.c (Qkill_emacs): Define.
4698 (syms_of_emacs): Initialize it.
4699 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4700 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4701 (quit_throw_to_read_char): Add parameter `from_signal'.
4702 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4703 * lisp.h (QUIT): Call Fkill_emacs if requested.
4704
c052ead4
JD
47052011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4706
4707 * widget.c (update_wm_hints): Return if wmshell is null.
4708 (widget_update_wm_size_hints): New function.
4709
4710 * widget.h (widget_update_wm_size_hints): Declare.
4711
4712 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4713 widget_update_wm_size_hints (Bug#10104).
4714
9e49252b
EZ
47152011-12-03 Eli Zaretskii <eliz@gnu.org>
4716
4717 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4718 before a newline, prepare the bidi iterator for consuming the
4719 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4720 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4721
02b16839
JL
47222011-12-02 Juri Linkov <juri@jurta.org>
4723
4724 * search.c (Fword_search_regexp): New Lisp function created from
4725 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4726 (Fword_search_backward, Fword_search_forward)
4727 (Fword_search_backward_lax, Fword_search_forward_lax):
4728 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4729 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4730
0068070e
SM
47312011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4732
4733 * fileio.c (Finsert_file_contents): Move after-change-function call
4734 to before the "handled:" label, since all "goto handled" appear in
4735 cases where the *-change-functions have already been properly called
4736 (bug#10117).
4737
3360a3fc
AS
47382011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4739
4740 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4741 waiting for input. (Bug#10169)
4742
73d6c093
EZ
47432011-11-30 Eli Zaretskii <eliz@gnu.org>
4744
4745 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4746 verifies glyph row's hash code--we have just reallocated the
4747 glyphs, so their contents can be complete garbage. (Bug#10164)
4748
febe6bea
JB
47492011-11-30 Juanma Barranquero <lekktu@gmail.com>
4750
4751 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4752
801a4313
EZ
47532011-11-30 Eli Zaretskii <eliz@gnu.org>
4754
4755 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4756 attributes are tested _before_ calling verify_row_hash, to protect
4757 against GCC re-ordering of the tests. (Bug#10164)
4758
2b56b87e
JD
47592011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4760
4761 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4762
4763 * xterm.c (handle_one_xevent): Only set async_visible and friends
4764 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4765 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4766 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4767
dbf31225
PE
47682011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4769
4770 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4771 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4772 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4773 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4774 All uses changed to use GCPRO1 etc.
4775 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4776 Revert to old implementation (i.e., before 2011-03-11).
4777
1305621b
YM
47782011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4779
4780 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4781 of scroll runs so as to avoid assigning disabled bogus rows and
4782 unnecessary graphics copy operations.
4783
8c9afb46
EZ
47842011-11-27 Eli Zaretskii <eliz@gnu.org>
4785
4786 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4787 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4788 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4789 (malloc, free, realloc, calloc): Redirect to e_* only when
4790 compiling Emacs.
4791
4792 * lisp.h (GCTYPEBITS): Move before first use.
4793 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4794 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4795 this macro definition.
4796
4797 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4798 _MSC_VER.
4799
54e9e3bf
JD
48002011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4801
6d5eb5b0
SM
4802 * gtkutil.c (xg_create_frame_widgets):
4803 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4804 present with Gtk+ 2.0.
4805
83aca1cb
PE
48062011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4807
4808 * fileio.c (Finsert_file_contents): Undo previous change; see
4809 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4810
5b76caa4
PE
48112011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4812
4813 Rename locals to avoid shadowing.
4814 * fileio.c (Finsert_file_contents):
4815 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4816 * process.c (wait_reading_process_output):
4817 Rename inner 'proc' to 'p' to avoid shadowing.
4818 Indent for consistency with usual Emacs style.
4819
8c535114
EZ
48202011-11-25 Eli Zaretskii <eliz@gnu.org>
4821
4822 * xdisp.c (redisplay_window): If cursor row is not fully visible
4823 after recentering, and scroll-conservatively is set to a large
4824 number, scroll window by a few more lines to make the cursor fully
4825 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4826 (start_display): Don't move to the next line if the display should
4827 start at a newline that is part of a display vector or an overlay
4828 string. (Bug#10119)
8c535114 4829
fa4fdb5c
JL
48302011-11-24 Juri Linkov <juri@jurta.org>
4831
4832 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4833 after the `MagickPingImage' call. (Bug#10112)
4834
90ec88df
CY
48352011-11-23 Chong Yidong <cyd@gnu.org>
4836
4837 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4838
56e2e794
MR
48392011-11-23 Martin Rudalics <rudalics@gmx.at>
4840
4841 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4842 making another buffer current. (Bug#10114)
4843
b6e64c41
GM
48442011-11-23 Glenn Morris <rgm@gnu.org>
4845
4846 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4847
6b21de18
CY
48482011-11-23 Chong Yidong <cyd@gnu.org>
4849
4850 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4851 using it (Bug#5984).
4852
b12cd789
EZ
48532011-11-22 Eli Zaretskii <eliz@gnu.org>
4854
4855 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4856 and header-lines, as they don't have one computed for them.
4857 (Bug#10098)
4858
4859 * .gdbinit (prow): Make displayed values more self-explaining.
4860 Add row's hash code.
4861
261b6fd4
LMI
48622011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4863
4864 * process.c (wait_reading_process_output): Fix asynchrounous
4865 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4866 (wait_reading_process_output): Add comment and URL.
261b6fd4 4867
e7cfd277
JD
48682011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4869
4870 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4871
a9b9b7f5
CY
48722011-11-21 Chong Yidong <cyd@gnu.org>
4873
4874 * window.c (Fnext_window, Fprevious_window): Doc fix.
4875
b0d15b4f
SM
48762011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4877
4878 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4879
fe7a3057
JB
48802011-11-20 Juanma Barranquero <lekktu@gmail.com>
4881
4882 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4883
d2999b1a
MR
48842011-11-20 Martin Rudalics <rudalics@gmx.at>
4885
4886 * window.c (Fset_window_combination_limit): Rename argument
4887 STATUS to LIMIT.
4888 (Vwindow_combination_limit): Remove "status" from doc-string.
4889
d5ff9cd0
AS
48902011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4891
4892 * m/ibms390.h: Remove.
4893 * m/ibms390x.h: Don't include "ibms390.h".
4894
a5bb9bd3
SM
48952011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4896
4897 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4898 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4899
cd1181db
JB
49002011-11-20 Juanma Barranquero <lekktu@gmail.com>
4901
4902 * casetab.c (Fset_case_table):
4903 * charset.c (Fcharset_after): Fix typos.
4904
615a3b8d 49052011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4906
17e845af
PE
4907 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4908 Otherwise, valgrind does not work on some platforms.
4909 Problem reported by Andreas Schwab in
6a0bf43d
PE
4910 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4911 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4912 is set, removing the need for VIRT_ADDRESS_VARIES.
4913 (PURE_P): Use a more-efficient implementation that needs just one
4914 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4915 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4916 to 4 (xorl, subq, cmpq, setbe).
4917 * alloc.c (pure): Always extern now, since that's the
4918 VIRT_ADDR_VARIES behavior.
4919 (PURE_POINTER_P): Use a single comparison, not two, for
4920 consistency with the new puresize.h.
4921 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4922 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4923 Remove VIRT_ADDR_VARIES no longer needed.
4924
f8fe6f96
EZ
49252011-11-19 Eli Zaretskii <eliz@gnu.org>
4926
4927 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4928 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4929 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4930 behave as if the cursor position were at the window margin.
4931
4932 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4933 and the cursor position is out of bounds, behave as if the cursor
4934 position were at the window margin. (Bug#10075)
4935
df05a53c
CY
49362011-11-18 Chong Yidong <cyd@gnu.org>
4937
4938 * window.c (Fwindow_combination_limit): Make first argument
4939 non-optional, since it is meaningless for live windows like the
4940 selected window.
61ccba97 4941
2071918e
DA
49422011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4943
4944 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4945
b50a28de
SM
49462011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4947
4948 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4949 (graft_intervals_into_buffer): Simplify.
4950
015137db
EZ
49512011-11-18 Eli Zaretskii <eliz@gnu.org>
4952
4953 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4954 hash values of the two rows.
4955 (copy_row_except_pointers): Preserve the used[] arrays and the
4956 hash values of the two rows. (Bug#10035)
68c95424 4957 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4958
4959 * xdisp.c (row_hash): New function, body extracted from
4960 compute_line_metrics.
4961 (compute_line_metrics): Call row_hash, instead of computing the
4962 hash code inline.
4963
4964 * dispnew.c (verify_row_hash): Call row_hash for computing the
4965 hash code of a row, instead of duplicating code from xdisp.c.
4966
4967 * dispextern.h (row_hash): Add prototype.
4968
a2addb04
TH
49692011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4970
4971 * frame.c (delete_frame): Don't delete the terminal when the last
4972 X frame is closed if emacs is built with GTK toolkit.
4973
df85d315
JB
49742011-11-17 Juanma Barranquero <lekktu@gmail.com>
4975
4976 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4977
a0c2d0ae
MR
49782011-11-17 Martin Rudalics <rudalics@gmx.at>
4979
4980 * window.c (Vwindow_splits): Rename to
4981 Vwindow_combination_resize. Suggested by Juri Linkov.
4982 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4983 of Vwindow_splits.
4984
58179cce
JB
49852011-11-16 Juanma Barranquero <lekktu@gmail.com>
4986
7877f373
JB
4987 * nsfns.m (Fns_font_name):
4988 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4989
b6f67890
MR
49902011-11-16 Martin Rudalics <rudalics@gmx.at>
4991
4992 * window.h (window): Rename slot "nest" to "combination_limit".
4993 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4994 (Fset_window_nest): Rename to Fset_window_combination_limit.
4995 (Vwindow_nest): Rename to Vwindow_combination_limit.
4996 (recombine_windows, make_parent_window, make_window)
4997 (Fsplit_window_internal, saved_window)
4998 (Fset_window_configuration, save_window_save): Rename all
4999 occurrences of window_nest to window_combination_limit.
5000
c7015153
JB
50012011-11-15 Juanma Barranquero <lekktu@gmail.com>
5002
5003 * image.c (imagemagick_load_image): Fix typo.
5004
322ad6ec
EZ
50052011-11-14 Eli Zaretskii <eliz@gnu.org>
5006
5007 * xdisp.c (display_line): Move the call to
5008 highlight_trailing_whitespace before the call to
5009 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5010 faces of all the glyphs to compute ROW's hash value.
5011 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5012
f067b8ec
JB
50132011-11-14 Juanma Barranquero <lekktu@gmail.com>
5014
5015 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5016 just return (bug#10044).
5017
1e5b2111
EZ
50182011-11-12 Eli Zaretskii <eliz@gnu.org>
5019
7ef3cbd5
EZ
5020 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5021 with user-defined heap size. Bump the default size of the temacs
5022 heap to 27MB, to avoid memory warning when running temacs.
5023 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5024
1e5b2111
EZ
5025 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5026 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5027 (verify_row_hash) [XASSERTS]: New function.
5028 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5029 that the hash value of glyph rows is correct.
1e5b2111 5030
89d61221
MR
50312011-11-12 Martin Rudalics <rudalics@gmx.at>
5032
5033 * window.h (window): Remove splits slot.
5034 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5035 (Fdelete_other_windows_internal, make_parent_window)
5036 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5037 (Fset_window_configuration, save_window_save): Don't deal with
5038 split status of windows.
5039 (saved_window): Remove splits slot.
5040 (Vwindow_splits): Rewrite doc-string.
5041
97f18cc8
JD
50422011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5043
5044 * xfns.c (unwind_create_frame):
5045 * nsfns.m (unwind_create_frame):
5046 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5047 Vframe_list (Bug#9999).
5048
22a648b4
DA
50492011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5050
0b381c7e 5051 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5052
659afede
KH
50532011-11-11 Kenichi Handa <handa@m17n.org>
5054
5055 * callproc.c (Fcall_process): Set the member dst_multibyte of
5056 process_coding.
5057
9ac0394b
KH
50582011-11-11 Johan Bockgård <bojohan@gnu.org>
5059
5060 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5061 avoid a crash (bug#9496).
5062
2fbdc249
CY
50632011-11-09 Chong Yidong <cyd@gnu.org>
5064
5065 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5066 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5067
ac6b1f81
PE
50682011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5069
5070 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5071
09db192c
PE
50722011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5073
5074 Avoid some portability problems by eschewing 'extern inline' functions.
5075 The trivial performance wins aren't worth the portability hassles; see
5076 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5077 et seq.
5078 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5079 (window_box_width, window_box_left, window_box_left_offset)
5080 (window_box_right, window_box_right_offset): Undo previous change,
5081 by removing the "extern"s.
5082 * intervals.c (adjust_intervals_for_insertion)
5083 (adjust_intervals_for_deletion): Undo previous change,
5084 making these static again.
5085 (offset_intervals, temp_set_point_both, temp_set_point)
5086 (copy_intervals_to_string): No longer inline.
5087 * xdisp.c (window_text_bottom_y, window_box_width)
5088 (window_box_height, window_box_left_offset)
5089 (window_box_right_offset, window_box_left, window_box_right)
5090 (window_box): No longer inline.
5091
105216ed
CY
50922011-11-08 Chong Yidong <cyd@gnu.org>
5093
5094 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5095 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5096 Signal an error if not a live window.
105216ed
CY
5097 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5098 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5099
ae9e237f
JB
51002011-11-07 Juanma Barranquero <lekktu@gmail.com>
5101
5102 * lisp.h (syms_of_abbrev): Remove declaration.
5103 Reported by CHENG Gao <chenggao@royau.me>.
5104
c7aa8333
EZ
51052011-11-07 Eli Zaretskii <eliz@gnu.org>
5106
5107 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5108 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5109 of temacs in GUI mode.
5110
be7f5545
MR
51112011-11-07 Martin Rudalics <rudalics@gmx.at>
5112
5113 * window.h: Declare delete_all_child_windows instead of
5114 delete_all_subwindows.
5115 * window.c (Fwindow_nest, Fset_window_nest)
5116 (Fset_window_new_total, Fset_window_new_normal)
5117 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5118 (delete_all_subwindows): Rename to delete_all_child_windows.
5119 (Fdelete_other_windows_internal, Fset_window_configuration):
5120 Call delete_all_child_windows instead of delete_all_subwindows.
5121 * frame.c (delete_frame): Call delete_all_child_windows instead
5122 of delete_all_subwindows.
5123
ca78dc43
PE
51242011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5125
5126 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5127 This is also needed for porting to any host where GC_MARK_STACK is
5128 not GC_MAKE_GCPROS_NOOPS.
5129 (which_symbols): Use it.
5130
a0241d01
KH
51312011-11-07 Kenichi Handa <handa@m17n.org>
5132
5133 * coding.c (coding_set_destination): Check coding->src_pos only
5134 when coding->src_object is a buffer (bug#9910).
5135
5136 * process.c (send_process): Set the member src_multibyte of coding
5137 to 0 (bug#9911) when sending a unibyte text.
5138
5139 * callproc.c (Fcall_process): Set the member src_multibyte of
5140 process_coding to 0 (bug#9912).
5141
a64bfdfa 51422011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5143
5144 * xmenu.c (cleanup_widget_value_tree): New function.
5145 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5146 calling free_menubar_widget_value_tree directly (Bug#9830).
5147
cb41b32a
PE
51482011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5149
5150 Fix some portability problems with 'inline'.
5151 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5152 (window_box_width, window_box_left, window_box_left_offset)
5153 (window_box_right, window_box_right_offset): Declare extern.
5154 Otherwise, these inline functions do not conform to C99 and
5155 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5156 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5157 * intervals.c (adjust_intervals_for_insertion)
5158 (adjust_intervals_for_deletion): Now extern, because otherwise the
5159 extern inline functions 'offset_intervals' couldn't refer to it.
5160 (static_offset_intervals): Remove.
5161 (offset_intervals): Rewrite using the old contents of
5162 static_offset_intervals. The old version didn't conform to C99
5163 because an extern inline function contained a reference to an
5164 identifier with static linkage.
5165
b7041366
AS
51662011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5167
5168 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5169 GC.
5170
88a37c4d
EZ
51712011-11-06 Eli Zaretskii <eliz@gnu.org>
5172
5173 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5174 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5175 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5176 return Qleft_to_right.
5177
49745b39
CY
51782011-11-06 Chong Yidong <cyd@gnu.org>
5179
5180 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5181 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5182 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5183 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5184 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5185 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5186 (Fwindow_vscroll): Doc fix.
5187 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5188 argument, since it makes no sense to pass a live window and for
5189 consistency with window-child.
5190
1f05cd82
CS
51912011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5192
5193 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5194 support MSVC.
5195
22610910
JR
51962011-11-05 Jason Rumney <jasonr@gnu.org>
5197
5198 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5199 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5200 fonts (Bug#6029).
5201 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5202 bitwise arithmetic preventing use of unicode-sip and non-truetype
5203 opentype fonts.
5204
a06776b2
EZ
52052011-11-05 Eli Zaretskii <eliz@gnu.org>
5206
3ad924ba
EZ
5207 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5208 "emacs"-only part.
5209
a06776b2
EZ
5210 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5211 initialization code to keep similarity to xfns.c after changes
5212 from 2011-11-05.
5213
c9e7db78
JD
52142011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5215
a97f8f3f
JD
5216 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5217 (unwind_create_frame): New function (Bug#9943).
5218 (Fx_create_frame): Restructure code to be more similar to the one in
5219 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5220 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5221 Move terminal->reference_count++ just before making the frame official
5222 (Bug#9943).
5223
5224 * nsterm.m (x_free_frame_resources): New function.
5225 (x_destroy_window): Move code to x_free_frame_resources.
5226
c9e7db78 5227 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5228 (Fx_create_frame, x_create_tip_frame):
5229 Move terminal->reference_count++ just before making the frame
75f1671a 5230 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5231 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5232
a6fc3b5c
EZ
52332011-11-05 Eli Zaretskii <eliz@gnu.org>
5234
5235 Support MSVC build with newer versions of Visual Studio.
5236 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5237 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5238 nt/gmake.defs.
5239
5240 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5241 which are not supported by MSVC.
5242 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5243 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5244 bitfields.
5245 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5246 types in bitfields.
5247 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5248
5249 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5250
58179cce 52512011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5252
5253 Support MSVC build with newer versions of Visual Studio.
5254 * w32.c: Don't include w32api.h for MSVC.
5255 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5256
5257 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5258 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5259 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5260 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5261 e_* cousins.
5262 (alloca) [_MSC_VER]: Define to _alloca.
5263
5264 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5265
5266 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5267
a58c13ed
EZ
52682011-11-04 Eli Zaretskii <eliz@gnu.org>
5269
5270 * xdisp.c (note_mouse_highlight): If either of
5271 previous/next-single-property-change returns nil, treat that as
5272 the beginning or the end of the buffer. (Bug#9955)
5273
fe0b6370
JD
52742011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5275
a58c13ed 5276 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5277 label is not null (Bug#9951).
5278 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5279 may be NULL.
5280
89bd5ee1
EZ
52812011-11-04 Eli Zaretskii <eliz@gnu.org>
5282
5283 * window.c (Fwindow_body_size): Mention in the doc string that the
5284 return value is in frame's canonical units. (Bug#9949)
5285
84c3edb9
EZ
52862011-11-03 Eli Zaretskii <eliz@gnu.org>
5287
4e2fb5c7
EZ
5288 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5289
84c3edb9 5290 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5291 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5292 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5293
bc17a887
EZ
52942011-11-01 Eli Zaretskii <eliz@gnu.org>
5295
5296 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5297 Don't stop backward scan on the continuation glyph, even though
5298 its CHARPOS is positive.
6d5eb5b0
SM
5299 (mouse_face_from_buffer_pos, note_mouse_highlight):
5300 Rename cover_string to disp_string.
bc17a887 5301
4ee88440
MR
53022011-11-01 Martin Rudalics <rudalics@gmx.at>
5303
5304 * window.c (temp_output_buffer_show): Don't use
5305 Vtemp_buffer_show_specifiers.
5306 (Vtemp_buffer_show_specifiers): Remove unused variable.
5307
c2ff3c02
EZ
53082011-10-30 Eli Zaretskii <eliz@gnu.org>
5309
5310 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5311 past the beginning of the current glyph matrix.
5312
58179cce 53132011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5314
5315 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5316 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5317 HAVE_GTK3 (Bug#9869).
b77a6a7f 5318
3b574623
JD
5319 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5320 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5321
b77a6a7f
JD
5322 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5323
5324 * xterm.c: Declare x_handle_net_wm_state to return int.
5325 (handle_one_xevent): Check if we are iconified but don't have
5326 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5327 (get_current_wm_state): Return non-zero if not hidden,
5328 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5329 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5330 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5331 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5332
196e41e4
PE
53332011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5334
5335 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5336 so that this new function doesn't get optimized away by a
5337 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5338
021f2e1a
AS
53392011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5340
5341 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5342
8b058d44
EZ
53432011-10-29 Eli Zaretskii <eliz@gnu.org>
5344
5345 Fix the `xbytecode' command.
5346 * .gdbinit (xprintbytestr): New command.
b50a28de 5347 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5348 (xbytecode): Print the byte-code string as well.
5349
4452fb80
EZ
53502011-10-29 Kim Storm <storm@cua.dk>
5351
8b058d44
EZ
5352 * alloc.c (which_symbols): New function.
5353
21b72067
AS
53542011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5355
5356 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5357 line. (Bug#9903)
5358
83ed7b5c
GM
53592011-10-29 Glenn Morris <rgm@gnu.org>
5360
5361 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5362 Not clear what it was for, and it causes various bugs. (Bug#9839)
5363
5a7a728b
EZ
53642011-10-28 Eli Zaretskii <eliz@gnu.org>
5365
5366 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5367 possible random value that matches one of those tested as
5368 condition to clear the mouse face.
5369
d3d0842f
CY
53702011-10-28 Chong Yidong <cyd@gnu.org>
5371
5372 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5373
31b39d13
DN
53742011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5375
5376 * window.c (make_window): Initialize phys_cursor_on_p.
5377
9aba6043
SM
53782011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5379
5380 * lisp.h (struct Lisp_Symbol): Update comments.
5381
c20992f4
JB
53822011-10-28 Juanma Barranquero <lekktu@gmail.com>
5383
5384 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5385
db4f02f2
EZ
53862011-10-28 Eli Zaretskii <eliz@gnu.org>
5387
5388 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5389 <oslsachem@gmail.com> for helping to debug this.
5390
5391 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5392 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5393 (g_b_init_get_glyph_outline_w): New static variables.
5394 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5395 (GetGlyphOutlineW_Proc): New typedefs.
5396 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5397 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5398 New functions.
5399 (w32font_open_internal, compute_metrics):
5400 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5401 instead of calling the "wide" APIs directly.
5402
5403 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5404
5405 * w32.h (syms_of_w32font): Add prototype.
5406
87e68db4
JB
54072011-10-27 Juanma Barranquero <lekktu@gmail.com>
5408
5409 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5410 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5411 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5412 (Fmove_to_window_line): Doc fix.
5413
435c1d67
CY
54142011-10-27 Chong Yidong <cyd@gnu.org>
5415
5416 * process.c (make_process): Set gnutls_state to NULL.
5417
5418 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5419 non-NULL, regardless of GNUTLS_INITSTAGE.
5420 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5421 an error. Set process slots as soon as we allocate them.
5422
5423 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5424
9c6c6f49
CY
54252011-10-27 Chong Yidong <cyd@gnu.org>
5426
9aba6043
SM
5427 * gnutls.c (emacs_gnutls_deinit): New function.
5428 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5429 (Fgnutls_deinit, Fgnutls_boot): Use it.
5430
5431 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5432 (deactivate_process): Call emacs_gnutls_deinit.
5433
657d08d3
JB
54342011-10-27 Juanma Barranquero <lekktu@gmail.com>
5435
5436 * image.c (x_create_x_image_and_pixmap):
5437 * w32.c (sys_rename, w32_delayed_load):
5438 * w32font.c (fill_in_logfont):
5439 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5440
5430d399
JB
54412011-10-26 Juanma Barranquero <lekktu@gmail.com>
5442
5443 * w32fns.c (w32_default_color_map): New function,
5444 extracted from Fw32_default_color_map.
a7ef684b 5445 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5446
fe0055fa
PE
54472011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5448
5449 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5450
e6346438
SM
54512011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5452
5453 * keyboard.c (test_undefined): New function (bug#9751).
5454 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5455
e112cc37
ET
54562011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5457
5458 * sysdep.c (init_sys_modes): Fix the check for the controlling
5459 terminal (Bug#6649).
5460
7b5d6677
EZ
54612011-10-20 Eli Zaretskii <eliz@gnu.org>
5462
5463 * dispextern.h (struct bidi_it): New member next_en_type.
5464
5465 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5466 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5467 current character, check also for next_en_type being WEAK_EN.
5468 (bidi_resolve_weak): Don't enter the expensive loop if the current
5469 position is before next_en_pos. Record the bidi type of the first
5470 non-ET, non-BN character we find, in addition to its position.
5471 (bidi_level_of_next_char): Invalidate next_en_type when
5472 next_en_pos is over-stepped.
5473
7da0b018
PE
54742011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5475
5476 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5477 * editfns.c: Rewrite current-time-zone so that it invokes
5478 the equivalent of (format-time-string "%Z") to get the time zone name.
5479 This fixes a bug when the time zone name contains characters that
5480 need converting from the system time locale to Emacs internal format.
5481 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5482 that patch fixed format-time-string to do the conversion, but
5483 I forgot to fix current-time-zone.
5484 (format_time_string): New function, containing most of
5485 what Fformat_time_string used to contain.
5486 (Fformat_time_string): Rewrite in terms of format_time_string.
5487 This doesn't change this function's behavior.
5488 (current-time-zone): Rewrite to use format_time_string.
5489 This fixes the bug reported by Michael Schierl in
5490 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5491 Jason Rumney's 2007-06-07 change worked around this bug, but
5492 didn't fix it.
5493 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5494
8547b010
EZ
54952011-10-19 Eli Zaretskii <eliz@gnu.org>
5496
5497 * xdisp.c (start_display): If the character at POS is displayed
5498 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5499 (try_window_reusing_current_matrix): If a line ends in a display
5500 vector or the next line starts in a display vector, continue
5501 redrawing the window even though the character position of
5502 start_row was reached.
8547b010
EZ
5503 (Bug#9771, part 2)
5504
4e948d15
CY
55052011-10-18 Chong Yidong <cyd@gnu.org>
5506
5507 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5508 with nobreak-char-display too.
5509
4787455f
EZ
55102011-10-18 Eli Zaretskii <eliz@gnu.org>
5511
5512 Fix part 3 of bug#9771.
5513 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5514 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5515 non-neutral characters if the current character is a paragraph
5516 separator (a.k.a. Newline). This avoids running the same
5517 expensive loop twice, once when we consume the preceding newline
5518 and the other time when the line actually needs to be displayed.
5519 Avoid the loop when we see neutrals on the base embedding level
5520 following a character whose directionality is the same as the
5521 paragraph's. This avoids running the expensive loop when a line
5522 ends in a long sequence of neutrals, like control characters.
5523 Add assertion against STRONG_AL type. Slightly rearrange code
5524 that determines the type of a neutral given the first non-neutral
5525 that follows it.
5526 (bidi_level_of_next_char): Set next_en_pos to zero when
5527 invalidating its info.
5528
2c91f553
EZ
55292011-10-17 Eli Zaretskii <eliz@gnu.org>
5530
5531 * xdisp.c (push_display_prop): Determine whether to record string
5532 or buffer position by IT->string, not by IT->method. Allow
5533 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5534 (move_it_vertically_backward): Don't look for character position
5535 immediately after the newline when in a continuation line.
5536 (Bug#9771, part 1)
2c91f553 5537
c7b08b0d
MR
55382011-10-15 Martin Rudalics <rudalics@gmx.at>
5539
5540 * window.c (coordinates_in_window): Rewrite and delabelize
5541 vertical border check. (Bug#5357) (Bug#9618)
5542
6b02f655
SM
55432011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5544
5545 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5546 errors in XSetWindowBorder (bug#9310).
5547
81d40c92
DA
55482011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5549
5550 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5551 avoid crash when xmalloc overrun checking is enabled.
5552
d4172c3b
EZ
55532011-10-13 Eli Zaretskii <eliz@gnu.org>
5554
5555 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5556 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5557 cursor motion with <left> and <right> arrow keys.
5558
5559 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5560 some callers set that themselves.
5561
b00eea75
EZ
55622011-10-12 Eli Zaretskii <eliz@gnu.org>
5563
5564 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5565 display string and the previous row comes from the same string and
5566 is empty. (Bug#9739) (Bug#9738)
5567
8fe012c4
SM
55682011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5569
5570 * doc.c (get_doc_string): Encode file name (bug#9735).
5571
0074aef2
EZ
55722011-10-12 Eli Zaretskii <eliz@gnu.org>
5573
79beb178
EZ
5574 * bidi.c (bidi_level_of_next_char):
5575 * xdisp.c (get_visually_first_element): Remove old incorrect
5576 comments regarding the Unicode Line Separator character.
5577
0074aef2
EZ
5578 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5579
6e4b3fbe
DA
55802011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5581
5582 * alloc.c (Fgc_status): Do not access beyond zombies array
5583 boundary if nzombies > MAX_ZOMBIES.
5584 * alloc.c (dump_zombies): Add missing format specifier.
5585
0324f3af
PE
55862011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5587
b5525cac
PE
5588 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5589 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5590
0324f3af
PE
5591 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5592 Some packages use them to denote characters with modifiers.
5593
e9b5f888
AS
55942011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5595
5596 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5597 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5598 matching a pp-number. Rename parameter var to var1.
5599
127827c0
SM
56002011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5601
5602 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5603
c8fd3bd0
GM
56042011-10-08 Glenn Morris <rgm@gnu.org>
5605
5606 * callint.c (Fcall_interactively): Give a more explicit error for the
5607 'c' case with a non-character input. (Bug#8479)
5608
352ec8ff
EZ
56092011-10-08 Eli Zaretskii <eliz@gnu.org>
5610
03669ccb
EZ
5611 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5612 lines.
7061c986
EZ
5613 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5614 lines that are hscrolled on the left.
03669ccb 5615
352ec8ff
EZ
5616 * dispnew.c (buffer_posn_from_coords): Account for a possible
5617 presence of header-line. (Bug#4426)
5618
a66cfb1c
SM
56192011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5620
6b02f655
SM
5621 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5622 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5623
7c5ee88e
PE
56242011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5625
5626 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5627 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5628 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5629 this makes Emacs dump core during garbage collection on rare
5630 occasions. sizeof is obviously inferior to offsetof here, so
5631 stick with offsetof.
5632 (GC_POINTER_ALIGNMENT): New macro.
5633 (mark_memory): Omit 3rd (offset) arg; caller changed.
5634 Don't assume EMACS_INT alignment is the same as pointer alignment.
5635
df1bbe5b
SM
56362011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5637
5638 * keyboard.c (read_key_sequence_remapped): New var.
5639 (read_key_sequence): Compute remapping in the right buffer.
5640 (command_loop_1): Use read_key_sequence's remapping directly.
5641
51553db6
SM
56422011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5643
32c1fffd
SM
5644 * dired.c (file_name_completion): Don't expand file name.
5645 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5646 before checking file name handler.
5647
51553db6
SM
5648 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5649 they've been requested explicitly (bug#9591).
5650
b6bd1599 56512011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5652
5653 * keymap.c (Fsingle_key_description): Use make_specified_string
5654 instead of build_string to build string from push_key_description.
5655 (Bug#5193)
5656
f701dc2a
PE
56572011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5658
4222c55d
PE
5659 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5660 This fixes a Y2038 bug on 64-bit hosts.
5661 * buffer.c (reset_buffer):
5662 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5663 (Fclear_buffer_auto_save_failure):
5664 Use 0, not -1, to represent an unset failure time, since time_t
5665 might not be signed.
5666
f701dc2a
PE
5667 Remove dependency on glibc malloc internals.
5668 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5669 Move back here from lisp.h, but with their new implementations.
5670 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5671 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5672 * charset.c (charset_table_init): New static var.
5673 (syms_of_charset): Use it instead of xmalloc. This removes a
5674 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5675 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5676 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5677 Move back to alloc.c.
5678 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5679 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5680
9ceebf39
JD
56812011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5682
5683 * nsterm.m (windowDidResize): Call x_set_window_size only when
5684 ns_in_resize is true. Otherwise set pixelwidth/height and
5685 call change_frame_size (Bug#9628).
5686
cb993c58
PE
56872011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5688
3930c88b
PE
5689 Port --enable-checking=all to Fedora 14 x86-64.
5690 * charset.c (syms_of_charset): Also account for glibc malloc's
5691 internal overhead when calculating the initial malloc maximum.
5692
cb993c58
PE
5693 Port --enable-checking=all to Fedora 14 x86.
5694 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5695 Move to lisp.h.
5696 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5697 (overrun_check_realloc, overrun_check_free):
5698 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5699 That way, xmalloc returns a properly-aligned pointer even if
5700 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5701 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5702 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5703 into account when calculating the initial malloc maximum.
5704 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5705 Move here from alloc.c, so that charset.c can use it too.
5706 Properly align; the old code wasn't right for common 32-bit hosts
5707 when configured with --enable-checking=all.
5708 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5709 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5710
31bed486
EZ
57112011-09-29 Eli Zaretskii <eliz@gnu.org>
5712
04c70788 5713 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5714 use EDOM.
5715
fbcaa2f3
EZ
57162011-09-28 Eli Zaretskii <eliz@gnu.org>
5717
5718 * xdisp.c (compute_display_string_end): If there's no display
5719 string at CHARPOS, return -1.
5720
5721 * bidi.c (bidi_fetch_char): When compute_display_string_end
5722 returns a negative value, treat the character as a normal
5723 character not covered by a display string. (Bug#9624)
5724
a239d4e9
JB
57252011-09-28 Juanma Barranquero <lekktu@gmail.com>
5726
5727 * lread.c (Fread_from_string): Fix typo in docstring.
5728
88652fd5
EZ
57292011-09-27 Eli Zaretskii <eliz@gnu.org>
5730
5731 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5732 newline, reseat the iterator instead of bidi-iterating there one
5733 character at a time. (Bug#9610)
32c1fffd
SM
5734 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5735 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5736
ed497dd4
AS
57372011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5738
5739 * lread.c (readevalloop): Use correct code for NBSP.
5740 (read1): Likewise. (Bug#9608)
5741
b2bf61aa
MA
57422011-09-25 Michael Albinus <michael.albinus@gmx.de>
5743
5744 * dbusbind.c (Fdbus_register_signal): When service is not
5745 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5746
32bbb17c
GM
57472011-09-25 Glenn Morris <rgm@gnu.org>
5748
5749 * buffer.c (truncate-lines): Doc fix.
5750
94e0933e
CY
57512011-09-24 Chong Yidong <cyd@stupidchicken.com>
5752
5753 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5754 (Fset_window_next_buffers): Doc fix.
5755
cddde921
GM
57562011-09-24 Glenn Morris <rgm@gnu.org>
5757
5758 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5759
1260aef1
PE
57602011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5761
25b4bfa0
PE
5762 Fix minor problems found by static checking.
5763 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5764 * indent.c (Fvertical_motion): Fix == vs = typo.
5765
e3cbd34b
EZ
57662011-09-24 Eli Zaretskii <eliz@gnu.org>
5767
a66cfb1c
SM
5768 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5769 Default value is now t. Doc fix.
6bf7006f 5770
e3cbd34b 5771 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5772 logic when moving up, not only when moving down. Fix the
e3cbd34b 5773 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5774 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5775
5776 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5777 CHARPOS is covered by a display string which includes newlines.
5778 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5779 is covered by a display string with embedded newlines.
5780
a3de0cbd
MA
57812011-09-24 Michael Albinus <michael.albinus@gmx.de>
5782
5783 * dbusbind.c (Fdbus_register_signal): Add match rule to
5784 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5785 (Fdbus_register_method, Vdbus_registered_objects_table):
5786 Fix docstring.
a3de0cbd 5787
b260039d
JM
57882011-09-24 Jim Meyering <meyering@redhat.com>
5789
32c1fffd 5790 do not ignore write error for any output size
b260039d
JM
5791 The previous change was incomplete.
5792 While it makes emacs --batch detect the vast majority of stdout
5793 write failures, errors were still ignored whenever the output size is
5794 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5795 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5796 && echo FAIL: ignored write error
5797 FAIL: ignored write error
5798 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5799 && echo FAIL: ignored write error
5800 FAIL: ignored write error
5801 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5802
8eca8a7c
AS
58032011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5804
5805 * emacs.c (Fkill_emacs): In noninteractive mode exit
5806 non-successfully if a write error occurred on stdout. (Bug#9574)
5807
3341db62
EZ
58082011-09-21 Eli Zaretskii <eliz@gnu.org>
5809
5810 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5811 the xassert test.
5812
5813 * dispextern.h (struct it): Update the comment documenting what
5814 can it->OBJECT be.
5815
8c203dbf
EZ
58162011-09-20 Eli Zaretskii <eliz@gnu.org>
5817
5818 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5819 a display string, extend search for cursor position to end of row.
5820 (find_row_edges): If the row ends in a newline from a display
5821 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5822 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5823 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5824 non-empty line. Fixes confusing cursor motion with arrow keys at
5825 the beginning of a line that starts with whitespace.
8c203dbf 5826
a4824228
LMI
58272011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5828
5829 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5830 (bug#9493).
5831
33ed493b
CY
58322011-09-18 Chong Yidong <cyd@stupidchicken.com>
5833
5834 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5835 boolean (Bug#9154).
5836
56cd55c8
EZ
58372011-09-18 Eli Zaretskii <eliz@gnu.org>
5838
5839 * xdisp.c (display_line): Record maximum and minimum buffer
5840 positions even if no glyphs were produced (e.g., by a zero-width
5841 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5842 buffer positions that will be removed from the glyph row because
5843 they don't fit.
c02dcedf
EZ
5844 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5845 column is beyond frame width: don't subtract 1 "pixel" when
5846 computing width of the stretch.
3e62b7e0
EZ
5847 (reseat_at_next_visible_line_start): Undo the change made on
5848 2011-09-17 that saved paragraph information and restored it after
5849 the call to `reseat'. (Bug#9545)
56cd55c8 5850
5ed99d36 58512011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5852
5853 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5854 and turn window cursor on if cleared (Bug#9415).
5855
5ed99d36 58562011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5857
5858 * search.c (boyer_moore): Take unibyte characters from pattern
5859 literally. (Bug#9458)
5860
9bade7b2
EZ
58612011-09-18 Eli Zaretskii <eliz@gnu.org>
5862
5863 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5864
e5e9d610
PE
58652011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5866
87e4427a
PE
5867 Fix minor problem found by static checking.
5868 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5869 initialized, to pacify gcc -Wuninitialized.
5870
e5e9d610
PE
5871 * fileio.c: Report proper errno when syscall falls.
5872 (Finsert_file_contents): Save and restore errno,
5873 so that report_file_error outputs the correct diagnostic.
5874 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5875
a1674f0b
EZ
58762011-09-18 Eli Zaretskii <eliz@gnu.org>
5877
5878 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5879
fbfb6dd4
EZ
58802011-09-17 Eli Zaretskii <eliz@gnu.org>
5881
5882 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5883 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5884
bb187662
EZ
58852011-09-17 Eli Zaretskii <eliz@gnu.org>
5886
1137e8b8 5887 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5888 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5889
5890 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5891 (bidi_find_paragraph_start): Search back for paragraph beginning
5892 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5893 (bidi_move_to_visually_next): Only trigger paragraph-related
5894 computations when the last character is a newline or at EOB, not
5895 just any NEUTRAL_B. (Bug#9470)
5896
bb187662
EZ
5897 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5898 truncated lines if point is covered by a display string. (Bug#9524)
5899
2e621251
PE
59002011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5901
5902 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5903 (cons_to_x_long): New function.
5904 (lisp_data_to_selection_data): Use it. Correct the test for
5905 short-versus-long data; it was negated. Break out of vector
5906 loop, for efficiency, when a long datum is discovered.
5907
91a15bc6
SM
59082011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5909
5910 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5911
b41c3a35
EZ
59122011-09-16 Eli Zaretskii <eliz@gnu.org>
5913
5914 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5915 GCC PR/17406) by declaring this function with external scope.
5916
7812ba2d
PE
59172011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5918
5919 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5920 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5921
cf7edc2a
AS
59222011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5923
5924 * editfns.c (Fformat): Correctly handle text properties on "%%".
5925
bd01620e
EZ
59262011-09-15 Eli Zaretskii <eliz@gnu.org>
5927
5928 * xterm.c (x_draw_composite_glyph_string_foreground):
5929 * w32term.c (x_draw_composite_glyph_string_foreground):
5930 * term.c (encode_terminal_code):
5931 * composite.c (composition_update_it, get_composition_id):
5932 * xdisp.c (get_next_display_element)
5933 (fill_composite_glyph_string): Add comments about special meaning
5934 of TAB characters in a composition.
5935
a02719a3
PE
59362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5937
5938 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5939 This occurs when processing a multibyte format.
5940 Problem reported by Wolfgang Jenker.
a02719a3 5941
72589a3c
JB
59422011-09-15 Johan Bockgård <bojohan@gnu.org>
5943
5944 * xdisp.c (try_cursor_movement): Only check for exact match if
5945 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5946
1c14176c
PE
59472011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5948
5949 Remove unused external symbols.
5950 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5951 * xdisp.c (calc_pixel_width_or_height): Now static.
5952 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5953 * indent.c (check_display_width):
5954 * w32term.c: Fix comment to match code.
5955 * xterm.c, xterm.h (x_catching_errors): Remove.
5956
d2eea5b5
PE
59572011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5958
5959 * xselect.c: Use signed conversions more consistently (Bug#9498).
5960 (selection_data_to_lisp_data): Assume incoming selection data are
5961 signed integers, not unsigned. This is to be consistent with
5962 outgoing selection data, which was modified to use signed integers
5963 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5964 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5965 expects long, not unsigned long.
5966
46888499
EZ
59672011-09-14 Eli Zaretskii <eliz@gnu.org>
5968
5969 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5970 computation of loop end. Reported by Johan Bockgård
5971 <bojohan@gnu.org>.
5972
ef8ef9fb
CY
59732011-09-13 Chong Yidong <cyd@stupidchicken.com>
5974
5975 * frame.c (Fother_visible_frames_p): Function deleted.
5976
fa819fed
EZ
59772011-09-12 Eli Zaretskii <eliz@gnu.org>
5978
5979 * indent.c (compute_motion): Process display vector front to back
5980 rather than the other way around. (Bug#2496)
5981
2ba8e008
SM
59822011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5983
5984 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5985
20f53c69
CY
59862011-09-11 Chong Yidong <cyd@stupidchicken.com>
5987
5988 * minibuf.c (Fread_from_minibuffer): Doc fix.
5989
d562d7a4
EZ
59902011-09-11 Eli Zaretskii <eliz@gnu.org>
5991
5992 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5993 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5994
1c4d7f3d
LMI
59952011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5996
5997 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5998 value for non-existent files.
5999
b885bf36
EZ
60002011-09-11 Eli Zaretskii <eliz@gnu.org>
6001
6002 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6003 set its "size" to -1. This will set the modtime_size field of
6004 the corresponding buffer to -1, which is what
6005 verify-visited-file-modtime expects for files that do not exist.
6006 (Bug#9139)
6007
6612f0bf
PE
60082011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6009
6010 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6011 here ...
6012 * lisp.h: ... from here. push_key_description is no longer
6013 defined in keyboard.c, so its declaration should not be in
6014 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6015 logically belongs with push_key_description.
6016
dfb3f755
PE
60172011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6018
6019 * buffer.h: Include <sys/types.h> instead of <time.h>.
6020 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6021 Problem reported by Herbert J. Skuhra.
6022
3134906c
LMI
60232011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6024
6025 * xml.c (parse_region): Make the parsing work for
6026 non-comment-starting XML files again (bug#9144).
6027
8d903f4e
AS
60282011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6029
6030 * image.c (gif_load): Fix calculation of bottom and right corner.
6031 (Bug#9468)
6032
80ad64f4
EZ
60332011-09-10 Eli Zaretskii <eliz@gnu.org>
6034
6035 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6036 redisplay in small windows.
6037
208a048d
EZ
60382011-09-09 Eli Zaretskii <eliz@gnu.org>
6039
6040 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6041
9b1c252e
MR
60422011-09-08 Martin Rudalics <rudalics@gmx.at>
6043
6044 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6045 Operate on live windows only.
6046
2949f33b
JB
60472011-09-08 Juanma Barranquero <lekktu@gmail.com>
6048
6049 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6050
e08dcafd
EZ
60512011-09-07 Eli Zaretskii <eliz@gnu.org>
6052
6053 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6054 only under bidi iteration.
6055
115b96bd
JD
60562011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6057
6058 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6059
c8199d0f
PE
60602011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6061
6062 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6063 Without this fix, the command to link temacs failed due to an
6064 undefined symbol __builtin_isnan. This is because
6065 /usr/include/iso/math_c99.h #defines isnan(x) to
6066 __builtin_isnan(x), but the bundled gcc, which identifies itself
6067 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6068 a __builtin_isnan.
6069 * floatfns.c (isnan): #undef, and then #define to a clone of
6070 what's in data.c.
6071 (Fisnan): Always define, since it's always available now.
6072 (syms_of_floatfns): Always define isnan at the Lisp level.
6073
e39b275c 60742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6075
6076 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6077
b2db44d9 60782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6079
f4af5137 6080 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6081 The previous code assumed that file offsets (off_t values) fit in
6082 EMACS_INT variables, which is not true on typical 32-bit hosts.
6083 The code messed up by falsely reporting buffer overflow in cases
6084 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6085 when "big" contains more than 2**29 bytes, even though this
6086 inserts just one byte and does not overflow the buffer.
6087 (Finsert_file_contents): Store file offsets as off_t
6088 values, not as EMACS_INT values. Check for overflow when
6089 converting between EMACS_INT and off_t. When checking for
6090 buffer overflow or for overlap, take the offsets into account.
6091 Don't use EMACS_INT for small values where int suffices.
6092 When checking for overlap, fix a typo: ZV was used where
6093 ZV_BYTE was intended.
6094 (Fwrite_region): Don't assume off_t fits into 'long'.
6095 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6096
ecfc0a49
MA
60972011-09-05 Michael Albinus <michael.albinus@gmx.de>
6098
6099 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6100
6511acf2 61012011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6102
0999621a 6103 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6104
6105 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6106 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6107 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6108 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6109 (modify_event_symbol): Do not assume that the length of
6110 name_alist_or_stem is safe to alloca and fits in int.
6111 (Fexecute_extended_command): Likewise for function name and binding.
6112 (Frecursion_depth): Wrap around reliably on integer overflow.
6113 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6114 since some callers pass EMACS_INT values.
6115 (Fsingle_key_description): Don't crash if symbol name contains more
6116 than MAX_ALLOCA bytes.
6117 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6118 (get_minibuffer): Arg is now EMACS_INT, not int.
6119 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6120 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6121 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6122
2be7d702
PE
6123 * dbusbind.c (signature_cat): New function.
6124 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6125 Do not overrun buffer; instead, report string overflow.
6126
9d1df220
PE
6127 * dispnew.c (add_window_display_history): Don't overrun buffer.
6128 Truncate instead; this is OK since it's just a log.
6129
33ef5c64
PE
6130 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6131 even if the time zone offset is outlandishly large.
6132 Don't mishandle offset == INT_MIN.
6133
66c6fdd5
PE
6134 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6135 when creating daemon; the previous buffer-overflow check was incorrect.
6136
d749b01b
PE
6137 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6138 which has the guts of the old verror function.
6139
b5cd1905
PE
6140 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6141 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6142
6e1a67fb
PE
6143 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6144 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6145 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6146 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6147 length of string rather than counting it via multiple sprintfs;
6148 that's simpler and more reliable.
c21721cc
PE
6149 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6150 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6151 sprintf, in case result does not fit in int.
6152
c57b67fc
PE
6153 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6154 (fontset_from_font): Print it.
6155
8a401434
PE
6156 * frame.c (tty_frame_count): Now printmax_t, not int.
6157 (make_terminal_frame, set_term_frame_name): Print it.
6158 (x_report_frame_params): In X, window IDs are unsigned long,
6159 not signed long, so print them as unsigned.
6160 (validate_x_resource_name): Check for implausibly long names,
6161 and don't assume name length fits in 'int'.
6162 (x_get_resource_string): Don't blindly alloca invocation name;
6163 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6164 not fit in int.
6165
6e1a67fb
PE
6166 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6167 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6168 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6169
0df02bf3
PE
6170 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6171 Use esprintf, not sprintf, in case result does not fit in int.
6172
48e30793
PE
6173 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6174 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6175 it as a large positive number.
6176 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6177 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6178
a66ff6d8
PE
6179 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6180 in case result does not fit in int.
6181
aca216ff
PE
6182 * print.c (float_to_string): Detect width overflow more reliably.
6183 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6184 buffer overrun. Don't assume list length fits in 'int'. Treat
6185 print length of 0 as 0, not as infinity; to be consistent with other
6186 uses of print length in this function. Don't overflow print length
6187 index. Don't assume hash table size fits in 'long', or that
6188 vectorlike size fits in 'unsigned long'.
6189
31c286f7
PE
6190 * process.c (make_process): Use printmax_t, not int, to format
6191 process-name gensyms.
6192
55e5faa1
PE
6193 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6194
80f2e268
PE
6195 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6196 to avoid potential buffer overrun.
6197
670741ab
PE
6198 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6199 if X resource line is longer than 512 bytes.
6200
b7163a50
PE
6201 * xfns.c (x_window): Make sprintf buffer a bit bigger
6202 to avoid potential buffer overrun.
6203
ae58ff1f
PE
6204 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6205
c43c8a6a
PE
6206 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6207
3f8236f4
PE
62082011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6209
53e9fe90 6210 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6211 Without these, Emacs silently mishandles large integers sometimes.
6212 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6213 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6214
6511acf2
PE
6215 * xdisp.c (try_window_id): Check Emacs fixnum range before
6216 converting to 'int'.
806add1d 6217
6511acf2 6218 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6219 Check that an Emacs fixnum is in range before assigning it to 'int'.
6220 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6221 values converted from Emacs fixnums.
6222 (Frecenter): Don't wrap around a line count if it is out of 'int'
6223 range; instead, treat it as an extreme value.
6224 (Fset_window_configuration, compare_window_configurations):
6225 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6226
6511acf2
PE
6227 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6228 that can exceed INT_MAX. Check that EMACS_INT value is in range
6229 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6230 (match_limit): Don't assume that a fixnum can fit in 'int'.
6231
6511acf2 6232 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6233 exceed INT_MAX.
6234
6511acf2 6235 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6236 (Fvertical_motion): Don't wrap around LINES values that don't fit
6237 in 'int'. Instead, treat them as extreme values. This is good
6238 enough for windows, which can't have more than INT_MAX lines anyway.
6239
fcb901a7
LMI
62402011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6241
0f2f6b6d
LMI
6242 * Require libxml/parser.h to avoid compilation warning.
6243
fcb901a7
LMI
6244 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6245
6246 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6247 since this reportedly can destroy thread storage.
6248
6e20a0d4
CY
62492011-08-30 Chong Yidong <cyd@stupidchicken.com>
6250
6251 * syntax.c (find_defun_start): Update all cache variables if
6252 exiting early (Bug#9401).
6253
148ae00e
EZ
62542011-08-30 Eli Zaretskii <eliz@gnu.org>
6255
f6cfbd8f
EZ
6256 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6257
148ae00e
EZ
6258 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6259 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6260 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6261
6262 * term.c (tty_append_glyph): New function.
6263 (produce_stretch_glyph): Static function and its prototype deleted.
6264
a66cfb1c
SM
6265 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6266 Add prototypes.
148ae00e 6267
c4a07a4c
PE
62682011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6269
6270 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6271 when checking :margin (Bug#9390).
6272 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6273 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6274 so that the name doesn't mislead. All uses changed.
6275
6bc8cd65
JB
62762011-08-28 Johan Bockgård <bojohan@gnu.org>
6277
6278 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6279 set_tty_hooks.
6280
dca4927e
EZ
62812011-08-27 Eli Zaretskii <eliz@gnu.org>
6282
6283 * xdisp.c (move_it_to): Don't bail out early when reaching
6284 position beyond to_charpos, if we are scanning backwards.
6285 (move_it_vertically_backward): When DY == 0, make sure we get to
6286 the first character in the line after the newline.
6287
f2cad773
PE
62882011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6289
6290 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6291 (ccl_driver): Do not generate an out-of-range pointer.
6292 (Fccl_execute_on_string): Remove unnecessary check for
6293 integer overflow, noted by Stefan Monnier in
6294 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6295 Remove a FIXME that didn't need fixing.
6296 Simplify the newly-introduced buffer reallocation code.
6297
0cae2cdb
JB
62982011-08-27 Juanma Barranquero <lekktu@gmail.com>
6299
6300 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6301
5fc295a4 63022011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6303
70c60eb2 6304 Integer and memory overflow issues (Bug#9196).
726e0ab1 6305
d31850da
PE
6306 * doc.c (get_doc_string): Rework so that
6307 get_doc_string_buffer_size is the actual buffer size, rather than
6308 being 1 less than the actual buffer size; this makes xpalloc more
6309 convenient.
6310
a69fbedb
PE
6311 * image.c (x_allocate_bitmap_record, cache_image):
6312 * xselect.c (Fx_register_dnd_atom):
6313 Simplify previous changes by using xpalloc.
6314
fe5c5d37
PE
6315 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6316 since either will do and ptrdiff_t is convenient with xpalloc.
6317
0065d054
PE
6318 * charset.c (charset_table_size)
6319 (struct charset_sort_data.priority): Now ptrdiff_t.
6320 (charset_compare): Don't overflow if priorities differ greatly.
6321 (Fsort_charsets): Don't assume list length fits in int.
6322 Check for size-calculation overflow when allocating sort data.
6323 (syms_of_charset): Allocate an initial charset table that is
6324 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6325
6326 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6327
6328 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6329 The actual value is always <= INT_MAX, and leaving it unsigned made
6330 overflow checking harder.
6331
6332 * dispextern.h (struct glyph_matrix.rows_allocated)
6333 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6334 with xpalloc. The values are still always <= INT_MAX.
6335
6336 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6337
6338 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6339 (SAFE_NALLOCA): New macro.
6340
6341 * region-cache.c (struct boundary.pos, find_cache_boundary)
6342 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6343 (set_cache_region, invalidate_region_cache)
6344 (revalidate_region_cache, know_region_cache, region_cache_forward)
6345 (region_cache_backward, pp_cache):
6346 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6347 so that ptrdiff_t * can be passed to xpalloc.
6348 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6349 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6350 (pp_cache): Don't assume cache_len fits in int.
6351 * region-cache.h: Adjust extern decls to match.
6352
6353 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6354 EMACS_INT, since either will do, for xpalloc.
6355
6356 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6357 (xnmalloc, xnrealloc, xpalloc): New functions.
6358
726e0ab1
PE
6359 * bidi.c (bidi_shelve_header_size): New constant.
6360 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6361 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6362
51f30bc5 6363 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6364 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6365 (overlay_strings):
6366 Don't update size of array until after memory allocation succeeds,
6367 because xmalloc/xrealloc may not return.
0065d054
PE
6368 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6369 now that we have proper integer overflow checking.
6370 (record_overlay_string, overlay_strings): Catch overflows when
6371 calculating size of overlay_str_buf.
726e0ab1 6372
0065d054
PE
6373 * callproc.c (Fcall_process): Check for size overflow when
6374 calculating size of args2.
6375 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6376 Normally we prefer signed values, but sticking with ptrdiff_t would
6377 require adding more-complicated checks.
726e0ab1
PE
6378
6379 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6380 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6381 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6382 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6383
6384 * character.c (Fstring): Check for size-calculation overflow.
6385
6386 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6387 unnecessary integer overflow. Check for size overflow.
6388 (encode_coding_object): Don't update size until xmalloc succeeds.
6389
6390 * composite.c (get_composition_id): Check for overflow in glyph
6391 length calculations.
6392
6393 Integer and memory overflow fixes for display code.
6394 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6395 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6396 (scrolling_window): Check for overflow in size calculations.
6397 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6398 Don't assume glyph table len fits in int.
6399 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6400 (row_table_size): Now ptrdiff_t, not int.
6401 (scrolling_window): Avoid overflow in size calculations.
6402 Don't update size until allocation succeeds.
6403 * fns.c (concat): Check for overflow in size calculations.
6404 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6405 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6406 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6407
6408 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6409 (get_doc_string): Check for size calculation overflow.
6410 Don't update size until allocation succeeds.
6411 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6412 EMACS_INT, where ptrdiff_t will do.
6413 (Fsubstitute_command_keys): Check for string overflow.
6414
6415 * editfns.c (set_time_zone_rule): Don't assume environment length
6416 fits in int.
6417 (message_length): Now ptrdiff_t, not int.
6418 (Fmessage_box): Don't update size until allocation succeeds.
6419 Don't assume message length fits in int.
6420 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6421
0065d054
PE
6422 * emacs.c (main): Do not reallocate argv, since there is a null at
6423 the end that can be overwritten, and this way there's no need to
6424 worry about size-calculation overflow.
6425 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6426
6427 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6428 alloc succeeds.
6429 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6430
6431 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6432 (x_set_scroll_bar_width, x_figure_window_size):
6433 Check for integer overflow.
6434 (x_set_alpha): Do not assume XINT fits in int.
6435
6436 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6437 This is for the members text_lines, text_cols, total_lines, total_cols,
6438 where the system imposes an 'int' limit.
6439
6440 * fringe.c (Fdefine_fringe_bitmap):
6441 Don't update size until alloc works.
6442
6443 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6444 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6445
6446 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6447 Check for size-calculation overflow.
6448 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6449 do, as we prefer signed integers.
6450 (id_to_widget.max_size, id_to_widget.used)
6451 (xg_store_widget_in_map, xg_remove_widget_from_map)
6452 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6453 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6454 Use and return ptrdiff_t, not int.
6455 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6456 * gtkutil.h: Change prototypes to match the above.
6457
6458 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6459 are duplicate now that they've been promoted to lisp.h.
6460 (x_allocate_bitmap_record, x_alloc_image_color)
6461 (make_image_cache, cache_image, xpm_load):
6462 Don't update size until alloc is done.
6463 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6464 (x_detect_edges):
3256efce 6465 Check for size calculation overflow.
726e0ab1
PE
6466 (ct_colors_allocated_max): New constant.
6467 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6468 overflow.
3256efce 6469
726e0ab1
PE
6470 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6471 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6472 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6473 Use ptrdiff_t, not int, to count maps.
6474 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6475 calculations. Don't update size until allocation succeeds.
6476 Redo calculations to avoid overflow.
726e0ab1
PE
6477 * keyboard.h: Change prototypes to match the above.
6478
6479 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6480 to count maps.
6481 (current_minor_maps): Check for size calculation overflow.
6482 * keymap.h: Change prototypes to match the above.
6483
6484 * lread.c (read1, init_obarray): Don't update size until alloc done.
6485
6486 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6487 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6488
726e0ab1
PE
6489 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6490 Now ptrdiff_t, not int.
6491 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6492 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6493
6494 * process.c (Fnetwork_interface_list): Check for overflow
6495 in size calculation.
6496
6497 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6498
6499 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6500 overflow. Don't bother calling xmalloc when xrealloc will do.
6501
6502 * search.c (Freplace_match): Check for size calculation overflow.
6503 (Fset_match_data): Don't assume list lengths fit in 'int'.
6504
6505 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6506 for command line length. Do not attempt to address one before the
6507 beginning of an array, as that's not portable.
6508
6509 * term.c (max_frame_lines): Remove; unused.
6510 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6511 not int.
6512 (encode_terminal_code, calculate_costs): Check for size
6513 calculation overflow.
6514 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6515 table lengths and related sizes. Don't update size until alloc
6516 done. Redo calculations to avoid overflow.
6517 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6518
6519 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6520 subtracting pointers.
6521 (gobble_line): Check for overflow more carefully. Don't update size
6522 until alloc done.
6523
6524 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6525 Don't update size until alloc done.
6526 Redo size calculations to avoid overflow.
6527 Check for size calculation overflow.
0065d054 6528 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6529
6530 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6531 Use ptrdiff_t, not int, for sizes.
6532 (store_mode_line_noprop_char): Don't update size until alloc done.
6533
0065d054
PE
6534 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6535 Use ptrdiff_t, not int, for sizes.
6536 (Finternal_make_lisp_face, cache_face):
6537 Check for size calculation overflow.
6538 (cache_face): Treat size calculation overflows as if they were
6539 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6540
6541 * xfns.c (x_encode_text, x_set_name_internal)
6542 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6543 sizes, since they can exceed INT_MAX in size. Check for size
6544 calculation overflow.
6545
0065d054
PE
6546 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6547 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6548 Don't update size until alloc done.
6549
0065d054 6550 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6551 as sprintf is limited to int lengths.
1d526e2f 6552
252c5ee1
PE
6553 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6554 (X_LONG_MIN): New macros.
864d7ce7
PE
6555 Use them to make the following changes clearer.
6556 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6557 This change doesn't affect the value now, but it may help remind
6558 future maintainers not to raise the value too much later.
6559 (SELECTION_QUANTUM): Remove, replacing with ...
6560 (selection_quantum): ... new function, which avoids overflow.
6561 All uses changed.
6562 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6563 assumption that selection length fits in 'int'.
6564 (x_reply_selection_request, x_handle_selection_request)
6565 (x_get_window_property, receive_incremental_selection)
6566 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6567 (lisp_data_to_selection_data, clean_local_selection_data):
6568 Use ptrdiff_t, not int, to record length of selection.
6569 (x_reply_selection_request, x_get_window_property)
6570 (receive_incremental_selection, x_property_data_to_lisp):
6571 Redo calculations to avoid overflow.
6572 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6573 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6574 something.
6575 (x_get_window_property, receive_incremental_selection)
6576 (lisp_data_to_selection_data, x_property_data_to_lisp):
6577 Check for size-calculation overflow.
6578 (x_get_window_property, receive_incremental_selection)
6579 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6580 Don't store size until memory allocation succeeds.
6581 (x_get_window_property): Plug memory leak on memory exhaustion.
6582 Don't double-block input; malloc is safe here. Don't assume 2**34
6583 - 4 fits in unsigned long. Add an xassert to check
6584 XGetWindowProperty overflow. Be more careful about overflow
6585 calculations, and distinguish size from memory overflow better.
6586 (receive_incremental_selection): When tracing, don't assume
6587 unsigned int is less than INT_MAX.
6588 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6589 harmful) conversions of unsigned short to int.
6590 (lisp_data_to_selection_data): Don't assume that integers
6591 in the range -65535 through -1 fit in an X unsigned short.
6592 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6593 result parameters unless successful. Rely on cons_to_unsigned
6594 to report problems with elements; the old code wasn't right anyway.
6595 (x_check_property_data): Check for int overflow; we cannot use
6596 a wider type due to X limits.
6597 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6598
726e0ab1 6599 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6600
0065d054
PE
6601 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6602 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6603 (x_color_cells): Don't store size until memory allocation succeeds.
6604 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6605 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6606 (x_term_init): Don't assume length fits in int (sprintf is limited
6607 to int size).
bc18e09d 6608
ebfa62c0
PE
6609 Use ptrdiff_t for composition IDs.
6610 * character.c (lisp_string_width):
6611 * composite.c (composition_table_size, n_compositions)
6612 (get_composition_id, composition_gstring_from_id):
6613 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6614 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6615 * window.c (Frecenter):
6616 Use ptrdiff_t, not int, for composition IDs.
6617 * composite.c (get_composition_id): Check for integer overflow.
6618 * composite.h: Adjust prototypes to match the above changes.
6619
d3411f89
PE
6620 Use ptrdiff_t for hash table indexes.
6621 * category.c (hash_get_category_set):
6622 * ccl.c (ccl_driver):
6623 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6624 * coding.c (coding_system_charset_list, detect_coding_system):
6625 * coding.h (struct coding_system.id):
6626 * composite.c (get_composition_id, gstring_lookup_cache):
6627 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6628 * image.c (xpm_get_color_table_h):
6629 * lisp.h (hash_lookup, hash_put):
6630 * minibuf.c (Ftest_completion):
6631 Use ptrdiff_t for hash table indexes, not int (which is too
6632 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6633 32-bit --with-wide-int hosts).
6634
e097a6fa
PE
6635 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6636 Add a FIXME comment about memory leaks.
6637 (syms_of_charset): Don't assume xmalloc returns.
6638
5637687f
PE
6639 Don't assume that stated character widths fit in int.
6640 * character.c (Fchar_width, c_string_width, lisp_string_width):
6641 * character.h (CHAR_WIDTH):
6642 * indent.c (MULTIBYTE_BYTES_WIDTH):
6643 Use sanitize_char_width to avoid undefined and/or bad behavior
6644 with outlandish widths.
a66cfb1c 6645 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6646 now that we have two such functions. All uses changed.
6647 (sanitize_char_width): New inline function.
6648
a2271ba2
PE
6649 Don't assume that tab-width fits in int.
6650 * character.h (sanitize_width): New inline function.
6651 (SANE_TAB_WIDTH): New macro.
6652 (ASCII_CHAR_WIDTH): Use it.
6653 * indent.c (sane_tab_width): Remove. All uses replaced by
6654 SANE_TAB_WIDTH (current_buffer).
6655 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6656
18c52557
PE
6657 * fileio.c: Integer overflow issues with file modes.
6658 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6659
caeeedc1
PE
6660 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6661 Remove unreachable code.
6662 (read_hex, load_charset_map_from_file): Check for integer overflow.
6663
6df6ae42 6664 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6665 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6666 (x_send_scroll_bar_event): Likewise. Check that the size does not
6667 exceed limits imposed by XClientMessageEvent, as well as the usual
6668 ptrdiff_t and size_t limits.
6669
b13995db
PE
6670 * keyboard.c: Overflow, signedness and related fixes.
6671 (make_lispy_movement): Use same integer type in forward decl
6672 that is used in the definition.
6673 (read_key_sequence, keyremap_step):
6674 Change bufsize argument back to int, undoing my 2011-03-30 change.
6675 We prefer signed types, and int is wide enough here.
6676 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6677 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6678 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6679 length, not size_t. Use ptrdiff_t for index, not int.
6680 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6681 possibility of integer overflow.
6682
13464394
PE
6683 Overflow, signedness and related fixes for images.
6684
6685 * dispextern.h (struct it.stack[0].u.image.image_id)
6686 (struct_it.image_id, struct image.id, struct image_cache.size)
6687 (struct image_cache.used, struct image_cache.ref_count):
6688 * gtkutil.c (update_frame_tool_bar):
6689 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6690 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6691 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6692 * nsmenu.m (update_frame_tool_bar):
6693 * xdisp.c (calc_pixel_width_or_height):
6694 * xfns.c (image_cache_refcount):
6695 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6696 on typical 64-bit hosts.
6697
6698 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6699 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6700 Omit unnecessary casts to int.
6701 (parse_image_spec): Check that integers fall into 'int' range
6702 when the callers expect that.
6703 (image_ascent): Redo ascent calculation to avoid int overflow.
6704 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6705 (lookup_image): Remove unnecessary tests.
6706 (xbm_image_p): Locals are now of int, not EMACS_INT,
6707 since parse_image_check makes sure they fit into int.
6708 (png_load, gif_load, svg_load_image):
6709 Prefer int to unsigned where either will do.
6710 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6711 old tiff_error_handler and tiff_warning_handler.
6712 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6713 stack buffer overflows. It uses only the features of vsnprintf
6714 that are common to both POSIX and native Microsoft.
6715 (tiff_error_handler, tiff_warning_handler): Use it.
6716 (tiff_load, gif_load, imagemagick_load_image):
6717 Don't assume :index value fits in 'int'.
6718 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6719 (imagemagick_load_image): Check that crop parameters fit into
6720 the integer types that MagickCropImage accepts. Don't assume
6721 Vimagemagick_render_type has a nonnegative value. Don't assume
6722 size_t fits in 'long'.
6723 (gs_load): Use printmax_t to print the widest integers possible.
6724 Check for integer overflow when computing image height and width.
6725
c11821d4
EZ
67262011-08-26 Eli Zaretskii <eliz@gnu.org>
6727
6728 * xdisp.c (redisplay_window): Don't force window start if point
6729 will be invisible in the resulting window. (Bug#9324)
6730
0c95fcf7
EZ
67312011-08-25 Eli Zaretskii <eliz@gnu.org>
6732
6733 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6734 the display spec is of the form `(space ...)'.
6735 (handle_display_spec): Return the value returned by
6736 handle_single_display_spec, not just 1 or zero.
6737 (handle_single_display_spec): If the display spec is of the form
6738 `(space ...)', and specifies display in the text area, return 2
6739 rather than 1.
fee65a97 6740 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6741 accurately, and prefer exact match for point under bidi.
6742 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6743
6744 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6745 into disp_prop; all users changed.
6746
6747 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6748 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6749 for the text covered by the display property.
6750
e4ed06f1
CY
67512011-08-25 Chong Yidong <cyd@stupidchicken.com>
6752
6753 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6754 Change return value to nil.
6755 (Frecord_buffer): Delete unused function.
6756
f67cdd7f
EZ
67572011-08-24 Eli Zaretskii <eliz@gnu.org>
6758
5980d4c6
EZ
6759 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6760 buffers, return left-to-right.
8610fe8b
EZ
6761 (set_cursor_from_row): Consider candidate row a win if its glyph
6762 represents a newline and point is on that newline. Fixes cursor
6763 positioning on the newline at EOL of R2L text within L2R
6764 paragraph, and vice versa.
6765 (try_cursor_movement): Check continued rows, in addition to
6766 continuation rows. Fixes unwarranted scroll when point enters a
6767 continued line of R2L text within an L2R paragraph, or vice versa.
6768 (cursor_row_p): Consider the case of point being equal to
6769 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6770 from the end of a short line to the beginning of a continued line
6771 of R2L text within L2R paragraph.
6772 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6773 composed characters.
5980d4c6 6774
f67cdd7f
EZ
6775 * bidi.c (bidi_check_type): Use xassert.
6776 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6777 members.
6778
bca633fb
EZ
67792011-08-23 Eli Zaretskii <eliz@gnu.org>
6780
6781 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6782 a character.
6783
4a5885a7
CY
67842011-08-23 Chong Yidong <cyd@stupidchicken.com>
6785
6786 * nsfont.m (ns_otf_to_script): Fix typo.
6787
0902a04e
KH
67882011-08-22 Kenichi Handa <handa@m17n.org>
6789
6790 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6791 extra slot even if the purpose is char-code-property-table.
6792
1a2e6670
EZ
67932011-08-23 Eli Zaretskii <eliz@gnu.org>
6794
8ddde651
EZ
6795 * xdisp.c (redisplay_window): When computing centering_position,
6796 account for the height of the header line. (Bug#8874)
6797
425cc014
EZ
6798 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6799 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6800 candidate is selected by the mouse, and that candidate has a
6801 composed character under the mouse.
6802
1a2e6670
EZ
6803 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6804 coordinates reported by pos-visible-in-window-p for a composed
6805 character in column zero.
6806
8b76d6f8
SM
68072011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6808
6809 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6810
dac347dd
EZ
68112011-08-22 Eli Zaretskii <eliz@gnu.org>
6812
6813 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6814 consider it a hit if to_charpos is anywhere in the range of the
6815 composed buffer positions.
6816
e013fb34
CY
68172011-08-22 Chong Yidong <cyd@stupidchicken.com>
6818
6819 * image.c (gif_load): Don't assume that each subimage has the same
6820 dimensions as the base image. Handle disposal method that is
6821 "undefined" by the gif spec (Bug#9335).
6822
bd1ba3e8
CY
68232011-08-20 Chong Yidong <cyd@stupidchicken.com>
6824
6825 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6826 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6827
54a1215b
EZ
68282011-08-19 Eli Zaretskii <eliz@gnu.org>
6829
823564e5
EZ
6830 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6831 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6832 from an Org mode buffer to a Speedbar frame.
6833
54a1215b
EZ
6834 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6835 a composition, take its buffer position from IT->cmp_it.charpos.
6836 Fixes cursor positioning at the beginning of a line that begins
6837 with a composed character.
6838
9778ebcc
EZ
68392011-08-18 Eli Zaretskii <eliz@gnu.org>
6840
0be6ee06
EZ
6841 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6842 character bidirectional type, use STRONG_L instead. Fixes crashes
6843 in a buffer produced by `describe-categories'.
6844
9778ebcc
EZ
6845 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6846 members before the level stack, so they would be saved and
6847 restored when copying iterator state. Fixes incorrect reordering
6848 around TABs covered by display properties.
6849
156bffbe
AS
68502011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6851
6b02f655 6852 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6853
72ad093b
CY
68542011-08-17 Chong Yidong <cyd@stupidchicken.com>
6855
6856 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6857 (internal_condition_case_2, internal_condition_case_n):
6858 Remove unnecessary aborts (Bug#9081).
72ad093b 6859
35774242
EZ
68602011-08-17 Eli Zaretskii <eliz@gnu.org>
6861
6862 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6863 has no `load' handler, try opening the file locally. (Bug#9311)
6864
db76dd85
KB
68652011-08-16 Ken Brown <kbrown@cornell.edu>
6866
6867 * gmalloc.c: Expand comment.
6868
b215eee5
EZ
68692011-08-16 Eli Zaretskii <eliz@gnu.org>
6870
6871 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6872 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6873
a4579d33
KB
68742011-08-16 Ken Brown <kbrown@cornell.edu>
6875
6876 Fix memory allocation problems in Cygwin build (Bug#9273).
6877
6878 * unexcw.c ( __malloc_initialized): Declare external variable.
6879 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6880
8b76d6f8
SM
6881 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6882 New variables.
a4579d33
KB
6883 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6884 dumped emacs.
6885 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6886 in the static heap.
6887 [CYGWIN] (special_realloc): New function.
6888 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6889 requests to realloc storage in the static heap.
6890
3ebec551
PE
68912011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6892
6893 * bidi.c (bidi_initialize): Remove unused local.
6894
9fd8be00
EZ
68952011-08-15 Eli Zaretskii <eliz@gnu.org>
6896
6b02f655
SM
6897 * bidimirror.h:
6898 * biditype.h: Remove file.
6899 * makefile.w32-in ($(BLD)/bidi.$(O)):
6900 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6901
6902 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6903
6904 * chartab.c: Improve commentary for the uniprop_table API.
6905
32413314
EZ
6906 * bidi.c (bidi_paragraph_init): Support zero value of
6907 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6908 (bidi_initialize): Use uniprop_table instead of including
6909 biditype.h and bidimirror.h.
32413314 6910
9fd8be00
EZ
6911 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6912 coordinates of the iterator when restoring from ppos_it.
6913 (Bug#9296)
6914
5cf2b69b
KH
69152011-08-14 Kenichi Handa <handa@m17n.org>
6916
6917 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6918 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6919
daf17d00
EZ
69202011-08-14 Eli Zaretskii <eliz@gnu.org>
6921
6922 * xdisp.c (move_it_in_display_line_to): Don't invoke
6923 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6924 ppos_it. Fixes vertical cursor motion when line beginning is
6925 covered by an image. (Bug#9296)
6926
08e3161a
JD
69272011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6928
6929 * nsterm.h (ns_run_ascript): Declare.
6930 (NSAPP_DATA2_RUNASSCRIPT): Define.
6931
6932 * nsfns.m (as_script, as_result, as_status): New static variables.
6933 (ns_run_ascript): New function.
5e617bc2 6934 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6935 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6936 the event loop. Get status from as_status (Bug#7276).
6937
6938 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6939 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6940 the event loop (Bug#7276).
6941
a3720aa2
AS
69422011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6943
6944 * gnutls.c (QCgnutls_bootprop_priority)
6945 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6946 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6947 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6948 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6949 (QCgnutls_bootprop_verify_hostname_error)
6950 (QCgnutls_bootprop_callbacks_verify): Rename from
6951 Qgnutls_bootprop_..., all uses changed.
6952
6953 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6954 uses changed.
6955
0a0d27fb
PE
69562011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6957
19d5c50c
PE
6958 * xfaces.c (Qframe_set_background_mode): Now static.
6959 * dispextern.h (Qframe_set_background_mode): Remove decl.
6960
0a0d27fb
PE
6961 * process.c (Fnetwork_interface_info): Declare local only if needed.
6962
377538cb
JD
69632011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6964
6965 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6966 (Fnetwork_interface_list): Allocate in increments of bytes instead
6967 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6968 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6969 sockaddr.
6970 (struct ifflag_def): notrailers is smart on OSX.
6971 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6972 Get hardware address with getifaddrs if available.
6973
08fff70c
EZ
69742011-08-12 Eli Zaretskii <eliz@gnu.org>
6975
6976 * xdisp.c (iterate_out_of_display_property): xassert that
6977 IT->position is set to within IT->object's boundaries. Break from
6978 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6979 when IT->position is set up wrongly due to some bug.
6980 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6981 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6982 entry. Force push_it to save on the stack the current
6983 buffer/string position, to be restored by pop_it. Fix flags in
6984 the iterator structure wrt the object coming from a display
6985 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6986 properties. (Bug#9284)
6987
7be1c708 69882011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6989
7be1c708
CY
6990 * fontset.c (fontset_get_font_group): Add proper type checks.
6991 (Bug#9172)
aac0c6e3 6992
7be1c708 69932011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6994
7be1c708
CY
6995 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6996 and LC_VERSION_MIN_MACOSX.
6997 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6998 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6999
97bb72a6
EZ
70002011-08-08 Eli Zaretskii <eliz@gnu.org>
7001
7002 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7003 no-display-properties-and-no-overlays under bidi display.
7004 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7005 properties and overlays.
97bb72a6 7006
d5617611
CY
70072011-08-08 Chong Yidong <cyd@stupidchicken.com>
7008
37e11a63
CY
7009 * editfns.c (Fset_time_zone_rule): Document relationship with the
7010 setenv function.
7011
d5617611
CY
7012 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7013 the font entity extracted from the cache (Bug#8109).
7014
58872834
CY
70152011-08-07 Chong Yidong <cyd@stupidchicken.com>
7016
7017 * composite.c (autocmp_chars): Don't reset point. That is done by
7018 restore_point_unwind (Bug#5984).
7019
75bfc667
JL
70202011-08-07 Juri Linkov <juri@jurta.org>
7021
7022 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7023 to show the arg `TIME' instead of `TIMEVAL'.
7024
d1410150
EZ
70252011-08-06 Eli Zaretskii <eliz@gnu.org>
7026
7027 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7028 display property strides EOL and includes a newline, as in
7029 longlines-mode. (Bug#9254)
75b771e4
EZ
7030 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7031 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7032
7033 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7034 is non-zero, even if the data buffer is NULL. Fixes a crash in
7035 vertical-motion with longlines-mode. (Bug#9254)
7036
35928349
EZ
70372011-08-05 Eli Zaretskii <eliz@gnu.org>
7038
ec7cc85b
EZ
7039 * bidi.c <bidi_cache_total_alloc>: Now static.
7040 (bidi_initialize): Initialize bidi_cache_total_alloc.
7041
8b76d6f8 7042 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7043 cache. (Bug#9221)
7044
7045 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7046 amount allocated this far in `bidi_cache_total_alloc'.
7047 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7048 non-zero, only free the data buffer without restoring the cache
7049 contents. All callers changed.
7050
7051 * dispextern.h (bidi_unshelve_cache): Update prototype.
7052
7053 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7054 (move_it_in_display_line, move_it_to)
7055 (move_it_vertically_backward, move_it_by_lines): Replace the call
7056 to xfree to an equivalent call to bidi_unshelve_cache.
7057 (move_it_in_display_line_to): Fix logic of returning
412b6358 7058 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7059
e2e2423b
EZ
70602011-08-05 Eli Zaretskii <eliz@gnu.org>
7061
7062 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7063 came from a string character with a `cursor' property. (Bug#9229)
7064
ae9e757a
JD
70652011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7066
7067 * Makefile.in (LIB_PTHREAD): New variable.
7068 (LIBES): Add LIB_PTHREAD (Bug#9216).
7069
7070 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7071 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7072
213bd7f2
AS
70732011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7074
6b02f655 7075 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7076
99aaf75f
JD
70772011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7078
7079 * xterm.c (x_find_topmost_parent): New function.
7080 (x_set_frame_alpha): Find topmost parent window with
7081 x_find_topmost_parent and set the property there also (bug#9181).
7082 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7083
c74e9d86
PE
70842011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7085
7086 * callproc.c (Fcall_process): Avoid vfork clobbering
7087 the local vars buffer, coding_systems, current_dir.
7088
640c8776
SM
70892011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7090
7091 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7092
f26d0e4c
PE
70932011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7094
8a10d76c
PE
7095 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7096 so that it is not optimized away.
7097
f26d0e4c
PE
7098 * xdisp.c (compute_display_string_pos): Remove unused local.
7099
55439c61
EZ
71002011-08-02 Eli Zaretskii <eliz@gnu.org>
7101
7102 Fix slow cursor motion and scrolling in large buffers with
7103 selective display, like Org Mode buffers. (Bug#9218)
7104
7105 * dispextern.h (struct bidi_it): New member disp_prop_p.
7106
7107 * xdisp.c: Remove one-slot cache of display string positions.
7108 (compute_display_string_pos): Accept an additional argument
5e617bc2 7109 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7110 for a display string or property. If found, set DISP_PROP_P
7111 non-zero.
7112
7113 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7114 DISP_PROP_P, and pass it to compute_display_string_pos.
7115 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7116 non-zero. All callers of bidi_fetch_char changed.
7117
fb33fa43
SM
71182011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7119
7120 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7121
b099e063
DM
71222010-12-03 Don March <don@ohspite.net>
7123
7124 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7125 last character M-[char] is translated to ESC [char] (bug#7541).
7126
5cc7f7af
KH
71272011-08-02 Kenichi Handa <handa@m17n.org>
7128
d0fffa3f 7129 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7130
7131 * chartab.c (uniprop_table): Make it non-static.
7132
525d5e6e
EZ
71332011-08-01 Eli Zaretskii <eliz@gnu.org>
7134
7135 * xdisp.c (forward_to_next_line_start): Accept additional argument
7136 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7137 on the newline.
7138 (reseat_at_next_visible_line_start): Use the bidi iterator state
7139 returned by forward_to_next_line_start to restore the state of
7140 it->bidi_it after backing up to previous newline. (Bug#9212)
7141
31011111
AS
71422011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7143
7144 * regex.c (re_comp): Protoize.
7145 (re_exec): Fix return type.
7146 (regexec): Fix type of `ret'. (Bug#9203)
7147
476371c4
PE
71482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7149
e5d76069
PE
7150 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7151 This is needed if max-image-size is a floating-point number.
7152
9a79b20c
AS
71532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7154
7155 * print.c (print_object): Print empty symbol as ##.
7156
7157 * lread.c (read1): Read ## as empty symbol.
7158
d8c2fa78
AA
71592011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7160
7161 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7162 setting frame foreground color (Bug#9175).
7163 (x_set_background_color): Likewise.
7164
ffe57a7a
AA
7165 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7166 contents (Bug#9176).
7167 (EmacsTooltip -init): Remove bezels and add shadows to
7168 tooltip windows.
7169
bf3492a5
AA
7170 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7171 or scroll bar (Bug#8470).
7172
d55e9c53
AA
7173 * nsfont.m (nsfont_open): Remove assignment to voffset and
7174 unnecessary vars hshink, expand, hd, full_height, min_height.
7175 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7176
7177 * nsterm.h (nsfont_info): Remove voffset field.
7178
d8c2fa78 71792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7180
7181 Implement strike-through and overline on NextStep (Bug#8863).
7182
7183 * nsfont.m (nsfont_open): Use underline position provided by font,
7184 instead of hard-coded value of 2.
7185 (nsfont_draw): Call ns_draw_text_decoration instead.
7186
7187 * nsterm.h: Add declaration for ns_draw_text_decoration.
7188
7189 * nsterm.m (ns_draw_text_decoration): New function for drawing
7190 underline, overline, and strike-through.
7191 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7192 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7193 accommodate underlining, etc.
4843aac3 7194
4cc60b9b
EZ
71952011-07-28 Eli Zaretskii <eliz@gnu.org>
7196
bc7ece87
EZ
7197 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7198 default.
4cc60b9b 7199
476371c4
PE
72002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7201
66606eea
PE
7202 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7203 Without this fix, if a signal arrives just after memory fills up,
7204 'malloc' might be invoked reentrantly.
7205
476371c4
PE
7206 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7207 In other words, assume that every image size is allowed, on non-X
7208 hosts. This assumption is probably wrong, but it lets Emacs compile.
7209
f3fcc40d
AS
72102011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7211
7212 * regex.c (re_iswctype): Convert return values to boolean.
7213
350c992f
EZ
72142011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7215
7216 * xdisp.c (compute_display_string_pos): Don't use cached display
7217 string position if the buffer had its restriction changed.
7218 (Bug#9184)
7219
5266b4bb
PE
72202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7221
7222 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7223
2573a837 72242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7225
41f55ccd 7226 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7227
39e378da
PE
7228 * bidi.c: Integer size and overflow fixes.
7229 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7230 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7231 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7232 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7233 (bidi_find_other_level_edge):
7234 Use ptrdiff_t instead of EMACS_INT where either will do.
7235 This works better on 32-bit hosts configured --with-wide-int.
7236 (bidi_cache_ensure_space): Check for size-calculation overflow.
7237 Use % rather than repeated addition, for better worst-case speed.
7238 Don't set bidi_cache_size until after xrealloc returns, because it
7239 might not return.
7240 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7241 (bidi_cache_ensure_space): Also check that the bidi cache size
7242 does not exceed that of the largest Lisp string or buffer. See Eli
7243 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7244
5e927815
PE
7245 * alloc.c (__malloc_size_t): Remove.
7246 All uses replaced by size_t. See Andreas Schwab's note
7247 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7248
ca4aa935
PE
7249 * image.c: Improve checking for integer overflow.
7250 (check_image_size): Assume that f is nonnull, since
7251 it is always nonnull in practice. This is one less thing to
7252 worry about when checking for integer overflow later.
7253 (x_check_image_size): New function, which checks for integer
7254 overflow issues inside X.
7255 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7256 This removes the need for a memory_full check.
7257 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7258 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7259 (xbm_read_bitmap_data): Change locals back to 'int', since
7260 their values must fit in 'int'.
7261 (xpm_load_image, png_load, tiff_load):
7262 Invoke x_create_x_image_and_pixmap earlier,
7263 to avoid much needless work if the image is too large.
7264 (tiff_load): Treat overly large images as if
7265 x_create_x_image_and_pixmap failed, not as malloc failures.
7266 (gs_load): Use x_check_image_size.
7267
5f8f9cc2
PE
7268 * gtkutil.c: Omit integer casts.
7269 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7270 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7271
5adf60bc
PE
7272 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7273
c8907a93
PE
7274 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7275 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7276 would wrongly return t on a 64-bit host.
7277
e3c25c68
PE
7278 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7279 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7280 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7281 and therefore cause GCC to emit a bogus diagnostic in some cases.
7282
3f791afe
PE
7283 * image.c: Integer signedness and overflow and related fixes.
7284 This is not an exhaustive set of fixes, but it's time to
7285 record what I've got.
7286 (lookup_pixel_color, check_image_size): Remove redundant decls.
7287 (check_image_size): Don't assume that arbitrary EMACS_INT values
7288 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7289 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7290 (tiff_load, imagemagick_load_image):
7291 Check for overflow in size calculations.
7292 (x_create_x_image_and_pixmap): Remove unnecessary test for
7293 xmalloc returning NULL; that can't happen.
7294 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7295 (xpm_color_bucket): Use better integer hashing function.
7296 (xpm_cache_color): Don't possibly over-allocate memory.
7297 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7298 (gif_memory_source):
7299 Use ptrdiff_t, not int or size_t, to record sizes.
7300 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7301 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7302 either works, as we prefer signed integers.
7303 (tiff_read_from_memory, tiff_write_from_memory):
7304 Return tsize_t, not size_t, since that's what the TIFF API wants.
7305 (tiff_read_from_memory): Don't fail simply because the read would
7306 go past EOF; instead, return a short read.
7307 (tiff_load): Omit no-longer-needed casts.
7308 (Fimagemagick_types): Don't assume size fits into 'int'.
7309
3cc5a532
PE
7310 Improve hashing quality when configured --with-wide-int.
7311 * fns.c (hash_string): New function, taken from sxhash_string.
7312 Do not discard information about ASCII character case; this
7313 discarding is no longer needed.
7314 (sxhash-string): Use it. Change sig to match it. Caller changed.
7315 * lisp.h: Declare it.
7316 * lread.c (hash_string): Remove, since we now use fns.c's version.
7317 The fns.c version returns a wider integer if --with-wide-int is
7318 specified, so this should help the quality of the hashing a bit.
7319
b312a492
PE
7320 * emacs.c: Integer overflow minor fix.
7321 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7322 Define only if GNU_LINUX.
7323 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7324
dfd153ae
PE
7325 * dispnew.c: Integer signedness and overflow fixes.
7326 Remove unnecessary forward decls, that were a maintenance hassle.
7327 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7328 All uses changed.
7329 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7330 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7331 (prepare_desired_row, line_draw_cost):
7332 Use int, not unsigned, where either works.
7333 (save_current_matrix, restore_current_matrix):
7334 Use ptrdiff_t, not size_t, where either works.
7335 (init_display): Check for overflow more accurately, and without
7336 relying on undefined behavior.
7337
a81d11a3
PE
7338 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7339 Remove, replacing with the new symbols in lisp.h. All uses changed.
7340 * fileio.c (make_temp_name):
7341 * filelock.c (lock_file_1, lock_file):
7342 * xdisp.c (message_dolog):
7343 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7344 Use pMd etc. instead.
7345 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7346 replacing the pWIDE etc. symbols removed from editfns.c.
7347
3300e6fd
PE
7348 * keyboard.h (num_input_events): Now uintmax_t.
7349 This is (very slightly) less likely to mess up due to wraparound.
7350 All uses changed.
7351
fd05c7e9
PE
7352 * buffer.c: Integer signedness fixes.
7353 (alloc_buffer_text, enlarge_buffer_text):
7354 Use ptrdiff_t rather than size_t when either will do, as we prefer
7355 signed integers.
7356
903fe15d
PE
7357 * alloc.c: Integer signedness and overflow fixes.
7358 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7359 (__malloc_size_t): Default to size_t, not to int.
7360 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7361 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7362 Prefer ptrdiff_t to size_t when either would do, as we prefer
7363 signed integers.
7364 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7365 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7366 Now const. Initialize with values that are in range even if char
7367 is signed.
7368 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7369 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7370 These functions do the right thing with sizes > 2**32.
7371 (check_depth): Now ptrdiff_t, not int.
7372 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7373 Adjust to new way of storing sizes. Check for size overflow bugs
7374 in rest of code.
7375 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7376 slightly wrong anyway, as it missed one instance of
7377 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7378 (refill_memory_reserve): Omit needless cast to size_t.
7379 (mark_object_loop_halt): Mark as externally visible.
7380
ac82cc6a
PE
7381 * xselect.c: Integer signedness and overflow fixes.
7382 (Fx_register_dnd_atom, x_handle_dnd_message):
7383 Use ptrdiff_t, not size_t, since we prefer signed.
7384 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7385 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7386 x_dnd_atoms_size and x_dnd_atoms_length.
7387
c2d1e36d
PE
7388 * doprnt.c: Prefer signed to unsigned when either works.
7389 * eval.c (verror):
7390 * doprnt.c (doprnt):
7391 * lisp.h (doprnt):
7392 * xdisp.c (vmessage):
7393 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7394 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7395 prefer signed arithmetic to avoid comparison confusion.
7396 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7397 but is a bit tricky.
7398
0e926e56
PE
7399 Assume freestanding C89 headers, string.h, stdlib.h.
7400 * data.c, doprnt.c, floatfns.c, print.c:
7401 Include float.h unconditionally.
7402 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7403 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7404 * regex.c: Likewise for stddef.h, string.h.
7405 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7406 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7407 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7408 (STDC_HEADERS): Remove obsolete defines.
7409 * sysdep.c: Include limits.h unconditionally.
7410
9cfdb3ec
PE
7411 Assume support for memcmp, memcpy, memmove, memset.
7412 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7413 * regex.c (memcmp, memcpy):
7414 Remove; we assume C89 now.
7415
7416 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7417 (__malloc_safe_bcopy): Remove; no longer needed.
7418
cf950e6b 7419 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7420 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7421 well either way, and we prefer signed to unsigned.
7422
dbf38e02
LMI
74232011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7424
7425 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7426 closes the connection while we're reading (bug#9182).
7427
d6f0886c 74282011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7429
d6f0886c
JD
7430 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7431 are specified (Bug#9168).
24e0f6b1 7432
2eb1f9e6
PE
74332011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7434
7435 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7436 Found by GCC static checking and --with-wide-int on a 32-bit host.
7437
22381272 74382011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7439
7440 * xdisp.c (compute_display_string_pos): Fix logic of caching
7441 previous display string position. Initialize cached_prev_pos to
7442 -1. Fixes slow-down at the beginning of a buffer.
7443
f25e39b4
EZ
74442011-07-24 Eli Zaretskii <eliz@gnu.org>
7445
7446 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7447 for attrs[LFACE_FONTSET_INDEX].
7448
04c4b52e
PE
74492011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7450
7451 * xml.c (parse_region): Remove unused local
7452 that was recently introduced.
7453
c1734fbd
EZ
74542011-07-23 Eli Zaretskii <eliz@gnu.org>
7455
be18c5a5
EZ
7456 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7457 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7458
c1734fbd
EZ
7459 * xdisp.c (move_it_in_display_line_to): Record the best matching
7460 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7461 exit if none of the characters scanned was an exact match.
7462 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7463 when exact match is impossible due to invisible text, and the
7464 lines are truncated.
7465
a258d627
JD
74662011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7467
7468 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7469 for OSX >= 10.7.
7470
b6d5a689
EZ
74712011-07-22 Eli Zaretskii <eliz@gnu.org>
7472
0f74f785
EZ
7473 Fix a significant slow-down of cursor motion with C-n, C-p,
7474 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7475 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7476 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7477 (next_element_from_buffer): Call compute_stop_pos_backwards to
7478 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7479 base_level_stop.
7480 (reseat): Don't look for prev_stop, as that could mean a very long
7481 run.
7482 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7483 <cached_disp_overlay_modiff>: Cache for last found display string
7484 position.
551918c1 7485 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7486 about the same buffer in the same area of character positions, and
7487 the buffer wasn't changed since the time the display string
7488 position was cached.
551918c1 7489
b2d0c91a
EZ
74902011-07-22 Eli Zaretskii <eliz@gnu.org>
7491
7492 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7493 is an integer, which is important for empty lines. (Bug#9149)
7494
043604ee
CY
74952011-07-22 Chong Yidong <cyd@stupidchicken.com>
7496
7497 * frame.c (Fmodify_frame_parameters): In tty case, update the
7498 default face if necessary (Bug#4238).
7499
da4adb04
CY
75002011-07-21 Chong Yidong <cyd@stupidchicken.com>
7501
7502 * editfns.c (Fstring_to_char): No need to explain what a character
7503 is in the docstring (Bug#6576).
7504
9abd0532
LMI
75052011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7506
7507 * xml.c (parse_region): Make sure we always return a tree.
7508
36881d16
HK
75092011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7510
7511 * xml.c (parse_region): If a document contains only comments,
7512 return that, too.
7513
1e98674d
LMI
75142011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7515
7516 * xml.c (make_dom): Return comments, too.
7517
590bd467
PE
75182011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7519
7520 Port to OpenBSD.
7521 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7522 and the surrounding thread.
7523 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7524 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7525 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7526 timer goes off.
7527 * s/openbsd.h (BROKEN_SIGIO): Define.
7528 * unexelf.c (unexec) [__OpenBSD__]:
7529 Don't update the .mdebug section of the Alpha COFF symbol table.
7530
f41628b2
LMI
75312011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7532
7533 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7534 (bug#8460).
7535
b59b67c5
PE
75362011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7537
15e3a074
PE
7538 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7539 This fixes some race conditions on the permissions of any newly
7540 created file.
7541
41bed37d
PE
7542 * alloc.c (valid_pointer_p): Use pipe, not open.
7543 This fixes some permissions issues when debugging.
7544
b59b67c5
PE
7545 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7546 If fchown fails to set both uid and gid, try to set just gid,
7547 as that is sometimes allowed. Adjust the file's mode to eliminate
7548 setuid or setgid bits that are inappropriate if fchown fails.
7549
925a6be7
SM
75502011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7551
7552 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7553 to compare Lisp_Objects.
7554 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7555 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7556 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7557
52968808
AS
75582011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7559
0a6a104b
AS
7560 * lread.c (read_integer): Unread even EOF character.
7561 (read1): Likewise. Properly record start position of symbol.
7562
52968808
AS
7563 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7564 symbol character follows.
7565
9e381cdd
PE
75662011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7567
7568 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7569 This works around a problem with the previous change to Fcopy_file.
7570 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7571 and without this change, GCC might complain about discarding
7572 fchown's return value.
7573
b5641435
JB
75742011-07-16 Juanma Barranquero <lekktu@gmail.com>
7575
7576 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7577
a8031457
PE
75782011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7579
7580 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7581
dd889327
LMI
75822011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7583
750c33f7
LMI
7584 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7585 it's used from the C level.
7586
dd889327
LMI
7587 * process.c: Use the same condition for POLL_FOR_INPUT in both
7588 keyboard.c and process.c (bug#1858).
7589
87e86684
LM
75902011-07-09 Lawrence Mitchell <wence@gmx.li>
7591
7592 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7593 (Fgnutls_boot): Use it.
7594
64348f40
AS
75952011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7596
7597 * doc.c (Fsubstitute_command_keys): Revert last change.
7598
1d698799
LMI
75992011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7600
f863868c
LMI
7601 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7602 quotes the next character, and doesn't affect other longer
7603 sequences (bug#8935).
7604
1d698799
LMI
7605 * lread.c (syms_of_lread): Clarify that is isn't only
7606 `eval-buffer' and `eval-defun' that's affected by
7607 `lexical-binding' (bug#8460).
7608
aa4b6df6
EZ
76092011-07-15 Eli Zaretskii <eliz@gnu.org>
7610
7611 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7612 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7613
5d856da6
PE
76142011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7615
ad6042bb
PE
7616 Fix minor problems found by static checking.
7617 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7618 (elsz): Now a signed constant, not a size_t var. We prefer signed
7619 types to unsigned, to avoid integer comparison confusion. Without
7620 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7621 "cannot optimize loop, the loop counter may overflow", a symptom
7622 of the confusion.
f00bbb22 7623 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7624 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7625
6468f31c
LMI
76262011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7627
49080b10
LMI
7628 * search.c (Fre_search_backward): Mention `case-fold-search' in
7629 all the re_search_* functions (bug#8138).
7630
6468f31c
LMI
7631 * keyboard.c (Fopen_dribble_file): Document when the file is
7632 closed (bug#8056).
7633
c965adc5
EZ
76342011-07-14 Eli Zaretskii <eliz@gnu.org>
7635
df9733bf
EZ
7636 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7637 bidi_cache_idx.
7638
0bb23927
EZ
7639 Support bidi reordering of display and overlay strings.
7640 * xdisp.c (compute_display_string_pos)
7641 (compute_display_string_end): Accept additional argument STRING.
7642 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7643 (reseat_to_string): Initialize bidi_it->string.s and
7644 bidi_it->string.schars.
7645 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7646 NULL (avoids a crash in bidi_paragraph_init).
7647 Initialize itb.string.lstring.
0bb23927
EZ
7648 (init_iterator): Call bidi_init_it only of a valid
7649 buffer position was specified. Initialize paragraph_embedding to
7650 L2R.
7651 (reseat_to_string): Initialize the bidi iterator.
7652 (display_string): If we need to ignore text properties of
7653 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7654 original value of -1 will not work with bidi.)
7655 (compute_display_string_pos): First arg is now struct
7656 `text_pos *'; all callers changed. Support display properties on
7657 Lisp strings.
7658 (compute_display_string_end): Support display properties on Lisp
7659 strings.
7660 (init_iterator, reseat_1, reseat_to_string): Initialize the
7661 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7662 when iterating on a string not from display properties).
640c8776
SM
7663 (compute_display_string_pos, compute_display_string_end):
7664 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7665 arrow keys.
7666 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7667 base_level_stop; instead, set base_level_stop to BEGV.
7668 Fixes crashes in vertical-motion.
0bb23927
EZ
7669 (next_element_from_buffer): Improve commentary for when
7670 the iterator is before prev_stop.
7671 (init_iterator): Initialize bidi_p from the default value of
7672 bidi-display-reordering, not from buffer-local value. Use the
7673 buffer-local value only if initializing for buffer iteration.
7674 (handle_invisible_prop): Support invisible properties on strings
7675 that are being bidi-reordered.
7676 (set_iterator_to_next): Support bidi reordering of C strings and
7677 Lisp strings.
7678 (next_element_from_string): Support bidi reordering of Lisp
7679 strings.
7680 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7681 (display_string): Support display of R2L glyph rows.
7682 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7683 (init_iterator): Don't initialize it->bidi_p for strings
7684 here.
7685 (reseat_to_string): Initialize it->bidi_p for strings here.
7686 (next_element_from_string, next_element_from_c_string)
7687 (next_element_from_buffer): Add xassert's for correspondence
7688 between IT's object being iterated and it->bidi_it.string
7689 structure.
7690 (face_before_or_after_it_pos): Support bidi iteration.
7691 (next_element_from_c_string): Handle the case of the first string
7692 character that is not the first one in the visual order.
7693 (get_visually_first_element): New function, refactored from common
7694 parts of next_element_from_buffer, next_element_from_string, and
7695 next_element_from_c_string.
7696 (tool_bar_lines_needed, redisplay_tool_bar)
7697 (display_menu_bar): Force left-to-right direction. Add a FIXME
7698 comment for making that be controlled by a user option.
7699 (push_it, pop_it): Save and restore the state of the
7700 bidi iterator. Save and restore the bidi_p flag.
7701 (pop_it): Iterate out of display property for string iteration as
7702 well.
7703 (iterate_out_of_display_property): Support iteration over strings.
7704 (handle_single_display_spec): Set up it->bidi_it for iteration
7705 over a display string, and call bidi_init_it.
7706 (handle_single_display_spec, next_overlay_string)
7707 (get_overlay_strings_1, push_display_prop): Set up the bidi
7708 iterator for displaying display or overlay strings.
7709 (forward_to_next_line_start): Don't use the shortcut if
7710 bidi-iterating.
7711 (back_to_previous_visible_line_start): If handle_display_prop
7712 pushed the iterator stack, restore the internal state of the bidi
7713 iterator by calling bidi_pop_it same number of times.
7714 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7715 and we are bidi-iterating, don't decrement the iterator position;
7716 instead, set the first_elt flag in the bidi iterator, to produce
7717 the same effect.
7718 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7719 (push_display_prop): xassert that we are iterating a buffer.
7720 (push_it, pop_it): Save and restore paragraph_embedding member.
7721 (handle_single_display_spec, next_overlay_string)
7722 (get_overlay_strings_1, reseat_1, reseat_to_string)
7723 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7724 correctly. Don't assume unibyte strings are not bidi-reordered.
7725 (compute_display_string_pos)
7726 (compute_display_string_end): Fix handling the case of C string.
7727 (push_it, pop_it): Save and restore from_disp_prop_p.
7728 (handle_single_display_spec, push_display_prop): Set the
7729 from_disp_prop_p flag.
7730 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7731 (pop_it): Call iterate_out_of_display_property only if we are
7732 popping after iteration over a string that came from a display
7733 property. Fix a typo in popping stretch info. Add an assertion
7734 for verifying that the iterator position is in sync with the bidi
7735 iterator.
7736 (handle_single_display_spec, get_overlay_strings_1)
7737 (push_display_prop): Fix initialization of paragraph direction for
7738 string when that of the parent object is not yet determined.
7739 (reseat_1): Call bidi_init_it to resync the bidi
7740 iterator with IT's position. (Bug#7616)
7741 (find_row_edges): If ROW->start.pos gives position
7742 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7743 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7744 Reset the from_disp_prop_p flag.
7745 (SAVE_IT, RESTORE_IT): New macros.
7746 (pos_visible_p, face_before_or_after_it_pos)
7747 (back_to_previous_visible_line_start)
7748 (move_it_in_display_line_to, move_it_in_display_line)
7749 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7750 (try_scrolling, redisplay_window, display_line): Use them when
7751 saving a temporary copy of the iterator and restoring it back.
7752 (back_to_previous_visible_line_start, reseat_1)
7753 (init_iterator): Empty the bidi cache "stack".
7754 (move_it_in_display_line_to): If iterator ended up at
7755 EOL, but we never saw any buffer positions smaller than
7756 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7757 motion in bidi-reordered lines.
7758 (move_it_in_display_line_to): Record prev_method and prev_pos
7759 immediately before the call to set_iterator_to_next. Fixes cursor
7760 motion in bidi-reordered lines with stretch glyphs and strings
7761 displayed in margins. (Bug#8133) (Bug#8867)
7762 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7763 TO_CHARPOS.
640c8776
SM
7764 (pos_visible_p): Support positions in bidi-reordered lines.
7765 Save and restore bidi cache.
0bb23927
EZ
7766
7767 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7768 (bidi_paragraph_info): Delete unused struct.
7769 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7770 (bidi_cache_start): New variable.
7771 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7772 to zero.
7773 (bidi_cache_fetch_state, bidi_cache_search)
7774 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7775 (bidi_cache_find, bidi_peek_at_next_level)
7776 (bidi_level_of_next_char, bidi_find_other_level_edge)
7777 (bidi_move_to_visually_next): Compare cache index with
7778 bidi_cache_start rather than with zero.
7779 (bidi_fetch_char): Accept new argument STRING; all callers
7780 changed. Support iteration over a string. Support strings with
7781 display properties. Support unibyte strings. Fix the type of
7782 `len' according to what STRING_CHAR_AND_LENGTH expects.
7783 (bidi_paragraph_init, bidi_resolve_explicit_1)
7784 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7785 (bidi_level_of_next_char, bidi_move_to_visually_next):
7786 Support iteration over a string.
0bb23927
EZ
7787 (bidi_set_sor_type, bidi_resolve_explicit_1)
7788 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7789 can now be zero (for strings); special values 0 and -1 were
7790 changed to -1 and -2, respectively.
7791 (bidi_char_at_pos): New function.
7792 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7793 Call it instead of FETCH_MULTIBYTE_CHAR.
7794 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7795 initialized to valid values.
7796 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7797 values.
7798 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7799 the test for valid cached positions. Fix the logic for looking up
7800 the sentinel state in the cache. GCPRO the Lisp string we are
7801 iterating.
7802 (bidi_push_it, bidi_pop_it): New functions.
7803 (bidi_initialize): Initialize the bidi cache start stack pointer.
7804 (bidi_cache_ensure_space): New function, refactored from part of
7805 bidi_cache_iterator_state. Don't assume the required size is just
7806 one BIDI_CACHE_CHUNK away.
7807 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7808 (bidi_count_bytes, bidi_char_at_pos): New functions.
7809 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7810 always valid if bidi_cache_idx is valid.
7811 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7812 is valid if it's going to be used.
7813 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7814 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7815 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7816 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7817 (bidi_find_other_level_edge, bidi_cache_start_stack):
7818 All variables related to cache indices are now EMACS_INT.
c965adc5 7819
0bb23927
EZ
7820 * dispextern.h (struct bidi_string_data): New structure.
7821 (struct bidi_it): New member `string'. Make flag members be 1-bit
7822 fields, and put them last in the struct.
640c8776
SM
7823 (compute_display_string_pos, compute_display_string_end):
7824 Update prototypes.
0bb23927
EZ
7825 (bidi_push_it, bidi_pop_it): Add prototypes.
7826 (struct iterator_stack_entry): New members bidi_p,
7827 paragraph_embedding, and from_disp_prop_p.
7828 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7829 (bidi_shelve_cache, bidi_unshelve_cache):
7830 Declare prototypes.
0bb23927
EZ
7831
7832 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7833 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7834 and vector-like objects.
7835
7836 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7837 cache around display iteration.
7838
7839 * window.c (Fwindow_end, window_scroll_pixel_based)
7840 (displayed_window_lines, Frecenter): Save and restore the bidi
7841 cache around display iteration.
7842
3bbd2265
LMI
78432011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7844
7845 * editfns.c (Fdelete_region): Clarify the use of the named
7846 parameters (bug#6788).
7847
adc47434
MR
78482011-07-14 Martin Rudalics <rudalics@gmx.at>
7849
7850 * indent.c (Fvertical_motion): Set and restore w->pointm when
7851 saving and restoring the window's buffer (Bug#9006).
7852
837c31f8
LMI
78532011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7854
7855 * editfns.c (Fstring_to_char): Clarify just what is returned
7856 (bug#6576). Text by Eli Zaretskii.
7857
ac389d0c
JB
78582011-07-13 Juanma Barranquero <lekktu@gmail.com>
7859
7860 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7861
0be0ce47
EZ
78622011-07-13 Eli Zaretskii <eliz@gnu.org>
7863
7864 * buffer.c (mmap_find): Fix a typo.
7865
cd18e7e3
JB
78662011-07-13 Johan Bockgård <bojohan@gnu.org>
7867
7868 Fix execution of x selection hooks.
7869 * xselect.c (Qx_lost_selection_functions)
7870 (Qx_sent_selection_functions): New vars.
7871 (syms_of_xselect): DEFSYM them.
7872 (x_handle_selection_request): Pass Qx_sent_selection_functions
7873 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7874 (x_handle_selection_clear,x_clear_frame_selections):
7875 Pass Qx_lost_selection_functions rather than
7876 Vx_lost_selection_functions to Frun_hook_with_args.
7877
47ea7f44
PE
78782011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7879
ac389d0c 7880 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7881 The old code sometimes used this field without initializing it.
7882
47ea7f44
PE
7883 * alloc.c (gc_sweep): Don't read past end of array.
7884 In theory, the old code could also have corrupted Emacs internals,
7885 though it'd be very unlikely.
7886
bc985c87
AS
78872011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7888
7889 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7890 argument. (Bug#4026)
bc985c87 7891
0cf34688
LMI
78922011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7893
b3dadd76
LMI
7894 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7895 key" (bug#4257).
7896
0cf34688
LMI
7897 * window.c (Fset_window_start): Doc fix (bug#4199).
7898 (Fset_window_hscroll): Ditto.
7899
270768cd
PE
79002011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7901
077e3dda 7902 Fix minor new problems caught by GCC 4.6.1.
270768cd 7903 * term.c (init_tty): Remove unused local.
490011a6 7904 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7905 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7906 not used otherwise.
270768cd 7907
b1f58454
CY
79082011-07-12 Chong Yidong <cyd@stupidchicken.com>
7909
7910 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7911
22b9578d
LMI
79122011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7913
6e70ab07
LMI
7914 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7915 are the mini-buffer and the echo area (bug#3320).
7916
22b9578d
LMI
7917 * term.c (init_tty): Remove support for supdup, c10 and perq
7918 terminals, which are no longer supported (bug#1482).
7919
8974cc9f
JB
79202011-07-10 Johan Bockgård <bojohan@gnu.org>
7921
7922 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7923
a560d974
JD
79242011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7925
7926 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7927 for non-popups (Bug#3642).
7928
1dae0f0a
AS
79292011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7930
268c2c36 7931 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7932 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7933 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7934 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7935 * data.c (fmod): Likewise.
7936 * dispnew.c (swap_glyphs_in_rows): Likewise.
7937 * emacs.c (memory_warning_signal): Likewise.
7938 * floatfns.c (float_error): Likewise.
7939 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7940 (otf_open, font_otf_capability, generate_otf_features)
7941 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7942 Likewise.
7943 * image.c (pbm_read_file): Likewise.
7944 * indent.c (string_display_width): Likewise.
7945 * intervals.c (check_for_interval, search_for_interval)
7946 (inc_interval_count, count_intervals, root_interval)
7947 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7948 * lread.c (defalias): Likewise.
268c2c36 7949 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7950 * regex.c (set_image_of_range_1, set_image_of_range)
7951 (regex_grow_registers): Likewise.
7952 * sysdep.c (strerror): Likewise.
7953 * termcap.c (valid_filename_p, tprint, main): Likewise.
7954 * tparam.c (main): Likewise.
7955 * unexhp9k800.c (run_time_remap, save_data_space)
7956 (update_file_ptrs, read_header, write_header, calculate_checksum)
7957 (copy_file, copy_rest, display_header): Likewise.
7958 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7959 Likewise.
7960 * xdisp.c (check_it): Likewise.
7961 * xfaces.c (register_color, unregister_color, unregister_colors):
7962 Likewise.
7963 * xfns.c (print_fontset_result): Likewise.
7964 * xrdb.c (member, fatal, main): Likewise.
7965
99033785
PE
79662011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7967
7968 Fix minor problems found by static checking (Bug#9031).
7969 * chartab.c (char_table_set_range, map_sub_char_table):
7970 Remove unused locals.
7971 (uniprop_table): Now static.
7972 * composite.c (_work_char): Remove unused static var.
7973
9cb2ac56
JB
79742011-07-09 Juanma Barranquero <lekktu@gmail.com>
7975
7976 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7977
f25661f0
JD
79782011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7979
7980 * gtkutil.c (qttip_cb): Remove code without function.
7981
8278c4fe
EZ
79822011-07-09 Eli Zaretskii <eliz@gnu.org>
7983
7984 * w32.c (pthread_sigmask): New stub.
7985
1692ae2d 79862011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7987
8a6ebd58 7988 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7989 sigprocmask is portable only for single-threaded applications, and
7990 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7991 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7992 (LIBES): Use it.
7993 * callproc.c (Fcall_process):
7994 * process.c (create_process):
7995 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7996 Use pthread_sigmask, not sigprocmask.
123403e4 7997
1b854618
JD
79982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7999
8000 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8001 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8002 wrong (Bug#8591).
8003
3fe4b549
JD
80042011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8005
0ce7e563
JD
8006 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8007 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8008 (xg_hide_tooltip): Fix comment.
8009
3fe4b549
JD
8010 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8011 in registerServicesMenuSendTypes.
8012 (validRequestorForSendType): Don't check ns_return_types.
8013
8014 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8015 ns_return_type.
8016
5df75e47
JR
80172011-07-08 Jason Rumney <jasonr@gnu.org>
8018
22610910
JR
8019 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8020 SH_SHOW for hidden windows (Bug#5482).
8021
5df75e47
JR
8022 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8023 frame struct members of non-existent frames (Bug#6284).
8024
699c10bd
JD
80252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8026
4393663b
JD
8027 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8028 variable firstTime not needed on OSX >= 10.6.
8029 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8030 >= 10.5. Use setKnobProportion, setDoubleValue.
8031
8032 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8033 (MAC_OS_X_VERSION_10_5): Define if not defined.
8034 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8035 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8036 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8037
8038 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8039 cString and lossyCString on OSX >= 10.4.
4393663b 8040
58179cce 8041 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8042 sizeToFit on OSX >= 10.2.
8043
8044 * nsimage.m (allocInitFromFile): Don't use deprecated method
8045 bestRepresentationForDevice on OSX >= 10.6.
8046
8047 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8048 to avoid warning.
8049
8050 * emacs.c: Declare unexec_init_emacs_zone.
8051
a63e0781
JD
8052 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8053
699c10bd
JD
8054 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8055
8056 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8057 on svcsMenu (Bug#8842).
8058
8059 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8060 ns_return_types.
8061 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8062
8063 * nsterm.m (QUTF8_STRING): Declare.
8064 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8065 (validRequestorForSendType): Return type is (id).
8066 Change indexOfObjectIdenticalTo to indexOfObject.
8067 Check if we have local selection before returning self (Bug#8842).
8068 (writeSelectionToPasteboard): Put local selection into paste board
8069 if we have a local selection (Bug#8842).
8070 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8071
8072 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8073 (ns_get_local_selection): Declare.
8074
54e10184
LMI
80752011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8076
9888ff71
LMI
8077 * keymap.c (describe_map_tree): Don't insert a double newline at
8078 the end of the buffer (bug#1169) and return whether we inserted
8079 something.
8080
54e10184
LMI
8081 * callint.c (Fcall_interactively): Change "reading args" to
8082 "providing args" to try to clarify what it does (bug#1010).
8083
15fa4783
KH
80842011-07-07 Kenichi Handa <handa@m17n.org>
8085
8086 * composite.c (composition_compute_stop_pos): Ignore a static
8087 composition starting before CHARPOS (Bug#8915).
8088
8089 * xdisp.c (handle_composition_prop): Likewise.
8090
a8815b00
EZ
80912011-07-07 Eli Zaretskii <eliz@gnu.org>
8092
8093 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8094 (Bug#9015)
8095
ef7b981d 80962011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8097
8098 * character.h (unicode_category_t): New enum type.
8099
8100 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8101 (Qchar_code_property_table): New variable.
8102 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8103 (UNIPROP_COMPRESSED_FORM_P): New macros.
8104 (char_table_ascii): Uncompress the compressed values.
8105 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8106 Uncompress the compressed values.
ac389d0c 8107 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8108 (char_table_ref_and_range): Uncompress the compressed values.
8109 (sub_char_table_set): New arg is_uniprop. Callers changed.
8110 Uncompress the compressed values.
8111 (sub_char_table_set_range): Args changed. Callers changed.
8112 (char_table_set_range): Adjuted for the above change.
8113 (map_sub_char_table): Delete args default_val and parent. Add arg
8114 top. Give decoded values to a Lisp function.
640c8776 8115 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8116 values to a Lisp function. Gcpro more variables.
8117 (uniprop_table_uncompress)
8118 (uniprop_decode_value_run_length): New functions.
8119 (uniprop_decoder, uniprop_decoder_count): New variables.
8120 (uniprop_get_decoder, uniprop_encode_value_character)
8121 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8122 New functions.
8123 (uniprop_encoder, uniprop_encoder_count): New variables.
8124 (uniprop_get_encoder, uniprop_table)
8125 (Funicode_property_table_internal, Fget_unicode_property_internal)
8126 (Fput_unicode_property_internal): New functions.
8127 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8128 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8129 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8130 char-code-property-alist.
8131
640c8776 8132 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8133 Vunicode_category_table.
8134
640c8776 8135 * font.c (font_range): Adjust for the change of
c805dec0
KH
8136 Vunicode_category_table.
8137
76b397fb
DN
81382011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8139
8140 * m/iris4d.h: Remove file, move contents ...
8141 * s/irix6-5.h: ... here.
8142
22b4128e
PE
81432011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8144
8145 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8146 * alloc.c (mark_buffer):
8147 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8148 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8149 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8150 This isn't true in general, and it's particularly not true
8151 if Emacs is configured with --with-wide-int.
8152 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8153 New macros, used in the buffer.c change.
8154
869795d6
JD
81552011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8156
8157 * xsettings.c: Use both GConf and GSettings if both are available.
8158 (store_config_changed_event): Add comment.
8159 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8160 (store_tool_bar_style_changed): New functions.
5e617bc2 8161 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8162 (struct xsettings): Move font inside HAVE_XFT.
8163 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8164 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8165 Move inside HAVE_XFT.
640c8776 8166 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8167 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8168 also.
8169 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8170 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8171 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8172 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8173 (parse_settings): Move check for font inside HAVE_XFT.
8174 (read_settings, apply_xft_settings): Add comment.
8175 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8176 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8177 call store_font_name_changed.
8178 (xft_settings_event): Add comment.
8179 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8180 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8181 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8182 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8183 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8184 (xsettings_get_system_font, xsettings_get_system_normal_font):
8185 Add comment.
869795d6 8186
d8ed26bd
PE
81872011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8188
8189 Random fixes. E.g., (random) never returned negative values.
8190 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8191 subseconds part to the entropy, as that's a bit more random.
8192 Prefer signed to unsigned, since the signedness doesn't matter and
8193 in general we prefer signed. When given a limit, use a
8194 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8195 latter isn't right if USE_2_TAGS_FOR_INTS.
8196 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8197 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8198
cabf1cac
SM
81992011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8200
8201 * textprop.c (text_property_stickiness):
8202 Obey Vtext_property_default_nonsticky.
8203 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8204 * w32fns.c (syms_of_w32fns):
8205 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8206
6e9b2be9
PE
82072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8208
8209 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8210 This is more efficient than Ffile_directory_p and avoids a minor race.
8211
90186c68
LMI
82122011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8213
7c301272
LMI
8214 * buffer.c (Foverlay_put): Say what the return value is
8215 (bug#7835).
8216
c4f2d8d4
LMI
8217 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8218 is a directory before asking whether to use the file name
8219 (bug#7564).
ad637907
LMI
8220 (barf_or_query_if_file_exists): Make the "File is a directory"
8221 error be more correct.
c4f2d8d4 8222
90186c68
LMI
8223 * fns.c (Frequire): Remove the mention of the .gz files, since
8224 that's installation-specific, but keep the mention of
8225 `get-load-suffixes'.
8226
da64016e
PE
82272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8228
8229 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8230 Report string overflow if the output is too long.
8231
7d47b580
JB
82322011-07-04 Juanma Barranquero <lekktu@gmail.com>
8233
a555cb87
JB
8234 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8235 (syms_of_gnutls): Remove duplicate DEFSYM for
8236 Qgnutls_bootprop_verify_hostname_error, an error for
8237 Qgnutls_bootprop_verify_error (which is no longer used).
8238
7d47b580
JB
8239 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8240 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8241 Also (re)move comments that are misplaced or no longer relevant.
8242
1e49bfab
LMI
82432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8244
8245 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8246
1485f4c0
CY
82472011-07-03 Chong Yidong <cyd@stupidchicken.com>
8248
8249 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8250 and background color parameters if they have been changed.
8251
a9ab721e
LMI
82522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8253
8254 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8255
cf7cff57
PE
82562011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8257
2e13213d
PE
8258 * xsettings.c (SYSTEM_FONT): Define only when used.
8259 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8260
cf7cff57
PE
8261 * keymap.c (access_keymap_1): Now static.
8262
7a8e04f7
CY
82632011-07-02 Chong Yidong <cyd@stupidchicken.com>
8264
8265 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8266 leave any prefix arg for the up event (Bug#1586).
8267
61352f62
LMI
82682011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8269
69bb1ef7
LMI
8270 * lread.c (syms_of_lread): Mention single symbols defined by
8271 `defvar' or `defconst' (bug#7154).
8272
61352f62 8273 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8274 (Frequire): Mention get-load-suffixes.
61352f62 8275
28545e04
MR
82762011-07-02 Martin Rudalics <rudalics@gmx.at>
8277
8278 * window.h (window): Remove clone_number slot.
8279 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8280 Remove.
8281 (make_parent_window, make_window, saved_window)
8282 (Fset_window_configuration, save_window_save): Don't deal with
8283 clone numbers.
8284 * buffer.c (Qclone_number): Remove declaration.
8285 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8286
3349e122
SM
82872011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8288
8289 Add multiple inheritance to keymaps.
8290 * keymap.c (Fmake_composed_keymap): New function.
8291 (Fset_keymap_parent): Simplify.
8292 (fix_submap_inheritance): Remove.
8293 (access_keymap_1): New function extracted from access_keymap to handle
8294 embedded parents and handle lists of maps.
8295 (access_keymap): Use it.
8296 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8297 (Fcopy_keymap): Handle embedded parents.
8298 (Fcommand_remapping, define_as_prefix): Simplify.
8299 (Fkey_binding): Simplify.
8300 (syms_of_keymap): Move minibuffer-local-completion-map,
8301 minibuffer-local-filename-completion-map,
8302 minibuffer-local-must-match-map, and
8303 minibuffer-local-filename-must-match-map to Elisp.
8304 (syms_of_keymap): Defsubr make-composed-keymap.
8305 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8306 (parse_menu_item): Trivial simplification.
8307
3279eb87
GM
83082011-07-01 Glenn Morris <rgm@gnu.org>
8309
8310 * Makefile.in (SETTINGS_LIBS): Fix typo.
8311
4550efdf
KI
83122011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8313
8314 * coding.c (Fencode_coding_string): Record the last coding system
8315 used, as the function doc string says (bug#8738).
8316
0949d2b6
JD
83172011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8318
8319 * xsettings.c (store_monospaced_changed): Take new font as arg and
8320 check for change against current_mono_font.
8321 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8322 (emacs_settings_constructor, emacs_settings_get_property)
8323 (emacs_settings_set_property, emacs_settings_class_init)
8324 (emacs_settings_init, gsettings_obj): Remove.
8325 (something_changedCB): New function for HAVE_GSETTINGS.
8326 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8327 with value as argument.
8328 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8329 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8330 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8331 "changed".
8332
8333 * xgselect.c: Add defined (HAVE_GSETTINGS).
8334 (xgselect_initialize): Ditto.
8335
8336 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8337 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8338 xg_select.
8339
bbc6b304
PE
83402011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8341
8342 * eval.c (struct backtrace): Simplify and port the data structure.
8343 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8344 signed bit field, as this assumption is not portable and it makes
8345 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8346 "char debug_on_exit : 1" as this is not portable either; instead,
8347 use the portable "unsigned int debug_on_exit : 1". Remove unused
8348 member evalargs. Remove obsolete comments about cc bombing out.
8349
9851bfc5
JD
83502011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8351
51bb811f 8352 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8353 Let HAVE_GSETTINGS override HAVE_GCONF.
8354 (store_monospaced_changed): New function.
8355 (EMACS_SETTINGS): A new type derived from GObject to handle
8356 GSettings notifications.
8357 (emacs_settings_constructor, emacs_settings_get_property)
8358 (emacs_settings_set_property, emacs_settings_class_init):
8359 New functions.
8360 (gsettings_client, gsettings_obj): New variables.
8361 (GSETTINGS_SCHEMA): New define.
8362 (something_changedCB): Call store_monospaced_changed.
8363 (init_gsettings): New function.
8364 (xsettings_initialize): Call init_gsettings.
8365 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8366 to NULL.
8367
640c8776 8368 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8369 GCONF_CFLAGS/LIBS.
8370
5386012d
MR
83712011-06-29 Martin Rudalics <rudalics@gmx.at>
8372
8373 * window.c (resize_root_window, grow_mini_window)
8374 (shrink_mini_window): Rename Qresize_root_window to
8375 Qwindow_resize_root_window and Qresize_root_window_vertically to
8376 Qwindow_resize_root_window_vertically.
8377
f13e0b08
PE
83782011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8379
8380 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8381
94515237
JB
83822011-06-27 Juanma Barranquero <lekktu@gmail.com>
8383
8384 * makefile.w32-in: Redesign dependencies so they reflect more
8385 clearly which files are directly included by each source file,
8386 and not through other includes.
8387
e43b6e43
MR
83882011-06-27 Martin Rudalics <rudalics@gmx.at>
8389
8390 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8391 (sort_overlays, overlay_strings): When an overlay's clone number
8392 matches the window's clone number process the overlay even if
8393 the overlay's window property doesn't match the current window.
8394
d68443dc
MR
8395 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8396 (Fwindow_hchild): Rename to Fwindow_left_child.
8397 (Fwindow_next): Rename to Fwindow_next_sibling.
8398 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8399 (resize_window_check): Rename to window_resize_check.
8400 (resize_window_apply): Rename to window_resize_apply.
8401 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8402 (Fdelete_other_windows_internal, resize_frame_windows)
8403 (Fsplit_window_internal, Fdelete_window_internal)
8404 (grow_mini_window, shrink_mini_window)
8405 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8406
c7e73be5
JD
84072011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8408
8409 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8410 (emacs_fixed_set_min_size): Remove.
8411 (emacs_fixed_new): Take frame as argument.
8412
8413 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8414 (_EmacsFixedPrivate): Remove minwidth/height.
8415 Add struct frame *f.
8416 (emacs_fixed_init): Initialize priv->f.
8417 (get_parent_class, emacs_fixed_set_min_size): Remove.
8418 (emacs_fixed_new): Set priv->f to argument.
8419 (emacs_fixed_get_preferred_width)
8420 (emacs_fixed_get_preferred_height): Use min_width/height from
8421 frames size_hint to set minimum and natural (Bug#8919).
8422 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8423 and use min_width/height from frames size_hint to set
8424 min_width/height (Bug#8919).
8425
8426 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8427 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8428 Fix indentation.
c7e73be5 8429
cf99dcf8
EZ
84302011-06-26 Eli Zaretskii <eliz@gnu.org>
8431
8432 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8433 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8434 called at ZV.
8435
029529ac
CY
84362011-06-26 Chong Yidong <cyd@stupidchicken.com>
8437
8438 * process.c (wait_reading_process_output): Bypass select if
8439 waiting for a cell while ignoring keyboard input, and input is
8440 pending. Suggested by Jan Djärv (Bug#8869).
8441
7a7ef429
PE
84422011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8443
8444 Use gnulib's dup2 module instead of rolling our own.
8445 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8446
11fdef7d 84472011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8448
8449 * dispnew.c (scrolling_window): Before scrolling, turn off a
8450 mouse-highlight in the window being scrolled.
8451
cd3520a4
JB
84522011-06-24 Juanma Barranquero <lekktu@gmail.com>
8453
8454 Move DEFSYM to lisp.h and use everywhere.
8455
8456 * character.h (DEFSYM): Move declaration...
8457 * lisp.h (DEFSYM): ...here.
8458
8459 * gnutls.c:
8460 * minibuf.c:
8461 * w32menu.c:
8462 * w32proc.c:
8463 * w32select.c: Don't include character.h.
8464
8465 * alloc.c (syms_of_alloc):
8466 * buffer.c (syms_of_buffer):
8467 * bytecode.c (syms_of_bytecode):
8468 * callint.c (syms_of_callint):
8469 * casefiddle.c (syms_of_casefiddle):
8470 * casetab.c (init_casetab_once):
8471 * category.c (init_category_once, syms_of_category):
8472 * ccl.c (syms_of_ccl):
8473 * cmds.c (syms_of_cmds):
8474 * composite.c (syms_of_composite):
8475 * dbusbind.c (syms_of_dbusbind):
8476 * dired.c (syms_of_dired):
8477 * dispnew.c (syms_of_display):
8478 * doc.c (syms_of_doc):
8479 * editfns.c (syms_of_editfns):
8480 * emacs.c (syms_of_emacs):
8481 * eval.c (syms_of_eval):
8482 * fileio.c (syms_of_fileio):
8483 * fns.c (syms_of_fns):
8484 * frame.c (syms_of_frame):
8485 * fringe.c (syms_of_fringe):
8486 * insdel.c (syms_of_insdel):
8487 * keymap.c (syms_of_keymap):
8488 * lread.c (init_obarray, syms_of_lread):
8489 * macros.c (syms_of_macros):
8490 * msdos.c (syms_of_msdos):
8491 * print.c (syms_of_print):
8492 * process.c (syms_of_process):
8493 * search.c (syms_of_search):
8494 * sound.c (syms_of_sound):
8495 * syntax.c (init_syntax_once, syms_of_syntax):
8496 * terminal.c (syms_of_terminal):
8497 * textprop.c (syms_of_textprop):
8498 * undo.c (syms_of_undo):
8499 * w32.c (globals_of_w32):
8500 * window.c (syms_of_window):
8501 * xdisp.c (syms_of_xdisp):
8502 * xfaces.c (syms_of_xfaces):
8503 * xfns.c (syms_of_xfns):
8504 * xmenu.c (syms_of_xmenu):
8505 * xsettings.c (syms_of_xsettings):
8506 * xterm.c (syms_of_xterm): Use DEFSYM.
8507
4228cf16
TZ
85082011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8509
cd3520a4 8510 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8511
7fcccf1e
PE
85122011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8513
7efb4e0e
PE
8514 Integer and buffer overflow fixes (Bug#8873).
8515
ff5844ad
PE
8516 * print.c (printchar, strout): Check for string overflow.
8517 (PRINTPREPARE, printchar, strout):
8518 Don't set size unless allocation succeeds.
8519
90532f02
PE
8520 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8521 for sizes. Check for string overflow more accurately.
8522 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8523
6d84508d
PE
8524 * macros.c: Integer and buffer overflow fixes.
8525 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8526 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8527 Use ptrdiff_t, not int, for sizes.
8528 Don't increment bufsize until after realloc succeeds.
8529 Check for size-calculation overflow.
8530 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8531
437b2cb4
PE
8532 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8533
8b9ac8b4
PE
8534 * lread.c: Integer overflow fixes.
8535 (read_integer): Radix is now EMACS_INT, not int,
8536 to improve quality of diagnostics for out-of-range radices.
8537 Calculate buffer size correctly for out-of-range radices.
8538 (read1): Check for integer overflow in radices, and in
8539 read-circle numbers.
82cb60d3
PE
8540 (read_escape): Avoid int overflow.
8541 (Fload, openp, read_buffer_size, read1)
8542 (substitute_object_recurse, read_vector, read_list, map_obarray):
8543 Use ptrdiff_t, not int, for sizes.
8544 (read1): Use EMACS_INT, not int, for sizes.
20270765 8545 Check for size overflow.
8b9ac8b4 8546
7fcccf1e
PE
8547 * image.c (cache_image): Check for size arithmetic overflow.
8548
bfbbd7e7
PE
8549 * lread.c: Integer overflow issues.
8550 (saved_doc_string_size, saved_doc_string_length)
8551 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8552 Now ptrdiff_t, not int.
8553 (read1): Don't assume doc string length fits in int. Check for
8554 out-of-range doc string lengths.
8555 (read_list): Don't assume file position fits in int.
39019e54 8556 (read_escape): Check for hex character overflow.
bfbbd7e7 8557
4e323265
LL
85582011-06-22 Leo Liu <sdl.web@gmail.com>
8559
8560 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8561 Move to minibuffer.el.
8562
85fece3e
PE
85632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8564
20b84ce9 8565 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8566 The following patches are for when GLYPH_DEBUG && !XASSERT.
8567 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8568 * dispnew.c (flush_stdout):
8569 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8570 Mark as externally visible.
8571 * dispnew.c (check_window_matrix_pointers): Now static.
8572 * dispnew.c (window_to_frame_vpos):
8573 * xfns.c (unwind_create_frame):
8574 * xterm.c (x_check_font): Remove unused local.
8575 * scroll.c (CHECK_BOUNDS):
8576 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8577 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8578 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8579 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8580 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8581 Now static.
8582 (debug_method_add): Use va_list and vsprintf rather than relying
8583 on undefined behavior with wrong number of arguments.
8584 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8585 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8586 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8587 since we're not interested in debugging glyphs with old libraries.
8588 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8589 GCC 4.6.0's static checking.
8590
0766b489
PE
85912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8592
31fd4b32
PE
8593 Integer overflow and signedness fixes (Bug#8873).
8594 A few related buffer overrun fixes, too.
8595
b79e8648
PE
8596 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8597
0766b489
PE
8598 * dispextern.h (struct face.stipple):
8599 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8600 (x_bitmap_mask, x_allocate_bitmap_record)
8601 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8602 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8603 (x_create_bitmap_from_xpm_data):
8604 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8605 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8606 (.bitmaps_last):
8607 * xfaces.c (load_pixmap):
8608 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8609 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8610 (.bitmaps_last, struct x_output.icon_bitmap):
8611 Use ptrdiff_t, not int, for bitmap indexes.
8612 (x_allocate_bitmap_record): Check for size overflow.
8613 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8614
b081724f
PE
8615 Use ptrdiff_t, not int, for overlay counts.
8616 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8617 * editfns.c (overlays_around, get_pos_property):
8618 * textprop.c (get_char_property_and_overlay):
8619 * xdisp.c (next_overlay_change, note_mouse_highlight):
8620 * xfaces.c (face_at_buffer_position):
21514da7
PE
8621 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8622 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8623 (Fnext_overlay_change, Fprevious_overlay_change)
8624 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8625 Use ptrdiff_t, not int, for sizes.
21514da7 8626 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8627
3de73e5e
PE
8628 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8629
2606c57b
PE
8630 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8631 (x_session_initialize): Do not assume string length fits in int.
8632
aaafe47a
PE
8633 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8634 This is unlikely, but can occur if DPI is outlandish.
8635
2674ddc8 8636 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8637 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8638
28154962
PE
8639 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8640 * xrdb.c (magic_file_p, search_magic_path):
8641 Omit last arg SUFFIX; it was always 0. All callers changed.
8642 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8643
7de51af5
PE
8644 * xfont.c (xfont_match): Avoid need for strlen.
8645
25ed6cc3
PE
8646 * xfns.c: Don't assume strlen fits in int.
8647 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8648
4eab31dd
PE
8649 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8650 not unsigned long, as we prefer signed integers. All callers changed.
8651 Detect integer overflow in repeat count.
8652 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8653 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8654
171e2a58
PE
8655 * termcap.c: Don't assume sizes fit in int and never overflow.
8656 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8657 (gobble_line): Check for size-calculation overflow.
8658
ad39faca 8659 * minibuf.c (Fread_buffer):
6e5bb2dc 8660 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8661 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8662 Don't assume string length fits in int.
8663
52c61c22 8664 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8665 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8666
b5b8c9e5
PE
8667 * font.c: Don't assume string length fits in int.
8668 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8669 Use ptrdiff_t, not int.
ccd6111c
PE
8670 (font_intern_prop): Don't assume string length fits in int.
8671 Don't assume integer property fits in fixnum.
8672 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8673
882f0d81 8674 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8675 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8676 Reformulate so as not to need the command string.
8677 Invoke gzip -cd rather than gunzip, as it's more portable.
8678 (lock_info_type, lock_file_1, lock_file):
8679 Don't assume pid_t and time_t fit in unsigned long.
8680 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8681 (current_lock_owner): Prefer signed type for sizes.
8682 Use memcpy, not strncpy, where memcpy is what is really wanted.
8683 Don't assume (via atoi) that time_t and pid_t fit in int.
8684 Check for time_t and/or pid_t out of range, e.g., via a network share.
8685 Don't alloca where an auto var works fine.
8686
93f4cf88
PE
8687 * fileio.c: Fix some integer overflow issues.
8688 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8689 Don't assume string length fits in int.
8690 (directory_file_name): Don't assume string length fits in long.
8691 (make_temp_name): Don't assume pid fits in int, or that its print
8692 length is less than 20.
8693
f3e92b69
PE
8694 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8695
1bfdaf10
PE
8696 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8697
35016e9a
PE
8698 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8699
3d1e65a1
PE
8700 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8701 We prefer signed integers, even for size calculations.
8702
0b963a93
PE
8703 * emacs.c: Don't assume string length fits in 'int'.
8704 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8705 (main): Don't invoke strlen when not needed.
8706
573f4b54
PE
8707 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8708 (XD_DEBUG_MESSAGE): Don't waste a byte.
8709
989f33ba
PE
8710 * callproc.c (getenv_internal_1, getenv_internal)
8711 (Fgetenv_internal):
965d34eb
PE
8712 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8713
e4d29b33
PE
8714 * lread.c (invalid_syntax): Omit length argument.
8715 All uses changed. This doesn't fix a bug, but it simplifies the
8716 code away from its former Hollerith-constant appearance, and it's
8717 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8718 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8719
eb49b136
PE
8720 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8721 This didn't break anything, but it didn't help either.
8722 It's confusing to put a bogus integer in a place where the actual
8723 value does not matter.
9f62aeb1 8724 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8725 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8726
15375a22
PE
8727 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8728 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8729 implementation.
b61cc01c
PE
8730 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8731 We prefer signed types, and the value cannot exceed the EMACS_INT
8732 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8733 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8734 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8735 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8736
53b2623d
PE
8737 * indent.c (sane_tab_width): New function.
8738 (current_column, scan_for_column, Findent_to, position_indentation)
8739 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8740 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8741
51cab52b 8742 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8743
f2ed8a70
PE
8744 * lisp.h (lint_assume): New macro.
8745 * composite.c (composition_gstring_put_cache):
8746 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8747
abe80cc6
PE
8748 * editfns.c, insdel.c:
8749 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8750
b02c740e
PE
8751 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8752
ebc96716
PE
8753 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8754
b4e50fa0 8755 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8756 Use much-faster test for byte-length change.
311d5d7c 8757 Don't assume string byte-length fits in 'int'.
a4cf38e4 8758 Check that character arg fits in 'int'.
85461888 8759 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8760
c0c1ee9f
PE
8761 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8762
a498d7f4
PE
8763 * fns.c (concat): Catch string overflow earlier.
8764 Do not rely on integer wraparound.
8765
51cab52b
PE
8766 * dispextern.h (struct it.overlay_strings_charpos)
8767 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8768 * xdisp.c (forward_to_next_line_start)
8769 (back_to_previous_visible_line_start)
8770 (reseat_at_next_visible_line_start, next_element_from_buffer):
8771 Don't arbitrarily truncate the value of 'selective' to int.
8772
76031fad
PE
8773 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8774
5eb55db9
PE
8775 * composite.c: Don't truncate sizes to 'int'.
8776 (composition_gstring_p, composition_reseat_it)
8777 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8778 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8779 not EMACS_UINT, for indexes.
5eb55db9 8780
0703a717
PE
8781 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8782
d6202519
PE
8783 * buffer.c: Include <verify.h>.
8784 (struct sortvec.priority, struct sortstr.priority):
8961a454 8785 Now EMACS_INT, not int.
c20998a7 8786 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8787 (struct sortstr.size, record_overlay_string)
8788 (struct sortstrlist.size, struct sortlist.used):
8789 Don't truncate size to int.
8790 (record_overlay_string): Check for size-calculation overflow.
d6202519 8791 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8792
d5a19415
JM
87932011-06-22 Jim Meyering <meyering@redhat.com>
8794
029529ac 8795 Don't leak an XBM-image-sized buffer
d5a19415
JM
8796 * image.c (xbm_load): Free the image buffer after using it.
8797
a9041e6c
PE
87982011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8799
8800 Port to Sun C.
8801 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8802 that Sun C diagnosed.
8803 * fns.c (secure_hash): Fix pointer signedness issue.
8804 * intervals.c (static_offset_intervals): New function.
8805 (offset_intervals): Use it.
8806
7f3f739f
LL
88072011-06-21 Leo Liu <sdl.web@gmail.com>
8808
8809 * deps.mk (fns.o):
8810 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8811 sha512.h.
8812
8813 * fns.c (secure_hash): Rename from crypto_hash_function and change
8814 the first arg to accept symbols.
5b66d427 8815 (Fsecure_hash): New primitive.
7f3f739f
LL
8816 (syms_of_fns): New symbols.
8817
76147d94
DD
88182011-06-20 Deniz Dogan <deniz@dogan.se>
8819
8820 * process.c (Fset_process_buffer): Clarify return value in
8821 docstring.
8822
7d7d0045
CY
88232011-06-18 Chong Yidong <cyd@stupidchicken.com>
8824
8825 * dispnew.c (add_window_display_history): Use BVAR.
8826
8827 * xdisp.c (debug_method_add): Use BVAR.
8828 (check_window_end, dump_glyph_matrix, dump_glyph)
8829 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8830
8831 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8832 Likewise.
8833
8834 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8835 check till after the cache is created in init_frame_faces.
8836
ff2bc410
SM
88372011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8838
8839 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8840
28177add
PE
88412011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8842
dd3482fe
PE
8843 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8844 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8845 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8846
393d71f3 8847 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8848 * fileio.c (Finsert_file_contents):
8849 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8850 Remove the old (too-loose) buffer overflow checks.
8851 They weren't needed, since make_gap checks for buffer overflow.
8852 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8853 The old code merely checked for Emacs fixnum overflow, and relied
8854 on undefined (wraparound) behavior. The new code avoids undefined
8855 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8856
2e6813b0 8857 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8858 Tune. Don't use wider integers than needed. Don't use alloca.
8859 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8860
599a9e4f
PE
8861 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8862
99561444
PE
8863 * insdel.c, lisp.h (buffer_overflow): New function.
8864 (insert_from_buffer_1, replace_range, replace_range_2):
8865 * insdel.c (make_gap_larger):
8866 * editfns.c (Finsert_char):
8867 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8868
28177add
PE
8869 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8870
e69dafad
PE
88712011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8872
4baa020d 8873 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8874
b1c46f02
PE
8875 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8876 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8877
e69dafad
PE
8878 * fileio.c: Don't assume EMACS_INT fits in off_t.
8879 (emacs_lseek): New static function.
8880 (Finsert_file_contents, Fwrite_region): Use it.
8881 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8882
566684ea
PE
8883 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8884
e6966cd6
PE
8885 * fns.c: Don't overflow int when computing a list length.
8886 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8887 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8888 truncation on 64-bit hosts. Check for QUIT every
8889 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8890 faster and is responsive enough.
8891 (Flength): Report an error instead of overflowing an integer.
8892 (Fsafe_length): Return a float if the value is not representable
8893 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8894 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8895 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8896
dd0b0efb
PE
8897 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8898 (header_size, word_size): New constants.
8899 (allocate_vectorlike): Don't check size overflow here.
8900 (allocate_vector): Check it here instead, since this is the only
8901 caller of allocate_vectorlike that could cause overflow.
8902 Check that the new vector's length is representable as a fixnum.
8903
86fe5cfe
PE
8904 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8905 The previous code was bogus. For example, next_almost_prime (32)
8906 returned 39, which is undesirable as it is a multiple of 3; and
8907 next_almost_prime (24) returned 25, which is a multiple of 5 so
8908 why was the code bothering to check for multiples of 7?
8909
80e88859
PE
8910 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8911
4a2f0ad6
PE
8912 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8913
f66c7cf8
PE
8914 Variadic C functions now count arguments with ptrdiff_t.
8915 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8916 Back then I didn't know that the Emacs coding style prefers signed int.
8917 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8918 were being counted with int, which may truncate counts on 64-bit
8919 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8920 * lisp.h (struct Lisp_Subr.function.aMANY)
8921 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8922 Arg counts are now ptrdiff_t, not size_t.
8923 All variadic functions and their callers changed accordingly.
8924 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8925 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8926 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8927 * callint.c (Fcall_interactively): Check arg count for overflow,
8928 to avoid potential buffer overrun. Use signed char, not 'int',
8929 for 'varies' array, so that we needn't bother to check its size
8930 calculation for overflow.
8931 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8932 * eval.c (apply_lambda):
8933 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8934 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8935 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8936
a1759b76
PE
8937 * callint.c (Fcall_interactively): Don't use index var as event count.
8938
d96be9fc
PE
8939 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8940 * mem-limits.h (SIZE): Remove; no longer used.
8941
a690a978 8942 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8943
578c21e6
PE
8944 Remove unnecessary casts.
8945 * xterm.c (x_term_init):
8946 * xfns.c (x_set_border_pixel):
8947 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8948 These aren't needed now that we assume ANSI C.
8949
96f53c6c
PE
8950 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8951 It's more likely to cause problems (due to unsigned overflow)
8952 than to cure them.
8953
83c77d31
PE
8954 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8955
ee2079f1
PE
8956 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8957
6da65536
PE
8958 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8959
7147c4a4
PE
8960 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8961
193e32d9
PE
8962 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8963
e5533da6
PE
8964 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8965
9910e595
PE
8966 GLYPH_CODE_FACE returns EMACS_INT, not int.
8967 * dispextern.h (merge_faces):
8968 * xfaces.c (merge_faces):
01103c44
PE
8969 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8970 Don't assume EMACS_INT fits in int.
9910e595 8971
2638320e
PE
8972 * character.h (CHAR_VALID_P): Remove unused parameter.
8973 * fontset.c, lisp.h, xdisp.c: All uses changed.
8974
045eb8d9
PE
8975 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8976
c1f134b5
PE
8977 * fns.c (concat): Minor tuning based on overflow analysis.
8978 This doesn't fix any bugs. Use int to hold character, instead
8979 of constantly refetching from Emacs object. Use XFASTINT, not
8980 XINT, for value known to be a character. Don't bother comparing
8981 a single byte to 0400, as it's always less.
8982
395fcb93 8983 * floatfns.c (Fexpt):
327eeec8
PE
8984 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8985
abbd3d23
PE
8986 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8987 for characters.
8988
684a03ef
PE
8989 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8990
0fed43f3
PE
8991 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8992 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8993 incorrectly succeed when S was a string, because 4294967386 was
8994 truncated before it was used.
8995
8fd02eb7
PE
8996 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8997 Otherwise, an out-of-range integer could cause undefined behavior
8998 on a 64-bit host.
8999
f8c86b69
PE
9000 * composite.c: Use int, not EMACS_INT, for characters.
9001 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9002 EMACS_INT, for values that are known to be in character range.
9003 This doesn't fix any bugs but is the usual style inside Emacs and
9004 may generate better code on 32-bit machines.
9005
34206dd2
PE
9006 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9007 This is for reasons similar to the recent CHAR_STRING fix.
9008 * charset.c (Fencode_char): Check that character arg is actually
9009 a character. Pass an int to ENCODE_CHAR.
9010 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9011 wider than 'int', as a compile-time check to prevent future regressions
9012 in this area.
9013
c5958d4c 9014 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9015
9016 Make sure a 64-bit char is never passed to CHAR_STRING.
9017 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9018 by silently ignoring the top 32 bits, allowing some values
9019 that were far too large to be valid characters.
9020 * character.h: Include <verify.h>.
9021 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9022 arguments are no wider than unsigned, as a compile-time check
9023 to prevent future regressions in this area.
9024 * data.c (Faset):
01103c44 9025 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9026 (Fsubst_char_in_region):
9027 * fns.c (concat):
9028 * xdisp.c (decode_mode_spec_coding):
9029 Adjust to CHAR_STRING's new requirement.
9030 * editfns.c (Finsert_char, Fsubst_char_in_region):
9031 * fns.c (concat): Check that character args are actually
9032 characters. Without this test, these functions did the wrong
9033 thing with wildly out-of-range values on 64-bit hosts.
9034
d37ca623
PE
9035 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9036 These casts should not be needed on 32-bit hosts, either.
9037 * keyboard.c (read_char):
9038 * lread.c (Fload): Remove casts to unsigned.
9039
ea204efb
PE
9040 * lisp.h (UNSIGNED_CMP): New macro.
9041 This fixes comparison bugs on 64-bit hosts.
9042 (ASCII_CHAR_P): Use it.
9043 * casefiddle.c (casify_object):
01103c44 9044 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9045 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9046 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9047 * dispextern.h (FACE_FROM_ID):
9048 * keyboard.c (read_char): Use UNSIGNED_CMP.
9049
41cb286c
PE
9050 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9051 not to EMACS_INT, to avoid GCC warning.
9052
4a1b9832
PE
9053 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9054
55daad71
PE
9055 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9056 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9057 isn't needed on 32-bit machines.
8f95c75c 9058
01103c44
PE
9059 * buffer.c (Fgenerate_new_buffer_name):
9060 Use EMACS_INT for count, not int.
0ceccced 9061 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9062
9063 * data.c (Qcompiled_function): Now static.
9064
c6f072e7
PE
9065 * window.c (window_body_lines): Now static.
9066
20ce5912
PE
9067 * image.c (gif_load): Rename local to avoid shadowing.
9068
9c4c5f81
PE
9069 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9070 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9071 * alloc.c (make_save_value): Integer argument is now of type
9072 ptrdiff_t, not int.
9073 (mark_object): Use ptrdiff_t, not int.
9074 * lisp.h (pD): New macro.
9075 * print.c (print_object): Use it.
9076
c0c5c8ae
PE
9077 * alloc.c: Use EMACS_INT, not int, to count objects.
9078 (total_conses, total_markers, total_symbols, total_vector_size)
9079 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9080 (total_free_floats, total_floats, total_free_intervals)
9081 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9082 Now EMACS_INT, not int. All uses changed.
9083 (Fgarbage_collect): Compute overall total using a double, so that
9084 integer overflow is less likely to be a problem. Check for overflow
9085 when converting back to an integer.
5a25e253
PE
9086 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9087 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9088 These were 'int' variables that could overflow on 64-bit hosts;
9089 they were never used, so remove them instead of repairing them.
211a0b2a 9090 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9091 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9092 Previously, this ceilinged at INT_MAX, but that doesn't work on
9093 64-bit machines.
e46bb31a 9094 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9095
c78baabf 9096 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9097 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9098 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9099 when a (possibly-narrower) signed value would do just as well.
9100 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9101
c9d624c6
PE
9102 * alloc.c: Catch some string size overflows that we were missing.
9103 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9104 for convenience in STRING_BYTES_MAX.
9105 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9106 The definition here is exact; the one in lisp.h was approximate.
9107 (allocate_string_data): Check for string overflow. This catches
9108 some instances we weren't catching before. Also, it catches
9109 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9110 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9111 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9112
c9d624c6
PE
9113 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9114 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9115 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9116
353032ce
PE
9117 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9118
2bccce07
PE
9119 * alloc.c (Fmake_string): Check for out-of-range init.
9120
0ac30604
SM
91212011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9122
9123 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9124
c195f2de
JD
91252011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9126
9127 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9128 xg_get_default_scrollbar_width.
9129
9130 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9131 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9132 (style_changed_cb): Call update_theme_scrollbar_width and call
9133 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9134 all frames (Bug#8505).
9135 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9136 Call gtk_window_set_resizable if HAVE_GTK3.
9137 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9138 and height if HAVE_GTK3 (Bug#8505).
9139 (scroll_bar_width_for_theme): New variable.
9140 (update_theme_scrollbar_width): New function.
9141 (xg_get_default_scrollbar_width): Move code to
9142 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9143 (xg_initialize): Call update_theme_scrollbar_width.
9144
9145 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9146
9147 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9148
e10ac9f1
MR
91492011-06-12 Martin Rudalics <rudalics@gmx.at>
9150
9151 * frame.c (make_frame): Call other_buffer_safely instead of
9152 other_buffer.
9153
9154 * window.c (temp_output_buffer_show): Call display_buffer with
9155 second argument Vtemp_buffer_show_specifiers and reset latter
9156 immediately after the call.
9157 (Vtemp_buffer_show_specifiers): New variable.
9158 (auto_window_vscroll_p, next_screen_context_lines)
9159 (Vscroll_preserve_screen_position): Remove leading asterisks from
9160 doc-strings.
9161
2d3c217e 91622011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9163
7b7f97e8 9164 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9165 * buffer.c (Qclone_number): Remove for now, as it's unused.
9166 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9167 (record_buffer): Remove unused local.
9168 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9169 (set_frame_buffer_list): Remove; unused.
9170 * frame.h (other_visible_frames): Remove decl.
9171 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9172 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9173 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9174 if HAVE_GPM.
9175 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9176 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9177 Define only if HAVE_GPM.
9178 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9179 (update_hints_inhibit): Remove; never set. All uses removed.
9180 * widgetprv.h (emacsFrameClassRec): Remove decl.
9181 * window.c (delete_deletable_window): Now returns void, since it
9182 wasn't returning anything.
9183 (compare_window_configurations): Remove unused locals.
9184 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9185 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9186 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9187 the same widths as pointers. This follows up on the 2011-05-06 patch.
9188 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9189 * xterm.h: Likewise.
9190 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9191
1384b89e
JB
91922011-06-12 Juanma Barranquero <lekktu@gmail.com>
9193
9194 * makefile.w32-in: Update dependencies.
9195 (LISP_H): Add lib/intprops.h.
9196
1100a63c
CY
91972011-06-11 Chong Yidong <cyd@stupidchicken.com>
9198
9199 * image.c (gif_load): Add animation frame delay to the metadata.
9200 (syms_of_image): Use DEFSYM. New symbol `delay'.
9201
6198ccd0
MR
92022011-06-11 Martin Rudalics <rudalics@gmx.at>
9203
9204 * window.c (delete_deletable_window): Re-add.
9205 (Fset_window_configuration): Rewrite to handle dead buffers and
9206 consequently deletable windows.
9207 (window_tree, Fwindow_tree): Remove. Supply functionality in
9208 window.el.
9209 (compare_window_configurations): Simplify code.
9210
b6e3633c
AS
92112011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9212
1ab0dee5
AS
9213 * image.c (imagemagick_load_image): Fix type mismatch.
9214 (Fimagemagick_types): Likewise.
9215
b6e3633c
AS
9216 * window.h (replace_buffer_in_windows): Declare.
9217
9397e56f
MR
92182011-06-11 Martin Rudalics <rudalics@gmx.at>
9219
9220 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9221 Qclone_number. Remove external declaration of Qdelete_window.
9222 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9223 code.
640c8776
SM
9224 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9225 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9226 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9227 buffer list implementation.
9228 (other_buffer_safely): New function.
9229 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9230 calls to replace_buffer_in_windows and
9231 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9232 if allowed.
9233 (record_buffer): Inhibit quitting and rewrite using quittable
9234 functions. Run Qbuffer_list_update_hook if allowed.
9235 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9236 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9237 Move switch-to-buffer to window.el.
9397e56f
MR
9238 (bury-buffer): Move to window.el.
9239 (Vbuffer_list_update_hook): New variable.
9240
9241 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9242 section.
9243
9244 * window.h (resize_frame_windows): Move up in code.
9245 (Fwindow_frame): Remove EXFUN.
9246 (replace_buffer_in_all_windows): Remove prototype.
9247 (replace_buffer_in_windows_safely): Add prototype.
9248
9249 * window.c: Declare Qdelete_window static again. Move down
9250 declaration of select_count.
9251 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9252 (Fother_window): Move to window.el.
9253 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9254 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9255 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9256 window.el.
9257 (replace_buffer_in_windows): Implement by calling
9258 Qreplace_buffer_in_windows.
9259 (replace_buffer_in_all_windows): Remove with some functionality
9260 moved into replace_buffer_in_windows_safely.
9261 (replace_buffer_in_windows_safely): New function.
9262 (select_window_norecord, select_frame_norecord): Move in front
9263 of run_window_configuration_change_hook. Remove now obsolete
9264 declarations.
640c8776
SM
9265 (Fset_window_buffer): Rewrite doc-string.
9266 Call Qrecord_window_buffer.
9397e56f
MR
9267 (keys_of_window): Move binding for other-window to window.el.
9268
b50691aa
CY
92692011-06-11 Chong Yidong <cyd@stupidchicken.com>
9270
9271 * dispextern.h (struct image): Replace data member, whose int_val
9272 and ptr_val fields were not used by anything, with a single
9273 lisp_val object.
9274
9275 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9276 (gif_clear_image, gif_load, imagemagick_load_image)
9277 (gs_clear_image, gs_load): Callers changed.
9278
3f754b86
PE
92792011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9280
cca69397
PE
9281 * buffer.h: Include <time.h>, for time_t.
9282 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9283
109e28d0
PE
9284 Fix minor problems found by static checking.
9285
60737f02
PE
9286 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9287
4b66faf3
PE
9288 Make identifiers static if they are not used in other modules.
9289 * data.c (Qcompiled_function, Qframe, Qvector):
9290 * image.c (QimageMagick, Qsvg):
9291 * minibuf.c (Qmetadata):
9292 * window.c (resize_window_check, resize_root_window): Now static.
9293 * window.h (resize_window_check, resize_root_window): Remove decls.
9294
109e28d0
PE
9295 * window.c (window_deletion_count, delete_deletable_window):
9296 Remove; unused.
46a4ce9e
PE
9297 (window_body_lines): Now static.
9298 (Fdelete_other_windows_internal): Mark vars as initialized.
9299 Make sure 'resize_failed' is initialized.
9300 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9301 (resize_window_apply): Remove unused local.
9302 * window.h (delete_deletable_window): Remove decl.
9303
109e28d0 9304 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9305 (imagemagick_load_image): Fix pointer signedness problem by changing
9306 last arg from unsigned char * to char *. All uses changed.
9307 Also, fix a local for similar reasons.
9308 Remove unused locals. Remove locals to avoid shadowing.
9309 (fn_rsvg_handle_free): Remove; unused.
9310 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9311 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9312
3f754b86
PE
9313 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9314
2547adb1
CY
93152011-06-10 Chong Yidong <cyd@stupidchicken.com>
9316
9317 * image.c (gif_load): Fix omitted cast error introduced by
9318 2011-06-06 change.
9319
2c8e37d4
MR
93202011-06-10 Martin Rudalics <rudalics@gmx.at>
9321
9322 * window.h (resize_proportionally, orig_total_lines)
9323 (orig_top_line): Remove from window structure.
9324 (set_window_height, set_window_width, change_window_heights)
9325 (Fdelete_window): Remove prototypes.
9326 (resize_frame_windows): Remove duplicate declaration.
9327
440a42e3
EZ
93282011-06-10 Eli Zaretskii <eliz@gnu.org>
9329
9330 * window.h (resize_frame_windows, resize_window_check)
9331 (delete_deletable_window, resize_root_window)
9332 (resize_frame_windows): Declare prototypes.
9333
9334 * window.c (resize_window_apply): Make definition be "static" to
9335 match the prototype.
9336
562dd5e9
MR
93372011-06-10 Martin Rudalics <rudalics@gmx.at>
9338
9339 * window.c: Remove declarations of Qwindow_size_fixed,
9340 window_min_size_1, window_min_size_2, window_min_size,
9341 size_window, window_fixed_size_p, enlarge_window, delete_window.
9342 Remove static from declaration of Qdelete_window, it's
9343 temporarily needed by Fbury_buffer.
9344 (replace_window): Don't assign orig_top_line and
9345 orig_total_lines.
9346 (Fdelete_window, delete_window): Remove. Window deletion is
9347 handled by window.el.
640c8776
SM
9348 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9349 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9350 (Fdelete_other_windows): Remove. Deleting other windows is
9351 handled by window.el.
9352 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9353 handled in window.el.
9354 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9355 Window minimum sizes are handled in window.el.
9356 (shrink_windows, size_window, set_window_height)
9357 (set_window_width, change_window_heights, window_height)
9358 (window_width, CURBEG, CURSIZE, enlarge_window)
9359 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9360 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9361 handled in window.el.
9362 (make_dummy_parent): Rename to make_parent_window and give it a
9363 second argument horflag.
9364 (make_window): Don't set resize_proportionally any more.
9365 (Fsplit_window): Remove. Windows are split in window.el.
9366 (save_restore_action, save_restore_orig_size)
9367 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9368 Resize mini windows in window.el.
9369 (grow_mini_window, shrink_mini_window): Implement by calling
9370 Qresize_root_window_vertically, resize_window_check and
9371 resize_window_apply.
640c8776
SM
9372 (saved_window, Fset_window_configuration, save_window_save):
9373 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9374 resize_proportionally.
9375 (window_min_height, window_min_width): Move to window.el.
9376 (keys_of_window): Move bindings for delete-other-windows,
9377 split-window, delete-window and enlarge-window to window.el.
9378
9379 * buffer.c: Temporarily extern Qdelete_window.
9380 (Fbury_buffer): Temporarily call Qdelete_window instead of
9381 Fdelete_window (Fbury_buffer will move to window.el soon).
9382
9383 * frame.c (set_menu_bar_lines_1): Remove code handling
9384 orig_top_line and orig_total_lines.
9385
9386 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9387 set_window_height but set heights directly.
9388 (change_frame_size_1): Use resize_frame_windows.
9389
9390 * xdisp.c (init_xdisp): Don't use set_window_height but set
9391 heights directly.
9392
640c8776
SM
9393 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9394 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9395 run_window_configuration_change_hook.
9396
9397 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9398 instead of change_window_heights and run
9399 run_window_configuration_change_hook.
9400
1a13852e
MR
94012011-06-09 Martin Rudalics <rudalics@gmx.at>
9402
9403 * window.c (replace_window): Rename second argument REPLACEMENT to
9404 NEW. New third argument SETFLAG. Rewrite.
9405 (delete_window, make_dummy_parent): Call replace_window with
9406 third argument 1.
9407 (window_list_1): Move down in code.
9408 (run_window_configuration_change_hook): Move set_buffer part
9409 before select_frame_norecord part in order to unwind correctly.
9410 Rename count1 to count.
9411 (recombine_windows, delete_deletable_window, resize_root_window)
9412 (Fdelete_other_windows_internal)
9413 (Frun_window_configuration_change_hook, make_parent_window)
9414 (resize_window_check, resize_window_apply, Fresize_window_apply)
9415 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9416 (Fdelete_window_internal, Fresize_mini_window_internal):
9417 New functions.
1a13852e
MR
9418 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9419
f3d1777e
MR
94202011-06-08 Martin Rudalics <rudalics@gmx.at>
9421
496e208e
MR
9422 * window.h (window): Add some new members to window structure -
9423 normal_lines, normal_cols, new_total, new_normal, clone_number,
9424 splits, nest, prev_buffers, next_buffers.
9425 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9426 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9427
f3d1777e
MR
9428 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9429 Remove.
496e208e
MR
9430 (make_dummy_parent): Set new members of windows structure.
9431 (make_window): Move down in code. Handle new members of window
9432 structure.
9433 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9434 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9435 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9436 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9437 (Fset_window_next_buffers, Fset_window_clone_number):
9438 New functions.
496e208e
MR
9439 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9440 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9441 Doc-string fixes.
9442 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9443 Argument WINDOW can be now internal window too.
9444 (Fwindow_use_time): Move up in code.
9445 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9446 Rewrite doc-string.
9447 (Fset_window_configuration, saved_window)
9448 (Fcurrent_window_configuration, save_window_save): Handle new
9449 members of window structure.
b9e809c2
MR
9450 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9451 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9452 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9453 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9454 Qget_mru_window, Qresize_root_window,
9455 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9456 Qauto_buffer_name; staticpro them.
f3d1777e 9457
abde8f8c
MR
94582011-06-07 Martin Rudalics <rudalics@gmx.at>
9459
9460 * window.c (Fwindow_total_size, Fwindow_left_column)
9461 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9462 (Fwindow_list_1): New functions.
9463 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9464 (Fwindow_width, Fscroll_left, Fscroll_right):
9465 Use window_body_cols instead of window_box_text_cols.
9466 (delete_window, Fset_window_configuration):
9467 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9468 (delete_all_subwindows): Take a window as argument and not a
9469 structure. Rewrite.
190b47e6
MR
9470 (window_loop): Remove handling of GET_LRU_WINDOW and
9471 GET_LARGEST_WINDOW.
9472 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9473
9474 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9475 window_box_text_cols. delete_all_subwindows now takes a
9476 Lisp_Object as argument.
abde8f8c 9477
640c8776
SM
9478 * indent.c (compute_motion, Fcompute_motion):
9479 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9480
fa8a67e6
MR
9481 * frame.c (delete_frame): Call delete_all_subwindows with root
9482 window as argument.
9483
a54e3482
DC
94842011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9485
9486 * fns.c (Fputhash): Document return value.
9487
60002bf5
CY
94882011-06-06 Chong Yidong <cyd@stupidchicken.com>
9489
9490 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9491
0c671da6 94922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9493
b862a52a 9494 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9495
be44ca6c
PE
9496 Check for overflow when converting integer to cons and back.
9497 * charset.c (Fdefine_charset_internal, Fdecode_char):
9498 Use cons_to_unsigned to catch overflow.
9499 (Fencode_char): Use INTEGER_TO_CONS.
9500 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9501 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9502 * data.c (long_to_cons, cons_to_long): Remove.
9503 (cons_to_unsigned, cons_to_signed): New functions.
9504 These signal an error for invalid or out-of-range values.
9505 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9506 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9507 * font.c (Ffont_variation_glyphs):
9508 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9509 * lisp.h: Include <intprops.h>.
9510 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9511 (cons_to_signed, cons_to_unsigned): New decls.
9512 (long_to_cons, cons_to_long): Remove decls.
9513 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9514 (Fprimitive_undo): Use CONS_TO_INTEGER.
9515 * xfns.c (Fx_window_property): Likewise.
9516 * xselect.c: Include <limits.h>.
9517 (x_own_selection, selection_data_to_lisp_data):
9518 Use INTEGER_TO_CONS.
9519 (x_handle_selection_request, x_handle_selection_clear)
9520 (x_get_foreign_selection, Fx_disown_selection_internal)
9521 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9522 (lisp_data_to_selection_data): Use cons_to_unsigned.
9523 (x_fill_property_data): Use cons_to_signed.
9524 Report values out of range.
9525
d1f3d2af
PE
9526 Check for buffer and string overflow more precisely.
9527 * buffer.h (BUF_BYTES_MAX): New macro.
9528 * lisp.h (STRING_BYTES_MAX): New macro.
9529 * alloc.c (Fmake_string):
9530 * character.c (string_escape_byte8):
9531 * coding.c (coding_alloc_by_realloc):
9532 * doprnt.c (doprnt):
9533 * editfns.c (Fformat):
9534 * eval.c (verror):
9535 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9536 since they may not be the same number.
9537 * editfns.c (Finsert_char):
9538 * fileio.c (Finsert_file_contents):
9539 Likewise for BUF_BYTES_MAX.
9540
dd52fcea
PE
9541 * image.c: Use ptrdiff_t, not int, for sizes.
9542 (slurp_file): Switch from int to ptrdiff_t.
9543 All uses changed.
9544 (slurp_file): Check that file size fits in both size_t (for
9545 malloc) and ptrdiff_t (for sanity and safety).
9546
7f9bbdbb
PE
9547 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9548 if b->modtime has its maximal value.
9549
dfe18f82
PE
9550 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9551
84acfcf0
PE
9552 Don't assume time_t can fit into int.
9553 * buffer.h (struct buffer.modtime): Now time_t, not int.
9554 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9555 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9556
ccd9a01a
PE
9557 Minor fixes for signed vs unsigned integers.
9558 * character.h (MAYBE_UNIFY_CHAR):
9559 * charset.c (maybe_unify_char):
9560 * keyboard.c (read_char, reorder_modifiers):
9561 XINT -> XFASTINT, since the integer must be nonnegative.
9562 * ftfont.c (ftfont_spec_pattern):
9563 * keymap.c (access_keymap, silly_event_symbol_error):
9564 XUINT -> XFASTINT, since the integer must be nonnegative.
9565 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9566 since it makes no difference and we prefer signed.
9567 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9568 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9569 nonnegative.
9570
d6d100dd
SM
95712011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9572
9573 * window.h (Fwindow_frame): Declare.
9574
2b6148e4
PE
95752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9576
9577 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9578 (SPARE_MEMORY): Always define.
9579 (LARGE_REQUEST): Remove.
9580 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9581
f230ecc9
MR
95822011-06-06 Martin Rudalics <rudalics@gmx.at>
9583
727e958e
MR
9584 * lisp.h: Move EXFUNS for Fframe_root_window,
9585 Fframe_first_window and Fset_frame_selected_window to window.h.
9586
9587 * window.h: Move EXFUNS for Fframe_root_window,
9588 Fframe_first_window and Fset_frame_selected_window here from
9589 lisp.h.
9590
9591 * frame.c (Fwindow_frame, Fframe_first_window)
9592 (Fframe_root_window, Fframe_selected_window)
9593 (Fset_frame_selected_window): Move to window.c.
9594 (Factive_minibuffer_window): Move to minibuf.c.
9595 (Fother_visible_frames_p): New function.
9596
9597 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9598
f230ecc9
MR
9599 * window.c (decode_window, decode_any_window): Move up in code.
9600 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9601 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9602 (Fwindow_buffer): Move up and rewrite doc-string.
9603 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9604 (Fwindow_prev): New functions.
727e958e
MR
9605 (Fwindow_frame): Move here from frame.c. Accept any window as
9606 argument.
9607 (Fframe_root_window, Fframe_first_window)
9608 (Fframe_selected_window): Move here from frame.c. Accept frame
9609 or arbitrary window as argument. Update doc-strings.
9610 (Fminibuffer_window): Move up in code.
9611 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9612 (Fset_frame_selected_window): Move here from frame.c.
9613 Marginal rewrite.
727e958e
MR
9614 (Fselected_window, select_window, Fselect_window): Move up in
9615 code. Minor doc-string fixes.
f230ecc9 9616
4d09bcf6
PE
96172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9618
9619 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9620 Do not assume that spare memory exists; that assumption is valid
9621 only if SYSTEM_MALLOC.
9622 (LARGE_REQUEST): New macro, so that the issue of large requests
9623 is separated from the issue of spare memory.
9624
810928a2
AS
96252011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9626
172418ad
AS
9627 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9628 format. (Bug#8806)
9629
43f862f7
AS
9630 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9631
810928a2
AS
9632 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9633 before statements.
9634
a059fe24
JD
96352011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9636
9637 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9638
9639 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9640
9641 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9642 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9643
989bf368
JB
96442011-06-05 Juanma Barranquero <lekktu@gmail.com>
9645
9646 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9647
4b80f674
CY
96482011-06-04 Chong Yidong <cyd@stupidchicken.com>
9649
9650 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9651 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9652 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9653 New error handlers.
4b80f674
CY
9654 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9655 Obey Vx_select_enable_clipboard_manager. Catch errors in
9656 x_clipboard_manager_save (Bug#8779).
9657 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9658 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9659
99a33b77 96602011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9661
9662 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9663
99a33b77 96642011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9665
9666 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9667 in the current matrix if keep_current_p is non-zero.
9668
8264569d
EZ
96692011-06-04 Eli Zaretskii <eliz@gnu.org>
9670
9671 * bidi.c (bidi_level_of_next_char): Fix last change.
9672
57f97249
EZ
96732011-06-03 Eli Zaretskii <eliz@gnu.org>
9674
fec2107c 9675 Support bidi reordering of text covered by display properties.
57f97249 9676
fec2107c
EZ
9677 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9678 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9679 (bidi_cache_search, bidi_cache_iterator_state)
9680 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9681 (bidi_level_of_next_char, bidi_move_to_visually_next):
9682 Support character positions inside a run of characters covered by a
fec2107c
EZ
9683 display string.
9684 (bidi_paragraph_init, bidi_resolve_explicit_1)
9685 (bidi_level_of_next_char): Call bidi_fetch_char and
9686 bidi_fetch_char_advance instead of FETCH_CHAR and
9687 FETCH_CHAR_ADVANCE.
9688 (bidi_init_it): Initialize new members.
9689 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9690 definitions.
9691 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9692 instead of using explicit *_CHAR codes.
d6d100dd
SM
9693 (bidi_resolve_explicit, bidi_resolve_weak):
9694 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9695 bidirectional text is supported only in multibyte buffers.
9696 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9697 it to initialize the frame_window_p member of struct bidi_it.
9698 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9699 (bidi_resolve_explicit, bidi_resolve_weak)
9700 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9701 bidi_it->nchars is non-positive.
9702 (bidi_level_of_next_char): Don't try to lookup the cache for the
9703 next/previous character if nothing is cached there yet, or if we
9704 were just reseat()'ed to a new position.
c40e2fb2 9705
0e14fe90
EZ
9706 * xdisp.c (set_cursor_from_row): Set start and stop points
9707 according to the row's direction when priming the loop that looks
9708 for the glyph on which to display cursor.
9709 (single_display_spec_intangible_p): Function deleted.
9710 (display_prop_intangible_p): Reimplement to call
9711 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9712 Accept 3 additional arguments needed by handle_display_spec.
9713 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9714 values: lists, `(when COND...)' forms, etc.
9715 (single_display_spec_string_p): Support property values that are
9716 lists with the argument STRING its top-level element.
9717 (display_prop_string_p): Fix the condition for processing a
9718 property that is a list to be consistent with handle_display_spec.
fec2107c 9719 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9720 last portion of handle_display_prop.
9721 (compute_display_string_pos): Accept additional argument
9722 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9723 value of a `display' property is a "replacing spec".
9724 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9725 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9726 the display property, but just return a value indicating whether
9727 the display property will replace the characters it covers.
9728 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9729 frame_window_p members of struct bidi_it.
d6d100dd
SM
9730 (compute_display_string_pos, compute_display_string_end):
9731 New functions.
fec2107c
EZ
9732 (push_it): Accept second argument POSITION, where pop_it should
9733 jump to continue iteration.
9734 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9735
fec2107c
EZ
9736 * keyboard.c (adjust_point_for_property): Adjust the call to
9737 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9738
9739 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9740 (bidi_init_it): Update prototypes.
9741 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9742 (compute_display_string_pos, compute_display_string_end):
9743 Declare prototypes.
fec2107c
EZ
9744 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9745 EMACS_INT.
fc6f18ce 9746
40087514 97472011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9748
57f53182
PE
9749 Malloc failure behavior now depends on size of allocation.
9750 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9751 * lisp.h: Change signatures accordingly.
9752 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9753 All callers changed. (Bug#8762)
9754
9755 * gnutls.c: Use Emacs's memory allocators.
9756 Without this change, the gnutls library would invoke malloc etc.
9757 directly, which causes problems on non-SYNC_INPUT hosts, and which
9758 runs afoul of improving memory_full behavior. (Bug#8761)
9759 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9760 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9761 xfree instead of the default malloc, realloc, free.
9762 (Fgnutls_boot): No need to check for memory allocation failure,
9763 since xmalloc does that for us.
9764
ac32cd99 9765 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9766 * category.c (hash_get_category_set):
9767 * ccl.c (ccl_driver):
9768 * charset.c (Fdefine_charset_internal):
9769 * charset.h (struct charset.hash_index):
9770 * composite.c (get_composition_id, gstring_lookup_cache)
9771 (composition_gstring_put_cache):
9772 * composite.h (struct composition.hash_index):
9773 * dispextern.h (struct image.hash):
9774 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9775 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9776 (hashfn_equal, hashfn_user_defined, make_hash_table)
9777 (maybe_resize_hash_table, hash_lookup, hash_put)
9778 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9779 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9780 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9781 * image.c (make_image, search_image_cache, lookup_image)
9782 (xpm_put_color_table_h):
9783 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9784 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9785 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9786 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9787 * alloc.c (allocate_vectorlike):
9788 Check for overflow in vector size calculations.
9789 * ccl.c (ccl_driver):
9790 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9791 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9792 need to be updated by these changes.
40087514
PE
9793 * fns.c (make_hash_table, maybe_resize_hash_table):
9794 Check for integer overflow with large hash tables.
0de4bb68
PE
9795 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9796 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9797 (SXHASH_REDUCE): New macro.
9798 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9799 Use it instead of discarding useful hash info with large hash values.
9800 (sxhash_float): New function.
9801 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9802 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9803 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9804 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9805 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9806 Adjust signatures to match updated version of code.
9807 (consing_since_gc): Now EMACS_INT, since a single hash table can
9808 use more than INT_MAX bytes.
9809
698d32e2
DN
98102011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9811
9812 Make it possible to build with GCC-4.6+ -O2 -flto.
9813
9814 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9815
fd6fa53f
SM
98162011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9817
9818 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9819 Call minibuffer-inactive-mode.
9820
864db017
JB
98212011-05-31 Juanma Barranquero <lekktu@gmail.com>
9822
9823 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9824 Update dependencies.
9825
2ad0baf4
DN
98262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9827
9828 * data.c (init_data): Remove code for UTS, this system is not
9829 supported anymore.
9830
4fcc2638
DN
98312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9832
9833 Don't force ./temacs to start in terminal mode.
9834
9835 * frame.c (make_initial_frame): Initialize faces in all cases, not
9836 only when CANNOT_DUMP is defined.
9837 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9838
c56e0fd5
DN
98392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9840
9841 * dispnew.c (add_window_display_history): Use const for the string
9842 pointer. Remove declaration, not needed.
9843
333d54da 98442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9845
55d4c1b2 9846 Use 'inline', not 'INLINE'.
333d54da 9847 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9848 * alloc.c, fontset.c (INLINE): Remove.
9849 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9850 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9851 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9852 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9853 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9854
738db178
DN
98552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9856
9857 Make it possible to run ./temacs.
9858
9859 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9860 syms_of_callproc does the same thing. Remove test for
9861 "initialized", do it in the caller.
9862 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9863
620c53a6
SM
98642011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9865
9866 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9867 (read_minibuf): Use get_minibuffer.
9868 (syms_of_minibuf): Use DEFSYM.
9869 (Qmetadata): New var.
9870 * data.c (Qbuffer): Don't make it static.
9871 (syms_of_data): Use DEFSYM.
9872
e003a292
PE
98732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9874
9875 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9876 (CCL_CODE_MIN): New macro.
9877
ed008a6d
PE
98782011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9879
3687c2ef
PE
9880 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9881
ed008a6d
PE
9882 * eval.c (Qdebug): Now static.
9883 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9884 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9885 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9886
d66c4c7c
CY
98872011-05-29 Chong Yidong <cyd@stupidchicken.com>
9888
9889 * image.c: Various fixes to ImageMagick code comments.
9890 (Fimagemagick_types): Doc fix.
9891
5fbc2025
PE
98922011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9893
0196f88a
PE
9894 Minor fixes prompted by GCC 4.6.0 warnings.
9895
9896 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9897
5fbc2025
PE
9898 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9899 (x_clipboard_manager_save_all): Move extern decl to ...
9900 * xterm.h: ... here, so that it can be checked for consistency.
9901
1dd3c2d9
CY
99022011-05-29 Chong Yidong <cyd@stupidchicken.com>
9903
9904 * xselect.c (x_clipboard_manager_save_frame)
9905 (x_clipboard_manager_save_all): New functions.
9906 (Fx_clipboard_manager_save): Lisp function deleted.
9907
9908 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9909 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9910
9911 * xterm.h: Update prototype.
9912
5ba6571d
WX
99132011-05-28 William Xu <william.xwl@gmail.com>
9914
9915 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9916 exiting (Bug#8239).
9917
3eaff834
JM
99182011-05-28 Jim Meyering <meyering@redhat.com>
9919
e1900994 9920 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9921 * fns.c (to_uchar): Define.
9922 (crypto_hash_function): Use it to convert some newly-signed
9923 variables to unsigned, to avoid sign-extension bugs. For example,
9924 without this change, (md5 "truc") would evaluate to
9925 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9926 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9927 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9928
0f6990a7
PE
99292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9930
9931 Integer overflow fixes.
c8a9ca5a 9932
08686060
PE
9933 * dbusbind.c: Serial number integer overflow fixes.
9934 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9935 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9936 to hold a serial number that is too large for a fixnum.
9937 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9938 Check for serial numbers out of range. Decode any serial number
59568bf0 9939 that was so large that it became a float. (Bug#8722)
08686060 9940
2d1fc3c7
PE
9941 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9942 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9943 Use XFASTINT rather than XUINT when numbers are nonnegative.
9944 (xd_append_arg, Fdbus_method_return_internal):
9945 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9946 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9947 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9948 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9949 (Bug#8722)
2d1fc3c7 9950
c8a9ca5a
PE
9951 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9952
519e1d69
PE
9953 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9954
6df6ae42 9955 ccl: Add integer overflow checks.
30569699
PE
9956 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9957 (IN_INT_RANGE): New macros.
9958 (ccl_driver): Use them to check for integer overflow when
9959 decoding a CCL program. Many of the new checks are whether XINT (x)
9960 fits in int; it doesn't always, on 64-bit hosts. The new version
9961 doesn't catch all possible integer overflows, but it's an
847044ea 9962 improvement. (Bug#8719)
30569699 9963
c11285dc
PE
9964 * alloc.c (make_event_array): Use XINT, not XUINT.
9965 There's no need for unsigned here.
9966
fdccd48e
PE
9967 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9968 This follows up to the 2011-05-06 change that substituted uintptr_t
9969 for EMACS_INT. This case wasn't caught back then.
9970
37910ab2
PE
9971 Rework Fformat to avoid integer overflow issues.
9972 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9973 now (part of C89). Include <verify.h>.
9974 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9975 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9976 (Fformat): Avoid the prepass trying to compute sizes; it was only
9977 approximate and thus did not catch overflow reliably. Instead, walk
9978 through the format just once, formatting and computing sizes as we go,
9979 checking for integer overflow at every step, and allocating a larger
9980 buffer as needed. Keep track separately whether the format is
9981 multibyte. Keep only the most-recently calculated precision, rather
9982 than them all. Record whether each argument has been converted to
9983 string. Use EMACS_INT, not int, for byte and char and arg counts.
9984 Support field widths and precisions larger than INT_MAX. Avoid
9985 sprintf's undefined behavior with conversion specifications such as %#d
9986 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9987 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9988 formatting out-of-range floating point numbers with int
9173deec 9989 formats. (Bug#8668)
37910ab2 9990
2e6578fb
PE
9991 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9992
0ae6bdee
PE
9993 * data.c: Avoid integer truncation in expressions involving floats.
9994 * data.c: Include <intprops.h>.
9995 (arith_driver): When there's an integer overflow in an expression
9996 involving floating point, convert the integers to floating point
9997 so that the resulting value does not suffer from catastrophic
9998 integer truncation. For example, on a 64-bit host (* 4
9999 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10000 Do not rely on undefined behavior after integer overflow.
10001
de883a70
PE
10002 merge count_size_as_multibyte, parse_str_to_multibyte
10003 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10004 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10005 Check for integer overflow.
10006 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10007 since it's now a duplicate of the other. This is more of
10008 a character than a buffer op, so better that it's in character.c.
10009 * fns.c, print.c: Adjust to above changes.
10010
2ff916cb
PE
100112011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10012
10013 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10014
f1b54466
PE
100152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10016
fb1ac845
PE
10017 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10018 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10019 (x_clipboard_manager_save): Now static.
10020 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10021
f1b54466
PE
10022 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10023 (crypto_hash_function): Now static.
10024 Fix pointer signedness problems. Avoid unnecessary initializations.
10025
a9f737ee
CY
100262011-05-27 Chong Yidong <cyd@stupidchicken.com>
10027
10028 * termhooks.h (Vselection_alist): Make it terminal-local.
10029
10030 * terminal.c (create_terminal): Initialize it.
10031
10032 * xselect.c: Support for clipboard managers.
10033 (Vselection_alist): Move to termhooks.h as terminal-local var.
10034 (LOCAL_SELECTION): New macro.
10035 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10036 (symbol_to_x_atom): Remove gratuitous arg.
10037 (x_handle_selection_request, lisp_data_to_selection_data)
10038 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10039 (x_own_selection, x_get_local_selection, x_convert_selection):
10040 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10041 (some_frame_on_display): Delete unused function.
10042 (Fx_own_selection_internal, Fx_get_selection_internal)
10043 (Fx_disown_selection_internal, Fx_selection_owner_p)
10044 (Fx_selection_exists_p): New optional frame arg.
10045 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10046 (x_handle_selection_clear): Don't treat other terminals with the
10047 same keyboard specially. Use the terminal-local Vselection_alist.
10048 (x_clear_frame_selections): Use Frun_hook_with_args.
10049
10050 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10051
10052 * xterm.h: Add support for those atoms.
10053
e067f0c1
CY
100542011-05-26 Chong Yidong <cyd@stupidchicken.com>
10055
10056 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10057 (converted_selections, conversion_fail_tag): New global variables.
10058 (x_selection_request_lisp_error): Free the above.
10059 (x_get_local_selection): Remove unnecessary code.
10060 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10061 of converted selections stored in converted_selections.
10062 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10063 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10064 (x_convert_selection): New function.
10065 (x_handle_selection_event): Simplify.
10066 (x_get_foreign_selection): Don't ignore incoming requests while
10067 waiting for an answer; this will fail when we implement
10068 SAVE_TARGETS, and seems unnecessary anyway.
10069 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10070 (Vx_sent_selection_functions): Doc fix.
10071
0f4aebc0
LL
100722011-05-26 Leo Liu <sdl.web@gmail.com>
10073
10074 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10075
e61124cd
YM
100762011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10077
10078 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10079
10080 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10081 for fringe update if it has periodic bitmap.
ac389d0c 10082 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10083 and fringe_bitmap_periodic_p.
10084
10085 * fringe.c (get_fringe_bitmap_data): New function.
10086 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10087 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10088 row. Mark glyph row for fringe update if periodicity changed.
10089
10090 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10091 for fringe update unless it has periodic bitmap.
10092
f16d9837
KH
100932011-05-25 Kenichi Handa <handa@m17n.org>
10094
10095 * xdisp.c (get_next_display_element): Set correct it->face_id for
10096 a static composition.
10097
e1b90ef6
LL
100982011-05-24 Leo Liu <sdl.web@gmail.com>
10099
10100 * deps.mk (fns.o):
10101 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10102
10103 * fns.c (crypto_hash_function, Fsha1): New function.
10104 (Fmd5): Use crypto_hash_function.
10105 (syms_of_fns): Add Ssha1.
10106
7400048f
PE
101072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10108
10109 * gnutls.c: Remove unused macros.
10110 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10111 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10112 Remove macros that are defined and never used.
10113 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10114
abb71cf4
CY
101152011-05-22 Chong Yidong <cyd@stupidchicken.com>
10116
10117 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10118 (Fx_get_selection_internal): Minor cleanup.
10119 (Fx_own_selection_internal): Rename arguments for consistency with
10120 select.el.
10121
6307db39
PE
101222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10123
10124 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10125
f3d4e0a4
CY
101262011-05-22 Chong Yidong <cyd@stupidchicken.com>
10127
10128 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10129
4d8ade89
YM
101302011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10131
10132 * dispnew.c (scrolling_window): Don't exclude the case that the
10133 last enabled row in the desired matrix touches the bottom boundary.
10134
32078c8d
GM
101352011-05-21 Glenn Morris <rgm@gnu.org>
10136
10137 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10138 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10139 and add some more files.
32078c8d 10140
7285dc67
EZ
101412011-05-20 Eli Zaretskii <eliz@gnu.org>
10142
10143 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10144 report_file_error introduced by the change from 2011-05-07.
10145
89d1bd22
PE
101462011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10147
10148 * systime.h (Time): Define only if emacs is defined.
10149 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10150 where the include path doesn't have X11/X.h by default. See
10151 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10152
cd394be1 101532011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10154
10155 * composite.c (find_automatic_composition): Fix previous change.
10156
b9704ad9
GM
101572011-05-20 Glenn Morris <rgm@gnu.org>
10158
10159 * lisp.mk: New file, split from Makefile.in.
10160 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10161 (shortlisp): Remove.
10162 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10163
4a720484
GM
101642011-05-19 Glenn Morris <rgm@gnu.org>
10165
10166 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10167 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10168 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10169 (lisp): Set the order to that of loadup.el.
10170 (shortlisp): Make it a copy of $lisp.
10171 (SOME_MACHINE_LISP): Remove.
10172 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10173 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10174
a28d4396
KH
101752011-05-18 Kenichi Handa <handa@m17n.org>
10176
10177 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10178 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10179 (find_automatic_composition): Mostly rewrite for efficiency.
10180
a2b1fa8e
JB
101812011-05-18 Juanma Barranquero <lekktu@gmail.com>
10182
10183 * makefile.w32-in: Update dependencies.
10184
8e1f5610
CS
101852011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10186
10187 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10188 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10189
7025ee00 101902011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10191
cdfa6eab
PE
10192 Fix some integer overflow issues, such as string length overflow.
10193
06d6db33
PE
10194 * insdel.c (count_size_as_multibyte): Check for string overflow.
10195
2b4560a8
PE
10196 * character.c (lisp_string_width): Check for string overflow.
10197 Use EMACS_INT, not int, for string indexes and lengths; in
10198 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10199 the resulting string length overflows an EMACS_INT; instead,
10200 report a string overflow if no precision given. When checking for
10201 precision exhaustion, use a check that cannot possibly have
10202 integer overflow. (Bug#8675)
10203 * character.h (lisp_string_width): Adjust to new signature.
10204
cb93f9be
PE
10205 * alloc.c (string_overflow): New function.
10206 (Fmake_string): Use it. This doesn't change behavior, but saves
10207 a few bytes and will simplify future changes.
10208 * character.c (string_escape_byte8): Likewise.
10209 * lisp.h (string_overflow): New decl.
10210
1a1f3366
PE
10211 Fixups, following up to the user-interface timestamp change.
10212 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10213 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10214 * msdos.c (mouse_get_pos): Likewise.
10215 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10216 * w32gui.h (Time): Define by including "systime.h" rather than by
10217 declaring it ourselves. (Bug#8664)
10218
d4e3e4d3
PE
10219 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10220 * image.c (clear_image_cache): Likewise.
10221
f6a24d19
PE
10222 * term.c (term_mouse_position): Don't assume time_t wraparound.
10223
08dc5ae6
PE
10224 Be more systematic about user-interface timestamps.
10225 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10226 and sometimes 'EMACS_UINT', to represent these timestamps.
10227 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10228 This makes the code easier to follow, and makes it easier to catch
10229 integer overflow bugs such as Bug#8664.
10230 * frame.c (Fmouse_position, Fmouse_pixel_position):
10231 Use Time, not unsigned long, for user-interface timestamps.
10232 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10233 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10234 * keyboard.h (last_event_timestamp): Likewise.
10235 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10236 * menu.h (xmenu_show): Likewise.
10237 * term.c (term_mouse_position): Likewise.
10238 * termhooks.h (struct input_event.timestamp): Likewise.
10239 (struct terminal.mouse_position_hook): Likewise.
10240 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10241 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10242 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10243 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10244 what it was before.
10245 * menu.h, termhooks.h: Include "systime.h", for Time.
10246
8e55734a
PE
10247 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10248 Don't assume that the difference between two unsigned long values
10249 can fit into an integer. At this point, we know button_down_time
10250 <= event->timestamp, so the difference must be nonnegative, so
10251 there's no need to cast the result if double-click-time is
10252 nonnegative, as it should be; check that it's nonnegative, just in
10253 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10254 apart (about 25 days). (Bug#8664)
8e55734a 10255
841f1b75 10256 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10257 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10258
3e26f69c
PE
10259 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10260 that always fit in int. Use a sentinel instead of a counter, to
10261 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10262 * frame.h (struct frame): Use int for menu_bar_items_used
10263 instead of EMACS_INT, since it always fits in int.
3e26f69c 10264
5cc152c0
PE
10265 * menu.c (grow_menu_items): Check for int overflow.
10266
d89eb65e
PE
10267 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10268
5235bd3e
PE
10269 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10270 Before, the code was not consistent. These values cannot exceed
10271 2**31 - 1 so there's no need to make them unsigned.
10272 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10273 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10274 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10275 as modifiers.
10276 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10277
bc827e23
PE
10278 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10279 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10280 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10281 presumably because the widths might not match.
10282
78eb494e
PE
10283 * window.c (size_window): Avoid needless test at loop start.
10284
04f2d78b
CB
102852011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10286
10287 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10288
d2fc7e3d 102892011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10290
10291 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10292
d2fc7e3d 102932011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10294
10295 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10296 `width' to `bar_area_x' and `bar_area_width', respectively.
10297 (x_scroll_run): Take account of fringe background extension.
10298
04f2d78b
CB
10299 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10300 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10301 `bar_area_width', respectively.
10302 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10303 background extension.
10304
79b70037
GM
103052011-05-10 Jim Meyering <meyering@redhat.com>
10306
10307 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10308
2f142cc5
JB
103092011-05-10 Juanma Barranquero <lekktu@gmail.com>
10310
10311 * image.c (Finit_image_library): Return t for built-in image types,
10312 like pbm and xbm. (Bug#8640)
10313
57679c86
AS
103142011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10315
10316 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10317
888c9e86
EZ
103182011-05-07 Eli Zaretskii <eliz@gnu.org>
10319
b0512a1d
EZ
10320 * w32console.c (Fset_screen_color): Doc fix.
10321 (Fget_screen_color): New function.
10322 (syms_of_ntterm): Defsubr it.
10323
7285dc67
EZ
10324 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10325 unlink the temporary file if Fcall_process didn't create it in the
10326 first place.
10327 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10328 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10329 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10330 cue to call_process_cleanup not to close that handle.
10331
4d3fcc8e
BK
103322011-05-07 Ben Key <bkey76@gmail.com>
10333
10334 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10335 one of two shell specific rules, either bootstrap-temacs-CMD or
10336 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10337 to the previous implementation of the bootstrap-temacs rule.
10338 The bootstrap-temacs-CMD rule is similar to the previous
10339 implementation of the bootstrap-temacs rule except that it
10340 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10341 variable.
10342
10343 These changes, along with some changes to nt/configure.bat,
10344 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10345 earlier fix to add support for --cflags and --ldflags options
10346 that include quotes so that it works whether make uses cmd or
10347 sh as the shell.
10348
b4289b64
MA
103492011-05-06 Michael Albinus <michael.albinus@gmx.de>
10350
10351 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10352 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10353 is a constant.
10354 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10355 a string. Handle both cases.
10356 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10357 (Fdbus_register_method): Use Qinvalid_function.
10358
af4c0e28
JB
103592011-05-06 Juanma Barranquero <lekktu@gmail.com>
10360
10361 * makefile.w32-in: Update dependencies.
10362 (LISP_H): Add inttypes.h and stdin.h.
10363 (PROCESS_H): Add unistd.h.
10364
c51453d9
EZ
103652011-05-06 Eli Zaretskii <eliz@gnu.org>
10366
10367 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10368 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10369
8ff0ac3c 103702011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10371
4c4b566b
PE
10372 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10373
aab2b9b5
PE
10374 * term.c (vfatal): Remove stray call to va_end.
10375 It's not needed and the C Standard doesn't allow it here anyway.
10376
c378da0b
PE
10377 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10378 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10379
288b08c7
PE
10380 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10381 bytes.
10382
e3601888
PE
10383 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10384
db6c0e74
PE
10385 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10386
dd5963ea
PE
10387 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10388
88c9450f
PE
10389 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10390
2f9442b8
PE
10391 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10392
c032b5f8
PE
10393 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10394 * charset.c (Fdefine_charset_internal): Don't initialize
10395 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10396 32-bit int (Bug#8600).
a108c10b
PE
10397
10398 * lread.c (read_integer): Be more consistent with string-to-number.
10399 Use string_to_number to do the actual conversion; this avoids
10400 rounding errors and fixes some other screwups. Without this fix,
10401 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10402 (digit_to_number): Move earlier, for benefit of read_integer.
10403 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10404 not a digit in any supported base. (Bug#8602)
a108c10b 10405
ad5f9eea
PE
10406 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10407
aec1708a
PE
10408 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10409 to match comment at start of function. This also removes a
10410 GCC warning about overflow in a 32+64-bit port.
10411
47be4ab5
PE
10412 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10413
371cac43
PE
10414 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10415 Reported by Stefan Monnier in
10416 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10417 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10418 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10419
d01a7826
PE
10420 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10421 (EMACS_UINTPTR): Likewise, with uintptr_t.
10422
7fd47d5c
PE
10423 * lisp.h: Prefer 64-bit EMACS_INT if available.
10424 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10425 on 32-bit hosts that have 64-bit int, so that they can access
10426 large files.
122b0c86
PE
10427 However, temporarily disable this change unless the temporary
10428 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10429
8727937b
PE
10430 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10431
8ac068ac
PE
10432 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10433 This removes an assumption that EMACS_INT and long are the same
10434 width as pointers. The assumption is true for Emacs porting targets
10435 now, but we want to make other targets possible.
10436 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10437 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10438 In the rest of the code, change types of integers that hold casted
10439 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10440 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10441 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10442 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10443 No need to cast type when ORing.
10444 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10445 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10446 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10447 assume EMACS_INT is the same width as char *.
10448 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10449 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10450 Remove no-longer-needed casts.
10451 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10452 (xg_tool_bar_help_callback, xg_make_tool_item):
10453 Use EMACS_INTPTR to hold an integer
10454 that will be cast to void *; this can avoid a GCC warning
10455 if EMACS_INT is not the same width as void *.
10456 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10457 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10458 (current_message_1, set_message_1):
10459 Use a local to convert to proper width without a cast.
10460 * xmenu.c (dialog_selection_callback): Likewise.
10461
ede49d71
PE
10462 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10463 Also, don't assume VALBITS / RAND_BITS is less than 5,
10464 and don't rely on undefined behavior when shifting a 1 left into
10465 the sign bit.
10466 * lisp.h (get_random): Change signature to match.
10467
2f30ecd0
PE
10468 * lread.c (hash_string): Use size_t, not int, for hash computation.
10469 Normally we prefer signed values; but hashing is special, because
10470 it's better to use unsigned division on hash table sizes so that
10471 the remainder is nonnegative. Also, size_t is the natural width
10472 for hashing into memory. The previous code used 'int', which doesn't
10473 retain enough info to hash well into very large tables.
10474 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10475
2a866e7b
PE
10476 * dbusbind.c: Don't possibly lose pointer info when converting.
10477 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10478 Use XPNTR rather than XHASH, so that the high-order bits of
10479 the pointer aren't lost when converting through void *.
10480
51639eac
PE
10481 * eval.c (Fautoload): Don't double-shift a pointer.
10482
92394119
PE
10483 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10484
dbdb9a7c
JB
104852011-05-06 Juanma Barranquero <lekktu@gmail.com>
10486
10487 * gnutls.c (DEF_GNUTLS_FN):
10488 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10489
db7a0b4f
AS
104902011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10491
10492 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10493 marker. (Bug#8610)
10494
cd394be1 104952011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10496
10497 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10498 New version that can reserve upto 2GB of heap space.
10499
f7ff1b0f 105002011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10501
10502 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10503
639c109b
TZ
105042011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10505
10506 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10507 `gnutls_certificate_set_x509_key_file'.
10508
d2127135
JB
105092011-05-05 Juanma Barranquero <lekktu@gmail.com>
10510
10511 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10512 Update dependencies.
10513
e968f4f3
JB
105142011-05-04 Juanma Barranquero <lekktu@gmail.com>
10515
10516 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10517 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10518 Remove unused parameter `fildes'.
10519 * process.c (read_process_output, send_process): Don't pass it.
10520
84d358f0
JB
105212011-05-04 Juanma Barranquero <lekktu@gmail.com>
10522
10523 Fix previous change: the library cache is defined in w32.c.
10524 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10525 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10526
0898ca10
JB
105272011-05-04 Juanma Barranquero <lekktu@gmail.com>
10528
10529 Implement dynamic loading of GnuTLS on Windows.
10530
10531 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10532 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10533 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10534 Declare.
10535
10536 * gnutls.c (Qgnutls_dll): Define.
10537 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10538 (gnutls_*): Declare function pointers.
10539 (init_gnutls_functions): New function to initialize function pointers.
10540 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10541 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10542 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10543 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10544 (emacs_gnutls_write, emacs_gnutls_read)
10545 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10546 (Fgnutls_available_p): New function.
10547 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10548 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10549 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10550
10551 * image.c: Include w32.h.
10552 (Vimage_type_cache): Delete.
10553 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10554 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10555 (w32_delayed_load): Move to w32.c.
10556
10557 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10558
10559 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10560 (w32_delayed_load): Move from image.c. When loading a library, record
10561 its filename in the :loaded-from property of the library id.
10562 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10563 Initialize and staticpro them.
10564 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10565
10566 * process.c: Include lisp.h before w32.h, not after.
10567 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10568 instead of gnutls_record_check_pending.
10569
10570 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10571
ff4de4aa
TZ
105722011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10573
10574 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10575 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10576 as passed in.
10577
abe95abb
JD
105782011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10579
10580 * xterm.c (x_set_frame_alpha): Do not set property on anything
10581 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10582
e16e55d4
JB
105832011-05-02 Juanma Barranquero <lekktu@gmail.com>
10584
10585 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10586
bafcf6a5
JB
105872011-05-02 Juanma Barranquero <lekktu@gmail.com>
10588
10589 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10590 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10591 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10592 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10593 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10594 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10595 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10596 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10597 (Qgnutls_bootprop_callbacks_verify): Make static.
10598
e7a6747f
AS
105992011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10600
19ed11ba
AS
10601 * callproc.c: Indentation fixup.
10602
e7a6747f 10603 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10604 (wait_for_termination, interruptible_wait_for_termination):
10605 Move after wait_for_termination_1.
e7a6747f 10606
1ef14cb4
LMI
106072011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10608
10609 * sysdep.c (interruptible_wait_for_termination): New function
10610 which is like wait_for_termination, but allows keyboard
10611 interruptions.
10612
10613 * callproc.c (Fcall_process): Add (:file "file") as an option for
10614 the STDOUT buffer.
10615 (Fcall_process_region): Ditto.
10616
330d880c
EZ
106172011-04-30 Eli Zaretskii <eliz@gnu.org>
10618
8db90b73
EZ
10619 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10620 rather than `XVECTOR (FOO)->size'.
10621
330d880c
EZ
10622 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10623 inttypes.h, as a gnulib replacement is used if it not available in
10624 system headers.
10625
15cbd324
EZ
106262011-04-21 Eli Zaretskii <eliz@gnu.org>
10627
10628 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10629 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10630 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10631
10632 * coding.c (coding_alloc_by_realloc): Error out if destination
10633 will grow beyond MOST_POSITIVE_FIXNUM.
10634 (decode_coding_emacs_mule): Abort if there isn't enough place in
10635 charbuf for the composition carryover bytes. Reserve an extra
10636 space for up to 2 characters produced in a loop.
10637 (decode_coding_iso_2022): Abort if there isn't enough place in
10638 charbuf for the composition carryover bytes.
10639
106402011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10641
ae940cca
EZ
10642 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10643 aborting when %lld or %lll format is passed.
10644 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10645 %llo or %llx format is passed. (Bug#8545)
10646
03ab8921
EZ
10647 * window.c (window_scroll_line_based): Use a marker instead of
10648 simple variables to record original value of point. (Bug#7952)
10649
afda1437
EZ
10650 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10651 produced by %s or %c overflows available buffer space. (Bug#8545)
10652
f76dee0c
PE
106532011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10654
10655 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10656 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10657
fdc5744d
JB
106582011-04-28 Juanma Barranquero <lekktu@gmail.com>
10659
10660 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10661
638f053a
JB
106622011-04-28 Juanma Barranquero <lekktu@gmail.com>
10663
10664 * keyboard.c (Qdelayed_warnings_hook): Define.
10665 (command_loop_1): Run `delayed-warnings-hook'
10666 if Vdelayed_warnings_list is non-nil.
10667 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10668 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10669
d178f871
EZ
106702011-04-28 Eli Zaretskii <eliz@gnu.org>
10671
10672 * doprnt.c (doprnt): Don't return value smaller than the buffer
10673 size if the message was truncated. (Bug#8545).
10674
b124fd93
JB
106752011-04-28 Juanma Barranquero <lekktu@gmail.com>
10676
10677 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10678 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10679
e810457d
PE
106802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10681
10682 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10683
ea51cceb
JB
106842011-04-27 Juanma Barranquero <lekktu@gmail.com>
10685
10686 * makefile.w32-in: Update dependencies.
10687
94dcfacf
EZ
106882011-04-27 Eli Zaretskii <eliz@gnu.org>
10689
10690 Improve `doprnt' and its usage. (Bug#8545)
10691 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10692 `format_end'. Remove support for %l as a conversion specifier.
10693 Don't use xrealloc. Improve diagnostics when the %l size modifier
10694 is used. Update the commentary.
10695
10696 * eval.c (verror): Simplify calculation of size_t.
10697
10698 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10699 messages.
10700
f61f41d7
PE
107012011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10702
10703 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10704 change.
10705
96fb4434
PE
107062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10707
10708 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10709 This makes this file independent of the recent pseudovector change.
10710
671875da 107112011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10712
69e9b5a3
PE
10713 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10714
b5f869a7 10715 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10716 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10717 Remove unused local.
c8926152 10718 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10719
841a1577 10720 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10721 GCC 4.6.0 optimizes based on type-based alias analysis.
10722 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10723 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10724 != &v->size, and therefore "v->size = 1; b->size = 2; return
10725 v->size;" must therefore return 1. This assumption is incorrect
10726 for Emacs, since it type-puns struct Lisp_Vector * with many other
10727 types. To fix this problem, this patch adds a new type struct
f904488f 10728 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10729 and pseudovectors, and helps optimizing compilers not get fooled
10730 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10731 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10732 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10733 the size member.
eab3844f
PE
10734 (XSETPVECTYPE): Rewrite in terms of new macro.
10735 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10736 This is a bit clearer, and further avoids the possibility of
10737 undesirable aliasing.
10738 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10739 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10740 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10741 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10742 (ASIZE): Now uses header.size rather than size.
10743 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10744 to avoid the hassle of writing XVECTOR (foo)->header.size.
10745 (struct vectorlike_header): New type.
eab3844f
PE
10746 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10747 object, to help avoid aliasing.
10748 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10749 (SUBRP): Likewise, since Lisp_Subr is a special case.
10750 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10751 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10752 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10753 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10754 changed to be "header.size" and "header.next".
10755 * buffer.h (struct buffer): Likewise.
10756 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10757 * frame.h (struct frame): Likewise.
10758 * process.h (struct Lisp_Process): Likewise.
10759 * termhooks.h (struct terminal): Likewise.
10760 * window.c (struct save_window_data, struct saved_window): Likewise.
10761 * window.h (struct window): Likewise.
10762 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10763 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10764 * buffer.c (init_buffer_once): Likewise.
10765 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10766 special case.
10767 * process.c (Fformat_network_address): Use local var for size,
10768 for brevity.
10769
0df1eac5
PE
10770 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10771
847ab9d1 10772 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10773 * data.c (atof): Remove decl; no longer used or needed.
10774 (digit_to_number): Move to lread.c.
10775 (Fstring_to_number): Use new string_to_number function, to be
10776 consistent with how the Lisp reader treats infinities and NaNs.
10777 Do not assume that floating-point numbers represent EMACS_INT
10778 without losing information; this is not true on most 64-bit hosts.
10779 Avoid double-rounding errors, by insisting on integers when
10780 parsing non-base-10 numbers, as the documentation specifies.
10781 * lisp.h (string_to_number): New decl, replacing ...
10782 (isfloat_string): Remove.
bc0a5c13 10783 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10784 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10785 appears to have been a coding error. Similarly, do not accept
10786 strings like +-1e0 as floating point numbers. Do not report
10787 overflow for integer overflows unless the base is not 10 which
10788 means we have no simple and reliable way to continue.
10789 Break out the floating-point parsing into a new
10790 function string_to_number, so that Fstring_to_number parses
10791 floating point numbers consistently with the Lisp reader.
04f2d78b 10792 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10793 (E_CHAR, EXP_INT): Remove, replacing with ...
10794 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10795 (string_to_number): New function, replacing isfloat_string.
10796 This function checks for valid syntax and produces the resulting
10797 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10798 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10799 so that overflow for non-base-10 numbers is reported only when
10800 there's no portable and simple way to convert to floating point.
452f4150 10801
67769ffc
PE
10802 * textprop.c (set_text_properties_1): Rewrite for clarity,
10803 and to avoid GCC warning about integer overflow.
10804
c20db43f
PE
10805 * intervals.h (struct interval): Use EMACS_INT for members
10806 where EMACS_UINT might cause problems. See
10807 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10808 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10809 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10810 All uses changed.
37aa2f85
PE
10811 (offset_intervals): Tell GCC not to worry about length overflow
10812 when negating a negative length.
c20db43f 10813
2538aa2f
PE
10814 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10815 (overrun_check_free): Likewise.
10816
f2d3008d
PE
10817 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10818 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10819 word size.
10820
ec8df744
PE
10821 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10822 (gnutls_make_error): Rename local to avoid shadowing.
10823 (gnutls_emacs_global_deinit): ifdef out; not used.
10824 (Fgnutls_boot): Use const for pointer to readonly storage.
10825 Comment out unused local. Fix pointer signedness problems.
10826
640ee02d
PE
10827 * lread.c (openp): Don't stuff size_t into an 'int'.
10828 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10829 about possible signed overflow.
10830
6048fb2a
PE
10831 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10832 (GDK_KEY_g): Don't define if already defined.
10833 (xg_prepare_tooltip): Avoid pointer signedness problem.
10834 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10835
fa3c87e1
PE
10836 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10837 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10838
2172544b
PE
10839 * xfns.c (Fx_window_property): Simplify a bit,
10840 to make a bit faster and to avoid GCC 4.6.0 warning.
10841 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10842
9b821a21
PE
10843 * fns.c (internal_equal): Don't assume size_t fits in int.
10844
3c616cfa
PE
10845 * alloc.c (compact_small_strings): Tighten assertion a little.
10846
c2982e87
PE
10847 Replace pEd with more-general pI, and fix some printf arg casts.
10848 * lisp.h (pI): New macro, generalizing old pEd macro to other
10849 conversion specifiers. For example, use "...%"pI"d..." rather
10850 than "...%"pEd"...".
10851 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10852 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10853 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10854 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10855 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10856 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10857 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10858 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10859 64-bit hosts.
10860 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10861 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10862 * print.c (safe_debug_print, print_object): Likewise.
10863 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10864 to int.
6f04d126
PE
10865 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10866 avoiding the 0 flag, which is not portable.
c2982e87
PE
10867 * process.c (Fmake_network_process): Use pI to avoid cast.
10868 * region-cache.c (pp_cache): Likewise.
10869 * xdisp.c (decode_mode_spec): Likewise.
10870 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10871 behavior on 64-bit hosts with printf arg.
6f04d126 10872 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10873 (x_stop_queuing_selection_requests): Likewise.
10874 (x_get_window_property): Don't truncate byte count to an 'int'
10875 when tracing.
0b432f21 10876
5e073ec7
PE
10877 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10878 here, since it parses constructs like leading '-' and spaces,
10879 which are not wanted; and it overflows with large numbers.
10880 Instead, simply match F[0-9]+, which is what is wanted anyway.
10881
36372bf9
PE
10882 * alloc.c: Remove unportable assumptions about struct layout.
10883 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10884 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10885 (allocate_vectorlike, make_pure_vector): Use the new macros,
10886 plus offsetof, to remove unportable assumptions about struct layout.
10887 These assumptions hold on all porting targets that I know of, but
10888 they are not guaranteed, they're easy to remove, and removing them
10889 makes further changes easier.
10890
0b432f21
PE
10891 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10892 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10893 (string_overrun_cookie): Now const. Use initializers that
10894 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10895 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10896 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10897 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10898 multiple of sizeof (EMACS_INT); it need not be, if
10899 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10900 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10901
895009e1
JB
109022011-04-26 Juanma Barranquero <lekktu@gmail.com>
10903
10904 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10905
6a7a1b0b
TZ
109062011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10907
10908 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10909 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10910 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10911
841a1577 109122011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10913
10914 * lisp.h (Qdebug): List symbol.
895009e1 10915 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10916 * keyboard.c (debug-on-event): New variable.
10917 (handle_user_signal): Break into debugger when debug-on-event
10918 matches the current signal symbol.
10919
f2d3ba6f
DN
109202011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10921
10922 * alloc.c (check_sblock, check_string_bytes)
10923 (check_string_free_list): Convert to standard C.
10924
42ce4c63
TZ
109252011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10926
10927 * w32.c (emacs_gnutls_push): Fix typo.
10928
825cd63c
EZ
109292011-04-25 Eli Zaretskii <eliz@gnu.org>
10930
fb11d64d
EZ
10931 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10932 "cast to pointer from integer of different size".
10933
825cd63c
EZ
10934 Improve doprnt and its use in verror. (Bug#8545)
10935 * doprnt.c (doprnt): Document the set of format control sequences
10936 supported by the function. Use SAFE_ALLOCA instead of always
10937 using `alloca'.
10938
10939 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10940 is one byte too soon. Don't use xrealloc; instead xfree and
10941 xmalloc anew.
10942
e061a11b
TZ
109432011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10944
10945 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10946 callbacks stage.
10947
10948 * gnutls.c: Renamed global_initialized to
10949 gnutls_global_initialized. Added internals for the
10950 :verify-hostname-error, :verify-error, and :verify-flags
10951 parameters of `gnutls-boot' and documented those parameters in the
10952 docstring. Start callback support.
9173deec
JB
10953 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10954 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10955 on error. Return error code.
e061a11b
TZ
10956 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10957 (emacs_gnutls_read): Likewise.
10958 (Fgnutls_boot): Return handshake error code.
10959 (emacs_gnutls_handle_error): New function.
10960 (wsaerror_to_errno): Likewise.
10961
10962 * w32.h (emacs_gnutls_pull): Add prototype.
10963 (emacs_gnutls_push): Likewise.
10964
10965 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10966 (emacs_gnutls_push): Likewise.
10967
109682011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10969
10970 * process.c (wait_reading_process_output): Check if GnuTLS
10971 buffered some data internally if no FDs are set for TLS
10972 connections.
10973
10974 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10975 (LIBS): Link to USER_LIBS.
10976 ($(BLD)/gnutls.$(0)): New target.
10977
fa6996bc
EZ
109782011-04-24 Eli Zaretskii <eliz@gnu.org>
10979
eb35682e
EZ
10980 * xdisp.c (handle_single_display_spec): Rename the
10981 display_replaced_before_p argument into display_replaced_p, to
10982 make it consistent with the commentary. Fix typos in the
10983 commentary.
10984
e2ad650c
EZ
10985 * textprop.c (syms_of_textprop): Remove dead code.
10986 (copy_text_properties): Delete obsolete commentary about an
10987 interface that was deleted long ago. Fix typos in the description
10988 of arguments.
10989
1b2de274
EZ
10990 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10991 to changes in oldXMenu/XMenu.h from 2011-04-16.
10992 <menu_help_message, prev_menu_help_message>: Constify.
10993 (IT_menu_make_room): menu->help_text is now `const char **';
10994 adjust.
10995
10996 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10997 to changes in oldXMenu/XMenu.h from 2011-04-16.
10998 (struct XMenu): Declare `help_text' `const char **'.
10999
11000 * xfaces.c <Qunspecified>: Make extern again.
11001
11002 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11003 required by POSIX.
1b2de274 11004
762b15be
EZ
11005 * doc.c (get_doc_string): Improve the format passed to `error'.
11006
11007 * doprnt.c (doprnt): Improve commentary.
11008
11009 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11010
11011 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11012 them with etags.
11013
f1052e5d
EZ
11014 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11015 changes in globals.h immediately force recompilation.
762b15be
EZ
11016 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11017 $(CURDIR)/s/ms-w32.h.
11018 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11019
fa6996bc
EZ
11020 * character.c (Fchar_direction): Function deleted.
11021 (syms_of_character): Don't defsubr it.
11022 <char-direction-table>: Deleted.
11023
e6c3da20
EZ
110242011-04-23 Eli Zaretskii <eliz@gnu.org>
11025
11026 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11027 * doprnt.c: Include limits.h.
11028 (SIZE_MAX): New macro.
04f2d78b
CB
11029 (doprnt): Return a size_t value. 2nd arg is now size_t.
11030 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11031 Improve overflow protection. Support `l' modifier for integer
11032 conversions. Support %l conversion. Don't assume an EMACS_INT
11033 argument for integer conversions and for %c.
11034
11035 * lisp.h (doprnt): Restore prototype.
11036
11037 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11038 $(SRC)/character.h.
11039
11040 * Makefile.in (base_obj): Add back doprnt.o.
11041
11042 * deps.mk (doprnt.o): Add back prerequisites.
11043 (callint.o): Depend on character.h.
11044
11045 * eval.c (internal_lisp_condition_case): Include the handler
11046 representation in the error message.
11047 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11048 when breaking from the loop.
11049
11050 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11051
11052 * callint.c (Fcall_interactively): When displaying error message
11053 about invalid control letter, pass the character's codepoint, not
11054 a pointer to its multibyte form. Improve display of the character
11055 in octal and display also its hex code.
11056
11057 * character.c (char_string): Use %x to display the (unsigned)
11058 codepoint of an invalid character, to avoid displaying a bogus
11059 negative value.
11060
11061 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11062 `error', not SYMBOL_NAME itself.
11063
11064 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11065 character arguments to `error'.
11066
11067 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11068 to `error' in error message about FINAL_CHAR argument. Make sure
11069 FINAL_CHAR is a character, and use %c when it is passed as
11070 argument to `error'.
11071
4ffd0d6b 110722011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11073
11074 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11075
11076 * w32.c: Include <time.h>.
11077 (sys_localtime): New function.
11078
4ffd0d6b 110792011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11080
11081 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11082
4ffd0d6b 11083 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11084
4ffd0d6b 110852011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11086
4ffd0d6b
GM
11087 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11088 zombies (Bug#8467).
aac0c6e3 11089
04c56954
EZ
110902011-04-19 Eli Zaretskii <eliz@gnu.org>
11091
11092 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11093 gl_state.e_property when gl_state.object is Qt.
11094
11095 * insdel.c (make_gap_larger): Remove limitation of buffer size
11096 to <= INT_MAX.
11097
16a43933
CY
110982011-04-18 Chong Yidong <cyd@stupidchicken.com>
11099
11100 * xdisp.c (lookup_glyphless_char_display)
11101 (produce_glyphless_glyph): Handle cons cell entry in
11102 glyphless-char-display.
11103 (Vglyphless_char_display): Document it.
11104
11105 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11106 glyphless-char-display.
11107
4581706e
CY
111082011-04-17 Chong Yidong <cyd@stupidchicken.com>
11109
11110 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11111
11112 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11113
11114 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11115 definition for no-X builds.
11116
4887c6e2 111172011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11118
fd35b6f9
PE
11119 Static checks with GCC 4.6.0 and non-default toolkits.
11120
5c1ccb01
PE
11121 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11122
006c5daa
PE
11123 * process.c (keyboard_bit_set): Define only if SIGIO.
11124 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11125 (send_process): Repair possible setjmp clobbering.
11126
efc736d3
PE
11127 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11128
4e2fe2e6
PE
11129 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11130
f97334a2
PE
11131 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11132
4e75f29d
PE
11133 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11134 Define only if needed.
11135
90efadd1
PE
11136 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11137 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11138 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11139
3c647824
PE
11140 * dispextern.h (struct redisplay_interface): Rename param
11141 to avoid shadowing.
e264f262 11142 * termhooks.h (struct terminal): Likewise.
761383f4 11143 * xterm.c (xembed_send_message): Likewise.
3c647824 11144
b58c5c4a
PE
11145 * insdel.c (make_gap_smaller): Define only if
11146 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11147
cad59032
PE
11148 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11149 it.
11150
c339dc2e
PE
11151 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11152 so that we aren't warned about unused symbols.
11153
91a3e27b
PE
11154 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11155
399c71d3 11156 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11157
8ffc96f5
PE
11158 * xfns.c (x_real_positions): Mark locals as initialized.
11159
eef9bc79
PE
11160 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11161
098db9dd
PE
11162 * xterm.c: Fix problems found by static analysis with other toolkits.
11163 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11164 (x_dispatch_event): Declare static if USE_GTK, and
11165 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11166 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11167 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11168 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11169 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11170
eb18f6cc
PE
11171 * xmenu.c (menu_help_callback): Pointer type fixes.
11172 Use const pointers when pointing at readonly data. Avoid pointer
11173 signedness clashes.
11174 (FALSE): Remove unused macro.
11175 (update_frame_menubar): Remove unused decl.
11176
1fe72bf8
PE
11177 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11178
60d9e1db
PE
11179 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11180 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11181 (single_menu_item): Rename local to avoid shadowing.
11182
39261c26
PE
11183 * keyboard.c (make_lispy_event): Remove unused local var.
11184
018c5e19
PE
11185 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11186 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11187
63d2b86e
PE
11188 * bitmaps: Change bitmaps from unsigned char back to the X11
11189 compatible char. Avoid the old compiler warnings about
11190 out-of-range initializers by using, for example, '\xab' rather
11191 than 0xab.
11192
aefd87e1
PE
11193 * xgselect.c (xgselect_initialize): Check vs interface
11194 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11195
bf501fb9
PE
11196 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11197
e9829fdf
PE
11198 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11199 to read-only memory.
11200
1086c095
PE
11201 * fns.c (vector): Remove; this old hack is no longer needed.
11202
2baccd04 11203 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11204 Remove unused var.
dde42981 11205 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11206
72391843 11207 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11208
436c16df 11209 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11210 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11211 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11212
92bb796d 11213 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11214 (x_term_init): Remove local to avoid shadowing.
92bb796d 11215
764430a3 11216 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11217
11218 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11219 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11220
d1dfb56c
EZ
112212011-04-16 Eli Zaretskii <eliz@gnu.org>
11222
c4354cb4
EZ
11223 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11224
d1dfb56c
EZ
11225 Fix regex.c, syntax.c and friends for buffers > 2GB.
11226 * syntax.h (struct gl_state_s): Declare character position members
11227 EMACS_INT.
11228
11229 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11230
04f2d78b
CB
11231 * textprop.c (verify_interval_modification, interval_of):
11232 Declare arguments EMACS_INT.
d1dfb56c
EZ
11233
11234 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11235 EMACS_INT.
11236
11237 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11238
11239 * indent.c (Fvertical_motion): Local variable it_start is now
11240 EMACS_INT.
11241
11242 * regex.c (re_match, re_match_2, re_match_2_internal)
11243 (bcmp_translate, regcomp, regexec, print_double_string)
11244 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11245 (re_compile_pattern, re_exec): Declare arguments and local
11246 variables `size_t' and `ssize_t' and return values `regoff_t', as
11247 appropriate.
11248 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11249 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11250 <compile_stack_type>: `size' and `avail' are now `size_t'.
11251
11252 * regex.h <regoff_t>: Use ssize_t, not int.
11253 (re_search, re_search_2, re_match, re_match_2): Arguments that
11254 specify buffer/string position and length are now ssize_t and
11255 size_t. Return type is regoff_t.
11256
613052cd
BK
112572011-04-16 Ben Key <bkey76@gmail.com>
11258
11259 * nsfont.m: Fixed bugs in ns_get_family and
11260 ns_descriptor_to_entity that were caused by using free to
11261 deallocate memory blocks that were allocated by xmalloc (via
11262 xstrdup). This caused Emacs to crash when compiled with
11263 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11264 --enable-checking=xmallocoverrun). xfree is now used to
11265 deallocate these memory blocks.
11266
4170f62f 112672011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11268
71b41406
PE
11269 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11270
9587a89d
PE
11271 emacs_write: Accept and return EMACS_INT for sizes.
11272 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11273 et seq.
11274 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11275 Accept and return EMACS_INT.
11276 (emacs_gnutls_write): Return the number of bytes written on
11277 partial writes.
11278 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11279 (emacs_read, emacs_write): Remove check for negative size, as the
11280 Emacs source code has been audited now.
9587a89d
PE
11281 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11282 (emacs_read, emacs_write): Use it.
273a5f82
PE
11283 * process.c (send_process): Adjust to the new signatures of
11284 emacs_write and emacs_gnutls_write. Do not attempt to store
11285 a byte offset into an 'int'; it might overflow.
9587a89d 11286 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11287
3e047f51
PE
11288 * sound.c: Don't assume sizes fit in 'int'.
11289 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11290 Return EMACS_INT, not int.
3e047f51 11291 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11292 Accept EMACS_INT, not int.
11293 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11294 record read return values.
11295
cc39a9db
BK
112962011-04-15 Ben Key <bkey76@gmail.com>
11297
c9d0ec6d
JB
11298 * keyboard.c (Qundefined): Don't declare static since it is used
11299 in nsfns.m.
11300 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11301 static since they are used in nsfont.m.
cc39a9db 11302
6c60eb9f
SM
113032011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11304
11305 * process.c (Qprocessp): Don't declare static.
11306 * lisp.h (Qprocessp): Declare again.
11307
7990b61a
JB
113082011-04-15 Juanma Barranquero <lekktu@gmail.com>
11309
11310 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11311
5d4cb038
PE
113122011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11313
8bd7b830 11314 Improve C-level modularity by making more things 'static'.
cd64ea1d 11315
e3b27b31
PE
11316 Don't publish debugger-only interfaces to other modules.
11317 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11318 (verify_bytepos, count_markers): Move decls to the only modules
11319 that need them.
11320 * region-cache.h (pp_cache): Likewise.
11321 * window.h (check_all_windows): Likewise.
11322 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11323
5d4cb038
PE
11324 * sysdep.c (croak): Now static, if
11325 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11326 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11327
11328 * alloc.c (refill_memory_reserve): Now static if
11329 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11330 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11331
e87b6180
PE
11332 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11333 Define only if USE_LUCID.
11334
ac64929e
PE
11335 * xrdb.c (x_customization_string, x_rm_string): Now static.
11336
6f37259d
PE
11337 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11338 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11339
1683e3ab
PE
11340 * xdisp.c (draw_row_with_mouse_face): Now static.
11341 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11342
de9c2632
PE
11343 * window.h (check_all_windows): Mark externally visible.
11344
2b96acb7
PE
11345 * window.c (window_deletion_count): Now static.
11346
11347 * undo.c: Make symbols static if they're not exported.
11348 (last_undo_buffer, last_boundary_position, pending_boundary):
11349 Now static.
11350
50436f33
PE
11351 * textprop.c (interval_insert_behind_hooks): Now static.
11352 (interval_insert_in_front_hooks): Likewise.
11353
64520e5c
PE
11354 * term.c: Make symbols static if they're not exported.
11355 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11356 (max_frame_lines, tty_set_terminal_modes):
11357 (tty_reset_terminal_modes, tty_turn_off_highlight):
11358 (get_tty_terminal): Now static.
11359 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11360 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11361 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11362 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11363 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11364
1fa53021
PE
11365 * sysdep.c: Make symbols static if they're not exported.
11366 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11367 Now static.
11368 (sigprocmask_set, full_mask): Remove; unused.
11369 (wait_debugging): Mark as visible.
11370 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11371 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11372
d4b43b22
PE
11373 * syntax.c (syntax_temp): Define only if !__GNUC__.
11374
b7c513d0
PE
11375 * sound.c (current_sound_device, current_sound): Now static.
11376
989b29ad
PE
11377 * search.c (searchbufs, searchbuf_head): Now static.
11378
13a55a78
PE
11379 * scroll.c (scroll_cost): Remove; unused.
11380 * dispextern.h (scroll_cost): Remove decl.
11381
de68a1fc
PE
11382 * region-cache.h (pp_cache): Mark as externally visible.
11383
40ccffa6
PE
11384 * process.c: Make symbols static if they're not exported.
11385 (process_tick, update_tick, create_process, chan_process):
11386 (Vprocess_alist, proc_buffered_char, datagram_access):
11387 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11388 (deactivate_process): Mark defn as static, as well as decl.
11389 * lisp.h (create_process): Remove decl.
11390 * process.h (chan_process, Vprocess_alist): Remove decls.
11391
ad64fc97
PE
11392 * print.c: Make symbols static if they're not exported.
11393 (print_depth, new_backquote_output, being_printed, print_buffer):
11394 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11395 (print_interval, print_number_index, initial_stderr_stream):
11396 Now static.
11397 * lisp.h (Fprinc): Remove decl.
11398 (debug_output_compilation_hack): Mark as externally visible.
11399
adddb265
PE
11400 * sysdep.c (croak): Move decl from here to syssignal.h.
11401 * syssignal.h (croak): Put it here, so the API can be checked when
11402 'croak' is called from dissociate_if_controlling_tty.
11403
1717ede2
PE
11404 * minibuf.c: Make symbols static if they're not exported.
11405 (minibuf_save_list, choose_minibuf_frame): Now static.
11406 * lisp.h (choose_minibuf_frame): Remove decl.
11407
fa5fb2bc
PE
11408 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11409
1e3890d1
PE
11410 * lread.c: Make symbols static if they're not exported.
11411 (read_objects, initial_obarray, oblookup_last_bucket_number):
11412 Now static.
11413 (make_symbol): Remove; unused.
11414 * lisp.h (initial_obarray, make_symbol): Remove decls.
11415
8a1414fa
PE
11416 * keyboard.c: Make symbols static if they're not exported.
11417 (single_kboard, recent_keys_index, total_keys, recent_keys):
11418 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11419 (this_single_command_key_start, echoing, last_auto_save):
11420 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11421 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11422 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11423 (Vlispy_mouse_stem, double_click_count):
11424 Now static.
11425 (force_auto_save_soon): Define only if SIGDANGER.
11426 (ignore_mouse_drag_p): Now static if
11427 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11428 (print_help): Remove; unused.
11429 (stop_character, last_timer_event): Mark as externally visible.
11430 * keyboard.h (ignore_mouse_drag_p): Declare only if
11431 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11432 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11433 * lisp.h (echoing): Remove decl.
11434 (force_auto_save_soon): Declare only if SIGDANGER.
11435 * xdisp.c (redisplay_window): Simplify code, to make it more
11436 obvious that ignore_mouse_drag_p is not accessed if !defined
11437 USE_GTK && !defined HAVE_NS.
11438
93ea6e8f
PE
11439 * intervals.c: Make symbols static if they're not exported.
11440 (merge_properties_sticky, merge_interval_right, delete_interval):
11441 Now static.
11442 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11443
77382fcc
PE
11444 * insdel.c: Make symbols static if they're not exported.
11445 However, leave prepare_to_modify_buffer alone. It's never
11446 called from outside this function, but that appears to be a bug.
11447 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11448 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11449 (adjust_after_replace_noundo): Remove; unused.
11450 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11451 (signal_before_change): Remove decls.
77382fcc 11452
9306c32e
PE
11453 * indent.c (val_compute_motion, val_vmotion): Now static.
11454
cd44d2eb
PE
11455 * image.c: Make symbols static if they're not exported.
11456 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11457 if USE_GTK.
11458 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11459 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11460
ad9a7a06
PE
11461 * fringe.c (standard_bitmaps): Now static.
11462 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11463
81626931
PE
11464 * frame.c: Make symbols static if they're not exported.
11465 (x_report_frame_params, make_terminal_frame): Now static.
11466 (get_frame_param): Now static, unless HAVE_NS.
11467 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11468 (x_get_resource_string): Remove; not used.
11469 * frame.h (make_terminal_frame, x_report_frame_params):
11470 (x_get_resource_string); Remove decls.
11471 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11472 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11473
239f9db9
PE
11474 * font.c, fontset.c: Make symbols static if they're not exported.
11475 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11476 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11477 * font.c (font_close_object): Now static.
11478 * font.h (font_close_object): Remove.
11479 * fontset.c (FONTSET_OBJLIST): Remove.
11480 (free_realized_fontset) #if-0 the body, which does nothing.
11481 (face_suitable_for_char_p): #if-0, as it's never called.
11482 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11483 * xfaces.c (face_at_string_position):
11484 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11485 since 0 is always ASCII.
11486
dfcf3579
PE
11487 * fns.c (weak_hash_tables): Now static.
11488
5045092b
PE
11489 * fileio.c: Make symbols static if they're not exported.
11490 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11491 (Vwrite_region_annotation_buffers): Now static.
11492
57a96f5c
PE
11493 * eval.c: Make symbols static if they're not exported.
11494 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11495 * lisp.h (backtrace_list): Remove decl.
11496
35f08c38
PE
11497 * emacs.c: Make symbols static if they're not exported.
11498 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11499 (fatal_error_code, fatal_error_signal_hook, standard_args):
11500 Now static.
11501 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11502 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11503 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11504 * lisp.h (fatal_error_signal_hook): Remove decl.
11505 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11506
f44bd759
PE
11507 * editfns.c: Move a (normally-unused) function to its only use.
11508 * editfns.c, lisp.h (get_operating_system_release): Remove.
11509 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11510 worth the hassle of breaking this out.
11511
b532497d
PE
11512 * xterm.c: Make symbols static if they're not exported.
11513 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11514 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11515 (x_destroy_window, x_delete_display):
11516 Now static.
11517 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11518 (x_mouse_leave): Remove; unused.
11519 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11520 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11521 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11522 Remove decls.
11523 (x_mouse_leave): Declare only if WINDOWSNT.
11524 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11525 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11526 USE_X_TOOLKIT.
11527
1675728f
PE
11528 * ftxfont.c: Make symbols static if they're not exported.
11529 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11530 HAVE_FREETYPE.
11531 * font.h (ftxfont_driver): Likewise.
11532
e4cebfca
PE
11533 * xfns.c: Make symbols static if they're not exported.
11534 (x_last_font_name, x_display_info_for_name):
11535 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11536 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11537 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11538 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11539 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11540 (last_show_tip_args): Now static.
11541 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11542 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11543 (x_screen_planes): Remove; unused.
11544 * dispextern.h (x_screen_planes): Remove decl.
11545
5bf46f05
PE
11546 * dispnew.c: Make symbols static if they're not exported.
11547 * dispextern.h (redraw_garbaged_frames, scrolling):
11548 (increment_row_positions): Remove.
11549 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11550 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11551 Now static.
11552 (redraw_garbaged_frames): Remove; unused.
11553
435f4c28
PE
11554 * xfaces.c: Make symbols static if they're not exported.
11555 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11556 Remove decls.
11557 * xterm.h (defined_color): Remove decls.
11558 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11559 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11560 (menu_face_changed_default, defined_color, free_realized_face):
11561 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11562 (ascii_face_of_lisp_face): Remove; unused.
11563
8524aef3
PE
11564 * xdisp.c: Make symbols static if they're not exported.
11565 * dispextern.h (scratch_glyph_row, window_box_edges):
11566 (glyph_to_pixel_coords, set_cursor_from_row):
11567 (get_next_display_element, set_iterator_to_next):
11568 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11569 (show_mouse_face): Remove decls
11570 * frame.h (message_buf_print): Likewise.
11571 * lisp.h (pop_message, set_message, check_point_in_composition):
11572 Likewise.
11573 * xterm.h (set_vertical_scroll_bar): Likewise.
11574 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11575 (message_buf_print, scratch_glyph_row, displayed_buffer):
11576 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11577 (get_next_display_element, show_mouse_face, window_box_edges):
11578 (frame_to_window_pixel_xy, check_point_in_composition):
11579 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11580 (glyph_to_pixel_coords): Remove; unused.
11581
16390cd2
PE
11582 * dired.c (file_name_completion): Now static.
11583
11584 * dbusbind.c (xd_in_read_queued_messages): Now static.
11585
a25f4dfa
PE
11586 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11587 * data.c (circular_list_error): Remove.
11588
14a9c8df
PE
11589 * commands.h (last_point_position, last_point_position_buffer):
11590 (last_point_position_window): Remove decls.
11591 * keyboard.c: Make these variables static.
11592
04f2d78b
CB
11593 * coding.h (coding, code_convert_region, encode_coding_gap):
11594 Remove decls.
74ab6df5
PE
11595 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11596 (iso_code_class, detect_coding, code_convert_region): Now static.
11597 (encode_coding_gap): Remove; unused.
11598
38dfbee1
PE
11599 * chartab.c (chartab_chars, chartab_bits): Now static.
11600
a2cb4e63
PE
11601 * charset.h (charset_iso_8859_1): Remove decl.
11602 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11603 Now static.
11604
127198fd
PE
11605 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11606 * ccl.c (Vccl_program_table): Now static.
11607 (check_ccl_update): Remove; unused.
11608
d85b608f
PE
11609 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11610 * category.h: ... from here.
11611 * category.c (check_category_table, set_category_set): Now static.
11612
31cd66f3
PE
11613 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11614 * lisp.h: Remove these decls.
11615
c358e587
PE
11616 * buffer.c (buffer_count): Remove unused var.
11617
e78aecca
PE
11618 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11619 so that it's not optimized away.
11620 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11621 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11622 exported only to the debugger.
11623
e192d7d3 11624 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11625 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11626
92470028
PE
11627 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11628 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11629 was inaccessible from Lisp.
11630 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11631 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11632
244ed907
PE
11633 alloc.c: Import and export fewer symbols, and remove unused items.
11634 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11635 is defined.
11636 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11637 it's not optimized away by whole-program optimization.
11638 (message_enable_multibyte, free_misc): Remove.
11639 (catchlist, handlerlist, mark_backtrace):
11640 Declare only if BYTE_MARK_STACK.
11641 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11642 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11643 (message_enable_multibyte): Remove decl.
11644 (free_misc, interval_free_list, float_block, float_block_index):
11645 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11646 (cons_free_list, last_marked_index):
11647 Now static.
11648 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11649 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11650 (mark_backtrace): Define only if BYTE_MARK_STACK.
11651 * xdisp.c (message_enable_multibyte): Now static.
11652
61c2b50e 11653 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11654 This makes it easier for human readers (and static analyzers)
11655 to see whether these variables are used from other modules.
11656 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11657 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11658 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11659 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11660 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11661 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11662 * xmenu.c, xselect.c:
11663 Declare Q* vars static if they are not used in other modules.
11664 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11665 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11666 Remove decls of unexported vars.
11667 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11668
95c82688
PE
11669 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11670
16a97296
PE
11671 Make Emacs functions such as Fatom 'static' by default.
11672 This makes it easier for human readers (and static analyzers)
11673 to see whether these functions can be called from other modules.
11674 DEFUN now defines a static function. To make the function external
11675 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11676 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11677 (Finit_image_library):
16a97296
PE
11678 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11679 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11680 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11681 Remove decls, since these functions are now static.
11682 (Funintern, Fget_internal_run_time): New decls, since these functions
11683 were already external.
95c82688 11684
16a97296
PE
11685 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11686 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11687 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11688 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11689 * keyboard.c, keymap.c, lread.c:
11690 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11691 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11692 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11693 Mark functions with DEFUE instead of DEFUN,
11694 if they are used in other modules.
11695 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11696 decls for now-static functions.
11697 * buffer.h (Fdelete_overlay): Remove decl.
11698 * callproc.c (Fgetenv_internal): Mark as internal.
11699 * composite.c (Fremove_list_of_text_properties): Remove decl.
11700 (Fcomposition_get_gstring): New forward static decl.
11701 * composite.h (Fcomposite_get_gstring): Remove decl.
11702 * dired.c (Ffile_attributes): New forward static decl.
11703 * doc.c (Fdocumntation_property): New forward static decl.
11704 * eval.c (Ffetch_bytecode): New forward static decl.
11705 (Funintern): Remove extern decl; now in .h file where it belongs.
11706 * fileio.c (Fmake_symbolic_link): New forward static decl.
11707 * image.c (Finit_image_library): New forward static decl.
11708 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11709 * intervals.h (Fprevious_property_change):
11710 (Fremove_list_of_text_properties): Remove decls.
11711 * keyboard.c (Fthis_command_keys): Remove decl.
11712 (Fcommand_execute): New forward static decl.
11713 * keymap.c (Flookup_key): New forward static decl.
11714 (Fcopy_keymap): Now static.
11715 * keymap.h (Flookup_key): Remove decl.
11716 * process.c (Fget_process): New forward static decl.
11717 (Fprocess_datagram_address): Mark as internal.
11718 * syntax.c (Fsyntax_table_p): New forward static decl.
11719 (skip_chars): Remove duplicate decl.
11720 * textprop.c (Fprevious_property_change): New forward static decl.
11721 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11722 Now internal.
11723 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11724 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11725
785bbd42
PE
11726 * editfns.c (Fformat): Remove unreachable code.
11727
8b913b57
AS
117282011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11729
11730 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11731 change. (Bug#8496)
11732
a6744a35
EZ
117332011-04-13 Eli Zaretskii <eliz@gnu.org>
11734
11735 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11736 when at ZV. (Bug#8487)
11737
e7974947
AS
117382011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11739
baad03f0
AS
11740 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11741 (Bug#8437)
11742 * keyboard.c (parse_tool_bar_item): Likewise.
11743 * sound.c (sound_cleanup, alsa_close): Likewise.
11744 * termcap.c (tgetent): Likewise.
11745 * xfns.c (x_default_font_parameter): Likewise.
11746 * xsettings.c (read_and_apply_settings): Likewise.
11747
e7974947
AS
11748 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11749 (overrun_check_free): Protoize.
11750
28272684
PE
117512011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11752
11753 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11754 since callers should never pass a negative size.
11755 Change the signature to match that of plain 'read' and 'write'; see
11756 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11757 * lisp.h: Update prototypes of emacs_write and emacs_read.
11758
11997c76
EZ
117592011-04-11 Eli Zaretskii <eliz@gnu.org>
11760
11761 * xdisp.c (redisplay_window): Don't try to determine the character
11762 position of the scroll margin if the window start point w->startp
e896f03c 11763 is outside the buffer's accessible region. (Bug#8468)
11997c76 11764
8a2cbd72
EZ
117652011-04-10 Eli Zaretskii <eliz@gnu.org>
11766
11767 Fix write-region and its subroutines for buffers > 2GB.
11768 * fileio.c (a_write, e_write): Modify declaration of arguments and
11769 local variables to support buffers larger than 2GB.
11770 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11771
11772 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11773 argument, local variables, and return value.
11774
11775 * lisp.h: Update prototypes of emacs_write and emacs_read.
11776
11777 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11778
4073e537 117792011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11780
1ebfdcb6
PE
11781 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11782
b2ded58d
PE
11783 Fix more problems found by GCC 4.6.0's static checks.
11784
7d66342c
PE
11785 * xdisp.c (vmessage): Use a better test for character truncation.
11786
bbf47d44
PE
11787 * charset.c (load_charset_map): <, not <=, for optimization,
11788 and to avoid potential problems with integer overflow.
9248994d 11789 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11790 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11791 * editfns.c (Fformat): Likewise.
1e69125e 11792 * syntax.c (skip_chars): Likewise.
3befa583 11793
e3019616
PE
11794 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11795 This also lets GCC 4.6.0 generate slightly better loop code.
11796
becfa255
PE
11797 * callint.c (Fcall_interactively): <, not <=, for optimization.
11798 (Fcall_interactively): Count the number of arguments produced,
11799 not the number of arguments given. This is simpler and lets GCC
11800 4.6.0 generate slightly better code.
11801
dae0cd48
PE
11802 * ftfont.c: Distingish more carefully between FcChar8 and char.
11803 The previous code passed unsigned char * to a functions like
11804 strlen and xstrcasecmp that expect char *, which does not
11805 conform to the C standard.
11806 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11807 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11808 char * when the C standard requires it.
11809
76032d70
PE
11810 * keyboard.c (read_char): Remove unused var.
11811
eb3f1cc8
PE
11812 * eval.c: Port to Windows vsnprintf (Bug#8435).
11813 Include <limits.h>.
11814 (SIZE_MAX): Define if the headers do not.
11815 (verror): Do not give up if vsnprintf returns a negative count.
11816 Instead, grow the buffer. This ports to Windows vsnprintf, which
11817 does not conform to C99. Problem reported by Eli Zaretskii.
11818 Also, simplify the allocation scheme, by avoiding the need for
11819 calling realloc, and removing the ALLOCATED variable.
11820
70476b54
PE
11821 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11822
12020a9e
PE
11823 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11824 But keep the doprint source code for now, as we might revamp it
11825 and use it again (Bug#8435).
ea6c7ae6
PE
11826 * lisp.h (doprnt): Remove.
11827 * Makefile.in (base_obj): Remove doprnt.o.
11828 * deps.mk (doprnt.o): Remove.
11829
5fdb398c
PE
11830 error: Print 32- and 64-bit integers portably (Bug#8435).
11831 Without this change, on typical 64-bit hosts error ("...%d...", N)
11832 was used to print both 32- and 64-bit integers N, which relied on
11833 undefined behavior.
61bdb816 11834 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11835 * lisp.h (error, verror): Mark as printf-like functions.
11836 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11837 Report overflow in size calculations when allocating printf buffer.
11838 Do not truncate output string at its first null byte.
11839 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11840 Truncate the output at a character boundary, since vsnprintf does not
11841 do that.
11842 * charset.c (check_iso_charset_parameter): Convert internal
11843 character to string before calling 'error', since %c now has the
11844 printf meaning.
11845 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11846 overflow when computing char to be passed to 'error'. Do not
11847 pass Lisp_Object to 'error'; pass the integer instead.
11848 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11849 formatted with plain %d.
11850
b189fa66
PE
11851 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11852
bff87ef0
PE
11853 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11854
7e2cac20
PE
11855 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11856
ce4d90b5
PE
11857 * xterm.c (x_catch_errors): Remove duplicate declaration.
11858
266c9547
PE
11859 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11860
79c49ad2
PE
11861 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11862
368f4090
JM
118632011-04-10 Jim Meyering <meyering@redhat.com>
11864
11865 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11866 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11867 return ssize_t not "int", and use size_t as the buffer length.
11868 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11869 * gnutls.h: Update declarations.
11870 * process.c (read_process_output): Use ssize_t, to match.
11871 (send_process): Likewise.
11872
a32d4040
CY
118732011-04-09 Chong Yidong <cyd@stupidchicken.com>
11874
11875 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11876
8546720e 118772011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11878
04f2d78b
CB
11879 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11880 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11881
8546720e
GM
11882 * xterm.c (handle_one_xevent):
11883 * xmenu.c (create_and_show_popup_menu):
11884 * xselect.c (x_decline_selection_request)
11885 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11886
0a2f5c1a 118872011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11888
11889 Fix some uses of `int' instead of EMACS_INT.
11890 * search.c (string_match_1, fast_string_match)
11891 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11892 (scan_buffer, find_next_newline_no_quit)
11893 (find_before_next_newline, search_command, Freplace_match)
11894 (Fmatch_data): Make some `int' variables be EMACS_INT.
11895
11896 * xdisp.c (display_count_lines): 3rd argument and return value now
11897 EMACS_INT. All callers changed.
11898 (pint2hrstr): Last argument is now EMACS_INT.
11899
11900 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11901 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11902 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11903 (decode_coding_utf_16, decode_coding_emacs_mule)
11904 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11905 (decode_coding_ccl, decode_coding_charset)
11906 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11907 (decode_coding_iso_2022, decode_coding_emacs_mule)
11908 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11909 <char_offset, last_offset>: Declare EMACS_INT.
11910 (encode_coding_utf_8, encode_coding_utf_16)
11911 (encode_coding_emacs_mule, encode_invocation_designation)
11912 (encode_designation_at_bol, encode_coding_iso_2022)
11913 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11914 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11915 Declare EMACS_INT.
11916 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11917 (encode_invocation_designation): Last argument P_NCHARS is now
11918 EMACS_INT.
11919 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11920 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11921
11922 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11923 All users changed.
11924
11925 * ccl.c (Fccl_execute_on_string): Declare some variables
11926 EMACS_INT.
11927
8546720e 119282011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11929
11930 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11931
4e19a977
CS
119322011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11933
11934 * process.c (Fformat_network_address): Doc fix.
11935
87302331
R
119362011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11937
ee7683eb 11938 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11939
cbb59342
CY
119402011-04-08 Chong Yidong <cyd@stupidchicken.com>
11941
11942 * keyboard.c (read_char): Call Lisp function help-form-show,
11943 instead of using internal_with_output_to_temp_buffer.
11944 (Qhelp_form_show): New var.
e0d38eeb 11945 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11946
11947 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11948
11949 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11950
e67a13ab
CY
119512011-04-06 Chong Yidong <cyd@stupidchicken.com>
11952
04f2d78b
CB
11953 * process.c (Flist_processes): Remove to Lisp.
11954 (list_processes_1): Delete.
e67a13ab 11955
973f782d
EZ
119562011-04-06 Eli Zaretskii <eliz@gnu.org>
11957
7c106b1e
EZ
11958 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11959
973f782d
EZ
11960 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11961
41cf7d1a 119622011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11963
ca23cc88
PE
11964 Fix more problems found by GCC 4.6.0's static checks.
11965
f390e2d5
PE
11966 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11967
42eea0d0
PE
11968 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11969
b69769da 11970 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11971
f9541e84
PE
11972 * xdisp.c (vmessage): Mark as a printf-like function.
11973
13841b55
PE
11974 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11975
c136c10f
PE
11976 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11977
5e2d4a30
PE
11978 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11979 printf-like functions.
11980 (tiff_load): Add casts to remove these marks before passing them
11981 to system-supplied API.
11982
583f48b9
PE
11983 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11984
b25d760e
PE
11985 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11986 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11987 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11988 directly, rather than having caller test rule sign. This avoids
11989 some unnecessary tests.
11990 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11991 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11992 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11993
bc7b6697 11994 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11995 (xfont_open): Avoid unnecessary tests.
bc7b6697 11996
27ccc379
PE
11997 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11998
dcd5c89a
PE
11999 * composite.h, composite.c (composition_gstring_put_cache):
12000 Use EMACS_INT, not int, for length.
12001
b13a45c6
PE
12002 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12003 breaking out part of COMPOSITION_DECODE_RULE.
12004 (COMPOSITION_DECODE_RULE): Use it.
12005 * composite.c (get_composition_id): Remove unused local vars,
12006 by using the new macro.
12007
1e792e4d
PE
12008 * textprop.c (set_text_properties_1): Change while to do-while,
12009 since the condition is always true at first.
12010
dc6c6455 12011 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12012 (interval_deletion_adjustment): Return unsigned value.
12013 All uses changed.
dc6c6455 12014
aba7731a
PE
12015 * process.c (list_processes_1, create_pty, read_process_output):
12016 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12017 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12018 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12019 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12020 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12021
fdfc4bf3
PE
12022 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12023
fca8fe46 12024 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12025 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12026
06a0259a 12027 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12028 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12029 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12030
e7b9e80f
PE
12031 * print.c (print_error_message): Avoid int overflow.
12032
56201685
PE
12033 * font.c (font_list_entities): Redo for clarity,
12034 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12035
78834453 12036 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12037 (font_score): Avoid potential overflow in diff calculation.
78834453 12038
0bc0b309 12039 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12040 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12041
e610eaca
PE
12042 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12043
b895abce
PE
12044 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12045 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12046 can always succeed if overflow has undefined behavior.
12047
1f1d9321 12048 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12049 (wordify): Omit three unnecessary tests.
1f1d9321 12050
c59478bc
PE
12051 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12052 All callers changed. This avoids the need for an unused var.
12053
79b73827
PE
12054 * casefiddle.c (casify_region): Remove var that is set but not used.
12055
a4db5dfe
PE
12056 * dired.c (file_name_completion): Remove var that is set but not used.
12057
43aae36e
PE
12058 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12059
2a47c44d 12060 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12061 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12062
a37c69bf
PE
12063 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12064 Check for integer overflow on size calculations.
12065
328ab8e7
PE
12066 * buffer.c (Fprevious_overlay_change): Remove var that is set
12067 but not used.
12068
e5a2a5cb
PE
12069 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12070 Remove vars that are set but not used.
8d84a6eb 12071 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12072 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12073
a60e5f68
PE
12074 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12075
f661cb61 12076 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12077 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12078
f0397f5a
PE
12079 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12080 that are set but not used.
12081
8664db06 12082 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12083 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12084
6abdaa4a
PE
12085 * xselect.c (x_get_local_selection, x_handle_property_notify):
12086 Remove vars that are set but not used.
12087
0ce7538d 12088 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12089 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12090
9ae848fc
PE
12091 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12092 Remove var that is set but not used.
0b918413
PE
12093 (scroll_bar_windows_size): Now size_t, not int.
12094 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12095 Check for overflow.
9ae848fc 12096
a5a62657
PE
12097 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12098 (map_tty_color) [!defined MSDOS]: Likewise.
12099
5c5cdd39
PE
12100 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12101
66ebf983
PE
12102 * coding.c: Remove vars that are set but not used.
12103 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12104 All callers changed.
12105 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12106 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12107 (decode_coding_charset): Remove vars that are set but not used.
12108
1be4d761
PE
12109 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12110 that is set but not used.
12111
47553fa8
PE
12112 * print.c (print_object): Remove var that is set but not used.
12113
1f7196bf 12114 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12115 The gnulib version avoids calling malloc in the usual case,
12116 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12117 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12118 * filelock.c (current_lock_owner): Likewise.
12119 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12120 * sysdep.c: Include allocator.h, careadlinkat.h.
12121 (emacs_no_realloc_allocator): New static constant.
12122 (emacs_readlink): New function.
fdb61804
PE
12123 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12124 ../lib/careadlinkat.h.
d1fdcab7 12125
f84c17c7
SM
121262011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12127
12128 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12129 first non-nil return value).
12130
ef3862ad
JD
121312011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12132
12133 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12134 if not defined (Bug#8403).
12135
376a7006
JB
121362011-04-02 Juanma Barranquero <lekktu@gmail.com>
12137
12138 * xdisp.c (display_count_lines): Remove parameter `start',
12139 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12140 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12141 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12142 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12143 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12144 and thereabouts. All callers changed.
12145 (get_per_char_metric): Remove parameter `f', unused since
12146 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12147
6ca3801d
JM
121482011-04-02 Jim Meyering <meyering@redhat.com>
12149
12150 do not dereference NULL upon failed strdup
12151 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12152 (ns_get_family): Likewise.
12153
d8e2b5ba
JB
121542011-04-02 Juanma Barranquero <lekktu@gmail.com>
12155
12156 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12157
8c74fcbd
JD
121582011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12159
12160 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12161 later (Bug#8403).
12162
7200d79c
SM
121632011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12164
03408648 12165 Add lexical binding.
7200d79c 12166
03408648
SM
12167 * window.c (Ftemp_output_buffer_show): New fun.
12168 (Fsave_window_excursion):
12169 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12170
12171 * lread.c (lisp_file_lexically_bound_p): New function.
12172 (Fload): Bind Qlexical_binding.
12173 (readevalloop): Remove `evalfun' arg.
12174 Bind Qinternal_interpreter_environment.
12175 (Feval_buffer): Bind Qlexical_binding.
12176 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12177 Mark as dynamic.
12178 (syms_of_lread): Declare `lexical-binding'.
12179
12180 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12181
12182 * keyboard.c (eval_dyn): New fun.
12183 (menu_item_eval_property): Use it.
ca105506
SM
12184
12185 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12186
03408648
SM
12187 * fns.c (concat, mapcar1): Accept byte-code-functions.
12188
12189 * eval.c (Fsetq): Handle lexical vars.
12190 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12191 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12192 (FletX, Flet): Obey lexical binding.
12193 (Fcommandp): Handle closures.
12194 (Feval): New `lexical' arg.
12195 (eval_sub): New function extracted from Feval. Use it almost
12196 everywhere where Feval was used. Look up vars in lexical env.
12197 Handle closures.
12198 (Ffunctionp): Move from subr.el.
12199 (Ffuncall): Handle closures.
12200 (apply_lambda): Remove `eval_flags'.
12201 (funcall_lambda): Handle closures and new byte-code-functions.
12202 (Fspecial_variable_p): New function.
12203 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12204 but without exporting it to Lisp.
23aba0ea 12205
23aba0ea 12206 * doc.c (Fdocumentation, store_function_docstring):
03408648 12207 * data.c (Finteractive_form): Handle closures.
23aba0ea 12208
03408648
SM
12209 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12210 interactive spec.
ba83908c 12211
04f2d78b
CB
12212 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12213 New byte-codes.
03408648
SM
12214 (exec_byte_code): New function extracted from Fbyte_code to handle new
12215 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12216
03408648 12217 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12218
03408648 12219 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12220
e2abce01
JB
122212011-03-31 Juanma Barranquero <lekktu@gmail.com>
12222
12223 * xdisp.c (redisplay_internal): Fix prototype.
12224
63696a73 122252011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12226
63696a73 12227 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12228 (try_scrolling): Use it when setting scroll_limit.
12229 Limit scrolling to 100 screen lines.
63696a73
EZ
12230 (redisplay_window): Even when falling back on "recentering",
12231 position point in the window according to scroll-conservatively,
12232 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12233
12234 (try_scrolling): When point is above the window, allow searching
12235 as far as scroll_max, or one screenful, to compute vertical
12236 distance from PT to the scroll margin position. This prevents
12237 try_scrolling from unnecessarily failing when
12238 scroll-conservatively is set to a value slightly larger than the
12239 window height. Clean up the case of PT below the margin at bottom
12240 of window: scroll_max can no longer be INT_MAX. When aggressive
12241 scrolling is in use, don't let point enter the opposite scroll
12242 margin as result of the scroll.
12243 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12244 threshold of 100 lines for never-recentering scrolling.
12245
e4cc2dfc
JB
122462011-03-31 Juanma Barranquero <lekktu@gmail.com>
12247
12248 * dispextern.h (move_it_by_lines):
12249 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12250 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12251 (message_log_check_duplicate): Remove parameters `prev_bol' and
12252 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12253 (redisplay_internal): Remove parameter `preserve_echo_area',
12254 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12255
12256 * indent.c (Fvertical_motion):
12257 * window.c (window_scroll_pixel_based, Frecenter):
12258 Don't pass `need_y_p' to `move_it_by_lines'.
12259
1c470562
SM
122602011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12261
44f230aa
SM
12262 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12263 steal a few bits to be more compact.
12264 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12265 Remove unneeded casts.
12266
1c470562
SM
12267 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12268
888adce9
ZK
122692011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12270
12271 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12272 binding" message (bug#7967).
12273
f838ed7b
PE
122742011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12275
77861b95
PE
12276 Fix more problems found by GCC 4.6.0's static checks.
12277
de6dbc14
PE
12278 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12279 Remove unused local var.
12280
f838ed7b
PE
12281 * editfns.c (Fmessage_box): Remove unused local var.
12282
792c7b2b
PE
12283 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12284 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12285 Omit unused local vars.
c499e557 12286 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12287 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12288 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12289 Omit unused local var.
12290
ba0165e1
PE
12291 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12292 Don't assume string length fits in int.
32ad8845 12293 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12294 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12295
3c59b4c9
PE
12296 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12297 instead of alloca (Bug#8344).
12298
a3eed478 12299 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12300 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12301
eb4d412d
PE
12302 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12303
1658b401
PE
12304 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12305 concerns.
12306
12307 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12308
12309 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12310
9a2c6e05
PE
12311 * keyboard.c (syms_of_keyboard): Use the same style as later
12312 in this function when indexing through an array. This also
12313 works around GCC bug 48267.
12314
03d0a109
PE
12315 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12316
44f730c8
PE
12317 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12318
fe75f926
PE
12319 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12320 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12321
ffa8c828
PE
12322 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12323 This avoids undefined behavior on integer overflow, and is a bit
12324 more convenient anyway since it is compared to a size_t variable.
12325
c5101a77
PE
12326 Variadic C functions now count arguments with size_t, not int.
12327 This avoids an unnecessary limitation on 64-bit machines, which
12328 caused (substring ...) to crash on large vectors (Bug#8344).
12329 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12330 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12331 All variadic functions and their callers changed accordingly.
c5101a77
PE
12332 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12333 * data.c (arith_driver, float_arith_driver): Likewise.
12334 * editfns.c (general_insert_function): Likewise.
12335 * eval.c (struct backtrace.nargs, interactive_p)
12336 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12337 (funcall_lambda, mark_backtrace): Likewise.
12338 * fns.c (concat): Likewise.
12339 * frame.c (x_set_frame_parameters): Likewise.
12340 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12341 0 if not found, not -1. All callers changed.
12342
dd3f25f7
PE
12343 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12344 (stack_copy_size): Now size_t, not int.
12345 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12346
461c2ab9
JB
123472011-03-28 Juanma Barranquero <lekktu@gmail.com>
12348
12349 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12350 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12351 All callers changed.
12352
12353 * lisp.h (multibyte_char_to_unibyte):
12354 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12355 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12356 * character.h (CHAR_TO_BYTE8):
12357 * cmds.c (internal_self_insert):
12358 * editfns.c (general_insert_function):
12359 * keymap.c (push_key_description):
12360 * search.c (Freplace_match):
12361 * xdisp.c (message_dolog, set_message_1): All callers changed.
12362
f6d62986
SM
123632011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12364
12365 * keyboard.c (safe_run_hook_funcall): New function.
12366 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12367 don't set the hook to nil, but remove the offending function instead.
12368 (Qcommand_hook_internal): Remove, unused.
12369 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12370 Vcommand_hook_internal.
12371
12372 * eval.c (enum run_hooks_condition): Remove.
12373 (funcall_nil, funcall_not): New functions.
12374 (run_hook_with_args): Call each function through a `funcall' argument.
12375 Remove `cond' argument, now redundant.
12376 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12377 (Frun_hook_with_args_until_failure): Adjust accordingly.
12378 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12379
1db5b1ad
JB
123802011-03-28 Juanma Barranquero <lekktu@gmail.com>
12381
12382 * dispextern.h (string_buffer_position): Remove declaration.
12383
12384 * print.c (strout): Remove parameter `multibyte', unused since
12385 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12386
12387 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12388 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12389 All callers changed.
12390
12391 * w32.c (_wsa_errlist): Use braces for struct initializers.
12392
12393 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12394 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12395 All callers changed.
12396 (string_buffer_position): Likewise. Also, make static (it's never
12397 used outside xdisp.c).
12398 (cursor_row_p): Remove parameter `w', unused since
12399 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12400 (decode_mode_spec): Remove parameter `precision', introduced during
12401 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12402 All callers changed.
12403
5ffb62aa
JD
124042011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12405
12406 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12407
461c2ab9 124082011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12409
12410 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12411 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12412 (ns_update_auto_hide_menu_bar): New functions.
12413 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12414 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12415 ns_constrain_all_frames.
12416 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12417 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12418
5c380ffb
JD
124192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12420
12421 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12422
9af30bdf
GM
124232011-03-27 Glenn Morris <rgm@gnu.org>
12424
12425 * syssignal.h: Replace RETSIGTYPE with void.
12426 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12427 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12428 Replace SIGTYPE with void everywhere.
12429 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12430 * s/template.h (SIGTYPE): Remove commented out definition.
12431
e2abce01
JB
124322011-03-26 Eli Zaretskii <eliz@gnu.org>
12433
12434 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12435 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12436
f868cd8a
JB
124372011-03-26 Juanma Barranquero <lekktu@gmail.com>
12438
59eb0929
JB
12439 * w32.c (read_unc_volume): Use parameter `henum', instead of
12440 global variable `wget_enum_handle'.
12441
12442 * keymap.c (describe_vector): Remove parameters `indices' and
12443 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12444 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12445
f868cd8a
JB
12446 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12447
12448 * keyboard.c (timer_check): Remove parameter `do_it_now',
12449 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12450 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12451 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12452
12453 * keyboard.c (read_char):
12454 * w32menu.c (w32_menu_display_help):
12455 * xmenu.c (show_help_event, menu_help_callback):
12456 Adjust calls to `show_help_echo'.
12457
12458 * gtkutil.c (xg_maybe_add_timer):
12459 * keyboard.c (readable_events):
12460 * process.c (wait_reading_process_output):
12461 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12462
12463 * insdel.c (adjust_markers_gap_motion):
12464 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12465 (gap_left, gap_right): Don't call it.
12466
2ecf6fdb
CY
124672011-03-25 Chong Yidong <cyd@stupidchicken.com>
12468
12469 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12470 incurred during fontification.
12471
6b1f9ba4
JB
124722011-03-25 Juanma Barranquero <lekktu@gmail.com>
12473
12474 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12475 (DEFVAR_PER_BUFFER): Don't pass it.
12476
12477 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12478 (scrolling_window): Don't pass it.
12479
0f4a96b5
JB
124802011-03-25 Juanma Barranquero <lekktu@gmail.com>
12481
12482 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12483
12484 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12485 and `suffix'.
12486 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12487 of variables specific to SELinux and computation of `encoded_absname'.
12488
12489 * image.c (XPutPixel): Remove unused variable `height'.
12490
12491 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12492
12493 * unexw32.c (get_section_info): Remove unused variable `section'.
12494
12495 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12496 (system_process_attributes): Remove unused variable `sess'.
12497 (sys_read): Remove unused variable `err'.
12498
12499 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12500 (w32_wnd_proc): Remove unused variable `isdead'.
12501 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12502 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12503 (x_create_tip_frame): Remove unused variable `tem'.
12504
12505 * w32inevt.c (w32_console_read_socket):
12506 Remove unused variable `no_events'.
12507
12508 * w32term.c (x_draw_composite_glyph_string_foreground):
12509 Remove unused variable `width'.
12510
1149507c
JB
125112011-03-24 Juanma Barranquero <lekktu@gmail.com>
12512
12513 * w32term.c (x_set_glyph_string_clipping):
12514 Don't pass uninitialized region to CombineRgn.
12515
9c88f339
JB
125162011-03-23 Juanma Barranquero <lekktu@gmail.com>
12517
12518 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12519 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12520 (Fx_close_connection): Remove unused variable `i'.
12521
12522 * w32font.c (w32font_draw): Return number of glyphs.
12523 (w32font_open_internal): Remove unused variable `i'.
12524 (w32font_driver): Add missing initializer.
12525
12526 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12527 (fill_in_menu): Remove unused variable `items_added'.
12528
12529 * w32term.c (last_mouse_press_frame): Remove static global variable.
12530 (w32_clip_to_row): Remove unused variable `f'.
12531 (x_delete_terminal): Remove unused variable `i'.
12532
12533 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12534 (NOTHING): Remove unused static global variable.
12535 (uniscribe_check_otf): Remove unused variable `table'.
12536 (uniscribe_font_driver): Add missing initializers.
12537
dee091a3
JD
125382011-03-23 Julien Danjou <julien@danjou.info>
12539
12540 * term.c (Fsuspend_tty, Fresume_tty):
12541 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12542 * window.c (temp_output_buffer_show):
12543 * insdel.c (signal_before_change):
12544 * frame.c (Fhandle_switch_frame):
12545 * fileio.c (Fdo_auto_save):
12546 * emacs.c (Fkill_emacs):
12547 * editfns.c (save_excursion_restore):
12548 * cmds.c (internal_self_insert):
12549 * callint.c (Fcall_interactively):
12550 * buffer.c (Fkill_all_local_variables):
12551 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12552 Use Frun_hooks.
0f4a96b5 12553 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12554 unconditionally since it does the check itself.
dee091a3 12555
2c520ab5 125562011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12557
c9c49752
PE
12558 Fix more problems found by GCC 4.5.2's static checks.
12559
8abc3f12
PE
12560 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12561 the first time through the loop, since we know p0 < p1 then.
12562 This also avoids a gcc -Wstrict-overflow warning.
12563
a2d26660
PE
12564 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12565 leading to a memory leak, possible in functions like
12566 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12567 of objects (Bug#8318).
a2d26660 12568
916c72e9
PE
12569 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12570 that could (at least in theory) be that large.
12571
19ab8a18
PE
12572 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12573 This is less likely to overflow, and avoids undefined behavior if
12574 overflow does occur. All callers changed. Use strtoul to scan
12575 for the unsigned long integer.
b7cbbd6f
PE
12576 (pint2hrstr): Simplify and tune code slightly.
12577 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12578
f0641eff
PE
12579 * scroll.c (do_scrolling): Work around GCC bug 48228.
12580 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12581
7f650bb9
PE
12582 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12583 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12584 (validate_x_resource_name): Simplify count usage.
12585 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12586
37dd57d1
PE
12587 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12588 fail (Bug#8306).
81e56e61 12589
699979fc 12590 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12591
401bf9b4
PE
12592 * process.c (Fmake_network_process): Use socklen_t, not int,
12593 where POSIX says socklen_t is required in portable programs.
12594 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12595 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12596 (Fmake_network_process, server_accept_connection):
12597 (wait_reading_process_output, read_process_output):
12598 Likewise.
12599
b93aacde
PE
12600 * process.c: Rename or move locals to avoid shadowing.
12601 (list_processes_1, Fmake_network_process):
12602 (read_process_output_error_handler, exec_sentinel_error_handler):
12603 Rename or move locals.
4dc343ee 12604 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12605 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12606 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12607 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12608 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12609
af8a867c 12610 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12611 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12612 Include tparam.h instead, since it declares them.
af8a867c
PE
12613 * cm.h (PC): Remove extern decl; tparam.h now does this.
12614 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12615 * terminfo.c: Include tparam.h, to check interfaces.
12616 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12617 (tparam): Adjust signature to match interface in tparam.h;
12618 this removes some undefined behavior. Check that outstring and len
12619 are zero, which they always are with Emacs.
12620 * tparam.h (PC, BC, UP): New extern decls.
12621
0248044d 12622 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12623 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12624
8ff096c1 12625 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12626 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12627 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12628 (ftfont_list): Remove unused local.
49eaafba
PE
12629 (get_adstyle_property, ftfont_pattern_entity):
12630 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12631 Rename locals to avoid shadowing.
8ff096c1 12632
e2be39f6
PE
12633 * xfont.c (xfont_list_family): Mark var as initialized.
12634
c9735e30
PE
12635 * xml.c (make_dom): Now static.
12636
8f5201ae
PE
12637 * composite.c (composition_compute_stop_pos): Rename local to
12638 avoid shadowing.
b246f932
PE
12639 (composition_reseat_it): Remove unused locals.
12640 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12641 (composition_update_it): Mark var as initialized.
11b61122
PE
12642 (find_automatic_composition): Mark vars as initialized,
12643 with a FIXME (Bug#8290).
8f5201ae 12644
760fbc2c
PE
12645 character.h: Rename locals to avoid shadowing.
12646 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12647 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12648 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12649 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12650 to avoid shadowing.
12651
ff08eb85
PE
12652 * textprop.c (property_change_between_p): Remove; unused.
12653
fc7bf025
PE
12654 * intervals.c (interval_start_pos): Now static.
12655
235d7abc
PE
12656 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12657
44f230aa
SM
12658 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12659 Rename locals to avoid shadowing.
3e7d6594 12660
50060332
PE
12661 * sound.c (wav_play, au_play, Fplay_sound_internal):
12662 Fix pointer signedness.
d01f234b 12663 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12664 (wav_play): Initialize a variable to 0, to prevent undefined
12665 behavior (Bug#8278).
50060332 12666
c4fc4e30
PE
12667 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12668
918436ed
PE
12669 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12670
c939f91b
PE
12671 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12672 clobbering (Bug#8298).
b9c7f648
PE
12673 * sysdep.c (sys_subshell): Likewise.
12674 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12675
6bd8c144
PE
12676 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12677 This should get cleaned up, so that child_setup has the
12678 same signature on all platforms.
12679
7710357c 12680 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12681 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12682
c59da222
CY
126832011-03-22 Chong Yidong <cyd@stupidchicken.com>
12684
12685 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12686 not to be necessary, and produces flickering.
12687
66b87493
GM
126882011-03-20 Glenn Morris <rgm@gnu.org>
12689
12690 * config.in: Remove file.
12691
45b6f6d5
JB
126922011-03-20 Juanma Barranquero <lekktu@gmail.com>
12693
12694 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12695 are now in src/globals.h.
12696 (syms_of_minibuf): Remove spurious & from previous change.
12697
cd394be1 126982011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12699
12700 * minibuf.c (completing-read-function): New variable.
12701 (completing-read-default): Rename from completing-read.
12702 (completing-read): Call completing-read-function.
12703
b14e3e21
CY
127042011-03-19 Juanma Barranquero <lekktu@gmail.com>
12705
12706 * xfaces.c (Fx_load_color_file):
12707 Read color file from absolute filename (bug#8250).
12708
f2b726e6
JB
127092011-03-19 Juanma Barranquero <lekktu@gmail.com>
12710
12711 * makefile.w32-in: Update dependencies.
12712
09f6ff02
EZ
127132011-03-17 Eli Zaretskii <eliz@gnu.org>
12714
12715 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12716
29a6015a
PE
127172011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12718
a3a6c54e
PE
12719 Fix more problems found by GCC 4.5.2's static checks.
12720
b766f867
PE
12721 * process.c (make_serial_process_unwind, send_process_trap):
12722 (sigchld_handler): Now static.
12723
be02381c
PE
12724 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12725 That way, the code declares only the vars that it needs.
12726 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12727 * s/cygwin.h (PTY_ITERATION): Likewise.
12728 * s/darwin.h (PTY_ITERATION): Likewise.
12729 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12730
57048744
PE
12731 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12732 * process.c (allocate_pty): Don't declare stb unless it's needed.
12733
7914961c 12734 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12735 (CONSTANTLIM): Remove; unused.
12736 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12737 Define only if needed.
7914961c 12738
b3967b18
PE
12739 * unexelf.c (unexec): Name an expression,
12740 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12741 Use a different way to cause a compilation error if anyone uses
12742 n rather than nn, a way that does not involve shadowing.
73366a00 12743 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12744
29a6015a
PE
12745 * deps.mk (unexalpha.o): Remove; unused.
12746
43cfc33e 12747 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12748 * unexec.h: New file.
ce701a33
PE
12749 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12750 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12751 Depend on unexec.h.
12752 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12753 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12754 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12755 Change as necessary to match prototype in unexec.h.
ce701a33 12756
01f44d5a
PE
12757 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12758 shadowing.
4f63c6bb 12759 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12760
a6670b0b
PE
12761 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12762 Rename locals to avoid shadowing.
12763
cef2010d 12764 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12765 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12766
d4d7173a
PE
12767 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12768
f08b802a
PE
12769 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12770 warning when compiling print.c.
12771
3ddb0639
PE
12772 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12773 instead of using an uninitialized var.
5ad03b97 12774 (font_sort_entities): Mark var as initialized.
3ddb0639 12775
170a2692
PE
12776 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12777
e663c700
PE
12778 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12779 pointers to constants.
89bc529a 12780 (font_parse_fcname): Remove unused vars.
7b81e2d0 12781 (font_delete_unmatched): Now static.
ea838e10 12782 (font_get_spec): Remove; unused.
13a547c6
PE
12783 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12784 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12785 Rename or move locals to avoid shadowing.
e663c700 12786
2a80c887 12787 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12788 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12789
1384fa33 12790 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12791 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12792
8b2c52e9
PE
12793 * alloc.c (mark_backtrace): Move decl from here ...
12794 * lisp.h: ... to here, so that it can be checked.
12795
475545b5 12796 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12797 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12798 (lisp_indirect_variable): Name an expression,
12799 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12800 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12801
b1349114 12802 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12803 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12804 Use const pointer when appropriate.
b1349114 12805
a2928364
PE
12806 * lisp.h (get_system_name, get_operating_system_release):
12807 Move decls here, to check interfaces.
12808 * process.c (get_operating_system_release): Move decl to lisp.h.
12809 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12810 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12811 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12812 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12813 (Fformat_time_string, Fencode_time, Finsert_char):
12814 (Ftranslate_region_internal, Fformat):
12815 Rename or remove local vars to avoid shadowing.
9710023e 12816 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12817
a415e694
PE
12818 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12819 avoid shadowing.
12820
8ef4622d
PE
12821 * lisp.h (eassert): Check that the argument compiles, even if
12822 ENABLE_CHECKING is not defined.
12823
946f9a5b
PE
12824 * data.c (Findirect_variable): Name an expression, to avoid
12825 gcc -Wbad-function-cast warning.
112396d6 12826 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12827 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12828 (Fmake_variable_buffer_local, Fmake_local_variable):
12829 Mark variables as initialized.
52746918 12830 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12831
e5aab7e7 12832 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12833 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12834 Rename locals to avoid shadowing.
dff45157
PE
12835 (mark_stack): Move local variables into the #ifdef region where
12836 they're used.
7bc26fdb
PE
12837 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12838 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12839 needed otherwise.
12840 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12841 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12842 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12843
e5aab7e7
PE
12844 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12845 avoids undefined behavior in theory.
12846
4da60324
PE
12847 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12848
88043301
PE
12849 Use functions, not macros, for up- and down-casing (Bug#8254).
12850 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12851 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12852 to use the following functions instead of these macros.
12853 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12854 EMACS_INT, since callers assume the returned value fits in int.
12855 (upcase1): Likewise, for UPCASE_TABLE.
12856 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12857 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12858 the race-condition problem in the old DOWNCASE.
88043301 12859
19ed5445
PE
12860 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12861 Rename locals to avoid shadowing.
12862 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12863 (regex_compile, re_search_2, re_match_2_internal):
12864 Remove unused local vars.
952db0d7
PE
12865 (FREE_VAR): Rewrite so as not to use empty "else",
12866 which gcc can warn about.
da053e48 12867 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12868 (RETALLOC_IF): Define only if needed.
12869 (WORDCHAR_P): Likewise. This one is never needed, but is used
12870 only in a comment talking about a compiler bug, so put inside
12871 the #if 0 of that comment.
12872 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12873 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12874 Remove; unused.
19ed5445 12875
1f3561e4 12876 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12877 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12878 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12879
ded6f8f7
PE
12880 * search.c (simple_search): Remove unused var.
12881
dbd37a95
PE
12882 * dired.c (compile_pattern): Move decl from here ...
12883 * lisp.h: ... to here, so that it can be checked.
12884 (struct re_registers): New forward decl.
12885
7e47afad
PE
12886 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12887
85f24f61
PE
12888 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12889 All uses changed.
12890 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12891 Rename locals to avoid shadowing.
5671df8f 12892 (Fvertical_motion): Mark locals as initialized.
85f24f61 12893
181aa2be 12894 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12895 (casify_region): Mark local as initialized.
181aa2be 12896
930d429c
PE
12897 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12898
7082eac6
PE
12899 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12900 New macros, so that the caller can use some names other than
12901 gcpro1, gcpro2, etc.
12902 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12903 of the new macros.
12904 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12905 argument, for consistency with GCPRO2_VAR, etc: it is now the
12906 prefix of the variable, not the variable itself. All uses
12907 changed.
38b2c076
PE
12908 * dired.c (directory_files_internal, file_name_completion):
12909 Rename locals to avoid shadowing.
12910
15206ed9
PE
12911 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12912 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12913 dired.c's scmp function, had undefined behavior.
12914 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12915 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12916 * buffer.h: ... to here, because these macros use current_buffer,
12917 and the new implementation with inline functions needs to have
12918 current_buffer in scope now, rather than later when the macros
12919 are used.
12920 (downcase, upcase1): New static inline functions.
12921 (DOWNCASE, UPCASE1): Reimplement using these functions.
12922 This avoids undefined behavior in expressions like
12923 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12924 from race conditions in accessing the global variables
12925 case_temp1 and case_temp2.
12926 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12927 * lisp.h (case_temp1, case_temp2): Remove their decls.
12928 * character.h (ASCII_CHAR_P): Move from here ...
12929 * lisp.h: ... to here, so that the inline functions mentioned
12930 above can use them.
12931
4a6bea26
PE
12932 * dired.c (directory_files_internal_unwind): Now static.
12933
f14b7e14
PE
12934 * fileio.c (file_name_as_directory, directory_file_name):
12935 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12936 Now static.
2893f146
PE
12937 (file_name_as_directory): Use const pointers when appropriate.
12938 (Fexpand_file_name): Likewise. In particular, newdir might
12939 point at constant storage, so make it a const pointer.
fd4ead52 12940 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12941 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12942 signedness issues.
f839df0c
PE
12943 (Fset_file_times, Finsert_file_contents, auto_save_error):
12944 Rename locals to avoid shadowing.
f14b7e14 12945
5716756e 12946 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12947 (Ftry_completion, Fall_completions): Rename or remove locals
12948 to avoid shadowing.
5716756e 12949
b4c3046a
PE
12950 * marker.c (bytepos_to_charpos): Remove; unused.
12951
b45db522
PE
12952 * lisp.h (verify_bytepos, count_markers): New decls,
12953 so that gcc does not warn that these functions aren't declared.
12954
85876d07
PE
12955 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12956 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12957 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12958 (copy_text): Remove unused local var.
85876d07 12959
03d78a21 12960 * filelock.c (within_one_second): Now static.
b3dd38ab 12961 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12962
5df8f01b
PE
12963 * buffer.c (fix_overlays_before): Mark locals as initialized.
12964 (fix_start_end_in_overlays): Likewise. This function should be
12965 simplified by using pointers-to-pointers, but that's a different
12966 matter.
b1d876f1 12967 (switch_to_buffer_1): Now static.
8f54f30a
PE
12968 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12969 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12970
a70072c9 12971 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12972 Fix pointer signedness issue.
edced198
PE
12973 (sys_subshell): Mark local as volatile if checking for lint,
12974 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12975 (MAXPATHLEN): Define only if needed.
a70072c9 12976
a0977c44
PE
12977 * process.c (serial_open, serial_configure): Move decls from here ...
12978 * systty.h: ... to here, so that they can be checked.
12979
a884fdcc
PE
12980 * fns.c (get_random, seed_random): Move extern decls from here ...
12981 * lisp.h: ... to here, so that they can be checked.
12982
604efe86 12983 * sysdep.c (reset_io): Now static.
b8950c94 12984 (wait_for_termination_signal): Remove; unused.
604efe86 12985
38fc62d9
PE
12986 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12987 (copy_keymap_item, append_key, push_text_char_description):
12988 Now static.
1004a21a 12989 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12990 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12991 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12992 (describe_map_tree):
12993 Rename locals to avoid shadowing.
38fc62d9 12994
2f2650da
PE
12995 * keyboard.c: Declare functions static if they are not used elsewhere.
12996 (echo_char, echo_dash, cmd_error, top_level_2):
12997 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12998 (read_char, kbd_buffer_get_event, make_lispy_position):
12999 (make_lispy_event, make_lispy_movement, apply_modifiers):
13000 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13001 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13002 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13003 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13004 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13005
a053e86c 13006 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13007 (mark_kboards): Move decl here ...
13008 * alloc.c (mark_kboards): ... from here.
a053e86c 13009
4752793e
PE
13010 * lisp.h (force_auto_save_soon): New decl.
13011
74f10ca7 13012 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13013 (DEFINE_DUMMY_FUNCTION): New macro.
13014 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13015 Use it.
c03cd23f
PE
13016 (main): Add casts to avoid warnings
13017 if GCC considers string literals to be constants.
74f10ca7 13018
022e70d4
PE
13019 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13020
59d6fe83
PE
13021 * dbusbind.c: Pointer signedness fixes.
13022 (xd_signature, xd_append_arg, xd_initialize):
13023 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13024 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13025 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13026 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13027
78320123
PE
13028 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13029 if GCC considers string literals to be constants.
49cebcca 13030 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13031
35ac2a97
SM
130322011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13033
fb103ca9
SM
13034 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13035 (print_preprocess, print_object): New macro to fix last change.
13036
35ac2a97
SM
13037 * print.c (print_preprocess): Don't forget font objects.
13038
62973b41
JB
130392011-03-16 Juanma Barranquero <lekktu@gmail.com>
13040
13041 * emacs.c (USAGE3): Doc fixes.
13042
0e48bb22
AS
130432011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13044
13045 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13046 structure.
13047
7684e57b
JB
130482011-03-14 Juanma Barranquero <lekktu@gmail.com>
13049
13050 * lisp.h (VWindow_system, Qfile_name_history):
13051 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13052 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13053 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13054
13055 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13056 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13057
13058 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13059 * w32console.c (detect_input_pending, read_input_pending)
13060 (encode_terminal_code):
13061 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13062 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13063 (w32_system_caret_y, Qfile_name_history):
13064 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13065 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13066 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13067 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13068 * w32proc.c (Qlocal, report_file_error):
13069 * w32term.c (Vwindow_system, updating_frame):
13070 * w32uniscribe.c (initialized, uniscribe_font_driver):
13071 Remove unneeded extern declarations.
13072
2aa46d6c
CY
130732011-03-14 Chong Yidong <cyd@stupidchicken.com>
13074
c96bbc66 13075 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13076
cffc6f3b
CY
130772011-03-13 Chong Yidong <cyd@stupidchicken.com>
13078
13079 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13080 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13081 These macros can no longer be used for assignment.
13082
44f230aa
SM
13083 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13084 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13085 (record_buffer_markers, fetch_buffer_markers): New functions for
13086 recording and fetching special buffer markers.
13087 (set_buffer_internal_1, set_buffer_temp): Use them.
13088
13089 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13090
13091 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13092
13093 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13094 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13095
13096 * xdisp.c (hscroll_window_tree):
13097 (reconsider_clip_changes): Use PT instead of BUF_PT.
13098
d251f04b
EZ
130992011-03-13 Eli Zaretskii <eliz@gnu.org>
13100
13101 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13102 $(EMACS_ROOT)/lib/intprops.h.
13103
f0c77cd1
PE
131042011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13105
3eca4629
PE
13106 Fix more problems found by GCC 4.5.2's static checks.
13107
7c86ee98
PE
13108 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13109 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13110 (xg_free_frame_widgets): Make it clear that a local variable is
13111 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13112 (gdk_window_get_screen): Make it clear that this macro is needed
13113 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13114 (int_gtk_range_get_value): New function, which avoids a diagnostic
13115 from gcc -Wbad-function-cast.
13116 (xg_set_toolkit_scroll_bar_thumb): Use it.
13117 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13118 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13119 (get_utf8_string, xg_get_file_with_chooser):
13120 Rename locals to avoid shadowing.
13121 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13122
41729b81
PE
13123 * xgselect.c (xg_select): Remove unused var.
13124
f0c77cd1
PE
13125 * image.c (four_corners_best): Mark locals as initialized.
13126 (gif_load): Initialize transparent_p to zero (Bug#8238).
13127 Mark another local as initialized.
ec6cf4c6 13128 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13129
ce0ad53d 13130 * image.c (clear_image_cache): Now static.
d5d5a617 13131 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13132 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13133 (x_edge_detection): Remove unnecessary cast that
13134 gcc -Wbad-function-cast diagnoses.
2037898d 13135 (gif_load): Fix pointer signedness.
6ae141d6
PE
13136 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13137 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13138
33383987 131392011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13140
d32df629
PE
13141 Improve quality of tests for time stamp overflow.
13142 For example, without this patch (encode-time 0 0 0 1 1
13143 1152921504606846976) returns the obviously-bogus value (-948597
13144 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13145 reports time overflow. See
13146 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13147 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13148 * editfns.c: Include limits.h and intprops.h.
13149 (TIME_T_MIN, TIME_T_MAX): New macros.
13150 (time_overflow): Move earlier, to before first use.
13151 (hi_time, lo_time): New functions, for an accurate test for
13152 out-of-range times.
13153 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13154 (Fget_internal_run_time): Don't assume time_t fits in int.
13155 (make_time): Use list2 instead of Fcons twice.
13156 (Fdecode_time): More accurate test for out-of-range times.
13157 (check_tm_member): New function.
13158 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13159 (lisp_time_argument): Don't rely on undefined left-shift and
13160 right-shift behavior when checking for time stamp overflow.
8be6f318 13161
fe31d94c
PE
13162 * editfns.c (time_overflow): New function, refactoring common code.
13163 (Fformat_time_string, Fdecode_time, Fencode_time):
13164 (Fcurrent_time_string): Use it.
13165
8be6f318
PE
13166 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13167 * dired.c (make_time): Move to ...
13168 * editfns.c (make_time): ... here.
13169 * systime.h: Note the move.
13170
09d9db2c 131712011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13172
126bc0dc
YM
13173 * fringe.c (update_window_fringes): Remove unused variables.
13174
c47cbdfd
YM
13175 * unexmacosx.c (copy_data_segment): Also copy __got section.
13176 (Bug#8223)
13177
7ac80be9
EZ
131782011-03-12 Eli Zaretskii <eliz@gnu.org>
13179
c96bbc66 13180 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13181 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13182 Constify `char *' arguments and their references according to
13183 prototypes in tparam.h.
13184
ecb0f94d 13185 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13186
7ac80be9
EZ
13187 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13188 Adapt all references accordingly.
13189
13190 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13191
ef1fd07e
TT
131922011-03-11 Tom Tromey <tromey@redhat.com>
13193
13194 * buffer.c (syms_of_buffer): Remove obsolete comment.
13195
7ef4b50c
EZ
131962011-03-11 Eli Zaretskii <eliz@gnu.org>
13197
13198 * termhooks.h (encode_terminal_code): Declare prototype.
13199
13200 * msdos.c (encode_terminal_code): Don't declare prototype.
13201
13202 * term.c (encode_terminal_code): Now external again, used by
13203 w32console.c and msdos.c.
13204
44f230aa
SM
13205 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13206 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13207
4b1ec863 132082011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13209
1714f52b 13210 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13211
4b1ec863
PE
13212 * fringe.c (update_window_fringes): Mark locals as initialized
13213 (Bug#8227).
13214 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13215
524c7aa6
PE
13216 * alloc.c (mark_fringe_data): Move decl from here ...
13217 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13218 to check its interface.
13219 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13220
a5c0af81 13221 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13222 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13223 (fontset_font): Mark local as initialized.
a9a06e0b 13224 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13225
b4716021
PE
13226 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13227
811e9bac 13228 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13229 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13230 (x_own_selection, Fx_disown_selection_internal): Rename locals
13231 to avoid shadowing.
13232 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13233
7e3ab302
PE
13234 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13235 so that the caller can use some name other than gcpro1.
13236 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13237 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13238 (Fx_backspace_delete_keys_p):
13239 Use them to avoid shadowing, and rename vars to avoid shadowing.
13240 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13241 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13242 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13243 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13244 Remove unused locals.
7e3ab302
PE
13245 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13246 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13247 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13248 macros.
f78faa98 13249
e2b13473
PE
13250 * xterm.h (x_mouse_leave): New decl.
13251
77f23912
PE
13252 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13253 Remove unused functions.
cdf4ba58
PE
13254 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13255 (x_calc_absolute_position): Now static.
7411c686 13256 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13257 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13258 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13259 unless they are used.
38d0b34a
PE
13260 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13261 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13262 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13263 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13264 (x_error_catcher, x_connection_closed, x_error_handler):
13265 (x_error_quitter, xembed_send_message, x_iconify_frame):
13266 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13267 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13268 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13269
44f230aa
SM
13270 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13271 Rename or move locals to avoid shadowing.
6b463e58 13272 (tty_defined_color, merge_face_heights): Now static.
5967d051 13273 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13274 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13275 does not deduce is never used uninitialized.
73719eba
PE
13276 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13277 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13278
426994c3 13279 * terminal.c (store_terminal_param): Now static.
5489860b 13280
032f1620 13281 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13282 (set_frame_menubar): Remove unused local.
d4323972 13283 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13284 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13285 since they might point to immutable storage.
281585b0
PE
13286 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13287 since it's unused otherwise.
032f1620 13288
367c19e5 13289 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13290 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13291 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13292 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13293 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13294 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13295 does not deduce are never used uninitialized.
70739cbe 13296
07b48fa9
PE
13297 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13298
8868a238 13299 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13300 * window.c (window_loop, size_window):
13301 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13302
7e5cf297 13303 * window.c (display_buffer): Now static.
d6550a9f
PE
13304 (size_window): Mark variables that gcc -Wuninitialized
13305 does not deduce are never used uninitialized.
a586633d
PE
13306 * window.h (check_all_windows): New decl, to forestall
13307 gcc -Wmissing-prototypes diagnostic.
5b555da1 13308 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13309
f6095868
PE
13310 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13311 shadowing.
13312 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13313 Include <limits.h>.
13314 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13315 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13316 (load_charset_map): Mark variables that gcc -Wuninitialized
13317 does not deduce are never used uninitialized.
53df7c11 13318 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13319
f38b440c
PE
13320 * coding.c (coding_set_source, coding_set_destination):
13321 Use "else { /* comment */ }" rather than "else /* comment */;"
13322 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13323 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13324 a block, when the outer 'i' will do.
13325 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13326 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13327 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13328 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13329 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13330 Rename locals to avoid shadowing.
13331 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13332 * coding.c (emacs_mule_char, encode_invocation_designation):
13333 Now static, since they're not used elsewhere.
413bb2db 13334 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13335 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13336 (decode_coding_emacs_mule): Mark variables that gcc
13337 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13338 (detect_coding_iso_2022): Initialize a local variable that might
13339 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13340 this initialization is needed. (Bug#8211)
5f58e762
PE
13341 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13342 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13343 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13344 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13345 Remove unused macros.
f38b440c 13346
232b38b9 13347 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13348 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13349 * character.c (string_count_byte8): Likewise.
232b38b9 13350
fb90da1b
PE
13351 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13352 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13353
fb93dbc2
PE
13354 * chartab.c (copy_sub_char_table): Now static, since it's not used
13355 elsewhere.
5c156ace
PE
13356 (sub_char_table_ref_and_range, char_table_ref_and_range):
13357 Rename locals to avoid shadowing.
bbcd0949 13358 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13359
7d3b3862 13360 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13361 (BIDI_BOB): Remove unused macro.
7d3b3862 13362
6be7d3da
PE
13363 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13364 deduce are never used uninitialized.
c2ed9c8b 13365 * term.c (encode_terminal_code): Likewise.
6be7d3da 13366
75f8807f 13367 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13368
50938595
PE
13369 * tparam.h: New file.
13370 * term.c, tparam.h: Include it.
13371 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13372 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13373 Move these decls to tparam.h, and make them agree with what
13374 is actually in tparam.c. The previous trick of using incompatible
13375 decls in different modules does not conform to the C standard.
13376 All callers of tparam changed to use tparam's actual API.
13377 * tparam.c (tparam1, tparam, tgoto):
13378 Use const pointers where appropriate.
13379
fbceeba2
PE
13380 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13381 * cm.h (struct cm): Likewise.
13382 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13383 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13384 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13385 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13386 (turn_on_face, init_tty): Likewise.
13387 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13388
7f3f1250
PE
13389 * term.c (term_mouse_position): Rename local to avoid shadowing.
13390
e6ca6543
PE
13391 * alloc.c (mark_ttys): Move decl from here ...
13392 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13393
c40f8d15
AS
133942011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13395
13396 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13397
cfe0661d
JB
133982011-03-09 Juanma Barranquero <lekktu@gmail.com>
13399
13400 * search.c (compile_pattern_1): Remove argument regp, unused since
13401 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13402 (compile_pattern): Don't pass it.
13403
0afb4571
J
134042011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13405
13406 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13407 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13408 for ! HAVE_GTK3.
13409 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13410
13411 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13412
13413 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13414 gdk_window_get_screen, gdk_window_get_geometry,
13415 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13416 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13417 (xg_get_pixbuf_from_pixmap): New function.
13418 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13419 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13420 Call xg_get_pixbuf_from_pixmap instead of
13421 gdk_pixbuf_get_from_drawable.
13422 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13423 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13424 (xg_check_special_colors): Use GtkStyleContext and its functions
13425 for HAVE_GTK3.
13426 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13427 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13428 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13429 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13430 Call gtk_widget_get_preferred_size.
0afb4571
J
13431 (xg_frame_resized): gdk_window_get_geometry only takes 5
13432 parameters.
44f230aa
SM
13433 (xg_win_to_widget, xg_event_is_for_menubar):
13434 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13435 (xg_set_widget_bg): New function.
13436 (delete_cb): New function.
895009e1 13437 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13438 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13439 (xg_set_background_color): Call xg_set_widget_bg.
13440 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13441 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13442 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13443 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13444 if ! HAVE_GTK3.
13445 (update_frame_tool_bar): Call gtk_widget_hide.
13446 (xg_initialize): Use GDK_KEY_g.
13447
13448 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13449 if ! HAVE_GTK3
13450 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13451
13452 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13453 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13454 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13455
1c2cc4ef
JB
134562011-03-08 Juanma Barranquero <lekktu@gmail.com>
13457
13458 * w32xfns.c (select_palette): Check success of RealizePalette against
13459 GDI_ERROR, not zero.
13460
33383987 13461See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13462
13463;; Local Variables:
13464;; coding: utf-8
aac0c6e3
MR
13465;; End:
13466
2f097256 13467 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13468
13469 This file is part of GNU Emacs.
13470
13471 GNU Emacs is free software: you can redistribute it and/or modify
13472 it under the terms of the GNU General Public License as published by
13473 the Free Software Foundation, either version 3 of the License, or
13474 (at your option) any later version.
13475
13476 GNU Emacs is distributed in the hope that it will be useful,
13477 but WITHOUT ANY WARRANTY; without even the implied warranty of
13478 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13479 GNU General Public License for more details.
13480
13481 You should have received a copy of the GNU General Public License
13482 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.