Give more-useful info on a fatal error (Bug#12328).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
cf29dd84
PE
12012-09-04 Paul Eggert <eggert@cs.ucla.edu>
2
3 Give more-useful info on a fatal error (Bug#12328).
4 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
5 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
6 of doing the work ourselves.
7 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
8 do most of the work.
9 (fatal_error_backtrace): New function, taken from the guts
10 of the old fatal_error_signal, but with a new option to output
11 a backtrace.
12 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
13 info about the signal than just its number.
14 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
15 * sysdep.c: Include <execinfo.h>
16 (emacs_backtrace): New function, taken partly from the previous
17 code of the 'die' function.
18 (emacs_abort): Call fatal_error_backtrace rather than abort.
19
972debf2
SM
202012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
21
22 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
23 eager (load-time) macro-expansion.
24 * lisp.mk (lisp): Add macroexp.
25
1088b922
PE
262012-09-04 Paul Eggert <eggert@cs.ucla.edu>
27
28 Simplify redefinition of 'abort' (Bug#12316).
29 Do not try to redefine the 'abort' function. Instead, redo
30 the code so that it calls 'emacs_abort' rather than 'abort'.
31 This removes the need for the NO_ABORT configure-time macro
32 and makes it easier to change the abort code to do a backtrace.
33 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
34 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
35 Remove; sysdep.c's emacs_abort now takes its place.
36 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
37 'abort' changed to use 'emacs_abort'.
38 * msdos.c (dos_abort) [defined abort]: Remove; not used.
39 (abort) [!defined abort]: Rename to ...
40 (emacs_abort): ... new name.
41 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
42 the place of the old 'abort' in emacs.c.
43 * w32.c, w32fns.c (abort): Do not #undef.
44 * w32.c (emacs_abort): Rename from w32_abort.
45
30934d33
EZ
462012-09-04 Eli Zaretskii <eliz@gnu.org>
47
48 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
49 offsets[j].dv, since the y axis of the screen coordinates points
50 down, while the y axis of the font definition coordinates points
51 up. This fixes display of Arabic diacritics such as KASRA and
52 KASRATAN. (Bug#11860)
53
af26b72c
PE
542012-09-04 Paul Eggert <eggert@cs.ucla.edu>
55
56 Be more systematic about _setjmp vs setjmp.
57 * alloc.c (test_setjmp, mark_stack):
58 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
59 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
60 (png_load, my_error_exit, jpeg_load):
61 * process.c (send_process_trap, send_process):
62 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
63 The underscored versions are up to 30x faster on some hosts.
64 Formerly, the code used setjmp+longjmp sometimes and
65 _setjmp+_longjmp at other times, with no particular reason to
66 prefer setjmp+longjmp.
67
26d4541d
PE
682012-09-03 Paul Eggert <eggert@cs.ucla.edu>
69
d42f4f0f 70 Fix minor problem found by static checking.
26d4541d 71 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 72
c5e28e39
MR
732012-09-03 Martin Rudalics <rudalics@gmx.at>
74
75 * buffer.c (Fdelete_all_overlays): New function.
76
3eab3ca9
CY
772012-09-03 Chong Yidong <cyd@gnu.org>
78
79 * gtkutil.c: Add extern decl for Qxft.
80
c04889f8
PE
812012-09-02 Paul Eggert <eggert@cs.ucla.edu>
82
1882aa38
PE
83 * emacs.c, eval.c: Use bool for boolean.
84 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
85 (malloc_using_checking) [DOUG_LEA_MALLOC]:
86 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
87 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
88 (main, decode_env_path, Fdaemon_initialized):
89 * eval.c (call_debugger, Finteractive_p, interactive_p):
90 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
91 (maybe_call_debugger, Fbacktrace):
92 * process.c (read_process_output, exec_sentinel):
93 Use bool for booleans.
94 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
95 All callers changed.
96 * eval.c (interactive_p): Omit always-true boolean argument
97 EXCLUDE_SUBRS_P. All callers changed.
98 * dispextern.h, lisp.h: Reflect above API changes.
99 * firstfile.c (dummy): Use the address of 'main', whose signature
100 won't change, instead of the address of 'initialize', whose
101 signature just changed from int to bool.
102 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
103 * msdos.c (fatal_error_in_progress): ... from here.
104 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
105 of incrementing it.
106 (redisplay_internal, unwind_redisplay): Simply clear
107 REDISPLAYING_P when unwinding, instead of saving its previous,
108 always-false value and then restoring it.
109
a411ac43
PE
110 Clean up some extern decls.
111 Mostly, this hoists extern decls out of .c files and into .h files.
112 That way, we're more likely to catch errors if the interfaces change.
113 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
114 declare xg_mark_data.
115 * dispextern.h (x_frame_parm_handlers):
116 * font.h (Qxft):
117 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
118 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
119 (Qultra_bold, Qoblique, Qitalic):
120 Move extern decl here from .c file.
121 * alloc.c (xg_mark_data) [USE_GTK]:
122 * doc.c (Qclosure):
123 * eval.c (Qlexical_binding):
124 * fns.c (time) [!HAVE_UNISTD_H]:
125 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
126 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
127 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
128 * lread.c (Qinternal_interpreter_environment):
129 * minibuf.c (Qbuffer):
130 * process.c (QCfamily, QCfilter):
131 * widget.c (free_frame_faces):
132 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
133 * xfont.c (x_clear_errors):
134 * xterm.c (x_frame_parm_handlers):
135 Remove now-redundant extern decls.
136 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
137 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
138 Now static.
139 * xfaces.c: Remove unnecessary static decls.
140 * xterm.c (updating_frame): Remove decl of nonexistent object.
141
c04889f8
PE
142 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
143 when building globals.h, as the objects that are not built on
144 this host are not needed to compile C files on this host.
145
8b339673
JD
1462012-09-02 Jan Djärv <jan.h.d@swipnet.se>
147
148 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
149
150 * frame.h: Add missing prototype for x_wm_set_size_hint.
151
a08d4ba7
PE
1522012-09-02 Paul Eggert <eggert@cs.ucla.edu>
153
154 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
155 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
156 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
157 (Fsubstitute_command_keys):
158 * editfns.c (region_limit, find_field, Fconstrain_to_field)
159 (save_excursion_save, save_excursion_restore)
160 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
161 (format_time_string, general_insert_function)
162 (make_buffer_string, make_buffer_string_both)
163 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
164 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
165 (copy_text, insert_1, insert_1_both, insert_from_string)
166 (insert_from_string_before_markers, insert_from_string_1)
167 (insert_from_buffer, insert_from_buffer_1, replace_range)
168 (replace_range_2, del_range_1, del_range_byte, del_range_both)
169 (del_range_2, modify_region):
170 * intervals.c (intervals_equal, balance_possible_root_interval)
171 (adjust_intervals_for_insertion, merge_properties_sticky)
172 (graft_intervals_into_buffer, lookup_char_property)
173 (adjust_for_invis_intang, set_point_both)
174 (get_property_and_range, compare_string_intervals)
175 (set_intervals_multibyte_1, set_intervals_multibyte):
176 * keyboard.c (decode_timer):
177 Use bool for boolean.
178 * intervals.h, lisp.h, systime.h: Reflect above API changes.
179 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
180
48c948de
CY
1812012-09-02 Chong Yidong <cyd@gnu.org>
182
183 * keymap.c (push_key_description): Print M-TAB as C-M-i
184 (Bug#11758).
185
6c49a40b
JB
1862012-09-02 Juanma Barranquero <lekktu@gmail.com>
187
188 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
189 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
190 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
191 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
192 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
193 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
194 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
195
4dfbd238
EZ
1962012-09-01 Eli Zaretskii <eliz@gnu.org>
197
7e510e28
EZ
198 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
199 more than one grapheme cluster passed to the shaper: compute the
200 offset adjustment values separately for each cluster. (Bug#11860)
201
4dfbd238
EZ
202 * image.c: Restore mistakenly removed inclusion of w32.h. Without
203 it, GCC doesn't see prototypes of w32_delayed_load, and complains
204 about implicit conversions from integer to pointer.
205
86571ae0
DC
2062012-09-01 Daniel Colascione <dancol@dancol.org>
207
208 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
209 system used too early.
210
0e23ef9d
PE
2112012-09-01 Paul Eggert <eggert@cs.ucla.edu>
212
213 Better seed support for (random).
214 * emacs.c (main): Call init_random.
215 * fns.c (Frandom): Set the seed from a string argument, if given.
216 Remove long-obsolete Gentzel cruft.
217 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
218 (init_random): New function.
219
17a2cbbd
DC
2202012-09-01 Daniel Colascione <dancol@dancol.org>
221
222 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
223 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
224 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
225 x_wm_set_size_hint, x_query_colors, x_real_positions,
226 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
227 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
228 all of which have been moved to common code.
229
230 * xfaces.c: Include TERM_HEADER instead of listing all possible
231 window-system headers.
232
233 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
234 to match header.
235
236 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
237 directly accessing frame internals.
238
f18cbb28 239 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
240 globals_of_w32font.
241
242 * process.c: Include TERM_HEADER instead of listing all possible
243 window-system headers.
244
245 * nsterm.h: Remove declarations now in frame.h. Define
246 FRAME_X_SCREEN, FRAME_X_VISUAL.
247
248 * menu.c: Include TERM_HEADER instead of listing all possible
249 window-system headers.
250
251 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
252 window system.
253
254 * keyboard.c: Include TERM_HEADER instead of listing all possible
255 window-system headers.
256
257 * image.c: Include TERM_HEADER instead of listing all possible
258 window-system headers. Declare Vlibrary_cache when compiling for
259 Windows.
260
261 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
262 window system declarations.
263
264 * frame.h: Move common functions here: set_frame_menubar,
265 x_set_window_size, x_sync, x_get_focus_frame,
266 x_set_mouse_position, x_set_mouse_pixel_position,
267 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
268 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
269 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
270 x_activate_menubar, x_real_positions, x_bitmap_icon,
271 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
272 and x_query_colors.
273
274 * frame.c: Include TERM_HEADER instead of listing all possible
275 window-system headers.
276
277 * font.c: Include TERM_HEADER instead of listing all possible
278 window-system headers.
279
280 * emacs.c: Include TERM_HEADER.
281
f18cbb28
EZ
282 * dispnew.c: Include TERM_HEADER instead of listing all possible
283 window-system headers.
17a2cbbd 284
f18cbb28 285 * ccl.h: Include character.h.
17a2cbbd
DC
286
287 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
288 the current window system; include in list of objects to link into
289 Emacs.
290
c650a5de
DA
2912012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
292
293 Remove mark_ttys function and fix tty_display_info initialization.
294 * lisp.h (mark_ttys): Remove prototype.
295 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
296 to mark_ttys because all possible values of 'top_frame' slot are
297 the frames which are reachable from Vframe_list.
298 * term.c (mark_ttys): Remove.
299 (init_tty): Safely initialize 'top_frame' slot with Qnil.
300
4e0f6479
DA
3012012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
302
303 Change struct frame bitfields from unsigned char to unsigned.
304 * frame.h (struct frame): Change type of 'display_preempted',
305 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
306 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
307 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
308 bitfields from unsigned char to unsigned.
309
8b96a52c
DA
3102012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
311
312 Remove unused member of struct x_output and struct w32_output.
313 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
314 * w32term.h (struct w32_output): Likewise.
315
b4444c8a
JD
3162012-08-30 Jan Djärv <jan.h.d@swipnet.se>
317
318 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
319 does not become zero (Bug#12234).
320
b98521db
PE
3212012-08-30 Paul Eggert <eggert@cs.ucla.edu>
322
323 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
324 for GCC 4.7.1 x86-64.
325
31d02438
GM
3262012-08-30 Glenn Morris <rgm@gnu.org>
327
328 * lread.c (init_lread): For out-of-tree builds, only add the
329 source directory's site-lisp dir to the load-path if it exists,
330 consistent with in-tree builds. (Bug#12302)
331
7f8941d8
JD
3322012-08-28 Jan Djärv <jan.h.d@swipnet.se>
333
334 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
335 button_values to NULL. Call setStykeMask so dialogs get a close button.
336 (windowShouldClose:): Set window_closed.
337 (dealloc): New member, free button_values.
338 (process_dialog:): Make member function. Remove window argument,
339 replace window with self. Count buttons and allocate and store values
340 in button_values.
341 (addButton:value:row:): value is int with the name tag. Call setTag
342 with tag. Remove return self, declare return value as void.
343 (addString:row:): Remove return self, declare return value as void.
344 (addSplit): Remove return self, declare return value as void.
345 (clicked:): Remove return self, declare return value as void.
346 Set dialog_return to button_values[seltag]. Code formatting change.
347 (initFromContents:isQuestion:): Adjust call to process_dialog.
348 Code formatting change.
349 (timeout_handler:): Set timer_fired to YES.
350 (runDialogAt:): Set timer_fired to NO.
351 Handle click on close button as quit.
352
353 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
354 Add window_closed and button_values. Add void as return value for
355 add(Button|String|Split). addButton takes int instead of Lisp_Object.
356 Add process_dialog as new member.
357
eada0861 3582012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 359
eada0861
GM
360 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
361 is not one of the heaps we manage. (Bug#12242)
362
3632012-08-28 Glenn Morris <rgm@gnu.org>
364
365 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
366
457294dd
MR
3672012-08-28 Martin Rudalics <rudalics@gmx.at>
368
369 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
370 auto-buffer-name window parameter. Install revision of reverted
371 fix.
457294dd 372
4f2daf31
DA
3732012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
374
375 Do not allow to set major mode for a dead buffer.
376 * buffer.c (Fset_buffer_major_mode): Signal an error
377 if the buffer is dead.
378 (Fother_buffer, other_buffer_safely): Remove redundant
379 nested declaration.
380
66322887
DA
3812012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
382
383 Always use set_buffer_if_live to restore original buffer at unwind.
384 * buffer.h (record_unwind_current_buffer): New function.
385 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
386 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
387 * undo.c, window.c: Adjust users.
388 * buffer.c (set_buffer_if_live): Fix comment.
389
a3d794a1
DA
3902012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
391
392 Fix usage of set_buffer_internal.
393 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
394 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
395 * coding.c (decode_coding): Omit redundant test.
396 * fileio.c (decide_coding_unwind): Likewise.
397 * fns.c (secure_hash): Likewise.
398 * insdel.c (modify_region): Likewise.
399 * keyboard.c (command_loop_1): Likewise.
400 * print.c (PRINTFINISH): Likewise.
401 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
402
59ea14cd
PE
4032012-08-27 Paul Eggert <eggert@cs.ucla.edu>
404
405 * dispnew.c: Use bool for boolean.
406 (frame_garbaged, display_completed, delayed_size_change)
407 (fonts_changed_p, add_window_display_history)
408 (add_frame_display_history, verify_row_hash)
409 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
410 (row_equal_p, realloc_glyph_pool)
411 (allocate_matrices_for_frame_redisplay)
412 (showing_window_margins_p)
413 (adjust_frame_glyphs_for_frame_redisplay)
414 (build_frame_matrix_from_leaf_window, make_current)
415 (mirrored_line_dance, mirror_line_dance, update_frame)
416 (update_window_tree, update_single_window)
417 (check_current_matrix_flags, update_window, update_text_area)
418 (update_window_line, set_window_update_flags, scrolling_window)
419 (update_frame_1, scrolling, buffer_posn_from_coords)
420 (do_pending_window_change, change_frame_size)
421 (change_frame_size_1, sit_for):
422 Use bool for boolean.
423 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
424 and remove last int (actually boolean) argument, which was always 0.
425 All callers changed.
426 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
427 * dispextern.h (struct composition_it): Use bool for boolean.
428 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
429 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
430 * dired.c (file_name_completion):
431 Use bool for boolean. (This was missed in an earlier change.)
432
95072a94
MR
4332012-08-27 Martin Rudalics <rudalics@gmx.at>
434
435 * window.c (Fset_window_configuration): Revert first part of
436 last change.
437
0f19feff
JD
4382012-08-27 Jan Djärv <jan.h.d@swipnet.se>
439
440 * nsterm.h (NSPanel): New class variable dialog_return.
441
442 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
443 dialog_return.
444 (windowShouldClose:): Use stop instead of stopModalWithCode.
445 (clicked:): Ditto, and also set dialog_return (Bug#12258).
446 (timeout_handler:): Use stop instead of abortModal. Send a dummy
447 event.
448 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
449 modal loop returns.
450
f10fe38f
PE
4512012-08-27 Paul Eggert <eggert@cs.ucla.edu>
452
de1339b0
PE
453 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
454 * composite.c (find_composition, composition_gstring_p)
455 (composition_reseat_it, find_automatic_composition):
456 * data.c (let_shadows_buffer_binding_p)
457 (let_shadows_global_binding_p, set_internal, make_blv)
458 (Fmake_variable_buffer_local, Fmake_local_variable)
459 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
460 (cons_to_signed, arith_driver):
461 * dbusbind.c (xd_in_read_queued_messages):
462 * dired.c (directory_files_internal, file_name_completion):
463 Use bool for booleans.
464 * dired.c (file_name_completion):
465 * process.h (fd_callback):
466 Omit int (actually boolean) argument. It wasn't being used.
467 All uses changed.
468 * composite.h, lisp.h: Reflect above API changes.
469
f10fe38f
PE
470 * cmds.c, coding.c: Use bool for booleans.
471 * cmds.c (move_point, Fself_insert_command):
472 * coding.h (struct composition status, struct coding_system):
473 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
474 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
475 (emacs_mule_char, decode_coding_emacs_mule)
476 (encode_coding_emacs_mule, detect_coding_iso_2022)
477 (decode_coding_iso_2022, encode_invocation_designation)
478 (encode_designation_at_bol, encode_coding_iso_2022)
479 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
480 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
481 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
482 (encode_coding_raw_text, detect_coding_charset)
483 (decode_coding_charset, encode_coding_charset, detect_eol)
484 (detect_coding, get_translation_table, produce_chars)
485 (consume_chars, reused_workbuf_in_use)
486 (make_conversion_work_buffer, code_conversion_save)
487 (decode_coding_object, encode_coding_object)
488 (detect_coding_system, char_encodable_p)
489 (Funencodable_char_position, code_convert_region)
490 (code_convert_string, code_convert_string_norecord)
491 (Fset_coding_system_priority):
492 * fileio.c (Finsert_file_contents):
493 Use bool for booleans.
494 * coding.h, lisp.h: Reflect above API changes.
495 * coding.c: Remove unnecessary static function decls.
496 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
497 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
498 not a boolean 'int', since callers never look at the return value.
499 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
500 * coding.h (decoding_buffer_size, encoding_buffer_size)
501 (emacs_mule_string_char): Remove unused extern decls.
502 (struct iso_2022_spec, struct coding_system):
503 Use 'unsigned int : 1' for boolean fields, since there's more than one.
504 (struct emacs_mule_spec): Remove unused field 'full_support'.
505 All initializations removed.
506 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
507
5474c384
DA
5082012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
509
f10fe38f 510 Fix spare memory change (Bug#12286).
5474c384
DA
511 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
512 (valid_lisp_object_p): Likewise.
513
c4b6914d
MR
5142012-08-27 Martin Rudalics <rudalics@gmx.at>
515
516 * window.c (Fset_window_configuration): Record any window's old
517 buffer if it's replaced (see Bug#8789). If the new current
518 buffer doesn't appear in the selected window, go to its old
519 point (Bug#12208).
520
35aaa1ea
DA
5212012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
522
523 Special MEM_TYPE_SPARE to denote reserved memory.
524 * alloc.c (enum mem_type): New memory type.
525 (refill_memory_reserve): Use new type for spare memory.
526 This prevents live_cons_p and live_string_p from incorrect
527 detection of uninitialized objects from spare memory as live.
528
6af64513
PE
5292012-08-26 Paul Eggert <eggert@cs.ucla.edu>
530
8b2e00a3
PE
531 Spelling fixes.
532 * Makefile.in (.PHONY): versioclean -> versionclean.
533
b52d6985
PE
534 Remove unused external symbols.
535 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
536 * window.c (Qwindow_valid_p, decode_valid_window):
537 Now static, not extern.
538 * data.c (Qinterval): Remove; unused.
539 (syms_of_data): Do not define 'interval'.
540 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
541 * window.h (decode_valid_window):
542 Remove decls.
543
d5172d4f
PE
544 * character.c, charset.c, chartab.c: Use bool for booleans.
545 * character.c (lisp_string_width, string_count_byte8)
546 (string_escape_byte8):
547 * charset.c (charset_map_loaded, load_charset_map, read_hex):
548 (load_charset_map_from_file, map_charset_chars)
549 (Fdefine_charset_internal, define_charset_internal)
550 (Fdeclare_equiv_charset, find_charsets_in_text)
551 (Ffind_charset_region, char_charset, Fiso_charset):
552 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
553 (sub_char_table_set, sub_char_table_set_range)
554 (char_table_set_range, optimize_sub_char_table)
555 (map_sub_char_table):
556 Use bool for boolean.
557 * character.c (str_to_unibyte): Omit last boolean argument; it was
558 always 0. All callers changed.
559 * character.h, charset.h: Adjust to match previous changes.
560 * character.h (char_printable_p): Remove decl of nonexistent function.
561 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
562 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
563 are all boolean, so make them single-bit bitfields.
564
6af64513
PE
565 * lisp.h (ASET): Remove attempt to detect side effects.
566 It was meant to be temporary and it often doesn't work,
567 because when IDX has side effects the behavior of IDX==IDX
568 is undefined. See Stefan Monnier in
569 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
570
e1f29348
BR
5712012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
572
573 * lisp.h (functionp): New function (extracted from Ffunctionp).
574 (FUNCTIONP): Use it.
575 * eval.c (Ffunctionp): Use it.
576
17c05d74
PE
5772012-08-25 Paul Eggert <eggert@cs.ucla.edu>
578
0f46bc75
PE
579 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
580 as that's faster and simpler than static storage. Don't bother
581 with the g_main_context_query overhead if g_main_context_pending
582 says no events are pending.
583 (gfds, gfds_size): Remove these static vars.
584 (xgselect_initialize): Remove; no longer needed.
585 All uses and decls removed.
586
ee4c0f69
PE
587 * emacs.c (fatal_error_signal_hook): Remove.
588 All uses removed. This leftover from old code was always 0.
589
17c05d74
PE
590 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
591 * casefiddle.c (casify_object, casify_region):
592 * casetab.c (set_case_table):
593 * category.c, category.h (word_boundary_p):
594 * category.h (CHAR_HAS_CATEGORY):
595 Use bool for booleans, instead of int.
596
391ceac5
EZ
5972012-08-25 Eli Zaretskii <eliz@gnu.org>
598
599 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
600
2f221583
PE
6012012-08-25 Paul Eggert <eggert@cs.ucla.edu>
602
f4a681b0
PE
603 On assertion failure, print backtrace if available.
604 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
605 (die) [ENABLE_CHECKING]: Print a backtrace if available.
606 * Makefile.in (LIB_EXECINFO): New macro.
607 (LIBES): Use it.
608
2f221583
PE
609 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
610 * bytecode.c (exec_byte_code):
611 * callint.c (check_mark, Fcall_interactively):
612 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
613 (getenv_internal, sync_process_alive, call_process_exited):
614 * lisp.h (USE_SAFE_ALLOCA):
615 Use bool for booleans, instead of int.
616 * lisp.h, process.h: Adjust prototypes to match above changes.
617 * callint.c (Fcall_interactively): Don't assume the mark's
618 offset fits in 'int'.
619
37ef52bb
PE
6202012-08-24 Paul Eggert <eggert@cs.ucla.edu>
621
622 * buffer.c, buffer.h: Use bool for boolean.
623 * buffer.c (reset_buffer_local_variables)
624 (buffer_lisp_local_variables, Fset_buffer_modified_p)
625 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
626 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
627 (overlay_touches_p, overlay_strings, Foverlay_put)
628 (report_overlay_modification, call_overlay_mod_hooks):
629 (mmap_enlarge, mmap_set_vars):
630 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
631 Use bool for booleans, instead of int.
632 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
633 since the 1-or-0 return value is always ignored anyway.
634 (mmap_initialized_p):
635 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
636 * buffer.h, lisp.h: Adjust prototypes to match above changes.
637
2cc21167
PE
6382012-08-23 Paul Eggert <eggert@cs.ucla.edu>
639
640 * bidi.c: Use bool for boolean.
641 This is a bit more readable, and makes the text segment of bidi.o
642 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
643 Presumably it's faster too.
644 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
645 Now bool.
646 (bidi_cache_find_level_change, bidi_cache_iterator_state)
647 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
648 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
649 (bidi_explicit_dir_char, bidi_level_of_next_char)
650 (bidi_find_other_level_edge, bidi_move_to_visually_next):
651 Use bool for booleans, instead of int.
652 * dispextern.h (bidi_init_it, bidi_paragraph_init)
653 (bidi_unshelve_cache): Adjust decls to match code.
654
7db4ddf4
MR
6552012-08-23 Martin Rudalics <rudalics@gmx.at>
656
657 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
658 argument.
659
b1bb8011
PE
6602012-08-23 Paul Eggert <eggert@cs.ucla.edu>
661
662 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
663 * atimer.h: Include <stdbool.h>.
664
ff687885
DN
6652012-08-22 Dan Nicolaescu <dann@gnu.org>
666
667 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
668 compile time tests instead of run time tests on systems that do
669 not use them.
670 (FRAME_MAC_P): Remove leftover from deleted code.
671 * frame.c (syms_of_frame): Remove leftover from deleted code.
672
4ce7a138
JD
6732012-08-22 Jan Djärv <jan.h.d@swipnet.se>
674
675 * nsterm.m (insertText:): Don't clear modifiers if code is space.
676
d733ec6d
PE
6772012-08-22 Paul Eggert <eggert@cs.ucla.edu>
678
679 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
680 Otherwise, the compiler complains about (A?B:C) where B is void
681 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
682 (fontset_add): Return void, for FONTSET_ADD.
683
d0d2d26f
PE
6842012-08-21 Paul Eggert <eggert@cs.ucla.edu>
685
fce31d69
PE
686 * alloc.c: Use bool for booleans.
687 (gc_in_progress, abort_on_gc)
688 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
689 (dont_register_blocks) [GC_MALLOC_CHECK]:
690 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
691 (check_string_bytes, make_specified_string, memory_full)
692 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
693 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
694 (mark_stack, valid_pointer_p, make_pure_string)
695 (Fgarbage_collect, survives_gc_p, gc_sweep):
696 Use bool for booleans, instead of int.
697 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
698 Remove unused local.
699 * alloc.c (PURE_POINTER_P):
700 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
701 * editfns.c (Fformat):
702 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
703 (Fdo_auto_save):
704 * fns.c (sweep_weak_table):
705 * lisp.h (suppress_checking, push_message, survives_gc_p)
706 (make_pure_string, gc_in_progress, abort_on_gc):
707 * lread.c (readchar, read1):
708 * print.c (Fprin1_to_string):
709 * xdisp.c (push_message):
710 Use bool for booleans affected directly or indirectly by
711 alloc.c's changes.
712
d0d2d26f
PE
713 Make recently-introduced setters macros.
714 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
715 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
716 (set_fontset_default, set_fontset_fallback): Rename from their
717 upper-case counterparts, and make them functions rather than macros.
718 This is more consistent with the other recently-introduced setters.
719 These don't need to be inline, since they're local.
720
d18e2bb6
JD
7212012-08-21 Jan Djärv <jan.h.d@swipnet.se>
722
723 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
724 the loop (Bug#12247).
725
1b9d9d16
PE
7262012-08-21 Paul Eggert <eggert@cs.ucla.edu>
727
728 * lisp.h (vcopy): Use memcpy rather than our own loop.
729 This fixes a performance regression introduced by the recent
730 addition of vcopy. This means 'vcopy' will need to be modified
731 for a copying collector, but that's OK. Also, tighten the
732 checking in the assertion.
733
b2f09701
EZ
7342012-08-21 Eli Zaretskii <eliz@gnu.org>
735
736 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
737 components for RTL text (Bug#11860). Adjust X-OFFSET of each
738 non-base glyph for the width of the base character, according to
e1f29348
BR
739 what x_draw_composite_glyph_string_foreground expects.
740 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
741 expectations, to produce correct width of the composed character.
742 Reverse the sign of the DU offset produced by ScriptPlace.
743
9b994fed
PE
7442012-08-21 Paul Eggert <eggert@cs.ucla.edu>
745
746 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
747
086ca913
DA
7482012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
749
750 Avoid direct writes to contents member of struct Lisp_Vector.
751 * lisp.h (vcopy): New function to copy data into vector.
752 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
753 * fns.c (Ffillarray): Use ASET.
754 * keyboard.c (timer_check_2): Use AREF and ASET.
755 (append_tool_bar_item, Frecent_keys): Use vcopy.
756 * lread.c (read_vector): Use ASET.
757 * msdos.c (Frecent_doskeys): Use vcopy.
758 * xface.c (Finternal_copy_lisp_face): Use vcopy.
759 (Finternal_merge_in_global_face): Use ASET and vcopy.
760 * xfont.c (xfont_list_pattern): Likewise.
761
5481664a
MR
7622012-08-21 Martin Rudalics <rudalics@gmx.at>
763
764 * window.c (Fwindow_point): For the selected window always return
765 the position of its buffer's point.
766 (Fset_window_point): For the selected window always go in its
767 buffer to the specified position.
768
6d470bdd
DA
7692012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
770
771 Setter macros for fontsets.
772 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
773 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
774 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
775 Adjust users.
776
24564fe1
GM
7772012-08-20 Glenn Morris <rgm@gnu.org>
778
779 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
780 Don't assume that `ln -f' works.
781
0a05a035
EZ
7822012-08-20 Eli Zaretskii <eliz@gnu.org>
783
784 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
785 and later about non-assignments with no effect. See discussion at
786 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
787 details.
788
e46f2325
DA
7892012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
790
791 Inline setter functions for Lisp_Objects slots of struct specbinding.
792 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
793 Adjust users.
794
734fbd86
MR
7952012-08-20 Martin Rudalics <rudalics@gmx.at>
796
797 * window.c (select_window): Always make selected window's buffer
798 current.
799
f1a95992
DA
8002012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
801
802 Use AREF and ASET for docstrings of category tables.
803 * category.h (CATEGORY_DOCSTRING): Use AREF.
804 (SET_CATEGORY_DOCSTRING): Use ASET.
805 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
806
e83064be
DA
8072012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
808
809 Inline setter functions for hash table members.
810 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
811 (set_hash_hash, set_hash_index): Rename with _slot suffix.
812 (set_hash_key_and_value, set_hash_index, set_hash_next)
813 (set_hash_hash): New functions.
814 * charset.c, fns.c: Adjust users.
815
4ce60d2e
DA
8162012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
817
818 Inline getter and setter functions for per-buffer values.
819 * buffer.h (per_buffer_default, set_per_buffer_default)
820 (per_buffer_value, set_per_buffer_value): New functions.
821 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
822 * buffer.c, data.c: Adjust users.
823
c06c9690
JB
8242012-08-20 Juanma Barranquero <lekktu@gmail.com>
825
826 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
827
32bd4250
PE
8282012-08-19 Paul Eggert <eggert@cs.ucla.edu>
829
bad03192 830 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
831 as gnulib does this if the system doesn't.
832 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
833 Remove declaration. MS-Windows declares it on stdlib.h which is
834 included by conf_post.h.
b69a6d22
PE
835 * emacs.c (environ) [DOUG_LEA_MALLOC]:
836 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
837 * vm-limit.c: Include <unistd.h>, for 'environ'.
838
22d7feb2
PE
839 * unexaix.c, unexcoff.c: Include "mem-limits.h".
840 (start_of_data): Remove decl; mem-limits.h provides it.
841
32bd4250
PE
842 * xdisp.c (handle_invisible_prop): Make it a bit faster
843 and avoid a gcc -Wmaybe-uninitialized diagnostic.
844
450809af
CY
8452012-08-19 Chong Yidong <cyd@gnu.org>
846
847 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
848 ends (Bug#3874).
849
9e677988
AS
8502012-08-19 Andreas Schwab <schwab@linux-m68k.org>
851
6b1319ce
AS
852 * .gdbinit: Use call instead of set when calling a function in the
853 inferior.
854
9e677988
AS
855 * data.c (set_internal): Don't use set_blv_found.
856 (Fkill_local_variable): Likewise.
857
d7191076
AA
8582012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
859
860 * nsfont.m (ns_ascii_average_width): Ensure the string
861 ascii_printable is initialized with a null-terminated character
862 array. Otherwise, it can contain undesired extra characters.
863
e757f1c6
PE
8642012-08-18 Paul Eggert <eggert@cs.ucla.edu>
865
866 port new setting code to Sun C 5.8 2005/10/13
867 * chartab.c, lisp.h (char_table_set, char_table_set_range):
868 Return void, not Lisp_Object. Otherwise, the compiler
869 complains about (A?B:C) where B is void and C is Lisp_Object
870 when compiling CHAR_TABLE_SET, due to the recent change to
871 the API of sub_char_table_set_contents.
872
a999ce26
CY
8732012-08-18 Chong Yidong <cyd@gnu.org>
874
875 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
876 for the string case (Bug#3874).
877
3f22b86f
PE
8782012-08-18 Paul Eggert <eggert@cs.ucla.edu>
879
39eb03f1
PE
880 * buffer.h (BSET): Remove (Bug#12215).
881 Replace all uses with calls to new setter functions.
882 (bset_bidi_paragraph_direction, bset_case_canon_table)
883 (bset_case_eqv_table, bset_directory, bset_display_count)
884 (bset_display_time, bset_downcase_table)
885 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
886 (bset_last_selected_window, bset_local_var_alist)
887 (bset_mark_active, bset_point_before_scroll, bset_read_only)
888 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
889 (bset_width_table):
890 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
891 (bset_auto_fill_function, bset_auto_save_file_format)
892 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
893 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
894 (bset_cache_long_line_scans, bset_case_fold_search)
895 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
896 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
897 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
898 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
899 (bset_header_line_format, bset_indicate_buffer_boundaries)
900 (bset_indicate_empty_lines, bset_invisibility_spec)
901 (bset_left_fringe_width, bset_major_mode, bset_mark)
902 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
903 (bset_name, bset_overwrite_mode, bset_pt_marker)
904 (bset_right_fringe_width, bset_save_length)
905 (bset_scroll_bar_width, bset_scroll_down_aggressively)
906 (bset_scroll_up_aggressively, bset_selective_display)
907 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
908 (bset_word_wrap, bset_zv_marker):
909 * category.c (bset_category_table):
910 * syntax.c (bset_syntax_table):
911 New setter functions.
912
6a09a33b
PE
913 * process.h (PSET): Remove (Bug#12215).
914 Replace all uses with calls to new setter functions.
915 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
916 (PROCESS_INLINE): New macro.
917 (pset_childp): New setter function.
918 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
919 * process.c (PROCESS_INLINE):
920 Define to EXTERN_INLINE, so that the corresponding functions
921 are compiled into code.
922 (pset_buffer, pset_command, pset_decode_coding_system)
923 (pset_decoding_buf, pset_encode_coding_system)
924 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
925 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
926 (pset_type, pset_write_queue): New setter functions.
927
e8c17b81
PE
928 * window.h (WSET): Remove (Bug#12215).
929 Replace all uses with calls to new setter functions.
930 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
931 (WINDOW_INLINE): New macro.
932 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
933 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
934 (wset_total_lines, wset_vertical_scroll_bar)
935 (wset_window_end_pos, wset_window_end_valid)
936 (wset_window_end_vpos): New setter functions.
937 * window.c (WINDOW_INLINE):
938 Define to EXTERN_INLINE, so that the corresponding functions
939 are compiled into code.
940 (wset_combination_limit, wset_dedicated, wset_display_table)
941 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
942 (wset_new_normal, wset_new_total, wset_next_buffers)
943 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
944 (wset_prev_buffers, wset_right_fringe_width)
945 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
946 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
947 (wset_window_parameters):
948 * xdisp.c (wset_base_line_number, wset_base_line_pos)
949 (wset_column_number_displayed, wset_region_showing):
950 New setter functions.
951
3f22b86f
PE
952 * termhooks.h (TSET): Remove (Bug#12215).
953 Replace all uses with calls to new setter functions.
954 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
955 (TERMHOOKS_INLINE): New macro.
956 (tset_charset_list, tset_selection_alist): New setter functions.
957 * terminal.c (TERMHOOKS_INLINE):
958 Define to EXTERN_INLINE, so that the corresponding functions
959 are compiled into code.
960 (tset_param_alist): New setter function.
961
742af32f
PE
9622012-08-17 Paul Eggert <eggert@cs.ucla.edu>
963
15dbb4d6
PE
964 * keyboard.h (KSET): Remove (Bug#12215).
965 Replace all uses with calls to new setter functions.
966 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
967 (KEYBOARD_INLINE): New macro.
968 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
969 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
970 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
971 New setter functions.
972 * keyboard.c (KEYBOARD_INLINE):
973 Define to EXTERN_INLINE, so that the corresponding functions
974 are compiled into code.
975 (kset_echo_string, kset_kbd_queue)
976 (kset_keyboard_translate_table, kset_last_prefix_arg)
977 (kset_last_repeatable_command, kset_local_function_key_map)
978 (kset_overriding_terminal_local_map, kset_real_last_command)
979 (kset_system_key_syms): New setter functions.
980
f00af5b1
PE
981 * frame.h (FSET): Remove (Bug#12215).
982 Replace all uses with calls to new setter functions.
983 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
984 (FRAME_INLINE): New macro.
985 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
986 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
987 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
988 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
989 (fset_param_alist, fset_root_window, fset_scroll_bars)
990 (fset_selected_window, fset_title, fset_tool_bar_items)
991 (fset_tool_bar_position, fset_tool_bar_window): New functions.
992 * frame.c (FRAME_INLINE):
993 Define to EXTERN_INLINE, so that the corresponding functions
994 are compiled into code.
995 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
996
0c94c8d6
PE
997 A few more naming-convention fixes for getters and setters.
998 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
999 and rename from buffer_overlays_set_before.
1000 (set_buffer_overlays_after): Move here from buffer.h, and rename
1001 from buffer_overlays_set_after.
1002 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
1003 All uses changed.
1004 (set_buffer_intervals): Rename from buffer_set_intervals.
1005 * intervals.c (set_interval_object): Move here from intervals.h,
1006 and rename from interval_set_object.
1007 (set_interval_left): Move here from intervals.h, and rename from
1008 interval_set_left.
1009 (set_interval_right): Move here from intervals.h, and rename from
1010 interval_set_right.
1011 (copy_interval_parent): Move here from intervals.h, and rename from
1012 interval_copy_parent.
1013 * intervals.h (set_interval_parent): Rename from interval_set_parent.
1014 (set_interval_plist): Rename from interval_set_plist.
1015 Return void, not Lisp_Object, since no caller uses the result.
1016 * lisp.h (string_intervals): Rename from string_get_intervals.
1017 (set_string_intervals): Rename from string_set_intervals.
1018
34dabdb7
PE
1019 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
1020 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 1021 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
1022 All uses changed. See the end of
1023 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
1024
742af32f
PE
1025 * lisp.h (CSET): Remove (Bug#12215).
1026 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
1027 (set_char_table_purpose): New functions,
1028 replacing CSET. All uses changed. For example, replace
1029 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 1030 "set_char_table_parent (char_table, parent);".
742af32f
PE
1031 The old version was confusing because it used the same name
1032 'parent' for two different things.
1033
a04e2c62
DA
10342012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1035
1036 Functions to get and set Lisp_Object fields of buffer-local variables.
1037 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
1038 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
1039 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
1040 * data.c, eval.c, frame.c: Adjust users.
1041
383dcbf9
CY
10422012-08-17 Chong Yidong <cyd@gnu.org>
1043
1044 * xfaces.c (merge_face_vectors): If the target font specfies a
1045 font spec, make the font's attributes take precedence over
1046 directly-specified attributes.
1047 (merge_face_ref): Recognize :font.
1048
44386687
DA
10492012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1050
1051 Do not use memcpy for copying intervals.
1052 * intervals.c (reproduce_interval): New function.
1053 (reproduce_tree, reproduce_tree_obj): Use it.
1054 (reproduce_tree_obj): Remove prototype.
1055
927c7216
PE
10562012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1057
1058 * lisp.h (duration_to_sec_usec): Remove unused decl.
1059
93044f7b
AA
10602012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
1061
1062 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
1063 to an allocated instance of NSString, not to the class itself.
1064
9851e4a5
JB
10652012-08-17 Juanma Barranquero <lekktu@gmail.com>
1066
1067 * makefile.w32-in (C_CTYPE_H): New macro.
1068 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
1069 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
1070 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1071
620f13b0
PE
10722012-08-16 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 Use ASCII tests for character types.
1075 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
1076 * xfns.c, xterm.c:
1077 Don't include <ctype.h>; was not needed.
1078 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
1079 * sysdep.c, xfaces.c:
1080 Include <c-ctype.h> instead of <ctype.h>.
1081 * nsterm.m: Include <c-ctype.h>.
1082 * charset.c (read_hex):
1083 * doc.c (Fsnarf_documentation):
1084 * fileio.c (IS_DRIVE) [WINDOWSNT]:
1085 (DRIVE_LETTER) [DOS_NT]:
1086 (Ffile_name_directory, Fexpand_file_name)
1087 (Fsubstitute_in_file_name):
1088 * font.c (font_parse_xlfd, font_parse_fcname):
1089 * frame.c (x_set_font_backend):
1090 * gtkutil.c (xg_get_font):
1091 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
1092 * nsimage.m (hexchar):
1093 * nsterm.m (ns_xlfd_to_fontname):
1094 * sysdep.c (system_process_attributes):
1095 * xfaces.c (hash_string_case_insensitive):
1096 Use C-locale tests instead of locale-specific tests for character
1097 types, since we want the ASCII interpretation here, not the
1098 interpretation suitable for whatever happens to be the current locale.
1099
52162052
MR
11002012-08-16 Martin Rudalics <rudalics@gmx.at>
1101
1102 Consistently check windows for validity/liveness
1103 (Bug#11984, Bug#12025, Bug#12026).
1104 * lisp.h (CHECK_VALID_WINDOW): New macro.
1105 * window.c (decode_window): Rename to decode_live_window.
1106 (decode_valid_window, Fwindow_valid_p): New functions.
1107 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
1108 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
1109 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
1110 (Fwindow_prev_sibling, Fwindow_combination_limit)
1111 (Fset_window_combination_limit, Fwindow_use_time)
1112 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
1113 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
1114 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
1115 (Fwindow_hscroll, Fset_window_hscroll)
1116 (Fwindow_redisplay_end_trigger)
1117 (Fset_window_redisplay_end_trigger, Fwindow_edges)
1118 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
1119 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1120 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
1121 (Fwindow_end, Fset_window_point, Fset_window_start)
1122 (Fpos_visible_in_window_p, Fwindow_line_height)
1123 (Fwindow_dedicated_p, Fset_window_dedicated_p)
1124 (Fwindow_prev_buffers, Fset_window_prev_buffers)
1125 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
1126 (Fset_window_parameter, Fwindow_display_table)
1127 (Fset_window_display_table, Fdelete_other_windows_internal)
1128 (Fset_window_buffer, Fset_window_new_total)
1129 (Fset_window_new_normal, Fdelete_window_internal)
1130 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
1131 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
1132 (Fwindow_scroll_bars): Check whether argument window is a valid or
1133 live window. Update doc-strings.
1134 (syms_of_window): New symbol Qwindow_valid_p.
1135 * keyboard.c (Fposn_at_x_y): Check whether argument
1136 frame_or_window denotes a valid window.
1137
2751c80f
DA
11382012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1139
1140 Fix previous char table change.
1141 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
1142 * chartab.c (optimize_sub_char_table): Likewise.
1143
032a42c8
CY
11442012-08-16 Chong Yidong <cyd@gnu.org>
1145
a2d19368
CY
1146 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
1147
032a42c8
CY
1148 * xfont.c (xfont_open):
1149 * xftfont.c (xftfont_open): Set the font's max_width field.
1150
1151 * nsfont.m (nsfont_open): Similar to the Xft backend, set
1152 min_width to space_width and average_width to the average over
1153 printable ASCII characters.
1154 (ns_char_width): Code cleanup.
1155 (ns_ascii_average_width): New utility function.
1156
1157 * font.h (struct font): Update comments.
1158
a098c930
DA
11592012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1160
032a42c8 1161 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
1162 * lisp.h (CSET): New macro.
1163 (char_table_set_extras, char_table_set_contents)
1164 (sub_char_table_set_contents): New function.
1165 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
1166 * syntax.c: Adjust users.
1167
8be3a09c
SM
11682012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
1169
1170 * eval.c (eval_sub): Bind lexical-binding.
1171 * lread.c (Qlexical_binding): Make non-static.
1172
ac4845a6
JD
11732012-08-15 Jan Djärv <jan.h.d@swipnet.se>
1174
ddee6515
JD
1175 * nsmenu.m (popupSession): Remove.
1176 (pop_down_menu): Remove endModalSession.
1177 (timeout_handler:): New method.
1178 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
1179 Call runModalForWindow. Check timer_fired when it returns.
1180 If not set, cancel timer and break out of loop.
1181 Otherwise loop again, with a new timeout.
1182
1183 * nsterm.m: Include fcntl.h if present.
1184 (fd_entry, t_readfds, inNsSelect): Remove.
1185 (select_writefds, select_valid, select_timeout, selfds)
1186 (select_mutex, apploopnr): Add.
1187 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
1188 Otherwise call kbd_buffer_store_event.
1189 (ns_send_appdefined): Remove release of fd_entry.
1190 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
1191 Increment and decrement apploopnr.
1192 (ns_select): If no file descriptors, just do a NSTimer.
1193 Otherwise copy read/write masks and start select thread (fd_handler).
1194 Start main loop and wait for application defined event.
1195 Inform select thread to stop selecting after main loop is exited.
1196 (ns_term_init): Create selfds pipe and set non-blocking.
1197 Initialize select_mutex. Start the select thread (fd_handler).
1198 (fd_handler:): Loop forever, wait for info from the main thread
1199 to either start or stop selecting. When select returns, send
1200 and appdefined event.
1201 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
1202 If not call kbd_buffer_store_event.
1203
1204 * nsterm.h (EmacsApp): fd_handler takes id argument.
1205 (EmacsDialogPanel): Add timer_fired and timeout_handler.
1206
ac4845a6
JD
1207 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
1208
eb424fe3
EZ
12092012-08-15 Eli Zaretskii <eliz@gnu.org>
1210
1211 * region-cache.c (move_cache_gap): Update gap_len using the actual
1212 growth of the boundaries array. Do not change cache_len.
1213 (Bug#12196)
1214
4e6a86c6
DA
12152012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1216
1217 Generalize and cleanup font subsystem checks.
1218 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
1219 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
1220 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 1221
5bf192ca
DA
12222012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1223
1224 * gtkutil.c (xg_get_font): Use pango_units_to_double.
1225
f2045622
CY
12262012-08-15 Chong Yidong <cyd@gnu.org>
1227
8be3a09c
SM
1228 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
1229 When using the new font chooser, use gtk_font_chooser_get_font_desc to
1230 extract the font descriptor instead of just the font name.
1231 In that case, return a font spec instead of a string.
f2045622
CY
1232 (x_last_font_name): Move to this file from xfns.c.
1233
1234 * xfns.c (Fx_select_font): The return value can also be a font
1235 spec. Move x_last_font_name management to gtkutil.c.
1236
1237 * xfaces.c: Make font weight and style symbols non-static.
1238
7f6feb56
SM
12392012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
1240
1241 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
1242 (bug#12117).
1243
fecbd8ff
SM
12442012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
1245
1246 * alloc.c (Fgarbage_collect): Use plural form consistently.
1247
9b8d5165
EZ
12482012-08-14 Eli Zaretskii <eliz@gnu.org>
1249
1250 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
1251 iteration through the command loop. Fixes a problem whereby mouse
1252 movements are ignored until the first mouse click.
1253
f5d9e83a
PE
12542012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1255
1256 Use bool, not int, for Lisp booleans.
1257 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
1258 makes Emacs a bit smaller and presumably a bit faster.
1259 * lisp.h: Include <stdbool.h>.
1260 (struct Lisp_Boolfwd, defvar_bool):
1261 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
1262 * regex.c [!emacs]: Include <stdbool.h>.
1263 (false, true): Remove; <stdbool.h> does this for us now.
1264
55802e4a
CY
12652012-08-14 Chong Yidong <cyd@gnu.org>
1266
4abcdac8
CY
1267 * character.c (Fcharacterp): Doc fix (Bug#12076).
1268
1269 * data.c (Findirect_variable): Doc fix (Bug#11040).
1270
55802e4a
CY
1271 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
1272
1273 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 1274 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 1275
8e99d072
BR
12762012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1277
1278 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
1279 (bug#12022).
1280
08908aca
MR
12812012-08-14 Martin Rudalics <rudalics@gmx.at>
1282
1283 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
1284 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1285 * minibuf.c (choose_minibuf_frame, read_minibuf):
1286 * w32fns.c (x_create_tip_frame):
1287 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
1288 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
1289
56120d6f
PE
12902012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 * intervals.c (offset_intervals): Remove obsolete comment.
1293
67b77c0b
AS
12942012-08-14 Andreas Schwab <schwab@linux-m68k.org>
1295
1296 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
1297
f48b82fd
GR
12982012-08-14 Gergely Risko <gergely@risko.hu>
1299
1300 * coding.c (decode_coding): Record buffer modification before
1301 disabling undo_list (Bug#11773).
1302
fd318b54
DA
13032012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1304
1305 Revert and cleanup some recent overlay changes.
1306 * buffer.h (enum overlay_type): Remove.
1307 (buffer_get_overlays, buffer_set_overlays): Likewise.
1308 (buffer_set_overlays_before, buffer_set_overlays_after):
1309 New function. Adjust users.
1310 (unchain_both): Add eassert.
1311
41a62dd9
DA
13122012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1313
1314 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
1315
5884c324
PE
13162012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 * gtkutil.c (xg_mark_data): Don't assume C99.
1319
ca06f160
JD
13202012-08-13 Jan Djärv <jan.h.d@swipnet.se>
1321
1322 * gtkutil.c (xg_frame_tb_info): New struct.
1323 (TB_INFO_KEY): New define.
1324 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
1325 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
1326 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
1327 if not present.
1328 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
1329 is up to date. Otherwise store new data.
1330 (free_frame_tool_bar): Free xg_frame_tb_info if present.
1331
7864a3f7
DA
13322012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1333
1334 Use KSET for write access to Lisp_Object members of struct kboard.
1335 * keyboard.h (KSET): New macro.
1336 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
1337 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
1338 * xterm.c: Adjust users.
1339
4c31be61
DA
13402012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1341
1342 Use BSET for write access to Lisp_Object members of struct buffer.
1343 * buffer.h (BSET): New macro.
1344 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
1345 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
1346 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
1347 * window.c, xdisp.c, xfns.c: Adjust users.
1348
14ae4239
BT
13492012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
1350
1351 * lread.c (syms_of_lread): Initialize Vlexical_binding.
1352
32bcadb4
JD
13532012-08-11 Jan Djärv <jan.h.d@swipnet.se>
1354
3d29b2ce
JD
1355 * nsterm.m (not_in_argv): New function.
1356 (application:openFile, application:openTempFile:):
1357 (application:openFileWithoutUI:, application:openFiles:): Open file
1358 if not_in_argv returns non-zero (bug#12171).
1359
32bcadb4 1360 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
1361 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
1362 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
1363 (xg_get_font_name): Use those functions/macros here.
1364 Reported by Frans Oilinki <moilinki@gmail.com>.
1365
9ff9402d 13662012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
1367
1368 * unexmacosx.c (copy_data_segment): Copy initialized data in
1369 statically linked libraries from input file rather than memory.
1370
db74a5fc
YM
1371 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
1372 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
1373 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
1374
25e65510
GM
13752012-08-10 Glenn Morris <rgm@gnu.org>
1376
1377 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
1378 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
1379
7961135c
DA
13802012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1381
1382 Fix last change to allow compilation with low optimization levels.
1383 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
1384 Reported by Jan Djärv <jan.h.d@swipnet.se>.
1385
42b3a444
DA
13862012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1387
1388 Use common inline syntax in intervals.h.
1389 * intervals.h (INTERVALS_INLINE): New macro.
1390 Change all users from LISP_INLINE.
1391
9fb0c957
DA
13922012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1393
1394 Define Qnone once for all platforms.
1395 * frame.c (Qnone): Define here.
1396 (syms_of_frame): DEFSYM it.
1397 * lisp.h (Qnone): New declaration.
1398 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
1399 * xfns.c: Remove duplication. Adjust users.
1400
65e8ee52
DA
14012012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1402
1403 Remove unused macros from intervals.h.
1404 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
1405 * intervals.c: Adjust comment.
1406
9b855fd6
EZ
14072012-08-10 Eli Zaretskii <eliz@gnu.org>
1408
1409 * w32fns.c <w32_unicode_gui>: New static variable.
1410 (globals_of_w32fns): Initialize it according to os_subtype.
1411 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
1412 testing os_subtype.
1413
39cb9e56 14142012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
1415 Eli Zaretskii <eliz@gnu.org>
1416
1417 Fix bug #10299 with Unicode characters sent by customized
1418 keyboards created by MSKLC.
1419 * w32fns.c (INIT_WINDOW_CLASS): New macro.
1420 (w32_init_class): Use it to initialize the Emacs class with either
1421 ANSI or Unicode API calls.
1422 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
1423 later.
1424 (w32_wnd_proc): If the character code sent by WM_CHAR or
1425 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
1426 original message. Call DefWindowProcW on NT and later.
1427
9374581a
GM
14282012-08-10 Glenn Morris <rgm@gnu.org>
1429
4b94e8cf
GM
1430 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
1431
9374581a
GM
1432 * lisp.h (DIRECTORY_SEP): Let configure set it.
1433
a2752828
DA
14342012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1435
1436 Use TSET for write access to Lisp_Object slots of struct terminal.
1437 * termhooks.h (TSET): New macro.
1438 * coding.c, terminal.c, xselect.c: Adjust users.
1439
cc92c454
SM
14402012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
1441
1442 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
1443 the failing expression, include them in the error message.
1444 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
1445 * lisp.h (internal_condition_case_n): Update declaration.
1446
4cb3e6b3
DA
14472012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1448
1449 Inline functions to examine and change buffer overlays.
1450 * buffer.c (unchain_both): New function.
1451 * buffer.h (buffer_get_overlays, buffer_set_overlays):
1452 (buffer_has_overlays): New function.
1453 (enum overlay_type): New enum.
1454 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
1455 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
1456
8707c1e5
DA
14572012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1458
1459 Inline functions to examine and change buffer intervals.
1460 * alloc.c (mark_interval_tree): Remove.
1461 (MARK_INTERVAL_TREE): Simplify.
1462 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
1463 * intervals.c (buffer_balance_intervals): New function.
1464 (graft_intervals_into_buffer): Adjust indentation.
1465 (set_intervals_multibyte): Simplify.
1466 * buffer.h (BUF_INTERVALS): Remove.
1467 (buffer_get_intervals, buffer_set_intervals): New function.
1468 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
1469 * intervals.c, textprop.c: Adjust users.
1470
ad8c997f
DA
14712012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1472
1473 Inline functions to examine and change string intervals.
1474 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
1475 (string_get_intervals, string_set_intervals): New function.
1476 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1477 * lread.c, print.c, textprop.c: Adjust users.
1478
32ac3a6b
GM
14792012-08-08 Glenn Morris <rgm@gnu.org>
1480
1481 * lisp.mk (lisp): Remove language/persian.elc.
1482
77c7bcb1
DA
14832012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1484
1485 Cleanup intervals.
1486 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
1487 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
1488 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
1489 Adjust comment. Move under #if 0.
77c7bcb1
DA
1490 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1491 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
1492
9c08a8d4
DA
14932012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1494
1495 Check total length of intervals with eassert.
1496 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
1497 * intervals.c: Change all users to eassert.
1498
26d16b35
EZ
14992012-08-07 Eli Zaretskii <eliz@gnu.org>
1500
14ae4239
BT
1501 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
1502 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
1503 INTERNAL_FIELD in Lisp_Cons.
1504
c644523b
DA
15052012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1506
1507 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
1508 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
1509 name since all xname users are fixed long time ago. Do not
1510 use INTERNAL_FIELD.
1511 (set_symbol_name, set_symbol_function, set_symbol_plist):
1512 (set_symbol_next, set_overlay_plist): New function.
1513 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
1514 (struct Lisp_Overlay): Likewise.
1515 (CVAR, MVAR, SVAR): Remove.
1516 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
1517 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
1518 * xterm.c: Adjust users.
1519 * .gdbinit: Change to use name field of struct Lisp_Symbol
1520 where appropriate.
1521
6a3d20cc
DA
15222012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1523
1524 Basic functions to set Lisp_Object and pointer slots of intervals.
1525 * intervals.h (interval_set_parent, interval_set_object):
1526 (interval_set_left, interval_set_right, interval_set_plist):
1527 (interval_copy_parent): New function.
1528 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
1529 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
1530 Adjust indentation.
6a3d20cc
DA
1531 (INTERVAL_SIZE): Remove. Adjust users.
1532 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
1533
4d2b044c
DA
15342012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
1537 * process.h (PGET): Remove.
1538 (struct Lisp_Process): Do not use INTERNAL_FIELD.
1539 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1540
d3d50620
DA
15412012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1542
1543 Drop WGET and revert read access to Lisp_Objects slots of struct window.
1544 * window.h (WGET): Remove.
1545 (struct window): Do not use INTERNAL_FIELD.
1546 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1547 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1548 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1549 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1550 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1551 Adjust users.
1552
d10a51dc
CY
15532012-08-07 Chong Yidong <cyd@gnu.org>
1554
1555 * window.c (Fwindow_edges, Fwindow_pixel_edges)
1556 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
1557 (Fdelete_window_internal): Signal an error if the window is not on
1558 a live frame (Bug#12025).
1559
e69b0960
DA
15602012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1561
1562 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
1563 * frame.h (FGET): Remove.
1564 (struct frame): Do not use INTERNAL_FIELD.
1565 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1566 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1567 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1568 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1569
25a20a3a
JB
15702012-08-06 Juanma Barranquero <lekktu@gmail.com>
1571
1572 * w32.c: Silence compiler warnings.
1573 (map_w32_filename): Remove unused variable `is_fat'.
1574 (chase_symlinks): Add parentheses around expression.
1575
1c6f11f4
GM
15762012-08-06 Glenn Morris <rgm@gnu.org>
1577
1db4583a
GM
1578 * sysdep.c: Respect BROKEN_GETWD.
1579
1c6f11f4
GM
1580 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
1581 Let configure handle it.
1582 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
1583
2b90362b
DA
15842012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1585
1586 Use GCALIGNMENT where appropriate.
1587 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
1588 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
1589 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
1590
5f50daf2
EZ
15912012-08-06 Eli Zaretskii <eliz@gnu.org>
1592
14ae4239
BT
1593 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
1594 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 1595
cbcc7007
SM
15962012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
1597
1598 * buffer.h (struct buffer): Revert `indirections' to a simple int;
1599 that should be sufficient for everyone.
1600
4d365fa4
JD
16012012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1602
1603 * keyboard.c (timer_check_2): Add break so timer_check returns next
1604 timeout.
1605
dd86bd82
DA
16062012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1607
1608 Fix Windows build errors introduced after converting to WGET and WSET.
1609 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
1610 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1611
054e1668
JD
16122012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1613
1614 * nsterm.m (ns_frame_rehighlight): Use FSET.
1615
1616 * nsmenu.m (ns_update_menubar): Use FSET.
1617
21238f11
DA
16182012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1619
1620 Separate read and write access to Lisp_Object slots of Lisp_Process.
1621 * process.h (PGET, PSET): New macros similar to AREF and ASET.
1622 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1623
077288cf
DA
16242012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1625
1626 Separate read and write access to Lisp_Object slots of struct window.
1627 * window.h (WGET, WSET): New macros similar to AREF and ASET.
1628 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1629 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1630 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1631 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1632 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1633 Adjust users.
1634
71688bd7
DA
16352012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1636
1637 Fix Windows build errors introduced after converting to FGET and FSET.
1638 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
1639 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
1640 (w32_judge_scroll_bars): Change to use FSET.
1641 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1642
f99bac93
DA
16432012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1644
1645 Fix replacement typo.
1646 * window.c (replace_window): Set root_window instead of
1647 selected_window. This fixes a total window subsystem
1648 malfunction reported by Bastien Guerry <bzg@gnu.org>.
1649
8c2a0f2d
GM
16502012-08-06 Glenn Morris <rgm@gnu.org>
1651
1652 * lisp.mk (lisp): Add language/persian.elc.
1653
edd74c35
DA
16542012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1655
1656 Separate read and write access to Lisp_Object slots of struct frame.
1657 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
1658 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1659 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1660 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1661 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1662
8671676c
AS
16632012-08-05 Andreas Schwab <schwab@linux-m68k.org>
1664
1665 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
1666
663e2b3f
DA
16672012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1668
1669 Generalize common compile-time constants.
1670 * lisp.h (header_size, bool_header_size, word_size): Now here.
1671 (struct Lisp_Vector): Add comment.
1672 (struct Lisp_Bool_Vector): Move up to define handy constants.
1673 (VECSIZE, PSEUDOVECSIZE): Simplify.
1674 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
1675 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
1676 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
1677 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
1678 * xfont.c, xmenu.c: Use word_size where appropriate.
1679
d32e47af
LM
16802012-08-05 Lawrence Mitchell <wence@gmx.li>
1681
1682 * search.c (Freplace_match): Treat \? in the replacement text
1683 literally (Bug#8161).
1684
e5d9c0d1
CY
16852012-08-05 Chong Yidong <cyd@gnu.org>
1686
1687 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
1688 * frame.c (Vdelete_frame_functions):
1689 * emacs.c (Vkill_emacs_hook): Doc fix.
1690
8da0576b
EZ
16912012-08-04 Eli Zaretskii <eliz@gnu.org>
1692
1693 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
1694 --with-x-toolkit=no builds.
1695 Reported by Carsten Mattner <carstenmattner@gmail.com>.
1696
02676e5d
CY
16972012-08-04 Chong Yidong <cyd@gnu.org>
1698
1699 * syntax.c (Fmodify_syntax_entry): Doc fix.
1700
97147da9
EZ
17012012-08-04 Eli Zaretskii <eliz@gnu.org>
1702
76151e2c
EZ
1703 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
1704 * w32.c (init_environment): Change the default values of many
1705 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
1706 them into environment when they were not already defined.
1707 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 1708 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
1709 (check_windows_init_file): Now external, not static.
1710 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
1711 called when Vload_path is already set up.
1712
1713 * w32.h (check_windows_init_file): Add prototype.
1714
1715 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
1716 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
1717 compatibility with Posix platforms.
1718 (main): Move the call to check_windows_init_file to here from
1719 w32.c.
1720 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
1721 any, in the DEFALT argument into the root of the Emacs build or
1722 installation tree, as appropriate.
1723
1724 * callproc.c (init_callproc_1): Call decode_env_path instead of
1725 doing its equivalent by hand.
1726 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
1727 the code that sets Vexec_path run on MS-Windows.
1728
1729 * lread.c (init_lread): Add comments to #ifdef's.
1730
97147da9
EZ
1731 * msdos.c (dos_set_window_size, IT_update_begin)
1732 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
1733 instead of direct references.
1734
185ee146
PE
17352012-08-04 Paul Eggert <eggert@cs.ucla.edu>
1736
1737 Export DEFAULT_REHASH_* to GDB.
1738 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
1739 Now constants, not macros.
1740
8834c57a
PE
17412012-08-03 Paul Eggert <eggert@cs.ucla.edu>
1742
98c6f1e3
PE
1743 Remove unnecessary casts involving pointers.
1744 These casts are no longer needed now that we assume C89 or later,
1745 since they involve casting to or from void *.
1746 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
1747 (make_pure_float, make_pure_vector):
1748 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
1749 * macros.c (Fstart_kbd_macro):
1750 * menu.c (find_and_return_menu_selection):
1751 * minibuf.c (read_minibuf_noninteractive):
1752 * sysdep.c (closedir):
1753 * xdisp.c (x_produce_glyphs):
1754 * xfaces.c (compare_fonts_by_sort_order):
1755 * xfns.c (x_real_positions, select_visual):
1756 * xselect.c (x_stop_queuing_selection_requests)
1757 (x_get_window_property, x_get_window_property_as_lisp_data):
1758 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
1759 Remove unnecessary pointer casts.
1760 * alloc.c (record_xmalloc): New function.
1761 * lisp.h (record_xmalloc): New decl.
1762 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
1763 more like a function. This is because the pointer cast is not
1764 needed. All uses changed.
1765 * print.c (print_string, print_error_message): Avoid length recalc.
1766
8834c57a
PE
1767 Improve fix for macroexp crash with debugging (Bug#12118).
1768 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
1769 ARRAY_MARK_FLAG when checking subscripts, because ASET is
1770 not supposed to be invoked from the garbage collector.
1771 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
1772 (gc_aset): New function, which is like ASET but can be
1773 used in the garbage collector.
1774 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1775 (set_hash_index): Use it instead of ASET.
1776
6dad7178
EZ
17772012-08-03 Eli Zaretskii <eliz@gnu.org>
1778
1779 Support symlinks on latest versions of MS-Windows.
1780 * w32.c: Include winioctl.h and aclapi.h.
1781 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
1782 (revert_to_self): Forward declarations of static functions.
1783 <static BOOL g_b_init_get_security_info>:
1784 <g_b_init_create_symbolic_link>: New static flags.
1785 (globals_of_w32): Initialize them to zero.
1786 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
1787 (map_w32_filename): Improve commentary. Simplify switch.
1788 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
1789 headers (most versions of MinGW w32api don't).
1790 (get_security_info, create_symbolic_link)
1791 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
1792 New functions.
1793 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
1794 in the argument file name.
1795 (sys_access): Call unc_volume_file_attributes only if
1796 GetFileAttributes fails with network-related error codes.
1797 (sys_rename): Diagnose renaming of a symlink when the user doesn't
1798 have the required privileges.
14ae4239 1799 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
1800 get_file_security_desc.
1801 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
1802 with addition of handling of symlinks and support for 'lstat'.
1803 If possible, get file's attributes and security information by
6dad7178
EZ
1804 handle, not by name. Produce S_IFLNK bit for symlinks, when
1805 called from 'lstat'.
1806 (stat, lstat): New functions, call 'stat_worker'.
1807 (symlink, readlink, careadlinkat): Rewritten to create and resolve
1808 symlinks when the underlying filesystem supports them.
1809
f162bcc3
PE
18102012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1811
79ea6c20
PE
1812 Fix macroexp crash on Windows with debugging (Bug#12118).
1813 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
1814 checking subscripts; problem introduced with the recent
1815 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
1816 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
1817 since it's used in non-static inline functions now.
1818
c0ce93fd
PE
1819 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
1820 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 1821
f162bcc3
PE
1822 Use C99-style 'extern inline' if available.
1823 * buffer.h (BUFFER_INLINE):
1824 * category.h (CATEGORY_INLINE):
1825 * character.h (CHARACTER_INLINE):
1826 * charset.h (CHARSET_INLINE):
1827 * composite.h (COMPOSITE_INLINE):
1828 * dispextern.h (DISPEXTERN_INLINE):
1829 * lisp.h (LISP_INLINE):
1830 * systime.h (SYSTIME_INLINE):
1831 New macro, replacing 'static inline' in this header.
1832 * buffer.h, category.h, character.h, charset.h, composite.h:
1833 * dispextern.h, lisp.h, systime.h:
1834 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1835 * alloc.c (LISP_INLINE):
1836 * buffer.c (BUFFER_INLINE):
1837 * category.c (CATEGORY_INLINE):
1838 * character.c (CHARACTER_INLINE):
1839 * charset.c (CHARSET_INLINE):
1840 * composite.c (COMPOSITE_INLINE):
1841 * dispnew.c (DISPEXTERN_INLINE):
1842 * sysdep.c (SYSTIME_INLINE):
1843 Define to EXTERN_INLINE, so that the corresponding functions
1844 are compiled into code.
1845 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
1846 (INLINE_HEADER_END): New macros.
1847 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
1848 since it's used in non-static inline functions now.
a8333d03 1849 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 1850
837b365b
GM
18512012-08-02 Glenn Morris <rgm@gnu.org>
1852
d66b744d
GM
1853 * s/: Remove empty directory.
1854
837b365b
GM
1855 * s/ms-w32.h: Move to ../nt/inc.
1856 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
1857 Update for new ms-w32.h location.
1858
13294f95
PE
18592012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1860
1861 Port to Solaris 8.
1862 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
1863
90df0db3
GM
18642012-08-02 Glenn Morris <rgm@gnu.org>
1865
1866 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
1867 hard-coding the path separator.
1868
4939150c
PE
18692012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1870
1871 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
1872 This how ASET and AREF are supposed to work, and makes
1873 it easier to think about future improvements. See
1874 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
1875 * charset.h (set_charset_attr): New function.
1876 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
1877 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
1878 (aref_addr): New function. All uses of &AREF(...) changed.
1879 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1880 (set_hash_index): New functions. All lvalue-style uses of
1881 HASH_KEY etc. changed.
1882 * keyboard.c (set_prop): New function. All lvalue-style uses
1883 of PROP changed.
1884
947b2afd
AA
18852012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
1886
1887 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
1888 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1889 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
1890 * nsfns.m (ns_set_name_as_filename): Likewise.
1891 * nsmenu.m (ns_update_menubar): Likewise.
1892 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
1893
4f5d0325
EZ
18942012-08-01 Eli Zaretskii <eliz@gnu.org>
1895
2008beae
EZ
1896 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
1897 Adapt to latest changes in field names of the corresponding Lisp
288479f6 1898 objects.
2008beae 1899
4f5d0325
EZ
1900 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
1901
fe3cc771
GM
19022012-08-01 Glenn Morris <rgm@gnu.org>
1903
1904 * s/msdos.h: Remove file.
1905 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
1906 * Makefile.in (S_FILE): Remove.
1907 (config_h): Remove S_FILE.
1908
c90acc54
JB
19092012-08-01 Juanma Barranquero <lekktu@gmail.com>
1910
1911 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
1912 Remove; moved to nt/config.nt.
1913
d8a05828
DA
19142012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1915
1916 Use INTERNAL_FIELD for conses and overlays.
1917 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
1918 Remove obsolete comment.
1919 (MVAR): New macro.
1920 (struct Lisp_Overlay): Use INTERNAL_FIELD.
1921 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
1922
8271d590
DA
19232012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1924
1925 Use INTERNAL_FIELD for symbols.
1926 * lisp.h (SVAR): New macro. Adjust users.
1927 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
1928 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
1929
3193acd2
DA
19302012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1931
1932 Use INTERNAL_FIELD for processes.
1933 * process.h (PVAR): New macro. Adjust style.
1934 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
1935 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
1936
3a45383a
DA
19372012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1938
1939 Use INTERNAL_FIELD for windows.
1940 * window.h (WVAR): New macro.
1941 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
1942 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1943 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1944 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
1945 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
1946 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1947
c1dbc63c
PE
19482012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
1951
5c0c0e8a
GM
19522012-08-01 Glenn Morris <rgm@gnu.org>
1953
1954 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
1955 Move to configure.ac.
1956
552a99b4
JB
19572012-08-01 Juanma Barranquero <lekktu@gmail.com>
1958
1959 * makefile.w32-in (CONFIG_H): Update dependencies.
1960 (CONF_POST_H): New macro.
1961
1962 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
1963
8d8e2dfe
GM
19642012-07-31 Glenn Morris <rgm@gnu.org>
1965
bc96620a
GM
1966 * Makefile.in (S_FILE): No longer set by configure.
1967
476b1b2d
GM
1968 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
1969 is available.
1970 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
1971
b2c7a106
GM
1972 * process.h (NULL_DEVICE):
1973 * emacs.c (SEPCHAR):
1974 * editfns.c (USER_FULL_NAME): Let configure set them.
1975
d53d062a
GM
1976 * s/README, s/template.h: Remove files.
1977
4515017f
GM
1978 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
1979
8d8e2dfe
GM
1980 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
1981 Move to configure.ac.
1982
5b20b3cc
EZ
19832012-07-31 Eli Zaretskii <eliz@gnu.org>
1984
1e0afd9a
EZ
1985 * .gdbinit (xframe): Adapt to introduction of FVAR and the
1986 resulting renaming of 'struct frame' members.
1987
5b20b3cc
EZ
1988 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
1989
1990 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
1991 after introduction of FVAR.
1992
f1310128
JD
19932012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1994
79e721e0
JD
1995 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
1996
1997 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
1998 instead of compositeToPoint.
1999 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
2000
8d7c7eed 2001 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 2002
e34f7f79
DA
20032012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2004
2005 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
2006 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 2007 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
2008 (BVAR): Change to use INTERNAL_FIELD.
2009 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
2010 (KVAR): Change to use INTERNAL_FIELD.
2011 * frame.h (FVAR): New macro.
2012 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
2013 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
2014 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
2015 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
2016 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
2017
c09bfb2f
DA
20182012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2019
2020 Miscellaneous fixes for non-default X toolkits.
2021 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
2022 * xterm.c (x_frame_of_widget): Remove redundant prototype.
2023 Move under #ifdef USE_LUCID.
2024 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
2025 definition and usage to avoid warnings.
2026
14c114ae
JD
20272012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2028
2029 * nsterm.m (openFiles): Fix previous checkin.
2030
3bd21e82
PE
20312012-07-31 Paul Eggert <eggert@cs.ucla.edu>
2032
2033 * indent.c (compute_motion): Remove unused local.
2034
c1529ded
GM
20352012-07-31 Glenn Morris <rgm@gnu.org>
2036
400d5621
GM
2037 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
2038
268e2432
GM
2039 * conf_post.h [USG5_4]:
2040 Move remaining contents of s/usg5-4-common.h here.
2041 * s/usg5-4-common.h: Remove file.
2042
7552f3ee
GM
2043 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
2044 * s/irix6-5.h: Remove file.
2045
6a381852
GM
2046 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
2047 * s/darwin.h: Remove file.
2048
c1529ded
GM
2049 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
2050 * s/hpux10-20.h: Remove file, which is now empty.
2051
b429a4ee
GM
20522012-07-30 Glenn Morris <rgm@gnu.org>
2053
2054 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
2055 * Makefile.in (config_h): Add conf_post.h.
2056 * makefile.w32-in (CONFIG_H): Add conf_post.h.
2057
adff3182
JD
20582012-07-30 Jan Djärv <jan.h.d@swipnet.se>
2059
2060 * nsterm.m (ns_do_open_file): New variable.
b9031d69 2061 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
2062 (openFile, openTempFile, openFileWithoutUI, openFiles):
2063 Open files only if ns_do_open_file.
adff3182 2064
c32af1e4
PE
20652012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2066
7393bcbb
PE
2067 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
2068 This no-op macro hasn't been needed for many years.
2069 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
2070
c32af1e4
PE
2071 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
2072 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
2073 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
2074 gdb_make_enums_visible.
2075 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
2076 (DIRECTORY_SEP): Now a constant, not a macro.
2077
302fc036
EZ
20782012-07-30 Eli Zaretskii <eliz@gnu.org>
2079
2080 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
2081 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
2082
2083 * w32term.c <w32_keyboard_codepage>: Renamed from
2084 keyboard_codepage and now external. All users changed.
2085
2086 * w32term.h: Add declaration of w32_keyboard_codepage.
2087
2088 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
2089 the codepage to translate keys to Unicode. If this argument is
2090 -1, use the value returned by GetConsoleCP. All callers changed.
2091
88fb40b4
PE
20922012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2093
0aee6912
PE
2094 Update .PHONY listings in makefiles.
2095 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
2096 bootstrap-clean, distclean, maintainer-clean, versioclean,
2097 extraclean, frc.
2098
88fb40b4
PE
2099 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
2100 This is a bit clearer. Fix some commentary typos.
2101
0a763bd1
GM
21022012-07-30 Glenn Morris <rgm@gnu.org>
2103
32bac6d6
GM
2104 * s/netbsd.h: Let configure include signal.h if needed.
2105 Remove file, which is now empty.
2106
b65e7c46
GM
2107 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
2108 Let configure set them.
2109 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
2110 No more need to undefine.
0a763bd1 2111
169304bd
AS
21122012-07-30 Andreas Schwab <schwab@linux-m68k.org>
2113
2114 * keymap.c (Fkey_description): Don't remove 0x80 bit from
2115 non-single-byte char when adding meta modifier. (Bug#12090)
2116
6cd7a139
DA
21172012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2118
2119 Convert safe_call to use variable number of arguments.
2120 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
2121 (safe_call2): Fix comment.
2122 * lisp.h (safe_call): Adjust prototype.
2123 * coding.c (encode_coding_object): Change to use safe_call2.
2124 * xfaces.c (merge_face_heights): Change to use safe_call1.
2125
d34d6ffc
GM
21262012-07-30 Glenn Morris <rgm@gnu.org>
2127
7b8a48e4 2128 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 2129 does that unconditionally. Remove file, which is now empty.
7b8a48e4 2130
d34d6ffc
GM
2131 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
2132 Remove empty files.
2133
03a660a6
PE
21342012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2135
2136 Export to GDB most of lisp.h's remaining object-like macros.
2137 * lisp.h (min, max): Move earlier, because they're used earlier now.
2138 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
2139 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
2140 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
2141 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
2142 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
2143 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
2144 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
2145 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
2146 Now constants, for GDB. They need not be macros.
2147 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
2148 Now constants, for GDB, as well as macros, for static initializers.
2149 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
2150 Move to after the definition of struct Lisp_Char_Table,
2151 since the former now needs that type defined.
2152 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
2153 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
2154 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
2155 New enums, for gdb_make_enums_visible.
2156 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 2157 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
2158 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
2159 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
2160 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
2161 enum maxargs, enum MAX_ALLOCA.
2162 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
2163 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
2164 no longer needed, now that they are done in lisp.h.
2165
e499d0ee
DA
21662012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2167
2168 Cleanup string bytes checking.
2169 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
2170 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
2171 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
2172 (check_sblock, compact_small_strings): Simplify.
2173
d5040d2d
PE
21742012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2175
2176 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
2177 These macros are confusing and no longer need to be defined, as
2178 the enum values now suffice. All uses replaced with definiens.
2179 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
2180
7f259ae6
JB
21812012-07-29 Juanma Barranquero <lekktu@gmail.com>
2182
2183 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
2184 ($(BLD)/w32console.$(O)): Update dependencies.
2185
7e63e0c3
DA
21862012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2187
2188 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
2189 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
2190 time. Adjust users.
2191 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
2192
ffd817eb
JD
21932012-07-29 Jan Djärv <jan.h.d@swipnet.se>
2194
2195 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
2196 setting sitelisp (Bug#12010).
2197
417a7a0e
EZ
21982012-07-29 Eli Zaretskii <eliz@gnu.org>
2199
14ae4239 2200 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
2201
2202 * w32heap.c (cache_system_info):
2203 * w32.c (sys_rename):
2204 * w32proc.c (find_child_console, sys_kill): All users changed.
2205
387d4d92
PE
22062012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2207
2208 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
2209
55a6cca6
EZ
22102012-07-29 Eli Zaretskii <eliz@gnu.org>
2211
2212 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
2213
dbcf001c
DA
22142012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2215
2216 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
2217 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
2218 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 2219
e2688e4a
DA
22202012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2221
2222 Generalize marker debugging code under MARKER_DEBUG and use eassert.
2223 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
2224 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
2225 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
2226 (replace_range, replace_range_2, del_range_2): Change to eassert.
2227 * marker.c (byte_char_debug_check): Adjust style.
2228
b46a6a83
PE
22292012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
2232 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
2233 long-ago-commented-out code that talks about "WIN32".
2234 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
2235 All uses changed.
2236
e32a5799
PE
22372012-07-28 Paul Eggert <eggert@cs.ucla.edu>
2238
2239 Use Gnulib stdalign module (Bug#9772, Bug#9960).
2240 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
2241 Simplify by using alignof.
2242 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
2243 * lisp.h: Include <stdalign.h>.
2244 (GCALIGNMENT): New macro and constant.
2245 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
2246 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
2247 (stdalign): New macro, if not already defined.
2248
df81cd29
EZ
22492012-07-28 Eli Zaretskii <eliz@gnu.org>
2250
01bd1b0d
EZ
2251 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
2252 * w32inevt.c: Include w32inevt.h.
2253 (w32_read_console_input): New inline function, calls either
2254 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
2255 w32_console_unicode_input.
2256 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
2257 (w32_kbd_patch_key, key_event): Use the codepage returned by
2258 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
2259 (key_event): use uChar.UnicodeChar only if
2260 w32_console_unicode_input is non-zero.
2261
2262 * w32console.c: Include w32heap.h.
2263 <w32_console_unicode_input>: New global variable.
2264 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
2265 family of Windows, zero otherwise.
2266
2267 * w32inevt.h: Declare w32_console_unicode_input.
2268
df81cd29
EZ
2269 * xdisp.c (init_iterator): Don't reference tip_frame in a build
2270 --without-x. (Bug#11742)
2271
c20fdd9e
PE
22722012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2273
2274 Adjust GDB to reflect pvec_type changes (Bug#12036).
2275 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
2276 2012-07-04 changes to pseudovector representation.
2277 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 2278
32770973 22792012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
2280
2281 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
2282 bus address.
2283 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
2284
3438fe21
EZ
22852012-07-27 Eli Zaretskii <eliz@gnu.org>
2286
bcfbc9de
EZ
2287 * alloc.c (listn): Fix the order the arguments are consed onto the
2288 list.
2289
3438fe21
EZ
2290 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
2291 enumeration constants, as PURE and HEAP are too general, and clash
2292 with other headers and sources, such as gmalloc.c and the
2293 MS-Windows system headers. All users changed.
2294
eeaea515
DA
22952012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2296
2297 Revert last save_excursion_save and save_excursion_restore changes.
2298 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
2299 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
2300
073c88c2
DA
23012012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2302
2303 Fix recently-introduced typos in Windows port.
2304 Reported by Martin Rudalics <rudalics@gmx.at>.
2305 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 2306 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 2307
4706125e
PE
23082012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2309
2310 Improve GDB symbol export (Bug#12036).
2311 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
2312 arms of an 'if', not using conditional expressions; otherwise GDB
2313 complains about the types in the unevaluated arm when the argument
2314 is an integer literal.
2315 (xgetint): Simplify expression.
2316 * alloc.c (gdb_make_enums_visible): New constant. This ports to
2317 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
2318 Zaretskii in <http://bugs.gnu.org/12036#13>.
2319 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
2320 needed now that we have gdb_make_enums_visible.
2321 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
2322 (enum enum_USE_LSB_TAG):
2323 New enum types, packaging up enums that need to be exported to GDB.
2324
694b6c97
DA
23252012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2326
2327 Utility function to make a list from specified amount of objects.
2328 * lisp.h (enum constype): New datatype.
2329 (listn): New prototype.
2330 * alloc.c (listn): New function.
2331 (Fmemory_use_count, syms_of_alloc): Use it.
2332 * buffer.c (syms_of_buffer): Likewise.
2333 * callint.c (syms_of_callint): Likewise.
2334 * charset.c (define_charset_internal): Likewise.
2335 * coding.c (syms_of_coding): Likewise.
2336 * keymap.c (syms_of_keymap): Likewise.
2337 * search.c (syms_of_search): Likewise.
2338 * syntax.c (syms_of_syntax): Likewise.
2339 * w32.c (init_environment): Likewise.
2340 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
2341 * xdisp.c (syms_of_xdisp): Likewise.
2342 * xfns.c (syms_of_xfns): Likewise.
2343
6195f384
DA
23442012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2345
2346 Fast save_excursion_save and save_excursion_restore.
2347 * lisp.h (struct Lisp_Excursion): New data type.
2348 (PVEC_EXCURSION): New pseudovector type.
2349 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
2350 to deal with it. Adjust comments.
2351 (init_marker, attach_marker): New prototype.
2352 (unchain_marker): Adjust prototype.
2353 * marker.c (attach_marker): Change to global.
2354 (init_marker): New function.
2355 * alloc.c (Fmake_marker, build_marker): Use it.
2356 (build_marker): More easserts.
2357 (mark_object): Handle struct Lisp_Excursion.
2358 * editfns.c (save_excursion_save, save_excursion_restore):
2359 Reimplement to use struct Lisp_Excursion. Add comments.
2360
5eceb8fb
PE
23612012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2362
2363 Fix export of symbols to GDB (Bug#12036).
2364 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
2365 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
2366 emacs.c, as this is a more-suitable home. Had this been done earlier
2367 the fix for 12036 would have avoided some of the problems noted in
2368 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
2369 would have been more obvious.
562157c8
PE
2370 * emacs.c: Do not include <verify.h>; no longer needed.
2371 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
2372 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
2373 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2374 Remove; now done in lisp.h.
2375 * lisp.h (PUBLISH_TO_GDB): New macro.
2376 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
2377 (DATA_SEG_BITS): Use it.
2378 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
2379 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
2380 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
2381 not be usable in #if. This simplifies things.
2382
d6749401
JB
23832012-07-26 Juanma Barranquero <lekktu@gmail.com>
2384
2385 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
2386
1781b9e9
PE
23872012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2388
d89518db 2389 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
2390 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
2391 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
2392 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
2393 Adjust to changes in lisp.h and emacs.c, by using
2394 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
2395 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
2396 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
2397 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
2398 instead of gdb_valbits.
2399 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
2400 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
2401 instead of gdb_array_mark_flag.
2402 (xboolvector): Get size from $->size, not $->header.size.
2403 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
2404 (xreload, hook-run, hookpost-run): Remove.
2405 * emacs.c: Include <verify.h>.
2406 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
2407 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
2408 Remove.
2409 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
2410 (gdb_USE_LSB_TAG): New enum constants.
2411 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2412 Also define these as enum constants, so they're visible to GDB.
2413 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
2414 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
2415 as constants, so they're visible to GDB.
2416 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
2417 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
2418 Now enum constants, not macros, so they're visible to GDB.
2419 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
2420 more convenient now. All uses changed.
2421 (VALMASK) [USE_LSB_TAG]: Also define in this case.
2422 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
2423
3628596a
DA
24242012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
2425
2426 Explicitly free restriction data that are not needed anymore.
2427 * editfns.c (save_restriction_restore): Free restriction data.
2428
7abaf5cc
SM
24292012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2430
2431 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
2432 add argument, tune behavior, and adjust all callers.
2433
71f88e00
PE
24342012-07-25 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 Use typedef for EMACS_INT, EMACS_UINT.
2437 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
2438 than macros. This simplifies debugging in the usual case, since
2439 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
2440 and it allows expressions involving EMACS_INT casts.
2441 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
2442
57ec3034
JD
24432012-07-25 Jan Djärv <jan.h.d@swipnet.se>
2444
2445 * nsterm.m (ns_read_socket): Return early if there is a modal
2446 window (Bug#12043).
2447
8137e7b3
MR
24482012-07-25 Martin Rudalics <rudalics@gmx.at>
2449
2450 * frame.c (Fredirect_frame_focus): In doc-string don't mention
2451 that FOCUS-FRAME can be omitted.
2452
04e9897c
DA
24532012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
2454
2455 Adjust buffer text indirection counters at the end of Fkill_buffer.
2456 * buffer.c (Fkill_buffer): Adjust indirection counters when the
2457 buffer is definitely dead. This should really fix an issue reported
2458 by Christoph Scholtes again. (Bug#12007).
2459 (init_buffer_once): Initialize indirection counters of
2460 buffer_defaults and buffer_local_symbols (for sanity and safety).
2461
8a0484e1
EZ
24622012-07-24 Eli Zaretskii <eliz@gnu.org>
2463
2464 * xdisp.c (init_iterator): Don't compute dimensions of truncation
2465 and continuation glyphs on tooltip frames, leave them at zero.
2466 Avoids continued lines in tooltips. (Bug#11832)
2467
fa691a83
DA
24682012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
2469
2470 Simplify copy_overlay.
04e9897c 2471 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
2472 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
2473
436bc8e0
EZ
24742012-07-23 Eli Zaretskii <eliz@gnu.org>
2475
2476 * print.c (print_object): Don't crash when a frame's name is nil
2477 or invalid. (Bug#12025)
2478
2479 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
2480 it signals an error when a tooltip frame is being created.
2481
d7a7fda3
DA
24822012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
2483
2484 Cleanup miscellaneous objects allocation and initialization.
2485 * alloc.c (allocate_misc): Change to static. Add argument to
2486 specify the subtype. Adjust comment and users.
2487 (build_overlay): New function.
2488 * buffer.c (copy_overlays, Fmake_overlay): Use it.
2489 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
2490 (allocate_misc): Remove prototype.
2491 (build_overlay): Add prototype.
2492
24932012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
2494
2495 Swap buffer text indirection counters in Fbuffer_swap_text.
2496 * buffer.c (Fbuffer_swap_text): Swap indirections too.
2497 This avoids crash reported by Christoph Scholtes at
2498 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
2499
9d7fa573
JD
25002012-07-22 Jan Djärv <jan.h.d@swipnet.se>
2501
2502 * nsmenu.m (Popdown_data): New struct.
2503 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
2504 free Popdown_data.
2505 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
2506 (initWithContentRect): Make imgView and contentView non-static
2507 and autorelease them. Also autorelease img and matrix (Bug#12005).
2508 (dealloc): Remove (Bug#12005).
2509
0dd6d66d
DA
25102012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2511
2512 Adjust consing_since_gc when objects are explicitly freed.
2513 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
2514 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
2515 (free_cons, free_misc): Subtract object size from consing_since_gc.
2516
d36d71df
DA
25172012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2518
2519 Simplify and cleanup markers positioning code.
2520 * marker.c (attach_marker): More useful eassert.
2521 (live_buffer, set_marker_internal): New function.
2522 (Fset_marker, set_marker_restricted): Use set_marker_internal.
2523 (set_marker_both, set_marker_restricted_both): Use live_buffer.
2524
fb9ea40f
PE
25252012-07-22 Paul Eggert <eggert@cs.ucla.edu>
2526
2527 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
2528 as it's limited by the amount of memory, not by INT_MAX.
2529
2d5c5f7d
EZ
25302012-07-21 Eli Zaretskii <eliz@gnu.org>
2531
07fb592e
EZ
2532 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
2533 in special-event-map. See the discussion at
2534 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
2535 for the reasons.
2536
37a9eac8 2537 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
2538 info.dwItemData. Fixes crashes on 64-bit Windows.
2539 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 2540
c4328746
JD
25412012-07-21 Jan Djärv <jan.h.d@swipnet.se>
2542
2543 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 2544 (conversationIdentifier): Return value is NSInteger.
784051c4 2545 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 2546
6e5d1c12
CY
25472012-07-21 Chong Yidong <cyd@gnu.org>
2548
2549 * window.c (decode_any_window): Signal an error if the window is
2550 on a dead frame (Bug#11984).
2551
9928463d
DA
25522012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2553
2554 Add indirection counting to speed up Fkill_buffer.
2555 * buffer.h (struct buffer): New member.
2556 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
2557 (Fmake_indirect_buffer): Set indirection counter to -1, increment
2558 base buffer indirection counter.
2559 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
2560 (Fkill_buffer): Adjust indirection counters as needed, don't walk
2561 through buffer list if indirection counter is 0.
2562
f8643a6b
DA
25632012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2564
2565 Extend the value returned by Fgarbage_collect with heap statistics.
2566 * alloc.c (Qheap): New symbol.
2567 (syms_of_alloc): DEFSYM it.
2568 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
2569 (Fmemory_free): Remove.
2570 (syms_of_alloc): Don't defsubr it.
2571 * buffer.c (Fcompact_buffer): Remove.
2572 (syms_of_buffer): Don't defsubr it.
2573
dac616ff
DA
25742012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2575
2576 Make maybe_gc inline.
2577 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
2578 * lisp.h (consing_since_gc, gc_relative_threshold)
2579 (memory_full_cons_threshold): Revert declaration.
2580 (maybe_gc): Remove prototype, define as inline.
2581 * alloc.c: Remove old commented-out code.
2582 (consing_since_gc, gc_relative_threshold)
2583 (memory_full_cons_threshold): Revert to global.
2584 (maybe_gc): Remove.
2585
d7ea76b4
DA
25862012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2587
2588 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
2589 * lisp.h (build_unibyte_string): New function.
2590 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
2591 * sysdep.c, w32fns.c, xfns.c: Use it.
2592 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
2593 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
2594 Adjust users accordingly.
2595 * font.h (font_open_by_name): Adjust prototype.
2596
765e61e3
DA
25972012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2598
2599 Cleanup calls to Fgarbage_collect.
2600 * lisp.h (maybe_gc): New prototype.
2601 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2602 Remove declarations.
2603 * alloc.c (maybe_gc): New function.
2604 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2605 Make them static.
2606 * bytecode.c (MAYBE_GC): Use maybe_gc.
2607 * eval.c (eval_sub, Ffuncall): Likewise.
2608 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
2609 to avoid dependency from auto-save feature.
2610
52b852c7
PE
26112012-07-19 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
2614 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
2615 'for_each_per_buffer_object_at'.
2616 All uses changed. It's better to use upper-case for macros that
2617 cannot be implemented as functions, to give the reader a clue
2618 that they're special.
2619
5db81e33
SM
26202012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
2621
2622 * alloc.c (Fgarbage_collect): Tweak docstring.
2623
5b835e1d
DA
26242012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2625
2626 Tweak the value returned from Fgarbage_collect again.
2627 * alloc.c (Fgarbage_collect): New return value, as confirmed in
2628 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
2629 Adjust documentation.
2630 (total_vector_bytes): Rename to total_vector_slots, adjust
2631 accounting.
2632 (total_free_vector_bytes): Rename to total_free_vector_slots,
2633 adjust accounting.
2634 (Qstring_bytes, Qvector_slots): New symbols.
2635 (syms_of_alloc): DEFSYM them.
2636
9cd47b72
DA
26372012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2638
2639 Buffer compaction primitive which may be used from Lisp.
2640 * buffer.c (compact_buffer, Fcompact_buffer): New function.
2641 (syms_of_buffer): Register Fcompact_buffer.
2642 * alloc.c (Fgarbage_collect): Use compact_buffer.
2643 * buffer.h (compact_buffer): New prototype.
2644 (struct buffer_text): New member.
2645
d17337e5
DA
26462012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2647
2648 New macro to iterate over all buffers, miscellaneous cleanups.
2649 * lisp.h (all_buffers): Remove declaration.
2650 * buffer.h (all_buffers): Add declaration, with comment.
2651 (for_each_buffer): New macro.
2652 * alloc.c (Fgarbage_collect, mark_object): Use it.
2653 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
2654 (init_buffer): Likewise.
2655 * data.c (Fset_default): Likewise.
2656 * coding.c (code_conversion_restore): Remove redundant check
2657 for dead buffer.
2658 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
2659
60cfd278
AS
26602012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2661
2662 Fix bug that created negative-length intervals.
2663 * intervals.c (merge_interval_right, merge_interval_left):
2664 Do not zero out this interval if it is absorbed by its children,
2665 as this interval's total length doesn't change in that case. See
2666 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
2667
d06714cb
PE
26682012-07-18 Paul Eggert <eggert@cs.ucla.edu>
2669
83713154
PE
2670 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
2671 when invoking (make-bool-vector N t) and N is a positive
2672 multiple of 8 -- the last 8 bits were mistakenly cleared.
2673
d06714cb
PE
2674 Remove some struct layout assumptions in bool vectors.
2675 * alloc.c (bool_header_size): New constant.
2676 (header_size, word_size): Move earlier, as they're now used earlier.
2677 Use 'word_size' in a few more places, where it's appropriate.
2678 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
2679 padding before the data member of a bool vector.
2680 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
2681 than doing the check by hand with an abort ().
2682
464d5a5e
SM
26832012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2684
5fbc0409
SM
2685 * eval.c (Fdefvar): Don't check constants since we only set the var if
2686 it's not yet defined anyway (bug#11904).
2687
464d5a5e
SM
2688 * lisp.h (last_undo_boundary): Declare new var.
2689 * keyboard.c (command_loop_1): Set it.
2690 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
2691 were auto-added by the command loop (bug#11774).
2692
8dc2e44a
AS
26932012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2694
2695 * w32font.c (Qsymbol): Remove local definition.
2696 (syms_of_w32font): Don't DEFSYM it.
2697
169925ec
DA
26982012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2699
2700 Fix sweep_vectors to handle large bool vectors correctly.
2701 * alloc.c (sweep_vectors): Account total_vector_bytes for
2702 bool vectors larger than VBLOCK_BYTES_MAX.
2703
5fbfb018
CY
27042012-07-18 Chong Yidong <cyd@gnu.org>
2705
2706 * frame.c (x_set_frame_parameters): Revert bogus change introduced
2707 in 2012-05-25 commit by Paul Eggert (Bug#11738).
2708
3ab6e069
DA
27092012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2710
2711 Return more descriptive data from Fgarbage_collect.
2712 Suggested by Stefan Monnier in
2713 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
2714 * alloc.c (bounded_number): New function.
2715 (total_buffers, total_vectors): New variable.
2716 (total_string_size): Rename to total_string_bytes, adjust users.
2717 (total_vector_size): Rename to total_vector_bytes, adjust users.
2718 (sweep_vectors): Account total_vectors and total_vector_bytes.
2719 (Fgarbage_collect): New return value. Adjust documentation.
2720 (gc_sweep): Account total_buffers.
2721 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
2722 (VECTOR_SIZE): Remove.
2723 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
2724 (Qinterval, Qmisc): New symbols.
2725 (syms_of_data): Initialize them.
2726 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
2727 (Qcons, Qbuffer): New declarations.
2728
6d02fe5b
PE
27292012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2730
2731 * alloc.c (Fmemory_free): Account for memory-free's own storage.
2732 Round up, not down. Improve doc.
2733
b7ffe040
DA
27342012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2735
2736 Restore old code in allocate_string_data to avoid Faset breakage.
2737 Reported by Julien Danjou <julien@danjou.info> in
2738 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
2739 * alloc.c (allocate_string_data): Restore old code with minor
2740 adjustments, fix comment to explain this subtle issue.
2741
4dc7c8d5
SM
27422012-07-17 Eli Zaretskii <eliz@gnu.org>
2743
2744 Remove FILE_SYSTEM_CASE.
2745 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
2746
2747 * fileio.c (FILE_SYSTEM_CASE): Don't define.
2748 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
2749 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
2750 call-process-region passes it through expand-file-name.
2751
2752 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
2753
27542012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2755
2756 Fix crash when creating indirect buffer (Bug#11917)
2757 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
2758 Don't handle unbound variables specially if non-zero.
2759 (Fbuffer_local_variables): Pass zero.
2760 (clone_per_buffer_values): Pass non-zero.
2761
27622012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2763
2764 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
2765 to make the loop interruptible.
2766
27672012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2768
2769 * gnutls.c (emacs_gnutls_handshake): Only retry if
2770 GNUTLS_E_INTERRUPTED.
2771
cce7fefc
DA
27722012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2773
2774 Cleanup and convert miscellaneous checks to eassert.
2775 * alloc.c (mark_interval): Fix comment, partially rephrase
2776 old comment from intervals.h (see below).
2777 * intervals.c (find_interval, adjust_intervals_for_insertion)
2778 (delete_interval, adjust_intervals_for_deletion)
2779 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
2780 Convert to eassert.
2781 (adjust_intervals_for_insertion, make_new_interval):
2782 Remove obsolete and unused code.
2783 * intervals.h (struct interval): Remove obsolete comment.
2784 * textprotp.c (erase_properties): Remove unused code.
2785 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
2786 (Fremove_list_of_text_properties): Convert to eassert.
2787
9ea10cc3
CY
27882012-07-17 Chong Yidong <cyd@gnu.org>
2789
2790 * editfns.c (Finsert_char): Doc fix.
2791
3900d5de
DA
27922012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2793
2794 Fix previous change to make Fmemory_free always accurate.
2795 * alloc.c (make_interval): Update total_free_intervals.
2796 (make_float): Likewise for total_free_floats.
2797 (free_cons, Fcons): Likewise for total_free_conses.
2798 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
2799 Likewise for total_free_vector_bytes.
2800 (Fmake_symbol): Likewise for total_free_symbols.
2801 (bytes_free): Remove.
2802
7098646f
DA
28032012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2804
2805 Simple free memory accounting feature.
2806 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
2807 (sweep_vectors): Accumulate size of free vectors.
2808 (Fgarbage_collect): Setup bytes_free.
2809 (Fmemory_free): New function.
2810 (syms_of_alloc): Register it.
2811
22657b40
DA
28122012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2813
2814 Cleanup overlays checking.
2815 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
2816 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
2817 eassert and OVERLAYP.
2818 (sort_overlays): Change to use OVERLAYP.
2819
ddfc8813
RK
28202012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
2821
2822 * editfns.c (Finsert_char): Make it interactive, and make the
2823 second arg optional. Copy interactive spec and docstring from
2824 ucs-insert.
2825
7c26cf3c
PE
28262012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
2829 Unlike the other wrapped functions, fabs has an unspecified
2830 effect on errno.
2831
5d127af9
JD
28322012-07-16 Jan Djärv <jan.h.d@swipnet.se>
2833
2834 * nsterm.m (keyDown): Interpret flags without left/right bits
2835 as the left key (Bug#11670).
2836
6a0dd1d7
DA
28372012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2838
2839 Remove empty and useless init functions.
2840 * lisp.h (init_character_once, init_fns, init_image)
2841 (init_filelock, init_sound): Remove prototype.
2842 * character.c (init_character_once): Remove.
2843 * filelock.c (init_filelock): Likewise.
2844 * fns.c (init_fns): Likewise.
2845 * image.c (init_image): Likewise.
2846 * sound.c (init_sound): Likewise.
2847 * emacs.c (main): Adjust accordingly.
2848
7a6136fd
DA
28492012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2850
2851 * gtkutil.h: Tiny cleanups.
2852 (use_old_gtk_file_dialog): Remove useless declaration.
2853 (xg_uses_old_file_dialog): Add suggested const attribute.
2854
ce811ad9
EZ
28552012-07-15 Eli Zaretskii <eliz@gnu.org>
2856
2857 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
2858 (bidi_paragraph_init): Use it to limit search forward for a strong
2859 directional character in abnormally large paragraphs full of
2860 neutral or weak characters. (Bug#11943)
2861
c9adfeaa
SF
28622012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
2863
2864 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
2865 the toolbar (Bug#9451).
2866 (xg_make_tool_item): Give the widget event box a transparent
2867 background.
2868
fff62aa9
DA
28692012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2870
2871 Cleanup basic allocation variables and functions.
2872 * alloc.c (ignore_warnings, init_intervals, init_float)
2873 (init_cons, init_symbol, init_marker): Remove.
2874 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
2875 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
2876 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
2877 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
2878 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
2879 (staticidx, init_alloc_once, init_strings, free_ablock):
2880 Remove redundant initialization.
2881 * fns.c (init_weak_hash_tables): Remove.
2882 * lisp.h (init_weak_hash_tables): Remove prototype.
2883
9730daca
DA
28842012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2885
2886 Use zero_vector where appropriate.
2887 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
2888 accordingly.
2889 * lisp.h (zero_vector): New declaration.
2890 * font.c (null_vector): Remove.
2891 (syms_of_font): Remove initialization and staticpro.
2892 (font_list_entities, font_find_for_lface): Change to use zero_vector.
2893 * keymap.c (Faccessible_keymaps): Likewise.
2894
2e2d2a13
LL
28952012-07-15 Leo Liu <sdl.web@gmail.com>
2896
2897 * fringe.c: Fix typo in comments.
2898
cd276f6e
LL
28992012-07-14 Leo Liu <sdl.web@gmail.com>
2900
2901 * fringe.c: Add a new bitmap exclamation-mark.
2902
5a1131d9
EZ
29032012-07-14 Eli Zaretskii <eliz@gnu.org>
2904
2905 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
2906
2907 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
2908 (HAVE_MENUS): Don't define, defined by editing config.in with
2909 msdos/sed2v2.inp.
2910 (GMALLOC_INHIBIT_VALLOC): Don't define.
2911 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
2912
22e983b7
JB
29132012-07-14 Juanma Barranquero <lekktu@gmail.com>
2914
2915 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
2916
5b3f250f
GM
29172012-07-14 Glenn Morris <rgm@gnu.org>
2918
2919 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
2920 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
2921 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
2922
33d63ff4
GM
29232012-07-13 Glenn Morris <rgm@gnu.org>
2924
5b633342
GM
2925 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
2926
33d63ff4
GM
2927 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
2928 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
2929
b55b9f85
JD
29302012-07-13 Jan Djärv <jan.h.d@swipnet.se>
2931
0dc8cf50
JD
2932 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
2933 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
2934 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
2935 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
2936 where appropriate.
2937 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
2938 as boolean expression.
2939 (x_set_window_size): Remove unused variable toolbar.
2940 (ns_get_color_default, ns_mod_to_lisp): Remove.
2941 (ns_mouse_position): Remove unused variables xchar and ychar.
2942 (ns_compute_glyph_string_overhangs): Remove unused variable face.
2943 (ns_set_vertical_scroll_bar): Remove unused variable count.
2944 (ns_delete_terminal): Remove unused variable i.
2945 (ns_term_init): Remove unused variables r, g and b.
2946 (mouseDown): Remove unused variable window.
2947 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
2948 (initFrameFromEmacs): Remove unused variable vbextra.
2949 (mouseEntered): Remove unused variables p and dpyinfo.
2950 (mouseExited): Remove unused variables p and r.
2951 (ns_define_frame_cursor, ns_clear_frame_area)
2952 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
2953 (menuDown): Assign [sender tag] to variable and cast the variable.
2954
2955 * nsterm.h (menuDown): Add id as type to argument sender.
2956 (ns_display_info_for_name): Add Lisp_Object argument.
2957 (ns_term_init): Add Lisp_Object argument.
2958 (ns_map_event_to_object): Add void argument.
2959 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
2960 prototype with arguments and only declare if __OBJC__.
2961 (nxatoms_of_nsselect): Add void argument.
2962 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
2963 (ns_alloc_autorelease_pool): Add void argument.
2964 (ns_release_autorelease_pool): Add void* argument.
2965 (ns_get_defaults_value): Add const char* argument.
2966
2967 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
2968 (initFromContents): Use SSDATA where appropriate.
2969 (ns_update_menubar): Add braces to ambigous if-else.
2970 (initWithTitle): Put () around assignment in if statement.
2971 (ns_menu_show): Remove unused variables window and keymap.
2972 (update_frame_tool_bar): Remove unused variable selected_p.
2973 (initWithContentRect): Remove unused variable this_cmd_name.
2974
2975 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
2976 appropriate.
2977 (setXBMColor): Remove unused variable len.
2978 (setPixmapData): Put () around assignment in loop statement.
2979
2980 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
2981 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
2982 where appropriate.
2983 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
2984 around assignment in loop statement.
2985 (nsfont_open): Remove unused variable i.
2986 (nsfont_open): Remove unused variable len.
2987 (nsfont_draw): Remove unused variable cs.
2988
2989 * nsfns.m (x_set_icon_name, ns_set_name_internal)
2990 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
2991 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
2992 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
2993 (Fns_font_name, Fns_perform_service)
2994 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
2995 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
2996 (ns_set_name): Remove unused variable view.
2997 (x_set_menu_bar_lines): Remove unused variable olines.
2998 (x_set_tool_bar_lines): Remove unused variable root_window.
2999 (Fns_list_colors): Put () around assignment in while statement.
3000 (Fns_perform_service): Remove unused variable len.
3001 (Fns_display_usable_bounds): Remove unused variable top.
3002 (syms_of_nsfns): Remove unused variable i.
3003
b55b9f85
JD
3004 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
3005 memcpy (Bug#11907).
3006
ed9265fc 30072012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
3008
3009 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
3010 and free it with DestroyExceptionInfo (Bug#11558).
3011
ef099b57
JB
30122012-07-13 Juanma Barranquero <lekktu@gmail.com>
3013
3014 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
3015 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
3016 Set here, not in nt/config.nt.
3017
ea814a5d
EZ
30182012-07-13 Eli Zaretskii <eliz@gnu.org>
3019
3020 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
3021 cursor overflow into the last glyph on display line when the right
3022 fringe is off. (Bug#11832)
3023
1a952767
PE
30242012-07-13 Paul Eggert <eggert@cs.ucla.edu>
3025
3026 * xdisp.c (produce_special_glyphs): Now static.
3027 * dispextern.h (produce_special_glyphs): Remove decl.
3028
983188fd
GM
30292012-07-13 Glenn Morris <rgm@gnu.org>
3030
8d7c7eed 3031 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
3032 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
3033
983188fd
GM
3034 * s/usg5-4-common.h (USG, USG5):
3035 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
3036 * s/sol2-6.h (SOLARIS2):
3037 * s/irix6-5.h (IRIX6_5):
3038 * s/hpux10-20.h (USG, USG5, HPUX):
3039 * s/gnu-linux.h (USG, GNU_LINUX):
3040 * s/freebsd.h (BSD_SYSTEM):
3041 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
3042 * s/cygwin.h (CYGWIN):
3043 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
3044 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
3045
d1e68667 30462012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
3047
3048 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 3049
6de0e799
GM
30502012-07-13 Glenn Morris <rgm@gnu.org>
3051
739ae010
GM
3052 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
3053
dbee5793
GM
3054 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
3055
6de0e799
GM
3056 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
3057 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
3058
b82da769
GM
30592012-07-12 Glenn Morris <rgm@gnu.org>
3060
4fae5a7a 3061 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
3062
3063 * process.c (init_process_emacs): Rename from init_process.
3064 The old name is also the name of a Mach system call.
3065 * lisp.h, emacs.c: Update for this name change.
3066 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
3067 longer needed.
3068
5a979817
EZ
30692012-07-12 Eli Zaretskii <eliz@gnu.org>
3070
3071 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
3072 memmove call that removes glyphs covered by the left truncation
3073 glyph. Improve commentary.
3074 (display_line): Fix display of continuation glyphs on GUI frames
3075 when the right fringe is turned off and variable-size fonts are
3076 used in the window. Move the code that appends a stretch glyph to
3077 produce_special_glyphs, so that it could be used for truncation
3078 and continuation glyphs alike.
3079 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
3080 glyph of a suitably computed width, to align the special glyphs at
3081 the window margin. Code moved from display_line. (Bug#11832)
3082
3e91a053
GM
30832012-07-12 Glenn Morris <rgm@gnu.org>
3084
ba9e4b84
GM
3085 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
3086
3087 * s/gnu-linux.h, s/hpux10-20.h:
3088 Do not unconditionally define HAVE_XRMSETDATABASE.
3089
3e91a053
GM
3090 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
3091
b300b1f4
PE
30922012-07-12 Paul Eggert <eggert@cs.ucla.edu>
3093
3094 Fix typos that broke OS X build.
3095 Reported by Randal L. Schwartz in
3096 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
3097 * nsterm.m (ns_timeout): Add missing local decl.
3098 (ns_get_color): snprintf -> sprintf, to fix typo.
3099
6e777848
GM
31002012-07-12 Glenn Morris <rgm@gnu.org>
3101
3f922c37
GM
3102 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
3103 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
3104 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
3105 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
3106
0ab7b23a
GM
3107 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
3108 Move PTY_OPEN to configure.
3109
6e777848
GM
3110 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3111 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
3112 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
3113
4a7edc24
DA
31142012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
3115
3116 Use empty_unibyte_string where applicable.
3117 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
3118 * lread.c (read1): Likewise.
3119 * xsettings.c (syms_of_xsettings): Likewise.
3120
308aab79
GM
31212012-07-12 Glenn Morris <rgm@gnu.org>
3122
42bd1719
GM
3123 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
3124 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
3125 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
3126 * s/hpux10-20.h (RUN_TIME_REMAP):
3127 * s/bsd-common.h (TABDLY): Move to configure.
3128
3129 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
3130
3131 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
3132
ea0bbd17 3133 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 3134 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
3135
3136 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 3137
308aab79
GM
3138 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
3139 * s/template.h: Move NARROWPROTO to configure.
3140
ee1cf5cf
GM
31412012-07-11 Glenn Morris <rgm@gnu.org>
3142
30fe9bf4
GM
3143 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
3144 unused since 2011-01-17 change to systty.h.
3145
ee1cf5cf
GM
3146 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
3147 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3148 Move HAVE_PTYS and HAVE_SOCKETS to configure.
3149
63e47e07
PE
31502012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3151
3152 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
3153
c43fb4c3
GM
31542012-07-11 Glenn Morris <rgm@gnu.org>
3155
3156 * s/darwin.h, s/gnu-linux.h, s/template.h:
3157 Move INTERRUPT_INPUT to configure.
3158
e8df9267
DA
31592012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3160
3161 Minor adjustments to interning code.
3162 * lisp.h (intern, intern_c_string): Redefine as static inline
3163 wrappers for intern_1 and intern_c_string_1, respectively.
3164 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
3165 * lread.c (intern_1, intern_c_string_1, oblookup):
3166 Simplify Vobarray checking.
e8df9267
DA
3167 * font.c (font_intern_prop): Likewise. Adjust comment.
3168 * w32font.c (intern_font_name): Likewise.
3169
34348bd4
AS
31702012-07-11 Andreas Schwab <schwab@linux-m68k.org>
3171
d96a1e0c
AS
3172 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
3173
34348bd4
AS
3174 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
3175 of Fcar/Fcdr if possible.
3176 * font.c (check_otf_features): Likewise.
3177 * fontset.c (Fnew_fontset): Likewise.
3178 * gnutls.c (Fgnutls_boot): Likewise.
3179 * minibuf.c (read_minibuf): Likewise.
3180 * msdos.c (IT_set_frame_parameters): Likewise.
3181 * xmenu.c (Fx_popup_dialog): Likewise.
3182 * w32menu.c (Fx_popup_dialog): Likewise.
3183
c8add24e
GM
31842012-07-11 Glenn Morris <rgm@gnu.org>
3185
4b575b3c
GM
3186 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
3187 since nothing has defined it on these platforms.
3188
09f4e3b0
GM
3189 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
3190 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
3191
172bedef
GM
3192 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3193 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3194 Move CLASH_DETECTION to configure.
3195
249685df
GM
3196 * s/gnu.h: Remove file, which is now empty.
3197
c8add24e
GM
3198 * s/gnu.h, s/gnu-linux.h:
3199 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
3200
b41253a3
JW
32012012-07-11 John Wiegley <johnw@newartisans.com>
3202
3203 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
3204 function attribute, so we only use it if it exists in the
3205 compiler.
3206
d923b542
DA
32072012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3208
3209 Avoid call to strlen in fast_c_string_match_ignore_case.
3210 * search.c (fast_c_string_match_ignore_case): Change to use
3211 length argument. Adjust users accordingly.
3212 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
3213
5ebbef1d
PE
32142012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3215
bb352260
PE
3216 Assume mkdir, rmdir.
3217 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
3218 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
3219
57054ddd
PE
3220 Assume rename.
3221 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
3222
b747d3f7
PE
3223 Assume perror.
3224 * s/hpux10-20.h (HAVE_PERROR): Remove.
3225 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
3226 Remove dummy definition, as this problem was obsolete long ago.
3227
5ebbef1d
PE
3228 Assume strerror.
3229 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
3230
984e7f30
DA
32312012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3232
3233 Avoid calls to strlen in font processing functions.
3234 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
3235 (font_open_by_name): Change to use length argument.
3236 Adjust users accordingly.
d923b542
DA
3237 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
3238 Adjust prototypes.
3239 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
3240 Change to return ptrdiff_t.
984e7f30
DA
3241 (xfont_list_pattern, xfont_match): Use length returned by
3242 xfont_decode_coding_xlfd.
3243 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
3244
20e94fdd
GM
32452012-07-11 Glenn Morris <rgm@gnu.org>
3246
9d596af3
GM
3247 * s/darwin.h, s/freebsd.h, s/netbsd.h:
3248 Move DONT_REOPEN_PTY to configure.
3249
20e94fdd
GM
3250 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
3251 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
3252
e99a530f
PE
32532012-07-10 Paul Eggert <eggert@cs.ucla.edu>
3254
22ffb973
PE
3255 Remove "#define unix" that is no longer needed (Bug#11905).
3256 * s/aix4-2.h (unix): Remove; no longer needed.
3257
e9a9ae03
PE
3258 EMACS_TIME simplification (Bug#11875).
3259 This replaces macros (which typically do not work in GDB)
3260 with functions, typedefs and enums, making the code easier to debug.
3261 The functional style also makes code easier to read and maintain.
3262 * systime.h: Include <sys/time.h> on all hosts, not just if
3263 WINDOWSNT, since 'struct timeval' is needed in general.
3264 (EMACS_TIME): Now a typedef, not a macro.
3265 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
3266 not macros.
3267 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
3268 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
3269 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
3270 (EMACS_TIME_LE): Now functions, not macros.
3271 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
3272 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
3273 which are not functions. All uses rewritten to use:
3274 (make_emacs_time): New function.
3275 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
3276 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
3277 not functions. All uses rewritten to use the following, respectively:
3278 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
3279 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 3280 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
3281 * fileio.c (Fcopy_file):
3282 * xterm.c (XTflash): Get the current time closer to when it's used.
3283 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
3284
ffacb126
PE
3285 * bytecode.c (targets): Suppress -Woverride-init warnings.
3286
e99a530f
PE
3287 Simplify by avoiding confusing use of strncpy etc.
3288 * doc.c (Fsnarf_documentation):
3289 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
3290 * frame.c (Fmake_terminal_frame):
3291 * gtkutil.c (get_utf8_string):
3292 * lread.c (openp):
3293 * nsmenu.m (ns_update_menubar):
3294 * regex.c (regerror):
3295 Prefer memcpy to strncpy and strncat when either will do.
3296 * fileio.c (Fsubstitute_in_file_name):
3297 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
3298 (menu_separator_name_p):
3299 * nsmenu.m (ns_update_menubar):
3300 Prefer memcmp to strncmp when either will do.
3301 * nsterm.m: Include <ftoastr.h>.
3302 (ns_get_color):
3303 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
3304 Prefer snprintf to strncpy.
3305 * nsterm.m (ns_term_init):
3306 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
3307 * nsterm.m (ns_term_init):
3308 Avoid the need for strncpy, by using build_string or
3309 make_unibyte_string directly. Use dtoastr, not snprintf.
3310 * process.c (Fmake_network_process): Diagnose service names that
3311 are too long, rather than silently truncating them or creating
3312 non-null-terminated names.
3313 (Fnetwork_interface_info): Likewise, for interface names.
3314 * sysdep.c (system_process_attributes) [GNU_LINUX]:
3315 Prefer sprintf to strncat.
3316 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
3317 Prefer vsnprintf to vsprintf + strncpy.
3318
c59592b3
GM
33192012-07-10 Glenn Morris <rgm@gnu.org>
3320
3321 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
3322 Clarify fallback case.
3323
7d7bbefd
DA
33242012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3325
3326 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
3327 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
3328 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 3329 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
3330 where argument type is known to be a Lisp_Cons.
3331
3a4c8000
TT
33322012-07-10 Tom Tromey <tromey@redhat.com>
3333
3334 * bytecode.c (BYTE_CODE_THREADED): New macro.
3335 (BYTE_CODES): New macro. Replaces all old byte-code defines.
3336 (enum byte_code_op): New type.
3337 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
3338 (exec_byte_code): Use them. Use token threading when applicable.
3339
2a0213a6
DA
33402012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3341
3342 Optimize pure C strings initialization.
3343 * lisp.h (make_pure_string): Fix prototype.
3344 (build_pure_c_string): New function, defined as static inline. This
3345 provides a better opportunity to optimize away calls to strlen when
3346 the function is called with compile-time constant argument.
3347 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
3348 argument, adjust users accordingly. Use build_pure_c_string where
3349 appropriate.
3350 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
3351 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
3352 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
3353
cb1caeaf
DA
33542012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3355
3356 Avoid calls to strlen in miscellaneous functions.
3357 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
3358 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
3359 * lread.c (openp): Likewise.
3360
c293e30c
DA
33612012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3362
3363 Avoid calls to strlen in path processing functions.
3364 * fileio.c (file_name_as_directory): Add comment. Change to add
3365 srclen argument and return the length of result. Adjust users
3366 accordingly.
3367 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
3368 swap 1st and 2nd arguments to obey the common convention.
3369 Adjust users accordingly.
c293e30c
DA
3370 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
3371
9e059e3f
GM
33722012-07-10 Glenn Morris <rgm@gnu.org>
3373
d02eb359
GM
3374 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
3375 Move PENDING_OUTPUT_COUNT definition to configure.
3376
882cf227
GM
3377 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
3378 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
3379 * s/gnu.h (DATA_START): Move definitions to configure.
3380
af6e839f
GM
3381 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
3382 We include usg5-4-common.h, which defines them both.
3383
40289a12
GM
3384 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
3385 O_RDONLY already includes it).
3386
9e059e3f
GM
3387 Stop ns builds setting the EMACSLOADPATH environment variable.
3388 * nsterm.m (ns_load_path): Rename from ns_init_paths.
3389 Now it does not set EMACSLOADPATH, just returns the load-path string.
3390 * nsterm.h: Update accordingly.
3391 * lread.c [HAVE_NS]: Include nsterm.h.
3392 (init_lread) [HAVE_NS]: Use ns_load_path.
3393 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
3394
7c4e8ec0
GM
33952012-07-09 Glenn Morris <rgm@gnu.org>
3396
d4f600ff
GM
3397 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
3398 since the included bsd-common.h does so.
3399
cbb31951
GM
3400 Stop ns builds setting the EMACSPATH environment variable.
3401 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
3402 (ns_init_paths): Do not set EMACSPATH.
3403 * nsterm.h (ns_exec_path): Add it.
3404 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
3405 Use ns_exec_path.
3406
7c4e8ec0
GM
3407 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
3408
26bccfae
PE
34092012-07-09 Paul Eggert <eggert@cs.ucla.edu>
3410
a0bee46f
PE
3411 * process.c (wait_reading_process_output): 'waitchannels' was unset
3412 when read_kbd || !NILP (wait_for_cell); fix this.
3413
5994c183
PE
3414 Add GCC-style 'const' attribute to functions that can use it.
3415 * character.h (char_resolve_modifier_mask):
3416 * keyboard.h (make_ctrl_char):
3417 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
3418 (init_character_once, next_almost_prime, init_fns, init_image)
3419 (flush_pending_output, init_sound):
3420 * mem-limits.h (start_of_data):
3421 * menu.h (finish_menu_items):
3422 Add ATTRIBUTE_CONST.
3423 * emacs.c (DEFINE_DUMMY_FUNCTION):
3424 Declare the dummy function with ATTRIBUTE_CONST.
3425 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
3426 Add decls with ATTRIBUTE_CONST.
3427
26bccfae
PE
3428 Minor improvements to make_formatted_string.
3429 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
3430 where int is good enough, as vsprintf returns an int.
3431 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
3432
a8290ec3
DA
34332012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3434
3435 Use make_formatted_string to avoid double length calculation.
3436 * lisp.h (make_formatted_string): New prototype.
3437 * alloc.c (make_formatted_string): New function.
3438 * buffer.c (Fgenerate_new_buffer_name): Use it.
3439 * dbus.c (syms_of_dbusbind): Likewise.
3440 * editfns.c (Fcurrent_time_zone): Likewise.
3441 * filelock.c (get_boot_time): Likewise.
3442 * frame.c (make_terminal_frame, set_term_frame_name)
3443 (x_report_frame_params): Likewise.
3444 * image.c (gs_load): Likewise.
3445 * minibuf.c (get_minibuffer): Likewise.
3446 * msdos.c (dos_set_window_size): Likewise.
3447 * process.c (make_process): Likewise.
3448 * xdisp.c (ensure_echo_area_buffers): Likewise.
3449 * xsettings.c (apply_xft_settings): Likewise.
3450
d01ba2f1
GM
34512012-07-09 Glenn Morris <rgm@gnu.org>
3452
3453 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
3454 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
3455 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
3456 * nsterm.h (ns_etc_directory): Add it.
3457 * callproc.c [HAVE_NS]: Include nsterm.h.
3458 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
3459
f1f924b6
DA
34602012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3461
3462 Move marker debugging code under MARKER_DEBUG.
3463 * marker.c (MARKER_DEBUG): Move marker debugging code under
3464 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
3465 for bootstrap with --enable-checking (~3x slowdown reported
3466 by Juanma Barranquero <lekktu@gmail.com>).
3467 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
3468
ab531b66
PE
34692012-07-08 Paul Eggert <eggert@cs.ucla.edu>
3470
3471 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
3472 See <http://bugs.gnu.org/11825#29>.
3473
c4b3bc8a
EZ
34742012-07-08 Eli Zaretskii <eliz@gnu.org>
3475
3476 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
3477 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
3478 (display_line): Add commentary about displaying truncation glyphs
3479 on GUI frames.
3480 (produce_special_glyphs): Move here from term.c.
3481
3482 * term.c (produce_special_glyphs): Move to xdisp.c.
3483
3484 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
3485 section.
c4b3bc8a 3486
b676b881
AS
34872012-07-07 Andreas Schwab <schwab@linux-m68k.org>
3488
f17c5273
AS
3489 * xdisp.c (display_line): Avoid warning about implicit declaration
3490 of FRAME_FONT.
3491
298819b9
AS
3492 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
3493
b676b881
AS
3494 * lisp.h: Remove empty conditional.
3495
6045c4fd
PE
34962012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3497
b3350bf9
PE
3498 * lread.c (load_path_check): Now static.
3499
6045c4fd
PE
3500 Fix some minor --with-ns problems found by static checking.
3501 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
3502 (x_set_font) [!HAVE_X_WINDOWS]:
3503 * image.c (xpm_load_image) [HAVE_NS]:
3504 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
3505 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
3506 Remove unused local.
3507 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
3508 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
3509 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
3510 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
3511 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
3512 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
3513 Fix pointer signedness problem.
3514 * xfaces.c (FRAME_X_FONT_TABLE):
3515 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
3516
929e7845
GM
35172012-07-07 Glenn Morris <rgm@gnu.org>
3518
3519 * lread.c (load_path_check): New function, split from init_lread.
3520 (init_lread): Reorganize. Motivation:
3521 If EMACSLOADPATH is set, check/warn about that rather than the
3522 defaults, which we are not going to use. Hence we can remove
3523 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
3524 Don't warn if site-lisp directories are missing.
3525 If not installed, start from a blank load-path, since
3526 PATH_LOADSEARCH refers to the eventual installation directories.
3527
58dd0aa4
EZ
35282012-07-07 Eli Zaretskii <eliz@gnu.org>
3529
3530 Support truncation and continuation glyphs on GUI frames, when
3531 fringes are disabled. (Bug#11832)
3532 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
3533 continuation glyphs even if on GUI frames.
3534 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
3535 or both, are absent.
3536 (start_display, move_it_in_display_line_to): Handle the case of a
3537 GUI frame without a fringe to display continuation or truncation
3538 glyphs.
3539 (insert_left_trunc_glyphs): Support GUI frames: make sure
3540 truncation glyphs overwrite enough glyphs from the current line to
3541 have sufficient space in pixels.
3542 (display_line): Support truncation and continuation glyphs on GUI
3543 frames. If some spare pixels are left on the line after inserting
3544 the truncation glyphs, fill that space with a stretch glyph of a
3545 suitably computed width.
3546
3547 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
3548 produce_glyphs, to support GUI sessions.
3549
31571fd7
PE
35502012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3551
5a16b9bc
PE
3552 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
3553
f3047c75
PE
3554 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
3555
31571fd7
PE
3556 Do not require float-time's arg to fit in time_t (Bug#11825).
3557 This works better on hosts where time_t is unsigned, and where
3558 float-time is applied to the (negative) difference between two times.
3559 * editfns.c (decode_time_components): Last arg is now double *,
3560 not int *, and means to store all the result as a double, without
3561 worrying about whether the seconds part fits in time_t.
3562 All callers changed.
3563 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
3564 All callers changed.
3565 (Ffloat_time): Do not fail merely because the specified time falls
3566 outside of time_t range.
3567
4516fbef
GM
35682012-07-07 Glenn Morris <rgm@gnu.org>
3569
3570 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
3571 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
3572 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
3573
07adc2c6
JB
35742012-07-07 Juanma Barranquero <lekktu@gmail.com>
3575
3576 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
3577 Update dependencies.
3578
3579 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
3580
fd573f31
PE
35812012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3582
fee5959d
PE
3583 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
3584 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
3585 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
3586 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
3587 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
3588 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
3589
fd573f31
PE
3590 * xfont.c (compare_font_names): Redo to omit the need for casts.
3591
ddadbc0e
AS
35922012-07-06 Andreas Schwab <schwab@linux-m68k.org>
3593
fca8d6b6
AS
3594 * xfns.c (Fx_change_window_property): Doc fix.
3595 * w32fns.c (Fx_change_window_property): Doc fix.
3596
ddadbc0e
AS
3597 * w32fns.c (Fx_window_property): Accept the same arguments as the
3598 X Windows version. Doc fix.
3599 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
3600
ed9265fc 36012012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
3602 Eli Zaretskii <eliz@gnu.org>
3603
3604 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
3605 Windows-specific code from nt/config.nt moved here.
3606 Obsolete settings removed.
3607
216ee680
PE
36082012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3609
3610 * process.c: Avoid unnecessary calls to gettime.
3611 (wait_reading_process_output): Don't get the time of day
3612 when gobbling data immediately and not waiting, as there's no need
3613 for it in that case. This removes a FIXME.
3614
bdd091e4
JD
36152012-07-06 Jan Djärv <jan.h.d@swipnet.se>
3616
3617 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
3618 is defined (Bug#11768).
3619
9d44f8ce
DA
36202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3621
3622 Fix marker debugging code.
3623 * marker.c (byte_char_debug_check): Do not perform the check
3624 if buffer is not multibyte.
090bd7cb
JB
3625 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3626 Call byte_char_debug_check with correct arguments.
9d44f8ce 3627
90fc4786
DA
36282012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3629
3630 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
3631 * marker.c (byte_char_debug_check, count_markers):
3632 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
3633 (byte_debug_flag): Remove.
3634 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3635 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
3636
7b7ae965
DA
36372012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3638
4e57b342
DA
3639 Avoid code repetition in marker-related functions.
3640 * marker.c (attach_marker): New function.
3641 (Fset_marker, set_marker_restricted, set_marker_both)
3642 (set_marker_restricted_both): Use it.
3643 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
3644 Consistently rename charno to charpos.
3645 (marker_position): Add eassert.
3646 (marker_byte_position): Convert to eassert.
3647
36482012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3649
3650 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 3651 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 3652 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 3653
657924ff
DA
36542012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3655
3656 Introduce fast path for the widely used marker operation.
3657 * alloc.c (build_marker): New function.
3658 * lisp.h (build_marker): New prototype.
3659 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
3660 * composite.c (autocmp_chars): Likewise.
3661 * editfns.c (buildmark): Remove.
3662 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
3663 (save_restriction_save): Use build_marker.
3664 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
3665 * window.c (save_window_save): Likewise.
3666
041a49a6
DA
36672012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3668
3669 Do not use Fdelete_overlay in delete_all_overlays
3670 to avoid redundant calls to unchain_overlay.
3671 * buffer.c (drop_overlay): New function.
3672 (delete_all_overlays, Fdelete_overlay): Use it.
3673 * minibuf.c (get_minibuffer): Fix comment.
3674
7dca65a4
PE
36752012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3676
3677 Port to OpenBSD 5.1 amd64.
3678 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
3679 This is needed for OpenBSD, and should be harmless on all BSD systems.
3680 Also, include <sys/sysctl.h>, as it should be available on all
3681 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
3682 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
3683 use p_pid member, not kp_proc.pid.
3684
8eb876e2
GM
36852012-07-06 Glenn Morris <rgm@gnu.org>
3686
3687 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
3688
38182d90
PE
36892012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3690
3691 More xmalloc and related cleanup.
3692 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
3693 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
3694 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
3695 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
3696 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
3697 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
3698 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
3699 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
3700 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
3701 * xterm.c:
3702 Omit needless casts involving void * pointers and allocation.
3703 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
3704 as the former is more robust if P's type is changed.
3705 Prefer xzalloc to xmalloc + memset 0.
3706 Simplify malloc-or-realloc to realloc.
3707 Don't worry about xmalloc returning a null pointer.
3708 Prefer xstrdup to xmalloc + strcpy.
3709 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
3710 growing it.
3711 * keyboard.c (apply_modifiers_uncached): Prefer local array to
3712 alloca of a constant.
3713
6dd5a677
EZ
37142012-07-05 Eli Zaretskii <eliz@gnu.org>
3715
3716 * xdisp.c (display_line): Fix horizontal pixel coordinates when
3717 hscroll is larger than the line width. Fixes long and futile
3718 looping inside extend_face_to_end_of_line (on a TTY) producing
3719 glyphs that are not needed and thrown away.
3720
6b312f0f
DA
37212012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3722
3723 * marker.c (set_marker_restricted_both): Simplify by using
3724 clip_to_bounds.
3725
f520ef9b
PE
37262012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3727
3728 * editfns.c (region_limit): Simplify by using clip_to_bounds.
3729
383b7c95
JD
37302012-07-05 Jan Djärv <jan.h.d@swipnet.se>
3731
3732 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
3733 not defined (Bug#11768).
3734 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
3735 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
3736 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
3737 followed by gtk_box_set_homogeneous (Bug#11768).
3738 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
3739 (update_theme_scrollbar_width, xg_create_scroll_bar):
3740 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
3741 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
3742 (is_box_type): New function (Bug#11768).
3743 (xg_tool_item_stale_p): Call is_box_type.
5293d758 3744 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
3745 with default display (Bug#11768).
3746
d6e7bf45
EZ
37472012-07-05 Eli Zaretskii <eliz@gnu.org>
3748
3749 * xdisp.c (window_hscroll_limited): New function.
3750 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
3751 coordinates when window's hscroll is set to insanely large
3752 values. (Bug#11857)
3753
431391ec
JB
37542012-07-05 Juanma Barranquero <lekktu@gmail.com>
3755
3756 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
3757 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
3758
23f86fce
DA
37592012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3760
3761 Cleanup xmalloc.
3762 * lisp.h (xzalloc): New prototype. Omit needless casts.
3763 * alloc.c (xzalloc): New function. Omit needless casts.
3764 * charset.c: Omit needless casts. Convert all calls to
3765 xmalloc with following memset to xzalloc.
3766 * dispnew.c: Likewise.
3767 * fringe.c: Likewise.
3768 * image.c: Likewise.
3769 * sound.c: Likewise.
3770 * term.c: Likewise.
3771 * w32fns.c: Likewise.
3772 * w32font.c: Likewise.
3773 * w32term.c: Likewise.
3774 * xfaces.c: Likewise.
3775 * xfns.c: Likewise.
3776 * xterm.c: Likewise.
3777 * atimer.c: Omit needless casts.
3778 * buffer.c: Likewise.
3779 * callproc.c: Likewise.
3780 * ccl.c: Likewise.
3781 * coding.c: Likewise.
3782 * composite.c: Likewise.
3783 * doc.c: Likewise.
3784 * doprnt.c: Likewise.
3785 * editfns.c: Likewise.
3786 * emacs.c: Likewise.
3787 * eval.c: Likewise.
3788 * filelock.c: Likewise.
3789 * fns.c: Likewise.
3790 * gtkutil.c: Likewise.
3791 * keyboard.c: Likewise.
3792 * lisp.h: Likewise.
3793 * lread.c: Likewise.
3794 * minibuf.c: Likewise.
3795 * msdos.c: Likewise.
3796 * print.c: Likewise.
3797 * process.c: Likewise.
3798 * region-cache.c: Likewise.
3799 * search.c: Likewise.
3800 * sysdep.c: Likewise.
3801 * termcap.c: Likewise.
3802 * terminal.c: Likewise.
3803 * tparam.c: Likewise.
3804 * w16select.c: Likewise.
3805 * w32.c: Likewise.
3806 * w32reg.c: Likewise.
3807 * w32select.c: Likewise.
3808 * w32uniscribe.c: Likewise.
3809 * widget.c: Likewise.
3810 * xdisp.c: Likewise.
3811 * xmenu.c: Likewise.
3812 * xrdb.c: Likewise.
3813 * xselect.c: Likewise.
3814
0497dc44
PE
38152012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3816
3817 * fileio.c (time_error_value): Check the right error number.
3818 Problem reported by Troels Nielsen in
3819 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
3820
356e7178
PE
38212012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3822
4e71fd89
PE
3823 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
3824 This should be fixed in a better way; see Eli Zaretskii in
3825 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
3826 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
3827
f0941253
PE
3828 * fileio.c (time_error_value): Rename from special_mtime.
3829 The old name's problems were noted by Eli Zaretskii in
3830 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
3831
065c9eb4
PE
3832 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
3833 This variable's comment says Emacs needs at least one GDB-visible
3834 symbol of type enum pvec_type, to work around GDB problems.
3835 The symbol's value doesn't matter.
3836
356e7178
PE
3837 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
3838 that causes compilation to fail on pre-C99 compilers.
3839
ed9265fc 38402012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
3841
3842 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
3843 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
3844
3884d954
DA
38452012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3846
d209e2fb 3847 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
3848 headers for buffer_defaults and buffer_local_symbols.
3849 Reported by Juanma Barranquero <lekktu@gmail.com>.
3850
ee28be33
SM
38512012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3852
3853 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
3854 * lisp.h (enum pvec_type): Use fewer bits.
3855 (PSEUDOVECTOR_SIZE_BITS): New constant.
3856 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
3857 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
3858 change in pvec_type.
3859 (PSEUDOVECTOR_TYPEP): New macro.
3860 (TYPED_PSEUDOVECTORP): Use it.
3861 * fns.c (internal_equal): Adapt code to extract pvectype.
3862 * emacs.c (gdb_pvec_type): Update type.
3863 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
3864 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
3865 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
3866 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
3867 (sweep_vectors): Use it. Use local var `total_bytes' instead of
3868 abusing vector->header.next.nbytes.
3869 (live_vector_p): Use PVEC_TYPE.
3870 (mark_object): Adapt code to extract pvectype. Use switch.
3871
c7f2cd7f
PE
38722012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3873
3874 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
3875 Tighten new eassert a bit.
3876
8ce70ed2
DA
38772012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3878
3879 Fix compilation with --enable-gcc-warnings and -O1
3880 optimization level.
3881 * doprnt.c (doprnt): Change type of tem to int, initialize
3882 to avoid compiler warning. Add eassert.
3883 * search.c (simple_search): Initialize match_byte to avoid
3884 compiler warning. Add eassert.
3885
dea7f1e5
PE
38862012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3887
24a212eb
PE
3888 Avoid weird behavior with large horizontal scrolls.
3889 Without this change, for example, large hscroll values would
3890 mess up Emacs's display on Fedora 15 x86, presumably due to
3891 overflows in int calculations in the display code.
3892 Also, if buffers had long lines, Emacs would freeze.
3893 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
3894 (set_window_hscroll): New function, containing the old guts of
3895 Fset_window_hscroll. Return the clipped value.
3896 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
3897 This avoids the need to check against PTRDIFF_MAX.
3898
dea7f1e5
PE
3899 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
3900
76046526
DA
39012012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3902
3903 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
3904
39adff0d
PE
39052012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3906
63807d47
PE
3907 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
3908 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
3909 since GCC 4.4.6 issues a bogus warning for them.
3910
39adff0d
PE
3911 Fix bugs in file timestamp newness comparisons.
3912 * fileio.c (Ffile_newer_than_file_p):
3913 * lread.c (Fload): Use full timestamp resolution of files,
3914 not just the 1-second resolution, so that files that are only
3915 slightly newer still count as newer.
3916 * fileio.c (Ffile_newer_than_file_p): Don't assume file
3917 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
3918
dbeed9a6
PE
39192012-07-03 Paul Eggert <eggert@cs.ucla.edu>
3920
3921 * fileio.c: Improve handling of file time marker. (Bug#11852)
3922 (special_mtime): New function.
3923 (Finsert_file_contents, Fverify_visited_file_modtime):
3924 Use it to set special mtime values consistently.
3925
636334d6
AS
39262012-07-03 Andreas Schwab <schwab@linux-m68k.org>
3927
3928 * fileio.c (Finsert_file_contents): Properly handle st_mtime
3929 marker for non-existing file. (Bug#11852)
3930
e2017fe2
GM
39312012-07-03 Glenn Morris <rgm@gnu.org>
3932
3933 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
3934 and did not make it into globals.h).
3935
404dbd37
TT
39362012-07-03 Tom Tromey <tromey@redhat.com>
3937
3938 * window.c (Fset_window_margins, Fset_window_fringes)
3939 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
3940 * textprop.c (Fprevious_property_change): No longer static.
3941 * syntax.c (Fsyntax_table_p): No longer static.
3942 * process.c (Fget_process, Fprocess_datagram_address): No longer
3943 static.
3944 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
3945 * keyboard.c (Fcommand_execute): No longer static.
3946 Remove EXFUN.
3947 * insdel.c (Fcombine_after_change_execute): No longer static.
3948 * image.c (Finit_image_library): No longer static.
3949 * fileio.c (Fmake_symbolic_link): No longer static.
3950 * eval.c (Ffetch_bytecode): No longer static.
3951 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
3952 * doc.c (Fdocumentation_property, Fsnarf_documentation):
3953 No longer static.
404dbd37
TT
3954 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
3955 static.
3956 * dired.c (Ffile_attributes): No longer static.
3957 * composite.c (Fcomposition_get_gstring): No longer static.
3958 * callproc.c (Fgetenv_internal): No longer static.
3959
3960 * ccl.h: Remove EXFUNs.
3961 * buffer.h: Remove EXFUNs.
3962 * dispextern.h: Remove EXFUNs.
3963 * intervals.h: Remove EXFUNs.
3964 * fontset.h: Remove EXFUN.
3965 * font.h: Remove EXFUNs.
3966 * dosfns.c (system_process_attributes): Remove EXFUN.
3967 * keymap.h: Remove EXFUNs.
3968 * lisp.h: Remove EXFUNs.
3969 * w32term.h: Remove EXFUNs.
3970 * window.h: Remove EXFUNs.
3971 * xsettings.h: Remove EXFUN.
3972 * xterm.h: Remove EXFUN.
3973
8e4fd1e1
GM
39742012-07-03 Glenn Morris <rgm@gnu.org>
3975
3976 * lisp.h (Frandom): Make it visible to C.
3977 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
3978 buffer for invisible buffers. (Bug#1229)
3979
ca95b3eb
DA
39802012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3981
3982 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
3983 values which aren't power of 2.
14ae4239
BT
3984 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
3985 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
3986 accordingly.
3987
7555c33f
SM
39882012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
3989
3990 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
3991
3992 * alloc.c (mark_object): Revert part of last patch to use `switch'.
3993
d12e8f5a
DA
39942012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3995
3996 * alloc.c (allocate_vector_block): Remove redundant
3997 calls to mallopt if DOUG_LEA_MALLOC is defined.
3998 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
3999 avoid calls to mallopt if zero_vector is returned.
4000
296094c3
DA
40012012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4002
4003 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
4004 is enabled, avoid dereferencing NULL current_sblock if
4005 running undumped.
4006
36429c89
DA
40072012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4008
4009 Cleanup basic buffer management.
4010 * buffer.h (struct buffer): Change layout to use generic vector
4011 marking code. Fix some comments. Change type of 'clip_changed'
4012 to bitfield. Remove unused #ifndef old.
4013 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
4014 (GET_OVERLAYS_AT): Fix indentation.
4015 (for_each_per_buffer_object_at): New macro.
4016 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
4017 (Fbuffer_local_variables): Use it.
4018 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
4019 * alloc.c (allocate_buffer): Adjust to match new layout of
4020 struct buffer. Fix comment.
4021 (mark_overlay): New function.
4022 (mark_buffer): Use it. Use mark_vectorlike to mark normal
4023 Lisp area of struct buffer.
4024 (mark_object): Use it. Adjust marking of misc objects
4025 and related comments.
4026
3b3e4cac
PE
40272012-07-02 Paul Eggert <eggert@cs.ucla.edu>
4028
4029 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
4030 wrapper that is not needed because the wrapped code is a no-op (zero
4031 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
4032 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
4033
cf5c0175
DA
40342012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
4035
4036 * alloc.c (mark_buffer): Simplify. Remove prototype.
4037 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 4038 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
4039 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
4040 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 4041
ca26824c
GM
40422012-06-30 Glenn Morris <rgm@gnu.org>
4043
2e4c5312
GM
4044 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
4045
ca26824c
GM
4046 * epaths.in (PATH_SITELOADSEARCH): New.
4047 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
4048 This is rather than relying on --enable-locallisppath elements
4049 having "site-lisp" in their names. (Bug#10208#25, 11658)
4050
0d23c240
EZ
40512012-06-30 Eli Zaretskii <eliz@gnu.org>
4052
c9240d7a
EZ
4053 * w32proc.c (sys_select): Accept and ignore one more argument.
4054
4055 * w32.c (emacs_gnutls_pull): Call select with one more argument.
4056
0d23c240 4057 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 4058 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
4059
4060 * sysdep.c: Don't include dos.h and dosfns.h.
4061
4062 * process.c (sys_select):
4063 * msdos.c (sys_select): Accept one more argument and ignore it.
4064
4065 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
4066 adapt data types and code to that.
4067
4068 * dosfns.c:
4069 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
4070 which clashes with the gnulib function of the same name.
4071
af5a5a98
AS
40722012-06-30 Andreas Schwab <schwab@linux-m68k.org>
4073
c5e4379c
AS
4074 * font.c (font_style_to_value, font_style_symbolic)
4075 (font_prop_validate_style): Add type checks for values in
4076 font_style_table.
4077
af5a5a98
AS
4078 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
4079 argument.
4080 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
4081 uses.
4082
8d38f461
EZ
40832012-06-29 Eli Zaretskii <eliz@gnu.org>
4084
2e5a6631
EZ
4085 * xdisp.c (try_window_id): Undo last change.
4086
8d38f461
EZ
4087 * w32.c (getwd): Adjust commentary about startup_dir.
4088 (init_environment): Always call sys_access, even in non-MSVC
4089 builds. Don't chdir to the directory of the Emacs executable.
4090 This undoes code from 1997 which was justified by the need to
4091 "avoid conflicts when removing and renaming directories". But its
4092 downside was that every relative file name was being interpreted
4093 relative to the directory of the Emacs executable, which can never
4094 be TRT. In particular, it broke sys_access when called with
4095 relative file names.
4096 (sys_access): Map GetLastError to errno.
4097
2af3565e
DA
40982012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4099
4100 * window.h (struct window): Change type of 'fringes_outside_margins'
4101 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 4102 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
4103 Adjust comment.
4104 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
4105 to ptrdiff_t.
4106
c8d3a25c 41072012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 4108
c8d3a25c
GM
4109 * gnutls.c (emacs_gnutls_handshake):
4110 Add QUIT to make the loop interruptible.
57570cd3 4111
c8d3a25c 41122012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 4113
c8d3a25c
GM
4114 * charset.c (init_charset): Make lack of etc/charsets fatal.
4115
3e984ee8
DA
41162012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4117
4118 * editfns.c (region_limit): Fix type mismatch.
4119
ef884f23
DA
41202012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4121
4122 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
4123 undefined. Convert from xassert to eassert.
4124 * nsmenu.m: Convert from xassert to eassert.
4125 * nsterm.m: Likewise.
4126
7d7e0027
SM
41272012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
4128
4129 * editfns.c (region_limit): Clip to narrowing (bug#11770).
4130
aa754e6a
PE
41312012-06-28 Paul Eggert <eggert@cs.ucla.edu>
4132
4133 Avoid integer overflow on scroll-left and scroll-right.
4134 * window.c (HSCROLL_MAX): New macro.
4135 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
4136 overflow when requested scroll falls outside ptrdiff_t range.
4137
80b00b08
DA
41382012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4139
4140 * window.h (struct window): Change type of 'hscroll',
4141 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
4142 'last_modified' and 'last_overlay_modified' to EMACS_INT.
4143 Adjust users accordingly.
4144 * xdisp.c (try_cursor_movement): Replace type check with eassert.
4145 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
4146 from EMACS_INT to ptrdiff_t.
4147 (make_window): Omit redundant initialization.
4148
62b2bcf6
JB
41492012-06-28 Juanma Barranquero <lekktu@gmail.com>
4150
4151 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
4152
45942c7d
DA
41532012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4154
4155 * window.h (struct window): Change type of 'use_time' and
4156 'sequence_number' from Lisp_Object to int.
4157 * frame.c (make_frame): Adjust users accordingly.
4158 * print.c (print_object): Likewise.
4159 * window.c (select_window, Fwindow_use_time, make_parent_window)
4160 (make_window): Likewise.
4161
e509cfa6
DA
41622012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4163
4164 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
4165 enabled with --enable-checking=[all,glyphs] configure option.
4166 Fix GLYPH_DEBUG usage assuming that it may be undefined,
4167 adjust comments accordingly.
4168 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
4169 undefined, adjust comments accordingly.
4170 * image.c: Likewise.
4171 * scroll.c: Likewise.
4172 * w32fns.c: Likewise.
4173 * w32term.c: Likewise.
4174 * xdisp.c: Likewise.
4175 * xfaces.c: Likewise.
4176 * xfns.c: Likewise.
4177 * xterm.c: Likewise.
4178
a54e2c05
DA
41792012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4180
4181 Generalize run-time debugging checks.
4182 * dispextern.h (XASSERTS): Remove.
4183 * fontset.c (xassert): Remove.
4184 Convert from xassert to eassert.
4185 * alloc.c: Convert from xassert to eassert.
4186 * bidi.c: Likewise.
4187 * dispnew.c: Likewise.
4188 * fns.c: Likewise.
4189 * fringe.c: Likewise.
4190 * ftfont.c: Likewise.
4191 * gtkutil.c: Likewise.
4192 * image.c: Likewise.
4193 * keyboard.c: Likewise.
4194 * menu.c: Likewise.
4195 * process.c: Likewise.
4196 * scroll.c: Likewise.
4197 * sound.c: Likewise.
4198 * term.c: Likewise.
4199 * w32console.c: Likewise.
4200 * w32fns.c: Likewise.
4201 * w32term.c: Likewise.
4202 * window.c: Likewise.
4203 * xdisp.c: Likewise.
4204 * xfaces.c: Likewise.
4205 * xfns.c: Likewise.
4206 * xselect.c: Likewise.
4207 * xterm.c: Likewise.
4208
1ec4b7b2
SM
42092012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
4210
4211 * fns.c (maybe_resize_hash_table): Output message when growing the
4212 purify-hashtable.
4213
2014308a
DA
42142012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4215
4216 * alloc.c (allocate_string_data): Remove dead code.
4217 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
4218 avoid GCC warning about unused macro.
4219
246155eb
DA
42202012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4221
4222 * alloc.c (allocate_string): Omit intervals initialization.
4223 * alloc.c (make_uninit_multibyte_string): Initialize intervals
4224 as in make_pure_string and make_pure_c_string.
4225
43184b7b
DA
42262012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4227
d209e2fb 4228 * alloc.c (allocate_string): Fix last change.
43184b7b 4229
3fe6dd74
DA
42302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4231
d209e2fb 4232 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
4233 to memset, add explicit initialization where appropriate.
4234
1ba6038a
GM
42352012-06-27 Glenn Morris <rgm@gnu.org>
4236
4237 * lisp.mk (lisp): Remove paths.elc.
4238
c89926a5
CY
42392012-06-27 Chong Yidong <cyd@gnu.org>
4240
4241 * doc.c (Fsubstitute_command_keys): Fix punctuation.
4242
ed6b3510
JW
42432012-06-26 John Wiegley <johnw@newartisans.com>
4244
1ec4b7b2 4245 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
4246 on Mac OS X Lion: __mod_init_func and __mod_term_func.
4247
ed6b3510
JW
4248 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
4249 when building with Clang.
4250
8edd4a2b
SM
42512012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
4252
4253 * eval.c (Fapply): Allow calling it with a single argument.
4254
f6f62d1b
EZ
42552012-06-26 Eli Zaretskii <eliz@gnu.org>
4256
4257 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
4258 _stricmp and _strnicmp.
4259 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
4260
62efea5e
DA
42612012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4262
4263 * alloc.c (allocate_window): Zero out non-Lisp part of newly
4264 allocated window.
4265 (allocate_process): Likewise for new process.
8edd4a2b 4266 (allocate_terminal): Change to use offsetof.
62efea5e
DA
4267 (allocate_frame): Likewise.
4268 * frame.c (make_frame): Omit redundant initialization.
4269 * window.c (make_parent_window): Use memset.
4270 (make_window): Omit redundant initialization.
4271 * process.c (make_process): Omit redundant initialization.
4272 * terminal.c (create_terminal): Likewise.
4273
42997f4d
DA
42742012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4275
4276 * term.c (delete_tty): Remove redundant call to memset.
4277
1130ecfc
DA
42782012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4279
4280 * alloc.c: Remove build_string.
4281 * lisp.h: Define build_string as static inline. This provides
4282 a better opportunity to optimize away calls to strlen when the
4283 function is called with compile-time constant argument.
4284 * image.c (imagemagick_error): Convert to build_string.
4285 * w32proc.c (sys_spawnve): Likewise.
4286 * xterm.c (x_term_init): Likewise.
4287
cf38a720
PE
42882012-06-26 Paul Eggert <eggert@cs.ucla.edu>
4289
99027bdd
PE
4290 Use sprintf return value instead of invoking strlen on result.
4291 In the old days this wasn't portable, since some sprintf
4292 implementations returned char *. But they died out years ago and
4293 Emacs already assumes sprintf returns int.
4294 Similarly for float_to_string.
4295 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
4296 * ccl.c (ccl_driver):
4297 * character.c (string_escape_byte8):
4298 * data.c (Fnumber_to_string):
4299 * doprnt.c (doprnt):
4300 * print.c (print_object):
4301 * xdisp.c (message_dolog):
4302 * xfns.c (syms_of_xfns):
4303 Use sprintf or float_to_string result to avoid need to call strlen.
4304 * data.c (Fnumber_to_string):
4305 Use make_unibyte_string, since the string must be ASCII.
4306 * lisp.h, print.c (float_to_string): Now returns int length.
4307 * term.c (produce_glyphless_glyph):
4308 Use sprintf result rather than recomputing it.
4309
cf38a720
PE
4310 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
4311 * Makefile.in (ALL_CFLAGS):
4312 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
4313 * gmalloc.c, regex.c: Include <config.h> unconditionally.
4314
3511c784
DA
43152012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4316
0a08eb21 4317 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
4318 strcasecmp if available.
4319 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
4320
fb7da12e
AS
43212012-06-25 Andreas Schwab <schwab@linux-m68k.org>
4322
4323 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
4324 Avoid comma operator.
4325 * menu.c (push_submenu_start, push_submenu_end)
4326 (push_left_right_boundary, push_menu_pane): Likewise.
4327 * msdos.c (dos_rawgetc): Likewise.
4328
afa2ffd8
DA
43292012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4330
4331 * xfns.c (xic_create_fontsetname): Remove redundant calls
4332 to memset.
4333
b3b4476b
PE
43342012-06-25 Paul Eggert <eggert@cs.ucla.edu>
4335
4495ff38
PE
4336 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4337 sprintf already null-terminates its output.
4338
b3b4476b
PE
4339 * xfns.c (x_window): Remove redundant cast.
4340
b00876c9
DA
43412012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4342
4343 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4344 `const char *' to `char *' to avoid compiler warning.
4345
d188e26b
PE
43462012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4347
885d1d74
PE
4348 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4349 instead of truncating it to 63 (admittedly a generous limit).
4350
d188e26b
PE
4351 * process.c: Fix spelling and caps in comments.
4352
e2f560b1
DN
43532012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
4354
e86db54b 4355 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
4356 * sysdep.c (setpgrp): Remove definition, not used in this file.
4357
7583a3a1
JB
43582012-06-24 Juanma Barranquero <lekktu@gmail.com>
4359
4360 * makefile.w32-in: Update dependencies.
4361
696056c2
EZ
43622012-06-24 Eli Zaretskii <eliz@gnu.org>
4363
4364 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4365 (SYSTIME_H): Add nt/inc/sys/time.h.
4366
4367 * systime.h [WINDOWSNT]: Include sys/time.h.
4368
4369 * s/ms-w32.h (struct timespec): Definition moved from
4370 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
4371
845ca893
PE
43722012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4373
4374 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
4375 * buffer.h (buffer_slot_type_mismatch):
4376 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4377 * eval.c (unwind_to_catch):
4378 * image.c (my_png_error, my_error_exit):
4379 * keyboard.c (quit_throw_to_read_char, user_error)
4380 (Fexit_recursive_edit, Fabort_recursive_edit):
4381 * lisp.h (die, args_out_of_range, args_out_of_range_3)
4382 (wrong_type_argument, buffer_overflow, __executable_start)
4383 (memory_full, buffer_memory_full, string_overflow, Fthrow)
4384 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
4385 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
4386 (fatal):
4387 (child_setup) [!DOS_NT]:
4388 * lread.c (end_of_file_error, invalid_syntax):
4389 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4390 * puresize.h (pure_write_error):
4391 * search.c (matcher_overflow):
4392 * sound.c (sound_perror, alsa_sound_perror):
4393 * sysdep.c, syssignal.h (croak):
4394 * term.c (maybe_fatal, vfatal):
4395 * textprop.c (text_read_only):
4396 * undo.c (user_error):
4397 * unexmacosx.c (unexec_error):
4398 * xterm.c (x_ins_del_lines, x_delete_glyphs):
4399 Use _Noreturn rather than NO_RETURN.
4400 No need for separate decl merely because of _Noreturn.
4401 * sound.c (sound_warning, parse_sound):
4402 Remove unnecessary forward decls.
4403
f1dd8073
PE
44042012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4405
4406 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
4407 * lisp.h (WAIT_READING_MAX): New macro.
4408 * dispnew.c (Fsleep_for, sit_for):
4409 * keyboard.c (kbd_buffer_get_event):
4410 * process.c (Faccept_process_output):
4411 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
4412 This improves on the previous patch, which introduced a bug
4413 when time_t is unsigned and as wide as intmax_t.
4414 See <http://bugs.gnu.org/9000#51>.
4415
b82c1755
EZ
44162012-06-23 Eli Zaretskii <eliz@gnu.org>
4417
4418 * dispnew.c (sit_for, Fsleep_for):
4419 * keyboard.c (kbd_buffer_get_event):
4420 * process.c (Faccept_process_output): Avoid compiler warnings when
4421 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
4422
ca300656
JB
44232012-06-23 Juanma Barranquero <lekktu@gmail.com>
4424
049ec95b
JB
4425 * makefile.w32-in: Update dependencies.
4426
ca300656
JB
4427 * w32.c (ltime): Add return type and declare static.
4428 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
4429
db7b8d06
PE
44302012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4431
4432 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
4433 Privately reported by Herbert J. Skuhra.
4434 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
4435 All uses changed.
4436 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
4437 not make_lisp_timeval, when the argument is of type EMACS_TIME.
4438
0bd8297f
EZ
44392012-06-23 Eli Zaretskii <eliz@gnu.org>
4440
96512555
EZ
4441 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
4442 last argument of make_unibyte_string.
4443
0bd8297f
EZ
4444 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
4445 language ID in the event parameters.
4446
4447 * w32term.c (w32_read_socket): Put the new keyboard codepage into
4448 event.code, not the obscure "character set ID".
4449
63def6b6
CY
44502012-06-23 Chong Yidong <cyd@gnu.org>
4451
4452 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
4453
e8a02204
EZ
44542012-06-23 Eli Zaretskii <eliz@gnu.org>
4455
388cdec0
EZ
4456 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
4457 * w32.c (fdutimens): New function.
4458
4459 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
4460
4461 * s/ms-w32.h (pselect): Redirect to sys_select.
4462
4463 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
4464
e8a02204
EZ
4465 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
4466 in the logic of incrementing and decrementing the value of
4467 use_relocatable_buffers.
4468
d054f3fb
PE
44692012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4470
4471 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
4472 Privately reported by Herbert J. Skuhra.
4473 [__FreeBSD__]: Remove "*/" typo after "#include".
4474 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
4475 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
4476 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
4477 Don't assume EMACS_TIME and struct timeval are the same type.
4478
d35af63c
PE
44792012-06-22 Paul Eggert <eggert@cs.ucla.edu>
4480
4481 Support higher-resolution time stamps (Bug#9000).
4482 The time stamps are only nanosecond-resolution at the C level,
4483 since that's the best that any real-world system supports now.
4484 But they are picosecond-resolution at the Lisp level, as that's
4485 easy, and leaves room for future OS improvements.
4486
4487 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
4488 (LIBES): Use it.
4489
4490 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
4491 Don't get current time unless it's needed.
4492
4493 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
4494 now provides it if it's absent.
4495 (start_atimer): Port to higher-res time stamps.
4496 Check for time stamp overflow. Don't get current time more
4497 often than is needed.
4498
4499 * buffer.h (struct buffer): Buffer modtime now has high resolution.
4500 Include systime.h, not time.h.
4501 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
4502
4503 * dired.c: Include stat-time.h.
4504 (Ffile-attributes): File times now have higher resolution.
4505
4506 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
4507 (struct image): Timestamp now has higher resolution.
4508
4509 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
4510 has at least microseconds now. All uses removed.
4511 (update_frame, update_single_window, update_window, update_frame_1)
4512 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 4513 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
4514
4515 * editfns.c (time_overflow): Now extern.
4516 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
4517 (float-time, Fformat_time_string, Fcurrent_time_string)
4518 (Fcurrent_time_zone): Accept and generate higher-resolution
4519 time stamps.
4520 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
4521 (decode_time_components, lisp_seconds_argument): New functions.
4522 (make_time): Now static.
4523 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
4524 Report an error if the time is invalid, rather than having the caller
4525 do that.
4526
4527 * fileio.c: Include <stat-time.h>
4528 (Fcopy_file): Copy higher-resolution time stamps.
4529 Prefer to set the time stamp via a file descriptor if that works.
4530 (Fset_file_times, Finsert_file_contents, Fwrite_region)
4531 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
4532 (Fvisited_file_modtime, Fset_visited_file_modtime):
4533 Support higher-resolution time stamps.
4534
4535 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
4536
4537 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
4538
4539 * image.c (prepare_image_for_display, clear_image_cache)
4540 (lookup_image): Port to higer-resolution time stamps.
4541
4542 * keyboard.c (start_polling, bind_polling_period):
4543 Check for time stamp overflow.
4544 (read_char, kbd_buffer_get_event, timer_start_idle)
4545 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
4546 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
4547 Port to higher-resolution time stamps. Do not assume time_t is signed.
4548 (decode_timer): New function. Timers are now vectors of length 9,
4549 not 8, to accommodate the picosecond component.
4550 (timer_check_2): Use it.
4551
4552 * nsterm.m (select_timeout, timeval_subtract): Remove.
4553 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
4554 as they're a bit more accurate and handle overflow better.
4555 (ns_select): Change prototype to be compatible with pselect.
4556 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
4557 * nsterm.h (ns_select): Adjust prototype.
4558
4559 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
4560 us-resolution time stamps.
4561 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
4562
4563 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
4564
4565 * lisp.h (time_overflow): New decl.
4566 (wait_reading_process_output): First arg is now intmax_t, not int,
4567 to accommodate larger waits.
4568
4569 * process.h (struct Lisp_Process.read_output_delay):
4570 Now counts nanoseconds, not microseconds.
4571 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
4572 EMACS_HAS_USECS.
4573 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
4574 (wait_reading_process_output):
4575 Port to ns-resolution time stamps.
4576 (Faccept_process_output, wait_reading_process_output):
4577 Check for time stamp overflow. Do not assume time_t is signed.
4578 (select_wrapper): Remove; we now use pselect.
4579 (Fprocess_attributes): Now generates ns-resolution time stamps.
4580
4581 * sysdep.c: Include utimens.h. Don't include utime.h
4582 or worry about struct utimbuf; gnulib does that for us now.
4583 (gettimeofday): Remove; gnulib provides a substitute.
4584 (make_timeval): New function.
4585 (set_file_times): Now sets ns-resolution time stamps.
4586 New arg FD; all uses changed.
4587 (time_from_jiffies, ltime_from_jiffies, get_up_time)
4588 (system_process_attributes):
4589 Now returns ns-resolution time stamp. All uses changed.
4590 Check for time stamp overflow.
4591
4592 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
4593 provides a substitute now.
4594
4595 * systime.h: Include timespec.h rather than sys/time.h and time.h,
4596 since it guarantees struct timespec.
4597 (EMACS_TIME): Now struct timespec, so that we can support
4598 ns-resolution time stamps.
4599 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
4600 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
4601 (EMACS_USECS): Remove.
4602 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
4603 so multiply the arg by 1000 before storing it.
4604 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
4605 New macros.
4606 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
4607 Port to ns-resolution time stamps.
4608 (EMACS_TIME_NEG_P): Remove; replaced by....
4609 (EMACS_TIME_SIGN): New macro.
4610 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
4611 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
4612 (set_file_times, make_time, lisp_time_argument): Adjust signature.
4613 (make_timeval, make_lisp_time, decode_time_components): New decls.
4614 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
4615 that it mishandled time_t overflow. You can't compare by subtracting!
4616 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
4617 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
4618
4619 * term.c: Include <sys/time.h>.
4620 (timeval_to_Time): New function, for proper overflow wraparound.
4621 (term_mouse_position, term_mouse_click): Use it.
4622
4623 * undo.c (record_first_change): Support higher-resolution time stamps
4624 in the undo buffer.
4625 (Fprimitive_undo): Use them when restoring time stamps.
4626
4627 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
4628 (w32_get_internal_run_time):
4629 Port to higher-resolution Emacs time stamps.
4630 (ltime): Now accepts single 64-bit integer, as that's more convenient
4631 for callers.
4632
4633 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
4634
4635 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
4636 for compatibility with pselect. Support ns-resolution time stamps.
4637
4638 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
4639
4640 * xselect.c (wait_for_property_change, x_get_foreign_selection):
4641 Check for time stamp overflow, and support ns-resolution time stamps.
4642
4643 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
4644 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
4645 (timeval_subtract): Remove; no longer needed.
4646 (XTflash, XTring_bell, x_wait_for_event):
4647 Port to ns-resolution time stamps. Don't assume time_t is signed.
4648
b6a92dfe
CY
46492012-06-22 Chong Yidong <cyd@gnu.org>
4650
4651 * xdisp.c (x_consider_frame_title): Revert last change.
4652
d251c37c
EZ
46532012-06-22 Eli Zaretskii <eliz@gnu.org>
4654
4655 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
4656 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
4657 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
4658 staticidx goes up to 1597 out of 1600 = 0x640.)
4659
f10deafb
PE
46602012-06-20 Paul Eggert <eggert@cs.ucla.edu>
4661
4662 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
4663 Otherwise, the umask might be mistakenly 0 while handling input signals.
4664
ec6de1e2
SM
46652012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
4666
4667 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
4668
28be1ada
DA
46692012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
4670
4671 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
4672 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
4673 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
4674 access to `contents' member of Lisp_Vector objects with AREF and ASET
4675 where appropriate.
4676
c6bf3022
CY
46772012-06-19 Chong Yidong <cyd@gnu.org>
4678
4679 * frame.c (delete_frame): When selecting a frame on a different
4680 text terminal, do not alter the terminal's top-frame.
4681
4682 * xdisp.c (format_mode_line_unwind_data): Record the target
4683 frame's selected window and its terminal's top-frame.
4684 (unwind_format_mode_line): Restore them.
4685 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
4686 Callers changed.
4687 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
4688 since tty frames can be explicitly named.
4689 (prepare_menu_bars): Likewise.
4690
4691 * term.c (Ftty_top_frame): New function.
4692
defd4196
PE
46932012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4694
4695 Port byte-code-meter to modern targets.
4696 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
4697 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 4698 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
4699 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
4700 (METER_1, METER_2): Simplify.
4701
1053a871
SM
47022012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
4703
4704 * data.c (Fdefalias): Return `symbol' (bug#11686).
4705
b7e8d081
MR
47062012-06-18 Martin Rudalics <rudalics@gmx.at>
4707
4708 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
4709 gets killed during executing of this function (Bug#11665).
4710 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
4711 (Vkill_buffer_query_functions): In doc-string say that functions
4712 run by this hook should not change the current buffer.
4713
7ea2b339
PE
47142012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4715
4716 Fix recently-introduced process.c problems found by static checking.
4717 * process.c (write_queue_push, write_queue_pop, send_process):
4718 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
4719 (write_queue_pop): Fix pointer signedness problem.
4720 (send_process): Remove unused local.
4721
96a313a1
CY
47222012-06-17 Chong Yidong <cyd@gnu.org>
4723
4724 * xdisp.c (redisplay_internal): No need to redisplay terminal
4725 frames that are not on top.
4726
20ca2e94
TN
47272012-06-17 Troels Nielsen <bn.troels@gmail.com>
4728
4729 * process.c (make_process): Initialize write_queue.
4730 (write_queue_push, write_queue_pop): New functions.
4731 (send_process): Use them to maintain correct ordering of process
4732 writes (Bug#10815).
4733
9a900ca9
PE
47342012-06-17 Paul Eggert <eggert@cs.ucla.edu>
4735
310fbfa8
PE
4736 * lisp.h (eassert): Assume C89 or later.
4737 This removes the need for CHECK.
4738 (CHECK): Remove. Its comments about always evaluating its
4739 argument were confusing, as 'eassert' typically does not evaluate
4740 its argument.
4741
27bb1ca4
PE
4742 * coding.c (produce_chars): Use ptrdiff_t, not int.
4743
9a900ca9
PE
4744 * xterm.c (x_draw_underwave): Check for integer overflow.
4745 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
4746
41b7f8bc 47472012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
4748
4749 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
4750 referenced (Bug#11583).
4751
9b0e3eba
AA
47522012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
4753
4754 Implement wave-style variant of underlining.
4755 * dispextern.h (face_underline_type): New enum.
4756 (face): Add field for underline type.
4757 * nsterm.m (ns_draw_underwave): New function.
4758 (ns_draw_text_decoration): Use it.
4759 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
4760 New functions.
4761 (x_draw_glyph_string): Use them.
4762 * xfaces.c (Qline, Qwave): New Lisp objects.
4763 (check_lface_attrs, merge_face_ref)
1053a871
SM
4764 (Finternal_set_lisp_face_attribute, realize_x_face):
4765 Handle wave-style underline face attributes.
9b0e3eba
AA
4766 * xterm.c (x_draw_underwave): New function.
4767 (x_draw_glyph_string): Use it.
4768
0fb52f11
JB
47692012-06-16 Juanma Barranquero <lekktu@gmail.com>
4770
4771 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
4772 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
4773 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
4774 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
4775 ($(BLD)/w32select.$(O)): Update dependencies.
4776
e5560ff7
AS
47772012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4778
4779 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
4780 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
4781 * character.c (_fetch_multibyte_char_p): Remove.
4782 * alloc.c: Include "character.h" before "buffer.h".
4783 * bidi.c: Likewise.
4784 * buffer.c: Likewise.
4785 * bytecode.c: Likewise.
4786 * callint.c: Likewise.
4787 * callproc.c: Likewise.
4788 * casefiddle.c: Likewise.
4789 * casetab.c: Likewise.
4790 * category.c: Likewise.
4791 * cmds.c: Likewise.
4792 * coding.c: Likewise.
4793 * composite.c: Likewise.
4794 * dired.c: Likewise.
4795 * dispnew.c: Likewise.
4796 * doc.c: Likewise.
4797 * dosfns.c: Likewise.
4798 * editfns.c: Likewise.
4799 * emacs.c: Likewise.
4800 * fileio.c: Likewise.
4801 * filelock.c: Likewise.
4802 * font.c: Likewise.
4803 * fontset.c: Likewise.
4804 * fringe.c: Likewise.
4805 * indent.c: Likewise.
4806 * insdel.c: Likewise.
4807 * intervals.c: Likewise.
4808 * keyboard.c: Likewise.
4809 * keymap.c: Likewise.
4810 * lread.c: Likewise.
4811 * macros.c: Likewise.
4812 * marker.c: Likewise.
4813 * minibuf.c: Likewise.
4814 * nsfns.m: Likewise.
4815 * nsmenu.m: Likewise.
4816 * print.c: Likewise.
4817 * process.c: Likewise.
4818 * regex.c: Likewise.
4819 * region-cache.c: Likewise.
4820 * search.c: Likewise.
4821 * syntax.c: Likewise.
4822 * term.c: Likewise.
4823 * textprop.c: Likewise.
4824 * undo.c: Likewise.
4825 * unexsol.c: Likewise.
4826 * w16select.c: Likewise.
4827 * w32fns.c: Likewise.
4828 * w32menu.c: Likewise.
4829 * window.c: Likewise.
4830 * xdisp.c: Likewise.
4831 * xfns.c: Likewise.
4832 * xmenu.c: Likewise.
4833 * xml.c: Likewise.
4834 * xselect.c: Likewise.
4835
2f07e6af
EZ
48362012-06-16 Eli Zaretskii <eliz@gnu.org>
4837
1053a871
SM
4838 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
4839 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 4840 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
4841 row.
4842 (handle_face_prop): Use chunk-relative overlay string index when
4843 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
4844 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
4845 the rightmost. (Bug#11720)
2f07e6af 4846
29b83cec
AS
48472012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4848
4849 * category.h (CHAR_HAS_CATEGORY): Define as inline.
4850 (CATEGORY_MEMBER): Enforce 1/0 value.
4851 * category.c (_temp_category_set): Remove.
4852
4c5501e9
EZ
48532012-06-16 Eli Zaretskii <eliz@gnu.org>
4854
4855 * window.c (Fdelete_other_windows_internal)
4856 (Fdelete_window_internal): Don't access frame's mouse highlight
4857 info of the initial frame. (Bug#11677)
4858
2b570124
PE
48592012-06-14 Paul Eggert <eggert@cs.ucla.edu>
4860
e93864f9
PE
4861 * .gdbinit (xgetint): Fix recently-introduced paren typo.
4862 Assume USE_2_TAGS_FOR_INTS.
4863 (xreload): Adjust $tagmask width to match recent lisp.h change.
4864
2b570124
PE
4865 Simplify lisp.h in minor ways that should not affect code.
4866 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
4867 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
4868 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
4869 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
4870 (INTTYPEBITS): New macro, for clarity.
4871 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
4872 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
4873 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
4874 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
4875 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
4876
81755f69
JB
48772012-06-13 Juanma Barranquero <lekktu@gmail.com>
4878
4879 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
4880
16192a57
GM
48812012-06-13 Glenn Morris <rgm@gnu.org>
4882
4883 * s/bsd-common.h (BSD4_3):
4884 * s/usg5-4-common.h (USG5_4): No longer define; unused.
4885
646b5f55
AS
48862012-06-13 Andreas Schwab <schwab@linux-m68k.org>
4887
4888 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
4889 instead of union.
4890 (XLI, XIL): Define.
1053a871
SM
4891 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
4892 Use them.
4893 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 4894 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 4895 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
4896 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
4897 * frame.c (delete_frame): Remove outdated comment.
4898 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
4899 USE_LISP_UNION_TYPE.
4900 (Fw32_unregister_hot_key): Likewise.
4901 (Fw32_toggle_lock_key): Likewise.
4902 * w32menu.c (add_menu_item): Likewise.
4903 (w32_menu_display_help): Use XIL instead of checking
4904 USE_LISP_UNION_TYPE.
4905 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
4906 (init_heap): Likewise.
4907 * w32term.c (w32_read_socket): Update comment.
4908
1d3823c9
GM
49092012-06-13 Glenn Morris <rgm@gnu.org>
4910
c62ff706
GM
4911 * s/usg5-4-common.h, src/s/unixware.h:
4912 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
4913
1d3823c9
GM
4914 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
4915
bfe3e0a2
PE
49162012-06-13 Paul Eggert <eggert@cs.ucla.edu>
4917
4918 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
4919 * alloc.c (make_number) [!defined make_number]:
4920 Remove, as lisp.h always defines this now.
4921 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
4922 (roundup_size): Verify that it is a power of 2.
4923 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
4924 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
4925 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
4926 -DUSE_LSB_TAG=0, to override the automatically-selected default.
4927 USE_LSB_TAG now is always defined to be either 0 or 1.
4928 All uses changed.
4929 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
4930 code works fine either way, and efficiency is not a concern here,
4931 as the union type is for debugging, not for production.
4932 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
4933 Use an inline function on all platforms when using the union type,
4934 since this is simpler and 'static inline' can be used portably
4935 within Emacs now.
4936 (LISP_INITIALLY_ZERO): New macro.
4937 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
4938 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
4939
45fa9c0f
GM
49402012-06-12 Glenn Morris <rgm@gnu.org>
4941
b4492cba
GM
4942 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
4943
4944 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 4945
45fa9c0f
GM
4946 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
4947 Move BROKEN_SIGIO to configure.
4948
4949 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
4950 Move NO_TERMIO to configure.
4951
0e25d334
CY
49522012-06-12 Chong Yidong <cyd@gnu.org>
4953
4954 * image.c (imagemagick_load_image): Use MagickFlattenImage if
4955 MagickMergeImageLayers is undefined. Use pixel pusher loop if
4956 MagickExportImagePixels is undefined.
4957
43682bb6
PE
49582012-06-12 Paul Eggert <eggert@cs.ucla.edu>
4959
4960 * image.c (imagemagick_load_image): Remove unused label.
4961
a9be7d2b
GM
49622012-06-11 Glenn Morris <rgm@gnu.org>
4963
4964 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4965 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
4966 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
4967 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
4968
3017f87f
SM
49692012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
4970
4971 * alloc.c (make_byte_code): New function.
4972 (Fmake_byte_code): Use it. Don't purify here.
4973 * lread.c (read1): Use it as well to avoid extra allocation.
4974
1b9b4cf4
CY
49752012-06-11 Chong Yidong <cyd@gnu.org>
4976
4977 * image.c (imagemagick_load_image): Implement transparency.
4978
95988fcf
AS
49792012-06-10 Andreas Schwab <schwab@linux-m68k.org>
4980
4981 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
4982 account for preceding backslashes. (Bug#11663)
4983
cd4eb164
CY
49842012-06-09 Chong Yidong <cyd@gnu.org>
4985
4986 * term.c: Support italics in capable terminals (Bug#9652).
4987 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
4988 (turn_on_face): Output using TS_enter_italic_mode if available.
4989 Don't handle unused blinking and alt-charset cases.
4990 (turn_off_face): Handle italic case; discard unused tty_blinking_p
4991 and tty_alt_charset_p cases.
4992 (tty_capable_p, init_tty): Support italics.
4993
4994 * termchar.h (struct tty_display_info): Add field for italics.
4995 Remove unused blink field.
4996
4997 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
4998 Handle slant.
4999
5000 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
5001 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
5002 tty_alt_charset_p. Add tty_italic_p.
5003
ff88beb8
MA
50042012-06-09 Michael Albinus <michael.albinus@gmx.de>
5005
5006 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
5007 dbus_type_is_basic if available.
5008 (xd_extract_signed, xd_extract_unsigned): Rename from
5009 extract_signed and extract_unsigned, respectively. Adapt callers.
5010
44286096
CY
50112012-06-09 Chong Yidong <cyd@gnu.org>
5012
1682701f
CY
5013 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
5014
44286096
CY
5015 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
5016 case (Bug#9752).
5017
d86feb17
PE
50182012-06-08 Paul Eggert <eggert@cs.ucla.edu>
5019
5020 * xdisp.c (vmessage): Treat frame message as multibyte.
5021 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
5022 would generate the diagnostic "Making \302\247 buffer-local while
5023 let-bound!".
5024
d5c20fe8
EZ
50252012-06-08 Eli Zaretskii <eliz@gnu.org>
5026
5027 * dispnew.c (showing_window_margins_p): Undo last change, which
5028 was done due to an inadvertent commit.
5029 (adjust_frame_glyphs_for_frame_redisplay): Do call
5030 showing_window_margins_p.
5031
513749ee
SM
50322012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5033
5034 * eval.c (Fmake_var_non_special): New primitive.
5035 (syms_of_eval): Defsubr it.
5036 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
5037
d4a8f5c1
JB
50382012-06-08 Juanma Barranquero <lekktu@gmail.com>
5039
5040 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
5041 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
5042
8bbbc977
EZ
50432012-06-08 Eli Zaretskii <eliz@gnu.org>
5044
5045 * alloc.c (allocate_vectorlike): Fix last change.
5046
f3372c87
DA
50472012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
5048
5049 Block-based vector allocation of small vectors.
5050 * lisp.h (struct vectorlike_header): New field `nbytes',
5051 adjust comment accordingly.
5052 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
5053 to denote vector blocks. Adjust users (live_vector_p,
5054 mark_maybe_pointer, valid_lisp_object_p) accordingly.
5055 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
5056 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
5057 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
5058 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
5059 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
5060 (roundup_size): New constant.
5061 (struct vector_block): New data type.
5062 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 5063 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
5064 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
5065 (sweep_vectors): New functions.
5066 (allocate_vectorlike): Return `zero_vector' as the only vector of
5067 0 items. Allocate new vector from block if vector size is less than
5068 or equal to VBLOCK_BYTES_MAX.
5069 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
5070 (init_alloc_once): Add call to init_vectors.
5071
4f18a4ed
SM
50722012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5073
5074 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
5075
86f158bc
PE
50762012-06-07 Paul Eggert <eggert@cs.ucla.edu>
5077
5078 * doprnt.c (doprnt): Truncate multibyte char correctly.
5079 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
5080 would mishandle a string argument "Xc" if X was a multibyte
5081 character of length 2: it would truncate after X's first byte
5082 rather than including all of X.
5083
c5cfcbe0
CY
50842012-06-06 Chong Yidong <cyd@gnu.org>
5085
5086 * buffer.c (word_wrap): Doc fix.
5087
c05cf390
PE
50882012-06-04 Paul Eggert <eggert@cs.ucla.edu>
5089
5090 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
5091
0c3461de
GM
50922012-06-03 Glenn Morris <rgm@gnu.org>
5093
5094 * xdisp.c (tool-bar-style): Doc fix.
5095
c71232db
UM
50962012-06-03 Ulrich Müller <ulm@gentoo.org>
5097
5098 * Makefile.in (PAXCTL): Define.
5099 (temacs$(EXEEXT)): Disable memory randomization for the temacs
5100 binary via PaX flags if the paxctl utility is available.
5101 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
5102 Restore PaX flags to their default. (Bug#11398)
5103
383f7350
CY
51042012-06-03 Chong Yidong <cyd@gnu.org>
5105
5106 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
5107 buffer (Bug#11226).
5108
5f2c76c6
CY
51092012-06-03 Chong Yidong <cyd@gnu.org>
5110
5111 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
5112 (note_mode_line_or_margin_highlight): If there is no help echo,
5113 use mode-line-default-help-echo. Handle the case where the mouse
5114 position is past the end of the mode line string.
5115
5116 * buffer.c (buffer_local_value_1): New function, split from
5117 Fbuffer_local_value; can return Qunbound.
5118 (Fbuffer_local_value): Use it.
5119 (Vmode_line_format): Docstring tweaks.
5120
773d47f6
PE
51212012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5122
5123 * sysdep.c (system_process_attributes): Improve comment.
5124
f2d6a3df
SM
51252012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
5126
5127 * keyboard.c: Export real-this-command to Elisp.
5128 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
5129 and DEFVAR it. Update all users.
5130
63810350
PE
51312012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5132
7bd5c1f4
PE
5133 * minibuf.c (Fassoc_string): Remove duplicate declaration.
5134
63810350
PE
5135 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
5136 Convert pctcpu and pctmem to Lisp float properly.
5137 Let the compiler fold better, as 100.0/0x8000 is exact.
5138
a2821611
AS
51392012-06-02 Andreas Schwab <schwab@linux-m68k.org>
5140
5141 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
5142 cons_block.
5143
5fceba1d
PE
51442012-06-01 Paul Eggert <eggert@cs.ucla.edu>
5145
5146 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
5147
c98ff5dd
DA
51482012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
5149
5150 For a 'struct window', replace some Lisp_Object fields to
5151 bitfields where appropriate, remove unused fields.
5152 * window.h (struct window): Remove unused 'last_mark_x' and
5153 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
5154 change it's type from Lisp_Object to bitfield.
5155 Change type of 'force_start', 'optional_new_start',
5156 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
5157 fields from Lisp_Object to bitfield. Adjust users accordingly.
5158
ca34e0be
PE
51592012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5160
5161 Pacify gcc -Wdouble-precision when using Xaw.
5162 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
5163 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
5164 Use 'float' consistently, rather than 'float' in most places
5165 and 'double' in a couple of places.
5166
efc00ab1 51672012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
5168
5169 * xdisp.c (handle_stop): Detect whether we have overlay strings
5170 loaded by testing it->current.overlay_string_index to be
5171 non-negative, instead of checking whether n_overlay_strings is
5172 positive. (Bug#11587)
5173
efc00ab1 51742012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
5175
5176 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
5177
5178 * doc.c (Fsubstitute_command_keys): Doc fix.
5179
efc00ab1 51802012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
5181
5182 * search.c (search_buffer): Remove calls to
5183 r_alloc_inhibit_buffer_relocation, as it is now called by
5184 maybe_unify_char, which was the cause of relocation of buffer text
5185 in bug#11519.
5186
efc00ab1 51872012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
5188
5189 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
5190 for the duration of call to load_charset, to avoid problems with
5191 callers of maybe_unify_char that access buffer text through C
5192 pointers.
5193
5194 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
5195 decrement the inhibition flag, instead of just setting or
5196 resetting it.
5197
ba93a187
PE
51982012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5199
5200 Remove obsolete '#define static' cruft.
5201 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
5202 This #undef was "temporary" in 2000; it is no longer needed
5203 now that '#define static' has gone away.
5204 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
5205 (gray_bitmap_bits): Remove; no longer needed.
5206 All uses replaced with definiens.
5207 * xterm.c: Include "bitmaps/gray.xbm".
5208
9e4bf381
PE
52092012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5210
5211 Clean up __executable_start, monstartup when --enable-profiling.
5212 The following changes affect the code only when profiling.
5213 * dispnew.c (__executable_start): Rename from safe_bcopy.
5214 Define only on platforms that need it.
5215 * emacs.c: Include <sys/gmon.h> when profiling.
5216 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
5217 (__executable_start): Remove decl, since lisp.h does it now.
5218 (safe_bcopy): Remove decl; no longer has that name.
5219 (main): Coalesce #if into single bit of code, for simplicity.
5220 Cast pointers to uintptr_t, since standard libraries want integers
5221 and not pointers.
5222 * lisp.h (__executable_start): New decl.
5223
32d72c2f
GM
52242012-05-31 Glenn Morris <rgm@gnu.org>
5225
5226 * image.c (Fimagemagick_types): Doc fix.
5227
baac5bc7
JM
52282012-05-30 Jim Meyering <meyering@redhat.com>
5229
5230 * callproc.c (Fcall_process_region): Include directory component
5231 in mkstemp error message (Bug#11586).
5232
72cb32cf
PE
52332012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5234
5235 * alloc.c, lisp.h (make_pure_vector): Now static.
5236
61b108cc
SM
52372012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
5238
5239 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
5240 Move to byte-run.el.
5241 (Fautoload): Do the hash-doc more carefully.
5242 * data.c (Fdefalias): Purify definition, except for keymaps.
5243 (Qdefun): Move from eval.c.
5244 * lisp.h (Qdefun): Remove.
5245 * lread.c (read1): Tiny simplification.
5246
471fe23d
TN
52472012-05-29 Troels Nielsen <bn.troels@gmail.com>
5248
934f3f58 5249 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
5250 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
5251 Bug#9642, but explicitly check that the buffer the overlay would
5252 be moved to is live and rearrange lines to make sure that errors
5253 will not put the overlay in an inconsistent state.
5254 (Fdelete_overlay): Cosmetics.
5255
85d0efd1
EZ
52562012-05-28 Eli Zaretskii <eliz@gnu.org>
5257
5258 * w32term.c (my_bring_window_to_top): New function.
5259 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
5260 could be different from the original one.
5261 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
5262 (Bug#11513)
5263
5264 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
5265 by calling BringWindowToTop.
5266
5267 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
5268 (WM_EMACS_END): Increase by one.
5269
da92a98c
PE
52702012-05-28 Paul Eggert <eggert@cs.ucla.edu>
5271
5272 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
5273 This avoids undefined behavior that might cause the eassert
5274 to not catch an out-of-range value.
5275
74d1f848
JB
52762012-05-28 Juanma Barranquero <lekktu@gmail.com>
5277
5278 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
5279 Update dependencies.
5280
9e1a06fc
EZ
52812012-05-27 Eli Zaretskii <eliz@gnu.org>
5282
5283 * bidi.c (bidi_mirror_char): Fix last change.
5284
f3dd7312
AS
52852012-05-27 Andreas Schwab <schwab@linux-m68k.org>
5286
5287 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
5288 when referring to sectname field in printf format.
5289
81899c91
PE
52902012-05-27 Paul Eggert <eggert@cs.ucla.edu>
5291
57b81a9f
PE
5292 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
5293 Only r_alloc_inhibit_buffer_relocation needed to be added;
5294 the others were already declared.
5295
81899c91
PE
5296 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
5297 before checking whether it's out of range. Put the check inside
5298 eassert. See
5299 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
5300
33017faf 53012012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
5302
5303 * callproc.c (Fcall_process): Restore a line that was accidentally
5304 commented out in the 2011-02-13 change (bug#11547).
5305
33017faf 53062012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
5307
5308 * lisp.h [REL_ALLOC]: Add prototypes for external functions
5309 defined on ralloc.c.
5310
5311 * buffer.c [REL_ALLOC]: Remove prototypes of
5312 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
5313 they are now on lisp.h.
5314
5315 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
5316
5317 * search.c (search_buffer): Use it to inhibit relocation of buffer
5318 text while re_search_2 is doing its job, because re_search_2 is
5319 passed C pointers to buffer text. (Bug#11519)
5320
23415acf
EZ
5321 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
5322 Update value to 24.
5323
44e27368
EZ
5324 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
5325 state after an additional call to move_it_in_display_line_to, keep
5326 the values of it->max_ascent and it->max_descent found for the
5327 entire line.
5328 (pos_visible_p): Revert the comparison against bottom_y to what it
5329 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
5330 (Bug#11464)
5331
c1892f11
PE
53322012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5333
5334 Fix coding-related core dumps with gcc -ftrapv.
5335 The code was computing A - B, where A and B are pointers, and B is
5336 random garbage. This can lead to core dumps on platforms that
5337 have special pointer registers, and it also leads to core dumps on
5338 x86-64 when compiled with gcc -ftrapv. The fix is to compute
5339 A - B only when B is initialized properly.
5340 * coding.c (coding_set_source, coding_set_destination): Return void.
5341 (coding_change_source, coding_change_destinations): New functions,
5342 with the old behaviors of coding_set_source and coding_set_destination.
5343 All callers that need an offset changed to use these new functions.
5344
eb7afdad
GM
53452012-05-26 Glenn Morris <rgm@gnu.org>
5346
5347 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5348
f12fdf02
EZ
53492012-05-26 Eli Zaretskii <eliz@gnu.org>
5350
53a63be6 5351 Extend mouse support on W32 text-mode console.
61b108cc
SM
5352 * xdisp.c (draw_row_with_mouse_face):
5353 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 5354
eb3f6f01 5355 * w32console.c: Include window.h.
61b108cc
SM
5356 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
5357 New functions.
eb3f6f01
EZ
5358 (initialize_w32_display): Initialize mouse-highlight data.
5359
53a63be6
EZ
5360 * w32inevt.c: Include termchar.h and window.h.
5361 (do_mouse_event): Support mouse-autoselect-window. When the mouse
5362 moves, call note_mouse_highlight. If help_echo changed, call
5363 gen_help_event to produce help-echo message in the echo area.
5364 Call clear_mouse_face if mouse_face_hidden is set in the mouse
5365 highlight info.
5366
4cfd81f6
PE
53672012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5368
5369 * lread.c (read1): Simplify slightly to avoid an overflow warning
5370 with GCC 4.7.0 on x86-64.
5371
4446092a
EZ
53722012-05-26 Eli Zaretskii <eliz@gnu.org>
5373
5374 * bidi.c (bidi_mirror_char): Revert last change: an int is
5375 definitely wide enough here.
5376
42b2a986 53772012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 5378
42b2a986 5379 Fix integer width and related bugs (Bug#9874).
eb106a49 5380 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5381 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5382 (string_bytes, check_sblock, allocate_string_data):
5383 (compact_small_strings, Fmake_bool_vector, make_string)
5384 (make_unibyte_string, make_multibyte_string)
5385 (make_string_from_bytes, make_specified_string)
5386 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
5387 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
5388 (mark_vectorlike):
5389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5390 (allocate_pseudovector):
5391 Use int, not EMACS_INT, where int is wide enough.
5392 (inhibit_garbage_collection, Fgarbage_collect):
5393 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5394 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
5395 int might not be wide enough.
5396 (bidi_cache_search, bidi_cache_find, bidi_init_it)
5397 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
5398 (bidi_at_paragraph_end, bidi_find_paragraph_start)
5399 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5400 (bidi_level_of_next_char, bidi_move_to_visually_next):
5401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5402 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
5403 (Fkill_buffer, Fset_buffer_major_mode)
5404 (advance_to_char_boundary, Fbuffer_swap_text)
5405 (Fset_buffer_multibyte, overlays_at, overlays_in)
5406 (overlay_touches_p, struct sortvec, record_overlay_string)
5407 (overlay_strings, recenter_overlay_lists)
5408 (adjust_overlays_for_insert, adjust_overlays_for_delete)
5409 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
5410 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
5411 (Foverlay_recenter, last_overlay_modification_hooks_used)
5412 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
5413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
5414 (validate_region): Omit unnecessary test for b <= e,
5415 since that's guaranteed by the previous test.
d311d28c
PE
5416 (adjust_overlays_for_delete): Avoid pos + length overflow.
5417 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
5418 (report_overlay_modification):
5419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5420 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
5421 Omit pointer cast, which isn't needed anyway, and doesn't work
5422 after the EMACS_INT -> ptrdiff_t change.
02481186 5423 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
5424 * buffer.h: Adjust decls to match defn changes elsewhere.
5425 (struct buffer_text, struct buffer):
5426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5427 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
5428 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
5429 not int, to avoid needless 32-bit limit on 64-bit hosts.
5430 (exec_byte_code): Use tighter memory-full test, one that checks
5431 for alloca overflow. Don't compute the address of the object just
5432 before an array, as that's not portable. Use EMACS_INT, not
5433 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
5434 * callint.c (Fcall_interactively):
5435 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5436 * callproc.c (call_process_kill, Fcall_process):
5437 Don't assume pid_t fits into an Emacs fixnum.
5438 (call_process_cleanup, Fcall_process, child_setup):
5439 Don't assume pid_t fits into int.
5440 (call_process_cleanup, Fcall_process, delete_temp_file)
5441 (Fcall_process_region):
5442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5443 (Fcall_process): Simplify handling of volatile integers.
5444 Use int, not EMACS_INT, where int will do.
5445 * casefiddle.c (casify_object, casify_region, operate_on_word)
5446 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
5447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5448 (casify_object): Avoid integer overflow when overallocating buffer.
5449 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 5450 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
5451 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
5452 * category.h (CATEGORYP): Don't assume arg is nonnegative.
5453 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
5454 integers are now checked earlier. All uses replaced with XINT.
5455 (ccl_driver):
5456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5457 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
5458 (ccl_driver, Fregister_code_conversion_map):
5459 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
5460 (resolve_symbol_ccl_program): Check that vector header is in range.
5461 Always copy the vector, so that we can check its contents reliably
5462 now rather than having to recheck each instruction as it's being
5463 executed. Check that vector words fit in 'int'.
5464 (ccl_get_compiled_code, Fregister_ccl_program)
5465 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
5466 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
5467 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
5468 contents are in range.
5469 (Fccl_execute_on_string): Check that status is in range.
5470 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
5471 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
5472 Accept and return EMACS_INT, not int, because callers can pass values
5473 out of 'int' range.
5474 (c_string_width, strwidth, lisp_string_width, chars_in_text)
5475 (multibyte_chars_in_text, parse_str_as_multibyte)
5476 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
5477 (str_as_unibyte, str_to_unibyte, string_count_byte8)
5478 (string_escape_byte8, Fget_byte):
5479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 5480 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
5481 avoid mishandling large integers.
5482 * character.h: Adjust decls to match defn changes elsewhere.
5483 * charset.c (load_charset_map_from_file, find_charsets_in_text)
5484 (Ffind_charset_region):
5485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5486 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
5487 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 5488 Don't assume fixnum fits in int.
d311d28c
PE
5489 (load_charset_map_from_vector, Fmap_charset_chars):
5490 Remove now-unnecessary CHECK_NATNUMs.
5491 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
5492 Don't rely on undefined behavior with signed left shift overflow.
5493 Don't assume unsigned int fits into fixnum, or that fixnum fits
5494 into unsigned int. Don't require max_code to be a valid fixnum;
5495 that's not true for gb10830 4-byte on a 32-bit host. Allow
5496 invalid_code to be a cons, for the same reason. Require code_offset
5497 to be a character. Avoid int overflow if max_char is close
5498 to INT_MAX.
5499 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
5500 this is intended anyway and avoids some undefined behavior.
5501 (load_charset_map): Pass unsigned, not int, as 2nd arg of
5502 INDEX_TO_CODE_POINT, as that's what it expects.
5503 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
5504 * charset.h (DECODE_CHAR): Return int, not unsigned;
5505 this is what was intended anyway, and it avoids undefined behavior.
5506 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
5507 integer-overflow issues.
5508 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
5509 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
5510 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
5511 * chartab.c (Fmake_char_table, Fset_char_table_range)
5512 (uniprop_get_decoder, uniprop_get_encoder):
5513 Don't assume fixnum fits in int.
5514 * cmds.c (move_point): New function, that does the gist of
5515 Fforward_char and Fbackward_char, but does so while checking
5516 for integer overflow more accurately.
c96e5d6a 5517 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
5518 (Fforward_line, Fend_of_line, internal_self_insert)
5519 (internal_self_insert):
5520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5521 Fix a FIXME, by checking for integer overflow when calculating
5522 target_clm and actual_clm.
5523 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 5524 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
5525 (ASSURE_DESTINATION, coding_alloc_by_realloc)
5526 (coding_alloc_by_making_gap, alloc_destination)
5527 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
5528 (encode_coding_utf_16, detect_coding_emacs_mule)
5529 (decode_coding_emacs_mule, encode_coding_emacs_mule)
5530 (detect_coding_iso_2022, decode_coding_iso_2022)
5531 (encode_invocation_designation, encode_designation_at_bol)
5532 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5533 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
5534 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
5535 (encode_coding_ccl, encode_coding_raw_text)
5536 (detect_coding_charset, decode_coding_charset)
5537 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
5538 (produce_composition, produce_charset, produce_annotation)
5539 (decode_coding, handle_composition_annotation)
5540 (handle_charset_annotation, consume_chars, decode_coding_gap)
5541 (decode_coding_object, encode_coding_object, detect_coding_system)
5542 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
5543 (code_convert_region, code_convert_string)
8f50130c
PE
5544 (Fdefine_coding_system_internal)
5545 (coding_set_source, coding_set_destination):
d311d28c
PE
5546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5547 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
5548 (Fdefine_coding_system_internal):
5549 Don't assume fixnums fit in int.
5550 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 5551 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
5552 (Funencodable_char_position, Fcheck_coding_systems_region)
5553 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 5554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 5555 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 5556 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 5557 Don't access memory outside of the args array.
d311d28c 5558 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
5559 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
5560 result of ENCODE_CHAR.
d311d28c
PE
5561 * coding.h: Adjust decls to match defn changes elsewhere.
5562 (struct coding_system):
5563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5564 * composite.c (get_composition_id, find_composition)
5565 (run_composition_function, update_compositions)
5566 (compose_text, composition_gstring_put_cache)
5567 (composition_gstring_p, composition_gstring_width)
5568 (fill_gstring_header, fill_gstring_body, autocmp_chars)
5569 (composition_compute_stop_pos, composition_reseat_it)
5570 (composition_update_it, struct position_record)
5571 (find_automatic_composition, composition_adjust_point)
5572 (Fcomposition_get_gstring, Ffind_composition_internal):
5573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5574 (update_compositions):
5575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5576 * composite.h: Adjust decls to match defn changes elsewhere.
5577 (struct composition):
5578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5579 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
5580 Do not attempt to compute the address of the object just before a
5581 buffer; this is not portable.
5582 (Faref, Faset):
5583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5584 (Faset): Use int, not EMACS_INT, where int is wide enough.
5585 (Fstring_to_number): Don't assume fixnums fit in int.
5586 (Frem): Don't assume arg is nonnegative.
5587 * dbusbind.c (xd_append_arg): Check for integers out of range.
5588 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 5589 (extract_signed, extract_unsigned): New functions.
243e0530
PE
5590 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
5591 (xd_get_connection_references): Return ptrdiff_t, not int.
5592 All uses changed.
5593 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
5594 (xd_read_message_1):
5595 Use int, not unsigned, where the dbus API uses int.
5596 (Fdbus_message_internal): Don't overflow mtype.
5597 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
5598 * dired.c (directory_files_internal, file_name_completion, scmp)
5599 (file_name_completion_stat):
5600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5601 (file_name_completion): Don't overflow matchcount.
5602 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
5603 * dispextern.h: Adjust decls to match defn changes elsewhere.
5604 (struct text_pos, struct glyph, struct bidi_saved_info)
5605 (struct bidi_string_data, struct bidi_it, struct composition_it)
5606 (struct it):
5607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5608 (struct display_pos, struct composition_it, struct it):
5609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5610 * dispnew.c (increment_matrix_positions)
5611 (increment_row_positions, mode_line_string)
5612 (marginal_area_string):
5613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 5614 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
5615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5616 (duration_to_sec_usec): New function, to check for overflow better.
5617 (Fsleep_for, sit_for): Use it.
5618 * doc.c (get_doc_string, store_function_docstring):
5619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5620 (get_doc_string, Fsnarf_documentation):
5621 Use int, not EMACS_INT, where int is wide enough.
5622 (get_doc_string):
5623 Use SAFE_ALLOCA, not alloca.
5624 Check for overflow when converting EMACS_INT to off_t.
5625 * doprnt.c (doprnt):
5626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5627 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
5628 Don't assume uid_t fits into fixnum.
5629 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
5630 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
5631 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
5632 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
5633 (general_insert_function)
5634 (Finsert_char, make_buffer_string, make_buffer_string_both)
5635 (update_buffer_properties, Fbuffer_substring)
5636 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
5637 (Fsubst_char_in_region, check_translation)
5638 (Ftranslate_region_internal, save_restriction_restore, Fformat)
5639 (transpose_markers, Ftranspose_regions):
5640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5641 (clip_to_bounds): Move to lisp.h as an inline function).
5642 (Fconstrain_to_field): Don't assume integers are nonnegative.
5643 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
5644 (Fsubst_char_in_region, Fsave_restriction):
5645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5646 (Femacs_pid): Don't assume pid_t fits into fixnum.
5647 (lo_time): Use int, not EMACS_INT, when int suffices.
5648 (lisp_time_argument): Check for usec out of range.
5649 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
5650 (Fuser_login_name, Fuser_full_name): Signal an error
5651 if a uid argument is out of range, rather than relying on
5652 undefined behavior.
c8d5c857
PE
5653 (Fformat_time_string): Remove now-unnecessary check.
5654 lisp_time_argument checks for out-of-range usec now.
243e0530 5655 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
5656 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
5657 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
5658 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
5659 (init_cmdargs, Fdump_emacs):
5660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5661 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
5662 the bottom (typically) 32 bits of the fixnum.
5663 * eval.c (specpdl_size, call_debugger):
5664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5665 (when_entered_debugger, Fbacktrace_debug):
5666 Don't assume fixnum can fit in int.
5667 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
5668 the object just before a buffer; this is not portable.
5669 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
5670 (grow_specpdl, unbind_to):
5671 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5672 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
5673 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 5674 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
5675 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
5676 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
5677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5678 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
5679 (a_write, e_write):
5680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5681 (Fcopy_file, non_regular_nbytes, read_non_regular)
5682 (Finsert_file_contents):
5683 Use int, not EMACS_INT, where int is wide enough.
5684 (READ_BUF_SIZE): Verify that it fits in int.
5685 (Finsert_file_contents): Check that counts are in proper range,
5686 rather than assuming fixnums fit into ptrdiff_t etc.
5687 Don't assume fixnums fit into int.
125b3835 5688 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
5689 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
5690 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
5691 (string_char_to_byte, string_byte_to_char)
5692 (string_make_multibyte, string_to_multibyte)
5693 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
5694 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
5695 (substring_both, Fdelete, internal_equal, Ffillarray)
5696 (Fclear_string, mapcar1)
5697 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
5698 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
5699 (larger_vector, make_hash_table, maybe_resize_hash_table)
5700 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
5701 (Fmaphash, secure_hash):
5702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5703 (concat): Check for string index and length overflow.
5704 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
5705 (Frequire):
5706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5707 (larger_vector): New API (vec, incr_min, size_max) replaces old
5708 one (vec, new_size, init). This catches size overflow.
5709 INIT was removed because it was always Qnil.
5710 All callers changed.
5711 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
5712 the upper bound on a hash table index size.
5713 (make_hash_table, maybe_resize_hash_table): Use it.
5714 (secure_hash): Computer start_byte and end_byte only after
5715 they're known to be in ptrdiff_t range.
5716 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
5717 (Ffont_get_glyphs, Ffont_at):
5718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5719 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
5720 (Flist_fonts, Fopen_font):
5721 Don't assume fixnum can fit in int.
5722 (check_gstring): Don't assume index can fit in int.
5723 (font_match_p): Check that fixnum is a character, not a nonnegative
5724 fixnum, since the later code needs to stuff it into an int.
5725 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
5726 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
5727 conversion overflow issues.
5728 (Fopen_font): Check for integer out of range.
5729 (Ffont_get_glyphs): Don't assume index can fit in int.
5730 * font.h: Adjust decls to match defn changes elsewhere.
5731 * fontset.c (reorder_font_vector): Redo score calculation to avoid
5732 integer overflow.
5733 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
5734 printmax_t, where ptrdiff_t is wide enough.
5735 (Finternal_char_font):
5736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5737 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
5738 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
5739 (Fset_frame_position, x_set_frame_parameters)
5740 (x_set_line_spacing, x_set_border_width)
5741 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
5742 Check that fixnums are in proper range for system types.
5743 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
5744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5745 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
5746 Use SAFE_ALLOCA_LISP, not alloca.
5747 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
5748 intptr_t is wide enough.
5749 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
5750 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
5751 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
5752 Check for fixnum out of range.
5753 * ftfont.c (ftfont_list): Don't assume index fits in int.
5754 Check that fixnums are in proper range for system types.
5755 (ftfont_shape_by_flt):
5756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
5757 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5759 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
5760 Check that fixnums are in proper range for system types.
5761 * gnutls.h: Adjust decls to match defn changes elsewhere.
5762 * gtkutil.c (xg_dialog_run):
5763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5764 (update_frame_tool_bar):
5765 Check that fixnums are in proper range for system types.
5766 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 5767 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
5768 * indent.c (last_known_column, last_known_column_point):
5769 (current_column_bol_cache):
5770 (skip_invisible, current_column, check_display_width):
5771 (check_display_width, scan_for_column, current_column_1)
5772 (Findent_to, Fcurrent_indentation, position_indentation)
5773 (indented_beyond_p, Fmove_to_column, compute_motion):
5774 (Fcompute_motion, Fvertical_motion):
5775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5776 (last_known_column_modified): Use EMACS_INT, not int.
5777 (check_display_width):
5778 (Fcompute_motion):
5779 Check that fixnums and floats are in proper range for system types.
5780 (compute_motion): Don't assume index or fixnum fits in int.
5781 (compute_motion, Fcompute_motion):
5782 Use int, not EMACS_INT, when it is wide enough.
5783 (vmotion): Omit local var start_hpos that is always 0; that way
5784 we don't need to worry about overflow in expressions involving it.
5785 * indent.h: Adjust decls to match defn changes elsewhere.
5786 (struct position):
5787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5788 Use int, not EMACS_INT, where int is wide enough.
5789 Remove unused members ovstring_chars_done and tab_offset;
5790 all uses removed.
5791 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
5792 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
5793 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
5794 (make_gap, copy_text, insert, insert_and_inherit)
5795 (insert_before_markers, insert_before_markers_and_inherit)
5796 (insert_1, count_combining_before, count_combining_after)
5797 (insert_1_both, insert_from_string)
5798 (insert_from_string_before_markers, insert_from_string_1)
5799 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
5800 (adjust_after_replace, adjust_after_insert, replace_range)
5801 (replace_range_2, del_range, del_range_1, del_range_byte)
5802 (del_range_both, del_range_2, modify_region)
5803 (prepare_to_modify_buffer, signal_before_change)
5804 (signal_after_change, Fcombine_after_change_execute):
5805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5806 * intervals.c (traverse_intervals, rotate_right, rotate_left)
5807 (balance_an_interval, split_interval_right, split_interval_left)
5808 (find_interval, next_interval, update_interval)
5809 (adjust_intervals_for_insertion, delete_node, delete_interval)
5810 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5811 (static_offset_intervals, offset_intervals)
5812 (merge_interval_right, merge_interval_left, make_new_interval)
5813 (graft_intervals_into_buffer, temp_set_point_both)
5814 (temp_set_point, set_point, adjust_for_invis_intang)
5815 (set_point_both, move_if_not_intangible, get_property_and_range)
5816 (get_local_map, copy_intervals, copy_intervals_to_string)
5817 (compare_string_intervals, set_intervals_multibyte_1):
5818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5819 * intervals.h: Adjust decls to match defn changes elsewhere.
5820 (struct interval):
5821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5822 * keyboard.c (this_command_key_count, this_single_command_key_start)
5823 (before_command_key_count, before_command_echo_length, echo_now)
5824 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
5825 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
5826 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
5827 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
5828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5829 (last_non_minibuf_size, last_point_position, echo_truncate)
5830 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
5831 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
5832 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
5833 (stuff_buffered_input):
5834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5835 (last_auto_save, command_loop_1, read_char):
5836 Use EMACS_INT, not int, to avoid integer overflow.
5837 (record_char): Avoid overflow in total_keys computation.
5838 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
5839 * keyboard.h: Adjust decls to match defn changes elsewhere.
5840 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
5841 (Fkey_description, Fdescribe_vector, Flookup_key):
5842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5843 (click_position): New function, to check that positions are in range.
5844 (Fcurrent_active_maps):
5845 (describe_command):
5846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5847 (Faccessible_keymaps, Fkey_description):
5848 (preferred_sequence_p):
5849 Don't assume fixnum can fit into int.
5850 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
5851 Check for integer overflow in size calculations.
5852 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
5853 avoid mishandling large integers.
5854 * lisp.h: Adjust decls to match defn changes elsewhere.
5855 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
5856 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
5857 (struct Lisp_Marker):
5858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5859 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
5860 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
5861 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
5862 All callers changed.
5863 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
5864 Assume the arg has valid form, since it always does.
5865 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
5866 unsigned integer system type.
5867 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
5868 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
5869 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5870 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
5871 (duration_to_sec_usec): New decl.
5872 * lread.c (read_from_string_index, read_from_string_index_byte)
5873 (read_from_string_limit, readchar, unreadchar, openp)
5874 (read_internal_start, read1, oblookup):
5875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5876 (Fload, readevalloop, Feval_buffer, Feval_region):
5877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5878 (openp): Check for out-of-range argument to 'access'.
5879 (read1): Use int, not EMACS_INT, where int is wide enough.
5880 Don't assume fixnum fits into int.
6efdadfd 5881 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
5882 (read_filtered_event): Use duration_to_sec_usec
5883 to do proper overflow checking on durations.
d311d28c
PE
5884 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
5885 in size calculation.
5886 (Fexecute_kbd_macro):
5887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5888 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
5889 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
5890 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
5891 (set_marker_both, set_marker_restricted_both, marker_position)
5892 (marker_byte_position, Fbuffer_has_markers_at):
5893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5894 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 5895 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
5896 It now merely ensures that the menu is large enough, without
5897 necessarily growing it, as this avoids some integer overflow issues.
5898 All callers changed.
5899 (keymap_panes, parse_single_submenu, Fx_popup_menu):
5900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5901 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
5902 Use SAFE_ALLOCA_LISP, not alloca.
5903 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
5904 to EMACS_INT. Check that fixnums are in proper range for system types.
5905 * minibuf.c (minibuf_prompt_width, string_to_object)
5906 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
5907 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
5908 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5909 (get_minibuffer, read_minibuf_unwind):
5910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5911 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
5912 this simplifies overflow checking. All callers changed.
5913 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
5914 (Ftest_completion):
5915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5916 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
5917 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
5918 Check that fixnums are in proper range for system types.
5919 (Fx_create_frame, Fx_show_tip):
5920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5921 * nsfont.m (ns_findfonts, nsfont_list_family):
5922 Don't assume fixnum fits in long.
5923 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
5924 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5925 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
5926 wide enough.
17fdb222 5927 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
5928 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5929 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
5930 (PRINTDECLARE, PRINTPREPARE):
5931 (strout, print_string):
5932 (print, print_preprocess, print_check_string_charset_prop)
5933 (print_object):
5934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5935 (PRINTDECLARE):
5936 (temp_output_buffer_setup, Fprin1_to_string, print_object):
5937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5938 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 5939 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 5940 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
5941 (print_error_message): Use SAFE_ALLOCA, not alloca.
5942 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
5943 (print_depth, new_backquote_output, print_number_index):
5944 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
5945 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
5946 (Fset_process_window_size, Fformat_network_address)
5947 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 5948 (sigchld_handler):
d311d28c 5949 Check that fixnums are in proper range for system types.
d44287d4 5950 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
5951 Check for process-ids out of pid_t range rather than relying on
5952 undefined behavior.
e4d81efc 5953 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
5954 (Fformat_network_address, read_process_output, send_process)
5955 (Fprocess_send_region, status_notify):
5956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5957 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
5958 (wait_reading_process_output, read_process_output, exec_sentinel):
5959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5960 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
5961 (Faccept_process_output): Use duration_to_sec_usec to do proper
5962 overflow checking on durations.
dde14581
PE
5963 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
5964 Don't assume pid_t fits in int.
02481186
PE
5965 * process.h (struct Lisp_Process): Members tick and update_tick
5966 are now of type EMACS_INT, not int.
b62b53e8
PE
5967 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
5968 configured --with-wide-int.
d311d28c
PE
5969 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
5970 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
5971 * search.c (looking_at_1, string_match_1):
5972 (fast_string_match, fast_c_string_match_ignore_case)
5973 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
5974 (scan_newline, find_before_next_newline, search_command)
5975 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
5976 (set_search_regs, wordify):
5977 (Freplace_match):
5978 (Fmatch_data):
5979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5980 (string_match_1, search_buffer, set_search_regs):
5981 (Fmatch_data):
5982 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5983 (wordify): Check for overflow in size calculation.
5984 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
5985 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
5986 Check that fixnums are in proper range for system types.
5987 * sound.c (struct sound_device)
5988 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
5989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5990 (Fplay_sound_internal):
5991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 5992 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
5993 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
5994 (Fparse_partial_sexp):
5995 Don't assume fixnums can fit in int.
5996 (struct lisp_parse_state, find_start_pos, find_start_value)
5997 (find_start_value_byte, find_start_begv)
5998 (update_syntax_table, char_quoted, dec_bytepos)
5999 (find_defun_start, prev_char_comend_first, back_comment):
6000 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
6001 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
6002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6003 (Finternal_describe_syntax_value): Check that match_lisp is a
6004 character, not an integer, since the code stuffs it into int.
6005 (scan_words, scan_sexps_forward):
6006 Check that fixnums are in proper range for system types.
6007 (Fforward_word):
6008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6009 (scan_sexps_forward):
6010 Use CHARACTERP, not INTEGERP, since the value must fit into int.
6011 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
6012 * syntax.h: Adjust decls to match defn changes elsewhere.
6013 (struct gl_state_s):
6014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
6015 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
6016 MOST_POSITIVE_FIXNUM.
d311d28c
PE
6017 * sysdep.c (wait_for_termination_1, wait_for_termination)
6018 (interruptible_wait_for_termination, mkdir):
6019 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
6020 (emacs_read, emacs_write):
6021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
6022 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
6023 and double all fit in int.
d311d28c
PE
6024 * term.c (set_tty_color_mode):
6025 Check that fixnums are in proper range for system types.
6026 * termhooks.h (struct input_event):
6027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6028 * textprop.c (validate_interval_range, interval_of)
6029 (Fadd_text_properties, set_text_properties_1)
6030 (Fremove_text_properties, Fremove_list_of_text_properties)
6031 (Ftext_property_any, Ftext_property_not_all)
6032 (copy_text_properties, text_property_list, extend_property_ranges)
6033 (verify_interval_modification):
6034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6035 (Fnext_single_char_property_change)
6036 (Fprevious_single_char_property_change):
6037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
6038 (copy_text_properties):
6039 Check for integer overflow in index calculation.
d311d28c
PE
6040 * undo.c (last_boundary_position, record_point, record_insert)
6041 (record_delete, record_marker_adjustment, record_change)
6042 (record_property_change):
6043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6044 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
6045 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6046 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6047 (Fx_hide_tip, Fx_file_dialog):
6048 * w32menu.c (set_frame_menubar):
6049 Use ptrdiff_t, not int, for consistency with rest of code.
6050 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
6051 (select_window, Fdelete_other_windows_internal)
6052 (window_scroll_pixel_based, window_scroll_line_based)
6053 (Frecenter, Fset_window_configuration):
6054 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6055 (Fset_window_hscroll, run_window_configuration_change_hook)
6056 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 6057 (Fscroll_other_window, Frecenter):
d311d28c
PE
6058 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6059 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
6060 Don't assume fixnum fits in int.
6061 (Fset_window_scroll_bars):
6062 Check that fixnums are in proper range for system types.
6063 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
6064 (string_pos, c_string_pos, number_of_chars, init_iterator)
6065 (in_ellipses_for_invisible_text_p, init_from_display_pos)
6066 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
6067 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
6068 (face_before_or_after_it_pos, handle_invisible_prop)
6069 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
6070 (display_prop_intangible_p, string_buffer_position_lim)
6071 (string_buffer_position, handle_composition_prop, load_overlay_strings)
6072 (get_overlay_strings_1, get_overlay_strings)
6073 (iterate_out_of_display_property, forward_to_next_line_start)
6074 (back_to_previous_visible_line_start, reseat, reseat_to_string)
6075 (get_next_display_element, set_iterator_to_next)
6076 (get_visually_first_element, compute_stop_pos_backwards)
6077 (handle_stop_backwards, next_element_from_buffer)
6078 (move_it_in_display_line_to, move_it_in_display_line)
6079 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6080 (add_to_log, message_dolog, message_log_check_duplicate)
6081 (message2, message2_nolog, message3, message3_nolog
6082 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
6083 (current_message_1, truncate_echo_area, truncate_message_1)
6084 (set_message, set_message_1, store_mode_line_noprop)
6085 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
6086 (text_outside_line_unchanged_p, check_point_in_composition)
6087 (reconsider_clip_changes)
6088 (redisplay_internal, set_cursor_from_row, try_scrolling)
6089 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
6090 (redisplay_window, find_last_unchanged_at_beg_row)
6091 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
6092 (trailing_whitespace_p, find_row_edges, display_line)
6093 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
6094 (display_mode_element, store_mode_line_string)
6095 (pint2str, pint2hrstr, decode_mode_spec)
6096 (display_count_lines, display_string, draw_glyphs)
6097 (x_produce_glyphs, x_insert_glyphs)
6098 (rows_from_pos_range, mouse_face_from_buffer_pos)
6099 (fast_find_string_pos, mouse_face_from_string_pos)
6100 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6102 (safe_call, init_from_display_pos, handle_fontified_prop)
6103 (handle_single_display_spec, load_overlay_strings)
6104 (with_echo_area_buffer, setup_echo_area_for_printing)
6105 (display_echo_area, echo_area_display)
6106 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
6107 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
6108 (redisplay_window, dump_glyph_row, display_mode_line)
6109 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 6110 (handle_display_spec, display_prop_string_p):
d311d28c
PE
6111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6112 (handle_single_display_spec, build_desired_tool_bar_string)
6113 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
6114 (get_specified_cursor_type):
6115 Check that fixnums are in proper range for system types.
6116 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
6117 (Flookup_image_map):
6118 Don't assume fixnums fit in int.
6119 (compare_overlay_entries):
6120 Avoid mishandling comparisons due to subtraction overflow.
6121 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
6122 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
6123 (handle_tool_bar_click):
6124 Use int, not unsigned, since we prefer signed and the signedness
6125 doesn't matter here.
6126 (get_next_display_element, next_element_from_display_vector):
6127 Use int, not EMACS_INT, when int is wide enough.
6128 (start_hourglass): Use duration_to_sec_usec to do proper
6129 overflow checking on durations.
6130 * xfaces.c (Fbitmap_spec_p):
6131 Check that fixnums are in proper range for system types.
6132 (compare_fonts_by_sort_order):
6133 Avoid mishandling comparisons due to subtraction overflow.
6134 (Fx_family_fonts, realize_basic_faces):
6135 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6136 (Fx_family_fonts):
6137 Don't assume fixnum fits in int.
6138 Use SAFE_ALLOCA_LISP, not alloca.
6139 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
6140 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
6141 (face_at_buffer_position, face_for_overlay_string)
6142 (face_at_string_position):
6143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6144 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
6145 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
6146 (Fx_show_tip):
6147 Check that fixnums are in proper range for system types.
6148 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6149 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
6150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6151 (Fx_change_window_property): Don't assume fixnums fit in int.
6152 * xfont.c (xfont_chars_supported):
6153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6154 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
6155 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
6156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6157 * xml.c (parse_region):
6158 * xrdb.c (magic_file_p):
6159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6160 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
6161 (x_get_local_selection, x_reply_selection_request)
6162 (x_handle_selection_request, wait_for_property_change):
6163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6164 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
6165 short is wide enough.
6166 (x_send_client_event): Don't assume fixnum fits in int.
6167 * xterm.c (x_x_to_emacs_modifiers):
6168 Don't assume EMACS_INT overflows nicely into int.
6169 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
6170 may come from Lisp.
6171 (handle_one_xevent): NATNUMP can eval its arg twice.
6172 (x_connection_closed):
6173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6174 * xterm.h: Adjust decls to match defn changes elsewhere.
6175 (struct scroll_bar): Use struct vectorlike_header
6176 rather than rolling our own approximation.
6177 (SCROLL_BAR_VEC_SIZE): Remove; not used.
6178
c6574eb5
GM
61792012-05-25 Glenn Morris <rgm@gnu.org>
6180
6181 * lisp.mk (lisp): Update for more files being compiled now.
6182
e8d32c7e
SM
61832012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
6184
48def666
SM
6185 * lread.c: Remove `read_pure' which makes no difference.
6186 (read_pure): Remove var.
6187 (unreadpure): Remove function.
6188 (readevalloop): Don't call read_list with -1 flag.
6189 (read1, read_vector): Don't test read_pure any more.
6190 (read_list): Simplify.
6191
e8d32c7e
SM
6192 * fileio.c, character.h: Minor style tweaks.
6193
4b2addb7
DA
61942012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
6195
6196 * window.h (clip_changed): Remove useless declaration.
6197
584461b2
JB
61982012-05-22 Juanma Barranquero <lekktu@gmail.com>
6199
6200 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
6201 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
6202
34374650
PE
62032012-05-22 Paul Eggert <eggert@cs.ucla.edu>
6204
6205 Remove src/m/*.
6206 This directory predates autoconf and is no longer needed nowadays.
6207 Move its few remaining bits of functionality to where they're needed.
6208 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
6209 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
6210 * m/template.h: Remove.
6211 * Makefile.in (M_FILE): Remove. All uses removed.
6212 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
6213 * lisp.h (USE_LSB_TAG):
6214 * mem-limits.h (EXCEEDS_LISP_PTR):
6215 Use VAL_MAX, not VALBITS, in #if.
6216 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
6217 (EMACS_UINT): Define unconditionally now.
6218 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
6219 (BITS_PER_EMACS_INT): New constants, replacing
6220 what used to be in config.h, but not useful in #if.
6221 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
6222 define them any more.
6223 (VAL_MAX): New macro.
6224 (VALMASK): Use it.
6225 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
6226 BITS_PER_EMACS_INT, in #if.
6227 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
6228 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
6229 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
6230 * s/ms-w32.h (DATA_START):
6231 Move here from removed file m/intel386.h.
6232 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
6233 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
6234
261cb4bb
PE
62352012-05-21 Paul Eggert <eggert@cs.ucla.edu>
6236
6237 Assume C89 or later.
6238 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
6239 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
6240 (xrealloc):
6241 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
6242 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
6243 * textprop.c, tparam.c (NULL): Remove.
6244 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
6245 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
6246 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
6247 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
6248 * xterm.c (input_signal_count): Assume volatile works.
6249
ff23cd9f
KB
62502012-05-21 Ken Brown <kbrown@cornell.edu>
6251
6252 * xgselect.c (xg_select): Fix first argument in call to 'select'
6253 (bug#11508).
6254
1b170bc6
KB
62552012-05-20 Ken Brown <kbrown@cornell.edu>
6256
6257 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 6258 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 6259
b2f4d39f
KB
62602012-05-19 Ken Brown <kbrown@cornell.edu>
6261
6262 * xfns.c (x_in_use): Remove `static' qualifier.
6263 * xterm.h (x_in_use): Declare.
6264 * xgselect.c: Include xterm.h.
6265 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
6266 and `display_arg' (bug#9754).
6267
003fdae2
PE
62682012-05-19 Paul Eggert <eggert@cs.ucla.edu>
6269
9232a6d9
PE
6270 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
6271
003fdae2
PE
6272 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
6273 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
6274
784b56e2
EZ
62752012-05-18 Eli Zaretskii <eliz@gnu.org>
6276
6277 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
6278
6279 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 6280 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
6281
6282 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
6283 reference to image_cache->refcount.
6284 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
6285
a0a79cde
JL
62862012-05-17 Juri Linkov <juri@jurta.org>
6287
6288 * search.c (Fword_search_regexp, Fword_search_backward)
6289 (Fword_search_forward, Fword_search_backward_lax)
6290 (Fword_search_forward_lax): Move functions to isearch.el
6291 (bug#10145, bug#11381).
6292
b0572523
PE
62932012-05-16 Paul Eggert <eggert@cs.ucla.edu>
6294
6295 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
6296
9660f5fc
SM
62972012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
6298
6299 * lread.c (init_obarray): Declare Qt and Qnil as special.
6300
4374de83
GM
63012012-05-14 Glenn Morris <rgm@gnu.org>
6302
6303 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 6304 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 6305
dc44c39a
PE
63062012-05-14 Paul Eggert <eggert@cs.ucla.edu>
6307
078c97cb
PE
6308 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
6309
dc44c39a
PE
6310 * unexaix.c: Port to more-recent AIX compilers.
6311 (report_error, report_error_1, make_hdr, copy_sym)
6312 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
6313 Make arguments const char *, not char *, to avoid violations of C
6314 standard and to fix some AIX warnings reported by Gilles Pion.
6315
e18afed7 63162012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
6317
6318 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
6319 already have overlays loaded.
6320 (handle_single_display_spec): Before returning without displaying
6321 fringe bitmap, synchronize the bidi iterator with the main display
6322 iterator, by calling iterate_out_of_display_property.
6323 (iterate_out_of_display_property): Detect buffer iteration by
6324 testing that it->string is a Lisp string.
6325 (get_next_display_element): When the current object is exhausted,
6326 and there's something on it->stack, call set_iterator_to_next to
6327 proceed with what's on the stack, instead of returning zero.
6328 (set_iterator_to_next): If called at the end of a Lisp string,
6329 proceed to consider_string_end without incrementing string
6330 position. Don't increment display vector index past the end of
6331 the display vector. (Bug#11417)
c8fb9dc6
EZ
6332 (pos_visible_p): Don't report a position visible when move_it_to
6333 stopped at the last line of window, which happens to be scanned
6334 backwards by the bidi iteration. (Bug#11464)
ac268e67 6335
e18afed7 63362012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
6337
6338 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
6339 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
6340 are on a TTY, and thus unable to display on the fringes.
6341 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
6342 so we need to signal to the caller that this is a "replacing"
6343 display spec. This fixes display when the spec is invalid or we
6344 are on a TTY.
6345
e18afed7 63462012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
6347
6348 * unexaix.c (make_hdr): Fix typo in prototype.
6349 This bug broke the build on AIX. Problem reported by Gilles Pion.
6350
9d0a235a
MA
63512012-05-14 Michael Albinus <michael.albinus@gmx.de>
6352
6353 * keyboard.c (kbd_buffer_get_event): Read special events also in
6354 batch mode. (Bug#11415)
6355
9e6b06ed
GM
63562012-05-12 Glenn Morris <rgm@gnu.org>
6357
6358 * ns.mk: Update for ns_appbindir no longer having trailing "/".
6359
c1a1d7a3
EZ
63602012-05-12 Eli Zaretskii <eliz@gnu.org>
6361
6362 * lisp.mk (lisp): Add newcomment.elc.
6363
3fe7cdc8
GM
63642012-05-12 Glenn Morris <rgm@gnu.org>
6365
6366 * Makefile.in (MKDIR_P): New, set by configure.
6367 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
6368
53f7d2c0
PE
63692012-05-11 Paul Eggert <eggert@cs.ucla.edu>
6370
6371 Remove unused function hourglass_started.
6372 * dispextern.h (hourglass_started):
6373 * w32fns.c (hourglass_started):
6374 * xdisp.c (hourglass_started): Remove.
6375
75aafb17
JB
63762012-05-10 Juanma Barranquero <lekktu@gmail.com>
6377
6378 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
6379 Update dependencies.
6380
12959e8e
PE
63812012-05-10 Paul Eggert <eggert@cs.ucla.edu>
6382
97107e2e
PE
6383 * xgselect.c (xg_select): Put maxfds+1 into a var.
6384 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
6385
12959e8e
PE
6386 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
6387
836d29b3
DA
63882012-05-10 Dave Abrahams <dave@boostpro.com>
6389
6390 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
6391 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
6392
5cb67954
MA
63932012-05-09 Michael Albinus <michael.albinus@gmx.de>
6394
6395 * dbusbind.c (xd_registered_buses): New internal Lisp object.
6396 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
6397 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
6398 Initialize xd_registered_buses.
6399
3478ec45
PE
64002012-05-09 Paul Eggert <eggert@cs.ucla.edu>
6401
b263a6b0
PE
6402 Untag more efficiently if USE_LSB_TAG.
6403 This is based on a proposal by YAMAMOTO Mitsuharu in
6404 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
6405 For an admittedly artificial (nth 8000 longlist) benchmark on
6406 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
6407 Emacs's overall text size by 1%.
6408 * lisp.h (XUNTAG): New macro.
6409 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
6410 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
6411 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
6412 * eval.c (Fautoload):
6413 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
6414 * frame.h (XFRAME): Use XUNTAG.
6415
3478ec45
PE
6416 Port recent dbusbind.c changes to 32-bit --with-wide-int.
6417 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
6418 Remove unportable assumptions about print widths of types like
6419 dbus_uint32_t.
6420 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
6421 intptr_t when converting between pointer and integer, to avoid GCC
6422 warnings about wrong width.
6423
666b903b 64242012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
6425
6426 * w32proc.c (new_child): Force Windows to reserve only 64KB of
6427 stack for each reader_thread, instead of defaulting to 8MB
6428 determined by the linker. This avoids failures in creating
6429 subprocesses on Windows 7, see the discussion in this thread:
6430 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
6431
b120cc17
JC
64322012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
6433
6434 Fix up display of the *Minibuf-0* buffer in the mini window.
6435 * keyboard.c (read_char): Don't clear the echo area if there's no
6436 message to clear.
6437 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 6438 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 6439
9a4b36f8
MA
64402012-05-07 Michael Albinus <michael.albinus@gmx.de>
6441
6442 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
6443 batch mode.
6444
e5f9458f
CY
64452012-05-06 Chong Yidong <cyd@gnu.org>
6446
6447 * lisp.mk (lisp): Update.
6448
eceeb5fc 64492012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
6450
6451 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
6452
71873e2b
SM
64532012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
6454
6455 * data.c (PUT_ERROR): New macro.
6456 (syms_of_data): Use it. Add new error type `user-error'.
6457 * undo.c (user_error): New function.
6458 (Fprimitive_undo): Use it.
6459 * print.c (print_error_message): Adjust print style for `user-error'.
6460 * keyboard.c (user_error): New function.
6461 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
6462
ab0fa4e4
PE
64632012-05-03 Paul Eggert <eggert@cs.ucla.edu>
6464
6465 Do not limit current-time-string to years 1000..9999.
6466 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
6467 (Fcurrent_time_string): Support any year that is supported by the
6468 underlying localtime representation. Don't use asctime, as it
6469 has undefined behavior for years outside the range -999..9999.
6470
7ed806a7
PE
64712012-05-02 Paul Eggert <eggert@cs.ucla.edu>
6472
6473 Fix race conditions involving setenv, gmtime, localtime, asctime.
6474 Without this fix, interrupts could mess up code that uses these
6475 nonreentrant functions, since setting TZ invalidates existing
6476 tm_zone or tzname values, and since most of these functions return
6477 pointers to static storage.
6478 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
6479 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
6480 Grow the critical sections to include not just invoking
6481 localtime/gmtime, but also accessing these functions' results
6482 including their tm_zone values if any, and any related TZ setting.
6483 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
6484 so that the struct tm is saved in the critical section.
6485 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
6486 motivated by the fact that memory allocation needs to be outside
6487 the critical section.
6488
0c16dfed
DA
64892012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
6490
6491 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
6492 with RESET_INTERVAL.
6493
6494 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6495 Remove duplicated buffer name initialization.
6496
3f83ace8
JM
64972012-05-02 Jim Meyering <jim@meyering.net>
6498
6499 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
6500
c7b8541e
JM
6501 * xfns.c (x_window): Use xstrdup (Bug#11375).
6502
90207a15 65032012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
6504
6505 * xdisp.c (pos_visible_p): If already at a newline from the
6506 display string before the 'while' loop, don't walk back the glyphs
6507 from it3.glyph_row. Solves assertion violation when the display
6508 string begins with a newline (egg.el). (Bug#11367)
6509
b593d6a9
AH
65102012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
6511
6512 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
6513 Move to simple.el.
6514
4737362e
GM
65152012-05-01 Glenn Morris <rgm@gnu.org>
6516
99cf43f9
GM
6517 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
6518 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
6519 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
6520 All were removed before 23.1.
6521
9311dcff
GM
6522 * dispnew.c: Remove HAVE_LIBNCURSES test;
6523 it is always true on relevant platforms.
6524
4d5c6349
GM
6525 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
6526 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
6527
4737362e
GM
6528 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
6529
74dd3a6b
AS
65302012-04-30 Andreas Schwab <schwab@linux-m68k.org>
6531
6532 * .gdbinit (xpr): Remove checks for no longer existing misc types.
6533 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
6534 Remove.
6535
13c379ee
PE
65362012-04-28 Paul Eggert <eggert@cs.ucla.edu>
6537
6538 Do not avoid creating empty evaporating overlays (Bug#9642).
6539 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
6540 That is, do not delete an evaporating overlay if it becomes
6541 empty after its bounds are adjusted to fit within its buffer.
6542 This fix caused other problems, and I'm reverting it until we get
6543 to the bottom of them.
6544
a8e7d6d7 65452012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
6546
6547 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
6548
a8e7d6d7 65492012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
6550
6551 * xdisp.c (pos_visible_p): If the window start position is beyond
6552 ZV, start the display from buffer beginning. Prevents assertion
6553 violation in init_iterator when the minibuffer window is scrolled
6554 via the scroll bar.
6555
6556 * window.c (window_scroll_pixel_based): Likewise.
6557
a8e7d6d7 65582012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
6559
6560 * keymap.c (where_is_internal): Doc fix (Bug#10872).
6561
a8e7d6d7 65622012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
6563
6564 * fileio.c (Fcopy_file, Fset_file_selinux_context):
6565 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
6566
a8e7d6d7 65672012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 6568
b593d6a9
AH
6569 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
6570 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 6571
1c6900d9
EZ
65722012-04-26 Eli Zaretskii <eliz@gnu.org>
6573
4c3fa1d9
EZ
6574 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
6575 display element, check also the underlying string or buffer
6576 character. (Bug#11341)
6577
1c6900d9
EZ
6578 * w32menu.c: Include w32heap.h.
6579 (add_menu_item): If the call to AppendMenuW (via
6580 unicode_append_menu) fails, disable Unicode menus only if we are
6581 running on Windows 9X/Me.
6582
42bf8205
AS
65832012-04-24 Andreas Schwab <schwab@linux-m68k.org>
6584
6585 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
6586 (xgetint): Add missing shift for LSB tags.
6587
b1bac16e
MR
65882012-04-24 Martin Rudalics <rudalics@gmx.at>
6589
6590 * keyboard.c (read_char): Don't wipe echo area for select window
6591 events: These might get delayed via `mouse-autoselect-window'
6592 (Bug#11304).
6593
d69621cc
JB
65942012-04-24 Juanma Barranquero <lekktu@gmail.com>
6595
6596 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
6597 manipulation of :loaded-from data.
6598
02fd101b
JB
65992012-04-23 Juanma Barranquero <lekktu@gmail.com>
6600
6601 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
6602 now a cons (bug#11311).
6603
888bec30
PE
66042012-04-23 Paul Eggert <eggert@cs.ucla.edu>
6605
89a438bd
PE
6606 Do not create empty overlays with the evaporate property (Bug#9642).
6607 * buffer.c (Fmove_overlay): Delete an evaporating overlay
6608 if it becomes empty after its bounds are adjusted to fit within
6609 its buffer. Without this fix, in a nonempty buffer (let ((o
6610 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
6611 yields an empty overlay that has the evaporate property, which is
6612 not supposed to happen.
6613
1068fe4d
PE
6614 Fix minor GTK3 problems found by static checking.
6615 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6616 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6617 (struct _EmacsFixedClass, emacs_fixed_get_type):
6618 Move decls here from emacsgtkfixed.h, since they needn't be public.
6619 (emacs_fixed_get_type): Now static.
6620 (emacs_fixed_class_init): Omit unused local.
6621 (emacs_fixed_child_type): Remove; unused.
6622 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6623 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6624 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
6625 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
6626 (EMACS_FIXED_GET_CLASS): Remove; unused.
6627 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
6628
888bec30
PE
6629 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
6630 Problem reported by Juanma Barranquero for Windows -Wunused-function.
6631
de85e130
PE
66322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6633
d0baac98 6634 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 6635 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
6636 (__malloc_size_t, __malloc_ptrdiff_t):
6637 Remove. All uses removed, replaced by the definiens if needed,
6638 since we can assume C89 or better now.
6639 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
6640 (protect_malloc_state, align, get_contiguous_space)
6641 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
6642 (malloc_atfork_handler_child, malloc_enable_thread)
6643 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
6644 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
6645 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
6646 (special_realloc, _realloc_internal_nolock, _realloc_internal)
6647 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
6648 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
6649 Define using prototypes, not old style.
6650 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
6651 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
6652 (align): Don't assume that signed integer overflow wraps around.
6653 Omit unused local var.
6654 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
6655 (_free_internal_nolock, memalign, mallochook, reallochook):
6656 Omit no-longer-needed casts.
6657 (valloc): Use getpagesize, not __getpagesize.
6658 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
6659 (struct hdr): The 'magic' member is now size_t, not unsigned long.
6660
de85e130
PE
6661 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
6662
dcbf5805
MA
66632012-04-22 Michael Albinus <michael.albinus@gmx.de>
6664
6665 Move functions from C to Lisp. Make non-blocking method calls
6666 the default. Implement further D-Bus standard interfaces.
6667
6668 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
6669 (QCdbus_request_name_allow_replacement)
6670 (QCdbus_request_name_replace_existing)
6671 (QCdbus_request_name_do_not_queue)
6672 (QCdbus_request_name_reply_primary_owner)
6673 (QCdbus_request_name_reply_in_queue)
6674 (QCdbus_request_name_reply_exists)
6675 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
6676 (QCdbus_registered_serial, QCdbus_registered_method)
6677 (QCdbus_registered_signal): New Lisp objects.
6678 (XD_DEBUG_MESSAGE): Use sizeof.
6679 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
6680 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
6681 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
6682 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
6683 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
6684 (xd_signature, xd_append_arg): Allow float for integer types.
6685 (xd_get_connection_references): New function.
b593d6a9
AH
6686 (xd_get_connection_address): Rename from xd_initialize.
6687 Return cached address.
dcbf5805
MA
6688 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
6689 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
6690 level.
6691 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 6692 Return number of refcounts.
dcbf5805
MA
6693 (Fdbus_get_unique_name): Make stronger parameter check.
6694 (Fdbus_message_internal): New defun.
6695 (Fdbus_call_method, Fdbus_call_method_asynchronously)
6696 (Fdbus_method_return_internal, Fdbus_method_error_internal)
6697 (Fdbus_send_signal, Fdbus_register_service)
6698 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
6699 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
6700 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
6701 (Vdbus_compiled_version, Vdbus_runtime_version)
6702 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
6703 (Vdbus_message_type_method_return, Vdbus_message_type_error)
6704 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
6705 (Vdbus_registered_buses, Vdbus_registered_objects_table):
6706 Adapt docstring.
dcbf5805 6707
52828e02
PE
67082012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6709
da05bc4c
PE
6710 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
6711 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
6712 Do not assume ptrdiff_t is the same width as 'int'.
6713
52828e02
PE
6714 * alloc.c: Handle unusual debugging option combinations.
6715 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
6716 since the two debugging options are incompatible.
6717 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
6718 is defined.
6719 (mem_init, mem_insert, mem_insert_fixup):
6720 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
6721 (NEED_MEM_INSERT): Remove; no longer needed.
6722
f01769f9
LL
67232012-04-22 Leo Liu <sdl.web@gmail.com>
6724
6725 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
6726
5790543d
PE
67272012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6728
6729 * sysdep.c [__FreeBSD__]: Minor cleanups.
6730 (list_system_processes, system_process_attributes) [__FreeBSD__]:
6731 Use Emacs indenting style more consistently. Avoid some casts.
6732 Use 'double' consistently rather than mixing 'float' and 'double'.
6733
b91b7e4d
EW
67342012-04-21 Eduard Wiebe <usenet@pusto.de>
6735
b593d6a9
AH
6736 * sysdep.c (list_system_processes, system_process_attributes):
6737 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 6738
6114eb15
AS
67392012-04-21 Andreas Schwab <schwab@linux-m68k.org>
6740
6741 * lisp.mk (lisp): Update.
6742
2f38dff7
PE
67432012-04-20 Paul Eggert <eggert@cs.ucla.edu>
6744
6745 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
6746 It is never used otherwise.
6747
4ae29f89
SM
67482012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
6749
6750 * print.c (print_preprocess): Only check print_depth if print-circle
6751 is nil.
6752 (print_object): Check for cycles even when print-circle is nil and
6753 print-gensym is t, but only check print_depth if print-circle is nil.
6754
f30d612a
CY
67552012-04-20 Chong Yidong <cyd@gnu.org>
6756
6757 * process.c (wait_reading_process_output): If EIO occurs on a pty,
6758 set the status to "failed" and ensure that sentinel is run.
6759
c07a4c0b 67602012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
6761
6762 * process.c (Fset_process_inherit_coding_system_flag)
6763 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 6764 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 6765
c07a4c0b 67662012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
6767
6768 * xdisp.c (string_buffer_position_lim): Limit starting position to
6769 BEGV.
6770 (set_cursor_from_row): If called for a mode-line or header-line
6771 row, return zero immediately.
6772 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
6773 farther than the first row after the header line, if any.
6774 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
6775 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
6776
c07a4c0b 67772012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6778
4ae29f89
SM
6779 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
6780 (bug#11238).
ad3a2b41 6781
c07a4c0b 67822012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 67832012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
6784
6785 configure: new option --enable-gcc-warnings (Bug#11207)
6786 * Makefile.in (C_WARNINGS_SWITCH): Remove.
6787 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
6788 (ALL_CFLAGS): Use new macros rather than old.
6789 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
6790 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
6791 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
6792 -Wunused-result, -Wunused-variable. This should go away once
6793 the Emacs and Gnulib regex code is merged.
6794 (xmalloc, xrealloc): Now static.
6795
aba027e8
PE
67962012-04-17 Paul Eggert <eggert@cs.ucla.edu>
6797
6798 * dired.c (Fsystem_groups): Remove unused local.
6799
e5a36063
GM
68002012-04-17 Glenn Morris <rgm@gnu.org>
6801
6802 * dired.c (Fsystem_users): Doc fix.
6803
316411f0
DA
68042012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
6805
6806 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
6807 (syms_of_dired): Add them.
6808
9426aba4
PE
68092012-04-16 Paul Eggert <eggert@cs.ucla.edu>
6810
b62a57be
PE
6811 Fix minor alloc.c problems found by static checking.
6812 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
6813 New extern decls, to avoid calling undeclared functions.
6814 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
6815 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
6816 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
6817 (NEED_MEM_INSERT): New macro.
6818 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 6819 Remove one incorrect comment and fix another.
b62a57be 6820
3539f31f
PE
6821 Fix minor ralloc.c problems found by static checking.
6822 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6823 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
6824 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
6825 (r_alloc_sbrk): Now static.
6826
a041960a
PE
6827 Improve ralloc.c interface checking.
6828 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6829 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
6830 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
6831 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
6832 [REL_ALLOC]: ... to here, to check interface.
6833 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
6834 Remove decls. This fixes an "It stinks!".
6835
9426aba4
PE
6836 * alloc.c (which_symbols): Fix alignment issue / type clash.
6837
d55c12ed
AS
68382012-04-15 Andreas Schwab <schwab@linux-m68k.org>
6839
6840 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
6841 (struct Lisp_Misc_Any): Likewise.
6842 (struct Lisp_Free): Likewise.
6843 * alloc.c (union aligned_Lisp_Symbol): Define.
6844 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
6845 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
6846 (union aligned_Lisp_Misc): Define.
6847 (MARKER_BLOCK_SIZE, struct marker_block): Use union
6848 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 6849 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 6850
b948ce8b
PE
68512012-04-14 Paul Eggert <eggert@cs.ucla.edu>
6852
6853 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
6854 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
6855 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
6856 * s/netbsd.h, s/sol2-6.h:
6857 Remove definition of GC_MARK_STACK, since the default now works.
6858 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
6859 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
6860 no longer the default.
6861 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
6862
35dc09a1 68632012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6864
35dc09a1
GM
6865 * lread.c (lisp_file_lexically_bound_p):
6866 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 6867
35dc09a1
GM
68682012-04-14 Eli Zaretskii <eliz@gnu.org>
6869
6870 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
6871 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
6872
68732012-04-14 Jan Djärv <jan.h.d@swipnet.se>
6874
6875 * nsterm.m (constrainFrameRect): Always constrain when there is only
6876 one screen (Bug#10962).
6877
bcd86815
KB
68782012-04-13 Ken Brown <kbrown@cornell.edu>
6879
6880 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
6881
c25df26e
RT
68822012-04-13 Reuben Thomas <rrt@sc3d.org>
6883
6884 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
6885
0fc59f1e
DC
68862012-04-11 Daniel Colascione <dancol@dancol.org>
6887
6888 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
6889 against is gone. It's better to use vfork now so that when Cygwin
6890 gains a new, working vfork, we use it automatically (bug#10398).
6891
de8c03dc
SM
68922012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6893
6894 * window.c (save_window_save): Obey window-point-insertion-type.
6895
2f097256
GM
68962012-04-11 Glenn Morris <rgm@gnu.org>
6897
6898 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
6899
453b951e
SM
69002012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6901
6902 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
6903
75f1671a 69042012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
6905
6906 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
6907 (force_quit_count): New var.
6908 (handle_interrupt): Use it.
6909
2a8ce227
JB
69102012-04-10 Juanma Barranquero <lekktu@gmail.com>
6911
6912 * w32.c (w32_delayed_load): Record the full path of the library
6913 being loaded (bug#10424).
6914
935396c0
GM
69152012-04-09 Glenn Morris <rgm@gnu.org>
6916
05920a43
GM
6917 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
6918 not just in the obarray, before snarfing them. (Bug#11036)
6919
935396c0
GM
6920 * Makefile.in ($(leimdir)/leim-list.el):
6921 Pass EMACS rather than BUILT_EMACS.
6922
a18ecafa
TZ
69232012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
6924
6925 * process.c (make_process):
6926 * process.h: Add integer `gnutls_handshakes_tried' member to
6927 process struct.
6928
6bbef4e5
JC
6929 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
6930 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
6931
6932 * gnutls.c (gnutls_log_function2i): Convenience log function.
6933 (emacs_gnutls_read): Use new log functions,
6934 `gnutls_handshakes_tried' process member, and
6935 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
6936 attempts per process (connection).
6937
b4d3bc10
CY
69382012-04-09 Chong Yidong <cyd@gnu.org>
6939
6940 * eval.c (Fuser_variable_p, user_variable_p_eh)
6941 (lisp_indirect_variable): Functions deleted.
6942 (Fdefvar): Caller changed.
6943
6944 * callint.c (Finteractive, Fcall_interactively):
6945 * minibuf.c (Fread_variable): Callers changed.
6946
70f4d973
EZ
69472012-04-09 Eli Zaretskii <eliz@gnu.org>
6948
6949 * xdisp.c (set_cursor_from_row): If the display string appears in
6950 the buffer at position that is closer to point than the position
6951 after the display string, display the cursor on the first glyph of
6952 the display string. Fixes cursor display when a 'display' text
6953 property immediately follows invisible text. (Bug#11094)
6954
cb3c2e3e
PE
69552012-04-09 Paul Eggert <eggert@cs.ucla.edu>
6956
6957 composite.c: use 'double' consistently
6958 * composite.c (get_composition_id): Use 'double' consistently
6959 instead of converting 'float' to 'double' and vice versa; this is
6960 easier to understand and avoids a GCC warning.
6961
fd06db5d
GM
69622012-04-09 Glenn Morris <rgm@gnu.org>
6963
50fe702a
GM
6964 * Makefile.in: Generate leim-list with bootstrap-emacs, in
6965 preparation for dumping it with emacs. (Bug#4789)
6966 (leimdir): New variable.
6967 ($(leimdir)/leim-list.el): New rule.
6968 (emacs$(EXEEXT)): Depend on leim-list.el.
6969
fd06db5d
GM
6970 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
6971 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
6972 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
6973
55c131ee
AS
69742012-04-08 Andreas Schwab <schwab@linux-m68k.org>
6975
6976 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
6977 proper alignment.
6978
9209588f
JB
69792012-04-07 Juanma Barranquero <lekktu@gmail.com>
6980
6981 * xml.c (init_libxml2_functions) [WINDOWSNT]:
6982 Remove unused local variable.
6983
e3fb2efb
PE
69842012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6985
6986 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
6987 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
6988 (mark_memory): Mark Lisp_Objects only if pointers might hide in
6989 objects, as mark_maybe_pointer will catch them otherwise.
6990 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
6991 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
6992
b5385551
PE
69932012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6994
6995 Fix typo that broke non-Windows builds.
6996 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
6997
9078ead6
EZ
69982012-04-07 Eli Zaretskii <eliz@gnu.org>
6999
7000 Support building on MS-Windows with libxml2.
7001
7002 * makefile.w32-in (OBJ2): Add xml.$(O).
7003 (GLOBAL_SOURCES): Add xml.c.
7004 ($(BLD)/xml.$(O)): New dependency list.
7005
7006 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
7007 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
7008 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
7009 [!WINDOWSNT]: New macros.
7010 (init_libxml2_functions, libxml2_loaded_p): New functions.
7011 (parse_region): Call fn_xmlCheckVersion instead of using the macro
7012 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
7013 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
7014 Calls xmlCleanupParser only if libxml2 was loaded (or statically
7015 linked in).
6bbef4e5
JC
7016 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
7017 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
7018 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
7019
7020 * emacs.c: Don't include libxml/parser.h.
7021 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
7022 xmlCleanupParser directly.
7023
7024 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
7025
3811fdf3
EZ
70262012-04-07 Eli Zaretskii <eliz@gnu.org>
7027
7028 * indent.c (Fvertical_motion): If there is a display string at
7029 point, use it.vpos to compute how many lines to backtrack after
7030 move_it_to point. (Bug#11133)
7031
2f8e16b2
EZ
70322012-04-06 Eli Zaretskii <eliz@gnu.org>
7033
7034 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
7035 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
7036 about subtle differences between FETCH_CHAR* and STRING_CHAR*
7037 macros related to unification of CJK characters. For the details,
7038 see the discussion following the message here:
7039 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
7040
3d439cd1
CY
70412012-04-04 Chong Yidong <cyd@gnu.org>
7042
7043 * keyboard.c (Vdelayed_warnings_list): Doc fix.
7044
8bc53d00
EZ
70452012-04-01 Eli Zaretskii <eliz@gnu.org>
7046
7047 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
7048 instead of alloca. (Bug#11138)
7049
3b0512a3
AS
70502012-04-01 Andreas Schwab <schwab@linux-m68k.org>
7051
7052 * w32menu.c (is_simple_dialog): Properly check lisp types.
7053 (Bug#11141)
7054
8427ddd2
EZ
70552012-03-31 Eli Zaretskii <eliz@gnu.org>
7056
979022ef
EZ
7057 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
7058 position we get to after a call to move_it_to fails the
7059 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
7060 only if we wind up in a string from display property. (Bug#11063)
7061
a6b1c7cc
EZ
7062 * window.c (Fdelete_other_windows_internal): Invalidate the row
7063 and column information about mouse highlight, so that redisplay
7064 restores it after reallocating the glyph matrices. (Bug#7464)
7065
8427ddd2
EZ
7066 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
7067 string comes from a `display' text property, use the buffer
7068 position of that property as if we actually saw that position in
7069 the row's glyphs.
697ba24b
EZ
7070 (move_it_by_lines): Remove the assertion that
7071 "it->current_x == 0 && it->hpos == 0" which can be legitimately
7072 violated when there's a before-string at the beginning of a line.
7073 (Bug#11063)
8427ddd2 7074
65a0a738
EZ
70752012-03-30 Eli Zaretskii <eliz@gnu.org>
7076
7077 * xdisp.c (append_space_for_newline): If the default face was
7078 remapped, use the remapped face for the appended newline.
7079 (extend_face_to_end_of_line): Use the remapped default face for
7080 extending the face to the end of the line.
7081 (display_line): Call extend_face_to_end_of_line when the default
7082 face was remapped. (Bug#11068)
7083
581355cc
EZ
70842012-03-29 Eli Zaretskii <eliz@gnu.org>
7085
7086 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
7087
e8fc049f
SM
70882012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7089
7090 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
7091
4fb9a543
GM
70922012-03-27 Glenn Morris <rgm@gnu.org>
7093
7094 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
7095 Doc fixes.
7096
679910f1
KH
70972012-03-26 Kenichi Handa <handa@m17n.org>
7098
7099 * dispextern.h (struct glyph): Fix previous change. Change the
7100 bit length of glyphless.ch to 25 (Bug#11082).
7101
90d49b7f
CY
71022012-03-26 Chong Yidong <cyd@gnu.org>
7103
7104 * keyboard.c (Vselection_inhibit_update_commands): New variable.
7105 (command_loop_1): Use it; inhibit selection update for
7106 handle-select-window too (Bug#8996).
7107
f514f6f0
FP
71082012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
7109
e8fc049f 7110 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 7111
bf43fa51
KH
71122012-03-25 Kenichi Handa <handa@m17n.org>
7113
7114 * dispextern.h (struct glyph): Change the bit length of
7115 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
7116
8a0c01dd
EZ
71172012-03-24 Eli Zaretskii <eliz@gnu.org>
7118
7119 * s/ms-w32.h (tzname): Include time.h before redirecting to
7120 _tzname. Fixes the MSVC build. (Bug#9960)
7121
7d1c3a76
AS
71222012-03-24 Andreas Schwab <schwab@linux-m68k.org>
7123
8ed79523
AS
7124 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
7125 characters.
7126
7d1c3a76
AS
7127 * xterm.c (XTread_socket): Only modify handling_signal if
7128 !SYNC_INPUT. (Bug#11080)
7129
e99a9b8b
EZ
71302012-03-23 Eli Zaretskii <eliz@gnu.org>
7131
7132 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
7133 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
7134 when fetching a multibyte character consumes more bytes than
7135 CHAR_BYTES returns, due to unification of CJK characters in
7136 string_char. (Bug#11073)
7137
5063c0e1
TN
71382012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
7139
7140 * process.c (wait_reading_process_output): Handle pty disconnect
7141 by refraining from sending oneself a SIGCHLD (bug#10933).
7142
9f851fbd
CY
71432012-03-22 Chong Yidong <cyd@gnu.org>
7144
7145 * dispextern.h (struct it): New member string_from_prefix_prop_p.
7146
5063c0e1 7147 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
7148 Mark string as coming from a prefix property.
7149 (handle_face_prop): Use default face for prefix strings (Bug#4281).
7150 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
7151
fb5b8aca
CY
71522012-03-21 Chong Yidong <cyd@gnu.org>
7153
7154 * xfaces.c (Vface_remapping_alist): Doc fix.
7155
62356a1b
EZ
71562012-03-20 Eli Zaretskii <eliz@gnu.org>
7157
7158 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
7159 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
7160 Doc fixes.
62356a1b 7161
025de85b
CY
71622012-03-20 Chong Yidong <cyd@gnu.org>
7163
7164 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
7165 to reflect default non-nil value of redisplay-dont-pause.
7166
4827f94e
KH
71672012-03-19 Kenichi Handa <handa@m17n.org>
7168
7169 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
7170 it fit in a valid range (Bug#11003).
7171
e50a24a2
EZ
71722012-03-18 Eli Zaretskii <eliz@gnu.org>
7173
7174 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
7175 that is not from display property, accept the row as a "cursor
7176 row" if one of the string's character has a non-nil `cursor'
7177 property. Fixes cursor positioning when there are newlines in
7178 overlay strings, e.g. in icomplete.el. (Bug#11035)
7179
9af5ed87
PE
71802012-03-12 Paul Eggert <eggert@cs.ucla.edu>
7181
7182 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
7183
d1f55f16
CY
71842012-03-12 Chong Yidong <cyd@gnu.org>
7185
7186 * eval.c (inhibit_lisp_code): Rename from
7187 inhibit_window_configuration_change_hook; move from window.c.
7188
7189 * xfns.c (unwind_create_frame_1, Fx_create_frame):
7190 * window.c (run_window_configuration_change_hook)
7191 (syms_of_window): Callers changed.
7192
66c5eebd
CY
71932012-03-11 Chong Yidong <cyd@gnu.org>
7194
413df973
CY
7195 * keymap.c (Fkey_description): Doc fix (Bug#9700).
7196
66c5eebd
CY
7197 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
7198
1de11f56
CY
71992012-03-10 Chong Yidong <cyd@gnu.org>
7200
7201 * frame.c (other_visible_frames): Don't assume the selected frame
7202 is visible (Bug#10955).
7203
cae07000
SM
72042012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
7205
7206 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
7207
89c94350
JD
72082012-03-08 Jan Djärv <jan.h.d@swipnet.se>
7209
7210 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
7211 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
7212 zero (Bug#10954).
7213
999dd333
GM
72142012-03-03 Glenn Morris <rgm@gnu.org>
7215
01a6dcc8 7216 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 7217
de0100f2
EZ
72182012-03-02 Eli Zaretskii <eliz@gnu.org>
7219
7220 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
7221 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
7222 (redisplay_window, next_element_from_string): Fix typos in
7223 comments.
3e441275
EZ
7224 (redisplay_window): Pass to move_it_vertically the margin in
7225 pixels, not in screen lines.
de0100f2 7226
96a72ee9
GM
72272012-03-02 Glenn Morris <rgm@gnu.org>
7228
7229 * buffer.c (buffer-list-update-hook): Doc fix.
7230
312508d7
EZ
72312012-02-29 Eli Zaretskii <eliz@gnu.org>
7232
7233 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
7234 push_it before setting up the iterator for the first overlay
7235 string, even if we have an empty string loaded.
7236 (next_overlay_string): If there's an empty string on the iterator
7237 stack, pop the stack. (Bug#10903)
7238
27f3c637
PE
72392012-02-25 Paul Eggert <eggert@cs.ucla.edu>
7240
7241 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
7242 Suggested by Stefan Monnier in
7243 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
7244 * alloc.c (widen_to_Lisp_Object): New static function.
7245 (mark_memory): Also mark Lisp_Objects by fetching pointer words
7246 and widening them to Lisp_Objects. This would work even if
7247 USE_LSB_TAG is defined and wide integers are used, which might
7248 happen in a future version of Emacs.
7249
3c9dfce6
CY
72502012-02-25 Chong Yidong <cyd@gnu.org>
7251
fa74b241
CY
7252 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
7253 Doc fix.
7254
3c9dfce6
CY
7255 * xselect.c (Fx_selection_exists_p): Doc fix.
7256 (x_clipboard_manager_save_all): Print an informative message
7257 before saving to clipboard manager.
7258
9486df08
CY
72592012-02-24 Chong Yidong <cyd@gnu.org>
7260
7261 * keyboard.c (process_special_events): Handle all X selection
7262 requests in kbd_buffer, not just the next one (Bug#8869).
7263
f01d3321
CY
72642012-02-23 Chong Yidong <cyd@gnu.org>
7265
7266 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
7267 call when setting menu-bar-lines and tool-bar-lines parameters.
7268 (unwind_create_frame_1): New helper function.
7269
7270 * window.c (inhibit_window_configuration_change_hook): New var.
7271 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 7272 (syms_of_window): Initialize it.
f01d3321 7273
86b847b6
CY
72742012-02-22 Chong Yidong <cyd@gnu.org>
7275
7276 * xterm.c (x_draw_image_relief): Add missing type check for
7277 Vtool_bar_button_margin (Bug#10743).
7278
a59225b1
CY
72792012-02-21 Chong Yidong <cyd@gnu.org>
7280
7281 * fileio.c (Vfile_name_handler_alist): Doc fix.
7282
7283 * buffer.c (Fget_file_buffer): Protect against invalid file
7284 handler return value.
7285
310f5bd4
PE
72862012-02-20 Paul Eggert <eggert@cs.ucla.edu>
7287
cb3a28cc
PE
7288 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
7289 when computing $valmask.
7290
310f5bd4
PE
7291 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
7292 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
7293 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
7294 It's useless in that case, and it can cause problems on hosts
7295 that allocate halves of EMACS_INT values separately.
7296 Reported by Dan Horák. Diagnosed by Andreas Schwab in
7297 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
7298 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
7299 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
7300 it avoids undefined behavior on hosts where shifting right by more
7301 than the word width has undefined behavior.
7302
2375c96a
CY
73032012-02-19 Chong Yidong <cyd@gnu.org>
7304
7305 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
7306 (Funhandled_file_name_directory, Ffile_name_as_directory)
7307 (Fdirectory_file_name, Fexpand_file_name)
7308 (Fsubstitute_in_file_name): Protect against invalid file handler
7309 return values (Bug#10845).
7310
3eb49e71
EZ
73112012-02-18 Eli Zaretskii <eliz@gnu.org>
7312
7313 * .gdbinit (pitx): Fix incorrect references to fields of the
7314 iterator stack.
7315
7b926f3f
CY
73162012-02-17 Chong Yidong <cyd@gnu.org>
7317
7318 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
7319
11273115
PE
73202012-02-15 Paul Eggert <eggert@cs.ucla.edu>
7321
7322 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
7323 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
7324
c3a70e2b
CY
73252012-02-15 Chong Yidong <cyd@gnu.org>
7326
7327 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
7328 marked as special. Also, starting docstrings with * is obsolete.
7329
0ca43699
AS
73302012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7331
7332 * gnutls.c (emacs_gnutls_write): Fix last change.
7333
2e8f3c56
LI
73342012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
7335
7336 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
7337 send_process.
7338
af70074f
SM
73392012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
7340
7341 * keymap.c (Fsingle_key_description): Handle char ranges.
7342
95986d52
CY
73432012-02-12 Chong Yidong <cyd@gnu.org>
7344
afd83bd1
CY
7345 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
7346 as that creates a dangerous corner case.
7347
95986d52
CY
7348 * window.c (Fdelete_window_internal): Invalidate the mouse
7349 highlight (Bug#9904).
7350
bd7da63e
GM
73512012-02-12 Glenn Morris <rgm@gnu.org>
7352
7353 * xselect.c (Fx_own_selection_internal)
7354 (Fx_get_selection_internal, Fx_disown_selection_internal)
7355 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
7356 * nsselect.m (Fx_own_selection_internal)
7357 (Fx_disown_selection_internal, Fx_selection_exists_p)
7358 (Fx_selection_owner_p, Fx_get_selection_internal):
7359 Sync docs and argument specs with the xselect.c versions.
7360
77abcbc2
LI
73612012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
7362
7363 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
7364
90b671e2
EZ
73652012-02-11 Eli Zaretskii <eliz@gnu.org>
7366
1c0ca0b7
EZ
7367 * w32select.c (Fx_selection_exists_p): Sync doc string and
7368 argument list with xselect.c. (Bug#10783)
7369
7370 * w16select.c (Fx_selection_exists_p): Sync doc string and
7371 argument list with xselect.c. (Bug#10783)
90b671e2 7372
49241268
GM
73732012-02-10 Glenn Morris <rgm@gnu.org>
7374
7375 * fns.c (Fsecure_hash): Doc fix.
7376
f998bbe7 73772012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
7378
7379 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
7380
0992bd9c
CY
73812012-02-07 Chong Yidong <cyd@gnu.org>
7382
7383 * buffer.c (Fbuffer_local_variables)
7384 (buffer_lisp_local_variables): Handle unbound vars correctly;
7385 don't let Qunbound leak into Lisp.
7386
af008560
GM
73872012-02-07 Glenn Morris <rgm@gnu.org>
7388
dd605cc4
GM
7389 * image.c (Fimagemagick_types): Doc fix.
7390
af008560
GM
7391 * image.c (imagemagick-render-type): Change it from a lisp object
7392 to an integer. Move the doc here from the lisp manual.
7393 Treat all values not equal to 0 the same.
7394
1449fa1d
CY
73952012-02-06 Chong Yidong <cyd@gnu.org>
7396
7397 * doc.c (store_function_docstring): Avoid applying docstring of
7398 alias to base function (Bug#2603).
7399
3723ec07
AS
74002012-02-04 Andreas Schwab <schwab@linux-m68k.org>
7401
7402 * .gdbinit (pp1, pv1): Remove redundant defines.
7403 (pr): Use pp.
7404
79c1cc1e
CY
74052012-02-04 Chong Yidong <cyd@gnu.org>
7406
7407 * nsterm.m: Declare a global (Bug#10694).
7408
d7f29f8e
EZ
74092012-02-04 Eli Zaretskii <eliz@gnu.org>
7410
cae07000
SM
7411 * w32.c (get_emacs_configuration_options):
7412 Include --enable-checking, if specified, in the return value.
d7f29f8e 7413
3b95a6f9
MR
74142012-02-04 Martin Rudalics <rudalics@gmx.at>
7415
7416 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
7417 after rounding frame sizes. (Bug#9723)
7418
d6fa96a6
EZ
74192012-02-04 Eli Zaretskii <eliz@gnu.org>
7420
7421 * keyboard.c (adjust_point_for_property): Don't position point
7422 before BEGV. (Bug#10696)
7423
df0b2940
PE
74242012-02-03 Paul Eggert <eggert@cs.ucla.edu>
7425
7426 Handle overflow when computing char display width (Bug#9496).
7427 * character.c (char_width): Return EMACS_INT, not int.
7428 (char_width, c_string_width): Check for overflow when
7429 computing the width; this is possible now that individual
7430 characters can have unbounded width. Problem introduced
7431 by merge from Emacs 23 on 2012-01-19.
7432
6bee44d6
MA
74332012-02-02 Michael Albinus <michael.albinus@gmx.de>
7434
7435 * dbusbind.c (Fdbus_register_method): Mention the return value
7436 :ignore in the docstring.
7437
44f92739
GM
74382012-02-02 Glenn Morris <rgm@gnu.org>
7439
1b9f60cc
GM
7440 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
7441
44f92739
GM
7442 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7443 Unconditionally set to t. (Bug#10673)
7444 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7445 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
7446 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
7447
c5d3843c
KH
74482012-02-02 Kenichi Handa <handa@m17n.org>
7449
7450 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
7451 0, do not call append_composite_glyph.
7452
159462d4 74532012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
7454
7455 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
7456 NULL (Bug#6988).
7457 (x_produce_glyphs): If the component of a composition is a null
7458 string, set it->pixel_width to 1 to avoid zero-width glyph.
7459
78cef877
EZ
74602012-02-01 Eli Zaretskii <eliz@gnu.org>
7461
7462 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
7463 first 2 arguments are identical. This makes inserting large
7464 output from a subprocess an order of magnitude faster on
7465 MS-Windows, where all sbrk'ed memory is always contiguous.
7466
97897668
GM
74672012-01-31 Glenn Morris <rgm@gnu.org>
7468
7469 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 7470 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
7471 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
7472
31fd3586
GM
74732012-01-29 Glenn Morris <rgm@gnu.org>
7474
7475 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
7476
0e24a8b2
CY
74772012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
7478
7479 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
7480
cc0adcb0
CY
74812012-01-28 Chong Yidong <cyd@gnu.org>
7482
7483 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
7484
acc28cb9
CY
74852012-01-26 Chong Yidong <cyd@gnu.org>
7486
9c69cfb7
CY
7487 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
7488
acc28cb9
CY
7489 * search.c (Fsearch_forward, Fsearch_backward): Document negative
7490 repeat counts (Bug#10507).
7491
48da7392
GM
74922012-01-26 Glenn Morris <rgm@gnu.org>
7493
7494 * lread.c (syms_of_lread): Doc fix.
7495
14af5f7f
CY
74962012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
7497
7498 * coding.c (encode_designation_at_bol): Change return value to
7499 EMACS_INT.
7500
0b21c100
CY
75012012-01-25 Chong Yidong <cyd@gnu.org>
7502
7503 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
7504
3c2907f7
CY
75052012-01-21 Chong Yidong <cyd@gnu.org>
7506
7507 * floatfns.c (Fcopysign): Make the second argument non-optional,
7508 since nil is not allowed anyway.
7509
959ad23f
AS
75102012-01-21 Andreas Schwab <schwab@linux-m68k.org>
7511
7512 * process.c (read_process_output): Use p instead of XPROCESS (proc).
7513 (send_process): Likewise.
7514
34a02f46
MR
75152012-01-19 Martin Rudalics <rudalics@gmx.at>
7516
7517 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
7518 (Vwindow_persistent_parameters): Do not use Qstate.
7519 Rewrite doc-strings.
34a02f46 7520
1259009a 75212012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
7522
7523 * character.c (char_width): New function.
70d4fdf6
GM
7524 (Fchar_width, c_string_width, lisp_string_width):
7525 Use char_width (Bug#9496).
25ed9e61 7526
6a6ee00d
MR
75272012-01-16 Martin Rudalics <rudalics@gmx.at>
7528
7529 * window.c (Vwindow_persistent_parameters): New variable.
7530 (Fset_window_configuration, save_window_save): Handle persistent
7531 window parameters.
7532
c85efaf7
EZ
75332012-01-14 Eli Zaretskii <eliz@gnu.org>
7534
7535 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
7536 thrashing the stack of the thread. (Bug#9087)
7537
5944709e
PE
75382012-01-12 Paul Eggert <eggert@cs.ucla.edu>
7539
7540 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
7541
e71f5d99
EZ
75422012-01-11 Eli Zaretskii <eliz@gnu.org>
7543
7544 * xdisp.c (rows_from_pos_range): Handle the case where the
7545 highlight ends on a newline. (Bug#10464)
7546 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
7547 he end column for display of highlight that ends on a newline
7548 before a R2L line.
7549
ce316182
GM
75502012-01-11 Glenn Morris <rgm@gnu.org>
7551
7552 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
7553 from load-path also when installation-directory is nil. (Bug#10208)
7554
5b43da69
GM
75552012-01-10 Glenn Morris <rgm@gnu.org>
7556
74cc8ff9
GM
7557 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
7558
7d8d6e4e
GM
7559 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
7560 Update template values to be closer to their typical values these days.
5b43da69 7561
a0db8d43
EZ
75622012-01-09 Eli Zaretskii <eliz@gnu.org>
7563
7564 * xdisp.c (rows_from_pos_range): Accept additional argument
7565 DISP_STRING, and accept any glyph in a row whose object is that
7566 string as eligible for mouse highlight. Fixes mouse highlight of
7567 display strings from overlays. (Bug#10464)
7568
9a0115ab 75692012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 7570
b9110d6a 7571 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
7572 * fileio.c (auto_saving_dir_umask): New static var.
7573 (Fmake_directory_internal): Use it.
7574 (do_auto_save_make_dir): Set it, instead of invoking chmod after
7575 creating the directory. The old code temporarily assigns
7576 too-generous permissions to the directory.
7577 (do_auto_save_eh): Clear it.
b9110d6a 7578 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
7579 that the var is always cleared.
7580
6c1bd3f3
EZ
75812012-01-07 Eli Zaretskii <eliz@gnu.org>
7582
7583 * search.c (scan_buffer): Pass character positions to
7584 know_region_cache, not byte positions. (Bug#6540)
7585
069d2b50
L
75862012-01-07 LynX <_LynX@bk.ru> (tiny change)
7587
7588 * w32.c (sys_rename): Report EXDEV when rename of a directory
7589 fails because the target is on another logical disk. (Bug#10284)
7590
75bf0d33
DB
75912012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
7592
7593 * xterm.c (x_embed_request_focus): New function.
7594
7595 * xterm.h: Add prototype.
7596
7597 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
7598
1c6e5a32
GM
75992012-01-05 Glenn Morris <rgm@gnu.org>
7600
7601 * emacs.c (emacs_copyright): Update short copyright year to 2012.
7602
651e947e
EZ
76032012-01-01 Eli Zaretskii <eliz@gnu.org>
7604
7605 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
7606 Load gnutls_transport_set_lowat only if GnuTLS version is below
7607 2.11.1.
7608 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
7609 GnuTLS versions below 2.11.1.
7610
3778cdd8
AL
76112011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
7612
7613 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
7614 to the doc string advising against its use for altering the way
7615 windows are scrolled.
7616
0e5317f7
KH
76172011-12-28 Kenichi Handa <handa@m17n.org>
7618
7619 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
7620 coding-system ASCII compatible only when it does not produce BOM
7621 on encoding (Bug#10383).
7622
93d5ca1f
JD
76232011-12-26 Jan Djärv <jan.h.d@swipnet.se>
7624
7625 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
7626 can scroll.
7627 (create_and_show_popup_menu): Always use menu_position_func for
7628 Gtk3 (Bug#10361).
7629
ca22b785
AS
76302011-12-24 Andreas Schwab <schwab@linux-m68k.org>
7631
7632 * callint.c (Fcall_interactively): Don't truncate prompt string.
7633
d048e1e6
EZ
76342011-12-23 Eli Zaretskii <eliz@gnu.org>
7635
7636 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
7637 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 7638 resumed from there (after widening). (Bug#10360)
d048e1e6 7639
5ccaba1f
JD
76402011-12-22 Jan Djärv <jan.h.d@swipnet.se>
7641
7642 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
7643
204ee57f
JD
76442011-12-21 Jan Djärv <jan.h.d@swipnet.se>
7645
b81d40f0
JB
7646 * nsterm.m (x_free_frame_resources):
7647 Release f->output_data.ns->miniimage.
204ee57f
JD
7648 (ns_index_color): Fix indentation. Do not retain
7649 color_table->colors[i].
7650
7651 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
7652 before returning.
7653
7654 * nsfns.m (x_set_background_color): Assign return value from
7655 ns_index_color to face-background instead of NSColor*.
7656 (ns_implicitly_set_icon_type): Fix indentation.
7657 Change assignment in for loop to comparison.
7658
7659 * emacs.c (ns_pool): New variable.
7660 (main): Assign ns_pool.
7661 (Fkill_emacs): Call ns_release_autorelease_pool.
7662
7663 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
7664 autorelease fdesc, release fdAttrs and tdict.
7665 (ns_get_covering_families): Release charset.
7666 (ns_findfonts): Release NSFontDescriptor created with new.
7667 (ns_uni_to_glyphs): Fix indentation.
7668 (setString): Release attrStr before assigning new value.
7669
c803b2b7
JD
76702011-12-18 Jan Djärv <jan.h.d@swipnet.se>
7671
678f4426
JD
7672 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
7673 and NS_IMPL_COCOA.
7674 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
7675 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
7676
cd394be1 76772011-12-18 David Reitter <reitter@cmu.edu>
678f4426 7678
5fecd5fc
JD
7679 * nsterm.m (ns_term_init): Subscribe for notifications
7680 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
7681 to method trackingNotification in EmacsMenu.
7682
7683 * nsmenu.m (trackingMenu): New variable.
3771cb17 7684 (trackingNotification): New method (from Aquamacs).
5fecd5fc 7685 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 7686 from Aquamacs (Bug#7030).
678f4426
JD
7687
76882011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 7689
c803b2b7
JD
7690 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
7691 (symbol_to_nsstring): Fix indentation.
7692 (ns_symbol_to_pb): New function.
cae07000
SM
7693 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
7694 (Fns_rotate_cut_buffers_internal): Remove.
7695 (Fns_store_selection_internal): Rename from
c803b2b7
JD
7696 Fns_store_cut_buffer_internal.
7697 (ns_get_foreign_selection, Fx_own_selection_internal)
7698 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
7699 (Fns_get_selection_internal, Fns_store_selection_internal):
7700 Use ns_symbol_to_pb and check if return value is nil.
7701 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
7702 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
7703 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
7704 renamed to Sns_store_selection_internal.
7705 (ns_handle_selection_request): Move code to Fx_own_selection_internal
7706 and remove this function.
7707 (ns_handle_selection_clear): Remove, never used.
7708 (Fx_own_selection_internal): Move code from ns_handle_selection_request
7709 here.
7710
e1b01a3a
KB
77112011-12-17 Ken Brown <kbrown@cornell.edu>
7712
7713 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
7714 GID is unknown (Bug#10257).
7715
2adb6e85
PE
77162011-12-17 Paul Eggert <eggert@cs.ucla.edu>
7717
7718 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
7719 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
7720 which caused a build failure on GNU/Linux IA-64. This problem was
7721 introduced by my 2011-10-07 patch.
7722
d1d7b339
JL
77232011-12-15 Juri Linkov <juri@jurta.org>
7724
7725 * image.c (imagemagick_error): New function. (Bug#10112)
7726 (imagemagick_load_image): Comment out `MagickSetResolution' call.
7727 Use `imagemagick_error' where ImageMagick functions return
7728 `MagickFalse'.
7729 (Fimagemagick_types): Add `Fnreverse' to return the list in the
7730 proper order.
7731
100d5755
KH
77322011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7733
7734 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
7735 fill background (Bug#8992).
7736
454592a6
MR
77372011-12-13 Martin Rudalics <rudalics@gmx.at>
7738
7739 * window.c (Vwindow_combination_resize)
7740 (Vwindow_combination_limit): Use t instead of non-nil in
7741 doc-strings.
61d4b438
MR
7742 (Vrecenter_redisplay): Add first sentence of doc-string on
7743 separate line.
53524d93 7744 (Frecenter): Fix doc-string typo.
454592a6 7745
3633e3aa
KH
77462011-12-11 Kenichi Handa <handa@m17n.org>
7747
7748 * coding.c (Funencodable_char_position): Pay attention to the
7749 buffer text relocation (Bug#9389).
7750
7b9d523a 77512011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 7752
7b9d523a
JD
7753 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
7754 gtk_init (Bug#10100).
7755
b73189c6
EZ
77562011-12-10 Eli Zaretskii <eliz@gnu.org>
7757
7758 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
7759 IT->string is nil. (Bug#10263)
7760
f7dfe5d6
JD
77612011-12-10 Jan Djärv <jan.h.d@swipnet.se>
7762
83faebb4
JD
7763 * nsterm.h (x_free_frame_resources): Declare.
7764
f7dfe5d6
JD
7765 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
7766 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
7767
7768 * nsterm.h (ns_get_defaults_value): Declare.
7769
7770 * nsterm.m (ns_default): Call ns_get_defaults_value.
7771
7cd4e72c
EZ
77722011-12-09 Eli Zaretskii <eliz@gnu.org>
7773
7774 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
7775 (Bug#10170)
7776
b34d7317
YM
77772011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7778
7779 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
7780 that where the value of an _OBJC_* symbol points to is in the .bss
7781 section (Bug#10240).
7782
76470ad1
KH
77832011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7784
7785 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 7786 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 7787
745fff94
KH
77882011-12-08 Kenichi Handa <handa@m17n.org>
7789
7790 * ftfont.c (get_adstyle_property): Fix previous change
7791 (Bug#10233).
7792
6e44397c
JB
77932011-12-07 Juanma Barranquero <lekktu@gmail.com>
7794
7795 * w32.c (init_environment): If no_site_lisp, remove site-lisp
7796 dirs from the default value of EMACSLOADPATH (bug#10208).
7797
7efa6272
GM
77982011-12-07 Glenn Morris <rgm@gnu.org>
7799
7800 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
7801 installation and source directories as well. (Bug#10208)
7802
f6fc4d87
CY
78032011-12-06 Chong Yidong <cyd@gnu.org>
7804
7805 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
7806
2bf26180
GM
78072011-12-06 Glenn Morris <rgm@gnu.org>
7808
7809 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
7810 as an error, not just -1. (Bug#10217)
7811
3a6ad4f0
CY
78122011-12-05 Chong Yidong <cyd@gnu.org>
7813
7814 * keyboard.c (process_special_events): New function.
7815 (swallow_events, Finput_pending_p): Use it (Bug#10195).
7816
75a3b399
PE
78172011-12-05 Paul Eggert <eggert@cs.ucla.edu>
7818
7819 * coding.c (encode_designation_at_bol): Don't use uninitialized
7820 local variable (Bug#9318).
7821
c3c9e25e
KH
78222011-12-05 Kenichi Handa <handa@m17n.org>
7823
7824 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
7825 return Qnil (Bug#8046, Bug#10193).
7826
5eb05ea3
KH
78272011-12-05 Kenichi Handa <handa@m17n.org>
7828
7829 * coding.c (encode_designation_at_bol): New args charbuf_end and
7830 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
7831 (coding_set_source): Return how many bytes coding->source was
7832 relocated.
7833 (coding_set_destination): Return how many bytes
7834 coding->destination was relocated.
7835 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 7836 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
7837
78382011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7839
7840 * coding.c (CODING_CHAR_CHARSET_P): New macro.
7841 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
7842 macro (Bug#9318).
7843
78442011-12-05 Andreas Schwab <schwab@linux-m68k.org>
7845
7846 The following changes are to fix Bug#9318.
7847
a79703f5 7848 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
7849 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
7850 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 7851 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 7852
7dbda6df
JB
78532011-12-05 Juanma Barranquero <lekktu@gmail.com>
7854
7855 * lisp.h (process_quit_flag): Fix external declaration.
7856
6d5eb5b0
SM
78572011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
7858
7859 Don't macro-inline non-performance-critical code.
7860 * eval.c (process_quit_flag): New function.
7861 * lisp.h (QUIT): Use it.
7862
a0c3fad0
JD
78632011-12-04 Jan Djärv <jan.h.d@swipnet.se>
7864
7865 * nsfns.m (get_geometry_from_preferences): New function.
7866 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
7867
6c07aac2
AS
78682011-12-04 Andreas Schwab <schwab@linux-m68k.org>
7869
7870 * emacs.c (Qkill_emacs): Define.
7871 (syms_of_emacs): Initialize it.
7872 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
7873 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
7874 (quit_throw_to_read_char): Add parameter `from_signal'.
7875 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
7876 * lisp.h (QUIT): Call Fkill_emacs if requested.
7877
c052ead4
JD
78782011-12-03 Jan Djärv <jan.h.d@swipnet.se>
7879
7880 * widget.c (update_wm_hints): Return if wmshell is null.
7881 (widget_update_wm_size_hints): New function.
7882
7883 * widget.h (widget_update_wm_size_hints): Declare.
7884
7885 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
7886 widget_update_wm_size_hints (Bug#10104).
7887
9e49252b
EZ
78882011-12-03 Eli Zaretskii <eliz@gnu.org>
7889
7890 * xdisp.c (handle_invisible_prop): If the invisible text ends just
7891 before a newline, prepare the bidi iterator for consuming the
7892 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 7893 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 7894
02b16839
JL
78952011-12-02 Juri Linkov <juri@jurta.org>
7896
7897 * search.c (Fword_search_regexp): New Lisp function created from
7898 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
7899 (Fword_search_backward, Fword_search_forward)
7900 (Fword_search_backward_lax, Fword_search_forward_lax):
7901 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
7902 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
7903
0068070e
SM
79042011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
7905
7906 * fileio.c (Finsert_file_contents): Move after-change-function call
7907 to before the "handled:" label, since all "goto handled" appear in
7908 cases where the *-change-functions have already been properly called
7909 (bug#10117).
7910
3360a3fc
AS
79112011-12-01 Andreas Schwab <schwab@linux-m68k.org>
7912
7913 * keyboard.c (interrupt_signal): Don't call kill-emacs when
7914 waiting for input. (Bug#10169)
7915
73d6c093
EZ
79162011-11-30 Eli Zaretskii <eliz@gnu.org>
7917
7918 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
7919 verifies glyph row's hash code--we have just reallocated the
7920 glyphs, so their contents can be complete garbage. (Bug#10164)
7921
febe6bea
JB
79222011-11-30 Juanma Barranquero <lekktu@gmail.com>
7923
7924 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
7925
801a4313
EZ
79262011-11-30 Eli Zaretskii <eliz@gnu.org>
7927
7928 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
7929 attributes are tested _before_ calling verify_row_hash, to protect
7930 against GCC re-ordering of the tests. (Bug#10164)
7931
2b56b87e
JD
79322011-11-29 Jan Djärv <jan.h.d@swipnet.se>
7933
7934 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
7935
7936 * xterm.c (handle_one_xevent): Only set async_visible and friends
7937 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 7938 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
7939 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
7940
dbf31225
PE
79412011-11-28 Paul Eggert <eggert@cs.ucla.edu>
7942
7943 Remove GCPRO-related macros that exist only to avoid shadowing locals.
7944 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
7945 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
7946 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7947 All uses changed to use GCPRO1 etc.
7948 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
7949 Revert to old implementation (i.e., before 2011-03-11).
7950
1305621b
YM
79512011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7952
7953 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
7954 of scroll runs so as to avoid assigning disabled bogus rows and
7955 unnecessary graphics copy operations.
7956
8c9afb46
EZ
79572011-11-27 Eli Zaretskii <eliz@gnu.org>
7958
7959 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
7960 (snprintf) [_MSC_VER]: Redirect to _snprintf.
7961 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
7962 (malloc, free, realloc, calloc): Redirect to e_* only when
7963 compiling Emacs.
7964
7965 * lisp.h (GCTYPEBITS): Move before first use.
7966 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
7967 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
7968 this macro definition.
7969
7970 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
7971 _MSC_VER.
7972
54e9e3bf
JD
79732011-11-27 Jan Djärv <jan.h.d@swipnet.se>
7974
6d5eb5b0
SM
7975 * gtkutil.c (xg_create_frame_widgets):
7976 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
7977 present with Gtk+ 2.0.
7978
83aca1cb
PE
79792011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7980
7981 * fileio.c (Finsert_file_contents): Undo previous change; see
7982 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7983
5b76caa4
PE
79842011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7985
7986 Rename locals to avoid shadowing.
7987 * fileio.c (Finsert_file_contents):
7988 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
7989 * process.c (wait_reading_process_output):
7990 Rename inner 'proc' to 'p' to avoid shadowing.
7991 Indent for consistency with usual Emacs style.
7992
8c535114
EZ
79932011-11-25 Eli Zaretskii <eliz@gnu.org>
7994
7995 * xdisp.c (redisplay_window): If cursor row is not fully visible
7996 after recentering, and scroll-conservatively is set to a large
7997 number, scroll window by a few more lines to make the cursor fully
7998 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
7999 (start_display): Don't move to the next line if the display should
8000 start at a newline that is part of a display vector or an overlay
8001 string. (Bug#10119)
8c535114 8002
fa4fdb5c
JL
80032011-11-24 Juri Linkov <juri@jurta.org>
8004
8005 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
8006 after the `MagickPingImage' call. (Bug#10112)
8007
90ec88df
CY
80082011-11-23 Chong Yidong <cyd@gnu.org>
8009
8010 * window.c (Fcoordinates_in_window_p): Accept only live windows.
8011
56e2e794
MR
80122011-11-23 Martin Rudalics <rudalics@gmx.at>
8013
8014 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
8015 making another buffer current. (Bug#10114)
8016
b6e64c41
GM
80172011-11-23 Glenn Morris <rgm@gnu.org>
8018
8019 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
8020
6b21de18
CY
80212011-11-23 Chong Yidong <cyd@gnu.org>
8022
8023 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
8024 using it (Bug#5984).
8025
b12cd789
EZ
80262011-11-22 Eli Zaretskii <eliz@gnu.org>
8027
8028 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
8029 and header-lines, as they don't have one computed for them.
8030 (Bug#10098)
8031
8032 * .gdbinit (prow): Make displayed values more self-explaining.
8033 Add row's hash code.
8034
261b6fd4
LMI
80352011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
8036
8037 * process.c (wait_reading_process_output): Fix asynchrounous
8038 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 8039 (wait_reading_process_output): Add comment and URL.
261b6fd4 8040
e7cfd277
JD
80412011-11-21 Jan Djärv <jan.h.d@swipnet.se>
8042
8043 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
8044
a9b9b7f5
CY
80452011-11-21 Chong Yidong <cyd@gnu.org>
8046
8047 * window.c (Fnext_window, Fprevious_window): Doc fix.
8048
b0d15b4f
SM
80492011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8050
8051 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
8052
fe7a3057
JB
80532011-11-20 Juanma Barranquero <lekktu@gmail.com>
8054
8055 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
8056
d2999b1a
MR
80572011-11-20 Martin Rudalics <rudalics@gmx.at>
8058
8059 * window.c (Fset_window_combination_limit): Rename argument
8060 STATUS to LIMIT.
8061 (Vwindow_combination_limit): Remove "status" from doc-string.
8062
d5ff9cd0
AS
80632011-11-20 Andreas Schwab <schwab@linux-m68k.org>
8064
8065 * m/ibms390.h: Remove.
8066 * m/ibms390x.h: Don't include "ibms390.h".
8067
a5bb9bd3
SM
80682011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8069
8070 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
8071 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
8072
cd1181db
JB
80732011-11-20 Juanma Barranquero <lekktu@gmail.com>
8074
8075 * casetab.c (Fset_case_table):
8076 * charset.c (Fcharset_after): Fix typos.
8077
615a3b8d 80782011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 8079
17e845af
PE
8080 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
8081 Otherwise, valgrind does not work on some platforms.
8082 Problem reported by Andreas Schwab in
6a0bf43d
PE
8083 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
8084 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
8085 is set, removing the need for VIRT_ADDRESS_VARIES.
8086 (PURE_P): Use a more-efficient implementation that needs just one
8087 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
8088 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
8089 to 4 (xorl, subq, cmpq, setbe).
8090 * alloc.c (pure): Always extern now, since that's the
8091 VIRT_ADDR_VARIES behavior.
8092 (PURE_POINTER_P): Use a single comparison, not two, for
8093 consistency with the new puresize.h.
8094 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
8095 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
8096 Remove VIRT_ADDR_VARIES no longer needed.
8097
f8fe6f96
EZ
80982011-11-19 Eli Zaretskii <eliz@gnu.org>
8099
8100 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
8101 (erase_phys_cursor, update_window_cursor, show_mouse_face)
8102 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
8103 behave as if the cursor position were at the window margin.
8104
8105 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
8106 and the cursor position is out of bounds, behave as if the cursor
8107 position were at the window margin. (Bug#10075)
8108
df05a53c
CY
81092011-11-18 Chong Yidong <cyd@gnu.org>
8110
8111 * window.c (Fwindow_combination_limit): Make first argument
8112 non-optional, since it is meaningless for live windows like the
8113 selected window.
61ccba97 8114
2071918e
DA
81152011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
8116
8117 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
8118
b50a28de
SM
81192011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
8120
8121 * intervals.c: Fix grafting over the whole buffer (bug#10071).
8122 (graft_intervals_into_buffer): Simplify.
8123
015137db
EZ
81242011-11-18 Eli Zaretskii <eliz@gnu.org>
8125
8126 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
8127 hash values of the two rows.
8128 (copy_row_except_pointers): Preserve the used[] arrays and the
8129 hash values of the two rows. (Bug#10035)
68c95424 8130 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
8131
8132 * xdisp.c (row_hash): New function, body extracted from
8133 compute_line_metrics.
8134 (compute_line_metrics): Call row_hash, instead of computing the
8135 hash code inline.
8136
8137 * dispnew.c (verify_row_hash): Call row_hash for computing the
8138 hash code of a row, instead of duplicating code from xdisp.c.
8139
8140 * dispextern.h (row_hash): Add prototype.
8141
a2addb04
TH
81422011-11-18 Tassilo Horn <tassilo@member.fsf.org>
8143
8144 * frame.c (delete_frame): Don't delete the terminal when the last
8145 X frame is closed if emacs is built with GTK toolkit.
8146
df85d315
JB
81472011-11-17 Juanma Barranquero <lekktu@gmail.com>
8148
8149 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
8150
a0c2d0ae
MR
81512011-11-17 Martin Rudalics <rudalics@gmx.at>
8152
8153 * window.c (Vwindow_splits): Rename to
8154 Vwindow_combination_resize. Suggested by Juri Linkov.
8155 (Fsplit_window_internal): Use Vwindow_combination_resize instead
8156 of Vwindow_splits.
8157
58179cce
JB
81582011-11-16 Juanma Barranquero <lekktu@gmail.com>
8159
7877f373
JB
8160 * nsfns.m (Fns_font_name):
8161 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 8162
b6f67890
MR
81632011-11-16 Martin Rudalics <rudalics@gmx.at>
8164
8165 * window.h (window): Rename slot "nest" to "combination_limit".
8166 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
8167 (Fset_window_nest): Rename to Fset_window_combination_limit.
8168 (Vwindow_nest): Rename to Vwindow_combination_limit.
8169 (recombine_windows, make_parent_window, make_window)
8170 (Fsplit_window_internal, saved_window)
8171 (Fset_window_configuration, save_window_save): Rename all
8172 occurrences of window_nest to window_combination_limit.
8173
c7015153
JB
81742011-11-15 Juanma Barranquero <lekktu@gmail.com>
8175
8176 * image.c (imagemagick_load_image): Fix typo.
8177
322ad6ec
EZ
81782011-11-14 Eli Zaretskii <eliz@gnu.org>
8179
8180 * xdisp.c (display_line): Move the call to
8181 highlight_trailing_whitespace before the call to
8182 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
8183 faces of all the glyphs to compute ROW's hash value.
8184 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 8185
f067b8ec
JB
81862011-11-14 Juanma Barranquero <lekktu@gmail.com>
8187
8188 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
8189 just return (bug#10044).
8190
1e5b2111
EZ
81912011-11-12 Eli Zaretskii <eliz@gnu.org>
8192
7ef3cbd5
EZ
8193 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
8194 with user-defined heap size. Bump the default size of the temacs
8195 heap to 27MB, to avoid memory warning when running temacs.
8196 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
8197
1e5b2111
EZ
8198 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
8199 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
8200 (verify_row_hash) [XASSERTS]: New function.
8201 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
8202 that the hash value of glyph rows is correct.
1e5b2111 8203
89d61221
MR
82042011-11-12 Martin Rudalics <rudalics@gmx.at>
8205
8206 * window.h (window): Remove splits slot.
8207 * window.c (Fwindow_splits, Fset_window_splits): Remove.
8208 (Fdelete_other_windows_internal, make_parent_window)
8209 (make_window, Fsplit_window_internal, Fdelete_window_internal)
8210 (Fset_window_configuration, save_window_save): Don't deal with
8211 split status of windows.
8212 (saved_window): Remove splits slot.
8213 (Vwindow_splits): Rewrite doc-string.
8214
97f18cc8
JD
82152011-11-11 Jan Djärv <jan.h.d@swipnet.se>
8216
8217 * xfns.c (unwind_create_frame):
8218 * nsfns.m (unwind_create_frame):
8219 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
8220 Vframe_list (Bug#9999).
8221
22a648b4
DA
82222011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
8223
0b381c7e 8224 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 8225
659afede
KH
82262011-11-11 Kenichi Handa <handa@m17n.org>
8227
8228 * callproc.c (Fcall_process): Set the member dst_multibyte of
8229 process_coding.
8230
9ac0394b
KH
82312011-11-11 Johan Bockgård <bojohan@gnu.org>
8232
8233 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
8234 avoid a crash (bug#9496).
8235
2fbdc249
CY
82362011-11-09 Chong Yidong <cyd@gnu.org>
8237
8238 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
8239 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
8240
ac6b1f81
PE
82412011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8242
8243 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
8244
09db192c
PE
82452011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8246
8247 Avoid some portability problems by eschewing 'extern inline' functions.
8248 The trivial performance wins aren't worth the portability hassles; see
8249 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
8250 et seq.
8251 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8252 (window_box_width, window_box_left, window_box_left_offset)
8253 (window_box_right, window_box_right_offset): Undo previous change,
8254 by removing the "extern"s.
8255 * intervals.c (adjust_intervals_for_insertion)
8256 (adjust_intervals_for_deletion): Undo previous change,
8257 making these static again.
8258 (offset_intervals, temp_set_point_both, temp_set_point)
8259 (copy_intervals_to_string): No longer inline.
8260 * xdisp.c (window_text_bottom_y, window_box_width)
8261 (window_box_height, window_box_left_offset)
8262 (window_box_right_offset, window_box_left, window_box_right)
8263 (window_box): No longer inline.
8264
105216ed
CY
82652011-11-08 Chong Yidong <cyd@gnu.org>
8266
8267 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
8268 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
8269 Signal an error if not a live window.
105216ed
CY
8270 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
8271 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
8272
ae9e237f
JB
82732011-11-07 Juanma Barranquero <lekktu@gmail.com>
8274
8275 * lisp.h (syms_of_abbrev): Remove declaration.
8276 Reported by CHENG Gao <chenggao@royau.me>.
8277
c7aa8333
EZ
82782011-11-07 Eli Zaretskii <eliz@gnu.org>
8279
8280 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
8281 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
8282 of temacs in GUI mode.
8283
be7f5545
MR
82842011-11-07 Martin Rudalics <rudalics@gmx.at>
8285
8286 * window.h: Declare delete_all_child_windows instead of
8287 delete_all_subwindows.
8288 * window.c (Fwindow_nest, Fset_window_nest)
8289 (Fset_window_new_total, Fset_window_new_normal)
8290 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
8291 (delete_all_subwindows): Rename to delete_all_child_windows.
8292 (Fdelete_other_windows_internal, Fset_window_configuration):
8293 Call delete_all_child_windows instead of delete_all_subwindows.
8294 * frame.c (delete_frame): Call delete_all_child_windows instead
8295 of delete_all_subwindows.
8296
ca78dc43
PE
82972011-11-07 Paul Eggert <eggert@cs.ucla.edu>
8298
8299 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
8300 This is also needed for porting to any host where GC_MARK_STACK is
8301 not GC_MAKE_GCPROS_NOOPS.
8302 (which_symbols): Use it.
8303
a0241d01
KH
83042011-11-07 Kenichi Handa <handa@m17n.org>
8305
8306 * coding.c (coding_set_destination): Check coding->src_pos only
8307 when coding->src_object is a buffer (bug#9910).
8308
8309 * process.c (send_process): Set the member src_multibyte of coding
8310 to 0 (bug#9911) when sending a unibyte text.
8311
8312 * callproc.c (Fcall_process): Set the member src_multibyte of
8313 process_coding to 0 (bug#9912).
8314
a64bfdfa 83152011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
8316
8317 * xmenu.c (cleanup_widget_value_tree): New function.
8318 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
8319 calling free_menubar_widget_value_tree directly (Bug#9830).
8320
cb41b32a
PE
83212011-11-06 Paul Eggert <eggert@cs.ucla.edu>
8322
8323 Fix some portability problems with 'inline'.
8324 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8325 (window_box_width, window_box_left, window_box_left_offset)
8326 (window_box_right, window_box_right_offset): Declare extern.
8327 Otherwise, these inline functions do not conform to C99 and
8328 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
8329 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
8330 * intervals.c (adjust_intervals_for_insertion)
8331 (adjust_intervals_for_deletion): Now extern, because otherwise the
8332 extern inline functions 'offset_intervals' couldn't refer to it.
8333 (static_offset_intervals): Remove.
8334 (offset_intervals): Rewrite using the old contents of
8335 static_offset_intervals. The old version didn't conform to C99
8336 because an extern inline function contained a reference to an
8337 identifier with static linkage.
8338
b7041366
AS
83392011-11-06 Andreas Schwab <schwab@linux-m68k.org>
8340
8341 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
8342 GC.
8343
88a37c4d
EZ
83442011-11-06 Eli Zaretskii <eliz@gnu.org>
8345
8346 * xdisp.c (init_iterator, reseat_to_string): Don't set the
8347 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
8348 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8349 return Qleft_to_right.
8350
49745b39
CY
83512011-11-06 Chong Yidong <cyd@gnu.org>
8352
8353 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
8354 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
8355 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
8356 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
8357 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
8358 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
8359 (Fwindow_vscroll): Doc fix.
8360 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
8361 argument, since it makes no sense to pass a live window and for
8362 consistency with window-child.
8363
1f05cd82
CS
83642011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
8365
8366 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
8367 support MSVC.
8368
22610910
JR
83692011-11-05 Jason Rumney <jasonr@gnu.org>
8370
8371 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
8372 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
8373 fonts (Bug#6029).
8374 (add_font_entity_to_list): Fix logic errors in mixed boolean and
8375 bitwise arithmetic preventing use of unicode-sip and non-truetype
8376 opentype fonts.
8377
a06776b2
EZ
83782011-11-05 Eli Zaretskii <eliz@gnu.org>
8379
3ad924ba
EZ
8380 * s/ms-w32.h (fstat, stat, utime): Move redirections to
8381 "emacs"-only part.
8382
a06776b2
EZ
8383 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
8384 initialization code to keep similarity to xfns.c after changes
8385 from 2011-11-05.
8386
c9e7db78
JD
83872011-11-05 Jan Djärv <jan.h.d@swipnet.se>
8388
a97f8f3f
JD
8389 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
8390 (unwind_create_frame): New function (Bug#9943).
8391 (Fx_create_frame): Restructure code to be more similar to the one in
8392 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
8393 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
8394 Move terminal->reference_count++ just before making the frame official
8395 (Bug#9943).
8396
8397 * nsterm.m (x_free_frame_resources): New function.
8398 (x_destroy_window): Move code to x_free_frame_resources.
8399
c9e7db78 8400 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
8401 (Fx_create_frame, x_create_tip_frame):
8402 Move terminal->reference_count++ just before making the frame
75f1671a 8403 official. Move initialization of image_cache_refcount and
c9e7db78
JD
8404 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
8405
a6fc3b5c
EZ
84062011-11-05 Eli Zaretskii <eliz@gnu.org>
8407
8408 Support MSVC build with newer versions of Visual Studio.
8409 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
8410 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
8411 nt/gmake.defs.
8412
8413 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
8414 which are not supported by MSVC.
8415 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
8416 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
8417 bitfields.
8418 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
8419 types in bitfields.
8420 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
8421
8422 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
8423
58179cce 84242011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
8425
8426 Support MSVC build with newer versions of Visual Studio.
8427 * w32.c: Don't include w32api.h for MSVC.
8428 (init_environment) [_MSC_VER]: Call sys_access, not _access.
8429
8430 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
8431 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
8432 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
8433 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
8434 e_* cousins.
8435 (alloca) [_MSC_VER]: Define to _alloca.
8436
8437 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
8438
8439 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
8440
a58c13ed
EZ
84412011-11-04 Eli Zaretskii <eliz@gnu.org>
8442
8443 * xdisp.c (note_mouse_highlight): If either of
8444 previous/next-single-property-change returns nil, treat that as
8445 the beginning or the end of the buffer. (Bug#9955)
8446
fe0b6370
JD
84472011-11-04 Jan Djärv <jan.h.d@swipnet.se>
8448
a58c13ed 8449 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
8450 label is not null (Bug#9951).
8451 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
8452 may be NULL.
8453
89bd5ee1
EZ
84542011-11-04 Eli Zaretskii <eliz@gnu.org>
8455
8456 * window.c (Fwindow_body_size): Mention in the doc string that the
8457 return value is in frame's canonical units. (Bug#9949)
8458
84c3edb9
EZ
84592011-11-03 Eli Zaretskii <eliz@gnu.org>
8460
4e2fb5c7
EZ
8461 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
8462
84c3edb9 8463 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 8464 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 8465 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 8466
bc17a887
EZ
84672011-11-01 Eli Zaretskii <eliz@gnu.org>
8468
8469 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
8470 Don't stop backward scan on the continuation glyph, even though
8471 its CHARPOS is positive.
6d5eb5b0
SM
8472 (mouse_face_from_buffer_pos, note_mouse_highlight):
8473 Rename cover_string to disp_string.
bc17a887 8474
4ee88440
MR
84752011-11-01 Martin Rudalics <rudalics@gmx.at>
8476
8477 * window.c (temp_output_buffer_show): Don't use
8478 Vtemp_buffer_show_specifiers.
8479 (Vtemp_buffer_show_specifiers): Remove unused variable.
8480
c2ff3c02
EZ
84812011-10-30 Eli Zaretskii <eliz@gnu.org>
8482
8483 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
8484 past the beginning of the current glyph matrix.
8485
58179cce 84862011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
8487
8488 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
8489 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
8490 HAVE_GTK3 (Bug#9869).
b77a6a7f 8491
3b574623
JD
8492 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
8493 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
8494
b77a6a7f
JD
8495 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
8496
8497 * xterm.c: Declare x_handle_net_wm_state to return int.
8498 (handle_one_xevent): Check if we are iconified but don't have
8499 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
8500 (get_current_wm_state): Return non-zero if not hidden,
8501 check for _NET_WM_STATE_HIDDEN (Bug#9893).
8502 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
8503 (x_handle_net_wm_state): Return what get_current_wm_state returns.
8504 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
8505
196e41e4
PE
85062011-10-29 Paul Eggert <eggert@cs.ucla.edu>
8507
8508 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
8509 so that this new function doesn't get optimized away by a
8510 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
8511
021f2e1a
AS
85122011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8513
8514 * frame.h (MOUSE_HL_INFO): Remove excess parens.
8515
8b058d44
EZ
85162011-10-29 Eli Zaretskii <eliz@gnu.org>
8517
8518 Fix the `xbytecode' command.
8519 * .gdbinit (xprintbytestr): New command.
b50a28de 8520 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
8521 (xbytecode): Print the byte-code string as well.
8522
4452fb80
EZ
85232011-10-29 Kim Storm <storm@cua.dk>
8524
8b058d44
EZ
8525 * alloc.c (which_symbols): New function.
8526
21b72067
AS
85272011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8528
8529 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
8530 line. (Bug#9903)
8531
83ed7b5c
GM
85322011-10-29 Glenn Morris <rgm@gnu.org>
8533
8534 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
8535 Not clear what it was for, and it causes various bugs. (Bug#9839)
8536
5a7a728b
EZ
85372011-10-28 Eli Zaretskii <eliz@gnu.org>
8538
8539 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
8540 possible random value that matches one of those tested as
8541 condition to clear the mouse face.
8542
d3d0842f
CY
85432011-10-28 Chong Yidong <cyd@gnu.org>
8544
8545 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
8546
31b39d13
DN
85472011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
8548
8549 * window.c (make_window): Initialize phys_cursor_on_p.
8550
9aba6043
SM
85512011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
8552
8553 * lisp.h (struct Lisp_Symbol): Update comments.
8554
c20992f4
JB
85552011-10-28 Juanma Barranquero <lekktu@gmail.com>
8556
8557 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
8558
db4f02f2
EZ
85592011-10-28 Eli Zaretskii <eliz@gnu.org>
8560
8561 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
8562 <oslsachem@gmail.com> for helping to debug this.
8563
8564 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
8565 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
8566 (g_b_init_get_glyph_outline_w): New static variables.
8567 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
8568 (GetGlyphOutlineW_Proc): New typedefs.
8569 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
8570 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
8571 New functions.
8572 (w32font_open_internal, compute_metrics):
8573 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
8574 instead of calling the "wide" APIs directly.
8575
8576 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
8577
8578 * w32.h (syms_of_w32font): Add prototype.
8579
87e68db4
JB
85802011-10-27 Juanma Barranquero <lekktu@gmail.com>
8581
8582 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
8583 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
8584 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
8585 (Fmove_to_window_line): Doc fix.
8586
435c1d67
CY
85872011-10-27 Chong Yidong <cyd@gnu.org>
8588
8589 * process.c (make_process): Set gnutls_state to NULL.
8590
8591 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
8592 non-NULL, regardless of GNUTLS_INITSTAGE.
8593 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
8594 an error. Set process slots as soon as we allocate them.
8595
8596 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
8597
9c6c6f49
CY
85982011-10-27 Chong Yidong <cyd@gnu.org>
8599
9aba6043
SM
8600 * gnutls.c (emacs_gnutls_deinit): New function.
8601 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
8602 (Fgnutls_deinit, Fgnutls_boot): Use it.
8603
8604 * process.c (make_process): Initialize GnuTLS credentials to NULL.
8605 (deactivate_process): Call emacs_gnutls_deinit.
8606
657d08d3
JB
86072011-10-27 Juanma Barranquero <lekktu@gmail.com>
8608
8609 * image.c (x_create_x_image_and_pixmap):
8610 * w32.c (sys_rename, w32_delayed_load):
8611 * w32font.c (fill_in_logfont):
8612 * w32reg.c (x_get_string_resource): Silence compiler warnings.
8613
5430d399
JB
86142011-10-26 Juanma Barranquero <lekktu@gmail.com>
8615
8616 * w32fns.c (w32_default_color_map): New function,
8617 extracted from Fw32_default_color_map.
a7ef684b 8618 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 8619
fe0055fa
PE
86202011-10-25 Paul Eggert <eggert@cs.ucla.edu>
8621
8622 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
8623
e6346438
SM
86242011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
8625
8626 * keyboard.c (test_undefined): New function (bug#9751).
8627 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
8628
e112cc37
ET
86292011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
8630
8631 * sysdep.c (init_sys_modes): Fix the check for the controlling
8632 terminal (Bug#6649).
8633
7b5d6677
EZ
86342011-10-20 Eli Zaretskii <eliz@gnu.org>
8635
8636 * dispextern.h (struct bidi_it): New member next_en_type.
8637
8638 * bidi.c (bidi_line_init): Initialize the next_en_type member.
8639 (bidi_resolve_explicit_1): When next_en_pos is valid for the
8640 current character, check also for next_en_type being WEAK_EN.
8641 (bidi_resolve_weak): Don't enter the expensive loop if the current
8642 position is before next_en_pos. Record the bidi type of the first
8643 non-ET, non-BN character we find, in addition to its position.
8644 (bidi_level_of_next_char): Invalidate next_en_type when
8645 next_en_pos is over-stepped.
8646
7da0b018
PE
86472011-10-20 Paul Eggert <eggert@cs.ucla.edu>
8648
8649 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
8650 * editfns.c: Rewrite current-time-zone so that it invokes
8651 the equivalent of (format-time-string "%Z") to get the time zone name.
8652 This fixes a bug when the time zone name contains characters that
8653 need converting from the system time locale to Emacs internal format.
8654 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
8655 that patch fixed format-time-string to do the conversion, but
8656 I forgot to fix current-time-zone.
8657 (format_time_string): New function, containing most of
8658 what Fformat_time_string used to contain.
8659 (Fformat_time_string): Rewrite in terms of format_time_string.
8660 This doesn't change this function's behavior.
8661 (current-time-zone): Rewrite to use format_time_string.
8662 This fixes the bug reported by Michael Schierl in
8663 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
8664 Jason Rumney's 2007-06-07 change worked around this bug, but
8665 didn't fix it.
8666 * systime.h (tzname, timezone): Remove no-longer-used declarations.
8667
8547b010
EZ
86682011-10-19 Eli Zaretskii <eliz@gnu.org>
8669
8670 * xdisp.c (start_display): If the character at POS is displayed
8671 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
8672 (try_window_reusing_current_matrix): If a line ends in a display
8673 vector or the next line starts in a display vector, continue
8674 redrawing the window even though the character position of
8675 start_row was reached.
8547b010
EZ
8676 (Bug#9771, part 2)
8677
4e948d15
CY
86782011-10-18 Chong Yidong <cyd@gnu.org>
8679
8680 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
8681 with nobreak-char-display too.
8682
4787455f
EZ
86832011-10-18 Eli Zaretskii <eliz@gnu.org>
8684
8685 Fix part 3 of bug#9771.
8686 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
8687 (bidi_resolve_neutral): Don't enter the expensive loop looking for
8688 non-neutral characters if the current character is a paragraph
8689 separator (a.k.a. Newline). This avoids running the same
8690 expensive loop twice, once when we consume the preceding newline
8691 and the other time when the line actually needs to be displayed.
8692 Avoid the loop when we see neutrals on the base embedding level
8693 following a character whose directionality is the same as the
8694 paragraph's. This avoids running the expensive loop when a line
8695 ends in a long sequence of neutrals, like control characters.
8696 Add assertion against STRONG_AL type. Slightly rearrange code
8697 that determines the type of a neutral given the first non-neutral
8698 that follows it.
8699 (bidi_level_of_next_char): Set next_en_pos to zero when
8700 invalidating its info.
8701
2c91f553
EZ
87022011-10-17 Eli Zaretskii <eliz@gnu.org>
8703
8704 * xdisp.c (push_display_prop): Determine whether to record string
8705 or buffer position by IT->string, not by IT->method. Allow
8706 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
8707 (move_it_vertically_backward): Don't look for character position
8708 immediately after the newline when in a continuation line.
8709 (Bug#9771, part 1)
2c91f553 8710
c7b08b0d
MR
87112011-10-15 Martin Rudalics <rudalics@gmx.at>
8712
8713 * window.c (coordinates_in_window): Rewrite and delabelize
8714 vertical border check. (Bug#5357) (Bug#9618)
8715
6b02f655
SM
87162011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
8717
8718 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
8719 errors in XSetWindowBorder (bug#9310).
8720
81d40c92
DA
87212011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
8722
8723 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
8724 avoid crash when xmalloc overrun checking is enabled.
8725
d4172c3b
EZ
87262011-10-13 Eli Zaretskii <eliz@gnu.org>
8727
8728 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
8729 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
8730 cursor motion with <left> and <right> arrow keys.
8731
8732 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
8733 some callers set that themselves.
8734
b00eea75
EZ
87352011-10-12 Eli Zaretskii <eliz@gnu.org>
8736
8737 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
8738 display string and the previous row comes from the same string and
8739 is empty. (Bug#9739) (Bug#9738)
8740
8fe012c4
SM
87412011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
8742
8743 * doc.c (get_doc_string): Encode file name (bug#9735).
8744
0074aef2
EZ
87452011-10-12 Eli Zaretskii <eliz@gnu.org>
8746
79beb178
EZ
8747 * bidi.c (bidi_level_of_next_char):
8748 * xdisp.c (get_visually_first_element): Remove old incorrect
8749 comments regarding the Unicode Line Separator character.
8750
0074aef2
EZ
8751 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
8752
6e4b3fbe
DA
87532011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
8754
8755 * alloc.c (Fgc_status): Do not access beyond zombies array
8756 boundary if nzombies > MAX_ZOMBIES.
8757 * alloc.c (dump_zombies): Add missing format specifier.
8758
0324f3af
PE
87592011-10-12 Paul Eggert <eggert@cs.ucla.edu>
8760
b5525cac
PE
8761 * xdisp.c (set_cursor_from_row): Simplify conditionals,
8762 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
8763
0324f3af
PE
8764 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
8765 Some packages use them to denote characters with modifiers.
8766
e9b5f888
AS
87672011-10-11 Andreas Schwab <schwab@linux-m68k.org>
8768
8769 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
8770 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
8771 matching a pp-number. Rename parameter var to var1.
8772
127827c0
SM
87732011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
8774
8775 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
8776
c8fd3bd0
GM
87772011-10-08 Glenn Morris <rgm@gnu.org>
8778
8779 * callint.c (Fcall_interactively): Give a more explicit error for the
8780 'c' case with a non-character input. (Bug#8479)
8781
352ec8ff
EZ
87822011-10-08 Eli Zaretskii <eliz@gnu.org>
8783
03669ccb
EZ
8784 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
8785 lines.
7061c986
EZ
8786 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
8787 lines that are hscrolled on the left.
03669ccb 8788
352ec8ff
EZ
8789 * dispnew.c (buffer_posn_from_coords): Account for a possible
8790 presence of header-line. (Bug#4426)
8791
a66cfb1c
SM
87922011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
8793
6b02f655
SM
8794 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
8795 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 8796
7c5ee88e
PE
87972011-10-07 Paul Eggert <eggert@cs.ucla.edu>
8798
8799 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
8800 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
8801 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
8802 this makes Emacs dump core during garbage collection on rare
8803 occasions. sizeof is obviously inferior to offsetof here, so
8804 stick with offsetof.
8805 (GC_POINTER_ALIGNMENT): New macro.
8806 (mark_memory): Omit 3rd (offset) arg; caller changed.
8807 Don't assume EMACS_INT alignment is the same as pointer alignment.
8808
df1bbe5b
SM
88092011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
8810
8811 * keyboard.c (read_key_sequence_remapped): New var.
8812 (read_key_sequence): Compute remapping in the right buffer.
8813 (command_loop_1): Use read_key_sequence's remapping directly.
8814
51553db6
SM
88152011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
8816
32c1fffd
SM
8817 * dired.c (file_name_completion): Don't expand file name.
8818 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
8819 before checking file name handler.
8820
51553db6
SM
8821 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
8822 they've been requested explicitly (bug#9591).
8823
b6bd1599 88242011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
8825
8826 * keymap.c (Fsingle_key_description): Use make_specified_string
8827 instead of build_string to build string from push_key_description.
8828 (Bug#5193)
8829
f701dc2a
PE
88302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8831
4222c55d
PE
8832 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
8833 This fixes a Y2038 bug on 64-bit hosts.
8834 * buffer.c (reset_buffer):
8835 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
8836 (Fclear_buffer_auto_save_failure):
8837 Use 0, not -1, to represent an unset failure time, since time_t
8838 might not be signed.
8839
f701dc2a
PE
8840 Remove dependency on glibc malloc internals.
8841 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8842 Move back here from lisp.h, but with their new implementations.
8843 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8844 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
8845 * charset.c (charset_table_init): New static var.
8846 (syms_of_charset): Use it instead of xmalloc. This removes a
8847 dependency on glibc malloc internals. See Eli Zaretskii's comment in
8848 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
8849 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8850 Move back to alloc.c.
8851 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8852 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
8853
9ceebf39
JD
88542011-09-30 Jan Djärv <jan.h.d@swipnet.se>
8855
8856 * nsterm.m (windowDidResize): Call x_set_window_size only when
8857 ns_in_resize is true. Otherwise set pixelwidth/height and
8858 call change_frame_size (Bug#9628).
8859
cb993c58
PE
88602011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8861
3930c88b
PE
8862 Port --enable-checking=all to Fedora 14 x86-64.
8863 * charset.c (syms_of_charset): Also account for glibc malloc's
8864 internal overhead when calculating the initial malloc maximum.
8865
cb993c58
PE
8866 Port --enable-checking=all to Fedora 14 x86.
8867 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8868 Move to lisp.h.
8869 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
8870 (overrun_check_realloc, overrun_check_free):
8871 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
8872 That way, xmalloc returns a properly-aligned pointer even if
8873 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
8874 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
8875 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
8876 into account when calculating the initial malloc maximum.
8877 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8878 Move here from alloc.c, so that charset.c can use it too.
8879 Properly align; the old code wasn't right for common 32-bit hosts
8880 when configured with --enable-checking=all.
8881 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8882 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
8883
31bed486
EZ
88842011-09-29 Eli Zaretskii <eliz@gnu.org>
8885
04c70788 8886 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
8887 use EDOM.
8888
fbcaa2f3
EZ
88892011-09-28 Eli Zaretskii <eliz@gnu.org>
8890
8891 * xdisp.c (compute_display_string_end): If there's no display
8892 string at CHARPOS, return -1.
8893
8894 * bidi.c (bidi_fetch_char): When compute_display_string_end
8895 returns a negative value, treat the character as a normal
8896 character not covered by a display string. (Bug#9624)
8897
a239d4e9
JB
88982011-09-28 Juanma Barranquero <lekktu@gmail.com>
8899
8900 * lread.c (Fread_from_string): Fix typo in docstring.
8901
88652fd5
EZ
89022011-09-27 Eli Zaretskii <eliz@gnu.org>
8903
8904 * xdisp.c (handle_invisible_prop): If invisible text ends on a
8905 newline, reseat the iterator instead of bidi-iterating there one
8906 character at a time. (Bug#9610)
32c1fffd
SM
8907 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
8908 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 8909
ed497dd4
AS
89102011-09-27 Andreas Schwab <schwab@linux-m68k.org>
8911
8912 * lread.c (readevalloop): Use correct code for NBSP.
8913 (read1): Likewise. (Bug#9608)
8914
b2bf61aa
MA
89152011-09-25 Michael Albinus <michael.albinus@gmx.de>
8916
8917 * dbusbind.c (Fdbus_register_signal): When service is not
8918 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
8919
32bbb17c
GM
89202011-09-25 Glenn Morris <rgm@gnu.org>
8921
8922 * buffer.c (truncate-lines): Doc fix.
8923
94e0933e
CY
89242011-09-24 Chong Yidong <cyd@stupidchicken.com>
8925
8926 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
8927 (Fset_window_next_buffers): Doc fix.
8928
cddde921
GM
89292011-09-24 Glenn Morris <rgm@gnu.org>
8930
8931 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
8932
1260aef1
PE
89332011-09-24 Paul Eggert <eggert@cs.ucla.edu>
8934
25b4bfa0
PE
8935 Fix minor problems found by static checking.
8936 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
8937 * indent.c (Fvertical_motion): Fix == vs = typo.
8938
e3cbd34b
EZ
89392011-09-24 Eli Zaretskii <eliz@gnu.org>
8940
a66cfb1c
SM
8941 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
8942 Default value is now t. Doc fix.
6bf7006f 8943
e3cbd34b 8944 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 8945 logic when moving up, not only when moving down. Fix the
e3cbd34b 8946 confusing name and values of the it_overshoot_expected variable;
32c1fffd 8947 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
8948
8949 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
8950 CHARPOS is covered by a display string which includes newlines.
8951 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
8952 is covered by a display string with embedded newlines.
8953
a3de0cbd
MA
89542011-09-24 Michael Albinus <michael.albinus@gmx.de>
8955
8956 * dbusbind.c (Fdbus_register_signal): Add match rule to
8957 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
8958 (Fdbus_register_method, Vdbus_registered_objects_table):
8959 Fix docstring.
a3de0cbd 8960
b260039d
JM
89612011-09-24 Jim Meyering <meyering@redhat.com>
8962
32c1fffd 8963 do not ignore write error for any output size
b260039d
JM
8964 The previous change was incomplete.
8965 While it makes emacs --batch detect the vast majority of stdout
8966 write failures, errors were still ignored whenever the output size is
8967 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
8968 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
8969 && echo FAIL: ignored write error
8970 FAIL: ignored write error
8971 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
8972 && echo FAIL: ignored write error
8973 FAIL: ignored write error
8974 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
8975
8eca8a7c
AS
89762011-09-23 Andreas Schwab <schwab@linux-m68k.org>
8977
8978 * emacs.c (Fkill_emacs): In noninteractive mode exit
8979 non-successfully if a write error occurred on stdout. (Bug#9574)
8980
3341db62
EZ
89812011-09-21 Eli Zaretskii <eliz@gnu.org>
8982
8983 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
8984 the xassert test.
8985
8986 * dispextern.h (struct it): Update the comment documenting what
8987 can it->OBJECT be.
8988
8c203dbf
EZ
89892011-09-20 Eli Zaretskii <eliz@gnu.org>
8990
8991 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
8992 a display string, extend search for cursor position to end of row.
8993 (find_row_edges): If the row ends in a newline from a display
8994 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
8995 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
8996 (Fcurrent_bidi_paragraph_direction): Fix search for previous
8997 non-empty line. Fixes confusing cursor motion with arrow keys at
8998 the beginning of a line that starts with whitespace.
8c203dbf 8999
a4824228
LMI
90002011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9001
9002 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
9003 (bug#9493).
9004
33ed493b
CY
90052011-09-18 Chong Yidong <cyd@stupidchicken.com>
9006
9007 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
9008 boolean (Bug#9154).
9009
56cd55c8
EZ
90102011-09-18 Eli Zaretskii <eliz@gnu.org>
9011
9012 * xdisp.c (display_line): Record maximum and minimum buffer
9013 positions even if no glyphs were produced (e.g., by a zero-width
9014 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
9015 buffer positions that will be removed from the glyph row because
9016 they don't fit.
c02dcedf
EZ
9017 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
9018 column is beyond frame width: don't subtract 1 "pixel" when
9019 computing width of the stretch.
3e62b7e0
EZ
9020 (reseat_at_next_visible_line_start): Undo the change made on
9021 2011-09-17 that saved paragraph information and restored it after
9022 the call to `reseat'. (Bug#9545)
56cd55c8 9023
5ed99d36 90242011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
9025
9026 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
9027 and turn window cursor on if cleared (Bug#9415).
9028
5ed99d36 90292011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
9030
9031 * search.c (boyer_moore): Take unibyte characters from pattern
9032 literally. (Bug#9458)
9033
9bade7b2
EZ
90342011-09-18 Eli Zaretskii <eliz@gnu.org>
9035
9036 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
9037
e5e9d610
PE
90382011-09-18 Paul Eggert <eggert@cs.ucla.edu>
9039
87e4427a
PE
9040 Fix minor problem found by static checking.
9041 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
9042 initialized, to pacify gcc -Wuninitialized.
9043
e5e9d610
PE
9044 * fileio.c: Report proper errno when syscall falls.
9045 (Finsert_file_contents): Save and restore errno,
9046 so that report_file_error outputs the correct diagnostic.
9047 (Fwrite_region) [CLASH_DETECTION]: Likewise.
9048
a1674f0b
EZ
90492011-09-18 Eli Zaretskii <eliz@gnu.org>
9050
9051 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
9052
fbfb6dd4
EZ
90532011-09-17 Eli Zaretskii <eliz@gnu.org>
9054
9055 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
9056 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
9057
bb187662
EZ
90582011-09-17 Eli Zaretskii <eliz@gnu.org>
9059
1137e8b8 9060 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 9061 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
9062
9063 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
9064 (bidi_find_paragraph_start): Search back for paragraph beginning
9065 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
9066 (bidi_move_to_visually_next): Only trigger paragraph-related
9067 computations when the last character is a newline or at EOB, not
9068 just any NEUTRAL_B. (Bug#9470)
9069
bb187662
EZ
9070 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
9071 truncated lines if point is covered by a display string. (Bug#9524)
9072
2e621251
PE
90732011-09-16 Paul Eggert <eggert@cs.ucla.edu>
9074
9075 * xselect.c: Relax test for outgoing X longs (Bug#9498).
9076 (cons_to_x_long): New function.
9077 (lisp_data_to_selection_data): Use it. Correct the test for
9078 short-versus-long data; it was negated. Break out of vector
9079 loop, for efficiency, when a long datum is discovered.
9080
91a15bc6
SM
90812011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
9082
9083 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
9084
b41c3a35
EZ
90852011-09-16 Eli Zaretskii <eliz@gnu.org>
9086
9087 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
9088 GCC PR/17406) by declaring this function with external scope.
9089
7812ba2d
PE
90902011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9091
9092 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
9093 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
9094
cf7edc2a
AS
90952011-09-15 Andreas Schwab <schwab@linux-m68k.org>
9096
9097 * editfns.c (Fformat): Correctly handle text properties on "%%".
9098
bd01620e
EZ
90992011-09-15 Eli Zaretskii <eliz@gnu.org>
9100
9101 * xterm.c (x_draw_composite_glyph_string_foreground):
9102 * w32term.c (x_draw_composite_glyph_string_foreground):
9103 * term.c (encode_terminal_code):
9104 * composite.c (composition_update_it, get_composition_id):
9105 * xdisp.c (get_next_display_element)
9106 (fill_composite_glyph_string): Add comments about special meaning
9107 of TAB characters in a composition.
9108
a02719a3
PE
91092011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9110
9111 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
9112 This occurs when processing a multibyte format.
9113 Problem reported by Wolfgang Jenker.
a02719a3 9114
72589a3c
JB
91152011-09-15 Johan Bockgård <bojohan@gnu.org>
9116
9117 * xdisp.c (try_cursor_movement): Only check for exact match if
9118 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
9119
1c14176c
PE
91202011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9121
9122 Remove unused external symbols.
9123 * dispextern.h (calc_pixel_width_or_height): Remove decl.
9124 * xdisp.c (calc_pixel_width_or_height): Now static.
9125 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
9126 * indent.c (check_display_width):
9127 * w32term.c: Fix comment to match code.
9128 * xterm.c, xterm.h (x_catching_errors): Remove.
9129
d2eea5b5
PE
91302011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9131
9132 * xselect.c: Use signed conversions more consistently (Bug#9498).
9133 (selection_data_to_lisp_data): Assume incoming selection data are
9134 signed integers, not unsigned. This is to be consistent with
9135 outgoing selection data, which was modified to use signed integers
9136 in as part of the fix to Bug#9196 in response to Jan D.'s comment
9137 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
9138 expects long, not unsigned long.
9139
46888499
EZ
91402011-09-14 Eli Zaretskii <eliz@gnu.org>
9141
9142 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
9143 computation of loop end. Reported by Johan Bockgård
9144 <bojohan@gnu.org>.
9145
ef8ef9fb
CY
91462011-09-13 Chong Yidong <cyd@stupidchicken.com>
9147
9148 * frame.c (Fother_visible_frames_p): Function deleted.
9149
fa819fed
EZ
91502011-09-12 Eli Zaretskii <eliz@gnu.org>
9151
9152 * indent.c (compute_motion): Process display vector front to back
9153 rather than the other way around. (Bug#2496)
9154
2ba8e008
SM
91552011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
9156
9157 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
9158
20f53c69
CY
91592011-09-11 Chong Yidong <cyd@stupidchicken.com>
9160
9161 * minibuf.c (Fread_from_minibuffer): Doc fix.
9162
d562d7a4
EZ
91632011-09-11 Eli Zaretskii <eliz@gnu.org>
9164
9165 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
9166 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
9167
1c4d7f3d
LMI
91682011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9169
9170 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
9171 value for non-existent files.
9172
b885bf36
EZ
91732011-09-11 Eli Zaretskii <eliz@gnu.org>
9174
9175 * fileio.c (Finsert_file_contents): If the file cannot be opened,
9176 set its "size" to -1. This will set the modtime_size field of
9177 the corresponding buffer to -1, which is what
9178 verify-visited-file-modtime expects for files that do not exist.
9179 (Bug#9139)
9180
6612f0bf
PE
91812011-09-11 Paul Eggert <eggert@cs.ucla.edu>
9182
9183 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
9184 here ...
9185 * lisp.h: ... from here. push_key_description is no longer
9186 defined in keyboard.c, so its declaration should not be in
9187 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
9188 logically belongs with push_key_description.
9189
dfb3f755
PE
91902011-09-10 Paul Eggert <eggert@cs.ucla.edu>
9191
9192 * buffer.h: Include <sys/types.h> instead of <time.h>.
9193 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
9194 Problem reported by Herbert J. Skuhra.
9195
3134906c
LMI
91962011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
9197
9198 * xml.c (parse_region): Make the parsing work for
9199 non-comment-starting XML files again (bug#9144).
9200
8d903f4e
AS
92012011-09-10 Andreas Schwab <schwab@linux-m68k.org>
9202
9203 * image.c (gif_load): Fix calculation of bottom and right corner.
9204 (Bug#9468)
9205
80ad64f4
EZ
92062011-09-10 Eli Zaretskii <eliz@gnu.org>
9207
9208 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
9209 redisplay in small windows.
9210
208a048d
EZ
92112011-09-09 Eli Zaretskii <eliz@gnu.org>
9212
9213 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
9214
9b1c252e
MR
92152011-09-08 Martin Rudalics <rudalics@gmx.at>
9216
9217 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
9218 Operate on live windows only.
9219
2949f33b
JB
92202011-09-08 Juanma Barranquero <lekktu@gmail.com>
9221
9222 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
9223
e08dcafd
EZ
92242011-09-07 Eli Zaretskii <eliz@gnu.org>
9225
9226 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
9227 only under bidi iteration.
9228
115b96bd
JD
92292011-09-07 Jan Djärv <jan.h.d@swipnet.se>
9230
9231 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
9232
c8199d0f
PE
92332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
9234
9235 isnan: Fix porting problem to Solaris 10 with bundled gcc.
9236 Without this fix, the command to link temacs failed due to an
9237 undefined symbol __builtin_isnan. This is because
9238 /usr/include/iso/math_c99.h #defines isnan(x) to
9239 __builtin_isnan(x), but the bundled gcc, which identifies itself
9240 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
9241 a __builtin_isnan.
9242 * floatfns.c (isnan): #undef, and then #define to a clone of
9243 what's in data.c.
9244 (Fisnan): Always define, since it's always available now.
9245 (syms_of_floatfns): Always define isnan at the Lisp level.
9246
e39b275c 92472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
9248
9249 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
9250
b2db44d9 92512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 9252
f4af5137 9253 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
9254 The previous code assumed that file offsets (off_t values) fit in
9255 EMACS_INT variables, which is not true on typical 32-bit hosts.
9256 The code messed up by falsely reporting buffer overflow in cases
9257 such as (insert-file-contents "big" nil 1 2) into an empty buffer
9258 when "big" contains more than 2**29 bytes, even though this
9259 inserts just one byte and does not overflow the buffer.
9260 (Finsert_file_contents): Store file offsets as off_t
9261 values, not as EMACS_INT values. Check for overflow when
9262 converting between EMACS_INT and off_t. When checking for
9263 buffer overflow or for overlap, take the offsets into account.
9264 Don't use EMACS_INT for small values where int suffices.
9265 When checking for overlap, fix a typo: ZV was used where
9266 ZV_BYTE was intended.
9267 (Fwrite_region): Don't assume off_t fits into 'long'.
9268 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
9269
ecfc0a49
MA
92702011-09-05 Michael Albinus <michael.albinus@gmx.de>
9271
9272 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
9273
6511acf2 92742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 9275
0999621a 9276 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
9277
9278 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 9279 (esprintf, exprintf, evxprintf): New functions.
62f19c19 9280 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 9281 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
9282 (modify_event_symbol): Do not assume that the length of
9283 name_alist_or_stem is safe to alloca and fits in int.
9284 (Fexecute_extended_command): Likewise for function name and binding.
9285 (Frecursion_depth): Wrap around reliably on integer overflow.
9286 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
9287 since some callers pass EMACS_INT values.
9288 (Fsingle_key_description): Don't crash if symbol name contains more
9289 than MAX_ALLOCA bytes.
9290 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
9291 (get_minibuffer): Arg is now EMACS_INT, not int.
9292 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 9293 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
9294 * window.h (command_loop_level, minibuf_level): Reflect API changes.
9295
2be7d702
PE
9296 * dbusbind.c (signature_cat): New function.
9297 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
9298 Do not overrun buffer; instead, report string overflow.
9299
9d1df220
PE
9300 * dispnew.c (add_window_display_history): Don't overrun buffer.
9301 Truncate instead; this is OK since it's just a log.
9302
33ef5c64
PE
9303 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
9304 even if the time zone offset is outlandishly large.
9305 Don't mishandle offset == INT_MIN.
9306
66c6fdd5
PE
9307 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
9308 when creating daemon; the previous buffer-overflow check was incorrect.
9309
d749b01b
PE
9310 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
9311 which has the guts of the old verror function.
9312
b5cd1905
PE
9313 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
9314 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
9315
6e1a67fb
PE
9316 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
9317 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 9318 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 9319 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
9320 length of string rather than counting it via multiple sprintfs;
9321 that's simpler and more reliable.
c21721cc
PE
9322 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
9323 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
9324 sprintf, in case result does not fit in int.
9325
c57b67fc
PE
9326 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
9327 (fontset_from_font): Print it.
9328
8a401434
PE
9329 * frame.c (tty_frame_count): Now printmax_t, not int.
9330 (make_terminal_frame, set_term_frame_name): Print it.
9331 (x_report_frame_params): In X, window IDs are unsigned long,
9332 not signed long, so print them as unsigned.
9333 (validate_x_resource_name): Check for implausibly long names,
9334 and don't assume name length fits in 'int'.
9335 (x_get_resource_string): Don't blindly alloca invocation name;
9336 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
9337 not fit in int.
9338
6e1a67fb
PE
9339 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
9340 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
9341 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
9342
0df02bf3
PE
9343 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
9344 Use esprintf, not sprintf, in case result does not fit in int.
9345
48e30793
PE
9346 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9347 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
9348 it as a large positive number.
9349 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
9350 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9351
a66ff6d8
PE
9352 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
9353 in case result does not fit in int.
9354
aca216ff
PE
9355 * print.c (float_to_string): Detect width overflow more reliably.
9356 (print_object): Make sprintf buffer a bit bigger, to avoid potential
9357 buffer overrun. Don't assume list length fits in 'int'. Treat
9358 print length of 0 as 0, not as infinity; to be consistent with other
9359 uses of print length in this function. Don't overflow print length
9360 index. Don't assume hash table size fits in 'long', or that
9361 vectorlike size fits in 'unsigned long'.
9362
31c286f7
PE
9363 * process.c (make_process): Use printmax_t, not int, to format
9364 process-name gensyms.
9365
55e5faa1
PE
9366 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
9367
80f2e268
PE
9368 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
9369 to avoid potential buffer overrun.
9370
670741ab
PE
9371 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
9372 if X resource line is longer than 512 bytes.
9373
b7163a50
PE
9374 * xfns.c (x_window): Make sprintf buffer a bit bigger
9375 to avoid potential buffer overrun.
9376
ae58ff1f
PE
9377 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
9378
c43c8a6a
PE
9379 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
9380
3f8236f4
PE
93812011-09-04 Paul Eggert <eggert@cs.ucla.edu>
9382
53e9fe90 9383 Integer overflow fixes for scrolling, etc.
6511acf2
PE
9384 Without these, Emacs silently mishandles large integers sometimes.
9385 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
9386 it were "C-u 1 M-x recenter" on a typical 64-bit host.
9387
6511acf2
PE
9388 * xdisp.c (try_window_id): Check Emacs fixnum range before
9389 converting to 'int'.
806add1d 9390
6511acf2 9391 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
9392 Check that an Emacs fixnum is in range before assigning it to 'int'.
9393 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
9394 values converted from Emacs fixnums.
9395 (Frecenter): Don't wrap around a line count if it is out of 'int'
9396 range; instead, treat it as an extreme value.
9397 (Fset_window_configuration, compare_window_configurations):
9398 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
9399
6511acf2
PE
9400 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
9401 that can exceed INT_MAX. Check that EMACS_INT value is in range
9402 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
9403 (match_limit): Don't assume that a fixnum can fit in 'int'.
9404
6511acf2 9405 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
9406 exceed INT_MAX.
9407
6511acf2 9408 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
9409 (Fvertical_motion): Don't wrap around LINES values that don't fit
9410 in 'int'. Instead, treat them as extreme values. This is good
9411 enough for windows, which can't have more than INT_MAX lines anyway.
9412
fcb901a7
LMI
94132011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9414
0f2f6b6d
LMI
9415 * Require libxml/parser.h to avoid compilation warning.
9416
fcb901a7
LMI
9417 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
9418
9419 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
9420 since this reportedly can destroy thread storage.
9421
6e20a0d4
CY
94222011-08-30 Chong Yidong <cyd@stupidchicken.com>
9423
9424 * syntax.c (find_defun_start): Update all cache variables if
9425 exiting early (Bug#9401).
9426
148ae00e
EZ
94272011-08-30 Eli Zaretskii <eliz@gnu.org>
9428
f6cfbd8f
EZ
9429 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
9430
148ae00e
EZ
9431 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
9432 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
9433 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
9434
9435 * term.c (tty_append_glyph): New function.
9436 (produce_stretch_glyph): Static function and its prototype deleted.
9437
a66cfb1c
SM
9438 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
9439 Add prototypes.
148ae00e 9440
c4a07a4c
PE
94412011-08-29 Paul Eggert <eggert@cs.ucla.edu>
9442
9443 * image.c (parse_image_spec): Check for nonnegative, not for positive,
9444 when checking :margin (Bug#9390).
9445 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 9446 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
9447 so that the name doesn't mislead. All uses changed.
9448
6bc8cd65
JB
94492011-08-28 Johan Bockgård <bojohan@gnu.org>
9450
9451 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
9452 set_tty_hooks.
9453
dca4927e
EZ
94542011-08-27 Eli Zaretskii <eliz@gnu.org>
9455
9456 * xdisp.c (move_it_to): Don't bail out early when reaching
9457 position beyond to_charpos, if we are scanning backwards.
9458 (move_it_vertically_backward): When DY == 0, make sure we get to
9459 the first character in the line after the newline.
9460
f2cad773
PE
94612011-08-27 Paul Eggert <eggert@cs.ucla.edu>
9462
9463 * ccl.c: Improve and simplify overflow checking (Bug#9196).
9464 (ccl_driver): Do not generate an out-of-range pointer.
9465 (Fccl_execute_on_string): Remove unnecessary check for
9466 integer overflow, noted by Stefan Monnier in
9467 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
9468 Remove a FIXME that didn't need fixing.
9469 Simplify the newly-introduced buffer reallocation code.
9470
0cae2cdb
JB
94712011-08-27 Juanma Barranquero <lekktu@gmail.com>
9472
9473 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
9474
5fc295a4 94752011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 9476
70c60eb2 9477 Integer and memory overflow issues (Bug#9196).
726e0ab1 9478
d31850da
PE
9479 * doc.c (get_doc_string): Rework so that
9480 get_doc_string_buffer_size is the actual buffer size, rather than
9481 being 1 less than the actual buffer size; this makes xpalloc more
9482 convenient.
9483
a69fbedb
PE
9484 * image.c (x_allocate_bitmap_record, cache_image):
9485 * xselect.c (Fx_register_dnd_atom):
9486 Simplify previous changes by using xpalloc.
9487
fe5c5d37
PE
9488 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
9489 since either will do and ptrdiff_t is convenient with xpalloc.
9490
0065d054
PE
9491 * charset.c (charset_table_size)
9492 (struct charset_sort_data.priority): Now ptrdiff_t.
9493 (charset_compare): Don't overflow if priorities differ greatly.
9494 (Fsort_charsets): Don't assume list length fits in int.
9495 Check for size-calculation overflow when allocating sort data.
9496 (syms_of_charset): Allocate an initial charset table that is
9497 just under 64 KiB, to avoid problems with glibc malloc and mmap.
9498
9499 * cmds.c (internal_self_insert): Check for size-calculation overflow.
9500
9501 * composite.h (struct composition.glyph_len): Now int, not unsigned.
9502 The actual value is always <= INT_MAX, and leaving it unsigned made
9503 overflow checking harder.
9504
9505 * dispextern.h (struct glyph_matrix.rows_allocated)
9506 (struct face_cache.size): Now ptrdiff_t, for convenience in use
9507 with xpalloc. The values are still always <= INT_MAX.
9508
9509 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
9510
9511 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
9512 (SAFE_NALLOCA): New macro.
9513
9514 * region-cache.c (struct boundary.pos, find_cache_boundary)
9515 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
9516 (set_cache_region, invalidate_region_cache)
9517 (revalidate_region_cache, know_region_cache, region_cache_forward)
9518 (region_cache_backward, pp_cache):
9519 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
9520 so that ptrdiff_t * can be passed to xpalloc.
9521 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
9522 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
9523 (pp_cache): Don't assume cache_len fits in int.
9524 * region-cache.h: Adjust extern decls to match.
9525
9526 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
9527 EMACS_INT, since either will do, for xpalloc.
9528
9529 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
9530 (xnmalloc, xnrealloc, xpalloc): New functions.
9531
726e0ab1
PE
9532 * bidi.c (bidi_shelve_header_size): New constant.
9533 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
9534 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
9535
51f30bc5 9536 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
9537 * buffer.c (overlays_at, overlays_in, record_overlay_string)
9538 (overlay_strings):
9539 Don't update size of array until after memory allocation succeeds,
9540 because xmalloc/xrealloc may not return.
0065d054
PE
9541 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
9542 now that we have proper integer overflow checking.
9543 (record_overlay_string, overlay_strings): Catch overflows when
9544 calculating size of overlay_str_buf.
726e0ab1 9545
0065d054
PE
9546 * callproc.c (Fcall_process): Check for size overflow when
9547 calculating size of args2.
9548 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
9549 Normally we prefer signed values, but sticking with ptrdiff_t would
9550 require adding more-complicated checks.
726e0ab1
PE
9551
9552 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
9553 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
9554 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 9555 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
9556
9557 * character.c (Fstring): Check for size-calculation overflow.
9558
9559 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
9560 unnecessary integer overflow. Check for size overflow.
9561 (encode_coding_object): Don't update size until xmalloc succeeds.
9562
9563 * composite.c (get_composition_id): Check for overflow in glyph
9564 length calculations.
9565
9566 Integer and memory overflow fixes for display code.
9567 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
9568 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
9569 (scrolling_window): Check for overflow in size calculations.
9570 (line_draw_cost, realloc_glyph_pool, add_row_entry):
9571 Don't assume glyph table len fits in int.
9572 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
9573 (row_table_size): Now ptrdiff_t, not int.
9574 (scrolling_window): Avoid overflow in size calculations.
9575 Don't update size until allocation succeeds.
9576 * fns.c (concat): Check for overflow in size calculations.
9577 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
9578 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9579 (NEXT_ALMOST_PRIME_LIMIT): New constant.
9580
9581 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
9582 (get_doc_string): Check for size calculation overflow.
9583 Don't update size until allocation succeeds.
9584 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
9585 EMACS_INT, where ptrdiff_t will do.
9586 (Fsubstitute_command_keys): Check for string overflow.
9587
9588 * editfns.c (set_time_zone_rule): Don't assume environment length
9589 fits in int.
9590 (message_length): Now ptrdiff_t, not int.
9591 (Fmessage_box): Don't update size until allocation succeeds.
9592 Don't assume message length fits in int.
9593 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
9594
0065d054
PE
9595 * emacs.c (main): Do not reallocate argv, since there is a null at
9596 the end that can be overwritten, and this way there's no need to
9597 worry about size-calculation overflow.
9598 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
9599
9600 * eval.c (init_eval_once, grow_specpdl): Don't update size until
9601 alloc succeeds.
9602 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
9603
9604 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
9605 (x_set_scroll_bar_width, x_figure_window_size):
9606 Check for integer overflow.
9607 (x_set_alpha): Do not assume XINT fits in int.
9608
9609 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
9610 This is for the members text_lines, text_cols, total_lines, total_cols,
9611 where the system imposes an 'int' limit.
9612
9613 * fringe.c (Fdefine_fringe_bitmap):
9614 Don't update size until alloc works.
9615
9616 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
9617 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
9618
9619 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
9620 Check for size-calculation overflow.
9621 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
9622 do, as we prefer signed integers.
9623 (id_to_widget.max_size, id_to_widget.used)
9624 (xg_store_widget_in_map, xg_remove_widget_from_map)
9625 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
9626 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
9627 Use and return ptrdiff_t, not int.
9628 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
9629 * gtkutil.h: Change prototypes to match the above.
9630
9631 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
9632 are duplicate now that they've been promoted to lisp.h.
9633 (x_allocate_bitmap_record, x_alloc_image_color)
9634 (make_image_cache, cache_image, xpm_load):
9635 Don't update size until alloc is done.
9636 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
9637 (x_detect_edges):
3256efce 9638 Check for size calculation overflow.
726e0ab1
PE
9639 (ct_colors_allocated_max): New constant.
9640 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
9641 overflow.
3256efce 9642
726e0ab1
PE
9643 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
9644 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
9645 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
9646 Use ptrdiff_t, not int, to count maps.
9647 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
9648 calculations. Don't update size until allocation succeeds.
9649 Redo calculations to avoid overflow.
726e0ab1
PE
9650 * keyboard.h: Change prototypes to match the above.
9651
9652 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
9653 to count maps.
9654 (current_minor_maps): Check for size calculation overflow.
9655 * keymap.h: Change prototypes to match the above.
9656
9657 * lread.c (read1, init_obarray): Don't update size until alloc done.
9658
9659 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
9660 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
9661
726e0ab1
PE
9662 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
9663 Now ptrdiff_t, not int.
9664 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
9665 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
9666
9667 * process.c (Fnetwork_interface_list): Check for overflow
9668 in size calculation.
9669
9670 * region-cache.c (move_cache_gap): Check for size calculation overflow.
9671
9672 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
9673 overflow. Don't bother calling xmalloc when xrealloc will do.
9674
9675 * search.c (Freplace_match): Check for size calculation overflow.
9676 (Fset_match_data): Don't assume list lengths fit in 'int'.
9677
9678 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
9679 for command line length. Do not attempt to address one before the
9680 beginning of an array, as that's not portable.
9681
9682 * term.c (max_frame_lines): Remove; unused.
9683 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
9684 not int.
9685 (encode_terminal_code, calculate_costs): Check for size
9686 calculation overflow.
9687 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
9688 table lengths and related sizes. Don't update size until alloc
9689 done. Redo calculations to avoid overflow.
9690 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
9691
9692 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
9693 subtracting pointers.
9694 (gobble_line): Check for overflow more carefully. Don't update size
9695 until alloc done.
9696
9697 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
9698 Don't update size until alloc done.
9699 Redo size calculations to avoid overflow.
9700 Check for size calculation overflow.
0065d054 9701 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
9702
9703 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
9704 Use ptrdiff_t, not int, for sizes.
9705 (store_mode_line_noprop_char): Don't update size until alloc done.
9706
0065d054
PE
9707 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
9708 Use ptrdiff_t, not int, for sizes.
9709 (Finternal_make_lisp_face, cache_face):
9710 Check for size calculation overflow.
9711 (cache_face): Treat size calculation overflows as if they were
9712 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
9713
9714 * xfns.c (x_encode_text, x_set_name_internal)
9715 (Fx_change_window_property): Use ptrdiff_t, not int, to count
9716 sizes, since they can exceed INT_MAX in size. Check for size
9717 calculation overflow.
9718
0065d054
PE
9719 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
9720 (xg_select): Check for size calculation overflow.
726e0ab1
PE
9721 Don't update size until alloc done.
9722
0065d054 9723 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 9724 as sprintf is limited to int lengths.
1d526e2f 9725
252c5ee1
PE
9726 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
9727 (X_LONG_MIN): New macros.
864d7ce7
PE
9728 Use them to make the following changes clearer.
9729 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
9730 This change doesn't affect the value now, but it may help remind
9731 future maintainers not to raise the value too much later.
9732 (SELECTION_QUANTUM): Remove, replacing with ...
9733 (selection_quantum): ... new function, which avoids overflow.
9734 All uses changed.
9735 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
9736 assumption that selection length fits in 'int'.
9737 (x_reply_selection_request, x_handle_selection_request)
9738 (x_get_window_property, receive_incremental_selection)
9739 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
9740 (lisp_data_to_selection_data, clean_local_selection_data):
9741 Use ptrdiff_t, not int, to record length of selection.
9742 (x_reply_selection_request, x_get_window_property)
9743 (receive_incremental_selection, x_property_data_to_lisp):
9744 Redo calculations to avoid overflow.
9745 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 9746 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
9747 something.
9748 (x_get_window_property, receive_incremental_selection)
9749 (lisp_data_to_selection_data, x_property_data_to_lisp):
9750 Check for size-calculation overflow.
9751 (x_get_window_property, receive_incremental_selection)
9752 (lisp_data_to_selection_data, Fx_register_dnd_atom):
9753 Don't store size until memory allocation succeeds.
9754 (x_get_window_property): Plug memory leak on memory exhaustion.
9755 Don't double-block input; malloc is safe here. Don't assume 2**34
9756 - 4 fits in unsigned long. Add an xassert to check
9757 XGetWindowProperty overflow. Be more careful about overflow
9758 calculations, and distinguish size from memory overflow better.
9759 (receive_incremental_selection): When tracing, don't assume
9760 unsigned int is less than INT_MAX.
9761 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
9762 harmful) conversions of unsigned short to int.
9763 (lisp_data_to_selection_data): Don't assume that integers
9764 in the range -65535 through -1 fit in an X unsigned short.
9765 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
9766 result parameters unless successful. Rely on cons_to_unsigned
9767 to report problems with elements; the old code wasn't right anyway.
9768 (x_check_property_data): Check for int overflow; we cannot use
9769 a wider type due to X limits.
9770 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
9771
726e0ab1 9772 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 9773
0065d054
PE
9774 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
9775 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
9776 (x_color_cells): Don't store size until memory allocation succeeds.
9777 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 9778 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
9779 (x_term_init): Don't assume length fits in int (sprintf is limited
9780 to int size).
bc18e09d 9781
ebfa62c0
PE
9782 Use ptrdiff_t for composition IDs.
9783 * character.c (lisp_string_width):
9784 * composite.c (composition_table_size, n_compositions)
9785 (get_composition_id, composition_gstring_from_id):
9786 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
9787 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
9788 * window.c (Frecenter):
9789 Use ptrdiff_t, not int, for composition IDs.
9790 * composite.c (get_composition_id): Check for integer overflow.
9791 * composite.h: Adjust prototypes to match the above changes.
9792
d3411f89
PE
9793 Use ptrdiff_t for hash table indexes.
9794 * category.c (hash_get_category_set):
9795 * ccl.c (ccl_driver):
9796 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
9797 * coding.c (coding_system_charset_list, detect_coding_system):
9798 * coding.h (struct coding_system.id):
9799 * composite.c (get_composition_id, gstring_lookup_cache):
9800 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
9801 * image.c (xpm_get_color_table_h):
9802 * lisp.h (hash_lookup, hash_put):
9803 * minibuf.c (Ftest_completion):
9804 Use ptrdiff_t for hash table indexes, not int (which is too
9805 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
9806 32-bit --with-wide-int hosts).
9807
e097a6fa
PE
9808 * charset.c (Fdefine_charset_internal): Check for integer overflow.
9809 Add a FIXME comment about memory leaks.
9810 (syms_of_charset): Don't assume xmalloc returns.
9811
5637687f
PE
9812 Don't assume that stated character widths fit in int.
9813 * character.c (Fchar_width, c_string_width, lisp_string_width):
9814 * character.h (CHAR_WIDTH):
9815 * indent.c (MULTIBYTE_BYTES_WIDTH):
9816 Use sanitize_char_width to avoid undefined and/or bad behavior
9817 with outlandish widths.
a66cfb1c 9818 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
9819 now that we have two such functions. All uses changed.
9820 (sanitize_char_width): New inline function.
9821
a2271ba2
PE
9822 Don't assume that tab-width fits in int.
9823 * character.h (sanitize_width): New inline function.
9824 (SANE_TAB_WIDTH): New macro.
9825 (ASCII_CHAR_WIDTH): Use it.
9826 * indent.c (sane_tab_width): Remove. All uses replaced by
9827 SANE_TAB_WIDTH (current_buffer).
9828 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
9829
18c52557
PE
9830 * fileio.c: Integer overflow issues with file modes.
9831 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
9832
caeeedc1
PE
9833 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
9834 Remove unreachable code.
9835 (read_hex, load_charset_map_from_file): Check for integer overflow.
9836
6df6ae42 9837 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
9838 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
9839 (x_send_scroll_bar_event): Likewise. Check that the size does not
9840 exceed limits imposed by XClientMessageEvent, as well as the usual
9841 ptrdiff_t and size_t limits.
9842
b13995db
PE
9843 * keyboard.c: Overflow, signedness and related fixes.
9844 (make_lispy_movement): Use same integer type in forward decl
9845 that is used in the definition.
9846 (read_key_sequence, keyremap_step):
9847 Change bufsize argument back to int, undoing my 2011-03-30 change.
9848 We prefer signed types, and int is wide enough here.
9849 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
9850 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
9851 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
9852 length, not size_t. Use ptrdiff_t for index, not int.
9853 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
9854 possibility of integer overflow.
9855
13464394
PE
9856 Overflow, signedness and related fixes for images.
9857
9858 * dispextern.h (struct it.stack[0].u.image.image_id)
9859 (struct_it.image_id, struct image.id, struct image_cache.size)
9860 (struct image_cache.used, struct image_cache.ref_count):
9861 * gtkutil.c (update_frame_tool_bar):
9862 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
9863 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
9864 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
9865 * nsmenu.m (update_frame_tool_bar):
9866 * xdisp.c (calc_pixel_width_or_height):
9867 * xfns.c (image_cache_refcount):
9868 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
9869 on typical 64-bit hosts.
9870
9871 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9872 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
9873 Omit unnecessary casts to int.
9874 (parse_image_spec): Check that integers fall into 'int' range
9875 when the callers expect that.
9876 (image_ascent): Redo ascent calculation to avoid int overflow.
9877 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
9878 (lookup_image): Remove unnecessary tests.
9879 (xbm_image_p): Locals are now of int, not EMACS_INT,
9880 since parse_image_check makes sure they fit into int.
9881 (png_load, gif_load, svg_load_image):
9882 Prefer int to unsigned where either will do.
9883 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
9884 old tiff_error_handler and tiff_warning_handler.
9885 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
9886 stack buffer overflows. It uses only the features of vsnprintf
9887 that are common to both POSIX and native Microsoft.
9888 (tiff_error_handler, tiff_warning_handler): Use it.
9889 (tiff_load, gif_load, imagemagick_load_image):
9890 Don't assume :index value fits in 'int'.
9891 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
9892 (imagemagick_load_image): Check that crop parameters fit into
9893 the integer types that MagickCropImage accepts. Don't assume
9894 Vimagemagick_render_type has a nonnegative value. Don't assume
9895 size_t fits in 'long'.
9896 (gs_load): Use printmax_t to print the widest integers possible.
9897 Check for integer overflow when computing image height and width.
9898
c11821d4
EZ
98992011-08-26 Eli Zaretskii <eliz@gnu.org>
9900
9901 * xdisp.c (redisplay_window): Don't force window start if point
9902 will be invisible in the resulting window. (Bug#9324)
9903
0c95fcf7
EZ
99042011-08-25 Eli Zaretskii <eliz@gnu.org>
9905
9906 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
9907 the display spec is of the form `(space ...)'.
9908 (handle_display_spec): Return the value returned by
9909 handle_single_display_spec, not just 1 or zero.
9910 (handle_single_display_spec): If the display spec is of the form
9911 `(space ...)', and specifies display in the text area, return 2
9912 rather than 1.
fee65a97 9913 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
9914 accurately, and prefer exact match for point under bidi.
9915 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
9916
9917 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
9918 into disp_prop; all users changed.
9919
9920 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
9921 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
9922 for the text covered by the display property.
9923
e4ed06f1
CY
99242011-08-25 Chong Yidong <cyd@stupidchicken.com>
9925
9926 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
9927 Change return value to nil.
9928 (Frecord_buffer): Delete unused function.
9929
f67cdd7f
EZ
99302011-08-24 Eli Zaretskii <eliz@gnu.org>
9931
5980d4c6
EZ
9932 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
9933 buffers, return left-to-right.
8610fe8b
EZ
9934 (set_cursor_from_row): Consider candidate row a win if its glyph
9935 represents a newline and point is on that newline. Fixes cursor
9936 positioning on the newline at EOL of R2L text within L2R
9937 paragraph, and vice versa.
9938 (try_cursor_movement): Check continued rows, in addition to
9939 continuation rows. Fixes unwarranted scroll when point enters a
9940 continued line of R2L text within an L2R paragraph, or vice versa.
9941 (cursor_row_p): Consider the case of point being equal to
9942 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
9943 from the end of a short line to the beginning of a continued line
9944 of R2L text within L2R paragraph.
9945 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
9946 composed characters.
5980d4c6 9947
f67cdd7f
EZ
9948 * bidi.c (bidi_check_type): Use xassert.
9949 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
9950 members.
9951
bca633fb
EZ
99522011-08-23 Eli Zaretskii <eliz@gnu.org>
9953
9954 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
9955 a character.
9956
4a5885a7
CY
99572011-08-23 Chong Yidong <cyd@stupidchicken.com>
9958
9959 * nsfont.m (ns_otf_to_script): Fix typo.
9960
0902a04e
KH
99612011-08-22 Kenichi Handa <handa@m17n.org>
9962
9963 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
9964 extra slot even if the purpose is char-code-property-table.
9965
1a2e6670
EZ
99662011-08-23 Eli Zaretskii <eliz@gnu.org>
9967
8ddde651
EZ
9968 * xdisp.c (redisplay_window): When computing centering_position,
9969 account for the height of the header line. (Bug#8874)
9970
425cc014
EZ
9971 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
9972 instead of CHAR_TO_BYTE. Fixes a crash when a completion
9973 candidate is selected by the mouse, and that candidate has a
9974 composed character under the mouse.
9975
1a2e6670
EZ
9976 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
9977 coordinates reported by pos-visible-in-window-p for a composed
9978 character in column zero.
9979
8b76d6f8
SM
99802011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
9981
9982 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
9983
dac347dd
EZ
99842011-08-22 Eli Zaretskii <eliz@gnu.org>
9985
9986 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
9987 consider it a hit if to_charpos is anywhere in the range of the
9988 composed buffer positions.
9989
e013fb34
CY
99902011-08-22 Chong Yidong <cyd@stupidchicken.com>
9991
9992 * image.c (gif_load): Don't assume that each subimage has the same
9993 dimensions as the base image. Handle disposal method that is
9994 "undefined" by the gif spec (Bug#9335).
9995
bd1ba3e8
CY
99962011-08-20 Chong Yidong <cyd@stupidchicken.com>
9997
9998 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 9999 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 10000
54a1215b
EZ
100012011-08-19 Eli Zaretskii <eliz@gnu.org>
10002
823564e5
EZ
10003 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
10004 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
10005 from an Org mode buffer to a Speedbar frame.
10006
54a1215b
EZ
10007 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
10008 a composition, take its buffer position from IT->cmp_it.charpos.
10009 Fixes cursor positioning at the beginning of a line that begins
10010 with a composed character.
10011
9778ebcc
EZ
100122011-08-18 Eli Zaretskii <eliz@gnu.org>
10013
0be6ee06
EZ
10014 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
10015 character bidirectional type, use STRONG_L instead. Fixes crashes
10016 in a buffer produced by `describe-categories'.
10017
9778ebcc
EZ
10018 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
10019 members before the level stack, so they would be saved and
10020 restored when copying iterator state. Fixes incorrect reordering
10021 around TABs covered by display properties.
10022
156bffbe
AS
100232011-08-18 Andreas Schwab <schwab@linux-m68k.org>
10024
6b02f655 10025 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 10026
72ad093b
CY
100272011-08-17 Chong Yidong <cyd@stupidchicken.com>
10028
10029 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
10030 (internal_condition_case_2, internal_condition_case_n):
10031 Remove unnecessary aborts (Bug#9081).
72ad093b 10032
35774242
EZ
100332011-08-17 Eli Zaretskii <eliz@gnu.org>
10034
10035 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
10036 has no `load' handler, try opening the file locally. (Bug#9311)
10037
db76dd85
KB
100382011-08-16 Ken Brown <kbrown@cornell.edu>
10039
10040 * gmalloc.c: Expand comment.
10041
b215eee5
EZ
100422011-08-16 Eli Zaretskii <eliz@gnu.org>
10043
10044 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
10045 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
10046
a4579d33
KB
100472011-08-16 Ken Brown <kbrown@cornell.edu>
10048
10049 Fix memory allocation problems in Cygwin build (Bug#9273).
10050
10051 * unexcw.c ( __malloc_initialized): Declare external variable.
10052 (fixup_executable): Force the dumped emacs to reinitialize malloc.
10053
8b76d6f8
SM
10054 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
10055 New variables.
a4579d33
KB
10056 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
10057 dumped emacs.
10058 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
10059 in the static heap.
10060 [CYGWIN] (special_realloc): New function.
10061 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
10062 requests to realloc storage in the static heap.
10063
3ebec551
PE
100642011-08-15 Paul Eggert <eggert@cs.ucla.edu>
10065
10066 * bidi.c (bidi_initialize): Remove unused local.
10067
9fd8be00
EZ
100682011-08-15 Eli Zaretskii <eliz@gnu.org>
10069
6b02f655
SM
10070 * bidimirror.h:
10071 * biditype.h: Remove file.
10072 * makefile.w32-in ($(BLD)/bidi.$(O)):
10073 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
10074
10075 * dispextern.h: Fix a typo in the comment to bidi_type_t.
10076
10077 * chartab.c: Improve commentary for the uniprop_table API.
10078
32413314
EZ
10079 * bidi.c (bidi_paragraph_init): Support zero value of
10080 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
10081 (bidi_initialize): Use uniprop_table instead of including
10082 biditype.h and bidimirror.h.
32413314 10083
9fd8be00
EZ
10084 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
10085 coordinates of the iterator when restoring from ppos_it.
10086 (Bug#9296)
10087
5cf2b69b
KH
100882011-08-14 Kenichi Handa <handa@m17n.org>
10089
10090 * process.c (create_process): Call setup_process_coding_systems
72ad093b 10091 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 10092
daf17d00
EZ
100932011-08-14 Eli Zaretskii <eliz@gnu.org>
10094
10095 * xdisp.c (move_it_in_display_line_to): Don't invoke
10096 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
10097 ppos_it. Fixes vertical cursor motion when line beginning is
10098 covered by an image. (Bug#9296)
10099
08e3161a
JD
101002011-08-14 Jan Djärv <jan.h.d@swipnet.se>
10101
10102 * nsterm.h (ns_run_ascript): Declare.
10103 (NSAPP_DATA2_RUNASSCRIPT): Define.
10104
10105 * nsfns.m (as_script, as_result, as_status): New static variables.
10106 (ns_run_ascript): New function.
5e617bc2 10107 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
10108 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
10109 the event loop. Get status from as_status (Bug#7276).
10110
10111 * nsterm.m (sendEvent): If event is NSApplicationDefined and
10112 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
10113 the event loop (Bug#7276).
10114
a3720aa2
AS
101152011-08-14 Andreas Schwab <schwab@linux-m68k.org>
10116
10117 * gnutls.c (QCgnutls_bootprop_priority)
10118 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
10119 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
10120 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
10121 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
10122 (QCgnutls_bootprop_verify_hostname_error)
10123 (QCgnutls_bootprop_callbacks_verify): Rename from
10124 Qgnutls_bootprop_..., all uses changed.
10125
10126 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
10127 uses changed.
10128
0a0d27fb
PE
101292011-08-14 Paul Eggert <eggert@cs.ucla.edu>
10130
19d5c50c
PE
10131 * xfaces.c (Qframe_set_background_mode): Now static.
10132 * dispextern.h (Qframe_set_background_mode): Remove decl.
10133
0a0d27fb
PE
10134 * process.c (Fnetwork_interface_info): Declare local only if needed.
10135
377538cb
JD
101362011-08-13 Jan Djärv <jan.h.d@swipnet.se>
10137
10138 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
10139 (Fnetwork_interface_list): Allocate in increments of bytes instead
10140 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
10141 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
10142 sockaddr.
10143 (struct ifflag_def): notrailers is smart on OSX.
10144 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
10145 Get hardware address with getifaddrs if available.
10146
08fff70c
EZ
101472011-08-12 Eli Zaretskii <eliz@gnu.org>
10148
10149 * xdisp.c (iterate_out_of_display_property): xassert that
10150 IT->position is set to within IT->object's boundaries. Break from
10151 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
10152 when IT->position is set up wrongly due to some bug.
10153 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
10154 (push_display_prop): Allow GET_FROM_STRING as IT->method on
10155 entry. Force push_it to save on the stack the current
10156 buffer/string position, to be restored by pop_it. Fix flags in
10157 the iterator structure wrt the object coming from a display
10158 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
10159 properties. (Bug#9284)
10160
7be1c708 101612011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 10162
7be1c708
CY
10163 * fontset.c (fontset_get_font_group): Add proper type checks.
10164 (Bug#9172)
aac0c6e3 10165
7be1c708 101662011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 10167
7be1c708
CY
10168 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
10169 and LC_VERSION_MIN_MACOSX.
10170 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
10171 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 10172
97bb72a6
EZ
101732011-08-08 Eli Zaretskii <eliz@gnu.org>
10174
10175 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
10176 no-display-properties-and-no-overlays under bidi display.
10177 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 10178 properties and overlays.
97bb72a6 10179
d5617611
CY
101802011-08-08 Chong Yidong <cyd@stupidchicken.com>
10181
37e11a63
CY
10182 * editfns.c (Fset_time_zone_rule): Document relationship with the
10183 setenv function.
10184
d5617611
CY
10185 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
10186 the font entity extracted from the cache (Bug#8109).
10187
58872834
CY
101882011-08-07 Chong Yidong <cyd@stupidchicken.com>
10189
10190 * composite.c (autocmp_chars): Don't reset point. That is done by
10191 restore_point_unwind (Bug#5984).
10192
75bfc667
JL
101932011-08-07 Juri Linkov <juri@jurta.org>
10194
10195 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
10196 to show the arg `TIME' instead of `TIMEVAL'.
10197
d1410150
EZ
101982011-08-06 Eli Zaretskii <eliz@gnu.org>
10199
10200 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
10201 display property strides EOL and includes a newline, as in
10202 longlines-mode. (Bug#9254)
75b771e4
EZ
10203 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
10204 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
10205
10206 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
10207 is non-zero, even if the data buffer is NULL. Fixes a crash in
10208 vertical-motion with longlines-mode. (Bug#9254)
10209
35928349
EZ
102102011-08-05 Eli Zaretskii <eliz@gnu.org>
10211
ec7cc85b
EZ
10212 * bidi.c <bidi_cache_total_alloc>: Now static.
10213 (bidi_initialize): Initialize bidi_cache_total_alloc.
10214
8b76d6f8 10215 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
10216 cache. (Bug#9221)
10217
10218 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
10219 amount allocated this far in `bidi_cache_total_alloc'.
10220 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
10221 non-zero, only free the data buffer without restoring the cache
10222 contents. All callers changed.
10223
10224 * dispextern.h (bidi_unshelve_cache): Update prototype.
10225
10226 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
10227 (move_it_in_display_line, move_it_to)
10228 (move_it_vertically_backward, move_it_by_lines): Replace the call
10229 to xfree to an equivalent call to bidi_unshelve_cache.
10230 (move_it_in_display_line_to): Fix logic of returning
412b6358 10231 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 10232
e2e2423b
EZ
102332011-08-05 Eli Zaretskii <eliz@gnu.org>
10234
10235 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
10236 came from a string character with a `cursor' property. (Bug#9229)
10237
ae9e757a
JD
102382011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10239
10240 * Makefile.in (LIB_PTHREAD): New variable.
10241 (LIBES): Add LIB_PTHREAD (Bug#9216).
10242
10243 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
10244 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
10245
213bd7f2
AS
102462011-08-04 Andreas Schwab <schwab@linux-m68k.org>
10247
6b02f655 10248 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 10249
99aaf75f
JD
102502011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10251
10252 * xterm.c (x_find_topmost_parent): New function.
10253 (x_set_frame_alpha): Find topmost parent window with
10254 x_find_topmost_parent and set the property there also (bug#9181).
10255 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
10256
c74e9d86
PE
102572011-08-04 Paul Eggert <eggert@cs.ucla.edu>
10258
10259 * callproc.c (Fcall_process): Avoid vfork clobbering
10260 the local vars buffer, coding_systems, current_dir.
10261
640c8776
SM
102622011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
10263
10264 * keymap.c (Fmake_composed_keymap): Move to subr.el.
10265
f26d0e4c
PE
102662011-08-03 Paul Eggert <eggert@cs.ucla.edu>
10267
8a10d76c
PE
10268 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
10269 so that it is not optimized away.
10270
f26d0e4c
PE
10271 * xdisp.c (compute_display_string_pos): Remove unused local.
10272
55439c61
EZ
102732011-08-02 Eli Zaretskii <eliz@gnu.org>
10274
10275 Fix slow cursor motion and scrolling in large buffers with
10276 selective display, like Org Mode buffers. (Bug#9218)
10277
10278 * dispextern.h (struct bidi_it): New member disp_prop_p.
10279
10280 * xdisp.c: Remove one-slot cache of display string positions.
10281 (compute_display_string_pos): Accept an additional argument
5e617bc2 10282 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
10283 for a display string or property. If found, set DISP_PROP_P
10284 non-zero.
10285
10286 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
10287 DISP_PROP_P, and pass it to compute_display_string_pos.
10288 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
10289 non-zero. All callers of bidi_fetch_char changed.
10290
fb33fa43
SM
102912011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
10292
10293 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
10294
b099e063
DM
102952010-12-03 Don March <don@ohspite.net>
10296
10297 * keymap.c (Fdefine_key): Fix non-prefix key error message when
10298 last character M-[char] is translated to ESC [char] (bug#7541).
10299
5cc7f7af
KH
103002011-08-02 Kenichi Handa <handa@m17n.org>
10301
d0fffa3f 10302 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
10303
10304 * chartab.c (uniprop_table): Make it non-static.
10305
525d5e6e
EZ
103062011-08-01 Eli Zaretskii <eliz@gnu.org>
10307
10308 * xdisp.c (forward_to_next_line_start): Accept additional argument
10309 BIDI_IT_PREV, and store into it the state of the bidi iterator had
10310 on the newline.
10311 (reseat_at_next_visible_line_start): Use the bidi iterator state
10312 returned by forward_to_next_line_start to restore the state of
10313 it->bidi_it after backing up to previous newline. (Bug#9212)
10314
31011111
AS
103152011-07-30 Andreas Schwab <schwab@linux-m68k.org>
10316
10317 * regex.c (re_comp): Protoize.
10318 (re_exec): Fix return type.
10319 (regexec): Fix type of `ret'. (Bug#9203)
10320
476371c4
PE
103212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10322
e5d76069
PE
10323 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
10324 This is needed if max-image-size is a floating-point number.
10325
9a79b20c
AS
103262011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10327
10328 * print.c (print_object): Print empty symbol as ##.
10329
10330 * lread.c (read1): Read ## as empty symbol.
10331
d8c2fa78
AA
103322011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
10333
10334 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10335 setting frame foreground color (Bug#9175).
10336 (x_set_background_color): Likewise.
10337
ffe57a7a
AA
10338 * nsmenu.m (-setText): Size tooltip dimensions precisely to
10339 contents (Bug#9176).
10340 (EmacsTooltip -init): Remove bezels and add shadows to
10341 tooltip windows.
10342
bf3492a5
AA
10343 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
10344 or scroll bar (Bug#8470).
10345
d55e9c53
AA
10346 * nsfont.m (nsfont_open): Remove assignment to voffset and
10347 unnecessary vars hshink, expand, hd, full_height, min_height.
10348 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
10349
10350 * nsterm.h (nsfont_info): Remove voffset field.
10351
d8c2fa78 103522011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
10353
10354 Implement strike-through and overline on NextStep (Bug#8863).
10355
10356 * nsfont.m (nsfont_open): Use underline position provided by font,
10357 instead of hard-coded value of 2.
10358 (nsfont_draw): Call ns_draw_text_decoration instead.
10359
10360 * nsterm.h: Add declaration for ns_draw_text_decoration.
10361
10362 * nsterm.m (ns_draw_text_decoration): New function for drawing
10363 underline, overline, and strike-through.
10364 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
10365 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 10366 accommodate underlining, etc.
4843aac3 10367
4cc60b9b
EZ
103682011-07-28 Eli Zaretskii <eliz@gnu.org>
10369
bc7ece87
EZ
10370 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
10371 default.
4cc60b9b 10372
476371c4
PE
103732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10374
66606eea
PE
10375 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
10376 Without this fix, if a signal arrives just after memory fills up,
10377 'malloc' might be invoked reentrantly.
10378
476371c4
PE
10379 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
10380 In other words, assume that every image size is allowed, on non-X
10381 hosts. This assumption is probably wrong, but it lets Emacs compile.
10382
f3fcc40d
AS
103832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10384
10385 * regex.c (re_iswctype): Convert return values to boolean.
10386
350c992f
EZ
103872011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
10388
10389 * xdisp.c (compute_display_string_pos): Don't use cached display
10390 string position if the buffer had its restriction changed.
10391 (Bug#9184)
10392
5266b4bb
PE
103932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10394
10395 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10396
2573a837 103972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 10398
41f55ccd 10399 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 10400
39e378da
PE
10401 * bidi.c: Integer size and overflow fixes.
10402 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
10403 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
10404 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10405 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
10406 (bidi_find_other_level_edge):
10407 Use ptrdiff_t instead of EMACS_INT where either will do.
10408 This works better on 32-bit hosts configured --with-wide-int.
10409 (bidi_cache_ensure_space): Check for size-calculation overflow.
10410 Use % rather than repeated addition, for better worst-case speed.
10411 Don't set bidi_cache_size until after xrealloc returns, because it
10412 might not return.
10413 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
10414 (bidi_cache_ensure_space): Also check that the bidi cache size
10415 does not exceed that of the largest Lisp string or buffer. See Eli
10416 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 10417
5e927815
PE
10418 * alloc.c (__malloc_size_t): Remove.
10419 All uses replaced by size_t. See Andreas Schwab's note
10420 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
10421
ca4aa935
PE
10422 * image.c: Improve checking for integer overflow.
10423 (check_image_size): Assume that f is nonnull, since
10424 it is always nonnull in practice. This is one less thing to
10425 worry about when checking for integer overflow later.
10426 (x_check_image_size): New function, which checks for integer
10427 overflow issues inside X.
10428 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
10429 This removes the need for a memory_full check.
10430 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
10431 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
10432 (xbm_read_bitmap_data): Change locals back to 'int', since
10433 their values must fit in 'int'.
10434 (xpm_load_image, png_load, tiff_load):
10435 Invoke x_create_x_image_and_pixmap earlier,
10436 to avoid much needless work if the image is too large.
10437 (tiff_load): Treat overly large images as if
10438 x_create_x_image_and_pixmap failed, not as malloc failures.
10439 (gs_load): Use x_check_image_size.
10440
5f8f9cc2
PE
10441 * gtkutil.c: Omit integer casts.
10442 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
10443 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
10444
5adf60bc
PE
10445 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
10446
c8907a93
PE
10447 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
10448 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
10449 would wrongly return t on a 64-bit host.
10450
e3c25c68
PE
10451 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
10452 The plain *_OVERFLOW macros run afoul of GCC bug 49705
10453 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
10454 and therefore cause GCC to emit a bogus diagnostic in some cases.
10455
3f791afe
PE
10456 * image.c: Integer signedness and overflow and related fixes.
10457 This is not an exhaustive set of fixes, but it's time to
10458 record what I've got.
10459 (lookup_pixel_color, check_image_size): Remove redundant decls.
10460 (check_image_size): Don't assume that arbitrary EMACS_INT values
10461 fit in 'int', or that arbitrary 'double' values fit in 'int'.
10462 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
10463 (tiff_load, imagemagick_load_image):
10464 Check for overflow in size calculations.
10465 (x_create_x_image_and_pixmap): Remove unnecessary test for
10466 xmalloc returning NULL; that can't happen.
10467 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
10468 (xpm_color_bucket): Use better integer hashing function.
10469 (xpm_cache_color): Don't possibly over-allocate memory.
10470 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
10471 (gif_memory_source):
10472 Use ptrdiff_t, not int or size_t, to record sizes.
10473 (png_load): Don't assume values greater than 2**31 fit in 'int'.
10474 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
10475 either works, as we prefer signed integers.
10476 (tiff_read_from_memory, tiff_write_from_memory):
10477 Return tsize_t, not size_t, since that's what the TIFF API wants.
10478 (tiff_read_from_memory): Don't fail simply because the read would
10479 go past EOF; instead, return a short read.
10480 (tiff_load): Omit no-longer-needed casts.
10481 (Fimagemagick_types): Don't assume size fits into 'int'.
10482
3cc5a532
PE
10483 Improve hashing quality when configured --with-wide-int.
10484 * fns.c (hash_string): New function, taken from sxhash_string.
10485 Do not discard information about ASCII character case; this
10486 discarding is no longer needed.
10487 (sxhash-string): Use it. Change sig to match it. Caller changed.
10488 * lisp.h: Declare it.
10489 * lread.c (hash_string): Remove, since we now use fns.c's version.
10490 The fns.c version returns a wider integer if --with-wide-int is
10491 specified, so this should help the quality of the hashing a bit.
10492
b312a492
PE
10493 * emacs.c: Integer overflow minor fix.
10494 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
10495 Define only if GNU_LINUX.
10496 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
10497
dfd153ae
PE
10498 * dispnew.c: Integer signedness and overflow fixes.
10499 Remove unnecessary forward decls, that were a maintenance hassle.
10500 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
10501 All uses changed.
10502 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
10503 (scrolling_window): Use ptrdiff_t, not int, for byte count.
10504 (prepare_desired_row, line_draw_cost):
10505 Use int, not unsigned, where either works.
10506 (save_current_matrix, restore_current_matrix):
10507 Use ptrdiff_t, not size_t, where either works.
10508 (init_display): Check for overflow more accurately, and without
10509 relying on undefined behavior.
10510
a81d11a3
PE
10511 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
10512 Remove, replacing with the new symbols in lisp.h. All uses changed.
10513 * fileio.c (make_temp_name):
10514 * filelock.c (lock_file_1, lock_file):
10515 * xdisp.c (message_dolog):
10516 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
10517 Use pMd etc. instead.
10518 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
10519 replacing the pWIDE etc. symbols removed from editfns.c.
10520
3300e6fd
PE
10521 * keyboard.h (num_input_events): Now uintmax_t.
10522 This is (very slightly) less likely to mess up due to wraparound.
10523 All uses changed.
10524
fd05c7e9
PE
10525 * buffer.c: Integer signedness fixes.
10526 (alloc_buffer_text, enlarge_buffer_text):
10527 Use ptrdiff_t rather than size_t when either will do, as we prefer
10528 signed integers.
10529
903fe15d
PE
10530 * alloc.c: Integer signedness and overflow fixes.
10531 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
10532 (__malloc_size_t): Default to size_t, not to int.
10533 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
10534 (Fgarbage_collect, mark_object_loop_halt, mark_object):
10535 Prefer ptrdiff_t to size_t when either would do, as we prefer
10536 signed integers.
10537 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
10538 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
10539 Now const. Initialize with values that are in range even if char
10540 is signed.
10541 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
10542 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
10543 These functions do the right thing with sizes > 2**32.
10544 (check_depth): Now ptrdiff_t, not int.
10545 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
10546 Adjust to new way of storing sizes. Check for size overflow bugs
10547 in rest of code.
10548 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
10549 slightly wrong anyway, as it missed one instance of
10550 XMALLOC_OVERRUN_CHECK_OVERHEAD.
10551 (refill_memory_reserve): Omit needless cast to size_t.
10552 (mark_object_loop_halt): Mark as externally visible.
10553
ac82cc6a
PE
10554 * xselect.c: Integer signedness and overflow fixes.
10555 (Fx_register_dnd_atom, x_handle_dnd_message):
10556 Use ptrdiff_t, not size_t, since we prefer signed.
10557 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
10558 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
10559 x_dnd_atoms_size and x_dnd_atoms_length.
10560
c2d1e36d
PE
10561 * doprnt.c: Prefer signed to unsigned when either works.
10562 * eval.c (verror):
10563 * doprnt.c (doprnt):
10564 * lisp.h (doprnt):
10565 * xdisp.c (vmessage):
10566 Use ptrdiff_t, not size_t, when using or implementing doprnt,
10567 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
10568 prefer signed arithmetic to avoid comparison confusion.
10569 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
10570 but is a bit tricky.
10571
0e926e56
PE
10572 Assume freestanding C89 headers, string.h, stdlib.h.
10573 * data.c, doprnt.c, floatfns.c, print.c:
10574 Include float.h unconditionally.
10575 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
10576 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
10577 * regex.c: Likewise for stddef.h, string.h.
10578 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
10579 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
10580 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
10581 (STDC_HEADERS): Remove obsolete defines.
10582 * sysdep.c: Include limits.h unconditionally.
10583
9cfdb3ec
PE
10584 Assume support for memcmp, memcpy, memmove, memset.
10585 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
10586 * regex.c (memcmp, memcpy):
10587 Remove; we assume C89 now.
10588
10589 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
10590 (__malloc_safe_bcopy): Remove; no longer needed.
10591
cf950e6b 10592 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
10593 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
10594 well either way, and we prefer signed to unsigned.
10595
dbf38e02
LMI
105962011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
10597
10598 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
10599 closes the connection while we're reading (bug#9182).
10600
d6f0886c 106012011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 10602
d6f0886c
JD
10603 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
10604 are specified (Bug#9168).
24e0f6b1 10605
2eb1f9e6
PE
106062011-07-25 Paul Eggert <eggert@cs.ucla.edu>
10607
10608 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
10609 Found by GCC static checking and --with-wide-int on a 32-bit host.
10610
22381272 106112011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
10612
10613 * xdisp.c (compute_display_string_pos): Fix logic of caching
10614 previous display string position. Initialize cached_prev_pos to
10615 -1. Fixes slow-down at the beginning of a buffer.
10616
f25e39b4
EZ
106172011-07-24 Eli Zaretskii <eliz@gnu.org>
10618
10619 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
10620 for attrs[LFACE_FONTSET_INDEX].
10621
04c4b52e
PE
106222011-07-23 Paul Eggert <eggert@cs.ucla.edu>
10623
10624 * xml.c (parse_region): Remove unused local
10625 that was recently introduced.
10626
c1734fbd
EZ
106272011-07-23 Eli Zaretskii <eliz@gnu.org>
10628
be18c5a5
EZ
10629 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
10630 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
10631
c1734fbd
EZ
10632 * xdisp.c (move_it_in_display_line_to): Record the best matching
10633 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
10634 exit if none of the characters scanned was an exact match.
10635 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
10636 when exact match is impossible due to invisible text, and the
10637 lines are truncated.
10638
a258d627
JD
106392011-07-23 Jan Djärv <jan.h.d@swipnet.se>
10640
10641 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
10642 for OSX >= 10.7.
10643
b6d5a689
EZ
106442011-07-22 Eli Zaretskii <eliz@gnu.org>
10645
0f74f785
EZ
10646 Fix a significant slow-down of cursor motion with C-n, C-p,
10647 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
10648 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 10649 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
10650 (next_element_from_buffer): Call compute_stop_pos_backwards to
10651 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
10652 base_level_stop.
10653 (reseat): Don't look for prev_stop, as that could mean a very long
10654 run.
10655 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
10656 <cached_disp_overlay_modiff>: Cache for last found display string
10657 position.
551918c1 10658 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
10659 about the same buffer in the same area of character positions, and
10660 the buffer wasn't changed since the time the display string
10661 position was cached.
551918c1 10662
b2d0c91a
EZ
106632011-07-22 Eli Zaretskii <eliz@gnu.org>
10664
10665 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
10666 is an integer, which is important for empty lines. (Bug#9149)
10667
043604ee
CY
106682011-07-22 Chong Yidong <cyd@stupidchicken.com>
10669
10670 * frame.c (Fmodify_frame_parameters): In tty case, update the
10671 default face if necessary (Bug#4238).
10672
da4adb04
CY
106732011-07-21 Chong Yidong <cyd@stupidchicken.com>
10674
10675 * editfns.c (Fstring_to_char): No need to explain what a character
10676 is in the docstring (Bug#6576).
10677
9abd0532
LMI
106782011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10679
10680 * xml.c (parse_region): Make sure we always return a tree.
10681
36881d16
HK
106822011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
10683
10684 * xml.c (parse_region): If a document contains only comments,
10685 return that, too.
10686
1e98674d
LMI
106872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10688
10689 * xml.c (make_dom): Return comments, too.
10690
590bd467
PE
106912011-07-19 Paul Eggert <eggert@cs.ucla.edu>
10692
10693 Port to OpenBSD.
10694 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
10695 and the surrounding thread.
10696 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
10697 rather than fgets, and retry after EINTR. Otherwise, 'emacs
10698 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
10699 timer goes off.
10700 * s/openbsd.h (BROKEN_SIGIO): Define.
10701 * unexelf.c (unexec) [__OpenBSD__]:
10702 Don't update the .mdebug section of the Alpha COFF symbol table.
10703
f41628b2
LMI
107042011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10705
10706 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
10707 (bug#8460).
10708
b59b67c5
PE
107092011-07-18 Paul Eggert <eggert@cs.ucla.edu>
10710
15e3a074
PE
10711 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
10712 This fixes some race conditions on the permissions of any newly
10713 created file.
10714
41bed37d
PE
10715 * alloc.c (valid_pointer_p): Use pipe, not open.
10716 This fixes some permissions issues when debugging.
10717
b59b67c5
PE
10718 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
10719 If fchown fails to set both uid and gid, try to set just gid,
10720 as that is sometimes allowed. Adjust the file's mode to eliminate
10721 setuid or setgid bits that are inappropriate if fchown fails.
10722
925a6be7
SM
107232011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
10724
10725 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
10726 to compare Lisp_Objects.
10727 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
10728 global_gnutls_log_level, don't mistake it for a Lisp_Object.
10729 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
10730
52968808
AS
107312011-07-17 Andreas Schwab <schwab@linux-m68k.org>
10732
0a6a104b
AS
10733 * lread.c (read_integer): Unread even EOF character.
10734 (read1): Likewise. Properly record start position of symbol.
10735
52968808
AS
10736 * lread.c (read1): Read `#:' as empty uninterned symbol if no
10737 symbol character follows.
10738
9e381cdd
PE
107392011-07-17 Paul Eggert <eggert@cs.ucla.edu>
10740
10741 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
10742 This works around a problem with the previous change to Fcopy_file.
10743 Recent glibc declares fchown with __attribute__((warn_unused_result)),
10744 and without this change, GCC might complain about discarding
10745 fchown's return value.
10746
b5641435
JB
107472011-07-16 Juanma Barranquero <lekktu@gmail.com>
10748
10749 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
10750
a8031457
PE
107512011-07-16 Paul Eggert <eggert@cs.ucla.edu>
10752
10753 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
10754
dd889327
LMI
107552011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
10756
750c33f7
LMI
10757 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
10758 it's used from the C level.
10759
dd889327
LMI
10760 * process.c: Use the same condition for POLL_FOR_INPUT in both
10761 keyboard.c and process.c (bug#1858).
10762
87e86684
LM
107632011-07-09 Lawrence Mitchell <wence@gmx.li>
10764
10765 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
10766 (Fgnutls_boot): Use it.
10767
64348f40
AS
107682011-07-15 Andreas Schwab <schwab@linux-m68k.org>
10769
10770 * doc.c (Fsubstitute_command_keys): Revert last change.
10771
1d698799
LMI
107722011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
10773
f863868c
LMI
10774 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
10775 quotes the next character, and doesn't affect other longer
10776 sequences (bug#8935).
10777
1d698799
LMI
10778 * lread.c (syms_of_lread): Clarify that is isn't only
10779 `eval-buffer' and `eval-defun' that's affected by
10780 `lexical-binding' (bug#8460).
10781
aa4b6df6
EZ
107822011-07-15 Eli Zaretskii <eliz@gnu.org>
10783
10784 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 10785 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 10786
5d856da6
PE
107872011-07-14 Paul Eggert <eggert@cs.ucla.edu>
10788
ad6042bb
PE
10789 Fix minor problems found by static checking.
10790 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
10791 (elsz): Now a signed constant, not a size_t var. We prefer signed
10792 types to unsigned, to avoid integer comparison confusion. Without
10793 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
10794 "cannot optimize loop, the loop counter may overflow", a symptom
10795 of the confusion.
f00bbb22 10796 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
10797 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
10798
6468f31c
LMI
107992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10800
49080b10
LMI
10801 * search.c (Fre_search_backward): Mention `case-fold-search' in
10802 all the re_search_* functions (bug#8138).
10803
6468f31c
LMI
10804 * keyboard.c (Fopen_dribble_file): Document when the file is
10805 closed (bug#8056).
10806
c965adc5
EZ
108072011-07-14 Eli Zaretskii <eliz@gnu.org>
10808
df9733bf
EZ
10809 * bidi.c (bidi_dump_cached_states): Fix format of displaying
10810 bidi_cache_idx.
10811
0bb23927
EZ
10812 Support bidi reordering of display and overlay strings.
10813 * xdisp.c (compute_display_string_pos)
10814 (compute_display_string_end): Accept additional argument STRING.
10815 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
10816 (reseat_to_string): Initialize bidi_it->string.s and
10817 bidi_it->string.schars.
10818 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
10819 NULL (avoids a crash in bidi_paragraph_init).
10820 Initialize itb.string.lstring.
0bb23927
EZ
10821 (init_iterator): Call bidi_init_it only of a valid
10822 buffer position was specified. Initialize paragraph_embedding to
10823 L2R.
10824 (reseat_to_string): Initialize the bidi iterator.
10825 (display_string): If we need to ignore text properties of
10826 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
10827 original value of -1 will not work with bidi.)
10828 (compute_display_string_pos): First arg is now struct
10829 `text_pos *'; all callers changed. Support display properties on
10830 Lisp strings.
10831 (compute_display_string_end): Support display properties on Lisp
10832 strings.
10833 (init_iterator, reseat_1, reseat_to_string): Initialize the
10834 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
10835 when iterating on a string not from display properties).
640c8776
SM
10836 (compute_display_string_pos, compute_display_string_end):
10837 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
10838 arrow keys.
10839 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
10840 base_level_stop; instead, set base_level_stop to BEGV.
10841 Fixes crashes in vertical-motion.
0bb23927
EZ
10842 (next_element_from_buffer): Improve commentary for when
10843 the iterator is before prev_stop.
10844 (init_iterator): Initialize bidi_p from the default value of
10845 bidi-display-reordering, not from buffer-local value. Use the
10846 buffer-local value only if initializing for buffer iteration.
10847 (handle_invisible_prop): Support invisible properties on strings
10848 that are being bidi-reordered.
10849 (set_iterator_to_next): Support bidi reordering of C strings and
10850 Lisp strings.
10851 (next_element_from_string): Support bidi reordering of Lisp
10852 strings.
10853 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
10854 (display_string): Support display of R2L glyph rows.
10855 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
10856 (init_iterator): Don't initialize it->bidi_p for strings
10857 here.
10858 (reseat_to_string): Initialize it->bidi_p for strings here.
10859 (next_element_from_string, next_element_from_c_string)
10860 (next_element_from_buffer): Add xassert's for correspondence
10861 between IT's object being iterated and it->bidi_it.string
10862 structure.
10863 (face_before_or_after_it_pos): Support bidi iteration.
10864 (next_element_from_c_string): Handle the case of the first string
10865 character that is not the first one in the visual order.
10866 (get_visually_first_element): New function, refactored from common
10867 parts of next_element_from_buffer, next_element_from_string, and
10868 next_element_from_c_string.
10869 (tool_bar_lines_needed, redisplay_tool_bar)
10870 (display_menu_bar): Force left-to-right direction. Add a FIXME
10871 comment for making that be controlled by a user option.
10872 (push_it, pop_it): Save and restore the state of the
10873 bidi iterator. Save and restore the bidi_p flag.
10874 (pop_it): Iterate out of display property for string iteration as
10875 well.
10876 (iterate_out_of_display_property): Support iteration over strings.
10877 (handle_single_display_spec): Set up it->bidi_it for iteration
10878 over a display string, and call bidi_init_it.
10879 (handle_single_display_spec, next_overlay_string)
10880 (get_overlay_strings_1, push_display_prop): Set up the bidi
10881 iterator for displaying display or overlay strings.
10882 (forward_to_next_line_start): Don't use the shortcut if
10883 bidi-iterating.
10884 (back_to_previous_visible_line_start): If handle_display_prop
10885 pushed the iterator stack, restore the internal state of the bidi
10886 iterator by calling bidi_pop_it same number of times.
10887 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
10888 and we are bidi-iterating, don't decrement the iterator position;
10889 instead, set the first_elt flag in the bidi iterator, to produce
10890 the same effect.
10891 (reseat_1): Remove redundant setting of string_from_display_prop_p.
10892 (push_display_prop): xassert that we are iterating a buffer.
10893 (push_it, pop_it): Save and restore paragraph_embedding member.
10894 (handle_single_display_spec, next_overlay_string)
10895 (get_overlay_strings_1, reseat_1, reseat_to_string)
10896 (push_display_prop): Set up the `unibyte' member of bidi_it.string
10897 correctly. Don't assume unibyte strings are not bidi-reordered.
10898 (compute_display_string_pos)
10899 (compute_display_string_end): Fix handling the case of C string.
10900 (push_it, pop_it): Save and restore from_disp_prop_p.
10901 (handle_single_display_spec, push_display_prop): Set the
10902 from_disp_prop_p flag.
10903 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
10904 (pop_it): Call iterate_out_of_display_property only if we are
10905 popping after iteration over a string that came from a display
10906 property. Fix a typo in popping stretch info. Add an assertion
10907 for verifying that the iterator position is in sync with the bidi
10908 iterator.
10909 (handle_single_display_spec, get_overlay_strings_1)
10910 (push_display_prop): Fix initialization of paragraph direction for
10911 string when that of the parent object is not yet determined.
10912 (reseat_1): Call bidi_init_it to resync the bidi
10913 iterator with IT's position. (Bug#7616)
10914 (find_row_edges): If ROW->start.pos gives position
10915 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
10916 (handle_stop, back_to_previous_visible_line_start, reseat_1):
10917 Reset the from_disp_prop_p flag.
10918 (SAVE_IT, RESTORE_IT): New macros.
10919 (pos_visible_p, face_before_or_after_it_pos)
10920 (back_to_previous_visible_line_start)
10921 (move_it_in_display_line_to, move_it_in_display_line)
10922 (move_it_to, move_it_vertically_backward, move_it_by_lines)
10923 (try_scrolling, redisplay_window, display_line): Use them when
10924 saving a temporary copy of the iterator and restoring it back.
10925 (back_to_previous_visible_line_start, reseat_1)
10926 (init_iterator): Empty the bidi cache "stack".
10927 (move_it_in_display_line_to): If iterator ended up at
10928 EOL, but we never saw any buffer positions smaller than
10929 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
10930 motion in bidi-reordered lines.
10931 (move_it_in_display_line_to): Record prev_method and prev_pos
10932 immediately before the call to set_iterator_to_next. Fixes cursor
10933 motion in bidi-reordered lines with stretch glyphs and strings
10934 displayed in margins. (Bug#8133) (Bug#8867)
10935 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
10936 TO_CHARPOS.
640c8776
SM
10937 (pos_visible_p): Support positions in bidi-reordered lines.
10938 Save and restore bidi cache.
0bb23927
EZ
10939
10940 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
10941 (bidi_paragraph_info): Delete unused struct.
10942 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
10943 (bidi_cache_start): New variable.
10944 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
10945 to zero.
10946 (bidi_cache_fetch_state, bidi_cache_search)
10947 (bidi_cache_find_level_change, bidi_cache_iterator_state)
10948 (bidi_cache_find, bidi_peek_at_next_level)
10949 (bidi_level_of_next_char, bidi_find_other_level_edge)
10950 (bidi_move_to_visually_next): Compare cache index with
10951 bidi_cache_start rather than with zero.
10952 (bidi_fetch_char): Accept new argument STRING; all callers
10953 changed. Support iteration over a string. Support strings with
10954 display properties. Support unibyte strings. Fix the type of
10955 `len' according to what STRING_CHAR_AND_LENGTH expects.
10956 (bidi_paragraph_init, bidi_resolve_explicit_1)
10957 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
10958 (bidi_level_of_next_char, bidi_move_to_visually_next):
10959 Support iteration over a string.
0bb23927
EZ
10960 (bidi_set_sor_type, bidi_resolve_explicit_1)
10961 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
10962 can now be zero (for strings); special values 0 and -1 were
10963 changed to -1 and -2, respectively.
10964 (bidi_char_at_pos): New function.
10965 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
10966 Call it instead of FETCH_MULTIBYTE_CHAR.
10967 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
10968 initialized to valid values.
10969 (bidi_init_it): Don't initialize charpos and bytepos with invalid
10970 values.
10971 (bidi_level_of_next_char): Allow the sentinel "position" to pass
10972 the test for valid cached positions. Fix the logic for looking up
10973 the sentinel state in the cache. GCPRO the Lisp string we are
10974 iterating.
10975 (bidi_push_it, bidi_pop_it): New functions.
10976 (bidi_initialize): Initialize the bidi cache start stack pointer.
10977 (bidi_cache_ensure_space): New function, refactored from part of
10978 bidi_cache_iterator_state. Don't assume the required size is just
10979 one BIDI_CACHE_CHUNK away.
10980 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
10981 (bidi_count_bytes, bidi_char_at_pos): New functions.
10982 (bidi_cache_search): Don't assume bidi_cache_last_idx is
10983 always valid if bidi_cache_idx is valid.
10984 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
10985 is valid if it's going to be used.
10986 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
10987 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
10988 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10989 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
10990 (bidi_find_other_level_edge, bidi_cache_start_stack):
10991 All variables related to cache indices are now EMACS_INT.
c965adc5 10992
0bb23927
EZ
10993 * dispextern.h (struct bidi_string_data): New structure.
10994 (struct bidi_it): New member `string'. Make flag members be 1-bit
10995 fields, and put them last in the struct.
640c8776
SM
10996 (compute_display_string_pos, compute_display_string_end):
10997 Update prototypes.
0bb23927
EZ
10998 (bidi_push_it, bidi_pop_it): Add prototypes.
10999 (struct iterator_stack_entry): New members bidi_p,
11000 paragraph_embedding, and from_disp_prop_p.
11001 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
11002 (bidi_shelve_cache, bidi_unshelve_cache):
11003 Declare prototypes.
0bb23927
EZ
11004
11005 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
11006 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
11007 and vector-like objects.
11008
11009 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
11010 cache around display iteration.
11011
11012 * window.c (Fwindow_end, window_scroll_pixel_based)
11013 (displayed_window_lines, Frecenter): Save and restore the bidi
11014 cache around display iteration.
11015
3bbd2265
LMI
110162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11017
11018 * editfns.c (Fdelete_region): Clarify the use of the named
11019 parameters (bug#6788).
11020
adc47434
MR
110212011-07-14 Martin Rudalics <rudalics@gmx.at>
11022
11023 * indent.c (Fvertical_motion): Set and restore w->pointm when
11024 saving and restoring the window's buffer (Bug#9006).
11025
837c31f8
LMI
110262011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
11027
11028 * editfns.c (Fstring_to_char): Clarify just what is returned
11029 (bug#6576). Text by Eli Zaretskii.
11030
ac389d0c
JB
110312011-07-13 Juanma Barranquero <lekktu@gmail.com>
11032
11033 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
11034
0be0ce47
EZ
110352011-07-13 Eli Zaretskii <eliz@gnu.org>
11036
11037 * buffer.c (mmap_find): Fix a typo.
11038
cd18e7e3
JB
110392011-07-13 Johan Bockgård <bojohan@gnu.org>
11040
11041 Fix execution of x selection hooks.
11042 * xselect.c (Qx_lost_selection_functions)
11043 (Qx_sent_selection_functions): New vars.
11044 (syms_of_xselect): DEFSYM them.
11045 (x_handle_selection_request): Pass Qx_sent_selection_functions
11046 rather than Vx_sent_selection_functions to Frun_hook_with_args.
11047 (x_handle_selection_clear,x_clear_frame_selections):
11048 Pass Qx_lost_selection_functions rather than
11049 Vx_lost_selection_functions to Frun_hook_with_args.
11050
47ea7f44
PE
110512011-07-13 Paul Eggert <eggert@cs.ucla.edu>
11052
ac389d0c 11053 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
11054 The old code sometimes used this field without initializing it.
11055
47ea7f44
PE
11056 * alloc.c (gc_sweep): Don't read past end of array.
11057 In theory, the old code could also have corrupted Emacs internals,
11058 though it'd be very unlikely.
11059
bc985c87
AS
110602011-07-12 Andreas Schwab <schwab@linux-m68k.org>
11061
11062 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 11063 argument. (Bug#4026)
bc985c87 11064
0cf34688
LMI
110652011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
11066
b3dadd76
LMI
11067 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
11068 key" (bug#4257).
11069
0cf34688
LMI
11070 * window.c (Fset_window_start): Doc fix (bug#4199).
11071 (Fset_window_hscroll): Ditto.
11072
270768cd
PE
110732011-07-12 Paul Eggert <eggert@cs.ucla.edu>
11074
077e3dda 11075 Fix minor new problems caught by GCC 4.6.1.
270768cd 11076 * term.c (init_tty): Remove unused local.
490011a6 11077 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 11078 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 11079 not used otherwise.
270768cd 11080
b1f58454
CY
110812011-07-12 Chong Yidong <cyd@stupidchicken.com>
11082
11083 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
11084
22b9578d
LMI
110852011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11086
6e70ab07
LMI
11087 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
11088 are the mini-buffer and the echo area (bug#3320).
11089
22b9578d
LMI
11090 * term.c (init_tty): Remove support for supdup, c10 and perq
11091 terminals, which are no longer supported (bug#1482).
11092
8974cc9f
JB
110932011-07-10 Johan Bockgård <bojohan@gnu.org>
11094
11095 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
11096
a560d974
JD
110972011-07-10 Jan Djärv <jan.h.d@swipnet.se>
11098
11099 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
11100 for non-popups (Bug#3642).
11101
1dae0f0a
AS
111022011-07-10 Andreas Schwab <schwab@linux-m68k.org>
11103
268c2c36 11104 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 11105 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
11106 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
11107 * cm.c (losecursor): Likewise.
1dae0f0a
AS
11108 * data.c (fmod): Likewise.
11109 * dispnew.c (swap_glyphs_in_rows): Likewise.
11110 * emacs.c (memory_warning_signal): Likewise.
11111 * floatfns.c (float_error): Likewise.
11112 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
11113 (otf_open, font_otf_capability, generate_otf_features)
11114 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
11115 Likewise.
11116 * image.c (pbm_read_file): Likewise.
11117 * indent.c (string_display_width): Likewise.
11118 * intervals.c (check_for_interval, search_for_interval)
11119 (inc_interval_count, count_intervals, root_interval)
11120 (adjust_intervals_for_insertion, make_new_interval): Likewise.
11121 * lread.c (defalias): Likewise.
268c2c36 11122 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
11123 * regex.c (set_image_of_range_1, set_image_of_range)
11124 (regex_grow_registers): Likewise.
11125 * sysdep.c (strerror): Likewise.
11126 * termcap.c (valid_filename_p, tprint, main): Likewise.
11127 * tparam.c (main): Likewise.
11128 * unexhp9k800.c (run_time_remap, save_data_space)
11129 (update_file_ptrs, read_header, write_header, calculate_checksum)
11130 (copy_file, copy_rest, display_header): Likewise.
11131 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
11132 Likewise.
11133 * xdisp.c (check_it): Likewise.
11134 * xfaces.c (register_color, unregister_color, unregister_colors):
11135 Likewise.
11136 * xfns.c (print_fontset_result): Likewise.
11137 * xrdb.c (member, fatal, main): Likewise.
11138
99033785
PE
111392011-07-10 Paul Eggert <eggert@cs.ucla.edu>
11140
11141 Fix minor problems found by static checking (Bug#9031).
11142 * chartab.c (char_table_set_range, map_sub_char_table):
11143 Remove unused locals.
11144 (uniprop_table): Now static.
11145 * composite.c (_work_char): Remove unused static var.
11146
9cb2ac56
JB
111472011-07-09 Juanma Barranquero <lekktu@gmail.com>
11148
11149 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
11150
f25661f0
JD
111512011-07-09 Jan Djärv <jan.h.d@swipnet.se>
11152
11153 * gtkutil.c (qttip_cb): Remove code without function.
11154
8278c4fe
EZ
111552011-07-09 Eli Zaretskii <eliz@gnu.org>
11156
11157 * w32.c (pthread_sigmask): New stub.
11158
1692ae2d 111592011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 11160
8a6ebd58 11161 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
11162 sigprocmask is portable only for single-threaded applications, and
11163 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
11164 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
11165 (LIBES): Use it.
11166 * callproc.c (Fcall_process):
11167 * process.c (create_process):
11168 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
11169 Use pthread_sigmask, not sigprocmask.
123403e4 11170
1b854618
JD
111712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11172
11173 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
11174 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
11175 wrong (Bug#8591).
11176
3fe4b549
JD
111772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11178
0ce7e563
JD
11179 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
11180 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
11181 (xg_hide_tooltip): Fix comment.
11182
3fe4b549
JD
11183 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
11184 in registerServicesMenuSendTypes.
11185 (validRequestorForSendType): Don't check ns_return_types.
11186
11187 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
11188 ns_return_type.
11189
5df75e47
JR
111902011-07-08 Jason Rumney <jasonr@gnu.org>
11191
22610910
JR
11192 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
11193 SH_SHOW for hidden windows (Bug#5482).
11194
5df75e47
JR
11195 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
11196 frame struct members of non-existent frames (Bug#6284).
11197
699c10bd
JD
111982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11199
4393663b
JD
11200 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
11201 variable firstTime not needed on OSX >= 10.6.
11202 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
11203 >= 10.5. Use setKnobProportion, setDoubleValue.
11204
11205 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
11206 (MAC_OS_X_VERSION_10_5): Define if not defined.
11207 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
11208 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
11209 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
11210
11211 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 11212 cString and lossyCString on OSX >= 10.4.
4393663b 11213
58179cce 11214 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
11215 sizeToFit on OSX >= 10.2.
11216
11217 * nsimage.m (allocInitFromFile): Don't use deprecated method
11218 bestRepresentationForDevice on OSX >= 10.6.
11219
11220 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
11221 to avoid warning.
11222
11223 * emacs.c: Declare unexec_init_emacs_zone.
11224
a63e0781
JD
11225 * nsgui.h: Fix compiler warning about gnulib redefining verify.
11226
699c10bd
JD
11227 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
11228
11229 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
11230 on svcsMenu (Bug#8842).
11231
11232 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
11233 ns_return_types.
11234 (Fns_list_services): Just return Qnil on 10.6, code not working there.
11235
11236 * nsterm.m (QUTF8_STRING): Declare.
11237 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
11238 (validRequestorForSendType): Return type is (id).
11239 Change indexOfObjectIdenticalTo to indexOfObject.
11240 Check if we have local selection before returning self (Bug#8842).
11241 (writeSelectionToPasteboard): Put local selection into paste board
11242 if we have a local selection (Bug#8842).
11243 (syms_of_nsterm): DEFSYM QUTF8_STRING.
11244
11245 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
11246 (ns_get_local_selection): Declare.
11247
54e10184
LMI
112482011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
11249
9888ff71
LMI
11250 * keymap.c (describe_map_tree): Don't insert a double newline at
11251 the end of the buffer (bug#1169) and return whether we inserted
11252 something.
11253
54e10184
LMI
11254 * callint.c (Fcall_interactively): Change "reading args" to
11255 "providing args" to try to clarify what it does (bug#1010).
11256
15fa4783
KH
112572011-07-07 Kenichi Handa <handa@m17n.org>
11258
11259 * composite.c (composition_compute_stop_pos): Ignore a static
11260 composition starting before CHARPOS (Bug#8915).
11261
11262 * xdisp.c (handle_composition_prop): Likewise.
11263
a8815b00
EZ
112642011-07-07 Eli Zaretskii <eliz@gnu.org>
11265
11266 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
11267 (Bug#9015)
11268
ef7b981d 112692011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
11270
11271 * character.h (unicode_category_t): New enum type.
11272
11273 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
11274 (Qchar_code_property_table): New variable.
11275 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
11276 (UNIPROP_COMPRESSED_FORM_P): New macros.
11277 (char_table_ascii): Uncompress the compressed values.
11278 (sub_char_table_ref): New arg is_uniprop. Callers changed.
11279 Uncompress the compressed values.
ac389d0c 11280 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
11281 (char_table_ref_and_range): Uncompress the compressed values.
11282 (sub_char_table_set): New arg is_uniprop. Callers changed.
11283 Uncompress the compressed values.
11284 (sub_char_table_set_range): Args changed. Callers changed.
11285 (char_table_set_range): Adjuted for the above change.
11286 (map_sub_char_table): Delete args default_val and parent. Add arg
11287 top. Give decoded values to a Lisp function.
640c8776 11288 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
11289 values to a Lisp function. Gcpro more variables.
11290 (uniprop_table_uncompress)
11291 (uniprop_decode_value_run_length): New functions.
11292 (uniprop_decoder, uniprop_decoder_count): New variables.
11293 (uniprop_get_decoder, uniprop_encode_value_character)
11294 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
11295 New functions.
11296 (uniprop_encoder, uniprop_encoder_count): New variables.
11297 (uniprop_get_encoder, uniprop_table)
11298 (Funicode_property_table_internal, Fget_unicode_property_internal)
11299 (Fput_unicode_property_internal): New functions.
11300 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
11301 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 11302 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
11303 char-code-property-alist.
11304
640c8776 11305 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
11306 Vunicode_category_table.
11307
640c8776 11308 * font.c (font_range): Adjust for the change of
c805dec0
KH
11309 Vunicode_category_table.
11310
76b397fb
DN
113112011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
11312
11313 * m/iris4d.h: Remove file, move contents ...
11314 * s/irix6-5.h: ... here.
11315
22b4128e
PE
113162011-07-06 Paul Eggert <eggert@cs.ucla.edu>
11317
11318 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
11319 * alloc.c (mark_buffer):
11320 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
11321 (clone_per_buffer_values): Don't assume that
22b4128e
PE
11322 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
11323 This isn't true in general, and it's particularly not true
11324 if Emacs is configured with --with-wide-int.
11325 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
11326 New macros, used in the buffer.c change.
11327
869795d6
JD
113282011-07-05 Jan Djärv <jan.h.d@swipnet.se>
11329
11330 * xsettings.c: Use both GConf and GSettings if both are available.
11331 (store_config_changed_event): Add comment.
11332 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
11333 (store_tool_bar_style_changed): New functions.
5e617bc2 11334 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
11335 (struct xsettings): Move font inside HAVE_XFT.
11336 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 11337 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 11338 Move inside HAVE_XFT.
640c8776 11339 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
11340 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
11341 also.
11342 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 11343 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 11344 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
11345 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
11346 (parse_settings): Move check for font inside HAVE_XFT.
11347 (read_settings, apply_xft_settings): Add comment.
11348 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
11349 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
11350 call store_font_name_changed.
11351 (xft_settings_event): Add comment.
11352 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
11353 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
11354 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
11355 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
11356 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
11357 (xsettings_get_system_font, xsettings_get_system_normal_font):
11358 Add comment.
869795d6 11359
d8ed26bd
PE
113602011-07-05 Paul Eggert <eggert@cs.ucla.edu>
11361
11362 Random fixes. E.g., (random) never returned negative values.
11363 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
11364 subseconds part to the entropy, as that's a bit more random.
11365 Prefer signed to unsigned, since the signedness doesn't matter and
11366 in general we prefer signed. When given a limit, use a
11367 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
11368 latter isn't right if USE_2_TAGS_FOR_INTS.
11369 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
11370 not 0..VALMASK. Don't discard "excess" bits that random () returns.
11371
cabf1cac
SM
113722011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
11373
11374 * textprop.c (text_property_stickiness):
11375 Obey Vtext_property_default_nonsticky.
11376 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
11377 * w32fns.c (syms_of_w32fns):
11378 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
11379
6e9b2be9
PE
113802011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11381
11382 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
11383 This is more efficient than Ffile_directory_p and avoids a minor race.
11384
90186c68
LMI
113852011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
11386
7c301272
LMI
11387 * buffer.c (Foverlay_put): Say what the return value is
11388 (bug#7835).
11389
c4f2d8d4
LMI
11390 * fileio.c (barf_or_query_if_file_exists): Check first if the file
11391 is a directory before asking whether to use the file name
11392 (bug#7564).
ad637907
LMI
11393 (barf_or_query_if_file_exists): Make the "File is a directory"
11394 error be more correct.
c4f2d8d4 11395
90186c68
LMI
11396 * fns.c (Frequire): Remove the mention of the .gz files, since
11397 that's installation-specific, but keep the mention of
11398 `get-load-suffixes'.
11399
da64016e
PE
114002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11401
11402 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
11403 Report string overflow if the output is too long.
11404
7d47b580
JB
114052011-07-04 Juanma Barranquero <lekktu@gmail.com>
11406
a555cb87
JB
11407 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
11408 (syms_of_gnutls): Remove duplicate DEFSYM for
11409 Qgnutls_bootprop_verify_hostname_error, an error for
11410 Qgnutls_bootprop_verify_error (which is no longer used).
11411
7d47b580
JB
11412 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
11413 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
11414 Also (re)move comments that are misplaced or no longer relevant.
11415
1e49bfab
LMI
114162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11417
11418 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
11419
1485f4c0
CY
114202011-07-03 Chong Yidong <cyd@stupidchicken.com>
11421
11422 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
11423 and background color parameters if they have been changed.
11424
a9ab721e
LMI
114252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11426
11427 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
11428
cf7cff57
PE
114292011-07-03 Paul Eggert <eggert@cs.ucla.edu>
11430
2e13213d
PE
11431 * xsettings.c (SYSTEM_FONT): Define only when used.
11432 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
11433
cf7cff57
PE
11434 * keymap.c (access_keymap_1): Now static.
11435
7a8e04f7
CY
114362011-07-02 Chong Yidong <cyd@stupidchicken.com>
11437
11438 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
11439 leave any prefix arg for the up event (Bug#1586).
11440
61352f62
LMI
114412011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
11442
69bb1ef7
LMI
11443 * lread.c (syms_of_lread): Mention single symbols defined by
11444 `defvar' or `defconst' (bug#7154).
11445
61352f62 11446 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 11447 (Frequire): Mention get-load-suffixes.
61352f62 11448
28545e04
MR
114492011-07-02 Martin Rudalics <rudalics@gmx.at>
11450
11451 * window.h (window): Remove clone_number slot.
11452 * window.c (Fwindow_clone_number, Fset_window_clone_number):
11453 Remove.
11454 (make_parent_window, make_window, saved_window)
11455 (Fset_window_configuration, save_window_save): Don't deal with
11456 clone numbers.
11457 * buffer.c (Qclone_number): Remove declaration.
11458 (sort_overlays, overlay_strings): Don't deal with clone numbers.
11459
3349e122
SM
114602011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
11461
11462 Add multiple inheritance to keymaps.
11463 * keymap.c (Fmake_composed_keymap): New function.
11464 (Fset_keymap_parent): Simplify.
11465 (fix_submap_inheritance): Remove.
11466 (access_keymap_1): New function extracted from access_keymap to handle
11467 embedded parents and handle lists of maps.
11468 (access_keymap): Use it.
11469 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
11470 (Fcopy_keymap): Handle embedded parents.
11471 (Fcommand_remapping, define_as_prefix): Simplify.
11472 (Fkey_binding): Simplify.
11473 (syms_of_keymap): Move minibuffer-local-completion-map,
11474 minibuffer-local-filename-completion-map,
11475 minibuffer-local-must-match-map, and
11476 minibuffer-local-filename-must-match-map to Elisp.
11477 (syms_of_keymap): Defsubr make-composed-keymap.
11478 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
11479 (parse_menu_item): Trivial simplification.
11480
3279eb87
GM
114812011-07-01 Glenn Morris <rgm@gnu.org>
11482
11483 * Makefile.in (SETTINGS_LIBS): Fix typo.
11484
39cb9e56 114852011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
11486
11487 * coding.c (Fencode_coding_string): Record the last coding system
11488 used, as the function doc string says (bug#8738).
11489
0949d2b6
JD
114902011-07-01 Jan Djärv <jan.h.d@swipnet.se>
11491
11492 * xsettings.c (store_monospaced_changed): Take new font as arg and
11493 check for change against current_mono_font.
11494 (EMACS_TYPE_SETTINGS): Remove this and related defines.
11495 (emacs_settings_constructor, emacs_settings_get_property)
11496 (emacs_settings_set_property, emacs_settings_class_init)
11497 (emacs_settings_init, gsettings_obj): Remove.
11498 (something_changedCB): New function for HAVE_GSETTINGS.
11499 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
11500 with value as argument.
11501 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
11502 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 11503 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
11504 "changed".
11505
11506 * xgselect.c: Add defined (HAVE_GSETTINGS).
11507 (xgselect_initialize): Ditto.
11508
11509 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
11510 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
11511 xg_select.
11512
bbc6b304
PE
115132011-07-01 Paul Eggert <eggert@cs.ucla.edu>
11514
11515 * eval.c (struct backtrace): Simplify and port the data structure.
11516 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
11517 signed bit field, as this assumption is not portable and it makes
11518 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
11519 "char debug_on_exit : 1" as this is not portable either; instead,
11520 use the portable "unsigned int debug_on_exit : 1". Remove unused
11521 member evalargs. Remove obsolete comments about cc bombing out.
11522
9851bfc5
JD
115232011-06-30 Jan Djärv <jan.h.d@swipnet.se>
11524
51bb811f 11525 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
11526 Let HAVE_GSETTINGS override HAVE_GCONF.
11527 (store_monospaced_changed): New function.
11528 (EMACS_SETTINGS): A new type derived from GObject to handle
11529 GSettings notifications.
11530 (emacs_settings_constructor, emacs_settings_get_property)
11531 (emacs_settings_set_property, emacs_settings_class_init):
11532 New functions.
11533 (gsettings_client, gsettings_obj): New variables.
11534 (GSETTINGS_SCHEMA): New define.
11535 (something_changedCB): Call store_monospaced_changed.
11536 (init_gsettings): New function.
11537 (xsettings_initialize): Call init_gsettings.
11538 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
11539 to NULL.
11540
640c8776 11541 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
11542 GCONF_CFLAGS/LIBS.
11543
5386012d
MR
115442011-06-29 Martin Rudalics <rudalics@gmx.at>
11545
11546 * window.c (resize_root_window, grow_mini_window)
11547 (shrink_mini_window): Rename Qresize_root_window to
11548 Qwindow_resize_root_window and Qresize_root_window_vertically to
11549 Qwindow_resize_root_window_vertically.
11550
f13e0b08
PE
115512011-06-28 Paul Eggert <eggert@cs.ucla.edu>
11552
11553 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
11554
94515237
JB
115552011-06-27 Juanma Barranquero <lekktu@gmail.com>
11556
11557 * makefile.w32-in: Redesign dependencies so they reflect more
11558 clearly which files are directly included by each source file,
11559 and not through other includes.
11560
e43b6e43
MR
115612011-06-27 Martin Rudalics <rudalics@gmx.at>
11562
11563 * buffer.c (Qclone_number): Declare static and DEFSYM it.
11564 (sort_overlays, overlay_strings): When an overlay's clone number
11565 matches the window's clone number process the overlay even if
11566 the overlay's window property doesn't match the current window.
11567
d68443dc
MR
11568 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
11569 (Fwindow_hchild): Rename to Fwindow_left_child.
11570 (Fwindow_next): Rename to Fwindow_next_sibling.
11571 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
11572 (resize_window_check): Rename to window_resize_check.
11573 (resize_window_apply): Rename to window_resize_apply.
11574 (Fresize_window_apply): Rename to Fwindow_resize_apply.
11575 (Fdelete_other_windows_internal, resize_frame_windows)
11576 (Fsplit_window_internal, Fdelete_window_internal)
11577 (grow_mini_window, shrink_mini_window)
11578 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 11579
c7e73be5
JD
115802011-06-26 Jan Djärv <jan.h.d@swipnet.se>
11581
11582 * emacsgtkfixed.h: State that this is only used with Gtk+3.
11583 (emacs_fixed_set_min_size): Remove.
11584 (emacs_fixed_new): Take frame as argument.
11585
11586 * emacsgtkfixed.c: State that this is only used with Gtk+3.
11587 (_EmacsFixedPrivate): Remove minwidth/height.
11588 Add struct frame *f.
11589 (emacs_fixed_init): Initialize priv->f.
11590 (get_parent_class, emacs_fixed_set_min_size): Remove.
11591 (emacs_fixed_new): Set priv->f to argument.
11592 (emacs_fixed_get_preferred_width)
11593 (emacs_fixed_get_preferred_height): Use min_width/height from
11594 frames size_hint to set minimum and natural (Bug#8919).
11595 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
11596 and use min_width/height from frames size_hint to set
11597 min_width/height (Bug#8919).
11598
11599 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
11600 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
11601 Fix indentation.
c7e73be5 11602
cf99dcf8
EZ
116032011-06-26 Eli Zaretskii <eliz@gnu.org>
11604
11605 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
11606 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
11607 called at ZV.
11608
029529ac
CY
116092011-06-26 Chong Yidong <cyd@stupidchicken.com>
11610
11611 * process.c (wait_reading_process_output): Bypass select if
11612 waiting for a cell while ignoring keyboard input, and input is
11613 pending. Suggested by Jan Djärv (Bug#8869).
11614
7a7ef429
PE
116152011-06-25 Paul Eggert <eggert@cs.ucla.edu>
11616
11617 Use gnulib's dup2 module instead of rolling our own.
11618 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
11619
11fdef7d 116202011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
11621
11622 * dispnew.c (scrolling_window): Before scrolling, turn off a
11623 mouse-highlight in the window being scrolled.
11624
cd3520a4
JB
116252011-06-24 Juanma Barranquero <lekktu@gmail.com>
11626
11627 Move DEFSYM to lisp.h and use everywhere.
11628
11629 * character.h (DEFSYM): Move declaration...
11630 * lisp.h (DEFSYM): ...here.
11631
11632 * gnutls.c:
11633 * minibuf.c:
11634 * w32menu.c:
11635 * w32proc.c:
11636 * w32select.c: Don't include character.h.
11637
11638 * alloc.c (syms_of_alloc):
11639 * buffer.c (syms_of_buffer):
11640 * bytecode.c (syms_of_bytecode):
11641 * callint.c (syms_of_callint):
11642 * casefiddle.c (syms_of_casefiddle):
11643 * casetab.c (init_casetab_once):
11644 * category.c (init_category_once, syms_of_category):
11645 * ccl.c (syms_of_ccl):
11646 * cmds.c (syms_of_cmds):
11647 * composite.c (syms_of_composite):
11648 * dbusbind.c (syms_of_dbusbind):
11649 * dired.c (syms_of_dired):
11650 * dispnew.c (syms_of_display):
11651 * doc.c (syms_of_doc):
11652 * editfns.c (syms_of_editfns):
11653 * emacs.c (syms_of_emacs):
11654 * eval.c (syms_of_eval):
11655 * fileio.c (syms_of_fileio):
11656 * fns.c (syms_of_fns):
11657 * frame.c (syms_of_frame):
11658 * fringe.c (syms_of_fringe):
11659 * insdel.c (syms_of_insdel):
11660 * keymap.c (syms_of_keymap):
11661 * lread.c (init_obarray, syms_of_lread):
11662 * macros.c (syms_of_macros):
11663 * msdos.c (syms_of_msdos):
11664 * print.c (syms_of_print):
11665 * process.c (syms_of_process):
11666 * search.c (syms_of_search):
11667 * sound.c (syms_of_sound):
11668 * syntax.c (init_syntax_once, syms_of_syntax):
11669 * terminal.c (syms_of_terminal):
11670 * textprop.c (syms_of_textprop):
11671 * undo.c (syms_of_undo):
11672 * w32.c (globals_of_w32):
11673 * window.c (syms_of_window):
11674 * xdisp.c (syms_of_xdisp):
11675 * xfaces.c (syms_of_xfaces):
11676 * xfns.c (syms_of_xfns):
11677 * xmenu.c (syms_of_xmenu):
11678 * xsettings.c (syms_of_xsettings):
11679 * xterm.c (syms_of_xterm): Use DEFSYM.
11680
4228cf16
TZ
116812011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
11682
cd3520a4 11683 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 11684
7fcccf1e
PE
116852011-06-23 Paul Eggert <eggert@cs.ucla.edu>
11686
7efb4e0e
PE
11687 Integer and buffer overflow fixes (Bug#8873).
11688
ff5844ad
PE
11689 * print.c (printchar, strout): Check for string overflow.
11690 (PRINTPREPARE, printchar, strout):
11691 Don't set size unless allocation succeeds.
11692
90532f02
PE
11693 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
11694 for sizes. Check for string overflow more accurately.
11695 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
11696
6d84508d
PE
11697 * macros.c: Integer and buffer overflow fixes.
11698 * keyboard.h (struct keyboard.kbd_macro_bufsize):
11699 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
11700 Use ptrdiff_t, not int, for sizes.
11701 Don't increment bufsize until after realloc succeeds.
11702 Check for size-calculation overflow.
11703 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
11704
437b2cb4
PE
11705 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
11706
8b9ac8b4
PE
11707 * lread.c: Integer overflow fixes.
11708 (read_integer): Radix is now EMACS_INT, not int,
11709 to improve quality of diagnostics for out-of-range radices.
11710 Calculate buffer size correctly for out-of-range radices.
11711 (read1): Check for integer overflow in radices, and in
11712 read-circle numbers.
82cb60d3
PE
11713 (read_escape): Avoid int overflow.
11714 (Fload, openp, read_buffer_size, read1)
11715 (substitute_object_recurse, read_vector, read_list, map_obarray):
11716 Use ptrdiff_t, not int, for sizes.
11717 (read1): Use EMACS_INT, not int, for sizes.
20270765 11718 Check for size overflow.
8b9ac8b4 11719
7fcccf1e
PE
11720 * image.c (cache_image): Check for size arithmetic overflow.
11721
bfbbd7e7
PE
11722 * lread.c: Integer overflow issues.
11723 (saved_doc_string_size, saved_doc_string_length)
11724 (prev_saved_doc_string_size, prev_saved_doc_string_length):
11725 Now ptrdiff_t, not int.
11726 (read1): Don't assume doc string length fits in int. Check for
11727 out-of-range doc string lengths.
11728 (read_list): Don't assume file position fits in int.
39019e54 11729 (read_escape): Check for hex character overflow.
bfbbd7e7 11730
4e323265
LL
117312011-06-22 Leo Liu <sdl.web@gmail.com>
11732
11733 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
11734 Move to minibuffer.el.
11735
85fece3e
PE
117362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11737
20b84ce9 11738 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
11739 The following patches are for when GLYPH_DEBUG && !XASSERT.
11740 * dispextern.h (trace_redisplay_p, dump_glyph_string):
11741 * dispnew.c (flush_stdout):
11742 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
11743 Mark as externally visible.
11744 * dispnew.c (check_window_matrix_pointers): Now static.
11745 * dispnew.c (window_to_frame_vpos):
11746 * xfns.c (unwind_create_frame):
11747 * xterm.c (x_check_font): Remove unused local.
11748 * scroll.c (CHECK_BOUNDS):
11749 * xfaces.c (cache_fache): Rename local to avoid shadowing.
11750 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
11751 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
11752 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
11753 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
11754 Now static.
11755 (debug_method_add): Use va_list and vsprintf rather than relying
11756 on undefined behavior with wrong number of arguments.
11757 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
11758 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
11759 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
11760 since we're not interested in debugging glyphs with old libraries.
11761 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
11762 GCC 4.6.0's static checking.
11763
0766b489
PE
117642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11765
31fd4b32
PE
11766 Integer overflow and signedness fixes (Bug#8873).
11767 A few related buffer overrun fixes, too.
11768
b79e8648
PE
11769 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
11770
0766b489
PE
11771 * dispextern.h (struct face.stipple):
11772 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
11773 (x_bitmap_mask, x_allocate_bitmap_record)
11774 (x_create_bitmap_from_data, x_create_bitmap_from_file)
11775 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
11776 (x_create_bitmap_from_xpm_data):
11777 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
11778 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
11779 (.bitmaps_last):
11780 * xfaces.c (load_pixmap):
11781 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
11782 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
11783 (.bitmaps_last, struct x_output.icon_bitmap):
11784 Use ptrdiff_t, not int, for bitmap indexes.
11785 (x_allocate_bitmap_record): Check for size overflow.
11786 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
11787
b081724f
PE
11788 Use ptrdiff_t, not int, for overlay counts.
11789 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
11790 * editfns.c (overlays_around, get_pos_property):
11791 * textprop.c (get_char_property_and_overlay):
11792 * xdisp.c (next_overlay_change, note_mouse_highlight):
11793 * xfaces.c (face_at_buffer_position):
21514da7
PE
11794 * buffer.c (OVERLAY_COUNT_MAX): New macro.
11795 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
11796 (Fnext_overlay_change, Fprevious_overlay_change)
11797 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 11798 Use ptrdiff_t, not int, for sizes.
21514da7 11799 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 11800
3de73e5e
PE
11801 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
11802
2606c57b
PE
11803 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
11804 (x_session_initialize): Do not assume string length fits in int.
11805
aaafe47a
PE
11806 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
11807 This is unlikely, but can occur if DPI is outlandish.
11808
2674ddc8 11809 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
11810 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
11811
28154962
PE
11812 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
11813 * xrdb.c (magic_file_p, search_magic_path):
11814 Omit last arg SUFFIX; it was always 0. All callers changed.
11815 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
11816
7de51af5
PE
11817 * xfont.c (xfont_match): Avoid need for strlen.
11818
25ed6cc3
PE
11819 * xfns.c: Don't assume strlen fits in int.
11820 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
11821
4eab31dd
PE
11822 * xdisp.c (message_log_check_duplicate): Return intmax_t,
11823 not unsigned long, as we prefer signed integers. All callers changed.
11824 Detect integer overflow in repeat count.
11825 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 11826 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 11827
171e2a58
PE
11828 * termcap.c: Don't assume sizes fit in int and never overflow.
11829 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
11830 (gobble_line): Check for size-calculation overflow.
11831
ad39faca 11832 * minibuf.c (Fread_buffer):
6e5bb2dc 11833 * lread.c (intern, intern_c_string):
74ca2eb3
PE
11834 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
11835 Don't assume string length fits in int.
11836
52c61c22 11837 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
11838 * gtkutil.c (style_changed_cb): Avoid need for strlen.
11839
b5b8c9e5
PE
11840 * font.c: Don't assume string length fits in int.
11841 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
11842 Use ptrdiff_t, not int.
ccd6111c
PE
11843 (font_intern_prop): Don't assume string length fits in int.
11844 Don't assume integer property fits in fixnum.
11845 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 11846
882f0d81 11847 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 11848 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
11849 Reformulate so as not to need the command string.
11850 Invoke gzip -cd rather than gunzip, as it's more portable.
11851 (lock_info_type, lock_file_1, lock_file):
11852 Don't assume pid_t and time_t fit in unsigned long.
11853 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
11854 (current_lock_owner): Prefer signed type for sizes.
11855 Use memcpy, not strncpy, where memcpy is what is really wanted.
11856 Don't assume (via atoi) that time_t and pid_t fit in int.
11857 Check for time_t and/or pid_t out of range, e.g., via a network share.
11858 Don't alloca where an auto var works fine.
11859
93f4cf88
PE
11860 * fileio.c: Fix some integer overflow issues.
11861 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
11862 Don't assume string length fits in int.
11863 (directory_file_name): Don't assume string length fits in long.
11864 (make_temp_name): Don't assume pid fits in int, or that its print
11865 length is less than 20.
11866
f3e92b69
PE
11867 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
11868
1bfdaf10
PE
11869 * coding.c (make_subsidiaries): Don't assume string length fits in int.
11870
35016e9a
PE
11871 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
11872
3d1e65a1
PE
11873 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
11874 We prefer signed integers, even for size calculations.
11875
0b963a93
PE
11876 * emacs.c: Don't assume string length fits in 'int'.
11877 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
11878 (main): Don't invoke strlen when not needed.
11879
573f4b54
PE
11880 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
11881 (XD_DEBUG_MESSAGE): Don't waste a byte.
11882
989f33ba
PE
11883 * callproc.c (getenv_internal_1, getenv_internal)
11884 (Fgetenv_internal):
965d34eb
PE
11885 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
11886
e4d29b33
PE
11887 * lread.c (invalid_syntax): Omit length argument.
11888 All uses changed. This doesn't fix a bug, but it simplifies the
11889 code away from its former Hollerith-constant appearance, and it's
11890 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 11891 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 11892
eb49b136
PE
11893 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
11894 This didn't break anything, but it didn't help either.
11895 It's confusing to put a bogus integer in a place where the actual
11896 value does not matter.
9f62aeb1 11897 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 11898 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 11899
15375a22
PE
11900 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
11901 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
11902 implementation.
b61cc01c
PE
11903 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
11904 We prefer signed types, and the value cannot exceed the EMACS_INT
11905 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
11906 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
11907 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
11908 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 11909
53b2623d
PE
11910 * indent.c (sane_tab_width): New function.
11911 (current_column, scan_for_column, Findent_to, position_indentation)
11912 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 11913 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 11914
51cab52b 11915 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 11916
f2ed8a70
PE
11917 * lisp.h (lint_assume): New macro.
11918 * composite.c (composition_gstring_put_cache):
11919 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
11920
abe80cc6
PE
11921 * editfns.c, insdel.c:
11922 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 11923
b02c740e
PE
11924 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
11925
ebc96716
PE
11926 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
11927
b4e50fa0 11928 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 11929 Use much-faster test for byte-length change.
311d5d7c 11930 Don't assume string byte-length fits in 'int'.
a4cf38e4 11931 Check that character arg fits in 'int'.
85461888 11932 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 11933
c0c1ee9f
PE
11934 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
11935
a498d7f4
PE
11936 * fns.c (concat): Catch string overflow earlier.
11937 Do not rely on integer wraparound.
11938
51cab52b
PE
11939 * dispextern.h (struct it.overlay_strings_charpos)
11940 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
11941 * xdisp.c (forward_to_next_line_start)
11942 (back_to_previous_visible_line_start)
11943 (reseat_at_next_visible_line_start, next_element_from_buffer):
11944 Don't arbitrarily truncate the value of 'selective' to int.
11945
76031fad
PE
11946 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
11947
5eb55db9
PE
11948 * composite.c: Don't truncate sizes to 'int'.
11949 (composition_gstring_p, composition_reseat_it)
11950 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
11951 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
11952 not EMACS_UINT, for indexes.
5eb55db9 11953
0703a717
PE
11954 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
11955
d6202519
PE
11956 * buffer.c: Include <verify.h>.
11957 (struct sortvec.priority, struct sortstr.priority):
8961a454 11958 Now EMACS_INT, not int.
c20998a7 11959 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
11960 (struct sortstr.size, record_overlay_string)
11961 (struct sortstrlist.size, struct sortlist.used):
11962 Don't truncate size to int.
11963 (record_overlay_string): Check for size-calculation overflow.
d6202519 11964 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 11965
d5a19415
JM
119662011-06-22 Jim Meyering <meyering@redhat.com>
11967
029529ac 11968 Don't leak an XBM-image-sized buffer
d5a19415
JM
11969 * image.c (xbm_load): Free the image buffer after using it.
11970
a9041e6c
PE
119712011-06-21 Paul Eggert <eggert@cs.ucla.edu>
11972
11973 Port to Sun C.
11974 * composite.c (find_automatic_composition): Omit needless 'return 0;'
11975 that Sun C diagnosed.
11976 * fns.c (secure_hash): Fix pointer signedness issue.
11977 * intervals.c (static_offset_intervals): New function.
11978 (offset_intervals): Use it.
11979
7f3f739f
LL
119802011-06-21 Leo Liu <sdl.web@gmail.com>
11981
11982 * deps.mk (fns.o):
11983 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
11984 sha512.h.
11985
11986 * fns.c (secure_hash): Rename from crypto_hash_function and change
11987 the first arg to accept symbols.
5b66d427 11988 (Fsecure_hash): New primitive.
7f3f739f
LL
11989 (syms_of_fns): New symbols.
11990
76147d94
DD
119912011-06-20 Deniz Dogan <deniz@dogan.se>
11992
11993 * process.c (Fset_process_buffer): Clarify return value in
11994 docstring.
11995
7d7d0045
CY
119962011-06-18 Chong Yidong <cyd@stupidchicken.com>
11997
11998 * dispnew.c (add_window_display_history): Use BVAR.
11999
12000 * xdisp.c (debug_method_add): Use BVAR.
12001 (check_window_end, dump_glyph_matrix, dump_glyph)
12002 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
12003
12004 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
12005 Likewise.
12006
12007 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
12008 check till after the cache is created in init_frame_faces.
12009
ff2bc410
SM
120102011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
12011
12012 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
12013
28177add
PE
120142011-06-16 Paul Eggert <eggert@cs.ucla.edu>
12015
dd3482fe
PE
12016 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
12017 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
12018 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
12019
393d71f3 12020 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
12021 * fileio.c (Finsert_file_contents):
12022 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
12023 Remove the old (too-loose) buffer overflow checks.
12024 They weren't needed, since make_gap checks for buffer overflow.
12025 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
12026 The old code merely checked for Emacs fixnum overflow, and relied
12027 on undefined (wraparound) behavior. The new code avoids undefined
12028 behavior, and also checks for ptrdiff_t and/or size_t overflow.
12029
2e6813b0 12030 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
12031 Tune. Don't use wider integers than needed. Don't use alloca.
12032 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 12033
599a9e4f
PE
12034 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
12035
99561444
PE
12036 * insdel.c, lisp.h (buffer_overflow): New function.
12037 (insert_from_buffer_1, replace_range, replace_range_2):
12038 * insdel.c (make_gap_larger):
12039 * editfns.c (Finsert_char):
12040 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
12041
28177add
PE
12042 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
12043
e69dafad
PE
120442011-06-15 Paul Eggert <eggert@cs.ucla.edu>
12045
4baa020d 12046 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 12047
b1c46f02
PE
12048 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
12049 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
12050
e69dafad
PE
12051 * fileio.c: Don't assume EMACS_INT fits in off_t.
12052 (emacs_lseek): New static function.
12053 (Finsert_file_contents, Fwrite_region): Use it.
12054 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
12055
566684ea
PE
12056 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
12057
e6966cd6
PE
12058 * fns.c: Don't overflow int when computing a list length.
12059 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
12060 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
12061 truncation on 64-bit hosts. Check for QUIT every
12062 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
12063 faster and is responsive enough.
12064 (Flength): Report an error instead of overflowing an integer.
12065 (Fsafe_length): Return a float if the value is not representable
12066 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 12067 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 12068 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 12069
dd0b0efb
PE
12070 * alloc.c: Check that resized vectors' lengths fit in fixnums.
12071 (header_size, word_size): New constants.
12072 (allocate_vectorlike): Don't check size overflow here.
12073 (allocate_vector): Check it here instead, since this is the only
12074 caller of allocate_vectorlike that could cause overflow.
12075 Check that the new vector's length is representable as a fixnum.
12076
86fe5cfe
PE
12077 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
12078 The previous code was bogus. For example, next_almost_prime (32)
12079 returned 39, which is undesirable as it is a multiple of 3; and
12080 next_almost_prime (24) returned 25, which is a multiple of 5 so
12081 why was the code bothering to check for multiples of 7?
12082
80e88859
PE
12083 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
12084
4a2f0ad6
PE
12085 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
12086
f66c7cf8
PE
12087 Variadic C functions now count arguments with ptrdiff_t.
12088 This partly undoes my 2011-03-30 change, which replaced int with size_t.
12089 Back then I didn't know that the Emacs coding style prefers signed int.
12090 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
12091 were being counted with int, which may truncate counts on 64-bit
12092 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
12093 * lisp.h (struct Lisp_Subr.function.aMANY)
12094 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
12095 Arg counts are now ptrdiff_t, not size_t.
12096 All variadic functions and their callers changed accordingly.
12097 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
12098 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
12099 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
12100 * callint.c (Fcall_interactively): Check arg count for overflow,
12101 to avoid potential buffer overrun. Use signed char, not 'int',
12102 for 'varies' array, so that we needn't bother to check its size
12103 calculation for overflow.
12104 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
12105 * eval.c (apply_lambda):
12106 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
12107 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
12108 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
12109
a1759b76
PE
12110 * callint.c (Fcall_interactively): Don't use index var as event count.
12111
d96be9fc
PE
12112 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
12113 * mem-limits.h (SIZE): Remove; no longer used.
12114
a690a978 12115 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 12116
578c21e6
PE
12117 Remove unnecessary casts.
12118 * xterm.c (x_term_init):
12119 * xfns.c (x_set_border_pixel):
12120 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
12121 These aren't needed now that we assume ANSI C.
12122
96f53c6c
PE
12123 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
12124 It's more likely to cause problems (due to unsigned overflow)
12125 than to cure them.
12126
83c77d31
PE
12127 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
12128
ee2079f1
PE
12129 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
12130
6da65536
PE
12131 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
12132
7147c4a4
PE
12133 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
12134
193e32d9
PE
12135 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
12136
e5533da6
PE
12137 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
12138
9910e595
PE
12139 GLYPH_CODE_FACE returns EMACS_INT, not int.
12140 * dispextern.h (merge_faces):
12141 * xfaces.c (merge_faces):
01103c44
PE
12142 * xdisp.c (get_next_display_element, next_element_from_display_vector):
12143 Don't assume EMACS_INT fits in int.
9910e595 12144
2638320e
PE
12145 * character.h (CHAR_VALID_P): Remove unused parameter.
12146 * fontset.c, lisp.h, xdisp.c: All uses changed.
12147
045eb8d9
PE
12148 * editfns.c (Ftranslate_region_internal): Omit redundant test.
12149
c1f134b5
PE
12150 * fns.c (concat): Minor tuning based on overflow analysis.
12151 This doesn't fix any bugs. Use int to hold character, instead
12152 of constantly refetching from Emacs object. Use XFASTINT, not
12153 XINT, for value known to be a character. Don't bother comparing
12154 a single byte to 0400, as it's always less.
12155
395fcb93 12156 * floatfns.c (Fexpt):
327eeec8
PE
12157 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
12158
abbd3d23
PE
12159 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
12160 for characters.
12161
684a03ef
PE
12162 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
12163
0fed43f3
PE
12164 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
12165 Without this fix, on a 64-bit host (aset S 0 4294967386) would
12166 incorrectly succeed when S was a string, because 4294967386 was
12167 truncated before it was used.
12168
8fd02eb7
PE
12169 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
12170 Otherwise, an out-of-range integer could cause undefined behavior
12171 on a 64-bit host.
12172
f8c86b69
PE
12173 * composite.c: Use int, not EMACS_INT, for characters.
12174 (fill_gstring_body, composition_compute_stop_pos): Use int, not
12175 EMACS_INT, for values that are known to be in character range.
12176 This doesn't fix any bugs but is the usual style inside Emacs and
12177 may generate better code on 32-bit machines.
12178
34206dd2
PE
12179 Make sure a 64-bit char is never passed to ENCODE_CHAR.
12180 This is for reasons similar to the recent CHAR_STRING fix.
12181 * charset.c (Fencode_char): Check that character arg is actually
12182 a character. Pass an int to ENCODE_CHAR.
12183 * charset.h (ENCODE_CHAR): Verify that the character argument is no
12184 wider than 'int', as a compile-time check to prevent future regressions
12185 in this area.
12186
c5958d4c 12187 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
12188
12189 Make sure a 64-bit char is never passed to CHAR_STRING.
12190 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
12191 by silently ignoring the top 32 bits, allowing some values
12192 that were far too large to be valid characters.
12193 * character.h: Include <verify.h>.
12194 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
12195 arguments are no wider than unsigned, as a compile-time check
12196 to prevent future regressions in this area.
12197 * data.c (Faset):
01103c44 12198 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
12199 (Fsubst_char_in_region):
12200 * fns.c (concat):
12201 * xdisp.c (decode_mode_spec_coding):
12202 Adjust to CHAR_STRING's new requirement.
12203 * editfns.c (Finsert_char, Fsubst_char_in_region):
12204 * fns.c (concat): Check that character args are actually
12205 characters. Without this test, these functions did the wrong
12206 thing with wildly out-of-range values on 64-bit hosts.
12207
d37ca623
PE
12208 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
12209 These casts should not be needed on 32-bit hosts, either.
12210 * keyboard.c (read_char):
12211 * lread.c (Fload): Remove casts to unsigned.
12212
ea204efb
PE
12213 * lisp.h (UNSIGNED_CMP): New macro.
12214 This fixes comparison bugs on 64-bit hosts.
12215 (ASCII_CHAR_P): Use it.
12216 * casefiddle.c (casify_object):
01103c44 12217 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
12218 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
12219 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
12220 * dispextern.h (FACE_FROM_ID):
12221 * keyboard.c (read_char): Use UNSIGNED_CMP.
12222
41cb286c
PE
12223 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
12224 not to EMACS_INT, to avoid GCC warning.
12225
4a1b9832
PE
12226 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
12227
55daad71
PE
12228 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
12229 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
12230 isn't needed on 32-bit machines.
8f95c75c 12231
01103c44
PE
12232 * buffer.c (Fgenerate_new_buffer_name):
12233 Use EMACS_INT for count, not int.
0ceccced 12234 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
12235
12236 * data.c (Qcompiled_function): Now static.
12237
c6f072e7
PE
12238 * window.c (window_body_lines): Now static.
12239
20ce5912
PE
12240 * image.c (gif_load): Rename local to avoid shadowing.
12241
9c4c5f81
PE
12242 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
12243 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
12244 * alloc.c (make_save_value): Integer argument is now of type
12245 ptrdiff_t, not int.
12246 (mark_object): Use ptrdiff_t, not int.
12247 * lisp.h (pD): New macro.
12248 * print.c (print_object): Use it.
12249
c0c5c8ae
PE
12250 * alloc.c: Use EMACS_INT, not int, to count objects.
12251 (total_conses, total_markers, total_symbols, total_vector_size)
12252 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
12253 (total_free_floats, total_floats, total_free_intervals)
12254 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
12255 Now EMACS_INT, not int. All uses changed.
12256 (Fgarbage_collect): Compute overall total using a double, so that
12257 integer overflow is less likely to be a problem. Check for overflow
12258 when converting back to an integer.
5a25e253
PE
12259 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
12260 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
12261 These were 'int' variables that could overflow on 64-bit hosts;
12262 they were never used, so remove them instead of repairing them.
211a0b2a 12263 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
12264 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
12265 Previously, this ceilinged at INT_MAX, but that doesn't work on
12266 64-bit machines.
e46bb31a 12267 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 12268
c78baabf 12269 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 12270 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
12271 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
12272 when a (possibly-narrower) signed value would do just as well.
12273 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 12274
c9d624c6
PE
12275 * alloc.c: Catch some string size overflows that we were missing.
12276 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
12277 for convenience in STRING_BYTES_MAX.
12278 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
12279 The definition here is exact; the one in lisp.h was approximate.
12280 (allocate_string_data): Check for string overflow. This catches
12281 some instances we weren't catching before. Also, it catches
12282 size_t overflow on (unusual) hosts where SIZE_MAX <= min
12283 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
12284 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 12285
c9d624c6
PE
12286 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
12287 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 12288 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 12289
353032ce
PE
12290 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
12291
2bccce07
PE
12292 * alloc.c (Fmake_string): Check for out-of-range init.
12293
0ac30604
SM
122942011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
12295
12296 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
12297
c195f2de
JD
122982011-06-14 Jan Djärv <jan.h.d@swipnet.se>
12299
12300 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
12301 xg_get_default_scrollbar_width.
12302
12303 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
12304 (int_gtk_range_get_value): Move to the scroll bar part of the file.
12305 (style_changed_cb): Call update_theme_scrollbar_width and call
12306 x_set_scroll_bar_default_width and xg_frame_set_char_size for
12307 all frames (Bug#8505).
12308 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
12309 Call gtk_window_set_resizable if HAVE_GTK3.
12310 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
12311 and height if HAVE_GTK3 (Bug#8505).
12312 (scroll_bar_width_for_theme): New variable.
12313 (update_theme_scrollbar_width): New function.
12314 (xg_get_default_scrollbar_width): Move code to
12315 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
12316 (xg_initialize): Call update_theme_scrollbar_width.
12317
12318 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
12319
12320 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
12321
e10ac9f1
MR
123222011-06-12 Martin Rudalics <rudalics@gmx.at>
12323
12324 * frame.c (make_frame): Call other_buffer_safely instead of
12325 other_buffer.
12326
12327 * window.c (temp_output_buffer_show): Call display_buffer with
12328 second argument Vtemp_buffer_show_specifiers and reset latter
12329 immediately after the call.
12330 (Vtemp_buffer_show_specifiers): New variable.
12331 (auto_window_vscroll_p, next_screen_context_lines)
12332 (Vscroll_preserve_screen_position): Remove leading asterisks from
12333 doc-strings.
12334
2d3c217e 123352011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 12336
7b7f97e8 12337 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
12338 * buffer.c (Qclone_number): Remove for now, as it's unused.
12339 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
12340 (record_buffer): Remove unused local.
12341 * frame.c (other_visible_frames, frame_buffer_list): Now static.
12342 (set_frame_buffer_list): Remove; unused.
12343 * frame.h (other_visible_frames): Remove decl.
12344 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
12345 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12346 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12347 if HAVE_GPM.
12348 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
12349 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
12350 Define only if HAVE_GPM.
12351 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
12352 (update_hints_inhibit): Remove; never set. All uses removed.
12353 * widgetprv.h (emacsFrameClassRec): Remove decl.
12354 * window.c (delete_deletable_window): Now returns void, since it
12355 wasn't returning anything.
12356 (compare_window_configurations): Remove unused locals.
12357 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
12358 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
12359 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
12360 the same widths as pointers. This follows up on the 2011-05-06 patch.
12361 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
12362 * xterm.h: Likewise.
12363 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
12364
1384b89e
JB
123652011-06-12 Juanma Barranquero <lekktu@gmail.com>
12366
12367 * makefile.w32-in: Update dependencies.
12368 (LISP_H): Add lib/intprops.h.
12369
1100a63c
CY
123702011-06-11 Chong Yidong <cyd@stupidchicken.com>
12371
12372 * image.c (gif_load): Add animation frame delay to the metadata.
12373 (syms_of_image): Use DEFSYM. New symbol `delay'.
12374
6198ccd0
MR
123752011-06-11 Martin Rudalics <rudalics@gmx.at>
12376
12377 * window.c (delete_deletable_window): Re-add.
12378 (Fset_window_configuration): Rewrite to handle dead buffers and
12379 consequently deletable windows.
12380 (window_tree, Fwindow_tree): Remove. Supply functionality in
12381 window.el.
12382 (compare_window_configurations): Simplify code.
12383
b6e3633c
AS
123842011-06-11 Andreas Schwab <schwab@linux-m68k.org>
12385
1ab0dee5
AS
12386 * image.c (imagemagick_load_image): Fix type mismatch.
12387 (Fimagemagick_types): Likewise.
12388
b6e3633c
AS
12389 * window.h (replace_buffer_in_windows): Declare.
12390
9397e56f
MR
123912011-06-11 Martin Rudalics <rudalics@gmx.at>
12392
12393 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
12394 Qclone_number. Remove external declaration of Qdelete_window.
12395 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
12396 code.
640c8776
SM
12397 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
12398 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
12399 (Fother_buffer): Rewrite doc-string. Major rewrite for new
12400 buffer list implementation.
12401 (other_buffer_safely): New function.
12402 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
12403 calls to replace_buffer_in_windows and
12404 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
12405 if allowed.
12406 (record_buffer): Inhibit quitting and rewrite using quittable
12407 functions. Run Qbuffer_list_update_hook if allowed.
12408 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
12409 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
12410 Move switch-to-buffer to window.el.
9397e56f
MR
12411 (bury-buffer): Move to window.el.
12412 (Vbuffer_list_update_hook): New variable.
12413
12414 * lisp.h (other_buffer_safely): Add prototype in buffer.c
12415 section.
12416
12417 * window.h (resize_frame_windows): Move up in code.
12418 (Fwindow_frame): Remove EXFUN.
12419 (replace_buffer_in_all_windows): Remove prototype.
12420 (replace_buffer_in_windows_safely): Add prototype.
12421
12422 * window.c: Declare Qdelete_window static again. Move down
12423 declaration of select_count.
12424 (Fnext_window, Fprevious_window): Rewrite doc-strings.
12425 (Fother_window): Move to window.el.
12426 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
12427 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
12428 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
12429 window.el.
12430 (replace_buffer_in_windows): Implement by calling
12431 Qreplace_buffer_in_windows.
12432 (replace_buffer_in_all_windows): Remove with some functionality
12433 moved into replace_buffer_in_windows_safely.
12434 (replace_buffer_in_windows_safely): New function.
12435 (select_window_norecord, select_frame_norecord): Move in front
12436 of run_window_configuration_change_hook. Remove now obsolete
12437 declarations.
640c8776
SM
12438 (Fset_window_buffer): Rewrite doc-string.
12439 Call Qrecord_window_buffer.
9397e56f
MR
12440 (keys_of_window): Move binding for other-window to window.el.
12441
b50691aa
CY
124422011-06-11 Chong Yidong <cyd@stupidchicken.com>
12443
12444 * dispextern.h (struct image): Replace data member, whose int_val
12445 and ptr_val fields were not used by anything, with a single
12446 lisp_val object.
12447
12448 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
12449 (gif_clear_image, gif_load, imagemagick_load_image)
12450 (gs_clear_image, gs_load): Callers changed.
12451
3f754b86
PE
124522011-06-10 Paul Eggert <eggert@cs.ucla.edu>
12453
cca69397
PE
12454 * buffer.h: Include <time.h>, for time_t.
12455 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
12456
109e28d0
PE
12457 Fix minor problems found by static checking.
12458
60737f02
PE
12459 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
12460
4b66faf3
PE
12461 Make identifiers static if they are not used in other modules.
12462 * data.c (Qcompiled_function, Qframe, Qvector):
12463 * image.c (QimageMagick, Qsvg):
12464 * minibuf.c (Qmetadata):
12465 * window.c (resize_window_check, resize_root_window): Now static.
12466 * window.h (resize_window_check, resize_root_window): Remove decls.
12467
109e28d0
PE
12468 * window.c (window_deletion_count, delete_deletable_window):
12469 Remove; unused.
46a4ce9e
PE
12470 (window_body_lines): Now static.
12471 (Fdelete_other_windows_internal): Mark vars as initialized.
12472 Make sure 'resize_failed' is initialized.
12473 (run_window_configuration_change_hook): Rename local to avoid shadowing.
12474 (resize_window_apply): Remove unused local.
12475 * window.h (delete_deletable_window): Remove decl.
12476
109e28d0 12477 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
12478 (imagemagick_load_image): Fix pointer signedness problem by changing
12479 last arg from unsigned char * to char *. All uses changed.
12480 Also, fix a local for similar reasons.
12481 Remove unused locals. Remove locals to avoid shadowing.
12482 (fn_rsvg_handle_free): Remove; unused.
12483 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 12484 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 12485
3f754b86
PE
12486 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
12487
2547adb1
CY
124882011-06-10 Chong Yidong <cyd@stupidchicken.com>
12489
12490 * image.c (gif_load): Fix omitted cast error introduced by
12491 2011-06-06 change.
12492
2c8e37d4
MR
124932011-06-10 Martin Rudalics <rudalics@gmx.at>
12494
12495 * window.h (resize_proportionally, orig_total_lines)
12496 (orig_top_line): Remove from window structure.
12497 (set_window_height, set_window_width, change_window_heights)
12498 (Fdelete_window): Remove prototypes.
12499 (resize_frame_windows): Remove duplicate declaration.
12500
440a42e3
EZ
125012011-06-10 Eli Zaretskii <eliz@gnu.org>
12502
12503 * window.h (resize_frame_windows, resize_window_check)
12504 (delete_deletable_window, resize_root_window)
12505 (resize_frame_windows): Declare prototypes.
12506
12507 * window.c (resize_window_apply): Make definition be "static" to
12508 match the prototype.
12509
562dd5e9
MR
125102011-06-10 Martin Rudalics <rudalics@gmx.at>
12511
12512 * window.c: Remove declarations of Qwindow_size_fixed,
12513 window_min_size_1, window_min_size_2, window_min_size,
12514 size_window, window_fixed_size_p, enlarge_window, delete_window.
12515 Remove static from declaration of Qdelete_window, it's
12516 temporarily needed by Fbury_buffer.
12517 (replace_window): Don't assign orig_top_line and
12518 orig_total_lines.
12519 (Fdelete_window, delete_window): Remove. Window deletion is
12520 handled by window.el.
640c8776
SM
12521 (window_loop): Remove DELETE_OTHER_WINDOWS case.
12522 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
12523 (Fdelete_other_windows): Remove. Deleting other windows is
12524 handled by window.el.
12525 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
12526 handled in window.el.
12527 (window_min_size_2, window_min_size_1, window_min_size): Remove.
12528 Window minimum sizes are handled in window.el.
12529 (shrink_windows, size_window, set_window_height)
12530 (set_window_width, change_window_heights, window_height)
12531 (window_width, CURBEG, CURSIZE, enlarge_window)
12532 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
12533 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
12534 handled in window.el.
12535 (make_dummy_parent): Rename to make_parent_window and give it a
12536 second argument horflag.
12537 (make_window): Don't set resize_proportionally any more.
12538 (Fsplit_window): Remove. Windows are split in window.el.
12539 (save_restore_action, save_restore_orig_size)
12540 (shrink_window_lowest_first, save_restore_orig_size): Remove.
12541 Resize mini windows in window.el.
12542 (grow_mini_window, shrink_mini_window): Implement by calling
12543 Qresize_root_window_vertically, resize_window_check and
12544 resize_window_apply.
640c8776
SM
12545 (saved_window, Fset_window_configuration, save_window_save):
12546 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
12547 resize_proportionally.
12548 (window_min_height, window_min_width): Move to window.el.
12549 (keys_of_window): Move bindings for delete-other-windows,
12550 split-window, delete-window and enlarge-window to window.el.
12551
12552 * buffer.c: Temporarily extern Qdelete_window.
12553 (Fbury_buffer): Temporarily call Qdelete_window instead of
12554 Fdelete_window (Fbury_buffer will move to window.el soon).
12555
12556 * frame.c (set_menu_bar_lines_1): Remove code handling
12557 orig_top_line and orig_total_lines.
12558
12559 * dispnew.c (adjust_frame_glyphs_initially): Don't use
12560 set_window_height but set heights directly.
12561 (change_frame_size_1): Use resize_frame_windows.
12562
12563 * xdisp.c (init_xdisp): Don't use set_window_height but set
12564 heights directly.
12565
640c8776
SM
12566 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
12567 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
12568 run_window_configuration_change_hook.
12569
12570 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
12571 instead of change_window_heights and run
12572 run_window_configuration_change_hook.
12573
1a13852e
MR
125742011-06-09 Martin Rudalics <rudalics@gmx.at>
12575
12576 * window.c (replace_window): Rename second argument REPLACEMENT to
12577 NEW. New third argument SETFLAG. Rewrite.
12578 (delete_window, make_dummy_parent): Call replace_window with
12579 third argument 1.
12580 (window_list_1): Move down in code.
12581 (run_window_configuration_change_hook): Move set_buffer part
12582 before select_frame_norecord part in order to unwind correctly.
12583 Rename count1 to count.
12584 (recombine_windows, delete_deletable_window, resize_root_window)
12585 (Fdelete_other_windows_internal)
12586 (Frun_window_configuration_change_hook, make_parent_window)
12587 (resize_window_check, resize_window_apply, Fresize_window_apply)
12588 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
12589 (Fdelete_window_internal, Fresize_mini_window_internal):
12590 New functions.
1a13852e
MR
12591 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
12592
f3d1777e
MR
125932011-06-08 Martin Rudalics <rudalics@gmx.at>
12594
496e208e
MR
12595 * window.h (window): Add some new members to window structure -
12596 normal_lines, normal_cols, new_total, new_normal, clone_number,
12597 splits, nest, prev_buffers, next_buffers.
12598 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 12599 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 12600
f3d1777e
MR
12601 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
12602 Remove.
496e208e
MR
12603 (make_dummy_parent): Set new members of windows structure.
12604 (make_window): Move down in code. Handle new members of window
12605 structure.
12606 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
12607 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
12608 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
12609 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
12610 (Fset_window_next_buffers, Fset_window_clone_number):
12611 New functions.
496e208e
MR
12612 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
12613 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
12614 Doc-string fixes.
12615 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
12616 Argument WINDOW can be now internal window too.
12617 (Fwindow_use_time): Move up in code.
12618 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
12619 Rewrite doc-string.
12620 (Fset_window_configuration, saved_window)
12621 (Fcurrent_window_configuration, save_window_save): Handle new
12622 members of window structure.
b9e809c2
MR
12623 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
12624 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
12625 (syms_of_window): New Lisp objects Qrecord_window_buffer,
12626 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
12627 Qget_mru_window, Qresize_root_window,
12628 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
12629 Qauto_buffer_name; staticpro them.
f3d1777e 12630
abde8f8c
MR
126312011-06-07 Martin Rudalics <rudalics@gmx.at>
12632
12633 * window.c (Fwindow_total_size, Fwindow_left_column)
12634 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
12635 (Fwindow_list_1): New functions.
12636 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
12637 (Fwindow_width, Fscroll_left, Fscroll_right):
12638 Use window_body_cols instead of window_box_text_cols.
12639 (delete_window, Fset_window_configuration):
12640 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
12641 (delete_all_subwindows): Take a window as argument and not a
12642 structure. Rewrite.
190b47e6
MR
12643 (window_loop): Remove handling of GET_LRU_WINDOW and
12644 GET_LARGEST_WINDOW.
12645 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
12646
12647 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
12648 window_box_text_cols. delete_all_subwindows now takes a
12649 Lisp_Object as argument.
abde8f8c 12650
640c8776
SM
12651 * indent.c (compute_motion, Fcompute_motion):
12652 Use window_body_cols instead of window_box_text_cols.
abde8f8c 12653
fa8a67e6
MR
12654 * frame.c (delete_frame): Call delete_all_subwindows with root
12655 window as argument.
12656
a54e3482
DC
126572011-06-07 Daniel Colascione <dan.colascione@gmail.com>
12658
12659 * fns.c (Fputhash): Document return value.
12660
60002bf5
CY
126612011-06-06 Chong Yidong <cyd@stupidchicken.com>
12662
12663 * image.c (gif_load): Implement gif89a spec "no disposal" method.
12664
0c671da6 126652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 12666
b862a52a 12667 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 12668
be44ca6c
PE
12669 Check for overflow when converting integer to cons and back.
12670 * charset.c (Fdefine_charset_internal, Fdecode_char):
12671 Use cons_to_unsigned to catch overflow.
12672 (Fencode_char): Use INTEGER_TO_CONS.
12673 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
12674 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
12675 * data.c (long_to_cons, cons_to_long): Remove.
12676 (cons_to_unsigned, cons_to_signed): New functions.
12677 These signal an error for invalid or out-of-range values.
12678 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
12679 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
12680 * font.c (Ffont_variation_glyphs):
12681 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
12682 * lisp.h: Include <intprops.h>.
12683 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
12684 (cons_to_signed, cons_to_unsigned): New decls.
12685 (long_to_cons, cons_to_long): Remove decls.
12686 * undo.c (record_first_change): Use INTEGER_TO_CONS.
12687 (Fprimitive_undo): Use CONS_TO_INTEGER.
12688 * xfns.c (Fx_window_property): Likewise.
12689 * xselect.c: Include <limits.h>.
12690 (x_own_selection, selection_data_to_lisp_data):
12691 Use INTEGER_TO_CONS.
12692 (x_handle_selection_request, x_handle_selection_clear)
12693 (x_get_foreign_selection, Fx_disown_selection_internal)
12694 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
12695 (lisp_data_to_selection_data): Use cons_to_unsigned.
12696 (x_fill_property_data): Use cons_to_signed.
12697 Report values out of range.
12698
d1f3d2af
PE
12699 Check for buffer and string overflow more precisely.
12700 * buffer.h (BUF_BYTES_MAX): New macro.
12701 * lisp.h (STRING_BYTES_MAX): New macro.
12702 * alloc.c (Fmake_string):
12703 * character.c (string_escape_byte8):
12704 * coding.c (coding_alloc_by_realloc):
12705 * doprnt.c (doprnt):
12706 * editfns.c (Fformat):
12707 * eval.c (verror):
12708 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
12709 since they may not be the same number.
12710 * editfns.c (Finsert_char):
12711 * fileio.c (Finsert_file_contents):
12712 Likewise for BUF_BYTES_MAX.
12713
dd52fcea
PE
12714 * image.c: Use ptrdiff_t, not int, for sizes.
12715 (slurp_file): Switch from int to ptrdiff_t.
12716 All uses changed.
12717 (slurp_file): Check that file size fits in both size_t (for
12718 malloc) and ptrdiff_t (for sanity and safety).
12719
7f9bbdbb
PE
12720 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
12721 if b->modtime has its maximal value.
12722
dfe18f82
PE
12723 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
12724
84acfcf0
PE
12725 Don't assume time_t can fit into int.
12726 * buffer.h (struct buffer.modtime): Now time_t, not int.
12727 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
12728 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
12729
ccd9a01a
PE
12730 Minor fixes for signed vs unsigned integers.
12731 * character.h (MAYBE_UNIFY_CHAR):
12732 * charset.c (maybe_unify_char):
12733 * keyboard.c (read_char, reorder_modifiers):
12734 XINT -> XFASTINT, since the integer must be nonnegative.
12735 * ftfont.c (ftfont_spec_pattern):
12736 * keymap.c (access_keymap, silly_event_symbol_error):
12737 XUINT -> XFASTINT, since the integer must be nonnegative.
12738 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
12739 since it makes no difference and we prefer signed.
12740 * keyboard.c (record_char): Use XUINT when all the neighbors do.
12741 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
12742 nonnegative.
12743
d6d100dd
SM
127442011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
12745
12746 * window.h (Fwindow_frame): Declare.
12747
2b6148e4
PE
127482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12749
12750 * alloc.c: Simplify handling of large-request failures (Bug#8800).
12751 (SPARE_MEMORY): Always define.
12752 (LARGE_REQUEST): Remove.
12753 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
12754
f230ecc9
MR
127552011-06-06 Martin Rudalics <rudalics@gmx.at>
12756
727e958e
MR
12757 * lisp.h: Move EXFUNS for Fframe_root_window,
12758 Fframe_first_window and Fset_frame_selected_window to window.h.
12759
12760 * window.h: Move EXFUNS for Fframe_root_window,
12761 Fframe_first_window and Fset_frame_selected_window here from
12762 lisp.h.
12763
12764 * frame.c (Fwindow_frame, Fframe_first_window)
12765 (Fframe_root_window, Fframe_selected_window)
12766 (Fset_frame_selected_window): Move to window.c.
12767 (Factive_minibuffer_window): Move to minibuf.c.
12768 (Fother_visible_frames_p): New function.
12769
12770 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
12771
f230ecc9
MR
12772 * window.c (decode_window, decode_any_window): Move up in code.
12773 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
12774 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
12775 (Fwindow_buffer): Move up and rewrite doc-string.
12776 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
12777 (Fwindow_prev): New functions.
727e958e
MR
12778 (Fwindow_frame): Move here from frame.c. Accept any window as
12779 argument.
12780 (Fframe_root_window, Fframe_first_window)
12781 (Fframe_selected_window): Move here from frame.c. Accept frame
12782 or arbitrary window as argument. Update doc-strings.
12783 (Fminibuffer_window): Move up in code.
12784 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
12785 (Fset_frame_selected_window): Move here from frame.c.
12786 Marginal rewrite.
727e958e
MR
12787 (Fselected_window, select_window, Fselect_window): Move up in
12788 code. Minor doc-string fixes.
f230ecc9 12789
4d09bcf6
PE
127902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12791
12792 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
12793 Do not assume that spare memory exists; that assumption is valid
12794 only if SYSTEM_MALLOC.
12795 (LARGE_REQUEST): New macro, so that the issue of large requests
12796 is separated from the issue of spare memory.
12797
810928a2
AS
127982011-06-05 Andreas Schwab <schwab@linux-m68k.org>
12799
172418ad
AS
12800 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
12801 format. (Bug#8806)
12802
43f862f7
AS
12803 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
12804
810928a2
AS
12805 * xfns.c (x_set_scroll_bar_default_width): Move declarations
12806 before statements.
12807
a059fe24
JD
128082011-06-05 Jan Djärv <jan.h.d@swipnet.se>
12809
12810 * gtkutil.c (xg_get_default_scrollbar_width): New function.
12811
12812 * gtkutil.h: Declare xg_get_default_scrollbar_width.
12813
12814 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
12815 min width by calling x_set_scroll_bar_default_width (Bug#8505).
12816
989bf368
JB
128172011-06-05 Juanma Barranquero <lekktu@gmail.com>
12818
12819 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
12820
4b80f674
CY
128212011-06-04 Chong Yidong <cyd@stupidchicken.com>
12822
12823 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
12824 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
12825 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
12826 New error handlers.
4b80f674
CY
12827 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
12828 Obey Vx_select_enable_clipboard_manager. Catch errors in
12829 x_clipboard_manager_save (Bug#8779).
12830 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 12831 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 12832
99a33b77 128332011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
12834
12835 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
12836
99a33b77 128372011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
12838
12839 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
12840 in the current matrix if keep_current_p is non-zero.
12841
8264569d
EZ
128422011-06-04 Eli Zaretskii <eliz@gnu.org>
12843
12844 * bidi.c (bidi_level_of_next_char): Fix last change.
12845
57f97249
EZ
128462011-06-03 Eli Zaretskii <eliz@gnu.org>
12847
fec2107c 12848 Support bidi reordering of text covered by display properties.
57f97249 12849
fec2107c
EZ
12850 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
12851 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
12852 (bidi_cache_search, bidi_cache_iterator_state)
12853 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
12854 (bidi_level_of_next_char, bidi_move_to_visually_next):
12855 Support character positions inside a run of characters covered by a
fec2107c
EZ
12856 display string.
12857 (bidi_paragraph_init, bidi_resolve_explicit_1)
12858 (bidi_level_of_next_char): Call bidi_fetch_char and
12859 bidi_fetch_char_advance instead of FETCH_CHAR and
12860 FETCH_CHAR_ADVANCE.
12861 (bidi_init_it): Initialize new members.
12862 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
12863 definitions.
12864 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
12865 instead of using explicit *_CHAR codes.
d6d100dd
SM
12866 (bidi_resolve_explicit, bidi_resolve_weak):
12867 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
12868 bidirectional text is supported only in multibyte buffers.
12869 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
12870 it to initialize the frame_window_p member of struct bidi_it.
12871 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
12872 (bidi_resolve_explicit, bidi_resolve_weak)
12873 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
12874 bidi_it->nchars is non-positive.
12875 (bidi_level_of_next_char): Don't try to lookup the cache for the
12876 next/previous character if nothing is cached there yet, or if we
12877 were just reseat()'ed to a new position.
c40e2fb2 12878
0e14fe90
EZ
12879 * xdisp.c (set_cursor_from_row): Set start and stop points
12880 according to the row's direction when priming the loop that looks
12881 for the glyph on which to display cursor.
12882 (single_display_spec_intangible_p): Function deleted.
12883 (display_prop_intangible_p): Reimplement to call
12884 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
12885 Accept 3 additional arguments needed by handle_display_spec.
12886 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
12887 values: lists, `(when COND...)' forms, etc.
12888 (single_display_spec_string_p): Support property values that are
12889 lists with the argument STRING its top-level element.
12890 (display_prop_string_p): Fix the condition for processing a
12891 property that is a list to be consistent with handle_display_spec.
fec2107c 12892 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
12893 last portion of handle_display_prop.
12894 (compute_display_string_pos): Accept additional argument
12895 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
12896 value of a `display' property is a "replacing spec".
12897 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
12898 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
12899 the display property, but just return a value indicating whether
12900 the display property will replace the characters it covers.
12901 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
12902 frame_window_p members of struct bidi_it.
d6d100dd
SM
12903 (compute_display_string_pos, compute_display_string_end):
12904 New functions.
fec2107c
EZ
12905 (push_it): Accept second argument POSITION, where pop_it should
12906 jump to continue iteration.
12907 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 12908
fec2107c
EZ
12909 * keyboard.c (adjust_point_for_property): Adjust the call to
12910 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
12911
12912 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
12913 (bidi_init_it): Update prototypes.
12914 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
12915 (compute_display_string_pos, compute_display_string_end):
12916 Declare prototypes.
fec2107c
EZ
12917 (struct bidi_it): New members nchars and disp_pos. ch_len is now
12918 EMACS_INT.
fc6f18ce 12919
40087514 129202011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 12921
57f53182
PE
12922 Malloc failure behavior now depends on size of allocation.
12923 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
12924 * lisp.h: Change signatures accordingly.
12925 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
12926 All callers changed. (Bug#8762)
12927
12928 * gnutls.c: Use Emacs's memory allocators.
12929 Without this change, the gnutls library would invoke malloc etc.
12930 directly, which causes problems on non-SYNC_INPUT hosts, and which
12931 runs afoul of improving memory_full behavior. (Bug#8761)
12932 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
12933 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
12934 xfree instead of the default malloc, realloc, free.
12935 (Fgnutls_boot): No need to check for memory allocation failure,
12936 since xmalloc does that for us.
12937
ac32cd99 12938 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
12939 * category.c (hash_get_category_set):
12940 * ccl.c (ccl_driver):
12941 * charset.c (Fdefine_charset_internal):
12942 * charset.h (struct charset.hash_index):
12943 * composite.c (get_composition_id, gstring_lookup_cache)
12944 (composition_gstring_put_cache):
12945 * composite.h (struct composition.hash_index):
12946 * dispextern.h (struct image.hash):
12947 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
12948 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
12949 (hashfn_equal, hashfn_user_defined, make_hash_table)
12950 (maybe_resize_hash_table, hash_lookup, hash_put)
12951 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
12952 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
12953 (Fsxhash, Fgethash, Fputhash, Fmaphash):
12954 * image.c (make_image, search_image_cache, lookup_image)
12955 (xpm_put_color_table_h):
12956 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 12957 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 12958 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 12959 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
12960 * alloc.c (allocate_vectorlike):
12961 Check for overflow in vector size calculations.
12962 * ccl.c (ccl_driver):
12963 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
12964 * fns.c, image.c: Remove unnecessary static decls that would otherwise
12965 need to be updated by these changes.
40087514
PE
12966 * fns.c (make_hash_table, maybe_resize_hash_table):
12967 Check for integer overflow with large hash tables.
0de4bb68
PE
12968 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
12969 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
12970 (SXHASH_REDUCE): New macro.
12971 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
12972 Use it instead of discarding useful hash info with large hash values.
12973 (sxhash_float): New function.
12974 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
12975 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
12976 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
12977 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
12978 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
12979 Adjust signatures to match updated version of code.
12980 (consing_since_gc): Now EMACS_INT, since a single hash table can
12981 use more than INT_MAX bytes.
12982
698d32e2
DN
129832011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
12984
12985 Make it possible to build with GCC-4.6+ -O2 -flto.
12986
12987 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
12988
fd6fa53f
SM
129892011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
12990
12991 * minibuf.c (get_minibuffer, read_minibuf_unwind):
12992 Call minibuffer-inactive-mode.
12993
864db017
JB
129942011-05-31 Juanma Barranquero <lekktu@gmail.com>
12995
12996 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
12997 Update dependencies.
12998
2ad0baf4
DN
129992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13000
13001 * data.c (init_data): Remove code for UTS, this system is not
13002 supported anymore.
13003
4fcc2638
DN
130042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13005
13006 Don't force ./temacs to start in terminal mode.
13007
13008 * frame.c (make_initial_frame): Initialize faces in all cases, not
13009 only when CANNOT_DUMP is defined.
13010 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
13011
c56e0fd5
DN
130122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13013
13014 * dispnew.c (add_window_display_history): Use const for the string
13015 pointer. Remove declaration, not needed.
13016
333d54da 130172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 13018
55d4c1b2 13019 Use 'inline', not 'INLINE'.
333d54da 13020 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
13021 * alloc.c, fontset.c (INLINE): Remove.
13022 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
13023 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
13024 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
13025 * gmalloc.c (register_heapinfo): Use inline unconditionally.
13026 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
13027
738db178
DN
130282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13029
13030 Make it possible to run ./temacs.
13031
13032 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
13033 syms_of_callproc does the same thing. Remove test for
13034 "initialized", do it in the caller.
13035 * emacs.c (main): Avoid calling set_initial_environment when dumping.
13036
620c53a6
SM
130372011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
13038
13039 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
13040 (read_minibuf): Use get_minibuffer.
13041 (syms_of_minibuf): Use DEFSYM.
13042 (Qmetadata): New var.
13043 * data.c (Qbuffer): Don't make it static.
13044 (syms_of_data): Use DEFSYM.
13045
e003a292
PE
130462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
13047
13048 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
13049 (CCL_CODE_MIN): New macro.
13050
ed008a6d
PE
130512011-05-30 Paul Eggert <eggert@cs.ucla.edu>
13052
3687c2ef
PE
13053 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
13054
ed008a6d
PE
13055 * eval.c (Qdebug): Now static.
13056 * lisp.h (Qdebug): Remove decl. This reverts a part of the
13057 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
13058 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
13059
d66c4c7c
CY
130602011-05-29 Chong Yidong <cyd@stupidchicken.com>
13061
13062 * image.c: Various fixes to ImageMagick code comments.
13063 (Fimagemagick_types): Doc fix.
13064
5fbc2025
PE
130652011-05-29 Paul Eggert <eggert@cs.ucla.edu>
13066
0196f88a
PE
13067 Minor fixes prompted by GCC 4.6.0 warnings.
13068
13069 * xselect.c (converted_selections, conversion_fail_tag): Now static.
13070
5fbc2025
PE
13071 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
13072 (x_clipboard_manager_save_all): Move extern decl to ...
13073 * xterm.h: ... here, so that it can be checked for consistency.
13074
1dd3c2d9
CY
130752011-05-29 Chong Yidong <cyd@stupidchicken.com>
13076
13077 * xselect.c (x_clipboard_manager_save_frame)
13078 (x_clipboard_manager_save_all): New functions.
13079 (Fx_clipboard_manager_save): Lisp function deleted.
13080
13081 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
13082 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
13083
13084 * xterm.h: Update prototype.
13085
5ba6571d
WX
130862011-05-28 William Xu <william.xwl@gmail.com>
13087
13088 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
13089 exiting (Bug#8239).
13090
3eaff834
JM
130912011-05-28 Jim Meyering <meyering@redhat.com>
13092
e1900994 13093 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
13094 * fns.c (to_uchar): Define.
13095 (crypto_hash_function): Use it to convert some newly-signed
13096 variables to unsigned, to avoid sign-extension bugs. For example,
13097 without this change, (md5 "truc") would evaluate to
13098 45723a2aff78ff4fff7fff1114760e62 rather than the expected
13099 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 13100 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 13101
0f6990a7
PE
131022011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13103
13104 Integer overflow fixes.
c8a9ca5a 13105
08686060
PE
13106 * dbusbind.c: Serial number integer overflow fixes.
13107 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
13108 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
13109 to hold a serial number that is too large for a fixnum.
13110 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13111 Check for serial numbers out of range. Decode any serial number
59568bf0 13112 that was so large that it became a float. (Bug#8722)
08686060 13113
2d1fc3c7
PE
13114 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
13115 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13116 Use XFASTINT rather than XUINT when numbers are nonnegative.
13117 (xd_append_arg, Fdbus_method_return_internal):
13118 (Fdbus_method_error_internal): Likewise. Also, for unsigned
13119 arguments, check that Lisp number is nonnegative, rather than
59568bf0 13120 silently wrapping negative numbers around. (Bug#8722)
30217ff0 13121 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 13122 (Bug#8722)
2d1fc3c7 13123
c8a9ca5a
PE
13124 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
13125
519e1d69
PE
13126 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
13127
6df6ae42 13128 ccl: Add integer overflow checks.
30569699
PE
13129 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
13130 (IN_INT_RANGE): New macros.
13131 (ccl_driver): Use them to check for integer overflow when
13132 decoding a CCL program. Many of the new checks are whether XINT (x)
13133 fits in int; it doesn't always, on 64-bit hosts. The new version
13134 doesn't catch all possible integer overflows, but it's an
847044ea 13135 improvement. (Bug#8719)
30569699 13136
c11285dc
PE
13137 * alloc.c (make_event_array): Use XINT, not XUINT.
13138 There's no need for unsigned here.
13139
fdccd48e
PE
13140 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
13141 This follows up to the 2011-05-06 change that substituted uintptr_t
13142 for EMACS_INT. This case wasn't caught back then.
13143
37910ab2
PE
13144 Rework Fformat to avoid integer overflow issues.
13145 * editfns.c: Include <float.h> unconditionally, as it's everywhere
13146 now (part of C89). Include <verify.h>.
13147 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
13148 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
13149 (Fformat): Avoid the prepass trying to compute sizes; it was only
13150 approximate and thus did not catch overflow reliably. Instead, walk
13151 through the format just once, formatting and computing sizes as we go,
13152 checking for integer overflow at every step, and allocating a larger
13153 buffer as needed. Keep track separately whether the format is
13154 multibyte. Keep only the most-recently calculated precision, rather
13155 than them all. Record whether each argument has been converted to
13156 string. Use EMACS_INT, not int, for byte and char and arg counts.
13157 Support field widths and precisions larger than INT_MAX. Avoid
13158 sprintf's undefined behavior with conversion specifications such as %#d
13159 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
13160 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
13161 formatting out-of-range floating point numbers with int
9173deec 13162 formats. (Bug#8668)
37910ab2 13163
2e6578fb
PE
13164 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
13165
0ae6bdee
PE
13166 * data.c: Avoid integer truncation in expressions involving floats.
13167 * data.c: Include <intprops.h>.
13168 (arith_driver): When there's an integer overflow in an expression
13169 involving floating point, convert the integers to floating point
13170 so that the resulting value does not suffer from catastrophic
13171 integer truncation. For example, on a 64-bit host (* 4
13172 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
13173 Do not rely on undefined behavior after integer overflow.
13174
de883a70
PE
13175 merge count_size_as_multibyte, parse_str_to_multibyte
13176 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 13177 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
13178 Check for integer overflow.
13179 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
13180 since it's now a duplicate of the other. This is more of
13181 a character than a buffer op, so better that it's in character.c.
13182 * fns.c, print.c: Adjust to above changes.
13183
2ff916cb
PE
131842011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
13185
13186 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
13187
f1b54466
PE
131882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13189
fb1ac845
PE
13190 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13191 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
13192 (x_clipboard_manager_save): Now static.
13193 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
13194
f1b54466
PE
13195 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13196 (crypto_hash_function): Now static.
13197 Fix pointer signedness problems. Avoid unnecessary initializations.
13198
a9f737ee
CY
131992011-05-27 Chong Yidong <cyd@stupidchicken.com>
13200
13201 * termhooks.h (Vselection_alist): Make it terminal-local.
13202
13203 * terminal.c (create_terminal): Initialize it.
13204
13205 * xselect.c: Support for clipboard managers.
13206 (Vselection_alist): Move to termhooks.h as terminal-local var.
13207 (LOCAL_SELECTION): New macro.
13208 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
13209 (symbol_to_x_atom): Remove gratuitous arg.
13210 (x_handle_selection_request, lisp_data_to_selection_data)
13211 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
13212 (x_own_selection, x_get_local_selection, x_convert_selection):
13213 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
13214 (some_frame_on_display): Delete unused function.
13215 (Fx_own_selection_internal, Fx_get_selection_internal)
13216 (Fx_disown_selection_internal, Fx_selection_owner_p)
13217 (Fx_selection_exists_p): New optional frame arg.
13218 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
13219 (x_handle_selection_clear): Don't treat other terminals with the
13220 same keyboard specially. Use the terminal-local Vselection_alist.
13221 (x_clear_frame_selections): Use Frun_hook_with_args.
13222
13223 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
13224
13225 * xterm.h: Add support for those atoms.
13226
e067f0c1
CY
132272011-05-26 Chong Yidong <cyd@stupidchicken.com>
13228
13229 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
13230 (converted_selections, conversion_fail_tag): New global variables.
13231 (x_selection_request_lisp_error): Free the above.
13232 (x_get_local_selection): Remove unnecessary code.
13233 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
13234 of converted selections stored in converted_selections.
13235 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
13236 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
13237 (x_convert_selection): New function.
13238 (x_handle_selection_event): Simplify.
13239 (x_get_foreign_selection): Don't ignore incoming requests while
13240 waiting for an answer; this will fail when we implement
13241 SAVE_TARGETS, and seems unnecessary anyway.
13242 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
13243 (Vx_sent_selection_functions): Doc fix.
13244
0f4aebc0
LL
132452011-05-26 Leo Liu <sdl.web@gmail.com>
13246
13247 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
13248
e61124cd
YM
132492011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13250
13251 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
13252
13253 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
13254 for fringe update if it has periodic bitmap.
ac389d0c 13255 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
13256 and fringe_bitmap_periodic_p.
13257
13258 * fringe.c (get_fringe_bitmap_data): New function.
13259 (draw_fringe_bitmap_1, update_window_fringes): Use it.
13260 (update_window_fringes): Record periodicity of fringe bitmap in glyph
13261 row. Mark glyph row for fringe update if periodicity changed.
13262
13263 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
13264 for fringe update unless it has periodic bitmap.
13265
f16d9837
KH
132662011-05-25 Kenichi Handa <handa@m17n.org>
13267
13268 * xdisp.c (get_next_display_element): Set correct it->face_id for
13269 a static composition.
13270
e1b90ef6
LL
132712011-05-24 Leo Liu <sdl.web@gmail.com>
13272
13273 * deps.mk (fns.o):
13274 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
13275
13276 * fns.c (crypto_hash_function, Fsha1): New function.
13277 (Fmd5): Use crypto_hash_function.
13278 (syms_of_fns): Add Ssha1.
13279
7400048f
PE
132802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13281
13282 * gnutls.c: Remove unused macros.
13283 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
13284 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
13285 Remove macros that are defined and never used.
13286 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
13287
abb71cf4
CY
132882011-05-22 Chong Yidong <cyd@stupidchicken.com>
13289
13290 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
13291 (Fx_get_selection_internal): Minor cleanup.
13292 (Fx_own_selection_internal): Rename arguments for consistency with
13293 select.el.
13294
6307db39
PE
132952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13296
13297 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
13298
f3d4e0a4
CY
132992011-05-22 Chong Yidong <cyd@stupidchicken.com>
13300
13301 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
13302
4d8ade89
YM
133032011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13304
13305 * dispnew.c (scrolling_window): Don't exclude the case that the
13306 last enabled row in the desired matrix touches the bottom boundary.
13307
32078c8d
GM
133082011-05-21 Glenn Morris <rgm@gnu.org>
13309
13310 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
13311 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
13312 and add some more files.
32078c8d 13313
7285dc67
EZ
133142011-05-20 Eli Zaretskii <eliz@gnu.org>
13315
13316 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
13317 report_file_error introduced by the change from 2011-05-07.
13318
89d1bd22
PE
133192011-05-20 Paul Eggert <eggert@cs.ucla.edu>
13320
13321 * systime.h (Time): Define only if emacs is defined.
13322 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
13323 where the include path doesn't have X11/X.h by default. See
13324 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
13325
cd394be1 133262011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
13327
13328 * composite.c (find_automatic_composition): Fix previous change.
13329
b9704ad9
GM
133302011-05-20 Glenn Morris <rgm@gnu.org>
13331
13332 * lisp.mk: New file, split from Makefile.in.
13333 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
13334 (shortlisp): Remove.
13335 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
13336
4a720484
GM
133372011-05-19 Glenn Morris <rgm@gnu.org>
13338
13339 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
13340 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
13341 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
13342 (lisp): Set the order to that of loadup.el.
13343 (shortlisp): Make it a copy of $lisp.
13344 (SOME_MACHINE_LISP): Remove.
13345 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
13346 Use just $shortlisp, not $SOME_MACHINE_LISP too.
13347
a28d4396
KH
133482011-05-18 Kenichi Handa <handa@m17n.org>
13349
13350 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
13351 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
13352 (find_automatic_composition): Mostly rewrite for efficiency.
13353
a2b1fa8e
JB
133542011-05-18 Juanma Barranquero <lekktu@gmail.com>
13355
13356 * makefile.w32-in: Update dependencies.
13357
8e1f5610
CS
133582011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
13359
13360 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 13361 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 13362
7025ee00 133632011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 13364
cdfa6eab
PE
13365 Fix some integer overflow issues, such as string length overflow.
13366
06d6db33
PE
13367 * insdel.c (count_size_as_multibyte): Check for string overflow.
13368
2b4560a8
PE
13369 * character.c (lisp_string_width): Check for string overflow.
13370 Use EMACS_INT, not int, for string indexes and lengths; in
13371 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
13372 the resulting string length overflows an EMACS_INT; instead,
13373 report a string overflow if no precision given. When checking for
13374 precision exhaustion, use a check that cannot possibly have
13375 integer overflow. (Bug#8675)
13376 * character.h (lisp_string_width): Adjust to new signature.
13377
cb93f9be
PE
13378 * alloc.c (string_overflow): New function.
13379 (Fmake_string): Use it. This doesn't change behavior, but saves
13380 a few bytes and will simplify future changes.
13381 * character.c (string_escape_byte8): Likewise.
13382 * lisp.h (string_overflow): New decl.
13383
1a1f3366
PE
13384 Fixups, following up to the user-interface timestamp change.
13385 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
13386 for UI timestamps, instead of unsigned long.
9fbd6841
PE
13387 * msdos.c (mouse_get_pos): Likewise.
13388 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
13389 * w32gui.h (Time): Define by including "systime.h" rather than by
13390 declaring it ourselves. (Bug#8664)
13391
d4e3e4d3
PE
13392 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
13393 * image.c (clear_image_cache): Likewise.
13394
f6a24d19
PE
13395 * term.c (term_mouse_position): Don't assume time_t wraparound.
13396
08dc5ae6
PE
13397 Be more systematic about user-interface timestamps.
13398 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
13399 and sometimes 'EMACS_UINT', to represent these timestamps.
13400 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
13401 This makes the code easier to follow, and makes it easier to catch
13402 integer overflow bugs such as Bug#8664.
13403 * frame.c (Fmouse_position, Fmouse_pixel_position):
13404 Use Time, not unsigned long, for user-interface timestamps.
13405 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
13406 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
13407 * keyboard.h (last_event_timestamp): Likewise.
13408 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
13409 * menu.h (xmenu_show): Likewise.
13410 * term.c (term_mouse_position): Likewise.
13411 * termhooks.h (struct input_event.timestamp): Likewise.
13412 (struct terminal.mouse_position_hook): Likewise.
13413 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
13414 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
13415 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
13416 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
13417 what it was before.
13418 * menu.h, termhooks.h: Include "systime.h", for Time.
13419
8e55734a
PE
13420 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
13421 Don't assume that the difference between two unsigned long values
13422 can fit into an integer. At this point, we know button_down_time
13423 <= event->timestamp, so the difference must be nonnegative, so
13424 there's no need to cast the result if double-click-time is
13425 nonnegative, as it should be; check that it's nonnegative, just in
13426 case. This bug is triggered when events are more than 2**31 ms
86db42d2 13427 apart (about 25 days). (Bug#8664)
8e55734a 13428
841f1b75 13429 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 13430 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 13431
3e26f69c
PE
13432 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
13433 that always fit in int. Use a sentinel instead of a counter, to
13434 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
13435 * frame.h (struct frame): Use int for menu_bar_items_used
13436 instead of EMACS_INT, since it always fits in int.
3e26f69c 13437
5cc152c0
PE
13438 * menu.c (grow_menu_items): Check for int overflow.
13439
d89eb65e
PE
13440 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
13441
5235bd3e
PE
13442 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
13443 Before, the code was not consistent. These values cannot exceed
13444 2**31 - 1 so there's no need to make them unsigned.
13445 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
13446 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
13447 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
13448 as modifiers.
13449 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
13450
bc827e23
PE
13451 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
13452 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
13453 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
13454 presumably because the widths might not match.
13455
78eb494e
PE
13456 * window.c (size_window): Avoid needless test at loop start.
13457
04f2d78b
CB
134582011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
13459
13460 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
13461
d2fc7e3d 134622011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
13463
13464 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
13465
d2fc7e3d 134662011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
13467
13468 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
13469 `width' to `bar_area_x' and `bar_area_width', respectively.
13470 (x_scroll_run): Take account of fringe background extension.
13471
04f2d78b
CB
13472 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
13473 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
13474 `bar_area_width', respectively.
13475 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
13476 background extension.
13477
79b70037
GM
134782011-05-10 Jim Meyering <meyering@redhat.com>
13479
13480 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
13481
2f142cc5
JB
134822011-05-10 Juanma Barranquero <lekktu@gmail.com>
13483
13484 * image.c (Finit_image_library): Return t for built-in image types,
13485 like pbm and xbm. (Bug#8640)
13486
57679c86
AS
134872011-05-09 Andreas Schwab <schwab@linux-m68k.org>
13488
13489 * w32menu.c (set_frame_menubar): Fix submenu allocation.
13490
888c9e86
EZ
134912011-05-07 Eli Zaretskii <eliz@gnu.org>
13492
b0512a1d
EZ
13493 * w32console.c (Fset_screen_color): Doc fix.
13494 (Fget_screen_color): New function.
13495 (syms_of_ntterm): Defsubr it.
13496
7285dc67
EZ
13497 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
13498 unlink the temporary file if Fcall_process didn't create it in the
13499 first place.
13500 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
13501 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
13502 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
13503 cue to call_process_cleanup not to close that handle.
13504
4d3fcc8e
BK
135052011-05-07 Ben Key <bkey76@gmail.com>
13506
13507 * makefile.w32-in: The bootstrap-temacs rule now makes use of
13508 one of two shell specific rules, either bootstrap-temacs-CMD or
13509 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
13510 to the previous implementation of the bootstrap-temacs rule.
13511 The bootstrap-temacs-CMD rule is similar to the previous
13512 implementation of the bootstrap-temacs rule except that it
13513 makes use of the ESC_CFLAGS variable instead of the CFLAGS
13514 variable.
13515
13516 These changes, along with some changes to nt/configure.bat,
13517 nt/gmake.defs, and nt/nmake.defs, are required to extend my
13518 earlier fix to add support for --cflags and --ldflags options
13519 that include quotes so that it works whether make uses cmd or
13520 sh as the shell.
13521
b4289b64
MA
135222011-05-06 Michael Albinus <michael.albinus@gmx.de>
13523
13524 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
13525 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
13526 is a constant.
13527 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
13528 a string. Handle both cases.
13529 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
13530 (Fdbus_register_method): Use Qinvalid_function.
13531
af4c0e28
JB
135322011-05-06 Juanma Barranquero <lekktu@gmail.com>
13533
13534 * makefile.w32-in: Update dependencies.
13535 (LISP_H): Add inttypes.h and stdin.h.
13536 (PROCESS_H): Add unistd.h.
13537
c51453d9
EZ
135382011-05-06 Eli Zaretskii <eliz@gnu.org>
13539
13540 * lread.c: Include limits.h (fixes the MS-Windows build broken by
13541 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
13542
8ff0ac3c 135432011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 13544
4c4b566b
PE
13545 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
13546
aab2b9b5
PE
13547 * term.c (vfatal): Remove stray call to va_end.
13548 It's not needed and the C Standard doesn't allow it here anyway.
13549
c378da0b
PE
13550 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
13551 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
13552
288b08c7
PE
13553 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
13554 bytes.
13555
e3601888
PE
13556 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
13557
db6c0e74
PE
13558 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
13559
dd5963ea
PE
13560 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
13561
88c9450f
PE
13562 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
13563
2f9442b8
PE
13564 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
13565
c032b5f8
PE
13566 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
13567 * charset.c (Fdefine_charset_internal): Don't initialize
13568 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 13569 32-bit int (Bug#8600).
a108c10b
PE
13570
13571 * lread.c (read_integer): Be more consistent with string-to-number.
13572 Use string_to_number to do the actual conversion; this avoids
13573 rounding errors and fixes some other screwups. Without this fix,
13574 for example, #x1fffffffffffffff was misread as -2305843009213693952.
13575 (digit_to_number): Move earlier, for benefit of read_integer.
13576 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 13577 not a digit in any supported base. (Bug#8602)
a108c10b 13578
ad5f9eea
PE
13579 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
13580
aec1708a
PE
13581 * dispnew.c (scrolling_window): Return 1 if we scrolled,
13582 to match comment at start of function. This also removes a
13583 GCC warning about overflow in a 32+64-bit port.
13584
47be4ab5
PE
13585 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
13586
371cac43
PE
13587 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
13588 Reported by Stefan Monnier in
13589 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
13590 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13591 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 13592
d01a7826
PE
13593 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
13594 (EMACS_UINTPTR): Likewise, with uintptr_t.
13595
7fd47d5c
PE
13596 * lisp.h: Prefer 64-bit EMACS_INT if available.
13597 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
13598 on 32-bit hosts that have 64-bit int, so that they can access
13599 large files.
122b0c86
PE
13600 However, temporarily disable this change unless the temporary
13601 symbol WIDE_EMACS_INT is defined.
7fd47d5c 13602
8727937b
PE
13603 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
13604
8ac068ac
PE
13605 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
13606 This removes an assumption that EMACS_INT and long are the same
13607 width as pointers. The assumption is true for Emacs porting targets
13608 now, but we want to make other targets possible.
13609 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
13610 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
13611 In the rest of the code, change types of integers that hold casted
13612 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
13613 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
13614 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
13615 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
13616 No need to cast type when ORing.
13617 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
13618 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
13619 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
13620 assume EMACS_INT is the same width as char *.
13621 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
13622 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
13623 Remove no-longer-needed casts.
13624 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
13625 (xg_tool_bar_help_callback, xg_make_tool_item):
13626 Use EMACS_INTPTR to hold an integer
13627 that will be cast to void *; this can avoid a GCC warning
13628 if EMACS_INT is not the same width as void *.
13629 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
13630 * xdisp.c (display_echo_area_1, resize_mini_window_1):
13631 (current_message_1, set_message_1):
13632 Use a local to convert to proper width without a cast.
13633 * xmenu.c (dialog_selection_callback): Likewise.
13634
ede49d71
PE
13635 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
13636 Also, don't assume VALBITS / RAND_BITS is less than 5,
13637 and don't rely on undefined behavior when shifting a 1 left into
13638 the sign bit.
13639 * lisp.h (get_random): Change signature to match.
13640
2f30ecd0
PE
13641 * lread.c (hash_string): Use size_t, not int, for hash computation.
13642 Normally we prefer signed values; but hashing is special, because
13643 it's better to use unsigned division on hash table sizes so that
13644 the remainder is nonnegative. Also, size_t is the natural width
13645 for hashing into memory. The previous code used 'int', which doesn't
13646 retain enough info to hash well into very large tables.
13647 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
13648
2a866e7b
PE
13649 * dbusbind.c: Don't possibly lose pointer info when converting.
13650 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13651 Use XPNTR rather than XHASH, so that the high-order bits of
13652 the pointer aren't lost when converting through void *.
13653
51639eac
PE
13654 * eval.c (Fautoload): Don't double-shift a pointer.
13655
92394119
PE
13656 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
13657
dbdb9a7c
JB
136582011-05-06 Juanma Barranquero <lekktu@gmail.com>
13659
13660 * gnutls.c (DEF_GNUTLS_FN):
13661 * image.c (DEF_IMGLIB_FN): Make function pointers static.
13662
db7a0b4f
AS
136632011-05-05 Andreas Schwab <schwab@linux-m68k.org>
13664
13665 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
13666 marker. (Bug#8610)
13667
cd394be1 136682011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
13669
13670 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
13671 New version that can reserve upto 2GB of heap space.
13672
f7ff1b0f 136732011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
13674
13675 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
13676
639c109b
TZ
136772011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
13678
13679 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
13680 `gnutls_certificate_set_x509_key_file'.
13681
d2127135
JB
136822011-05-05 Juanma Barranquero <lekktu@gmail.com>
13683
13684 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
13685 Update dependencies.
13686
e968f4f3
JB
136872011-05-04 Juanma Barranquero <lekktu@gmail.com>
13688
13689 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
13690 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
13691 Remove unused parameter `fildes'.
13692 * process.c (read_process_output, send_process): Don't pass it.
13693
84d358f0
JB
136942011-05-04 Juanma Barranquero <lekktu@gmail.com>
13695
13696 Fix previous change: the library cache is defined in w32.c.
13697 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
13698 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
13699
0898ca10
JB
137002011-05-04 Juanma Barranquero <lekktu@gmail.com>
13701
13702 Implement dynamic loading of GnuTLS on Windows.
13703
13704 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
13705 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
13706 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13707 Declare.
13708
13709 * gnutls.c (Qgnutls_dll): Define.
13710 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
13711 (gnutls_*): Declare function pointers.
13712 (init_gnutls_functions): New function to initialize function pointers.
13713 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
13714 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
13715 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13716 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
13717 (emacs_gnutls_write, emacs_gnutls_read)
13718 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
13719 (Fgnutls_available_p): New function.
13720 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
13721 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
13722 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
13723
13724 * image.c: Include w32.h.
13725 (Vimage_type_cache): Delete.
13726 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
13727 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
13728 (w32_delayed_load): Move to w32.c.
13729
13730 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
13731
13732 * w32.c (QCloaded_from, Vlibrary_cache): Define.
13733 (w32_delayed_load): Move from image.c. When loading a library, record
13734 its filename in the :loaded-from property of the library id.
13735 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
13736 Initialize and staticpro them.
13737 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
13738
13739 * process.c: Include lisp.h before w32.h, not after.
13740 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
13741 instead of gnutls_record_check_pending.
13742
13743 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
13744
ff4de4aa
TZ
137452011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
13746
13747 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
13748 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
13749 as passed in.
13750
abe95abb
JD
137512011-05-03 Jan Djärv <jan.h.d@swipnet.se>
13752
13753 * xterm.c (x_set_frame_alpha): Do not set property on anything
13754 else than FRAME_X_OUTER_WINDOW (Bug#8608).
13755
e16e55d4
JB
137562011-05-02 Juanma Barranquero <lekktu@gmail.com>
13757
13758 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
13759
bafcf6a5
JB
137602011-05-02 Juanma Barranquero <lekktu@gmail.com>
13761
13762 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
13763 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
13764 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
13765 (gnutls_global_initialized, Qgnutls_bootprop_priority)
13766 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
13767 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
13768 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
13769 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
13770 (Qgnutls_bootprop_callbacks_verify): Make static.
13771
e7a6747f
AS
137722011-05-01 Andreas Schwab <schwab@linux-m68k.org>
13773
19ed11ba
AS
13774 * callproc.c: Indentation fixup.
13775
e7a6747f 13776 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
13777 (wait_for_termination, interruptible_wait_for_termination):
13778 Move after wait_for_termination_1.
e7a6747f 13779
1ef14cb4
LMI
137802011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
13781
13782 * sysdep.c (interruptible_wait_for_termination): New function
13783 which is like wait_for_termination, but allows keyboard
13784 interruptions.
13785
13786 * callproc.c (Fcall_process): Add (:file "file") as an option for
13787 the STDOUT buffer.
13788 (Fcall_process_region): Ditto.
13789
330d880c
EZ
137902011-04-30 Eli Zaretskii <eliz@gnu.org>
13791
8db90b73
EZ
13792 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
13793 rather than `XVECTOR (FOO)->size'.
13794
330d880c
EZ
13795 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
13796 inttypes.h, as a gnulib replacement is used if it not available in
13797 system headers.
13798
15cbd324
EZ
137992011-04-21 Eli Zaretskii <eliz@gnu.org>
13800
13801 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
13802 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
13803 of MOST_POSITIVE_FIXNUM. (Bug#8528)
13804
13805 * coding.c (coding_alloc_by_realloc): Error out if destination
13806 will grow beyond MOST_POSITIVE_FIXNUM.
13807 (decode_coding_emacs_mule): Abort if there isn't enough place in
13808 charbuf for the composition carryover bytes. Reserve an extra
13809 space for up to 2 characters produced in a loop.
13810 (decode_coding_iso_2022): Abort if there isn't enough place in
13811 charbuf for the composition carryover bytes.
13812
138132011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 13814
ae940cca
EZ
13815 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
13816 aborting when %lld or %lll format is passed.
13817 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
13818 %llo or %llx format is passed. (Bug#8545)
13819
03ab8921
EZ
13820 * window.c (window_scroll_line_based): Use a marker instead of
13821 simple variables to record original value of point. (Bug#7952)
13822
afda1437
EZ
13823 * doprnt.c (doprnt): Fix the case where a multibyte sequence
13824 produced by %s or %c overflows available buffer space. (Bug#8545)
13825
f76dee0c
PE
138262011-04-28 Paul Eggert <eggert@cs.ucla.edu>
13827
13828 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 13829 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 13830
fdc5744d
JB
138312011-04-28 Juanma Barranquero <lekktu@gmail.com>
13832
13833 * w32.c (init_environment): Warn about defaulting HOME to C:\.
13834
638f053a
JB
138352011-04-28 Juanma Barranquero <lekktu@gmail.com>
13836
13837 * keyboard.c (Qdelayed_warnings_hook): Define.
13838 (command_loop_1): Run `delayed-warnings-hook'
13839 if Vdelayed_warnings_list is non-nil.
13840 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
13841 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
13842
d178f871
EZ
138432011-04-28 Eli Zaretskii <eliz@gnu.org>
13844
13845 * doprnt.c (doprnt): Don't return value smaller than the buffer
13846 size if the message was truncated. (Bug#8545).
13847
b124fd93
JB
138482011-04-28 Juanma Barranquero <lekktu@gmail.com>
13849
13850 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
13851 (Fx_window_property): #if-0 the whole functions, not just the bodies.
13852
e810457d
PE
138532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13854
13855 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
13856
ea51cceb
JB
138572011-04-27 Juanma Barranquero <lekktu@gmail.com>
13858
13859 * makefile.w32-in: Update dependencies.
13860
94dcfacf
EZ
138612011-04-27 Eli Zaretskii <eliz@gnu.org>
13862
13863 Improve `doprnt' and its usage. (Bug#8545)
13864 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
13865 `format_end'. Remove support for %l as a conversion specifier.
13866 Don't use xrealloc. Improve diagnostics when the %l size modifier
13867 is used. Update the commentary.
13868
13869 * eval.c (verror): Simplify calculation of size_t.
13870
13871 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
13872 messages.
13873
f61f41d7
PE
138742011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
13875
13876 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
13877 change.
13878
96fb4434
PE
138792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13880
13881 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
13882 This makes this file independent of the recent pseudovector change.
13883
671875da 138842011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 13885
69e9b5a3
PE
13886 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
13887
b5f869a7 13888 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 13889 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 13890 Remove unused local.
c8926152 13891 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 13892
841a1577 13893 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
13894 GCC 4.6.0 optimizes based on type-based alias analysis.
13895 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
13896 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
13897 != &v->size, and therefore "v->size = 1; b->size = 2; return
13898 v->size;" must therefore return 1. This assumption is incorrect
13899 for Emacs, since it type-puns struct Lisp_Vector * with many other
13900 types. To fix this problem, this patch adds a new type struct
f904488f 13901 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
13902 and pseudovectors, and helps optimizing compilers not get fooled
13903 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
13904 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
13905 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
13906 the size member.
eab3844f
PE
13907 (XSETPVECTYPE): Rewrite in terms of new macro.
13908 (XSETPVECTYPESIZE): New macro, specifying both type and size.
13909 This is a bit clearer, and further avoids the possibility of
13910 undesirable aliasing.
13911 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 13912 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
13913 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
13914 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
13915 (ASIZE): Now uses header.size rather than size.
13916 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
13917 to avoid the hassle of writing XVECTOR (foo)->header.size.
13918 (struct vectorlike_header): New type.
eab3844f
PE
13919 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
13920 object, to help avoid aliasing.
13921 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
13922 (SUBRP): Likewise, since Lisp_Subr is a special case.
13923 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
13924 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
13925 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 13926 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
13927 changed to be "header.size" and "header.next".
13928 * buffer.h (struct buffer): Likewise.
13929 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
13930 * frame.h (struct frame): Likewise.
13931 * process.h (struct Lisp_Process): Likewise.
13932 * termhooks.h (struct terminal): Likewise.
13933 * window.c (struct save_window_data, struct saved_window): Likewise.
13934 * window.h (struct window): Likewise.
13935 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
13936 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
13937 * buffer.c (init_buffer_once): Likewise.
13938 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
13939 special case.
13940 * process.c (Fformat_network_address): Use local var for size,
13941 for brevity.
13942
0df1eac5
PE
13943 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
13944
847ab9d1 13945 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
13946 * data.c (atof): Remove decl; no longer used or needed.
13947 (digit_to_number): Move to lread.c.
13948 (Fstring_to_number): Use new string_to_number function, to be
13949 consistent with how the Lisp reader treats infinities and NaNs.
13950 Do not assume that floating-point numbers represent EMACS_INT
13951 without losing information; this is not true on most 64-bit hosts.
13952 Avoid double-rounding errors, by insisting on integers when
13953 parsing non-base-10 numbers, as the documentation specifies.
13954 * lisp.h (string_to_number): New decl, replacing ...
13955 (isfloat_string): Remove.
bc0a5c13 13956 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 13957 (read1): Do not accept +. and -. as integers; this
452f4150
PE
13958 appears to have been a coding error. Similarly, do not accept
13959 strings like +-1e0 as floating point numbers. Do not report
13960 overflow for integer overflows unless the base is not 10 which
13961 means we have no simple and reliable way to continue.
13962 Break out the floating-point parsing into a new
13963 function string_to_number, so that Fstring_to_number parses
13964 floating point numbers consistently with the Lisp reader.
04f2d78b 13965 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
13966 (E_CHAR, EXP_INT): Remove, replacing with ...
13967 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
13968 (string_to_number): New function, replacing isfloat_string.
13969 This function checks for valid syntax and produces the resulting
13970 Lisp float number too. Rework it so that string-to-number
bc0a5c13 13971 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
13972 so that overflow for non-base-10 numbers is reported only when
13973 there's no portable and simple way to convert to floating point.
452f4150 13974
67769ffc
PE
13975 * textprop.c (set_text_properties_1): Rewrite for clarity,
13976 and to avoid GCC warning about integer overflow.
13977
c20db43f
PE
13978 * intervals.h (struct interval): Use EMACS_INT for members
13979 where EMACS_UINT might cause problems. See
13980 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
13981 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
13982 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
13983 All uses changed.
37aa2f85
PE
13984 (offset_intervals): Tell GCC not to worry about length overflow
13985 when negating a negative length.
c20db43f 13986
2538aa2f
PE
13987 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
13988 (overrun_check_free): Likewise.
13989
f2d3008d
PE
13990 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
13991 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
13992 word size.
13993
ec8df744
PE
13994 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13995 (gnutls_make_error): Rename local to avoid shadowing.
13996 (gnutls_emacs_global_deinit): ifdef out; not used.
13997 (Fgnutls_boot): Use const for pointer to readonly storage.
13998 Comment out unused local. Fix pointer signedness problems.
13999
640ee02d
PE
14000 * lread.c (openp): Don't stuff size_t into an 'int'.
14001 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
14002 about possible signed overflow.
14003
6048fb2a
PE
14004 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14005 (GDK_KEY_g): Don't define if already defined.
14006 (xg_prepare_tooltip): Avoid pointer signedness problem.
14007 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
14008
fa3c87e1
PE
14009 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
14010 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
14011
2172544b
PE
14012 * xfns.c (Fx_window_property): Simplify a bit,
14013 to make a bit faster and to avoid GCC 4.6.0 warning.
14014 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
14015
9b821a21
PE
14016 * fns.c (internal_equal): Don't assume size_t fits in int.
14017
3c616cfa
PE
14018 * alloc.c (compact_small_strings): Tighten assertion a little.
14019
c2982e87
PE
14020 Replace pEd with more-general pI, and fix some printf arg casts.
14021 * lisp.h (pI): New macro, generalizing old pEd macro to other
14022 conversion specifiers. For example, use "...%"pI"d..." rather
14023 than "...%"pEd"...".
14024 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 14025 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
14026 * alloc.c (check_pure_size): Don't overflow by converting size to int.
14027 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
14028 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
14029 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
14030 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
14031 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
14032 64-bit hosts.
14033 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
14034 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
14035 * print.c (safe_debug_print, print_object): Likewise.
14036 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
14037 to int.
6f04d126
PE
14038 Use pI instead of if-then-else-abort. Use %p to avoid casts,
14039 avoiding the 0 flag, which is not portable.
c2982e87
PE
14040 * process.c (Fmake_network_process): Use pI to avoid cast.
14041 * region-cache.c (pp_cache): Likewise.
14042 * xdisp.c (decode_mode_spec): Likewise.
14043 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
14044 behavior on 64-bit hosts with printf arg.
6f04d126 14045 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
14046 (x_stop_queuing_selection_requests): Likewise.
14047 (x_get_window_property): Don't truncate byte count to an 'int'
14048 when tracing.
0b432f21 14049
5e073ec7
PE
14050 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
14051 here, since it parses constructs like leading '-' and spaces,
14052 which are not wanted; and it overflows with large numbers.
14053 Instead, simply match F[0-9]+, which is what is wanted anyway.
14054
36372bf9
PE
14055 * alloc.c: Remove unportable assumptions about struct layout.
14056 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
14057 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
14058 (allocate_vectorlike, make_pure_vector): Use the new macros,
14059 plus offsetof, to remove unportable assumptions about struct layout.
14060 These assumptions hold on all porting targets that I know of, but
14061 they are not guaranteed, they're easy to remove, and removing them
14062 makes further changes easier.
14063
0b432f21
PE
14064 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
14065 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
14066 (string_overrun_cookie): Now const. Use initializers that
14067 don't formally overflow signed char, to avoid warnings.
000098c1
PE
14068 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
14069 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
14070 (allocate_buffer): Don't assume sizeof (struct buffer) is a
14071 multiple of sizeof (EMACS_INT); it need not be, if
14072 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 14073 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 14074
895009e1
JB
140752011-04-26 Juanma Barranquero <lekktu@gmail.com>
14076
14077 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
14078
6a7a1b0b
TZ
140792011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
14080
14081 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 14082 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
14083 Reported by Paul Eggert <eggert@cs.ucla.edu>.
14084
841a1577 140852011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
14086
14087 * lisp.h (Qdebug): List symbol.
895009e1 14088 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
14089 * keyboard.c (debug-on-event): New variable.
14090 (handle_user_signal): Break into debugger when debug-on-event
14091 matches the current signal symbol.
14092
f2d3ba6f
DN
140932011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
14094
14095 * alloc.c (check_sblock, check_string_bytes)
14096 (check_string_free_list): Convert to standard C.
14097
42ce4c63
TZ
140982011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
14099
14100 * w32.c (emacs_gnutls_push): Fix typo.
14101
825cd63c
EZ
141022011-04-25 Eli Zaretskii <eliz@gnu.org>
14103
fb11d64d
EZ
14104 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
14105 "cast to pointer from integer of different size".
14106
825cd63c
EZ
14107 Improve doprnt and its use in verror. (Bug#8545)
14108 * doprnt.c (doprnt): Document the set of format control sequences
14109 supported by the function. Use SAFE_ALLOCA instead of always
14110 using `alloca'.
14111
14112 * eval.c (verror): Don't limit the buffer size at size_max-1, that
14113 is one byte too soon. Don't use xrealloc; instead xfree and
14114 xmalloc anew.
14115
e061a11b
TZ
141162011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
14117
14118 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
14119 callbacks stage.
14120
14121 * gnutls.c: Renamed global_initialized to
14122 gnutls_global_initialized. Added internals for the
14123 :verify-hostname-error, :verify-error, and :verify-flags
14124 parameters of `gnutls-boot' and documented those parameters in the
14125 docstring. Start callback support.
9173deec
JB
14126 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
14127 unless a fatal error occurred. Call gnutls_alert_send_appropriate
14128 on error. Return error code.
e061a11b
TZ
14129 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
14130 (emacs_gnutls_read): Likewise.
14131 (Fgnutls_boot): Return handshake error code.
14132 (emacs_gnutls_handle_error): New function.
14133 (wsaerror_to_errno): Likewise.
14134
14135 * w32.h (emacs_gnutls_pull): Add prototype.
14136 (emacs_gnutls_push): Likewise.
14137
14138 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
14139 (emacs_gnutls_push): Likewise.
14140
141412011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
14142
14143 * process.c (wait_reading_process_output): Check if GnuTLS
14144 buffered some data internally if no FDs are set for TLS
14145 connections.
14146
14147 * makefile.w32-in (OBJ2): Add gnutls.$(O).
14148 (LIBS): Link to USER_LIBS.
14149 ($(BLD)/gnutls.$(0)): New target.
14150
fa6996bc
EZ
141512011-04-24 Eli Zaretskii <eliz@gnu.org>
14152
eb35682e
EZ
14153 * xdisp.c (handle_single_display_spec): Rename the
14154 display_replaced_before_p argument into display_replaced_p, to
14155 make it consistent with the commentary. Fix typos in the
14156 commentary.
14157
e2ad650c
EZ
14158 * textprop.c (syms_of_textprop): Remove dead code.
14159 (copy_text_properties): Delete obsolete commentary about an
14160 interface that was deleted long ago. Fix typos in the description
14161 of arguments.
14162
1b2de274
EZ
14163 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
14164 to changes in oldXMenu/XMenu.h from 2011-04-16.
14165 <menu_help_message, prev_menu_help_message>: Constify.
14166 (IT_menu_make_room): menu->help_text is now `const char **';
14167 adjust.
14168
14169 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
14170 to changes in oldXMenu/XMenu.h from 2011-04-16.
14171 (struct XMenu): Declare `help_text' `const char **'.
14172
14173 * xfaces.c <Qunspecified>: Make extern again.
14174
14175 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 14176 required by POSIX.
1b2de274 14177
762b15be
EZ
14178 * doc.c (get_doc_string): Improve the format passed to `error'.
14179
14180 * doprnt.c (doprnt): Improve commentary.
14181
14182 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
14183
14184 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
14185 them with etags.
14186
f1052e5d
EZ
14187 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
14188 changes in globals.h immediately force recompilation.
762b15be
EZ
14189 (TAGS): Depend on $(CURDIR)/m/intel386.h and
14190 $(CURDIR)/s/ms-w32.h.
14191 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 14192
fa6996bc
EZ
14193 * character.c (Fchar_direction): Function deleted.
14194 (syms_of_character): Don't defsubr it.
14195 <char-direction-table>: Deleted.
14196
e6c3da20
EZ
141972011-04-23 Eli Zaretskii <eliz@gnu.org>
14198
14199 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
14200 * doprnt.c: Include limits.h.
14201 (SIZE_MAX): New macro.
04f2d78b
CB
14202 (doprnt): Return a size_t value. 2nd arg is now size_t.
14203 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
14204 Improve overflow protection. Support `l' modifier for integer
14205 conversions. Support %l conversion. Don't assume an EMACS_INT
14206 argument for integer conversions and for %c.
14207
14208 * lisp.h (doprnt): Restore prototype.
14209
14210 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
14211 $(SRC)/character.h.
14212
14213 * Makefile.in (base_obj): Add back doprnt.o.
14214
14215 * deps.mk (doprnt.o): Add back prerequisites.
14216 (callint.o): Depend on character.h.
14217
14218 * eval.c (internal_lisp_condition_case): Include the handler
14219 representation in the error message.
14220 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
14221 when breaking from the loop.
14222
14223 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
14224
14225 * callint.c (Fcall_interactively): When displaying error message
14226 about invalid control letter, pass the character's codepoint, not
14227 a pointer to its multibyte form. Improve display of the character
14228 in octal and display also its hex code.
14229
14230 * character.c (char_string): Use %x to display the (unsigned)
14231 codepoint of an invalid character, to avoid displaying a bogus
14232 negative value.
14233
14234 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
14235 `error', not SYMBOL_NAME itself.
14236
14237 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
14238 character arguments to `error'.
14239
14240 * charset.c (check_iso_charset_parameter): Fix incorrect argument
14241 to `error' in error message about FINAL_CHAR argument. Make sure
14242 FINAL_CHAR is a character, and use %c when it is passed as
14243 argument to `error'.
14244
4ffd0d6b 142452011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
14246
14247 * s/ms-w32.h (localtime): Redirect to sys_localtime.
14248
14249 * w32.c: Include <time.h>.
14250 (sys_localtime): New function.
14251
4ffd0d6b 142522011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
14253
14254 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
14255
4ffd0d6b 14256 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 14257
4ffd0d6b 142582011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 14259
4ffd0d6b
GM
14260 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
14261 zombies (Bug#8467).
aac0c6e3 14262
04c56954
EZ
142632011-04-19 Eli Zaretskii <eliz@gnu.org>
14264
14265 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
14266 gl_state.e_property when gl_state.object is Qt.
14267
14268 * insdel.c (make_gap_larger): Remove limitation of buffer size
14269 to <= INT_MAX.
14270
16a43933
CY
142712011-04-18 Chong Yidong <cyd@stupidchicken.com>
14272
14273 * xdisp.c (lookup_glyphless_char_display)
14274 (produce_glyphless_glyph): Handle cons cell entry in
14275 glyphless-char-display.
14276 (Vglyphless_char_display): Document it.
14277
14278 * term.c (produce_glyphless_glyph): Handle cons cell entry in
14279 glyphless-char-display.
14280
4581706e
CY
142812011-04-17 Chong Yidong <cyd@stupidchicken.com>
14282
14283 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
14284
14285 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
14286
14287 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
14288 definition for no-X builds.
14289
4887c6e2 142902011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 14291
fd35b6f9
PE
14292 Static checks with GCC 4.6.0 and non-default toolkits.
14293
5c1ccb01
PE
14294 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
14295
006c5daa
PE
14296 * process.c (keyboard_bit_set): Define only if SIGIO.
14297 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
14298 (send_process): Repair possible setjmp clobbering.
14299
efc736d3
PE
14300 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
14301
4e2fe2e6
PE
14302 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
14303
f97334a2
PE
14304 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
14305
4e75f29d
PE
14306 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
14307 Define only if needed.
14308
90efadd1
PE
14309 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
14310 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 14311 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 14312
3c647824
PE
14313 * dispextern.h (struct redisplay_interface): Rename param
14314 to avoid shadowing.
e264f262 14315 * termhooks.h (struct terminal): Likewise.
761383f4 14316 * xterm.c (xembed_send_message): Likewise.
3c647824 14317
b58c5c4a
PE
14318 * insdel.c (make_gap_smaller): Define only if
14319 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
14320
cad59032
PE
14321 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
14322 it.
14323
c339dc2e
PE
14324 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
14325 so that we aren't warned about unused symbols.
14326
91a3e27b
PE
14327 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
14328
399c71d3 14329 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 14330
8ffc96f5
PE
14331 * xfns.c (x_real_positions): Mark locals as initialized.
14332
eef9bc79
PE
14333 * xmenu.c (xmenu_show): Don't use uninitialized vars.
14334
098db9dd
PE
14335 * xterm.c: Fix problems found by static analysis with other toolkits.
14336 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
14337 (x_dispatch_event): Declare static if USE_GTK, and
14338 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 14339 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 14340 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
14341 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
14342 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 14343
eb18f6cc
PE
14344 * xmenu.c (menu_help_callback): Pointer type fixes.
14345 Use const pointers when pointing at readonly data. Avoid pointer
14346 signedness clashes.
14347 (FALSE): Remove unused macro.
14348 (update_frame_menubar): Remove unused decl.
14349
1fe72bf8
PE
14350 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
14351
60d9e1db
PE
14352 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
14353 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
14354 (single_menu_item): Rename local to avoid shadowing.
14355
39261c26
PE
14356 * keyboard.c (make_lispy_event): Remove unused local var.
14357
018c5e19
PE
14358 * frame.c, frame.h (x_get_resource_string): Bring this back, but
14359 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
14360
63d2b86e
PE
14361 * bitmaps: Change bitmaps from unsigned char back to the X11
14362 compatible char. Avoid the old compiler warnings about
14363 out-of-range initializers by using, for example, '\xab' rather
14364 than 0xab.
14365
aefd87e1
PE
14366 * xgselect.c (xgselect_initialize): Check vs interface
14367 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
14368
bf501fb9
PE
14369 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
14370
e9829fdf
PE
14371 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
14372 to read-only memory.
14373
1086c095
PE
14374 * fns.c (vector): Remove; this old hack is no longer needed.
14375
2baccd04 14376 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 14377 Remove unused var.
dde42981 14378 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 14379
72391843 14380 * xrdb.c (x_load_resources): Omit unused local.
3565b346 14381
436c16df 14382 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 14383 (x_window): Rename locals to avoid shadowing.
dc5ddd85 14384 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 14385
92bb796d 14386 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 14387 (x_term_init): Remove local to avoid shadowing.
92bb796d 14388
764430a3 14389 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
14390
14391 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
14392 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
14393
d1dfb56c
EZ
143942011-04-16 Eli Zaretskii <eliz@gnu.org>
14395
c4354cb4
EZ
14396 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
14397
d1dfb56c
EZ
14398 Fix regex.c, syntax.c and friends for buffers > 2GB.
14399 * syntax.h (struct gl_state_s): Declare character position members
14400 EMACS_INT.
14401
14402 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
14403
04f2d78b
CB
14404 * textprop.c (verify_interval_modification, interval_of):
14405 Declare arguments EMACS_INT.
d1dfb56c
EZ
14406
14407 * intervals.c (adjust_intervals_for_insertion): Declare arguments
14408 EMACS_INT.
14409
14410 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
14411
14412 * indent.c (Fvertical_motion): Local variable it_start is now
14413 EMACS_INT.
14414
14415 * regex.c (re_match, re_match_2, re_match_2_internal)
14416 (bcmp_translate, regcomp, regexec, print_double_string)
14417 (group_in_compile_stack, re_search, re_search_2, regex_compile)
14418 (re_compile_pattern, re_exec): Declare arguments and local
14419 variables `size_t' and `ssize_t' and return values `regoff_t', as
14420 appropriate.
14421 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
14422 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
14423 <compile_stack_type>: `size' and `avail' are now `size_t'.
14424
14425 * regex.h <regoff_t>: Use ssize_t, not int.
14426 (re_search, re_search_2, re_match, re_match_2): Arguments that
14427 specify buffer/string position and length are now ssize_t and
14428 size_t. Return type is regoff_t.
14429
613052cd
BK
144302011-04-16 Ben Key <bkey76@gmail.com>
14431
14432 * nsfont.m: Fixed bugs in ns_get_family and
14433 ns_descriptor_to_entity that were caused by using free to
14434 deallocate memory blocks that were allocated by xmalloc (via
14435 xstrdup). This caused Emacs to crash when compiled with
14436 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
14437 --enable-checking=xmallocoverrun). xfree is now used to
14438 deallocate these memory blocks.
14439
4170f62f 144402011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 14441
71b41406
PE
14442 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
14443
9587a89d
PE
14444 emacs_write: Accept and return EMACS_INT for sizes.
14445 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
14446 et seq.
14447 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
14448 Accept and return EMACS_INT.
14449 (emacs_gnutls_write): Return the number of bytes written on
14450 partial writes.
14451 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
14452 (emacs_read, emacs_write): Remove check for negative size, as the
14453 Emacs source code has been audited now.
9587a89d
PE
14454 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
14455 (emacs_read, emacs_write): Use it.
273a5f82
PE
14456 * process.c (send_process): Adjust to the new signatures of
14457 emacs_write and emacs_gnutls_write. Do not attempt to store
14458 a byte offset into an 'int'; it might overflow.
9587a89d 14459 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 14460
3e047f51
PE
14461 * sound.c: Don't assume sizes fit in 'int'.
14462 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 14463 Return EMACS_INT, not int.
3e047f51 14464 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
14465 Accept EMACS_INT, not int.
14466 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
14467 record read return values.
14468
cc39a9db
BK
144692011-04-15 Ben Key <bkey76@gmail.com>
14470
c9d0ec6d
JB
14471 * keyboard.c (Qundefined): Don't declare static since it is used
14472 in nsfns.m.
14473 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
14474 static since they are used in nsfont.m.
cc39a9db 14475
6c60eb9f
SM
144762011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
14477
14478 * process.c (Qprocessp): Don't declare static.
14479 * lisp.h (Qprocessp): Declare again.
14480
7990b61a
JB
144812011-04-15 Juanma Barranquero <lekktu@gmail.com>
14482
14483 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
14484
5d4cb038
PE
144852011-04-14 Paul Eggert <eggert@cs.ucla.edu>
14486
8bd7b830 14487 Improve C-level modularity by making more things 'static'.
cd64ea1d 14488
e3b27b31
PE
14489 Don't publish debugger-only interfaces to other modules.
14490 * lisp.h (safe_debug_print, debug_output_compilation_hack):
14491 (verify_bytepos, count_markers): Move decls to the only modules
14492 that need them.
14493 * region-cache.h (pp_cache): Likewise.
14494 * window.h (check_all_windows): Likewise.
14495 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
14496
5d4cb038
PE
14497 * sysdep.c (croak): Now static, if
14498 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
14499 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
14500
14501 * alloc.c (refill_memory_reserve): Now static if
14502 !defined REL_ALLOC || defined SYSTEM_MALLOC.
14503 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 14504
e87b6180
PE
14505 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
14506 Define only if USE_LUCID.
14507
ac64929e
PE
14508 * xrdb.c (x_customization_string, x_rm_string): Now static.
14509
6f37259d
PE
14510 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
14511 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
14512
1683e3ab
PE
14513 * xdisp.c (draw_row_with_mouse_face): Now static.
14514 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
14515
de9c2632
PE
14516 * window.h (check_all_windows): Mark externally visible.
14517
2b96acb7
PE
14518 * window.c (window_deletion_count): Now static.
14519
14520 * undo.c: Make symbols static if they're not exported.
14521 (last_undo_buffer, last_boundary_position, pending_boundary):
14522 Now static.
14523
50436f33
PE
14524 * textprop.c (interval_insert_behind_hooks): Now static.
14525 (interval_insert_in_front_hooks): Likewise.
14526
64520e5c
PE
14527 * term.c: Make symbols static if they're not exported.
14528 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
14529 (max_frame_lines, tty_set_terminal_modes):
14530 (tty_reset_terminal_modes, tty_turn_off_highlight):
14531 (get_tty_terminal): Now static.
14532 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
14533 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 14534 HAVE_WINDOW_SYSTEM.
64520e5c
PE
14535 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
14536 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
14537
1fa53021
PE
14538 * sysdep.c: Make symbols static if they're not exported.
14539 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
14540 Now static.
14541 (sigprocmask_set, full_mask): Remove; unused.
14542 (wait_debugging): Mark as visible.
14543 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
14544 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
14545
d4b43b22
PE
14546 * syntax.c (syntax_temp): Define only if !__GNUC__.
14547
b7c513d0
PE
14548 * sound.c (current_sound_device, current_sound): Now static.
14549
989b29ad
PE
14550 * search.c (searchbufs, searchbuf_head): Now static.
14551
13a55a78
PE
14552 * scroll.c (scroll_cost): Remove; unused.
14553 * dispextern.h (scroll_cost): Remove decl.
14554
de68a1fc
PE
14555 * region-cache.h (pp_cache): Mark as externally visible.
14556
40ccffa6
PE
14557 * process.c: Make symbols static if they're not exported.
14558 (process_tick, update_tick, create_process, chan_process):
14559 (Vprocess_alist, proc_buffered_char, datagram_access):
14560 (fd_callback_data, send_process_frame, process_sent_to): Now static.
14561 (deactivate_process): Mark defn as static, as well as decl.
14562 * lisp.h (create_process): Remove decl.
14563 * process.h (chan_process, Vprocess_alist): Remove decls.
14564
ad64fc97
PE
14565 * print.c: Make symbols static if they're not exported.
14566 (print_depth, new_backquote_output, being_printed, print_buffer):
14567 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
14568 (print_interval, print_number_index, initial_stderr_stream):
14569 Now static.
14570 * lisp.h (Fprinc): Remove decl.
14571 (debug_output_compilation_hack): Mark as externally visible.
14572
adddb265
PE
14573 * sysdep.c (croak): Move decl from here to syssignal.h.
14574 * syssignal.h (croak): Put it here, so the API can be checked when
14575 'croak' is called from dissociate_if_controlling_tty.
14576
1717ede2
PE
14577 * minibuf.c: Make symbols static if they're not exported.
14578 (minibuf_save_list, choose_minibuf_frame): Now static.
14579 * lisp.h (choose_minibuf_frame): Remove decl.
14580
fa5fb2bc
PE
14581 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
14582
1e3890d1
PE
14583 * lread.c: Make symbols static if they're not exported.
14584 (read_objects, initial_obarray, oblookup_last_bucket_number):
14585 Now static.
14586 (make_symbol): Remove; unused.
14587 * lisp.h (initial_obarray, make_symbol): Remove decls.
14588
8a1414fa
PE
14589 * keyboard.c: Make symbols static if they're not exported.
14590 (single_kboard, recent_keys_index, total_keys, recent_keys):
14591 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
14592 (this_single_command_key_start, echoing, last_auto_save):
14593 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
14594 (command_loop, echo_now, keyboard_init_hook, help_char_p):
14595 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
14596 (Vlispy_mouse_stem, double_click_count):
14597 Now static.
14598 (force_auto_save_soon): Define only if SIGDANGER.
14599 (ignore_mouse_drag_p): Now static if
14600 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
14601 (print_help): Remove; unused.
14602 (stop_character, last_timer_event): Mark as externally visible.
14603 * keyboard.h (ignore_mouse_drag_p): Declare only if
14604 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
14605 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
14606 * lisp.h (echoing): Remove decl.
14607 (force_auto_save_soon): Declare only if SIGDANGER.
14608 * xdisp.c (redisplay_window): Simplify code, to make it more
14609 obvious that ignore_mouse_drag_p is not accessed if !defined
14610 USE_GTK && !defined HAVE_NS.
14611
93ea6e8f
PE
14612 * intervals.c: Make symbols static if they're not exported.
14613 (merge_properties_sticky, merge_interval_right, delete_interval):
14614 Now static.
14615 * intervals.h (merge_interval_right, delete_interval): Remove decls.
14616
77382fcc
PE
14617 * insdel.c: Make symbols static if they're not exported.
14618 However, leave prepare_to_modify_buffer alone. It's never
14619 called from outside this function, but that appears to be a bug.
14620 (combine_after_change_list, combine_after_change_buffer):
4889fc82 14621 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
14622 (adjust_after_replace_noundo): Remove; unused.
14623 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 14624 (signal_before_change): Remove decls.
77382fcc 14625
9306c32e
PE
14626 * indent.c (val_compute_motion, val_vmotion): Now static.
14627
cd44d2eb
PE
14628 * image.c: Make symbols static if they're not exported.
14629 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
14630 if USE_GTK.
14631 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
14632 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
14633
ad9a7a06
PE
14634 * fringe.c (standard_bitmaps): Now static.
14635 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
14636
81626931
PE
14637 * frame.c: Make symbols static if they're not exported.
14638 (x_report_frame_params, make_terminal_frame): Now static.
14639 (get_frame_param): Now static, unless HAVE_NS.
14640 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
14641 (x_get_resource_string): Remove; not used.
14642 * frame.h (make_terminal_frame, x_report_frame_params):
14643 (x_get_resource_string); Remove decls.
14644 (x_fullscreen_adjust): Declare only if WINDOWSNT.
14645 * lisp.h (get_frame_param): Declare only if HAVE_NS.
14646
239f9db9
PE
14647 * font.c, fontset.c: Make symbols static if they're not exported.
14648 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
14649 (FACE_SUITABLE_FOR_CHAR_P): Use it.
14650 * font.c (font_close_object): Now static.
14651 * font.h (font_close_object): Remove.
14652 * fontset.c (FONTSET_OBJLIST): Remove.
14653 (free_realized_fontset) #if-0 the body, which does nothing.
14654 (face_suitable_for_char_p): #if-0, as it's never called.
14655 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
14656 * xfaces.c (face_at_string_position):
14657 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
14658 since 0 is always ASCII.
14659
dfcf3579
PE
14660 * fns.c (weak_hash_tables): Now static.
14661
5045092b
PE
14662 * fileio.c: Make symbols static if they're not exported.
14663 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
14664 (Vwrite_region_annotation_buffers): Now static.
14665
57a96f5c
PE
14666 * eval.c: Make symbols static if they're not exported.
14667 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
14668 * lisp.h (backtrace_list): Remove decl.
14669
35f08c38
PE
14670 * emacs.c: Make symbols static if they're not exported.
14671 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
14672 (fatal_error_code, fatal_error_signal_hook, standard_args):
14673 Now static.
14674 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
14675 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
14676 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
14677 * lisp.h (fatal_error_signal_hook): Remove decl.
14678 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
14679
f44bd759
PE
14680 * editfns.c: Move a (normally-unused) function to its only use.
14681 * editfns.c, lisp.h (get_operating_system_release): Remove.
14682 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
14683 worth the hassle of breaking this out.
14684
b532497d
PE
14685 * xterm.c: Make symbols static if they're not exported.
14686 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
14687 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
14688 (x_destroy_window, x_delete_display):
14689 Now static.
14690 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
14691 (x_mouse_leave): Remove; unused.
14692 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
14693 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
14694 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
14695 Remove decls.
14696 (x_mouse_leave): Declare only if WINDOWSNT.
14697 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
14698 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
14699 USE_X_TOOLKIT.
14700
1675728f
PE
14701 * ftxfont.c: Make symbols static if they're not exported.
14702 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
14703 HAVE_FREETYPE.
14704 * font.h (ftxfont_driver): Likewise.
14705
e4cebfca
PE
14706 * xfns.c: Make symbols static if they're not exported.
14707 (x_last_font_name, x_display_info_for_name):
14708 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
14709 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
14710 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
14711 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
14712 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
14713 (last_show_tip_args): Now static.
14714 (xic_defaut_fontset, xic_create_fontsetname): Define only if
14715 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
14716 (x_screen_planes): Remove; unused.
14717 * dispextern.h (x_screen_planes): Remove decl.
14718
5bf46f05
PE
14719 * dispnew.c: Make symbols static if they're not exported.
14720 * dispextern.h (redraw_garbaged_frames, scrolling):
14721 (increment_row_positions): Remove.
14722 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
14723 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
14724 Now static.
14725 (redraw_garbaged_frames): Remove; unused.
14726
435f4c28
PE
14727 * xfaces.c: Make symbols static if they're not exported.
14728 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
14729 Remove decls.
14730 * xterm.h (defined_color): Remove decls.
14731 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
14732 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
14733 (menu_face_changed_default, defined_color, free_realized_face):
14734 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
14735 (ascii_face_of_lisp_face): Remove; unused.
14736
8524aef3
PE
14737 * xdisp.c: Make symbols static if they're not exported.
14738 * dispextern.h (scratch_glyph_row, window_box_edges):
14739 (glyph_to_pixel_coords, set_cursor_from_row):
14740 (get_next_display_element, set_iterator_to_next):
14741 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
14742 (show_mouse_face): Remove decls
14743 * frame.h (message_buf_print): Likewise.
14744 * lisp.h (pop_message, set_message, check_point_in_composition):
14745 Likewise.
14746 * xterm.h (set_vertical_scroll_bar): Likewise.
14747 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
14748 (message_buf_print, scratch_glyph_row, displayed_buffer):
14749 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
14750 (get_next_display_element, show_mouse_face, window_box_edges):
14751 (frame_to_window_pixel_xy, check_point_in_composition):
14752 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
14753 (glyph_to_pixel_coords): Remove; unused.
14754
16390cd2
PE
14755 * dired.c (file_name_completion): Now static.
14756
14757 * dbusbind.c (xd_in_read_queued_messages): Now static.
14758
a25f4dfa
PE
14759 * lisp.h (circular_list_error, FOREACH): Remove; unused.
14760 * data.c (circular_list_error): Remove.
14761
14a9c8df
PE
14762 * commands.h (last_point_position, last_point_position_buffer):
14763 (last_point_position_window): Remove decls.
14764 * keyboard.c: Make these variables static.
14765
04f2d78b
CB
14766 * coding.h (coding, code_convert_region, encode_coding_gap):
14767 Remove decls.
74ab6df5
PE
14768 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
14769 (iso_code_class, detect_coding, code_convert_region): Now static.
14770 (encode_coding_gap): Remove; unused.
14771
38dfbee1
PE
14772 * chartab.c (chartab_chars, chartab_bits): Now static.
14773
a2cb4e63
PE
14774 * charset.h (charset_iso_8859_1): Remove decl.
14775 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
14776 Now static.
14777
127198fd
PE
14778 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
14779 * ccl.c (Vccl_program_table): Now static.
14780 (check_ccl_update): Remove; unused.
14781
d85b608f
PE
14782 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
14783 * category.h: ... from here.
14784 * category.c (check_category_table, set_category_set): Now static.
14785
31cd66f3
PE
14786 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
14787 * lisp.h: Remove these decls.
14788
c358e587
PE
14789 * buffer.c (buffer_count): Remove unused var.
14790
e78aecca
PE
14791 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
14792 so that it's not optimized away.
14793 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
14794 * dispextern.h (bidi_dump_cached_states): Remove, since it's
14795 exported only to the debugger.
14796
e192d7d3 14797 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 14798 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 14799
92470028
PE
14800 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
14801 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
14802 was inaccessible from Lisp.
14803 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
14804 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
14805
244ed907
PE
14806 alloc.c: Import and export fewer symbols, and remove unused items.
14807 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
14808 is defined.
14809 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
14810 it's not optimized away by whole-program optimization.
14811 (message_enable_multibyte, free_misc): Remove.
14812 (catchlist, handlerlist, mark_backtrace):
14813 Declare only if BYTE_MARK_STACK.
14814 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
14815 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
14816 (message_enable_multibyte): Remove decl.
14817 (free_misc, interval_free_list, float_block, float_block_index):
14818 (n_float_blocks, float_free_list, cons_block, cons_block_index):
14819 (cons_free_list, last_marked_index):
14820 Now static.
14821 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
14822 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
14823 (mark_backtrace): Define only if BYTE_MARK_STACK.
14824 * xdisp.c (message_enable_multibyte): Now static.
14825
61c2b50e 14826 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
14827 This makes it easier for human readers (and static analyzers)
14828 to see whether these variables are used from other modules.
14829 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
14830 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
14831 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
14832 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
14833 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
14834 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
14835 * xmenu.c, xselect.c:
14836 Declare Q* vars static if they are not used in other modules.
14837 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
14838 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
14839 Remove decls of unexported vars.
14840 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
14841
95c82688
PE
14842 * lisp.h (DEFINE_FUNC): Make sname 'static'.
14843
16a97296
PE
14844 Make Emacs functions such as Fatom 'static' by default.
14845 This makes it easier for human readers (and static analyzers)
14846 to see whether these functions can be called from other modules.
14847 DEFUN now defines a static function. To make the function external
14848 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
14849 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
14850 (Finit_image_library):
16a97296
PE
14851 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
14852 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
14853 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
14854 Remove decls, since these functions are now static.
14855 (Funintern, Fget_internal_run_time): New decls, since these functions
14856 were already external.
95c82688 14857
16a97296
PE
14858 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
14859 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
14860 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
14861 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
14862 * keyboard.c, keymap.c, lread.c:
14863 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
14864 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
14865 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
14866 Mark functions with DEFUE instead of DEFUN,
14867 if they are used in other modules.
14868 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
14869 decls for now-static functions.
14870 * buffer.h (Fdelete_overlay): Remove decl.
14871 * callproc.c (Fgetenv_internal): Mark as internal.
14872 * composite.c (Fremove_list_of_text_properties): Remove decl.
14873 (Fcomposition_get_gstring): New forward static decl.
14874 * composite.h (Fcomposite_get_gstring): Remove decl.
14875 * dired.c (Ffile_attributes): New forward static decl.
14876 * doc.c (Fdocumntation_property): New forward static decl.
14877 * eval.c (Ffetch_bytecode): New forward static decl.
14878 (Funintern): Remove extern decl; now in .h file where it belongs.
14879 * fileio.c (Fmake_symbolic_link): New forward static decl.
14880 * image.c (Finit_image_library): New forward static decl.
14881 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
14882 * intervals.h (Fprevious_property_change):
14883 (Fremove_list_of_text_properties): Remove decls.
14884 * keyboard.c (Fthis_command_keys): Remove decl.
14885 (Fcommand_execute): New forward static decl.
14886 * keymap.c (Flookup_key): New forward static decl.
14887 (Fcopy_keymap): Now static.
14888 * keymap.h (Flookup_key): Remove decl.
14889 * process.c (Fget_process): New forward static decl.
14890 (Fprocess_datagram_address): Mark as internal.
14891 * syntax.c (Fsyntax_table_p): New forward static decl.
14892 (skip_chars): Remove duplicate decl.
14893 * textprop.c (Fprevious_property_change): New forward static decl.
14894 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
14895 Now internal.
14896 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
14897 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
14898
785bbd42
PE
14899 * editfns.c (Fformat): Remove unreachable code.
14900
8b913b57
AS
149012011-04-14 Andreas Schwab <schwab@linux-m68k.org>
14902
14903 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
14904 change. (Bug#8496)
14905
a6744a35
EZ
149062011-04-13 Eli Zaretskii <eliz@gnu.org>
14907
14908 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
14909 when at ZV. (Bug#8487)
14910
e7974947
AS
149112011-04-12 Andreas Schwab <schwab@linux-m68k.org>
14912
baad03f0
AS
14913 * charset.c (Fclear_charset_maps): Use xfree instead of free.
14914 (Bug#8437)
14915 * keyboard.c (parse_tool_bar_item): Likewise.
14916 * sound.c (sound_cleanup, alsa_close): Likewise.
14917 * termcap.c (tgetent): Likewise.
14918 * xfns.c (x_default_font_parameter): Likewise.
14919 * xsettings.c (read_and_apply_settings): Likewise.
14920
e7974947
AS
14921 * alloc.c (overrun_check_malloc, overrun_check_realloc)
14922 (overrun_check_free): Protoize.
14923
28272684
PE
149242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
14925
14926 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
14927 since callers should never pass a negative size.
14928 Change the signature to match that of plain 'read' and 'write'; see
14929 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
14930 * lisp.h: Update prototypes of emacs_write and emacs_read.
14931
11997c76
EZ
149322011-04-11 Eli Zaretskii <eliz@gnu.org>
14933
14934 * xdisp.c (redisplay_window): Don't try to determine the character
14935 position of the scroll margin if the window start point w->startp
e896f03c 14936 is outside the buffer's accessible region. (Bug#8468)
11997c76 14937
8a2cbd72
EZ
149382011-04-10 Eli Zaretskii <eliz@gnu.org>
14939
14940 Fix write-region and its subroutines for buffers > 2GB.
14941 * fileio.c (a_write, e_write): Modify declaration of arguments and
14942 local variables to support buffers larger than 2GB.
14943 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
14944
14945 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
14946 argument, local variables, and return value.
14947
14948 * lisp.h: Update prototypes of emacs_write and emacs_read.
14949
14950 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
14951
4073e537 149522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 14953
1ebfdcb6
PE
14954 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
14955
b2ded58d
PE
14956 Fix more problems found by GCC 4.6.0's static checks.
14957
7d66342c
PE
14958 * xdisp.c (vmessage): Use a better test for character truncation.
14959
bbf47d44
PE
14960 * charset.c (load_charset_map): <, not <=, for optimization,
14961 and to avoid potential problems with integer overflow.
9248994d 14962 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 14963 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 14964 * editfns.c (Fformat): Likewise.
1e69125e 14965 * syntax.c (skip_chars): Likewise.
3befa583 14966
e3019616
PE
14967 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
14968 This also lets GCC 4.6.0 generate slightly better loop code.
14969
becfa255
PE
14970 * callint.c (Fcall_interactively): <, not <=, for optimization.
14971 (Fcall_interactively): Count the number of arguments produced,
14972 not the number of arguments given. This is simpler and lets GCC
14973 4.6.0 generate slightly better code.
14974
dae0cd48
PE
14975 * ftfont.c: Distingish more carefully between FcChar8 and char.
14976 The previous code passed unsigned char * to a functions like
14977 strlen and xstrcasecmp that expect char *, which does not
14978 conform to the C standard.
14979 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
14980 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
14981 char * when the C standard requires it.
14982
76032d70
PE
14983 * keyboard.c (read_char): Remove unused var.
14984
eb3f1cc8
PE
14985 * eval.c: Port to Windows vsnprintf (Bug#8435).
14986 Include <limits.h>.
14987 (SIZE_MAX): Define if the headers do not.
14988 (verror): Do not give up if vsnprintf returns a negative count.
14989 Instead, grow the buffer. This ports to Windows vsnprintf, which
14990 does not conform to C99. Problem reported by Eli Zaretskii.
14991 Also, simplify the allocation scheme, by avoiding the need for
14992 calling realloc, and removing the ALLOCATED variable.
14993
70476b54
PE
14994 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
14995
12020a9e
PE
14996 Remove invocations of doprnt, as Emacs now uses vsnprintf.
14997 But keep the doprint source code for now, as we might revamp it
14998 and use it again (Bug#8435).
ea6c7ae6
PE
14999 * lisp.h (doprnt): Remove.
15000 * Makefile.in (base_obj): Remove doprnt.o.
15001 * deps.mk (doprnt.o): Remove.
15002
5fdb398c
PE
15003 error: Print 32- and 64-bit integers portably (Bug#8435).
15004 Without this change, on typical 64-bit hosts error ("...%d...", N)
15005 was used to print both 32- and 64-bit integers N, which relied on
15006 undefined behavior.
61bdb816 15007 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
15008 * lisp.h (error, verror): Mark as printf-like functions.
15009 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
15010 Report overflow in size calculations when allocating printf buffer.
15011 Do not truncate output string at its first null byte.
15012 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
15013 Truncate the output at a character boundary, since vsnprintf does not
15014 do that.
15015 * charset.c (check_iso_charset_parameter): Convert internal
15016 character to string before calling 'error', since %c now has the
15017 printf meaning.
15018 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
15019 overflow when computing char to be passed to 'error'. Do not
15020 pass Lisp_Object to 'error'; pass the integer instead.
15021 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
15022 formatted with plain %d.
15023
b189fa66
PE
15024 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
15025
bff87ef0
PE
15026 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
15027
7e2cac20
PE
15028 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
15029
ce4d90b5
PE
15030 * xterm.c (x_catch_errors): Remove duplicate declaration.
15031
266c9547
PE
15032 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
15033
79c49ad2
PE
15034 * xdisp.c, lisp.h (message_nolog): Remove; unused.
15035
368f4090
JM
150362011-04-10 Jim Meyering <meyering@redhat.com>
15037
15038 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
15039 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
15040 return ssize_t not "int", and use size_t as the buffer length.
15041 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
15042 * gnutls.h: Update declarations.
15043 * process.c (read_process_output): Use ssize_t, to match.
15044 (send_process): Likewise.
15045
a32d4040
CY
150462011-04-09 Chong Yidong <cyd@stupidchicken.com>
15047
15048 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
15049
8546720e 150502011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 15051
04f2d78b
CB
15052 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
15053 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 15054
8546720e
GM
15055 * xterm.c (handle_one_xevent):
15056 * xmenu.c (create_and_show_popup_menu):
15057 * xselect.c (x_decline_selection_request)
15058 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 15059
0a2f5c1a 150602011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
15061
15062 Fix some uses of `int' instead of EMACS_INT.
15063 * search.c (string_match_1, fast_string_match)
15064 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
15065 (scan_buffer, find_next_newline_no_quit)
15066 (find_before_next_newline, search_command, Freplace_match)
15067 (Fmatch_data): Make some `int' variables be EMACS_INT.
15068
15069 * xdisp.c (display_count_lines): 3rd argument and return value now
15070 EMACS_INT. All callers changed.
15071 (pint2hrstr): Last argument is now EMACS_INT.
15072
15073 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
15074 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
15075 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
15076 (decode_coding_utf_16, decode_coding_emacs_mule)
15077 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
15078 (decode_coding_ccl, decode_coding_charset)
15079 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
15080 (decode_coding_iso_2022, decode_coding_emacs_mule)
15081 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
15082 <char_offset, last_offset>: Declare EMACS_INT.
15083 (encode_coding_utf_8, encode_coding_utf_16)
15084 (encode_coding_emacs_mule, encode_invocation_designation)
15085 (encode_designation_at_bol, encode_coding_iso_2022)
15086 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
15087 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
15088 Declare EMACS_INT.
15089 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
15090 (encode_invocation_designation): Last argument P_NCHARS is now
15091 EMACS_INT.
15092 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
15093 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
15094
15095 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
15096 All users changed.
15097
15098 * ccl.c (Fccl_execute_on_string): Declare some variables
15099 EMACS_INT.
15100
8546720e 151012011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
15102
15103 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
15104
4e19a977
CS
151052011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
15106
15107 * process.c (Fformat_network_address): Doc fix.
15108
87302331
R
151092011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
15110
ee7683eb 15111 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 15112
cbb59342
CY
151132011-04-08 Chong Yidong <cyd@stupidchicken.com>
15114
15115 * keyboard.c (read_char): Call Lisp function help-form-show,
15116 instead of using internal_with_output_to_temp_buffer.
15117 (Qhelp_form_show): New var.
e0d38eeb 15118 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
15119
15120 * print.c (internal_with_output_to_temp_buffer): Function deleted.
15121
15122 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
15123
e67a13ab
CY
151242011-04-06 Chong Yidong <cyd@stupidchicken.com>
15125
04f2d78b
CB
15126 * process.c (Flist_processes): Remove to Lisp.
15127 (list_processes_1): Delete.
e67a13ab 15128
973f782d
EZ
151292011-04-06 Eli Zaretskii <eliz@gnu.org>
15130
7c106b1e
EZ
15131 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
15132
973f782d
EZ
15133 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
15134
41cf7d1a 151352011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 15136
ca23cc88
PE
15137 Fix more problems found by GCC 4.6.0's static checks.
15138
f390e2d5
PE
15139 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
15140
42eea0d0
PE
15141 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
15142
b69769da 15143 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 15144
f9541e84
PE
15145 * xdisp.c (vmessage): Mark as a printf-like function.
15146
13841b55
PE
15147 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
15148
c136c10f
PE
15149 * sound.c (sound_warning): Don't crash if arg contains a printf format.
15150
5e2d4a30
PE
15151 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
15152 printf-like functions.
15153 (tiff_load): Add casts to remove these marks before passing them
15154 to system-supplied API.
15155
583f48b9
PE
15156 * eval.c (Fsignal): Remove excess argument to 'fatal'.
15157
b25d760e
PE
15158 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
15159 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
15160 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
15161 directly, rather than having caller test rule sign. This avoids
15162 some unnecessary tests.
15163 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
15164 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
15165 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 15166
bc7b6697 15167 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 15168 (xfont_open): Avoid unnecessary tests.
bc7b6697 15169
27ccc379
PE
15170 * composite.c (composition_gstring_put_cache): Use unsigned integer.
15171
dcd5c89a
PE
15172 * composite.h, composite.c (composition_gstring_put_cache):
15173 Use EMACS_INT, not int, for length.
15174
b13a45c6
PE
15175 * composite.h (COMPOSITION_DECODE_REFS): New macro,
15176 breaking out part of COMPOSITION_DECODE_RULE.
15177 (COMPOSITION_DECODE_RULE): Use it.
15178 * composite.c (get_composition_id): Remove unused local vars,
15179 by using the new macro.
15180
1e792e4d
PE
15181 * textprop.c (set_text_properties_1): Change while to do-while,
15182 since the condition is always true at first.
15183
dc6c6455 15184 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
15185 (interval_deletion_adjustment): Return unsigned value.
15186 All uses changed.
dc6c6455 15187
aba7731a
PE
15188 * process.c (list_processes_1, create_pty, read_process_output):
15189 (exec_sentinel): Remove vars that were set but not used.
afd4052b 15190 (create_pty): Remove unnecessary "volatile"s.
bc57d757 15191 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 15192 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 15193 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 15194
fdfc4bf3
PE
15195 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
15196
fca8fe46 15197 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 15198 (update_syntax_table): Use unsigned instead of int.
fca8fe46 15199
06a0259a 15200 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 15201 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 15202 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 15203
e7b9e80f
PE
15204 * print.c (print_error_message): Avoid int overflow.
15205
56201685
PE
15206 * font.c (font_list_entities): Redo for clarity,
15207 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
15208
78834453 15209 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 15210 (font_score): Avoid potential overflow in diff calculation.
78834453 15211
0bc0b309 15212 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 15213 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 15214
e610eaca
PE
15215 * eval.c (funcall_lambda): Rename local to avoid shadowing.
15216
b895abce
PE
15217 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
15218 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
15219 can always succeed if overflow has undefined behavior.
15220
1f1d9321 15221 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 15222 (wordify): Omit three unnecessary tests.
1f1d9321 15223
c59478bc
PE
15224 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
15225 All callers changed. This avoids the need for an unused var.
15226
79b73827
PE
15227 * casefiddle.c (casify_region): Remove var that is set but not used.
15228
a4db5dfe
PE
15229 * dired.c (file_name_completion): Remove var that is set but not used.
15230
43aae36e
PE
15231 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
15232
2a47c44d 15233 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 15234 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 15235
a37c69bf
PE
15236 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
15237 Check for integer overflow on size calculations.
15238
328ab8e7
PE
15239 * buffer.c (Fprevious_overlay_change): Remove var that is set
15240 but not used.
15241
e5a2a5cb
PE
15242 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
15243 Remove vars that are set but not used.
8d84a6eb 15244 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 15245 (timer_check_2): Mark vars as initialized.
e5a2a5cb 15246
a60e5f68
PE
15247 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
15248
f661cb61 15249 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 15250 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 15251
f0397f5a
PE
15252 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
15253 that are set but not used.
15254
8664db06 15255 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 15256 if XCreateBitmapFromData fails (Bug#8410).
8664db06 15257
6abdaa4a
PE
15258 * xselect.c (x_get_local_selection, x_handle_property_notify):
15259 Remove vars that are set but not used.
15260
0ce7538d 15261 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 15262 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 15263
9ae848fc
PE
15264 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
15265 Remove var that is set but not used.
0b918413
PE
15266 (scroll_bar_windows_size): Now size_t, not int.
15267 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
15268 Check for overflow.
9ae848fc 15269
a5a62657
PE
15270 * xfaces.c (realize_named_face): Remove vars that are set but not used.
15271 (map_tty_color) [!defined MSDOS]: Likewise.
15272
5c5cdd39
PE
15273 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
15274
66ebf983
PE
15275 * coding.c: Remove vars that are set but not used.
15276 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
15277 All callers changed.
15278 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
15279 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
15280 (decode_coding_charset): Remove vars that are set but not used.
15281
1be4d761
PE
15282 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
15283 that is set but not used.
15284
47553fa8
PE
15285 * print.c (print_object): Remove var that is set but not used.
15286
1f7196bf 15287 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
15288 The gnulib version avoids calling malloc in the usual case,
15289 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
15290 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
15291 * filelock.c (current_lock_owner): Likewise.
15292 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
15293 * sysdep.c: Include allocator.h, careadlinkat.h.
15294 (emacs_no_realloc_allocator): New static constant.
15295 (emacs_readlink): New function.
fdb61804
PE
15296 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
15297 ../lib/careadlinkat.h.
d1fdcab7 15298
f84c17c7
SM
152992011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
15300
15301 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
15302 first non-nil return value).
15303
ef3862ad
JD
153042011-04-03 Jan Djärv <jan.h.d@swipnet.se>
15305
15306 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
15307 if not defined (Bug#8403).
15308
376a7006
JB
153092011-04-02 Juanma Barranquero <lekktu@gmail.com>
15310
15311 * xdisp.c (display_count_lines): Remove parameter `start',
15312 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15313 (get_char_face_and_encoding): Remove parameter `multibyte_p',
15314 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15315 (fill_stretch_glyph_string): Remove parameters `row' and `area',
15316 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
15317 and thereabouts. All callers changed.
15318 (get_per_char_metric): Remove parameter `f', unused since
15319 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15320
6ca3801d
JM
153212011-04-02 Jim Meyering <meyering@redhat.com>
15322
15323 do not dereference NULL upon failed strdup
15324 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
15325 (ns_get_family): Likewise.
15326
d8e2b5ba
JB
153272011-04-02 Juanma Barranquero <lekktu@gmail.com>
15328
15329 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
15330
8c74fcbd
JD
153312011-04-02 Jan Djärv <jan.h.d@swipnet.se>
15332
15333 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
15334 later (Bug#8403).
15335
7200d79c
SM
153362011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
15337
03408648 15338 Add lexical binding.
7200d79c 15339
03408648
SM
15340 * window.c (Ftemp_output_buffer_show): New fun.
15341 (Fsave_window_excursion):
15342 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
15343
15344 * lread.c (lisp_file_lexically_bound_p): New function.
15345 (Fload): Bind Qlexical_binding.
15346 (readevalloop): Remove `evalfun' arg.
15347 Bind Qinternal_interpreter_environment.
15348 (Feval_buffer): Bind Qlexical_binding.
15349 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
15350 Mark as dynamic.
15351 (syms_of_lread): Declare `lexical-binding'.
15352
15353 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
15354
15355 * keyboard.c (eval_dyn): New fun.
15356 (menu_item_eval_property): Use it.
ca105506
SM
15357
15358 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 15359
03408648
SM
15360 * fns.c (concat, mapcar1): Accept byte-code-functions.
15361
15362 * eval.c (Fsetq): Handle lexical vars.
15363 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
15364 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
15365 (FletX, Flet): Obey lexical binding.
15366 (Fcommandp): Handle closures.
15367 (Feval): New `lexical' arg.
15368 (eval_sub): New function extracted from Feval. Use it almost
15369 everywhere where Feval was used. Look up vars in lexical env.
15370 Handle closures.
15371 (Ffunctionp): Move from subr.el.
15372 (Ffuncall): Handle closures.
15373 (apply_lambda): Remove `eval_flags'.
15374 (funcall_lambda): Handle closures and new byte-code-functions.
15375 (Fspecial_variable_p): New function.
15376 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
15377 but without exporting it to Lisp.
23aba0ea 15378
23aba0ea 15379 * doc.c (Fdocumentation, store_function_docstring):
03408648 15380 * data.c (Finteractive_form): Handle closures.
23aba0ea 15381
03408648
SM
15382 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
15383 interactive spec.
ba83908c 15384
04f2d78b
CB
15385 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
15386 New byte-codes.
03408648
SM
15387 (exec_byte_code): New function extracted from Fbyte_code to handle new
15388 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 15389
03408648 15390 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 15391
03408648 15392 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 15393
e2abce01
JB
153942011-03-31 Juanma Barranquero <lekktu@gmail.com>
15395
15396 * xdisp.c (redisplay_internal): Fix prototype.
15397
63696a73 153982011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 15399
63696a73 15400 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
15401 (try_scrolling): Use it when setting scroll_limit.
15402 Limit scrolling to 100 screen lines.
63696a73
EZ
15403 (redisplay_window): Even when falling back on "recentering",
15404 position point in the window according to scroll-conservatively,
15405 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
15406
15407 (try_scrolling): When point is above the window, allow searching
15408 as far as scroll_max, or one screenful, to compute vertical
15409 distance from PT to the scroll margin position. This prevents
15410 try_scrolling from unnecessarily failing when
15411 scroll-conservatively is set to a value slightly larger than the
15412 window height. Clean up the case of PT below the margin at bottom
15413 of window: scroll_max can no longer be INT_MAX. When aggressive
15414 scrolling is in use, don't let point enter the opposite scroll
15415 margin as result of the scroll.
15416 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
15417 threshold of 100 lines for never-recentering scrolling.
15418
e4cc2dfc
JB
154192011-03-31 Juanma Barranquero <lekktu@gmail.com>
15420
15421 * dispextern.h (move_it_by_lines):
15422 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
15423 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
15424 (message_log_check_duplicate): Remove parameters `prev_bol' and
15425 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15426 (redisplay_internal): Remove parameter `preserve_echo_area',
15427 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
15428
15429 * indent.c (Fvertical_motion):
15430 * window.c (window_scroll_pixel_based, Frecenter):
15431 Don't pass `need_y_p' to `move_it_by_lines'.
15432
1c470562
SM
154332011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
15434
44f230aa
SM
15435 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
15436 steal a few bits to be more compact.
15437 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
15438 Remove unneeded casts.
15439
1c470562
SM
15440 * bytecode.c (Fbyte_code): CAR and CDR can GC.
15441
888adce9
ZK
154422011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
15443
15444 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
15445 binding" message (bug#7967).
15446
f838ed7b
PE
154472011-03-30 Paul Eggert <eggert@cs.ucla.edu>
15448
77861b95
PE
15449 Fix more problems found by GCC 4.6.0's static checks.
15450
de6dbc14
PE
15451 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
15452 Remove unused local var.
15453
f838ed7b
PE
15454 * editfns.c (Fmessage_box): Remove unused local var.
15455
792c7b2b
PE
15456 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
15457 (note_mode_line_or_margin_highlight, note_mouse_highlight):
15458 Omit unused local vars.
c499e557 15459 * window.c (shrink_windows): Omit unused local var.
b01a1c29 15460 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
15461 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
15462 Omit unused local var.
15463
ba0165e1
PE
15464 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
15465 Don't assume string length fits in int.
32ad8845 15466 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 15467 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 15468
3c59b4c9
PE
15469 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
15470 instead of alloca (Bug#8344).
15471
a3eed478 15472 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 15473 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 15474
eb4d412d
PE
15475 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
15476
1658b401
PE
15477 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
15478 concerns.
15479
15480 * term.c (produce_glyphless_glyph): Remove unnecessary test.
15481
15482 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 15483
9a2c6e05
PE
15484 * keyboard.c (syms_of_keyboard): Use the same style as later
15485 in this function when indexing through an array. This also
15486 works around GCC bug 48267.
15487
03d0a109
PE
15488 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
15489
44f730c8
PE
15490 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
15491
fe75f926
PE
15492 * chartab.c (sub_char_table_ref_and_range): Redo for slight
15493 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
15494
ffa8c828
PE
15495 * keyboard.c, keyboard.h (num_input_events): Now size_t.
15496 This avoids undefined behavior on integer overflow, and is a bit
15497 more convenient anyway since it is compared to a size_t variable.
15498
c5101a77
PE
15499 Variadic C functions now count arguments with size_t, not int.
15500 This avoids an unnecessary limitation on 64-bit machines, which
15501 caused (substring ...) to crash on large vectors (Bug#8344).
15502 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
15503 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 15504 All variadic functions and their callers changed accordingly.
c5101a77
PE
15505 (struct gcpro.nvars): Now size_t, not int. All uses changed.
15506 * data.c (arith_driver, float_arith_driver): Likewise.
15507 * editfns.c (general_insert_function): Likewise.
15508 * eval.c (struct backtrace.nargs, interactive_p)
15509 (internal_condition_case_n, run_hook_with_args, apply_lambda)
15510 (funcall_lambda, mark_backtrace): Likewise.
15511 * fns.c (concat): Likewise.
15512 * frame.c (x_set_frame_parameters): Likewise.
15513 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
15514 0 if not found, not -1. All callers changed.
15515
dd3f25f7
PE
15516 * alloc.c (garbage_collect): Don't assume stack size fits in int.
15517 (stack_copy_size): Now size_t, not int.
15518 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
15519
461c2ab9
JB
155202011-03-28 Juanma Barranquero <lekktu@gmail.com>
15521
15522 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
15523 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15524 All callers changed.
15525
15526 * lisp.h (multibyte_char_to_unibyte):
15527 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
15528 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15529 * character.h (CHAR_TO_BYTE8):
15530 * cmds.c (internal_self_insert):
15531 * editfns.c (general_insert_function):
15532 * keymap.c (push_key_description):
15533 * search.c (Freplace_match):
15534 * xdisp.c (message_dolog, set_message_1): All callers changed.
15535
f6d62986
SM
155362011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
15537
15538 * keyboard.c (safe_run_hook_funcall): New function.
15539 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
15540 don't set the hook to nil, but remove the offending function instead.
15541 (Qcommand_hook_internal): Remove, unused.
15542 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
15543 Vcommand_hook_internal.
15544
15545 * eval.c (enum run_hooks_condition): Remove.
15546 (funcall_nil, funcall_not): New functions.
15547 (run_hook_with_args): Call each function through a `funcall' argument.
15548 Remove `cond' argument, now redundant.
15549 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
15550 (Frun_hook_with_args_until_failure): Adjust accordingly.
15551 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
15552
1db5b1ad
JB
155532011-03-28 Juanma Barranquero <lekktu@gmail.com>
15554
15555 * dispextern.h (string_buffer_position): Remove declaration.
15556
15557 * print.c (strout): Remove parameter `multibyte', unused since
15558 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
15559
15560 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
15561 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
15562 All callers changed.
15563
15564 * w32.c (_wsa_errlist): Use braces for struct initializers.
15565
15566 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
15567 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
15568 All callers changed.
15569 (string_buffer_position): Likewise. Also, make static (it's never
15570 used outside xdisp.c).
15571 (cursor_row_p): Remove parameter `w', unused since
15572 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
15573 (decode_mode_spec): Remove parameter `precision', introduced during
15574 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
15575 All callers changed.
15576
5ffb62aa
JD
155772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15578
15579 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
15580
461c2ab9 155812011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
15582
15583 * nsterm.m (ns_menu_bar_is_hidden): New variable.
15584 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
15585 (ns_update_auto_hide_menu_bar): New functions.
15586 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
15587 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
15588 ns_constrain_all_frames.
15589 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
15590 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
15591
5c380ffb
JD
155922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15593
15594 * nsmenu.m (runDialogAt): Remove argument to timer_check.
15595
9af30bdf
GM
155962011-03-27 Glenn Morris <rgm@gnu.org>
15597
15598 * syssignal.h: Replace RETSIGTYPE with void.
15599 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
15600 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
15601 Replace SIGTYPE with void everywhere.
15602 * s/usg5-4-common.h (SIGTYPE): Remove definition.
15603 * s/template.h (SIGTYPE): Remove commented out definition.
15604
e2abce01
JB
156052011-03-26 Eli Zaretskii <eliz@gnu.org>
15606
15607 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
15608 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
15609
f868cd8a
JB
156102011-03-26 Juanma Barranquero <lekktu@gmail.com>
15611
59eb0929
JB
15612 * w32.c (read_unc_volume): Use parameter `henum', instead of
15613 global variable `wget_enum_handle'.
15614
15615 * keymap.c (describe_vector): Remove parameters `indices' and
15616 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
15617 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
15618
f868cd8a
JB
15619 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
15620
15621 * keyboard.c (timer_check): Remove parameter `do_it_now',
15622 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
15623 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
15624 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
15625
15626 * keyboard.c (read_char):
15627 * w32menu.c (w32_menu_display_help):
15628 * xmenu.c (show_help_event, menu_help_callback):
15629 Adjust calls to `show_help_echo'.
15630
15631 * gtkutil.c (xg_maybe_add_timer):
15632 * keyboard.c (readable_events):
15633 * process.c (wait_reading_process_output):
15634 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
15635
15636 * insdel.c (adjust_markers_gap_motion):
15637 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
15638 (gap_left, gap_right): Don't call it.
15639
2ecf6fdb
CY
156402011-03-25 Chong Yidong <cyd@stupidchicken.com>
15641
15642 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
15643 incurred during fontification.
15644
6b1f9ba4
JB
156452011-03-25 Juanma Barranquero <lekktu@gmail.com>
15646
15647 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
15648 (DEFVAR_PER_BUFFER): Don't pass it.
15649
15650 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
15651 (scrolling_window): Don't pass it.
15652
0f4a96b5
JB
156532011-03-25 Juanma Barranquero <lekktu@gmail.com>
15654
15655 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
15656
15657 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
15658 and `suffix'.
15659 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
15660 of variables specific to SELinux and computation of `encoded_absname'.
15661
15662 * image.c (XPutPixel): Remove unused variable `height'.
15663
15664 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
15665
15666 * unexw32.c (get_section_info): Remove unused variable `section'.
15667
15668 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
15669 (system_process_attributes): Remove unused variable `sess'.
15670 (sys_read): Remove unused variable `err'.
15671
15672 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
15673 (w32_wnd_proc): Remove unused variable `isdead'.
15674 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
15675 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
15676 (x_create_tip_frame): Remove unused variable `tem'.
15677
15678 * w32inevt.c (w32_console_read_socket):
15679 Remove unused variable `no_events'.
15680
15681 * w32term.c (x_draw_composite_glyph_string_foreground):
15682 Remove unused variable `width'.
15683
1149507c
JB
156842011-03-24 Juanma Barranquero <lekktu@gmail.com>
15685
15686 * w32term.c (x_set_glyph_string_clipping):
15687 Don't pass uninitialized region to CombineRgn.
15688
9c88f339
JB
156892011-03-23 Juanma Barranquero <lekktu@gmail.com>
15690
15691 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
15692 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
15693 (Fx_close_connection): Remove unused variable `i'.
15694
15695 * w32font.c (w32font_draw): Return number of glyphs.
15696 (w32font_open_internal): Remove unused variable `i'.
15697 (w32font_driver): Add missing initializer.
15698
15699 * w32menu.c (utf8to16): Remove unused variable `utf16'.
15700 (fill_in_menu): Remove unused variable `items_added'.
15701
15702 * w32term.c (last_mouse_press_frame): Remove static global variable.
15703 (w32_clip_to_row): Remove unused variable `f'.
15704 (x_delete_terminal): Remove unused variable `i'.
15705
15706 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
15707 (NOTHING): Remove unused static global variable.
15708 (uniscribe_check_otf): Remove unused variable `table'.
15709 (uniscribe_font_driver): Add missing initializers.
15710
dee091a3
JD
157112011-03-23 Julien Danjou <julien@danjou.info>
15712
15713 * term.c (Fsuspend_tty, Fresume_tty):
15714 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
15715 * window.c (temp_output_buffer_show):
15716 * insdel.c (signal_before_change):
15717 * frame.c (Fhandle_switch_frame):
15718 * fileio.c (Fdo_auto_save):
15719 * emacs.c (Fkill_emacs):
15720 * editfns.c (save_excursion_restore):
15721 * cmds.c (internal_self_insert):
15722 * callint.c (Fcall_interactively):
15723 * buffer.c (Fkill_all_local_variables):
15724 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
15725 Use Frun_hooks.
0f4a96b5 15726 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 15727 unconditionally since it does the check itself.
dee091a3 15728
2c520ab5 157292011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 15730
c9c49752
PE
15731 Fix more problems found by GCC 4.5.2's static checks.
15732
8abc3f12
PE
15733 * coding.c (encode_coding_raw_text): Avoid unnecessary test
15734 the first time through the loop, since we know p0 < p1 then.
15735 This also avoids a gcc -Wstrict-overflow warning.
15736
a2d26660
PE
15737 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
15738 leading to a memory leak, possible in functions like
15739 load_charset_map_from_file that can allocate an unbounded number
b12ef411 15740 of objects (Bug#8318).
a2d26660 15741
916c72e9
PE
15742 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
15743 that could (at least in theory) be that large.
15744
19ab8a18
PE
15745 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
15746 This is less likely to overflow, and avoids undefined behavior if
15747 overflow does occur. All callers changed. Use strtoul to scan
15748 for the unsigned long integer.
b7cbbd6f
PE
15749 (pint2hrstr): Simplify and tune code slightly.
15750 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 15751
f0641eff
PE
15752 * scroll.c (do_scrolling): Work around GCC bug 48228.
15753 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
15754
7f650bb9
PE
15755 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
15756 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
15757 (validate_x_resource_name): Simplify count usage.
15758 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 15759
37dd57d1
PE
15760 * fileio.c (Fcopy_file): Report error if fchown or fchmod
15761 fail (Bug#8306).
81e56e61 15762
699979fc 15763 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 15764
401bf9b4
PE
15765 * process.c (Fmake_network_process): Use socklen_t, not int,
15766 where POSIX says socklen_t is required in portable programs.
15767 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 15768 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
15769 (Fmake_network_process, server_accept_connection):
15770 (wait_reading_process_output, read_process_output):
15771 Likewise.
15772
b93aacde
PE
15773 * process.c: Rename or move locals to avoid shadowing.
15774 (list_processes_1, Fmake_network_process):
15775 (read_process_output_error_handler, exec_sentinel_error_handler):
15776 Rename or move locals.
4dc343ee 15777 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 15778 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 15779 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 15780 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 15781 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 15782
af8a867c 15783 Make tparam.h and terminfo.c consistent.
44f230aa
SM
15784 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
15785 Include tparam.h instead, since it declares them.
af8a867c
PE
15786 * cm.h (PC): Remove extern decl; tparam.h now does this.
15787 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
15788 * terminfo.c: Include tparam.h, to check interfaces.
15789 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
15790 (tparam): Adjust signature to match interface in tparam.h;
15791 this removes some undefined behavior. Check that outstring and len
15792 are zero, which they always are with Emacs.
15793 * tparam.h (PC, BC, UP): New extern decls.
15794
0248044d 15795 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 15796 (xftfont_open): Rename locals to avoid shadowing.
0248044d 15797
8ff096c1 15798 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
15799 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
15800 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 15801 (ftfont_list): Remove unused local.
49eaafba
PE
15802 (get_adstyle_property, ftfont_pattern_entity):
15803 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
15804 Rename locals to avoid shadowing.
8ff096c1 15805
e2be39f6
PE
15806 * xfont.c (xfont_list_family): Mark var as initialized.
15807
c9735e30
PE
15808 * xml.c (make_dom): Now static.
15809
8f5201ae
PE
15810 * composite.c (composition_compute_stop_pos): Rename local to
15811 avoid shadowing.
b246f932
PE
15812 (composition_reseat_it): Remove unused locals.
15813 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 15814 (composition_update_it): Mark var as initialized.
11b61122
PE
15815 (find_automatic_composition): Mark vars as initialized,
15816 with a FIXME (Bug#8290).
8f5201ae 15817
760fbc2c
PE
15818 character.h: Rename locals to avoid shadowing.
15819 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
15820 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
15821 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
15822 (BUF_DEC_POS): Be more systematic about renaming local temporaries
15823 to avoid shadowing.
15824
ff08eb85
PE
15825 * textprop.c (property_change_between_p): Remove; unused.
15826
fc7bf025
PE
15827 * intervals.c (interval_start_pos): Now static.
15828
235d7abc
PE
15829 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
15830
44f230aa
SM
15831 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
15832 Rename locals to avoid shadowing.
3e7d6594 15833
50060332
PE
15834 * sound.c (wav_play, au_play, Fplay_sound_internal):
15835 Fix pointer signedness.
d01f234b 15836 (alsa_choose_format): Remove unused local var.
c83b8872
PE
15837 (wav_play): Initialize a variable to 0, to prevent undefined
15838 behavior (Bug#8278).
50060332 15839
c4fc4e30
PE
15840 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
15841
918436ed
PE
15842 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
15843
c939f91b
PE
15844 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
15845 clobbering (Bug#8298).
b9c7f648
PE
15846 * sysdep.c (sys_subshell): Likewise.
15847 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 15848
6bd8c144
PE
15849 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
15850 This should get cleaned up, so that child_setup has the
15851 same signature on all platforms.
15852
7710357c 15853 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 15854 (relocate_fd): Rename locals to avoid shadowing.
7710357c 15855
c59da222
CY
158562011-03-22 Chong Yidong <cyd@stupidchicken.com>
15857
15858 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
15859 not to be necessary, and produces flickering.
15860
66b87493
GM
158612011-03-20 Glenn Morris <rgm@gnu.org>
15862
15863 * config.in: Remove file.
15864
45b6f6d5
JB
158652011-03-20 Juanma Barranquero <lekktu@gmail.com>
15866
15867 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
15868 are now in src/globals.h.
15869 (syms_of_minibuf): Remove spurious & from previous change.
15870
cd394be1 158712011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
15872
15873 * minibuf.c (completing-read-function): New variable.
15874 (completing-read-default): Rename from completing-read.
15875 (completing-read): Call completing-read-function.
15876
b14e3e21
CY
158772011-03-19 Juanma Barranquero <lekktu@gmail.com>
15878
15879 * xfaces.c (Fx_load_color_file):
15880 Read color file from absolute filename (bug#8250).
15881
f2b726e6
JB
158822011-03-19 Juanma Barranquero <lekktu@gmail.com>
15883
15884 * makefile.w32-in: Update dependencies.
15885
09f6ff02
EZ
158862011-03-17 Eli Zaretskii <eliz@gnu.org>
15887
15888 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
15889
29a6015a
PE
158902011-03-17 Paul Eggert <eggert@cs.ucla.edu>
15891
a3a6c54e
PE
15892 Fix more problems found by GCC 4.5.2's static checks.
15893
b766f867
PE
15894 * process.c (make_serial_process_unwind, send_process_trap):
15895 (sigchld_handler): Now static.
15896
be02381c
PE
15897 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
15898 That way, the code declares only the vars that it needs.
15899 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
15900 * s/cygwin.h (PTY_ITERATION): Likewise.
15901 * s/darwin.h (PTY_ITERATION): Likewise.
15902 * s/gnu-linux.h (PTY_ITERATION): Likewise.
15903
57048744
PE
15904 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
15905 * process.c (allocate_pty): Don't declare stb unless it's needed.
15906
7914961c 15907 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
15908 (CONSTANTLIM): Remove; unused.
15909 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
15910 Define only if needed.
7914961c 15911
b3967b18
PE
15912 * unexelf.c (unexec): Name an expression,
15913 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
15914 Use a different way to cause a compilation error if anyone uses
15915 n rather than nn, a way that does not involve shadowing.
73366a00 15916 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 15917
29a6015a
PE
15918 * deps.mk (unexalpha.o): Remove; unused.
15919
43cfc33e 15920 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 15921 * unexec.h: New file.
ce701a33
PE
15922 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
15923 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
15924 Depend on unexec.h.
15925 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
15926 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
15927 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 15928 Change as necessary to match prototype in unexec.h.
ce701a33 15929
01f44d5a
PE
15930 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
15931 shadowing.
4f63c6bb 15932 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 15933
a6670b0b
PE
15934 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
15935 Rename locals to avoid shadowing.
15936
cef2010d 15937 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 15938 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 15939
d4d7173a
PE
15940 * print.c (Fredirect_debugging_output): Fix pointer signedess.
15941
f08b802a
PE
15942 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
15943 warning when compiling print.c.
15944
3ddb0639
PE
15945 * font.c (font_unparse_fcname): Abort in an "impossible" situation
15946 instead of using an uninitialized var.
5ad03b97 15947 (font_sort_entities): Mark var as initialized.
3ddb0639 15948
170a2692
PE
15949 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
15950
e663c700
PE
15951 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
15952 pointers to constants.
89bc529a 15953 (font_parse_fcname): Remove unused vars.
7b81e2d0 15954 (font_delete_unmatched): Now static.
ea838e10 15955 (font_get_spec): Remove; unused.
13a547c6
PE
15956 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
15957 (font_update_drivers, Ffont_get_glyphs, font_add_log):
15958 Rename or move locals to avoid shadowing.
e663c700 15959
2a80c887 15960 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 15961 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 15962
1384fa33 15963 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 15964 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 15965
8b2c52e9
PE
15966 * alloc.c (mark_backtrace): Move decl from here ...
15967 * lisp.h: ... to here, so that it can be checked.
15968
475545b5 15969 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 15970 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
15971 (lisp_indirect_variable): Name an expression,
15972 to avoid gcc -Wbad-function-cast warning.
1faed8ae 15973 (Fdefvar): Rename locals to avoid shadowing.
475545b5 15974
b1349114 15975 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 15976 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 15977 Use const pointer when appropriate.
b1349114 15978
a2928364
PE
15979 * lisp.h (get_system_name, get_operating_system_release):
15980 Move decls here, to check interfaces.
15981 * process.c (get_operating_system_release): Move decl to lisp.h.
15982 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
15983 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
15984 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
15985 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
15986 (Fformat_time_string, Fencode_time, Finsert_char):
15987 (Ftranslate_region_internal, Fformat):
15988 Rename or remove local vars to avoid shadowing.
9710023e 15989 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 15990
a415e694
PE
15991 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
15992 avoid shadowing.
15993
8ef4622d
PE
15994 * lisp.h (eassert): Check that the argument compiles, even if
15995 ENABLE_CHECKING is not defined.
15996
946f9a5b
PE
15997 * data.c (Findirect_variable): Name an expression, to avoid
15998 gcc -Wbad-function-cast warning.
112396d6 15999 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 16000 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
16001 (Fmake_variable_buffer_local, Fmake_local_variable):
16002 Mark variables as initialized.
52746918 16003 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 16004
e5aab7e7 16005 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
16006 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
16007 Rename locals to avoid shadowing.
dff45157
PE
16008 (mark_stack): Move local variables into the #ifdef region where
16009 they're used.
7bc26fdb
PE
16010 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
16011 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
16012 needed otherwise.
16013 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
16014 (GC_STRING_CHARS): Remove; not used.
d40d4be1 16015 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 16016
e5aab7e7
PE
16017 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
16018 avoids undefined behavior in theory.
16019
4da60324
PE
16020 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
16021
88043301
PE
16022 Use functions, not macros, for up- and down-casing (Bug#8254).
16023 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16024 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
16025 to use the following functions instead of these macros.
16026 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
16027 EMACS_INT, since callers assume the returned value fits in int.
16028 (upcase1): Likewise, for UPCASE_TABLE.
16029 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 16030 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 16031 the race-condition problem in the old DOWNCASE.
88043301 16032
19ed5445
PE
16033 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
16034 Rename locals to avoid shadowing.
16035 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
16036 (regex_compile, re_search_2, re_match_2_internal):
16037 Remove unused local vars.
952db0d7
PE
16038 (FREE_VAR): Rewrite so as not to use empty "else",
16039 which gcc can warn about.
da053e48 16040 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
16041 (RETALLOC_IF): Define only if needed.
16042 (WORDCHAR_P): Likewise. This one is never needed, but is used
16043 only in a comment talking about a compiler bug, so put inside
16044 the #if 0 of that comment.
16045 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
16046 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
16047 Remove; unused.
19ed5445 16048
1f3561e4 16049 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
16050 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
16051 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 16052
ded6f8f7
PE
16053 * search.c (simple_search): Remove unused var.
16054
dbd37a95
PE
16055 * dired.c (compile_pattern): Move decl from here ...
16056 * lisp.h: ... to here, so that it can be checked.
16057 (struct re_registers): New forward decl.
16058
7e47afad
PE
16059 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
16060
85f24f61
PE
16061 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
16062 All uses changed.
16063 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
16064 Rename locals to avoid shadowing.
5671df8f 16065 (Fvertical_motion): Mark locals as initialized.
85f24f61 16066
181aa2be 16067 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 16068 (casify_region): Mark local as initialized.
181aa2be 16069
930d429c
PE
16070 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
16071
7082eac6
PE
16072 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
16073 New macros, so that the caller can use some names other than
16074 gcpro1, gcpro2, etc.
16075 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
16076 of the new macros.
16077 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
16078 argument, for consistency with GCPRO2_VAR, etc: it is now the
16079 prefix of the variable, not the variable itself. All uses
16080 changed.
38b2c076
PE
16081 * dired.c (directory_files_internal, file_name_completion):
16082 Rename locals to avoid shadowing.
16083
15206ed9
PE
16084 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
16085 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
16086 dired.c's scmp function, had undefined behavior.
16087 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16088 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
16089 * buffer.h: ... to here, because these macros use current_buffer,
16090 and the new implementation with inline functions needs to have
16091 current_buffer in scope now, rather than later when the macros
16092 are used.
16093 (downcase, upcase1): New static inline functions.
16094 (DOWNCASE, UPCASE1): Reimplement using these functions.
16095 This avoids undefined behavior in expressions like
16096 DOWNCASE (x) == DOWNCASE (y), which previously suffered
16097 from race conditions in accessing the global variables
16098 case_temp1 and case_temp2.
16099 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
16100 * lisp.h (case_temp1, case_temp2): Remove their decls.
16101 * character.h (ASCII_CHAR_P): Move from here ...
16102 * lisp.h: ... to here, so that the inline functions mentioned
16103 above can use them.
16104
4a6bea26
PE
16105 * dired.c (directory_files_internal_unwind): Now static.
16106
f14b7e14
PE
16107 * fileio.c (file_name_as_directory, directory_file_name):
16108 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
16109 Now static.
2893f146
PE
16110 (file_name_as_directory): Use const pointers when appropriate.
16111 (Fexpand_file_name): Likewise. In particular, newdir might
16112 point at constant storage, so make it a const pointer.
fd4ead52 16113 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
16114 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
16115 signedness issues.
f839df0c
PE
16116 (Fset_file_times, Finsert_file_contents, auto_save_error):
16117 Rename locals to avoid shadowing.
f14b7e14 16118
5716756e 16119 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
16120 (Ftry_completion, Fall_completions): Rename or remove locals
16121 to avoid shadowing.
5716756e 16122
b4c3046a
PE
16123 * marker.c (bytepos_to_charpos): Remove; unused.
16124
b45db522
PE
16125 * lisp.h (verify_bytepos, count_markers): New decls,
16126 so that gcc does not warn that these functions aren't declared.
16127
85876d07
PE
16128 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
16129 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 16130 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 16131 (copy_text): Remove unused local var.
85876d07 16132
03d78a21 16133 * filelock.c (within_one_second): Now static.
b3dd38ab 16134 (lock_file_1): Rename local to avoid shadowing.
03d78a21 16135
5df8f01b
PE
16136 * buffer.c (fix_overlays_before): Mark locals as initialized.
16137 (fix_start_end_in_overlays): Likewise. This function should be
16138 simplified by using pointers-to-pointers, but that's a different
16139 matter.
b1d876f1 16140 (switch_to_buffer_1): Now static.
8f54f30a
PE
16141 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
16142 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 16143
a70072c9 16144 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 16145 Fix pointer signedness issue.
edced198
PE
16146 (sys_subshell): Mark local as volatile if checking for lint,
16147 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 16148 (MAXPATHLEN): Define only if needed.
a70072c9 16149
a0977c44
PE
16150 * process.c (serial_open, serial_configure): Move decls from here ...
16151 * systty.h: ... to here, so that they can be checked.
16152
a884fdcc
PE
16153 * fns.c (get_random, seed_random): Move extern decls from here ...
16154 * lisp.h: ... to here, so that they can be checked.
16155
604efe86 16156 * sysdep.c (reset_io): Now static.
b8950c94 16157 (wait_for_termination_signal): Remove; unused.
604efe86 16158
38fc62d9
PE
16159 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
16160 (copy_keymap_item, append_key, push_text_char_description):
16161 Now static.
1004a21a 16162 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 16163 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
16164 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
16165 (describe_map_tree):
16166 Rename locals to avoid shadowing.
38fc62d9 16167
2f2650da
PE
16168 * keyboard.c: Declare functions static if they are not used elsewhere.
16169 (echo_char, echo_dash, cmd_error, top_level_2):
16170 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
16171 (read_char, kbd_buffer_get_event, make_lispy_position):
16172 (make_lispy_event, make_lispy_movement, apply_modifiers):
16173 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
16174 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
16175 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 16176 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 16177 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 16178
a053e86c 16179 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
16180 (mark_kboards): Move decl here ...
16181 * alloc.c (mark_kboards): ... from here.
a053e86c 16182
4752793e
PE
16183 * lisp.h (force_auto_save_soon): New decl.
16184
74f10ca7 16185 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
16186 (DEFINE_DUMMY_FUNCTION): New macro.
16187 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
16188 Use it.
c03cd23f
PE
16189 (main): Add casts to avoid warnings
16190 if GCC considers string literals to be constants.
74f10ca7 16191
022e70d4
PE
16192 * lisp.h (fatal_error_signal): Add decl, since it's exported.
16193
59d6fe83
PE
16194 * dbusbind.c: Pointer signedness fixes.
16195 (xd_signature, xd_append_arg, xd_initialize):
16196 (Fdbus_call_method, Fdbus_call_method_asynchronously):
16197 (Fdbus_method_return_internal, Fdbus_method_error_internal):
16198 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
16199 (Fdbus_register_signal): Use SSDATA when the context wants char *.
16200
78320123
PE
16201 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
16202 if GCC considers string literals to be constants.
49cebcca 16203 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 16204
35ac2a97
SM
162052011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
16206
fb103ca9
SM
16207 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
16208 (print_preprocess, print_object): New macro to fix last change.
16209
35ac2a97
SM
16210 * print.c (print_preprocess): Don't forget font objects.
16211
62973b41
JB
162122011-03-16 Juanma Barranquero <lekktu@gmail.com>
16213
16214 * emacs.c (USAGE3): Doc fixes.
16215
0e48bb22
AS
162162011-03-15 Andreas Schwab <schwab@linux-m68k.org>
16217
16218 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
16219 structure.
16220
7684e57b
JB
162212011-03-14 Juanma Barranquero <lekktu@gmail.com>
16222
16223 * lisp.h (VWindow_system, Qfile_name_history):
16224 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
16225 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
16226 (w32_system_caret_x, w32_system_caret_y): Declare extern.
16227
16228 * w32select.c: Don't #include "keyboard.h".
c96bbc66 16229 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
16230
16231 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
16232 * w32console.c (detect_input_pending, read_input_pending)
16233 (encode_terminal_code):
16234 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
16235 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
16236 (w32_system_caret_y, Qfile_name_history):
16237 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
16238 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
16239 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
16240 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
16241 * w32proc.c (Qlocal, report_file_error):
16242 * w32term.c (Vwindow_system, updating_frame):
16243 * w32uniscribe.c (initialized, uniscribe_font_driver):
16244 Remove unneeded extern declarations.
16245
2aa46d6c
CY
162462011-03-14 Chong Yidong <cyd@stupidchicken.com>
16247
c96bbc66 16248 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 16249
cffc6f3b
CY
162502011-03-13 Chong Yidong <cyd@stupidchicken.com>
16251
16252 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
16253 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
16254 These macros can no longer be used for assignment.
16255
44f230aa
SM
16256 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
16257 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
16258 (record_buffer_markers, fetch_buffer_markers): New functions for
16259 recording and fetching special buffer markers.
16260 (set_buffer_internal_1, set_buffer_temp): Use them.
16261
16262 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
16263
16264 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
16265
16266 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
16267 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
16268
16269 * xdisp.c (hscroll_window_tree):
16270 (reconsider_clip_changes): Use PT instead of BUF_PT.
16271
d251f04b
EZ
162722011-03-13 Eli Zaretskii <eliz@gnu.org>
16273
16274 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
16275 $(EMACS_ROOT)/lib/intprops.h.
16276
f0c77cd1
PE
162772011-03-13 Paul Eggert <eggert@cs.ucla.edu>
16278
3eca4629
PE
16279 Fix more problems found by GCC 4.5.2's static checks.
16280
7c86ee98
PE
16281 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
16282 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
16283 (xg_free_frame_widgets): Make it clear that a local variable is
16284 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
16285 (gdk_window_get_screen): Make it clear that this macro is needed
16286 only if USE_GTK_TOOLTIP.
1e5524e7
PE
16287 (int_gtk_range_get_value): New function, which avoids a diagnostic
16288 from gcc -Wbad-function-cast.
16289 (xg_set_toolkit_scroll_bar_thumb): Use it.
16290 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
16291 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
16292 (get_utf8_string, xg_get_file_with_chooser):
16293 Rename locals to avoid shadowing.
16294 (create_dialog): Move locals to avoid shadowing.
7c86ee98 16295
41729b81
PE
16296 * xgselect.c (xg_select): Remove unused var.
16297
f0c77cd1
PE
16298 * image.c (four_corners_best): Mark locals as initialized.
16299 (gif_load): Initialize transparent_p to zero (Bug#8238).
16300 Mark another local as initialized.
ec6cf4c6 16301 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 16302
ce0ad53d 16303 * image.c (clear_image_cache): Now static.
d5d5a617 16304 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 16305 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
16306 (x_edge_detection): Remove unnecessary cast that
16307 gcc -Wbad-function-cast diagnoses.
2037898d 16308 (gif_load): Fix pointer signedness.
6ae141d6
PE
16309 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
16310 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 16311
33383987 163122011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 16313
d32df629
PE
16314 Improve quality of tests for time stamp overflow.
16315 For example, without this patch (encode-time 0 0 0 1 1
16316 1152921504606846976) returns the obviously-bogus value (-948597
16317 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
16318 reports time overflow. See
16319 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
16320 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
16321 * editfns.c: Include limits.h and intprops.h.
16322 (TIME_T_MIN, TIME_T_MAX): New macros.
16323 (time_overflow): Move earlier, to before first use.
16324 (hi_time, lo_time): New functions, for an accurate test for
16325 out-of-range times.
16326 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
16327 (Fget_internal_run_time): Don't assume time_t fits in int.
16328 (make_time): Use list2 instead of Fcons twice.
16329 (Fdecode_time): More accurate test for out-of-range times.
16330 (check_tm_member): New function.
16331 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
16332 (lisp_time_argument): Don't rely on undefined left-shift and
16333 right-shift behavior when checking for time stamp overflow.
8be6f318 16334
fe31d94c
PE
16335 * editfns.c (time_overflow): New function, refactoring common code.
16336 (Fformat_time_string, Fdecode_time, Fencode_time):
16337 (Fcurrent_time_string): Use it.
16338
8be6f318
PE
16339 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
16340 * dired.c (make_time): Move to ...
16341 * editfns.c (make_time): ... here.
16342 * systime.h: Note the move.
16343
09d9db2c 163442011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 16345
126bc0dc
YM
16346 * fringe.c (update_window_fringes): Remove unused variables.
16347
c47cbdfd
YM
16348 * unexmacosx.c (copy_data_segment): Also copy __got section.
16349 (Bug#8223)
16350
7ac80be9
EZ
163512011-03-12 Eli Zaretskii <eliz@gnu.org>
16352
c96bbc66 16353 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
16354 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
16355 Constify `char *' arguments and their references according to
16356 prototypes in tparam.h.
16357
ecb0f94d 16358 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 16359
7ac80be9
EZ
16360 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
16361 Adapt all references accordingly.
16362
16363 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
16364
ef1fd07e
TT
163652011-03-11 Tom Tromey <tromey@redhat.com>
16366
16367 * buffer.c (syms_of_buffer): Remove obsolete comment.
16368
7ef4b50c
EZ
163692011-03-11 Eli Zaretskii <eliz@gnu.org>
16370
16371 * termhooks.h (encode_terminal_code): Declare prototype.
16372
16373 * msdos.c (encode_terminal_code): Don't declare prototype.
16374
16375 * term.c (encode_terminal_code): Now external again, used by
16376 w32console.c and msdos.c.
16377
44f230aa
SM
16378 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
16379 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 16380
4b1ec863 163812011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 16382
1714f52b 16383 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 16384
4b1ec863
PE
16385 * fringe.c (update_window_fringes): Mark locals as initialized
16386 (Bug#8227).
16387 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 16388
524c7aa6
PE
16389 * alloc.c (mark_fringe_data): Move decl from here ...
16390 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
16391 to check its interface.
16392 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
16393
a5c0af81 16394 * fontset.c (free_realized_fontset): Now static.
7519b8cd 16395 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 16396 (fontset_font): Mark local as initialized.
a9a06e0b 16397 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 16398
b4716021
PE
16399 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
16400
811e9bac 16401 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 16402 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
16403 (x_own_selection, Fx_disown_selection_internal): Rename locals
16404 to avoid shadowing.
16405 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 16406
7e3ab302
PE
16407 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
16408 so that the caller can use some name other than gcpro1.
16409 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
16410 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16411 (Fx_backspace_delete_keys_p):
16412 Use them to avoid shadowing, and rename vars to avoid shadowing.
16413 (x_decode_color, x_set_name, x_window): Now static.
6b437900 16414 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 16415 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
16416 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
16417 Remove unused locals.
7e3ab302
PE
16418 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16419 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
16420 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
16421 macros.
f78faa98 16422
e2b13473
PE
16423 * xterm.h (x_mouse_leave): New decl.
16424
77f23912
PE
16425 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
16426 Remove unused functions.
cdf4ba58
PE
16427 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
16428 (x_calc_absolute_position): Now static.
7411c686 16429 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 16430 Don't declare local "event" unless it's used.
ed7bf3a5
PE
16431 (x_iconify_frame, x_free_frame_resources): Don't declare locals
16432 unless they are used.
38d0b34a
PE
16433 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
16434 (x_fatal_error_signal): Remove; not used.
a6067996
PE
16435 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
16436 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
16437 (x_error_catcher, x_connection_closed, x_error_handler):
16438 (x_error_quitter, xembed_send_message, x_iconify_frame):
16439 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 16440 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 16441 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 16442
44f230aa
SM
16443 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
16444 Rename or move locals to avoid shadowing.
6b463e58 16445 (tty_defined_color, merge_face_heights): Now static.
5967d051 16446 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
16447 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
16448 does not deduce is never used uninitialized.
73719eba
PE
16449 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
16450 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 16451
426994c3 16452 * terminal.c (store_terminal_param): Now static.
5489860b 16453
032f1620 16454 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 16455 (set_frame_menubar): Remove unused local.
d4323972 16456 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
16457 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
16458 since they might point to immutable storage.
281585b0
PE
16459 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
16460 since it's unused otherwise.
032f1620 16461
367c19e5 16462 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 16463 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
16464 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
16465 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 16466 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
16467 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
16468 does not deduce are never used uninitialized.
70739cbe 16469
07b48fa9
PE
16470 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
16471
8868a238 16472 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
16473 * window.c (window_loop, size_window):
16474 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 16475
7e5cf297 16476 * window.c (display_buffer): Now static.
d6550a9f
PE
16477 (size_window): Mark variables that gcc -Wuninitialized
16478 does not deduce are never used uninitialized.
a586633d
PE
16479 * window.h (check_all_windows): New decl, to forestall
16480 gcc -Wmissing-prototypes diagnostic.
5b555da1 16481 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 16482
f6095868
PE
16483 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
16484 shadowing.
16485 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
16486 Include <limits.h>.
16487 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
16488 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
16489 (load_charset_map): Mark variables that gcc -Wuninitialized
16490 does not deduce are never used uninitialized.
53df7c11 16491 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 16492
f38b440c
PE
16493 * coding.c (coding_set_source, coding_set_destination):
16494 Use "else { /* comment */ }" rather than "else /* comment */;"
16495 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
16496 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
16497 a block, when the outer 'i' will do.
16498 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
16499 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
16500 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
16501 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
16502 (Fdecode_sjis_char, Fdefine_coding_system_internal):
16503 Rename locals to avoid shadowing.
16504 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
16505 * coding.c (emacs_mule_char, encode_invocation_designation):
16506 Now static, since they're not used elsewhere.
413bb2db 16507 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 16508 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
16509 (decode_coding_emacs_mule): Mark variables that gcc
16510 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
16511 (detect_coding_iso_2022): Initialize a local variable that might
16512 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 16513 this initialization is needed. (Bug#8211)
5f58e762
PE
16514 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
16515 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
16516 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
16517 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
16518 Remove unused macros.
f38b440c 16519
232b38b9 16520 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 16521 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 16522 * character.c (string_count_byte8): Likewise.
232b38b9 16523
fb90da1b
PE
16524 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
16525 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
16526
fb93dbc2
PE
16527 * chartab.c (copy_sub_char_table): Now static, since it's not used
16528 elsewhere.
5c156ace
PE
16529 (sub_char_table_ref_and_range, char_table_ref_and_range):
16530 Rename locals to avoid shadowing.
bbcd0949 16531 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 16532
7d3b3862 16533 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 16534 (BIDI_BOB): Remove unused macro.
7d3b3862 16535
6be7d3da
PE
16536 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
16537 deduce are never used uninitialized.
c2ed9c8b 16538 * term.c (encode_terminal_code): Likewise.
6be7d3da 16539
75f8807f 16540 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 16541
50938595
PE
16542 * tparam.h: New file.
16543 * term.c, tparam.h: Include it.
16544 * deps.mk (term.o, tparam.o): Depend on tparam.h.
16545 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
16546 Move these decls to tparam.h, and make them agree with what
16547 is actually in tparam.c. The previous trick of using incompatible
16548 decls in different modules does not conform to the C standard.
16549 All callers of tparam changed to use tparam's actual API.
16550 * tparam.c (tparam1, tparam, tgoto):
16551 Use const pointers where appropriate.
16552
fbceeba2
PE
16553 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
16554 * cm.h (struct cm): Likewise.
16555 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
16556 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
16557 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
16558 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
16559 (turn_on_face, init_tty): Likewise.
16560 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 16561
7f3f1250
PE
16562 * term.c (term_mouse_position): Rename local to avoid shadowing.
16563
e6ca6543
PE
16564 * alloc.c (mark_ttys): Move decl from here ...
16565 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
16566
c40f8d15
AS
165672011-03-11 Andreas Schwab <schwab@linux-m68k.org>
16568
16569 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
16570
cfe0661d
JB
165712011-03-09 Juanma Barranquero <lekktu@gmail.com>
16572
16573 * search.c (compile_pattern_1): Remove argument regp, unused since
16574 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
16575 (compile_pattern): Don't pass it.
16576
0afb4571
J
165772011-03-08 Jan Djärv <jan.h.d@swipnet.se>
16578
16579 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
16580 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
16581 for ! HAVE_GTK3.
16582 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
16583
16584 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
16585
16586 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
16587 gdk_window_get_screen, gdk_window_get_geometry,
16588 gdk_x11_window_lookup_for_display and GDK_KEY_g.
16589 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
16590 (xg_get_pixbuf_from_pixmap): New function.
16591 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
16592 to Pixmap, take frame as parameter, remove GdkColormap parameter.
16593 Call xg_get_pixbuf_from_pixmap instead of
16594 gdk_pixbuf_get_from_drawable.
16595 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
16596 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
16597 (xg_check_special_colors): Use GtkStyleContext and its functions
16598 for HAVE_GTK3.
16599 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
16600 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
16601 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
16602 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
16603 Call gtk_widget_get_preferred_size.
0afb4571
J
16604 (xg_frame_resized): gdk_window_get_geometry only takes 5
16605 parameters.
44f230aa
SM
16606 (xg_win_to_widget, xg_event_is_for_menubar):
16607 Call gdk_x11_window_lookup_for_display.
0afb4571
J
16608 (xg_set_widget_bg): New function.
16609 (delete_cb): New function.
895009e1 16610 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 16611 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
16612 (xg_set_background_color): Call xg_set_widget_bg.
16613 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
16614 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
16615 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
16616 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
16617 if ! HAVE_GTK3.
16618 (update_frame_tool_bar): Call gtk_widget_hide.
16619 (xg_initialize): Use GDK_KEY_g.
16620
16621 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
16622 if ! HAVE_GTK3
16623 (x_session_initialize): Call gdk_x11_set_sm_client_id.
16624
16625 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
16626 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
16627 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
16628
1c2cc4ef
JB
166292011-03-08 Juanma Barranquero <lekktu@gmail.com>
16630
16631 * w32xfns.c (select_palette): Check success of RealizePalette against
16632 GDI_ERROR, not zero.
16633
33383987 16634See ChangeLog.11 for earlier changes.
aac0c6e3
MR
16635
16636;; Local Variables:
16637;; coding: utf-8
aac0c6e3
MR
16638;; End:
16639
2f097256 16640 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
16641
16642 This file is part of GNU Emacs.
16643
16644 GNU Emacs is free software: you can redistribute it and/or modify
16645 it under the terms of the GNU General Public License as published by
16646 the Free Software Foundation, either version 3 of the License, or
16647 (at your option) any later version.
16648
16649 GNU Emacs is distributed in the hope that it will be useful,
16650 but WITHOUT ANY WARRANTY; without even the implied warranty of
16651 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16652 GNU General Public License for more details.
16653
16654 You should have received a copy of the GNU General Public License
16655 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.