Clean-up left-overs after 2012-09-23T08:44:20Z!eggert@cs.ucla.edu wrt signal handling.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5101529e
EZ
12012-09-23 Eli Zaretskii <eliz@gnu.org>
2
3 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
4 fatal_error_backtrace.
5
6 * w32proc.c (sys_kill): Undo last change: don't do anything when
7 invoked to deliver SIGABRT to our own process. This is now
8 handled by emacs_raise.
9
2c3ee0ad
JB
102012-09-23 Juanma Barranquero <lekktu@gmail.com>
11
12 * w32term.c (w32_read_socket): Remove leftover reference to
13 interrupt_input_pending.
14
62a1d661
PE
152012-09-23 Paul Eggert <eggert@cs.ucla.edu>
16
17 Do not use SA_NODEFER.
18 Problem reported by Dani Moncayo in
19 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
20 * alloc.c (die):
21 * sysdep.c (emacs_abort): Do not reset signal handler.
22 * emacs.c (terminate_due_to_signal): Reset signal handler here.
23 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
24 wanted even on POSIXish hosts, and it doesn't work on Windows.
25
a0942b9a
JD
262012-09-23 Jan Djärv <jan.h.d@swipnet.se>
27
28 * xterm.c (x_term_init): Call fixup_locale before and after calling
29 gtk_init (Bug#12392).
30
d07ff9db
CY
312012-09-23 Chong Yidong <cyd@gnu.org>
32
33 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
34 Vdynamic_library_alist.
35
36 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
37 (Fgnutls_available_p): Caller changed.
38
39 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
40 (Flibxml_parse_xml_region): Likewise.
41
42 * dispextern.h (struct image_type): Remove arg from init function.
43
44 * image.c (Finit_image_library, lookup_image_type)
45 (define_image_type): Remove now-unneeded second arg.
46 (init_xpm_functions, init_png_functions, init_jpeg_functions)
47 (init_tiff_functions, init_gif_functions, init_svg_functions):
48 Arglist and w32_delayed_load calling convention changed.
49 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 50 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 51
4d7e6e51
PE
522012-09-23 Paul Eggert <eggert@cs.ucla.edu>
53
54 Simplify and avoid signal-handling races (Bug#12471).
55 * alloc.c (die):
56 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
57 Avoid recursive loop if there's a fatal error in the function itself.
58 * atimer.c (pending_atimers):
59 * blockinput.h: Don't include "atimer.h"; no longer needed.
60 (interrupt_input_pending): Remove. All uses removed.
61 pending_signals now counts both atimers and ordinary interrupts.
62 This is less racy than having three separate pending-signal flags.
63 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
64 (input_blocked_p):
65 Rename from their upper-case counterparts BLOCK_INPUT,
66 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
67 INPUT_BLOCKED_P, and turn into functions. All uses changed.
68 This makes it easier to access volatile variables more accurately.
69 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
70 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
71 that's more reliable if the code is buggy and sets
72 interrupt_input_blocked to a negative value. All uses changed.
73 * atimer.c (deliver_alarm_signal):
74 Remove. No need to deliver this to the parent; any thread can
75 handle this signal now. All uses replaced by underlying handler.
76 * atimer.c (turn_on_atimers):
77 * dispnew.c (handle_window_change_signal):
78 * emacs.c (handle_danger_signal):
79 * keyboard.c (kbd_buffer_get_event):
80 Don't reestablish signal handler; not needed with sigaction.
81 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
82 (UNBLOCK_INPUT_TO):
83 Rework to avoid unnecessary accesses to volatile variables.
84 (UNBLOCK_INPUT_TO): Now a function.
85 (totally_unblock_input, unblock_input): New decls.
86 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
87 (init_data): Remove. Necessary stuff now done in init_signal.
88 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
89 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
90 (fatal_error_code): Remove; no longer needed.
91 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
92 it doesn't always backtrace. All uses changed. No need to reset
93 signal to default, since sigaction and/or die does that for us now.
94 Use emacs_raise (FOO), not kill (getpid (), FOO).
95 (main): Check more-accurately whether we're dumping.
96 Move fatal-error setup to sysdep.c
97 * floatfns.c: Do not include "syssignal.h"; no longer needed.
98 * gtkutil.c (xg_get_file_name, xg_get_font):
99 Remove no-longer-needed signal-mask manipulation.
100 * keyboard.c, process.c (POLL_FOR_INPUT):
101 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
102 * keyboard.c (read_avail_input): Remove.
103 All uses replaced by gobble_input.
104 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
105 (kbd_buffer_store_event_hold, gobble_input):
106 (record_asynch_buffer_change) [USABLE_SIGIO]:
107 (store_user_signal_events):
108 No need to mess with signal mask.
109 (gobble_input): If blocking input and there are terminals, simply
110 set pending_signals to 1 and return. All hooks changed to not
111 worry about whether input is blocked.
112 (process_pending_signals): Clear pending_signals before processing
113 them, in case a signal comes in while we're processing.
114 By convention callers now test pending_signals before calling us.
115 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
116 New functions, to support changes to blockinput.h.
117 (handle_input_available_signal): Now extern.
118 (reinvoke_input_signal): Remove. All uses replaced by
119 handle_async_input.
120 (quit_count): Now volatile, since a signal handler uses it.
121 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg. All
122 callers changed. Block SIGINT only if not already blocked.
123 Clear sigmask reliably, even if Fsignal returns, which it can.
124 Omit unnecessary accesses to volatile var.
125 (quit_throw_to_read_char): No need to restore sigmask.
126 * keyboard.c (gobble_input, handle_user_signal):
127 * process.c (wait_reading_process_output):
128 Call signal-handling code rather than killing ourselves.
129 * lisp.h: Include <float.h>, for...
130 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
131 (pending_signals): Now volatile.
132 (syms_of_data): Now const if IEEE floating point.
133 (handle_input_available_signal) [USABLE_SIGIO]:
134 (terminate_due_to_signal, record_child_status_change): New decls.
135 * process.c (create_process): Avoid disaster if memory is exhausted
136 while we're processing a vfork, by tightening the critical section
137 around the vfork.
138 (send_process_frame, process_sent_to, handle_pipe_signal)
139 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
140 ignores SIGPIPE.
141 (send_process): No need for setjmp/longjmp any more, since the
142 SIGPIPE stuff is now gone. Instead, report an error if errno
143 is EPIPE.
144 (record_child_status_change): Now extern. PID and W are now args.
145 Return void, not bool. All callers changed.
146 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
147 Remove. All uses removed. This bug should be fixed now in a
148 different way.
149 (wait_for_termination_1): Use waitpid rather than sigsuspend,
150 and record the child status change directly. This avoids the
151 need to futz with the signal mask.
152 (process_fatal_action): Move here from emacs.c.
153 (emacs_sigaction_flags): New function, containing
154 much of what used to be in emacs_sigaction_init.
155 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
156 caught by emacs, to make races less likely.
157 (deliver_process_signal): Rename from handle_on_main_thread.
158 All uses changed.
159 (BACKTRACE_LIMIT_MAX): Now at top level.
160 (thread_backtrace_buffer, threadback_backtrace_pointers):
161 New static vars.
162 (deliver_thread_signal, deliver_fatal_thread_signal):
163 New functions, for more-accurate delivery of thread-specific signals.
164 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
165 (deliver_arith_signal): Handle in this thread, not
166 in the main thread, since it's triggered by this thread.
167 (maybe_fatal_sig): New function.
168 (init_signals): New arg DUMPING so that we can be more accurate
169 about whether we're dumping. Caller changed.
170 Treat thread-specific signals differently from process-general signals.
171 Block all signals while handling fatal error; that's safer.
172 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
173 on IEEE hosts.
174 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
175 Ignore SIGPIPE unless batch.
176 (emacs_backtrace): Output backtrace for the appropriate thread,
177 which is not necessarily the main thread.
178 * syssignal.h: Include <stdbool.h>.
179 (emacs_raise): New macro.
180 * xterm.c (x_connection_signal): Remove; no longer needed
181 now that we use sigaction.
182 (x_connection_closed): No need to mess with sigmask now.
183 (x_initialize): No need to reset SIGPIPE handler here, since
184 init_signals does this for us now.
185
8f4635e9
JD
1862012-09-23 Jan Djärv <jan.h.d@swipnet.se>
187
188 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
189 background rect may be larger (Bug#12445).
190
3296976d
CY
1912012-09-23 Chong Yidong <cyd@gnu.org>
192
193 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
194
d41e491e
PE
1952012-09-22 Paul Eggert <eggert@cs.ucla.edu>
196
197 * .gdbinit: Just stop at fatal_error_backtrace.
198 See Stefan Monnier's request in
199 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
200 Remove no-longer-used query of system type.
201
c88b867f
CY
2022012-09-22 Chong Yidong <cyd@gnu.org>
203
204 * search.c (Freplace_match): Doc fix (Bug#12325).
205
206 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
207
208 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
209 (Fline_end_position): Doc fix.
210
211 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
212
bb4d86b4
CY
2132012-09-22 Chong Yidong <cyd@gnu.org>
214
215 * dispextern.h (struct image_type): Add new slot, storing a type
216 initialization function.
217
218 * image.c (define_image_type): Call the image initializer function
219 if it is defined. Arguments and return value changed.
220 (valid_image_p, make_image): Callers changed.
221 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
222 (gif_type, imagemagick_type, svg_type, gs_type): Add
223 initialization functions.
224 (Finit_image_library): Call lookup_image_type.
225 (CHECK_LIB_AVAILABLE): Macro deleted.
226 (lookup_image_type): Call define_image_type here, rather than via
227 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
228 (syms_of_image): Move define_image_type calls for xbm_type and
229 pbm_type to lookup_image_type.
230
df9685f3
EZ
2312012-09-22 Eli Zaretskii <eliz@gnu.org>
232
233 * keyboard.c (timer_check_2): Move calculation of 'timers' and
234 'idle_timers' from here ...
235 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
236 lists, to avoid infloops when the timer does something stupid,
237 like reinvoke itself with the same or smaller time-out.
238 (Bug#12447)
239
8e17c9ba
MR
2402012-09-22 Martin Rudalics <rudalics@gmx.at>
241
242 * window.c (Fsplit_window_internal): Handle only Qt value of
243 Vwindow_combination_limit separately.
244 (Qtemp_buffer_resize): New symbol.
245 (Vwindow_combination_limit): New default value. Rewrite
246 doc-string.
247
589bd69b
EZ
2482012-09-22 Eli Zaretskii <eliz@gnu.org>
249
250 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
251 the new overlay string. (Bug#10159)
252
01108e3f
PE
2532012-09-22 Paul Eggert <eggert@cs.ucla.edu>
254
255 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
256 or that fprintf is async-signal-safe. POSIX doesn't require
257 either assumption.
258
82f8cd94
CY
2592012-09-22 Chong Yidong <cyd@gnu.org>
260
261 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
262 (Bug#8207).
263
3cccbd87
KH
2642012-09-22 Kenichi Handa <handa@gnu.org>
265
266 * composite.c (composition_reseat_it): Handle the case that a
267 grapheme cluster is not covered by a single font (Bug#12352).
268
09c01941
CY
2692012-09-21 Chong Yidong <cyd@gnu.org>
270
271 * image.c (define_image_type): Avoid adding duplicate types to
272 image_types (Bug#12463). Suggested by Jörg Walter.
273
acfa068f 2742012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
275
276 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
277 (print_load_command_name): Add case LC_DATA_IN_CODE.
278 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
279
acfa068f 2802012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
281
282 * eval.c (Frun_hook_with_args_until_success)
283 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
284
acfa068f 2852012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
286
287 * fileio.c (Ffile_selinux_context): Only call freecon when
288 lgetfilecon succeeded.
289 (Fset_file_selinux_context): Likewise. (Bug#12444)
290
acfa068f 2912012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
292
293 * xdisp.c (try_window_reusing_current_matrix): Under bidi
294 reordering, locate the cursor by calling set_cursor_from_row; if
295 that fails, clear the desired glyph matrix before returning a
296 failure indication to the caller. Fixes leaving garbled display
297 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
298 (compute_stop_pos_backwards): Fix a typo that caused crashes while
299 scrolling through multibyte text.
aa36e4d2 300
e99f70c8
SM
3012012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
302
303 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
304 calling mark_vectorlike since that's the one that marks the window.
305 (mark_discard_killed_buffers): Mark the final cdr.
306 * window.h (struct window): Move prev/next_buffers to the
307 non-standard fields.
308 * window.c (make_window): Initialize prev/next_buffers manually.
309
f75beb47
PE
3102012-09-20 Paul Eggert <eggert@cs.ucla.edu>
311
312 Omit unused arg EXPECTED from socket hooks.
313 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
314 * nsterm.m (ns_term_init):
315 * termhooks.h (struct terminal.read_socket_hook):
316 * w32inevt.c (w32_console_read_socket):
317 * w32term.c (w32_read_socket):
318 * xterm.c (XTread_socket):
319 Omit unused arg EXPECTED. All callers changed.
320 (store_user_signal_events): Return void, not int, since callers no
321 longer care about the return value. All uses changed.
322
b019b76a
JB
3232012-09-20 Juanma Barranquero <lekktu@gmail.com>
324
325 * w32gui.h (XParseGeometry): Do not declare.
326
05642592
PE
3272012-09-19 Paul Eggert <eggert@cs.ucla.edu>
328
e4bce92a
PE
329 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
330 Ignore 'expected'. See Eli Zaretskii in
331 <http://bugs.gnu.org/12471#8> (last line).
332
05642592
PE
333 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
334 (XParseGeometry): Now static. Substitute extremal values for
335 values that are out of range.
336
e543ae91
JD
3372012-09-19 Jan Djärv <jan.h.d@swipnet.se>
338
339 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
340
341 * nsfns.m (XParseGeometry): Remove.
342 (Fx_create_frame): Call x_set_offset to correctly interpret
343 top_pos in geometry.
344
345 * frame.c (read_integer, XParseGeometry): Moved from w32xfns.c.
346 (Fx_parse_geometry): If there is a space in string, call
347 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
348
45ba16c7
EZ
3492012-09-17 Eli Zaretskii <eliz@gnu.org>
350
c8b9f1bc
EZ
351 * search.c (scan_buffer): Use character positions in calls to
352 region_cache_forward and region_cache_backward, not byte
353 positions. (Bug#12196)
354
b4c932a2
EZ
355 * w32term.c (w32_read_socket): Set pending_signals to 1, like
356 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
357
45ba16c7
EZ
358 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
359 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
360 emacs_blocked_malloc, now deleted.
361
eeceac93
PE
3622012-09-17 Paul Eggert <eggert@cs.ucla.edu>
363
364 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
365 The workaround was for improving performance on Solaris 2.4, but
366 is getting in the way now. Emacs will still work if someone is
367 still running Solaris 2.4 in a museum somewhere; Sun dropped
368 support for Solaris 2.4 in 2003.
369 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
370 * process.c (create_process) [HAVE_WORKING_VFORK]:
371 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
372 since Emacs no longer uses vfork on that platform.
373
78f83752
GM
3742012-09-17 Glenn Morris <rgm@gnu.org>
375
376 * emacs.c: Use COPYRIGHT.
377
634b8cac
PE
3782012-09-16 Paul Eggert <eggert@cs.ucla.edu>
379
0caaedb1
PE
380 Remove configure's --without-sync-input option (Bug#12450).
381 When auditing signal-handling in preparation for cleaning it up,
382 I found that SYNC_INPUT has race conditions and would be a real
383 pain to fix. Since it's an undocumented and deprecated
384 configure-time option, now seems like a good time to remove it.
385 Also see <http://bugs.gnu.org/11080#16>.
386 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
387 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
388 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
389 (malloc_hysteresis):
390 (check_depth) [XMALLOC_OVERRUN_CHECK]:
391 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
392 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
393 (dont_register_blocks, bytes_used_when_reconsidered)
394 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
395 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
396 [!SYSTEM_MALLOC && !SYNC_INPUT]:
397 Remove. All uses removed.
398 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
399 implementation, one that depends on whether the new macro
400 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
401 is defined.
402 * atimer.c (run_timers, handle_alarm_signal):
403 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
404 (handle_async_input, process_pending_signals)
405 (handle_input_available_signal, init_keyboard):
406 * nsterm.m (ns_read_socket):
407 * process.c (wait_reading_process_output):
408 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
409 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
410 (emacs_write):
411 * xterm.c (XTread_socket):
412 Assume SYNC_INPUT.
413 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
414 * eval.c (handling_signal): Remove. All uses removed.
415 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
416 All uses replaced with the SYNC_INPUT version.
417 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
418 Remove decls.
419 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
420 Now static.
421
634b8cac
PE
422 * font.c (Ffont_shape_gstring): Remove unused local.
423
83da1b55
GM
4242012-09-16 Glenn Morris <rgm@gnu.org>
425
518650a5
GM
426 * Makefile.in (clean): No longer run nextstep's clean.
427
83da1b55
GM
428 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
429 (ns_frag): Remove.
430 (ns-app): Move here from ns.mk, and simplify.
431 (clean): Simplify nextstep entry.
432 * ns.mk: Remove file.
433
85a43e2e
KH
4342012-09-17 Kenichi Handa <handa@gnu.org>
435
436 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
437 not covert the last few charactes.
438
ba13e616 4392012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
440
441 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
442 here, but just check the validity of glyphs in the glyph-string.
443
a8c729af
MR
4442012-09-16 Martin Rudalics <rudalics@gmx.at>
445
446 * window.c (Fwindow_parameter, Fset_window_parameter): Accept
447 any window as argument (Bug#12452).
448
c077c059
JD
4492012-09-16 Jan Djärv <jan.h.d@swipnet.se>
450
451 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
452 to ns_term_init to avoid memory leak.
453
454 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
455 explicit retain/release.
456 (ns_term_init): Only allow one display. Initialize outerpool and
457 ns_*_types.
458
39a57ad0
PE
4592012-09-15 Paul Eggert <eggert@cs.ucla.edu>
460
461 Port _setjmp fix to POSIXish hosts as well as Microsoft.
462 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
463 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
464 the Microsoft problem in a different way, by altering ../nt/config.nt.
465
7105c8cb
EZ
4662012-09-15 Eli Zaretskii <eliz@gnu.org>
467
468 * w32xfns.c:
469 * w32uniscribe.c:
470 * w32term.c:
471 * w32select.c:
472 * w32reg.c:
473 * w32proc.c:
474 * w32menu.c:
475 * w32inevt.c:
476 * w32heap.c:
477 * w32font.c:
478 * w32fns.c:
479 * w32console.c:
480 * w32.c:
481 * w16select.c: Remove inclusion of setjmp.h, as it is now included
482 by lisp.h. This completes removal of setjmp.h inclusion
483 erroneously announced in the previous commit. (Bug#12446)
484
485 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
486 more accurate.
487
488 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
489 not defined as a macro. The latter happens on MS-Windows.
490 (Bug#12446)
491
0328b6de
PE
4922012-09-15 Paul Eggert <eggert@cs.ucla.edu>
493
494 Port better to POSIX hosts lacking _setjmp (Bug#12446).
495 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 496 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
497 only reason for the instance was because "lisp.h" was included.
498 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
499 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
500 and _longjmp with the new symbols. Emacs already uses _setjmp if
501 available, so this change affects only POSIXish hosts that have
502 sigsetjmp but not _setjmp, such as some versions of Solaris and
503 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
504 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
505 (png_load_body) [HAVE_PNG]:
506 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
507 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
508 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
509 since PNG requires jmp_buf. This is the only exception to the
510 general rule that we now use sys_setjmp and sys_longjmp.
511 This exception is OK since this code does not change the signal
512 mask or longjmp out of a signal handler.
513
2af03429
PE
5142012-09-14 Paul Eggert <eggert@cs.ucla.edu>
515
516 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
517 Include "syssignal.h", for 'main_thread'.
518
2f294edf
DA
5192012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
520
521 Avoid out-of-range marker position (Bug#12426).
522 * insdel.c (replace_range, replace_range_2): Adjust
523 markers before overlays, as suggested by comments.
524 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
525 Remove redundant check before calling offset_intervals.
526
6b533e9c
MR
5272012-09-14 Martin Rudalics <rudalics@gmx.at>
528
529 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
530 current buffer (Bug#12387).
531
2a7931e3
JB
5322012-09-14 Juanma Barranquero <lekktu@gmail.com>
533
534 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
535
c18e885b
PE
5362012-09-13 Paul Eggert <eggert@cs.ucla.edu>
537
538 Use a more backwards-compatible timer format (Bug#12430).
539 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
540 vector element, not from the 4th, since PSECS is now at the end.
541 (Fcurrent_idle_time): Doc fix.
542
d59a1afb
DA
5432012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
544
545 Function to mark objects and remove killed buffers at once.
546 * alloc.c (discard_killed_buffers): Rename to ...
547 (mark_discard_killed buffers) ... new name. Add marking
548 of remaining objects. Fix comment. Adjust users.
549 (mark_object): Do not touch frame buffer lists here.
550 * frame.c (delete_frame): Reset frame buffer lists here.
551
5f0cb45a
PE
5522012-09-13 Paul Eggert <eggert@cs.ucla.edu>
553
8ea47e3a
PE
554 Better workaround for GNOME bug when --enable-gcc-warnings.
555 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
556 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
557 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
558
4a4bbad2
PE
559 Simplify SIGIO usage (Bug#12408).
560 The code that dealt with SIGIO was crufty and confusing, e.g., it
561 played tricks like "#undef SIGIO" but these tricks were not used
562 consistently. Simplify mostly by not #undeffing standard symbols,
563 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
564 or not as we please) rather than "defined SIGIO" (standard symbol
565 that we probably shouldn't #undef).
566 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
567 Modules that need it can include it.
568 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
569 * dispextern.h (ignore_sigio): New decl.
570 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
571 unconditionally, since it's now a no-op if !USABLE_SIGIO.
572 * emacs.c (shut_down_emacs):
573 * keyboard.c (kbd_buffer_store_event_hold):
574 Use ignore_sigio rather than invoking 'signal' directly.
575 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
576 for FIONREAD.
577 (FIONREAD, SIGIO): Do not #undef.
578 (tty_read_avail_input): Use #error rather than a syntax error.
579 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
580 for I_PIPE, used by SETUP_SLAVE_PTY.
581 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
582 * sysdep.c (croak): Remove; no longer needed. This bit of
583 temporary code, with Fred N. Fish's comment that it's temporary,
584 has been in Emacs since at least 1992!
585 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
586 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
587 * syssignal.h (croak): Remove decl.
588 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
589 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
590 now that we're termios-only.
591 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
592 * term.c (dissociate_if_controlling_tty): Use #error rather than
593 a run-time error.
594
5f0cb45a
PE
595 Work around GCC and GNOME bugs when --enable-gcc-warnings.
596 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
597 to work around GNOME bug 683906.
598 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
599 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
600 This works around GCC bug 54561.
601
40bce90b
PE
6022012-09-12 Paul Eggert <eggert@cs.ucla.edu>
603
604 More fixes for 'volatile' and setjmp/longjmp.
605 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
606 * image.c (struct png_load_context) [HAVE_PNG]: New type.
607 (png_load_body) [HAVE_PNG]:
608 (jpeg_load_body) [HAVE_JPEG]:
609 New function, with most of the old parent function's body.
610 (png_load) [HAVE_PNG]:
611 (jpeg_load) [HAVE_JPEG]:
612 Invoke the new function, to avoid longjmp munging our locals.
613 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
614 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
615 longjmp is passed 2, as the C standard doesn't guarantee this.
616 Instead, store the failure code into mgr->failure_code.
617
bfeae2cf
SM
6182012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
619
620 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
621 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
622 (syms_of_keyboard): Remove support for unread-command-char.
623
8099e36b
EZ
6242012-09-12 Eli Zaretskii <eliz@gnu.org>
625
626 * w32proc.c (sys_kill): If PID is our process ID and the signal is
627 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
628 violation. (Bug#12426)
629
92547ff9
PE
6302012-09-12 Paul Eggert <eggert@cs.ucla.edu>
631
632 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
633
45b82ad0
SM
6342012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
635
636 * eval.c: Add `inhibit-debugger'.
637 (Qinhibit_debugger): New symbol.
638 (call_debugger): Bind it instead of Qdebug_on_error.
639 (maybe_call_debugger): Test Vinhibit_debugger.
640 (syms_of_eval): Define inhibit-debugger.
641 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
642 (syms_of_xdisp): Remove inhibit-debug-on-message.
643
5779a1dc
PE
6442012-09-11 Paul Eggert <eggert@cs.ucla.edu>
645
50f2e553
PE
646 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
647 If a nonvolatile local variable is written before a _longjmp to
648 the frame containing the variable, and is read after the _longjmp,
649 the value read is indeterminate. Some local variables of type
650 'struct handler' and 'struct catchtag' are used in this way, so
651 mark each of their slots as volatile if the slot can be set before
652 _longjmp and read afterwards.
653 * lisp.h (struct handler): var and chosen_clause are now volatile.
654 (struct catchtag): val, next, and pdlcount are now volatile.
655
ae1d87e2
PE
656 * bidi.c (bidi_push_it, bidi_pop_it):
657 * fns.c (copy_hash_table):
658 * image.c (define_image_type):
659 * keyboard.c (kbd_buffer_store_event_hold):
660 * process.c (Fprocess_send_eof):
661 * xfaces.c (x_create_gc) [HAVE_NS]:
662 * xgselect.c (xg_select):
663 Prefer assignment to memcpy when either will do.
664
5779a1dc
PE
665 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
666 Use pointer-to-a-pointer to simplify and avoid a NILP check each
667 time an item is removed. No need to mark this function 'inline';
668 the compiler knows better than we do.
669
c4c9756b
JD
6702012-09-11 Jan Djärv <jan.h.d@swipnet.se>
671
672 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
673 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
674 to change_frame_size (Bug#12388).
675 (windowDidResize:): Pass YES to updateFrameSize.
676
677 * nsterm.h: Add delay parameter to updateFrameSize.
678
d73e321c
DA
6792012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
680
681 Discard killed buffers from deleted window and frame objects.
682 This reduces an amount of references to killed buffers and
683 helps GC to reclaim them faster.
684 * alloc.c (discard_killed_buffers): New function.
685 (mark_object): Use it for deleted windows and frames.
686 (mark_object): If symbol's value is set up for a killed buffer
687 or deleted frame, restore it's global binding.
688 * data.c (swap_in_global_binding): Add GC notice.
689 (swap_in_symval_forwarding): Use convenient set_blv_where.
690 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
691 * window.h: ... to here.
692
e578f381
DA
6932012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
694
695 Convenient macro to check whether the buffer is live.
696 * buffer.h (BUFFER_LIVE_P): New macro.
697 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
698 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
699
3057e615
YM
7002012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
701
702 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
703 composition cases (Bug#12364).
704
705 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
706 overhang of succeeding glyphs overlapping box cursor.
707
708 * w32term.c (x_draw_glyph_string): Likewise.
709
6fda35f2
PE
7102012-09-11 Paul Eggert <eggert@cs.ucla.edu>
711
c990426a
PE
712 Simplify, document, and port floating-point (Bug#12381).
713 The porting part of this patch fixes bugs on non-IEEE platforms
714 with frexp, ldexp, logb.
715 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
716 Now static.
717 * floatfns.c: Simplify discussion of functions that Emacs doesn't
718 support, by removing commented-out code and briefly listing the
719 C89 functions excluded. The commented-out stuff was confusing
720 maintenance, e.g., we thought we needed cbrt but it was commented out.
721 (logb): Remove decl; no longer needed.
722 (isfinite): New macro, if not already supplied.
723 (isnan): Don't replace any existing macro.
724 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
725 are present on all C89 platforms.
726 (Ffrexp): Do not special-case zero, as frexp does the right thing
727 for that case.
728 (Flogb): Do not use logb, as it doesn't have the desired meaning
729 on hosts that use non-base-2 floating point. Instead, stick with
730 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
731 frexp, to avoid getting an unspecified result.
732
6fda35f2
PE
733 * xdisp.c (Qinhibit_debug_on_message): Now static.
734
16130a58
JD
7352012-09-10 Jan Djärv <jan.h.d@swipnet.se>
736
737 * nsterm.m (ns_update_begin): Set clip path to whole view by using
738 NSBezierPath (Bug#12131).
739
d105a573
CY
7402012-09-10 Chong Yidong <cyd@gnu.org>
741
742 * fns.c (Fdelq, Fdelete): Doc fix.
743
ff55dfe8
PE
7442012-09-10 Paul Eggert <eggert@cs.ucla.edu>
745
746 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
747 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
748
e7032e7c
SM
7492012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
750
751 * lisp.h (make_lisp_ptr): New macro to replace XSET.
752 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
753 Use it.
754
e9957956
EZ
7552012-09-09 Eli Zaretskii <eliz@gnu.org>
756
aba05ce9
EZ
757 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
758 left fringe if the window has a left margin. This avoids leaving
759 traces of the cursor because its leftmost pixel is not drawn over.
760
e9957956
EZ
761 * dispnew.c (update_window_line): When the left margin area of a
762 screen line is updated, set the redraw_fringe_bitmaps_p flag of
763 that screen line. (Bug#12277)
764
f6196b87
PE
7652012-09-09 Paul Eggert <eggert@cs.ucla.edu>
766
767 Assume C89 or later for math functions (Bug#12381).
768 This simplifies the code, and makes it a bit smaller and faster,
769 and (most important) makes it easier to clean up signal handling
770 since we can stop worring about floating-point exceptions in
771 library code. That was a problem before C89, but the problem
772 went away many years ago on all practical Emacs targets.
773 * data.c, image.c, lread.c, print.c:
774 Don't include <math.h>; no longer needed.
775 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
776 might be autoconfigured, as that never happens.
777 * data.c (fmod):
778 * doprnt.c (DBL_MAX_10_EXP):
779 * print.c (DBL_DIG):
780 Remove. C89 or later always defines these.
781 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
782 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
783 (arith_error, domain_error, domain_error2):
784 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
785 no longer needed -- we simply return what C returns. All uses removed.
786 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
787 the wrapped code.
788 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
789 Remove. All uses expanded, as these macros are no longer used
790 more than once and are now more trouble than they're worth.
791 (Ftan): Use tan, not sin / cos.
792 (Flogb): Assume C89 frexp.
793 (fmod_float): Assume C89 fmod.
794 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
795 (init_floatfns): Remove. All uses removed.
796
9d7f1863
JD
7972012-09-08 Jan Djärv <jan.h.d@swipnet.se>
798
799 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
800 compositeToPoint for OSX < 10.6 (Bug#12390).
801
eabf0404
PE
8022012-09-08 Paul Eggert <eggert@cs.ucla.edu>
803
804 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
805 This produces more-accurate results.
806
0b3b1d23
JD
8072012-09-08 Jan Djärv <jan.h.d@swipnet.se>
808
809 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
810 changes (Bug#12088).
811
6dcef6ec
CY
8122012-09-08 Chong Yidong <cyd@gnu.org>
813
814 * syntax.c (Fstring_to_syntax): Doc fix.
815
aa7d57c5
JD
8162012-09-08 Jan Djärv <jan.h.d@swipnet.se>
817
818 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
819 in the internal border.
820 (x_set_window_size): Remove static variables and their usage.
821 (ns_redraw_scroll_bars): Fix NSTRACE arg.
822 (ns_after_update_window_line, ns_draw_fringe_bitmap): Remove
823 fringe/internal border adjustment (Bug#11052).
824 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
825 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
826 (ns_fix_rect_ibw): Remove.
827 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
828 (ns_dumpglyphs_box_or_relief): Ditto.
829 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
830 adjustment.
831 (ns_dumpglyphs_image): Ditto.
fc0c31f8 832 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
833 border adjustment.
834 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
835 their usage. Add fringe_extended_p and its use as in other terms.
836 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
837 scroll bar was removed.
838 (updateFrameSize): New function.
839 (windowDidResize): Move code to updateFrameSize and call it.
840
841 * nsterm.h (EmacsView): Add updateFrameSize.
842
1a5432bc
CY
8432012-09-07 Chong Yidong <cyd@gnu.org>
844
b4f5313e
CY
845 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
846
1a5432bc
CY
847 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
848
1a4f1e9b
PE
8492012-09-07 Paul Eggert <eggert@cs.ucla.edu>
850
851 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
852 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
853 Problem introduced when merging patches. Noted by Eli Zaretskii in
854 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
855 * floatfns.c: Comment fix.
856 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
857 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
858 and anyway the declaration is harmless even if SIGDANGER is not defined.
859 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
860 defined BROKEN_FIONREAD). systty.h formerly did this, but other
861 source files not surprisingly expected syssignal.h to define, or
862 not define, SIGIO, and it's cleaner to do it that way, for consistency.
863 Include <sys/ioctl.h>, for FIONREAD.
864 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
865 This eliminates a problem whereby other files mysteriously had
866 to include "syssignal.h" before including "systty.h" if they
867 wanted to use "#ifdef SIGIO".
868
bc8000ff
EZ
8692012-09-07 Eli Zaretskii <eliz@gnu.org>
870
3e6d6928
EZ
871 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
872
873 * w32.c (sigemptyset): Empty the set.
874 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
875
bc8000ff
EZ
876 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
877
b4fa72f2
DA
8782012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
879
880 * alloc.c (mark_buffer): Revert unsafe marking optimization.
881 (mark_object): Likewise for frame objects.
882
30730c93
PE
8832012-09-07 Paul Eggert <eggert@cs.ucla.edu>
884
885 * syssignal.h (handle_on_main_thread): Always declare,
886 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
887 This ports to platforms without HAVE_PTHREAD.
888
2fe28299
PE
8892012-09-06 Paul Eggert <eggert@cs.ucla.edu>
890
891 Signal-handler cleanup (Bug#12327).
892 Emacs's signal handlers were written in the old 4.2BSD style with
893 sigblock and sigmask and so forth, and this led to some
894 inefficiencies and confusion. Rewrite these to use
895 pthread_sigmask etc. without copying signal sets around. Also,
896 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
897 'signal', and instead use functions that do not attempt to take
898 over the system name space. This patch causes Emacs's text
899 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
900 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
901 Do not include <signal.h> or "syssignal.h", as these
902 modules do not use signals.
903 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
904 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
905 Do not include <signal.h>, as "syssignal.h" does that for us now.
906 * atimer.c (sigmask_atimers): New function.
907 (block_atimers, unblock_atimers): New functions,
908 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
909 All uses replaced.
910 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
911 no longer needed here.
912 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 913 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
914 * sysdep.c (struct save_signal): New member 'action', replacing
915 old member 'handler'.
916 (save_signal_handlers, restore_signal_handlers):
917 Use sigaction instead of 'signal' to save and restore.
918 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
919 New function. All users of 'signal' modified to use set_sighandler
920 if they're writeonly, and to use sys_signal if they're read+write.
921 (emacs_sigaction_init, forwarded_signal): New functions.
922 (sys_signal): Remove. All uses replaced by calls to sigaction
923 and emacs_sigaction_init, or by direct calls to 'signal'.
924 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
925 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
926 all uses replaced by pthread_sigmask etc. calls.
927 * syssignal.h: Include <signal.h>.
928 (emacs_sigaction_init, forwarded_signal): New decls.
929 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
930 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
931 (sigmask, sys_sigmask): Remove; no longer needed.
932 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
933 (sigblock, sigunblock, sigfree):
934 (sigsetmask) [!defined sigsetmask]:
935 Remove. All uses replaced by pthread_sigmask.
936 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
937 no longer need to be replaced, and its typical old uses
938 are now done via emacs_sigaction_init and sigaction.
939 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
940 (sys_sigdel): Remove; unused.
941 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
942
0216c128
EZ
9432012-09-06 Eli Zaretskii <eliz@gnu.org>
944
945 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
946 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
947
c752cfa9
DA
9482012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
949
950 Explicitly mark buffer_defaults and buffer_local_symbols.
951 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
952 mark_local_symbols here.
953 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
954 since special buffers aren't marked here any more.
955 (allocate_buffer): Chain new buffer with all_buffers here...
956 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
957 not here.
958 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
959 (syms_of_buffer): Remove staticpro of the above.
960 (init_buffer_once): Set names for buffer_defaults and
961 buffer_local_symbols.
962
a864ef14
PE
9632012-09-06 Paul Eggert <eggert@cs.ucla.edu>
964
965 Use bool for booleans in font-related modules.
966 * font.c (font_intern_prop, font_style_to_value)
967 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
968 (generate_otf_features, font_check_otf_features, font_check_otf)
969 (font_match_p, font_list_entities, font_at):
970 * fontset.c (fontset_id_valid_p, reorder_font_vector
971 (fontset_find_font, Fset_fontset_font)
972 (face_suitable_for_char_p) [0]:
973 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
974 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
975 (m17n_flt_initialized, ftfont_shape_by_flt):
976 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
977 * nsfont.m (nsfont_draw):
978 * w32font.c (w32font_draw):
979 * w32term.c (x_draw_glyphless_glyph_string_foreground):
980 Use bool for booleans.
981 * font.h: Adjust to above API changes.
982 (struct font, struct font_driver, struct font_driver_list):
983 Use bool for booleans.
984 (struct font): Remove useless member encoding_type.
985 All users removed.
986 * fontset.c, xftfont.c: Omit unnecessary static decls.
987
0699fc18
DA
9882012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
989
990 * alloc.c (mark_object): Revert window marking code
991 since it's unsafe for the Fset_window_configuration.
992
20ef56db
PE
9932012-09-05 Paul Eggert <eggert@cs.ucla.edu>
994
2fe28299 995 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
996 Be more systematic about preserving errno whenever a signal
997 handler returns, even if it's not in the main thread. Do this by
998 renaming signal handlers to distinguish between signal delivery
999 and signal handling. All uses changed.
1000 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
1001 * data.c (deliver_arith_signal): Rename from arith_error.
1002 * dispnew.c (deliver_window_change_signal): Rename from
1003 window_change_signal.
1004 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
1005 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
1006 * keyboard.c (deliver_input_available_signal): Rename from
1007 input_available_signal.
1008 (deliver_user_signal): Rename from handle_user_signal.
1009 (deliver_interrupt_signal): Rename from interrupt_signal.
1010 * process.c (deliver_pipe_signal): Rename from send_process_trap.
1011 (deliver_child_signal): Rename from sigchld_handler.
1012 * atimer.c (handle_alarm_signal):
1013 * data.c (handle_arith_signal):
1014 * dispnew.c (handle_window_change_signal):
1015 * emacs.c (handle_fatal_signal, handle_danger_signal):
1016 * keyboard.c (handle_input_available_signal):
1017 * keyboard.c (handle_user_signal, handle_interrupt_signal):
1018 * process.c (handle_pipe_signal, handle_child_signal):
1019 New functions, with the actual signal-handling code taken from the
1020 original respective signal handlers, sans the sporadic attempts to
1021 preserve errno, since that's now done by handle_on_main_thread.
1022 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
1023 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
1024 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1025 Move to sysdep.c.
1026 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1027 Move initialization of main_thread to sysdep.c's init_signals.
1028 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
1029 our usage, and simplifies the mainline code.
1030 (record_child_status_change): New static function, as a helper
1031 for handle_child_signal, and with most of the old child handler's
1032 contents.
1033 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
1034 (handle_child_signal): Use the above.
1035 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1036 Moved here from emacs.c.
1037 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
1038 code moved here from emacs.c's main function.
1039 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
1040 replacing the old SIGNAL_THREAD_CHECK. All uses changed. This
1041 lets callers save and restore errno properly.
1042
e3ccf108
DA
10432012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1044
1045 Remove redundant or unused things here and there.
1046 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
1047 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
1048 * editfns.c (Fcompare_buffer_substrings): Likewise.
1049 * frame.h (struct terminal, struct font_driver_list):
1050 Remove redundant declarations.
1051 * window.h (Qleft, Qright): Likewise.
1052
697e1e39
DA
10532012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1054
1055 Do not mark objects from deleted buffers, windows and frames.
1056 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
1057 (mark_object): Likewise for windows and frames.
1058
c1ca42ca
DA
10592012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1060
1061 * alloc.c (valid_lisp_object_p): Treat killed buffers,
1062 buffer_defaults and buffer_local_symbols as valid objects.
1063 Return special value to denote them.
1064
014d93be
PE
10652012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1066
f75d7a91
PE
1067 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
1068 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
1069 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
1070 (file_name_absolute_p, Fsubstitute_in_file_name):
1071 (check_executable, check_writable, Ffile_accessible_directory_p)
1072 (Fset_file_selinux_context, Fdefault_file_modes)
1073 (Finsert_file_contents, choose_write_coding_system)
1074 (Fwrite_region, build_annotations, a_write, e_write)
1075 (Fdo_auto_save):
1076 * filelock.c (boot_time_initialized, get_boot_time)
1077 (get_boot_time_1, lock_file_1, within_one_second):
1078 * floatfns.c (in_float):
1079 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
1080 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
1081 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
1082 * lisp.h (struct Lisp_Hash_Table.cmpfn):
1083 * window.c (compare_window_configurations):
1084 Use bool for booleans.
1085 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
1086 (Fdefault_file_modes): Now mode_t, not int, for modes.
1087 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
1088 (internal_delete_file): Now returns void, not a (boolean) int,
1089 since nobody was looking at the return value.
1090 * lisp.h, window.h: Adjust to above API changes.
1091
014d93be
PE
1092 * xdisp.c (set_message): Simplify and reindent last change.
1093
776f29e1
JB
10942012-09-05 Juanma Barranquero <lekktu@gmail.com>
1095
1096 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
1097
7f7e0167
LI
10982012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
1099
1100 * eval.c (call_debugger): Make the function non-static so that we
1101 can call it from set_message.
1102
1103 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
1104 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
1105
cf29dd84
PE
11062012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1107
1108 Give more-useful info on a fatal error (Bug#12328).
1109 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
1110 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
1111 of doing the work ourselves.
1112 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
1113 do most of the work.
1114 (fatal_error_backtrace): New function, taken from the guts
1115 of the old fatal_error_signal, but with a new option to output
1116 a backtrace.
1117 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
1118 info about the signal than just its number.
1119 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
1120 * sysdep.c: Include <execinfo.h>
1121 (emacs_backtrace): New function, taken partly from the previous
1122 code of the 'die' function.
1123 (emacs_abort): Call fatal_error_backtrace rather than abort.
1124
972debf2
SM
11252012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1126
1127 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
1128 eager (load-time) macro-expansion.
1129 * lisp.mk (lisp): Add macroexp.
1130
1088b922
PE
11312012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1132
1133 Simplify redefinition of 'abort' (Bug#12316).
1134 Do not try to redefine the 'abort' function. Instead, redo
1135 the code so that it calls 'emacs_abort' rather than 'abort'.
1136 This removes the need for the NO_ABORT configure-time macro
1137 and makes it easier to change the abort code to do a backtrace.
1138 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
1139 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
1140 Remove; sysdep.c's emacs_abort now takes its place.
1141 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
1142 'abort' changed to use 'emacs_abort'.
1143 * msdos.c (dos_abort) [defined abort]: Remove; not used.
1144 (abort) [!defined abort]: Rename to ...
1145 (emacs_abort): ... new name.
1146 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
1147 the place of the old 'abort' in emacs.c.
1148 * w32.c, w32fns.c (abort): Do not #undef.
1149 * w32.c (emacs_abort): Rename from w32_abort.
1150
30934d33
EZ
11512012-09-04 Eli Zaretskii <eliz@gnu.org>
1152
1153 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
1154 offsets[j].dv, since the y axis of the screen coordinates points
1155 down, while the y axis of the font definition coordinates points
1156 up. This fixes display of Arabic diacritics such as KASRA and
1157 KASRATAN. (Bug#11860)
1158
af26b72c
PE
11592012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1160
1161 Be more systematic about _setjmp vs setjmp.
1162 * alloc.c (test_setjmp, mark_stack):
1163 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
1164 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
1165 (png_load, my_error_exit, jpeg_load):
1166 * process.c (send_process_trap, send_process):
1167 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
1168 The underscored versions are up to 30x faster on some hosts.
1169 Formerly, the code used setjmp+longjmp sometimes and
1170 _setjmp+_longjmp at other times, with no particular reason to
1171 prefer setjmp+longjmp.
1172
26d4541d
PE
11732012-09-03 Paul Eggert <eggert@cs.ucla.edu>
1174
d42f4f0f 1175 Fix minor problem found by static checking.
26d4541d 1176 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 1177
c5e28e39
MR
11782012-09-03 Martin Rudalics <rudalics@gmx.at>
1179
1180 * buffer.c (Fdelete_all_overlays): New function.
1181
3eab3ca9
CY
11822012-09-03 Chong Yidong <cyd@gnu.org>
1183
1184 * gtkutil.c: Add extern decl for Qxft.
1185
c04889f8
PE
11862012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1187
1882aa38
PE
1188 * emacs.c, eval.c: Use bool for boolean.
1189 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
1190 (malloc_using_checking) [DOUG_LEA_MALLOC]:
1191 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
1192 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
1193 (main, decode_env_path, Fdaemon_initialized):
1194 * eval.c (call_debugger, Finteractive_p, interactive_p):
1195 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
1196 (maybe_call_debugger, Fbacktrace):
1197 * process.c (read_process_output, exec_sentinel):
1198 Use bool for booleans.
1199 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
1200 All callers changed.
1201 * eval.c (interactive_p): Omit always-true boolean argument
1202 EXCLUDE_SUBRS_P. All callers changed.
1203 * dispextern.h, lisp.h: Reflect above API changes.
1204 * firstfile.c (dummy): Use the address of 'main', whose signature
1205 won't change, instead of the address of 'initialize', whose
1206 signature just changed from int to bool.
1207 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
1208 * msdos.c (fatal_error_in_progress): ... from here.
1209 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
1210 of incrementing it.
1211 (redisplay_internal, unwind_redisplay): Simply clear
1212 REDISPLAYING_P when unwinding, instead of saving its previous,
1213 always-false value and then restoring it.
1214
a411ac43
PE
1215 Clean up some extern decls.
1216 Mostly, this hoists extern decls out of .c files and into .h files.
1217 That way, we're more likely to catch errors if the interfaces change.
1218 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
1219 declare xg_mark_data.
1220 * dispextern.h (x_frame_parm_handlers):
1221 * font.h (Qxft):
1222 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
1223 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
1224 (Qultra_bold, Qoblique, Qitalic):
1225 Move extern decl here from .c file.
1226 * alloc.c (xg_mark_data) [USE_GTK]:
1227 * doc.c (Qclosure):
1228 * eval.c (Qlexical_binding):
1229 * fns.c (time) [!HAVE_UNISTD_H]:
1230 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
1231 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
1232 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
1233 * lread.c (Qinternal_interpreter_environment):
1234 * minibuf.c (Qbuffer):
1235 * process.c (QCfamily, QCfilter):
1236 * widget.c (free_frame_faces):
1237 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
1238 * xfont.c (x_clear_errors):
1239 * xterm.c (x_frame_parm_handlers):
1240 Remove now-redundant extern decls.
1241 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
1242 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
1243 Now static.
1244 * xfaces.c: Remove unnecessary static decls.
1245 * xterm.c (updating_frame): Remove decl of nonexistent object.
1246
c04889f8
PE
1247 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
1248 when building globals.h, as the objects that are not built on
1249 this host are not needed to compile C files on this host.
1250
8b339673
JD
12512012-09-02 Jan Djärv <jan.h.d@swipnet.se>
1252
1253 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
1254
1255 * frame.h: Add missing prototype for x_wm_set_size_hint.
1256
a08d4ba7
PE
12572012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
1260 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
1261 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
1262 (Fsubstitute_command_keys):
1263 * editfns.c (region_limit, find_field, Fconstrain_to_field)
1264 (save_excursion_save, save_excursion_restore)
1265 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
1266 (format_time_string, general_insert_function)
1267 (make_buffer_string, make_buffer_string_both)
1268 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
1269 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
1270 (copy_text, insert_1, insert_1_both, insert_from_string)
1271 (insert_from_string_before_markers, insert_from_string_1)
1272 (insert_from_buffer, insert_from_buffer_1, replace_range)
1273 (replace_range_2, del_range_1, del_range_byte, del_range_both)
1274 (del_range_2, modify_region):
1275 * intervals.c (intervals_equal, balance_possible_root_interval)
1276 (adjust_intervals_for_insertion, merge_properties_sticky)
1277 (graft_intervals_into_buffer, lookup_char_property)
1278 (adjust_for_invis_intang, set_point_both)
1279 (get_property_and_range, compare_string_intervals)
1280 (set_intervals_multibyte_1, set_intervals_multibyte):
1281 * keyboard.c (decode_timer):
1282 Use bool for boolean.
1283 * intervals.h, lisp.h, systime.h: Reflect above API changes.
1284 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
1285
48c948de
CY
12862012-09-02 Chong Yidong <cyd@gnu.org>
1287
1288 * keymap.c (push_key_description): Print M-TAB as C-M-i
1289 (Bug#11758).
1290
6c49a40b
JB
12912012-09-02 Juanma Barranquero <lekktu@gmail.com>
1292
1293 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
1294 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
1295 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
1296 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
1297 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
1298 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
1299 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1300
4dfbd238
EZ
13012012-09-01 Eli Zaretskii <eliz@gnu.org>
1302
7e510e28
EZ
1303 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
1304 more than one grapheme cluster passed to the shaper: compute the
1305 offset adjustment values separately for each cluster. (Bug#11860)
1306
4dfbd238
EZ
1307 * image.c: Restore mistakenly removed inclusion of w32.h. Without
1308 it, GCC doesn't see prototypes of w32_delayed_load, and complains
1309 about implicit conversions from integer to pointer.
1310
86571ae0
DC
13112012-09-01 Daniel Colascione <dancol@dancol.org>
1312
1313 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
1314 system used too early.
1315
0e23ef9d
PE
13162012-09-01 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 Better seed support for (random).
1319 * emacs.c (main): Call init_random.
1320 * fns.c (Frandom): Set the seed from a string argument, if given.
1321 Remove long-obsolete Gentzel cruft.
1322 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
1323 (init_random): New function.
1324
17a2cbbd
DC
13252012-09-01 Daniel Colascione <dancol@dancol.org>
1326
1327 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
1328 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
1329 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
1330 x_wm_set_size_hint, x_query_colors, x_real_positions,
1331 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
1332 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
1333 all of which have been moved to common code.
1334
1335 * xfaces.c: Include TERM_HEADER instead of listing all possible
1336 window-system headers.
1337
1338 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
1339 to match header.
1340
1341 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
1342 directly accessing frame internals.
1343
f18cbb28 1344 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
1345 globals_of_w32font.
1346
1347 * process.c: Include TERM_HEADER instead of listing all possible
1348 window-system headers.
1349
1350 * nsterm.h: Remove declarations now in frame.h. Define
1351 FRAME_X_SCREEN, FRAME_X_VISUAL.
1352
1353 * menu.c: Include TERM_HEADER instead of listing all possible
1354 window-system headers.
1355
1356 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
1357 window system.
1358
1359 * keyboard.c: Include TERM_HEADER instead of listing all possible
1360 window-system headers.
1361
1362 * image.c: Include TERM_HEADER instead of listing all possible
1363 window-system headers. Declare Vlibrary_cache when compiling for
1364 Windows.
1365
1366 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
1367 window system declarations.
1368
1369 * frame.h: Move common functions here: set_frame_menubar,
1370 x_set_window_size, x_sync, x_get_focus_frame,
1371 x_set_mouse_position, x_set_mouse_pixel_position,
1372 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
1373 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
1374 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
1375 x_activate_menubar, x_real_positions, x_bitmap_icon,
1376 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
1377 and x_query_colors.
1378
1379 * frame.c: Include TERM_HEADER instead of listing all possible
1380 window-system headers.
1381
1382 * font.c: Include TERM_HEADER instead of listing all possible
1383 window-system headers.
1384
1385 * emacs.c: Include TERM_HEADER.
1386
f18cbb28
EZ
1387 * dispnew.c: Include TERM_HEADER instead of listing all possible
1388 window-system headers.
17a2cbbd 1389
f18cbb28 1390 * ccl.h: Include character.h.
17a2cbbd
DC
1391
1392 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
1393 the current window system; include in list of objects to link into
1394 Emacs.
1395
c650a5de
DA
13962012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1397
1398 Remove mark_ttys function and fix tty_display_info initialization.
1399 * lisp.h (mark_ttys): Remove prototype.
1400 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
1401 to mark_ttys because all possible values of 'top_frame' slot are
1402 the frames which are reachable from Vframe_list.
1403 * term.c (mark_ttys): Remove.
1404 (init_tty): Safely initialize 'top_frame' slot with Qnil.
1405
4e0f6479
DA
14062012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1407
1408 Change struct frame bitfields from unsigned char to unsigned.
1409 * frame.h (struct frame): Change type of 'display_preempted',
1410 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
1411 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
1412 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
1413 bitfields from unsigned char to unsigned.
1414
8b96a52c
DA
14152012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1416
1417 Remove unused member of struct x_output and struct w32_output.
1418 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
1419 * w32term.h (struct w32_output): Likewise.
1420
b4444c8a
JD
14212012-08-30 Jan Djärv <jan.h.d@swipnet.se>
1422
1423 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
1424 does not become zero (Bug#12234).
1425
b98521db
PE
14262012-08-30 Paul Eggert <eggert@cs.ucla.edu>
1427
1428 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
1429 for GCC 4.7.1 x86-64.
1430
31d02438
GM
14312012-08-30 Glenn Morris <rgm@gnu.org>
1432
1433 * lread.c (init_lread): For out-of-tree builds, only add the
1434 source directory's site-lisp dir to the load-path if it exists,
1435 consistent with in-tree builds. (Bug#12302)
1436
7f8941d8
JD
14372012-08-28 Jan Djärv <jan.h.d@swipnet.se>
1438
1439 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 1440 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
1441 (windowShouldClose:): Set window_closed.
1442 (dealloc): New member, free button_values.
fc0c31f8
JB
1443 (process_dialog:): Make member function. Remove window argument,
1444 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
1445 in button_values.
1446 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 1447 with tag. Remove return self, declare return value as void.
7f8941d8
JD
1448 (addString:row:): Remove return self, declare return value as void.
1449 (addSplit): Remove return self, declare return value as void.
1450 (clicked:): Remove return self, declare return value as void.
fc0c31f8 1451 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
1452 (initFromContents:isQuestion:): Adjust call to process_dialog.
1453 Code formatting change.
1454 (timeout_handler:): Set timer_fired to YES.
1455 (runDialogAt:): Set timer_fired to NO.
1456 Handle click on close button as quit.
1457
1458 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
1459 Add window_closed and button_values. Add void as return value for
1460 add(Button|String|Split). addButton takes int instead of Lisp_Object.
1461 Add process_dialog as new member.
1462
eada0861 14632012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 1464
eada0861
GM
1465 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
1466 is not one of the heaps we manage. (Bug#12242)
1467
14682012-08-28 Glenn Morris <rgm@gnu.org>
1469
1470 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
1471
457294dd
MR
14722012-08-28 Martin Rudalics <rudalics@gmx.at>
1473
1474 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
1475 auto-buffer-name window parameter. Install revision of reverted
1476 fix.
457294dd 1477
4f2daf31
DA
14782012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1479
1480 Do not allow to set major mode for a dead buffer.
1481 * buffer.c (Fset_buffer_major_mode): Signal an error
1482 if the buffer is dead.
1483 (Fother_buffer, other_buffer_safely): Remove redundant
1484 nested declaration.
1485
66322887
DA
14862012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1487
1488 Always use set_buffer_if_live to restore original buffer at unwind.
1489 * buffer.h (record_unwind_current_buffer): New function.
1490 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
1491 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
1492 * undo.c, window.c: Adjust users.
1493 * buffer.c (set_buffer_if_live): Fix comment.
1494
a3d794a1
DA
14952012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1496
1497 Fix usage of set_buffer_internal.
1498 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
1499 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
1500 * coding.c (decode_coding): Omit redundant test.
1501 * fileio.c (decide_coding_unwind): Likewise.
1502 * fns.c (secure_hash): Likewise.
1503 * insdel.c (modify_region): Likewise.
1504 * keyboard.c (command_loop_1): Likewise.
1505 * print.c (PRINTFINISH): Likewise.
1506 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
1507
59ea14cd
PE
15082012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1509
1510 * dispnew.c: Use bool for boolean.
1511 (frame_garbaged, display_completed, delayed_size_change)
1512 (fonts_changed_p, add_window_display_history)
1513 (add_frame_display_history, verify_row_hash)
1514 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
1515 (row_equal_p, realloc_glyph_pool)
1516 (allocate_matrices_for_frame_redisplay)
1517 (showing_window_margins_p)
1518 (adjust_frame_glyphs_for_frame_redisplay)
1519 (build_frame_matrix_from_leaf_window, make_current)
1520 (mirrored_line_dance, mirror_line_dance, update_frame)
1521 (update_window_tree, update_single_window)
1522 (check_current_matrix_flags, update_window, update_text_area)
1523 (update_window_line, set_window_update_flags, scrolling_window)
1524 (update_frame_1, scrolling, buffer_posn_from_coords)
1525 (do_pending_window_change, change_frame_size)
1526 (change_frame_size_1, sit_for):
1527 Use bool for boolean.
1528 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
1529 and remove last int (actually boolean) argument, which was always 0.
1530 All callers changed.
1531 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
1532 * dispextern.h (struct composition_it): Use bool for boolean.
1533 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
1534 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
1535 * dired.c (file_name_completion):
1536 Use bool for boolean. (This was missed in an earlier change.)
1537
95072a94
MR
15382012-08-27 Martin Rudalics <rudalics@gmx.at>
1539
1540 * window.c (Fset_window_configuration): Revert first part of
1541 last change.
1542
0f19feff
JD
15432012-08-27 Jan Djärv <jan.h.d@swipnet.se>
1544
1545 * nsterm.h (NSPanel): New class variable dialog_return.
1546
1547 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
1548 dialog_return.
1549 (windowShouldClose:): Use stop instead of stopModalWithCode.
1550 (clicked:): Ditto, and also set dialog_return (Bug#12258).
1551 (timeout_handler:): Use stop instead of abortModal. Send a dummy
1552 event.
1553 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
1554 modal loop returns.
1555
f10fe38f
PE
15562012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1557
de1339b0
PE
1558 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
1559 * composite.c (find_composition, composition_gstring_p)
1560 (composition_reseat_it, find_automatic_composition):
1561 * data.c (let_shadows_buffer_binding_p)
1562 (let_shadows_global_binding_p, set_internal, make_blv)
1563 (Fmake_variable_buffer_local, Fmake_local_variable)
1564 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
1565 (cons_to_signed, arith_driver):
1566 * dbusbind.c (xd_in_read_queued_messages):
1567 * dired.c (directory_files_internal, file_name_completion):
1568 Use bool for booleans.
1569 * dired.c (file_name_completion):
1570 * process.h (fd_callback):
1571 Omit int (actually boolean) argument. It wasn't being used.
1572 All uses changed.
1573 * composite.h, lisp.h: Reflect above API changes.
1574
f10fe38f
PE
1575 * cmds.c, coding.c: Use bool for booleans.
1576 * cmds.c (move_point, Fself_insert_command):
1577 * coding.h (struct composition status, struct coding_system):
1578 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
1579 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
1580 (emacs_mule_char, decode_coding_emacs_mule)
1581 (encode_coding_emacs_mule, detect_coding_iso_2022)
1582 (decode_coding_iso_2022, encode_invocation_designation)
1583 (encode_designation_at_bol, encode_coding_iso_2022)
1584 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
1585 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
1586 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
1587 (encode_coding_raw_text, detect_coding_charset)
1588 (decode_coding_charset, encode_coding_charset, detect_eol)
1589 (detect_coding, get_translation_table, produce_chars)
1590 (consume_chars, reused_workbuf_in_use)
1591 (make_conversion_work_buffer, code_conversion_save)
1592 (decode_coding_object, encode_coding_object)
1593 (detect_coding_system, char_encodable_p)
1594 (Funencodable_char_position, code_convert_region)
1595 (code_convert_string, code_convert_string_norecord)
1596 (Fset_coding_system_priority):
1597 * fileio.c (Finsert_file_contents):
1598 Use bool for booleans.
1599 * coding.h, lisp.h: Reflect above API changes.
1600 * coding.c: Remove unnecessary static function decls.
1601 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
1602 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
1603 not a boolean 'int', since callers never look at the return value.
1604 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
1605 * coding.h (decoding_buffer_size, encoding_buffer_size)
1606 (emacs_mule_string_char): Remove unused extern decls.
1607 (struct iso_2022_spec, struct coding_system):
1608 Use 'unsigned int : 1' for boolean fields, since there's more than one.
1609 (struct emacs_mule_spec): Remove unused field 'full_support'.
1610 All initializations removed.
1611 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
1612
5474c384
DA
16132012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1614
f10fe38f 1615 Fix spare memory change (Bug#12286).
5474c384
DA
1616 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
1617 (valid_lisp_object_p): Likewise.
1618
c4b6914d
MR
16192012-08-27 Martin Rudalics <rudalics@gmx.at>
1620
1621 * window.c (Fset_window_configuration): Record any window's old
1622 buffer if it's replaced (see Bug#8789). If the new current
1623 buffer doesn't appear in the selected window, go to its old
1624 point (Bug#12208).
1625
35aaa1ea
DA
16262012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1627
1628 Special MEM_TYPE_SPARE to denote reserved memory.
1629 * alloc.c (enum mem_type): New memory type.
1630 (refill_memory_reserve): Use new type for spare memory.
1631 This prevents live_cons_p and live_string_p from incorrect
1632 detection of uninitialized objects from spare memory as live.
1633
6af64513
PE
16342012-08-26 Paul Eggert <eggert@cs.ucla.edu>
1635
8b2e00a3
PE
1636 Spelling fixes.
1637 * Makefile.in (.PHONY): versioclean -> versionclean.
1638
b52d6985
PE
1639 Remove unused external symbols.
1640 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
1641 * window.c (Qwindow_valid_p, decode_valid_window):
1642 Now static, not extern.
1643 * data.c (Qinterval): Remove; unused.
1644 (syms_of_data): Do not define 'interval'.
1645 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
1646 * window.h (decode_valid_window):
1647 Remove decls.
1648
d5172d4f
PE
1649 * character.c, charset.c, chartab.c: Use bool for booleans.
1650 * character.c (lisp_string_width, string_count_byte8)
1651 (string_escape_byte8):
1652 * charset.c (charset_map_loaded, load_charset_map, read_hex):
1653 (load_charset_map_from_file, map_charset_chars)
1654 (Fdefine_charset_internal, define_charset_internal)
1655 (Fdeclare_equiv_charset, find_charsets_in_text)
1656 (Ffind_charset_region, char_charset, Fiso_charset):
1657 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
1658 (sub_char_table_set, sub_char_table_set_range)
1659 (char_table_set_range, optimize_sub_char_table)
1660 (map_sub_char_table):
1661 Use bool for boolean.
1662 * character.c (str_to_unibyte): Omit last boolean argument; it was
1663 always 0. All callers changed.
1664 * character.h, charset.h: Adjust to match previous changes.
1665 * character.h (char_printable_p): Remove decl of nonexistent function.
1666 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
1667 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
1668 are all boolean, so make them single-bit bitfields.
1669
6af64513
PE
1670 * lisp.h (ASET): Remove attempt to detect side effects.
1671 It was meant to be temporary and it often doesn't work,
1672 because when IDX has side effects the behavior of IDX==IDX
1673 is undefined. See Stefan Monnier in
1674 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
1675
e1f29348
BR
16762012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1677
1678 * lisp.h (functionp): New function (extracted from Ffunctionp).
1679 (FUNCTIONP): Use it.
1680 * eval.c (Ffunctionp): Use it.
1681
17c05d74
PE
16822012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1683
0f46bc75
PE
1684 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
1685 as that's faster and simpler than static storage. Don't bother
1686 with the g_main_context_query overhead if g_main_context_pending
1687 says no events are pending.
1688 (gfds, gfds_size): Remove these static vars.
1689 (xgselect_initialize): Remove; no longer needed.
1690 All uses and decls removed.
1691
ee4c0f69
PE
1692 * emacs.c (fatal_error_signal_hook): Remove.
1693 All uses removed. This leftover from old code was always 0.
1694
17c05d74
PE
1695 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
1696 * casefiddle.c (casify_object, casify_region):
1697 * casetab.c (set_case_table):
1698 * category.c, category.h (word_boundary_p):
1699 * category.h (CHAR_HAS_CATEGORY):
1700 Use bool for booleans, instead of int.
1701
391ceac5
EZ
17022012-08-25 Eli Zaretskii <eliz@gnu.org>
1703
1704 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
1705
2f221583
PE
17062012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1707
f4a681b0
PE
1708 On assertion failure, print backtrace if available.
1709 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
1710 (die) [ENABLE_CHECKING]: Print a backtrace if available.
1711 * Makefile.in (LIB_EXECINFO): New macro.
1712 (LIBES): Use it.
1713
2f221583
PE
1714 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
1715 * bytecode.c (exec_byte_code):
1716 * callint.c (check_mark, Fcall_interactively):
1717 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
1718 (getenv_internal, sync_process_alive, call_process_exited):
1719 * lisp.h (USE_SAFE_ALLOCA):
1720 Use bool for booleans, instead of int.
1721 * lisp.h, process.h: Adjust prototypes to match above changes.
1722 * callint.c (Fcall_interactively): Don't assume the mark's
1723 offset fits in 'int'.
1724
37ef52bb
PE
17252012-08-24 Paul Eggert <eggert@cs.ucla.edu>
1726
1727 * buffer.c, buffer.h: Use bool for boolean.
1728 * buffer.c (reset_buffer_local_variables)
1729 (buffer_lisp_local_variables, Fset_buffer_modified_p)
1730 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
1731 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
1732 (overlay_touches_p, overlay_strings, Foverlay_put)
1733 (report_overlay_modification, call_overlay_mod_hooks):
1734 (mmap_enlarge, mmap_set_vars):
1735 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
1736 Use bool for booleans, instead of int.
1737 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
1738 since the 1-or-0 return value is always ignored anyway.
1739 (mmap_initialized_p):
1740 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
1741 * buffer.h, lisp.h: Adjust prototypes to match above changes.
1742
2cc21167
PE
17432012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 * bidi.c: Use bool for boolean.
1746 This is a bit more readable, and makes the text segment of bidi.o
1747 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
1748 Presumably it's faster too.
1749 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
1750 Now bool.
1751 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1752 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
1753 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
1754 (bidi_explicit_dir_char, bidi_level_of_next_char)
1755 (bidi_find_other_level_edge, bidi_move_to_visually_next):
1756 Use bool for booleans, instead of int.
1757 * dispextern.h (bidi_init_it, bidi_paragraph_init)
1758 (bidi_unshelve_cache): Adjust decls to match code.
1759
7db4ddf4
MR
17602012-08-23 Martin Rudalics <rudalics@gmx.at>
1761
1762 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
1763 argument.
1764
b1bb8011
PE
17652012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1766
1767 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
1768 * atimer.h: Include <stdbool.h>.
1769
ff687885
DN
17702012-08-22 Dan Nicolaescu <dann@gnu.org>
1771
1772 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
1773 compile time tests instead of run time tests on systems that do
1774 not use them.
1775 (FRAME_MAC_P): Remove leftover from deleted code.
1776 * frame.c (syms_of_frame): Remove leftover from deleted code.
1777
4ce7a138
JD
17782012-08-22 Jan Djärv <jan.h.d@swipnet.se>
1779
1780 * nsterm.m (insertText:): Don't clear modifiers if code is space.
1781
d733ec6d
PE
17822012-08-22 Paul Eggert <eggert@cs.ucla.edu>
1783
1784 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
1785 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 1786 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
1787 (fontset_add): Return void, for FONTSET_ADD.
1788
d0d2d26f
PE
17892012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1790
fce31d69
PE
1791 * alloc.c: Use bool for booleans.
1792 (gc_in_progress, abort_on_gc)
1793 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1794 (dont_register_blocks) [GC_MALLOC_CHECK]:
1795 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
1796 (check_string_bytes, make_specified_string, memory_full)
1797 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
1798 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
1799 (mark_stack, valid_pointer_p, make_pure_string)
1800 (Fgarbage_collect, survives_gc_p, gc_sweep):
1801 Use bool for booleans, instead of int.
1802 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1803 Remove unused local.
1804 * alloc.c (PURE_POINTER_P):
1805 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
1806 * editfns.c (Fformat):
1807 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
1808 (Fdo_auto_save):
1809 * fns.c (sweep_weak_table):
1810 * lisp.h (suppress_checking, push_message, survives_gc_p)
1811 (make_pure_string, gc_in_progress, abort_on_gc):
1812 * lread.c (readchar, read1):
1813 * print.c (Fprin1_to_string):
1814 * xdisp.c (push_message):
1815 Use bool for booleans affected directly or indirectly by
1816 alloc.c's changes.
1817
d0d2d26f
PE
1818 Make recently-introduced setters macros.
1819 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
1820 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
1821 (set_fontset_default, set_fontset_fallback): Rename from their
1822 upper-case counterparts, and make them functions rather than macros.
1823 This is more consistent with the other recently-introduced setters.
1824 These don't need to be inline, since they're local.
1825
d18e2bb6
JD
18262012-08-21 Jan Djärv <jan.h.d@swipnet.se>
1827
1828 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
1829 the loop (Bug#12247).
1830
1b9d9d16
PE
18312012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1832
1833 * lisp.h (vcopy): Use memcpy rather than our own loop.
1834 This fixes a performance regression introduced by the recent
1835 addition of vcopy. This means 'vcopy' will need to be modified
1836 for a copying collector, but that's OK. Also, tighten the
1837 checking in the assertion.
1838
b2f09701
EZ
18392012-08-21 Eli Zaretskii <eliz@gnu.org>
1840
1841 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
1842 components for RTL text (Bug#11860). Adjust X-OFFSET of each
1843 non-base glyph for the width of the base character, according to
e1f29348
BR
1844 what x_draw_composite_glyph_string_foreground expects.
1845 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
1846 expectations, to produce correct width of the composed character.
1847 Reverse the sign of the DU offset produced by ScriptPlace.
1848
9b994fed
PE
18492012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1850
1851 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
1852
086ca913
DA
18532012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1854
1855 Avoid direct writes to contents member of struct Lisp_Vector.
1856 * lisp.h (vcopy): New function to copy data into vector.
1857 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
1858 * fns.c (Ffillarray): Use ASET.
1859 * keyboard.c (timer_check_2): Use AREF and ASET.
1860 (append_tool_bar_item, Frecent_keys): Use vcopy.
1861 * lread.c (read_vector): Use ASET.
1862 * msdos.c (Frecent_doskeys): Use vcopy.
1863 * xface.c (Finternal_copy_lisp_face): Use vcopy.
1864 (Finternal_merge_in_global_face): Use ASET and vcopy.
1865 * xfont.c (xfont_list_pattern): Likewise.
1866
5481664a
MR
18672012-08-21 Martin Rudalics <rudalics@gmx.at>
1868
1869 * window.c (Fwindow_point): For the selected window always return
1870 the position of its buffer's point.
1871 (Fset_window_point): For the selected window always go in its
1872 buffer to the specified position.
1873
6d470bdd
DA
18742012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1875
1876 Setter macros for fontsets.
1877 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
1878 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
1879 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
1880 Adjust users.
1881
24564fe1
GM
18822012-08-20 Glenn Morris <rgm@gnu.org>
1883
1884 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1885 Don't assume that `ln -f' works.
1886
0a05a035
EZ
18872012-08-20 Eli Zaretskii <eliz@gnu.org>
1888
1889 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
1890 and later about non-assignments with no effect. See discussion at
1891 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
1892 details.
1893
e46f2325
DA
18942012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1895
1896 Inline setter functions for Lisp_Objects slots of struct specbinding.
1897 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
1898 Adjust users.
1899
734fbd86
MR
19002012-08-20 Martin Rudalics <rudalics@gmx.at>
1901
1902 * window.c (select_window): Always make selected window's buffer
1903 current.
1904
f1a95992
DA
19052012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1906
1907 Use AREF and ASET for docstrings of category tables.
1908 * category.h (CATEGORY_DOCSTRING): Use AREF.
1909 (SET_CATEGORY_DOCSTRING): Use ASET.
1910 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
1911
e83064be
DA
19122012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1913
1914 Inline setter functions for hash table members.
1915 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
1916 (set_hash_hash, set_hash_index): Rename with _slot suffix.
1917 (set_hash_key_and_value, set_hash_index, set_hash_next)
1918 (set_hash_hash): New functions.
1919 * charset.c, fns.c: Adjust users.
1920
4ce60d2e
DA
19212012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1922
1923 Inline getter and setter functions for per-buffer values.
1924 * buffer.h (per_buffer_default, set_per_buffer_default)
1925 (per_buffer_value, set_per_buffer_value): New functions.
1926 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
1927 * buffer.c, data.c: Adjust users.
1928
c06c9690
JB
19292012-08-20 Juanma Barranquero <lekktu@gmail.com>
1930
1931 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
1932
32bd4250
PE
19332012-08-19 Paul Eggert <eggert@cs.ucla.edu>
1934
bad03192 1935 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
1936 as gnulib does this if the system doesn't.
1937 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
1938 Remove declaration. MS-Windows declares it on stdlib.h which is
1939 included by conf_post.h.
b69a6d22
PE
1940 * emacs.c (environ) [DOUG_LEA_MALLOC]:
1941 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
1942 * vm-limit.c: Include <unistd.h>, for 'environ'.
1943
22d7feb2
PE
1944 * unexaix.c, unexcoff.c: Include "mem-limits.h".
1945 (start_of_data): Remove decl; mem-limits.h provides it.
1946
32bd4250
PE
1947 * xdisp.c (handle_invisible_prop): Make it a bit faster
1948 and avoid a gcc -Wmaybe-uninitialized diagnostic.
1949
450809af
CY
19502012-08-19 Chong Yidong <cyd@gnu.org>
1951
1952 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
1953 ends (Bug#3874).
1954
9e677988
AS
19552012-08-19 Andreas Schwab <schwab@linux-m68k.org>
1956
6b1319ce
AS
1957 * .gdbinit: Use call instead of set when calling a function in the
1958 inferior.
1959
9e677988
AS
1960 * data.c (set_internal): Don't use set_blv_found.
1961 (Fkill_local_variable): Likewise.
1962
d7191076
AA
19632012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
1964
1965 * nsfont.m (ns_ascii_average_width): Ensure the string
1966 ascii_printable is initialized with a null-terminated character
1967 array. Otherwise, it can contain undesired extra characters.
1968
e757f1c6
PE
19692012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1970
1971 port new setting code to Sun C 5.8 2005/10/13
1972 * chartab.c, lisp.h (char_table_set, char_table_set_range):
1973 Return void, not Lisp_Object. Otherwise, the compiler
1974 complains about (A?B:C) where B is void and C is Lisp_Object
1975 when compiling CHAR_TABLE_SET, due to the recent change to
1976 the API of sub_char_table_set_contents.
1977
a999ce26
CY
19782012-08-18 Chong Yidong <cyd@gnu.org>
1979
1980 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
1981 for the string case (Bug#3874).
1982
3f22b86f
PE
19832012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1984
39eb03f1
PE
1985 * buffer.h (BSET): Remove (Bug#12215).
1986 Replace all uses with calls to new setter functions.
1987 (bset_bidi_paragraph_direction, bset_case_canon_table)
1988 (bset_case_eqv_table, bset_directory, bset_display_count)
1989 (bset_display_time, bset_downcase_table)
1990 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
1991 (bset_last_selected_window, bset_local_var_alist)
1992 (bset_mark_active, bset_point_before_scroll, bset_read_only)
1993 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
1994 (bset_width_table):
1995 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
1996 (bset_auto_fill_function, bset_auto_save_file_format)
1997 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
1998 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
1999 (bset_cache_long_line_scans, bset_case_fold_search)
2000 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
2001 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
2002 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
2003 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
2004 (bset_header_line_format, bset_indicate_buffer_boundaries)
2005 (bset_indicate_empty_lines, bset_invisibility_spec)
2006 (bset_left_fringe_width, bset_major_mode, bset_mark)
2007 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
2008 (bset_name, bset_overwrite_mode, bset_pt_marker)
2009 (bset_right_fringe_width, bset_save_length)
2010 (bset_scroll_bar_width, bset_scroll_down_aggressively)
2011 (bset_scroll_up_aggressively, bset_selective_display)
2012 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
2013 (bset_word_wrap, bset_zv_marker):
2014 * category.c (bset_category_table):
2015 * syntax.c (bset_syntax_table):
2016 New setter functions.
2017
6a09a33b
PE
2018 * process.h (PSET): Remove (Bug#12215).
2019 Replace all uses with calls to new setter functions.
2020 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2021 (PROCESS_INLINE): New macro.
2022 (pset_childp): New setter function.
2023 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
2024 * process.c (PROCESS_INLINE):
2025 Define to EXTERN_INLINE, so that the corresponding functions
2026 are compiled into code.
2027 (pset_buffer, pset_command, pset_decode_coding_system)
2028 (pset_decoding_buf, pset_encode_coding_system)
2029 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
2030 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
2031 (pset_type, pset_write_queue): New setter functions.
2032
e8c17b81
PE
2033 * window.h (WSET): Remove (Bug#12215).
2034 Replace all uses with calls to new setter functions.
2035 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2036 (WINDOW_INLINE): New macro.
2037 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
2038 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
2039 (wset_total_lines, wset_vertical_scroll_bar)
2040 (wset_window_end_pos, wset_window_end_valid)
2041 (wset_window_end_vpos): New setter functions.
2042 * window.c (WINDOW_INLINE):
2043 Define to EXTERN_INLINE, so that the corresponding functions
2044 are compiled into code.
2045 (wset_combination_limit, wset_dedicated, wset_display_table)
2046 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
2047 (wset_new_normal, wset_new_total, wset_next_buffers)
2048 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
2049 (wset_prev_buffers, wset_right_fringe_width)
2050 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
2051 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
2052 (wset_window_parameters):
2053 * xdisp.c (wset_base_line_number, wset_base_line_pos)
2054 (wset_column_number_displayed, wset_region_showing):
2055 New setter functions.
2056
3f22b86f
PE
2057 * termhooks.h (TSET): Remove (Bug#12215).
2058 Replace all uses with calls to new setter functions.
2059 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2060 (TERMHOOKS_INLINE): New macro.
2061 (tset_charset_list, tset_selection_alist): New setter functions.
2062 * terminal.c (TERMHOOKS_INLINE):
2063 Define to EXTERN_INLINE, so that the corresponding functions
2064 are compiled into code.
2065 (tset_param_alist): New setter function.
2066
742af32f
PE
20672012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2068
15dbb4d6
PE
2069 * keyboard.h (KSET): Remove (Bug#12215).
2070 Replace all uses with calls to new setter functions.
2071 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2072 (KEYBOARD_INLINE): New macro.
2073 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
2074 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
2075 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
2076 New setter functions.
2077 * keyboard.c (KEYBOARD_INLINE):
2078 Define to EXTERN_INLINE, so that the corresponding functions
2079 are compiled into code.
2080 (kset_echo_string, kset_kbd_queue)
2081 (kset_keyboard_translate_table, kset_last_prefix_arg)
2082 (kset_last_repeatable_command, kset_local_function_key_map)
2083 (kset_overriding_terminal_local_map, kset_real_last_command)
2084 (kset_system_key_syms): New setter functions.
2085
f00af5b1
PE
2086 * frame.h (FSET): Remove (Bug#12215).
2087 Replace all uses with calls to new setter functions.
2088 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2089 (FRAME_INLINE): New macro.
2090 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
2091 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
2092 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
2093 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
2094 (fset_param_alist, fset_root_window, fset_scroll_bars)
2095 (fset_selected_window, fset_title, fset_tool_bar_items)
2096 (fset_tool_bar_position, fset_tool_bar_window): New functions.
2097 * frame.c (FRAME_INLINE):
2098 Define to EXTERN_INLINE, so that the corresponding functions
2099 are compiled into code.
2100 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
2101
0c94c8d6
PE
2102 A few more naming-convention fixes for getters and setters.
2103 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
2104 and rename from buffer_overlays_set_before.
2105 (set_buffer_overlays_after): Move here from buffer.h, and rename
2106 from buffer_overlays_set_after.
2107 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
2108 All uses changed.
2109 (set_buffer_intervals): Rename from buffer_set_intervals.
2110 * intervals.c (set_interval_object): Move here from intervals.h,
2111 and rename from interval_set_object.
2112 (set_interval_left): Move here from intervals.h, and rename from
2113 interval_set_left.
2114 (set_interval_right): Move here from intervals.h, and rename from
2115 interval_set_right.
2116 (copy_interval_parent): Move here from intervals.h, and rename from
2117 interval_copy_parent.
2118 * intervals.h (set_interval_parent): Rename from interval_set_parent.
2119 (set_interval_plist): Rename from interval_set_plist.
2120 Return void, not Lisp_Object, since no caller uses the result.
2121 * lisp.h (string_intervals): Rename from string_get_intervals.
2122 (set_string_intervals): Rename from string_set_intervals.
2123
34dabdb7
PE
2124 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
2125 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 2126 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
2127 All uses changed. See the end of
2128 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
2129
742af32f
PE
2130 * lisp.h (CSET): Remove (Bug#12215).
2131 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
2132 (set_char_table_purpose): New functions,
2133 replacing CSET. All uses changed. For example, replace
2134 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 2135 "set_char_table_parent (char_table, parent);".
742af32f
PE
2136 The old version was confusing because it used the same name
2137 'parent' for two different things.
2138
a04e2c62
DA
21392012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2140
2141 Functions to get and set Lisp_Object fields of buffer-local variables.
2142 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
2143 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
2144 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
2145 * data.c, eval.c, frame.c: Adjust users.
2146
383dcbf9
CY
21472012-08-17 Chong Yidong <cyd@gnu.org>
2148
2149 * xfaces.c (merge_face_vectors): If the target font specfies a
2150 font spec, make the font's attributes take precedence over
2151 directly-specified attributes.
2152 (merge_face_ref): Recognize :font.
2153
44386687
DA
21542012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2155
2156 Do not use memcpy for copying intervals.
2157 * intervals.c (reproduce_interval): New function.
2158 (reproduce_tree, reproduce_tree_obj): Use it.
2159 (reproduce_tree_obj): Remove prototype.
2160
927c7216
PE
21612012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * lisp.h (duration_to_sec_usec): Remove unused decl.
2164
93044f7b
AA
21652012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
2166
2167 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
2168 to an allocated instance of NSString, not to the class itself.
2169
9851e4a5
JB
21702012-08-17 Juanma Barranquero <lekktu@gmail.com>
2171
2172 * makefile.w32-in (C_CTYPE_H): New macro.
2173 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
2174 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
2175 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2176
620f13b0
PE
21772012-08-16 Paul Eggert <eggert@cs.ucla.edu>
2178
2179 Use ASCII tests for character types.
2180 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
2181 * xfns.c, xterm.c:
2182 Don't include <ctype.h>; was not needed.
2183 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
2184 * sysdep.c, xfaces.c:
2185 Include <c-ctype.h> instead of <ctype.h>.
2186 * nsterm.m: Include <c-ctype.h>.
2187 * charset.c (read_hex):
2188 * doc.c (Fsnarf_documentation):
2189 * fileio.c (IS_DRIVE) [WINDOWSNT]:
2190 (DRIVE_LETTER) [DOS_NT]:
2191 (Ffile_name_directory, Fexpand_file_name)
2192 (Fsubstitute_in_file_name):
2193 * font.c (font_parse_xlfd, font_parse_fcname):
2194 * frame.c (x_set_font_backend):
2195 * gtkutil.c (xg_get_font):
2196 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
2197 * nsimage.m (hexchar):
2198 * nsterm.m (ns_xlfd_to_fontname):
2199 * sysdep.c (system_process_attributes):
2200 * xfaces.c (hash_string_case_insensitive):
2201 Use C-locale tests instead of locale-specific tests for character
2202 types, since we want the ASCII interpretation here, not the
2203 interpretation suitable for whatever happens to be the current locale.
2204
52162052
MR
22052012-08-16 Martin Rudalics <rudalics@gmx.at>
2206
2207 Consistently check windows for validity/liveness
2208 (Bug#11984, Bug#12025, Bug#12026).
2209 * lisp.h (CHECK_VALID_WINDOW): New macro.
2210 * window.c (decode_window): Rename to decode_live_window.
2211 (decode_valid_window, Fwindow_valid_p): New functions.
2212 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
2213 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
2214 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
2215 (Fwindow_prev_sibling, Fwindow_combination_limit)
2216 (Fset_window_combination_limit, Fwindow_use_time)
2217 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
2218 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
2219 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
2220 (Fwindow_hscroll, Fset_window_hscroll)
2221 (Fwindow_redisplay_end_trigger)
2222 (Fset_window_redisplay_end_trigger, Fwindow_edges)
2223 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
2224 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2225 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
2226 (Fwindow_end, Fset_window_point, Fset_window_start)
2227 (Fpos_visible_in_window_p, Fwindow_line_height)
2228 (Fwindow_dedicated_p, Fset_window_dedicated_p)
2229 (Fwindow_prev_buffers, Fset_window_prev_buffers)
2230 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
2231 (Fset_window_parameter, Fwindow_display_table)
2232 (Fset_window_display_table, Fdelete_other_windows_internal)
2233 (Fset_window_buffer, Fset_window_new_total)
2234 (Fset_window_new_normal, Fdelete_window_internal)
2235 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
2236 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
2237 (Fwindow_scroll_bars): Check whether argument window is a valid or
2238 live window. Update doc-strings.
2239 (syms_of_window): New symbol Qwindow_valid_p.
2240 * keyboard.c (Fposn_at_x_y): Check whether argument
2241 frame_or_window denotes a valid window.
2242
2751c80f
DA
22432012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2244
2245 Fix previous char table change.
2246 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
2247 * chartab.c (optimize_sub_char_table): Likewise.
2248
032a42c8
CY
22492012-08-16 Chong Yidong <cyd@gnu.org>
2250
a2d19368
CY
2251 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
2252
032a42c8
CY
2253 * xfont.c (xfont_open):
2254 * xftfont.c (xftfont_open): Set the font's max_width field.
2255
2256 * nsfont.m (nsfont_open): Similar to the Xft backend, set
2257 min_width to space_width and average_width to the average over
2258 printable ASCII characters.
2259 (ns_char_width): Code cleanup.
2260 (ns_ascii_average_width): New utility function.
2261
2262 * font.h (struct font): Update comments.
2263
a098c930
DA
22642012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2265
032a42c8 2266 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
2267 * lisp.h (CSET): New macro.
2268 (char_table_set_extras, char_table_set_contents)
2269 (sub_char_table_set_contents): New function.
2270 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
2271 * syntax.c: Adjust users.
2272
8be3a09c
SM
22732012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
2274
2275 * eval.c (eval_sub): Bind lexical-binding.
2276 * lread.c (Qlexical_binding): Make non-static.
2277
ac4845a6
JD
22782012-08-15 Jan Djärv <jan.h.d@swipnet.se>
2279
ddee6515
JD
2280 * nsmenu.m (popupSession): Remove.
2281 (pop_down_menu): Remove endModalSession.
2282 (timeout_handler:): New method.
2283 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
2284 Call runModalForWindow. Check timer_fired when it returns.
2285 If not set, cancel timer and break out of loop.
2286 Otherwise loop again, with a new timeout.
2287
2288 * nsterm.m: Include fcntl.h if present.
2289 (fd_entry, t_readfds, inNsSelect): Remove.
2290 (select_writefds, select_valid, select_timeout, selfds)
2291 (select_mutex, apploopnr): Add.
2292 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
2293 Otherwise call kbd_buffer_store_event.
2294 (ns_send_appdefined): Remove release of fd_entry.
2295 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
2296 Increment and decrement apploopnr.
2297 (ns_select): If no file descriptors, just do a NSTimer.
2298 Otherwise copy read/write masks and start select thread (fd_handler).
2299 Start main loop and wait for application defined event.
2300 Inform select thread to stop selecting after main loop is exited.
2301 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 2302 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
2303 (fd_handler:): Loop forever, wait for info from the main thread
2304 to either start or stop selecting. When select returns, send
2305 and appdefined event.
2306 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
2307 If not call kbd_buffer_store_event.
2308
2309 * nsterm.h (EmacsApp): fd_handler takes id argument.
2310 (EmacsDialogPanel): Add timer_fired and timeout_handler.
2311
ac4845a6
JD
2312 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
2313
eb424fe3
EZ
23142012-08-15 Eli Zaretskii <eliz@gnu.org>
2315
2316 * region-cache.c (move_cache_gap): Update gap_len using the actual
2317 growth of the boundaries array. Do not change cache_len.
2318 (Bug#12196)
2319
4e6a86c6
DA
23202012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2321
2322 Generalize and cleanup font subsystem checks.
2323 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
2324 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
2325 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 2326
5bf192ca
DA
23272012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2328
2329 * gtkutil.c (xg_get_font): Use pango_units_to_double.
2330
f2045622
CY
23312012-08-15 Chong Yidong <cyd@gnu.org>
2332
8be3a09c
SM
2333 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
2334 When using the new font chooser, use gtk_font_chooser_get_font_desc to
2335 extract the font descriptor instead of just the font name.
2336 In that case, return a font spec instead of a string.
f2045622
CY
2337 (x_last_font_name): Move to this file from xfns.c.
2338
2339 * xfns.c (Fx_select_font): The return value can also be a font
2340 spec. Move x_last_font_name management to gtkutil.c.
2341
2342 * xfaces.c: Make font weight and style symbols non-static.
2343
7f6feb56
SM
23442012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
2345
2346 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
2347 (bug#12117).
2348
fecbd8ff
SM
23492012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
2350
2351 * alloc.c (Fgarbage_collect): Use plural form consistently.
2352
9b8d5165
EZ
23532012-08-14 Eli Zaretskii <eliz@gnu.org>
2354
2355 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
2356 iteration through the command loop. Fixes a problem whereby mouse
2357 movements are ignored until the first mouse click.
2358
f5d9e83a
PE
23592012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2360
2361 Use bool, not int, for Lisp booleans.
2362 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
2363 makes Emacs a bit smaller and presumably a bit faster.
2364 * lisp.h: Include <stdbool.h>.
2365 (struct Lisp_Boolfwd, defvar_bool):
2366 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
2367 * regex.c [!emacs]: Include <stdbool.h>.
2368 (false, true): Remove; <stdbool.h> does this for us now.
2369
55802e4a
CY
23702012-08-14 Chong Yidong <cyd@gnu.org>
2371
4abcdac8
CY
2372 * character.c (Fcharacterp): Doc fix (Bug#12076).
2373
2374 * data.c (Findirect_variable): Doc fix (Bug#11040).
2375
55802e4a
CY
2376 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
2377
2378 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 2379 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 2380
8e99d072
BR
23812012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2382
2383 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
2384 (bug#12022).
2385
08908aca
MR
23862012-08-14 Martin Rudalics <rudalics@gmx.at>
2387
2388 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
2389 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
2390 * minibuf.c (choose_minibuf_frame, read_minibuf):
2391 * w32fns.c (x_create_tip_frame):
2392 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
2393 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
2394
56120d6f
PE
23952012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 * intervals.c (offset_intervals): Remove obsolete comment.
2398
67b77c0b
AS
23992012-08-14 Andreas Schwab <schwab@linux-m68k.org>
2400
2401 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
2402
f48b82fd
GR
24032012-08-14 Gergely Risko <gergely@risko.hu>
2404
2405 * coding.c (decode_coding): Record buffer modification before
2406 disabling undo_list (Bug#11773).
2407
fd318b54
DA
24082012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2409
2410 Revert and cleanup some recent overlay changes.
2411 * buffer.h (enum overlay_type): Remove.
2412 (buffer_get_overlays, buffer_set_overlays): Likewise.
2413 (buffer_set_overlays_before, buffer_set_overlays_after):
2414 New function. Adjust users.
2415 (unchain_both): Add eassert.
2416
41a62dd9
DA
24172012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2418
2419 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
2420
5884c324
PE
24212012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 * gtkutil.c (xg_mark_data): Don't assume C99.
2424
ca06f160
JD
24252012-08-13 Jan Djärv <jan.h.d@swipnet.se>
2426
2427 * gtkutil.c (xg_frame_tb_info): New struct.
2428 (TB_INFO_KEY): New define.
2429 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
2430 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
2431 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
2432 if not present.
2433 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 2434 is up to date. Otherwise store new data.
ca06f160
JD
2435 (free_frame_tool_bar): Free xg_frame_tb_info if present.
2436
7864a3f7
DA
24372012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2438
2439 Use KSET for write access to Lisp_Object members of struct kboard.
2440 * keyboard.h (KSET): New macro.
2441 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
2442 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
2443 * xterm.c: Adjust users.
2444
4c31be61
DA
24452012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2446
2447 Use BSET for write access to Lisp_Object members of struct buffer.
2448 * buffer.h (BSET): New macro.
2449 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
2450 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
2451 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
2452 * window.c, xdisp.c, xfns.c: Adjust users.
2453
14ae4239
BT
24542012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
2455
2456 * lread.c (syms_of_lread): Initialize Vlexical_binding.
2457
32bcadb4
JD
24582012-08-11 Jan Djärv <jan.h.d@swipnet.se>
2459
3d29b2ce 2460 * nsterm.m (not_in_argv): New function.
fc0c31f8 2461 (application:openFile, application:openTempFile:):
3d29b2ce
JD
2462 (application:openFileWithoutUI:, application:openFiles:): Open file
2463 if not_in_argv returns non-zero (bug#12171).
2464
32bcadb4 2465 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
2466 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
2467 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
2468 (xg_get_font_name): Use those functions/macros here.
2469 Reported by Frans Oilinki <moilinki@gmail.com>.
2470
9ff9402d 24712012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
2472
2473 * unexmacosx.c (copy_data_segment): Copy initialized data in
2474 statically linked libraries from input file rather than memory.
2475
db74a5fc
YM
2476 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
2477 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
2478 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
2479
25e65510
GM
24802012-08-10 Glenn Morris <rgm@gnu.org>
2481
2482 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
2483 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
2484
7961135c
DA
24852012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2486
2487 Fix last change to allow compilation with low optimization levels.
2488 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
2489 Reported by Jan Djärv <jan.h.d@swipnet.se>.
2490
42b3a444
DA
24912012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2492
2493 Use common inline syntax in intervals.h.
2494 * intervals.h (INTERVALS_INLINE): New macro.
2495 Change all users from LISP_INLINE.
2496
9fb0c957
DA
24972012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2498
2499 Define Qnone once for all platforms.
2500 * frame.c (Qnone): Define here.
2501 (syms_of_frame): DEFSYM it.
2502 * lisp.h (Qnone): New declaration.
2503 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
2504 * xfns.c: Remove duplication. Adjust users.
2505
65e8ee52
DA
25062012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2507
2508 Remove unused macros from intervals.h.
2509 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
2510 * intervals.c: Adjust comment.
2511
9b855fd6
EZ
25122012-08-10 Eli Zaretskii <eliz@gnu.org>
2513
2514 * w32fns.c <w32_unicode_gui>: New static variable.
2515 (globals_of_w32fns): Initialize it according to os_subtype.
2516 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
2517 testing os_subtype.
2518
39cb9e56 25192012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
2520 Eli Zaretskii <eliz@gnu.org>
2521
2522 Fix bug #10299 with Unicode characters sent by customized
2523 keyboards created by MSKLC.
2524 * w32fns.c (INIT_WINDOW_CLASS): New macro.
2525 (w32_init_class): Use it to initialize the Emacs class with either
2526 ANSI or Unicode API calls.
2527 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
2528 later.
2529 (w32_wnd_proc): If the character code sent by WM_CHAR or
2530 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
2531 original message. Call DefWindowProcW on NT and later.
2532
9374581a
GM
25332012-08-10 Glenn Morris <rgm@gnu.org>
2534
4b94e8cf
GM
2535 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
2536
9374581a
GM
2537 * lisp.h (DIRECTORY_SEP): Let configure set it.
2538
a2752828
DA
25392012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2540
2541 Use TSET for write access to Lisp_Object slots of struct terminal.
2542 * termhooks.h (TSET): New macro.
2543 * coding.c, terminal.c, xselect.c: Adjust users.
2544
cc92c454
SM
25452012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
2546
2547 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
2548 the failing expression, include them in the error message.
2549 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
2550 * lisp.h (internal_condition_case_n): Update declaration.
2551
4cb3e6b3
DA
25522012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2553
2554 Inline functions to examine and change buffer overlays.
2555 * buffer.c (unchain_both): New function.
2556 * buffer.h (buffer_get_overlays, buffer_set_overlays):
2557 (buffer_has_overlays): New function.
2558 (enum overlay_type): New enum.
2559 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
2560 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
2561
8707c1e5
DA
25622012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2563
2564 Inline functions to examine and change buffer intervals.
2565 * alloc.c (mark_interval_tree): Remove.
2566 (MARK_INTERVAL_TREE): Simplify.
2567 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
2568 * intervals.c (buffer_balance_intervals): New function.
2569 (graft_intervals_into_buffer): Adjust indentation.
2570 (set_intervals_multibyte): Simplify.
2571 * buffer.h (BUF_INTERVALS): Remove.
2572 (buffer_get_intervals, buffer_set_intervals): New function.
2573 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
2574 * intervals.c, textprop.c: Adjust users.
2575
ad8c997f
DA
25762012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2577
2578 Inline functions to examine and change string intervals.
2579 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
2580 (string_get_intervals, string_set_intervals): New function.
2581 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2582 * lread.c, print.c, textprop.c: Adjust users.
2583
32ac3a6b
GM
25842012-08-08 Glenn Morris <rgm@gnu.org>
2585
2586 * lisp.mk (lisp): Remove language/persian.elc.
2587
77c7bcb1
DA
25882012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2589
2590 Cleanup intervals.
2591 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
2592 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
2593 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
2594 Adjust comment. Move under #if 0.
77c7bcb1
DA
2595 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2596 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
2597
9c08a8d4
DA
25982012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2599
2600 Check total length of intervals with eassert.
2601 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
2602 * intervals.c: Change all users to eassert.
2603
26d16b35
EZ
26042012-08-07 Eli Zaretskii <eliz@gnu.org>
2605
14ae4239
BT
2606 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
2607 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
2608 INTERNAL_FIELD in Lisp_Cons.
2609
c644523b
DA
26102012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2611
2612 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
2613 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
2614 name since all xname users are fixed long time ago. Do not
2615 use INTERNAL_FIELD.
2616 (set_symbol_name, set_symbol_function, set_symbol_plist):
2617 (set_symbol_next, set_overlay_plist): New function.
2618 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
2619 (struct Lisp_Overlay): Likewise.
2620 (CVAR, MVAR, SVAR): Remove.
2621 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
2622 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
2623 * xterm.c: Adjust users.
2624 * .gdbinit: Change to use name field of struct Lisp_Symbol
2625 where appropriate.
2626
6a3d20cc
DA
26272012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2628
2629 Basic functions to set Lisp_Object and pointer slots of intervals.
2630 * intervals.h (interval_set_parent, interval_set_object):
2631 (interval_set_left, interval_set_right, interval_set_plist):
2632 (interval_copy_parent): New function.
2633 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
2634 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
2635 Adjust indentation.
6a3d20cc
DA
2636 (INTERVAL_SIZE): Remove. Adjust users.
2637 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
2638
4d2b044c
DA
26392012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2640
2641 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
2642 * process.h (PGET): Remove.
2643 (struct Lisp_Process): Do not use INTERNAL_FIELD.
2644 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2645
d3d50620
DA
26462012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2647
2648 Drop WGET and revert read access to Lisp_Objects slots of struct window.
2649 * window.h (WGET): Remove.
2650 (struct window): Do not use INTERNAL_FIELD.
2651 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2652 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2653 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2654 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2655 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2656 Adjust users.
2657
d10a51dc
CY
26582012-08-07 Chong Yidong <cyd@gnu.org>
2659
2660 * window.c (Fwindow_edges, Fwindow_pixel_edges)
2661 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
2662 (Fdelete_window_internal): Signal an error if the window is not on
2663 a live frame (Bug#12025).
2664
e69b0960
DA
26652012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2666
2667 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
2668 * frame.h (FGET): Remove.
2669 (struct frame): Do not use INTERNAL_FIELD.
2670 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2671 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2672 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2673 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2674
25a20a3a
JB
26752012-08-06 Juanma Barranquero <lekktu@gmail.com>
2676
2677 * w32.c: Silence compiler warnings.
2678 (map_w32_filename): Remove unused variable `is_fat'.
2679 (chase_symlinks): Add parentheses around expression.
2680
1c6f11f4
GM
26812012-08-06 Glenn Morris <rgm@gnu.org>
2682
1db4583a
GM
2683 * sysdep.c: Respect BROKEN_GETWD.
2684
1c6f11f4
GM
2685 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
2686 Let configure handle it.
2687 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
2688
2b90362b
DA
26892012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2690
2691 Use GCALIGNMENT where appropriate.
2692 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
2693 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
2694 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
2695
5f50daf2
EZ
26962012-08-06 Eli Zaretskii <eliz@gnu.org>
2697
14ae4239
BT
2698 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
2699 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 2700
cbcc7007
SM
27012012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
2702
2703 * buffer.h (struct buffer): Revert `indirections' to a simple int;
2704 that should be sufficient for everyone.
2705
4d365fa4
JD
27062012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2707
2708 * keyboard.c (timer_check_2): Add break so timer_check returns next
2709 timeout.
2710
dd86bd82
DA
27112012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2712
2713 Fix Windows build errors introduced after converting to WGET and WSET.
2714 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
2715 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2716
054e1668
JD
27172012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2718
2719 * nsterm.m (ns_frame_rehighlight): Use FSET.
2720
2721 * nsmenu.m (ns_update_menubar): Use FSET.
2722
21238f11
DA
27232012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2724
2725 Separate read and write access to Lisp_Object slots of Lisp_Process.
2726 * process.h (PGET, PSET): New macros similar to AREF and ASET.
2727 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2728
077288cf
DA
27292012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2730
2731 Separate read and write access to Lisp_Object slots of struct window.
2732 * window.h (WGET, WSET): New macros similar to AREF and ASET.
2733 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2734 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2735 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2736 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2737 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2738 Adjust users.
2739
71688bd7
DA
27402012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2741
2742 Fix Windows build errors introduced after converting to FGET and FSET.
2743 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
2744 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
2745 (w32_judge_scroll_bars): Change to use FSET.
2746 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2747
f99bac93
DA
27482012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2749
2750 Fix replacement typo.
2751 * window.c (replace_window): Set root_window instead of
2752 selected_window. This fixes a total window subsystem
2753 malfunction reported by Bastien Guerry <bzg@gnu.org>.
2754
8c2a0f2d
GM
27552012-08-06 Glenn Morris <rgm@gnu.org>
2756
2757 * lisp.mk (lisp): Add language/persian.elc.
2758
edd74c35
DA
27592012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2760
2761 Separate read and write access to Lisp_Object slots of struct frame.
2762 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
2763 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2764 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2765 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2766 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2767
8671676c
AS
27682012-08-05 Andreas Schwab <schwab@linux-m68k.org>
2769
2770 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
2771
663e2b3f
DA
27722012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2773
2774 Generalize common compile-time constants.
2775 * lisp.h (header_size, bool_header_size, word_size): Now here.
2776 (struct Lisp_Vector): Add comment.
2777 (struct Lisp_Bool_Vector): Move up to define handy constants.
2778 (VECSIZE, PSEUDOVECSIZE): Simplify.
2779 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
2780 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
2781 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
2782 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
2783 * xfont.c, xmenu.c: Use word_size where appropriate.
2784
d32e47af
LM
27852012-08-05 Lawrence Mitchell <wence@gmx.li>
2786
2787 * search.c (Freplace_match): Treat \? in the replacement text
2788 literally (Bug#8161).
2789
e5d9c0d1
CY
27902012-08-05 Chong Yidong <cyd@gnu.org>
2791
2792 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
2793 * frame.c (Vdelete_frame_functions):
2794 * emacs.c (Vkill_emacs_hook): Doc fix.
2795
8da0576b
EZ
27962012-08-04 Eli Zaretskii <eliz@gnu.org>
2797
2798 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
2799 --with-x-toolkit=no builds.
2800 Reported by Carsten Mattner <carstenmattner@gmail.com>.
2801
02676e5d
CY
28022012-08-04 Chong Yidong <cyd@gnu.org>
2803
2804 * syntax.c (Fmodify_syntax_entry): Doc fix.
2805
97147da9
EZ
28062012-08-04 Eli Zaretskii <eliz@gnu.org>
2807
76151e2c
EZ
2808 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
2809 * w32.c (init_environment): Change the default values of many
2810 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
2811 them into environment when they were not already defined.
2812 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 2813 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
2814 (check_windows_init_file): Now external, not static.
2815 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
2816 called when Vload_path is already set up.
2817
2818 * w32.h (check_windows_init_file): Add prototype.
2819
2820 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
2821 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
2822 compatibility with Posix platforms.
2823 (main): Move the call to check_windows_init_file to here from
2824 w32.c.
2825 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
2826 any, in the DEFALT argument into the root of the Emacs build or
2827 installation tree, as appropriate.
2828
2829 * callproc.c (init_callproc_1): Call decode_env_path instead of
2830 doing its equivalent by hand.
2831 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
2832 the code that sets Vexec_path run on MS-Windows.
2833
2834 * lread.c (init_lread): Add comments to #ifdef's.
2835
97147da9
EZ
2836 * msdos.c (dos_set_window_size, IT_update_begin)
2837 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
2838 instead of direct references.
2839
185ee146
PE
28402012-08-04 Paul Eggert <eggert@cs.ucla.edu>
2841
2842 Export DEFAULT_REHASH_* to GDB.
2843 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
2844 Now constants, not macros.
2845
8834c57a
PE
28462012-08-03 Paul Eggert <eggert@cs.ucla.edu>
2847
98c6f1e3
PE
2848 Remove unnecessary casts involving pointers.
2849 These casts are no longer needed now that we assume C89 or later,
2850 since they involve casting to or from void *.
2851 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
2852 (make_pure_float, make_pure_vector):
2853 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
2854 * macros.c (Fstart_kbd_macro):
2855 * menu.c (find_and_return_menu_selection):
2856 * minibuf.c (read_minibuf_noninteractive):
2857 * sysdep.c (closedir):
2858 * xdisp.c (x_produce_glyphs):
2859 * xfaces.c (compare_fonts_by_sort_order):
2860 * xfns.c (x_real_positions, select_visual):
2861 * xselect.c (x_stop_queuing_selection_requests)
2862 (x_get_window_property, x_get_window_property_as_lisp_data):
2863 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
2864 Remove unnecessary pointer casts.
2865 * alloc.c (record_xmalloc): New function.
2866 * lisp.h (record_xmalloc): New decl.
2867 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
2868 more like a function. This is because the pointer cast is not
2869 needed. All uses changed.
2870 * print.c (print_string, print_error_message): Avoid length recalc.
2871
8834c57a
PE
2872 Improve fix for macroexp crash with debugging (Bug#12118).
2873 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
2874 ARRAY_MARK_FLAG when checking subscripts, because ASET is
2875 not supposed to be invoked from the garbage collector.
2876 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
2877 (gc_aset): New function, which is like ASET but can be
2878 used in the garbage collector.
2879 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2880 (set_hash_index): Use it instead of ASET.
2881
6dad7178
EZ
28822012-08-03 Eli Zaretskii <eliz@gnu.org>
2883
2884 Support symlinks on latest versions of MS-Windows.
2885 * w32.c: Include winioctl.h and aclapi.h.
2886 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
2887 (revert_to_self): Forward declarations of static functions.
2888 <static BOOL g_b_init_get_security_info>:
2889 <g_b_init_create_symbolic_link>: New static flags.
2890 (globals_of_w32): Initialize them to zero.
2891 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
2892 (map_w32_filename): Improve commentary. Simplify switch.
2893 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
2894 headers (most versions of MinGW w32api don't).
2895 (get_security_info, create_symbolic_link)
2896 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
2897 New functions.
2898 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
2899 in the argument file name.
2900 (sys_access): Call unc_volume_file_attributes only if
2901 GetFileAttributes fails with network-related error codes.
2902 (sys_rename): Diagnose renaming of a symlink when the user doesn't
2903 have the required privileges.
14ae4239 2904 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
2905 get_file_security_desc.
2906 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
2907 with addition of handling of symlinks and support for 'lstat'.
2908 If possible, get file's attributes and security information by
6dad7178
EZ
2909 handle, not by name. Produce S_IFLNK bit for symlinks, when
2910 called from 'lstat'.
2911 (stat, lstat): New functions, call 'stat_worker'.
2912 (symlink, readlink, careadlinkat): Rewritten to create and resolve
2913 symlinks when the underlying filesystem supports them.
2914
f162bcc3
PE
29152012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2916
79ea6c20
PE
2917 Fix macroexp crash on Windows with debugging (Bug#12118).
2918 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
2919 checking subscripts; problem introduced with the recent
2920 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
2921 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
2922 since it's used in non-static inline functions now.
2923
c0ce93fd
PE
2924 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
2925 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 2926
f162bcc3
PE
2927 Use C99-style 'extern inline' if available.
2928 * buffer.h (BUFFER_INLINE):
2929 * category.h (CATEGORY_INLINE):
2930 * character.h (CHARACTER_INLINE):
2931 * charset.h (CHARSET_INLINE):
2932 * composite.h (COMPOSITE_INLINE):
2933 * dispextern.h (DISPEXTERN_INLINE):
2934 * lisp.h (LISP_INLINE):
2935 * systime.h (SYSTIME_INLINE):
2936 New macro, replacing 'static inline' in this header.
2937 * buffer.h, category.h, character.h, charset.h, composite.h:
2938 * dispextern.h, lisp.h, systime.h:
2939 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2940 * alloc.c (LISP_INLINE):
2941 * buffer.c (BUFFER_INLINE):
2942 * category.c (CATEGORY_INLINE):
2943 * character.c (CHARACTER_INLINE):
2944 * charset.c (CHARSET_INLINE):
2945 * composite.c (COMPOSITE_INLINE):
2946 * dispnew.c (DISPEXTERN_INLINE):
2947 * sysdep.c (SYSTIME_INLINE):
2948 Define to EXTERN_INLINE, so that the corresponding functions
2949 are compiled into code.
2950 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
2951 (INLINE_HEADER_END): New macros.
2952 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
2953 since it's used in non-static inline functions now.
a8333d03 2954 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 2955
837b365b
GM
29562012-08-02 Glenn Morris <rgm@gnu.org>
2957
d66b744d
GM
2958 * s/: Remove empty directory.
2959
837b365b
GM
2960 * s/ms-w32.h: Move to ../nt/inc.
2961 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
2962 Update for new ms-w32.h location.
2963
13294f95
PE
29642012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2965
2966 Port to Solaris 8.
2967 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
2968
90df0db3
GM
29692012-08-02 Glenn Morris <rgm@gnu.org>
2970
2971 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
2972 hard-coding the path separator.
2973
4939150c
PE
29742012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
2977 This how ASET and AREF are supposed to work, and makes
2978 it easier to think about future improvements. See
2979 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
2980 * charset.h (set_charset_attr): New function.
2981 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
2982 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
2983 (aref_addr): New function. All uses of &AREF(...) changed.
2984 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2985 (set_hash_index): New functions. All lvalue-style uses of
2986 HASH_KEY etc. changed.
2987 * keyboard.c (set_prop): New function. All lvalue-style uses
2988 of PROP changed.
2989
947b2afd
AA
29902012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
2991
2992 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
2993 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
2994 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
2995 * nsfns.m (ns_set_name_as_filename): Likewise.
2996 * nsmenu.m (ns_update_menubar): Likewise.
2997 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
2998
4f5d0325
EZ
29992012-08-01 Eli Zaretskii <eliz@gnu.org>
3000
2008beae
EZ
3001 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
3002 Adapt to latest changes in field names of the corresponding Lisp
288479f6 3003 objects.
2008beae 3004
4f5d0325
EZ
3005 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
3006
fe3cc771
GM
30072012-08-01 Glenn Morris <rgm@gnu.org>
3008
3009 * s/msdos.h: Remove file.
3010 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
3011 * Makefile.in (S_FILE): Remove.
3012 (config_h): Remove S_FILE.
3013
c90acc54
JB
30142012-08-01 Juanma Barranquero <lekktu@gmail.com>
3015
3016 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
3017 Remove; moved to nt/config.nt.
3018
d8a05828
DA
30192012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3020
3021 Use INTERNAL_FIELD for conses and overlays.
3022 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
3023 Remove obsolete comment.
3024 (MVAR): New macro.
3025 (struct Lisp_Overlay): Use INTERNAL_FIELD.
3026 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
3027
8271d590
DA
30282012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3029
3030 Use INTERNAL_FIELD for symbols.
3031 * lisp.h (SVAR): New macro. Adjust users.
3032 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
3033 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
3034
3193acd2
DA
30352012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3036
3037 Use INTERNAL_FIELD for processes.
3038 * process.h (PVAR): New macro. Adjust style.
3039 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
3040 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
3041
3a45383a
DA
30422012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3043
3044 Use INTERNAL_FIELD for windows.
3045 * window.h (WVAR): New macro.
3046 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
3047 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3048 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3049 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
3050 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
3051 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3052
c1dbc63c
PE
30532012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3054
3055 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
3056
5c0c0e8a
GM
30572012-08-01 Glenn Morris <rgm@gnu.org>
3058
3059 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
3060 Move to configure.ac.
3061
552a99b4
JB
30622012-08-01 Juanma Barranquero <lekktu@gmail.com>
3063
3064 * makefile.w32-in (CONFIG_H): Update dependencies.
3065 (CONF_POST_H): New macro.
3066
3067 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
3068
8d8e2dfe
GM
30692012-07-31 Glenn Morris <rgm@gnu.org>
3070
bc96620a
GM
3071 * Makefile.in (S_FILE): No longer set by configure.
3072
476b1b2d
GM
3073 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
3074 is available.
3075 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
3076
b2c7a106
GM
3077 * process.h (NULL_DEVICE):
3078 * emacs.c (SEPCHAR):
3079 * editfns.c (USER_FULL_NAME): Let configure set them.
3080
d53d062a
GM
3081 * s/README, s/template.h: Remove files.
3082
4515017f
GM
3083 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
3084
8d8e2dfe
GM
3085 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
3086 Move to configure.ac.
3087
5b20b3cc
EZ
30882012-07-31 Eli Zaretskii <eliz@gnu.org>
3089
1e0afd9a
EZ
3090 * .gdbinit (xframe): Adapt to introduction of FVAR and the
3091 resulting renaming of 'struct frame' members.
3092
5b20b3cc
EZ
3093 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
3094
3095 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
3096 after introduction of FVAR.
3097
f1310128
JD
30982012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3099
79e721e0
JD
3100 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
3101
3102 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
3103 instead of compositeToPoint.
3104 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
3105
8d7c7eed 3106 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 3107
e34f7f79
DA
31082012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3109
3110 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
3111 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 3112 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
3113 (BVAR): Change to use INTERNAL_FIELD.
3114 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
3115 (KVAR): Change to use INTERNAL_FIELD.
3116 * frame.h (FVAR): New macro.
3117 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
3118 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
3119 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
3120 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
3121 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3122
c09bfb2f
DA
31232012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3124
3125 Miscellaneous fixes for non-default X toolkits.
3126 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
3127 * xterm.c (x_frame_of_widget): Remove redundant prototype.
3128 Move under #ifdef USE_LUCID.
3129 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
3130 definition and usage to avoid warnings.
3131
14c114ae
JD
31322012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3133
3134 * nsterm.m (openFiles): Fix previous checkin.
3135
3bd21e82
PE
31362012-07-31 Paul Eggert <eggert@cs.ucla.edu>
3137
3138 * indent.c (compute_motion): Remove unused local.
3139
c1529ded
GM
31402012-07-31 Glenn Morris <rgm@gnu.org>
3141
400d5621
GM
3142 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
3143
268e2432
GM
3144 * conf_post.h [USG5_4]:
3145 Move remaining contents of s/usg5-4-common.h here.
3146 * s/usg5-4-common.h: Remove file.
3147
7552f3ee
GM
3148 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
3149 * s/irix6-5.h: Remove file.
3150
6a381852
GM
3151 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
3152 * s/darwin.h: Remove file.
3153
c1529ded
GM
3154 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
3155 * s/hpux10-20.h: Remove file, which is now empty.
3156
b429a4ee
GM
31572012-07-30 Glenn Morris <rgm@gnu.org>
3158
3159 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
3160 * Makefile.in (config_h): Add conf_post.h.
3161 * makefile.w32-in (CONFIG_H): Add conf_post.h.
3162
adff3182
JD
31632012-07-30 Jan Djärv <jan.h.d@swipnet.se>
3164
3165 * nsterm.m (ns_do_open_file): New variable.
b9031d69 3166 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
3167 (openFile, openTempFile, openFileWithoutUI, openFiles):
3168 Open files only if ns_do_open_file.
adff3182 3169
c32af1e4
PE
31702012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3171
7393bcbb
PE
3172 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
3173 This no-op macro hasn't been needed for many years.
3174 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
3175
c32af1e4
PE
3176 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
3177 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
3178 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
3179 gdb_make_enums_visible.
3180 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
3181 (DIRECTORY_SEP): Now a constant, not a macro.
3182
302fc036
EZ
31832012-07-30 Eli Zaretskii <eliz@gnu.org>
3184
3185 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
3186 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
3187
3188 * w32term.c <w32_keyboard_codepage>: Renamed from
3189 keyboard_codepage and now external. All users changed.
3190
3191 * w32term.h: Add declaration of w32_keyboard_codepage.
3192
3193 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
3194 the codepage to translate keys to Unicode. If this argument is
3195 -1, use the value returned by GetConsoleCP. All callers changed.
3196
88fb40b4
PE
31972012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3198
0aee6912
PE
3199 Update .PHONY listings in makefiles.
3200 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
3201 bootstrap-clean, distclean, maintainer-clean, versioclean,
3202 extraclean, frc.
3203
88fb40b4
PE
3204 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
3205 This is a bit clearer. Fix some commentary typos.
3206
0a763bd1
GM
32072012-07-30 Glenn Morris <rgm@gnu.org>
3208
32bac6d6
GM
3209 * s/netbsd.h: Let configure include signal.h if needed.
3210 Remove file, which is now empty.
3211
b65e7c46
GM
3212 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
3213 Let configure set them.
3214 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
3215 No more need to undefine.
0a763bd1 3216
169304bd
AS
32172012-07-30 Andreas Schwab <schwab@linux-m68k.org>
3218
3219 * keymap.c (Fkey_description): Don't remove 0x80 bit from
3220 non-single-byte char when adding meta modifier. (Bug#12090)
3221
6cd7a139
DA
32222012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3223
3224 Convert safe_call to use variable number of arguments.
3225 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
3226 (safe_call2): Fix comment.
3227 * lisp.h (safe_call): Adjust prototype.
3228 * coding.c (encode_coding_object): Change to use safe_call2.
3229 * xfaces.c (merge_face_heights): Change to use safe_call1.
3230
d34d6ffc
GM
32312012-07-30 Glenn Morris <rgm@gnu.org>
3232
7b8a48e4 3233 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 3234 does that unconditionally. Remove file, which is now empty.
7b8a48e4 3235
d34d6ffc
GM
3236 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
3237 Remove empty files.
3238
03a660a6
PE
32392012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3240
3241 Export to GDB most of lisp.h's remaining object-like macros.
3242 * lisp.h (min, max): Move earlier, because they're used earlier now.
3243 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
3244 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
3245 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
3246 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
3247 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
3248 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
3249 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
3250 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
3251 Now constants, for GDB. They need not be macros.
3252 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
3253 Now constants, for GDB, as well as macros, for static initializers.
3254 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
3255 Move to after the definition of struct Lisp_Char_Table,
3256 since the former now needs that type defined.
3257 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
3258 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
3259 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
3260 New enums, for gdb_make_enums_visible.
3261 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 3262 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
3263 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
3264 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
3265 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
3266 enum maxargs, enum MAX_ALLOCA.
3267 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
3268 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
3269 no longer needed, now that they are done in lisp.h.
3270
e499d0ee
DA
32712012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3272
3273 Cleanup string bytes checking.
3274 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
3275 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
3276 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
3277 (check_sblock, compact_small_strings): Simplify.
3278
d5040d2d
PE
32792012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3280
3281 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
3282 These macros are confusing and no longer need to be defined, as
3283 the enum values now suffice. All uses replaced with definiens.
3284 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
3285
7f259ae6
JB
32862012-07-29 Juanma Barranquero <lekktu@gmail.com>
3287
3288 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
3289 ($(BLD)/w32console.$(O)): Update dependencies.
3290
7e63e0c3
DA
32912012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3292
3293 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
3294 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
3295 time. Adjust users.
3296 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
3297
ffd817eb
JD
32982012-07-29 Jan Djärv <jan.h.d@swipnet.se>
3299
3300 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
3301 setting sitelisp (Bug#12010).
3302
417a7a0e
EZ
33032012-07-29 Eli Zaretskii <eliz@gnu.org>
3304
14ae4239 3305 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
3306
3307 * w32heap.c (cache_system_info):
3308 * w32.c (sys_rename):
3309 * w32proc.c (find_child_console, sys_kill): All users changed.
3310
387d4d92
PE
33112012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3312
3313 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
3314
55a6cca6
EZ
33152012-07-29 Eli Zaretskii <eliz@gnu.org>
3316
3317 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
3318
dbcf001c
DA
33192012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3320
3321 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
3322 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
3323 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 3324
e2688e4a
DA
33252012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3326
3327 Generalize marker debugging code under MARKER_DEBUG and use eassert.
3328 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
3329 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
3330 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
3331 (replace_range, replace_range_2, del_range_2): Change to eassert.
3332 * marker.c (byte_char_debug_check): Adjust style.
3333
b46a6a83
PE
33342012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3335
3336 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
3337 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
3338 long-ago-commented-out code that talks about "WIN32".
3339 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
3340 All uses changed.
3341
e32a5799
PE
33422012-07-28 Paul Eggert <eggert@cs.ucla.edu>
3343
3344 Use Gnulib stdalign module (Bug#9772, Bug#9960).
3345 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
3346 Simplify by using alignof.
3347 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
3348 * lisp.h: Include <stdalign.h>.
3349 (GCALIGNMENT): New macro and constant.
3350 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
3351 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
3352 (stdalign): New macro, if not already defined.
3353
df81cd29
EZ
33542012-07-28 Eli Zaretskii <eliz@gnu.org>
3355
01bd1b0d
EZ
3356 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
3357 * w32inevt.c: Include w32inevt.h.
3358 (w32_read_console_input): New inline function, calls either
3359 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
3360 w32_console_unicode_input.
3361 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
3362 (w32_kbd_patch_key, key_event): Use the codepage returned by
3363 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
3364 (key_event): use uChar.UnicodeChar only if
3365 w32_console_unicode_input is non-zero.
3366
3367 * w32console.c: Include w32heap.h.
3368 <w32_console_unicode_input>: New global variable.
3369 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
3370 family of Windows, zero otherwise.
3371
3372 * w32inevt.h: Declare w32_console_unicode_input.
3373
df81cd29
EZ
3374 * xdisp.c (init_iterator): Don't reference tip_frame in a build
3375 --without-x. (Bug#11742)
3376
c20fdd9e
PE
33772012-07-27 Paul Eggert <eggert@cs.ucla.edu>
3378
3379 Adjust GDB to reflect pvec_type changes (Bug#12036).
3380 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
3381 2012-07-04 changes to pseudovector representation.
3382 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 3383
32770973 33842012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
3385
3386 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
3387 bus address.
3388 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
3389
3438fe21
EZ
33902012-07-27 Eli Zaretskii <eliz@gnu.org>
3391
bcfbc9de
EZ
3392 * alloc.c (listn): Fix the order the arguments are consed onto the
3393 list.
3394
3438fe21
EZ
3395 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
3396 enumeration constants, as PURE and HEAP are too general, and clash
3397 with other headers and sources, such as gmalloc.c and the
3398 MS-Windows system headers. All users changed.
3399
eeaea515
DA
34002012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3401
3402 Revert last save_excursion_save and save_excursion_restore changes.
3403 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
3404 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
3405
073c88c2
DA
34062012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3407
3408 Fix recently-introduced typos in Windows port.
3409 Reported by Martin Rudalics <rudalics@gmx.at>.
3410 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 3411 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 3412
4706125e
PE
34132012-07-27 Paul Eggert <eggert@cs.ucla.edu>
3414
3415 Improve GDB symbol export (Bug#12036).
3416 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
3417 arms of an 'if', not using conditional expressions; otherwise GDB
3418 complains about the types in the unevaluated arm when the argument
3419 is an integer literal.
3420 (xgetint): Simplify expression.
3421 * alloc.c (gdb_make_enums_visible): New constant. This ports to
3422 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
3423 Zaretskii in <http://bugs.gnu.org/12036#13>.
3424 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
3425 needed now that we have gdb_make_enums_visible.
3426 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
3427 (enum enum_USE_LSB_TAG):
3428 New enum types, packaging up enums that need to be exported to GDB.
3429
694b6c97
DA
34302012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3431
3432 Utility function to make a list from specified amount of objects.
3433 * lisp.h (enum constype): New datatype.
3434 (listn): New prototype.
3435 * alloc.c (listn): New function.
3436 (Fmemory_use_count, syms_of_alloc): Use it.
3437 * buffer.c (syms_of_buffer): Likewise.
3438 * callint.c (syms_of_callint): Likewise.
3439 * charset.c (define_charset_internal): Likewise.
3440 * coding.c (syms_of_coding): Likewise.
3441 * keymap.c (syms_of_keymap): Likewise.
3442 * search.c (syms_of_search): Likewise.
3443 * syntax.c (syms_of_syntax): Likewise.
3444 * w32.c (init_environment): Likewise.
3445 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
3446 * xdisp.c (syms_of_xdisp): Likewise.
3447 * xfns.c (syms_of_xfns): Likewise.
3448
6195f384
DA
34492012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3450
3451 Fast save_excursion_save and save_excursion_restore.
3452 * lisp.h (struct Lisp_Excursion): New data type.
3453 (PVEC_EXCURSION): New pseudovector type.
3454 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
3455 to deal with it. Adjust comments.
3456 (init_marker, attach_marker): New prototype.
3457 (unchain_marker): Adjust prototype.
3458 * marker.c (attach_marker): Change to global.
3459 (init_marker): New function.
3460 * alloc.c (Fmake_marker, build_marker): Use it.
3461 (build_marker): More easserts.
3462 (mark_object): Handle struct Lisp_Excursion.
3463 * editfns.c (save_excursion_save, save_excursion_restore):
3464 Reimplement to use struct Lisp_Excursion. Add comments.
3465
5eceb8fb
PE
34662012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3467
3468 Fix export of symbols to GDB (Bug#12036).
3469 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
3470 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
3471 emacs.c, as this is a more-suitable home. Had this been done earlier
3472 the fix for 12036 would have avoided some of the problems noted in
3473 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
3474 would have been more obvious.
562157c8
PE
3475 * emacs.c: Do not include <verify.h>; no longer needed.
3476 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
3477 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
3478 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3479 Remove; now done in lisp.h.
3480 * lisp.h (PUBLISH_TO_GDB): New macro.
3481 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
3482 (DATA_SEG_BITS): Use it.
3483 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
3484 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
3485 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
3486 not be usable in #if. This simplifies things.
3487
d6749401
JB
34882012-07-26 Juanma Barranquero <lekktu@gmail.com>
3489
3490 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
3491
1781b9e9
PE
34922012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3493
d89518db 3494 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
3495 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
3496 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
3497 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
3498 Adjust to changes in lisp.h and emacs.c, by using
3499 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
3500 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
3501 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
3502 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
3503 instead of gdb_valbits.
3504 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
3505 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
3506 instead of gdb_array_mark_flag.
3507 (xboolvector): Get size from $->size, not $->header.size.
3508 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
3509 (xreload, hook-run, hookpost-run): Remove.
3510 * emacs.c: Include <verify.h>.
3511 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
3512 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
3513 Remove.
3514 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
3515 (gdb_USE_LSB_TAG): New enum constants.
3516 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3517 Also define these as enum constants, so they're visible to GDB.
3518 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
3519 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
3520 as constants, so they're visible to GDB.
3521 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
3522 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
3523 Now enum constants, not macros, so they're visible to GDB.
3524 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
3525 more convenient now. All uses changed.
3526 (VALMASK) [USE_LSB_TAG]: Also define in this case.
3527 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
3528
3628596a
DA
35292012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
3530
3531 Explicitly free restriction data that are not needed anymore.
3532 * editfns.c (save_restriction_restore): Free restriction data.
3533
7abaf5cc
SM
35342012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
3535
3536 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
3537 add argument, tune behavior, and adjust all callers.
3538
71f88e00
PE
35392012-07-25 Paul Eggert <eggert@cs.ucla.edu>
3540
3541 Use typedef for EMACS_INT, EMACS_UINT.
3542 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
3543 than macros. This simplifies debugging in the usual case, since
3544 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
3545 and it allows expressions involving EMACS_INT casts.
3546 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
3547
57ec3034
JD
35482012-07-25 Jan Djärv <jan.h.d@swipnet.se>
3549
3550 * nsterm.m (ns_read_socket): Return early if there is a modal
3551 window (Bug#12043).
3552
8137e7b3
MR
35532012-07-25 Martin Rudalics <rudalics@gmx.at>
3554
3555 * frame.c (Fredirect_frame_focus): In doc-string don't mention
3556 that FOCUS-FRAME can be omitted.
3557
04e9897c
DA
35582012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
3559
3560 Adjust buffer text indirection counters at the end of Fkill_buffer.
3561 * buffer.c (Fkill_buffer): Adjust indirection counters when the
3562 buffer is definitely dead. This should really fix an issue reported
3563 by Christoph Scholtes again. (Bug#12007).
3564 (init_buffer_once): Initialize indirection counters of
3565 buffer_defaults and buffer_local_symbols (for sanity and safety).
3566
8a0484e1
EZ
35672012-07-24 Eli Zaretskii <eliz@gnu.org>
3568
3569 * xdisp.c (init_iterator): Don't compute dimensions of truncation
3570 and continuation glyphs on tooltip frames, leave them at zero.
3571 Avoids continued lines in tooltips. (Bug#11832)
3572
fa691a83
DA
35732012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
3574
3575 Simplify copy_overlay.
04e9897c 3576 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
3577 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
3578
436bc8e0
EZ
35792012-07-23 Eli Zaretskii <eliz@gnu.org>
3580
3581 * print.c (print_object): Don't crash when a frame's name is nil
3582 or invalid. (Bug#12025)
3583
3584 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
3585 it signals an error when a tooltip frame is being created.
3586
d7a7fda3
DA
35872012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
3588
3589 Cleanup miscellaneous objects allocation and initialization.
3590 * alloc.c (allocate_misc): Change to static. Add argument to
3591 specify the subtype. Adjust comment and users.
3592 (build_overlay): New function.
3593 * buffer.c (copy_overlays, Fmake_overlay): Use it.
3594 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
3595 (allocate_misc): Remove prototype.
3596 (build_overlay): Add prototype.
3597
35982012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
3599
3600 Swap buffer text indirection counters in Fbuffer_swap_text.
3601 * buffer.c (Fbuffer_swap_text): Swap indirections too.
3602 This avoids crash reported by Christoph Scholtes at
3603 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
3604
9d7fa573
JD
36052012-07-22 Jan Djärv <jan.h.d@swipnet.se>
3606
3607 * nsmenu.m (Popdown_data): New struct.
3608 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
3609 free Popdown_data.
3610 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
3611 (initWithContentRect): Make imgView and contentView non-static
3612 and autorelease them. Also autorelease img and matrix (Bug#12005).
3613 (dealloc): Remove (Bug#12005).
3614
0dd6d66d
DA
36152012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3616
3617 Adjust consing_since_gc when objects are explicitly freed.
3618 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
3619 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
3620 (free_cons, free_misc): Subtract object size from consing_since_gc.
3621
d36d71df
DA
36222012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3623
3624 Simplify and cleanup markers positioning code.
3625 * marker.c (attach_marker): More useful eassert.
3626 (live_buffer, set_marker_internal): New function.
3627 (Fset_marker, set_marker_restricted): Use set_marker_internal.
3628 (set_marker_both, set_marker_restricted_both): Use live_buffer.
3629
fb9ea40f
PE
36302012-07-22 Paul Eggert <eggert@cs.ucla.edu>
3631
3632 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
3633 as it's limited by the amount of memory, not by INT_MAX.
3634
2d5c5f7d
EZ
36352012-07-21 Eli Zaretskii <eliz@gnu.org>
3636
07fb592e
EZ
3637 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
3638 in special-event-map. See the discussion at
3639 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
3640 for the reasons.
3641
37a9eac8 3642 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
3643 info.dwItemData. Fixes crashes on 64-bit Windows.
3644 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 3645
c4328746
JD
36462012-07-21 Jan Djärv <jan.h.d@swipnet.se>
3647
fc0c31f8 3648 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 3649 (conversationIdentifier): Return value is NSInteger.
784051c4 3650 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 3651
6e5d1c12
CY
36522012-07-21 Chong Yidong <cyd@gnu.org>
3653
3654 * window.c (decode_any_window): Signal an error if the window is
3655 on a dead frame (Bug#11984).
3656
9928463d
DA
36572012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3658
3659 Add indirection counting to speed up Fkill_buffer.
3660 * buffer.h (struct buffer): New member.
3661 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
3662 (Fmake_indirect_buffer): Set indirection counter to -1, increment
3663 base buffer indirection counter.
3664 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
3665 (Fkill_buffer): Adjust indirection counters as needed, don't walk
3666 through buffer list if indirection counter is 0.
3667
f8643a6b
DA
36682012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3669
3670 Extend the value returned by Fgarbage_collect with heap statistics.
3671 * alloc.c (Qheap): New symbol.
3672 (syms_of_alloc): DEFSYM it.
3673 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
3674 (Fmemory_free): Remove.
3675 (syms_of_alloc): Don't defsubr it.
3676 * buffer.c (Fcompact_buffer): Remove.
3677 (syms_of_buffer): Don't defsubr it.
3678
dac616ff
DA
36792012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3680
3681 Make maybe_gc inline.
3682 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
3683 * lisp.h (consing_since_gc, gc_relative_threshold)
3684 (memory_full_cons_threshold): Revert declaration.
3685 (maybe_gc): Remove prototype, define as inline.
3686 * alloc.c: Remove old commented-out code.
3687 (consing_since_gc, gc_relative_threshold)
3688 (memory_full_cons_threshold): Revert to global.
3689 (maybe_gc): Remove.
3690
d7ea76b4
DA
36912012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3692
3693 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
3694 * lisp.h (build_unibyte_string): New function.
3695 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
3696 * sysdep.c, w32fns.c, xfns.c: Use it.
3697 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
3698 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
3699 Adjust users accordingly.
3700 * font.h (font_open_by_name): Adjust prototype.
3701
765e61e3
DA
37022012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3703
3704 Cleanup calls to Fgarbage_collect.
3705 * lisp.h (maybe_gc): New prototype.
3706 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3707 Remove declarations.
3708 * alloc.c (maybe_gc): New function.
3709 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3710 Make them static.
3711 * bytecode.c (MAYBE_GC): Use maybe_gc.
3712 * eval.c (eval_sub, Ffuncall): Likewise.
3713 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
3714 to avoid dependency from auto-save feature.
3715
52b852c7
PE
37162012-07-19 Paul Eggert <eggert@cs.ucla.edu>
3717
3718 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
3719 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
3720 'for_each_per_buffer_object_at'.
3721 All uses changed. It's better to use upper-case for macros that
3722 cannot be implemented as functions, to give the reader a clue
3723 that they're special.
3724
5db81e33
SM
37252012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
3726
3727 * alloc.c (Fgarbage_collect): Tweak docstring.
3728
5b835e1d
DA
37292012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3730
3731 Tweak the value returned from Fgarbage_collect again.
3732 * alloc.c (Fgarbage_collect): New return value, as confirmed in
3733 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
3734 Adjust documentation.
3735 (total_vector_bytes): Rename to total_vector_slots, adjust
3736 accounting.
3737 (total_free_vector_bytes): Rename to total_free_vector_slots,
3738 adjust accounting.
3739 (Qstring_bytes, Qvector_slots): New symbols.
3740 (syms_of_alloc): DEFSYM them.
3741
9cd47b72
DA
37422012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3743
3744 Buffer compaction primitive which may be used from Lisp.
3745 * buffer.c (compact_buffer, Fcompact_buffer): New function.
3746 (syms_of_buffer): Register Fcompact_buffer.
3747 * alloc.c (Fgarbage_collect): Use compact_buffer.
3748 * buffer.h (compact_buffer): New prototype.
3749 (struct buffer_text): New member.
3750
d17337e5
DA
37512012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3752
3753 New macro to iterate over all buffers, miscellaneous cleanups.
3754 * lisp.h (all_buffers): Remove declaration.
3755 * buffer.h (all_buffers): Add declaration, with comment.
3756 (for_each_buffer): New macro.
3757 * alloc.c (Fgarbage_collect, mark_object): Use it.
3758 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
3759 (init_buffer): Likewise.
3760 * data.c (Fset_default): Likewise.
3761 * coding.c (code_conversion_restore): Remove redundant check
3762 for dead buffer.
3763 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
3764
60cfd278
AS
37652012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3766
3767 Fix bug that created negative-length intervals.
3768 * intervals.c (merge_interval_right, merge_interval_left):
3769 Do not zero out this interval if it is absorbed by its children,
3770 as this interval's total length doesn't change in that case. See
3771 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
3772
d06714cb
PE
37732012-07-18 Paul Eggert <eggert@cs.ucla.edu>
3774
83713154
PE
3775 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
3776 when invoking (make-bool-vector N t) and N is a positive
3777 multiple of 8 -- the last 8 bits were mistakenly cleared.
3778
d06714cb
PE
3779 Remove some struct layout assumptions in bool vectors.
3780 * alloc.c (bool_header_size): New constant.
3781 (header_size, word_size): Move earlier, as they're now used earlier.
3782 Use 'word_size' in a few more places, where it's appropriate.
3783 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
3784 padding before the data member of a bool vector.
3785 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
3786 than doing the check by hand with an abort ().
3787
464d5a5e
SM
37882012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3789
5fbc0409
SM
3790 * eval.c (Fdefvar): Don't check constants since we only set the var if
3791 it's not yet defined anyway (bug#11904).
3792
464d5a5e
SM
3793 * lisp.h (last_undo_boundary): Declare new var.
3794 * keyboard.c (command_loop_1): Set it.
3795 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
3796 were auto-added by the command loop (bug#11774).
3797
8dc2e44a
AS
37982012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3799
3800 * w32font.c (Qsymbol): Remove local definition.
3801 (syms_of_w32font): Don't DEFSYM it.
3802
169925ec
DA
38032012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3804
3805 Fix sweep_vectors to handle large bool vectors correctly.
3806 * alloc.c (sweep_vectors): Account total_vector_bytes for
3807 bool vectors larger than VBLOCK_BYTES_MAX.
3808
5fbfb018
CY
38092012-07-18 Chong Yidong <cyd@gnu.org>
3810
3811 * frame.c (x_set_frame_parameters): Revert bogus change introduced
3812 in 2012-05-25 commit by Paul Eggert (Bug#11738).
3813
3ab6e069
DA
38142012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3815
3816 Return more descriptive data from Fgarbage_collect.
3817 Suggested by Stefan Monnier in
3818 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
3819 * alloc.c (bounded_number): New function.
3820 (total_buffers, total_vectors): New variable.
3821 (total_string_size): Rename to total_string_bytes, adjust users.
3822 (total_vector_size): Rename to total_vector_bytes, adjust users.
3823 (sweep_vectors): Account total_vectors and total_vector_bytes.
3824 (Fgarbage_collect): New return value. Adjust documentation.
3825 (gc_sweep): Account total_buffers.
3826 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
3827 (VECTOR_SIZE): Remove.
3828 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
3829 (Qinterval, Qmisc): New symbols.
3830 (syms_of_data): Initialize them.
3831 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
3832 (Qcons, Qbuffer): New declarations.
3833
6d02fe5b
PE
38342012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3835
3836 * alloc.c (Fmemory_free): Account for memory-free's own storage.
3837 Round up, not down. Improve doc.
3838
b7ffe040
DA
38392012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3840
3841 Restore old code in allocate_string_data to avoid Faset breakage.
3842 Reported by Julien Danjou <julien@danjou.info> in
3843 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
3844 * alloc.c (allocate_string_data): Restore old code with minor
3845 adjustments, fix comment to explain this subtle issue.
3846
4dc7c8d5
SM
38472012-07-17 Eli Zaretskii <eliz@gnu.org>
3848
3849 Remove FILE_SYSTEM_CASE.
3850 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
3851
3852 * fileio.c (FILE_SYSTEM_CASE): Don't define.
3853 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
3854 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
3855 call-process-region passes it through expand-file-name.
3856
3857 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
3858
38592012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3860
3861 Fix crash when creating indirect buffer (Bug#11917)
3862 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
3863 Don't handle unbound variables specially if non-zero.
3864 (Fbuffer_local_variables): Pass zero.
3865 (clone_per_buffer_values): Pass non-zero.
3866
38672012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3868
3869 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
3870 to make the loop interruptible.
3871
38722012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3873
3874 * gnutls.c (emacs_gnutls_handshake): Only retry if
3875 GNUTLS_E_INTERRUPTED.
3876
cce7fefc
DA
38772012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3878
3879 Cleanup and convert miscellaneous checks to eassert.
3880 * alloc.c (mark_interval): Fix comment, partially rephrase
3881 old comment from intervals.h (see below).
3882 * intervals.c (find_interval, adjust_intervals_for_insertion)
3883 (delete_interval, adjust_intervals_for_deletion)
3884 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
3885 Convert to eassert.
3886 (adjust_intervals_for_insertion, make_new_interval):
3887 Remove obsolete and unused code.
3888 * intervals.h (struct interval): Remove obsolete comment.
3889 * textprotp.c (erase_properties): Remove unused code.
3890 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
3891 (Fremove_list_of_text_properties): Convert to eassert.
3892
9ea10cc3
CY
38932012-07-17 Chong Yidong <cyd@gnu.org>
3894
3895 * editfns.c (Finsert_char): Doc fix.
3896
3900d5de
DA
38972012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3898
3899 Fix previous change to make Fmemory_free always accurate.
3900 * alloc.c (make_interval): Update total_free_intervals.
3901 (make_float): Likewise for total_free_floats.
3902 (free_cons, Fcons): Likewise for total_free_conses.
3903 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
3904 Likewise for total_free_vector_bytes.
3905 (Fmake_symbol): Likewise for total_free_symbols.
3906 (bytes_free): Remove.
3907
7098646f
DA
39082012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3909
3910 Simple free memory accounting feature.
3911 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
3912 (sweep_vectors): Accumulate size of free vectors.
3913 (Fgarbage_collect): Setup bytes_free.
3914 (Fmemory_free): New function.
3915 (syms_of_alloc): Register it.
3916
22657b40
DA
39172012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3918
3919 Cleanup overlays checking.
3920 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
3921 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
3922 eassert and OVERLAYP.
3923 (sort_overlays): Change to use OVERLAYP.
3924
ddfc8813
RK
39252012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
3926
3927 * editfns.c (Finsert_char): Make it interactive, and make the
3928 second arg optional. Copy interactive spec and docstring from
3929 ucs-insert.
3930
7c26cf3c
PE
39312012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3932
3933 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
3934 Unlike the other wrapped functions, fabs has an unspecified
3935 effect on errno.
3936
5d127af9
JD
39372012-07-16 Jan Djärv <jan.h.d@swipnet.se>
3938
3939 * nsterm.m (keyDown): Interpret flags without left/right bits
3940 as the left key (Bug#11670).
3941
6a0dd1d7
DA
39422012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3943
3944 Remove empty and useless init functions.
3945 * lisp.h (init_character_once, init_fns, init_image)
3946 (init_filelock, init_sound): Remove prototype.
3947 * character.c (init_character_once): Remove.
3948 * filelock.c (init_filelock): Likewise.
3949 * fns.c (init_fns): Likewise.
3950 * image.c (init_image): Likewise.
3951 * sound.c (init_sound): Likewise.
3952 * emacs.c (main): Adjust accordingly.
3953
7a6136fd
DA
39542012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3955
3956 * gtkutil.h: Tiny cleanups.
3957 (use_old_gtk_file_dialog): Remove useless declaration.
3958 (xg_uses_old_file_dialog): Add suggested const attribute.
3959
ce811ad9
EZ
39602012-07-15 Eli Zaretskii <eliz@gnu.org>
3961
3962 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
3963 (bidi_paragraph_init): Use it to limit search forward for a strong
3964 directional character in abnormally large paragraphs full of
3965 neutral or weak characters. (Bug#11943)
3966
c9adfeaa
SF
39672012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
3968
3969 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
3970 the toolbar (Bug#9451).
3971 (xg_make_tool_item): Give the widget event box a transparent
3972 background.
3973
fff62aa9
DA
39742012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3975
3976 Cleanup basic allocation variables and functions.
3977 * alloc.c (ignore_warnings, init_intervals, init_float)
3978 (init_cons, init_symbol, init_marker): Remove.
3979 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
3980 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
3981 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
3982 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
3983 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
3984 (staticidx, init_alloc_once, init_strings, free_ablock):
3985 Remove redundant initialization.
3986 * fns.c (init_weak_hash_tables): Remove.
3987 * lisp.h (init_weak_hash_tables): Remove prototype.
3988
9730daca
DA
39892012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3990
3991 Use zero_vector where appropriate.
3992 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
3993 accordingly.
3994 * lisp.h (zero_vector): New declaration.
3995 * font.c (null_vector): Remove.
3996 (syms_of_font): Remove initialization and staticpro.
3997 (font_list_entities, font_find_for_lface): Change to use zero_vector.
3998 * keymap.c (Faccessible_keymaps): Likewise.
3999
2e2d2a13
LL
40002012-07-15 Leo Liu <sdl.web@gmail.com>
4001
4002 * fringe.c: Fix typo in comments.
4003
cd276f6e
LL
40042012-07-14 Leo Liu <sdl.web@gmail.com>
4005
4006 * fringe.c: Add a new bitmap exclamation-mark.
4007
5a1131d9
EZ
40082012-07-14 Eli Zaretskii <eliz@gnu.org>
4009
4010 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
4011
4012 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
4013 (HAVE_MENUS): Don't define, defined by editing config.in with
4014 msdos/sed2v2.inp.
4015 (GMALLOC_INHIBIT_VALLOC): Don't define.
4016 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
4017
22e983b7
JB
40182012-07-14 Juanma Barranquero <lekktu@gmail.com>
4019
4020 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
4021
5b3f250f
GM
40222012-07-14 Glenn Morris <rgm@gnu.org>
4023
4024 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
4025 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
4026 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
4027
33d63ff4
GM
40282012-07-13 Glenn Morris <rgm@gnu.org>
4029
5b633342
GM
4030 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
4031
33d63ff4
GM
4032 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
4033 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
4034
b55b9f85
JD
40352012-07-13 Jan Djärv <jan.h.d@swipnet.se>
4036
0dc8cf50
JD
4037 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
4038 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
4039 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
4040 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
4041 where appropriate.
4042 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
4043 as boolean expression.
4044 (x_set_window_size): Remove unused variable toolbar.
4045 (ns_get_color_default, ns_mod_to_lisp): Remove.
4046 (ns_mouse_position): Remove unused variables xchar and ychar.
4047 (ns_compute_glyph_string_overhangs): Remove unused variable face.
4048 (ns_set_vertical_scroll_bar): Remove unused variable count.
4049 (ns_delete_terminal): Remove unused variable i.
4050 (ns_term_init): Remove unused variables r, g and b.
4051 (mouseDown): Remove unused variable window.
4052 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
4053 (initFrameFromEmacs): Remove unused variable vbextra.
4054 (mouseEntered): Remove unused variables p and dpyinfo.
4055 (mouseExited): Remove unused variables p and r.
4056 (ns_define_frame_cursor, ns_clear_frame_area)
4057 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
4058 (menuDown): Assign [sender tag] to variable and cast the variable.
4059
4060 * nsterm.h (menuDown): Add id as type to argument sender.
4061 (ns_display_info_for_name): Add Lisp_Object argument.
4062 (ns_term_init): Add Lisp_Object argument.
4063 (ns_map_event_to_object): Add void argument.
4064 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
4065 prototype with arguments and only declare if __OBJC__.
4066 (nxatoms_of_nsselect): Add void argument.
4067 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
4068 (ns_alloc_autorelease_pool): Add void argument.
4069 (ns_release_autorelease_pool): Add void* argument.
4070 (ns_get_defaults_value): Add const char* argument.
4071
4072 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
4073 (initFromContents): Use SSDATA where appropriate.
4074 (ns_update_menubar): Add braces to ambigous if-else.
4075 (initWithTitle): Put () around assignment in if statement.
4076 (ns_menu_show): Remove unused variables window and keymap.
4077 (update_frame_tool_bar): Remove unused variable selected_p.
4078 (initWithContentRect): Remove unused variable this_cmd_name.
4079
4080 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
4081 appropriate.
4082 (setXBMColor): Remove unused variable len.
4083 (setPixmapData): Put () around assignment in loop statement.
4084
4085 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
4086 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
4087 where appropriate.
4088 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
4089 around assignment in loop statement.
4090 (nsfont_open): Remove unused variable i.
4091 (nsfont_open): Remove unused variable len.
4092 (nsfont_draw): Remove unused variable cs.
4093
4094 * nsfns.m (x_set_icon_name, ns_set_name_internal)
4095 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
4096 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
4097 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
4098 (Fns_font_name, Fns_perform_service)
4099 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
4100 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
4101 (ns_set_name): Remove unused variable view.
4102 (x_set_menu_bar_lines): Remove unused variable olines.
4103 (x_set_tool_bar_lines): Remove unused variable root_window.
4104 (Fns_list_colors): Put () around assignment in while statement.
4105 (Fns_perform_service): Remove unused variable len.
4106 (Fns_display_usable_bounds): Remove unused variable top.
4107 (syms_of_nsfns): Remove unused variable i.
4108
b55b9f85
JD
4109 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
4110 memcpy (Bug#11907).
4111
ed9265fc 41122012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
4113
4114 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
4115 and free it with DestroyExceptionInfo (Bug#11558).
4116
ef099b57
JB
41172012-07-13 Juanma Barranquero <lekktu@gmail.com>
4118
4119 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
4120 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
4121 Set here, not in nt/config.nt.
4122
ea814a5d
EZ
41232012-07-13 Eli Zaretskii <eliz@gnu.org>
4124
4125 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
4126 cursor overflow into the last glyph on display line when the right
4127 fringe is off. (Bug#11832)
4128
1a952767
PE
41292012-07-13 Paul Eggert <eggert@cs.ucla.edu>
4130
4131 * xdisp.c (produce_special_glyphs): Now static.
4132 * dispextern.h (produce_special_glyphs): Remove decl.
4133
983188fd
GM
41342012-07-13 Glenn Morris <rgm@gnu.org>
4135
8d7c7eed 4136 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
4137 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
4138
983188fd
GM
4139 * s/usg5-4-common.h (USG, USG5):
4140 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
4141 * s/sol2-6.h (SOLARIS2):
4142 * s/irix6-5.h (IRIX6_5):
4143 * s/hpux10-20.h (USG, USG5, HPUX):
4144 * s/gnu-linux.h (USG, GNU_LINUX):
4145 * s/freebsd.h (BSD_SYSTEM):
4146 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
4147 * s/cygwin.h (CYGWIN):
4148 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
4149 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
4150
d1e68667 41512012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
4152
4153 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 4154
6de0e799
GM
41552012-07-13 Glenn Morris <rgm@gnu.org>
4156
739ae010
GM
4157 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
4158
dbee5793
GM
4159 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
4160
6de0e799
GM
4161 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
4162 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
4163
b82da769
GM
41642012-07-12 Glenn Morris <rgm@gnu.org>
4165
4fae5a7a 4166 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
4167
4168 * process.c (init_process_emacs): Rename from init_process.
4169 The old name is also the name of a Mach system call.
4170 * lisp.h, emacs.c: Update for this name change.
4171 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
4172 longer needed.
4173
5a979817
EZ
41742012-07-12 Eli Zaretskii <eliz@gnu.org>
4175
4176 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
4177 memmove call that removes glyphs covered by the left truncation
4178 glyph. Improve commentary.
4179 (display_line): Fix display of continuation glyphs on GUI frames
4180 when the right fringe is turned off and variable-size fonts are
4181 used in the window. Move the code that appends a stretch glyph to
4182 produce_special_glyphs, so that it could be used for truncation
4183 and continuation glyphs alike.
4184 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
4185 glyph of a suitably computed width, to align the special glyphs at
4186 the window margin. Code moved from display_line. (Bug#11832)
4187
3e91a053
GM
41882012-07-12 Glenn Morris <rgm@gnu.org>
4189
ba9e4b84
GM
4190 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
4191
4192 * s/gnu-linux.h, s/hpux10-20.h:
4193 Do not unconditionally define HAVE_XRMSETDATABASE.
4194
3e91a053
GM
4195 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
4196
b300b1f4
PE
41972012-07-12 Paul Eggert <eggert@cs.ucla.edu>
4198
4199 Fix typos that broke OS X build.
4200 Reported by Randal L. Schwartz in
4201 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
4202 * nsterm.m (ns_timeout): Add missing local decl.
4203 (ns_get_color): snprintf -> sprintf, to fix typo.
4204
6e777848
GM
42052012-07-12 Glenn Morris <rgm@gnu.org>
4206
3f922c37
GM
4207 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
4208 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
4209 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
4210 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
4211
0ab7b23a
GM
4212 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
4213 Move PTY_OPEN to configure.
4214
6e777848
GM
4215 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4216 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
4217 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
4218
4a7edc24
DA
42192012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
4220
4221 Use empty_unibyte_string where applicable.
4222 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
4223 * lread.c (read1): Likewise.
4224 * xsettings.c (syms_of_xsettings): Likewise.
4225
308aab79
GM
42262012-07-12 Glenn Morris <rgm@gnu.org>
4227
42bd1719
GM
4228 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
4229 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
4230 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
4231 * s/hpux10-20.h (RUN_TIME_REMAP):
4232 * s/bsd-common.h (TABDLY): Move to configure.
4233
4234 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
4235
4236 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
4237
ea0bbd17 4238 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 4239 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
4240
4241 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 4242
308aab79
GM
4243 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
4244 * s/template.h: Move NARROWPROTO to configure.
4245
ee1cf5cf
GM
42462012-07-11 Glenn Morris <rgm@gnu.org>
4247
30fe9bf4
GM
4248 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
4249 unused since 2011-01-17 change to systty.h.
4250
ee1cf5cf
GM
4251 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
4252 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4253 Move HAVE_PTYS and HAVE_SOCKETS to configure.
4254
63e47e07
PE
42552012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4256
4257 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
4258
c43fb4c3
GM
42592012-07-11 Glenn Morris <rgm@gnu.org>
4260
4261 * s/darwin.h, s/gnu-linux.h, s/template.h:
4262 Move INTERRUPT_INPUT to configure.
4263
e8df9267
DA
42642012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4265
4266 Minor adjustments to interning code.
4267 * lisp.h (intern, intern_c_string): Redefine as static inline
4268 wrappers for intern_1 and intern_c_string_1, respectively.
4269 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
4270 * lread.c (intern_1, intern_c_string_1, oblookup):
4271 Simplify Vobarray checking.
e8df9267
DA
4272 * font.c (font_intern_prop): Likewise. Adjust comment.
4273 * w32font.c (intern_font_name): Likewise.
4274
34348bd4
AS
42752012-07-11 Andreas Schwab <schwab@linux-m68k.org>
4276
d96a1e0c
AS
4277 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
4278
34348bd4
AS
4279 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
4280 of Fcar/Fcdr if possible.
4281 * font.c (check_otf_features): Likewise.
4282 * fontset.c (Fnew_fontset): Likewise.
4283 * gnutls.c (Fgnutls_boot): Likewise.
4284 * minibuf.c (read_minibuf): Likewise.
4285 * msdos.c (IT_set_frame_parameters): Likewise.
4286 * xmenu.c (Fx_popup_dialog): Likewise.
4287 * w32menu.c (Fx_popup_dialog): Likewise.
4288
c8add24e
GM
42892012-07-11 Glenn Morris <rgm@gnu.org>
4290
4b575b3c
GM
4291 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
4292 since nothing has defined it on these platforms.
4293
09f4e3b0
GM
4294 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
4295 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
4296
172bedef
GM
4297 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4298 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4299 Move CLASH_DETECTION to configure.
4300
249685df
GM
4301 * s/gnu.h: Remove file, which is now empty.
4302
c8add24e
GM
4303 * s/gnu.h, s/gnu-linux.h:
4304 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
4305
b41253a3
JW
43062012-07-11 John Wiegley <johnw@newartisans.com>
4307
4308 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
4309 function attribute, so we only use it if it exists in the
4310 compiler.
4311
d923b542
DA
43122012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4313
4314 Avoid call to strlen in fast_c_string_match_ignore_case.
4315 * search.c (fast_c_string_match_ignore_case): Change to use
4316 length argument. Adjust users accordingly.
4317 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
4318
5ebbef1d
PE
43192012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4320
bb352260
PE
4321 Assume mkdir, rmdir.
4322 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
4323 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
4324
57054ddd
PE
4325 Assume rename.
4326 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
4327
b747d3f7
PE
4328 Assume perror.
4329 * s/hpux10-20.h (HAVE_PERROR): Remove.
4330 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
4331 Remove dummy definition, as this problem was obsolete long ago.
4332
5ebbef1d
PE
4333 Assume strerror.
4334 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
4335
984e7f30
DA
43362012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4337
4338 Avoid calls to strlen in font processing functions.
4339 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
4340 (font_open_by_name): Change to use length argument.
4341 Adjust users accordingly.
d923b542
DA
4342 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
4343 Adjust prototypes.
4344 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
4345 Change to return ptrdiff_t.
984e7f30
DA
4346 (xfont_list_pattern, xfont_match): Use length returned by
4347 xfont_decode_coding_xlfd.
4348 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
4349
20e94fdd
GM
43502012-07-11 Glenn Morris <rgm@gnu.org>
4351
9d596af3
GM
4352 * s/darwin.h, s/freebsd.h, s/netbsd.h:
4353 Move DONT_REOPEN_PTY to configure.
4354
20e94fdd
GM
4355 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
4356 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
4357
e99a530f
PE
43582012-07-10 Paul Eggert <eggert@cs.ucla.edu>
4359
22ffb973
PE
4360 Remove "#define unix" that is no longer needed (Bug#11905).
4361 * s/aix4-2.h (unix): Remove; no longer needed.
4362
e9a9ae03
PE
4363 EMACS_TIME simplification (Bug#11875).
4364 This replaces macros (which typically do not work in GDB)
4365 with functions, typedefs and enums, making the code easier to debug.
4366 The functional style also makes code easier to read and maintain.
4367 * systime.h: Include <sys/time.h> on all hosts, not just if
4368 WINDOWSNT, since 'struct timeval' is needed in general.
4369 (EMACS_TIME): Now a typedef, not a macro.
4370 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
4371 not macros.
4372 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
4373 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
4374 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
4375 (EMACS_TIME_LE): Now functions, not macros.
4376 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
4377 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
4378 which are not functions. All uses rewritten to use:
4379 (make_emacs_time): New function.
4380 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
4381 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
4382 not functions. All uses rewritten to use the following, respectively:
4383 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
4384 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 4385 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
4386 * fileio.c (Fcopy_file):
4387 * xterm.c (XTflash): Get the current time closer to when it's used.
4388 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
4389
ffacb126
PE
4390 * bytecode.c (targets): Suppress -Woverride-init warnings.
4391
e99a530f
PE
4392 Simplify by avoiding confusing use of strncpy etc.
4393 * doc.c (Fsnarf_documentation):
4394 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
4395 * frame.c (Fmake_terminal_frame):
4396 * gtkutil.c (get_utf8_string):
4397 * lread.c (openp):
4398 * nsmenu.m (ns_update_menubar):
4399 * regex.c (regerror):
4400 Prefer memcpy to strncpy and strncat when either will do.
4401 * fileio.c (Fsubstitute_in_file_name):
4402 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
4403 (menu_separator_name_p):
4404 * nsmenu.m (ns_update_menubar):
4405 Prefer memcmp to strncmp when either will do.
4406 * nsterm.m: Include <ftoastr.h>.
4407 (ns_get_color):
4408 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
4409 Prefer snprintf to strncpy.
4410 * nsterm.m (ns_term_init):
4411 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
4412 * nsterm.m (ns_term_init):
4413 Avoid the need for strncpy, by using build_string or
4414 make_unibyte_string directly. Use dtoastr, not snprintf.
4415 * process.c (Fmake_network_process): Diagnose service names that
4416 are too long, rather than silently truncating them or creating
4417 non-null-terminated names.
4418 (Fnetwork_interface_info): Likewise, for interface names.
4419 * sysdep.c (system_process_attributes) [GNU_LINUX]:
4420 Prefer sprintf to strncat.
4421 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
4422 Prefer vsnprintf to vsprintf + strncpy.
4423
c59592b3
GM
44242012-07-10 Glenn Morris <rgm@gnu.org>
4425
4426 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
4427 Clarify fallback case.
4428
7d7bbefd
DA
44292012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4430
4431 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
4432 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
4433 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 4434 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
4435 where argument type is known to be a Lisp_Cons.
4436
3a4c8000
TT
44372012-07-10 Tom Tromey <tromey@redhat.com>
4438
4439 * bytecode.c (BYTE_CODE_THREADED): New macro.
4440 (BYTE_CODES): New macro. Replaces all old byte-code defines.
4441 (enum byte_code_op): New type.
4442 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
4443 (exec_byte_code): Use them. Use token threading when applicable.
4444
2a0213a6
DA
44452012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4446
4447 Optimize pure C strings initialization.
4448 * lisp.h (make_pure_string): Fix prototype.
4449 (build_pure_c_string): New function, defined as static inline. This
4450 provides a better opportunity to optimize away calls to strlen when
4451 the function is called with compile-time constant argument.
4452 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
4453 argument, adjust users accordingly. Use build_pure_c_string where
4454 appropriate.
4455 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
4456 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
4457 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
4458
cb1caeaf
DA
44592012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4460
4461 Avoid calls to strlen in miscellaneous functions.
4462 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
4463 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
4464 * lread.c (openp): Likewise.
4465
c293e30c
DA
44662012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4467
4468 Avoid calls to strlen in path processing functions.
4469 * fileio.c (file_name_as_directory): Add comment. Change to add
4470 srclen argument and return the length of result. Adjust users
4471 accordingly.
4472 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
4473 swap 1st and 2nd arguments to obey the common convention.
4474 Adjust users accordingly.
c293e30c
DA
4475 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
4476
9e059e3f
GM
44772012-07-10 Glenn Morris <rgm@gnu.org>
4478
d02eb359
GM
4479 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
4480 Move PENDING_OUTPUT_COUNT definition to configure.
4481
882cf227
GM
4482 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
4483 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
4484 * s/gnu.h (DATA_START): Move definitions to configure.
4485
af6e839f
GM
4486 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
4487 We include usg5-4-common.h, which defines them both.
4488
40289a12
GM
4489 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
4490 O_RDONLY already includes it).
4491
9e059e3f
GM
4492 Stop ns builds setting the EMACSLOADPATH environment variable.
4493 * nsterm.m (ns_load_path): Rename from ns_init_paths.
4494 Now it does not set EMACSLOADPATH, just returns the load-path string.
4495 * nsterm.h: Update accordingly.
4496 * lread.c [HAVE_NS]: Include nsterm.h.
4497 (init_lread) [HAVE_NS]: Use ns_load_path.
4498 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
4499
7c4e8ec0
GM
45002012-07-09 Glenn Morris <rgm@gnu.org>
4501
d4f600ff
GM
4502 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
4503 since the included bsd-common.h does so.
4504
cbb31951
GM
4505 Stop ns builds setting the EMACSPATH environment variable.
4506 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
4507 (ns_init_paths): Do not set EMACSPATH.
4508 * nsterm.h (ns_exec_path): Add it.
4509 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
4510 Use ns_exec_path.
4511
7c4e8ec0
GM
4512 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
4513
26bccfae
PE
45142012-07-09 Paul Eggert <eggert@cs.ucla.edu>
4515
a0bee46f
PE
4516 * process.c (wait_reading_process_output): 'waitchannels' was unset
4517 when read_kbd || !NILP (wait_for_cell); fix this.
4518
5994c183
PE
4519 Add GCC-style 'const' attribute to functions that can use it.
4520 * character.h (char_resolve_modifier_mask):
4521 * keyboard.h (make_ctrl_char):
4522 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
4523 (init_character_once, next_almost_prime, init_fns, init_image)
4524 (flush_pending_output, init_sound):
4525 * mem-limits.h (start_of_data):
4526 * menu.h (finish_menu_items):
4527 Add ATTRIBUTE_CONST.
4528 * emacs.c (DEFINE_DUMMY_FUNCTION):
4529 Declare the dummy function with ATTRIBUTE_CONST.
4530 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
4531 Add decls with ATTRIBUTE_CONST.
4532
26bccfae
PE
4533 Minor improvements to make_formatted_string.
4534 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
4535 where int is good enough, as vsprintf returns an int.
4536 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
4537
a8290ec3
DA
45382012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4539
4540 Use make_formatted_string to avoid double length calculation.
4541 * lisp.h (make_formatted_string): New prototype.
4542 * alloc.c (make_formatted_string): New function.
4543 * buffer.c (Fgenerate_new_buffer_name): Use it.
4544 * dbus.c (syms_of_dbusbind): Likewise.
4545 * editfns.c (Fcurrent_time_zone): Likewise.
4546 * filelock.c (get_boot_time): Likewise.
4547 * frame.c (make_terminal_frame, set_term_frame_name)
4548 (x_report_frame_params): Likewise.
4549 * image.c (gs_load): Likewise.
4550 * minibuf.c (get_minibuffer): Likewise.
4551 * msdos.c (dos_set_window_size): Likewise.
4552 * process.c (make_process): Likewise.
4553 * xdisp.c (ensure_echo_area_buffers): Likewise.
4554 * xsettings.c (apply_xft_settings): Likewise.
4555
d01ba2f1
GM
45562012-07-09 Glenn Morris <rgm@gnu.org>
4557
4558 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
4559 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
4560 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
4561 * nsterm.h (ns_etc_directory): Add it.
4562 * callproc.c [HAVE_NS]: Include nsterm.h.
4563 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
4564
f1f924b6
DA
45652012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4566
4567 Move marker debugging code under MARKER_DEBUG.
4568 * marker.c (MARKER_DEBUG): Move marker debugging code under
4569 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
4570 for bootstrap with --enable-checking (~3x slowdown reported
4571 by Juanma Barranquero <lekktu@gmail.com>).
4572 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
4573
ab531b66
PE
45742012-07-08 Paul Eggert <eggert@cs.ucla.edu>
4575
4576 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
4577 See <http://bugs.gnu.org/11825#29>.
4578
c4b3bc8a
EZ
45792012-07-08 Eli Zaretskii <eliz@gnu.org>
4580
4581 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
4582 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
4583 (display_line): Add commentary about displaying truncation glyphs
4584 on GUI frames.
4585 (produce_special_glyphs): Move here from term.c.
4586
4587 * term.c (produce_special_glyphs): Move to xdisp.c.
4588
4589 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
4590 section.
c4b3bc8a 4591
b676b881
AS
45922012-07-07 Andreas Schwab <schwab@linux-m68k.org>
4593
f17c5273
AS
4594 * xdisp.c (display_line): Avoid warning about implicit declaration
4595 of FRAME_FONT.
4596
298819b9
AS
4597 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
4598
b676b881
AS
4599 * lisp.h: Remove empty conditional.
4600
6045c4fd
PE
46012012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4602
b3350bf9
PE
4603 * lread.c (load_path_check): Now static.
4604
6045c4fd
PE
4605 Fix some minor --with-ns problems found by static checking.
4606 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
4607 (x_set_font) [!HAVE_X_WINDOWS]:
4608 * image.c (xpm_load_image) [HAVE_NS]:
4609 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
4610 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
4611 Remove unused local.
4612 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
4613 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
4614 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
4615 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
4616 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
4617 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
4618 Fix pointer signedness problem.
4619 * xfaces.c (FRAME_X_FONT_TABLE):
4620 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
4621
929e7845
GM
46222012-07-07 Glenn Morris <rgm@gnu.org>
4623
4624 * lread.c (load_path_check): New function, split from init_lread.
4625 (init_lread): Reorganize. Motivation:
4626 If EMACSLOADPATH is set, check/warn about that rather than the
4627 defaults, which we are not going to use. Hence we can remove
4628 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
4629 Don't warn if site-lisp directories are missing.
4630 If not installed, start from a blank load-path, since
4631 PATH_LOADSEARCH refers to the eventual installation directories.
4632
58dd0aa4
EZ
46332012-07-07 Eli Zaretskii <eliz@gnu.org>
4634
4635 Support truncation and continuation glyphs on GUI frames, when
4636 fringes are disabled. (Bug#11832)
4637 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
4638 continuation glyphs even if on GUI frames.
4639 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
4640 or both, are absent.
4641 (start_display, move_it_in_display_line_to): Handle the case of a
4642 GUI frame without a fringe to display continuation or truncation
4643 glyphs.
4644 (insert_left_trunc_glyphs): Support GUI frames: make sure
4645 truncation glyphs overwrite enough glyphs from the current line to
4646 have sufficient space in pixels.
4647 (display_line): Support truncation and continuation glyphs on GUI
4648 frames. If some spare pixels are left on the line after inserting
4649 the truncation glyphs, fill that space with a stretch glyph of a
4650 suitably computed width.
4651
4652 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
4653 produce_glyphs, to support GUI sessions.
4654
31571fd7
PE
46552012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4656
5a16b9bc
PE
4657 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
4658
f3047c75
PE
4659 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
4660
31571fd7
PE
4661 Do not require float-time's arg to fit in time_t (Bug#11825).
4662 This works better on hosts where time_t is unsigned, and where
4663 float-time is applied to the (negative) difference between two times.
4664 * editfns.c (decode_time_components): Last arg is now double *,
4665 not int *, and means to store all the result as a double, without
4666 worrying about whether the seconds part fits in time_t.
4667 All callers changed.
4668 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
4669 All callers changed.
4670 (Ffloat_time): Do not fail merely because the specified time falls
4671 outside of time_t range.
4672
4516fbef
GM
46732012-07-07 Glenn Morris <rgm@gnu.org>
4674
4675 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
4676 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
4677 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
4678
07adc2c6
JB
46792012-07-07 Juanma Barranquero <lekktu@gmail.com>
4680
4681 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
4682 Update dependencies.
4683
4684 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
4685
fd573f31
PE
46862012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4687
fee5959d
PE
4688 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
4689 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
4690 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
4691 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
4692 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
4693 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
4694
fd573f31
PE
4695 * xfont.c (compare_font_names): Redo to omit the need for casts.
4696
ddadbc0e
AS
46972012-07-06 Andreas Schwab <schwab@linux-m68k.org>
4698
fca8d6b6
AS
4699 * xfns.c (Fx_change_window_property): Doc fix.
4700 * w32fns.c (Fx_change_window_property): Doc fix.
4701
ddadbc0e
AS
4702 * w32fns.c (Fx_window_property): Accept the same arguments as the
4703 X Windows version. Doc fix.
4704 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
4705
ed9265fc 47062012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
4707 Eli Zaretskii <eliz@gnu.org>
4708
4709 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
4710 Windows-specific code from nt/config.nt moved here.
4711 Obsolete settings removed.
4712
216ee680
PE
47132012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4714
4715 * process.c: Avoid unnecessary calls to gettime.
4716 (wait_reading_process_output): Don't get the time of day
4717 when gobbling data immediately and not waiting, as there's no need
4718 for it in that case. This removes a FIXME.
4719
bdd091e4
JD
47202012-07-06 Jan Djärv <jan.h.d@swipnet.se>
4721
4722 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
4723 is defined (Bug#11768).
4724
9d44f8ce
DA
47252012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4726
4727 Fix marker debugging code.
4728 * marker.c (byte_char_debug_check): Do not perform the check
4729 if buffer is not multibyte.
090bd7cb
JB
4730 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4731 Call byte_char_debug_check with correct arguments.
9d44f8ce 4732
90fc4786
DA
47332012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4734
4735 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
4736 * marker.c (byte_char_debug_check, count_markers):
4737 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
4738 (byte_debug_flag): Remove.
4739 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4740 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
4741
7b7ae965
DA
47422012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4743
4e57b342
DA
4744 Avoid code repetition in marker-related functions.
4745 * marker.c (attach_marker): New function.
4746 (Fset_marker, set_marker_restricted, set_marker_both)
4747 (set_marker_restricted_both): Use it.
4748 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
4749 Consistently rename charno to charpos.
4750 (marker_position): Add eassert.
4751 (marker_byte_position): Convert to eassert.
4752
47532012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4754
4755 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 4756 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 4757 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 4758
657924ff
DA
47592012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4760
4761 Introduce fast path for the widely used marker operation.
4762 * alloc.c (build_marker): New function.
4763 * lisp.h (build_marker): New prototype.
4764 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
4765 * composite.c (autocmp_chars): Likewise.
4766 * editfns.c (buildmark): Remove.
4767 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
4768 (save_restriction_save): Use build_marker.
4769 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
4770 * window.c (save_window_save): Likewise.
4771
041a49a6
DA
47722012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4773
4774 Do not use Fdelete_overlay in delete_all_overlays
4775 to avoid redundant calls to unchain_overlay.
4776 * buffer.c (drop_overlay): New function.
4777 (delete_all_overlays, Fdelete_overlay): Use it.
4778 * minibuf.c (get_minibuffer): Fix comment.
4779
7dca65a4
PE
47802012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4781
4782 Port to OpenBSD 5.1 amd64.
4783 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
4784 This is needed for OpenBSD, and should be harmless on all BSD systems.
4785 Also, include <sys/sysctl.h>, as it should be available on all
4786 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
4787 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
4788 use p_pid member, not kp_proc.pid.
4789
8eb876e2
GM
47902012-07-06 Glenn Morris <rgm@gnu.org>
4791
4792 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
4793
38182d90
PE
47942012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4795
4796 More xmalloc and related cleanup.
4797 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
4798 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
4799 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
4800 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
4801 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
4802 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
4803 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
4804 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
4805 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
4806 * xterm.c:
4807 Omit needless casts involving void * pointers and allocation.
4808 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
4809 as the former is more robust if P's type is changed.
4810 Prefer xzalloc to xmalloc + memset 0.
4811 Simplify malloc-or-realloc to realloc.
4812 Don't worry about xmalloc returning a null pointer.
4813 Prefer xstrdup to xmalloc + strcpy.
4814 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
4815 growing it.
4816 * keyboard.c (apply_modifiers_uncached): Prefer local array to
4817 alloca of a constant.
4818
6dd5a677
EZ
48192012-07-05 Eli Zaretskii <eliz@gnu.org>
4820
4821 * xdisp.c (display_line): Fix horizontal pixel coordinates when
4822 hscroll is larger than the line width. Fixes long and futile
4823 looping inside extend_face_to_end_of_line (on a TTY) producing
4824 glyphs that are not needed and thrown away.
4825
6b312f0f
DA
48262012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4827
4828 * marker.c (set_marker_restricted_both): Simplify by using
4829 clip_to_bounds.
4830
f520ef9b
PE
48312012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4832
4833 * editfns.c (region_limit): Simplify by using clip_to_bounds.
4834
383b7c95
JD
48352012-07-05 Jan Djärv <jan.h.d@swipnet.se>
4836
4837 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
4838 not defined (Bug#11768).
4839 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
4840 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
4841 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
4842 followed by gtk_box_set_homogeneous (Bug#11768).
4843 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
4844 (update_theme_scrollbar_width, xg_create_scroll_bar):
4845 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
4846 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
4847 (is_box_type): New function (Bug#11768).
4848 (xg_tool_item_stale_p): Call is_box_type.
5293d758 4849 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
4850 with default display (Bug#11768).
4851
d6e7bf45
EZ
48522012-07-05 Eli Zaretskii <eliz@gnu.org>
4853
4854 * xdisp.c (window_hscroll_limited): New function.
4855 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
4856 coordinates when window's hscroll is set to insanely large
4857 values. (Bug#11857)
4858
431391ec
JB
48592012-07-05 Juanma Barranquero <lekktu@gmail.com>
4860
4861 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
4862 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
4863
23f86fce
DA
48642012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4865
4866 Cleanup xmalloc.
4867 * lisp.h (xzalloc): New prototype. Omit needless casts.
4868 * alloc.c (xzalloc): New function. Omit needless casts.
4869 * charset.c: Omit needless casts. Convert all calls to
4870 xmalloc with following memset to xzalloc.
4871 * dispnew.c: Likewise.
4872 * fringe.c: Likewise.
4873 * image.c: Likewise.
4874 * sound.c: Likewise.
4875 * term.c: Likewise.
4876 * w32fns.c: Likewise.
4877 * w32font.c: Likewise.
4878 * w32term.c: Likewise.
4879 * xfaces.c: Likewise.
4880 * xfns.c: Likewise.
4881 * xterm.c: Likewise.
4882 * atimer.c: Omit needless casts.
4883 * buffer.c: Likewise.
4884 * callproc.c: Likewise.
4885 * ccl.c: Likewise.
4886 * coding.c: Likewise.
4887 * composite.c: Likewise.
4888 * doc.c: Likewise.
4889 * doprnt.c: Likewise.
4890 * editfns.c: Likewise.
4891 * emacs.c: Likewise.
4892 * eval.c: Likewise.
4893 * filelock.c: Likewise.
4894 * fns.c: Likewise.
4895 * gtkutil.c: Likewise.
4896 * keyboard.c: Likewise.
4897 * lisp.h: Likewise.
4898 * lread.c: Likewise.
4899 * minibuf.c: Likewise.
4900 * msdos.c: Likewise.
4901 * print.c: Likewise.
4902 * process.c: Likewise.
4903 * region-cache.c: Likewise.
4904 * search.c: Likewise.
4905 * sysdep.c: Likewise.
4906 * termcap.c: Likewise.
4907 * terminal.c: Likewise.
4908 * tparam.c: Likewise.
4909 * w16select.c: Likewise.
4910 * w32.c: Likewise.
4911 * w32reg.c: Likewise.
4912 * w32select.c: Likewise.
4913 * w32uniscribe.c: Likewise.
4914 * widget.c: Likewise.
4915 * xdisp.c: Likewise.
4916 * xmenu.c: Likewise.
4917 * xrdb.c: Likewise.
4918 * xselect.c: Likewise.
4919
0497dc44
PE
49202012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4921
4922 * fileio.c (time_error_value): Check the right error number.
4923 Problem reported by Troels Nielsen in
4924 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
4925
356e7178
PE
49262012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4927
4e71fd89
PE
4928 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
4929 This should be fixed in a better way; see Eli Zaretskii in
4930 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
4931 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
4932
f0941253
PE
4933 * fileio.c (time_error_value): Rename from special_mtime.
4934 The old name's problems were noted by Eli Zaretskii in
4935 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
4936
065c9eb4
PE
4937 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
4938 This variable's comment says Emacs needs at least one GDB-visible
4939 symbol of type enum pvec_type, to work around GDB problems.
4940 The symbol's value doesn't matter.
4941
356e7178
PE
4942 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
4943 that causes compilation to fail on pre-C99 compilers.
4944
ed9265fc 49452012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
4946
4947 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
4948 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
4949
3884d954
DA
49502012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4951
d209e2fb 4952 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
4953 headers for buffer_defaults and buffer_local_symbols.
4954 Reported by Juanma Barranquero <lekktu@gmail.com>.
4955
ee28be33
SM
49562012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4957
4958 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
4959 * lisp.h (enum pvec_type): Use fewer bits.
4960 (PSEUDOVECTOR_SIZE_BITS): New constant.
4961 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
4962 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
4963 change in pvec_type.
4964 (PSEUDOVECTOR_TYPEP): New macro.
4965 (TYPED_PSEUDOVECTORP): Use it.
4966 * fns.c (internal_equal): Adapt code to extract pvectype.
4967 * emacs.c (gdb_pvec_type): Update type.
4968 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
4969 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
4970 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
4971 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
4972 (sweep_vectors): Use it. Use local var `total_bytes' instead of
4973 abusing vector->header.next.nbytes.
4974 (live_vector_p): Use PVEC_TYPE.
4975 (mark_object): Adapt code to extract pvectype. Use switch.
4976
c7f2cd7f
PE
49772012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4978
4979 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
4980 Tighten new eassert a bit.
4981
8ce70ed2
DA
49822012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4983
4984 Fix compilation with --enable-gcc-warnings and -O1
4985 optimization level.
4986 * doprnt.c (doprnt): Change type of tem to int, initialize
4987 to avoid compiler warning. Add eassert.
4988 * search.c (simple_search): Initialize match_byte to avoid
4989 compiler warning. Add eassert.
4990
dea7f1e5
PE
49912012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4992
24a212eb
PE
4993 Avoid weird behavior with large horizontal scrolls.
4994 Without this change, for example, large hscroll values would
4995 mess up Emacs's display on Fedora 15 x86, presumably due to
4996 overflows in int calculations in the display code.
4997 Also, if buffers had long lines, Emacs would freeze.
4998 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
4999 (set_window_hscroll): New function, containing the old guts of
5000 Fset_window_hscroll. Return the clipped value.
5001 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
5002 This avoids the need to check against PTRDIFF_MAX.
5003
dea7f1e5
PE
5004 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
5005
76046526
DA
50062012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5007
5008 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
5009
39adff0d
PE
50102012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5011
63807d47
PE
5012 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
5013 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
5014 since GCC 4.4.6 issues a bogus warning for them.
5015
39adff0d
PE
5016 Fix bugs in file timestamp newness comparisons.
5017 * fileio.c (Ffile_newer_than_file_p):
5018 * lread.c (Fload): Use full timestamp resolution of files,
5019 not just the 1-second resolution, so that files that are only
5020 slightly newer still count as newer.
5021 * fileio.c (Ffile_newer_than_file_p): Don't assume file
5022 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
5023
dbeed9a6
PE
50242012-07-03 Paul Eggert <eggert@cs.ucla.edu>
5025
5026 * fileio.c: Improve handling of file time marker. (Bug#11852)
5027 (special_mtime): New function.
5028 (Finsert_file_contents, Fverify_visited_file_modtime):
5029 Use it to set special mtime values consistently.
5030
636334d6
AS
50312012-07-03 Andreas Schwab <schwab@linux-m68k.org>
5032
5033 * fileio.c (Finsert_file_contents): Properly handle st_mtime
5034 marker for non-existing file. (Bug#11852)
5035
e2017fe2
GM
50362012-07-03 Glenn Morris <rgm@gnu.org>
5037
5038 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
5039 and did not make it into globals.h).
5040
404dbd37
TT
50412012-07-03 Tom Tromey <tromey@redhat.com>
5042
5043 * window.c (Fset_window_margins, Fset_window_fringes)
5044 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
5045 * textprop.c (Fprevious_property_change): No longer static.
5046 * syntax.c (Fsyntax_table_p): No longer static.
5047 * process.c (Fget_process, Fprocess_datagram_address): No longer
5048 static.
5049 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
5050 * keyboard.c (Fcommand_execute): No longer static.
5051 Remove EXFUN.
5052 * insdel.c (Fcombine_after_change_execute): No longer static.
5053 * image.c (Finit_image_library): No longer static.
5054 * fileio.c (Fmake_symbolic_link): No longer static.
5055 * eval.c (Ffetch_bytecode): No longer static.
5056 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
5057 * doc.c (Fdocumentation_property, Fsnarf_documentation):
5058 No longer static.
404dbd37
TT
5059 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
5060 static.
5061 * dired.c (Ffile_attributes): No longer static.
5062 * composite.c (Fcomposition_get_gstring): No longer static.
5063 * callproc.c (Fgetenv_internal): No longer static.
5064
5065 * ccl.h: Remove EXFUNs.
5066 * buffer.h: Remove EXFUNs.
5067 * dispextern.h: Remove EXFUNs.
5068 * intervals.h: Remove EXFUNs.
5069 * fontset.h: Remove EXFUN.
5070 * font.h: Remove EXFUNs.
5071 * dosfns.c (system_process_attributes): Remove EXFUN.
5072 * keymap.h: Remove EXFUNs.
5073 * lisp.h: Remove EXFUNs.
5074 * w32term.h: Remove EXFUNs.
5075 * window.h: Remove EXFUNs.
5076 * xsettings.h: Remove EXFUN.
5077 * xterm.h: Remove EXFUN.
5078
8e4fd1e1
GM
50792012-07-03 Glenn Morris <rgm@gnu.org>
5080
5081 * lisp.h (Frandom): Make it visible to C.
5082 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
5083 buffer for invisible buffers. (Bug#1229)
5084
ca95b3eb
DA
50852012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5086
5087 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
5088 values which aren't power of 2.
14ae4239
BT
5089 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
5090 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
5091 accordingly.
5092
7555c33f
SM
50932012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
5094
5095 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
5096
5097 * alloc.c (mark_object): Revert part of last patch to use `switch'.
5098
d12e8f5a
DA
50992012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5100
5101 * alloc.c (allocate_vector_block): Remove redundant
5102 calls to mallopt if DOUG_LEA_MALLOC is defined.
5103 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
5104 avoid calls to mallopt if zero_vector is returned.
5105
296094c3
DA
51062012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5107
5108 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
5109 is enabled, avoid dereferencing NULL current_sblock if
5110 running undumped.
5111
36429c89
DA
51122012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5113
5114 Cleanup basic buffer management.
5115 * buffer.h (struct buffer): Change layout to use generic vector
5116 marking code. Fix some comments. Change type of 'clip_changed'
5117 to bitfield. Remove unused #ifndef old.
5118 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
5119 (GET_OVERLAYS_AT): Fix indentation.
5120 (for_each_per_buffer_object_at): New macro.
5121 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
5122 (Fbuffer_local_variables): Use it.
5123 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
5124 * alloc.c (allocate_buffer): Adjust to match new layout of
5125 struct buffer. Fix comment.
5126 (mark_overlay): New function.
5127 (mark_buffer): Use it. Use mark_vectorlike to mark normal
5128 Lisp area of struct buffer.
5129 (mark_object): Use it. Adjust marking of misc objects
5130 and related comments.
5131
3b3e4cac
PE
51322012-07-02 Paul Eggert <eggert@cs.ucla.edu>
5133
5134 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
5135 wrapper that is not needed because the wrapped code is a no-op (zero
5136 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
5137 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
5138
cf5c0175
DA
51392012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
5140
5141 * alloc.c (mark_buffer): Simplify. Remove prototype.
5142 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 5143 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
5144 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
5145 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 5146
ca26824c
GM
51472012-06-30 Glenn Morris <rgm@gnu.org>
5148
2e4c5312
GM
5149 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
5150
ca26824c
GM
5151 * epaths.in (PATH_SITELOADSEARCH): New.
5152 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
5153 This is rather than relying on --enable-locallisppath elements
5154 having "site-lisp" in their names. (Bug#10208#25, 11658)
5155
0d23c240
EZ
51562012-06-30 Eli Zaretskii <eliz@gnu.org>
5157
c9240d7a
EZ
5158 * w32proc.c (sys_select): Accept and ignore one more argument.
5159
5160 * w32.c (emacs_gnutls_pull): Call select with one more argument.
5161
0d23c240 5162 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 5163 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
5164
5165 * sysdep.c: Don't include dos.h and dosfns.h.
5166
5167 * process.c (sys_select):
5168 * msdos.c (sys_select): Accept one more argument and ignore it.
5169
5170 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
5171 adapt data types and code to that.
5172
5173 * dosfns.c:
5174 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
5175 which clashes with the gnulib function of the same name.
5176
af5a5a98
AS
51772012-06-30 Andreas Schwab <schwab@linux-m68k.org>
5178
c5e4379c
AS
5179 * font.c (font_style_to_value, font_style_symbolic)
5180 (font_prop_validate_style): Add type checks for values in
5181 font_style_table.
5182
af5a5a98
AS
5183 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
5184 argument.
5185 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
5186 uses.
5187
8d38f461
EZ
51882012-06-29 Eli Zaretskii <eliz@gnu.org>
5189
2e5a6631
EZ
5190 * xdisp.c (try_window_id): Undo last change.
5191
8d38f461
EZ
5192 * w32.c (getwd): Adjust commentary about startup_dir.
5193 (init_environment): Always call sys_access, even in non-MSVC
5194 builds. Don't chdir to the directory of the Emacs executable.
5195 This undoes code from 1997 which was justified by the need to
5196 "avoid conflicts when removing and renaming directories". But its
5197 downside was that every relative file name was being interpreted
5198 relative to the directory of the Emacs executable, which can never
5199 be TRT. In particular, it broke sys_access when called with
5200 relative file names.
5201 (sys_access): Map GetLastError to errno.
5202
2af3565e
DA
52032012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5204
5205 * window.h (struct window): Change type of 'fringes_outside_margins'
5206 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 5207 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
5208 Adjust comment.
5209 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
5210 to ptrdiff_t.
5211
c8d3a25c 52122012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 5213
c8d3a25c
GM
5214 * gnutls.c (emacs_gnutls_handshake):
5215 Add QUIT to make the loop interruptible.
57570cd3 5216
c8d3a25c 52172012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 5218
c8d3a25c
GM
5219 * charset.c (init_charset): Make lack of etc/charsets fatal.
5220
3e984ee8
DA
52212012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5222
5223 * editfns.c (region_limit): Fix type mismatch.
5224
ef884f23
DA
52252012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5226
5227 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
5228 undefined. Convert from xassert to eassert.
5229 * nsmenu.m: Convert from xassert to eassert.
5230 * nsterm.m: Likewise.
5231
7d7e0027
SM
52322012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
5233
5234 * editfns.c (region_limit): Clip to narrowing (bug#11770).
5235
aa754e6a
PE
52362012-06-28 Paul Eggert <eggert@cs.ucla.edu>
5237
5238 Avoid integer overflow on scroll-left and scroll-right.
5239 * window.c (HSCROLL_MAX): New macro.
5240 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
5241 overflow when requested scroll falls outside ptrdiff_t range.
5242
80b00b08
DA
52432012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5244
5245 * window.h (struct window): Change type of 'hscroll',
5246 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
5247 'last_modified' and 'last_overlay_modified' to EMACS_INT.
5248 Adjust users accordingly.
5249 * xdisp.c (try_cursor_movement): Replace type check with eassert.
5250 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
5251 from EMACS_INT to ptrdiff_t.
5252 (make_window): Omit redundant initialization.
5253
62b2bcf6
JB
52542012-06-28 Juanma Barranquero <lekktu@gmail.com>
5255
5256 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
5257
45942c7d
DA
52582012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5259
5260 * window.h (struct window): Change type of 'use_time' and
5261 'sequence_number' from Lisp_Object to int.
5262 * frame.c (make_frame): Adjust users accordingly.
5263 * print.c (print_object): Likewise.
5264 * window.c (select_window, Fwindow_use_time, make_parent_window)
5265 (make_window): Likewise.
5266
e509cfa6
DA
52672012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5268
5269 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
5270 enabled with --enable-checking=[all,glyphs] configure option.
5271 Fix GLYPH_DEBUG usage assuming that it may be undefined,
5272 adjust comments accordingly.
5273 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
5274 undefined, adjust comments accordingly.
5275 * image.c: Likewise.
5276 * scroll.c: Likewise.
5277 * w32fns.c: Likewise.
5278 * w32term.c: Likewise.
5279 * xdisp.c: Likewise.
5280 * xfaces.c: Likewise.
5281 * xfns.c: Likewise.
5282 * xterm.c: Likewise.
5283
a54e2c05
DA
52842012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5285
5286 Generalize run-time debugging checks.
5287 * dispextern.h (XASSERTS): Remove.
5288 * fontset.c (xassert): Remove.
5289 Convert from xassert to eassert.
5290 * alloc.c: Convert from xassert to eassert.
5291 * bidi.c: Likewise.
5292 * dispnew.c: Likewise.
5293 * fns.c: Likewise.
5294 * fringe.c: Likewise.
5295 * ftfont.c: Likewise.
5296 * gtkutil.c: Likewise.
5297 * image.c: Likewise.
5298 * keyboard.c: Likewise.
5299 * menu.c: Likewise.
5300 * process.c: Likewise.
5301 * scroll.c: Likewise.
5302 * sound.c: Likewise.
5303 * term.c: Likewise.
5304 * w32console.c: Likewise.
5305 * w32fns.c: Likewise.
5306 * w32term.c: Likewise.
5307 * window.c: Likewise.
5308 * xdisp.c: Likewise.
5309 * xfaces.c: Likewise.
5310 * xfns.c: Likewise.
5311 * xselect.c: Likewise.
5312 * xterm.c: Likewise.
5313
1ec4b7b2
SM
53142012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
5315
5316 * fns.c (maybe_resize_hash_table): Output message when growing the
5317 purify-hashtable.
5318
2014308a
DA
53192012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5320
5321 * alloc.c (allocate_string_data): Remove dead code.
5322 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
5323 avoid GCC warning about unused macro.
5324
246155eb
DA
53252012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5326
5327 * alloc.c (allocate_string): Omit intervals initialization.
5328 * alloc.c (make_uninit_multibyte_string): Initialize intervals
5329 as in make_pure_string and make_pure_c_string.
5330
43184b7b
DA
53312012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5332
d209e2fb 5333 * alloc.c (allocate_string): Fix last change.
43184b7b 5334
3fe6dd74
DA
53352012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5336
d209e2fb 5337 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
5338 to memset, add explicit initialization where appropriate.
5339
1ba6038a
GM
53402012-06-27 Glenn Morris <rgm@gnu.org>
5341
5342 * lisp.mk (lisp): Remove paths.elc.
5343
c89926a5
CY
53442012-06-27 Chong Yidong <cyd@gnu.org>
5345
5346 * doc.c (Fsubstitute_command_keys): Fix punctuation.
5347
ed6b3510
JW
53482012-06-26 John Wiegley <johnw@newartisans.com>
5349
1ec4b7b2 5350 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
5351 on Mac OS X Lion: __mod_init_func and __mod_term_func.
5352
ed6b3510
JW
5353 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
5354 when building with Clang.
5355
8edd4a2b
SM
53562012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
5357
5358 * eval.c (Fapply): Allow calling it with a single argument.
5359
f6f62d1b
EZ
53602012-06-26 Eli Zaretskii <eliz@gnu.org>
5361
5362 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
5363 _stricmp and _strnicmp.
5364 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
5365
62efea5e
DA
53662012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5367
5368 * alloc.c (allocate_window): Zero out non-Lisp part of newly
5369 allocated window.
5370 (allocate_process): Likewise for new process.
8edd4a2b 5371 (allocate_terminal): Change to use offsetof.
62efea5e
DA
5372 (allocate_frame): Likewise.
5373 * frame.c (make_frame): Omit redundant initialization.
5374 * window.c (make_parent_window): Use memset.
5375 (make_window): Omit redundant initialization.
5376 * process.c (make_process): Omit redundant initialization.
5377 * terminal.c (create_terminal): Likewise.
5378
42997f4d
DA
53792012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5380
5381 * term.c (delete_tty): Remove redundant call to memset.
5382
1130ecfc
DA
53832012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5384
5385 * alloc.c: Remove build_string.
5386 * lisp.h: Define build_string as static inline. This provides
5387 a better opportunity to optimize away calls to strlen when the
5388 function is called with compile-time constant argument.
5389 * image.c (imagemagick_error): Convert to build_string.
5390 * w32proc.c (sys_spawnve): Likewise.
5391 * xterm.c (x_term_init): Likewise.
5392
cf38a720
PE
53932012-06-26 Paul Eggert <eggert@cs.ucla.edu>
5394
99027bdd
PE
5395 Use sprintf return value instead of invoking strlen on result.
5396 In the old days this wasn't portable, since some sprintf
5397 implementations returned char *. But they died out years ago and
5398 Emacs already assumes sprintf returns int.
5399 Similarly for float_to_string.
5400 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
5401 * ccl.c (ccl_driver):
5402 * character.c (string_escape_byte8):
5403 * data.c (Fnumber_to_string):
5404 * doprnt.c (doprnt):
5405 * print.c (print_object):
5406 * xdisp.c (message_dolog):
5407 * xfns.c (syms_of_xfns):
5408 Use sprintf or float_to_string result to avoid need to call strlen.
5409 * data.c (Fnumber_to_string):
5410 Use make_unibyte_string, since the string must be ASCII.
5411 * lisp.h, print.c (float_to_string): Now returns int length.
5412 * term.c (produce_glyphless_glyph):
5413 Use sprintf result rather than recomputing it.
5414
cf38a720
PE
5415 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
5416 * Makefile.in (ALL_CFLAGS):
5417 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
5418 * gmalloc.c, regex.c: Include <config.h> unconditionally.
5419
3511c784
DA
54202012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5421
0a08eb21 5422 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
5423 strcasecmp if available.
5424 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
5425
fb7da12e
AS
54262012-06-25 Andreas Schwab <schwab@linux-m68k.org>
5427
5428 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
5429 Avoid comma operator.
5430 * menu.c (push_submenu_start, push_submenu_end)
5431 (push_left_right_boundary, push_menu_pane): Likewise.
5432 * msdos.c (dos_rawgetc): Likewise.
5433
afa2ffd8
DA
54342012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5435
5436 * xfns.c (xic_create_fontsetname): Remove redundant calls
5437 to memset.
5438
b3b4476b
PE
54392012-06-25 Paul Eggert <eggert@cs.ucla.edu>
5440
4495ff38
PE
5441 * gtkutil.c (get_utf8_string): Remove redundant assignment.
5442 sprintf already null-terminates its output.
5443
b3b4476b
PE
5444 * xfns.c (x_window): Remove redundant cast.
5445
b00876c9
DA
54462012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5447
5448 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
5449 `const char *' to `char *' to avoid compiler warning.
5450
d188e26b
PE
54512012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5452
885d1d74
PE
5453 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
5454 instead of truncating it to 63 (admittedly a generous limit).
5455
d188e26b
PE
5456 * process.c: Fix spelling and caps in comments.
5457
e2f560b1
DN
54582012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
5459
e86db54b 5460 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
5461 * sysdep.c (setpgrp): Remove definition, not used in this file.
5462
7583a3a1
JB
54632012-06-24 Juanma Barranquero <lekktu@gmail.com>
5464
5465 * makefile.w32-in: Update dependencies.
5466
696056c2
EZ
54672012-06-24 Eli Zaretskii <eliz@gnu.org>
5468
5469 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
5470 (SYSTIME_H): Add nt/inc/sys/time.h.
5471
5472 * systime.h [WINDOWSNT]: Include sys/time.h.
5473
5474 * s/ms-w32.h (struct timespec): Definition moved from
5475 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
5476
845ca893
PE
54772012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5478
5479 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
5480 * buffer.h (buffer_slot_type_mismatch):
5481 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5482 * eval.c (unwind_to_catch):
5483 * image.c (my_png_error, my_error_exit):
5484 * keyboard.c (quit_throw_to_read_char, user_error)
5485 (Fexit_recursive_edit, Fabort_recursive_edit):
5486 * lisp.h (die, args_out_of_range, args_out_of_range_3)
5487 (wrong_type_argument, buffer_overflow, __executable_start)
5488 (memory_full, buffer_memory_full, string_overflow, Fthrow)
5489 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
5490 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
5491 (fatal):
5492 (child_setup) [!DOS_NT]:
5493 * lread.c (end_of_file_error, invalid_syntax):
5494 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5495 * puresize.h (pure_write_error):
5496 * search.c (matcher_overflow):
5497 * sound.c (sound_perror, alsa_sound_perror):
5498 * sysdep.c, syssignal.h (croak):
5499 * term.c (maybe_fatal, vfatal):
5500 * textprop.c (text_read_only):
5501 * undo.c (user_error):
5502 * unexmacosx.c (unexec_error):
5503 * xterm.c (x_ins_del_lines, x_delete_glyphs):
5504 Use _Noreturn rather than NO_RETURN.
5505 No need for separate decl merely because of _Noreturn.
5506 * sound.c (sound_warning, parse_sound):
5507 Remove unnecessary forward decls.
5508
f1dd8073
PE
55092012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5510
5511 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
5512 * lisp.h (WAIT_READING_MAX): New macro.
5513 * dispnew.c (Fsleep_for, sit_for):
5514 * keyboard.c (kbd_buffer_get_event):
5515 * process.c (Faccept_process_output):
5516 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
5517 This improves on the previous patch, which introduced a bug
5518 when time_t is unsigned and as wide as intmax_t.
5519 See <http://bugs.gnu.org/9000#51>.
5520
b82c1755
EZ
55212012-06-23 Eli Zaretskii <eliz@gnu.org>
5522
5523 * dispnew.c (sit_for, Fsleep_for):
5524 * keyboard.c (kbd_buffer_get_event):
5525 * process.c (Faccept_process_output): Avoid compiler warnings when
5526 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
5527
ca300656
JB
55282012-06-23 Juanma Barranquero <lekktu@gmail.com>
5529
049ec95b
JB
5530 * makefile.w32-in: Update dependencies.
5531
ca300656
JB
5532 * w32.c (ltime): Add return type and declare static.
5533 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
5534
db7b8d06
PE
55352012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5536
5537 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
5538 Privately reported by Herbert J. Skuhra.
5539 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
5540 All uses changed.
5541 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
5542 not make_lisp_timeval, when the argument is of type EMACS_TIME.
5543
0bd8297f
EZ
55442012-06-23 Eli Zaretskii <eliz@gnu.org>
5545
96512555
EZ
5546 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
5547 last argument of make_unibyte_string.
5548
0bd8297f
EZ
5549 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
5550 language ID in the event parameters.
5551
5552 * w32term.c (w32_read_socket): Put the new keyboard codepage into
5553 event.code, not the obscure "character set ID".
5554
63def6b6
CY
55552012-06-23 Chong Yidong <cyd@gnu.org>
5556
5557 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
5558
e8a02204
EZ
55592012-06-23 Eli Zaretskii <eliz@gnu.org>
5560
388cdec0
EZ
5561 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
5562 * w32.c (fdutimens): New function.
5563
5564 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
5565
5566 * s/ms-w32.h (pselect): Redirect to sys_select.
5567
5568 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
5569
e8a02204
EZ
5570 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
5571 in the logic of incrementing and decrementing the value of
5572 use_relocatable_buffers.
5573
d054f3fb
PE
55742012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5575
5576 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
5577 Privately reported by Herbert J. Skuhra.
5578 [__FreeBSD__]: Remove "*/" typo after "#include".
5579 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
5580 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
5581 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
5582 Don't assume EMACS_TIME and struct timeval are the same type.
5583
d35af63c
PE
55842012-06-22 Paul Eggert <eggert@cs.ucla.edu>
5585
5586 Support higher-resolution time stamps (Bug#9000).
5587 The time stamps are only nanosecond-resolution at the C level,
5588 since that's the best that any real-world system supports now.
5589 But they are picosecond-resolution at the Lisp level, as that's
5590 easy, and leaves room for future OS improvements.
5591
5592 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
5593 (LIBES): Use it.
5594
5595 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
5596 Don't get current time unless it's needed.
5597
5598 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
5599 now provides it if it's absent.
5600 (start_atimer): Port to higher-res time stamps.
5601 Check for time stamp overflow. Don't get current time more
5602 often than is needed.
5603
5604 * buffer.h (struct buffer): Buffer modtime now has high resolution.
5605 Include systime.h, not time.h.
5606 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
5607
5608 * dired.c: Include stat-time.h.
5609 (Ffile-attributes): File times now have higher resolution.
5610
5611 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
5612 (struct image): Timestamp now has higher resolution.
5613
5614 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
5615 has at least microseconds now. All uses removed.
5616 (update_frame, update_single_window, update_window, update_frame_1)
5617 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 5618 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
5619
5620 * editfns.c (time_overflow): Now extern.
5621 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
5622 (float-time, Fformat_time_string, Fcurrent_time_string)
5623 (Fcurrent_time_zone): Accept and generate higher-resolution
5624 time stamps.
5625 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
5626 (decode_time_components, lisp_seconds_argument): New functions.
5627 (make_time): Now static.
5628 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
5629 Report an error if the time is invalid, rather than having the caller
5630 do that.
5631
5632 * fileio.c: Include <stat-time.h>
5633 (Fcopy_file): Copy higher-resolution time stamps.
5634 Prefer to set the time stamp via a file descriptor if that works.
5635 (Fset_file_times, Finsert_file_contents, Fwrite_region)
5636 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
5637 (Fvisited_file_modtime, Fset_visited_file_modtime):
5638 Support higher-resolution time stamps.
5639
5640 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
5641
5642 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
5643
5644 * image.c (prepare_image_for_display, clear_image_cache)
5645 (lookup_image): Port to higer-resolution time stamps.
5646
5647 * keyboard.c (start_polling, bind_polling_period):
5648 Check for time stamp overflow.
5649 (read_char, kbd_buffer_get_event, timer_start_idle)
5650 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
5651 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
5652 Port to higher-resolution time stamps. Do not assume time_t is signed.
5653 (decode_timer): New function. Timers are now vectors of length 9,
5654 not 8, to accommodate the picosecond component.
5655 (timer_check_2): Use it.
5656
5657 * nsterm.m (select_timeout, timeval_subtract): Remove.
5658 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
5659 as they're a bit more accurate and handle overflow better.
5660 (ns_select): Change prototype to be compatible with pselect.
5661 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
5662 * nsterm.h (ns_select): Adjust prototype.
5663
5664 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
5665 us-resolution time stamps.
5666 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
5667
5668 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
5669
5670 * lisp.h (time_overflow): New decl.
5671 (wait_reading_process_output): First arg is now intmax_t, not int,
5672 to accommodate larger waits.
5673
5674 * process.h (struct Lisp_Process.read_output_delay):
5675 Now counts nanoseconds, not microseconds.
5676 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
5677 EMACS_HAS_USECS.
5678 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
5679 (wait_reading_process_output):
5680 Port to ns-resolution time stamps.
5681 (Faccept_process_output, wait_reading_process_output):
5682 Check for time stamp overflow. Do not assume time_t is signed.
5683 (select_wrapper): Remove; we now use pselect.
5684 (Fprocess_attributes): Now generates ns-resolution time stamps.
5685
5686 * sysdep.c: Include utimens.h. Don't include utime.h
5687 or worry about struct utimbuf; gnulib does that for us now.
5688 (gettimeofday): Remove; gnulib provides a substitute.
5689 (make_timeval): New function.
5690 (set_file_times): Now sets ns-resolution time stamps.
5691 New arg FD; all uses changed.
5692 (time_from_jiffies, ltime_from_jiffies, get_up_time)
5693 (system_process_attributes):
5694 Now returns ns-resolution time stamp. All uses changed.
5695 Check for time stamp overflow.
5696
5697 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
5698 provides a substitute now.
5699
5700 * systime.h: Include timespec.h rather than sys/time.h and time.h,
5701 since it guarantees struct timespec.
5702 (EMACS_TIME): Now struct timespec, so that we can support
5703 ns-resolution time stamps.
5704 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
5705 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
5706 (EMACS_USECS): Remove.
5707 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
5708 so multiply the arg by 1000 before storing it.
5709 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
5710 New macros.
5711 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
5712 Port to ns-resolution time stamps.
5713 (EMACS_TIME_NEG_P): Remove; replaced by....
5714 (EMACS_TIME_SIGN): New macro.
5715 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
5716 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
5717 (set_file_times, make_time, lisp_time_argument): Adjust signature.
5718 (make_timeval, make_lisp_time, decode_time_components): New decls.
5719 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
5720 that it mishandled time_t overflow. You can't compare by subtracting!
5721 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
5722 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
5723
5724 * term.c: Include <sys/time.h>.
5725 (timeval_to_Time): New function, for proper overflow wraparound.
5726 (term_mouse_position, term_mouse_click): Use it.
5727
5728 * undo.c (record_first_change): Support higher-resolution time stamps
5729 in the undo buffer.
5730 (Fprimitive_undo): Use them when restoring time stamps.
5731
5732 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
5733 (w32_get_internal_run_time):
5734 Port to higher-resolution Emacs time stamps.
5735 (ltime): Now accepts single 64-bit integer, as that's more convenient
5736 for callers.
5737
5738 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
5739
5740 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
5741 for compatibility with pselect. Support ns-resolution time stamps.
5742
5743 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
5744
5745 * xselect.c (wait_for_property_change, x_get_foreign_selection):
5746 Check for time stamp overflow, and support ns-resolution time stamps.
5747
5748 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
5749 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
5750 (timeval_subtract): Remove; no longer needed.
5751 (XTflash, XTring_bell, x_wait_for_event):
5752 Port to ns-resolution time stamps. Don't assume time_t is signed.
5753
b6a92dfe
CY
57542012-06-22 Chong Yidong <cyd@gnu.org>
5755
5756 * xdisp.c (x_consider_frame_title): Revert last change.
5757
d251c37c
EZ
57582012-06-22 Eli Zaretskii <eliz@gnu.org>
5759
5760 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
5761 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
5762 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
5763 staticidx goes up to 1597 out of 1600 = 0x640.)
5764
f10deafb
PE
57652012-06-20 Paul Eggert <eggert@cs.ucla.edu>
5766
5767 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
5768 Otherwise, the umask might be mistakenly 0 while handling input signals.
5769
ec6de1e2
SM
57702012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
5771
5772 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
5773
28be1ada
DA
57742012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
5775
5776 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
5777 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
5778 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
5779 access to `contents' member of Lisp_Vector objects with AREF and ASET
5780 where appropriate.
5781
c6bf3022
CY
57822012-06-19 Chong Yidong <cyd@gnu.org>
5783
5784 * frame.c (delete_frame): When selecting a frame on a different
5785 text terminal, do not alter the terminal's top-frame.
5786
5787 * xdisp.c (format_mode_line_unwind_data): Record the target
5788 frame's selected window and its terminal's top-frame.
5789 (unwind_format_mode_line): Restore them.
5790 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
5791 Callers changed.
5792 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
5793 since tty frames can be explicitly named.
5794 (prepare_menu_bars): Likewise.
5795
5796 * term.c (Ftty_top_frame): New function.
5797
defd4196
PE
57982012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5799
5800 Port byte-code-meter to modern targets.
5801 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
5802 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 5803 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
5804 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
5805 (METER_1, METER_2): Simplify.
5806
1053a871
SM
58072012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
5808
5809 * data.c (Fdefalias): Return `symbol' (bug#11686).
5810
b7e8d081
MR
58112012-06-18 Martin Rudalics <rudalics@gmx.at>
5812
5813 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
5814 gets killed during executing of this function (Bug#11665).
5815 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
5816 (Vkill_buffer_query_functions): In doc-string say that functions
5817 run by this hook should not change the current buffer.
5818
7ea2b339
PE
58192012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5820
5821 Fix recently-introduced process.c problems found by static checking.
5822 * process.c (write_queue_push, write_queue_pop, send_process):
5823 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
5824 (write_queue_pop): Fix pointer signedness problem.
5825 (send_process): Remove unused local.
5826
96a313a1
CY
58272012-06-17 Chong Yidong <cyd@gnu.org>
5828
5829 * xdisp.c (redisplay_internal): No need to redisplay terminal
5830 frames that are not on top.
5831
20ca2e94
TN
58322012-06-17 Troels Nielsen <bn.troels@gmail.com>
5833
5834 * process.c (make_process): Initialize write_queue.
5835 (write_queue_push, write_queue_pop): New functions.
5836 (send_process): Use them to maintain correct ordering of process
5837 writes (Bug#10815).
5838
9a900ca9
PE
58392012-06-17 Paul Eggert <eggert@cs.ucla.edu>
5840
310fbfa8
PE
5841 * lisp.h (eassert): Assume C89 or later.
5842 This removes the need for CHECK.
5843 (CHECK): Remove. Its comments about always evaluating its
5844 argument were confusing, as 'eassert' typically does not evaluate
5845 its argument.
5846
27bb1ca4
PE
5847 * coding.c (produce_chars): Use ptrdiff_t, not int.
5848
9a900ca9
PE
5849 * xterm.c (x_draw_underwave): Check for integer overflow.
5850 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
5851
41b7f8bc 58522012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
5853
5854 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
5855 referenced (Bug#11583).
5856
9b0e3eba
AA
58572012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
5858
5859 Implement wave-style variant of underlining.
5860 * dispextern.h (face_underline_type): New enum.
5861 (face): Add field for underline type.
5862 * nsterm.m (ns_draw_underwave): New function.
5863 (ns_draw_text_decoration): Use it.
5864 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
5865 New functions.
5866 (x_draw_glyph_string): Use them.
5867 * xfaces.c (Qline, Qwave): New Lisp objects.
5868 (check_lface_attrs, merge_face_ref)
1053a871
SM
5869 (Finternal_set_lisp_face_attribute, realize_x_face):
5870 Handle wave-style underline face attributes.
9b0e3eba
AA
5871 * xterm.c (x_draw_underwave): New function.
5872 (x_draw_glyph_string): Use it.
5873
0fb52f11
JB
58742012-06-16 Juanma Barranquero <lekktu@gmail.com>
5875
5876 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
5877 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
5878 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
5879 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
5880 ($(BLD)/w32select.$(O)): Update dependencies.
5881
e5560ff7
AS
58822012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5883
5884 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
5885 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
5886 * character.c (_fetch_multibyte_char_p): Remove.
5887 * alloc.c: Include "character.h" before "buffer.h".
5888 * bidi.c: Likewise.
5889 * buffer.c: Likewise.
5890 * bytecode.c: Likewise.
5891 * callint.c: Likewise.
5892 * callproc.c: Likewise.
5893 * casefiddle.c: Likewise.
5894 * casetab.c: Likewise.
5895 * category.c: Likewise.
5896 * cmds.c: Likewise.
5897 * coding.c: Likewise.
5898 * composite.c: Likewise.
5899 * dired.c: Likewise.
5900 * dispnew.c: Likewise.
5901 * doc.c: Likewise.
5902 * dosfns.c: Likewise.
5903 * editfns.c: Likewise.
5904 * emacs.c: Likewise.
5905 * fileio.c: Likewise.
5906 * filelock.c: Likewise.
5907 * font.c: Likewise.
5908 * fontset.c: Likewise.
5909 * fringe.c: Likewise.
5910 * indent.c: Likewise.
5911 * insdel.c: Likewise.
5912 * intervals.c: Likewise.
5913 * keyboard.c: Likewise.
5914 * keymap.c: Likewise.
5915 * lread.c: Likewise.
5916 * macros.c: Likewise.
5917 * marker.c: Likewise.
5918 * minibuf.c: Likewise.
5919 * nsfns.m: Likewise.
5920 * nsmenu.m: Likewise.
5921 * print.c: Likewise.
5922 * process.c: Likewise.
5923 * regex.c: Likewise.
5924 * region-cache.c: Likewise.
5925 * search.c: Likewise.
5926 * syntax.c: Likewise.
5927 * term.c: Likewise.
5928 * textprop.c: Likewise.
5929 * undo.c: Likewise.
5930 * unexsol.c: Likewise.
5931 * w16select.c: Likewise.
5932 * w32fns.c: Likewise.
5933 * w32menu.c: Likewise.
5934 * window.c: Likewise.
5935 * xdisp.c: Likewise.
5936 * xfns.c: Likewise.
5937 * xmenu.c: Likewise.
5938 * xml.c: Likewise.
5939 * xselect.c: Likewise.
5940
2f07e6af
EZ
59412012-06-16 Eli Zaretskii <eliz@gnu.org>
5942
1053a871
SM
5943 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
5944 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 5945 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
5946 row.
5947 (handle_face_prop): Use chunk-relative overlay string index when
5948 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
5949 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
5950 the rightmost. (Bug#11720)
2f07e6af 5951
29b83cec
AS
59522012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5953
5954 * category.h (CHAR_HAS_CATEGORY): Define as inline.
5955 (CATEGORY_MEMBER): Enforce 1/0 value.
5956 * category.c (_temp_category_set): Remove.
5957
4c5501e9
EZ
59582012-06-16 Eli Zaretskii <eliz@gnu.org>
5959
5960 * window.c (Fdelete_other_windows_internal)
5961 (Fdelete_window_internal): Don't access frame's mouse highlight
5962 info of the initial frame. (Bug#11677)
5963
2b570124
PE
59642012-06-14 Paul Eggert <eggert@cs.ucla.edu>
5965
e93864f9
PE
5966 * .gdbinit (xgetint): Fix recently-introduced paren typo.
5967 Assume USE_2_TAGS_FOR_INTS.
5968 (xreload): Adjust $tagmask width to match recent lisp.h change.
5969
2b570124
PE
5970 Simplify lisp.h in minor ways that should not affect code.
5971 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
5972 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
5973 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
5974 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
5975 (INTTYPEBITS): New macro, for clarity.
5976 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
5977 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
5978 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
5979 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
5980 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
5981
81755f69
JB
59822012-06-13 Juanma Barranquero <lekktu@gmail.com>
5983
5984 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
5985
16192a57
GM
59862012-06-13 Glenn Morris <rgm@gnu.org>
5987
5988 * s/bsd-common.h (BSD4_3):
5989 * s/usg5-4-common.h (USG5_4): No longer define; unused.
5990
646b5f55
AS
59912012-06-13 Andreas Schwab <schwab@linux-m68k.org>
5992
5993 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
5994 instead of union.
5995 (XLI, XIL): Define.
1053a871
SM
5996 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
5997 Use them.
5998 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 5999 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 6000 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
6001 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
6002 * frame.c (delete_frame): Remove outdated comment.
6003 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
6004 USE_LISP_UNION_TYPE.
6005 (Fw32_unregister_hot_key): Likewise.
6006 (Fw32_toggle_lock_key): Likewise.
6007 * w32menu.c (add_menu_item): Likewise.
6008 (w32_menu_display_help): Use XIL instead of checking
6009 USE_LISP_UNION_TYPE.
6010 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
6011 (init_heap): Likewise.
6012 * w32term.c (w32_read_socket): Update comment.
6013
1d3823c9
GM
60142012-06-13 Glenn Morris <rgm@gnu.org>
6015
c62ff706
GM
6016 * s/usg5-4-common.h, src/s/unixware.h:
6017 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
6018
1d3823c9
GM
6019 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
6020
bfe3e0a2
PE
60212012-06-13 Paul Eggert <eggert@cs.ucla.edu>
6022
6023 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
6024 * alloc.c (make_number) [!defined make_number]:
6025 Remove, as lisp.h always defines this now.
6026 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
6027 (roundup_size): Verify that it is a power of 2.
6028 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
6029 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
6030 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
6031 -DUSE_LSB_TAG=0, to override the automatically-selected default.
6032 USE_LSB_TAG now is always defined to be either 0 or 1.
6033 All uses changed.
6034 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
6035 code works fine either way, and efficiency is not a concern here,
6036 as the union type is for debugging, not for production.
6037 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
6038 Use an inline function on all platforms when using the union type,
6039 since this is simpler and 'static inline' can be used portably
6040 within Emacs now.
6041 (LISP_INITIALLY_ZERO): New macro.
6042 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
6043 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
6044
45fa9c0f
GM
60452012-06-12 Glenn Morris <rgm@gnu.org>
6046
b4492cba
GM
6047 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
6048
6049 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 6050
45fa9c0f
GM
6051 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
6052 Move BROKEN_SIGIO to configure.
6053
6054 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
6055 Move NO_TERMIO to configure.
6056
0e25d334
CY
60572012-06-12 Chong Yidong <cyd@gnu.org>
6058
6059 * image.c (imagemagick_load_image): Use MagickFlattenImage if
6060 MagickMergeImageLayers is undefined. Use pixel pusher loop if
6061 MagickExportImagePixels is undefined.
6062
43682bb6
PE
60632012-06-12 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 * image.c (imagemagick_load_image): Remove unused label.
6066
a9be7d2b
GM
60672012-06-11 Glenn Morris <rgm@gnu.org>
6068
6069 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
6070 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
6071 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
6072 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
6073
3017f87f
SM
60742012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
6075
6076 * alloc.c (make_byte_code): New function.
6077 (Fmake_byte_code): Use it. Don't purify here.
6078 * lread.c (read1): Use it as well to avoid extra allocation.
6079
1b9b4cf4
CY
60802012-06-11 Chong Yidong <cyd@gnu.org>
6081
6082 * image.c (imagemagick_load_image): Implement transparency.
6083
95988fcf
AS
60842012-06-10 Andreas Schwab <schwab@linux-m68k.org>
6085
6086 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
6087 account for preceding backslashes. (Bug#11663)
6088
cd4eb164
CY
60892012-06-09 Chong Yidong <cyd@gnu.org>
6090
6091 * term.c: Support italics in capable terminals (Bug#9652).
6092 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
6093 (turn_on_face): Output using TS_enter_italic_mode if available.
6094 Don't handle unused blinking and alt-charset cases.
6095 (turn_off_face): Handle italic case; discard unused tty_blinking_p
6096 and tty_alt_charset_p cases.
6097 (tty_capable_p, init_tty): Support italics.
6098
6099 * termchar.h (struct tty_display_info): Add field for italics.
6100 Remove unused blink field.
6101
6102 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
6103 Handle slant.
6104
6105 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
6106 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
6107 tty_alt_charset_p. Add tty_italic_p.
6108
ff88beb8
MA
61092012-06-09 Michael Albinus <michael.albinus@gmx.de>
6110
6111 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
6112 dbus_type_is_basic if available.
6113 (xd_extract_signed, xd_extract_unsigned): Rename from
6114 extract_signed and extract_unsigned, respectively. Adapt callers.
6115
44286096
CY
61162012-06-09 Chong Yidong <cyd@gnu.org>
6117
1682701f
CY
6118 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
6119
44286096
CY
6120 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
6121 case (Bug#9752).
6122
d86feb17
PE
61232012-06-08 Paul Eggert <eggert@cs.ucla.edu>
6124
6125 * xdisp.c (vmessage): Treat frame message as multibyte.
6126 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
6127 would generate the diagnostic "Making \302\247 buffer-local while
6128 let-bound!".
6129
d5c20fe8
EZ
61302012-06-08 Eli Zaretskii <eliz@gnu.org>
6131
6132 * dispnew.c (showing_window_margins_p): Undo last change, which
6133 was done due to an inadvertent commit.
6134 (adjust_frame_glyphs_for_frame_redisplay): Do call
6135 showing_window_margins_p.
6136
513749ee
SM
61372012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6138
6139 * eval.c (Fmake_var_non_special): New primitive.
6140 (syms_of_eval): Defsubr it.
6141 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
6142
d4a8f5c1
JB
61432012-06-08 Juanma Barranquero <lekktu@gmail.com>
6144
6145 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
6146 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
6147
8bbbc977
EZ
61482012-06-08 Eli Zaretskii <eliz@gnu.org>
6149
6150 * alloc.c (allocate_vectorlike): Fix last change.
6151
f3372c87
DA
61522012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
6153
6154 Block-based vector allocation of small vectors.
6155 * lisp.h (struct vectorlike_header): New field `nbytes',
6156 adjust comment accordingly.
6157 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 6158 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
6159 mark_maybe_pointer, valid_lisp_object_p) accordingly.
6160 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
6161 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
6162 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
6163 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
6164 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
6165 (roundup_size): New constant.
6166 (struct vector_block): New data type.
6167 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 6168 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
6169 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
6170 (sweep_vectors): New functions.
6171 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 6172 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
6173 or equal to VBLOCK_BYTES_MAX.
6174 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
6175 (init_alloc_once): Add call to init_vectors.
6176
4f18a4ed
SM
61772012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6178
6179 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
6180
86f158bc
PE
61812012-06-07 Paul Eggert <eggert@cs.ucla.edu>
6182
6183 * doprnt.c (doprnt): Truncate multibyte char correctly.
6184 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
6185 would mishandle a string argument "Xc" if X was a multibyte
6186 character of length 2: it would truncate after X's first byte
6187 rather than including all of X.
6188
c5cfcbe0
CY
61892012-06-06 Chong Yidong <cyd@gnu.org>
6190
6191 * buffer.c (word_wrap): Doc fix.
6192
c05cf390
PE
61932012-06-04 Paul Eggert <eggert@cs.ucla.edu>
6194
6195 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
6196
0c3461de
GM
61972012-06-03 Glenn Morris <rgm@gnu.org>
6198
6199 * xdisp.c (tool-bar-style): Doc fix.
6200
c71232db
UM
62012012-06-03 Ulrich Müller <ulm@gentoo.org>
6202
6203 * Makefile.in (PAXCTL): Define.
6204 (temacs$(EXEEXT)): Disable memory randomization for the temacs
6205 binary via PaX flags if the paxctl utility is available.
6206 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
6207 Restore PaX flags to their default. (Bug#11398)
6208
383f7350
CY
62092012-06-03 Chong Yidong <cyd@gnu.org>
6210
6211 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
6212 buffer (Bug#11226).
6213
5f2c76c6
CY
62142012-06-03 Chong Yidong <cyd@gnu.org>
6215
6216 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
6217 (note_mode_line_or_margin_highlight): If there is no help echo,
6218 use mode-line-default-help-echo. Handle the case where the mouse
6219 position is past the end of the mode line string.
6220
6221 * buffer.c (buffer_local_value_1): New function, split from
6222 Fbuffer_local_value; can return Qunbound.
6223 (Fbuffer_local_value): Use it.
6224 (Vmode_line_format): Docstring tweaks.
6225
773d47f6
PE
62262012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6227
6228 * sysdep.c (system_process_attributes): Improve comment.
6229
f2d6a3df
SM
62302012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
6231
6232 * keyboard.c: Export real-this-command to Elisp.
6233 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
6234 and DEFVAR it. Update all users.
6235
63810350
PE
62362012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6237
7bd5c1f4
PE
6238 * minibuf.c (Fassoc_string): Remove duplicate declaration.
6239
63810350
PE
6240 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
6241 Convert pctcpu and pctmem to Lisp float properly.
6242 Let the compiler fold better, as 100.0/0x8000 is exact.
6243
a2821611
AS
62442012-06-02 Andreas Schwab <schwab@linux-m68k.org>
6245
6246 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
6247 cons_block.
6248
5fceba1d
PE
62492012-06-01 Paul Eggert <eggert@cs.ucla.edu>
6250
6251 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
6252
c98ff5dd
DA
62532012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
6254
6255 For a 'struct window', replace some Lisp_Object fields to
6256 bitfields where appropriate, remove unused fields.
6257 * window.h (struct window): Remove unused 'last_mark_x' and
6258 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
6259 change it's type from Lisp_Object to bitfield.
6260 Change type of 'force_start', 'optional_new_start',
6261 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 6262 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 6263
ca34e0be
PE
62642012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6265
6266 Pacify gcc -Wdouble-precision when using Xaw.
6267 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
6268 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
6269 Use 'float' consistently, rather than 'float' in most places
6270 and 'double' in a couple of places.
6271
efc00ab1 62722012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
6273
6274 * xdisp.c (handle_stop): Detect whether we have overlay strings
6275 loaded by testing it->current.overlay_string_index to be
6276 non-negative, instead of checking whether n_overlay_strings is
6277 positive. (Bug#11587)
6278
efc00ab1 62792012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
6280
6281 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
6282
6283 * doc.c (Fsubstitute_command_keys): Doc fix.
6284
efc00ab1 62852012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
6286
6287 * search.c (search_buffer): Remove calls to
6288 r_alloc_inhibit_buffer_relocation, as it is now called by
6289 maybe_unify_char, which was the cause of relocation of buffer text
6290 in bug#11519.
6291
efc00ab1 62922012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
6293
6294 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
6295 for the duration of call to load_charset, to avoid problems with
6296 callers of maybe_unify_char that access buffer text through C
6297 pointers.
6298
6299 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
6300 decrement the inhibition flag, instead of just setting or
6301 resetting it.
6302
ba93a187
PE
63032012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6304
6305 Remove obsolete '#define static' cruft.
6306 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
6307 This #undef was "temporary" in 2000; it is no longer needed
6308 now that '#define static' has gone away.
6309 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
6310 (gray_bitmap_bits): Remove; no longer needed.
6311 All uses replaced with definiens.
6312 * xterm.c: Include "bitmaps/gray.xbm".
6313
9e4bf381
PE
63142012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6315
6316 Clean up __executable_start, monstartup when --enable-profiling.
6317 The following changes affect the code only when profiling.
6318 * dispnew.c (__executable_start): Rename from safe_bcopy.
6319 Define only on platforms that need it.
6320 * emacs.c: Include <sys/gmon.h> when profiling.
6321 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
6322 (__executable_start): Remove decl, since lisp.h does it now.
6323 (safe_bcopy): Remove decl; no longer has that name.
6324 (main): Coalesce #if into single bit of code, for simplicity.
6325 Cast pointers to uintptr_t, since standard libraries want integers
6326 and not pointers.
6327 * lisp.h (__executable_start): New decl.
6328
32d72c2f
GM
63292012-05-31 Glenn Morris <rgm@gnu.org>
6330
6331 * image.c (Fimagemagick_types): Doc fix.
6332
baac5bc7
JM
63332012-05-30 Jim Meyering <meyering@redhat.com>
6334
6335 * callproc.c (Fcall_process_region): Include directory component
6336 in mkstemp error message (Bug#11586).
6337
72cb32cf
PE
63382012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6339
6340 * alloc.c, lisp.h (make_pure_vector): Now static.
6341
61b108cc
SM
63422012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
6343
6344 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
6345 Move to byte-run.el.
6346 (Fautoload): Do the hash-doc more carefully.
6347 * data.c (Fdefalias): Purify definition, except for keymaps.
6348 (Qdefun): Move from eval.c.
6349 * lisp.h (Qdefun): Remove.
6350 * lread.c (read1): Tiny simplification.
6351
471fe23d
TN
63522012-05-29 Troels Nielsen <bn.troels@gmail.com>
6353
934f3f58 6354 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
6355 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
6356 Bug#9642, but explicitly check that the buffer the overlay would
6357 be moved to is live and rearrange lines to make sure that errors
6358 will not put the overlay in an inconsistent state.
6359 (Fdelete_overlay): Cosmetics.
6360
85d0efd1
EZ
63612012-05-28 Eli Zaretskii <eliz@gnu.org>
6362
6363 * w32term.c (my_bring_window_to_top): New function.
6364 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
6365 could be different from the original one.
6366 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
6367 (Bug#11513)
6368
6369 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
6370 by calling BringWindowToTop.
6371
6372 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
6373 (WM_EMACS_END): Increase by one.
6374
da92a98c
PE
63752012-05-28 Paul Eggert <eggert@cs.ucla.edu>
6376
6377 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
6378 This avoids undefined behavior that might cause the eassert
6379 to not catch an out-of-range value.
6380
74d1f848
JB
63812012-05-28 Juanma Barranquero <lekktu@gmail.com>
6382
6383 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
6384 Update dependencies.
6385
9e1a06fc
EZ
63862012-05-27 Eli Zaretskii <eliz@gnu.org>
6387
6388 * bidi.c (bidi_mirror_char): Fix last change.
6389
f3dd7312
AS
63902012-05-27 Andreas Schwab <schwab@linux-m68k.org>
6391
6392 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
6393 when referring to sectname field in printf format.
6394
81899c91
PE
63952012-05-27 Paul Eggert <eggert@cs.ucla.edu>
6396
57b81a9f
PE
6397 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
6398 Only r_alloc_inhibit_buffer_relocation needed to be added;
6399 the others were already declared.
6400
81899c91
PE
6401 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
6402 before checking whether it's out of range. Put the check inside
6403 eassert. See
6404 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
6405
33017faf 64062012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
6407
6408 * callproc.c (Fcall_process): Restore a line that was accidentally
6409 commented out in the 2011-02-13 change (bug#11547).
6410
33017faf 64112012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
6412
6413 * lisp.h [REL_ALLOC]: Add prototypes for external functions
6414 defined on ralloc.c.
6415
6416 * buffer.c [REL_ALLOC]: Remove prototypes of
6417 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
6418 they are now on lisp.h.
6419
6420 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
6421
6422 * search.c (search_buffer): Use it to inhibit relocation of buffer
6423 text while re_search_2 is doing its job, because re_search_2 is
6424 passed C pointers to buffer text. (Bug#11519)
6425
23415acf
EZ
6426 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
6427 Update value to 24.
6428
44e27368
EZ
6429 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
6430 state after an additional call to move_it_in_display_line_to, keep
6431 the values of it->max_ascent and it->max_descent found for the
6432 entire line.
6433 (pos_visible_p): Revert the comparison against bottom_y to what it
6434 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
6435 (Bug#11464)
6436
c1892f11
PE
64372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
6438
6439 Fix coding-related core dumps with gcc -ftrapv.
6440 The code was computing A - B, where A and B are pointers, and B is
6441 random garbage. This can lead to core dumps on platforms that
6442 have special pointer registers, and it also leads to core dumps on
6443 x86-64 when compiled with gcc -ftrapv. The fix is to compute
6444 A - B only when B is initialized properly.
6445 * coding.c (coding_set_source, coding_set_destination): Return void.
6446 (coding_change_source, coding_change_destinations): New functions,
6447 with the old behaviors of coding_set_source and coding_set_destination.
6448 All callers that need an offset changed to use these new functions.
6449
eb7afdad
GM
64502012-05-26 Glenn Morris <rgm@gnu.org>
6451
6452 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
6453
f12fdf02
EZ
64542012-05-26 Eli Zaretskii <eliz@gnu.org>
6455
53a63be6 6456 Extend mouse support on W32 text-mode console.
61b108cc
SM
6457 * xdisp.c (draw_row_with_mouse_face):
6458 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 6459
eb3f6f01 6460 * w32console.c: Include window.h.
61b108cc
SM
6461 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
6462 New functions.
eb3f6f01
EZ
6463 (initialize_w32_display): Initialize mouse-highlight data.
6464
53a63be6
EZ
6465 * w32inevt.c: Include termchar.h and window.h.
6466 (do_mouse_event): Support mouse-autoselect-window. When the mouse
6467 moves, call note_mouse_highlight. If help_echo changed, call
6468 gen_help_event to produce help-echo message in the echo area.
6469 Call clear_mouse_face if mouse_face_hidden is set in the mouse
6470 highlight info.
6471
4cfd81f6
PE
64722012-05-26 Paul Eggert <eggert@cs.ucla.edu>
6473
6474 * lread.c (read1): Simplify slightly to avoid an overflow warning
6475 with GCC 4.7.0 on x86-64.
6476
4446092a
EZ
64772012-05-26 Eli Zaretskii <eliz@gnu.org>
6478
6479 * bidi.c (bidi_mirror_char): Revert last change: an int is
6480 definitely wide enough here.
6481
42b2a986 64822012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 6483
42b2a986 6484 Fix integer width and related bugs (Bug#9874).
eb106a49 6485 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
6486 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6487 (string_bytes, check_sblock, allocate_string_data):
6488 (compact_small_strings, Fmake_bool_vector, make_string)
6489 (make_unibyte_string, make_multibyte_string)
6490 (make_string_from_bytes, make_specified_string)
6491 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
6492 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
6493 (mark_vectorlike):
6494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6495 (allocate_pseudovector):
6496 Use int, not EMACS_INT, where int is wide enough.
6497 (inhibit_garbage_collection, Fgarbage_collect):
6498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6499 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
6500 int might not be wide enough.
6501 (bidi_cache_search, bidi_cache_find, bidi_init_it)
6502 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
6503 (bidi_at_paragraph_end, bidi_find_paragraph_start)
6504 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6505 (bidi_level_of_next_char, bidi_move_to_visually_next):
6506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6507 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
6508 (Fkill_buffer, Fset_buffer_major_mode)
6509 (advance_to_char_boundary, Fbuffer_swap_text)
6510 (Fset_buffer_multibyte, overlays_at, overlays_in)
6511 (overlay_touches_p, struct sortvec, record_overlay_string)
6512 (overlay_strings, recenter_overlay_lists)
6513 (adjust_overlays_for_insert, adjust_overlays_for_delete)
6514 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
6515 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
6516 (Foverlay_recenter, last_overlay_modification_hooks_used)
6517 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
6518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
6519 (validate_region): Omit unnecessary test for b <= e,
6520 since that's guaranteed by the previous test.
d311d28c
PE
6521 (adjust_overlays_for_delete): Avoid pos + length overflow.
6522 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
6523 (report_overlay_modification):
6524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6525 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
6526 Omit pointer cast, which isn't needed anyway, and doesn't work
6527 after the EMACS_INT -> ptrdiff_t change.
02481186 6528 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
6529 * buffer.h: Adjust decls to match defn changes elsewhere.
6530 (struct buffer_text, struct buffer):
6531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6532 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
6533 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
6534 not int, to avoid needless 32-bit limit on 64-bit hosts.
6535 (exec_byte_code): Use tighter memory-full test, one that checks
6536 for alloca overflow. Don't compute the address of the object just
6537 before an array, as that's not portable. Use EMACS_INT, not
6538 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
6539 * callint.c (Fcall_interactively):
6540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6541 * callproc.c (call_process_kill, Fcall_process):
6542 Don't assume pid_t fits into an Emacs fixnum.
6543 (call_process_cleanup, Fcall_process, child_setup):
6544 Don't assume pid_t fits into int.
6545 (call_process_cleanup, Fcall_process, delete_temp_file)
6546 (Fcall_process_region):
6547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6548 (Fcall_process): Simplify handling of volatile integers.
6549 Use int, not EMACS_INT, where int will do.
6550 * casefiddle.c (casify_object, casify_region, operate_on_word)
6551 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
6552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6553 (casify_object): Avoid integer overflow when overallocating buffer.
6554 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 6555 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
6556 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
6557 * category.h (CATEGORYP): Don't assume arg is nonnegative.
6558 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
6559 integers are now checked earlier. All uses replaced with XINT.
6560 (ccl_driver):
6561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6562 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
6563 (ccl_driver, Fregister_code_conversion_map):
6564 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
6565 (resolve_symbol_ccl_program): Check that vector header is in range.
6566 Always copy the vector, so that we can check its contents reliably
6567 now rather than having to recheck each instruction as it's being
6568 executed. Check that vector words fit in 'int'.
6569 (ccl_get_compiled_code, Fregister_ccl_program)
6570 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
6571 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
6572 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
6573 contents are in range.
6574 (Fccl_execute_on_string): Check that status is in range.
6575 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
6576 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
6577 Accept and return EMACS_INT, not int, because callers can pass values
6578 out of 'int' range.
6579 (c_string_width, strwidth, lisp_string_width, chars_in_text)
6580 (multibyte_chars_in_text, parse_str_as_multibyte)
6581 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
6582 (str_as_unibyte, str_to_unibyte, string_count_byte8)
6583 (string_escape_byte8, Fget_byte):
6584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 6585 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
6586 avoid mishandling large integers.
6587 * character.h: Adjust decls to match defn changes elsewhere.
6588 * charset.c (load_charset_map_from_file, find_charsets_in_text)
6589 (Ffind_charset_region):
6590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6591 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
6592 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 6593 Don't assume fixnum fits in int.
d311d28c
PE
6594 (load_charset_map_from_vector, Fmap_charset_chars):
6595 Remove now-unnecessary CHECK_NATNUMs.
6596 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
6597 Don't rely on undefined behavior with signed left shift overflow.
6598 Don't assume unsigned int fits into fixnum, or that fixnum fits
6599 into unsigned int. Don't require max_code to be a valid fixnum;
6600 that's not true for gb10830 4-byte on a 32-bit host. Allow
6601 invalid_code to be a cons, for the same reason. Require code_offset
6602 to be a character. Avoid int overflow if max_char is close
6603 to INT_MAX.
6604 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
6605 this is intended anyway and avoids some undefined behavior.
6606 (load_charset_map): Pass unsigned, not int, as 2nd arg of
6607 INDEX_TO_CODE_POINT, as that's what it expects.
6608 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
6609 * charset.h (DECODE_CHAR): Return int, not unsigned;
6610 this is what was intended anyway, and it avoids undefined behavior.
6611 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
6612 integer-overflow issues.
6613 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
6614 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
6615 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
6616 * chartab.c (Fmake_char_table, Fset_char_table_range)
6617 (uniprop_get_decoder, uniprop_get_encoder):
6618 Don't assume fixnum fits in int.
6619 * cmds.c (move_point): New function, that does the gist of
6620 Fforward_char and Fbackward_char, but does so while checking
6621 for integer overflow more accurately.
c96e5d6a 6622 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
6623 (Fforward_line, Fend_of_line, internal_self_insert)
6624 (internal_self_insert):
6625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6626 Fix a FIXME, by checking for integer overflow when calculating
6627 target_clm and actual_clm.
6628 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 6629 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
6630 (ASSURE_DESTINATION, coding_alloc_by_realloc)
6631 (coding_alloc_by_making_gap, alloc_destination)
6632 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
6633 (encode_coding_utf_16, detect_coding_emacs_mule)
6634 (decode_coding_emacs_mule, encode_coding_emacs_mule)
6635 (detect_coding_iso_2022, decode_coding_iso_2022)
6636 (encode_invocation_designation, encode_designation_at_bol)
6637 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6638 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
6639 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
6640 (encode_coding_ccl, encode_coding_raw_text)
6641 (detect_coding_charset, decode_coding_charset)
6642 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
6643 (produce_composition, produce_charset, produce_annotation)
6644 (decode_coding, handle_composition_annotation)
6645 (handle_charset_annotation, consume_chars, decode_coding_gap)
6646 (decode_coding_object, encode_coding_object, detect_coding_system)
6647 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
6648 (code_convert_region, code_convert_string)
8f50130c
PE
6649 (Fdefine_coding_system_internal)
6650 (coding_set_source, coding_set_destination):
d311d28c
PE
6651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6652 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
6653 (Fdefine_coding_system_internal):
6654 Don't assume fixnums fit in int.
6655 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 6656 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
6657 (Funencodable_char_position, Fcheck_coding_systems_region)
6658 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 6659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 6660 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 6661 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 6662 Don't access memory outside of the args array.
d311d28c 6663 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
6664 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
6665 result of ENCODE_CHAR.
d311d28c
PE
6666 * coding.h: Adjust decls to match defn changes elsewhere.
6667 (struct coding_system):
6668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6669 * composite.c (get_composition_id, find_composition)
6670 (run_composition_function, update_compositions)
6671 (compose_text, composition_gstring_put_cache)
6672 (composition_gstring_p, composition_gstring_width)
6673 (fill_gstring_header, fill_gstring_body, autocmp_chars)
6674 (composition_compute_stop_pos, composition_reseat_it)
6675 (composition_update_it, struct position_record)
6676 (find_automatic_composition, composition_adjust_point)
6677 (Fcomposition_get_gstring, Ffind_composition_internal):
6678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6679 (update_compositions):
6680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6681 * composite.h: Adjust decls to match defn changes elsewhere.
6682 (struct composition):
6683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6684 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
6685 Do not attempt to compute the address of the object just before a
6686 buffer; this is not portable.
6687 (Faref, Faset):
6688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6689 (Faset): Use int, not EMACS_INT, where int is wide enough.
6690 (Fstring_to_number): Don't assume fixnums fit in int.
6691 (Frem): Don't assume arg is nonnegative.
6692 * dbusbind.c (xd_append_arg): Check for integers out of range.
6693 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 6694 (extract_signed, extract_unsigned): New functions.
243e0530
PE
6695 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
6696 (xd_get_connection_references): Return ptrdiff_t, not int.
6697 All uses changed.
6698 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
6699 (xd_read_message_1):
6700 Use int, not unsigned, where the dbus API uses int.
6701 (Fdbus_message_internal): Don't overflow mtype.
6702 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
6703 * dired.c (directory_files_internal, file_name_completion, scmp)
6704 (file_name_completion_stat):
6705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6706 (file_name_completion): Don't overflow matchcount.
6707 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
6708 * dispextern.h: Adjust decls to match defn changes elsewhere.
6709 (struct text_pos, struct glyph, struct bidi_saved_info)
6710 (struct bidi_string_data, struct bidi_it, struct composition_it)
6711 (struct it):
6712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6713 (struct display_pos, struct composition_it, struct it):
6714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6715 * dispnew.c (increment_matrix_positions)
6716 (increment_row_positions, mode_line_string)
6717 (marginal_area_string):
6718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 6719 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
6720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6721 (duration_to_sec_usec): New function, to check for overflow better.
6722 (Fsleep_for, sit_for): Use it.
6723 * doc.c (get_doc_string, store_function_docstring):
6724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6725 (get_doc_string, Fsnarf_documentation):
6726 Use int, not EMACS_INT, where int is wide enough.
6727 (get_doc_string):
6728 Use SAFE_ALLOCA, not alloca.
6729 Check for overflow when converting EMACS_INT to off_t.
6730 * doprnt.c (doprnt):
6731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6732 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
6733 Don't assume uid_t fits into fixnum.
6734 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
6735 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
6736 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
6737 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
6738 (general_insert_function)
6739 (Finsert_char, make_buffer_string, make_buffer_string_both)
6740 (update_buffer_properties, Fbuffer_substring)
6741 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
6742 (Fsubst_char_in_region, check_translation)
6743 (Ftranslate_region_internal, save_restriction_restore, Fformat)
6744 (transpose_markers, Ftranspose_regions):
6745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6746 (clip_to_bounds): Move to lisp.h as an inline function).
6747 (Fconstrain_to_field): Don't assume integers are nonnegative.
6748 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
6749 (Fsubst_char_in_region, Fsave_restriction):
6750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6751 (Femacs_pid): Don't assume pid_t fits into fixnum.
6752 (lo_time): Use int, not EMACS_INT, when int suffices.
6753 (lisp_time_argument): Check for usec out of range.
6754 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
6755 (Fuser_login_name, Fuser_full_name): Signal an error
6756 if a uid argument is out of range, rather than relying on
6757 undefined behavior.
c8d5c857
PE
6758 (Fformat_time_string): Remove now-unnecessary check.
6759 lisp_time_argument checks for out-of-range usec now.
243e0530 6760 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
6761 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
6762 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
6763 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
6764 (init_cmdargs, Fdump_emacs):
6765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6766 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
6767 the bottom (typically) 32 bits of the fixnum.
6768 * eval.c (specpdl_size, call_debugger):
6769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6770 (when_entered_debugger, Fbacktrace_debug):
6771 Don't assume fixnum can fit in int.
6772 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
6773 the object just before a buffer; this is not portable.
6774 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
6775 (grow_specpdl, unbind_to):
6776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6777 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
6778 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 6779 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
6780 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
6781 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
6782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6783 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
6784 (a_write, e_write):
6785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6786 (Fcopy_file, non_regular_nbytes, read_non_regular)
6787 (Finsert_file_contents):
6788 Use int, not EMACS_INT, where int is wide enough.
6789 (READ_BUF_SIZE): Verify that it fits in int.
6790 (Finsert_file_contents): Check that counts are in proper range,
6791 rather than assuming fixnums fit into ptrdiff_t etc.
6792 Don't assume fixnums fit into int.
125b3835 6793 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
6794 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
6795 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
6796 (string_char_to_byte, string_byte_to_char)
6797 (string_make_multibyte, string_to_multibyte)
6798 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
6799 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
6800 (substring_both, Fdelete, internal_equal, Ffillarray)
6801 (Fclear_string, mapcar1)
6802 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
6803 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
6804 (larger_vector, make_hash_table, maybe_resize_hash_table)
6805 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
6806 (Fmaphash, secure_hash):
6807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6808 (concat): Check for string index and length overflow.
6809 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
6810 (Frequire):
6811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6812 (larger_vector): New API (vec, incr_min, size_max) replaces old
6813 one (vec, new_size, init). This catches size overflow.
6814 INIT was removed because it was always Qnil.
6815 All callers changed.
6816 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
6817 the upper bound on a hash table index size.
6818 (make_hash_table, maybe_resize_hash_table): Use it.
6819 (secure_hash): Computer start_byte and end_byte only after
6820 they're known to be in ptrdiff_t range.
6821 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
6822 (Ffont_get_glyphs, Ffont_at):
6823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6824 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
6825 (Flist_fonts, Fopen_font):
6826 Don't assume fixnum can fit in int.
6827 (check_gstring): Don't assume index can fit in int.
6828 (font_match_p): Check that fixnum is a character, not a nonnegative
6829 fixnum, since the later code needs to stuff it into an int.
6830 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
6831 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
6832 conversion overflow issues.
6833 (Fopen_font): Check for integer out of range.
6834 (Ffont_get_glyphs): Don't assume index can fit in int.
6835 * font.h: Adjust decls to match defn changes elsewhere.
6836 * fontset.c (reorder_font_vector): Redo score calculation to avoid
6837 integer overflow.
6838 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
6839 printmax_t, where ptrdiff_t is wide enough.
6840 (Finternal_char_font):
6841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6842 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
6843 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
6844 (Fset_frame_position, x_set_frame_parameters)
6845 (x_set_line_spacing, x_set_border_width)
6846 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
6847 Check that fixnums are in proper range for system types.
6848 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
6849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6850 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
6851 Use SAFE_ALLOCA_LISP, not alloca.
6852 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
6853 intptr_t is wide enough.
6854 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
6855 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
6856 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
6857 Check for fixnum out of range.
6858 * ftfont.c (ftfont_list): Don't assume index fits in int.
6859 Check that fixnums are in proper range for system types.
6860 (ftfont_shape_by_flt):
6861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
6862 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6864 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
6865 Check that fixnums are in proper range for system types.
6866 * gnutls.h: Adjust decls to match defn changes elsewhere.
6867 * gtkutil.c (xg_dialog_run):
6868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6869 (update_frame_tool_bar):
6870 Check that fixnums are in proper range for system types.
6871 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 6872 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
6873 * indent.c (last_known_column, last_known_column_point):
6874 (current_column_bol_cache):
6875 (skip_invisible, current_column, check_display_width):
6876 (check_display_width, scan_for_column, current_column_1)
6877 (Findent_to, Fcurrent_indentation, position_indentation)
6878 (indented_beyond_p, Fmove_to_column, compute_motion):
6879 (Fcompute_motion, Fvertical_motion):
6880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6881 (last_known_column_modified): Use EMACS_INT, not int.
6882 (check_display_width):
6883 (Fcompute_motion):
6884 Check that fixnums and floats are in proper range for system types.
6885 (compute_motion): Don't assume index or fixnum fits in int.
6886 (compute_motion, Fcompute_motion):
6887 Use int, not EMACS_INT, when it is wide enough.
6888 (vmotion): Omit local var start_hpos that is always 0; that way
6889 we don't need to worry about overflow in expressions involving it.
6890 * indent.h: Adjust decls to match defn changes elsewhere.
6891 (struct position):
6892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6893 Use int, not EMACS_INT, where int is wide enough.
6894 Remove unused members ovstring_chars_done and tab_offset;
6895 all uses removed.
6896 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
6897 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
6898 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
6899 (make_gap, copy_text, insert, insert_and_inherit)
6900 (insert_before_markers, insert_before_markers_and_inherit)
6901 (insert_1, count_combining_before, count_combining_after)
6902 (insert_1_both, insert_from_string)
6903 (insert_from_string_before_markers, insert_from_string_1)
6904 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
6905 (adjust_after_replace, adjust_after_insert, replace_range)
6906 (replace_range_2, del_range, del_range_1, del_range_byte)
6907 (del_range_both, del_range_2, modify_region)
6908 (prepare_to_modify_buffer, signal_before_change)
6909 (signal_after_change, Fcombine_after_change_execute):
6910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6911 * intervals.c (traverse_intervals, rotate_right, rotate_left)
6912 (balance_an_interval, split_interval_right, split_interval_left)
6913 (find_interval, next_interval, update_interval)
6914 (adjust_intervals_for_insertion, delete_node, delete_interval)
6915 (interval_deletion_adjustment, adjust_intervals_for_deletion)
6916 (static_offset_intervals, offset_intervals)
6917 (merge_interval_right, merge_interval_left, make_new_interval)
6918 (graft_intervals_into_buffer, temp_set_point_both)
6919 (temp_set_point, set_point, adjust_for_invis_intang)
6920 (set_point_both, move_if_not_intangible, get_property_and_range)
6921 (get_local_map, copy_intervals, copy_intervals_to_string)
6922 (compare_string_intervals, set_intervals_multibyte_1):
6923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6924 * intervals.h: Adjust decls to match defn changes elsewhere.
6925 (struct interval):
6926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6927 * keyboard.c (this_command_key_count, this_single_command_key_start)
6928 (before_command_key_count, before_command_echo_length, echo_now)
6929 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
6930 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
6931 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
6932 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
6933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6934 (last_non_minibuf_size, last_point_position, echo_truncate)
6935 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
6936 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
6937 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
6938 (stuff_buffered_input):
6939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6940 (last_auto_save, command_loop_1, read_char):
6941 Use EMACS_INT, not int, to avoid integer overflow.
6942 (record_char): Avoid overflow in total_keys computation.
6943 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
6944 * keyboard.h: Adjust decls to match defn changes elsewhere.
6945 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
6946 (Fkey_description, Fdescribe_vector, Flookup_key):
6947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6948 (click_position): New function, to check that positions are in range.
6949 (Fcurrent_active_maps):
6950 (describe_command):
6951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6952 (Faccessible_keymaps, Fkey_description):
6953 (preferred_sequence_p):
6954 Don't assume fixnum can fit into int.
6955 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
6956 Check for integer overflow in size calculations.
6957 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
6958 avoid mishandling large integers.
6959 * lisp.h: Adjust decls to match defn changes elsewhere.
6960 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
6961 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
6962 (struct Lisp_Marker):
6963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6964 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
6965 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
6966 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
6967 All callers changed.
6968 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
6969 Assume the arg has valid form, since it always does.
6970 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
6971 unsigned integer system type.
6972 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
6973 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
6974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6975 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
6976 (duration_to_sec_usec): New decl.
6977 * lread.c (read_from_string_index, read_from_string_index_byte)
6978 (read_from_string_limit, readchar, unreadchar, openp)
6979 (read_internal_start, read1, oblookup):
6980 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6981 (Fload, readevalloop, Feval_buffer, Feval_region):
6982 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6983 (openp): Check for out-of-range argument to 'access'.
6984 (read1): Use int, not EMACS_INT, where int is wide enough.
6985 Don't assume fixnum fits into int.
6efdadfd 6986 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
6987 (read_filtered_event): Use duration_to_sec_usec
6988 to do proper overflow checking on durations.
d311d28c
PE
6989 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
6990 in size calculation.
6991 (Fexecute_kbd_macro):
6992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6993 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
6994 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
6995 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
6996 (set_marker_both, set_marker_restricted_both, marker_position)
6997 (marker_byte_position, Fbuffer_has_markers_at):
6998 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6999 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 7000 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
7001 It now merely ensures that the menu is large enough, without
7002 necessarily growing it, as this avoids some integer overflow issues.
7003 All callers changed.
7004 (keymap_panes, parse_single_submenu, Fx_popup_menu):
7005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7006 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
7007 Use SAFE_ALLOCA_LISP, not alloca.
7008 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
7009 to EMACS_INT. Check that fixnums are in proper range for system types.
7010 * minibuf.c (minibuf_prompt_width, string_to_object)
7011 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
7012 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
7013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7014 (get_minibuffer, read_minibuf_unwind):
7015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7016 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
7017 this simplifies overflow checking. All callers changed.
7018 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
7019 (Ftest_completion):
7020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7021 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
7022 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
7023 Check that fixnums are in proper range for system types.
7024 (Fx_create_frame, Fx_show_tip):
7025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7026 * nsfont.m (ns_findfonts, nsfont_list_family):
7027 Don't assume fixnum fits in long.
7028 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
7029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7030 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
7031 wide enough.
17fdb222 7032 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
7033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7034 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
7035 (PRINTDECLARE, PRINTPREPARE):
7036 (strout, print_string):
7037 (print, print_preprocess, print_check_string_charset_prop)
7038 (print_object):
7039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7040 (PRINTDECLARE):
7041 (temp_output_buffer_setup, Fprin1_to_string, print_object):
7042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7043 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 7044 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 7045 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
7046 (print_error_message): Use SAFE_ALLOCA, not alloca.
7047 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
7048 (print_depth, new_backquote_output, print_number_index):
7049 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
7050 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
7051 (Fset_process_window_size, Fformat_network_address)
7052 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 7053 (sigchld_handler):
d311d28c 7054 Check that fixnums are in proper range for system types.
d44287d4 7055 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
7056 Check for process-ids out of pid_t range rather than relying on
7057 undefined behavior.
e4d81efc 7058 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
7059 (Fformat_network_address, read_process_output, send_process)
7060 (Fprocess_send_region, status_notify):
7061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7062 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
7063 (wait_reading_process_output, read_process_output, exec_sentinel):
7064 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7065 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
7066 (Faccept_process_output): Use duration_to_sec_usec to do proper
7067 overflow checking on durations.
dde14581
PE
7068 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
7069 Don't assume pid_t fits in int.
02481186
PE
7070 * process.h (struct Lisp_Process): Members tick and update_tick
7071 are now of type EMACS_INT, not int.
b62b53e8
PE
7072 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
7073 configured --with-wide-int.
d311d28c
PE
7074 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
7075 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
7076 * search.c (looking_at_1, string_match_1):
7077 (fast_string_match, fast_c_string_match_ignore_case)
7078 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
7079 (scan_newline, find_before_next_newline, search_command)
7080 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
7081 (set_search_regs, wordify):
7082 (Freplace_match):
7083 (Fmatch_data):
7084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7085 (string_match_1, search_buffer, set_search_regs):
7086 (Fmatch_data):
7087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7088 (wordify): Check for overflow in size calculation.
7089 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
7090 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
7091 Check that fixnums are in proper range for system types.
7092 * sound.c (struct sound_device)
7093 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
7094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7095 (Fplay_sound_internal):
7096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 7097 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
7098 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
7099 (Fparse_partial_sexp):
7100 Don't assume fixnums can fit in int.
7101 (struct lisp_parse_state, find_start_pos, find_start_value)
7102 (find_start_value_byte, find_start_begv)
7103 (update_syntax_table, char_quoted, dec_bytepos)
7104 (find_defun_start, prev_char_comend_first, back_comment):
7105 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
7106 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
7107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7108 (Finternal_describe_syntax_value): Check that match_lisp is a
7109 character, not an integer, since the code stuffs it into int.
7110 (scan_words, scan_sexps_forward):
7111 Check that fixnums are in proper range for system types.
7112 (Fforward_word):
7113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7114 (scan_sexps_forward):
7115 Use CHARACTERP, not INTEGERP, since the value must fit into int.
7116 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
7117 * syntax.h: Adjust decls to match defn changes elsewhere.
7118 (struct gl_state_s):
7119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
7120 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
7121 MOST_POSITIVE_FIXNUM.
d311d28c
PE
7122 * sysdep.c (wait_for_termination_1, wait_for_termination)
7123 (interruptible_wait_for_termination, mkdir):
7124 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
7125 (emacs_read, emacs_write):
7126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
7127 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
7128 and double all fit in int.
d311d28c
PE
7129 * term.c (set_tty_color_mode):
7130 Check that fixnums are in proper range for system types.
7131 * termhooks.h (struct input_event):
7132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7133 * textprop.c (validate_interval_range, interval_of)
7134 (Fadd_text_properties, set_text_properties_1)
7135 (Fremove_text_properties, Fremove_list_of_text_properties)
7136 (Ftext_property_any, Ftext_property_not_all)
7137 (copy_text_properties, text_property_list, extend_property_ranges)
7138 (verify_interval_modification):
7139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7140 (Fnext_single_char_property_change)
7141 (Fprevious_single_char_property_change):
7142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
7143 (copy_text_properties):
7144 Check for integer overflow in index calculation.
d311d28c
PE
7145 * undo.c (last_boundary_position, record_point, record_insert)
7146 (record_delete, record_marker_adjustment, record_change)
7147 (record_property_change):
7148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7149 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
7150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7151 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7152 (Fx_hide_tip, Fx_file_dialog):
7153 * w32menu.c (set_frame_menubar):
7154 Use ptrdiff_t, not int, for consistency with rest of code.
7155 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
7156 (select_window, Fdelete_other_windows_internal)
7157 (window_scroll_pixel_based, window_scroll_line_based)
7158 (Frecenter, Fset_window_configuration):
7159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7160 (Fset_window_hscroll, run_window_configuration_change_hook)
7161 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 7162 (Fscroll_other_window, Frecenter):
d311d28c
PE
7163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7164 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
7165 Don't assume fixnum fits in int.
7166 (Fset_window_scroll_bars):
7167 Check that fixnums are in proper range for system types.
7168 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
7169 (string_pos, c_string_pos, number_of_chars, init_iterator)
7170 (in_ellipses_for_invisible_text_p, init_from_display_pos)
7171 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
7172 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
7173 (face_before_or_after_it_pos, handle_invisible_prop)
7174 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
7175 (display_prop_intangible_p, string_buffer_position_lim)
7176 (string_buffer_position, handle_composition_prop, load_overlay_strings)
7177 (get_overlay_strings_1, get_overlay_strings)
7178 (iterate_out_of_display_property, forward_to_next_line_start)
7179 (back_to_previous_visible_line_start, reseat, reseat_to_string)
7180 (get_next_display_element, set_iterator_to_next)
7181 (get_visually_first_element, compute_stop_pos_backwards)
7182 (handle_stop_backwards, next_element_from_buffer)
7183 (move_it_in_display_line_to, move_it_in_display_line)
7184 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7185 (add_to_log, message_dolog, message_log_check_duplicate)
7186 (message2, message2_nolog, message3, message3_nolog
7187 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
7188 (current_message_1, truncate_echo_area, truncate_message_1)
7189 (set_message, set_message_1, store_mode_line_noprop)
7190 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
7191 (text_outside_line_unchanged_p, check_point_in_composition)
7192 (reconsider_clip_changes)
7193 (redisplay_internal, set_cursor_from_row, try_scrolling)
7194 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
7195 (redisplay_window, find_last_unchanged_at_beg_row)
7196 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
7197 (trailing_whitespace_p, find_row_edges, display_line)
7198 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
7199 (display_mode_element, store_mode_line_string)
7200 (pint2str, pint2hrstr, decode_mode_spec)
7201 (display_count_lines, display_string, draw_glyphs)
7202 (x_produce_glyphs, x_insert_glyphs)
7203 (rows_from_pos_range, mouse_face_from_buffer_pos)
7204 (fast_find_string_pos, mouse_face_from_string_pos)
7205 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7207 (safe_call, init_from_display_pos, handle_fontified_prop)
7208 (handle_single_display_spec, load_overlay_strings)
7209 (with_echo_area_buffer, setup_echo_area_for_printing)
7210 (display_echo_area, echo_area_display)
7211 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
7212 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
7213 (redisplay_window, dump_glyph_row, display_mode_line)
7214 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 7215 (handle_display_spec, display_prop_string_p):
d311d28c
PE
7216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7217 (handle_single_display_spec, build_desired_tool_bar_string)
7218 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
7219 (get_specified_cursor_type):
7220 Check that fixnums are in proper range for system types.
7221 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
7222 (Flookup_image_map):
7223 Don't assume fixnums fit in int.
7224 (compare_overlay_entries):
7225 Avoid mishandling comparisons due to subtraction overflow.
7226 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
7227 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
7228 (handle_tool_bar_click):
7229 Use int, not unsigned, since we prefer signed and the signedness
7230 doesn't matter here.
7231 (get_next_display_element, next_element_from_display_vector):
7232 Use int, not EMACS_INT, when int is wide enough.
7233 (start_hourglass): Use duration_to_sec_usec to do proper
7234 overflow checking on durations.
7235 * xfaces.c (Fbitmap_spec_p):
7236 Check that fixnums are in proper range for system types.
7237 (compare_fonts_by_sort_order):
7238 Avoid mishandling comparisons due to subtraction overflow.
7239 (Fx_family_fonts, realize_basic_faces):
7240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7241 (Fx_family_fonts):
7242 Don't assume fixnum fits in int.
7243 Use SAFE_ALLOCA_LISP, not alloca.
7244 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
7245 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
7246 (face_at_buffer_position, face_for_overlay_string)
7247 (face_at_string_position):
7248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7249 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
7250 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
7251 (Fx_show_tip):
7252 Check that fixnums are in proper range for system types.
7253 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7254 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
7255 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7256 (Fx_change_window_property): Don't assume fixnums fit in int.
7257 * xfont.c (xfont_chars_supported):
7258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7259 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
7260 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
7261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7262 * xml.c (parse_region):
7263 * xrdb.c (magic_file_p):
7264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7265 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
7266 (x_get_local_selection, x_reply_selection_request)
7267 (x_handle_selection_request, wait_for_property_change):
7268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7269 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
7270 short is wide enough.
7271 (x_send_client_event): Don't assume fixnum fits in int.
7272 * xterm.c (x_x_to_emacs_modifiers):
7273 Don't assume EMACS_INT overflows nicely into int.
7274 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
7275 may come from Lisp.
7276 (handle_one_xevent): NATNUMP can eval its arg twice.
7277 (x_connection_closed):
7278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7279 * xterm.h: Adjust decls to match defn changes elsewhere.
7280 (struct scroll_bar): Use struct vectorlike_header
7281 rather than rolling our own approximation.
7282 (SCROLL_BAR_VEC_SIZE): Remove; not used.
7283
c6574eb5
GM
72842012-05-25 Glenn Morris <rgm@gnu.org>
7285
7286 * lisp.mk (lisp): Update for more files being compiled now.
7287
e8d32c7e
SM
72882012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
7289
48def666
SM
7290 * lread.c: Remove `read_pure' which makes no difference.
7291 (read_pure): Remove var.
7292 (unreadpure): Remove function.
7293 (readevalloop): Don't call read_list with -1 flag.
7294 (read1, read_vector): Don't test read_pure any more.
7295 (read_list): Simplify.
7296
e8d32c7e
SM
7297 * fileio.c, character.h: Minor style tweaks.
7298
4b2addb7
DA
72992012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
7300
7301 * window.h (clip_changed): Remove useless declaration.
7302
584461b2
JB
73032012-05-22 Juanma Barranquero <lekktu@gmail.com>
7304
7305 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
7306 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
7307
34374650
PE
73082012-05-22 Paul Eggert <eggert@cs.ucla.edu>
7309
7310 Remove src/m/*.
7311 This directory predates autoconf and is no longer needed nowadays.
7312 Move its few remaining bits of functionality to where they're needed.
7313 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
7314 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
7315 * m/template.h: Remove.
7316 * Makefile.in (M_FILE): Remove. All uses removed.
7317 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
7318 * lisp.h (USE_LSB_TAG):
7319 * mem-limits.h (EXCEEDS_LISP_PTR):
7320 Use VAL_MAX, not VALBITS, in #if.
7321 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
7322 (EMACS_UINT): Define unconditionally now.
7323 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
7324 (BITS_PER_EMACS_INT): New constants, replacing
7325 what used to be in config.h, but not useful in #if.
7326 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
7327 define them any more.
7328 (VAL_MAX): New macro.
7329 (VALMASK): Use it.
7330 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
7331 BITS_PER_EMACS_INT, in #if.
7332 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
7333 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
7334 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
7335 * s/ms-w32.h (DATA_START):
7336 Move here from removed file m/intel386.h.
7337 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
7338 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
7339
261cb4bb
PE
73402012-05-21 Paul Eggert <eggert@cs.ucla.edu>
7341
7342 Assume C89 or later.
7343 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
7344 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
7345 (xrealloc):
7346 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
7347 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
7348 * textprop.c, tparam.c (NULL): Remove.
7349 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
7350 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
7351 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
7352 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
7353 * xterm.c (input_signal_count): Assume volatile works.
7354
ff23cd9f
KB
73552012-05-21 Ken Brown <kbrown@cornell.edu>
7356
7357 * xgselect.c (xg_select): Fix first argument in call to 'select'
7358 (bug#11508).
7359
1b170bc6
KB
73602012-05-20 Ken Brown <kbrown@cornell.edu>
7361
7362 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 7363 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 7364
b2f4d39f
KB
73652012-05-19 Ken Brown <kbrown@cornell.edu>
7366
7367 * xfns.c (x_in_use): Remove `static' qualifier.
7368 * xterm.h (x_in_use): Declare.
7369 * xgselect.c: Include xterm.h.
7370 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
7371 and `display_arg' (bug#9754).
7372
003fdae2
PE
73732012-05-19 Paul Eggert <eggert@cs.ucla.edu>
7374
9232a6d9
PE
7375 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
7376
003fdae2
PE
7377 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
7378 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
7379
784b56e2
EZ
73802012-05-18 Eli Zaretskii <eliz@gnu.org>
7381
7382 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
7383
7384 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 7385 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
7386
7387 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
7388 reference to image_cache->refcount.
7389 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
7390
a0a79cde
JL
73912012-05-17 Juri Linkov <juri@jurta.org>
7392
7393 * search.c (Fword_search_regexp, Fword_search_backward)
7394 (Fword_search_forward, Fword_search_backward_lax)
7395 (Fword_search_forward_lax): Move functions to isearch.el
7396 (bug#10145, bug#11381).
7397
b0572523
PE
73982012-05-16 Paul Eggert <eggert@cs.ucla.edu>
7399
7400 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
7401
9660f5fc
SM
74022012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
7403
7404 * lread.c (init_obarray): Declare Qt and Qnil as special.
7405
4374de83
GM
74062012-05-14 Glenn Morris <rgm@gnu.org>
7407
7408 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 7409 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 7410
dc44c39a
PE
74112012-05-14 Paul Eggert <eggert@cs.ucla.edu>
7412
078c97cb
PE
7413 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
7414
dc44c39a
PE
7415 * unexaix.c: Port to more-recent AIX compilers.
7416 (report_error, report_error_1, make_hdr, copy_sym)
7417 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
7418 Make arguments const char *, not char *, to avoid violations of C
7419 standard and to fix some AIX warnings reported by Gilles Pion.
7420
e18afed7 74212012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
7422
7423 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
7424 already have overlays loaded.
7425 (handle_single_display_spec): Before returning without displaying
7426 fringe bitmap, synchronize the bidi iterator with the main display
7427 iterator, by calling iterate_out_of_display_property.
7428 (iterate_out_of_display_property): Detect buffer iteration by
7429 testing that it->string is a Lisp string.
7430 (get_next_display_element): When the current object is exhausted,
7431 and there's something on it->stack, call set_iterator_to_next to
7432 proceed with what's on the stack, instead of returning zero.
7433 (set_iterator_to_next): If called at the end of a Lisp string,
7434 proceed to consider_string_end without incrementing string
7435 position. Don't increment display vector index past the end of
7436 the display vector. (Bug#11417)
c8fb9dc6
EZ
7437 (pos_visible_p): Don't report a position visible when move_it_to
7438 stopped at the last line of window, which happens to be scanned
7439 backwards by the bidi iteration. (Bug#11464)
ac268e67 7440
e18afed7 74412012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
7442
7443 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
7444 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
7445 are on a TTY, and thus unable to display on the fringes.
7446 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
7447 so we need to signal to the caller that this is a "replacing"
7448 display spec. This fixes display when the spec is invalid or we
7449 are on a TTY.
7450
e18afed7 74512012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
7452
7453 * unexaix.c (make_hdr): Fix typo in prototype.
7454 This bug broke the build on AIX. Problem reported by Gilles Pion.
7455
9d0a235a
MA
74562012-05-14 Michael Albinus <michael.albinus@gmx.de>
7457
7458 * keyboard.c (kbd_buffer_get_event): Read special events also in
7459 batch mode. (Bug#11415)
7460
9e6b06ed
GM
74612012-05-12 Glenn Morris <rgm@gnu.org>
7462
7463 * ns.mk: Update for ns_appbindir no longer having trailing "/".
7464
c1a1d7a3
EZ
74652012-05-12 Eli Zaretskii <eliz@gnu.org>
7466
7467 * lisp.mk (lisp): Add newcomment.elc.
7468
3fe7cdc8
GM
74692012-05-12 Glenn Morris <rgm@gnu.org>
7470
7471 * Makefile.in (MKDIR_P): New, set by configure.
7472 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
7473
53f7d2c0
PE
74742012-05-11 Paul Eggert <eggert@cs.ucla.edu>
7475
7476 Remove unused function hourglass_started.
7477 * dispextern.h (hourglass_started):
7478 * w32fns.c (hourglass_started):
7479 * xdisp.c (hourglass_started): Remove.
7480
75aafb17
JB
74812012-05-10 Juanma Barranquero <lekktu@gmail.com>
7482
7483 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
7484 Update dependencies.
7485
12959e8e
PE
74862012-05-10 Paul Eggert <eggert@cs.ucla.edu>
7487
97107e2e
PE
7488 * xgselect.c (xg_select): Put maxfds+1 into a var.
7489 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
7490
12959e8e
PE
7491 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
7492
836d29b3
DA
74932012-05-10 Dave Abrahams <dave@boostpro.com>
7494
7495 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
7496 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
7497
5cb67954
MA
74982012-05-09 Michael Albinus <michael.albinus@gmx.de>
7499
7500 * dbusbind.c (xd_registered_buses): New internal Lisp object.
7501 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
7502 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
7503 Initialize xd_registered_buses.
7504
3478ec45
PE
75052012-05-09 Paul Eggert <eggert@cs.ucla.edu>
7506
b263a6b0
PE
7507 Untag more efficiently if USE_LSB_TAG.
7508 This is based on a proposal by YAMAMOTO Mitsuharu in
7509 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
7510 For an admittedly artificial (nth 8000 longlist) benchmark on
7511 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
7512 Emacs's overall text size by 1%.
7513 * lisp.h (XUNTAG): New macro.
7514 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
7515 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
7516 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
7517 * eval.c (Fautoload):
7518 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
7519 * frame.h (XFRAME): Use XUNTAG.
7520
3478ec45
PE
7521 Port recent dbusbind.c changes to 32-bit --with-wide-int.
7522 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
7523 Remove unportable assumptions about print widths of types like
7524 dbus_uint32_t.
7525 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
7526 intptr_t when converting between pointer and integer, to avoid GCC
7527 warnings about wrong width.
7528
666b903b 75292012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
7530
7531 * w32proc.c (new_child): Force Windows to reserve only 64KB of
7532 stack for each reader_thread, instead of defaulting to 8MB
7533 determined by the linker. This avoids failures in creating
7534 subprocesses on Windows 7, see the discussion in this thread:
7535 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
7536
b120cc17
JC
75372012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
7538
7539 Fix up display of the *Minibuf-0* buffer in the mini window.
7540 * keyboard.c (read_char): Don't clear the echo area if there's no
7541 message to clear.
7542 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 7543 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 7544
9a4b36f8
MA
75452012-05-07 Michael Albinus <michael.albinus@gmx.de>
7546
7547 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
7548 batch mode.
7549
e5f9458f
CY
75502012-05-06 Chong Yidong <cyd@gnu.org>
7551
7552 * lisp.mk (lisp): Update.
7553
eceeb5fc 75542012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
7555
7556 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
7557
71873e2b
SM
75582012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
7559
7560 * data.c (PUT_ERROR): New macro.
7561 (syms_of_data): Use it. Add new error type `user-error'.
7562 * undo.c (user_error): New function.
7563 (Fprimitive_undo): Use it.
7564 * print.c (print_error_message): Adjust print style for `user-error'.
7565 * keyboard.c (user_error): New function.
7566 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
7567
ab0fa4e4
PE
75682012-05-03 Paul Eggert <eggert@cs.ucla.edu>
7569
7570 Do not limit current-time-string to years 1000..9999.
7571 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
7572 (Fcurrent_time_string): Support any year that is supported by the
7573 underlying localtime representation. Don't use asctime, as it
7574 has undefined behavior for years outside the range -999..9999.
7575
7ed806a7
PE
75762012-05-02 Paul Eggert <eggert@cs.ucla.edu>
7577
7578 Fix race conditions involving setenv, gmtime, localtime, asctime.
7579 Without this fix, interrupts could mess up code that uses these
7580 nonreentrant functions, since setting TZ invalidates existing
7581 tm_zone or tzname values, and since most of these functions return
7582 pointers to static storage.
7583 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
7584 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
7585 Grow the critical sections to include not just invoking
7586 localtime/gmtime, but also accessing these functions' results
7587 including their tm_zone values if any, and any related TZ setting.
7588 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
7589 so that the struct tm is saved in the critical section.
7590 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
7591 motivated by the fact that memory allocation needs to be outside
7592 the critical section.
7593
0c16dfed
DA
75942012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
7595
7596 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
7597 with RESET_INTERVAL.
7598
7599 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7600 Remove duplicated buffer name initialization.
7601
3f83ace8
JM
76022012-05-02 Jim Meyering <jim@meyering.net>
7603
7604 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
7605
c7b8541e
JM
7606 * xfns.c (x_window): Use xstrdup (Bug#11375).
7607
90207a15 76082012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
7609
7610 * xdisp.c (pos_visible_p): If already at a newline from the
7611 display string before the 'while' loop, don't walk back the glyphs
7612 from it3.glyph_row. Solves assertion violation when the display
7613 string begins with a newline (egg.el). (Bug#11367)
7614
b593d6a9
AH
76152012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
7616
7617 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
7618 Move to simple.el.
7619
4737362e
GM
76202012-05-01 Glenn Morris <rgm@gnu.org>
7621
99cf43f9
GM
7622 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
7623 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
7624 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
7625 All were removed before 23.1.
7626
9311dcff
GM
7627 * dispnew.c: Remove HAVE_LIBNCURSES test;
7628 it is always true on relevant platforms.
7629
4d5c6349
GM
7630 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
7631 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
7632
4737362e
GM
7633 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
7634
74dd3a6b
AS
76352012-04-30 Andreas Schwab <schwab@linux-m68k.org>
7636
7637 * .gdbinit (xpr): Remove checks for no longer existing misc types.
7638 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
7639 Remove.
7640
13c379ee
PE
76412012-04-28 Paul Eggert <eggert@cs.ucla.edu>
7642
7643 Do not avoid creating empty evaporating overlays (Bug#9642).
7644 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
7645 That is, do not delete an evaporating overlay if it becomes
7646 empty after its bounds are adjusted to fit within its buffer.
7647 This fix caused other problems, and I'm reverting it until we get
7648 to the bottom of them.
7649
a8e7d6d7 76502012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
7651
7652 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
7653
a8e7d6d7 76542012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
7655
7656 * xdisp.c (pos_visible_p): If the window start position is beyond
7657 ZV, start the display from buffer beginning. Prevents assertion
7658 violation in init_iterator when the minibuffer window is scrolled
7659 via the scroll bar.
7660
7661 * window.c (window_scroll_pixel_based): Likewise.
7662
a8e7d6d7 76632012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
7664
7665 * keymap.c (where_is_internal): Doc fix (Bug#10872).
7666
a8e7d6d7 76672012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
7668
7669 * fileio.c (Fcopy_file, Fset_file_selinux_context):
7670 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
7671
a8e7d6d7 76722012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 7673
b593d6a9
AH
7674 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
7675 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 7676
1c6900d9
EZ
76772012-04-26 Eli Zaretskii <eliz@gnu.org>
7678
4c3fa1d9
EZ
7679 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
7680 display element, check also the underlying string or buffer
7681 character. (Bug#11341)
7682
1c6900d9
EZ
7683 * w32menu.c: Include w32heap.h.
7684 (add_menu_item): If the call to AppendMenuW (via
7685 unicode_append_menu) fails, disable Unicode menus only if we are
7686 running on Windows 9X/Me.
7687
42bf8205
AS
76882012-04-24 Andreas Schwab <schwab@linux-m68k.org>
7689
7690 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
7691 (xgetint): Add missing shift for LSB tags.
7692
b1bac16e
MR
76932012-04-24 Martin Rudalics <rudalics@gmx.at>
7694
7695 * keyboard.c (read_char): Don't wipe echo area for select window
7696 events: These might get delayed via `mouse-autoselect-window'
7697 (Bug#11304).
7698
d69621cc
JB
76992012-04-24 Juanma Barranquero <lekktu@gmail.com>
7700
7701 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
7702 manipulation of :loaded-from data.
7703
02fd101b
JB
77042012-04-23 Juanma Barranquero <lekktu@gmail.com>
7705
7706 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
7707 now a cons (bug#11311).
7708
888bec30
PE
77092012-04-23 Paul Eggert <eggert@cs.ucla.edu>
7710
89a438bd
PE
7711 Do not create empty overlays with the evaporate property (Bug#9642).
7712 * buffer.c (Fmove_overlay): Delete an evaporating overlay
7713 if it becomes empty after its bounds are adjusted to fit within
7714 its buffer. Without this fix, in a nonempty buffer (let ((o
7715 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
7716 yields an empty overlay that has the evaporate property, which is
7717 not supposed to happen.
7718
1068fe4d
PE
7719 Fix minor GTK3 problems found by static checking.
7720 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7721 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7722 (struct _EmacsFixedClass, emacs_fixed_get_type):
7723 Move decls here from emacsgtkfixed.h, since they needn't be public.
7724 (emacs_fixed_get_type): Now static.
7725 (emacs_fixed_class_init): Omit unused local.
7726 (emacs_fixed_child_type): Remove; unused.
7727 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7728 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7729 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
7730 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
7731 (EMACS_FIXED_GET_CLASS): Remove; unused.
7732 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
7733
888bec30
PE
7734 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
7735 Problem reported by Juanma Barranquero for Windows -Wunused-function.
7736
de85e130
PE
77372012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7738
d0baac98 7739 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 7740 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
7741 (__malloc_size_t, __malloc_ptrdiff_t):
7742 Remove. All uses removed, replaced by the definiens if needed,
7743 since we can assume C89 or better now.
7744 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
7745 (protect_malloc_state, align, get_contiguous_space)
7746 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
7747 (malloc_atfork_handler_child, malloc_enable_thread)
7748 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
7749 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
7750 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
7751 (special_realloc, _realloc_internal_nolock, _realloc_internal)
7752 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
7753 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
7754 Define using prototypes, not old style.
7755 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
7756 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
7757 (align): Don't assume that signed integer overflow wraps around.
7758 Omit unused local var.
7759 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
7760 (_free_internal_nolock, memalign, mallochook, reallochook):
7761 Omit no-longer-needed casts.
7762 (valloc): Use getpagesize, not __getpagesize.
7763 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
7764 (struct hdr): The 'magic' member is now size_t, not unsigned long.
7765
de85e130
PE
7766 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
7767
dcbf5805
MA
77682012-04-22 Michael Albinus <michael.albinus@gmx.de>
7769
7770 Move functions from C to Lisp. Make non-blocking method calls
7771 the default. Implement further D-Bus standard interfaces.
7772
7773 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
7774 (QCdbus_request_name_allow_replacement)
7775 (QCdbus_request_name_replace_existing)
7776 (QCdbus_request_name_do_not_queue)
7777 (QCdbus_request_name_reply_primary_owner)
7778 (QCdbus_request_name_reply_in_queue)
7779 (QCdbus_request_name_reply_exists)
7780 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
7781 (QCdbus_registered_serial, QCdbus_registered_method)
7782 (QCdbus_registered_signal): New Lisp objects.
7783 (XD_DEBUG_MESSAGE): Use sizeof.
7784 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
7785 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
7786 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
7787 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
7788 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
7789 (xd_signature, xd_append_arg): Allow float for integer types.
7790 (xd_get_connection_references): New function.
b593d6a9
AH
7791 (xd_get_connection_address): Rename from xd_initialize.
7792 Return cached address.
dcbf5805
MA
7793 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
7794 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
7795 level.
7796 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 7797 Return number of refcounts.
dcbf5805
MA
7798 (Fdbus_get_unique_name): Make stronger parameter check.
7799 (Fdbus_message_internal): New defun.
7800 (Fdbus_call_method, Fdbus_call_method_asynchronously)
7801 (Fdbus_method_return_internal, Fdbus_method_error_internal)
7802 (Fdbus_send_signal, Fdbus_register_service)
7803 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
7804 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
7805 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
7806 (Vdbus_compiled_version, Vdbus_runtime_version)
7807 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
7808 (Vdbus_message_type_method_return, Vdbus_message_type_error)
7809 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
7810 (Vdbus_registered_buses, Vdbus_registered_objects_table):
7811 Adapt docstring.
dcbf5805 7812
52828e02
PE
78132012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7814
da05bc4c
PE
7815 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
7816 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
7817 Do not assume ptrdiff_t is the same width as 'int'.
7818
52828e02
PE
7819 * alloc.c: Handle unusual debugging option combinations.
7820 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
7821 since the two debugging options are incompatible.
7822 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
7823 is defined.
7824 (mem_init, mem_insert, mem_insert_fixup):
7825 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
7826 (NEED_MEM_INSERT): Remove; no longer needed.
7827
f01769f9
LL
78282012-04-22 Leo Liu <sdl.web@gmail.com>
7829
7830 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
7831
5790543d
PE
78322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7833
7834 * sysdep.c [__FreeBSD__]: Minor cleanups.
7835 (list_system_processes, system_process_attributes) [__FreeBSD__]:
7836 Use Emacs indenting style more consistently. Avoid some casts.
7837 Use 'double' consistently rather than mixing 'float' and 'double'.
7838
b91b7e4d
EW
78392012-04-21 Eduard Wiebe <usenet@pusto.de>
7840
b593d6a9
AH
7841 * sysdep.c (list_system_processes, system_process_attributes):
7842 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 7843
6114eb15
AS
78442012-04-21 Andreas Schwab <schwab@linux-m68k.org>
7845
7846 * lisp.mk (lisp): Update.
7847
2f38dff7
PE
78482012-04-20 Paul Eggert <eggert@cs.ucla.edu>
7849
7850 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
7851 It is never used otherwise.
7852
4ae29f89
SM
78532012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
7854
7855 * print.c (print_preprocess): Only check print_depth if print-circle
7856 is nil.
7857 (print_object): Check for cycles even when print-circle is nil and
7858 print-gensym is t, but only check print_depth if print-circle is nil.
7859
f30d612a
CY
78602012-04-20 Chong Yidong <cyd@gnu.org>
7861
7862 * process.c (wait_reading_process_output): If EIO occurs on a pty,
7863 set the status to "failed" and ensure that sentinel is run.
7864
c07a4c0b 78652012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
7866
7867 * process.c (Fset_process_inherit_coding_system_flag)
7868 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 7869 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 7870
c07a4c0b 78712012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
7872
7873 * xdisp.c (string_buffer_position_lim): Limit starting position to
7874 BEGV.
7875 (set_cursor_from_row): If called for a mode-line or header-line
7876 row, return zero immediately.
7877 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
7878 farther than the first row after the header line, if any.
7879 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
7880 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
7881
c07a4c0b 78822012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7883
4ae29f89
SM
7884 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
7885 (bug#11238).
ad3a2b41 7886
c07a4c0b 78872012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 78882012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
7889
7890 configure: new option --enable-gcc-warnings (Bug#11207)
7891 * Makefile.in (C_WARNINGS_SWITCH): Remove.
7892 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
7893 (ALL_CFLAGS): Use new macros rather than old.
7894 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
7895 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
7896 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
7897 -Wunused-result, -Wunused-variable. This should go away once
7898 the Emacs and Gnulib regex code is merged.
7899 (xmalloc, xrealloc): Now static.
7900
aba027e8
PE
79012012-04-17 Paul Eggert <eggert@cs.ucla.edu>
7902
7903 * dired.c (Fsystem_groups): Remove unused local.
7904
e5a36063
GM
79052012-04-17 Glenn Morris <rgm@gnu.org>
7906
7907 * dired.c (Fsystem_users): Doc fix.
7908
316411f0
DA
79092012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
7910
7911 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
7912 (syms_of_dired): Add them.
7913
9426aba4
PE
79142012-04-16 Paul Eggert <eggert@cs.ucla.edu>
7915
b62a57be
PE
7916 Fix minor alloc.c problems found by static checking.
7917 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
7918 New extern decls, to avoid calling undeclared functions.
7919 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
7920 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
7921 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
7922 (NEED_MEM_INSERT): New macro.
7923 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 7924 Remove one incorrect comment and fix another.
b62a57be 7925
3539f31f
PE
7926 Fix minor ralloc.c problems found by static checking.
7927 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7928 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
7929 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
7930 (r_alloc_sbrk): Now static.
7931
a041960a
PE
7932 Improve ralloc.c interface checking.
7933 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7934 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
7935 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
7936 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
7937 [REL_ALLOC]: ... to here, to check interface.
7938 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
7939 Remove decls. This fixes an "It stinks!".
7940
9426aba4
PE
7941 * alloc.c (which_symbols): Fix alignment issue / type clash.
7942
d55c12ed
AS
79432012-04-15 Andreas Schwab <schwab@linux-m68k.org>
7944
7945 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
7946 (struct Lisp_Misc_Any): Likewise.
7947 (struct Lisp_Free): Likewise.
7948 * alloc.c (union aligned_Lisp_Symbol): Define.
7949 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
7950 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
7951 (union aligned_Lisp_Misc): Define.
7952 (MARKER_BLOCK_SIZE, struct marker_block): Use union
7953 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 7954 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 7955
b948ce8b
PE
79562012-04-14 Paul Eggert <eggert@cs.ucla.edu>
7957
7958 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
7959 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
7960 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
7961 * s/netbsd.h, s/sol2-6.h:
7962 Remove definition of GC_MARK_STACK, since the default now works.
7963 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
7964 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
7965 no longer the default.
7966 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
7967
35dc09a1 79682012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7969
35dc09a1
GM
7970 * lread.c (lisp_file_lexically_bound_p):
7971 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 7972
35dc09a1
GM
79732012-04-14 Eli Zaretskii <eliz@gnu.org>
7974
7975 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
7976 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
7977
79782012-04-14 Jan Djärv <jan.h.d@swipnet.se>
7979
7980 * nsterm.m (constrainFrameRect): Always constrain when there is only
7981 one screen (Bug#10962).
7982
bcd86815
KB
79832012-04-13 Ken Brown <kbrown@cornell.edu>
7984
7985 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
7986
c25df26e
RT
79872012-04-13 Reuben Thomas <rrt@sc3d.org>
7988
7989 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
7990
0fc59f1e
DC
79912012-04-11 Daniel Colascione <dancol@dancol.org>
7992
7993 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
7994 against is gone. It's better to use vfork now so that when Cygwin
7995 gains a new, working vfork, we use it automatically (bug#10398).
7996
de8c03dc
SM
79972012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7998
7999 * window.c (save_window_save): Obey window-point-insertion-type.
8000
2f097256
GM
80012012-04-11 Glenn Morris <rgm@gnu.org>
8002
8003 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
8004
453b951e
SM
80052012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8006
8007 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
8008
75f1671a 80092012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
8010
8011 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
8012 (force_quit_count): New var.
8013 (handle_interrupt): Use it.
8014
2a8ce227
JB
80152012-04-10 Juanma Barranquero <lekktu@gmail.com>
8016
8017 * w32.c (w32_delayed_load): Record the full path of the library
8018 being loaded (bug#10424).
8019
935396c0
GM
80202012-04-09 Glenn Morris <rgm@gnu.org>
8021
05920a43
GM
8022 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
8023 not just in the obarray, before snarfing them. (Bug#11036)
8024
935396c0
GM
8025 * Makefile.in ($(leimdir)/leim-list.el):
8026 Pass EMACS rather than BUILT_EMACS.
8027
a18ecafa
TZ
80282012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
8029
8030 * process.c (make_process):
8031 * process.h: Add integer `gnutls_handshakes_tried' member to
8032 process struct.
8033
6bbef4e5
JC
8034 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
8035 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
8036
8037 * gnutls.c (gnutls_log_function2i): Convenience log function.
8038 (emacs_gnutls_read): Use new log functions,
8039 `gnutls_handshakes_tried' process member, and
8040 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
8041 attempts per process (connection).
8042
b4d3bc10
CY
80432012-04-09 Chong Yidong <cyd@gnu.org>
8044
8045 * eval.c (Fuser_variable_p, user_variable_p_eh)
8046 (lisp_indirect_variable): Functions deleted.
8047 (Fdefvar): Caller changed.
8048
8049 * callint.c (Finteractive, Fcall_interactively):
8050 * minibuf.c (Fread_variable): Callers changed.
8051
70f4d973
EZ
80522012-04-09 Eli Zaretskii <eliz@gnu.org>
8053
8054 * xdisp.c (set_cursor_from_row): If the display string appears in
8055 the buffer at position that is closer to point than the position
8056 after the display string, display the cursor on the first glyph of
8057 the display string. Fixes cursor display when a 'display' text
8058 property immediately follows invisible text. (Bug#11094)
8059
cb3c2e3e
PE
80602012-04-09 Paul Eggert <eggert@cs.ucla.edu>
8061
8062 composite.c: use 'double' consistently
8063 * composite.c (get_composition_id): Use 'double' consistently
8064 instead of converting 'float' to 'double' and vice versa; this is
8065 easier to understand and avoids a GCC warning.
8066
fd06db5d
GM
80672012-04-09 Glenn Morris <rgm@gnu.org>
8068
50fe702a
GM
8069 * Makefile.in: Generate leim-list with bootstrap-emacs, in
8070 preparation for dumping it with emacs. (Bug#4789)
8071 (leimdir): New variable.
8072 ($(leimdir)/leim-list.el): New rule.
8073 (emacs$(EXEEXT)): Depend on leim-list.el.
8074
fd06db5d
GM
8075 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
8076 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
8077 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
8078
55c131ee
AS
80792012-04-08 Andreas Schwab <schwab@linux-m68k.org>
8080
8081 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
8082 proper alignment.
8083
9209588f
JB
80842012-04-07 Juanma Barranquero <lekktu@gmail.com>
8085
8086 * xml.c (init_libxml2_functions) [WINDOWSNT]:
8087 Remove unused local variable.
8088
e3fb2efb
PE
80892012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8090
8091 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
8092 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
8093 (mark_memory): Mark Lisp_Objects only if pointers might hide in
8094 objects, as mark_maybe_pointer will catch them otherwise.
8095 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
8096 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
8097
b5385551
PE
80982012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8099
8100 Fix typo that broke non-Windows builds.
8101 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
8102
9078ead6
EZ
81032012-04-07 Eli Zaretskii <eliz@gnu.org>
8104
8105 Support building on MS-Windows with libxml2.
8106
8107 * makefile.w32-in (OBJ2): Add xml.$(O).
8108 (GLOBAL_SOURCES): Add xml.c.
8109 ($(BLD)/xml.$(O)): New dependency list.
8110
8111 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
8112 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
8113 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
8114 [!WINDOWSNT]: New macros.
8115 (init_libxml2_functions, libxml2_loaded_p): New functions.
8116 (parse_region): Call fn_xmlCheckVersion instead of using the macro
8117 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
8118 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
8119 Calls xmlCleanupParser only if libxml2 was loaded (or statically
8120 linked in).
6bbef4e5
JC
8121 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
8122 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
8123 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
8124
8125 * emacs.c: Don't include libxml/parser.h.
8126 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
8127 xmlCleanupParser directly.
8128
8129 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
8130
3811fdf3
EZ
81312012-04-07 Eli Zaretskii <eliz@gnu.org>
8132
8133 * indent.c (Fvertical_motion): If there is a display string at
8134 point, use it.vpos to compute how many lines to backtrack after
8135 move_it_to point. (Bug#11133)
8136
2f8e16b2
EZ
81372012-04-06 Eli Zaretskii <eliz@gnu.org>
8138
8139 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
8140 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
8141 about subtle differences between FETCH_CHAR* and STRING_CHAR*
8142 macros related to unification of CJK characters. For the details,
8143 see the discussion following the message here:
8144 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
8145
3d439cd1
CY
81462012-04-04 Chong Yidong <cyd@gnu.org>
8147
8148 * keyboard.c (Vdelayed_warnings_list): Doc fix.
8149
8bc53d00
EZ
81502012-04-01 Eli Zaretskii <eliz@gnu.org>
8151
8152 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
8153 instead of alloca. (Bug#11138)
8154
3b0512a3
AS
81552012-04-01 Andreas Schwab <schwab@linux-m68k.org>
8156
8157 * w32menu.c (is_simple_dialog): Properly check lisp types.
8158 (Bug#11141)
8159
8427ddd2
EZ
81602012-03-31 Eli Zaretskii <eliz@gnu.org>
8161
979022ef
EZ
8162 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
8163 position we get to after a call to move_it_to fails the
8164 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
8165 only if we wind up in a string from display property. (Bug#11063)
8166
a6b1c7cc
EZ
8167 * window.c (Fdelete_other_windows_internal): Invalidate the row
8168 and column information about mouse highlight, so that redisplay
8169 restores it after reallocating the glyph matrices. (Bug#7464)
8170
8427ddd2
EZ
8171 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
8172 string comes from a `display' text property, use the buffer
8173 position of that property as if we actually saw that position in
8174 the row's glyphs.
697ba24b
EZ
8175 (move_it_by_lines): Remove the assertion that
8176 "it->current_x == 0 && it->hpos == 0" which can be legitimately
8177 violated when there's a before-string at the beginning of a line.
8178 (Bug#11063)
8427ddd2 8179
65a0a738
EZ
81802012-03-30 Eli Zaretskii <eliz@gnu.org>
8181
8182 * xdisp.c (append_space_for_newline): If the default face was
8183 remapped, use the remapped face for the appended newline.
8184 (extend_face_to_end_of_line): Use the remapped default face for
8185 extending the face to the end of the line.
8186 (display_line): Call extend_face_to_end_of_line when the default
8187 face was remapped. (Bug#11068)
8188
581355cc
EZ
81892012-03-29 Eli Zaretskii <eliz@gnu.org>
8190
8191 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
8192
e8fc049f
SM
81932012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8194
8195 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
8196
4fb9a543
GM
81972012-03-27 Glenn Morris <rgm@gnu.org>
8198
8199 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
8200 Doc fixes.
8201
679910f1
KH
82022012-03-26 Kenichi Handa <handa@m17n.org>
8203
8204 * dispextern.h (struct glyph): Fix previous change. Change the
8205 bit length of glyphless.ch to 25 (Bug#11082).
8206
90d49b7f
CY
82072012-03-26 Chong Yidong <cyd@gnu.org>
8208
8209 * keyboard.c (Vselection_inhibit_update_commands): New variable.
8210 (command_loop_1): Use it; inhibit selection update for
8211 handle-select-window too (Bug#8996).
8212
f514f6f0
FP
82132012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
8214
e8fc049f 8215 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 8216
bf43fa51
KH
82172012-03-25 Kenichi Handa <handa@m17n.org>
8218
8219 * dispextern.h (struct glyph): Change the bit length of
8220 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
8221
8a0c01dd
EZ
82222012-03-24 Eli Zaretskii <eliz@gnu.org>
8223
8224 * s/ms-w32.h (tzname): Include time.h before redirecting to
8225 _tzname. Fixes the MSVC build. (Bug#9960)
8226
7d1c3a76
AS
82272012-03-24 Andreas Schwab <schwab@linux-m68k.org>
8228
8ed79523
AS
8229 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
8230 characters.
8231
7d1c3a76
AS
8232 * xterm.c (XTread_socket): Only modify handling_signal if
8233 !SYNC_INPUT. (Bug#11080)
8234
e99a9b8b
EZ
82352012-03-23 Eli Zaretskii <eliz@gnu.org>
8236
8237 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
8238 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
8239 when fetching a multibyte character consumes more bytes than
8240 CHAR_BYTES returns, due to unification of CJK characters in
8241 string_char. (Bug#11073)
8242
5063c0e1
TN
82432012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
8244
8245 * process.c (wait_reading_process_output): Handle pty disconnect
8246 by refraining from sending oneself a SIGCHLD (bug#10933).
8247
9f851fbd
CY
82482012-03-22 Chong Yidong <cyd@gnu.org>
8249
8250 * dispextern.h (struct it): New member string_from_prefix_prop_p.
8251
5063c0e1 8252 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
8253 Mark string as coming from a prefix property.
8254 (handle_face_prop): Use default face for prefix strings (Bug#4281).
8255 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
8256
fb5b8aca
CY
82572012-03-21 Chong Yidong <cyd@gnu.org>
8258
8259 * xfaces.c (Vface_remapping_alist): Doc fix.
8260
62356a1b
EZ
82612012-03-20 Eli Zaretskii <eliz@gnu.org>
8262
8263 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
8264 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
8265 Doc fixes.
62356a1b 8266
025de85b
CY
82672012-03-20 Chong Yidong <cyd@gnu.org>
8268
8269 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
8270 to reflect default non-nil value of redisplay-dont-pause.
8271
4827f94e
KH
82722012-03-19 Kenichi Handa <handa@m17n.org>
8273
8274 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
8275 it fit in a valid range (Bug#11003).
8276
e50a24a2
EZ
82772012-03-18 Eli Zaretskii <eliz@gnu.org>
8278
8279 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
8280 that is not from display property, accept the row as a "cursor
8281 row" if one of the string's character has a non-nil `cursor'
8282 property. Fixes cursor positioning when there are newlines in
8283 overlay strings, e.g. in icomplete.el. (Bug#11035)
8284
9af5ed87
PE
82852012-03-12 Paul Eggert <eggert@cs.ucla.edu>
8286
8287 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
8288
d1f55f16
CY
82892012-03-12 Chong Yidong <cyd@gnu.org>
8290
8291 * eval.c (inhibit_lisp_code): Rename from
8292 inhibit_window_configuration_change_hook; move from window.c.
8293
8294 * xfns.c (unwind_create_frame_1, Fx_create_frame):
8295 * window.c (run_window_configuration_change_hook)
8296 (syms_of_window): Callers changed.
8297
66c5eebd
CY
82982012-03-11 Chong Yidong <cyd@gnu.org>
8299
413df973
CY
8300 * keymap.c (Fkey_description): Doc fix (Bug#9700).
8301
66c5eebd
CY
8302 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
8303
1de11f56
CY
83042012-03-10 Chong Yidong <cyd@gnu.org>
8305
8306 * frame.c (other_visible_frames): Don't assume the selected frame
8307 is visible (Bug#10955).
8308
cae07000
SM
83092012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
8310
8311 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
8312
89c94350
JD
83132012-03-08 Jan Djärv <jan.h.d@swipnet.se>
8314
8315 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
8316 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
8317 zero (Bug#10954).
8318
999dd333
GM
83192012-03-03 Glenn Morris <rgm@gnu.org>
8320
01a6dcc8 8321 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 8322
de0100f2
EZ
83232012-03-02 Eli Zaretskii <eliz@gnu.org>
8324
8325 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
8326 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
8327 (redisplay_window, next_element_from_string): Fix typos in
8328 comments.
3e441275
EZ
8329 (redisplay_window): Pass to move_it_vertically the margin in
8330 pixels, not in screen lines.
de0100f2 8331
96a72ee9
GM
83322012-03-02 Glenn Morris <rgm@gnu.org>
8333
8334 * buffer.c (buffer-list-update-hook): Doc fix.
8335
312508d7
EZ
83362012-02-29 Eli Zaretskii <eliz@gnu.org>
8337
8338 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
8339 push_it before setting up the iterator for the first overlay
8340 string, even if we have an empty string loaded.
8341 (next_overlay_string): If there's an empty string on the iterator
8342 stack, pop the stack. (Bug#10903)
8343
27f3c637
PE
83442012-02-25 Paul Eggert <eggert@cs.ucla.edu>
8345
8346 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
8347 Suggested by Stefan Monnier in
8348 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
8349 * alloc.c (widen_to_Lisp_Object): New static function.
8350 (mark_memory): Also mark Lisp_Objects by fetching pointer words
8351 and widening them to Lisp_Objects. This would work even if
8352 USE_LSB_TAG is defined and wide integers are used, which might
8353 happen in a future version of Emacs.
8354
3c9dfce6
CY
83552012-02-25 Chong Yidong <cyd@gnu.org>
8356
fa74b241
CY
8357 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
8358 Doc fix.
8359
3c9dfce6
CY
8360 * xselect.c (Fx_selection_exists_p): Doc fix.
8361 (x_clipboard_manager_save_all): Print an informative message
8362 before saving to clipboard manager.
8363
9486df08
CY
83642012-02-24 Chong Yidong <cyd@gnu.org>
8365
8366 * keyboard.c (process_special_events): Handle all X selection
8367 requests in kbd_buffer, not just the next one (Bug#8869).
8368
f01d3321
CY
83692012-02-23 Chong Yidong <cyd@gnu.org>
8370
8371 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
8372 call when setting menu-bar-lines and tool-bar-lines parameters.
8373 (unwind_create_frame_1): New helper function.
8374
8375 * window.c (inhibit_window_configuration_change_hook): New var.
8376 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 8377 (syms_of_window): Initialize it.
f01d3321 8378
86b847b6
CY
83792012-02-22 Chong Yidong <cyd@gnu.org>
8380
8381 * xterm.c (x_draw_image_relief): Add missing type check for
8382 Vtool_bar_button_margin (Bug#10743).
8383
a59225b1
CY
83842012-02-21 Chong Yidong <cyd@gnu.org>
8385
8386 * fileio.c (Vfile_name_handler_alist): Doc fix.
8387
8388 * buffer.c (Fget_file_buffer): Protect against invalid file
8389 handler return value.
8390
310f5bd4
PE
83912012-02-20 Paul Eggert <eggert@cs.ucla.edu>
8392
cb3a28cc
PE
8393 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
8394 when computing $valmask.
8395
310f5bd4
PE
8396 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
8397 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
8398 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
8399 It's useless in that case, and it can cause problems on hosts
8400 that allocate halves of EMACS_INT values separately.
8401 Reported by Dan Horák. Diagnosed by Andreas Schwab in
8402 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
8403 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
8404 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
8405 it avoids undefined behavior on hosts where shifting right by more
8406 than the word width has undefined behavior.
8407
2375c96a
CY
84082012-02-19 Chong Yidong <cyd@gnu.org>
8409
8410 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
8411 (Funhandled_file_name_directory, Ffile_name_as_directory)
8412 (Fdirectory_file_name, Fexpand_file_name)
8413 (Fsubstitute_in_file_name): Protect against invalid file handler
8414 return values (Bug#10845).
8415
3eb49e71
EZ
84162012-02-18 Eli Zaretskii <eliz@gnu.org>
8417
8418 * .gdbinit (pitx): Fix incorrect references to fields of the
8419 iterator stack.
8420
7b926f3f
CY
84212012-02-17 Chong Yidong <cyd@gnu.org>
8422
8423 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
8424
11273115
PE
84252012-02-15 Paul Eggert <eggert@cs.ucla.edu>
8426
8427 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
8428 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
8429
c3a70e2b
CY
84302012-02-15 Chong Yidong <cyd@gnu.org>
8431
8432 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
8433 marked as special. Also, starting docstrings with * is obsolete.
8434
0ca43699
AS
84352012-02-13 Andreas Schwab <schwab@linux-m68k.org>
8436
8437 * gnutls.c (emacs_gnutls_write): Fix last change.
8438
2e8f3c56
LI
84392012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
8440
8441 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
8442 send_process.
8443
af70074f
SM
84442012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
8445
8446 * keymap.c (Fsingle_key_description): Handle char ranges.
8447
95986d52
CY
84482012-02-12 Chong Yidong <cyd@gnu.org>
8449
afd83bd1
CY
8450 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
8451 as that creates a dangerous corner case.
8452
95986d52
CY
8453 * window.c (Fdelete_window_internal): Invalidate the mouse
8454 highlight (Bug#9904).
8455
bd7da63e
GM
84562012-02-12 Glenn Morris <rgm@gnu.org>
8457
8458 * xselect.c (Fx_own_selection_internal)
8459 (Fx_get_selection_internal, Fx_disown_selection_internal)
8460 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
8461 * nsselect.m (Fx_own_selection_internal)
8462 (Fx_disown_selection_internal, Fx_selection_exists_p)
8463 (Fx_selection_owner_p, Fx_get_selection_internal):
8464 Sync docs and argument specs with the xselect.c versions.
8465
77abcbc2
LI
84662012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
8467
8468 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
8469
90b671e2
EZ
84702012-02-11 Eli Zaretskii <eliz@gnu.org>
8471
1c0ca0b7
EZ
8472 * w32select.c (Fx_selection_exists_p): Sync doc string and
8473 argument list with xselect.c. (Bug#10783)
8474
8475 * w16select.c (Fx_selection_exists_p): Sync doc string and
8476 argument list with xselect.c. (Bug#10783)
90b671e2 8477
49241268
GM
84782012-02-10 Glenn Morris <rgm@gnu.org>
8479
8480 * fns.c (Fsecure_hash): Doc fix.
8481
f998bbe7 84822012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
8483
8484 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
8485
0992bd9c
CY
84862012-02-07 Chong Yidong <cyd@gnu.org>
8487
8488 * buffer.c (Fbuffer_local_variables)
8489 (buffer_lisp_local_variables): Handle unbound vars correctly;
8490 don't let Qunbound leak into Lisp.
8491
af008560
GM
84922012-02-07 Glenn Morris <rgm@gnu.org>
8493
dd605cc4
GM
8494 * image.c (Fimagemagick_types): Doc fix.
8495
af008560
GM
8496 * image.c (imagemagick-render-type): Change it from a lisp object
8497 to an integer. Move the doc here from the lisp manual.
8498 Treat all values not equal to 0 the same.
8499
1449fa1d
CY
85002012-02-06 Chong Yidong <cyd@gnu.org>
8501
8502 * doc.c (store_function_docstring): Avoid applying docstring of
8503 alias to base function (Bug#2603).
8504
3723ec07
AS
85052012-02-04 Andreas Schwab <schwab@linux-m68k.org>
8506
8507 * .gdbinit (pp1, pv1): Remove redundant defines.
8508 (pr): Use pp.
8509
79c1cc1e
CY
85102012-02-04 Chong Yidong <cyd@gnu.org>
8511
8512 * nsterm.m: Declare a global (Bug#10694).
8513
d7f29f8e
EZ
85142012-02-04 Eli Zaretskii <eliz@gnu.org>
8515
cae07000
SM
8516 * w32.c (get_emacs_configuration_options):
8517 Include --enable-checking, if specified, in the return value.
d7f29f8e 8518
3b95a6f9
MR
85192012-02-04 Martin Rudalics <rudalics@gmx.at>
8520
8521 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
8522 after rounding frame sizes. (Bug#9723)
8523
d6fa96a6
EZ
85242012-02-04 Eli Zaretskii <eliz@gnu.org>
8525
8526 * keyboard.c (adjust_point_for_property): Don't position point
8527 before BEGV. (Bug#10696)
8528
df0b2940
PE
85292012-02-03 Paul Eggert <eggert@cs.ucla.edu>
8530
8531 Handle overflow when computing char display width (Bug#9496).
8532 * character.c (char_width): Return EMACS_INT, not int.
8533 (char_width, c_string_width): Check for overflow when
8534 computing the width; this is possible now that individual
8535 characters can have unbounded width. Problem introduced
8536 by merge from Emacs 23 on 2012-01-19.
8537
6bee44d6
MA
85382012-02-02 Michael Albinus <michael.albinus@gmx.de>
8539
8540 * dbusbind.c (Fdbus_register_method): Mention the return value
8541 :ignore in the docstring.
8542
44f92739
GM
85432012-02-02 Glenn Morris <rgm@gnu.org>
8544
1b9f60cc
GM
8545 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
8546
44f92739
GM
8547 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8548 Unconditionally set to t. (Bug#10673)
8549 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8550 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
8551 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
8552
c5d3843c
KH
85532012-02-02 Kenichi Handa <handa@m17n.org>
8554
8555 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
8556 0, do not call append_composite_glyph.
8557
159462d4 85582012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
8559
8560 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
8561 NULL (Bug#6988).
8562 (x_produce_glyphs): If the component of a composition is a null
8563 string, set it->pixel_width to 1 to avoid zero-width glyph.
8564
78cef877
EZ
85652012-02-01 Eli Zaretskii <eliz@gnu.org>
8566
8567 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
8568 first 2 arguments are identical. This makes inserting large
8569 output from a subprocess an order of magnitude faster on
8570 MS-Windows, where all sbrk'ed memory is always contiguous.
8571
97897668
GM
85722012-01-31 Glenn Morris <rgm@gnu.org>
8573
8574 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 8575 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
8576 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
8577
31fd3586
GM
85782012-01-29 Glenn Morris <rgm@gnu.org>
8579
8580 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
8581
0e24a8b2
CY
85822012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
8583
8584 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
8585
cc0adcb0
CY
85862012-01-28 Chong Yidong <cyd@gnu.org>
8587
8588 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
8589
acc28cb9
CY
85902012-01-26 Chong Yidong <cyd@gnu.org>
8591
9c69cfb7
CY
8592 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
8593
acc28cb9
CY
8594 * search.c (Fsearch_forward, Fsearch_backward): Document negative
8595 repeat counts (Bug#10507).
8596
48da7392
GM
85972012-01-26 Glenn Morris <rgm@gnu.org>
8598
8599 * lread.c (syms_of_lread): Doc fix.
8600
14af5f7f
CY
86012012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
8602
8603 * coding.c (encode_designation_at_bol): Change return value to
8604 EMACS_INT.
8605
0b21c100
CY
86062012-01-25 Chong Yidong <cyd@gnu.org>
8607
8608 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
8609
3c2907f7
CY
86102012-01-21 Chong Yidong <cyd@gnu.org>
8611
8612 * floatfns.c (Fcopysign): Make the second argument non-optional,
8613 since nil is not allowed anyway.
8614
959ad23f
AS
86152012-01-21 Andreas Schwab <schwab@linux-m68k.org>
8616
8617 * process.c (read_process_output): Use p instead of XPROCESS (proc).
8618 (send_process): Likewise.
8619
34a02f46
MR
86202012-01-19 Martin Rudalics <rudalics@gmx.at>
8621
8622 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
8623 (Vwindow_persistent_parameters): Do not use Qstate.
8624 Rewrite doc-strings.
34a02f46 8625
1259009a 86262012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
8627
8628 * character.c (char_width): New function.
70d4fdf6
GM
8629 (Fchar_width, c_string_width, lisp_string_width):
8630 Use char_width (Bug#9496).
25ed9e61 8631
6a6ee00d
MR
86322012-01-16 Martin Rudalics <rudalics@gmx.at>
8633
8634 * window.c (Vwindow_persistent_parameters): New variable.
8635 (Fset_window_configuration, save_window_save): Handle persistent
8636 window parameters.
8637
c85efaf7
EZ
86382012-01-14 Eli Zaretskii <eliz@gnu.org>
8639
8640 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
8641 thrashing the stack of the thread. (Bug#9087)
8642
5944709e
PE
86432012-01-12 Paul Eggert <eggert@cs.ucla.edu>
8644
8645 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
8646
e71f5d99
EZ
86472012-01-11 Eli Zaretskii <eliz@gnu.org>
8648
8649 * xdisp.c (rows_from_pos_range): Handle the case where the
8650 highlight ends on a newline. (Bug#10464)
8651 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
8652 he end column for display of highlight that ends on a newline
8653 before a R2L line.
8654
ce316182
GM
86552012-01-11 Glenn Morris <rgm@gnu.org>
8656
8657 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
8658 from load-path also when installation-directory is nil. (Bug#10208)
8659
5b43da69
GM
86602012-01-10 Glenn Morris <rgm@gnu.org>
8661
74cc8ff9
GM
8662 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
8663
7d8d6e4e
GM
8664 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
8665 Update template values to be closer to their typical values these days.
5b43da69 8666
a0db8d43
EZ
86672012-01-09 Eli Zaretskii <eliz@gnu.org>
8668
8669 * xdisp.c (rows_from_pos_range): Accept additional argument
8670 DISP_STRING, and accept any glyph in a row whose object is that
8671 string as eligible for mouse highlight. Fixes mouse highlight of
8672 display strings from overlays. (Bug#10464)
8673
9a0115ab 86742012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 8675
b9110d6a 8676 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
8677 * fileio.c (auto_saving_dir_umask): New static var.
8678 (Fmake_directory_internal): Use it.
8679 (do_auto_save_make_dir): Set it, instead of invoking chmod after
8680 creating the directory. The old code temporarily assigns
8681 too-generous permissions to the directory.
8682 (do_auto_save_eh): Clear it.
b9110d6a 8683 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
8684 that the var is always cleared.
8685
6c1bd3f3
EZ
86862012-01-07 Eli Zaretskii <eliz@gnu.org>
8687
8688 * search.c (scan_buffer): Pass character positions to
8689 know_region_cache, not byte positions. (Bug#6540)
8690
069d2b50
L
86912012-01-07 LynX <_LynX@bk.ru> (tiny change)
8692
8693 * w32.c (sys_rename): Report EXDEV when rename of a directory
8694 fails because the target is on another logical disk. (Bug#10284)
8695
75bf0d33
DB
86962012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
8697
8698 * xterm.c (x_embed_request_focus): New function.
8699
8700 * xterm.h: Add prototype.
8701
8702 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
8703
1c6e5a32
GM
87042012-01-05 Glenn Morris <rgm@gnu.org>
8705
8706 * emacs.c (emacs_copyright): Update short copyright year to 2012.
8707
651e947e
EZ
87082012-01-01 Eli Zaretskii <eliz@gnu.org>
8709
8710 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
8711 Load gnutls_transport_set_lowat only if GnuTLS version is below
8712 2.11.1.
8713 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
8714 GnuTLS versions below 2.11.1.
8715
3778cdd8
AL
87162011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
8717
8718 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
8719 to the doc string advising against its use for altering the way
8720 windows are scrolled.
8721
0e5317f7
KH
87222011-12-28 Kenichi Handa <handa@m17n.org>
8723
8724 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
8725 coding-system ASCII compatible only when it does not produce BOM
8726 on encoding (Bug#10383).
8727
93d5ca1f
JD
87282011-12-26 Jan Djärv <jan.h.d@swipnet.se>
8729
8730 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
8731 can scroll.
8732 (create_and_show_popup_menu): Always use menu_position_func for
8733 Gtk3 (Bug#10361).
8734
ca22b785
AS
87352011-12-24 Andreas Schwab <schwab@linux-m68k.org>
8736
8737 * callint.c (Fcall_interactively): Don't truncate prompt string.
8738
d048e1e6
EZ
87392011-12-23 Eli Zaretskii <eliz@gnu.org>
8740
8741 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
8742 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 8743 resumed from there (after widening). (Bug#10360)
d048e1e6 8744
5ccaba1f
JD
87452011-12-22 Jan Djärv <jan.h.d@swipnet.se>
8746
8747 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
8748
204ee57f
JD
87492011-12-21 Jan Djärv <jan.h.d@swipnet.se>
8750
b81d40f0
JB
8751 * nsterm.m (x_free_frame_resources):
8752 Release f->output_data.ns->miniimage.
204ee57f
JD
8753 (ns_index_color): Fix indentation. Do not retain
8754 color_table->colors[i].
8755
8756 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
8757 before returning.
8758
8759 * nsfns.m (x_set_background_color): Assign return value from
8760 ns_index_color to face-background instead of NSColor*.
8761 (ns_implicitly_set_icon_type): Fix indentation.
8762 Change assignment in for loop to comparison.
8763
8764 * emacs.c (ns_pool): New variable.
8765 (main): Assign ns_pool.
8766 (Fkill_emacs): Call ns_release_autorelease_pool.
8767
8768 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
8769 autorelease fdesc, release fdAttrs and tdict.
8770 (ns_get_covering_families): Release charset.
8771 (ns_findfonts): Release NSFontDescriptor created with new.
8772 (ns_uni_to_glyphs): Fix indentation.
8773 (setString): Release attrStr before assigning new value.
8774
c803b2b7
JD
87752011-12-18 Jan Djärv <jan.h.d@swipnet.se>
8776
678f4426
JD
8777 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
8778 and NS_IMPL_COCOA.
8779 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
8780 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
8781
cd394be1 87822011-12-18 David Reitter <reitter@cmu.edu>
678f4426 8783
5fecd5fc
JD
8784 * nsterm.m (ns_term_init): Subscribe for notifications
8785 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
8786 to method trackingNotification in EmacsMenu.
8787
8788 * nsmenu.m (trackingMenu): New variable.
3771cb17 8789 (trackingNotification): New method (from Aquamacs).
5fecd5fc 8790 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 8791 from Aquamacs (Bug#7030).
678f4426
JD
8792
87932011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 8794
c803b2b7
JD
8795 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
8796 (symbol_to_nsstring): Fix indentation.
8797 (ns_symbol_to_pb): New function.
cae07000
SM
8798 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
8799 (Fns_rotate_cut_buffers_internal): Remove.
8800 (Fns_store_selection_internal): Rename from
c803b2b7
JD
8801 Fns_store_cut_buffer_internal.
8802 (ns_get_foreign_selection, Fx_own_selection_internal)
8803 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
8804 (Fns_get_selection_internal, Fns_store_selection_internal):
8805 Use ns_symbol_to_pb and check if return value is nil.
8806 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
8807 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
8808 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
8809 renamed to Sns_store_selection_internal.
8810 (ns_handle_selection_request): Move code to Fx_own_selection_internal
8811 and remove this function.
8812 (ns_handle_selection_clear): Remove, never used.
8813 (Fx_own_selection_internal): Move code from ns_handle_selection_request
8814 here.
8815
e1b01a3a
KB
88162011-12-17 Ken Brown <kbrown@cornell.edu>
8817
8818 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
8819 GID is unknown (Bug#10257).
8820
2adb6e85
PE
88212011-12-17 Paul Eggert <eggert@cs.ucla.edu>
8822
8823 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
8824 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
8825 which caused a build failure on GNU/Linux IA-64. This problem was
8826 introduced by my 2011-10-07 patch.
8827
d1d7b339
JL
88282011-12-15 Juri Linkov <juri@jurta.org>
8829
8830 * image.c (imagemagick_error): New function. (Bug#10112)
8831 (imagemagick_load_image): Comment out `MagickSetResolution' call.
8832 Use `imagemagick_error' where ImageMagick functions return
8833 `MagickFalse'.
8834 (Fimagemagick_types): Add `Fnreverse' to return the list in the
8835 proper order.
8836
100d5755
KH
88372011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8838
8839 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
8840 fill background (Bug#8992).
8841
454592a6
MR
88422011-12-13 Martin Rudalics <rudalics@gmx.at>
8843
8844 * window.c (Vwindow_combination_resize)
8845 (Vwindow_combination_limit): Use t instead of non-nil in
8846 doc-strings.
61d4b438
MR
8847 (Vrecenter_redisplay): Add first sentence of doc-string on
8848 separate line.
53524d93 8849 (Frecenter): Fix doc-string typo.
454592a6 8850
3633e3aa
KH
88512011-12-11 Kenichi Handa <handa@m17n.org>
8852
8853 * coding.c (Funencodable_char_position): Pay attention to the
8854 buffer text relocation (Bug#9389).
8855
7b9d523a 88562011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 8857
7b9d523a
JD
8858 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
8859 gtk_init (Bug#10100).
8860
b73189c6
EZ
88612011-12-10 Eli Zaretskii <eliz@gnu.org>
8862
8863 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
8864 IT->string is nil. (Bug#10263)
8865
f7dfe5d6
JD
88662011-12-10 Jan Djärv <jan.h.d@swipnet.se>
8867
83faebb4
JD
8868 * nsterm.h (x_free_frame_resources): Declare.
8869
f7dfe5d6
JD
8870 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
8871 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
8872
8873 * nsterm.h (ns_get_defaults_value): Declare.
8874
8875 * nsterm.m (ns_default): Call ns_get_defaults_value.
8876
7cd4e72c
EZ
88772011-12-09 Eli Zaretskii <eliz@gnu.org>
8878
8879 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
8880 (Bug#10170)
8881
b34d7317
YM
88822011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8883
8884 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
8885 that where the value of an _OBJC_* symbol points to is in the .bss
8886 section (Bug#10240).
8887
76470ad1
KH
88882011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8889
8890 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 8891 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 8892
745fff94
KH
88932011-12-08 Kenichi Handa <handa@m17n.org>
8894
8895 * ftfont.c (get_adstyle_property): Fix previous change
8896 (Bug#10233).
8897
6e44397c
JB
88982011-12-07 Juanma Barranquero <lekktu@gmail.com>
8899
8900 * w32.c (init_environment): If no_site_lisp, remove site-lisp
8901 dirs from the default value of EMACSLOADPATH (bug#10208).
8902
7efa6272
GM
89032011-12-07 Glenn Morris <rgm@gnu.org>
8904
8905 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
8906 installation and source directories as well. (Bug#10208)
8907
f6fc4d87
CY
89082011-12-06 Chong Yidong <cyd@gnu.org>
8909
8910 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
8911
2bf26180
GM
89122011-12-06 Glenn Morris <rgm@gnu.org>
8913
8914 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
8915 as an error, not just -1. (Bug#10217)
8916
3a6ad4f0
CY
89172011-12-05 Chong Yidong <cyd@gnu.org>
8918
8919 * keyboard.c (process_special_events): New function.
8920 (swallow_events, Finput_pending_p): Use it (Bug#10195).
8921
75a3b399
PE
89222011-12-05 Paul Eggert <eggert@cs.ucla.edu>
8923
8924 * coding.c (encode_designation_at_bol): Don't use uninitialized
8925 local variable (Bug#9318).
8926
c3c9e25e
KH
89272011-12-05 Kenichi Handa <handa@m17n.org>
8928
8929 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
8930 return Qnil (Bug#8046, Bug#10193).
8931
5eb05ea3
KH
89322011-12-05 Kenichi Handa <handa@m17n.org>
8933
8934 * coding.c (encode_designation_at_bol): New args charbuf_end and
8935 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
8936 (coding_set_source): Return how many bytes coding->source was
8937 relocated.
8938 (coding_set_destination): Return how many bytes
8939 coding->destination was relocated.
8940 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 8941 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
8942
89432011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8944
8945 * coding.c (CODING_CHAR_CHARSET_P): New macro.
8946 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
8947 macro (Bug#9318).
8948
89492011-12-05 Andreas Schwab <schwab@linux-m68k.org>
8950
8951 The following changes are to fix Bug#9318.
8952
a79703f5 8953 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
8954 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
8955 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 8956 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 8957
7dbda6df
JB
89582011-12-05 Juanma Barranquero <lekktu@gmail.com>
8959
8960 * lisp.h (process_quit_flag): Fix external declaration.
8961
6d5eb5b0
SM
89622011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
8963
8964 Don't macro-inline non-performance-critical code.
8965 * eval.c (process_quit_flag): New function.
8966 * lisp.h (QUIT): Use it.
8967
a0c3fad0
JD
89682011-12-04 Jan Djärv <jan.h.d@swipnet.se>
8969
8970 * nsfns.m (get_geometry_from_preferences): New function.
8971 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
8972
6c07aac2
AS
89732011-12-04 Andreas Schwab <schwab@linux-m68k.org>
8974
8975 * emacs.c (Qkill_emacs): Define.
8976 (syms_of_emacs): Initialize it.
8977 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
8978 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
8979 (quit_throw_to_read_char): Add parameter `from_signal'.
8980 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
8981 * lisp.h (QUIT): Call Fkill_emacs if requested.
8982
c052ead4
JD
89832011-12-03 Jan Djärv <jan.h.d@swipnet.se>
8984
8985 * widget.c (update_wm_hints): Return if wmshell is null.
8986 (widget_update_wm_size_hints): New function.
8987
8988 * widget.h (widget_update_wm_size_hints): Declare.
8989
8990 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
8991 widget_update_wm_size_hints (Bug#10104).
8992
9e49252b
EZ
89932011-12-03 Eli Zaretskii <eliz@gnu.org>
8994
8995 * xdisp.c (handle_invisible_prop): If the invisible text ends just
8996 before a newline, prepare the bidi iterator for consuming the
8997 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 8998 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 8999
02b16839
JL
90002011-12-02 Juri Linkov <juri@jurta.org>
9001
9002 * search.c (Fword_search_regexp): New Lisp function created from
9003 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
9004 (Fword_search_backward, Fword_search_forward)
9005 (Fword_search_backward_lax, Fword_search_forward_lax):
9006 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
9007 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
9008
0068070e
SM
90092011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
9010
9011 * fileio.c (Finsert_file_contents): Move after-change-function call
9012 to before the "handled:" label, since all "goto handled" appear in
9013 cases where the *-change-functions have already been properly called
9014 (bug#10117).
9015
3360a3fc
AS
90162011-12-01 Andreas Schwab <schwab@linux-m68k.org>
9017
9018 * keyboard.c (interrupt_signal): Don't call kill-emacs when
9019 waiting for input. (Bug#10169)
9020
73d6c093
EZ
90212011-11-30 Eli Zaretskii <eliz@gnu.org>
9022
9023 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
9024 verifies glyph row's hash code--we have just reallocated the
9025 glyphs, so their contents can be complete garbage. (Bug#10164)
9026
febe6bea
JB
90272011-11-30 Juanma Barranquero <lekktu@gmail.com>
9028
9029 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
9030
801a4313
EZ
90312011-11-30 Eli Zaretskii <eliz@gnu.org>
9032
9033 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
9034 attributes are tested _before_ calling verify_row_hash, to protect
9035 against GCC re-ordering of the tests. (Bug#10164)
9036
2b56b87e
JD
90372011-11-29 Jan Djärv <jan.h.d@swipnet.se>
9038
9039 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
9040
9041 * xterm.c (handle_one_xevent): Only set async_visible and friends
9042 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 9043 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
9044 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
9045
dbf31225
PE
90462011-11-28 Paul Eggert <eggert@cs.ucla.edu>
9047
9048 Remove GCPRO-related macros that exist only to avoid shadowing locals.
9049 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
9050 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
9051 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9052 All uses changed to use GCPRO1 etc.
9053 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
9054 Revert to old implementation (i.e., before 2011-03-11).
9055
1305621b
YM
90562011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9057
9058 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
9059 of scroll runs so as to avoid assigning disabled bogus rows and
9060 unnecessary graphics copy operations.
9061
8c9afb46
EZ
90622011-11-27 Eli Zaretskii <eliz@gnu.org>
9063
9064 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
9065 (snprintf) [_MSC_VER]: Redirect to _snprintf.
9066 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
9067 (malloc, free, realloc, calloc): Redirect to e_* only when
9068 compiling Emacs.
9069
9070 * lisp.h (GCTYPEBITS): Move before first use.
9071 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
9072 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
9073 this macro definition.
9074
9075 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
9076 _MSC_VER.
9077
54e9e3bf
JD
90782011-11-27 Jan Djärv <jan.h.d@swipnet.se>
9079
6d5eb5b0
SM
9080 * gtkutil.c (xg_create_frame_widgets):
9081 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
9082 present with Gtk+ 2.0.
9083
83aca1cb
PE
90842011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9085
9086 * fileio.c (Finsert_file_contents): Undo previous change; see
9087 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9088
5b76caa4
PE
90892011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9090
9091 Rename locals to avoid shadowing.
9092 * fileio.c (Finsert_file_contents):
9093 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
9094 * process.c (wait_reading_process_output):
9095 Rename inner 'proc' to 'p' to avoid shadowing.
9096 Indent for consistency with usual Emacs style.
9097
8c535114
EZ
90982011-11-25 Eli Zaretskii <eliz@gnu.org>
9099
9100 * xdisp.c (redisplay_window): If cursor row is not fully visible
9101 after recentering, and scroll-conservatively is set to a large
9102 number, scroll window by a few more lines to make the cursor fully
9103 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
9104 (start_display): Don't move to the next line if the display should
9105 start at a newline that is part of a display vector or an overlay
9106 string. (Bug#10119)
8c535114 9107
fa4fdb5c
JL
91082011-11-24 Juri Linkov <juri@jurta.org>
9109
9110 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
9111 after the `MagickPingImage' call. (Bug#10112)
9112
90ec88df
CY
91132011-11-23 Chong Yidong <cyd@gnu.org>
9114
9115 * window.c (Fcoordinates_in_window_p): Accept only live windows.
9116
56e2e794
MR
91172011-11-23 Martin Rudalics <rudalics@gmx.at>
9118
9119 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
9120 making another buffer current. (Bug#10114)
9121
b6e64c41
GM
91222011-11-23 Glenn Morris <rgm@gnu.org>
9123
9124 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
9125
6b21de18
CY
91262011-11-23 Chong Yidong <cyd@gnu.org>
9127
9128 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
9129 using it (Bug#5984).
9130
b12cd789
EZ
91312011-11-22 Eli Zaretskii <eliz@gnu.org>
9132
9133 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
9134 and header-lines, as they don't have one computed for them.
9135 (Bug#10098)
9136
9137 * .gdbinit (prow): Make displayed values more self-explaining.
9138 Add row's hash code.
9139
261b6fd4
LMI
91402011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
9141
9142 * process.c (wait_reading_process_output): Fix asynchrounous
9143 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 9144 (wait_reading_process_output): Add comment and URL.
261b6fd4 9145
e7cfd277
JD
91462011-11-21 Jan Djärv <jan.h.d@swipnet.se>
9147
9148 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
9149
a9b9b7f5
CY
91502011-11-21 Chong Yidong <cyd@gnu.org>
9151
9152 * window.c (Fnext_window, Fprevious_window): Doc fix.
9153
b0d15b4f
SM
91542011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9155
9156 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
9157
fe7a3057
JB
91582011-11-20 Juanma Barranquero <lekktu@gmail.com>
9159
9160 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
9161
d2999b1a
MR
91622011-11-20 Martin Rudalics <rudalics@gmx.at>
9163
9164 * window.c (Fset_window_combination_limit): Rename argument
9165 STATUS to LIMIT.
9166 (Vwindow_combination_limit): Remove "status" from doc-string.
9167
d5ff9cd0
AS
91682011-11-20 Andreas Schwab <schwab@linux-m68k.org>
9169
9170 * m/ibms390.h: Remove.
9171 * m/ibms390x.h: Don't include "ibms390.h".
9172
a5bb9bd3
SM
91732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9174
9175 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
9176 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
9177
cd1181db
JB
91782011-11-20 Juanma Barranquero <lekktu@gmail.com>
9179
9180 * casetab.c (Fset_case_table):
9181 * charset.c (Fcharset_after): Fix typos.
9182
615a3b8d 91832011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 9184
17e845af
PE
9185 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
9186 Otherwise, valgrind does not work on some platforms.
9187 Problem reported by Andreas Schwab in
6a0bf43d
PE
9188 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
9189 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
9190 is set, removing the need for VIRT_ADDRESS_VARIES.
9191 (PURE_P): Use a more-efficient implementation that needs just one
9192 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
9193 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
9194 to 4 (xorl, subq, cmpq, setbe).
9195 * alloc.c (pure): Always extern now, since that's the
9196 VIRT_ADDR_VARIES behavior.
9197 (PURE_POINTER_P): Use a single comparison, not two, for
9198 consistency with the new puresize.h.
9199 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
9200 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
9201 Remove VIRT_ADDR_VARIES no longer needed.
9202
f8fe6f96
EZ
92032011-11-19 Eli Zaretskii <eliz@gnu.org>
9204
9205 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
9206 (erase_phys_cursor, update_window_cursor, show_mouse_face)
9207 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
9208 behave as if the cursor position were at the window margin.
9209
9210 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
9211 and the cursor position is out of bounds, behave as if the cursor
9212 position were at the window margin. (Bug#10075)
9213
df05a53c
CY
92142011-11-18 Chong Yidong <cyd@gnu.org>
9215
9216 * window.c (Fwindow_combination_limit): Make first argument
9217 non-optional, since it is meaningless for live windows like the
9218 selected window.
61ccba97 9219
2071918e
DA
92202011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
9221
9222 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
9223
b50a28de
SM
92242011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
9225
9226 * intervals.c: Fix grafting over the whole buffer (bug#10071).
9227 (graft_intervals_into_buffer): Simplify.
9228
015137db
EZ
92292011-11-18 Eli Zaretskii <eliz@gnu.org>
9230
9231 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
9232 hash values of the two rows.
9233 (copy_row_except_pointers): Preserve the used[] arrays and the
9234 hash values of the two rows. (Bug#10035)
68c95424 9235 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
9236
9237 * xdisp.c (row_hash): New function, body extracted from
9238 compute_line_metrics.
9239 (compute_line_metrics): Call row_hash, instead of computing the
9240 hash code inline.
9241
9242 * dispnew.c (verify_row_hash): Call row_hash for computing the
9243 hash code of a row, instead of duplicating code from xdisp.c.
9244
9245 * dispextern.h (row_hash): Add prototype.
9246
a2addb04
TH
92472011-11-18 Tassilo Horn <tassilo@member.fsf.org>
9248
9249 * frame.c (delete_frame): Don't delete the terminal when the last
9250 X frame is closed if emacs is built with GTK toolkit.
9251
df85d315
JB
92522011-11-17 Juanma Barranquero <lekktu@gmail.com>
9253
9254 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
9255
a0c2d0ae
MR
92562011-11-17 Martin Rudalics <rudalics@gmx.at>
9257
9258 * window.c (Vwindow_splits): Rename to
9259 Vwindow_combination_resize. Suggested by Juri Linkov.
9260 (Fsplit_window_internal): Use Vwindow_combination_resize instead
9261 of Vwindow_splits.
9262
58179cce
JB
92632011-11-16 Juanma Barranquero <lekktu@gmail.com>
9264
7877f373
JB
9265 * nsfns.m (Fns_font_name):
9266 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 9267
b6f67890
MR
92682011-11-16 Martin Rudalics <rudalics@gmx.at>
9269
9270 * window.h (window): Rename slot "nest" to "combination_limit".
9271 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
9272 (Fset_window_nest): Rename to Fset_window_combination_limit.
9273 (Vwindow_nest): Rename to Vwindow_combination_limit.
9274 (recombine_windows, make_parent_window, make_window)
9275 (Fsplit_window_internal, saved_window)
9276 (Fset_window_configuration, save_window_save): Rename all
9277 occurrences of window_nest to window_combination_limit.
9278
c7015153
JB
92792011-11-15 Juanma Barranquero <lekktu@gmail.com>
9280
9281 * image.c (imagemagick_load_image): Fix typo.
9282
322ad6ec
EZ
92832011-11-14 Eli Zaretskii <eliz@gnu.org>
9284
9285 * xdisp.c (display_line): Move the call to
9286 highlight_trailing_whitespace before the call to
9287 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
9288 faces of all the glyphs to compute ROW's hash value.
9289 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 9290
f067b8ec
JB
92912011-11-14 Juanma Barranquero <lekktu@gmail.com>
9292
9293 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
9294 just return (bug#10044).
9295
1e5b2111
EZ
92962011-11-12 Eli Zaretskii <eliz@gnu.org>
9297
7ef3cbd5
EZ
9298 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
9299 with user-defined heap size. Bump the default size of the temacs
9300 heap to 27MB, to avoid memory warning when running temacs.
9301 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
9302
1e5b2111
EZ
9303 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
9304 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
9305 (verify_row_hash) [XASSERTS]: New function.
9306 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
9307 that the hash value of glyph rows is correct.
1e5b2111 9308
89d61221
MR
93092011-11-12 Martin Rudalics <rudalics@gmx.at>
9310
9311 * window.h (window): Remove splits slot.
9312 * window.c (Fwindow_splits, Fset_window_splits): Remove.
9313 (Fdelete_other_windows_internal, make_parent_window)
9314 (make_window, Fsplit_window_internal, Fdelete_window_internal)
9315 (Fset_window_configuration, save_window_save): Don't deal with
9316 split status of windows.
9317 (saved_window): Remove splits slot.
9318 (Vwindow_splits): Rewrite doc-string.
9319
97f18cc8
JD
93202011-11-11 Jan Djärv <jan.h.d@swipnet.se>
9321
9322 * xfns.c (unwind_create_frame):
9323 * nsfns.m (unwind_create_frame):
9324 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
9325 Vframe_list (Bug#9999).
9326
22a648b4
DA
93272011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
9328
0b381c7e 9329 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 9330
659afede
KH
93312011-11-11 Kenichi Handa <handa@m17n.org>
9332
9333 * callproc.c (Fcall_process): Set the member dst_multibyte of
9334 process_coding.
9335
9ac0394b
KH
93362011-11-11 Johan Bockgård <bojohan@gnu.org>
9337
9338 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
9339 avoid a crash (bug#9496).
9340
2fbdc249
CY
93412011-11-09 Chong Yidong <cyd@gnu.org>
9342
9343 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
9344 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
9345
ac6b1f81
PE
93462011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9347
9348 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
9349
09db192c
PE
93502011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9351
9352 Avoid some portability problems by eschewing 'extern inline' functions.
9353 The trivial performance wins aren't worth the portability hassles; see
9354 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
9355 et seq.
9356 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
9357 (window_box_width, window_box_left, window_box_left_offset)
9358 (window_box_right, window_box_right_offset): Undo previous change,
9359 by removing the "extern"s.
9360 * intervals.c (adjust_intervals_for_insertion)
9361 (adjust_intervals_for_deletion): Undo previous change,
9362 making these static again.
9363 (offset_intervals, temp_set_point_both, temp_set_point)
9364 (copy_intervals_to_string): No longer inline.
9365 * xdisp.c (window_text_bottom_y, window_box_width)
9366 (window_box_height, window_box_left_offset)
9367 (window_box_right_offset, window_box_left, window_box_right)
9368 (window_box): No longer inline.
9369
105216ed
CY
93702011-11-08 Chong Yidong <cyd@gnu.org>
9371
9372 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
9373 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
9374 Signal an error if not a live window.
105216ed
CY
9375 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
9376 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
9377
ae9e237f
JB
93782011-11-07 Juanma Barranquero <lekktu@gmail.com>
9379
9380 * lisp.h (syms_of_abbrev): Remove declaration.
9381 Reported by CHENG Gao <chenggao@royau.me>.
9382
c7aa8333
EZ
93832011-11-07 Eli Zaretskii <eliz@gnu.org>
9384
9385 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
9386 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
9387 of temacs in GUI mode.
9388
be7f5545
MR
93892011-11-07 Martin Rudalics <rudalics@gmx.at>
9390
9391 * window.h: Declare delete_all_child_windows instead of
9392 delete_all_subwindows.
9393 * window.c (Fwindow_nest, Fset_window_nest)
9394 (Fset_window_new_total, Fset_window_new_normal)
9395 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
9396 (delete_all_subwindows): Rename to delete_all_child_windows.
9397 (Fdelete_other_windows_internal, Fset_window_configuration):
9398 Call delete_all_child_windows instead of delete_all_subwindows.
9399 * frame.c (delete_frame): Call delete_all_child_windows instead
9400 of delete_all_subwindows.
9401
ca78dc43
PE
94022011-11-07 Paul Eggert <eggert@cs.ucla.edu>
9403
9404 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
9405 This is also needed for porting to any host where GC_MARK_STACK is
9406 not GC_MAKE_GCPROS_NOOPS.
9407 (which_symbols): Use it.
9408
a0241d01
KH
94092011-11-07 Kenichi Handa <handa@m17n.org>
9410
9411 * coding.c (coding_set_destination): Check coding->src_pos only
9412 when coding->src_object is a buffer (bug#9910).
9413
9414 * process.c (send_process): Set the member src_multibyte of coding
9415 to 0 (bug#9911) when sending a unibyte text.
9416
9417 * callproc.c (Fcall_process): Set the member src_multibyte of
9418 process_coding to 0 (bug#9912).
9419
a64bfdfa 94202011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
9421
9422 * xmenu.c (cleanup_widget_value_tree): New function.
9423 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
9424 calling free_menubar_widget_value_tree directly (Bug#9830).
9425
cb41b32a
PE
94262011-11-06 Paul Eggert <eggert@cs.ucla.edu>
9427
9428 Fix some portability problems with 'inline'.
9429 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
9430 (window_box_width, window_box_left, window_box_left_offset)
9431 (window_box_right, window_box_right_offset): Declare extern.
9432 Otherwise, these inline functions do not conform to C99 and
9433 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
9434 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
9435 * intervals.c (adjust_intervals_for_insertion)
9436 (adjust_intervals_for_deletion): Now extern, because otherwise the
9437 extern inline functions 'offset_intervals' couldn't refer to it.
9438 (static_offset_intervals): Remove.
9439 (offset_intervals): Rewrite using the old contents of
9440 static_offset_intervals. The old version didn't conform to C99
9441 because an extern inline function contained a reference to an
9442 identifier with static linkage.
9443
b7041366
AS
94442011-11-06 Andreas Schwab <schwab@linux-m68k.org>
9445
9446 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
9447 GC.
9448
88a37c4d
EZ
94492011-11-06 Eli Zaretskii <eliz@gnu.org>
9450
9451 * xdisp.c (init_iterator, reseat_to_string): Don't set the
9452 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
9453 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
9454 return Qleft_to_right.
9455
49745b39
CY
94562011-11-06 Chong Yidong <cyd@gnu.org>
9457
9458 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
9459 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
9460 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
9461 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
9462 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
9463 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
9464 (Fwindow_vscroll): Doc fix.
9465 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
9466 argument, since it makes no sense to pass a live window and for
9467 consistency with window-child.
9468
1f05cd82
CS
94692011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
9470
9471 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
9472 support MSVC.
9473
22610910
JR
94742011-11-05 Jason Rumney <jasonr@gnu.org>
9475
9476 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
9477 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
9478 fonts (Bug#6029).
9479 (add_font_entity_to_list): Fix logic errors in mixed boolean and
9480 bitwise arithmetic preventing use of unicode-sip and non-truetype
9481 opentype fonts.
9482
a06776b2
EZ
94832011-11-05 Eli Zaretskii <eliz@gnu.org>
9484
3ad924ba
EZ
9485 * s/ms-w32.h (fstat, stat, utime): Move redirections to
9486 "emacs"-only part.
9487
a06776b2
EZ
9488 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
9489 initialization code to keep similarity to xfns.c after changes
9490 from 2011-11-05.
9491
c9e7db78
JD
94922011-11-05 Jan Djärv <jan.h.d@swipnet.se>
9493
a97f8f3f
JD
9494 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
9495 (unwind_create_frame): New function (Bug#9943).
9496 (Fx_create_frame): Restructure code to be more similar to the one in
9497 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
9498 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
9499 Move terminal->reference_count++ just before making the frame official
9500 (Bug#9943).
9501
9502 * nsterm.m (x_free_frame_resources): New function.
9503 (x_destroy_window): Move code to x_free_frame_resources.
9504
c9e7db78 9505 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
9506 (Fx_create_frame, x_create_tip_frame):
9507 Move terminal->reference_count++ just before making the frame
75f1671a 9508 official. Move initialization of image_cache_refcount and
c9e7db78
JD
9509 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
9510
a6fc3b5c
EZ
95112011-11-05 Eli Zaretskii <eliz@gnu.org>
9512
9513 Support MSVC build with newer versions of Visual Studio.
9514 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
9515 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
9516 nt/gmake.defs.
9517
9518 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
9519 which are not supported by MSVC.
9520 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
9521 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
9522 bitfields.
9523 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
9524 types in bitfields.
9525 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
9526
9527 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
9528
58179cce 95292011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
9530
9531 Support MSVC build with newer versions of Visual Studio.
9532 * w32.c: Don't include w32api.h for MSVC.
9533 (init_environment) [_MSC_VER]: Call sys_access, not _access.
9534
9535 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
9536 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
9537 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
9538 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
9539 e_* cousins.
9540 (alloca) [_MSC_VER]: Define to _alloca.
9541
9542 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
9543
9544 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
9545
a58c13ed
EZ
95462011-11-04 Eli Zaretskii <eliz@gnu.org>
9547
9548 * xdisp.c (note_mouse_highlight): If either of
9549 previous/next-single-property-change returns nil, treat that as
9550 the beginning or the end of the buffer. (Bug#9955)
9551
fe0b6370
JD
95522011-11-04 Jan Djärv <jan.h.d@swipnet.se>
9553
a58c13ed 9554 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
9555 label is not null (Bug#9951).
9556 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
9557 may be NULL.
9558
89bd5ee1
EZ
95592011-11-04 Eli Zaretskii <eliz@gnu.org>
9560
9561 * window.c (Fwindow_body_size): Mention in the doc string that the
9562 return value is in frame's canonical units. (Bug#9949)
9563
84c3edb9
EZ
95642011-11-03 Eli Zaretskii <eliz@gnu.org>
9565
4e2fb5c7
EZ
9566 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
9567
84c3edb9 9568 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 9569 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 9570 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 9571
bc17a887
EZ
95722011-11-01 Eli Zaretskii <eliz@gnu.org>
9573
9574 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
9575 Don't stop backward scan on the continuation glyph, even though
9576 its CHARPOS is positive.
6d5eb5b0
SM
9577 (mouse_face_from_buffer_pos, note_mouse_highlight):
9578 Rename cover_string to disp_string.
bc17a887 9579
4ee88440
MR
95802011-11-01 Martin Rudalics <rudalics@gmx.at>
9581
9582 * window.c (temp_output_buffer_show): Don't use
9583 Vtemp_buffer_show_specifiers.
9584 (Vtemp_buffer_show_specifiers): Remove unused variable.
9585
c2ff3c02
EZ
95862011-10-30 Eli Zaretskii <eliz@gnu.org>
9587
9588 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
9589 past the beginning of the current glyph matrix.
9590
58179cce 95912011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
9592
9593 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
9594 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
9595 HAVE_GTK3 (Bug#9869).
b77a6a7f 9596
3b574623
JD
9597 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
9598 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
9599
b77a6a7f
JD
9600 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
9601
9602 * xterm.c: Declare x_handle_net_wm_state to return int.
9603 (handle_one_xevent): Check if we are iconified but don't have
9604 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
9605 (get_current_wm_state): Return non-zero if not hidden,
9606 check for _NET_WM_STATE_HIDDEN (Bug#9893).
9607 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
9608 (x_handle_net_wm_state): Return what get_current_wm_state returns.
9609 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
9610
196e41e4
PE
96112011-10-29 Paul Eggert <eggert@cs.ucla.edu>
9612
9613 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
9614 so that this new function doesn't get optimized away by a
9615 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
9616
021f2e1a
AS
96172011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9618
9619 * frame.h (MOUSE_HL_INFO): Remove excess parens.
9620
8b058d44
EZ
96212011-10-29 Eli Zaretskii <eliz@gnu.org>
9622
9623 Fix the `xbytecode' command.
9624 * .gdbinit (xprintbytestr): New command.
b50a28de 9625 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
9626 (xbytecode): Print the byte-code string as well.
9627
4452fb80
EZ
96282011-10-29 Kim Storm <storm@cua.dk>
9629
8b058d44
EZ
9630 * alloc.c (which_symbols): New function.
9631
21b72067
AS
96322011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9633
9634 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
9635 line. (Bug#9903)
9636
83ed7b5c
GM
96372011-10-29 Glenn Morris <rgm@gnu.org>
9638
9639 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
9640 Not clear what it was for, and it causes various bugs. (Bug#9839)
9641
5a7a728b
EZ
96422011-10-28 Eli Zaretskii <eliz@gnu.org>
9643
9644 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
9645 possible random value that matches one of those tested as
9646 condition to clear the mouse face.
9647
d3d0842f
CY
96482011-10-28 Chong Yidong <cyd@gnu.org>
9649
9650 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
9651
31b39d13
DN
96522011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
9653
9654 * window.c (make_window): Initialize phys_cursor_on_p.
9655
9aba6043
SM
96562011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
9657
9658 * lisp.h (struct Lisp_Symbol): Update comments.
9659
c20992f4
JB
96602011-10-28 Juanma Barranquero <lekktu@gmail.com>
9661
9662 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
9663
db4f02f2
EZ
96642011-10-28 Eli Zaretskii <eliz@gnu.org>
9665
9666 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
9667 <oslsachem@gmail.com> for helping to debug this.
9668
9669 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
9670 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
9671 (g_b_init_get_glyph_outline_w): New static variables.
9672 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
9673 (GetGlyphOutlineW_Proc): New typedefs.
9674 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
9675 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
9676 New functions.
9677 (w32font_open_internal, compute_metrics):
9678 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
9679 instead of calling the "wide" APIs directly.
9680
9681 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
9682
9683 * w32.h (syms_of_w32font): Add prototype.
9684
87e68db4
JB
96852011-10-27 Juanma Barranquero <lekktu@gmail.com>
9686
9687 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
9688 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
9689 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
9690 (Fmove_to_window_line): Doc fix.
9691
435c1d67
CY
96922011-10-27 Chong Yidong <cyd@gnu.org>
9693
9694 * process.c (make_process): Set gnutls_state to NULL.
9695
9696 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
9697 non-NULL, regardless of GNUTLS_INITSTAGE.
9698 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
9699 an error. Set process slots as soon as we allocate them.
9700
9701 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
9702
9c6c6f49
CY
97032011-10-27 Chong Yidong <cyd@gnu.org>
9704
9aba6043
SM
9705 * gnutls.c (emacs_gnutls_deinit): New function.
9706 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
9707 (Fgnutls_deinit, Fgnutls_boot): Use it.
9708
9709 * process.c (make_process): Initialize GnuTLS credentials to NULL.
9710 (deactivate_process): Call emacs_gnutls_deinit.
9711
657d08d3
JB
97122011-10-27 Juanma Barranquero <lekktu@gmail.com>
9713
9714 * image.c (x_create_x_image_and_pixmap):
9715 * w32.c (sys_rename, w32_delayed_load):
9716 * w32font.c (fill_in_logfont):
9717 * w32reg.c (x_get_string_resource): Silence compiler warnings.
9718
5430d399
JB
97192011-10-26 Juanma Barranquero <lekktu@gmail.com>
9720
9721 * w32fns.c (w32_default_color_map): New function,
9722 extracted from Fw32_default_color_map.
a7ef684b 9723 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 9724
fe0055fa
PE
97252011-10-25 Paul Eggert <eggert@cs.ucla.edu>
9726
9727 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
9728
e6346438
SM
97292011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
9730
9731 * keyboard.c (test_undefined): New function (bug#9751).
9732 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
9733
e112cc37
ET
97342011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
9735
9736 * sysdep.c (init_sys_modes): Fix the check for the controlling
9737 terminal (Bug#6649).
9738
7b5d6677
EZ
97392011-10-20 Eli Zaretskii <eliz@gnu.org>
9740
9741 * dispextern.h (struct bidi_it): New member next_en_type.
9742
9743 * bidi.c (bidi_line_init): Initialize the next_en_type member.
9744 (bidi_resolve_explicit_1): When next_en_pos is valid for the
9745 current character, check also for next_en_type being WEAK_EN.
9746 (bidi_resolve_weak): Don't enter the expensive loop if the current
9747 position is before next_en_pos. Record the bidi type of the first
9748 non-ET, non-BN character we find, in addition to its position.
9749 (bidi_level_of_next_char): Invalidate next_en_type when
9750 next_en_pos is over-stepped.
9751
7da0b018
PE
97522011-10-20 Paul Eggert <eggert@cs.ucla.edu>
9753
9754 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
9755 * editfns.c: Rewrite current-time-zone so that it invokes
9756 the equivalent of (format-time-string "%Z") to get the time zone name.
9757 This fixes a bug when the time zone name contains characters that
9758 need converting from the system time locale to Emacs internal format.
9759 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
9760 that patch fixed format-time-string to do the conversion, but
9761 I forgot to fix current-time-zone.
9762 (format_time_string): New function, containing most of
9763 what Fformat_time_string used to contain.
9764 (Fformat_time_string): Rewrite in terms of format_time_string.
9765 This doesn't change this function's behavior.
9766 (current-time-zone): Rewrite to use format_time_string.
9767 This fixes the bug reported by Michael Schierl in
9768 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
9769 Jason Rumney's 2007-06-07 change worked around this bug, but
9770 didn't fix it.
9771 * systime.h (tzname, timezone): Remove no-longer-used declarations.
9772
8547b010
EZ
97732011-10-19 Eli Zaretskii <eliz@gnu.org>
9774
9775 * xdisp.c (start_display): If the character at POS is displayed
9776 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
9777 (try_window_reusing_current_matrix): If a line ends in a display
9778 vector or the next line starts in a display vector, continue
9779 redrawing the window even though the character position of
9780 start_row was reached.
8547b010
EZ
9781 (Bug#9771, part 2)
9782
4e948d15
CY
97832011-10-18 Chong Yidong <cyd@gnu.org>
9784
9785 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
9786 with nobreak-char-display too.
9787
4787455f
EZ
97882011-10-18 Eli Zaretskii <eliz@gnu.org>
9789
9790 Fix part 3 of bug#9771.
9791 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
9792 (bidi_resolve_neutral): Don't enter the expensive loop looking for
9793 non-neutral characters if the current character is a paragraph
9794 separator (a.k.a. Newline). This avoids running the same
9795 expensive loop twice, once when we consume the preceding newline
9796 and the other time when the line actually needs to be displayed.
9797 Avoid the loop when we see neutrals on the base embedding level
9798 following a character whose directionality is the same as the
9799 paragraph's. This avoids running the expensive loop when a line
9800 ends in a long sequence of neutrals, like control characters.
9801 Add assertion against STRONG_AL type. Slightly rearrange code
9802 that determines the type of a neutral given the first non-neutral
9803 that follows it.
9804 (bidi_level_of_next_char): Set next_en_pos to zero when
9805 invalidating its info.
9806
2c91f553
EZ
98072011-10-17 Eli Zaretskii <eliz@gnu.org>
9808
9809 * xdisp.c (push_display_prop): Determine whether to record string
9810 or buffer position by IT->string, not by IT->method. Allow
9811 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
9812 (move_it_vertically_backward): Don't look for character position
9813 immediately after the newline when in a continuation line.
9814 (Bug#9771, part 1)
2c91f553 9815
c7b08b0d
MR
98162011-10-15 Martin Rudalics <rudalics@gmx.at>
9817
9818 * window.c (coordinates_in_window): Rewrite and delabelize
9819 vertical border check. (Bug#5357) (Bug#9618)
9820
6b02f655
SM
98212011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
9822
9823 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
9824 errors in XSetWindowBorder (bug#9310).
9825
81d40c92
DA
98262011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
9827
9828 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
9829 avoid crash when xmalloc overrun checking is enabled.
9830
d4172c3b
EZ
98312011-10-13 Eli Zaretskii <eliz@gnu.org>
9832
9833 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
9834 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
9835 cursor motion with <left> and <right> arrow keys.
9836
9837 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
9838 some callers set that themselves.
9839
b00eea75
EZ
98402011-10-12 Eli Zaretskii <eliz@gnu.org>
9841
9842 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
9843 display string and the previous row comes from the same string and
9844 is empty. (Bug#9739) (Bug#9738)
9845
8fe012c4
SM
98462011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
9847
9848 * doc.c (get_doc_string): Encode file name (bug#9735).
9849
0074aef2
EZ
98502011-10-12 Eli Zaretskii <eliz@gnu.org>
9851
79beb178
EZ
9852 * bidi.c (bidi_level_of_next_char):
9853 * xdisp.c (get_visually_first_element): Remove old incorrect
9854 comments regarding the Unicode Line Separator character.
9855
0074aef2
EZ
9856 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
9857
6e4b3fbe
DA
98582011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
9859
9860 * alloc.c (Fgc_status): Do not access beyond zombies array
9861 boundary if nzombies > MAX_ZOMBIES.
9862 * alloc.c (dump_zombies): Add missing format specifier.
9863
0324f3af
PE
98642011-10-12 Paul Eggert <eggert@cs.ucla.edu>
9865
b5525cac
PE
9866 * xdisp.c (set_cursor_from_row): Simplify conditionals,
9867 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
9868
0324f3af
PE
9869 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
9870 Some packages use them to denote characters with modifiers.
9871
e9b5f888
AS
98722011-10-11 Andreas Schwab <schwab@linux-m68k.org>
9873
9874 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
9875 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
9876 matching a pp-number. Rename parameter var to var1.
9877
127827c0
SM
98782011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
9879
9880 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
9881
c8fd3bd0
GM
98822011-10-08 Glenn Morris <rgm@gnu.org>
9883
9884 * callint.c (Fcall_interactively): Give a more explicit error for the
9885 'c' case with a non-character input. (Bug#8479)
9886
352ec8ff
EZ
98872011-10-08 Eli Zaretskii <eliz@gnu.org>
9888
03669ccb
EZ
9889 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
9890 lines.
7061c986
EZ
9891 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
9892 lines that are hscrolled on the left.
03669ccb 9893
352ec8ff
EZ
9894 * dispnew.c (buffer_posn_from_coords): Account for a possible
9895 presence of header-line. (Bug#4426)
9896
a66cfb1c
SM
98972011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
9898
6b02f655
SM
9899 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
9900 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 9901
7c5ee88e
PE
99022011-10-07 Paul Eggert <eggert@cs.ucla.edu>
9903
9904 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
9905 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
9906 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
9907 this makes Emacs dump core during garbage collection on rare
9908 occasions. sizeof is obviously inferior to offsetof here, so
9909 stick with offsetof.
9910 (GC_POINTER_ALIGNMENT): New macro.
9911 (mark_memory): Omit 3rd (offset) arg; caller changed.
9912 Don't assume EMACS_INT alignment is the same as pointer alignment.
9913
df1bbe5b
SM
99142011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
9915
9916 * keyboard.c (read_key_sequence_remapped): New var.
9917 (read_key_sequence): Compute remapping in the right buffer.
9918 (command_loop_1): Use read_key_sequence's remapping directly.
9919
51553db6
SM
99202011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
9921
32c1fffd
SM
9922 * dired.c (file_name_completion): Don't expand file name.
9923 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
9924 before checking file name handler.
9925
51553db6
SM
9926 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
9927 they've been requested explicitly (bug#9591).
9928
b6bd1599 99292011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
9930
9931 * keymap.c (Fsingle_key_description): Use make_specified_string
9932 instead of build_string to build string from push_key_description.
9933 (Bug#5193)
9934
f701dc2a
PE
99352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9936
4222c55d
PE
9937 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
9938 This fixes a Y2038 bug on 64-bit hosts.
9939 * buffer.c (reset_buffer):
9940 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
9941 (Fclear_buffer_auto_save_failure):
9942 Use 0, not -1, to represent an unset failure time, since time_t
9943 might not be signed.
9944
f701dc2a
PE
9945 Remove dependency on glibc malloc internals.
9946 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9947 Move back here from lisp.h, but with their new implementations.
9948 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9949 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
9950 * charset.c (charset_table_init): New static var.
9951 (syms_of_charset): Use it instead of xmalloc. This removes a
9952 dependency on glibc malloc internals. See Eli Zaretskii's comment in
9953 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
9954 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9955 Move back to alloc.c.
9956 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9957 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
9958
9ceebf39
JD
99592011-09-30 Jan Djärv <jan.h.d@swipnet.se>
9960
9961 * nsterm.m (windowDidResize): Call x_set_window_size only when
9962 ns_in_resize is true. Otherwise set pixelwidth/height and
9963 call change_frame_size (Bug#9628).
9964
cb993c58
PE
99652011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9966
3930c88b
PE
9967 Port --enable-checking=all to Fedora 14 x86-64.
9968 * charset.c (syms_of_charset): Also account for glibc malloc's
9969 internal overhead when calculating the initial malloc maximum.
9970
cb993c58
PE
9971 Port --enable-checking=all to Fedora 14 x86.
9972 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9973 Move to lisp.h.
9974 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
9975 (overrun_check_realloc, overrun_check_free):
9976 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
9977 That way, xmalloc returns a properly-aligned pointer even if
9978 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
9979 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
9980 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
9981 into account when calculating the initial malloc maximum.
9982 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9983 Move here from alloc.c, so that charset.c can use it too.
9984 Properly align; the old code wasn't right for common 32-bit hosts
9985 when configured with --enable-checking=all.
9986 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9987 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
9988
31bed486
EZ
99892011-09-29 Eli Zaretskii <eliz@gnu.org>
9990
04c70788 9991 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
9992 use EDOM.
9993
fbcaa2f3
EZ
99942011-09-28 Eli Zaretskii <eliz@gnu.org>
9995
9996 * xdisp.c (compute_display_string_end): If there's no display
9997 string at CHARPOS, return -1.
9998
9999 * bidi.c (bidi_fetch_char): When compute_display_string_end
10000 returns a negative value, treat the character as a normal
10001 character not covered by a display string. (Bug#9624)
10002
a239d4e9
JB
100032011-09-28 Juanma Barranquero <lekktu@gmail.com>
10004
10005 * lread.c (Fread_from_string): Fix typo in docstring.
10006
88652fd5
EZ
100072011-09-27 Eli Zaretskii <eliz@gnu.org>
10008
10009 * xdisp.c (handle_invisible_prop): If invisible text ends on a
10010 newline, reseat the iterator instead of bidi-iterating there one
10011 character at a time. (Bug#9610)
32c1fffd
SM
10012 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
10013 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 10014
ed497dd4
AS
100152011-09-27 Andreas Schwab <schwab@linux-m68k.org>
10016
10017 * lread.c (readevalloop): Use correct code for NBSP.
10018 (read1): Likewise. (Bug#9608)
10019
b2bf61aa
MA
100202011-09-25 Michael Albinus <michael.albinus@gmx.de>
10021
10022 * dbusbind.c (Fdbus_register_signal): When service is not
10023 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
10024
32bbb17c
GM
100252011-09-25 Glenn Morris <rgm@gnu.org>
10026
10027 * buffer.c (truncate-lines): Doc fix.
10028
94e0933e
CY
100292011-09-24 Chong Yidong <cyd@stupidchicken.com>
10030
10031 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
10032 (Fset_window_next_buffers): Doc fix.
10033
cddde921
GM
100342011-09-24 Glenn Morris <rgm@gnu.org>
10035
10036 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
10037
1260aef1
PE
100382011-09-24 Paul Eggert <eggert@cs.ucla.edu>
10039
25b4bfa0
PE
10040 Fix minor problems found by static checking.
10041 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
10042 * indent.c (Fvertical_motion): Fix == vs = typo.
10043
e3cbd34b
EZ
100442011-09-24 Eli Zaretskii <eliz@gnu.org>
10045
a66cfb1c
SM
10046 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
10047 Default value is now t. Doc fix.
6bf7006f 10048
e3cbd34b 10049 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 10050 logic when moving up, not only when moving down. Fix the
e3cbd34b 10051 confusing name and values of the it_overshoot_expected variable;
32c1fffd 10052 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
10053
10054 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
10055 CHARPOS is covered by a display string which includes newlines.
10056 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
10057 is covered by a display string with embedded newlines.
10058
a3de0cbd
MA
100592011-09-24 Michael Albinus <michael.albinus@gmx.de>
10060
10061 * dbusbind.c (Fdbus_register_signal): Add match rule to
10062 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
10063 (Fdbus_register_method, Vdbus_registered_objects_table):
10064 Fix docstring.
a3de0cbd 10065
b260039d
JM
100662011-09-24 Jim Meyering <meyering@redhat.com>
10067
32c1fffd 10068 do not ignore write error for any output size
b260039d
JM
10069 The previous change was incomplete.
10070 While it makes emacs --batch detect the vast majority of stdout
10071 write failures, errors were still ignored whenever the output size is
10072 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
10073 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
10074 && echo FAIL: ignored write error
10075 FAIL: ignored write error
10076 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
10077 && echo FAIL: ignored write error
10078 FAIL: ignored write error
10079 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
10080
8eca8a7c
AS
100812011-09-23 Andreas Schwab <schwab@linux-m68k.org>
10082
10083 * emacs.c (Fkill_emacs): In noninteractive mode exit
10084 non-successfully if a write error occurred on stdout. (Bug#9574)
10085
3341db62
EZ
100862011-09-21 Eli Zaretskii <eliz@gnu.org>
10087
10088 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
10089 the xassert test.
10090
10091 * dispextern.h (struct it): Update the comment documenting what
10092 can it->OBJECT be.
10093
8c203dbf
EZ
100942011-09-20 Eli Zaretskii <eliz@gnu.org>
10095
10096 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
10097 a display string, extend search for cursor position to end of row.
10098 (find_row_edges): If the row ends in a newline from a display
10099 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
10100 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
10101 (Fcurrent_bidi_paragraph_direction): Fix search for previous
10102 non-empty line. Fixes confusing cursor motion with arrow keys at
10103 the beginning of a line that starts with whitespace.
8c203dbf 10104
a4824228
LMI
101052011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10106
10107 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
10108 (bug#9493).
10109
33ed493b
CY
101102011-09-18 Chong Yidong <cyd@stupidchicken.com>
10111
10112 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
10113 boolean (Bug#9154).
10114
56cd55c8
EZ
101152011-09-18 Eli Zaretskii <eliz@gnu.org>
10116
10117 * xdisp.c (display_line): Record maximum and minimum buffer
10118 positions even if no glyphs were produced (e.g., by a zero-width
10119 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
10120 buffer positions that will be removed from the glyph row because
10121 they don't fit.
c02dcedf
EZ
10122 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
10123 column is beyond frame width: don't subtract 1 "pixel" when
10124 computing width of the stretch.
3e62b7e0
EZ
10125 (reseat_at_next_visible_line_start): Undo the change made on
10126 2011-09-17 that saved paragraph information and restored it after
10127 the call to `reseat'. (Bug#9545)
56cd55c8 10128
5ed99d36 101292011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
10130
10131 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
10132 and turn window cursor on if cleared (Bug#9415).
10133
5ed99d36 101342011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
10135
10136 * search.c (boyer_moore): Take unibyte characters from pattern
10137 literally. (Bug#9458)
10138
9bade7b2
EZ
101392011-09-18 Eli Zaretskii <eliz@gnu.org>
10140
10141 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
10142
e5e9d610
PE
101432011-09-18 Paul Eggert <eggert@cs.ucla.edu>
10144
87e4427a
PE
10145 Fix minor problem found by static checking.
10146 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
10147 initialized, to pacify gcc -Wuninitialized.
10148
e5e9d610
PE
10149 * fileio.c: Report proper errno when syscall falls.
10150 (Finsert_file_contents): Save and restore errno,
10151 so that report_file_error outputs the correct diagnostic.
10152 (Fwrite_region) [CLASH_DETECTION]: Likewise.
10153
a1674f0b
EZ
101542011-09-18 Eli Zaretskii <eliz@gnu.org>
10155
10156 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
10157
fbfb6dd4
EZ
101582011-09-17 Eli Zaretskii <eliz@gnu.org>
10159
10160 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
10161 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
10162
bb187662
EZ
101632011-09-17 Eli Zaretskii <eliz@gnu.org>
10164
1137e8b8 10165 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 10166 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
10167
10168 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
10169 (bidi_find_paragraph_start): Search back for paragraph beginning
10170 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
10171 (bidi_move_to_visually_next): Only trigger paragraph-related
10172 computations when the last character is a newline or at EOB, not
10173 just any NEUTRAL_B. (Bug#9470)
10174
bb187662
EZ
10175 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
10176 truncated lines if point is covered by a display string. (Bug#9524)
10177
2e621251
PE
101782011-09-16 Paul Eggert <eggert@cs.ucla.edu>
10179
10180 * xselect.c: Relax test for outgoing X longs (Bug#9498).
10181 (cons_to_x_long): New function.
10182 (lisp_data_to_selection_data): Use it. Correct the test for
10183 short-versus-long data; it was negated. Break out of vector
10184 loop, for efficiency, when a long datum is discovered.
10185
91a15bc6
SM
101862011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
10187
10188 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
10189
b41c3a35
EZ
101902011-09-16 Eli Zaretskii <eliz@gnu.org>
10191
10192 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
10193 GCC PR/17406) by declaring this function with external scope.
10194
7812ba2d
PE
101952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10196
10197 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
10198 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
10199
cf7edc2a
AS
102002011-09-15 Andreas Schwab <schwab@linux-m68k.org>
10201
10202 * editfns.c (Fformat): Correctly handle text properties on "%%".
10203
bd01620e
EZ
102042011-09-15 Eli Zaretskii <eliz@gnu.org>
10205
10206 * xterm.c (x_draw_composite_glyph_string_foreground):
10207 * w32term.c (x_draw_composite_glyph_string_foreground):
10208 * term.c (encode_terminal_code):
10209 * composite.c (composition_update_it, get_composition_id):
10210 * xdisp.c (get_next_display_element)
10211 (fill_composite_glyph_string): Add comments about special meaning
10212 of TAB characters in a composition.
10213
a02719a3
PE
102142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10215
10216 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
10217 This occurs when processing a multibyte format.
10218 Problem reported by Wolfgang Jenker.
a02719a3 10219
72589a3c
JB
102202011-09-15 Johan Bockgård <bojohan@gnu.org>
10221
10222 * xdisp.c (try_cursor_movement): Only check for exact match if
10223 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
10224
1c14176c
PE
102252011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10226
10227 Remove unused external symbols.
10228 * dispextern.h (calc_pixel_width_or_height): Remove decl.
10229 * xdisp.c (calc_pixel_width_or_height): Now static.
10230 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
10231 * indent.c (check_display_width):
10232 * w32term.c: Fix comment to match code.
10233 * xterm.c, xterm.h (x_catching_errors): Remove.
10234
d2eea5b5
PE
102352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10236
10237 * xselect.c: Use signed conversions more consistently (Bug#9498).
10238 (selection_data_to_lisp_data): Assume incoming selection data are
10239 signed integers, not unsigned. This is to be consistent with
10240 outgoing selection data, which was modified to use signed integers
10241 in as part of the fix to Bug#9196 in response to Jan D.'s comment
10242 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
10243 expects long, not unsigned long.
10244
46888499
EZ
102452011-09-14 Eli Zaretskii <eliz@gnu.org>
10246
10247 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
10248 computation of loop end. Reported by Johan Bockgård
10249 <bojohan@gnu.org>.
10250
ef8ef9fb
CY
102512011-09-13 Chong Yidong <cyd@stupidchicken.com>
10252
10253 * frame.c (Fother_visible_frames_p): Function deleted.
10254
fa819fed
EZ
102552011-09-12 Eli Zaretskii <eliz@gnu.org>
10256
10257 * indent.c (compute_motion): Process display vector front to back
10258 rather than the other way around. (Bug#2496)
10259
2ba8e008
SM
102602011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
10261
10262 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
10263
20f53c69
CY
102642011-09-11 Chong Yidong <cyd@stupidchicken.com>
10265
10266 * minibuf.c (Fread_from_minibuffer): Doc fix.
10267
d562d7a4
EZ
102682011-09-11 Eli Zaretskii <eliz@gnu.org>
10269
10270 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
10271 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
10272
1c4d7f3d
LMI
102732011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10274
10275 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
10276 value for non-existent files.
10277
b885bf36
EZ
102782011-09-11 Eli Zaretskii <eliz@gnu.org>
10279
10280 * fileio.c (Finsert_file_contents): If the file cannot be opened,
10281 set its "size" to -1. This will set the modtime_size field of
10282 the corresponding buffer to -1, which is what
10283 verify-visited-file-modtime expects for files that do not exist.
10284 (Bug#9139)
10285
6612f0bf
PE
102862011-09-11 Paul Eggert <eggert@cs.ucla.edu>
10287
10288 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
10289 here ...
10290 * lisp.h: ... from here. push_key_description is no longer
10291 defined in keyboard.c, so its declaration should not be in
10292 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
10293 logically belongs with push_key_description.
10294
dfb3f755
PE
102952011-09-10 Paul Eggert <eggert@cs.ucla.edu>
10296
10297 * buffer.h: Include <sys/types.h> instead of <time.h>.
10298 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
10299 Problem reported by Herbert J. Skuhra.
10300
3134906c
LMI
103012011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
10302
10303 * xml.c (parse_region): Make the parsing work for
10304 non-comment-starting XML files again (bug#9144).
10305
8d903f4e
AS
103062011-09-10 Andreas Schwab <schwab@linux-m68k.org>
10307
10308 * image.c (gif_load): Fix calculation of bottom and right corner.
10309 (Bug#9468)
10310
80ad64f4
EZ
103112011-09-10 Eli Zaretskii <eliz@gnu.org>
10312
10313 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
10314 redisplay in small windows.
10315
208a048d
EZ
103162011-09-09 Eli Zaretskii <eliz@gnu.org>
10317
10318 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
10319
9b1c252e
MR
103202011-09-08 Martin Rudalics <rudalics@gmx.at>
10321
10322 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
10323 Operate on live windows only.
10324
2949f33b
JB
103252011-09-08 Juanma Barranquero <lekktu@gmail.com>
10326
10327 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
10328
e08dcafd
EZ
103292011-09-07 Eli Zaretskii <eliz@gnu.org>
10330
10331 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
10332 only under bidi iteration.
10333
115b96bd
JD
103342011-09-07 Jan Djärv <jan.h.d@swipnet.se>
10335
10336 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
10337
c8199d0f
PE
103382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
10339
10340 isnan: Fix porting problem to Solaris 10 with bundled gcc.
10341 Without this fix, the command to link temacs failed due to an
10342 undefined symbol __builtin_isnan. This is because
10343 /usr/include/iso/math_c99.h #defines isnan(x) to
10344 __builtin_isnan(x), but the bundled gcc, which identifies itself
10345 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
10346 a __builtin_isnan.
10347 * floatfns.c (isnan): #undef, and then #define to a clone of
10348 what's in data.c.
10349 (Fisnan): Always define, since it's always available now.
10350 (syms_of_floatfns): Always define isnan at the Lisp level.
10351
e39b275c 103522011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
10353
10354 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
10355
b2db44d9 103562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 10357
f4af5137 10358 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
10359 The previous code assumed that file offsets (off_t values) fit in
10360 EMACS_INT variables, which is not true on typical 32-bit hosts.
10361 The code messed up by falsely reporting buffer overflow in cases
10362 such as (insert-file-contents "big" nil 1 2) into an empty buffer
10363 when "big" contains more than 2**29 bytes, even though this
10364 inserts just one byte and does not overflow the buffer.
10365 (Finsert_file_contents): Store file offsets as off_t
10366 values, not as EMACS_INT values. Check for overflow when
10367 converting between EMACS_INT and off_t. When checking for
10368 buffer overflow or for overlap, take the offsets into account.
10369 Don't use EMACS_INT for small values where int suffices.
10370 When checking for overlap, fix a typo: ZV was used where
10371 ZV_BYTE was intended.
10372 (Fwrite_region): Don't assume off_t fits into 'long'.
10373 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
10374
ecfc0a49
MA
103752011-09-05 Michael Albinus <michael.albinus@gmx.de>
10376
10377 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
10378
6511acf2 103792011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 10380
0999621a 10381 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
10382
10383 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 10384 (esprintf, exprintf, evxprintf): New functions.
62f19c19 10385 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 10386 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
10387 (modify_event_symbol): Do not assume that the length of
10388 name_alist_or_stem is safe to alloca and fits in int.
10389 (Fexecute_extended_command): Likewise for function name and binding.
10390 (Frecursion_depth): Wrap around reliably on integer overflow.
10391 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
10392 since some callers pass EMACS_INT values.
10393 (Fsingle_key_description): Don't crash if symbol name contains more
10394 than MAX_ALLOCA bytes.
10395 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
10396 (get_minibuffer): Arg is now EMACS_INT, not int.
10397 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 10398 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
10399 * window.h (command_loop_level, minibuf_level): Reflect API changes.
10400
2be7d702
PE
10401 * dbusbind.c (signature_cat): New function.
10402 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
10403 Do not overrun buffer; instead, report string overflow.
10404
9d1df220
PE
10405 * dispnew.c (add_window_display_history): Don't overrun buffer.
10406 Truncate instead; this is OK since it's just a log.
10407
33ef5c64
PE
10408 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
10409 even if the time zone offset is outlandishly large.
10410 Don't mishandle offset == INT_MIN.
10411
66c6fdd5
PE
10412 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
10413 when creating daemon; the previous buffer-overflow check was incorrect.
10414
d749b01b
PE
10415 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
10416 which has the guts of the old verror function.
10417
b5cd1905
PE
10418 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
10419 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
10420
6e1a67fb
PE
10421 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
10422 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 10423 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 10424 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
10425 length of string rather than counting it via multiple sprintfs;
10426 that's simpler and more reliable.
c21721cc
PE
10427 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
10428 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
10429 sprintf, in case result does not fit in int.
10430
c57b67fc
PE
10431 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
10432 (fontset_from_font): Print it.
10433
8a401434
PE
10434 * frame.c (tty_frame_count): Now printmax_t, not int.
10435 (make_terminal_frame, set_term_frame_name): Print it.
10436 (x_report_frame_params): In X, window IDs are unsigned long,
10437 not signed long, so print them as unsigned.
10438 (validate_x_resource_name): Check for implausibly long names,
10439 and don't assume name length fits in 'int'.
10440 (x_get_resource_string): Don't blindly alloca invocation name;
10441 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
10442 not fit in int.
10443
6e1a67fb
PE
10444 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
10445 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
10446 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
10447
0df02bf3
PE
10448 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
10449 Use esprintf, not sprintf, in case result does not fit in int.
10450
48e30793
PE
10451 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
10452 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
10453 it as a large positive number.
10454 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
10455 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
10456
a66ff6d8
PE
10457 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
10458 in case result does not fit in int.
10459
aca216ff
PE
10460 * print.c (float_to_string): Detect width overflow more reliably.
10461 (print_object): Make sprintf buffer a bit bigger, to avoid potential
10462 buffer overrun. Don't assume list length fits in 'int'. Treat
10463 print length of 0 as 0, not as infinity; to be consistent with other
10464 uses of print length in this function. Don't overflow print length
10465 index. Don't assume hash table size fits in 'long', or that
10466 vectorlike size fits in 'unsigned long'.
10467
31c286f7
PE
10468 * process.c (make_process): Use printmax_t, not int, to format
10469 process-name gensyms.
10470
55e5faa1
PE
10471 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
10472
80f2e268
PE
10473 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
10474 to avoid potential buffer overrun.
10475
670741ab
PE
10476 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
10477 if X resource line is longer than 512 bytes.
10478
b7163a50
PE
10479 * xfns.c (x_window): Make sprintf buffer a bit bigger
10480 to avoid potential buffer overrun.
10481
ae58ff1f
PE
10482 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
10483
c43c8a6a
PE
10484 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
10485
3f8236f4
PE
104862011-09-04 Paul Eggert <eggert@cs.ucla.edu>
10487
53e9fe90 10488 Integer overflow fixes for scrolling, etc.
6511acf2
PE
10489 Without these, Emacs silently mishandles large integers sometimes.
10490 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
10491 it were "C-u 1 M-x recenter" on a typical 64-bit host.
10492
6511acf2
PE
10493 * xdisp.c (try_window_id): Check Emacs fixnum range before
10494 converting to 'int'.
806add1d 10495
6511acf2 10496 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
10497 Check that an Emacs fixnum is in range before assigning it to 'int'.
10498 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
10499 values converted from Emacs fixnums.
10500 (Frecenter): Don't wrap around a line count if it is out of 'int'
10501 range; instead, treat it as an extreme value.
10502 (Fset_window_configuration, compare_window_configurations):
10503 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
10504
6511acf2
PE
10505 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
10506 that can exceed INT_MAX. Check that EMACS_INT value is in range
10507 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
10508 (match_limit): Don't assume that a fixnum can fit in 'int'.
10509
6511acf2 10510 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
10511 exceed INT_MAX.
10512
6511acf2 10513 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
10514 (Fvertical_motion): Don't wrap around LINES values that don't fit
10515 in 'int'. Instead, treat them as extreme values. This is good
10516 enough for windows, which can't have more than INT_MAX lines anyway.
10517
fcb901a7
LMI
105182011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10519
0f2f6b6d
LMI
10520 * Require libxml/parser.h to avoid compilation warning.
10521
fcb901a7
LMI
10522 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
10523
10524 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
10525 since this reportedly can destroy thread storage.
10526
6e20a0d4
CY
105272011-08-30 Chong Yidong <cyd@stupidchicken.com>
10528
10529 * syntax.c (find_defun_start): Update all cache variables if
10530 exiting early (Bug#9401).
10531
148ae00e
EZ
105322011-08-30 Eli Zaretskii <eliz@gnu.org>
10533
f6cfbd8f
EZ
10534 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
10535
148ae00e
EZ
10536 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
10537 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
10538 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
10539
10540 * term.c (tty_append_glyph): New function.
10541 (produce_stretch_glyph): Static function and its prototype deleted.
10542
a66cfb1c
SM
10543 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
10544 Add prototypes.
148ae00e 10545
c4a07a4c
PE
105462011-08-29 Paul Eggert <eggert@cs.ucla.edu>
10547
10548 * image.c (parse_image_spec): Check for nonnegative, not for positive,
10549 when checking :margin (Bug#9390).
10550 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 10551 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
10552 so that the name doesn't mislead. All uses changed.
10553
6bc8cd65
JB
105542011-08-28 Johan Bockgård <bojohan@gnu.org>
10555
10556 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
10557 set_tty_hooks.
10558
dca4927e
EZ
105592011-08-27 Eli Zaretskii <eliz@gnu.org>
10560
10561 * xdisp.c (move_it_to): Don't bail out early when reaching
10562 position beyond to_charpos, if we are scanning backwards.
10563 (move_it_vertically_backward): When DY == 0, make sure we get to
10564 the first character in the line after the newline.
10565
f2cad773
PE
105662011-08-27 Paul Eggert <eggert@cs.ucla.edu>
10567
10568 * ccl.c: Improve and simplify overflow checking (Bug#9196).
10569 (ccl_driver): Do not generate an out-of-range pointer.
10570 (Fccl_execute_on_string): Remove unnecessary check for
10571 integer overflow, noted by Stefan Monnier in
10572 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
10573 Remove a FIXME that didn't need fixing.
10574 Simplify the newly-introduced buffer reallocation code.
10575
0cae2cdb
JB
105762011-08-27 Juanma Barranquero <lekktu@gmail.com>
10577
10578 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
10579
5fc295a4 105802011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 10581
70c60eb2 10582 Integer and memory overflow issues (Bug#9196).
726e0ab1 10583
d31850da
PE
10584 * doc.c (get_doc_string): Rework so that
10585 get_doc_string_buffer_size is the actual buffer size, rather than
10586 being 1 less than the actual buffer size; this makes xpalloc more
10587 convenient.
10588
a69fbedb
PE
10589 * image.c (x_allocate_bitmap_record, cache_image):
10590 * xselect.c (Fx_register_dnd_atom):
10591 Simplify previous changes by using xpalloc.
10592
fe5c5d37
PE
10593 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10594 since either will do and ptrdiff_t is convenient with xpalloc.
10595
0065d054
PE
10596 * charset.c (charset_table_size)
10597 (struct charset_sort_data.priority): Now ptrdiff_t.
10598 (charset_compare): Don't overflow if priorities differ greatly.
10599 (Fsort_charsets): Don't assume list length fits in int.
10600 Check for size-calculation overflow when allocating sort data.
10601 (syms_of_charset): Allocate an initial charset table that is
10602 just under 64 KiB, to avoid problems with glibc malloc and mmap.
10603
10604 * cmds.c (internal_self_insert): Check for size-calculation overflow.
10605
10606 * composite.h (struct composition.glyph_len): Now int, not unsigned.
10607 The actual value is always <= INT_MAX, and leaving it unsigned made
10608 overflow checking harder.
10609
10610 * dispextern.h (struct glyph_matrix.rows_allocated)
10611 (struct face_cache.size): Now ptrdiff_t, for convenience in use
10612 with xpalloc. The values are still always <= INT_MAX.
10613
10614 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
10615
10616 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
10617 (SAFE_NALLOCA): New macro.
10618
10619 * region-cache.c (struct boundary.pos, find_cache_boundary)
10620 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
10621 (set_cache_region, invalidate_region_cache)
10622 (revalidate_region_cache, know_region_cache, region_cache_forward)
10623 (region_cache_backward, pp_cache):
10624 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
10625 so that ptrdiff_t * can be passed to xpalloc.
10626 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
10627 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
10628 (pp_cache): Don't assume cache_len fits in int.
10629 * region-cache.h: Adjust extern decls to match.
10630
10631 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
10632 EMACS_INT, since either will do, for xpalloc.
10633
10634 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
10635 (xnmalloc, xnrealloc, xpalloc): New functions.
10636
726e0ab1
PE
10637 * bidi.c (bidi_shelve_header_size): New constant.
10638 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
10639 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
10640
51f30bc5 10641 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
10642 * buffer.c (overlays_at, overlays_in, record_overlay_string)
10643 (overlay_strings):
10644 Don't update size of array until after memory allocation succeeds,
10645 because xmalloc/xrealloc may not return.
0065d054
PE
10646 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
10647 now that we have proper integer overflow checking.
10648 (record_overlay_string, overlay_strings): Catch overflows when
10649 calculating size of overlay_str_buf.
726e0ab1 10650
0065d054
PE
10651 * callproc.c (Fcall_process): Check for size overflow when
10652 calculating size of args2.
10653 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
10654 Normally we prefer signed values, but sticking with ptrdiff_t would
10655 require adding more-complicated checks.
726e0ab1
PE
10656
10657 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
10658 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
10659 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 10660 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
10661
10662 * character.c (Fstring): Check for size-calculation overflow.
10663
10664 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
10665 unnecessary integer overflow. Check for size overflow.
10666 (encode_coding_object): Don't update size until xmalloc succeeds.
10667
10668 * composite.c (get_composition_id): Check for overflow in glyph
10669 length calculations.
10670
10671 Integer and memory overflow fixes for display code.
10672 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
10673 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
10674 (scrolling_window): Check for overflow in size calculations.
10675 (line_draw_cost, realloc_glyph_pool, add_row_entry):
10676 Don't assume glyph table len fits in int.
10677 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
10678 (row_table_size): Now ptrdiff_t, not int.
10679 (scrolling_window): Avoid overflow in size calculations.
10680 Don't update size until allocation succeeds.
10681 * fns.c (concat): Check for overflow in size calculations.
10682 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
10683 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10684 (NEXT_ALMOST_PRIME_LIMIT): New constant.
10685
10686 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
10687 (get_doc_string): Check for size calculation overflow.
10688 Don't update size until allocation succeeds.
10689 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
10690 EMACS_INT, where ptrdiff_t will do.
10691 (Fsubstitute_command_keys): Check for string overflow.
10692
10693 * editfns.c (set_time_zone_rule): Don't assume environment length
10694 fits in int.
10695 (message_length): Now ptrdiff_t, not int.
10696 (Fmessage_box): Don't update size until allocation succeeds.
10697 Don't assume message length fits in int.
10698 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
10699
0065d054
PE
10700 * emacs.c (main): Do not reallocate argv, since there is a null at
10701 the end that can be overwritten, and this way there's no need to
10702 worry about size-calculation overflow.
10703 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
10704
10705 * eval.c (init_eval_once, grow_specpdl): Don't update size until
10706 alloc succeeds.
10707 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
10708
10709 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
10710 (x_set_scroll_bar_width, x_figure_window_size):
10711 Check for integer overflow.
10712 (x_set_alpha): Do not assume XINT fits in int.
10713
10714 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
10715 This is for the members text_lines, text_cols, total_lines, total_cols,
10716 where the system imposes an 'int' limit.
10717
10718 * fringe.c (Fdefine_fringe_bitmap):
10719 Don't update size until alloc works.
10720
10721 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
10722 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
10723
10724 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
10725 Check for size-calculation overflow.
10726 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
10727 do, as we prefer signed integers.
10728 (id_to_widget.max_size, id_to_widget.used)
10729 (xg_store_widget_in_map, xg_remove_widget_from_map)
10730 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
10731 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
10732 Use and return ptrdiff_t, not int.
10733 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
10734 * gtkutil.h: Change prototypes to match the above.
10735
10736 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
10737 are duplicate now that they've been promoted to lisp.h.
10738 (x_allocate_bitmap_record, x_alloc_image_color)
10739 (make_image_cache, cache_image, xpm_load):
10740 Don't update size until alloc is done.
10741 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
10742 (x_detect_edges):
3256efce 10743 Check for size calculation overflow.
726e0ab1
PE
10744 (ct_colors_allocated_max): New constant.
10745 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
10746 overflow.
3256efce 10747
726e0ab1
PE
10748 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
10749 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
10750 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
10751 Use ptrdiff_t, not int, to count maps.
10752 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
10753 calculations. Don't update size until allocation succeeds.
10754 Redo calculations to avoid overflow.
726e0ab1
PE
10755 * keyboard.h: Change prototypes to match the above.
10756
10757 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
10758 to count maps.
10759 (current_minor_maps): Check for size calculation overflow.
10760 * keymap.h: Change prototypes to match the above.
10761
10762 * lread.c (read1, init_obarray): Don't update size until alloc done.
10763
10764 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
10765 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
10766
726e0ab1
PE
10767 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
10768 Now ptrdiff_t, not int.
10769 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
10770 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
10771
10772 * process.c (Fnetwork_interface_list): Check for overflow
10773 in size calculation.
10774
10775 * region-cache.c (move_cache_gap): Check for size calculation overflow.
10776
10777 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
10778 overflow. Don't bother calling xmalloc when xrealloc will do.
10779
10780 * search.c (Freplace_match): Check for size calculation overflow.
10781 (Fset_match_data): Don't assume list lengths fit in 'int'.
10782
10783 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
10784 for command line length. Do not attempt to address one before the
10785 beginning of an array, as that's not portable.
10786
10787 * term.c (max_frame_lines): Remove; unused.
10788 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
10789 not int.
10790 (encode_terminal_code, calculate_costs): Check for size
10791 calculation overflow.
10792 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
10793 table lengths and related sizes. Don't update size until alloc
10794 done. Redo calculations to avoid overflow.
10795 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
10796
10797 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
10798 subtracting pointers.
10799 (gobble_line): Check for overflow more carefully. Don't update size
10800 until alloc done.
10801
10802 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
10803 Don't update size until alloc done.
10804 Redo size calculations to avoid overflow.
10805 Check for size calculation overflow.
0065d054 10806 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
10807
10808 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
10809 Use ptrdiff_t, not int, for sizes.
10810 (store_mode_line_noprop_char): Don't update size until alloc done.
10811
0065d054
PE
10812 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
10813 Use ptrdiff_t, not int, for sizes.
10814 (Finternal_make_lisp_face, cache_face):
10815 Check for size calculation overflow.
10816 (cache_face): Treat size calculation overflows as if they were
10817 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
10818
10819 * xfns.c (x_encode_text, x_set_name_internal)
10820 (Fx_change_window_property): Use ptrdiff_t, not int, to count
10821 sizes, since they can exceed INT_MAX in size. Check for size
10822 calculation overflow.
10823
0065d054
PE
10824 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
10825 (xg_select): Check for size calculation overflow.
726e0ab1
PE
10826 Don't update size until alloc done.
10827
0065d054 10828 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 10829 as sprintf is limited to int lengths.
1d526e2f 10830
252c5ee1
PE
10831 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
10832 (X_LONG_MIN): New macros.
864d7ce7
PE
10833 Use them to make the following changes clearer.
10834 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
10835 This change doesn't affect the value now, but it may help remind
10836 future maintainers not to raise the value too much later.
10837 (SELECTION_QUANTUM): Remove, replacing with ...
10838 (selection_quantum): ... new function, which avoids overflow.
10839 All uses changed.
10840 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
10841 assumption that selection length fits in 'int'.
10842 (x_reply_selection_request, x_handle_selection_request)
10843 (x_get_window_property, receive_incremental_selection)
10844 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
10845 (lisp_data_to_selection_data, clean_local_selection_data):
10846 Use ptrdiff_t, not int, to record length of selection.
10847 (x_reply_selection_request, x_get_window_property)
10848 (receive_incremental_selection, x_property_data_to_lisp):
10849 Redo calculations to avoid overflow.
10850 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 10851 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
10852 something.
10853 (x_get_window_property, receive_incremental_selection)
10854 (lisp_data_to_selection_data, x_property_data_to_lisp):
10855 Check for size-calculation overflow.
10856 (x_get_window_property, receive_incremental_selection)
10857 (lisp_data_to_selection_data, Fx_register_dnd_atom):
10858 Don't store size until memory allocation succeeds.
10859 (x_get_window_property): Plug memory leak on memory exhaustion.
10860 Don't double-block input; malloc is safe here. Don't assume 2**34
10861 - 4 fits in unsigned long. Add an xassert to check
10862 XGetWindowProperty overflow. Be more careful about overflow
10863 calculations, and distinguish size from memory overflow better.
10864 (receive_incremental_selection): When tracing, don't assume
10865 unsigned int is less than INT_MAX.
10866 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
10867 harmful) conversions of unsigned short to int.
10868 (lisp_data_to_selection_data): Don't assume that integers
10869 in the range -65535 through -1 fit in an X unsigned short.
10870 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
10871 result parameters unless successful. Rely on cons_to_unsigned
10872 to report problems with elements; the old code wasn't right anyway.
10873 (x_check_property_data): Check for int overflow; we cannot use
10874 a wider type due to X limits.
10875 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
10876
726e0ab1 10877 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 10878
0065d054
PE
10879 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
10880 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
10881 (x_color_cells): Don't store size until memory allocation succeeds.
10882 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 10883 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
10884 (x_term_init): Don't assume length fits in int (sprintf is limited
10885 to int size).
bc18e09d 10886
ebfa62c0
PE
10887 Use ptrdiff_t for composition IDs.
10888 * character.c (lisp_string_width):
10889 * composite.c (composition_table_size, n_compositions)
10890 (get_composition_id, composition_gstring_from_id):
10891 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
10892 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
10893 * window.c (Frecenter):
10894 Use ptrdiff_t, not int, for composition IDs.
10895 * composite.c (get_composition_id): Check for integer overflow.
10896 * composite.h: Adjust prototypes to match the above changes.
10897
d3411f89
PE
10898 Use ptrdiff_t for hash table indexes.
10899 * category.c (hash_get_category_set):
10900 * ccl.c (ccl_driver):
10901 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
10902 * coding.c (coding_system_charset_list, detect_coding_system):
10903 * coding.h (struct coding_system.id):
10904 * composite.c (get_composition_id, gstring_lookup_cache):
10905 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
10906 * image.c (xpm_get_color_table_h):
10907 * lisp.h (hash_lookup, hash_put):
10908 * minibuf.c (Ftest_completion):
10909 Use ptrdiff_t for hash table indexes, not int (which is too
10910 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
10911 32-bit --with-wide-int hosts).
10912
e097a6fa
PE
10913 * charset.c (Fdefine_charset_internal): Check for integer overflow.
10914 Add a FIXME comment about memory leaks.
10915 (syms_of_charset): Don't assume xmalloc returns.
10916
5637687f
PE
10917 Don't assume that stated character widths fit in int.
10918 * character.c (Fchar_width, c_string_width, lisp_string_width):
10919 * character.h (CHAR_WIDTH):
10920 * indent.c (MULTIBYTE_BYTES_WIDTH):
10921 Use sanitize_char_width to avoid undefined and/or bad behavior
10922 with outlandish widths.
a66cfb1c 10923 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
10924 now that we have two such functions. All uses changed.
10925 (sanitize_char_width): New inline function.
10926
a2271ba2
PE
10927 Don't assume that tab-width fits in int.
10928 * character.h (sanitize_width): New inline function.
10929 (SANE_TAB_WIDTH): New macro.
10930 (ASCII_CHAR_WIDTH): Use it.
10931 * indent.c (sane_tab_width): Remove. All uses replaced by
10932 SANE_TAB_WIDTH (current_buffer).
10933 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
10934
18c52557
PE
10935 * fileio.c: Integer overflow issues with file modes.
10936 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
10937
caeeedc1
PE
10938 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
10939 Remove unreachable code.
10940 (read_hex, load_charset_map_from_file): Check for integer overflow.
10941
6df6ae42 10942 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
10943 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
10944 (x_send_scroll_bar_event): Likewise. Check that the size does not
10945 exceed limits imposed by XClientMessageEvent, as well as the usual
10946 ptrdiff_t and size_t limits.
10947
b13995db
PE
10948 * keyboard.c: Overflow, signedness and related fixes.
10949 (make_lispy_movement): Use same integer type in forward decl
10950 that is used in the definition.
10951 (read_key_sequence, keyremap_step):
10952 Change bufsize argument back to int, undoing my 2011-03-30 change.
10953 We prefer signed types, and int is wide enough here.
10954 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
10955 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
10956 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
10957 length, not size_t. Use ptrdiff_t for index, not int.
10958 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
10959 possibility of integer overflow.
10960
13464394
PE
10961 Overflow, signedness and related fixes for images.
10962
10963 * dispextern.h (struct it.stack[0].u.image.image_id)
10964 (struct_it.image_id, struct image.id, struct image_cache.size)
10965 (struct image_cache.used, struct image_cache.ref_count):
10966 * gtkutil.c (update_frame_tool_bar):
10967 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
10968 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
10969 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
10970 * nsmenu.m (update_frame_tool_bar):
10971 * xdisp.c (calc_pixel_width_or_height):
10972 * xfns.c (image_cache_refcount):
10973 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
10974 on typical 64-bit hosts.
10975
10976 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10977 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
10978 Omit unnecessary casts to int.
10979 (parse_image_spec): Check that integers fall into 'int' range
10980 when the callers expect that.
10981 (image_ascent): Redo ascent calculation to avoid int overflow.
10982 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
10983 (lookup_image): Remove unnecessary tests.
10984 (xbm_image_p): Locals are now of int, not EMACS_INT,
10985 since parse_image_check makes sure they fit into int.
10986 (png_load, gif_load, svg_load_image):
10987 Prefer int to unsigned where either will do.
10988 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
10989 old tiff_error_handler and tiff_warning_handler.
10990 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
10991 stack buffer overflows. It uses only the features of vsnprintf
10992 that are common to both POSIX and native Microsoft.
10993 (tiff_error_handler, tiff_warning_handler): Use it.
10994 (tiff_load, gif_load, imagemagick_load_image):
10995 Don't assume :index value fits in 'int'.
10996 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
10997 (imagemagick_load_image): Check that crop parameters fit into
10998 the integer types that MagickCropImage accepts. Don't assume
10999 Vimagemagick_render_type has a nonnegative value. Don't assume
11000 size_t fits in 'long'.
11001 (gs_load): Use printmax_t to print the widest integers possible.
11002 Check for integer overflow when computing image height and width.
11003
c11821d4
EZ
110042011-08-26 Eli Zaretskii <eliz@gnu.org>
11005
11006 * xdisp.c (redisplay_window): Don't force window start if point
11007 will be invisible in the resulting window. (Bug#9324)
11008
0c95fcf7
EZ
110092011-08-25 Eli Zaretskii <eliz@gnu.org>
11010
11011 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
11012 the display spec is of the form `(space ...)'.
11013 (handle_display_spec): Return the value returned by
11014 handle_single_display_spec, not just 1 or zero.
11015 (handle_single_display_spec): If the display spec is of the form
11016 `(space ...)', and specifies display in the text area, return 2
11017 rather than 1.
fee65a97 11018 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
11019 accurately, and prefer exact match for point under bidi.
11020 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
11021
11022 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
11023 into disp_prop; all users changed.
11024
11025 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
11026 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
11027 for the text covered by the display property.
11028
e4ed06f1
CY
110292011-08-25 Chong Yidong <cyd@stupidchicken.com>
11030
11031 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
11032 Change return value to nil.
11033 (Frecord_buffer): Delete unused function.
11034
f67cdd7f
EZ
110352011-08-24 Eli Zaretskii <eliz@gnu.org>
11036
5980d4c6
EZ
11037 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
11038 buffers, return left-to-right.
8610fe8b
EZ
11039 (set_cursor_from_row): Consider candidate row a win if its glyph
11040 represents a newline and point is on that newline. Fixes cursor
11041 positioning on the newline at EOL of R2L text within L2R
11042 paragraph, and vice versa.
11043 (try_cursor_movement): Check continued rows, in addition to
11044 continuation rows. Fixes unwarranted scroll when point enters a
11045 continued line of R2L text within an L2R paragraph, or vice versa.
11046 (cursor_row_p): Consider the case of point being equal to
11047 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
11048 from the end of a short line to the beginning of a continued line
11049 of R2L text within L2R paragraph.
11050 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
11051 composed characters.
5980d4c6 11052
f67cdd7f
EZ
11053 * bidi.c (bidi_check_type): Use xassert.
11054 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
11055 members.
11056
bca633fb
EZ
110572011-08-23 Eli Zaretskii <eliz@gnu.org>
11058
11059 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
11060 a character.
11061
4a5885a7
CY
110622011-08-23 Chong Yidong <cyd@stupidchicken.com>
11063
11064 * nsfont.m (ns_otf_to_script): Fix typo.
11065
0902a04e
KH
110662011-08-22 Kenichi Handa <handa@m17n.org>
11067
11068 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
11069 extra slot even if the purpose is char-code-property-table.
11070
1a2e6670
EZ
110712011-08-23 Eli Zaretskii <eliz@gnu.org>
11072
8ddde651
EZ
11073 * xdisp.c (redisplay_window): When computing centering_position,
11074 account for the height of the header line. (Bug#8874)
11075
425cc014
EZ
11076 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
11077 instead of CHAR_TO_BYTE. Fixes a crash when a completion
11078 candidate is selected by the mouse, and that candidate has a
11079 composed character under the mouse.
11080
1a2e6670
EZ
11081 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
11082 coordinates reported by pos-visible-in-window-p for a composed
11083 character in column zero.
11084
8b76d6f8
SM
110852011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
11086
11087 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
11088
dac347dd
EZ
110892011-08-22 Eli Zaretskii <eliz@gnu.org>
11090
11091 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
11092 consider it a hit if to_charpos is anywhere in the range of the
11093 composed buffer positions.
11094
e013fb34
CY
110952011-08-22 Chong Yidong <cyd@stupidchicken.com>
11096
11097 * image.c (gif_load): Don't assume that each subimage has the same
11098 dimensions as the base image. Handle disposal method that is
11099 "undefined" by the gif spec (Bug#9335).
11100
bd1ba3e8
CY
111012011-08-20 Chong Yidong <cyd@stupidchicken.com>
11102
11103 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 11104 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 11105
54a1215b
EZ
111062011-08-19 Eli Zaretskii <eliz@gnu.org>
11107
823564e5
EZ
11108 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
11109 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
11110 from an Org mode buffer to a Speedbar frame.
11111
54a1215b
EZ
11112 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
11113 a composition, take its buffer position from IT->cmp_it.charpos.
11114 Fixes cursor positioning at the beginning of a line that begins
11115 with a composed character.
11116
9778ebcc
EZ
111172011-08-18 Eli Zaretskii <eliz@gnu.org>
11118
0be6ee06
EZ
11119 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
11120 character bidirectional type, use STRONG_L instead. Fixes crashes
11121 in a buffer produced by `describe-categories'.
11122
9778ebcc
EZ
11123 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
11124 members before the level stack, so they would be saved and
11125 restored when copying iterator state. Fixes incorrect reordering
11126 around TABs covered by display properties.
11127
156bffbe
AS
111282011-08-18 Andreas Schwab <schwab@linux-m68k.org>
11129
6b02f655 11130 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 11131
72ad093b
CY
111322011-08-17 Chong Yidong <cyd@stupidchicken.com>
11133
11134 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
11135 (internal_condition_case_2, internal_condition_case_n):
11136 Remove unnecessary aborts (Bug#9081).
72ad093b 11137
35774242
EZ
111382011-08-17 Eli Zaretskii <eliz@gnu.org>
11139
11140 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
11141 has no `load' handler, try opening the file locally. (Bug#9311)
11142
db76dd85
KB
111432011-08-16 Ken Brown <kbrown@cornell.edu>
11144
11145 * gmalloc.c: Expand comment.
11146
b215eee5
EZ
111472011-08-16 Eli Zaretskii <eliz@gnu.org>
11148
11149 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
11150 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
11151
a4579d33
KB
111522011-08-16 Ken Brown <kbrown@cornell.edu>
11153
11154 Fix memory allocation problems in Cygwin build (Bug#9273).
11155
11156 * unexcw.c ( __malloc_initialized): Declare external variable.
11157 (fixup_executable): Force the dumped emacs to reinitialize malloc.
11158
8b76d6f8
SM
11159 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
11160 New variables.
a4579d33
KB
11161 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
11162 dumped emacs.
11163 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
11164 in the static heap.
11165 [CYGWIN] (special_realloc): New function.
11166 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
11167 requests to realloc storage in the static heap.
11168
3ebec551
PE
111692011-08-15 Paul Eggert <eggert@cs.ucla.edu>
11170
11171 * bidi.c (bidi_initialize): Remove unused local.
11172
9fd8be00
EZ
111732011-08-15 Eli Zaretskii <eliz@gnu.org>
11174
6b02f655
SM
11175 * bidimirror.h:
11176 * biditype.h: Remove file.
11177 * makefile.w32-in ($(BLD)/bidi.$(O)):
11178 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
11179
11180 * dispextern.h: Fix a typo in the comment to bidi_type_t.
11181
11182 * chartab.c: Improve commentary for the uniprop_table API.
11183
32413314
EZ
11184 * bidi.c (bidi_paragraph_init): Support zero value of
11185 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
11186 (bidi_initialize): Use uniprop_table instead of including
11187 biditype.h and bidimirror.h.
32413314 11188
9fd8be00
EZ
11189 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
11190 coordinates of the iterator when restoring from ppos_it.
11191 (Bug#9296)
11192
5cf2b69b
KH
111932011-08-14 Kenichi Handa <handa@m17n.org>
11194
11195 * process.c (create_process): Call setup_process_coding_systems
72ad093b 11196 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 11197
daf17d00
EZ
111982011-08-14 Eli Zaretskii <eliz@gnu.org>
11199
11200 * xdisp.c (move_it_in_display_line_to): Don't invoke
11201 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
11202 ppos_it. Fixes vertical cursor motion when line beginning is
11203 covered by an image. (Bug#9296)
11204
08e3161a
JD
112052011-08-14 Jan Djärv <jan.h.d@swipnet.se>
11206
11207 * nsterm.h (ns_run_ascript): Declare.
11208 (NSAPP_DATA2_RUNASSCRIPT): Define.
11209
11210 * nsfns.m (as_script, as_result, as_status): New static variables.
11211 (ns_run_ascript): New function.
5e617bc2 11212 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
11213 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
11214 the event loop. Get status from as_status (Bug#7276).
11215
11216 * nsterm.m (sendEvent): If event is NSApplicationDefined and
11217 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
11218 the event loop (Bug#7276).
11219
a3720aa2
AS
112202011-08-14 Andreas Schwab <schwab@linux-m68k.org>
11221
11222 * gnutls.c (QCgnutls_bootprop_priority)
11223 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
11224 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
11225 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
11226 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
11227 (QCgnutls_bootprop_verify_hostname_error)
11228 (QCgnutls_bootprop_callbacks_verify): Rename from
11229 Qgnutls_bootprop_..., all uses changed.
11230
11231 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
11232 uses changed.
11233
0a0d27fb
PE
112342011-08-14 Paul Eggert <eggert@cs.ucla.edu>
11235
19d5c50c
PE
11236 * xfaces.c (Qframe_set_background_mode): Now static.
11237 * dispextern.h (Qframe_set_background_mode): Remove decl.
11238
0a0d27fb
PE
11239 * process.c (Fnetwork_interface_info): Declare local only if needed.
11240
377538cb
JD
112412011-08-13 Jan Djärv <jan.h.d@swipnet.se>
11242
11243 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
11244 (Fnetwork_interface_list): Allocate in increments of bytes instead
11245 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
11246 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
11247 sockaddr.
11248 (struct ifflag_def): notrailers is smart on OSX.
11249 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
11250 Get hardware address with getifaddrs if available.
11251
08fff70c
EZ
112522011-08-12 Eli Zaretskii <eliz@gnu.org>
11253
11254 * xdisp.c (iterate_out_of_display_property): xassert that
11255 IT->position is set to within IT->object's boundaries. Break from
11256 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
11257 when IT->position is set up wrongly due to some bug.
11258 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
11259 (push_display_prop): Allow GET_FROM_STRING as IT->method on
11260 entry. Force push_it to save on the stack the current
11261 buffer/string position, to be restored by pop_it. Fix flags in
11262 the iterator structure wrt the object coming from a display
11263 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
11264 properties. (Bug#9284)
11265
7be1c708 112662011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 11267
7be1c708
CY
11268 * fontset.c (fontset_get_font_group): Add proper type checks.
11269 (Bug#9172)
aac0c6e3 11270
7be1c708 112712011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 11272
7be1c708
CY
11273 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
11274 and LC_VERSION_MIN_MACOSX.
11275 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
11276 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 11277
97bb72a6
EZ
112782011-08-08 Eli Zaretskii <eliz@gnu.org>
11279
11280 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
11281 no-display-properties-and-no-overlays under bidi display.
11282 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 11283 properties and overlays.
97bb72a6 11284
d5617611
CY
112852011-08-08 Chong Yidong <cyd@stupidchicken.com>
11286
37e11a63
CY
11287 * editfns.c (Fset_time_zone_rule): Document relationship with the
11288 setenv function.
11289
d5617611
CY
11290 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
11291 the font entity extracted from the cache (Bug#8109).
11292
58872834
CY
112932011-08-07 Chong Yidong <cyd@stupidchicken.com>
11294
11295 * composite.c (autocmp_chars): Don't reset point. That is done by
11296 restore_point_unwind (Bug#5984).
11297
75bfc667
JL
112982011-08-07 Juri Linkov <juri@jurta.org>
11299
11300 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
11301 to show the arg `TIME' instead of `TIMEVAL'.
11302
d1410150
EZ
113032011-08-06 Eli Zaretskii <eliz@gnu.org>
11304
11305 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
11306 display property strides EOL and includes a newline, as in
11307 longlines-mode. (Bug#9254)
75b771e4
EZ
11308 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
11309 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
11310
11311 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
11312 is non-zero, even if the data buffer is NULL. Fixes a crash in
11313 vertical-motion with longlines-mode. (Bug#9254)
11314
35928349
EZ
113152011-08-05 Eli Zaretskii <eliz@gnu.org>
11316
ec7cc85b
EZ
11317 * bidi.c <bidi_cache_total_alloc>: Now static.
11318 (bidi_initialize): Initialize bidi_cache_total_alloc.
11319
8b76d6f8 11320 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
11321 cache. (Bug#9221)
11322
11323 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
11324 amount allocated this far in `bidi_cache_total_alloc'.
11325 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
11326 non-zero, only free the data buffer without restoring the cache
11327 contents. All callers changed.
11328
11329 * dispextern.h (bidi_unshelve_cache): Update prototype.
11330
11331 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
11332 (move_it_in_display_line, move_it_to)
11333 (move_it_vertically_backward, move_it_by_lines): Replace the call
11334 to xfree to an equivalent call to bidi_unshelve_cache.
11335 (move_it_in_display_line_to): Fix logic of returning
412b6358 11336 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 11337
e2e2423b
EZ
113382011-08-05 Eli Zaretskii <eliz@gnu.org>
11339
11340 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
11341 came from a string character with a `cursor' property. (Bug#9229)
11342
ae9e757a
JD
113432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11344
11345 * Makefile.in (LIB_PTHREAD): New variable.
11346 (LIBES): Add LIB_PTHREAD (Bug#9216).
11347
11348 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
11349 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
11350
213bd7f2
AS
113512011-08-04 Andreas Schwab <schwab@linux-m68k.org>
11352
6b02f655 11353 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 11354
99aaf75f
JD
113552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11356
11357 * xterm.c (x_find_topmost_parent): New function.
11358 (x_set_frame_alpha): Find topmost parent window with
11359 x_find_topmost_parent and set the property there also (bug#9181).
11360 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
11361
c74e9d86
PE
113622011-08-04 Paul Eggert <eggert@cs.ucla.edu>
11363
11364 * callproc.c (Fcall_process): Avoid vfork clobbering
11365 the local vars buffer, coding_systems, current_dir.
11366
640c8776
SM
113672011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
11368
11369 * keymap.c (Fmake_composed_keymap): Move to subr.el.
11370
f26d0e4c
PE
113712011-08-03 Paul Eggert <eggert@cs.ucla.edu>
11372
8a10d76c
PE
11373 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
11374 so that it is not optimized away.
11375
f26d0e4c
PE
11376 * xdisp.c (compute_display_string_pos): Remove unused local.
11377
55439c61
EZ
113782011-08-02 Eli Zaretskii <eliz@gnu.org>
11379
11380 Fix slow cursor motion and scrolling in large buffers with
11381 selective display, like Org Mode buffers. (Bug#9218)
11382
11383 * dispextern.h (struct bidi_it): New member disp_prop_p.
11384
11385 * xdisp.c: Remove one-slot cache of display string positions.
11386 (compute_display_string_pos): Accept an additional argument
5e617bc2 11387 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
11388 for a display string or property. If found, set DISP_PROP_P
11389 non-zero.
11390
11391 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
11392 DISP_PROP_P, and pass it to compute_display_string_pos.
11393 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
11394 non-zero. All callers of bidi_fetch_char changed.
11395
fb33fa43
SM
113962011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
11397
11398 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
11399
b099e063
DM
114002010-12-03 Don March <don@ohspite.net>
11401
11402 * keymap.c (Fdefine_key): Fix non-prefix key error message when
11403 last character M-[char] is translated to ESC [char] (bug#7541).
11404
5cc7f7af
KH
114052011-08-02 Kenichi Handa <handa@m17n.org>
11406
d0fffa3f 11407 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
11408
11409 * chartab.c (uniprop_table): Make it non-static.
11410
525d5e6e
EZ
114112011-08-01 Eli Zaretskii <eliz@gnu.org>
11412
11413 * xdisp.c (forward_to_next_line_start): Accept additional argument
11414 BIDI_IT_PREV, and store into it the state of the bidi iterator had
11415 on the newline.
11416 (reseat_at_next_visible_line_start): Use the bidi iterator state
11417 returned by forward_to_next_line_start to restore the state of
11418 it->bidi_it after backing up to previous newline. (Bug#9212)
11419
31011111
AS
114202011-07-30 Andreas Schwab <schwab@linux-m68k.org>
11421
11422 * regex.c (re_comp): Protoize.
11423 (re_exec): Fix return type.
11424 (regexec): Fix type of `ret'. (Bug#9203)
11425
476371c4
PE
114262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11427
e5d76069
PE
11428 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
11429 This is needed if max-image-size is a floating-point number.
11430
9a79b20c
AS
114312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
11432
11433 * print.c (print_object): Print empty symbol as ##.
11434
11435 * lread.c (read1): Read ## as empty symbol.
11436
d8c2fa78
AA
114372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
11438
11439 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
11440 setting frame foreground color (Bug#9175).
11441 (x_set_background_color): Likewise.
11442
ffe57a7a
AA
11443 * nsmenu.m (-setText): Size tooltip dimensions precisely to
11444 contents (Bug#9176).
11445 (EmacsTooltip -init): Remove bezels and add shadows to
11446 tooltip windows.
11447
bf3492a5
AA
11448 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
11449 or scroll bar (Bug#8470).
11450
d55e9c53
AA
11451 * nsfont.m (nsfont_open): Remove assignment to voffset and
11452 unnecessary vars hshink, expand, hd, full_height, min_height.
11453 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
11454
11455 * nsterm.h (nsfont_info): Remove voffset field.
11456
d8c2fa78 114572011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
11458
11459 Implement strike-through and overline on NextStep (Bug#8863).
11460
11461 * nsfont.m (nsfont_open): Use underline position provided by font,
11462 instead of hard-coded value of 2.
11463 (nsfont_draw): Call ns_draw_text_decoration instead.
11464
11465 * nsterm.h: Add declaration for ns_draw_text_decoration.
11466
11467 * nsterm.m (ns_draw_text_decoration): New function for drawing
11468 underline, overline, and strike-through.
11469 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
11470 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 11471 accommodate underlining, etc.
4843aac3 11472
4cc60b9b
EZ
114732011-07-28 Eli Zaretskii <eliz@gnu.org>
11474
bc7ece87
EZ
11475 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
11476 default.
4cc60b9b 11477
476371c4
PE
114782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11479
66606eea
PE
11480 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
11481 Without this fix, if a signal arrives just after memory fills up,
11482 'malloc' might be invoked reentrantly.
11483
476371c4
PE
11484 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
11485 In other words, assume that every image size is allowed, on non-X
11486 hosts. This assumption is probably wrong, but it lets Emacs compile.
11487
f3fcc40d
AS
114882011-07-28 Andreas Schwab <schwab@linux-m68k.org>
11489
11490 * regex.c (re_iswctype): Convert return values to boolean.
11491
350c992f
EZ
114922011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
11493
11494 * xdisp.c (compute_display_string_pos): Don't use cached display
11495 string position if the buffer had its restriction changed.
11496 (Bug#9184)
11497
5266b4bb
PE
114982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11499
11500 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11501
2573a837 115022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 11503
41f55ccd 11504 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 11505
39e378da
PE
11506 * bidi.c: Integer size and overflow fixes.
11507 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
11508 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
11509 (bidi_cache_find_level_change, bidi_cache_ensure_space)
11510 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
11511 (bidi_find_other_level_edge):
11512 Use ptrdiff_t instead of EMACS_INT where either will do.
11513 This works better on 32-bit hosts configured --with-wide-int.
11514 (bidi_cache_ensure_space): Check for size-calculation overflow.
11515 Use % rather than repeated addition, for better worst-case speed.
11516 Don't set bidi_cache_size until after xrealloc returns, because it
11517 might not return.
11518 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
11519 (bidi_cache_ensure_space): Also check that the bidi cache size
11520 does not exceed that of the largest Lisp string or buffer. See Eli
11521 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 11522
5e927815
PE
11523 * alloc.c (__malloc_size_t): Remove.
11524 All uses replaced by size_t. See Andreas Schwab's note
11525 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
11526
ca4aa935
PE
11527 * image.c: Improve checking for integer overflow.
11528 (check_image_size): Assume that f is nonnull, since
11529 it is always nonnull in practice. This is one less thing to
11530 worry about when checking for integer overflow later.
11531 (x_check_image_size): New function, which checks for integer
11532 overflow issues inside X.
11533 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
11534 This removes the need for a memory_full check.
11535 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
11536 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
11537 (xbm_read_bitmap_data): Change locals back to 'int', since
11538 their values must fit in 'int'.
11539 (xpm_load_image, png_load, tiff_load):
11540 Invoke x_create_x_image_and_pixmap earlier,
11541 to avoid much needless work if the image is too large.
11542 (tiff_load): Treat overly large images as if
11543 x_create_x_image_and_pixmap failed, not as malloc failures.
11544 (gs_load): Use x_check_image_size.
11545
5f8f9cc2
PE
11546 * gtkutil.c: Omit integer casts.
11547 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
11548 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
11549
5adf60bc
PE
11550 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
11551
c8907a93
PE
11552 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
11553 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
11554 would wrongly return t on a 64-bit host.
11555
e3c25c68
PE
11556 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
11557 The plain *_OVERFLOW macros run afoul of GCC bug 49705
11558 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
11559 and therefore cause GCC to emit a bogus diagnostic in some cases.
11560
3f791afe
PE
11561 * image.c: Integer signedness and overflow and related fixes.
11562 This is not an exhaustive set of fixes, but it's time to
11563 record what I've got.
11564 (lookup_pixel_color, check_image_size): Remove redundant decls.
11565 (check_image_size): Don't assume that arbitrary EMACS_INT values
11566 fit in 'int', or that arbitrary 'double' values fit in 'int'.
11567 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
11568 (tiff_load, imagemagick_load_image):
11569 Check for overflow in size calculations.
11570 (x_create_x_image_and_pixmap): Remove unnecessary test for
11571 xmalloc returning NULL; that can't happen.
11572 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
11573 (xpm_color_bucket): Use better integer hashing function.
11574 (xpm_cache_color): Don't possibly over-allocate memory.
11575 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
11576 (gif_memory_source):
11577 Use ptrdiff_t, not int or size_t, to record sizes.
11578 (png_load): Don't assume values greater than 2**31 fit in 'int'.
11579 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
11580 either works, as we prefer signed integers.
11581 (tiff_read_from_memory, tiff_write_from_memory):
11582 Return tsize_t, not size_t, since that's what the TIFF API wants.
11583 (tiff_read_from_memory): Don't fail simply because the read would
11584 go past EOF; instead, return a short read.
11585 (tiff_load): Omit no-longer-needed casts.
11586 (Fimagemagick_types): Don't assume size fits into 'int'.
11587
3cc5a532
PE
11588 Improve hashing quality when configured --with-wide-int.
11589 * fns.c (hash_string): New function, taken from sxhash_string.
11590 Do not discard information about ASCII character case; this
11591 discarding is no longer needed.
11592 (sxhash-string): Use it. Change sig to match it. Caller changed.
11593 * lisp.h: Declare it.
11594 * lread.c (hash_string): Remove, since we now use fns.c's version.
11595 The fns.c version returns a wider integer if --with-wide-int is
11596 specified, so this should help the quality of the hashing a bit.
11597
b312a492
PE
11598 * emacs.c: Integer overflow minor fix.
11599 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
11600 Define only if GNU_LINUX.
11601 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
11602
dfd153ae
PE
11603 * dispnew.c: Integer signedness and overflow fixes.
11604 Remove unnecessary forward decls, that were a maintenance hassle.
11605 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
11606 All uses changed.
11607 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
11608 (scrolling_window): Use ptrdiff_t, not int, for byte count.
11609 (prepare_desired_row, line_draw_cost):
11610 Use int, not unsigned, where either works.
11611 (save_current_matrix, restore_current_matrix):
11612 Use ptrdiff_t, not size_t, where either works.
11613 (init_display): Check for overflow more accurately, and without
11614 relying on undefined behavior.
11615
a81d11a3
PE
11616 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
11617 Remove, replacing with the new symbols in lisp.h. All uses changed.
11618 * fileio.c (make_temp_name):
11619 * filelock.c (lock_file_1, lock_file):
11620 * xdisp.c (message_dolog):
11621 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
11622 Use pMd etc. instead.
11623 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
11624 replacing the pWIDE etc. symbols removed from editfns.c.
11625
3300e6fd
PE
11626 * keyboard.h (num_input_events): Now uintmax_t.
11627 This is (very slightly) less likely to mess up due to wraparound.
11628 All uses changed.
11629
fd05c7e9
PE
11630 * buffer.c: Integer signedness fixes.
11631 (alloc_buffer_text, enlarge_buffer_text):
11632 Use ptrdiff_t rather than size_t when either will do, as we prefer
11633 signed integers.
11634
903fe15d
PE
11635 * alloc.c: Integer signedness and overflow fixes.
11636 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
11637 (__malloc_size_t): Default to size_t, not to int.
11638 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
11639 (Fgarbage_collect, mark_object_loop_halt, mark_object):
11640 Prefer ptrdiff_t to size_t when either would do, as we prefer
11641 signed integers.
11642 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
11643 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
11644 Now const. Initialize with values that are in range even if char
11645 is signed.
11646 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
11647 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
11648 These functions do the right thing with sizes > 2**32.
11649 (check_depth): Now ptrdiff_t, not int.
11650 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
11651 Adjust to new way of storing sizes. Check for size overflow bugs
11652 in rest of code.
11653 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
11654 slightly wrong anyway, as it missed one instance of
11655 XMALLOC_OVERRUN_CHECK_OVERHEAD.
11656 (refill_memory_reserve): Omit needless cast to size_t.
11657 (mark_object_loop_halt): Mark as externally visible.
11658
ac82cc6a
PE
11659 * xselect.c: Integer signedness and overflow fixes.
11660 (Fx_register_dnd_atom, x_handle_dnd_message):
11661 Use ptrdiff_t, not size_t, since we prefer signed.
11662 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
11663 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
11664 x_dnd_atoms_size and x_dnd_atoms_length.
11665
c2d1e36d
PE
11666 * doprnt.c: Prefer signed to unsigned when either works.
11667 * eval.c (verror):
11668 * doprnt.c (doprnt):
11669 * lisp.h (doprnt):
11670 * xdisp.c (vmessage):
11671 Use ptrdiff_t, not size_t, when using or implementing doprnt,
11672 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
11673 prefer signed arithmetic to avoid comparison confusion.
11674 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
11675 but is a bit tricky.
11676
0e926e56
PE
11677 Assume freestanding C89 headers, string.h, stdlib.h.
11678 * data.c, doprnt.c, floatfns.c, print.c:
11679 Include float.h unconditionally.
11680 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
11681 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
11682 * regex.c: Likewise for stddef.h, string.h.
11683 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
11684 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
11685 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
11686 (STDC_HEADERS): Remove obsolete defines.
11687 * sysdep.c: Include limits.h unconditionally.
11688
9cfdb3ec
PE
11689 Assume support for memcmp, memcpy, memmove, memset.
11690 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
11691 * regex.c (memcmp, memcpy):
11692 Remove; we assume C89 now.
11693
11694 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
11695 (__malloc_safe_bcopy): Remove; no longer needed.
11696
cf950e6b 11697 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
11698 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
11699 well either way, and we prefer signed to unsigned.
11700
dbf38e02
LMI
117012011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
11702
11703 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
11704 closes the connection while we're reading (bug#9182).
11705
d6f0886c 117062011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 11707
d6f0886c
JD
11708 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
11709 are specified (Bug#9168).
24e0f6b1 11710
2eb1f9e6
PE
117112011-07-25 Paul Eggert <eggert@cs.ucla.edu>
11712
11713 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
11714 Found by GCC static checking and --with-wide-int on a 32-bit host.
11715
22381272 117162011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
11717
11718 * xdisp.c (compute_display_string_pos): Fix logic of caching
11719 previous display string position. Initialize cached_prev_pos to
11720 -1. Fixes slow-down at the beginning of a buffer.
11721
f25e39b4
EZ
117222011-07-24 Eli Zaretskii <eliz@gnu.org>
11723
11724 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
11725 for attrs[LFACE_FONTSET_INDEX].
11726
04c4b52e
PE
117272011-07-23 Paul Eggert <eggert@cs.ucla.edu>
11728
11729 * xml.c (parse_region): Remove unused local
11730 that was recently introduced.
11731
c1734fbd
EZ
117322011-07-23 Eli Zaretskii <eliz@gnu.org>
11733
be18c5a5
EZ
11734 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
11735 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
11736
c1734fbd
EZ
11737 * xdisp.c (move_it_in_display_line_to): Record the best matching
11738 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
11739 exit if none of the characters scanned was an exact match.
11740 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
11741 when exact match is impossible due to invisible text, and the
11742 lines are truncated.
11743
a258d627
JD
117442011-07-23 Jan Djärv <jan.h.d@swipnet.se>
11745
11746 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
11747 for OSX >= 10.7.
11748
b6d5a689
EZ
117492011-07-22 Eli Zaretskii <eliz@gnu.org>
11750
0f74f785
EZ
11751 Fix a significant slow-down of cursor motion with C-n, C-p,
11752 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
11753 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 11754 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
11755 (next_element_from_buffer): Call compute_stop_pos_backwards to
11756 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
11757 base_level_stop.
11758 (reseat): Don't look for prev_stop, as that could mean a very long
11759 run.
11760 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
11761 <cached_disp_overlay_modiff>: Cache for last found display string
11762 position.
551918c1 11763 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
11764 about the same buffer in the same area of character positions, and
11765 the buffer wasn't changed since the time the display string
11766 position was cached.
551918c1 11767
b2d0c91a
EZ
117682011-07-22 Eli Zaretskii <eliz@gnu.org>
11769
11770 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
11771 is an integer, which is important for empty lines. (Bug#9149)
11772
043604ee
CY
117732011-07-22 Chong Yidong <cyd@stupidchicken.com>
11774
11775 * frame.c (Fmodify_frame_parameters): In tty case, update the
11776 default face if necessary (Bug#4238).
11777
da4adb04
CY
117782011-07-21 Chong Yidong <cyd@stupidchicken.com>
11779
11780 * editfns.c (Fstring_to_char): No need to explain what a character
11781 is in the docstring (Bug#6576).
11782
9abd0532
LMI
117832011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11784
11785 * xml.c (parse_region): Make sure we always return a tree.
11786
36881d16
HK
117872011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
11788
11789 * xml.c (parse_region): If a document contains only comments,
11790 return that, too.
11791
1e98674d
LMI
117922011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11793
11794 * xml.c (make_dom): Return comments, too.
11795
590bd467
PE
117962011-07-19 Paul Eggert <eggert@cs.ucla.edu>
11797
11798 Port to OpenBSD.
11799 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
11800 and the surrounding thread.
11801 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
11802 rather than fgets, and retry after EINTR. Otherwise, 'emacs
11803 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
11804 timer goes off.
11805 * s/openbsd.h (BROKEN_SIGIO): Define.
11806 * unexelf.c (unexec) [__OpenBSD__]:
11807 Don't update the .mdebug section of the Alpha COFF symbol table.
11808
f41628b2
LMI
118092011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
11810
11811 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
11812 (bug#8460).
11813
b59b67c5
PE
118142011-07-18 Paul Eggert <eggert@cs.ucla.edu>
11815
15e3a074
PE
11816 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
11817 This fixes some race conditions on the permissions of any newly
11818 created file.
11819
41bed37d
PE
11820 * alloc.c (valid_pointer_p): Use pipe, not open.
11821 This fixes some permissions issues when debugging.
11822
b59b67c5
PE
11823 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
11824 If fchown fails to set both uid and gid, try to set just gid,
11825 as that is sometimes allowed. Adjust the file's mode to eliminate
11826 setuid or setgid bits that are inappropriate if fchown fails.
11827
925a6be7
SM
118282011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
11829
11830 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
11831 to compare Lisp_Objects.
11832 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
11833 global_gnutls_log_level, don't mistake it for a Lisp_Object.
11834 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
11835
52968808
AS
118362011-07-17 Andreas Schwab <schwab@linux-m68k.org>
11837
0a6a104b
AS
11838 * lread.c (read_integer): Unread even EOF character.
11839 (read1): Likewise. Properly record start position of symbol.
11840
52968808
AS
11841 * lread.c (read1): Read `#:' as empty uninterned symbol if no
11842 symbol character follows.
11843
9e381cdd
PE
118442011-07-17 Paul Eggert <eggert@cs.ucla.edu>
11845
11846 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
11847 This works around a problem with the previous change to Fcopy_file.
11848 Recent glibc declares fchown with __attribute__((warn_unused_result)),
11849 and without this change, GCC might complain about discarding
11850 fchown's return value.
11851
b5641435
JB
118522011-07-16 Juanma Barranquero <lekktu@gmail.com>
11853
11854 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
11855
a8031457
PE
118562011-07-16 Paul Eggert <eggert@cs.ucla.edu>
11857
11858 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
11859
dd889327
LMI
118602011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
11861
750c33f7
LMI
11862 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
11863 it's used from the C level.
11864
dd889327
LMI
11865 * process.c: Use the same condition for POLL_FOR_INPUT in both
11866 keyboard.c and process.c (bug#1858).
11867
87e86684
LM
118682011-07-09 Lawrence Mitchell <wence@gmx.li>
11869
11870 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
11871 (Fgnutls_boot): Use it.
11872
64348f40
AS
118732011-07-15 Andreas Schwab <schwab@linux-m68k.org>
11874
11875 * doc.c (Fsubstitute_command_keys): Revert last change.
11876
1d698799
LMI
118772011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
11878
f863868c
LMI
11879 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
11880 quotes the next character, and doesn't affect other longer
11881 sequences (bug#8935).
11882
1d698799
LMI
11883 * lread.c (syms_of_lread): Clarify that is isn't only
11884 `eval-buffer' and `eval-defun' that's affected by
11885 `lexical-binding' (bug#8460).
11886
aa4b6df6
EZ
118872011-07-15 Eli Zaretskii <eliz@gnu.org>
11888
11889 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 11890 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 11891
5d856da6
PE
118922011-07-14 Paul Eggert <eggert@cs.ucla.edu>
11893
ad6042bb
PE
11894 Fix minor problems found by static checking.
11895 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
11896 (elsz): Now a signed constant, not a size_t var. We prefer signed
11897 types to unsigned, to avoid integer comparison confusion. Without
11898 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
11899 "cannot optimize loop, the loop counter may overflow", a symptom
11900 of the confusion.
f00bbb22 11901 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
11902 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
11903
6468f31c
LMI
119042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11905
49080b10
LMI
11906 * search.c (Fre_search_backward): Mention `case-fold-search' in
11907 all the re_search_* functions (bug#8138).
11908
6468f31c
LMI
11909 * keyboard.c (Fopen_dribble_file): Document when the file is
11910 closed (bug#8056).
11911
c965adc5
EZ
119122011-07-14 Eli Zaretskii <eliz@gnu.org>
11913
df9733bf
EZ
11914 * bidi.c (bidi_dump_cached_states): Fix format of displaying
11915 bidi_cache_idx.
11916
0bb23927
EZ
11917 Support bidi reordering of display and overlay strings.
11918 * xdisp.c (compute_display_string_pos)
11919 (compute_display_string_end): Accept additional argument STRING.
11920 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
11921 (reseat_to_string): Initialize bidi_it->string.s and
11922 bidi_it->string.schars.
11923 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
11924 NULL (avoids a crash in bidi_paragraph_init).
11925 Initialize itb.string.lstring.
0bb23927
EZ
11926 (init_iterator): Call bidi_init_it only of a valid
11927 buffer position was specified. Initialize paragraph_embedding to
11928 L2R.
11929 (reseat_to_string): Initialize the bidi iterator.
11930 (display_string): If we need to ignore text properties of
11931 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
11932 original value of -1 will not work with bidi.)
11933 (compute_display_string_pos): First arg is now struct
11934 `text_pos *'; all callers changed. Support display properties on
11935 Lisp strings.
11936 (compute_display_string_end): Support display properties on Lisp
11937 strings.
11938 (init_iterator, reseat_1, reseat_to_string): Initialize the
11939 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
11940 when iterating on a string not from display properties).
640c8776
SM
11941 (compute_display_string_pos, compute_display_string_end):
11942 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
11943 arrow keys.
11944 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
11945 base_level_stop; instead, set base_level_stop to BEGV.
11946 Fixes crashes in vertical-motion.
0bb23927
EZ
11947 (next_element_from_buffer): Improve commentary for when
11948 the iterator is before prev_stop.
11949 (init_iterator): Initialize bidi_p from the default value of
11950 bidi-display-reordering, not from buffer-local value. Use the
11951 buffer-local value only if initializing for buffer iteration.
11952 (handle_invisible_prop): Support invisible properties on strings
11953 that are being bidi-reordered.
11954 (set_iterator_to_next): Support bidi reordering of C strings and
11955 Lisp strings.
11956 (next_element_from_string): Support bidi reordering of Lisp
11957 strings.
11958 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
11959 (display_string): Support display of R2L glyph rows.
11960 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
11961 (init_iterator): Don't initialize it->bidi_p for strings
11962 here.
11963 (reseat_to_string): Initialize it->bidi_p for strings here.
11964 (next_element_from_string, next_element_from_c_string)
11965 (next_element_from_buffer): Add xassert's for correspondence
11966 between IT's object being iterated and it->bidi_it.string
11967 structure.
11968 (face_before_or_after_it_pos): Support bidi iteration.
11969 (next_element_from_c_string): Handle the case of the first string
11970 character that is not the first one in the visual order.
11971 (get_visually_first_element): New function, refactored from common
11972 parts of next_element_from_buffer, next_element_from_string, and
11973 next_element_from_c_string.
11974 (tool_bar_lines_needed, redisplay_tool_bar)
11975 (display_menu_bar): Force left-to-right direction. Add a FIXME
11976 comment for making that be controlled by a user option.
11977 (push_it, pop_it): Save and restore the state of the
11978 bidi iterator. Save and restore the bidi_p flag.
11979 (pop_it): Iterate out of display property for string iteration as
11980 well.
11981 (iterate_out_of_display_property): Support iteration over strings.
11982 (handle_single_display_spec): Set up it->bidi_it for iteration
11983 over a display string, and call bidi_init_it.
11984 (handle_single_display_spec, next_overlay_string)
11985 (get_overlay_strings_1, push_display_prop): Set up the bidi
11986 iterator for displaying display or overlay strings.
11987 (forward_to_next_line_start): Don't use the shortcut if
11988 bidi-iterating.
11989 (back_to_previous_visible_line_start): If handle_display_prop
11990 pushed the iterator stack, restore the internal state of the bidi
11991 iterator by calling bidi_pop_it same number of times.
11992 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
11993 and we are bidi-iterating, don't decrement the iterator position;
11994 instead, set the first_elt flag in the bidi iterator, to produce
11995 the same effect.
11996 (reseat_1): Remove redundant setting of string_from_display_prop_p.
11997 (push_display_prop): xassert that we are iterating a buffer.
11998 (push_it, pop_it): Save and restore paragraph_embedding member.
11999 (handle_single_display_spec, next_overlay_string)
12000 (get_overlay_strings_1, reseat_1, reseat_to_string)
12001 (push_display_prop): Set up the `unibyte' member of bidi_it.string
12002 correctly. Don't assume unibyte strings are not bidi-reordered.
12003 (compute_display_string_pos)
12004 (compute_display_string_end): Fix handling the case of C string.
12005 (push_it, pop_it): Save and restore from_disp_prop_p.
12006 (handle_single_display_spec, push_display_prop): Set the
12007 from_disp_prop_p flag.
12008 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
12009 (pop_it): Call iterate_out_of_display_property only if we are
12010 popping after iteration over a string that came from a display
12011 property. Fix a typo in popping stretch info. Add an assertion
12012 for verifying that the iterator position is in sync with the bidi
12013 iterator.
12014 (handle_single_display_spec, get_overlay_strings_1)
12015 (push_display_prop): Fix initialization of paragraph direction for
12016 string when that of the parent object is not yet determined.
12017 (reseat_1): Call bidi_init_it to resync the bidi
12018 iterator with IT's position. (Bug#7616)
12019 (find_row_edges): If ROW->start.pos gives position
12020 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
12021 (handle_stop, back_to_previous_visible_line_start, reseat_1):
12022 Reset the from_disp_prop_p flag.
12023 (SAVE_IT, RESTORE_IT): New macros.
12024 (pos_visible_p, face_before_or_after_it_pos)
12025 (back_to_previous_visible_line_start)
12026 (move_it_in_display_line_to, move_it_in_display_line)
12027 (move_it_to, move_it_vertically_backward, move_it_by_lines)
12028 (try_scrolling, redisplay_window, display_line): Use them when
12029 saving a temporary copy of the iterator and restoring it back.
12030 (back_to_previous_visible_line_start, reseat_1)
12031 (init_iterator): Empty the bidi cache "stack".
12032 (move_it_in_display_line_to): If iterator ended up at
12033 EOL, but we never saw any buffer positions smaller than
12034 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
12035 motion in bidi-reordered lines.
12036 (move_it_in_display_line_to): Record prev_method and prev_pos
12037 immediately before the call to set_iterator_to_next. Fixes cursor
12038 motion in bidi-reordered lines with stretch glyphs and strings
12039 displayed in margins. (Bug#8133) (Bug#8867)
12040 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
12041 TO_CHARPOS.
640c8776
SM
12042 (pos_visible_p): Support positions in bidi-reordered lines.
12043 Save and restore bidi cache.
0bb23927
EZ
12044
12045 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
12046 (bidi_paragraph_info): Delete unused struct.
12047 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
12048 (bidi_cache_start): New variable.
12049 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
12050 to zero.
12051 (bidi_cache_fetch_state, bidi_cache_search)
12052 (bidi_cache_find_level_change, bidi_cache_iterator_state)
12053 (bidi_cache_find, bidi_peek_at_next_level)
12054 (bidi_level_of_next_char, bidi_find_other_level_edge)
12055 (bidi_move_to_visually_next): Compare cache index with
12056 bidi_cache_start rather than with zero.
12057 (bidi_fetch_char): Accept new argument STRING; all callers
12058 changed. Support iteration over a string. Support strings with
12059 display properties. Support unibyte strings. Fix the type of
12060 `len' according to what STRING_CHAR_AND_LENGTH expects.
12061 (bidi_paragraph_init, bidi_resolve_explicit_1)
12062 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
12063 (bidi_level_of_next_char, bidi_move_to_visually_next):
12064 Support iteration over a string.
0bb23927
EZ
12065 (bidi_set_sor_type, bidi_resolve_explicit_1)
12066 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
12067 can now be zero (for strings); special values 0 and -1 were
12068 changed to -1 and -2, respectively.
12069 (bidi_char_at_pos): New function.
12070 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
12071 Call it instead of FETCH_MULTIBYTE_CHAR.
12072 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
12073 initialized to valid values.
12074 (bidi_init_it): Don't initialize charpos and bytepos with invalid
12075 values.
12076 (bidi_level_of_next_char): Allow the sentinel "position" to pass
12077 the test for valid cached positions. Fix the logic for looking up
12078 the sentinel state in the cache. GCPRO the Lisp string we are
12079 iterating.
12080 (bidi_push_it, bidi_pop_it): New functions.
12081 (bidi_initialize): Initialize the bidi cache start stack pointer.
12082 (bidi_cache_ensure_space): New function, refactored from part of
12083 bidi_cache_iterator_state. Don't assume the required size is just
12084 one BIDI_CACHE_CHUNK away.
12085 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
12086 (bidi_count_bytes, bidi_char_at_pos): New functions.
12087 (bidi_cache_search): Don't assume bidi_cache_last_idx is
12088 always valid if bidi_cache_idx is valid.
12089 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
12090 is valid if it's going to be used.
12091 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
12092 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
12093 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12094 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
12095 (bidi_find_other_level_edge, bidi_cache_start_stack):
12096 All variables related to cache indices are now EMACS_INT.
c965adc5 12097
0bb23927
EZ
12098 * dispextern.h (struct bidi_string_data): New structure.
12099 (struct bidi_it): New member `string'. Make flag members be 1-bit
12100 fields, and put them last in the struct.
640c8776
SM
12101 (compute_display_string_pos, compute_display_string_end):
12102 Update prototypes.
0bb23927
EZ
12103 (bidi_push_it, bidi_pop_it): Add prototypes.
12104 (struct iterator_stack_entry): New members bidi_p,
12105 paragraph_embedding, and from_disp_prop_p.
12106 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
12107 (bidi_shelve_cache, bidi_unshelve_cache):
12108 Declare prototypes.
0bb23927
EZ
12109
12110 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
12111 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
12112 and vector-like objects.
12113
12114 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
12115 cache around display iteration.
12116
12117 * window.c (Fwindow_end, window_scroll_pixel_based)
12118 (displayed_window_lines, Frecenter): Save and restore the bidi
12119 cache around display iteration.
12120
3bbd2265
LMI
121212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12122
12123 * editfns.c (Fdelete_region): Clarify the use of the named
12124 parameters (bug#6788).
12125
adc47434
MR
121262011-07-14 Martin Rudalics <rudalics@gmx.at>
12127
12128 * indent.c (Fvertical_motion): Set and restore w->pointm when
12129 saving and restoring the window's buffer (Bug#9006).
12130
837c31f8
LMI
121312011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
12132
12133 * editfns.c (Fstring_to_char): Clarify just what is returned
12134 (bug#6576). Text by Eli Zaretskii.
12135
ac389d0c
JB
121362011-07-13 Juanma Barranquero <lekktu@gmail.com>
12137
12138 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
12139
0be0ce47
EZ
121402011-07-13 Eli Zaretskii <eliz@gnu.org>
12141
12142 * buffer.c (mmap_find): Fix a typo.
12143
cd18e7e3
JB
121442011-07-13 Johan Bockgård <bojohan@gnu.org>
12145
12146 Fix execution of x selection hooks.
12147 * xselect.c (Qx_lost_selection_functions)
12148 (Qx_sent_selection_functions): New vars.
12149 (syms_of_xselect): DEFSYM them.
12150 (x_handle_selection_request): Pass Qx_sent_selection_functions
12151 rather than Vx_sent_selection_functions to Frun_hook_with_args.
12152 (x_handle_selection_clear,x_clear_frame_selections):
12153 Pass Qx_lost_selection_functions rather than
12154 Vx_lost_selection_functions to Frun_hook_with_args.
12155
47ea7f44
PE
121562011-07-13 Paul Eggert <eggert@cs.ucla.edu>
12157
ac389d0c 12158 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
12159 The old code sometimes used this field without initializing it.
12160
47ea7f44
PE
12161 * alloc.c (gc_sweep): Don't read past end of array.
12162 In theory, the old code could also have corrupted Emacs internals,
12163 though it'd be very unlikely.
12164
bc985c87
AS
121652011-07-12 Andreas Schwab <schwab@linux-m68k.org>
12166
12167 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 12168 argument. (Bug#4026)
bc985c87 12169
0cf34688
LMI
121702011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
12171
b3dadd76
LMI
12172 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
12173 key" (bug#4257).
12174
0cf34688
LMI
12175 * window.c (Fset_window_start): Doc fix (bug#4199).
12176 (Fset_window_hscroll): Ditto.
12177
270768cd
PE
121782011-07-12 Paul Eggert <eggert@cs.ucla.edu>
12179
077e3dda 12180 Fix minor new problems caught by GCC 4.6.1.
270768cd 12181 * term.c (init_tty): Remove unused local.
490011a6 12182 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 12183 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 12184 not used otherwise.
270768cd 12185
b1f58454
CY
121862011-07-12 Chong Yidong <cyd@stupidchicken.com>
12187
12188 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
12189
22b9578d
LMI
121902011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
12191
6e70ab07
LMI
12192 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
12193 are the mini-buffer and the echo area (bug#3320).
12194
22b9578d
LMI
12195 * term.c (init_tty): Remove support for supdup, c10 and perq
12196 terminals, which are no longer supported (bug#1482).
12197
8974cc9f
JB
121982011-07-10 Johan Bockgård <bojohan@gnu.org>
12199
12200 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
12201
a560d974
JD
122022011-07-10 Jan Djärv <jan.h.d@swipnet.se>
12203
12204 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
12205 for non-popups (Bug#3642).
12206
1dae0f0a
AS
122072011-07-10 Andreas Schwab <schwab@linux-m68k.org>
12208
268c2c36 12209 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 12210 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
12211 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
12212 * cm.c (losecursor): Likewise.
1dae0f0a
AS
12213 * data.c (fmod): Likewise.
12214 * dispnew.c (swap_glyphs_in_rows): Likewise.
12215 * emacs.c (memory_warning_signal): Likewise.
12216 * floatfns.c (float_error): Likewise.
12217 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
12218 (otf_open, font_otf_capability, generate_otf_features)
12219 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
12220 Likewise.
12221 * image.c (pbm_read_file): Likewise.
12222 * indent.c (string_display_width): Likewise.
12223 * intervals.c (check_for_interval, search_for_interval)
12224 (inc_interval_count, count_intervals, root_interval)
12225 (adjust_intervals_for_insertion, make_new_interval): Likewise.
12226 * lread.c (defalias): Likewise.
268c2c36 12227 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
12228 * regex.c (set_image_of_range_1, set_image_of_range)
12229 (regex_grow_registers): Likewise.
12230 * sysdep.c (strerror): Likewise.
12231 * termcap.c (valid_filename_p, tprint, main): Likewise.
12232 * tparam.c (main): Likewise.
12233 * unexhp9k800.c (run_time_remap, save_data_space)
12234 (update_file_ptrs, read_header, write_header, calculate_checksum)
12235 (copy_file, copy_rest, display_header): Likewise.
12236 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
12237 Likewise.
12238 * xdisp.c (check_it): Likewise.
12239 * xfaces.c (register_color, unregister_color, unregister_colors):
12240 Likewise.
12241 * xfns.c (print_fontset_result): Likewise.
12242 * xrdb.c (member, fatal, main): Likewise.
12243
99033785
PE
122442011-07-10 Paul Eggert <eggert@cs.ucla.edu>
12245
12246 Fix minor problems found by static checking (Bug#9031).
12247 * chartab.c (char_table_set_range, map_sub_char_table):
12248 Remove unused locals.
12249 (uniprop_table): Now static.
12250 * composite.c (_work_char): Remove unused static var.
12251
9cb2ac56
JB
122522011-07-09 Juanma Barranquero <lekktu@gmail.com>
12253
12254 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
12255
f25661f0
JD
122562011-07-09 Jan Djärv <jan.h.d@swipnet.se>
12257
12258 * gtkutil.c (qttip_cb): Remove code without function.
12259
8278c4fe
EZ
122602011-07-09 Eli Zaretskii <eliz@gnu.org>
12261
12262 * w32.c (pthread_sigmask): New stub.
12263
1692ae2d 122642011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 12265
8a6ebd58 12266 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
12267 sigprocmask is portable only for single-threaded applications, and
12268 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
12269 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
12270 (LIBES): Use it.
12271 * callproc.c (Fcall_process):
12272 * process.c (create_process):
12273 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
12274 Use pthread_sigmask, not sigprocmask.
123403e4 12275
1b854618
JD
122762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12277
12278 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
12279 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
12280 wrong (Bug#8591).
12281
3fe4b549
JD
122822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12283
0ce7e563
JD
12284 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
12285 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
12286 (xg_hide_tooltip): Fix comment.
12287
3fe4b549
JD
12288 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
12289 in registerServicesMenuSendTypes.
12290 (validRequestorForSendType): Don't check ns_return_types.
12291
12292 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
12293 ns_return_type.
12294
5df75e47
JR
122952011-07-08 Jason Rumney <jasonr@gnu.org>
12296
22610910
JR
12297 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
12298 SH_SHOW for hidden windows (Bug#5482).
12299
5df75e47
JR
12300 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
12301 frame struct members of non-existent frames (Bug#6284).
12302
699c10bd
JD
123032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12304
4393663b
JD
12305 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
12306 variable firstTime not needed on OSX >= 10.6.
12307 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
12308 >= 10.5. Use setKnobProportion, setDoubleValue.
12309
12310 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
12311 (MAC_OS_X_VERSION_10_5): Define if not defined.
12312 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
12313 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
12314 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
12315
12316 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 12317 cString and lossyCString on OSX >= 10.4.
4393663b 12318
58179cce 12319 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
12320 sizeToFit on OSX >= 10.2.
12321
12322 * nsimage.m (allocInitFromFile): Don't use deprecated method
12323 bestRepresentationForDevice on OSX >= 10.6.
12324
12325 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
12326 to avoid warning.
12327
12328 * emacs.c: Declare unexec_init_emacs_zone.
12329
a63e0781
JD
12330 * nsgui.h: Fix compiler warning about gnulib redefining verify.
12331
699c10bd
JD
12332 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
12333
12334 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
12335 on svcsMenu (Bug#8842).
12336
12337 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
12338 ns_return_types.
12339 (Fns_list_services): Just return Qnil on 10.6, code not working there.
12340
12341 * nsterm.m (QUTF8_STRING): Declare.
12342 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
12343 (validRequestorForSendType): Return type is (id).
12344 Change indexOfObjectIdenticalTo to indexOfObject.
12345 Check if we have local selection before returning self (Bug#8842).
12346 (writeSelectionToPasteboard): Put local selection into paste board
12347 if we have a local selection (Bug#8842).
12348 (syms_of_nsterm): DEFSYM QUTF8_STRING.
12349
12350 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
12351 (ns_get_local_selection): Declare.
12352
54e10184
LMI
123532011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
12354
9888ff71
LMI
12355 * keymap.c (describe_map_tree): Don't insert a double newline at
12356 the end of the buffer (bug#1169) and return whether we inserted
12357 something.
12358
54e10184
LMI
12359 * callint.c (Fcall_interactively): Change "reading args" to
12360 "providing args" to try to clarify what it does (bug#1010).
12361
15fa4783
KH
123622011-07-07 Kenichi Handa <handa@m17n.org>
12363
12364 * composite.c (composition_compute_stop_pos): Ignore a static
12365 composition starting before CHARPOS (Bug#8915).
12366
12367 * xdisp.c (handle_composition_prop): Likewise.
12368
a8815b00
EZ
123692011-07-07 Eli Zaretskii <eliz@gnu.org>
12370
12371 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
12372 (Bug#9015)
12373
ef7b981d 123742011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
12375
12376 * character.h (unicode_category_t): New enum type.
12377
12378 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
12379 (Qchar_code_property_table): New variable.
12380 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
12381 (UNIPROP_COMPRESSED_FORM_P): New macros.
12382 (char_table_ascii): Uncompress the compressed values.
12383 (sub_char_table_ref): New arg is_uniprop. Callers changed.
12384 Uncompress the compressed values.
ac389d0c 12385 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
12386 (char_table_ref_and_range): Uncompress the compressed values.
12387 (sub_char_table_set): New arg is_uniprop. Callers changed.
12388 Uncompress the compressed values.
12389 (sub_char_table_set_range): Args changed. Callers changed.
12390 (char_table_set_range): Adjuted for the above change.
12391 (map_sub_char_table): Delete args default_val and parent. Add arg
12392 top. Give decoded values to a Lisp function.
640c8776 12393 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
12394 values to a Lisp function. Gcpro more variables.
12395 (uniprop_table_uncompress)
12396 (uniprop_decode_value_run_length): New functions.
12397 (uniprop_decoder, uniprop_decoder_count): New variables.
12398 (uniprop_get_decoder, uniprop_encode_value_character)
12399 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
12400 New functions.
12401 (uniprop_encoder, uniprop_encoder_count): New variables.
12402 (uniprop_get_encoder, uniprop_table)
12403 (Funicode_property_table_internal, Fget_unicode_property_internal)
12404 (Fput_unicode_property_internal): New functions.
12405 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
12406 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 12407 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
12408 char-code-property-alist.
12409
640c8776 12410 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
12411 Vunicode_category_table.
12412
640c8776 12413 * font.c (font_range): Adjust for the change of
c805dec0
KH
12414 Vunicode_category_table.
12415
76b397fb
DN
124162011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
12417
12418 * m/iris4d.h: Remove file, move contents ...
12419 * s/irix6-5.h: ... here.
12420
22b4128e
PE
124212011-07-06 Paul Eggert <eggert@cs.ucla.edu>
12422
12423 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
12424 * alloc.c (mark_buffer):
12425 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
12426 (clone_per_buffer_values): Don't assume that
22b4128e
PE
12427 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
12428 This isn't true in general, and it's particularly not true
12429 if Emacs is configured with --with-wide-int.
12430 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
12431 New macros, used in the buffer.c change.
12432
869795d6
JD
124332011-07-05 Jan Djärv <jan.h.d@swipnet.se>
12434
12435 * xsettings.c: Use both GConf and GSettings if both are available.
12436 (store_config_changed_event): Add comment.
12437 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
12438 (store_tool_bar_style_changed): New functions.
5e617bc2 12439 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
12440 (struct xsettings): Move font inside HAVE_XFT.
12441 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 12442 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 12443 Move inside HAVE_XFT.
640c8776 12444 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
12445 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
12446 also.
12447 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 12448 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 12449 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
12450 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
12451 (parse_settings): Move check for font inside HAVE_XFT.
12452 (read_settings, apply_xft_settings): Add comment.
12453 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
12454 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
12455 call store_font_name_changed.
12456 (xft_settings_event): Add comment.
12457 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
12458 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
12459 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
12460 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
12461 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
12462 (xsettings_get_system_font, xsettings_get_system_normal_font):
12463 Add comment.
869795d6 12464
d8ed26bd
PE
124652011-07-05 Paul Eggert <eggert@cs.ucla.edu>
12466
12467 Random fixes. E.g., (random) never returned negative values.
12468 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
12469 subseconds part to the entropy, as that's a bit more random.
12470 Prefer signed to unsigned, since the signedness doesn't matter and
12471 in general we prefer signed. When given a limit, use a
12472 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
12473 latter isn't right if USE_2_TAGS_FOR_INTS.
12474 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
12475 not 0..VALMASK. Don't discard "excess" bits that random () returns.
12476
cabf1cac
SM
124772011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
12478
12479 * textprop.c (text_property_stickiness):
12480 Obey Vtext_property_default_nonsticky.
12481 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
12482 * w32fns.c (syms_of_w32fns):
12483 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
12484
6e9b2be9
PE
124852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12486
12487 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
12488 This is more efficient than Ffile_directory_p and avoids a minor race.
12489
90186c68
LMI
124902011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
12491
7c301272
LMI
12492 * buffer.c (Foverlay_put): Say what the return value is
12493 (bug#7835).
12494
c4f2d8d4
LMI
12495 * fileio.c (barf_or_query_if_file_exists): Check first if the file
12496 is a directory before asking whether to use the file name
12497 (bug#7564).
ad637907
LMI
12498 (barf_or_query_if_file_exists): Make the "File is a directory"
12499 error be more correct.
c4f2d8d4 12500
90186c68
LMI
12501 * fns.c (Frequire): Remove the mention of the .gz files, since
12502 that's installation-specific, but keep the mention of
12503 `get-load-suffixes'.
12504
da64016e
PE
125052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12506
12507 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
12508 Report string overflow if the output is too long.
12509
7d47b580
JB
125102011-07-04 Juanma Barranquero <lekktu@gmail.com>
12511
a555cb87
JB
12512 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
12513 (syms_of_gnutls): Remove duplicate DEFSYM for
12514 Qgnutls_bootprop_verify_hostname_error, an error for
12515 Qgnutls_bootprop_verify_error (which is no longer used).
12516
7d47b580
JB
12517 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
12518 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
12519 Also (re)move comments that are misplaced or no longer relevant.
12520
1e49bfab
LMI
125212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12522
12523 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
12524
1485f4c0
CY
125252011-07-03 Chong Yidong <cyd@stupidchicken.com>
12526
12527 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
12528 and background color parameters if they have been changed.
12529
a9ab721e
LMI
125302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12531
12532 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
12533
cf7cff57
PE
125342011-07-03 Paul Eggert <eggert@cs.ucla.edu>
12535
2e13213d
PE
12536 * xsettings.c (SYSTEM_FONT): Define only when used.
12537 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
12538
cf7cff57
PE
12539 * keymap.c (access_keymap_1): Now static.
12540
7a8e04f7
CY
125412011-07-02 Chong Yidong <cyd@stupidchicken.com>
12542
12543 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
12544 leave any prefix arg for the up event (Bug#1586).
12545
61352f62
LMI
125462011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
12547
69bb1ef7
LMI
12548 * lread.c (syms_of_lread): Mention single symbols defined by
12549 `defvar' or `defconst' (bug#7154).
12550
61352f62 12551 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 12552 (Frequire): Mention get-load-suffixes.
61352f62 12553
28545e04
MR
125542011-07-02 Martin Rudalics <rudalics@gmx.at>
12555
12556 * window.h (window): Remove clone_number slot.
12557 * window.c (Fwindow_clone_number, Fset_window_clone_number):
12558 Remove.
12559 (make_parent_window, make_window, saved_window)
12560 (Fset_window_configuration, save_window_save): Don't deal with
12561 clone numbers.
12562 * buffer.c (Qclone_number): Remove declaration.
12563 (sort_overlays, overlay_strings): Don't deal with clone numbers.
12564
3349e122
SM
125652011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
12566
12567 Add multiple inheritance to keymaps.
12568 * keymap.c (Fmake_composed_keymap): New function.
12569 (Fset_keymap_parent): Simplify.
12570 (fix_submap_inheritance): Remove.
12571 (access_keymap_1): New function extracted from access_keymap to handle
12572 embedded parents and handle lists of maps.
12573 (access_keymap): Use it.
12574 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
12575 (Fcopy_keymap): Handle embedded parents.
12576 (Fcommand_remapping, define_as_prefix): Simplify.
12577 (Fkey_binding): Simplify.
12578 (syms_of_keymap): Move minibuffer-local-completion-map,
12579 minibuffer-local-filename-completion-map,
12580 minibuffer-local-must-match-map, and
12581 minibuffer-local-filename-must-match-map to Elisp.
12582 (syms_of_keymap): Defsubr make-composed-keymap.
12583 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
12584 (parse_menu_item): Trivial simplification.
12585
3279eb87
GM
125862011-07-01 Glenn Morris <rgm@gnu.org>
12587
12588 * Makefile.in (SETTINGS_LIBS): Fix typo.
12589
39cb9e56 125902011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
12591
12592 * coding.c (Fencode_coding_string): Record the last coding system
12593 used, as the function doc string says (bug#8738).
12594
0949d2b6
JD
125952011-07-01 Jan Djärv <jan.h.d@swipnet.se>
12596
12597 * xsettings.c (store_monospaced_changed): Take new font as arg and
12598 check for change against current_mono_font.
12599 (EMACS_TYPE_SETTINGS): Remove this and related defines.
12600 (emacs_settings_constructor, emacs_settings_get_property)
12601 (emacs_settings_set_property, emacs_settings_class_init)
12602 (emacs_settings_init, gsettings_obj): Remove.
12603 (something_changedCB): New function for HAVE_GSETTINGS.
12604 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
12605 with value as argument.
12606 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
12607 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 12608 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
12609 "changed".
12610
12611 * xgselect.c: Add defined (HAVE_GSETTINGS).
12612 (xgselect_initialize): Ditto.
12613
12614 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
12615 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
12616 xg_select.
12617
bbc6b304
PE
126182011-07-01 Paul Eggert <eggert@cs.ucla.edu>
12619
12620 * eval.c (struct backtrace): Simplify and port the data structure.
12621 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
12622 signed bit field, as this assumption is not portable and it makes
12623 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
12624 "char debug_on_exit : 1" as this is not portable either; instead,
12625 use the portable "unsigned int debug_on_exit : 1". Remove unused
12626 member evalargs. Remove obsolete comments about cc bombing out.
12627
9851bfc5
JD
126282011-06-30 Jan Djärv <jan.h.d@swipnet.se>
12629
51bb811f 12630 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
12631 Let HAVE_GSETTINGS override HAVE_GCONF.
12632 (store_monospaced_changed): New function.
12633 (EMACS_SETTINGS): A new type derived from GObject to handle
12634 GSettings notifications.
12635 (emacs_settings_constructor, emacs_settings_get_property)
12636 (emacs_settings_set_property, emacs_settings_class_init):
12637 New functions.
12638 (gsettings_client, gsettings_obj): New variables.
12639 (GSETTINGS_SCHEMA): New define.
12640 (something_changedCB): Call store_monospaced_changed.
12641 (init_gsettings): New function.
12642 (xsettings_initialize): Call init_gsettings.
12643 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
12644 to NULL.
12645
640c8776 12646 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
12647 GCONF_CFLAGS/LIBS.
12648
5386012d
MR
126492011-06-29 Martin Rudalics <rudalics@gmx.at>
12650
12651 * window.c (resize_root_window, grow_mini_window)
12652 (shrink_mini_window): Rename Qresize_root_window to
12653 Qwindow_resize_root_window and Qresize_root_window_vertically to
12654 Qwindow_resize_root_window_vertically.
12655
f13e0b08
PE
126562011-06-28 Paul Eggert <eggert@cs.ucla.edu>
12657
12658 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
12659
94515237
JB
126602011-06-27 Juanma Barranquero <lekktu@gmail.com>
12661
12662 * makefile.w32-in: Redesign dependencies so they reflect more
12663 clearly which files are directly included by each source file,
12664 and not through other includes.
12665
e43b6e43
MR
126662011-06-27 Martin Rudalics <rudalics@gmx.at>
12667
12668 * buffer.c (Qclone_number): Declare static and DEFSYM it.
12669 (sort_overlays, overlay_strings): When an overlay's clone number
12670 matches the window's clone number process the overlay even if
12671 the overlay's window property doesn't match the current window.
12672
d68443dc
MR
12673 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
12674 (Fwindow_hchild): Rename to Fwindow_left_child.
12675 (Fwindow_next): Rename to Fwindow_next_sibling.
12676 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
12677 (resize_window_check): Rename to window_resize_check.
12678 (resize_window_apply): Rename to window_resize_apply.
12679 (Fresize_window_apply): Rename to Fwindow_resize_apply.
12680 (Fdelete_other_windows_internal, resize_frame_windows)
12681 (Fsplit_window_internal, Fdelete_window_internal)
12682 (grow_mini_window, shrink_mini_window)
12683 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 12684
c7e73be5
JD
126852011-06-26 Jan Djärv <jan.h.d@swipnet.se>
12686
12687 * emacsgtkfixed.h: State that this is only used with Gtk+3.
12688 (emacs_fixed_set_min_size): Remove.
12689 (emacs_fixed_new): Take frame as argument.
12690
12691 * emacsgtkfixed.c: State that this is only used with Gtk+3.
12692 (_EmacsFixedPrivate): Remove minwidth/height.
12693 Add struct frame *f.
12694 (emacs_fixed_init): Initialize priv->f.
12695 (get_parent_class, emacs_fixed_set_min_size): Remove.
12696 (emacs_fixed_new): Set priv->f to argument.
12697 (emacs_fixed_get_preferred_width)
12698 (emacs_fixed_get_preferred_height): Use min_width/height from
12699 frames size_hint to set minimum and natural (Bug#8919).
12700 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
12701 and use min_width/height from frames size_hint to set
12702 min_width/height (Bug#8919).
12703
12704 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
12705 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
12706 Fix indentation.
c7e73be5 12707
cf99dcf8
EZ
127082011-06-26 Eli Zaretskii <eliz@gnu.org>
12709
12710 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
12711 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
12712 called at ZV.
12713
029529ac
CY
127142011-06-26 Chong Yidong <cyd@stupidchicken.com>
12715
12716 * process.c (wait_reading_process_output): Bypass select if
12717 waiting for a cell while ignoring keyboard input, and input is
12718 pending. Suggested by Jan Djärv (Bug#8869).
12719
7a7ef429
PE
127202011-06-25 Paul Eggert <eggert@cs.ucla.edu>
12721
12722 Use gnulib's dup2 module instead of rolling our own.
12723 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
12724
11fdef7d 127252011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
12726
12727 * dispnew.c (scrolling_window): Before scrolling, turn off a
12728 mouse-highlight in the window being scrolled.
12729
cd3520a4
JB
127302011-06-24 Juanma Barranquero <lekktu@gmail.com>
12731
12732 Move DEFSYM to lisp.h and use everywhere.
12733
12734 * character.h (DEFSYM): Move declaration...
12735 * lisp.h (DEFSYM): ...here.
12736
12737 * gnutls.c:
12738 * minibuf.c:
12739 * w32menu.c:
12740 * w32proc.c:
12741 * w32select.c: Don't include character.h.
12742
12743 * alloc.c (syms_of_alloc):
12744 * buffer.c (syms_of_buffer):
12745 * bytecode.c (syms_of_bytecode):
12746 * callint.c (syms_of_callint):
12747 * casefiddle.c (syms_of_casefiddle):
12748 * casetab.c (init_casetab_once):
12749 * category.c (init_category_once, syms_of_category):
12750 * ccl.c (syms_of_ccl):
12751 * cmds.c (syms_of_cmds):
12752 * composite.c (syms_of_composite):
12753 * dbusbind.c (syms_of_dbusbind):
12754 * dired.c (syms_of_dired):
12755 * dispnew.c (syms_of_display):
12756 * doc.c (syms_of_doc):
12757 * editfns.c (syms_of_editfns):
12758 * emacs.c (syms_of_emacs):
12759 * eval.c (syms_of_eval):
12760 * fileio.c (syms_of_fileio):
12761 * fns.c (syms_of_fns):
12762 * frame.c (syms_of_frame):
12763 * fringe.c (syms_of_fringe):
12764 * insdel.c (syms_of_insdel):
12765 * keymap.c (syms_of_keymap):
12766 * lread.c (init_obarray, syms_of_lread):
12767 * macros.c (syms_of_macros):
12768 * msdos.c (syms_of_msdos):
12769 * print.c (syms_of_print):
12770 * process.c (syms_of_process):
12771 * search.c (syms_of_search):
12772 * sound.c (syms_of_sound):
12773 * syntax.c (init_syntax_once, syms_of_syntax):
12774 * terminal.c (syms_of_terminal):
12775 * textprop.c (syms_of_textprop):
12776 * undo.c (syms_of_undo):
12777 * w32.c (globals_of_w32):
12778 * window.c (syms_of_window):
12779 * xdisp.c (syms_of_xdisp):
12780 * xfaces.c (syms_of_xfaces):
12781 * xfns.c (syms_of_xfns):
12782 * xmenu.c (syms_of_xmenu):
12783 * xsettings.c (syms_of_xsettings):
12784 * xterm.c (syms_of_xterm): Use DEFSYM.
12785
4228cf16
TZ
127862011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
12787
cd3520a4 12788 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 12789
7fcccf1e
PE
127902011-06-23 Paul Eggert <eggert@cs.ucla.edu>
12791
7efb4e0e
PE
12792 Integer and buffer overflow fixes (Bug#8873).
12793
ff5844ad
PE
12794 * print.c (printchar, strout): Check for string overflow.
12795 (PRINTPREPARE, printchar, strout):
12796 Don't set size unless allocation succeeds.
12797
90532f02
PE
12798 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
12799 for sizes. Check for string overflow more accurately.
12800 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
12801
6d84508d
PE
12802 * macros.c: Integer and buffer overflow fixes.
12803 * keyboard.h (struct keyboard.kbd_macro_bufsize):
12804 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
12805 Use ptrdiff_t, not int, for sizes.
12806 Don't increment bufsize until after realloc succeeds.
12807 Check for size-calculation overflow.
12808 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
12809
437b2cb4
PE
12810 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
12811
8b9ac8b4
PE
12812 * lread.c: Integer overflow fixes.
12813 (read_integer): Radix is now EMACS_INT, not int,
12814 to improve quality of diagnostics for out-of-range radices.
12815 Calculate buffer size correctly for out-of-range radices.
12816 (read1): Check for integer overflow in radices, and in
12817 read-circle numbers.
82cb60d3
PE
12818 (read_escape): Avoid int overflow.
12819 (Fload, openp, read_buffer_size, read1)
12820 (substitute_object_recurse, read_vector, read_list, map_obarray):
12821 Use ptrdiff_t, not int, for sizes.
12822 (read1): Use EMACS_INT, not int, for sizes.
20270765 12823 Check for size overflow.
8b9ac8b4 12824
7fcccf1e
PE
12825 * image.c (cache_image): Check for size arithmetic overflow.
12826
bfbbd7e7
PE
12827 * lread.c: Integer overflow issues.
12828 (saved_doc_string_size, saved_doc_string_length)
12829 (prev_saved_doc_string_size, prev_saved_doc_string_length):
12830 Now ptrdiff_t, not int.
12831 (read1): Don't assume doc string length fits in int. Check for
12832 out-of-range doc string lengths.
12833 (read_list): Don't assume file position fits in int.
39019e54 12834 (read_escape): Check for hex character overflow.
bfbbd7e7 12835
4e323265
LL
128362011-06-22 Leo Liu <sdl.web@gmail.com>
12837
12838 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
12839 Move to minibuffer.el.
12840
85fece3e
PE
128412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12842
20b84ce9 12843 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
12844 The following patches are for when GLYPH_DEBUG && !XASSERT.
12845 * dispextern.h (trace_redisplay_p, dump_glyph_string):
12846 * dispnew.c (flush_stdout):
12847 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
12848 Mark as externally visible.
12849 * dispnew.c (check_window_matrix_pointers): Now static.
12850 * dispnew.c (window_to_frame_vpos):
12851 * xfns.c (unwind_create_frame):
12852 * xterm.c (x_check_font): Remove unused local.
12853 * scroll.c (CHECK_BOUNDS):
12854 * xfaces.c (cache_fache): Rename local to avoid shadowing.
12855 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
12856 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
12857 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
12858 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
12859 Now static.
12860 (debug_method_add): Use va_list and vsprintf rather than relying
12861 on undefined behavior with wrong number of arguments.
12862 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
12863 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
12864 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
12865 since we're not interested in debugging glyphs with old libraries.
12866 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
12867 GCC 4.6.0's static checking.
12868
0766b489
PE
128692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12870
31fd4b32
PE
12871 Integer overflow and signedness fixes (Bug#8873).
12872 A few related buffer overrun fixes, too.
12873
b79e8648
PE
12874 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
12875
0766b489
PE
12876 * dispextern.h (struct face.stipple):
12877 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
12878 (x_bitmap_mask, x_allocate_bitmap_record)
12879 (x_create_bitmap_from_data, x_create_bitmap_from_file)
12880 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
12881 (x_create_bitmap_from_xpm_data):
12882 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
12883 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
12884 (.bitmaps_last):
12885 * xfaces.c (load_pixmap):
12886 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
12887 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
12888 (.bitmaps_last, struct x_output.icon_bitmap):
12889 Use ptrdiff_t, not int, for bitmap indexes.
12890 (x_allocate_bitmap_record): Check for size overflow.
12891 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
12892
b081724f
PE
12893 Use ptrdiff_t, not int, for overlay counts.
12894 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
12895 * editfns.c (overlays_around, get_pos_property):
12896 * textprop.c (get_char_property_and_overlay):
12897 * xdisp.c (next_overlay_change, note_mouse_highlight):
12898 * xfaces.c (face_at_buffer_position):
21514da7
PE
12899 * buffer.c (OVERLAY_COUNT_MAX): New macro.
12900 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
12901 (Fnext_overlay_change, Fprevious_overlay_change)
12902 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 12903 Use ptrdiff_t, not int, for sizes.
21514da7 12904 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 12905
3de73e5e
PE
12906 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
12907
2606c57b
PE
12908 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
12909 (x_session_initialize): Do not assume string length fits in int.
12910
aaafe47a
PE
12911 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
12912 This is unlikely, but can occur if DPI is outlandish.
12913
2674ddc8 12914 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
12915 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
12916
28154962
PE
12917 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
12918 * xrdb.c (magic_file_p, search_magic_path):
12919 Omit last arg SUFFIX; it was always 0. All callers changed.
12920 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
12921
7de51af5
PE
12922 * xfont.c (xfont_match): Avoid need for strlen.
12923
25ed6cc3
PE
12924 * xfns.c: Don't assume strlen fits in int.
12925 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
12926
4eab31dd
PE
12927 * xdisp.c (message_log_check_duplicate): Return intmax_t,
12928 not unsigned long, as we prefer signed integers. All callers changed.
12929 Detect integer overflow in repeat count.
12930 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 12931 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 12932
171e2a58
PE
12933 * termcap.c: Don't assume sizes fit in int and never overflow.
12934 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
12935 (gobble_line): Check for size-calculation overflow.
12936
ad39faca 12937 * minibuf.c (Fread_buffer):
6e5bb2dc 12938 * lread.c (intern, intern_c_string):
74ca2eb3
PE
12939 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
12940 Don't assume string length fits in int.
12941
52c61c22 12942 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
12943 * gtkutil.c (style_changed_cb): Avoid need for strlen.
12944
b5b8c9e5
PE
12945 * font.c: Don't assume string length fits in int.
12946 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
12947 Use ptrdiff_t, not int.
ccd6111c
PE
12948 (font_intern_prop): Don't assume string length fits in int.
12949 Don't assume integer property fits in fixnum.
12950 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 12951
882f0d81 12952 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 12953 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
12954 Reformulate so as not to need the command string.
12955 Invoke gzip -cd rather than gunzip, as it's more portable.
12956 (lock_info_type, lock_file_1, lock_file):
12957 Don't assume pid_t and time_t fit in unsigned long.
12958 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
12959 (current_lock_owner): Prefer signed type for sizes.
12960 Use memcpy, not strncpy, where memcpy is what is really wanted.
12961 Don't assume (via atoi) that time_t and pid_t fit in int.
12962 Check for time_t and/or pid_t out of range, e.g., via a network share.
12963 Don't alloca where an auto var works fine.
12964
93f4cf88
PE
12965 * fileio.c: Fix some integer overflow issues.
12966 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
12967 Don't assume string length fits in int.
12968 (directory_file_name): Don't assume string length fits in long.
12969 (make_temp_name): Don't assume pid fits in int, or that its print
12970 length is less than 20.
12971
f3e92b69
PE
12972 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
12973
1bfdaf10
PE
12974 * coding.c (make_subsidiaries): Don't assume string length fits in int.
12975
35016e9a
PE
12976 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
12977
3d1e65a1
PE
12978 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
12979 We prefer signed integers, even for size calculations.
12980
0b963a93
PE
12981 * emacs.c: Don't assume string length fits in 'int'.
12982 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
12983 (main): Don't invoke strlen when not needed.
12984
573f4b54
PE
12985 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
12986 (XD_DEBUG_MESSAGE): Don't waste a byte.
12987
989f33ba
PE
12988 * callproc.c (getenv_internal_1, getenv_internal)
12989 (Fgetenv_internal):
965d34eb
PE
12990 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
12991
e4d29b33
PE
12992 * lread.c (invalid_syntax): Omit length argument.
12993 All uses changed. This doesn't fix a bug, but it simplifies the
12994 code away from its former Hollerith-constant appearance, and it's
12995 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 12996 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 12997
eb49b136
PE
12998 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
12999 This didn't break anything, but it didn't help either.
13000 It's confusing to put a bogus integer in a place where the actual
13001 value does not matter.
9f62aeb1 13002 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 13003 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 13004
15375a22
PE
13005 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
13006 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
13007 implementation.
b61cc01c
PE
13008 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
13009 We prefer signed types, and the value cannot exceed the EMACS_INT
13010 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
13011 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
13012 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
13013 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 13014
53b2623d
PE
13015 * indent.c (sane_tab_width): New function.
13016 (current_column, scan_for_column, Findent_to, position_indentation)
13017 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 13018 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 13019
51cab52b 13020 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 13021
f2ed8a70
PE
13022 * lisp.h (lint_assume): New macro.
13023 * composite.c (composition_gstring_put_cache):
13024 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
13025
abe80cc6
PE
13026 * editfns.c, insdel.c:
13027 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 13028
b02c740e
PE
13029 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
13030
ebc96716
PE
13031 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
13032
b4e50fa0 13033 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 13034 Use much-faster test for byte-length change.
311d5d7c 13035 Don't assume string byte-length fits in 'int'.
a4cf38e4 13036 Check that character arg fits in 'int'.
85461888 13037 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 13038
c0c1ee9f
PE
13039 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
13040
a498d7f4
PE
13041 * fns.c (concat): Catch string overflow earlier.
13042 Do not rely on integer wraparound.
13043
51cab52b
PE
13044 * dispextern.h (struct it.overlay_strings_charpos)
13045 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
13046 * xdisp.c (forward_to_next_line_start)
13047 (back_to_previous_visible_line_start)
13048 (reseat_at_next_visible_line_start, next_element_from_buffer):
13049 Don't arbitrarily truncate the value of 'selective' to int.
13050
76031fad
PE
13051 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
13052
5eb55db9
PE
13053 * composite.c: Don't truncate sizes to 'int'.
13054 (composition_gstring_p, composition_reseat_it)
13055 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
13056 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
13057 not EMACS_UINT, for indexes.
5eb55db9 13058
0703a717
PE
13059 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
13060
d6202519
PE
13061 * buffer.c: Include <verify.h>.
13062 (struct sortvec.priority, struct sortstr.priority):
8961a454 13063 Now EMACS_INT, not int.
c20998a7 13064 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
13065 (struct sortstr.size, record_overlay_string)
13066 (struct sortstrlist.size, struct sortlist.used):
13067 Don't truncate size to int.
13068 (record_overlay_string): Check for size-calculation overflow.
d6202519 13069 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 13070
d5a19415
JM
130712011-06-22 Jim Meyering <meyering@redhat.com>
13072
029529ac 13073 Don't leak an XBM-image-sized buffer
d5a19415
JM
13074 * image.c (xbm_load): Free the image buffer after using it.
13075
a9041e6c
PE
130762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
13077
13078 Port to Sun C.
13079 * composite.c (find_automatic_composition): Omit needless 'return 0;'
13080 that Sun C diagnosed.
13081 * fns.c (secure_hash): Fix pointer signedness issue.
13082 * intervals.c (static_offset_intervals): New function.
13083 (offset_intervals): Use it.
13084
7f3f739f
LL
130852011-06-21 Leo Liu <sdl.web@gmail.com>
13086
13087 * deps.mk (fns.o):
13088 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
13089 sha512.h.
13090
13091 * fns.c (secure_hash): Rename from crypto_hash_function and change
13092 the first arg to accept symbols.
5b66d427 13093 (Fsecure_hash): New primitive.
7f3f739f
LL
13094 (syms_of_fns): New symbols.
13095
76147d94
DD
130962011-06-20 Deniz Dogan <deniz@dogan.se>
13097
13098 * process.c (Fset_process_buffer): Clarify return value in
13099 docstring.
13100
7d7d0045
CY
131012011-06-18 Chong Yidong <cyd@stupidchicken.com>
13102
13103 * dispnew.c (add_window_display_history): Use BVAR.
13104
13105 * xdisp.c (debug_method_add): Use BVAR.
13106 (check_window_end, dump_glyph_matrix, dump_glyph)
13107 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
13108
13109 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
13110 Likewise.
13111
13112 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
13113 check till after the cache is created in init_frame_faces.
13114
ff2bc410
SM
131152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
13116
13117 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
13118
28177add
PE
131192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
13120
dd3482fe
PE
13121 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
13122 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
13123 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
13124
393d71f3 13125 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
13126 * fileio.c (Finsert_file_contents):
13127 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
13128 Remove the old (too-loose) buffer overflow checks.
13129 They weren't needed, since make_gap checks for buffer overflow.
13130 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
13131 The old code merely checked for Emacs fixnum overflow, and relied
13132 on undefined (wraparound) behavior. The new code avoids undefined
13133 behavior, and also checks for ptrdiff_t and/or size_t overflow.
13134
2e6813b0 13135 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
13136 Tune. Don't use wider integers than needed. Don't use alloca.
13137 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 13138
599a9e4f
PE
13139 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
13140
99561444
PE
13141 * insdel.c, lisp.h (buffer_overflow): New function.
13142 (insert_from_buffer_1, replace_range, replace_range_2):
13143 * insdel.c (make_gap_larger):
13144 * editfns.c (Finsert_char):
13145 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
13146
28177add
PE
13147 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
13148
e69dafad
PE
131492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
13150
4baa020d 13151 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 13152
b1c46f02
PE
13153 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
13154 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
13155
e69dafad
PE
13156 * fileio.c: Don't assume EMACS_INT fits in off_t.
13157 (emacs_lseek): New static function.
13158 (Finsert_file_contents, Fwrite_region): Use it.
13159 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
13160
566684ea
PE
13161 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
13162
e6966cd6
PE
13163 * fns.c: Don't overflow int when computing a list length.
13164 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
13165 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
13166 truncation on 64-bit hosts. Check for QUIT every
13167 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
13168 faster and is responsive enough.
13169 (Flength): Report an error instead of overflowing an integer.
13170 (Fsafe_length): Return a float if the value is not representable
13171 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 13172 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 13173 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 13174
dd0b0efb
PE
13175 * alloc.c: Check that resized vectors' lengths fit in fixnums.
13176 (header_size, word_size): New constants.
13177 (allocate_vectorlike): Don't check size overflow here.
13178 (allocate_vector): Check it here instead, since this is the only
13179 caller of allocate_vectorlike that could cause overflow.
13180 Check that the new vector's length is representable as a fixnum.
13181
86fe5cfe
PE
13182 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
13183 The previous code was bogus. For example, next_almost_prime (32)
13184 returned 39, which is undesirable as it is a multiple of 3; and
13185 next_almost_prime (24) returned 25, which is a multiple of 5 so
13186 why was the code bothering to check for multiples of 7?
13187
80e88859
PE
13188 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
13189
4a2f0ad6
PE
13190 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
13191
f66c7cf8
PE
13192 Variadic C functions now count arguments with ptrdiff_t.
13193 This partly undoes my 2011-03-30 change, which replaced int with size_t.
13194 Back then I didn't know that the Emacs coding style prefers signed int.
13195 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
13196 were being counted with int, which may truncate counts on 64-bit
13197 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
13198 * lisp.h (struct Lisp_Subr.function.aMANY)
13199 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
13200 Arg counts are now ptrdiff_t, not size_t.
13201 All variadic functions and their callers changed accordingly.
13202 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
13203 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
13204 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
13205 * callint.c (Fcall_interactively): Check arg count for overflow,
13206 to avoid potential buffer overrun. Use signed char, not 'int',
13207 for 'varies' array, so that we needn't bother to check its size
13208 calculation for overflow.
13209 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
13210 * eval.c (apply_lambda):
13211 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
13212 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
13213 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
13214
a1759b76
PE
13215 * callint.c (Fcall_interactively): Don't use index var as event count.
13216
d96be9fc
PE
13217 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
13218 * mem-limits.h (SIZE): Remove; no longer used.
13219
a690a978 13220 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 13221
578c21e6
PE
13222 Remove unnecessary casts.
13223 * xterm.c (x_term_init):
13224 * xfns.c (x_set_border_pixel):
13225 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
13226 These aren't needed now that we assume ANSI C.
13227
96f53c6c
PE
13228 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
13229 It's more likely to cause problems (due to unsigned overflow)
13230 than to cure them.
13231
83c77d31
PE
13232 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
13233
ee2079f1
PE
13234 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
13235
6da65536
PE
13236 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
13237
7147c4a4
PE
13238 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
13239
193e32d9
PE
13240 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
13241
e5533da6
PE
13242 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
13243
9910e595
PE
13244 GLYPH_CODE_FACE returns EMACS_INT, not int.
13245 * dispextern.h (merge_faces):
13246 * xfaces.c (merge_faces):
01103c44
PE
13247 * xdisp.c (get_next_display_element, next_element_from_display_vector):
13248 Don't assume EMACS_INT fits in int.
9910e595 13249
2638320e
PE
13250 * character.h (CHAR_VALID_P): Remove unused parameter.
13251 * fontset.c, lisp.h, xdisp.c: All uses changed.
13252
045eb8d9
PE
13253 * editfns.c (Ftranslate_region_internal): Omit redundant test.
13254
c1f134b5
PE
13255 * fns.c (concat): Minor tuning based on overflow analysis.
13256 This doesn't fix any bugs. Use int to hold character, instead
13257 of constantly refetching from Emacs object. Use XFASTINT, not
13258 XINT, for value known to be a character. Don't bother comparing
13259 a single byte to 0400, as it's always less.
13260
395fcb93 13261 * floatfns.c (Fexpt):
327eeec8
PE
13262 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
13263
abbd3d23
PE
13264 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
13265 for characters.
13266
684a03ef
PE
13267 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
13268
0fed43f3
PE
13269 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
13270 Without this fix, on a 64-bit host (aset S 0 4294967386) would
13271 incorrectly succeed when S was a string, because 4294967386 was
13272 truncated before it was used.
13273
8fd02eb7
PE
13274 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
13275 Otherwise, an out-of-range integer could cause undefined behavior
13276 on a 64-bit host.
13277
f8c86b69
PE
13278 * composite.c: Use int, not EMACS_INT, for characters.
13279 (fill_gstring_body, composition_compute_stop_pos): Use int, not
13280 EMACS_INT, for values that are known to be in character range.
13281 This doesn't fix any bugs but is the usual style inside Emacs and
13282 may generate better code on 32-bit machines.
13283
34206dd2
PE
13284 Make sure a 64-bit char is never passed to ENCODE_CHAR.
13285 This is for reasons similar to the recent CHAR_STRING fix.
13286 * charset.c (Fencode_char): Check that character arg is actually
13287 a character. Pass an int to ENCODE_CHAR.
13288 * charset.h (ENCODE_CHAR): Verify that the character argument is no
13289 wider than 'int', as a compile-time check to prevent future regressions
13290 in this area.
13291
c5958d4c 13292 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
13293
13294 Make sure a 64-bit char is never passed to CHAR_STRING.
13295 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
13296 by silently ignoring the top 32 bits, allowing some values
13297 that were far too large to be valid characters.
13298 * character.h: Include <verify.h>.
13299 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
13300 arguments are no wider than unsigned, as a compile-time check
13301 to prevent future regressions in this area.
13302 * data.c (Faset):
01103c44 13303 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
13304 (Fsubst_char_in_region):
13305 * fns.c (concat):
13306 * xdisp.c (decode_mode_spec_coding):
13307 Adjust to CHAR_STRING's new requirement.
13308 * editfns.c (Finsert_char, Fsubst_char_in_region):
13309 * fns.c (concat): Check that character args are actually
13310 characters. Without this test, these functions did the wrong
13311 thing with wildly out-of-range values on 64-bit hosts.
13312
d37ca623
PE
13313 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
13314 These casts should not be needed on 32-bit hosts, either.
13315 * keyboard.c (read_char):
13316 * lread.c (Fload): Remove casts to unsigned.
13317
ea204efb
PE
13318 * lisp.h (UNSIGNED_CMP): New macro.
13319 This fixes comparison bugs on 64-bit hosts.
13320 (ASCII_CHAR_P): Use it.
13321 * casefiddle.c (casify_object):
01103c44 13322 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
13323 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
13324 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
13325 * dispextern.h (FACE_FROM_ID):
13326 * keyboard.c (read_char): Use UNSIGNED_CMP.
13327
41cb286c
PE
13328 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
13329 not to EMACS_INT, to avoid GCC warning.
13330
4a1b9832
PE
13331 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
13332
55daad71
PE
13333 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
13334 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
13335 isn't needed on 32-bit machines.
8f95c75c 13336
01103c44
PE
13337 * buffer.c (Fgenerate_new_buffer_name):
13338 Use EMACS_INT for count, not int.
0ceccced 13339 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
13340
13341 * data.c (Qcompiled_function): Now static.
13342
c6f072e7
PE
13343 * window.c (window_body_lines): Now static.
13344
20ce5912
PE
13345 * image.c (gif_load): Rename local to avoid shadowing.
13346
9c4c5f81
PE
13347 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
13348 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
13349 * alloc.c (make_save_value): Integer argument is now of type
13350 ptrdiff_t, not int.
13351 (mark_object): Use ptrdiff_t, not int.
13352 * lisp.h (pD): New macro.
13353 * print.c (print_object): Use it.
13354
c0c5c8ae
PE
13355 * alloc.c: Use EMACS_INT, not int, to count objects.
13356 (total_conses, total_markers, total_symbols, total_vector_size)
13357 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
13358 (total_free_floats, total_floats, total_free_intervals)
13359 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
13360 Now EMACS_INT, not int. All uses changed.
13361 (Fgarbage_collect): Compute overall total using a double, so that
13362 integer overflow is less likely to be a problem. Check for overflow
13363 when converting back to an integer.
5a25e253
PE
13364 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
13365 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
13366 These were 'int' variables that could overflow on 64-bit hosts;
13367 they were never used, so remove them instead of repairing them.
211a0b2a 13368 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
13369 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
13370 Previously, this ceilinged at INT_MAX, but that doesn't work on
13371 64-bit machines.
e46bb31a 13372 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 13373
c78baabf 13374 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 13375 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
13376 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
13377 when a (possibly-narrower) signed value would do just as well.
13378 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 13379
c9d624c6
PE
13380 * alloc.c: Catch some string size overflows that we were missing.
13381 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
13382 for convenience in STRING_BYTES_MAX.
13383 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
13384 The definition here is exact; the one in lisp.h was approximate.
13385 (allocate_string_data): Check for string overflow. This catches
13386 some instances we weren't catching before. Also, it catches
13387 size_t overflow on (unusual) hosts where SIZE_MAX <= min
13388 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
13389 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 13390
c9d624c6
PE
13391 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
13392 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 13393 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 13394
353032ce
PE
13395 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
13396
2bccce07
PE
13397 * alloc.c (Fmake_string): Check for out-of-range init.
13398
0ac30604
SM
133992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
13400
13401 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
13402
c195f2de
JD
134032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
13404
13405 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
13406 xg_get_default_scrollbar_width.
13407
13408 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
13409 (int_gtk_range_get_value): Move to the scroll bar part of the file.
13410 (style_changed_cb): Call update_theme_scrollbar_width and call
13411 x_set_scroll_bar_default_width and xg_frame_set_char_size for
13412 all frames (Bug#8505).
13413 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
13414 Call gtk_window_set_resizable if HAVE_GTK3.
13415 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
13416 and height if HAVE_GTK3 (Bug#8505).
13417 (scroll_bar_width_for_theme): New variable.
13418 (update_theme_scrollbar_width): New function.
13419 (xg_get_default_scrollbar_width): Move code to
13420 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
13421 (xg_initialize): Call update_theme_scrollbar_width.
13422
13423 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
13424
13425 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
13426
e10ac9f1
MR
134272011-06-12 Martin Rudalics <rudalics@gmx.at>
13428
13429 * frame.c (make_frame): Call other_buffer_safely instead of
13430 other_buffer.
13431
13432 * window.c (temp_output_buffer_show): Call display_buffer with
13433 second argument Vtemp_buffer_show_specifiers and reset latter
13434 immediately after the call.
13435 (Vtemp_buffer_show_specifiers): New variable.
13436 (auto_window_vscroll_p, next_screen_context_lines)
13437 (Vscroll_preserve_screen_position): Remove leading asterisks from
13438 doc-strings.
13439
2d3c217e 134402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 13441
7b7f97e8 13442 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
13443 * buffer.c (Qclone_number): Remove for now, as it's unused.
13444 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
13445 (record_buffer): Remove unused local.
13446 * frame.c (other_visible_frames, frame_buffer_list): Now static.
13447 (set_frame_buffer_list): Remove; unused.
13448 * frame.h (other_visible_frames): Remove decl.
13449 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
13450 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
13451 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
13452 if HAVE_GPM.
13453 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
13454 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
13455 Define only if HAVE_GPM.
13456 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
13457 (update_hints_inhibit): Remove; never set. All uses removed.
13458 * widgetprv.h (emacsFrameClassRec): Remove decl.
13459 * window.c (delete_deletable_window): Now returns void, since it
13460 wasn't returning anything.
13461 (compare_window_configurations): Remove unused locals.
13462 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
13463 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
13464 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
13465 the same widths as pointers. This follows up on the 2011-05-06 patch.
13466 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
13467 * xterm.h: Likewise.
13468 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
13469
1384b89e
JB
134702011-06-12 Juanma Barranquero <lekktu@gmail.com>
13471
13472 * makefile.w32-in: Update dependencies.
13473 (LISP_H): Add lib/intprops.h.
13474
1100a63c
CY
134752011-06-11 Chong Yidong <cyd@stupidchicken.com>
13476
13477 * image.c (gif_load): Add animation frame delay to the metadata.
13478 (syms_of_image): Use DEFSYM. New symbol `delay'.
13479
6198ccd0
MR
134802011-06-11 Martin Rudalics <rudalics@gmx.at>
13481
13482 * window.c (delete_deletable_window): Re-add.
13483 (Fset_window_configuration): Rewrite to handle dead buffers and
13484 consequently deletable windows.
13485 (window_tree, Fwindow_tree): Remove. Supply functionality in
13486 window.el.
13487 (compare_window_configurations): Simplify code.
13488
b6e3633c
AS
134892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
13490
1ab0dee5
AS
13491 * image.c (imagemagick_load_image): Fix type mismatch.
13492 (Fimagemagick_types): Likewise.
13493
b6e3633c
AS
13494 * window.h (replace_buffer_in_windows): Declare.
13495
9397e56f
MR
134962011-06-11 Martin Rudalics <rudalics@gmx.at>
13497
13498 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
13499 Qclone_number. Remove external declaration of Qdelete_window.
13500 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
13501 code.
640c8776
SM
13502 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
13503 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
13504 (Fother_buffer): Rewrite doc-string. Major rewrite for new
13505 buffer list implementation.
13506 (other_buffer_safely): New function.
13507 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
13508 calls to replace_buffer_in_windows and
13509 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
13510 if allowed.
13511 (record_buffer): Inhibit quitting and rewrite using quittable
13512 functions. Run Qbuffer_list_update_hook if allowed.
13513 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
13514 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
13515 Move switch-to-buffer to window.el.
9397e56f
MR
13516 (bury-buffer): Move to window.el.
13517 (Vbuffer_list_update_hook): New variable.
13518
13519 * lisp.h (other_buffer_safely): Add prototype in buffer.c
13520 section.
13521
13522 * window.h (resize_frame_windows): Move up in code.
13523 (Fwindow_frame): Remove EXFUN.
13524 (replace_buffer_in_all_windows): Remove prototype.
13525 (replace_buffer_in_windows_safely): Add prototype.
13526
13527 * window.c: Declare Qdelete_window static again. Move down
13528 declaration of select_count.
13529 (Fnext_window, Fprevious_window): Rewrite doc-strings.
13530 (Fother_window): Move to window.el.
13531 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
13532 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
13533 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
13534 window.el.
13535 (replace_buffer_in_windows): Implement by calling
13536 Qreplace_buffer_in_windows.
13537 (replace_buffer_in_all_windows): Remove with some functionality
13538 moved into replace_buffer_in_windows_safely.
13539 (replace_buffer_in_windows_safely): New function.
13540 (select_window_norecord, select_frame_norecord): Move in front
13541 of run_window_configuration_change_hook. Remove now obsolete
13542 declarations.
640c8776
SM
13543 (Fset_window_buffer): Rewrite doc-string.
13544 Call Qrecord_window_buffer.
9397e56f
MR
13545 (keys_of_window): Move binding for other-window to window.el.
13546
b50691aa
CY
135472011-06-11 Chong Yidong <cyd@stupidchicken.com>
13548
13549 * dispextern.h (struct image): Replace data member, whose int_val
13550 and ptr_val fields were not used by anything, with a single
13551 lisp_val object.
13552
13553 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
13554 (gif_clear_image, gif_load, imagemagick_load_image)
13555 (gs_clear_image, gs_load): Callers changed.
13556
3f754b86
PE
135572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
13558
cca69397
PE
13559 * buffer.h: Include <time.h>, for time_t.
13560 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
13561
109e28d0
PE
13562 Fix minor problems found by static checking.
13563
60737f02
PE
13564 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
13565
4b66faf3
PE
13566 Make identifiers static if they are not used in other modules.
13567 * data.c (Qcompiled_function, Qframe, Qvector):
13568 * image.c (QimageMagick, Qsvg):
13569 * minibuf.c (Qmetadata):
13570 * window.c (resize_window_check, resize_root_window): Now static.
13571 * window.h (resize_window_check, resize_root_window): Remove decls.
13572
109e28d0
PE
13573 * window.c (window_deletion_count, delete_deletable_window):
13574 Remove; unused.
46a4ce9e
PE
13575 (window_body_lines): Now static.
13576 (Fdelete_other_windows_internal): Mark vars as initialized.
13577 Make sure 'resize_failed' is initialized.
13578 (run_window_configuration_change_hook): Rename local to avoid shadowing.
13579 (resize_window_apply): Remove unused local.
13580 * window.h (delete_deletable_window): Remove decl.
13581
109e28d0 13582 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
13583 (imagemagick_load_image): Fix pointer signedness problem by changing
13584 last arg from unsigned char * to char *. All uses changed.
13585 Also, fix a local for similar reasons.
13586 Remove unused locals. Remove locals to avoid shadowing.
13587 (fn_rsvg_handle_free): Remove; unused.
13588 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 13589 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 13590
3f754b86
PE
13591 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
13592
2547adb1
CY
135932011-06-10 Chong Yidong <cyd@stupidchicken.com>
13594
13595 * image.c (gif_load): Fix omitted cast error introduced by
13596 2011-06-06 change.
13597
2c8e37d4
MR
135982011-06-10 Martin Rudalics <rudalics@gmx.at>
13599
13600 * window.h (resize_proportionally, orig_total_lines)
13601 (orig_top_line): Remove from window structure.
13602 (set_window_height, set_window_width, change_window_heights)
13603 (Fdelete_window): Remove prototypes.
13604 (resize_frame_windows): Remove duplicate declaration.
13605
440a42e3
EZ
136062011-06-10 Eli Zaretskii <eliz@gnu.org>
13607
13608 * window.h (resize_frame_windows, resize_window_check)
13609 (delete_deletable_window, resize_root_window)
13610 (resize_frame_windows): Declare prototypes.
13611
13612 * window.c (resize_window_apply): Make definition be "static" to
13613 match the prototype.
13614
562dd5e9
MR
136152011-06-10 Martin Rudalics <rudalics@gmx.at>
13616
13617 * window.c: Remove declarations of Qwindow_size_fixed,
13618 window_min_size_1, window_min_size_2, window_min_size,
13619 size_window, window_fixed_size_p, enlarge_window, delete_window.
13620 Remove static from declaration of Qdelete_window, it's
13621 temporarily needed by Fbury_buffer.
13622 (replace_window): Don't assign orig_top_line and
13623 orig_total_lines.
13624 (Fdelete_window, delete_window): Remove. Window deletion is
13625 handled by window.el.
640c8776
SM
13626 (window_loop): Remove DELETE_OTHER_WINDOWS case.
13627 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
13628 (Fdelete_other_windows): Remove. Deleting other windows is
13629 handled by window.el.
13630 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
13631 handled in window.el.
13632 (window_min_size_2, window_min_size_1, window_min_size): Remove.
13633 Window minimum sizes are handled in window.el.
13634 (shrink_windows, size_window, set_window_height)
13635 (set_window_width, change_window_heights, window_height)
13636 (window_width, CURBEG, CURSIZE, enlarge_window)
13637 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
13638 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
13639 handled in window.el.
13640 (make_dummy_parent): Rename to make_parent_window and give it a
13641 second argument horflag.
13642 (make_window): Don't set resize_proportionally any more.
13643 (Fsplit_window): Remove. Windows are split in window.el.
13644 (save_restore_action, save_restore_orig_size)
13645 (shrink_window_lowest_first, save_restore_orig_size): Remove.
13646 Resize mini windows in window.el.
13647 (grow_mini_window, shrink_mini_window): Implement by calling
13648 Qresize_root_window_vertically, resize_window_check and
13649 resize_window_apply.
640c8776
SM
13650 (saved_window, Fset_window_configuration, save_window_save):
13651 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
13652 resize_proportionally.
13653 (window_min_height, window_min_width): Move to window.el.
13654 (keys_of_window): Move bindings for delete-other-windows,
13655 split-window, delete-window and enlarge-window to window.el.
13656
13657 * buffer.c: Temporarily extern Qdelete_window.
13658 (Fbury_buffer): Temporarily call Qdelete_window instead of
13659 Fdelete_window (Fbury_buffer will move to window.el soon).
13660
13661 * frame.c (set_menu_bar_lines_1): Remove code handling
13662 orig_top_line and orig_total_lines.
13663
13664 * dispnew.c (adjust_frame_glyphs_initially): Don't use
13665 set_window_height but set heights directly.
13666 (change_frame_size_1): Use resize_frame_windows.
13667
13668 * xdisp.c (init_xdisp): Don't use set_window_height but set
13669 heights directly.
13670
640c8776
SM
13671 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
13672 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
13673 run_window_configuration_change_hook.
13674
13675 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
13676 instead of change_window_heights and run
13677 run_window_configuration_change_hook.
13678
1a13852e
MR
136792011-06-09 Martin Rudalics <rudalics@gmx.at>
13680
13681 * window.c (replace_window): Rename second argument REPLACEMENT to
13682 NEW. New third argument SETFLAG. Rewrite.
13683 (delete_window, make_dummy_parent): Call replace_window with
13684 third argument 1.
13685 (window_list_1): Move down in code.
13686 (run_window_configuration_change_hook): Move set_buffer part
13687 before select_frame_norecord part in order to unwind correctly.
13688 Rename count1 to count.
13689 (recombine_windows, delete_deletable_window, resize_root_window)
13690 (Fdelete_other_windows_internal)
13691 (Frun_window_configuration_change_hook, make_parent_window)
13692 (resize_window_check, resize_window_apply, Fresize_window_apply)
13693 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
13694 (Fdelete_window_internal, Fresize_mini_window_internal):
13695 New functions.
1a13852e
MR
13696 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
13697
f3d1777e
MR
136982011-06-08 Martin Rudalics <rudalics@gmx.at>
13699
496e208e
MR
13700 * window.h (window): Add some new members to window structure -
13701 normal_lines, normal_cols, new_total, new_normal, clone_number,
13702 splits, nest, prev_buffers, next_buffers.
13703 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 13704 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 13705
f3d1777e
MR
13706 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
13707 Remove.
496e208e
MR
13708 (make_dummy_parent): Set new members of windows structure.
13709 (make_window): Move down in code. Handle new members of window
13710 structure.
13711 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
13712 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
13713 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
13714 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
13715 (Fset_window_next_buffers, Fset_window_clone_number):
13716 New functions.
496e208e
MR
13717 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
13718 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
13719 Doc-string fixes.
13720 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
13721 Argument WINDOW can be now internal window too.
13722 (Fwindow_use_time): Move up in code.
13723 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
13724 Rewrite doc-string.
13725 (Fset_window_configuration, saved_window)
13726 (Fcurrent_window_configuration, save_window_save): Handle new
13727 members of window structure.
b9e809c2
MR
13728 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
13729 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
13730 (syms_of_window): New Lisp objects Qrecord_window_buffer,
13731 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
13732 Qget_mru_window, Qresize_root_window,
13733 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
13734 Qauto_buffer_name; staticpro them.
f3d1777e 13735
abde8f8c
MR
137362011-06-07 Martin Rudalics <rudalics@gmx.at>
13737
13738 * window.c (Fwindow_total_size, Fwindow_left_column)
13739 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
13740 (Fwindow_list_1): New functions.
13741 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
13742 (Fwindow_width, Fscroll_left, Fscroll_right):
13743 Use window_body_cols instead of window_box_text_cols.
13744 (delete_window, Fset_window_configuration):
13745 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
13746 (delete_all_subwindows): Take a window as argument and not a
13747 structure. Rewrite.
190b47e6
MR
13748 (window_loop): Remove handling of GET_LRU_WINDOW and
13749 GET_LARGEST_WINDOW.
13750 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
13751
13752 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
13753 window_box_text_cols. delete_all_subwindows now takes a
13754 Lisp_Object as argument.
abde8f8c 13755
640c8776
SM
13756 * indent.c (compute_motion, Fcompute_motion):
13757 Use window_body_cols instead of window_box_text_cols.
abde8f8c 13758
fa8a67e6
MR
13759 * frame.c (delete_frame): Call delete_all_subwindows with root
13760 window as argument.
13761
a54e3482
DC
137622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
13763
13764 * fns.c (Fputhash): Document return value.
13765
60002bf5
CY
137662011-06-06 Chong Yidong <cyd@stupidchicken.com>
13767
13768 * image.c (gif_load): Implement gif89a spec "no disposal" method.
13769
0c671da6 137702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 13771
b862a52a 13772 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 13773
be44ca6c
PE
13774 Check for overflow when converting integer to cons and back.
13775 * charset.c (Fdefine_charset_internal, Fdecode_char):
13776 Use cons_to_unsigned to catch overflow.
13777 (Fencode_char): Use INTEGER_TO_CONS.
13778 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
13779 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
13780 * data.c (long_to_cons, cons_to_long): Remove.
13781 (cons_to_unsigned, cons_to_signed): New functions.
13782 These signal an error for invalid or out-of-range values.
13783 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
13784 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
13785 * font.c (Ffont_variation_glyphs):
13786 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
13787 * lisp.h: Include <intprops.h>.
13788 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
13789 (cons_to_signed, cons_to_unsigned): New decls.
13790 (long_to_cons, cons_to_long): Remove decls.
13791 * undo.c (record_first_change): Use INTEGER_TO_CONS.
13792 (Fprimitive_undo): Use CONS_TO_INTEGER.
13793 * xfns.c (Fx_window_property): Likewise.
13794 * xselect.c: Include <limits.h>.
13795 (x_own_selection, selection_data_to_lisp_data):
13796 Use INTEGER_TO_CONS.
13797 (x_handle_selection_request, x_handle_selection_clear)
13798 (x_get_foreign_selection, Fx_disown_selection_internal)
13799 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
13800 (lisp_data_to_selection_data): Use cons_to_unsigned.
13801 (x_fill_property_data): Use cons_to_signed.
13802 Report values out of range.
13803
d1f3d2af
PE
13804 Check for buffer and string overflow more precisely.
13805 * buffer.h (BUF_BYTES_MAX): New macro.
13806 * lisp.h (STRING_BYTES_MAX): New macro.
13807 * alloc.c (Fmake_string):
13808 * character.c (string_escape_byte8):
13809 * coding.c (coding_alloc_by_realloc):
13810 * doprnt.c (doprnt):
13811 * editfns.c (Fformat):
13812 * eval.c (verror):
13813 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
13814 since they may not be the same number.
13815 * editfns.c (Finsert_char):
13816 * fileio.c (Finsert_file_contents):
13817 Likewise for BUF_BYTES_MAX.
13818
dd52fcea
PE
13819 * image.c: Use ptrdiff_t, not int, for sizes.
13820 (slurp_file): Switch from int to ptrdiff_t.
13821 All uses changed.
13822 (slurp_file): Check that file size fits in both size_t (for
13823 malloc) and ptrdiff_t (for sanity and safety).
13824
7f9bbdbb
PE
13825 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
13826 if b->modtime has its maximal value.
13827
dfe18f82
PE
13828 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
13829
84acfcf0
PE
13830 Don't assume time_t can fit into int.
13831 * buffer.h (struct buffer.modtime): Now time_t, not int.
13832 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
13833 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
13834
ccd9a01a
PE
13835 Minor fixes for signed vs unsigned integers.
13836 * character.h (MAYBE_UNIFY_CHAR):
13837 * charset.c (maybe_unify_char):
13838 * keyboard.c (read_char, reorder_modifiers):
13839 XINT -> XFASTINT, since the integer must be nonnegative.
13840 * ftfont.c (ftfont_spec_pattern):
13841 * keymap.c (access_keymap, silly_event_symbol_error):
13842 XUINT -> XFASTINT, since the integer must be nonnegative.
13843 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
13844 since it makes no difference and we prefer signed.
13845 * keyboard.c (record_char): Use XUINT when all the neighbors do.
13846 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
13847 nonnegative.
13848
d6d100dd
SM
138492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
13850
13851 * window.h (Fwindow_frame): Declare.
13852
2b6148e4
PE
138532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13854
13855 * alloc.c: Simplify handling of large-request failures (Bug#8800).
13856 (SPARE_MEMORY): Always define.
13857 (LARGE_REQUEST): Remove.
13858 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
13859
f230ecc9
MR
138602011-06-06 Martin Rudalics <rudalics@gmx.at>
13861
727e958e
MR
13862 * lisp.h: Move EXFUNS for Fframe_root_window,
13863 Fframe_first_window and Fset_frame_selected_window to window.h.
13864
13865 * window.h: Move EXFUNS for Fframe_root_window,
13866 Fframe_first_window and Fset_frame_selected_window here from
13867 lisp.h.
13868
13869 * frame.c (Fwindow_frame, Fframe_first_window)
13870 (Fframe_root_window, Fframe_selected_window)
13871 (Fset_frame_selected_window): Move to window.c.
13872 (Factive_minibuffer_window): Move to minibuf.c.
13873 (Fother_visible_frames_p): New function.
13874
13875 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
13876
f230ecc9
MR
13877 * window.c (decode_window, decode_any_window): Move up in code.
13878 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
13879 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
13880 (Fwindow_buffer): Move up and rewrite doc-string.
13881 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
13882 (Fwindow_prev): New functions.
727e958e
MR
13883 (Fwindow_frame): Move here from frame.c. Accept any window as
13884 argument.
13885 (Fframe_root_window, Fframe_first_window)
13886 (Fframe_selected_window): Move here from frame.c. Accept frame
13887 or arbitrary window as argument. Update doc-strings.
13888 (Fminibuffer_window): Move up in code.
13889 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
13890 (Fset_frame_selected_window): Move here from frame.c.
13891 Marginal rewrite.
727e958e
MR
13892 (Fselected_window, select_window, Fselect_window): Move up in
13893 code. Minor doc-string fixes.
f230ecc9 13894
4d09bcf6
PE
138952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13896
13897 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
13898 Do not assume that spare memory exists; that assumption is valid
13899 only if SYSTEM_MALLOC.
13900 (LARGE_REQUEST): New macro, so that the issue of large requests
13901 is separated from the issue of spare memory.
13902
810928a2
AS
139032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
13904
172418ad
AS
13905 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
13906 format. (Bug#8806)
13907
43f862f7
AS
13908 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
13909
810928a2
AS
13910 * xfns.c (x_set_scroll_bar_default_width): Move declarations
13911 before statements.
13912
a059fe24
JD
139132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
13914
13915 * gtkutil.c (xg_get_default_scrollbar_width): New function.
13916
13917 * gtkutil.h: Declare xg_get_default_scrollbar_width.
13918
13919 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
13920 min width by calling x_set_scroll_bar_default_width (Bug#8505).
13921
989bf368
JB
139222011-06-05 Juanma Barranquero <lekktu@gmail.com>
13923
13924 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
13925
4b80f674
CY
139262011-06-04 Chong Yidong <cyd@stupidchicken.com>
13927
13928 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
13929 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
13930 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
13931 New error handlers.
4b80f674
CY
13932 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
13933 Obey Vx_select_enable_clipboard_manager. Catch errors in
13934 x_clipboard_manager_save (Bug#8779).
13935 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 13936 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 13937
99a33b77 139382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
13939
13940 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
13941
99a33b77 139422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
13943
13944 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
13945 in the current matrix if keep_current_p is non-zero.
13946
8264569d
EZ
139472011-06-04 Eli Zaretskii <eliz@gnu.org>
13948
13949 * bidi.c (bidi_level_of_next_char): Fix last change.
13950
57f97249
EZ
139512011-06-03 Eli Zaretskii <eliz@gnu.org>
13952
fec2107c 13953 Support bidi reordering of text covered by display properties.
57f97249 13954
fec2107c
EZ
13955 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
13956 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
13957 (bidi_cache_search, bidi_cache_iterator_state)
13958 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
13959 (bidi_level_of_next_char, bidi_move_to_visually_next):
13960 Support character positions inside a run of characters covered by a
fec2107c
EZ
13961 display string.
13962 (bidi_paragraph_init, bidi_resolve_explicit_1)
13963 (bidi_level_of_next_char): Call bidi_fetch_char and
13964 bidi_fetch_char_advance instead of FETCH_CHAR and
13965 FETCH_CHAR_ADVANCE.
13966 (bidi_init_it): Initialize new members.
13967 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
13968 definitions.
13969 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
13970 instead of using explicit *_CHAR codes.
d6d100dd
SM
13971 (bidi_resolve_explicit, bidi_resolve_weak):
13972 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
13973 bidirectional text is supported only in multibyte buffers.
13974 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
13975 it to initialize the frame_window_p member of struct bidi_it.
13976 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
13977 (bidi_resolve_explicit, bidi_resolve_weak)
13978 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
13979 bidi_it->nchars is non-positive.
13980 (bidi_level_of_next_char): Don't try to lookup the cache for the
13981 next/previous character if nothing is cached there yet, or if we
13982 were just reseat()'ed to a new position.
c40e2fb2 13983
0e14fe90
EZ
13984 * xdisp.c (set_cursor_from_row): Set start and stop points
13985 according to the row's direction when priming the loop that looks
13986 for the glyph on which to display cursor.
13987 (single_display_spec_intangible_p): Function deleted.
13988 (display_prop_intangible_p): Reimplement to call
13989 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
13990 Accept 3 additional arguments needed by handle_display_spec.
13991 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
13992 values: lists, `(when COND...)' forms, etc.
13993 (single_display_spec_string_p): Support property values that are
13994 lists with the argument STRING its top-level element.
13995 (display_prop_string_p): Fix the condition for processing a
13996 property that is a list to be consistent with handle_display_spec.
fec2107c 13997 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
13998 last portion of handle_display_prop.
13999 (compute_display_string_pos): Accept additional argument
14000 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
14001 value of a `display' property is a "replacing spec".
14002 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
14003 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
14004 the display property, but just return a value indicating whether
14005 the display property will replace the characters it covers.
14006 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
14007 frame_window_p members of struct bidi_it.
d6d100dd
SM
14008 (compute_display_string_pos, compute_display_string_end):
14009 New functions.
fec2107c
EZ
14010 (push_it): Accept second argument POSITION, where pop_it should
14011 jump to continue iteration.
14012 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 14013
fec2107c
EZ
14014 * keyboard.c (adjust_point_for_property): Adjust the call to
14015 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
14016
14017 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
14018 (bidi_init_it): Update prototypes.
14019 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
14020 (compute_display_string_pos, compute_display_string_end):
14021 Declare prototypes.
fec2107c
EZ
14022 (struct bidi_it): New members nchars and disp_pos. ch_len is now
14023 EMACS_INT.
fc6f18ce 14024
40087514 140252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 14026
57f53182
PE
14027 Malloc failure behavior now depends on size of allocation.
14028 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
14029 * lisp.h: Change signatures accordingly.
14030 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
14031 All callers changed. (Bug#8762)
14032
14033 * gnutls.c: Use Emacs's memory allocators.
14034 Without this change, the gnutls library would invoke malloc etc.
14035 directly, which causes problems on non-SYNC_INPUT hosts, and which
14036 runs afoul of improving memory_full behavior. (Bug#8761)
14037 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
14038 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
14039 xfree instead of the default malloc, realloc, free.
14040 (Fgnutls_boot): No need to check for memory allocation failure,
14041 since xmalloc does that for us.
14042
ac32cd99 14043 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
14044 * category.c (hash_get_category_set):
14045 * ccl.c (ccl_driver):
14046 * charset.c (Fdefine_charset_internal):
14047 * charset.h (struct charset.hash_index):
14048 * composite.c (get_composition_id, gstring_lookup_cache)
14049 (composition_gstring_put_cache):
14050 * composite.h (struct composition.hash_index):
14051 * dispextern.h (struct image.hash):
14052 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
14053 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
14054 (hashfn_equal, hashfn_user_defined, make_hash_table)
14055 (maybe_resize_hash_table, hash_lookup, hash_put)
14056 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
14057 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
14058 (Fsxhash, Fgethash, Fputhash, Fmaphash):
14059 * image.c (make_image, search_image_cache, lookup_image)
14060 (xpm_put_color_table_h):
14061 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 14062 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 14063 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 14064 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
14065 * alloc.c (allocate_vectorlike):
14066 Check for overflow in vector size calculations.
14067 * ccl.c (ccl_driver):
14068 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
14069 * fns.c, image.c: Remove unnecessary static decls that would otherwise
14070 need to be updated by these changes.
40087514
PE
14071 * fns.c (make_hash_table, maybe_resize_hash_table):
14072 Check for integer overflow with large hash tables.
0de4bb68
PE
14073 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
14074 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
14075 (SXHASH_REDUCE): New macro.
14076 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
14077 Use it instead of discarding useful hash info with large hash values.
14078 (sxhash_float): New function.
14079 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
14080 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
14081 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
14082 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
14083 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
14084 Adjust signatures to match updated version of code.
14085 (consing_since_gc): Now EMACS_INT, since a single hash table can
14086 use more than INT_MAX bytes.
14087
698d32e2
DN
140882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
14089
14090 Make it possible to build with GCC-4.6+ -O2 -flto.
14091
14092 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
14093
fd6fa53f
SM
140942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
14095
14096 * minibuf.c (get_minibuffer, read_minibuf_unwind):
14097 Call minibuffer-inactive-mode.
14098
864db017
JB
140992011-05-31 Juanma Barranquero <lekktu@gmail.com>
14100
14101 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
14102 Update dependencies.
14103
2ad0baf4
DN
141042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14105
14106 * data.c (init_data): Remove code for UTS, this system is not
14107 supported anymore.
14108
4fcc2638
DN
141092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14110
14111 Don't force ./temacs to start in terminal mode.
14112
14113 * frame.c (make_initial_frame): Initialize faces in all cases, not
14114 only when CANNOT_DUMP is defined.
14115 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
14116
c56e0fd5
DN
141172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14118
14119 * dispnew.c (add_window_display_history): Use const for the string
14120 pointer. Remove declaration, not needed.
14121
333d54da 141222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 14123
55d4c1b2 14124 Use 'inline', not 'INLINE'.
333d54da 14125 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
14126 * alloc.c, fontset.c (INLINE): Remove.
14127 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
14128 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
14129 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
14130 * gmalloc.c (register_heapinfo): Use inline unconditionally.
14131 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
14132
738db178
DN
141332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14134
14135 Make it possible to run ./temacs.
14136
14137 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
14138 syms_of_callproc does the same thing. Remove test for
14139 "initialized", do it in the caller.
14140 * emacs.c (main): Avoid calling set_initial_environment when dumping.
14141
620c53a6
SM
141422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
14143
14144 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
14145 (read_minibuf): Use get_minibuffer.
14146 (syms_of_minibuf): Use DEFSYM.
14147 (Qmetadata): New var.
14148 * data.c (Qbuffer): Don't make it static.
14149 (syms_of_data): Use DEFSYM.
14150
e003a292
PE
141512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
14152
14153 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
14154 (CCL_CODE_MIN): New macro.
14155
ed008a6d
PE
141562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
14157
3687c2ef
PE
14158 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
14159
ed008a6d
PE
14160 * eval.c (Qdebug): Now static.
14161 * lisp.h (Qdebug): Remove decl. This reverts a part of the
14162 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
14163 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
14164
d66c4c7c
CY
141652011-05-29 Chong Yidong <cyd@stupidchicken.com>
14166
14167 * image.c: Various fixes to ImageMagick code comments.
14168 (Fimagemagick_types): Doc fix.
14169
5fbc2025
PE
141702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
14171
0196f88a
PE
14172 Minor fixes prompted by GCC 4.6.0 warnings.
14173
14174 * xselect.c (converted_selections, conversion_fail_tag): Now static.
14175
5fbc2025
PE
14176 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
14177 (x_clipboard_manager_save_all): Move extern decl to ...
14178 * xterm.h: ... here, so that it can be checked for consistency.
14179
1dd3c2d9
CY
141802011-05-29 Chong Yidong <cyd@stupidchicken.com>
14181
14182 * xselect.c (x_clipboard_manager_save_frame)
14183 (x_clipboard_manager_save_all): New functions.
14184 (Fx_clipboard_manager_save): Lisp function deleted.
14185
14186 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
14187 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
14188
14189 * xterm.h: Update prototype.
14190
5ba6571d
WX
141912011-05-28 William Xu <william.xwl@gmail.com>
14192
14193 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
14194 exiting (Bug#8239).
14195
3eaff834
JM
141962011-05-28 Jim Meyering <meyering@redhat.com>
14197
e1900994 14198 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
14199 * fns.c (to_uchar): Define.
14200 (crypto_hash_function): Use it to convert some newly-signed
14201 variables to unsigned, to avoid sign-extension bugs. For example,
14202 without this change, (md5 "truc") would evaluate to
14203 45723a2aff78ff4fff7fff1114760e62 rather than the expected
14204 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 14205 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 14206
0f6990a7
PE
142072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14208
14209 Integer overflow fixes.
c8a9ca5a 14210
08686060
PE
14211 * dbusbind.c: Serial number integer overflow fixes.
14212 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
14213 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
14214 to hold a serial number that is too large for a fixnum.
14215 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14216 Check for serial numbers out of range. Decode any serial number
59568bf0 14217 that was so large that it became a float. (Bug#8722)
08686060 14218
2d1fc3c7
PE
14219 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
14220 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14221 Use XFASTINT rather than XUINT when numbers are nonnegative.
14222 (xd_append_arg, Fdbus_method_return_internal):
14223 (Fdbus_method_error_internal): Likewise. Also, for unsigned
14224 arguments, check that Lisp number is nonnegative, rather than
59568bf0 14225 silently wrapping negative numbers around. (Bug#8722)
30217ff0 14226 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 14227 (Bug#8722)
2d1fc3c7 14228
c8a9ca5a
PE
14229 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
14230
519e1d69
PE
14231 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
14232
6df6ae42 14233 ccl: Add integer overflow checks.
30569699
PE
14234 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
14235 (IN_INT_RANGE): New macros.
14236 (ccl_driver): Use them to check for integer overflow when
14237 decoding a CCL program. Many of the new checks are whether XINT (x)
14238 fits in int; it doesn't always, on 64-bit hosts. The new version
14239 doesn't catch all possible integer overflows, but it's an
847044ea 14240 improvement. (Bug#8719)
30569699 14241
c11285dc
PE
14242 * alloc.c (make_event_array): Use XINT, not XUINT.
14243 There's no need for unsigned here.
14244
fdccd48e
PE
14245 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
14246 This follows up to the 2011-05-06 change that substituted uintptr_t
14247 for EMACS_INT. This case wasn't caught back then.
14248
37910ab2
PE
14249 Rework Fformat to avoid integer overflow issues.
14250 * editfns.c: Include <float.h> unconditionally, as it's everywhere
14251 now (part of C89). Include <verify.h>.
14252 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
14253 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
14254 (Fformat): Avoid the prepass trying to compute sizes; it was only
14255 approximate and thus did not catch overflow reliably. Instead, walk
14256 through the format just once, formatting and computing sizes as we go,
14257 checking for integer overflow at every step, and allocating a larger
14258 buffer as needed. Keep track separately whether the format is
14259 multibyte. Keep only the most-recently calculated precision, rather
14260 than them all. Record whether each argument has been converted to
14261 string. Use EMACS_INT, not int, for byte and char and arg counts.
14262 Support field widths and precisions larger than INT_MAX. Avoid
14263 sprintf's undefined behavior with conversion specifications such as %#d
14264 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
14265 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
14266 formatting out-of-range floating point numbers with int
9173deec 14267 formats. (Bug#8668)
37910ab2 14268
2e6578fb
PE
14269 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
14270
0ae6bdee
PE
14271 * data.c: Avoid integer truncation in expressions involving floats.
14272 * data.c: Include <intprops.h>.
14273 (arith_driver): When there's an integer overflow in an expression
14274 involving floating point, convert the integers to floating point
14275 so that the resulting value does not suffer from catastrophic
14276 integer truncation. For example, on a 64-bit host (* 4
14277 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
14278 Do not rely on undefined behavior after integer overflow.
14279
de883a70
PE
14280 merge count_size_as_multibyte, parse_str_to_multibyte
14281 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 14282 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
14283 Check for integer overflow.
14284 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
14285 since it's now a duplicate of the other. This is more of
14286 a character than a buffer op, so better that it's in character.c.
14287 * fns.c, print.c: Adjust to above changes.
14288
2ff916cb
PE
142892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
14290
14291 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
14292
f1b54466
PE
142932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14294
fb1ac845
PE
14295 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14296 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
14297 (x_clipboard_manager_save): Now static.
14298 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
14299
f1b54466
PE
14300 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14301 (crypto_hash_function): Now static.
14302 Fix pointer signedness problems. Avoid unnecessary initializations.
14303
a9f737ee
CY
143042011-05-27 Chong Yidong <cyd@stupidchicken.com>
14305
14306 * termhooks.h (Vselection_alist): Make it terminal-local.
14307
14308 * terminal.c (create_terminal): Initialize it.
14309
14310 * xselect.c: Support for clipboard managers.
14311 (Vselection_alist): Move to termhooks.h as terminal-local var.
14312 (LOCAL_SELECTION): New macro.
14313 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
14314 (symbol_to_x_atom): Remove gratuitous arg.
14315 (x_handle_selection_request, lisp_data_to_selection_data)
14316 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
14317 (x_own_selection, x_get_local_selection, x_convert_selection):
14318 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
14319 (some_frame_on_display): Delete unused function.
14320 (Fx_own_selection_internal, Fx_get_selection_internal)
14321 (Fx_disown_selection_internal, Fx_selection_owner_p)
14322 (Fx_selection_exists_p): New optional frame arg.
14323 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
14324 (x_handle_selection_clear): Don't treat other terminals with the
14325 same keyboard specially. Use the terminal-local Vselection_alist.
14326 (x_clear_frame_selections): Use Frun_hook_with_args.
14327
14328 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
14329
14330 * xterm.h: Add support for those atoms.
14331
e067f0c1
CY
143322011-05-26 Chong Yidong <cyd@stupidchicken.com>
14333
14334 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
14335 (converted_selections, conversion_fail_tag): New global variables.
14336 (x_selection_request_lisp_error): Free the above.
14337 (x_get_local_selection): Remove unnecessary code.
14338 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
14339 of converted selections stored in converted_selections.
14340 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
14341 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
14342 (x_convert_selection): New function.
14343 (x_handle_selection_event): Simplify.
14344 (x_get_foreign_selection): Don't ignore incoming requests while
14345 waiting for an answer; this will fail when we implement
14346 SAVE_TARGETS, and seems unnecessary anyway.
14347 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
14348 (Vx_sent_selection_functions): Doc fix.
14349
0f4aebc0
LL
143502011-05-26 Leo Liu <sdl.web@gmail.com>
14351
14352 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
14353
e61124cd
YM
143542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14355
14356 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
14357
14358 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
14359 for fringe update if it has periodic bitmap.
ac389d0c 14360 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
14361 and fringe_bitmap_periodic_p.
14362
14363 * fringe.c (get_fringe_bitmap_data): New function.
14364 (draw_fringe_bitmap_1, update_window_fringes): Use it.
14365 (update_window_fringes): Record periodicity of fringe bitmap in glyph
14366 row. Mark glyph row for fringe update if periodicity changed.
14367
14368 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
14369 for fringe update unless it has periodic bitmap.
14370
f16d9837
KH
143712011-05-25 Kenichi Handa <handa@m17n.org>
14372
14373 * xdisp.c (get_next_display_element): Set correct it->face_id for
14374 a static composition.
14375
e1b90ef6
LL
143762011-05-24 Leo Liu <sdl.web@gmail.com>
14377
14378 * deps.mk (fns.o):
14379 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
14380
14381 * fns.c (crypto_hash_function, Fsha1): New function.
14382 (Fmd5): Use crypto_hash_function.
14383 (syms_of_fns): Add Ssha1.
14384
7400048f
PE
143852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
14386
14387 * gnutls.c: Remove unused macros.
14388 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
14389 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
14390 Remove macros that are defined and never used.
14391 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
14392
abb71cf4
CY
143932011-05-22 Chong Yidong <cyd@stupidchicken.com>
14394
14395 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
14396 (Fx_get_selection_internal): Minor cleanup.
14397 (Fx_own_selection_internal): Rename arguments for consistency with
14398 select.el.
14399
6307db39
PE
144002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
14401
14402 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
14403
f3d4e0a4
CY
144042011-05-22 Chong Yidong <cyd@stupidchicken.com>
14405
14406 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
14407
4d8ade89
YM
144082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14409
14410 * dispnew.c (scrolling_window): Don't exclude the case that the
14411 last enabled row in the desired matrix touches the bottom boundary.
14412
32078c8d
GM
144132011-05-21 Glenn Morris <rgm@gnu.org>
14414
14415 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
14416 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
14417 and add some more files.
32078c8d 14418
7285dc67
EZ
144192011-05-20 Eli Zaretskii <eliz@gnu.org>
14420
14421 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
14422 report_file_error introduced by the change from 2011-05-07.
14423
89d1bd22
PE
144242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
14425
14426 * systime.h (Time): Define only if emacs is defined.
14427 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
14428 where the include path doesn't have X11/X.h by default. See
14429 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
14430
cd394be1 144312011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
14432
14433 * composite.c (find_automatic_composition): Fix previous change.
14434
b9704ad9
GM
144352011-05-20 Glenn Morris <rgm@gnu.org>
14436
14437 * lisp.mk: New file, split from Makefile.in.
14438 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
14439 (shortlisp): Remove.
14440 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
14441
4a720484
GM
144422011-05-19 Glenn Morris <rgm@gnu.org>
14443
14444 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
14445 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
14446 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
14447 (lisp): Set the order to that of loadup.el.
14448 (shortlisp): Make it a copy of $lisp.
14449 (SOME_MACHINE_LISP): Remove.
14450 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
14451 Use just $shortlisp, not $SOME_MACHINE_LISP too.
14452
a28d4396
KH
144532011-05-18 Kenichi Handa <handa@m17n.org>
14454
14455 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
14456 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
14457 (find_automatic_composition): Mostly rewrite for efficiency.
14458
a2b1fa8e
JB
144592011-05-18 Juanma Barranquero <lekktu@gmail.com>
14460
14461 * makefile.w32-in: Update dependencies.
14462
8e1f5610
CS
144632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
14464
14465 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 14466 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 14467
7025ee00 144682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 14469
cdfa6eab
PE
14470 Fix some integer overflow issues, such as string length overflow.
14471
06d6db33
PE
14472 * insdel.c (count_size_as_multibyte): Check for string overflow.
14473
2b4560a8
PE
14474 * character.c (lisp_string_width): Check for string overflow.
14475 Use EMACS_INT, not int, for string indexes and lengths; in
14476 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
14477 the resulting string length overflows an EMACS_INT; instead,
14478 report a string overflow if no precision given. When checking for
14479 precision exhaustion, use a check that cannot possibly have
14480 integer overflow. (Bug#8675)
14481 * character.h (lisp_string_width): Adjust to new signature.
14482
cb93f9be
PE
14483 * alloc.c (string_overflow): New function.
14484 (Fmake_string): Use it. This doesn't change behavior, but saves
14485 a few bytes and will simplify future changes.
14486 * character.c (string_escape_byte8): Likewise.
14487 * lisp.h (string_overflow): New decl.
14488
1a1f3366
PE
14489 Fixups, following up to the user-interface timestamp change.
14490 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
14491 for UI timestamps, instead of unsigned long.
9fbd6841
PE
14492 * msdos.c (mouse_get_pos): Likewise.
14493 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
14494 * w32gui.h (Time): Define by including "systime.h" rather than by
14495 declaring it ourselves. (Bug#8664)
14496
d4e3e4d3
PE
14497 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
14498 * image.c (clear_image_cache): Likewise.
14499
f6a24d19
PE
14500 * term.c (term_mouse_position): Don't assume time_t wraparound.
14501
08dc5ae6
PE
14502 Be more systematic about user-interface timestamps.
14503 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
14504 and sometimes 'EMACS_UINT', to represent these timestamps.
14505 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
14506 This makes the code easier to follow, and makes it easier to catch
14507 integer overflow bugs such as Bug#8664.
14508 * frame.c (Fmouse_position, Fmouse_pixel_position):
14509 Use Time, not unsigned long, for user-interface timestamps.
14510 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
14511 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
14512 * keyboard.h (last_event_timestamp): Likewise.
14513 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
14514 * menu.h (xmenu_show): Likewise.
14515 * term.c (term_mouse_position): Likewise.
14516 * termhooks.h (struct input_event.timestamp): Likewise.
14517 (struct terminal.mouse_position_hook): Likewise.
14518 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
14519 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
14520 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
14521 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
14522 what it was before.
14523 * menu.h, termhooks.h: Include "systime.h", for Time.
14524
8e55734a
PE
14525 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
14526 Don't assume that the difference between two unsigned long values
14527 can fit into an integer. At this point, we know button_down_time
14528 <= event->timestamp, so the difference must be nonnegative, so
14529 there's no need to cast the result if double-click-time is
14530 nonnegative, as it should be; check that it's nonnegative, just in
14531 case. This bug is triggered when events are more than 2**31 ms
86db42d2 14532 apart (about 25 days). (Bug#8664)
8e55734a 14533
841f1b75 14534 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 14535 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 14536
3e26f69c
PE
14537 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
14538 that always fit in int. Use a sentinel instead of a counter, to
14539 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
14540 * frame.h (struct frame): Use int for menu_bar_items_used
14541 instead of EMACS_INT, since it always fits in int.
3e26f69c 14542
5cc152c0
PE
14543 * menu.c (grow_menu_items): Check for int overflow.
14544
d89eb65e
PE
14545 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
14546
5235bd3e
PE
14547 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
14548 Before, the code was not consistent. These values cannot exceed
14549 2**31 - 1 so there's no need to make them unsigned.
14550 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
14551 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
14552 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
14553 as modifiers.
14554 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
14555
bc827e23
PE
14556 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
14557 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
14558 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
14559 presumably because the widths might not match.
14560
78eb494e
PE
14561 * window.c (size_window): Avoid needless test at loop start.
14562
04f2d78b
CB
145632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
14564
14565 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
14566
d2fc7e3d 145672011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
14568
14569 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
14570
d2fc7e3d 145712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
14572
14573 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
14574 `width' to `bar_area_x' and `bar_area_width', respectively.
14575 (x_scroll_run): Take account of fringe background extension.
14576
04f2d78b
CB
14577 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
14578 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
14579 `bar_area_width', respectively.
14580 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
14581 background extension.
14582
79b70037
GM
145832011-05-10 Jim Meyering <meyering@redhat.com>
14584
14585 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
14586
2f142cc5
JB
145872011-05-10 Juanma Barranquero <lekktu@gmail.com>
14588
14589 * image.c (Finit_image_library): Return t for built-in image types,
14590 like pbm and xbm. (Bug#8640)
14591
57679c86
AS
145922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
14593
14594 * w32menu.c (set_frame_menubar): Fix submenu allocation.
14595
888c9e86
EZ
145962011-05-07 Eli Zaretskii <eliz@gnu.org>
14597
b0512a1d
EZ
14598 * w32console.c (Fset_screen_color): Doc fix.
14599 (Fget_screen_color): New function.
14600 (syms_of_ntterm): Defsubr it.
14601
7285dc67
EZ
14602 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
14603 unlink the temporary file if Fcall_process didn't create it in the
14604 first place.
14605 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
14606 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
14607 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
14608 cue to call_process_cleanup not to close that handle.
14609
4d3fcc8e
BK
146102011-05-07 Ben Key <bkey76@gmail.com>
14611
14612 * makefile.w32-in: The bootstrap-temacs rule now makes use of
14613 one of two shell specific rules, either bootstrap-temacs-CMD or
14614 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
14615 to the previous implementation of the bootstrap-temacs rule.
14616 The bootstrap-temacs-CMD rule is similar to the previous
14617 implementation of the bootstrap-temacs rule except that it
14618 makes use of the ESC_CFLAGS variable instead of the CFLAGS
14619 variable.
14620
14621 These changes, along with some changes to nt/configure.bat,
14622 nt/gmake.defs, and nt/nmake.defs, are required to extend my
14623 earlier fix to add support for --cflags and --ldflags options
14624 that include quotes so that it works whether make uses cmd or
14625 sh as the shell.
14626
b4289b64
MA
146272011-05-06 Michael Albinus <michael.albinus@gmx.de>
14628
14629 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
14630 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
14631 is a constant.
14632 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
14633 a string. Handle both cases.
14634 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
14635 (Fdbus_register_method): Use Qinvalid_function.
14636
af4c0e28
JB
146372011-05-06 Juanma Barranquero <lekktu@gmail.com>
14638
14639 * makefile.w32-in: Update dependencies.
14640 (LISP_H): Add inttypes.h and stdin.h.
14641 (PROCESS_H): Add unistd.h.
14642
c51453d9
EZ
146432011-05-06 Eli Zaretskii <eliz@gnu.org>
14644
14645 * lread.c: Include limits.h (fixes the MS-Windows build broken by
14646 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
14647
8ff0ac3c 146482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 14649
4c4b566b
PE
14650 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
14651
aab2b9b5
PE
14652 * term.c (vfatal): Remove stray call to va_end.
14653 It's not needed and the C Standard doesn't allow it here anyway.
14654
c378da0b
PE
14655 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
14656 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
14657
288b08c7
PE
14658 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
14659 bytes.
14660
e3601888
PE
14661 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
14662
db6c0e74
PE
14663 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14664
dd5963ea
PE
14665 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
14666
88c9450f
PE
14667 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
14668
2f9442b8
PE
14669 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
14670
c032b5f8
PE
14671 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
14672 * charset.c (Fdefine_charset_internal): Don't initialize
14673 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 14674 32-bit int (Bug#8600).
a108c10b
PE
14675
14676 * lread.c (read_integer): Be more consistent with string-to-number.
14677 Use string_to_number to do the actual conversion; this avoids
14678 rounding errors and fixes some other screwups. Without this fix,
14679 for example, #x1fffffffffffffff was misread as -2305843009213693952.
14680 (digit_to_number): Move earlier, for benefit of read_integer.
14681 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 14682 not a digit in any supported base. (Bug#8602)
a108c10b 14683
ad5f9eea
PE
14684 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
14685
aec1708a
PE
14686 * dispnew.c (scrolling_window): Return 1 if we scrolled,
14687 to match comment at start of function. This also removes a
14688 GCC warning about overflow in a 32+64-bit port.
14689
47be4ab5
PE
14690 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
14691
371cac43
PE
14692 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
14693 Reported by Stefan Monnier in
14694 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
14695 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14696 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 14697
d01a7826
PE
14698 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
14699 (EMACS_UINTPTR): Likewise, with uintptr_t.
14700
7fd47d5c
PE
14701 * lisp.h: Prefer 64-bit EMACS_INT if available.
14702 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
14703 on 32-bit hosts that have 64-bit int, so that they can access
14704 large files.
122b0c86
PE
14705 However, temporarily disable this change unless the temporary
14706 symbol WIDE_EMACS_INT is defined.
7fd47d5c 14707
8727937b
PE
14708 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
14709
8ac068ac
PE
14710 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
14711 This removes an assumption that EMACS_INT and long are the same
14712 width as pointers. The assumption is true for Emacs porting targets
14713 now, but we want to make other targets possible.
14714 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
14715 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
14716 In the rest of the code, change types of integers that hold casted
14717 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
14718 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
14719 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
14720 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
14721 No need to cast type when ORing.
14722 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
14723 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
14724 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
14725 assume EMACS_INT is the same width as char *.
14726 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
14727 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
14728 Remove no-longer-needed casts.
14729 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
14730 (xg_tool_bar_help_callback, xg_make_tool_item):
14731 Use EMACS_INTPTR to hold an integer
14732 that will be cast to void *; this can avoid a GCC warning
14733 if EMACS_INT is not the same width as void *.
14734 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
14735 * xdisp.c (display_echo_area_1, resize_mini_window_1):
14736 (current_message_1, set_message_1):
14737 Use a local to convert to proper width without a cast.
14738 * xmenu.c (dialog_selection_callback): Likewise.
14739
ede49d71
PE
14740 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
14741 Also, don't assume VALBITS / RAND_BITS is less than 5,
14742 and don't rely on undefined behavior when shifting a 1 left into
14743 the sign bit.
14744 * lisp.h (get_random): Change signature to match.
14745
2f30ecd0
PE
14746 * lread.c (hash_string): Use size_t, not int, for hash computation.
14747 Normally we prefer signed values; but hashing is special, because
14748 it's better to use unsigned division on hash table sizes so that
14749 the remainder is nonnegative. Also, size_t is the natural width
14750 for hashing into memory. The previous code used 'int', which doesn't
14751 retain enough info to hash well into very large tables.
14752 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
14753
2a866e7b
PE
14754 * dbusbind.c: Don't possibly lose pointer info when converting.
14755 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14756 Use XPNTR rather than XHASH, so that the high-order bits of
14757 the pointer aren't lost when converting through void *.
14758
51639eac
PE
14759 * eval.c (Fautoload): Don't double-shift a pointer.
14760
92394119
PE
14761 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
14762
dbdb9a7c
JB
147632011-05-06 Juanma Barranquero <lekktu@gmail.com>
14764
14765 * gnutls.c (DEF_GNUTLS_FN):
14766 * image.c (DEF_IMGLIB_FN): Make function pointers static.
14767
db7a0b4f
AS
147682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
14769
14770 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
14771 marker. (Bug#8610)
14772
cd394be1 147732011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
14774
14775 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
14776 New version that can reserve upto 2GB of heap space.
14777
f7ff1b0f 147782011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
14779
14780 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
14781
639c109b
TZ
147822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
14783
14784 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
14785 `gnutls_certificate_set_x509_key_file'.
14786
d2127135
JB
147872011-05-05 Juanma Barranquero <lekktu@gmail.com>
14788
14789 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
14790 Update dependencies.
14791
e968f4f3
JB
147922011-05-04 Juanma Barranquero <lekktu@gmail.com>
14793
14794 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
14795 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
14796 Remove unused parameter `fildes'.
14797 * process.c (read_process_output, send_process): Don't pass it.
14798
84d358f0
JB
147992011-05-04 Juanma Barranquero <lekktu@gmail.com>
14800
14801 Fix previous change: the library cache is defined in w32.c.
14802 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
14803 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
14804
0898ca10
JB
148052011-05-04 Juanma Barranquero <lekktu@gmail.com>
14806
14807 Implement dynamic loading of GnuTLS on Windows.
14808
14809 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
14810 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
14811 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14812 Declare.
14813
14814 * gnutls.c (Qgnutls_dll): Define.
14815 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
14816 (gnutls_*): Declare function pointers.
14817 (init_gnutls_functions): New function to initialize function pointers.
14818 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
14819 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
14820 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14821 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
14822 (emacs_gnutls_write, emacs_gnutls_read)
14823 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
14824 (Fgnutls_available_p): New function.
14825 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
14826 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
14827 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
14828
14829 * image.c: Include w32.h.
14830 (Vimage_type_cache): Delete.
14831 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
14832 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
14833 (w32_delayed_load): Move to w32.c.
14834
14835 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
14836
14837 * w32.c (QCloaded_from, Vlibrary_cache): Define.
14838 (w32_delayed_load): Move from image.c. When loading a library, record
14839 its filename in the :loaded-from property of the library id.
14840 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
14841 Initialize and staticpro them.
14842 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
14843
14844 * process.c: Include lisp.h before w32.h, not after.
14845 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
14846 instead of gnutls_record_check_pending.
14847
14848 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
14849
ff4de4aa
TZ
148502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
14851
14852 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
14853 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
14854 as passed in.
14855
abe95abb
JD
148562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
14857
14858 * xterm.c (x_set_frame_alpha): Do not set property on anything
14859 else than FRAME_X_OUTER_WINDOW (Bug#8608).
14860
e16e55d4
JB
148612011-05-02 Juanma Barranquero <lekktu@gmail.com>
14862
14863 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
14864
bafcf6a5
JB
148652011-05-02 Juanma Barranquero <lekktu@gmail.com>
14866
14867 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
14868 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
14869 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
14870 (gnutls_global_initialized, Qgnutls_bootprop_priority)
14871 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
14872 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
14873 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
14874 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
14875 (Qgnutls_bootprop_callbacks_verify): Make static.
14876
e7a6747f
AS
148772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
14878
19ed11ba
AS
14879 * callproc.c: Indentation fixup.
14880
e7a6747f 14881 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
14882 (wait_for_termination, interruptible_wait_for_termination):
14883 Move after wait_for_termination_1.
e7a6747f 14884
1ef14cb4
LMI
148852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
14886
14887 * sysdep.c (interruptible_wait_for_termination): New function
14888 which is like wait_for_termination, but allows keyboard
14889 interruptions.
14890
14891 * callproc.c (Fcall_process): Add (:file "file") as an option for
14892 the STDOUT buffer.
14893 (Fcall_process_region): Ditto.
14894
330d880c
EZ
148952011-04-30 Eli Zaretskii <eliz@gnu.org>
14896
8db90b73
EZ
14897 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
14898 rather than `XVECTOR (FOO)->size'.
14899
330d880c
EZ
14900 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
14901 inttypes.h, as a gnulib replacement is used if it not available in
14902 system headers.
14903
15cbd324
EZ
149042011-04-21 Eli Zaretskii <eliz@gnu.org>
14905
14906 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
14907 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
14908 of MOST_POSITIVE_FIXNUM. (Bug#8528)
14909
14910 * coding.c (coding_alloc_by_realloc): Error out if destination
14911 will grow beyond MOST_POSITIVE_FIXNUM.
14912 (decode_coding_emacs_mule): Abort if there isn't enough place in
14913 charbuf for the composition carryover bytes. Reserve an extra
14914 space for up to 2 characters produced in a loop.
14915 (decode_coding_iso_2022): Abort if there isn't enough place in
14916 charbuf for the composition carryover bytes.
14917
149182011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 14919
ae940cca
EZ
14920 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
14921 aborting when %lld or %lll format is passed.
14922 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
14923 %llo or %llx format is passed. (Bug#8545)
14924
03ab8921
EZ
14925 * window.c (window_scroll_line_based): Use a marker instead of
14926 simple variables to record original value of point. (Bug#7952)
14927
afda1437
EZ
14928 * doprnt.c (doprnt): Fix the case where a multibyte sequence
14929 produced by %s or %c overflows available buffer space. (Bug#8545)
14930
f76dee0c
PE
149312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
14932
14933 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 14934 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 14935
fdc5744d
JB
149362011-04-28 Juanma Barranquero <lekktu@gmail.com>
14937
14938 * w32.c (init_environment): Warn about defaulting HOME to C:\.
14939
638f053a
JB
149402011-04-28 Juanma Barranquero <lekktu@gmail.com>
14941
14942 * keyboard.c (Qdelayed_warnings_hook): Define.
14943 (command_loop_1): Run `delayed-warnings-hook'
14944 if Vdelayed_warnings_list is non-nil.
14945 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
14946 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
14947
d178f871
EZ
149482011-04-28 Eli Zaretskii <eliz@gnu.org>
14949
14950 * doprnt.c (doprnt): Don't return value smaller than the buffer
14951 size if the message was truncated. (Bug#8545).
14952
b124fd93
JB
149532011-04-28 Juanma Barranquero <lekktu@gmail.com>
14954
14955 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
14956 (Fx_window_property): #if-0 the whole functions, not just the bodies.
14957
e810457d
PE
149582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14959
14960 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
14961
ea51cceb
JB
149622011-04-27 Juanma Barranquero <lekktu@gmail.com>
14963
14964 * makefile.w32-in: Update dependencies.
14965
94dcfacf
EZ
149662011-04-27 Eli Zaretskii <eliz@gnu.org>
14967
14968 Improve `doprnt' and its usage. (Bug#8545)
14969 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
14970 `format_end'. Remove support for %l as a conversion specifier.
14971 Don't use xrealloc. Improve diagnostics when the %l size modifier
14972 is used. Update the commentary.
14973
14974 * eval.c (verror): Simplify calculation of size_t.
14975
14976 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
14977 messages.
14978
f61f41d7
PE
149792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
14980
14981 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
14982 change.
14983
96fb4434
PE
149842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14985
14986 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
14987 This makes this file independent of the recent pseudovector change.
14988
671875da 149892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 14990
69e9b5a3
PE
14991 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
14992
b5f869a7 14993 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 14994 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 14995 Remove unused local.
c8926152 14996 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 14997
841a1577 14998 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
14999 GCC 4.6.0 optimizes based on type-based alias analysis.
15000 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
15001 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
15002 != &v->size, and therefore "v->size = 1; b->size = 2; return
15003 v->size;" must therefore return 1. This assumption is incorrect
15004 for Emacs, since it type-puns struct Lisp_Vector * with many other
15005 types. To fix this problem, this patch adds a new type struct
f904488f 15006 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
15007 and pseudovectors, and helps optimizing compilers not get fooled
15008 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
15009 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
15010 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
15011 the size member.
eab3844f
PE
15012 (XSETPVECTYPE): Rewrite in terms of new macro.
15013 (XSETPVECTYPESIZE): New macro, specifying both type and size.
15014 This is a bit clearer, and further avoids the possibility of
15015 undesirable aliasing.
15016 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 15017 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
15018 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
15019 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
15020 (ASIZE): Now uses header.size rather than size.
15021 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
15022 to avoid the hassle of writing XVECTOR (foo)->header.size.
15023 (struct vectorlike_header): New type.
eab3844f
PE
15024 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
15025 object, to help avoid aliasing.
15026 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
15027 (SUBRP): Likewise, since Lisp_Subr is a special case.
15028 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
15029 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
15030 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 15031 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
15032 changed to be "header.size" and "header.next".
15033 * buffer.h (struct buffer): Likewise.
15034 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
15035 * frame.h (struct frame): Likewise.
15036 * process.h (struct Lisp_Process): Likewise.
15037 * termhooks.h (struct terminal): Likewise.
15038 * window.c (struct save_window_data, struct saved_window): Likewise.
15039 * window.h (struct window): Likewise.
15040 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
15041 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
15042 * buffer.c (init_buffer_once): Likewise.
15043 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
15044 special case.
15045 * process.c (Fformat_network_address): Use local var for size,
15046 for brevity.
15047
0df1eac5
PE
15048 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
15049
847ab9d1 15050 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
15051 * data.c (atof): Remove decl; no longer used or needed.
15052 (digit_to_number): Move to lread.c.
15053 (Fstring_to_number): Use new string_to_number function, to be
15054 consistent with how the Lisp reader treats infinities and NaNs.
15055 Do not assume that floating-point numbers represent EMACS_INT
15056 without losing information; this is not true on most 64-bit hosts.
15057 Avoid double-rounding errors, by insisting on integers when
15058 parsing non-base-10 numbers, as the documentation specifies.
15059 * lisp.h (string_to_number): New decl, replacing ...
15060 (isfloat_string): Remove.
bc0a5c13 15061 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 15062 (read1): Do not accept +. and -. as integers; this
452f4150
PE
15063 appears to have been a coding error. Similarly, do not accept
15064 strings like +-1e0 as floating point numbers. Do not report
15065 overflow for integer overflows unless the base is not 10 which
15066 means we have no simple and reliable way to continue.
15067 Break out the floating-point parsing into a new
15068 function string_to_number, so that Fstring_to_number parses
15069 floating point numbers consistently with the Lisp reader.
04f2d78b 15070 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
15071 (E_CHAR, EXP_INT): Remove, replacing with ...
15072 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
15073 (string_to_number): New function, replacing isfloat_string.
15074 This function checks for valid syntax and produces the resulting
15075 Lisp float number too. Rework it so that string-to-number
bc0a5c13 15076 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
15077 so that overflow for non-base-10 numbers is reported only when
15078 there's no portable and simple way to convert to floating point.
452f4150 15079
67769ffc
PE
15080 * textprop.c (set_text_properties_1): Rewrite for clarity,
15081 and to avoid GCC warning about integer overflow.
15082
c20db43f
PE
15083 * intervals.h (struct interval): Use EMACS_INT for members
15084 where EMACS_UINT might cause problems. See
15085 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
15086 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
15087 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
15088 All uses changed.
37aa2f85
PE
15089 (offset_intervals): Tell GCC not to worry about length overflow
15090 when negating a negative length.
c20db43f 15091
2538aa2f
PE
15092 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
15093 (overrun_check_free): Likewise.
15094
f2d3008d
PE
15095 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
15096 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
15097 word size.
15098
ec8df744
PE
15099 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15100 (gnutls_make_error): Rename local to avoid shadowing.
15101 (gnutls_emacs_global_deinit): ifdef out; not used.
15102 (Fgnutls_boot): Use const for pointer to readonly storage.
15103 Comment out unused local. Fix pointer signedness problems.
15104
640ee02d
PE
15105 * lread.c (openp): Don't stuff size_t into an 'int'.
15106 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
15107 about possible signed overflow.
15108
6048fb2a
PE
15109 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15110 (GDK_KEY_g): Don't define if already defined.
15111 (xg_prepare_tooltip): Avoid pointer signedness problem.
15112 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
15113
fa3c87e1
PE
15114 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
15115 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
15116
2172544b
PE
15117 * xfns.c (Fx_window_property): Simplify a bit,
15118 to make a bit faster and to avoid GCC 4.6.0 warning.
15119 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
15120
9b821a21
PE
15121 * fns.c (internal_equal): Don't assume size_t fits in int.
15122
3c616cfa
PE
15123 * alloc.c (compact_small_strings): Tighten assertion a little.
15124
c2982e87
PE
15125 Replace pEd with more-general pI, and fix some printf arg casts.
15126 * lisp.h (pI): New macro, generalizing old pEd macro to other
15127 conversion specifiers. For example, use "...%"pI"d..." rather
15128 than "...%"pEd"...".
15129 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 15130 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
15131 * alloc.c (check_pure_size): Don't overflow by converting size to int.
15132 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
15133 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
15134 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
15135 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
15136 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
15137 64-bit hosts.
15138 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
15139 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
15140 * print.c (safe_debug_print, print_object): Likewise.
15141 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
15142 to int.
6f04d126
PE
15143 Use pI instead of if-then-else-abort. Use %p to avoid casts,
15144 avoiding the 0 flag, which is not portable.
c2982e87
PE
15145 * process.c (Fmake_network_process): Use pI to avoid cast.
15146 * region-cache.c (pp_cache): Likewise.
15147 * xdisp.c (decode_mode_spec): Likewise.
15148 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
15149 behavior on 64-bit hosts with printf arg.
6f04d126 15150 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
15151 (x_stop_queuing_selection_requests): Likewise.
15152 (x_get_window_property): Don't truncate byte count to an 'int'
15153 when tracing.
0b432f21 15154
5e073ec7
PE
15155 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
15156 here, since it parses constructs like leading '-' and spaces,
15157 which are not wanted; and it overflows with large numbers.
15158 Instead, simply match F[0-9]+, which is what is wanted anyway.
15159
36372bf9
PE
15160 * alloc.c: Remove unportable assumptions about struct layout.
15161 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
15162 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
15163 (allocate_vectorlike, make_pure_vector): Use the new macros,
15164 plus offsetof, to remove unportable assumptions about struct layout.
15165 These assumptions hold on all porting targets that I know of, but
15166 they are not guaranteed, they're easy to remove, and removing them
15167 makes further changes easier.
15168
0b432f21
PE
15169 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
15170 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
15171 (string_overrun_cookie): Now const. Use initializers that
15172 don't formally overflow signed char, to avoid warnings.
000098c1
PE
15173 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
15174 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
15175 (allocate_buffer): Don't assume sizeof (struct buffer) is a
15176 multiple of sizeof (EMACS_INT); it need not be, if
15177 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 15178 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 15179
895009e1
JB
151802011-04-26 Juanma Barranquero <lekktu@gmail.com>
15181
15182 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
15183
6a7a1b0b
TZ
151842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
15185
15186 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 15187 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
15188 Reported by Paul Eggert <eggert@cs.ucla.edu>.
15189
841a1577 151902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
15191
15192 * lisp.h (Qdebug): List symbol.
895009e1 15193 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
15194 * keyboard.c (debug-on-event): New variable.
15195 (handle_user_signal): Break into debugger when debug-on-event
15196 matches the current signal symbol.
15197
f2d3ba6f
DN
151982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
15199
15200 * alloc.c (check_sblock, check_string_bytes)
15201 (check_string_free_list): Convert to standard C.
15202
42ce4c63
TZ
152032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
15204
15205 * w32.c (emacs_gnutls_push): Fix typo.
15206
825cd63c
EZ
152072011-04-25 Eli Zaretskii <eliz@gnu.org>
15208
fb11d64d
EZ
15209 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
15210 "cast to pointer from integer of different size".
15211
825cd63c
EZ
15212 Improve doprnt and its use in verror. (Bug#8545)
15213 * doprnt.c (doprnt): Document the set of format control sequences
15214 supported by the function. Use SAFE_ALLOCA instead of always
15215 using `alloca'.
15216
15217 * eval.c (verror): Don't limit the buffer size at size_max-1, that
15218 is one byte too soon. Don't use xrealloc; instead xfree and
15219 xmalloc anew.
15220
e061a11b
TZ
152212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
15222
15223 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
15224 callbacks stage.
15225
15226 * gnutls.c: Renamed global_initialized to
15227 gnutls_global_initialized. Added internals for the
15228 :verify-hostname-error, :verify-error, and :verify-flags
15229 parameters of `gnutls-boot' and documented those parameters in the
15230 docstring. Start callback support.
9173deec
JB
15231 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
15232 unless a fatal error occurred. Call gnutls_alert_send_appropriate
15233 on error. Return error code.
e061a11b
TZ
15234 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
15235 (emacs_gnutls_read): Likewise.
15236 (Fgnutls_boot): Return handshake error code.
15237 (emacs_gnutls_handle_error): New function.
15238 (wsaerror_to_errno): Likewise.
15239
15240 * w32.h (emacs_gnutls_pull): Add prototype.
15241 (emacs_gnutls_push): Likewise.
15242
15243 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
15244 (emacs_gnutls_push): Likewise.
15245
152462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
15247
15248 * process.c (wait_reading_process_output): Check if GnuTLS
15249 buffered some data internally if no FDs are set for TLS
15250 connections.
15251
15252 * makefile.w32-in (OBJ2): Add gnutls.$(O).
15253 (LIBS): Link to USER_LIBS.
15254 ($(BLD)/gnutls.$(0)): New target.
15255
fa6996bc
EZ
152562011-04-24 Eli Zaretskii <eliz@gnu.org>
15257
eb35682e
EZ
15258 * xdisp.c (handle_single_display_spec): Rename the
15259 display_replaced_before_p argument into display_replaced_p, to
15260 make it consistent with the commentary. Fix typos in the
15261 commentary.
15262
e2ad650c
EZ
15263 * textprop.c (syms_of_textprop): Remove dead code.
15264 (copy_text_properties): Delete obsolete commentary about an
15265 interface that was deleted long ago. Fix typos in the description
15266 of arguments.
15267
1b2de274
EZ
15268 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
15269 to changes in oldXMenu/XMenu.h from 2011-04-16.
15270 <menu_help_message, prev_menu_help_message>: Constify.
15271 (IT_menu_make_room): menu->help_text is now `const char **';
15272 adjust.
15273
15274 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
15275 to changes in oldXMenu/XMenu.h from 2011-04-16.
15276 (struct XMenu): Declare `help_text' `const char **'.
15277
15278 * xfaces.c <Qunspecified>: Make extern again.
15279
15280 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 15281 required by POSIX.
1b2de274 15282
762b15be
EZ
15283 * doc.c (get_doc_string): Improve the format passed to `error'.
15284
15285 * doprnt.c (doprnt): Improve commentary.
15286
15287 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
15288
15289 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
15290 them with etags.
15291
f1052e5d
EZ
15292 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
15293 changes in globals.h immediately force recompilation.
762b15be
EZ
15294 (TAGS): Depend on $(CURDIR)/m/intel386.h and
15295 $(CURDIR)/s/ms-w32.h.
15296 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 15297
fa6996bc
EZ
15298 * character.c (Fchar_direction): Function deleted.
15299 (syms_of_character): Don't defsubr it.
15300 <char-direction-table>: Deleted.
15301
e6c3da20
EZ
153022011-04-23 Eli Zaretskii <eliz@gnu.org>
15303
15304 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
15305 * doprnt.c: Include limits.h.
15306 (SIZE_MAX): New macro.
04f2d78b
CB
15307 (doprnt): Return a size_t value. 2nd arg is now size_t.
15308 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
15309 Improve overflow protection. Support `l' modifier for integer
15310 conversions. Support %l conversion. Don't assume an EMACS_INT
15311 argument for integer conversions and for %c.
15312
15313 * lisp.h (doprnt): Restore prototype.
15314
15315 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
15316 $(SRC)/character.h.
15317
15318 * Makefile.in (base_obj): Add back doprnt.o.
15319
15320 * deps.mk (doprnt.o): Add back prerequisites.
15321 (callint.o): Depend on character.h.
15322
15323 * eval.c (internal_lisp_condition_case): Include the handler
15324 representation in the error message.
15325 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
15326 when breaking from the loop.
15327
15328 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
15329
15330 * callint.c (Fcall_interactively): When displaying error message
15331 about invalid control letter, pass the character's codepoint, not
15332 a pointer to its multibyte form. Improve display of the character
15333 in octal and display also its hex code.
15334
15335 * character.c (char_string): Use %x to display the (unsigned)
15336 codepoint of an invalid character, to avoid displaying a bogus
15337 negative value.
15338
15339 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
15340 `error', not SYMBOL_NAME itself.
15341
15342 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
15343 character arguments to `error'.
15344
15345 * charset.c (check_iso_charset_parameter): Fix incorrect argument
15346 to `error' in error message about FINAL_CHAR argument. Make sure
15347 FINAL_CHAR is a character, and use %c when it is passed as
15348 argument to `error'.
15349
4ffd0d6b 153502011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
15351
15352 * s/ms-w32.h (localtime): Redirect to sys_localtime.
15353
15354 * w32.c: Include <time.h>.
15355 (sys_localtime): New function.
15356
4ffd0d6b 153572011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
15358
15359 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
15360
4ffd0d6b 15361 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 15362
4ffd0d6b 153632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 15364
4ffd0d6b
GM
15365 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
15366 zombies (Bug#8467).
aac0c6e3 15367
04c56954
EZ
153682011-04-19 Eli Zaretskii <eliz@gnu.org>
15369
15370 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
15371 gl_state.e_property when gl_state.object is Qt.
15372
15373 * insdel.c (make_gap_larger): Remove limitation of buffer size
15374 to <= INT_MAX.
15375
16a43933
CY
153762011-04-18 Chong Yidong <cyd@stupidchicken.com>
15377
15378 * xdisp.c (lookup_glyphless_char_display)
15379 (produce_glyphless_glyph): Handle cons cell entry in
15380 glyphless-char-display.
15381 (Vglyphless_char_display): Document it.
15382
15383 * term.c (produce_glyphless_glyph): Handle cons cell entry in
15384 glyphless-char-display.
15385
4581706e
CY
153862011-04-17 Chong Yidong <cyd@stupidchicken.com>
15387
15388 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
15389
15390 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
15391
15392 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
15393 definition for no-X builds.
15394
4887c6e2 153952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 15396
fd35b6f9
PE
15397 Static checks with GCC 4.6.0 and non-default toolkits.
15398
5c1ccb01
PE
15399 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
15400
006c5daa
PE
15401 * process.c (keyboard_bit_set): Define only if SIGIO.
15402 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
15403 (send_process): Repair possible setjmp clobbering.
15404
efc736d3
PE
15405 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
15406
4e2fe2e6
PE
15407 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
15408
f97334a2
PE
15409 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
15410
4e75f29d
PE
15411 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
15412 Define only if needed.
15413
90efadd1
PE
15414 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
15415 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 15416 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 15417
3c647824
PE
15418 * dispextern.h (struct redisplay_interface): Rename param
15419 to avoid shadowing.
e264f262 15420 * termhooks.h (struct terminal): Likewise.
761383f4 15421 * xterm.c (xembed_send_message): Likewise.
3c647824 15422
b58c5c4a
PE
15423 * insdel.c (make_gap_smaller): Define only if
15424 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
15425
cad59032
PE
15426 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
15427 it.
15428
c339dc2e
PE
15429 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
15430 so that we aren't warned about unused symbols.
15431
91a3e27b
PE
15432 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
15433
399c71d3 15434 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 15435
8ffc96f5
PE
15436 * xfns.c (x_real_positions): Mark locals as initialized.
15437
eef9bc79
PE
15438 * xmenu.c (xmenu_show): Don't use uninitialized vars.
15439
098db9dd
PE
15440 * xterm.c: Fix problems found by static analysis with other toolkits.
15441 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
15442 (x_dispatch_event): Declare static if USE_GTK, and
15443 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 15444 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 15445 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
15446 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
15447 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 15448
eb18f6cc
PE
15449 * xmenu.c (menu_help_callback): Pointer type fixes.
15450 Use const pointers when pointing at readonly data. Avoid pointer
15451 signedness clashes.
15452 (FALSE): Remove unused macro.
15453 (update_frame_menubar): Remove unused decl.
15454
1fe72bf8
PE
15455 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
15456
60d9e1db
PE
15457 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
15458 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
15459 (single_menu_item): Rename local to avoid shadowing.
15460
39261c26
PE
15461 * keyboard.c (make_lispy_event): Remove unused local var.
15462
018c5e19
PE
15463 * frame.c, frame.h (x_get_resource_string): Bring this back, but
15464 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
15465
63d2b86e
PE
15466 * bitmaps: Change bitmaps from unsigned char back to the X11
15467 compatible char. Avoid the old compiler warnings about
15468 out-of-range initializers by using, for example, '\xab' rather
15469 than 0xab.
15470
aefd87e1
PE
15471 * xgselect.c (xgselect_initialize): Check vs interface
15472 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
15473
bf501fb9
PE
15474 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
15475
e9829fdf
PE
15476 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
15477 to read-only memory.
15478
1086c095
PE
15479 * fns.c (vector): Remove; this old hack is no longer needed.
15480
2baccd04 15481 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 15482 Remove unused var.
dde42981 15483 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 15484
72391843 15485 * xrdb.c (x_load_resources): Omit unused local.
3565b346 15486
436c16df 15487 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 15488 (x_window): Rename locals to avoid shadowing.
dc5ddd85 15489 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 15490
92bb796d 15491 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 15492 (x_term_init): Remove local to avoid shadowing.
92bb796d 15493
764430a3 15494 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
15495
15496 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
15497 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
15498
d1dfb56c
EZ
154992011-04-16 Eli Zaretskii <eliz@gnu.org>
15500
c4354cb4
EZ
15501 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
15502
d1dfb56c
EZ
15503 Fix regex.c, syntax.c and friends for buffers > 2GB.
15504 * syntax.h (struct gl_state_s): Declare character position members
15505 EMACS_INT.
15506
15507 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
15508
04f2d78b
CB
15509 * textprop.c (verify_interval_modification, interval_of):
15510 Declare arguments EMACS_INT.
d1dfb56c
EZ
15511
15512 * intervals.c (adjust_intervals_for_insertion): Declare arguments
15513 EMACS_INT.
15514
15515 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
15516
15517 * indent.c (Fvertical_motion): Local variable it_start is now
15518 EMACS_INT.
15519
15520 * regex.c (re_match, re_match_2, re_match_2_internal)
15521 (bcmp_translate, regcomp, regexec, print_double_string)
15522 (group_in_compile_stack, re_search, re_search_2, regex_compile)
15523 (re_compile_pattern, re_exec): Declare arguments and local
15524 variables `size_t' and `ssize_t' and return values `regoff_t', as
15525 appropriate.
15526 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
15527 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
15528 <compile_stack_type>: `size' and `avail' are now `size_t'.
15529
15530 * regex.h <regoff_t>: Use ssize_t, not int.
15531 (re_search, re_search_2, re_match, re_match_2): Arguments that
15532 specify buffer/string position and length are now ssize_t and
15533 size_t. Return type is regoff_t.
15534
613052cd
BK
155352011-04-16 Ben Key <bkey76@gmail.com>
15536
15537 * nsfont.m: Fixed bugs in ns_get_family and
15538 ns_descriptor_to_entity that were caused by using free to
15539 deallocate memory blocks that were allocated by xmalloc (via
15540 xstrdup). This caused Emacs to crash when compiled with
15541 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
15542 --enable-checking=xmallocoverrun). xfree is now used to
15543 deallocate these memory blocks.
15544
4170f62f 155452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 15546
71b41406
PE
15547 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
15548
9587a89d
PE
15549 emacs_write: Accept and return EMACS_INT for sizes.
15550 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
15551 et seq.
15552 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
15553 Accept and return EMACS_INT.
15554 (emacs_gnutls_write): Return the number of bytes written on
15555 partial writes.
15556 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
15557 (emacs_read, emacs_write): Remove check for negative size, as the
15558 Emacs source code has been audited now.
9587a89d
PE
15559 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
15560 (emacs_read, emacs_write): Use it.
273a5f82
PE
15561 * process.c (send_process): Adjust to the new signatures of
15562 emacs_write and emacs_gnutls_write. Do not attempt to store
15563 a byte offset into an 'int'; it might overflow.
9587a89d 15564 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 15565
3e047f51
PE
15566 * sound.c: Don't assume sizes fit in 'int'.
15567 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 15568 Return EMACS_INT, not int.
3e047f51 15569 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
15570 Accept EMACS_INT, not int.
15571 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
15572 record read return values.
15573
cc39a9db
BK
155742011-04-15 Ben Key <bkey76@gmail.com>
15575
c9d0ec6d
JB
15576 * keyboard.c (Qundefined): Don't declare static since it is used
15577 in nsfns.m.
15578 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
15579 static since they are used in nsfont.m.
cc39a9db 15580
6c60eb9f
SM
155812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
15582
15583 * process.c (Qprocessp): Don't declare static.
15584 * lisp.h (Qprocessp): Declare again.
15585
7990b61a
JB
155862011-04-15 Juanma Barranquero <lekktu@gmail.com>
15587
15588 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
15589
5d4cb038
PE
155902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
15591
8bd7b830 15592 Improve C-level modularity by making more things 'static'.
cd64ea1d 15593
e3b27b31
PE
15594 Don't publish debugger-only interfaces to other modules.
15595 * lisp.h (safe_debug_print, debug_output_compilation_hack):
15596 (verify_bytepos, count_markers): Move decls to the only modules
15597 that need them.
15598 * region-cache.h (pp_cache): Likewise.
15599 * window.h (check_all_windows): Likewise.
15600 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
15601
5d4cb038
PE
15602 * sysdep.c (croak): Now static, if
15603 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
15604 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
15605
15606 * alloc.c (refill_memory_reserve): Now static if
15607 !defined REL_ALLOC || defined SYSTEM_MALLOC.
15608 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 15609
e87b6180
PE
15610 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
15611 Define only if USE_LUCID.
15612
ac64929e
PE
15613 * xrdb.c (x_customization_string, x_rm_string): Now static.
15614
6f37259d
PE
15615 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
15616 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
15617
1683e3ab
PE
15618 * xdisp.c (draw_row_with_mouse_face): Now static.
15619 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
15620
de9c2632
PE
15621 * window.h (check_all_windows): Mark externally visible.
15622
2b96acb7
PE
15623 * window.c (window_deletion_count): Now static.
15624
15625 * undo.c: Make symbols static if they're not exported.
15626 (last_undo_buffer, last_boundary_position, pending_boundary):
15627 Now static.
15628
50436f33
PE
15629 * textprop.c (interval_insert_behind_hooks): Now static.
15630 (interval_insert_in_front_hooks): Likewise.
15631
64520e5c
PE
15632 * term.c: Make symbols static if they're not exported.
15633 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
15634 (max_frame_lines, tty_set_terminal_modes):
15635 (tty_reset_terminal_modes, tty_turn_off_highlight):
15636 (get_tty_terminal): Now static.
15637 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
15638 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 15639 HAVE_WINDOW_SYSTEM.
64520e5c
PE
15640 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
15641 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
15642
1fa53021
PE
15643 * sysdep.c: Make symbols static if they're not exported.
15644 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
15645 Now static.
15646 (sigprocmask_set, full_mask): Remove; unused.
15647 (wait_debugging): Mark as visible.
15648 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
15649 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
15650
d4b43b22
PE
15651 * syntax.c (syntax_temp): Define only if !__GNUC__.
15652
b7c513d0
PE
15653 * sound.c (current_sound_device, current_sound): Now static.
15654
989b29ad
PE
15655 * search.c (searchbufs, searchbuf_head): Now static.
15656
13a55a78
PE
15657 * scroll.c (scroll_cost): Remove; unused.
15658 * dispextern.h (scroll_cost): Remove decl.
15659
de68a1fc
PE
15660 * region-cache.h (pp_cache): Mark as externally visible.
15661
40ccffa6
PE
15662 * process.c: Make symbols static if they're not exported.
15663 (process_tick, update_tick, create_process, chan_process):
15664 (Vprocess_alist, proc_buffered_char, datagram_access):
15665 (fd_callback_data, send_process_frame, process_sent_to): Now static.
15666 (deactivate_process): Mark defn as static, as well as decl.
15667 * lisp.h (create_process): Remove decl.
15668 * process.h (chan_process, Vprocess_alist): Remove decls.
15669
ad64fc97
PE
15670 * print.c: Make symbols static if they're not exported.
15671 (print_depth, new_backquote_output, being_printed, print_buffer):
15672 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
15673 (print_interval, print_number_index, initial_stderr_stream):
15674 Now static.
15675 * lisp.h (Fprinc): Remove decl.
15676 (debug_output_compilation_hack): Mark as externally visible.
15677
adddb265
PE
15678 * sysdep.c (croak): Move decl from here to syssignal.h.
15679 * syssignal.h (croak): Put it here, so the API can be checked when
15680 'croak' is called from dissociate_if_controlling_tty.
15681
1717ede2
PE
15682 * minibuf.c: Make symbols static if they're not exported.
15683 (minibuf_save_list, choose_minibuf_frame): Now static.
15684 * lisp.h (choose_minibuf_frame): Remove decl.
15685
fa5fb2bc
PE
15686 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
15687
1e3890d1
PE
15688 * lread.c: Make symbols static if they're not exported.
15689 (read_objects, initial_obarray, oblookup_last_bucket_number):
15690 Now static.
15691 (make_symbol): Remove; unused.
15692 * lisp.h (initial_obarray, make_symbol): Remove decls.
15693
8a1414fa
PE
15694 * keyboard.c: Make symbols static if they're not exported.
15695 (single_kboard, recent_keys_index, total_keys, recent_keys):
15696 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
15697 (this_single_command_key_start, echoing, last_auto_save):
15698 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
15699 (command_loop, echo_now, keyboard_init_hook, help_char_p):
15700 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
15701 (Vlispy_mouse_stem, double_click_count):
15702 Now static.
15703 (force_auto_save_soon): Define only if SIGDANGER.
15704 (ignore_mouse_drag_p): Now static if
15705 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
15706 (print_help): Remove; unused.
15707 (stop_character, last_timer_event): Mark as externally visible.
15708 * keyboard.h (ignore_mouse_drag_p): Declare only if
15709 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
15710 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
15711 * lisp.h (echoing): Remove decl.
15712 (force_auto_save_soon): Declare only if SIGDANGER.
15713 * xdisp.c (redisplay_window): Simplify code, to make it more
15714 obvious that ignore_mouse_drag_p is not accessed if !defined
15715 USE_GTK && !defined HAVE_NS.
15716
93ea6e8f
PE
15717 * intervals.c: Make symbols static if they're not exported.
15718 (merge_properties_sticky, merge_interval_right, delete_interval):
15719 Now static.
15720 * intervals.h (merge_interval_right, delete_interval): Remove decls.
15721
77382fcc
PE
15722 * insdel.c: Make symbols static if they're not exported.
15723 However, leave prepare_to_modify_buffer alone. It's never
15724 called from outside this function, but that appears to be a bug.
15725 (combine_after_change_list, combine_after_change_buffer):
4889fc82 15726 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
15727 (adjust_after_replace_noundo): Remove; unused.
15728 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 15729 (signal_before_change): Remove decls.
77382fcc 15730
9306c32e
PE
15731 * indent.c (val_compute_motion, val_vmotion): Now static.
15732
cd44d2eb
PE
15733 * image.c: Make symbols static if they're not exported.
15734 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
15735 if USE_GTK.
15736 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
15737 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
15738
ad9a7a06
PE
15739 * fringe.c (standard_bitmaps): Now static.
15740 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
15741
81626931
PE
15742 * frame.c: Make symbols static if they're not exported.
15743 (x_report_frame_params, make_terminal_frame): Now static.
15744 (get_frame_param): Now static, unless HAVE_NS.
15745 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
15746 (x_get_resource_string): Remove; not used.
15747 * frame.h (make_terminal_frame, x_report_frame_params):
15748 (x_get_resource_string); Remove decls.
15749 (x_fullscreen_adjust): Declare only if WINDOWSNT.
15750 * lisp.h (get_frame_param): Declare only if HAVE_NS.
15751
239f9db9
PE
15752 * font.c, fontset.c: Make symbols static if they're not exported.
15753 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
15754 (FACE_SUITABLE_FOR_CHAR_P): Use it.
15755 * font.c (font_close_object): Now static.
15756 * font.h (font_close_object): Remove.
15757 * fontset.c (FONTSET_OBJLIST): Remove.
15758 (free_realized_fontset) #if-0 the body, which does nothing.
15759 (face_suitable_for_char_p): #if-0, as it's never called.
15760 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
15761 * xfaces.c (face_at_string_position):
15762 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
15763 since 0 is always ASCII.
15764
dfcf3579
PE
15765 * fns.c (weak_hash_tables): Now static.
15766
5045092b
PE
15767 * fileio.c: Make symbols static if they're not exported.
15768 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
15769 (Vwrite_region_annotation_buffers): Now static.
15770
57a96f5c
PE
15771 * eval.c: Make symbols static if they're not exported.
15772 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
15773 * lisp.h (backtrace_list): Remove decl.
15774
35f08c38
PE
15775 * emacs.c: Make symbols static if they're not exported.
15776 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
15777 (fatal_error_code, fatal_error_signal_hook, standard_args):
15778 Now static.
15779 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
15780 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
15781 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
15782 * lisp.h (fatal_error_signal_hook): Remove decl.
15783 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
15784
f44bd759
PE
15785 * editfns.c: Move a (normally-unused) function to its only use.
15786 * editfns.c, lisp.h (get_operating_system_release): Remove.
15787 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
15788 worth the hassle of breaking this out.
15789
b532497d
PE
15790 * xterm.c: Make symbols static if they're not exported.
15791 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
15792 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
15793 (x_destroy_window, x_delete_display):
15794 Now static.
15795 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
15796 (x_mouse_leave): Remove; unused.
15797 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
15798 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
15799 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
15800 Remove decls.
15801 (x_mouse_leave): Declare only if WINDOWSNT.
15802 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
15803 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
15804 USE_X_TOOLKIT.
15805
1675728f
PE
15806 * ftxfont.c: Make symbols static if they're not exported.
15807 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
15808 HAVE_FREETYPE.
15809 * font.h (ftxfont_driver): Likewise.
15810
e4cebfca
PE
15811 * xfns.c: Make symbols static if they're not exported.
15812 (x_last_font_name, x_display_info_for_name):
15813 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
15814 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
15815 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
15816 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
15817 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
15818 (last_show_tip_args): Now static.
15819 (xic_defaut_fontset, xic_create_fontsetname): Define only if
15820 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
15821 (x_screen_planes): Remove; unused.
15822 * dispextern.h (x_screen_planes): Remove decl.
15823
5bf46f05
PE
15824 * dispnew.c: Make symbols static if they're not exported.
15825 * dispextern.h (redraw_garbaged_frames, scrolling):
15826 (increment_row_positions): Remove.
15827 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
15828 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
15829 Now static.
15830 (redraw_garbaged_frames): Remove; unused.
15831
435f4c28
PE
15832 * xfaces.c: Make symbols static if they're not exported.
15833 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
15834 Remove decls.
15835 * xterm.h (defined_color): Remove decls.
15836 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
15837 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
15838 (menu_face_changed_default, defined_color, free_realized_face):
15839 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
15840 (ascii_face_of_lisp_face): Remove; unused.
15841
8524aef3
PE
15842 * xdisp.c: Make symbols static if they're not exported.
15843 * dispextern.h (scratch_glyph_row, window_box_edges):
15844 (glyph_to_pixel_coords, set_cursor_from_row):
15845 (get_next_display_element, set_iterator_to_next):
15846 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
15847 (show_mouse_face): Remove decls
15848 * frame.h (message_buf_print): Likewise.
15849 * lisp.h (pop_message, set_message, check_point_in_composition):
15850 Likewise.
15851 * xterm.h (set_vertical_scroll_bar): Likewise.
15852 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
15853 (message_buf_print, scratch_glyph_row, displayed_buffer):
15854 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
15855 (get_next_display_element, show_mouse_face, window_box_edges):
15856 (frame_to_window_pixel_xy, check_point_in_composition):
15857 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
15858 (glyph_to_pixel_coords): Remove; unused.
15859
16390cd2
PE
15860 * dired.c (file_name_completion): Now static.
15861
15862 * dbusbind.c (xd_in_read_queued_messages): Now static.
15863
a25f4dfa
PE
15864 * lisp.h (circular_list_error, FOREACH): Remove; unused.
15865 * data.c (circular_list_error): Remove.
15866
14a9c8df
PE
15867 * commands.h (last_point_position, last_point_position_buffer):
15868 (last_point_position_window): Remove decls.
15869 * keyboard.c: Make these variables static.
15870
04f2d78b
CB
15871 * coding.h (coding, code_convert_region, encode_coding_gap):
15872 Remove decls.
74ab6df5
PE
15873 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
15874 (iso_code_class, detect_coding, code_convert_region): Now static.
15875 (encode_coding_gap): Remove; unused.
15876
38dfbee1
PE
15877 * chartab.c (chartab_chars, chartab_bits): Now static.
15878
a2cb4e63
PE
15879 * charset.h (charset_iso_8859_1): Remove decl.
15880 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
15881 Now static.
15882
127198fd
PE
15883 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
15884 * ccl.c (Vccl_program_table): Now static.
15885 (check_ccl_update): Remove; unused.
15886
d85b608f
PE
15887 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
15888 * category.h: ... from here.
15889 * category.c (check_category_table, set_category_set): Now static.
15890
31cd66f3
PE
15891 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
15892 * lisp.h: Remove these decls.
15893
c358e587
PE
15894 * buffer.c (buffer_count): Remove unused var.
15895
e78aecca
PE
15896 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
15897 so that it's not optimized away.
15898 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
15899 * dispextern.h (bidi_dump_cached_states): Remove, since it's
15900 exported only to the debugger.
15901
e192d7d3 15902 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 15903 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 15904
92470028
PE
15905 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
15906 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
15907 was inaccessible from Lisp.
15908 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
15909 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
15910
244ed907
PE
15911 alloc.c: Import and export fewer symbols, and remove unused items.
15912 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
15913 is defined.
15914 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
15915 it's not optimized away by whole-program optimization.
15916 (message_enable_multibyte, free_misc): Remove.
15917 (catchlist, handlerlist, mark_backtrace):
15918 Declare only if BYTE_MARK_STACK.
15919 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
15920 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
15921 (message_enable_multibyte): Remove decl.
15922 (free_misc, interval_free_list, float_block, float_block_index):
15923 (n_float_blocks, float_free_list, cons_block, cons_block_index):
15924 (cons_free_list, last_marked_index):
15925 Now static.
15926 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
15927 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
15928 (mark_backtrace): Define only if BYTE_MARK_STACK.
15929 * xdisp.c (message_enable_multibyte): Now static.
15930
61c2b50e 15931 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
15932 This makes it easier for human readers (and static analyzers)
15933 to see whether these variables are used from other modules.
15934 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
15935 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
15936 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
15937 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
15938 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
15939 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
15940 * xmenu.c, xselect.c:
15941 Declare Q* vars static if they are not used in other modules.
15942 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
15943 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
15944 Remove decls of unexported vars.
15945 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
15946
95c82688
PE
15947 * lisp.h (DEFINE_FUNC): Make sname 'static'.
15948
16a97296
PE
15949 Make Emacs functions such as Fatom 'static' by default.
15950 This makes it easier for human readers (and static analyzers)
15951 to see whether these functions can be called from other modules.
15952 DEFUN now defines a static function. To make the function external
15953 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
15954 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
15955 (Finit_image_library):
16a97296
PE
15956 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
15957 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
15958 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
15959 Remove decls, since these functions are now static.
15960 (Funintern, Fget_internal_run_time): New decls, since these functions
15961 were already external.
95c82688 15962
16a97296
PE
15963 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
15964 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
15965 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
15966 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
15967 * keyboard.c, keymap.c, lread.c:
15968 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
15969 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
15970 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
15971 Mark functions with DEFUE instead of DEFUN,
15972 if they are used in other modules.
15973 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
15974 decls for now-static functions.
15975 * buffer.h (Fdelete_overlay): Remove decl.
15976 * callproc.c (Fgetenv_internal): Mark as internal.
15977 * composite.c (Fremove_list_of_text_properties): Remove decl.
15978 (Fcomposition_get_gstring): New forward static decl.
15979 * composite.h (Fcomposite_get_gstring): Remove decl.
15980 * dired.c (Ffile_attributes): New forward static decl.
15981 * doc.c (Fdocumntation_property): New forward static decl.
15982 * eval.c (Ffetch_bytecode): New forward static decl.
15983 (Funintern): Remove extern decl; now in .h file where it belongs.
15984 * fileio.c (Fmake_symbolic_link): New forward static decl.
15985 * image.c (Finit_image_library): New forward static decl.
15986 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
15987 * intervals.h (Fprevious_property_change):
15988 (Fremove_list_of_text_properties): Remove decls.
15989 * keyboard.c (Fthis_command_keys): Remove decl.
15990 (Fcommand_execute): New forward static decl.
15991 * keymap.c (Flookup_key): New forward static decl.
15992 (Fcopy_keymap): Now static.
15993 * keymap.h (Flookup_key): Remove decl.
15994 * process.c (Fget_process): New forward static decl.
15995 (Fprocess_datagram_address): Mark as internal.
15996 * syntax.c (Fsyntax_table_p): New forward static decl.
15997 (skip_chars): Remove duplicate decl.
15998 * textprop.c (Fprevious_property_change): New forward static decl.
15999 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
16000 Now internal.
16001 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
16002 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
16003
785bbd42
PE
16004 * editfns.c (Fformat): Remove unreachable code.
16005
8b913b57
AS
160062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
16007
16008 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
16009 change. (Bug#8496)
16010
a6744a35
EZ
160112011-04-13 Eli Zaretskii <eliz@gnu.org>
16012
16013 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
16014 when at ZV. (Bug#8487)
16015
e7974947
AS
160162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
16017
baad03f0
AS
16018 * charset.c (Fclear_charset_maps): Use xfree instead of free.
16019 (Bug#8437)
16020 * keyboard.c (parse_tool_bar_item): Likewise.
16021 * sound.c (sound_cleanup, alsa_close): Likewise.
16022 * termcap.c (tgetent): Likewise.
16023 * xfns.c (x_default_font_parameter): Likewise.
16024 * xsettings.c (read_and_apply_settings): Likewise.
16025
e7974947
AS
16026 * alloc.c (overrun_check_malloc, overrun_check_realloc)
16027 (overrun_check_free): Protoize.
16028
28272684
PE
160292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
16030
16031 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
16032 since callers should never pass a negative size.
16033 Change the signature to match that of plain 'read' and 'write'; see
16034 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
16035 * lisp.h: Update prototypes of emacs_write and emacs_read.
16036
11997c76
EZ
160372011-04-11 Eli Zaretskii <eliz@gnu.org>
16038
16039 * xdisp.c (redisplay_window): Don't try to determine the character
16040 position of the scroll margin if the window start point w->startp
e896f03c 16041 is outside the buffer's accessible region. (Bug#8468)
11997c76 16042
8a2cbd72
EZ
160432011-04-10 Eli Zaretskii <eliz@gnu.org>
16044
16045 Fix write-region and its subroutines for buffers > 2GB.
16046 * fileio.c (a_write, e_write): Modify declaration of arguments and
16047 local variables to support buffers larger than 2GB.
16048 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
16049
16050 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
16051 argument, local variables, and return value.
16052
16053 * lisp.h: Update prototypes of emacs_write and emacs_read.
16054
16055 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
16056
4073e537 160572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 16058
1ebfdcb6
PE
16059 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
16060
b2ded58d
PE
16061 Fix more problems found by GCC 4.6.0's static checks.
16062
7d66342c
PE
16063 * xdisp.c (vmessage): Use a better test for character truncation.
16064
bbf47d44
PE
16065 * charset.c (load_charset_map): <, not <=, for optimization,
16066 and to avoid potential problems with integer overflow.
9248994d 16067 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 16068 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 16069 * editfns.c (Fformat): Likewise.
1e69125e 16070 * syntax.c (skip_chars): Likewise.
3befa583 16071
e3019616
PE
16072 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
16073 This also lets GCC 4.6.0 generate slightly better loop code.
16074
becfa255
PE
16075 * callint.c (Fcall_interactively): <, not <=, for optimization.
16076 (Fcall_interactively): Count the number of arguments produced,
16077 not the number of arguments given. This is simpler and lets GCC
16078 4.6.0 generate slightly better code.
16079
dae0cd48
PE
16080 * ftfont.c: Distingish more carefully between FcChar8 and char.
16081 The previous code passed unsigned char * to a functions like
16082 strlen and xstrcasecmp that expect char *, which does not
16083 conform to the C standard.
16084 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
16085 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
16086 char * when the C standard requires it.
16087
76032d70
PE
16088 * keyboard.c (read_char): Remove unused var.
16089
eb3f1cc8
PE
16090 * eval.c: Port to Windows vsnprintf (Bug#8435).
16091 Include <limits.h>.
16092 (SIZE_MAX): Define if the headers do not.
16093 (verror): Do not give up if vsnprintf returns a negative count.
16094 Instead, grow the buffer. This ports to Windows vsnprintf, which
16095 does not conform to C99. Problem reported by Eli Zaretskii.
16096 Also, simplify the allocation scheme, by avoiding the need for
16097 calling realloc, and removing the ALLOCATED variable.
16098
70476b54
PE
16099 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
16100
12020a9e
PE
16101 Remove invocations of doprnt, as Emacs now uses vsnprintf.
16102 But keep the doprint source code for now, as we might revamp it
16103 and use it again (Bug#8435).
ea6c7ae6
PE
16104 * lisp.h (doprnt): Remove.
16105 * Makefile.in (base_obj): Remove doprnt.o.
16106 * deps.mk (doprnt.o): Remove.
16107
5fdb398c
PE
16108 error: Print 32- and 64-bit integers portably (Bug#8435).
16109 Without this change, on typical 64-bit hosts error ("...%d...", N)
16110 was used to print both 32- and 64-bit integers N, which relied on
16111 undefined behavior.
61bdb816 16112 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
16113 * lisp.h (error, verror): Mark as printf-like functions.
16114 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
16115 Report overflow in size calculations when allocating printf buffer.
16116 Do not truncate output string at its first null byte.
16117 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
16118 Truncate the output at a character boundary, since vsnprintf does not
16119 do that.
16120 * charset.c (check_iso_charset_parameter): Convert internal
16121 character to string before calling 'error', since %c now has the
16122 printf meaning.
16123 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
16124 overflow when computing char to be passed to 'error'. Do not
16125 pass Lisp_Object to 'error'; pass the integer instead.
16126 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
16127 formatted with plain %d.
16128
b189fa66
PE
16129 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
16130
bff87ef0
PE
16131 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
16132
7e2cac20
PE
16133 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
16134
ce4d90b5
PE
16135 * xterm.c (x_catch_errors): Remove duplicate declaration.
16136
266c9547
PE
16137 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
16138
79c49ad2
PE
16139 * xdisp.c, lisp.h (message_nolog): Remove; unused.
16140
368f4090
JM
161412011-04-10 Jim Meyering <meyering@redhat.com>
16142
16143 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
16144 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
16145 return ssize_t not "int", and use size_t as the buffer length.
16146 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
16147 * gnutls.h: Update declarations.
16148 * process.c (read_process_output): Use ssize_t, to match.
16149 (send_process): Likewise.
16150
a32d4040
CY
161512011-04-09 Chong Yidong <cyd@stupidchicken.com>
16152
16153 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
16154
8546720e 161552011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 16156
04f2d78b
CB
16157 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
16158 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 16159
8546720e
GM
16160 * xterm.c (handle_one_xevent):
16161 * xmenu.c (create_and_show_popup_menu):
16162 * xselect.c (x_decline_selection_request)
16163 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 16164
0a2f5c1a 161652011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
16166
16167 Fix some uses of `int' instead of EMACS_INT.
16168 * search.c (string_match_1, fast_string_match)
16169 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
16170 (scan_buffer, find_next_newline_no_quit)
16171 (find_before_next_newline, search_command, Freplace_match)
16172 (Fmatch_data): Make some `int' variables be EMACS_INT.
16173
16174 * xdisp.c (display_count_lines): 3rd argument and return value now
16175 EMACS_INT. All callers changed.
16176 (pint2hrstr): Last argument is now EMACS_INT.
16177
16178 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
16179 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
16180 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
16181 (decode_coding_utf_16, decode_coding_emacs_mule)
16182 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
16183 (decode_coding_ccl, decode_coding_charset)
16184 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
16185 (decode_coding_iso_2022, decode_coding_emacs_mule)
16186 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
16187 <char_offset, last_offset>: Declare EMACS_INT.
16188 (encode_coding_utf_8, encode_coding_utf_16)
16189 (encode_coding_emacs_mule, encode_invocation_designation)
16190 (encode_designation_at_bol, encode_coding_iso_2022)
16191 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
16192 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
16193 Declare EMACS_INT.
16194 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
16195 (encode_invocation_designation): Last argument P_NCHARS is now
16196 EMACS_INT.
16197 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
16198 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
16199
16200 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
16201 All users changed.
16202
16203 * ccl.c (Fccl_execute_on_string): Declare some variables
16204 EMACS_INT.
16205
8546720e 162062011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
16207
16208 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
16209
4e19a977
CS
162102011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
16211
16212 * process.c (Fformat_network_address): Doc fix.
16213
87302331
R
162142011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
16215
ee7683eb 16216 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 16217
cbb59342
CY
162182011-04-08 Chong Yidong <cyd@stupidchicken.com>
16219
16220 * keyboard.c (read_char): Call Lisp function help-form-show,
16221 instead of using internal_with_output_to_temp_buffer.
16222 (Qhelp_form_show): New var.
e0d38eeb 16223 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
16224
16225 * print.c (internal_with_output_to_temp_buffer): Function deleted.
16226
16227 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
16228
e67a13ab
CY
162292011-04-06 Chong Yidong <cyd@stupidchicken.com>
16230
04f2d78b
CB
16231 * process.c (Flist_processes): Remove to Lisp.
16232 (list_processes_1): Delete.
e67a13ab 16233
973f782d
EZ
162342011-04-06 Eli Zaretskii <eliz@gnu.org>
16235
7c106b1e
EZ
16236 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
16237
973f782d
EZ
16238 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
16239
41cf7d1a 162402011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 16241
ca23cc88
PE
16242 Fix more problems found by GCC 4.6.0's static checks.
16243
f390e2d5
PE
16244 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
16245
42eea0d0
PE
16246 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
16247
b69769da 16248 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 16249
f9541e84
PE
16250 * xdisp.c (vmessage): Mark as a printf-like function.
16251
13841b55
PE
16252 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
16253
c136c10f
PE
16254 * sound.c (sound_warning): Don't crash if arg contains a printf format.
16255
5e2d4a30
PE
16256 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
16257 printf-like functions.
16258 (tiff_load): Add casts to remove these marks before passing them
16259 to system-supplied API.
16260
583f48b9
PE
16261 * eval.c (Fsignal): Remove excess argument to 'fatal'.
16262
b25d760e
PE
16263 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
16264 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
16265 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
16266 directly, rather than having caller test rule sign. This avoids
16267 some unnecessary tests.
16268 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
16269 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
16270 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 16271
bc7b6697 16272 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 16273 (xfont_open): Avoid unnecessary tests.
bc7b6697 16274
27ccc379
PE
16275 * composite.c (composition_gstring_put_cache): Use unsigned integer.
16276
dcd5c89a
PE
16277 * composite.h, composite.c (composition_gstring_put_cache):
16278 Use EMACS_INT, not int, for length.
16279
b13a45c6
PE
16280 * composite.h (COMPOSITION_DECODE_REFS): New macro,
16281 breaking out part of COMPOSITION_DECODE_RULE.
16282 (COMPOSITION_DECODE_RULE): Use it.
16283 * composite.c (get_composition_id): Remove unused local vars,
16284 by using the new macro.
16285
1e792e4d
PE
16286 * textprop.c (set_text_properties_1): Change while to do-while,
16287 since the condition is always true at first.
16288
dc6c6455 16289 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
16290 (interval_deletion_adjustment): Return unsigned value.
16291 All uses changed.
dc6c6455 16292
aba7731a
PE
16293 * process.c (list_processes_1, create_pty, read_process_output):
16294 (exec_sentinel): Remove vars that were set but not used.
afd4052b 16295 (create_pty): Remove unnecessary "volatile"s.
bc57d757 16296 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 16297 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 16298 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 16299
fdfc4bf3
PE
16300 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
16301
fca8fe46 16302 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 16303 (update_syntax_table): Use unsigned instead of int.
fca8fe46 16304
06a0259a 16305 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 16306 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 16307 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 16308
e7b9e80f
PE
16309 * print.c (print_error_message): Avoid int overflow.
16310
56201685
PE
16311 * font.c (font_list_entities): Redo for clarity,
16312 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
16313
78834453 16314 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 16315 (font_score): Avoid potential overflow in diff calculation.
78834453 16316
0bc0b309 16317 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 16318 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 16319
e610eaca
PE
16320 * eval.c (funcall_lambda): Rename local to avoid shadowing.
16321
b895abce
PE
16322 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
16323 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
16324 can always succeed if overflow has undefined behavior.
16325
1f1d9321 16326 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 16327 (wordify): Omit three unnecessary tests.
1f1d9321 16328
c59478bc
PE
16329 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
16330 All callers changed. This avoids the need for an unused var.
16331
79b73827
PE
16332 * casefiddle.c (casify_region): Remove var that is set but not used.
16333
a4db5dfe
PE
16334 * dired.c (file_name_completion): Remove var that is set but not used.
16335
43aae36e
PE
16336 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
16337
2a47c44d 16338 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 16339 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 16340
a37c69bf
PE
16341 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
16342 Check for integer overflow on size calculations.
16343
328ab8e7
PE
16344 * buffer.c (Fprevious_overlay_change): Remove var that is set
16345 but not used.
16346
e5a2a5cb
PE
16347 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
16348 Remove vars that are set but not used.
8d84a6eb 16349 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 16350 (timer_check_2): Mark vars as initialized.
e5a2a5cb 16351
a60e5f68
PE
16352 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
16353
f661cb61 16354 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 16355 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 16356
f0397f5a
PE
16357 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
16358 that are set but not used.
16359
8664db06 16360 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 16361 if XCreateBitmapFromData fails (Bug#8410).
8664db06 16362
6abdaa4a
PE
16363 * xselect.c (x_get_local_selection, x_handle_property_notify):
16364 Remove vars that are set but not used.
16365
0ce7538d 16366 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 16367 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 16368
9ae848fc
PE
16369 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
16370 Remove var that is set but not used.
0b918413
PE
16371 (scroll_bar_windows_size): Now size_t, not int.
16372 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
16373 Check for overflow.
9ae848fc 16374
a5a62657
PE
16375 * xfaces.c (realize_named_face): Remove vars that are set but not used.
16376 (map_tty_color) [!defined MSDOS]: Likewise.
16377
5c5cdd39
PE
16378 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
16379
66ebf983
PE
16380 * coding.c: Remove vars that are set but not used.
16381 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
16382 All callers changed.
16383 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
16384 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
16385 (decode_coding_charset): Remove vars that are set but not used.
16386
1be4d761
PE
16387 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
16388 that is set but not used.
16389
47553fa8
PE
16390 * print.c (print_object): Remove var that is set but not used.
16391
1f7196bf 16392 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
16393 The gnulib version avoids calling malloc in the usual case,
16394 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
16395 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
16396 * filelock.c (current_lock_owner): Likewise.
16397 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
16398 * sysdep.c: Include allocator.h, careadlinkat.h.
16399 (emacs_no_realloc_allocator): New static constant.
16400 (emacs_readlink): New function.
fdb61804
PE
16401 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
16402 ../lib/careadlinkat.h.
d1fdcab7 16403
f84c17c7
SM
164042011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
16405
16406 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
16407 first non-nil return value).
16408
ef3862ad
JD
164092011-04-03 Jan Djärv <jan.h.d@swipnet.se>
16410
16411 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
16412 if not defined (Bug#8403).
16413
376a7006
JB
164142011-04-02 Juanma Barranquero <lekktu@gmail.com>
16415
16416 * xdisp.c (display_count_lines): Remove parameter `start',
16417 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16418 (get_char_face_and_encoding): Remove parameter `multibyte_p',
16419 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
16420 (fill_stretch_glyph_string): Remove parameters `row' and `area',
16421 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
16422 and thereabouts. All callers changed.
16423 (get_per_char_metric): Remove parameter `f', unused since
16424 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
16425
6ca3801d
JM
164262011-04-02 Jim Meyering <meyering@redhat.com>
16427
16428 do not dereference NULL upon failed strdup
16429 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
16430 (ns_get_family): Likewise.
16431
d8e2b5ba
JB
164322011-04-02 Juanma Barranquero <lekktu@gmail.com>
16433
16434 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
16435
8c74fcbd
JD
164362011-04-02 Jan Djärv <jan.h.d@swipnet.se>
16437
16438 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
16439 later (Bug#8403).
16440
7200d79c
SM
164412011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
16442
03408648 16443 Add lexical binding.
7200d79c 16444
03408648
SM
16445 * window.c (Ftemp_output_buffer_show): New fun.
16446 (Fsave_window_excursion):
16447 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
16448
16449 * lread.c (lisp_file_lexically_bound_p): New function.
16450 (Fload): Bind Qlexical_binding.
16451 (readevalloop): Remove `evalfun' arg.
16452 Bind Qinternal_interpreter_environment.
16453 (Feval_buffer): Bind Qlexical_binding.
16454 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
16455 Mark as dynamic.
16456 (syms_of_lread): Declare `lexical-binding'.
16457
16458 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
16459
16460 * keyboard.c (eval_dyn): New fun.
16461 (menu_item_eval_property): Use it.
ca105506
SM
16462
16463 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 16464
03408648
SM
16465 * fns.c (concat, mapcar1): Accept byte-code-functions.
16466
16467 * eval.c (Fsetq): Handle lexical vars.
16468 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
16469 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
16470 (FletX, Flet): Obey lexical binding.
16471 (Fcommandp): Handle closures.
16472 (Feval): New `lexical' arg.
16473 (eval_sub): New function extracted from Feval. Use it almost
16474 everywhere where Feval was used. Look up vars in lexical env.
16475 Handle closures.
16476 (Ffunctionp): Move from subr.el.
16477 (Ffuncall): Handle closures.
16478 (apply_lambda): Remove `eval_flags'.
16479 (funcall_lambda): Handle closures and new byte-code-functions.
16480 (Fspecial_variable_p): New function.
16481 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
16482 but without exporting it to Lisp.
23aba0ea 16483
23aba0ea 16484 * doc.c (Fdocumentation, store_function_docstring):
03408648 16485 * data.c (Finteractive_form): Handle closures.
23aba0ea 16486
03408648
SM
16487 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
16488 interactive spec.
ba83908c 16489
04f2d78b
CB
16490 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
16491 New byte-codes.
03408648
SM
16492 (exec_byte_code): New function extracted from Fbyte_code to handle new
16493 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 16494
03408648 16495 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 16496
03408648 16497 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 16498
e2abce01
JB
164992011-03-31 Juanma Barranquero <lekktu@gmail.com>
16500
16501 * xdisp.c (redisplay_internal): Fix prototype.
16502
63696a73 165032011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 16504
63696a73 16505 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
16506 (try_scrolling): Use it when setting scroll_limit.
16507 Limit scrolling to 100 screen lines.
63696a73
EZ
16508 (redisplay_window): Even when falling back on "recentering",
16509 position point in the window according to scroll-conservatively,
16510 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
16511
16512 (try_scrolling): When point is above the window, allow searching
16513 as far as scroll_max, or one screenful, to compute vertical
16514 distance from PT to the scroll margin position. This prevents
16515 try_scrolling from unnecessarily failing when
16516 scroll-conservatively is set to a value slightly larger than the
16517 window height. Clean up the case of PT below the margin at bottom
16518 of window: scroll_max can no longer be INT_MAX. When aggressive
16519 scrolling is in use, don't let point enter the opposite scroll
16520 margin as result of the scroll.
16521 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
16522 threshold of 100 lines for never-recentering scrolling.
16523
e4cc2dfc
JB
165242011-03-31 Juanma Barranquero <lekktu@gmail.com>
16525
16526 * dispextern.h (move_it_by_lines):
16527 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
16528 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
16529 (message_log_check_duplicate): Remove parameters `prev_bol' and
16530 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16531 (redisplay_internal): Remove parameter `preserve_echo_area',
16532 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
16533
16534 * indent.c (Fvertical_motion):
16535 * window.c (window_scroll_pixel_based, Frecenter):
16536 Don't pass `need_y_p' to `move_it_by_lines'.
16537
1c470562
SM
165382011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
16539
44f230aa
SM
16540 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
16541 steal a few bits to be more compact.
16542 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
16543 Remove unneeded casts.
16544
1c470562
SM
16545 * bytecode.c (Fbyte_code): CAR and CDR can GC.
16546
888adce9
ZK
165472011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
16548
16549 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
16550 binding" message (bug#7967).
16551
f838ed7b
PE
165522011-03-30 Paul Eggert <eggert@cs.ucla.edu>
16553
77861b95
PE
16554 Fix more problems found by GCC 4.6.0's static checks.
16555
de6dbc14
PE
16556 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
16557 Remove unused local var.
16558
f838ed7b
PE
16559 * editfns.c (Fmessage_box): Remove unused local var.
16560
792c7b2b
PE
16561 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
16562 (note_mode_line_or_margin_highlight, note_mouse_highlight):
16563 Omit unused local vars.
c499e557 16564 * window.c (shrink_windows): Omit unused local var.
b01a1c29 16565 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
16566 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
16567 Omit unused local var.
16568
ba0165e1
PE
16569 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
16570 Don't assume string length fits in int.
32ad8845 16571 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 16572 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 16573
3c59b4c9
PE
16574 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
16575 instead of alloca (Bug#8344).
16576
a3eed478 16577 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 16578 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 16579
eb4d412d
PE
16580 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
16581
1658b401
PE
16582 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
16583 concerns.
16584
16585 * term.c (produce_glyphless_glyph): Remove unnecessary test.
16586
16587 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 16588
9a2c6e05
PE
16589 * keyboard.c (syms_of_keyboard): Use the same style as later
16590 in this function when indexing through an array. This also
16591 works around GCC bug 48267.
16592
03d0a109
PE
16593 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
16594
44f730c8
PE
16595 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
16596
fe75f926
PE
16597 * chartab.c (sub_char_table_ref_and_range): Redo for slight
16598 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
16599
ffa8c828
PE
16600 * keyboard.c, keyboard.h (num_input_events): Now size_t.
16601 This avoids undefined behavior on integer overflow, and is a bit
16602 more convenient anyway since it is compared to a size_t variable.
16603
c5101a77
PE
16604 Variadic C functions now count arguments with size_t, not int.
16605 This avoids an unnecessary limitation on 64-bit machines, which
16606 caused (substring ...) to crash on large vectors (Bug#8344).
16607 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
16608 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 16609 All variadic functions and their callers changed accordingly.
c5101a77
PE
16610 (struct gcpro.nvars): Now size_t, not int. All uses changed.
16611 * data.c (arith_driver, float_arith_driver): Likewise.
16612 * editfns.c (general_insert_function): Likewise.
16613 * eval.c (struct backtrace.nargs, interactive_p)
16614 (internal_condition_case_n, run_hook_with_args, apply_lambda)
16615 (funcall_lambda, mark_backtrace): Likewise.
16616 * fns.c (concat): Likewise.
16617 * frame.c (x_set_frame_parameters): Likewise.
16618 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
16619 0 if not found, not -1. All callers changed.
16620
dd3f25f7
PE
16621 * alloc.c (garbage_collect): Don't assume stack size fits in int.
16622 (stack_copy_size): Now size_t, not int.
16623 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
16624
461c2ab9
JB
166252011-03-28 Juanma Barranquero <lekktu@gmail.com>
16626
16627 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
16628 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16629 All callers changed.
16630
16631 * lisp.h (multibyte_char_to_unibyte):
16632 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
16633 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16634 * character.h (CHAR_TO_BYTE8):
16635 * cmds.c (internal_self_insert):
16636 * editfns.c (general_insert_function):
16637 * keymap.c (push_key_description):
16638 * search.c (Freplace_match):
16639 * xdisp.c (message_dolog, set_message_1): All callers changed.
16640
f6d62986
SM
166412011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
16642
16643 * keyboard.c (safe_run_hook_funcall): New function.
16644 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
16645 don't set the hook to nil, but remove the offending function instead.
16646 (Qcommand_hook_internal): Remove, unused.
16647 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
16648 Vcommand_hook_internal.
16649
16650 * eval.c (enum run_hooks_condition): Remove.
16651 (funcall_nil, funcall_not): New functions.
16652 (run_hook_with_args): Call each function through a `funcall' argument.
16653 Remove `cond' argument, now redundant.
16654 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
16655 (Frun_hook_with_args_until_failure): Adjust accordingly.
16656 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
16657
1db5b1ad
JB
166582011-03-28 Juanma Barranquero <lekktu@gmail.com>
16659
16660 * dispextern.h (string_buffer_position): Remove declaration.
16661
16662 * print.c (strout): Remove parameter `multibyte', unused since
16663 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
16664
16665 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
16666 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
16667 All callers changed.
16668
16669 * w32.c (_wsa_errlist): Use braces for struct initializers.
16670
16671 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
16672 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
16673 All callers changed.
16674 (string_buffer_position): Likewise. Also, make static (it's never
16675 used outside xdisp.c).
16676 (cursor_row_p): Remove parameter `w', unused since
16677 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
16678 (decode_mode_spec): Remove parameter `precision', introduced during
16679 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
16680 All callers changed.
16681
5ffb62aa
JD
166822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16683
16684 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
16685
461c2ab9 166862011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
16687
16688 * nsterm.m (ns_menu_bar_is_hidden): New variable.
16689 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
16690 (ns_update_auto_hide_menu_bar): New functions.
16691 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
16692 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
16693 ns_constrain_all_frames.
16694 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
16695 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
16696
5c380ffb
JD
166972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16698
16699 * nsmenu.m (runDialogAt): Remove argument to timer_check.
16700
9af30bdf
GM
167012011-03-27 Glenn Morris <rgm@gnu.org>
16702
16703 * syssignal.h: Replace RETSIGTYPE with void.
16704 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
16705 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
16706 Replace SIGTYPE with void everywhere.
16707 * s/usg5-4-common.h (SIGTYPE): Remove definition.
16708 * s/template.h (SIGTYPE): Remove commented out definition.
16709
e2abce01
JB
167102011-03-26 Eli Zaretskii <eliz@gnu.org>
16711
16712 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
16713 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
16714
f868cd8a
JB
167152011-03-26 Juanma Barranquero <lekktu@gmail.com>
16716
59eb0929
JB
16717 * w32.c (read_unc_volume): Use parameter `henum', instead of
16718 global variable `wget_enum_handle'.
16719
16720 * keymap.c (describe_vector): Remove parameters `indices' and
16721 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
16722 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
16723
f868cd8a
JB
16724 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
16725
16726 * keyboard.c (timer_check): Remove parameter `do_it_now',
16727 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
16728 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
16729 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
16730
16731 * keyboard.c (read_char):
16732 * w32menu.c (w32_menu_display_help):
16733 * xmenu.c (show_help_event, menu_help_callback):
16734 Adjust calls to `show_help_echo'.
16735
16736 * gtkutil.c (xg_maybe_add_timer):
16737 * keyboard.c (readable_events):
16738 * process.c (wait_reading_process_output):
16739 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
16740
16741 * insdel.c (adjust_markers_gap_motion):
16742 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
16743 (gap_left, gap_right): Don't call it.
16744
2ecf6fdb
CY
167452011-03-25 Chong Yidong <cyd@stupidchicken.com>
16746
16747 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
16748 incurred during fontification.
16749
6b1f9ba4
JB
167502011-03-25 Juanma Barranquero <lekktu@gmail.com>
16751
16752 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
16753 (DEFVAR_PER_BUFFER): Don't pass it.
16754
16755 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
16756 (scrolling_window): Don't pass it.
16757
0f4a96b5
JB
167582011-03-25 Juanma Barranquero <lekktu@gmail.com>
16759
16760 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
16761
16762 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
16763 and `suffix'.
16764 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
16765 of variables specific to SELinux and computation of `encoded_absname'.
16766
16767 * image.c (XPutPixel): Remove unused variable `height'.
16768
16769 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
16770
16771 * unexw32.c (get_section_info): Remove unused variable `section'.
16772
16773 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
16774 (system_process_attributes): Remove unused variable `sess'.
16775 (sys_read): Remove unused variable `err'.
16776
16777 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
16778 (w32_wnd_proc): Remove unused variable `isdead'.
16779 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
16780 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
16781 (x_create_tip_frame): Remove unused variable `tem'.
16782
16783 * w32inevt.c (w32_console_read_socket):
16784 Remove unused variable `no_events'.
16785
16786 * w32term.c (x_draw_composite_glyph_string_foreground):
16787 Remove unused variable `width'.
16788
1149507c
JB
167892011-03-24 Juanma Barranquero <lekktu@gmail.com>
16790
16791 * w32term.c (x_set_glyph_string_clipping):
16792 Don't pass uninitialized region to CombineRgn.
16793
9c88f339
JB
167942011-03-23 Juanma Barranquero <lekktu@gmail.com>
16795
16796 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
16797 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
16798 (Fx_close_connection): Remove unused variable `i'.
16799
16800 * w32font.c (w32font_draw): Return number of glyphs.
16801 (w32font_open_internal): Remove unused variable `i'.
16802 (w32font_driver): Add missing initializer.
16803
16804 * w32menu.c (utf8to16): Remove unused variable `utf16'.
16805 (fill_in_menu): Remove unused variable `items_added'.
16806
16807 * w32term.c (last_mouse_press_frame): Remove static global variable.
16808 (w32_clip_to_row): Remove unused variable `f'.
16809 (x_delete_terminal): Remove unused variable `i'.
16810
16811 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
16812 (NOTHING): Remove unused static global variable.
16813 (uniscribe_check_otf): Remove unused variable `table'.
16814 (uniscribe_font_driver): Add missing initializers.
16815
dee091a3
JD
168162011-03-23 Julien Danjou <julien@danjou.info>
16817
16818 * term.c (Fsuspend_tty, Fresume_tty):
16819 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
16820 * window.c (temp_output_buffer_show):
16821 * insdel.c (signal_before_change):
16822 * frame.c (Fhandle_switch_frame):
16823 * fileio.c (Fdo_auto_save):
16824 * emacs.c (Fkill_emacs):
16825 * editfns.c (save_excursion_restore):
16826 * cmds.c (internal_self_insert):
16827 * callint.c (Fcall_interactively):
16828 * buffer.c (Fkill_all_local_variables):
16829 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
16830 Use Frun_hooks.
0f4a96b5 16831 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 16832 unconditionally since it does the check itself.
dee091a3 16833
2c520ab5 168342011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 16835
c9c49752
PE
16836 Fix more problems found by GCC 4.5.2's static checks.
16837
8abc3f12
PE
16838 * coding.c (encode_coding_raw_text): Avoid unnecessary test
16839 the first time through the loop, since we know p0 < p1 then.
16840 This also avoids a gcc -Wstrict-overflow warning.
16841
a2d26660
PE
16842 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
16843 leading to a memory leak, possible in functions like
16844 load_charset_map_from_file that can allocate an unbounded number
b12ef411 16845 of objects (Bug#8318).
a2d26660 16846
916c72e9
PE
16847 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
16848 that could (at least in theory) be that large.
16849
19ab8a18
PE
16850 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
16851 This is less likely to overflow, and avoids undefined behavior if
16852 overflow does occur. All callers changed. Use strtoul to scan
16853 for the unsigned long integer.
b7cbbd6f
PE
16854 (pint2hrstr): Simplify and tune code slightly.
16855 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 16856
f0641eff
PE
16857 * scroll.c (do_scrolling): Work around GCC bug 48228.
16858 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
16859
7f650bb9
PE
16860 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
16861 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
16862 (validate_x_resource_name): Simplify count usage.
16863 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 16864
37dd57d1
PE
16865 * fileio.c (Fcopy_file): Report error if fchown or fchmod
16866 fail (Bug#8306).
81e56e61 16867
699979fc 16868 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 16869
401bf9b4
PE
16870 * process.c (Fmake_network_process): Use socklen_t, not int,
16871 where POSIX says socklen_t is required in portable programs.
16872 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 16873 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
16874 (Fmake_network_process, server_accept_connection):
16875 (wait_reading_process_output, read_process_output):
16876 Likewise.
16877
b93aacde
PE
16878 * process.c: Rename or move locals to avoid shadowing.
16879 (list_processes_1, Fmake_network_process):
16880 (read_process_output_error_handler, exec_sentinel_error_handler):
16881 Rename or move locals.
4dc343ee 16882 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 16883 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 16884 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 16885 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 16886 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 16887
af8a867c 16888 Make tparam.h and terminfo.c consistent.
44f230aa
SM
16889 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
16890 Include tparam.h instead, since it declares them.
af8a867c
PE
16891 * cm.h (PC): Remove extern decl; tparam.h now does this.
16892 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
16893 * terminfo.c: Include tparam.h, to check interfaces.
16894 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
16895 (tparam): Adjust signature to match interface in tparam.h;
16896 this removes some undefined behavior. Check that outstring and len
16897 are zero, which they always are with Emacs.
16898 * tparam.h (PC, BC, UP): New extern decls.
16899
0248044d 16900 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 16901 (xftfont_open): Rename locals to avoid shadowing.
0248044d 16902
8ff096c1 16903 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
16904 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
16905 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 16906 (ftfont_list): Remove unused local.
49eaafba
PE
16907 (get_adstyle_property, ftfont_pattern_entity):
16908 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
16909 Rename locals to avoid shadowing.
8ff096c1 16910
e2be39f6
PE
16911 * xfont.c (xfont_list_family): Mark var as initialized.
16912
c9735e30
PE
16913 * xml.c (make_dom): Now static.
16914
8f5201ae
PE
16915 * composite.c (composition_compute_stop_pos): Rename local to
16916 avoid shadowing.
b246f932
PE
16917 (composition_reseat_it): Remove unused locals.
16918 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 16919 (composition_update_it): Mark var as initialized.
11b61122
PE
16920 (find_automatic_composition): Mark vars as initialized,
16921 with a FIXME (Bug#8290).
8f5201ae 16922
760fbc2c
PE
16923 character.h: Rename locals to avoid shadowing.
16924 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
16925 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
16926 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
16927 (BUF_DEC_POS): Be more systematic about renaming local temporaries
16928 to avoid shadowing.
16929
ff08eb85
PE
16930 * textprop.c (property_change_between_p): Remove; unused.
16931
fc7bf025
PE
16932 * intervals.c (interval_start_pos): Now static.
16933
235d7abc
PE
16934 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
16935
44f230aa
SM
16936 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
16937 Rename locals to avoid shadowing.
3e7d6594 16938
50060332
PE
16939 * sound.c (wav_play, au_play, Fplay_sound_internal):
16940 Fix pointer signedness.
d01f234b 16941 (alsa_choose_format): Remove unused local var.
c83b8872
PE
16942 (wav_play): Initialize a variable to 0, to prevent undefined
16943 behavior (Bug#8278).
50060332 16944
c4fc4e30
PE
16945 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
16946
918436ed
PE
16947 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
16948
c939f91b
PE
16949 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
16950 clobbering (Bug#8298).
b9c7f648
PE
16951 * sysdep.c (sys_subshell): Likewise.
16952 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 16953
6bd8c144
PE
16954 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
16955 This should get cleaned up, so that child_setup has the
16956 same signature on all platforms.
16957
7710357c 16958 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 16959 (relocate_fd): Rename locals to avoid shadowing.
7710357c 16960
c59da222
CY
169612011-03-22 Chong Yidong <cyd@stupidchicken.com>
16962
16963 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
16964 not to be necessary, and produces flickering.
16965
66b87493
GM
169662011-03-20 Glenn Morris <rgm@gnu.org>
16967
16968 * config.in: Remove file.
16969
45b6f6d5
JB
169702011-03-20 Juanma Barranquero <lekktu@gmail.com>
16971
16972 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
16973 are now in src/globals.h.
16974 (syms_of_minibuf): Remove spurious & from previous change.
16975
cd394be1 169762011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
16977
16978 * minibuf.c (completing-read-function): New variable.
16979 (completing-read-default): Rename from completing-read.
16980 (completing-read): Call completing-read-function.
16981
b14e3e21
CY
169822011-03-19 Juanma Barranquero <lekktu@gmail.com>
16983
16984 * xfaces.c (Fx_load_color_file):
16985 Read color file from absolute filename (bug#8250).
16986
f2b726e6
JB
169872011-03-19 Juanma Barranquero <lekktu@gmail.com>
16988
16989 * makefile.w32-in: Update dependencies.
16990
09f6ff02
EZ
169912011-03-17 Eli Zaretskii <eliz@gnu.org>
16992
16993 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
16994
29a6015a
PE
169952011-03-17 Paul Eggert <eggert@cs.ucla.edu>
16996
a3a6c54e
PE
16997 Fix more problems found by GCC 4.5.2's static checks.
16998
b766f867
PE
16999 * process.c (make_serial_process_unwind, send_process_trap):
17000 (sigchld_handler): Now static.
17001
be02381c
PE
17002 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
17003 That way, the code declares only the vars that it needs.
17004 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
17005 * s/cygwin.h (PTY_ITERATION): Likewise.
17006 * s/darwin.h (PTY_ITERATION): Likewise.
17007 * s/gnu-linux.h (PTY_ITERATION): Likewise.
17008
57048744
PE
17009 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
17010 * process.c (allocate_pty): Don't declare stb unless it's needed.
17011
7914961c 17012 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
17013 (CONSTANTLIM): Remove; unused.
17014 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
17015 Define only if needed.
7914961c 17016
b3967b18
PE
17017 * unexelf.c (unexec): Name an expression,
17018 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
17019 Use a different way to cause a compilation error if anyone uses
17020 n rather than nn, a way that does not involve shadowing.
73366a00 17021 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 17022
29a6015a
PE
17023 * deps.mk (unexalpha.o): Remove; unused.
17024
43cfc33e 17025 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 17026 * unexec.h: New file.
ce701a33
PE
17027 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
17028 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
17029 Depend on unexec.h.
17030 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
17031 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
17032 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 17033 Change as necessary to match prototype in unexec.h.
ce701a33 17034
01f44d5a
PE
17035 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
17036 shadowing.
4f63c6bb 17037 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 17038
a6670b0b
PE
17039 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
17040 Rename locals to avoid shadowing.
17041
cef2010d 17042 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 17043 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 17044
d4d7173a
PE
17045 * print.c (Fredirect_debugging_output): Fix pointer signedess.
17046
f08b802a
PE
17047 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
17048 warning when compiling print.c.
17049
3ddb0639
PE
17050 * font.c (font_unparse_fcname): Abort in an "impossible" situation
17051 instead of using an uninitialized var.
5ad03b97 17052 (font_sort_entities): Mark var as initialized.
3ddb0639 17053
170a2692
PE
17054 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
17055
e663c700
PE
17056 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
17057 pointers to constants.
89bc529a 17058 (font_parse_fcname): Remove unused vars.
7b81e2d0 17059 (font_delete_unmatched): Now static.
ea838e10 17060 (font_get_spec): Remove; unused.
13a547c6
PE
17061 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
17062 (font_update_drivers, Ffont_get_glyphs, font_add_log):
17063 Rename or move locals to avoid shadowing.
e663c700 17064
2a80c887 17065 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 17066 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 17067
1384fa33 17068 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 17069 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 17070
8b2c52e9
PE
17071 * alloc.c (mark_backtrace): Move decl from here ...
17072 * lisp.h: ... to here, so that it can be checked.
17073
475545b5 17074 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 17075 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
17076 (lisp_indirect_variable): Name an expression,
17077 to avoid gcc -Wbad-function-cast warning.
1faed8ae 17078 (Fdefvar): Rename locals to avoid shadowing.
475545b5 17079
b1349114 17080 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 17081 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 17082 Use const pointer when appropriate.
b1349114 17083
a2928364
PE
17084 * lisp.h (get_system_name, get_operating_system_release):
17085 Move decls here, to check interfaces.
17086 * process.c (get_operating_system_release): Move decl to lisp.h.
17087 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
17088 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
17089 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
17090 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
17091 (Fformat_time_string, Fencode_time, Finsert_char):
17092 (Ftranslate_region_internal, Fformat):
17093 Rename or remove local vars to avoid shadowing.
9710023e 17094 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 17095
a415e694
PE
17096 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
17097 avoid shadowing.
17098
8ef4622d
PE
17099 * lisp.h (eassert): Check that the argument compiles, even if
17100 ENABLE_CHECKING is not defined.
17101
946f9a5b
PE
17102 * data.c (Findirect_variable): Name an expression, to avoid
17103 gcc -Wbad-function-cast warning.
112396d6 17104 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 17105 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
17106 (Fmake_variable_buffer_local, Fmake_local_variable):
17107 Mark variables as initialized.
52746918 17108 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 17109
e5aab7e7 17110 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
17111 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
17112 Rename locals to avoid shadowing.
dff45157
PE
17113 (mark_stack): Move local variables into the #ifdef region where
17114 they're used.
7bc26fdb
PE
17115 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
17116 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
17117 needed otherwise.
17118 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
17119 (GC_STRING_CHARS): Remove; not used.
d40d4be1 17120 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 17121
e5aab7e7
PE
17122 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
17123 avoids undefined behavior in theory.
17124
4da60324
PE
17125 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
17126
88043301
PE
17127 Use functions, not macros, for up- and down-casing (Bug#8254).
17128 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17129 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
17130 to use the following functions instead of these macros.
17131 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
17132 EMACS_INT, since callers assume the returned value fits in int.
17133 (upcase1): Likewise, for UPCASE_TABLE.
17134 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 17135 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 17136 the race-condition problem in the old DOWNCASE.
88043301 17137
19ed5445
PE
17138 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
17139 Rename locals to avoid shadowing.
17140 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
17141 (regex_compile, re_search_2, re_match_2_internal):
17142 Remove unused local vars.
952db0d7
PE
17143 (FREE_VAR): Rewrite so as not to use empty "else",
17144 which gcc can warn about.
da053e48 17145 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
17146 (RETALLOC_IF): Define only if needed.
17147 (WORDCHAR_P): Likewise. This one is never needed, but is used
17148 only in a comment talking about a compiler bug, so put inside
17149 the #if 0 of that comment.
17150 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
17151 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
17152 Remove; unused.
19ed5445 17153
1f3561e4 17154 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
17155 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
17156 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 17157
ded6f8f7
PE
17158 * search.c (simple_search): Remove unused var.
17159
dbd37a95
PE
17160 * dired.c (compile_pattern): Move decl from here ...
17161 * lisp.h: ... to here, so that it can be checked.
17162 (struct re_registers): New forward decl.
17163
7e47afad
PE
17164 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
17165
85f24f61
PE
17166 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
17167 All uses changed.
17168 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
17169 Rename locals to avoid shadowing.
5671df8f 17170 (Fvertical_motion): Mark locals as initialized.
85f24f61 17171
181aa2be 17172 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 17173 (casify_region): Mark local as initialized.
181aa2be 17174
930d429c
PE
17175 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
17176
7082eac6
PE
17177 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
17178 New macros, so that the caller can use some names other than
17179 gcpro1, gcpro2, etc.
17180 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
17181 of the new macros.
17182 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
17183 argument, for consistency with GCPRO2_VAR, etc: it is now the
17184 prefix of the variable, not the variable itself. All uses
17185 changed.
38b2c076
PE
17186 * dired.c (directory_files_internal, file_name_completion):
17187 Rename locals to avoid shadowing.
17188
15206ed9
PE
17189 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
17190 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
17191 dired.c's scmp function, had undefined behavior.
17192 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17193 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
17194 * buffer.h: ... to here, because these macros use current_buffer,
17195 and the new implementation with inline functions needs to have
17196 current_buffer in scope now, rather than later when the macros
17197 are used.
17198 (downcase, upcase1): New static inline functions.
17199 (DOWNCASE, UPCASE1): Reimplement using these functions.
17200 This avoids undefined behavior in expressions like
17201 DOWNCASE (x) == DOWNCASE (y), which previously suffered
17202 from race conditions in accessing the global variables
17203 case_temp1 and case_temp2.
17204 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
17205 * lisp.h (case_temp1, case_temp2): Remove their decls.
17206 * character.h (ASCII_CHAR_P): Move from here ...
17207 * lisp.h: ... to here, so that the inline functions mentioned
17208 above can use them.
17209
4a6bea26
PE
17210 * dired.c (directory_files_internal_unwind): Now static.
17211
f14b7e14
PE
17212 * fileio.c (file_name_as_directory, directory_file_name):
17213 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
17214 Now static.
2893f146
PE
17215 (file_name_as_directory): Use const pointers when appropriate.
17216 (Fexpand_file_name): Likewise. In particular, newdir might
17217 point at constant storage, so make it a const pointer.
fd4ead52 17218 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
17219 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
17220 signedness issues.
f839df0c
PE
17221 (Fset_file_times, Finsert_file_contents, auto_save_error):
17222 Rename locals to avoid shadowing.
f14b7e14 17223
5716756e 17224 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
17225 (Ftry_completion, Fall_completions): Rename or remove locals
17226 to avoid shadowing.
5716756e 17227
b4c3046a
PE
17228 * marker.c (bytepos_to_charpos): Remove; unused.
17229
b45db522
PE
17230 * lisp.h (verify_bytepos, count_markers): New decls,
17231 so that gcc does not warn that these functions aren't declared.
17232
85876d07
PE
17233 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
17234 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 17235 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 17236 (copy_text): Remove unused local var.
85876d07 17237
03d78a21 17238 * filelock.c (within_one_second): Now static.
b3dd38ab 17239 (lock_file_1): Rename local to avoid shadowing.
03d78a21 17240
5df8f01b
PE
17241 * buffer.c (fix_overlays_before): Mark locals as initialized.
17242 (fix_start_end_in_overlays): Likewise. This function should be
17243 simplified by using pointers-to-pointers, but that's a different
17244 matter.
b1d876f1 17245 (switch_to_buffer_1): Now static.
8f54f30a
PE
17246 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
17247 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 17248
a70072c9 17249 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 17250 Fix pointer signedness issue.
edced198
PE
17251 (sys_subshell): Mark local as volatile if checking for lint,
17252 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 17253 (MAXPATHLEN): Define only if needed.
a70072c9 17254
a0977c44
PE
17255 * process.c (serial_open, serial_configure): Move decls from here ...
17256 * systty.h: ... to here, so that they can be checked.
17257
a884fdcc
PE
17258 * fns.c (get_random, seed_random): Move extern decls from here ...
17259 * lisp.h: ... to here, so that they can be checked.
17260
604efe86 17261 * sysdep.c (reset_io): Now static.
b8950c94 17262 (wait_for_termination_signal): Remove; unused.
604efe86 17263
38fc62d9
PE
17264 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
17265 (copy_keymap_item, append_key, push_text_char_description):
17266 Now static.
1004a21a 17267 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 17268 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
17269 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
17270 (describe_map_tree):
17271 Rename locals to avoid shadowing.
38fc62d9 17272
2f2650da
PE
17273 * keyboard.c: Declare functions static if they are not used elsewhere.
17274 (echo_char, echo_dash, cmd_error, top_level_2):
17275 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
17276 (read_char, kbd_buffer_get_event, make_lispy_position):
17277 (make_lispy_event, make_lispy_movement, apply_modifiers):
17278 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
17279 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
17280 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 17281 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 17282 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 17283
a053e86c 17284 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
17285 (mark_kboards): Move decl here ...
17286 * alloc.c (mark_kboards): ... from here.
a053e86c 17287
4752793e
PE
17288 * lisp.h (force_auto_save_soon): New decl.
17289
74f10ca7 17290 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
17291 (DEFINE_DUMMY_FUNCTION): New macro.
17292 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
17293 Use it.
c03cd23f
PE
17294 (main): Add casts to avoid warnings
17295 if GCC considers string literals to be constants.
74f10ca7 17296
022e70d4
PE
17297 * lisp.h (fatal_error_signal): Add decl, since it's exported.
17298
59d6fe83
PE
17299 * dbusbind.c: Pointer signedness fixes.
17300 (xd_signature, xd_append_arg, xd_initialize):
17301 (Fdbus_call_method, Fdbus_call_method_asynchronously):
17302 (Fdbus_method_return_internal, Fdbus_method_error_internal):
17303 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
17304 (Fdbus_register_signal): Use SSDATA when the context wants char *.
17305
78320123
PE
17306 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
17307 if GCC considers string literals to be constants.
49cebcca 17308 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 17309
35ac2a97
SM
173102011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
17311
fb103ca9
SM
17312 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
17313 (print_preprocess, print_object): New macro to fix last change.
17314
35ac2a97
SM
17315 * print.c (print_preprocess): Don't forget font objects.
17316
62973b41
JB
173172011-03-16 Juanma Barranquero <lekktu@gmail.com>
17318
17319 * emacs.c (USAGE3): Doc fixes.
17320
0e48bb22
AS
173212011-03-15 Andreas Schwab <schwab@linux-m68k.org>
17322
17323 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
17324 structure.
17325
7684e57b
JB
173262011-03-14 Juanma Barranquero <lekktu@gmail.com>
17327
17328 * lisp.h (VWindow_system, Qfile_name_history):
17329 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
17330 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
17331 (w32_system_caret_x, w32_system_caret_y): Declare extern.
17332
17333 * w32select.c: Don't #include "keyboard.h".
c96bbc66 17334 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
17335
17336 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
17337 * w32console.c (detect_input_pending, read_input_pending)
17338 (encode_terminal_code):
17339 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
17340 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
17341 (w32_system_caret_y, Qfile_name_history):
17342 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
17343 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
17344 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
17345 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
17346 * w32proc.c (Qlocal, report_file_error):
17347 * w32term.c (Vwindow_system, updating_frame):
17348 * w32uniscribe.c (initialized, uniscribe_font_driver):
17349 Remove unneeded extern declarations.
17350
2aa46d6c
CY
173512011-03-14 Chong Yidong <cyd@stupidchicken.com>
17352
c96bbc66 17353 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 17354
cffc6f3b
CY
173552011-03-13 Chong Yidong <cyd@stupidchicken.com>
17356
17357 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
17358 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
17359 These macros can no longer be used for assignment.
17360
44f230aa
SM
17361 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
17362 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
17363 (record_buffer_markers, fetch_buffer_markers): New functions for
17364 recording and fetching special buffer markers.
17365 (set_buffer_internal_1, set_buffer_temp): Use them.
17366
17367 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
17368
17369 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
17370
17371 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
17372 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
17373
17374 * xdisp.c (hscroll_window_tree):
17375 (reconsider_clip_changes): Use PT instead of BUF_PT.
17376
d251f04b
EZ
173772011-03-13 Eli Zaretskii <eliz@gnu.org>
17378
17379 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
17380 $(EMACS_ROOT)/lib/intprops.h.
17381
f0c77cd1
PE
173822011-03-13 Paul Eggert <eggert@cs.ucla.edu>
17383
3eca4629
PE
17384 Fix more problems found by GCC 4.5.2's static checks.
17385
7c86ee98
PE
17386 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
17387 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
17388 (xg_free_frame_widgets): Make it clear that a local variable is
17389 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
17390 (gdk_window_get_screen): Make it clear that this macro is needed
17391 only if USE_GTK_TOOLTIP.
1e5524e7
PE
17392 (int_gtk_range_get_value): New function, which avoids a diagnostic
17393 from gcc -Wbad-function-cast.
17394 (xg_set_toolkit_scroll_bar_thumb): Use it.
17395 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
17396 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
17397 (get_utf8_string, xg_get_file_with_chooser):
17398 Rename locals to avoid shadowing.
17399 (create_dialog): Move locals to avoid shadowing.
7c86ee98 17400
41729b81
PE
17401 * xgselect.c (xg_select): Remove unused var.
17402
f0c77cd1
PE
17403 * image.c (four_corners_best): Mark locals as initialized.
17404 (gif_load): Initialize transparent_p to zero (Bug#8238).
17405 Mark another local as initialized.
ec6cf4c6 17406 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 17407
ce0ad53d 17408 * image.c (clear_image_cache): Now static.
d5d5a617 17409 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 17410 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
17411 (x_edge_detection): Remove unnecessary cast that
17412 gcc -Wbad-function-cast diagnoses.
2037898d 17413 (gif_load): Fix pointer signedness.
6ae141d6
PE
17414 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
17415 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 17416
33383987 174172011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 17418
d32df629
PE
17419 Improve quality of tests for time stamp overflow.
17420 For example, without this patch (encode-time 0 0 0 1 1
17421 1152921504606846976) returns the obviously-bogus value (-948597
17422 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
17423 reports time overflow. See
17424 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
17425 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
17426 * editfns.c: Include limits.h and intprops.h.
17427 (TIME_T_MIN, TIME_T_MAX): New macros.
17428 (time_overflow): Move earlier, to before first use.
17429 (hi_time, lo_time): New functions, for an accurate test for
17430 out-of-range times.
17431 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
17432 (Fget_internal_run_time): Don't assume time_t fits in int.
17433 (make_time): Use list2 instead of Fcons twice.
17434 (Fdecode_time): More accurate test for out-of-range times.
17435 (check_tm_member): New function.
17436 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
17437 (lisp_time_argument): Don't rely on undefined left-shift and
17438 right-shift behavior when checking for time stamp overflow.
8be6f318 17439
fe31d94c
PE
17440 * editfns.c (time_overflow): New function, refactoring common code.
17441 (Fformat_time_string, Fdecode_time, Fencode_time):
17442 (Fcurrent_time_string): Use it.
17443
8be6f318
PE
17444 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
17445 * dired.c (make_time): Move to ...
17446 * editfns.c (make_time): ... here.
17447 * systime.h: Note the move.
17448
09d9db2c 174492011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 17450
126bc0dc
YM
17451 * fringe.c (update_window_fringes): Remove unused variables.
17452
c47cbdfd
YM
17453 * unexmacosx.c (copy_data_segment): Also copy __got section.
17454 (Bug#8223)
17455
7ac80be9
EZ
174562011-03-12 Eli Zaretskii <eliz@gnu.org>
17457
c96bbc66 17458 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
17459 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
17460 Constify `char *' arguments and their references according to
17461 prototypes in tparam.h.
17462
ecb0f94d 17463 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 17464
7ac80be9
EZ
17465 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
17466 Adapt all references accordingly.
17467
17468 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
17469
ef1fd07e
TT
174702011-03-11 Tom Tromey <tromey@redhat.com>
17471
17472 * buffer.c (syms_of_buffer): Remove obsolete comment.
17473
7ef4b50c
EZ
174742011-03-11 Eli Zaretskii <eliz@gnu.org>
17475
17476 * termhooks.h (encode_terminal_code): Declare prototype.
17477
17478 * msdos.c (encode_terminal_code): Don't declare prototype.
17479
17480 * term.c (encode_terminal_code): Now external again, used by
17481 w32console.c and msdos.c.
17482
44f230aa
SM
17483 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
17484 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 17485
4b1ec863 174862011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 17487
1714f52b 17488 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 17489
4b1ec863
PE
17490 * fringe.c (update_window_fringes): Mark locals as initialized
17491 (Bug#8227).
17492 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 17493
524c7aa6
PE
17494 * alloc.c (mark_fringe_data): Move decl from here ...
17495 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
17496 to check its interface.
17497 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
17498
a5c0af81 17499 * fontset.c (free_realized_fontset): Now static.
7519b8cd 17500 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 17501 (fontset_font): Mark local as initialized.
a9a06e0b 17502 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 17503
b4716021
PE
17504 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
17505
811e9bac 17506 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 17507 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
17508 (x_own_selection, Fx_disown_selection_internal): Rename locals
17509 to avoid shadowing.
17510 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 17511
7e3ab302
PE
17512 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
17513 so that the caller can use some name other than gcpro1.
17514 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
17515 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17516 (Fx_backspace_delete_keys_p):
17517 Use them to avoid shadowing, and rename vars to avoid shadowing.
17518 (x_decode_color, x_set_name, x_window): Now static.
6b437900 17519 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 17520 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
17521 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
17522 Remove unused locals.
7e3ab302
PE
17523 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17524 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
17525 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
17526 macros.
f78faa98 17527
e2b13473
PE
17528 * xterm.h (x_mouse_leave): New decl.
17529
77f23912
PE
17530 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
17531 Remove unused functions.
cdf4ba58
PE
17532 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
17533 (x_calc_absolute_position): Now static.
7411c686 17534 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 17535 Don't declare local "event" unless it's used.
ed7bf3a5
PE
17536 (x_iconify_frame, x_free_frame_resources): Don't declare locals
17537 unless they are used.
38d0b34a
PE
17538 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
17539 (x_fatal_error_signal): Remove; not used.
a6067996
PE
17540 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
17541 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
17542 (x_error_catcher, x_connection_closed, x_error_handler):
17543 (x_error_quitter, xembed_send_message, x_iconify_frame):
17544 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 17545 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 17546 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 17547
44f230aa
SM
17548 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
17549 Rename or move locals to avoid shadowing.
6b463e58 17550 (tty_defined_color, merge_face_heights): Now static.
5967d051 17551 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
17552 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
17553 does not deduce is never used uninitialized.
73719eba
PE
17554 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
17555 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 17556
426994c3 17557 * terminal.c (store_terminal_param): Now static.
5489860b 17558
032f1620 17559 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 17560 (set_frame_menubar): Remove unused local.
d4323972 17561 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
17562 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
17563 since they might point to immutable storage.
281585b0
PE
17564 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
17565 since it's unused otherwise.
032f1620 17566
367c19e5 17567 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 17568 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
17569 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
17570 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 17571 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
17572 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
17573 does not deduce are never used uninitialized.
70739cbe 17574
07b48fa9
PE
17575 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
17576
8868a238 17577 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
17578 * window.c (window_loop, size_window):
17579 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 17580
7e5cf297 17581 * window.c (display_buffer): Now static.
d6550a9f
PE
17582 (size_window): Mark variables that gcc -Wuninitialized
17583 does not deduce are never used uninitialized.
a586633d
PE
17584 * window.h (check_all_windows): New decl, to forestall
17585 gcc -Wmissing-prototypes diagnostic.
5b555da1 17586 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 17587
f6095868
PE
17588 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
17589 shadowing.
17590 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
17591 Include <limits.h>.
17592 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
17593 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
17594 (load_charset_map): Mark variables that gcc -Wuninitialized
17595 does not deduce are never used uninitialized.
53df7c11 17596 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 17597
f38b440c
PE
17598 * coding.c (coding_set_source, coding_set_destination):
17599 Use "else { /* comment */ }" rather than "else /* comment */;"
17600 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
17601 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
17602 a block, when the outer 'i' will do.
17603 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
17604 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
17605 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
17606 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
17607 (Fdecode_sjis_char, Fdefine_coding_system_internal):
17608 Rename locals to avoid shadowing.
17609 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
17610 * coding.c (emacs_mule_char, encode_invocation_designation):
17611 Now static, since they're not used elsewhere.
413bb2db 17612 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 17613 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
17614 (decode_coding_emacs_mule): Mark variables that gcc
17615 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
17616 (detect_coding_iso_2022): Initialize a local variable that might
17617 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 17618 this initialization is needed. (Bug#8211)
5f58e762
PE
17619 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
17620 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
17621 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
17622 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
17623 Remove unused macros.
f38b440c 17624
232b38b9 17625 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 17626 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 17627 * character.c (string_count_byte8): Likewise.
232b38b9 17628
fb90da1b
PE
17629 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
17630 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
17631
fb93dbc2
PE
17632 * chartab.c (copy_sub_char_table): Now static, since it's not used
17633 elsewhere.
5c156ace
PE
17634 (sub_char_table_ref_and_range, char_table_ref_and_range):
17635 Rename locals to avoid shadowing.
bbcd0949 17636 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 17637
7d3b3862 17638 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 17639 (BIDI_BOB): Remove unused macro.
7d3b3862 17640
6be7d3da
PE
17641 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
17642 deduce are never used uninitialized.
c2ed9c8b 17643 * term.c (encode_terminal_code): Likewise.
6be7d3da 17644
75f8807f 17645 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 17646
50938595
PE
17647 * tparam.h: New file.
17648 * term.c, tparam.h: Include it.
17649 * deps.mk (term.o, tparam.o): Depend on tparam.h.
17650 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
17651 Move these decls to tparam.h, and make them agree with what
17652 is actually in tparam.c. The previous trick of using incompatible
17653 decls in different modules does not conform to the C standard.
17654 All callers of tparam changed to use tparam's actual API.
17655 * tparam.c (tparam1, tparam, tgoto):
17656 Use const pointers where appropriate.
17657
fbceeba2
PE
17658 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
17659 * cm.h (struct cm): Likewise.
17660 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
17661 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
17662 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
17663 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
17664 (turn_on_face, init_tty): Likewise.
17665 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 17666
7f3f1250
PE
17667 * term.c (term_mouse_position): Rename local to avoid shadowing.
17668
e6ca6543
PE
17669 * alloc.c (mark_ttys): Move decl from here ...
17670 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
17671
c40f8d15
AS
176722011-03-11 Andreas Schwab <schwab@linux-m68k.org>
17673
17674 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
17675
cfe0661d
JB
176762011-03-09 Juanma Barranquero <lekktu@gmail.com>
17677
17678 * search.c (compile_pattern_1): Remove argument regp, unused since
17679 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
17680 (compile_pattern): Don't pass it.
17681
0afb4571
J
176822011-03-08 Jan Djärv <jan.h.d@swipnet.se>
17683
17684 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
17685 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
17686 for ! HAVE_GTK3.
17687 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
17688
17689 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
17690
17691 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
17692 gdk_window_get_screen, gdk_window_get_geometry,
17693 gdk_x11_window_lookup_for_display and GDK_KEY_g.
17694 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
17695 (xg_get_pixbuf_from_pixmap): New function.
17696 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
17697 to Pixmap, take frame as parameter, remove GdkColormap parameter.
17698 Call xg_get_pixbuf_from_pixmap instead of
17699 gdk_pixbuf_get_from_drawable.
17700 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
17701 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
17702 (xg_check_special_colors): Use GtkStyleContext and its functions
17703 for HAVE_GTK3.
17704 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
17705 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
17706 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
17707 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
17708 Call gtk_widget_get_preferred_size.
0afb4571
J
17709 (xg_frame_resized): gdk_window_get_geometry only takes 5
17710 parameters.
44f230aa
SM
17711 (xg_win_to_widget, xg_event_is_for_menubar):
17712 Call gdk_x11_window_lookup_for_display.
0afb4571
J
17713 (xg_set_widget_bg): New function.
17714 (delete_cb): New function.
895009e1 17715 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 17716 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
17717 (xg_set_background_color): Call xg_set_widget_bg.
17718 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
17719 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
17720 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
17721 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
17722 if ! HAVE_GTK3.
17723 (update_frame_tool_bar): Call gtk_widget_hide.
17724 (xg_initialize): Use GDK_KEY_g.
17725
17726 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
17727 if ! HAVE_GTK3
17728 (x_session_initialize): Call gdk_x11_set_sm_client_id.
17729
17730 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
17731 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
17732 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
17733
1c2cc4ef
JB
177342011-03-08 Juanma Barranquero <lekktu@gmail.com>
17735
17736 * w32xfns.c (select_palette): Check success of RealizePalette against
17737 GDI_ERROR, not zero.
17738
33383987 17739See ChangeLog.11 for earlier changes.
aac0c6e3
MR
17740
17741;; Local Variables:
17742;; coding: utf-8
aac0c6e3
MR
17743;; End:
17744
2f097256 17745 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
17746
17747 This file is part of GNU Emacs.
17748
17749 GNU Emacs is free software: you can redistribute it and/or modify
17750 it under the terms of the GNU General Public License as published by
17751 the Free Software Foundation, either version 3 of the License, or
17752 (at your option) any later version.
17753
17754 GNU Emacs is distributed in the hope that it will be useful,
17755 but WITHOUT ANY WARRANTY; without even the implied warranty of
17756 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17757 GNU General Public License for more details.
17758
17759 You should have received a copy of the GNU General Public License
17760 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.