quail-define-inscript-package tiny change
[bpt/emacs.git] / src / ChangeLog
CommitLineData
44386687
DA
12012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Do not use memcpy for copying intervals.
4 * intervals.c (reproduce_interval): New function.
5 (reproduce_tree, reproduce_tree_obj): Use it.
6 (reproduce_tree_obj): Remove prototype.
7
927c7216
PE
82012-08-17 Paul Eggert <eggert@cs.ucla.edu>
9
10 * lisp.h (duration_to_sec_usec): Remove unused decl.
11
93044f7b
AA
122012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
13
14 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
15 to an allocated instance of NSString, not to the class itself.
16
9851e4a5
JB
172012-08-17 Juanma Barranquero <lekktu@gmail.com>
18
19 * makefile.w32-in (C_CTYPE_H): New macro.
20 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
21 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
22 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
23
620f13b0
PE
242012-08-16 Paul Eggert <eggert@cs.ucla.edu>
25
26 Use ASCII tests for character types.
27 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
28 * xfns.c, xterm.c:
29 Don't include <ctype.h>; was not needed.
30 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
31 * sysdep.c, xfaces.c:
32 Include <c-ctype.h> instead of <ctype.h>.
33 * nsterm.m: Include <c-ctype.h>.
34 * charset.c (read_hex):
35 * doc.c (Fsnarf_documentation):
36 * fileio.c (IS_DRIVE) [WINDOWSNT]:
37 (DRIVE_LETTER) [DOS_NT]:
38 (Ffile_name_directory, Fexpand_file_name)
39 (Fsubstitute_in_file_name):
40 * font.c (font_parse_xlfd, font_parse_fcname):
41 * frame.c (x_set_font_backend):
42 * gtkutil.c (xg_get_font):
43 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
44 * nsimage.m (hexchar):
45 * nsterm.m (ns_xlfd_to_fontname):
46 * sysdep.c (system_process_attributes):
47 * xfaces.c (hash_string_case_insensitive):
48 Use C-locale tests instead of locale-specific tests for character
49 types, since we want the ASCII interpretation here, not the
50 interpretation suitable for whatever happens to be the current locale.
51
52162052
MR
522012-08-16 Martin Rudalics <rudalics@gmx.at>
53
54 Consistently check windows for validity/liveness
55 (Bug#11984, Bug#12025, Bug#12026).
56 * lisp.h (CHECK_VALID_WINDOW): New macro.
57 * window.c (decode_window): Rename to decode_live_window.
58 (decode_valid_window, Fwindow_valid_p): New functions.
59 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
60 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
61 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
62 (Fwindow_prev_sibling, Fwindow_combination_limit)
63 (Fset_window_combination_limit, Fwindow_use_time)
64 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
65 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
66 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
67 (Fwindow_hscroll, Fset_window_hscroll)
68 (Fwindow_redisplay_end_trigger)
69 (Fset_window_redisplay_end_trigger, Fwindow_edges)
70 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
71 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
72 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
73 (Fwindow_end, Fset_window_point, Fset_window_start)
74 (Fpos_visible_in_window_p, Fwindow_line_height)
75 (Fwindow_dedicated_p, Fset_window_dedicated_p)
76 (Fwindow_prev_buffers, Fset_window_prev_buffers)
77 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
78 (Fset_window_parameter, Fwindow_display_table)
79 (Fset_window_display_table, Fdelete_other_windows_internal)
80 (Fset_window_buffer, Fset_window_new_total)
81 (Fset_window_new_normal, Fdelete_window_internal)
82 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
83 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
84 (Fwindow_scroll_bars): Check whether argument window is a valid or
85 live window. Update doc-strings.
86 (syms_of_window): New symbol Qwindow_valid_p.
87 * keyboard.c (Fposn_at_x_y): Check whether argument
88 frame_or_window denotes a valid window.
89
2751c80f
DA
902012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
91
92 Fix previous char table change.
93 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
94 * chartab.c (optimize_sub_char_table): Likewise.
95
032a42c8
CY
962012-08-16 Chong Yidong <cyd@gnu.org>
97
a2d19368
CY
98 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
99
032a42c8
CY
100 * xfont.c (xfont_open):
101 * xftfont.c (xftfont_open): Set the font's max_width field.
102
103 * nsfont.m (nsfont_open): Similar to the Xft backend, set
104 min_width to space_width and average_width to the average over
105 printable ASCII characters.
106 (ns_char_width): Code cleanup.
107 (ns_ascii_average_width): New utility function.
108
109 * font.h (struct font): Update comments.
110
a098c930
DA
1112012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
112
032a42c8 113 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
114 * lisp.h (CSET): New macro.
115 (char_table_set_extras, char_table_set_contents)
116 (sub_char_table_set_contents): New function.
117 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
118 * syntax.c: Adjust users.
119
8be3a09c
SM
1202012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
121
122 * eval.c (eval_sub): Bind lexical-binding.
123 * lread.c (Qlexical_binding): Make non-static.
124
ac4845a6
JD
1252012-08-15 Jan Djärv <jan.h.d@swipnet.se>
126
ddee6515
JD
127 * nsmenu.m (popupSession): Remove.
128 (pop_down_menu): Remove endModalSession.
129 (timeout_handler:): New method.
130 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
131 Call runModalForWindow. Check timer_fired when it returns.
132 If not set, cancel timer and break out of loop.
133 Otherwise loop again, with a new timeout.
134
135 * nsterm.m: Include fcntl.h if present.
136 (fd_entry, t_readfds, inNsSelect): Remove.
137 (select_writefds, select_valid, select_timeout, selfds)
138 (select_mutex, apploopnr): Add.
139 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
140 Otherwise call kbd_buffer_store_event.
141 (ns_send_appdefined): Remove release of fd_entry.
142 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
143 Increment and decrement apploopnr.
144 (ns_select): If no file descriptors, just do a NSTimer.
145 Otherwise copy read/write masks and start select thread (fd_handler).
146 Start main loop and wait for application defined event.
147 Inform select thread to stop selecting after main loop is exited.
148 (ns_term_init): Create selfds pipe and set non-blocking.
149 Initialize select_mutex. Start the select thread (fd_handler).
150 (fd_handler:): Loop forever, wait for info from the main thread
151 to either start or stop selecting. When select returns, send
152 and appdefined event.
153 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
154 If not call kbd_buffer_store_event.
155
156 * nsterm.h (EmacsApp): fd_handler takes id argument.
157 (EmacsDialogPanel): Add timer_fired and timeout_handler.
158
ac4845a6
JD
159 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
160
eb424fe3
EZ
1612012-08-15 Eli Zaretskii <eliz@gnu.org>
162
163 * region-cache.c (move_cache_gap): Update gap_len using the actual
164 growth of the boundaries array. Do not change cache_len.
165 (Bug#12196)
166
4e6a86c6
DA
1672012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
168
169 Generalize and cleanup font subsystem checks.
170 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
171 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
172 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 173
5bf192ca
DA
1742012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
175
176 * gtkutil.c (xg_get_font): Use pango_units_to_double.
177
f2045622
CY
1782012-08-15 Chong Yidong <cyd@gnu.org>
179
8be3a09c
SM
180 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
181 When using the new font chooser, use gtk_font_chooser_get_font_desc to
182 extract the font descriptor instead of just the font name.
183 In that case, return a font spec instead of a string.
f2045622
CY
184 (x_last_font_name): Move to this file from xfns.c.
185
186 * xfns.c (Fx_select_font): The return value can also be a font
187 spec. Move x_last_font_name management to gtkutil.c.
188
189 * xfaces.c: Make font weight and style symbols non-static.
190
7f6feb56
SM
1912012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
192
193 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
194 (bug#12117).
195
fecbd8ff
SM
1962012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
197
198 * alloc.c (Fgarbage_collect): Use plural form consistently.
199
9b8d5165
EZ
2002012-08-14 Eli Zaretskii <eliz@gnu.org>
201
202 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
203 iteration through the command loop. Fixes a problem whereby mouse
204 movements are ignored until the first mouse click.
205
f5d9e83a
PE
2062012-08-14 Paul Eggert <eggert@cs.ucla.edu>
207
208 Use bool, not int, for Lisp booleans.
209 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
210 makes Emacs a bit smaller and presumably a bit faster.
211 * lisp.h: Include <stdbool.h>.
212 (struct Lisp_Boolfwd, defvar_bool):
213 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
214 * regex.c [!emacs]: Include <stdbool.h>.
215 (false, true): Remove; <stdbool.h> does this for us now.
216
55802e4a
CY
2172012-08-14 Chong Yidong <cyd@gnu.org>
218
4abcdac8
CY
219 * character.c (Fcharacterp): Doc fix (Bug#12076).
220
221 * data.c (Findirect_variable): Doc fix (Bug#11040).
222
55802e4a
CY
223 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
224
225 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 226 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 227
8e99d072
BR
2282012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
229
230 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
231 (bug#12022).
232
08908aca
MR
2332012-08-14 Martin Rudalics <rudalics@gmx.at>
234
235 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
236 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
237 * minibuf.c (choose_minibuf_frame, read_minibuf):
238 * w32fns.c (x_create_tip_frame):
239 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
240 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
241
56120d6f
PE
2422012-08-14 Paul Eggert <eggert@cs.ucla.edu>
243
244 * intervals.c (offset_intervals): Remove obsolete comment.
245
67b77c0b
AS
2462012-08-14 Andreas Schwab <schwab@linux-m68k.org>
247
248 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
249
f48b82fd
GR
2502012-08-14 Gergely Risko <gergely@risko.hu>
251
252 * coding.c (decode_coding): Record buffer modification before
253 disabling undo_list (Bug#11773).
254
fd318b54
DA
2552012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
256
257 Revert and cleanup some recent overlay changes.
258 * buffer.h (enum overlay_type): Remove.
259 (buffer_get_overlays, buffer_set_overlays): Likewise.
260 (buffer_set_overlays_before, buffer_set_overlays_after):
261 New function. Adjust users.
262 (unchain_both): Add eassert.
263
41a62dd9
DA
2642012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
265
266 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
267
5884c324
PE
2682012-08-14 Paul Eggert <eggert@cs.ucla.edu>
269
270 * gtkutil.c (xg_mark_data): Don't assume C99.
271
ca06f160
JD
2722012-08-13 Jan Djärv <jan.h.d@swipnet.se>
273
274 * gtkutil.c (xg_frame_tb_info): New struct.
275 (TB_INFO_KEY): New define.
276 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
277 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
278 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
279 if not present.
280 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
281 is up to date. Otherwise store new data.
282 (free_frame_tool_bar): Free xg_frame_tb_info if present.
283
7864a3f7
DA
2842012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
285
286 Use KSET for write access to Lisp_Object members of struct kboard.
287 * keyboard.h (KSET): New macro.
288 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
289 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
290 * xterm.c: Adjust users.
291
4c31be61
DA
2922012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
293
294 Use BSET for write access to Lisp_Object members of struct buffer.
295 * buffer.h (BSET): New macro.
296 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
297 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
298 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
299 * window.c, xdisp.c, xfns.c: Adjust users.
300
14ae4239
BT
3012012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
302
303 * lread.c (syms_of_lread): Initialize Vlexical_binding.
304
32bcadb4
JD
3052012-08-11 Jan Djärv <jan.h.d@swipnet.se>
306
3d29b2ce
JD
307 * nsterm.m (not_in_argv): New function.
308 (application:openFile, application:openTempFile:):
309 (application:openFileWithoutUI:, application:openFiles:): Open file
310 if not_in_argv returns non-zero (bug#12171).
311
32bcadb4 312 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
313 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
314 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
315 (xg_get_font_name): Use those functions/macros here.
316 Reported by Frans Oilinki <moilinki@gmail.com>.
317
9ff9402d 3182012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
319
320 * unexmacosx.c (copy_data_segment): Copy initialized data in
321 statically linked libraries from input file rather than memory.
322
db74a5fc
YM
323 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
324 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
325 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
326
25e65510
GM
3272012-08-10 Glenn Morris <rgm@gnu.org>
328
329 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
330 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
331
7961135c
DA
3322012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
333
334 Fix last change to allow compilation with low optimization levels.
335 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
336 Reported by Jan Djärv <jan.h.d@swipnet.se>.
337
42b3a444
DA
3382012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
339
340 Use common inline syntax in intervals.h.
341 * intervals.h (INTERVALS_INLINE): New macro.
342 Change all users from LISP_INLINE.
343
9fb0c957
DA
3442012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
345
346 Define Qnone once for all platforms.
347 * frame.c (Qnone): Define here.
348 (syms_of_frame): DEFSYM it.
349 * lisp.h (Qnone): New declaration.
350 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
351 * xfns.c: Remove duplication. Adjust users.
352
65e8ee52
DA
3532012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
354
355 Remove unused macros from intervals.h.
356 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
357 * intervals.c: Adjust comment.
358
9b855fd6
EZ
3592012-08-10 Eli Zaretskii <eliz@gnu.org>
360
361 * w32fns.c <w32_unicode_gui>: New static variable.
362 (globals_of_w32fns): Initialize it according to os_subtype.
363 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
364 testing os_subtype.
365
39cb9e56 3662012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
367 Eli Zaretskii <eliz@gnu.org>
368
369 Fix bug #10299 with Unicode characters sent by customized
370 keyboards created by MSKLC.
371 * w32fns.c (INIT_WINDOW_CLASS): New macro.
372 (w32_init_class): Use it to initialize the Emacs class with either
373 ANSI or Unicode API calls.
374 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
375 later.
376 (w32_wnd_proc): If the character code sent by WM_CHAR or
377 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
378 original message. Call DefWindowProcW on NT and later.
379
9374581a
GM
3802012-08-10 Glenn Morris <rgm@gnu.org>
381
4b94e8cf
GM
382 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
383
9374581a
GM
384 * lisp.h (DIRECTORY_SEP): Let configure set it.
385
a2752828
DA
3862012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
387
388 Use TSET for write access to Lisp_Object slots of struct terminal.
389 * termhooks.h (TSET): New macro.
390 * coding.c, terminal.c, xselect.c: Adjust users.
391
cc92c454
SM
3922012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
393
394 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
395 the failing expression, include them in the error message.
396 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
397 * lisp.h (internal_condition_case_n): Update declaration.
398
4cb3e6b3
DA
3992012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
400
401 Inline functions to examine and change buffer overlays.
402 * buffer.c (unchain_both): New function.
403 * buffer.h (buffer_get_overlays, buffer_set_overlays):
404 (buffer_has_overlays): New function.
405 (enum overlay_type): New enum.
406 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
407 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
408
8707c1e5
DA
4092012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
410
411 Inline functions to examine and change buffer intervals.
412 * alloc.c (mark_interval_tree): Remove.
413 (MARK_INTERVAL_TREE): Simplify.
414 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
415 * intervals.c (buffer_balance_intervals): New function.
416 (graft_intervals_into_buffer): Adjust indentation.
417 (set_intervals_multibyte): Simplify.
418 * buffer.h (BUF_INTERVALS): Remove.
419 (buffer_get_intervals, buffer_set_intervals): New function.
420 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
421 * intervals.c, textprop.c: Adjust users.
422
ad8c997f
DA
4232012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
424
425 Inline functions to examine and change string intervals.
426 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
427 (string_get_intervals, string_set_intervals): New function.
428 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
429 * lread.c, print.c, textprop.c: Adjust users.
430
32ac3a6b
GM
4312012-08-08 Glenn Morris <rgm@gnu.org>
432
433 * lisp.mk (lisp): Remove language/persian.elc.
434
77c7bcb1
DA
4352012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
436
437 Cleanup intervals.
438 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
439 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
440 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
441 Adjust comment. Move under #if 0.
77c7bcb1
DA
442 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
443 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
444
9c08a8d4
DA
4452012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
446
447 Check total length of intervals with eassert.
448 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
449 * intervals.c: Change all users to eassert.
450
26d16b35
EZ
4512012-08-07 Eli Zaretskii <eliz@gnu.org>
452
14ae4239
BT
453 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
454 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
455 INTERNAL_FIELD in Lisp_Cons.
456
c644523b
DA
4572012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
458
459 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
460 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
461 name since all xname users are fixed long time ago. Do not
462 use INTERNAL_FIELD.
463 (set_symbol_name, set_symbol_function, set_symbol_plist):
464 (set_symbol_next, set_overlay_plist): New function.
465 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
466 (struct Lisp_Overlay): Likewise.
467 (CVAR, MVAR, SVAR): Remove.
468 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
469 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
470 * xterm.c: Adjust users.
471 * .gdbinit: Change to use name field of struct Lisp_Symbol
472 where appropriate.
473
6a3d20cc
DA
4742012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
475
476 Basic functions to set Lisp_Object and pointer slots of intervals.
477 * intervals.h (interval_set_parent, interval_set_object):
478 (interval_set_left, interval_set_right, interval_set_plist):
479 (interval_copy_parent): New function.
480 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
481 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
482 Adjust indentation.
6a3d20cc
DA
483 (INTERVAL_SIZE): Remove. Adjust users.
484 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
485
4d2b044c
DA
4862012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
487
488 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
489 * process.h (PGET): Remove.
490 (struct Lisp_Process): Do not use INTERNAL_FIELD.
491 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
492
d3d50620
DA
4932012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
494
495 Drop WGET and revert read access to Lisp_Objects slots of struct window.
496 * window.h (WGET): Remove.
497 (struct window): Do not use INTERNAL_FIELD.
498 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
499 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
500 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
501 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
502 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
503 Adjust users.
504
d10a51dc
CY
5052012-08-07 Chong Yidong <cyd@gnu.org>
506
507 * window.c (Fwindow_edges, Fwindow_pixel_edges)
508 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
509 (Fdelete_window_internal): Signal an error if the window is not on
510 a live frame (Bug#12025).
511
e69b0960
DA
5122012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
513
514 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
515 * frame.h (FGET): Remove.
516 (struct frame): Do not use INTERNAL_FIELD.
517 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
518 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
519 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
520 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
521
25a20a3a
JB
5222012-08-06 Juanma Barranquero <lekktu@gmail.com>
523
524 * w32.c: Silence compiler warnings.
525 (map_w32_filename): Remove unused variable `is_fat'.
526 (chase_symlinks): Add parentheses around expression.
527
1c6f11f4
GM
5282012-08-06 Glenn Morris <rgm@gnu.org>
529
1db4583a
GM
530 * sysdep.c: Respect BROKEN_GETWD.
531
1c6f11f4
GM
532 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
533 Let configure handle it.
534 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
535
2b90362b
DA
5362012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
537
538 Use GCALIGNMENT where appropriate.
539 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
540 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
541 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
542
5f50daf2
EZ
5432012-08-06 Eli Zaretskii <eliz@gnu.org>
544
14ae4239
BT
545 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
546 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 547
cbcc7007
SM
5482012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
549
550 * buffer.h (struct buffer): Revert `indirections' to a simple int;
551 that should be sufficient for everyone.
552
4d365fa4
JD
5532012-08-06 Jan Djärv <jan.h.d@swipnet.se>
554
555 * keyboard.c (timer_check_2): Add break so timer_check returns next
556 timeout.
557
dd86bd82
DA
5582012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
559
560 Fix Windows build errors introduced after converting to WGET and WSET.
561 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
562 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
563
054e1668
JD
5642012-08-06 Jan Djärv <jan.h.d@swipnet.se>
565
566 * nsterm.m (ns_frame_rehighlight): Use FSET.
567
568 * nsmenu.m (ns_update_menubar): Use FSET.
569
21238f11
DA
5702012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
571
572 Separate read and write access to Lisp_Object slots of Lisp_Process.
573 * process.h (PGET, PSET): New macros similar to AREF and ASET.
574 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
575
077288cf
DA
5762012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
577
578 Separate read and write access to Lisp_Object slots of struct window.
579 * window.h (WGET, WSET): New macros similar to AREF and ASET.
580 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
581 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
582 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
583 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
584 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
585 Adjust users.
586
71688bd7
DA
5872012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
588
589 Fix Windows build errors introduced after converting to FGET and FSET.
590 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
591 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
592 (w32_judge_scroll_bars): Change to use FSET.
593 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
594
f99bac93
DA
5952012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
596
597 Fix replacement typo.
598 * window.c (replace_window): Set root_window instead of
599 selected_window. This fixes a total window subsystem
600 malfunction reported by Bastien Guerry <bzg@gnu.org>.
601
8c2a0f2d
GM
6022012-08-06 Glenn Morris <rgm@gnu.org>
603
604 * lisp.mk (lisp): Add language/persian.elc.
605
edd74c35
DA
6062012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
607
608 Separate read and write access to Lisp_Object slots of struct frame.
609 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
610 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
611 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
612 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
613 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
614
8671676c
AS
6152012-08-05 Andreas Schwab <schwab@linux-m68k.org>
616
617 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
618
663e2b3f
DA
6192012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
620
621 Generalize common compile-time constants.
622 * lisp.h (header_size, bool_header_size, word_size): Now here.
623 (struct Lisp_Vector): Add comment.
624 (struct Lisp_Bool_Vector): Move up to define handy constants.
625 (VECSIZE, PSEUDOVECSIZE): Simplify.
626 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
627 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
628 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
629 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
630 * xfont.c, xmenu.c: Use word_size where appropriate.
631
d32e47af
LM
6322012-08-05 Lawrence Mitchell <wence@gmx.li>
633
634 * search.c (Freplace_match): Treat \? in the replacement text
635 literally (Bug#8161).
636
e5d9c0d1
CY
6372012-08-05 Chong Yidong <cyd@gnu.org>
638
639 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
640 * frame.c (Vdelete_frame_functions):
641 * emacs.c (Vkill_emacs_hook): Doc fix.
642
8da0576b
EZ
6432012-08-04 Eli Zaretskii <eliz@gnu.org>
644
645 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
646 --with-x-toolkit=no builds.
647 Reported by Carsten Mattner <carstenmattner@gmail.com>.
648
02676e5d
CY
6492012-08-04 Chong Yidong <cyd@gnu.org>
650
651 * syntax.c (Fmodify_syntax_entry): Doc fix.
652
97147da9
EZ
6532012-08-04 Eli Zaretskii <eliz@gnu.org>
654
76151e2c
EZ
655 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
656 * w32.c (init_environment): Change the default values of many
657 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
658 them into environment when they were not already defined.
659 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 660 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
661 (check_windows_init_file): Now external, not static.
662 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
663 called when Vload_path is already set up.
664
665 * w32.h (check_windows_init_file): Add prototype.
666
667 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
668 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
669 compatibility with Posix platforms.
670 (main): Move the call to check_windows_init_file to here from
671 w32.c.
672 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
673 any, in the DEFALT argument into the root of the Emacs build or
674 installation tree, as appropriate.
675
676 * callproc.c (init_callproc_1): Call decode_env_path instead of
677 doing its equivalent by hand.
678 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
679 the code that sets Vexec_path run on MS-Windows.
680
681 * lread.c (init_lread): Add comments to #ifdef's.
682
97147da9
EZ
683 * msdos.c (dos_set_window_size, IT_update_begin)
684 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
685 instead of direct references.
686
185ee146
PE
6872012-08-04 Paul Eggert <eggert@cs.ucla.edu>
688
689 Export DEFAULT_REHASH_* to GDB.
690 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
691 Now constants, not macros.
692
8834c57a
PE
6932012-08-03 Paul Eggert <eggert@cs.ucla.edu>
694
98c6f1e3
PE
695 Remove unnecessary casts involving pointers.
696 These casts are no longer needed now that we assume C89 or later,
697 since they involve casting to or from void *.
698 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
699 (make_pure_float, make_pure_vector):
700 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
701 * macros.c (Fstart_kbd_macro):
702 * menu.c (find_and_return_menu_selection):
703 * minibuf.c (read_minibuf_noninteractive):
704 * sysdep.c (closedir):
705 * xdisp.c (x_produce_glyphs):
706 * xfaces.c (compare_fonts_by_sort_order):
707 * xfns.c (x_real_positions, select_visual):
708 * xselect.c (x_stop_queuing_selection_requests)
709 (x_get_window_property, x_get_window_property_as_lisp_data):
710 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
711 Remove unnecessary pointer casts.
712 * alloc.c (record_xmalloc): New function.
713 * lisp.h (record_xmalloc): New decl.
714 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
715 more like a function. This is because the pointer cast is not
716 needed. All uses changed.
717 * print.c (print_string, print_error_message): Avoid length recalc.
718
8834c57a
PE
719 Improve fix for macroexp crash with debugging (Bug#12118).
720 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
721 ARRAY_MARK_FLAG when checking subscripts, because ASET is
722 not supposed to be invoked from the garbage collector.
723 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
724 (gc_aset): New function, which is like ASET but can be
725 used in the garbage collector.
726 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
727 (set_hash_index): Use it instead of ASET.
728
6dad7178
EZ
7292012-08-03 Eli Zaretskii <eliz@gnu.org>
730
731 Support symlinks on latest versions of MS-Windows.
732 * w32.c: Include winioctl.h and aclapi.h.
733 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
734 (revert_to_self): Forward declarations of static functions.
735 <static BOOL g_b_init_get_security_info>:
736 <g_b_init_create_symbolic_link>: New static flags.
737 (globals_of_w32): Initialize them to zero.
738 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
739 (map_w32_filename): Improve commentary. Simplify switch.
740 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
741 headers (most versions of MinGW w32api don't).
742 (get_security_info, create_symbolic_link)
743 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
744 New functions.
745 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
746 in the argument file name.
747 (sys_access): Call unc_volume_file_attributes only if
748 GetFileAttributes fails with network-related error codes.
749 (sys_rename): Diagnose renaming of a symlink when the user doesn't
750 have the required privileges.
14ae4239 751 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
752 get_file_security_desc.
753 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
754 with addition of handling of symlinks and support for 'lstat'.
755 If possible, get file's attributes and security information by
6dad7178
EZ
756 handle, not by name. Produce S_IFLNK bit for symlinks, when
757 called from 'lstat'.
758 (stat, lstat): New functions, call 'stat_worker'.
759 (symlink, readlink, careadlinkat): Rewritten to create and resolve
760 symlinks when the underlying filesystem supports them.
761
f162bcc3
PE
7622012-08-02 Paul Eggert <eggert@cs.ucla.edu>
763
79ea6c20
PE
764 Fix macroexp crash on Windows with debugging (Bug#12118).
765 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
766 checking subscripts; problem introduced with the recent
767 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
768 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
769 since it's used in non-static inline functions now.
770
c0ce93fd
PE
771 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
772 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 773
f162bcc3
PE
774 Use C99-style 'extern inline' if available.
775 * buffer.h (BUFFER_INLINE):
776 * category.h (CATEGORY_INLINE):
777 * character.h (CHARACTER_INLINE):
778 * charset.h (CHARSET_INLINE):
779 * composite.h (COMPOSITE_INLINE):
780 * dispextern.h (DISPEXTERN_INLINE):
781 * lisp.h (LISP_INLINE):
782 * systime.h (SYSTIME_INLINE):
783 New macro, replacing 'static inline' in this header.
784 * buffer.h, category.h, character.h, charset.h, composite.h:
785 * dispextern.h, lisp.h, systime.h:
786 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
787 * alloc.c (LISP_INLINE):
788 * buffer.c (BUFFER_INLINE):
789 * category.c (CATEGORY_INLINE):
790 * character.c (CHARACTER_INLINE):
791 * charset.c (CHARSET_INLINE):
792 * composite.c (COMPOSITE_INLINE):
793 * dispnew.c (DISPEXTERN_INLINE):
794 * sysdep.c (SYSTIME_INLINE):
795 Define to EXTERN_INLINE, so that the corresponding functions
796 are compiled into code.
797 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
798 (INLINE_HEADER_END): New macros.
799 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
800 since it's used in non-static inline functions now.
a8333d03 801 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 802
837b365b
GM
8032012-08-02 Glenn Morris <rgm@gnu.org>
804
d66b744d
GM
805 * s/: Remove empty directory.
806
837b365b
GM
807 * s/ms-w32.h: Move to ../nt/inc.
808 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
809 Update for new ms-w32.h location.
810
13294f95
PE
8112012-08-02 Paul Eggert <eggert@cs.ucla.edu>
812
813 Port to Solaris 8.
814 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
815
90df0db3
GM
8162012-08-02 Glenn Morris <rgm@gnu.org>
817
818 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
819 hard-coding the path separator.
820
4939150c
PE
8212012-08-01 Paul Eggert <eggert@cs.ucla.edu>
822
823 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
824 This how ASET and AREF are supposed to work, and makes
825 it easier to think about future improvements. See
826 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
827 * charset.h (set_charset_attr): New function.
828 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
829 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
830 (aref_addr): New function. All uses of &AREF(...) changed.
831 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
832 (set_hash_index): New functions. All lvalue-style uses of
833 HASH_KEY etc. changed.
834 * keyboard.c (set_prop): New function. All lvalue-style uses
835 of PROP changed.
836
947b2afd
AA
8372012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
838
839 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
840 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
841 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
842 * nsfns.m (ns_set_name_as_filename): Likewise.
843 * nsmenu.m (ns_update_menubar): Likewise.
844 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
845
4f5d0325
EZ
8462012-08-01 Eli Zaretskii <eliz@gnu.org>
847
2008beae
EZ
848 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
849 Adapt to latest changes in field names of the corresponding Lisp
288479f6 850 objects.
2008beae 851
4f5d0325
EZ
852 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
853
fe3cc771
GM
8542012-08-01 Glenn Morris <rgm@gnu.org>
855
856 * s/msdos.h: Remove file.
857 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
858 * Makefile.in (S_FILE): Remove.
859 (config_h): Remove S_FILE.
860
c90acc54
JB
8612012-08-01 Juanma Barranquero <lekktu@gmail.com>
862
863 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
864 Remove; moved to nt/config.nt.
865
d8a05828
DA
8662012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
867
868 Use INTERNAL_FIELD for conses and overlays.
869 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
870 Remove obsolete comment.
871 (MVAR): New macro.
872 (struct Lisp_Overlay): Use INTERNAL_FIELD.
873 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
874
8271d590
DA
8752012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
876
877 Use INTERNAL_FIELD for symbols.
878 * lisp.h (SVAR): New macro. Adjust users.
879 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
880 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
881
3193acd2
DA
8822012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
883
884 Use INTERNAL_FIELD for processes.
885 * process.h (PVAR): New macro. Adjust style.
886 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
887 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
888
3a45383a
DA
8892012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
890
891 Use INTERNAL_FIELD for windows.
892 * window.h (WVAR): New macro.
893 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
894 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
895 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
896 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
897 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
898 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
899
c1dbc63c
PE
9002012-08-01 Paul Eggert <eggert@cs.ucla.edu>
901
902 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
903
5c0c0e8a
GM
9042012-08-01 Glenn Morris <rgm@gnu.org>
905
906 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
907 Move to configure.ac.
908
552a99b4
JB
9092012-08-01 Juanma Barranquero <lekktu@gmail.com>
910
911 * makefile.w32-in (CONFIG_H): Update dependencies.
912 (CONF_POST_H): New macro.
913
914 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
915
8d8e2dfe
GM
9162012-07-31 Glenn Morris <rgm@gnu.org>
917
bc96620a
GM
918 * Makefile.in (S_FILE): No longer set by configure.
919
476b1b2d
GM
920 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
921 is available.
922 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
923
b2c7a106
GM
924 * process.h (NULL_DEVICE):
925 * emacs.c (SEPCHAR):
926 * editfns.c (USER_FULL_NAME): Let configure set them.
927
d53d062a
GM
928 * s/README, s/template.h: Remove files.
929
4515017f
GM
930 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
931
8d8e2dfe
GM
932 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
933 Move to configure.ac.
934
5b20b3cc
EZ
9352012-07-31 Eli Zaretskii <eliz@gnu.org>
936
1e0afd9a
EZ
937 * .gdbinit (xframe): Adapt to introduction of FVAR and the
938 resulting renaming of 'struct frame' members.
939
5b20b3cc
EZ
940 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
941
942 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
943 after introduction of FVAR.
944
f1310128
JD
9452012-07-31 Jan Djärv <jan.h.d@swipnet.se>
946
79e721e0
JD
947 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
948
949 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
950 instead of compositeToPoint.
951 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
952
8d7c7eed 953 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 954
e34f7f79
DA
9552012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
956
957 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
958 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 959 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
960 (BVAR): Change to use INTERNAL_FIELD.
961 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
962 (KVAR): Change to use INTERNAL_FIELD.
963 * frame.h (FVAR): New macro.
964 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
965 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
966 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
967 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
968 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
969
c09bfb2f
DA
9702012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
971
972 Miscellaneous fixes for non-default X toolkits.
973 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
974 * xterm.c (x_frame_of_widget): Remove redundant prototype.
975 Move under #ifdef USE_LUCID.
976 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
977 definition and usage to avoid warnings.
978
14c114ae
JD
9792012-07-31 Jan Djärv <jan.h.d@swipnet.se>
980
981 * nsterm.m (openFiles): Fix previous checkin.
982
3bd21e82
PE
9832012-07-31 Paul Eggert <eggert@cs.ucla.edu>
984
985 * indent.c (compute_motion): Remove unused local.
986
c1529ded
GM
9872012-07-31 Glenn Morris <rgm@gnu.org>
988
400d5621
GM
989 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
990
268e2432
GM
991 * conf_post.h [USG5_4]:
992 Move remaining contents of s/usg5-4-common.h here.
993 * s/usg5-4-common.h: Remove file.
994
7552f3ee
GM
995 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
996 * s/irix6-5.h: Remove file.
997
6a381852
GM
998 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
999 * s/darwin.h: Remove file.
1000
c1529ded
GM
1001 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
1002 * s/hpux10-20.h: Remove file, which is now empty.
1003
b429a4ee
GM
10042012-07-30 Glenn Morris <rgm@gnu.org>
1005
1006 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
1007 * Makefile.in (config_h): Add conf_post.h.
1008 * makefile.w32-in (CONFIG_H): Add conf_post.h.
1009
adff3182
JD
10102012-07-30 Jan Djärv <jan.h.d@swipnet.se>
1011
1012 * nsterm.m (ns_do_open_file): New variable.
b9031d69 1013 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
1014 (openFile, openTempFile, openFileWithoutUI, openFiles):
1015 Open files only if ns_do_open_file.
adff3182 1016
c32af1e4
PE
10172012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1018
7393bcbb
PE
1019 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
1020 This no-op macro hasn't been needed for many years.
1021 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
1022
c32af1e4
PE
1023 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
1024 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
1025 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
1026 gdb_make_enums_visible.
1027 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
1028 (DIRECTORY_SEP): Now a constant, not a macro.
1029
302fc036
EZ
10302012-07-30 Eli Zaretskii <eliz@gnu.org>
1031
1032 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
1033 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
1034
1035 * w32term.c <w32_keyboard_codepage>: Renamed from
1036 keyboard_codepage and now external. All users changed.
1037
1038 * w32term.h: Add declaration of w32_keyboard_codepage.
1039
1040 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
1041 the codepage to translate keys to Unicode. If this argument is
1042 -1, use the value returned by GetConsoleCP. All callers changed.
1043
88fb40b4
PE
10442012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1045
0aee6912
PE
1046 Update .PHONY listings in makefiles.
1047 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
1048 bootstrap-clean, distclean, maintainer-clean, versioclean,
1049 extraclean, frc.
1050
88fb40b4
PE
1051 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
1052 This is a bit clearer. Fix some commentary typos.
1053
0a763bd1
GM
10542012-07-30 Glenn Morris <rgm@gnu.org>
1055
32bac6d6
GM
1056 * s/netbsd.h: Let configure include signal.h if needed.
1057 Remove file, which is now empty.
1058
b65e7c46
GM
1059 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
1060 Let configure set them.
1061 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
1062 No more need to undefine.
0a763bd1 1063
169304bd
AS
10642012-07-30 Andreas Schwab <schwab@linux-m68k.org>
1065
1066 * keymap.c (Fkey_description): Don't remove 0x80 bit from
1067 non-single-byte char when adding meta modifier. (Bug#12090)
1068
6cd7a139
DA
10692012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1070
1071 Convert safe_call to use variable number of arguments.
1072 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
1073 (safe_call2): Fix comment.
1074 * lisp.h (safe_call): Adjust prototype.
1075 * coding.c (encode_coding_object): Change to use safe_call2.
1076 * xfaces.c (merge_face_heights): Change to use safe_call1.
1077
d34d6ffc
GM
10782012-07-30 Glenn Morris <rgm@gnu.org>
1079
7b8a48e4 1080 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 1081 does that unconditionally. Remove file, which is now empty.
7b8a48e4 1082
d34d6ffc
GM
1083 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
1084 Remove empty files.
1085
03a660a6
PE
10862012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 Export to GDB most of lisp.h's remaining object-like macros.
1089 * lisp.h (min, max): Move earlier, because they're used earlier now.
1090 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
1091 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
1092 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
1093 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
1094 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
1095 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
1096 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
1097 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
1098 Now constants, for GDB. They need not be macros.
1099 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
1100 Now constants, for GDB, as well as macros, for static initializers.
1101 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
1102 Move to after the definition of struct Lisp_Char_Table,
1103 since the former now needs that type defined.
1104 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
1105 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
1106 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
1107 New enums, for gdb_make_enums_visible.
1108 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 1109 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
1110 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
1111 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
1112 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
1113 enum maxargs, enum MAX_ALLOCA.
1114 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
1115 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
1116 no longer needed, now that they are done in lisp.h.
1117
e499d0ee
DA
11182012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1119
1120 Cleanup string bytes checking.
1121 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
1122 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
1123 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
1124 (check_sblock, compact_small_strings): Simplify.
1125
d5040d2d
PE
11262012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
1129 These macros are confusing and no longer need to be defined, as
1130 the enum values now suffice. All uses replaced with definiens.
1131 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
1132
7f259ae6
JB
11332012-07-29 Juanma Barranquero <lekktu@gmail.com>
1134
1135 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
1136 ($(BLD)/w32console.$(O)): Update dependencies.
1137
7e63e0c3
DA
11382012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1139
1140 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
1141 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
1142 time. Adjust users.
1143 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
1144
ffd817eb
JD
11452012-07-29 Jan Djärv <jan.h.d@swipnet.se>
1146
1147 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
1148 setting sitelisp (Bug#12010).
1149
417a7a0e
EZ
11502012-07-29 Eli Zaretskii <eliz@gnu.org>
1151
14ae4239 1152 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
1153
1154 * w32heap.c (cache_system_info):
1155 * w32.c (sys_rename):
1156 * w32proc.c (find_child_console, sys_kill): All users changed.
1157
387d4d92
PE
11582012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1159
1160 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
1161
55a6cca6
EZ
11622012-07-29 Eli Zaretskii <eliz@gnu.org>
1163
1164 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
1165
dbcf001c
DA
11662012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1167
1168 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1169 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1170 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1171
e2688e4a
DA
11722012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1173
1174 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1175 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1176 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1177 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1178 (replace_range, replace_range_2, del_range_2): Change to eassert.
1179 * marker.c (byte_char_debug_check): Adjust style.
1180
b46a6a83
PE
11812012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1182
1183 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1184 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1185 long-ago-commented-out code that talks about "WIN32".
1186 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1187 All uses changed.
1188
e32a5799
PE
11892012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1192 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1193 Simplify by using alignof.
1194 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1195 * lisp.h: Include <stdalign.h>.
1196 (GCALIGNMENT): New macro and constant.
1197 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1198 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1199 (stdalign): New macro, if not already defined.
1200
df81cd29
EZ
12012012-07-28 Eli Zaretskii <eliz@gnu.org>
1202
01bd1b0d
EZ
1203 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1204 * w32inevt.c: Include w32inevt.h.
1205 (w32_read_console_input): New inline function, calls either
1206 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1207 w32_console_unicode_input.
1208 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1209 (w32_kbd_patch_key, key_event): Use the codepage returned by
1210 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1211 (key_event): use uChar.UnicodeChar only if
1212 w32_console_unicode_input is non-zero.
1213
1214 * w32console.c: Include w32heap.h.
1215 <w32_console_unicode_input>: New global variable.
1216 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1217 family of Windows, zero otherwise.
1218
1219 * w32inevt.h: Declare w32_console_unicode_input.
1220
df81cd29
EZ
1221 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1222 --without-x. (Bug#11742)
1223
c20fdd9e
PE
12242012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 Adjust GDB to reflect pvec_type changes (Bug#12036).
1227 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1228 2012-07-04 changes to pseudovector representation.
1229 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1230
32770973 12312012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1232
1233 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1234 bus address.
1235 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1236
3438fe21
EZ
12372012-07-27 Eli Zaretskii <eliz@gnu.org>
1238
bcfbc9de
EZ
1239 * alloc.c (listn): Fix the order the arguments are consed onto the
1240 list.
1241
3438fe21
EZ
1242 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1243 enumeration constants, as PURE and HEAP are too general, and clash
1244 with other headers and sources, such as gmalloc.c and the
1245 MS-Windows system headers. All users changed.
1246
eeaea515
DA
12472012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1248
1249 Revert last save_excursion_save and save_excursion_restore changes.
1250 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1251 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1252
073c88c2
DA
12532012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1254
1255 Fix recently-introduced typos in Windows port.
1256 Reported by Martin Rudalics <rudalics@gmx.at>.
1257 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1258 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1259
4706125e
PE
12602012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1261
1262 Improve GDB symbol export (Bug#12036).
1263 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1264 arms of an 'if', not using conditional expressions; otherwise GDB
1265 complains about the types in the unevaluated arm when the argument
1266 is an integer literal.
1267 (xgetint): Simplify expression.
1268 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1269 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1270 Zaretskii in <http://bugs.gnu.org/12036#13>.
1271 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1272 needed now that we have gdb_make_enums_visible.
1273 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1274 (enum enum_USE_LSB_TAG):
1275 New enum types, packaging up enums that need to be exported to GDB.
1276
694b6c97
DA
12772012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1278
1279 Utility function to make a list from specified amount of objects.
1280 * lisp.h (enum constype): New datatype.
1281 (listn): New prototype.
1282 * alloc.c (listn): New function.
1283 (Fmemory_use_count, syms_of_alloc): Use it.
1284 * buffer.c (syms_of_buffer): Likewise.
1285 * callint.c (syms_of_callint): Likewise.
1286 * charset.c (define_charset_internal): Likewise.
1287 * coding.c (syms_of_coding): Likewise.
1288 * keymap.c (syms_of_keymap): Likewise.
1289 * search.c (syms_of_search): Likewise.
1290 * syntax.c (syms_of_syntax): Likewise.
1291 * w32.c (init_environment): Likewise.
1292 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1293 * xdisp.c (syms_of_xdisp): Likewise.
1294 * xfns.c (syms_of_xfns): Likewise.
1295
6195f384
DA
12962012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1297
1298 Fast save_excursion_save and save_excursion_restore.
1299 * lisp.h (struct Lisp_Excursion): New data type.
1300 (PVEC_EXCURSION): New pseudovector type.
1301 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1302 to deal with it. Adjust comments.
1303 (init_marker, attach_marker): New prototype.
1304 (unchain_marker): Adjust prototype.
1305 * marker.c (attach_marker): Change to global.
1306 (init_marker): New function.
1307 * alloc.c (Fmake_marker, build_marker): Use it.
1308 (build_marker): More easserts.
1309 (mark_object): Handle struct Lisp_Excursion.
1310 * editfns.c (save_excursion_save, save_excursion_restore):
1311 Reimplement to use struct Lisp_Excursion. Add comments.
1312
5eceb8fb
PE
13132012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1314
1315 Fix export of symbols to GDB (Bug#12036).
1316 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1317 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1318 emacs.c, as this is a more-suitable home. Had this been done earlier
1319 the fix for 12036 would have avoided some of the problems noted in
1320 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1321 would have been more obvious.
562157c8
PE
1322 * emacs.c: Do not include <verify.h>; no longer needed.
1323 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1324 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1325 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1326 Remove; now done in lisp.h.
1327 * lisp.h (PUBLISH_TO_GDB): New macro.
1328 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1329 (DATA_SEG_BITS): Use it.
1330 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1331 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1332 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1333 not be usable in #if. This simplifies things.
1334
d6749401
JB
13352012-07-26 Juanma Barranquero <lekktu@gmail.com>
1336
1337 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1338
1781b9e9
PE
13392012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1340
d89518db 1341 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1342 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1343 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1344 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1345 Adjust to changes in lisp.h and emacs.c, by using
1346 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1347 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1348 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1349 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1350 instead of gdb_valbits.
1351 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1352 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1353 instead of gdb_array_mark_flag.
1354 (xboolvector): Get size from $->size, not $->header.size.
1355 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1356 (xreload, hook-run, hookpost-run): Remove.
1357 * emacs.c: Include <verify.h>.
1358 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1359 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1360 Remove.
1361 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1362 (gdb_USE_LSB_TAG): New enum constants.
1363 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1364 Also define these as enum constants, so they're visible to GDB.
1365 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1366 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1367 as constants, so they're visible to GDB.
1368 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1369 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1370 Now enum constants, not macros, so they're visible to GDB.
1371 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1372 more convenient now. All uses changed.
1373 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1374 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1375
3628596a
DA
13762012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1377
1378 Explicitly free restriction data that are not needed anymore.
1379 * editfns.c (save_restriction_restore): Free restriction data.
1380
7abaf5cc
SM
13812012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1382
1383 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1384 add argument, tune behavior, and adjust all callers.
1385
71f88e00
PE
13862012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 Use typedef for EMACS_INT, EMACS_UINT.
1389 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1390 than macros. This simplifies debugging in the usual case, since
1391 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1392 and it allows expressions involving EMACS_INT casts.
1393 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1394
57ec3034
JD
13952012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1396
1397 * nsterm.m (ns_read_socket): Return early if there is a modal
1398 window (Bug#12043).
1399
8137e7b3
MR
14002012-07-25 Martin Rudalics <rudalics@gmx.at>
1401
1402 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1403 that FOCUS-FRAME can be omitted.
1404
04e9897c
DA
14052012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1406
1407 Adjust buffer text indirection counters at the end of Fkill_buffer.
1408 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1409 buffer is definitely dead. This should really fix an issue reported
1410 by Christoph Scholtes again. (Bug#12007).
1411 (init_buffer_once): Initialize indirection counters of
1412 buffer_defaults and buffer_local_symbols (for sanity and safety).
1413
8a0484e1
EZ
14142012-07-24 Eli Zaretskii <eliz@gnu.org>
1415
1416 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1417 and continuation glyphs on tooltip frames, leave them at zero.
1418 Avoids continued lines in tooltips. (Bug#11832)
1419
fa691a83
DA
14202012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1421
1422 Simplify copy_overlay.
04e9897c 1423 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1424 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1425
436bc8e0
EZ
14262012-07-23 Eli Zaretskii <eliz@gnu.org>
1427
1428 * print.c (print_object): Don't crash when a frame's name is nil
1429 or invalid. (Bug#12025)
1430
1431 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1432 it signals an error when a tooltip frame is being created.
1433
d7a7fda3
DA
14342012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1435
1436 Cleanup miscellaneous objects allocation and initialization.
1437 * alloc.c (allocate_misc): Change to static. Add argument to
1438 specify the subtype. Adjust comment and users.
1439 (build_overlay): New function.
1440 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1441 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1442 (allocate_misc): Remove prototype.
1443 (build_overlay): Add prototype.
1444
14452012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1446
1447 Swap buffer text indirection counters in Fbuffer_swap_text.
1448 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1449 This avoids crash reported by Christoph Scholtes at
1450 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1451
9d7fa573
JD
14522012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1453
1454 * nsmenu.m (Popdown_data): New struct.
1455 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1456 free Popdown_data.
1457 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1458 (initWithContentRect): Make imgView and contentView non-static
1459 and autorelease them. Also autorelease img and matrix (Bug#12005).
1460 (dealloc): Remove (Bug#12005).
1461
0dd6d66d
DA
14622012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1463
1464 Adjust consing_since_gc when objects are explicitly freed.
1465 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1466 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1467 (free_cons, free_misc): Subtract object size from consing_since_gc.
1468
d36d71df
DA
14692012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1470
1471 Simplify and cleanup markers positioning code.
1472 * marker.c (attach_marker): More useful eassert.
1473 (live_buffer, set_marker_internal): New function.
1474 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1475 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1476
fb9ea40f
PE
14772012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1478
1479 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1480 as it's limited by the amount of memory, not by INT_MAX.
1481
2d5c5f7d
EZ
14822012-07-21 Eli Zaretskii <eliz@gnu.org>
1483
07fb592e
EZ
1484 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1485 in special-event-map. See the discussion at
1486 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1487 for the reasons.
1488
37a9eac8 1489 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1490 info.dwItemData. Fixes crashes on 64-bit Windows.
1491 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1492
c4328746
JD
14932012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1494
1495 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1496 (conversationIdentifier): Return value is NSInteger.
784051c4 1497 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1498
6e5d1c12
CY
14992012-07-21 Chong Yidong <cyd@gnu.org>
1500
1501 * window.c (decode_any_window): Signal an error if the window is
1502 on a dead frame (Bug#11984).
1503
9928463d
DA
15042012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1505
1506 Add indirection counting to speed up Fkill_buffer.
1507 * buffer.h (struct buffer): New member.
1508 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1509 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1510 base buffer indirection counter.
1511 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1512 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1513 through buffer list if indirection counter is 0.
1514
f8643a6b
DA
15152012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1516
1517 Extend the value returned by Fgarbage_collect with heap statistics.
1518 * alloc.c (Qheap): New symbol.
1519 (syms_of_alloc): DEFSYM it.
1520 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1521 (Fmemory_free): Remove.
1522 (syms_of_alloc): Don't defsubr it.
1523 * buffer.c (Fcompact_buffer): Remove.
1524 (syms_of_buffer): Don't defsubr it.
1525
dac616ff
DA
15262012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1527
1528 Make maybe_gc inline.
1529 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1530 * lisp.h (consing_since_gc, gc_relative_threshold)
1531 (memory_full_cons_threshold): Revert declaration.
1532 (maybe_gc): Remove prototype, define as inline.
1533 * alloc.c: Remove old commented-out code.
1534 (consing_since_gc, gc_relative_threshold)
1535 (memory_full_cons_threshold): Revert to global.
1536 (maybe_gc): Remove.
1537
d7ea76b4
DA
15382012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1539
1540 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1541 * lisp.h (build_unibyte_string): New function.
1542 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1543 * sysdep.c, w32fns.c, xfns.c: Use it.
1544 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1545 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1546 Adjust users accordingly.
1547 * font.h (font_open_by_name): Adjust prototype.
1548
765e61e3
DA
15492012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1550
1551 Cleanup calls to Fgarbage_collect.
1552 * lisp.h (maybe_gc): New prototype.
1553 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1554 Remove declarations.
1555 * alloc.c (maybe_gc): New function.
1556 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1557 Make them static.
1558 * bytecode.c (MAYBE_GC): Use maybe_gc.
1559 * eval.c (eval_sub, Ffuncall): Likewise.
1560 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1561 to avoid dependency from auto-save feature.
1562
52b852c7
PE
15632012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1564
1565 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1566 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1567 'for_each_per_buffer_object_at'.
1568 All uses changed. It's better to use upper-case for macros that
1569 cannot be implemented as functions, to give the reader a clue
1570 that they're special.
1571
5db81e33
SM
15722012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1573
1574 * alloc.c (Fgarbage_collect): Tweak docstring.
1575
5b835e1d
DA
15762012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1577
1578 Tweak the value returned from Fgarbage_collect again.
1579 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1580 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1581 Adjust documentation.
1582 (total_vector_bytes): Rename to total_vector_slots, adjust
1583 accounting.
1584 (total_free_vector_bytes): Rename to total_free_vector_slots,
1585 adjust accounting.
1586 (Qstring_bytes, Qvector_slots): New symbols.
1587 (syms_of_alloc): DEFSYM them.
1588
9cd47b72
DA
15892012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1590
1591 Buffer compaction primitive which may be used from Lisp.
1592 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1593 (syms_of_buffer): Register Fcompact_buffer.
1594 * alloc.c (Fgarbage_collect): Use compact_buffer.
1595 * buffer.h (compact_buffer): New prototype.
1596 (struct buffer_text): New member.
1597
d17337e5
DA
15982012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1599
1600 New macro to iterate over all buffers, miscellaneous cleanups.
1601 * lisp.h (all_buffers): Remove declaration.
1602 * buffer.h (all_buffers): Add declaration, with comment.
1603 (for_each_buffer): New macro.
1604 * alloc.c (Fgarbage_collect, mark_object): Use it.
1605 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1606 (init_buffer): Likewise.
1607 * data.c (Fset_default): Likewise.
1608 * coding.c (code_conversion_restore): Remove redundant check
1609 for dead buffer.
1610 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1611
60cfd278
AS
16122012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1613
1614 Fix bug that created negative-length intervals.
1615 * intervals.c (merge_interval_right, merge_interval_left):
1616 Do not zero out this interval if it is absorbed by its children,
1617 as this interval's total length doesn't change in that case. See
1618 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1619
d06714cb
PE
16202012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1621
83713154
PE
1622 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1623 when invoking (make-bool-vector N t) and N is a positive
1624 multiple of 8 -- the last 8 bits were mistakenly cleared.
1625
d06714cb
PE
1626 Remove some struct layout assumptions in bool vectors.
1627 * alloc.c (bool_header_size): New constant.
1628 (header_size, word_size): Move earlier, as they're now used earlier.
1629 Use 'word_size' in a few more places, where it's appropriate.
1630 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1631 padding before the data member of a bool vector.
1632 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1633 than doing the check by hand with an abort ().
1634
464d5a5e
SM
16352012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1636
5fbc0409
SM
1637 * eval.c (Fdefvar): Don't check constants since we only set the var if
1638 it's not yet defined anyway (bug#11904).
1639
464d5a5e
SM
1640 * lisp.h (last_undo_boundary): Declare new var.
1641 * keyboard.c (command_loop_1): Set it.
1642 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1643 were auto-added by the command loop (bug#11774).
1644
8dc2e44a
AS
16452012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1646
1647 * w32font.c (Qsymbol): Remove local definition.
1648 (syms_of_w32font): Don't DEFSYM it.
1649
169925ec
DA
16502012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1651
1652 Fix sweep_vectors to handle large bool vectors correctly.
1653 * alloc.c (sweep_vectors): Account total_vector_bytes for
1654 bool vectors larger than VBLOCK_BYTES_MAX.
1655
5fbfb018
CY
16562012-07-18 Chong Yidong <cyd@gnu.org>
1657
1658 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1659 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1660
3ab6e069
DA
16612012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1662
1663 Return more descriptive data from Fgarbage_collect.
1664 Suggested by Stefan Monnier in
1665 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1666 * alloc.c (bounded_number): New function.
1667 (total_buffers, total_vectors): New variable.
1668 (total_string_size): Rename to total_string_bytes, adjust users.
1669 (total_vector_size): Rename to total_vector_bytes, adjust users.
1670 (sweep_vectors): Account total_vectors and total_vector_bytes.
1671 (Fgarbage_collect): New return value. Adjust documentation.
1672 (gc_sweep): Account total_buffers.
1673 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1674 (VECTOR_SIZE): Remove.
1675 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1676 (Qinterval, Qmisc): New symbols.
1677 (syms_of_data): Initialize them.
1678 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1679 (Qcons, Qbuffer): New declarations.
1680
6d02fe5b
PE
16812012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1682
1683 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1684 Round up, not down. Improve doc.
1685
b7ffe040
DA
16862012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1687
1688 Restore old code in allocate_string_data to avoid Faset breakage.
1689 Reported by Julien Danjou <julien@danjou.info> in
1690 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1691 * alloc.c (allocate_string_data): Restore old code with minor
1692 adjustments, fix comment to explain this subtle issue.
1693
4dc7c8d5
SM
16942012-07-17 Eli Zaretskii <eliz@gnu.org>
1695
1696 Remove FILE_SYSTEM_CASE.
1697 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1698
1699 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1700 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1701 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1702 call-process-region passes it through expand-file-name.
1703
1704 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1705
17062012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1707
1708 Fix crash when creating indirect buffer (Bug#11917)
1709 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1710 Don't handle unbound variables specially if non-zero.
1711 (Fbuffer_local_variables): Pass zero.
1712 (clone_per_buffer_values): Pass non-zero.
1713
17142012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1715
1716 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1717 to make the loop interruptible.
1718
17192012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1720
1721 * gnutls.c (emacs_gnutls_handshake): Only retry if
1722 GNUTLS_E_INTERRUPTED.
1723
cce7fefc
DA
17242012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1725
1726 Cleanup and convert miscellaneous checks to eassert.
1727 * alloc.c (mark_interval): Fix comment, partially rephrase
1728 old comment from intervals.h (see below).
1729 * intervals.c (find_interval, adjust_intervals_for_insertion)
1730 (delete_interval, adjust_intervals_for_deletion)
1731 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1732 Convert to eassert.
1733 (adjust_intervals_for_insertion, make_new_interval):
1734 Remove obsolete and unused code.
1735 * intervals.h (struct interval): Remove obsolete comment.
1736 * textprotp.c (erase_properties): Remove unused code.
1737 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1738 (Fremove_list_of_text_properties): Convert to eassert.
1739
9ea10cc3
CY
17402012-07-17 Chong Yidong <cyd@gnu.org>
1741
1742 * editfns.c (Finsert_char): Doc fix.
1743
3900d5de
DA
17442012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1745
1746 Fix previous change to make Fmemory_free always accurate.
1747 * alloc.c (make_interval): Update total_free_intervals.
1748 (make_float): Likewise for total_free_floats.
1749 (free_cons, Fcons): Likewise for total_free_conses.
1750 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1751 Likewise for total_free_vector_bytes.
1752 (Fmake_symbol): Likewise for total_free_symbols.
1753 (bytes_free): Remove.
1754
7098646f
DA
17552012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1756
1757 Simple free memory accounting feature.
1758 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1759 (sweep_vectors): Accumulate size of free vectors.
1760 (Fgarbage_collect): Setup bytes_free.
1761 (Fmemory_free): New function.
1762 (syms_of_alloc): Register it.
1763
22657b40
DA
17642012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1765
1766 Cleanup overlays checking.
1767 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1768 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1769 eassert and OVERLAYP.
1770 (sort_overlays): Change to use OVERLAYP.
1771
ddfc8813
RK
17722012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1773
1774 * editfns.c (Finsert_char): Make it interactive, and make the
1775 second arg optional. Copy interactive spec and docstring from
1776 ucs-insert.
1777
7c26cf3c
PE
17782012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1779
1780 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1781 Unlike the other wrapped functions, fabs has an unspecified
1782 effect on errno.
1783
5d127af9
JD
17842012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1785
1786 * nsterm.m (keyDown): Interpret flags without left/right bits
1787 as the left key (Bug#11670).
1788
6a0dd1d7
DA
17892012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1790
1791 Remove empty and useless init functions.
1792 * lisp.h (init_character_once, init_fns, init_image)
1793 (init_filelock, init_sound): Remove prototype.
1794 * character.c (init_character_once): Remove.
1795 * filelock.c (init_filelock): Likewise.
1796 * fns.c (init_fns): Likewise.
1797 * image.c (init_image): Likewise.
1798 * sound.c (init_sound): Likewise.
1799 * emacs.c (main): Adjust accordingly.
1800
7a6136fd
DA
18012012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1802
1803 * gtkutil.h: Tiny cleanups.
1804 (use_old_gtk_file_dialog): Remove useless declaration.
1805 (xg_uses_old_file_dialog): Add suggested const attribute.
1806
ce811ad9
EZ
18072012-07-15 Eli Zaretskii <eliz@gnu.org>
1808
1809 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1810 (bidi_paragraph_init): Use it to limit search forward for a strong
1811 directional character in abnormally large paragraphs full of
1812 neutral or weak characters. (Bug#11943)
1813
c9adfeaa
SF
18142012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1815
1816 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1817 the toolbar (Bug#9451).
1818 (xg_make_tool_item): Give the widget event box a transparent
1819 background.
1820
fff62aa9
DA
18212012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1822
1823 Cleanup basic allocation variables and functions.
1824 * alloc.c (ignore_warnings, init_intervals, init_float)
1825 (init_cons, init_symbol, init_marker): Remove.
1826 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1827 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1828 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1829 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1830 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1831 (staticidx, init_alloc_once, init_strings, free_ablock):
1832 Remove redundant initialization.
1833 * fns.c (init_weak_hash_tables): Remove.
1834 * lisp.h (init_weak_hash_tables): Remove prototype.
1835
9730daca
DA
18362012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1837
1838 Use zero_vector where appropriate.
1839 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1840 accordingly.
1841 * lisp.h (zero_vector): New declaration.
1842 * font.c (null_vector): Remove.
1843 (syms_of_font): Remove initialization and staticpro.
1844 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1845 * keymap.c (Faccessible_keymaps): Likewise.
1846
2e2d2a13
LL
18472012-07-15 Leo Liu <sdl.web@gmail.com>
1848
1849 * fringe.c: Fix typo in comments.
1850
cd276f6e
LL
18512012-07-14 Leo Liu <sdl.web@gmail.com>
1852
1853 * fringe.c: Add a new bitmap exclamation-mark.
1854
5a1131d9
EZ
18552012-07-14 Eli Zaretskii <eliz@gnu.org>
1856
1857 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1858
1859 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1860 (HAVE_MENUS): Don't define, defined by editing config.in with
1861 msdos/sed2v2.inp.
1862 (GMALLOC_INHIBIT_VALLOC): Don't define.
1863 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1864
22e983b7
JB
18652012-07-14 Juanma Barranquero <lekktu@gmail.com>
1866
1867 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1868
5b3f250f
GM
18692012-07-14 Glenn Morris <rgm@gnu.org>
1870
1871 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1872 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1873 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1874
33d63ff4
GM
18752012-07-13 Glenn Morris <rgm@gnu.org>
1876
5b633342
GM
1877 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1878
33d63ff4
GM
1879 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1880 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1881
b55b9f85
JD
18822012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1883
0dc8cf50
JD
1884 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1885 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1886 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1887 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1888 where appropriate.
1889 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1890 as boolean expression.
1891 (x_set_window_size): Remove unused variable toolbar.
1892 (ns_get_color_default, ns_mod_to_lisp): Remove.
1893 (ns_mouse_position): Remove unused variables xchar and ychar.
1894 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1895 (ns_set_vertical_scroll_bar): Remove unused variable count.
1896 (ns_delete_terminal): Remove unused variable i.
1897 (ns_term_init): Remove unused variables r, g and b.
1898 (mouseDown): Remove unused variable window.
1899 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1900 (initFrameFromEmacs): Remove unused variable vbextra.
1901 (mouseEntered): Remove unused variables p and dpyinfo.
1902 (mouseExited): Remove unused variables p and r.
1903 (ns_define_frame_cursor, ns_clear_frame_area)
1904 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1905 (menuDown): Assign [sender tag] to variable and cast the variable.
1906
1907 * nsterm.h (menuDown): Add id as type to argument sender.
1908 (ns_display_info_for_name): Add Lisp_Object argument.
1909 (ns_term_init): Add Lisp_Object argument.
1910 (ns_map_event_to_object): Add void argument.
1911 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1912 prototype with arguments and only declare if __OBJC__.
1913 (nxatoms_of_nsselect): Add void argument.
1914 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1915 (ns_alloc_autorelease_pool): Add void argument.
1916 (ns_release_autorelease_pool): Add void* argument.
1917 (ns_get_defaults_value): Add const char* argument.
1918
1919 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1920 (initFromContents): Use SSDATA where appropriate.
1921 (ns_update_menubar): Add braces to ambigous if-else.
1922 (initWithTitle): Put () around assignment in if statement.
1923 (ns_menu_show): Remove unused variables window and keymap.
1924 (update_frame_tool_bar): Remove unused variable selected_p.
1925 (initWithContentRect): Remove unused variable this_cmd_name.
1926
1927 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1928 appropriate.
1929 (setXBMColor): Remove unused variable len.
1930 (setPixmapData): Put () around assignment in loop statement.
1931
1932 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1933 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1934 where appropriate.
1935 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1936 around assignment in loop statement.
1937 (nsfont_open): Remove unused variable i.
1938 (nsfont_open): Remove unused variable len.
1939 (nsfont_draw): Remove unused variable cs.
1940
1941 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1942 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1943 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1944 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1945 (Fns_font_name, Fns_perform_service)
1946 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1947 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1948 (ns_set_name): Remove unused variable view.
1949 (x_set_menu_bar_lines): Remove unused variable olines.
1950 (x_set_tool_bar_lines): Remove unused variable root_window.
1951 (Fns_list_colors): Put () around assignment in while statement.
1952 (Fns_perform_service): Remove unused variable len.
1953 (Fns_display_usable_bounds): Remove unused variable top.
1954 (syms_of_nsfns): Remove unused variable i.
1955
b55b9f85
JD
1956 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1957 memcpy (Bug#11907).
1958
ed9265fc 19592012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1960
1961 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1962 and free it with DestroyExceptionInfo (Bug#11558).
1963
ef099b57
JB
19642012-07-13 Juanma Barranquero <lekktu@gmail.com>
1965
1966 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1967 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1968 Set here, not in nt/config.nt.
1969
ea814a5d
EZ
19702012-07-13 Eli Zaretskii <eliz@gnu.org>
1971
1972 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1973 cursor overflow into the last glyph on display line when the right
1974 fringe is off. (Bug#11832)
1975
1a952767
PE
19762012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1977
1978 * xdisp.c (produce_special_glyphs): Now static.
1979 * dispextern.h (produce_special_glyphs): Remove decl.
1980
983188fd
GM
19812012-07-13 Glenn Morris <rgm@gnu.org>
1982
8d7c7eed 1983 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1984 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1985
983188fd
GM
1986 * s/usg5-4-common.h (USG, USG5):
1987 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1988 * s/sol2-6.h (SOLARIS2):
1989 * s/irix6-5.h (IRIX6_5):
1990 * s/hpux10-20.h (USG, USG5, HPUX):
1991 * s/gnu-linux.h (USG, GNU_LINUX):
1992 * s/freebsd.h (BSD_SYSTEM):
1993 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1994 * s/cygwin.h (CYGWIN):
1995 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1996 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1997
d1e68667 19982012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1999
2000 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 2001
6de0e799
GM
20022012-07-13 Glenn Morris <rgm@gnu.org>
2003
739ae010
GM
2004 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
2005
dbee5793
GM
2006 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
2007
6de0e799
GM
2008 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
2009 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
2010
b82da769
GM
20112012-07-12 Glenn Morris <rgm@gnu.org>
2012
4fae5a7a 2013 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
2014
2015 * process.c (init_process_emacs): Rename from init_process.
2016 The old name is also the name of a Mach system call.
2017 * lisp.h, emacs.c: Update for this name change.
2018 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
2019 longer needed.
2020
5a979817
EZ
20212012-07-12 Eli Zaretskii <eliz@gnu.org>
2022
2023 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
2024 memmove call that removes glyphs covered by the left truncation
2025 glyph. Improve commentary.
2026 (display_line): Fix display of continuation glyphs on GUI frames
2027 when the right fringe is turned off and variable-size fonts are
2028 used in the window. Move the code that appends a stretch glyph to
2029 produce_special_glyphs, so that it could be used for truncation
2030 and continuation glyphs alike.
2031 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
2032 glyph of a suitably computed width, to align the special glyphs at
2033 the window margin. Code moved from display_line. (Bug#11832)
2034
3e91a053
GM
20352012-07-12 Glenn Morris <rgm@gnu.org>
2036
ba9e4b84
GM
2037 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
2038
2039 * s/gnu-linux.h, s/hpux10-20.h:
2040 Do not unconditionally define HAVE_XRMSETDATABASE.
2041
3e91a053
GM
2042 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
2043
b300b1f4
PE
20442012-07-12 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 Fix typos that broke OS X build.
2047 Reported by Randal L. Schwartz in
2048 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
2049 * nsterm.m (ns_timeout): Add missing local decl.
2050 (ns_get_color): snprintf -> sprintf, to fix typo.
2051
6e777848
GM
20522012-07-12 Glenn Morris <rgm@gnu.org>
2053
3f922c37
GM
2054 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
2055 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
2056 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
2057 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
2058
0ab7b23a
GM
2059 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
2060 Move PTY_OPEN to configure.
2061
6e777848
GM
2062 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2063 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
2064 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
2065
4a7edc24
DA
20662012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
2067
2068 Use empty_unibyte_string where applicable.
2069 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
2070 * lread.c (read1): Likewise.
2071 * xsettings.c (syms_of_xsettings): Likewise.
2072
308aab79
GM
20732012-07-12 Glenn Morris <rgm@gnu.org>
2074
42bd1719
GM
2075 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
2076 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
2077 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
2078 * s/hpux10-20.h (RUN_TIME_REMAP):
2079 * s/bsd-common.h (TABDLY): Move to configure.
2080
2081 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
2082
2083 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
2084
ea0bbd17 2085 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 2086 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
2087
2088 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 2089
308aab79
GM
2090 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
2091 * s/template.h: Move NARROWPROTO to configure.
2092
ee1cf5cf
GM
20932012-07-11 Glenn Morris <rgm@gnu.org>
2094
30fe9bf4
GM
2095 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
2096 unused since 2011-01-17 change to systty.h.
2097
ee1cf5cf
GM
2098 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
2099 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2100 Move HAVE_PTYS and HAVE_SOCKETS to configure.
2101
63e47e07
PE
21022012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2103
2104 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
2105
c43fb4c3
GM
21062012-07-11 Glenn Morris <rgm@gnu.org>
2107
2108 * s/darwin.h, s/gnu-linux.h, s/template.h:
2109 Move INTERRUPT_INPUT to configure.
2110
e8df9267
DA
21112012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2112
2113 Minor adjustments to interning code.
2114 * lisp.h (intern, intern_c_string): Redefine as static inline
2115 wrappers for intern_1 and intern_c_string_1, respectively.
2116 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
2117 * lread.c (intern_1, intern_c_string_1, oblookup):
2118 Simplify Vobarray checking.
e8df9267
DA
2119 * font.c (font_intern_prop): Likewise. Adjust comment.
2120 * w32font.c (intern_font_name): Likewise.
2121
34348bd4
AS
21222012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2123
d96a1e0c
AS
2124 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
2125
34348bd4
AS
2126 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
2127 of Fcar/Fcdr if possible.
2128 * font.c (check_otf_features): Likewise.
2129 * fontset.c (Fnew_fontset): Likewise.
2130 * gnutls.c (Fgnutls_boot): Likewise.
2131 * minibuf.c (read_minibuf): Likewise.
2132 * msdos.c (IT_set_frame_parameters): Likewise.
2133 * xmenu.c (Fx_popup_dialog): Likewise.
2134 * w32menu.c (Fx_popup_dialog): Likewise.
2135
c8add24e
GM
21362012-07-11 Glenn Morris <rgm@gnu.org>
2137
4b575b3c
GM
2138 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
2139 since nothing has defined it on these platforms.
2140
09f4e3b0
GM
2141 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
2142 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
2143
172bedef
GM
2144 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2145 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2146 Move CLASH_DETECTION to configure.
2147
249685df
GM
2148 * s/gnu.h: Remove file, which is now empty.
2149
c8add24e
GM
2150 * s/gnu.h, s/gnu-linux.h:
2151 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
2152
b41253a3
JW
21532012-07-11 John Wiegley <johnw@newartisans.com>
2154
2155 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
2156 function attribute, so we only use it if it exists in the
2157 compiler.
2158
d923b542
DA
21592012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2160
2161 Avoid call to strlen in fast_c_string_match_ignore_case.
2162 * search.c (fast_c_string_match_ignore_case): Change to use
2163 length argument. Adjust users accordingly.
2164 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
2165
5ebbef1d
PE
21662012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2167
bb352260
PE
2168 Assume mkdir, rmdir.
2169 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2170 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2171
57054ddd
PE
2172 Assume rename.
2173 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2174
b747d3f7
PE
2175 Assume perror.
2176 * s/hpux10-20.h (HAVE_PERROR): Remove.
2177 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2178 Remove dummy definition, as this problem was obsolete long ago.
2179
5ebbef1d
PE
2180 Assume strerror.
2181 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2182
984e7f30
DA
21832012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2184
2185 Avoid calls to strlen in font processing functions.
2186 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2187 (font_open_by_name): Change to use length argument.
2188 Adjust users accordingly.
d923b542
DA
2189 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2190 Adjust prototypes.
2191 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2192 Change to return ptrdiff_t.
984e7f30
DA
2193 (xfont_list_pattern, xfont_match): Use length returned by
2194 xfont_decode_coding_xlfd.
2195 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2196
20e94fdd
GM
21972012-07-11 Glenn Morris <rgm@gnu.org>
2198
9d596af3
GM
2199 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2200 Move DONT_REOPEN_PTY to configure.
2201
20e94fdd
GM
2202 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2203 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2204
e99a530f
PE
22052012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2206
22ffb973
PE
2207 Remove "#define unix" that is no longer needed (Bug#11905).
2208 * s/aix4-2.h (unix): Remove; no longer needed.
2209
e9a9ae03
PE
2210 EMACS_TIME simplification (Bug#11875).
2211 This replaces macros (which typically do not work in GDB)
2212 with functions, typedefs and enums, making the code easier to debug.
2213 The functional style also makes code easier to read and maintain.
2214 * systime.h: Include <sys/time.h> on all hosts, not just if
2215 WINDOWSNT, since 'struct timeval' is needed in general.
2216 (EMACS_TIME): Now a typedef, not a macro.
2217 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2218 not macros.
2219 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2220 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2221 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2222 (EMACS_TIME_LE): Now functions, not macros.
2223 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2224 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2225 which are not functions. All uses rewritten to use:
2226 (make_emacs_time): New function.
2227 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2228 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2229 not functions. All uses rewritten to use the following, respectively:
2230 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2231 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2232 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2233 * fileio.c (Fcopy_file):
2234 * xterm.c (XTflash): Get the current time closer to when it's used.
2235 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2236
ffacb126
PE
2237 * bytecode.c (targets): Suppress -Woverride-init warnings.
2238
e99a530f
PE
2239 Simplify by avoiding confusing use of strncpy etc.
2240 * doc.c (Fsnarf_documentation):
2241 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2242 * frame.c (Fmake_terminal_frame):
2243 * gtkutil.c (get_utf8_string):
2244 * lread.c (openp):
2245 * nsmenu.m (ns_update_menubar):
2246 * regex.c (regerror):
2247 Prefer memcpy to strncpy and strncat when either will do.
2248 * fileio.c (Fsubstitute_in_file_name):
2249 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2250 (menu_separator_name_p):
2251 * nsmenu.m (ns_update_menubar):
2252 Prefer memcmp to strncmp when either will do.
2253 * nsterm.m: Include <ftoastr.h>.
2254 (ns_get_color):
2255 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2256 Prefer snprintf to strncpy.
2257 * nsterm.m (ns_term_init):
2258 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2259 * nsterm.m (ns_term_init):
2260 Avoid the need for strncpy, by using build_string or
2261 make_unibyte_string directly. Use dtoastr, not snprintf.
2262 * process.c (Fmake_network_process): Diagnose service names that
2263 are too long, rather than silently truncating them or creating
2264 non-null-terminated names.
2265 (Fnetwork_interface_info): Likewise, for interface names.
2266 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2267 Prefer sprintf to strncat.
2268 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2269 Prefer vsnprintf to vsprintf + strncpy.
2270
c59592b3
GM
22712012-07-10 Glenn Morris <rgm@gnu.org>
2272
2273 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2274 Clarify fallback case.
2275
7d7bbefd
DA
22762012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2277
2278 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2279 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2280 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2281 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2282 where argument type is known to be a Lisp_Cons.
2283
3a4c8000
TT
22842012-07-10 Tom Tromey <tromey@redhat.com>
2285
2286 * bytecode.c (BYTE_CODE_THREADED): New macro.
2287 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2288 (enum byte_code_op): New type.
2289 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2290 (exec_byte_code): Use them. Use token threading when applicable.
2291
2a0213a6
DA
22922012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2293
2294 Optimize pure C strings initialization.
2295 * lisp.h (make_pure_string): Fix prototype.
2296 (build_pure_c_string): New function, defined as static inline. This
2297 provides a better opportunity to optimize away calls to strlen when
2298 the function is called with compile-time constant argument.
2299 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2300 argument, adjust users accordingly. Use build_pure_c_string where
2301 appropriate.
2302 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2303 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2304 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2305
cb1caeaf
DA
23062012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2307
2308 Avoid calls to strlen in miscellaneous functions.
2309 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2310 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2311 * lread.c (openp): Likewise.
2312
c293e30c
DA
23132012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2314
2315 Avoid calls to strlen in path processing functions.
2316 * fileio.c (file_name_as_directory): Add comment. Change to add
2317 srclen argument and return the length of result. Adjust users
2318 accordingly.
2319 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2320 swap 1st and 2nd arguments to obey the common convention.
2321 Adjust users accordingly.
c293e30c
DA
2322 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2323
9e059e3f
GM
23242012-07-10 Glenn Morris <rgm@gnu.org>
2325
d02eb359
GM
2326 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2327 Move PENDING_OUTPUT_COUNT definition to configure.
2328
882cf227
GM
2329 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2330 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2331 * s/gnu.h (DATA_START): Move definitions to configure.
2332
af6e839f
GM
2333 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2334 We include usg5-4-common.h, which defines them both.
2335
40289a12
GM
2336 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2337 O_RDONLY already includes it).
2338
9e059e3f
GM
2339 Stop ns builds setting the EMACSLOADPATH environment variable.
2340 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2341 Now it does not set EMACSLOADPATH, just returns the load-path string.
2342 * nsterm.h: Update accordingly.
2343 * lread.c [HAVE_NS]: Include nsterm.h.
2344 (init_lread) [HAVE_NS]: Use ns_load_path.
2345 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2346
7c4e8ec0
GM
23472012-07-09 Glenn Morris <rgm@gnu.org>
2348
d4f600ff
GM
2349 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2350 since the included bsd-common.h does so.
2351
cbb31951
GM
2352 Stop ns builds setting the EMACSPATH environment variable.
2353 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2354 (ns_init_paths): Do not set EMACSPATH.
2355 * nsterm.h (ns_exec_path): Add it.
2356 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2357 Use ns_exec_path.
2358
7c4e8ec0
GM
2359 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2360
26bccfae
PE
23612012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2362
a0bee46f
PE
2363 * process.c (wait_reading_process_output): 'waitchannels' was unset
2364 when read_kbd || !NILP (wait_for_cell); fix this.
2365
5994c183
PE
2366 Add GCC-style 'const' attribute to functions that can use it.
2367 * character.h (char_resolve_modifier_mask):
2368 * keyboard.h (make_ctrl_char):
2369 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2370 (init_character_once, next_almost_prime, init_fns, init_image)
2371 (flush_pending_output, init_sound):
2372 * mem-limits.h (start_of_data):
2373 * menu.h (finish_menu_items):
2374 Add ATTRIBUTE_CONST.
2375 * emacs.c (DEFINE_DUMMY_FUNCTION):
2376 Declare the dummy function with ATTRIBUTE_CONST.
2377 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2378 Add decls with ATTRIBUTE_CONST.
2379
26bccfae
PE
2380 Minor improvements to make_formatted_string.
2381 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2382 where int is good enough, as vsprintf returns an int.
2383 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2384
a8290ec3
DA
23852012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2386
2387 Use make_formatted_string to avoid double length calculation.
2388 * lisp.h (make_formatted_string): New prototype.
2389 * alloc.c (make_formatted_string): New function.
2390 * buffer.c (Fgenerate_new_buffer_name): Use it.
2391 * dbus.c (syms_of_dbusbind): Likewise.
2392 * editfns.c (Fcurrent_time_zone): Likewise.
2393 * filelock.c (get_boot_time): Likewise.
2394 * frame.c (make_terminal_frame, set_term_frame_name)
2395 (x_report_frame_params): Likewise.
2396 * image.c (gs_load): Likewise.
2397 * minibuf.c (get_minibuffer): Likewise.
2398 * msdos.c (dos_set_window_size): Likewise.
2399 * process.c (make_process): Likewise.
2400 * xdisp.c (ensure_echo_area_buffers): Likewise.
2401 * xsettings.c (apply_xft_settings): Likewise.
2402
d01ba2f1
GM
24032012-07-09 Glenn Morris <rgm@gnu.org>
2404
2405 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2406 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2407 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2408 * nsterm.h (ns_etc_directory): Add it.
2409 * callproc.c [HAVE_NS]: Include nsterm.h.
2410 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2411
f1f924b6
DA
24122012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2413
2414 Move marker debugging code under MARKER_DEBUG.
2415 * marker.c (MARKER_DEBUG): Move marker debugging code under
2416 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2417 for bootstrap with --enable-checking (~3x slowdown reported
2418 by Juanma Barranquero <lekktu@gmail.com>).
2419 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2420
ab531b66
PE
24212012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2424 See <http://bugs.gnu.org/11825#29>.
2425
c4b3bc8a
EZ
24262012-07-08 Eli Zaretskii <eliz@gnu.org>
2427
2428 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2429 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2430 (display_line): Add commentary about displaying truncation glyphs
2431 on GUI frames.
2432 (produce_special_glyphs): Move here from term.c.
2433
2434 * term.c (produce_special_glyphs): Move to xdisp.c.
2435
2436 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2437 section.
c4b3bc8a 2438
b676b881
AS
24392012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2440
f17c5273
AS
2441 * xdisp.c (display_line): Avoid warning about implicit declaration
2442 of FRAME_FONT.
2443
298819b9
AS
2444 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2445
b676b881
AS
2446 * lisp.h: Remove empty conditional.
2447
6045c4fd
PE
24482012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2449
b3350bf9
PE
2450 * lread.c (load_path_check): Now static.
2451
6045c4fd
PE
2452 Fix some minor --with-ns problems found by static checking.
2453 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2454 (x_set_font) [!HAVE_X_WINDOWS]:
2455 * image.c (xpm_load_image) [HAVE_NS]:
2456 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2457 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2458 Remove unused local.
2459 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2460 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2461 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2462 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2463 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2464 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2465 Fix pointer signedness problem.
2466 * xfaces.c (FRAME_X_FONT_TABLE):
2467 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2468
929e7845
GM
24692012-07-07 Glenn Morris <rgm@gnu.org>
2470
2471 * lread.c (load_path_check): New function, split from init_lread.
2472 (init_lread): Reorganize. Motivation:
2473 If EMACSLOADPATH is set, check/warn about that rather than the
2474 defaults, which we are not going to use. Hence we can remove
2475 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2476 Don't warn if site-lisp directories are missing.
2477 If not installed, start from a blank load-path, since
2478 PATH_LOADSEARCH refers to the eventual installation directories.
2479
58dd0aa4
EZ
24802012-07-07 Eli Zaretskii <eliz@gnu.org>
2481
2482 Support truncation and continuation glyphs on GUI frames, when
2483 fringes are disabled. (Bug#11832)
2484 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2485 continuation glyphs even if on GUI frames.
2486 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2487 or both, are absent.
2488 (start_display, move_it_in_display_line_to): Handle the case of a
2489 GUI frame without a fringe to display continuation or truncation
2490 glyphs.
2491 (insert_left_trunc_glyphs): Support GUI frames: make sure
2492 truncation glyphs overwrite enough glyphs from the current line to
2493 have sufficient space in pixels.
2494 (display_line): Support truncation and continuation glyphs on GUI
2495 frames. If some spare pixels are left on the line after inserting
2496 the truncation glyphs, fill that space with a stretch glyph of a
2497 suitably computed width.
2498
2499 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2500 produce_glyphs, to support GUI sessions.
2501
31571fd7
PE
25022012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2503
5a16b9bc
PE
2504 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2505
f3047c75
PE
2506 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2507
31571fd7
PE
2508 Do not require float-time's arg to fit in time_t (Bug#11825).
2509 This works better on hosts where time_t is unsigned, and where
2510 float-time is applied to the (negative) difference between two times.
2511 * editfns.c (decode_time_components): Last arg is now double *,
2512 not int *, and means to store all the result as a double, without
2513 worrying about whether the seconds part fits in time_t.
2514 All callers changed.
2515 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2516 All callers changed.
2517 (Ffloat_time): Do not fail merely because the specified time falls
2518 outside of time_t range.
2519
4516fbef
GM
25202012-07-07 Glenn Morris <rgm@gnu.org>
2521
2522 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2523 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2524 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2525
07adc2c6
JB
25262012-07-07 Juanma Barranquero <lekktu@gmail.com>
2527
2528 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2529 Update dependencies.
2530
2531 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2532
fd573f31
PE
25332012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2534
fee5959d
PE
2535 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2536 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2537 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2538 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2539 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2540 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2541
fd573f31
PE
2542 * xfont.c (compare_font_names): Redo to omit the need for casts.
2543
ddadbc0e
AS
25442012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2545
fca8d6b6
AS
2546 * xfns.c (Fx_change_window_property): Doc fix.
2547 * w32fns.c (Fx_change_window_property): Doc fix.
2548
ddadbc0e
AS
2549 * w32fns.c (Fx_window_property): Accept the same arguments as the
2550 X Windows version. Doc fix.
2551 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2552
ed9265fc 25532012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2554 Eli Zaretskii <eliz@gnu.org>
2555
2556 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2557 Windows-specific code from nt/config.nt moved here.
2558 Obsolete settings removed.
2559
216ee680
PE
25602012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2561
2562 * process.c: Avoid unnecessary calls to gettime.
2563 (wait_reading_process_output): Don't get the time of day
2564 when gobbling data immediately and not waiting, as there's no need
2565 for it in that case. This removes a FIXME.
2566
bdd091e4
JD
25672012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2568
2569 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2570 is defined (Bug#11768).
2571
9d44f8ce
DA
25722012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2573
2574 Fix marker debugging code.
2575 * marker.c (byte_char_debug_check): Do not perform the check
2576 if buffer is not multibyte.
090bd7cb
JB
2577 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2578 Call byte_char_debug_check with correct arguments.
9d44f8ce 2579
90fc4786
DA
25802012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2581
2582 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2583 * marker.c (byte_char_debug_check, count_markers):
2584 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2585 (byte_debug_flag): Remove.
2586 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2587 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2588
7b7ae965
DA
25892012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2590
4e57b342
DA
2591 Avoid code repetition in marker-related functions.
2592 * marker.c (attach_marker): New function.
2593 (Fset_marker, set_marker_restricted, set_marker_both)
2594 (set_marker_restricted_both): Use it.
2595 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2596 Consistently rename charno to charpos.
2597 (marker_position): Add eassert.
2598 (marker_byte_position): Convert to eassert.
2599
26002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2601
2602 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2603 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2604 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2605
657924ff
DA
26062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2607
2608 Introduce fast path for the widely used marker operation.
2609 * alloc.c (build_marker): New function.
2610 * lisp.h (build_marker): New prototype.
2611 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2612 * composite.c (autocmp_chars): Likewise.
2613 * editfns.c (buildmark): Remove.
2614 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2615 (save_restriction_save): Use build_marker.
2616 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2617 * window.c (save_window_save): Likewise.
2618
041a49a6
DA
26192012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2620
2621 Do not use Fdelete_overlay in delete_all_overlays
2622 to avoid redundant calls to unchain_overlay.
2623 * buffer.c (drop_overlay): New function.
2624 (delete_all_overlays, Fdelete_overlay): Use it.
2625 * minibuf.c (get_minibuffer): Fix comment.
2626
7dca65a4
PE
26272012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2628
2629 Port to OpenBSD 5.1 amd64.
2630 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2631 This is needed for OpenBSD, and should be harmless on all BSD systems.
2632 Also, include <sys/sysctl.h>, as it should be available on all
2633 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2634 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2635 use p_pid member, not kp_proc.pid.
2636
8eb876e2
GM
26372012-07-06 Glenn Morris <rgm@gnu.org>
2638
2639 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2640
38182d90
PE
26412012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 More xmalloc and related cleanup.
2644 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2645 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2646 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2647 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2648 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2649 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2650 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2651 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2652 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2653 * xterm.c:
2654 Omit needless casts involving void * pointers and allocation.
2655 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2656 as the former is more robust if P's type is changed.
2657 Prefer xzalloc to xmalloc + memset 0.
2658 Simplify malloc-or-realloc to realloc.
2659 Don't worry about xmalloc returning a null pointer.
2660 Prefer xstrdup to xmalloc + strcpy.
2661 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2662 growing it.
2663 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2664 alloca of a constant.
2665
6dd5a677
EZ
26662012-07-05 Eli Zaretskii <eliz@gnu.org>
2667
2668 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2669 hscroll is larger than the line width. Fixes long and futile
2670 looping inside extend_face_to_end_of_line (on a TTY) producing
2671 glyphs that are not needed and thrown away.
2672
6b312f0f
DA
26732012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2674
2675 * marker.c (set_marker_restricted_both): Simplify by using
2676 clip_to_bounds.
2677
f520ef9b
PE
26782012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2681
383b7c95
JD
26822012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2683
2684 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2685 not defined (Bug#11768).
2686 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2687 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2688 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2689 followed by gtk_box_set_homogeneous (Bug#11768).
2690 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2691 (update_theme_scrollbar_width, xg_create_scroll_bar):
2692 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2693 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2694 (is_box_type): New function (Bug#11768).
2695 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2696 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2697 with default display (Bug#11768).
2698
d6e7bf45
EZ
26992012-07-05 Eli Zaretskii <eliz@gnu.org>
2700
2701 * xdisp.c (window_hscroll_limited): New function.
2702 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2703 coordinates when window's hscroll is set to insanely large
2704 values. (Bug#11857)
2705
431391ec
JB
27062012-07-05 Juanma Barranquero <lekktu@gmail.com>
2707
2708 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2709 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2710
23f86fce
DA
27112012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2712
2713 Cleanup xmalloc.
2714 * lisp.h (xzalloc): New prototype. Omit needless casts.
2715 * alloc.c (xzalloc): New function. Omit needless casts.
2716 * charset.c: Omit needless casts. Convert all calls to
2717 xmalloc with following memset to xzalloc.
2718 * dispnew.c: Likewise.
2719 * fringe.c: Likewise.
2720 * image.c: Likewise.
2721 * sound.c: Likewise.
2722 * term.c: Likewise.
2723 * w32fns.c: Likewise.
2724 * w32font.c: Likewise.
2725 * w32term.c: Likewise.
2726 * xfaces.c: Likewise.
2727 * xfns.c: Likewise.
2728 * xterm.c: Likewise.
2729 * atimer.c: Omit needless casts.
2730 * buffer.c: Likewise.
2731 * callproc.c: Likewise.
2732 * ccl.c: Likewise.
2733 * coding.c: Likewise.
2734 * composite.c: Likewise.
2735 * doc.c: Likewise.
2736 * doprnt.c: Likewise.
2737 * editfns.c: Likewise.
2738 * emacs.c: Likewise.
2739 * eval.c: Likewise.
2740 * filelock.c: Likewise.
2741 * fns.c: Likewise.
2742 * gtkutil.c: Likewise.
2743 * keyboard.c: Likewise.
2744 * lisp.h: Likewise.
2745 * lread.c: Likewise.
2746 * minibuf.c: Likewise.
2747 * msdos.c: Likewise.
2748 * print.c: Likewise.
2749 * process.c: Likewise.
2750 * region-cache.c: Likewise.
2751 * search.c: Likewise.
2752 * sysdep.c: Likewise.
2753 * termcap.c: Likewise.
2754 * terminal.c: Likewise.
2755 * tparam.c: Likewise.
2756 * w16select.c: Likewise.
2757 * w32.c: Likewise.
2758 * w32reg.c: Likewise.
2759 * w32select.c: Likewise.
2760 * w32uniscribe.c: Likewise.
2761 * widget.c: Likewise.
2762 * xdisp.c: Likewise.
2763 * xmenu.c: Likewise.
2764 * xrdb.c: Likewise.
2765 * xselect.c: Likewise.
2766
0497dc44
PE
27672012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2768
2769 * fileio.c (time_error_value): Check the right error number.
2770 Problem reported by Troels Nielsen in
2771 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2772
356e7178
PE
27732012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2774
4e71fd89
PE
2775 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2776 This should be fixed in a better way; see Eli Zaretskii in
2777 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2778 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2779
f0941253
PE
2780 * fileio.c (time_error_value): Rename from special_mtime.
2781 The old name's problems were noted by Eli Zaretskii in
2782 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2783
065c9eb4
PE
2784 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2785 This variable's comment says Emacs needs at least one GDB-visible
2786 symbol of type enum pvec_type, to work around GDB problems.
2787 The symbol's value doesn't matter.
2788
356e7178
PE
2789 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2790 that causes compilation to fail on pre-C99 compilers.
2791
ed9265fc 27922012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2793
2794 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2795 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2796
3884d954
DA
27972012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2798
d209e2fb 2799 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2800 headers for buffer_defaults and buffer_local_symbols.
2801 Reported by Juanma Barranquero <lekktu@gmail.com>.
2802
ee28be33
SM
28032012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2804
2805 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2806 * lisp.h (enum pvec_type): Use fewer bits.
2807 (PSEUDOVECTOR_SIZE_BITS): New constant.
2808 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2809 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2810 change in pvec_type.
2811 (PSEUDOVECTOR_TYPEP): New macro.
2812 (TYPED_PSEUDOVECTORP): Use it.
2813 * fns.c (internal_equal): Adapt code to extract pvectype.
2814 * emacs.c (gdb_pvec_type): Update type.
2815 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2816 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2817 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2818 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2819 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2820 abusing vector->header.next.nbytes.
2821 (live_vector_p): Use PVEC_TYPE.
2822 (mark_object): Adapt code to extract pvectype. Use switch.
2823
c7f2cd7f
PE
28242012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2825
2826 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2827 Tighten new eassert a bit.
2828
8ce70ed2
DA
28292012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2830
2831 Fix compilation with --enable-gcc-warnings and -O1
2832 optimization level.
2833 * doprnt.c (doprnt): Change type of tem to int, initialize
2834 to avoid compiler warning. Add eassert.
2835 * search.c (simple_search): Initialize match_byte to avoid
2836 compiler warning. Add eassert.
2837
dea7f1e5
PE
28382012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2839
24a212eb
PE
2840 Avoid weird behavior with large horizontal scrolls.
2841 Without this change, for example, large hscroll values would
2842 mess up Emacs's display on Fedora 15 x86, presumably due to
2843 overflows in int calculations in the display code.
2844 Also, if buffers had long lines, Emacs would freeze.
2845 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2846 (set_window_hscroll): New function, containing the old guts of
2847 Fset_window_hscroll. Return the clipped value.
2848 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2849 This avoids the need to check against PTRDIFF_MAX.
2850
dea7f1e5
PE
2851 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2852
76046526
DA
28532012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2854
2855 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2856
39adff0d
PE
28572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2858
63807d47
PE
2859 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2860 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2861 since GCC 4.4.6 issues a bogus warning for them.
2862
39adff0d
PE
2863 Fix bugs in file timestamp newness comparisons.
2864 * fileio.c (Ffile_newer_than_file_p):
2865 * lread.c (Fload): Use full timestamp resolution of files,
2866 not just the 1-second resolution, so that files that are only
2867 slightly newer still count as newer.
2868 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2869 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2870
dbeed9a6
PE
28712012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 * fileio.c: Improve handling of file time marker. (Bug#11852)
2874 (special_mtime): New function.
2875 (Finsert_file_contents, Fverify_visited_file_modtime):
2876 Use it to set special mtime values consistently.
2877
636334d6
AS
28782012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2879
2880 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2881 marker for non-existing file. (Bug#11852)
2882
e2017fe2
GM
28832012-07-03 Glenn Morris <rgm@gnu.org>
2884
2885 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2886 and did not make it into globals.h).
2887
404dbd37
TT
28882012-07-03 Tom Tromey <tromey@redhat.com>
2889
2890 * window.c (Fset_window_margins, Fset_window_fringes)
2891 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2892 * textprop.c (Fprevious_property_change): No longer static.
2893 * syntax.c (Fsyntax_table_p): No longer static.
2894 * process.c (Fget_process, Fprocess_datagram_address): No longer
2895 static.
2896 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2897 * keyboard.c (Fcommand_execute): No longer static.
2898 Remove EXFUN.
2899 * insdel.c (Fcombine_after_change_execute): No longer static.
2900 * image.c (Finit_image_library): No longer static.
2901 * fileio.c (Fmake_symbolic_link): No longer static.
2902 * eval.c (Ffetch_bytecode): No longer static.
2903 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2904 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2905 No longer static.
404dbd37
TT
2906 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2907 static.
2908 * dired.c (Ffile_attributes): No longer static.
2909 * composite.c (Fcomposition_get_gstring): No longer static.
2910 * callproc.c (Fgetenv_internal): No longer static.
2911
2912 * ccl.h: Remove EXFUNs.
2913 * buffer.h: Remove EXFUNs.
2914 * dispextern.h: Remove EXFUNs.
2915 * intervals.h: Remove EXFUNs.
2916 * fontset.h: Remove EXFUN.
2917 * font.h: Remove EXFUNs.
2918 * dosfns.c (system_process_attributes): Remove EXFUN.
2919 * keymap.h: Remove EXFUNs.
2920 * lisp.h: Remove EXFUNs.
2921 * w32term.h: Remove EXFUNs.
2922 * window.h: Remove EXFUNs.
2923 * xsettings.h: Remove EXFUN.
2924 * xterm.h: Remove EXFUN.
2925
8e4fd1e1
GM
29262012-07-03 Glenn Morris <rgm@gnu.org>
2927
2928 * lisp.h (Frandom): Make it visible to C.
2929 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2930 buffer for invisible buffers. (Bug#1229)
2931
ca95b3eb
DA
29322012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2933
2934 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2935 values which aren't power of 2.
14ae4239
BT
2936 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2937 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2938 accordingly.
2939
7555c33f
SM
29402012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2941
2942 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2943
2944 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2945
d12e8f5a
DA
29462012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2947
2948 * alloc.c (allocate_vector_block): Remove redundant
2949 calls to mallopt if DOUG_LEA_MALLOC is defined.
2950 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2951 avoid calls to mallopt if zero_vector is returned.
2952
296094c3
DA
29532012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2954
2955 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2956 is enabled, avoid dereferencing NULL current_sblock if
2957 running undumped.
2958
36429c89
DA
29592012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2960
2961 Cleanup basic buffer management.
2962 * buffer.h (struct buffer): Change layout to use generic vector
2963 marking code. Fix some comments. Change type of 'clip_changed'
2964 to bitfield. Remove unused #ifndef old.
2965 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2966 (GET_OVERLAYS_AT): Fix indentation.
2967 (for_each_per_buffer_object_at): New macro.
2968 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2969 (Fbuffer_local_variables): Use it.
2970 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2971 * alloc.c (allocate_buffer): Adjust to match new layout of
2972 struct buffer. Fix comment.
2973 (mark_overlay): New function.
2974 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2975 Lisp area of struct buffer.
2976 (mark_object): Use it. Adjust marking of misc objects
2977 and related comments.
2978
3b3e4cac
PE
29792012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2980
2981 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2982 wrapper that is not needed because the wrapped code is a no-op (zero
2983 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2984 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2985
cf5c0175
DA
29862012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2987
2988 * alloc.c (mark_buffer): Simplify. Remove prototype.
2989 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2990 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2991 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2992 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2993
ca26824c
GM
29942012-06-30 Glenn Morris <rgm@gnu.org>
2995
2e4c5312
GM
2996 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2997
ca26824c
GM
2998 * epaths.in (PATH_SITELOADSEARCH): New.
2999 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
3000 This is rather than relying on --enable-locallisppath elements
3001 having "site-lisp" in their names. (Bug#10208#25, 11658)
3002
0d23c240
EZ
30032012-06-30 Eli Zaretskii <eliz@gnu.org>
3004
c9240d7a
EZ
3005 * w32proc.c (sys_select): Accept and ignore one more argument.
3006
3007 * w32.c (emacs_gnutls_pull): Call select with one more argument.
3008
0d23c240 3009 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 3010 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
3011
3012 * sysdep.c: Don't include dos.h and dosfns.h.
3013
3014 * process.c (sys_select):
3015 * msdos.c (sys_select): Accept one more argument and ignore it.
3016
3017 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
3018 adapt data types and code to that.
3019
3020 * dosfns.c:
3021 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
3022 which clashes with the gnulib function of the same name.
3023
af5a5a98
AS
30242012-06-30 Andreas Schwab <schwab@linux-m68k.org>
3025
c5e4379c
AS
3026 * font.c (font_style_to_value, font_style_symbolic)
3027 (font_prop_validate_style): Add type checks for values in
3028 font_style_table.
3029
af5a5a98
AS
3030 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
3031 argument.
3032 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
3033 uses.
3034
8d38f461
EZ
30352012-06-29 Eli Zaretskii <eliz@gnu.org>
3036
2e5a6631
EZ
3037 * xdisp.c (try_window_id): Undo last change.
3038
8d38f461
EZ
3039 * w32.c (getwd): Adjust commentary about startup_dir.
3040 (init_environment): Always call sys_access, even in non-MSVC
3041 builds. Don't chdir to the directory of the Emacs executable.
3042 This undoes code from 1997 which was justified by the need to
3043 "avoid conflicts when removing and renaming directories". But its
3044 downside was that every relative file name was being interpreted
3045 relative to the directory of the Emacs executable, which can never
3046 be TRT. In particular, it broke sys_access when called with
3047 relative file names.
3048 (sys_access): Map GetLastError to errno.
3049
2af3565e
DA
30502012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3051
3052 * window.h (struct window): Change type of 'fringes_outside_margins'
3053 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 3054 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
3055 Adjust comment.
3056 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
3057 to ptrdiff_t.
3058
c8d3a25c 30592012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 3060
c8d3a25c
GM
3061 * gnutls.c (emacs_gnutls_handshake):
3062 Add QUIT to make the loop interruptible.
57570cd3 3063
c8d3a25c 30642012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 3065
c8d3a25c
GM
3066 * charset.c (init_charset): Make lack of etc/charsets fatal.
3067
3e984ee8
DA
30682012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3069
3070 * editfns.c (region_limit): Fix type mismatch.
3071
ef884f23
DA
30722012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3073
3074 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
3075 undefined. Convert from xassert to eassert.
3076 * nsmenu.m: Convert from xassert to eassert.
3077 * nsterm.m: Likewise.
3078
7d7e0027
SM
30792012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
3080
3081 * editfns.c (region_limit): Clip to narrowing (bug#11770).
3082
aa754e6a
PE
30832012-06-28 Paul Eggert <eggert@cs.ucla.edu>
3084
3085 Avoid integer overflow on scroll-left and scroll-right.
3086 * window.c (HSCROLL_MAX): New macro.
3087 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
3088 overflow when requested scroll falls outside ptrdiff_t range.
3089
80b00b08
DA
30902012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3091
3092 * window.h (struct window): Change type of 'hscroll',
3093 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
3094 'last_modified' and 'last_overlay_modified' to EMACS_INT.
3095 Adjust users accordingly.
3096 * xdisp.c (try_cursor_movement): Replace type check with eassert.
3097 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
3098 from EMACS_INT to ptrdiff_t.
3099 (make_window): Omit redundant initialization.
3100
62b2bcf6
JB
31012012-06-28 Juanma Barranquero <lekktu@gmail.com>
3102
3103 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
3104
45942c7d
DA
31052012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3106
3107 * window.h (struct window): Change type of 'use_time' and
3108 'sequence_number' from Lisp_Object to int.
3109 * frame.c (make_frame): Adjust users accordingly.
3110 * print.c (print_object): Likewise.
3111 * window.c (select_window, Fwindow_use_time, make_parent_window)
3112 (make_window): Likewise.
3113
e509cfa6
DA
31142012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3115
3116 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
3117 enabled with --enable-checking=[all,glyphs] configure option.
3118 Fix GLYPH_DEBUG usage assuming that it may be undefined,
3119 adjust comments accordingly.
3120 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
3121 undefined, adjust comments accordingly.
3122 * image.c: Likewise.
3123 * scroll.c: Likewise.
3124 * w32fns.c: Likewise.
3125 * w32term.c: Likewise.
3126 * xdisp.c: Likewise.
3127 * xfaces.c: Likewise.
3128 * xfns.c: Likewise.
3129 * xterm.c: Likewise.
3130
a54e2c05
DA
31312012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3132
3133 Generalize run-time debugging checks.
3134 * dispextern.h (XASSERTS): Remove.
3135 * fontset.c (xassert): Remove.
3136 Convert from xassert to eassert.
3137 * alloc.c: Convert from xassert to eassert.
3138 * bidi.c: Likewise.
3139 * dispnew.c: Likewise.
3140 * fns.c: Likewise.
3141 * fringe.c: Likewise.
3142 * ftfont.c: Likewise.
3143 * gtkutil.c: Likewise.
3144 * image.c: Likewise.
3145 * keyboard.c: Likewise.
3146 * menu.c: Likewise.
3147 * process.c: Likewise.
3148 * scroll.c: Likewise.
3149 * sound.c: Likewise.
3150 * term.c: Likewise.
3151 * w32console.c: Likewise.
3152 * w32fns.c: Likewise.
3153 * w32term.c: Likewise.
3154 * window.c: Likewise.
3155 * xdisp.c: Likewise.
3156 * xfaces.c: Likewise.
3157 * xfns.c: Likewise.
3158 * xselect.c: Likewise.
3159 * xterm.c: Likewise.
3160
1ec4b7b2
SM
31612012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
3162
3163 * fns.c (maybe_resize_hash_table): Output message when growing the
3164 purify-hashtable.
3165
2014308a
DA
31662012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3167
3168 * alloc.c (allocate_string_data): Remove dead code.
3169 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3170 avoid GCC warning about unused macro.
3171
246155eb
DA
31722012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3173
3174 * alloc.c (allocate_string): Omit intervals initialization.
3175 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3176 as in make_pure_string and make_pure_c_string.
3177
43184b7b
DA
31782012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3179
d209e2fb 3180 * alloc.c (allocate_string): Fix last change.
43184b7b 3181
3fe6dd74
DA
31822012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3183
d209e2fb 3184 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3185 to memset, add explicit initialization where appropriate.
3186
1ba6038a
GM
31872012-06-27 Glenn Morris <rgm@gnu.org>
3188
3189 * lisp.mk (lisp): Remove paths.elc.
3190
c89926a5
CY
31912012-06-27 Chong Yidong <cyd@gnu.org>
3192
3193 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3194
ed6b3510
JW
31952012-06-26 John Wiegley <johnw@newartisans.com>
3196
1ec4b7b2 3197 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3198 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3199
ed6b3510
JW
3200 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3201 when building with Clang.
3202
8edd4a2b
SM
32032012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3204
3205 * eval.c (Fapply): Allow calling it with a single argument.
3206
f6f62d1b
EZ
32072012-06-26 Eli Zaretskii <eliz@gnu.org>
3208
3209 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3210 _stricmp and _strnicmp.
3211 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3212
62efea5e
DA
32132012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3214
3215 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3216 allocated window.
3217 (allocate_process): Likewise for new process.
8edd4a2b 3218 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3219 (allocate_frame): Likewise.
3220 * frame.c (make_frame): Omit redundant initialization.
3221 * window.c (make_parent_window): Use memset.
3222 (make_window): Omit redundant initialization.
3223 * process.c (make_process): Omit redundant initialization.
3224 * terminal.c (create_terminal): Likewise.
3225
42997f4d
DA
32262012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3227
3228 * term.c (delete_tty): Remove redundant call to memset.
3229
1130ecfc
DA
32302012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3231
3232 * alloc.c: Remove build_string.
3233 * lisp.h: Define build_string as static inline. This provides
3234 a better opportunity to optimize away calls to strlen when the
3235 function is called with compile-time constant argument.
3236 * image.c (imagemagick_error): Convert to build_string.
3237 * w32proc.c (sys_spawnve): Likewise.
3238 * xterm.c (x_term_init): Likewise.
3239
cf38a720
PE
32402012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3241
99027bdd
PE
3242 Use sprintf return value instead of invoking strlen on result.
3243 In the old days this wasn't portable, since some sprintf
3244 implementations returned char *. But they died out years ago and
3245 Emacs already assumes sprintf returns int.
3246 Similarly for float_to_string.
3247 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3248 * ccl.c (ccl_driver):
3249 * character.c (string_escape_byte8):
3250 * data.c (Fnumber_to_string):
3251 * doprnt.c (doprnt):
3252 * print.c (print_object):
3253 * xdisp.c (message_dolog):
3254 * xfns.c (syms_of_xfns):
3255 Use sprintf or float_to_string result to avoid need to call strlen.
3256 * data.c (Fnumber_to_string):
3257 Use make_unibyte_string, since the string must be ASCII.
3258 * lisp.h, print.c (float_to_string): Now returns int length.
3259 * term.c (produce_glyphless_glyph):
3260 Use sprintf result rather than recomputing it.
3261
cf38a720
PE
3262 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3263 * Makefile.in (ALL_CFLAGS):
3264 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3265 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3266
3511c784
DA
32672012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3268
0a08eb21 3269 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3270 strcasecmp if available.
3271 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3272
fb7da12e
AS
32732012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3274
3275 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3276 Avoid comma operator.
3277 * menu.c (push_submenu_start, push_submenu_end)
3278 (push_left_right_boundary, push_menu_pane): Likewise.
3279 * msdos.c (dos_rawgetc): Likewise.
3280
afa2ffd8
DA
32812012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3282
3283 * xfns.c (xic_create_fontsetname): Remove redundant calls
3284 to memset.
3285
b3b4476b
PE
32862012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3287
4495ff38
PE
3288 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3289 sprintf already null-terminates its output.
3290
b3b4476b
PE
3291 * xfns.c (x_window): Remove redundant cast.
3292
b00876c9
DA
32932012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3294
3295 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3296 `const char *' to `char *' to avoid compiler warning.
3297
d188e26b
PE
32982012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3299
885d1d74
PE
3300 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3301 instead of truncating it to 63 (admittedly a generous limit).
3302
d188e26b
PE
3303 * process.c: Fix spelling and caps in comments.
3304
e2f560b1
DN
33052012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3306
e86db54b 3307 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3308 * sysdep.c (setpgrp): Remove definition, not used in this file.
3309
7583a3a1
JB
33102012-06-24 Juanma Barranquero <lekktu@gmail.com>
3311
3312 * makefile.w32-in: Update dependencies.
3313
696056c2
EZ
33142012-06-24 Eli Zaretskii <eliz@gnu.org>
3315
3316 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3317 (SYSTIME_H): Add nt/inc/sys/time.h.
3318
3319 * systime.h [WINDOWSNT]: Include sys/time.h.
3320
3321 * s/ms-w32.h (struct timespec): Definition moved from
3322 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3323
845ca893
PE
33242012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3325
3326 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3327 * buffer.h (buffer_slot_type_mismatch):
3328 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3329 * eval.c (unwind_to_catch):
3330 * image.c (my_png_error, my_error_exit):
3331 * keyboard.c (quit_throw_to_read_char, user_error)
3332 (Fexit_recursive_edit, Fabort_recursive_edit):
3333 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3334 (wrong_type_argument, buffer_overflow, __executable_start)
3335 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3336 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3337 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3338 (fatal):
3339 (child_setup) [!DOS_NT]:
3340 * lread.c (end_of_file_error, invalid_syntax):
3341 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3342 * puresize.h (pure_write_error):
3343 * search.c (matcher_overflow):
3344 * sound.c (sound_perror, alsa_sound_perror):
3345 * sysdep.c, syssignal.h (croak):
3346 * term.c (maybe_fatal, vfatal):
3347 * textprop.c (text_read_only):
3348 * undo.c (user_error):
3349 * unexmacosx.c (unexec_error):
3350 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3351 Use _Noreturn rather than NO_RETURN.
3352 No need for separate decl merely because of _Noreturn.
3353 * sound.c (sound_warning, parse_sound):
3354 Remove unnecessary forward decls.
3355
f1dd8073
PE
33562012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3357
3358 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3359 * lisp.h (WAIT_READING_MAX): New macro.
3360 * dispnew.c (Fsleep_for, sit_for):
3361 * keyboard.c (kbd_buffer_get_event):
3362 * process.c (Faccept_process_output):
3363 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3364 This improves on the previous patch, which introduced a bug
3365 when time_t is unsigned and as wide as intmax_t.
3366 See <http://bugs.gnu.org/9000#51>.
3367
b82c1755
EZ
33682012-06-23 Eli Zaretskii <eliz@gnu.org>
3369
3370 * dispnew.c (sit_for, Fsleep_for):
3371 * keyboard.c (kbd_buffer_get_event):
3372 * process.c (Faccept_process_output): Avoid compiler warnings when
3373 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3374
ca300656
JB
33752012-06-23 Juanma Barranquero <lekktu@gmail.com>
3376
049ec95b
JB
3377 * makefile.w32-in: Update dependencies.
3378
ca300656
JB
3379 * w32.c (ltime): Add return type and declare static.
3380 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3381
db7b8d06
PE
33822012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3385 Privately reported by Herbert J. Skuhra.
3386 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3387 All uses changed.
3388 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3389 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3390
0bd8297f
EZ
33912012-06-23 Eli Zaretskii <eliz@gnu.org>
3392
96512555
EZ
3393 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3394 last argument of make_unibyte_string.
3395
0bd8297f
EZ
3396 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3397 language ID in the event parameters.
3398
3399 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3400 event.code, not the obscure "character set ID".
3401
63def6b6
CY
34022012-06-23 Chong Yidong <cyd@gnu.org>
3403
3404 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3405
e8a02204
EZ
34062012-06-23 Eli Zaretskii <eliz@gnu.org>
3407
388cdec0
EZ
3408 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3409 * w32.c (fdutimens): New function.
3410
3411 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3412
3413 * s/ms-w32.h (pselect): Redirect to sys_select.
3414
3415 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3416
e8a02204
EZ
3417 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3418 in the logic of incrementing and decrementing the value of
3419 use_relocatable_buffers.
3420
d054f3fb
PE
34212012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3422
3423 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3424 Privately reported by Herbert J. Skuhra.
3425 [__FreeBSD__]: Remove "*/" typo after "#include".
3426 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3427 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3428 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3429 Don't assume EMACS_TIME and struct timeval are the same type.
3430
d35af63c
PE
34312012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3432
3433 Support higher-resolution time stamps (Bug#9000).
3434 The time stamps are only nanosecond-resolution at the C level,
3435 since that's the best that any real-world system supports now.
3436 But they are picosecond-resolution at the Lisp level, as that's
3437 easy, and leaves room for future OS improvements.
3438
3439 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3440 (LIBES): Use it.
3441
3442 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3443 Don't get current time unless it's needed.
3444
3445 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3446 now provides it if it's absent.
3447 (start_atimer): Port to higher-res time stamps.
3448 Check for time stamp overflow. Don't get current time more
3449 often than is needed.
3450
3451 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3452 Include systime.h, not time.h.
3453 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3454
3455 * dired.c: Include stat-time.h.
3456 (Ffile-attributes): File times now have higher resolution.
3457
3458 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3459 (struct image): Timestamp now has higher resolution.
3460
3461 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3462 has at least microseconds now. All uses removed.
3463 (update_frame, update_single_window, update_window, update_frame_1)
3464 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 3465 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
3466
3467 * editfns.c (time_overflow): Now extern.
3468 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3469 (float-time, Fformat_time_string, Fcurrent_time_string)
3470 (Fcurrent_time_zone): Accept and generate higher-resolution
3471 time stamps.
3472 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3473 (decode_time_components, lisp_seconds_argument): New functions.
3474 (make_time): Now static.
3475 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3476 Report an error if the time is invalid, rather than having the caller
3477 do that.
3478
3479 * fileio.c: Include <stat-time.h>
3480 (Fcopy_file): Copy higher-resolution time stamps.
3481 Prefer to set the time stamp via a file descriptor if that works.
3482 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3483 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3484 (Fvisited_file_modtime, Fset_visited_file_modtime):
3485 Support higher-resolution time stamps.
3486
3487 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3488
3489 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3490
3491 * image.c (prepare_image_for_display, clear_image_cache)
3492 (lookup_image): Port to higer-resolution time stamps.
3493
3494 * keyboard.c (start_polling, bind_polling_period):
3495 Check for time stamp overflow.
3496 (read_char, kbd_buffer_get_event, timer_start_idle)
3497 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3498 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3499 Port to higher-resolution time stamps. Do not assume time_t is signed.
3500 (decode_timer): New function. Timers are now vectors of length 9,
3501 not 8, to accommodate the picosecond component.
3502 (timer_check_2): Use it.
3503
3504 * nsterm.m (select_timeout, timeval_subtract): Remove.
3505 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3506 as they're a bit more accurate and handle overflow better.
3507 (ns_select): Change prototype to be compatible with pselect.
3508 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3509 * nsterm.h (ns_select): Adjust prototype.
3510
3511 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3512 us-resolution time stamps.
3513 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3514
3515 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3516
3517 * lisp.h (time_overflow): New decl.
3518 (wait_reading_process_output): First arg is now intmax_t, not int,
3519 to accommodate larger waits.
3520
3521 * process.h (struct Lisp_Process.read_output_delay):
3522 Now counts nanoseconds, not microseconds.
3523 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3524 EMACS_HAS_USECS.
3525 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3526 (wait_reading_process_output):
3527 Port to ns-resolution time stamps.
3528 (Faccept_process_output, wait_reading_process_output):
3529 Check for time stamp overflow. Do not assume time_t is signed.
3530 (select_wrapper): Remove; we now use pselect.
3531 (Fprocess_attributes): Now generates ns-resolution time stamps.
3532
3533 * sysdep.c: Include utimens.h. Don't include utime.h
3534 or worry about struct utimbuf; gnulib does that for us now.
3535 (gettimeofday): Remove; gnulib provides a substitute.
3536 (make_timeval): New function.
3537 (set_file_times): Now sets ns-resolution time stamps.
3538 New arg FD; all uses changed.
3539 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3540 (system_process_attributes):
3541 Now returns ns-resolution time stamp. All uses changed.
3542 Check for time stamp overflow.
3543
3544 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3545 provides a substitute now.
3546
3547 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3548 since it guarantees struct timespec.
3549 (EMACS_TIME): Now struct timespec, so that we can support
3550 ns-resolution time stamps.
3551 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3552 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3553 (EMACS_USECS): Remove.
3554 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3555 so multiply the arg by 1000 before storing it.
3556 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3557 New macros.
3558 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3559 Port to ns-resolution time stamps.
3560 (EMACS_TIME_NEG_P): Remove; replaced by....
3561 (EMACS_TIME_SIGN): New macro.
3562 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3563 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3564 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3565 (make_timeval, make_lisp_time, decode_time_components): New decls.
3566 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3567 that it mishandled time_t overflow. You can't compare by subtracting!
3568 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3569 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3570
3571 * term.c: Include <sys/time.h>.
3572 (timeval_to_Time): New function, for proper overflow wraparound.
3573 (term_mouse_position, term_mouse_click): Use it.
3574
3575 * undo.c (record_first_change): Support higher-resolution time stamps
3576 in the undo buffer.
3577 (Fprimitive_undo): Use them when restoring time stamps.
3578
3579 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3580 (w32_get_internal_run_time):
3581 Port to higher-resolution Emacs time stamps.
3582 (ltime): Now accepts single 64-bit integer, as that's more convenient
3583 for callers.
3584
3585 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3586
3587 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3588 for compatibility with pselect. Support ns-resolution time stamps.
3589
3590 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3591
3592 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3593 Check for time stamp overflow, and support ns-resolution time stamps.
3594
3595 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3596 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3597 (timeval_subtract): Remove; no longer needed.
3598 (XTflash, XTring_bell, x_wait_for_event):
3599 Port to ns-resolution time stamps. Don't assume time_t is signed.
3600
b6a92dfe
CY
36012012-06-22 Chong Yidong <cyd@gnu.org>
3602
3603 * xdisp.c (x_consider_frame_title): Revert last change.
3604
d251c37c
EZ
36052012-06-22 Eli Zaretskii <eliz@gnu.org>
3606
3607 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3608 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3609 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3610 staticidx goes up to 1597 out of 1600 = 0x640.)
3611
f10deafb
PE
36122012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3613
3614 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3615 Otherwise, the umask might be mistakenly 0 while handling input signals.
3616
ec6de1e2
SM
36172012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3618
3619 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3620
28be1ada
DA
36212012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3622
3623 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3624 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3625 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3626 access to `contents' member of Lisp_Vector objects with AREF and ASET
3627 where appropriate.
3628
c6bf3022
CY
36292012-06-19 Chong Yidong <cyd@gnu.org>
3630
3631 * frame.c (delete_frame): When selecting a frame on a different
3632 text terminal, do not alter the terminal's top-frame.
3633
3634 * xdisp.c (format_mode_line_unwind_data): Record the target
3635 frame's selected window and its terminal's top-frame.
3636 (unwind_format_mode_line): Restore them.
3637 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3638 Callers changed.
3639 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3640 since tty frames can be explicitly named.
3641 (prepare_menu_bars): Likewise.
3642
3643 * term.c (Ftty_top_frame): New function.
3644
defd4196
PE
36452012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3646
3647 Port byte-code-meter to modern targets.
3648 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3649 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3650 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3651 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3652 (METER_1, METER_2): Simplify.
3653
1053a871
SM
36542012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3655
3656 * data.c (Fdefalias): Return `symbol' (bug#11686).
3657
b7e8d081
MR
36582012-06-18 Martin Rudalics <rudalics@gmx.at>
3659
3660 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3661 gets killed during executing of this function (Bug#11665).
3662 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3663 (Vkill_buffer_query_functions): In doc-string say that functions
3664 run by this hook should not change the current buffer.
3665
7ea2b339
PE
36662012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3667
3668 Fix recently-introduced process.c problems found by static checking.
3669 * process.c (write_queue_push, write_queue_pop, send_process):
3670 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3671 (write_queue_pop): Fix pointer signedness problem.
3672 (send_process): Remove unused local.
3673
96a313a1
CY
36742012-06-17 Chong Yidong <cyd@gnu.org>
3675
3676 * xdisp.c (redisplay_internal): No need to redisplay terminal
3677 frames that are not on top.
3678
20ca2e94
TN
36792012-06-17 Troels Nielsen <bn.troels@gmail.com>
3680
3681 * process.c (make_process): Initialize write_queue.
3682 (write_queue_push, write_queue_pop): New functions.
3683 (send_process): Use them to maintain correct ordering of process
3684 writes (Bug#10815).
3685
9a900ca9
PE
36862012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3687
310fbfa8
PE
3688 * lisp.h (eassert): Assume C89 or later.
3689 This removes the need for CHECK.
3690 (CHECK): Remove. Its comments about always evaluating its
3691 argument were confusing, as 'eassert' typically does not evaluate
3692 its argument.
3693
27bb1ca4
PE
3694 * coding.c (produce_chars): Use ptrdiff_t, not int.
3695
9a900ca9
PE
3696 * xterm.c (x_draw_underwave): Check for integer overflow.
3697 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3698
41b7f8bc 36992012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3700
3701 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3702 referenced (Bug#11583).
3703
9b0e3eba
AA
37042012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3705
3706 Implement wave-style variant of underlining.
3707 * dispextern.h (face_underline_type): New enum.
3708 (face): Add field for underline type.
3709 * nsterm.m (ns_draw_underwave): New function.
3710 (ns_draw_text_decoration): Use it.
3711 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3712 New functions.
3713 (x_draw_glyph_string): Use them.
3714 * xfaces.c (Qline, Qwave): New Lisp objects.
3715 (check_lface_attrs, merge_face_ref)
1053a871
SM
3716 (Finternal_set_lisp_face_attribute, realize_x_face):
3717 Handle wave-style underline face attributes.
9b0e3eba
AA
3718 * xterm.c (x_draw_underwave): New function.
3719 (x_draw_glyph_string): Use it.
3720
0fb52f11
JB
37212012-06-16 Juanma Barranquero <lekktu@gmail.com>
3722
3723 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3724 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3725 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3726 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3727 ($(BLD)/w32select.$(O)): Update dependencies.
3728
e5560ff7
AS
37292012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3730
3731 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3732 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3733 * character.c (_fetch_multibyte_char_p): Remove.
3734 * alloc.c: Include "character.h" before "buffer.h".
3735 * bidi.c: Likewise.
3736 * buffer.c: Likewise.
3737 * bytecode.c: Likewise.
3738 * callint.c: Likewise.
3739 * callproc.c: Likewise.
3740 * casefiddle.c: Likewise.
3741 * casetab.c: Likewise.
3742 * category.c: Likewise.
3743 * cmds.c: Likewise.
3744 * coding.c: Likewise.
3745 * composite.c: Likewise.
3746 * dired.c: Likewise.
3747 * dispnew.c: Likewise.
3748 * doc.c: Likewise.
3749 * dosfns.c: Likewise.
3750 * editfns.c: Likewise.
3751 * emacs.c: Likewise.
3752 * fileio.c: Likewise.
3753 * filelock.c: Likewise.
3754 * font.c: Likewise.
3755 * fontset.c: Likewise.
3756 * fringe.c: Likewise.
3757 * indent.c: Likewise.
3758 * insdel.c: Likewise.
3759 * intervals.c: Likewise.
3760 * keyboard.c: Likewise.
3761 * keymap.c: Likewise.
3762 * lread.c: Likewise.
3763 * macros.c: Likewise.
3764 * marker.c: Likewise.
3765 * minibuf.c: Likewise.
3766 * nsfns.m: Likewise.
3767 * nsmenu.m: Likewise.
3768 * print.c: Likewise.
3769 * process.c: Likewise.
3770 * regex.c: Likewise.
3771 * region-cache.c: Likewise.
3772 * search.c: Likewise.
3773 * syntax.c: Likewise.
3774 * term.c: Likewise.
3775 * textprop.c: Likewise.
3776 * undo.c: Likewise.
3777 * unexsol.c: Likewise.
3778 * w16select.c: Likewise.
3779 * w32fns.c: Likewise.
3780 * w32menu.c: Likewise.
3781 * window.c: Likewise.
3782 * xdisp.c: Likewise.
3783 * xfns.c: Likewise.
3784 * xmenu.c: Likewise.
3785 * xml.c: Likewise.
3786 * xselect.c: Likewise.
3787
2f07e6af
EZ
37882012-06-16 Eli Zaretskii <eliz@gnu.org>
3789
1053a871
SM
3790 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3791 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3792 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3793 row.
3794 (handle_face_prop): Use chunk-relative overlay string index when
3795 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3796 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3797 the rightmost. (Bug#11720)
2f07e6af 3798
29b83cec
AS
37992012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3800
3801 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3802 (CATEGORY_MEMBER): Enforce 1/0 value.
3803 * category.c (_temp_category_set): Remove.
3804
4c5501e9
EZ
38052012-06-16 Eli Zaretskii <eliz@gnu.org>
3806
3807 * window.c (Fdelete_other_windows_internal)
3808 (Fdelete_window_internal): Don't access frame's mouse highlight
3809 info of the initial frame. (Bug#11677)
3810
2b570124
PE
38112012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3812
e93864f9
PE
3813 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3814 Assume USE_2_TAGS_FOR_INTS.
3815 (xreload): Adjust $tagmask width to match recent lisp.h change.
3816
2b570124
PE
3817 Simplify lisp.h in minor ways that should not affect code.
3818 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3819 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3820 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3821 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3822 (INTTYPEBITS): New macro, for clarity.
3823 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3824 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3825 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3826 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3827 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3828
81755f69
JB
38292012-06-13 Juanma Barranquero <lekktu@gmail.com>
3830
3831 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3832
16192a57
GM
38332012-06-13 Glenn Morris <rgm@gnu.org>
3834
3835 * s/bsd-common.h (BSD4_3):
3836 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3837
646b5f55
AS
38382012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3839
3840 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3841 instead of union.
3842 (XLI, XIL): Define.
1053a871
SM
3843 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3844 Use them.
3845 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3846 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3847 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3848 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3849 * frame.c (delete_frame): Remove outdated comment.
3850 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3851 USE_LISP_UNION_TYPE.
3852 (Fw32_unregister_hot_key): Likewise.
3853 (Fw32_toggle_lock_key): Likewise.
3854 * w32menu.c (add_menu_item): Likewise.
3855 (w32_menu_display_help): Use XIL instead of checking
3856 USE_LISP_UNION_TYPE.
3857 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3858 (init_heap): Likewise.
3859 * w32term.c (w32_read_socket): Update comment.
3860
1d3823c9
GM
38612012-06-13 Glenn Morris <rgm@gnu.org>
3862
c62ff706
GM
3863 * s/usg5-4-common.h, src/s/unixware.h:
3864 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3865
1d3823c9
GM
3866 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3867
bfe3e0a2
PE
38682012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3869
3870 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3871 * alloc.c (make_number) [!defined make_number]:
3872 Remove, as lisp.h always defines this now.
3873 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3874 (roundup_size): Verify that it is a power of 2.
3875 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3876 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3877 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3878 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3879 USE_LSB_TAG now is always defined to be either 0 or 1.
3880 All uses changed.
3881 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3882 code works fine either way, and efficiency is not a concern here,
3883 as the union type is for debugging, not for production.
3884 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3885 Use an inline function on all platforms when using the union type,
3886 since this is simpler and 'static inline' can be used portably
3887 within Emacs now.
3888 (LISP_INITIALLY_ZERO): New macro.
3889 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3890 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3891
45fa9c0f
GM
38922012-06-12 Glenn Morris <rgm@gnu.org>
3893
b4492cba
GM
3894 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3895
3896 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3897
45fa9c0f
GM
3898 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3899 Move BROKEN_SIGIO to configure.
3900
3901 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3902 Move NO_TERMIO to configure.
3903
0e25d334
CY
39042012-06-12 Chong Yidong <cyd@gnu.org>
3905
3906 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3907 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3908 MagickExportImagePixels is undefined.
3909
43682bb6
PE
39102012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3911
3912 * image.c (imagemagick_load_image): Remove unused label.
3913
a9be7d2b
GM
39142012-06-11 Glenn Morris <rgm@gnu.org>
3915
3916 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3917 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3918 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3919 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3920
3017f87f
SM
39212012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3922
3923 * alloc.c (make_byte_code): New function.
3924 (Fmake_byte_code): Use it. Don't purify here.
3925 * lread.c (read1): Use it as well to avoid extra allocation.
3926
1b9b4cf4
CY
39272012-06-11 Chong Yidong <cyd@gnu.org>
3928
3929 * image.c (imagemagick_load_image): Implement transparency.
3930
95988fcf
AS
39312012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3932
3933 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3934 account for preceding backslashes. (Bug#11663)
3935
cd4eb164
CY
39362012-06-09 Chong Yidong <cyd@gnu.org>
3937
3938 * term.c: Support italics in capable terminals (Bug#9652).
3939 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3940 (turn_on_face): Output using TS_enter_italic_mode if available.
3941 Don't handle unused blinking and alt-charset cases.
3942 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3943 and tty_alt_charset_p cases.
3944 (tty_capable_p, init_tty): Support italics.
3945
3946 * termchar.h (struct tty_display_info): Add field for italics.
3947 Remove unused blink field.
3948
3949 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3950 Handle slant.
3951
3952 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3953 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3954 tty_alt_charset_p. Add tty_italic_p.
3955
ff88beb8
MA
39562012-06-09 Michael Albinus <michael.albinus@gmx.de>
3957
3958 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3959 dbus_type_is_basic if available.
3960 (xd_extract_signed, xd_extract_unsigned): Rename from
3961 extract_signed and extract_unsigned, respectively. Adapt callers.
3962
44286096
CY
39632012-06-09 Chong Yidong <cyd@gnu.org>
3964
1682701f
CY
3965 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3966
44286096
CY
3967 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3968 case (Bug#9752).
3969
d86feb17
PE
39702012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3971
3972 * xdisp.c (vmessage): Treat frame message as multibyte.
3973 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3974 would generate the diagnostic "Making \302\247 buffer-local while
3975 let-bound!".
3976
d5c20fe8
EZ
39772012-06-08 Eli Zaretskii <eliz@gnu.org>
3978
3979 * dispnew.c (showing_window_margins_p): Undo last change, which
3980 was done due to an inadvertent commit.
3981 (adjust_frame_glyphs_for_frame_redisplay): Do call
3982 showing_window_margins_p.
3983
513749ee
SM
39842012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3985
3986 * eval.c (Fmake_var_non_special): New primitive.
3987 (syms_of_eval): Defsubr it.
3988 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3989
d4a8f5c1
JB
39902012-06-08 Juanma Barranquero <lekktu@gmail.com>
3991
3992 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3993 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3994
8bbbc977
EZ
39952012-06-08 Eli Zaretskii <eliz@gnu.org>
3996
3997 * alloc.c (allocate_vectorlike): Fix last change.
3998
f3372c87
DA
39992012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
4000
4001 Block-based vector allocation of small vectors.
4002 * lisp.h (struct vectorlike_header): New field `nbytes',
4003 adjust comment accordingly.
4004 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
4005 to denote vector blocks. Adjust users (live_vector_p,
4006 mark_maybe_pointer, valid_lisp_object_p) accordingly.
4007 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
4008 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
4009 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
4010 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
4011 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
4012 (roundup_size): New constant.
4013 (struct vector_block): New data type.
4014 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 4015 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
4016 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
4017 (sweep_vectors): New functions.
4018 (allocate_vectorlike): Return `zero_vector' as the only vector of
4019 0 items. Allocate new vector from block if vector size is less than
4020 or equal to VBLOCK_BYTES_MAX.
4021 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
4022 (init_alloc_once): Add call to init_vectors.
4023
4f18a4ed
SM
40242012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4025
4026 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
4027
86f158bc
PE
40282012-06-07 Paul Eggert <eggert@cs.ucla.edu>
4029
4030 * doprnt.c (doprnt): Truncate multibyte char correctly.
4031 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
4032 would mishandle a string argument "Xc" if X was a multibyte
4033 character of length 2: it would truncate after X's first byte
4034 rather than including all of X.
4035
c5cfcbe0
CY
40362012-06-06 Chong Yidong <cyd@gnu.org>
4037
4038 * buffer.c (word_wrap): Doc fix.
4039
c05cf390
PE
40402012-06-04 Paul Eggert <eggert@cs.ucla.edu>
4041
4042 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
4043
0c3461de
GM
40442012-06-03 Glenn Morris <rgm@gnu.org>
4045
4046 * xdisp.c (tool-bar-style): Doc fix.
4047
c71232db
UM
40482012-06-03 Ulrich Müller <ulm@gentoo.org>
4049
4050 * Makefile.in (PAXCTL): Define.
4051 (temacs$(EXEEXT)): Disable memory randomization for the temacs
4052 binary via PaX flags if the paxctl utility is available.
4053 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
4054 Restore PaX flags to their default. (Bug#11398)
4055
383f7350
CY
40562012-06-03 Chong Yidong <cyd@gnu.org>
4057
4058 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
4059 buffer (Bug#11226).
4060
5f2c76c6
CY
40612012-06-03 Chong Yidong <cyd@gnu.org>
4062
4063 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
4064 (note_mode_line_or_margin_highlight): If there is no help echo,
4065 use mode-line-default-help-echo. Handle the case where the mouse
4066 position is past the end of the mode line string.
4067
4068 * buffer.c (buffer_local_value_1): New function, split from
4069 Fbuffer_local_value; can return Qunbound.
4070 (Fbuffer_local_value): Use it.
4071 (Vmode_line_format): Docstring tweaks.
4072
773d47f6
PE
40732012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4074
4075 * sysdep.c (system_process_attributes): Improve comment.
4076
f2d6a3df
SM
40772012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
4078
4079 * keyboard.c: Export real-this-command to Elisp.
4080 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
4081 and DEFVAR it. Update all users.
4082
63810350
PE
40832012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4084
7bd5c1f4
PE
4085 * minibuf.c (Fassoc_string): Remove duplicate declaration.
4086
63810350
PE
4087 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
4088 Convert pctcpu and pctmem to Lisp float properly.
4089 Let the compiler fold better, as 100.0/0x8000 is exact.
4090
a2821611
AS
40912012-06-02 Andreas Schwab <schwab@linux-m68k.org>
4092
4093 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
4094 cons_block.
4095
5fceba1d
PE
40962012-06-01 Paul Eggert <eggert@cs.ucla.edu>
4097
4098 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
4099
c98ff5dd
DA
41002012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
4101
4102 For a 'struct window', replace some Lisp_Object fields to
4103 bitfields where appropriate, remove unused fields.
4104 * window.h (struct window): Remove unused 'last_mark_x' and
4105 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
4106 change it's type from Lisp_Object to bitfield.
4107 Change type of 'force_start', 'optional_new_start',
4108 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
4109 fields from Lisp_Object to bitfield. Adjust users accordingly.
4110
ca34e0be
PE
41112012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4112
4113 Pacify gcc -Wdouble-precision when using Xaw.
4114 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
4115 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
4116 Use 'float' consistently, rather than 'float' in most places
4117 and 'double' in a couple of places.
4118
efc00ab1 41192012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
4120
4121 * xdisp.c (handle_stop): Detect whether we have overlay strings
4122 loaded by testing it->current.overlay_string_index to be
4123 non-negative, instead of checking whether n_overlay_strings is
4124 positive. (Bug#11587)
4125
efc00ab1 41262012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
4127
4128 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
4129
4130 * doc.c (Fsubstitute_command_keys): Doc fix.
4131
efc00ab1 41322012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
4133
4134 * search.c (search_buffer): Remove calls to
4135 r_alloc_inhibit_buffer_relocation, as it is now called by
4136 maybe_unify_char, which was the cause of relocation of buffer text
4137 in bug#11519.
4138
efc00ab1 41392012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
4140
4141 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4142 for the duration of call to load_charset, to avoid problems with
4143 callers of maybe_unify_char that access buffer text through C
4144 pointers.
4145
4146 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
4147 decrement the inhibition flag, instead of just setting or
4148 resetting it.
4149
ba93a187
PE
41502012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4151
4152 Remove obsolete '#define static' cruft.
4153 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
4154 This #undef was "temporary" in 2000; it is no longer needed
4155 now that '#define static' has gone away.
4156 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
4157 (gray_bitmap_bits): Remove; no longer needed.
4158 All uses replaced with definiens.
4159 * xterm.c: Include "bitmaps/gray.xbm".
4160
9e4bf381
PE
41612012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4162
4163 Clean up __executable_start, monstartup when --enable-profiling.
4164 The following changes affect the code only when profiling.
4165 * dispnew.c (__executable_start): Rename from safe_bcopy.
4166 Define only on platforms that need it.
4167 * emacs.c: Include <sys/gmon.h> when profiling.
4168 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4169 (__executable_start): Remove decl, since lisp.h does it now.
4170 (safe_bcopy): Remove decl; no longer has that name.
4171 (main): Coalesce #if into single bit of code, for simplicity.
4172 Cast pointers to uintptr_t, since standard libraries want integers
4173 and not pointers.
4174 * lisp.h (__executable_start): New decl.
4175
32d72c2f
GM
41762012-05-31 Glenn Morris <rgm@gnu.org>
4177
4178 * image.c (Fimagemagick_types): Doc fix.
4179
baac5bc7
JM
41802012-05-30 Jim Meyering <meyering@redhat.com>
4181
4182 * callproc.c (Fcall_process_region): Include directory component
4183 in mkstemp error message (Bug#11586).
4184
72cb32cf
PE
41852012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4186
4187 * alloc.c, lisp.h (make_pure_vector): Now static.
4188
61b108cc
SM
41892012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4190
4191 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4192 Move to byte-run.el.
4193 (Fautoload): Do the hash-doc more carefully.
4194 * data.c (Fdefalias): Purify definition, except for keymaps.
4195 (Qdefun): Move from eval.c.
4196 * lisp.h (Qdefun): Remove.
4197 * lread.c (read1): Tiny simplification.
4198
471fe23d
TN
41992012-05-29 Troels Nielsen <bn.troels@gmail.com>
4200
934f3f58 4201 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4202 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4203 Bug#9642, but explicitly check that the buffer the overlay would
4204 be moved to is live and rearrange lines to make sure that errors
4205 will not put the overlay in an inconsistent state.
4206 (Fdelete_overlay): Cosmetics.
4207
85d0efd1
EZ
42082012-05-28 Eli Zaretskii <eliz@gnu.org>
4209
4210 * w32term.c (my_bring_window_to_top): New function.
4211 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4212 could be different from the original one.
4213 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4214 (Bug#11513)
4215
4216 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4217 by calling BringWindowToTop.
4218
4219 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4220 (WM_EMACS_END): Increase by one.
4221
da92a98c
PE
42222012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4223
4224 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4225 This avoids undefined behavior that might cause the eassert
4226 to not catch an out-of-range value.
4227
74d1f848
JB
42282012-05-28 Juanma Barranquero <lekktu@gmail.com>
4229
4230 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4231 Update dependencies.
4232
9e1a06fc
EZ
42332012-05-27 Eli Zaretskii <eliz@gnu.org>
4234
4235 * bidi.c (bidi_mirror_char): Fix last change.
4236
f3dd7312
AS
42372012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4238
4239 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4240 when referring to sectname field in printf format.
4241
81899c91
PE
42422012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4243
57b81a9f
PE
4244 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4245 Only r_alloc_inhibit_buffer_relocation needed to be added;
4246 the others were already declared.
4247
81899c91
PE
4248 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4249 before checking whether it's out of range. Put the check inside
4250 eassert. See
4251 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4252
33017faf 42532012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4254
4255 * callproc.c (Fcall_process): Restore a line that was accidentally
4256 commented out in the 2011-02-13 change (bug#11547).
4257
33017faf 42582012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4259
4260 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4261 defined on ralloc.c.
4262
4263 * buffer.c [REL_ALLOC]: Remove prototypes of
4264 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4265 they are now on lisp.h.
4266
4267 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4268
4269 * search.c (search_buffer): Use it to inhibit relocation of buffer
4270 text while re_search_2 is doing its job, because re_search_2 is
4271 passed C pointers to buffer text. (Bug#11519)
4272
23415acf
EZ
4273 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4274 Update value to 24.
4275
44e27368
EZ
4276 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4277 state after an additional call to move_it_in_display_line_to, keep
4278 the values of it->max_ascent and it->max_descent found for the
4279 entire line.
4280 (pos_visible_p): Revert the comparison against bottom_y to what it
4281 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4282 (Bug#11464)
4283
c1892f11
PE
42842012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4285
4286 Fix coding-related core dumps with gcc -ftrapv.
4287 The code was computing A - B, where A and B are pointers, and B is
4288 random garbage. This can lead to core dumps on platforms that
4289 have special pointer registers, and it also leads to core dumps on
4290 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4291 A - B only when B is initialized properly.
4292 * coding.c (coding_set_source, coding_set_destination): Return void.
4293 (coding_change_source, coding_change_destinations): New functions,
4294 with the old behaviors of coding_set_source and coding_set_destination.
4295 All callers that need an offset changed to use these new functions.
4296
eb7afdad
GM
42972012-05-26 Glenn Morris <rgm@gnu.org>
4298
4299 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4300
f12fdf02
EZ
43012012-05-26 Eli Zaretskii <eliz@gnu.org>
4302
53a63be6 4303 Extend mouse support on W32 text-mode console.
61b108cc
SM
4304 * xdisp.c (draw_row_with_mouse_face):
4305 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4306
eb3f6f01 4307 * w32console.c: Include window.h.
61b108cc
SM
4308 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4309 New functions.
eb3f6f01
EZ
4310 (initialize_w32_display): Initialize mouse-highlight data.
4311
53a63be6
EZ
4312 * w32inevt.c: Include termchar.h and window.h.
4313 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4314 moves, call note_mouse_highlight. If help_echo changed, call
4315 gen_help_event to produce help-echo message in the echo area.
4316 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4317 highlight info.
4318
4cfd81f6
PE
43192012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4320
4321 * lread.c (read1): Simplify slightly to avoid an overflow warning
4322 with GCC 4.7.0 on x86-64.
4323
4446092a
EZ
43242012-05-26 Eli Zaretskii <eliz@gnu.org>
4325
4326 * bidi.c (bidi_mirror_char): Revert last change: an int is
4327 definitely wide enough here.
4328
42b2a986 43292012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4330
42b2a986 4331 Fix integer width and related bugs (Bug#9874).
eb106a49 4332 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4333 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4334 (string_bytes, check_sblock, allocate_string_data):
4335 (compact_small_strings, Fmake_bool_vector, make_string)
4336 (make_unibyte_string, make_multibyte_string)
4337 (make_string_from_bytes, make_specified_string)
4338 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4339 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4340 (mark_vectorlike):
4341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4342 (allocate_pseudovector):
4343 Use int, not EMACS_INT, where int is wide enough.
4344 (inhibit_garbage_collection, Fgarbage_collect):
4345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4346 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4347 int might not be wide enough.
4348 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4349 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4350 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4351 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4352 (bidi_level_of_next_char, bidi_move_to_visually_next):
4353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4354 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4355 (Fkill_buffer, Fset_buffer_major_mode)
4356 (advance_to_char_boundary, Fbuffer_swap_text)
4357 (Fset_buffer_multibyte, overlays_at, overlays_in)
4358 (overlay_touches_p, struct sortvec, record_overlay_string)
4359 (overlay_strings, recenter_overlay_lists)
4360 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4361 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4362 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4363 (Foverlay_recenter, last_overlay_modification_hooks_used)
4364 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4366 (validate_region): Omit unnecessary test for b <= e,
4367 since that's guaranteed by the previous test.
d311d28c
PE
4368 (adjust_overlays_for_delete): Avoid pos + length overflow.
4369 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4370 (report_overlay_modification):
4371 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4372 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4373 Omit pointer cast, which isn't needed anyway, and doesn't work
4374 after the EMACS_INT -> ptrdiff_t change.
02481186 4375 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4376 * buffer.h: Adjust decls to match defn changes elsewhere.
4377 (struct buffer_text, struct buffer):
4378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4379 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4380 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4381 not int, to avoid needless 32-bit limit on 64-bit hosts.
4382 (exec_byte_code): Use tighter memory-full test, one that checks
4383 for alloca overflow. Don't compute the address of the object just
4384 before an array, as that's not portable. Use EMACS_INT, not
4385 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4386 * callint.c (Fcall_interactively):
4387 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4388 * callproc.c (call_process_kill, Fcall_process):
4389 Don't assume pid_t fits into an Emacs fixnum.
4390 (call_process_cleanup, Fcall_process, child_setup):
4391 Don't assume pid_t fits into int.
4392 (call_process_cleanup, Fcall_process, delete_temp_file)
4393 (Fcall_process_region):
4394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4395 (Fcall_process): Simplify handling of volatile integers.
4396 Use int, not EMACS_INT, where int will do.
4397 * casefiddle.c (casify_object, casify_region, operate_on_word)
4398 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4400 (casify_object): Avoid integer overflow when overallocating buffer.
4401 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4402 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4403 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4404 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4405 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4406 integers are now checked earlier. All uses replaced with XINT.
4407 (ccl_driver):
4408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4409 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4410 (ccl_driver, Fregister_code_conversion_map):
4411 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4412 (resolve_symbol_ccl_program): Check that vector header is in range.
4413 Always copy the vector, so that we can check its contents reliably
4414 now rather than having to recheck each instruction as it's being
4415 executed. Check that vector words fit in 'int'.
4416 (ccl_get_compiled_code, Fregister_ccl_program)
4417 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4418 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4419 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4420 contents are in range.
4421 (Fccl_execute_on_string): Check that status is in range.
4422 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4423 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4424 Accept and return EMACS_INT, not int, because callers can pass values
4425 out of 'int' range.
4426 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4427 (multibyte_chars_in_text, parse_str_as_multibyte)
4428 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4429 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4430 (string_escape_byte8, Fget_byte):
4431 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4432 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4433 avoid mishandling large integers.
4434 * character.h: Adjust decls to match defn changes elsewhere.
4435 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4436 (Ffind_charset_region):
4437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4438 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4439 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4440 Don't assume fixnum fits in int.
d311d28c
PE
4441 (load_charset_map_from_vector, Fmap_charset_chars):
4442 Remove now-unnecessary CHECK_NATNUMs.
4443 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4444 Don't rely on undefined behavior with signed left shift overflow.
4445 Don't assume unsigned int fits into fixnum, or that fixnum fits
4446 into unsigned int. Don't require max_code to be a valid fixnum;
4447 that's not true for gb10830 4-byte on a 32-bit host. Allow
4448 invalid_code to be a cons, for the same reason. Require code_offset
4449 to be a character. Avoid int overflow if max_char is close
4450 to INT_MAX.
4451 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4452 this is intended anyway and avoids some undefined behavior.
4453 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4454 INDEX_TO_CODE_POINT, as that's what it expects.
4455 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4456 * charset.h (DECODE_CHAR): Return int, not unsigned;
4457 this is what was intended anyway, and it avoids undefined behavior.
4458 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4459 integer-overflow issues.
4460 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4461 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4462 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4463 * chartab.c (Fmake_char_table, Fset_char_table_range)
4464 (uniprop_get_decoder, uniprop_get_encoder):
4465 Don't assume fixnum fits in int.
4466 * cmds.c (move_point): New function, that does the gist of
4467 Fforward_char and Fbackward_char, but does so while checking
4468 for integer overflow more accurately.
c96e5d6a 4469 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4470 (Fforward_line, Fend_of_line, internal_self_insert)
4471 (internal_self_insert):
4472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4473 Fix a FIXME, by checking for integer overflow when calculating
4474 target_clm and actual_clm.
4475 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4476 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4477 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4478 (coding_alloc_by_making_gap, alloc_destination)
4479 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4480 (encode_coding_utf_16, detect_coding_emacs_mule)
4481 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4482 (detect_coding_iso_2022, decode_coding_iso_2022)
4483 (encode_invocation_designation, encode_designation_at_bol)
4484 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4485 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4486 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4487 (encode_coding_ccl, encode_coding_raw_text)
4488 (detect_coding_charset, decode_coding_charset)
4489 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4490 (produce_composition, produce_charset, produce_annotation)
4491 (decode_coding, handle_composition_annotation)
4492 (handle_charset_annotation, consume_chars, decode_coding_gap)
4493 (decode_coding_object, encode_coding_object, detect_coding_system)
4494 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4495 (code_convert_region, code_convert_string)
8f50130c
PE
4496 (Fdefine_coding_system_internal)
4497 (coding_set_source, coding_set_destination):
d311d28c
PE
4498 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4499 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4500 (Fdefine_coding_system_internal):
4501 Don't assume fixnums fit in int.
4502 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4503 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4504 (Funencodable_char_position, Fcheck_coding_systems_region)
4505 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4507 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4508 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4509 Don't access memory outside of the args array.
d311d28c 4510 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4511 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4512 result of ENCODE_CHAR.
d311d28c
PE
4513 * coding.h: Adjust decls to match defn changes elsewhere.
4514 (struct coding_system):
4515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4516 * composite.c (get_composition_id, find_composition)
4517 (run_composition_function, update_compositions)
4518 (compose_text, composition_gstring_put_cache)
4519 (composition_gstring_p, composition_gstring_width)
4520 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4521 (composition_compute_stop_pos, composition_reseat_it)
4522 (composition_update_it, struct position_record)
4523 (find_automatic_composition, composition_adjust_point)
4524 (Fcomposition_get_gstring, Ffind_composition_internal):
4525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4526 (update_compositions):
4527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4528 * composite.h: Adjust decls to match defn changes elsewhere.
4529 (struct composition):
4530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4531 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4532 Do not attempt to compute the address of the object just before a
4533 buffer; this is not portable.
4534 (Faref, Faset):
4535 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4536 (Faset): Use int, not EMACS_INT, where int is wide enough.
4537 (Fstring_to_number): Don't assume fixnums fit in int.
4538 (Frem): Don't assume arg is nonnegative.
4539 * dbusbind.c (xd_append_arg): Check for integers out of range.
4540 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4541 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4542 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4543 (xd_get_connection_references): Return ptrdiff_t, not int.
4544 All uses changed.
4545 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4546 (xd_read_message_1):
4547 Use int, not unsigned, where the dbus API uses int.
4548 (Fdbus_message_internal): Don't overflow mtype.
4549 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4550 * dired.c (directory_files_internal, file_name_completion, scmp)
4551 (file_name_completion_stat):
4552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4553 (file_name_completion): Don't overflow matchcount.
4554 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4555 * dispextern.h: Adjust decls to match defn changes elsewhere.
4556 (struct text_pos, struct glyph, struct bidi_saved_info)
4557 (struct bidi_string_data, struct bidi_it, struct composition_it)
4558 (struct it):
4559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4560 (struct display_pos, struct composition_it, struct it):
4561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4562 * dispnew.c (increment_matrix_positions)
4563 (increment_row_positions, mode_line_string)
4564 (marginal_area_string):
4565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4566 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4568 (duration_to_sec_usec): New function, to check for overflow better.
4569 (Fsleep_for, sit_for): Use it.
4570 * doc.c (get_doc_string, store_function_docstring):
4571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4572 (get_doc_string, Fsnarf_documentation):
4573 Use int, not EMACS_INT, where int is wide enough.
4574 (get_doc_string):
4575 Use SAFE_ALLOCA, not alloca.
4576 Check for overflow when converting EMACS_INT to off_t.
4577 * doprnt.c (doprnt):
4578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4579 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4580 Don't assume uid_t fits into fixnum.
4581 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4582 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4583 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4584 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4585 (general_insert_function)
4586 (Finsert_char, make_buffer_string, make_buffer_string_both)
4587 (update_buffer_properties, Fbuffer_substring)
4588 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4589 (Fsubst_char_in_region, check_translation)
4590 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4591 (transpose_markers, Ftranspose_regions):
4592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4593 (clip_to_bounds): Move to lisp.h as an inline function).
4594 (Fconstrain_to_field): Don't assume integers are nonnegative.
4595 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4596 (Fsubst_char_in_region, Fsave_restriction):
4597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4598 (Femacs_pid): Don't assume pid_t fits into fixnum.
4599 (lo_time): Use int, not EMACS_INT, when int suffices.
4600 (lisp_time_argument): Check for usec out of range.
4601 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4602 (Fuser_login_name, Fuser_full_name): Signal an error
4603 if a uid argument is out of range, rather than relying on
4604 undefined behavior.
c8d5c857
PE
4605 (Fformat_time_string): Remove now-unnecessary check.
4606 lisp_time_argument checks for out-of-range usec now.
243e0530 4607 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4608 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4609 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4610 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4611 (init_cmdargs, Fdump_emacs):
4612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4613 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4614 the bottom (typically) 32 bits of the fixnum.
4615 * eval.c (specpdl_size, call_debugger):
4616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4617 (when_entered_debugger, Fbacktrace_debug):
4618 Don't assume fixnum can fit in int.
4619 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4620 the object just before a buffer; this is not portable.
4621 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4622 (grow_specpdl, unbind_to):
4623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4624 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4625 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4626 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4627 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4628 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4630 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4631 (a_write, e_write):
4632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4633 (Fcopy_file, non_regular_nbytes, read_non_regular)
4634 (Finsert_file_contents):
4635 Use int, not EMACS_INT, where int is wide enough.
4636 (READ_BUF_SIZE): Verify that it fits in int.
4637 (Finsert_file_contents): Check that counts are in proper range,
4638 rather than assuming fixnums fit into ptrdiff_t etc.
4639 Don't assume fixnums fit into int.
125b3835 4640 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4641 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4642 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4643 (string_char_to_byte, string_byte_to_char)
4644 (string_make_multibyte, string_to_multibyte)
4645 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4646 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4647 (substring_both, Fdelete, internal_equal, Ffillarray)
4648 (Fclear_string, mapcar1)
4649 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4650 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4651 (larger_vector, make_hash_table, maybe_resize_hash_table)
4652 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4653 (Fmaphash, secure_hash):
4654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4655 (concat): Check for string index and length overflow.
4656 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4657 (Frequire):
4658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4659 (larger_vector): New API (vec, incr_min, size_max) replaces old
4660 one (vec, new_size, init). This catches size overflow.
4661 INIT was removed because it was always Qnil.
4662 All callers changed.
4663 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4664 the upper bound on a hash table index size.
4665 (make_hash_table, maybe_resize_hash_table): Use it.
4666 (secure_hash): Computer start_byte and end_byte only after
4667 they're known to be in ptrdiff_t range.
4668 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4669 (Ffont_get_glyphs, Ffont_at):
4670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4671 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4672 (Flist_fonts, Fopen_font):
4673 Don't assume fixnum can fit in int.
4674 (check_gstring): Don't assume index can fit in int.
4675 (font_match_p): Check that fixnum is a character, not a nonnegative
4676 fixnum, since the later code needs to stuff it into an int.
4677 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4678 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4679 conversion overflow issues.
4680 (Fopen_font): Check for integer out of range.
4681 (Ffont_get_glyphs): Don't assume index can fit in int.
4682 * font.h: Adjust decls to match defn changes elsewhere.
4683 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4684 integer overflow.
4685 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4686 printmax_t, where ptrdiff_t is wide enough.
4687 (Finternal_char_font):
4688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4689 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4690 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4691 (Fset_frame_position, x_set_frame_parameters)
4692 (x_set_line_spacing, x_set_border_width)
4693 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4694 Check that fixnums are in proper range for system types.
4695 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4697 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4698 Use SAFE_ALLOCA_LISP, not alloca.
4699 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4700 intptr_t is wide enough.
4701 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4702 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4703 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4704 Check for fixnum out of range.
4705 * ftfont.c (ftfont_list): Don't assume index fits in int.
4706 Check that fixnums are in proper range for system types.
4707 (ftfont_shape_by_flt):
4708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4709 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4711 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4712 Check that fixnums are in proper range for system types.
4713 * gnutls.h: Adjust decls to match defn changes elsewhere.
4714 * gtkutil.c (xg_dialog_run):
4715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4716 (update_frame_tool_bar):
4717 Check that fixnums are in proper range for system types.
4718 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4719 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4720 * indent.c (last_known_column, last_known_column_point):
4721 (current_column_bol_cache):
4722 (skip_invisible, current_column, check_display_width):
4723 (check_display_width, scan_for_column, current_column_1)
4724 (Findent_to, Fcurrent_indentation, position_indentation)
4725 (indented_beyond_p, Fmove_to_column, compute_motion):
4726 (Fcompute_motion, Fvertical_motion):
4727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4728 (last_known_column_modified): Use EMACS_INT, not int.
4729 (check_display_width):
4730 (Fcompute_motion):
4731 Check that fixnums and floats are in proper range for system types.
4732 (compute_motion): Don't assume index or fixnum fits in int.
4733 (compute_motion, Fcompute_motion):
4734 Use int, not EMACS_INT, when it is wide enough.
4735 (vmotion): Omit local var start_hpos that is always 0; that way
4736 we don't need to worry about overflow in expressions involving it.
4737 * indent.h: Adjust decls to match defn changes elsewhere.
4738 (struct position):
4739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4740 Use int, not EMACS_INT, where int is wide enough.
4741 Remove unused members ovstring_chars_done and tab_offset;
4742 all uses removed.
4743 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4744 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4745 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4746 (make_gap, copy_text, insert, insert_and_inherit)
4747 (insert_before_markers, insert_before_markers_and_inherit)
4748 (insert_1, count_combining_before, count_combining_after)
4749 (insert_1_both, insert_from_string)
4750 (insert_from_string_before_markers, insert_from_string_1)
4751 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4752 (adjust_after_replace, adjust_after_insert, replace_range)
4753 (replace_range_2, del_range, del_range_1, del_range_byte)
4754 (del_range_both, del_range_2, modify_region)
4755 (prepare_to_modify_buffer, signal_before_change)
4756 (signal_after_change, Fcombine_after_change_execute):
4757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4758 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4759 (balance_an_interval, split_interval_right, split_interval_left)
4760 (find_interval, next_interval, update_interval)
4761 (adjust_intervals_for_insertion, delete_node, delete_interval)
4762 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4763 (static_offset_intervals, offset_intervals)
4764 (merge_interval_right, merge_interval_left, make_new_interval)
4765 (graft_intervals_into_buffer, temp_set_point_both)
4766 (temp_set_point, set_point, adjust_for_invis_intang)
4767 (set_point_both, move_if_not_intangible, get_property_and_range)
4768 (get_local_map, copy_intervals, copy_intervals_to_string)
4769 (compare_string_intervals, set_intervals_multibyte_1):
4770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4771 * intervals.h: Adjust decls to match defn changes elsewhere.
4772 (struct interval):
4773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4774 * keyboard.c (this_command_key_count, this_single_command_key_start)
4775 (before_command_key_count, before_command_echo_length, echo_now)
4776 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4777 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4778 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4779 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4781 (last_non_minibuf_size, last_point_position, echo_truncate)
4782 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4783 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4784 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4785 (stuff_buffered_input):
4786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4787 (last_auto_save, command_loop_1, read_char):
4788 Use EMACS_INT, not int, to avoid integer overflow.
4789 (record_char): Avoid overflow in total_keys computation.
4790 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4791 * keyboard.h: Adjust decls to match defn changes elsewhere.
4792 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4793 (Fkey_description, Fdescribe_vector, Flookup_key):
4794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4795 (click_position): New function, to check that positions are in range.
4796 (Fcurrent_active_maps):
4797 (describe_command):
4798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4799 (Faccessible_keymaps, Fkey_description):
4800 (preferred_sequence_p):
4801 Don't assume fixnum can fit into int.
4802 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4803 Check for integer overflow in size calculations.
4804 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4805 avoid mishandling large integers.
4806 * lisp.h: Adjust decls to match defn changes elsewhere.
4807 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4808 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4809 (struct Lisp_Marker):
4810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4811 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4812 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4813 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4814 All callers changed.
4815 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4816 Assume the arg has valid form, since it always does.
4817 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4818 unsigned integer system type.
4819 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4820 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4822 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4823 (duration_to_sec_usec): New decl.
4824 * lread.c (read_from_string_index, read_from_string_index_byte)
4825 (read_from_string_limit, readchar, unreadchar, openp)
4826 (read_internal_start, read1, oblookup):
4827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4828 (Fload, readevalloop, Feval_buffer, Feval_region):
4829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4830 (openp): Check for out-of-range argument to 'access'.
4831 (read1): Use int, not EMACS_INT, where int is wide enough.
4832 Don't assume fixnum fits into int.
6efdadfd 4833 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4834 (read_filtered_event): Use duration_to_sec_usec
4835 to do proper overflow checking on durations.
d311d28c
PE
4836 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4837 in size calculation.
4838 (Fexecute_kbd_macro):
4839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4840 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4841 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4842 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4843 (set_marker_both, set_marker_restricted_both, marker_position)
4844 (marker_byte_position, Fbuffer_has_markers_at):
4845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4846 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4847 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4848 It now merely ensures that the menu is large enough, without
4849 necessarily growing it, as this avoids some integer overflow issues.
4850 All callers changed.
4851 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4853 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4854 Use SAFE_ALLOCA_LISP, not alloca.
4855 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4856 to EMACS_INT. Check that fixnums are in proper range for system types.
4857 * minibuf.c (minibuf_prompt_width, string_to_object)
4858 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4859 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4861 (get_minibuffer, read_minibuf_unwind):
4862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4863 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4864 this simplifies overflow checking. All callers changed.
4865 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4866 (Ftest_completion):
4867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4868 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4869 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4870 Check that fixnums are in proper range for system types.
4871 (Fx_create_frame, Fx_show_tip):
4872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4873 * nsfont.m (ns_findfonts, nsfont_list_family):
4874 Don't assume fixnum fits in long.
4875 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4877 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4878 wide enough.
17fdb222 4879 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4881 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4882 (PRINTDECLARE, PRINTPREPARE):
4883 (strout, print_string):
4884 (print, print_preprocess, print_check_string_charset_prop)
4885 (print_object):
4886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4887 (PRINTDECLARE):
4888 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4890 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4891 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4892 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4893 (print_error_message): Use SAFE_ALLOCA, not alloca.
4894 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4895 (print_depth, new_backquote_output, print_number_index):
4896 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4897 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4898 (Fset_process_window_size, Fformat_network_address)
4899 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4900 (sigchld_handler):
d311d28c 4901 Check that fixnums are in proper range for system types.
d44287d4 4902 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4903 Check for process-ids out of pid_t range rather than relying on
4904 undefined behavior.
e4d81efc 4905 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4906 (Fformat_network_address, read_process_output, send_process)
4907 (Fprocess_send_region, status_notify):
4908 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4909 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4910 (wait_reading_process_output, read_process_output, exec_sentinel):
4911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4912 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4913 (Faccept_process_output): Use duration_to_sec_usec to do proper
4914 overflow checking on durations.
dde14581
PE
4915 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4916 Don't assume pid_t fits in int.
02481186
PE
4917 * process.h (struct Lisp_Process): Members tick and update_tick
4918 are now of type EMACS_INT, not int.
b62b53e8
PE
4919 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4920 configured --with-wide-int.
d311d28c
PE
4921 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4922 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4923 * search.c (looking_at_1, string_match_1):
4924 (fast_string_match, fast_c_string_match_ignore_case)
4925 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4926 (scan_newline, find_before_next_newline, search_command)
4927 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4928 (set_search_regs, wordify):
4929 (Freplace_match):
4930 (Fmatch_data):
4931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4932 (string_match_1, search_buffer, set_search_regs):
4933 (Fmatch_data):
4934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4935 (wordify): Check for overflow in size calculation.
4936 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4937 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4938 Check that fixnums are in proper range for system types.
4939 * sound.c (struct sound_device)
4940 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4942 (Fplay_sound_internal):
4943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4944 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4945 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4946 (Fparse_partial_sexp):
4947 Don't assume fixnums can fit in int.
4948 (struct lisp_parse_state, find_start_pos, find_start_value)
4949 (find_start_value_byte, find_start_begv)
4950 (update_syntax_table, char_quoted, dec_bytepos)
4951 (find_defun_start, prev_char_comend_first, back_comment):
4952 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4953 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4955 (Finternal_describe_syntax_value): Check that match_lisp is a
4956 character, not an integer, since the code stuffs it into int.
4957 (scan_words, scan_sexps_forward):
4958 Check that fixnums are in proper range for system types.
4959 (Fforward_word):
4960 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4961 (scan_sexps_forward):
4962 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4963 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4964 * syntax.h: Adjust decls to match defn changes elsewhere.
4965 (struct gl_state_s):
4966 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4967 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4968 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4969 * sysdep.c (wait_for_termination_1, wait_for_termination)
4970 (interruptible_wait_for_termination, mkdir):
4971 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4972 (emacs_read, emacs_write):
4973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4974 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4975 and double all fit in int.
d311d28c
PE
4976 * term.c (set_tty_color_mode):
4977 Check that fixnums are in proper range for system types.
4978 * termhooks.h (struct input_event):
4979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4980 * textprop.c (validate_interval_range, interval_of)
4981 (Fadd_text_properties, set_text_properties_1)
4982 (Fremove_text_properties, Fremove_list_of_text_properties)
4983 (Ftext_property_any, Ftext_property_not_all)
4984 (copy_text_properties, text_property_list, extend_property_ranges)
4985 (verify_interval_modification):
4986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4987 (Fnext_single_char_property_change)
4988 (Fprevious_single_char_property_change):
4989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4990 (copy_text_properties):
4991 Check for integer overflow in index calculation.
d311d28c
PE
4992 * undo.c (last_boundary_position, record_point, record_insert)
4993 (record_delete, record_marker_adjustment, record_change)
4994 (record_property_change):
4995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4996 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4998 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4999 (Fx_hide_tip, Fx_file_dialog):
5000 * w32menu.c (set_frame_menubar):
5001 Use ptrdiff_t, not int, for consistency with rest of code.
5002 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
5003 (select_window, Fdelete_other_windows_internal)
5004 (window_scroll_pixel_based, window_scroll_line_based)
5005 (Frecenter, Fset_window_configuration):
5006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5007 (Fset_window_hscroll, run_window_configuration_change_hook)
5008 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 5009 (Fscroll_other_window, Frecenter):
d311d28c
PE
5010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5011 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
5012 Don't assume fixnum fits in int.
5013 (Fset_window_scroll_bars):
5014 Check that fixnums are in proper range for system types.
5015 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
5016 (string_pos, c_string_pos, number_of_chars, init_iterator)
5017 (in_ellipses_for_invisible_text_p, init_from_display_pos)
5018 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
5019 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
5020 (face_before_or_after_it_pos, handle_invisible_prop)
5021 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
5022 (display_prop_intangible_p, string_buffer_position_lim)
5023 (string_buffer_position, handle_composition_prop, load_overlay_strings)
5024 (get_overlay_strings_1, get_overlay_strings)
5025 (iterate_out_of_display_property, forward_to_next_line_start)
5026 (back_to_previous_visible_line_start, reseat, reseat_to_string)
5027 (get_next_display_element, set_iterator_to_next)
5028 (get_visually_first_element, compute_stop_pos_backwards)
5029 (handle_stop_backwards, next_element_from_buffer)
5030 (move_it_in_display_line_to, move_it_in_display_line)
5031 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5032 (add_to_log, message_dolog, message_log_check_duplicate)
5033 (message2, message2_nolog, message3, message3_nolog
5034 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
5035 (current_message_1, truncate_echo_area, truncate_message_1)
5036 (set_message, set_message_1, store_mode_line_noprop)
5037 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
5038 (text_outside_line_unchanged_p, check_point_in_composition)
5039 (reconsider_clip_changes)
5040 (redisplay_internal, set_cursor_from_row, try_scrolling)
5041 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
5042 (redisplay_window, find_last_unchanged_at_beg_row)
5043 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
5044 (trailing_whitespace_p, find_row_edges, display_line)
5045 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
5046 (display_mode_element, store_mode_line_string)
5047 (pint2str, pint2hrstr, decode_mode_spec)
5048 (display_count_lines, display_string, draw_glyphs)
5049 (x_produce_glyphs, x_insert_glyphs)
5050 (rows_from_pos_range, mouse_face_from_buffer_pos)
5051 (fast_find_string_pos, mouse_face_from_string_pos)
5052 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5054 (safe_call, init_from_display_pos, handle_fontified_prop)
5055 (handle_single_display_spec, load_overlay_strings)
5056 (with_echo_area_buffer, setup_echo_area_for_printing)
5057 (display_echo_area, echo_area_display)
5058 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
5059 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
5060 (redisplay_window, dump_glyph_row, display_mode_line)
5061 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 5062 (handle_display_spec, display_prop_string_p):
d311d28c
PE
5063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5064 (handle_single_display_spec, build_desired_tool_bar_string)
5065 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
5066 (get_specified_cursor_type):
5067 Check that fixnums are in proper range for system types.
5068 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
5069 (Flookup_image_map):
5070 Don't assume fixnums fit in int.
5071 (compare_overlay_entries):
5072 Avoid mishandling comparisons due to subtraction overflow.
5073 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
5074 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
5075 (handle_tool_bar_click):
5076 Use int, not unsigned, since we prefer signed and the signedness
5077 doesn't matter here.
5078 (get_next_display_element, next_element_from_display_vector):
5079 Use int, not EMACS_INT, when int is wide enough.
5080 (start_hourglass): Use duration_to_sec_usec to do proper
5081 overflow checking on durations.
5082 * xfaces.c (Fbitmap_spec_p):
5083 Check that fixnums are in proper range for system types.
5084 (compare_fonts_by_sort_order):
5085 Avoid mishandling comparisons due to subtraction overflow.
5086 (Fx_family_fonts, realize_basic_faces):
5087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5088 (Fx_family_fonts):
5089 Don't assume fixnum fits in int.
5090 Use SAFE_ALLOCA_LISP, not alloca.
5091 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
5092 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
5093 (face_at_buffer_position, face_for_overlay_string)
5094 (face_at_string_position):
5095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5096 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
5097 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
5098 (Fx_show_tip):
5099 Check that fixnums are in proper range for system types.
5100 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5101 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
5102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5103 (Fx_change_window_property): Don't assume fixnums fit in int.
5104 * xfont.c (xfont_chars_supported):
5105 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5106 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
5107 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
5108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5109 * xml.c (parse_region):
5110 * xrdb.c (magic_file_p):
5111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5112 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
5113 (x_get_local_selection, x_reply_selection_request)
5114 (x_handle_selection_request, wait_for_property_change):
5115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5116 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
5117 short is wide enough.
5118 (x_send_client_event): Don't assume fixnum fits in int.
5119 * xterm.c (x_x_to_emacs_modifiers):
5120 Don't assume EMACS_INT overflows nicely into int.
5121 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
5122 may come from Lisp.
5123 (handle_one_xevent): NATNUMP can eval its arg twice.
5124 (x_connection_closed):
5125 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5126 * xterm.h: Adjust decls to match defn changes elsewhere.
5127 (struct scroll_bar): Use struct vectorlike_header
5128 rather than rolling our own approximation.
5129 (SCROLL_BAR_VEC_SIZE): Remove; not used.
5130
c6574eb5
GM
51312012-05-25 Glenn Morris <rgm@gnu.org>
5132
5133 * lisp.mk (lisp): Update for more files being compiled now.
5134
e8d32c7e
SM
51352012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
5136
48def666
SM
5137 * lread.c: Remove `read_pure' which makes no difference.
5138 (read_pure): Remove var.
5139 (unreadpure): Remove function.
5140 (readevalloop): Don't call read_list with -1 flag.
5141 (read1, read_vector): Don't test read_pure any more.
5142 (read_list): Simplify.
5143
e8d32c7e
SM
5144 * fileio.c, character.h: Minor style tweaks.
5145
4b2addb7
DA
51462012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
5147
5148 * window.h (clip_changed): Remove useless declaration.
5149
584461b2
JB
51502012-05-22 Juanma Barranquero <lekktu@gmail.com>
5151
5152 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
5153 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
5154
34374650
PE
51552012-05-22 Paul Eggert <eggert@cs.ucla.edu>
5156
5157 Remove src/m/*.
5158 This directory predates autoconf and is no longer needed nowadays.
5159 Move its few remaining bits of functionality to where they're needed.
5160 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
5161 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
5162 * m/template.h: Remove.
5163 * Makefile.in (M_FILE): Remove. All uses removed.
5164 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
5165 * lisp.h (USE_LSB_TAG):
5166 * mem-limits.h (EXCEEDS_LISP_PTR):
5167 Use VAL_MAX, not VALBITS, in #if.
5168 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5169 (EMACS_UINT): Define unconditionally now.
5170 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5171 (BITS_PER_EMACS_INT): New constants, replacing
5172 what used to be in config.h, but not useful in #if.
5173 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5174 define them any more.
5175 (VAL_MAX): New macro.
5176 (VALMASK): Use it.
5177 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5178 BITS_PER_EMACS_INT, in #if.
5179 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5180 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5181 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5182 * s/ms-w32.h (DATA_START):
5183 Move here from removed file m/intel386.h.
5184 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5185 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5186
261cb4bb
PE
51872012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5188
5189 Assume C89 or later.
5190 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5191 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5192 (xrealloc):
5193 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5194 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5195 * textprop.c, tparam.c (NULL): Remove.
5196 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5197 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5198 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5199 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5200 * xterm.c (input_signal_count): Assume volatile works.
5201
ff23cd9f
KB
52022012-05-21 Ken Brown <kbrown@cornell.edu>
5203
5204 * xgselect.c (xg_select): Fix first argument in call to 'select'
5205 (bug#11508).
5206
1b170bc6
KB
52072012-05-20 Ken Brown <kbrown@cornell.edu>
5208
5209 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5210 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5211
b2f4d39f
KB
52122012-05-19 Ken Brown <kbrown@cornell.edu>
5213
5214 * xfns.c (x_in_use): Remove `static' qualifier.
5215 * xterm.h (x_in_use): Declare.
5216 * xgselect.c: Include xterm.h.
5217 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5218 and `display_arg' (bug#9754).
5219
003fdae2
PE
52202012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5221
9232a6d9
PE
5222 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5223
003fdae2
PE
5224 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5225 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5226
784b56e2
EZ
52272012-05-18 Eli Zaretskii <eliz@gnu.org>
5228
5229 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5230
5231 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5232 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5233
5234 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5235 reference to image_cache->refcount.
5236 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5237
a0a79cde
JL
52382012-05-17 Juri Linkov <juri@jurta.org>
5239
5240 * search.c (Fword_search_regexp, Fword_search_backward)
5241 (Fword_search_forward, Fword_search_backward_lax)
5242 (Fword_search_forward_lax): Move functions to isearch.el
5243 (bug#10145, bug#11381).
5244
b0572523
PE
52452012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5248
9660f5fc
SM
52492012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5250
5251 * lread.c (init_obarray): Declare Qt and Qnil as special.
5252
4374de83
GM
52532012-05-14 Glenn Morris <rgm@gnu.org>
5254
5255 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5256 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5257
dc44c39a
PE
52582012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5259
078c97cb
PE
5260 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5261
dc44c39a
PE
5262 * unexaix.c: Port to more-recent AIX compilers.
5263 (report_error, report_error_1, make_hdr, copy_sym)
5264 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5265 Make arguments const char *, not char *, to avoid violations of C
5266 standard and to fix some AIX warnings reported by Gilles Pion.
5267
e18afed7 52682012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5269
5270 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5271 already have overlays loaded.
5272 (handle_single_display_spec): Before returning without displaying
5273 fringe bitmap, synchronize the bidi iterator with the main display
5274 iterator, by calling iterate_out_of_display_property.
5275 (iterate_out_of_display_property): Detect buffer iteration by
5276 testing that it->string is a Lisp string.
5277 (get_next_display_element): When the current object is exhausted,
5278 and there's something on it->stack, call set_iterator_to_next to
5279 proceed with what's on the stack, instead of returning zero.
5280 (set_iterator_to_next): If called at the end of a Lisp string,
5281 proceed to consider_string_end without incrementing string
5282 position. Don't increment display vector index past the end of
5283 the display vector. (Bug#11417)
c8fb9dc6
EZ
5284 (pos_visible_p): Don't report a position visible when move_it_to
5285 stopped at the last line of window, which happens to be scanned
5286 backwards by the bidi iteration. (Bug#11464)
ac268e67 5287
e18afed7 52882012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5289
5290 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5291 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5292 are on a TTY, and thus unable to display on the fringes.
5293 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5294 so we need to signal to the caller that this is a "replacing"
5295 display spec. This fixes display when the spec is invalid or we
5296 are on a TTY.
5297
e18afed7 52982012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5299
5300 * unexaix.c (make_hdr): Fix typo in prototype.
5301 This bug broke the build on AIX. Problem reported by Gilles Pion.
5302
9d0a235a
MA
53032012-05-14 Michael Albinus <michael.albinus@gmx.de>
5304
5305 * keyboard.c (kbd_buffer_get_event): Read special events also in
5306 batch mode. (Bug#11415)
5307
9e6b06ed
GM
53082012-05-12 Glenn Morris <rgm@gnu.org>
5309
5310 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5311
c1a1d7a3
EZ
53122012-05-12 Eli Zaretskii <eliz@gnu.org>
5313
5314 * lisp.mk (lisp): Add newcomment.elc.
5315
3fe7cdc8
GM
53162012-05-12 Glenn Morris <rgm@gnu.org>
5317
5318 * Makefile.in (MKDIR_P): New, set by configure.
5319 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5320
53f7d2c0
PE
53212012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5322
5323 Remove unused function hourglass_started.
5324 * dispextern.h (hourglass_started):
5325 * w32fns.c (hourglass_started):
5326 * xdisp.c (hourglass_started): Remove.
5327
75aafb17
JB
53282012-05-10 Juanma Barranquero <lekktu@gmail.com>
5329
5330 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5331 Update dependencies.
5332
12959e8e
PE
53332012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5334
97107e2e
PE
5335 * xgselect.c (xg_select): Put maxfds+1 into a var.
5336 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5337
12959e8e
PE
5338 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5339
836d29b3
DA
53402012-05-10 Dave Abrahams <dave@boostpro.com>
5341
5342 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5343 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5344
5cb67954
MA
53452012-05-09 Michael Albinus <michael.albinus@gmx.de>
5346
5347 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5348 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5349 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5350 Initialize xd_registered_buses.
5351
3478ec45
PE
53522012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5353
b263a6b0
PE
5354 Untag more efficiently if USE_LSB_TAG.
5355 This is based on a proposal by YAMAMOTO Mitsuharu in
5356 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5357 For an admittedly artificial (nth 8000 longlist) benchmark on
5358 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5359 Emacs's overall text size by 1%.
5360 * lisp.h (XUNTAG): New macro.
5361 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5362 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5363 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5364 * eval.c (Fautoload):
5365 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5366 * frame.h (XFRAME): Use XUNTAG.
5367
3478ec45
PE
5368 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5369 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5370 Remove unportable assumptions about print widths of types like
5371 dbus_uint32_t.
5372 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5373 intptr_t when converting between pointer and integer, to avoid GCC
5374 warnings about wrong width.
5375
666b903b 53762012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5377
5378 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5379 stack for each reader_thread, instead of defaulting to 8MB
5380 determined by the linker. This avoids failures in creating
5381 subprocesses on Windows 7, see the discussion in this thread:
5382 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5383
b120cc17
JC
53842012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5385
5386 Fix up display of the *Minibuf-0* buffer in the mini window.
5387 * keyboard.c (read_char): Don't clear the echo area if there's no
5388 message to clear.
5389 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5390 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5391
9a4b36f8
MA
53922012-05-07 Michael Albinus <michael.albinus@gmx.de>
5393
5394 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5395 batch mode.
5396
e5f9458f
CY
53972012-05-06 Chong Yidong <cyd@gnu.org>
5398
5399 * lisp.mk (lisp): Update.
5400
eceeb5fc 54012012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5402
5403 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5404
71873e2b
SM
54052012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5406
5407 * data.c (PUT_ERROR): New macro.
5408 (syms_of_data): Use it. Add new error type `user-error'.
5409 * undo.c (user_error): New function.
5410 (Fprimitive_undo): Use it.
5411 * print.c (print_error_message): Adjust print style for `user-error'.
5412 * keyboard.c (user_error): New function.
5413 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5414
ab0fa4e4
PE
54152012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5416
5417 Do not limit current-time-string to years 1000..9999.
5418 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5419 (Fcurrent_time_string): Support any year that is supported by the
5420 underlying localtime representation. Don't use asctime, as it
5421 has undefined behavior for years outside the range -999..9999.
5422
7ed806a7
PE
54232012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5424
5425 Fix race conditions involving setenv, gmtime, localtime, asctime.
5426 Without this fix, interrupts could mess up code that uses these
5427 nonreentrant functions, since setting TZ invalidates existing
5428 tm_zone or tzname values, and since most of these functions return
5429 pointers to static storage.
5430 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5431 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5432 Grow the critical sections to include not just invoking
5433 localtime/gmtime, but also accessing these functions' results
5434 including their tm_zone values if any, and any related TZ setting.
5435 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5436 so that the struct tm is saved in the critical section.
5437 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5438 motivated by the fact that memory allocation needs to be outside
5439 the critical section.
5440
0c16dfed
DA
54412012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5442
5443 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5444 with RESET_INTERVAL.
5445
5446 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5447 Remove duplicated buffer name initialization.
5448
3f83ace8
JM
54492012-05-02 Jim Meyering <jim@meyering.net>
5450
5451 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5452
c7b8541e
JM
5453 * xfns.c (x_window): Use xstrdup (Bug#11375).
5454
90207a15 54552012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5456
5457 * xdisp.c (pos_visible_p): If already at a newline from the
5458 display string before the 'while' loop, don't walk back the glyphs
5459 from it3.glyph_row. Solves assertion violation when the display
5460 string begins with a newline (egg.el). (Bug#11367)
5461
b593d6a9
AH
54622012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5463
5464 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5465 Move to simple.el.
5466
4737362e
GM
54672012-05-01 Glenn Morris <rgm@gnu.org>
5468
99cf43f9
GM
5469 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5470 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5471 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5472 All were removed before 23.1.
5473
9311dcff
GM
5474 * dispnew.c: Remove HAVE_LIBNCURSES test;
5475 it is always true on relevant platforms.
5476
4d5c6349
GM
5477 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5478 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5479
4737362e
GM
5480 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5481
74dd3a6b
AS
54822012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5483
5484 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5485 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5486 Remove.
5487
13c379ee
PE
54882012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5489
5490 Do not avoid creating empty evaporating overlays (Bug#9642).
5491 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5492 That is, do not delete an evaporating overlay if it becomes
5493 empty after its bounds are adjusted to fit within its buffer.
5494 This fix caused other problems, and I'm reverting it until we get
5495 to the bottom of them.
5496
a8e7d6d7 54972012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5498
5499 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5500
a8e7d6d7 55012012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5502
5503 * xdisp.c (pos_visible_p): If the window start position is beyond
5504 ZV, start the display from buffer beginning. Prevents assertion
5505 violation in init_iterator when the minibuffer window is scrolled
5506 via the scroll bar.
5507
5508 * window.c (window_scroll_pixel_based): Likewise.
5509
a8e7d6d7 55102012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5511
5512 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5513
a8e7d6d7 55142012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5515
5516 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5517 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5518
a8e7d6d7 55192012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5520
b593d6a9
AH
5521 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5522 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5523
1c6900d9
EZ
55242012-04-26 Eli Zaretskii <eliz@gnu.org>
5525
4c3fa1d9
EZ
5526 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5527 display element, check also the underlying string or buffer
5528 character. (Bug#11341)
5529
1c6900d9
EZ
5530 * w32menu.c: Include w32heap.h.
5531 (add_menu_item): If the call to AppendMenuW (via
5532 unicode_append_menu) fails, disable Unicode menus only if we are
5533 running on Windows 9X/Me.
5534
42bf8205
AS
55352012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5536
5537 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5538 (xgetint): Add missing shift for LSB tags.
5539
b1bac16e
MR
55402012-04-24 Martin Rudalics <rudalics@gmx.at>
5541
5542 * keyboard.c (read_char): Don't wipe echo area for select window
5543 events: These might get delayed via `mouse-autoselect-window'
5544 (Bug#11304).
5545
d69621cc
JB
55462012-04-24 Juanma Barranquero <lekktu@gmail.com>
5547
5548 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5549 manipulation of :loaded-from data.
5550
02fd101b
JB
55512012-04-23 Juanma Barranquero <lekktu@gmail.com>
5552
5553 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5554 now a cons (bug#11311).
5555
888bec30
PE
55562012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5557
89a438bd
PE
5558 Do not create empty overlays with the evaporate property (Bug#9642).
5559 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5560 if it becomes empty after its bounds are adjusted to fit within
5561 its buffer. Without this fix, in a nonempty buffer (let ((o
5562 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5563 yields an empty overlay that has the evaporate property, which is
5564 not supposed to happen.
5565
1068fe4d
PE
5566 Fix minor GTK3 problems found by static checking.
5567 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5568 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5569 (struct _EmacsFixedClass, emacs_fixed_get_type):
5570 Move decls here from emacsgtkfixed.h, since they needn't be public.
5571 (emacs_fixed_get_type): Now static.
5572 (emacs_fixed_class_init): Omit unused local.
5573 (emacs_fixed_child_type): Remove; unused.
5574 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5575 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5576 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5577 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5578 (EMACS_FIXED_GET_CLASS): Remove; unused.
5579 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5580
888bec30
PE
5581 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5582 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5583
de85e130
PE
55842012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5585
d0baac98 5586 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5587 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5588 (__malloc_size_t, __malloc_ptrdiff_t):
5589 Remove. All uses removed, replaced by the definiens if needed,
5590 since we can assume C89 or better now.
5591 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5592 (protect_malloc_state, align, get_contiguous_space)
5593 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5594 (malloc_atfork_handler_child, malloc_enable_thread)
5595 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5596 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5597 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5598 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5599 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5600 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5601 Define using prototypes, not old style.
5602 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5603 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5604 (align): Don't assume that signed integer overflow wraps around.
5605 Omit unused local var.
5606 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5607 (_free_internal_nolock, memalign, mallochook, reallochook):
5608 Omit no-longer-needed casts.
5609 (valloc): Use getpagesize, not __getpagesize.
5610 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5611 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5612
de85e130
PE
5613 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5614
dcbf5805
MA
56152012-04-22 Michael Albinus <michael.albinus@gmx.de>
5616
5617 Move functions from C to Lisp. Make non-blocking method calls
5618 the default. Implement further D-Bus standard interfaces.
5619
5620 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5621 (QCdbus_request_name_allow_replacement)
5622 (QCdbus_request_name_replace_existing)
5623 (QCdbus_request_name_do_not_queue)
5624 (QCdbus_request_name_reply_primary_owner)
5625 (QCdbus_request_name_reply_in_queue)
5626 (QCdbus_request_name_reply_exists)
5627 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5628 (QCdbus_registered_serial, QCdbus_registered_method)
5629 (QCdbus_registered_signal): New Lisp objects.
5630 (XD_DEBUG_MESSAGE): Use sizeof.
5631 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5632 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5633 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5634 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5635 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5636 (xd_signature, xd_append_arg): Allow float for integer types.
5637 (xd_get_connection_references): New function.
b593d6a9
AH
5638 (xd_get_connection_address): Rename from xd_initialize.
5639 Return cached address.
dcbf5805
MA
5640 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5641 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5642 level.
5643 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5644 Return number of refcounts.
dcbf5805
MA
5645 (Fdbus_get_unique_name): Make stronger parameter check.
5646 (Fdbus_message_internal): New defun.
5647 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5648 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5649 (Fdbus_send_signal, Fdbus_register_service)
5650 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5651 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5652 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5653 (Vdbus_compiled_version, Vdbus_runtime_version)
5654 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5655 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5656 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5657 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5658 Adapt docstring.
dcbf5805 5659
52828e02
PE
56602012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5661
da05bc4c
PE
5662 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5663 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5664 Do not assume ptrdiff_t is the same width as 'int'.
5665
52828e02
PE
5666 * alloc.c: Handle unusual debugging option combinations.
5667 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5668 since the two debugging options are incompatible.
5669 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5670 is defined.
5671 (mem_init, mem_insert, mem_insert_fixup):
5672 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5673 (NEED_MEM_INSERT): Remove; no longer needed.
5674
f01769f9
LL
56752012-04-22 Leo Liu <sdl.web@gmail.com>
5676
5677 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5678
5790543d
PE
56792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5680
5681 * sysdep.c [__FreeBSD__]: Minor cleanups.
5682 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5683 Use Emacs indenting style more consistently. Avoid some casts.
5684 Use 'double' consistently rather than mixing 'float' and 'double'.
5685
b91b7e4d
EW
56862012-04-21 Eduard Wiebe <usenet@pusto.de>
5687
b593d6a9
AH
5688 * sysdep.c (list_system_processes, system_process_attributes):
5689 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5690
6114eb15
AS
56912012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5692
5693 * lisp.mk (lisp): Update.
5694
2f38dff7
PE
56952012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5696
5697 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5698 It is never used otherwise.
5699
4ae29f89
SM
57002012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5701
5702 * print.c (print_preprocess): Only check print_depth if print-circle
5703 is nil.
5704 (print_object): Check for cycles even when print-circle is nil and
5705 print-gensym is t, but only check print_depth if print-circle is nil.
5706
f30d612a
CY
57072012-04-20 Chong Yidong <cyd@gnu.org>
5708
5709 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5710 set the status to "failed" and ensure that sentinel is run.
5711
c07a4c0b 57122012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5713
5714 * process.c (Fset_process_inherit_coding_system_flag)
5715 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5716 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5717
c07a4c0b 57182012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5719
5720 * xdisp.c (string_buffer_position_lim): Limit starting position to
5721 BEGV.
5722 (set_cursor_from_row): If called for a mode-line or header-line
5723 row, return zero immediately.
5724 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5725 farther than the first row after the header line, if any.
5726 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5727 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5728
c07a4c0b 57292012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5730
4ae29f89
SM
5731 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5732 (bug#11238).
ad3a2b41 5733
c07a4c0b 57342012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 57352012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5736
5737 configure: new option --enable-gcc-warnings (Bug#11207)
5738 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5739 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5740 (ALL_CFLAGS): Use new macros rather than old.
5741 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5742 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5743 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5744 -Wunused-result, -Wunused-variable. This should go away once
5745 the Emacs and Gnulib regex code is merged.
5746 (xmalloc, xrealloc): Now static.
5747
aba027e8
PE
57482012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5749
5750 * dired.c (Fsystem_groups): Remove unused local.
5751
e5a36063
GM
57522012-04-17 Glenn Morris <rgm@gnu.org>
5753
5754 * dired.c (Fsystem_users): Doc fix.
5755
316411f0
DA
57562012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5757
5758 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5759 (syms_of_dired): Add them.
5760
9426aba4
PE
57612012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5762
b62a57be
PE
5763 Fix minor alloc.c problems found by static checking.
5764 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5765 New extern decls, to avoid calling undeclared functions.
5766 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5767 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5768 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5769 (NEED_MEM_INSERT): New macro.
5770 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5771 Remove one incorrect comment and fix another.
b62a57be 5772
3539f31f
PE
5773 Fix minor ralloc.c problems found by static checking.
5774 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5775 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5776 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5777 (r_alloc_sbrk): Now static.
5778
a041960a
PE
5779 Improve ralloc.c interface checking.
5780 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5781 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5782 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5783 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5784 [REL_ALLOC]: ... to here, to check interface.
5785 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5786 Remove decls. This fixes an "It stinks!".
5787
9426aba4
PE
5788 * alloc.c (which_symbols): Fix alignment issue / type clash.
5789
d55c12ed
AS
57902012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5791
5792 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5793 (struct Lisp_Misc_Any): Likewise.
5794 (struct Lisp_Free): Likewise.
5795 * alloc.c (union aligned_Lisp_Symbol): Define.
5796 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5797 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5798 (union aligned_Lisp_Misc): Define.
5799 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5800 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5801 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5802
b948ce8b
PE
58032012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5804
5805 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5806 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5807 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5808 * s/netbsd.h, s/sol2-6.h:
5809 Remove definition of GC_MARK_STACK, since the default now works.
5810 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5811 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5812 no longer the default.
5813 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5814
35dc09a1 58152012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5816
35dc09a1
GM
5817 * lread.c (lisp_file_lexically_bound_p):
5818 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5819
35dc09a1
GM
58202012-04-14 Eli Zaretskii <eliz@gnu.org>
5821
5822 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5823 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5824
58252012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5826
5827 * nsterm.m (constrainFrameRect): Always constrain when there is only
5828 one screen (Bug#10962).
5829
bcd86815
KB
58302012-04-13 Ken Brown <kbrown@cornell.edu>
5831
5832 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5833
c25df26e
RT
58342012-04-13 Reuben Thomas <rrt@sc3d.org>
5835
5836 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5837
0fc59f1e
DC
58382012-04-11 Daniel Colascione <dancol@dancol.org>
5839
5840 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5841 against is gone. It's better to use vfork now so that when Cygwin
5842 gains a new, working vfork, we use it automatically (bug#10398).
5843
de8c03dc
SM
58442012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5845
5846 * window.c (save_window_save): Obey window-point-insertion-type.
5847
2f097256
GM
58482012-04-11 Glenn Morris <rgm@gnu.org>
5849
5850 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5851
453b951e
SM
58522012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5853
5854 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5855
75f1671a 58562012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5857
5858 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5859 (force_quit_count): New var.
5860 (handle_interrupt): Use it.
5861
2a8ce227
JB
58622012-04-10 Juanma Barranquero <lekktu@gmail.com>
5863
5864 * w32.c (w32_delayed_load): Record the full path of the library
5865 being loaded (bug#10424).
5866
935396c0
GM
58672012-04-09 Glenn Morris <rgm@gnu.org>
5868
05920a43
GM
5869 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5870 not just in the obarray, before snarfing them. (Bug#11036)
5871
935396c0
GM
5872 * Makefile.in ($(leimdir)/leim-list.el):
5873 Pass EMACS rather than BUILT_EMACS.
5874
a18ecafa
TZ
58752012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5876
5877 * process.c (make_process):
5878 * process.h: Add integer `gnutls_handshakes_tried' member to
5879 process struct.
5880
6bbef4e5
JC
5881 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5882 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5883
5884 * gnutls.c (gnutls_log_function2i): Convenience log function.
5885 (emacs_gnutls_read): Use new log functions,
5886 `gnutls_handshakes_tried' process member, and
5887 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5888 attempts per process (connection).
5889
b4d3bc10
CY
58902012-04-09 Chong Yidong <cyd@gnu.org>
5891
5892 * eval.c (Fuser_variable_p, user_variable_p_eh)
5893 (lisp_indirect_variable): Functions deleted.
5894 (Fdefvar): Caller changed.
5895
5896 * callint.c (Finteractive, Fcall_interactively):
5897 * minibuf.c (Fread_variable): Callers changed.
5898
70f4d973
EZ
58992012-04-09 Eli Zaretskii <eliz@gnu.org>
5900
5901 * xdisp.c (set_cursor_from_row): If the display string appears in
5902 the buffer at position that is closer to point than the position
5903 after the display string, display the cursor on the first glyph of
5904 the display string. Fixes cursor display when a 'display' text
5905 property immediately follows invisible text. (Bug#11094)
5906
cb3c2e3e
PE
59072012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5908
5909 composite.c: use 'double' consistently
5910 * composite.c (get_composition_id): Use 'double' consistently
5911 instead of converting 'float' to 'double' and vice versa; this is
5912 easier to understand and avoids a GCC warning.
5913
fd06db5d
GM
59142012-04-09 Glenn Morris <rgm@gnu.org>
5915
50fe702a
GM
5916 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5917 preparation for dumping it with emacs. (Bug#4789)
5918 (leimdir): New variable.
5919 ($(leimdir)/leim-list.el): New rule.
5920 (emacs$(EXEEXT)): Depend on leim-list.el.
5921
fd06db5d
GM
5922 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5923 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5924 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5925
55c131ee
AS
59262012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5927
5928 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5929 proper alignment.
5930
9209588f
JB
59312012-04-07 Juanma Barranquero <lekktu@gmail.com>
5932
5933 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5934 Remove unused local variable.
5935
e3fb2efb
PE
59362012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5937
5938 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5939 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5940 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5941 objects, as mark_maybe_pointer will catch them otherwise.
5942 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5943 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5944
b5385551
PE
59452012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5946
5947 Fix typo that broke non-Windows builds.
5948 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5949
9078ead6
EZ
59502012-04-07 Eli Zaretskii <eliz@gnu.org>
5951
5952 Support building on MS-Windows with libxml2.
5953
5954 * makefile.w32-in (OBJ2): Add xml.$(O).
5955 (GLOBAL_SOURCES): Add xml.c.
5956 ($(BLD)/xml.$(O)): New dependency list.
5957
5958 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5959 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5960 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5961 [!WINDOWSNT]: New macros.
5962 (init_libxml2_functions, libxml2_loaded_p): New functions.
5963 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5964 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5965 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5966 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5967 linked in).
6bbef4e5
JC
5968 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5969 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5970 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5971
5972 * emacs.c: Don't include libxml/parser.h.
5973 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5974 xmlCleanupParser directly.
5975
5976 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5977
3811fdf3
EZ
59782012-04-07 Eli Zaretskii <eliz@gnu.org>
5979
5980 * indent.c (Fvertical_motion): If there is a display string at
5981 point, use it.vpos to compute how many lines to backtrack after
5982 move_it_to point. (Bug#11133)
5983
2f8e16b2
EZ
59842012-04-06 Eli Zaretskii <eliz@gnu.org>
5985
5986 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5987 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5988 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5989 macros related to unification of CJK characters. For the details,
5990 see the discussion following the message here:
5991 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5992
3d439cd1
CY
59932012-04-04 Chong Yidong <cyd@gnu.org>
5994
5995 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5996
8bc53d00
EZ
59972012-04-01 Eli Zaretskii <eliz@gnu.org>
5998
5999 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
6000 instead of alloca. (Bug#11138)
6001
3b0512a3
AS
60022012-04-01 Andreas Schwab <schwab@linux-m68k.org>
6003
6004 * w32menu.c (is_simple_dialog): Properly check lisp types.
6005 (Bug#11141)
6006
8427ddd2
EZ
60072012-03-31 Eli Zaretskii <eliz@gnu.org>
6008
979022ef
EZ
6009 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
6010 position we get to after a call to move_it_to fails the
6011 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
6012 only if we wind up in a string from display property. (Bug#11063)
6013
a6b1c7cc
EZ
6014 * window.c (Fdelete_other_windows_internal): Invalidate the row
6015 and column information about mouse highlight, so that redisplay
6016 restores it after reallocating the glyph matrices. (Bug#7464)
6017
8427ddd2
EZ
6018 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
6019 string comes from a `display' text property, use the buffer
6020 position of that property as if we actually saw that position in
6021 the row's glyphs.
697ba24b
EZ
6022 (move_it_by_lines): Remove the assertion that
6023 "it->current_x == 0 && it->hpos == 0" which can be legitimately
6024 violated when there's a before-string at the beginning of a line.
6025 (Bug#11063)
8427ddd2 6026
65a0a738
EZ
60272012-03-30 Eli Zaretskii <eliz@gnu.org>
6028
6029 * xdisp.c (append_space_for_newline): If the default face was
6030 remapped, use the remapped face for the appended newline.
6031 (extend_face_to_end_of_line): Use the remapped default face for
6032 extending the face to the end of the line.
6033 (display_line): Call extend_face_to_end_of_line when the default
6034 face was remapped. (Bug#11068)
6035
581355cc
EZ
60362012-03-29 Eli Zaretskii <eliz@gnu.org>
6037
6038 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
6039
e8fc049f
SM
60402012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6041
6042 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
6043
4fb9a543
GM
60442012-03-27 Glenn Morris <rgm@gnu.org>
6045
6046 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
6047 Doc fixes.
6048
679910f1
KH
60492012-03-26 Kenichi Handa <handa@m17n.org>
6050
6051 * dispextern.h (struct glyph): Fix previous change. Change the
6052 bit length of glyphless.ch to 25 (Bug#11082).
6053
90d49b7f
CY
60542012-03-26 Chong Yidong <cyd@gnu.org>
6055
6056 * keyboard.c (Vselection_inhibit_update_commands): New variable.
6057 (command_loop_1): Use it; inhibit selection update for
6058 handle-select-window too (Bug#8996).
6059
f514f6f0
FP
60602012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
6061
e8fc049f 6062 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 6063
bf43fa51
KH
60642012-03-25 Kenichi Handa <handa@m17n.org>
6065
6066 * dispextern.h (struct glyph): Change the bit length of
6067 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
6068
8a0c01dd
EZ
60692012-03-24 Eli Zaretskii <eliz@gnu.org>
6070
6071 * s/ms-w32.h (tzname): Include time.h before redirecting to
6072 _tzname. Fixes the MSVC build. (Bug#9960)
6073
7d1c3a76
AS
60742012-03-24 Andreas Schwab <schwab@linux-m68k.org>
6075
8ed79523
AS
6076 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
6077 characters.
6078
7d1c3a76
AS
6079 * xterm.c (XTread_socket): Only modify handling_signal if
6080 !SYNC_INPUT. (Bug#11080)
6081
e99a9b8b
EZ
60822012-03-23 Eli Zaretskii <eliz@gnu.org>
6083
6084 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
6085 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
6086 when fetching a multibyte character consumes more bytes than
6087 CHAR_BYTES returns, due to unification of CJK characters in
6088 string_char. (Bug#11073)
6089
5063c0e1
TN
60902012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
6091
6092 * process.c (wait_reading_process_output): Handle pty disconnect
6093 by refraining from sending oneself a SIGCHLD (bug#10933).
6094
9f851fbd
CY
60952012-03-22 Chong Yidong <cyd@gnu.org>
6096
6097 * dispextern.h (struct it): New member string_from_prefix_prop_p.
6098
5063c0e1 6099 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
6100 Mark string as coming from a prefix property.
6101 (handle_face_prop): Use default face for prefix strings (Bug#4281).
6102 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
6103
fb5b8aca
CY
61042012-03-21 Chong Yidong <cyd@gnu.org>
6105
6106 * xfaces.c (Vface_remapping_alist): Doc fix.
6107
62356a1b
EZ
61082012-03-20 Eli Zaretskii <eliz@gnu.org>
6109
6110 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
6111 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
6112 Doc fixes.
62356a1b 6113
025de85b
CY
61142012-03-20 Chong Yidong <cyd@gnu.org>
6115
6116 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
6117 to reflect default non-nil value of redisplay-dont-pause.
6118
4827f94e
KH
61192012-03-19 Kenichi Handa <handa@m17n.org>
6120
6121 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
6122 it fit in a valid range (Bug#11003).
6123
e50a24a2
EZ
61242012-03-18 Eli Zaretskii <eliz@gnu.org>
6125
6126 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
6127 that is not from display property, accept the row as a "cursor
6128 row" if one of the string's character has a non-nil `cursor'
6129 property. Fixes cursor positioning when there are newlines in
6130 overlay strings, e.g. in icomplete.el. (Bug#11035)
6131
9af5ed87
PE
61322012-03-12 Paul Eggert <eggert@cs.ucla.edu>
6133
6134 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
6135
d1f55f16
CY
61362012-03-12 Chong Yidong <cyd@gnu.org>
6137
6138 * eval.c (inhibit_lisp_code): Rename from
6139 inhibit_window_configuration_change_hook; move from window.c.
6140
6141 * xfns.c (unwind_create_frame_1, Fx_create_frame):
6142 * window.c (run_window_configuration_change_hook)
6143 (syms_of_window): Callers changed.
6144
66c5eebd
CY
61452012-03-11 Chong Yidong <cyd@gnu.org>
6146
413df973
CY
6147 * keymap.c (Fkey_description): Doc fix (Bug#9700).
6148
66c5eebd
CY
6149 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
6150
1de11f56
CY
61512012-03-10 Chong Yidong <cyd@gnu.org>
6152
6153 * frame.c (other_visible_frames): Don't assume the selected frame
6154 is visible (Bug#10955).
6155
cae07000
SM
61562012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
6157
6158 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
6159
89c94350
JD
61602012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6161
6162 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
6163 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
6164 zero (Bug#10954).
6165
999dd333
GM
61662012-03-03 Glenn Morris <rgm@gnu.org>
6167
01a6dcc8 6168 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6169
de0100f2
EZ
61702012-03-02 Eli Zaretskii <eliz@gnu.org>
6171
6172 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6173 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6174 (redisplay_window, next_element_from_string): Fix typos in
6175 comments.
3e441275
EZ
6176 (redisplay_window): Pass to move_it_vertically the margin in
6177 pixels, not in screen lines.
de0100f2 6178
96a72ee9
GM
61792012-03-02 Glenn Morris <rgm@gnu.org>
6180
6181 * buffer.c (buffer-list-update-hook): Doc fix.
6182
312508d7
EZ
61832012-02-29 Eli Zaretskii <eliz@gnu.org>
6184
6185 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6186 push_it before setting up the iterator for the first overlay
6187 string, even if we have an empty string loaded.
6188 (next_overlay_string): If there's an empty string on the iterator
6189 stack, pop the stack. (Bug#10903)
6190
27f3c637
PE
61912012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6192
6193 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6194 Suggested by Stefan Monnier in
6195 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6196 * alloc.c (widen_to_Lisp_Object): New static function.
6197 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6198 and widening them to Lisp_Objects. This would work even if
6199 USE_LSB_TAG is defined and wide integers are used, which might
6200 happen in a future version of Emacs.
6201
3c9dfce6
CY
62022012-02-25 Chong Yidong <cyd@gnu.org>
6203
fa74b241
CY
6204 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6205 Doc fix.
6206
3c9dfce6
CY
6207 * xselect.c (Fx_selection_exists_p): Doc fix.
6208 (x_clipboard_manager_save_all): Print an informative message
6209 before saving to clipboard manager.
6210
9486df08
CY
62112012-02-24 Chong Yidong <cyd@gnu.org>
6212
6213 * keyboard.c (process_special_events): Handle all X selection
6214 requests in kbd_buffer, not just the next one (Bug#8869).
6215
f01d3321
CY
62162012-02-23 Chong Yidong <cyd@gnu.org>
6217
6218 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6219 call when setting menu-bar-lines and tool-bar-lines parameters.
6220 (unwind_create_frame_1): New helper function.
6221
6222 * window.c (inhibit_window_configuration_change_hook): New var.
6223 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6224 (syms_of_window): Initialize it.
f01d3321 6225
86b847b6
CY
62262012-02-22 Chong Yidong <cyd@gnu.org>
6227
6228 * xterm.c (x_draw_image_relief): Add missing type check for
6229 Vtool_bar_button_margin (Bug#10743).
6230
a59225b1
CY
62312012-02-21 Chong Yidong <cyd@gnu.org>
6232
6233 * fileio.c (Vfile_name_handler_alist): Doc fix.
6234
6235 * buffer.c (Fget_file_buffer): Protect against invalid file
6236 handler return value.
6237
310f5bd4
PE
62382012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6239
cb3a28cc
PE
6240 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6241 when computing $valmask.
6242
310f5bd4
PE
6243 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6244 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6245 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6246 It's useless in that case, and it can cause problems on hosts
6247 that allocate halves of EMACS_INT values separately.
6248 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6249 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6250 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6251 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6252 it avoids undefined behavior on hosts where shifting right by more
6253 than the word width has undefined behavior.
6254
2375c96a
CY
62552012-02-19 Chong Yidong <cyd@gnu.org>
6256
6257 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6258 (Funhandled_file_name_directory, Ffile_name_as_directory)
6259 (Fdirectory_file_name, Fexpand_file_name)
6260 (Fsubstitute_in_file_name): Protect against invalid file handler
6261 return values (Bug#10845).
6262
3eb49e71
EZ
62632012-02-18 Eli Zaretskii <eliz@gnu.org>
6264
6265 * .gdbinit (pitx): Fix incorrect references to fields of the
6266 iterator stack.
6267
7b926f3f
CY
62682012-02-17 Chong Yidong <cyd@gnu.org>
6269
6270 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6271
11273115
PE
62722012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6273
6274 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6275 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6276
c3a70e2b
CY
62772012-02-15 Chong Yidong <cyd@gnu.org>
6278
6279 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6280 marked as special. Also, starting docstrings with * is obsolete.
6281
0ca43699
AS
62822012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6283
6284 * gnutls.c (emacs_gnutls_write): Fix last change.
6285
2e8f3c56
LI
62862012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6287
6288 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6289 send_process.
6290
af70074f
SM
62912012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6292
6293 * keymap.c (Fsingle_key_description): Handle char ranges.
6294
95986d52
CY
62952012-02-12 Chong Yidong <cyd@gnu.org>
6296
afd83bd1
CY
6297 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6298 as that creates a dangerous corner case.
6299
95986d52
CY
6300 * window.c (Fdelete_window_internal): Invalidate the mouse
6301 highlight (Bug#9904).
6302
bd7da63e
GM
63032012-02-12 Glenn Morris <rgm@gnu.org>
6304
6305 * xselect.c (Fx_own_selection_internal)
6306 (Fx_get_selection_internal, Fx_disown_selection_internal)
6307 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6308 * nsselect.m (Fx_own_selection_internal)
6309 (Fx_disown_selection_internal, Fx_selection_exists_p)
6310 (Fx_selection_owner_p, Fx_get_selection_internal):
6311 Sync docs and argument specs with the xselect.c versions.
6312
77abcbc2
LI
63132012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6314
6315 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6316
90b671e2
EZ
63172012-02-11 Eli Zaretskii <eliz@gnu.org>
6318
1c0ca0b7
EZ
6319 * w32select.c (Fx_selection_exists_p): Sync doc string and
6320 argument list with xselect.c. (Bug#10783)
6321
6322 * w16select.c (Fx_selection_exists_p): Sync doc string and
6323 argument list with xselect.c. (Bug#10783)
90b671e2 6324
49241268
GM
63252012-02-10 Glenn Morris <rgm@gnu.org>
6326
6327 * fns.c (Fsecure_hash): Doc fix.
6328
f998bbe7 63292012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6330
6331 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6332
0992bd9c
CY
63332012-02-07 Chong Yidong <cyd@gnu.org>
6334
6335 * buffer.c (Fbuffer_local_variables)
6336 (buffer_lisp_local_variables): Handle unbound vars correctly;
6337 don't let Qunbound leak into Lisp.
6338
af008560
GM
63392012-02-07 Glenn Morris <rgm@gnu.org>
6340
dd605cc4
GM
6341 * image.c (Fimagemagick_types): Doc fix.
6342
af008560
GM
6343 * image.c (imagemagick-render-type): Change it from a lisp object
6344 to an integer. Move the doc here from the lisp manual.
6345 Treat all values not equal to 0 the same.
6346
1449fa1d
CY
63472012-02-06 Chong Yidong <cyd@gnu.org>
6348
6349 * doc.c (store_function_docstring): Avoid applying docstring of
6350 alias to base function (Bug#2603).
6351
3723ec07
AS
63522012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6353
6354 * .gdbinit (pp1, pv1): Remove redundant defines.
6355 (pr): Use pp.
6356
79c1cc1e
CY
63572012-02-04 Chong Yidong <cyd@gnu.org>
6358
6359 * nsterm.m: Declare a global (Bug#10694).
6360
d7f29f8e
EZ
63612012-02-04 Eli Zaretskii <eliz@gnu.org>
6362
cae07000
SM
6363 * w32.c (get_emacs_configuration_options):
6364 Include --enable-checking, if specified, in the return value.
d7f29f8e 6365
3b95a6f9
MR
63662012-02-04 Martin Rudalics <rudalics@gmx.at>
6367
6368 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6369 after rounding frame sizes. (Bug#9723)
6370
d6fa96a6
EZ
63712012-02-04 Eli Zaretskii <eliz@gnu.org>
6372
6373 * keyboard.c (adjust_point_for_property): Don't position point
6374 before BEGV. (Bug#10696)
6375
df0b2940
PE
63762012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6377
6378 Handle overflow when computing char display width (Bug#9496).
6379 * character.c (char_width): Return EMACS_INT, not int.
6380 (char_width, c_string_width): Check for overflow when
6381 computing the width; this is possible now that individual
6382 characters can have unbounded width. Problem introduced
6383 by merge from Emacs 23 on 2012-01-19.
6384
6bee44d6
MA
63852012-02-02 Michael Albinus <michael.albinus@gmx.de>
6386
6387 * dbusbind.c (Fdbus_register_method): Mention the return value
6388 :ignore in the docstring.
6389
44f92739
GM
63902012-02-02 Glenn Morris <rgm@gnu.org>
6391
1b9f60cc
GM
6392 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6393
44f92739
GM
6394 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6395 Unconditionally set to t. (Bug#10673)
6396 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6397 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6398 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6399
c5d3843c
KH
64002012-02-02 Kenichi Handa <handa@m17n.org>
6401
6402 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6403 0, do not call append_composite_glyph.
6404
159462d4 64052012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6406
6407 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6408 NULL (Bug#6988).
6409 (x_produce_glyphs): If the component of a composition is a null
6410 string, set it->pixel_width to 1 to avoid zero-width glyph.
6411
78cef877
EZ
64122012-02-01 Eli Zaretskii <eliz@gnu.org>
6413
6414 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6415 first 2 arguments are identical. This makes inserting large
6416 output from a subprocess an order of magnitude faster on
6417 MS-Windows, where all sbrk'ed memory is always contiguous.
6418
97897668
GM
64192012-01-31 Glenn Morris <rgm@gnu.org>
6420
6421 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6422 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6423 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6424
31fd3586
GM
64252012-01-29 Glenn Morris <rgm@gnu.org>
6426
6427 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6428
0e24a8b2
CY
64292012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6430
6431 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6432
cc0adcb0
CY
64332012-01-28 Chong Yidong <cyd@gnu.org>
6434
6435 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6436
acc28cb9
CY
64372012-01-26 Chong Yidong <cyd@gnu.org>
6438
9c69cfb7
CY
6439 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6440
acc28cb9
CY
6441 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6442 repeat counts (Bug#10507).
6443
48da7392
GM
64442012-01-26 Glenn Morris <rgm@gnu.org>
6445
6446 * lread.c (syms_of_lread): Doc fix.
6447
14af5f7f
CY
64482012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6449
6450 * coding.c (encode_designation_at_bol): Change return value to
6451 EMACS_INT.
6452
0b21c100
CY
64532012-01-25 Chong Yidong <cyd@gnu.org>
6454
6455 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6456
3c2907f7
CY
64572012-01-21 Chong Yidong <cyd@gnu.org>
6458
6459 * floatfns.c (Fcopysign): Make the second argument non-optional,
6460 since nil is not allowed anyway.
6461
959ad23f
AS
64622012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6463
6464 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6465 (send_process): Likewise.
6466
34a02f46
MR
64672012-01-19 Martin Rudalics <rudalics@gmx.at>
6468
6469 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6470 (Vwindow_persistent_parameters): Do not use Qstate.
6471 Rewrite doc-strings.
34a02f46 6472
1259009a 64732012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6474
6475 * character.c (char_width): New function.
70d4fdf6
GM
6476 (Fchar_width, c_string_width, lisp_string_width):
6477 Use char_width (Bug#9496).
25ed9e61 6478
6a6ee00d
MR
64792012-01-16 Martin Rudalics <rudalics@gmx.at>
6480
6481 * window.c (Vwindow_persistent_parameters): New variable.
6482 (Fset_window_configuration, save_window_save): Handle persistent
6483 window parameters.
6484
c85efaf7
EZ
64852012-01-14 Eli Zaretskii <eliz@gnu.org>
6486
6487 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6488 thrashing the stack of the thread. (Bug#9087)
6489
5944709e
PE
64902012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6491
6492 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6493
e71f5d99
EZ
64942012-01-11 Eli Zaretskii <eliz@gnu.org>
6495
6496 * xdisp.c (rows_from_pos_range): Handle the case where the
6497 highlight ends on a newline. (Bug#10464)
6498 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6499 he end column for display of highlight that ends on a newline
6500 before a R2L line.
6501
ce316182
GM
65022012-01-11 Glenn Morris <rgm@gnu.org>
6503
6504 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6505 from load-path also when installation-directory is nil. (Bug#10208)
6506
5b43da69
GM
65072012-01-10 Glenn Morris <rgm@gnu.org>
6508
74cc8ff9
GM
6509 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6510
7d8d6e4e
GM
6511 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6512 Update template values to be closer to their typical values these days.
5b43da69 6513
a0db8d43
EZ
65142012-01-09 Eli Zaretskii <eliz@gnu.org>
6515
6516 * xdisp.c (rows_from_pos_range): Accept additional argument
6517 DISP_STRING, and accept any glyph in a row whose object is that
6518 string as eligible for mouse highlight. Fixes mouse highlight of
6519 display strings from overlays. (Bug#10464)
6520
9a0115ab 65212012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6522
b9110d6a 6523 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6524 * fileio.c (auto_saving_dir_umask): New static var.
6525 (Fmake_directory_internal): Use it.
6526 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6527 creating the directory. The old code temporarily assigns
6528 too-generous permissions to the directory.
6529 (do_auto_save_eh): Clear it.
b9110d6a 6530 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6531 that the var is always cleared.
6532
6c1bd3f3
EZ
65332012-01-07 Eli Zaretskii <eliz@gnu.org>
6534
6535 * search.c (scan_buffer): Pass character positions to
6536 know_region_cache, not byte positions. (Bug#6540)
6537
069d2b50
L
65382012-01-07 LynX <_LynX@bk.ru> (tiny change)
6539
6540 * w32.c (sys_rename): Report EXDEV when rename of a directory
6541 fails because the target is on another logical disk. (Bug#10284)
6542
75bf0d33
DB
65432012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6544
6545 * xterm.c (x_embed_request_focus): New function.
6546
6547 * xterm.h: Add prototype.
6548
6549 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6550
1c6e5a32
GM
65512012-01-05 Glenn Morris <rgm@gnu.org>
6552
6553 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6554
651e947e
EZ
65552012-01-01 Eli Zaretskii <eliz@gnu.org>
6556
6557 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6558 Load gnutls_transport_set_lowat only if GnuTLS version is below
6559 2.11.1.
6560 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6561 GnuTLS versions below 2.11.1.
6562
3778cdd8
AL
65632011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6564
6565 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6566 to the doc string advising against its use for altering the way
6567 windows are scrolled.
6568
0e5317f7
KH
65692011-12-28 Kenichi Handa <handa@m17n.org>
6570
6571 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6572 coding-system ASCII compatible only when it does not produce BOM
6573 on encoding (Bug#10383).
6574
93d5ca1f
JD
65752011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6576
6577 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6578 can scroll.
6579 (create_and_show_popup_menu): Always use menu_position_func for
6580 Gtk3 (Bug#10361).
6581
ca22b785
AS
65822011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6583
6584 * callint.c (Fcall_interactively): Don't truncate prompt string.
6585
d048e1e6
EZ
65862011-12-23 Eli Zaretskii <eliz@gnu.org>
6587
6588 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6589 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6590 resumed from there (after widening). (Bug#10360)
d048e1e6 6591
5ccaba1f
JD
65922011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6593
6594 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6595
204ee57f
JD
65962011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6597
b81d40f0
JB
6598 * nsterm.m (x_free_frame_resources):
6599 Release f->output_data.ns->miniimage.
204ee57f
JD
6600 (ns_index_color): Fix indentation. Do not retain
6601 color_table->colors[i].
6602
6603 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6604 before returning.
6605
6606 * nsfns.m (x_set_background_color): Assign return value from
6607 ns_index_color to face-background instead of NSColor*.
6608 (ns_implicitly_set_icon_type): Fix indentation.
6609 Change assignment in for loop to comparison.
6610
6611 * emacs.c (ns_pool): New variable.
6612 (main): Assign ns_pool.
6613 (Fkill_emacs): Call ns_release_autorelease_pool.
6614
6615 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6616 autorelease fdesc, release fdAttrs and tdict.
6617 (ns_get_covering_families): Release charset.
6618 (ns_findfonts): Release NSFontDescriptor created with new.
6619 (ns_uni_to_glyphs): Fix indentation.
6620 (setString): Release attrStr before assigning new value.
6621
c803b2b7
JD
66222011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6623
678f4426
JD
6624 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6625 and NS_IMPL_COCOA.
6626 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6627 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6628
cd394be1 66292011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6630
5fecd5fc
JD
6631 * nsterm.m (ns_term_init): Subscribe for notifications
6632 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6633 to method trackingNotification in EmacsMenu.
6634
6635 * nsmenu.m (trackingMenu): New variable.
3771cb17 6636 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6637 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6638 from Aquamacs (Bug#7030).
678f4426
JD
6639
66402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6641
c803b2b7
JD
6642 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6643 (symbol_to_nsstring): Fix indentation.
6644 (ns_symbol_to_pb): New function.
cae07000
SM
6645 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6646 (Fns_rotate_cut_buffers_internal): Remove.
6647 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6648 Fns_store_cut_buffer_internal.
6649 (ns_get_foreign_selection, Fx_own_selection_internal)
6650 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6651 (Fns_get_selection_internal, Fns_store_selection_internal):
6652 Use ns_symbol_to_pb and check if return value is nil.
6653 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6654 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6655 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6656 renamed to Sns_store_selection_internal.
6657 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6658 and remove this function.
6659 (ns_handle_selection_clear): Remove, never used.
6660 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6661 here.
6662
e1b01a3a
KB
66632011-12-17 Ken Brown <kbrown@cornell.edu>
6664
6665 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6666 GID is unknown (Bug#10257).
6667
2adb6e85
PE
66682011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6669
6670 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6671 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6672 which caused a build failure on GNU/Linux IA-64. This problem was
6673 introduced by my 2011-10-07 patch.
6674
d1d7b339
JL
66752011-12-15 Juri Linkov <juri@jurta.org>
6676
6677 * image.c (imagemagick_error): New function. (Bug#10112)
6678 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6679 Use `imagemagick_error' where ImageMagick functions return
6680 `MagickFalse'.
6681 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6682 proper order.
6683
100d5755
KH
66842011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6685
6686 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6687 fill background (Bug#8992).
6688
454592a6
MR
66892011-12-13 Martin Rudalics <rudalics@gmx.at>
6690
6691 * window.c (Vwindow_combination_resize)
6692 (Vwindow_combination_limit): Use t instead of non-nil in
6693 doc-strings.
61d4b438
MR
6694 (Vrecenter_redisplay): Add first sentence of doc-string on
6695 separate line.
53524d93 6696 (Frecenter): Fix doc-string typo.
454592a6 6697
3633e3aa
KH
66982011-12-11 Kenichi Handa <handa@m17n.org>
6699
6700 * coding.c (Funencodable_char_position): Pay attention to the
6701 buffer text relocation (Bug#9389).
6702
7b9d523a 67032011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6704
7b9d523a
JD
6705 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6706 gtk_init (Bug#10100).
6707
b73189c6
EZ
67082011-12-10 Eli Zaretskii <eliz@gnu.org>
6709
6710 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6711 IT->string is nil. (Bug#10263)
6712
f7dfe5d6
JD
67132011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6714
83faebb4
JD
6715 * nsterm.h (x_free_frame_resources): Declare.
6716
f7dfe5d6
JD
6717 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6718 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6719
6720 * nsterm.h (ns_get_defaults_value): Declare.
6721
6722 * nsterm.m (ns_default): Call ns_get_defaults_value.
6723
7cd4e72c
EZ
67242011-12-09 Eli Zaretskii <eliz@gnu.org>
6725
6726 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6727 (Bug#10170)
6728
b34d7317
YM
67292011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6730
6731 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6732 that where the value of an _OBJC_* symbol points to is in the .bss
6733 section (Bug#10240).
6734
76470ad1
KH
67352011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6736
6737 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6738 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6739
745fff94
KH
67402011-12-08 Kenichi Handa <handa@m17n.org>
6741
6742 * ftfont.c (get_adstyle_property): Fix previous change
6743 (Bug#10233).
6744
6e44397c
JB
67452011-12-07 Juanma Barranquero <lekktu@gmail.com>
6746
6747 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6748 dirs from the default value of EMACSLOADPATH (bug#10208).
6749
7efa6272
GM
67502011-12-07 Glenn Morris <rgm@gnu.org>
6751
6752 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6753 installation and source directories as well. (Bug#10208)
6754
f6fc4d87
CY
67552011-12-06 Chong Yidong <cyd@gnu.org>
6756
6757 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6758
2bf26180
GM
67592011-12-06 Glenn Morris <rgm@gnu.org>
6760
6761 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6762 as an error, not just -1. (Bug#10217)
6763
3a6ad4f0
CY
67642011-12-05 Chong Yidong <cyd@gnu.org>
6765
6766 * keyboard.c (process_special_events): New function.
6767 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6768
75a3b399
PE
67692011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6770
6771 * coding.c (encode_designation_at_bol): Don't use uninitialized
6772 local variable (Bug#9318).
6773
c3c9e25e
KH
67742011-12-05 Kenichi Handa <handa@m17n.org>
6775
6776 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6777 return Qnil (Bug#8046, Bug#10193).
6778
5eb05ea3
KH
67792011-12-05 Kenichi Handa <handa@m17n.org>
6780
6781 * coding.c (encode_designation_at_bol): New args charbuf_end and
6782 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6783 (coding_set_source): Return how many bytes coding->source was
6784 relocated.
6785 (coding_set_destination): Return how many bytes
6786 coding->destination was relocated.
6787 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6788 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6789
67902011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6791
6792 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6793 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6794 macro (Bug#9318).
6795
67962011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6797
6798 The following changes are to fix Bug#9318.
6799
a79703f5 6800 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6801 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6802 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6803 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6804
7dbda6df
JB
68052011-12-05 Juanma Barranquero <lekktu@gmail.com>
6806
6807 * lisp.h (process_quit_flag): Fix external declaration.
6808
6d5eb5b0
SM
68092011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6810
6811 Don't macro-inline non-performance-critical code.
6812 * eval.c (process_quit_flag): New function.
6813 * lisp.h (QUIT): Use it.
6814
a0c3fad0
JD
68152011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6816
6817 * nsfns.m (get_geometry_from_preferences): New function.
6818 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6819
6c07aac2
AS
68202011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6821
6822 * emacs.c (Qkill_emacs): Define.
6823 (syms_of_emacs): Initialize it.
6824 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6825 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6826 (quit_throw_to_read_char): Add parameter `from_signal'.
6827 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6828 * lisp.h (QUIT): Call Fkill_emacs if requested.
6829
c052ead4
JD
68302011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6831
6832 * widget.c (update_wm_hints): Return if wmshell is null.
6833 (widget_update_wm_size_hints): New function.
6834
6835 * widget.h (widget_update_wm_size_hints): Declare.
6836
6837 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6838 widget_update_wm_size_hints (Bug#10104).
6839
9e49252b
EZ
68402011-12-03 Eli Zaretskii <eliz@gnu.org>
6841
6842 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6843 before a newline, prepare the bidi iterator for consuming the
6844 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6845 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6846
02b16839
JL
68472011-12-02 Juri Linkov <juri@jurta.org>
6848
6849 * search.c (Fword_search_regexp): New Lisp function created from
6850 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6851 (Fword_search_backward, Fword_search_forward)
6852 (Fword_search_backward_lax, Fword_search_forward_lax):
6853 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6854 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6855
0068070e
SM
68562011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6857
6858 * fileio.c (Finsert_file_contents): Move after-change-function call
6859 to before the "handled:" label, since all "goto handled" appear in
6860 cases where the *-change-functions have already been properly called
6861 (bug#10117).
6862
3360a3fc
AS
68632011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6864
6865 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6866 waiting for input. (Bug#10169)
6867
73d6c093
EZ
68682011-11-30 Eli Zaretskii <eliz@gnu.org>
6869
6870 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6871 verifies glyph row's hash code--we have just reallocated the
6872 glyphs, so their contents can be complete garbage. (Bug#10164)
6873
febe6bea
JB
68742011-11-30 Juanma Barranquero <lekktu@gmail.com>
6875
6876 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6877
801a4313
EZ
68782011-11-30 Eli Zaretskii <eliz@gnu.org>
6879
6880 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6881 attributes are tested _before_ calling verify_row_hash, to protect
6882 against GCC re-ordering of the tests. (Bug#10164)
6883
2b56b87e
JD
68842011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6885
6886 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6887
6888 * xterm.c (handle_one_xevent): Only set async_visible and friends
6889 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6890 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6891 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6892
dbf31225
PE
68932011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6894
6895 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6896 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6897 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6898 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6899 All uses changed to use GCPRO1 etc.
6900 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6901 Revert to old implementation (i.e., before 2011-03-11).
6902
1305621b
YM
69032011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6904
6905 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6906 of scroll runs so as to avoid assigning disabled bogus rows and
6907 unnecessary graphics copy operations.
6908
8c9afb46
EZ
69092011-11-27 Eli Zaretskii <eliz@gnu.org>
6910
6911 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6912 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6913 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6914 (malloc, free, realloc, calloc): Redirect to e_* only when
6915 compiling Emacs.
6916
6917 * lisp.h (GCTYPEBITS): Move before first use.
6918 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6919 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6920 this macro definition.
6921
6922 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6923 _MSC_VER.
6924
54e9e3bf
JD
69252011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6926
6d5eb5b0
SM
6927 * gtkutil.c (xg_create_frame_widgets):
6928 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6929 present with Gtk+ 2.0.
6930
83aca1cb
PE
69312011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6932
6933 * fileio.c (Finsert_file_contents): Undo previous change; see
6934 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6935
5b76caa4
PE
69362011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6937
6938 Rename locals to avoid shadowing.
6939 * fileio.c (Finsert_file_contents):
6940 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6941 * process.c (wait_reading_process_output):
6942 Rename inner 'proc' to 'p' to avoid shadowing.
6943 Indent for consistency with usual Emacs style.
6944
8c535114
EZ
69452011-11-25 Eli Zaretskii <eliz@gnu.org>
6946
6947 * xdisp.c (redisplay_window): If cursor row is not fully visible
6948 after recentering, and scroll-conservatively is set to a large
6949 number, scroll window by a few more lines to make the cursor fully
6950 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6951 (start_display): Don't move to the next line if the display should
6952 start at a newline that is part of a display vector or an overlay
6953 string. (Bug#10119)
8c535114 6954
fa4fdb5c
JL
69552011-11-24 Juri Linkov <juri@jurta.org>
6956
6957 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6958 after the `MagickPingImage' call. (Bug#10112)
6959
90ec88df
CY
69602011-11-23 Chong Yidong <cyd@gnu.org>
6961
6962 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6963
56e2e794
MR
69642011-11-23 Martin Rudalics <rudalics@gmx.at>
6965
6966 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6967 making another buffer current. (Bug#10114)
6968
b6e64c41
GM
69692011-11-23 Glenn Morris <rgm@gnu.org>
6970
6971 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6972
6b21de18
CY
69732011-11-23 Chong Yidong <cyd@gnu.org>
6974
6975 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6976 using it (Bug#5984).
6977
b12cd789
EZ
69782011-11-22 Eli Zaretskii <eliz@gnu.org>
6979
6980 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6981 and header-lines, as they don't have one computed for them.
6982 (Bug#10098)
6983
6984 * .gdbinit (prow): Make displayed values more self-explaining.
6985 Add row's hash code.
6986
261b6fd4
LMI
69872011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6988
6989 * process.c (wait_reading_process_output): Fix asynchrounous
6990 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6991 (wait_reading_process_output): Add comment and URL.
261b6fd4 6992
e7cfd277
JD
69932011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6994
6995 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6996
a9b9b7f5
CY
69972011-11-21 Chong Yidong <cyd@gnu.org>
6998
6999 * window.c (Fnext_window, Fprevious_window): Doc fix.
7000
b0d15b4f
SM
70012011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7002
7003 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
7004
fe7a3057
JB
70052011-11-20 Juanma Barranquero <lekktu@gmail.com>
7006
7007 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
7008
d2999b1a
MR
70092011-11-20 Martin Rudalics <rudalics@gmx.at>
7010
7011 * window.c (Fset_window_combination_limit): Rename argument
7012 STATUS to LIMIT.
7013 (Vwindow_combination_limit): Remove "status" from doc-string.
7014
d5ff9cd0
AS
70152011-11-20 Andreas Schwab <schwab@linux-m68k.org>
7016
7017 * m/ibms390.h: Remove.
7018 * m/ibms390x.h: Don't include "ibms390.h".
7019
a5bb9bd3
SM
70202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7021
7022 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
7023 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
7024
cd1181db
JB
70252011-11-20 Juanma Barranquero <lekktu@gmail.com>
7026
7027 * casetab.c (Fset_case_table):
7028 * charset.c (Fcharset_after): Fix typos.
7029
615a3b8d 70302011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 7031
17e845af
PE
7032 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
7033 Otherwise, valgrind does not work on some platforms.
7034 Problem reported by Andreas Schwab in
6a0bf43d
PE
7035 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
7036 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
7037 is set, removing the need for VIRT_ADDRESS_VARIES.
7038 (PURE_P): Use a more-efficient implementation that needs just one
7039 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
7040 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
7041 to 4 (xorl, subq, cmpq, setbe).
7042 * alloc.c (pure): Always extern now, since that's the
7043 VIRT_ADDR_VARIES behavior.
7044 (PURE_POINTER_P): Use a single comparison, not two, for
7045 consistency with the new puresize.h.
7046 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
7047 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
7048 Remove VIRT_ADDR_VARIES no longer needed.
7049
f8fe6f96
EZ
70502011-11-19 Eli Zaretskii <eliz@gnu.org>
7051
7052 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
7053 (erase_phys_cursor, update_window_cursor, show_mouse_face)
7054 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
7055 behave as if the cursor position were at the window margin.
7056
7057 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
7058 and the cursor position is out of bounds, behave as if the cursor
7059 position were at the window margin. (Bug#10075)
7060
df05a53c
CY
70612011-11-18 Chong Yidong <cyd@gnu.org>
7062
7063 * window.c (Fwindow_combination_limit): Make first argument
7064 non-optional, since it is meaningless for live windows like the
7065 selected window.
61ccba97 7066
2071918e
DA
70672011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
7068
7069 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
7070
b50a28de
SM
70712011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
7072
7073 * intervals.c: Fix grafting over the whole buffer (bug#10071).
7074 (graft_intervals_into_buffer): Simplify.
7075
015137db
EZ
70762011-11-18 Eli Zaretskii <eliz@gnu.org>
7077
7078 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
7079 hash values of the two rows.
7080 (copy_row_except_pointers): Preserve the used[] arrays and the
7081 hash values of the two rows. (Bug#10035)
68c95424 7082 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
7083
7084 * xdisp.c (row_hash): New function, body extracted from
7085 compute_line_metrics.
7086 (compute_line_metrics): Call row_hash, instead of computing the
7087 hash code inline.
7088
7089 * dispnew.c (verify_row_hash): Call row_hash for computing the
7090 hash code of a row, instead of duplicating code from xdisp.c.
7091
7092 * dispextern.h (row_hash): Add prototype.
7093
a2addb04
TH
70942011-11-18 Tassilo Horn <tassilo@member.fsf.org>
7095
7096 * frame.c (delete_frame): Don't delete the terminal when the last
7097 X frame is closed if emacs is built with GTK toolkit.
7098
df85d315
JB
70992011-11-17 Juanma Barranquero <lekktu@gmail.com>
7100
7101 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
7102
a0c2d0ae
MR
71032011-11-17 Martin Rudalics <rudalics@gmx.at>
7104
7105 * window.c (Vwindow_splits): Rename to
7106 Vwindow_combination_resize. Suggested by Juri Linkov.
7107 (Fsplit_window_internal): Use Vwindow_combination_resize instead
7108 of Vwindow_splits.
7109
58179cce
JB
71102011-11-16 Juanma Barranquero <lekktu@gmail.com>
7111
7877f373
JB
7112 * nsfns.m (Fns_font_name):
7113 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 7114
b6f67890
MR
71152011-11-16 Martin Rudalics <rudalics@gmx.at>
7116
7117 * window.h (window): Rename slot "nest" to "combination_limit".
7118 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
7119 (Fset_window_nest): Rename to Fset_window_combination_limit.
7120 (Vwindow_nest): Rename to Vwindow_combination_limit.
7121 (recombine_windows, make_parent_window, make_window)
7122 (Fsplit_window_internal, saved_window)
7123 (Fset_window_configuration, save_window_save): Rename all
7124 occurrences of window_nest to window_combination_limit.
7125
c7015153
JB
71262011-11-15 Juanma Barranquero <lekktu@gmail.com>
7127
7128 * image.c (imagemagick_load_image): Fix typo.
7129
322ad6ec
EZ
71302011-11-14 Eli Zaretskii <eliz@gnu.org>
7131
7132 * xdisp.c (display_line): Move the call to
7133 highlight_trailing_whitespace before the call to
7134 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
7135 faces of all the glyphs to compute ROW's hash value.
7136 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 7137
f067b8ec
JB
71382011-11-14 Juanma Barranquero <lekktu@gmail.com>
7139
7140 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
7141 just return (bug#10044).
7142
1e5b2111
EZ
71432011-11-12 Eli Zaretskii <eliz@gnu.org>
7144
7ef3cbd5
EZ
7145 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
7146 with user-defined heap size. Bump the default size of the temacs
7147 heap to 27MB, to avoid memory warning when running temacs.
7148 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
7149
1e5b2111
EZ
7150 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
7151 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
7152 (verify_row_hash) [XASSERTS]: New function.
7153 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
7154 that the hash value of glyph rows is correct.
1e5b2111 7155
89d61221
MR
71562011-11-12 Martin Rudalics <rudalics@gmx.at>
7157
7158 * window.h (window): Remove splits slot.
7159 * window.c (Fwindow_splits, Fset_window_splits): Remove.
7160 (Fdelete_other_windows_internal, make_parent_window)
7161 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7162 (Fset_window_configuration, save_window_save): Don't deal with
7163 split status of windows.
7164 (saved_window): Remove splits slot.
7165 (Vwindow_splits): Rewrite doc-string.
7166
97f18cc8
JD
71672011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7168
7169 * xfns.c (unwind_create_frame):
7170 * nsfns.m (unwind_create_frame):
7171 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7172 Vframe_list (Bug#9999).
7173
22a648b4
DA
71742011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7175
0b381c7e 7176 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7177
659afede
KH
71782011-11-11 Kenichi Handa <handa@m17n.org>
7179
7180 * callproc.c (Fcall_process): Set the member dst_multibyte of
7181 process_coding.
7182
9ac0394b
KH
71832011-11-11 Johan Bockgård <bojohan@gnu.org>
7184
7185 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7186 avoid a crash (bug#9496).
7187
2fbdc249
CY
71882011-11-09 Chong Yidong <cyd@gnu.org>
7189
7190 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7191 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7192
ac6b1f81
PE
71932011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7194
7195 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7196
09db192c
PE
71972011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7198
7199 Avoid some portability problems by eschewing 'extern inline' functions.
7200 The trivial performance wins aren't worth the portability hassles; see
7201 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7202 et seq.
7203 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7204 (window_box_width, window_box_left, window_box_left_offset)
7205 (window_box_right, window_box_right_offset): Undo previous change,
7206 by removing the "extern"s.
7207 * intervals.c (adjust_intervals_for_insertion)
7208 (adjust_intervals_for_deletion): Undo previous change,
7209 making these static again.
7210 (offset_intervals, temp_set_point_both, temp_set_point)
7211 (copy_intervals_to_string): No longer inline.
7212 * xdisp.c (window_text_bottom_y, window_box_width)
7213 (window_box_height, window_box_left_offset)
7214 (window_box_right_offset, window_box_left, window_box_right)
7215 (window_box): No longer inline.
7216
105216ed
CY
72172011-11-08 Chong Yidong <cyd@gnu.org>
7218
7219 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7220 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7221 Signal an error if not a live window.
105216ed
CY
7222 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7223 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7224
ae9e237f
JB
72252011-11-07 Juanma Barranquero <lekktu@gmail.com>
7226
7227 * lisp.h (syms_of_abbrev): Remove declaration.
7228 Reported by CHENG Gao <chenggao@royau.me>.
7229
c7aa8333
EZ
72302011-11-07 Eli Zaretskii <eliz@gnu.org>
7231
7232 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7233 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7234 of temacs in GUI mode.
7235
be7f5545
MR
72362011-11-07 Martin Rudalics <rudalics@gmx.at>
7237
7238 * window.h: Declare delete_all_child_windows instead of
7239 delete_all_subwindows.
7240 * window.c (Fwindow_nest, Fset_window_nest)
7241 (Fset_window_new_total, Fset_window_new_normal)
7242 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7243 (delete_all_subwindows): Rename to delete_all_child_windows.
7244 (Fdelete_other_windows_internal, Fset_window_configuration):
7245 Call delete_all_child_windows instead of delete_all_subwindows.
7246 * frame.c (delete_frame): Call delete_all_child_windows instead
7247 of delete_all_subwindows.
7248
ca78dc43
PE
72492011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7250
7251 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7252 This is also needed for porting to any host where GC_MARK_STACK is
7253 not GC_MAKE_GCPROS_NOOPS.
7254 (which_symbols): Use it.
7255
a0241d01
KH
72562011-11-07 Kenichi Handa <handa@m17n.org>
7257
7258 * coding.c (coding_set_destination): Check coding->src_pos only
7259 when coding->src_object is a buffer (bug#9910).
7260
7261 * process.c (send_process): Set the member src_multibyte of coding
7262 to 0 (bug#9911) when sending a unibyte text.
7263
7264 * callproc.c (Fcall_process): Set the member src_multibyte of
7265 process_coding to 0 (bug#9912).
7266
a64bfdfa 72672011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7268
7269 * xmenu.c (cleanup_widget_value_tree): New function.
7270 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7271 calling free_menubar_widget_value_tree directly (Bug#9830).
7272
cb41b32a
PE
72732011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7274
7275 Fix some portability problems with 'inline'.
7276 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7277 (window_box_width, window_box_left, window_box_left_offset)
7278 (window_box_right, window_box_right_offset): Declare extern.
7279 Otherwise, these inline functions do not conform to C99 and
7280 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7281 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7282 * intervals.c (adjust_intervals_for_insertion)
7283 (adjust_intervals_for_deletion): Now extern, because otherwise the
7284 extern inline functions 'offset_intervals' couldn't refer to it.
7285 (static_offset_intervals): Remove.
7286 (offset_intervals): Rewrite using the old contents of
7287 static_offset_intervals. The old version didn't conform to C99
7288 because an extern inline function contained a reference to an
7289 identifier with static linkage.
7290
b7041366
AS
72912011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7292
7293 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7294 GC.
7295
88a37c4d
EZ
72962011-11-06 Eli Zaretskii <eliz@gnu.org>
7297
7298 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7299 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7300 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7301 return Qleft_to_right.
7302
49745b39
CY
73032011-11-06 Chong Yidong <cyd@gnu.org>
7304
7305 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7306 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7307 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7308 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7309 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7310 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7311 (Fwindow_vscroll): Doc fix.
7312 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7313 argument, since it makes no sense to pass a live window and for
7314 consistency with window-child.
7315
1f05cd82
CS
73162011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7317
7318 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7319 support MSVC.
7320
22610910
JR
73212011-11-05 Jason Rumney <jasonr@gnu.org>
7322
7323 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7324 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7325 fonts (Bug#6029).
7326 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7327 bitwise arithmetic preventing use of unicode-sip and non-truetype
7328 opentype fonts.
7329
a06776b2
EZ
73302011-11-05 Eli Zaretskii <eliz@gnu.org>
7331
3ad924ba
EZ
7332 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7333 "emacs"-only part.
7334
a06776b2
EZ
7335 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7336 initialization code to keep similarity to xfns.c after changes
7337 from 2011-11-05.
7338
c9e7db78
JD
73392011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7340
a97f8f3f
JD
7341 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7342 (unwind_create_frame): New function (Bug#9943).
7343 (Fx_create_frame): Restructure code to be more similar to the one in
7344 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7345 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7346 Move terminal->reference_count++ just before making the frame official
7347 (Bug#9943).
7348
7349 * nsterm.m (x_free_frame_resources): New function.
7350 (x_destroy_window): Move code to x_free_frame_resources.
7351
c9e7db78 7352 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7353 (Fx_create_frame, x_create_tip_frame):
7354 Move terminal->reference_count++ just before making the frame
75f1671a 7355 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7356 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7357
a6fc3b5c
EZ
73582011-11-05 Eli Zaretskii <eliz@gnu.org>
7359
7360 Support MSVC build with newer versions of Visual Studio.
7361 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7362 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7363 nt/gmake.defs.
7364
7365 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7366 which are not supported by MSVC.
7367 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7368 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7369 bitfields.
7370 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7371 types in bitfields.
7372 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7373
7374 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7375
58179cce 73762011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7377
7378 Support MSVC build with newer versions of Visual Studio.
7379 * w32.c: Don't include w32api.h for MSVC.
7380 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7381
7382 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7383 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7384 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7385 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7386 e_* cousins.
7387 (alloca) [_MSC_VER]: Define to _alloca.
7388
7389 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7390
7391 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7392
a58c13ed
EZ
73932011-11-04 Eli Zaretskii <eliz@gnu.org>
7394
7395 * xdisp.c (note_mouse_highlight): If either of
7396 previous/next-single-property-change returns nil, treat that as
7397 the beginning or the end of the buffer. (Bug#9955)
7398
fe0b6370
JD
73992011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7400
a58c13ed 7401 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7402 label is not null (Bug#9951).
7403 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7404 may be NULL.
7405
89bd5ee1
EZ
74062011-11-04 Eli Zaretskii <eliz@gnu.org>
7407
7408 * window.c (Fwindow_body_size): Mention in the doc string that the
7409 return value is in frame's canonical units. (Bug#9949)
7410
84c3edb9
EZ
74112011-11-03 Eli Zaretskii <eliz@gnu.org>
7412
4e2fb5c7
EZ
7413 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7414
84c3edb9 7415 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7416 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7417 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7418
bc17a887
EZ
74192011-11-01 Eli Zaretskii <eliz@gnu.org>
7420
7421 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7422 Don't stop backward scan on the continuation glyph, even though
7423 its CHARPOS is positive.
6d5eb5b0
SM
7424 (mouse_face_from_buffer_pos, note_mouse_highlight):
7425 Rename cover_string to disp_string.
bc17a887 7426
4ee88440
MR
74272011-11-01 Martin Rudalics <rudalics@gmx.at>
7428
7429 * window.c (temp_output_buffer_show): Don't use
7430 Vtemp_buffer_show_specifiers.
7431 (Vtemp_buffer_show_specifiers): Remove unused variable.
7432
c2ff3c02
EZ
74332011-10-30 Eli Zaretskii <eliz@gnu.org>
7434
7435 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7436 past the beginning of the current glyph matrix.
7437
58179cce 74382011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7439
7440 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7441 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7442 HAVE_GTK3 (Bug#9869).
b77a6a7f 7443
3b574623
JD
7444 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7445 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7446
b77a6a7f
JD
7447 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7448
7449 * xterm.c: Declare x_handle_net_wm_state to return int.
7450 (handle_one_xevent): Check if we are iconified but don't have
7451 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7452 (get_current_wm_state): Return non-zero if not hidden,
7453 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7454 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7455 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7456 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7457
196e41e4
PE
74582011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7459
7460 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7461 so that this new function doesn't get optimized away by a
7462 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7463
021f2e1a
AS
74642011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7465
7466 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7467
8b058d44
EZ
74682011-10-29 Eli Zaretskii <eliz@gnu.org>
7469
7470 Fix the `xbytecode' command.
7471 * .gdbinit (xprintbytestr): New command.
b50a28de 7472 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7473 (xbytecode): Print the byte-code string as well.
7474
4452fb80
EZ
74752011-10-29 Kim Storm <storm@cua.dk>
7476
8b058d44
EZ
7477 * alloc.c (which_symbols): New function.
7478
21b72067
AS
74792011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7480
7481 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7482 line. (Bug#9903)
7483
83ed7b5c
GM
74842011-10-29 Glenn Morris <rgm@gnu.org>
7485
7486 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7487 Not clear what it was for, and it causes various bugs. (Bug#9839)
7488
5a7a728b
EZ
74892011-10-28 Eli Zaretskii <eliz@gnu.org>
7490
7491 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7492 possible random value that matches one of those tested as
7493 condition to clear the mouse face.
7494
d3d0842f
CY
74952011-10-28 Chong Yidong <cyd@gnu.org>
7496
7497 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7498
31b39d13
DN
74992011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7500
7501 * window.c (make_window): Initialize phys_cursor_on_p.
7502
9aba6043
SM
75032011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7504
7505 * lisp.h (struct Lisp_Symbol): Update comments.
7506
c20992f4
JB
75072011-10-28 Juanma Barranquero <lekktu@gmail.com>
7508
7509 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7510
db4f02f2
EZ
75112011-10-28 Eli Zaretskii <eliz@gnu.org>
7512
7513 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7514 <oslsachem@gmail.com> for helping to debug this.
7515
7516 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7517 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7518 (g_b_init_get_glyph_outline_w): New static variables.
7519 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7520 (GetGlyphOutlineW_Proc): New typedefs.
7521 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7522 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7523 New functions.
7524 (w32font_open_internal, compute_metrics):
7525 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7526 instead of calling the "wide" APIs directly.
7527
7528 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7529
7530 * w32.h (syms_of_w32font): Add prototype.
7531
87e68db4
JB
75322011-10-27 Juanma Barranquero <lekktu@gmail.com>
7533
7534 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7535 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7536 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7537 (Fmove_to_window_line): Doc fix.
7538
435c1d67
CY
75392011-10-27 Chong Yidong <cyd@gnu.org>
7540
7541 * process.c (make_process): Set gnutls_state to NULL.
7542
7543 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7544 non-NULL, regardless of GNUTLS_INITSTAGE.
7545 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7546 an error. Set process slots as soon as we allocate them.
7547
7548 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7549
9c6c6f49
CY
75502011-10-27 Chong Yidong <cyd@gnu.org>
7551
9aba6043
SM
7552 * gnutls.c (emacs_gnutls_deinit): New function.
7553 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7554 (Fgnutls_deinit, Fgnutls_boot): Use it.
7555
7556 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7557 (deactivate_process): Call emacs_gnutls_deinit.
7558
657d08d3
JB
75592011-10-27 Juanma Barranquero <lekktu@gmail.com>
7560
7561 * image.c (x_create_x_image_and_pixmap):
7562 * w32.c (sys_rename, w32_delayed_load):
7563 * w32font.c (fill_in_logfont):
7564 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7565
5430d399
JB
75662011-10-26 Juanma Barranquero <lekktu@gmail.com>
7567
7568 * w32fns.c (w32_default_color_map): New function,
7569 extracted from Fw32_default_color_map.
a7ef684b 7570 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7571
fe0055fa
PE
75722011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7573
7574 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7575
e6346438
SM
75762011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7577
7578 * keyboard.c (test_undefined): New function (bug#9751).
7579 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7580
e112cc37
ET
75812011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7582
7583 * sysdep.c (init_sys_modes): Fix the check for the controlling
7584 terminal (Bug#6649).
7585
7b5d6677
EZ
75862011-10-20 Eli Zaretskii <eliz@gnu.org>
7587
7588 * dispextern.h (struct bidi_it): New member next_en_type.
7589
7590 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7591 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7592 current character, check also for next_en_type being WEAK_EN.
7593 (bidi_resolve_weak): Don't enter the expensive loop if the current
7594 position is before next_en_pos. Record the bidi type of the first
7595 non-ET, non-BN character we find, in addition to its position.
7596 (bidi_level_of_next_char): Invalidate next_en_type when
7597 next_en_pos is over-stepped.
7598
7da0b018
PE
75992011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7600
7601 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7602 * editfns.c: Rewrite current-time-zone so that it invokes
7603 the equivalent of (format-time-string "%Z") to get the time zone name.
7604 This fixes a bug when the time zone name contains characters that
7605 need converting from the system time locale to Emacs internal format.
7606 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7607 that patch fixed format-time-string to do the conversion, but
7608 I forgot to fix current-time-zone.
7609 (format_time_string): New function, containing most of
7610 what Fformat_time_string used to contain.
7611 (Fformat_time_string): Rewrite in terms of format_time_string.
7612 This doesn't change this function's behavior.
7613 (current-time-zone): Rewrite to use format_time_string.
7614 This fixes the bug reported by Michael Schierl in
7615 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7616 Jason Rumney's 2007-06-07 change worked around this bug, but
7617 didn't fix it.
7618 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7619
8547b010
EZ
76202011-10-19 Eli Zaretskii <eliz@gnu.org>
7621
7622 * xdisp.c (start_display): If the character at POS is displayed
7623 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7624 (try_window_reusing_current_matrix): If a line ends in a display
7625 vector or the next line starts in a display vector, continue
7626 redrawing the window even though the character position of
7627 start_row was reached.
8547b010
EZ
7628 (Bug#9771, part 2)
7629
4e948d15
CY
76302011-10-18 Chong Yidong <cyd@gnu.org>
7631
7632 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7633 with nobreak-char-display too.
7634
4787455f
EZ
76352011-10-18 Eli Zaretskii <eliz@gnu.org>
7636
7637 Fix part 3 of bug#9771.
7638 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7639 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7640 non-neutral characters if the current character is a paragraph
7641 separator (a.k.a. Newline). This avoids running the same
7642 expensive loop twice, once when we consume the preceding newline
7643 and the other time when the line actually needs to be displayed.
7644 Avoid the loop when we see neutrals on the base embedding level
7645 following a character whose directionality is the same as the
7646 paragraph's. This avoids running the expensive loop when a line
7647 ends in a long sequence of neutrals, like control characters.
7648 Add assertion against STRONG_AL type. Slightly rearrange code
7649 that determines the type of a neutral given the first non-neutral
7650 that follows it.
7651 (bidi_level_of_next_char): Set next_en_pos to zero when
7652 invalidating its info.
7653
2c91f553
EZ
76542011-10-17 Eli Zaretskii <eliz@gnu.org>
7655
7656 * xdisp.c (push_display_prop): Determine whether to record string
7657 or buffer position by IT->string, not by IT->method. Allow
7658 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7659 (move_it_vertically_backward): Don't look for character position
7660 immediately after the newline when in a continuation line.
7661 (Bug#9771, part 1)
2c91f553 7662
c7b08b0d
MR
76632011-10-15 Martin Rudalics <rudalics@gmx.at>
7664
7665 * window.c (coordinates_in_window): Rewrite and delabelize
7666 vertical border check. (Bug#5357) (Bug#9618)
7667
6b02f655
SM
76682011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7669
7670 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7671 errors in XSetWindowBorder (bug#9310).
7672
81d40c92
DA
76732011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7674
7675 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7676 avoid crash when xmalloc overrun checking is enabled.
7677
d4172c3b
EZ
76782011-10-13 Eli Zaretskii <eliz@gnu.org>
7679
7680 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7681 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7682 cursor motion with <left> and <right> arrow keys.
7683
7684 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7685 some callers set that themselves.
7686
b00eea75
EZ
76872011-10-12 Eli Zaretskii <eliz@gnu.org>
7688
7689 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7690 display string and the previous row comes from the same string and
7691 is empty. (Bug#9739) (Bug#9738)
7692
8fe012c4
SM
76932011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7694
7695 * doc.c (get_doc_string): Encode file name (bug#9735).
7696
0074aef2
EZ
76972011-10-12 Eli Zaretskii <eliz@gnu.org>
7698
79beb178
EZ
7699 * bidi.c (bidi_level_of_next_char):
7700 * xdisp.c (get_visually_first_element): Remove old incorrect
7701 comments regarding the Unicode Line Separator character.
7702
0074aef2
EZ
7703 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7704
6e4b3fbe
DA
77052011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7706
7707 * alloc.c (Fgc_status): Do not access beyond zombies array
7708 boundary if nzombies > MAX_ZOMBIES.
7709 * alloc.c (dump_zombies): Add missing format specifier.
7710
0324f3af
PE
77112011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7712
b5525cac
PE
7713 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7714 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7715
0324f3af
PE
7716 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7717 Some packages use them to denote characters with modifiers.
7718
e9b5f888
AS
77192011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7720
7721 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7722 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7723 matching a pp-number. Rename parameter var to var1.
7724
127827c0
SM
77252011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7726
7727 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7728
c8fd3bd0
GM
77292011-10-08 Glenn Morris <rgm@gnu.org>
7730
7731 * callint.c (Fcall_interactively): Give a more explicit error for the
7732 'c' case with a non-character input. (Bug#8479)
7733
352ec8ff
EZ
77342011-10-08 Eli Zaretskii <eliz@gnu.org>
7735
03669ccb
EZ
7736 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7737 lines.
7061c986
EZ
7738 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7739 lines that are hscrolled on the left.
03669ccb 7740
352ec8ff
EZ
7741 * dispnew.c (buffer_posn_from_coords): Account for a possible
7742 presence of header-line. (Bug#4426)
7743
a66cfb1c
SM
77442011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7745
6b02f655
SM
7746 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7747 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7748
7c5ee88e
PE
77492011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7750
7751 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7752 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7753 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7754 this makes Emacs dump core during garbage collection on rare
7755 occasions. sizeof is obviously inferior to offsetof here, so
7756 stick with offsetof.
7757 (GC_POINTER_ALIGNMENT): New macro.
7758 (mark_memory): Omit 3rd (offset) arg; caller changed.
7759 Don't assume EMACS_INT alignment is the same as pointer alignment.
7760
df1bbe5b
SM
77612011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7762
7763 * keyboard.c (read_key_sequence_remapped): New var.
7764 (read_key_sequence): Compute remapping in the right buffer.
7765 (command_loop_1): Use read_key_sequence's remapping directly.
7766
51553db6
SM
77672011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7768
32c1fffd
SM
7769 * dired.c (file_name_completion): Don't expand file name.
7770 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7771 before checking file name handler.
7772
51553db6
SM
7773 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7774 they've been requested explicitly (bug#9591).
7775
b6bd1599 77762011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7777
7778 * keymap.c (Fsingle_key_description): Use make_specified_string
7779 instead of build_string to build string from push_key_description.
7780 (Bug#5193)
7781
f701dc2a
PE
77822011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7783
4222c55d
PE
7784 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7785 This fixes a Y2038 bug on 64-bit hosts.
7786 * buffer.c (reset_buffer):
7787 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7788 (Fclear_buffer_auto_save_failure):
7789 Use 0, not -1, to represent an unset failure time, since time_t
7790 might not be signed.
7791
f701dc2a
PE
7792 Remove dependency on glibc malloc internals.
7793 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7794 Move back here from lisp.h, but with their new implementations.
7795 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7796 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7797 * charset.c (charset_table_init): New static var.
7798 (syms_of_charset): Use it instead of xmalloc. This removes a
7799 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7800 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7801 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7802 Move back to alloc.c.
7803 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7804 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7805
9ceebf39
JD
78062011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7807
7808 * nsterm.m (windowDidResize): Call x_set_window_size only when
7809 ns_in_resize is true. Otherwise set pixelwidth/height and
7810 call change_frame_size (Bug#9628).
7811
cb993c58
PE
78122011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7813
3930c88b
PE
7814 Port --enable-checking=all to Fedora 14 x86-64.
7815 * charset.c (syms_of_charset): Also account for glibc malloc's
7816 internal overhead when calculating the initial malloc maximum.
7817
cb993c58
PE
7818 Port --enable-checking=all to Fedora 14 x86.
7819 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7820 Move to lisp.h.
7821 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7822 (overrun_check_realloc, overrun_check_free):
7823 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7824 That way, xmalloc returns a properly-aligned pointer even if
7825 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7826 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7827 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7828 into account when calculating the initial malloc maximum.
7829 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7830 Move here from alloc.c, so that charset.c can use it too.
7831 Properly align; the old code wasn't right for common 32-bit hosts
7832 when configured with --enable-checking=all.
7833 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7834 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7835
31bed486
EZ
78362011-09-29 Eli Zaretskii <eliz@gnu.org>
7837
04c70788 7838 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7839 use EDOM.
7840
fbcaa2f3
EZ
78412011-09-28 Eli Zaretskii <eliz@gnu.org>
7842
7843 * xdisp.c (compute_display_string_end): If there's no display
7844 string at CHARPOS, return -1.
7845
7846 * bidi.c (bidi_fetch_char): When compute_display_string_end
7847 returns a negative value, treat the character as a normal
7848 character not covered by a display string. (Bug#9624)
7849
a239d4e9
JB
78502011-09-28 Juanma Barranquero <lekktu@gmail.com>
7851
7852 * lread.c (Fread_from_string): Fix typo in docstring.
7853
88652fd5
EZ
78542011-09-27 Eli Zaretskii <eliz@gnu.org>
7855
7856 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7857 newline, reseat the iterator instead of bidi-iterating there one
7858 character at a time. (Bug#9610)
32c1fffd
SM
7859 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7860 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7861
ed497dd4
AS
78622011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7863
7864 * lread.c (readevalloop): Use correct code for NBSP.
7865 (read1): Likewise. (Bug#9608)
7866
b2bf61aa
MA
78672011-09-25 Michael Albinus <michael.albinus@gmx.de>
7868
7869 * dbusbind.c (Fdbus_register_signal): When service is not
7870 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7871
32bbb17c
GM
78722011-09-25 Glenn Morris <rgm@gnu.org>
7873
7874 * buffer.c (truncate-lines): Doc fix.
7875
94e0933e
CY
78762011-09-24 Chong Yidong <cyd@stupidchicken.com>
7877
7878 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7879 (Fset_window_next_buffers): Doc fix.
7880
cddde921
GM
78812011-09-24 Glenn Morris <rgm@gnu.org>
7882
7883 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7884
1260aef1
PE
78852011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7886
25b4bfa0
PE
7887 Fix minor problems found by static checking.
7888 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7889 * indent.c (Fvertical_motion): Fix == vs = typo.
7890
e3cbd34b
EZ
78912011-09-24 Eli Zaretskii <eliz@gnu.org>
7892
a66cfb1c
SM
7893 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7894 Default value is now t. Doc fix.
6bf7006f 7895
e3cbd34b 7896 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7897 logic when moving up, not only when moving down. Fix the
e3cbd34b 7898 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7899 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7900
7901 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7902 CHARPOS is covered by a display string which includes newlines.
7903 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7904 is covered by a display string with embedded newlines.
7905
a3de0cbd
MA
79062011-09-24 Michael Albinus <michael.albinus@gmx.de>
7907
7908 * dbusbind.c (Fdbus_register_signal): Add match rule to
7909 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7910 (Fdbus_register_method, Vdbus_registered_objects_table):
7911 Fix docstring.
a3de0cbd 7912
b260039d
JM
79132011-09-24 Jim Meyering <meyering@redhat.com>
7914
32c1fffd 7915 do not ignore write error for any output size
b260039d
JM
7916 The previous change was incomplete.
7917 While it makes emacs --batch detect the vast majority of stdout
7918 write failures, errors were still ignored whenever the output size is
7919 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7920 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7921 && echo FAIL: ignored write error
7922 FAIL: ignored write error
7923 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7924 && echo FAIL: ignored write error
7925 FAIL: ignored write error
7926 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7927
8eca8a7c
AS
79282011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7929
7930 * emacs.c (Fkill_emacs): In noninteractive mode exit
7931 non-successfully if a write error occurred on stdout. (Bug#9574)
7932
3341db62
EZ
79332011-09-21 Eli Zaretskii <eliz@gnu.org>
7934
7935 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7936 the xassert test.
7937
7938 * dispextern.h (struct it): Update the comment documenting what
7939 can it->OBJECT be.
7940
8c203dbf
EZ
79412011-09-20 Eli Zaretskii <eliz@gnu.org>
7942
7943 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7944 a display string, extend search for cursor position to end of row.
7945 (find_row_edges): If the row ends in a newline from a display
7946 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7947 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7948 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7949 non-empty line. Fixes confusing cursor motion with arrow keys at
7950 the beginning of a line that starts with whitespace.
8c203dbf 7951
a4824228
LMI
79522011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7953
7954 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7955 (bug#9493).
7956
33ed493b
CY
79572011-09-18 Chong Yidong <cyd@stupidchicken.com>
7958
7959 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7960 boolean (Bug#9154).
7961
56cd55c8
EZ
79622011-09-18 Eli Zaretskii <eliz@gnu.org>
7963
7964 * xdisp.c (display_line): Record maximum and minimum buffer
7965 positions even if no glyphs were produced (e.g., by a zero-width
7966 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7967 buffer positions that will be removed from the glyph row because
7968 they don't fit.
c02dcedf
EZ
7969 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7970 column is beyond frame width: don't subtract 1 "pixel" when
7971 computing width of the stretch.
3e62b7e0
EZ
7972 (reseat_at_next_visible_line_start): Undo the change made on
7973 2011-09-17 that saved paragraph information and restored it after
7974 the call to `reseat'. (Bug#9545)
56cd55c8 7975
5ed99d36 79762011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7977
7978 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7979 and turn window cursor on if cleared (Bug#9415).
7980
5ed99d36 79812011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7982
7983 * search.c (boyer_moore): Take unibyte characters from pattern
7984 literally. (Bug#9458)
7985
9bade7b2
EZ
79862011-09-18 Eli Zaretskii <eliz@gnu.org>
7987
7988 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7989
e5e9d610
PE
79902011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7991
87e4427a
PE
7992 Fix minor problem found by static checking.
7993 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7994 initialized, to pacify gcc -Wuninitialized.
7995
e5e9d610
PE
7996 * fileio.c: Report proper errno when syscall falls.
7997 (Finsert_file_contents): Save and restore errno,
7998 so that report_file_error outputs the correct diagnostic.
7999 (Fwrite_region) [CLASH_DETECTION]: Likewise.
8000
a1674f0b
EZ
80012011-09-18 Eli Zaretskii <eliz@gnu.org>
8002
8003 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
8004
fbfb6dd4
EZ
80052011-09-17 Eli Zaretskii <eliz@gnu.org>
8006
8007 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
8008 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
8009
bb187662
EZ
80102011-09-17 Eli Zaretskii <eliz@gnu.org>
8011
1137e8b8 8012 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 8013 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
8014
8015 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
8016 (bidi_find_paragraph_start): Search back for paragraph beginning
8017 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
8018 (bidi_move_to_visually_next): Only trigger paragraph-related
8019 computations when the last character is a newline or at EOB, not
8020 just any NEUTRAL_B. (Bug#9470)
8021
bb187662
EZ
8022 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
8023 truncated lines if point is covered by a display string. (Bug#9524)
8024
2e621251
PE
80252011-09-16 Paul Eggert <eggert@cs.ucla.edu>
8026
8027 * xselect.c: Relax test for outgoing X longs (Bug#9498).
8028 (cons_to_x_long): New function.
8029 (lisp_data_to_selection_data): Use it. Correct the test for
8030 short-versus-long data; it was negated. Break out of vector
8031 loop, for efficiency, when a long datum is discovered.
8032
91a15bc6
SM
80332011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
8034
8035 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
8036
b41c3a35
EZ
80372011-09-16 Eli Zaretskii <eliz@gnu.org>
8038
8039 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
8040 GCC PR/17406) by declaring this function with external scope.
8041
7812ba2d
PE
80422011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8043
8044 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
8045 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
8046
cf7edc2a
AS
80472011-09-15 Andreas Schwab <schwab@linux-m68k.org>
8048
8049 * editfns.c (Fformat): Correctly handle text properties on "%%".
8050
bd01620e
EZ
80512011-09-15 Eli Zaretskii <eliz@gnu.org>
8052
8053 * xterm.c (x_draw_composite_glyph_string_foreground):
8054 * w32term.c (x_draw_composite_glyph_string_foreground):
8055 * term.c (encode_terminal_code):
8056 * composite.c (composition_update_it, get_composition_id):
8057 * xdisp.c (get_next_display_element)
8058 (fill_composite_glyph_string): Add comments about special meaning
8059 of TAB characters in a composition.
8060
a02719a3
PE
80612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8062
8063 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
8064 This occurs when processing a multibyte format.
8065 Problem reported by Wolfgang Jenker.
a02719a3 8066
72589a3c
JB
80672011-09-15 Johan Bockgård <bojohan@gnu.org>
8068
8069 * xdisp.c (try_cursor_movement): Only check for exact match if
8070 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
8071
1c14176c
PE
80722011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8073
8074 Remove unused external symbols.
8075 * dispextern.h (calc_pixel_width_or_height): Remove decl.
8076 * xdisp.c (calc_pixel_width_or_height): Now static.
8077 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
8078 * indent.c (check_display_width):
8079 * w32term.c: Fix comment to match code.
8080 * xterm.c, xterm.h (x_catching_errors): Remove.
8081
d2eea5b5
PE
80822011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8083
8084 * xselect.c: Use signed conversions more consistently (Bug#9498).
8085 (selection_data_to_lisp_data): Assume incoming selection data are
8086 signed integers, not unsigned. This is to be consistent with
8087 outgoing selection data, which was modified to use signed integers
8088 in as part of the fix to Bug#9196 in response to Jan D.'s comment
8089 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
8090 expects long, not unsigned long.
8091
46888499
EZ
80922011-09-14 Eli Zaretskii <eliz@gnu.org>
8093
8094 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
8095 computation of loop end. Reported by Johan Bockgård
8096 <bojohan@gnu.org>.
8097
ef8ef9fb
CY
80982011-09-13 Chong Yidong <cyd@stupidchicken.com>
8099
8100 * frame.c (Fother_visible_frames_p): Function deleted.
8101
fa819fed
EZ
81022011-09-12 Eli Zaretskii <eliz@gnu.org>
8103
8104 * indent.c (compute_motion): Process display vector front to back
8105 rather than the other way around. (Bug#2496)
8106
2ba8e008
SM
81072011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
8108
8109 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
8110
20f53c69
CY
81112011-09-11 Chong Yidong <cyd@stupidchicken.com>
8112
8113 * minibuf.c (Fread_from_minibuffer): Doc fix.
8114
d562d7a4
EZ
81152011-09-11 Eli Zaretskii <eliz@gnu.org>
8116
8117 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
8118 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
8119
1c4d7f3d
LMI
81202011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8121
8122 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
8123 value for non-existent files.
8124
b885bf36
EZ
81252011-09-11 Eli Zaretskii <eliz@gnu.org>
8126
8127 * fileio.c (Finsert_file_contents): If the file cannot be opened,
8128 set its "size" to -1. This will set the modtime_size field of
8129 the corresponding buffer to -1, which is what
8130 verify-visited-file-modtime expects for files that do not exist.
8131 (Bug#9139)
8132
6612f0bf
PE
81332011-09-11 Paul Eggert <eggert@cs.ucla.edu>
8134
8135 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
8136 here ...
8137 * lisp.h: ... from here. push_key_description is no longer
8138 defined in keyboard.c, so its declaration should not be in
8139 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
8140 logically belongs with push_key_description.
8141
dfb3f755
PE
81422011-09-10 Paul Eggert <eggert@cs.ucla.edu>
8143
8144 * buffer.h: Include <sys/types.h> instead of <time.h>.
8145 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
8146 Problem reported by Herbert J. Skuhra.
8147
3134906c
LMI
81482011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8149
8150 * xml.c (parse_region): Make the parsing work for
8151 non-comment-starting XML files again (bug#9144).
8152
8d903f4e
AS
81532011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8154
8155 * image.c (gif_load): Fix calculation of bottom and right corner.
8156 (Bug#9468)
8157
80ad64f4
EZ
81582011-09-10 Eli Zaretskii <eliz@gnu.org>
8159
8160 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
8161 redisplay in small windows.
8162
208a048d
EZ
81632011-09-09 Eli Zaretskii <eliz@gnu.org>
8164
8165 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
8166
9b1c252e
MR
81672011-09-08 Martin Rudalics <rudalics@gmx.at>
8168
8169 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8170 Operate on live windows only.
8171
2949f33b
JB
81722011-09-08 Juanma Barranquero <lekktu@gmail.com>
8173
8174 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8175
e08dcafd
EZ
81762011-09-07 Eli Zaretskii <eliz@gnu.org>
8177
8178 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8179 only under bidi iteration.
8180
115b96bd
JD
81812011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8182
8183 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8184
c8199d0f
PE
81852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8186
8187 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8188 Without this fix, the command to link temacs failed due to an
8189 undefined symbol __builtin_isnan. This is because
8190 /usr/include/iso/math_c99.h #defines isnan(x) to
8191 __builtin_isnan(x), but the bundled gcc, which identifies itself
8192 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8193 a __builtin_isnan.
8194 * floatfns.c (isnan): #undef, and then #define to a clone of
8195 what's in data.c.
8196 (Fisnan): Always define, since it's always available now.
8197 (syms_of_floatfns): Always define isnan at the Lisp level.
8198
e39b275c 81992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8200
8201 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8202
b2db44d9 82032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8204
f4af5137 8205 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8206 The previous code assumed that file offsets (off_t values) fit in
8207 EMACS_INT variables, which is not true on typical 32-bit hosts.
8208 The code messed up by falsely reporting buffer overflow in cases
8209 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8210 when "big" contains more than 2**29 bytes, even though this
8211 inserts just one byte and does not overflow the buffer.
8212 (Finsert_file_contents): Store file offsets as off_t
8213 values, not as EMACS_INT values. Check for overflow when
8214 converting between EMACS_INT and off_t. When checking for
8215 buffer overflow or for overlap, take the offsets into account.
8216 Don't use EMACS_INT for small values where int suffices.
8217 When checking for overlap, fix a typo: ZV was used where
8218 ZV_BYTE was intended.
8219 (Fwrite_region): Don't assume off_t fits into 'long'.
8220 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8221
ecfc0a49
MA
82222011-09-05 Michael Albinus <michael.albinus@gmx.de>
8223
8224 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8225
6511acf2 82262011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8227
0999621a 8228 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8229
8230 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8231 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8232 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8233 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8234 (modify_event_symbol): Do not assume that the length of
8235 name_alist_or_stem is safe to alloca and fits in int.
8236 (Fexecute_extended_command): Likewise for function name and binding.
8237 (Frecursion_depth): Wrap around reliably on integer overflow.
8238 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8239 since some callers pass EMACS_INT values.
8240 (Fsingle_key_description): Don't crash if symbol name contains more
8241 than MAX_ALLOCA bytes.
8242 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8243 (get_minibuffer): Arg is now EMACS_INT, not int.
8244 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8245 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8246 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8247
2be7d702
PE
8248 * dbusbind.c (signature_cat): New function.
8249 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8250 Do not overrun buffer; instead, report string overflow.
8251
9d1df220
PE
8252 * dispnew.c (add_window_display_history): Don't overrun buffer.
8253 Truncate instead; this is OK since it's just a log.
8254
33ef5c64
PE
8255 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8256 even if the time zone offset is outlandishly large.
8257 Don't mishandle offset == INT_MIN.
8258
66c6fdd5
PE
8259 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8260 when creating daemon; the previous buffer-overflow check was incorrect.
8261
d749b01b
PE
8262 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8263 which has the guts of the old verror function.
8264
b5cd1905
PE
8265 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8266 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8267
6e1a67fb
PE
8268 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8269 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8270 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8271 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8272 length of string rather than counting it via multiple sprintfs;
8273 that's simpler and more reliable.
c21721cc
PE
8274 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8275 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8276 sprintf, in case result does not fit in int.
8277
c57b67fc
PE
8278 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8279 (fontset_from_font): Print it.
8280
8a401434
PE
8281 * frame.c (tty_frame_count): Now printmax_t, not int.
8282 (make_terminal_frame, set_term_frame_name): Print it.
8283 (x_report_frame_params): In X, window IDs are unsigned long,
8284 not signed long, so print them as unsigned.
8285 (validate_x_resource_name): Check for implausibly long names,
8286 and don't assume name length fits in 'int'.
8287 (x_get_resource_string): Don't blindly alloca invocation name;
8288 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8289 not fit in int.
8290
6e1a67fb
PE
8291 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8292 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8293 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8294
0df02bf3
PE
8295 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8296 Use esprintf, not sprintf, in case result does not fit in int.
8297
48e30793
PE
8298 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8299 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8300 it as a large positive number.
8301 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8302 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8303
a66ff6d8
PE
8304 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8305 in case result does not fit in int.
8306
aca216ff
PE
8307 * print.c (float_to_string): Detect width overflow more reliably.
8308 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8309 buffer overrun. Don't assume list length fits in 'int'. Treat
8310 print length of 0 as 0, not as infinity; to be consistent with other
8311 uses of print length in this function. Don't overflow print length
8312 index. Don't assume hash table size fits in 'long', or that
8313 vectorlike size fits in 'unsigned long'.
8314
31c286f7
PE
8315 * process.c (make_process): Use printmax_t, not int, to format
8316 process-name gensyms.
8317
55e5faa1
PE
8318 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8319
80f2e268
PE
8320 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8321 to avoid potential buffer overrun.
8322
670741ab
PE
8323 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8324 if X resource line is longer than 512 bytes.
8325
b7163a50
PE
8326 * xfns.c (x_window): Make sprintf buffer a bit bigger
8327 to avoid potential buffer overrun.
8328
ae58ff1f
PE
8329 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8330
c43c8a6a
PE
8331 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8332
3f8236f4
PE
83332011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8334
53e9fe90 8335 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8336 Without these, Emacs silently mishandles large integers sometimes.
8337 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8338 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8339
6511acf2
PE
8340 * xdisp.c (try_window_id): Check Emacs fixnum range before
8341 converting to 'int'.
806add1d 8342
6511acf2 8343 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8344 Check that an Emacs fixnum is in range before assigning it to 'int'.
8345 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8346 values converted from Emacs fixnums.
8347 (Frecenter): Don't wrap around a line count if it is out of 'int'
8348 range; instead, treat it as an extreme value.
8349 (Fset_window_configuration, compare_window_configurations):
8350 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8351
6511acf2
PE
8352 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8353 that can exceed INT_MAX. Check that EMACS_INT value is in range
8354 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8355 (match_limit): Don't assume that a fixnum can fit in 'int'.
8356
6511acf2 8357 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8358 exceed INT_MAX.
8359
6511acf2 8360 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8361 (Fvertical_motion): Don't wrap around LINES values that don't fit
8362 in 'int'. Instead, treat them as extreme values. This is good
8363 enough for windows, which can't have more than INT_MAX lines anyway.
8364
fcb901a7
LMI
83652011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8366
0f2f6b6d
LMI
8367 * Require libxml/parser.h to avoid compilation warning.
8368
fcb901a7
LMI
8369 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8370
8371 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8372 since this reportedly can destroy thread storage.
8373
6e20a0d4
CY
83742011-08-30 Chong Yidong <cyd@stupidchicken.com>
8375
8376 * syntax.c (find_defun_start): Update all cache variables if
8377 exiting early (Bug#9401).
8378
148ae00e
EZ
83792011-08-30 Eli Zaretskii <eliz@gnu.org>
8380
f6cfbd8f
EZ
8381 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8382
148ae00e
EZ
8383 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8384 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8385 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8386
8387 * term.c (tty_append_glyph): New function.
8388 (produce_stretch_glyph): Static function and its prototype deleted.
8389
a66cfb1c
SM
8390 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8391 Add prototypes.
148ae00e 8392
c4a07a4c
PE
83932011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8394
8395 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8396 when checking :margin (Bug#9390).
8397 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8398 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8399 so that the name doesn't mislead. All uses changed.
8400
6bc8cd65
JB
84012011-08-28 Johan Bockgård <bojohan@gnu.org>
8402
8403 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8404 set_tty_hooks.
8405
dca4927e
EZ
84062011-08-27 Eli Zaretskii <eliz@gnu.org>
8407
8408 * xdisp.c (move_it_to): Don't bail out early when reaching
8409 position beyond to_charpos, if we are scanning backwards.
8410 (move_it_vertically_backward): When DY == 0, make sure we get to
8411 the first character in the line after the newline.
8412
f2cad773
PE
84132011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8414
8415 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8416 (ccl_driver): Do not generate an out-of-range pointer.
8417 (Fccl_execute_on_string): Remove unnecessary check for
8418 integer overflow, noted by Stefan Monnier in
8419 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8420 Remove a FIXME that didn't need fixing.
8421 Simplify the newly-introduced buffer reallocation code.
8422
0cae2cdb
JB
84232011-08-27 Juanma Barranquero <lekktu@gmail.com>
8424
8425 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8426
5fc295a4 84272011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8428
70c60eb2 8429 Integer and memory overflow issues (Bug#9196).
726e0ab1 8430
d31850da
PE
8431 * doc.c (get_doc_string): Rework so that
8432 get_doc_string_buffer_size is the actual buffer size, rather than
8433 being 1 less than the actual buffer size; this makes xpalloc more
8434 convenient.
8435
a69fbedb
PE
8436 * image.c (x_allocate_bitmap_record, cache_image):
8437 * xselect.c (Fx_register_dnd_atom):
8438 Simplify previous changes by using xpalloc.
8439
fe5c5d37
PE
8440 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8441 since either will do and ptrdiff_t is convenient with xpalloc.
8442
0065d054
PE
8443 * charset.c (charset_table_size)
8444 (struct charset_sort_data.priority): Now ptrdiff_t.
8445 (charset_compare): Don't overflow if priorities differ greatly.
8446 (Fsort_charsets): Don't assume list length fits in int.
8447 Check for size-calculation overflow when allocating sort data.
8448 (syms_of_charset): Allocate an initial charset table that is
8449 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8450
8451 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8452
8453 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8454 The actual value is always <= INT_MAX, and leaving it unsigned made
8455 overflow checking harder.
8456
8457 * dispextern.h (struct glyph_matrix.rows_allocated)
8458 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8459 with xpalloc. The values are still always <= INT_MAX.
8460
8461 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8462
8463 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8464 (SAFE_NALLOCA): New macro.
8465
8466 * region-cache.c (struct boundary.pos, find_cache_boundary)
8467 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8468 (set_cache_region, invalidate_region_cache)
8469 (revalidate_region_cache, know_region_cache, region_cache_forward)
8470 (region_cache_backward, pp_cache):
8471 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8472 so that ptrdiff_t * can be passed to xpalloc.
8473 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8474 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8475 (pp_cache): Don't assume cache_len fits in int.
8476 * region-cache.h: Adjust extern decls to match.
8477
8478 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8479 EMACS_INT, since either will do, for xpalloc.
8480
8481 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8482 (xnmalloc, xnrealloc, xpalloc): New functions.
8483
726e0ab1
PE
8484 * bidi.c (bidi_shelve_header_size): New constant.
8485 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8486 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8487
51f30bc5 8488 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8489 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8490 (overlay_strings):
8491 Don't update size of array until after memory allocation succeeds,
8492 because xmalloc/xrealloc may not return.
0065d054
PE
8493 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8494 now that we have proper integer overflow checking.
8495 (record_overlay_string, overlay_strings): Catch overflows when
8496 calculating size of overlay_str_buf.
726e0ab1 8497
0065d054
PE
8498 * callproc.c (Fcall_process): Check for size overflow when
8499 calculating size of args2.
8500 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8501 Normally we prefer signed values, but sticking with ptrdiff_t would
8502 require adding more-complicated checks.
726e0ab1
PE
8503
8504 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8505 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8506 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8507 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8508
8509 * character.c (Fstring): Check for size-calculation overflow.
8510
8511 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8512 unnecessary integer overflow. Check for size overflow.
8513 (encode_coding_object): Don't update size until xmalloc succeeds.
8514
8515 * composite.c (get_composition_id): Check for overflow in glyph
8516 length calculations.
8517
8518 Integer and memory overflow fixes for display code.
8519 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8520 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8521 (scrolling_window): Check for overflow in size calculations.
8522 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8523 Don't assume glyph table len fits in int.
8524 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8525 (row_table_size): Now ptrdiff_t, not int.
8526 (scrolling_window): Avoid overflow in size calculations.
8527 Don't update size until allocation succeeds.
8528 * fns.c (concat): Check for overflow in size calculations.
8529 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8530 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8531 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8532
8533 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8534 (get_doc_string): Check for size calculation overflow.
8535 Don't update size until allocation succeeds.
8536 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8537 EMACS_INT, where ptrdiff_t will do.
8538 (Fsubstitute_command_keys): Check for string overflow.
8539
8540 * editfns.c (set_time_zone_rule): Don't assume environment length
8541 fits in int.
8542 (message_length): Now ptrdiff_t, not int.
8543 (Fmessage_box): Don't update size until allocation succeeds.
8544 Don't assume message length fits in int.
8545 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8546
0065d054
PE
8547 * emacs.c (main): Do not reallocate argv, since there is a null at
8548 the end that can be overwritten, and this way there's no need to
8549 worry about size-calculation overflow.
8550 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8551
8552 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8553 alloc succeeds.
8554 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8555
8556 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8557 (x_set_scroll_bar_width, x_figure_window_size):
8558 Check for integer overflow.
8559 (x_set_alpha): Do not assume XINT fits in int.
8560
8561 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8562 This is for the members text_lines, text_cols, total_lines, total_cols,
8563 where the system imposes an 'int' limit.
8564
8565 * fringe.c (Fdefine_fringe_bitmap):
8566 Don't update size until alloc works.
8567
8568 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8569 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8570
8571 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8572 Check for size-calculation overflow.
8573 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8574 do, as we prefer signed integers.
8575 (id_to_widget.max_size, id_to_widget.used)
8576 (xg_store_widget_in_map, xg_remove_widget_from_map)
8577 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8578 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8579 Use and return ptrdiff_t, not int.
8580 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8581 * gtkutil.h: Change prototypes to match the above.
8582
8583 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8584 are duplicate now that they've been promoted to lisp.h.
8585 (x_allocate_bitmap_record, x_alloc_image_color)
8586 (make_image_cache, cache_image, xpm_load):
8587 Don't update size until alloc is done.
8588 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8589 (x_detect_edges):
3256efce 8590 Check for size calculation overflow.
726e0ab1
PE
8591 (ct_colors_allocated_max): New constant.
8592 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8593 overflow.
3256efce 8594
726e0ab1
PE
8595 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8596 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8597 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8598 Use ptrdiff_t, not int, to count maps.
8599 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8600 calculations. Don't update size until allocation succeeds.
8601 Redo calculations to avoid overflow.
726e0ab1
PE
8602 * keyboard.h: Change prototypes to match the above.
8603
8604 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8605 to count maps.
8606 (current_minor_maps): Check for size calculation overflow.
8607 * keymap.h: Change prototypes to match the above.
8608
8609 * lread.c (read1, init_obarray): Don't update size until alloc done.
8610
8611 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8612 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8613
726e0ab1
PE
8614 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8615 Now ptrdiff_t, not int.
8616 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8617 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8618
8619 * process.c (Fnetwork_interface_list): Check for overflow
8620 in size calculation.
8621
8622 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8623
8624 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8625 overflow. Don't bother calling xmalloc when xrealloc will do.
8626
8627 * search.c (Freplace_match): Check for size calculation overflow.
8628 (Fset_match_data): Don't assume list lengths fit in 'int'.
8629
8630 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8631 for command line length. Do not attempt to address one before the
8632 beginning of an array, as that's not portable.
8633
8634 * term.c (max_frame_lines): Remove; unused.
8635 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8636 not int.
8637 (encode_terminal_code, calculate_costs): Check for size
8638 calculation overflow.
8639 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8640 table lengths and related sizes. Don't update size until alloc
8641 done. Redo calculations to avoid overflow.
8642 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8643
8644 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8645 subtracting pointers.
8646 (gobble_line): Check for overflow more carefully. Don't update size
8647 until alloc done.
8648
8649 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8650 Don't update size until alloc done.
8651 Redo size calculations to avoid overflow.
8652 Check for size calculation overflow.
0065d054 8653 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8654
8655 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8656 Use ptrdiff_t, not int, for sizes.
8657 (store_mode_line_noprop_char): Don't update size until alloc done.
8658
0065d054
PE
8659 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8660 Use ptrdiff_t, not int, for sizes.
8661 (Finternal_make_lisp_face, cache_face):
8662 Check for size calculation overflow.
8663 (cache_face): Treat size calculation overflows as if they were
8664 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8665
8666 * xfns.c (x_encode_text, x_set_name_internal)
8667 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8668 sizes, since they can exceed INT_MAX in size. Check for size
8669 calculation overflow.
8670
0065d054
PE
8671 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8672 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8673 Don't update size until alloc done.
8674
0065d054 8675 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8676 as sprintf is limited to int lengths.
1d526e2f 8677
252c5ee1
PE
8678 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8679 (X_LONG_MIN): New macros.
864d7ce7
PE
8680 Use them to make the following changes clearer.
8681 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8682 This change doesn't affect the value now, but it may help remind
8683 future maintainers not to raise the value too much later.
8684 (SELECTION_QUANTUM): Remove, replacing with ...
8685 (selection_quantum): ... new function, which avoids overflow.
8686 All uses changed.
8687 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8688 assumption that selection length fits in 'int'.
8689 (x_reply_selection_request, x_handle_selection_request)
8690 (x_get_window_property, receive_incremental_selection)
8691 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8692 (lisp_data_to_selection_data, clean_local_selection_data):
8693 Use ptrdiff_t, not int, to record length of selection.
8694 (x_reply_selection_request, x_get_window_property)
8695 (receive_incremental_selection, x_property_data_to_lisp):
8696 Redo calculations to avoid overflow.
8697 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8698 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8699 something.
8700 (x_get_window_property, receive_incremental_selection)
8701 (lisp_data_to_selection_data, x_property_data_to_lisp):
8702 Check for size-calculation overflow.
8703 (x_get_window_property, receive_incremental_selection)
8704 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8705 Don't store size until memory allocation succeeds.
8706 (x_get_window_property): Plug memory leak on memory exhaustion.
8707 Don't double-block input; malloc is safe here. Don't assume 2**34
8708 - 4 fits in unsigned long. Add an xassert to check
8709 XGetWindowProperty overflow. Be more careful about overflow
8710 calculations, and distinguish size from memory overflow better.
8711 (receive_incremental_selection): When tracing, don't assume
8712 unsigned int is less than INT_MAX.
8713 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8714 harmful) conversions of unsigned short to int.
8715 (lisp_data_to_selection_data): Don't assume that integers
8716 in the range -65535 through -1 fit in an X unsigned short.
8717 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8718 result parameters unless successful. Rely on cons_to_unsigned
8719 to report problems with elements; the old code wasn't right anyway.
8720 (x_check_property_data): Check for int overflow; we cannot use
8721 a wider type due to X limits.
8722 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8723
726e0ab1 8724 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8725
0065d054
PE
8726 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8727 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8728 (x_color_cells): Don't store size until memory allocation succeeds.
8729 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8730 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8731 (x_term_init): Don't assume length fits in int (sprintf is limited
8732 to int size).
bc18e09d 8733
ebfa62c0
PE
8734 Use ptrdiff_t for composition IDs.
8735 * character.c (lisp_string_width):
8736 * composite.c (composition_table_size, n_compositions)
8737 (get_composition_id, composition_gstring_from_id):
8738 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8739 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8740 * window.c (Frecenter):
8741 Use ptrdiff_t, not int, for composition IDs.
8742 * composite.c (get_composition_id): Check for integer overflow.
8743 * composite.h: Adjust prototypes to match the above changes.
8744
d3411f89
PE
8745 Use ptrdiff_t for hash table indexes.
8746 * category.c (hash_get_category_set):
8747 * ccl.c (ccl_driver):
8748 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8749 * coding.c (coding_system_charset_list, detect_coding_system):
8750 * coding.h (struct coding_system.id):
8751 * composite.c (get_composition_id, gstring_lookup_cache):
8752 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8753 * image.c (xpm_get_color_table_h):
8754 * lisp.h (hash_lookup, hash_put):
8755 * minibuf.c (Ftest_completion):
8756 Use ptrdiff_t for hash table indexes, not int (which is too
8757 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8758 32-bit --with-wide-int hosts).
8759
e097a6fa
PE
8760 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8761 Add a FIXME comment about memory leaks.
8762 (syms_of_charset): Don't assume xmalloc returns.
8763
5637687f
PE
8764 Don't assume that stated character widths fit in int.
8765 * character.c (Fchar_width, c_string_width, lisp_string_width):
8766 * character.h (CHAR_WIDTH):
8767 * indent.c (MULTIBYTE_BYTES_WIDTH):
8768 Use sanitize_char_width to avoid undefined and/or bad behavior
8769 with outlandish widths.
a66cfb1c 8770 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8771 now that we have two such functions. All uses changed.
8772 (sanitize_char_width): New inline function.
8773
a2271ba2
PE
8774 Don't assume that tab-width fits in int.
8775 * character.h (sanitize_width): New inline function.
8776 (SANE_TAB_WIDTH): New macro.
8777 (ASCII_CHAR_WIDTH): Use it.
8778 * indent.c (sane_tab_width): Remove. All uses replaced by
8779 SANE_TAB_WIDTH (current_buffer).
8780 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8781
18c52557
PE
8782 * fileio.c: Integer overflow issues with file modes.
8783 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8784
caeeedc1
PE
8785 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8786 Remove unreachable code.
8787 (read_hex, load_charset_map_from_file): Check for integer overflow.
8788
6df6ae42 8789 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8790 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8791 (x_send_scroll_bar_event): Likewise. Check that the size does not
8792 exceed limits imposed by XClientMessageEvent, as well as the usual
8793 ptrdiff_t and size_t limits.
8794
b13995db
PE
8795 * keyboard.c: Overflow, signedness and related fixes.
8796 (make_lispy_movement): Use same integer type in forward decl
8797 that is used in the definition.
8798 (read_key_sequence, keyremap_step):
8799 Change bufsize argument back to int, undoing my 2011-03-30 change.
8800 We prefer signed types, and int is wide enough here.
8801 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8802 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8803 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8804 length, not size_t. Use ptrdiff_t for index, not int.
8805 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8806 possibility of integer overflow.
8807
13464394
PE
8808 Overflow, signedness and related fixes for images.
8809
8810 * dispextern.h (struct it.stack[0].u.image.image_id)
8811 (struct_it.image_id, struct image.id, struct image_cache.size)
8812 (struct image_cache.used, struct image_cache.ref_count):
8813 * gtkutil.c (update_frame_tool_bar):
8814 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8815 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8816 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8817 * nsmenu.m (update_frame_tool_bar):
8818 * xdisp.c (calc_pixel_width_or_height):
8819 * xfns.c (image_cache_refcount):
8820 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8821 on typical 64-bit hosts.
8822
8823 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8824 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8825 Omit unnecessary casts to int.
8826 (parse_image_spec): Check that integers fall into 'int' range
8827 when the callers expect that.
8828 (image_ascent): Redo ascent calculation to avoid int overflow.
8829 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8830 (lookup_image): Remove unnecessary tests.
8831 (xbm_image_p): Locals are now of int, not EMACS_INT,
8832 since parse_image_check makes sure they fit into int.
8833 (png_load, gif_load, svg_load_image):
8834 Prefer int to unsigned where either will do.
8835 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8836 old tiff_error_handler and tiff_warning_handler.
8837 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8838 stack buffer overflows. It uses only the features of vsnprintf
8839 that are common to both POSIX and native Microsoft.
8840 (tiff_error_handler, tiff_warning_handler): Use it.
8841 (tiff_load, gif_load, imagemagick_load_image):
8842 Don't assume :index value fits in 'int'.
8843 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8844 (imagemagick_load_image): Check that crop parameters fit into
8845 the integer types that MagickCropImage accepts. Don't assume
8846 Vimagemagick_render_type has a nonnegative value. Don't assume
8847 size_t fits in 'long'.
8848 (gs_load): Use printmax_t to print the widest integers possible.
8849 Check for integer overflow when computing image height and width.
8850
c11821d4
EZ
88512011-08-26 Eli Zaretskii <eliz@gnu.org>
8852
8853 * xdisp.c (redisplay_window): Don't force window start if point
8854 will be invisible in the resulting window. (Bug#9324)
8855
0c95fcf7
EZ
88562011-08-25 Eli Zaretskii <eliz@gnu.org>
8857
8858 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8859 the display spec is of the form `(space ...)'.
8860 (handle_display_spec): Return the value returned by
8861 handle_single_display_spec, not just 1 or zero.
8862 (handle_single_display_spec): If the display spec is of the form
8863 `(space ...)', and specifies display in the text area, return 2
8864 rather than 1.
fee65a97 8865 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8866 accurately, and prefer exact match for point under bidi.
8867 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8868
8869 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8870 into disp_prop; all users changed.
8871
8872 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8873 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8874 for the text covered by the display property.
8875
e4ed06f1
CY
88762011-08-25 Chong Yidong <cyd@stupidchicken.com>
8877
8878 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8879 Change return value to nil.
8880 (Frecord_buffer): Delete unused function.
8881
f67cdd7f
EZ
88822011-08-24 Eli Zaretskii <eliz@gnu.org>
8883
5980d4c6
EZ
8884 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8885 buffers, return left-to-right.
8610fe8b
EZ
8886 (set_cursor_from_row): Consider candidate row a win if its glyph
8887 represents a newline and point is on that newline. Fixes cursor
8888 positioning on the newline at EOL of R2L text within L2R
8889 paragraph, and vice versa.
8890 (try_cursor_movement): Check continued rows, in addition to
8891 continuation rows. Fixes unwarranted scroll when point enters a
8892 continued line of R2L text within an L2R paragraph, or vice versa.
8893 (cursor_row_p): Consider the case of point being equal to
8894 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8895 from the end of a short line to the beginning of a continued line
8896 of R2L text within L2R paragraph.
8897 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8898 composed characters.
5980d4c6 8899
f67cdd7f
EZ
8900 * bidi.c (bidi_check_type): Use xassert.
8901 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8902 members.
8903
bca633fb
EZ
89042011-08-23 Eli Zaretskii <eliz@gnu.org>
8905
8906 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8907 a character.
8908
4a5885a7
CY
89092011-08-23 Chong Yidong <cyd@stupidchicken.com>
8910
8911 * nsfont.m (ns_otf_to_script): Fix typo.
8912
0902a04e
KH
89132011-08-22 Kenichi Handa <handa@m17n.org>
8914
8915 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8916 extra slot even if the purpose is char-code-property-table.
8917
1a2e6670
EZ
89182011-08-23 Eli Zaretskii <eliz@gnu.org>
8919
8ddde651
EZ
8920 * xdisp.c (redisplay_window): When computing centering_position,
8921 account for the height of the header line. (Bug#8874)
8922
425cc014
EZ
8923 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8924 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8925 candidate is selected by the mouse, and that candidate has a
8926 composed character under the mouse.
8927
1a2e6670
EZ
8928 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8929 coordinates reported by pos-visible-in-window-p for a composed
8930 character in column zero.
8931
8b76d6f8
SM
89322011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8933
8934 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8935
dac347dd
EZ
89362011-08-22 Eli Zaretskii <eliz@gnu.org>
8937
8938 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8939 consider it a hit if to_charpos is anywhere in the range of the
8940 composed buffer positions.
8941
e013fb34
CY
89422011-08-22 Chong Yidong <cyd@stupidchicken.com>
8943
8944 * image.c (gif_load): Don't assume that each subimage has the same
8945 dimensions as the base image. Handle disposal method that is
8946 "undefined" by the gif spec (Bug#9335).
8947
bd1ba3e8
CY
89482011-08-20 Chong Yidong <cyd@stupidchicken.com>
8949
8950 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8951 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8952
54a1215b
EZ
89532011-08-19 Eli Zaretskii <eliz@gnu.org>
8954
823564e5
EZ
8955 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8956 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8957 from an Org mode buffer to a Speedbar frame.
8958
54a1215b
EZ
8959 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8960 a composition, take its buffer position from IT->cmp_it.charpos.
8961 Fixes cursor positioning at the beginning of a line that begins
8962 with a composed character.
8963
9778ebcc
EZ
89642011-08-18 Eli Zaretskii <eliz@gnu.org>
8965
0be6ee06
EZ
8966 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8967 character bidirectional type, use STRONG_L instead. Fixes crashes
8968 in a buffer produced by `describe-categories'.
8969
9778ebcc
EZ
8970 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8971 members before the level stack, so they would be saved and
8972 restored when copying iterator state. Fixes incorrect reordering
8973 around TABs covered by display properties.
8974
156bffbe
AS
89752011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8976
6b02f655 8977 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8978
72ad093b
CY
89792011-08-17 Chong Yidong <cyd@stupidchicken.com>
8980
8981 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8982 (internal_condition_case_2, internal_condition_case_n):
8983 Remove unnecessary aborts (Bug#9081).
72ad093b 8984
35774242
EZ
89852011-08-17 Eli Zaretskii <eliz@gnu.org>
8986
8987 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8988 has no `load' handler, try opening the file locally. (Bug#9311)
8989
db76dd85
KB
89902011-08-16 Ken Brown <kbrown@cornell.edu>
8991
8992 * gmalloc.c: Expand comment.
8993
b215eee5
EZ
89942011-08-16 Eli Zaretskii <eliz@gnu.org>
8995
8996 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8997 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8998
a4579d33
KB
89992011-08-16 Ken Brown <kbrown@cornell.edu>
9000
9001 Fix memory allocation problems in Cygwin build (Bug#9273).
9002
9003 * unexcw.c ( __malloc_initialized): Declare external variable.
9004 (fixup_executable): Force the dumped emacs to reinitialize malloc.
9005
8b76d6f8
SM
9006 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
9007 New variables.
a4579d33
KB
9008 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
9009 dumped emacs.
9010 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
9011 in the static heap.
9012 [CYGWIN] (special_realloc): New function.
9013 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
9014 requests to realloc storage in the static heap.
9015
3ebec551
PE
90162011-08-15 Paul Eggert <eggert@cs.ucla.edu>
9017
9018 * bidi.c (bidi_initialize): Remove unused local.
9019
9fd8be00
EZ
90202011-08-15 Eli Zaretskii <eliz@gnu.org>
9021
6b02f655
SM
9022 * bidimirror.h:
9023 * biditype.h: Remove file.
9024 * makefile.w32-in ($(BLD)/bidi.$(O)):
9025 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
9026
9027 * dispextern.h: Fix a typo in the comment to bidi_type_t.
9028
9029 * chartab.c: Improve commentary for the uniprop_table API.
9030
32413314
EZ
9031 * bidi.c (bidi_paragraph_init): Support zero value of
9032 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
9033 (bidi_initialize): Use uniprop_table instead of including
9034 biditype.h and bidimirror.h.
32413314 9035
9fd8be00
EZ
9036 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
9037 coordinates of the iterator when restoring from ppos_it.
9038 (Bug#9296)
9039
5cf2b69b
KH
90402011-08-14 Kenichi Handa <handa@m17n.org>
9041
9042 * process.c (create_process): Call setup_process_coding_systems
72ad093b 9043 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 9044
daf17d00
EZ
90452011-08-14 Eli Zaretskii <eliz@gnu.org>
9046
9047 * xdisp.c (move_it_in_display_line_to): Don't invoke
9048 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
9049 ppos_it. Fixes vertical cursor motion when line beginning is
9050 covered by an image. (Bug#9296)
9051
08e3161a
JD
90522011-08-14 Jan Djärv <jan.h.d@swipnet.se>
9053
9054 * nsterm.h (ns_run_ascript): Declare.
9055 (NSAPP_DATA2_RUNASSCRIPT): Define.
9056
9057 * nsfns.m (as_script, as_result, as_status): New static variables.
9058 (ns_run_ascript): New function.
5e617bc2 9059 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
9060 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
9061 the event loop. Get status from as_status (Bug#7276).
9062
9063 * nsterm.m (sendEvent): If event is NSApplicationDefined and
9064 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
9065 the event loop (Bug#7276).
9066
a3720aa2
AS
90672011-08-14 Andreas Schwab <schwab@linux-m68k.org>
9068
9069 * gnutls.c (QCgnutls_bootprop_priority)
9070 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
9071 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
9072 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
9073 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
9074 (QCgnutls_bootprop_verify_hostname_error)
9075 (QCgnutls_bootprop_callbacks_verify): Rename from
9076 Qgnutls_bootprop_..., all uses changed.
9077
9078 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
9079 uses changed.
9080
0a0d27fb
PE
90812011-08-14 Paul Eggert <eggert@cs.ucla.edu>
9082
19d5c50c
PE
9083 * xfaces.c (Qframe_set_background_mode): Now static.
9084 * dispextern.h (Qframe_set_background_mode): Remove decl.
9085
0a0d27fb
PE
9086 * process.c (Fnetwork_interface_info): Declare local only if needed.
9087
377538cb
JD
90882011-08-13 Jan Djärv <jan.h.d@swipnet.se>
9089
9090 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
9091 (Fnetwork_interface_list): Allocate in increments of bytes instead
9092 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
9093 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
9094 sockaddr.
9095 (struct ifflag_def): notrailers is smart on OSX.
9096 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
9097 Get hardware address with getifaddrs if available.
9098
08fff70c
EZ
90992011-08-12 Eli Zaretskii <eliz@gnu.org>
9100
9101 * xdisp.c (iterate_out_of_display_property): xassert that
9102 IT->position is set to within IT->object's boundaries. Break from
9103 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
9104 when IT->position is set up wrongly due to some bug.
9105 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
9106 (push_display_prop): Allow GET_FROM_STRING as IT->method on
9107 entry. Force push_it to save on the stack the current
9108 buffer/string position, to be restored by pop_it. Fix flags in
9109 the iterator structure wrt the object coming from a display
9110 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
9111 properties. (Bug#9284)
9112
7be1c708 91132011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 9114
7be1c708
CY
9115 * fontset.c (fontset_get_font_group): Add proper type checks.
9116 (Bug#9172)
aac0c6e3 9117
7be1c708 91182011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 9119
7be1c708
CY
9120 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
9121 and LC_VERSION_MIN_MACOSX.
9122 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
9123 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 9124
97bb72a6
EZ
91252011-08-08 Eli Zaretskii <eliz@gnu.org>
9126
9127 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
9128 no-display-properties-and-no-overlays under bidi display.
9129 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 9130 properties and overlays.
97bb72a6 9131
d5617611
CY
91322011-08-08 Chong Yidong <cyd@stupidchicken.com>
9133
37e11a63
CY
9134 * editfns.c (Fset_time_zone_rule): Document relationship with the
9135 setenv function.
9136
d5617611
CY
9137 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
9138 the font entity extracted from the cache (Bug#8109).
9139
58872834
CY
91402011-08-07 Chong Yidong <cyd@stupidchicken.com>
9141
9142 * composite.c (autocmp_chars): Don't reset point. That is done by
9143 restore_point_unwind (Bug#5984).
9144
75bfc667
JL
91452011-08-07 Juri Linkov <juri@jurta.org>
9146
9147 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
9148 to show the arg `TIME' instead of `TIMEVAL'.
9149
d1410150
EZ
91502011-08-06 Eli Zaretskii <eliz@gnu.org>
9151
9152 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9153 display property strides EOL and includes a newline, as in
9154 longlines-mode. (Bug#9254)
75b771e4
EZ
9155 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
9156 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
9157
9158 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
9159 is non-zero, even if the data buffer is NULL. Fixes a crash in
9160 vertical-motion with longlines-mode. (Bug#9254)
9161
35928349
EZ
91622011-08-05 Eli Zaretskii <eliz@gnu.org>
9163
ec7cc85b
EZ
9164 * bidi.c <bidi_cache_total_alloc>: Now static.
9165 (bidi_initialize): Initialize bidi_cache_total_alloc.
9166
8b76d6f8 9167 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9168 cache. (Bug#9221)
9169
9170 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9171 amount allocated this far in `bidi_cache_total_alloc'.
9172 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9173 non-zero, only free the data buffer without restoring the cache
9174 contents. All callers changed.
9175
9176 * dispextern.h (bidi_unshelve_cache): Update prototype.
9177
9178 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9179 (move_it_in_display_line, move_it_to)
9180 (move_it_vertically_backward, move_it_by_lines): Replace the call
9181 to xfree to an equivalent call to bidi_unshelve_cache.
9182 (move_it_in_display_line_to): Fix logic of returning
412b6358 9183 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9184
e2e2423b
EZ
91852011-08-05 Eli Zaretskii <eliz@gnu.org>
9186
9187 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9188 came from a string character with a `cursor' property. (Bug#9229)
9189
ae9e757a
JD
91902011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9191
9192 * Makefile.in (LIB_PTHREAD): New variable.
9193 (LIBES): Add LIB_PTHREAD (Bug#9216).
9194
9195 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9196 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9197
213bd7f2
AS
91982011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9199
6b02f655 9200 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9201
99aaf75f
JD
92022011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9203
9204 * xterm.c (x_find_topmost_parent): New function.
9205 (x_set_frame_alpha): Find topmost parent window with
9206 x_find_topmost_parent and set the property there also (bug#9181).
9207 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9208
c74e9d86
PE
92092011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9210
9211 * callproc.c (Fcall_process): Avoid vfork clobbering
9212 the local vars buffer, coding_systems, current_dir.
9213
640c8776
SM
92142011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9215
9216 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9217
f26d0e4c
PE
92182011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9219
8a10d76c
PE
9220 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9221 so that it is not optimized away.
9222
f26d0e4c
PE
9223 * xdisp.c (compute_display_string_pos): Remove unused local.
9224
55439c61
EZ
92252011-08-02 Eli Zaretskii <eliz@gnu.org>
9226
9227 Fix slow cursor motion and scrolling in large buffers with
9228 selective display, like Org Mode buffers. (Bug#9218)
9229
9230 * dispextern.h (struct bidi_it): New member disp_prop_p.
9231
9232 * xdisp.c: Remove one-slot cache of display string positions.
9233 (compute_display_string_pos): Accept an additional argument
5e617bc2 9234 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9235 for a display string or property. If found, set DISP_PROP_P
9236 non-zero.
9237
9238 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9239 DISP_PROP_P, and pass it to compute_display_string_pos.
9240 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9241 non-zero. All callers of bidi_fetch_char changed.
9242
fb33fa43
SM
92432011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9244
9245 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9246
b099e063
DM
92472010-12-03 Don March <don@ohspite.net>
9248
9249 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9250 last character M-[char] is translated to ESC [char] (bug#7541).
9251
5cc7f7af
KH
92522011-08-02 Kenichi Handa <handa@m17n.org>
9253
d0fffa3f 9254 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9255
9256 * chartab.c (uniprop_table): Make it non-static.
9257
525d5e6e
EZ
92582011-08-01 Eli Zaretskii <eliz@gnu.org>
9259
9260 * xdisp.c (forward_to_next_line_start): Accept additional argument
9261 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9262 on the newline.
9263 (reseat_at_next_visible_line_start): Use the bidi iterator state
9264 returned by forward_to_next_line_start to restore the state of
9265 it->bidi_it after backing up to previous newline. (Bug#9212)
9266
31011111
AS
92672011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9268
9269 * regex.c (re_comp): Protoize.
9270 (re_exec): Fix return type.
9271 (regexec): Fix type of `ret'. (Bug#9203)
9272
476371c4
PE
92732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9274
e5d76069
PE
9275 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9276 This is needed if max-image-size is a floating-point number.
9277
9a79b20c
AS
92782011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9279
9280 * print.c (print_object): Print empty symbol as ##.
9281
9282 * lread.c (read1): Read ## as empty symbol.
9283
d8c2fa78
AA
92842011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9285
9286 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9287 setting frame foreground color (Bug#9175).
9288 (x_set_background_color): Likewise.
9289
ffe57a7a
AA
9290 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9291 contents (Bug#9176).
9292 (EmacsTooltip -init): Remove bezels and add shadows to
9293 tooltip windows.
9294
bf3492a5
AA
9295 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9296 or scroll bar (Bug#8470).
9297
d55e9c53
AA
9298 * nsfont.m (nsfont_open): Remove assignment to voffset and
9299 unnecessary vars hshink, expand, hd, full_height, min_height.
9300 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9301
9302 * nsterm.h (nsfont_info): Remove voffset field.
9303
d8c2fa78 93042011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9305
9306 Implement strike-through and overline on NextStep (Bug#8863).
9307
9308 * nsfont.m (nsfont_open): Use underline position provided by font,
9309 instead of hard-coded value of 2.
9310 (nsfont_draw): Call ns_draw_text_decoration instead.
9311
9312 * nsterm.h: Add declaration for ns_draw_text_decoration.
9313
9314 * nsterm.m (ns_draw_text_decoration): New function for drawing
9315 underline, overline, and strike-through.
9316 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9317 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9318 accommodate underlining, etc.
4843aac3 9319
4cc60b9b
EZ
93202011-07-28 Eli Zaretskii <eliz@gnu.org>
9321
bc7ece87
EZ
9322 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9323 default.
4cc60b9b 9324
476371c4
PE
93252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9326
66606eea
PE
9327 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9328 Without this fix, if a signal arrives just after memory fills up,
9329 'malloc' might be invoked reentrantly.
9330
476371c4
PE
9331 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9332 In other words, assume that every image size is allowed, on non-X
9333 hosts. This assumption is probably wrong, but it lets Emacs compile.
9334
f3fcc40d
AS
93352011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9336
9337 * regex.c (re_iswctype): Convert return values to boolean.
9338
350c992f
EZ
93392011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9340
9341 * xdisp.c (compute_display_string_pos): Don't use cached display
9342 string position if the buffer had its restriction changed.
9343 (Bug#9184)
9344
5266b4bb
PE
93452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9346
9347 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9348
2573a837 93492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9350
41f55ccd 9351 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9352
39e378da
PE
9353 * bidi.c: Integer size and overflow fixes.
9354 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9355 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9356 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9357 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9358 (bidi_find_other_level_edge):
9359 Use ptrdiff_t instead of EMACS_INT where either will do.
9360 This works better on 32-bit hosts configured --with-wide-int.
9361 (bidi_cache_ensure_space): Check for size-calculation overflow.
9362 Use % rather than repeated addition, for better worst-case speed.
9363 Don't set bidi_cache_size until after xrealloc returns, because it
9364 might not return.
9365 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9366 (bidi_cache_ensure_space): Also check that the bidi cache size
9367 does not exceed that of the largest Lisp string or buffer. See Eli
9368 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9369
5e927815
PE
9370 * alloc.c (__malloc_size_t): Remove.
9371 All uses replaced by size_t. See Andreas Schwab's note
9372 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9373
ca4aa935
PE
9374 * image.c: Improve checking for integer overflow.
9375 (check_image_size): Assume that f is nonnull, since
9376 it is always nonnull in practice. This is one less thing to
9377 worry about when checking for integer overflow later.
9378 (x_check_image_size): New function, which checks for integer
9379 overflow issues inside X.
9380 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9381 This removes the need for a memory_full check.
9382 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9383 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9384 (xbm_read_bitmap_data): Change locals back to 'int', since
9385 their values must fit in 'int'.
9386 (xpm_load_image, png_load, tiff_load):
9387 Invoke x_create_x_image_and_pixmap earlier,
9388 to avoid much needless work if the image is too large.
9389 (tiff_load): Treat overly large images as if
9390 x_create_x_image_and_pixmap failed, not as malloc failures.
9391 (gs_load): Use x_check_image_size.
9392
5f8f9cc2
PE
9393 * gtkutil.c: Omit integer casts.
9394 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9395 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9396
5adf60bc
PE
9397 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9398
c8907a93
PE
9399 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9400 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9401 would wrongly return t on a 64-bit host.
9402
e3c25c68
PE
9403 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9404 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9405 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9406 and therefore cause GCC to emit a bogus diagnostic in some cases.
9407
3f791afe
PE
9408 * image.c: Integer signedness and overflow and related fixes.
9409 This is not an exhaustive set of fixes, but it's time to
9410 record what I've got.
9411 (lookup_pixel_color, check_image_size): Remove redundant decls.
9412 (check_image_size): Don't assume that arbitrary EMACS_INT values
9413 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9414 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9415 (tiff_load, imagemagick_load_image):
9416 Check for overflow in size calculations.
9417 (x_create_x_image_and_pixmap): Remove unnecessary test for
9418 xmalloc returning NULL; that can't happen.
9419 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9420 (xpm_color_bucket): Use better integer hashing function.
9421 (xpm_cache_color): Don't possibly over-allocate memory.
9422 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9423 (gif_memory_source):
9424 Use ptrdiff_t, not int or size_t, to record sizes.
9425 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9426 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9427 either works, as we prefer signed integers.
9428 (tiff_read_from_memory, tiff_write_from_memory):
9429 Return tsize_t, not size_t, since that's what the TIFF API wants.
9430 (tiff_read_from_memory): Don't fail simply because the read would
9431 go past EOF; instead, return a short read.
9432 (tiff_load): Omit no-longer-needed casts.
9433 (Fimagemagick_types): Don't assume size fits into 'int'.
9434
3cc5a532
PE
9435 Improve hashing quality when configured --with-wide-int.
9436 * fns.c (hash_string): New function, taken from sxhash_string.
9437 Do not discard information about ASCII character case; this
9438 discarding is no longer needed.
9439 (sxhash-string): Use it. Change sig to match it. Caller changed.
9440 * lisp.h: Declare it.
9441 * lread.c (hash_string): Remove, since we now use fns.c's version.
9442 The fns.c version returns a wider integer if --with-wide-int is
9443 specified, so this should help the quality of the hashing a bit.
9444
b312a492
PE
9445 * emacs.c: Integer overflow minor fix.
9446 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9447 Define only if GNU_LINUX.
9448 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9449
dfd153ae
PE
9450 * dispnew.c: Integer signedness and overflow fixes.
9451 Remove unnecessary forward decls, that were a maintenance hassle.
9452 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9453 All uses changed.
9454 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9455 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9456 (prepare_desired_row, line_draw_cost):
9457 Use int, not unsigned, where either works.
9458 (save_current_matrix, restore_current_matrix):
9459 Use ptrdiff_t, not size_t, where either works.
9460 (init_display): Check for overflow more accurately, and without
9461 relying on undefined behavior.
9462
a81d11a3
PE
9463 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9464 Remove, replacing with the new symbols in lisp.h. All uses changed.
9465 * fileio.c (make_temp_name):
9466 * filelock.c (lock_file_1, lock_file):
9467 * xdisp.c (message_dolog):
9468 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9469 Use pMd etc. instead.
9470 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9471 replacing the pWIDE etc. symbols removed from editfns.c.
9472
3300e6fd
PE
9473 * keyboard.h (num_input_events): Now uintmax_t.
9474 This is (very slightly) less likely to mess up due to wraparound.
9475 All uses changed.
9476
fd05c7e9
PE
9477 * buffer.c: Integer signedness fixes.
9478 (alloc_buffer_text, enlarge_buffer_text):
9479 Use ptrdiff_t rather than size_t when either will do, as we prefer
9480 signed integers.
9481
903fe15d
PE
9482 * alloc.c: Integer signedness and overflow fixes.
9483 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9484 (__malloc_size_t): Default to size_t, not to int.
9485 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9486 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9487 Prefer ptrdiff_t to size_t when either would do, as we prefer
9488 signed integers.
9489 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9490 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9491 Now const. Initialize with values that are in range even if char
9492 is signed.
9493 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9494 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9495 These functions do the right thing with sizes > 2**32.
9496 (check_depth): Now ptrdiff_t, not int.
9497 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9498 Adjust to new way of storing sizes. Check for size overflow bugs
9499 in rest of code.
9500 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9501 slightly wrong anyway, as it missed one instance of
9502 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9503 (refill_memory_reserve): Omit needless cast to size_t.
9504 (mark_object_loop_halt): Mark as externally visible.
9505
ac82cc6a
PE
9506 * xselect.c: Integer signedness and overflow fixes.
9507 (Fx_register_dnd_atom, x_handle_dnd_message):
9508 Use ptrdiff_t, not size_t, since we prefer signed.
9509 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9510 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9511 x_dnd_atoms_size and x_dnd_atoms_length.
9512
c2d1e36d
PE
9513 * doprnt.c: Prefer signed to unsigned when either works.
9514 * eval.c (verror):
9515 * doprnt.c (doprnt):
9516 * lisp.h (doprnt):
9517 * xdisp.c (vmessage):
9518 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9519 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9520 prefer signed arithmetic to avoid comparison confusion.
9521 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9522 but is a bit tricky.
9523
0e926e56
PE
9524 Assume freestanding C89 headers, string.h, stdlib.h.
9525 * data.c, doprnt.c, floatfns.c, print.c:
9526 Include float.h unconditionally.
9527 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9528 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9529 * regex.c: Likewise for stddef.h, string.h.
9530 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9531 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9532 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9533 (STDC_HEADERS): Remove obsolete defines.
9534 * sysdep.c: Include limits.h unconditionally.
9535
9cfdb3ec
PE
9536 Assume support for memcmp, memcpy, memmove, memset.
9537 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9538 * regex.c (memcmp, memcpy):
9539 Remove; we assume C89 now.
9540
9541 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9542 (__malloc_safe_bcopy): Remove; no longer needed.
9543
cf950e6b 9544 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9545 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9546 well either way, and we prefer signed to unsigned.
9547
dbf38e02
LMI
95482011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9549
9550 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9551 closes the connection while we're reading (bug#9182).
9552
d6f0886c 95532011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9554
d6f0886c
JD
9555 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9556 are specified (Bug#9168).
24e0f6b1 9557
2eb1f9e6
PE
95582011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9559
9560 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9561 Found by GCC static checking and --with-wide-int on a 32-bit host.
9562
22381272 95632011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9564
9565 * xdisp.c (compute_display_string_pos): Fix logic of caching
9566 previous display string position. Initialize cached_prev_pos to
9567 -1. Fixes slow-down at the beginning of a buffer.
9568
f25e39b4
EZ
95692011-07-24 Eli Zaretskii <eliz@gnu.org>
9570
9571 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9572 for attrs[LFACE_FONTSET_INDEX].
9573
04c4b52e
PE
95742011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9575
9576 * xml.c (parse_region): Remove unused local
9577 that was recently introduced.
9578
c1734fbd
EZ
95792011-07-23 Eli Zaretskii <eliz@gnu.org>
9580
be18c5a5
EZ
9581 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9582 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9583
c1734fbd
EZ
9584 * xdisp.c (move_it_in_display_line_to): Record the best matching
9585 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9586 exit if none of the characters scanned was an exact match.
9587 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9588 when exact match is impossible due to invisible text, and the
9589 lines are truncated.
9590
a258d627
JD
95912011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9592
9593 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9594 for OSX >= 10.7.
9595
b6d5a689
EZ
95962011-07-22 Eli Zaretskii <eliz@gnu.org>
9597
0f74f785
EZ
9598 Fix a significant slow-down of cursor motion with C-n, C-p,
9599 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9600 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9601 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9602 (next_element_from_buffer): Call compute_stop_pos_backwards to
9603 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9604 base_level_stop.
9605 (reseat): Don't look for prev_stop, as that could mean a very long
9606 run.
9607 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9608 <cached_disp_overlay_modiff>: Cache for last found display string
9609 position.
551918c1 9610 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9611 about the same buffer in the same area of character positions, and
9612 the buffer wasn't changed since the time the display string
9613 position was cached.
551918c1 9614
b2d0c91a
EZ
96152011-07-22 Eli Zaretskii <eliz@gnu.org>
9616
9617 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9618 is an integer, which is important for empty lines. (Bug#9149)
9619
043604ee
CY
96202011-07-22 Chong Yidong <cyd@stupidchicken.com>
9621
9622 * frame.c (Fmodify_frame_parameters): In tty case, update the
9623 default face if necessary (Bug#4238).
9624
da4adb04
CY
96252011-07-21 Chong Yidong <cyd@stupidchicken.com>
9626
9627 * editfns.c (Fstring_to_char): No need to explain what a character
9628 is in the docstring (Bug#6576).
9629
9abd0532
LMI
96302011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9631
9632 * xml.c (parse_region): Make sure we always return a tree.
9633
36881d16
HK
96342011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9635
9636 * xml.c (parse_region): If a document contains only comments,
9637 return that, too.
9638
1e98674d
LMI
96392011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9640
9641 * xml.c (make_dom): Return comments, too.
9642
590bd467
PE
96432011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9644
9645 Port to OpenBSD.
9646 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9647 and the surrounding thread.
9648 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9649 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9650 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9651 timer goes off.
9652 * s/openbsd.h (BROKEN_SIGIO): Define.
9653 * unexelf.c (unexec) [__OpenBSD__]:
9654 Don't update the .mdebug section of the Alpha COFF symbol table.
9655
f41628b2
LMI
96562011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9657
9658 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9659 (bug#8460).
9660
b59b67c5
PE
96612011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9662
15e3a074
PE
9663 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9664 This fixes some race conditions on the permissions of any newly
9665 created file.
9666
41bed37d
PE
9667 * alloc.c (valid_pointer_p): Use pipe, not open.
9668 This fixes some permissions issues when debugging.
9669
b59b67c5
PE
9670 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9671 If fchown fails to set both uid and gid, try to set just gid,
9672 as that is sometimes allowed. Adjust the file's mode to eliminate
9673 setuid or setgid bits that are inappropriate if fchown fails.
9674
925a6be7
SM
96752011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9676
9677 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9678 to compare Lisp_Objects.
9679 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9680 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9681 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9682
52968808
AS
96832011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9684
0a6a104b
AS
9685 * lread.c (read_integer): Unread even EOF character.
9686 (read1): Likewise. Properly record start position of symbol.
9687
52968808
AS
9688 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9689 symbol character follows.
9690
9e381cdd
PE
96912011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9692
9693 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9694 This works around a problem with the previous change to Fcopy_file.
9695 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9696 and without this change, GCC might complain about discarding
9697 fchown's return value.
9698
b5641435
JB
96992011-07-16 Juanma Barranquero <lekktu@gmail.com>
9700
9701 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9702
a8031457
PE
97032011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9704
9705 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9706
dd889327
LMI
97072011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9708
750c33f7
LMI
9709 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9710 it's used from the C level.
9711
dd889327
LMI
9712 * process.c: Use the same condition for POLL_FOR_INPUT in both
9713 keyboard.c and process.c (bug#1858).
9714
87e86684
LM
97152011-07-09 Lawrence Mitchell <wence@gmx.li>
9716
9717 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9718 (Fgnutls_boot): Use it.
9719
64348f40
AS
97202011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9721
9722 * doc.c (Fsubstitute_command_keys): Revert last change.
9723
1d698799
LMI
97242011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9725
f863868c
LMI
9726 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9727 quotes the next character, and doesn't affect other longer
9728 sequences (bug#8935).
9729
1d698799
LMI
9730 * lread.c (syms_of_lread): Clarify that is isn't only
9731 `eval-buffer' and `eval-defun' that's affected by
9732 `lexical-binding' (bug#8460).
9733
aa4b6df6
EZ
97342011-07-15 Eli Zaretskii <eliz@gnu.org>
9735
9736 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9737 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9738
5d856da6
PE
97392011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9740
ad6042bb
PE
9741 Fix minor problems found by static checking.
9742 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9743 (elsz): Now a signed constant, not a size_t var. We prefer signed
9744 types to unsigned, to avoid integer comparison confusion. Without
9745 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9746 "cannot optimize loop, the loop counter may overflow", a symptom
9747 of the confusion.
f00bbb22 9748 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9749 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9750
6468f31c
LMI
97512011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9752
49080b10
LMI
9753 * search.c (Fre_search_backward): Mention `case-fold-search' in
9754 all the re_search_* functions (bug#8138).
9755
6468f31c
LMI
9756 * keyboard.c (Fopen_dribble_file): Document when the file is
9757 closed (bug#8056).
9758
c965adc5
EZ
97592011-07-14 Eli Zaretskii <eliz@gnu.org>
9760
df9733bf
EZ
9761 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9762 bidi_cache_idx.
9763
0bb23927
EZ
9764 Support bidi reordering of display and overlay strings.
9765 * xdisp.c (compute_display_string_pos)
9766 (compute_display_string_end): Accept additional argument STRING.
9767 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9768 (reseat_to_string): Initialize bidi_it->string.s and
9769 bidi_it->string.schars.
9770 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9771 NULL (avoids a crash in bidi_paragraph_init).
9772 Initialize itb.string.lstring.
0bb23927
EZ
9773 (init_iterator): Call bidi_init_it only of a valid
9774 buffer position was specified. Initialize paragraph_embedding to
9775 L2R.
9776 (reseat_to_string): Initialize the bidi iterator.
9777 (display_string): If we need to ignore text properties of
9778 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9779 original value of -1 will not work with bidi.)
9780 (compute_display_string_pos): First arg is now struct
9781 `text_pos *'; all callers changed. Support display properties on
9782 Lisp strings.
9783 (compute_display_string_end): Support display properties on Lisp
9784 strings.
9785 (init_iterator, reseat_1, reseat_to_string): Initialize the
9786 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9787 when iterating on a string not from display properties).
640c8776
SM
9788 (compute_display_string_pos, compute_display_string_end):
9789 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9790 arrow keys.
9791 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9792 base_level_stop; instead, set base_level_stop to BEGV.
9793 Fixes crashes in vertical-motion.
0bb23927
EZ
9794 (next_element_from_buffer): Improve commentary for when
9795 the iterator is before prev_stop.
9796 (init_iterator): Initialize bidi_p from the default value of
9797 bidi-display-reordering, not from buffer-local value. Use the
9798 buffer-local value only if initializing for buffer iteration.
9799 (handle_invisible_prop): Support invisible properties on strings
9800 that are being bidi-reordered.
9801 (set_iterator_to_next): Support bidi reordering of C strings and
9802 Lisp strings.
9803 (next_element_from_string): Support bidi reordering of Lisp
9804 strings.
9805 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9806 (display_string): Support display of R2L glyph rows.
9807 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9808 (init_iterator): Don't initialize it->bidi_p for strings
9809 here.
9810 (reseat_to_string): Initialize it->bidi_p for strings here.
9811 (next_element_from_string, next_element_from_c_string)
9812 (next_element_from_buffer): Add xassert's for correspondence
9813 between IT's object being iterated and it->bidi_it.string
9814 structure.
9815 (face_before_or_after_it_pos): Support bidi iteration.
9816 (next_element_from_c_string): Handle the case of the first string
9817 character that is not the first one in the visual order.
9818 (get_visually_first_element): New function, refactored from common
9819 parts of next_element_from_buffer, next_element_from_string, and
9820 next_element_from_c_string.
9821 (tool_bar_lines_needed, redisplay_tool_bar)
9822 (display_menu_bar): Force left-to-right direction. Add a FIXME
9823 comment for making that be controlled by a user option.
9824 (push_it, pop_it): Save and restore the state of the
9825 bidi iterator. Save and restore the bidi_p flag.
9826 (pop_it): Iterate out of display property for string iteration as
9827 well.
9828 (iterate_out_of_display_property): Support iteration over strings.
9829 (handle_single_display_spec): Set up it->bidi_it for iteration
9830 over a display string, and call bidi_init_it.
9831 (handle_single_display_spec, next_overlay_string)
9832 (get_overlay_strings_1, push_display_prop): Set up the bidi
9833 iterator for displaying display or overlay strings.
9834 (forward_to_next_line_start): Don't use the shortcut if
9835 bidi-iterating.
9836 (back_to_previous_visible_line_start): If handle_display_prop
9837 pushed the iterator stack, restore the internal state of the bidi
9838 iterator by calling bidi_pop_it same number of times.
9839 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9840 and we are bidi-iterating, don't decrement the iterator position;
9841 instead, set the first_elt flag in the bidi iterator, to produce
9842 the same effect.
9843 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9844 (push_display_prop): xassert that we are iterating a buffer.
9845 (push_it, pop_it): Save and restore paragraph_embedding member.
9846 (handle_single_display_spec, next_overlay_string)
9847 (get_overlay_strings_1, reseat_1, reseat_to_string)
9848 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9849 correctly. Don't assume unibyte strings are not bidi-reordered.
9850 (compute_display_string_pos)
9851 (compute_display_string_end): Fix handling the case of C string.
9852 (push_it, pop_it): Save and restore from_disp_prop_p.
9853 (handle_single_display_spec, push_display_prop): Set the
9854 from_disp_prop_p flag.
9855 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9856 (pop_it): Call iterate_out_of_display_property only if we are
9857 popping after iteration over a string that came from a display
9858 property. Fix a typo in popping stretch info. Add an assertion
9859 for verifying that the iterator position is in sync with the bidi
9860 iterator.
9861 (handle_single_display_spec, get_overlay_strings_1)
9862 (push_display_prop): Fix initialization of paragraph direction for
9863 string when that of the parent object is not yet determined.
9864 (reseat_1): Call bidi_init_it to resync the bidi
9865 iterator with IT's position. (Bug#7616)
9866 (find_row_edges): If ROW->start.pos gives position
9867 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9868 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9869 Reset the from_disp_prop_p flag.
9870 (SAVE_IT, RESTORE_IT): New macros.
9871 (pos_visible_p, face_before_or_after_it_pos)
9872 (back_to_previous_visible_line_start)
9873 (move_it_in_display_line_to, move_it_in_display_line)
9874 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9875 (try_scrolling, redisplay_window, display_line): Use them when
9876 saving a temporary copy of the iterator and restoring it back.
9877 (back_to_previous_visible_line_start, reseat_1)
9878 (init_iterator): Empty the bidi cache "stack".
9879 (move_it_in_display_line_to): If iterator ended up at
9880 EOL, but we never saw any buffer positions smaller than
9881 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9882 motion in bidi-reordered lines.
9883 (move_it_in_display_line_to): Record prev_method and prev_pos
9884 immediately before the call to set_iterator_to_next. Fixes cursor
9885 motion in bidi-reordered lines with stretch glyphs and strings
9886 displayed in margins. (Bug#8133) (Bug#8867)
9887 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9888 TO_CHARPOS.
640c8776
SM
9889 (pos_visible_p): Support positions in bidi-reordered lines.
9890 Save and restore bidi cache.
0bb23927
EZ
9891
9892 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9893 (bidi_paragraph_info): Delete unused struct.
9894 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9895 (bidi_cache_start): New variable.
9896 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9897 to zero.
9898 (bidi_cache_fetch_state, bidi_cache_search)
9899 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9900 (bidi_cache_find, bidi_peek_at_next_level)
9901 (bidi_level_of_next_char, bidi_find_other_level_edge)
9902 (bidi_move_to_visually_next): Compare cache index with
9903 bidi_cache_start rather than with zero.
9904 (bidi_fetch_char): Accept new argument STRING; all callers
9905 changed. Support iteration over a string. Support strings with
9906 display properties. Support unibyte strings. Fix the type of
9907 `len' according to what STRING_CHAR_AND_LENGTH expects.
9908 (bidi_paragraph_init, bidi_resolve_explicit_1)
9909 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9910 (bidi_level_of_next_char, bidi_move_to_visually_next):
9911 Support iteration over a string.
0bb23927
EZ
9912 (bidi_set_sor_type, bidi_resolve_explicit_1)
9913 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9914 can now be zero (for strings); special values 0 and -1 were
9915 changed to -1 and -2, respectively.
9916 (bidi_char_at_pos): New function.
9917 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9918 Call it instead of FETCH_MULTIBYTE_CHAR.
9919 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9920 initialized to valid values.
9921 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9922 values.
9923 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9924 the test for valid cached positions. Fix the logic for looking up
9925 the sentinel state in the cache. GCPRO the Lisp string we are
9926 iterating.
9927 (bidi_push_it, bidi_pop_it): New functions.
9928 (bidi_initialize): Initialize the bidi cache start stack pointer.
9929 (bidi_cache_ensure_space): New function, refactored from part of
9930 bidi_cache_iterator_state. Don't assume the required size is just
9931 one BIDI_CACHE_CHUNK away.
9932 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9933 (bidi_count_bytes, bidi_char_at_pos): New functions.
9934 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9935 always valid if bidi_cache_idx is valid.
9936 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9937 is valid if it's going to be used.
9938 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9939 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9940 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9941 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9942 (bidi_find_other_level_edge, bidi_cache_start_stack):
9943 All variables related to cache indices are now EMACS_INT.
c965adc5 9944
0bb23927
EZ
9945 * dispextern.h (struct bidi_string_data): New structure.
9946 (struct bidi_it): New member `string'. Make flag members be 1-bit
9947 fields, and put them last in the struct.
640c8776
SM
9948 (compute_display_string_pos, compute_display_string_end):
9949 Update prototypes.
0bb23927
EZ
9950 (bidi_push_it, bidi_pop_it): Add prototypes.
9951 (struct iterator_stack_entry): New members bidi_p,
9952 paragraph_embedding, and from_disp_prop_p.
9953 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9954 (bidi_shelve_cache, bidi_unshelve_cache):
9955 Declare prototypes.
0bb23927
EZ
9956
9957 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9958 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9959 and vector-like objects.
9960
9961 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9962 cache around display iteration.
9963
9964 * window.c (Fwindow_end, window_scroll_pixel_based)
9965 (displayed_window_lines, Frecenter): Save and restore the bidi
9966 cache around display iteration.
9967
3bbd2265
LMI
99682011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9969
9970 * editfns.c (Fdelete_region): Clarify the use of the named
9971 parameters (bug#6788).
9972
adc47434
MR
99732011-07-14 Martin Rudalics <rudalics@gmx.at>
9974
9975 * indent.c (Fvertical_motion): Set and restore w->pointm when
9976 saving and restoring the window's buffer (Bug#9006).
9977
837c31f8
LMI
99782011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9979
9980 * editfns.c (Fstring_to_char): Clarify just what is returned
9981 (bug#6576). Text by Eli Zaretskii.
9982
ac389d0c
JB
99832011-07-13 Juanma Barranquero <lekktu@gmail.com>
9984
9985 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9986
0be0ce47
EZ
99872011-07-13 Eli Zaretskii <eliz@gnu.org>
9988
9989 * buffer.c (mmap_find): Fix a typo.
9990
cd18e7e3
JB
99912011-07-13 Johan Bockgård <bojohan@gnu.org>
9992
9993 Fix execution of x selection hooks.
9994 * xselect.c (Qx_lost_selection_functions)
9995 (Qx_sent_selection_functions): New vars.
9996 (syms_of_xselect): DEFSYM them.
9997 (x_handle_selection_request): Pass Qx_sent_selection_functions
9998 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9999 (x_handle_selection_clear,x_clear_frame_selections):
10000 Pass Qx_lost_selection_functions rather than
10001 Vx_lost_selection_functions to Frun_hook_with_args.
10002
47ea7f44
PE
100032011-07-13 Paul Eggert <eggert@cs.ucla.edu>
10004
ac389d0c 10005 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
10006 The old code sometimes used this field without initializing it.
10007
47ea7f44
PE
10008 * alloc.c (gc_sweep): Don't read past end of array.
10009 In theory, the old code could also have corrupted Emacs internals,
10010 though it'd be very unlikely.
10011
bc985c87
AS
100122011-07-12 Andreas Schwab <schwab@linux-m68k.org>
10013
10014 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 10015 argument. (Bug#4026)
bc985c87 10016
0cf34688
LMI
100172011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
10018
b3dadd76
LMI
10019 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
10020 key" (bug#4257).
10021
0cf34688
LMI
10022 * window.c (Fset_window_start): Doc fix (bug#4199).
10023 (Fset_window_hscroll): Ditto.
10024
270768cd
PE
100252011-07-12 Paul Eggert <eggert@cs.ucla.edu>
10026
077e3dda 10027 Fix minor new problems caught by GCC 4.6.1.
270768cd 10028 * term.c (init_tty): Remove unused local.
490011a6 10029 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 10030 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 10031 not used otherwise.
270768cd 10032
b1f58454
CY
100332011-07-12 Chong Yidong <cyd@stupidchicken.com>
10034
10035 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
10036
22b9578d
LMI
100372011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10038
6e70ab07
LMI
10039 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
10040 are the mini-buffer and the echo area (bug#3320).
10041
22b9578d
LMI
10042 * term.c (init_tty): Remove support for supdup, c10 and perq
10043 terminals, which are no longer supported (bug#1482).
10044
8974cc9f
JB
100452011-07-10 Johan Bockgård <bojohan@gnu.org>
10046
10047 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
10048
a560d974
JD
100492011-07-10 Jan Djärv <jan.h.d@swipnet.se>
10050
10051 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
10052 for non-popups (Bug#3642).
10053
1dae0f0a
AS
100542011-07-10 Andreas Schwab <schwab@linux-m68k.org>
10055
268c2c36 10056 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 10057 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
10058 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
10059 * cm.c (losecursor): Likewise.
1dae0f0a
AS
10060 * data.c (fmod): Likewise.
10061 * dispnew.c (swap_glyphs_in_rows): Likewise.
10062 * emacs.c (memory_warning_signal): Likewise.
10063 * floatfns.c (float_error): Likewise.
10064 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
10065 (otf_open, font_otf_capability, generate_otf_features)
10066 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
10067 Likewise.
10068 * image.c (pbm_read_file): Likewise.
10069 * indent.c (string_display_width): Likewise.
10070 * intervals.c (check_for_interval, search_for_interval)
10071 (inc_interval_count, count_intervals, root_interval)
10072 (adjust_intervals_for_insertion, make_new_interval): Likewise.
10073 * lread.c (defalias): Likewise.
268c2c36 10074 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
10075 * regex.c (set_image_of_range_1, set_image_of_range)
10076 (regex_grow_registers): Likewise.
10077 * sysdep.c (strerror): Likewise.
10078 * termcap.c (valid_filename_p, tprint, main): Likewise.
10079 * tparam.c (main): Likewise.
10080 * unexhp9k800.c (run_time_remap, save_data_space)
10081 (update_file_ptrs, read_header, write_header, calculate_checksum)
10082 (copy_file, copy_rest, display_header): Likewise.
10083 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
10084 Likewise.
10085 * xdisp.c (check_it): Likewise.
10086 * xfaces.c (register_color, unregister_color, unregister_colors):
10087 Likewise.
10088 * xfns.c (print_fontset_result): Likewise.
10089 * xrdb.c (member, fatal, main): Likewise.
10090
99033785
PE
100912011-07-10 Paul Eggert <eggert@cs.ucla.edu>
10092
10093 Fix minor problems found by static checking (Bug#9031).
10094 * chartab.c (char_table_set_range, map_sub_char_table):
10095 Remove unused locals.
10096 (uniprop_table): Now static.
10097 * composite.c (_work_char): Remove unused static var.
10098
9cb2ac56
JB
100992011-07-09 Juanma Barranquero <lekktu@gmail.com>
10100
10101 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
10102
f25661f0
JD
101032011-07-09 Jan Djärv <jan.h.d@swipnet.se>
10104
10105 * gtkutil.c (qttip_cb): Remove code without function.
10106
8278c4fe
EZ
101072011-07-09 Eli Zaretskii <eliz@gnu.org>
10108
10109 * w32.c (pthread_sigmask): New stub.
10110
1692ae2d 101112011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 10112
8a6ebd58 10113 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
10114 sigprocmask is portable only for single-threaded applications, and
10115 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
10116 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
10117 (LIBES): Use it.
10118 * callproc.c (Fcall_process):
10119 * process.c (create_process):
10120 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
10121 Use pthread_sigmask, not sigprocmask.
123403e4 10122
1b854618
JD
101232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10124
10125 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
10126 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
10127 wrong (Bug#8591).
10128
3fe4b549
JD
101292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10130
0ce7e563
JD
10131 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10132 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
10133 (xg_hide_tooltip): Fix comment.
10134
3fe4b549
JD
10135 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
10136 in registerServicesMenuSendTypes.
10137 (validRequestorForSendType): Don't check ns_return_types.
10138
10139 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
10140 ns_return_type.
10141
5df75e47
JR
101422011-07-08 Jason Rumney <jasonr@gnu.org>
10143
22610910
JR
10144 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
10145 SH_SHOW for hidden windows (Bug#5482).
10146
5df75e47
JR
10147 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
10148 frame struct members of non-existent frames (Bug#6284).
10149
699c10bd
JD
101502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10151
4393663b
JD
10152 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
10153 variable firstTime not needed on OSX >= 10.6.
10154 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
10155 >= 10.5. Use setKnobProportion, setDoubleValue.
10156
10157 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
10158 (MAC_OS_X_VERSION_10_5): Define if not defined.
10159 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
10160 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
10161 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
10162
10163 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 10164 cString and lossyCString on OSX >= 10.4.
4393663b 10165
58179cce 10166 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10167 sizeToFit on OSX >= 10.2.
10168
10169 * nsimage.m (allocInitFromFile): Don't use deprecated method
10170 bestRepresentationForDevice on OSX >= 10.6.
10171
10172 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10173 to avoid warning.
10174
10175 * emacs.c: Declare unexec_init_emacs_zone.
10176
a63e0781
JD
10177 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10178
699c10bd
JD
10179 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10180
10181 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10182 on svcsMenu (Bug#8842).
10183
10184 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10185 ns_return_types.
10186 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10187
10188 * nsterm.m (QUTF8_STRING): Declare.
10189 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10190 (validRequestorForSendType): Return type is (id).
10191 Change indexOfObjectIdenticalTo to indexOfObject.
10192 Check if we have local selection before returning self (Bug#8842).
10193 (writeSelectionToPasteboard): Put local selection into paste board
10194 if we have a local selection (Bug#8842).
10195 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10196
10197 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10198 (ns_get_local_selection): Declare.
10199
54e10184
LMI
102002011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10201
9888ff71
LMI
10202 * keymap.c (describe_map_tree): Don't insert a double newline at
10203 the end of the buffer (bug#1169) and return whether we inserted
10204 something.
10205
54e10184
LMI
10206 * callint.c (Fcall_interactively): Change "reading args" to
10207 "providing args" to try to clarify what it does (bug#1010).
10208
15fa4783
KH
102092011-07-07 Kenichi Handa <handa@m17n.org>
10210
10211 * composite.c (composition_compute_stop_pos): Ignore a static
10212 composition starting before CHARPOS (Bug#8915).
10213
10214 * xdisp.c (handle_composition_prop): Likewise.
10215
a8815b00
EZ
102162011-07-07 Eli Zaretskii <eliz@gnu.org>
10217
10218 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10219 (Bug#9015)
10220
ef7b981d 102212011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10222
10223 * character.h (unicode_category_t): New enum type.
10224
10225 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10226 (Qchar_code_property_table): New variable.
10227 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10228 (UNIPROP_COMPRESSED_FORM_P): New macros.
10229 (char_table_ascii): Uncompress the compressed values.
10230 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10231 Uncompress the compressed values.
ac389d0c 10232 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10233 (char_table_ref_and_range): Uncompress the compressed values.
10234 (sub_char_table_set): New arg is_uniprop. Callers changed.
10235 Uncompress the compressed values.
10236 (sub_char_table_set_range): Args changed. Callers changed.
10237 (char_table_set_range): Adjuted for the above change.
10238 (map_sub_char_table): Delete args default_val and parent. Add arg
10239 top. Give decoded values to a Lisp function.
640c8776 10240 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10241 values to a Lisp function. Gcpro more variables.
10242 (uniprop_table_uncompress)
10243 (uniprop_decode_value_run_length): New functions.
10244 (uniprop_decoder, uniprop_decoder_count): New variables.
10245 (uniprop_get_decoder, uniprop_encode_value_character)
10246 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10247 New functions.
10248 (uniprop_encoder, uniprop_encoder_count): New variables.
10249 (uniprop_get_encoder, uniprop_table)
10250 (Funicode_property_table_internal, Fget_unicode_property_internal)
10251 (Fput_unicode_property_internal): New functions.
10252 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10253 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10254 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10255 char-code-property-alist.
10256
640c8776 10257 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10258 Vunicode_category_table.
10259
640c8776 10260 * font.c (font_range): Adjust for the change of
c805dec0
KH
10261 Vunicode_category_table.
10262
76b397fb
DN
102632011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10264
10265 * m/iris4d.h: Remove file, move contents ...
10266 * s/irix6-5.h: ... here.
10267
22b4128e
PE
102682011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10269
10270 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10271 * alloc.c (mark_buffer):
10272 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10273 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10274 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10275 This isn't true in general, and it's particularly not true
10276 if Emacs is configured with --with-wide-int.
10277 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10278 New macros, used in the buffer.c change.
10279
869795d6
JD
102802011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10281
10282 * xsettings.c: Use both GConf and GSettings if both are available.
10283 (store_config_changed_event): Add comment.
10284 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10285 (store_tool_bar_style_changed): New functions.
5e617bc2 10286 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10287 (struct xsettings): Move font inside HAVE_XFT.
10288 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10289 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10290 Move inside HAVE_XFT.
640c8776 10291 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10292 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10293 also.
10294 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10295 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10296 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10297 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10298 (parse_settings): Move check for font inside HAVE_XFT.
10299 (read_settings, apply_xft_settings): Add comment.
10300 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10301 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10302 call store_font_name_changed.
10303 (xft_settings_event): Add comment.
10304 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10305 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10306 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10307 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10308 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10309 (xsettings_get_system_font, xsettings_get_system_normal_font):
10310 Add comment.
869795d6 10311
d8ed26bd
PE
103122011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10313
10314 Random fixes. E.g., (random) never returned negative values.
10315 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10316 subseconds part to the entropy, as that's a bit more random.
10317 Prefer signed to unsigned, since the signedness doesn't matter and
10318 in general we prefer signed. When given a limit, use a
10319 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10320 latter isn't right if USE_2_TAGS_FOR_INTS.
10321 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10322 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10323
cabf1cac
SM
103242011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10325
10326 * textprop.c (text_property_stickiness):
10327 Obey Vtext_property_default_nonsticky.
10328 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10329 * w32fns.c (syms_of_w32fns):
10330 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10331
6e9b2be9
PE
103322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10333
10334 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10335 This is more efficient than Ffile_directory_p and avoids a minor race.
10336
90186c68
LMI
103372011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10338
7c301272
LMI
10339 * buffer.c (Foverlay_put): Say what the return value is
10340 (bug#7835).
10341
c4f2d8d4
LMI
10342 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10343 is a directory before asking whether to use the file name
10344 (bug#7564).
ad637907
LMI
10345 (barf_or_query_if_file_exists): Make the "File is a directory"
10346 error be more correct.
c4f2d8d4 10347
90186c68
LMI
10348 * fns.c (Frequire): Remove the mention of the .gz files, since
10349 that's installation-specific, but keep the mention of
10350 `get-load-suffixes'.
10351
da64016e
PE
103522011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10353
10354 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10355 Report string overflow if the output is too long.
10356
7d47b580
JB
103572011-07-04 Juanma Barranquero <lekktu@gmail.com>
10358
a555cb87
JB
10359 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10360 (syms_of_gnutls): Remove duplicate DEFSYM for
10361 Qgnutls_bootprop_verify_hostname_error, an error for
10362 Qgnutls_bootprop_verify_error (which is no longer used).
10363
7d47b580
JB
10364 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10365 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10366 Also (re)move comments that are misplaced or no longer relevant.
10367
1e49bfab
LMI
103682011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10369
10370 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10371
1485f4c0
CY
103722011-07-03 Chong Yidong <cyd@stupidchicken.com>
10373
10374 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10375 and background color parameters if they have been changed.
10376
a9ab721e
LMI
103772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10378
10379 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10380
cf7cff57
PE
103812011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10382
2e13213d
PE
10383 * xsettings.c (SYSTEM_FONT): Define only when used.
10384 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10385
cf7cff57
PE
10386 * keymap.c (access_keymap_1): Now static.
10387
7a8e04f7
CY
103882011-07-02 Chong Yidong <cyd@stupidchicken.com>
10389
10390 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10391 leave any prefix arg for the up event (Bug#1586).
10392
61352f62
LMI
103932011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10394
69bb1ef7
LMI
10395 * lread.c (syms_of_lread): Mention single symbols defined by
10396 `defvar' or `defconst' (bug#7154).
10397
61352f62 10398 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10399 (Frequire): Mention get-load-suffixes.
61352f62 10400
28545e04
MR
104012011-07-02 Martin Rudalics <rudalics@gmx.at>
10402
10403 * window.h (window): Remove clone_number slot.
10404 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10405 Remove.
10406 (make_parent_window, make_window, saved_window)
10407 (Fset_window_configuration, save_window_save): Don't deal with
10408 clone numbers.
10409 * buffer.c (Qclone_number): Remove declaration.
10410 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10411
3349e122
SM
104122011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10413
10414 Add multiple inheritance to keymaps.
10415 * keymap.c (Fmake_composed_keymap): New function.
10416 (Fset_keymap_parent): Simplify.
10417 (fix_submap_inheritance): Remove.
10418 (access_keymap_1): New function extracted from access_keymap to handle
10419 embedded parents and handle lists of maps.
10420 (access_keymap): Use it.
10421 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10422 (Fcopy_keymap): Handle embedded parents.
10423 (Fcommand_remapping, define_as_prefix): Simplify.
10424 (Fkey_binding): Simplify.
10425 (syms_of_keymap): Move minibuffer-local-completion-map,
10426 minibuffer-local-filename-completion-map,
10427 minibuffer-local-must-match-map, and
10428 minibuffer-local-filename-must-match-map to Elisp.
10429 (syms_of_keymap): Defsubr make-composed-keymap.
10430 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10431 (parse_menu_item): Trivial simplification.
10432
3279eb87
GM
104332011-07-01 Glenn Morris <rgm@gnu.org>
10434
10435 * Makefile.in (SETTINGS_LIBS): Fix typo.
10436
39cb9e56 104372011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10438
10439 * coding.c (Fencode_coding_string): Record the last coding system
10440 used, as the function doc string says (bug#8738).
10441
0949d2b6
JD
104422011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10443
10444 * xsettings.c (store_monospaced_changed): Take new font as arg and
10445 check for change against current_mono_font.
10446 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10447 (emacs_settings_constructor, emacs_settings_get_property)
10448 (emacs_settings_set_property, emacs_settings_class_init)
10449 (emacs_settings_init, gsettings_obj): Remove.
10450 (something_changedCB): New function for HAVE_GSETTINGS.
10451 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10452 with value as argument.
10453 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10454 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10455 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10456 "changed".
10457
10458 * xgselect.c: Add defined (HAVE_GSETTINGS).
10459 (xgselect_initialize): Ditto.
10460
10461 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10462 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10463 xg_select.
10464
bbc6b304
PE
104652011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10466
10467 * eval.c (struct backtrace): Simplify and port the data structure.
10468 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10469 signed bit field, as this assumption is not portable and it makes
10470 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10471 "char debug_on_exit : 1" as this is not portable either; instead,
10472 use the portable "unsigned int debug_on_exit : 1". Remove unused
10473 member evalargs. Remove obsolete comments about cc bombing out.
10474
9851bfc5
JD
104752011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10476
51bb811f 10477 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10478 Let HAVE_GSETTINGS override HAVE_GCONF.
10479 (store_monospaced_changed): New function.
10480 (EMACS_SETTINGS): A new type derived from GObject to handle
10481 GSettings notifications.
10482 (emacs_settings_constructor, emacs_settings_get_property)
10483 (emacs_settings_set_property, emacs_settings_class_init):
10484 New functions.
10485 (gsettings_client, gsettings_obj): New variables.
10486 (GSETTINGS_SCHEMA): New define.
10487 (something_changedCB): Call store_monospaced_changed.
10488 (init_gsettings): New function.
10489 (xsettings_initialize): Call init_gsettings.
10490 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10491 to NULL.
10492
640c8776 10493 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10494 GCONF_CFLAGS/LIBS.
10495
5386012d
MR
104962011-06-29 Martin Rudalics <rudalics@gmx.at>
10497
10498 * window.c (resize_root_window, grow_mini_window)
10499 (shrink_mini_window): Rename Qresize_root_window to
10500 Qwindow_resize_root_window and Qresize_root_window_vertically to
10501 Qwindow_resize_root_window_vertically.
10502
f13e0b08
PE
105032011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10504
10505 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10506
94515237
JB
105072011-06-27 Juanma Barranquero <lekktu@gmail.com>
10508
10509 * makefile.w32-in: Redesign dependencies so they reflect more
10510 clearly which files are directly included by each source file,
10511 and not through other includes.
10512
e43b6e43
MR
105132011-06-27 Martin Rudalics <rudalics@gmx.at>
10514
10515 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10516 (sort_overlays, overlay_strings): When an overlay's clone number
10517 matches the window's clone number process the overlay even if
10518 the overlay's window property doesn't match the current window.
10519
d68443dc
MR
10520 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10521 (Fwindow_hchild): Rename to Fwindow_left_child.
10522 (Fwindow_next): Rename to Fwindow_next_sibling.
10523 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10524 (resize_window_check): Rename to window_resize_check.
10525 (resize_window_apply): Rename to window_resize_apply.
10526 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10527 (Fdelete_other_windows_internal, resize_frame_windows)
10528 (Fsplit_window_internal, Fdelete_window_internal)
10529 (grow_mini_window, shrink_mini_window)
10530 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10531
c7e73be5
JD
105322011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10533
10534 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10535 (emacs_fixed_set_min_size): Remove.
10536 (emacs_fixed_new): Take frame as argument.
10537
10538 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10539 (_EmacsFixedPrivate): Remove minwidth/height.
10540 Add struct frame *f.
10541 (emacs_fixed_init): Initialize priv->f.
10542 (get_parent_class, emacs_fixed_set_min_size): Remove.
10543 (emacs_fixed_new): Set priv->f to argument.
10544 (emacs_fixed_get_preferred_width)
10545 (emacs_fixed_get_preferred_height): Use min_width/height from
10546 frames size_hint to set minimum and natural (Bug#8919).
10547 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10548 and use min_width/height from frames size_hint to set
10549 min_width/height (Bug#8919).
10550
10551 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10552 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10553 Fix indentation.
c7e73be5 10554
cf99dcf8
EZ
105552011-06-26 Eli Zaretskii <eliz@gnu.org>
10556
10557 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10558 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10559 called at ZV.
10560
029529ac
CY
105612011-06-26 Chong Yidong <cyd@stupidchicken.com>
10562
10563 * process.c (wait_reading_process_output): Bypass select if
10564 waiting for a cell while ignoring keyboard input, and input is
10565 pending. Suggested by Jan Djärv (Bug#8869).
10566
7a7ef429
PE
105672011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10568
10569 Use gnulib's dup2 module instead of rolling our own.
10570 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10571
11fdef7d 105722011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10573
10574 * dispnew.c (scrolling_window): Before scrolling, turn off a
10575 mouse-highlight in the window being scrolled.
10576
cd3520a4
JB
105772011-06-24 Juanma Barranquero <lekktu@gmail.com>
10578
10579 Move DEFSYM to lisp.h and use everywhere.
10580
10581 * character.h (DEFSYM): Move declaration...
10582 * lisp.h (DEFSYM): ...here.
10583
10584 * gnutls.c:
10585 * minibuf.c:
10586 * w32menu.c:
10587 * w32proc.c:
10588 * w32select.c: Don't include character.h.
10589
10590 * alloc.c (syms_of_alloc):
10591 * buffer.c (syms_of_buffer):
10592 * bytecode.c (syms_of_bytecode):
10593 * callint.c (syms_of_callint):
10594 * casefiddle.c (syms_of_casefiddle):
10595 * casetab.c (init_casetab_once):
10596 * category.c (init_category_once, syms_of_category):
10597 * ccl.c (syms_of_ccl):
10598 * cmds.c (syms_of_cmds):
10599 * composite.c (syms_of_composite):
10600 * dbusbind.c (syms_of_dbusbind):
10601 * dired.c (syms_of_dired):
10602 * dispnew.c (syms_of_display):
10603 * doc.c (syms_of_doc):
10604 * editfns.c (syms_of_editfns):
10605 * emacs.c (syms_of_emacs):
10606 * eval.c (syms_of_eval):
10607 * fileio.c (syms_of_fileio):
10608 * fns.c (syms_of_fns):
10609 * frame.c (syms_of_frame):
10610 * fringe.c (syms_of_fringe):
10611 * insdel.c (syms_of_insdel):
10612 * keymap.c (syms_of_keymap):
10613 * lread.c (init_obarray, syms_of_lread):
10614 * macros.c (syms_of_macros):
10615 * msdos.c (syms_of_msdos):
10616 * print.c (syms_of_print):
10617 * process.c (syms_of_process):
10618 * search.c (syms_of_search):
10619 * sound.c (syms_of_sound):
10620 * syntax.c (init_syntax_once, syms_of_syntax):
10621 * terminal.c (syms_of_terminal):
10622 * textprop.c (syms_of_textprop):
10623 * undo.c (syms_of_undo):
10624 * w32.c (globals_of_w32):
10625 * window.c (syms_of_window):
10626 * xdisp.c (syms_of_xdisp):
10627 * xfaces.c (syms_of_xfaces):
10628 * xfns.c (syms_of_xfns):
10629 * xmenu.c (syms_of_xmenu):
10630 * xsettings.c (syms_of_xsettings):
10631 * xterm.c (syms_of_xterm): Use DEFSYM.
10632
4228cf16
TZ
106332011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10634
cd3520a4 10635 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10636
7fcccf1e
PE
106372011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10638
7efb4e0e
PE
10639 Integer and buffer overflow fixes (Bug#8873).
10640
ff5844ad
PE
10641 * print.c (printchar, strout): Check for string overflow.
10642 (PRINTPREPARE, printchar, strout):
10643 Don't set size unless allocation succeeds.
10644
90532f02
PE
10645 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10646 for sizes. Check for string overflow more accurately.
10647 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10648
6d84508d
PE
10649 * macros.c: Integer and buffer overflow fixes.
10650 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10651 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10652 Use ptrdiff_t, not int, for sizes.
10653 Don't increment bufsize until after realloc succeeds.
10654 Check for size-calculation overflow.
10655 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10656
437b2cb4
PE
10657 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10658
8b9ac8b4
PE
10659 * lread.c: Integer overflow fixes.
10660 (read_integer): Radix is now EMACS_INT, not int,
10661 to improve quality of diagnostics for out-of-range radices.
10662 Calculate buffer size correctly for out-of-range radices.
10663 (read1): Check for integer overflow in radices, and in
10664 read-circle numbers.
82cb60d3
PE
10665 (read_escape): Avoid int overflow.
10666 (Fload, openp, read_buffer_size, read1)
10667 (substitute_object_recurse, read_vector, read_list, map_obarray):
10668 Use ptrdiff_t, not int, for sizes.
10669 (read1): Use EMACS_INT, not int, for sizes.
20270765 10670 Check for size overflow.
8b9ac8b4 10671
7fcccf1e
PE
10672 * image.c (cache_image): Check for size arithmetic overflow.
10673
bfbbd7e7
PE
10674 * lread.c: Integer overflow issues.
10675 (saved_doc_string_size, saved_doc_string_length)
10676 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10677 Now ptrdiff_t, not int.
10678 (read1): Don't assume doc string length fits in int. Check for
10679 out-of-range doc string lengths.
10680 (read_list): Don't assume file position fits in int.
39019e54 10681 (read_escape): Check for hex character overflow.
bfbbd7e7 10682
4e323265
LL
106832011-06-22 Leo Liu <sdl.web@gmail.com>
10684
10685 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10686 Move to minibuffer.el.
10687
85fece3e
PE
106882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10689
20b84ce9 10690 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10691 The following patches are for when GLYPH_DEBUG && !XASSERT.
10692 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10693 * dispnew.c (flush_stdout):
10694 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10695 Mark as externally visible.
10696 * dispnew.c (check_window_matrix_pointers): Now static.
10697 * dispnew.c (window_to_frame_vpos):
10698 * xfns.c (unwind_create_frame):
10699 * xterm.c (x_check_font): Remove unused local.
10700 * scroll.c (CHECK_BOUNDS):
10701 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10702 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10703 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10704 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10705 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10706 Now static.
10707 (debug_method_add): Use va_list and vsprintf rather than relying
10708 on undefined behavior with wrong number of arguments.
10709 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10710 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10711 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10712 since we're not interested in debugging glyphs with old libraries.
10713 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10714 GCC 4.6.0's static checking.
10715
0766b489
PE
107162011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10717
31fd4b32
PE
10718 Integer overflow and signedness fixes (Bug#8873).
10719 A few related buffer overrun fixes, too.
10720
b79e8648
PE
10721 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10722
0766b489
PE
10723 * dispextern.h (struct face.stipple):
10724 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10725 (x_bitmap_mask, x_allocate_bitmap_record)
10726 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10727 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10728 (x_create_bitmap_from_xpm_data):
10729 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10730 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10731 (.bitmaps_last):
10732 * xfaces.c (load_pixmap):
10733 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10734 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10735 (.bitmaps_last, struct x_output.icon_bitmap):
10736 Use ptrdiff_t, not int, for bitmap indexes.
10737 (x_allocate_bitmap_record): Check for size overflow.
10738 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10739
b081724f
PE
10740 Use ptrdiff_t, not int, for overlay counts.
10741 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10742 * editfns.c (overlays_around, get_pos_property):
10743 * textprop.c (get_char_property_and_overlay):
10744 * xdisp.c (next_overlay_change, note_mouse_highlight):
10745 * xfaces.c (face_at_buffer_position):
21514da7
PE
10746 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10747 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10748 (Fnext_overlay_change, Fprevious_overlay_change)
10749 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10750 Use ptrdiff_t, not int, for sizes.
21514da7 10751 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10752
3de73e5e
PE
10753 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10754
2606c57b
PE
10755 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10756 (x_session_initialize): Do not assume string length fits in int.
10757
aaafe47a
PE
10758 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10759 This is unlikely, but can occur if DPI is outlandish.
10760
2674ddc8 10761 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10762 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10763
28154962
PE
10764 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10765 * xrdb.c (magic_file_p, search_magic_path):
10766 Omit last arg SUFFIX; it was always 0. All callers changed.
10767 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10768
7de51af5
PE
10769 * xfont.c (xfont_match): Avoid need for strlen.
10770
25ed6cc3
PE
10771 * xfns.c: Don't assume strlen fits in int.
10772 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10773
4eab31dd
PE
10774 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10775 not unsigned long, as we prefer signed integers. All callers changed.
10776 Detect integer overflow in repeat count.
10777 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10778 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10779
171e2a58
PE
10780 * termcap.c: Don't assume sizes fit in int and never overflow.
10781 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10782 (gobble_line): Check for size-calculation overflow.
10783
ad39faca 10784 * minibuf.c (Fread_buffer):
6e5bb2dc 10785 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10786 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10787 Don't assume string length fits in int.
10788
52c61c22 10789 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10790 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10791
b5b8c9e5
PE
10792 * font.c: Don't assume string length fits in int.
10793 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10794 Use ptrdiff_t, not int.
ccd6111c
PE
10795 (font_intern_prop): Don't assume string length fits in int.
10796 Don't assume integer property fits in fixnum.
10797 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10798
882f0d81 10799 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10800 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10801 Reformulate so as not to need the command string.
10802 Invoke gzip -cd rather than gunzip, as it's more portable.
10803 (lock_info_type, lock_file_1, lock_file):
10804 Don't assume pid_t and time_t fit in unsigned long.
10805 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10806 (current_lock_owner): Prefer signed type for sizes.
10807 Use memcpy, not strncpy, where memcpy is what is really wanted.
10808 Don't assume (via atoi) that time_t and pid_t fit in int.
10809 Check for time_t and/or pid_t out of range, e.g., via a network share.
10810 Don't alloca where an auto var works fine.
10811
93f4cf88
PE
10812 * fileio.c: Fix some integer overflow issues.
10813 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10814 Don't assume string length fits in int.
10815 (directory_file_name): Don't assume string length fits in long.
10816 (make_temp_name): Don't assume pid fits in int, or that its print
10817 length is less than 20.
10818
f3e92b69
PE
10819 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10820
1bfdaf10
PE
10821 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10822
35016e9a
PE
10823 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10824
3d1e65a1
PE
10825 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10826 We prefer signed integers, even for size calculations.
10827
0b963a93
PE
10828 * emacs.c: Don't assume string length fits in 'int'.
10829 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10830 (main): Don't invoke strlen when not needed.
10831
573f4b54
PE
10832 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10833 (XD_DEBUG_MESSAGE): Don't waste a byte.
10834
989f33ba
PE
10835 * callproc.c (getenv_internal_1, getenv_internal)
10836 (Fgetenv_internal):
965d34eb
PE
10837 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10838
e4d29b33
PE
10839 * lread.c (invalid_syntax): Omit length argument.
10840 All uses changed. This doesn't fix a bug, but it simplifies the
10841 code away from its former Hollerith-constant appearance, and it's
10842 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10843 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10844
eb49b136
PE
10845 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10846 This didn't break anything, but it didn't help either.
10847 It's confusing to put a bogus integer in a place where the actual
10848 value does not matter.
9f62aeb1 10849 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10850 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10851
15375a22
PE
10852 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10853 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10854 implementation.
b61cc01c
PE
10855 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10856 We prefer signed types, and the value cannot exceed the EMACS_INT
10857 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10858 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10859 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10860 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10861
53b2623d
PE
10862 * indent.c (sane_tab_width): New function.
10863 (current_column, scan_for_column, Findent_to, position_indentation)
10864 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10865 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10866
51cab52b 10867 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10868
f2ed8a70
PE
10869 * lisp.h (lint_assume): New macro.
10870 * composite.c (composition_gstring_put_cache):
10871 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10872
abe80cc6
PE
10873 * editfns.c, insdel.c:
10874 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10875
b02c740e
PE
10876 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10877
ebc96716
PE
10878 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10879
b4e50fa0 10880 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10881 Use much-faster test for byte-length change.
311d5d7c 10882 Don't assume string byte-length fits in 'int'.
a4cf38e4 10883 Check that character arg fits in 'int'.
85461888 10884 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10885
c0c1ee9f
PE
10886 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10887
a498d7f4
PE
10888 * fns.c (concat): Catch string overflow earlier.
10889 Do not rely on integer wraparound.
10890
51cab52b
PE
10891 * dispextern.h (struct it.overlay_strings_charpos)
10892 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10893 * xdisp.c (forward_to_next_line_start)
10894 (back_to_previous_visible_line_start)
10895 (reseat_at_next_visible_line_start, next_element_from_buffer):
10896 Don't arbitrarily truncate the value of 'selective' to int.
10897
76031fad
PE
10898 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10899
5eb55db9
PE
10900 * composite.c: Don't truncate sizes to 'int'.
10901 (composition_gstring_p, composition_reseat_it)
10902 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10903 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10904 not EMACS_UINT, for indexes.
5eb55db9 10905
0703a717
PE
10906 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10907
d6202519
PE
10908 * buffer.c: Include <verify.h>.
10909 (struct sortvec.priority, struct sortstr.priority):
8961a454 10910 Now EMACS_INT, not int.
c20998a7 10911 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10912 (struct sortstr.size, record_overlay_string)
10913 (struct sortstrlist.size, struct sortlist.used):
10914 Don't truncate size to int.
10915 (record_overlay_string): Check for size-calculation overflow.
d6202519 10916 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10917
d5a19415
JM
109182011-06-22 Jim Meyering <meyering@redhat.com>
10919
029529ac 10920 Don't leak an XBM-image-sized buffer
d5a19415
JM
10921 * image.c (xbm_load): Free the image buffer after using it.
10922
a9041e6c
PE
109232011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10924
10925 Port to Sun C.
10926 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10927 that Sun C diagnosed.
10928 * fns.c (secure_hash): Fix pointer signedness issue.
10929 * intervals.c (static_offset_intervals): New function.
10930 (offset_intervals): Use it.
10931
7f3f739f
LL
109322011-06-21 Leo Liu <sdl.web@gmail.com>
10933
10934 * deps.mk (fns.o):
10935 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10936 sha512.h.
10937
10938 * fns.c (secure_hash): Rename from crypto_hash_function and change
10939 the first arg to accept symbols.
5b66d427 10940 (Fsecure_hash): New primitive.
7f3f739f
LL
10941 (syms_of_fns): New symbols.
10942
76147d94
DD
109432011-06-20 Deniz Dogan <deniz@dogan.se>
10944
10945 * process.c (Fset_process_buffer): Clarify return value in
10946 docstring.
10947
7d7d0045
CY
109482011-06-18 Chong Yidong <cyd@stupidchicken.com>
10949
10950 * dispnew.c (add_window_display_history): Use BVAR.
10951
10952 * xdisp.c (debug_method_add): Use BVAR.
10953 (check_window_end, dump_glyph_matrix, dump_glyph)
10954 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10955
10956 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10957 Likewise.
10958
10959 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10960 check till after the cache is created in init_frame_faces.
10961
ff2bc410
SM
109622011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10963
10964 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10965
28177add
PE
109662011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10967
dd3482fe
PE
10968 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10969 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10970 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10971
393d71f3 10972 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10973 * fileio.c (Finsert_file_contents):
10974 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10975 Remove the old (too-loose) buffer overflow checks.
10976 They weren't needed, since make_gap checks for buffer overflow.
10977 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10978 The old code merely checked for Emacs fixnum overflow, and relied
10979 on undefined (wraparound) behavior. The new code avoids undefined
10980 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10981
2e6813b0 10982 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10983 Tune. Don't use wider integers than needed. Don't use alloca.
10984 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10985
599a9e4f
PE
10986 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10987
99561444
PE
10988 * insdel.c, lisp.h (buffer_overflow): New function.
10989 (insert_from_buffer_1, replace_range, replace_range_2):
10990 * insdel.c (make_gap_larger):
10991 * editfns.c (Finsert_char):
10992 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10993
28177add
PE
10994 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10995
e69dafad
PE
109962011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10997
4baa020d 10998 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10999
b1c46f02
PE
11000 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
11001 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
11002
e69dafad
PE
11003 * fileio.c: Don't assume EMACS_INT fits in off_t.
11004 (emacs_lseek): New static function.
11005 (Finsert_file_contents, Fwrite_region): Use it.
11006 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
11007
566684ea
PE
11008 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
11009
e6966cd6
PE
11010 * fns.c: Don't overflow int when computing a list length.
11011 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
11012 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
11013 truncation on 64-bit hosts. Check for QUIT every
11014 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
11015 faster and is responsive enough.
11016 (Flength): Report an error instead of overflowing an integer.
11017 (Fsafe_length): Return a float if the value is not representable
11018 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 11019 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 11020 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 11021
dd0b0efb
PE
11022 * alloc.c: Check that resized vectors' lengths fit in fixnums.
11023 (header_size, word_size): New constants.
11024 (allocate_vectorlike): Don't check size overflow here.
11025 (allocate_vector): Check it here instead, since this is the only
11026 caller of allocate_vectorlike that could cause overflow.
11027 Check that the new vector's length is representable as a fixnum.
11028
86fe5cfe
PE
11029 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
11030 The previous code was bogus. For example, next_almost_prime (32)
11031 returned 39, which is undesirable as it is a multiple of 3; and
11032 next_almost_prime (24) returned 25, which is a multiple of 5 so
11033 why was the code bothering to check for multiples of 7?
11034
80e88859
PE
11035 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
11036
4a2f0ad6
PE
11037 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
11038
f66c7cf8
PE
11039 Variadic C functions now count arguments with ptrdiff_t.
11040 This partly undoes my 2011-03-30 change, which replaced int with size_t.
11041 Back then I didn't know that the Emacs coding style prefers signed int.
11042 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
11043 were being counted with int, which may truncate counts on 64-bit
11044 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
11045 * lisp.h (struct Lisp_Subr.function.aMANY)
11046 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
11047 Arg counts are now ptrdiff_t, not size_t.
11048 All variadic functions and their callers changed accordingly.
11049 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
11050 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
11051 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
11052 * callint.c (Fcall_interactively): Check arg count for overflow,
11053 to avoid potential buffer overrun. Use signed char, not 'int',
11054 for 'varies' array, so that we needn't bother to check its size
11055 calculation for overflow.
11056 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
11057 * eval.c (apply_lambda):
11058 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
11059 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
11060 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
11061
a1759b76
PE
11062 * callint.c (Fcall_interactively): Don't use index var as event count.
11063
d96be9fc
PE
11064 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
11065 * mem-limits.h (SIZE): Remove; no longer used.
11066
a690a978 11067 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 11068
578c21e6
PE
11069 Remove unnecessary casts.
11070 * xterm.c (x_term_init):
11071 * xfns.c (x_set_border_pixel):
11072 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11073 These aren't needed now that we assume ANSI C.
11074
96f53c6c
PE
11075 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
11076 It's more likely to cause problems (due to unsigned overflow)
11077 than to cure them.
11078
83c77d31
PE
11079 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
11080
ee2079f1
PE
11081 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
11082
6da65536
PE
11083 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
11084
7147c4a4
PE
11085 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
11086
193e32d9
PE
11087 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
11088
e5533da6
PE
11089 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
11090
9910e595
PE
11091 GLYPH_CODE_FACE returns EMACS_INT, not int.
11092 * dispextern.h (merge_faces):
11093 * xfaces.c (merge_faces):
01103c44
PE
11094 * xdisp.c (get_next_display_element, next_element_from_display_vector):
11095 Don't assume EMACS_INT fits in int.
9910e595 11096
2638320e
PE
11097 * character.h (CHAR_VALID_P): Remove unused parameter.
11098 * fontset.c, lisp.h, xdisp.c: All uses changed.
11099
045eb8d9
PE
11100 * editfns.c (Ftranslate_region_internal): Omit redundant test.
11101
c1f134b5
PE
11102 * fns.c (concat): Minor tuning based on overflow analysis.
11103 This doesn't fix any bugs. Use int to hold character, instead
11104 of constantly refetching from Emacs object. Use XFASTINT, not
11105 XINT, for value known to be a character. Don't bother comparing
11106 a single byte to 0400, as it's always less.
11107
395fcb93 11108 * floatfns.c (Fexpt):
327eeec8
PE
11109 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
11110
abbd3d23
PE
11111 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
11112 for characters.
11113
684a03ef
PE
11114 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
11115
0fed43f3
PE
11116 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
11117 Without this fix, on a 64-bit host (aset S 0 4294967386) would
11118 incorrectly succeed when S was a string, because 4294967386 was
11119 truncated before it was used.
11120
8fd02eb7
PE
11121 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
11122 Otherwise, an out-of-range integer could cause undefined behavior
11123 on a 64-bit host.
11124
f8c86b69
PE
11125 * composite.c: Use int, not EMACS_INT, for characters.
11126 (fill_gstring_body, composition_compute_stop_pos): Use int, not
11127 EMACS_INT, for values that are known to be in character range.
11128 This doesn't fix any bugs but is the usual style inside Emacs and
11129 may generate better code on 32-bit machines.
11130
34206dd2
PE
11131 Make sure a 64-bit char is never passed to ENCODE_CHAR.
11132 This is for reasons similar to the recent CHAR_STRING fix.
11133 * charset.c (Fencode_char): Check that character arg is actually
11134 a character. Pass an int to ENCODE_CHAR.
11135 * charset.h (ENCODE_CHAR): Verify that the character argument is no
11136 wider than 'int', as a compile-time check to prevent future regressions
11137 in this area.
11138
c5958d4c 11139 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
11140
11141 Make sure a 64-bit char is never passed to CHAR_STRING.
11142 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
11143 by silently ignoring the top 32 bits, allowing some values
11144 that were far too large to be valid characters.
11145 * character.h: Include <verify.h>.
11146 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
11147 arguments are no wider than unsigned, as a compile-time check
11148 to prevent future regressions in this area.
11149 * data.c (Faset):
01103c44 11150 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
11151 (Fsubst_char_in_region):
11152 * fns.c (concat):
11153 * xdisp.c (decode_mode_spec_coding):
11154 Adjust to CHAR_STRING's new requirement.
11155 * editfns.c (Finsert_char, Fsubst_char_in_region):
11156 * fns.c (concat): Check that character args are actually
11157 characters. Without this test, these functions did the wrong
11158 thing with wildly out-of-range values on 64-bit hosts.
11159
d37ca623
PE
11160 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
11161 These casts should not be needed on 32-bit hosts, either.
11162 * keyboard.c (read_char):
11163 * lread.c (Fload): Remove casts to unsigned.
11164
ea204efb
PE
11165 * lisp.h (UNSIGNED_CMP): New macro.
11166 This fixes comparison bugs on 64-bit hosts.
11167 (ASCII_CHAR_P): Use it.
11168 * casefiddle.c (casify_object):
01103c44 11169 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11170 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11171 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11172 * dispextern.h (FACE_FROM_ID):
11173 * keyboard.c (read_char): Use UNSIGNED_CMP.
11174
41cb286c
PE
11175 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11176 not to EMACS_INT, to avoid GCC warning.
11177
4a1b9832
PE
11178 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11179
55daad71
PE
11180 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11181 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11182 isn't needed on 32-bit machines.
8f95c75c 11183
01103c44
PE
11184 * buffer.c (Fgenerate_new_buffer_name):
11185 Use EMACS_INT for count, not int.
0ceccced 11186 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11187
11188 * data.c (Qcompiled_function): Now static.
11189
c6f072e7
PE
11190 * window.c (window_body_lines): Now static.
11191
20ce5912
PE
11192 * image.c (gif_load): Rename local to avoid shadowing.
11193
9c4c5f81
PE
11194 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11195 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11196 * alloc.c (make_save_value): Integer argument is now of type
11197 ptrdiff_t, not int.
11198 (mark_object): Use ptrdiff_t, not int.
11199 * lisp.h (pD): New macro.
11200 * print.c (print_object): Use it.
11201
c0c5c8ae
PE
11202 * alloc.c: Use EMACS_INT, not int, to count objects.
11203 (total_conses, total_markers, total_symbols, total_vector_size)
11204 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11205 (total_free_floats, total_floats, total_free_intervals)
11206 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11207 Now EMACS_INT, not int. All uses changed.
11208 (Fgarbage_collect): Compute overall total using a double, so that
11209 integer overflow is less likely to be a problem. Check for overflow
11210 when converting back to an integer.
5a25e253
PE
11211 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11212 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11213 These were 'int' variables that could overflow on 64-bit hosts;
11214 they were never used, so remove them instead of repairing them.
211a0b2a 11215 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11216 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11217 Previously, this ceilinged at INT_MAX, but that doesn't work on
11218 64-bit machines.
e46bb31a 11219 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11220
c78baabf 11221 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11222 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11223 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11224 when a (possibly-narrower) signed value would do just as well.
11225 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11226
c9d624c6
PE
11227 * alloc.c: Catch some string size overflows that we were missing.
11228 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11229 for convenience in STRING_BYTES_MAX.
11230 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11231 The definition here is exact; the one in lisp.h was approximate.
11232 (allocate_string_data): Check for string overflow. This catches
11233 some instances we weren't catching before. Also, it catches
11234 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11235 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11236 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11237
c9d624c6
PE
11238 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11239 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11240 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11241
353032ce
PE
11242 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11243
2bccce07
PE
11244 * alloc.c (Fmake_string): Check for out-of-range init.
11245
0ac30604
SM
112462011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11247
11248 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11249
c195f2de
JD
112502011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11251
11252 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11253 xg_get_default_scrollbar_width.
11254
11255 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11256 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11257 (style_changed_cb): Call update_theme_scrollbar_width and call
11258 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11259 all frames (Bug#8505).
11260 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11261 Call gtk_window_set_resizable if HAVE_GTK3.
11262 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11263 and height if HAVE_GTK3 (Bug#8505).
11264 (scroll_bar_width_for_theme): New variable.
11265 (update_theme_scrollbar_width): New function.
11266 (xg_get_default_scrollbar_width): Move code to
11267 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11268 (xg_initialize): Call update_theme_scrollbar_width.
11269
11270 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11271
11272 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11273
e10ac9f1
MR
112742011-06-12 Martin Rudalics <rudalics@gmx.at>
11275
11276 * frame.c (make_frame): Call other_buffer_safely instead of
11277 other_buffer.
11278
11279 * window.c (temp_output_buffer_show): Call display_buffer with
11280 second argument Vtemp_buffer_show_specifiers and reset latter
11281 immediately after the call.
11282 (Vtemp_buffer_show_specifiers): New variable.
11283 (auto_window_vscroll_p, next_screen_context_lines)
11284 (Vscroll_preserve_screen_position): Remove leading asterisks from
11285 doc-strings.
11286
2d3c217e 112872011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11288
7b7f97e8 11289 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11290 * buffer.c (Qclone_number): Remove for now, as it's unused.
11291 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11292 (record_buffer): Remove unused local.
11293 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11294 (set_frame_buffer_list): Remove; unused.
11295 * frame.h (other_visible_frames): Remove decl.
11296 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11297 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11298 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11299 if HAVE_GPM.
11300 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11301 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11302 Define only if HAVE_GPM.
11303 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11304 (update_hints_inhibit): Remove; never set. All uses removed.
11305 * widgetprv.h (emacsFrameClassRec): Remove decl.
11306 * window.c (delete_deletable_window): Now returns void, since it
11307 wasn't returning anything.
11308 (compare_window_configurations): Remove unused locals.
11309 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11310 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11311 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11312 the same widths as pointers. This follows up on the 2011-05-06 patch.
11313 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11314 * xterm.h: Likewise.
11315 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11316
1384b89e
JB
113172011-06-12 Juanma Barranquero <lekktu@gmail.com>
11318
11319 * makefile.w32-in: Update dependencies.
11320 (LISP_H): Add lib/intprops.h.
11321
1100a63c
CY
113222011-06-11 Chong Yidong <cyd@stupidchicken.com>
11323
11324 * image.c (gif_load): Add animation frame delay to the metadata.
11325 (syms_of_image): Use DEFSYM. New symbol `delay'.
11326
6198ccd0
MR
113272011-06-11 Martin Rudalics <rudalics@gmx.at>
11328
11329 * window.c (delete_deletable_window): Re-add.
11330 (Fset_window_configuration): Rewrite to handle dead buffers and
11331 consequently deletable windows.
11332 (window_tree, Fwindow_tree): Remove. Supply functionality in
11333 window.el.
11334 (compare_window_configurations): Simplify code.
11335
b6e3633c
AS
113362011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11337
1ab0dee5
AS
11338 * image.c (imagemagick_load_image): Fix type mismatch.
11339 (Fimagemagick_types): Likewise.
11340
b6e3633c
AS
11341 * window.h (replace_buffer_in_windows): Declare.
11342
9397e56f
MR
113432011-06-11 Martin Rudalics <rudalics@gmx.at>
11344
11345 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11346 Qclone_number. Remove external declaration of Qdelete_window.
11347 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11348 code.
640c8776
SM
11349 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11350 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11351 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11352 buffer list implementation.
11353 (other_buffer_safely): New function.
11354 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11355 calls to replace_buffer_in_windows and
11356 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11357 if allowed.
11358 (record_buffer): Inhibit quitting and rewrite using quittable
11359 functions. Run Qbuffer_list_update_hook if allowed.
11360 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11361 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11362 Move switch-to-buffer to window.el.
9397e56f
MR
11363 (bury-buffer): Move to window.el.
11364 (Vbuffer_list_update_hook): New variable.
11365
11366 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11367 section.
11368
11369 * window.h (resize_frame_windows): Move up in code.
11370 (Fwindow_frame): Remove EXFUN.
11371 (replace_buffer_in_all_windows): Remove prototype.
11372 (replace_buffer_in_windows_safely): Add prototype.
11373
11374 * window.c: Declare Qdelete_window static again. Move down
11375 declaration of select_count.
11376 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11377 (Fother_window): Move to window.el.
11378 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11379 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11380 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11381 window.el.
11382 (replace_buffer_in_windows): Implement by calling
11383 Qreplace_buffer_in_windows.
11384 (replace_buffer_in_all_windows): Remove with some functionality
11385 moved into replace_buffer_in_windows_safely.
11386 (replace_buffer_in_windows_safely): New function.
11387 (select_window_norecord, select_frame_norecord): Move in front
11388 of run_window_configuration_change_hook. Remove now obsolete
11389 declarations.
640c8776
SM
11390 (Fset_window_buffer): Rewrite doc-string.
11391 Call Qrecord_window_buffer.
9397e56f
MR
11392 (keys_of_window): Move binding for other-window to window.el.
11393
b50691aa
CY
113942011-06-11 Chong Yidong <cyd@stupidchicken.com>
11395
11396 * dispextern.h (struct image): Replace data member, whose int_val
11397 and ptr_val fields were not used by anything, with a single
11398 lisp_val object.
11399
11400 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11401 (gif_clear_image, gif_load, imagemagick_load_image)
11402 (gs_clear_image, gs_load): Callers changed.
11403
3f754b86
PE
114042011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11405
cca69397
PE
11406 * buffer.h: Include <time.h>, for time_t.
11407 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11408
109e28d0
PE
11409 Fix minor problems found by static checking.
11410
60737f02
PE
11411 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11412
4b66faf3
PE
11413 Make identifiers static if they are not used in other modules.
11414 * data.c (Qcompiled_function, Qframe, Qvector):
11415 * image.c (QimageMagick, Qsvg):
11416 * minibuf.c (Qmetadata):
11417 * window.c (resize_window_check, resize_root_window): Now static.
11418 * window.h (resize_window_check, resize_root_window): Remove decls.
11419
109e28d0
PE
11420 * window.c (window_deletion_count, delete_deletable_window):
11421 Remove; unused.
46a4ce9e
PE
11422 (window_body_lines): Now static.
11423 (Fdelete_other_windows_internal): Mark vars as initialized.
11424 Make sure 'resize_failed' is initialized.
11425 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11426 (resize_window_apply): Remove unused local.
11427 * window.h (delete_deletable_window): Remove decl.
11428
109e28d0 11429 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11430 (imagemagick_load_image): Fix pointer signedness problem by changing
11431 last arg from unsigned char * to char *. All uses changed.
11432 Also, fix a local for similar reasons.
11433 Remove unused locals. Remove locals to avoid shadowing.
11434 (fn_rsvg_handle_free): Remove; unused.
11435 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11436 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11437
3f754b86
PE
11438 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11439
2547adb1
CY
114402011-06-10 Chong Yidong <cyd@stupidchicken.com>
11441
11442 * image.c (gif_load): Fix omitted cast error introduced by
11443 2011-06-06 change.
11444
2c8e37d4
MR
114452011-06-10 Martin Rudalics <rudalics@gmx.at>
11446
11447 * window.h (resize_proportionally, orig_total_lines)
11448 (orig_top_line): Remove from window structure.
11449 (set_window_height, set_window_width, change_window_heights)
11450 (Fdelete_window): Remove prototypes.
11451 (resize_frame_windows): Remove duplicate declaration.
11452
440a42e3
EZ
114532011-06-10 Eli Zaretskii <eliz@gnu.org>
11454
11455 * window.h (resize_frame_windows, resize_window_check)
11456 (delete_deletable_window, resize_root_window)
11457 (resize_frame_windows): Declare prototypes.
11458
11459 * window.c (resize_window_apply): Make definition be "static" to
11460 match the prototype.
11461
562dd5e9
MR
114622011-06-10 Martin Rudalics <rudalics@gmx.at>
11463
11464 * window.c: Remove declarations of Qwindow_size_fixed,
11465 window_min_size_1, window_min_size_2, window_min_size,
11466 size_window, window_fixed_size_p, enlarge_window, delete_window.
11467 Remove static from declaration of Qdelete_window, it's
11468 temporarily needed by Fbury_buffer.
11469 (replace_window): Don't assign orig_top_line and
11470 orig_total_lines.
11471 (Fdelete_window, delete_window): Remove. Window deletion is
11472 handled by window.el.
640c8776
SM
11473 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11474 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11475 (Fdelete_other_windows): Remove. Deleting other windows is
11476 handled by window.el.
11477 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11478 handled in window.el.
11479 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11480 Window minimum sizes are handled in window.el.
11481 (shrink_windows, size_window, set_window_height)
11482 (set_window_width, change_window_heights, window_height)
11483 (window_width, CURBEG, CURSIZE, enlarge_window)
11484 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11485 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11486 handled in window.el.
11487 (make_dummy_parent): Rename to make_parent_window and give it a
11488 second argument horflag.
11489 (make_window): Don't set resize_proportionally any more.
11490 (Fsplit_window): Remove. Windows are split in window.el.
11491 (save_restore_action, save_restore_orig_size)
11492 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11493 Resize mini windows in window.el.
11494 (grow_mini_window, shrink_mini_window): Implement by calling
11495 Qresize_root_window_vertically, resize_window_check and
11496 resize_window_apply.
640c8776
SM
11497 (saved_window, Fset_window_configuration, save_window_save):
11498 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11499 resize_proportionally.
11500 (window_min_height, window_min_width): Move to window.el.
11501 (keys_of_window): Move bindings for delete-other-windows,
11502 split-window, delete-window and enlarge-window to window.el.
11503
11504 * buffer.c: Temporarily extern Qdelete_window.
11505 (Fbury_buffer): Temporarily call Qdelete_window instead of
11506 Fdelete_window (Fbury_buffer will move to window.el soon).
11507
11508 * frame.c (set_menu_bar_lines_1): Remove code handling
11509 orig_top_line and orig_total_lines.
11510
11511 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11512 set_window_height but set heights directly.
11513 (change_frame_size_1): Use resize_frame_windows.
11514
11515 * xdisp.c (init_xdisp): Don't use set_window_height but set
11516 heights directly.
11517
640c8776
SM
11518 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11519 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11520 run_window_configuration_change_hook.
11521
11522 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11523 instead of change_window_heights and run
11524 run_window_configuration_change_hook.
11525
1a13852e
MR
115262011-06-09 Martin Rudalics <rudalics@gmx.at>
11527
11528 * window.c (replace_window): Rename second argument REPLACEMENT to
11529 NEW. New third argument SETFLAG. Rewrite.
11530 (delete_window, make_dummy_parent): Call replace_window with
11531 third argument 1.
11532 (window_list_1): Move down in code.
11533 (run_window_configuration_change_hook): Move set_buffer part
11534 before select_frame_norecord part in order to unwind correctly.
11535 Rename count1 to count.
11536 (recombine_windows, delete_deletable_window, resize_root_window)
11537 (Fdelete_other_windows_internal)
11538 (Frun_window_configuration_change_hook, make_parent_window)
11539 (resize_window_check, resize_window_apply, Fresize_window_apply)
11540 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11541 (Fdelete_window_internal, Fresize_mini_window_internal):
11542 New functions.
1a13852e
MR
11543 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11544
f3d1777e
MR
115452011-06-08 Martin Rudalics <rudalics@gmx.at>
11546
496e208e
MR
11547 * window.h (window): Add some new members to window structure -
11548 normal_lines, normal_cols, new_total, new_normal, clone_number,
11549 splits, nest, prev_buffers, next_buffers.
11550 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11551 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11552
f3d1777e
MR
11553 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11554 Remove.
496e208e
MR
11555 (make_dummy_parent): Set new members of windows structure.
11556 (make_window): Move down in code. Handle new members of window
11557 structure.
11558 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11559 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11560 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11561 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11562 (Fset_window_next_buffers, Fset_window_clone_number):
11563 New functions.
496e208e
MR
11564 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11565 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11566 Doc-string fixes.
11567 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11568 Argument WINDOW can be now internal window too.
11569 (Fwindow_use_time): Move up in code.
11570 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11571 Rewrite doc-string.
11572 (Fset_window_configuration, saved_window)
11573 (Fcurrent_window_configuration, save_window_save): Handle new
11574 members of window structure.
b9e809c2
MR
11575 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11576 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11577 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11578 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11579 Qget_mru_window, Qresize_root_window,
11580 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11581 Qauto_buffer_name; staticpro them.
f3d1777e 11582
abde8f8c
MR
115832011-06-07 Martin Rudalics <rudalics@gmx.at>
11584
11585 * window.c (Fwindow_total_size, Fwindow_left_column)
11586 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11587 (Fwindow_list_1): New functions.
11588 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11589 (Fwindow_width, Fscroll_left, Fscroll_right):
11590 Use window_body_cols instead of window_box_text_cols.
11591 (delete_window, Fset_window_configuration):
11592 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11593 (delete_all_subwindows): Take a window as argument and not a
11594 structure. Rewrite.
190b47e6
MR
11595 (window_loop): Remove handling of GET_LRU_WINDOW and
11596 GET_LARGEST_WINDOW.
11597 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11598
11599 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11600 window_box_text_cols. delete_all_subwindows now takes a
11601 Lisp_Object as argument.
abde8f8c 11602
640c8776
SM
11603 * indent.c (compute_motion, Fcompute_motion):
11604 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11605
fa8a67e6
MR
11606 * frame.c (delete_frame): Call delete_all_subwindows with root
11607 window as argument.
11608
a54e3482
DC
116092011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11610
11611 * fns.c (Fputhash): Document return value.
11612
60002bf5
CY
116132011-06-06 Chong Yidong <cyd@stupidchicken.com>
11614
11615 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11616
0c671da6 116172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11618
b862a52a 11619 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11620
be44ca6c
PE
11621 Check for overflow when converting integer to cons and back.
11622 * charset.c (Fdefine_charset_internal, Fdecode_char):
11623 Use cons_to_unsigned to catch overflow.
11624 (Fencode_char): Use INTEGER_TO_CONS.
11625 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11626 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11627 * data.c (long_to_cons, cons_to_long): Remove.
11628 (cons_to_unsigned, cons_to_signed): New functions.
11629 These signal an error for invalid or out-of-range values.
11630 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11631 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11632 * font.c (Ffont_variation_glyphs):
11633 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11634 * lisp.h: Include <intprops.h>.
11635 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11636 (cons_to_signed, cons_to_unsigned): New decls.
11637 (long_to_cons, cons_to_long): Remove decls.
11638 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11639 (Fprimitive_undo): Use CONS_TO_INTEGER.
11640 * xfns.c (Fx_window_property): Likewise.
11641 * xselect.c: Include <limits.h>.
11642 (x_own_selection, selection_data_to_lisp_data):
11643 Use INTEGER_TO_CONS.
11644 (x_handle_selection_request, x_handle_selection_clear)
11645 (x_get_foreign_selection, Fx_disown_selection_internal)
11646 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11647 (lisp_data_to_selection_data): Use cons_to_unsigned.
11648 (x_fill_property_data): Use cons_to_signed.
11649 Report values out of range.
11650
d1f3d2af
PE
11651 Check for buffer and string overflow more precisely.
11652 * buffer.h (BUF_BYTES_MAX): New macro.
11653 * lisp.h (STRING_BYTES_MAX): New macro.
11654 * alloc.c (Fmake_string):
11655 * character.c (string_escape_byte8):
11656 * coding.c (coding_alloc_by_realloc):
11657 * doprnt.c (doprnt):
11658 * editfns.c (Fformat):
11659 * eval.c (verror):
11660 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11661 since they may not be the same number.
11662 * editfns.c (Finsert_char):
11663 * fileio.c (Finsert_file_contents):
11664 Likewise for BUF_BYTES_MAX.
11665
dd52fcea
PE
11666 * image.c: Use ptrdiff_t, not int, for sizes.
11667 (slurp_file): Switch from int to ptrdiff_t.
11668 All uses changed.
11669 (slurp_file): Check that file size fits in both size_t (for
11670 malloc) and ptrdiff_t (for sanity and safety).
11671
7f9bbdbb
PE
11672 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11673 if b->modtime has its maximal value.
11674
dfe18f82
PE
11675 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11676
84acfcf0
PE
11677 Don't assume time_t can fit into int.
11678 * buffer.h (struct buffer.modtime): Now time_t, not int.
11679 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11680 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11681
ccd9a01a
PE
11682 Minor fixes for signed vs unsigned integers.
11683 * character.h (MAYBE_UNIFY_CHAR):
11684 * charset.c (maybe_unify_char):
11685 * keyboard.c (read_char, reorder_modifiers):
11686 XINT -> XFASTINT, since the integer must be nonnegative.
11687 * ftfont.c (ftfont_spec_pattern):
11688 * keymap.c (access_keymap, silly_event_symbol_error):
11689 XUINT -> XFASTINT, since the integer must be nonnegative.
11690 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11691 since it makes no difference and we prefer signed.
11692 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11693 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11694 nonnegative.
11695
d6d100dd
SM
116962011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11697
11698 * window.h (Fwindow_frame): Declare.
11699
2b6148e4
PE
117002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11701
11702 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11703 (SPARE_MEMORY): Always define.
11704 (LARGE_REQUEST): Remove.
11705 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11706
f230ecc9
MR
117072011-06-06 Martin Rudalics <rudalics@gmx.at>
11708
727e958e
MR
11709 * lisp.h: Move EXFUNS for Fframe_root_window,
11710 Fframe_first_window and Fset_frame_selected_window to window.h.
11711
11712 * window.h: Move EXFUNS for Fframe_root_window,
11713 Fframe_first_window and Fset_frame_selected_window here from
11714 lisp.h.
11715
11716 * frame.c (Fwindow_frame, Fframe_first_window)
11717 (Fframe_root_window, Fframe_selected_window)
11718 (Fset_frame_selected_window): Move to window.c.
11719 (Factive_minibuffer_window): Move to minibuf.c.
11720 (Fother_visible_frames_p): New function.
11721
11722 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11723
f230ecc9
MR
11724 * window.c (decode_window, decode_any_window): Move up in code.
11725 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11726 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11727 (Fwindow_buffer): Move up and rewrite doc-string.
11728 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11729 (Fwindow_prev): New functions.
727e958e
MR
11730 (Fwindow_frame): Move here from frame.c. Accept any window as
11731 argument.
11732 (Fframe_root_window, Fframe_first_window)
11733 (Fframe_selected_window): Move here from frame.c. Accept frame
11734 or arbitrary window as argument. Update doc-strings.
11735 (Fminibuffer_window): Move up in code.
11736 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11737 (Fset_frame_selected_window): Move here from frame.c.
11738 Marginal rewrite.
727e958e
MR
11739 (Fselected_window, select_window, Fselect_window): Move up in
11740 code. Minor doc-string fixes.
f230ecc9 11741
4d09bcf6
PE
117422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11743
11744 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11745 Do not assume that spare memory exists; that assumption is valid
11746 only if SYSTEM_MALLOC.
11747 (LARGE_REQUEST): New macro, so that the issue of large requests
11748 is separated from the issue of spare memory.
11749
810928a2
AS
117502011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11751
172418ad
AS
11752 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11753 format. (Bug#8806)
11754
43f862f7
AS
11755 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11756
810928a2
AS
11757 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11758 before statements.
11759
a059fe24
JD
117602011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11761
11762 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11763
11764 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11765
11766 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11767 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11768
989bf368
JB
117692011-06-05 Juanma Barranquero <lekktu@gmail.com>
11770
11771 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11772
4b80f674
CY
117732011-06-04 Chong Yidong <cyd@stupidchicken.com>
11774
11775 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11776 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11777 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11778 New error handlers.
4b80f674
CY
11779 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11780 Obey Vx_select_enable_clipboard_manager. Catch errors in
11781 x_clipboard_manager_save (Bug#8779).
11782 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11783 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11784
99a33b77 117852011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11786
11787 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11788
99a33b77 117892011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11790
11791 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11792 in the current matrix if keep_current_p is non-zero.
11793
8264569d
EZ
117942011-06-04 Eli Zaretskii <eliz@gnu.org>
11795
11796 * bidi.c (bidi_level_of_next_char): Fix last change.
11797
57f97249
EZ
117982011-06-03 Eli Zaretskii <eliz@gnu.org>
11799
fec2107c 11800 Support bidi reordering of text covered by display properties.
57f97249 11801
fec2107c
EZ
11802 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11803 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11804 (bidi_cache_search, bidi_cache_iterator_state)
11805 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11806 (bidi_level_of_next_char, bidi_move_to_visually_next):
11807 Support character positions inside a run of characters covered by a
fec2107c
EZ
11808 display string.
11809 (bidi_paragraph_init, bidi_resolve_explicit_1)
11810 (bidi_level_of_next_char): Call bidi_fetch_char and
11811 bidi_fetch_char_advance instead of FETCH_CHAR and
11812 FETCH_CHAR_ADVANCE.
11813 (bidi_init_it): Initialize new members.
11814 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11815 definitions.
11816 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11817 instead of using explicit *_CHAR codes.
d6d100dd
SM
11818 (bidi_resolve_explicit, bidi_resolve_weak):
11819 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11820 bidirectional text is supported only in multibyte buffers.
11821 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11822 it to initialize the frame_window_p member of struct bidi_it.
11823 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11824 (bidi_resolve_explicit, bidi_resolve_weak)
11825 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11826 bidi_it->nchars is non-positive.
11827 (bidi_level_of_next_char): Don't try to lookup the cache for the
11828 next/previous character if nothing is cached there yet, or if we
11829 were just reseat()'ed to a new position.
c40e2fb2 11830
0e14fe90
EZ
11831 * xdisp.c (set_cursor_from_row): Set start and stop points
11832 according to the row's direction when priming the loop that looks
11833 for the glyph on which to display cursor.
11834 (single_display_spec_intangible_p): Function deleted.
11835 (display_prop_intangible_p): Reimplement to call
11836 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11837 Accept 3 additional arguments needed by handle_display_spec.
11838 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11839 values: lists, `(when COND...)' forms, etc.
11840 (single_display_spec_string_p): Support property values that are
11841 lists with the argument STRING its top-level element.
11842 (display_prop_string_p): Fix the condition for processing a
11843 property that is a list to be consistent with handle_display_spec.
fec2107c 11844 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11845 last portion of handle_display_prop.
11846 (compute_display_string_pos): Accept additional argument
11847 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11848 value of a `display' property is a "replacing spec".
11849 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11850 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11851 the display property, but just return a value indicating whether
11852 the display property will replace the characters it covers.
11853 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11854 frame_window_p members of struct bidi_it.
d6d100dd
SM
11855 (compute_display_string_pos, compute_display_string_end):
11856 New functions.
fec2107c
EZ
11857 (push_it): Accept second argument POSITION, where pop_it should
11858 jump to continue iteration.
11859 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11860
fec2107c
EZ
11861 * keyboard.c (adjust_point_for_property): Adjust the call to
11862 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11863
11864 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11865 (bidi_init_it): Update prototypes.
11866 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11867 (compute_display_string_pos, compute_display_string_end):
11868 Declare prototypes.
fec2107c
EZ
11869 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11870 EMACS_INT.
fc6f18ce 11871
40087514 118722011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11873
57f53182
PE
11874 Malloc failure behavior now depends on size of allocation.
11875 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11876 * lisp.h: Change signatures accordingly.
11877 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11878 All callers changed. (Bug#8762)
11879
11880 * gnutls.c: Use Emacs's memory allocators.
11881 Without this change, the gnutls library would invoke malloc etc.
11882 directly, which causes problems on non-SYNC_INPUT hosts, and which
11883 runs afoul of improving memory_full behavior. (Bug#8761)
11884 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11885 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11886 xfree instead of the default malloc, realloc, free.
11887 (Fgnutls_boot): No need to check for memory allocation failure,
11888 since xmalloc does that for us.
11889
ac32cd99 11890 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11891 * category.c (hash_get_category_set):
11892 * ccl.c (ccl_driver):
11893 * charset.c (Fdefine_charset_internal):
11894 * charset.h (struct charset.hash_index):
11895 * composite.c (get_composition_id, gstring_lookup_cache)
11896 (composition_gstring_put_cache):
11897 * composite.h (struct composition.hash_index):
11898 * dispextern.h (struct image.hash):
11899 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11900 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11901 (hashfn_equal, hashfn_user_defined, make_hash_table)
11902 (maybe_resize_hash_table, hash_lookup, hash_put)
11903 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11904 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11905 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11906 * image.c (make_image, search_image_cache, lookup_image)
11907 (xpm_put_color_table_h):
11908 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11909 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11910 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11911 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11912 * alloc.c (allocate_vectorlike):
11913 Check for overflow in vector size calculations.
11914 * ccl.c (ccl_driver):
11915 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11916 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11917 need to be updated by these changes.
40087514
PE
11918 * fns.c (make_hash_table, maybe_resize_hash_table):
11919 Check for integer overflow with large hash tables.
0de4bb68
PE
11920 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11921 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11922 (SXHASH_REDUCE): New macro.
11923 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11924 Use it instead of discarding useful hash info with large hash values.
11925 (sxhash_float): New function.
11926 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11927 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11928 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11929 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11930 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11931 Adjust signatures to match updated version of code.
11932 (consing_since_gc): Now EMACS_INT, since a single hash table can
11933 use more than INT_MAX bytes.
11934
698d32e2
DN
119352011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11936
11937 Make it possible to build with GCC-4.6+ -O2 -flto.
11938
11939 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11940
fd6fa53f
SM
119412011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11942
11943 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11944 Call minibuffer-inactive-mode.
11945
864db017
JB
119462011-05-31 Juanma Barranquero <lekktu@gmail.com>
11947
11948 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11949 Update dependencies.
11950
2ad0baf4
DN
119512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11952
11953 * data.c (init_data): Remove code for UTS, this system is not
11954 supported anymore.
11955
4fcc2638
DN
119562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11957
11958 Don't force ./temacs to start in terminal mode.
11959
11960 * frame.c (make_initial_frame): Initialize faces in all cases, not
11961 only when CANNOT_DUMP is defined.
11962 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11963
c56e0fd5
DN
119642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11965
11966 * dispnew.c (add_window_display_history): Use const for the string
11967 pointer. Remove declaration, not needed.
11968
333d54da 119692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11970
55d4c1b2 11971 Use 'inline', not 'INLINE'.
333d54da 11972 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11973 * alloc.c, fontset.c (INLINE): Remove.
11974 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11975 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11976 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11977 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11978 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11979
738db178
DN
119802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11981
11982 Make it possible to run ./temacs.
11983
11984 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11985 syms_of_callproc does the same thing. Remove test for
11986 "initialized", do it in the caller.
11987 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11988
620c53a6
SM
119892011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11990
11991 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11992 (read_minibuf): Use get_minibuffer.
11993 (syms_of_minibuf): Use DEFSYM.
11994 (Qmetadata): New var.
11995 * data.c (Qbuffer): Don't make it static.
11996 (syms_of_data): Use DEFSYM.
11997
e003a292
PE
119982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11999
12000 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
12001 (CCL_CODE_MIN): New macro.
12002
ed008a6d
PE
120032011-05-30 Paul Eggert <eggert@cs.ucla.edu>
12004
3687c2ef
PE
12005 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
12006
ed008a6d
PE
12007 * eval.c (Qdebug): Now static.
12008 * lisp.h (Qdebug): Remove decl. This reverts a part of the
12009 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
12010 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
12011
d66c4c7c
CY
120122011-05-29 Chong Yidong <cyd@stupidchicken.com>
12013
12014 * image.c: Various fixes to ImageMagick code comments.
12015 (Fimagemagick_types): Doc fix.
12016
5fbc2025
PE
120172011-05-29 Paul Eggert <eggert@cs.ucla.edu>
12018
0196f88a
PE
12019 Minor fixes prompted by GCC 4.6.0 warnings.
12020
12021 * xselect.c (converted_selections, conversion_fail_tag): Now static.
12022
5fbc2025
PE
12023 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
12024 (x_clipboard_manager_save_all): Move extern decl to ...
12025 * xterm.h: ... here, so that it can be checked for consistency.
12026
1dd3c2d9
CY
120272011-05-29 Chong Yidong <cyd@stupidchicken.com>
12028
12029 * xselect.c (x_clipboard_manager_save_frame)
12030 (x_clipboard_manager_save_all): New functions.
12031 (Fx_clipboard_manager_save): Lisp function deleted.
12032
12033 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
12034 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
12035
12036 * xterm.h: Update prototype.
12037
5ba6571d
WX
120382011-05-28 William Xu <william.xwl@gmail.com>
12039
12040 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
12041 exiting (Bug#8239).
12042
3eaff834
JM
120432011-05-28 Jim Meyering <meyering@redhat.com>
12044
e1900994 12045 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
12046 * fns.c (to_uchar): Define.
12047 (crypto_hash_function): Use it to convert some newly-signed
12048 variables to unsigned, to avoid sign-extension bugs. For example,
12049 without this change, (md5 "truc") would evaluate to
12050 45723a2aff78ff4fff7fff1114760e62 rather than the expected
12051 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 12052 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 12053
0f6990a7
PE
120542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12055
12056 Integer overflow fixes.
c8a9ca5a 12057
08686060
PE
12058 * dbusbind.c: Serial number integer overflow fixes.
12059 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
12060 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
12061 to hold a serial number that is too large for a fixnum.
12062 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12063 Check for serial numbers out of range. Decode any serial number
59568bf0 12064 that was so large that it became a float. (Bug#8722)
08686060 12065
2d1fc3c7
PE
12066 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
12067 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12068 Use XFASTINT rather than XUINT when numbers are nonnegative.
12069 (xd_append_arg, Fdbus_method_return_internal):
12070 (Fdbus_method_error_internal): Likewise. Also, for unsigned
12071 arguments, check that Lisp number is nonnegative, rather than
59568bf0 12072 silently wrapping negative numbers around. (Bug#8722)
30217ff0 12073 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 12074 (Bug#8722)
2d1fc3c7 12075
c8a9ca5a
PE
12076 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
12077
519e1d69
PE
12078 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
12079
6df6ae42 12080 ccl: Add integer overflow checks.
30569699
PE
12081 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
12082 (IN_INT_RANGE): New macros.
12083 (ccl_driver): Use them to check for integer overflow when
12084 decoding a CCL program. Many of the new checks are whether XINT (x)
12085 fits in int; it doesn't always, on 64-bit hosts. The new version
12086 doesn't catch all possible integer overflows, but it's an
847044ea 12087 improvement. (Bug#8719)
30569699 12088
c11285dc
PE
12089 * alloc.c (make_event_array): Use XINT, not XUINT.
12090 There's no need for unsigned here.
12091
fdccd48e
PE
12092 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
12093 This follows up to the 2011-05-06 change that substituted uintptr_t
12094 for EMACS_INT. This case wasn't caught back then.
12095
37910ab2
PE
12096 Rework Fformat to avoid integer overflow issues.
12097 * editfns.c: Include <float.h> unconditionally, as it's everywhere
12098 now (part of C89). Include <verify.h>.
12099 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
12100 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
12101 (Fformat): Avoid the prepass trying to compute sizes; it was only
12102 approximate and thus did not catch overflow reliably. Instead, walk
12103 through the format just once, formatting and computing sizes as we go,
12104 checking for integer overflow at every step, and allocating a larger
12105 buffer as needed. Keep track separately whether the format is
12106 multibyte. Keep only the most-recently calculated precision, rather
12107 than them all. Record whether each argument has been converted to
12108 string. Use EMACS_INT, not int, for byte and char and arg counts.
12109 Support field widths and precisions larger than INT_MAX. Avoid
12110 sprintf's undefined behavior with conversion specifications such as %#d
12111 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
12112 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
12113 formatting out-of-range floating point numbers with int
9173deec 12114 formats. (Bug#8668)
37910ab2 12115
2e6578fb
PE
12116 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
12117
0ae6bdee
PE
12118 * data.c: Avoid integer truncation in expressions involving floats.
12119 * data.c: Include <intprops.h>.
12120 (arith_driver): When there's an integer overflow in an expression
12121 involving floating point, convert the integers to floating point
12122 so that the resulting value does not suffer from catastrophic
12123 integer truncation. For example, on a 64-bit host (* 4
12124 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
12125 Do not rely on undefined behavior after integer overflow.
12126
de883a70
PE
12127 merge count_size_as_multibyte, parse_str_to_multibyte
12128 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 12129 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
12130 Check for integer overflow.
12131 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
12132 since it's now a duplicate of the other. This is more of
12133 a character than a buffer op, so better that it's in character.c.
12134 * fns.c, print.c: Adjust to above changes.
12135
2ff916cb
PE
121362011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
12137
12138 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
12139
f1b54466
PE
121402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12141
fb1ac845
PE
12142 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12143 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
12144 (x_clipboard_manager_save): Now static.
12145 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
12146
f1b54466
PE
12147 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12148 (crypto_hash_function): Now static.
12149 Fix pointer signedness problems. Avoid unnecessary initializations.
12150
a9f737ee
CY
121512011-05-27 Chong Yidong <cyd@stupidchicken.com>
12152
12153 * termhooks.h (Vselection_alist): Make it terminal-local.
12154
12155 * terminal.c (create_terminal): Initialize it.
12156
12157 * xselect.c: Support for clipboard managers.
12158 (Vselection_alist): Move to termhooks.h as terminal-local var.
12159 (LOCAL_SELECTION): New macro.
12160 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
12161 (symbol_to_x_atom): Remove gratuitous arg.
12162 (x_handle_selection_request, lisp_data_to_selection_data)
12163 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
12164 (x_own_selection, x_get_local_selection, x_convert_selection):
12165 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
12166 (some_frame_on_display): Delete unused function.
12167 (Fx_own_selection_internal, Fx_get_selection_internal)
12168 (Fx_disown_selection_internal, Fx_selection_owner_p)
12169 (Fx_selection_exists_p): New optional frame arg.
12170 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12171 (x_handle_selection_clear): Don't treat other terminals with the
12172 same keyboard specially. Use the terminal-local Vselection_alist.
12173 (x_clear_frame_selections): Use Frun_hook_with_args.
12174
12175 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12176
12177 * xterm.h: Add support for those atoms.
12178
e067f0c1
CY
121792011-05-26 Chong Yidong <cyd@stupidchicken.com>
12180
12181 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12182 (converted_selections, conversion_fail_tag): New global variables.
12183 (x_selection_request_lisp_error): Free the above.
12184 (x_get_local_selection): Remove unnecessary code.
12185 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12186 of converted selections stored in converted_selections.
12187 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12188 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12189 (x_convert_selection): New function.
12190 (x_handle_selection_event): Simplify.
12191 (x_get_foreign_selection): Don't ignore incoming requests while
12192 waiting for an answer; this will fail when we implement
12193 SAVE_TARGETS, and seems unnecessary anyway.
12194 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12195 (Vx_sent_selection_functions): Doc fix.
12196
0f4aebc0
LL
121972011-05-26 Leo Liu <sdl.web@gmail.com>
12198
12199 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12200
e61124cd
YM
122012011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12202
12203 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12204
12205 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12206 for fringe update if it has periodic bitmap.
ac389d0c 12207 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12208 and fringe_bitmap_periodic_p.
12209
12210 * fringe.c (get_fringe_bitmap_data): New function.
12211 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12212 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12213 row. Mark glyph row for fringe update if periodicity changed.
12214
12215 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12216 for fringe update unless it has periodic bitmap.
12217
f16d9837
KH
122182011-05-25 Kenichi Handa <handa@m17n.org>
12219
12220 * xdisp.c (get_next_display_element): Set correct it->face_id for
12221 a static composition.
12222
e1b90ef6
LL
122232011-05-24 Leo Liu <sdl.web@gmail.com>
12224
12225 * deps.mk (fns.o):
12226 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12227
12228 * fns.c (crypto_hash_function, Fsha1): New function.
12229 (Fmd5): Use crypto_hash_function.
12230 (syms_of_fns): Add Ssha1.
12231
7400048f
PE
122322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12233
12234 * gnutls.c: Remove unused macros.
12235 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12236 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12237 Remove macros that are defined and never used.
12238 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12239
abb71cf4
CY
122402011-05-22 Chong Yidong <cyd@stupidchicken.com>
12241
12242 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12243 (Fx_get_selection_internal): Minor cleanup.
12244 (Fx_own_selection_internal): Rename arguments for consistency with
12245 select.el.
12246
6307db39
PE
122472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12248
12249 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12250
f3d4e0a4
CY
122512011-05-22 Chong Yidong <cyd@stupidchicken.com>
12252
12253 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12254
4d8ade89
YM
122552011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12256
12257 * dispnew.c (scrolling_window): Don't exclude the case that the
12258 last enabled row in the desired matrix touches the bottom boundary.
12259
32078c8d
GM
122602011-05-21 Glenn Morris <rgm@gnu.org>
12261
12262 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12263 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12264 and add some more files.
32078c8d 12265
7285dc67
EZ
122662011-05-20 Eli Zaretskii <eliz@gnu.org>
12267
12268 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12269 report_file_error introduced by the change from 2011-05-07.
12270
89d1bd22
PE
122712011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12272
12273 * systime.h (Time): Define only if emacs is defined.
12274 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12275 where the include path doesn't have X11/X.h by default. See
12276 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12277
cd394be1 122782011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12279
12280 * composite.c (find_automatic_composition): Fix previous change.
12281
b9704ad9
GM
122822011-05-20 Glenn Morris <rgm@gnu.org>
12283
12284 * lisp.mk: New file, split from Makefile.in.
12285 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12286 (shortlisp): Remove.
12287 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12288
4a720484
GM
122892011-05-19 Glenn Morris <rgm@gnu.org>
12290
12291 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12292 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12293 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12294 (lisp): Set the order to that of loadup.el.
12295 (shortlisp): Make it a copy of $lisp.
12296 (SOME_MACHINE_LISP): Remove.
12297 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12298 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12299
a28d4396
KH
123002011-05-18 Kenichi Handa <handa@m17n.org>
12301
12302 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12303 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12304 (find_automatic_composition): Mostly rewrite for efficiency.
12305
a2b1fa8e
JB
123062011-05-18 Juanma Barranquero <lekktu@gmail.com>
12307
12308 * makefile.w32-in: Update dependencies.
12309
8e1f5610
CS
123102011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12311
12312 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12313 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12314
7025ee00 123152011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12316
cdfa6eab
PE
12317 Fix some integer overflow issues, such as string length overflow.
12318
06d6db33
PE
12319 * insdel.c (count_size_as_multibyte): Check for string overflow.
12320
2b4560a8
PE
12321 * character.c (lisp_string_width): Check for string overflow.
12322 Use EMACS_INT, not int, for string indexes and lengths; in
12323 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12324 the resulting string length overflows an EMACS_INT; instead,
12325 report a string overflow if no precision given. When checking for
12326 precision exhaustion, use a check that cannot possibly have
12327 integer overflow. (Bug#8675)
12328 * character.h (lisp_string_width): Adjust to new signature.
12329
cb93f9be
PE
12330 * alloc.c (string_overflow): New function.
12331 (Fmake_string): Use it. This doesn't change behavior, but saves
12332 a few bytes and will simplify future changes.
12333 * character.c (string_escape_byte8): Likewise.
12334 * lisp.h (string_overflow): New decl.
12335
1a1f3366
PE
12336 Fixups, following up to the user-interface timestamp change.
12337 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12338 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12339 * msdos.c (mouse_get_pos): Likewise.
12340 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12341 * w32gui.h (Time): Define by including "systime.h" rather than by
12342 declaring it ourselves. (Bug#8664)
12343
d4e3e4d3
PE
12344 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12345 * image.c (clear_image_cache): Likewise.
12346
f6a24d19
PE
12347 * term.c (term_mouse_position): Don't assume time_t wraparound.
12348
08dc5ae6
PE
12349 Be more systematic about user-interface timestamps.
12350 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12351 and sometimes 'EMACS_UINT', to represent these timestamps.
12352 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12353 This makes the code easier to follow, and makes it easier to catch
12354 integer overflow bugs such as Bug#8664.
12355 * frame.c (Fmouse_position, Fmouse_pixel_position):
12356 Use Time, not unsigned long, for user-interface timestamps.
12357 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12358 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12359 * keyboard.h (last_event_timestamp): Likewise.
12360 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12361 * menu.h (xmenu_show): Likewise.
12362 * term.c (term_mouse_position): Likewise.
12363 * termhooks.h (struct input_event.timestamp): Likewise.
12364 (struct terminal.mouse_position_hook): Likewise.
12365 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12366 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12367 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12368 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12369 what it was before.
12370 * menu.h, termhooks.h: Include "systime.h", for Time.
12371
8e55734a
PE
12372 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12373 Don't assume that the difference between two unsigned long values
12374 can fit into an integer. At this point, we know button_down_time
12375 <= event->timestamp, so the difference must be nonnegative, so
12376 there's no need to cast the result if double-click-time is
12377 nonnegative, as it should be; check that it's nonnegative, just in
12378 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12379 apart (about 25 days). (Bug#8664)
8e55734a 12380
841f1b75 12381 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12382 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12383
3e26f69c
PE
12384 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12385 that always fit in int. Use a sentinel instead of a counter, to
12386 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12387 * frame.h (struct frame): Use int for menu_bar_items_used
12388 instead of EMACS_INT, since it always fits in int.
3e26f69c 12389
5cc152c0
PE
12390 * menu.c (grow_menu_items): Check for int overflow.
12391
d89eb65e
PE
12392 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12393
5235bd3e
PE
12394 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12395 Before, the code was not consistent. These values cannot exceed
12396 2**31 - 1 so there's no need to make them unsigned.
12397 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12398 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12399 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12400 as modifiers.
12401 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12402
bc827e23
PE
12403 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12404 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12405 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12406 presumably because the widths might not match.
12407
78eb494e
PE
12408 * window.c (size_window): Avoid needless test at loop start.
12409
04f2d78b
CB
124102011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12411
12412 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12413
d2fc7e3d 124142011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12415
12416 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12417
d2fc7e3d 124182011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12419
12420 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12421 `width' to `bar_area_x' and `bar_area_width', respectively.
12422 (x_scroll_run): Take account of fringe background extension.
12423
04f2d78b
CB
12424 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12425 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12426 `bar_area_width', respectively.
12427 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12428 background extension.
12429
79b70037
GM
124302011-05-10 Jim Meyering <meyering@redhat.com>
12431
12432 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12433
2f142cc5
JB
124342011-05-10 Juanma Barranquero <lekktu@gmail.com>
12435
12436 * image.c (Finit_image_library): Return t for built-in image types,
12437 like pbm and xbm. (Bug#8640)
12438
57679c86
AS
124392011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12440
12441 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12442
888c9e86
EZ
124432011-05-07 Eli Zaretskii <eliz@gnu.org>
12444
b0512a1d
EZ
12445 * w32console.c (Fset_screen_color): Doc fix.
12446 (Fget_screen_color): New function.
12447 (syms_of_ntterm): Defsubr it.
12448
7285dc67
EZ
12449 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12450 unlink the temporary file if Fcall_process didn't create it in the
12451 first place.
12452 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12453 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12454 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12455 cue to call_process_cleanup not to close that handle.
12456
4d3fcc8e
BK
124572011-05-07 Ben Key <bkey76@gmail.com>
12458
12459 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12460 one of two shell specific rules, either bootstrap-temacs-CMD or
12461 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12462 to the previous implementation of the bootstrap-temacs rule.
12463 The bootstrap-temacs-CMD rule is similar to the previous
12464 implementation of the bootstrap-temacs rule except that it
12465 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12466 variable.
12467
12468 These changes, along with some changes to nt/configure.bat,
12469 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12470 earlier fix to add support for --cflags and --ldflags options
12471 that include quotes so that it works whether make uses cmd or
12472 sh as the shell.
12473
b4289b64
MA
124742011-05-06 Michael Albinus <michael.albinus@gmx.de>
12475
12476 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12477 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12478 is a constant.
12479 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12480 a string. Handle both cases.
12481 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12482 (Fdbus_register_method): Use Qinvalid_function.
12483
af4c0e28
JB
124842011-05-06 Juanma Barranquero <lekktu@gmail.com>
12485
12486 * makefile.w32-in: Update dependencies.
12487 (LISP_H): Add inttypes.h and stdin.h.
12488 (PROCESS_H): Add unistd.h.
12489
c51453d9
EZ
124902011-05-06 Eli Zaretskii <eliz@gnu.org>
12491
12492 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12493 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12494
8ff0ac3c 124952011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12496
4c4b566b
PE
12497 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12498
aab2b9b5
PE
12499 * term.c (vfatal): Remove stray call to va_end.
12500 It's not needed and the C Standard doesn't allow it here anyway.
12501
c378da0b
PE
12502 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12503 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12504
288b08c7
PE
12505 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12506 bytes.
12507
e3601888
PE
12508 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12509
db6c0e74
PE
12510 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12511
dd5963ea
PE
12512 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12513
88c9450f
PE
12514 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12515
2f9442b8
PE
12516 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12517
c032b5f8
PE
12518 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12519 * charset.c (Fdefine_charset_internal): Don't initialize
12520 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12521 32-bit int (Bug#8600).
a108c10b
PE
12522
12523 * lread.c (read_integer): Be more consistent with string-to-number.
12524 Use string_to_number to do the actual conversion; this avoids
12525 rounding errors and fixes some other screwups. Without this fix,
12526 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12527 (digit_to_number): Move earlier, for benefit of read_integer.
12528 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12529 not a digit in any supported base. (Bug#8602)
a108c10b 12530
ad5f9eea
PE
12531 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12532
aec1708a
PE
12533 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12534 to match comment at start of function. This also removes a
12535 GCC warning about overflow in a 32+64-bit port.
12536
47be4ab5
PE
12537 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12538
371cac43
PE
12539 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12540 Reported by Stefan Monnier in
12541 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12542 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12543 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12544
d01a7826
PE
12545 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12546 (EMACS_UINTPTR): Likewise, with uintptr_t.
12547
7fd47d5c
PE
12548 * lisp.h: Prefer 64-bit EMACS_INT if available.
12549 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12550 on 32-bit hosts that have 64-bit int, so that they can access
12551 large files.
122b0c86
PE
12552 However, temporarily disable this change unless the temporary
12553 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12554
8727937b
PE
12555 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12556
8ac068ac
PE
12557 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12558 This removes an assumption that EMACS_INT and long are the same
12559 width as pointers. The assumption is true for Emacs porting targets
12560 now, but we want to make other targets possible.
12561 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12562 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12563 In the rest of the code, change types of integers that hold casted
12564 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12565 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12566 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12567 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12568 No need to cast type when ORing.
12569 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12570 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12571 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12572 assume EMACS_INT is the same width as char *.
12573 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12574 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12575 Remove no-longer-needed casts.
12576 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12577 (xg_tool_bar_help_callback, xg_make_tool_item):
12578 Use EMACS_INTPTR to hold an integer
12579 that will be cast to void *; this can avoid a GCC warning
12580 if EMACS_INT is not the same width as void *.
12581 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12582 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12583 (current_message_1, set_message_1):
12584 Use a local to convert to proper width without a cast.
12585 * xmenu.c (dialog_selection_callback): Likewise.
12586
ede49d71
PE
12587 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12588 Also, don't assume VALBITS / RAND_BITS is less than 5,
12589 and don't rely on undefined behavior when shifting a 1 left into
12590 the sign bit.
12591 * lisp.h (get_random): Change signature to match.
12592
2f30ecd0
PE
12593 * lread.c (hash_string): Use size_t, not int, for hash computation.
12594 Normally we prefer signed values; but hashing is special, because
12595 it's better to use unsigned division on hash table sizes so that
12596 the remainder is nonnegative. Also, size_t is the natural width
12597 for hashing into memory. The previous code used 'int', which doesn't
12598 retain enough info to hash well into very large tables.
12599 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12600
2a866e7b
PE
12601 * dbusbind.c: Don't possibly lose pointer info when converting.
12602 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12603 Use XPNTR rather than XHASH, so that the high-order bits of
12604 the pointer aren't lost when converting through void *.
12605
51639eac
PE
12606 * eval.c (Fautoload): Don't double-shift a pointer.
12607
92394119
PE
12608 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12609
dbdb9a7c
JB
126102011-05-06 Juanma Barranquero <lekktu@gmail.com>
12611
12612 * gnutls.c (DEF_GNUTLS_FN):
12613 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12614
db7a0b4f
AS
126152011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12616
12617 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12618 marker. (Bug#8610)
12619
cd394be1 126202011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12621
12622 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12623 New version that can reserve upto 2GB of heap space.
12624
f7ff1b0f 126252011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12626
12627 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12628
639c109b
TZ
126292011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12630
12631 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12632 `gnutls_certificate_set_x509_key_file'.
12633
d2127135
JB
126342011-05-05 Juanma Barranquero <lekktu@gmail.com>
12635
12636 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12637 Update dependencies.
12638
e968f4f3
JB
126392011-05-04 Juanma Barranquero <lekktu@gmail.com>
12640
12641 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12642 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12643 Remove unused parameter `fildes'.
12644 * process.c (read_process_output, send_process): Don't pass it.
12645
84d358f0
JB
126462011-05-04 Juanma Barranquero <lekktu@gmail.com>
12647
12648 Fix previous change: the library cache is defined in w32.c.
12649 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12650 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12651
0898ca10
JB
126522011-05-04 Juanma Barranquero <lekktu@gmail.com>
12653
12654 Implement dynamic loading of GnuTLS on Windows.
12655
12656 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12657 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12658 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12659 Declare.
12660
12661 * gnutls.c (Qgnutls_dll): Define.
12662 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12663 (gnutls_*): Declare function pointers.
12664 (init_gnutls_functions): New function to initialize function pointers.
12665 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12666 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12667 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12668 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12669 (emacs_gnutls_write, emacs_gnutls_read)
12670 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12671 (Fgnutls_available_p): New function.
12672 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12673 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12674 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12675
12676 * image.c: Include w32.h.
12677 (Vimage_type_cache): Delete.
12678 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12679 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12680 (w32_delayed_load): Move to w32.c.
12681
12682 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12683
12684 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12685 (w32_delayed_load): Move from image.c. When loading a library, record
12686 its filename in the :loaded-from property of the library id.
12687 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12688 Initialize and staticpro them.
12689 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12690
12691 * process.c: Include lisp.h before w32.h, not after.
12692 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12693 instead of gnutls_record_check_pending.
12694
12695 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12696
ff4de4aa
TZ
126972011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12698
12699 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12700 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12701 as passed in.
12702
abe95abb
JD
127032011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12704
12705 * xterm.c (x_set_frame_alpha): Do not set property on anything
12706 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12707
e16e55d4
JB
127082011-05-02 Juanma Barranquero <lekktu@gmail.com>
12709
12710 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12711
bafcf6a5
JB
127122011-05-02 Juanma Barranquero <lekktu@gmail.com>
12713
12714 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12715 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12716 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12717 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12718 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12719 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12720 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12721 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12722 (Qgnutls_bootprop_callbacks_verify): Make static.
12723
e7a6747f
AS
127242011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12725
19ed11ba
AS
12726 * callproc.c: Indentation fixup.
12727
e7a6747f 12728 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12729 (wait_for_termination, interruptible_wait_for_termination):
12730 Move after wait_for_termination_1.
e7a6747f 12731
1ef14cb4
LMI
127322011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12733
12734 * sysdep.c (interruptible_wait_for_termination): New function
12735 which is like wait_for_termination, but allows keyboard
12736 interruptions.
12737
12738 * callproc.c (Fcall_process): Add (:file "file") as an option for
12739 the STDOUT buffer.
12740 (Fcall_process_region): Ditto.
12741
330d880c
EZ
127422011-04-30 Eli Zaretskii <eliz@gnu.org>
12743
8db90b73
EZ
12744 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12745 rather than `XVECTOR (FOO)->size'.
12746
330d880c
EZ
12747 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12748 inttypes.h, as a gnulib replacement is used if it not available in
12749 system headers.
12750
15cbd324
EZ
127512011-04-21 Eli Zaretskii <eliz@gnu.org>
12752
12753 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12754 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12755 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12756
12757 * coding.c (coding_alloc_by_realloc): Error out if destination
12758 will grow beyond MOST_POSITIVE_FIXNUM.
12759 (decode_coding_emacs_mule): Abort if there isn't enough place in
12760 charbuf for the composition carryover bytes. Reserve an extra
12761 space for up to 2 characters produced in a loop.
12762 (decode_coding_iso_2022): Abort if there isn't enough place in
12763 charbuf for the composition carryover bytes.
12764
127652011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12766
ae940cca
EZ
12767 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12768 aborting when %lld or %lll format is passed.
12769 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12770 %llo or %llx format is passed. (Bug#8545)
12771
03ab8921
EZ
12772 * window.c (window_scroll_line_based): Use a marker instead of
12773 simple variables to record original value of point. (Bug#7952)
12774
afda1437
EZ
12775 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12776 produced by %s or %c overflows available buffer space. (Bug#8545)
12777
f76dee0c
PE
127782011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12779
12780 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12781 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12782
fdc5744d
JB
127832011-04-28 Juanma Barranquero <lekktu@gmail.com>
12784
12785 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12786
638f053a
JB
127872011-04-28 Juanma Barranquero <lekktu@gmail.com>
12788
12789 * keyboard.c (Qdelayed_warnings_hook): Define.
12790 (command_loop_1): Run `delayed-warnings-hook'
12791 if Vdelayed_warnings_list is non-nil.
12792 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12793 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12794
d178f871
EZ
127952011-04-28 Eli Zaretskii <eliz@gnu.org>
12796
12797 * doprnt.c (doprnt): Don't return value smaller than the buffer
12798 size if the message was truncated. (Bug#8545).
12799
b124fd93
JB
128002011-04-28 Juanma Barranquero <lekktu@gmail.com>
12801
12802 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12803 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12804
e810457d
PE
128052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12806
12807 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12808
ea51cceb
JB
128092011-04-27 Juanma Barranquero <lekktu@gmail.com>
12810
12811 * makefile.w32-in: Update dependencies.
12812
94dcfacf
EZ
128132011-04-27 Eli Zaretskii <eliz@gnu.org>
12814
12815 Improve `doprnt' and its usage. (Bug#8545)
12816 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12817 `format_end'. Remove support for %l as a conversion specifier.
12818 Don't use xrealloc. Improve diagnostics when the %l size modifier
12819 is used. Update the commentary.
12820
12821 * eval.c (verror): Simplify calculation of size_t.
12822
12823 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12824 messages.
12825
f61f41d7
PE
128262011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12827
12828 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12829 change.
12830
96fb4434
PE
128312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12832
12833 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12834 This makes this file independent of the recent pseudovector change.
12835
671875da 128362011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12837
69e9b5a3
PE
12838 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12839
b5f869a7 12840 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12841 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12842 Remove unused local.
c8926152 12843 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12844
841a1577 12845 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12846 GCC 4.6.0 optimizes based on type-based alias analysis.
12847 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12848 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12849 != &v->size, and therefore "v->size = 1; b->size = 2; return
12850 v->size;" must therefore return 1. This assumption is incorrect
12851 for Emacs, since it type-puns struct Lisp_Vector * with many other
12852 types. To fix this problem, this patch adds a new type struct
f904488f 12853 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12854 and pseudovectors, and helps optimizing compilers not get fooled
12855 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12856 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12857 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12858 the size member.
eab3844f
PE
12859 (XSETPVECTYPE): Rewrite in terms of new macro.
12860 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12861 This is a bit clearer, and further avoids the possibility of
12862 undesirable aliasing.
12863 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12864 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12865 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12866 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12867 (ASIZE): Now uses header.size rather than size.
12868 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12869 to avoid the hassle of writing XVECTOR (foo)->header.size.
12870 (struct vectorlike_header): New type.
eab3844f
PE
12871 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12872 object, to help avoid aliasing.
12873 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12874 (SUBRP): Likewise, since Lisp_Subr is a special case.
12875 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12876 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12877 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12878 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12879 changed to be "header.size" and "header.next".
12880 * buffer.h (struct buffer): Likewise.
12881 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12882 * frame.h (struct frame): Likewise.
12883 * process.h (struct Lisp_Process): Likewise.
12884 * termhooks.h (struct terminal): Likewise.
12885 * window.c (struct save_window_data, struct saved_window): Likewise.
12886 * window.h (struct window): Likewise.
12887 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12888 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12889 * buffer.c (init_buffer_once): Likewise.
12890 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12891 special case.
12892 * process.c (Fformat_network_address): Use local var for size,
12893 for brevity.
12894
0df1eac5
PE
12895 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12896
847ab9d1 12897 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12898 * data.c (atof): Remove decl; no longer used or needed.
12899 (digit_to_number): Move to lread.c.
12900 (Fstring_to_number): Use new string_to_number function, to be
12901 consistent with how the Lisp reader treats infinities and NaNs.
12902 Do not assume that floating-point numbers represent EMACS_INT
12903 without losing information; this is not true on most 64-bit hosts.
12904 Avoid double-rounding errors, by insisting on integers when
12905 parsing non-base-10 numbers, as the documentation specifies.
12906 * lisp.h (string_to_number): New decl, replacing ...
12907 (isfloat_string): Remove.
bc0a5c13 12908 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12909 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12910 appears to have been a coding error. Similarly, do not accept
12911 strings like +-1e0 as floating point numbers. Do not report
12912 overflow for integer overflows unless the base is not 10 which
12913 means we have no simple and reliable way to continue.
12914 Break out the floating-point parsing into a new
12915 function string_to_number, so that Fstring_to_number parses
12916 floating point numbers consistently with the Lisp reader.
04f2d78b 12917 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12918 (E_CHAR, EXP_INT): Remove, replacing with ...
12919 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12920 (string_to_number): New function, replacing isfloat_string.
12921 This function checks for valid syntax and produces the resulting
12922 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12923 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12924 so that overflow for non-base-10 numbers is reported only when
12925 there's no portable and simple way to convert to floating point.
452f4150 12926
67769ffc
PE
12927 * textprop.c (set_text_properties_1): Rewrite for clarity,
12928 and to avoid GCC warning about integer overflow.
12929
c20db43f
PE
12930 * intervals.h (struct interval): Use EMACS_INT for members
12931 where EMACS_UINT might cause problems. See
12932 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12933 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12934 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12935 All uses changed.
37aa2f85
PE
12936 (offset_intervals): Tell GCC not to worry about length overflow
12937 when negating a negative length.
c20db43f 12938
2538aa2f
PE
12939 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12940 (overrun_check_free): Likewise.
12941
f2d3008d
PE
12942 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12943 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12944 word size.
12945
ec8df744
PE
12946 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12947 (gnutls_make_error): Rename local to avoid shadowing.
12948 (gnutls_emacs_global_deinit): ifdef out; not used.
12949 (Fgnutls_boot): Use const for pointer to readonly storage.
12950 Comment out unused local. Fix pointer signedness problems.
12951
640ee02d
PE
12952 * lread.c (openp): Don't stuff size_t into an 'int'.
12953 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12954 about possible signed overflow.
12955
6048fb2a
PE
12956 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12957 (GDK_KEY_g): Don't define if already defined.
12958 (xg_prepare_tooltip): Avoid pointer signedness problem.
12959 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12960
fa3c87e1
PE
12961 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12962 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12963
2172544b
PE
12964 * xfns.c (Fx_window_property): Simplify a bit,
12965 to make a bit faster and to avoid GCC 4.6.0 warning.
12966 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12967
9b821a21
PE
12968 * fns.c (internal_equal): Don't assume size_t fits in int.
12969
3c616cfa
PE
12970 * alloc.c (compact_small_strings): Tighten assertion a little.
12971
c2982e87
PE
12972 Replace pEd with more-general pI, and fix some printf arg casts.
12973 * lisp.h (pI): New macro, generalizing old pEd macro to other
12974 conversion specifiers. For example, use "...%"pI"d..." rather
12975 than "...%"pEd"...".
12976 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12977 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12978 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12979 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12980 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12981 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12982 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12983 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12984 64-bit hosts.
12985 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12986 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12987 * print.c (safe_debug_print, print_object): Likewise.
12988 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12989 to int.
6f04d126
PE
12990 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12991 avoiding the 0 flag, which is not portable.
c2982e87
PE
12992 * process.c (Fmake_network_process): Use pI to avoid cast.
12993 * region-cache.c (pp_cache): Likewise.
12994 * xdisp.c (decode_mode_spec): Likewise.
12995 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12996 behavior on 64-bit hosts with printf arg.
6f04d126 12997 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12998 (x_stop_queuing_selection_requests): Likewise.
12999 (x_get_window_property): Don't truncate byte count to an 'int'
13000 when tracing.
0b432f21 13001
5e073ec7
PE
13002 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
13003 here, since it parses constructs like leading '-' and spaces,
13004 which are not wanted; and it overflows with large numbers.
13005 Instead, simply match F[0-9]+, which is what is wanted anyway.
13006
36372bf9
PE
13007 * alloc.c: Remove unportable assumptions about struct layout.
13008 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
13009 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
13010 (allocate_vectorlike, make_pure_vector): Use the new macros,
13011 plus offsetof, to remove unportable assumptions about struct layout.
13012 These assumptions hold on all porting targets that I know of, but
13013 they are not guaranteed, they're easy to remove, and removing them
13014 makes further changes easier.
13015
0b432f21
PE
13016 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
13017 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
13018 (string_overrun_cookie): Now const. Use initializers that
13019 don't formally overflow signed char, to avoid warnings.
000098c1
PE
13020 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
13021 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
13022 (allocate_buffer): Don't assume sizeof (struct buffer) is a
13023 multiple of sizeof (EMACS_INT); it need not be, if
13024 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 13025 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 13026
895009e1
JB
130272011-04-26 Juanma Barranquero <lekktu@gmail.com>
13028
13029 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
13030
6a7a1b0b
TZ
130312011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
13032
13033 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 13034 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
13035 Reported by Paul Eggert <eggert@cs.ucla.edu>.
13036
841a1577 130372011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
13038
13039 * lisp.h (Qdebug): List symbol.
895009e1 13040 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
13041 * keyboard.c (debug-on-event): New variable.
13042 (handle_user_signal): Break into debugger when debug-on-event
13043 matches the current signal symbol.
13044
f2d3ba6f
DN
130452011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
13046
13047 * alloc.c (check_sblock, check_string_bytes)
13048 (check_string_free_list): Convert to standard C.
13049
42ce4c63
TZ
130502011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
13051
13052 * w32.c (emacs_gnutls_push): Fix typo.
13053
825cd63c
EZ
130542011-04-25 Eli Zaretskii <eliz@gnu.org>
13055
fb11d64d
EZ
13056 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
13057 "cast to pointer from integer of different size".
13058
825cd63c
EZ
13059 Improve doprnt and its use in verror. (Bug#8545)
13060 * doprnt.c (doprnt): Document the set of format control sequences
13061 supported by the function. Use SAFE_ALLOCA instead of always
13062 using `alloca'.
13063
13064 * eval.c (verror): Don't limit the buffer size at size_max-1, that
13065 is one byte too soon. Don't use xrealloc; instead xfree and
13066 xmalloc anew.
13067
e061a11b
TZ
130682011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
13069
13070 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
13071 callbacks stage.
13072
13073 * gnutls.c: Renamed global_initialized to
13074 gnutls_global_initialized. Added internals for the
13075 :verify-hostname-error, :verify-error, and :verify-flags
13076 parameters of `gnutls-boot' and documented those parameters in the
13077 docstring. Start callback support.
9173deec
JB
13078 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
13079 unless a fatal error occurred. Call gnutls_alert_send_appropriate
13080 on error. Return error code.
e061a11b
TZ
13081 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
13082 (emacs_gnutls_read): Likewise.
13083 (Fgnutls_boot): Return handshake error code.
13084 (emacs_gnutls_handle_error): New function.
13085 (wsaerror_to_errno): Likewise.
13086
13087 * w32.h (emacs_gnutls_pull): Add prototype.
13088 (emacs_gnutls_push): Likewise.
13089
13090 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
13091 (emacs_gnutls_push): Likewise.
13092
130932011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
13094
13095 * process.c (wait_reading_process_output): Check if GnuTLS
13096 buffered some data internally if no FDs are set for TLS
13097 connections.
13098
13099 * makefile.w32-in (OBJ2): Add gnutls.$(O).
13100 (LIBS): Link to USER_LIBS.
13101 ($(BLD)/gnutls.$(0)): New target.
13102
fa6996bc
EZ
131032011-04-24 Eli Zaretskii <eliz@gnu.org>
13104
eb35682e
EZ
13105 * xdisp.c (handle_single_display_spec): Rename the
13106 display_replaced_before_p argument into display_replaced_p, to
13107 make it consistent with the commentary. Fix typos in the
13108 commentary.
13109
e2ad650c
EZ
13110 * textprop.c (syms_of_textprop): Remove dead code.
13111 (copy_text_properties): Delete obsolete commentary about an
13112 interface that was deleted long ago. Fix typos in the description
13113 of arguments.
13114
1b2de274
EZ
13115 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
13116 to changes in oldXMenu/XMenu.h from 2011-04-16.
13117 <menu_help_message, prev_menu_help_message>: Constify.
13118 (IT_menu_make_room): menu->help_text is now `const char **';
13119 adjust.
13120
13121 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
13122 to changes in oldXMenu/XMenu.h from 2011-04-16.
13123 (struct XMenu): Declare `help_text' `const char **'.
13124
13125 * xfaces.c <Qunspecified>: Make extern again.
13126
13127 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 13128 required by POSIX.
1b2de274 13129
762b15be
EZ
13130 * doc.c (get_doc_string): Improve the format passed to `error'.
13131
13132 * doprnt.c (doprnt): Improve commentary.
13133
13134 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
13135
13136 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
13137 them with etags.
13138
f1052e5d
EZ
13139 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13140 changes in globals.h immediately force recompilation.
762b15be
EZ
13141 (TAGS): Depend on $(CURDIR)/m/intel386.h and
13142 $(CURDIR)/s/ms-w32.h.
13143 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 13144
fa6996bc
EZ
13145 * character.c (Fchar_direction): Function deleted.
13146 (syms_of_character): Don't defsubr it.
13147 <char-direction-table>: Deleted.
13148
e6c3da20
EZ
131492011-04-23 Eli Zaretskii <eliz@gnu.org>
13150
13151 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
13152 * doprnt.c: Include limits.h.
13153 (SIZE_MAX): New macro.
04f2d78b
CB
13154 (doprnt): Return a size_t value. 2nd arg is now size_t.
13155 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
13156 Improve overflow protection. Support `l' modifier for integer
13157 conversions. Support %l conversion. Don't assume an EMACS_INT
13158 argument for integer conversions and for %c.
13159
13160 * lisp.h (doprnt): Restore prototype.
13161
13162 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
13163 $(SRC)/character.h.
13164
13165 * Makefile.in (base_obj): Add back doprnt.o.
13166
13167 * deps.mk (doprnt.o): Add back prerequisites.
13168 (callint.o): Depend on character.h.
13169
13170 * eval.c (internal_lisp_condition_case): Include the handler
13171 representation in the error message.
13172 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13173 when breaking from the loop.
13174
13175 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13176
13177 * callint.c (Fcall_interactively): When displaying error message
13178 about invalid control letter, pass the character's codepoint, not
13179 a pointer to its multibyte form. Improve display of the character
13180 in octal and display also its hex code.
13181
13182 * character.c (char_string): Use %x to display the (unsigned)
13183 codepoint of an invalid character, to avoid displaying a bogus
13184 negative value.
13185
13186 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13187 `error', not SYMBOL_NAME itself.
13188
13189 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13190 character arguments to `error'.
13191
13192 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13193 to `error' in error message about FINAL_CHAR argument. Make sure
13194 FINAL_CHAR is a character, and use %c when it is passed as
13195 argument to `error'.
13196
4ffd0d6b 131972011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13198
13199 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13200
13201 * w32.c: Include <time.h>.
13202 (sys_localtime): New function.
13203
4ffd0d6b 132042011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13205
13206 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13207
4ffd0d6b 13208 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13209
4ffd0d6b 132102011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13211
4ffd0d6b
GM
13212 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13213 zombies (Bug#8467).
aac0c6e3 13214
04c56954
EZ
132152011-04-19 Eli Zaretskii <eliz@gnu.org>
13216
13217 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13218 gl_state.e_property when gl_state.object is Qt.
13219
13220 * insdel.c (make_gap_larger): Remove limitation of buffer size
13221 to <= INT_MAX.
13222
16a43933
CY
132232011-04-18 Chong Yidong <cyd@stupidchicken.com>
13224
13225 * xdisp.c (lookup_glyphless_char_display)
13226 (produce_glyphless_glyph): Handle cons cell entry in
13227 glyphless-char-display.
13228 (Vglyphless_char_display): Document it.
13229
13230 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13231 glyphless-char-display.
13232
4581706e
CY
132332011-04-17 Chong Yidong <cyd@stupidchicken.com>
13234
13235 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13236
13237 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13238
13239 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13240 definition for no-X builds.
13241
4887c6e2 132422011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13243
fd35b6f9
PE
13244 Static checks with GCC 4.6.0 and non-default toolkits.
13245
5c1ccb01
PE
13246 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13247
006c5daa
PE
13248 * process.c (keyboard_bit_set): Define only if SIGIO.
13249 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13250 (send_process): Repair possible setjmp clobbering.
13251
efc736d3
PE
13252 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13253
4e2fe2e6
PE
13254 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13255
f97334a2
PE
13256 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13257
4e75f29d
PE
13258 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13259 Define only if needed.
13260
90efadd1
PE
13261 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13262 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13263 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13264
3c647824
PE
13265 * dispextern.h (struct redisplay_interface): Rename param
13266 to avoid shadowing.
e264f262 13267 * termhooks.h (struct terminal): Likewise.
761383f4 13268 * xterm.c (xembed_send_message): Likewise.
3c647824 13269
b58c5c4a
PE
13270 * insdel.c (make_gap_smaller): Define only if
13271 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13272
cad59032
PE
13273 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13274 it.
13275
c339dc2e
PE
13276 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13277 so that we aren't warned about unused symbols.
13278
91a3e27b
PE
13279 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13280
399c71d3 13281 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13282
8ffc96f5
PE
13283 * xfns.c (x_real_positions): Mark locals as initialized.
13284
eef9bc79
PE
13285 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13286
098db9dd
PE
13287 * xterm.c: Fix problems found by static analysis with other toolkits.
13288 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13289 (x_dispatch_event): Declare static if USE_GTK, and
13290 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13291 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13292 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13293 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13294 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13295
eb18f6cc
PE
13296 * xmenu.c (menu_help_callback): Pointer type fixes.
13297 Use const pointers when pointing at readonly data. Avoid pointer
13298 signedness clashes.
13299 (FALSE): Remove unused macro.
13300 (update_frame_menubar): Remove unused decl.
13301
1fe72bf8
PE
13302 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13303
60d9e1db
PE
13304 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13305 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13306 (single_menu_item): Rename local to avoid shadowing.
13307
39261c26
PE
13308 * keyboard.c (make_lispy_event): Remove unused local var.
13309
018c5e19
PE
13310 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13311 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13312
63d2b86e
PE
13313 * bitmaps: Change bitmaps from unsigned char back to the X11
13314 compatible char. Avoid the old compiler warnings about
13315 out-of-range initializers by using, for example, '\xab' rather
13316 than 0xab.
13317
aefd87e1
PE
13318 * xgselect.c (xgselect_initialize): Check vs interface
13319 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13320
bf501fb9
PE
13321 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13322
e9829fdf
PE
13323 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13324 to read-only memory.
13325
1086c095
PE
13326 * fns.c (vector): Remove; this old hack is no longer needed.
13327
2baccd04 13328 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13329 Remove unused var.
dde42981 13330 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13331
72391843 13332 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13333
436c16df 13334 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13335 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13336 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13337
92bb796d 13338 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13339 (x_term_init): Remove local to avoid shadowing.
92bb796d 13340
764430a3 13341 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13342
13343 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13344 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13345
d1dfb56c
EZ
133462011-04-16 Eli Zaretskii <eliz@gnu.org>
13347
c4354cb4
EZ
13348 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13349
d1dfb56c
EZ
13350 Fix regex.c, syntax.c and friends for buffers > 2GB.
13351 * syntax.h (struct gl_state_s): Declare character position members
13352 EMACS_INT.
13353
13354 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13355
04f2d78b
CB
13356 * textprop.c (verify_interval_modification, interval_of):
13357 Declare arguments EMACS_INT.
d1dfb56c
EZ
13358
13359 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13360 EMACS_INT.
13361
13362 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13363
13364 * indent.c (Fvertical_motion): Local variable it_start is now
13365 EMACS_INT.
13366
13367 * regex.c (re_match, re_match_2, re_match_2_internal)
13368 (bcmp_translate, regcomp, regexec, print_double_string)
13369 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13370 (re_compile_pattern, re_exec): Declare arguments and local
13371 variables `size_t' and `ssize_t' and return values `regoff_t', as
13372 appropriate.
13373 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13374 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13375 <compile_stack_type>: `size' and `avail' are now `size_t'.
13376
13377 * regex.h <regoff_t>: Use ssize_t, not int.
13378 (re_search, re_search_2, re_match, re_match_2): Arguments that
13379 specify buffer/string position and length are now ssize_t and
13380 size_t. Return type is regoff_t.
13381
613052cd
BK
133822011-04-16 Ben Key <bkey76@gmail.com>
13383
13384 * nsfont.m: Fixed bugs in ns_get_family and
13385 ns_descriptor_to_entity that were caused by using free to
13386 deallocate memory blocks that were allocated by xmalloc (via
13387 xstrdup). This caused Emacs to crash when compiled with
13388 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13389 --enable-checking=xmallocoverrun). xfree is now used to
13390 deallocate these memory blocks.
13391
4170f62f 133922011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13393
71b41406
PE
13394 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13395
9587a89d
PE
13396 emacs_write: Accept and return EMACS_INT for sizes.
13397 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13398 et seq.
13399 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13400 Accept and return EMACS_INT.
13401 (emacs_gnutls_write): Return the number of bytes written on
13402 partial writes.
13403 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13404 (emacs_read, emacs_write): Remove check for negative size, as the
13405 Emacs source code has been audited now.
9587a89d
PE
13406 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13407 (emacs_read, emacs_write): Use it.
273a5f82
PE
13408 * process.c (send_process): Adjust to the new signatures of
13409 emacs_write and emacs_gnutls_write. Do not attempt to store
13410 a byte offset into an 'int'; it might overflow.
9587a89d 13411 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13412
3e047f51
PE
13413 * sound.c: Don't assume sizes fit in 'int'.
13414 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13415 Return EMACS_INT, not int.
3e047f51 13416 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13417 Accept EMACS_INT, not int.
13418 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13419 record read return values.
13420
cc39a9db
BK
134212011-04-15 Ben Key <bkey76@gmail.com>
13422
c9d0ec6d
JB
13423 * keyboard.c (Qundefined): Don't declare static since it is used
13424 in nsfns.m.
13425 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13426 static since they are used in nsfont.m.
cc39a9db 13427
6c60eb9f
SM
134282011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13429
13430 * process.c (Qprocessp): Don't declare static.
13431 * lisp.h (Qprocessp): Declare again.
13432
7990b61a
JB
134332011-04-15 Juanma Barranquero <lekktu@gmail.com>
13434
13435 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13436
5d4cb038
PE
134372011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13438
8bd7b830 13439 Improve C-level modularity by making more things 'static'.
cd64ea1d 13440
e3b27b31
PE
13441 Don't publish debugger-only interfaces to other modules.
13442 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13443 (verify_bytepos, count_markers): Move decls to the only modules
13444 that need them.
13445 * region-cache.h (pp_cache): Likewise.
13446 * window.h (check_all_windows): Likewise.
13447 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13448
5d4cb038
PE
13449 * sysdep.c (croak): Now static, if
13450 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13451 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13452
13453 * alloc.c (refill_memory_reserve): Now static if
13454 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13455 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13456
e87b6180
PE
13457 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13458 Define only if USE_LUCID.
13459
ac64929e
PE
13460 * xrdb.c (x_customization_string, x_rm_string): Now static.
13461
6f37259d
PE
13462 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13463 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13464
1683e3ab
PE
13465 * xdisp.c (draw_row_with_mouse_face): Now static.
13466 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13467
de9c2632
PE
13468 * window.h (check_all_windows): Mark externally visible.
13469
2b96acb7
PE
13470 * window.c (window_deletion_count): Now static.
13471
13472 * undo.c: Make symbols static if they're not exported.
13473 (last_undo_buffer, last_boundary_position, pending_boundary):
13474 Now static.
13475
50436f33
PE
13476 * textprop.c (interval_insert_behind_hooks): Now static.
13477 (interval_insert_in_front_hooks): Likewise.
13478
64520e5c
PE
13479 * term.c: Make symbols static if they're not exported.
13480 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13481 (max_frame_lines, tty_set_terminal_modes):
13482 (tty_reset_terminal_modes, tty_turn_off_highlight):
13483 (get_tty_terminal): Now static.
13484 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13485 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13486 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13487 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13488 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13489
1fa53021
PE
13490 * sysdep.c: Make symbols static if they're not exported.
13491 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13492 Now static.
13493 (sigprocmask_set, full_mask): Remove; unused.
13494 (wait_debugging): Mark as visible.
13495 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13496 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13497
d4b43b22
PE
13498 * syntax.c (syntax_temp): Define only if !__GNUC__.
13499
b7c513d0
PE
13500 * sound.c (current_sound_device, current_sound): Now static.
13501
989b29ad
PE
13502 * search.c (searchbufs, searchbuf_head): Now static.
13503
13a55a78
PE
13504 * scroll.c (scroll_cost): Remove; unused.
13505 * dispextern.h (scroll_cost): Remove decl.
13506
de68a1fc
PE
13507 * region-cache.h (pp_cache): Mark as externally visible.
13508
40ccffa6
PE
13509 * process.c: Make symbols static if they're not exported.
13510 (process_tick, update_tick, create_process, chan_process):
13511 (Vprocess_alist, proc_buffered_char, datagram_access):
13512 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13513 (deactivate_process): Mark defn as static, as well as decl.
13514 * lisp.h (create_process): Remove decl.
13515 * process.h (chan_process, Vprocess_alist): Remove decls.
13516
ad64fc97
PE
13517 * print.c: Make symbols static if they're not exported.
13518 (print_depth, new_backquote_output, being_printed, print_buffer):
13519 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13520 (print_interval, print_number_index, initial_stderr_stream):
13521 Now static.
13522 * lisp.h (Fprinc): Remove decl.
13523 (debug_output_compilation_hack): Mark as externally visible.
13524
adddb265
PE
13525 * sysdep.c (croak): Move decl from here to syssignal.h.
13526 * syssignal.h (croak): Put it here, so the API can be checked when
13527 'croak' is called from dissociate_if_controlling_tty.
13528
1717ede2
PE
13529 * minibuf.c: Make symbols static if they're not exported.
13530 (minibuf_save_list, choose_minibuf_frame): Now static.
13531 * lisp.h (choose_minibuf_frame): Remove decl.
13532
fa5fb2bc
PE
13533 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13534
1e3890d1
PE
13535 * lread.c: Make symbols static if they're not exported.
13536 (read_objects, initial_obarray, oblookup_last_bucket_number):
13537 Now static.
13538 (make_symbol): Remove; unused.
13539 * lisp.h (initial_obarray, make_symbol): Remove decls.
13540
8a1414fa
PE
13541 * keyboard.c: Make symbols static if they're not exported.
13542 (single_kboard, recent_keys_index, total_keys, recent_keys):
13543 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13544 (this_single_command_key_start, echoing, last_auto_save):
13545 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13546 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13547 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13548 (Vlispy_mouse_stem, double_click_count):
13549 Now static.
13550 (force_auto_save_soon): Define only if SIGDANGER.
13551 (ignore_mouse_drag_p): Now static if
13552 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13553 (print_help): Remove; unused.
13554 (stop_character, last_timer_event): Mark as externally visible.
13555 * keyboard.h (ignore_mouse_drag_p): Declare only if
13556 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13557 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13558 * lisp.h (echoing): Remove decl.
13559 (force_auto_save_soon): Declare only if SIGDANGER.
13560 * xdisp.c (redisplay_window): Simplify code, to make it more
13561 obvious that ignore_mouse_drag_p is not accessed if !defined
13562 USE_GTK && !defined HAVE_NS.
13563
93ea6e8f
PE
13564 * intervals.c: Make symbols static if they're not exported.
13565 (merge_properties_sticky, merge_interval_right, delete_interval):
13566 Now static.
13567 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13568
77382fcc
PE
13569 * insdel.c: Make symbols static if they're not exported.
13570 However, leave prepare_to_modify_buffer alone. It's never
13571 called from outside this function, but that appears to be a bug.
13572 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13573 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13574 (adjust_after_replace_noundo): Remove; unused.
13575 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13576 (signal_before_change): Remove decls.
77382fcc 13577
9306c32e
PE
13578 * indent.c (val_compute_motion, val_vmotion): Now static.
13579
cd44d2eb
PE
13580 * image.c: Make symbols static if they're not exported.
13581 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13582 if USE_GTK.
13583 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13584 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13585
ad9a7a06
PE
13586 * fringe.c (standard_bitmaps): Now static.
13587 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13588
81626931
PE
13589 * frame.c: Make symbols static if they're not exported.
13590 (x_report_frame_params, make_terminal_frame): Now static.
13591 (get_frame_param): Now static, unless HAVE_NS.
13592 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13593 (x_get_resource_string): Remove; not used.
13594 * frame.h (make_terminal_frame, x_report_frame_params):
13595 (x_get_resource_string); Remove decls.
13596 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13597 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13598
239f9db9
PE
13599 * font.c, fontset.c: Make symbols static if they're not exported.
13600 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13601 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13602 * font.c (font_close_object): Now static.
13603 * font.h (font_close_object): Remove.
13604 * fontset.c (FONTSET_OBJLIST): Remove.
13605 (free_realized_fontset) #if-0 the body, which does nothing.
13606 (face_suitable_for_char_p): #if-0, as it's never called.
13607 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13608 * xfaces.c (face_at_string_position):
13609 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13610 since 0 is always ASCII.
13611
dfcf3579
PE
13612 * fns.c (weak_hash_tables): Now static.
13613
5045092b
PE
13614 * fileio.c: Make symbols static if they're not exported.
13615 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13616 (Vwrite_region_annotation_buffers): Now static.
13617
57a96f5c
PE
13618 * eval.c: Make symbols static if they're not exported.
13619 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13620 * lisp.h (backtrace_list): Remove decl.
13621
35f08c38
PE
13622 * emacs.c: Make symbols static if they're not exported.
13623 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13624 (fatal_error_code, fatal_error_signal_hook, standard_args):
13625 Now static.
13626 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13627 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13628 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13629 * lisp.h (fatal_error_signal_hook): Remove decl.
13630 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13631
f44bd759
PE
13632 * editfns.c: Move a (normally-unused) function to its only use.
13633 * editfns.c, lisp.h (get_operating_system_release): Remove.
13634 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13635 worth the hassle of breaking this out.
13636
b532497d
PE
13637 * xterm.c: Make symbols static if they're not exported.
13638 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13639 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13640 (x_destroy_window, x_delete_display):
13641 Now static.
13642 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13643 (x_mouse_leave): Remove; unused.
13644 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13645 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13646 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13647 Remove decls.
13648 (x_mouse_leave): Declare only if WINDOWSNT.
13649 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13650 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13651 USE_X_TOOLKIT.
13652
1675728f
PE
13653 * ftxfont.c: Make symbols static if they're not exported.
13654 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13655 HAVE_FREETYPE.
13656 * font.h (ftxfont_driver): Likewise.
13657
e4cebfca
PE
13658 * xfns.c: Make symbols static if they're not exported.
13659 (x_last_font_name, x_display_info_for_name):
13660 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13661 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13662 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13663 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13664 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13665 (last_show_tip_args): Now static.
13666 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13667 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13668 (x_screen_planes): Remove; unused.
13669 * dispextern.h (x_screen_planes): Remove decl.
13670
5bf46f05
PE
13671 * dispnew.c: Make symbols static if they're not exported.
13672 * dispextern.h (redraw_garbaged_frames, scrolling):
13673 (increment_row_positions): Remove.
13674 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13675 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13676 Now static.
13677 (redraw_garbaged_frames): Remove; unused.
13678
435f4c28
PE
13679 * xfaces.c: Make symbols static if they're not exported.
13680 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13681 Remove decls.
13682 * xterm.h (defined_color): Remove decls.
13683 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13684 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13685 (menu_face_changed_default, defined_color, free_realized_face):
13686 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13687 (ascii_face_of_lisp_face): Remove; unused.
13688
8524aef3
PE
13689 * xdisp.c: Make symbols static if they're not exported.
13690 * dispextern.h (scratch_glyph_row, window_box_edges):
13691 (glyph_to_pixel_coords, set_cursor_from_row):
13692 (get_next_display_element, set_iterator_to_next):
13693 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13694 (show_mouse_face): Remove decls
13695 * frame.h (message_buf_print): Likewise.
13696 * lisp.h (pop_message, set_message, check_point_in_composition):
13697 Likewise.
13698 * xterm.h (set_vertical_scroll_bar): Likewise.
13699 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13700 (message_buf_print, scratch_glyph_row, displayed_buffer):
13701 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13702 (get_next_display_element, show_mouse_face, window_box_edges):
13703 (frame_to_window_pixel_xy, check_point_in_composition):
13704 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13705 (glyph_to_pixel_coords): Remove; unused.
13706
16390cd2
PE
13707 * dired.c (file_name_completion): Now static.
13708
13709 * dbusbind.c (xd_in_read_queued_messages): Now static.
13710
a25f4dfa
PE
13711 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13712 * data.c (circular_list_error): Remove.
13713
14a9c8df
PE
13714 * commands.h (last_point_position, last_point_position_buffer):
13715 (last_point_position_window): Remove decls.
13716 * keyboard.c: Make these variables static.
13717
04f2d78b
CB
13718 * coding.h (coding, code_convert_region, encode_coding_gap):
13719 Remove decls.
74ab6df5
PE
13720 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13721 (iso_code_class, detect_coding, code_convert_region): Now static.
13722 (encode_coding_gap): Remove; unused.
13723
38dfbee1
PE
13724 * chartab.c (chartab_chars, chartab_bits): Now static.
13725
a2cb4e63
PE
13726 * charset.h (charset_iso_8859_1): Remove decl.
13727 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13728 Now static.
13729
127198fd
PE
13730 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13731 * ccl.c (Vccl_program_table): Now static.
13732 (check_ccl_update): Remove; unused.
13733
d85b608f
PE
13734 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13735 * category.h: ... from here.
13736 * category.c (check_category_table, set_category_set): Now static.
13737
31cd66f3
PE
13738 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13739 * lisp.h: Remove these decls.
13740
c358e587
PE
13741 * buffer.c (buffer_count): Remove unused var.
13742
e78aecca
PE
13743 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13744 so that it's not optimized away.
13745 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13746 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13747 exported only to the debugger.
13748
e192d7d3 13749 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13750 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13751
92470028
PE
13752 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13753 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13754 was inaccessible from Lisp.
13755 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13756 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13757
244ed907
PE
13758 alloc.c: Import and export fewer symbols, and remove unused items.
13759 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13760 is defined.
13761 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13762 it's not optimized away by whole-program optimization.
13763 (message_enable_multibyte, free_misc): Remove.
13764 (catchlist, handlerlist, mark_backtrace):
13765 Declare only if BYTE_MARK_STACK.
13766 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13767 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13768 (message_enable_multibyte): Remove decl.
13769 (free_misc, interval_free_list, float_block, float_block_index):
13770 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13771 (cons_free_list, last_marked_index):
13772 Now static.
13773 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13774 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13775 (mark_backtrace): Define only if BYTE_MARK_STACK.
13776 * xdisp.c (message_enable_multibyte): Now static.
13777
61c2b50e 13778 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13779 This makes it easier for human readers (and static analyzers)
13780 to see whether these variables are used from other modules.
13781 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13782 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13783 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13784 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13785 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13786 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13787 * xmenu.c, xselect.c:
13788 Declare Q* vars static if they are not used in other modules.
13789 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13790 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13791 Remove decls of unexported vars.
13792 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13793
95c82688
PE
13794 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13795
16a97296
PE
13796 Make Emacs functions such as Fatom 'static' by default.
13797 This makes it easier for human readers (and static analyzers)
13798 to see whether these functions can be called from other modules.
13799 DEFUN now defines a static function. To make the function external
13800 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13801 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13802 (Finit_image_library):
16a97296
PE
13803 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13804 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13805 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13806 Remove decls, since these functions are now static.
13807 (Funintern, Fget_internal_run_time): New decls, since these functions
13808 were already external.
95c82688 13809
16a97296
PE
13810 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13811 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13812 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13813 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13814 * keyboard.c, keymap.c, lread.c:
13815 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13816 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13817 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13818 Mark functions with DEFUE instead of DEFUN,
13819 if they are used in other modules.
13820 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13821 decls for now-static functions.
13822 * buffer.h (Fdelete_overlay): Remove decl.
13823 * callproc.c (Fgetenv_internal): Mark as internal.
13824 * composite.c (Fremove_list_of_text_properties): Remove decl.
13825 (Fcomposition_get_gstring): New forward static decl.
13826 * composite.h (Fcomposite_get_gstring): Remove decl.
13827 * dired.c (Ffile_attributes): New forward static decl.
13828 * doc.c (Fdocumntation_property): New forward static decl.
13829 * eval.c (Ffetch_bytecode): New forward static decl.
13830 (Funintern): Remove extern decl; now in .h file where it belongs.
13831 * fileio.c (Fmake_symbolic_link): New forward static decl.
13832 * image.c (Finit_image_library): New forward static decl.
13833 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13834 * intervals.h (Fprevious_property_change):
13835 (Fremove_list_of_text_properties): Remove decls.
13836 * keyboard.c (Fthis_command_keys): Remove decl.
13837 (Fcommand_execute): New forward static decl.
13838 * keymap.c (Flookup_key): New forward static decl.
13839 (Fcopy_keymap): Now static.
13840 * keymap.h (Flookup_key): Remove decl.
13841 * process.c (Fget_process): New forward static decl.
13842 (Fprocess_datagram_address): Mark as internal.
13843 * syntax.c (Fsyntax_table_p): New forward static decl.
13844 (skip_chars): Remove duplicate decl.
13845 * textprop.c (Fprevious_property_change): New forward static decl.
13846 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13847 Now internal.
13848 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13849 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13850
785bbd42
PE
13851 * editfns.c (Fformat): Remove unreachable code.
13852
8b913b57
AS
138532011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13854
13855 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13856 change. (Bug#8496)
13857
a6744a35
EZ
138582011-04-13 Eli Zaretskii <eliz@gnu.org>
13859
13860 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13861 when at ZV. (Bug#8487)
13862
e7974947
AS
138632011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13864
baad03f0
AS
13865 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13866 (Bug#8437)
13867 * keyboard.c (parse_tool_bar_item): Likewise.
13868 * sound.c (sound_cleanup, alsa_close): Likewise.
13869 * termcap.c (tgetent): Likewise.
13870 * xfns.c (x_default_font_parameter): Likewise.
13871 * xsettings.c (read_and_apply_settings): Likewise.
13872
e7974947
AS
13873 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13874 (overrun_check_free): Protoize.
13875
28272684
PE
138762011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13877
13878 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13879 since callers should never pass a negative size.
13880 Change the signature to match that of plain 'read' and 'write'; see
13881 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13882 * lisp.h: Update prototypes of emacs_write and emacs_read.
13883
11997c76
EZ
138842011-04-11 Eli Zaretskii <eliz@gnu.org>
13885
13886 * xdisp.c (redisplay_window): Don't try to determine the character
13887 position of the scroll margin if the window start point w->startp
e896f03c 13888 is outside the buffer's accessible region. (Bug#8468)
11997c76 13889
8a2cbd72
EZ
138902011-04-10 Eli Zaretskii <eliz@gnu.org>
13891
13892 Fix write-region and its subroutines for buffers > 2GB.
13893 * fileio.c (a_write, e_write): Modify declaration of arguments and
13894 local variables to support buffers larger than 2GB.
13895 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13896
13897 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13898 argument, local variables, and return value.
13899
13900 * lisp.h: Update prototypes of emacs_write and emacs_read.
13901
13902 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13903
4073e537 139042011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13905
1ebfdcb6
PE
13906 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13907
b2ded58d
PE
13908 Fix more problems found by GCC 4.6.0's static checks.
13909
7d66342c
PE
13910 * xdisp.c (vmessage): Use a better test for character truncation.
13911
bbf47d44
PE
13912 * charset.c (load_charset_map): <, not <=, for optimization,
13913 and to avoid potential problems with integer overflow.
9248994d 13914 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13915 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13916 * editfns.c (Fformat): Likewise.
1e69125e 13917 * syntax.c (skip_chars): Likewise.
3befa583 13918
e3019616
PE
13919 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13920 This also lets GCC 4.6.0 generate slightly better loop code.
13921
becfa255
PE
13922 * callint.c (Fcall_interactively): <, not <=, for optimization.
13923 (Fcall_interactively): Count the number of arguments produced,
13924 not the number of arguments given. This is simpler and lets GCC
13925 4.6.0 generate slightly better code.
13926
dae0cd48
PE
13927 * ftfont.c: Distingish more carefully between FcChar8 and char.
13928 The previous code passed unsigned char * to a functions like
13929 strlen and xstrcasecmp that expect char *, which does not
13930 conform to the C standard.
13931 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13932 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13933 char * when the C standard requires it.
13934
76032d70
PE
13935 * keyboard.c (read_char): Remove unused var.
13936
eb3f1cc8
PE
13937 * eval.c: Port to Windows vsnprintf (Bug#8435).
13938 Include <limits.h>.
13939 (SIZE_MAX): Define if the headers do not.
13940 (verror): Do not give up if vsnprintf returns a negative count.
13941 Instead, grow the buffer. This ports to Windows vsnprintf, which
13942 does not conform to C99. Problem reported by Eli Zaretskii.
13943 Also, simplify the allocation scheme, by avoiding the need for
13944 calling realloc, and removing the ALLOCATED variable.
13945
70476b54
PE
13946 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13947
12020a9e
PE
13948 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13949 But keep the doprint source code for now, as we might revamp it
13950 and use it again (Bug#8435).
ea6c7ae6
PE
13951 * lisp.h (doprnt): Remove.
13952 * Makefile.in (base_obj): Remove doprnt.o.
13953 * deps.mk (doprnt.o): Remove.
13954
5fdb398c
PE
13955 error: Print 32- and 64-bit integers portably (Bug#8435).
13956 Without this change, on typical 64-bit hosts error ("...%d...", N)
13957 was used to print both 32- and 64-bit integers N, which relied on
13958 undefined behavior.
61bdb816 13959 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13960 * lisp.h (error, verror): Mark as printf-like functions.
13961 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13962 Report overflow in size calculations when allocating printf buffer.
13963 Do not truncate output string at its first null byte.
13964 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13965 Truncate the output at a character boundary, since vsnprintf does not
13966 do that.
13967 * charset.c (check_iso_charset_parameter): Convert internal
13968 character to string before calling 'error', since %c now has the
13969 printf meaning.
13970 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13971 overflow when computing char to be passed to 'error'. Do not
13972 pass Lisp_Object to 'error'; pass the integer instead.
13973 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13974 formatted with plain %d.
13975
b189fa66
PE
13976 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13977
bff87ef0
PE
13978 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13979
7e2cac20
PE
13980 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13981
ce4d90b5
PE
13982 * xterm.c (x_catch_errors): Remove duplicate declaration.
13983
266c9547
PE
13984 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13985
79c49ad2
PE
13986 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13987
368f4090
JM
139882011-04-10 Jim Meyering <meyering@redhat.com>
13989
13990 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13991 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13992 return ssize_t not "int", and use size_t as the buffer length.
13993 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13994 * gnutls.h: Update declarations.
13995 * process.c (read_process_output): Use ssize_t, to match.
13996 (send_process): Likewise.
13997
a32d4040
CY
139982011-04-09 Chong Yidong <cyd@stupidchicken.com>
13999
14000 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
14001
8546720e 140022011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 14003
04f2d78b
CB
14004 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
14005 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 14006
8546720e
GM
14007 * xterm.c (handle_one_xevent):
14008 * xmenu.c (create_and_show_popup_menu):
14009 * xselect.c (x_decline_selection_request)
14010 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 14011
0a2f5c1a 140122011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
14013
14014 Fix some uses of `int' instead of EMACS_INT.
14015 * search.c (string_match_1, fast_string_match)
14016 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
14017 (scan_buffer, find_next_newline_no_quit)
14018 (find_before_next_newline, search_command, Freplace_match)
14019 (Fmatch_data): Make some `int' variables be EMACS_INT.
14020
14021 * xdisp.c (display_count_lines): 3rd argument and return value now
14022 EMACS_INT. All callers changed.
14023 (pint2hrstr): Last argument is now EMACS_INT.
14024
14025 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
14026 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
14027 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
14028 (decode_coding_utf_16, decode_coding_emacs_mule)
14029 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
14030 (decode_coding_ccl, decode_coding_charset)
14031 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
14032 (decode_coding_iso_2022, decode_coding_emacs_mule)
14033 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
14034 <char_offset, last_offset>: Declare EMACS_INT.
14035 (encode_coding_utf_8, encode_coding_utf_16)
14036 (encode_coding_emacs_mule, encode_invocation_designation)
14037 (encode_designation_at_bol, encode_coding_iso_2022)
14038 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
14039 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
14040 Declare EMACS_INT.
14041 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
14042 (encode_invocation_designation): Last argument P_NCHARS is now
14043 EMACS_INT.
14044 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
14045 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
14046
14047 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
14048 All users changed.
14049
14050 * ccl.c (Fccl_execute_on_string): Declare some variables
14051 EMACS_INT.
14052
8546720e 140532011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
14054
14055 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
14056
4e19a977
CS
140572011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
14058
14059 * process.c (Fformat_network_address): Doc fix.
14060
87302331
R
140612011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
14062
ee7683eb 14063 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 14064
cbb59342
CY
140652011-04-08 Chong Yidong <cyd@stupidchicken.com>
14066
14067 * keyboard.c (read_char): Call Lisp function help-form-show,
14068 instead of using internal_with_output_to_temp_buffer.
14069 (Qhelp_form_show): New var.
e0d38eeb 14070 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
14071
14072 * print.c (internal_with_output_to_temp_buffer): Function deleted.
14073
14074 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
14075
e67a13ab
CY
140762011-04-06 Chong Yidong <cyd@stupidchicken.com>
14077
04f2d78b
CB
14078 * process.c (Flist_processes): Remove to Lisp.
14079 (list_processes_1): Delete.
e67a13ab 14080
973f782d
EZ
140812011-04-06 Eli Zaretskii <eliz@gnu.org>
14082
7c106b1e
EZ
14083 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
14084
973f782d
EZ
14085 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
14086
41cf7d1a 140872011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 14088
ca23cc88
PE
14089 Fix more problems found by GCC 4.6.0's static checks.
14090
f390e2d5
PE
14091 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
14092
42eea0d0
PE
14093 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
14094
b69769da 14095 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 14096
f9541e84
PE
14097 * xdisp.c (vmessage): Mark as a printf-like function.
14098
13841b55
PE
14099 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
14100
c136c10f
PE
14101 * sound.c (sound_warning): Don't crash if arg contains a printf format.
14102
5e2d4a30
PE
14103 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
14104 printf-like functions.
14105 (tiff_load): Add casts to remove these marks before passing them
14106 to system-supplied API.
14107
583f48b9
PE
14108 * eval.c (Fsignal): Remove excess argument to 'fatal'.
14109
b25d760e
PE
14110 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
14111 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
14112 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
14113 directly, rather than having caller test rule sign. This avoids
14114 some unnecessary tests.
14115 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
14116 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
14117 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 14118
bc7b6697 14119 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 14120 (xfont_open): Avoid unnecessary tests.
bc7b6697 14121
27ccc379
PE
14122 * composite.c (composition_gstring_put_cache): Use unsigned integer.
14123
dcd5c89a
PE
14124 * composite.h, composite.c (composition_gstring_put_cache):
14125 Use EMACS_INT, not int, for length.
14126
b13a45c6
PE
14127 * composite.h (COMPOSITION_DECODE_REFS): New macro,
14128 breaking out part of COMPOSITION_DECODE_RULE.
14129 (COMPOSITION_DECODE_RULE): Use it.
14130 * composite.c (get_composition_id): Remove unused local vars,
14131 by using the new macro.
14132
1e792e4d
PE
14133 * textprop.c (set_text_properties_1): Change while to do-while,
14134 since the condition is always true at first.
14135
dc6c6455 14136 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
14137 (interval_deletion_adjustment): Return unsigned value.
14138 All uses changed.
dc6c6455 14139
aba7731a
PE
14140 * process.c (list_processes_1, create_pty, read_process_output):
14141 (exec_sentinel): Remove vars that were set but not used.
afd4052b 14142 (create_pty): Remove unnecessary "volatile"s.
bc57d757 14143 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 14144 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 14145 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 14146
fdfc4bf3
PE
14147 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
14148
fca8fe46 14149 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 14150 (update_syntax_table): Use unsigned instead of int.
fca8fe46 14151
06a0259a 14152 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 14153 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 14154 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 14155
e7b9e80f
PE
14156 * print.c (print_error_message): Avoid int overflow.
14157
56201685
PE
14158 * font.c (font_list_entities): Redo for clarity,
14159 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
14160
78834453 14161 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 14162 (font_score): Avoid potential overflow in diff calculation.
78834453 14163
0bc0b309 14164 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 14165 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 14166
e610eaca
PE
14167 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14168
b895abce
PE
14169 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14170 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14171 can always succeed if overflow has undefined behavior.
14172
1f1d9321 14173 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14174 (wordify): Omit three unnecessary tests.
1f1d9321 14175
c59478bc
PE
14176 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14177 All callers changed. This avoids the need for an unused var.
14178
79b73827
PE
14179 * casefiddle.c (casify_region): Remove var that is set but not used.
14180
a4db5dfe
PE
14181 * dired.c (file_name_completion): Remove var that is set but not used.
14182
43aae36e
PE
14183 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14184
2a47c44d 14185 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14186 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14187
a37c69bf
PE
14188 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14189 Check for integer overflow on size calculations.
14190
328ab8e7
PE
14191 * buffer.c (Fprevious_overlay_change): Remove var that is set
14192 but not used.
14193
e5a2a5cb
PE
14194 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14195 Remove vars that are set but not used.
8d84a6eb 14196 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14197 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14198
a60e5f68
PE
14199 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14200
f661cb61 14201 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14202 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14203
f0397f5a
PE
14204 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14205 that are set but not used.
14206
8664db06 14207 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14208 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14209
6abdaa4a
PE
14210 * xselect.c (x_get_local_selection, x_handle_property_notify):
14211 Remove vars that are set but not used.
14212
0ce7538d 14213 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14214 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14215
9ae848fc
PE
14216 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14217 Remove var that is set but not used.
0b918413
PE
14218 (scroll_bar_windows_size): Now size_t, not int.
14219 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14220 Check for overflow.
9ae848fc 14221
a5a62657
PE
14222 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14223 (map_tty_color) [!defined MSDOS]: Likewise.
14224
5c5cdd39
PE
14225 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14226
66ebf983
PE
14227 * coding.c: Remove vars that are set but not used.
14228 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14229 All callers changed.
14230 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14231 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14232 (decode_coding_charset): Remove vars that are set but not used.
14233
1be4d761
PE
14234 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14235 that is set but not used.
14236
47553fa8
PE
14237 * print.c (print_object): Remove var that is set but not used.
14238
1f7196bf 14239 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14240 The gnulib version avoids calling malloc in the usual case,
14241 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14242 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14243 * filelock.c (current_lock_owner): Likewise.
14244 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14245 * sysdep.c: Include allocator.h, careadlinkat.h.
14246 (emacs_no_realloc_allocator): New static constant.
14247 (emacs_readlink): New function.
fdb61804
PE
14248 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14249 ../lib/careadlinkat.h.
d1fdcab7 14250
f84c17c7
SM
142512011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14252
14253 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14254 first non-nil return value).
14255
ef3862ad
JD
142562011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14257
14258 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14259 if not defined (Bug#8403).
14260
376a7006
JB
142612011-04-02 Juanma Barranquero <lekktu@gmail.com>
14262
14263 * xdisp.c (display_count_lines): Remove parameter `start',
14264 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14265 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14266 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14267 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14268 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14269 and thereabouts. All callers changed.
14270 (get_per_char_metric): Remove parameter `f', unused since
14271 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14272
6ca3801d
JM
142732011-04-02 Jim Meyering <meyering@redhat.com>
14274
14275 do not dereference NULL upon failed strdup
14276 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14277 (ns_get_family): Likewise.
14278
d8e2b5ba
JB
142792011-04-02 Juanma Barranquero <lekktu@gmail.com>
14280
14281 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14282
8c74fcbd
JD
142832011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14284
14285 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14286 later (Bug#8403).
14287
7200d79c
SM
142882011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14289
03408648 14290 Add lexical binding.
7200d79c 14291
03408648
SM
14292 * window.c (Ftemp_output_buffer_show): New fun.
14293 (Fsave_window_excursion):
14294 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14295
14296 * lread.c (lisp_file_lexically_bound_p): New function.
14297 (Fload): Bind Qlexical_binding.
14298 (readevalloop): Remove `evalfun' arg.
14299 Bind Qinternal_interpreter_environment.
14300 (Feval_buffer): Bind Qlexical_binding.
14301 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14302 Mark as dynamic.
14303 (syms_of_lread): Declare `lexical-binding'.
14304
14305 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14306
14307 * keyboard.c (eval_dyn): New fun.
14308 (menu_item_eval_property): Use it.
ca105506
SM
14309
14310 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14311
03408648
SM
14312 * fns.c (concat, mapcar1): Accept byte-code-functions.
14313
14314 * eval.c (Fsetq): Handle lexical vars.
14315 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14316 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14317 (FletX, Flet): Obey lexical binding.
14318 (Fcommandp): Handle closures.
14319 (Feval): New `lexical' arg.
14320 (eval_sub): New function extracted from Feval. Use it almost
14321 everywhere where Feval was used. Look up vars in lexical env.
14322 Handle closures.
14323 (Ffunctionp): Move from subr.el.
14324 (Ffuncall): Handle closures.
14325 (apply_lambda): Remove `eval_flags'.
14326 (funcall_lambda): Handle closures and new byte-code-functions.
14327 (Fspecial_variable_p): New function.
14328 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14329 but without exporting it to Lisp.
23aba0ea 14330
23aba0ea 14331 * doc.c (Fdocumentation, store_function_docstring):
03408648 14332 * data.c (Finteractive_form): Handle closures.
23aba0ea 14333
03408648
SM
14334 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14335 interactive spec.
ba83908c 14336
04f2d78b
CB
14337 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14338 New byte-codes.
03408648
SM
14339 (exec_byte_code): New function extracted from Fbyte_code to handle new
14340 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14341
03408648 14342 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14343
03408648 14344 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14345
e2abce01
JB
143462011-03-31 Juanma Barranquero <lekktu@gmail.com>
14347
14348 * xdisp.c (redisplay_internal): Fix prototype.
14349
63696a73 143502011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14351
63696a73 14352 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14353 (try_scrolling): Use it when setting scroll_limit.
14354 Limit scrolling to 100 screen lines.
63696a73
EZ
14355 (redisplay_window): Even when falling back on "recentering",
14356 position point in the window according to scroll-conservatively,
14357 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14358
14359 (try_scrolling): When point is above the window, allow searching
14360 as far as scroll_max, or one screenful, to compute vertical
14361 distance from PT to the scroll margin position. This prevents
14362 try_scrolling from unnecessarily failing when
14363 scroll-conservatively is set to a value slightly larger than the
14364 window height. Clean up the case of PT below the margin at bottom
14365 of window: scroll_max can no longer be INT_MAX. When aggressive
14366 scrolling is in use, don't let point enter the opposite scroll
14367 margin as result of the scroll.
14368 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14369 threshold of 100 lines for never-recentering scrolling.
14370
e4cc2dfc
JB
143712011-03-31 Juanma Barranquero <lekktu@gmail.com>
14372
14373 * dispextern.h (move_it_by_lines):
14374 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14375 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14376 (message_log_check_duplicate): Remove parameters `prev_bol' and
14377 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14378 (redisplay_internal): Remove parameter `preserve_echo_area',
14379 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14380
14381 * indent.c (Fvertical_motion):
14382 * window.c (window_scroll_pixel_based, Frecenter):
14383 Don't pass `need_y_p' to `move_it_by_lines'.
14384
1c470562
SM
143852011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14386
44f230aa
SM
14387 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14388 steal a few bits to be more compact.
14389 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14390 Remove unneeded casts.
14391
1c470562
SM
14392 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14393
888adce9
ZK
143942011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14395
14396 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14397 binding" message (bug#7967).
14398
f838ed7b
PE
143992011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14400
77861b95
PE
14401 Fix more problems found by GCC 4.6.0's static checks.
14402
de6dbc14
PE
14403 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14404 Remove unused local var.
14405
f838ed7b
PE
14406 * editfns.c (Fmessage_box): Remove unused local var.
14407
792c7b2b
PE
14408 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14409 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14410 Omit unused local vars.
c499e557 14411 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14412 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14413 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14414 Omit unused local var.
14415
ba0165e1
PE
14416 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14417 Don't assume string length fits in int.
32ad8845 14418 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14419 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14420
3c59b4c9
PE
14421 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14422 instead of alloca (Bug#8344).
14423
a3eed478 14424 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14425 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14426
eb4d412d
PE
14427 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14428
1658b401
PE
14429 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14430 concerns.
14431
14432 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14433
14434 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14435
9a2c6e05
PE
14436 * keyboard.c (syms_of_keyboard): Use the same style as later
14437 in this function when indexing through an array. This also
14438 works around GCC bug 48267.
14439
03d0a109
PE
14440 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14441
44f730c8
PE
14442 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14443
fe75f926
PE
14444 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14445 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14446
ffa8c828
PE
14447 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14448 This avoids undefined behavior on integer overflow, and is a bit
14449 more convenient anyway since it is compared to a size_t variable.
14450
c5101a77
PE
14451 Variadic C functions now count arguments with size_t, not int.
14452 This avoids an unnecessary limitation on 64-bit machines, which
14453 caused (substring ...) to crash on large vectors (Bug#8344).
14454 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14455 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14456 All variadic functions and their callers changed accordingly.
c5101a77
PE
14457 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14458 * data.c (arith_driver, float_arith_driver): Likewise.
14459 * editfns.c (general_insert_function): Likewise.
14460 * eval.c (struct backtrace.nargs, interactive_p)
14461 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14462 (funcall_lambda, mark_backtrace): Likewise.
14463 * fns.c (concat): Likewise.
14464 * frame.c (x_set_frame_parameters): Likewise.
14465 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14466 0 if not found, not -1. All callers changed.
14467
dd3f25f7
PE
14468 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14469 (stack_copy_size): Now size_t, not int.
14470 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14471
461c2ab9
JB
144722011-03-28 Juanma Barranquero <lekktu@gmail.com>
14473
14474 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14475 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14476 All callers changed.
14477
14478 * lisp.h (multibyte_char_to_unibyte):
14479 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14480 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14481 * character.h (CHAR_TO_BYTE8):
14482 * cmds.c (internal_self_insert):
14483 * editfns.c (general_insert_function):
14484 * keymap.c (push_key_description):
14485 * search.c (Freplace_match):
14486 * xdisp.c (message_dolog, set_message_1): All callers changed.
14487
f6d62986
SM
144882011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14489
14490 * keyboard.c (safe_run_hook_funcall): New function.
14491 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14492 don't set the hook to nil, but remove the offending function instead.
14493 (Qcommand_hook_internal): Remove, unused.
14494 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14495 Vcommand_hook_internal.
14496
14497 * eval.c (enum run_hooks_condition): Remove.
14498 (funcall_nil, funcall_not): New functions.
14499 (run_hook_with_args): Call each function through a `funcall' argument.
14500 Remove `cond' argument, now redundant.
14501 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14502 (Frun_hook_with_args_until_failure): Adjust accordingly.
14503 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14504
1db5b1ad
JB
145052011-03-28 Juanma Barranquero <lekktu@gmail.com>
14506
14507 * dispextern.h (string_buffer_position): Remove declaration.
14508
14509 * print.c (strout): Remove parameter `multibyte', unused since
14510 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14511
14512 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14513 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14514 All callers changed.
14515
14516 * w32.c (_wsa_errlist): Use braces for struct initializers.
14517
14518 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14519 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14520 All callers changed.
14521 (string_buffer_position): Likewise. Also, make static (it's never
14522 used outside xdisp.c).
14523 (cursor_row_p): Remove parameter `w', unused since
14524 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14525 (decode_mode_spec): Remove parameter `precision', introduced during
14526 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14527 All callers changed.
14528
5ffb62aa
JD
145292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14530
14531 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14532
461c2ab9 145332011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14534
14535 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14536 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14537 (ns_update_auto_hide_menu_bar): New functions.
14538 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14539 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14540 ns_constrain_all_frames.
14541 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14542 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14543
5c380ffb
JD
145442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14545
14546 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14547
9af30bdf
GM
145482011-03-27 Glenn Morris <rgm@gnu.org>
14549
14550 * syssignal.h: Replace RETSIGTYPE with void.
14551 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14552 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14553 Replace SIGTYPE with void everywhere.
14554 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14555 * s/template.h (SIGTYPE): Remove commented out definition.
14556
e2abce01
JB
145572011-03-26 Eli Zaretskii <eliz@gnu.org>
14558
14559 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14560 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14561
f868cd8a
JB
145622011-03-26 Juanma Barranquero <lekktu@gmail.com>
14563
59eb0929
JB
14564 * w32.c (read_unc_volume): Use parameter `henum', instead of
14565 global variable `wget_enum_handle'.
14566
14567 * keymap.c (describe_vector): Remove parameters `indices' and
14568 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14569 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14570
f868cd8a
JB
14571 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14572
14573 * keyboard.c (timer_check): Remove parameter `do_it_now',
14574 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14575 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14576 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14577
14578 * keyboard.c (read_char):
14579 * w32menu.c (w32_menu_display_help):
14580 * xmenu.c (show_help_event, menu_help_callback):
14581 Adjust calls to `show_help_echo'.
14582
14583 * gtkutil.c (xg_maybe_add_timer):
14584 * keyboard.c (readable_events):
14585 * process.c (wait_reading_process_output):
14586 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14587
14588 * insdel.c (adjust_markers_gap_motion):
14589 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14590 (gap_left, gap_right): Don't call it.
14591
2ecf6fdb
CY
145922011-03-25 Chong Yidong <cyd@stupidchicken.com>
14593
14594 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14595 incurred during fontification.
14596
6b1f9ba4
JB
145972011-03-25 Juanma Barranquero <lekktu@gmail.com>
14598
14599 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14600 (DEFVAR_PER_BUFFER): Don't pass it.
14601
14602 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14603 (scrolling_window): Don't pass it.
14604
0f4a96b5
JB
146052011-03-25 Juanma Barranquero <lekktu@gmail.com>
14606
14607 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14608
14609 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14610 and `suffix'.
14611 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14612 of variables specific to SELinux and computation of `encoded_absname'.
14613
14614 * image.c (XPutPixel): Remove unused variable `height'.
14615
14616 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14617
14618 * unexw32.c (get_section_info): Remove unused variable `section'.
14619
14620 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14621 (system_process_attributes): Remove unused variable `sess'.
14622 (sys_read): Remove unused variable `err'.
14623
14624 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14625 (w32_wnd_proc): Remove unused variable `isdead'.
14626 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14627 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14628 (x_create_tip_frame): Remove unused variable `tem'.
14629
14630 * w32inevt.c (w32_console_read_socket):
14631 Remove unused variable `no_events'.
14632
14633 * w32term.c (x_draw_composite_glyph_string_foreground):
14634 Remove unused variable `width'.
14635
1149507c
JB
146362011-03-24 Juanma Barranquero <lekktu@gmail.com>
14637
14638 * w32term.c (x_set_glyph_string_clipping):
14639 Don't pass uninitialized region to CombineRgn.
14640
9c88f339
JB
146412011-03-23 Juanma Barranquero <lekktu@gmail.com>
14642
14643 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14644 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14645 (Fx_close_connection): Remove unused variable `i'.
14646
14647 * w32font.c (w32font_draw): Return number of glyphs.
14648 (w32font_open_internal): Remove unused variable `i'.
14649 (w32font_driver): Add missing initializer.
14650
14651 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14652 (fill_in_menu): Remove unused variable `items_added'.
14653
14654 * w32term.c (last_mouse_press_frame): Remove static global variable.
14655 (w32_clip_to_row): Remove unused variable `f'.
14656 (x_delete_terminal): Remove unused variable `i'.
14657
14658 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14659 (NOTHING): Remove unused static global variable.
14660 (uniscribe_check_otf): Remove unused variable `table'.
14661 (uniscribe_font_driver): Add missing initializers.
14662
dee091a3
JD
146632011-03-23 Julien Danjou <julien@danjou.info>
14664
14665 * term.c (Fsuspend_tty, Fresume_tty):
14666 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14667 * window.c (temp_output_buffer_show):
14668 * insdel.c (signal_before_change):
14669 * frame.c (Fhandle_switch_frame):
14670 * fileio.c (Fdo_auto_save):
14671 * emacs.c (Fkill_emacs):
14672 * editfns.c (save_excursion_restore):
14673 * cmds.c (internal_self_insert):
14674 * callint.c (Fcall_interactively):
14675 * buffer.c (Fkill_all_local_variables):
14676 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14677 Use Frun_hooks.
0f4a96b5 14678 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14679 unconditionally since it does the check itself.
dee091a3 14680
2c520ab5 146812011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14682
c9c49752
PE
14683 Fix more problems found by GCC 4.5.2's static checks.
14684
8abc3f12
PE
14685 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14686 the first time through the loop, since we know p0 < p1 then.
14687 This also avoids a gcc -Wstrict-overflow warning.
14688
a2d26660
PE
14689 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14690 leading to a memory leak, possible in functions like
14691 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14692 of objects (Bug#8318).
a2d26660 14693
916c72e9
PE
14694 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14695 that could (at least in theory) be that large.
14696
19ab8a18
PE
14697 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14698 This is less likely to overflow, and avoids undefined behavior if
14699 overflow does occur. All callers changed. Use strtoul to scan
14700 for the unsigned long integer.
b7cbbd6f
PE
14701 (pint2hrstr): Simplify and tune code slightly.
14702 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14703
f0641eff
PE
14704 * scroll.c (do_scrolling): Work around GCC bug 48228.
14705 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14706
7f650bb9
PE
14707 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14708 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14709 (validate_x_resource_name): Simplify count usage.
14710 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14711
37dd57d1
PE
14712 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14713 fail (Bug#8306).
81e56e61 14714
699979fc 14715 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14716
401bf9b4
PE
14717 * process.c (Fmake_network_process): Use socklen_t, not int,
14718 where POSIX says socklen_t is required in portable programs.
14719 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14720 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14721 (Fmake_network_process, server_accept_connection):
14722 (wait_reading_process_output, read_process_output):
14723 Likewise.
14724
b93aacde
PE
14725 * process.c: Rename or move locals to avoid shadowing.
14726 (list_processes_1, Fmake_network_process):
14727 (read_process_output_error_handler, exec_sentinel_error_handler):
14728 Rename or move locals.
4dc343ee 14729 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14730 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14731 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14732 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14733 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14734
af8a867c 14735 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14736 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14737 Include tparam.h instead, since it declares them.
af8a867c
PE
14738 * cm.h (PC): Remove extern decl; tparam.h now does this.
14739 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14740 * terminfo.c: Include tparam.h, to check interfaces.
14741 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14742 (tparam): Adjust signature to match interface in tparam.h;
14743 this removes some undefined behavior. Check that outstring and len
14744 are zero, which they always are with Emacs.
14745 * tparam.h (PC, BC, UP): New extern decls.
14746
0248044d 14747 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14748 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14749
8ff096c1 14750 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14751 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14752 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14753 (ftfont_list): Remove unused local.
49eaafba
PE
14754 (get_adstyle_property, ftfont_pattern_entity):
14755 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14756 Rename locals to avoid shadowing.
8ff096c1 14757
e2be39f6
PE
14758 * xfont.c (xfont_list_family): Mark var as initialized.
14759
c9735e30
PE
14760 * xml.c (make_dom): Now static.
14761
8f5201ae
PE
14762 * composite.c (composition_compute_stop_pos): Rename local to
14763 avoid shadowing.
b246f932
PE
14764 (composition_reseat_it): Remove unused locals.
14765 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14766 (composition_update_it): Mark var as initialized.
11b61122
PE
14767 (find_automatic_composition): Mark vars as initialized,
14768 with a FIXME (Bug#8290).
8f5201ae 14769
760fbc2c
PE
14770 character.h: Rename locals to avoid shadowing.
14771 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14772 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14773 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14774 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14775 to avoid shadowing.
14776
ff08eb85
PE
14777 * textprop.c (property_change_between_p): Remove; unused.
14778
fc7bf025
PE
14779 * intervals.c (interval_start_pos): Now static.
14780
235d7abc
PE
14781 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14782
44f230aa
SM
14783 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14784 Rename locals to avoid shadowing.
3e7d6594 14785
50060332
PE
14786 * sound.c (wav_play, au_play, Fplay_sound_internal):
14787 Fix pointer signedness.
d01f234b 14788 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14789 (wav_play): Initialize a variable to 0, to prevent undefined
14790 behavior (Bug#8278).
50060332 14791
c4fc4e30
PE
14792 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14793
918436ed
PE
14794 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14795
c939f91b
PE
14796 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14797 clobbering (Bug#8298).
b9c7f648
PE
14798 * sysdep.c (sys_subshell): Likewise.
14799 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14800
6bd8c144
PE
14801 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14802 This should get cleaned up, so that child_setup has the
14803 same signature on all platforms.
14804
7710357c 14805 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14806 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14807
c59da222
CY
148082011-03-22 Chong Yidong <cyd@stupidchicken.com>
14809
14810 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14811 not to be necessary, and produces flickering.
14812
66b87493
GM
148132011-03-20 Glenn Morris <rgm@gnu.org>
14814
14815 * config.in: Remove file.
14816
45b6f6d5
JB
148172011-03-20 Juanma Barranquero <lekktu@gmail.com>
14818
14819 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14820 are now in src/globals.h.
14821 (syms_of_minibuf): Remove spurious & from previous change.
14822
cd394be1 148232011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14824
14825 * minibuf.c (completing-read-function): New variable.
14826 (completing-read-default): Rename from completing-read.
14827 (completing-read): Call completing-read-function.
14828
b14e3e21
CY
148292011-03-19 Juanma Barranquero <lekktu@gmail.com>
14830
14831 * xfaces.c (Fx_load_color_file):
14832 Read color file from absolute filename (bug#8250).
14833
f2b726e6
JB
148342011-03-19 Juanma Barranquero <lekktu@gmail.com>
14835
14836 * makefile.w32-in: Update dependencies.
14837
09f6ff02
EZ
148382011-03-17 Eli Zaretskii <eliz@gnu.org>
14839
14840 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14841
29a6015a
PE
148422011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14843
a3a6c54e
PE
14844 Fix more problems found by GCC 4.5.2's static checks.
14845
b766f867
PE
14846 * process.c (make_serial_process_unwind, send_process_trap):
14847 (sigchld_handler): Now static.
14848
be02381c
PE
14849 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14850 That way, the code declares only the vars that it needs.
14851 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14852 * s/cygwin.h (PTY_ITERATION): Likewise.
14853 * s/darwin.h (PTY_ITERATION): Likewise.
14854 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14855
57048744
PE
14856 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14857 * process.c (allocate_pty): Don't declare stb unless it's needed.
14858
7914961c 14859 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14860 (CONSTANTLIM): Remove; unused.
14861 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14862 Define only if needed.
7914961c 14863
b3967b18
PE
14864 * unexelf.c (unexec): Name an expression,
14865 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14866 Use a different way to cause a compilation error if anyone uses
14867 n rather than nn, a way that does not involve shadowing.
73366a00 14868 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14869
29a6015a
PE
14870 * deps.mk (unexalpha.o): Remove; unused.
14871
43cfc33e 14872 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14873 * unexec.h: New file.
ce701a33
PE
14874 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14875 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14876 Depend on unexec.h.
14877 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14878 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14879 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14880 Change as necessary to match prototype in unexec.h.
ce701a33 14881
01f44d5a
PE
14882 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14883 shadowing.
4f63c6bb 14884 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14885
a6670b0b
PE
14886 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14887 Rename locals to avoid shadowing.
14888
cef2010d 14889 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14890 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14891
d4d7173a
PE
14892 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14893
f08b802a
PE
14894 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14895 warning when compiling print.c.
14896
3ddb0639
PE
14897 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14898 instead of using an uninitialized var.
5ad03b97 14899 (font_sort_entities): Mark var as initialized.
3ddb0639 14900
170a2692
PE
14901 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14902
e663c700
PE
14903 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14904 pointers to constants.
89bc529a 14905 (font_parse_fcname): Remove unused vars.
7b81e2d0 14906 (font_delete_unmatched): Now static.
ea838e10 14907 (font_get_spec): Remove; unused.
13a547c6
PE
14908 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14909 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14910 Rename or move locals to avoid shadowing.
e663c700 14911
2a80c887 14912 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14913 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14914
1384fa33 14915 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14916 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14917
8b2c52e9
PE
14918 * alloc.c (mark_backtrace): Move decl from here ...
14919 * lisp.h: ... to here, so that it can be checked.
14920
475545b5 14921 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14922 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14923 (lisp_indirect_variable): Name an expression,
14924 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14925 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14926
b1349114 14927 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14928 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14929 Use const pointer when appropriate.
b1349114 14930
a2928364
PE
14931 * lisp.h (get_system_name, get_operating_system_release):
14932 Move decls here, to check interfaces.
14933 * process.c (get_operating_system_release): Move decl to lisp.h.
14934 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14935 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14936 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14937 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14938 (Fformat_time_string, Fencode_time, Finsert_char):
14939 (Ftranslate_region_internal, Fformat):
14940 Rename or remove local vars to avoid shadowing.
9710023e 14941 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14942
a415e694
PE
14943 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14944 avoid shadowing.
14945
8ef4622d
PE
14946 * lisp.h (eassert): Check that the argument compiles, even if
14947 ENABLE_CHECKING is not defined.
14948
946f9a5b
PE
14949 * data.c (Findirect_variable): Name an expression, to avoid
14950 gcc -Wbad-function-cast warning.
112396d6 14951 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14952 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14953 (Fmake_variable_buffer_local, Fmake_local_variable):
14954 Mark variables as initialized.
52746918 14955 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14956
e5aab7e7 14957 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14958 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14959 Rename locals to avoid shadowing.
dff45157
PE
14960 (mark_stack): Move local variables into the #ifdef region where
14961 they're used.
7bc26fdb
PE
14962 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14963 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14964 needed otherwise.
14965 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14966 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14967 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14968
e5aab7e7
PE
14969 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14970 avoids undefined behavior in theory.
14971
4da60324
PE
14972 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14973
88043301
PE
14974 Use functions, not macros, for up- and down-casing (Bug#8254).
14975 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14976 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14977 to use the following functions instead of these macros.
14978 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14979 EMACS_INT, since callers assume the returned value fits in int.
14980 (upcase1): Likewise, for UPCASE_TABLE.
14981 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14982 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14983 the race-condition problem in the old DOWNCASE.
88043301 14984
19ed5445
PE
14985 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14986 Rename locals to avoid shadowing.
14987 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14988 (regex_compile, re_search_2, re_match_2_internal):
14989 Remove unused local vars.
952db0d7
PE
14990 (FREE_VAR): Rewrite so as not to use empty "else",
14991 which gcc can warn about.
da053e48 14992 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14993 (RETALLOC_IF): Define only if needed.
14994 (WORDCHAR_P): Likewise. This one is never needed, but is used
14995 only in a comment talking about a compiler bug, so put inside
14996 the #if 0 of that comment.
14997 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14998 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14999 Remove; unused.
19ed5445 15000
1f3561e4 15001 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
15002 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
15003 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 15004
ded6f8f7
PE
15005 * search.c (simple_search): Remove unused var.
15006
dbd37a95
PE
15007 * dired.c (compile_pattern): Move decl from here ...
15008 * lisp.h: ... to here, so that it can be checked.
15009 (struct re_registers): New forward decl.
15010
7e47afad
PE
15011 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
15012
85f24f61
PE
15013 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
15014 All uses changed.
15015 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
15016 Rename locals to avoid shadowing.
5671df8f 15017 (Fvertical_motion): Mark locals as initialized.
85f24f61 15018
181aa2be 15019 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 15020 (casify_region): Mark local as initialized.
181aa2be 15021
930d429c
PE
15022 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
15023
7082eac6
PE
15024 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
15025 New macros, so that the caller can use some names other than
15026 gcpro1, gcpro2, etc.
15027 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
15028 of the new macros.
15029 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
15030 argument, for consistency with GCPRO2_VAR, etc: it is now the
15031 prefix of the variable, not the variable itself. All uses
15032 changed.
38b2c076
PE
15033 * dired.c (directory_files_internal, file_name_completion):
15034 Rename locals to avoid shadowing.
15035
15206ed9
PE
15036 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
15037 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
15038 dired.c's scmp function, had undefined behavior.
15039 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15040 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
15041 * buffer.h: ... to here, because these macros use current_buffer,
15042 and the new implementation with inline functions needs to have
15043 current_buffer in scope now, rather than later when the macros
15044 are used.
15045 (downcase, upcase1): New static inline functions.
15046 (DOWNCASE, UPCASE1): Reimplement using these functions.
15047 This avoids undefined behavior in expressions like
15048 DOWNCASE (x) == DOWNCASE (y), which previously suffered
15049 from race conditions in accessing the global variables
15050 case_temp1 and case_temp2.
15051 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
15052 * lisp.h (case_temp1, case_temp2): Remove their decls.
15053 * character.h (ASCII_CHAR_P): Move from here ...
15054 * lisp.h: ... to here, so that the inline functions mentioned
15055 above can use them.
15056
4a6bea26
PE
15057 * dired.c (directory_files_internal_unwind): Now static.
15058
f14b7e14
PE
15059 * fileio.c (file_name_as_directory, directory_file_name):
15060 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
15061 Now static.
2893f146
PE
15062 (file_name_as_directory): Use const pointers when appropriate.
15063 (Fexpand_file_name): Likewise. In particular, newdir might
15064 point at constant storage, so make it a const pointer.
fd4ead52 15065 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
15066 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
15067 signedness issues.
f839df0c
PE
15068 (Fset_file_times, Finsert_file_contents, auto_save_error):
15069 Rename locals to avoid shadowing.
f14b7e14 15070
5716756e 15071 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
15072 (Ftry_completion, Fall_completions): Rename or remove locals
15073 to avoid shadowing.
5716756e 15074
b4c3046a
PE
15075 * marker.c (bytepos_to_charpos): Remove; unused.
15076
b45db522
PE
15077 * lisp.h (verify_bytepos, count_markers): New decls,
15078 so that gcc does not warn that these functions aren't declared.
15079
85876d07
PE
15080 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
15081 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 15082 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 15083 (copy_text): Remove unused local var.
85876d07 15084
03d78a21 15085 * filelock.c (within_one_second): Now static.
b3dd38ab 15086 (lock_file_1): Rename local to avoid shadowing.
03d78a21 15087
5df8f01b
PE
15088 * buffer.c (fix_overlays_before): Mark locals as initialized.
15089 (fix_start_end_in_overlays): Likewise. This function should be
15090 simplified by using pointers-to-pointers, but that's a different
15091 matter.
b1d876f1 15092 (switch_to_buffer_1): Now static.
8f54f30a
PE
15093 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
15094 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 15095
a70072c9 15096 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 15097 Fix pointer signedness issue.
edced198
PE
15098 (sys_subshell): Mark local as volatile if checking for lint,
15099 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 15100 (MAXPATHLEN): Define only if needed.
a70072c9 15101
a0977c44
PE
15102 * process.c (serial_open, serial_configure): Move decls from here ...
15103 * systty.h: ... to here, so that they can be checked.
15104
a884fdcc
PE
15105 * fns.c (get_random, seed_random): Move extern decls from here ...
15106 * lisp.h: ... to here, so that they can be checked.
15107
604efe86 15108 * sysdep.c (reset_io): Now static.
b8950c94 15109 (wait_for_termination_signal): Remove; unused.
604efe86 15110
38fc62d9
PE
15111 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
15112 (copy_keymap_item, append_key, push_text_char_description):
15113 Now static.
1004a21a 15114 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 15115 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
15116 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
15117 (describe_map_tree):
15118 Rename locals to avoid shadowing.
38fc62d9 15119
2f2650da
PE
15120 * keyboard.c: Declare functions static if they are not used elsewhere.
15121 (echo_char, echo_dash, cmd_error, top_level_2):
15122 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
15123 (read_char, kbd_buffer_get_event, make_lispy_position):
15124 (make_lispy_event, make_lispy_movement, apply_modifiers):
15125 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
15126 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
15127 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 15128 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 15129 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 15130
a053e86c 15131 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
15132 (mark_kboards): Move decl here ...
15133 * alloc.c (mark_kboards): ... from here.
a053e86c 15134
4752793e
PE
15135 * lisp.h (force_auto_save_soon): New decl.
15136
74f10ca7 15137 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
15138 (DEFINE_DUMMY_FUNCTION): New macro.
15139 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
15140 Use it.
c03cd23f
PE
15141 (main): Add casts to avoid warnings
15142 if GCC considers string literals to be constants.
74f10ca7 15143
022e70d4
PE
15144 * lisp.h (fatal_error_signal): Add decl, since it's exported.
15145
59d6fe83
PE
15146 * dbusbind.c: Pointer signedness fixes.
15147 (xd_signature, xd_append_arg, xd_initialize):
15148 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15149 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15150 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
15151 (Fdbus_register_signal): Use SSDATA when the context wants char *.
15152
78320123
PE
15153 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
15154 if GCC considers string literals to be constants.
49cebcca 15155 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 15156
35ac2a97
SM
151572011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
15158
fb103ca9
SM
15159 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
15160 (print_preprocess, print_object): New macro to fix last change.
15161
35ac2a97
SM
15162 * print.c (print_preprocess): Don't forget font objects.
15163
62973b41
JB
151642011-03-16 Juanma Barranquero <lekktu@gmail.com>
15165
15166 * emacs.c (USAGE3): Doc fixes.
15167
0e48bb22
AS
151682011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15169
15170 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15171 structure.
15172
7684e57b
JB
151732011-03-14 Juanma Barranquero <lekktu@gmail.com>
15174
15175 * lisp.h (VWindow_system, Qfile_name_history):
15176 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15177 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15178 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15179
15180 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15181 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15182
15183 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15184 * w32console.c (detect_input_pending, read_input_pending)
15185 (encode_terminal_code):
15186 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15187 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15188 (w32_system_caret_y, Qfile_name_history):
15189 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15190 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15191 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15192 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15193 * w32proc.c (Qlocal, report_file_error):
15194 * w32term.c (Vwindow_system, updating_frame):
15195 * w32uniscribe.c (initialized, uniscribe_font_driver):
15196 Remove unneeded extern declarations.
15197
2aa46d6c
CY
151982011-03-14 Chong Yidong <cyd@stupidchicken.com>
15199
c96bbc66 15200 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15201
cffc6f3b
CY
152022011-03-13 Chong Yidong <cyd@stupidchicken.com>
15203
15204 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15205 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15206 These macros can no longer be used for assignment.
15207
44f230aa
SM
15208 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15209 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15210 (record_buffer_markers, fetch_buffer_markers): New functions for
15211 recording and fetching special buffer markers.
15212 (set_buffer_internal_1, set_buffer_temp): Use them.
15213
15214 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15215
15216 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15217
15218 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15219 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15220
15221 * xdisp.c (hscroll_window_tree):
15222 (reconsider_clip_changes): Use PT instead of BUF_PT.
15223
d251f04b
EZ
152242011-03-13 Eli Zaretskii <eliz@gnu.org>
15225
15226 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15227 $(EMACS_ROOT)/lib/intprops.h.
15228
f0c77cd1
PE
152292011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15230
3eca4629
PE
15231 Fix more problems found by GCC 4.5.2's static checks.
15232
7c86ee98
PE
15233 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15234 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15235 (xg_free_frame_widgets): Make it clear that a local variable is
15236 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15237 (gdk_window_get_screen): Make it clear that this macro is needed
15238 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15239 (int_gtk_range_get_value): New function, which avoids a diagnostic
15240 from gcc -Wbad-function-cast.
15241 (xg_set_toolkit_scroll_bar_thumb): Use it.
15242 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15243 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15244 (get_utf8_string, xg_get_file_with_chooser):
15245 Rename locals to avoid shadowing.
15246 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15247
41729b81
PE
15248 * xgselect.c (xg_select): Remove unused var.
15249
f0c77cd1
PE
15250 * image.c (four_corners_best): Mark locals as initialized.
15251 (gif_load): Initialize transparent_p to zero (Bug#8238).
15252 Mark another local as initialized.
ec6cf4c6 15253 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15254
ce0ad53d 15255 * image.c (clear_image_cache): Now static.
d5d5a617 15256 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15257 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15258 (x_edge_detection): Remove unnecessary cast that
15259 gcc -Wbad-function-cast diagnoses.
2037898d 15260 (gif_load): Fix pointer signedness.
6ae141d6
PE
15261 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15262 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15263
33383987 152642011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15265
d32df629
PE
15266 Improve quality of tests for time stamp overflow.
15267 For example, without this patch (encode-time 0 0 0 1 1
15268 1152921504606846976) returns the obviously-bogus value (-948597
15269 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15270 reports time overflow. See
15271 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15272 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15273 * editfns.c: Include limits.h and intprops.h.
15274 (TIME_T_MIN, TIME_T_MAX): New macros.
15275 (time_overflow): Move earlier, to before first use.
15276 (hi_time, lo_time): New functions, for an accurate test for
15277 out-of-range times.
15278 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15279 (Fget_internal_run_time): Don't assume time_t fits in int.
15280 (make_time): Use list2 instead of Fcons twice.
15281 (Fdecode_time): More accurate test for out-of-range times.
15282 (check_tm_member): New function.
15283 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15284 (lisp_time_argument): Don't rely on undefined left-shift and
15285 right-shift behavior when checking for time stamp overflow.
8be6f318 15286
fe31d94c
PE
15287 * editfns.c (time_overflow): New function, refactoring common code.
15288 (Fformat_time_string, Fdecode_time, Fencode_time):
15289 (Fcurrent_time_string): Use it.
15290
8be6f318
PE
15291 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15292 * dired.c (make_time): Move to ...
15293 * editfns.c (make_time): ... here.
15294 * systime.h: Note the move.
15295
09d9db2c 152962011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15297
126bc0dc
YM
15298 * fringe.c (update_window_fringes): Remove unused variables.
15299
c47cbdfd
YM
15300 * unexmacosx.c (copy_data_segment): Also copy __got section.
15301 (Bug#8223)
15302
7ac80be9
EZ
153032011-03-12 Eli Zaretskii <eliz@gnu.org>
15304
c96bbc66 15305 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15306 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15307 Constify `char *' arguments and their references according to
15308 prototypes in tparam.h.
15309
ecb0f94d 15310 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15311
7ac80be9
EZ
15312 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15313 Adapt all references accordingly.
15314
15315 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15316
ef1fd07e
TT
153172011-03-11 Tom Tromey <tromey@redhat.com>
15318
15319 * buffer.c (syms_of_buffer): Remove obsolete comment.
15320
7ef4b50c
EZ
153212011-03-11 Eli Zaretskii <eliz@gnu.org>
15322
15323 * termhooks.h (encode_terminal_code): Declare prototype.
15324
15325 * msdos.c (encode_terminal_code): Don't declare prototype.
15326
15327 * term.c (encode_terminal_code): Now external again, used by
15328 w32console.c and msdos.c.
15329
44f230aa
SM
15330 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15331 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15332
4b1ec863 153332011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15334
1714f52b 15335 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15336
4b1ec863
PE
15337 * fringe.c (update_window_fringes): Mark locals as initialized
15338 (Bug#8227).
15339 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15340
524c7aa6
PE
15341 * alloc.c (mark_fringe_data): Move decl from here ...
15342 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15343 to check its interface.
15344 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15345
a5c0af81 15346 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15347 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15348 (fontset_font): Mark local as initialized.
a9a06e0b 15349 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15350
b4716021
PE
15351 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15352
811e9bac 15353 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15354 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15355 (x_own_selection, Fx_disown_selection_internal): Rename locals
15356 to avoid shadowing.
15357 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15358
7e3ab302
PE
15359 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15360 so that the caller can use some name other than gcpro1.
15361 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15362 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15363 (Fx_backspace_delete_keys_p):
15364 Use them to avoid shadowing, and rename vars to avoid shadowing.
15365 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15366 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15367 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15368 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15369 Remove unused locals.
7e3ab302
PE
15370 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15371 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15372 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15373 macros.
f78faa98 15374
e2b13473
PE
15375 * xterm.h (x_mouse_leave): New decl.
15376
77f23912
PE
15377 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15378 Remove unused functions.
cdf4ba58
PE
15379 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15380 (x_calc_absolute_position): Now static.
7411c686 15381 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15382 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15383 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15384 unless they are used.
38d0b34a
PE
15385 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15386 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15387 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15388 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15389 (x_error_catcher, x_connection_closed, x_error_handler):
15390 (x_error_quitter, xembed_send_message, x_iconify_frame):
15391 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15392 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15393 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15394
44f230aa
SM
15395 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15396 Rename or move locals to avoid shadowing.
6b463e58 15397 (tty_defined_color, merge_face_heights): Now static.
5967d051 15398 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15399 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15400 does not deduce is never used uninitialized.
73719eba
PE
15401 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15402 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15403
426994c3 15404 * terminal.c (store_terminal_param): Now static.
5489860b 15405
032f1620 15406 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15407 (set_frame_menubar): Remove unused local.
d4323972 15408 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15409 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15410 since they might point to immutable storage.
281585b0
PE
15411 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15412 since it's unused otherwise.
032f1620 15413
367c19e5 15414 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15415 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15416 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15417 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15418 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15419 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15420 does not deduce are never used uninitialized.
70739cbe 15421
07b48fa9
PE
15422 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15423
8868a238 15424 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15425 * window.c (window_loop, size_window):
15426 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15427
7e5cf297 15428 * window.c (display_buffer): Now static.
d6550a9f
PE
15429 (size_window): Mark variables that gcc -Wuninitialized
15430 does not deduce are never used uninitialized.
a586633d
PE
15431 * window.h (check_all_windows): New decl, to forestall
15432 gcc -Wmissing-prototypes diagnostic.
5b555da1 15433 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15434
f6095868
PE
15435 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15436 shadowing.
15437 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15438 Include <limits.h>.
15439 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15440 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15441 (load_charset_map): Mark variables that gcc -Wuninitialized
15442 does not deduce are never used uninitialized.
53df7c11 15443 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15444
f38b440c
PE
15445 * coding.c (coding_set_source, coding_set_destination):
15446 Use "else { /* comment */ }" rather than "else /* comment */;"
15447 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15448 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15449 a block, when the outer 'i' will do.
15450 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15451 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15452 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15453 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15454 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15455 Rename locals to avoid shadowing.
15456 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15457 * coding.c (emacs_mule_char, encode_invocation_designation):
15458 Now static, since they're not used elsewhere.
413bb2db 15459 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15460 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15461 (decode_coding_emacs_mule): Mark variables that gcc
15462 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15463 (detect_coding_iso_2022): Initialize a local variable that might
15464 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15465 this initialization is needed. (Bug#8211)
5f58e762
PE
15466 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15467 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15468 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15469 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15470 Remove unused macros.
f38b440c 15471
232b38b9 15472 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15473 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15474 * character.c (string_count_byte8): Likewise.
232b38b9 15475
fb90da1b
PE
15476 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15477 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15478
fb93dbc2
PE
15479 * chartab.c (copy_sub_char_table): Now static, since it's not used
15480 elsewhere.
5c156ace
PE
15481 (sub_char_table_ref_and_range, char_table_ref_and_range):
15482 Rename locals to avoid shadowing.
bbcd0949 15483 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15484
7d3b3862 15485 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15486 (BIDI_BOB): Remove unused macro.
7d3b3862 15487
6be7d3da
PE
15488 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15489 deduce are never used uninitialized.
c2ed9c8b 15490 * term.c (encode_terminal_code): Likewise.
6be7d3da 15491
75f8807f 15492 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15493
50938595
PE
15494 * tparam.h: New file.
15495 * term.c, tparam.h: Include it.
15496 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15497 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15498 Move these decls to tparam.h, and make them agree with what
15499 is actually in tparam.c. The previous trick of using incompatible
15500 decls in different modules does not conform to the C standard.
15501 All callers of tparam changed to use tparam's actual API.
15502 * tparam.c (tparam1, tparam, tgoto):
15503 Use const pointers where appropriate.
15504
fbceeba2
PE
15505 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15506 * cm.h (struct cm): Likewise.
15507 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15508 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15509 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15510 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15511 (turn_on_face, init_tty): Likewise.
15512 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15513
7f3f1250
PE
15514 * term.c (term_mouse_position): Rename local to avoid shadowing.
15515
e6ca6543
PE
15516 * alloc.c (mark_ttys): Move decl from here ...
15517 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15518
c40f8d15
AS
155192011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15520
15521 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15522
cfe0661d
JB
155232011-03-09 Juanma Barranquero <lekktu@gmail.com>
15524
15525 * search.c (compile_pattern_1): Remove argument regp, unused since
15526 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15527 (compile_pattern): Don't pass it.
15528
0afb4571
J
155292011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15530
15531 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15532 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15533 for ! HAVE_GTK3.
15534 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15535
15536 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15537
15538 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15539 gdk_window_get_screen, gdk_window_get_geometry,
15540 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15541 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15542 (xg_get_pixbuf_from_pixmap): New function.
15543 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15544 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15545 Call xg_get_pixbuf_from_pixmap instead of
15546 gdk_pixbuf_get_from_drawable.
15547 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15548 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15549 (xg_check_special_colors): Use GtkStyleContext and its functions
15550 for HAVE_GTK3.
15551 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15552 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15553 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15554 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15555 Call gtk_widget_get_preferred_size.
0afb4571
J
15556 (xg_frame_resized): gdk_window_get_geometry only takes 5
15557 parameters.
44f230aa
SM
15558 (xg_win_to_widget, xg_event_is_for_menubar):
15559 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15560 (xg_set_widget_bg): New function.
15561 (delete_cb): New function.
895009e1 15562 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15563 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15564 (xg_set_background_color): Call xg_set_widget_bg.
15565 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15566 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15567 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15568 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15569 if ! HAVE_GTK3.
15570 (update_frame_tool_bar): Call gtk_widget_hide.
15571 (xg_initialize): Use GDK_KEY_g.
15572
15573 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15574 if ! HAVE_GTK3
15575 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15576
15577 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15578 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15579 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15580
1c2cc4ef
JB
155812011-03-08 Juanma Barranquero <lekktu@gmail.com>
15582
15583 * w32xfns.c (select_palette): Check success of RealizePalette against
15584 GDI_ERROR, not zero.
15585
33383987 15586See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15587
15588;; Local Variables:
15589;; coding: utf-8
aac0c6e3
MR
15590;; End:
15591
2f097256 15592 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15593
15594 This file is part of GNU Emacs.
15595
15596 GNU Emacs is free software: you can redistribute it and/or modify
15597 it under the terms of the GNU General Public License as published by
15598 the Free Software Foundation, either version 3 of the License, or
15599 (at your option) any later version.
15600
15601 GNU Emacs is distributed in the hope that it will be useful,
15602 but WITHOUT ANY WARRANTY; without even the implied warranty of
15603 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15604 GNU General Public License for more details.
15605
15606 You should have received a copy of the GNU General Public License
15607 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.