emacs_write: Accept and return EMACS_INT for sizes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4170f62f 12011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2
9587a89d
PE
3 emacs_write: Accept and return EMACS_INT for sizes.
4 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5 et seq.
6 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7 Accept and return EMACS_INT.
8 (emacs_gnutls_write): Return the number of bytes written on
9 partial writes.
10 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11 (emacs_read, emacs_write): Remove check for negative size, as the
12 Emacs source code has been audited now.
9587a89d
PE
13 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
14 (emacs_read, emacs_write): Use it.
273a5f82
PE
15 * process.c (send_process): Adjust to the new signatures of
16 emacs_write and emacs_gnutls_write. Do not attempt to store
17 a byte offset into an 'int'; it might overflow.
9587a89d 18 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 19
3e047f51
PE
20 * sound.c: Don't assume sizes fit in 'int'.
21 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 22 Return EMACS_INT, not int.
3e047f51 23 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
24 Accept EMACS_INT, not int.
25 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
26 record read return values.
27
cc39a9db
BK
282011-04-15 Ben Key <bkey76@gmail.com>
29
30 * keyboard.c (Qundefined): Don't declare static since it is
31 used in nsfns.m.
32 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
33 declare static since they are used in nsfont.m.
34
6c60eb9f
SM
352011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
36
37 * process.c (Qprocessp): Don't declare static.
38 * lisp.h (Qprocessp): Declare again.
39
7990b61a
JB
402011-04-15 Juanma Barranquero <lekktu@gmail.com>
41
42 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
43
5d4cb038
PE
442011-04-14 Paul Eggert <eggert@cs.ucla.edu>
45
8bd7b830 46 Improve C-level modularity by making more things 'static'.
cd64ea1d 47
e3b27b31
PE
48 Don't publish debugger-only interfaces to other modules.
49 * lisp.h (safe_debug_print, debug_output_compilation_hack):
50 (verify_bytepos, count_markers): Move decls to the only modules
51 that need them.
52 * region-cache.h (pp_cache): Likewise.
53 * window.h (check_all_windows): Likewise.
54 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
55
5d4cb038
PE
56 * sysdep.c (croak): Now static, if
57 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
58 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
59
60 * alloc.c (refill_memory_reserve): Now static if
61 !defined REL_ALLOC || defined SYSTEM_MALLOC.
62 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 63
e87b6180
PE
64 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
65 Define only if USE_LUCID.
66
ac64929e
PE
67 * xrdb.c (x_customization_string, x_rm_string): Now static.
68
6f37259d
PE
69 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
70 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
71
1683e3ab
PE
72 * xdisp.c (draw_row_with_mouse_face): Now static.
73 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
74
de9c2632
PE
75 * window.h (check_all_windows): Mark externally visible.
76
2b96acb7
PE
77 * window.c (window_deletion_count): Now static.
78
79 * undo.c: Make symbols static if they're not exported.
80 (last_undo_buffer, last_boundary_position, pending_boundary):
81 Now static.
82
50436f33
PE
83 * textprop.c (interval_insert_behind_hooks): Now static.
84 (interval_insert_in_front_hooks): Likewise.
85
64520e5c
PE
86 * term.c: Make symbols static if they're not exported.
87 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
88 (max_frame_lines, tty_set_terminal_modes):
89 (tty_reset_terminal_modes, tty_turn_off_highlight):
90 (get_tty_terminal): Now static.
91 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
92 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 93 HAVE_WINDOW_SYSTEM.
64520e5c
PE
94 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
95 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
96
1fa53021
PE
97 * sysdep.c: Make symbols static if they're not exported.
98 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
99 Now static.
100 (sigprocmask_set, full_mask): Remove; unused.
101 (wait_debugging): Mark as visible.
102 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
103 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
104
d4b43b22
PE
105 * syntax.c (syntax_temp): Define only if !__GNUC__.
106
b7c513d0
PE
107 * sound.c (current_sound_device, current_sound): Now static.
108
989b29ad
PE
109 * search.c (searchbufs, searchbuf_head): Now static.
110
13a55a78
PE
111 * scroll.c (scroll_cost): Remove; unused.
112 * dispextern.h (scroll_cost): Remove decl.
113
de68a1fc
PE
114 * region-cache.h (pp_cache): Mark as externally visible.
115
40ccffa6
PE
116 * process.c: Make symbols static if they're not exported.
117 (process_tick, update_tick, create_process, chan_process):
118 (Vprocess_alist, proc_buffered_char, datagram_access):
119 (fd_callback_data, send_process_frame, process_sent_to): Now static.
120 (deactivate_process): Mark defn as static, as well as decl.
121 * lisp.h (create_process): Remove decl.
122 * process.h (chan_process, Vprocess_alist): Remove decls.
123
ad64fc97
PE
124 * print.c: Make symbols static if they're not exported.
125 (print_depth, new_backquote_output, being_printed, print_buffer):
126 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
127 (print_interval, print_number_index, initial_stderr_stream):
128 Now static.
129 * lisp.h (Fprinc): Remove decl.
130 (debug_output_compilation_hack): Mark as externally visible.
131
adddb265
PE
132 * sysdep.c (croak): Move decl from here to syssignal.h.
133 * syssignal.h (croak): Put it here, so the API can be checked when
134 'croak' is called from dissociate_if_controlling_tty.
135
1717ede2
PE
136 * minibuf.c: Make symbols static if they're not exported.
137 (minibuf_save_list, choose_minibuf_frame): Now static.
138 * lisp.h (choose_minibuf_frame): Remove decl.
139
fa5fb2bc
PE
140 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
141
1e3890d1
PE
142 * lread.c: Make symbols static if they're not exported.
143 (read_objects, initial_obarray, oblookup_last_bucket_number):
144 Now static.
145 (make_symbol): Remove; unused.
146 * lisp.h (initial_obarray, make_symbol): Remove decls.
147
8a1414fa
PE
148 * keyboard.c: Make symbols static if they're not exported.
149 (single_kboard, recent_keys_index, total_keys, recent_keys):
150 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
151 (this_single_command_key_start, echoing, last_auto_save):
152 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
153 (command_loop, echo_now, keyboard_init_hook, help_char_p):
154 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
155 (Vlispy_mouse_stem, double_click_count):
156 Now static.
157 (force_auto_save_soon): Define only if SIGDANGER.
158 (ignore_mouse_drag_p): Now static if
159 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
160 (print_help): Remove; unused.
161 (stop_character, last_timer_event): Mark as externally visible.
162 * keyboard.h (ignore_mouse_drag_p): Declare only if
163 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
164 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
165 * lisp.h (echoing): Remove decl.
166 (force_auto_save_soon): Declare only if SIGDANGER.
167 * xdisp.c (redisplay_window): Simplify code, to make it more
168 obvious that ignore_mouse_drag_p is not accessed if !defined
169 USE_GTK && !defined HAVE_NS.
170
93ea6e8f
PE
171 * intervals.c: Make symbols static if they're not exported.
172 (merge_properties_sticky, merge_interval_right, delete_interval):
173 Now static.
174 * intervals.h (merge_interval_right, delete_interval): Remove decls.
175
77382fcc
PE
176 * insdel.c: Make symbols static if they're not exported.
177 However, leave prepare_to_modify_buffer alone. It's never
178 called from outside this function, but that appears to be a bug.
179 (combine_after_change_list, combine_after_change_buffer):
4889fc82 180 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
181 (adjust_after_replace_noundo): Remove; unused.
182 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 183 (signal_before_change): Remove decls.
77382fcc 184
9306c32e
PE
185 * indent.c (val_compute_motion, val_vmotion): Now static.
186
cd44d2eb
PE
187 * image.c: Make symbols static if they're not exported.
188 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
189 if USE_GTK.
190 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
191 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
192
ad9a7a06
PE
193 * fringe.c (standard_bitmaps): Now static.
194 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
195
81626931
PE
196 * frame.c: Make symbols static if they're not exported.
197 (x_report_frame_params, make_terminal_frame): Now static.
198 (get_frame_param): Now static, unless HAVE_NS.
199 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
200 (x_get_resource_string): Remove; not used.
201 * frame.h (make_terminal_frame, x_report_frame_params):
202 (x_get_resource_string); Remove decls.
203 (x_fullscreen_adjust): Declare only if WINDOWSNT.
204 * lisp.h (get_frame_param): Declare only if HAVE_NS.
205
239f9db9
PE
206 * font.c, fontset.c: Make symbols static if they're not exported.
207 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
208 (FACE_SUITABLE_FOR_CHAR_P): Use it.
209 * font.c (font_close_object): Now static.
210 * font.h (font_close_object): Remove.
211 * fontset.c (FONTSET_OBJLIST): Remove.
212 (free_realized_fontset) #if-0 the body, which does nothing.
213 (face_suitable_for_char_p): #if-0, as it's never called.
214 * fontset.h (face_suitable_for_char_p): Remove decl.
215 * xfaces.c (face_at_string_position): Use
216 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
217 since 0 is always ASCII.
218
dfcf3579
PE
219 * fns.c (weak_hash_tables): Now static.
220
5045092b
PE
221 * fileio.c: Make symbols static if they're not exported.
222 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
223 (Vwrite_region_annotation_buffers): Now static.
224
57a96f5c
PE
225 * eval.c: Make symbols static if they're not exported.
226 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
227 * lisp.h (backtrace_list): Remove decl.
228
35f08c38
PE
229 * emacs.c: Make symbols static if they're not exported.
230 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
231 (fatal_error_code, fatal_error_signal_hook, standard_args):
232 Now static.
233 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
234 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
235 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
236 * lisp.h (fatal_error_signal_hook): Remove decl.
237 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
238
f44bd759
PE
239 * editfns.c: Move a (normally-unused) function to its only use.
240 * editfns.c, lisp.h (get_operating_system_release): Remove.
241 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
242 worth the hassle of breaking this out.
243
b532497d
PE
244 * xterm.c: Make symbols static if they're not exported.
245 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
246 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
247 (x_destroy_window, x_delete_display):
248 Now static.
249 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
250 (x_mouse_leave): Remove; unused.
251 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
252 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
253 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
254 Remove decls.
255 (x_mouse_leave): Declare only if WINDOWSNT.
256 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
257 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
258 USE_X_TOOLKIT.
259
1675728f
PE
260 * ftxfont.c: Make symbols static if they're not exported.
261 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
262 HAVE_FREETYPE.
263 * font.h (ftxfont_driver): Likewise.
264
e4cebfca
PE
265 * xfns.c: Make symbols static if they're not exported.
266 (x_last_font_name, x_display_info_for_name):
267 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
268 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
269 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
270 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
271 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
272 (last_show_tip_args): Now static.
273 (xic_defaut_fontset, xic_create_fontsetname): Define only if
274 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
275 (x_screen_planes): Remove; unused.
276 * dispextern.h (x_screen_planes): Remove decl.
277
5bf46f05
PE
278 * dispnew.c: Make symbols static if they're not exported.
279 * dispextern.h (redraw_garbaged_frames, scrolling):
280 (increment_row_positions): Remove.
281 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
282 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
283 Now static.
284 (redraw_garbaged_frames): Remove; unused.
285
435f4c28
PE
286 * xfaces.c: Make symbols static if they're not exported.
287 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
288 Remove decls.
289 * xterm.h (defined_color): Remove decls.
290 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
291 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
292 (menu_face_changed_default, defined_color, free_realized_face):
293 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
294 (ascii_face_of_lisp_face): Remove; unused.
295
8524aef3
PE
296 * xdisp.c: Make symbols static if they're not exported.
297 * dispextern.h (scratch_glyph_row, window_box_edges):
298 (glyph_to_pixel_coords, set_cursor_from_row):
299 (get_next_display_element, set_iterator_to_next):
300 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
301 (show_mouse_face): Remove decls
302 * frame.h (message_buf_print): Likewise.
303 * lisp.h (pop_message, set_message, check_point_in_composition):
304 Likewise.
305 * xterm.h (set_vertical_scroll_bar): Likewise.
306 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
307 (message_buf_print, scratch_glyph_row, displayed_buffer):
308 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
309 (get_next_display_element, show_mouse_face, window_box_edges):
310 (frame_to_window_pixel_xy, check_point_in_composition):
311 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
312 (glyph_to_pixel_coords): Remove; unused.
313
16390cd2
PE
314 * dired.c (file_name_completion): Now static.
315
316 * dbusbind.c (xd_in_read_queued_messages): Now static.
317
a25f4dfa
PE
318 * lisp.h (circular_list_error, FOREACH): Remove; unused.
319 * data.c (circular_list_error): Remove.
320
14a9c8df
PE
321 * commands.h (last_point_position, last_point_position_buffer):
322 (last_point_position_window): Remove decls.
323 * keyboard.c: Make these variables static.
324
74ab6df5
PE
325 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
326 decls.
327 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
328 (iso_code_class, detect_coding, code_convert_region): Now static.
329 (encode_coding_gap): Remove; unused.
330
38dfbee1
PE
331 * chartab.c (chartab_chars, chartab_bits): Now static.
332
a2cb4e63
PE
333 * charset.h (charset_iso_8859_1): Remove decl.
334 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
335 Now static.
336
127198fd
PE
337 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
338 * ccl.c (Vccl_program_table): Now static.
339 (check_ccl_update): Remove; unused.
340
d85b608f
PE
341 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
342 * category.h: ... from here.
343 * category.c (check_category_table, set_category_set): Now static.
344
31cd66f3
PE
345 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
346 * lisp.h: Remove these decls.
347
c358e587
PE
348 * buffer.c (buffer_count): Remove unused var.
349
e78aecca
PE
350 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
351 so that it's not optimized away.
352 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
353 * dispextern.h (bidi_dump_cached_states): Remove, since it's
354 exported only to the debugger.
355
e192d7d3
PE
356 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
357 * atimer.h (run_all_atimers): Removed; not exported.
358
92470028
PE
359 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
360 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
361 was inaccessible from Lisp.
362 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
363 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
364
244ed907
PE
365 alloc.c: Import and export fewer symbols, and remove unused items.
366 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
367 is defined.
368 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
369 it's not optimized away by whole-program optimization.
370 (message_enable_multibyte, free_misc): Remove.
371 (catchlist, handlerlist, mark_backtrace):
372 Declare only if BYTE_MARK_STACK.
373 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
374 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
375 (message_enable_multibyte): Remove decl.
376 (free_misc, interval_free_list, float_block, float_block_index):
377 (n_float_blocks, float_free_list, cons_block, cons_block_index):
378 (cons_free_list, last_marked_index):
379 Now static.
380 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
381 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
382 (mark_backtrace): Define only if BYTE_MARK_STACK.
383 * xdisp.c (message_enable_multibyte): Now static.
384
955cbe7b
PE
385 Declare Lisp_Object Q* variables to be 'static' if not exproted.
386 This makes it easier for human readers (and static analyzers)
387 to see whether these variables are used from other modules.
388 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
389 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
390 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
391 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
392 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
393 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
394 * xmenu.c, xselect.c:
395 Declare Q* vars static if they are not used in other modules.
396 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
397 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
398 Remove decls of unexported vars.
399 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
400
95c82688
PE
401 * lisp.h (DEFINE_FUNC): Make sname 'static'.
402
16a97296
PE
403 Make Emacs functions such as Fatom 'static' by default.
404 This makes it easier for human readers (and static analyzers)
405 to see whether these functions can be called from other modules.
406 DEFUN now defines a static function. To make the function external
407 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
408 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
409 (Finit_image_library):
16a97296
PE
410 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
411 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
412 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
413 Remove decls, since these functions are now static.
414 (Funintern, Fget_internal_run_time): New decls, since these functions
415 were already external.
95c82688 416
16a97296
PE
417 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
418 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
419 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
420 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
421 * keyboard.c, keymap.c, lread.c:
422 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
423 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
424 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
425 Mark functions with DEFUE instead of DEFUN,
426 if they are used in other modules.
427 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
428 decls for now-static functions.
429 * buffer.h (Fdelete_overlay): Remove decl.
430 * callproc.c (Fgetenv_internal): Mark as internal.
431 * composite.c (Fremove_list_of_text_properties): Remove decl.
432 (Fcomposition_get_gstring): New forward static decl.
433 * composite.h (Fcomposite_get_gstring): Remove decl.
434 * dired.c (Ffile_attributes): New forward static decl.
435 * doc.c (Fdocumntation_property): New forward static decl.
436 * eval.c (Ffetch_bytecode): New forward static decl.
437 (Funintern): Remove extern decl; now in .h file where it belongs.
438 * fileio.c (Fmake_symbolic_link): New forward static decl.
439 * image.c (Finit_image_library): New forward static decl.
440 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
441 * intervals.h (Fprevious_property_change):
442 (Fremove_list_of_text_properties): Remove decls.
443 * keyboard.c (Fthis_command_keys): Remove decl.
444 (Fcommand_execute): New forward static decl.
445 * keymap.c (Flookup_key): New forward static decl.
446 (Fcopy_keymap): Now static.
447 * keymap.h (Flookup_key): Remove decl.
448 * process.c (Fget_process): New forward static decl.
449 (Fprocess_datagram_address): Mark as internal.
450 * syntax.c (Fsyntax_table_p): New forward static decl.
451 (skip_chars): Remove duplicate decl.
452 * textprop.c (Fprevious_property_change): New forward static decl.
453 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
454 Now internal.
455 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
456 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
457
785bbd42
PE
458 * editfns.c (Fformat): Remove unreachable code.
459
8b913b57
AS
4602011-04-14 Andreas Schwab <schwab@linux-m68k.org>
461
462 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
463 change. (Bug#8496)
464
a6744a35
EZ
4652011-04-13 Eli Zaretskii <eliz@gnu.org>
466
467 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
468 when at ZV. (Bug#8487)
469
e7974947
AS
4702011-04-12 Andreas Schwab <schwab@linux-m68k.org>
471
baad03f0
AS
472 * charset.c (Fclear_charset_maps): Use xfree instead of free.
473 (Bug#8437)
474 * keyboard.c (parse_tool_bar_item): Likewise.
475 * sound.c (sound_cleanup, alsa_close): Likewise.
476 * termcap.c (tgetent): Likewise.
477 * xfns.c (x_default_font_parameter): Likewise.
478 * xsettings.c (read_and_apply_settings): Likewise.
479
e7974947
AS
480 * alloc.c (overrun_check_malloc, overrun_check_realloc)
481 (overrun_check_free): Protoize.
482
28272684
PE
4832011-04-12 Paul Eggert <eggert@cs.ucla.edu>
484
485 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
486 since callers should never pass a negative size.
487 Change the signature to match that of plain 'read' and 'write'; see
488 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
489 * lisp.h: Update prototypes of emacs_write and emacs_read.
490
11997c76
EZ
4912011-04-11 Eli Zaretskii <eliz@gnu.org>
492
493 * xdisp.c (redisplay_window): Don't try to determine the character
494 position of the scroll margin if the window start point w->startp
e896f03c 495 is outside the buffer's accessible region. (Bug#8468)
11997c76 496
8a2cbd72
EZ
4972011-04-10 Eli Zaretskii <eliz@gnu.org>
498
499 Fix write-region and its subroutines for buffers > 2GB.
500 * fileio.c (a_write, e_write): Modify declaration of arguments and
501 local variables to support buffers larger than 2GB.
502 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
503
504 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
505 argument, local variables, and return value.
506
507 * lisp.h: Update prototypes of emacs_write and emacs_read.
508
509 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
510
4073e537 5112011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 512
1ebfdcb6
PE
513 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
514
b2ded58d
PE
515 Fix more problems found by GCC 4.6.0's static checks.
516
7d66342c
PE
517 * xdisp.c (vmessage): Use a better test for character truncation.
518
bbf47d44
PE
519 * charset.c (load_charset_map): <, not <=, for optimization,
520 and to avoid potential problems with integer overflow.
9248994d 521 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 522 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 523 * editfns.c (Fformat): Likewise.
1e69125e 524 * syntax.c (skip_chars): Likewise.
3befa583 525
e3019616
PE
526 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
527 This also lets GCC 4.6.0 generate slightly better loop code.
528
becfa255
PE
529 * callint.c (Fcall_interactively): <, not <=, for optimization.
530 (Fcall_interactively): Count the number of arguments produced,
531 not the number of arguments given. This is simpler and lets GCC
532 4.6.0 generate slightly better code.
533
dae0cd48
PE
534 * ftfont.c: Distingish more carefully between FcChar8 and char.
535 The previous code passed unsigned char * to a functions like
536 strlen and xstrcasecmp that expect char *, which does not
537 conform to the C standard.
538 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
539 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
540 char * when the C standard requires it.
541
76032d70
PE
542 * keyboard.c (read_char): Remove unused var.
543
eb3f1cc8
PE
544 * eval.c: Port to Windows vsnprintf (Bug#8435).
545 Include <limits.h>.
546 (SIZE_MAX): Define if the headers do not.
547 (verror): Do not give up if vsnprintf returns a negative count.
548 Instead, grow the buffer. This ports to Windows vsnprintf, which
549 does not conform to C99. Problem reported by Eli Zaretskii.
550 Also, simplify the allocation scheme, by avoiding the need for
551 calling realloc, and removing the ALLOCATED variable.
552
70476b54
PE
553 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
554
12020a9e
PE
555 Remove invocations of doprnt, as Emacs now uses vsnprintf.
556 But keep the doprint source code for now, as we might revamp it
557 and use it again (Bug#8435).
ea6c7ae6
PE
558 * lisp.h (doprnt): Remove.
559 * Makefile.in (base_obj): Remove doprnt.o.
560 * deps.mk (doprnt.o): Remove.
561
5fdb398c
PE
562 error: Print 32- and 64-bit integers portably (Bug#8435).
563 Without this change, on typical 64-bit hosts error ("...%d...", N)
564 was used to print both 32- and 64-bit integers N, which relied on
565 undefined behavior.
566 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
567 New macro.
568 * lisp.h (error, verror): Mark as printf-like functions.
569 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
570 Report overflow in size calculations when allocating printf buffer.
571 Do not truncate output string at its first null byte.
572 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
573 Truncate the output at a character boundary, since vsnprintf does not
574 do that.
575 * charset.c (check_iso_charset_parameter): Convert internal
576 character to string before calling 'error', since %c now has the
577 printf meaning.
578 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
579 overflow when computing char to be passed to 'error'. Do not
580 pass Lisp_Object to 'error'; pass the integer instead.
581 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
582 formatted with plain %d.
583
b189fa66
PE
584 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
585
bff87ef0
PE
586 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
587
7e2cac20
PE
588 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
589
ce4d90b5
PE
590 * xterm.c (x_catch_errors): Remove duplicate declaration.
591
266c9547
PE
592 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
593
79c49ad2
PE
594 * xdisp.c, lisp.h (message_nolog): Remove; unused.
595
368f4090
JM
5962011-04-10 Jim Meyering <meyering@redhat.com>
597
598 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
599 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
600 return ssize_t not "int", and use size_t as the buffer length.
601 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
602 * gnutls.h: Update declarations.
603 * process.c (read_process_output): Use ssize_t, to match.
604 (send_process): Likewise.
605
a32d4040
CY
6062011-04-09 Chong Yidong <cyd@stupidchicken.com>
607
608 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
609
8546720e 6102011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 611
8546720e
GM
612 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
613 unsigned char, to match FcChar8 type definition.
aac0c6e3 614
8546720e
GM
615 * xterm.c (handle_one_xevent):
616 * xmenu.c (create_and_show_popup_menu):
617 * xselect.c (x_decline_selection_request)
618 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 619
0a2f5c1a 6202011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
621
622 Fix some uses of `int' instead of EMACS_INT.
623 * search.c (string_match_1, fast_string_match)
624 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
625 (scan_buffer, find_next_newline_no_quit)
626 (find_before_next_newline, search_command, Freplace_match)
627 (Fmatch_data): Make some `int' variables be EMACS_INT.
628
629 * xdisp.c (display_count_lines): 3rd argument and return value now
630 EMACS_INT. All callers changed.
631 (pint2hrstr): Last argument is now EMACS_INT.
632
633 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
634 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
635 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
636 (decode_coding_utf_16, decode_coding_emacs_mule)
637 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
638 (decode_coding_ccl, decode_coding_charset)
639 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
640 (decode_coding_iso_2022, decode_coding_emacs_mule)
641 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
642 <char_offset, last_offset>: Declare EMACS_INT.
643 (encode_coding_utf_8, encode_coding_utf_16)
644 (encode_coding_emacs_mule, encode_invocation_designation)
645 (encode_designation_at_bol, encode_coding_iso_2022)
646 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
647 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
648 Declare EMACS_INT.
649 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
650 (encode_invocation_designation): Last argument P_NCHARS is now
651 EMACS_INT.
652 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
653 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
654
655 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
656 All users changed.
657
658 * ccl.c (Fccl_execute_on_string): Declare some variables
659 EMACS_INT.
660
8546720e 6612011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
662
663 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
664
4e19a977
CS
6652011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
666
667 * process.c (Fformat_network_address): Doc fix.
668
87302331
R
6692011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
670
671 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
672
cbb59342
CY
6732011-04-08 Chong Yidong <cyd@stupidchicken.com>
674
675 * keyboard.c (read_char): Call Lisp function help-form-show,
676 instead of using internal_with_output_to_temp_buffer.
677 (Qhelp_form_show): New var.
e0d38eeb 678 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
679
680 * print.c (internal_with_output_to_temp_buffer): Function deleted.
681
682 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
683
e67a13ab
CY
6842011-04-06 Chong Yidong <cyd@stupidchicken.com>
685
686 * process.c (Flist_processes): Removed to Lisp.
687 (list_processes_1): Deleted.
688
973f782d
EZ
6892011-04-06 Eli Zaretskii <eliz@gnu.org>
690
7c106b1e
EZ
691 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
692
973f782d
EZ
693 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
694
41cf7d1a 6952011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 696
ca23cc88
PE
697 Fix more problems found by GCC 4.6.0's static checks.
698
f390e2d5
PE
699 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
700
42eea0d0
PE
701 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
702
b69769da 703 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 704
f9541e84
PE
705 * xdisp.c (vmessage): Mark as a printf-like function.
706
13841b55
PE
707 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
708
c136c10f
PE
709 * sound.c (sound_warning): Don't crash if arg contains a printf format.
710
5e2d4a30
PE
711 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
712 printf-like functions.
713 (tiff_load): Add casts to remove these marks before passing them
714 to system-supplied API.
715
583f48b9
PE
716 * eval.c (Fsignal): Remove excess argument to 'fatal'.
717
b25d760e
PE
718 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
719 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
720 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
721 directly, rather than having caller test rule sign. This avoids
722 some unnecessary tests.
723 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
724 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
725 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 726
bc7b6697 727 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 728 (xfont_open): Avoid unnecessary tests.
bc7b6697 729
27ccc379
PE
730 * composite.c (composition_gstring_put_cache): Use unsigned integer.
731
dcd5c89a
PE
732 * composite.h, composite.c (composition_gstring_put_cache):
733 Use EMACS_INT, not int, for length.
734
b13a45c6
PE
735 * composite.h (COMPOSITION_DECODE_REFS): New macro,
736 breaking out part of COMPOSITION_DECODE_RULE.
737 (COMPOSITION_DECODE_RULE): Use it.
738 * composite.c (get_composition_id): Remove unused local vars,
739 by using the new macro.
740
1e792e4d
PE
741 * textprop.c (set_text_properties_1): Change while to do-while,
742 since the condition is always true at first.
743
dc6c6455 744 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
745 (interval_deletion_adjustment): Return unsigned value.
746 All uses changed.
dc6c6455 747
aba7731a
PE
748 * process.c (list_processes_1, create_pty, read_process_output):
749 (exec_sentinel): Remove vars that were set but not used.
afd4052b 750 (create_pty): Remove unnecessary "volatile"s.
bc57d757 751 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 752 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 753 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 754
fdfc4bf3
PE
755 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
756
fca8fe46 757 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 758 (update_syntax_table): Use unsigned instead of int.
fca8fe46 759
06a0259a 760 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 761 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 762 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 763
e7b9e80f
PE
764 * print.c (print_error_message): Avoid int overflow.
765
56201685
PE
766 * font.c (font_list_entities): Redo for clarity,
767 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
768
78834453 769 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 770 (font_score): Avoid potential overflow in diff calculation.
78834453 771
0bc0b309 772 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 773 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 774
e610eaca
PE
775 * eval.c (funcall_lambda): Rename local to avoid shadowing.
776
b895abce
PE
777 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
778 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
779 can always succeed if overflow has undefined behavior.
780
1f1d9321 781 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 782 (wordify): Omit three unnecessary tests.
1f1d9321 783
c59478bc
PE
784 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
785 All callers changed. This avoids the need for an unused var.
786
79b73827
PE
787 * casefiddle.c (casify_region): Remove var that is set but not used.
788
a4db5dfe
PE
789 * dired.c (file_name_completion): Remove var that is set but not used.
790
43aae36e
PE
791 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
792
2a47c44d 793 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 794 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 795
a37c69bf
PE
796 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
797 Check for integer overflow on size calculations.
798
328ab8e7
PE
799 * buffer.c (Fprevious_overlay_change): Remove var that is set
800 but not used.
801
e5a2a5cb
PE
802 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
803 Remove vars that are set but not used.
8d84a6eb 804 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 805 (timer_check_2): Mark vars as initialized.
e5a2a5cb 806
a60e5f68
PE
807 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
808
f661cb61 809 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 810 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 811
f0397f5a
PE
812 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
813 that are set but not used.
814
8664db06 815 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 816 if XCreateBitmapFromData fails (Bug#8410).
8664db06 817
6abdaa4a
PE
818 * xselect.c (x_get_local_selection, x_handle_property_notify):
819 Remove vars that are set but not used.
820
0ce7538d 821 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 822 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 823
9ae848fc
PE
824 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
825 Remove var that is set but not used.
0b918413
PE
826 (scroll_bar_windows_size): Now size_t, not int.
827 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
828 Check for overflow.
9ae848fc 829
a5a62657
PE
830 * xfaces.c (realize_named_face): Remove vars that are set but not used.
831 (map_tty_color) [!defined MSDOS]: Likewise.
832
5c5cdd39
PE
833 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
834
66ebf983
PE
835 * coding.c: Remove vars that are set but not used.
836 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
837 All callers changed.
838 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
839 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
840 (decode_coding_charset): Remove vars that are set but not used.
841
1be4d761
PE
842 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
843 that is set but not used.
844
47553fa8
PE
845 * print.c (print_object): Remove var that is set but not used.
846
1f7196bf 847 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
848 The gnulib version avoids calling malloc in the usual case,
849 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
850 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
851 * filelock.c (current_lock_owner): Likewise.
852 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
853 * sysdep.c: Include allocator.h, careadlinkat.h.
854 (emacs_no_realloc_allocator): New static constant.
855 (emacs_readlink): New function.
fdb61804
PE
856 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
857 ../lib/careadlinkat.h.
d1fdcab7 858
f84c17c7
SM
8592011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
860
861 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
862 first non-nil return value).
863
ef3862ad
JD
8642011-04-03 Jan Djärv <jan.h.d@swipnet.se>
865
866 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
867 if not defined (Bug#8403).
868
376a7006
JB
8692011-04-02 Juanma Barranquero <lekktu@gmail.com>
870
871 * xdisp.c (display_count_lines): Remove parameter `start',
872 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
873 (get_char_face_and_encoding): Remove parameter `multibyte_p',
874 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
875 (fill_stretch_glyph_string): Remove parameters `row' and `area',
876 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
877 and thereabouts. All callers changed.
878 (get_per_char_metric): Remove parameter `f', unused since
879 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
880
6ca3801d
JM
8812011-04-02 Jim Meyering <meyering@redhat.com>
882
883 do not dereference NULL upon failed strdup
884 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
885 (ns_get_family): Likewise.
886
d8e2b5ba
JB
8872011-04-02 Juanma Barranquero <lekktu@gmail.com>
888
889 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
890
8c74fcbd
JD
8912011-04-02 Jan Djärv <jan.h.d@swipnet.se>
892
893 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
894 later (Bug#8403).
895
7200d79c
SM
8962011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
897
03408648 898 Add lexical binding.
7200d79c 899
03408648
SM
900 * window.c (Ftemp_output_buffer_show): New fun.
901 (Fsave_window_excursion):
902 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
903
904 * lread.c (lisp_file_lexically_bound_p): New function.
905 (Fload): Bind Qlexical_binding.
906 (readevalloop): Remove `evalfun' arg.
907 Bind Qinternal_interpreter_environment.
908 (Feval_buffer): Bind Qlexical_binding.
909 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
910 Mark as dynamic.
911 (syms_of_lread): Declare `lexical-binding'.
912
913 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
914
915 * keyboard.c (eval_dyn): New fun.
916 (menu_item_eval_property): Use it.
ca105506
SM
917
918 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 919
03408648
SM
920 * fns.c (concat, mapcar1): Accept byte-code-functions.
921
922 * eval.c (Fsetq): Handle lexical vars.
923 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
924 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
925 (FletX, Flet): Obey lexical binding.
926 (Fcommandp): Handle closures.
927 (Feval): New `lexical' arg.
928 (eval_sub): New function extracted from Feval. Use it almost
929 everywhere where Feval was used. Look up vars in lexical env.
930 Handle closures.
931 (Ffunctionp): Move from subr.el.
932 (Ffuncall): Handle closures.
933 (apply_lambda): Remove `eval_flags'.
934 (funcall_lambda): Handle closures and new byte-code-functions.
935 (Fspecial_variable_p): New function.
936 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
937 but without exporting it to Lisp.
23aba0ea 938
23aba0ea 939 * doc.c (Fdocumentation, store_function_docstring):
03408648 940 * data.c (Finteractive_form): Handle closures.
23aba0ea 941
03408648
SM
942 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
943 interactive spec.
ba83908c 944
03408648
SM
945 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
946 byte-codes.
947 (exec_byte_code): New function extracted from Fbyte_code to handle new
948 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 949
03408648 950 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 951
03408648 952 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 953
e2abce01
JB
9542011-03-31 Juanma Barranquero <lekktu@gmail.com>
955
956 * xdisp.c (redisplay_internal): Fix prototype.
957
63696a73 9582011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 959
63696a73
EZ
960 * xdisp.c (SCROLL_LIMIT): New macro.
961 (try_scrolling): Use it when setting scroll_limit. Limit
962 scrolling to 100 screen lines.
963 (redisplay_window): Even when falling back on "recentering",
964 position point in the window according to scroll-conservatively,
965 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
966
967 (try_scrolling): When point is above the window, allow searching
968 as far as scroll_max, or one screenful, to compute vertical
969 distance from PT to the scroll margin position. This prevents
970 try_scrolling from unnecessarily failing when
971 scroll-conservatively is set to a value slightly larger than the
972 window height. Clean up the case of PT below the margin at bottom
973 of window: scroll_max can no longer be INT_MAX. When aggressive
974 scrolling is in use, don't let point enter the opposite scroll
975 margin as result of the scroll.
976 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
977 threshold of 100 lines for never-recentering scrolling.
978
e4cc2dfc
JB
9792011-03-31 Juanma Barranquero <lekktu@gmail.com>
980
981 * dispextern.h (move_it_by_lines):
982 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
983 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
984 (message_log_check_duplicate): Remove parameters `prev_bol' and
985 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
986 (redisplay_internal): Remove parameter `preserve_echo_area',
987 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
988
989 * indent.c (Fvertical_motion):
990 * window.c (window_scroll_pixel_based, Frecenter):
991 Don't pass `need_y_p' to `move_it_by_lines'.
992
1c470562
SM
9932011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
994
44f230aa
SM
995 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
996 steal a few bits to be more compact.
997 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
998 Remove unneeded casts.
999
1c470562
SM
1000 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1001
888adce9
ZK
10022011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1003
1004 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1005 binding" message (bug#7967).
1006
f838ed7b
PE
10072011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1008
77861b95
PE
1009 Fix more problems found by GCC 4.6.0's static checks.
1010
de6dbc14
PE
1011 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1012 Remove unused local var.
1013
f838ed7b
PE
1014 * editfns.c (Fmessage_box): Remove unused local var.
1015
792c7b2b
PE
1016 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1017 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1018 Omit unused local vars.
c499e557 1019 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1020 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1021 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1022 Omit unused local var.
1023
ba0165e1
PE
1024 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1025 Don't assume string length fits in int.
32ad8845 1026 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1027 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1028
3c59b4c9
PE
1029 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1030 instead of alloca (Bug#8344).
1031
a3eed478 1032 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1033 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1034
eb4d412d
PE
1035 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1036
1658b401
PE
1037 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1038 concerns.
1039
1040 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1041
1042 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1043
9a2c6e05
PE
1044 * keyboard.c (syms_of_keyboard): Use the same style as later
1045 in this function when indexing through an array. This also
1046 works around GCC bug 48267.
1047
03d0a109
PE
1048 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1049
44f730c8
PE
1050 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1051
fe75f926
PE
1052 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1053 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1054
ffa8c828
PE
1055 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1056 This avoids undefined behavior on integer overflow, and is a bit
1057 more convenient anyway since it is compared to a size_t variable.
1058
c5101a77
PE
1059 Variadic C functions now count arguments with size_t, not int.
1060 This avoids an unnecessary limitation on 64-bit machines, which
1061 caused (substring ...) to crash on large vectors (Bug#8344).
1062 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1063 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1064 All variadic functions and their callers changed accordingly.
c5101a77
PE
1065 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1066 * data.c (arith_driver, float_arith_driver): Likewise.
1067 * editfns.c (general_insert_function): Likewise.
1068 * eval.c (struct backtrace.nargs, interactive_p)
1069 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1070 (funcall_lambda, mark_backtrace): Likewise.
1071 * fns.c (concat): Likewise.
1072 * frame.c (x_set_frame_parameters): Likewise.
1073 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1074 0 if not found, not -1. All callers changed.
1075
dd3f25f7
PE
1076 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1077 (stack_copy_size): Now size_t, not int.
1078 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1079
461c2ab9
JB
10802011-03-28 Juanma Barranquero <lekktu@gmail.com>
1081
1082 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1083 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1084 All callers changed.
1085
1086 * lisp.h (multibyte_char_to_unibyte):
1087 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1088 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1089 * character.h (CHAR_TO_BYTE8):
1090 * cmds.c (internal_self_insert):
1091 * editfns.c (general_insert_function):
1092 * keymap.c (push_key_description):
1093 * search.c (Freplace_match):
1094 * xdisp.c (message_dolog, set_message_1): All callers changed.
1095
f6d62986
SM
10962011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1097
1098 * keyboard.c (safe_run_hook_funcall): New function.
1099 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1100 don't set the hook to nil, but remove the offending function instead.
1101 (Qcommand_hook_internal): Remove, unused.
1102 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1103 Vcommand_hook_internal.
1104
1105 * eval.c (enum run_hooks_condition): Remove.
1106 (funcall_nil, funcall_not): New functions.
1107 (run_hook_with_args): Call each function through a `funcall' argument.
1108 Remove `cond' argument, now redundant.
1109 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1110 (Frun_hook_with_args_until_failure): Adjust accordingly.
1111 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1112
1db5b1ad
JB
11132011-03-28 Juanma Barranquero <lekktu@gmail.com>
1114
1115 * dispextern.h (string_buffer_position): Remove declaration.
1116
1117 * print.c (strout): Remove parameter `multibyte', unused since
1118 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1119
1120 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1121 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1122 All callers changed.
1123
1124 * w32.c (_wsa_errlist): Use braces for struct initializers.
1125
1126 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1127 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1128 All callers changed.
1129 (string_buffer_position): Likewise. Also, make static (it's never
1130 used outside xdisp.c).
1131 (cursor_row_p): Remove parameter `w', unused since
1132 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1133 (decode_mode_spec): Remove parameter `precision', introduced during
1134 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1135 All callers changed.
1136
5ffb62aa
JD
11372011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1138
1139 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1140
461c2ab9 11412011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1142
1143 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1144 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1145 (ns_update_auto_hide_menu_bar): New functions.
1146 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1147 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1148 ns_constrain_all_frames.
1149 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1150 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1151
5c380ffb
JD
11522011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1153
1154 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1155
9af30bdf
GM
11562011-03-27 Glenn Morris <rgm@gnu.org>
1157
1158 * syssignal.h: Replace RETSIGTYPE with void.
1159 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1160 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1161 Replace SIGTYPE with void everywhere.
1162 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1163 * s/template.h (SIGTYPE): Remove commented out definition.
1164
e2abce01
JB
11652011-03-26 Eli Zaretskii <eliz@gnu.org>
1166
1167 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1168 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1169
f868cd8a
JB
11702011-03-26 Juanma Barranquero <lekktu@gmail.com>
1171
59eb0929
JB
1172 * w32.c (read_unc_volume): Use parameter `henum', instead of
1173 global variable `wget_enum_handle'.
1174
1175 * keymap.c (describe_vector): Remove parameters `indices' and
1176 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1177 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1178
f868cd8a
JB
1179 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1180
1181 * keyboard.c (timer_check): Remove parameter `do_it_now',
1182 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1183 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1184 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1185
1186 * keyboard.c (read_char):
1187 * w32menu.c (w32_menu_display_help):
1188 * xmenu.c (show_help_event, menu_help_callback):
1189 Adjust calls to `show_help_echo'.
1190
1191 * gtkutil.c (xg_maybe_add_timer):
1192 * keyboard.c (readable_events):
1193 * process.c (wait_reading_process_output):
1194 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1195
1196 * insdel.c (adjust_markers_gap_motion):
1197 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1198 (gap_left, gap_right): Don't call it.
1199
2ecf6fdb
CY
12002011-03-25 Chong Yidong <cyd@stupidchicken.com>
1201
1202 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1203 incurred during fontification.
1204
6b1f9ba4
JB
12052011-03-25 Juanma Barranquero <lekktu@gmail.com>
1206
1207 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1208 (DEFVAR_PER_BUFFER): Don't pass it.
1209
1210 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1211 (scrolling_window): Don't pass it.
1212
0f4a96b5
JB
12132011-03-25 Juanma Barranquero <lekktu@gmail.com>
1214
1215 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1216
1217 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1218 and `suffix'.
1219 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1220 of variables specific to SELinux and computation of `encoded_absname'.
1221
1222 * image.c (XPutPixel): Remove unused variable `height'.
1223
1224 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1225
1226 * unexw32.c (get_section_info): Remove unused variable `section'.
1227
1228 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1229 (system_process_attributes): Remove unused variable `sess'.
1230 (sys_read): Remove unused variable `err'.
1231
1232 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1233 (w32_wnd_proc): Remove unused variable `isdead'.
1234 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1235 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1236 (x_create_tip_frame): Remove unused variable `tem'.
1237
1238 * w32inevt.c (w32_console_read_socket):
1239 Remove unused variable `no_events'.
1240
1241 * w32term.c (x_draw_composite_glyph_string_foreground):
1242 Remove unused variable `width'.
1243
1149507c
JB
12442011-03-24 Juanma Barranquero <lekktu@gmail.com>
1245
1246 * w32term.c (x_set_glyph_string_clipping):
1247 Don't pass uninitialized region to CombineRgn.
1248
9c88f339
JB
12492011-03-23 Juanma Barranquero <lekktu@gmail.com>
1250
1251 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1252 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1253 (Fx_close_connection): Remove unused variable `i'.
1254
1255 * w32font.c (w32font_draw): Return number of glyphs.
1256 (w32font_open_internal): Remove unused variable `i'.
1257 (w32font_driver): Add missing initializer.
1258
1259 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1260 (fill_in_menu): Remove unused variable `items_added'.
1261
1262 * w32term.c (last_mouse_press_frame): Remove static global variable.
1263 (w32_clip_to_row): Remove unused variable `f'.
1264 (x_delete_terminal): Remove unused variable `i'.
1265
1266 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1267 (NOTHING): Remove unused static global variable.
1268 (uniscribe_check_otf): Remove unused variable `table'.
1269 (uniscribe_font_driver): Add missing initializers.
1270
dee091a3
JD
12712011-03-23 Julien Danjou <julien@danjou.info>
1272
1273 * term.c (Fsuspend_tty, Fresume_tty):
1274 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1275 * window.c (temp_output_buffer_show):
1276 * insdel.c (signal_before_change):
1277 * frame.c (Fhandle_switch_frame):
1278 * fileio.c (Fdo_auto_save):
1279 * emacs.c (Fkill_emacs):
1280 * editfns.c (save_excursion_restore):
1281 * cmds.c (internal_self_insert):
1282 * callint.c (Fcall_interactively):
1283 * buffer.c (Fkill_all_local_variables):
1284 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1285 Use Frun_hooks.
0f4a96b5 1286 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1287 unconditionnaly since it does the check itself.
1288
2c520ab5 12892011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1290
c9c49752
PE
1291 Fix more problems found by GCC 4.5.2's static checks.
1292
8abc3f12
PE
1293 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1294 the first time through the loop, since we know p0 < p1 then.
1295 This also avoids a gcc -Wstrict-overflow warning.
1296
a2d26660
PE
1297 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1298 leading to a memory leak, possible in functions like
1299 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1300 of objects (Bug#8318).
a2d26660 1301
916c72e9
PE
1302 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1303 that could (at least in theory) be that large.
1304
19ab8a18
PE
1305 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1306 This is less likely to overflow, and avoids undefined behavior if
1307 overflow does occur. All callers changed. Use strtoul to scan
1308 for the unsigned long integer.
b7cbbd6f
PE
1309 (pint2hrstr): Simplify and tune code slightly.
1310 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1311
f0641eff
PE
1312 * scroll.c (do_scrolling): Work around GCC bug 48228.
1313 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1314
7f650bb9
PE
1315 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1316 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1317 (validate_x_resource_name): Simplify count usage.
1318 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1319
37dd57d1
PE
1320 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1321 fail (Bug#8306).
81e56e61 1322
699979fc 1323 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1324
401bf9b4
PE
1325 * process.c (Fmake_network_process): Use socklen_t, not int,
1326 where POSIX says socklen_t is required in portable programs.
1327 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1328 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1329 (Fmake_network_process, server_accept_connection):
1330 (wait_reading_process_output, read_process_output):
1331 Likewise.
1332
b93aacde
PE
1333 * process.c: Rename or move locals to avoid shadowing.
1334 (list_processes_1, Fmake_network_process):
1335 (read_process_output_error_handler, exec_sentinel_error_handler):
1336 Rename or move locals.
4dc343ee 1337 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1338 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1339 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1340 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1341 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1342
af8a867c 1343 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1344 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1345 Include tparam.h instead, since it declares them.
af8a867c
PE
1346 * cm.h (PC): Remove extern decl; tparam.h now does this.
1347 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1348 * terminfo.c: Include tparam.h, to check interfaces.
1349 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1350 (tparam): Adjust signature to match interface in tparam.h;
1351 this removes some undefined behavior. Check that outstring and len
1352 are zero, which they always are with Emacs.
1353 * tparam.h (PC, BC, UP): New extern decls.
1354
0248044d 1355 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1356 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1357
8ff096c1 1358 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1359 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1360 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1361 (ftfont_list): Remove unused local.
49eaafba
PE
1362 (get_adstyle_property, ftfont_pattern_entity):
1363 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1364 Rename locals to avoid shadowing.
8ff096c1 1365
e2be39f6
PE
1366 * xfont.c (xfont_list_family): Mark var as initialized.
1367
c9735e30
PE
1368 * xml.c (make_dom): Now static.
1369
8f5201ae
PE
1370 * composite.c (composition_compute_stop_pos): Rename local to
1371 avoid shadowing.
b246f932
PE
1372 (composition_reseat_it): Remove unused locals.
1373 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1374 (composition_update_it): Mark var as initialized.
11b61122
PE
1375 (find_automatic_composition): Mark vars as initialized,
1376 with a FIXME (Bug#8290).
8f5201ae 1377
760fbc2c
PE
1378 character.h: Rename locals to avoid shadowing.
1379 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1380 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1381 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1382 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1383 to avoid shadowing.
1384
ff08eb85
PE
1385 * textprop.c (property_change_between_p): Remove; unused.
1386
fc7bf025
PE
1387 * intervals.c (interval_start_pos): Now static.
1388
235d7abc
PE
1389 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1390
44f230aa
SM
1391 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1392 Rename locals to avoid shadowing.
3e7d6594 1393
50060332
PE
1394 * sound.c (wav_play, au_play, Fplay_sound_internal):
1395 Fix pointer signedness.
d01f234b 1396 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1397 (wav_play): Initialize a variable to 0, to prevent undefined
1398 behavior (Bug#8278).
50060332 1399
c4fc4e30
PE
1400 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1401
918436ed
PE
1402 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1403
c939f91b
PE
1404 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1405 clobbering (Bug#8298).
b9c7f648
PE
1406 * sysdep.c (sys_subshell): Likewise.
1407 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1408
6bd8c144
PE
1409 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1410 This should get cleaned up, so that child_setup has the
1411 same signature on all platforms.
1412
7710357c 1413 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1414 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1415
c59da222
CY
14162011-03-22 Chong Yidong <cyd@stupidchicken.com>
1417
1418 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1419 not to be necessary, and produces flickering.
1420
66b87493
GM
14212011-03-20 Glenn Morris <rgm@gnu.org>
1422
1423 * config.in: Remove file.
1424
45b6f6d5
JB
14252011-03-20 Juanma Barranquero <lekktu@gmail.com>
1426
1427 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1428 are now in src/globals.h.
1429 (syms_of_minibuf): Remove spurious & from previous change.
1430
3ec03f7e
LL
14312011-03-20 Leo <sdl.web@gmail.com>
1432
1433 * minibuf.c (completing-read-function): New variable.
1434 (completing-read-default): Rename from completing-read.
1435 (completing-read): Call completing-read-function.
1436
b14e3e21
CY
14372011-03-19 Juanma Barranquero <lekktu@gmail.com>
1438
1439 * xfaces.c (Fx_load_color_file):
1440 Read color file from absolute filename (bug#8250).
1441
f2b726e6
JB
14422011-03-19 Juanma Barranquero <lekktu@gmail.com>
1443
1444 * makefile.w32-in: Update dependencies.
1445
09f6ff02
EZ
14462011-03-17 Eli Zaretskii <eliz@gnu.org>
1447
1448 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1449
29a6015a
PE
14502011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1451
a3a6c54e
PE
1452 Fix more problems found by GCC 4.5.2's static checks.
1453
b766f867
PE
1454 * process.c (make_serial_process_unwind, send_process_trap):
1455 (sigchld_handler): Now static.
1456
be02381c
PE
1457 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1458 That way, the code declares only the vars that it needs.
1459 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1460 * s/cygwin.h (PTY_ITERATION): Likewise.
1461 * s/darwin.h (PTY_ITERATION): Likewise.
1462 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1463
57048744
PE
1464 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1465 * process.c (allocate_pty): Don't declare stb unless it's needed.
1466
7914961c 1467 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1468 (CONSTANTLIM): Remove; unused.
1469 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1470 Define only if needed.
7914961c 1471
b3967b18
PE
1472 * unexelf.c (unexec): Name an expression,
1473 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1474 Use a different way to cause a compilation error if anyone uses
1475 n rather than nn, a way that does not involve shadowing.
73366a00 1476 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1477
29a6015a
PE
1478 * deps.mk (unexalpha.o): Remove; unused.
1479
43cfc33e 1480 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1481 * unexec.h: New file.
ce701a33
PE
1482 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1483 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1484 Depend on unexec.h.
1485 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1486 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1487 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1488 Change as necessary to match prototype in unexec.h.
ce701a33 1489
01f44d5a
PE
1490 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1491 shadowing.
4f63c6bb 1492 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1493
a6670b0b
PE
1494 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1495 Rename locals to avoid shadowing.
1496
cef2010d 1497 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1498 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1499
d4d7173a
PE
1500 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1501
f08b802a
PE
1502 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1503 warning when compiling print.c.
1504
3ddb0639
PE
1505 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1506 instead of using an uninitialized var.
5ad03b97 1507 (font_sort_entities): Mark var as initialized.
3ddb0639 1508
170a2692
PE
1509 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1510
e663c700
PE
1511 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1512 pointers to constants.
89bc529a 1513 (font_parse_fcname): Remove unused vars.
7b81e2d0 1514 (font_delete_unmatched): Now static.
ea838e10 1515 (font_get_spec): Remove; unused.
13a547c6
PE
1516 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1517 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1518 Rename or move locals to avoid shadowing.
e663c700 1519
2a80c887 1520 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1521 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1522
1384fa33 1523 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1524 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1525
8b2c52e9
PE
1526 * alloc.c (mark_backtrace): Move decl from here ...
1527 * lisp.h: ... to here, so that it can be checked.
1528
475545b5 1529 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1530 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1531 (lisp_indirect_variable): Name an expression,
1532 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1533 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1534
b1349114 1535 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1536 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1537 Use const pointer when appropriate.
b1349114 1538
a2928364
PE
1539 * lisp.h (get_system_name, get_operating_system_release):
1540 Move decls here, to check interfaces.
1541 * process.c (get_operating_system_release): Move decl to lisp.h.
1542 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1543 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1544 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1545 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1546 (Fformat_time_string, Fencode_time, Finsert_char):
1547 (Ftranslate_region_internal, Fformat):
1548 Rename or remove local vars to avoid shadowing.
9710023e 1549 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1550
a415e694
PE
1551 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1552 avoid shadowing.
1553
8ef4622d
PE
1554 * lisp.h (eassert): Check that the argument compiles, even if
1555 ENABLE_CHECKING is not defined.
1556
946f9a5b
PE
1557 * data.c (Findirect_variable): Name an expression, to avoid
1558 gcc -Wbad-function-cast warning.
112396d6 1559 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1560 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1561 (Fmake_variable_buffer_local, Fmake_local_variable):
1562 Mark variables as initialized.
52746918 1563 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1564
e5aab7e7 1565 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1566 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1567 Rename locals to avoid shadowing.
dff45157
PE
1568 (mark_stack): Move local variables into the #ifdef region where
1569 they're used.
7bc26fdb
PE
1570 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1571 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1572 needed otherwise.
1573 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1574 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1575 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1576
e5aab7e7
PE
1577 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1578 avoids undefined behavior in theory.
1579
4da60324
PE
1580 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1581
88043301
PE
1582 Use functions, not macros, for up- and down-casing (Bug#8254).
1583 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1584 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1585 to use the following functions instead of these macros.
1586 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1587 EMACS_INT, since callers assume the returned value fits in int.
1588 (upcase1): Likewise, for UPCASE_TABLE.
1589 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1590 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1591 the race-condition problem in the old DOWNCASE.
88043301 1592
19ed5445
PE
1593 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1594 Rename locals to avoid shadowing.
1595 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1596 (regex_compile, re_search_2, re_match_2_internal):
1597 Remove unused local vars.
952db0d7
PE
1598 (FREE_VAR): Rewrite so as not to use empty "else",
1599 which gcc can warn about.
da053e48 1600 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1601 (RETALLOC_IF): Define only if needed.
1602 (WORDCHAR_P): Likewise. This one is never needed, but is used
1603 only in a comment talking about a compiler bug, so put inside
1604 the #if 0 of that comment.
1605 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1606 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1607 Remove; unused.
19ed5445 1608
1f3561e4 1609 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1610 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1611 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1612
ded6f8f7
PE
1613 * search.c (simple_search): Remove unused var.
1614
dbd37a95
PE
1615 * dired.c (compile_pattern): Move decl from here ...
1616 * lisp.h: ... to here, so that it can be checked.
1617 (struct re_registers): New forward decl.
1618
7e47afad
PE
1619 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1620
85f24f61
PE
1621 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1622 All uses changed.
1623 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1624 Rename locals to avoid shadowing.
5671df8f 1625 (Fvertical_motion): Mark locals as initialized.
85f24f61 1626
181aa2be 1627 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1628 (casify_region): Mark local as initialized.
181aa2be 1629
930d429c
PE
1630 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1631
7082eac6
PE
1632 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1633 New macros, so that the caller can use some names other than
1634 gcpro1, gcpro2, etc.
1635 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1636 of the new macros.
1637 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1638 argument, for consistency with GCPRO2_VAR, etc: it is now the
1639 prefix of the variable, not the variable itself. All uses
1640 changed.
38b2c076
PE
1641 * dired.c (directory_files_internal, file_name_completion):
1642 Rename locals to avoid shadowing.
1643
15206ed9
PE
1644 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1645 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1646 dired.c's scmp function, had undefined behavior.
1647 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1648 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1649 * buffer.h: ... to here, because these macros use current_buffer,
1650 and the new implementation with inline functions needs to have
1651 current_buffer in scope now, rather than later when the macros
1652 are used.
1653 (downcase, upcase1): New static inline functions.
1654 (DOWNCASE, UPCASE1): Reimplement using these functions.
1655 This avoids undefined behavior in expressions like
1656 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1657 from race conditions in accessing the global variables
1658 case_temp1 and case_temp2.
1659 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1660 * lisp.h (case_temp1, case_temp2): Remove their decls.
1661 * character.h (ASCII_CHAR_P): Move from here ...
1662 * lisp.h: ... to here, so that the inline functions mentioned
1663 above can use them.
1664
4a6bea26
PE
1665 * dired.c (directory_files_internal_unwind): Now static.
1666
f14b7e14
PE
1667 * fileio.c (file_name_as_directory, directory_file_name):
1668 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1669 Now static.
2893f146
PE
1670 (file_name_as_directory): Use const pointers when appropriate.
1671 (Fexpand_file_name): Likewise. In particular, newdir might
1672 point at constant storage, so make it a const pointer.
fd4ead52 1673 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1674 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1675 signedness issues.
f839df0c
PE
1676 (Fset_file_times, Finsert_file_contents, auto_save_error):
1677 Rename locals to avoid shadowing.
f14b7e14 1678
5716756e 1679 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1680 (Ftry_completion, Fall_completions): Rename or remove locals
1681 to avoid shadowing.
5716756e 1682
b4c3046a
PE
1683 * marker.c (bytepos_to_charpos): Remove; unused.
1684
b45db522
PE
1685 * lisp.h (verify_bytepos, count_markers): New decls,
1686 so that gcc does not warn that these functions aren't declared.
1687
85876d07
PE
1688 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1689 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1690 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1691 (copy_text): Remove unused local var.
85876d07 1692
03d78a21 1693 * filelock.c (within_one_second): Now static.
b3dd38ab 1694 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1695
5df8f01b
PE
1696 * buffer.c (fix_overlays_before): Mark locals as initialized.
1697 (fix_start_end_in_overlays): Likewise. This function should be
1698 simplified by using pointers-to-pointers, but that's a different
1699 matter.
b1d876f1 1700 (switch_to_buffer_1): Now static.
8f54f30a
PE
1701 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1702 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1703
a70072c9 1704 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1705 Fix pointer signedness issue.
edced198
PE
1706 (sys_subshell): Mark local as volatile if checking for lint,
1707 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1708 (MAXPATHLEN): Define only if needed.
a70072c9 1709
a0977c44
PE
1710 * process.c (serial_open, serial_configure): Move decls from here ...
1711 * systty.h: ... to here, so that they can be checked.
1712
a884fdcc
PE
1713 * fns.c (get_random, seed_random): Move extern decls from here ...
1714 * lisp.h: ... to here, so that they can be checked.
1715
604efe86 1716 * sysdep.c (reset_io): Now static.
b8950c94 1717 (wait_for_termination_signal): Remove; unused.
604efe86 1718
38fc62d9
PE
1719 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1720 (copy_keymap_item, append_key, push_text_char_description):
1721 Now static.
1004a21a 1722 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1723 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1724 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1725 (describe_map_tree):
1726 Rename locals to avoid shadowing.
38fc62d9 1727
2f2650da
PE
1728 * keyboard.c: Declare functions static if they are not used elsewhere.
1729 (echo_char, echo_dash, cmd_error, top_level_2):
1730 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1731 (read_char, kbd_buffer_get_event, make_lispy_position):
1732 (make_lispy_event, make_lispy_movement, apply_modifiers):
1733 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1734 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1735 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1736 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1737 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1738
a053e86c 1739 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1740 (mark_kboards): Move decl here ...
1741 * alloc.c (mark_kboards): ... from here.
a053e86c 1742
4752793e
PE
1743 * lisp.h (force_auto_save_soon): New decl.
1744
74f10ca7 1745 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1746 (DEFINE_DUMMY_FUNCTION): New macro.
1747 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1748 Use it.
c03cd23f
PE
1749 (main): Add casts to avoid warnings
1750 if GCC considers string literals to be constants.
74f10ca7 1751
022e70d4
PE
1752 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1753
59d6fe83
PE
1754 * dbusbind.c: Pointer signedness fixes.
1755 (xd_signature, xd_append_arg, xd_initialize):
1756 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1757 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1758 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1759 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1760
78320123
PE
1761 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1762 if GCC considers string literals to be constants.
49cebcca 1763 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1764
35ac2a97
SM
17652011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1766
fb103ca9
SM
1767 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1768 (print_preprocess, print_object): New macro to fix last change.
1769
35ac2a97
SM
1770 * print.c (print_preprocess): Don't forget font objects.
1771
62973b41
JB
17722011-03-16 Juanma Barranquero <lekktu@gmail.com>
1773
1774 * emacs.c (USAGE3): Doc fixes.
1775
0e48bb22
AS
17762011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1777
1778 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1779 structure.
1780
7684e57b
JB
17812011-03-14 Juanma Barranquero <lekktu@gmail.com>
1782
1783 * lisp.h (VWindow_system, Qfile_name_history):
1784 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1785 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1786 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1787
1788 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1789 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1790
1791 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1792 * w32console.c (detect_input_pending, read_input_pending)
1793 (encode_terminal_code):
1794 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1795 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1796 (w32_system_caret_y, Qfile_name_history):
1797 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1798 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1799 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1800 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1801 * w32proc.c (Qlocal, report_file_error):
1802 * w32term.c (Vwindow_system, updating_frame):
1803 * w32uniscribe.c (initialized, uniscribe_font_driver):
1804 Remove unneeded extern declarations.
1805
2aa46d6c
CY
18062011-03-14 Chong Yidong <cyd@stupidchicken.com>
1807
c96bbc66 1808 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1809
cffc6f3b
CY
18102011-03-13 Chong Yidong <cyd@stupidchicken.com>
1811
1812 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1813 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1814 These macros can no longer be used for assignment.
1815
44f230aa
SM
1816 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1817 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1818 (record_buffer_markers, fetch_buffer_markers): New functions for
1819 recording and fetching special buffer markers.
1820 (set_buffer_internal_1, set_buffer_temp): Use them.
1821
1822 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1823
1824 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1825
1826 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1827 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1828
1829 * xdisp.c (hscroll_window_tree):
1830 (reconsider_clip_changes): Use PT instead of BUF_PT.
1831
d251f04b
EZ
18322011-03-13 Eli Zaretskii <eliz@gnu.org>
1833
1834 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1835 $(EMACS_ROOT)/lib/intprops.h.
1836
f0c77cd1
PE
18372011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1838
3eca4629
PE
1839 Fix more problems found by GCC 4.5.2's static checks.
1840
7c86ee98
PE
1841 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1842 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1843 (xg_free_frame_widgets): Make it clear that a local variable is
1844 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1845 (gdk_window_get_screen): Make it clear that this macro is needed
1846 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1847 (int_gtk_range_get_value): New function, which avoids a diagnostic
1848 from gcc -Wbad-function-cast.
1849 (xg_set_toolkit_scroll_bar_thumb): Use it.
1850 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1851 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1852 (get_utf8_string, xg_get_file_with_chooser):
1853 Rename locals to avoid shadowing.
1854 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1855
41729b81
PE
1856 * xgselect.c (xg_select): Remove unused var.
1857
f0c77cd1
PE
1858 * image.c (four_corners_best): Mark locals as initialized.
1859 (gif_load): Initialize transparent_p to zero (Bug#8238).
1860 Mark another local as initialized.
ec6cf4c6 1861 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1862
ce0ad53d 1863 * image.c (clear_image_cache): Now static.
d5d5a617 1864 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1865 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1866 (x_edge_detection): Remove unnecessary cast that
1867 gcc -Wbad-function-cast diagnoses.
2037898d 1868 (gif_load): Fix pointer signedness.
6ae141d6
PE
1869 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1870 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1871
33383987 18722011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1873
d32df629
PE
1874 Improve quality of tests for time stamp overflow.
1875 For example, without this patch (encode-time 0 0 0 1 1
1876 1152921504606846976) returns the obviously-bogus value (-948597
1877 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1878 reports time overflow. See
1879 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1880 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1881 * editfns.c: Include limits.h and intprops.h.
1882 (TIME_T_MIN, TIME_T_MAX): New macros.
1883 (time_overflow): Move earlier, to before first use.
1884 (hi_time, lo_time): New functions, for an accurate test for
1885 out-of-range times.
1886 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1887 (Fget_internal_run_time): Don't assume time_t fits in int.
1888 (make_time): Use list2 instead of Fcons twice.
1889 (Fdecode_time): More accurate test for out-of-range times.
1890 (check_tm_member): New function.
1891 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1892 (lisp_time_argument): Don't rely on undefined left-shift and
1893 right-shift behavior when checking for time stamp overflow.
8be6f318 1894
fe31d94c
PE
1895 * editfns.c (time_overflow): New function, refactoring common code.
1896 (Fformat_time_string, Fdecode_time, Fencode_time):
1897 (Fcurrent_time_string): Use it.
1898
8be6f318
PE
1899 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1900 * dired.c (make_time): Move to ...
1901 * editfns.c (make_time): ... here.
1902 * systime.h: Note the move.
1903
09d9db2c 19042011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1905
126bc0dc
YM
1906 * fringe.c (update_window_fringes): Remove unused variables.
1907
c47cbdfd
YM
1908 * unexmacosx.c (copy_data_segment): Also copy __got section.
1909 (Bug#8223)
1910
7ac80be9
EZ
19112011-03-12 Eli Zaretskii <eliz@gnu.org>
1912
c96bbc66 1913 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1914 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1915 Constify `char *' arguments and their references according to
1916 prototypes in tparam.h.
1917
ecb0f94d 1918 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1919
7ac80be9
EZ
1920 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1921 Adapt all references accordingly.
1922
1923 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1924
ef1fd07e
TT
19252011-03-11 Tom Tromey <tromey@redhat.com>
1926
1927 * buffer.c (syms_of_buffer): Remove obsolete comment.
1928
7ef4b50c
EZ
19292011-03-11 Eli Zaretskii <eliz@gnu.org>
1930
1931 * termhooks.h (encode_terminal_code): Declare prototype.
1932
1933 * msdos.c (encode_terminal_code): Don't declare prototype.
1934
1935 * term.c (encode_terminal_code): Now external again, used by
1936 w32console.c and msdos.c.
1937
44f230aa
SM
1938 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1939 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1940
4b1ec863 19412011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1942
1714f52b 1943 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1944
4b1ec863
PE
1945 * fringe.c (update_window_fringes): Mark locals as initialized
1946 (Bug#8227).
1947 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1948
524c7aa6
PE
1949 * alloc.c (mark_fringe_data): Move decl from here ...
1950 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1951 to check its interface.
1952 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1953
a5c0af81 1954 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1955 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1956 (fontset_font): Mark local as initialized.
a9a06e0b 1957 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1958
b4716021
PE
1959 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1960
811e9bac 1961 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1962 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1963 (x_own_selection, Fx_disown_selection_internal): Rename locals
1964 to avoid shadowing.
1965 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1966
7e3ab302
PE
1967 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1968 so that the caller can use some name other than gcpro1.
1969 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1970 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1971 (Fx_backspace_delete_keys_p):
1972 Use them to avoid shadowing, and rename vars to avoid shadowing.
1973 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1974 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1975 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1976 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1977 Remove unused locals.
7e3ab302
PE
1978 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1979 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1980 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1981 macros.
f78faa98 1982
e2b13473
PE
1983 * xterm.h (x_mouse_leave): New decl.
1984
77f23912
PE
1985 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1986 Remove unused functions.
cdf4ba58
PE
1987 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1988 (x_calc_absolute_position): Now static.
7411c686 1989 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1990 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1991 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1992 unless they are used.
38d0b34a
PE
1993 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1994 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1995 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1996 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1997 (x_error_catcher, x_connection_closed, x_error_handler):
1998 (x_error_quitter, xembed_send_message, x_iconify_frame):
1999 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2000 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2001 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2002
44f230aa
SM
2003 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2004 Rename or move locals to avoid shadowing.
6b463e58 2005 (tty_defined_color, merge_face_heights): Now static.
5967d051 2006 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2007 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2008 does not deduce is never used uninitialized.
73719eba
PE
2009 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2010 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2011
426994c3 2012 * terminal.c (store_terminal_param): Now static.
5489860b 2013
032f1620 2014 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2015 (set_frame_menubar): Remove unused local.
d4323972 2016 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2017 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2018 since they might point to immutable storage.
281585b0
PE
2019 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2020 since it's unused otherwise.
032f1620 2021
367c19e5 2022 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2023 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2024 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2025 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2026 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2027 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2028 does not deduce are never used uninitialized.
70739cbe 2029
07b48fa9
PE
2030 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2031
8868a238 2032 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2033 * window.c (window_loop, size_window):
2034 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2035
7e5cf297 2036 * window.c (display_buffer): Now static.
d6550a9f
PE
2037 (size_window): Mark variables that gcc -Wuninitialized
2038 does not deduce are never used uninitialized.
a586633d
PE
2039 * window.h (check_all_windows): New decl, to forestall
2040 gcc -Wmissing-prototypes diagnostic.
5b555da1 2041 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2042
f6095868
PE
2043 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2044 shadowing.
2045 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2046 Include <limits.h>.
2047 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2048 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2049 (load_charset_map): Mark variables that gcc -Wuninitialized
2050 does not deduce are never used uninitialized.
53df7c11 2051 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2052
f38b440c
PE
2053 * coding.c (coding_set_source, coding_set_destination):
2054 Use "else { /* comment */ }" rather than "else /* comment */;"
2055 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2056 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2057 a block, when the outer 'i' will do.
2058 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2059 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2060 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2061 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2062 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2063 Rename locals to avoid shadowing.
2064 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2065 * coding.c (emacs_mule_char, encode_invocation_designation):
2066 Now static, since they're not used elsewhere.
413bb2db 2067 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2068 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2069 (decode_coding_emacs_mule): Mark variables that gcc
2070 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2071 (detect_coding_iso_2022): Initialize a local variable that might
2072 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2073 this initialization is needed. (Bug#8211)
5f58e762
PE
2074 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2075 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2076 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2077 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2078 Remove unused macros.
f38b440c 2079
232b38b9 2080 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2081 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2082 * character.c (string_count_byte8): Likewise.
232b38b9 2083
fb90da1b
PE
2084 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2085 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2086
fb93dbc2
PE
2087 * chartab.c (copy_sub_char_table): Now static, since it's not used
2088 elsewhere.
5c156ace
PE
2089 (sub_char_table_ref_and_range, char_table_ref_and_range):
2090 Rename locals to avoid shadowing.
bbcd0949 2091 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2092
7d3b3862 2093 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2094 (BIDI_BOB): Remove unused macro.
7d3b3862 2095
6be7d3da
PE
2096 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2097 deduce are never used uninitialized.
c2ed9c8b 2098 * term.c (encode_terminal_code): Likewise.
6be7d3da 2099
75f8807f 2100 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2101
50938595
PE
2102 * tparam.h: New file.
2103 * term.c, tparam.h: Include it.
2104 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2105 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2106 Move these decls to tparam.h, and make them agree with what
2107 is actually in tparam.c. The previous trick of using incompatible
2108 decls in different modules does not conform to the C standard.
2109 All callers of tparam changed to use tparam's actual API.
2110 * tparam.c (tparam1, tparam, tgoto):
2111 Use const pointers where appropriate.
2112
fbceeba2
PE
2113 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2114 * cm.h (struct cm): Likewise.
2115 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2116 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2117 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2118 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2119 (turn_on_face, init_tty): Likewise.
2120 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2121
7f3f1250
PE
2122 * term.c (term_mouse_position): Rename local to avoid shadowing.
2123
e6ca6543
PE
2124 * alloc.c (mark_ttys): Move decl from here ...
2125 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2126
c40f8d15
AS
21272011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2128
2129 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2130
cfe0661d
JB
21312011-03-09 Juanma Barranquero <lekktu@gmail.com>
2132
2133 * search.c (compile_pattern_1): Remove argument regp, unused since
2134 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2135 (compile_pattern): Don't pass it.
2136
0afb4571
J
21372011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2138
2139 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2140 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2141 for ! HAVE_GTK3.
2142 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2143
2144 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2145
2146 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2147 gdk_window_get_screen, gdk_window_get_geometry,
2148 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2149 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2150 (xg_get_pixbuf_from_pixmap): New function.
2151 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2152 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2153 Call xg_get_pixbuf_from_pixmap instead of
2154 gdk_pixbuf_get_from_drawable.
2155 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2156 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2157 (xg_check_special_colors): Use GtkStyleContext and its functions
2158 for HAVE_GTK3.
2159 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2160 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2161 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2162 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2163 Call gtk_widget_get_preferred_size.
0afb4571
J
2164 (xg_frame_resized): gdk_window_get_geometry only takes 5
2165 parameters.
44f230aa
SM
2166 (xg_win_to_widget, xg_event_is_for_menubar):
2167 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2168 (xg_set_widget_bg): New function.
2169 (delete_cb): New function.
2170 (xg_create_frame_widgets): connect delete-event to delete_cb.
2171 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2172 (xg_set_background_color): Call xg_set_widget_bg.
2173 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2174 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2175 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2176 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2177 if ! HAVE_GTK3.
2178 (update_frame_tool_bar): Call gtk_widget_hide.
2179 (xg_initialize): Use GDK_KEY_g.
2180
2181 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2182 if ! HAVE_GTK3
2183 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2184
2185 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2186 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2187 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2188
1c2cc4ef
JB
21892011-03-08 Juanma Barranquero <lekktu@gmail.com>
2190
2191 * w32xfns.c (select_palette): Check success of RealizePalette against
2192 GDI_ERROR, not zero.
2193
33383987 2194See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2195
2196;; Local Variables:
2197;; coding: utf-8
aac0c6e3
MR
2198;; End:
2199
33383987 2200 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2201
2202 This file is part of GNU Emacs.
2203
2204 GNU Emacs is free software: you can redistribute it and/or modify
2205 it under the terms of the GNU General Public License as published by
2206 the Free Software Foundation, either version 3 of the License, or
2207 (at your option) any later version.
2208
2209 GNU Emacs is distributed in the hope that it will be useful,
2210 but WITHOUT ANY WARRANTY; without even the implied warranty of
2211 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2212 GNU General Public License for more details.
2213
2214 You should have received a copy of the GNU General Public License
2215 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.