Fix bug #12082 with input of Meta-non-ASCII-characters on MS-Windows.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
302fc036
EZ
12012-07-30 Eli Zaretskii <eliz@gnu.org>
2
3 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
4 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
5
6 * w32term.c <w32_keyboard_codepage>: Renamed from
7 keyboard_codepage and now external. All users changed.
8
9 * w32term.h: Add declaration of w32_keyboard_codepage.
10
11 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
12 the codepage to translate keys to Unicode. If this argument is
13 -1, use the value returned by GetConsoleCP. All callers changed.
14
88fb40b4
PE
152012-07-30 Paul Eggert <eggert@cs.ucla.edu>
16
0aee6912
PE
17 Update .PHONY listings in makefiles.
18 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
19 bootstrap-clean, distclean, maintainer-clean, versioclean,
20 extraclean, frc.
21
88fb40b4
PE
22 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
23 This is a bit clearer. Fix some commentary typos.
24
0a763bd1
GM
252012-07-30 Glenn Morris <rgm@gnu.org>
26
32bac6d6
GM
27 * s/netbsd.h: Let configure include signal.h if needed.
28 Remove file, which is now empty.
29
b65e7c46
GM
30 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
31 Let configure set them.
32 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
33 No more need to undefine.
0a763bd1 34
169304bd
AS
352012-07-30 Andreas Schwab <schwab@linux-m68k.org>
36
37 * keymap.c (Fkey_description): Don't remove 0x80 bit from
38 non-single-byte char when adding meta modifier. (Bug#12090)
39
6cd7a139
DA
402012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
41
42 Convert safe_call to use variable number of arguments.
43 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
44 (safe_call2): Fix comment.
45 * lisp.h (safe_call): Adjust prototype.
46 * coding.c (encode_coding_object): Change to use safe_call2.
47 * xfaces.c (merge_face_heights): Change to use safe_call1.
48
d34d6ffc
GM
492012-07-30 Glenn Morris <rgm@gnu.org>
50
7b8a48e4 51 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 52 does that unconditionally. Remove file, which is now empty.
7b8a48e4 53
d34d6ffc
GM
54 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
55 Remove empty files.
56
03a660a6
PE
572012-07-30 Paul Eggert <eggert@cs.ucla.edu>
58
59 Export to GDB most of lisp.h's remaining object-like macros.
60 * lisp.h (min, max): Move earlier, because they're used earlier now.
61 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
62 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
63 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
64 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
65 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
66 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
67 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
68 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
69 Now constants, for GDB. They need not be macros.
70 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
71 Now constants, for GDB, as well as macros, for static initializers.
72 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
73 Move to after the definition of struct Lisp_Char_Table,
74 since the former now needs that type defined.
75 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
76 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
77 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
78 New enums, for gdb_make_enums_visible.
79 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 80 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
81 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
82 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
83 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
84 enum maxargs, enum MAX_ALLOCA.
85 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
86 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
87 no longer needed, now that they are done in lisp.h.
88
e499d0ee
DA
892012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
90
91 Cleanup string bytes checking.
92 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
93 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
94 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
95 (check_sblock, compact_small_strings): Simplify.
96
d5040d2d
PE
972012-07-29 Paul Eggert <eggert@cs.ucla.edu>
98
99 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
100 These macros are confusing and no longer need to be defined, as
101 the enum values now suffice. All uses replaced with definiens.
102 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
103
7f259ae6
JB
1042012-07-29 Juanma Barranquero <lekktu@gmail.com>
105
106 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
107 ($(BLD)/w32console.$(O)): Update dependencies.
108
7e63e0c3
DA
1092012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
110
111 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
112 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
113 time. Adjust users.
114 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
115
ffd817eb
JD
1162012-07-29 Jan Djärv <jan.h.d@swipnet.se>
117
118 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
119 setting sitelisp (Bug#12010).
120
417a7a0e
EZ
1212012-07-29 Eli Zaretskii <eliz@gnu.org>
122
123 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
124
125 * w32heap.c (cache_system_info):
126 * w32.c (sys_rename):
127 * w32proc.c (find_child_console, sys_kill): All users changed.
128
387d4d92
PE
1292012-07-29 Paul Eggert <eggert@cs.ucla.edu>
130
131 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
132
55a6cca6
EZ
1332012-07-29 Eli Zaretskii <eliz@gnu.org>
134
135 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
136
dbcf001c
DA
1372012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
138
139 Cleanup statistics calculation in Fgarbage_collect.
140 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
141 zombies percentage calculation. Simplify elapsed time calculation.
142
e2688e4a
DA
1432012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
144
145 Generalize marker debugging code under MARKER_DEBUG and use eassert.
146 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
147 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
148 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
149 (replace_range, replace_range_2, del_range_2): Change to eassert.
150 * marker.c (byte_char_debug_check): Adjust style.
151
b46a6a83
PE
1522012-07-29 Paul Eggert <eggert@cs.ucla.edu>
153
154 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
155 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
156 long-ago-commented-out code that talks about "WIN32".
157 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
158 All uses changed.
159
e32a5799
PE
1602012-07-28 Paul Eggert <eggert@cs.ucla.edu>
161
162 Use Gnulib stdalign module (Bug#9772, Bug#9960).
163 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
164 Simplify by using alignof.
165 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
166 * lisp.h: Include <stdalign.h>.
167 (GCALIGNMENT): New macro and constant.
168 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
169 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
170 (stdalign): New macro, if not already defined.
171
df81cd29
EZ
1722012-07-28 Eli Zaretskii <eliz@gnu.org>
173
01bd1b0d
EZ
174 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
175 * w32inevt.c: Include w32inevt.h.
176 (w32_read_console_input): New inline function, calls either
177 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
178 w32_console_unicode_input.
179 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
180 (w32_kbd_patch_key, key_event): Use the codepage returned by
181 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
182 (key_event): use uChar.UnicodeChar only if
183 w32_console_unicode_input is non-zero.
184
185 * w32console.c: Include w32heap.h.
186 <w32_console_unicode_input>: New global variable.
187 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
188 family of Windows, zero otherwise.
189
190 * w32inevt.h: Declare w32_console_unicode_input.
191
df81cd29
EZ
192 * xdisp.c (init_iterator): Don't reference tip_frame in a build
193 --without-x. (Bug#11742)
194
c20fdd9e
PE
1952012-07-27 Paul Eggert <eggert@cs.ucla.edu>
196
197 Adjust GDB to reflect pvec_type changes (Bug#12036).
198 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
199 2012-07-04 changes to pseudovector representation. Problem
200 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
201
32770973 2022012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
203
204 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
205 bus address.
206 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
207
3438fe21
EZ
2082012-07-27 Eli Zaretskii <eliz@gnu.org>
209
bcfbc9de
EZ
210 * alloc.c (listn): Fix the order the arguments are consed onto the
211 list.
212
3438fe21
EZ
213 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
214 enumeration constants, as PURE and HEAP are too general, and clash
215 with other headers and sources, such as gmalloc.c and the
216 MS-Windows system headers. All users changed.
217
eeaea515
DA
2182012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
219
220 Revert last save_excursion_save and save_excursion_restore changes.
221 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
222 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
223
073c88c2
DA
2242012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
225
226 Fix recently-introduced typos in Windows port.
227 Reported by Martin Rudalics <rudalics@gmx.at>.
228 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 229 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 230
4706125e
PE
2312012-07-27 Paul Eggert <eggert@cs.ucla.edu>
232
233 Improve GDB symbol export (Bug#12036).
234 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
235 arms of an 'if', not using conditional expressions; otherwise GDB
236 complains about the types in the unevaluated arm when the argument
237 is an integer literal.
238 (xgetint): Simplify expression.
239 * alloc.c (gdb_make_enums_visible): New constant. This ports to
240 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
241 Zaretskii in <http://bugs.gnu.org/12036#13>.
242 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
243 needed now that we have gdb_make_enums_visible.
244 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
245 (enum enum_USE_LSB_TAG):
246 New enum types, packaging up enums that need to be exported to GDB.
247
694b6c97
DA
2482012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
249
250 Utility function to make a list from specified amount of objects.
251 * lisp.h (enum constype): New datatype.
252 (listn): New prototype.
253 * alloc.c (listn): New function.
254 (Fmemory_use_count, syms_of_alloc): Use it.
255 * buffer.c (syms_of_buffer): Likewise.
256 * callint.c (syms_of_callint): Likewise.
257 * charset.c (define_charset_internal): Likewise.
258 * coding.c (syms_of_coding): Likewise.
259 * keymap.c (syms_of_keymap): Likewise.
260 * search.c (syms_of_search): Likewise.
261 * syntax.c (syms_of_syntax): Likewise.
262 * w32.c (init_environment): Likewise.
263 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
264 * xdisp.c (syms_of_xdisp): Likewise.
265 * xfns.c (syms_of_xfns): Likewise.
266
6195f384
DA
2672012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
268
269 Fast save_excursion_save and save_excursion_restore.
270 * lisp.h (struct Lisp_Excursion): New data type.
271 (PVEC_EXCURSION): New pseudovector type.
272 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
273 to deal with it. Adjust comments.
274 (init_marker, attach_marker): New prototype.
275 (unchain_marker): Adjust prototype.
276 * marker.c (attach_marker): Change to global.
277 (init_marker): New function.
278 * alloc.c (Fmake_marker, build_marker): Use it.
279 (build_marker): More easserts.
280 (mark_object): Handle struct Lisp_Excursion.
281 * editfns.c (save_excursion_save, save_excursion_restore):
282 Reimplement to use struct Lisp_Excursion. Add comments.
283
5eceb8fb
PE
2842012-07-26 Paul Eggert <eggert@cs.ucla.edu>
285
286 Fix export of symbols to GDB (Bug#12036).
287 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
288 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
289 emacs.c, as this is a more-suitable home. Had this been done earlier
290 the fix for 12036 would have avoided some of the problems noted in
291 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
292 would have been more obvious.
562157c8
PE
293 * emacs.c: Do not include <verify.h>; no longer needed.
294 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
295 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
296 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
297 Remove; now done in lisp.h.
298 * lisp.h (PUBLISH_TO_GDB): New macro.
299 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
300 (DATA_SEG_BITS): Use it.
301 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
302 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
303 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
304 not be usable in #if. This simplifies things.
305
d6749401
JB
3062012-07-26 Juanma Barranquero <lekktu@gmail.com>
307
308 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
309
1781b9e9
PE
3102012-07-26 Paul Eggert <eggert@cs.ucla.edu>
311
d89518db 312 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
313 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
314 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
315 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
316 Adjust to changes in lisp.h and emacs.c, by using
317 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
318 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
319 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
320 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
321 instead of gdb_valbits.
322 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
323 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
324 instead of gdb_array_mark_flag.
325 (xboolvector): Get size from $->size, not $->header.size.
326 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
327 (xreload, hook-run, hookpost-run): Remove.
328 * emacs.c: Include <verify.h>.
329 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
330 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
331 Remove.
332 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
333 (gdb_USE_LSB_TAG): New enum constants.
334 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
335 Also define these as enum constants, so they're visible to GDB.
336 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
337 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
338 as constants, so they're visible to GDB.
339 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
340 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
341 Now enum constants, not macros, so they're visible to GDB.
342 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
343 more convenient now. All uses changed.
344 (VALMASK) [USE_LSB_TAG]: Also define in this case.
345 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
346
3628596a
DA
3472012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
348
349 Explicitly free restriction data that are not needed anymore.
350 * editfns.c (save_restriction_restore): Free restriction data.
351
7abaf5cc
SM
3522012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
353
354 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
355 add argument, tune behavior, and adjust all callers.
356
71f88e00
PE
3572012-07-25 Paul Eggert <eggert@cs.ucla.edu>
358
359 Use typedef for EMACS_INT, EMACS_UINT.
360 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
361 than macros. This simplifies debugging in the usual case, since
362 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
363 and it allows expressions involving EMACS_INT casts.
364 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
365
57ec3034
JD
3662012-07-25 Jan Djärv <jan.h.d@swipnet.se>
367
368 * nsterm.m (ns_read_socket): Return early if there is a modal
369 window (Bug#12043).
370
8137e7b3
MR
3712012-07-25 Martin Rudalics <rudalics@gmx.at>
372
373 * frame.c (Fredirect_frame_focus): In doc-string don't mention
374 that FOCUS-FRAME can be omitted.
375
04e9897c
DA
3762012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
377
378 Adjust buffer text indirection counters at the end of Fkill_buffer.
379 * buffer.c (Fkill_buffer): Adjust indirection counters when the
380 buffer is definitely dead. This should really fix an issue reported
381 by Christoph Scholtes again. (Bug#12007).
382 (init_buffer_once): Initialize indirection counters of
383 buffer_defaults and buffer_local_symbols (for sanity and safety).
384
8a0484e1
EZ
3852012-07-24 Eli Zaretskii <eliz@gnu.org>
386
387 * xdisp.c (init_iterator): Don't compute dimensions of truncation
388 and continuation glyphs on tooltip frames, leave them at zero.
389 Avoids continued lines in tooltips. (Bug#11832)
390
fa691a83
DA
3912012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
392
393 Simplify copy_overlay.
04e9897c 394 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
395 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
396
436bc8e0
EZ
3972012-07-23 Eli Zaretskii <eliz@gnu.org>
398
399 * print.c (print_object): Don't crash when a frame's name is nil
400 or invalid. (Bug#12025)
401
402 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
403 it signals an error when a tooltip frame is being created.
404
d7a7fda3
DA
4052012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
406
407 Cleanup miscellaneous objects allocation and initialization.
408 * alloc.c (allocate_misc): Change to static. Add argument to
409 specify the subtype. Adjust comment and users.
410 (build_overlay): New function.
411 * buffer.c (copy_overlays, Fmake_overlay): Use it.
412 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
413 (allocate_misc): Remove prototype.
414 (build_overlay): Add prototype.
415
4162012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
417
418 Swap buffer text indirection counters in Fbuffer_swap_text.
419 * buffer.c (Fbuffer_swap_text): Swap indirections too.
420 This avoids crash reported by Christoph Scholtes at
421 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
422
9d7fa573
JD
4232012-07-22 Jan Djärv <jan.h.d@swipnet.se>
424
425 * nsmenu.m (Popdown_data): New struct.
426 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
427 free Popdown_data.
428 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
429 (initWithContentRect): Make imgView and contentView non-static
430 and autorelease them. Also autorelease img and matrix (Bug#12005).
431 (dealloc): Remove (Bug#12005).
432
0dd6d66d
DA
4332012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
434
435 Adjust consing_since_gc when objects are explicitly freed.
436 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
437 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
438 (free_cons, free_misc): Subtract object size from consing_since_gc.
439
d36d71df
DA
4402012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
441
442 Simplify and cleanup markers positioning code.
443 * marker.c (attach_marker): More useful eassert.
444 (live_buffer, set_marker_internal): New function.
445 (Fset_marker, set_marker_restricted): Use set_marker_internal.
446 (set_marker_both, set_marker_restricted_both): Use live_buffer.
447
fb9ea40f
PE
4482012-07-22 Paul Eggert <eggert@cs.ucla.edu>
449
450 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
451 as it's limited by the amount of memory, not by INT_MAX.
452
2d5c5f7d
EZ
4532012-07-21 Eli Zaretskii <eliz@gnu.org>
454
07fb592e
EZ
455 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
456 in special-event-map. See the discussion at
457 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
458 for the reasons.
459
37a9eac8 460 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
461 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
462 Fabrice Popineau <fabrice.popineau@supelec.fr>.
463
c4328746
JD
4642012-07-21 Jan Djärv <jan.h.d@swipnet.se>
465
466 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 467 (conversationIdentifier): Return value is NSInteger.
784051c4 468 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 469
6e5d1c12
CY
4702012-07-21 Chong Yidong <cyd@gnu.org>
471
472 * window.c (decode_any_window): Signal an error if the window is
473 on a dead frame (Bug#11984).
474
9928463d
DA
4752012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
476
477 Add indirection counting to speed up Fkill_buffer.
478 * buffer.h (struct buffer): New member.
479 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
480 (Fmake_indirect_buffer): Set indirection counter to -1, increment
481 base buffer indirection counter.
482 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
483 (Fkill_buffer): Adjust indirection counters as needed, don't walk
484 through buffer list if indirection counter is 0.
485
f8643a6b
DA
4862012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
487
488 Extend the value returned by Fgarbage_collect with heap statistics.
489 * alloc.c (Qheap): New symbol.
490 (syms_of_alloc): DEFSYM it.
491 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
492 (Fmemory_free): Remove.
493 (syms_of_alloc): Don't defsubr it.
494 * buffer.c (Fcompact_buffer): Remove.
495 (syms_of_buffer): Don't defsubr it.
496
dac616ff
DA
4972012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
498
499 Make maybe_gc inline.
500 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
501 * lisp.h (consing_since_gc, gc_relative_threshold)
502 (memory_full_cons_threshold): Revert declaration.
503 (maybe_gc): Remove prototype, define as inline.
504 * alloc.c: Remove old commented-out code.
505 (consing_since_gc, gc_relative_threshold)
506 (memory_full_cons_threshold): Revert to global.
507 (maybe_gc): Remove.
508
d7ea76b4
DA
5092012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
510
511 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
512 * lisp.h (build_unibyte_string): New function.
513 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
514 * sysdep.c, w32fns.c, xfns.c: Use it.
515 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
516 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
517 Adjust users accordingly.
518 * font.h (font_open_by_name): Adjust prototype.
519
765e61e3
DA
5202012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
521
522 Cleanup calls to Fgarbage_collect.
523 * lisp.h (maybe_gc): New prototype.
524 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
525 Remove declarations.
526 * alloc.c (maybe_gc): New function.
527 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
528 Make them static.
529 * bytecode.c (MAYBE_GC): Use maybe_gc.
530 * eval.c (eval_sub, Ffuncall): Likewise.
531 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
532 to avoid dependency from auto-save feature.
533
52b852c7
PE
5342012-07-19 Paul Eggert <eggert@cs.ucla.edu>
535
536 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
537 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
538 'for_each_per_buffer_object_at'.
539 All uses changed. It's better to use upper-case for macros that
540 cannot be implemented as functions, to give the reader a clue
541 that they're special.
542
5db81e33
SM
5432012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
544
545 * alloc.c (Fgarbage_collect): Tweak docstring.
546
5b835e1d
DA
5472012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
548
549 Tweak the value returned from Fgarbage_collect again.
550 * alloc.c (Fgarbage_collect): New return value, as confirmed in
551 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
552 Adjust documentation.
553 (total_vector_bytes): Rename to total_vector_slots, adjust
554 accounting.
555 (total_free_vector_bytes): Rename to total_free_vector_slots,
556 adjust accounting.
557 (Qstring_bytes, Qvector_slots): New symbols.
558 (syms_of_alloc): DEFSYM them.
559
9cd47b72
DA
5602012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
561
562 Buffer compaction primitive which may be used from Lisp.
563 * buffer.c (compact_buffer, Fcompact_buffer): New function.
564 (syms_of_buffer): Register Fcompact_buffer.
565 * alloc.c (Fgarbage_collect): Use compact_buffer.
566 * buffer.h (compact_buffer): New prototype.
567 (struct buffer_text): New member.
568
d17337e5
DA
5692012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
570
571 New macro to iterate over all buffers, miscellaneous cleanups.
572 * lisp.h (all_buffers): Remove declaration.
573 * buffer.h (all_buffers): Add declaration, with comment.
574 (for_each_buffer): New macro.
575 * alloc.c (Fgarbage_collect, mark_object): Use it.
576 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
577 (init_buffer): Likewise.
578 * data.c (Fset_default): Likewise.
579 * coding.c (code_conversion_restore): Remove redundant check
580 for dead buffer.
581 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
582
60cfd278
AS
5832012-07-18 Andreas Schwab <schwab@linux-m68k.org>
584
585 Fix bug that created negative-length intervals.
586 * intervals.c (merge_interval_right, merge_interval_left):
587 Do not zero out this interval if it is absorbed by its children,
588 as this interval's total length doesn't change in that case. See
589 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
590
d06714cb
PE
5912012-07-18 Paul Eggert <eggert@cs.ucla.edu>
592
83713154
PE
593 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
594 when invoking (make-bool-vector N t) and N is a positive
595 multiple of 8 -- the last 8 bits were mistakenly cleared.
596
d06714cb
PE
597 Remove some struct layout assumptions in bool vectors.
598 * alloc.c (bool_header_size): New constant.
599 (header_size, word_size): Move earlier, as they're now used earlier.
600 Use 'word_size' in a few more places, where it's appropriate.
601 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
602 padding before the data member of a bool vector.
603 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
604 than doing the check by hand with an abort ().
605
464d5a5e
SM
6062012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
607
5fbc0409
SM
608 * eval.c (Fdefvar): Don't check constants since we only set the var if
609 it's not yet defined anyway (bug#11904).
610
464d5a5e
SM
611 * lisp.h (last_undo_boundary): Declare new var.
612 * keyboard.c (command_loop_1): Set it.
613 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
614 were auto-added by the command loop (bug#11774).
615
8dc2e44a
AS
6162012-07-18 Andreas Schwab <schwab@linux-m68k.org>
617
618 * w32font.c (Qsymbol): Remove local definition.
619 (syms_of_w32font): Don't DEFSYM it.
620
169925ec
DA
6212012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
622
623 Fix sweep_vectors to handle large bool vectors correctly.
624 * alloc.c (sweep_vectors): Account total_vector_bytes for
625 bool vectors larger than VBLOCK_BYTES_MAX.
626
5fbfb018
CY
6272012-07-18 Chong Yidong <cyd@gnu.org>
628
629 * frame.c (x_set_frame_parameters): Revert bogus change introduced
630 in 2012-05-25 commit by Paul Eggert (Bug#11738).
631
3ab6e069
DA
6322012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
633
634 Return more descriptive data from Fgarbage_collect.
635 Suggested by Stefan Monnier in
636 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
637 * alloc.c (bounded_number): New function.
638 (total_buffers, total_vectors): New variable.
639 (total_string_size): Rename to total_string_bytes, adjust users.
640 (total_vector_size): Rename to total_vector_bytes, adjust users.
641 (sweep_vectors): Account total_vectors and total_vector_bytes.
642 (Fgarbage_collect): New return value. Adjust documentation.
643 (gc_sweep): Account total_buffers.
644 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
645 (VECTOR_SIZE): Remove.
646 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
647 (Qinterval, Qmisc): New symbols.
648 (syms_of_data): Initialize them.
649 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
650 (Qcons, Qbuffer): New declarations.
651
6d02fe5b
PE
6522012-07-17 Paul Eggert <eggert@cs.ucla.edu>
653
654 * alloc.c (Fmemory_free): Account for memory-free's own storage.
655 Round up, not down. Improve doc.
656
b7ffe040
DA
6572012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
658
659 Restore old code in allocate_string_data to avoid Faset breakage.
660 Reported by Julien Danjou <julien@danjou.info> in
661 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
662 * alloc.c (allocate_string_data): Restore old code with minor
663 adjustments, fix comment to explain this subtle issue.
664
4dc7c8d5
SM
6652012-07-17 Eli Zaretskii <eliz@gnu.org>
666
667 Remove FILE_SYSTEM_CASE.
668 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
669
670 * fileio.c (FILE_SYSTEM_CASE): Don't define.
671 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
672 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
673 call-process-region passes it through expand-file-name.
674
675 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
676
6772012-07-17 Andreas Schwab <schwab@linux-m68k.org>
678
679 Fix crash when creating indirect buffer (Bug#11917)
680 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
681 Don't handle unbound variables specially if non-zero.
682 (Fbuffer_local_variables): Pass zero.
683 (clone_per_buffer_values): Pass non-zero.
684
6852012-07-17 Andreas Schwab <schwab@linux-m68k.org>
686
687 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
688 to make the loop interruptible.
689
6902012-07-17 Andreas Schwab <schwab@linux-m68k.org>
691
692 * gnutls.c (emacs_gnutls_handshake): Only retry if
693 GNUTLS_E_INTERRUPTED.
694
cce7fefc
DA
6952012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
696
697 Cleanup and convert miscellaneous checks to eassert.
698 * alloc.c (mark_interval): Fix comment, partially rephrase
699 old comment from intervals.h (see below).
700 * intervals.c (find_interval, adjust_intervals_for_insertion)
701 (delete_interval, adjust_intervals_for_deletion)
702 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
703 Convert to eassert.
704 (adjust_intervals_for_insertion, make_new_interval):
705 Remove obsolete and unused code.
706 * intervals.h (struct interval): Remove obsolete comment.
707 * textprotp.c (erase_properties): Remove unused code.
708 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
709 (Fremove_list_of_text_properties): Convert to eassert.
710
9ea10cc3
CY
7112012-07-17 Chong Yidong <cyd@gnu.org>
712
713 * editfns.c (Finsert_char): Doc fix.
714
3900d5de
DA
7152012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
716
717 Fix previous change to make Fmemory_free always accurate.
718 * alloc.c (make_interval): Update total_free_intervals.
719 (make_float): Likewise for total_free_floats.
720 (free_cons, Fcons): Likewise for total_free_conses.
721 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
722 Likewise for total_free_vector_bytes.
723 (Fmake_symbol): Likewise for total_free_symbols.
724 (bytes_free): Remove.
725
7098646f
DA
7262012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
727
728 Simple free memory accounting feature.
729 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
730 (sweep_vectors): Accumulate size of free vectors.
731 (Fgarbage_collect): Setup bytes_free.
732 (Fmemory_free): New function.
733 (syms_of_alloc): Register it.
734
22657b40
DA
7352012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
736
737 Cleanup overlays checking.
738 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
739 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
740 eassert and OVERLAYP.
741 (sort_overlays): Change to use OVERLAYP.
742
ddfc8813
RK
7432012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
744
745 * editfns.c (Finsert_char): Make it interactive, and make the
746 second arg optional. Copy interactive spec and docstring from
747 ucs-insert.
748
7c26cf3c
PE
7492012-07-17 Paul Eggert <eggert@cs.ucla.edu>
750
751 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
752 Unlike the other wrapped functions, fabs has an unspecified
753 effect on errno.
754
5d127af9
JD
7552012-07-16 Jan Djärv <jan.h.d@swipnet.se>
756
757 * nsterm.m (keyDown): Interpret flags without left/right bits
758 as the left key (Bug#11670).
759
6a0dd1d7
DA
7602012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
761
762 Remove empty and useless init functions.
763 * lisp.h (init_character_once, init_fns, init_image)
764 (init_filelock, init_sound): Remove prototype.
765 * character.c (init_character_once): Remove.
766 * filelock.c (init_filelock): Likewise.
767 * fns.c (init_fns): Likewise.
768 * image.c (init_image): Likewise.
769 * sound.c (init_sound): Likewise.
770 * emacs.c (main): Adjust accordingly.
771
7a6136fd
DA
7722012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
773
774 * gtkutil.h: Tiny cleanups.
775 (use_old_gtk_file_dialog): Remove useless declaration.
776 (xg_uses_old_file_dialog): Add suggested const attribute.
777
ce811ad9
EZ
7782012-07-15 Eli Zaretskii <eliz@gnu.org>
779
780 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
781 (bidi_paragraph_init): Use it to limit search forward for a strong
782 directional character in abnormally large paragraphs full of
783 neutral or weak characters. (Bug#11943)
784
c9adfeaa
SF
7852012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
786
787 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
788 the toolbar (Bug#9451).
789 (xg_make_tool_item): Give the widget event box a transparent
790 background.
791
fff62aa9
DA
7922012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
793
794 Cleanup basic allocation variables and functions.
795 * alloc.c (ignore_warnings, init_intervals, init_float)
796 (init_cons, init_symbol, init_marker): Remove.
797 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
798 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
799 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
800 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
801 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
802 (staticidx, init_alloc_once, init_strings, free_ablock):
803 Remove redundant initialization.
804 * fns.c (init_weak_hash_tables): Remove.
805 * lisp.h (init_weak_hash_tables): Remove prototype.
806
9730daca
DA
8072012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
808
809 Use zero_vector where appropriate.
810 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
811 accordingly.
812 * lisp.h (zero_vector): New declaration.
813 * font.c (null_vector): Remove.
814 (syms_of_font): Remove initialization and staticpro.
815 (font_list_entities, font_find_for_lface): Change to use zero_vector.
816 * keymap.c (Faccessible_keymaps): Likewise.
817
2e2d2a13
LL
8182012-07-15 Leo Liu <sdl.web@gmail.com>
819
820 * fringe.c: Fix typo in comments.
821
cd276f6e
LL
8222012-07-14 Leo Liu <sdl.web@gmail.com>
823
824 * fringe.c: Add a new bitmap exclamation-mark.
825
5a1131d9
EZ
8262012-07-14 Eli Zaretskii <eliz@gnu.org>
827
828 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
829
830 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
831 (HAVE_MENUS): Don't define, defined by editing config.in with
832 msdos/sed2v2.inp.
833 (GMALLOC_INHIBIT_VALLOC): Don't define.
834 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
835
22e983b7
JB
8362012-07-14 Juanma Barranquero <lekktu@gmail.com>
837
838 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
839
5b3f250f
GM
8402012-07-14 Glenn Morris <rgm@gnu.org>
841
842 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
843 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
844 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
845
33d63ff4
GM
8462012-07-13 Glenn Morris <rgm@gnu.org>
847
5b633342
GM
848 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
849
33d63ff4
GM
850 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
851 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
852
b55b9f85
JD
8532012-07-13 Jan Djärv <jan.h.d@swipnet.se>
854
0dc8cf50
JD
855 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
856 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
857 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
858 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
859 where appropriate.
860 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
861 as boolean expression.
862 (x_set_window_size): Remove unused variable toolbar.
863 (ns_get_color_default, ns_mod_to_lisp): Remove.
864 (ns_mouse_position): Remove unused variables xchar and ychar.
865 (ns_compute_glyph_string_overhangs): Remove unused variable face.
866 (ns_set_vertical_scroll_bar): Remove unused variable count.
867 (ns_delete_terminal): Remove unused variable i.
868 (ns_term_init): Remove unused variables r, g and b.
869 (mouseDown): Remove unused variable window.
870 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
871 (initFrameFromEmacs): Remove unused variable vbextra.
872 (mouseEntered): Remove unused variables p and dpyinfo.
873 (mouseExited): Remove unused variables p and r.
874 (ns_define_frame_cursor, ns_clear_frame_area)
875 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
876 (menuDown): Assign [sender tag] to variable and cast the variable.
877
878 * nsterm.h (menuDown): Add id as type to argument sender.
879 (ns_display_info_for_name): Add Lisp_Object argument.
880 (ns_term_init): Add Lisp_Object argument.
881 (ns_map_event_to_object): Add void argument.
882 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
883 prototype with arguments and only declare if __OBJC__.
884 (nxatoms_of_nsselect): Add void argument.
885 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
886 (ns_alloc_autorelease_pool): Add void argument.
887 (ns_release_autorelease_pool): Add void* argument.
888 (ns_get_defaults_value): Add const char* argument.
889
890 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
891 (initFromContents): Use SSDATA where appropriate.
892 (ns_update_menubar): Add braces to ambigous if-else.
893 (initWithTitle): Put () around assignment in if statement.
894 (ns_menu_show): Remove unused variables window and keymap.
895 (update_frame_tool_bar): Remove unused variable selected_p.
896 (initWithContentRect): Remove unused variable this_cmd_name.
897
898 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
899 appropriate.
900 (setXBMColor): Remove unused variable len.
901 (setPixmapData): Put () around assignment in loop statement.
902
903 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
904 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
905 where appropriate.
906 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
907 around assignment in loop statement.
908 (nsfont_open): Remove unused variable i.
909 (nsfont_open): Remove unused variable len.
910 (nsfont_draw): Remove unused variable cs.
911
912 * nsfns.m (x_set_icon_name, ns_set_name_internal)
913 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
914 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
915 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
916 (Fns_font_name, Fns_perform_service)
917 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
918 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
919 (ns_set_name): Remove unused variable view.
920 (x_set_menu_bar_lines): Remove unused variable olines.
921 (x_set_tool_bar_lines): Remove unused variable root_window.
922 (Fns_list_colors): Put () around assignment in while statement.
923 (Fns_perform_service): Remove unused variable len.
924 (Fns_display_usable_bounds): Remove unused variable top.
925 (syms_of_nsfns): Remove unused variable i.
926
b55b9f85
JD
927 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
928 memcpy (Bug#11907).
929
ed9265fc 9302012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
931
932 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
933 and free it with DestroyExceptionInfo (Bug#11558).
934
ef099b57
JB
9352012-07-13 Juanma Barranquero <lekktu@gmail.com>
936
937 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
938 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
939 Set here, not in nt/config.nt.
940
ea814a5d
EZ
9412012-07-13 Eli Zaretskii <eliz@gnu.org>
942
943 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
944 cursor overflow into the last glyph on display line when the right
945 fringe is off. (Bug#11832)
946
1a952767
PE
9472012-07-13 Paul Eggert <eggert@cs.ucla.edu>
948
949 * xdisp.c (produce_special_glyphs): Now static.
950 * dispextern.h (produce_special_glyphs): Remove decl.
951
983188fd
GM
9522012-07-13 Glenn Morris <rgm@gnu.org>
953
32fb4bb6
GM
954 * s/bsd-common, s/cygwin.h: Remove empty files.
955 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
956
983188fd
GM
957 * s/usg5-4-common.h (USG, USG5):
958 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
959 * s/sol2-6.h (SOLARIS2):
960 * s/irix6-5.h (IRIX6_5):
961 * s/hpux10-20.h (USG, USG5, HPUX):
962 * s/gnu-linux.h (USG, GNU_LINUX):
963 * s/freebsd.h (BSD_SYSTEM):
964 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
965 * s/cygwin.h (CYGWIN):
966 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
967 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
968
d1e68667 9692012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
970
971 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 972
6de0e799
GM
9732012-07-13 Glenn Morris <rgm@gnu.org>
974
739ae010
GM
975 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
976
dbee5793
GM
977 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
978
6de0e799
GM
979 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
980 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
981
b82da769
GM
9822012-07-12 Glenn Morris <rgm@gnu.org>
983
4fae5a7a 984 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
985
986 * process.c (init_process_emacs): Rename from init_process.
987 The old name is also the name of a Mach system call.
988 * lisp.h, emacs.c: Update for this name change.
989 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
990 longer needed.
991
5a979817
EZ
9922012-07-12 Eli Zaretskii <eliz@gnu.org>
993
994 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
995 memmove call that removes glyphs covered by the left truncation
996 glyph. Improve commentary.
997 (display_line): Fix display of continuation glyphs on GUI frames
998 when the right fringe is turned off and variable-size fonts are
999 used in the window. Move the code that appends a stretch glyph to
1000 produce_special_glyphs, so that it could be used for truncation
1001 and continuation glyphs alike.
1002 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1003 glyph of a suitably computed width, to align the special glyphs at
1004 the window margin. Code moved from display_line. (Bug#11832)
1005
3e91a053
GM
10062012-07-12 Glenn Morris <rgm@gnu.org>
1007
ba9e4b84
GM
1008 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1009
1010 * s/gnu-linux.h, s/hpux10-20.h:
1011 Do not unconditionally define HAVE_XRMSETDATABASE.
1012
3e91a053
GM
1013 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1014
b300b1f4
PE
10152012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 Fix typos that broke OS X build.
1018 Reported by Randal L. Schwartz in
1019 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1020 * nsterm.m (ns_timeout): Add missing local decl.
1021 (ns_get_color): snprintf -> sprintf, to fix typo.
1022
6e777848
GM
10232012-07-12 Glenn Morris <rgm@gnu.org>
1024
3f922c37
GM
1025 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1026 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1027 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1028 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1029
0ab7b23a
GM
1030 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1031 Move PTY_OPEN to configure.
1032
6e777848
GM
1033 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1034 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1035 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1036
4a7edc24
DA
10372012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1038
1039 Use empty_unibyte_string where applicable.
1040 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1041 * lread.c (read1): Likewise.
1042 * xsettings.c (syms_of_xsettings): Likewise.
1043
308aab79
GM
10442012-07-12 Glenn Morris <rgm@gnu.org>
1045
42bd1719
GM
1046 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1047 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1048 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1049 * s/hpux10-20.h (RUN_TIME_REMAP):
1050 * s/bsd-common.h (TABDLY): Move to configure.
1051
1052 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1053
1054 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1055
ea0bbd17 1056 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1057 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1058
1059 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1060
308aab79
GM
1061 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1062 * s/template.h: Move NARROWPROTO to configure.
1063
ee1cf5cf
GM
10642012-07-11 Glenn Morris <rgm@gnu.org>
1065
30fe9bf4
GM
1066 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1067 unused since 2011-01-17 change to systty.h.
1068
ee1cf5cf
GM
1069 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1070 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1071 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1072
63e47e07
PE
10732012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1074
1075 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1076
c43fb4c3
GM
10772012-07-11 Glenn Morris <rgm@gnu.org>
1078
1079 * s/darwin.h, s/gnu-linux.h, s/template.h:
1080 Move INTERRUPT_INPUT to configure.
1081
e8df9267
DA
10822012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1083
1084 Minor adjustments to interning code.
1085 * lisp.h (intern, intern_c_string): Redefine as static inline
1086 wrappers for intern_1 and intern_c_string_1, respectively.
1087 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1088 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1089 Vobarray checking.
e8df9267
DA
1090 * font.c (font_intern_prop): Likewise. Adjust comment.
1091 * w32font.c (intern_font_name): Likewise.
1092
34348bd4
AS
10932012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1094
d96a1e0c
AS
1095 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1096
34348bd4
AS
1097 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1098 of Fcar/Fcdr if possible.
1099 * font.c (check_otf_features): Likewise.
1100 * fontset.c (Fnew_fontset): Likewise.
1101 * gnutls.c (Fgnutls_boot): Likewise.
1102 * minibuf.c (read_minibuf): Likewise.
1103 * msdos.c (IT_set_frame_parameters): Likewise.
1104 * xmenu.c (Fx_popup_dialog): Likewise.
1105 * w32menu.c (Fx_popup_dialog): Likewise.
1106
c8add24e
GM
11072012-07-11 Glenn Morris <rgm@gnu.org>
1108
4b575b3c
GM
1109 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1110 since nothing has defined it on these platforms.
1111
09f4e3b0
GM
1112 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1113 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1114
172bedef
GM
1115 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1116 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1117 Move CLASH_DETECTION to configure.
1118
249685df
GM
1119 * s/gnu.h: Remove file, which is now empty.
1120
c8add24e
GM
1121 * s/gnu.h, s/gnu-linux.h:
1122 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1123
b41253a3
JW
11242012-07-11 John Wiegley <johnw@newartisans.com>
1125
1126 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1127 function attribute, so we only use it if it exists in the
1128 compiler.
1129
d923b542
DA
11302012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1131
1132 Avoid call to strlen in fast_c_string_match_ignore_case.
1133 * search.c (fast_c_string_match_ignore_case): Change to use
1134 length argument. Adjust users accordingly.
1135 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1136
5ebbef1d
PE
11372012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1138
bb352260
PE
1139 Assume mkdir, rmdir.
1140 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1141 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1142
57054ddd
PE
1143 Assume rename.
1144 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1145
b747d3f7
PE
1146 Assume perror.
1147 * s/hpux10-20.h (HAVE_PERROR): Remove.
1148 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1149 Remove dummy definition, as this problem was obsolete long ago.
1150
5ebbef1d
PE
1151 Assume strerror.
1152 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1153
984e7f30
DA
11542012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1155
1156 Avoid calls to strlen in font processing functions.
1157 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1158 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1159 users accordingly.
d923b542
DA
1160 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1161 Adjust prototypes.
1162 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1163 Change to return ptrdiff_t.
984e7f30
DA
1164 (xfont_list_pattern, xfont_match): Use length returned by
1165 xfont_decode_coding_xlfd.
1166 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1167
20e94fdd
GM
11682012-07-11 Glenn Morris <rgm@gnu.org>
1169
9d596af3
GM
1170 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1171 Move DONT_REOPEN_PTY to configure.
1172
20e94fdd
GM
1173 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1174 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1175
e99a530f
PE
11762012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1177
22ffb973
PE
1178 Remove "#define unix" that is no longer needed (Bug#11905).
1179 * s/aix4-2.h (unix): Remove; no longer needed.
1180
e9a9ae03
PE
1181 EMACS_TIME simplification (Bug#11875).
1182 This replaces macros (which typically do not work in GDB)
1183 with functions, typedefs and enums, making the code easier to debug.
1184 The functional style also makes code easier to read and maintain.
1185 * systime.h: Include <sys/time.h> on all hosts, not just if
1186 WINDOWSNT, since 'struct timeval' is needed in general.
1187 (EMACS_TIME): Now a typedef, not a macro.
1188 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1189 not macros.
1190 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1191 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1192 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1193 (EMACS_TIME_LE): Now functions, not macros.
1194 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1195 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1196 which are not functions. All uses rewritten to use:
1197 (make_emacs_time): New function.
1198 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1199 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1200 not functions. All uses rewritten to use the following, respectively:
1201 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1202 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1203 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1204 * fileio.c (Fcopy_file):
1205 * xterm.c (XTflash): Get the current time closer to when it's used.
1206 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1207
ffacb126
PE
1208 * bytecode.c (targets): Suppress -Woverride-init warnings.
1209
e99a530f
PE
1210 Simplify by avoiding confusing use of strncpy etc.
1211 * doc.c (Fsnarf_documentation):
1212 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1213 * frame.c (Fmake_terminal_frame):
1214 * gtkutil.c (get_utf8_string):
1215 * lread.c (openp):
1216 * nsmenu.m (ns_update_menubar):
1217 * regex.c (regerror):
1218 Prefer memcpy to strncpy and strncat when either will do.
1219 * fileio.c (Fsubstitute_in_file_name):
1220 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1221 (menu_separator_name_p):
1222 * nsmenu.m (ns_update_menubar):
1223 Prefer memcmp to strncmp when either will do.
1224 * nsterm.m: Include <ftoastr.h>.
1225 (ns_get_color):
1226 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1227 Prefer snprintf to strncpy.
1228 * nsterm.m (ns_term_init):
1229 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1230 * nsterm.m (ns_term_init):
1231 Avoid the need for strncpy, by using build_string or
1232 make_unibyte_string directly. Use dtoastr, not snprintf.
1233 * process.c (Fmake_network_process): Diagnose service names that
1234 are too long, rather than silently truncating them or creating
1235 non-null-terminated names.
1236 (Fnetwork_interface_info): Likewise, for interface names.
1237 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1238 Prefer sprintf to strncat.
1239 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1240 Prefer vsnprintf to vsprintf + strncpy.
1241
c59592b3
GM
12422012-07-10 Glenn Morris <rgm@gnu.org>
1243
1244 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1245 Clarify fallback case.
1246
7d7bbefd
DA
12472012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1248
1249 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1250 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1251 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1252 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1253 where argument type is known to be a Lisp_Cons.
1254
3a4c8000
TT
12552012-07-10 Tom Tromey <tromey@redhat.com>
1256
1257 * bytecode.c (BYTE_CODE_THREADED): New macro.
1258 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1259 (enum byte_code_op): New type.
1260 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1261 (exec_byte_code): Use them. Use token threading when applicable.
1262
2a0213a6
DA
12632012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1264
1265 Optimize pure C strings initialization.
1266 * lisp.h (make_pure_string): Fix prototype.
1267 (build_pure_c_string): New function, defined as static inline. This
1268 provides a better opportunity to optimize away calls to strlen when
1269 the function is called with compile-time constant argument.
1270 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1271 argument, adjust users accordingly. Use build_pure_c_string where
1272 appropriate.
1273 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1274 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1275 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1276
cb1caeaf
DA
12772012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1278
1279 Avoid calls to strlen in miscellaneous functions.
1280 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1281 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1282 * lread.c (openp): Likewise.
1283
c293e30c
DA
12842012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1285
1286 Avoid calls to strlen in path processing functions.
1287 * fileio.c (file_name_as_directory): Add comment. Change to add
1288 srclen argument and return the length of result. Adjust users
1289 accordingly.
1290 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1291 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1292 users accordingly.
1293 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1294
9e059e3f
GM
12952012-07-10 Glenn Morris <rgm@gnu.org>
1296
d02eb359
GM
1297 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1298 Move PENDING_OUTPUT_COUNT definition to configure.
1299
882cf227
GM
1300 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1301 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1302 * s/gnu.h (DATA_START): Move definitions to configure.
1303
af6e839f
GM
1304 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1305 We include usg5-4-common.h, which defines them both.
1306
40289a12
GM
1307 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1308 O_RDONLY already includes it).
1309
9e059e3f
GM
1310 Stop ns builds setting the EMACSLOADPATH environment variable.
1311 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1312 Now it does not set EMACSLOADPATH, just returns the load-path string.
1313 * nsterm.h: Update accordingly.
1314 * lread.c [HAVE_NS]: Include nsterm.h.
1315 (init_lread) [HAVE_NS]: Use ns_load_path.
1316 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1317
7c4e8ec0
GM
13182012-07-09 Glenn Morris <rgm@gnu.org>
1319
d4f600ff
GM
1320 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1321 since the included bsd-common.h does so.
1322
cbb31951
GM
1323 Stop ns builds setting the EMACSPATH environment variable.
1324 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1325 (ns_init_paths): Do not set EMACSPATH.
1326 * nsterm.h (ns_exec_path): Add it.
1327 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1328 Use ns_exec_path.
1329
7c4e8ec0
GM
1330 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1331
26bccfae
PE
13322012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1333
a0bee46f
PE
1334 * process.c (wait_reading_process_output): 'waitchannels' was unset
1335 when read_kbd || !NILP (wait_for_cell); fix this.
1336
5994c183
PE
1337 Add GCC-style 'const' attribute to functions that can use it.
1338 * character.h (char_resolve_modifier_mask):
1339 * keyboard.h (make_ctrl_char):
1340 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1341 (init_character_once, next_almost_prime, init_fns, init_image)
1342 (flush_pending_output, init_sound):
1343 * mem-limits.h (start_of_data):
1344 * menu.h (finish_menu_items):
1345 Add ATTRIBUTE_CONST.
1346 * emacs.c (DEFINE_DUMMY_FUNCTION):
1347 Declare the dummy function with ATTRIBUTE_CONST.
1348 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1349 Add decls with ATTRIBUTE_CONST.
1350
26bccfae
PE
1351 Minor improvements to make_formatted_string.
1352 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1353 where int is good enough, as vsprintf returns an int.
1354 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1355
a8290ec3
DA
13562012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1357
1358 Use make_formatted_string to avoid double length calculation.
1359 * lisp.h (make_formatted_string): New prototype.
1360 * alloc.c (make_formatted_string): New function.
1361 * buffer.c (Fgenerate_new_buffer_name): Use it.
1362 * dbus.c (syms_of_dbusbind): Likewise.
1363 * editfns.c (Fcurrent_time_zone): Likewise.
1364 * filelock.c (get_boot_time): Likewise.
1365 * frame.c (make_terminal_frame, set_term_frame_name)
1366 (x_report_frame_params): Likewise.
1367 * image.c (gs_load): Likewise.
1368 * minibuf.c (get_minibuffer): Likewise.
1369 * msdos.c (dos_set_window_size): Likewise.
1370 * process.c (make_process): Likewise.
1371 * xdisp.c (ensure_echo_area_buffers): Likewise.
1372 * xsettings.c (apply_xft_settings): Likewise.
1373
d01ba2f1
GM
13742012-07-09 Glenn Morris <rgm@gnu.org>
1375
1376 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1377 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1378 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1379 * nsterm.h (ns_etc_directory): Add it.
1380 * callproc.c [HAVE_NS]: Include nsterm.h.
1381 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1382
f1f924b6
DA
13832012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1384
1385 Move marker debugging code under MARKER_DEBUG.
1386 * marker.c (MARKER_DEBUG): Move marker debugging code under
1387 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1388 for bootstrap with --enable-checking (~3x slowdown reported
1389 by Juanma Barranquero <lekktu@gmail.com>).
1390 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1391
ab531b66
PE
13922012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1395 See <http://bugs.gnu.org/11825#29>.
1396
c4b3bc8a
EZ
13972012-07-08 Eli Zaretskii <eliz@gnu.org>
1398
1399 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1400 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1401 (display_line): Add commentary about displaying truncation glyphs
1402 on GUI frames.
1403 (produce_special_glyphs): Move here from term.c.
1404
1405 * term.c (produce_special_glyphs): Move to xdisp.c.
1406
1407 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1408 section.
c4b3bc8a 1409
b676b881
AS
14102012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1411
f17c5273
AS
1412 * xdisp.c (display_line): Avoid warning about implicit declaration
1413 of FRAME_FONT.
1414
298819b9
AS
1415 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1416
b676b881
AS
1417 * lisp.h: Remove empty conditional.
1418
6045c4fd
PE
14192012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1420
b3350bf9
PE
1421 * lread.c (load_path_check): Now static.
1422
6045c4fd
PE
1423 Fix some minor --with-ns problems found by static checking.
1424 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1425 (x_set_font) [!HAVE_X_WINDOWS]:
1426 * image.c (xpm_load_image) [HAVE_NS]:
1427 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1428 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1429 Remove unused local.
1430 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1431 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1432 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1433 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1434 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1435 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1436 Fix pointer signedness problem.
1437 * xfaces.c (FRAME_X_FONT_TABLE):
1438 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1439
929e7845
GM
14402012-07-07 Glenn Morris <rgm@gnu.org>
1441
1442 * lread.c (load_path_check): New function, split from init_lread.
1443 (init_lread): Reorganize. Motivation:
1444 If EMACSLOADPATH is set, check/warn about that rather than the
1445 defaults, which we are not going to use. Hence we can remove
1446 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1447 Don't warn if site-lisp directories are missing.
1448 If not installed, start from a blank load-path, since
1449 PATH_LOADSEARCH refers to the eventual installation directories.
1450
58dd0aa4
EZ
14512012-07-07 Eli Zaretskii <eliz@gnu.org>
1452
1453 Support truncation and continuation glyphs on GUI frames, when
1454 fringes are disabled. (Bug#11832)
1455 * xdisp.c (init_iterator): Get dimensions of truncation and
1456 continuation glyphs even if on GUI frames. Adjust
1457 it->last_visible_x on GUI frames when the left or right fringes,
1458 or both, are absent.
1459 (start_display, move_it_in_display_line_to): Handle the case of a
1460 GUI frame without a fringe to display continuation or truncation
1461 glyphs.
1462 (insert_left_trunc_glyphs): Support GUI frames: make sure
1463 truncation glyphs overwrite enough glyphs from the current line to
1464 have sufficient space in pixels.
1465 (display_line): Support truncation and continuation glyphs on GUI
1466 frames. If some spare pixels are left on the line after inserting
1467 the truncation glyphs, fill that space with a stretch glyph of a
1468 suitably computed width.
1469
1470 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1471 produce_glyphs, to support GUI sessions.
1472
31571fd7
PE
14732012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1474
5a16b9bc
PE
1475 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1476
f3047c75
PE
1477 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1478
31571fd7
PE
1479 Do not require float-time's arg to fit in time_t (Bug#11825).
1480 This works better on hosts where time_t is unsigned, and where
1481 float-time is applied to the (negative) difference between two times.
1482 * editfns.c (decode_time_components): Last arg is now double *,
1483 not int *, and means to store all the result as a double, without
1484 worrying about whether the seconds part fits in time_t.
1485 All callers changed.
1486 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1487 All callers changed.
1488 (Ffloat_time): Do not fail merely because the specified time falls
1489 outside of time_t range.
1490
4516fbef
GM
14912012-07-07 Glenn Morris <rgm@gnu.org>
1492
1493 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1494 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1495 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1496
07adc2c6
JB
14972012-07-07 Juanma Barranquero <lekktu@gmail.com>
1498
1499 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1500 Update dependencies.
1501
1502 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1503
fd573f31
PE
15042012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1505
fee5959d
PE
1506 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1507 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1508 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1509 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1510 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1511 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1512
fd573f31
PE
1513 * xfont.c (compare_font_names): Redo to omit the need for casts.
1514
ddadbc0e
AS
15152012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1516
fca8d6b6
AS
1517 * xfns.c (Fx_change_window_property): Doc fix.
1518 * w32fns.c (Fx_change_window_property): Doc fix.
1519
ddadbc0e
AS
1520 * w32fns.c (Fx_window_property): Accept the same arguments as the
1521 X Windows version. Doc fix.
1522 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1523
ed9265fc 15242012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1525 Eli Zaretskii <eliz@gnu.org>
1526
1527 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1528 Windows-specific code from nt/config.nt moved here.
1529 Obsolete settings removed.
1530
216ee680
PE
15312012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 * process.c: Avoid unnecessary calls to gettime.
1534 (wait_reading_process_output): Don't get the time of day
1535 when gobbling data immediately and not waiting, as there's no need
1536 for it in that case. This removes a FIXME.
1537
bdd091e4
JD
15382012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1539
1540 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1541 is defined (Bug#11768).
1542
9d44f8ce
DA
15432012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1544
1545 Fix marker debugging code.
1546 * marker.c (byte_char_debug_check): Do not perform the check
1547 if buffer is not multibyte.
090bd7cb
JB
1548 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1549 Call byte_char_debug_check with correct arguments.
9d44f8ce 1550
90fc4786
DA
15512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1552
1553 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1554 * marker.c (byte_char_debug_check, count_markers):
1555 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1556 (byte_debug_flag): Remove.
1557 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1558 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1559
7b7ae965
DA
15602012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1561
4e57b342
DA
1562 Avoid code repetition in marker-related functions.
1563 * marker.c (attach_marker): New function.
1564 (Fset_marker, set_marker_restricted, set_marker_both)
1565 (set_marker_restricted_both): Use it.
1566 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1567 Consistently rename charno to charpos.
1568 (marker_position): Add eassert.
1569 (marker_byte_position): Convert to eassert.
1570
15712012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1572
1573 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1574 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1575 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1576
657924ff
DA
15772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1578
1579 Introduce fast path for the widely used marker operation.
1580 * alloc.c (build_marker): New function.
1581 * lisp.h (build_marker): New prototype.
1582 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1583 * composite.c (autocmp_chars): Likewise.
1584 * editfns.c (buildmark): Remove.
1585 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1586 (save_restriction_save): Use build_marker.
1587 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1588 * window.c (save_window_save): Likewise.
1589
041a49a6
DA
15902012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1591
1592 Do not use Fdelete_overlay in delete_all_overlays
1593 to avoid redundant calls to unchain_overlay.
1594 * buffer.c (drop_overlay): New function.
1595 (delete_all_overlays, Fdelete_overlay): Use it.
1596 * minibuf.c (get_minibuffer): Fix comment.
1597
7dca65a4
PE
15982012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1599
1600 Port to OpenBSD 5.1 amd64.
1601 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1602 This is needed for OpenBSD, and should be harmless on all BSD systems.
1603 Also, include <sys/sysctl.h>, as it should be available on all
1604 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1605 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1606 use p_pid member, not kp_proc.pid.
1607
8eb876e2
GM
16082012-07-06 Glenn Morris <rgm@gnu.org>
1609
1610 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1611
38182d90
PE
16122012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1613
1614 More xmalloc and related cleanup.
1615 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1616 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1617 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1618 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1619 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1620 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1621 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1622 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1623 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1624 * xterm.c:
1625 Omit needless casts involving void * pointers and allocation.
1626 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1627 as the former is more robust if P's type is changed.
1628 Prefer xzalloc to xmalloc + memset 0.
1629 Simplify malloc-or-realloc to realloc.
1630 Don't worry about xmalloc returning a null pointer.
1631 Prefer xstrdup to xmalloc + strcpy.
1632 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1633 growing it.
1634 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1635 alloca of a constant.
1636
6dd5a677
EZ
16372012-07-05 Eli Zaretskii <eliz@gnu.org>
1638
1639 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1640 hscroll is larger than the line width. Fixes long and futile
1641 looping inside extend_face_to_end_of_line (on a TTY) producing
1642 glyphs that are not needed and thrown away.
1643
6b312f0f
DA
16442012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1645
1646 * marker.c (set_marker_restricted_both): Simplify by using
1647 clip_to_bounds.
1648
f520ef9b
PE
16492012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1650
1651 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1652
383b7c95
JD
16532012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1654
1655 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1656 not defined (Bug#11768).
1657 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1658 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1659 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1660 followed by gtk_box_set_homogeneous (Bug#11768).
1661 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1662 (update_theme_scrollbar_width, xg_create_scroll_bar):
1663 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1664 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1665 (is_box_type): New function (Bug#11768).
1666 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1667 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1668 with default display (Bug#11768).
1669
d6e7bf45
EZ
16702012-07-05 Eli Zaretskii <eliz@gnu.org>
1671
1672 * xdisp.c (window_hscroll_limited): New function.
1673 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1674 coordinates when window's hscroll is set to insanely large
1675 values. (Bug#11857)
1676
431391ec
JB
16772012-07-05 Juanma Barranquero <lekktu@gmail.com>
1678
1679 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1680 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1681
23f86fce
DA
16822012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1683
1684 Cleanup xmalloc.
1685 * lisp.h (xzalloc): New prototype. Omit needless casts.
1686 * alloc.c (xzalloc): New function. Omit needless casts.
1687 * charset.c: Omit needless casts. Convert all calls to
1688 xmalloc with following memset to xzalloc.
1689 * dispnew.c: Likewise.
1690 * fringe.c: Likewise.
1691 * image.c: Likewise.
1692 * sound.c: Likewise.
1693 * term.c: Likewise.
1694 * w32fns.c: Likewise.
1695 * w32font.c: Likewise.
1696 * w32term.c: Likewise.
1697 * xfaces.c: Likewise.
1698 * xfns.c: Likewise.
1699 * xterm.c: Likewise.
1700 * atimer.c: Omit needless casts.
1701 * buffer.c: Likewise.
1702 * callproc.c: Likewise.
1703 * ccl.c: Likewise.
1704 * coding.c: Likewise.
1705 * composite.c: Likewise.
1706 * doc.c: Likewise.
1707 * doprnt.c: Likewise.
1708 * editfns.c: Likewise.
1709 * emacs.c: Likewise.
1710 * eval.c: Likewise.
1711 * filelock.c: Likewise.
1712 * fns.c: Likewise.
1713 * gtkutil.c: Likewise.
1714 * keyboard.c: Likewise.
1715 * lisp.h: Likewise.
1716 * lread.c: Likewise.
1717 * minibuf.c: Likewise.
1718 * msdos.c: Likewise.
1719 * print.c: Likewise.
1720 * process.c: Likewise.
1721 * region-cache.c: Likewise.
1722 * search.c: Likewise.
1723 * sysdep.c: Likewise.
1724 * termcap.c: Likewise.
1725 * terminal.c: Likewise.
1726 * tparam.c: Likewise.
1727 * w16select.c: Likewise.
1728 * w32.c: Likewise.
1729 * w32reg.c: Likewise.
1730 * w32select.c: Likewise.
1731 * w32uniscribe.c: Likewise.
1732 * widget.c: Likewise.
1733 * xdisp.c: Likewise.
1734 * xmenu.c: Likewise.
1735 * xrdb.c: Likewise.
1736 * xselect.c: Likewise.
1737
0497dc44
PE
17382012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1739
1740 * fileio.c (time_error_value): Check the right error number.
1741 Problem reported by Troels Nielsen in
1742 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1743
356e7178
PE
17442012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1745
4e71fd89
PE
1746 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1747 This should be fixed in a better way; see Eli Zaretskii in
1748 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1749 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1750
f0941253
PE
1751 * fileio.c (time_error_value): Rename from special_mtime.
1752 The old name's problems were noted by Eli Zaretskii in
1753 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1754
065c9eb4
PE
1755 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1756 This variable's comment says Emacs needs at least one GDB-visible
1757 symbol of type enum pvec_type, to work around GDB problems.
1758 The symbol's value doesn't matter.
1759
356e7178
PE
1760 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1761 that causes compilation to fail on pre-C99 compilers.
1762
ed9265fc 17632012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1764
1765 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1766 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1767
3884d954
DA
17682012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1769
d209e2fb 1770 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1771 headers for buffer_defaults and buffer_local_symbols.
1772 Reported by Juanma Barranquero <lekktu@gmail.com>.
1773
ee28be33
SM
17742012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1775
1776 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1777 * lisp.h (enum pvec_type): Use fewer bits.
1778 (PSEUDOVECTOR_SIZE_BITS): New constant.
1779 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1780 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1781 change in pvec_type.
1782 (PSEUDOVECTOR_TYPEP): New macro.
1783 (TYPED_PSEUDOVECTORP): Use it.
1784 * fns.c (internal_equal): Adapt code to extract pvectype.
1785 * emacs.c (gdb_pvec_type): Update type.
1786 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1787 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1788 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1789 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1790 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1791 abusing vector->header.next.nbytes.
1792 (live_vector_p): Use PVEC_TYPE.
1793 (mark_object): Adapt code to extract pvectype. Use switch.
1794
c7f2cd7f
PE
17952012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1798 Tighten new eassert a bit.
1799
8ce70ed2
DA
18002012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1801
1802 Fix compilation with --enable-gcc-warnings and -O1
1803 optimization level.
1804 * doprnt.c (doprnt): Change type of tem to int, initialize
1805 to avoid compiler warning. Add eassert.
1806 * search.c (simple_search): Initialize match_byte to avoid
1807 compiler warning. Add eassert.
1808
dea7f1e5
PE
18092012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1810
24a212eb
PE
1811 Avoid weird behavior with large horizontal scrolls.
1812 Without this change, for example, large hscroll values would
1813 mess up Emacs's display on Fedora 15 x86, presumably due to
1814 overflows in int calculations in the display code.
1815 Also, if buffers had long lines, Emacs would freeze.
1816 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1817 (set_window_hscroll): New function, containing the old guts of
1818 Fset_window_hscroll. Return the clipped value.
1819 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1820 This avoids the need to check against PTRDIFF_MAX.
1821
dea7f1e5
PE
1822 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1823
76046526
DA
18242012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1825
1826 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1827
39adff0d
PE
18282012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1829
63807d47
PE
1830 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1831 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1832 since GCC 4.4.6 issues a bogus warning for them.
1833
39adff0d
PE
1834 Fix bugs in file timestamp newness comparisons.
1835 * fileio.c (Ffile_newer_than_file_p):
1836 * lread.c (Fload): Use full timestamp resolution of files,
1837 not just the 1-second resolution, so that files that are only
1838 slightly newer still count as newer.
1839 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1840 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1841
dbeed9a6
PE
18422012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1843
1844 * fileio.c: Improve handling of file time marker. (Bug#11852)
1845 (special_mtime): New function.
1846 (Finsert_file_contents, Fverify_visited_file_modtime):
1847 Use it to set special mtime values consistently.
1848
636334d6
AS
18492012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1850
1851 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1852 marker for non-existing file. (Bug#11852)
1853
e2017fe2
GM
18542012-07-03 Glenn Morris <rgm@gnu.org>
1855
1856 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1857 and did not make it into globals.h).
1858
404dbd37
TT
18592012-07-03 Tom Tromey <tromey@redhat.com>
1860
1861 * window.c (Fset_window_margins, Fset_window_fringes)
1862 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1863 * textprop.c (Fprevious_property_change): No longer static.
1864 * syntax.c (Fsyntax_table_p): No longer static.
1865 * process.c (Fget_process, Fprocess_datagram_address): No longer
1866 static.
1867 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1868 * keyboard.c (Fcommand_execute): No longer static.
1869 Remove EXFUN.
1870 * insdel.c (Fcombine_after_change_execute): No longer static.
1871 * image.c (Finit_image_library): No longer static.
1872 * fileio.c (Fmake_symbolic_link): No longer static.
1873 * eval.c (Ffetch_bytecode): No longer static.
1874 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1875 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1876 No longer static.
404dbd37
TT
1877 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1878 static.
1879 * dired.c (Ffile_attributes): No longer static.
1880 * composite.c (Fcomposition_get_gstring): No longer static.
1881 * callproc.c (Fgetenv_internal): No longer static.
1882
1883 * ccl.h: Remove EXFUNs.
1884 * buffer.h: Remove EXFUNs.
1885 * dispextern.h: Remove EXFUNs.
1886 * intervals.h: Remove EXFUNs.
1887 * fontset.h: Remove EXFUN.
1888 * font.h: Remove EXFUNs.
1889 * dosfns.c (system_process_attributes): Remove EXFUN.
1890 * keymap.h: Remove EXFUNs.
1891 * lisp.h: Remove EXFUNs.
1892 * w32term.h: Remove EXFUNs.
1893 * window.h: Remove EXFUNs.
1894 * xsettings.h: Remove EXFUN.
1895 * xterm.h: Remove EXFUN.
1896
8e4fd1e1
GM
18972012-07-03 Glenn Morris <rgm@gnu.org>
1898
1899 * lisp.h (Frandom): Make it visible to C.
1900 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1901 buffer for invisible buffers. (Bug#1229)
1902
ca95b3eb
DA
19032012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1904
1905 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1906 values which aren't power of 2.
1907 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1908 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1909 accordingly.
1910
7555c33f
SM
19112012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1912
1913 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1914
1915 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1916
d12e8f5a
DA
19172012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1918
1919 * alloc.c (allocate_vector_block): Remove redundant
1920 calls to mallopt if DOUG_LEA_MALLOC is defined.
1921 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1922 avoid calls to mallopt if zero_vector is returned.
1923
296094c3
DA
19242012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1925
1926 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1927 is enabled, avoid dereferencing NULL current_sblock if
1928 running undumped.
1929
36429c89
DA
19302012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1931
1932 Cleanup basic buffer management.
1933 * buffer.h (struct buffer): Change layout to use generic vector
1934 marking code. Fix some comments. Change type of 'clip_changed'
1935 to bitfield. Remove unused #ifndef old.
1936 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1937 (GET_OVERLAYS_AT): Fix indentation.
1938 (for_each_per_buffer_object_at): New macro.
1939 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1940 (Fbuffer_local_variables): Use it.
1941 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1942 * alloc.c (allocate_buffer): Adjust to match new layout of
1943 struct buffer. Fix comment.
1944 (mark_overlay): New function.
1945 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1946 Lisp area of struct buffer.
1947 (mark_object): Use it. Adjust marking of misc objects
1948 and related comments.
1949
3b3e4cac
PE
19502012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1953 wrapper that is not needed because the wrapped code is a no-op (zero
1954 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1955 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1956
cf5c0175
DA
19572012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1958
1959 * alloc.c (mark_buffer): Simplify. Remove prototype.
1960 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1961 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1962 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1963 redundant calls to mark_vectorlike for bool vectors.
1964
ca26824c
GM
19652012-06-30 Glenn Morris <rgm@gnu.org>
1966
2e4c5312
GM
1967 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1968
ca26824c
GM
1969 * epaths.in (PATH_SITELOADSEARCH): New.
1970 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1971 This is rather than relying on --enable-locallisppath elements
1972 having "site-lisp" in their names. (Bug#10208#25, 11658)
1973
0d23c240
EZ
19742012-06-30 Eli Zaretskii <eliz@gnu.org>
1975
c9240d7a
EZ
1976 * w32proc.c (sys_select): Accept and ignore one more argument.
1977
1978 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1979
0d23c240 1980 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1981 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1982
1983 * sysdep.c: Don't include dos.h and dosfns.h.
1984
1985 * process.c (sys_select):
1986 * msdos.c (sys_select): Accept one more argument and ignore it.
1987
1988 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1989 adapt data types and code to that.
1990
1991 * dosfns.c:
1992 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1993 which clashes with the gnulib function of the same name.
1994
af5a5a98
AS
19952012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1996
c5e4379c
AS
1997 * font.c (font_style_to_value, font_style_symbolic)
1998 (font_prop_validate_style): Add type checks for values in
1999 font_style_table.
2000
af5a5a98
AS
2001 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2002 argument.
2003 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2004 uses.
2005
8d38f461
EZ
20062012-06-29 Eli Zaretskii <eliz@gnu.org>
2007
2e5a6631
EZ
2008 * xdisp.c (try_window_id): Undo last change.
2009
8d38f461
EZ
2010 * w32.c (getwd): Adjust commentary about startup_dir.
2011 (init_environment): Always call sys_access, even in non-MSVC
2012 builds. Don't chdir to the directory of the Emacs executable.
2013 This undoes code from 1997 which was justified by the need to
2014 "avoid conflicts when removing and renaming directories". But its
2015 downside was that every relative file name was being interpreted
2016 relative to the directory of the Emacs executable, which can never
2017 be TRT. In particular, it broke sys_access when called with
2018 relative file names.
2019 (sys_access): Map GetLastError to errno.
2020
2af3565e
DA
20212012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2022
2023 * window.h (struct window): Change type of 'fringes_outside_margins'
2024 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2025 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2026 Adjust comment.
2027 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2028 to ptrdiff_t.
2029
c8d3a25c 20302012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2031
c8d3a25c
GM
2032 * gnutls.c (emacs_gnutls_handshake):
2033 Add QUIT to make the loop interruptible.
57570cd3 2034
c8d3a25c 20352012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2036
c8d3a25c
GM
2037 * charset.c (init_charset): Make lack of etc/charsets fatal.
2038
3e984ee8
DA
20392012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2040
2041 * editfns.c (region_limit): Fix type mismatch.
2042
ef884f23
DA
20432012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2044
2045 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2046 undefined. Convert from xassert to eassert.
2047 * nsmenu.m: Convert from xassert to eassert.
2048 * nsterm.m: Likewise.
2049
7d7e0027
SM
20502012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2051
2052 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2053
aa754e6a
PE
20542012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 Avoid integer overflow on scroll-left and scroll-right.
2057 * window.c (HSCROLL_MAX): New macro.
2058 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2059 overflow when requested scroll falls outside ptrdiff_t range.
2060
80b00b08
DA
20612012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2062
2063 * window.h (struct window): Change type of 'hscroll',
2064 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2065 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2066 Adjust users accordingly.
2067 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2068 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2069 from EMACS_INT to ptrdiff_t.
2070 (make_window): Omit redundant initialization.
2071
62b2bcf6
JB
20722012-06-28 Juanma Barranquero <lekktu@gmail.com>
2073
2074 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2075
45942c7d
DA
20762012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2077
2078 * window.h (struct window): Change type of 'use_time' and
2079 'sequence_number' from Lisp_Object to int.
2080 * frame.c (make_frame): Adjust users accordingly.
2081 * print.c (print_object): Likewise.
2082 * window.c (select_window, Fwindow_use_time, make_parent_window)
2083 (make_window): Likewise.
2084
e509cfa6
DA
20852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2086
2087 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2088 enabled with --enable-checking=[all,glyphs] configure option.
2089 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2090 adjust comments accordingly.
2091 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2092 undefined, adjust comments accordingly.
2093 * image.c: Likewise.
2094 * scroll.c: Likewise.
2095 * w32fns.c: Likewise.
2096 * w32term.c: Likewise.
2097 * xdisp.c: Likewise.
2098 * xfaces.c: Likewise.
2099 * xfns.c: Likewise.
2100 * xterm.c: Likewise.
2101
a54e2c05
DA
21022012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2103
2104 Generalize run-time debugging checks.
2105 * dispextern.h (XASSERTS): Remove.
2106 * fontset.c (xassert): Remove.
2107 Convert from xassert to eassert.
2108 * alloc.c: Convert from xassert to eassert.
2109 * bidi.c: Likewise.
2110 * dispnew.c: Likewise.
2111 * fns.c: Likewise.
2112 * fringe.c: Likewise.
2113 * ftfont.c: Likewise.
2114 * gtkutil.c: Likewise.
2115 * image.c: Likewise.
2116 * keyboard.c: Likewise.
2117 * menu.c: Likewise.
2118 * process.c: Likewise.
2119 * scroll.c: Likewise.
2120 * sound.c: Likewise.
2121 * term.c: Likewise.
2122 * w32console.c: Likewise.
2123 * w32fns.c: Likewise.
2124 * w32term.c: Likewise.
2125 * window.c: Likewise.
2126 * xdisp.c: Likewise.
2127 * xfaces.c: Likewise.
2128 * xfns.c: Likewise.
2129 * xselect.c: Likewise.
2130 * xterm.c: Likewise.
2131
1ec4b7b2
SM
21322012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2133
2134 * fns.c (maybe_resize_hash_table): Output message when growing the
2135 purify-hashtable.
2136
2014308a
DA
21372012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2138
2139 * alloc.c (allocate_string_data): Remove dead code.
2140 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2141 avoid GCC warning about unused macro.
2142
246155eb
DA
21432012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2144
2145 * alloc.c (allocate_string): Omit intervals initialization.
2146 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2147 as in make_pure_string and make_pure_c_string.
2148
43184b7b
DA
21492012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2150
d209e2fb 2151 * alloc.c (allocate_string): Fix last change.
43184b7b 2152
3fe6dd74
DA
21532012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2154
d209e2fb 2155 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2156 to memset, add explicit initialization where appropriate.
2157
1ba6038a
GM
21582012-06-27 Glenn Morris <rgm@gnu.org>
2159
2160 * lisp.mk (lisp): Remove paths.elc.
2161
c89926a5
CY
21622012-06-27 Chong Yidong <cyd@gnu.org>
2163
2164 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2165
ed6b3510
JW
21662012-06-26 John Wiegley <johnw@newartisans.com>
2167
1ec4b7b2 2168 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2169 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2170
ed6b3510
JW
2171 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2172 when building with Clang.
2173
8edd4a2b
SM
21742012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2175
2176 * eval.c (Fapply): Allow calling it with a single argument.
2177
f6f62d1b
EZ
21782012-06-26 Eli Zaretskii <eliz@gnu.org>
2179
2180 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2181 _stricmp and _strnicmp.
2182 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2183
62efea5e
DA
21842012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2185
2186 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2187 allocated window.
2188 (allocate_process): Likewise for new process.
8edd4a2b 2189 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2190 (allocate_frame): Likewise.
2191 * frame.c (make_frame): Omit redundant initialization.
2192 * window.c (make_parent_window): Use memset.
2193 (make_window): Omit redundant initialization.
2194 * process.c (make_process): Omit redundant initialization.
2195 * terminal.c (create_terminal): Likewise.
2196
42997f4d
DA
21972012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2198
2199 * term.c (delete_tty): Remove redundant call to memset.
2200
1130ecfc
DA
22012012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2202
2203 * alloc.c: Remove build_string.
2204 * lisp.h: Define build_string as static inline. This provides
2205 a better opportunity to optimize away calls to strlen when the
2206 function is called with compile-time constant argument.
2207 * image.c (imagemagick_error): Convert to build_string.
2208 * w32proc.c (sys_spawnve): Likewise.
2209 * xterm.c (x_term_init): Likewise.
2210
cf38a720
PE
22112012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2212
99027bdd
PE
2213 Use sprintf return value instead of invoking strlen on result.
2214 In the old days this wasn't portable, since some sprintf
2215 implementations returned char *. But they died out years ago and
2216 Emacs already assumes sprintf returns int.
2217 Similarly for float_to_string.
2218 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2219 * ccl.c (ccl_driver):
2220 * character.c (string_escape_byte8):
2221 * data.c (Fnumber_to_string):
2222 * doprnt.c (doprnt):
2223 * print.c (print_object):
2224 * xdisp.c (message_dolog):
2225 * xfns.c (syms_of_xfns):
2226 Use sprintf or float_to_string result to avoid need to call strlen.
2227 * data.c (Fnumber_to_string):
2228 Use make_unibyte_string, since the string must be ASCII.
2229 * lisp.h, print.c (float_to_string): Now returns int length.
2230 * term.c (produce_glyphless_glyph):
2231 Use sprintf result rather than recomputing it.
2232
cf38a720
PE
2233 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2234 * Makefile.in (ALL_CFLAGS):
2235 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2236 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2237
3511c784
DA
22382012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2239
0a08eb21 2240 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2241 strcasecmp if available.
2242 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2243
fb7da12e
AS
22442012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2245
2246 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2247 Avoid comma operator.
2248 * menu.c (push_submenu_start, push_submenu_end)
2249 (push_left_right_boundary, push_menu_pane): Likewise.
2250 * msdos.c (dos_rawgetc): Likewise.
2251
afa2ffd8
DA
22522012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2253
2254 * xfns.c (xic_create_fontsetname): Remove redundant calls
2255 to memset.
2256
b3b4476b
PE
22572012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2258
4495ff38
PE
2259 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2260 sprintf already null-terminates its output.
2261
b3b4476b
PE
2262 * xfns.c (x_window): Remove redundant cast.
2263
b00876c9
DA
22642012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2265
2266 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2267 `const char *' to `char *' to avoid compiler warning.
2268
d188e26b
PE
22692012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2270
885d1d74
PE
2271 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2272 instead of truncating it to 63 (admittedly a generous limit).
2273
d188e26b
PE
2274 * process.c: Fix spelling and caps in comments.
2275
e2f560b1
DN
22762012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2277
e86db54b 2278 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2279 * sysdep.c (setpgrp): Remove definition, not used in this file.
2280
7583a3a1
JB
22812012-06-24 Juanma Barranquero <lekktu@gmail.com>
2282
2283 * makefile.w32-in: Update dependencies.
2284
696056c2
EZ
22852012-06-24 Eli Zaretskii <eliz@gnu.org>
2286
2287 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2288 (SYSTIME_H): Add nt/inc/sys/time.h.
2289
2290 * systime.h [WINDOWSNT]: Include sys/time.h.
2291
2292 * s/ms-w32.h (struct timespec): Definition moved from
2293 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2294
845ca893
PE
22952012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2296
2297 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2298 * buffer.h (buffer_slot_type_mismatch):
2299 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2300 * eval.c (unwind_to_catch):
2301 * image.c (my_png_error, my_error_exit):
2302 * keyboard.c (quit_throw_to_read_char, user_error)
2303 (Fexit_recursive_edit, Fabort_recursive_edit):
2304 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2305 (wrong_type_argument, buffer_overflow, __executable_start)
2306 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2307 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2308 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2309 (fatal):
2310 (child_setup) [!DOS_NT]:
2311 * lread.c (end_of_file_error, invalid_syntax):
2312 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2313 * puresize.h (pure_write_error):
2314 * search.c (matcher_overflow):
2315 * sound.c (sound_perror, alsa_sound_perror):
2316 * sysdep.c, syssignal.h (croak):
2317 * term.c (maybe_fatal, vfatal):
2318 * textprop.c (text_read_only):
2319 * undo.c (user_error):
2320 * unexmacosx.c (unexec_error):
2321 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2322 Use _Noreturn rather than NO_RETURN.
2323 No need for separate decl merely because of _Noreturn.
2324 * sound.c (sound_warning, parse_sound):
2325 Remove unnecessary forward decls.
2326
f1dd8073
PE
23272012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2328
2329 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2330 * lisp.h (WAIT_READING_MAX): New macro.
2331 * dispnew.c (Fsleep_for, sit_for):
2332 * keyboard.c (kbd_buffer_get_event):
2333 * process.c (Faccept_process_output):
2334 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2335 This improves on the previous patch, which introduced a bug
2336 when time_t is unsigned and as wide as intmax_t.
2337 See <http://bugs.gnu.org/9000#51>.
2338
b82c1755
EZ
23392012-06-23 Eli Zaretskii <eliz@gnu.org>
2340
2341 * dispnew.c (sit_for, Fsleep_for):
2342 * keyboard.c (kbd_buffer_get_event):
2343 * process.c (Faccept_process_output): Avoid compiler warnings when
2344 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2345
ca300656
JB
23462012-06-23 Juanma Barranquero <lekktu@gmail.com>
2347
049ec95b
JB
2348 * makefile.w32-in: Update dependencies.
2349
ca300656
JB
2350 * w32.c (ltime): Add return type and declare static.
2351 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2352
db7b8d06
PE
23532012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2354
2355 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2356 Privately reported by Herbert J. Skuhra.
2357 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2358 All uses changed.
2359 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2360 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2361
0bd8297f
EZ
23622012-06-23 Eli Zaretskii <eliz@gnu.org>
2363
96512555
EZ
2364 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2365 last argument of make_unibyte_string.
2366
0bd8297f
EZ
2367 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2368 language ID in the event parameters.
2369
2370 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2371 event.code, not the obscure "character set ID".
2372
63def6b6
CY
23732012-06-23 Chong Yidong <cyd@gnu.org>
2374
2375 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2376
e8a02204
EZ
23772012-06-23 Eli Zaretskii <eliz@gnu.org>
2378
388cdec0
EZ
2379 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2380 * w32.c (fdutimens): New function.
2381
2382 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2383
2384 * s/ms-w32.h (pselect): Redirect to sys_select.
2385
2386 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2387
e8a02204
EZ
2388 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2389 in the logic of incrementing and decrementing the value of
2390 use_relocatable_buffers.
2391
d054f3fb
PE
23922012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2395 Privately reported by Herbert J. Skuhra.
2396 [__FreeBSD__]: Remove "*/" typo after "#include".
2397 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2398 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2399 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2400 Don't assume EMACS_TIME and struct timeval are the same type.
2401
d35af63c
PE
24022012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 Support higher-resolution time stamps (Bug#9000).
2405 The time stamps are only nanosecond-resolution at the C level,
2406 since that's the best that any real-world system supports now.
2407 But they are picosecond-resolution at the Lisp level, as that's
2408 easy, and leaves room for future OS improvements.
2409
2410 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2411 (LIBES): Use it.
2412
2413 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2414 Don't get current time unless it's needed.
2415
2416 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2417 now provides it if it's absent.
2418 (start_atimer): Port to higher-res time stamps.
2419 Check for time stamp overflow. Don't get current time more
2420 often than is needed.
2421
2422 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2423 Include systime.h, not time.h.
2424 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2425
2426 * dired.c: Include stat-time.h.
2427 (Ffile-attributes): File times now have higher resolution.
2428
2429 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2430 (struct image): Timestamp now has higher resolution.
2431
2432 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2433 has at least microseconds now. All uses removed.
2434 (update_frame, update_single_window, update_window, update_frame_1)
2435 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2436
2437 * editfns.c (time_overflow): Now extern.
2438 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2439 (float-time, Fformat_time_string, Fcurrent_time_string)
2440 (Fcurrent_time_zone): Accept and generate higher-resolution
2441 time stamps.
2442 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2443 (decode_time_components, lisp_seconds_argument): New functions.
2444 (make_time): Now static.
2445 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2446 Report an error if the time is invalid, rather than having the caller
2447 do that.
2448
2449 * fileio.c: Include <stat-time.h>
2450 (Fcopy_file): Copy higher-resolution time stamps.
2451 Prefer to set the time stamp via a file descriptor if that works.
2452 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2453 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2454 (Fvisited_file_modtime, Fset_visited_file_modtime):
2455 Support higher-resolution time stamps.
2456
2457 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2458
2459 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2460
2461 * image.c (prepare_image_for_display, clear_image_cache)
2462 (lookup_image): Port to higer-resolution time stamps.
2463
2464 * keyboard.c (start_polling, bind_polling_period):
2465 Check for time stamp overflow.
2466 (read_char, kbd_buffer_get_event, timer_start_idle)
2467 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2468 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2469 Port to higher-resolution time stamps. Do not assume time_t is signed.
2470 (decode_timer): New function. Timers are now vectors of length 9,
2471 not 8, to accommodate the picosecond component.
2472 (timer_check_2): Use it.
2473
2474 * nsterm.m (select_timeout, timeval_subtract): Remove.
2475 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2476 as they're a bit more accurate and handle overflow better.
2477 (ns_select): Change prototype to be compatible with pselect.
2478 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2479 * nsterm.h (ns_select): Adjust prototype.
2480
2481 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2482 us-resolution time stamps.
2483 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2484
2485 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2486
2487 * lisp.h (time_overflow): New decl.
2488 (wait_reading_process_output): First arg is now intmax_t, not int,
2489 to accommodate larger waits.
2490
2491 * process.h (struct Lisp_Process.read_output_delay):
2492 Now counts nanoseconds, not microseconds.
2493 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2494 EMACS_HAS_USECS.
2495 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2496 (wait_reading_process_output):
2497 Port to ns-resolution time stamps.
2498 (Faccept_process_output, wait_reading_process_output):
2499 Check for time stamp overflow. Do not assume time_t is signed.
2500 (select_wrapper): Remove; we now use pselect.
2501 (Fprocess_attributes): Now generates ns-resolution time stamps.
2502
2503 * sysdep.c: Include utimens.h. Don't include utime.h
2504 or worry about struct utimbuf; gnulib does that for us now.
2505 (gettimeofday): Remove; gnulib provides a substitute.
2506 (make_timeval): New function.
2507 (set_file_times): Now sets ns-resolution time stamps.
2508 New arg FD; all uses changed.
2509 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2510 (system_process_attributes):
2511 Now returns ns-resolution time stamp. All uses changed.
2512 Check for time stamp overflow.
2513
2514 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2515 provides a substitute now.
2516
2517 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2518 since it guarantees struct timespec.
2519 (EMACS_TIME): Now struct timespec, so that we can support
2520 ns-resolution time stamps.
2521 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2522 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2523 (EMACS_USECS): Remove.
2524 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2525 so multiply the arg by 1000 before storing it.
2526 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2527 New macros.
2528 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2529 Port to ns-resolution time stamps.
2530 (EMACS_TIME_NEG_P): Remove; replaced by....
2531 (EMACS_TIME_SIGN): New macro.
2532 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2533 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2534 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2535 (make_timeval, make_lisp_time, decode_time_components): New decls.
2536 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2537 that it mishandled time_t overflow. You can't compare by subtracting!
2538 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2539 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2540
2541 * term.c: Include <sys/time.h>.
2542 (timeval_to_Time): New function, for proper overflow wraparound.
2543 (term_mouse_position, term_mouse_click): Use it.
2544
2545 * undo.c (record_first_change): Support higher-resolution time stamps
2546 in the undo buffer.
2547 (Fprimitive_undo): Use them when restoring time stamps.
2548
2549 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2550 (w32_get_internal_run_time):
2551 Port to higher-resolution Emacs time stamps.
2552 (ltime): Now accepts single 64-bit integer, as that's more convenient
2553 for callers.
2554
2555 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2556
2557 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2558 for compatibility with pselect. Support ns-resolution time stamps.
2559
2560 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2561
2562 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2563 Check for time stamp overflow, and support ns-resolution time stamps.
2564
2565 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2566 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2567 (timeval_subtract): Remove; no longer needed.
2568 (XTflash, XTring_bell, x_wait_for_event):
2569 Port to ns-resolution time stamps. Don't assume time_t is signed.
2570
b6a92dfe
CY
25712012-06-22 Chong Yidong <cyd@gnu.org>
2572
2573 * xdisp.c (x_consider_frame_title): Revert last change.
2574
d251c37c
EZ
25752012-06-22 Eli Zaretskii <eliz@gnu.org>
2576
2577 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2578 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2579 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2580 staticidx goes up to 1597 out of 1600 = 0x640.)
2581
f10deafb
PE
25822012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2583
2584 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2585 Otherwise, the umask might be mistakenly 0 while handling input signals.
2586
ec6de1e2
SM
25872012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2588
2589 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2590
28be1ada
DA
25912012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2592
2593 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2594 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2595 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2596 access to `contents' member of Lisp_Vector objects with AREF and ASET
2597 where appropriate.
2598
c6bf3022
CY
25992012-06-19 Chong Yidong <cyd@gnu.org>
2600
2601 * frame.c (delete_frame): When selecting a frame on a different
2602 text terminal, do not alter the terminal's top-frame.
2603
2604 * xdisp.c (format_mode_line_unwind_data): Record the target
2605 frame's selected window and its terminal's top-frame.
2606 (unwind_format_mode_line): Restore them.
2607 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2608 Callers changed.
2609 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2610 since tty frames can be explicitly named.
2611 (prepare_menu_bars): Likewise.
2612
2613 * term.c (Ftty_top_frame): New function.
2614
defd4196
PE
26152012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2616
2617 Port byte-code-meter to modern targets.
2618 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2619 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2620 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2621 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2622 (METER_1, METER_2): Simplify.
2623
1053a871
SM
26242012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2625
2626 * data.c (Fdefalias): Return `symbol' (bug#11686).
2627
b7e8d081
MR
26282012-06-18 Martin Rudalics <rudalics@gmx.at>
2629
2630 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2631 gets killed during executing of this function (Bug#11665).
2632 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2633 (Vkill_buffer_query_functions): In doc-string say that functions
2634 run by this hook should not change the current buffer.
2635
7ea2b339
PE
26362012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2637
2638 Fix recently-introduced process.c problems found by static checking.
2639 * process.c (write_queue_push, write_queue_pop, send_process):
2640 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2641 (write_queue_pop): Fix pointer signedness problem.
2642 (send_process): Remove unused local.
2643
96a313a1
CY
26442012-06-17 Chong Yidong <cyd@gnu.org>
2645
2646 * xdisp.c (redisplay_internal): No need to redisplay terminal
2647 frames that are not on top.
2648
20ca2e94
TN
26492012-06-17 Troels Nielsen <bn.troels@gmail.com>
2650
2651 * process.c (make_process): Initialize write_queue.
2652 (write_queue_push, write_queue_pop): New functions.
2653 (send_process): Use them to maintain correct ordering of process
2654 writes (Bug#10815).
2655
9a900ca9
PE
26562012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2657
310fbfa8
PE
2658 * lisp.h (eassert): Assume C89 or later.
2659 This removes the need for CHECK.
2660 (CHECK): Remove. Its comments about always evaluating its
2661 argument were confusing, as 'eassert' typically does not evaluate
2662 its argument.
2663
27bb1ca4
PE
2664 * coding.c (produce_chars): Use ptrdiff_t, not int.
2665
9a900ca9
PE
2666 * xterm.c (x_draw_underwave): Check for integer overflow.
2667 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2668
41b7f8bc 26692012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2670
2671 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2672 referenced (Bug#11583).
2673
9b0e3eba
AA
26742012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2675
2676 Implement wave-style variant of underlining.
2677 * dispextern.h (face_underline_type): New enum.
2678 (face): Add field for underline type.
2679 * nsterm.m (ns_draw_underwave): New function.
2680 (ns_draw_text_decoration): Use it.
2681 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2682 New functions.
2683 (x_draw_glyph_string): Use them.
2684 * xfaces.c (Qline, Qwave): New Lisp objects.
2685 (check_lface_attrs, merge_face_ref)
1053a871
SM
2686 (Finternal_set_lisp_face_attribute, realize_x_face):
2687 Handle wave-style underline face attributes.
9b0e3eba
AA
2688 * xterm.c (x_draw_underwave): New function.
2689 (x_draw_glyph_string): Use it.
2690
0fb52f11
JB
26912012-06-16 Juanma Barranquero <lekktu@gmail.com>
2692
2693 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2694 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2695 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2696 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2697 ($(BLD)/w32select.$(O)): Update dependencies.
2698
e5560ff7
AS
26992012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2700
2701 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2702 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2703 * character.c (_fetch_multibyte_char_p): Remove.
2704 * alloc.c: Include "character.h" before "buffer.h".
2705 * bidi.c: Likewise.
2706 * buffer.c: Likewise.
2707 * bytecode.c: Likewise.
2708 * callint.c: Likewise.
2709 * callproc.c: Likewise.
2710 * casefiddle.c: Likewise.
2711 * casetab.c: Likewise.
2712 * category.c: Likewise.
2713 * cmds.c: Likewise.
2714 * coding.c: Likewise.
2715 * composite.c: Likewise.
2716 * dired.c: Likewise.
2717 * dispnew.c: Likewise.
2718 * doc.c: Likewise.
2719 * dosfns.c: Likewise.
2720 * editfns.c: Likewise.
2721 * emacs.c: Likewise.
2722 * fileio.c: Likewise.
2723 * filelock.c: Likewise.
2724 * font.c: Likewise.
2725 * fontset.c: Likewise.
2726 * fringe.c: Likewise.
2727 * indent.c: Likewise.
2728 * insdel.c: Likewise.
2729 * intervals.c: Likewise.
2730 * keyboard.c: Likewise.
2731 * keymap.c: Likewise.
2732 * lread.c: Likewise.
2733 * macros.c: Likewise.
2734 * marker.c: Likewise.
2735 * minibuf.c: Likewise.
2736 * nsfns.m: Likewise.
2737 * nsmenu.m: Likewise.
2738 * print.c: Likewise.
2739 * process.c: Likewise.
2740 * regex.c: Likewise.
2741 * region-cache.c: Likewise.
2742 * search.c: Likewise.
2743 * syntax.c: Likewise.
2744 * term.c: Likewise.
2745 * textprop.c: Likewise.
2746 * undo.c: Likewise.
2747 * unexsol.c: Likewise.
2748 * w16select.c: Likewise.
2749 * w32fns.c: Likewise.
2750 * w32menu.c: Likewise.
2751 * window.c: Likewise.
2752 * xdisp.c: Likewise.
2753 * xfns.c: Likewise.
2754 * xmenu.c: Likewise.
2755 * xml.c: Likewise.
2756 * xselect.c: Likewise.
2757
2f07e6af
EZ
27582012-06-16 Eli Zaretskii <eliz@gnu.org>
2759
1053a871
SM
2760 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2761 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2762 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2763 row.
2764 (handle_face_prop): Use chunk-relative overlay string index when
2765 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2766 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2767 the rightmost. (Bug#11720)
2f07e6af 2768
29b83cec
AS
27692012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2770
2771 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2772 (CATEGORY_MEMBER): Enforce 1/0 value.
2773 * category.c (_temp_category_set): Remove.
2774
4c5501e9
EZ
27752012-06-16 Eli Zaretskii <eliz@gnu.org>
2776
2777 * window.c (Fdelete_other_windows_internal)
2778 (Fdelete_window_internal): Don't access frame's mouse highlight
2779 info of the initial frame. (Bug#11677)
2780
2b570124
PE
27812012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2782
e93864f9
PE
2783 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2784 Assume USE_2_TAGS_FOR_INTS.
2785 (xreload): Adjust $tagmask width to match recent lisp.h change.
2786
2b570124
PE
2787 Simplify lisp.h in minor ways that should not affect code.
2788 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2789 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2790 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2791 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2792 (INTTYPEBITS): New macro, for clarity.
2793 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2794 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2795 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2796 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2797 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2798
81755f69
JB
27992012-06-13 Juanma Barranquero <lekktu@gmail.com>
2800
2801 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2802
16192a57
GM
28032012-06-13 Glenn Morris <rgm@gnu.org>
2804
2805 * s/bsd-common.h (BSD4_3):
2806 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2807
646b5f55
AS
28082012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2809
2810 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2811 instead of union.
2812 (XLI, XIL): Define.
1053a871
SM
2813 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2814 Use them.
2815 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2816 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2817 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2818 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2819 * frame.c (delete_frame): Remove outdated comment.
2820 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2821 USE_LISP_UNION_TYPE.
2822 (Fw32_unregister_hot_key): Likewise.
2823 (Fw32_toggle_lock_key): Likewise.
2824 * w32menu.c (add_menu_item): Likewise.
2825 (w32_menu_display_help): Use XIL instead of checking
2826 USE_LISP_UNION_TYPE.
2827 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2828 (init_heap): Likewise.
2829 * w32term.c (w32_read_socket): Update comment.
2830
1d3823c9
GM
28312012-06-13 Glenn Morris <rgm@gnu.org>
2832
c62ff706
GM
2833 * s/usg5-4-common.h, src/s/unixware.h:
2834 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2835
1d3823c9
GM
2836 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2837
bfe3e0a2
PE
28382012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2839
2840 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2841 * alloc.c (make_number) [!defined make_number]:
2842 Remove, as lisp.h always defines this now.
2843 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2844 (roundup_size): Verify that it is a power of 2.
2845 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2846 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2847 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2848 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2849 USE_LSB_TAG now is always defined to be either 0 or 1.
2850 All uses changed.
2851 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2852 code works fine either way, and efficiency is not a concern here,
2853 as the union type is for debugging, not for production.
2854 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2855 Use an inline function on all platforms when using the union type,
2856 since this is simpler and 'static inline' can be used portably
2857 within Emacs now.
2858 (LISP_INITIALLY_ZERO): New macro.
2859 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2860 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2861
45fa9c0f
GM
28622012-06-12 Glenn Morris <rgm@gnu.org>
2863
b4492cba
GM
2864 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2865
2866 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2867
45fa9c0f
GM
2868 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2869 Move BROKEN_SIGIO to configure.
2870
2871 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2872 Move NO_TERMIO to configure.
2873
0e25d334
CY
28742012-06-12 Chong Yidong <cyd@gnu.org>
2875
2876 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2877 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2878 MagickExportImagePixels is undefined.
2879
43682bb6
PE
28802012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2881
2882 * image.c (imagemagick_load_image): Remove unused label.
2883
a9be7d2b
GM
28842012-06-11 Glenn Morris <rgm@gnu.org>
2885
2886 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2887 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2888 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2889 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2890
3017f87f
SM
28912012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2892
2893 * alloc.c (make_byte_code): New function.
2894 (Fmake_byte_code): Use it. Don't purify here.
2895 * lread.c (read1): Use it as well to avoid extra allocation.
2896
1b9b4cf4
CY
28972012-06-11 Chong Yidong <cyd@gnu.org>
2898
2899 * image.c (imagemagick_load_image): Implement transparency.
2900
95988fcf
AS
29012012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2902
2903 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2904 account for preceding backslashes. (Bug#11663)
2905
cd4eb164
CY
29062012-06-09 Chong Yidong <cyd@gnu.org>
2907
2908 * term.c: Support italics in capable terminals (Bug#9652).
2909 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2910 (turn_on_face): Output using TS_enter_italic_mode if available.
2911 Don't handle unused blinking and alt-charset cases.
2912 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2913 and tty_alt_charset_p cases.
2914 (tty_capable_p, init_tty): Support italics.
2915
2916 * termchar.h (struct tty_display_info): Add field for italics.
2917 Remove unused blink field.
2918
2919 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2920 Handle slant.
2921
2922 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2923 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2924 tty_alt_charset_p. Add tty_italic_p.
2925
ff88beb8
MA
29262012-06-09 Michael Albinus <michael.albinus@gmx.de>
2927
2928 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2929 dbus_type_is_basic if available.
2930 (xd_extract_signed, xd_extract_unsigned): Rename from
2931 extract_signed and extract_unsigned, respectively. Adapt callers.
2932
44286096
CY
29332012-06-09 Chong Yidong <cyd@gnu.org>
2934
1682701f
CY
2935 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2936
44286096
CY
2937 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2938 case (Bug#9752).
2939
d86feb17
PE
29402012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2941
2942 * xdisp.c (vmessage): Treat frame message as multibyte.
2943 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2944 would generate the diagnostic "Making \302\247 buffer-local while
2945 let-bound!".
2946
d5c20fe8
EZ
29472012-06-08 Eli Zaretskii <eliz@gnu.org>
2948
2949 * dispnew.c (showing_window_margins_p): Undo last change, which
2950 was done due to an inadvertent commit.
2951 (adjust_frame_glyphs_for_frame_redisplay): Do call
2952 showing_window_margins_p.
2953
513749ee
SM
29542012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2955
2956 * eval.c (Fmake_var_non_special): New primitive.
2957 (syms_of_eval): Defsubr it.
2958 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2959
d4a8f5c1
JB
29602012-06-08 Juanma Barranquero <lekktu@gmail.com>
2961
2962 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2963 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2964
8bbbc977
EZ
29652012-06-08 Eli Zaretskii <eliz@gnu.org>
2966
2967 * alloc.c (allocate_vectorlike): Fix last change.
2968
f3372c87
DA
29692012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2970
2971 Block-based vector allocation of small vectors.
2972 * lisp.h (struct vectorlike_header): New field `nbytes',
2973 adjust comment accordingly.
2974 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2975 to denote vector blocks. Adjust users (live_vector_p,
2976 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2977 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2978 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2979 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2980 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2981 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2982 (roundup_size): New constant.
2983 (struct vector_block): New data type.
2984 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2985 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2986 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2987 (sweep_vectors): New functions.
2988 (allocate_vectorlike): Return `zero_vector' as the only vector of
2989 0 items. Allocate new vector from block if vector size is less than
2990 or equal to VBLOCK_BYTES_MAX.
2991 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2992 (init_alloc_once): Add call to init_vectors.
2993
4f18a4ed
SM
29942012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2995
2996 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2997
86f158bc
PE
29982012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2999
3000 * doprnt.c (doprnt): Truncate multibyte char correctly.
3001 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3002 would mishandle a string argument "Xc" if X was a multibyte
3003 character of length 2: it would truncate after X's first byte
3004 rather than including all of X.
3005
c5cfcbe0
CY
30062012-06-06 Chong Yidong <cyd@gnu.org>
3007
3008 * buffer.c (word_wrap): Doc fix.
3009
c05cf390
PE
30102012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3011
3012 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3013
0c3461de
GM
30142012-06-03 Glenn Morris <rgm@gnu.org>
3015
3016 * xdisp.c (tool-bar-style): Doc fix.
3017
c71232db
UM
30182012-06-03 Ulrich Müller <ulm@gentoo.org>
3019
3020 * Makefile.in (PAXCTL): Define.
3021 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3022 binary via PaX flags if the paxctl utility is available.
3023 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3024 Restore PaX flags to their default. (Bug#11398)
3025
383f7350
CY
30262012-06-03 Chong Yidong <cyd@gnu.org>
3027
3028 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3029 buffer (Bug#11226).
3030
5f2c76c6
CY
30312012-06-03 Chong Yidong <cyd@gnu.org>
3032
3033 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3034 (note_mode_line_or_margin_highlight): If there is no help echo,
3035 use mode-line-default-help-echo. Handle the case where the mouse
3036 position is past the end of the mode line string.
3037
3038 * buffer.c (buffer_local_value_1): New function, split from
3039 Fbuffer_local_value; can return Qunbound.
3040 (Fbuffer_local_value): Use it.
3041 (Vmode_line_format): Docstring tweaks.
3042
773d47f6
PE
30432012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 * sysdep.c (system_process_attributes): Improve comment.
3046
f2d6a3df
SM
30472012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3048
3049 * keyboard.c: Export real-this-command to Elisp.
3050 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3051 and DEFVAR it. Update all users.
3052
63810350
PE
30532012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3054
7bd5c1f4
PE
3055 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3056
63810350
PE
3057 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3058 Convert pctcpu and pctmem to Lisp float properly.
3059 Let the compiler fold better, as 100.0/0x8000 is exact.
3060
a2821611
AS
30612012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3062
3063 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3064 cons_block.
3065
5fceba1d
PE
30662012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3069
c98ff5dd
DA
30702012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3071
3072 For a 'struct window', replace some Lisp_Object fields to
3073 bitfields where appropriate, remove unused fields.
3074 * window.h (struct window): Remove unused 'last_mark_x' and
3075 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3076 change it's type from Lisp_Object to bitfield.
3077 Change type of 'force_start', 'optional_new_start',
3078 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3079 fields from Lisp_Object to bitfield. Adjust users accordingly.
3080
ca34e0be
PE
30812012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 Pacify gcc -Wdouble-precision when using Xaw.
3084 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3085 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3086 Use 'float' consistently, rather than 'float' in most places
3087 and 'double' in a couple of places.
3088
efc00ab1 30892012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3090
3091 * xdisp.c (handle_stop): Detect whether we have overlay strings
3092 loaded by testing it->current.overlay_string_index to be
3093 non-negative, instead of checking whether n_overlay_strings is
3094 positive. (Bug#11587)
3095
efc00ab1 30962012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3097
3098 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3099
3100 * doc.c (Fsubstitute_command_keys): Doc fix.
3101
efc00ab1 31022012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3103
3104 * search.c (search_buffer): Remove calls to
3105 r_alloc_inhibit_buffer_relocation, as it is now called by
3106 maybe_unify_char, which was the cause of relocation of buffer text
3107 in bug#11519.
3108
efc00ab1 31092012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3110
3111 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3112 for the duration of call to load_charset, to avoid problems with
3113 callers of maybe_unify_char that access buffer text through C
3114 pointers.
3115
3116 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3117 decrement the inhibition flag, instead of just setting or
3118 resetting it.
3119
ba93a187
PE
31202012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3121
3122 Remove obsolete '#define static' cruft.
3123 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3124 This #undef was "temporary" in 2000; it is no longer needed
3125 now that '#define static' has gone away.
3126 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3127 (gray_bitmap_bits): Remove; no longer needed.
3128 All uses replaced with definiens.
3129 * xterm.c: Include "bitmaps/gray.xbm".
3130
9e4bf381
PE
31312012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3132
3133 Clean up __executable_start, monstartup when --enable-profiling.
3134 The following changes affect the code only when profiling.
3135 * dispnew.c (__executable_start): Rename from safe_bcopy.
3136 Define only on platforms that need it.
3137 * emacs.c: Include <sys/gmon.h> when profiling.
3138 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3139 (__executable_start): Remove decl, since lisp.h does it now.
3140 (safe_bcopy): Remove decl; no longer has that name.
3141 (main): Coalesce #if into single bit of code, for simplicity.
3142 Cast pointers to uintptr_t, since standard libraries want integers
3143 and not pointers.
3144 * lisp.h (__executable_start): New decl.
3145
32d72c2f
GM
31462012-05-31 Glenn Morris <rgm@gnu.org>
3147
3148 * image.c (Fimagemagick_types): Doc fix.
3149
baac5bc7
JM
31502012-05-30 Jim Meyering <meyering@redhat.com>
3151
3152 * callproc.c (Fcall_process_region): Include directory component
3153 in mkstemp error message (Bug#11586).
3154
72cb32cf
PE
31552012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3156
3157 * alloc.c, lisp.h (make_pure_vector): Now static.
3158
61b108cc
SM
31592012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3160
3161 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3162 Move to byte-run.el.
3163 (Fautoload): Do the hash-doc more carefully.
3164 * data.c (Fdefalias): Purify definition, except for keymaps.
3165 (Qdefun): Move from eval.c.
3166 * lisp.h (Qdefun): Remove.
3167 * lread.c (read1): Tiny simplification.
3168
471fe23d
TN
31692012-05-29 Troels Nielsen <bn.troels@gmail.com>
3170
934f3f58 3171 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3172 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3173 Bug#9642, but explicitly check that the buffer the overlay would
3174 be moved to is live and rearrange lines to make sure that errors
3175 will not put the overlay in an inconsistent state.
3176 (Fdelete_overlay): Cosmetics.
3177
85d0efd1
EZ
31782012-05-28 Eli Zaretskii <eliz@gnu.org>
3179
3180 * w32term.c (my_bring_window_to_top): New function.
3181 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3182 could be different from the original one.
3183 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3184 (Bug#11513)
3185
3186 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3187 by calling BringWindowToTop.
3188
3189 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3190 (WM_EMACS_END): Increase by one.
3191
da92a98c
PE
31922012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3193
3194 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3195 This avoids undefined behavior that might cause the eassert
3196 to not catch an out-of-range value.
3197
74d1f848
JB
31982012-05-28 Juanma Barranquero <lekktu@gmail.com>
3199
3200 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3201 Update dependencies.
3202
9e1a06fc
EZ
32032012-05-27 Eli Zaretskii <eliz@gnu.org>
3204
3205 * bidi.c (bidi_mirror_char): Fix last change.
3206
f3dd7312
AS
32072012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3208
3209 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3210 when referring to sectname field in printf format.
3211
81899c91
PE
32122012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3213
57b81a9f
PE
3214 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3215 Only r_alloc_inhibit_buffer_relocation needed to be added;
3216 the others were already declared.
3217
81899c91
PE
3218 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3219 before checking whether it's out of range. Put the check inside
3220 eassert. See
3221 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3222
33017faf 32232012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3224
3225 * callproc.c (Fcall_process): Restore a line that was accidentally
3226 commented out in the 2011-02-13 change (bug#11547).
3227
33017faf 32282012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3229
3230 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3231 defined on ralloc.c.
3232
3233 * buffer.c [REL_ALLOC]: Remove prototypes of
3234 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3235 they are now on lisp.h.
3236
3237 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3238
3239 * search.c (search_buffer): Use it to inhibit relocation of buffer
3240 text while re_search_2 is doing its job, because re_search_2 is
3241 passed C pointers to buffer text. (Bug#11519)
3242
23415acf
EZ
3243 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3244 Update value to 24.
3245
44e27368
EZ
3246 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3247 state after an additional call to move_it_in_display_line_to, keep
3248 the values of it->max_ascent and it->max_descent found for the
3249 entire line.
3250 (pos_visible_p): Revert the comparison against bottom_y to what it
3251 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3252 (Bug#11464)
3253
c1892f11
PE
32542012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3255
3256 Fix coding-related core dumps with gcc -ftrapv.
3257 The code was computing A - B, where A and B are pointers, and B is
3258 random garbage. This can lead to core dumps on platforms that
3259 have special pointer registers, and it also leads to core dumps on
3260 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3261 A - B only when B is initialized properly.
3262 * coding.c (coding_set_source, coding_set_destination): Return void.
3263 (coding_change_source, coding_change_destinations): New functions,
3264 with the old behaviors of coding_set_source and coding_set_destination.
3265 All callers that need an offset changed to use these new functions.
3266
eb7afdad
GM
32672012-05-26 Glenn Morris <rgm@gnu.org>
3268
3269 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3270
f12fdf02
EZ
32712012-05-26 Eli Zaretskii <eliz@gnu.org>
3272
53a63be6 3273 Extend mouse support on W32 text-mode console.
61b108cc
SM
3274 * xdisp.c (draw_row_with_mouse_face):
3275 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3276
eb3f6f01 3277 * w32console.c: Include window.h.
61b108cc
SM
3278 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3279 New functions.
eb3f6f01
EZ
3280 (initialize_w32_display): Initialize mouse-highlight data.
3281
53a63be6
EZ
3282 * w32inevt.c: Include termchar.h and window.h.
3283 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3284 moves, call note_mouse_highlight. If help_echo changed, call
3285 gen_help_event to produce help-echo message in the echo area.
3286 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3287 highlight info.
3288
4cfd81f6
PE
32892012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3290
3291 * lread.c (read1): Simplify slightly to avoid an overflow warning
3292 with GCC 4.7.0 on x86-64.
3293
4446092a
EZ
32942012-05-26 Eli Zaretskii <eliz@gnu.org>
3295
3296 * bidi.c (bidi_mirror_char): Revert last change: an int is
3297 definitely wide enough here.
3298
42b2a986 32992012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3300
42b2a986 3301 Fix integer width and related bugs (Bug#9874).
eb106a49 3302 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3303 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3304 (string_bytes, check_sblock, allocate_string_data):
3305 (compact_small_strings, Fmake_bool_vector, make_string)
3306 (make_unibyte_string, make_multibyte_string)
3307 (make_string_from_bytes, make_specified_string)
3308 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3309 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3310 (mark_vectorlike):
3311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3312 (allocate_pseudovector):
3313 Use int, not EMACS_INT, where int is wide enough.
3314 (inhibit_garbage_collection, Fgarbage_collect):
3315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3316 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3317 int might not be wide enough.
3318 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3319 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3320 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3321 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3322 (bidi_level_of_next_char, bidi_move_to_visually_next):
3323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3324 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3325 (Fkill_buffer, Fset_buffer_major_mode)
3326 (advance_to_char_boundary, Fbuffer_swap_text)
3327 (Fset_buffer_multibyte, overlays_at, overlays_in)
3328 (overlay_touches_p, struct sortvec, record_overlay_string)
3329 (overlay_strings, recenter_overlay_lists)
3330 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3331 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3332 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3333 (Foverlay_recenter, last_overlay_modification_hooks_used)
3334 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3336 (validate_region): Omit unnecessary test for b <= e,
3337 since that's guaranteed by the previous test.
d311d28c
PE
3338 (adjust_overlays_for_delete): Avoid pos + length overflow.
3339 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3340 (report_overlay_modification):
3341 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3342 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3343 Omit pointer cast, which isn't needed anyway, and doesn't work
3344 after the EMACS_INT -> ptrdiff_t change.
02481186 3345 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3346 * buffer.h: Adjust decls to match defn changes elsewhere.
3347 (struct buffer_text, struct buffer):
3348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3349 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3350 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3351 not int, to avoid needless 32-bit limit on 64-bit hosts.
3352 (exec_byte_code): Use tighter memory-full test, one that checks
3353 for alloca overflow. Don't compute the address of the object just
3354 before an array, as that's not portable. Use EMACS_INT, not
3355 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3356 * callint.c (Fcall_interactively):
3357 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3358 * callproc.c (call_process_kill, Fcall_process):
3359 Don't assume pid_t fits into an Emacs fixnum.
3360 (call_process_cleanup, Fcall_process, child_setup):
3361 Don't assume pid_t fits into int.
3362 (call_process_cleanup, Fcall_process, delete_temp_file)
3363 (Fcall_process_region):
3364 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3365 (Fcall_process): Simplify handling of volatile integers.
3366 Use int, not EMACS_INT, where int will do.
3367 * casefiddle.c (casify_object, casify_region, operate_on_word)
3368 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3369 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3370 (casify_object): Avoid integer overflow when overallocating buffer.
3371 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3372 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3373 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3374 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3375 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3376 integers are now checked earlier. All uses replaced with XINT.
3377 (ccl_driver):
3378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3379 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3380 (ccl_driver, Fregister_code_conversion_map):
3381 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3382 (resolve_symbol_ccl_program): Check that vector header is in range.
3383 Always copy the vector, so that we can check its contents reliably
3384 now rather than having to recheck each instruction as it's being
3385 executed. Check that vector words fit in 'int'.
3386 (ccl_get_compiled_code, Fregister_ccl_program)
3387 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3388 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3389 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3390 contents are in range.
3391 (Fccl_execute_on_string): Check that status is in range.
3392 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3393 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3394 Accept and return EMACS_INT, not int, because callers can pass values
3395 out of 'int' range.
3396 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3397 (multibyte_chars_in_text, parse_str_as_multibyte)
3398 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3399 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3400 (string_escape_byte8, Fget_byte):
3401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3402 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3403 avoid mishandling large integers.
3404 * character.h: Adjust decls to match defn changes elsewhere.
3405 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3406 (Ffind_charset_region):
3407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3408 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3409 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3410 Don't assume fixnum fits in int.
d311d28c
PE
3411 (load_charset_map_from_vector, Fmap_charset_chars):
3412 Remove now-unnecessary CHECK_NATNUMs.
3413 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3414 Don't rely on undefined behavior with signed left shift overflow.
3415 Don't assume unsigned int fits into fixnum, or that fixnum fits
3416 into unsigned int. Don't require max_code to be a valid fixnum;
3417 that's not true for gb10830 4-byte on a 32-bit host. Allow
3418 invalid_code to be a cons, for the same reason. Require code_offset
3419 to be a character. Avoid int overflow if max_char is close
3420 to INT_MAX.
3421 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3422 this is intended anyway and avoids some undefined behavior.
3423 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3424 INDEX_TO_CODE_POINT, as that's what it expects.
3425 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3426 * charset.h (DECODE_CHAR): Return int, not unsigned;
3427 this is what was intended anyway, and it avoids undefined behavior.
3428 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3429 integer-overflow issues.
3430 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3431 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3432 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3433 * chartab.c (Fmake_char_table, Fset_char_table_range)
3434 (uniprop_get_decoder, uniprop_get_encoder):
3435 Don't assume fixnum fits in int.
3436 * cmds.c (move_point): New function, that does the gist of
3437 Fforward_char and Fbackward_char, but does so while checking
3438 for integer overflow more accurately.
c96e5d6a 3439 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3440 (Fforward_line, Fend_of_line, internal_self_insert)
3441 (internal_self_insert):
3442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3443 Fix a FIXME, by checking for integer overflow when calculating
3444 target_clm and actual_clm.
3445 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3446 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3447 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3448 (coding_alloc_by_making_gap, alloc_destination)
3449 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3450 (encode_coding_utf_16, detect_coding_emacs_mule)
3451 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3452 (detect_coding_iso_2022, decode_coding_iso_2022)
3453 (encode_invocation_designation, encode_designation_at_bol)
3454 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3455 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3456 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3457 (encode_coding_ccl, encode_coding_raw_text)
3458 (detect_coding_charset, decode_coding_charset)
3459 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3460 (produce_composition, produce_charset, produce_annotation)
3461 (decode_coding, handle_composition_annotation)
3462 (handle_charset_annotation, consume_chars, decode_coding_gap)
3463 (decode_coding_object, encode_coding_object, detect_coding_system)
3464 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3465 (code_convert_region, code_convert_string)
8f50130c
PE
3466 (Fdefine_coding_system_internal)
3467 (coding_set_source, coding_set_destination):
d311d28c
PE
3468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3469 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3470 (Fdefine_coding_system_internal):
3471 Don't assume fixnums fit in int.
3472 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3473 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3474 (Funencodable_char_position, Fcheck_coding_systems_region)
3475 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3477 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3478 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3479 Don't access memory outside of the args array.
d311d28c 3480 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3481 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3482 result of ENCODE_CHAR.
d311d28c
PE
3483 * coding.h: Adjust decls to match defn changes elsewhere.
3484 (struct coding_system):
3485 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3486 * composite.c (get_composition_id, find_composition)
3487 (run_composition_function, update_compositions)
3488 (compose_text, composition_gstring_put_cache)
3489 (composition_gstring_p, composition_gstring_width)
3490 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3491 (composition_compute_stop_pos, composition_reseat_it)
3492 (composition_update_it, struct position_record)
3493 (find_automatic_composition, composition_adjust_point)
3494 (Fcomposition_get_gstring, Ffind_composition_internal):
3495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3496 (update_compositions):
3497 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3498 * composite.h: Adjust decls to match defn changes elsewhere.
3499 (struct composition):
3500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3501 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3502 Do not attempt to compute the address of the object just before a
3503 buffer; this is not portable.
3504 (Faref, Faset):
3505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3506 (Faset): Use int, not EMACS_INT, where int is wide enough.
3507 (Fstring_to_number): Don't assume fixnums fit in int.
3508 (Frem): Don't assume arg is nonnegative.
3509 * dbusbind.c (xd_append_arg): Check for integers out of range.
3510 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3511 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3512 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3513 (xd_get_connection_references): Return ptrdiff_t, not int.
3514 All uses changed.
3515 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3516 (xd_read_message_1):
3517 Use int, not unsigned, where the dbus API uses int.
3518 (Fdbus_message_internal): Don't overflow mtype.
3519 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3520 * dired.c (directory_files_internal, file_name_completion, scmp)
3521 (file_name_completion_stat):
3522 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3523 (file_name_completion): Don't overflow matchcount.
3524 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3525 * dispextern.h: Adjust decls to match defn changes elsewhere.
3526 (struct text_pos, struct glyph, struct bidi_saved_info)
3527 (struct bidi_string_data, struct bidi_it, struct composition_it)
3528 (struct it):
3529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3530 (struct display_pos, struct composition_it, struct it):
3531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3532 * dispnew.c (increment_matrix_positions)
3533 (increment_row_positions, mode_line_string)
3534 (marginal_area_string):
3535 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3536 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3538 (duration_to_sec_usec): New function, to check for overflow better.
3539 (Fsleep_for, sit_for): Use it.
3540 * doc.c (get_doc_string, store_function_docstring):
3541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3542 (get_doc_string, Fsnarf_documentation):
3543 Use int, not EMACS_INT, where int is wide enough.
3544 (get_doc_string):
3545 Use SAFE_ALLOCA, not alloca.
3546 Check for overflow when converting EMACS_INT to off_t.
3547 * doprnt.c (doprnt):
3548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3549 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3550 Don't assume uid_t fits into fixnum.
3551 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3552 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3553 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3554 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3555 (general_insert_function)
3556 (Finsert_char, make_buffer_string, make_buffer_string_both)
3557 (update_buffer_properties, Fbuffer_substring)
3558 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3559 (Fsubst_char_in_region, check_translation)
3560 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3561 (transpose_markers, Ftranspose_regions):
3562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3563 (clip_to_bounds): Move to lisp.h as an inline function).
3564 (Fconstrain_to_field): Don't assume integers are nonnegative.
3565 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3566 (Fsubst_char_in_region, Fsave_restriction):
3567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3568 (Femacs_pid): Don't assume pid_t fits into fixnum.
3569 (lo_time): Use int, not EMACS_INT, when int suffices.
3570 (lisp_time_argument): Check for usec out of range.
3571 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3572 (Fuser_login_name, Fuser_full_name): Signal an error
3573 if a uid argument is out of range, rather than relying on
3574 undefined behavior.
c8d5c857
PE
3575 (Fformat_time_string): Remove now-unnecessary check.
3576 lisp_time_argument checks for out-of-range usec now.
243e0530 3577 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3578 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3579 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3580 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3581 (init_cmdargs, Fdump_emacs):
3582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3583 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3584 the bottom (typically) 32 bits of the fixnum.
3585 * eval.c (specpdl_size, call_debugger):
3586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3587 (when_entered_debugger, Fbacktrace_debug):
3588 Don't assume fixnum can fit in int.
3589 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3590 the object just before a buffer; this is not portable.
3591 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3592 (grow_specpdl, unbind_to):
3593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3594 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3595 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3596 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3597 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3598 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3600 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3601 (a_write, e_write):
3602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3603 (Fcopy_file, non_regular_nbytes, read_non_regular)
3604 (Finsert_file_contents):
3605 Use int, not EMACS_INT, where int is wide enough.
3606 (READ_BUF_SIZE): Verify that it fits in int.
3607 (Finsert_file_contents): Check that counts are in proper range,
3608 rather than assuming fixnums fit into ptrdiff_t etc.
3609 Don't assume fixnums fit into int.
125b3835 3610 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3611 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3612 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3613 (string_char_to_byte, string_byte_to_char)
3614 (string_make_multibyte, string_to_multibyte)
3615 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3616 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3617 (substring_both, Fdelete, internal_equal, Ffillarray)
3618 (Fclear_string, mapcar1)
3619 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3620 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3621 (larger_vector, make_hash_table, maybe_resize_hash_table)
3622 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3623 (Fmaphash, secure_hash):
3624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3625 (concat): Check for string index and length overflow.
3626 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3627 (Frequire):
3628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3629 (larger_vector): New API (vec, incr_min, size_max) replaces old
3630 one (vec, new_size, init). This catches size overflow.
3631 INIT was removed because it was always Qnil.
3632 All callers changed.
3633 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3634 the upper bound on a hash table index size.
3635 (make_hash_table, maybe_resize_hash_table): Use it.
3636 (secure_hash): Computer start_byte and end_byte only after
3637 they're known to be in ptrdiff_t range.
3638 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3639 (Ffont_get_glyphs, Ffont_at):
3640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3641 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3642 (Flist_fonts, Fopen_font):
3643 Don't assume fixnum can fit in int.
3644 (check_gstring): Don't assume index can fit in int.
3645 (font_match_p): Check that fixnum is a character, not a nonnegative
3646 fixnum, since the later code needs to stuff it into an int.
3647 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3648 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3649 conversion overflow issues.
3650 (Fopen_font): Check for integer out of range.
3651 (Ffont_get_glyphs): Don't assume index can fit in int.
3652 * font.h: Adjust decls to match defn changes elsewhere.
3653 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3654 integer overflow.
3655 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3656 printmax_t, where ptrdiff_t is wide enough.
3657 (Finternal_char_font):
3658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3659 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3660 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3661 (Fset_frame_position, x_set_frame_parameters)
3662 (x_set_line_spacing, x_set_border_width)
3663 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3664 Check that fixnums are in proper range for system types.
3665 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3667 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3668 Use SAFE_ALLOCA_LISP, not alloca.
3669 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3670 intptr_t is wide enough.
3671 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3672 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3673 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3674 Check for fixnum out of range.
3675 * ftfont.c (ftfont_list): Don't assume index fits in int.
3676 Check that fixnums are in proper range for system types.
3677 (ftfont_shape_by_flt):
3678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3679 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3681 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3682 Check that fixnums are in proper range for system types.
3683 * gnutls.h: Adjust decls to match defn changes elsewhere.
3684 * gtkutil.c (xg_dialog_run):
3685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3686 (update_frame_tool_bar):
3687 Check that fixnums are in proper range for system types.
3688 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3689 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3690 * indent.c (last_known_column, last_known_column_point):
3691 (current_column_bol_cache):
3692 (skip_invisible, current_column, check_display_width):
3693 (check_display_width, scan_for_column, current_column_1)
3694 (Findent_to, Fcurrent_indentation, position_indentation)
3695 (indented_beyond_p, Fmove_to_column, compute_motion):
3696 (Fcompute_motion, Fvertical_motion):
3697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3698 (last_known_column_modified): Use EMACS_INT, not int.
3699 (check_display_width):
3700 (Fcompute_motion):
3701 Check that fixnums and floats are in proper range for system types.
3702 (compute_motion): Don't assume index or fixnum fits in int.
3703 (compute_motion, Fcompute_motion):
3704 Use int, not EMACS_INT, when it is wide enough.
3705 (vmotion): Omit local var start_hpos that is always 0; that way
3706 we don't need to worry about overflow in expressions involving it.
3707 * indent.h: Adjust decls to match defn changes elsewhere.
3708 (struct position):
3709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3710 Use int, not EMACS_INT, where int is wide enough.
3711 Remove unused members ovstring_chars_done and tab_offset;
3712 all uses removed.
3713 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3714 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3715 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3716 (make_gap, copy_text, insert, insert_and_inherit)
3717 (insert_before_markers, insert_before_markers_and_inherit)
3718 (insert_1, count_combining_before, count_combining_after)
3719 (insert_1_both, insert_from_string)
3720 (insert_from_string_before_markers, insert_from_string_1)
3721 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3722 (adjust_after_replace, adjust_after_insert, replace_range)
3723 (replace_range_2, del_range, del_range_1, del_range_byte)
3724 (del_range_both, del_range_2, modify_region)
3725 (prepare_to_modify_buffer, signal_before_change)
3726 (signal_after_change, Fcombine_after_change_execute):
3727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3728 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3729 (balance_an_interval, split_interval_right, split_interval_left)
3730 (find_interval, next_interval, update_interval)
3731 (adjust_intervals_for_insertion, delete_node, delete_interval)
3732 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3733 (static_offset_intervals, offset_intervals)
3734 (merge_interval_right, merge_interval_left, make_new_interval)
3735 (graft_intervals_into_buffer, temp_set_point_both)
3736 (temp_set_point, set_point, adjust_for_invis_intang)
3737 (set_point_both, move_if_not_intangible, get_property_and_range)
3738 (get_local_map, copy_intervals, copy_intervals_to_string)
3739 (compare_string_intervals, set_intervals_multibyte_1):
3740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3741 * intervals.h: Adjust decls to match defn changes elsewhere.
3742 (struct interval):
3743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3744 * keyboard.c (this_command_key_count, this_single_command_key_start)
3745 (before_command_key_count, before_command_echo_length, echo_now)
3746 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3747 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3748 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3749 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3751 (last_non_minibuf_size, last_point_position, echo_truncate)
3752 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3753 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3754 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3755 (stuff_buffered_input):
3756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3757 (last_auto_save, command_loop_1, read_char):
3758 Use EMACS_INT, not int, to avoid integer overflow.
3759 (record_char): Avoid overflow in total_keys computation.
3760 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3761 * keyboard.h: Adjust decls to match defn changes elsewhere.
3762 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3763 (Fkey_description, Fdescribe_vector, Flookup_key):
3764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3765 (click_position): New function, to check that positions are in range.
3766 (Fcurrent_active_maps):
3767 (describe_command):
3768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3769 (Faccessible_keymaps, Fkey_description):
3770 (preferred_sequence_p):
3771 Don't assume fixnum can fit into int.
3772 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3773 Check for integer overflow in size calculations.
3774 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3775 avoid mishandling large integers.
3776 * lisp.h: Adjust decls to match defn changes elsewhere.
3777 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3778 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3779 (struct Lisp_Marker):
3780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3781 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3782 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3783 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3784 All callers changed.
3785 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3786 Assume the arg has valid form, since it always does.
3787 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3788 unsigned integer system type.
3789 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3790 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3792 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3793 (duration_to_sec_usec): New decl.
3794 * lread.c (read_from_string_index, read_from_string_index_byte)
3795 (read_from_string_limit, readchar, unreadchar, openp)
3796 (read_internal_start, read1, oblookup):
3797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3798 (Fload, readevalloop, Feval_buffer, Feval_region):
3799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3800 (openp): Check for out-of-range argument to 'access'.
3801 (read1): Use int, not EMACS_INT, where int is wide enough.
3802 Don't assume fixnum fits into int.
6efdadfd 3803 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3804 (read_filtered_event): Use duration_to_sec_usec
3805 to do proper overflow checking on durations.
d311d28c
PE
3806 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3807 in size calculation.
3808 (Fexecute_kbd_macro):
3809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3810 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3811 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3812 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3813 (set_marker_both, set_marker_restricted_both, marker_position)
3814 (marker_byte_position, Fbuffer_has_markers_at):
3815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3816 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3817 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3818 It now merely ensures that the menu is large enough, without
3819 necessarily growing it, as this avoids some integer overflow issues.
3820 All callers changed.
3821 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3823 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3824 Use SAFE_ALLOCA_LISP, not alloca.
3825 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3826 to EMACS_INT. Check that fixnums are in proper range for system types.
3827 * minibuf.c (minibuf_prompt_width, string_to_object)
3828 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3829 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3830 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3831 (get_minibuffer, read_minibuf_unwind):
3832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3833 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3834 this simplifies overflow checking. All callers changed.
3835 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3836 (Ftest_completion):
3837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3838 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3839 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3840 Check that fixnums are in proper range for system types.
3841 (Fx_create_frame, Fx_show_tip):
3842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3843 * nsfont.m (ns_findfonts, nsfont_list_family):
3844 Don't assume fixnum fits in long.
3845 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3847 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3848 wide enough.
17fdb222 3849 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3851 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3852 (PRINTDECLARE, PRINTPREPARE):
3853 (strout, print_string):
3854 (print, print_preprocess, print_check_string_charset_prop)
3855 (print_object):
3856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3857 (PRINTDECLARE):
3858 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3860 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3861 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3862 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3863 (print_error_message): Use SAFE_ALLOCA, not alloca.
3864 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3865 (print_depth, new_backquote_output, print_number_index):
3866 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3867 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3868 (Fset_process_window_size, Fformat_network_address)
3869 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3870 (sigchld_handler):
d311d28c 3871 Check that fixnums are in proper range for system types.
d44287d4 3872 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3873 Check for process-ids out of pid_t range rather than relying on
3874 undefined behavior.
e4d81efc 3875 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3876 (Fformat_network_address, read_process_output, send_process)
3877 (Fprocess_send_region, status_notify):
3878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3879 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3880 (wait_reading_process_output, read_process_output, exec_sentinel):
3881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3882 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3883 (Faccept_process_output): Use duration_to_sec_usec to do proper
3884 overflow checking on durations.
dde14581
PE
3885 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3886 Don't assume pid_t fits in int.
02481186
PE
3887 * process.h (struct Lisp_Process): Members tick and update_tick
3888 are now of type EMACS_INT, not int.
b62b53e8
PE
3889 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3890 configured --with-wide-int.
d311d28c
PE
3891 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3892 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3893 * search.c (looking_at_1, string_match_1):
3894 (fast_string_match, fast_c_string_match_ignore_case)
3895 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3896 (scan_newline, find_before_next_newline, search_command)
3897 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3898 (set_search_regs, wordify):
3899 (Freplace_match):
3900 (Fmatch_data):
3901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3902 (string_match_1, search_buffer, set_search_regs):
3903 (Fmatch_data):
3904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3905 (wordify): Check for overflow in size calculation.
3906 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3907 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3908 Check that fixnums are in proper range for system types.
3909 * sound.c (struct sound_device)
3910 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3912 (Fplay_sound_internal):
3913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3914 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3915 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3916 (Fparse_partial_sexp):
3917 Don't assume fixnums can fit in int.
3918 (struct lisp_parse_state, find_start_pos, find_start_value)
3919 (find_start_value_byte, find_start_begv)
3920 (update_syntax_table, char_quoted, dec_bytepos)
3921 (find_defun_start, prev_char_comend_first, back_comment):
3922 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3923 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3924 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3925 (Finternal_describe_syntax_value): Check that match_lisp is a
3926 character, not an integer, since the code stuffs it into int.
3927 (scan_words, scan_sexps_forward):
3928 Check that fixnums are in proper range for system types.
3929 (Fforward_word):
3930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3931 (scan_sexps_forward):
3932 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3933 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3934 * syntax.h: Adjust decls to match defn changes elsewhere.
3935 (struct gl_state_s):
3936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3937 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3938 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3939 * sysdep.c (wait_for_termination_1, wait_for_termination)
3940 (interruptible_wait_for_termination, mkdir):
3941 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3942 (emacs_read, emacs_write):
3943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3944 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3945 and double all fit in int.
d311d28c
PE
3946 * term.c (set_tty_color_mode):
3947 Check that fixnums are in proper range for system types.
3948 * termhooks.h (struct input_event):
3949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3950 * textprop.c (validate_interval_range, interval_of)
3951 (Fadd_text_properties, set_text_properties_1)
3952 (Fremove_text_properties, Fremove_list_of_text_properties)
3953 (Ftext_property_any, Ftext_property_not_all)
3954 (copy_text_properties, text_property_list, extend_property_ranges)
3955 (verify_interval_modification):
3956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3957 (Fnext_single_char_property_change)
3958 (Fprevious_single_char_property_change):
3959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3960 (copy_text_properties):
3961 Check for integer overflow in index calculation.
d311d28c
PE
3962 * undo.c (last_boundary_position, record_point, record_insert)
3963 (record_delete, record_marker_adjustment, record_change)
3964 (record_property_change):
3965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3966 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3967 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3968 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3969 (Fx_hide_tip, Fx_file_dialog):
3970 * w32menu.c (set_frame_menubar):
3971 Use ptrdiff_t, not int, for consistency with rest of code.
3972 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3973 (select_window, Fdelete_other_windows_internal)
3974 (window_scroll_pixel_based, window_scroll_line_based)
3975 (Frecenter, Fset_window_configuration):
3976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3977 (Fset_window_hscroll, run_window_configuration_change_hook)
3978 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3979 (Fscroll_other_window, Frecenter):
d311d28c
PE
3980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3981 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3982 Don't assume fixnum fits in int.
3983 (Fset_window_scroll_bars):
3984 Check that fixnums are in proper range for system types.
3985 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3986 (string_pos, c_string_pos, number_of_chars, init_iterator)
3987 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3988 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3989 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3990 (face_before_or_after_it_pos, handle_invisible_prop)
3991 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3992 (display_prop_intangible_p, string_buffer_position_lim)
3993 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3994 (get_overlay_strings_1, get_overlay_strings)
3995 (iterate_out_of_display_property, forward_to_next_line_start)
3996 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3997 (get_next_display_element, set_iterator_to_next)
3998 (get_visually_first_element, compute_stop_pos_backwards)
3999 (handle_stop_backwards, next_element_from_buffer)
4000 (move_it_in_display_line_to, move_it_in_display_line)
4001 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4002 (add_to_log, message_dolog, message_log_check_duplicate)
4003 (message2, message2_nolog, message3, message3_nolog
4004 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4005 (current_message_1, truncate_echo_area, truncate_message_1)
4006 (set_message, set_message_1, store_mode_line_noprop)
4007 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4008 (text_outside_line_unchanged_p, check_point_in_composition)
4009 (reconsider_clip_changes)
4010 (redisplay_internal, set_cursor_from_row, try_scrolling)
4011 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4012 (redisplay_window, find_last_unchanged_at_beg_row)
4013 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4014 (trailing_whitespace_p, find_row_edges, display_line)
4015 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4016 (display_mode_element, store_mode_line_string)
4017 (pint2str, pint2hrstr, decode_mode_spec)
4018 (display_count_lines, display_string, draw_glyphs)
4019 (x_produce_glyphs, x_insert_glyphs)
4020 (rows_from_pos_range, mouse_face_from_buffer_pos)
4021 (fast_find_string_pos, mouse_face_from_string_pos)
4022 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4024 (safe_call, init_from_display_pos, handle_fontified_prop)
4025 (handle_single_display_spec, load_overlay_strings)
4026 (with_echo_area_buffer, setup_echo_area_for_printing)
4027 (display_echo_area, echo_area_display)
4028 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4029 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4030 (redisplay_window, dump_glyph_row, display_mode_line)
4031 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4032 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4034 (handle_single_display_spec, build_desired_tool_bar_string)
4035 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4036 (get_specified_cursor_type):
4037 Check that fixnums are in proper range for system types.
4038 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4039 (Flookup_image_map):
4040 Don't assume fixnums fit in int.
4041 (compare_overlay_entries):
4042 Avoid mishandling comparisons due to subtraction overflow.
4043 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4044 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4045 (handle_tool_bar_click):
4046 Use int, not unsigned, since we prefer signed and the signedness
4047 doesn't matter here.
4048 (get_next_display_element, next_element_from_display_vector):
4049 Use int, not EMACS_INT, when int is wide enough.
4050 (start_hourglass): Use duration_to_sec_usec to do proper
4051 overflow checking on durations.
4052 * xfaces.c (Fbitmap_spec_p):
4053 Check that fixnums are in proper range for system types.
4054 (compare_fonts_by_sort_order):
4055 Avoid mishandling comparisons due to subtraction overflow.
4056 (Fx_family_fonts, realize_basic_faces):
4057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4058 (Fx_family_fonts):
4059 Don't assume fixnum fits in int.
4060 Use SAFE_ALLOCA_LISP, not alloca.
4061 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4062 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4063 (face_at_buffer_position, face_for_overlay_string)
4064 (face_at_string_position):
4065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4066 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4067 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4068 (Fx_show_tip):
4069 Check that fixnums are in proper range for system types.
4070 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4071 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4072 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4073 (Fx_change_window_property): Don't assume fixnums fit in int.
4074 * xfont.c (xfont_chars_supported):
4075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4076 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4077 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4079 * xml.c (parse_region):
4080 * xrdb.c (magic_file_p):
4081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4082 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4083 (x_get_local_selection, x_reply_selection_request)
4084 (x_handle_selection_request, wait_for_property_change):
4085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4086 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4087 short is wide enough.
4088 (x_send_client_event): Don't assume fixnum fits in int.
4089 * xterm.c (x_x_to_emacs_modifiers):
4090 Don't assume EMACS_INT overflows nicely into int.
4091 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4092 may come from Lisp.
4093 (handle_one_xevent): NATNUMP can eval its arg twice.
4094 (x_connection_closed):
4095 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4096 * xterm.h: Adjust decls to match defn changes elsewhere.
4097 (struct scroll_bar): Use struct vectorlike_header
4098 rather than rolling our own approximation.
4099 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4100
c6574eb5
GM
41012012-05-25 Glenn Morris <rgm@gnu.org>
4102
4103 * lisp.mk (lisp): Update for more files being compiled now.
4104
e8d32c7e
SM
41052012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4106
48def666
SM
4107 * lread.c: Remove `read_pure' which makes no difference.
4108 (read_pure): Remove var.
4109 (unreadpure): Remove function.
4110 (readevalloop): Don't call read_list with -1 flag.
4111 (read1, read_vector): Don't test read_pure any more.
4112 (read_list): Simplify.
4113
e8d32c7e
SM
4114 * fileio.c, character.h: Minor style tweaks.
4115
4b2addb7
DA
41162012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4117
4118 * window.h (clip_changed): Remove useless declaration.
4119
584461b2
JB
41202012-05-22 Juanma Barranquero <lekktu@gmail.com>
4121
4122 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4123 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4124
34374650
PE
41252012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4126
4127 Remove src/m/*.
4128 This directory predates autoconf and is no longer needed nowadays.
4129 Move its few remaining bits of functionality to where they're needed.
4130 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4131 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4132 * m/template.h: Remove.
4133 * Makefile.in (M_FILE): Remove. All uses removed.
4134 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4135 * lisp.h (USE_LSB_TAG):
4136 * mem-limits.h (EXCEEDS_LISP_PTR):
4137 Use VAL_MAX, not VALBITS, in #if.
4138 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4139 (EMACS_UINT): Define unconditionally now.
4140 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4141 (BITS_PER_EMACS_INT): New constants, replacing
4142 what used to be in config.h, but not useful in #if.
4143 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4144 define them any more.
4145 (VAL_MAX): New macro.
4146 (VALMASK): Use it.
4147 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4148 BITS_PER_EMACS_INT, in #if.
4149 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4150 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4151 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4152 * s/ms-w32.h (DATA_START):
4153 Move here from removed file m/intel386.h.
4154 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4155 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4156
261cb4bb
PE
41572012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4158
4159 Assume C89 or later.
4160 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4161 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4162 (xrealloc):
4163 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4164 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4165 * textprop.c, tparam.c (NULL): Remove.
4166 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4167 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4168 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4169 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4170 * xterm.c (input_signal_count): Assume volatile works.
4171
ff23cd9f
KB
41722012-05-21 Ken Brown <kbrown@cornell.edu>
4173
4174 * xgselect.c (xg_select): Fix first argument in call to 'select'
4175 (bug#11508).
4176
1b170bc6
KB
41772012-05-20 Ken Brown <kbrown@cornell.edu>
4178
4179 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4180 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4181
b2f4d39f
KB
41822012-05-19 Ken Brown <kbrown@cornell.edu>
4183
4184 * xfns.c (x_in_use): Remove `static' qualifier.
4185 * xterm.h (x_in_use): Declare.
4186 * xgselect.c: Include xterm.h.
4187 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4188 and `display_arg' (bug#9754).
4189
003fdae2
PE
41902012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4191
9232a6d9
PE
4192 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4193
003fdae2
PE
4194 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4195 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4196
784b56e2
EZ
41972012-05-18 Eli Zaretskii <eliz@gnu.org>
4198
4199 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4200
4201 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4202 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4203
4204 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4205 reference to image_cache->refcount.
4206 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4207
a0a79cde
JL
42082012-05-17 Juri Linkov <juri@jurta.org>
4209
4210 * search.c (Fword_search_regexp, Fword_search_backward)
4211 (Fword_search_forward, Fword_search_backward_lax)
4212 (Fword_search_forward_lax): Move functions to isearch.el
4213 (bug#10145, bug#11381).
4214
b0572523
PE
42152012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4216
4217 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4218
9660f5fc
SM
42192012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4220
4221 * lread.c (init_obarray): Declare Qt and Qnil as special.
4222
4374de83
GM
42232012-05-14 Glenn Morris <rgm@gnu.org>
4224
4225 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4226 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4227
dc44c39a
PE
42282012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4229
078c97cb
PE
4230 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4231
dc44c39a
PE
4232 * unexaix.c: Port to more-recent AIX compilers.
4233 (report_error, report_error_1, make_hdr, copy_sym)
4234 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4235 Make arguments const char *, not char *, to avoid violations of C
4236 standard and to fix some AIX warnings reported by Gilles Pion.
4237
e18afed7 42382012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4239
4240 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4241 already have overlays loaded.
4242 (handle_single_display_spec): Before returning without displaying
4243 fringe bitmap, synchronize the bidi iterator with the main display
4244 iterator, by calling iterate_out_of_display_property.
4245 (iterate_out_of_display_property): Detect buffer iteration by
4246 testing that it->string is a Lisp string.
4247 (get_next_display_element): When the current object is exhausted,
4248 and there's something on it->stack, call set_iterator_to_next to
4249 proceed with what's on the stack, instead of returning zero.
4250 (set_iterator_to_next): If called at the end of a Lisp string,
4251 proceed to consider_string_end without incrementing string
4252 position. Don't increment display vector index past the end of
4253 the display vector. (Bug#11417)
c8fb9dc6
EZ
4254 (pos_visible_p): Don't report a position visible when move_it_to
4255 stopped at the last line of window, which happens to be scanned
4256 backwards by the bidi iteration. (Bug#11464)
ac268e67 4257
e18afed7 42582012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4259
4260 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4261 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4262 are on a TTY, and thus unable to display on the fringes.
4263 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4264 so we need to signal to the caller that this is a "replacing"
4265 display spec. This fixes display when the spec is invalid or we
4266 are on a TTY.
4267
e18afed7 42682012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4269
4270 * unexaix.c (make_hdr): Fix typo in prototype.
4271 This bug broke the build on AIX. Problem reported by Gilles Pion.
4272
9d0a235a
MA
42732012-05-14 Michael Albinus <michael.albinus@gmx.de>
4274
4275 * keyboard.c (kbd_buffer_get_event): Read special events also in
4276 batch mode. (Bug#11415)
4277
9e6b06ed
GM
42782012-05-12 Glenn Morris <rgm@gnu.org>
4279
4280 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4281
c1a1d7a3
EZ
42822012-05-12 Eli Zaretskii <eliz@gnu.org>
4283
4284 * lisp.mk (lisp): Add newcomment.elc.
4285
3fe7cdc8
GM
42862012-05-12 Glenn Morris <rgm@gnu.org>
4287
4288 * Makefile.in (MKDIR_P): New, set by configure.
4289 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4290
53f7d2c0
PE
42912012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4292
4293 Remove unused function hourglass_started.
4294 * dispextern.h (hourglass_started):
4295 * w32fns.c (hourglass_started):
4296 * xdisp.c (hourglass_started): Remove.
4297
75aafb17
JB
42982012-05-10 Juanma Barranquero <lekktu@gmail.com>
4299
4300 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4301 Update dependencies.
4302
12959e8e
PE
43032012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4304
97107e2e
PE
4305 * xgselect.c (xg_select): Put maxfds+1 into a var.
4306 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4307
12959e8e
PE
4308 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4309
836d29b3
DA
43102012-05-10 Dave Abrahams <dave@boostpro.com>
4311
4312 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4313 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4314
5cb67954
MA
43152012-05-09 Michael Albinus <michael.albinus@gmx.de>
4316
4317 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4318 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4319 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4320 Initialize xd_registered_buses.
4321
3478ec45
PE
43222012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4323
b263a6b0
PE
4324 Untag more efficiently if USE_LSB_TAG.
4325 This is based on a proposal by YAMAMOTO Mitsuharu in
4326 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4327 For an admittedly artificial (nth 8000 longlist) benchmark on
4328 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4329 Emacs's overall text size by 1%.
4330 * lisp.h (XUNTAG): New macro.
4331 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4332 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4333 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4334 * eval.c (Fautoload):
4335 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4336 * frame.h (XFRAME): Use XUNTAG.
4337
3478ec45
PE
4338 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4339 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4340 Remove unportable assumptions about print widths of types like
4341 dbus_uint32_t.
4342 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4343 intptr_t when converting between pointer and integer, to avoid GCC
4344 warnings about wrong width.
4345
666b903b 43462012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4347
4348 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4349 stack for each reader_thread, instead of defaulting to 8MB
4350 determined by the linker. This avoids failures in creating
4351 subprocesses on Windows 7, see the discussion in this thread:
4352 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4353
b120cc17
JC
43542012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4355
4356 Fix up display of the *Minibuf-0* buffer in the mini window.
4357 * keyboard.c (read_char): Don't clear the echo area if there's no
4358 message to clear.
4359 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4360 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4361
9a4b36f8
MA
43622012-05-07 Michael Albinus <michael.albinus@gmx.de>
4363
4364 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4365 batch mode.
4366
e5f9458f
CY
43672012-05-06 Chong Yidong <cyd@gnu.org>
4368
4369 * lisp.mk (lisp): Update.
4370
eceeb5fc 43712012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4372
4373 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4374
71873e2b
SM
43752012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4376
4377 * data.c (PUT_ERROR): New macro.
4378 (syms_of_data): Use it. Add new error type `user-error'.
4379 * undo.c (user_error): New function.
4380 (Fprimitive_undo): Use it.
4381 * print.c (print_error_message): Adjust print style for `user-error'.
4382 * keyboard.c (user_error): New function.
4383 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4384
ab0fa4e4
PE
43852012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 Do not limit current-time-string to years 1000..9999.
4388 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4389 (Fcurrent_time_string): Support any year that is supported by the
4390 underlying localtime representation. Don't use asctime, as it
4391 has undefined behavior for years outside the range -999..9999.
4392
7ed806a7
PE
43932012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4394
4395 Fix race conditions involving setenv, gmtime, localtime, asctime.
4396 Without this fix, interrupts could mess up code that uses these
4397 nonreentrant functions, since setting TZ invalidates existing
4398 tm_zone or tzname values, and since most of these functions return
4399 pointers to static storage.
4400 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4401 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4402 Grow the critical sections to include not just invoking
4403 localtime/gmtime, but also accessing these functions' results
4404 including their tm_zone values if any, and any related TZ setting.
4405 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4406 so that the struct tm is saved in the critical section.
4407 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4408 motivated by the fact that memory allocation needs to be outside
4409 the critical section.
4410
0c16dfed
DA
44112012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4412
4413 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4414 with RESET_INTERVAL.
4415
4416 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4417 Remove duplicated buffer name initialization.
4418
3f83ace8
JM
44192012-05-02 Jim Meyering <jim@meyering.net>
4420
4421 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4422
c7b8541e
JM
4423 * xfns.c (x_window): Use xstrdup (Bug#11375).
4424
90207a15 44252012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4426
4427 * xdisp.c (pos_visible_p): If already at a newline from the
4428 display string before the 'while' loop, don't walk back the glyphs
4429 from it3.glyph_row. Solves assertion violation when the display
4430 string begins with a newline (egg.el). (Bug#11367)
4431
b593d6a9
AH
44322012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4433
4434 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4435 Move to simple.el.
4436
4737362e
GM
44372012-05-01 Glenn Morris <rgm@gnu.org>
4438
99cf43f9
GM
4439 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4440 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4441 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4442 All were removed before 23.1.
4443
9311dcff
GM
4444 * dispnew.c: Remove HAVE_LIBNCURSES test;
4445 it is always true on relevant platforms.
4446
4d5c6349
GM
4447 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4448 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4449
4737362e
GM
4450 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4451
74dd3a6b
AS
44522012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4453
4454 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4455 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4456 Remove.
4457
13c379ee
PE
44582012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4459
4460 Do not avoid creating empty evaporating overlays (Bug#9642).
4461 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4462 That is, do not delete an evaporating overlay if it becomes
4463 empty after its bounds are adjusted to fit within its buffer.
4464 This fix caused other problems, and I'm reverting it until we get
4465 to the bottom of them.
4466
a8e7d6d7 44672012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4468
4469 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4470
a8e7d6d7 44712012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4472
4473 * xdisp.c (pos_visible_p): If the window start position is beyond
4474 ZV, start the display from buffer beginning. Prevents assertion
4475 violation in init_iterator when the minibuffer window is scrolled
4476 via the scroll bar.
4477
4478 * window.c (window_scroll_pixel_based): Likewise.
4479
a8e7d6d7 44802012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4481
4482 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4483
a8e7d6d7 44842012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4485
4486 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4487 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4488
a8e7d6d7 44892012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4490
b593d6a9
AH
4491 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4492 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4493
1c6900d9
EZ
44942012-04-26 Eli Zaretskii <eliz@gnu.org>
4495
4c3fa1d9
EZ
4496 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4497 display element, check also the underlying string or buffer
4498 character. (Bug#11341)
4499
1c6900d9
EZ
4500 * w32menu.c: Include w32heap.h.
4501 (add_menu_item): If the call to AppendMenuW (via
4502 unicode_append_menu) fails, disable Unicode menus only if we are
4503 running on Windows 9X/Me.
4504
42bf8205
AS
45052012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4506
4507 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4508 (xgetint): Add missing shift for LSB tags.
4509
b1bac16e
MR
45102012-04-24 Martin Rudalics <rudalics@gmx.at>
4511
4512 * keyboard.c (read_char): Don't wipe echo area for select window
4513 events: These might get delayed via `mouse-autoselect-window'
4514 (Bug#11304).
4515
d69621cc
JB
45162012-04-24 Juanma Barranquero <lekktu@gmail.com>
4517
4518 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4519 manipulation of :loaded-from data.
4520
02fd101b
JB
45212012-04-23 Juanma Barranquero <lekktu@gmail.com>
4522
4523 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4524 now a cons (bug#11311).
4525
888bec30
PE
45262012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4527
89a438bd
PE
4528 Do not create empty overlays with the evaporate property (Bug#9642).
4529 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4530 if it becomes empty after its bounds are adjusted to fit within
4531 its buffer. Without this fix, in a nonempty buffer (let ((o
4532 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4533 yields an empty overlay that has the evaporate property, which is
4534 not supposed to happen.
4535
1068fe4d
PE
4536 Fix minor GTK3 problems found by static checking.
4537 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4538 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4539 (struct _EmacsFixedClass, emacs_fixed_get_type):
4540 Move decls here from emacsgtkfixed.h, since they needn't be public.
4541 (emacs_fixed_get_type): Now static.
4542 (emacs_fixed_class_init): Omit unused local.
4543 (emacs_fixed_child_type): Remove; unused.
4544 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4545 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4546 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4547 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4548 (EMACS_FIXED_GET_CLASS): Remove; unused.
4549 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4550
888bec30
PE
4551 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4552 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4553
de85e130
PE
45542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4555
d0baac98 4556 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4557 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4558 (__malloc_size_t, __malloc_ptrdiff_t):
4559 Remove. All uses removed, replaced by the definiens if needed,
4560 since we can assume C89 or better now.
4561 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4562 (protect_malloc_state, align, get_contiguous_space)
4563 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4564 (malloc_atfork_handler_child, malloc_enable_thread)
4565 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4566 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4567 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4568 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4569 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4570 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4571 Define using prototypes, not old style.
4572 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4573 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4574 (align): Don't assume that signed integer overflow wraps around.
4575 Omit unused local var.
4576 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4577 (_free_internal_nolock, memalign, mallochook, reallochook):
4578 Omit no-longer-needed casts.
4579 (valloc): Use getpagesize, not __getpagesize.
4580 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4581 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4582
de85e130
PE
4583 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4584
dcbf5805
MA
45852012-04-22 Michael Albinus <michael.albinus@gmx.de>
4586
4587 Move functions from C to Lisp. Make non-blocking method calls
4588 the default. Implement further D-Bus standard interfaces.
4589
4590 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4591 (QCdbus_request_name_allow_replacement)
4592 (QCdbus_request_name_replace_existing)
4593 (QCdbus_request_name_do_not_queue)
4594 (QCdbus_request_name_reply_primary_owner)
4595 (QCdbus_request_name_reply_in_queue)
4596 (QCdbus_request_name_reply_exists)
4597 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4598 (QCdbus_registered_serial, QCdbus_registered_method)
4599 (QCdbus_registered_signal): New Lisp objects.
4600 (XD_DEBUG_MESSAGE): Use sizeof.
4601 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4602 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4603 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4604 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4605 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4606 (xd_signature, xd_append_arg): Allow float for integer types.
4607 (xd_get_connection_references): New function.
b593d6a9
AH
4608 (xd_get_connection_address): Rename from xd_initialize.
4609 Return cached address.
dcbf5805
MA
4610 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4611 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4612 level.
4613 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4614 Return number of refcounts.
dcbf5805
MA
4615 (Fdbus_get_unique_name): Make stronger parameter check.
4616 (Fdbus_message_internal): New defun.
4617 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4618 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4619 (Fdbus_send_signal, Fdbus_register_service)
4620 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4621 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4622 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4623 (Vdbus_compiled_version, Vdbus_runtime_version)
4624 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4625 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4626 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4627 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4628 Adapt docstring.
dcbf5805 4629
52828e02
PE
46302012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4631
da05bc4c
PE
4632 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4633 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4634 Do not assume ptrdiff_t is the same width as 'int'.
4635
52828e02
PE
4636 * alloc.c: Handle unusual debugging option combinations.
4637 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4638 since the two debugging options are incompatible.
4639 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4640 is defined.
4641 (mem_init, mem_insert, mem_insert_fixup):
4642 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4643 (NEED_MEM_INSERT): Remove; no longer needed.
4644
f01769f9
LL
46452012-04-22 Leo Liu <sdl.web@gmail.com>
4646
4647 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4648
5790543d
PE
46492012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4650
4651 * sysdep.c [__FreeBSD__]: Minor cleanups.
4652 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4653 Use Emacs indenting style more consistently. Avoid some casts.
4654 Use 'double' consistently rather than mixing 'float' and 'double'.
4655
b91b7e4d
EW
46562012-04-21 Eduard Wiebe <usenet@pusto.de>
4657
b593d6a9
AH
4658 * sysdep.c (list_system_processes, system_process_attributes):
4659 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4660
6114eb15
AS
46612012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4662
4663 * lisp.mk (lisp): Update.
4664
2f38dff7
PE
46652012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4666
4667 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4668 It is never used otherwise.
4669
4ae29f89
SM
46702012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4671
4672 * print.c (print_preprocess): Only check print_depth if print-circle
4673 is nil.
4674 (print_object): Check for cycles even when print-circle is nil and
4675 print-gensym is t, but only check print_depth if print-circle is nil.
4676
f30d612a
CY
46772012-04-20 Chong Yidong <cyd@gnu.org>
4678
4679 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4680 set the status to "failed" and ensure that sentinel is run.
4681
c07a4c0b 46822012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4683
4684 * process.c (Fset_process_inherit_coding_system_flag)
4685 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4686 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4687
c07a4c0b 46882012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4689
4690 * xdisp.c (string_buffer_position_lim): Limit starting position to
4691 BEGV.
4692 (set_cursor_from_row): If called for a mode-line or header-line
4693 row, return zero immediately.
4694 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4695 farther than the first row after the header line, if any.
4696 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4697 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4698
c07a4c0b 46992012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4700
4ae29f89
SM
4701 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4702 (bug#11238).
ad3a2b41 4703
c07a4c0b 47042012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 47052012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4706
4707 configure: new option --enable-gcc-warnings (Bug#11207)
4708 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4709 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4710 (ALL_CFLAGS): Use new macros rather than old.
4711 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4712 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4713 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4714 -Wunused-result, -Wunused-variable. This should go away once
4715 the Emacs and Gnulib regex code is merged.
4716 (xmalloc, xrealloc): Now static.
4717
aba027e8
PE
47182012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4719
4720 * dired.c (Fsystem_groups): Remove unused local.
4721
e5a36063
GM
47222012-04-17 Glenn Morris <rgm@gnu.org>
4723
4724 * dired.c (Fsystem_users): Doc fix.
4725
316411f0
DA
47262012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4727
4728 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4729 (syms_of_dired): Add them.
4730
9426aba4
PE
47312012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4732
b62a57be
PE
4733 Fix minor alloc.c problems found by static checking.
4734 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4735 New extern decls, to avoid calling undeclared functions.
4736 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4737 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4738 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4739 (NEED_MEM_INSERT): New macro.
4740 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4741 Remove one incorrect comment and fix another.
b62a57be 4742
3539f31f
PE
4743 Fix minor ralloc.c problems found by static checking.
4744 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4745 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4746 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4747 (r_alloc_sbrk): Now static.
4748
a041960a
PE
4749 Improve ralloc.c interface checking.
4750 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4751 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4752 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4753 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4754 [REL_ALLOC]: ... to here, to check interface.
4755 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4756 Remove decls. This fixes an "It stinks!".
4757
9426aba4
PE
4758 * alloc.c (which_symbols): Fix alignment issue / type clash.
4759
d55c12ed
AS
47602012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4761
4762 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4763 (struct Lisp_Misc_Any): Likewise.
4764 (struct Lisp_Free): Likewise.
4765 * alloc.c (union aligned_Lisp_Symbol): Define.
4766 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4767 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4768 (union aligned_Lisp_Misc): Define.
4769 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4770 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4771 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4772
b948ce8b
PE
47732012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4774
4775 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4776 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4777 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4778 * s/netbsd.h, s/sol2-6.h:
4779 Remove definition of GC_MARK_STACK, since the default now works.
4780 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4781 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4782 no longer the default.
4783 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4784
35dc09a1 47852012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4786
35dc09a1
GM
4787 * lread.c (lisp_file_lexically_bound_p):
4788 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4789
35dc09a1
GM
47902012-04-14 Eli Zaretskii <eliz@gnu.org>
4791
4792 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4793 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4794
47952012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4796
4797 * nsterm.m (constrainFrameRect): Always constrain when there is only
4798 one screen (Bug#10962).
4799
bcd86815
KB
48002012-04-13 Ken Brown <kbrown@cornell.edu>
4801
4802 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4803
c25df26e
RT
48042012-04-13 Reuben Thomas <rrt@sc3d.org>
4805
4806 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4807
0fc59f1e
DC
48082012-04-11 Daniel Colascione <dancol@dancol.org>
4809
4810 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4811 against is gone. It's better to use vfork now so that when Cygwin
4812 gains a new, working vfork, we use it automatically (bug#10398).
4813
de8c03dc
SM
48142012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4815
4816 * window.c (save_window_save): Obey window-point-insertion-type.
4817
2f097256
GM
48182012-04-11 Glenn Morris <rgm@gnu.org>
4819
4820 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4821
453b951e
SM
48222012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4823
4824 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4825
75f1671a 48262012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4827
4828 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4829 (force_quit_count): New var.
4830 (handle_interrupt): Use it.
4831
2a8ce227
JB
48322012-04-10 Juanma Barranquero <lekktu@gmail.com>
4833
4834 * w32.c (w32_delayed_load): Record the full path of the library
4835 being loaded (bug#10424).
4836
935396c0
GM
48372012-04-09 Glenn Morris <rgm@gnu.org>
4838
05920a43
GM
4839 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4840 not just in the obarray, before snarfing them. (Bug#11036)
4841
935396c0
GM
4842 * Makefile.in ($(leimdir)/leim-list.el):
4843 Pass EMACS rather than BUILT_EMACS.
4844
a18ecafa
TZ
48452012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4846
4847 * process.c (make_process):
4848 * process.h: Add integer `gnutls_handshakes_tried' member to
4849 process struct.
4850
6bbef4e5
JC
4851 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4852 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4853
4854 * gnutls.c (gnutls_log_function2i): Convenience log function.
4855 (emacs_gnutls_read): Use new log functions,
4856 `gnutls_handshakes_tried' process member, and
4857 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4858 attempts per process (connection).
4859
b4d3bc10
CY
48602012-04-09 Chong Yidong <cyd@gnu.org>
4861
4862 * eval.c (Fuser_variable_p, user_variable_p_eh)
4863 (lisp_indirect_variable): Functions deleted.
4864 (Fdefvar): Caller changed.
4865
4866 * callint.c (Finteractive, Fcall_interactively):
4867 * minibuf.c (Fread_variable): Callers changed.
4868
70f4d973
EZ
48692012-04-09 Eli Zaretskii <eliz@gnu.org>
4870
4871 * xdisp.c (set_cursor_from_row): If the display string appears in
4872 the buffer at position that is closer to point than the position
4873 after the display string, display the cursor on the first glyph of
4874 the display string. Fixes cursor display when a 'display' text
4875 property immediately follows invisible text. (Bug#11094)
4876
cb3c2e3e
PE
48772012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4878
4879 composite.c: use 'double' consistently
4880 * composite.c (get_composition_id): Use 'double' consistently
4881 instead of converting 'float' to 'double' and vice versa; this is
4882 easier to understand and avoids a GCC warning.
4883
fd06db5d
GM
48842012-04-09 Glenn Morris <rgm@gnu.org>
4885
50fe702a
GM
4886 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4887 preparation for dumping it with emacs. (Bug#4789)
4888 (leimdir): New variable.
4889 ($(leimdir)/leim-list.el): New rule.
4890 (emacs$(EXEEXT)): Depend on leim-list.el.
4891
fd06db5d
GM
4892 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4893 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4894 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4895
55c131ee
AS
48962012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4897
4898 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4899 proper alignment.
4900
9209588f
JB
49012012-04-07 Juanma Barranquero <lekktu@gmail.com>
4902
4903 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4904 Remove unused local variable.
4905
e3fb2efb
PE
49062012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4907
4908 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4909 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4910 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4911 objects, as mark_maybe_pointer will catch them otherwise.
4912 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4913 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4914
b5385551
PE
49152012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4916
4917 Fix typo that broke non-Windows builds.
4918 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4919
9078ead6
EZ
49202012-04-07 Eli Zaretskii <eliz@gnu.org>
4921
4922 Support building on MS-Windows with libxml2.
4923
4924 * makefile.w32-in (OBJ2): Add xml.$(O).
4925 (GLOBAL_SOURCES): Add xml.c.
4926 ($(BLD)/xml.$(O)): New dependency list.
4927
4928 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4929 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4930 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4931 [!WINDOWSNT]: New macros.
4932 (init_libxml2_functions, libxml2_loaded_p): New functions.
4933 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4934 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4935 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4936 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4937 linked in).
6bbef4e5
JC
4938 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4939 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4940 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4941
4942 * emacs.c: Don't include libxml/parser.h.
4943 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4944 xmlCleanupParser directly.
4945
4946 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4947
3811fdf3
EZ
49482012-04-07 Eli Zaretskii <eliz@gnu.org>
4949
4950 * indent.c (Fvertical_motion): If there is a display string at
4951 point, use it.vpos to compute how many lines to backtrack after
4952 move_it_to point. (Bug#11133)
4953
2f8e16b2
EZ
49542012-04-06 Eli Zaretskii <eliz@gnu.org>
4955
4956 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4957 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4958 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4959 macros related to unification of CJK characters. For the details,
4960 see the discussion following the message here:
4961 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4962
3d439cd1
CY
49632012-04-04 Chong Yidong <cyd@gnu.org>
4964
4965 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4966
8bc53d00
EZ
49672012-04-01 Eli Zaretskii <eliz@gnu.org>
4968
4969 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4970 instead of alloca. (Bug#11138)
4971
3b0512a3
AS
49722012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4973
4974 * w32menu.c (is_simple_dialog): Properly check lisp types.
4975 (Bug#11141)
4976
8427ddd2
EZ
49772012-03-31 Eli Zaretskii <eliz@gnu.org>
4978
979022ef
EZ
4979 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4980 position we get to after a call to move_it_to fails the
4981 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4982 only if we wind up in a string from display property. (Bug#11063)
4983
a6b1c7cc
EZ
4984 * window.c (Fdelete_other_windows_internal): Invalidate the row
4985 and column information about mouse highlight, so that redisplay
4986 restores it after reallocating the glyph matrices. (Bug#7464)
4987
8427ddd2
EZ
4988 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4989 string comes from a `display' text property, use the buffer
4990 position of that property as if we actually saw that position in
4991 the row's glyphs.
697ba24b
EZ
4992 (move_it_by_lines): Remove the assertion that
4993 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4994 violated when there's a before-string at the beginning of a line.
4995 (Bug#11063)
8427ddd2 4996
65a0a738
EZ
49972012-03-30 Eli Zaretskii <eliz@gnu.org>
4998
4999 * xdisp.c (append_space_for_newline): If the default face was
5000 remapped, use the remapped face for the appended newline.
5001 (extend_face_to_end_of_line): Use the remapped default face for
5002 extending the face to the end of the line.
5003 (display_line): Call extend_face_to_end_of_line when the default
5004 face was remapped. (Bug#11068)
5005
581355cc
EZ
50062012-03-29 Eli Zaretskii <eliz@gnu.org>
5007
5008 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5009
e8fc049f
SM
50102012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5011
5012 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5013
4fb9a543
GM
50142012-03-27 Glenn Morris <rgm@gnu.org>
5015
5016 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5017 Doc fixes.
5018
679910f1
KH
50192012-03-26 Kenichi Handa <handa@m17n.org>
5020
5021 * dispextern.h (struct glyph): Fix previous change. Change the
5022 bit length of glyphless.ch to 25 (Bug#11082).
5023
90d49b7f
CY
50242012-03-26 Chong Yidong <cyd@gnu.org>
5025
5026 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5027 (command_loop_1): Use it; inhibit selection update for
5028 handle-select-window too (Bug#8996).
5029
f514f6f0
FP
50302012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5031
e8fc049f 5032 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5033
bf43fa51
KH
50342012-03-25 Kenichi Handa <handa@m17n.org>
5035
5036 * dispextern.h (struct glyph): Change the bit length of
5037 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5038
8a0c01dd
EZ
50392012-03-24 Eli Zaretskii <eliz@gnu.org>
5040
5041 * s/ms-w32.h (tzname): Include time.h before redirecting to
5042 _tzname. Fixes the MSVC build. (Bug#9960)
5043
7d1c3a76
AS
50442012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5045
8ed79523
AS
5046 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5047 characters.
5048
7d1c3a76
AS
5049 * xterm.c (XTread_socket): Only modify handling_signal if
5050 !SYNC_INPUT. (Bug#11080)
5051
e99a9b8b
EZ
50522012-03-23 Eli Zaretskii <eliz@gnu.org>
5053
5054 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5055 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5056 when fetching a multibyte character consumes more bytes than
5057 CHAR_BYTES returns, due to unification of CJK characters in
5058 string_char. (Bug#11073)
5059
5063c0e1
TN
50602012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5061
5062 * process.c (wait_reading_process_output): Handle pty disconnect
5063 by refraining from sending oneself a SIGCHLD (bug#10933).
5064
9f851fbd
CY
50652012-03-22 Chong Yidong <cyd@gnu.org>
5066
5067 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5068
5063c0e1 5069 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5070 Mark string as coming from a prefix property.
5071 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5072 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5073
fb5b8aca
CY
50742012-03-21 Chong Yidong <cyd@gnu.org>
5075
5076 * xfaces.c (Vface_remapping_alist): Doc fix.
5077
62356a1b
EZ
50782012-03-20 Eli Zaretskii <eliz@gnu.org>
5079
5080 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5081 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5082 Doc fixes.
62356a1b 5083
025de85b
CY
50842012-03-20 Chong Yidong <cyd@gnu.org>
5085
5086 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5087 to reflect default non-nil value of redisplay-dont-pause.
5088
4827f94e
KH
50892012-03-19 Kenichi Handa <handa@m17n.org>
5090
5091 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5092 it fit in a valid range (Bug#11003).
5093
e50a24a2
EZ
50942012-03-18 Eli Zaretskii <eliz@gnu.org>
5095
5096 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5097 that is not from display property, accept the row as a "cursor
5098 row" if one of the string's character has a non-nil `cursor'
5099 property. Fixes cursor positioning when there are newlines in
5100 overlay strings, e.g. in icomplete.el. (Bug#11035)
5101
9af5ed87
PE
51022012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5103
5104 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5105
d1f55f16
CY
51062012-03-12 Chong Yidong <cyd@gnu.org>
5107
5108 * eval.c (inhibit_lisp_code): Rename from
5109 inhibit_window_configuration_change_hook; move from window.c.
5110
5111 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5112 * window.c (run_window_configuration_change_hook)
5113 (syms_of_window): Callers changed.
5114
66c5eebd
CY
51152012-03-11 Chong Yidong <cyd@gnu.org>
5116
413df973
CY
5117 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5118
66c5eebd
CY
5119 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5120
1de11f56
CY
51212012-03-10 Chong Yidong <cyd@gnu.org>
5122
5123 * frame.c (other_visible_frames): Don't assume the selected frame
5124 is visible (Bug#10955).
5125
cae07000
SM
51262012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5127
5128 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5129
89c94350
JD
51302012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5131
5132 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5133 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5134 zero (Bug#10954).
5135
999dd333
GM
51362012-03-03 Glenn Morris <rgm@gnu.org>
5137
01a6dcc8 5138 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5139
de0100f2
EZ
51402012-03-02 Eli Zaretskii <eliz@gnu.org>
5141
5142 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5143 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5144 (redisplay_window, next_element_from_string): Fix typos in
5145 comments.
3e441275
EZ
5146 (redisplay_window): Pass to move_it_vertically the margin in
5147 pixels, not in screen lines.
de0100f2 5148
96a72ee9
GM
51492012-03-02 Glenn Morris <rgm@gnu.org>
5150
5151 * buffer.c (buffer-list-update-hook): Doc fix.
5152
312508d7
EZ
51532012-02-29 Eli Zaretskii <eliz@gnu.org>
5154
5155 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5156 push_it before setting up the iterator for the first overlay
5157 string, even if we have an empty string loaded.
5158 (next_overlay_string): If there's an empty string on the iterator
5159 stack, pop the stack. (Bug#10903)
5160
27f3c637
PE
51612012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5162
5163 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5164 Suggested by Stefan Monnier in
5165 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5166 * alloc.c (widen_to_Lisp_Object): New static function.
5167 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5168 and widening them to Lisp_Objects. This would work even if
5169 USE_LSB_TAG is defined and wide integers are used, which might
5170 happen in a future version of Emacs.
5171
3c9dfce6
CY
51722012-02-25 Chong Yidong <cyd@gnu.org>
5173
fa74b241
CY
5174 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5175 Doc fix.
5176
3c9dfce6
CY
5177 * xselect.c (Fx_selection_exists_p): Doc fix.
5178 (x_clipboard_manager_save_all): Print an informative message
5179 before saving to clipboard manager.
5180
9486df08
CY
51812012-02-24 Chong Yidong <cyd@gnu.org>
5182
5183 * keyboard.c (process_special_events): Handle all X selection
5184 requests in kbd_buffer, not just the next one (Bug#8869).
5185
f01d3321
CY
51862012-02-23 Chong Yidong <cyd@gnu.org>
5187
5188 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5189 call when setting menu-bar-lines and tool-bar-lines parameters.
5190 (unwind_create_frame_1): New helper function.
5191
5192 * window.c (inhibit_window_configuration_change_hook): New var.
5193 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5194 (syms_of_window): Initialize it.
f01d3321 5195
86b847b6
CY
51962012-02-22 Chong Yidong <cyd@gnu.org>
5197
5198 * xterm.c (x_draw_image_relief): Add missing type check for
5199 Vtool_bar_button_margin (Bug#10743).
5200
a59225b1
CY
52012012-02-21 Chong Yidong <cyd@gnu.org>
5202
5203 * fileio.c (Vfile_name_handler_alist): Doc fix.
5204
5205 * buffer.c (Fget_file_buffer): Protect against invalid file
5206 handler return value.
5207
310f5bd4
PE
52082012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5209
cb3a28cc
PE
5210 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5211 when computing $valmask.
5212
310f5bd4
PE
5213 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5214 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5215 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5216 It's useless in that case, and it can cause problems on hosts
5217 that allocate halves of EMACS_INT values separately.
5218 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5219 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5220 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5221 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5222 it avoids undefined behavior on hosts where shifting right by more
5223 than the word width has undefined behavior.
5224
2375c96a
CY
52252012-02-19 Chong Yidong <cyd@gnu.org>
5226
5227 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5228 (Funhandled_file_name_directory, Ffile_name_as_directory)
5229 (Fdirectory_file_name, Fexpand_file_name)
5230 (Fsubstitute_in_file_name): Protect against invalid file handler
5231 return values (Bug#10845).
5232
3eb49e71
EZ
52332012-02-18 Eli Zaretskii <eliz@gnu.org>
5234
5235 * .gdbinit (pitx): Fix incorrect references to fields of the
5236 iterator stack.
5237
7b926f3f
CY
52382012-02-17 Chong Yidong <cyd@gnu.org>
5239
5240 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5241
11273115
PE
52422012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5243
5244 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5245 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5246
c3a70e2b
CY
52472012-02-15 Chong Yidong <cyd@gnu.org>
5248
5249 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5250 marked as special. Also, starting docstrings with * is obsolete.
5251
0ca43699
AS
52522012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5253
5254 * gnutls.c (emacs_gnutls_write): Fix last change.
5255
2e8f3c56
LI
52562012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5257
5258 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5259 send_process.
5260
af70074f
SM
52612012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5262
5263 * keymap.c (Fsingle_key_description): Handle char ranges.
5264
95986d52
CY
52652012-02-12 Chong Yidong <cyd@gnu.org>
5266
afd83bd1
CY
5267 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5268 as that creates a dangerous corner case.
5269
95986d52
CY
5270 * window.c (Fdelete_window_internal): Invalidate the mouse
5271 highlight (Bug#9904).
5272
bd7da63e
GM
52732012-02-12 Glenn Morris <rgm@gnu.org>
5274
5275 * xselect.c (Fx_own_selection_internal)
5276 (Fx_get_selection_internal, Fx_disown_selection_internal)
5277 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5278 * nsselect.m (Fx_own_selection_internal)
5279 (Fx_disown_selection_internal, Fx_selection_exists_p)
5280 (Fx_selection_owner_p, Fx_get_selection_internal):
5281 Sync docs and argument specs with the xselect.c versions.
5282
77abcbc2
LI
52832012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5284
5285 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5286
90b671e2
EZ
52872012-02-11 Eli Zaretskii <eliz@gnu.org>
5288
1c0ca0b7
EZ
5289 * w32select.c (Fx_selection_exists_p): Sync doc string and
5290 argument list with xselect.c. (Bug#10783)
5291
5292 * w16select.c (Fx_selection_exists_p): Sync doc string and
5293 argument list with xselect.c. (Bug#10783)
90b671e2 5294
49241268
GM
52952012-02-10 Glenn Morris <rgm@gnu.org>
5296
5297 * fns.c (Fsecure_hash): Doc fix.
5298
f998bbe7 52992012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5300
5301 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5302
0992bd9c
CY
53032012-02-07 Chong Yidong <cyd@gnu.org>
5304
5305 * buffer.c (Fbuffer_local_variables)
5306 (buffer_lisp_local_variables): Handle unbound vars correctly;
5307 don't let Qunbound leak into Lisp.
5308
af008560
GM
53092012-02-07 Glenn Morris <rgm@gnu.org>
5310
dd605cc4
GM
5311 * image.c (Fimagemagick_types): Doc fix.
5312
af008560
GM
5313 * image.c (imagemagick-render-type): Change it from a lisp object
5314 to an integer. Move the doc here from the lisp manual.
5315 Treat all values not equal to 0 the same.
5316
1449fa1d
CY
53172012-02-06 Chong Yidong <cyd@gnu.org>
5318
5319 * doc.c (store_function_docstring): Avoid applying docstring of
5320 alias to base function (Bug#2603).
5321
3723ec07
AS
53222012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5323
5324 * .gdbinit (pp1, pv1): Remove redundant defines.
5325 (pr): Use pp.
5326
79c1cc1e
CY
53272012-02-04 Chong Yidong <cyd@gnu.org>
5328
5329 * nsterm.m: Declare a global (Bug#10694).
5330
d7f29f8e
EZ
53312012-02-04 Eli Zaretskii <eliz@gnu.org>
5332
cae07000
SM
5333 * w32.c (get_emacs_configuration_options):
5334 Include --enable-checking, if specified, in the return value.
d7f29f8e 5335
3b95a6f9
MR
53362012-02-04 Martin Rudalics <rudalics@gmx.at>
5337
5338 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5339 after rounding frame sizes. (Bug#9723)
5340
d6fa96a6
EZ
53412012-02-04 Eli Zaretskii <eliz@gnu.org>
5342
5343 * keyboard.c (adjust_point_for_property): Don't position point
5344 before BEGV. (Bug#10696)
5345
df0b2940
PE
53462012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5347
5348 Handle overflow when computing char display width (Bug#9496).
5349 * character.c (char_width): Return EMACS_INT, not int.
5350 (char_width, c_string_width): Check for overflow when
5351 computing the width; this is possible now that individual
5352 characters can have unbounded width. Problem introduced
5353 by merge from Emacs 23 on 2012-01-19.
5354
6bee44d6
MA
53552012-02-02 Michael Albinus <michael.albinus@gmx.de>
5356
5357 * dbusbind.c (Fdbus_register_method): Mention the return value
5358 :ignore in the docstring.
5359
44f92739
GM
53602012-02-02 Glenn Morris <rgm@gnu.org>
5361
1b9f60cc
GM
5362 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5363
44f92739
GM
5364 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5365 Unconditionally set to t. (Bug#10673)
5366 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5367 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5368 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5369
c5d3843c
KH
53702012-02-02 Kenichi Handa <handa@m17n.org>
5371
5372 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5373 0, do not call append_composite_glyph.
5374
159462d4 53752012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5376
5377 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5378 NULL (Bug#6988).
5379 (x_produce_glyphs): If the component of a composition is a null
5380 string, set it->pixel_width to 1 to avoid zero-width glyph.
5381
78cef877
EZ
53822012-02-01 Eli Zaretskii <eliz@gnu.org>
5383
5384 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5385 first 2 arguments are identical. This makes inserting large
5386 output from a subprocess an order of magnitude faster on
5387 MS-Windows, where all sbrk'ed memory is always contiguous.
5388
97897668
GM
53892012-01-31 Glenn Morris <rgm@gnu.org>
5390
5391 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5392 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5393 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5394
31fd3586
GM
53952012-01-29 Glenn Morris <rgm@gnu.org>
5396
5397 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5398
0e24a8b2
CY
53992012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5400
5401 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5402
cc0adcb0
CY
54032012-01-28 Chong Yidong <cyd@gnu.org>
5404
5405 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5406
acc28cb9
CY
54072012-01-26 Chong Yidong <cyd@gnu.org>
5408
9c69cfb7
CY
5409 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5410
acc28cb9
CY
5411 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5412 repeat counts (Bug#10507).
5413
48da7392
GM
54142012-01-26 Glenn Morris <rgm@gnu.org>
5415
5416 * lread.c (syms_of_lread): Doc fix.
5417
14af5f7f
CY
54182012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5419
5420 * coding.c (encode_designation_at_bol): Change return value to
5421 EMACS_INT.
5422
0b21c100
CY
54232012-01-25 Chong Yidong <cyd@gnu.org>
5424
5425 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5426
3c2907f7
CY
54272012-01-21 Chong Yidong <cyd@gnu.org>
5428
5429 * floatfns.c (Fcopysign): Make the second argument non-optional,
5430 since nil is not allowed anyway.
5431
959ad23f
AS
54322012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5433
5434 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5435 (send_process): Likewise.
5436
34a02f46
MR
54372012-01-19 Martin Rudalics <rudalics@gmx.at>
5438
5439 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5440 (Vwindow_persistent_parameters): Do not use Qstate.
5441 Rewrite doc-strings.
34a02f46 5442
1259009a 54432012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5444
5445 * character.c (char_width): New function.
70d4fdf6
GM
5446 (Fchar_width, c_string_width, lisp_string_width):
5447 Use char_width (Bug#9496).
25ed9e61 5448
6a6ee00d
MR
54492012-01-16 Martin Rudalics <rudalics@gmx.at>
5450
5451 * window.c (Vwindow_persistent_parameters): New variable.
5452 (Fset_window_configuration, save_window_save): Handle persistent
5453 window parameters.
5454
c85efaf7
EZ
54552012-01-14 Eli Zaretskii <eliz@gnu.org>
5456
5457 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5458 thrashing the stack of the thread. (Bug#9087)
5459
5944709e
PE
54602012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5461
5462 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5463
e71f5d99
EZ
54642012-01-11 Eli Zaretskii <eliz@gnu.org>
5465
5466 * xdisp.c (rows_from_pos_range): Handle the case where the
5467 highlight ends on a newline. (Bug#10464)
5468 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5469 he end column for display of highlight that ends on a newline
5470 before a R2L line.
5471
ce316182
GM
54722012-01-11 Glenn Morris <rgm@gnu.org>
5473
5474 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5475 from load-path also when installation-directory is nil. (Bug#10208)
5476
5b43da69
GM
54772012-01-10 Glenn Morris <rgm@gnu.org>
5478
74cc8ff9
GM
5479 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5480
7d8d6e4e
GM
5481 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5482 Update template values to be closer to their typical values these days.
5b43da69 5483
a0db8d43
EZ
54842012-01-09 Eli Zaretskii <eliz@gnu.org>
5485
5486 * xdisp.c (rows_from_pos_range): Accept additional argument
5487 DISP_STRING, and accept any glyph in a row whose object is that
5488 string as eligible for mouse highlight. Fixes mouse highlight of
5489 display strings from overlays. (Bug#10464)
5490
9a0115ab 54912012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5492
b9110d6a 5493 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5494 * fileio.c (auto_saving_dir_umask): New static var.
5495 (Fmake_directory_internal): Use it.
5496 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5497 creating the directory. The old code temporarily assigns
5498 too-generous permissions to the directory.
5499 (do_auto_save_eh): Clear it.
b9110d6a 5500 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5501 that the var is always cleared.
5502
6c1bd3f3
EZ
55032012-01-07 Eli Zaretskii <eliz@gnu.org>
5504
5505 * search.c (scan_buffer): Pass character positions to
5506 know_region_cache, not byte positions. (Bug#6540)
5507
069d2b50
L
55082012-01-07 LynX <_LynX@bk.ru> (tiny change)
5509
5510 * w32.c (sys_rename): Report EXDEV when rename of a directory
5511 fails because the target is on another logical disk. (Bug#10284)
5512
75bf0d33
DB
55132012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5514
5515 * xterm.c (x_embed_request_focus): New function.
5516
5517 * xterm.h: Add prototype.
5518
5519 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5520
1c6e5a32
GM
55212012-01-05 Glenn Morris <rgm@gnu.org>
5522
5523 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5524
651e947e
EZ
55252012-01-01 Eli Zaretskii <eliz@gnu.org>
5526
5527 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5528 Load gnutls_transport_set_lowat only if GnuTLS version is below
5529 2.11.1.
5530 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5531 GnuTLS versions below 2.11.1.
5532
3778cdd8
AL
55332011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5534
5535 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5536 to the doc string advising against its use for altering the way
5537 windows are scrolled.
5538
0e5317f7
KH
55392011-12-28 Kenichi Handa <handa@m17n.org>
5540
5541 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5542 coding-system ASCII compatible only when it does not produce BOM
5543 on encoding (Bug#10383).
5544
93d5ca1f
JD
55452011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5546
5547 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5548 can scroll.
5549 (create_and_show_popup_menu): Always use menu_position_func for
5550 Gtk3 (Bug#10361).
5551
ca22b785
AS
55522011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5553
5554 * callint.c (Fcall_interactively): Don't truncate prompt string.
5555
d048e1e6
EZ
55562011-12-23 Eli Zaretskii <eliz@gnu.org>
5557
5558 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5559 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5560 resumed from there (after widening). (Bug#10360)
d048e1e6 5561
5ccaba1f
JD
55622011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5563
5564 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5565
204ee57f
JD
55662011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5567
b81d40f0
JB
5568 * nsterm.m (x_free_frame_resources):
5569 Release f->output_data.ns->miniimage.
204ee57f
JD
5570 (ns_index_color): Fix indentation. Do not retain
5571 color_table->colors[i].
5572
5573 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5574 before returning.
5575
5576 * nsfns.m (x_set_background_color): Assign return value from
5577 ns_index_color to face-background instead of NSColor*.
5578 (ns_implicitly_set_icon_type): Fix indentation.
5579 Change assignment in for loop to comparison.
5580
5581 * emacs.c (ns_pool): New variable.
5582 (main): Assign ns_pool.
5583 (Fkill_emacs): Call ns_release_autorelease_pool.
5584
5585 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5586 autorelease fdesc, release fdAttrs and tdict.
5587 (ns_get_covering_families): Release charset.
5588 (ns_findfonts): Release NSFontDescriptor created with new.
5589 (ns_uni_to_glyphs): Fix indentation.
5590 (setString): Release attrStr before assigning new value.
5591
c803b2b7
JD
55922011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5593
678f4426
JD
5594 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5595 and NS_IMPL_COCOA.
5596 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5597 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5598
cd394be1 55992011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5600
5fecd5fc
JD
5601 * nsterm.m (ns_term_init): Subscribe for notifications
5602 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5603 to method trackingNotification in EmacsMenu.
5604
5605 * nsmenu.m (trackingMenu): New variable.
3771cb17 5606 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5607 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5608 from Aquamacs (Bug#7030).
678f4426
JD
5609
56102011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5611
c803b2b7
JD
5612 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5613 (symbol_to_nsstring): Fix indentation.
5614 (ns_symbol_to_pb): New function.
cae07000
SM
5615 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5616 (Fns_rotate_cut_buffers_internal): Remove.
5617 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5618 Fns_store_cut_buffer_internal.
5619 (ns_get_foreign_selection, Fx_own_selection_internal)
5620 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5621 (Fns_get_selection_internal, Fns_store_selection_internal):
5622 Use ns_symbol_to_pb and check if return value is nil.
5623 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5624 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5625 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5626 renamed to Sns_store_selection_internal.
5627 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5628 and remove this function.
5629 (ns_handle_selection_clear): Remove, never used.
5630 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5631 here.
5632
e1b01a3a
KB
56332011-12-17 Ken Brown <kbrown@cornell.edu>
5634
5635 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5636 GID is unknown (Bug#10257).
5637
2adb6e85
PE
56382011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5639
5640 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5641 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5642 which caused a build failure on GNU/Linux IA-64. This problem was
5643 introduced by my 2011-10-07 patch.
5644
d1d7b339
JL
56452011-12-15 Juri Linkov <juri@jurta.org>
5646
5647 * image.c (imagemagick_error): New function. (Bug#10112)
5648 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5649 Use `imagemagick_error' where ImageMagick functions return
5650 `MagickFalse'.
5651 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5652 proper order.
5653
100d5755
KH
56542011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5655
5656 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5657 fill background (Bug#8992).
5658
454592a6
MR
56592011-12-13 Martin Rudalics <rudalics@gmx.at>
5660
5661 * window.c (Vwindow_combination_resize)
5662 (Vwindow_combination_limit): Use t instead of non-nil in
5663 doc-strings.
61d4b438
MR
5664 (Vrecenter_redisplay): Add first sentence of doc-string on
5665 separate line.
53524d93 5666 (Frecenter): Fix doc-string typo.
454592a6 5667
3633e3aa
KH
56682011-12-11 Kenichi Handa <handa@m17n.org>
5669
5670 * coding.c (Funencodable_char_position): Pay attention to the
5671 buffer text relocation (Bug#9389).
5672
7b9d523a 56732011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5674
7b9d523a
JD
5675 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5676 gtk_init (Bug#10100).
5677
b73189c6
EZ
56782011-12-10 Eli Zaretskii <eliz@gnu.org>
5679
5680 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5681 IT->string is nil. (Bug#10263)
5682
f7dfe5d6
JD
56832011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5684
83faebb4
JD
5685 * nsterm.h (x_free_frame_resources): Declare.
5686
f7dfe5d6
JD
5687 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5688 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5689
5690 * nsterm.h (ns_get_defaults_value): Declare.
5691
5692 * nsterm.m (ns_default): Call ns_get_defaults_value.
5693
7cd4e72c
EZ
56942011-12-09 Eli Zaretskii <eliz@gnu.org>
5695
5696 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5697 (Bug#10170)
5698
b34d7317
YM
56992011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5700
5701 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5702 that where the value of an _OBJC_* symbol points to is in the .bss
5703 section (Bug#10240).
5704
76470ad1
KH
57052011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5706
5707 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5708 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5709
745fff94
KH
57102011-12-08 Kenichi Handa <handa@m17n.org>
5711
5712 * ftfont.c (get_adstyle_property): Fix previous change
5713 (Bug#10233).
5714
6e44397c
JB
57152011-12-07 Juanma Barranquero <lekktu@gmail.com>
5716
5717 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5718 dirs from the default value of EMACSLOADPATH (bug#10208).
5719
7efa6272
GM
57202011-12-07 Glenn Morris <rgm@gnu.org>
5721
5722 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5723 installation and source directories as well. (Bug#10208)
5724
f6fc4d87
CY
57252011-12-06 Chong Yidong <cyd@gnu.org>
5726
5727 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5728
2bf26180
GM
57292011-12-06 Glenn Morris <rgm@gnu.org>
5730
5731 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5732 as an error, not just -1. (Bug#10217)
5733
3a6ad4f0
CY
57342011-12-05 Chong Yidong <cyd@gnu.org>
5735
5736 * keyboard.c (process_special_events): New function.
5737 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5738
75a3b399
PE
57392011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5740
5741 * coding.c (encode_designation_at_bol): Don't use uninitialized
5742 local variable (Bug#9318).
5743
c3c9e25e
KH
57442011-12-05 Kenichi Handa <handa@m17n.org>
5745
5746 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5747 return Qnil (Bug#8046, Bug#10193).
5748
5eb05ea3
KH
57492011-12-05 Kenichi Handa <handa@m17n.org>
5750
5751 * coding.c (encode_designation_at_bol): New args charbuf_end and
5752 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5753 (coding_set_source): Return how many bytes coding->source was
5754 relocated.
5755 (coding_set_destination): Return how many bytes
5756 coding->destination was relocated.
5757 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5758 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5759
57602011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5761
5762 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5763 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5764 macro (Bug#9318).
5765
57662011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5767
5768 The following changes are to fix Bug#9318.
5769
a79703f5 5770 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5771 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5772 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5773 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5774
7dbda6df
JB
57752011-12-05 Juanma Barranquero <lekktu@gmail.com>
5776
5777 * lisp.h (process_quit_flag): Fix external declaration.
5778
6d5eb5b0
SM
57792011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5780
5781 Don't macro-inline non-performance-critical code.
5782 * eval.c (process_quit_flag): New function.
5783 * lisp.h (QUIT): Use it.
5784
a0c3fad0
JD
57852011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5786
5787 * nsfns.m (get_geometry_from_preferences): New function.
5788 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5789
6c07aac2
AS
57902011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5791
5792 * emacs.c (Qkill_emacs): Define.
5793 (syms_of_emacs): Initialize it.
5794 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5795 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5796 (quit_throw_to_read_char): Add parameter `from_signal'.
5797 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5798 * lisp.h (QUIT): Call Fkill_emacs if requested.
5799
c052ead4
JD
58002011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5801
5802 * widget.c (update_wm_hints): Return if wmshell is null.
5803 (widget_update_wm_size_hints): New function.
5804
5805 * widget.h (widget_update_wm_size_hints): Declare.
5806
5807 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5808 widget_update_wm_size_hints (Bug#10104).
5809
9e49252b
EZ
58102011-12-03 Eli Zaretskii <eliz@gnu.org>
5811
5812 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5813 before a newline, prepare the bidi iterator for consuming the
5814 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5815 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5816
02b16839
JL
58172011-12-02 Juri Linkov <juri@jurta.org>
5818
5819 * search.c (Fword_search_regexp): New Lisp function created from
5820 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5821 (Fword_search_backward, Fword_search_forward)
5822 (Fword_search_backward_lax, Fword_search_forward_lax):
5823 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5824 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5825
0068070e
SM
58262011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5827
5828 * fileio.c (Finsert_file_contents): Move after-change-function call
5829 to before the "handled:" label, since all "goto handled" appear in
5830 cases where the *-change-functions have already been properly called
5831 (bug#10117).
5832
3360a3fc
AS
58332011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5834
5835 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5836 waiting for input. (Bug#10169)
5837
73d6c093
EZ
58382011-11-30 Eli Zaretskii <eliz@gnu.org>
5839
5840 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5841 verifies glyph row's hash code--we have just reallocated the
5842 glyphs, so their contents can be complete garbage. (Bug#10164)
5843
febe6bea
JB
58442011-11-30 Juanma Barranquero <lekktu@gmail.com>
5845
5846 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5847
801a4313
EZ
58482011-11-30 Eli Zaretskii <eliz@gnu.org>
5849
5850 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5851 attributes are tested _before_ calling verify_row_hash, to protect
5852 against GCC re-ordering of the tests. (Bug#10164)
5853
2b56b87e
JD
58542011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5855
5856 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5857
5858 * xterm.c (handle_one_xevent): Only set async_visible and friends
5859 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5860 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5861 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5862
dbf31225
PE
58632011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5864
5865 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5866 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5867 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5868 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5869 All uses changed to use GCPRO1 etc.
5870 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5871 Revert to old implementation (i.e., before 2011-03-11).
5872
1305621b
YM
58732011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5874
5875 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5876 of scroll runs so as to avoid assigning disabled bogus rows and
5877 unnecessary graphics copy operations.
5878
8c9afb46
EZ
58792011-11-27 Eli Zaretskii <eliz@gnu.org>
5880
5881 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5882 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5883 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5884 (malloc, free, realloc, calloc): Redirect to e_* only when
5885 compiling Emacs.
5886
5887 * lisp.h (GCTYPEBITS): Move before first use.
5888 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5889 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5890 this macro definition.
5891
5892 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5893 _MSC_VER.
5894
54e9e3bf
JD
58952011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5896
6d5eb5b0
SM
5897 * gtkutil.c (xg_create_frame_widgets):
5898 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5899 present with Gtk+ 2.0.
5900
83aca1cb
PE
59012011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5902
5903 * fileio.c (Finsert_file_contents): Undo previous change; see
5904 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5905
5b76caa4
PE
59062011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5907
5908 Rename locals to avoid shadowing.
5909 * fileio.c (Finsert_file_contents):
5910 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5911 * process.c (wait_reading_process_output):
5912 Rename inner 'proc' to 'p' to avoid shadowing.
5913 Indent for consistency with usual Emacs style.
5914
8c535114
EZ
59152011-11-25 Eli Zaretskii <eliz@gnu.org>
5916
5917 * xdisp.c (redisplay_window): If cursor row is not fully visible
5918 after recentering, and scroll-conservatively is set to a large
5919 number, scroll window by a few more lines to make the cursor fully
5920 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5921 (start_display): Don't move to the next line if the display should
5922 start at a newline that is part of a display vector or an overlay
5923 string. (Bug#10119)
8c535114 5924
fa4fdb5c
JL
59252011-11-24 Juri Linkov <juri@jurta.org>
5926
5927 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5928 after the `MagickPingImage' call. (Bug#10112)
5929
90ec88df
CY
59302011-11-23 Chong Yidong <cyd@gnu.org>
5931
5932 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5933
56e2e794
MR
59342011-11-23 Martin Rudalics <rudalics@gmx.at>
5935
5936 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5937 making another buffer current. (Bug#10114)
5938
b6e64c41
GM
59392011-11-23 Glenn Morris <rgm@gnu.org>
5940
5941 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5942
6b21de18
CY
59432011-11-23 Chong Yidong <cyd@gnu.org>
5944
5945 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5946 using it (Bug#5984).
5947
b12cd789
EZ
59482011-11-22 Eli Zaretskii <eliz@gnu.org>
5949
5950 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5951 and header-lines, as they don't have one computed for them.
5952 (Bug#10098)
5953
5954 * .gdbinit (prow): Make displayed values more self-explaining.
5955 Add row's hash code.
5956
261b6fd4
LMI
59572011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5958
5959 * process.c (wait_reading_process_output): Fix asynchrounous
5960 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5961 (wait_reading_process_output): Add comment and URL.
261b6fd4 5962
e7cfd277
JD
59632011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5964
5965 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5966
a9b9b7f5
CY
59672011-11-21 Chong Yidong <cyd@gnu.org>
5968
5969 * window.c (Fnext_window, Fprevious_window): Doc fix.
5970
b0d15b4f
SM
59712011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5972
5973 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5974
fe7a3057
JB
59752011-11-20 Juanma Barranquero <lekktu@gmail.com>
5976
5977 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5978
d2999b1a
MR
59792011-11-20 Martin Rudalics <rudalics@gmx.at>
5980
5981 * window.c (Fset_window_combination_limit): Rename argument
5982 STATUS to LIMIT.
5983 (Vwindow_combination_limit): Remove "status" from doc-string.
5984
d5ff9cd0
AS
59852011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5986
5987 * m/ibms390.h: Remove.
5988 * m/ibms390x.h: Don't include "ibms390.h".
5989
a5bb9bd3
SM
59902011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5991
5992 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5993 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5994
cd1181db
JB
59952011-11-20 Juanma Barranquero <lekktu@gmail.com>
5996
5997 * casetab.c (Fset_case_table):
5998 * charset.c (Fcharset_after): Fix typos.
5999
615a3b8d 60002011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6001
17e845af
PE
6002 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6003 Otherwise, valgrind does not work on some platforms.
6004 Problem reported by Andreas Schwab in
6a0bf43d
PE
6005 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6006 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6007 is set, removing the need for VIRT_ADDRESS_VARIES.
6008 (PURE_P): Use a more-efficient implementation that needs just one
6009 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6010 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6011 to 4 (xorl, subq, cmpq, setbe).
6012 * alloc.c (pure): Always extern now, since that's the
6013 VIRT_ADDR_VARIES behavior.
6014 (PURE_POINTER_P): Use a single comparison, not two, for
6015 consistency with the new puresize.h.
6016 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6017 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6018 Remove VIRT_ADDR_VARIES no longer needed.
6019
f8fe6f96
EZ
60202011-11-19 Eli Zaretskii <eliz@gnu.org>
6021
6022 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6023 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6024 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6025 behave as if the cursor position were at the window margin.
6026
6027 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6028 and the cursor position is out of bounds, behave as if the cursor
6029 position were at the window margin. (Bug#10075)
6030
df05a53c
CY
60312011-11-18 Chong Yidong <cyd@gnu.org>
6032
6033 * window.c (Fwindow_combination_limit): Make first argument
6034 non-optional, since it is meaningless for live windows like the
6035 selected window.
61ccba97 6036
2071918e
DA
60372011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6038
6039 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6040
b50a28de
SM
60412011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6042
6043 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6044 (graft_intervals_into_buffer): Simplify.
6045
015137db
EZ
60462011-11-18 Eli Zaretskii <eliz@gnu.org>
6047
6048 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6049 hash values of the two rows.
6050 (copy_row_except_pointers): Preserve the used[] arrays and the
6051 hash values of the two rows. (Bug#10035)
68c95424 6052 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6053
6054 * xdisp.c (row_hash): New function, body extracted from
6055 compute_line_metrics.
6056 (compute_line_metrics): Call row_hash, instead of computing the
6057 hash code inline.
6058
6059 * dispnew.c (verify_row_hash): Call row_hash for computing the
6060 hash code of a row, instead of duplicating code from xdisp.c.
6061
6062 * dispextern.h (row_hash): Add prototype.
6063
a2addb04
TH
60642011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6065
6066 * frame.c (delete_frame): Don't delete the terminal when the last
6067 X frame is closed if emacs is built with GTK toolkit.
6068
df85d315
JB
60692011-11-17 Juanma Barranquero <lekktu@gmail.com>
6070
6071 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6072
a0c2d0ae
MR
60732011-11-17 Martin Rudalics <rudalics@gmx.at>
6074
6075 * window.c (Vwindow_splits): Rename to
6076 Vwindow_combination_resize. Suggested by Juri Linkov.
6077 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6078 of Vwindow_splits.
6079
58179cce
JB
60802011-11-16 Juanma Barranquero <lekktu@gmail.com>
6081
7877f373
JB
6082 * nsfns.m (Fns_font_name):
6083 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6084
b6f67890
MR
60852011-11-16 Martin Rudalics <rudalics@gmx.at>
6086
6087 * window.h (window): Rename slot "nest" to "combination_limit".
6088 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6089 (Fset_window_nest): Rename to Fset_window_combination_limit.
6090 (Vwindow_nest): Rename to Vwindow_combination_limit.
6091 (recombine_windows, make_parent_window, make_window)
6092 (Fsplit_window_internal, saved_window)
6093 (Fset_window_configuration, save_window_save): Rename all
6094 occurrences of window_nest to window_combination_limit.
6095
c7015153
JB
60962011-11-15 Juanma Barranquero <lekktu@gmail.com>
6097
6098 * image.c (imagemagick_load_image): Fix typo.
6099
322ad6ec
EZ
61002011-11-14 Eli Zaretskii <eliz@gnu.org>
6101
6102 * xdisp.c (display_line): Move the call to
6103 highlight_trailing_whitespace before the call to
6104 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6105 faces of all the glyphs to compute ROW's hash value.
6106 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6107
f067b8ec
JB
61082011-11-14 Juanma Barranquero <lekktu@gmail.com>
6109
6110 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6111 just return (bug#10044).
6112
1e5b2111
EZ
61132011-11-12 Eli Zaretskii <eliz@gnu.org>
6114
7ef3cbd5
EZ
6115 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6116 with user-defined heap size. Bump the default size of the temacs
6117 heap to 27MB, to avoid memory warning when running temacs.
6118 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6119
1e5b2111
EZ
6120 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6121 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6122 (verify_row_hash) [XASSERTS]: New function.
6123 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6124 that the hash value of glyph rows is correct.
1e5b2111 6125
89d61221
MR
61262011-11-12 Martin Rudalics <rudalics@gmx.at>
6127
6128 * window.h (window): Remove splits slot.
6129 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6130 (Fdelete_other_windows_internal, make_parent_window)
6131 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6132 (Fset_window_configuration, save_window_save): Don't deal with
6133 split status of windows.
6134 (saved_window): Remove splits slot.
6135 (Vwindow_splits): Rewrite doc-string.
6136
97f18cc8
JD
61372011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6138
6139 * xfns.c (unwind_create_frame):
6140 * nsfns.m (unwind_create_frame):
6141 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6142 Vframe_list (Bug#9999).
6143
22a648b4
DA
61442011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6145
0b381c7e 6146 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6147
659afede
KH
61482011-11-11 Kenichi Handa <handa@m17n.org>
6149
6150 * callproc.c (Fcall_process): Set the member dst_multibyte of
6151 process_coding.
6152
9ac0394b
KH
61532011-11-11 Johan Bockgård <bojohan@gnu.org>
6154
6155 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6156 avoid a crash (bug#9496).
6157
2fbdc249
CY
61582011-11-09 Chong Yidong <cyd@gnu.org>
6159
6160 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6161 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6162
ac6b1f81
PE
61632011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6164
6165 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6166
09db192c
PE
61672011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6168
6169 Avoid some portability problems by eschewing 'extern inline' functions.
6170 The trivial performance wins aren't worth the portability hassles; see
6171 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6172 et seq.
6173 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6174 (window_box_width, window_box_left, window_box_left_offset)
6175 (window_box_right, window_box_right_offset): Undo previous change,
6176 by removing the "extern"s.
6177 * intervals.c (adjust_intervals_for_insertion)
6178 (adjust_intervals_for_deletion): Undo previous change,
6179 making these static again.
6180 (offset_intervals, temp_set_point_both, temp_set_point)
6181 (copy_intervals_to_string): No longer inline.
6182 * xdisp.c (window_text_bottom_y, window_box_width)
6183 (window_box_height, window_box_left_offset)
6184 (window_box_right_offset, window_box_left, window_box_right)
6185 (window_box): No longer inline.
6186
105216ed
CY
61872011-11-08 Chong Yidong <cyd@gnu.org>
6188
6189 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6190 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6191 Signal an error if not a live window.
105216ed
CY
6192 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6193 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6194
ae9e237f
JB
61952011-11-07 Juanma Barranquero <lekktu@gmail.com>
6196
6197 * lisp.h (syms_of_abbrev): Remove declaration.
6198 Reported by CHENG Gao <chenggao@royau.me>.
6199
c7aa8333
EZ
62002011-11-07 Eli Zaretskii <eliz@gnu.org>
6201
6202 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6203 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6204 of temacs in GUI mode.
6205
be7f5545
MR
62062011-11-07 Martin Rudalics <rudalics@gmx.at>
6207
6208 * window.h: Declare delete_all_child_windows instead of
6209 delete_all_subwindows.
6210 * window.c (Fwindow_nest, Fset_window_nest)
6211 (Fset_window_new_total, Fset_window_new_normal)
6212 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6213 (delete_all_subwindows): Rename to delete_all_child_windows.
6214 (Fdelete_other_windows_internal, Fset_window_configuration):
6215 Call delete_all_child_windows instead of delete_all_subwindows.
6216 * frame.c (delete_frame): Call delete_all_child_windows instead
6217 of delete_all_subwindows.
6218
ca78dc43
PE
62192011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6220
6221 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6222 This is also needed for porting to any host where GC_MARK_STACK is
6223 not GC_MAKE_GCPROS_NOOPS.
6224 (which_symbols): Use it.
6225
a0241d01
KH
62262011-11-07 Kenichi Handa <handa@m17n.org>
6227
6228 * coding.c (coding_set_destination): Check coding->src_pos only
6229 when coding->src_object is a buffer (bug#9910).
6230
6231 * process.c (send_process): Set the member src_multibyte of coding
6232 to 0 (bug#9911) when sending a unibyte text.
6233
6234 * callproc.c (Fcall_process): Set the member src_multibyte of
6235 process_coding to 0 (bug#9912).
6236
a64bfdfa 62372011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6238
6239 * xmenu.c (cleanup_widget_value_tree): New function.
6240 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6241 calling free_menubar_widget_value_tree directly (Bug#9830).
6242
cb41b32a
PE
62432011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6244
6245 Fix some portability problems with 'inline'.
6246 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6247 (window_box_width, window_box_left, window_box_left_offset)
6248 (window_box_right, window_box_right_offset): Declare extern.
6249 Otherwise, these inline functions do not conform to C99 and
6250 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6251 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6252 * intervals.c (adjust_intervals_for_insertion)
6253 (adjust_intervals_for_deletion): Now extern, because otherwise the
6254 extern inline functions 'offset_intervals' couldn't refer to it.
6255 (static_offset_intervals): Remove.
6256 (offset_intervals): Rewrite using the old contents of
6257 static_offset_intervals. The old version didn't conform to C99
6258 because an extern inline function contained a reference to an
6259 identifier with static linkage.
6260
b7041366
AS
62612011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6262
6263 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6264 GC.
6265
88a37c4d
EZ
62662011-11-06 Eli Zaretskii <eliz@gnu.org>
6267
6268 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6269 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6270 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6271 return Qleft_to_right.
6272
49745b39
CY
62732011-11-06 Chong Yidong <cyd@gnu.org>
6274
6275 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6276 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6277 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6278 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6279 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6280 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6281 (Fwindow_vscroll): Doc fix.
6282 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6283 argument, since it makes no sense to pass a live window and for
6284 consistency with window-child.
6285
1f05cd82
CS
62862011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6287
6288 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6289 support MSVC.
6290
22610910
JR
62912011-11-05 Jason Rumney <jasonr@gnu.org>
6292
6293 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6294 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6295 fonts (Bug#6029).
6296 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6297 bitwise arithmetic preventing use of unicode-sip and non-truetype
6298 opentype fonts.
6299
a06776b2
EZ
63002011-11-05 Eli Zaretskii <eliz@gnu.org>
6301
3ad924ba
EZ
6302 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6303 "emacs"-only part.
6304
a06776b2
EZ
6305 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6306 initialization code to keep similarity to xfns.c after changes
6307 from 2011-11-05.
6308
c9e7db78
JD
63092011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6310
a97f8f3f
JD
6311 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6312 (unwind_create_frame): New function (Bug#9943).
6313 (Fx_create_frame): Restructure code to be more similar to the one in
6314 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6315 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6316 Move terminal->reference_count++ just before making the frame official
6317 (Bug#9943).
6318
6319 * nsterm.m (x_free_frame_resources): New function.
6320 (x_destroy_window): Move code to x_free_frame_resources.
6321
c9e7db78 6322 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6323 (Fx_create_frame, x_create_tip_frame):
6324 Move terminal->reference_count++ just before making the frame
75f1671a 6325 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6326 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6327
a6fc3b5c
EZ
63282011-11-05 Eli Zaretskii <eliz@gnu.org>
6329
6330 Support MSVC build with newer versions of Visual Studio.
6331 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6332 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6333 nt/gmake.defs.
6334
6335 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6336 which are not supported by MSVC.
6337 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6338 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6339 bitfields.
6340 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6341 types in bitfields.
6342 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6343
6344 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6345
58179cce 63462011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6347
6348 Support MSVC build with newer versions of Visual Studio.
6349 * w32.c: Don't include w32api.h for MSVC.
6350 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6351
6352 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6353 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6354 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6355 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6356 e_* cousins.
6357 (alloca) [_MSC_VER]: Define to _alloca.
6358
6359 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6360
6361 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6362
a58c13ed
EZ
63632011-11-04 Eli Zaretskii <eliz@gnu.org>
6364
6365 * xdisp.c (note_mouse_highlight): If either of
6366 previous/next-single-property-change returns nil, treat that as
6367 the beginning or the end of the buffer. (Bug#9955)
6368
fe0b6370
JD
63692011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6370
a58c13ed 6371 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6372 label is not null (Bug#9951).
6373 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6374 may be NULL.
6375
89bd5ee1
EZ
63762011-11-04 Eli Zaretskii <eliz@gnu.org>
6377
6378 * window.c (Fwindow_body_size): Mention in the doc string that the
6379 return value is in frame's canonical units. (Bug#9949)
6380
84c3edb9
EZ
63812011-11-03 Eli Zaretskii <eliz@gnu.org>
6382
4e2fb5c7
EZ
6383 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6384
84c3edb9 6385 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6386 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6387 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6388
bc17a887
EZ
63892011-11-01 Eli Zaretskii <eliz@gnu.org>
6390
6391 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6392 Don't stop backward scan on the continuation glyph, even though
6393 its CHARPOS is positive.
6d5eb5b0
SM
6394 (mouse_face_from_buffer_pos, note_mouse_highlight):
6395 Rename cover_string to disp_string.
bc17a887 6396
4ee88440
MR
63972011-11-01 Martin Rudalics <rudalics@gmx.at>
6398
6399 * window.c (temp_output_buffer_show): Don't use
6400 Vtemp_buffer_show_specifiers.
6401 (Vtemp_buffer_show_specifiers): Remove unused variable.
6402
c2ff3c02
EZ
64032011-10-30 Eli Zaretskii <eliz@gnu.org>
6404
6405 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6406 past the beginning of the current glyph matrix.
6407
58179cce 64082011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6409
6410 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6411 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6412 HAVE_GTK3 (Bug#9869).
b77a6a7f 6413
3b574623
JD
6414 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6415 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6416
b77a6a7f
JD
6417 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6418
6419 * xterm.c: Declare x_handle_net_wm_state to return int.
6420 (handle_one_xevent): Check if we are iconified but don't have
6421 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6422 (get_current_wm_state): Return non-zero if not hidden,
6423 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6424 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6425 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6426 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6427
196e41e4
PE
64282011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6429
6430 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6431 so that this new function doesn't get optimized away by a
6432 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6433
021f2e1a
AS
64342011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6435
6436 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6437
8b058d44
EZ
64382011-10-29 Eli Zaretskii <eliz@gnu.org>
6439
6440 Fix the `xbytecode' command.
6441 * .gdbinit (xprintbytestr): New command.
b50a28de 6442 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6443 (xbytecode): Print the byte-code string as well.
6444
4452fb80
EZ
64452011-10-29 Kim Storm <storm@cua.dk>
6446
8b058d44
EZ
6447 * alloc.c (which_symbols): New function.
6448
21b72067
AS
64492011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6450
6451 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6452 line. (Bug#9903)
6453
83ed7b5c
GM
64542011-10-29 Glenn Morris <rgm@gnu.org>
6455
6456 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6457 Not clear what it was for, and it causes various bugs. (Bug#9839)
6458
5a7a728b
EZ
64592011-10-28 Eli Zaretskii <eliz@gnu.org>
6460
6461 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6462 possible random value that matches one of those tested as
6463 condition to clear the mouse face.
6464
d3d0842f
CY
64652011-10-28 Chong Yidong <cyd@gnu.org>
6466
6467 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6468
31b39d13
DN
64692011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6470
6471 * window.c (make_window): Initialize phys_cursor_on_p.
6472
9aba6043
SM
64732011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6474
6475 * lisp.h (struct Lisp_Symbol): Update comments.
6476
c20992f4
JB
64772011-10-28 Juanma Barranquero <lekktu@gmail.com>
6478
6479 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6480
db4f02f2
EZ
64812011-10-28 Eli Zaretskii <eliz@gnu.org>
6482
6483 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6484 <oslsachem@gmail.com> for helping to debug this.
6485
6486 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6487 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6488 (g_b_init_get_glyph_outline_w): New static variables.
6489 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6490 (GetGlyphOutlineW_Proc): New typedefs.
6491 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6492 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6493 New functions.
6494 (w32font_open_internal, compute_metrics):
6495 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6496 instead of calling the "wide" APIs directly.
6497
6498 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6499
6500 * w32.h (syms_of_w32font): Add prototype.
6501
87e68db4
JB
65022011-10-27 Juanma Barranquero <lekktu@gmail.com>
6503
6504 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6505 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6506 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6507 (Fmove_to_window_line): Doc fix.
6508
435c1d67
CY
65092011-10-27 Chong Yidong <cyd@gnu.org>
6510
6511 * process.c (make_process): Set gnutls_state to NULL.
6512
6513 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6514 non-NULL, regardless of GNUTLS_INITSTAGE.
6515 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6516 an error. Set process slots as soon as we allocate them.
6517
6518 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6519
9c6c6f49
CY
65202011-10-27 Chong Yidong <cyd@gnu.org>
6521
9aba6043
SM
6522 * gnutls.c (emacs_gnutls_deinit): New function.
6523 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6524 (Fgnutls_deinit, Fgnutls_boot): Use it.
6525
6526 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6527 (deactivate_process): Call emacs_gnutls_deinit.
6528
657d08d3
JB
65292011-10-27 Juanma Barranquero <lekktu@gmail.com>
6530
6531 * image.c (x_create_x_image_and_pixmap):
6532 * w32.c (sys_rename, w32_delayed_load):
6533 * w32font.c (fill_in_logfont):
6534 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6535
5430d399
JB
65362011-10-26 Juanma Barranquero <lekktu@gmail.com>
6537
6538 * w32fns.c (w32_default_color_map): New function,
6539 extracted from Fw32_default_color_map.
a7ef684b 6540 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6541
fe0055fa
PE
65422011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6543
6544 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6545
e6346438
SM
65462011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6547
6548 * keyboard.c (test_undefined): New function (bug#9751).
6549 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6550
e112cc37
ET
65512011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6552
6553 * sysdep.c (init_sys_modes): Fix the check for the controlling
6554 terminal (Bug#6649).
6555
7b5d6677
EZ
65562011-10-20 Eli Zaretskii <eliz@gnu.org>
6557
6558 * dispextern.h (struct bidi_it): New member next_en_type.
6559
6560 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6561 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6562 current character, check also for next_en_type being WEAK_EN.
6563 (bidi_resolve_weak): Don't enter the expensive loop if the current
6564 position is before next_en_pos. Record the bidi type of the first
6565 non-ET, non-BN character we find, in addition to its position.
6566 (bidi_level_of_next_char): Invalidate next_en_type when
6567 next_en_pos is over-stepped.
6568
7da0b018
PE
65692011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6570
6571 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6572 * editfns.c: Rewrite current-time-zone so that it invokes
6573 the equivalent of (format-time-string "%Z") to get the time zone name.
6574 This fixes a bug when the time zone name contains characters that
6575 need converting from the system time locale to Emacs internal format.
6576 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6577 that patch fixed format-time-string to do the conversion, but
6578 I forgot to fix current-time-zone.
6579 (format_time_string): New function, containing most of
6580 what Fformat_time_string used to contain.
6581 (Fformat_time_string): Rewrite in terms of format_time_string.
6582 This doesn't change this function's behavior.
6583 (current-time-zone): Rewrite to use format_time_string.
6584 This fixes the bug reported by Michael Schierl in
6585 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6586 Jason Rumney's 2007-06-07 change worked around this bug, but
6587 didn't fix it.
6588 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6589
8547b010
EZ
65902011-10-19 Eli Zaretskii <eliz@gnu.org>
6591
6592 * xdisp.c (start_display): If the character at POS is displayed
6593 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6594 (try_window_reusing_current_matrix): If a line ends in a display
6595 vector or the next line starts in a display vector, continue
6596 redrawing the window even though the character position of
6597 start_row was reached.
8547b010
EZ
6598 (Bug#9771, part 2)
6599
4e948d15
CY
66002011-10-18 Chong Yidong <cyd@gnu.org>
6601
6602 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6603 with nobreak-char-display too.
6604
4787455f
EZ
66052011-10-18 Eli Zaretskii <eliz@gnu.org>
6606
6607 Fix part 3 of bug#9771.
6608 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6609 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6610 non-neutral characters if the current character is a paragraph
6611 separator (a.k.a. Newline). This avoids running the same
6612 expensive loop twice, once when we consume the preceding newline
6613 and the other time when the line actually needs to be displayed.
6614 Avoid the loop when we see neutrals on the base embedding level
6615 following a character whose directionality is the same as the
6616 paragraph's. This avoids running the expensive loop when a line
6617 ends in a long sequence of neutrals, like control characters.
6618 Add assertion against STRONG_AL type. Slightly rearrange code
6619 that determines the type of a neutral given the first non-neutral
6620 that follows it.
6621 (bidi_level_of_next_char): Set next_en_pos to zero when
6622 invalidating its info.
6623
2c91f553
EZ
66242011-10-17 Eli Zaretskii <eliz@gnu.org>
6625
6626 * xdisp.c (push_display_prop): Determine whether to record string
6627 or buffer position by IT->string, not by IT->method. Allow
6628 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6629 (move_it_vertically_backward): Don't look for character position
6630 immediately after the newline when in a continuation line.
6631 (Bug#9771, part 1)
2c91f553 6632
c7b08b0d
MR
66332011-10-15 Martin Rudalics <rudalics@gmx.at>
6634
6635 * window.c (coordinates_in_window): Rewrite and delabelize
6636 vertical border check. (Bug#5357) (Bug#9618)
6637
6b02f655
SM
66382011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6639
6640 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6641 errors in XSetWindowBorder (bug#9310).
6642
81d40c92
DA
66432011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6644
6645 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6646 avoid crash when xmalloc overrun checking is enabled.
6647
d4172c3b
EZ
66482011-10-13 Eli Zaretskii <eliz@gnu.org>
6649
6650 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6651 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6652 cursor motion with <left> and <right> arrow keys.
6653
6654 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6655 some callers set that themselves.
6656
b00eea75
EZ
66572011-10-12 Eli Zaretskii <eliz@gnu.org>
6658
6659 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6660 display string and the previous row comes from the same string and
6661 is empty. (Bug#9739) (Bug#9738)
6662
8fe012c4
SM
66632011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6664
6665 * doc.c (get_doc_string): Encode file name (bug#9735).
6666
0074aef2
EZ
66672011-10-12 Eli Zaretskii <eliz@gnu.org>
6668
79beb178
EZ
6669 * bidi.c (bidi_level_of_next_char):
6670 * xdisp.c (get_visually_first_element): Remove old incorrect
6671 comments regarding the Unicode Line Separator character.
6672
0074aef2
EZ
6673 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6674
6e4b3fbe
DA
66752011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6676
6677 * alloc.c (Fgc_status): Do not access beyond zombies array
6678 boundary if nzombies > MAX_ZOMBIES.
6679 * alloc.c (dump_zombies): Add missing format specifier.
6680
0324f3af
PE
66812011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6682
b5525cac
PE
6683 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6684 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6685
0324f3af
PE
6686 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6687 Some packages use them to denote characters with modifiers.
6688
e9b5f888
AS
66892011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6690
6691 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6692 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6693 matching a pp-number. Rename parameter var to var1.
6694
127827c0
SM
66952011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6696
6697 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6698
c8fd3bd0
GM
66992011-10-08 Glenn Morris <rgm@gnu.org>
6700
6701 * callint.c (Fcall_interactively): Give a more explicit error for the
6702 'c' case with a non-character input. (Bug#8479)
6703
352ec8ff
EZ
67042011-10-08 Eli Zaretskii <eliz@gnu.org>
6705
03669ccb
EZ
6706 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6707 lines.
7061c986
EZ
6708 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6709 lines that are hscrolled on the left.
03669ccb 6710
352ec8ff
EZ
6711 * dispnew.c (buffer_posn_from_coords): Account for a possible
6712 presence of header-line. (Bug#4426)
6713
a66cfb1c
SM
67142011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6715
6b02f655
SM
6716 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6717 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6718
7c5ee88e
PE
67192011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6720
6721 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6722 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6723 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6724 this makes Emacs dump core during garbage collection on rare
6725 occasions. sizeof is obviously inferior to offsetof here, so
6726 stick with offsetof.
6727 (GC_POINTER_ALIGNMENT): New macro.
6728 (mark_memory): Omit 3rd (offset) arg; caller changed.
6729 Don't assume EMACS_INT alignment is the same as pointer alignment.
6730
df1bbe5b
SM
67312011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6732
6733 * keyboard.c (read_key_sequence_remapped): New var.
6734 (read_key_sequence): Compute remapping in the right buffer.
6735 (command_loop_1): Use read_key_sequence's remapping directly.
6736
51553db6
SM
67372011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6738
32c1fffd
SM
6739 * dired.c (file_name_completion): Don't expand file name.
6740 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6741 before checking file name handler.
6742
51553db6
SM
6743 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6744 they've been requested explicitly (bug#9591).
6745
b6bd1599 67462011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6747
6748 * keymap.c (Fsingle_key_description): Use make_specified_string
6749 instead of build_string to build string from push_key_description.
6750 (Bug#5193)
6751
f701dc2a
PE
67522011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6753
4222c55d
PE
6754 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6755 This fixes a Y2038 bug on 64-bit hosts.
6756 * buffer.c (reset_buffer):
6757 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6758 (Fclear_buffer_auto_save_failure):
6759 Use 0, not -1, to represent an unset failure time, since time_t
6760 might not be signed.
6761
f701dc2a
PE
6762 Remove dependency on glibc malloc internals.
6763 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6764 Move back here from lisp.h, but with their new implementations.
6765 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6766 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6767 * charset.c (charset_table_init): New static var.
6768 (syms_of_charset): Use it instead of xmalloc. This removes a
6769 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6770 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6771 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6772 Move back to alloc.c.
6773 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6774 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6775
9ceebf39
JD
67762011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6777
6778 * nsterm.m (windowDidResize): Call x_set_window_size only when
6779 ns_in_resize is true. Otherwise set pixelwidth/height and
6780 call change_frame_size (Bug#9628).
6781
cb993c58
PE
67822011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6783
3930c88b
PE
6784 Port --enable-checking=all to Fedora 14 x86-64.
6785 * charset.c (syms_of_charset): Also account for glibc malloc's
6786 internal overhead when calculating the initial malloc maximum.
6787
cb993c58
PE
6788 Port --enable-checking=all to Fedora 14 x86.
6789 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6790 Move to lisp.h.
6791 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6792 (overrun_check_realloc, overrun_check_free):
6793 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6794 That way, xmalloc returns a properly-aligned pointer even if
6795 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6796 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6797 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6798 into account when calculating the initial malloc maximum.
6799 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6800 Move here from alloc.c, so that charset.c can use it too.
6801 Properly align; the old code wasn't right for common 32-bit hosts
6802 when configured with --enable-checking=all.
6803 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6804 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6805
31bed486
EZ
68062011-09-29 Eli Zaretskii <eliz@gnu.org>
6807
04c70788 6808 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6809 use EDOM.
6810
fbcaa2f3
EZ
68112011-09-28 Eli Zaretskii <eliz@gnu.org>
6812
6813 * xdisp.c (compute_display_string_end): If there's no display
6814 string at CHARPOS, return -1.
6815
6816 * bidi.c (bidi_fetch_char): When compute_display_string_end
6817 returns a negative value, treat the character as a normal
6818 character not covered by a display string. (Bug#9624)
6819
a239d4e9
JB
68202011-09-28 Juanma Barranquero <lekktu@gmail.com>
6821
6822 * lread.c (Fread_from_string): Fix typo in docstring.
6823
88652fd5
EZ
68242011-09-27 Eli Zaretskii <eliz@gnu.org>
6825
6826 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6827 newline, reseat the iterator instead of bidi-iterating there one
6828 character at a time. (Bug#9610)
32c1fffd
SM
6829 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6830 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6831
ed497dd4
AS
68322011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6833
6834 * lread.c (readevalloop): Use correct code for NBSP.
6835 (read1): Likewise. (Bug#9608)
6836
b2bf61aa
MA
68372011-09-25 Michael Albinus <michael.albinus@gmx.de>
6838
6839 * dbusbind.c (Fdbus_register_signal): When service is not
6840 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6841
32bbb17c
GM
68422011-09-25 Glenn Morris <rgm@gnu.org>
6843
6844 * buffer.c (truncate-lines): Doc fix.
6845
94e0933e
CY
68462011-09-24 Chong Yidong <cyd@stupidchicken.com>
6847
6848 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6849 (Fset_window_next_buffers): Doc fix.
6850
cddde921
GM
68512011-09-24 Glenn Morris <rgm@gnu.org>
6852
6853 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6854
1260aef1
PE
68552011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6856
25b4bfa0
PE
6857 Fix minor problems found by static checking.
6858 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6859 * indent.c (Fvertical_motion): Fix == vs = typo.
6860
e3cbd34b
EZ
68612011-09-24 Eli Zaretskii <eliz@gnu.org>
6862
a66cfb1c
SM
6863 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6864 Default value is now t. Doc fix.
6bf7006f 6865
e3cbd34b 6866 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6867 logic when moving up, not only when moving down. Fix the
e3cbd34b 6868 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6869 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6870
6871 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6872 CHARPOS is covered by a display string which includes newlines.
6873 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6874 is covered by a display string with embedded newlines.
6875
a3de0cbd
MA
68762011-09-24 Michael Albinus <michael.albinus@gmx.de>
6877
6878 * dbusbind.c (Fdbus_register_signal): Add match rule to
6879 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6880 (Fdbus_register_method, Vdbus_registered_objects_table):
6881 Fix docstring.
a3de0cbd 6882
b260039d
JM
68832011-09-24 Jim Meyering <meyering@redhat.com>
6884
32c1fffd 6885 do not ignore write error for any output size
b260039d
JM
6886 The previous change was incomplete.
6887 While it makes emacs --batch detect the vast majority of stdout
6888 write failures, errors were still ignored whenever the output size is
6889 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6890 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6891 && echo FAIL: ignored write error
6892 FAIL: ignored write error
6893 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6894 && echo FAIL: ignored write error
6895 FAIL: ignored write error
6896 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6897
8eca8a7c
AS
68982011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6899
6900 * emacs.c (Fkill_emacs): In noninteractive mode exit
6901 non-successfully if a write error occurred on stdout. (Bug#9574)
6902
3341db62
EZ
69032011-09-21 Eli Zaretskii <eliz@gnu.org>
6904
6905 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6906 the xassert test.
6907
6908 * dispextern.h (struct it): Update the comment documenting what
6909 can it->OBJECT be.
6910
8c203dbf
EZ
69112011-09-20 Eli Zaretskii <eliz@gnu.org>
6912
6913 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6914 a display string, extend search for cursor position to end of row.
6915 (find_row_edges): If the row ends in a newline from a display
6916 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6917 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6918 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6919 non-empty line. Fixes confusing cursor motion with arrow keys at
6920 the beginning of a line that starts with whitespace.
8c203dbf 6921
a4824228
LMI
69222011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6923
6924 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6925 (bug#9493).
6926
33ed493b
CY
69272011-09-18 Chong Yidong <cyd@stupidchicken.com>
6928
6929 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6930 boolean (Bug#9154).
6931
56cd55c8
EZ
69322011-09-18 Eli Zaretskii <eliz@gnu.org>
6933
6934 * xdisp.c (display_line): Record maximum and minimum buffer
6935 positions even if no glyphs were produced (e.g., by a zero-width
6936 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6937 buffer positions that will be removed from the glyph row because
6938 they don't fit.
c02dcedf
EZ
6939 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6940 column is beyond frame width: don't subtract 1 "pixel" when
6941 computing width of the stretch.
3e62b7e0
EZ
6942 (reseat_at_next_visible_line_start): Undo the change made on
6943 2011-09-17 that saved paragraph information and restored it after
6944 the call to `reseat'. (Bug#9545)
56cd55c8 6945
5ed99d36 69462011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6947
6948 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6949 and turn window cursor on if cleared (Bug#9415).
6950
5ed99d36 69512011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6952
6953 * search.c (boyer_moore): Take unibyte characters from pattern
6954 literally. (Bug#9458)
6955
9bade7b2
EZ
69562011-09-18 Eli Zaretskii <eliz@gnu.org>
6957
6958 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6959
e5e9d610
PE
69602011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6961
87e4427a
PE
6962 Fix minor problem found by static checking.
6963 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6964 initialized, to pacify gcc -Wuninitialized.
6965
e5e9d610
PE
6966 * fileio.c: Report proper errno when syscall falls.
6967 (Finsert_file_contents): Save and restore errno,
6968 so that report_file_error outputs the correct diagnostic.
6969 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6970
a1674f0b
EZ
69712011-09-18 Eli Zaretskii <eliz@gnu.org>
6972
6973 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6974
fbfb6dd4
EZ
69752011-09-17 Eli Zaretskii <eliz@gnu.org>
6976
6977 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6978 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6979
bb187662
EZ
69802011-09-17 Eli Zaretskii <eliz@gnu.org>
6981
1137e8b8 6982 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6983 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6984
6985 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6986 (bidi_find_paragraph_start): Search back for paragraph beginning
6987 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6988 (bidi_move_to_visually_next): Only trigger paragraph-related
6989 computations when the last character is a newline or at EOB, not
6990 just any NEUTRAL_B. (Bug#9470)
6991
bb187662
EZ
6992 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6993 truncated lines if point is covered by a display string. (Bug#9524)
6994
2e621251
PE
69952011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6996
6997 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6998 (cons_to_x_long): New function.
6999 (lisp_data_to_selection_data): Use it. Correct the test for
7000 short-versus-long data; it was negated. Break out of vector
7001 loop, for efficiency, when a long datum is discovered.
7002
91a15bc6
SM
70032011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7004
7005 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7006
b41c3a35
EZ
70072011-09-16 Eli Zaretskii <eliz@gnu.org>
7008
7009 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7010 GCC PR/17406) by declaring this function with external scope.
7011
7812ba2d
PE
70122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7013
7014 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7015 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7016
cf7edc2a
AS
70172011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7018
7019 * editfns.c (Fformat): Correctly handle text properties on "%%".
7020
bd01620e
EZ
70212011-09-15 Eli Zaretskii <eliz@gnu.org>
7022
7023 * xterm.c (x_draw_composite_glyph_string_foreground):
7024 * w32term.c (x_draw_composite_glyph_string_foreground):
7025 * term.c (encode_terminal_code):
7026 * composite.c (composition_update_it, get_composition_id):
7027 * xdisp.c (get_next_display_element)
7028 (fill_composite_glyph_string): Add comments about special meaning
7029 of TAB characters in a composition.
7030
a02719a3
PE
70312011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7032
7033 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7034 This occurs when processing a multibyte format.
7035 Problem reported by Wolfgang Jenker.
a02719a3 7036
72589a3c
JB
70372011-09-15 Johan Bockgård <bojohan@gnu.org>
7038
7039 * xdisp.c (try_cursor_movement): Only check for exact match if
7040 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7041
1c14176c
PE
70422011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7043
7044 Remove unused external symbols.
7045 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7046 * xdisp.c (calc_pixel_width_or_height): Now static.
7047 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7048 * indent.c (check_display_width):
7049 * w32term.c: Fix comment to match code.
7050 * xterm.c, xterm.h (x_catching_errors): Remove.
7051
d2eea5b5
PE
70522011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7053
7054 * xselect.c: Use signed conversions more consistently (Bug#9498).
7055 (selection_data_to_lisp_data): Assume incoming selection data are
7056 signed integers, not unsigned. This is to be consistent with
7057 outgoing selection data, which was modified to use signed integers
7058 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7059 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7060 expects long, not unsigned long.
7061
46888499
EZ
70622011-09-14 Eli Zaretskii <eliz@gnu.org>
7063
7064 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7065 computation of loop end. Reported by Johan Bockgård
7066 <bojohan@gnu.org>.
7067
ef8ef9fb
CY
70682011-09-13 Chong Yidong <cyd@stupidchicken.com>
7069
7070 * frame.c (Fother_visible_frames_p): Function deleted.
7071
fa819fed
EZ
70722011-09-12 Eli Zaretskii <eliz@gnu.org>
7073
7074 * indent.c (compute_motion): Process display vector front to back
7075 rather than the other way around. (Bug#2496)
7076
2ba8e008
SM
70772011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7078
7079 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7080
20f53c69
CY
70812011-09-11 Chong Yidong <cyd@stupidchicken.com>
7082
7083 * minibuf.c (Fread_from_minibuffer): Doc fix.
7084
d562d7a4
EZ
70852011-09-11 Eli Zaretskii <eliz@gnu.org>
7086
7087 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7088 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7089
1c4d7f3d
LMI
70902011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7091
7092 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7093 value for non-existent files.
7094
b885bf36
EZ
70952011-09-11 Eli Zaretskii <eliz@gnu.org>
7096
7097 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7098 set its "size" to -1. This will set the modtime_size field of
7099 the corresponding buffer to -1, which is what
7100 verify-visited-file-modtime expects for files that do not exist.
7101 (Bug#9139)
7102
6612f0bf
PE
71032011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7104
7105 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7106 here ...
7107 * lisp.h: ... from here. push_key_description is no longer
7108 defined in keyboard.c, so its declaration should not be in
7109 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7110 logically belongs with push_key_description.
7111
dfb3f755
PE
71122011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7113
7114 * buffer.h: Include <sys/types.h> instead of <time.h>.
7115 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7116 Problem reported by Herbert J. Skuhra.
7117
3134906c
LMI
71182011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7119
7120 * xml.c (parse_region): Make the parsing work for
7121 non-comment-starting XML files again (bug#9144).
7122
8d903f4e
AS
71232011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7124
7125 * image.c (gif_load): Fix calculation of bottom and right corner.
7126 (Bug#9468)
7127
80ad64f4
EZ
71282011-09-10 Eli Zaretskii <eliz@gnu.org>
7129
7130 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7131 redisplay in small windows.
7132
208a048d
EZ
71332011-09-09 Eli Zaretskii <eliz@gnu.org>
7134
7135 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7136
9b1c252e
MR
71372011-09-08 Martin Rudalics <rudalics@gmx.at>
7138
7139 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7140 Operate on live windows only.
7141
2949f33b
JB
71422011-09-08 Juanma Barranquero <lekktu@gmail.com>
7143
7144 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7145
e08dcafd
EZ
71462011-09-07 Eli Zaretskii <eliz@gnu.org>
7147
7148 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7149 only under bidi iteration.
7150
115b96bd
JD
71512011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7152
7153 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7154
c8199d0f
PE
71552011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7156
7157 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7158 Without this fix, the command to link temacs failed due to an
7159 undefined symbol __builtin_isnan. This is because
7160 /usr/include/iso/math_c99.h #defines isnan(x) to
7161 __builtin_isnan(x), but the bundled gcc, which identifies itself
7162 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7163 a __builtin_isnan.
7164 * floatfns.c (isnan): #undef, and then #define to a clone of
7165 what's in data.c.
7166 (Fisnan): Always define, since it's always available now.
7167 (syms_of_floatfns): Always define isnan at the Lisp level.
7168
e39b275c 71692011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7170
7171 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7172
b2db44d9 71732011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7174
f4af5137 7175 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7176 The previous code assumed that file offsets (off_t values) fit in
7177 EMACS_INT variables, which is not true on typical 32-bit hosts.
7178 The code messed up by falsely reporting buffer overflow in cases
7179 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7180 when "big" contains more than 2**29 bytes, even though this
7181 inserts just one byte and does not overflow the buffer.
7182 (Finsert_file_contents): Store file offsets as off_t
7183 values, not as EMACS_INT values. Check for overflow when
7184 converting between EMACS_INT and off_t. When checking for
7185 buffer overflow or for overlap, take the offsets into account.
7186 Don't use EMACS_INT for small values where int suffices.
7187 When checking for overlap, fix a typo: ZV was used where
7188 ZV_BYTE was intended.
7189 (Fwrite_region): Don't assume off_t fits into 'long'.
7190 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7191
ecfc0a49
MA
71922011-09-05 Michael Albinus <michael.albinus@gmx.de>
7193
7194 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7195
6511acf2 71962011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7197
0999621a 7198 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7199
7200 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7201 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7202 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7203 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7204 (modify_event_symbol): Do not assume that the length of
7205 name_alist_or_stem is safe to alloca and fits in int.
7206 (Fexecute_extended_command): Likewise for function name and binding.
7207 (Frecursion_depth): Wrap around reliably on integer overflow.
7208 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7209 since some callers pass EMACS_INT values.
7210 (Fsingle_key_description): Don't crash if symbol name contains more
7211 than MAX_ALLOCA bytes.
7212 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7213 (get_minibuffer): Arg is now EMACS_INT, not int.
7214 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7215 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7216 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7217
2be7d702
PE
7218 * dbusbind.c (signature_cat): New function.
7219 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7220 Do not overrun buffer; instead, report string overflow.
7221
9d1df220
PE
7222 * dispnew.c (add_window_display_history): Don't overrun buffer.
7223 Truncate instead; this is OK since it's just a log.
7224
33ef5c64
PE
7225 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7226 even if the time zone offset is outlandishly large.
7227 Don't mishandle offset == INT_MIN.
7228
66c6fdd5
PE
7229 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7230 when creating daemon; the previous buffer-overflow check was incorrect.
7231
d749b01b
PE
7232 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7233 which has the guts of the old verror function.
7234
b5cd1905
PE
7235 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7236 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7237
6e1a67fb
PE
7238 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7239 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7240 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7241 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7242 length of string rather than counting it via multiple sprintfs;
7243 that's simpler and more reliable.
c21721cc
PE
7244 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7245 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7246 sprintf, in case result does not fit in int.
7247
c57b67fc
PE
7248 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7249 (fontset_from_font): Print it.
7250
8a401434
PE
7251 * frame.c (tty_frame_count): Now printmax_t, not int.
7252 (make_terminal_frame, set_term_frame_name): Print it.
7253 (x_report_frame_params): In X, window IDs are unsigned long,
7254 not signed long, so print them as unsigned.
7255 (validate_x_resource_name): Check for implausibly long names,
7256 and don't assume name length fits in 'int'.
7257 (x_get_resource_string): Don't blindly alloca invocation name;
7258 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7259 not fit in int.
7260
6e1a67fb
PE
7261 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7262 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7263 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7264
0df02bf3
PE
7265 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7266 Use esprintf, not sprintf, in case result does not fit in int.
7267
48e30793
PE
7268 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7269 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7270 it as a large positive number.
7271 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7272 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7273
a66ff6d8
PE
7274 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7275 in case result does not fit in int.
7276
aca216ff
PE
7277 * print.c (float_to_string): Detect width overflow more reliably.
7278 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7279 buffer overrun. Don't assume list length fits in 'int'. Treat
7280 print length of 0 as 0, not as infinity; to be consistent with other
7281 uses of print length in this function. Don't overflow print length
7282 index. Don't assume hash table size fits in 'long', or that
7283 vectorlike size fits in 'unsigned long'.
7284
31c286f7
PE
7285 * process.c (make_process): Use printmax_t, not int, to format
7286 process-name gensyms.
7287
55e5faa1
PE
7288 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7289
80f2e268
PE
7290 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7291 to avoid potential buffer overrun.
7292
670741ab
PE
7293 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7294 if X resource line is longer than 512 bytes.
7295
b7163a50
PE
7296 * xfns.c (x_window): Make sprintf buffer a bit bigger
7297 to avoid potential buffer overrun.
7298
ae58ff1f
PE
7299 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7300
c43c8a6a
PE
7301 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7302
3f8236f4
PE
73032011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7304
53e9fe90 7305 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7306 Without these, Emacs silently mishandles large integers sometimes.
7307 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7308 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7309
6511acf2
PE
7310 * xdisp.c (try_window_id): Check Emacs fixnum range before
7311 converting to 'int'.
806add1d 7312
6511acf2 7313 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7314 Check that an Emacs fixnum is in range before assigning it to 'int'.
7315 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7316 values converted from Emacs fixnums.
7317 (Frecenter): Don't wrap around a line count if it is out of 'int'
7318 range; instead, treat it as an extreme value.
7319 (Fset_window_configuration, compare_window_configurations):
7320 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7321
6511acf2
PE
7322 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7323 that can exceed INT_MAX. Check that EMACS_INT value is in range
7324 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7325 (match_limit): Don't assume that a fixnum can fit in 'int'.
7326
6511acf2 7327 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7328 exceed INT_MAX.
7329
6511acf2 7330 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7331 (Fvertical_motion): Don't wrap around LINES values that don't fit
7332 in 'int'. Instead, treat them as extreme values. This is good
7333 enough for windows, which can't have more than INT_MAX lines anyway.
7334
fcb901a7
LMI
73352011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7336
0f2f6b6d
LMI
7337 * Require libxml/parser.h to avoid compilation warning.
7338
fcb901a7
LMI
7339 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7340
7341 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7342 since this reportedly can destroy thread storage.
7343
6e20a0d4
CY
73442011-08-30 Chong Yidong <cyd@stupidchicken.com>
7345
7346 * syntax.c (find_defun_start): Update all cache variables if
7347 exiting early (Bug#9401).
7348
148ae00e
EZ
73492011-08-30 Eli Zaretskii <eliz@gnu.org>
7350
f6cfbd8f
EZ
7351 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7352
148ae00e
EZ
7353 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7354 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7355 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7356
7357 * term.c (tty_append_glyph): New function.
7358 (produce_stretch_glyph): Static function and its prototype deleted.
7359
a66cfb1c
SM
7360 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7361 Add prototypes.
148ae00e 7362
c4a07a4c
PE
73632011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7364
7365 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7366 when checking :margin (Bug#9390).
7367 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7368 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7369 so that the name doesn't mislead. All uses changed.
7370
6bc8cd65
JB
73712011-08-28 Johan Bockgård <bojohan@gnu.org>
7372
7373 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7374 set_tty_hooks.
7375
dca4927e
EZ
73762011-08-27 Eli Zaretskii <eliz@gnu.org>
7377
7378 * xdisp.c (move_it_to): Don't bail out early when reaching
7379 position beyond to_charpos, if we are scanning backwards.
7380 (move_it_vertically_backward): When DY == 0, make sure we get to
7381 the first character in the line after the newline.
7382
f2cad773
PE
73832011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7384
7385 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7386 (ccl_driver): Do not generate an out-of-range pointer.
7387 (Fccl_execute_on_string): Remove unnecessary check for
7388 integer overflow, noted by Stefan Monnier in
7389 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7390 Remove a FIXME that didn't need fixing.
7391 Simplify the newly-introduced buffer reallocation code.
7392
0cae2cdb
JB
73932011-08-27 Juanma Barranquero <lekktu@gmail.com>
7394
7395 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7396
5fc295a4 73972011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7398
70c60eb2 7399 Integer and memory overflow issues (Bug#9196).
726e0ab1 7400
d31850da
PE
7401 * doc.c (get_doc_string): Rework so that
7402 get_doc_string_buffer_size is the actual buffer size, rather than
7403 being 1 less than the actual buffer size; this makes xpalloc more
7404 convenient.
7405
a69fbedb
PE
7406 * image.c (x_allocate_bitmap_record, cache_image):
7407 * xselect.c (Fx_register_dnd_atom):
7408 Simplify previous changes by using xpalloc.
7409
fe5c5d37
PE
7410 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7411 since either will do and ptrdiff_t is convenient with xpalloc.
7412
0065d054
PE
7413 * charset.c (charset_table_size)
7414 (struct charset_sort_data.priority): Now ptrdiff_t.
7415 (charset_compare): Don't overflow if priorities differ greatly.
7416 (Fsort_charsets): Don't assume list length fits in int.
7417 Check for size-calculation overflow when allocating sort data.
7418 (syms_of_charset): Allocate an initial charset table that is
7419 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7420
7421 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7422
7423 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7424 The actual value is always <= INT_MAX, and leaving it unsigned made
7425 overflow checking harder.
7426
7427 * dispextern.h (struct glyph_matrix.rows_allocated)
7428 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7429 with xpalloc. The values are still always <= INT_MAX.
7430
7431 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7432
7433 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7434 (SAFE_NALLOCA): New macro.
7435
7436 * region-cache.c (struct boundary.pos, find_cache_boundary)
7437 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7438 (set_cache_region, invalidate_region_cache)
7439 (revalidate_region_cache, know_region_cache, region_cache_forward)
7440 (region_cache_backward, pp_cache):
7441 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7442 so that ptrdiff_t * can be passed to xpalloc.
7443 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7444 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7445 (pp_cache): Don't assume cache_len fits in int.
7446 * region-cache.h: Adjust extern decls to match.
7447
7448 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7449 EMACS_INT, since either will do, for xpalloc.
7450
7451 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7452 (xnmalloc, xnrealloc, xpalloc): New functions.
7453
726e0ab1
PE
7454 * bidi.c (bidi_shelve_header_size): New constant.
7455 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7456 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7457
51f30bc5 7458 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7459 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7460 (overlay_strings):
7461 Don't update size of array until after memory allocation succeeds,
7462 because xmalloc/xrealloc may not return.
0065d054
PE
7463 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7464 now that we have proper integer overflow checking.
7465 (record_overlay_string, overlay_strings): Catch overflows when
7466 calculating size of overlay_str_buf.
726e0ab1 7467
0065d054
PE
7468 * callproc.c (Fcall_process): Check for size overflow when
7469 calculating size of args2.
7470 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7471 Normally we prefer signed values, but sticking with ptrdiff_t would
7472 require adding more-complicated checks.
726e0ab1
PE
7473
7474 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7475 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7476 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7477 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7478
7479 * character.c (Fstring): Check for size-calculation overflow.
7480
7481 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7482 unnecessary integer overflow. Check for size overflow.
7483 (encode_coding_object): Don't update size until xmalloc succeeds.
7484
7485 * composite.c (get_composition_id): Check for overflow in glyph
7486 length calculations.
7487
7488 Integer and memory overflow fixes for display code.
7489 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7490 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7491 (scrolling_window): Check for overflow in size calculations.
7492 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7493 Don't assume glyph table len fits in int.
7494 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7495 (row_table_size): Now ptrdiff_t, not int.
7496 (scrolling_window): Avoid overflow in size calculations.
7497 Don't update size until allocation succeeds.
7498 * fns.c (concat): Check for overflow in size calculations.
7499 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7500 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7501 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7502
7503 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7504 (get_doc_string): Check for size calculation overflow.
7505 Don't update size until allocation succeeds.
7506 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7507 EMACS_INT, where ptrdiff_t will do.
7508 (Fsubstitute_command_keys): Check for string overflow.
7509
7510 * editfns.c (set_time_zone_rule): Don't assume environment length
7511 fits in int.
7512 (message_length): Now ptrdiff_t, not int.
7513 (Fmessage_box): Don't update size until allocation succeeds.
7514 Don't assume message length fits in int.
7515 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7516
0065d054
PE
7517 * emacs.c (main): Do not reallocate argv, since there is a null at
7518 the end that can be overwritten, and this way there's no need to
7519 worry about size-calculation overflow.
7520 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7521
7522 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7523 alloc succeeds.
7524 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7525
7526 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7527 (x_set_scroll_bar_width, x_figure_window_size):
7528 Check for integer overflow.
7529 (x_set_alpha): Do not assume XINT fits in int.
7530
7531 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7532 This is for the members text_lines, text_cols, total_lines, total_cols,
7533 where the system imposes an 'int' limit.
7534
7535 * fringe.c (Fdefine_fringe_bitmap):
7536 Don't update size until alloc works.
7537
7538 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7539 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7540
7541 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7542 Check for size-calculation overflow.
7543 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7544 do, as we prefer signed integers.
7545 (id_to_widget.max_size, id_to_widget.used)
7546 (xg_store_widget_in_map, xg_remove_widget_from_map)
7547 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7548 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7549 Use and return ptrdiff_t, not int.
7550 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7551 * gtkutil.h: Change prototypes to match the above.
7552
7553 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7554 are duplicate now that they've been promoted to lisp.h.
7555 (x_allocate_bitmap_record, x_alloc_image_color)
7556 (make_image_cache, cache_image, xpm_load):
7557 Don't update size until alloc is done.
7558 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7559 (x_detect_edges):
3256efce 7560 Check for size calculation overflow.
726e0ab1
PE
7561 (ct_colors_allocated_max): New constant.
7562 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7563 overflow.
3256efce 7564
726e0ab1
PE
7565 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7566 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7567 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7568 Use ptrdiff_t, not int, to count maps.
7569 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7570 calculations. Don't update size until allocation succeeds.
7571 Redo calculations to avoid overflow.
726e0ab1
PE
7572 * keyboard.h: Change prototypes to match the above.
7573
7574 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7575 to count maps.
7576 (current_minor_maps): Check for size calculation overflow.
7577 * keymap.h: Change prototypes to match the above.
7578
7579 * lread.c (read1, init_obarray): Don't update size until alloc done.
7580
7581 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7582 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7583
726e0ab1
PE
7584 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7585 Now ptrdiff_t, not int.
7586 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7587 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7588
7589 * process.c (Fnetwork_interface_list): Check for overflow
7590 in size calculation.
7591
7592 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7593
7594 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7595 overflow. Don't bother calling xmalloc when xrealloc will do.
7596
7597 * search.c (Freplace_match): Check for size calculation overflow.
7598 (Fset_match_data): Don't assume list lengths fit in 'int'.
7599
7600 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7601 for command line length. Do not attempt to address one before the
7602 beginning of an array, as that's not portable.
7603
7604 * term.c (max_frame_lines): Remove; unused.
7605 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7606 not int.
7607 (encode_terminal_code, calculate_costs): Check for size
7608 calculation overflow.
7609 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7610 table lengths and related sizes. Don't update size until alloc
7611 done. Redo calculations to avoid overflow.
7612 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7613
7614 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7615 subtracting pointers.
7616 (gobble_line): Check for overflow more carefully. Don't update size
7617 until alloc done.
7618
7619 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7620 Don't update size until alloc done.
7621 Redo size calculations to avoid overflow.
7622 Check for size calculation overflow.
0065d054 7623 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7624
7625 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7626 Use ptrdiff_t, not int, for sizes.
7627 (store_mode_line_noprop_char): Don't update size until alloc done.
7628
0065d054
PE
7629 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7630 Use ptrdiff_t, not int, for sizes.
7631 (Finternal_make_lisp_face, cache_face):
7632 Check for size calculation overflow.
7633 (cache_face): Treat size calculation overflows as if they were
7634 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7635
7636 * xfns.c (x_encode_text, x_set_name_internal)
7637 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7638 sizes, since they can exceed INT_MAX in size. Check for size
7639 calculation overflow.
7640
0065d054
PE
7641 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7642 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7643 Don't update size until alloc done.
7644
0065d054 7645 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7646 as sprintf is limited to int lengths.
1d526e2f 7647
252c5ee1
PE
7648 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7649 (X_LONG_MIN): New macros.
864d7ce7
PE
7650 Use them to make the following changes clearer.
7651 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7652 This change doesn't affect the value now, but it may help remind
7653 future maintainers not to raise the value too much later.
7654 (SELECTION_QUANTUM): Remove, replacing with ...
7655 (selection_quantum): ... new function, which avoids overflow.
7656 All uses changed.
7657 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7658 assumption that selection length fits in 'int'.
7659 (x_reply_selection_request, x_handle_selection_request)
7660 (x_get_window_property, receive_incremental_selection)
7661 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7662 (lisp_data_to_selection_data, clean_local_selection_data):
7663 Use ptrdiff_t, not int, to record length of selection.
7664 (x_reply_selection_request, x_get_window_property)
7665 (receive_incremental_selection, x_property_data_to_lisp):
7666 Redo calculations to avoid overflow.
7667 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7668 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7669 something.
7670 (x_get_window_property, receive_incremental_selection)
7671 (lisp_data_to_selection_data, x_property_data_to_lisp):
7672 Check for size-calculation overflow.
7673 (x_get_window_property, receive_incremental_selection)
7674 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7675 Don't store size until memory allocation succeeds.
7676 (x_get_window_property): Plug memory leak on memory exhaustion.
7677 Don't double-block input; malloc is safe here. Don't assume 2**34
7678 - 4 fits in unsigned long. Add an xassert to check
7679 XGetWindowProperty overflow. Be more careful about overflow
7680 calculations, and distinguish size from memory overflow better.
7681 (receive_incremental_selection): When tracing, don't assume
7682 unsigned int is less than INT_MAX.
7683 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7684 harmful) conversions of unsigned short to int.
7685 (lisp_data_to_selection_data): Don't assume that integers
7686 in the range -65535 through -1 fit in an X unsigned short.
7687 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7688 result parameters unless successful. Rely on cons_to_unsigned
7689 to report problems with elements; the old code wasn't right anyway.
7690 (x_check_property_data): Check for int overflow; we cannot use
7691 a wider type due to X limits.
7692 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7693
726e0ab1 7694 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7695
0065d054
PE
7696 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7697 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7698 (x_color_cells): Don't store size until memory allocation succeeds.
7699 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7700 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7701 (x_term_init): Don't assume length fits in int (sprintf is limited
7702 to int size).
bc18e09d 7703
ebfa62c0
PE
7704 Use ptrdiff_t for composition IDs.
7705 * character.c (lisp_string_width):
7706 * composite.c (composition_table_size, n_compositions)
7707 (get_composition_id, composition_gstring_from_id):
7708 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7709 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7710 * window.c (Frecenter):
7711 Use ptrdiff_t, not int, for composition IDs.
7712 * composite.c (get_composition_id): Check for integer overflow.
7713 * composite.h: Adjust prototypes to match the above changes.
7714
d3411f89
PE
7715 Use ptrdiff_t for hash table indexes.
7716 * category.c (hash_get_category_set):
7717 * ccl.c (ccl_driver):
7718 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7719 * coding.c (coding_system_charset_list, detect_coding_system):
7720 * coding.h (struct coding_system.id):
7721 * composite.c (get_composition_id, gstring_lookup_cache):
7722 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7723 * image.c (xpm_get_color_table_h):
7724 * lisp.h (hash_lookup, hash_put):
7725 * minibuf.c (Ftest_completion):
7726 Use ptrdiff_t for hash table indexes, not int (which is too
7727 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7728 32-bit --with-wide-int hosts).
7729
e097a6fa
PE
7730 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7731 Add a FIXME comment about memory leaks.
7732 (syms_of_charset): Don't assume xmalloc returns.
7733
5637687f
PE
7734 Don't assume that stated character widths fit in int.
7735 * character.c (Fchar_width, c_string_width, lisp_string_width):
7736 * character.h (CHAR_WIDTH):
7737 * indent.c (MULTIBYTE_BYTES_WIDTH):
7738 Use sanitize_char_width to avoid undefined and/or bad behavior
7739 with outlandish widths.
a66cfb1c 7740 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7741 now that we have two such functions. All uses changed.
7742 (sanitize_char_width): New inline function.
7743
a2271ba2
PE
7744 Don't assume that tab-width fits in int.
7745 * character.h (sanitize_width): New inline function.
7746 (SANE_TAB_WIDTH): New macro.
7747 (ASCII_CHAR_WIDTH): Use it.
7748 * indent.c (sane_tab_width): Remove. All uses replaced by
7749 SANE_TAB_WIDTH (current_buffer).
7750 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7751
18c52557
PE
7752 * fileio.c: Integer overflow issues with file modes.
7753 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7754
caeeedc1
PE
7755 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7756 Remove unreachable code.
7757 (read_hex, load_charset_map_from_file): Check for integer overflow.
7758
6df6ae42 7759 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7760 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7761 (x_send_scroll_bar_event): Likewise. Check that the size does not
7762 exceed limits imposed by XClientMessageEvent, as well as the usual
7763 ptrdiff_t and size_t limits.
7764
b13995db
PE
7765 * keyboard.c: Overflow, signedness and related fixes.
7766 (make_lispy_movement): Use same integer type in forward decl
7767 that is used in the definition.
7768 (read_key_sequence, keyremap_step):
7769 Change bufsize argument back to int, undoing my 2011-03-30 change.
7770 We prefer signed types, and int is wide enough here.
7771 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7772 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7773 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7774 length, not size_t. Use ptrdiff_t for index, not int.
7775 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7776 possibility of integer overflow.
7777
13464394
PE
7778 Overflow, signedness and related fixes for images.
7779
7780 * dispextern.h (struct it.stack[0].u.image.image_id)
7781 (struct_it.image_id, struct image.id, struct image_cache.size)
7782 (struct image_cache.used, struct image_cache.ref_count):
7783 * gtkutil.c (update_frame_tool_bar):
7784 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7785 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7786 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7787 * nsmenu.m (update_frame_tool_bar):
7788 * xdisp.c (calc_pixel_width_or_height):
7789 * xfns.c (image_cache_refcount):
7790 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7791 on typical 64-bit hosts.
7792
7793 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7794 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7795 Omit unnecessary casts to int.
7796 (parse_image_spec): Check that integers fall into 'int' range
7797 when the callers expect that.
7798 (image_ascent): Redo ascent calculation to avoid int overflow.
7799 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7800 (lookup_image): Remove unnecessary tests.
7801 (xbm_image_p): Locals are now of int, not EMACS_INT,
7802 since parse_image_check makes sure they fit into int.
7803 (png_load, gif_load, svg_load_image):
7804 Prefer int to unsigned where either will do.
7805 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7806 old tiff_error_handler and tiff_warning_handler.
7807 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7808 stack buffer overflows. It uses only the features of vsnprintf
7809 that are common to both POSIX and native Microsoft.
7810 (tiff_error_handler, tiff_warning_handler): Use it.
7811 (tiff_load, gif_load, imagemagick_load_image):
7812 Don't assume :index value fits in 'int'.
7813 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7814 (imagemagick_load_image): Check that crop parameters fit into
7815 the integer types that MagickCropImage accepts. Don't assume
7816 Vimagemagick_render_type has a nonnegative value. Don't assume
7817 size_t fits in 'long'.
7818 (gs_load): Use printmax_t to print the widest integers possible.
7819 Check for integer overflow when computing image height and width.
7820
c11821d4
EZ
78212011-08-26 Eli Zaretskii <eliz@gnu.org>
7822
7823 * xdisp.c (redisplay_window): Don't force window start if point
7824 will be invisible in the resulting window. (Bug#9324)
7825
0c95fcf7
EZ
78262011-08-25 Eli Zaretskii <eliz@gnu.org>
7827
7828 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7829 the display spec is of the form `(space ...)'.
7830 (handle_display_spec): Return the value returned by
7831 handle_single_display_spec, not just 1 or zero.
7832 (handle_single_display_spec): If the display spec is of the form
7833 `(space ...)', and specifies display in the text area, return 2
7834 rather than 1.
fee65a97 7835 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7836 accurately, and prefer exact match for point under bidi.
7837 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7838
7839 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7840 into disp_prop; all users changed.
7841
7842 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7843 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7844 for the text covered by the display property.
7845
e4ed06f1
CY
78462011-08-25 Chong Yidong <cyd@stupidchicken.com>
7847
7848 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7849 Change return value to nil.
7850 (Frecord_buffer): Delete unused function.
7851
f67cdd7f
EZ
78522011-08-24 Eli Zaretskii <eliz@gnu.org>
7853
5980d4c6
EZ
7854 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7855 buffers, return left-to-right.
8610fe8b
EZ
7856 (set_cursor_from_row): Consider candidate row a win if its glyph
7857 represents a newline and point is on that newline. Fixes cursor
7858 positioning on the newline at EOL of R2L text within L2R
7859 paragraph, and vice versa.
7860 (try_cursor_movement): Check continued rows, in addition to
7861 continuation rows. Fixes unwarranted scroll when point enters a
7862 continued line of R2L text within an L2R paragraph, or vice versa.
7863 (cursor_row_p): Consider the case of point being equal to
7864 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7865 from the end of a short line to the beginning of a continued line
7866 of R2L text within L2R paragraph.
7867 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7868 composed characters.
5980d4c6 7869
f67cdd7f
EZ
7870 * bidi.c (bidi_check_type): Use xassert.
7871 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7872 members.
7873
bca633fb
EZ
78742011-08-23 Eli Zaretskii <eliz@gnu.org>
7875
7876 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7877 a character.
7878
4a5885a7
CY
78792011-08-23 Chong Yidong <cyd@stupidchicken.com>
7880
7881 * nsfont.m (ns_otf_to_script): Fix typo.
7882
0902a04e
KH
78832011-08-22 Kenichi Handa <handa@m17n.org>
7884
7885 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7886 extra slot even if the purpose is char-code-property-table.
7887
1a2e6670
EZ
78882011-08-23 Eli Zaretskii <eliz@gnu.org>
7889
8ddde651
EZ
7890 * xdisp.c (redisplay_window): When computing centering_position,
7891 account for the height of the header line. (Bug#8874)
7892
425cc014
EZ
7893 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7894 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7895 candidate is selected by the mouse, and that candidate has a
7896 composed character under the mouse.
7897
1a2e6670
EZ
7898 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7899 coordinates reported by pos-visible-in-window-p for a composed
7900 character in column zero.
7901
8b76d6f8
SM
79022011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7903
7904 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7905
dac347dd
EZ
79062011-08-22 Eli Zaretskii <eliz@gnu.org>
7907
7908 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7909 consider it a hit if to_charpos is anywhere in the range of the
7910 composed buffer positions.
7911
e013fb34
CY
79122011-08-22 Chong Yidong <cyd@stupidchicken.com>
7913
7914 * image.c (gif_load): Don't assume that each subimage has the same
7915 dimensions as the base image. Handle disposal method that is
7916 "undefined" by the gif spec (Bug#9335).
7917
bd1ba3e8
CY
79182011-08-20 Chong Yidong <cyd@stupidchicken.com>
7919
7920 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7921 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7922
54a1215b
EZ
79232011-08-19 Eli Zaretskii <eliz@gnu.org>
7924
823564e5
EZ
7925 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7926 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7927 from an Org mode buffer to a Speedbar frame.
7928
54a1215b
EZ
7929 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7930 a composition, take its buffer position from IT->cmp_it.charpos.
7931 Fixes cursor positioning at the beginning of a line that begins
7932 with a composed character.
7933
9778ebcc
EZ
79342011-08-18 Eli Zaretskii <eliz@gnu.org>
7935
0be6ee06
EZ
7936 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7937 character bidirectional type, use STRONG_L instead. Fixes crashes
7938 in a buffer produced by `describe-categories'.
7939
9778ebcc
EZ
7940 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7941 members before the level stack, so they would be saved and
7942 restored when copying iterator state. Fixes incorrect reordering
7943 around TABs covered by display properties.
7944
156bffbe
AS
79452011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7946
6b02f655 7947 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7948
72ad093b
CY
79492011-08-17 Chong Yidong <cyd@stupidchicken.com>
7950
7951 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7952 (internal_condition_case_2, internal_condition_case_n):
7953 Remove unnecessary aborts (Bug#9081).
72ad093b 7954
35774242
EZ
79552011-08-17 Eli Zaretskii <eliz@gnu.org>
7956
7957 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7958 has no `load' handler, try opening the file locally. (Bug#9311)
7959
db76dd85
KB
79602011-08-16 Ken Brown <kbrown@cornell.edu>
7961
7962 * gmalloc.c: Expand comment.
7963
b215eee5
EZ
79642011-08-16 Eli Zaretskii <eliz@gnu.org>
7965
7966 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7967 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7968
a4579d33
KB
79692011-08-16 Ken Brown <kbrown@cornell.edu>
7970
7971 Fix memory allocation problems in Cygwin build (Bug#9273).
7972
7973 * unexcw.c ( __malloc_initialized): Declare external variable.
7974 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7975
8b76d6f8
SM
7976 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7977 New variables.
a4579d33
KB
7978 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7979 dumped emacs.
7980 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7981 in the static heap.
7982 [CYGWIN] (special_realloc): New function.
7983 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7984 requests to realloc storage in the static heap.
7985
3ebec551
PE
79862011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7987
7988 * bidi.c (bidi_initialize): Remove unused local.
7989
9fd8be00
EZ
79902011-08-15 Eli Zaretskii <eliz@gnu.org>
7991
6b02f655
SM
7992 * bidimirror.h:
7993 * biditype.h: Remove file.
7994 * makefile.w32-in ($(BLD)/bidi.$(O)):
7995 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7996
7997 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7998
7999 * chartab.c: Improve commentary for the uniprop_table API.
8000
32413314
EZ
8001 * bidi.c (bidi_paragraph_init): Support zero value of
8002 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8003 (bidi_initialize): Use uniprop_table instead of including
8004 biditype.h and bidimirror.h.
32413314 8005
9fd8be00
EZ
8006 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8007 coordinates of the iterator when restoring from ppos_it.
8008 (Bug#9296)
8009
5cf2b69b
KH
80102011-08-14 Kenichi Handa <handa@m17n.org>
8011
8012 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8013 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8014
daf17d00
EZ
80152011-08-14 Eli Zaretskii <eliz@gnu.org>
8016
8017 * xdisp.c (move_it_in_display_line_to): Don't invoke
8018 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8019 ppos_it. Fixes vertical cursor motion when line beginning is
8020 covered by an image. (Bug#9296)
8021
08e3161a
JD
80222011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8023
8024 * nsterm.h (ns_run_ascript): Declare.
8025 (NSAPP_DATA2_RUNASSCRIPT): Define.
8026
8027 * nsfns.m (as_script, as_result, as_status): New static variables.
8028 (ns_run_ascript): New function.
5e617bc2 8029 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8030 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8031 the event loop. Get status from as_status (Bug#7276).
8032
8033 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8034 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8035 the event loop (Bug#7276).
8036
a3720aa2
AS
80372011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8038
8039 * gnutls.c (QCgnutls_bootprop_priority)
8040 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8041 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8042 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8043 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8044 (QCgnutls_bootprop_verify_hostname_error)
8045 (QCgnutls_bootprop_callbacks_verify): Rename from
8046 Qgnutls_bootprop_..., all uses changed.
8047
8048 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8049 uses changed.
8050
0a0d27fb
PE
80512011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8052
19d5c50c
PE
8053 * xfaces.c (Qframe_set_background_mode): Now static.
8054 * dispextern.h (Qframe_set_background_mode): Remove decl.
8055
0a0d27fb
PE
8056 * process.c (Fnetwork_interface_info): Declare local only if needed.
8057
377538cb
JD
80582011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8059
8060 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8061 (Fnetwork_interface_list): Allocate in increments of bytes instead
8062 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8063 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8064 sockaddr.
8065 (struct ifflag_def): notrailers is smart on OSX.
8066 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8067 Get hardware address with getifaddrs if available.
8068
08fff70c
EZ
80692011-08-12 Eli Zaretskii <eliz@gnu.org>
8070
8071 * xdisp.c (iterate_out_of_display_property): xassert that
8072 IT->position is set to within IT->object's boundaries. Break from
8073 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8074 when IT->position is set up wrongly due to some bug.
8075 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8076 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8077 entry. Force push_it to save on the stack the current
8078 buffer/string position, to be restored by pop_it. Fix flags in
8079 the iterator structure wrt the object coming from a display
8080 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8081 properties. (Bug#9284)
8082
7be1c708 80832011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8084
7be1c708
CY
8085 * fontset.c (fontset_get_font_group): Add proper type checks.
8086 (Bug#9172)
aac0c6e3 8087
7be1c708 80882011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8089
7be1c708
CY
8090 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8091 and LC_VERSION_MIN_MACOSX.
8092 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8093 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8094
97bb72a6
EZ
80952011-08-08 Eli Zaretskii <eliz@gnu.org>
8096
8097 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8098 no-display-properties-and-no-overlays under bidi display.
8099 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8100 properties and overlays.
97bb72a6 8101
d5617611
CY
81022011-08-08 Chong Yidong <cyd@stupidchicken.com>
8103
37e11a63
CY
8104 * editfns.c (Fset_time_zone_rule): Document relationship with the
8105 setenv function.
8106
d5617611
CY
8107 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8108 the font entity extracted from the cache (Bug#8109).
8109
58872834
CY
81102011-08-07 Chong Yidong <cyd@stupidchicken.com>
8111
8112 * composite.c (autocmp_chars): Don't reset point. That is done by
8113 restore_point_unwind (Bug#5984).
8114
75bfc667
JL
81152011-08-07 Juri Linkov <juri@jurta.org>
8116
8117 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8118 to show the arg `TIME' instead of `TIMEVAL'.
8119
d1410150
EZ
81202011-08-06 Eli Zaretskii <eliz@gnu.org>
8121
8122 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8123 display property strides EOL and includes a newline, as in
8124 longlines-mode. (Bug#9254)
75b771e4
EZ
8125 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8126 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8127
8128 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8129 is non-zero, even if the data buffer is NULL. Fixes a crash in
8130 vertical-motion with longlines-mode. (Bug#9254)
8131
35928349
EZ
81322011-08-05 Eli Zaretskii <eliz@gnu.org>
8133
ec7cc85b
EZ
8134 * bidi.c <bidi_cache_total_alloc>: Now static.
8135 (bidi_initialize): Initialize bidi_cache_total_alloc.
8136
8b76d6f8 8137 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8138 cache. (Bug#9221)
8139
8140 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8141 amount allocated this far in `bidi_cache_total_alloc'.
8142 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8143 non-zero, only free the data buffer without restoring the cache
8144 contents. All callers changed.
8145
8146 * dispextern.h (bidi_unshelve_cache): Update prototype.
8147
8148 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8149 (move_it_in_display_line, move_it_to)
8150 (move_it_vertically_backward, move_it_by_lines): Replace the call
8151 to xfree to an equivalent call to bidi_unshelve_cache.
8152 (move_it_in_display_line_to): Fix logic of returning
412b6358 8153 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8154
e2e2423b
EZ
81552011-08-05 Eli Zaretskii <eliz@gnu.org>
8156
8157 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8158 came from a string character with a `cursor' property. (Bug#9229)
8159
ae9e757a
JD
81602011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8161
8162 * Makefile.in (LIB_PTHREAD): New variable.
8163 (LIBES): Add LIB_PTHREAD (Bug#9216).
8164
8165 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8166 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8167
213bd7f2
AS
81682011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8169
6b02f655 8170 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8171
99aaf75f
JD
81722011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8173
8174 * xterm.c (x_find_topmost_parent): New function.
8175 (x_set_frame_alpha): Find topmost parent window with
8176 x_find_topmost_parent and set the property there also (bug#9181).
8177 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8178
c74e9d86
PE
81792011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8180
8181 * callproc.c (Fcall_process): Avoid vfork clobbering
8182 the local vars buffer, coding_systems, current_dir.
8183
640c8776
SM
81842011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8185
8186 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8187
f26d0e4c
PE
81882011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8189
8a10d76c
PE
8190 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8191 so that it is not optimized away.
8192
f26d0e4c
PE
8193 * xdisp.c (compute_display_string_pos): Remove unused local.
8194
55439c61
EZ
81952011-08-02 Eli Zaretskii <eliz@gnu.org>
8196
8197 Fix slow cursor motion and scrolling in large buffers with
8198 selective display, like Org Mode buffers. (Bug#9218)
8199
8200 * dispextern.h (struct bidi_it): New member disp_prop_p.
8201
8202 * xdisp.c: Remove one-slot cache of display string positions.
8203 (compute_display_string_pos): Accept an additional argument
5e617bc2 8204 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8205 for a display string or property. If found, set DISP_PROP_P
8206 non-zero.
8207
8208 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8209 DISP_PROP_P, and pass it to compute_display_string_pos.
8210 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8211 non-zero. All callers of bidi_fetch_char changed.
8212
fb33fa43
SM
82132011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8214
8215 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8216
b099e063
DM
82172010-12-03 Don March <don@ohspite.net>
8218
8219 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8220 last character M-[char] is translated to ESC [char] (bug#7541).
8221
5cc7f7af
KH
82222011-08-02 Kenichi Handa <handa@m17n.org>
8223
d0fffa3f 8224 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8225
8226 * chartab.c (uniprop_table): Make it non-static.
8227
525d5e6e
EZ
82282011-08-01 Eli Zaretskii <eliz@gnu.org>
8229
8230 * xdisp.c (forward_to_next_line_start): Accept additional argument
8231 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8232 on the newline.
8233 (reseat_at_next_visible_line_start): Use the bidi iterator state
8234 returned by forward_to_next_line_start to restore the state of
8235 it->bidi_it after backing up to previous newline. (Bug#9212)
8236
31011111
AS
82372011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8238
8239 * regex.c (re_comp): Protoize.
8240 (re_exec): Fix return type.
8241 (regexec): Fix type of `ret'. (Bug#9203)
8242
476371c4
PE
82432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8244
e5d76069
PE
8245 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8246 This is needed if max-image-size is a floating-point number.
8247
9a79b20c
AS
82482011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8249
8250 * print.c (print_object): Print empty symbol as ##.
8251
8252 * lread.c (read1): Read ## as empty symbol.
8253
d8c2fa78
AA
82542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8255
8256 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8257 setting frame foreground color (Bug#9175).
8258 (x_set_background_color): Likewise.
8259
ffe57a7a
AA
8260 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8261 contents (Bug#9176).
8262 (EmacsTooltip -init): Remove bezels and add shadows to
8263 tooltip windows.
8264
bf3492a5
AA
8265 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8266 or scroll bar (Bug#8470).
8267
d55e9c53
AA
8268 * nsfont.m (nsfont_open): Remove assignment to voffset and
8269 unnecessary vars hshink, expand, hd, full_height, min_height.
8270 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8271
8272 * nsterm.h (nsfont_info): Remove voffset field.
8273
d8c2fa78 82742011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8275
8276 Implement strike-through and overline on NextStep (Bug#8863).
8277
8278 * nsfont.m (nsfont_open): Use underline position provided by font,
8279 instead of hard-coded value of 2.
8280 (nsfont_draw): Call ns_draw_text_decoration instead.
8281
8282 * nsterm.h: Add declaration for ns_draw_text_decoration.
8283
8284 * nsterm.m (ns_draw_text_decoration): New function for drawing
8285 underline, overline, and strike-through.
8286 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8287 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8288 accommodate underlining, etc.
4843aac3 8289
4cc60b9b
EZ
82902011-07-28 Eli Zaretskii <eliz@gnu.org>
8291
bc7ece87
EZ
8292 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8293 default.
4cc60b9b 8294
476371c4
PE
82952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8296
66606eea
PE
8297 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8298 Without this fix, if a signal arrives just after memory fills up,
8299 'malloc' might be invoked reentrantly.
8300
476371c4
PE
8301 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8302 In other words, assume that every image size is allowed, on non-X
8303 hosts. This assumption is probably wrong, but it lets Emacs compile.
8304
f3fcc40d
AS
83052011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8306
8307 * regex.c (re_iswctype): Convert return values to boolean.
8308
350c992f
EZ
83092011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8310
8311 * xdisp.c (compute_display_string_pos): Don't use cached display
8312 string position if the buffer had its restriction changed.
8313 (Bug#9184)
8314
5266b4bb
PE
83152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8316
8317 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8318
2573a837 83192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8320
41f55ccd 8321 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8322
39e378da
PE
8323 * bidi.c: Integer size and overflow fixes.
8324 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8325 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8326 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8327 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8328 (bidi_find_other_level_edge):
8329 Use ptrdiff_t instead of EMACS_INT where either will do.
8330 This works better on 32-bit hosts configured --with-wide-int.
8331 (bidi_cache_ensure_space): Check for size-calculation overflow.
8332 Use % rather than repeated addition, for better worst-case speed.
8333 Don't set bidi_cache_size until after xrealloc returns, because it
8334 might not return.
8335 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8336 (bidi_cache_ensure_space): Also check that the bidi cache size
8337 does not exceed that of the largest Lisp string or buffer. See Eli
8338 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8339
5e927815
PE
8340 * alloc.c (__malloc_size_t): Remove.
8341 All uses replaced by size_t. See Andreas Schwab's note
8342 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8343
ca4aa935
PE
8344 * image.c: Improve checking for integer overflow.
8345 (check_image_size): Assume that f is nonnull, since
8346 it is always nonnull in practice. This is one less thing to
8347 worry about when checking for integer overflow later.
8348 (x_check_image_size): New function, which checks for integer
8349 overflow issues inside X.
8350 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8351 This removes the need for a memory_full check.
8352 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8353 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8354 (xbm_read_bitmap_data): Change locals back to 'int', since
8355 their values must fit in 'int'.
8356 (xpm_load_image, png_load, tiff_load):
8357 Invoke x_create_x_image_and_pixmap earlier,
8358 to avoid much needless work if the image is too large.
8359 (tiff_load): Treat overly large images as if
8360 x_create_x_image_and_pixmap failed, not as malloc failures.
8361 (gs_load): Use x_check_image_size.
8362
5f8f9cc2
PE
8363 * gtkutil.c: Omit integer casts.
8364 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8365 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8366
5adf60bc
PE
8367 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8368
c8907a93
PE
8369 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8370 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8371 would wrongly return t on a 64-bit host.
8372
e3c25c68
PE
8373 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8374 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8375 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8376 and therefore cause GCC to emit a bogus diagnostic in some cases.
8377
3f791afe
PE
8378 * image.c: Integer signedness and overflow and related fixes.
8379 This is not an exhaustive set of fixes, but it's time to
8380 record what I've got.
8381 (lookup_pixel_color, check_image_size): Remove redundant decls.
8382 (check_image_size): Don't assume that arbitrary EMACS_INT values
8383 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8384 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8385 (tiff_load, imagemagick_load_image):
8386 Check for overflow in size calculations.
8387 (x_create_x_image_and_pixmap): Remove unnecessary test for
8388 xmalloc returning NULL; that can't happen.
8389 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8390 (xpm_color_bucket): Use better integer hashing function.
8391 (xpm_cache_color): Don't possibly over-allocate memory.
8392 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8393 (gif_memory_source):
8394 Use ptrdiff_t, not int or size_t, to record sizes.
8395 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8396 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8397 either works, as we prefer signed integers.
8398 (tiff_read_from_memory, tiff_write_from_memory):
8399 Return tsize_t, not size_t, since that's what the TIFF API wants.
8400 (tiff_read_from_memory): Don't fail simply because the read would
8401 go past EOF; instead, return a short read.
8402 (tiff_load): Omit no-longer-needed casts.
8403 (Fimagemagick_types): Don't assume size fits into 'int'.
8404
3cc5a532
PE
8405 Improve hashing quality when configured --with-wide-int.
8406 * fns.c (hash_string): New function, taken from sxhash_string.
8407 Do not discard information about ASCII character case; this
8408 discarding is no longer needed.
8409 (sxhash-string): Use it. Change sig to match it. Caller changed.
8410 * lisp.h: Declare it.
8411 * lread.c (hash_string): Remove, since we now use fns.c's version.
8412 The fns.c version returns a wider integer if --with-wide-int is
8413 specified, so this should help the quality of the hashing a bit.
8414
b312a492
PE
8415 * emacs.c: Integer overflow minor fix.
8416 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8417 Define only if GNU_LINUX.
8418 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8419
dfd153ae
PE
8420 * dispnew.c: Integer signedness and overflow fixes.
8421 Remove unnecessary forward decls, that were a maintenance hassle.
8422 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8423 All uses changed.
8424 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8425 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8426 (prepare_desired_row, line_draw_cost):
8427 Use int, not unsigned, where either works.
8428 (save_current_matrix, restore_current_matrix):
8429 Use ptrdiff_t, not size_t, where either works.
8430 (init_display): Check for overflow more accurately, and without
8431 relying on undefined behavior.
8432
a81d11a3
PE
8433 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8434 Remove, replacing with the new symbols in lisp.h. All uses changed.
8435 * fileio.c (make_temp_name):
8436 * filelock.c (lock_file_1, lock_file):
8437 * xdisp.c (message_dolog):
8438 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8439 Use pMd etc. instead.
8440 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8441 replacing the pWIDE etc. symbols removed from editfns.c.
8442
3300e6fd
PE
8443 * keyboard.h (num_input_events): Now uintmax_t.
8444 This is (very slightly) less likely to mess up due to wraparound.
8445 All uses changed.
8446
fd05c7e9
PE
8447 * buffer.c: Integer signedness fixes.
8448 (alloc_buffer_text, enlarge_buffer_text):
8449 Use ptrdiff_t rather than size_t when either will do, as we prefer
8450 signed integers.
8451
903fe15d
PE
8452 * alloc.c: Integer signedness and overflow fixes.
8453 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8454 (__malloc_size_t): Default to size_t, not to int.
8455 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8456 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8457 Prefer ptrdiff_t to size_t when either would do, as we prefer
8458 signed integers.
8459 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8460 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8461 Now const. Initialize with values that are in range even if char
8462 is signed.
8463 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8464 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8465 These functions do the right thing with sizes > 2**32.
8466 (check_depth): Now ptrdiff_t, not int.
8467 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8468 Adjust to new way of storing sizes. Check for size overflow bugs
8469 in rest of code.
8470 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8471 slightly wrong anyway, as it missed one instance of
8472 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8473 (refill_memory_reserve): Omit needless cast to size_t.
8474 (mark_object_loop_halt): Mark as externally visible.
8475
ac82cc6a
PE
8476 * xselect.c: Integer signedness and overflow fixes.
8477 (Fx_register_dnd_atom, x_handle_dnd_message):
8478 Use ptrdiff_t, not size_t, since we prefer signed.
8479 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8480 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8481 x_dnd_atoms_size and x_dnd_atoms_length.
8482
c2d1e36d
PE
8483 * doprnt.c: Prefer signed to unsigned when either works.
8484 * eval.c (verror):
8485 * doprnt.c (doprnt):
8486 * lisp.h (doprnt):
8487 * xdisp.c (vmessage):
8488 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8489 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8490 prefer signed arithmetic to avoid comparison confusion.
8491 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8492 but is a bit tricky.
8493
0e926e56
PE
8494 Assume freestanding C89 headers, string.h, stdlib.h.
8495 * data.c, doprnt.c, floatfns.c, print.c:
8496 Include float.h unconditionally.
8497 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8498 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8499 * regex.c: Likewise for stddef.h, string.h.
8500 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8501 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8502 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8503 (STDC_HEADERS): Remove obsolete defines.
8504 * sysdep.c: Include limits.h unconditionally.
8505
9cfdb3ec
PE
8506 Assume support for memcmp, memcpy, memmove, memset.
8507 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8508 * regex.c (memcmp, memcpy):
8509 Remove; we assume C89 now.
8510
8511 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8512 (__malloc_safe_bcopy): Remove; no longer needed.
8513
cf950e6b 8514 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8515 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8516 well either way, and we prefer signed to unsigned.
8517
dbf38e02
LMI
85182011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8519
8520 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8521 closes the connection while we're reading (bug#9182).
8522
d6f0886c 85232011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8524
d6f0886c
JD
8525 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8526 are specified (Bug#9168).
24e0f6b1 8527
2eb1f9e6
PE
85282011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8529
8530 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8531 Found by GCC static checking and --with-wide-int on a 32-bit host.
8532
22381272 85332011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8534
8535 * xdisp.c (compute_display_string_pos): Fix logic of caching
8536 previous display string position. Initialize cached_prev_pos to
8537 -1. Fixes slow-down at the beginning of a buffer.
8538
f25e39b4
EZ
85392011-07-24 Eli Zaretskii <eliz@gnu.org>
8540
8541 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8542 for attrs[LFACE_FONTSET_INDEX].
8543
04c4b52e
PE
85442011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8545
8546 * xml.c (parse_region): Remove unused local
8547 that was recently introduced.
8548
c1734fbd
EZ
85492011-07-23 Eli Zaretskii <eliz@gnu.org>
8550
be18c5a5
EZ
8551 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8552 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8553
c1734fbd
EZ
8554 * xdisp.c (move_it_in_display_line_to): Record the best matching
8555 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8556 exit if none of the characters scanned was an exact match.
8557 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8558 when exact match is impossible due to invisible text, and the
8559 lines are truncated.
8560
a258d627
JD
85612011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8562
8563 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8564 for OSX >= 10.7.
8565
b6d5a689
EZ
85662011-07-22 Eli Zaretskii <eliz@gnu.org>
8567
0f74f785
EZ
8568 Fix a significant slow-down of cursor motion with C-n, C-p,
8569 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8570 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8571 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8572 (next_element_from_buffer): Call compute_stop_pos_backwards to
8573 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8574 base_level_stop.
8575 (reseat): Don't look for prev_stop, as that could mean a very long
8576 run.
8577 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8578 <cached_disp_overlay_modiff>: Cache for last found display string
8579 position.
551918c1 8580 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8581 about the same buffer in the same area of character positions, and
8582 the buffer wasn't changed since the time the display string
8583 position was cached.
551918c1 8584
b2d0c91a
EZ
85852011-07-22 Eli Zaretskii <eliz@gnu.org>
8586
8587 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8588 is an integer, which is important for empty lines. (Bug#9149)
8589
043604ee
CY
85902011-07-22 Chong Yidong <cyd@stupidchicken.com>
8591
8592 * frame.c (Fmodify_frame_parameters): In tty case, update the
8593 default face if necessary (Bug#4238).
8594
da4adb04
CY
85952011-07-21 Chong Yidong <cyd@stupidchicken.com>
8596
8597 * editfns.c (Fstring_to_char): No need to explain what a character
8598 is in the docstring (Bug#6576).
8599
9abd0532
LMI
86002011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8601
8602 * xml.c (parse_region): Make sure we always return a tree.
8603
36881d16
HK
86042011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8605
8606 * xml.c (parse_region): If a document contains only comments,
8607 return that, too.
8608
1e98674d
LMI
86092011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8610
8611 * xml.c (make_dom): Return comments, too.
8612
590bd467
PE
86132011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8614
8615 Port to OpenBSD.
8616 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8617 and the surrounding thread.
8618 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8619 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8620 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8621 timer goes off.
8622 * s/openbsd.h (BROKEN_SIGIO): Define.
8623 * unexelf.c (unexec) [__OpenBSD__]:
8624 Don't update the .mdebug section of the Alpha COFF symbol table.
8625
f41628b2
LMI
86262011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8627
8628 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8629 (bug#8460).
8630
b59b67c5
PE
86312011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8632
15e3a074
PE
8633 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8634 This fixes some race conditions on the permissions of any newly
8635 created file.
8636
41bed37d
PE
8637 * alloc.c (valid_pointer_p): Use pipe, not open.
8638 This fixes some permissions issues when debugging.
8639
b59b67c5
PE
8640 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8641 If fchown fails to set both uid and gid, try to set just gid,
8642 as that is sometimes allowed. Adjust the file's mode to eliminate
8643 setuid or setgid bits that are inappropriate if fchown fails.
8644
925a6be7
SM
86452011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8646
8647 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8648 to compare Lisp_Objects.
8649 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8650 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8651 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8652
52968808
AS
86532011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8654
0a6a104b
AS
8655 * lread.c (read_integer): Unread even EOF character.
8656 (read1): Likewise. Properly record start position of symbol.
8657
52968808
AS
8658 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8659 symbol character follows.
8660
9e381cdd
PE
86612011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8662
8663 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8664 This works around a problem with the previous change to Fcopy_file.
8665 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8666 and without this change, GCC might complain about discarding
8667 fchown's return value.
8668
b5641435
JB
86692011-07-16 Juanma Barranquero <lekktu@gmail.com>
8670
8671 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8672
a8031457
PE
86732011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8674
8675 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8676
dd889327
LMI
86772011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8678
750c33f7
LMI
8679 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8680 it's used from the C level.
8681
dd889327
LMI
8682 * process.c: Use the same condition for POLL_FOR_INPUT in both
8683 keyboard.c and process.c (bug#1858).
8684
87e86684
LM
86852011-07-09 Lawrence Mitchell <wence@gmx.li>
8686
8687 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8688 (Fgnutls_boot): Use it.
8689
64348f40
AS
86902011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8691
8692 * doc.c (Fsubstitute_command_keys): Revert last change.
8693
1d698799
LMI
86942011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8695
f863868c
LMI
8696 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8697 quotes the next character, and doesn't affect other longer
8698 sequences (bug#8935).
8699
1d698799
LMI
8700 * lread.c (syms_of_lread): Clarify that is isn't only
8701 `eval-buffer' and `eval-defun' that's affected by
8702 `lexical-binding' (bug#8460).
8703
aa4b6df6
EZ
87042011-07-15 Eli Zaretskii <eliz@gnu.org>
8705
8706 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8707 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8708
5d856da6
PE
87092011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8710
ad6042bb
PE
8711 Fix minor problems found by static checking.
8712 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8713 (elsz): Now a signed constant, not a size_t var. We prefer signed
8714 types to unsigned, to avoid integer comparison confusion. Without
8715 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8716 "cannot optimize loop, the loop counter may overflow", a symptom
8717 of the confusion.
f00bbb22 8718 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8719 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8720
6468f31c
LMI
87212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8722
49080b10
LMI
8723 * search.c (Fre_search_backward): Mention `case-fold-search' in
8724 all the re_search_* functions (bug#8138).
8725
6468f31c
LMI
8726 * keyboard.c (Fopen_dribble_file): Document when the file is
8727 closed (bug#8056).
8728
c965adc5
EZ
87292011-07-14 Eli Zaretskii <eliz@gnu.org>
8730
df9733bf
EZ
8731 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8732 bidi_cache_idx.
8733
0bb23927
EZ
8734 Support bidi reordering of display and overlay strings.
8735 * xdisp.c (compute_display_string_pos)
8736 (compute_display_string_end): Accept additional argument STRING.
8737 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8738 (reseat_to_string): Initialize bidi_it->string.s and
8739 bidi_it->string.schars.
8740 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8741 NULL (avoids a crash in bidi_paragraph_init).
8742 Initialize itb.string.lstring.
0bb23927
EZ
8743 (init_iterator): Call bidi_init_it only of a valid
8744 buffer position was specified. Initialize paragraph_embedding to
8745 L2R.
8746 (reseat_to_string): Initialize the bidi iterator.
8747 (display_string): If we need to ignore text properties of
8748 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8749 original value of -1 will not work with bidi.)
8750 (compute_display_string_pos): First arg is now struct
8751 `text_pos *'; all callers changed. Support display properties on
8752 Lisp strings.
8753 (compute_display_string_end): Support display properties on Lisp
8754 strings.
8755 (init_iterator, reseat_1, reseat_to_string): Initialize the
8756 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8757 when iterating on a string not from display properties).
640c8776
SM
8758 (compute_display_string_pos, compute_display_string_end):
8759 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8760 arrow keys.
8761 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8762 base_level_stop; instead, set base_level_stop to BEGV.
8763 Fixes crashes in vertical-motion.
0bb23927
EZ
8764 (next_element_from_buffer): Improve commentary for when
8765 the iterator is before prev_stop.
8766 (init_iterator): Initialize bidi_p from the default value of
8767 bidi-display-reordering, not from buffer-local value. Use the
8768 buffer-local value only if initializing for buffer iteration.
8769 (handle_invisible_prop): Support invisible properties on strings
8770 that are being bidi-reordered.
8771 (set_iterator_to_next): Support bidi reordering of C strings and
8772 Lisp strings.
8773 (next_element_from_string): Support bidi reordering of Lisp
8774 strings.
8775 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8776 (display_string): Support display of R2L glyph rows.
8777 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8778 (init_iterator): Don't initialize it->bidi_p for strings
8779 here.
8780 (reseat_to_string): Initialize it->bidi_p for strings here.
8781 (next_element_from_string, next_element_from_c_string)
8782 (next_element_from_buffer): Add xassert's for correspondence
8783 between IT's object being iterated and it->bidi_it.string
8784 structure.
8785 (face_before_or_after_it_pos): Support bidi iteration.
8786 (next_element_from_c_string): Handle the case of the first string
8787 character that is not the first one in the visual order.
8788 (get_visually_first_element): New function, refactored from common
8789 parts of next_element_from_buffer, next_element_from_string, and
8790 next_element_from_c_string.
8791 (tool_bar_lines_needed, redisplay_tool_bar)
8792 (display_menu_bar): Force left-to-right direction. Add a FIXME
8793 comment for making that be controlled by a user option.
8794 (push_it, pop_it): Save and restore the state of the
8795 bidi iterator. Save and restore the bidi_p flag.
8796 (pop_it): Iterate out of display property for string iteration as
8797 well.
8798 (iterate_out_of_display_property): Support iteration over strings.
8799 (handle_single_display_spec): Set up it->bidi_it for iteration
8800 over a display string, and call bidi_init_it.
8801 (handle_single_display_spec, next_overlay_string)
8802 (get_overlay_strings_1, push_display_prop): Set up the bidi
8803 iterator for displaying display or overlay strings.
8804 (forward_to_next_line_start): Don't use the shortcut if
8805 bidi-iterating.
8806 (back_to_previous_visible_line_start): If handle_display_prop
8807 pushed the iterator stack, restore the internal state of the bidi
8808 iterator by calling bidi_pop_it same number of times.
8809 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8810 and we are bidi-iterating, don't decrement the iterator position;
8811 instead, set the first_elt flag in the bidi iterator, to produce
8812 the same effect.
8813 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8814 (push_display_prop): xassert that we are iterating a buffer.
8815 (push_it, pop_it): Save and restore paragraph_embedding member.
8816 (handle_single_display_spec, next_overlay_string)
8817 (get_overlay_strings_1, reseat_1, reseat_to_string)
8818 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8819 correctly. Don't assume unibyte strings are not bidi-reordered.
8820 (compute_display_string_pos)
8821 (compute_display_string_end): Fix handling the case of C string.
8822 (push_it, pop_it): Save and restore from_disp_prop_p.
8823 (handle_single_display_spec, push_display_prop): Set the
8824 from_disp_prop_p flag.
8825 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8826 (pop_it): Call iterate_out_of_display_property only if we are
8827 popping after iteration over a string that came from a display
8828 property. Fix a typo in popping stretch info. Add an assertion
8829 for verifying that the iterator position is in sync with the bidi
8830 iterator.
8831 (handle_single_display_spec, get_overlay_strings_1)
8832 (push_display_prop): Fix initialization of paragraph direction for
8833 string when that of the parent object is not yet determined.
8834 (reseat_1): Call bidi_init_it to resync the bidi
8835 iterator with IT's position. (Bug#7616)
8836 (find_row_edges): If ROW->start.pos gives position
8837 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8838 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8839 Reset the from_disp_prop_p flag.
8840 (SAVE_IT, RESTORE_IT): New macros.
8841 (pos_visible_p, face_before_or_after_it_pos)
8842 (back_to_previous_visible_line_start)
8843 (move_it_in_display_line_to, move_it_in_display_line)
8844 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8845 (try_scrolling, redisplay_window, display_line): Use them when
8846 saving a temporary copy of the iterator and restoring it back.
8847 (back_to_previous_visible_line_start, reseat_1)
8848 (init_iterator): Empty the bidi cache "stack".
8849 (move_it_in_display_line_to): If iterator ended up at
8850 EOL, but we never saw any buffer positions smaller than
8851 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8852 motion in bidi-reordered lines.
8853 (move_it_in_display_line_to): Record prev_method and prev_pos
8854 immediately before the call to set_iterator_to_next. Fixes cursor
8855 motion in bidi-reordered lines with stretch glyphs and strings
8856 displayed in margins. (Bug#8133) (Bug#8867)
8857 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8858 TO_CHARPOS.
640c8776
SM
8859 (pos_visible_p): Support positions in bidi-reordered lines.
8860 Save and restore bidi cache.
0bb23927
EZ
8861
8862 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8863 (bidi_paragraph_info): Delete unused struct.
8864 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8865 (bidi_cache_start): New variable.
8866 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8867 to zero.
8868 (bidi_cache_fetch_state, bidi_cache_search)
8869 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8870 (bidi_cache_find, bidi_peek_at_next_level)
8871 (bidi_level_of_next_char, bidi_find_other_level_edge)
8872 (bidi_move_to_visually_next): Compare cache index with
8873 bidi_cache_start rather than with zero.
8874 (bidi_fetch_char): Accept new argument STRING; all callers
8875 changed. Support iteration over a string. Support strings with
8876 display properties. Support unibyte strings. Fix the type of
8877 `len' according to what STRING_CHAR_AND_LENGTH expects.
8878 (bidi_paragraph_init, bidi_resolve_explicit_1)
8879 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8880 (bidi_level_of_next_char, bidi_move_to_visually_next):
8881 Support iteration over a string.
0bb23927
EZ
8882 (bidi_set_sor_type, bidi_resolve_explicit_1)
8883 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8884 can now be zero (for strings); special values 0 and -1 were
8885 changed to -1 and -2, respectively.
8886 (bidi_char_at_pos): New function.
8887 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8888 Call it instead of FETCH_MULTIBYTE_CHAR.
8889 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8890 initialized to valid values.
8891 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8892 values.
8893 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8894 the test for valid cached positions. Fix the logic for looking up
8895 the sentinel state in the cache. GCPRO the Lisp string we are
8896 iterating.
8897 (bidi_push_it, bidi_pop_it): New functions.
8898 (bidi_initialize): Initialize the bidi cache start stack pointer.
8899 (bidi_cache_ensure_space): New function, refactored from part of
8900 bidi_cache_iterator_state. Don't assume the required size is just
8901 one BIDI_CACHE_CHUNK away.
8902 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8903 (bidi_count_bytes, bidi_char_at_pos): New functions.
8904 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8905 always valid if bidi_cache_idx is valid.
8906 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8907 is valid if it's going to be used.
8908 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8909 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8910 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8911 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8912 (bidi_find_other_level_edge, bidi_cache_start_stack):
8913 All variables related to cache indices are now EMACS_INT.
c965adc5 8914
0bb23927
EZ
8915 * dispextern.h (struct bidi_string_data): New structure.
8916 (struct bidi_it): New member `string'. Make flag members be 1-bit
8917 fields, and put them last in the struct.
640c8776
SM
8918 (compute_display_string_pos, compute_display_string_end):
8919 Update prototypes.
0bb23927
EZ
8920 (bidi_push_it, bidi_pop_it): Add prototypes.
8921 (struct iterator_stack_entry): New members bidi_p,
8922 paragraph_embedding, and from_disp_prop_p.
8923 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8924 (bidi_shelve_cache, bidi_unshelve_cache):
8925 Declare prototypes.
0bb23927
EZ
8926
8927 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8928 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8929 and vector-like objects.
8930
8931 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8932 cache around display iteration.
8933
8934 * window.c (Fwindow_end, window_scroll_pixel_based)
8935 (displayed_window_lines, Frecenter): Save and restore the bidi
8936 cache around display iteration.
8937
3bbd2265
LMI
89382011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8939
8940 * editfns.c (Fdelete_region): Clarify the use of the named
8941 parameters (bug#6788).
8942
adc47434
MR
89432011-07-14 Martin Rudalics <rudalics@gmx.at>
8944
8945 * indent.c (Fvertical_motion): Set and restore w->pointm when
8946 saving and restoring the window's buffer (Bug#9006).
8947
837c31f8
LMI
89482011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8949
8950 * editfns.c (Fstring_to_char): Clarify just what is returned
8951 (bug#6576). Text by Eli Zaretskii.
8952
ac389d0c
JB
89532011-07-13 Juanma Barranquero <lekktu@gmail.com>
8954
8955 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8956
0be0ce47
EZ
89572011-07-13 Eli Zaretskii <eliz@gnu.org>
8958
8959 * buffer.c (mmap_find): Fix a typo.
8960
cd18e7e3
JB
89612011-07-13 Johan Bockgård <bojohan@gnu.org>
8962
8963 Fix execution of x selection hooks.
8964 * xselect.c (Qx_lost_selection_functions)
8965 (Qx_sent_selection_functions): New vars.
8966 (syms_of_xselect): DEFSYM them.
8967 (x_handle_selection_request): Pass Qx_sent_selection_functions
8968 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8969 (x_handle_selection_clear,x_clear_frame_selections):
8970 Pass Qx_lost_selection_functions rather than
8971 Vx_lost_selection_functions to Frun_hook_with_args.
8972
47ea7f44
PE
89732011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8974
ac389d0c 8975 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8976 The old code sometimes used this field without initializing it.
8977
47ea7f44
PE
8978 * alloc.c (gc_sweep): Don't read past end of array.
8979 In theory, the old code could also have corrupted Emacs internals,
8980 though it'd be very unlikely.
8981
bc985c87
AS
89822011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8983
8984 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8985 argument. (Bug#4026)
bc985c87 8986
0cf34688
LMI
89872011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8988
b3dadd76
LMI
8989 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8990 key" (bug#4257).
8991
0cf34688
LMI
8992 * window.c (Fset_window_start): Doc fix (bug#4199).
8993 (Fset_window_hscroll): Ditto.
8994
270768cd
PE
89952011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8996
077e3dda 8997 Fix minor new problems caught by GCC 4.6.1.
270768cd 8998 * term.c (init_tty): Remove unused local.
490011a6 8999 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9000 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9001 not used otherwise.
270768cd 9002
b1f58454
CY
90032011-07-12 Chong Yidong <cyd@stupidchicken.com>
9004
9005 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9006
22b9578d
LMI
90072011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9008
6e70ab07
LMI
9009 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9010 are the mini-buffer and the echo area (bug#3320).
9011
22b9578d
LMI
9012 * term.c (init_tty): Remove support for supdup, c10 and perq
9013 terminals, which are no longer supported (bug#1482).
9014
8974cc9f
JB
90152011-07-10 Johan Bockgård <bojohan@gnu.org>
9016
9017 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9018
a560d974
JD
90192011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9020
9021 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9022 for non-popups (Bug#3642).
9023
1dae0f0a
AS
90242011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9025
268c2c36 9026 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9027 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9028 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9029 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9030 * data.c (fmod): Likewise.
9031 * dispnew.c (swap_glyphs_in_rows): Likewise.
9032 * emacs.c (memory_warning_signal): Likewise.
9033 * floatfns.c (float_error): Likewise.
9034 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9035 (otf_open, font_otf_capability, generate_otf_features)
9036 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9037 Likewise.
9038 * image.c (pbm_read_file): Likewise.
9039 * indent.c (string_display_width): Likewise.
9040 * intervals.c (check_for_interval, search_for_interval)
9041 (inc_interval_count, count_intervals, root_interval)
9042 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9043 * lread.c (defalias): Likewise.
268c2c36 9044 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9045 * regex.c (set_image_of_range_1, set_image_of_range)
9046 (regex_grow_registers): Likewise.
9047 * sysdep.c (strerror): Likewise.
9048 * termcap.c (valid_filename_p, tprint, main): Likewise.
9049 * tparam.c (main): Likewise.
9050 * unexhp9k800.c (run_time_remap, save_data_space)
9051 (update_file_ptrs, read_header, write_header, calculate_checksum)
9052 (copy_file, copy_rest, display_header): Likewise.
9053 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9054 Likewise.
9055 * xdisp.c (check_it): Likewise.
9056 * xfaces.c (register_color, unregister_color, unregister_colors):
9057 Likewise.
9058 * xfns.c (print_fontset_result): Likewise.
9059 * xrdb.c (member, fatal, main): Likewise.
9060
99033785
PE
90612011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9062
9063 Fix minor problems found by static checking (Bug#9031).
9064 * chartab.c (char_table_set_range, map_sub_char_table):
9065 Remove unused locals.
9066 (uniprop_table): Now static.
9067 * composite.c (_work_char): Remove unused static var.
9068
9cb2ac56
JB
90692011-07-09 Juanma Barranquero <lekktu@gmail.com>
9070
9071 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9072
f25661f0
JD
90732011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9074
9075 * gtkutil.c (qttip_cb): Remove code without function.
9076
8278c4fe
EZ
90772011-07-09 Eli Zaretskii <eliz@gnu.org>
9078
9079 * w32.c (pthread_sigmask): New stub.
9080
1692ae2d 90812011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9082
8a6ebd58 9083 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9084 sigprocmask is portable only for single-threaded applications, and
9085 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9086 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9087 (LIBES): Use it.
9088 * callproc.c (Fcall_process):
9089 * process.c (create_process):
9090 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9091 Use pthread_sigmask, not sigprocmask.
123403e4 9092
1b854618
JD
90932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9094
9095 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9096 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9097 wrong (Bug#8591).
9098
3fe4b549
JD
90992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9100
0ce7e563
JD
9101 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9102 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9103 (xg_hide_tooltip): Fix comment.
9104
3fe4b549
JD
9105 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9106 in registerServicesMenuSendTypes.
9107 (validRequestorForSendType): Don't check ns_return_types.
9108
9109 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9110 ns_return_type.
9111
5df75e47
JR
91122011-07-08 Jason Rumney <jasonr@gnu.org>
9113
22610910
JR
9114 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9115 SH_SHOW for hidden windows (Bug#5482).
9116
5df75e47
JR
9117 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9118 frame struct members of non-existent frames (Bug#6284).
9119
699c10bd
JD
91202011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9121
4393663b
JD
9122 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9123 variable firstTime not needed on OSX >= 10.6.
9124 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9125 >= 10.5. Use setKnobProportion, setDoubleValue.
9126
9127 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9128 (MAC_OS_X_VERSION_10_5): Define if not defined.
9129 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9130 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9131 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9132
9133 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9134 cString and lossyCString on OSX >= 10.4.
4393663b 9135
58179cce 9136 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9137 sizeToFit on OSX >= 10.2.
9138
9139 * nsimage.m (allocInitFromFile): Don't use deprecated method
9140 bestRepresentationForDevice on OSX >= 10.6.
9141
9142 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9143 to avoid warning.
9144
9145 * emacs.c: Declare unexec_init_emacs_zone.
9146
a63e0781
JD
9147 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9148
699c10bd
JD
9149 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9150
9151 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9152 on svcsMenu (Bug#8842).
9153
9154 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9155 ns_return_types.
9156 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9157
9158 * nsterm.m (QUTF8_STRING): Declare.
9159 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9160 (validRequestorForSendType): Return type is (id).
9161 Change indexOfObjectIdenticalTo to indexOfObject.
9162 Check if we have local selection before returning self (Bug#8842).
9163 (writeSelectionToPasteboard): Put local selection into paste board
9164 if we have a local selection (Bug#8842).
9165 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9166
9167 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9168 (ns_get_local_selection): Declare.
9169
54e10184
LMI
91702011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9171
9888ff71
LMI
9172 * keymap.c (describe_map_tree): Don't insert a double newline at
9173 the end of the buffer (bug#1169) and return whether we inserted
9174 something.
9175
54e10184
LMI
9176 * callint.c (Fcall_interactively): Change "reading args" to
9177 "providing args" to try to clarify what it does (bug#1010).
9178
15fa4783
KH
91792011-07-07 Kenichi Handa <handa@m17n.org>
9180
9181 * composite.c (composition_compute_stop_pos): Ignore a static
9182 composition starting before CHARPOS (Bug#8915).
9183
9184 * xdisp.c (handle_composition_prop): Likewise.
9185
a8815b00
EZ
91862011-07-07 Eli Zaretskii <eliz@gnu.org>
9187
9188 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9189 (Bug#9015)
9190
ef7b981d 91912011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9192
9193 * character.h (unicode_category_t): New enum type.
9194
9195 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9196 (Qchar_code_property_table): New variable.
9197 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9198 (UNIPROP_COMPRESSED_FORM_P): New macros.
9199 (char_table_ascii): Uncompress the compressed values.
9200 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9201 Uncompress the compressed values.
ac389d0c 9202 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9203 (char_table_ref_and_range): Uncompress the compressed values.
9204 (sub_char_table_set): New arg is_uniprop. Callers changed.
9205 Uncompress the compressed values.
9206 (sub_char_table_set_range): Args changed. Callers changed.
9207 (char_table_set_range): Adjuted for the above change.
9208 (map_sub_char_table): Delete args default_val and parent. Add arg
9209 top. Give decoded values to a Lisp function.
640c8776 9210 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9211 values to a Lisp function. Gcpro more variables.
9212 (uniprop_table_uncompress)
9213 (uniprop_decode_value_run_length): New functions.
9214 (uniprop_decoder, uniprop_decoder_count): New variables.
9215 (uniprop_get_decoder, uniprop_encode_value_character)
9216 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9217 New functions.
9218 (uniprop_encoder, uniprop_encoder_count): New variables.
9219 (uniprop_get_encoder, uniprop_table)
9220 (Funicode_property_table_internal, Fget_unicode_property_internal)
9221 (Fput_unicode_property_internal): New functions.
9222 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9223 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9224 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9225 char-code-property-alist.
9226
640c8776 9227 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9228 Vunicode_category_table.
9229
640c8776 9230 * font.c (font_range): Adjust for the change of
c805dec0
KH
9231 Vunicode_category_table.
9232
76b397fb
DN
92332011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9234
9235 * m/iris4d.h: Remove file, move contents ...
9236 * s/irix6-5.h: ... here.
9237
22b4128e
PE
92382011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9239
9240 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9241 * alloc.c (mark_buffer):
9242 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9243 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9244 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9245 This isn't true in general, and it's particularly not true
9246 if Emacs is configured with --with-wide-int.
9247 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9248 New macros, used in the buffer.c change.
9249
869795d6
JD
92502011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9251
9252 * xsettings.c: Use both GConf and GSettings if both are available.
9253 (store_config_changed_event): Add comment.
9254 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9255 (store_tool_bar_style_changed): New functions.
5e617bc2 9256 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9257 (struct xsettings): Move font inside HAVE_XFT.
9258 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9259 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9260 Move inside HAVE_XFT.
640c8776 9261 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9262 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9263 also.
9264 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9265 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9266 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9267 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9268 (parse_settings): Move check for font inside HAVE_XFT.
9269 (read_settings, apply_xft_settings): Add comment.
9270 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9271 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9272 call store_font_name_changed.
9273 (xft_settings_event): Add comment.
9274 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9275 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9276 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9277 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9278 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9279 (xsettings_get_system_font, xsettings_get_system_normal_font):
9280 Add comment.
869795d6 9281
d8ed26bd
PE
92822011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9283
9284 Random fixes. E.g., (random) never returned negative values.
9285 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9286 subseconds part to the entropy, as that's a bit more random.
9287 Prefer signed to unsigned, since the signedness doesn't matter and
9288 in general we prefer signed. When given a limit, use a
9289 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9290 latter isn't right if USE_2_TAGS_FOR_INTS.
9291 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9292 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9293
cabf1cac
SM
92942011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9295
9296 * textprop.c (text_property_stickiness):
9297 Obey Vtext_property_default_nonsticky.
9298 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9299 * w32fns.c (syms_of_w32fns):
9300 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9301
6e9b2be9
PE
93022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9303
9304 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9305 This is more efficient than Ffile_directory_p and avoids a minor race.
9306
90186c68
LMI
93072011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9308
7c301272
LMI
9309 * buffer.c (Foverlay_put): Say what the return value is
9310 (bug#7835).
9311
c4f2d8d4
LMI
9312 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9313 is a directory before asking whether to use the file name
9314 (bug#7564).
ad637907
LMI
9315 (barf_or_query_if_file_exists): Make the "File is a directory"
9316 error be more correct.
c4f2d8d4 9317
90186c68
LMI
9318 * fns.c (Frequire): Remove the mention of the .gz files, since
9319 that's installation-specific, but keep the mention of
9320 `get-load-suffixes'.
9321
da64016e
PE
93222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9323
9324 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9325 Report string overflow if the output is too long.
9326
7d47b580
JB
93272011-07-04 Juanma Barranquero <lekktu@gmail.com>
9328
a555cb87
JB
9329 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9330 (syms_of_gnutls): Remove duplicate DEFSYM for
9331 Qgnutls_bootprop_verify_hostname_error, an error for
9332 Qgnutls_bootprop_verify_error (which is no longer used).
9333
7d47b580
JB
9334 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9335 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9336 Also (re)move comments that are misplaced or no longer relevant.
9337
1e49bfab
LMI
93382011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9339
9340 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9341
1485f4c0
CY
93422011-07-03 Chong Yidong <cyd@stupidchicken.com>
9343
9344 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9345 and background color parameters if they have been changed.
9346
a9ab721e
LMI
93472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9348
9349 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9350
cf7cff57
PE
93512011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9352
2e13213d
PE
9353 * xsettings.c (SYSTEM_FONT): Define only when used.
9354 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9355
cf7cff57
PE
9356 * keymap.c (access_keymap_1): Now static.
9357
7a8e04f7
CY
93582011-07-02 Chong Yidong <cyd@stupidchicken.com>
9359
9360 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9361 leave any prefix arg for the up event (Bug#1586).
9362
61352f62
LMI
93632011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9364
69bb1ef7
LMI
9365 * lread.c (syms_of_lread): Mention single symbols defined by
9366 `defvar' or `defconst' (bug#7154).
9367
61352f62 9368 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9369 (Frequire): Mention get-load-suffixes.
61352f62 9370
28545e04
MR
93712011-07-02 Martin Rudalics <rudalics@gmx.at>
9372
9373 * window.h (window): Remove clone_number slot.
9374 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9375 Remove.
9376 (make_parent_window, make_window, saved_window)
9377 (Fset_window_configuration, save_window_save): Don't deal with
9378 clone numbers.
9379 * buffer.c (Qclone_number): Remove declaration.
9380 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9381
3349e122
SM
93822011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9383
9384 Add multiple inheritance to keymaps.
9385 * keymap.c (Fmake_composed_keymap): New function.
9386 (Fset_keymap_parent): Simplify.
9387 (fix_submap_inheritance): Remove.
9388 (access_keymap_1): New function extracted from access_keymap to handle
9389 embedded parents and handle lists of maps.
9390 (access_keymap): Use it.
9391 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9392 (Fcopy_keymap): Handle embedded parents.
9393 (Fcommand_remapping, define_as_prefix): Simplify.
9394 (Fkey_binding): Simplify.
9395 (syms_of_keymap): Move minibuffer-local-completion-map,
9396 minibuffer-local-filename-completion-map,
9397 minibuffer-local-must-match-map, and
9398 minibuffer-local-filename-must-match-map to Elisp.
9399 (syms_of_keymap): Defsubr make-composed-keymap.
9400 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9401 (parse_menu_item): Trivial simplification.
9402
3279eb87
GM
94032011-07-01 Glenn Morris <rgm@gnu.org>
9404
9405 * Makefile.in (SETTINGS_LIBS): Fix typo.
9406
4550efdf
KI
94072011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9408
9409 * coding.c (Fencode_coding_string): Record the last coding system
9410 used, as the function doc string says (bug#8738).
9411
0949d2b6
JD
94122011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9413
9414 * xsettings.c (store_monospaced_changed): Take new font as arg and
9415 check for change against current_mono_font.
9416 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9417 (emacs_settings_constructor, emacs_settings_get_property)
9418 (emacs_settings_set_property, emacs_settings_class_init)
9419 (emacs_settings_init, gsettings_obj): Remove.
9420 (something_changedCB): New function for HAVE_GSETTINGS.
9421 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9422 with value as argument.
9423 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9424 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9425 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9426 "changed".
9427
9428 * xgselect.c: Add defined (HAVE_GSETTINGS).
9429 (xgselect_initialize): Ditto.
9430
9431 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9432 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9433 xg_select.
9434
bbc6b304
PE
94352011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9436
9437 * eval.c (struct backtrace): Simplify and port the data structure.
9438 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9439 signed bit field, as this assumption is not portable and it makes
9440 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9441 "char debug_on_exit : 1" as this is not portable either; instead,
9442 use the portable "unsigned int debug_on_exit : 1". Remove unused
9443 member evalargs. Remove obsolete comments about cc bombing out.
9444
9851bfc5
JD
94452011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9446
51bb811f 9447 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9448 Let HAVE_GSETTINGS override HAVE_GCONF.
9449 (store_monospaced_changed): New function.
9450 (EMACS_SETTINGS): A new type derived from GObject to handle
9451 GSettings notifications.
9452 (emacs_settings_constructor, emacs_settings_get_property)
9453 (emacs_settings_set_property, emacs_settings_class_init):
9454 New functions.
9455 (gsettings_client, gsettings_obj): New variables.
9456 (GSETTINGS_SCHEMA): New define.
9457 (something_changedCB): Call store_monospaced_changed.
9458 (init_gsettings): New function.
9459 (xsettings_initialize): Call init_gsettings.
9460 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9461 to NULL.
9462
640c8776 9463 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9464 GCONF_CFLAGS/LIBS.
9465
5386012d
MR
94662011-06-29 Martin Rudalics <rudalics@gmx.at>
9467
9468 * window.c (resize_root_window, grow_mini_window)
9469 (shrink_mini_window): Rename Qresize_root_window to
9470 Qwindow_resize_root_window and Qresize_root_window_vertically to
9471 Qwindow_resize_root_window_vertically.
9472
f13e0b08
PE
94732011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9474
9475 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9476
94515237
JB
94772011-06-27 Juanma Barranquero <lekktu@gmail.com>
9478
9479 * makefile.w32-in: Redesign dependencies so they reflect more
9480 clearly which files are directly included by each source file,
9481 and not through other includes.
9482
e43b6e43
MR
94832011-06-27 Martin Rudalics <rudalics@gmx.at>
9484
9485 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9486 (sort_overlays, overlay_strings): When an overlay's clone number
9487 matches the window's clone number process the overlay even if
9488 the overlay's window property doesn't match the current window.
9489
d68443dc
MR
9490 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9491 (Fwindow_hchild): Rename to Fwindow_left_child.
9492 (Fwindow_next): Rename to Fwindow_next_sibling.
9493 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9494 (resize_window_check): Rename to window_resize_check.
9495 (resize_window_apply): Rename to window_resize_apply.
9496 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9497 (Fdelete_other_windows_internal, resize_frame_windows)
9498 (Fsplit_window_internal, Fdelete_window_internal)
9499 (grow_mini_window, shrink_mini_window)
9500 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9501
c7e73be5
JD
95022011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9503
9504 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9505 (emacs_fixed_set_min_size): Remove.
9506 (emacs_fixed_new): Take frame as argument.
9507
9508 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9509 (_EmacsFixedPrivate): Remove minwidth/height.
9510 Add struct frame *f.
9511 (emacs_fixed_init): Initialize priv->f.
9512 (get_parent_class, emacs_fixed_set_min_size): Remove.
9513 (emacs_fixed_new): Set priv->f to argument.
9514 (emacs_fixed_get_preferred_width)
9515 (emacs_fixed_get_preferred_height): Use min_width/height from
9516 frames size_hint to set minimum and natural (Bug#8919).
9517 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9518 and use min_width/height from frames size_hint to set
9519 min_width/height (Bug#8919).
9520
9521 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9522 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9523 Fix indentation.
c7e73be5 9524
cf99dcf8
EZ
95252011-06-26 Eli Zaretskii <eliz@gnu.org>
9526
9527 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9528 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9529 called at ZV.
9530
029529ac
CY
95312011-06-26 Chong Yidong <cyd@stupidchicken.com>
9532
9533 * process.c (wait_reading_process_output): Bypass select if
9534 waiting for a cell while ignoring keyboard input, and input is
9535 pending. Suggested by Jan Djärv (Bug#8869).
9536
7a7ef429
PE
95372011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9538
9539 Use gnulib's dup2 module instead of rolling our own.
9540 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9541
11fdef7d 95422011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9543
9544 * dispnew.c (scrolling_window): Before scrolling, turn off a
9545 mouse-highlight in the window being scrolled.
9546
cd3520a4
JB
95472011-06-24 Juanma Barranquero <lekktu@gmail.com>
9548
9549 Move DEFSYM to lisp.h and use everywhere.
9550
9551 * character.h (DEFSYM): Move declaration...
9552 * lisp.h (DEFSYM): ...here.
9553
9554 * gnutls.c:
9555 * minibuf.c:
9556 * w32menu.c:
9557 * w32proc.c:
9558 * w32select.c: Don't include character.h.
9559
9560 * alloc.c (syms_of_alloc):
9561 * buffer.c (syms_of_buffer):
9562 * bytecode.c (syms_of_bytecode):
9563 * callint.c (syms_of_callint):
9564 * casefiddle.c (syms_of_casefiddle):
9565 * casetab.c (init_casetab_once):
9566 * category.c (init_category_once, syms_of_category):
9567 * ccl.c (syms_of_ccl):
9568 * cmds.c (syms_of_cmds):
9569 * composite.c (syms_of_composite):
9570 * dbusbind.c (syms_of_dbusbind):
9571 * dired.c (syms_of_dired):
9572 * dispnew.c (syms_of_display):
9573 * doc.c (syms_of_doc):
9574 * editfns.c (syms_of_editfns):
9575 * emacs.c (syms_of_emacs):
9576 * eval.c (syms_of_eval):
9577 * fileio.c (syms_of_fileio):
9578 * fns.c (syms_of_fns):
9579 * frame.c (syms_of_frame):
9580 * fringe.c (syms_of_fringe):
9581 * insdel.c (syms_of_insdel):
9582 * keymap.c (syms_of_keymap):
9583 * lread.c (init_obarray, syms_of_lread):
9584 * macros.c (syms_of_macros):
9585 * msdos.c (syms_of_msdos):
9586 * print.c (syms_of_print):
9587 * process.c (syms_of_process):
9588 * search.c (syms_of_search):
9589 * sound.c (syms_of_sound):
9590 * syntax.c (init_syntax_once, syms_of_syntax):
9591 * terminal.c (syms_of_terminal):
9592 * textprop.c (syms_of_textprop):
9593 * undo.c (syms_of_undo):
9594 * w32.c (globals_of_w32):
9595 * window.c (syms_of_window):
9596 * xdisp.c (syms_of_xdisp):
9597 * xfaces.c (syms_of_xfaces):
9598 * xfns.c (syms_of_xfns):
9599 * xmenu.c (syms_of_xmenu):
9600 * xsettings.c (syms_of_xsettings):
9601 * xterm.c (syms_of_xterm): Use DEFSYM.
9602
4228cf16
TZ
96032011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9604
cd3520a4 9605 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9606
7fcccf1e
PE
96072011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9608
7efb4e0e
PE
9609 Integer and buffer overflow fixes (Bug#8873).
9610
ff5844ad
PE
9611 * print.c (printchar, strout): Check for string overflow.
9612 (PRINTPREPARE, printchar, strout):
9613 Don't set size unless allocation succeeds.
9614
90532f02
PE
9615 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9616 for sizes. Check for string overflow more accurately.
9617 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9618
6d84508d
PE
9619 * macros.c: Integer and buffer overflow fixes.
9620 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9621 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9622 Use ptrdiff_t, not int, for sizes.
9623 Don't increment bufsize until after realloc succeeds.
9624 Check for size-calculation overflow.
9625 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9626
437b2cb4
PE
9627 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9628
8b9ac8b4
PE
9629 * lread.c: Integer overflow fixes.
9630 (read_integer): Radix is now EMACS_INT, not int,
9631 to improve quality of diagnostics for out-of-range radices.
9632 Calculate buffer size correctly for out-of-range radices.
9633 (read1): Check for integer overflow in radices, and in
9634 read-circle numbers.
82cb60d3
PE
9635 (read_escape): Avoid int overflow.
9636 (Fload, openp, read_buffer_size, read1)
9637 (substitute_object_recurse, read_vector, read_list, map_obarray):
9638 Use ptrdiff_t, not int, for sizes.
9639 (read1): Use EMACS_INT, not int, for sizes.
20270765 9640 Check for size overflow.
8b9ac8b4 9641
7fcccf1e
PE
9642 * image.c (cache_image): Check for size arithmetic overflow.
9643
bfbbd7e7
PE
9644 * lread.c: Integer overflow issues.
9645 (saved_doc_string_size, saved_doc_string_length)
9646 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9647 Now ptrdiff_t, not int.
9648 (read1): Don't assume doc string length fits in int. Check for
9649 out-of-range doc string lengths.
9650 (read_list): Don't assume file position fits in int.
39019e54 9651 (read_escape): Check for hex character overflow.
bfbbd7e7 9652
4e323265
LL
96532011-06-22 Leo Liu <sdl.web@gmail.com>
9654
9655 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9656 Move to minibuffer.el.
9657
85fece3e
PE
96582011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9659
20b84ce9 9660 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9661 The following patches are for when GLYPH_DEBUG && !XASSERT.
9662 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9663 * dispnew.c (flush_stdout):
9664 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9665 Mark as externally visible.
9666 * dispnew.c (check_window_matrix_pointers): Now static.
9667 * dispnew.c (window_to_frame_vpos):
9668 * xfns.c (unwind_create_frame):
9669 * xterm.c (x_check_font): Remove unused local.
9670 * scroll.c (CHECK_BOUNDS):
9671 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9672 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9673 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9674 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9675 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9676 Now static.
9677 (debug_method_add): Use va_list and vsprintf rather than relying
9678 on undefined behavior with wrong number of arguments.
9679 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9680 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9681 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9682 since we're not interested in debugging glyphs with old libraries.
9683 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9684 GCC 4.6.0's static checking.
9685
0766b489
PE
96862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9687
31fd4b32
PE
9688 Integer overflow and signedness fixes (Bug#8873).
9689 A few related buffer overrun fixes, too.
9690
b79e8648
PE
9691 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9692
0766b489
PE
9693 * dispextern.h (struct face.stipple):
9694 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9695 (x_bitmap_mask, x_allocate_bitmap_record)
9696 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9697 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9698 (x_create_bitmap_from_xpm_data):
9699 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9700 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9701 (.bitmaps_last):
9702 * xfaces.c (load_pixmap):
9703 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9704 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9705 (.bitmaps_last, struct x_output.icon_bitmap):
9706 Use ptrdiff_t, not int, for bitmap indexes.
9707 (x_allocate_bitmap_record): Check for size overflow.
9708 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9709
b081724f
PE
9710 Use ptrdiff_t, not int, for overlay counts.
9711 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9712 * editfns.c (overlays_around, get_pos_property):
9713 * textprop.c (get_char_property_and_overlay):
9714 * xdisp.c (next_overlay_change, note_mouse_highlight):
9715 * xfaces.c (face_at_buffer_position):
21514da7
PE
9716 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9717 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9718 (Fnext_overlay_change, Fprevious_overlay_change)
9719 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9720 Use ptrdiff_t, not int, for sizes.
21514da7 9721 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9722
3de73e5e
PE
9723 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9724
2606c57b
PE
9725 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9726 (x_session_initialize): Do not assume string length fits in int.
9727
aaafe47a
PE
9728 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9729 This is unlikely, but can occur if DPI is outlandish.
9730
2674ddc8 9731 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9732 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9733
28154962
PE
9734 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9735 * xrdb.c (magic_file_p, search_magic_path):
9736 Omit last arg SUFFIX; it was always 0. All callers changed.
9737 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9738
7de51af5
PE
9739 * xfont.c (xfont_match): Avoid need for strlen.
9740
25ed6cc3
PE
9741 * xfns.c: Don't assume strlen fits in int.
9742 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9743
4eab31dd
PE
9744 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9745 not unsigned long, as we prefer signed integers. All callers changed.
9746 Detect integer overflow in repeat count.
9747 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9748 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9749
171e2a58
PE
9750 * termcap.c: Don't assume sizes fit in int and never overflow.
9751 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9752 (gobble_line): Check for size-calculation overflow.
9753
ad39faca 9754 * minibuf.c (Fread_buffer):
6e5bb2dc 9755 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9756 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9757 Don't assume string length fits in int.
9758
52c61c22 9759 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9760 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9761
b5b8c9e5
PE
9762 * font.c: Don't assume string length fits in int.
9763 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9764 Use ptrdiff_t, not int.
ccd6111c
PE
9765 (font_intern_prop): Don't assume string length fits in int.
9766 Don't assume integer property fits in fixnum.
9767 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9768
882f0d81 9769 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9770 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9771 Reformulate so as not to need the command string.
9772 Invoke gzip -cd rather than gunzip, as it's more portable.
9773 (lock_info_type, lock_file_1, lock_file):
9774 Don't assume pid_t and time_t fit in unsigned long.
9775 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9776 (current_lock_owner): Prefer signed type for sizes.
9777 Use memcpy, not strncpy, where memcpy is what is really wanted.
9778 Don't assume (via atoi) that time_t and pid_t fit in int.
9779 Check for time_t and/or pid_t out of range, e.g., via a network share.
9780 Don't alloca where an auto var works fine.
9781
93f4cf88
PE
9782 * fileio.c: Fix some integer overflow issues.
9783 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9784 Don't assume string length fits in int.
9785 (directory_file_name): Don't assume string length fits in long.
9786 (make_temp_name): Don't assume pid fits in int, or that its print
9787 length is less than 20.
9788
f3e92b69
PE
9789 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9790
1bfdaf10
PE
9791 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9792
35016e9a
PE
9793 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9794
3d1e65a1
PE
9795 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9796 We prefer signed integers, even for size calculations.
9797
0b963a93
PE
9798 * emacs.c: Don't assume string length fits in 'int'.
9799 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9800 (main): Don't invoke strlen when not needed.
9801
573f4b54
PE
9802 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9803 (XD_DEBUG_MESSAGE): Don't waste a byte.
9804
989f33ba
PE
9805 * callproc.c (getenv_internal_1, getenv_internal)
9806 (Fgetenv_internal):
965d34eb
PE
9807 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9808
e4d29b33
PE
9809 * lread.c (invalid_syntax): Omit length argument.
9810 All uses changed. This doesn't fix a bug, but it simplifies the
9811 code away from its former Hollerith-constant appearance, and it's
9812 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9813 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9814
eb49b136
PE
9815 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9816 This didn't break anything, but it didn't help either.
9817 It's confusing to put a bogus integer in a place where the actual
9818 value does not matter.
9f62aeb1 9819 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9820 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9821
15375a22
PE
9822 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9823 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9824 implementation.
b61cc01c
PE
9825 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9826 We prefer signed types, and the value cannot exceed the EMACS_INT
9827 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9828 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9829 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9830 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9831
53b2623d
PE
9832 * indent.c (sane_tab_width): New function.
9833 (current_column, scan_for_column, Findent_to, position_indentation)
9834 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9835 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9836
51cab52b 9837 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9838
f2ed8a70
PE
9839 * lisp.h (lint_assume): New macro.
9840 * composite.c (composition_gstring_put_cache):
9841 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9842
abe80cc6
PE
9843 * editfns.c, insdel.c:
9844 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9845
b02c740e
PE
9846 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9847
ebc96716
PE
9848 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9849
b4e50fa0 9850 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9851 Use much-faster test for byte-length change.
311d5d7c 9852 Don't assume string byte-length fits in 'int'.
a4cf38e4 9853 Check that character arg fits in 'int'.
85461888 9854 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9855
c0c1ee9f
PE
9856 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9857
a498d7f4
PE
9858 * fns.c (concat): Catch string overflow earlier.
9859 Do not rely on integer wraparound.
9860
51cab52b
PE
9861 * dispextern.h (struct it.overlay_strings_charpos)
9862 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9863 * xdisp.c (forward_to_next_line_start)
9864 (back_to_previous_visible_line_start)
9865 (reseat_at_next_visible_line_start, next_element_from_buffer):
9866 Don't arbitrarily truncate the value of 'selective' to int.
9867
76031fad
PE
9868 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9869
5eb55db9
PE
9870 * composite.c: Don't truncate sizes to 'int'.
9871 (composition_gstring_p, composition_reseat_it)
9872 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9873 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9874 not EMACS_UINT, for indexes.
5eb55db9 9875
0703a717
PE
9876 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9877
d6202519
PE
9878 * buffer.c: Include <verify.h>.
9879 (struct sortvec.priority, struct sortstr.priority):
8961a454 9880 Now EMACS_INT, not int.
c20998a7 9881 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9882 (struct sortstr.size, record_overlay_string)
9883 (struct sortstrlist.size, struct sortlist.used):
9884 Don't truncate size to int.
9885 (record_overlay_string): Check for size-calculation overflow.
d6202519 9886 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9887
d5a19415
JM
98882011-06-22 Jim Meyering <meyering@redhat.com>
9889
029529ac 9890 Don't leak an XBM-image-sized buffer
d5a19415
JM
9891 * image.c (xbm_load): Free the image buffer after using it.
9892
a9041e6c
PE
98932011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9894
9895 Port to Sun C.
9896 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9897 that Sun C diagnosed.
9898 * fns.c (secure_hash): Fix pointer signedness issue.
9899 * intervals.c (static_offset_intervals): New function.
9900 (offset_intervals): Use it.
9901
7f3f739f
LL
99022011-06-21 Leo Liu <sdl.web@gmail.com>
9903
9904 * deps.mk (fns.o):
9905 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9906 sha512.h.
9907
9908 * fns.c (secure_hash): Rename from crypto_hash_function and change
9909 the first arg to accept symbols.
5b66d427 9910 (Fsecure_hash): New primitive.
7f3f739f
LL
9911 (syms_of_fns): New symbols.
9912
76147d94
DD
99132011-06-20 Deniz Dogan <deniz@dogan.se>
9914
9915 * process.c (Fset_process_buffer): Clarify return value in
9916 docstring.
9917
7d7d0045
CY
99182011-06-18 Chong Yidong <cyd@stupidchicken.com>
9919
9920 * dispnew.c (add_window_display_history): Use BVAR.
9921
9922 * xdisp.c (debug_method_add): Use BVAR.
9923 (check_window_end, dump_glyph_matrix, dump_glyph)
9924 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9925
9926 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9927 Likewise.
9928
9929 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9930 check till after the cache is created in init_frame_faces.
9931
ff2bc410
SM
99322011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9933
9934 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9935
28177add
PE
99362011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9937
dd3482fe
PE
9938 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9939 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9940 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9941
393d71f3 9942 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9943 * fileio.c (Finsert_file_contents):
9944 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9945 Remove the old (too-loose) buffer overflow checks.
9946 They weren't needed, since make_gap checks for buffer overflow.
9947 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9948 The old code merely checked for Emacs fixnum overflow, and relied
9949 on undefined (wraparound) behavior. The new code avoids undefined
9950 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9951
2e6813b0 9952 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9953 Tune. Don't use wider integers than needed. Don't use alloca.
9954 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9955
599a9e4f
PE
9956 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9957
99561444
PE
9958 * insdel.c, lisp.h (buffer_overflow): New function.
9959 (insert_from_buffer_1, replace_range, replace_range_2):
9960 * insdel.c (make_gap_larger):
9961 * editfns.c (Finsert_char):
9962 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9963
28177add
PE
9964 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9965
e69dafad
PE
99662011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9967
4baa020d 9968 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9969
b1c46f02
PE
9970 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9971 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9972
e69dafad
PE
9973 * fileio.c: Don't assume EMACS_INT fits in off_t.
9974 (emacs_lseek): New static function.
9975 (Finsert_file_contents, Fwrite_region): Use it.
9976 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9977
566684ea
PE
9978 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9979
e6966cd6
PE
9980 * fns.c: Don't overflow int when computing a list length.
9981 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9982 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9983 truncation on 64-bit hosts. Check for QUIT every
9984 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9985 faster and is responsive enough.
9986 (Flength): Report an error instead of overflowing an integer.
9987 (Fsafe_length): Return a float if the value is not representable
9988 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9989 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9990 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9991
dd0b0efb
PE
9992 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9993 (header_size, word_size): New constants.
9994 (allocate_vectorlike): Don't check size overflow here.
9995 (allocate_vector): Check it here instead, since this is the only
9996 caller of allocate_vectorlike that could cause overflow.
9997 Check that the new vector's length is representable as a fixnum.
9998
86fe5cfe
PE
9999 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10000 The previous code was bogus. For example, next_almost_prime (32)
10001 returned 39, which is undesirable as it is a multiple of 3; and
10002 next_almost_prime (24) returned 25, which is a multiple of 5 so
10003 why was the code bothering to check for multiples of 7?
10004
80e88859
PE
10005 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10006
4a2f0ad6
PE
10007 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10008
f66c7cf8
PE
10009 Variadic C functions now count arguments with ptrdiff_t.
10010 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10011 Back then I didn't know that the Emacs coding style prefers signed int.
10012 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10013 were being counted with int, which may truncate counts on 64-bit
10014 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10015 * lisp.h (struct Lisp_Subr.function.aMANY)
10016 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10017 Arg counts are now ptrdiff_t, not size_t.
10018 All variadic functions and their callers changed accordingly.
10019 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10020 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10021 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10022 * callint.c (Fcall_interactively): Check arg count for overflow,
10023 to avoid potential buffer overrun. Use signed char, not 'int',
10024 for 'varies' array, so that we needn't bother to check its size
10025 calculation for overflow.
10026 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10027 * eval.c (apply_lambda):
10028 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10029 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10030 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10031
a1759b76
PE
10032 * callint.c (Fcall_interactively): Don't use index var as event count.
10033
d96be9fc
PE
10034 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10035 * mem-limits.h (SIZE): Remove; no longer used.
10036
a690a978 10037 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10038
578c21e6
PE
10039 Remove unnecessary casts.
10040 * xterm.c (x_term_init):
10041 * xfns.c (x_set_border_pixel):
10042 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10043 These aren't needed now that we assume ANSI C.
10044
96f53c6c
PE
10045 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10046 It's more likely to cause problems (due to unsigned overflow)
10047 than to cure them.
10048
83c77d31
PE
10049 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10050
ee2079f1
PE
10051 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10052
6da65536
PE
10053 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10054
7147c4a4
PE
10055 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10056
193e32d9
PE
10057 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10058
e5533da6
PE
10059 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10060
9910e595
PE
10061 GLYPH_CODE_FACE returns EMACS_INT, not int.
10062 * dispextern.h (merge_faces):
10063 * xfaces.c (merge_faces):
01103c44
PE
10064 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10065 Don't assume EMACS_INT fits in int.
9910e595 10066
2638320e
PE
10067 * character.h (CHAR_VALID_P): Remove unused parameter.
10068 * fontset.c, lisp.h, xdisp.c: All uses changed.
10069
045eb8d9
PE
10070 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10071
c1f134b5
PE
10072 * fns.c (concat): Minor tuning based on overflow analysis.
10073 This doesn't fix any bugs. Use int to hold character, instead
10074 of constantly refetching from Emacs object. Use XFASTINT, not
10075 XINT, for value known to be a character. Don't bother comparing
10076 a single byte to 0400, as it's always less.
10077
395fcb93 10078 * floatfns.c (Fexpt):
327eeec8
PE
10079 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10080
abbd3d23
PE
10081 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10082 for characters.
10083
684a03ef
PE
10084 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10085
0fed43f3
PE
10086 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10087 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10088 incorrectly succeed when S was a string, because 4294967386 was
10089 truncated before it was used.
10090
8fd02eb7
PE
10091 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10092 Otherwise, an out-of-range integer could cause undefined behavior
10093 on a 64-bit host.
10094
f8c86b69
PE
10095 * composite.c: Use int, not EMACS_INT, for characters.
10096 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10097 EMACS_INT, for values that are known to be in character range.
10098 This doesn't fix any bugs but is the usual style inside Emacs and
10099 may generate better code on 32-bit machines.
10100
34206dd2
PE
10101 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10102 This is for reasons similar to the recent CHAR_STRING fix.
10103 * charset.c (Fencode_char): Check that character arg is actually
10104 a character. Pass an int to ENCODE_CHAR.
10105 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10106 wider than 'int', as a compile-time check to prevent future regressions
10107 in this area.
10108
c5958d4c 10109 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10110
10111 Make sure a 64-bit char is never passed to CHAR_STRING.
10112 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10113 by silently ignoring the top 32 bits, allowing some values
10114 that were far too large to be valid characters.
10115 * character.h: Include <verify.h>.
10116 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10117 arguments are no wider than unsigned, as a compile-time check
10118 to prevent future regressions in this area.
10119 * data.c (Faset):
01103c44 10120 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10121 (Fsubst_char_in_region):
10122 * fns.c (concat):
10123 * xdisp.c (decode_mode_spec_coding):
10124 Adjust to CHAR_STRING's new requirement.
10125 * editfns.c (Finsert_char, Fsubst_char_in_region):
10126 * fns.c (concat): Check that character args are actually
10127 characters. Without this test, these functions did the wrong
10128 thing with wildly out-of-range values on 64-bit hosts.
10129
d37ca623
PE
10130 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10131 These casts should not be needed on 32-bit hosts, either.
10132 * keyboard.c (read_char):
10133 * lread.c (Fload): Remove casts to unsigned.
10134
ea204efb
PE
10135 * lisp.h (UNSIGNED_CMP): New macro.
10136 This fixes comparison bugs on 64-bit hosts.
10137 (ASCII_CHAR_P): Use it.
10138 * casefiddle.c (casify_object):
01103c44 10139 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10140 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10141 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10142 * dispextern.h (FACE_FROM_ID):
10143 * keyboard.c (read_char): Use UNSIGNED_CMP.
10144
41cb286c
PE
10145 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10146 not to EMACS_INT, to avoid GCC warning.
10147
4a1b9832
PE
10148 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10149
55daad71
PE
10150 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10151 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10152 isn't needed on 32-bit machines.
8f95c75c 10153
01103c44
PE
10154 * buffer.c (Fgenerate_new_buffer_name):
10155 Use EMACS_INT for count, not int.
0ceccced 10156 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10157
10158 * data.c (Qcompiled_function): Now static.
10159
c6f072e7
PE
10160 * window.c (window_body_lines): Now static.
10161
20ce5912
PE
10162 * image.c (gif_load): Rename local to avoid shadowing.
10163
9c4c5f81
PE
10164 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10165 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10166 * alloc.c (make_save_value): Integer argument is now of type
10167 ptrdiff_t, not int.
10168 (mark_object): Use ptrdiff_t, not int.
10169 * lisp.h (pD): New macro.
10170 * print.c (print_object): Use it.
10171
c0c5c8ae
PE
10172 * alloc.c: Use EMACS_INT, not int, to count objects.
10173 (total_conses, total_markers, total_symbols, total_vector_size)
10174 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10175 (total_free_floats, total_floats, total_free_intervals)
10176 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10177 Now EMACS_INT, not int. All uses changed.
10178 (Fgarbage_collect): Compute overall total using a double, so that
10179 integer overflow is less likely to be a problem. Check for overflow
10180 when converting back to an integer.
5a25e253
PE
10181 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10182 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10183 These were 'int' variables that could overflow on 64-bit hosts;
10184 they were never used, so remove them instead of repairing them.
211a0b2a 10185 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10186 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10187 Previously, this ceilinged at INT_MAX, but that doesn't work on
10188 64-bit machines.
e46bb31a 10189 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10190
c78baabf 10191 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10192 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10193 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10194 when a (possibly-narrower) signed value would do just as well.
10195 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10196
c9d624c6
PE
10197 * alloc.c: Catch some string size overflows that we were missing.
10198 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10199 for convenience in STRING_BYTES_MAX.
10200 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10201 The definition here is exact; the one in lisp.h was approximate.
10202 (allocate_string_data): Check for string overflow. This catches
10203 some instances we weren't catching before. Also, it catches
10204 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10205 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10206 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10207
c9d624c6
PE
10208 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10209 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10210 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10211
353032ce
PE
10212 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10213
2bccce07
PE
10214 * alloc.c (Fmake_string): Check for out-of-range init.
10215
0ac30604
SM
102162011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10217
10218 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10219
c195f2de
JD
102202011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10221
10222 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10223 xg_get_default_scrollbar_width.
10224
10225 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10226 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10227 (style_changed_cb): Call update_theme_scrollbar_width and call
10228 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10229 all frames (Bug#8505).
10230 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10231 Call gtk_window_set_resizable if HAVE_GTK3.
10232 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10233 and height if HAVE_GTK3 (Bug#8505).
10234 (scroll_bar_width_for_theme): New variable.
10235 (update_theme_scrollbar_width): New function.
10236 (xg_get_default_scrollbar_width): Move code to
10237 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10238 (xg_initialize): Call update_theme_scrollbar_width.
10239
10240 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10241
10242 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10243
e10ac9f1
MR
102442011-06-12 Martin Rudalics <rudalics@gmx.at>
10245
10246 * frame.c (make_frame): Call other_buffer_safely instead of
10247 other_buffer.
10248
10249 * window.c (temp_output_buffer_show): Call display_buffer with
10250 second argument Vtemp_buffer_show_specifiers and reset latter
10251 immediately after the call.
10252 (Vtemp_buffer_show_specifiers): New variable.
10253 (auto_window_vscroll_p, next_screen_context_lines)
10254 (Vscroll_preserve_screen_position): Remove leading asterisks from
10255 doc-strings.
10256
2d3c217e 102572011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10258
7b7f97e8 10259 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10260 * buffer.c (Qclone_number): Remove for now, as it's unused.
10261 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10262 (record_buffer): Remove unused local.
10263 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10264 (set_frame_buffer_list): Remove; unused.
10265 * frame.h (other_visible_frames): Remove decl.
10266 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10267 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10268 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10269 if HAVE_GPM.
10270 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10271 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10272 Define only if HAVE_GPM.
10273 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10274 (update_hints_inhibit): Remove; never set. All uses removed.
10275 * widgetprv.h (emacsFrameClassRec): Remove decl.
10276 * window.c (delete_deletable_window): Now returns void, since it
10277 wasn't returning anything.
10278 (compare_window_configurations): Remove unused locals.
10279 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10280 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10281 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10282 the same widths as pointers. This follows up on the 2011-05-06 patch.
10283 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10284 * xterm.h: Likewise.
10285 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10286
1384b89e
JB
102872011-06-12 Juanma Barranquero <lekktu@gmail.com>
10288
10289 * makefile.w32-in: Update dependencies.
10290 (LISP_H): Add lib/intprops.h.
10291
1100a63c
CY
102922011-06-11 Chong Yidong <cyd@stupidchicken.com>
10293
10294 * image.c (gif_load): Add animation frame delay to the metadata.
10295 (syms_of_image): Use DEFSYM. New symbol `delay'.
10296
6198ccd0
MR
102972011-06-11 Martin Rudalics <rudalics@gmx.at>
10298
10299 * window.c (delete_deletable_window): Re-add.
10300 (Fset_window_configuration): Rewrite to handle dead buffers and
10301 consequently deletable windows.
10302 (window_tree, Fwindow_tree): Remove. Supply functionality in
10303 window.el.
10304 (compare_window_configurations): Simplify code.
10305
b6e3633c
AS
103062011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10307
1ab0dee5
AS
10308 * image.c (imagemagick_load_image): Fix type mismatch.
10309 (Fimagemagick_types): Likewise.
10310
b6e3633c
AS
10311 * window.h (replace_buffer_in_windows): Declare.
10312
9397e56f
MR
103132011-06-11 Martin Rudalics <rudalics@gmx.at>
10314
10315 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10316 Qclone_number. Remove external declaration of Qdelete_window.
10317 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10318 code.
640c8776
SM
10319 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10320 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10321 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10322 buffer list implementation.
10323 (other_buffer_safely): New function.
10324 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10325 calls to replace_buffer_in_windows and
10326 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10327 if allowed.
10328 (record_buffer): Inhibit quitting and rewrite using quittable
10329 functions. Run Qbuffer_list_update_hook if allowed.
10330 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10331 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10332 Move switch-to-buffer to window.el.
9397e56f
MR
10333 (bury-buffer): Move to window.el.
10334 (Vbuffer_list_update_hook): New variable.
10335
10336 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10337 section.
10338
10339 * window.h (resize_frame_windows): Move up in code.
10340 (Fwindow_frame): Remove EXFUN.
10341 (replace_buffer_in_all_windows): Remove prototype.
10342 (replace_buffer_in_windows_safely): Add prototype.
10343
10344 * window.c: Declare Qdelete_window static again. Move down
10345 declaration of select_count.
10346 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10347 (Fother_window): Move to window.el.
10348 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10349 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10350 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10351 window.el.
10352 (replace_buffer_in_windows): Implement by calling
10353 Qreplace_buffer_in_windows.
10354 (replace_buffer_in_all_windows): Remove with some functionality
10355 moved into replace_buffer_in_windows_safely.
10356 (replace_buffer_in_windows_safely): New function.
10357 (select_window_norecord, select_frame_norecord): Move in front
10358 of run_window_configuration_change_hook. Remove now obsolete
10359 declarations.
640c8776
SM
10360 (Fset_window_buffer): Rewrite doc-string.
10361 Call Qrecord_window_buffer.
9397e56f
MR
10362 (keys_of_window): Move binding for other-window to window.el.
10363
b50691aa
CY
103642011-06-11 Chong Yidong <cyd@stupidchicken.com>
10365
10366 * dispextern.h (struct image): Replace data member, whose int_val
10367 and ptr_val fields were not used by anything, with a single
10368 lisp_val object.
10369
10370 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10371 (gif_clear_image, gif_load, imagemagick_load_image)
10372 (gs_clear_image, gs_load): Callers changed.
10373
3f754b86
PE
103742011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10375
cca69397
PE
10376 * buffer.h: Include <time.h>, for time_t.
10377 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10378
109e28d0
PE
10379 Fix minor problems found by static checking.
10380
60737f02
PE
10381 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10382
4b66faf3
PE
10383 Make identifiers static if they are not used in other modules.
10384 * data.c (Qcompiled_function, Qframe, Qvector):
10385 * image.c (QimageMagick, Qsvg):
10386 * minibuf.c (Qmetadata):
10387 * window.c (resize_window_check, resize_root_window): Now static.
10388 * window.h (resize_window_check, resize_root_window): Remove decls.
10389
109e28d0
PE
10390 * window.c (window_deletion_count, delete_deletable_window):
10391 Remove; unused.
46a4ce9e
PE
10392 (window_body_lines): Now static.
10393 (Fdelete_other_windows_internal): Mark vars as initialized.
10394 Make sure 'resize_failed' is initialized.
10395 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10396 (resize_window_apply): Remove unused local.
10397 * window.h (delete_deletable_window): Remove decl.
10398
109e28d0 10399 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10400 (imagemagick_load_image): Fix pointer signedness problem by changing
10401 last arg from unsigned char * to char *. All uses changed.
10402 Also, fix a local for similar reasons.
10403 Remove unused locals. Remove locals to avoid shadowing.
10404 (fn_rsvg_handle_free): Remove; unused.
10405 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10406 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10407
3f754b86
PE
10408 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10409
2547adb1
CY
104102011-06-10 Chong Yidong <cyd@stupidchicken.com>
10411
10412 * image.c (gif_load): Fix omitted cast error introduced by
10413 2011-06-06 change.
10414
2c8e37d4
MR
104152011-06-10 Martin Rudalics <rudalics@gmx.at>
10416
10417 * window.h (resize_proportionally, orig_total_lines)
10418 (orig_top_line): Remove from window structure.
10419 (set_window_height, set_window_width, change_window_heights)
10420 (Fdelete_window): Remove prototypes.
10421 (resize_frame_windows): Remove duplicate declaration.
10422
440a42e3
EZ
104232011-06-10 Eli Zaretskii <eliz@gnu.org>
10424
10425 * window.h (resize_frame_windows, resize_window_check)
10426 (delete_deletable_window, resize_root_window)
10427 (resize_frame_windows): Declare prototypes.
10428
10429 * window.c (resize_window_apply): Make definition be "static" to
10430 match the prototype.
10431
562dd5e9
MR
104322011-06-10 Martin Rudalics <rudalics@gmx.at>
10433
10434 * window.c: Remove declarations of Qwindow_size_fixed,
10435 window_min_size_1, window_min_size_2, window_min_size,
10436 size_window, window_fixed_size_p, enlarge_window, delete_window.
10437 Remove static from declaration of Qdelete_window, it's
10438 temporarily needed by Fbury_buffer.
10439 (replace_window): Don't assign orig_top_line and
10440 orig_total_lines.
10441 (Fdelete_window, delete_window): Remove. Window deletion is
10442 handled by window.el.
640c8776
SM
10443 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10444 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10445 (Fdelete_other_windows): Remove. Deleting other windows is
10446 handled by window.el.
10447 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10448 handled in window.el.
10449 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10450 Window minimum sizes are handled in window.el.
10451 (shrink_windows, size_window, set_window_height)
10452 (set_window_width, change_window_heights, window_height)
10453 (window_width, CURBEG, CURSIZE, enlarge_window)
10454 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10455 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10456 handled in window.el.
10457 (make_dummy_parent): Rename to make_parent_window and give it a
10458 second argument horflag.
10459 (make_window): Don't set resize_proportionally any more.
10460 (Fsplit_window): Remove. Windows are split in window.el.
10461 (save_restore_action, save_restore_orig_size)
10462 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10463 Resize mini windows in window.el.
10464 (grow_mini_window, shrink_mini_window): Implement by calling
10465 Qresize_root_window_vertically, resize_window_check and
10466 resize_window_apply.
640c8776
SM
10467 (saved_window, Fset_window_configuration, save_window_save):
10468 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10469 resize_proportionally.
10470 (window_min_height, window_min_width): Move to window.el.
10471 (keys_of_window): Move bindings for delete-other-windows,
10472 split-window, delete-window and enlarge-window to window.el.
10473
10474 * buffer.c: Temporarily extern Qdelete_window.
10475 (Fbury_buffer): Temporarily call Qdelete_window instead of
10476 Fdelete_window (Fbury_buffer will move to window.el soon).
10477
10478 * frame.c (set_menu_bar_lines_1): Remove code handling
10479 orig_top_line and orig_total_lines.
10480
10481 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10482 set_window_height but set heights directly.
10483 (change_frame_size_1): Use resize_frame_windows.
10484
10485 * xdisp.c (init_xdisp): Don't use set_window_height but set
10486 heights directly.
10487
640c8776
SM
10488 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10489 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10490 run_window_configuration_change_hook.
10491
10492 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10493 instead of change_window_heights and run
10494 run_window_configuration_change_hook.
10495
1a13852e
MR
104962011-06-09 Martin Rudalics <rudalics@gmx.at>
10497
10498 * window.c (replace_window): Rename second argument REPLACEMENT to
10499 NEW. New third argument SETFLAG. Rewrite.
10500 (delete_window, make_dummy_parent): Call replace_window with
10501 third argument 1.
10502 (window_list_1): Move down in code.
10503 (run_window_configuration_change_hook): Move set_buffer part
10504 before select_frame_norecord part in order to unwind correctly.
10505 Rename count1 to count.
10506 (recombine_windows, delete_deletable_window, resize_root_window)
10507 (Fdelete_other_windows_internal)
10508 (Frun_window_configuration_change_hook, make_parent_window)
10509 (resize_window_check, resize_window_apply, Fresize_window_apply)
10510 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10511 (Fdelete_window_internal, Fresize_mini_window_internal):
10512 New functions.
1a13852e
MR
10513 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10514
f3d1777e
MR
105152011-06-08 Martin Rudalics <rudalics@gmx.at>
10516
496e208e
MR
10517 * window.h (window): Add some new members to window structure -
10518 normal_lines, normal_cols, new_total, new_normal, clone_number,
10519 splits, nest, prev_buffers, next_buffers.
10520 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10521 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10522
f3d1777e
MR
10523 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10524 Remove.
496e208e
MR
10525 (make_dummy_parent): Set new members of windows structure.
10526 (make_window): Move down in code. Handle new members of window
10527 structure.
10528 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10529 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10530 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10531 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10532 (Fset_window_next_buffers, Fset_window_clone_number):
10533 New functions.
496e208e
MR
10534 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10535 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10536 Doc-string fixes.
10537 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10538 Argument WINDOW can be now internal window too.
10539 (Fwindow_use_time): Move up in code.
10540 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10541 Rewrite doc-string.
10542 (Fset_window_configuration, saved_window)
10543 (Fcurrent_window_configuration, save_window_save): Handle new
10544 members of window structure.
b9e809c2
MR
10545 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10546 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10547 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10548 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10549 Qget_mru_window, Qresize_root_window,
10550 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10551 Qauto_buffer_name; staticpro them.
f3d1777e 10552
abde8f8c
MR
105532011-06-07 Martin Rudalics <rudalics@gmx.at>
10554
10555 * window.c (Fwindow_total_size, Fwindow_left_column)
10556 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10557 (Fwindow_list_1): New functions.
10558 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10559 (Fwindow_width, Fscroll_left, Fscroll_right):
10560 Use window_body_cols instead of window_box_text_cols.
10561 (delete_window, Fset_window_configuration):
10562 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10563 (delete_all_subwindows): Take a window as argument and not a
10564 structure. Rewrite.
190b47e6
MR
10565 (window_loop): Remove handling of GET_LRU_WINDOW and
10566 GET_LARGEST_WINDOW.
10567 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10568
10569 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10570 window_box_text_cols. delete_all_subwindows now takes a
10571 Lisp_Object as argument.
abde8f8c 10572
640c8776
SM
10573 * indent.c (compute_motion, Fcompute_motion):
10574 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10575
fa8a67e6
MR
10576 * frame.c (delete_frame): Call delete_all_subwindows with root
10577 window as argument.
10578
a54e3482
DC
105792011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10580
10581 * fns.c (Fputhash): Document return value.
10582
60002bf5
CY
105832011-06-06 Chong Yidong <cyd@stupidchicken.com>
10584
10585 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10586
0c671da6 105872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10588
b862a52a 10589 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10590
be44ca6c
PE
10591 Check for overflow when converting integer to cons and back.
10592 * charset.c (Fdefine_charset_internal, Fdecode_char):
10593 Use cons_to_unsigned to catch overflow.
10594 (Fencode_char): Use INTEGER_TO_CONS.
10595 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10596 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10597 * data.c (long_to_cons, cons_to_long): Remove.
10598 (cons_to_unsigned, cons_to_signed): New functions.
10599 These signal an error for invalid or out-of-range values.
10600 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10601 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10602 * font.c (Ffont_variation_glyphs):
10603 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10604 * lisp.h: Include <intprops.h>.
10605 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10606 (cons_to_signed, cons_to_unsigned): New decls.
10607 (long_to_cons, cons_to_long): Remove decls.
10608 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10609 (Fprimitive_undo): Use CONS_TO_INTEGER.
10610 * xfns.c (Fx_window_property): Likewise.
10611 * xselect.c: Include <limits.h>.
10612 (x_own_selection, selection_data_to_lisp_data):
10613 Use INTEGER_TO_CONS.
10614 (x_handle_selection_request, x_handle_selection_clear)
10615 (x_get_foreign_selection, Fx_disown_selection_internal)
10616 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10617 (lisp_data_to_selection_data): Use cons_to_unsigned.
10618 (x_fill_property_data): Use cons_to_signed.
10619 Report values out of range.
10620
d1f3d2af
PE
10621 Check for buffer and string overflow more precisely.
10622 * buffer.h (BUF_BYTES_MAX): New macro.
10623 * lisp.h (STRING_BYTES_MAX): New macro.
10624 * alloc.c (Fmake_string):
10625 * character.c (string_escape_byte8):
10626 * coding.c (coding_alloc_by_realloc):
10627 * doprnt.c (doprnt):
10628 * editfns.c (Fformat):
10629 * eval.c (verror):
10630 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10631 since they may not be the same number.
10632 * editfns.c (Finsert_char):
10633 * fileio.c (Finsert_file_contents):
10634 Likewise for BUF_BYTES_MAX.
10635
dd52fcea
PE
10636 * image.c: Use ptrdiff_t, not int, for sizes.
10637 (slurp_file): Switch from int to ptrdiff_t.
10638 All uses changed.
10639 (slurp_file): Check that file size fits in both size_t (for
10640 malloc) and ptrdiff_t (for sanity and safety).
10641
7f9bbdbb
PE
10642 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10643 if b->modtime has its maximal value.
10644
dfe18f82
PE
10645 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10646
84acfcf0
PE
10647 Don't assume time_t can fit into int.
10648 * buffer.h (struct buffer.modtime): Now time_t, not int.
10649 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10650 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10651
ccd9a01a
PE
10652 Minor fixes for signed vs unsigned integers.
10653 * character.h (MAYBE_UNIFY_CHAR):
10654 * charset.c (maybe_unify_char):
10655 * keyboard.c (read_char, reorder_modifiers):
10656 XINT -> XFASTINT, since the integer must be nonnegative.
10657 * ftfont.c (ftfont_spec_pattern):
10658 * keymap.c (access_keymap, silly_event_symbol_error):
10659 XUINT -> XFASTINT, since the integer must be nonnegative.
10660 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10661 since it makes no difference and we prefer signed.
10662 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10663 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10664 nonnegative.
10665
d6d100dd
SM
106662011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10667
10668 * window.h (Fwindow_frame): Declare.
10669
2b6148e4
PE
106702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10671
10672 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10673 (SPARE_MEMORY): Always define.
10674 (LARGE_REQUEST): Remove.
10675 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10676
f230ecc9
MR
106772011-06-06 Martin Rudalics <rudalics@gmx.at>
10678
727e958e
MR
10679 * lisp.h: Move EXFUNS for Fframe_root_window,
10680 Fframe_first_window and Fset_frame_selected_window to window.h.
10681
10682 * window.h: Move EXFUNS for Fframe_root_window,
10683 Fframe_first_window and Fset_frame_selected_window here from
10684 lisp.h.
10685
10686 * frame.c (Fwindow_frame, Fframe_first_window)
10687 (Fframe_root_window, Fframe_selected_window)
10688 (Fset_frame_selected_window): Move to window.c.
10689 (Factive_minibuffer_window): Move to minibuf.c.
10690 (Fother_visible_frames_p): New function.
10691
10692 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10693
f230ecc9
MR
10694 * window.c (decode_window, decode_any_window): Move up in code.
10695 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10696 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10697 (Fwindow_buffer): Move up and rewrite doc-string.
10698 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10699 (Fwindow_prev): New functions.
727e958e
MR
10700 (Fwindow_frame): Move here from frame.c. Accept any window as
10701 argument.
10702 (Fframe_root_window, Fframe_first_window)
10703 (Fframe_selected_window): Move here from frame.c. Accept frame
10704 or arbitrary window as argument. Update doc-strings.
10705 (Fminibuffer_window): Move up in code.
10706 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10707 (Fset_frame_selected_window): Move here from frame.c.
10708 Marginal rewrite.
727e958e
MR
10709 (Fselected_window, select_window, Fselect_window): Move up in
10710 code. Minor doc-string fixes.
f230ecc9 10711
4d09bcf6
PE
107122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10713
10714 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10715 Do not assume that spare memory exists; that assumption is valid
10716 only if SYSTEM_MALLOC.
10717 (LARGE_REQUEST): New macro, so that the issue of large requests
10718 is separated from the issue of spare memory.
10719
810928a2
AS
107202011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10721
172418ad
AS
10722 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10723 format. (Bug#8806)
10724
43f862f7
AS
10725 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10726
810928a2
AS
10727 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10728 before statements.
10729
a059fe24
JD
107302011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10731
10732 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10733
10734 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10735
10736 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10737 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10738
989bf368
JB
107392011-06-05 Juanma Barranquero <lekktu@gmail.com>
10740
10741 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10742
4b80f674
CY
107432011-06-04 Chong Yidong <cyd@stupidchicken.com>
10744
10745 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10746 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10747 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10748 New error handlers.
4b80f674
CY
10749 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10750 Obey Vx_select_enable_clipboard_manager. Catch errors in
10751 x_clipboard_manager_save (Bug#8779).
10752 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10753 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10754
99a33b77 107552011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10756
10757 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10758
99a33b77 107592011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10760
10761 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10762 in the current matrix if keep_current_p is non-zero.
10763
8264569d
EZ
107642011-06-04 Eli Zaretskii <eliz@gnu.org>
10765
10766 * bidi.c (bidi_level_of_next_char): Fix last change.
10767
57f97249
EZ
107682011-06-03 Eli Zaretskii <eliz@gnu.org>
10769
fec2107c 10770 Support bidi reordering of text covered by display properties.
57f97249 10771
fec2107c
EZ
10772 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10773 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10774 (bidi_cache_search, bidi_cache_iterator_state)
10775 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10776 (bidi_level_of_next_char, bidi_move_to_visually_next):
10777 Support character positions inside a run of characters covered by a
fec2107c
EZ
10778 display string.
10779 (bidi_paragraph_init, bidi_resolve_explicit_1)
10780 (bidi_level_of_next_char): Call bidi_fetch_char and
10781 bidi_fetch_char_advance instead of FETCH_CHAR and
10782 FETCH_CHAR_ADVANCE.
10783 (bidi_init_it): Initialize new members.
10784 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10785 definitions.
10786 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10787 instead of using explicit *_CHAR codes.
d6d100dd
SM
10788 (bidi_resolve_explicit, bidi_resolve_weak):
10789 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10790 bidirectional text is supported only in multibyte buffers.
10791 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10792 it to initialize the frame_window_p member of struct bidi_it.
10793 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10794 (bidi_resolve_explicit, bidi_resolve_weak)
10795 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10796 bidi_it->nchars is non-positive.
10797 (bidi_level_of_next_char): Don't try to lookup the cache for the
10798 next/previous character if nothing is cached there yet, or if we
10799 were just reseat()'ed to a new position.
c40e2fb2 10800
0e14fe90
EZ
10801 * xdisp.c (set_cursor_from_row): Set start and stop points
10802 according to the row's direction when priming the loop that looks
10803 for the glyph on which to display cursor.
10804 (single_display_spec_intangible_p): Function deleted.
10805 (display_prop_intangible_p): Reimplement to call
10806 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10807 Accept 3 additional arguments needed by handle_display_spec.
10808 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10809 values: lists, `(when COND...)' forms, etc.
10810 (single_display_spec_string_p): Support property values that are
10811 lists with the argument STRING its top-level element.
10812 (display_prop_string_p): Fix the condition for processing a
10813 property that is a list to be consistent with handle_display_spec.
fec2107c 10814 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10815 last portion of handle_display_prop.
10816 (compute_display_string_pos): Accept additional argument
10817 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10818 value of a `display' property is a "replacing spec".
10819 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10820 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10821 the display property, but just return a value indicating whether
10822 the display property will replace the characters it covers.
10823 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10824 frame_window_p members of struct bidi_it.
d6d100dd
SM
10825 (compute_display_string_pos, compute_display_string_end):
10826 New functions.
fec2107c
EZ
10827 (push_it): Accept second argument POSITION, where pop_it should
10828 jump to continue iteration.
10829 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10830
fec2107c
EZ
10831 * keyboard.c (adjust_point_for_property): Adjust the call to
10832 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10833
10834 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10835 (bidi_init_it): Update prototypes.
10836 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10837 (compute_display_string_pos, compute_display_string_end):
10838 Declare prototypes.
fec2107c
EZ
10839 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10840 EMACS_INT.
fc6f18ce 10841
40087514 108422011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10843
57f53182
PE
10844 Malloc failure behavior now depends on size of allocation.
10845 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10846 * lisp.h: Change signatures accordingly.
10847 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10848 All callers changed. (Bug#8762)
10849
10850 * gnutls.c: Use Emacs's memory allocators.
10851 Without this change, the gnutls library would invoke malloc etc.
10852 directly, which causes problems on non-SYNC_INPUT hosts, and which
10853 runs afoul of improving memory_full behavior. (Bug#8761)
10854 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10855 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10856 xfree instead of the default malloc, realloc, free.
10857 (Fgnutls_boot): No need to check for memory allocation failure,
10858 since xmalloc does that for us.
10859
ac32cd99 10860 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10861 * category.c (hash_get_category_set):
10862 * ccl.c (ccl_driver):
10863 * charset.c (Fdefine_charset_internal):
10864 * charset.h (struct charset.hash_index):
10865 * composite.c (get_composition_id, gstring_lookup_cache)
10866 (composition_gstring_put_cache):
10867 * composite.h (struct composition.hash_index):
10868 * dispextern.h (struct image.hash):
10869 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10870 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10871 (hashfn_equal, hashfn_user_defined, make_hash_table)
10872 (maybe_resize_hash_table, hash_lookup, hash_put)
10873 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10874 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10875 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10876 * image.c (make_image, search_image_cache, lookup_image)
10877 (xpm_put_color_table_h):
10878 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10879 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10880 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10881 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10882 * alloc.c (allocate_vectorlike):
10883 Check for overflow in vector size calculations.
10884 * ccl.c (ccl_driver):
10885 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10886 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10887 need to be updated by these changes.
40087514
PE
10888 * fns.c (make_hash_table, maybe_resize_hash_table):
10889 Check for integer overflow with large hash tables.
0de4bb68
PE
10890 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10891 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10892 (SXHASH_REDUCE): New macro.
10893 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10894 Use it instead of discarding useful hash info with large hash values.
10895 (sxhash_float): New function.
10896 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10897 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10898 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10899 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10900 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10901 Adjust signatures to match updated version of code.
10902 (consing_since_gc): Now EMACS_INT, since a single hash table can
10903 use more than INT_MAX bytes.
10904
698d32e2
DN
109052011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10906
10907 Make it possible to build with GCC-4.6+ -O2 -flto.
10908
10909 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10910
fd6fa53f
SM
109112011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10912
10913 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10914 Call minibuffer-inactive-mode.
10915
864db017
JB
109162011-05-31 Juanma Barranquero <lekktu@gmail.com>
10917
10918 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10919 Update dependencies.
10920
2ad0baf4
DN
109212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10922
10923 * data.c (init_data): Remove code for UTS, this system is not
10924 supported anymore.
10925
4fcc2638
DN
109262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10927
10928 Don't force ./temacs to start in terminal mode.
10929
10930 * frame.c (make_initial_frame): Initialize faces in all cases, not
10931 only when CANNOT_DUMP is defined.
10932 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10933
c56e0fd5
DN
109342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10935
10936 * dispnew.c (add_window_display_history): Use const for the string
10937 pointer. Remove declaration, not needed.
10938
333d54da 109392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10940
55d4c1b2 10941 Use 'inline', not 'INLINE'.
333d54da 10942 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10943 * alloc.c, fontset.c (INLINE): Remove.
10944 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10945 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10946 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10947 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10948 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10949
738db178
DN
109502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10951
10952 Make it possible to run ./temacs.
10953
10954 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10955 syms_of_callproc does the same thing. Remove test for
10956 "initialized", do it in the caller.
10957 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10958
620c53a6
SM
109592011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10960
10961 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10962 (read_minibuf): Use get_minibuffer.
10963 (syms_of_minibuf): Use DEFSYM.
10964 (Qmetadata): New var.
10965 * data.c (Qbuffer): Don't make it static.
10966 (syms_of_data): Use DEFSYM.
10967
e003a292
PE
109682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10969
10970 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10971 (CCL_CODE_MIN): New macro.
10972
ed008a6d
PE
109732011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10974
3687c2ef
PE
10975 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10976
ed008a6d
PE
10977 * eval.c (Qdebug): Now static.
10978 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10979 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10980 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10981
d66c4c7c
CY
109822011-05-29 Chong Yidong <cyd@stupidchicken.com>
10983
10984 * image.c: Various fixes to ImageMagick code comments.
10985 (Fimagemagick_types): Doc fix.
10986
5fbc2025
PE
109872011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10988
0196f88a
PE
10989 Minor fixes prompted by GCC 4.6.0 warnings.
10990
10991 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10992
5fbc2025
PE
10993 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10994 (x_clipboard_manager_save_all): Move extern decl to ...
10995 * xterm.h: ... here, so that it can be checked for consistency.
10996
1dd3c2d9
CY
109972011-05-29 Chong Yidong <cyd@stupidchicken.com>
10998
10999 * xselect.c (x_clipboard_manager_save_frame)
11000 (x_clipboard_manager_save_all): New functions.
11001 (Fx_clipboard_manager_save): Lisp function deleted.
11002
11003 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11004 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11005
11006 * xterm.h: Update prototype.
11007
5ba6571d
WX
110082011-05-28 William Xu <william.xwl@gmail.com>
11009
11010 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11011 exiting (Bug#8239).
11012
3eaff834
JM
110132011-05-28 Jim Meyering <meyering@redhat.com>
11014
e1900994 11015 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11016 * fns.c (to_uchar): Define.
11017 (crypto_hash_function): Use it to convert some newly-signed
11018 variables to unsigned, to avoid sign-extension bugs. For example,
11019 without this change, (md5 "truc") would evaluate to
11020 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11021 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11022 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11023
0f6990a7
PE
110242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11025
11026 Integer overflow fixes.
c8a9ca5a 11027
08686060
PE
11028 * dbusbind.c: Serial number integer overflow fixes.
11029 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11030 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11031 to hold a serial number that is too large for a fixnum.
11032 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11033 Check for serial numbers out of range. Decode any serial number
59568bf0 11034 that was so large that it became a float. (Bug#8722)
08686060 11035
2d1fc3c7
PE
11036 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11037 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11038 Use XFASTINT rather than XUINT when numbers are nonnegative.
11039 (xd_append_arg, Fdbus_method_return_internal):
11040 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11041 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11042 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11043 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11044 (Bug#8722)
2d1fc3c7 11045
c8a9ca5a
PE
11046 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11047
519e1d69
PE
11048 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11049
6df6ae42 11050 ccl: Add integer overflow checks.
30569699
PE
11051 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11052 (IN_INT_RANGE): New macros.
11053 (ccl_driver): Use them to check for integer overflow when
11054 decoding a CCL program. Many of the new checks are whether XINT (x)
11055 fits in int; it doesn't always, on 64-bit hosts. The new version
11056 doesn't catch all possible integer overflows, but it's an
847044ea 11057 improvement. (Bug#8719)
30569699 11058
c11285dc
PE
11059 * alloc.c (make_event_array): Use XINT, not XUINT.
11060 There's no need for unsigned here.
11061
fdccd48e
PE
11062 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11063 This follows up to the 2011-05-06 change that substituted uintptr_t
11064 for EMACS_INT. This case wasn't caught back then.
11065
37910ab2
PE
11066 Rework Fformat to avoid integer overflow issues.
11067 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11068 now (part of C89). Include <verify.h>.
11069 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11070 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11071 (Fformat): Avoid the prepass trying to compute sizes; it was only
11072 approximate and thus did not catch overflow reliably. Instead, walk
11073 through the format just once, formatting and computing sizes as we go,
11074 checking for integer overflow at every step, and allocating a larger
11075 buffer as needed. Keep track separately whether the format is
11076 multibyte. Keep only the most-recently calculated precision, rather
11077 than them all. Record whether each argument has been converted to
11078 string. Use EMACS_INT, not int, for byte and char and arg counts.
11079 Support field widths and precisions larger than INT_MAX. Avoid
11080 sprintf's undefined behavior with conversion specifications such as %#d
11081 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11082 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11083 formatting out-of-range floating point numbers with int
9173deec 11084 formats. (Bug#8668)
37910ab2 11085
2e6578fb
PE
11086 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11087
0ae6bdee
PE
11088 * data.c: Avoid integer truncation in expressions involving floats.
11089 * data.c: Include <intprops.h>.
11090 (arith_driver): When there's an integer overflow in an expression
11091 involving floating point, convert the integers to floating point
11092 so that the resulting value does not suffer from catastrophic
11093 integer truncation. For example, on a 64-bit host (* 4
11094 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11095 Do not rely on undefined behavior after integer overflow.
11096
de883a70
PE
11097 merge count_size_as_multibyte, parse_str_to_multibyte
11098 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11099 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11100 Check for integer overflow.
11101 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11102 since it's now a duplicate of the other. This is more of
11103 a character than a buffer op, so better that it's in character.c.
11104 * fns.c, print.c: Adjust to above changes.
11105
2ff916cb
PE
111062011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11107
11108 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11109
f1b54466
PE
111102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11111
fb1ac845
PE
11112 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11113 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11114 (x_clipboard_manager_save): Now static.
11115 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11116
f1b54466
PE
11117 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11118 (crypto_hash_function): Now static.
11119 Fix pointer signedness problems. Avoid unnecessary initializations.
11120
a9f737ee
CY
111212011-05-27 Chong Yidong <cyd@stupidchicken.com>
11122
11123 * termhooks.h (Vselection_alist): Make it terminal-local.
11124
11125 * terminal.c (create_terminal): Initialize it.
11126
11127 * xselect.c: Support for clipboard managers.
11128 (Vselection_alist): Move to termhooks.h as terminal-local var.
11129 (LOCAL_SELECTION): New macro.
11130 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11131 (symbol_to_x_atom): Remove gratuitous arg.
11132 (x_handle_selection_request, lisp_data_to_selection_data)
11133 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11134 (x_own_selection, x_get_local_selection, x_convert_selection):
11135 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11136 (some_frame_on_display): Delete unused function.
11137 (Fx_own_selection_internal, Fx_get_selection_internal)
11138 (Fx_disown_selection_internal, Fx_selection_owner_p)
11139 (Fx_selection_exists_p): New optional frame arg.
11140 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11141 (x_handle_selection_clear): Don't treat other terminals with the
11142 same keyboard specially. Use the terminal-local Vselection_alist.
11143 (x_clear_frame_selections): Use Frun_hook_with_args.
11144
11145 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11146
11147 * xterm.h: Add support for those atoms.
11148
e067f0c1
CY
111492011-05-26 Chong Yidong <cyd@stupidchicken.com>
11150
11151 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11152 (converted_selections, conversion_fail_tag): New global variables.
11153 (x_selection_request_lisp_error): Free the above.
11154 (x_get_local_selection): Remove unnecessary code.
11155 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11156 of converted selections stored in converted_selections.
11157 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11158 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11159 (x_convert_selection): New function.
11160 (x_handle_selection_event): Simplify.
11161 (x_get_foreign_selection): Don't ignore incoming requests while
11162 waiting for an answer; this will fail when we implement
11163 SAVE_TARGETS, and seems unnecessary anyway.
11164 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11165 (Vx_sent_selection_functions): Doc fix.
11166
0f4aebc0
LL
111672011-05-26 Leo Liu <sdl.web@gmail.com>
11168
11169 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11170
e61124cd
YM
111712011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11172
11173 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11174
11175 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11176 for fringe update if it has periodic bitmap.
ac389d0c 11177 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11178 and fringe_bitmap_periodic_p.
11179
11180 * fringe.c (get_fringe_bitmap_data): New function.
11181 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11182 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11183 row. Mark glyph row for fringe update if periodicity changed.
11184
11185 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11186 for fringe update unless it has periodic bitmap.
11187
f16d9837
KH
111882011-05-25 Kenichi Handa <handa@m17n.org>
11189
11190 * xdisp.c (get_next_display_element): Set correct it->face_id for
11191 a static composition.
11192
e1b90ef6
LL
111932011-05-24 Leo Liu <sdl.web@gmail.com>
11194
11195 * deps.mk (fns.o):
11196 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11197
11198 * fns.c (crypto_hash_function, Fsha1): New function.
11199 (Fmd5): Use crypto_hash_function.
11200 (syms_of_fns): Add Ssha1.
11201
7400048f
PE
112022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11203
11204 * gnutls.c: Remove unused macros.
11205 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11206 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11207 Remove macros that are defined and never used.
11208 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11209
abb71cf4
CY
112102011-05-22 Chong Yidong <cyd@stupidchicken.com>
11211
11212 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11213 (Fx_get_selection_internal): Minor cleanup.
11214 (Fx_own_selection_internal): Rename arguments for consistency with
11215 select.el.
11216
6307db39
PE
112172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11218
11219 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11220
f3d4e0a4
CY
112212011-05-22 Chong Yidong <cyd@stupidchicken.com>
11222
11223 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11224
4d8ade89
YM
112252011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11226
11227 * dispnew.c (scrolling_window): Don't exclude the case that the
11228 last enabled row in the desired matrix touches the bottom boundary.
11229
32078c8d
GM
112302011-05-21 Glenn Morris <rgm@gnu.org>
11231
11232 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11233 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11234 and add some more files.
32078c8d 11235
7285dc67
EZ
112362011-05-20 Eli Zaretskii <eliz@gnu.org>
11237
11238 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11239 report_file_error introduced by the change from 2011-05-07.
11240
89d1bd22
PE
112412011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11242
11243 * systime.h (Time): Define only if emacs is defined.
11244 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11245 where the include path doesn't have X11/X.h by default. See
11246 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11247
cd394be1 112482011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11249
11250 * composite.c (find_automatic_composition): Fix previous change.
11251
b9704ad9
GM
112522011-05-20 Glenn Morris <rgm@gnu.org>
11253
11254 * lisp.mk: New file, split from Makefile.in.
11255 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11256 (shortlisp): Remove.
11257 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11258
4a720484
GM
112592011-05-19 Glenn Morris <rgm@gnu.org>
11260
11261 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11262 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11263 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11264 (lisp): Set the order to that of loadup.el.
11265 (shortlisp): Make it a copy of $lisp.
11266 (SOME_MACHINE_LISP): Remove.
11267 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11268 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11269
a28d4396
KH
112702011-05-18 Kenichi Handa <handa@m17n.org>
11271
11272 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11273 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11274 (find_automatic_composition): Mostly rewrite for efficiency.
11275
a2b1fa8e
JB
112762011-05-18 Juanma Barranquero <lekktu@gmail.com>
11277
11278 * makefile.w32-in: Update dependencies.
11279
8e1f5610
CS
112802011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11281
11282 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11283 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11284
7025ee00 112852011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11286
cdfa6eab
PE
11287 Fix some integer overflow issues, such as string length overflow.
11288
06d6db33
PE
11289 * insdel.c (count_size_as_multibyte): Check for string overflow.
11290
2b4560a8
PE
11291 * character.c (lisp_string_width): Check for string overflow.
11292 Use EMACS_INT, not int, for string indexes and lengths; in
11293 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11294 the resulting string length overflows an EMACS_INT; instead,
11295 report a string overflow if no precision given. When checking for
11296 precision exhaustion, use a check that cannot possibly have
11297 integer overflow. (Bug#8675)
11298 * character.h (lisp_string_width): Adjust to new signature.
11299
cb93f9be
PE
11300 * alloc.c (string_overflow): New function.
11301 (Fmake_string): Use it. This doesn't change behavior, but saves
11302 a few bytes and will simplify future changes.
11303 * character.c (string_escape_byte8): Likewise.
11304 * lisp.h (string_overflow): New decl.
11305
1a1f3366
PE
11306 Fixups, following up to the user-interface timestamp change.
11307 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11308 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11309 * msdos.c (mouse_get_pos): Likewise.
11310 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11311 * w32gui.h (Time): Define by including "systime.h" rather than by
11312 declaring it ourselves. (Bug#8664)
11313
d4e3e4d3
PE
11314 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11315 * image.c (clear_image_cache): Likewise.
11316
f6a24d19
PE
11317 * term.c (term_mouse_position): Don't assume time_t wraparound.
11318
08dc5ae6
PE
11319 Be more systematic about user-interface timestamps.
11320 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11321 and sometimes 'EMACS_UINT', to represent these timestamps.
11322 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11323 This makes the code easier to follow, and makes it easier to catch
11324 integer overflow bugs such as Bug#8664.
11325 * frame.c (Fmouse_position, Fmouse_pixel_position):
11326 Use Time, not unsigned long, for user-interface timestamps.
11327 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11328 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11329 * keyboard.h (last_event_timestamp): Likewise.
11330 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11331 * menu.h (xmenu_show): Likewise.
11332 * term.c (term_mouse_position): Likewise.
11333 * termhooks.h (struct input_event.timestamp): Likewise.
11334 (struct terminal.mouse_position_hook): Likewise.
11335 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11336 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11337 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11338 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11339 what it was before.
11340 * menu.h, termhooks.h: Include "systime.h", for Time.
11341
8e55734a
PE
11342 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11343 Don't assume that the difference between two unsigned long values
11344 can fit into an integer. At this point, we know button_down_time
11345 <= event->timestamp, so the difference must be nonnegative, so
11346 there's no need to cast the result if double-click-time is
11347 nonnegative, as it should be; check that it's nonnegative, just in
11348 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11349 apart (about 25 days). (Bug#8664)
8e55734a 11350
841f1b75 11351 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11352 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11353
3e26f69c
PE
11354 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11355 that always fit in int. Use a sentinel instead of a counter, to
11356 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11357 * frame.h (struct frame): Use int for menu_bar_items_used
11358 instead of EMACS_INT, since it always fits in int.
3e26f69c 11359
5cc152c0
PE
11360 * menu.c (grow_menu_items): Check for int overflow.
11361
d89eb65e
PE
11362 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11363
5235bd3e
PE
11364 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11365 Before, the code was not consistent. These values cannot exceed
11366 2**31 - 1 so there's no need to make them unsigned.
11367 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11368 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11369 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11370 as modifiers.
11371 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11372
bc827e23
PE
11373 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11374 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11375 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11376 presumably because the widths might not match.
11377
78eb494e
PE
11378 * window.c (size_window): Avoid needless test at loop start.
11379
04f2d78b
CB
113802011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11381
11382 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11383
d2fc7e3d 113842011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11385
11386 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11387
d2fc7e3d 113882011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11389
11390 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11391 `width' to `bar_area_x' and `bar_area_width', respectively.
11392 (x_scroll_run): Take account of fringe background extension.
11393
04f2d78b
CB
11394 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11395 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11396 `bar_area_width', respectively.
11397 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11398 background extension.
11399
79b70037
GM
114002011-05-10 Jim Meyering <meyering@redhat.com>
11401
11402 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11403
2f142cc5
JB
114042011-05-10 Juanma Barranquero <lekktu@gmail.com>
11405
11406 * image.c (Finit_image_library): Return t for built-in image types,
11407 like pbm and xbm. (Bug#8640)
11408
57679c86
AS
114092011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11410
11411 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11412
888c9e86
EZ
114132011-05-07 Eli Zaretskii <eliz@gnu.org>
11414
b0512a1d
EZ
11415 * w32console.c (Fset_screen_color): Doc fix.
11416 (Fget_screen_color): New function.
11417 (syms_of_ntterm): Defsubr it.
11418
7285dc67
EZ
11419 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11420 unlink the temporary file if Fcall_process didn't create it in the
11421 first place.
11422 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11423 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11424 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11425 cue to call_process_cleanup not to close that handle.
11426
4d3fcc8e
BK
114272011-05-07 Ben Key <bkey76@gmail.com>
11428
11429 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11430 one of two shell specific rules, either bootstrap-temacs-CMD or
11431 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11432 to the previous implementation of the bootstrap-temacs rule.
11433 The bootstrap-temacs-CMD rule is similar to the previous
11434 implementation of the bootstrap-temacs rule except that it
11435 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11436 variable.
11437
11438 These changes, along with some changes to nt/configure.bat,
11439 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11440 earlier fix to add support for --cflags and --ldflags options
11441 that include quotes so that it works whether make uses cmd or
11442 sh as the shell.
11443
b4289b64
MA
114442011-05-06 Michael Albinus <michael.albinus@gmx.de>
11445
11446 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11447 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11448 is a constant.
11449 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11450 a string. Handle both cases.
11451 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11452 (Fdbus_register_method): Use Qinvalid_function.
11453
af4c0e28
JB
114542011-05-06 Juanma Barranquero <lekktu@gmail.com>
11455
11456 * makefile.w32-in: Update dependencies.
11457 (LISP_H): Add inttypes.h and stdin.h.
11458 (PROCESS_H): Add unistd.h.
11459
c51453d9
EZ
114602011-05-06 Eli Zaretskii <eliz@gnu.org>
11461
11462 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11463 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11464
8ff0ac3c 114652011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11466
4c4b566b
PE
11467 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11468
aab2b9b5
PE
11469 * term.c (vfatal): Remove stray call to va_end.
11470 It's not needed and the C Standard doesn't allow it here anyway.
11471
c378da0b
PE
11472 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11473 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11474
288b08c7
PE
11475 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11476 bytes.
11477
e3601888
PE
11478 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11479
db6c0e74
PE
11480 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11481
dd5963ea
PE
11482 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11483
88c9450f
PE
11484 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11485
2f9442b8
PE
11486 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11487
c032b5f8
PE
11488 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11489 * charset.c (Fdefine_charset_internal): Don't initialize
11490 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11491 32-bit int (Bug#8600).
a108c10b
PE
11492
11493 * lread.c (read_integer): Be more consistent with string-to-number.
11494 Use string_to_number to do the actual conversion; this avoids
11495 rounding errors and fixes some other screwups. Without this fix,
11496 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11497 (digit_to_number): Move earlier, for benefit of read_integer.
11498 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11499 not a digit in any supported base. (Bug#8602)
a108c10b 11500
ad5f9eea
PE
11501 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11502
aec1708a
PE
11503 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11504 to match comment at start of function. This also removes a
11505 GCC warning about overflow in a 32+64-bit port.
11506
47be4ab5
PE
11507 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11508
371cac43
PE
11509 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11510 Reported by Stefan Monnier in
11511 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11512 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11513 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11514
d01a7826
PE
11515 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11516 (EMACS_UINTPTR): Likewise, with uintptr_t.
11517
7fd47d5c
PE
11518 * lisp.h: Prefer 64-bit EMACS_INT if available.
11519 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11520 on 32-bit hosts that have 64-bit int, so that they can access
11521 large files.
122b0c86
PE
11522 However, temporarily disable this change unless the temporary
11523 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11524
8727937b
PE
11525 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11526
8ac068ac
PE
11527 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11528 This removes an assumption that EMACS_INT and long are the same
11529 width as pointers. The assumption is true for Emacs porting targets
11530 now, but we want to make other targets possible.
11531 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11532 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11533 In the rest of the code, change types of integers that hold casted
11534 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11535 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11536 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11537 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11538 No need to cast type when ORing.
11539 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11540 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11541 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11542 assume EMACS_INT is the same width as char *.
11543 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11544 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11545 Remove no-longer-needed casts.
11546 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11547 (xg_tool_bar_help_callback, xg_make_tool_item):
11548 Use EMACS_INTPTR to hold an integer
11549 that will be cast to void *; this can avoid a GCC warning
11550 if EMACS_INT is not the same width as void *.
11551 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11552 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11553 (current_message_1, set_message_1):
11554 Use a local to convert to proper width without a cast.
11555 * xmenu.c (dialog_selection_callback): Likewise.
11556
ede49d71
PE
11557 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11558 Also, don't assume VALBITS / RAND_BITS is less than 5,
11559 and don't rely on undefined behavior when shifting a 1 left into
11560 the sign bit.
11561 * lisp.h (get_random): Change signature to match.
11562
2f30ecd0
PE
11563 * lread.c (hash_string): Use size_t, not int, for hash computation.
11564 Normally we prefer signed values; but hashing is special, because
11565 it's better to use unsigned division on hash table sizes so that
11566 the remainder is nonnegative. Also, size_t is the natural width
11567 for hashing into memory. The previous code used 'int', which doesn't
11568 retain enough info to hash well into very large tables.
11569 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11570
2a866e7b
PE
11571 * dbusbind.c: Don't possibly lose pointer info when converting.
11572 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11573 Use XPNTR rather than XHASH, so that the high-order bits of
11574 the pointer aren't lost when converting through void *.
11575
51639eac
PE
11576 * eval.c (Fautoload): Don't double-shift a pointer.
11577
92394119
PE
11578 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11579
dbdb9a7c
JB
115802011-05-06 Juanma Barranquero <lekktu@gmail.com>
11581
11582 * gnutls.c (DEF_GNUTLS_FN):
11583 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11584
db7a0b4f
AS
115852011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11586
11587 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11588 marker. (Bug#8610)
11589
cd394be1 115902011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11591
11592 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11593 New version that can reserve upto 2GB of heap space.
11594
f7ff1b0f 115952011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11596
11597 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11598
639c109b
TZ
115992011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11600
11601 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11602 `gnutls_certificate_set_x509_key_file'.
11603
d2127135
JB
116042011-05-05 Juanma Barranquero <lekktu@gmail.com>
11605
11606 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11607 Update dependencies.
11608
e968f4f3
JB
116092011-05-04 Juanma Barranquero <lekktu@gmail.com>
11610
11611 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11612 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11613 Remove unused parameter `fildes'.
11614 * process.c (read_process_output, send_process): Don't pass it.
11615
84d358f0
JB
116162011-05-04 Juanma Barranquero <lekktu@gmail.com>
11617
11618 Fix previous change: the library cache is defined in w32.c.
11619 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11620 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11621
0898ca10
JB
116222011-05-04 Juanma Barranquero <lekktu@gmail.com>
11623
11624 Implement dynamic loading of GnuTLS on Windows.
11625
11626 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11627 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11628 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11629 Declare.
11630
11631 * gnutls.c (Qgnutls_dll): Define.
11632 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11633 (gnutls_*): Declare function pointers.
11634 (init_gnutls_functions): New function to initialize function pointers.
11635 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11636 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11637 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11638 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11639 (emacs_gnutls_write, emacs_gnutls_read)
11640 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11641 (Fgnutls_available_p): New function.
11642 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11643 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11644 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11645
11646 * image.c: Include w32.h.
11647 (Vimage_type_cache): Delete.
11648 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11649 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11650 (w32_delayed_load): Move to w32.c.
11651
11652 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11653
11654 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11655 (w32_delayed_load): Move from image.c. When loading a library, record
11656 its filename in the :loaded-from property of the library id.
11657 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11658 Initialize and staticpro them.
11659 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11660
11661 * process.c: Include lisp.h before w32.h, not after.
11662 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11663 instead of gnutls_record_check_pending.
11664
11665 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11666
ff4de4aa
TZ
116672011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11668
11669 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11670 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11671 as passed in.
11672
abe95abb
JD
116732011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11674
11675 * xterm.c (x_set_frame_alpha): Do not set property on anything
11676 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11677
e16e55d4
JB
116782011-05-02 Juanma Barranquero <lekktu@gmail.com>
11679
11680 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11681
bafcf6a5
JB
116822011-05-02 Juanma Barranquero <lekktu@gmail.com>
11683
11684 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11685 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11686 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11687 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11688 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11689 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11690 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11691 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11692 (Qgnutls_bootprop_callbacks_verify): Make static.
11693
e7a6747f
AS
116942011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11695
19ed11ba
AS
11696 * callproc.c: Indentation fixup.
11697
e7a6747f 11698 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11699 (wait_for_termination, interruptible_wait_for_termination):
11700 Move after wait_for_termination_1.
e7a6747f 11701
1ef14cb4
LMI
117022011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11703
11704 * sysdep.c (interruptible_wait_for_termination): New function
11705 which is like wait_for_termination, but allows keyboard
11706 interruptions.
11707
11708 * callproc.c (Fcall_process): Add (:file "file") as an option for
11709 the STDOUT buffer.
11710 (Fcall_process_region): Ditto.
11711
330d880c
EZ
117122011-04-30 Eli Zaretskii <eliz@gnu.org>
11713
8db90b73
EZ
11714 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11715 rather than `XVECTOR (FOO)->size'.
11716
330d880c
EZ
11717 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11718 inttypes.h, as a gnulib replacement is used if it not available in
11719 system headers.
11720
15cbd324
EZ
117212011-04-21 Eli Zaretskii <eliz@gnu.org>
11722
11723 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11724 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11725 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11726
11727 * coding.c (coding_alloc_by_realloc): Error out if destination
11728 will grow beyond MOST_POSITIVE_FIXNUM.
11729 (decode_coding_emacs_mule): Abort if there isn't enough place in
11730 charbuf for the composition carryover bytes. Reserve an extra
11731 space for up to 2 characters produced in a loop.
11732 (decode_coding_iso_2022): Abort if there isn't enough place in
11733 charbuf for the composition carryover bytes.
11734
117352011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11736
ae940cca
EZ
11737 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11738 aborting when %lld or %lll format is passed.
11739 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11740 %llo or %llx format is passed. (Bug#8545)
11741
03ab8921
EZ
11742 * window.c (window_scroll_line_based): Use a marker instead of
11743 simple variables to record original value of point. (Bug#7952)
11744
afda1437
EZ
11745 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11746 produced by %s or %c overflows available buffer space. (Bug#8545)
11747
f76dee0c
PE
117482011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11749
11750 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11751 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11752
fdc5744d
JB
117532011-04-28 Juanma Barranquero <lekktu@gmail.com>
11754
11755 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11756
638f053a
JB
117572011-04-28 Juanma Barranquero <lekktu@gmail.com>
11758
11759 * keyboard.c (Qdelayed_warnings_hook): Define.
11760 (command_loop_1): Run `delayed-warnings-hook'
11761 if Vdelayed_warnings_list is non-nil.
11762 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11763 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11764
d178f871
EZ
117652011-04-28 Eli Zaretskii <eliz@gnu.org>
11766
11767 * doprnt.c (doprnt): Don't return value smaller than the buffer
11768 size if the message was truncated. (Bug#8545).
11769
b124fd93
JB
117702011-04-28 Juanma Barranquero <lekktu@gmail.com>
11771
11772 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11773 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11774
e810457d
PE
117752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11776
11777 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11778
ea51cceb
JB
117792011-04-27 Juanma Barranquero <lekktu@gmail.com>
11780
11781 * makefile.w32-in: Update dependencies.
11782
94dcfacf
EZ
117832011-04-27 Eli Zaretskii <eliz@gnu.org>
11784
11785 Improve `doprnt' and its usage. (Bug#8545)
11786 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11787 `format_end'. Remove support for %l as a conversion specifier.
11788 Don't use xrealloc. Improve diagnostics when the %l size modifier
11789 is used. Update the commentary.
11790
11791 * eval.c (verror): Simplify calculation of size_t.
11792
11793 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11794 messages.
11795
f61f41d7
PE
117962011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11797
11798 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11799 change.
11800
96fb4434
PE
118012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11802
11803 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11804 This makes this file independent of the recent pseudovector change.
11805
671875da 118062011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11807
69e9b5a3
PE
11808 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11809
b5f869a7 11810 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11811 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11812 Remove unused local.
c8926152 11813 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11814
841a1577 11815 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11816 GCC 4.6.0 optimizes based on type-based alias analysis.
11817 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11818 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11819 != &v->size, and therefore "v->size = 1; b->size = 2; return
11820 v->size;" must therefore return 1. This assumption is incorrect
11821 for Emacs, since it type-puns struct Lisp_Vector * with many other
11822 types. To fix this problem, this patch adds a new type struct
f904488f 11823 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11824 and pseudovectors, and helps optimizing compilers not get fooled
11825 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11826 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11827 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11828 the size member.
eab3844f
PE
11829 (XSETPVECTYPE): Rewrite in terms of new macro.
11830 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11831 This is a bit clearer, and further avoids the possibility of
11832 undesirable aliasing.
11833 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11834 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11835 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11836 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11837 (ASIZE): Now uses header.size rather than size.
11838 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11839 to avoid the hassle of writing XVECTOR (foo)->header.size.
11840 (struct vectorlike_header): New type.
eab3844f
PE
11841 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11842 object, to help avoid aliasing.
11843 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11844 (SUBRP): Likewise, since Lisp_Subr is a special case.
11845 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11846 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11847 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11848 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11849 changed to be "header.size" and "header.next".
11850 * buffer.h (struct buffer): Likewise.
11851 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11852 * frame.h (struct frame): Likewise.
11853 * process.h (struct Lisp_Process): Likewise.
11854 * termhooks.h (struct terminal): Likewise.
11855 * window.c (struct save_window_data, struct saved_window): Likewise.
11856 * window.h (struct window): Likewise.
11857 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11858 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11859 * buffer.c (init_buffer_once): Likewise.
11860 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11861 special case.
11862 * process.c (Fformat_network_address): Use local var for size,
11863 for brevity.
11864
0df1eac5
PE
11865 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11866
847ab9d1 11867 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11868 * data.c (atof): Remove decl; no longer used or needed.
11869 (digit_to_number): Move to lread.c.
11870 (Fstring_to_number): Use new string_to_number function, to be
11871 consistent with how the Lisp reader treats infinities and NaNs.
11872 Do not assume that floating-point numbers represent EMACS_INT
11873 without losing information; this is not true on most 64-bit hosts.
11874 Avoid double-rounding errors, by insisting on integers when
11875 parsing non-base-10 numbers, as the documentation specifies.
11876 * lisp.h (string_to_number): New decl, replacing ...
11877 (isfloat_string): Remove.
bc0a5c13 11878 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11879 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11880 appears to have been a coding error. Similarly, do not accept
11881 strings like +-1e0 as floating point numbers. Do not report
11882 overflow for integer overflows unless the base is not 10 which
11883 means we have no simple and reliable way to continue.
11884 Break out the floating-point parsing into a new
11885 function string_to_number, so that Fstring_to_number parses
11886 floating point numbers consistently with the Lisp reader.
04f2d78b 11887 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11888 (E_CHAR, EXP_INT): Remove, replacing with ...
11889 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11890 (string_to_number): New function, replacing isfloat_string.
11891 This function checks for valid syntax and produces the resulting
11892 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11893 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11894 so that overflow for non-base-10 numbers is reported only when
11895 there's no portable and simple way to convert to floating point.
452f4150 11896
67769ffc
PE
11897 * textprop.c (set_text_properties_1): Rewrite for clarity,
11898 and to avoid GCC warning about integer overflow.
11899
c20db43f
PE
11900 * intervals.h (struct interval): Use EMACS_INT for members
11901 where EMACS_UINT might cause problems. See
11902 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11903 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11904 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11905 All uses changed.
37aa2f85
PE
11906 (offset_intervals): Tell GCC not to worry about length overflow
11907 when negating a negative length.
c20db43f 11908
2538aa2f
PE
11909 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11910 (overrun_check_free): Likewise.
11911
f2d3008d
PE
11912 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11913 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11914 word size.
11915
ec8df744
PE
11916 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11917 (gnutls_make_error): Rename local to avoid shadowing.
11918 (gnutls_emacs_global_deinit): ifdef out; not used.
11919 (Fgnutls_boot): Use const for pointer to readonly storage.
11920 Comment out unused local. Fix pointer signedness problems.
11921
640ee02d
PE
11922 * lread.c (openp): Don't stuff size_t into an 'int'.
11923 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11924 about possible signed overflow.
11925
6048fb2a
PE
11926 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11927 (GDK_KEY_g): Don't define if already defined.
11928 (xg_prepare_tooltip): Avoid pointer signedness problem.
11929 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11930
fa3c87e1
PE
11931 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11932 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11933
2172544b
PE
11934 * xfns.c (Fx_window_property): Simplify a bit,
11935 to make a bit faster and to avoid GCC 4.6.0 warning.
11936 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11937
9b821a21
PE
11938 * fns.c (internal_equal): Don't assume size_t fits in int.
11939
3c616cfa
PE
11940 * alloc.c (compact_small_strings): Tighten assertion a little.
11941
c2982e87
PE
11942 Replace pEd with more-general pI, and fix some printf arg casts.
11943 * lisp.h (pI): New macro, generalizing old pEd macro to other
11944 conversion specifiers. For example, use "...%"pI"d..." rather
11945 than "...%"pEd"...".
11946 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11947 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11948 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11949 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11950 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11951 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11952 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11953 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11954 64-bit hosts.
11955 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11956 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11957 * print.c (safe_debug_print, print_object): Likewise.
11958 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11959 to int.
6f04d126
PE
11960 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11961 avoiding the 0 flag, which is not portable.
c2982e87
PE
11962 * process.c (Fmake_network_process): Use pI to avoid cast.
11963 * region-cache.c (pp_cache): Likewise.
11964 * xdisp.c (decode_mode_spec): Likewise.
11965 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11966 behavior on 64-bit hosts with printf arg.
6f04d126 11967 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11968 (x_stop_queuing_selection_requests): Likewise.
11969 (x_get_window_property): Don't truncate byte count to an 'int'
11970 when tracing.
0b432f21 11971
5e073ec7
PE
11972 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11973 here, since it parses constructs like leading '-' and spaces,
11974 which are not wanted; and it overflows with large numbers.
11975 Instead, simply match F[0-9]+, which is what is wanted anyway.
11976
36372bf9
PE
11977 * alloc.c: Remove unportable assumptions about struct layout.
11978 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11979 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11980 (allocate_vectorlike, make_pure_vector): Use the new macros,
11981 plus offsetof, to remove unportable assumptions about struct layout.
11982 These assumptions hold on all porting targets that I know of, but
11983 they are not guaranteed, they're easy to remove, and removing them
11984 makes further changes easier.
11985
0b432f21
PE
11986 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11987 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11988 (string_overrun_cookie): Now const. Use initializers that
11989 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11990 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11991 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11992 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11993 multiple of sizeof (EMACS_INT); it need not be, if
11994 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11995 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11996
895009e1
JB
119972011-04-26 Juanma Barranquero <lekktu@gmail.com>
11998
11999 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12000
6a7a1b0b
TZ
120012011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12002
12003 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12004 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12005 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12006
841a1577 120072011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12008
12009 * lisp.h (Qdebug): List symbol.
895009e1 12010 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12011 * keyboard.c (debug-on-event): New variable.
12012 (handle_user_signal): Break into debugger when debug-on-event
12013 matches the current signal symbol.
12014
f2d3ba6f
DN
120152011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12016
12017 * alloc.c (check_sblock, check_string_bytes)
12018 (check_string_free_list): Convert to standard C.
12019
42ce4c63
TZ
120202011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12021
12022 * w32.c (emacs_gnutls_push): Fix typo.
12023
825cd63c
EZ
120242011-04-25 Eli Zaretskii <eliz@gnu.org>
12025
fb11d64d
EZ
12026 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12027 "cast to pointer from integer of different size".
12028
825cd63c
EZ
12029 Improve doprnt and its use in verror. (Bug#8545)
12030 * doprnt.c (doprnt): Document the set of format control sequences
12031 supported by the function. Use SAFE_ALLOCA instead of always
12032 using `alloca'.
12033
12034 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12035 is one byte too soon. Don't use xrealloc; instead xfree and
12036 xmalloc anew.
12037
e061a11b
TZ
120382011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12039
12040 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12041 callbacks stage.
12042
12043 * gnutls.c: Renamed global_initialized to
12044 gnutls_global_initialized. Added internals for the
12045 :verify-hostname-error, :verify-error, and :verify-flags
12046 parameters of `gnutls-boot' and documented those parameters in the
12047 docstring. Start callback support.
9173deec
JB
12048 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12049 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12050 on error. Return error code.
e061a11b
TZ
12051 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12052 (emacs_gnutls_read): Likewise.
12053 (Fgnutls_boot): Return handshake error code.
12054 (emacs_gnutls_handle_error): New function.
12055 (wsaerror_to_errno): Likewise.
12056
12057 * w32.h (emacs_gnutls_pull): Add prototype.
12058 (emacs_gnutls_push): Likewise.
12059
12060 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12061 (emacs_gnutls_push): Likewise.
12062
120632011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12064
12065 * process.c (wait_reading_process_output): Check if GnuTLS
12066 buffered some data internally if no FDs are set for TLS
12067 connections.
12068
12069 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12070 (LIBS): Link to USER_LIBS.
12071 ($(BLD)/gnutls.$(0)): New target.
12072
fa6996bc
EZ
120732011-04-24 Eli Zaretskii <eliz@gnu.org>
12074
eb35682e
EZ
12075 * xdisp.c (handle_single_display_spec): Rename the
12076 display_replaced_before_p argument into display_replaced_p, to
12077 make it consistent with the commentary. Fix typos in the
12078 commentary.
12079
e2ad650c
EZ
12080 * textprop.c (syms_of_textprop): Remove dead code.
12081 (copy_text_properties): Delete obsolete commentary about an
12082 interface that was deleted long ago. Fix typos in the description
12083 of arguments.
12084
1b2de274
EZ
12085 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12086 to changes in oldXMenu/XMenu.h from 2011-04-16.
12087 <menu_help_message, prev_menu_help_message>: Constify.
12088 (IT_menu_make_room): menu->help_text is now `const char **';
12089 adjust.
12090
12091 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12092 to changes in oldXMenu/XMenu.h from 2011-04-16.
12093 (struct XMenu): Declare `help_text' `const char **'.
12094
12095 * xfaces.c <Qunspecified>: Make extern again.
12096
12097 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12098 required by POSIX.
1b2de274 12099
762b15be
EZ
12100 * doc.c (get_doc_string): Improve the format passed to `error'.
12101
12102 * doprnt.c (doprnt): Improve commentary.
12103
12104 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12105
12106 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12107 them with etags.
12108
f1052e5d
EZ
12109 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12110 changes in globals.h immediately force recompilation.
762b15be
EZ
12111 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12112 $(CURDIR)/s/ms-w32.h.
12113 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12114
fa6996bc
EZ
12115 * character.c (Fchar_direction): Function deleted.
12116 (syms_of_character): Don't defsubr it.
12117 <char-direction-table>: Deleted.
12118
e6c3da20
EZ
121192011-04-23 Eli Zaretskii <eliz@gnu.org>
12120
12121 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12122 * doprnt.c: Include limits.h.
12123 (SIZE_MAX): New macro.
04f2d78b
CB
12124 (doprnt): Return a size_t value. 2nd arg is now size_t.
12125 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12126 Improve overflow protection. Support `l' modifier for integer
12127 conversions. Support %l conversion. Don't assume an EMACS_INT
12128 argument for integer conversions and for %c.
12129
12130 * lisp.h (doprnt): Restore prototype.
12131
12132 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12133 $(SRC)/character.h.
12134
12135 * Makefile.in (base_obj): Add back doprnt.o.
12136
12137 * deps.mk (doprnt.o): Add back prerequisites.
12138 (callint.o): Depend on character.h.
12139
12140 * eval.c (internal_lisp_condition_case): Include the handler
12141 representation in the error message.
12142 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12143 when breaking from the loop.
12144
12145 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12146
12147 * callint.c (Fcall_interactively): When displaying error message
12148 about invalid control letter, pass the character's codepoint, not
12149 a pointer to its multibyte form. Improve display of the character
12150 in octal and display also its hex code.
12151
12152 * character.c (char_string): Use %x to display the (unsigned)
12153 codepoint of an invalid character, to avoid displaying a bogus
12154 negative value.
12155
12156 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12157 `error', not SYMBOL_NAME itself.
12158
12159 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12160 character arguments to `error'.
12161
12162 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12163 to `error' in error message about FINAL_CHAR argument. Make sure
12164 FINAL_CHAR is a character, and use %c when it is passed as
12165 argument to `error'.
12166
4ffd0d6b 121672011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12168
12169 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12170
12171 * w32.c: Include <time.h>.
12172 (sys_localtime): New function.
12173
4ffd0d6b 121742011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12175
12176 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12177
4ffd0d6b 12178 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12179
4ffd0d6b 121802011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12181
4ffd0d6b
GM
12182 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12183 zombies (Bug#8467).
aac0c6e3 12184
04c56954
EZ
121852011-04-19 Eli Zaretskii <eliz@gnu.org>
12186
12187 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12188 gl_state.e_property when gl_state.object is Qt.
12189
12190 * insdel.c (make_gap_larger): Remove limitation of buffer size
12191 to <= INT_MAX.
12192
16a43933
CY
121932011-04-18 Chong Yidong <cyd@stupidchicken.com>
12194
12195 * xdisp.c (lookup_glyphless_char_display)
12196 (produce_glyphless_glyph): Handle cons cell entry in
12197 glyphless-char-display.
12198 (Vglyphless_char_display): Document it.
12199
12200 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12201 glyphless-char-display.
12202
4581706e
CY
122032011-04-17 Chong Yidong <cyd@stupidchicken.com>
12204
12205 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12206
12207 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12208
12209 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12210 definition for no-X builds.
12211
4887c6e2 122122011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12213
fd35b6f9
PE
12214 Static checks with GCC 4.6.0 and non-default toolkits.
12215
5c1ccb01
PE
12216 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12217
006c5daa
PE
12218 * process.c (keyboard_bit_set): Define only if SIGIO.
12219 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12220 (send_process): Repair possible setjmp clobbering.
12221
efc736d3
PE
12222 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12223
4e2fe2e6
PE
12224 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12225
f97334a2
PE
12226 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12227
4e75f29d
PE
12228 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12229 Define only if needed.
12230
90efadd1
PE
12231 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12232 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12233 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12234
3c647824
PE
12235 * dispextern.h (struct redisplay_interface): Rename param
12236 to avoid shadowing.
e264f262 12237 * termhooks.h (struct terminal): Likewise.
761383f4 12238 * xterm.c (xembed_send_message): Likewise.
3c647824 12239
b58c5c4a
PE
12240 * insdel.c (make_gap_smaller): Define only if
12241 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12242
cad59032
PE
12243 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12244 it.
12245
c339dc2e
PE
12246 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12247 so that we aren't warned about unused symbols.
12248
91a3e27b
PE
12249 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12250
399c71d3 12251 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12252
8ffc96f5
PE
12253 * xfns.c (x_real_positions): Mark locals as initialized.
12254
eef9bc79
PE
12255 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12256
098db9dd
PE
12257 * xterm.c: Fix problems found by static analysis with other toolkits.
12258 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12259 (x_dispatch_event): Declare static if USE_GTK, and
12260 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12261 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12262 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12263 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12264 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12265
eb18f6cc
PE
12266 * xmenu.c (menu_help_callback): Pointer type fixes.
12267 Use const pointers when pointing at readonly data. Avoid pointer
12268 signedness clashes.
12269 (FALSE): Remove unused macro.
12270 (update_frame_menubar): Remove unused decl.
12271
1fe72bf8
PE
12272 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12273
60d9e1db
PE
12274 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12275 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12276 (single_menu_item): Rename local to avoid shadowing.
12277
39261c26
PE
12278 * keyboard.c (make_lispy_event): Remove unused local var.
12279
018c5e19
PE
12280 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12281 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12282
63d2b86e
PE
12283 * bitmaps: Change bitmaps from unsigned char back to the X11
12284 compatible char. Avoid the old compiler warnings about
12285 out-of-range initializers by using, for example, '\xab' rather
12286 than 0xab.
12287
aefd87e1
PE
12288 * xgselect.c (xgselect_initialize): Check vs interface
12289 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12290
bf501fb9
PE
12291 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12292
e9829fdf
PE
12293 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12294 to read-only memory.
12295
1086c095
PE
12296 * fns.c (vector): Remove; this old hack is no longer needed.
12297
2baccd04 12298 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12299 Remove unused var.
dde42981 12300 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12301
72391843 12302 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12303
436c16df 12304 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12305 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12306 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12307
92bb796d 12308 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12309 (x_term_init): Remove local to avoid shadowing.
92bb796d 12310
764430a3 12311 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12312
12313 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12314 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12315
d1dfb56c
EZ
123162011-04-16 Eli Zaretskii <eliz@gnu.org>
12317
c4354cb4
EZ
12318 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12319
d1dfb56c
EZ
12320 Fix regex.c, syntax.c and friends for buffers > 2GB.
12321 * syntax.h (struct gl_state_s): Declare character position members
12322 EMACS_INT.
12323
12324 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12325
04f2d78b
CB
12326 * textprop.c (verify_interval_modification, interval_of):
12327 Declare arguments EMACS_INT.
d1dfb56c
EZ
12328
12329 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12330 EMACS_INT.
12331
12332 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12333
12334 * indent.c (Fvertical_motion): Local variable it_start is now
12335 EMACS_INT.
12336
12337 * regex.c (re_match, re_match_2, re_match_2_internal)
12338 (bcmp_translate, regcomp, regexec, print_double_string)
12339 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12340 (re_compile_pattern, re_exec): Declare arguments and local
12341 variables `size_t' and `ssize_t' and return values `regoff_t', as
12342 appropriate.
12343 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12344 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12345 <compile_stack_type>: `size' and `avail' are now `size_t'.
12346
12347 * regex.h <regoff_t>: Use ssize_t, not int.
12348 (re_search, re_search_2, re_match, re_match_2): Arguments that
12349 specify buffer/string position and length are now ssize_t and
12350 size_t. Return type is regoff_t.
12351
613052cd
BK
123522011-04-16 Ben Key <bkey76@gmail.com>
12353
12354 * nsfont.m: Fixed bugs in ns_get_family and
12355 ns_descriptor_to_entity that were caused by using free to
12356 deallocate memory blocks that were allocated by xmalloc (via
12357 xstrdup). This caused Emacs to crash when compiled with
12358 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12359 --enable-checking=xmallocoverrun). xfree is now used to
12360 deallocate these memory blocks.
12361
4170f62f 123622011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12363
71b41406
PE
12364 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12365
9587a89d
PE
12366 emacs_write: Accept and return EMACS_INT for sizes.
12367 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12368 et seq.
12369 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12370 Accept and return EMACS_INT.
12371 (emacs_gnutls_write): Return the number of bytes written on
12372 partial writes.
12373 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12374 (emacs_read, emacs_write): Remove check for negative size, as the
12375 Emacs source code has been audited now.
9587a89d
PE
12376 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12377 (emacs_read, emacs_write): Use it.
273a5f82
PE
12378 * process.c (send_process): Adjust to the new signatures of
12379 emacs_write and emacs_gnutls_write. Do not attempt to store
12380 a byte offset into an 'int'; it might overflow.
9587a89d 12381 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12382
3e047f51
PE
12383 * sound.c: Don't assume sizes fit in 'int'.
12384 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12385 Return EMACS_INT, not int.
3e047f51 12386 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12387 Accept EMACS_INT, not int.
12388 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12389 record read return values.
12390
cc39a9db
BK
123912011-04-15 Ben Key <bkey76@gmail.com>
12392
c9d0ec6d
JB
12393 * keyboard.c (Qundefined): Don't declare static since it is used
12394 in nsfns.m.
12395 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12396 static since they are used in nsfont.m.
cc39a9db 12397
6c60eb9f
SM
123982011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12399
12400 * process.c (Qprocessp): Don't declare static.
12401 * lisp.h (Qprocessp): Declare again.
12402
7990b61a
JB
124032011-04-15 Juanma Barranquero <lekktu@gmail.com>
12404
12405 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12406
5d4cb038
PE
124072011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12408
8bd7b830 12409 Improve C-level modularity by making more things 'static'.
cd64ea1d 12410
e3b27b31
PE
12411 Don't publish debugger-only interfaces to other modules.
12412 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12413 (verify_bytepos, count_markers): Move decls to the only modules
12414 that need them.
12415 * region-cache.h (pp_cache): Likewise.
12416 * window.h (check_all_windows): Likewise.
12417 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12418
5d4cb038
PE
12419 * sysdep.c (croak): Now static, if
12420 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12421 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12422
12423 * alloc.c (refill_memory_reserve): Now static if
12424 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12425 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12426
e87b6180
PE
12427 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12428 Define only if USE_LUCID.
12429
ac64929e
PE
12430 * xrdb.c (x_customization_string, x_rm_string): Now static.
12431
6f37259d
PE
12432 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12433 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12434
1683e3ab
PE
12435 * xdisp.c (draw_row_with_mouse_face): Now static.
12436 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12437
de9c2632
PE
12438 * window.h (check_all_windows): Mark externally visible.
12439
2b96acb7
PE
12440 * window.c (window_deletion_count): Now static.
12441
12442 * undo.c: Make symbols static if they're not exported.
12443 (last_undo_buffer, last_boundary_position, pending_boundary):
12444 Now static.
12445
50436f33
PE
12446 * textprop.c (interval_insert_behind_hooks): Now static.
12447 (interval_insert_in_front_hooks): Likewise.
12448
64520e5c
PE
12449 * term.c: Make symbols static if they're not exported.
12450 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12451 (max_frame_lines, tty_set_terminal_modes):
12452 (tty_reset_terminal_modes, tty_turn_off_highlight):
12453 (get_tty_terminal): Now static.
12454 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12455 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12456 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12457 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12458 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12459
1fa53021
PE
12460 * sysdep.c: Make symbols static if they're not exported.
12461 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12462 Now static.
12463 (sigprocmask_set, full_mask): Remove; unused.
12464 (wait_debugging): Mark as visible.
12465 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12466 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12467
d4b43b22
PE
12468 * syntax.c (syntax_temp): Define only if !__GNUC__.
12469
b7c513d0
PE
12470 * sound.c (current_sound_device, current_sound): Now static.
12471
989b29ad
PE
12472 * search.c (searchbufs, searchbuf_head): Now static.
12473
13a55a78
PE
12474 * scroll.c (scroll_cost): Remove; unused.
12475 * dispextern.h (scroll_cost): Remove decl.
12476
de68a1fc
PE
12477 * region-cache.h (pp_cache): Mark as externally visible.
12478
40ccffa6
PE
12479 * process.c: Make symbols static if they're not exported.
12480 (process_tick, update_tick, create_process, chan_process):
12481 (Vprocess_alist, proc_buffered_char, datagram_access):
12482 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12483 (deactivate_process): Mark defn as static, as well as decl.
12484 * lisp.h (create_process): Remove decl.
12485 * process.h (chan_process, Vprocess_alist): Remove decls.
12486
ad64fc97
PE
12487 * print.c: Make symbols static if they're not exported.
12488 (print_depth, new_backquote_output, being_printed, print_buffer):
12489 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12490 (print_interval, print_number_index, initial_stderr_stream):
12491 Now static.
12492 * lisp.h (Fprinc): Remove decl.
12493 (debug_output_compilation_hack): Mark as externally visible.
12494
adddb265
PE
12495 * sysdep.c (croak): Move decl from here to syssignal.h.
12496 * syssignal.h (croak): Put it here, so the API can be checked when
12497 'croak' is called from dissociate_if_controlling_tty.
12498
1717ede2
PE
12499 * minibuf.c: Make symbols static if they're not exported.
12500 (minibuf_save_list, choose_minibuf_frame): Now static.
12501 * lisp.h (choose_minibuf_frame): Remove decl.
12502
fa5fb2bc
PE
12503 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12504
1e3890d1
PE
12505 * lread.c: Make symbols static if they're not exported.
12506 (read_objects, initial_obarray, oblookup_last_bucket_number):
12507 Now static.
12508 (make_symbol): Remove; unused.
12509 * lisp.h (initial_obarray, make_symbol): Remove decls.
12510
8a1414fa
PE
12511 * keyboard.c: Make symbols static if they're not exported.
12512 (single_kboard, recent_keys_index, total_keys, recent_keys):
12513 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12514 (this_single_command_key_start, echoing, last_auto_save):
12515 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12516 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12517 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12518 (Vlispy_mouse_stem, double_click_count):
12519 Now static.
12520 (force_auto_save_soon): Define only if SIGDANGER.
12521 (ignore_mouse_drag_p): Now static if
12522 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12523 (print_help): Remove; unused.
12524 (stop_character, last_timer_event): Mark as externally visible.
12525 * keyboard.h (ignore_mouse_drag_p): Declare only if
12526 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12527 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12528 * lisp.h (echoing): Remove decl.
12529 (force_auto_save_soon): Declare only if SIGDANGER.
12530 * xdisp.c (redisplay_window): Simplify code, to make it more
12531 obvious that ignore_mouse_drag_p is not accessed if !defined
12532 USE_GTK && !defined HAVE_NS.
12533
93ea6e8f
PE
12534 * intervals.c: Make symbols static if they're not exported.
12535 (merge_properties_sticky, merge_interval_right, delete_interval):
12536 Now static.
12537 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12538
77382fcc
PE
12539 * insdel.c: Make symbols static if they're not exported.
12540 However, leave prepare_to_modify_buffer alone. It's never
12541 called from outside this function, but that appears to be a bug.
12542 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12543 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12544 (adjust_after_replace_noundo): Remove; unused.
12545 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12546 (signal_before_change): Remove decls.
77382fcc 12547
9306c32e
PE
12548 * indent.c (val_compute_motion, val_vmotion): Now static.
12549
cd44d2eb
PE
12550 * image.c: Make symbols static if they're not exported.
12551 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12552 if USE_GTK.
12553 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12554 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12555
ad9a7a06
PE
12556 * fringe.c (standard_bitmaps): Now static.
12557 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12558
81626931
PE
12559 * frame.c: Make symbols static if they're not exported.
12560 (x_report_frame_params, make_terminal_frame): Now static.
12561 (get_frame_param): Now static, unless HAVE_NS.
12562 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12563 (x_get_resource_string): Remove; not used.
12564 * frame.h (make_terminal_frame, x_report_frame_params):
12565 (x_get_resource_string); Remove decls.
12566 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12567 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12568
239f9db9
PE
12569 * font.c, fontset.c: Make symbols static if they're not exported.
12570 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12571 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12572 * font.c (font_close_object): Now static.
12573 * font.h (font_close_object): Remove.
12574 * fontset.c (FONTSET_OBJLIST): Remove.
12575 (free_realized_fontset) #if-0 the body, which does nothing.
12576 (face_suitable_for_char_p): #if-0, as it's never called.
12577 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12578 * xfaces.c (face_at_string_position):
12579 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12580 since 0 is always ASCII.
12581
dfcf3579
PE
12582 * fns.c (weak_hash_tables): Now static.
12583
5045092b
PE
12584 * fileio.c: Make symbols static if they're not exported.
12585 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12586 (Vwrite_region_annotation_buffers): Now static.
12587
57a96f5c
PE
12588 * eval.c: Make symbols static if they're not exported.
12589 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12590 * lisp.h (backtrace_list): Remove decl.
12591
35f08c38
PE
12592 * emacs.c: Make symbols static if they're not exported.
12593 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12594 (fatal_error_code, fatal_error_signal_hook, standard_args):
12595 Now static.
12596 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12597 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12598 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12599 * lisp.h (fatal_error_signal_hook): Remove decl.
12600 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12601
f44bd759
PE
12602 * editfns.c: Move a (normally-unused) function to its only use.
12603 * editfns.c, lisp.h (get_operating_system_release): Remove.
12604 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12605 worth the hassle of breaking this out.
12606
b532497d
PE
12607 * xterm.c: Make symbols static if they're not exported.
12608 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12609 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12610 (x_destroy_window, x_delete_display):
12611 Now static.
12612 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12613 (x_mouse_leave): Remove; unused.
12614 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12615 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12616 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12617 Remove decls.
12618 (x_mouse_leave): Declare only if WINDOWSNT.
12619 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12620 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12621 USE_X_TOOLKIT.
12622
1675728f
PE
12623 * ftxfont.c: Make symbols static if they're not exported.
12624 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12625 HAVE_FREETYPE.
12626 * font.h (ftxfont_driver): Likewise.
12627
e4cebfca
PE
12628 * xfns.c: Make symbols static if they're not exported.
12629 (x_last_font_name, x_display_info_for_name):
12630 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12631 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12632 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12633 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12634 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12635 (last_show_tip_args): Now static.
12636 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12637 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12638 (x_screen_planes): Remove; unused.
12639 * dispextern.h (x_screen_planes): Remove decl.
12640
5bf46f05
PE
12641 * dispnew.c: Make symbols static if they're not exported.
12642 * dispextern.h (redraw_garbaged_frames, scrolling):
12643 (increment_row_positions): Remove.
12644 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12645 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12646 Now static.
12647 (redraw_garbaged_frames): Remove; unused.
12648
435f4c28
PE
12649 * xfaces.c: Make symbols static if they're not exported.
12650 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12651 Remove decls.
12652 * xterm.h (defined_color): Remove decls.
12653 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12654 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12655 (menu_face_changed_default, defined_color, free_realized_face):
12656 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12657 (ascii_face_of_lisp_face): Remove; unused.
12658
8524aef3
PE
12659 * xdisp.c: Make symbols static if they're not exported.
12660 * dispextern.h (scratch_glyph_row, window_box_edges):
12661 (glyph_to_pixel_coords, set_cursor_from_row):
12662 (get_next_display_element, set_iterator_to_next):
12663 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12664 (show_mouse_face): Remove decls
12665 * frame.h (message_buf_print): Likewise.
12666 * lisp.h (pop_message, set_message, check_point_in_composition):
12667 Likewise.
12668 * xterm.h (set_vertical_scroll_bar): Likewise.
12669 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12670 (message_buf_print, scratch_glyph_row, displayed_buffer):
12671 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12672 (get_next_display_element, show_mouse_face, window_box_edges):
12673 (frame_to_window_pixel_xy, check_point_in_composition):
12674 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12675 (glyph_to_pixel_coords): Remove; unused.
12676
16390cd2
PE
12677 * dired.c (file_name_completion): Now static.
12678
12679 * dbusbind.c (xd_in_read_queued_messages): Now static.
12680
a25f4dfa
PE
12681 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12682 * data.c (circular_list_error): Remove.
12683
14a9c8df
PE
12684 * commands.h (last_point_position, last_point_position_buffer):
12685 (last_point_position_window): Remove decls.
12686 * keyboard.c: Make these variables static.
12687
04f2d78b
CB
12688 * coding.h (coding, code_convert_region, encode_coding_gap):
12689 Remove decls.
74ab6df5
PE
12690 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12691 (iso_code_class, detect_coding, code_convert_region): Now static.
12692 (encode_coding_gap): Remove; unused.
12693
38dfbee1
PE
12694 * chartab.c (chartab_chars, chartab_bits): Now static.
12695
a2cb4e63
PE
12696 * charset.h (charset_iso_8859_1): Remove decl.
12697 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12698 Now static.
12699
127198fd
PE
12700 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12701 * ccl.c (Vccl_program_table): Now static.
12702 (check_ccl_update): Remove; unused.
12703
d85b608f
PE
12704 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12705 * category.h: ... from here.
12706 * category.c (check_category_table, set_category_set): Now static.
12707
31cd66f3
PE
12708 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12709 * lisp.h: Remove these decls.
12710
c358e587
PE
12711 * buffer.c (buffer_count): Remove unused var.
12712
e78aecca
PE
12713 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12714 so that it's not optimized away.
12715 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12716 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12717 exported only to the debugger.
12718
e192d7d3 12719 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12720 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12721
92470028
PE
12722 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12723 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12724 was inaccessible from Lisp.
12725 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12726 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12727
244ed907
PE
12728 alloc.c: Import and export fewer symbols, and remove unused items.
12729 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12730 is defined.
12731 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12732 it's not optimized away by whole-program optimization.
12733 (message_enable_multibyte, free_misc): Remove.
12734 (catchlist, handlerlist, mark_backtrace):
12735 Declare only if BYTE_MARK_STACK.
12736 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12737 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12738 (message_enable_multibyte): Remove decl.
12739 (free_misc, interval_free_list, float_block, float_block_index):
12740 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12741 (cons_free_list, last_marked_index):
12742 Now static.
12743 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12744 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12745 (mark_backtrace): Define only if BYTE_MARK_STACK.
12746 * xdisp.c (message_enable_multibyte): Now static.
12747
61c2b50e 12748 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12749 This makes it easier for human readers (and static analyzers)
12750 to see whether these variables are used from other modules.
12751 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12752 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12753 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12754 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12755 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12756 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12757 * xmenu.c, xselect.c:
12758 Declare Q* vars static if they are not used in other modules.
12759 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12760 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12761 Remove decls of unexported vars.
12762 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12763
95c82688
PE
12764 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12765
16a97296
PE
12766 Make Emacs functions such as Fatom 'static' by default.
12767 This makes it easier for human readers (and static analyzers)
12768 to see whether these functions can be called from other modules.
12769 DEFUN now defines a static function. To make the function external
12770 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12771 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12772 (Finit_image_library):
16a97296
PE
12773 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12774 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12775 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12776 Remove decls, since these functions are now static.
12777 (Funintern, Fget_internal_run_time): New decls, since these functions
12778 were already external.
95c82688 12779
16a97296
PE
12780 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12781 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12782 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12783 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12784 * keyboard.c, keymap.c, lread.c:
12785 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12786 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12787 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12788 Mark functions with DEFUE instead of DEFUN,
12789 if they are used in other modules.
12790 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12791 decls for now-static functions.
12792 * buffer.h (Fdelete_overlay): Remove decl.
12793 * callproc.c (Fgetenv_internal): Mark as internal.
12794 * composite.c (Fremove_list_of_text_properties): Remove decl.
12795 (Fcomposition_get_gstring): New forward static decl.
12796 * composite.h (Fcomposite_get_gstring): Remove decl.
12797 * dired.c (Ffile_attributes): New forward static decl.
12798 * doc.c (Fdocumntation_property): New forward static decl.
12799 * eval.c (Ffetch_bytecode): New forward static decl.
12800 (Funintern): Remove extern decl; now in .h file where it belongs.
12801 * fileio.c (Fmake_symbolic_link): New forward static decl.
12802 * image.c (Finit_image_library): New forward static decl.
12803 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12804 * intervals.h (Fprevious_property_change):
12805 (Fremove_list_of_text_properties): Remove decls.
12806 * keyboard.c (Fthis_command_keys): Remove decl.
12807 (Fcommand_execute): New forward static decl.
12808 * keymap.c (Flookup_key): New forward static decl.
12809 (Fcopy_keymap): Now static.
12810 * keymap.h (Flookup_key): Remove decl.
12811 * process.c (Fget_process): New forward static decl.
12812 (Fprocess_datagram_address): Mark as internal.
12813 * syntax.c (Fsyntax_table_p): New forward static decl.
12814 (skip_chars): Remove duplicate decl.
12815 * textprop.c (Fprevious_property_change): New forward static decl.
12816 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12817 Now internal.
12818 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12819 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12820
785bbd42
PE
12821 * editfns.c (Fformat): Remove unreachable code.
12822
8b913b57
AS
128232011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12824
12825 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12826 change. (Bug#8496)
12827
a6744a35
EZ
128282011-04-13 Eli Zaretskii <eliz@gnu.org>
12829
12830 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12831 when at ZV. (Bug#8487)
12832
e7974947
AS
128332011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12834
baad03f0
AS
12835 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12836 (Bug#8437)
12837 * keyboard.c (parse_tool_bar_item): Likewise.
12838 * sound.c (sound_cleanup, alsa_close): Likewise.
12839 * termcap.c (tgetent): Likewise.
12840 * xfns.c (x_default_font_parameter): Likewise.
12841 * xsettings.c (read_and_apply_settings): Likewise.
12842
e7974947
AS
12843 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12844 (overrun_check_free): Protoize.
12845
28272684
PE
128462011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12847
12848 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12849 since callers should never pass a negative size.
12850 Change the signature to match that of plain 'read' and 'write'; see
12851 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12852 * lisp.h: Update prototypes of emacs_write and emacs_read.
12853
11997c76
EZ
128542011-04-11 Eli Zaretskii <eliz@gnu.org>
12855
12856 * xdisp.c (redisplay_window): Don't try to determine the character
12857 position of the scroll margin if the window start point w->startp
e896f03c 12858 is outside the buffer's accessible region. (Bug#8468)
11997c76 12859
8a2cbd72
EZ
128602011-04-10 Eli Zaretskii <eliz@gnu.org>
12861
12862 Fix write-region and its subroutines for buffers > 2GB.
12863 * fileio.c (a_write, e_write): Modify declaration of arguments and
12864 local variables to support buffers larger than 2GB.
12865 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12866
12867 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12868 argument, local variables, and return value.
12869
12870 * lisp.h: Update prototypes of emacs_write and emacs_read.
12871
12872 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12873
4073e537 128742011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12875
1ebfdcb6
PE
12876 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12877
b2ded58d
PE
12878 Fix more problems found by GCC 4.6.0's static checks.
12879
7d66342c
PE
12880 * xdisp.c (vmessage): Use a better test for character truncation.
12881
bbf47d44
PE
12882 * charset.c (load_charset_map): <, not <=, for optimization,
12883 and to avoid potential problems with integer overflow.
9248994d 12884 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12885 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12886 * editfns.c (Fformat): Likewise.
1e69125e 12887 * syntax.c (skip_chars): Likewise.
3befa583 12888
e3019616
PE
12889 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12890 This also lets GCC 4.6.0 generate slightly better loop code.
12891
becfa255
PE
12892 * callint.c (Fcall_interactively): <, not <=, for optimization.
12893 (Fcall_interactively): Count the number of arguments produced,
12894 not the number of arguments given. This is simpler and lets GCC
12895 4.6.0 generate slightly better code.
12896
dae0cd48
PE
12897 * ftfont.c: Distingish more carefully between FcChar8 and char.
12898 The previous code passed unsigned char * to a functions like
12899 strlen and xstrcasecmp that expect char *, which does not
12900 conform to the C standard.
12901 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12902 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12903 char * when the C standard requires it.
12904
76032d70
PE
12905 * keyboard.c (read_char): Remove unused var.
12906
eb3f1cc8
PE
12907 * eval.c: Port to Windows vsnprintf (Bug#8435).
12908 Include <limits.h>.
12909 (SIZE_MAX): Define if the headers do not.
12910 (verror): Do not give up if vsnprintf returns a negative count.
12911 Instead, grow the buffer. This ports to Windows vsnprintf, which
12912 does not conform to C99. Problem reported by Eli Zaretskii.
12913 Also, simplify the allocation scheme, by avoiding the need for
12914 calling realloc, and removing the ALLOCATED variable.
12915
70476b54
PE
12916 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12917
12020a9e
PE
12918 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12919 But keep the doprint source code for now, as we might revamp it
12920 and use it again (Bug#8435).
ea6c7ae6
PE
12921 * lisp.h (doprnt): Remove.
12922 * Makefile.in (base_obj): Remove doprnt.o.
12923 * deps.mk (doprnt.o): Remove.
12924
5fdb398c
PE
12925 error: Print 32- and 64-bit integers portably (Bug#8435).
12926 Without this change, on typical 64-bit hosts error ("...%d...", N)
12927 was used to print both 32- and 64-bit integers N, which relied on
12928 undefined behavior.
61bdb816 12929 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12930 * lisp.h (error, verror): Mark as printf-like functions.
12931 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12932 Report overflow in size calculations when allocating printf buffer.
12933 Do not truncate output string at its first null byte.
12934 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12935 Truncate the output at a character boundary, since vsnprintf does not
12936 do that.
12937 * charset.c (check_iso_charset_parameter): Convert internal
12938 character to string before calling 'error', since %c now has the
12939 printf meaning.
12940 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12941 overflow when computing char to be passed to 'error'. Do not
12942 pass Lisp_Object to 'error'; pass the integer instead.
12943 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12944 formatted with plain %d.
12945
b189fa66
PE
12946 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12947
bff87ef0
PE
12948 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12949
7e2cac20
PE
12950 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12951
ce4d90b5
PE
12952 * xterm.c (x_catch_errors): Remove duplicate declaration.
12953
266c9547
PE
12954 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12955
79c49ad2
PE
12956 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12957
368f4090
JM
129582011-04-10 Jim Meyering <meyering@redhat.com>
12959
12960 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12961 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12962 return ssize_t not "int", and use size_t as the buffer length.
12963 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12964 * gnutls.h: Update declarations.
12965 * process.c (read_process_output): Use ssize_t, to match.
12966 (send_process): Likewise.
12967
a32d4040
CY
129682011-04-09 Chong Yidong <cyd@stupidchicken.com>
12969
12970 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12971
8546720e 129722011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12973
04f2d78b
CB
12974 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12975 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12976
8546720e
GM
12977 * xterm.c (handle_one_xevent):
12978 * xmenu.c (create_and_show_popup_menu):
12979 * xselect.c (x_decline_selection_request)
12980 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12981
0a2f5c1a 129822011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12983
12984 Fix some uses of `int' instead of EMACS_INT.
12985 * search.c (string_match_1, fast_string_match)
12986 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12987 (scan_buffer, find_next_newline_no_quit)
12988 (find_before_next_newline, search_command, Freplace_match)
12989 (Fmatch_data): Make some `int' variables be EMACS_INT.
12990
12991 * xdisp.c (display_count_lines): 3rd argument and return value now
12992 EMACS_INT. All callers changed.
12993 (pint2hrstr): Last argument is now EMACS_INT.
12994
12995 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12996 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12997 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12998 (decode_coding_utf_16, decode_coding_emacs_mule)
12999 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13000 (decode_coding_ccl, decode_coding_charset)
13001 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13002 (decode_coding_iso_2022, decode_coding_emacs_mule)
13003 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13004 <char_offset, last_offset>: Declare EMACS_INT.
13005 (encode_coding_utf_8, encode_coding_utf_16)
13006 (encode_coding_emacs_mule, encode_invocation_designation)
13007 (encode_designation_at_bol, encode_coding_iso_2022)
13008 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13009 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13010 Declare EMACS_INT.
13011 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13012 (encode_invocation_designation): Last argument P_NCHARS is now
13013 EMACS_INT.
13014 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13015 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13016
13017 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13018 All users changed.
13019
13020 * ccl.c (Fccl_execute_on_string): Declare some variables
13021 EMACS_INT.
13022
8546720e 130232011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13024
13025 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13026
4e19a977
CS
130272011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13028
13029 * process.c (Fformat_network_address): Doc fix.
13030
87302331
R
130312011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13032
ee7683eb 13033 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13034
cbb59342
CY
130352011-04-08 Chong Yidong <cyd@stupidchicken.com>
13036
13037 * keyboard.c (read_char): Call Lisp function help-form-show,
13038 instead of using internal_with_output_to_temp_buffer.
13039 (Qhelp_form_show): New var.
e0d38eeb 13040 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13041
13042 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13043
13044 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13045
e67a13ab
CY
130462011-04-06 Chong Yidong <cyd@stupidchicken.com>
13047
04f2d78b
CB
13048 * process.c (Flist_processes): Remove to Lisp.
13049 (list_processes_1): Delete.
e67a13ab 13050
973f782d
EZ
130512011-04-06 Eli Zaretskii <eliz@gnu.org>
13052
7c106b1e
EZ
13053 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13054
973f782d
EZ
13055 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13056
41cf7d1a 130572011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13058
ca23cc88
PE
13059 Fix more problems found by GCC 4.6.0's static checks.
13060
f390e2d5
PE
13061 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13062
42eea0d0
PE
13063 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13064
b69769da 13065 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13066
f9541e84
PE
13067 * xdisp.c (vmessage): Mark as a printf-like function.
13068
13841b55
PE
13069 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13070
c136c10f
PE
13071 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13072
5e2d4a30
PE
13073 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13074 printf-like functions.
13075 (tiff_load): Add casts to remove these marks before passing them
13076 to system-supplied API.
13077
583f48b9
PE
13078 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13079
b25d760e
PE
13080 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13081 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13082 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13083 directly, rather than having caller test rule sign. This avoids
13084 some unnecessary tests.
13085 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13086 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13087 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13088
bc7b6697 13089 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13090 (xfont_open): Avoid unnecessary tests.
bc7b6697 13091
27ccc379
PE
13092 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13093
dcd5c89a
PE
13094 * composite.h, composite.c (composition_gstring_put_cache):
13095 Use EMACS_INT, not int, for length.
13096
b13a45c6
PE
13097 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13098 breaking out part of COMPOSITION_DECODE_RULE.
13099 (COMPOSITION_DECODE_RULE): Use it.
13100 * composite.c (get_composition_id): Remove unused local vars,
13101 by using the new macro.
13102
1e792e4d
PE
13103 * textprop.c (set_text_properties_1): Change while to do-while,
13104 since the condition is always true at first.
13105
dc6c6455 13106 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13107 (interval_deletion_adjustment): Return unsigned value.
13108 All uses changed.
dc6c6455 13109
aba7731a
PE
13110 * process.c (list_processes_1, create_pty, read_process_output):
13111 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13112 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13113 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13114 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13115 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13116
fdfc4bf3
PE
13117 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13118
fca8fe46 13119 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13120 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13121
06a0259a 13122 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13123 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13124 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13125
e7b9e80f
PE
13126 * print.c (print_error_message): Avoid int overflow.
13127
56201685
PE
13128 * font.c (font_list_entities): Redo for clarity,
13129 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13130
78834453 13131 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13132 (font_score): Avoid potential overflow in diff calculation.
78834453 13133
0bc0b309 13134 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13135 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13136
e610eaca
PE
13137 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13138
b895abce
PE
13139 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13140 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13141 can always succeed if overflow has undefined behavior.
13142
1f1d9321 13143 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13144 (wordify): Omit three unnecessary tests.
1f1d9321 13145
c59478bc
PE
13146 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13147 All callers changed. This avoids the need for an unused var.
13148
79b73827
PE
13149 * casefiddle.c (casify_region): Remove var that is set but not used.
13150
a4db5dfe
PE
13151 * dired.c (file_name_completion): Remove var that is set but not used.
13152
43aae36e
PE
13153 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13154
2a47c44d 13155 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13156 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13157
a37c69bf
PE
13158 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13159 Check for integer overflow on size calculations.
13160
328ab8e7
PE
13161 * buffer.c (Fprevious_overlay_change): Remove var that is set
13162 but not used.
13163
e5a2a5cb
PE
13164 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13165 Remove vars that are set but not used.
8d84a6eb 13166 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13167 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13168
a60e5f68
PE
13169 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13170
f661cb61 13171 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13172 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13173
f0397f5a
PE
13174 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13175 that are set but not used.
13176
8664db06 13177 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13178 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13179
6abdaa4a
PE
13180 * xselect.c (x_get_local_selection, x_handle_property_notify):
13181 Remove vars that are set but not used.
13182
0ce7538d 13183 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13184 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13185
9ae848fc
PE
13186 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13187 Remove var that is set but not used.
0b918413
PE
13188 (scroll_bar_windows_size): Now size_t, not int.
13189 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13190 Check for overflow.
9ae848fc 13191
a5a62657
PE
13192 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13193 (map_tty_color) [!defined MSDOS]: Likewise.
13194
5c5cdd39
PE
13195 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13196
66ebf983
PE
13197 * coding.c: Remove vars that are set but not used.
13198 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13199 All callers changed.
13200 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13201 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13202 (decode_coding_charset): Remove vars that are set but not used.
13203
1be4d761
PE
13204 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13205 that is set but not used.
13206
47553fa8
PE
13207 * print.c (print_object): Remove var that is set but not used.
13208
1f7196bf 13209 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13210 The gnulib version avoids calling malloc in the usual case,
13211 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13212 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13213 * filelock.c (current_lock_owner): Likewise.
13214 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13215 * sysdep.c: Include allocator.h, careadlinkat.h.
13216 (emacs_no_realloc_allocator): New static constant.
13217 (emacs_readlink): New function.
fdb61804
PE
13218 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13219 ../lib/careadlinkat.h.
d1fdcab7 13220
f84c17c7
SM
132212011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13222
13223 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13224 first non-nil return value).
13225
ef3862ad
JD
132262011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13227
13228 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13229 if not defined (Bug#8403).
13230
376a7006
JB
132312011-04-02 Juanma Barranquero <lekktu@gmail.com>
13232
13233 * xdisp.c (display_count_lines): Remove parameter `start',
13234 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13235 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13236 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13237 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13238 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13239 and thereabouts. All callers changed.
13240 (get_per_char_metric): Remove parameter `f', unused since
13241 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13242
6ca3801d
JM
132432011-04-02 Jim Meyering <meyering@redhat.com>
13244
13245 do not dereference NULL upon failed strdup
13246 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13247 (ns_get_family): Likewise.
13248
d8e2b5ba
JB
132492011-04-02 Juanma Barranquero <lekktu@gmail.com>
13250
13251 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13252
8c74fcbd
JD
132532011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13254
13255 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13256 later (Bug#8403).
13257
7200d79c
SM
132582011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13259
03408648 13260 Add lexical binding.
7200d79c 13261
03408648
SM
13262 * window.c (Ftemp_output_buffer_show): New fun.
13263 (Fsave_window_excursion):
13264 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13265
13266 * lread.c (lisp_file_lexically_bound_p): New function.
13267 (Fload): Bind Qlexical_binding.
13268 (readevalloop): Remove `evalfun' arg.
13269 Bind Qinternal_interpreter_environment.
13270 (Feval_buffer): Bind Qlexical_binding.
13271 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13272 Mark as dynamic.
13273 (syms_of_lread): Declare `lexical-binding'.
13274
13275 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13276
13277 * keyboard.c (eval_dyn): New fun.
13278 (menu_item_eval_property): Use it.
ca105506
SM
13279
13280 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13281
03408648
SM
13282 * fns.c (concat, mapcar1): Accept byte-code-functions.
13283
13284 * eval.c (Fsetq): Handle lexical vars.
13285 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13286 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13287 (FletX, Flet): Obey lexical binding.
13288 (Fcommandp): Handle closures.
13289 (Feval): New `lexical' arg.
13290 (eval_sub): New function extracted from Feval. Use it almost
13291 everywhere where Feval was used. Look up vars in lexical env.
13292 Handle closures.
13293 (Ffunctionp): Move from subr.el.
13294 (Ffuncall): Handle closures.
13295 (apply_lambda): Remove `eval_flags'.
13296 (funcall_lambda): Handle closures and new byte-code-functions.
13297 (Fspecial_variable_p): New function.
13298 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13299 but without exporting it to Lisp.
23aba0ea 13300
23aba0ea 13301 * doc.c (Fdocumentation, store_function_docstring):
03408648 13302 * data.c (Finteractive_form): Handle closures.
23aba0ea 13303
03408648
SM
13304 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13305 interactive spec.
ba83908c 13306
04f2d78b
CB
13307 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13308 New byte-codes.
03408648
SM
13309 (exec_byte_code): New function extracted from Fbyte_code to handle new
13310 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13311
03408648 13312 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13313
03408648 13314 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13315
e2abce01
JB
133162011-03-31 Juanma Barranquero <lekktu@gmail.com>
13317
13318 * xdisp.c (redisplay_internal): Fix prototype.
13319
63696a73 133202011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13321
63696a73 13322 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13323 (try_scrolling): Use it when setting scroll_limit.
13324 Limit scrolling to 100 screen lines.
63696a73
EZ
13325 (redisplay_window): Even when falling back on "recentering",
13326 position point in the window according to scroll-conservatively,
13327 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13328
13329 (try_scrolling): When point is above the window, allow searching
13330 as far as scroll_max, or one screenful, to compute vertical
13331 distance from PT to the scroll margin position. This prevents
13332 try_scrolling from unnecessarily failing when
13333 scroll-conservatively is set to a value slightly larger than the
13334 window height. Clean up the case of PT below the margin at bottom
13335 of window: scroll_max can no longer be INT_MAX. When aggressive
13336 scrolling is in use, don't let point enter the opposite scroll
13337 margin as result of the scroll.
13338 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13339 threshold of 100 lines for never-recentering scrolling.
13340
e4cc2dfc
JB
133412011-03-31 Juanma Barranquero <lekktu@gmail.com>
13342
13343 * dispextern.h (move_it_by_lines):
13344 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13345 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13346 (message_log_check_duplicate): Remove parameters `prev_bol' and
13347 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13348 (redisplay_internal): Remove parameter `preserve_echo_area',
13349 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13350
13351 * indent.c (Fvertical_motion):
13352 * window.c (window_scroll_pixel_based, Frecenter):
13353 Don't pass `need_y_p' to `move_it_by_lines'.
13354
1c470562
SM
133552011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13356
44f230aa
SM
13357 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13358 steal a few bits to be more compact.
13359 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13360 Remove unneeded casts.
13361
1c470562
SM
13362 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13363
888adce9
ZK
133642011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13365
13366 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13367 binding" message (bug#7967).
13368
f838ed7b
PE
133692011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13370
77861b95
PE
13371 Fix more problems found by GCC 4.6.0's static checks.
13372
de6dbc14
PE
13373 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13374 Remove unused local var.
13375
f838ed7b
PE
13376 * editfns.c (Fmessage_box): Remove unused local var.
13377
792c7b2b
PE
13378 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13379 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13380 Omit unused local vars.
c499e557 13381 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13382 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13383 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13384 Omit unused local var.
13385
ba0165e1
PE
13386 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13387 Don't assume string length fits in int.
32ad8845 13388 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13389 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13390
3c59b4c9
PE
13391 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13392 instead of alloca (Bug#8344).
13393
a3eed478 13394 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13395 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13396
eb4d412d
PE
13397 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13398
1658b401
PE
13399 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13400 concerns.
13401
13402 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13403
13404 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13405
9a2c6e05
PE
13406 * keyboard.c (syms_of_keyboard): Use the same style as later
13407 in this function when indexing through an array. This also
13408 works around GCC bug 48267.
13409
03d0a109
PE
13410 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13411
44f730c8
PE
13412 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13413
fe75f926
PE
13414 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13415 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13416
ffa8c828
PE
13417 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13418 This avoids undefined behavior on integer overflow, and is a bit
13419 more convenient anyway since it is compared to a size_t variable.
13420
c5101a77
PE
13421 Variadic C functions now count arguments with size_t, not int.
13422 This avoids an unnecessary limitation on 64-bit machines, which
13423 caused (substring ...) to crash on large vectors (Bug#8344).
13424 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13425 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13426 All variadic functions and their callers changed accordingly.
c5101a77
PE
13427 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13428 * data.c (arith_driver, float_arith_driver): Likewise.
13429 * editfns.c (general_insert_function): Likewise.
13430 * eval.c (struct backtrace.nargs, interactive_p)
13431 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13432 (funcall_lambda, mark_backtrace): Likewise.
13433 * fns.c (concat): Likewise.
13434 * frame.c (x_set_frame_parameters): Likewise.
13435 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13436 0 if not found, not -1. All callers changed.
13437
dd3f25f7
PE
13438 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13439 (stack_copy_size): Now size_t, not int.
13440 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13441
461c2ab9
JB
134422011-03-28 Juanma Barranquero <lekktu@gmail.com>
13443
13444 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13445 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13446 All callers changed.
13447
13448 * lisp.h (multibyte_char_to_unibyte):
13449 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13450 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13451 * character.h (CHAR_TO_BYTE8):
13452 * cmds.c (internal_self_insert):
13453 * editfns.c (general_insert_function):
13454 * keymap.c (push_key_description):
13455 * search.c (Freplace_match):
13456 * xdisp.c (message_dolog, set_message_1): All callers changed.
13457
f6d62986
SM
134582011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13459
13460 * keyboard.c (safe_run_hook_funcall): New function.
13461 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13462 don't set the hook to nil, but remove the offending function instead.
13463 (Qcommand_hook_internal): Remove, unused.
13464 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13465 Vcommand_hook_internal.
13466
13467 * eval.c (enum run_hooks_condition): Remove.
13468 (funcall_nil, funcall_not): New functions.
13469 (run_hook_with_args): Call each function through a `funcall' argument.
13470 Remove `cond' argument, now redundant.
13471 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13472 (Frun_hook_with_args_until_failure): Adjust accordingly.
13473 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13474
1db5b1ad
JB
134752011-03-28 Juanma Barranquero <lekktu@gmail.com>
13476
13477 * dispextern.h (string_buffer_position): Remove declaration.
13478
13479 * print.c (strout): Remove parameter `multibyte', unused since
13480 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13481
13482 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13483 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13484 All callers changed.
13485
13486 * w32.c (_wsa_errlist): Use braces for struct initializers.
13487
13488 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13489 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13490 All callers changed.
13491 (string_buffer_position): Likewise. Also, make static (it's never
13492 used outside xdisp.c).
13493 (cursor_row_p): Remove parameter `w', unused since
13494 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13495 (decode_mode_spec): Remove parameter `precision', introduced during
13496 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13497 All callers changed.
13498
5ffb62aa
JD
134992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13500
13501 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13502
461c2ab9 135032011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13504
13505 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13506 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13507 (ns_update_auto_hide_menu_bar): New functions.
13508 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13509 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13510 ns_constrain_all_frames.
13511 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13512 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13513
5c380ffb
JD
135142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13515
13516 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13517
9af30bdf
GM
135182011-03-27 Glenn Morris <rgm@gnu.org>
13519
13520 * syssignal.h: Replace RETSIGTYPE with void.
13521 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13522 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13523 Replace SIGTYPE with void everywhere.
13524 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13525 * s/template.h (SIGTYPE): Remove commented out definition.
13526
e2abce01
JB
135272011-03-26 Eli Zaretskii <eliz@gnu.org>
13528
13529 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13530 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13531
f868cd8a
JB
135322011-03-26 Juanma Barranquero <lekktu@gmail.com>
13533
59eb0929
JB
13534 * w32.c (read_unc_volume): Use parameter `henum', instead of
13535 global variable `wget_enum_handle'.
13536
13537 * keymap.c (describe_vector): Remove parameters `indices' and
13538 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13539 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13540
f868cd8a
JB
13541 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13542
13543 * keyboard.c (timer_check): Remove parameter `do_it_now',
13544 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13545 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13546 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13547
13548 * keyboard.c (read_char):
13549 * w32menu.c (w32_menu_display_help):
13550 * xmenu.c (show_help_event, menu_help_callback):
13551 Adjust calls to `show_help_echo'.
13552
13553 * gtkutil.c (xg_maybe_add_timer):
13554 * keyboard.c (readable_events):
13555 * process.c (wait_reading_process_output):
13556 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13557
13558 * insdel.c (adjust_markers_gap_motion):
13559 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13560 (gap_left, gap_right): Don't call it.
13561
2ecf6fdb
CY
135622011-03-25 Chong Yidong <cyd@stupidchicken.com>
13563
13564 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13565 incurred during fontification.
13566
6b1f9ba4
JB
135672011-03-25 Juanma Barranquero <lekktu@gmail.com>
13568
13569 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13570 (DEFVAR_PER_BUFFER): Don't pass it.
13571
13572 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13573 (scrolling_window): Don't pass it.
13574
0f4a96b5
JB
135752011-03-25 Juanma Barranquero <lekktu@gmail.com>
13576
13577 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13578
13579 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13580 and `suffix'.
13581 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13582 of variables specific to SELinux and computation of `encoded_absname'.
13583
13584 * image.c (XPutPixel): Remove unused variable `height'.
13585
13586 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13587
13588 * unexw32.c (get_section_info): Remove unused variable `section'.
13589
13590 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13591 (system_process_attributes): Remove unused variable `sess'.
13592 (sys_read): Remove unused variable `err'.
13593
13594 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13595 (w32_wnd_proc): Remove unused variable `isdead'.
13596 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13597 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13598 (x_create_tip_frame): Remove unused variable `tem'.
13599
13600 * w32inevt.c (w32_console_read_socket):
13601 Remove unused variable `no_events'.
13602
13603 * w32term.c (x_draw_composite_glyph_string_foreground):
13604 Remove unused variable `width'.
13605
1149507c
JB
136062011-03-24 Juanma Barranquero <lekktu@gmail.com>
13607
13608 * w32term.c (x_set_glyph_string_clipping):
13609 Don't pass uninitialized region to CombineRgn.
13610
9c88f339
JB
136112011-03-23 Juanma Barranquero <lekktu@gmail.com>
13612
13613 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13614 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13615 (Fx_close_connection): Remove unused variable `i'.
13616
13617 * w32font.c (w32font_draw): Return number of glyphs.
13618 (w32font_open_internal): Remove unused variable `i'.
13619 (w32font_driver): Add missing initializer.
13620
13621 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13622 (fill_in_menu): Remove unused variable `items_added'.
13623
13624 * w32term.c (last_mouse_press_frame): Remove static global variable.
13625 (w32_clip_to_row): Remove unused variable `f'.
13626 (x_delete_terminal): Remove unused variable `i'.
13627
13628 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13629 (NOTHING): Remove unused static global variable.
13630 (uniscribe_check_otf): Remove unused variable `table'.
13631 (uniscribe_font_driver): Add missing initializers.
13632
dee091a3
JD
136332011-03-23 Julien Danjou <julien@danjou.info>
13634
13635 * term.c (Fsuspend_tty, Fresume_tty):
13636 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13637 * window.c (temp_output_buffer_show):
13638 * insdel.c (signal_before_change):
13639 * frame.c (Fhandle_switch_frame):
13640 * fileio.c (Fdo_auto_save):
13641 * emacs.c (Fkill_emacs):
13642 * editfns.c (save_excursion_restore):
13643 * cmds.c (internal_self_insert):
13644 * callint.c (Fcall_interactively):
13645 * buffer.c (Fkill_all_local_variables):
13646 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13647 Use Frun_hooks.
0f4a96b5 13648 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13649 unconditionally since it does the check itself.
dee091a3 13650
2c520ab5 136512011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13652
c9c49752
PE
13653 Fix more problems found by GCC 4.5.2's static checks.
13654
8abc3f12
PE
13655 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13656 the first time through the loop, since we know p0 < p1 then.
13657 This also avoids a gcc -Wstrict-overflow warning.
13658
a2d26660
PE
13659 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13660 leading to a memory leak, possible in functions like
13661 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13662 of objects (Bug#8318).
a2d26660 13663
916c72e9
PE
13664 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13665 that could (at least in theory) be that large.
13666
19ab8a18
PE
13667 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13668 This is less likely to overflow, and avoids undefined behavior if
13669 overflow does occur. All callers changed. Use strtoul to scan
13670 for the unsigned long integer.
b7cbbd6f
PE
13671 (pint2hrstr): Simplify and tune code slightly.
13672 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13673
f0641eff
PE
13674 * scroll.c (do_scrolling): Work around GCC bug 48228.
13675 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13676
7f650bb9
PE
13677 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13678 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13679 (validate_x_resource_name): Simplify count usage.
13680 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13681
37dd57d1
PE
13682 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13683 fail (Bug#8306).
81e56e61 13684
699979fc 13685 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13686
401bf9b4
PE
13687 * process.c (Fmake_network_process): Use socklen_t, not int,
13688 where POSIX says socklen_t is required in portable programs.
13689 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13690 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13691 (Fmake_network_process, server_accept_connection):
13692 (wait_reading_process_output, read_process_output):
13693 Likewise.
13694
b93aacde
PE
13695 * process.c: Rename or move locals to avoid shadowing.
13696 (list_processes_1, Fmake_network_process):
13697 (read_process_output_error_handler, exec_sentinel_error_handler):
13698 Rename or move locals.
4dc343ee 13699 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13700 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13701 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13702 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13703 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13704
af8a867c 13705 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13706 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13707 Include tparam.h instead, since it declares them.
af8a867c
PE
13708 * cm.h (PC): Remove extern decl; tparam.h now does this.
13709 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13710 * terminfo.c: Include tparam.h, to check interfaces.
13711 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13712 (tparam): Adjust signature to match interface in tparam.h;
13713 this removes some undefined behavior. Check that outstring and len
13714 are zero, which they always are with Emacs.
13715 * tparam.h (PC, BC, UP): New extern decls.
13716
0248044d 13717 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13718 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13719
8ff096c1 13720 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13721 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13722 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13723 (ftfont_list): Remove unused local.
49eaafba
PE
13724 (get_adstyle_property, ftfont_pattern_entity):
13725 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13726 Rename locals to avoid shadowing.
8ff096c1 13727
e2be39f6
PE
13728 * xfont.c (xfont_list_family): Mark var as initialized.
13729
c9735e30
PE
13730 * xml.c (make_dom): Now static.
13731
8f5201ae
PE
13732 * composite.c (composition_compute_stop_pos): Rename local to
13733 avoid shadowing.
b246f932
PE
13734 (composition_reseat_it): Remove unused locals.
13735 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13736 (composition_update_it): Mark var as initialized.
11b61122
PE
13737 (find_automatic_composition): Mark vars as initialized,
13738 with a FIXME (Bug#8290).
8f5201ae 13739
760fbc2c
PE
13740 character.h: Rename locals to avoid shadowing.
13741 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13742 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13743 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13744 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13745 to avoid shadowing.
13746
ff08eb85
PE
13747 * textprop.c (property_change_between_p): Remove; unused.
13748
fc7bf025
PE
13749 * intervals.c (interval_start_pos): Now static.
13750
235d7abc
PE
13751 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13752
44f230aa
SM
13753 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13754 Rename locals to avoid shadowing.
3e7d6594 13755
50060332
PE
13756 * sound.c (wav_play, au_play, Fplay_sound_internal):
13757 Fix pointer signedness.
d01f234b 13758 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13759 (wav_play): Initialize a variable to 0, to prevent undefined
13760 behavior (Bug#8278).
50060332 13761
c4fc4e30
PE
13762 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13763
918436ed
PE
13764 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13765
c939f91b
PE
13766 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13767 clobbering (Bug#8298).
b9c7f648
PE
13768 * sysdep.c (sys_subshell): Likewise.
13769 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13770
6bd8c144
PE
13771 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13772 This should get cleaned up, so that child_setup has the
13773 same signature on all platforms.
13774
7710357c 13775 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13776 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13777
c59da222
CY
137782011-03-22 Chong Yidong <cyd@stupidchicken.com>
13779
13780 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13781 not to be necessary, and produces flickering.
13782
66b87493
GM
137832011-03-20 Glenn Morris <rgm@gnu.org>
13784
13785 * config.in: Remove file.
13786
45b6f6d5
JB
137872011-03-20 Juanma Barranquero <lekktu@gmail.com>
13788
13789 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13790 are now in src/globals.h.
13791 (syms_of_minibuf): Remove spurious & from previous change.
13792
cd394be1 137932011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13794
13795 * minibuf.c (completing-read-function): New variable.
13796 (completing-read-default): Rename from completing-read.
13797 (completing-read): Call completing-read-function.
13798
b14e3e21
CY
137992011-03-19 Juanma Barranquero <lekktu@gmail.com>
13800
13801 * xfaces.c (Fx_load_color_file):
13802 Read color file from absolute filename (bug#8250).
13803
f2b726e6
JB
138042011-03-19 Juanma Barranquero <lekktu@gmail.com>
13805
13806 * makefile.w32-in: Update dependencies.
13807
09f6ff02
EZ
138082011-03-17 Eli Zaretskii <eliz@gnu.org>
13809
13810 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13811
29a6015a
PE
138122011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13813
a3a6c54e
PE
13814 Fix more problems found by GCC 4.5.2's static checks.
13815
b766f867
PE
13816 * process.c (make_serial_process_unwind, send_process_trap):
13817 (sigchld_handler): Now static.
13818
be02381c
PE
13819 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13820 That way, the code declares only the vars that it needs.
13821 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13822 * s/cygwin.h (PTY_ITERATION): Likewise.
13823 * s/darwin.h (PTY_ITERATION): Likewise.
13824 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13825
57048744
PE
13826 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13827 * process.c (allocate_pty): Don't declare stb unless it's needed.
13828
7914961c 13829 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13830 (CONSTANTLIM): Remove; unused.
13831 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13832 Define only if needed.
7914961c 13833
b3967b18
PE
13834 * unexelf.c (unexec): Name an expression,
13835 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13836 Use a different way to cause a compilation error if anyone uses
13837 n rather than nn, a way that does not involve shadowing.
73366a00 13838 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13839
29a6015a
PE
13840 * deps.mk (unexalpha.o): Remove; unused.
13841
43cfc33e 13842 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13843 * unexec.h: New file.
ce701a33
PE
13844 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13845 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13846 Depend on unexec.h.
13847 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13848 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13849 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13850 Change as necessary to match prototype in unexec.h.
ce701a33 13851
01f44d5a
PE
13852 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13853 shadowing.
4f63c6bb 13854 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13855
a6670b0b
PE
13856 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13857 Rename locals to avoid shadowing.
13858
cef2010d 13859 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13860 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13861
d4d7173a
PE
13862 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13863
f08b802a
PE
13864 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13865 warning when compiling print.c.
13866
3ddb0639
PE
13867 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13868 instead of using an uninitialized var.
5ad03b97 13869 (font_sort_entities): Mark var as initialized.
3ddb0639 13870
170a2692
PE
13871 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13872
e663c700
PE
13873 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13874 pointers to constants.
89bc529a 13875 (font_parse_fcname): Remove unused vars.
7b81e2d0 13876 (font_delete_unmatched): Now static.
ea838e10 13877 (font_get_spec): Remove; unused.
13a547c6
PE
13878 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13879 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13880 Rename or move locals to avoid shadowing.
e663c700 13881
2a80c887 13882 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13883 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13884
1384fa33 13885 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13886 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13887
8b2c52e9
PE
13888 * alloc.c (mark_backtrace): Move decl from here ...
13889 * lisp.h: ... to here, so that it can be checked.
13890
475545b5 13891 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13892 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13893 (lisp_indirect_variable): Name an expression,
13894 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13895 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13896
b1349114 13897 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13898 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13899 Use const pointer when appropriate.
b1349114 13900
a2928364
PE
13901 * lisp.h (get_system_name, get_operating_system_release):
13902 Move decls here, to check interfaces.
13903 * process.c (get_operating_system_release): Move decl to lisp.h.
13904 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13905 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13906 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13907 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13908 (Fformat_time_string, Fencode_time, Finsert_char):
13909 (Ftranslate_region_internal, Fformat):
13910 Rename or remove local vars to avoid shadowing.
9710023e 13911 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13912
a415e694
PE
13913 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13914 avoid shadowing.
13915
8ef4622d
PE
13916 * lisp.h (eassert): Check that the argument compiles, even if
13917 ENABLE_CHECKING is not defined.
13918
946f9a5b
PE
13919 * data.c (Findirect_variable): Name an expression, to avoid
13920 gcc -Wbad-function-cast warning.
112396d6 13921 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13922 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13923 (Fmake_variable_buffer_local, Fmake_local_variable):
13924 Mark variables as initialized.
52746918 13925 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13926
e5aab7e7 13927 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13928 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13929 Rename locals to avoid shadowing.
dff45157
PE
13930 (mark_stack): Move local variables into the #ifdef region where
13931 they're used.
7bc26fdb
PE
13932 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13933 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13934 needed otherwise.
13935 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13936 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13937 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13938
e5aab7e7
PE
13939 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13940 avoids undefined behavior in theory.
13941
4da60324
PE
13942 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13943
88043301
PE
13944 Use functions, not macros, for up- and down-casing (Bug#8254).
13945 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13946 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13947 to use the following functions instead of these macros.
13948 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13949 EMACS_INT, since callers assume the returned value fits in int.
13950 (upcase1): Likewise, for UPCASE_TABLE.
13951 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13952 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13953 the race-condition problem in the old DOWNCASE.
88043301 13954
19ed5445
PE
13955 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13956 Rename locals to avoid shadowing.
13957 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13958 (regex_compile, re_search_2, re_match_2_internal):
13959 Remove unused local vars.
952db0d7
PE
13960 (FREE_VAR): Rewrite so as not to use empty "else",
13961 which gcc can warn about.
da053e48 13962 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13963 (RETALLOC_IF): Define only if needed.
13964 (WORDCHAR_P): Likewise. This one is never needed, but is used
13965 only in a comment talking about a compiler bug, so put inside
13966 the #if 0 of that comment.
13967 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13968 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13969 Remove; unused.
19ed5445 13970
1f3561e4 13971 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13972 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13973 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13974
ded6f8f7
PE
13975 * search.c (simple_search): Remove unused var.
13976
dbd37a95
PE
13977 * dired.c (compile_pattern): Move decl from here ...
13978 * lisp.h: ... to here, so that it can be checked.
13979 (struct re_registers): New forward decl.
13980
7e47afad
PE
13981 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13982
85f24f61
PE
13983 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13984 All uses changed.
13985 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13986 Rename locals to avoid shadowing.
5671df8f 13987 (Fvertical_motion): Mark locals as initialized.
85f24f61 13988
181aa2be 13989 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13990 (casify_region): Mark local as initialized.
181aa2be 13991
930d429c
PE
13992 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13993
7082eac6
PE
13994 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13995 New macros, so that the caller can use some names other than
13996 gcpro1, gcpro2, etc.
13997 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13998 of the new macros.
13999 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14000 argument, for consistency with GCPRO2_VAR, etc: it is now the
14001 prefix of the variable, not the variable itself. All uses
14002 changed.
38b2c076
PE
14003 * dired.c (directory_files_internal, file_name_completion):
14004 Rename locals to avoid shadowing.
14005
15206ed9
PE
14006 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14007 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14008 dired.c's scmp function, had undefined behavior.
14009 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14010 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14011 * buffer.h: ... to here, because these macros use current_buffer,
14012 and the new implementation with inline functions needs to have
14013 current_buffer in scope now, rather than later when the macros
14014 are used.
14015 (downcase, upcase1): New static inline functions.
14016 (DOWNCASE, UPCASE1): Reimplement using these functions.
14017 This avoids undefined behavior in expressions like
14018 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14019 from race conditions in accessing the global variables
14020 case_temp1 and case_temp2.
14021 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14022 * lisp.h (case_temp1, case_temp2): Remove their decls.
14023 * character.h (ASCII_CHAR_P): Move from here ...
14024 * lisp.h: ... to here, so that the inline functions mentioned
14025 above can use them.
14026
4a6bea26
PE
14027 * dired.c (directory_files_internal_unwind): Now static.
14028
f14b7e14
PE
14029 * fileio.c (file_name_as_directory, directory_file_name):
14030 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14031 Now static.
2893f146
PE
14032 (file_name_as_directory): Use const pointers when appropriate.
14033 (Fexpand_file_name): Likewise. In particular, newdir might
14034 point at constant storage, so make it a const pointer.
fd4ead52 14035 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14036 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14037 signedness issues.
f839df0c
PE
14038 (Fset_file_times, Finsert_file_contents, auto_save_error):
14039 Rename locals to avoid shadowing.
f14b7e14 14040
5716756e 14041 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14042 (Ftry_completion, Fall_completions): Rename or remove locals
14043 to avoid shadowing.
5716756e 14044
b4c3046a
PE
14045 * marker.c (bytepos_to_charpos): Remove; unused.
14046
b45db522
PE
14047 * lisp.h (verify_bytepos, count_markers): New decls,
14048 so that gcc does not warn that these functions aren't declared.
14049
85876d07
PE
14050 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14051 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14052 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14053 (copy_text): Remove unused local var.
85876d07 14054
03d78a21 14055 * filelock.c (within_one_second): Now static.
b3dd38ab 14056 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14057
5df8f01b
PE
14058 * buffer.c (fix_overlays_before): Mark locals as initialized.
14059 (fix_start_end_in_overlays): Likewise. This function should be
14060 simplified by using pointers-to-pointers, but that's a different
14061 matter.
b1d876f1 14062 (switch_to_buffer_1): Now static.
8f54f30a
PE
14063 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14064 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14065
a70072c9 14066 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14067 Fix pointer signedness issue.
edced198
PE
14068 (sys_subshell): Mark local as volatile if checking for lint,
14069 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14070 (MAXPATHLEN): Define only if needed.
a70072c9 14071
a0977c44
PE
14072 * process.c (serial_open, serial_configure): Move decls from here ...
14073 * systty.h: ... to here, so that they can be checked.
14074
a884fdcc
PE
14075 * fns.c (get_random, seed_random): Move extern decls from here ...
14076 * lisp.h: ... to here, so that they can be checked.
14077
604efe86 14078 * sysdep.c (reset_io): Now static.
b8950c94 14079 (wait_for_termination_signal): Remove; unused.
604efe86 14080
38fc62d9
PE
14081 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14082 (copy_keymap_item, append_key, push_text_char_description):
14083 Now static.
1004a21a 14084 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14085 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14086 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14087 (describe_map_tree):
14088 Rename locals to avoid shadowing.
38fc62d9 14089
2f2650da
PE
14090 * keyboard.c: Declare functions static if they are not used elsewhere.
14091 (echo_char, echo_dash, cmd_error, top_level_2):
14092 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14093 (read_char, kbd_buffer_get_event, make_lispy_position):
14094 (make_lispy_event, make_lispy_movement, apply_modifiers):
14095 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14096 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14097 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14098 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14099 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14100
a053e86c 14101 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14102 (mark_kboards): Move decl here ...
14103 * alloc.c (mark_kboards): ... from here.
a053e86c 14104
4752793e
PE
14105 * lisp.h (force_auto_save_soon): New decl.
14106
74f10ca7 14107 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14108 (DEFINE_DUMMY_FUNCTION): New macro.
14109 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14110 Use it.
c03cd23f
PE
14111 (main): Add casts to avoid warnings
14112 if GCC considers string literals to be constants.
74f10ca7 14113
022e70d4
PE
14114 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14115
59d6fe83
PE
14116 * dbusbind.c: Pointer signedness fixes.
14117 (xd_signature, xd_append_arg, xd_initialize):
14118 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14119 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14120 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14121 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14122
78320123
PE
14123 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14124 if GCC considers string literals to be constants.
49cebcca 14125 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14126
35ac2a97
SM
141272011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14128
fb103ca9
SM
14129 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14130 (print_preprocess, print_object): New macro to fix last change.
14131
35ac2a97
SM
14132 * print.c (print_preprocess): Don't forget font objects.
14133
62973b41
JB
141342011-03-16 Juanma Barranquero <lekktu@gmail.com>
14135
14136 * emacs.c (USAGE3): Doc fixes.
14137
0e48bb22
AS
141382011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14139
14140 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14141 structure.
14142
7684e57b
JB
141432011-03-14 Juanma Barranquero <lekktu@gmail.com>
14144
14145 * lisp.h (VWindow_system, Qfile_name_history):
14146 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14147 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14148 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14149
14150 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14151 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14152
14153 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14154 * w32console.c (detect_input_pending, read_input_pending)
14155 (encode_terminal_code):
14156 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14157 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14158 (w32_system_caret_y, Qfile_name_history):
14159 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14160 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14161 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14162 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14163 * w32proc.c (Qlocal, report_file_error):
14164 * w32term.c (Vwindow_system, updating_frame):
14165 * w32uniscribe.c (initialized, uniscribe_font_driver):
14166 Remove unneeded extern declarations.
14167
2aa46d6c
CY
141682011-03-14 Chong Yidong <cyd@stupidchicken.com>
14169
c96bbc66 14170 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14171
cffc6f3b
CY
141722011-03-13 Chong Yidong <cyd@stupidchicken.com>
14173
14174 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14175 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14176 These macros can no longer be used for assignment.
14177
44f230aa
SM
14178 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14179 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14180 (record_buffer_markers, fetch_buffer_markers): New functions for
14181 recording and fetching special buffer markers.
14182 (set_buffer_internal_1, set_buffer_temp): Use them.
14183
14184 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14185
14186 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14187
14188 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14189 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14190
14191 * xdisp.c (hscroll_window_tree):
14192 (reconsider_clip_changes): Use PT instead of BUF_PT.
14193
d251f04b
EZ
141942011-03-13 Eli Zaretskii <eliz@gnu.org>
14195
14196 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14197 $(EMACS_ROOT)/lib/intprops.h.
14198
f0c77cd1
PE
141992011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14200
3eca4629
PE
14201 Fix more problems found by GCC 4.5.2's static checks.
14202
7c86ee98
PE
14203 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14204 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14205 (xg_free_frame_widgets): Make it clear that a local variable is
14206 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14207 (gdk_window_get_screen): Make it clear that this macro is needed
14208 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14209 (int_gtk_range_get_value): New function, which avoids a diagnostic
14210 from gcc -Wbad-function-cast.
14211 (xg_set_toolkit_scroll_bar_thumb): Use it.
14212 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14213 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14214 (get_utf8_string, xg_get_file_with_chooser):
14215 Rename locals to avoid shadowing.
14216 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14217
41729b81
PE
14218 * xgselect.c (xg_select): Remove unused var.
14219
f0c77cd1
PE
14220 * image.c (four_corners_best): Mark locals as initialized.
14221 (gif_load): Initialize transparent_p to zero (Bug#8238).
14222 Mark another local as initialized.
ec6cf4c6 14223 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14224
ce0ad53d 14225 * image.c (clear_image_cache): Now static.
d5d5a617 14226 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14227 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14228 (x_edge_detection): Remove unnecessary cast that
14229 gcc -Wbad-function-cast diagnoses.
2037898d 14230 (gif_load): Fix pointer signedness.
6ae141d6
PE
14231 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14232 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14233
33383987 142342011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14235
d32df629
PE
14236 Improve quality of tests for time stamp overflow.
14237 For example, without this patch (encode-time 0 0 0 1 1
14238 1152921504606846976) returns the obviously-bogus value (-948597
14239 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14240 reports time overflow. See
14241 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14242 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14243 * editfns.c: Include limits.h and intprops.h.
14244 (TIME_T_MIN, TIME_T_MAX): New macros.
14245 (time_overflow): Move earlier, to before first use.
14246 (hi_time, lo_time): New functions, for an accurate test for
14247 out-of-range times.
14248 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14249 (Fget_internal_run_time): Don't assume time_t fits in int.
14250 (make_time): Use list2 instead of Fcons twice.
14251 (Fdecode_time): More accurate test for out-of-range times.
14252 (check_tm_member): New function.
14253 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14254 (lisp_time_argument): Don't rely on undefined left-shift and
14255 right-shift behavior when checking for time stamp overflow.
8be6f318 14256
fe31d94c
PE
14257 * editfns.c (time_overflow): New function, refactoring common code.
14258 (Fformat_time_string, Fdecode_time, Fencode_time):
14259 (Fcurrent_time_string): Use it.
14260
8be6f318
PE
14261 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14262 * dired.c (make_time): Move to ...
14263 * editfns.c (make_time): ... here.
14264 * systime.h: Note the move.
14265
09d9db2c 142662011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14267
126bc0dc
YM
14268 * fringe.c (update_window_fringes): Remove unused variables.
14269
c47cbdfd
YM
14270 * unexmacosx.c (copy_data_segment): Also copy __got section.
14271 (Bug#8223)
14272
7ac80be9
EZ
142732011-03-12 Eli Zaretskii <eliz@gnu.org>
14274
c96bbc66 14275 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14276 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14277 Constify `char *' arguments and their references according to
14278 prototypes in tparam.h.
14279
ecb0f94d 14280 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14281
7ac80be9
EZ
14282 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14283 Adapt all references accordingly.
14284
14285 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14286
ef1fd07e
TT
142872011-03-11 Tom Tromey <tromey@redhat.com>
14288
14289 * buffer.c (syms_of_buffer): Remove obsolete comment.
14290
7ef4b50c
EZ
142912011-03-11 Eli Zaretskii <eliz@gnu.org>
14292
14293 * termhooks.h (encode_terminal_code): Declare prototype.
14294
14295 * msdos.c (encode_terminal_code): Don't declare prototype.
14296
14297 * term.c (encode_terminal_code): Now external again, used by
14298 w32console.c and msdos.c.
14299
44f230aa
SM
14300 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14301 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14302
4b1ec863 143032011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14304
1714f52b 14305 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14306
4b1ec863
PE
14307 * fringe.c (update_window_fringes): Mark locals as initialized
14308 (Bug#8227).
14309 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14310
524c7aa6
PE
14311 * alloc.c (mark_fringe_data): Move decl from here ...
14312 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14313 to check its interface.
14314 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14315
a5c0af81 14316 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14317 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14318 (fontset_font): Mark local as initialized.
a9a06e0b 14319 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14320
b4716021
PE
14321 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14322
811e9bac 14323 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14324 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14325 (x_own_selection, Fx_disown_selection_internal): Rename locals
14326 to avoid shadowing.
14327 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14328
7e3ab302
PE
14329 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14330 so that the caller can use some name other than gcpro1.
14331 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14332 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14333 (Fx_backspace_delete_keys_p):
14334 Use them to avoid shadowing, and rename vars to avoid shadowing.
14335 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14336 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14337 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14338 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14339 Remove unused locals.
7e3ab302
PE
14340 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14341 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14342 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14343 macros.
f78faa98 14344
e2b13473
PE
14345 * xterm.h (x_mouse_leave): New decl.
14346
77f23912
PE
14347 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14348 Remove unused functions.
cdf4ba58
PE
14349 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14350 (x_calc_absolute_position): Now static.
7411c686 14351 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14352 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14353 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14354 unless they are used.
38d0b34a
PE
14355 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14356 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14357 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14358 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14359 (x_error_catcher, x_connection_closed, x_error_handler):
14360 (x_error_quitter, xembed_send_message, x_iconify_frame):
14361 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14362 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14363 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14364
44f230aa
SM
14365 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14366 Rename or move locals to avoid shadowing.
6b463e58 14367 (tty_defined_color, merge_face_heights): Now static.
5967d051 14368 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14369 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14370 does not deduce is never used uninitialized.
73719eba
PE
14371 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14372 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14373
426994c3 14374 * terminal.c (store_terminal_param): Now static.
5489860b 14375
032f1620 14376 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14377 (set_frame_menubar): Remove unused local.
d4323972 14378 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14379 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14380 since they might point to immutable storage.
281585b0
PE
14381 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14382 since it's unused otherwise.
032f1620 14383
367c19e5 14384 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14385 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14386 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14387 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14388 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14389 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14390 does not deduce are never used uninitialized.
70739cbe 14391
07b48fa9
PE
14392 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14393
8868a238 14394 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14395 * window.c (window_loop, size_window):
14396 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14397
7e5cf297 14398 * window.c (display_buffer): Now static.
d6550a9f
PE
14399 (size_window): Mark variables that gcc -Wuninitialized
14400 does not deduce are never used uninitialized.
a586633d
PE
14401 * window.h (check_all_windows): New decl, to forestall
14402 gcc -Wmissing-prototypes diagnostic.
5b555da1 14403 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14404
f6095868
PE
14405 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14406 shadowing.
14407 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14408 Include <limits.h>.
14409 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14410 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14411 (load_charset_map): Mark variables that gcc -Wuninitialized
14412 does not deduce are never used uninitialized.
53df7c11 14413 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14414
f38b440c
PE
14415 * coding.c (coding_set_source, coding_set_destination):
14416 Use "else { /* comment */ }" rather than "else /* comment */;"
14417 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14418 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14419 a block, when the outer 'i' will do.
14420 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14421 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14422 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14423 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14424 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14425 Rename locals to avoid shadowing.
14426 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14427 * coding.c (emacs_mule_char, encode_invocation_designation):
14428 Now static, since they're not used elsewhere.
413bb2db 14429 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14430 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14431 (decode_coding_emacs_mule): Mark variables that gcc
14432 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14433 (detect_coding_iso_2022): Initialize a local variable that might
14434 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14435 this initialization is needed. (Bug#8211)
5f58e762
PE
14436 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14437 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14438 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14439 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14440 Remove unused macros.
f38b440c 14441
232b38b9 14442 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14443 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14444 * character.c (string_count_byte8): Likewise.
232b38b9 14445
fb90da1b
PE
14446 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14447 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14448
fb93dbc2
PE
14449 * chartab.c (copy_sub_char_table): Now static, since it's not used
14450 elsewhere.
5c156ace
PE
14451 (sub_char_table_ref_and_range, char_table_ref_and_range):
14452 Rename locals to avoid shadowing.
bbcd0949 14453 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14454
7d3b3862 14455 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14456 (BIDI_BOB): Remove unused macro.
7d3b3862 14457
6be7d3da
PE
14458 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14459 deduce are never used uninitialized.
c2ed9c8b 14460 * term.c (encode_terminal_code): Likewise.
6be7d3da 14461
75f8807f 14462 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14463
50938595
PE
14464 * tparam.h: New file.
14465 * term.c, tparam.h: Include it.
14466 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14467 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14468 Move these decls to tparam.h, and make them agree with what
14469 is actually in tparam.c. The previous trick of using incompatible
14470 decls in different modules does not conform to the C standard.
14471 All callers of tparam changed to use tparam's actual API.
14472 * tparam.c (tparam1, tparam, tgoto):
14473 Use const pointers where appropriate.
14474
fbceeba2
PE
14475 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14476 * cm.h (struct cm): Likewise.
14477 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14478 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14479 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14480 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14481 (turn_on_face, init_tty): Likewise.
14482 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14483
7f3f1250
PE
14484 * term.c (term_mouse_position): Rename local to avoid shadowing.
14485
e6ca6543
PE
14486 * alloc.c (mark_ttys): Move decl from here ...
14487 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14488
c40f8d15
AS
144892011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14490
14491 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14492
cfe0661d
JB
144932011-03-09 Juanma Barranquero <lekktu@gmail.com>
14494
14495 * search.c (compile_pattern_1): Remove argument regp, unused since
14496 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14497 (compile_pattern): Don't pass it.
14498
0afb4571
J
144992011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14500
14501 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14502 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14503 for ! HAVE_GTK3.
14504 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14505
14506 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14507
14508 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14509 gdk_window_get_screen, gdk_window_get_geometry,
14510 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14511 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14512 (xg_get_pixbuf_from_pixmap): New function.
14513 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14514 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14515 Call xg_get_pixbuf_from_pixmap instead of
14516 gdk_pixbuf_get_from_drawable.
14517 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14518 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14519 (xg_check_special_colors): Use GtkStyleContext and its functions
14520 for HAVE_GTK3.
14521 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14522 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14523 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14524 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14525 Call gtk_widget_get_preferred_size.
0afb4571
J
14526 (xg_frame_resized): gdk_window_get_geometry only takes 5
14527 parameters.
44f230aa
SM
14528 (xg_win_to_widget, xg_event_is_for_menubar):
14529 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14530 (xg_set_widget_bg): New function.
14531 (delete_cb): New function.
895009e1 14532 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14533 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14534 (xg_set_background_color): Call xg_set_widget_bg.
14535 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14536 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14537 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14538 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14539 if ! HAVE_GTK3.
14540 (update_frame_tool_bar): Call gtk_widget_hide.
14541 (xg_initialize): Use GDK_KEY_g.
14542
14543 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14544 if ! HAVE_GTK3
14545 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14546
14547 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14548 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14549 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14550
1c2cc4ef
JB
145512011-03-08 Juanma Barranquero <lekktu@gmail.com>
14552
14553 * w32xfns.c (select_palette): Check success of RealizePalette against
14554 GDI_ERROR, not zero.
14555
33383987 14556See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14557
14558;; Local Variables:
14559;; coding: utf-8
aac0c6e3
MR
14560;; End:
14561
2f097256 14562 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14563
14564 This file is part of GNU Emacs.
14565
14566 GNU Emacs is free software: you can redistribute it and/or modify
14567 it under the terms of the GNU General Public License as published by
14568 the Free Software Foundation, either version 3 of the License, or
14569 (at your option) any later version.
14570
14571 GNU Emacs is distributed in the hope that it will be useful,
14572 but WITHOUT ANY WARRANTY; without even the implied warranty of
14573 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14574 GNU General Public License for more details.
14575
14576 You should have received a copy of the GNU General Public License
14577 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.