* window.c (size_window): Avoid needless test at loop start.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
78eb494e
PE
12011-05-11 Paul Eggert <eggert@cs.ucla.edu>
2
3 * window.c (size_window): Avoid needless test at loop start.
4
2f142cc5
JB
52011-05-10 Juanma Barranquero <lekktu@gmail.com>
6
7 * image.c (Finit_image_library): Return t for built-in image types,
8 like pbm and xbm. (Bug#8640)
9
57679c86
AS
102011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11
12 * w32menu.c (set_frame_menubar): Fix submenu allocation.
13
888c9e86
EZ
142011-05-07 Eli Zaretskii <eliz@gnu.org>
15
b0512a1d
EZ
16 * w32console.c (Fset_screen_color): Doc fix.
17 (Fget_screen_color): New function.
18 (syms_of_ntterm): Defsubr it.
19
888c9e86
EZ
20 * callproc.c (call_process_cleanup): Don't close and unlink the
21 temporary file if Fcall_process didn't create it in the first
22 place.
23 (Fcall_process): Don't create tempfile if stdout of the child
24 process will be redirected to a file specified with `:file'.
25 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
26 cue to call_process_cleanup not to close that handle.
27
4d3fcc8e
BK
282011-05-07 Ben Key <bkey76@gmail.com>
29
30 * makefile.w32-in: The bootstrap-temacs rule now makes use of
31 one of two shell specific rules, either bootstrap-temacs-CMD or
32 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
33 to the previous implementation of the bootstrap-temacs rule.
34 The bootstrap-temacs-CMD rule is similar to the previous
35 implementation of the bootstrap-temacs rule except that it
36 makes use of the ESC_CFLAGS variable instead of the CFLAGS
37 variable.
38
39 These changes, along with some changes to nt/configure.bat,
40 nt/gmake.defs, and nt/nmake.defs, are required to extend my
41 earlier fix to add support for --cflags and --ldflags options
42 that include quotes so that it works whether make uses cmd or
43 sh as the shell.
44
b4289b64
MA
452011-05-06 Michael Albinus <michael.albinus@gmx.de>
46
47 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
48 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
49 is a constant.
50 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
51 a string. Handle both cases.
52 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
53 (Fdbus_register_method): Use Qinvalid_function.
54
af4c0e28
JB
552011-05-06 Juanma Barranquero <lekktu@gmail.com>
56
57 * makefile.w32-in: Update dependencies.
58 (LISP_H): Add inttypes.h and stdin.h.
59 (PROCESS_H): Add unistd.h.
60
c51453d9
EZ
612011-05-06 Eli Zaretskii <eliz@gnu.org>
62
63 * lread.c: Include limits.h (fixes the MS-Windows build broken by
64 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
65
8ff0ac3c 662011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 67
4c4b566b
PE
68 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
69
aab2b9b5
PE
70 * term.c (vfatal): Remove stray call to va_end.
71 It's not needed and the C Standard doesn't allow it here anyway.
72
c378da0b
PE
73 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
74 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
75
288b08c7
PE
76 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
77 bytes.
78
e3601888
PE
79 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
80
db6c0e74
PE
81 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
82
dd5963ea
PE
83 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
84
88c9450f
PE
85 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
86
2f9442b8
PE
87 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
88
c032b5f8
PE
89 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
90 * charset.c (Fdefine_charset_internal): Don't initialize
91 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 92 32-bit int (Bug#8600).
a108c10b
PE
93
94 * lread.c (read_integer): Be more consistent with string-to-number.
95 Use string_to_number to do the actual conversion; this avoids
96 rounding errors and fixes some other screwups. Without this fix,
97 for example, #x1fffffffffffffff was misread as -2305843009213693952.
98 (digit_to_number): Move earlier, for benefit of read_integer.
99 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 100 not a digit in any supported base. (Bug#8602)
a108c10b 101
ad5f9eea
PE
102 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
103
aec1708a
PE
104 * dispnew.c (scrolling_window): Return 1 if we scrolled,
105 to match comment at start of function. This also removes a
106 GCC warning about overflow in a 32+64-bit port.
107
47be4ab5
PE
108 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
109
371cac43
PE
110 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
111 Reported by Stefan Monnier in
112 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
113 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
114 SYMBOLP-guarded XSYMBOL, not XPNTR.
115
d01a7826
PE
116 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
117 (EMACS_UINTPTR): Likewise, with uintptr_t.
118
7fd47d5c
PE
119 * lisp.h: Prefer 64-bit EMACS_INT if available.
120 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
121 on 32-bit hosts that have 64-bit int, so that they can access
122 large files.
122b0c86
PE
123 However, temporarily disable this change unless the temporary
124 symbol WIDE_EMACS_INT is defined.
7fd47d5c 125
8727937b
PE
126 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
127
8ac068ac
PE
128 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
129 This removes an assumption that EMACS_INT and long are the same
130 width as pointers. The assumption is true for Emacs porting targets
131 now, but we want to make other targets possible.
132 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
133 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
134 In the rest of the code, change types of integers that hold casted
135 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
136 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
137 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
138 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
139 No need to cast type when ORing.
140 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
141 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
142 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
143 assume EMACS_INT is the same width as char *.
144 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
145 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
146 Remove no-longer-needed casts.
147 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
148 (xg_tool_bar_help_callback, xg_make_tool_item):
149 Use EMACS_INTPTR to hold an integer
150 that will be cast to void *; this can avoid a GCC warning
151 if EMACS_INT is not the same width as void *.
152 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
153 * xdisp.c (display_echo_area_1, resize_mini_window_1):
154 (current_message_1, set_message_1):
155 Use a local to convert to proper width without a cast.
156 * xmenu.c (dialog_selection_callback): Likewise.
157
ede49d71
PE
158 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
159 Also, don't assume VALBITS / RAND_BITS is less than 5,
160 and don't rely on undefined behavior when shifting a 1 left into
161 the sign bit.
162 * lisp.h (get_random): Change signature to match.
163
2f30ecd0
PE
164 * lread.c (hash_string): Use size_t, not int, for hash computation.
165 Normally we prefer signed values; but hashing is special, because
166 it's better to use unsigned division on hash table sizes so that
167 the remainder is nonnegative. Also, size_t is the natural width
168 for hashing into memory. The previous code used 'int', which doesn't
169 retain enough info to hash well into very large tables.
170 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
171
2a866e7b
PE
172 * dbusbind.c: Don't possibly lose pointer info when converting.
173 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
174 Use XPNTR rather than XHASH, so that the high-order bits of
175 the pointer aren't lost when converting through void *.
176
51639eac
PE
177 * eval.c (Fautoload): Don't double-shift a pointer.
178
92394119
PE
179 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
180
dbdb9a7c
JB
1812011-05-06 Juanma Barranquero <lekktu@gmail.com>
182
183 * gnutls.c (DEF_GNUTLS_FN):
184 * image.c (DEF_IMGLIB_FN): Make function pointers static.
185
db7a0b4f
AS
1862011-05-05 Andreas Schwab <schwab@linux-m68k.org>
187
188 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
189 marker. (Bug#8610)
190
f7ff1b0f 1912011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
192
193 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
194 New version that can reserve upto 2GB of heap space.
195
f7ff1b0f 1962011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
197
198 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
199
639c109b
TZ
2002011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
201
202 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
203 `gnutls_certificate_set_x509_key_file'.
204
d2127135
JB
2052011-05-05 Juanma Barranquero <lekktu@gmail.com>
206
207 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
208 Update dependencies.
209
e968f4f3
JB
2102011-05-04 Juanma Barranquero <lekktu@gmail.com>
211
212 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
213 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
214 Remove unused parameter `fildes'.
215 * process.c (read_process_output, send_process): Don't pass it.
216
84d358f0
JB
2172011-05-04 Juanma Barranquero <lekktu@gmail.com>
218
219 Fix previous change: the library cache is defined in w32.c.
220 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
221 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
222
0898ca10
JB
2232011-05-04 Juanma Barranquero <lekktu@gmail.com>
224
225 Implement dynamic loading of GnuTLS on Windows.
226
227 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
228 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
229 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
230 Declare.
231
232 * gnutls.c (Qgnutls_dll): Define.
233 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
234 (gnutls_*): Declare function pointers.
235 (init_gnutls_functions): New function to initialize function pointers.
236 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
237 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
238 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
239 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
240 (emacs_gnutls_write, emacs_gnutls_read)
241 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
242 (Fgnutls_available_p): New function.
243 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
244 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
245 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
246
247 * image.c: Include w32.h.
248 (Vimage_type_cache): Delete.
249 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
250 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
251 (w32_delayed_load): Move to w32.c.
252
253 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
254
255 * w32.c (QCloaded_from, Vlibrary_cache): Define.
256 (w32_delayed_load): Move from image.c. When loading a library, record
257 its filename in the :loaded-from property of the library id.
258 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
259 Initialize and staticpro them.
260 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
261
262 * process.c: Include lisp.h before w32.h, not after.
263 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
264 instead of gnutls_record_check_pending.
265
266 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
267
ff4de4aa
TZ
2682011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
269
270 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
271 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
272 as passed in.
273
abe95abb
JD
2742011-05-03 Jan Djärv <jan.h.d@swipnet.se>
275
276 * xterm.c (x_set_frame_alpha): Do not set property on anything
277 else than FRAME_X_OUTER_WINDOW (Bug#8608).
278
e16e55d4
JB
2792011-05-02 Juanma Barranquero <lekktu@gmail.com>
280
281 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
282
bafcf6a5
JB
2832011-05-02 Juanma Barranquero <lekktu@gmail.com>
284
285 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
286 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
287 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
288 (gnutls_global_initialized, Qgnutls_bootprop_priority)
289 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
290 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
291 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
292 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
293 (Qgnutls_bootprop_callbacks_verify): Make static.
294
e7a6747f
AS
2952011-05-01 Andreas Schwab <schwab@linux-m68k.org>
296
19ed11ba
AS
297 * callproc.c: Indentation fixup.
298
e7a6747f
AS
299 * sysdep.c (wait_for_termination_1): Make static.
300 (wait_for_termination, interruptible_wait_for_termination): Move
301 after wait_for_termination_1.
302
1ef14cb4
LMI
3032011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
304
305 * sysdep.c (interruptible_wait_for_termination): New function
306 which is like wait_for_termination, but allows keyboard
307 interruptions.
308
309 * callproc.c (Fcall_process): Add (:file "file") as an option for
310 the STDOUT buffer.
311 (Fcall_process_region): Ditto.
312
330d880c
EZ
3132011-04-30 Eli Zaretskii <eliz@gnu.org>
314
8db90b73
EZ
315 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
316 rather than `XVECTOR (FOO)->size'.
317
330d880c
EZ
318 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
319 inttypes.h, as a gnulib replacement is used if it not available in
320 system headers.
321
15cbd324
EZ
3222011-04-21 Eli Zaretskii <eliz@gnu.org>
323
324 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
325 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
326 of MOST_POSITIVE_FIXNUM. (Bug#8528)
327
328 * coding.c (coding_alloc_by_realloc): Error out if destination
329 will grow beyond MOST_POSITIVE_FIXNUM.
330 (decode_coding_emacs_mule): Abort if there isn't enough place in
331 charbuf for the composition carryover bytes. Reserve an extra
332 space for up to 2 characters produced in a loop.
333 (decode_coding_iso_2022): Abort if there isn't enough place in
334 charbuf for the composition carryover bytes.
335
3362011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 337
ae940cca
EZ
338 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
339 aborting when %lld or %lll format is passed.
340 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
341 %llo or %llx format is passed. (Bug#8545)
342
03ab8921
EZ
343 * window.c (window_scroll_line_based): Use a marker instead of
344 simple variables to record original value of point. (Bug#7952)
345
afda1437
EZ
346 * doprnt.c (doprnt): Fix the case where a multibyte sequence
347 produced by %s or %c overflows available buffer space. (Bug#8545)
348
f76dee0c
PE
3492011-04-28 Paul Eggert <eggert@cs.ucla.edu>
350
351 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 352 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 353
fdc5744d
JB
3542011-04-28 Juanma Barranquero <lekktu@gmail.com>
355
356 * w32.c (init_environment): Warn about defaulting HOME to C:\.
357
638f053a
JB
3582011-04-28 Juanma Barranquero <lekktu@gmail.com>
359
360 * keyboard.c (Qdelayed_warnings_hook): Define.
361 (command_loop_1): Run `delayed-warnings-hook'
362 if Vdelayed_warnings_list is non-nil.
363 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
364 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
365
d178f871
EZ
3662011-04-28 Eli Zaretskii <eliz@gnu.org>
367
368 * doprnt.c (doprnt): Don't return value smaller than the buffer
369 size if the message was truncated. (Bug#8545).
370
b124fd93
JB
3712011-04-28 Juanma Barranquero <lekktu@gmail.com>
372
373 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
374 (Fx_window_property): #if-0 the whole functions, not just the bodies.
375
e810457d
PE
3762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
377
378 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
379
ea51cceb
JB
3802011-04-27 Juanma Barranquero <lekktu@gmail.com>
381
382 * makefile.w32-in: Update dependencies.
383
94dcfacf
EZ
3842011-04-27 Eli Zaretskii <eliz@gnu.org>
385
386 Improve `doprnt' and its usage. (Bug#8545)
387 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
388 `format_end'. Remove support for %l as a conversion specifier.
389 Don't use xrealloc. Improve diagnostics when the %l size modifier
390 is used. Update the commentary.
391
392 * eval.c (verror): Simplify calculation of size_t.
393
394 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
395 messages.
396
f61f41d7
PE
3972011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
398
399 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
400 change.
401
96fb4434
PE
4022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
403
404 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
405 This makes this file independent of the recent pseudovector change.
406
671875da 4072011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 408
69e9b5a3
PE
409 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
410
b5f869a7 411 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 412 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 413 Remove unused local.
c8926152 414 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 415
841a1577 416 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
417 GCC 4.6.0 optimizes based on type-based alias analysis. For
418 example, if b is of type struct buffer * and v of type struct
419 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
420 != &v->size, and therefore "v->size = 1; b->size = 2; return
421 v->size;" must therefore return 1. This assumption is incorrect
422 for Emacs, since it type-puns struct Lisp_Vector * with many other
423 types. To fix this problem, this patch adds a new type struct
f904488f 424 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
425 and pseudovectors, and helps optimizing compilers not get fooled
426 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
427 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
428 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
429 the size member.
eab3844f
PE
430 (XSETPVECTYPE): Rewrite in terms of new macro.
431 (XSETPVECTYPESIZE): New macro, specifying both type and size.
432 This is a bit clearer, and further avoids the possibility of
433 undesirable aliasing.
434 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 435 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
436 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
437 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
438 (ASIZE): Now uses header.size rather than size. All
439 previous uses of XVECTOR (foo)->size replaced to use this macro,
440 to avoid the hassle of writing XVECTOR (foo)->header.size.
441 (struct vectorlike_header): New type.
eab3844f
PE
442 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
443 object, to help avoid aliasing.
444 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
445 (SUBRP): Likewise, since Lisp_Subr is a special case.
446 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
447 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
448 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 449 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
450 changed to be "header.size" and "header.next".
451 * buffer.h (struct buffer): Likewise.
452 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
453 * frame.h (struct frame): Likewise.
454 * process.h (struct Lisp_Process): Likewise.
455 * termhooks.h (struct terminal): Likewise.
456 * window.c (struct save_window_data, struct saved_window): Likewise.
457 * window.h (struct window): Likewise.
458 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
459 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
460 * buffer.c (init_buffer_once): Likewise.
461 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
462 special case.
463 * process.c (Fformat_network_address): Use local var for size,
464 for brevity.
465
0df1eac5
PE
466 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
467
847ab9d1 468 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
469 * data.c (atof): Remove decl; no longer used or needed.
470 (digit_to_number): Move to lread.c.
471 (Fstring_to_number): Use new string_to_number function, to be
472 consistent with how the Lisp reader treats infinities and NaNs.
473 Do not assume that floating-point numbers represent EMACS_INT
474 without losing information; this is not true on most 64-bit hosts.
475 Avoid double-rounding errors, by insisting on integers when
476 parsing non-base-10 numbers, as the documentation specifies.
477 * lisp.h (string_to_number): New decl, replacing ...
478 (isfloat_string): Remove.
bc0a5c13 479 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 480 (read1): Do not accept +. and -. as integers; this
452f4150
PE
481 appears to have been a coding error. Similarly, do not accept
482 strings like +-1e0 as floating point numbers. Do not report
483 overflow for integer overflows unless the base is not 10 which
484 means we have no simple and reliable way to continue.
485 Break out the floating-point parsing into a new
486 function string_to_number, so that Fstring_to_number parses
487 floating point numbers consistently with the Lisp reader.
488 (digit_to_number): Moved here from data.c. Make it static inline.
489 (E_CHAR, EXP_INT): Remove, replacing with ...
490 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
491 (string_to_number): New function, replacing isfloat_string.
492 This function checks for valid syntax and produces the resulting
493 Lisp float number too. Rework it so that string-to-number
bc0a5c13 494 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
495 so that overflow for non-base-10 numbers is reported only when
496 there's no portable and simple way to convert to floating point.
452f4150 497
67769ffc
PE
498 * textprop.c (set_text_properties_1): Rewrite for clarity,
499 and to avoid GCC warning about integer overflow.
500
c20db43f
PE
501 * intervals.h (struct interval): Use EMACS_INT for members
502 where EMACS_UINT might cause problems. See
503 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
504 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
505 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
506 All uses changed.
37aa2f85
PE
507 (offset_intervals): Tell GCC not to worry about length overflow
508 when negating a negative length.
c20db43f 509
2538aa2f
PE
510 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
511 (overrun_check_free): Likewise.
512
f2d3008d
PE
513 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
514 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
515 word size.
516
ec8df744
PE
517 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
518 (gnutls_make_error): Rename local to avoid shadowing.
519 (gnutls_emacs_global_deinit): ifdef out; not used.
520 (Fgnutls_boot): Use const for pointer to readonly storage.
521 Comment out unused local. Fix pointer signedness problems.
522
640ee02d
PE
523 * lread.c (openp): Don't stuff size_t into an 'int'.
524 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
525 about possible signed overflow.
526
6048fb2a
PE
527 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
528 (GDK_KEY_g): Don't define if already defined.
529 (xg_prepare_tooltip): Avoid pointer signedness problem.
530 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
531
fa3c87e1
PE
532 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
533 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
534
2172544b
PE
535 * xfns.c (Fx_window_property): Simplify a bit,
536 to make a bit faster and to avoid GCC 4.6.0 warning.
537 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
538
9b821a21
PE
539 * fns.c (internal_equal): Don't assume size_t fits in int.
540
3c616cfa
PE
541 * alloc.c (compact_small_strings): Tighten assertion a little.
542
c2982e87
PE
543 Replace pEd with more-general pI, and fix some printf arg casts.
544 * lisp.h (pI): New macro, generalizing old pEd macro to other
545 conversion specifiers. For example, use "...%"pI"d..." rather
546 than "...%"pEd"...".
547 (pEd): Remove. All uses replaced with similar uses of pI.
548 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
549 * alloc.c (check_pure_size): Don't overflow by converting size to int.
550 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
551 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
552 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
553 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
554 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
555 64-bit hosts.
556 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
557 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
558 * print.c (safe_debug_print, print_object): Likewise.
559 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
560 to int.
6f04d126
PE
561 Use pI instead of if-then-else-abort. Use %p to avoid casts,
562 avoiding the 0 flag, which is not portable.
c2982e87
PE
563 * process.c (Fmake_network_process): Use pI to avoid cast.
564 * region-cache.c (pp_cache): Likewise.
565 * xdisp.c (decode_mode_spec): Likewise.
566 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
567 behavior on 64-bit hosts with printf arg.
6f04d126 568 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
569 (x_stop_queuing_selection_requests): Likewise.
570 (x_get_window_property): Don't truncate byte count to an 'int'
571 when tracing.
0b432f21 572
5e073ec7
PE
573 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
574 here, since it parses constructs like leading '-' and spaces,
575 which are not wanted; and it overflows with large numbers.
576 Instead, simply match F[0-9]+, which is what is wanted anyway.
577
36372bf9
PE
578 * alloc.c: Remove unportable assumptions about struct layout.
579 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
580 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
581 (allocate_vectorlike, make_pure_vector): Use the new macros,
582 plus offsetof, to remove unportable assumptions about struct layout.
583 These assumptions hold on all porting targets that I know of, but
584 they are not guaranteed, they're easy to remove, and removing them
585 makes further changes easier.
586
0b432f21
PE
587 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
588 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
589 (string_overrun_cookie): Now const. Use initializers that
590 don't formally overflow signed char, to avoid warnings.
000098c1
PE
591 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
592 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
593 (allocate_buffer): Don't assume sizeof (struct buffer) is a
594 multiple of sizeof (EMACS_INT); it need not be, if
595 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 596 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 597
895009e1
JB
5982011-04-26 Juanma Barranquero <lekktu@gmail.com>
599
600 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
601
6a7a1b0b
TZ
6022011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
603
604 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 605 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
606 Reported by Paul Eggert <eggert@cs.ucla.edu>.
607
841a1577 6082011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
609
610 * lisp.h (Qdebug): List symbol.
895009e1 611 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
612 * keyboard.c (debug-on-event): New variable.
613 (handle_user_signal): Break into debugger when debug-on-event
614 matches the current signal symbol.
615
f2d3ba6f
DN
6162011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
617
618 * alloc.c (check_sblock, check_string_bytes)
619 (check_string_free_list): Convert to standard C.
620
42ce4c63
TZ
6212011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
622
623 * w32.c (emacs_gnutls_push): Fix typo.
624
825cd63c
EZ
6252011-04-25 Eli Zaretskii <eliz@gnu.org>
626
fb11d64d
EZ
627 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
628 "cast to pointer from integer of different size".
629
825cd63c
EZ
630 Improve doprnt and its use in verror. (Bug#8545)
631 * doprnt.c (doprnt): Document the set of format control sequences
632 supported by the function. Use SAFE_ALLOCA instead of always
633 using `alloca'.
634
635 * eval.c (verror): Don't limit the buffer size at size_max-1, that
636 is one byte too soon. Don't use xrealloc; instead xfree and
637 xmalloc anew.
638
e061a11b
TZ
6392011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
640
641 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
642 callbacks stage.
643
644 * gnutls.c: Renamed global_initialized to
645 gnutls_global_initialized. Added internals for the
646 :verify-hostname-error, :verify-error, and :verify-flags
647 parameters of `gnutls-boot' and documented those parameters in the
648 docstring. Start callback support.
649 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
650 unless a fatal error occured. Call gnutls_alert_send_appropriate
651 on error. Return error code.
652 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
653 (emacs_gnutls_read): Likewise.
654 (Fgnutls_boot): Return handshake error code.
655 (emacs_gnutls_handle_error): New function.
656 (wsaerror_to_errno): Likewise.
657
658 * w32.h (emacs_gnutls_pull): Add prototype.
659 (emacs_gnutls_push): Likewise.
660
661 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
662 (emacs_gnutls_push): Likewise.
663
6642011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
665
666 * process.c (wait_reading_process_output): Check if GnuTLS
667 buffered some data internally if no FDs are set for TLS
668 connections.
669
670 * makefile.w32-in (OBJ2): Add gnutls.$(O).
671 (LIBS): Link to USER_LIBS.
672 ($(BLD)/gnutls.$(0)): New target.
673
fa6996bc
EZ
6742011-04-24 Eli Zaretskii <eliz@gnu.org>
675
eb35682e
EZ
676 * xdisp.c (handle_single_display_spec): Rename the
677 display_replaced_before_p argument into display_replaced_p, to
678 make it consistent with the commentary. Fix typos in the
679 commentary.
680
e2ad650c
EZ
681 * textprop.c (syms_of_textprop): Remove dead code.
682 (copy_text_properties): Delete obsolete commentary about an
683 interface that was deleted long ago. Fix typos in the description
684 of arguments.
685
1b2de274
EZ
686 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
687 to changes in oldXMenu/XMenu.h from 2011-04-16.
688 <menu_help_message, prev_menu_help_message>: Constify.
689 (IT_menu_make_room): menu->help_text is now `const char **';
690 adjust.
691
692 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
693 to changes in oldXMenu/XMenu.h from 2011-04-16.
694 (struct XMenu): Declare `help_text' `const char **'.
695
696 * xfaces.c <Qunspecified>: Make extern again.
697
698 * syntax.c: Include sys/types.h before including regex.h, as
699 required by Posix.
700
762b15be
EZ
701 * doc.c (get_doc_string): Improve the format passed to `error'.
702
703 * doprnt.c (doprnt): Improve commentary.
704
705 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
706
707 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
708 them with etags.
709
f1052e5d
EZ
710 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
711 changes in globals.h immediately force recompilation.
762b15be
EZ
712 (TAGS): Depend on $(CURDIR)/m/intel386.h and
713 $(CURDIR)/s/ms-w32.h.
714 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 715
fa6996bc
EZ
716 * character.c (Fchar_direction): Function deleted.
717 (syms_of_character): Don't defsubr it.
718 <char-direction-table>: Deleted.
719
e6c3da20
EZ
7202011-04-23 Eli Zaretskii <eliz@gnu.org>
721
722 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
723 * doprnt.c: Include limits.h.
724 (SIZE_MAX): New macro.
725 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
726 local variables are now size_t instead of int or unsigned.
727 Improve overflow protection. Support `l' modifier for integer
728 conversions. Support %l conversion. Don't assume an EMACS_INT
729 argument for integer conversions and for %c.
730
731 * lisp.h (doprnt): Restore prototype.
732
733 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
734 $(SRC)/character.h.
735
736 * Makefile.in (base_obj): Add back doprnt.o.
737
738 * deps.mk (doprnt.o): Add back prerequisites.
739 (callint.o): Depend on character.h.
740
741 * eval.c (internal_lisp_condition_case): Include the handler
742 representation in the error message.
743 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
744 when breaking from the loop.
745
746 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
747
748 * callint.c (Fcall_interactively): When displaying error message
749 about invalid control letter, pass the character's codepoint, not
750 a pointer to its multibyte form. Improve display of the character
751 in octal and display also its hex code.
752
753 * character.c (char_string): Use %x to display the (unsigned)
754 codepoint of an invalid character, to avoid displaying a bogus
755 negative value.
756
757 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
758 `error', not SYMBOL_NAME itself.
759
760 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
761 character arguments to `error'.
762
763 * charset.c (check_iso_charset_parameter): Fix incorrect argument
764 to `error' in error message about FINAL_CHAR argument. Make sure
765 FINAL_CHAR is a character, and use %c when it is passed as
766 argument to `error'.
767
4ffd0d6b 7682011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
769
770 * s/ms-w32.h (localtime): Redirect to sys_localtime.
771
772 * w32.c: Include <time.h>.
773 (sys_localtime): New function.
774
4ffd0d6b 7752011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
776
777 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
778
4ffd0d6b 779 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 780
4ffd0d6b 7812011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 782
4ffd0d6b
GM
783 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
784 zombies (Bug#8467).
aac0c6e3 785
04c56954
EZ
7862011-04-19 Eli Zaretskii <eliz@gnu.org>
787
788 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
789 gl_state.e_property when gl_state.object is Qt.
790
791 * insdel.c (make_gap_larger): Remove limitation of buffer size
792 to <= INT_MAX.
793
16a43933
CY
7942011-04-18 Chong Yidong <cyd@stupidchicken.com>
795
796 * xdisp.c (lookup_glyphless_char_display)
797 (produce_glyphless_glyph): Handle cons cell entry in
798 glyphless-char-display.
799 (Vglyphless_char_display): Document it.
800
801 * term.c (produce_glyphless_glyph): Handle cons cell entry in
802 glyphless-char-display.
803
4581706e
CY
8042011-04-17 Chong Yidong <cyd@stupidchicken.com>
805
806 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
807
808 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
809
810 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
811 definition for no-X builds.
812
4887c6e2 8132011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 814
fd35b6f9
PE
815 Static checks with GCC 4.6.0 and non-default toolkits.
816
5c1ccb01
PE
817 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
818
006c5daa
PE
819 * process.c (keyboard_bit_set): Define only if SIGIO.
820 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
821 (send_process): Repair possible setjmp clobbering.
822
efc736d3
PE
823 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
824
4e2fe2e6
PE
825 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
826
f97334a2
PE
827 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
828
4e75f29d
PE
829 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
830 Define only if needed.
831
90efadd1
PE
832 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
833 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 834 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 835
3c647824
PE
836 * dispextern.h (struct redisplay_interface): Rename param
837 to avoid shadowing.
e264f262 838 * termhooks.h (struct terminal): Likewise.
761383f4 839 * xterm.c (xembed_send_message): Likewise.
3c647824 840
b58c5c4a
PE
841 * insdel.c (make_gap_smaller): Define only if
842 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
843
cad59032
PE
844 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
845 it.
846
c339dc2e
PE
847 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
848 so that we aren't warned about unused symbols.
849
91a3e27b
PE
850 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
851
399c71d3 852 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 853
8ffc96f5
PE
854 * xfns.c (x_real_positions): Mark locals as initialized.
855
eef9bc79
PE
856 * xmenu.c (xmenu_show): Don't use uninitialized vars.
857
098db9dd
PE
858 * xterm.c: Fix problems found by static analysis with other toolkits.
859 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
860 (x_dispatch_event): Declare static if USE_GTK, and
861 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 862 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 863 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
864 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
865 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 866
eb18f6cc
PE
867 * xmenu.c (menu_help_callback): Pointer type fixes.
868 Use const pointers when pointing at readonly data. Avoid pointer
869 signedness clashes.
870 (FALSE): Remove unused macro.
871 (update_frame_menubar): Remove unused decl.
872
1fe72bf8
PE
873 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
874
60d9e1db
PE
875 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
876 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
877 (single_menu_item): Rename local to avoid shadowing.
878
39261c26
PE
879 * keyboard.c (make_lispy_event): Remove unused local var.
880
018c5e19
PE
881 * frame.c, frame.h (x_get_resource_string): Bring this back, but
882 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
883
63d2b86e
PE
884 * bitmaps: Change bitmaps from unsigned char back to the X11
885 compatible char. Avoid the old compiler warnings about
886 out-of-range initializers by using, for example, '\xab' rather
887 than 0xab.
888
aefd87e1
PE
889 * xgselect.c (xgselect_initialize): Check vs interface
890 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
891
bf501fb9
PE
892 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
893
e9829fdf
PE
894 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
895 to read-only memory.
896
1086c095
PE
897 * fns.c (vector): Remove; this old hack is no longer needed.
898
2baccd04 899 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 900 Remove unused var.
dde42981 901 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 902
72391843 903 * xrdb.c (x_load_resources): Omit unused local.
3565b346 904
436c16df 905 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 906 (x_window): Rename locals to avoid shadowing.
dc5ddd85 907 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 908
92bb796d 909 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 910 (x_term_init): Remove local to avoid shadowing.
92bb796d 911
764430a3 912 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
913
914 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
915 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
916
d1dfb56c
EZ
9172011-04-16 Eli Zaretskii <eliz@gnu.org>
918
c4354cb4
EZ
919 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
920
d1dfb56c
EZ
921 Fix regex.c, syntax.c and friends for buffers > 2GB.
922 * syntax.h (struct gl_state_s): Declare character position members
923 EMACS_INT.
924
925 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
926
927 * textprop.c (verify_interval_modification, interval_of): Declare
928 arguments EMACS_INT.
929
930 * intervals.c (adjust_intervals_for_insertion): Declare arguments
931 EMACS_INT.
932
933 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
934
935 * indent.c (Fvertical_motion): Local variable it_start is now
936 EMACS_INT.
937
938 * regex.c (re_match, re_match_2, re_match_2_internal)
939 (bcmp_translate, regcomp, regexec, print_double_string)
940 (group_in_compile_stack, re_search, re_search_2, regex_compile)
941 (re_compile_pattern, re_exec): Declare arguments and local
942 variables `size_t' and `ssize_t' and return values `regoff_t', as
943 appropriate.
944 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
945 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
946 <compile_stack_type>: `size' and `avail' are now `size_t'.
947
948 * regex.h <regoff_t>: Use ssize_t, not int.
949 (re_search, re_search_2, re_match, re_match_2): Arguments that
950 specify buffer/string position and length are now ssize_t and
951 size_t. Return type is regoff_t.
952
613052cd
BK
9532011-04-16 Ben Key <bkey76@gmail.com>
954
955 * nsfont.m: Fixed bugs in ns_get_family and
956 ns_descriptor_to_entity that were caused by using free to
957 deallocate memory blocks that were allocated by xmalloc (via
958 xstrdup). This caused Emacs to crash when compiled with
959 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
960 --enable-checking=xmallocoverrun). xfree is now used to
961 deallocate these memory blocks.
962
4170f62f 9632011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 964
71b41406
PE
965 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
966
9587a89d
PE
967 emacs_write: Accept and return EMACS_INT for sizes.
968 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
969 et seq.
970 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
971 Accept and return EMACS_INT.
972 (emacs_gnutls_write): Return the number of bytes written on
973 partial writes.
974 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
975 (emacs_read, emacs_write): Remove check for negative size, as the
976 Emacs source code has been audited now.
9587a89d
PE
977 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
978 (emacs_read, emacs_write): Use it.
273a5f82
PE
979 * process.c (send_process): Adjust to the new signatures of
980 emacs_write and emacs_gnutls_write. Do not attempt to store
981 a byte offset into an 'int'; it might overflow.
9587a89d 982 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 983
3e047f51
PE
984 * sound.c: Don't assume sizes fit in 'int'.
985 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 986 Return EMACS_INT, not int.
3e047f51 987 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
988 Accept EMACS_INT, not int.
989 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
990 record read return values.
991
cc39a9db
BK
9922011-04-15 Ben Key <bkey76@gmail.com>
993
c9d0ec6d
JB
994 * keyboard.c (Qundefined): Don't declare static since it is used
995 in nsfns.m.
996 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
997 static since they are used in nsfont.m.
cc39a9db 998
6c60eb9f
SM
9992011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1000
1001 * process.c (Qprocessp): Don't declare static.
1002 * lisp.h (Qprocessp): Declare again.
1003
7990b61a
JB
10042011-04-15 Juanma Barranquero <lekktu@gmail.com>
1005
1006 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1007
5d4cb038
PE
10082011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1009
8bd7b830 1010 Improve C-level modularity by making more things 'static'.
cd64ea1d 1011
e3b27b31
PE
1012 Don't publish debugger-only interfaces to other modules.
1013 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1014 (verify_bytepos, count_markers): Move decls to the only modules
1015 that need them.
1016 * region-cache.h (pp_cache): Likewise.
1017 * window.h (check_all_windows): Likewise.
1018 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1019
5d4cb038
PE
1020 * sysdep.c (croak): Now static, if
1021 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1022 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1023
1024 * alloc.c (refill_memory_reserve): Now static if
1025 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1026 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1027
e87b6180
PE
1028 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1029 Define only if USE_LUCID.
1030
ac64929e
PE
1031 * xrdb.c (x_customization_string, x_rm_string): Now static.
1032
6f37259d
PE
1033 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1034 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1035
1683e3ab
PE
1036 * xdisp.c (draw_row_with_mouse_face): Now static.
1037 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1038
de9c2632
PE
1039 * window.h (check_all_windows): Mark externally visible.
1040
2b96acb7
PE
1041 * window.c (window_deletion_count): Now static.
1042
1043 * undo.c: Make symbols static if they're not exported.
1044 (last_undo_buffer, last_boundary_position, pending_boundary):
1045 Now static.
1046
50436f33
PE
1047 * textprop.c (interval_insert_behind_hooks): Now static.
1048 (interval_insert_in_front_hooks): Likewise.
1049
64520e5c
PE
1050 * term.c: Make symbols static if they're not exported.
1051 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1052 (max_frame_lines, tty_set_terminal_modes):
1053 (tty_reset_terminal_modes, tty_turn_off_highlight):
1054 (get_tty_terminal): Now static.
1055 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1056 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1057 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1058 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1059 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1060
1fa53021
PE
1061 * sysdep.c: Make symbols static if they're not exported.
1062 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1063 Now static.
1064 (sigprocmask_set, full_mask): Remove; unused.
1065 (wait_debugging): Mark as visible.
1066 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1067 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1068
d4b43b22
PE
1069 * syntax.c (syntax_temp): Define only if !__GNUC__.
1070
b7c513d0
PE
1071 * sound.c (current_sound_device, current_sound): Now static.
1072
989b29ad
PE
1073 * search.c (searchbufs, searchbuf_head): Now static.
1074
13a55a78
PE
1075 * scroll.c (scroll_cost): Remove; unused.
1076 * dispextern.h (scroll_cost): Remove decl.
1077
de68a1fc
PE
1078 * region-cache.h (pp_cache): Mark as externally visible.
1079
40ccffa6
PE
1080 * process.c: Make symbols static if they're not exported.
1081 (process_tick, update_tick, create_process, chan_process):
1082 (Vprocess_alist, proc_buffered_char, datagram_access):
1083 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1084 (deactivate_process): Mark defn as static, as well as decl.
1085 * lisp.h (create_process): Remove decl.
1086 * process.h (chan_process, Vprocess_alist): Remove decls.
1087
ad64fc97
PE
1088 * print.c: Make symbols static if they're not exported.
1089 (print_depth, new_backquote_output, being_printed, print_buffer):
1090 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1091 (print_interval, print_number_index, initial_stderr_stream):
1092 Now static.
1093 * lisp.h (Fprinc): Remove decl.
1094 (debug_output_compilation_hack): Mark as externally visible.
1095
adddb265
PE
1096 * sysdep.c (croak): Move decl from here to syssignal.h.
1097 * syssignal.h (croak): Put it here, so the API can be checked when
1098 'croak' is called from dissociate_if_controlling_tty.
1099
1717ede2
PE
1100 * minibuf.c: Make symbols static if they're not exported.
1101 (minibuf_save_list, choose_minibuf_frame): Now static.
1102 * lisp.h (choose_minibuf_frame): Remove decl.
1103
fa5fb2bc
PE
1104 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1105
1e3890d1
PE
1106 * lread.c: Make symbols static if they're not exported.
1107 (read_objects, initial_obarray, oblookup_last_bucket_number):
1108 Now static.
1109 (make_symbol): Remove; unused.
1110 * lisp.h (initial_obarray, make_symbol): Remove decls.
1111
8a1414fa
PE
1112 * keyboard.c: Make symbols static if they're not exported.
1113 (single_kboard, recent_keys_index, total_keys, recent_keys):
1114 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1115 (this_single_command_key_start, echoing, last_auto_save):
1116 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1117 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1118 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1119 (Vlispy_mouse_stem, double_click_count):
1120 Now static.
1121 (force_auto_save_soon): Define only if SIGDANGER.
1122 (ignore_mouse_drag_p): Now static if
1123 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1124 (print_help): Remove; unused.
1125 (stop_character, last_timer_event): Mark as externally visible.
1126 * keyboard.h (ignore_mouse_drag_p): Declare only if
1127 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1128 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1129 * lisp.h (echoing): Remove decl.
1130 (force_auto_save_soon): Declare only if SIGDANGER.
1131 * xdisp.c (redisplay_window): Simplify code, to make it more
1132 obvious that ignore_mouse_drag_p is not accessed if !defined
1133 USE_GTK && !defined HAVE_NS.
1134
93ea6e8f
PE
1135 * intervals.c: Make symbols static if they're not exported.
1136 (merge_properties_sticky, merge_interval_right, delete_interval):
1137 Now static.
1138 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1139
77382fcc
PE
1140 * insdel.c: Make symbols static if they're not exported.
1141 However, leave prepare_to_modify_buffer alone. It's never
1142 called from outside this function, but that appears to be a bug.
1143 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1144 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1145 (adjust_after_replace_noundo): Remove; unused.
1146 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1147 (signal_before_change): Remove decls.
77382fcc 1148
9306c32e
PE
1149 * indent.c (val_compute_motion, val_vmotion): Now static.
1150
cd44d2eb
PE
1151 * image.c: Make symbols static if they're not exported.
1152 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1153 if USE_GTK.
1154 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1155 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1156
ad9a7a06
PE
1157 * fringe.c (standard_bitmaps): Now static.
1158 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1159
81626931
PE
1160 * frame.c: Make symbols static if they're not exported.
1161 (x_report_frame_params, make_terminal_frame): Now static.
1162 (get_frame_param): Now static, unless HAVE_NS.
1163 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1164 (x_get_resource_string): Remove; not used.
1165 * frame.h (make_terminal_frame, x_report_frame_params):
1166 (x_get_resource_string); Remove decls.
1167 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1168 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1169
239f9db9
PE
1170 * font.c, fontset.c: Make symbols static if they're not exported.
1171 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1172 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1173 * font.c (font_close_object): Now static.
1174 * font.h (font_close_object): Remove.
1175 * fontset.c (FONTSET_OBJLIST): Remove.
1176 (free_realized_fontset) #if-0 the body, which does nothing.
1177 (face_suitable_for_char_p): #if-0, as it's never called.
1178 * fontset.h (face_suitable_for_char_p): Remove decl.
1179 * xfaces.c (face_at_string_position): Use
1180 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1181 since 0 is always ASCII.
1182
dfcf3579
PE
1183 * fns.c (weak_hash_tables): Now static.
1184
5045092b
PE
1185 * fileio.c: Make symbols static if they're not exported.
1186 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1187 (Vwrite_region_annotation_buffers): Now static.
1188
57a96f5c
PE
1189 * eval.c: Make symbols static if they're not exported.
1190 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1191 * lisp.h (backtrace_list): Remove decl.
1192
35f08c38
PE
1193 * emacs.c: Make symbols static if they're not exported.
1194 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1195 (fatal_error_code, fatal_error_signal_hook, standard_args):
1196 Now static.
1197 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1198 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1199 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1200 * lisp.h (fatal_error_signal_hook): Remove decl.
1201 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1202
f44bd759
PE
1203 * editfns.c: Move a (normally-unused) function to its only use.
1204 * editfns.c, lisp.h (get_operating_system_release): Remove.
1205 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1206 worth the hassle of breaking this out.
1207
b532497d
PE
1208 * xterm.c: Make symbols static if they're not exported.
1209 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1210 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1211 (x_destroy_window, x_delete_display):
1212 Now static.
1213 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1214 (x_mouse_leave): Remove; unused.
1215 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1216 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1217 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1218 Remove decls.
1219 (x_mouse_leave): Declare only if WINDOWSNT.
1220 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1221 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1222 USE_X_TOOLKIT.
1223
1675728f
PE
1224 * ftxfont.c: Make symbols static if they're not exported.
1225 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1226 HAVE_FREETYPE.
1227 * font.h (ftxfont_driver): Likewise.
1228
e4cebfca
PE
1229 * xfns.c: Make symbols static if they're not exported.
1230 (x_last_font_name, x_display_info_for_name):
1231 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1232 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1233 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1234 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1235 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1236 (last_show_tip_args): Now static.
1237 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1238 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1239 (x_screen_planes): Remove; unused.
1240 * dispextern.h (x_screen_planes): Remove decl.
1241
5bf46f05
PE
1242 * dispnew.c: Make symbols static if they're not exported.
1243 * dispextern.h (redraw_garbaged_frames, scrolling):
1244 (increment_row_positions): Remove.
1245 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1246 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1247 Now static.
1248 (redraw_garbaged_frames): Remove; unused.
1249
435f4c28
PE
1250 * xfaces.c: Make symbols static if they're not exported.
1251 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1252 Remove decls.
1253 * xterm.h (defined_color): Remove decls.
1254 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1255 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1256 (menu_face_changed_default, defined_color, free_realized_face):
1257 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1258 (ascii_face_of_lisp_face): Remove; unused.
1259
8524aef3
PE
1260 * xdisp.c: Make symbols static if they're not exported.
1261 * dispextern.h (scratch_glyph_row, window_box_edges):
1262 (glyph_to_pixel_coords, set_cursor_from_row):
1263 (get_next_display_element, set_iterator_to_next):
1264 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1265 (show_mouse_face): Remove decls
1266 * frame.h (message_buf_print): Likewise.
1267 * lisp.h (pop_message, set_message, check_point_in_composition):
1268 Likewise.
1269 * xterm.h (set_vertical_scroll_bar): Likewise.
1270 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1271 (message_buf_print, scratch_glyph_row, displayed_buffer):
1272 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1273 (get_next_display_element, show_mouse_face, window_box_edges):
1274 (frame_to_window_pixel_xy, check_point_in_composition):
1275 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1276 (glyph_to_pixel_coords): Remove; unused.
1277
16390cd2
PE
1278 * dired.c (file_name_completion): Now static.
1279
1280 * dbusbind.c (xd_in_read_queued_messages): Now static.
1281
a25f4dfa
PE
1282 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1283 * data.c (circular_list_error): Remove.
1284
14a9c8df
PE
1285 * commands.h (last_point_position, last_point_position_buffer):
1286 (last_point_position_window): Remove decls.
1287 * keyboard.c: Make these variables static.
1288
74ab6df5
PE
1289 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1290 decls.
1291 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1292 (iso_code_class, detect_coding, code_convert_region): Now static.
1293 (encode_coding_gap): Remove; unused.
1294
38dfbee1
PE
1295 * chartab.c (chartab_chars, chartab_bits): Now static.
1296
a2cb4e63
PE
1297 * charset.h (charset_iso_8859_1): Remove decl.
1298 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1299 Now static.
1300
127198fd
PE
1301 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1302 * ccl.c (Vccl_program_table): Now static.
1303 (check_ccl_update): Remove; unused.
1304
d85b608f
PE
1305 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1306 * category.h: ... from here.
1307 * category.c (check_category_table, set_category_set): Now static.
1308
31cd66f3
PE
1309 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1310 * lisp.h: Remove these decls.
1311
c358e587
PE
1312 * buffer.c (buffer_count): Remove unused var.
1313
e78aecca
PE
1314 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1315 so that it's not optimized away.
1316 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1317 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1318 exported only to the debugger.
1319
e192d7d3
PE
1320 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1321 * atimer.h (run_all_atimers): Removed; not exported.
1322
92470028
PE
1323 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1324 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1325 was inaccessible from Lisp.
1326 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1327 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1328
244ed907
PE
1329 alloc.c: Import and export fewer symbols, and remove unused items.
1330 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1331 is defined.
1332 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1333 it's not optimized away by whole-program optimization.
1334 (message_enable_multibyte, free_misc): Remove.
1335 (catchlist, handlerlist, mark_backtrace):
1336 Declare only if BYTE_MARK_STACK.
1337 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1338 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1339 (message_enable_multibyte): Remove decl.
1340 (free_misc, interval_free_list, float_block, float_block_index):
1341 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1342 (cons_free_list, last_marked_index):
1343 Now static.
1344 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1345 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1346 (mark_backtrace): Define only if BYTE_MARK_STACK.
1347 * xdisp.c (message_enable_multibyte): Now static.
1348
61c2b50e 1349 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1350 This makes it easier for human readers (and static analyzers)
1351 to see whether these variables are used from other modules.
1352 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1353 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1354 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1355 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1356 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1357 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1358 * xmenu.c, xselect.c:
1359 Declare Q* vars static if they are not used in other modules.
1360 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1361 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1362 Remove decls of unexported vars.
1363 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1364
95c82688
PE
1365 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1366
16a97296
PE
1367 Make Emacs functions such as Fatom 'static' by default.
1368 This makes it easier for human readers (and static analyzers)
1369 to see whether these functions can be called from other modules.
1370 DEFUN now defines a static function. To make the function external
1371 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1372 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1373 (Finit_image_library):
16a97296
PE
1374 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1375 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1376 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1377 Remove decls, since these functions are now static.
1378 (Funintern, Fget_internal_run_time): New decls, since these functions
1379 were already external.
95c82688 1380
16a97296
PE
1381 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1382 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1383 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1384 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1385 * keyboard.c, keymap.c, lread.c:
1386 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1387 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1388 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1389 Mark functions with DEFUE instead of DEFUN,
1390 if they are used in other modules.
1391 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1392 decls for now-static functions.
1393 * buffer.h (Fdelete_overlay): Remove decl.
1394 * callproc.c (Fgetenv_internal): Mark as internal.
1395 * composite.c (Fremove_list_of_text_properties): Remove decl.
1396 (Fcomposition_get_gstring): New forward static decl.
1397 * composite.h (Fcomposite_get_gstring): Remove decl.
1398 * dired.c (Ffile_attributes): New forward static decl.
1399 * doc.c (Fdocumntation_property): New forward static decl.
1400 * eval.c (Ffetch_bytecode): New forward static decl.
1401 (Funintern): Remove extern decl; now in .h file where it belongs.
1402 * fileio.c (Fmake_symbolic_link): New forward static decl.
1403 * image.c (Finit_image_library): New forward static decl.
1404 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1405 * intervals.h (Fprevious_property_change):
1406 (Fremove_list_of_text_properties): Remove decls.
1407 * keyboard.c (Fthis_command_keys): Remove decl.
1408 (Fcommand_execute): New forward static decl.
1409 * keymap.c (Flookup_key): New forward static decl.
1410 (Fcopy_keymap): Now static.
1411 * keymap.h (Flookup_key): Remove decl.
1412 * process.c (Fget_process): New forward static decl.
1413 (Fprocess_datagram_address): Mark as internal.
1414 * syntax.c (Fsyntax_table_p): New forward static decl.
1415 (skip_chars): Remove duplicate decl.
1416 * textprop.c (Fprevious_property_change): New forward static decl.
1417 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1418 Now internal.
1419 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1420 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1421
785bbd42
PE
1422 * editfns.c (Fformat): Remove unreachable code.
1423
8b913b57
AS
14242011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1425
1426 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1427 change. (Bug#8496)
1428
a6744a35
EZ
14292011-04-13 Eli Zaretskii <eliz@gnu.org>
1430
1431 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1432 when at ZV. (Bug#8487)
1433
e7974947
AS
14342011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1435
baad03f0
AS
1436 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1437 (Bug#8437)
1438 * keyboard.c (parse_tool_bar_item): Likewise.
1439 * sound.c (sound_cleanup, alsa_close): Likewise.
1440 * termcap.c (tgetent): Likewise.
1441 * xfns.c (x_default_font_parameter): Likewise.
1442 * xsettings.c (read_and_apply_settings): Likewise.
1443
e7974947
AS
1444 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1445 (overrun_check_free): Protoize.
1446
28272684
PE
14472011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1450 since callers should never pass a negative size.
1451 Change the signature to match that of plain 'read' and 'write'; see
1452 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1453 * lisp.h: Update prototypes of emacs_write and emacs_read.
1454
11997c76
EZ
14552011-04-11 Eli Zaretskii <eliz@gnu.org>
1456
1457 * xdisp.c (redisplay_window): Don't try to determine the character
1458 position of the scroll margin if the window start point w->startp
e896f03c 1459 is outside the buffer's accessible region. (Bug#8468)
11997c76 1460
8a2cbd72
EZ
14612011-04-10 Eli Zaretskii <eliz@gnu.org>
1462
1463 Fix write-region and its subroutines for buffers > 2GB.
1464 * fileio.c (a_write, e_write): Modify declaration of arguments and
1465 local variables to support buffers larger than 2GB.
1466 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1467
1468 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1469 argument, local variables, and return value.
1470
1471 * lisp.h: Update prototypes of emacs_write and emacs_read.
1472
1473 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1474
4073e537 14752011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1476
1ebfdcb6
PE
1477 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1478
b2ded58d
PE
1479 Fix more problems found by GCC 4.6.0's static checks.
1480
7d66342c
PE
1481 * xdisp.c (vmessage): Use a better test for character truncation.
1482
bbf47d44
PE
1483 * charset.c (load_charset_map): <, not <=, for optimization,
1484 and to avoid potential problems with integer overflow.
9248994d 1485 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1486 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1487 * editfns.c (Fformat): Likewise.
1e69125e 1488 * syntax.c (skip_chars): Likewise.
3befa583 1489
e3019616
PE
1490 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1491 This also lets GCC 4.6.0 generate slightly better loop code.
1492
becfa255
PE
1493 * callint.c (Fcall_interactively): <, not <=, for optimization.
1494 (Fcall_interactively): Count the number of arguments produced,
1495 not the number of arguments given. This is simpler and lets GCC
1496 4.6.0 generate slightly better code.
1497
dae0cd48
PE
1498 * ftfont.c: Distingish more carefully between FcChar8 and char.
1499 The previous code passed unsigned char * to a functions like
1500 strlen and xstrcasecmp that expect char *, which does not
1501 conform to the C standard.
1502 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1503 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1504 char * when the C standard requires it.
1505
76032d70
PE
1506 * keyboard.c (read_char): Remove unused var.
1507
eb3f1cc8
PE
1508 * eval.c: Port to Windows vsnprintf (Bug#8435).
1509 Include <limits.h>.
1510 (SIZE_MAX): Define if the headers do not.
1511 (verror): Do not give up if vsnprintf returns a negative count.
1512 Instead, grow the buffer. This ports to Windows vsnprintf, which
1513 does not conform to C99. Problem reported by Eli Zaretskii.
1514 Also, simplify the allocation scheme, by avoiding the need for
1515 calling realloc, and removing the ALLOCATED variable.
1516
70476b54
PE
1517 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1518
12020a9e
PE
1519 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1520 But keep the doprint source code for now, as we might revamp it
1521 and use it again (Bug#8435).
ea6c7ae6
PE
1522 * lisp.h (doprnt): Remove.
1523 * Makefile.in (base_obj): Remove doprnt.o.
1524 * deps.mk (doprnt.o): Remove.
1525
5fdb398c
PE
1526 error: Print 32- and 64-bit integers portably (Bug#8435).
1527 Without this change, on typical 64-bit hosts error ("...%d...", N)
1528 was used to print both 32- and 64-bit integers N, which relied on
1529 undefined behavior.
1530 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1531 New macro.
1532 * lisp.h (error, verror): Mark as printf-like functions.
1533 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1534 Report overflow in size calculations when allocating printf buffer.
1535 Do not truncate output string at its first null byte.
1536 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1537 Truncate the output at a character boundary, since vsnprintf does not
1538 do that.
1539 * charset.c (check_iso_charset_parameter): Convert internal
1540 character to string before calling 'error', since %c now has the
1541 printf meaning.
1542 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1543 overflow when computing char to be passed to 'error'. Do not
1544 pass Lisp_Object to 'error'; pass the integer instead.
1545 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1546 formatted with plain %d.
1547
b189fa66
PE
1548 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1549
bff87ef0
PE
1550 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1551
7e2cac20
PE
1552 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1553
ce4d90b5
PE
1554 * xterm.c (x_catch_errors): Remove duplicate declaration.
1555
266c9547
PE
1556 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1557
79c49ad2
PE
1558 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1559
368f4090
JM
15602011-04-10 Jim Meyering <meyering@redhat.com>
1561
1562 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1563 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1564 return ssize_t not "int", and use size_t as the buffer length.
1565 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1566 * gnutls.h: Update declarations.
1567 * process.c (read_process_output): Use ssize_t, to match.
1568 (send_process): Likewise.
1569
a32d4040
CY
15702011-04-09 Chong Yidong <cyd@stupidchicken.com>
1571
1572 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1573
8546720e 15742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1575
8546720e
GM
1576 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1577 unsigned char, to match FcChar8 type definition.
aac0c6e3 1578
8546720e
GM
1579 * xterm.c (handle_one_xevent):
1580 * xmenu.c (create_and_show_popup_menu):
1581 * xselect.c (x_decline_selection_request)
1582 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1583
0a2f5c1a 15842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1585
1586 Fix some uses of `int' instead of EMACS_INT.
1587 * search.c (string_match_1, fast_string_match)
1588 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1589 (scan_buffer, find_next_newline_no_quit)
1590 (find_before_next_newline, search_command, Freplace_match)
1591 (Fmatch_data): Make some `int' variables be EMACS_INT.
1592
1593 * xdisp.c (display_count_lines): 3rd argument and return value now
1594 EMACS_INT. All callers changed.
1595 (pint2hrstr): Last argument is now EMACS_INT.
1596
1597 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1598 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1599 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1600 (decode_coding_utf_16, decode_coding_emacs_mule)
1601 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1602 (decode_coding_ccl, decode_coding_charset)
1603 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1604 (decode_coding_iso_2022, decode_coding_emacs_mule)
1605 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1606 <char_offset, last_offset>: Declare EMACS_INT.
1607 (encode_coding_utf_8, encode_coding_utf_16)
1608 (encode_coding_emacs_mule, encode_invocation_designation)
1609 (encode_designation_at_bol, encode_coding_iso_2022)
1610 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1611 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1612 Declare EMACS_INT.
1613 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1614 (encode_invocation_designation): Last argument P_NCHARS is now
1615 EMACS_INT.
1616 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1617 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1618
1619 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1620 All users changed.
1621
1622 * ccl.c (Fccl_execute_on_string): Declare some variables
1623 EMACS_INT.
1624
8546720e 16252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1626
1627 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1628
4e19a977
CS
16292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1630
1631 * process.c (Fformat_network_address): Doc fix.
1632
87302331
R
16332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1634
1635 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1636
cbb59342
CY
16372011-04-08 Chong Yidong <cyd@stupidchicken.com>
1638
1639 * keyboard.c (read_char): Call Lisp function help-form-show,
1640 instead of using internal_with_output_to_temp_buffer.
1641 (Qhelp_form_show): New var.
e0d38eeb 1642 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1643
1644 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1645
1646 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1647
e67a13ab
CY
16482011-04-06 Chong Yidong <cyd@stupidchicken.com>
1649
1650 * process.c (Flist_processes): Removed to Lisp.
1651 (list_processes_1): Deleted.
1652
973f782d
EZ
16532011-04-06 Eli Zaretskii <eliz@gnu.org>
1654
7c106b1e
EZ
1655 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1656
973f782d
EZ
1657 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1658
41cf7d1a 16592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1660
ca23cc88
PE
1661 Fix more problems found by GCC 4.6.0's static checks.
1662
f390e2d5
PE
1663 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1664
42eea0d0
PE
1665 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1666
b69769da 1667 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1668
f9541e84
PE
1669 * xdisp.c (vmessage): Mark as a printf-like function.
1670
13841b55
PE
1671 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1672
c136c10f
PE
1673 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1674
5e2d4a30
PE
1675 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1676 printf-like functions.
1677 (tiff_load): Add casts to remove these marks before passing them
1678 to system-supplied API.
1679
583f48b9
PE
1680 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1681
b25d760e
PE
1682 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1683 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1684 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1685 directly, rather than having caller test rule sign. This avoids
1686 some unnecessary tests.
1687 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1688 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1689 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1690
bc7b6697 1691 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1692 (xfont_open): Avoid unnecessary tests.
bc7b6697 1693
27ccc379
PE
1694 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1695
dcd5c89a
PE
1696 * composite.h, composite.c (composition_gstring_put_cache):
1697 Use EMACS_INT, not int, for length.
1698
b13a45c6
PE
1699 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1700 breaking out part of COMPOSITION_DECODE_RULE.
1701 (COMPOSITION_DECODE_RULE): Use it.
1702 * composite.c (get_composition_id): Remove unused local vars,
1703 by using the new macro.
1704
1e792e4d
PE
1705 * textprop.c (set_text_properties_1): Change while to do-while,
1706 since the condition is always true at first.
1707
dc6c6455 1708 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1709 (interval_deletion_adjustment): Return unsigned value.
1710 All uses changed.
dc6c6455 1711
aba7731a
PE
1712 * process.c (list_processes_1, create_pty, read_process_output):
1713 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1714 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1715 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1716 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1717 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1718
fdfc4bf3
PE
1719 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1720
fca8fe46 1721 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1722 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1723
06a0259a 1724 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1725 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1726 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1727
e7b9e80f
PE
1728 * print.c (print_error_message): Avoid int overflow.
1729
56201685
PE
1730 * font.c (font_list_entities): Redo for clarity,
1731 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1732
78834453 1733 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1734 (font_score): Avoid potential overflow in diff calculation.
78834453 1735
0bc0b309 1736 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1737 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1738
e610eaca
PE
1739 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1740
b895abce
PE
1741 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1742 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1743 can always succeed if overflow has undefined behavior.
1744
1f1d9321 1745 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1746 (wordify): Omit three unnecessary tests.
1f1d9321 1747
c59478bc
PE
1748 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1749 All callers changed. This avoids the need for an unused var.
1750
79b73827
PE
1751 * casefiddle.c (casify_region): Remove var that is set but not used.
1752
a4db5dfe
PE
1753 * dired.c (file_name_completion): Remove var that is set but not used.
1754
43aae36e
PE
1755 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1756
2a47c44d 1757 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1758 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1759
a37c69bf
PE
1760 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1761 Check for integer overflow on size calculations.
1762
328ab8e7
PE
1763 * buffer.c (Fprevious_overlay_change): Remove var that is set
1764 but not used.
1765
e5a2a5cb
PE
1766 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1767 Remove vars that are set but not used.
8d84a6eb 1768 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1769 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1770
a60e5f68
PE
1771 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1772
f661cb61 1773 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1774 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1775
f0397f5a
PE
1776 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1777 that are set but not used.
1778
8664db06 1779 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1780 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1781
6abdaa4a
PE
1782 * xselect.c (x_get_local_selection, x_handle_property_notify):
1783 Remove vars that are set but not used.
1784
0ce7538d 1785 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1786 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1787
9ae848fc
PE
1788 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1789 Remove var that is set but not used.
0b918413
PE
1790 (scroll_bar_windows_size): Now size_t, not int.
1791 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1792 Check for overflow.
9ae848fc 1793
a5a62657
PE
1794 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1795 (map_tty_color) [!defined MSDOS]: Likewise.
1796
5c5cdd39
PE
1797 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1798
66ebf983
PE
1799 * coding.c: Remove vars that are set but not used.
1800 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1801 All callers changed.
1802 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1803 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1804 (decode_coding_charset): Remove vars that are set but not used.
1805
1be4d761
PE
1806 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1807 that is set but not used.
1808
47553fa8
PE
1809 * print.c (print_object): Remove var that is set but not used.
1810
1f7196bf 1811 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1812 The gnulib version avoids calling malloc in the usual case,
1813 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1814 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1815 * filelock.c (current_lock_owner): Likewise.
1816 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1817 * sysdep.c: Include allocator.h, careadlinkat.h.
1818 (emacs_no_realloc_allocator): New static constant.
1819 (emacs_readlink): New function.
fdb61804
PE
1820 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1821 ../lib/careadlinkat.h.
d1fdcab7 1822
f84c17c7
SM
18232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1824
1825 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1826 first non-nil return value).
1827
ef3862ad
JD
18282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1829
1830 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1831 if not defined (Bug#8403).
1832
376a7006
JB
18332011-04-02 Juanma Barranquero <lekktu@gmail.com>
1834
1835 * xdisp.c (display_count_lines): Remove parameter `start',
1836 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1837 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1838 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1839 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1840 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1841 and thereabouts. All callers changed.
1842 (get_per_char_metric): Remove parameter `f', unused since
1843 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1844
6ca3801d
JM
18452011-04-02 Jim Meyering <meyering@redhat.com>
1846
1847 do not dereference NULL upon failed strdup
1848 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1849 (ns_get_family): Likewise.
1850
d8e2b5ba
JB
18512011-04-02 Juanma Barranquero <lekktu@gmail.com>
1852
1853 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1854
8c74fcbd
JD
18552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1856
1857 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1858 later (Bug#8403).
1859
7200d79c
SM
18602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1861
03408648 1862 Add lexical binding.
7200d79c 1863
03408648
SM
1864 * window.c (Ftemp_output_buffer_show): New fun.
1865 (Fsave_window_excursion):
1866 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1867
1868 * lread.c (lisp_file_lexically_bound_p): New function.
1869 (Fload): Bind Qlexical_binding.
1870 (readevalloop): Remove `evalfun' arg.
1871 Bind Qinternal_interpreter_environment.
1872 (Feval_buffer): Bind Qlexical_binding.
1873 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1874 Mark as dynamic.
1875 (syms_of_lread): Declare `lexical-binding'.
1876
1877 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1878
1879 * keyboard.c (eval_dyn): New fun.
1880 (menu_item_eval_property): Use it.
ca105506
SM
1881
1882 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1883
03408648
SM
1884 * fns.c (concat, mapcar1): Accept byte-code-functions.
1885
1886 * eval.c (Fsetq): Handle lexical vars.
1887 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1888 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1889 (FletX, Flet): Obey lexical binding.
1890 (Fcommandp): Handle closures.
1891 (Feval): New `lexical' arg.
1892 (eval_sub): New function extracted from Feval. Use it almost
1893 everywhere where Feval was used. Look up vars in lexical env.
1894 Handle closures.
1895 (Ffunctionp): Move from subr.el.
1896 (Ffuncall): Handle closures.
1897 (apply_lambda): Remove `eval_flags'.
1898 (funcall_lambda): Handle closures and new byte-code-functions.
1899 (Fspecial_variable_p): New function.
1900 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1901 but without exporting it to Lisp.
23aba0ea 1902
23aba0ea 1903 * doc.c (Fdocumentation, store_function_docstring):
03408648 1904 * data.c (Finteractive_form): Handle closures.
23aba0ea 1905
03408648
SM
1906 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1907 interactive spec.
ba83908c 1908
03408648
SM
1909 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1910 byte-codes.
1911 (exec_byte_code): New function extracted from Fbyte_code to handle new
1912 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1913
03408648 1914 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1915
03408648 1916 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1917
e2abce01
JB
19182011-03-31 Juanma Barranquero <lekktu@gmail.com>
1919
1920 * xdisp.c (redisplay_internal): Fix prototype.
1921
63696a73 19222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1923
63696a73
EZ
1924 * xdisp.c (SCROLL_LIMIT): New macro.
1925 (try_scrolling): Use it when setting scroll_limit. Limit
1926 scrolling to 100 screen lines.
1927 (redisplay_window): Even when falling back on "recentering",
1928 position point in the window according to scroll-conservatively,
1929 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1930
1931 (try_scrolling): When point is above the window, allow searching
1932 as far as scroll_max, or one screenful, to compute vertical
1933 distance from PT to the scroll margin position. This prevents
1934 try_scrolling from unnecessarily failing when
1935 scroll-conservatively is set to a value slightly larger than the
1936 window height. Clean up the case of PT below the margin at bottom
1937 of window: scroll_max can no longer be INT_MAX. When aggressive
1938 scrolling is in use, don't let point enter the opposite scroll
1939 margin as result of the scroll.
1940 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1941 threshold of 100 lines for never-recentering scrolling.
1942
e4cc2dfc
JB
19432011-03-31 Juanma Barranquero <lekktu@gmail.com>
1944
1945 * dispextern.h (move_it_by_lines):
1946 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1947 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1948 (message_log_check_duplicate): Remove parameters `prev_bol' and
1949 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1950 (redisplay_internal): Remove parameter `preserve_echo_area',
1951 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1952
1953 * indent.c (Fvertical_motion):
1954 * window.c (window_scroll_pixel_based, Frecenter):
1955 Don't pass `need_y_p' to `move_it_by_lines'.
1956
1c470562
SM
19572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1958
44f230aa
SM
1959 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1960 steal a few bits to be more compact.
1961 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1962 Remove unneeded casts.
1963
1c470562
SM
1964 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1965
888adce9
ZK
19662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1967
1968 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1969 binding" message (bug#7967).
1970
f838ed7b
PE
19712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1972
77861b95
PE
1973 Fix more problems found by GCC 4.6.0's static checks.
1974
de6dbc14
PE
1975 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1976 Remove unused local var.
1977
f838ed7b
PE
1978 * editfns.c (Fmessage_box): Remove unused local var.
1979
792c7b2b
PE
1980 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1981 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1982 Omit unused local vars.
c499e557 1983 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1984 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1985 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1986 Omit unused local var.
1987
ba0165e1
PE
1988 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1989 Don't assume string length fits in int.
32ad8845 1990 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1991 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1992
3c59b4c9
PE
1993 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1994 instead of alloca (Bug#8344).
1995
a3eed478 1996 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1997 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1998
eb4d412d
PE
1999 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2000
1658b401
PE
2001 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2002 concerns.
2003
2004 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2005
2006 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2007
9a2c6e05
PE
2008 * keyboard.c (syms_of_keyboard): Use the same style as later
2009 in this function when indexing through an array. This also
2010 works around GCC bug 48267.
2011
03d0a109
PE
2012 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2013
44f730c8
PE
2014 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2015
fe75f926
PE
2016 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2017 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2018
ffa8c828
PE
2019 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2020 This avoids undefined behavior on integer overflow, and is a bit
2021 more convenient anyway since it is compared to a size_t variable.
2022
c5101a77
PE
2023 Variadic C functions now count arguments with size_t, not int.
2024 This avoids an unnecessary limitation on 64-bit machines, which
2025 caused (substring ...) to crash on large vectors (Bug#8344).
2026 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2027 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2028 All variadic functions and their callers changed accordingly.
c5101a77
PE
2029 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2030 * data.c (arith_driver, float_arith_driver): Likewise.
2031 * editfns.c (general_insert_function): Likewise.
2032 * eval.c (struct backtrace.nargs, interactive_p)
2033 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2034 (funcall_lambda, mark_backtrace): Likewise.
2035 * fns.c (concat): Likewise.
2036 * frame.c (x_set_frame_parameters): Likewise.
2037 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2038 0 if not found, not -1. All callers changed.
2039
dd3f25f7
PE
2040 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2041 (stack_copy_size): Now size_t, not int.
2042 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2043
461c2ab9
JB
20442011-03-28 Juanma Barranquero <lekktu@gmail.com>
2045
2046 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2047 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2048 All callers changed.
2049
2050 * lisp.h (multibyte_char_to_unibyte):
2051 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2052 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2053 * character.h (CHAR_TO_BYTE8):
2054 * cmds.c (internal_self_insert):
2055 * editfns.c (general_insert_function):
2056 * keymap.c (push_key_description):
2057 * search.c (Freplace_match):
2058 * xdisp.c (message_dolog, set_message_1): All callers changed.
2059
f6d62986
SM
20602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2061
2062 * keyboard.c (safe_run_hook_funcall): New function.
2063 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2064 don't set the hook to nil, but remove the offending function instead.
2065 (Qcommand_hook_internal): Remove, unused.
2066 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2067 Vcommand_hook_internal.
2068
2069 * eval.c (enum run_hooks_condition): Remove.
2070 (funcall_nil, funcall_not): New functions.
2071 (run_hook_with_args): Call each function through a `funcall' argument.
2072 Remove `cond' argument, now redundant.
2073 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2074 (Frun_hook_with_args_until_failure): Adjust accordingly.
2075 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2076
1db5b1ad
JB
20772011-03-28 Juanma Barranquero <lekktu@gmail.com>
2078
2079 * dispextern.h (string_buffer_position): Remove declaration.
2080
2081 * print.c (strout): Remove parameter `multibyte', unused since
2082 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2083
2084 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2085 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2086 All callers changed.
2087
2088 * w32.c (_wsa_errlist): Use braces for struct initializers.
2089
2090 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2091 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2092 All callers changed.
2093 (string_buffer_position): Likewise. Also, make static (it's never
2094 used outside xdisp.c).
2095 (cursor_row_p): Remove parameter `w', unused since
2096 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2097 (decode_mode_spec): Remove parameter `precision', introduced during
2098 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2099 All callers changed.
2100
5ffb62aa
JD
21012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2102
2103 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2104
461c2ab9 21052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2106
2107 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2108 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2109 (ns_update_auto_hide_menu_bar): New functions.
2110 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2111 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2112 ns_constrain_all_frames.
2113 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2114 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2115
5c380ffb
JD
21162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2117
2118 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2119
9af30bdf
GM
21202011-03-27 Glenn Morris <rgm@gnu.org>
2121
2122 * syssignal.h: Replace RETSIGTYPE with void.
2123 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2124 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2125 Replace SIGTYPE with void everywhere.
2126 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2127 * s/template.h (SIGTYPE): Remove commented out definition.
2128
e2abce01
JB
21292011-03-26 Eli Zaretskii <eliz@gnu.org>
2130
2131 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2132 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2133
f868cd8a
JB
21342011-03-26 Juanma Barranquero <lekktu@gmail.com>
2135
59eb0929
JB
2136 * w32.c (read_unc_volume): Use parameter `henum', instead of
2137 global variable `wget_enum_handle'.
2138
2139 * keymap.c (describe_vector): Remove parameters `indices' and
2140 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2141 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2142
f868cd8a
JB
2143 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2144
2145 * keyboard.c (timer_check): Remove parameter `do_it_now',
2146 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2147 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2148 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2149
2150 * keyboard.c (read_char):
2151 * w32menu.c (w32_menu_display_help):
2152 * xmenu.c (show_help_event, menu_help_callback):
2153 Adjust calls to `show_help_echo'.
2154
2155 * gtkutil.c (xg_maybe_add_timer):
2156 * keyboard.c (readable_events):
2157 * process.c (wait_reading_process_output):
2158 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2159
2160 * insdel.c (adjust_markers_gap_motion):
2161 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2162 (gap_left, gap_right): Don't call it.
2163
2ecf6fdb
CY
21642011-03-25 Chong Yidong <cyd@stupidchicken.com>
2165
2166 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2167 incurred during fontification.
2168
6b1f9ba4
JB
21692011-03-25 Juanma Barranquero <lekktu@gmail.com>
2170
2171 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2172 (DEFVAR_PER_BUFFER): Don't pass it.
2173
2174 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2175 (scrolling_window): Don't pass it.
2176
0f4a96b5
JB
21772011-03-25 Juanma Barranquero <lekktu@gmail.com>
2178
2179 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2180
2181 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2182 and `suffix'.
2183 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2184 of variables specific to SELinux and computation of `encoded_absname'.
2185
2186 * image.c (XPutPixel): Remove unused variable `height'.
2187
2188 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2189
2190 * unexw32.c (get_section_info): Remove unused variable `section'.
2191
2192 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2193 (system_process_attributes): Remove unused variable `sess'.
2194 (sys_read): Remove unused variable `err'.
2195
2196 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2197 (w32_wnd_proc): Remove unused variable `isdead'.
2198 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2199 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2200 (x_create_tip_frame): Remove unused variable `tem'.
2201
2202 * w32inevt.c (w32_console_read_socket):
2203 Remove unused variable `no_events'.
2204
2205 * w32term.c (x_draw_composite_glyph_string_foreground):
2206 Remove unused variable `width'.
2207
1149507c
JB
22082011-03-24 Juanma Barranquero <lekktu@gmail.com>
2209
2210 * w32term.c (x_set_glyph_string_clipping):
2211 Don't pass uninitialized region to CombineRgn.
2212
9c88f339
JB
22132011-03-23 Juanma Barranquero <lekktu@gmail.com>
2214
2215 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2216 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2217 (Fx_close_connection): Remove unused variable `i'.
2218
2219 * w32font.c (w32font_draw): Return number of glyphs.
2220 (w32font_open_internal): Remove unused variable `i'.
2221 (w32font_driver): Add missing initializer.
2222
2223 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2224 (fill_in_menu): Remove unused variable `items_added'.
2225
2226 * w32term.c (last_mouse_press_frame): Remove static global variable.
2227 (w32_clip_to_row): Remove unused variable `f'.
2228 (x_delete_terminal): Remove unused variable `i'.
2229
2230 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2231 (NOTHING): Remove unused static global variable.
2232 (uniscribe_check_otf): Remove unused variable `table'.
2233 (uniscribe_font_driver): Add missing initializers.
2234
dee091a3
JD
22352011-03-23 Julien Danjou <julien@danjou.info>
2236
2237 * term.c (Fsuspend_tty, Fresume_tty):
2238 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2239 * window.c (temp_output_buffer_show):
2240 * insdel.c (signal_before_change):
2241 * frame.c (Fhandle_switch_frame):
2242 * fileio.c (Fdo_auto_save):
2243 * emacs.c (Fkill_emacs):
2244 * editfns.c (save_excursion_restore):
2245 * cmds.c (internal_self_insert):
2246 * callint.c (Fcall_interactively):
2247 * buffer.c (Fkill_all_local_variables):
2248 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2249 Use Frun_hooks.
0f4a96b5 2250 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2251 unconditionnaly since it does the check itself.
2252
2c520ab5 22532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2254
c9c49752
PE
2255 Fix more problems found by GCC 4.5.2's static checks.
2256
8abc3f12
PE
2257 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2258 the first time through the loop, since we know p0 < p1 then.
2259 This also avoids a gcc -Wstrict-overflow warning.
2260
a2d26660
PE
2261 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2262 leading to a memory leak, possible in functions like
2263 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2264 of objects (Bug#8318).
a2d26660 2265
916c72e9
PE
2266 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2267 that could (at least in theory) be that large.
2268
19ab8a18
PE
2269 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2270 This is less likely to overflow, and avoids undefined behavior if
2271 overflow does occur. All callers changed. Use strtoul to scan
2272 for the unsigned long integer.
b7cbbd6f
PE
2273 (pint2hrstr): Simplify and tune code slightly.
2274 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2275
f0641eff
PE
2276 * scroll.c (do_scrolling): Work around GCC bug 48228.
2277 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2278
7f650bb9
PE
2279 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2280 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2281 (validate_x_resource_name): Simplify count usage.
2282 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2283
37dd57d1
PE
2284 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2285 fail (Bug#8306).
81e56e61 2286
699979fc 2287 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2288
401bf9b4
PE
2289 * process.c (Fmake_network_process): Use socklen_t, not int,
2290 where POSIX says socklen_t is required in portable programs.
2291 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2292 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2293 (Fmake_network_process, server_accept_connection):
2294 (wait_reading_process_output, read_process_output):
2295 Likewise.
2296
b93aacde
PE
2297 * process.c: Rename or move locals to avoid shadowing.
2298 (list_processes_1, Fmake_network_process):
2299 (read_process_output_error_handler, exec_sentinel_error_handler):
2300 Rename or move locals.
4dc343ee 2301 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2302 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2303 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2304 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2305 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2306
af8a867c 2307 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2308 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2309 Include tparam.h instead, since it declares them.
af8a867c
PE
2310 * cm.h (PC): Remove extern decl; tparam.h now does this.
2311 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2312 * terminfo.c: Include tparam.h, to check interfaces.
2313 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2314 (tparam): Adjust signature to match interface in tparam.h;
2315 this removes some undefined behavior. Check that outstring and len
2316 are zero, which they always are with Emacs.
2317 * tparam.h (PC, BC, UP): New extern decls.
2318
0248044d 2319 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2320 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2321
8ff096c1 2322 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2323 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2324 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2325 (ftfont_list): Remove unused local.
49eaafba
PE
2326 (get_adstyle_property, ftfont_pattern_entity):
2327 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2328 Rename locals to avoid shadowing.
8ff096c1 2329
e2be39f6
PE
2330 * xfont.c (xfont_list_family): Mark var as initialized.
2331
c9735e30
PE
2332 * xml.c (make_dom): Now static.
2333
8f5201ae
PE
2334 * composite.c (composition_compute_stop_pos): Rename local to
2335 avoid shadowing.
b246f932
PE
2336 (composition_reseat_it): Remove unused locals.
2337 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2338 (composition_update_it): Mark var as initialized.
11b61122
PE
2339 (find_automatic_composition): Mark vars as initialized,
2340 with a FIXME (Bug#8290).
8f5201ae 2341
760fbc2c
PE
2342 character.h: Rename locals to avoid shadowing.
2343 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2344 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2345 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2346 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2347 to avoid shadowing.
2348
ff08eb85
PE
2349 * textprop.c (property_change_between_p): Remove; unused.
2350
fc7bf025
PE
2351 * intervals.c (interval_start_pos): Now static.
2352
235d7abc
PE
2353 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2354
44f230aa
SM
2355 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2356 Rename locals to avoid shadowing.
3e7d6594 2357
50060332
PE
2358 * sound.c (wav_play, au_play, Fplay_sound_internal):
2359 Fix pointer signedness.
d01f234b 2360 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2361 (wav_play): Initialize a variable to 0, to prevent undefined
2362 behavior (Bug#8278).
50060332 2363
c4fc4e30
PE
2364 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2365
918436ed
PE
2366 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2367
c939f91b
PE
2368 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2369 clobbering (Bug#8298).
b9c7f648
PE
2370 * sysdep.c (sys_subshell): Likewise.
2371 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2372
6bd8c144
PE
2373 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2374 This should get cleaned up, so that child_setup has the
2375 same signature on all platforms.
2376
7710357c 2377 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2378 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2379
c59da222
CY
23802011-03-22 Chong Yidong <cyd@stupidchicken.com>
2381
2382 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2383 not to be necessary, and produces flickering.
2384
66b87493
GM
23852011-03-20 Glenn Morris <rgm@gnu.org>
2386
2387 * config.in: Remove file.
2388
45b6f6d5
JB
23892011-03-20 Juanma Barranquero <lekktu@gmail.com>
2390
2391 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2392 are now in src/globals.h.
2393 (syms_of_minibuf): Remove spurious & from previous change.
2394
3ec03f7e
LL
23952011-03-20 Leo <sdl.web@gmail.com>
2396
2397 * minibuf.c (completing-read-function): New variable.
2398 (completing-read-default): Rename from completing-read.
2399 (completing-read): Call completing-read-function.
2400
b14e3e21
CY
24012011-03-19 Juanma Barranquero <lekktu@gmail.com>
2402
2403 * xfaces.c (Fx_load_color_file):
2404 Read color file from absolute filename (bug#8250).
2405
f2b726e6
JB
24062011-03-19 Juanma Barranquero <lekktu@gmail.com>
2407
2408 * makefile.w32-in: Update dependencies.
2409
09f6ff02
EZ
24102011-03-17 Eli Zaretskii <eliz@gnu.org>
2411
2412 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2413
29a6015a
PE
24142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2415
a3a6c54e
PE
2416 Fix more problems found by GCC 4.5.2's static checks.
2417
b766f867
PE
2418 * process.c (make_serial_process_unwind, send_process_trap):
2419 (sigchld_handler): Now static.
2420
be02381c
PE
2421 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2422 That way, the code declares only the vars that it needs.
2423 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2424 * s/cygwin.h (PTY_ITERATION): Likewise.
2425 * s/darwin.h (PTY_ITERATION): Likewise.
2426 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2427
57048744
PE
2428 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2429 * process.c (allocate_pty): Don't declare stb unless it's needed.
2430
7914961c 2431 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2432 (CONSTANTLIM): Remove; unused.
2433 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2434 Define only if needed.
7914961c 2435
b3967b18
PE
2436 * unexelf.c (unexec): Name an expression,
2437 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2438 Use a different way to cause a compilation error if anyone uses
2439 n rather than nn, a way that does not involve shadowing.
73366a00 2440 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2441
29a6015a
PE
2442 * deps.mk (unexalpha.o): Remove; unused.
2443
43cfc33e 2444 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2445 * unexec.h: New file.
ce701a33
PE
2446 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2447 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2448 Depend on unexec.h.
2449 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2450 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2451 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2452 Change as necessary to match prototype in unexec.h.
ce701a33 2453
01f44d5a
PE
2454 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2455 shadowing.
4f63c6bb 2456 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2457
a6670b0b
PE
2458 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2459 Rename locals to avoid shadowing.
2460
cef2010d 2461 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2462 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2463
d4d7173a
PE
2464 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2465
f08b802a
PE
2466 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2467 warning when compiling print.c.
2468
3ddb0639
PE
2469 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2470 instead of using an uninitialized var.
5ad03b97 2471 (font_sort_entities): Mark var as initialized.
3ddb0639 2472
170a2692
PE
2473 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2474
e663c700
PE
2475 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2476 pointers to constants.
89bc529a 2477 (font_parse_fcname): Remove unused vars.
7b81e2d0 2478 (font_delete_unmatched): Now static.
ea838e10 2479 (font_get_spec): Remove; unused.
13a547c6
PE
2480 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2481 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2482 Rename or move locals to avoid shadowing.
e663c700 2483
2a80c887 2484 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2485 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2486
1384fa33 2487 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2488 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2489
8b2c52e9
PE
2490 * alloc.c (mark_backtrace): Move decl from here ...
2491 * lisp.h: ... to here, so that it can be checked.
2492
475545b5 2493 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2494 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2495 (lisp_indirect_variable): Name an expression,
2496 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2497 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2498
b1349114 2499 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2500 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2501 Use const pointer when appropriate.
b1349114 2502
a2928364
PE
2503 * lisp.h (get_system_name, get_operating_system_release):
2504 Move decls here, to check interfaces.
2505 * process.c (get_operating_system_release): Move decl to lisp.h.
2506 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2507 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2508 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2509 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2510 (Fformat_time_string, Fencode_time, Finsert_char):
2511 (Ftranslate_region_internal, Fformat):
2512 Rename or remove local vars to avoid shadowing.
9710023e 2513 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2514
a415e694
PE
2515 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2516 avoid shadowing.
2517
8ef4622d
PE
2518 * lisp.h (eassert): Check that the argument compiles, even if
2519 ENABLE_CHECKING is not defined.
2520
946f9a5b
PE
2521 * data.c (Findirect_variable): Name an expression, to avoid
2522 gcc -Wbad-function-cast warning.
112396d6 2523 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2524 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2525 (Fmake_variable_buffer_local, Fmake_local_variable):
2526 Mark variables as initialized.
52746918 2527 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2528
e5aab7e7 2529 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2530 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2531 Rename locals to avoid shadowing.
dff45157
PE
2532 (mark_stack): Move local variables into the #ifdef region where
2533 they're used.
7bc26fdb
PE
2534 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2535 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2536 needed otherwise.
2537 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2538 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2539 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2540
e5aab7e7
PE
2541 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2542 avoids undefined behavior in theory.
2543
4da60324
PE
2544 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2545
88043301
PE
2546 Use functions, not macros, for up- and down-casing (Bug#8254).
2547 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2548 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2549 to use the following functions instead of these macros.
2550 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2551 EMACS_INT, since callers assume the returned value fits in int.
2552 (upcase1): Likewise, for UPCASE_TABLE.
2553 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2554 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2555 the race-condition problem in the old DOWNCASE.
88043301 2556
19ed5445
PE
2557 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2558 Rename locals to avoid shadowing.
2559 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2560 (regex_compile, re_search_2, re_match_2_internal):
2561 Remove unused local vars.
952db0d7
PE
2562 (FREE_VAR): Rewrite so as not to use empty "else",
2563 which gcc can warn about.
da053e48 2564 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2565 (RETALLOC_IF): Define only if needed.
2566 (WORDCHAR_P): Likewise. This one is never needed, but is used
2567 only in a comment talking about a compiler bug, so put inside
2568 the #if 0 of that comment.
2569 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2570 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2571 Remove; unused.
19ed5445 2572
1f3561e4 2573 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2574 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2575 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2576
ded6f8f7
PE
2577 * search.c (simple_search): Remove unused var.
2578
dbd37a95
PE
2579 * dired.c (compile_pattern): Move decl from here ...
2580 * lisp.h: ... to here, so that it can be checked.
2581 (struct re_registers): New forward decl.
2582
7e47afad
PE
2583 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2584
85f24f61
PE
2585 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2586 All uses changed.
2587 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2588 Rename locals to avoid shadowing.
5671df8f 2589 (Fvertical_motion): Mark locals as initialized.
85f24f61 2590
181aa2be 2591 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2592 (casify_region): Mark local as initialized.
181aa2be 2593
930d429c
PE
2594 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2595
7082eac6
PE
2596 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2597 New macros, so that the caller can use some names other than
2598 gcpro1, gcpro2, etc.
2599 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2600 of the new macros.
2601 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2602 argument, for consistency with GCPRO2_VAR, etc: it is now the
2603 prefix of the variable, not the variable itself. All uses
2604 changed.
38b2c076
PE
2605 * dired.c (directory_files_internal, file_name_completion):
2606 Rename locals to avoid shadowing.
2607
15206ed9
PE
2608 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2609 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2610 dired.c's scmp function, had undefined behavior.
2611 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2612 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2613 * buffer.h: ... to here, because these macros use current_buffer,
2614 and the new implementation with inline functions needs to have
2615 current_buffer in scope now, rather than later when the macros
2616 are used.
2617 (downcase, upcase1): New static inline functions.
2618 (DOWNCASE, UPCASE1): Reimplement using these functions.
2619 This avoids undefined behavior in expressions like
2620 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2621 from race conditions in accessing the global variables
2622 case_temp1 and case_temp2.
2623 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2624 * lisp.h (case_temp1, case_temp2): Remove their decls.
2625 * character.h (ASCII_CHAR_P): Move from here ...
2626 * lisp.h: ... to here, so that the inline functions mentioned
2627 above can use them.
2628
4a6bea26
PE
2629 * dired.c (directory_files_internal_unwind): Now static.
2630
f14b7e14
PE
2631 * fileio.c (file_name_as_directory, directory_file_name):
2632 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2633 Now static.
2893f146
PE
2634 (file_name_as_directory): Use const pointers when appropriate.
2635 (Fexpand_file_name): Likewise. In particular, newdir might
2636 point at constant storage, so make it a const pointer.
fd4ead52 2637 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2638 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2639 signedness issues.
f839df0c
PE
2640 (Fset_file_times, Finsert_file_contents, auto_save_error):
2641 Rename locals to avoid shadowing.
f14b7e14 2642
5716756e 2643 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2644 (Ftry_completion, Fall_completions): Rename or remove locals
2645 to avoid shadowing.
5716756e 2646
b4c3046a
PE
2647 * marker.c (bytepos_to_charpos): Remove; unused.
2648
b45db522
PE
2649 * lisp.h (verify_bytepos, count_markers): New decls,
2650 so that gcc does not warn that these functions aren't declared.
2651
85876d07
PE
2652 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2653 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2654 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2655 (copy_text): Remove unused local var.
85876d07 2656
03d78a21 2657 * filelock.c (within_one_second): Now static.
b3dd38ab 2658 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2659
5df8f01b
PE
2660 * buffer.c (fix_overlays_before): Mark locals as initialized.
2661 (fix_start_end_in_overlays): Likewise. This function should be
2662 simplified by using pointers-to-pointers, but that's a different
2663 matter.
b1d876f1 2664 (switch_to_buffer_1): Now static.
8f54f30a
PE
2665 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2666 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2667
a70072c9 2668 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2669 Fix pointer signedness issue.
edced198
PE
2670 (sys_subshell): Mark local as volatile if checking for lint,
2671 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2672 (MAXPATHLEN): Define only if needed.
a70072c9 2673
a0977c44
PE
2674 * process.c (serial_open, serial_configure): Move decls from here ...
2675 * systty.h: ... to here, so that they can be checked.
2676
a884fdcc
PE
2677 * fns.c (get_random, seed_random): Move extern decls from here ...
2678 * lisp.h: ... to here, so that they can be checked.
2679
604efe86 2680 * sysdep.c (reset_io): Now static.
b8950c94 2681 (wait_for_termination_signal): Remove; unused.
604efe86 2682
38fc62d9
PE
2683 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2684 (copy_keymap_item, append_key, push_text_char_description):
2685 Now static.
1004a21a 2686 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2687 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2688 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2689 (describe_map_tree):
2690 Rename locals to avoid shadowing.
38fc62d9 2691
2f2650da
PE
2692 * keyboard.c: Declare functions static if they are not used elsewhere.
2693 (echo_char, echo_dash, cmd_error, top_level_2):
2694 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2695 (read_char, kbd_buffer_get_event, make_lispy_position):
2696 (make_lispy_event, make_lispy_movement, apply_modifiers):
2697 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2698 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2699 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2700 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2701 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2702
a053e86c 2703 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2704 (mark_kboards): Move decl here ...
2705 * alloc.c (mark_kboards): ... from here.
a053e86c 2706
4752793e
PE
2707 * lisp.h (force_auto_save_soon): New decl.
2708
74f10ca7 2709 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2710 (DEFINE_DUMMY_FUNCTION): New macro.
2711 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2712 Use it.
c03cd23f
PE
2713 (main): Add casts to avoid warnings
2714 if GCC considers string literals to be constants.
74f10ca7 2715
022e70d4
PE
2716 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2717
59d6fe83
PE
2718 * dbusbind.c: Pointer signedness fixes.
2719 (xd_signature, xd_append_arg, xd_initialize):
2720 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2721 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2722 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2723 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2724
78320123
PE
2725 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2726 if GCC considers string literals to be constants.
49cebcca 2727 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2728
35ac2a97
SM
27292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2730
fb103ca9
SM
2731 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2732 (print_preprocess, print_object): New macro to fix last change.
2733
35ac2a97
SM
2734 * print.c (print_preprocess): Don't forget font objects.
2735
62973b41
JB
27362011-03-16 Juanma Barranquero <lekktu@gmail.com>
2737
2738 * emacs.c (USAGE3): Doc fixes.
2739
0e48bb22
AS
27402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2741
2742 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2743 structure.
2744
7684e57b
JB
27452011-03-14 Juanma Barranquero <lekktu@gmail.com>
2746
2747 * lisp.h (VWindow_system, Qfile_name_history):
2748 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2749 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2750 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2751
2752 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2753 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2754
2755 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2756 * w32console.c (detect_input_pending, read_input_pending)
2757 (encode_terminal_code):
2758 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2759 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2760 (w32_system_caret_y, Qfile_name_history):
2761 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2762 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2763 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2764 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2765 * w32proc.c (Qlocal, report_file_error):
2766 * w32term.c (Vwindow_system, updating_frame):
2767 * w32uniscribe.c (initialized, uniscribe_font_driver):
2768 Remove unneeded extern declarations.
2769
2aa46d6c
CY
27702011-03-14 Chong Yidong <cyd@stupidchicken.com>
2771
c96bbc66 2772 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2773
cffc6f3b
CY
27742011-03-13 Chong Yidong <cyd@stupidchicken.com>
2775
2776 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2777 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2778 These macros can no longer be used for assignment.
2779
44f230aa
SM
2780 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2781 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2782 (record_buffer_markers, fetch_buffer_markers): New functions for
2783 recording and fetching special buffer markers.
2784 (set_buffer_internal_1, set_buffer_temp): Use them.
2785
2786 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2787
2788 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2789
2790 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2791 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2792
2793 * xdisp.c (hscroll_window_tree):
2794 (reconsider_clip_changes): Use PT instead of BUF_PT.
2795
d251f04b
EZ
27962011-03-13 Eli Zaretskii <eliz@gnu.org>
2797
2798 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2799 $(EMACS_ROOT)/lib/intprops.h.
2800
f0c77cd1
PE
28012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2802
3eca4629
PE
2803 Fix more problems found by GCC 4.5.2's static checks.
2804
7c86ee98
PE
2805 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2806 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2807 (xg_free_frame_widgets): Make it clear that a local variable is
2808 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2809 (gdk_window_get_screen): Make it clear that this macro is needed
2810 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2811 (int_gtk_range_get_value): New function, which avoids a diagnostic
2812 from gcc -Wbad-function-cast.
2813 (xg_set_toolkit_scroll_bar_thumb): Use it.
2814 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2815 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2816 (get_utf8_string, xg_get_file_with_chooser):
2817 Rename locals to avoid shadowing.
2818 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2819
41729b81
PE
2820 * xgselect.c (xg_select): Remove unused var.
2821
f0c77cd1
PE
2822 * image.c (four_corners_best): Mark locals as initialized.
2823 (gif_load): Initialize transparent_p to zero (Bug#8238).
2824 Mark another local as initialized.
ec6cf4c6 2825 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2826
ce0ad53d 2827 * image.c (clear_image_cache): Now static.
d5d5a617 2828 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2829 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2830 (x_edge_detection): Remove unnecessary cast that
2831 gcc -Wbad-function-cast diagnoses.
2037898d 2832 (gif_load): Fix pointer signedness.
6ae141d6
PE
2833 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2834 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2835
33383987 28362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2837
d32df629
PE
2838 Improve quality of tests for time stamp overflow.
2839 For example, without this patch (encode-time 0 0 0 1 1
2840 1152921504606846976) returns the obviously-bogus value (-948597
2841 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2842 reports time overflow. See
2843 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2844 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2845 * editfns.c: Include limits.h and intprops.h.
2846 (TIME_T_MIN, TIME_T_MAX): New macros.
2847 (time_overflow): Move earlier, to before first use.
2848 (hi_time, lo_time): New functions, for an accurate test for
2849 out-of-range times.
2850 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2851 (Fget_internal_run_time): Don't assume time_t fits in int.
2852 (make_time): Use list2 instead of Fcons twice.
2853 (Fdecode_time): More accurate test for out-of-range times.
2854 (check_tm_member): New function.
2855 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2856 (lisp_time_argument): Don't rely on undefined left-shift and
2857 right-shift behavior when checking for time stamp overflow.
8be6f318 2858
fe31d94c
PE
2859 * editfns.c (time_overflow): New function, refactoring common code.
2860 (Fformat_time_string, Fdecode_time, Fencode_time):
2861 (Fcurrent_time_string): Use it.
2862
8be6f318
PE
2863 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2864 * dired.c (make_time): Move to ...
2865 * editfns.c (make_time): ... here.
2866 * systime.h: Note the move.
2867
09d9db2c 28682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2869
126bc0dc
YM
2870 * fringe.c (update_window_fringes): Remove unused variables.
2871
c47cbdfd
YM
2872 * unexmacosx.c (copy_data_segment): Also copy __got section.
2873 (Bug#8223)
2874
7ac80be9
EZ
28752011-03-12 Eli Zaretskii <eliz@gnu.org>
2876
c96bbc66 2877 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2878 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2879 Constify `char *' arguments and their references according to
2880 prototypes in tparam.h.
2881
ecb0f94d 2882 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2883
7ac80be9
EZ
2884 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2885 Adapt all references accordingly.
2886
2887 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2888
ef1fd07e
TT
28892011-03-11 Tom Tromey <tromey@redhat.com>
2890
2891 * buffer.c (syms_of_buffer): Remove obsolete comment.
2892
7ef4b50c
EZ
28932011-03-11 Eli Zaretskii <eliz@gnu.org>
2894
2895 * termhooks.h (encode_terminal_code): Declare prototype.
2896
2897 * msdos.c (encode_terminal_code): Don't declare prototype.
2898
2899 * term.c (encode_terminal_code): Now external again, used by
2900 w32console.c and msdos.c.
2901
44f230aa
SM
2902 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2903 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2904
4b1ec863 29052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2906
1714f52b 2907 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2908
4b1ec863
PE
2909 * fringe.c (update_window_fringes): Mark locals as initialized
2910 (Bug#8227).
2911 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2912
524c7aa6
PE
2913 * alloc.c (mark_fringe_data): Move decl from here ...
2914 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2915 to check its interface.
2916 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2917
a5c0af81 2918 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2919 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2920 (fontset_font): Mark local as initialized.
a9a06e0b 2921 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2922
b4716021
PE
2923 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2924
811e9bac 2925 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2926 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2927 (x_own_selection, Fx_disown_selection_internal): Rename locals
2928 to avoid shadowing.
2929 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2930
7e3ab302
PE
2931 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2932 so that the caller can use some name other than gcpro1.
2933 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2934 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2935 (Fx_backspace_delete_keys_p):
2936 Use them to avoid shadowing, and rename vars to avoid shadowing.
2937 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2938 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2939 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2940 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2941 Remove unused locals.
7e3ab302
PE
2942 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2943 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2944 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2945 macros.
f78faa98 2946
e2b13473
PE
2947 * xterm.h (x_mouse_leave): New decl.
2948
77f23912
PE
2949 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2950 Remove unused functions.
cdf4ba58
PE
2951 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2952 (x_calc_absolute_position): Now static.
7411c686 2953 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2954 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2955 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2956 unless they are used.
38d0b34a
PE
2957 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2958 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2959 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2960 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2961 (x_error_catcher, x_connection_closed, x_error_handler):
2962 (x_error_quitter, xembed_send_message, x_iconify_frame):
2963 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2964 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2965 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2966
44f230aa
SM
2967 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2968 Rename or move locals to avoid shadowing.
6b463e58 2969 (tty_defined_color, merge_face_heights): Now static.
5967d051 2970 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2971 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2972 does not deduce is never used uninitialized.
73719eba
PE
2973 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2974 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2975
426994c3 2976 * terminal.c (store_terminal_param): Now static.
5489860b 2977
032f1620 2978 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2979 (set_frame_menubar): Remove unused local.
d4323972 2980 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2981 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2982 since they might point to immutable storage.
281585b0
PE
2983 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2984 since it's unused otherwise.
032f1620 2985
367c19e5 2986 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2987 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2988 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2989 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2990 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2991 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2992 does not deduce are never used uninitialized.
70739cbe 2993
07b48fa9
PE
2994 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2995
8868a238 2996 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2997 * window.c (window_loop, size_window):
2998 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2999
7e5cf297 3000 * window.c (display_buffer): Now static.
d6550a9f
PE
3001 (size_window): Mark variables that gcc -Wuninitialized
3002 does not deduce are never used uninitialized.
a586633d
PE
3003 * window.h (check_all_windows): New decl, to forestall
3004 gcc -Wmissing-prototypes diagnostic.
5b555da1 3005 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3006
f6095868
PE
3007 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3008 shadowing.
3009 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3010 Include <limits.h>.
3011 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3012 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3013 (load_charset_map): Mark variables that gcc -Wuninitialized
3014 does not deduce are never used uninitialized.
53df7c11 3015 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3016
f38b440c
PE
3017 * coding.c (coding_set_source, coding_set_destination):
3018 Use "else { /* comment */ }" rather than "else /* comment */;"
3019 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3020 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3021 a block, when the outer 'i' will do.
3022 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3023 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3024 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3025 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3026 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3027 Rename locals to avoid shadowing.
3028 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3029 * coding.c (emacs_mule_char, encode_invocation_designation):
3030 Now static, since they're not used elsewhere.
413bb2db 3031 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3032 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3033 (decode_coding_emacs_mule): Mark variables that gcc
3034 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3035 (detect_coding_iso_2022): Initialize a local variable that might
3036 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3037 this initialization is needed. (Bug#8211)
5f58e762
PE
3038 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3039 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3040 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3041 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3042 Remove unused macros.
f38b440c 3043
232b38b9 3044 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3045 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3046 * character.c (string_count_byte8): Likewise.
232b38b9 3047
fb90da1b
PE
3048 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3049 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3050
fb93dbc2
PE
3051 * chartab.c (copy_sub_char_table): Now static, since it's not used
3052 elsewhere.
5c156ace
PE
3053 (sub_char_table_ref_and_range, char_table_ref_and_range):
3054 Rename locals to avoid shadowing.
bbcd0949 3055 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3056
7d3b3862 3057 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3058 (BIDI_BOB): Remove unused macro.
7d3b3862 3059
6be7d3da
PE
3060 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3061 deduce are never used uninitialized.
c2ed9c8b 3062 * term.c (encode_terminal_code): Likewise.
6be7d3da 3063
75f8807f 3064 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3065
50938595
PE
3066 * tparam.h: New file.
3067 * term.c, tparam.h: Include it.
3068 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3069 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3070 Move these decls to tparam.h, and make them agree with what
3071 is actually in tparam.c. The previous trick of using incompatible
3072 decls in different modules does not conform to the C standard.
3073 All callers of tparam changed to use tparam's actual API.
3074 * tparam.c (tparam1, tparam, tgoto):
3075 Use const pointers where appropriate.
3076
fbceeba2
PE
3077 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3078 * cm.h (struct cm): Likewise.
3079 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3080 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3081 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3082 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3083 (turn_on_face, init_tty): Likewise.
3084 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3085
7f3f1250
PE
3086 * term.c (term_mouse_position): Rename local to avoid shadowing.
3087
e6ca6543
PE
3088 * alloc.c (mark_ttys): Move decl from here ...
3089 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3090
c40f8d15
AS
30912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3092
3093 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3094
cfe0661d
JB
30952011-03-09 Juanma Barranquero <lekktu@gmail.com>
3096
3097 * search.c (compile_pattern_1): Remove argument regp, unused since
3098 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3099 (compile_pattern): Don't pass it.
3100
0afb4571
J
31012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3102
3103 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3104 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3105 for ! HAVE_GTK3.
3106 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3107
3108 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3109
3110 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3111 gdk_window_get_screen, gdk_window_get_geometry,
3112 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3113 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3114 (xg_get_pixbuf_from_pixmap): New function.
3115 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3116 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3117 Call xg_get_pixbuf_from_pixmap instead of
3118 gdk_pixbuf_get_from_drawable.
3119 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3120 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3121 (xg_check_special_colors): Use GtkStyleContext and its functions
3122 for HAVE_GTK3.
3123 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3124 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3125 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3126 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3127 Call gtk_widget_get_preferred_size.
0afb4571
J
3128 (xg_frame_resized): gdk_window_get_geometry only takes 5
3129 parameters.
44f230aa
SM
3130 (xg_win_to_widget, xg_event_is_for_menubar):
3131 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3132 (xg_set_widget_bg): New function.
3133 (delete_cb): New function.
895009e1 3134 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3135 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3136 (xg_set_background_color): Call xg_set_widget_bg.
3137 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3138 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3139 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3140 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3141 if ! HAVE_GTK3.
3142 (update_frame_tool_bar): Call gtk_widget_hide.
3143 (xg_initialize): Use GDK_KEY_g.
3144
3145 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3146 if ! HAVE_GTK3
3147 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3148
3149 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3150 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3151 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3152
1c2cc4ef
JB
31532011-03-08 Juanma Barranquero <lekktu@gmail.com>
3154
3155 * w32xfns.c (select_palette): Check success of RealizePalette against
3156 GDI_ERROR, not zero.
3157
33383987 3158See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3159
3160;; Local Variables:
3161;; coding: utf-8
aac0c6e3
MR
3162;; End:
3163
33383987 3164 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3165
3166 This file is part of GNU Emacs.
3167
3168 GNU Emacs is free software: you can redistribute it and/or modify
3169 it under the terms of the GNU General Public License as published by
3170 the Free Software Foundation, either version 3 of the License, or
3171 (at your option) any later version.
3172
3173 GNU Emacs is distributed in the hope that it will be useful,
3174 but WITHOUT ANY WARRANTY; without even the implied warranty of
3175 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3176 GNU General Public License for more details.
3177
3178 You should have received a copy of the GNU General Public License
3179 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.