* fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f26d0e4c
PE
12011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2
8a10d76c
PE
3 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4 so that it is not optimized away.
5
f26d0e4c
PE
6 * xdisp.c (compute_display_string_pos): Remove unused local.
7
55439c61
EZ
82011-08-02 Eli Zaretskii <eliz@gnu.org>
9
10 Fix slow cursor motion and scrolling in large buffers with
11 selective display, like Org Mode buffers. (Bug#9218)
12
13 * dispextern.h (struct bidi_it): New member disp_prop_p.
14
15 * xdisp.c: Remove one-slot cache of display string positions.
16 (compute_display_string_pos): Accept an additional argument
17 DISP_PROP_P; callers changed. Scan at most 5K characters forward
18 for a display string or property. If found, set DISP_PROP_P
19 non-zero.
20
21 * bidi.c (bidi_fetch_char): Accept an additional argument
22 DISP_PROP_P, and pass it to compute_display_string_pos. Only
23 handle text covered by a display string if DISP_PROP_P is returned
24 non-zero. All callers of bidi_fetch_char changed.
25
fb33fa43
SM
262011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
27
28 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
29
b099e063
DM
302010-12-03 Don March <don@ohspite.net>
31
32 * keymap.c (Fdefine_key): Fix non-prefix key error message when
33 last character M-[char] is translated to ESC [char] (bug#7541).
34
5cc7f7af
KH
352011-08-02 Kenichi Handa <handa@m17n.org>
36
d0fffa3f 37 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
38
39 * chartab.c (uniprop_table): Make it non-static.
40
525d5e6e
EZ
412011-08-01 Eli Zaretskii <eliz@gnu.org>
42
43 * xdisp.c (forward_to_next_line_start): Accept additional argument
44 BIDI_IT_PREV, and store into it the state of the bidi iterator had
45 on the newline.
46 (reseat_at_next_visible_line_start): Use the bidi iterator state
47 returned by forward_to_next_line_start to restore the state of
48 it->bidi_it after backing up to previous newline. (Bug#9212)
49
31011111
AS
502011-07-30 Andreas Schwab <schwab@linux-m68k.org>
51
52 * regex.c (re_comp): Protoize.
53 (re_exec): Fix return type.
54 (regexec): Fix type of `ret'. (Bug#9203)
55
e5d76069
PE
562011-07-29 Paul Eggert <eggert@cs.ucla.edu>
57
58 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
59 This is needed if max-image-size is a floating-point number.
60
9a79b20c
AS
612011-07-28 Andreas Schwab <schwab@linux-m68k.org>
62
63 * print.c (print_object): Print empty symbol as ##.
64
65 * lread.c (read1): Read ## as empty symbol.
66
d8c2fa78
AA
672011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
68
69 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
70 setting frame foreground color (Bug#9175).
71 (x_set_background_color): Likewise.
72
ffe57a7a
AA
73 * nsmenu.m (-setText): Size tooltip dimensions precisely to
74 contents (Bug#9176).
75 (EmacsTooltip -init): Remove bezels and add shadows to
76 tooltip windows.
77
bf3492a5
AA
78 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
79 or scroll bar (Bug#8470).
80
d55e9c53
AA
81 * nsfont.m (nsfont_open): Remove assignment to voffset and
82 unnecessary vars hshink, expand, hd, full_height, min_height.
83 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
84
85 * nsterm.h (nsfont_info): Remove voffset field.
86
d8c2fa78 872011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
88
89 Implement strike-through and overline on NextStep (Bug#8863).
90
91 * nsfont.m (nsfont_open): Use underline position provided by font,
92 instead of hard-coded value of 2.
93 (nsfont_draw): Call ns_draw_text_decoration instead.
94
95 * nsterm.h: Add declaration for ns_draw_text_decoration.
96
97 * nsterm.m (ns_draw_text_decoration): New function for drawing
98 underline, overline, and strike-through.
99 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
100 ns_draw_text_decoration. Change treatment of cursor drawing to
101 accomodate underlining, etc.
102
4cc60b9b
EZ
1032011-07-28 Eli Zaretskii <eliz@gnu.org>
104
bc7ece87
EZ
105 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
106 default.
4cc60b9b 107
476371c4
PE
1082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
109
66606eea
PE
110 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
111 Without this fix, if a signal arrives just after memory fills up,
112 'malloc' might be invoked reentrantly.
113
476371c4
PE
114 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
115 In other words, assume that every image size is allowed, on non-X
116 hosts. This assumption is probably wrong, but it lets Emacs compile.
117
f3fcc40d
AS
1182011-07-28 Andreas Schwab <schwab@linux-m68k.org>
119
120 * regex.c (re_iswctype): Convert return values to boolean.
121
350c992f
EZ
1222011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
123
124 * xdisp.c (compute_display_string_pos): Don't use cached display
125 string position if the buffer had its restriction changed.
126 (Bug#9184)
127
5266b4bb
PE
1282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
129
130 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
131
2573a837 1322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 133
41f55ccd 134 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 135
39e378da
PE
136 * bidi.c: Integer size and overflow fixes.
137 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
138 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
139 (bidi_cache_find_level_change, bidi_cache_ensure_space)
140 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
141 (bidi_find_other_level_edge):
142 Use ptrdiff_t instead of EMACS_INT where either will do.
143 This works better on 32-bit hosts configured --with-wide-int.
144 (bidi_cache_ensure_space): Check for size-calculation overflow.
145 Use % rather than repeated addition, for better worst-case speed.
146 Don't set bidi_cache_size until after xrealloc returns, because it
147 might not return.
148 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
149 (bidi_cache_ensure_space): Also check that the bidi cache size
150 does not exceed that of the largest Lisp string or buffer. See Eli
151 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 152
5e927815
PE
153 * alloc.c (__malloc_size_t): Remove.
154 All uses replaced by size_t. See Andreas Schwab's note
155 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
156
ca4aa935
PE
157 * image.c: Improve checking for integer overflow.
158 (check_image_size): Assume that f is nonnull, since
159 it is always nonnull in practice. This is one less thing to
160 worry about when checking for integer overflow later.
161 (x_check_image_size): New function, which checks for integer
162 overflow issues inside X.
163 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
164 This removes the need for a memory_full check.
165 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
166 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
167 (xbm_read_bitmap_data): Change locals back to 'int', since
168 their values must fit in 'int'.
169 (xpm_load_image, png_load, tiff_load):
170 Invoke x_create_x_image_and_pixmap earlier,
171 to avoid much needless work if the image is too large.
172 (tiff_load): Treat overly large images as if
173 x_create_x_image_and_pixmap failed, not as malloc failures.
174 (gs_load): Use x_check_image_size.
175
5f8f9cc2
PE
176 * gtkutil.c: Omit integer casts.
177 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
178 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
179
5adf60bc
PE
180 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
181
c8907a93
PE
182 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
183 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
184 would wrongly return t on a 64-bit host.
185
e3c25c68
PE
186 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
187 The plain *_OVERFLOW macros run afoul of GCC bug 49705
188 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
189 and therefore cause GCC to emit a bogus diagnostic in some cases.
190
3f791afe
PE
191 * image.c: Integer signedness and overflow and related fixes.
192 This is not an exhaustive set of fixes, but it's time to
193 record what I've got.
194 (lookup_pixel_color, check_image_size): Remove redundant decls.
195 (check_image_size): Don't assume that arbitrary EMACS_INT values
196 fit in 'int', or that arbitrary 'double' values fit in 'int'.
197 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
198 (tiff_load, imagemagick_load_image):
199 Check for overflow in size calculations.
200 (x_create_x_image_and_pixmap): Remove unnecessary test for
201 xmalloc returning NULL; that can't happen.
202 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
203 (xpm_color_bucket): Use better integer hashing function.
204 (xpm_cache_color): Don't possibly over-allocate memory.
205 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
206 (gif_memory_source):
207 Use ptrdiff_t, not int or size_t, to record sizes.
208 (png_load): Don't assume values greater than 2**31 fit in 'int'.
209 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
210 either works, as we prefer signed integers.
211 (tiff_read_from_memory, tiff_write_from_memory):
212 Return tsize_t, not size_t, since that's what the TIFF API wants.
213 (tiff_read_from_memory): Don't fail simply because the read would
214 go past EOF; instead, return a short read.
215 (tiff_load): Omit no-longer-needed casts.
216 (Fimagemagick_types): Don't assume size fits into 'int'.
217
3cc5a532
PE
218 Improve hashing quality when configured --with-wide-int.
219 * fns.c (hash_string): New function, taken from sxhash_string.
220 Do not discard information about ASCII character case; this
221 discarding is no longer needed.
222 (sxhash-string): Use it. Change sig to match it. Caller changed.
223 * lisp.h: Declare it.
224 * lread.c (hash_string): Remove, since we now use fns.c's version.
225 The fns.c version returns a wider integer if --with-wide-int is
226 specified, so this should help the quality of the hashing a bit.
227
b312a492
PE
228 * emacs.c: Integer overflow minor fix.
229 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
230 Define only if GNU_LINUX.
231 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
232
dfd153ae
PE
233 * dispnew.c: Integer signedness and overflow fixes.
234 Remove unnecessary forward decls, that were a maintenance hassle.
235 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
236 All uses changed.
237 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
238 (scrolling_window): Use ptrdiff_t, not int, for byte count.
239 (prepare_desired_row, line_draw_cost):
240 Use int, not unsigned, where either works.
241 (save_current_matrix, restore_current_matrix):
242 Use ptrdiff_t, not size_t, where either works.
243 (init_display): Check for overflow more accurately, and without
244 relying on undefined behavior.
245
a81d11a3
PE
246 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
247 Remove, replacing with the new symbols in lisp.h. All uses changed.
248 * fileio.c (make_temp_name):
249 * filelock.c (lock_file_1, lock_file):
250 * xdisp.c (message_dolog):
251 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
252 Use pMd etc. instead.
253 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
254 replacing the pWIDE etc. symbols removed from editfns.c.
255
3300e6fd
PE
256 * keyboard.h (num_input_events): Now uintmax_t.
257 This is (very slightly) less likely to mess up due to wraparound.
258 All uses changed.
259
fd05c7e9
PE
260 * buffer.c: Integer signedness fixes.
261 (alloc_buffer_text, enlarge_buffer_text):
262 Use ptrdiff_t rather than size_t when either will do, as we prefer
263 signed integers.
264
903fe15d
PE
265 * alloc.c: Integer signedness and overflow fixes.
266 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
267 (__malloc_size_t): Default to size_t, not to int.
268 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
269 (Fgarbage_collect, mark_object_loop_halt, mark_object):
270 Prefer ptrdiff_t to size_t when either would do, as we prefer
271 signed integers.
272 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
273 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
274 Now const. Initialize with values that are in range even if char
275 is signed.
276 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
277 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
278 These functions do the right thing with sizes > 2**32.
279 (check_depth): Now ptrdiff_t, not int.
280 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
281 Adjust to new way of storing sizes. Check for size overflow bugs
282 in rest of code.
283 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
284 slightly wrong anyway, as it missed one instance of
285 XMALLOC_OVERRUN_CHECK_OVERHEAD.
286 (refill_memory_reserve): Omit needless cast to size_t.
287 (mark_object_loop_halt): Mark as externally visible.
288
ac82cc6a
PE
289 * xselect.c: Integer signedness and overflow fixes.
290 (Fx_register_dnd_atom, x_handle_dnd_message):
291 Use ptrdiff_t, not size_t, since we prefer signed.
292 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
293 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
294 x_dnd_atoms_size and x_dnd_atoms_length.
295
c2d1e36d
PE
296 * doprnt.c: Prefer signed to unsigned when either works.
297 * eval.c (verror):
298 * doprnt.c (doprnt):
299 * lisp.h (doprnt):
300 * xdisp.c (vmessage):
301 Use ptrdiff_t, not size_t, when using or implementing doprnt,
302 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
303 prefer signed arithmetic to avoid comparison confusion.
304 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
305 but is a bit tricky.
306
0e926e56
PE
307 Assume freestanding C89 headers, string.h, stdlib.h.
308 * data.c, doprnt.c, floatfns.c, print.c:
309 Include float.h unconditionally.
310 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
311 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
312 * regex.c: Likewise for stddef.h, string.h.
313 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
314 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
315 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
316 (STDC_HEADERS): Remove obsolete defines.
317 * sysdep.c: Include limits.h unconditionally.
318
9cfdb3ec
PE
319 Assume support for memcmp, memcpy, memmove, memset.
320 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
321 * regex.c (memcmp, memcpy):
322 Remove; we assume C89 now.
323
324 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
325 (__malloc_safe_bcopy): Remove; no longer needed.
326
cf950e6b 327 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
328 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
329 well either way, and we prefer signed to unsigned.
330
dbf38e02
LMI
3312011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
332
333 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
334 closes the connection while we're reading (bug#9182).
335
d6f0886c
JD
3362011-07-25 Jan Djärv <jan.h.d@swipnet.se>
337
338 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
339 are specified (Bug#9168).
340
2eb1f9e6
PE
3412011-07-25 Paul Eggert <eggert@cs.ucla.edu>
342
343 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
344 Found by GCC static checking and --with-wide-int on a 32-bit host.
345
22381272 3462011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
347
348 * xdisp.c (compute_display_string_pos): Fix logic of caching
349 previous display string position. Initialize cached_prev_pos to
350 -1. Fixes slow-down at the beginning of a buffer.
351
f25e39b4
EZ
3522011-07-24 Eli Zaretskii <eliz@gnu.org>
353
354 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
355 for attrs[LFACE_FONTSET_INDEX].
356
04c4b52e
PE
3572011-07-23 Paul Eggert <eggert@cs.ucla.edu>
358
359 * xml.c (parse_region): Remove unused local
360 that was recently introduced.
361
c1734fbd
EZ
3622011-07-23 Eli Zaretskii <eliz@gnu.org>
363
be18c5a5
EZ
364 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
365 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
366
c1734fbd
EZ
367 * xdisp.c (move_it_in_display_line_to): Record the best matching
368 position for TO_CHARPOS while scanning the line, and restore it on
369 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
370 vertical-motion and pos-visible-in-window-p under bidi redisplay
371 when exact match is impossible due to invisible text, and the
372 lines are truncated.
373
a258d627
JD
3742011-07-23 Jan Djärv <jan.h.d@swipnet.se>
375
376 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
377 for OSX >= 10.7.
378
b6d5a689
EZ
3792011-07-22 Eli Zaretskii <eliz@gnu.org>
380
0f74f785
EZ
381 Fix a significant slow-down of cursor motion with C-n, C-p,
382 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
383 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 384 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
385 (next_element_from_buffer): Call compute_stop_pos_backwards to
386 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
387 base_level_stop.
388 (reseat): Don't look for prev_stop, as that could mean a very long
389 run.
390 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
391 <cached_disp_overlay_modiff>: Cache for last found display string
392 position.
551918c1 393 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
394 about the same buffer in the same area of character positions, and
395 the buffer wasn't changed since the time the display string
396 position was cached.
551918c1 397
b2d0c91a
EZ
3982011-07-22 Eli Zaretskii <eliz@gnu.org>
399
400 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
401 is an integer, which is important for empty lines. (Bug#9149)
402
043604ee
CY
4032011-07-22 Chong Yidong <cyd@stupidchicken.com>
404
405 * frame.c (Fmodify_frame_parameters): In tty case, update the
406 default face if necessary (Bug#4238).
407
da4adb04
CY
4082011-07-21 Chong Yidong <cyd@stupidchicken.com>
409
410 * editfns.c (Fstring_to_char): No need to explain what a character
411 is in the docstring (Bug#6576).
412
9abd0532
LMI
4132011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
414
415 * xml.c (parse_region): Make sure we always return a tree.
416
36881d16
HK
4172011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
418
419 * xml.c (parse_region): If a document contains only comments,
420 return that, too.
421
1e98674d
LMI
4222011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
423
424 * xml.c (make_dom): Return comments, too.
425
590bd467
PE
4262011-07-19 Paul Eggert <eggert@cs.ucla.edu>
427
428 Port to OpenBSD.
429 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
430 and the surrounding thread.
431 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
432 rather than fgets, and retry after EINTR. Otherwise, 'emacs
433 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
434 timer goes off.
435 * s/openbsd.h (BROKEN_SIGIO): Define.
436 * unexelf.c (unexec) [__OpenBSD__]:
437 Don't update the .mdebug section of the Alpha COFF symbol table.
438
f41628b2
LMI
4392011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
440
441 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
442 (bug#8460).
443
b59b67c5
PE
4442011-07-18 Paul Eggert <eggert@cs.ucla.edu>
445
15e3a074
PE
446 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
447 This fixes some race conditions on the permissions of any newly
448 created file.
449
41bed37d
PE
450 * alloc.c (valid_pointer_p): Use pipe, not open.
451 This fixes some permissions issues when debugging.
452
b59b67c5
PE
453 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
454 If fchown fails to set both uid and gid, try to set just gid,
455 as that is sometimes allowed. Adjust the file's mode to eliminate
456 setuid or setgid bits that are inappropriate if fchown fails.
457
925a6be7
SM
4582011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
459
460 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
461 to compare Lisp_Objects.
462 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
463 global_gnutls_log_level, don't mistake it for a Lisp_Object.
464 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
465
52968808
AS
4662011-07-17 Andreas Schwab <schwab@linux-m68k.org>
467
0a6a104b
AS
468 * lread.c (read_integer): Unread even EOF character.
469 (read1): Likewise. Properly record start position of symbol.
470
52968808
AS
471 * lread.c (read1): Read `#:' as empty uninterned symbol if no
472 symbol character follows.
473
9e381cdd
PE
4742011-07-17 Paul Eggert <eggert@cs.ucla.edu>
475
476 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
477 This works around a problem with the previous change to Fcopy_file.
478 Recent glibc declares fchown with __attribute__((warn_unused_result)),
479 and without this change, GCC might complain about discarding
480 fchown's return value.
481
b5641435
JB
4822011-07-16 Juanma Barranquero <lekktu@gmail.com>
483
484 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
485
a8031457
PE
4862011-07-16 Paul Eggert <eggert@cs.ucla.edu>
487
488 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
489
dd889327
LMI
4902011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
491
750c33f7
LMI
492 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
493 it's used from the C level.
494
dd889327
LMI
495 * process.c: Use the same condition for POLL_FOR_INPUT in both
496 keyboard.c and process.c (bug#1858).
497
87e86684
LM
4982011-07-09 Lawrence Mitchell <wence@gmx.li>
499
500 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
501 (Fgnutls_boot): Use it.
502
64348f40
AS
5032011-07-15 Andreas Schwab <schwab@linux-m68k.org>
504
505 * doc.c (Fsubstitute_command_keys): Revert last change.
506
1d698799
LMI
5072011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
508
f863868c
LMI
509 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
510 quotes the next character, and doesn't affect other longer
511 sequences (bug#8935).
512
1d698799
LMI
513 * lread.c (syms_of_lread): Clarify that is isn't only
514 `eval-buffer' and `eval-defun' that's affected by
515 `lexical-binding' (bug#8460).
516
aa4b6df6
EZ
5172011-07-15 Eli Zaretskii <eliz@gnu.org>
518
519 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
520 bidi redisplay when a line includes both an image and is
521 truncated.
522
5d856da6
PE
5232011-07-14 Paul Eggert <eggert@cs.ucla.edu>
524
ad6042bb
PE
525 Fix minor problems found by static checking.
526 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
527 (elsz): Now a signed constant, not a size_t var. We prefer signed
528 types to unsigned, to avoid integer comparison confusion. Without
529 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
530 "cannot optimize loop, the loop counter may overflow", a symptom
531 of the confusion.
f00bbb22 532 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
533 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
534
6468f31c
LMI
5352011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
536
49080b10
LMI
537 * search.c (Fre_search_backward): Mention `case-fold-search' in
538 all the re_search_* functions (bug#8138).
539
6468f31c
LMI
540 * keyboard.c (Fopen_dribble_file): Document when the file is
541 closed (bug#8056).
542
c965adc5
EZ
5432011-07-14 Eli Zaretskii <eliz@gnu.org>
544
df9733bf
EZ
545 * bidi.c (bidi_dump_cached_states): Fix format of displaying
546 bidi_cache_idx.
547
0bb23927
EZ
548 Support bidi reordering of display and overlay strings.
549 * xdisp.c (compute_display_string_pos)
550 (compute_display_string_end): Accept additional argument STRING.
551 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
552 (reseat_to_string): Initialize bidi_it->string.s and
553 bidi_it->string.schars.
554 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
555 NULL (avoids a crash in bidi_paragraph_init). Initialize
556 itb.string.lstring.
557 (init_iterator): Call bidi_init_it only of a valid
558 buffer position was specified. Initialize paragraph_embedding to
559 L2R.
560 (reseat_to_string): Initialize the bidi iterator.
561 (display_string): If we need to ignore text properties of
562 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
563 original value of -1 will not work with bidi.)
564 (compute_display_string_pos): First arg is now struct
565 `text_pos *'; all callers changed. Support display properties on
566 Lisp strings.
567 (compute_display_string_end): Support display properties on Lisp
568 strings.
569 (init_iterator, reseat_1, reseat_to_string): Initialize the
570 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
571 when iterating on a string not from display properties).
572 (compute_display_string_pos, compute_display_string_end): Fix
573 calculation of the object to scan. Fixes an error when using
574 arrow keys.
575 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
576 base_level_stop; instead, set base_level_stop to BEGV. Fixes
577 crashes in vertical-motion.
578 (next_element_from_buffer): Improve commentary for when
579 the iterator is before prev_stop.
580 (init_iterator): Initialize bidi_p from the default value of
581 bidi-display-reordering, not from buffer-local value. Use the
582 buffer-local value only if initializing for buffer iteration.
583 (handle_invisible_prop): Support invisible properties on strings
584 that are being bidi-reordered.
585 (set_iterator_to_next): Support bidi reordering of C strings and
586 Lisp strings.
587 (next_element_from_string): Support bidi reordering of Lisp
588 strings.
589 (handle_stop_backwards): Support Lisp strings as well.
590 (display_string): Support display of R2L glyph rows. Use
591 IT_STRING_CHARPOS when displaying from a Lisp string.
592 (init_iterator): Don't initialize it->bidi_p for strings
593 here.
594 (reseat_to_string): Initialize it->bidi_p for strings here.
595 (next_element_from_string, next_element_from_c_string)
596 (next_element_from_buffer): Add xassert's for correspondence
597 between IT's object being iterated and it->bidi_it.string
598 structure.
599 (face_before_or_after_it_pos): Support bidi iteration.
600 (next_element_from_c_string): Handle the case of the first string
601 character that is not the first one in the visual order.
602 (get_visually_first_element): New function, refactored from common
603 parts of next_element_from_buffer, next_element_from_string, and
604 next_element_from_c_string.
605 (tool_bar_lines_needed, redisplay_tool_bar)
606 (display_menu_bar): Force left-to-right direction. Add a FIXME
607 comment for making that be controlled by a user option.
608 (push_it, pop_it): Save and restore the state of the
609 bidi iterator. Save and restore the bidi_p flag.
610 (pop_it): Iterate out of display property for string iteration as
611 well.
612 (iterate_out_of_display_property): Support iteration over strings.
613 (handle_single_display_spec): Set up it->bidi_it for iteration
614 over a display string, and call bidi_init_it.
615 (handle_single_display_spec, next_overlay_string)
616 (get_overlay_strings_1, push_display_prop): Set up the bidi
617 iterator for displaying display or overlay strings.
618 (forward_to_next_line_start): Don't use the shortcut if
619 bidi-iterating.
620 (back_to_previous_visible_line_start): If handle_display_prop
621 pushed the iterator stack, restore the internal state of the bidi
622 iterator by calling bidi_pop_it same number of times.
623 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
624 and we are bidi-iterating, don't decrement the iterator position;
625 instead, set the first_elt flag in the bidi iterator, to produce
626 the same effect.
627 (reseat_1): Remove redundant setting of string_from_display_prop_p.
628 (push_display_prop): xassert that we are iterating a buffer.
629 (push_it, pop_it): Save and restore paragraph_embedding member.
630 (handle_single_display_spec, next_overlay_string)
631 (get_overlay_strings_1, reseat_1, reseat_to_string)
632 (push_display_prop): Set up the `unibyte' member of bidi_it.string
633 correctly. Don't assume unibyte strings are not bidi-reordered.
634 (compute_display_string_pos)
635 (compute_display_string_end): Fix handling the case of C string.
636 (push_it, pop_it): Save and restore from_disp_prop_p.
637 (handle_single_display_spec, push_display_prop): Set the
638 from_disp_prop_p flag.
639 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
640 (pop_it): Call iterate_out_of_display_property only if we are
641 popping after iteration over a string that came from a display
642 property. Fix a typo in popping stretch info. Add an assertion
643 for verifying that the iterator position is in sync with the bidi
644 iterator.
645 (handle_single_display_spec, get_overlay_strings_1)
646 (push_display_prop): Fix initialization of paragraph direction for
647 string when that of the parent object is not yet determined.
648 (reseat_1): Call bidi_init_it to resync the bidi
649 iterator with IT's position. (Bug#7616)
650 (find_row_edges): If ROW->start.pos gives position
651 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
652 (handle_stop, back_to_previous_visible_line_start, reseat_1):
653 Reset the from_disp_prop_p flag.
654 (SAVE_IT, RESTORE_IT): New macros.
655 (pos_visible_p, face_before_or_after_it_pos)
656 (back_to_previous_visible_line_start)
657 (move_it_in_display_line_to, move_it_in_display_line)
658 (move_it_to, move_it_vertically_backward, move_it_by_lines)
659 (try_scrolling, redisplay_window, display_line): Use them when
660 saving a temporary copy of the iterator and restoring it back.
661 (back_to_previous_visible_line_start, reseat_1)
662 (init_iterator): Empty the bidi cache "stack".
663 (move_it_in_display_line_to): If iterator ended up at
664 EOL, but we never saw any buffer positions smaller than
665 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
666 motion in bidi-reordered lines.
667 (move_it_in_display_line_to): Record prev_method and prev_pos
668 immediately before the call to set_iterator_to_next. Fixes cursor
669 motion in bidi-reordered lines with stretch glyphs and strings
670 displayed in margins. (Bug#8133) (Bug#8867)
671 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
672 TO_CHARPOS.
673 (pos_visible_p): Support positions in bidi-reordered lines. Save
674 and restore bidi cache.
675
676 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
677 (bidi_paragraph_info): Delete unused struct.
678 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
679 (bidi_cache_start): New variable.
680 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
681 to zero.
682 (bidi_cache_fetch_state, bidi_cache_search)
683 (bidi_cache_find_level_change, bidi_cache_iterator_state)
684 (bidi_cache_find, bidi_peek_at_next_level)
685 (bidi_level_of_next_char, bidi_find_other_level_edge)
686 (bidi_move_to_visually_next): Compare cache index with
687 bidi_cache_start rather than with zero.
688 (bidi_fetch_char): Accept new argument STRING; all callers
689 changed. Support iteration over a string. Support strings with
690 display properties. Support unibyte strings. Fix the type of
691 `len' according to what STRING_CHAR_AND_LENGTH expects.
692 (bidi_paragraph_init, bidi_resolve_explicit_1)
693 (bidi_resolve_explicit, bidi_resolve_weak)
694 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
695 iteration over a string.
696 (bidi_set_sor_type, bidi_resolve_explicit_1)
697 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
698 can now be zero (for strings); special values 0 and -1 were
699 changed to -1 and -2, respectively.
700 (bidi_char_at_pos): New function.
701 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
702 Call it instead of FETCH_MULTIBYTE_CHAR.
703 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
704 initialized to valid values.
705 (bidi_init_it): Don't initialize charpos and bytepos with invalid
706 values.
707 (bidi_level_of_next_char): Allow the sentinel "position" to pass
708 the test for valid cached positions. Fix the logic for looking up
709 the sentinel state in the cache. GCPRO the Lisp string we are
710 iterating.
711 (bidi_push_it, bidi_pop_it): New functions.
712 (bidi_initialize): Initialize the bidi cache start stack pointer.
713 (bidi_cache_ensure_space): New function, refactored from part of
714 bidi_cache_iterator_state. Don't assume the required size is just
715 one BIDI_CACHE_CHUNK away.
716 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
717 (bidi_count_bytes, bidi_char_at_pos): New functions.
718 (bidi_cache_search): Don't assume bidi_cache_last_idx is
719 always valid if bidi_cache_idx is valid.
720 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
721 is valid if it's going to be used.
722 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
723 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
724 (bidi_cache_find_level_change, bidi_cache_ensure_space)
725 (bidi_cache_iterator_state, bidi_cache_find)
726 (bidi_find_other_level_edge, bidi_cache_start_stack): All
727 variables related to cache indices are now EMACS_INT.
728
0bb23927
EZ
729 * dispextern.h (struct bidi_string_data): New structure.
730 (struct bidi_it): New member `string'. Make flag members be 1-bit
731 fields, and put them last in the struct.
732 (compute_display_string_pos, compute_display_string_end): Update
733 prototypes.
734 (bidi_push_it, bidi_pop_it): Add prototypes.
735 (struct iterator_stack_entry): New members bidi_p,
736 paragraph_embedding, and from_disp_prop_p.
737 (struct it): Member bidi_p is now a bit field 1 bit wide.
738 (bidi_shelve_cache, bidi_unshelve_cache): Declare
739 prototypes.
740
741 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
742 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
743 and vector-like objects.
744
745 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
746 cache around display iteration.
747
748 * window.c (Fwindow_end, window_scroll_pixel_based)
749 (displayed_window_lines, Frecenter): Save and restore the bidi
750 cache around display iteration.
751
3bbd2265
LMI
7522011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
753
754 * editfns.c (Fdelete_region): Clarify the use of the named
755 parameters (bug#6788).
756
adc47434
MR
7572011-07-14 Martin Rudalics <rudalics@gmx.at>
758
759 * indent.c (Fvertical_motion): Set and restore w->pointm when
760 saving and restoring the window's buffer (Bug#9006).
761
837c31f8
LMI
7622011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
763
764 * editfns.c (Fstring_to_char): Clarify just what is returned
765 (bug#6576). Text by Eli Zaretskii.
766
ac389d0c
JB
7672011-07-13 Juanma Barranquero <lekktu@gmail.com>
768
769 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
770
0be0ce47
EZ
7712011-07-13 Eli Zaretskii <eliz@gnu.org>
772
773 * buffer.c (mmap_find): Fix a typo.
774
cd18e7e3
JB
7752011-07-13 Johan Bockgård <bojohan@gnu.org>
776
777 Fix execution of x selection hooks.
778 * xselect.c (Qx_lost_selection_functions)
779 (Qx_sent_selection_functions): New vars.
780 (syms_of_xselect): DEFSYM them.
781 (x_handle_selection_request): Pass Qx_sent_selection_functions
782 rather than Vx_sent_selection_functions to Frun_hook_with_args.
783 (x_handle_selection_clear,x_clear_frame_selections):
784 Pass Qx_lost_selection_functions rather than
785 Vx_lost_selection_functions to Frun_hook_with_args.
786
47ea7f44
PE
7872011-07-13 Paul Eggert <eggert@cs.ucla.edu>
788
ac389d0c 789 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
790 The old code sometimes used this field without initializing it.
791
47ea7f44
PE
792 * alloc.c (gc_sweep): Don't read past end of array.
793 In theory, the old code could also have corrupted Emacs internals,
794 though it'd be very unlikely.
795
bc985c87
AS
7962011-07-12 Andreas Schwab <schwab@linux-m68k.org>
797
798 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 799 argument. (Bug#4026)
bc985c87 800
0cf34688
LMI
8012011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
802
b3dadd76
LMI
803 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
804 key" (bug#4257).
805
0cf34688
LMI
806 * window.c (Fset_window_start): Doc fix (bug#4199).
807 (Fset_window_hscroll): Ditto.
808
270768cd
PE
8092011-07-12 Paul Eggert <eggert@cs.ucla.edu>
810
077e3dda 811 Fix minor new problems caught by GCC 4.6.1.
270768cd 812 * term.c (init_tty): Remove unused local.
490011a6 813 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 814 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 815 not used otherwise.
270768cd 816
b1f58454
CY
8172011-07-12 Chong Yidong <cyd@stupidchicken.com>
818
819 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
820
22b9578d
LMI
8212011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
822
6e70ab07
LMI
823 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
824 are the mini-buffer and the echo area (bug#3320).
825
22b9578d
LMI
826 * term.c (init_tty): Remove support for supdup, c10 and perq
827 terminals, which are no longer supported (bug#1482).
828
8974cc9f
JB
8292011-07-10 Johan Bockgård <bojohan@gnu.org>
830
831 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
832
a560d974
JD
8332011-07-10 Jan Djärv <jan.h.d@swipnet.se>
834
835 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
836 for non-popups (Bug#3642).
837
1dae0f0a
AS
8382011-07-10 Andreas Schwab <schwab@linux-m68k.org>
839
268c2c36 840 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 841 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
842 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
843 * cm.c (losecursor): Likewise.
1dae0f0a
AS
844 * data.c (fmod): Likewise.
845 * dispnew.c (swap_glyphs_in_rows): Likewise.
846 * emacs.c (memory_warning_signal): Likewise.
847 * floatfns.c (float_error): Likewise.
848 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
849 (otf_open, font_otf_capability, generate_otf_features)
850 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
851 Likewise.
852 * image.c (pbm_read_file): Likewise.
853 * indent.c (string_display_width): Likewise.
854 * intervals.c (check_for_interval, search_for_interval)
855 (inc_interval_count, count_intervals, root_interval)
856 (adjust_intervals_for_insertion, make_new_interval): Likewise.
857 * lread.c (defalias): Likewise.
268c2c36 858 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
859 * regex.c (set_image_of_range_1, set_image_of_range)
860 (regex_grow_registers): Likewise.
861 * sysdep.c (strerror): Likewise.
862 * termcap.c (valid_filename_p, tprint, main): Likewise.
863 * tparam.c (main): Likewise.
864 * unexhp9k800.c (run_time_remap, save_data_space)
865 (update_file_ptrs, read_header, write_header, calculate_checksum)
866 (copy_file, copy_rest, display_header): Likewise.
867 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
868 Likewise.
869 * xdisp.c (check_it): Likewise.
870 * xfaces.c (register_color, unregister_color, unregister_colors):
871 Likewise.
872 * xfns.c (print_fontset_result): Likewise.
873 * xrdb.c (member, fatal, main): Likewise.
874
99033785
PE
8752011-07-10 Paul Eggert <eggert@cs.ucla.edu>
876
877 Fix minor problems found by static checking (Bug#9031).
878 * chartab.c (char_table_set_range, map_sub_char_table):
879 Remove unused locals.
880 (uniprop_table): Now static.
881 * composite.c (_work_char): Remove unused static var.
882
9cb2ac56
JB
8832011-07-09 Juanma Barranquero <lekktu@gmail.com>
884
885 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
886
f25661f0
JD
8872011-07-09 Jan Djärv <jan.h.d@swipnet.se>
888
889 * gtkutil.c (qttip_cb): Remove code without function.
890
8278c4fe
EZ
8912011-07-09 Eli Zaretskii <eliz@gnu.org>
892
893 * w32.c (pthread_sigmask): New stub.
894
1692ae2d 8952011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 896
8a6ebd58 897 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
898 sigprocmask is portable only for single-threaded applications, and
899 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
900 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
901 (LIBES): Use it.
902 * callproc.c (Fcall_process):
903 * process.c (create_process):
904 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
905 Use pthread_sigmask, not sigprocmask.
123403e4 906
1b854618
JD
9072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
908
909 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
910 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
911 wrong (Bug#8591).
912
3fe4b549
JD
9132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
914
0ce7e563
JD
915 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
916 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
917 (xg_hide_tooltip): Fix comment.
918
3fe4b549
JD
919 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
920 in registerServicesMenuSendTypes.
921 (validRequestorForSendType): Don't check ns_return_types.
922
923 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
924 ns_return_type.
925
5df75e47
JR
9262011-07-08 Jason Rumney <jasonr@gnu.org>
927
928 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
929 frame struct members of non-existent frames (Bug#6284).
930
699c10bd
JD
9312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
932
4393663b
JD
933 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
934 variable firstTime not needed on OSX >= 10.6.
935 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
936 >= 10.5. Use setKnobProportion, setDoubleValue.
937
938 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
939 (MAC_OS_X_VERSION_10_5): Define if not defined.
940 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
941 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
942 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
943
944 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
945 cString and lossyCString on OSX >= 10.4
946
947 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
948 sizeToFit on OSX >= 10.2.
949
950 * nsimage.m (allocInitFromFile): Don't use deprecated method
951 bestRepresentationForDevice on OSX >= 10.6.
952
953 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
954 to avoid warning.
955
956 * emacs.c: Declare unexec_init_emacs_zone.
957
a63e0781
JD
958 * nsgui.h: Fix compiler warning about gnulib redefining verify.
959
699c10bd
JD
960 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
961
962 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
963 on svcsMenu (Bug#8842).
964
965 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
966 ns_return_types.
967 (Fns_list_services): Just return Qnil on 10.6, code not working there.
968
969 * nsterm.m (QUTF8_STRING): Declare.
970 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
971 (validRequestorForSendType): Return type is (id).
972 Change indexOfObjectIdenticalTo to indexOfObject.
973 Check if we have local selection before returning self (Bug#8842).
974 (writeSelectionToPasteboard): Put local selection into paste board
975 if we have a local selection (Bug#8842).
976 (syms_of_nsterm): DEFSYM QUTF8_STRING.
977
978 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
979 (ns_get_local_selection): Declare.
980
54e10184
LMI
9812011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
982
9888ff71
LMI
983 * keymap.c (describe_map_tree): Don't insert a double newline at
984 the end of the buffer (bug#1169) and return whether we inserted
985 something.
986
54e10184
LMI
987 * callint.c (Fcall_interactively): Change "reading args" to
988 "providing args" to try to clarify what it does (bug#1010).
989
15fa4783
KH
9902011-07-07 Kenichi Handa <handa@m17n.org>
991
992 * composite.c (composition_compute_stop_pos): Ignore a static
993 composition starting before CHARPOS (Bug#8915).
994
995 * xdisp.c (handle_composition_prop): Likewise.
996
a8815b00
EZ
9972011-07-07 Eli Zaretskii <eliz@gnu.org>
998
999 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1000 (Bug#9015)
1001
ef7b981d 10022011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1003
1004 * character.h (unicode_category_t): New enum type.
1005
1006 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1007 (Qchar_code_property_table): New variable.
1008 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1009 (UNIPROP_COMPRESSED_FORM_P): New macros.
1010 (char_table_ascii): Uncompress the compressed values.
1011 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1012 Uncompress the compressed values.
ac389d0c 1013 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1014 (char_table_ref_and_range): Uncompress the compressed values.
1015 (sub_char_table_set): New arg is_uniprop. Callers changed.
1016 Uncompress the compressed values.
1017 (sub_char_table_set_range): Args changed. Callers changed.
1018 (char_table_set_range): Adjuted for the above change.
1019 (map_sub_char_table): Delete args default_val and parent. Add arg
1020 top. Give decoded values to a Lisp function.
1021 (map_char_table): Adjusted for the above change. Give decoded
1022 values to a Lisp function. Gcpro more variables.
1023 (uniprop_table_uncompress)
1024 (uniprop_decode_value_run_length): New functions.
1025 (uniprop_decoder, uniprop_decoder_count): New variables.
1026 (uniprop_get_decoder, uniprop_encode_value_character)
1027 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1028 New functions.
1029 (uniprop_encoder, uniprop_encoder_count): New variables.
1030 (uniprop_get_encoder, uniprop_table)
1031 (Funicode_property_table_internal, Fget_unicode_property_internal)
1032 (Fput_unicode_property_internal): New functions.
1033 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1034 Sunicode_property_table_internal, Sget_unicode_property_internal,
1035 and Sput_unicode_property_internal. Defvar_lisp
1036 char-code-property-alist.
1037
1038 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1039 Vunicode_category_table.
1040
1041 * font.c (font_range): Adjusted for the change of
1042 Vunicode_category_table.
1043
76b397fb
DN
10442011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1045
1046 * m/iris4d.h: Remove file, move contents ...
1047 * s/irix6-5.h: ... here.
1048
22b4128e
PE
10492011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1050
1051 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1052 * alloc.c (mark_buffer):
1053 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1054 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1055 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1056 This isn't true in general, and it's particularly not true
1057 if Emacs is configured with --with-wide-int.
1058 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1059 New macros, used in the buffer.c change.
1060
869795d6
JD
10612011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1062
1063 * xsettings.c: Use both GConf and GSettings if both are available.
1064 (store_config_changed_event): Add comment.
1065 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1066 (store_tool_bar_style_changed): New functions.
1067 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1068 (struct xsettings): Move font inside HAVE_XFT.
1069 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1070 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1071 Move inside HAVE_XFT.
1072 (something_changed_gsettingsCB): Renamed from something_changedCB.
1073 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1074 also.
1075 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1076 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1077 (something_changed_gconfCB): Renamed from something_changedCB.
1078 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1079 (parse_settings): Move check for font inside HAVE_XFT.
1080 (read_settings, apply_xft_settings): Add comment.
1081 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1082 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1083 call store_font_name_changed.
1084 (xft_settings_event): Add comment.
1085 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1086 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1087 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1088 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1089 (xsettings_initialize): Call init_gsettings last.
1090 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1091 comment.
1092
d8ed26bd
PE
10932011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 Random fixes. E.g., (random) never returned negative values.
1096 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1097 subseconds part to the entropy, as that's a bit more random.
1098 Prefer signed to unsigned, since the signedness doesn't matter and
1099 in general we prefer signed. When given a limit, use a
1100 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1101 latter isn't right if USE_2_TAGS_FOR_INTS.
1102 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1103 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1104
cabf1cac
SM
11052011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1106
1107 * textprop.c (text_property_stickiness):
1108 Obey Vtext_property_default_nonsticky.
1109 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1110 * w32fns.c (syms_of_w32fns):
1111 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1112
6e9b2be9
PE
11132011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1116 This is more efficient than Ffile_directory_p and avoids a minor race.
1117
90186c68
LMI
11182011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1119
7c301272
LMI
1120 * buffer.c (Foverlay_put): Say what the return value is
1121 (bug#7835).
1122
c4f2d8d4
LMI
1123 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1124 is a directory before asking whether to use the file name
1125 (bug#7564).
ad637907
LMI
1126 (barf_or_query_if_file_exists): Make the "File is a directory"
1127 error be more correct.
c4f2d8d4 1128
90186c68
LMI
1129 * fns.c (Frequire): Remove the mention of the .gz files, since
1130 that's installation-specific, but keep the mention of
1131 `get-load-suffixes'.
1132
da64016e
PE
11332011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1134
1135 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1136 Report string overflow if the output is too long.
1137
7d47b580
JB
11382011-07-04 Juanma Barranquero <lekktu@gmail.com>
1139
a555cb87
JB
1140 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1141 (syms_of_gnutls): Remove duplicate DEFSYM for
1142 Qgnutls_bootprop_verify_hostname_error, an error for
1143 Qgnutls_bootprop_verify_error (which is no longer used).
1144
7d47b580
JB
1145 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1146 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1147 Also (re)move comments that are misplaced or no longer relevant.
1148
1e49bfab
LMI
11492011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1150
1151 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1152
1485f4c0
CY
11532011-07-03 Chong Yidong <cyd@stupidchicken.com>
1154
1155 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1156 and background color parameters if they have been changed.
1157
a9ab721e
LMI
11582011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1159
1160 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1161
cf7cff57
PE
11622011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1163
2e13213d
PE
1164 * xsettings.c (SYSTEM_FONT): Define only when used.
1165 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1166
cf7cff57
PE
1167 * keymap.c (access_keymap_1): Now static.
1168
7a8e04f7
CY
11692011-07-02 Chong Yidong <cyd@stupidchicken.com>
1170
1171 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1172 leave any prefix arg for the up event (Bug#1586).
1173
61352f62
LMI
11742011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1175
69bb1ef7
LMI
1176 * lread.c (syms_of_lread): Mention single symbols defined by
1177 `defvar' or `defconst' (bug#7154).
1178
61352f62 1179 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1180 (Frequire): Mention get-load-suffixes.
61352f62 1181
28545e04
MR
11822011-07-02 Martin Rudalics <rudalics@gmx.at>
1183
1184 * window.h (window): Remove clone_number slot.
1185 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1186 Remove.
1187 (make_parent_window, make_window, saved_window)
1188 (Fset_window_configuration, save_window_save): Don't deal with
1189 clone numbers.
1190 * buffer.c (Qclone_number): Remove declaration.
1191 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1192
3349e122
SM
11932011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1194
1195 Add multiple inheritance to keymaps.
1196 * keymap.c (Fmake_composed_keymap): New function.
1197 (Fset_keymap_parent): Simplify.
1198 (fix_submap_inheritance): Remove.
1199 (access_keymap_1): New function extracted from access_keymap to handle
1200 embedded parents and handle lists of maps.
1201 (access_keymap): Use it.
1202 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1203 (Fcopy_keymap): Handle embedded parents.
1204 (Fcommand_remapping, define_as_prefix): Simplify.
1205 (Fkey_binding): Simplify.
1206 (syms_of_keymap): Move minibuffer-local-completion-map,
1207 minibuffer-local-filename-completion-map,
1208 minibuffer-local-must-match-map, and
1209 minibuffer-local-filename-must-match-map to Elisp.
1210 (syms_of_keymap): Defsubr make-composed-keymap.
1211 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1212 (parse_menu_item): Trivial simplification.
1213
3279eb87
GM
12142011-07-01 Glenn Morris <rgm@gnu.org>
1215
1216 * Makefile.in (SETTINGS_LIBS): Fix typo.
1217
4550efdf
KI
12182011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1219
1220 * coding.c (Fencode_coding_string): Record the last coding system
1221 used, as the function doc string says (bug#8738).
1222
0949d2b6
JD
12232011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1224
1225 * xsettings.c (store_monospaced_changed): Take new font as arg and
1226 check for change against current_mono_font.
1227 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1228 (emacs_settings_constructor, emacs_settings_get_property)
1229 (emacs_settings_set_property, emacs_settings_class_init)
1230 (emacs_settings_init, gsettings_obj): Remove.
1231 (something_changedCB): New function for HAVE_GSETTINGS.
1232 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1233 with value as argument.
1234 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1235 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1236 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1237 "changed".
1238
1239 * xgselect.c: Add defined (HAVE_GSETTINGS).
1240 (xgselect_initialize): Ditto.
1241
1242 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1243 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1244 xg_select.
1245
bbc6b304
PE
12462011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1247
1248 * eval.c (struct backtrace): Simplify and port the data structure.
1249 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1250 signed bit field, as this assumption is not portable and it makes
1251 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1252 "char debug_on_exit : 1" as this is not portable either; instead,
1253 use the portable "unsigned int debug_on_exit : 1". Remove unused
1254 member evalargs. Remove obsolete comments about cc bombing out.
1255
9851bfc5
JD
12562011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1257
51bb811f 1258 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1259 Let HAVE_GSETTINGS override HAVE_GCONF.
1260 (store_monospaced_changed): New function.
1261 (EMACS_SETTINGS): A new type derived from GObject to handle
1262 GSettings notifications.
1263 (emacs_settings_constructor, emacs_settings_get_property)
1264 (emacs_settings_set_property, emacs_settings_class_init):
1265 New functions.
1266 (gsettings_client, gsettings_obj): New variables.
1267 (GSETTINGS_SCHEMA): New define.
1268 (something_changedCB): Call store_monospaced_changed.
1269 (init_gsettings): New function.
1270 (xsettings_initialize): Call init_gsettings.
1271 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1272 to NULL.
1273
1274 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1275 GCONF_CFLAGS/LIBS.
1276
5386012d
MR
12772011-06-29 Martin Rudalics <rudalics@gmx.at>
1278
1279 * window.c (resize_root_window, grow_mini_window)
1280 (shrink_mini_window): Rename Qresize_root_window to
1281 Qwindow_resize_root_window and Qresize_root_window_vertically to
1282 Qwindow_resize_root_window_vertically.
1283
f13e0b08
PE
12842011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1287
94515237
JB
12882011-06-27 Juanma Barranquero <lekktu@gmail.com>
1289
1290 * makefile.w32-in: Redesign dependencies so they reflect more
1291 clearly which files are directly included by each source file,
1292 and not through other includes.
1293
e43b6e43
MR
12942011-06-27 Martin Rudalics <rudalics@gmx.at>
1295
1296 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1297 (sort_overlays, overlay_strings): When an overlay's clone number
1298 matches the window's clone number process the overlay even if
1299 the overlay's window property doesn't match the current window.
1300
d68443dc
MR
1301 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1302 (Fwindow_hchild): Rename to Fwindow_left_child.
1303 (Fwindow_next): Rename to Fwindow_next_sibling.
1304 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1305 (resize_window_check): Rename to window_resize_check.
1306 (resize_window_apply): Rename to window_resize_apply.
1307 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1308 (Fdelete_other_windows_internal, resize_frame_windows)
1309 (Fsplit_window_internal, Fdelete_window_internal)
1310 (grow_mini_window, shrink_mini_window)
1311 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1312
c7e73be5
JD
13132011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1314
1315 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1316 (emacs_fixed_set_min_size): Remove.
1317 (emacs_fixed_new): Take frame as argument.
1318
1319 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1320 (_EmacsFixedPrivate): Remove minwidth/height.
1321 Add struct frame *f.
1322 (emacs_fixed_init): Initialize priv->f.
1323 (get_parent_class, emacs_fixed_set_min_size): Remove.
1324 (emacs_fixed_new): Set priv->f to argument.
1325 (emacs_fixed_get_preferred_width)
1326 (emacs_fixed_get_preferred_height): Use min_width/height from
1327 frames size_hint to set minimum and natural (Bug#8919).
1328 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1329 and use min_width/height from frames size_hint to set
1330 min_width/height (Bug#8919).
1331
1332 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1333 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1334 Fix indentation.
c7e73be5 1335
cf99dcf8
EZ
13362011-06-26 Eli Zaretskii <eliz@gnu.org>
1337
1338 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1339 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1340 called at ZV.
1341
029529ac
CY
13422011-06-26 Chong Yidong <cyd@stupidchicken.com>
1343
1344 * process.c (wait_reading_process_output): Bypass select if
1345 waiting for a cell while ignoring keyboard input, and input is
1346 pending. Suggested by Jan Djärv (Bug#8869).
1347
7a7ef429
PE
13482011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 Use gnulib's dup2 module instead of rolling our own.
1351 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1352
11fdef7d 13532011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1354
1355 * dispnew.c (scrolling_window): Before scrolling, turn off a
1356 mouse-highlight in the window being scrolled.
1357
cd3520a4
JB
13582011-06-24 Juanma Barranquero <lekktu@gmail.com>
1359
1360 Move DEFSYM to lisp.h and use everywhere.
1361
1362 * character.h (DEFSYM): Move declaration...
1363 * lisp.h (DEFSYM): ...here.
1364
1365 * gnutls.c:
1366 * minibuf.c:
1367 * w32menu.c:
1368 * w32proc.c:
1369 * w32select.c: Don't include character.h.
1370
1371 * alloc.c (syms_of_alloc):
1372 * buffer.c (syms_of_buffer):
1373 * bytecode.c (syms_of_bytecode):
1374 * callint.c (syms_of_callint):
1375 * casefiddle.c (syms_of_casefiddle):
1376 * casetab.c (init_casetab_once):
1377 * category.c (init_category_once, syms_of_category):
1378 * ccl.c (syms_of_ccl):
1379 * cmds.c (syms_of_cmds):
1380 * composite.c (syms_of_composite):
1381 * dbusbind.c (syms_of_dbusbind):
1382 * dired.c (syms_of_dired):
1383 * dispnew.c (syms_of_display):
1384 * doc.c (syms_of_doc):
1385 * editfns.c (syms_of_editfns):
1386 * emacs.c (syms_of_emacs):
1387 * eval.c (syms_of_eval):
1388 * fileio.c (syms_of_fileio):
1389 * fns.c (syms_of_fns):
1390 * frame.c (syms_of_frame):
1391 * fringe.c (syms_of_fringe):
1392 * insdel.c (syms_of_insdel):
1393 * keymap.c (syms_of_keymap):
1394 * lread.c (init_obarray, syms_of_lread):
1395 * macros.c (syms_of_macros):
1396 * msdos.c (syms_of_msdos):
1397 * print.c (syms_of_print):
1398 * process.c (syms_of_process):
1399 * search.c (syms_of_search):
1400 * sound.c (syms_of_sound):
1401 * syntax.c (init_syntax_once, syms_of_syntax):
1402 * terminal.c (syms_of_terminal):
1403 * textprop.c (syms_of_textprop):
1404 * undo.c (syms_of_undo):
1405 * w32.c (globals_of_w32):
1406 * window.c (syms_of_window):
1407 * xdisp.c (syms_of_xdisp):
1408 * xfaces.c (syms_of_xfaces):
1409 * xfns.c (syms_of_xfns):
1410 * xmenu.c (syms_of_xmenu):
1411 * xsettings.c (syms_of_xsettings):
1412 * xterm.c (syms_of_xterm): Use DEFSYM.
1413
4228cf16
TZ
14142011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1415
cd3520a4 1416 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1417
7fcccf1e
PE
14182011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1419
7efb4e0e
PE
1420 Integer and buffer overflow fixes (Bug#8873).
1421
ff5844ad
PE
1422 * print.c (printchar, strout): Check for string overflow.
1423 (PRINTPREPARE, printchar, strout):
1424 Don't set size unless allocation succeeds.
1425
90532f02
PE
1426 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1427 for sizes. Check for string overflow more accurately.
1428 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1429
6d84508d
PE
1430 * macros.c: Integer and buffer overflow fixes.
1431 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1432 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1433 Use ptrdiff_t, not int, for sizes.
1434 Don't increment bufsize until after realloc succeeds.
1435 Check for size-calculation overflow.
1436 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1437
437b2cb4
PE
1438 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1439
8b9ac8b4
PE
1440 * lread.c: Integer overflow fixes.
1441 (read_integer): Radix is now EMACS_INT, not int,
1442 to improve quality of diagnostics for out-of-range radices.
1443 Calculate buffer size correctly for out-of-range radices.
1444 (read1): Check for integer overflow in radices, and in
1445 read-circle numbers.
82cb60d3
PE
1446 (read_escape): Avoid int overflow.
1447 (Fload, openp, read_buffer_size, read1)
1448 (substitute_object_recurse, read_vector, read_list, map_obarray):
1449 Use ptrdiff_t, not int, for sizes.
1450 (read1): Use EMACS_INT, not int, for sizes.
20270765 1451 Check for size overflow.
8b9ac8b4 1452
7fcccf1e
PE
1453 * image.c (cache_image): Check for size arithmetic overflow.
1454
bfbbd7e7
PE
1455 * lread.c: Integer overflow issues.
1456 (saved_doc_string_size, saved_doc_string_length)
1457 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1458 Now ptrdiff_t, not int.
1459 (read1): Don't assume doc string length fits in int. Check for
1460 out-of-range doc string lengths.
1461 (read_list): Don't assume file position fits in int.
39019e54 1462 (read_escape): Check for hex character overflow.
bfbbd7e7 1463
4e323265
LL
14642011-06-22 Leo Liu <sdl.web@gmail.com>
1465
1466 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1467 Move to minibuffer.el.
1468
85fece3e
PE
14692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1470
20b84ce9 1471 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1472 The following patches are for when GLYPH_DEBUG && !XASSERT.
1473 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1474 * dispnew.c (flush_stdout):
1475 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1476 Mark as externally visible.
1477 * dispnew.c (check_window_matrix_pointers): Now static.
1478 * dispnew.c (window_to_frame_vpos):
1479 * xfns.c (unwind_create_frame):
1480 * xterm.c (x_check_font): Remove unused local.
1481 * scroll.c (CHECK_BOUNDS):
1482 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1483 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1484 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1485 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1486 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1487 Now static.
1488 (debug_method_add): Use va_list and vsprintf rather than relying
1489 on undefined behavior with wrong number of arguments.
1490 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1491 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1492 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1493 since we're not interested in debugging glyphs with old libraries.
1494 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1495 GCC 4.6.0's static checking.
1496
0766b489
PE
14972011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1498
31fd4b32
PE
1499 Integer overflow and signedness fixes (Bug#8873).
1500 A few related buffer overrun fixes, too.
1501
b79e8648
PE
1502 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1503
0766b489
PE
1504 * dispextern.h (struct face.stipple):
1505 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1506 (x_bitmap_mask, x_allocate_bitmap_record)
1507 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1508 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1509 (x_create_bitmap_from_xpm_data):
1510 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1511 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1512 (.bitmaps_last):
1513 * xfaces.c (load_pixmap):
1514 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1515 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1516 (.bitmaps_last, struct x_output.icon_bitmap):
1517 Use ptrdiff_t, not int, for bitmap indexes.
1518 (x_allocate_bitmap_record): Check for size overflow.
1519 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1520
b081724f
PE
1521 Use ptrdiff_t, not int, for overlay counts.
1522 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1523 * editfns.c (overlays_around, get_pos_property):
1524 * textprop.c (get_char_property_and_overlay):
1525 * xdisp.c (next_overlay_change, note_mouse_highlight):
1526 * xfaces.c (face_at_buffer_position):
21514da7
PE
1527 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1528 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1529 (Fnext_overlay_change, Fprevious_overlay_change)
1530 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1531 Use ptrdiff_t, not int, for sizes.
21514da7 1532 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1533
3de73e5e
PE
1534 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1535
2606c57b
PE
1536 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1537 (x_session_initialize): Do not assume string length fits in int.
1538
aaafe47a
PE
1539 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1540 This is unlikely, but can occur if DPI is outlandish.
1541
2674ddc8 1542 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1543 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1544
28154962
PE
1545 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1546 * xrdb.c (magic_file_p, search_magic_path):
1547 Omit last arg SUFFIX; it was always 0. All callers changed.
1548 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1549
7de51af5
PE
1550 * xfont.c (xfont_match): Avoid need for strlen.
1551
25ed6cc3
PE
1552 * xfns.c: Don't assume strlen fits in int.
1553 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1554
4eab31dd
PE
1555 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1556 not unsigned long, as we prefer signed integers. All callers changed.
1557 Detect integer overflow in repeat count.
1558 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1559 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1560
171e2a58
PE
1561 * termcap.c: Don't assume sizes fit in int and never overflow.
1562 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1563 (gobble_line): Check for size-calculation overflow.
1564
ad39faca 1565 * minibuf.c (Fread_buffer):
6e5bb2dc 1566 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1567 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1568 Don't assume string length fits in int.
1569
52c61c22 1570 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1571 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1572
b5b8c9e5
PE
1573 * font.c: Don't assume string length fits in int.
1574 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1575 Use ptrdiff_t, not int.
ccd6111c
PE
1576 (font_intern_prop): Don't assume string length fits in int.
1577 Don't assume integer property fits in fixnum.
1578 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1579
882f0d81 1580 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1581 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1582 Reformulate so as not to need the command string.
1583 Invoke gzip -cd rather than gunzip, as it's more portable.
1584 (lock_info_type, lock_file_1, lock_file):
1585 Don't assume pid_t and time_t fit in unsigned long.
1586 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1587 (current_lock_owner): Prefer signed type for sizes.
1588 Use memcpy, not strncpy, where memcpy is what is really wanted.
1589 Don't assume (via atoi) that time_t and pid_t fit in int.
1590 Check for time_t and/or pid_t out of range, e.g., via a network share.
1591 Don't alloca where an auto var works fine.
1592
93f4cf88
PE
1593 * fileio.c: Fix some integer overflow issues.
1594 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1595 Don't assume string length fits in int.
1596 (directory_file_name): Don't assume string length fits in long.
1597 (make_temp_name): Don't assume pid fits in int, or that its print
1598 length is less than 20.
1599
f3e92b69
PE
1600 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1601
1bfdaf10
PE
1602 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1603
35016e9a
PE
1604 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1605
3d1e65a1
PE
1606 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1607 We prefer signed integers, even for size calculations.
1608
0b963a93
PE
1609 * emacs.c: Don't assume string length fits in 'int'.
1610 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1611 (main): Don't invoke strlen when not needed.
1612
573f4b54
PE
1613 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1614 (XD_DEBUG_MESSAGE): Don't waste a byte.
1615
989f33ba
PE
1616 * callproc.c (getenv_internal_1, getenv_internal)
1617 (Fgetenv_internal):
965d34eb
PE
1618 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1619
e4d29b33
PE
1620 * lread.c (invalid_syntax): Omit length argument.
1621 All uses changed. This doesn't fix a bug, but it simplifies the
1622 code away from its former Hollerith-constant appearance, and it's
1623 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1624 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1625
eb49b136
PE
1626 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1627 This didn't break anything, but it didn't help either.
1628 It's confusing to put a bogus integer in a place where the actual
1629 value does not matter.
9f62aeb1 1630 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1631 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1632
15375a22
PE
1633 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1634 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1635 implementation.
b61cc01c
PE
1636 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1637 We prefer signed types, and the value cannot exceed the EMACS_INT
1638 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1639 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1640 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1641 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1642
53b2623d
PE
1643 * indent.c (sane_tab_width): New function.
1644 (current_column, scan_for_column, Findent_to, position_indentation)
1645 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1646 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1647
51cab52b 1648 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1649
f2ed8a70
PE
1650 * lisp.h (lint_assume): New macro.
1651 * composite.c (composition_gstring_put_cache):
1652 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1653
abe80cc6
PE
1654 * editfns.c, insdel.c:
1655 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1656
b02c740e
PE
1657 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1658
ebc96716
PE
1659 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1660
b4e50fa0 1661 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1662 Use much-faster test for byte-length change.
311d5d7c 1663 Don't assume string byte-length fits in 'int'.
a4cf38e4 1664 Check that character arg fits in 'int'.
85461888 1665 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1666
c0c1ee9f
PE
1667 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1668
a498d7f4
PE
1669 * fns.c (concat): Catch string overflow earlier.
1670 Do not rely on integer wraparound.
1671
51cab52b
PE
1672 * dispextern.h (struct it.overlay_strings_charpos)
1673 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1674 * xdisp.c (forward_to_next_line_start)
1675 (back_to_previous_visible_line_start)
1676 (reseat_at_next_visible_line_start, next_element_from_buffer):
1677 Don't arbitrarily truncate the value of 'selective' to int.
1678
76031fad
PE
1679 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1680
5eb55db9
PE
1681 * composite.c: Don't truncate sizes to 'int'.
1682 (composition_gstring_p, composition_reseat_it)
1683 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1684 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1685 not EMACS_UINT, for indexes.
5eb55db9 1686
0703a717
PE
1687 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1688
d6202519
PE
1689 * buffer.c: Include <verify.h>.
1690 (struct sortvec.priority, struct sortstr.priority):
8961a454 1691 Now EMACS_INT, not int.
c20998a7 1692 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1693 (struct sortstr.size, record_overlay_string)
1694 (struct sortstrlist.size, struct sortlist.used):
1695 Don't truncate size to int.
1696 (record_overlay_string): Check for size-calculation overflow.
d6202519 1697 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1698
d5a19415
JM
16992011-06-22 Jim Meyering <meyering@redhat.com>
1700
029529ac 1701 Don't leak an XBM-image-sized buffer
d5a19415
JM
1702 * image.c (xbm_load): Free the image buffer after using it.
1703
a9041e6c
PE
17042011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1705
1706 Port to Sun C.
1707 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1708 that Sun C diagnosed.
1709 * fns.c (secure_hash): Fix pointer signedness issue.
1710 * intervals.c (static_offset_intervals): New function.
1711 (offset_intervals): Use it.
1712
7f3f739f
LL
17132011-06-21 Leo Liu <sdl.web@gmail.com>
1714
1715 * deps.mk (fns.o):
1716 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1717 sha512.h.
1718
1719 * fns.c (secure_hash): Rename from crypto_hash_function and change
1720 the first arg to accept symbols.
5b66d427 1721 (Fsecure_hash): New primitive.
7f3f739f
LL
1722 (syms_of_fns): New symbols.
1723
76147d94
DD
17242011-06-20 Deniz Dogan <deniz@dogan.se>
1725
1726 * process.c (Fset_process_buffer): Clarify return value in
1727 docstring.
1728
7d7d0045
CY
17292011-06-18 Chong Yidong <cyd@stupidchicken.com>
1730
1731 * dispnew.c (add_window_display_history): Use BVAR.
1732
1733 * xdisp.c (debug_method_add): Use BVAR.
1734 (check_window_end, dump_glyph_matrix, dump_glyph)
1735 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1736
1737 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1738 Likewise.
1739
1740 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1741 check till after the cache is created in init_frame_faces.
1742
ff2bc410
SM
17432011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1744
1745 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1746
28177add
PE
17472011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1748
dd3482fe
PE
1749 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1750 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1751 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1752
393d71f3 1753 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1754 * fileio.c (Finsert_file_contents):
1755 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1756 Remove the old (too-loose) buffer overflow checks.
1757 They weren't needed, since make_gap checks for buffer overflow.
1758 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1759 The old code merely checked for Emacs fixnum overflow, and relied
1760 on undefined (wraparound) behavior. The new code avoids undefined
1761 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1762
2e6813b0 1763 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1764 Tune. Don't use wider integers than needed. Don't use alloca.
1765 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1766
599a9e4f
PE
1767 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1768
99561444
PE
1769 * insdel.c, lisp.h (buffer_overflow): New function.
1770 (insert_from_buffer_1, replace_range, replace_range_2):
1771 * insdel.c (make_gap_larger):
1772 * editfns.c (Finsert_char):
1773 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1774
28177add
PE
1775 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1776
e69dafad
PE
17772011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1778
a7af7fde 1779 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1780
b1c46f02
PE
1781 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1782 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1783
e69dafad
PE
1784 * fileio.c: Don't assume EMACS_INT fits in off_t.
1785 (emacs_lseek): New static function.
1786 (Finsert_file_contents, Fwrite_region): Use it.
1787 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1788
566684ea
PE
1789 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1790
e6966cd6
PE
1791 * fns.c: Don't overflow int when computing a list length.
1792 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1793 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1794 truncation on 64-bit hosts. Check for QUIT every
1795 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1796 faster and is responsive enough.
1797 (Flength): Report an error instead of overflowing an integer.
1798 (Fsafe_length): Return a float if the value is not representable
1799 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1800 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1801 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1802
dd0b0efb
PE
1803 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1804 (header_size, word_size): New constants.
1805 (allocate_vectorlike): Don't check size overflow here.
1806 (allocate_vector): Check it here instead, since this is the only
1807 caller of allocate_vectorlike that could cause overflow.
1808 Check that the new vector's length is representable as a fixnum.
1809
86fe5cfe
PE
1810 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1811 The previous code was bogus. For example, next_almost_prime (32)
1812 returned 39, which is undesirable as it is a multiple of 3; and
1813 next_almost_prime (24) returned 25, which is a multiple of 5 so
1814 why was the code bothering to check for multiples of 7?
1815
80e88859
PE
1816 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1817
4a2f0ad6
PE
1818 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1819
f66c7cf8
PE
1820 Variadic C functions now count arguments with ptrdiff_t.
1821 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1822 Back then I didn't know that the Emacs coding style prefers signed int.
1823 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1824 were being counted with int, which may truncate counts on 64-bit
1825 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1826 * lisp.h (struct Lisp_Subr.function.aMANY)
1827 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1828 Arg counts are now ptrdiff_t, not size_t.
1829 All variadic functions and their callers changed accordingly.
1830 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1831 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1832 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1833 * callint.c (Fcall_interactively): Check arg count for overflow,
1834 to avoid potential buffer overrun. Use signed char, not 'int',
1835 for 'varies' array, so that we needn't bother to check its size
1836 calculation for overflow.
1837 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1838 * eval.c (apply_lambda):
1839 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1840 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1841 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1842
a1759b76
PE
1843 * callint.c (Fcall_interactively): Don't use index var as event count.
1844
d96be9fc
PE
1845 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1846 * mem-limits.h (SIZE): Remove; no longer used.
1847
a690a978 1848 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1849
578c21e6
PE
1850 Remove unnecessary casts.
1851 * xterm.c (x_term_init):
1852 * xfns.c (x_set_border_pixel):
1853 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1854 These aren't needed now that we assume ANSI C.
1855
96f53c6c
PE
1856 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1857 It's more likely to cause problems (due to unsigned overflow)
1858 than to cure them.
1859
83c77d31
PE
1860 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1861
ee2079f1
PE
1862 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1863
6da65536
PE
1864 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1865
7147c4a4
PE
1866 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1867
193e32d9
PE
1868 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1869
e5533da6
PE
1870 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1871
9910e595
PE
1872 GLYPH_CODE_FACE returns EMACS_INT, not int.
1873 * dispextern.h (merge_faces):
1874 * xfaces.c (merge_faces):
01103c44
PE
1875 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1876 Don't assume EMACS_INT fits in int.
9910e595 1877
2638320e
PE
1878 * character.h (CHAR_VALID_P): Remove unused parameter.
1879 * fontset.c, lisp.h, xdisp.c: All uses changed.
1880
045eb8d9
PE
1881 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1882
c1f134b5
PE
1883 * fns.c (concat): Minor tuning based on overflow analysis.
1884 This doesn't fix any bugs. Use int to hold character, instead
1885 of constantly refetching from Emacs object. Use XFASTINT, not
1886 XINT, for value known to be a character. Don't bother comparing
1887 a single byte to 0400, as it's always less.
1888
395fcb93 1889 * floatfns.c (Fexpt):
327eeec8
PE
1890 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1891
abbd3d23
PE
1892 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1893 for characters.
1894
684a03ef
PE
1895 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1896
0fed43f3
PE
1897 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1898 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1899 incorrectly succeed when S was a string, because 4294967386 was
1900 truncated before it was used.
1901
8fd02eb7
PE
1902 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1903 Otherwise, an out-of-range integer could cause undefined behavior
1904 on a 64-bit host.
1905
f8c86b69
PE
1906 * composite.c: Use int, not EMACS_INT, for characters.
1907 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1908 EMACS_INT, for values that are known to be in character range.
1909 This doesn't fix any bugs but is the usual style inside Emacs and
1910 may generate better code on 32-bit machines.
1911
34206dd2
PE
1912 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1913 This is for reasons similar to the recent CHAR_STRING fix.
1914 * charset.c (Fencode_char): Check that character arg is actually
1915 a character. Pass an int to ENCODE_CHAR.
1916 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1917 wider than 'int', as a compile-time check to prevent future regressions
1918 in this area.
1919
c5958d4c 1920 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1921
1922 Make sure a 64-bit char is never passed to CHAR_STRING.
1923 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1924 by silently ignoring the top 32 bits, allowing some values
1925 that were far too large to be valid characters.
1926 * character.h: Include <verify.h>.
1927 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1928 arguments are no wider than unsigned, as a compile-time check
1929 to prevent future regressions in this area.
1930 * data.c (Faset):
01103c44 1931 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1932 (Fsubst_char_in_region):
1933 * fns.c (concat):
1934 * xdisp.c (decode_mode_spec_coding):
1935 Adjust to CHAR_STRING's new requirement.
1936 * editfns.c (Finsert_char, Fsubst_char_in_region):
1937 * fns.c (concat): Check that character args are actually
1938 characters. Without this test, these functions did the wrong
1939 thing with wildly out-of-range values on 64-bit hosts.
1940
d37ca623
PE
1941 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1942 These casts should not be needed on 32-bit hosts, either.
1943 * keyboard.c (read_char):
1944 * lread.c (Fload): Remove casts to unsigned.
1945
ea204efb
PE
1946 * lisp.h (UNSIGNED_CMP): New macro.
1947 This fixes comparison bugs on 64-bit hosts.
1948 (ASCII_CHAR_P): Use it.
1949 * casefiddle.c (casify_object):
01103c44 1950 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1951 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1952 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1953 * dispextern.h (FACE_FROM_ID):
1954 * keyboard.c (read_char): Use UNSIGNED_CMP.
1955
41cb286c
PE
1956 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1957 not to EMACS_INT, to avoid GCC warning.
1958
4a1b9832
PE
1959 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1960
55daad71
PE
1961 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1962 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1963 isn't needed on 32-bit machines.
8f95c75c 1964
01103c44
PE
1965 * buffer.c (Fgenerate_new_buffer_name):
1966 Use EMACS_INT for count, not int.
0ceccced 1967 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1968
1969 * data.c (Qcompiled_function): Now static.
1970
c6f072e7
PE
1971 * window.c (window_body_lines): Now static.
1972
20ce5912
PE
1973 * image.c (gif_load): Rename local to avoid shadowing.
1974
9c4c5f81
PE
1975 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1976 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1977 * alloc.c (make_save_value): Integer argument is now of type
1978 ptrdiff_t, not int.
1979 (mark_object): Use ptrdiff_t, not int.
1980 * lisp.h (pD): New macro.
1981 * print.c (print_object): Use it.
1982
c0c5c8ae
PE
1983 * alloc.c: Use EMACS_INT, not int, to count objects.
1984 (total_conses, total_markers, total_symbols, total_vector_size)
1985 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1986 (total_free_floats, total_floats, total_free_intervals)
1987 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1988 Now EMACS_INT, not int. All uses changed.
1989 (Fgarbage_collect): Compute overall total using a double, so that
1990 integer overflow is less likely to be a problem. Check for overflow
1991 when converting back to an integer.
5a25e253
PE
1992 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1993 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1994 These were 'int' variables that could overflow on 64-bit hosts;
1995 they were never used, so remove them instead of repairing them.
211a0b2a 1996 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1997 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1998 Previously, this ceilinged at INT_MAX, but that doesn't work on
1999 64-bit machines.
e46bb31a 2000 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2001
c78baabf 2002 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2003 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2004 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2005 when a (possibly-narrower) signed value would do just as well.
2006 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2007
c9d624c6
PE
2008 * alloc.c: Catch some string size overflows that we were missing.
2009 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2010 for convenience in STRING_BYTES_MAX.
2011 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2012 The definition here is exact; the one in lisp.h was approximate.
2013 (allocate_string_data): Check for string overflow. This catches
2014 some instances we weren't catching before. Also, it catches
2015 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2016 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2017 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2018
c9d624c6
PE
2019 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2020 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2021 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2022
353032ce
PE
2023 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2024
2bccce07
PE
2025 * alloc.c (Fmake_string): Check for out-of-range init.
2026
0ac30604
SM
20272011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2028
2029 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2030
c195f2de
JD
20312011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2032
2033 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2034 xg_get_default_scrollbar_width.
2035
2036 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2037 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2038 (style_changed_cb): Call update_theme_scrollbar_width and call
2039 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2040 all frames (Bug#8505).
2041 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2042 Call gtk_window_set_resizable if HAVE_GTK3.
2043 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2044 and height if HAVE_GTK3 (Bug#8505).
2045 (scroll_bar_width_for_theme): New variable.
2046 (update_theme_scrollbar_width): New function.
2047 (xg_get_default_scrollbar_width): Move code to
2048 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2049 (xg_initialize): Call update_theme_scrollbar_width.
2050
2051 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2052
2053 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2054
e10ac9f1
MR
20552011-06-12 Martin Rudalics <rudalics@gmx.at>
2056
2057 * frame.c (make_frame): Call other_buffer_safely instead of
2058 other_buffer.
2059
2060 * window.c (temp_output_buffer_show): Call display_buffer with
2061 second argument Vtemp_buffer_show_specifiers and reset latter
2062 immediately after the call.
2063 (Vtemp_buffer_show_specifiers): New variable.
2064 (auto_window_vscroll_p, next_screen_context_lines)
2065 (Vscroll_preserve_screen_position): Remove leading asterisks from
2066 doc-strings.
2067
2d3c217e 20682011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2069
7b7f97e8 2070 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2071 * buffer.c (Qclone_number): Remove for now, as it's unused.
2072 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2073 (record_buffer): Remove unused local.
2074 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2075 (set_frame_buffer_list): Remove; unused.
2076 * frame.h (other_visible_frames): Remove decl.
2077 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2078 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2079 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2080 if HAVE_GPM.
2081 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2082 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2083 Define only if HAVE_GPM.
2084 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2085 (update_hints_inhibit): Remove; never set. All uses removed.
2086 * widgetprv.h (emacsFrameClassRec): Remove decl.
2087 * window.c (delete_deletable_window): Now returns void, since it
2088 wasn't returning anything.
2089 (compare_window_configurations): Remove unused locals.
2090 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2091 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2092 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2093 the same widths as pointers. This follows up on the 2011-05-06 patch.
2094 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2095 * xterm.h: Likewise.
2096 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2097
1384b89e
JB
20982011-06-12 Juanma Barranquero <lekktu@gmail.com>
2099
2100 * makefile.w32-in: Update dependencies.
2101 (LISP_H): Add lib/intprops.h.
2102
1100a63c
CY
21032011-06-11 Chong Yidong <cyd@stupidchicken.com>
2104
2105 * image.c (gif_load): Add animation frame delay to the metadata.
2106 (syms_of_image): Use DEFSYM. New symbol `delay'.
2107
6198ccd0
MR
21082011-06-11 Martin Rudalics <rudalics@gmx.at>
2109
2110 * window.c (delete_deletable_window): Re-add.
2111 (Fset_window_configuration): Rewrite to handle dead buffers and
2112 consequently deletable windows.
2113 (window_tree, Fwindow_tree): Remove. Supply functionality in
2114 window.el.
2115 (compare_window_configurations): Simplify code.
2116
b6e3633c
AS
21172011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2118
1ab0dee5
AS
2119 * image.c (imagemagick_load_image): Fix type mismatch.
2120 (Fimagemagick_types): Likewise.
2121
b6e3633c
AS
2122 * window.h (replace_buffer_in_windows): Declare.
2123
9397e56f
MR
21242011-06-11 Martin Rudalics <rudalics@gmx.at>
2125
2126 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2127 Qclone_number. Remove external declaration of Qdelete_window.
2128 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2129 code.
2130 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2131 Qbuffer_list_update_hook if allowed.
2132 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2133 buffer list implementation.
2134 (other_buffer_safely): New function.
2135 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2136 calls to replace_buffer_in_windows and
2137 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2138 if allowed.
2139 (record_buffer): Inhibit quitting and rewrite using quittable
2140 functions. Run Qbuffer_list_update_hook if allowed.
2141 (Frecord_buffer, Funrecord_buffer): New functions.
2142 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2143 switch-to-buffer to window.el.
2144 (bury-buffer): Move to window.el.
2145 (Vbuffer_list_update_hook): New variable.
2146
2147 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2148 section.
2149
2150 * window.h (resize_frame_windows): Move up in code.
2151 (Fwindow_frame): Remove EXFUN.
2152 (replace_buffer_in_all_windows): Remove prototype.
2153 (replace_buffer_in_windows_safely): Add prototype.
2154
2155 * window.c: Declare Qdelete_window static again. Move down
2156 declaration of select_count.
2157 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2158 (Fother_window): Move to window.el.
2159 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2160 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2161 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2162 window.el.
2163 (replace_buffer_in_windows): Implement by calling
2164 Qreplace_buffer_in_windows.
2165 (replace_buffer_in_all_windows): Remove with some functionality
2166 moved into replace_buffer_in_windows_safely.
2167 (replace_buffer_in_windows_safely): New function.
2168 (select_window_norecord, select_frame_norecord): Move in front
2169 of run_window_configuration_change_hook. Remove now obsolete
2170 declarations.
2171 (Fset_window_buffer): Rewrite doc-string. Call
2172 Qrecord_window_buffer.
2173 (keys_of_window): Move binding for other-window to window.el.
2174
b50691aa
CY
21752011-06-11 Chong Yidong <cyd@stupidchicken.com>
2176
2177 * dispextern.h (struct image): Replace data member, whose int_val
2178 and ptr_val fields were not used by anything, with a single
2179 lisp_val object.
2180
2181 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2182 (gif_clear_image, gif_load, imagemagick_load_image)
2183 (gs_clear_image, gs_load): Callers changed.
2184
3f754b86
PE
21852011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2186
cca69397
PE
2187 * buffer.h: Include <time.h>, for time_t.
2188 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2189
109e28d0
PE
2190 Fix minor problems found by static checking.
2191
60737f02
PE
2192 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2193
4b66faf3
PE
2194 Make identifiers static if they are not used in other modules.
2195 * data.c (Qcompiled_function, Qframe, Qvector):
2196 * image.c (QimageMagick, Qsvg):
2197 * minibuf.c (Qmetadata):
2198 * window.c (resize_window_check, resize_root_window): Now static.
2199 * window.h (resize_window_check, resize_root_window): Remove decls.
2200
109e28d0
PE
2201 * window.c (window_deletion_count, delete_deletable_window):
2202 Remove; unused.
46a4ce9e
PE
2203 (window_body_lines): Now static.
2204 (Fdelete_other_windows_internal): Mark vars as initialized.
2205 Make sure 'resize_failed' is initialized.
2206 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2207 (resize_window_apply): Remove unused local.
2208 * window.h (delete_deletable_window): Remove decl.
2209
109e28d0 2210 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2211 (imagemagick_load_image): Fix pointer signedness problem by changing
2212 last arg from unsigned char * to char *. All uses changed.
2213 Also, fix a local for similar reasons.
2214 Remove unused locals. Remove locals to avoid shadowing.
2215 (fn_rsvg_handle_free): Remove; unused.
2216 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2217 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2218
3f754b86
PE
2219 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2220
2547adb1
CY
22212011-06-10 Chong Yidong <cyd@stupidchicken.com>
2222
2223 * image.c (gif_load): Fix omitted cast error introduced by
2224 2011-06-06 change.
2225
2c8e37d4
MR
22262011-06-10 Martin Rudalics <rudalics@gmx.at>
2227
2228 * window.h (resize_proportionally, orig_total_lines)
2229 (orig_top_line): Remove from window structure.
2230 (set_window_height, set_window_width, change_window_heights)
2231 (Fdelete_window): Remove prototypes.
2232 (resize_frame_windows): Remove duplicate declaration.
2233
440a42e3
EZ
22342011-06-10 Eli Zaretskii <eliz@gnu.org>
2235
2236 * window.h (resize_frame_windows, resize_window_check)
2237 (delete_deletable_window, resize_root_window)
2238 (resize_frame_windows): Declare prototypes.
2239
2240 * window.c (resize_window_apply): Make definition be "static" to
2241 match the prototype.
2242
562dd5e9
MR
22432011-06-10 Martin Rudalics <rudalics@gmx.at>
2244
2245 * window.c: Remove declarations of Qwindow_size_fixed,
2246 window_min_size_1, window_min_size_2, window_min_size,
2247 size_window, window_fixed_size_p, enlarge_window, delete_window.
2248 Remove static from declaration of Qdelete_window, it's
2249 temporarily needed by Fbury_buffer.
2250 (replace_window): Don't assign orig_top_line and
2251 orig_total_lines.
2252 (Fdelete_window, delete_window): Remove. Window deletion is
2253 handled by window.el.
2254 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2255 Fdelete_window calls with calls to Qdelete_window.
2256 (Fdelete_other_windows): Remove. Deleting other windows is
2257 handled by window.el.
2258 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2259 handled in window.el.
2260 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2261 Window minimum sizes are handled in window.el.
2262 (shrink_windows, size_window, set_window_height)
2263 (set_window_width, change_window_heights, window_height)
2264 (window_width, CURBEG, CURSIZE, enlarge_window)
2265 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2266 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2267 handled in window.el.
2268 (make_dummy_parent): Rename to make_parent_window and give it a
2269 second argument horflag.
2270 (make_window): Don't set resize_proportionally any more.
2271 (Fsplit_window): Remove. Windows are split in window.el.
2272 (save_restore_action, save_restore_orig_size)
2273 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2274 Resize mini windows in window.el.
2275 (grow_mini_window, shrink_mini_window): Implement by calling
2276 Qresize_root_window_vertically, resize_window_check and
2277 resize_window_apply.
2278 (saved_window, Fset_window_configuration, save_window_save): Do
2279 not handle orig_top_line, orig_total_lines, and
2280 resize_proportionally.
2281 (window_min_height, window_min_width): Move to window.el.
2282 (keys_of_window): Move bindings for delete-other-windows,
2283 split-window, delete-window and enlarge-window to window.el.
2284
2285 * buffer.c: Temporarily extern Qdelete_window.
2286 (Fbury_buffer): Temporarily call Qdelete_window instead of
2287 Fdelete_window (Fbury_buffer will move to window.el soon).
2288
2289 * frame.c (set_menu_bar_lines_1): Remove code handling
2290 orig_top_line and orig_total_lines.
2291
2292 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2293 set_window_height but set heights directly.
2294 (change_frame_size_1): Use resize_frame_windows.
2295
2296 * xdisp.c (init_xdisp): Don't use set_window_height but set
2297 heights directly.
2298
2299 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2300 resize_frame_windows instead of change_window_heights and run
2301 run_window_configuration_change_hook.
2302
2303 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2304 instead of change_window_heights and run
2305 run_window_configuration_change_hook.
2306
1a13852e
MR
23072011-06-09 Martin Rudalics <rudalics@gmx.at>
2308
2309 * window.c (replace_window): Rename second argument REPLACEMENT to
2310 NEW. New third argument SETFLAG. Rewrite.
2311 (delete_window, make_dummy_parent): Call replace_window with
2312 third argument 1.
2313 (window_list_1): Move down in code.
2314 (run_window_configuration_change_hook): Move set_buffer part
2315 before select_frame_norecord part in order to unwind correctly.
2316 Rename count1 to count.
2317 (recombine_windows, delete_deletable_window, resize_root_window)
2318 (Fdelete_other_windows_internal)
2319 (Frun_window_configuration_change_hook, make_parent_window)
2320 (resize_window_check, resize_window_apply, Fresize_window_apply)
2321 (resize_frame_windows, Fsplit_window_internal)
2322 (Fdelete_window_internal, Fresize_mini_window_internal): New
2323 functions.
2324 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2325
f3d1777e
MR
23262011-06-08 Martin Rudalics <rudalics@gmx.at>
2327
496e208e
MR
2328 * window.h (window): Add some new members to window structure -
2329 normal_lines, normal_cols, new_total, new_normal, clone_number,
2330 splits, nest, prev_buffers, next_buffers.
2331 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2332 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2333
f3d1777e
MR
2334 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2335 Remove.
496e208e
MR
2336 (make_dummy_parent): Set new members of windows structure.
2337 (make_window): Move down in code. Handle new members of window
2338 structure.
2339 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2340 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2341 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2342 (Fset_window_prev_buffers, Fwindow_next_buffers)
2343 (Fset_window_next_buffers, Fset_window_clone_number): New
2344 functions.
2345 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2346 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2347 Doc-string fixes.
2348 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2349 Argument WINDOW can be now internal window too.
2350 (Fwindow_use_time): Move up in code.
2351 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2352 Rewrite doc-string.
2353 (Fset_window_configuration, saved_window)
2354 (Fcurrent_window_configuration, save_window_save): Handle new
2355 members of window structure.
b9e809c2
MR
2356 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2357 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2358 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2359 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2360 Qget_mru_window, Qresize_root_window,
2361 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2362 Qauto_buffer_name; staticpro them.
f3d1777e 2363
abde8f8c
MR
23642011-06-07 Martin Rudalics <rudalics@gmx.at>
2365
2366 * window.c (Fwindow_total_size, Fwindow_left_column)
2367 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2368 (Fwindow_list_1): New functions.
2369 (window_box_text_cols): Replace with window_body_cols.
2370 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2371 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2372 (delete_window, Fset_window_configuration): Call
2373 delete_all_subwindows with window as argument.
2374 (delete_all_subwindows): Take a window as argument and not a
2375 structure. Rewrite.
190b47e6
MR
2376 (window_loop): Remove handling of GET_LRU_WINDOW and
2377 GET_LARGEST_WINDOW.
2378 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2379
2380 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2381 window_box_text_cols. delete_all_subwindows now takes a
2382 Lisp_Object as argument.
abde8f8c
MR
2383
2384 * indent.c (compute_motion, Fcompute_motion): Use
2385 window_body_cols instead of window_box_text_cols.
2386
fa8a67e6
MR
2387 * frame.c (delete_frame): Call delete_all_subwindows with root
2388 window as argument.
2389
a54e3482
DC
23902011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2391
2392 * fns.c (Fputhash): Document return value.
2393
60002bf5
CY
23942011-06-06 Chong Yidong <cyd@stupidchicken.com>
2395
2396 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2397
0c671da6 23982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2399
b862a52a 2400 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2401
be44ca6c
PE
2402 Check for overflow when converting integer to cons and back.
2403 * charset.c (Fdefine_charset_internal, Fdecode_char):
2404 Use cons_to_unsigned to catch overflow.
2405 (Fencode_char): Use INTEGER_TO_CONS.
2406 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2407 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2408 * data.c (long_to_cons, cons_to_long): Remove.
2409 (cons_to_unsigned, cons_to_signed): New functions.
2410 These signal an error for invalid or out-of-range values.
2411 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2412 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2413 * font.c (Ffont_variation_glyphs):
2414 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2415 * lisp.h: Include <intprops.h>.
2416 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2417 (cons_to_signed, cons_to_unsigned): New decls.
2418 (long_to_cons, cons_to_long): Remove decls.
2419 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2420 (Fprimitive_undo): Use CONS_TO_INTEGER.
2421 * xfns.c (Fx_window_property): Likewise.
2422 * xselect.c: Include <limits.h>.
2423 (x_own_selection, selection_data_to_lisp_data):
2424 Use INTEGER_TO_CONS.
2425 (x_handle_selection_request, x_handle_selection_clear)
2426 (x_get_foreign_selection, Fx_disown_selection_internal)
2427 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2428 (lisp_data_to_selection_data): Use cons_to_unsigned.
2429 (x_fill_property_data): Use cons_to_signed.
2430 Report values out of range.
2431
d1f3d2af
PE
2432 Check for buffer and string overflow more precisely.
2433 * buffer.h (BUF_BYTES_MAX): New macro.
2434 * lisp.h (STRING_BYTES_MAX): New macro.
2435 * alloc.c (Fmake_string):
2436 * character.c (string_escape_byte8):
2437 * coding.c (coding_alloc_by_realloc):
2438 * doprnt.c (doprnt):
2439 * editfns.c (Fformat):
2440 * eval.c (verror):
2441 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2442 since they may not be the same number.
2443 * editfns.c (Finsert_char):
2444 * fileio.c (Finsert_file_contents):
2445 Likewise for BUF_BYTES_MAX.
2446
dd52fcea
PE
2447 * image.c: Use ptrdiff_t, not int, for sizes.
2448 (slurp_file): Switch from int to ptrdiff_t.
2449 All uses changed.
2450 (slurp_file): Check that file size fits in both size_t (for
2451 malloc) and ptrdiff_t (for sanity and safety).
2452
7f9bbdbb
PE
2453 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2454 if b->modtime has its maximal value.
2455
dfe18f82
PE
2456 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2457
84acfcf0
PE
2458 Don't assume time_t can fit into int.
2459 * buffer.h (struct buffer.modtime): Now time_t, not int.
2460 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2461 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2462
ccd9a01a
PE
2463 Minor fixes for signed vs unsigned integers.
2464 * character.h (MAYBE_UNIFY_CHAR):
2465 * charset.c (maybe_unify_char):
2466 * keyboard.c (read_char, reorder_modifiers):
2467 XINT -> XFASTINT, since the integer must be nonnegative.
2468 * ftfont.c (ftfont_spec_pattern):
2469 * keymap.c (access_keymap, silly_event_symbol_error):
2470 XUINT -> XFASTINT, since the integer must be nonnegative.
2471 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2472 since it makes no difference and we prefer signed.
2473 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2474 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2475 nonnegative.
2476
d6d100dd
SM
24772011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2478
2479 * window.h (Fwindow_frame): Declare.
2480
2b6148e4
PE
24812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2482
2483 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2484 (SPARE_MEMORY): Always define.
2485 (LARGE_REQUEST): Remove.
2486 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2487
f230ecc9
MR
24882011-06-06 Martin Rudalics <rudalics@gmx.at>
2489
727e958e
MR
2490 * lisp.h: Move EXFUNS for Fframe_root_window,
2491 Fframe_first_window and Fset_frame_selected_window to window.h.
2492
2493 * window.h: Move EXFUNS for Fframe_root_window,
2494 Fframe_first_window and Fset_frame_selected_window here from
2495 lisp.h.
2496
2497 * frame.c (Fwindow_frame, Fframe_first_window)
2498 (Fframe_root_window, Fframe_selected_window)
2499 (Fset_frame_selected_window): Move to window.c.
2500 (Factive_minibuffer_window): Move to minibuf.c.
2501 (Fother_visible_frames_p): New function.
2502
2503 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2504
f230ecc9
MR
2505 * window.c (decode_window, decode_any_window): Move up in code.
2506 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2507 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2508 (Fwindow_buffer): Move up and rewrite doc-string.
2509 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2510 (Fwindow_prev): New functions.
727e958e
MR
2511 (Fwindow_frame): Move here from frame.c. Accept any window as
2512 argument.
2513 (Fframe_root_window, Fframe_first_window)
2514 (Fframe_selected_window): Move here from frame.c. Accept frame
2515 or arbitrary window as argument. Update doc-strings.
2516 (Fminibuffer_window): Move up in code.
2517 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2518 (Fset_frame_selected_window): Move here from frame.c.
2519 Marginal rewrite.
727e958e
MR
2520 (Fselected_window, select_window, Fselect_window): Move up in
2521 code. Minor doc-string fixes.
f230ecc9 2522
4d09bcf6
PE
25232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2524
2525 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2526 Do not assume that spare memory exists; that assumption is valid
2527 only if SYSTEM_MALLOC.
2528 (LARGE_REQUEST): New macro, so that the issue of large requests
2529 is separated from the issue of spare memory.
2530
810928a2
AS
25312011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2532
172418ad
AS
2533 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2534 format. (Bug#8806)
2535
43f862f7
AS
2536 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2537
810928a2
AS
2538 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2539 before statements.
2540
a059fe24
JD
25412011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2542
2543 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2544
2545 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2546
2547 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2548 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2549
989bf368
JB
25502011-06-05 Juanma Barranquero <lekktu@gmail.com>
2551
2552 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2553
4b80f674
CY
25542011-06-04 Chong Yidong <cyd@stupidchicken.com>
2555
2556 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2557 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2558 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2559 New error handlers.
4b80f674
CY
2560 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2561 Obey Vx_select_enable_clipboard_manager. Catch errors in
2562 x_clipboard_manager_save (Bug#8779).
2563 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2564 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2565
99a33b77 25662011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2567
2568 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2569
99a33b77 25702011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2571
2572 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2573 in the current matrix if keep_current_p is non-zero.
2574
8264569d
EZ
25752011-06-04 Eli Zaretskii <eliz@gnu.org>
2576
2577 * bidi.c (bidi_level_of_next_char): Fix last change.
2578
57f97249
EZ
25792011-06-03 Eli Zaretskii <eliz@gnu.org>
2580
fec2107c 2581 Support bidi reordering of text covered by display properties.
57f97249 2582
fec2107c
EZ
2583 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2584 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2585 (bidi_cache_search, bidi_cache_iterator_state)
2586 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2587 (bidi_level_of_next_char, bidi_move_to_visually_next):
2588 Support character positions inside a run of characters covered by a
fec2107c
EZ
2589 display string.
2590 (bidi_paragraph_init, bidi_resolve_explicit_1)
2591 (bidi_level_of_next_char): Call bidi_fetch_char and
2592 bidi_fetch_char_advance instead of FETCH_CHAR and
2593 FETCH_CHAR_ADVANCE.
2594 (bidi_init_it): Initialize new members.
2595 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2596 definitions.
2597 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2598 instead of using explicit *_CHAR codes.
d6d100dd
SM
2599 (bidi_resolve_explicit, bidi_resolve_weak):
2600 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2601 bidirectional text is supported only in multibyte buffers.
2602 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2603 it to initialize the frame_window_p member of struct bidi_it.
2604 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2605 (bidi_resolve_explicit, bidi_resolve_weak)
2606 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2607 bidi_it->nchars is non-positive.
2608 (bidi_level_of_next_char): Don't try to lookup the cache for the
2609 next/previous character if nothing is cached there yet, or if we
2610 were just reseat()'ed to a new position.
c40e2fb2 2611
0e14fe90
EZ
2612 * xdisp.c (set_cursor_from_row): Set start and stop points
2613 according to the row's direction when priming the loop that looks
2614 for the glyph on which to display cursor.
2615 (single_display_spec_intangible_p): Function deleted.
2616 (display_prop_intangible_p): Reimplement to call
2617 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2618 Accept 3 additional arguments needed by handle_display_spec.
2619 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2620 values: lists, `(when COND...)' forms, etc.
2621 (single_display_spec_string_p): Support property values that are
2622 lists with the argument STRING its top-level element.
2623 (display_prop_string_p): Fix the condition for processing a
2624 property that is a list to be consistent with handle_display_spec.
fec2107c 2625 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2626 last portion of handle_display_prop.
2627 (compute_display_string_pos): Accept additional argument
2628 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2629 value of a `display' property is a "replacing spec".
2630 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2631 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2632 the display property, but just return a value indicating whether
2633 the display property will replace the characters it covers.
2634 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2635 frame_window_p members of struct bidi_it.
d6d100dd
SM
2636 (compute_display_string_pos, compute_display_string_end):
2637 New functions.
fec2107c
EZ
2638 (push_it): Accept second argument POSITION, where pop_it should
2639 jump to continue iteration.
2640 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2641
fec2107c
EZ
2642 * keyboard.c (adjust_point_for_property): Adjust the call to
2643 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2644
2645 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2646 (bidi_init_it): Update prototypes.
2647 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2648 (compute_display_string_pos, compute_display_string_end):
2649 Declare prototypes.
fec2107c
EZ
2650 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2651 EMACS_INT.
fc6f18ce 2652
40087514 26532011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2654
57f53182
PE
2655 Malloc failure behavior now depends on size of allocation.
2656 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2657 * lisp.h: Change signatures accordingly.
2658 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2659 All callers changed. (Bug#8762)
2660
2661 * gnutls.c: Use Emacs's memory allocators.
2662 Without this change, the gnutls library would invoke malloc etc.
2663 directly, which causes problems on non-SYNC_INPUT hosts, and which
2664 runs afoul of improving memory_full behavior. (Bug#8761)
2665 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2666 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2667 xfree instead of the default malloc, realloc, free.
2668 (Fgnutls_boot): No need to check for memory allocation failure,
2669 since xmalloc does that for us.
2670
ac32cd99 2671 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2672 * category.c (hash_get_category_set):
2673 * ccl.c (ccl_driver):
2674 * charset.c (Fdefine_charset_internal):
2675 * charset.h (struct charset.hash_index):
2676 * composite.c (get_composition_id, gstring_lookup_cache)
2677 (composition_gstring_put_cache):
2678 * composite.h (struct composition.hash_index):
2679 * dispextern.h (struct image.hash):
2680 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2681 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2682 (hashfn_equal, hashfn_user_defined, make_hash_table)
2683 (maybe_resize_hash_table, hash_lookup, hash_put)
2684 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2685 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2686 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2687 * image.c (make_image, search_image_cache, lookup_image)
2688 (xpm_put_color_table_h):
2689 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2690 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2691 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2692 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2693 * alloc.c (allocate_vectorlike):
2694 Check for overflow in vector size calculations.
2695 * ccl.c (ccl_driver):
2696 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2697 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2698 need to be updated by these changes.
40087514
PE
2699 * fns.c (make_hash_table, maybe_resize_hash_table):
2700 Check for integer overflow with large hash tables.
0de4bb68
PE
2701 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2702 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2703 (SXHASH_REDUCE): New macro.
2704 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2705 Use it instead of discarding useful hash info with large hash values.
2706 (sxhash_float): New function.
2707 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2708 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2709 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2710 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2711 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2712 Adjust signatures to match updated version of code.
2713 (consing_since_gc): Now EMACS_INT, since a single hash table can
2714 use more than INT_MAX bytes.
2715
698d32e2
DN
27162011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2717
2718 Make it possible to build with GCC-4.6+ -O2 -flto.
2719
2720 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2721
fd6fa53f
SM
27222011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2723
2724 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2725 Call minibuffer-inactive-mode.
2726
864db017
JB
27272011-05-31 Juanma Barranquero <lekktu@gmail.com>
2728
2729 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2730 Update dependencies.
2731
2ad0baf4
DN
27322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2733
2734 * data.c (init_data): Remove code for UTS, this system is not
2735 supported anymore.
2736
4fcc2638
DN
27372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2738
2739 Don't force ./temacs to start in terminal mode.
2740
2741 * frame.c (make_initial_frame): Initialize faces in all cases, not
2742 only when CANNOT_DUMP is defined.
2743 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2744
c56e0fd5
DN
27452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2746
2747 * dispnew.c (add_window_display_history): Use const for the string
2748 pointer. Remove declaration, not needed.
2749
333d54da 27502011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2751
55d4c1b2 2752 Use 'inline', not 'INLINE'.
333d54da 2753 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2754 * alloc.c, fontset.c (INLINE): Remove.
2755 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2756 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2757 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2758 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2759 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2760
738db178
DN
27612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2762
2763 Make it possible to run ./temacs.
2764
2765 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2766 syms_of_callproc does the same thing. Remove test for
2767 "initialized", do it in the caller.
2768 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2769
620c53a6
SM
27702011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2771
2772 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2773 (read_minibuf): Use get_minibuffer.
2774 (syms_of_minibuf): Use DEFSYM.
2775 (Qmetadata): New var.
2776 * data.c (Qbuffer): Don't make it static.
2777 (syms_of_data): Use DEFSYM.
2778
e003a292
PE
27792011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2780
2781 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2782 (CCL_CODE_MIN): New macro.
2783
ed008a6d
PE
27842011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2785
3687c2ef
PE
2786 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2787
ed008a6d
PE
2788 * eval.c (Qdebug): Now static.
2789 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2790 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2791 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2792
d66c4c7c
CY
27932011-05-29 Chong Yidong <cyd@stupidchicken.com>
2794
2795 * image.c: Various fixes to ImageMagick code comments.
2796 (Fimagemagick_types): Doc fix.
2797
5fbc2025
PE
27982011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2799
0196f88a
PE
2800 Minor fixes prompted by GCC 4.6.0 warnings.
2801
2802 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2803
5fbc2025
PE
2804 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2805 (x_clipboard_manager_save_all): Move extern decl to ...
2806 * xterm.h: ... here, so that it can be checked for consistency.
2807
1dd3c2d9
CY
28082011-05-29 Chong Yidong <cyd@stupidchicken.com>
2809
2810 * xselect.c (x_clipboard_manager_save_frame)
2811 (x_clipboard_manager_save_all): New functions.
2812 (Fx_clipboard_manager_save): Lisp function deleted.
2813
2814 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2815 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2816
2817 * xterm.h: Update prototype.
2818
5ba6571d
WX
28192011-05-28 William Xu <william.xwl@gmail.com>
2820
2821 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2822 exiting (Bug#8239).
2823
3eaff834
JM
28242011-05-28 Jim Meyering <meyering@redhat.com>
2825
e1900994 2826 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2827 * fns.c (to_uchar): Define.
2828 (crypto_hash_function): Use it to convert some newly-signed
2829 variables to unsigned, to avoid sign-extension bugs. For example,
2830 without this change, (md5 "truc") would evaluate to
2831 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2832 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2833 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2834
0f6990a7
PE
28352011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 Integer overflow fixes.
c8a9ca5a 2838
08686060
PE
2839 * dbusbind.c: Serial number integer overflow fixes.
2840 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2841 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2842 to hold a serial number that is too large for a fixnum.
2843 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2844 Check for serial numbers out of range. Decode any serial number
59568bf0 2845 that was so large that it became a float. (Bug#8722)
08686060 2846
2d1fc3c7
PE
2847 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2848 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2849 Use XFASTINT rather than XUINT when numbers are nonnegative.
2850 (xd_append_arg, Fdbus_method_return_internal):
2851 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2852 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2853 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2854 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2855 (Bug#8722)
2d1fc3c7 2856
c8a9ca5a
PE
2857 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2858
519e1d69
PE
2859 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2860
30569699
PE
2861 ccl: add integer overflow checks
2862 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2863 (IN_INT_RANGE): New macros.
2864 (ccl_driver): Use them to check for integer overflow when
2865 decoding a CCL program. Many of the new checks are whether XINT (x)
2866 fits in int; it doesn't always, on 64-bit hosts. The new version
2867 doesn't catch all possible integer overflows, but it's an
847044ea 2868 improvement. (Bug#8719)
30569699 2869
c11285dc
PE
2870 * alloc.c (make_event_array): Use XINT, not XUINT.
2871 There's no need for unsigned here.
2872
fdccd48e
PE
2873 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2874 This follows up to the 2011-05-06 change that substituted uintptr_t
2875 for EMACS_INT. This case wasn't caught back then.
2876
37910ab2
PE
2877 Rework Fformat to avoid integer overflow issues.
2878 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2879 now (part of C89). Include <verify.h>.
2880 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2881 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2882 (Fformat): Avoid the prepass trying to compute sizes; it was only
2883 approximate and thus did not catch overflow reliably. Instead, walk
2884 through the format just once, formatting and computing sizes as we go,
2885 checking for integer overflow at every step, and allocating a larger
2886 buffer as needed. Keep track separately whether the format is
2887 multibyte. Keep only the most-recently calculated precision, rather
2888 than them all. Record whether each argument has been converted to
2889 string. Use EMACS_INT, not int, for byte and char and arg counts.
2890 Support field widths and precisions larger than INT_MAX. Avoid
2891 sprintf's undefined behavior with conversion specifications such as %#d
2892 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2893 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2894 formatting out-of-range floating point numbers with int
9173deec 2895 formats. (Bug#8668)
37910ab2 2896
2e6578fb
PE
2897 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2898
0ae6bdee
PE
2899 * data.c: Avoid integer truncation in expressions involving floats.
2900 * data.c: Include <intprops.h>.
2901 (arith_driver): When there's an integer overflow in an expression
2902 involving floating point, convert the integers to floating point
2903 so that the resulting value does not suffer from catastrophic
2904 integer truncation. For example, on a 64-bit host (* 4
2905 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2906 Do not rely on undefined behavior after integer overflow.
2907
de883a70
PE
2908 merge count_size_as_multibyte, parse_str_to_multibyte
2909 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2910 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2911 Check for integer overflow.
2912 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2913 since it's now a duplicate of the other. This is more of
2914 a character than a buffer op, so better that it's in character.c.
2915 * fns.c, print.c: Adjust to above changes.
2916
2ff916cb
PE
29172011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2918
2919 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2920
f1b54466
PE
29212011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2922
fb1ac845
PE
2923 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2924 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2925 (x_clipboard_manager_save): Now static.
2926 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2927
f1b54466
PE
2928 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2929 (crypto_hash_function): Now static.
2930 Fix pointer signedness problems. Avoid unnecessary initializations.
2931
a9f737ee
CY
29322011-05-27 Chong Yidong <cyd@stupidchicken.com>
2933
2934 * termhooks.h (Vselection_alist): Make it terminal-local.
2935
2936 * terminal.c (create_terminal): Initialize it.
2937
2938 * xselect.c: Support for clipboard managers.
2939 (Vselection_alist): Move to termhooks.h as terminal-local var.
2940 (LOCAL_SELECTION): New macro.
2941 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2942 (symbol_to_x_atom): Remove gratuitous arg.
2943 (x_handle_selection_request, lisp_data_to_selection_data)
2944 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2945 (x_own_selection, x_get_local_selection, x_convert_selection):
2946 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2947 (some_frame_on_display): Delete unused function.
2948 (Fx_own_selection_internal, Fx_get_selection_internal)
2949 (Fx_disown_selection_internal, Fx_selection_owner_p)
2950 (Fx_selection_exists_p): New optional frame arg.
2951 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2952 (x_handle_selection_clear): Don't treat other terminals with the
2953 same keyboard specially. Use the terminal-local Vselection_alist.
2954 (x_clear_frame_selections): Use Frun_hook_with_args.
2955
2956 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2957
2958 * xterm.h: Add support for those atoms.
2959
e067f0c1
CY
29602011-05-26 Chong Yidong <cyd@stupidchicken.com>
2961
2962 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2963 (converted_selections, conversion_fail_tag): New global variables.
2964 (x_selection_request_lisp_error): Free the above.
2965 (x_get_local_selection): Remove unnecessary code.
2966 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2967 of converted selections stored in converted_selections.
2968 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2969 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2970 (x_convert_selection): New function.
2971 (x_handle_selection_event): Simplify.
2972 (x_get_foreign_selection): Don't ignore incoming requests while
2973 waiting for an answer; this will fail when we implement
2974 SAVE_TARGETS, and seems unnecessary anyway.
2975 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2976 (Vx_sent_selection_functions): Doc fix.
2977
0f4aebc0
LL
29782011-05-26 Leo Liu <sdl.web@gmail.com>
2979
2980 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2981
e61124cd
YM
29822011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2983
2984 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2985
2986 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2987 for fringe update if it has periodic bitmap.
ac389d0c 2988 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2989 and fringe_bitmap_periodic_p.
2990
2991 * fringe.c (get_fringe_bitmap_data): New function.
2992 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2993 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2994 row. Mark glyph row for fringe update if periodicity changed.
2995
2996 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2997 for fringe update unless it has periodic bitmap.
2998
f16d9837
KH
29992011-05-25 Kenichi Handa <handa@m17n.org>
3000
3001 * xdisp.c (get_next_display_element): Set correct it->face_id for
3002 a static composition.
3003
e1b90ef6
LL
30042011-05-24 Leo Liu <sdl.web@gmail.com>
3005
3006 * deps.mk (fns.o):
3007 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3008
3009 * fns.c (crypto_hash_function, Fsha1): New function.
3010 (Fmd5): Use crypto_hash_function.
3011 (syms_of_fns): Add Ssha1.
3012
7400048f
PE
30132011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3014
3015 * gnutls.c: Remove unused macros.
3016 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3017 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3018 Remove macros that are defined and never used.
3019 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3020
abb71cf4
CY
30212011-05-22 Chong Yidong <cyd@stupidchicken.com>
3022
3023 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3024 (Fx_get_selection_internal): Minor cleanup.
3025 (Fx_own_selection_internal): Rename arguments for consistency with
3026 select.el.
3027
6307db39
PE
30282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3029
3030 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3031
f3d4e0a4
CY
30322011-05-22 Chong Yidong <cyd@stupidchicken.com>
3033
3034 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3035
4d8ade89
YM
30362011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3037
3038 * dispnew.c (scrolling_window): Don't exclude the case that the
3039 last enabled row in the desired matrix touches the bottom boundary.
3040
32078c8d
GM
30412011-05-21 Glenn Morris <rgm@gnu.org>
3042
3043 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3044 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3045 and add some more files.
32078c8d 3046
7285dc67
EZ
30472011-05-20 Eli Zaretskii <eliz@gnu.org>
3048
3049 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3050 report_file_error introduced by the change from 2011-05-07.
3051
89d1bd22
PE
30522011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 * systime.h (Time): Define only if emacs is defined.
3055 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3056 where the include path doesn't have X11/X.h by default. See
3057 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3058
e23640bb 30592011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3060
3061 * composite.c (find_automatic_composition): Fix previous change.
3062
b9704ad9
GM
30632011-05-20 Glenn Morris <rgm@gnu.org>
3064
3065 * lisp.mk: New file, split from Makefile.in.
3066 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3067 (shortlisp): Remove.
3068 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3069
4a720484
GM
30702011-05-19 Glenn Morris <rgm@gnu.org>
3071
3072 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3073 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3074 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3075 (lisp): Set the order to that of loadup.el.
3076 (shortlisp): Make it a copy of $lisp.
3077 (SOME_MACHINE_LISP): Remove.
3078 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3079 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3080
a28d4396
KH
30812011-05-18 Kenichi Handa <handa@m17n.org>
3082
3083 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3084 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3085 (find_automatic_composition): Mostly rewrite for efficiency.
3086
a2b1fa8e
JB
30872011-05-18 Juanma Barranquero <lekktu@gmail.com>
3088
3089 * makefile.w32-in: Update dependencies.
3090
8e1f5610
CS
30912011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3092
3093 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3094 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3095
7025ee00 30962011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3097
cdfa6eab
PE
3098 Fix some integer overflow issues, such as string length overflow.
3099
06d6db33
PE
3100 * insdel.c (count_size_as_multibyte): Check for string overflow.
3101
2b4560a8
PE
3102 * character.c (lisp_string_width): Check for string overflow.
3103 Use EMACS_INT, not int, for string indexes and lengths; in
3104 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3105 the resulting string length overflows an EMACS_INT; instead,
3106 report a string overflow if no precision given. When checking for
3107 precision exhaustion, use a check that cannot possibly have
3108 integer overflow. (Bug#8675)
3109 * character.h (lisp_string_width): Adjust to new signature.
3110
cb93f9be
PE
3111 * alloc.c (string_overflow): New function.
3112 (Fmake_string): Use it. This doesn't change behavior, but saves
3113 a few bytes and will simplify future changes.
3114 * character.c (string_escape_byte8): Likewise.
3115 * lisp.h (string_overflow): New decl.
3116
1a1f3366
PE
3117 Fixups, following up to the user-interface timestamp change.
3118 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3119 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3120 * msdos.c (mouse_get_pos): Likewise.
3121 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3122 * w32gui.h (Time): Define by including "systime.h" rather than by
3123 declaring it ourselves. (Bug#8664)
3124
d4e3e4d3
PE
3125 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3126 * image.c (clear_image_cache): Likewise.
3127
f6a24d19
PE
3128 * term.c (term_mouse_position): Don't assume time_t wraparound.
3129
08dc5ae6
PE
3130 Be more systematic about user-interface timestamps.
3131 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3132 and sometimes 'EMACS_UINT', to represent these timestamps.
3133 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3134 This makes the code easier to follow, and makes it easier to catch
3135 integer overflow bugs such as Bug#8664.
3136 * frame.c (Fmouse_position, Fmouse_pixel_position):
3137 Use Time, not unsigned long, for user-interface timestamps.
3138 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3139 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3140 * keyboard.h (last_event_timestamp): Likewise.
3141 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3142 * menu.h (xmenu_show): Likewise.
3143 * term.c (term_mouse_position): Likewise.
3144 * termhooks.h (struct input_event.timestamp): Likewise.
3145 (struct terminal.mouse_position_hook): Likewise.
3146 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3147 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3148 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3149 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3150 what it was before.
3151 * menu.h, termhooks.h: Include "systime.h", for Time.
3152
8e55734a
PE
3153 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3154 Don't assume that the difference between two unsigned long values
3155 can fit into an integer. At this point, we know button_down_time
3156 <= event->timestamp, so the difference must be nonnegative, so
3157 there's no need to cast the result if double-click-time is
3158 nonnegative, as it should be; check that it's nonnegative, just in
3159 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3160 apart (about 25 days). (Bug#8664)
8e55734a 3161
841f1b75 3162 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3163 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3164
3e26f69c
PE
3165 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3166 that always fit in int. Use a sentinel instead of a counter, to
3167 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3168 * frame.h (struct frame): Use int for menu_bar_items_used
3169 instead of EMACS_INT, since it always fits in int.
3e26f69c 3170
5cc152c0
PE
3171 * menu.c (grow_menu_items): Check for int overflow.
3172
d89eb65e
PE
3173 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3174
5235bd3e
PE
3175 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3176 Before, the code was not consistent. These values cannot exceed
3177 2**31 - 1 so there's no need to make them unsigned.
3178 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3179 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3180 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3181 as modifiers.
3182 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3183
bc827e23
PE
3184 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3185 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3186 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3187 presumably because the widths might not match.
3188
78eb494e
PE
3189 * window.c (size_window): Avoid needless test at loop start.
3190
04f2d78b
CB
31912011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3192
3193 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3194
d2fc7e3d 31952011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3196
3197 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3198
d2fc7e3d 31992011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3200
3201 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3202 `width' to `bar_area_x' and `bar_area_width', respectively.
3203 (x_scroll_run): Take account of fringe background extension.
3204
04f2d78b
CB
3205 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3206 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3207 `bar_area_width', respectively.
3208 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3209 background extension.
3210
79b70037
GM
32112011-05-10 Jim Meyering <meyering@redhat.com>
3212
3213 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3214
2f142cc5
JB
32152011-05-10 Juanma Barranquero <lekktu@gmail.com>
3216
3217 * image.c (Finit_image_library): Return t for built-in image types,
3218 like pbm and xbm. (Bug#8640)
3219
57679c86
AS
32202011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3221
3222 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3223
888c9e86
EZ
32242011-05-07 Eli Zaretskii <eliz@gnu.org>
3225
b0512a1d
EZ
3226 * w32console.c (Fset_screen_color): Doc fix.
3227 (Fget_screen_color): New function.
3228 (syms_of_ntterm): Defsubr it.
3229
7285dc67
EZ
3230 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3231 unlink the temporary file if Fcall_process didn't create it in the
3232 first place.
3233 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3234 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3235 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3236 cue to call_process_cleanup not to close that handle.
3237
4d3fcc8e
BK
32382011-05-07 Ben Key <bkey76@gmail.com>
3239
3240 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3241 one of two shell specific rules, either bootstrap-temacs-CMD or
3242 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3243 to the previous implementation of the bootstrap-temacs rule.
3244 The bootstrap-temacs-CMD rule is similar to the previous
3245 implementation of the bootstrap-temacs rule except that it
3246 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3247 variable.
3248
3249 These changes, along with some changes to nt/configure.bat,
3250 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3251 earlier fix to add support for --cflags and --ldflags options
3252 that include quotes so that it works whether make uses cmd or
3253 sh as the shell.
3254
b4289b64
MA
32552011-05-06 Michael Albinus <michael.albinus@gmx.de>
3256
3257 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3258 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3259 is a constant.
3260 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3261 a string. Handle both cases.
3262 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3263 (Fdbus_register_method): Use Qinvalid_function.
3264
af4c0e28
JB
32652011-05-06 Juanma Barranquero <lekktu@gmail.com>
3266
3267 * makefile.w32-in: Update dependencies.
3268 (LISP_H): Add inttypes.h and stdin.h.
3269 (PROCESS_H): Add unistd.h.
3270
c51453d9
EZ
32712011-05-06 Eli Zaretskii <eliz@gnu.org>
3272
3273 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3274 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3275
8ff0ac3c 32762011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3277
4c4b566b
PE
3278 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3279
aab2b9b5
PE
3280 * term.c (vfatal): Remove stray call to va_end.
3281 It's not needed and the C Standard doesn't allow it here anyway.
3282
c378da0b
PE
3283 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3284 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3285
288b08c7
PE
3286 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3287 bytes.
3288
e3601888
PE
3289 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3290
db6c0e74
PE
3291 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3292
dd5963ea
PE
3293 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3294
88c9450f
PE
3295 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3296
2f9442b8
PE
3297 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3298
c032b5f8
PE
3299 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3300 * charset.c (Fdefine_charset_internal): Don't initialize
3301 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3302 32-bit int (Bug#8600).
a108c10b
PE
3303
3304 * lread.c (read_integer): Be more consistent with string-to-number.
3305 Use string_to_number to do the actual conversion; this avoids
3306 rounding errors and fixes some other screwups. Without this fix,
3307 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3308 (digit_to_number): Move earlier, for benefit of read_integer.
3309 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3310 not a digit in any supported base. (Bug#8602)
a108c10b 3311
ad5f9eea
PE
3312 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3313
aec1708a
PE
3314 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3315 to match comment at start of function. This also removes a
3316 GCC warning about overflow in a 32+64-bit port.
3317
47be4ab5
PE
3318 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3319
371cac43
PE
3320 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3321 Reported by Stefan Monnier in
3322 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3323 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3324 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3325
d01a7826
PE
3326 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3327 (EMACS_UINTPTR): Likewise, with uintptr_t.
3328
7fd47d5c
PE
3329 * lisp.h: Prefer 64-bit EMACS_INT if available.
3330 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3331 on 32-bit hosts that have 64-bit int, so that they can access
3332 large files.
122b0c86
PE
3333 However, temporarily disable this change unless the temporary
3334 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3335
8727937b
PE
3336 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3337
8ac068ac
PE
3338 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3339 This removes an assumption that EMACS_INT and long are the same
3340 width as pointers. The assumption is true for Emacs porting targets
3341 now, but we want to make other targets possible.
3342 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3343 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3344 In the rest of the code, change types of integers that hold casted
3345 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3346 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3347 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3348 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3349 No need to cast type when ORing.
3350 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3351 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3352 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3353 assume EMACS_INT is the same width as char *.
3354 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3355 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3356 Remove no-longer-needed casts.
3357 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3358 (xg_tool_bar_help_callback, xg_make_tool_item):
3359 Use EMACS_INTPTR to hold an integer
3360 that will be cast to void *; this can avoid a GCC warning
3361 if EMACS_INT is not the same width as void *.
3362 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3363 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3364 (current_message_1, set_message_1):
3365 Use a local to convert to proper width without a cast.
3366 * xmenu.c (dialog_selection_callback): Likewise.
3367
ede49d71
PE
3368 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3369 Also, don't assume VALBITS / RAND_BITS is less than 5,
3370 and don't rely on undefined behavior when shifting a 1 left into
3371 the sign bit.
3372 * lisp.h (get_random): Change signature to match.
3373
2f30ecd0
PE
3374 * lread.c (hash_string): Use size_t, not int, for hash computation.
3375 Normally we prefer signed values; but hashing is special, because
3376 it's better to use unsigned division on hash table sizes so that
3377 the remainder is nonnegative. Also, size_t is the natural width
3378 for hashing into memory. The previous code used 'int', which doesn't
3379 retain enough info to hash well into very large tables.
3380 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3381
2a866e7b
PE
3382 * dbusbind.c: Don't possibly lose pointer info when converting.
3383 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3384 Use XPNTR rather than XHASH, so that the high-order bits of
3385 the pointer aren't lost when converting through void *.
3386
51639eac
PE
3387 * eval.c (Fautoload): Don't double-shift a pointer.
3388
92394119
PE
3389 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3390
dbdb9a7c
JB
33912011-05-06 Juanma Barranquero <lekktu@gmail.com>
3392
3393 * gnutls.c (DEF_GNUTLS_FN):
3394 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3395
db7a0b4f
AS
33962011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3397
3398 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3399 marker. (Bug#8610)
3400
f7ff1b0f 34012011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3402
3403 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3404 New version that can reserve upto 2GB of heap space.
3405
f7ff1b0f 34062011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3407
3408 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3409
639c109b
TZ
34102011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3411
3412 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3413 `gnutls_certificate_set_x509_key_file'.
3414
d2127135
JB
34152011-05-05 Juanma Barranquero <lekktu@gmail.com>
3416
3417 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3418 Update dependencies.
3419
e968f4f3
JB
34202011-05-04 Juanma Barranquero <lekktu@gmail.com>
3421
3422 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3423 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3424 Remove unused parameter `fildes'.
3425 * process.c (read_process_output, send_process): Don't pass it.
3426
84d358f0
JB
34272011-05-04 Juanma Barranquero <lekktu@gmail.com>
3428
3429 Fix previous change: the library cache is defined in w32.c.
3430 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3431 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3432
0898ca10
JB
34332011-05-04 Juanma Barranquero <lekktu@gmail.com>
3434
3435 Implement dynamic loading of GnuTLS on Windows.
3436
3437 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3438 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3439 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3440 Declare.
3441
3442 * gnutls.c (Qgnutls_dll): Define.
3443 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3444 (gnutls_*): Declare function pointers.
3445 (init_gnutls_functions): New function to initialize function pointers.
3446 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3447 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3448 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3449 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3450 (emacs_gnutls_write, emacs_gnutls_read)
3451 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3452 (Fgnutls_available_p): New function.
3453 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3454 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3455 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3456
3457 * image.c: Include w32.h.
3458 (Vimage_type_cache): Delete.
3459 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3460 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3461 (w32_delayed_load): Move to w32.c.
3462
3463 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3464
3465 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3466 (w32_delayed_load): Move from image.c. When loading a library, record
3467 its filename in the :loaded-from property of the library id.
3468 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3469 Initialize and staticpro them.
3470 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3471
3472 * process.c: Include lisp.h before w32.h, not after.
3473 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3474 instead of gnutls_record_check_pending.
3475
3476 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3477
ff4de4aa
TZ
34782011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3479
3480 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3481 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3482 as passed in.
3483
abe95abb
JD
34842011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3485
3486 * xterm.c (x_set_frame_alpha): Do not set property on anything
3487 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3488
e16e55d4
JB
34892011-05-02 Juanma Barranquero <lekktu@gmail.com>
3490
3491 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3492
bafcf6a5
JB
34932011-05-02 Juanma Barranquero <lekktu@gmail.com>
3494
3495 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3496 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3497 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3498 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3499 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3500 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3501 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3502 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3503 (Qgnutls_bootprop_callbacks_verify): Make static.
3504
e7a6747f
AS
35052011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3506
19ed11ba
AS
3507 * callproc.c: Indentation fixup.
3508
e7a6747f 3509 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3510 (wait_for_termination, interruptible_wait_for_termination):
3511 Move after wait_for_termination_1.
e7a6747f 3512
1ef14cb4
LMI
35132011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3514
3515 * sysdep.c (interruptible_wait_for_termination): New function
3516 which is like wait_for_termination, but allows keyboard
3517 interruptions.
3518
3519 * callproc.c (Fcall_process): Add (:file "file") as an option for
3520 the STDOUT buffer.
3521 (Fcall_process_region): Ditto.
3522
330d880c
EZ
35232011-04-30 Eli Zaretskii <eliz@gnu.org>
3524
8db90b73
EZ
3525 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3526 rather than `XVECTOR (FOO)->size'.
3527
330d880c
EZ
3528 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3529 inttypes.h, as a gnulib replacement is used if it not available in
3530 system headers.
3531
15cbd324
EZ
35322011-04-21 Eli Zaretskii <eliz@gnu.org>
3533
3534 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3535 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3536 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3537
3538 * coding.c (coding_alloc_by_realloc): Error out if destination
3539 will grow beyond MOST_POSITIVE_FIXNUM.
3540 (decode_coding_emacs_mule): Abort if there isn't enough place in
3541 charbuf for the composition carryover bytes. Reserve an extra
3542 space for up to 2 characters produced in a loop.
3543 (decode_coding_iso_2022): Abort if there isn't enough place in
3544 charbuf for the composition carryover bytes.
3545
35462011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3547
ae940cca
EZ
3548 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3549 aborting when %lld or %lll format is passed.
3550 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3551 %llo or %llx format is passed. (Bug#8545)
3552
03ab8921
EZ
3553 * window.c (window_scroll_line_based): Use a marker instead of
3554 simple variables to record original value of point. (Bug#7952)
3555
afda1437
EZ
3556 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3557 produced by %s or %c overflows available buffer space. (Bug#8545)
3558
f76dee0c
PE
35592011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3560
3561 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3562 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3563
fdc5744d
JB
35642011-04-28 Juanma Barranquero <lekktu@gmail.com>
3565
3566 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3567
638f053a
JB
35682011-04-28 Juanma Barranquero <lekktu@gmail.com>
3569
3570 * keyboard.c (Qdelayed_warnings_hook): Define.
3571 (command_loop_1): Run `delayed-warnings-hook'
3572 if Vdelayed_warnings_list is non-nil.
3573 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3574 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3575
d178f871
EZ
35762011-04-28 Eli Zaretskii <eliz@gnu.org>
3577
3578 * doprnt.c (doprnt): Don't return value smaller than the buffer
3579 size if the message was truncated. (Bug#8545).
3580
b124fd93
JB
35812011-04-28 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3584 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3585
e810457d
PE
35862011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3587
3588 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3589
ea51cceb
JB
35902011-04-27 Juanma Barranquero <lekktu@gmail.com>
3591
3592 * makefile.w32-in: Update dependencies.
3593
94dcfacf
EZ
35942011-04-27 Eli Zaretskii <eliz@gnu.org>
3595
3596 Improve `doprnt' and its usage. (Bug#8545)
3597 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3598 `format_end'. Remove support for %l as a conversion specifier.
3599 Don't use xrealloc. Improve diagnostics when the %l size modifier
3600 is used. Update the commentary.
3601
3602 * eval.c (verror): Simplify calculation of size_t.
3603
3604 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3605 messages.
3606
f61f41d7
PE
36072011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3608
3609 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3610 change.
3611
96fb4434
PE
36122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3613
3614 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3615 This makes this file independent of the recent pseudovector change.
3616
671875da 36172011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3618
69e9b5a3
PE
3619 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3620
b5f869a7 3621 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3622 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3623 Remove unused local.
c8926152 3624 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3625
841a1577 3626 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3627 GCC 4.6.0 optimizes based on type-based alias analysis.
3628 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3629 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3630 != &v->size, and therefore "v->size = 1; b->size = 2; return
3631 v->size;" must therefore return 1. This assumption is incorrect
3632 for Emacs, since it type-puns struct Lisp_Vector * with many other
3633 types. To fix this problem, this patch adds a new type struct
f904488f 3634 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3635 and pseudovectors, and helps optimizing compilers not get fooled
3636 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3637 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3638 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3639 the size member.
eab3844f
PE
3640 (XSETPVECTYPE): Rewrite in terms of new macro.
3641 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3642 This is a bit clearer, and further avoids the possibility of
3643 undesirable aliasing.
3644 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3645 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3646 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3647 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3648 (ASIZE): Now uses header.size rather than size.
3649 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3650 to avoid the hassle of writing XVECTOR (foo)->header.size.
3651 (struct vectorlike_header): New type.
eab3844f
PE
3652 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3653 object, to help avoid aliasing.
3654 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3655 (SUBRP): Likewise, since Lisp_Subr is a special case.
3656 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3657 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3658 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3659 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3660 changed to be "header.size" and "header.next".
3661 * buffer.h (struct buffer): Likewise.
3662 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3663 * frame.h (struct frame): Likewise.
3664 * process.h (struct Lisp_Process): Likewise.
3665 * termhooks.h (struct terminal): Likewise.
3666 * window.c (struct save_window_data, struct saved_window): Likewise.
3667 * window.h (struct window): Likewise.
3668 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3669 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3670 * buffer.c (init_buffer_once): Likewise.
3671 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3672 special case.
3673 * process.c (Fformat_network_address): Use local var for size,
3674 for brevity.
3675
0df1eac5
PE
3676 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3677
847ab9d1 3678 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3679 * data.c (atof): Remove decl; no longer used or needed.
3680 (digit_to_number): Move to lread.c.
3681 (Fstring_to_number): Use new string_to_number function, to be
3682 consistent with how the Lisp reader treats infinities and NaNs.
3683 Do not assume that floating-point numbers represent EMACS_INT
3684 without losing information; this is not true on most 64-bit hosts.
3685 Avoid double-rounding errors, by insisting on integers when
3686 parsing non-base-10 numbers, as the documentation specifies.
3687 * lisp.h (string_to_number): New decl, replacing ...
3688 (isfloat_string): Remove.
bc0a5c13 3689 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3690 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3691 appears to have been a coding error. Similarly, do not accept
3692 strings like +-1e0 as floating point numbers. Do not report
3693 overflow for integer overflows unless the base is not 10 which
3694 means we have no simple and reliable way to continue.
3695 Break out the floating-point parsing into a new
3696 function string_to_number, so that Fstring_to_number parses
3697 floating point numbers consistently with the Lisp reader.
04f2d78b 3698 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3699 (E_CHAR, EXP_INT): Remove, replacing with ...
3700 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3701 (string_to_number): New function, replacing isfloat_string.
3702 This function checks for valid syntax and produces the resulting
3703 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3704 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3705 so that overflow for non-base-10 numbers is reported only when
3706 there's no portable and simple way to convert to floating point.
452f4150 3707
67769ffc
PE
3708 * textprop.c (set_text_properties_1): Rewrite for clarity,
3709 and to avoid GCC warning about integer overflow.
3710
c20db43f
PE
3711 * intervals.h (struct interval): Use EMACS_INT for members
3712 where EMACS_UINT might cause problems. See
3713 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3714 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3715 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3716 All uses changed.
37aa2f85
PE
3717 (offset_intervals): Tell GCC not to worry about length overflow
3718 when negating a negative length.
c20db43f 3719
2538aa2f
PE
3720 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3721 (overrun_check_free): Likewise.
3722
f2d3008d
PE
3723 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3724 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3725 word size.
3726
ec8df744
PE
3727 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3728 (gnutls_make_error): Rename local to avoid shadowing.
3729 (gnutls_emacs_global_deinit): ifdef out; not used.
3730 (Fgnutls_boot): Use const for pointer to readonly storage.
3731 Comment out unused local. Fix pointer signedness problems.
3732
640ee02d
PE
3733 * lread.c (openp): Don't stuff size_t into an 'int'.
3734 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3735 about possible signed overflow.
3736
6048fb2a
PE
3737 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3738 (GDK_KEY_g): Don't define if already defined.
3739 (xg_prepare_tooltip): Avoid pointer signedness problem.
3740 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3741
fa3c87e1
PE
3742 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3743 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3744
2172544b
PE
3745 * xfns.c (Fx_window_property): Simplify a bit,
3746 to make a bit faster and to avoid GCC 4.6.0 warning.
3747 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3748
9b821a21
PE
3749 * fns.c (internal_equal): Don't assume size_t fits in int.
3750
3c616cfa
PE
3751 * alloc.c (compact_small_strings): Tighten assertion a little.
3752
c2982e87
PE
3753 Replace pEd with more-general pI, and fix some printf arg casts.
3754 * lisp.h (pI): New macro, generalizing old pEd macro to other
3755 conversion specifiers. For example, use "...%"pI"d..." rather
3756 than "...%"pEd"...".
3757 (pEd): Remove. All uses replaced with similar uses of pI.
3758 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3759 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3760 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3761 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3762 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3763 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3764 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3765 64-bit hosts.
3766 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3767 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3768 * print.c (safe_debug_print, print_object): Likewise.
3769 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3770 to int.
6f04d126
PE
3771 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3772 avoiding the 0 flag, which is not portable.
c2982e87
PE
3773 * process.c (Fmake_network_process): Use pI to avoid cast.
3774 * region-cache.c (pp_cache): Likewise.
3775 * xdisp.c (decode_mode_spec): Likewise.
3776 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3777 behavior on 64-bit hosts with printf arg.
6f04d126 3778 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3779 (x_stop_queuing_selection_requests): Likewise.
3780 (x_get_window_property): Don't truncate byte count to an 'int'
3781 when tracing.
0b432f21 3782
5e073ec7
PE
3783 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3784 here, since it parses constructs like leading '-' and spaces,
3785 which are not wanted; and it overflows with large numbers.
3786 Instead, simply match F[0-9]+, which is what is wanted anyway.
3787
36372bf9
PE
3788 * alloc.c: Remove unportable assumptions about struct layout.
3789 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3790 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3791 (allocate_vectorlike, make_pure_vector): Use the new macros,
3792 plus offsetof, to remove unportable assumptions about struct layout.
3793 These assumptions hold on all porting targets that I know of, but
3794 they are not guaranteed, they're easy to remove, and removing them
3795 makes further changes easier.
3796
0b432f21
PE
3797 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3798 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3799 (string_overrun_cookie): Now const. Use initializers that
3800 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3801 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3802 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3803 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3804 multiple of sizeof (EMACS_INT); it need not be, if
3805 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3806 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3807
895009e1
JB
38082011-04-26 Juanma Barranquero <lekktu@gmail.com>
3809
3810 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3811
6a7a1b0b
TZ
38122011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3813
3814 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3815 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3816 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3817
841a1577 38182011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3819
3820 * lisp.h (Qdebug): List symbol.
895009e1 3821 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3822 * keyboard.c (debug-on-event): New variable.
3823 (handle_user_signal): Break into debugger when debug-on-event
3824 matches the current signal symbol.
3825
f2d3ba6f
DN
38262011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3827
3828 * alloc.c (check_sblock, check_string_bytes)
3829 (check_string_free_list): Convert to standard C.
3830
42ce4c63
TZ
38312011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3832
3833 * w32.c (emacs_gnutls_push): Fix typo.
3834
825cd63c
EZ
38352011-04-25 Eli Zaretskii <eliz@gnu.org>
3836
fb11d64d
EZ
3837 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3838 "cast to pointer from integer of different size".
3839
825cd63c
EZ
3840 Improve doprnt and its use in verror. (Bug#8545)
3841 * doprnt.c (doprnt): Document the set of format control sequences
3842 supported by the function. Use SAFE_ALLOCA instead of always
3843 using `alloca'.
3844
3845 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3846 is one byte too soon. Don't use xrealloc; instead xfree and
3847 xmalloc anew.
3848
e061a11b
TZ
38492011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3850
3851 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3852 callbacks stage.
3853
3854 * gnutls.c: Renamed global_initialized to
3855 gnutls_global_initialized. Added internals for the
3856 :verify-hostname-error, :verify-error, and :verify-flags
3857 parameters of `gnutls-boot' and documented those parameters in the
3858 docstring. Start callback support.
9173deec
JB
3859 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3860 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3861 on error. Return error code.
e061a11b
TZ
3862 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3863 (emacs_gnutls_read): Likewise.
3864 (Fgnutls_boot): Return handshake error code.
3865 (emacs_gnutls_handle_error): New function.
3866 (wsaerror_to_errno): Likewise.
3867
3868 * w32.h (emacs_gnutls_pull): Add prototype.
3869 (emacs_gnutls_push): Likewise.
3870
3871 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3872 (emacs_gnutls_push): Likewise.
3873
38742011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3875
3876 * process.c (wait_reading_process_output): Check if GnuTLS
3877 buffered some data internally if no FDs are set for TLS
3878 connections.
3879
3880 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3881 (LIBS): Link to USER_LIBS.
3882 ($(BLD)/gnutls.$(0)): New target.
3883
fa6996bc
EZ
38842011-04-24 Eli Zaretskii <eliz@gnu.org>
3885
eb35682e
EZ
3886 * xdisp.c (handle_single_display_spec): Rename the
3887 display_replaced_before_p argument into display_replaced_p, to
3888 make it consistent with the commentary. Fix typos in the
3889 commentary.
3890
e2ad650c
EZ
3891 * textprop.c (syms_of_textprop): Remove dead code.
3892 (copy_text_properties): Delete obsolete commentary about an
3893 interface that was deleted long ago. Fix typos in the description
3894 of arguments.
3895
1b2de274
EZ
3896 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3897 to changes in oldXMenu/XMenu.h from 2011-04-16.
3898 <menu_help_message, prev_menu_help_message>: Constify.
3899 (IT_menu_make_room): menu->help_text is now `const char **';
3900 adjust.
3901
3902 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3903 to changes in oldXMenu/XMenu.h from 2011-04-16.
3904 (struct XMenu): Declare `help_text' `const char **'.
3905
3906 * xfaces.c <Qunspecified>: Make extern again.
3907
3908 * syntax.c: Include sys/types.h before including regex.h, as
3909 required by Posix.
3910
762b15be
EZ
3911 * doc.c (get_doc_string): Improve the format passed to `error'.
3912
3913 * doprnt.c (doprnt): Improve commentary.
3914
3915 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3916
3917 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3918 them with etags.
3919
f1052e5d
EZ
3920 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3921 changes in globals.h immediately force recompilation.
762b15be
EZ
3922 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3923 $(CURDIR)/s/ms-w32.h.
3924 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3925
fa6996bc
EZ
3926 * character.c (Fchar_direction): Function deleted.
3927 (syms_of_character): Don't defsubr it.
3928 <char-direction-table>: Deleted.
3929
e6c3da20
EZ
39302011-04-23 Eli Zaretskii <eliz@gnu.org>
3931
3932 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3933 * doprnt.c: Include limits.h.
3934 (SIZE_MAX): New macro.
04f2d78b
CB
3935 (doprnt): Return a size_t value. 2nd arg is now size_t.
3936 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3937 Improve overflow protection. Support `l' modifier for integer
3938 conversions. Support %l conversion. Don't assume an EMACS_INT
3939 argument for integer conversions and for %c.
3940
3941 * lisp.h (doprnt): Restore prototype.
3942
3943 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3944 $(SRC)/character.h.
3945
3946 * Makefile.in (base_obj): Add back doprnt.o.
3947
3948 * deps.mk (doprnt.o): Add back prerequisites.
3949 (callint.o): Depend on character.h.
3950
3951 * eval.c (internal_lisp_condition_case): Include the handler
3952 representation in the error message.
3953 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3954 when breaking from the loop.
3955
3956 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3957
3958 * callint.c (Fcall_interactively): When displaying error message
3959 about invalid control letter, pass the character's codepoint, not
3960 a pointer to its multibyte form. Improve display of the character
3961 in octal and display also its hex code.
3962
3963 * character.c (char_string): Use %x to display the (unsigned)
3964 codepoint of an invalid character, to avoid displaying a bogus
3965 negative value.
3966
3967 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3968 `error', not SYMBOL_NAME itself.
3969
3970 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3971 character arguments to `error'.
3972
3973 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3974 to `error' in error message about FINAL_CHAR argument. Make sure
3975 FINAL_CHAR is a character, and use %c when it is passed as
3976 argument to `error'.
3977
4ffd0d6b 39782011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3979
3980 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3981
3982 * w32.c: Include <time.h>.
3983 (sys_localtime): New function.
3984
4ffd0d6b 39852011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3986
3987 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3988
4ffd0d6b 3989 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3990
4ffd0d6b 39912011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3992
4ffd0d6b
GM
3993 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3994 zombies (Bug#8467).
aac0c6e3 3995
04c56954
EZ
39962011-04-19 Eli Zaretskii <eliz@gnu.org>
3997
3998 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3999 gl_state.e_property when gl_state.object is Qt.
4000
4001 * insdel.c (make_gap_larger): Remove limitation of buffer size
4002 to <= INT_MAX.
4003
16a43933
CY
40042011-04-18 Chong Yidong <cyd@stupidchicken.com>
4005
4006 * xdisp.c (lookup_glyphless_char_display)
4007 (produce_glyphless_glyph): Handle cons cell entry in
4008 glyphless-char-display.
4009 (Vglyphless_char_display): Document it.
4010
4011 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4012 glyphless-char-display.
4013
4581706e
CY
40142011-04-17 Chong Yidong <cyd@stupidchicken.com>
4015
4016 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4017
4018 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4019
4020 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4021 definition for no-X builds.
4022
4887c6e2 40232011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4024
fd35b6f9
PE
4025 Static checks with GCC 4.6.0 and non-default toolkits.
4026
5c1ccb01
PE
4027 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4028
006c5daa
PE
4029 * process.c (keyboard_bit_set): Define only if SIGIO.
4030 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4031 (send_process): Repair possible setjmp clobbering.
4032
efc736d3
PE
4033 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4034
4e2fe2e6
PE
4035 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4036
f97334a2
PE
4037 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4038
4e75f29d
PE
4039 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4040 Define only if needed.
4041
90efadd1
PE
4042 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4043 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4044 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4045
3c647824
PE
4046 * dispextern.h (struct redisplay_interface): Rename param
4047 to avoid shadowing.
e264f262 4048 * termhooks.h (struct terminal): Likewise.
761383f4 4049 * xterm.c (xembed_send_message): Likewise.
3c647824 4050
b58c5c4a
PE
4051 * insdel.c (make_gap_smaller): Define only if
4052 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4053
cad59032
PE
4054 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4055 it.
4056
c339dc2e
PE
4057 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4058 so that we aren't warned about unused symbols.
4059
91a3e27b
PE
4060 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4061
399c71d3 4062 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4063
8ffc96f5
PE
4064 * xfns.c (x_real_positions): Mark locals as initialized.
4065
eef9bc79
PE
4066 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4067
098db9dd
PE
4068 * xterm.c: Fix problems found by static analysis with other toolkits.
4069 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4070 (x_dispatch_event): Declare static if USE_GTK, and
4071 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4072 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4073 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4074 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4075 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4076
eb18f6cc
PE
4077 * xmenu.c (menu_help_callback): Pointer type fixes.
4078 Use const pointers when pointing at readonly data. Avoid pointer
4079 signedness clashes.
4080 (FALSE): Remove unused macro.
4081 (update_frame_menubar): Remove unused decl.
4082
1fe72bf8
PE
4083 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4084
60d9e1db
PE
4085 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4086 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4087 (single_menu_item): Rename local to avoid shadowing.
4088
39261c26
PE
4089 * keyboard.c (make_lispy_event): Remove unused local var.
4090
018c5e19
PE
4091 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4092 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4093
63d2b86e
PE
4094 * bitmaps: Change bitmaps from unsigned char back to the X11
4095 compatible char. Avoid the old compiler warnings about
4096 out-of-range initializers by using, for example, '\xab' rather
4097 than 0xab.
4098
aefd87e1
PE
4099 * xgselect.c (xgselect_initialize): Check vs interface
4100 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4101
bf501fb9
PE
4102 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4103
e9829fdf
PE
4104 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4105 to read-only memory.
4106
1086c095
PE
4107 * fns.c (vector): Remove; this old hack is no longer needed.
4108
2baccd04 4109 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4110 Remove unused var.
dde42981 4111 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4112
72391843 4113 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4114
436c16df 4115 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4116 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4117 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4118
92bb796d 4119 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4120 (x_term_init): Remove local to avoid shadowing.
92bb796d 4121
764430a3 4122 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4123
4124 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4125 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4126
d1dfb56c
EZ
41272011-04-16 Eli Zaretskii <eliz@gnu.org>
4128
c4354cb4
EZ
4129 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4130
d1dfb56c
EZ
4131 Fix regex.c, syntax.c and friends for buffers > 2GB.
4132 * syntax.h (struct gl_state_s): Declare character position members
4133 EMACS_INT.
4134
4135 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4136
04f2d78b
CB
4137 * textprop.c (verify_interval_modification, interval_of):
4138 Declare arguments EMACS_INT.
d1dfb56c
EZ
4139
4140 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4141 EMACS_INT.
4142
4143 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4144
4145 * indent.c (Fvertical_motion): Local variable it_start is now
4146 EMACS_INT.
4147
4148 * regex.c (re_match, re_match_2, re_match_2_internal)
4149 (bcmp_translate, regcomp, regexec, print_double_string)
4150 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4151 (re_compile_pattern, re_exec): Declare arguments and local
4152 variables `size_t' and `ssize_t' and return values `regoff_t', as
4153 appropriate.
4154 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4155 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4156 <compile_stack_type>: `size' and `avail' are now `size_t'.
4157
4158 * regex.h <regoff_t>: Use ssize_t, not int.
4159 (re_search, re_search_2, re_match, re_match_2): Arguments that
4160 specify buffer/string position and length are now ssize_t and
4161 size_t. Return type is regoff_t.
4162
613052cd
BK
41632011-04-16 Ben Key <bkey76@gmail.com>
4164
4165 * nsfont.m: Fixed bugs in ns_get_family and
4166 ns_descriptor_to_entity that were caused by using free to
4167 deallocate memory blocks that were allocated by xmalloc (via
4168 xstrdup). This caused Emacs to crash when compiled with
4169 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4170 --enable-checking=xmallocoverrun). xfree is now used to
4171 deallocate these memory blocks.
4172
4170f62f 41732011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4174
71b41406
PE
4175 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4176
9587a89d
PE
4177 emacs_write: Accept and return EMACS_INT for sizes.
4178 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4179 et seq.
4180 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4181 Accept and return EMACS_INT.
4182 (emacs_gnutls_write): Return the number of bytes written on
4183 partial writes.
4184 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4185 (emacs_read, emacs_write): Remove check for negative size, as the
4186 Emacs source code has been audited now.
9587a89d
PE
4187 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4188 (emacs_read, emacs_write): Use it.
273a5f82
PE
4189 * process.c (send_process): Adjust to the new signatures of
4190 emacs_write and emacs_gnutls_write. Do not attempt to store
4191 a byte offset into an 'int'; it might overflow.
9587a89d 4192 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4193
3e047f51
PE
4194 * sound.c: Don't assume sizes fit in 'int'.
4195 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4196 Return EMACS_INT, not int.
3e047f51 4197 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4198 Accept EMACS_INT, not int.
4199 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4200 record read return values.
4201
cc39a9db
BK
42022011-04-15 Ben Key <bkey76@gmail.com>
4203
c9d0ec6d
JB
4204 * keyboard.c (Qundefined): Don't declare static since it is used
4205 in nsfns.m.
4206 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4207 static since they are used in nsfont.m.
cc39a9db 4208
6c60eb9f
SM
42092011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4210
4211 * process.c (Qprocessp): Don't declare static.
4212 * lisp.h (Qprocessp): Declare again.
4213
7990b61a
JB
42142011-04-15 Juanma Barranquero <lekktu@gmail.com>
4215
4216 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4217
5d4cb038
PE
42182011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4219
8bd7b830 4220 Improve C-level modularity by making more things 'static'.
cd64ea1d 4221
e3b27b31
PE
4222 Don't publish debugger-only interfaces to other modules.
4223 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4224 (verify_bytepos, count_markers): Move decls to the only modules
4225 that need them.
4226 * region-cache.h (pp_cache): Likewise.
4227 * window.h (check_all_windows): Likewise.
4228 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4229
5d4cb038
PE
4230 * sysdep.c (croak): Now static, if
4231 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4232 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4233
4234 * alloc.c (refill_memory_reserve): Now static if
4235 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4236 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4237
e87b6180
PE
4238 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4239 Define only if USE_LUCID.
4240
ac64929e
PE
4241 * xrdb.c (x_customization_string, x_rm_string): Now static.
4242
6f37259d
PE
4243 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4244 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4245
1683e3ab
PE
4246 * xdisp.c (draw_row_with_mouse_face): Now static.
4247 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4248
de9c2632
PE
4249 * window.h (check_all_windows): Mark externally visible.
4250
2b96acb7
PE
4251 * window.c (window_deletion_count): Now static.
4252
4253 * undo.c: Make symbols static if they're not exported.
4254 (last_undo_buffer, last_boundary_position, pending_boundary):
4255 Now static.
4256
50436f33
PE
4257 * textprop.c (interval_insert_behind_hooks): Now static.
4258 (interval_insert_in_front_hooks): Likewise.
4259
64520e5c
PE
4260 * term.c: Make symbols static if they're not exported.
4261 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4262 (max_frame_lines, tty_set_terminal_modes):
4263 (tty_reset_terminal_modes, tty_turn_off_highlight):
4264 (get_tty_terminal): Now static.
4265 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4266 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4267 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4268 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4269 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4270
1fa53021
PE
4271 * sysdep.c: Make symbols static if they're not exported.
4272 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4273 Now static.
4274 (sigprocmask_set, full_mask): Remove; unused.
4275 (wait_debugging): Mark as visible.
4276 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4277 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4278
d4b43b22
PE
4279 * syntax.c (syntax_temp): Define only if !__GNUC__.
4280
b7c513d0
PE
4281 * sound.c (current_sound_device, current_sound): Now static.
4282
989b29ad
PE
4283 * search.c (searchbufs, searchbuf_head): Now static.
4284
13a55a78
PE
4285 * scroll.c (scroll_cost): Remove; unused.
4286 * dispextern.h (scroll_cost): Remove decl.
4287
de68a1fc
PE
4288 * region-cache.h (pp_cache): Mark as externally visible.
4289
40ccffa6
PE
4290 * process.c: Make symbols static if they're not exported.
4291 (process_tick, update_tick, create_process, chan_process):
4292 (Vprocess_alist, proc_buffered_char, datagram_access):
4293 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4294 (deactivate_process): Mark defn as static, as well as decl.
4295 * lisp.h (create_process): Remove decl.
4296 * process.h (chan_process, Vprocess_alist): Remove decls.
4297
ad64fc97
PE
4298 * print.c: Make symbols static if they're not exported.
4299 (print_depth, new_backquote_output, being_printed, print_buffer):
4300 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4301 (print_interval, print_number_index, initial_stderr_stream):
4302 Now static.
4303 * lisp.h (Fprinc): Remove decl.
4304 (debug_output_compilation_hack): Mark as externally visible.
4305
adddb265
PE
4306 * sysdep.c (croak): Move decl from here to syssignal.h.
4307 * syssignal.h (croak): Put it here, so the API can be checked when
4308 'croak' is called from dissociate_if_controlling_tty.
4309
1717ede2
PE
4310 * minibuf.c: Make symbols static if they're not exported.
4311 (minibuf_save_list, choose_minibuf_frame): Now static.
4312 * lisp.h (choose_minibuf_frame): Remove decl.
4313
fa5fb2bc
PE
4314 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4315
1e3890d1
PE
4316 * lread.c: Make symbols static if they're not exported.
4317 (read_objects, initial_obarray, oblookup_last_bucket_number):
4318 Now static.
4319 (make_symbol): Remove; unused.
4320 * lisp.h (initial_obarray, make_symbol): Remove decls.
4321
8a1414fa
PE
4322 * keyboard.c: Make symbols static if they're not exported.
4323 (single_kboard, recent_keys_index, total_keys, recent_keys):
4324 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4325 (this_single_command_key_start, echoing, last_auto_save):
4326 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4327 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4328 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4329 (Vlispy_mouse_stem, double_click_count):
4330 Now static.
4331 (force_auto_save_soon): Define only if SIGDANGER.
4332 (ignore_mouse_drag_p): Now static if
4333 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4334 (print_help): Remove; unused.
4335 (stop_character, last_timer_event): Mark as externally visible.
4336 * keyboard.h (ignore_mouse_drag_p): Declare only if
4337 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4338 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4339 * lisp.h (echoing): Remove decl.
4340 (force_auto_save_soon): Declare only if SIGDANGER.
4341 * xdisp.c (redisplay_window): Simplify code, to make it more
4342 obvious that ignore_mouse_drag_p is not accessed if !defined
4343 USE_GTK && !defined HAVE_NS.
4344
93ea6e8f
PE
4345 * intervals.c: Make symbols static if they're not exported.
4346 (merge_properties_sticky, merge_interval_right, delete_interval):
4347 Now static.
4348 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4349
77382fcc
PE
4350 * insdel.c: Make symbols static if they're not exported.
4351 However, leave prepare_to_modify_buffer alone. It's never
4352 called from outside this function, but that appears to be a bug.
4353 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4354 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4355 (adjust_after_replace_noundo): Remove; unused.
4356 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4357 (signal_before_change): Remove decls.
77382fcc 4358
9306c32e
PE
4359 * indent.c (val_compute_motion, val_vmotion): Now static.
4360
cd44d2eb
PE
4361 * image.c: Make symbols static if they're not exported.
4362 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4363 if USE_GTK.
4364 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4365 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4366
ad9a7a06
PE
4367 * fringe.c (standard_bitmaps): Now static.
4368 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4369
81626931
PE
4370 * frame.c: Make symbols static if they're not exported.
4371 (x_report_frame_params, make_terminal_frame): Now static.
4372 (get_frame_param): Now static, unless HAVE_NS.
4373 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4374 (x_get_resource_string): Remove; not used.
4375 * frame.h (make_terminal_frame, x_report_frame_params):
4376 (x_get_resource_string); Remove decls.
4377 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4378 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4379
239f9db9
PE
4380 * font.c, fontset.c: Make symbols static if they're not exported.
4381 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4382 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4383 * font.c (font_close_object): Now static.
4384 * font.h (font_close_object): Remove.
4385 * fontset.c (FONTSET_OBJLIST): Remove.
4386 (free_realized_fontset) #if-0 the body, which does nothing.
4387 (face_suitable_for_char_p): #if-0, as it's never called.
4388 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4389 * xfaces.c (face_at_string_position):
4390 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4391 since 0 is always ASCII.
4392
dfcf3579
PE
4393 * fns.c (weak_hash_tables): Now static.
4394
5045092b
PE
4395 * fileio.c: Make symbols static if they're not exported.
4396 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4397 (Vwrite_region_annotation_buffers): Now static.
4398
57a96f5c
PE
4399 * eval.c: Make symbols static if they're not exported.
4400 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4401 * lisp.h (backtrace_list): Remove decl.
4402
35f08c38
PE
4403 * emacs.c: Make symbols static if they're not exported.
4404 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4405 (fatal_error_code, fatal_error_signal_hook, standard_args):
4406 Now static.
4407 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4408 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4409 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4410 * lisp.h (fatal_error_signal_hook): Remove decl.
4411 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4412
f44bd759
PE
4413 * editfns.c: Move a (normally-unused) function to its only use.
4414 * editfns.c, lisp.h (get_operating_system_release): Remove.
4415 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4416 worth the hassle of breaking this out.
4417
b532497d
PE
4418 * xterm.c: Make symbols static if they're not exported.
4419 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4420 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4421 (x_destroy_window, x_delete_display):
4422 Now static.
4423 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4424 (x_mouse_leave): Remove; unused.
4425 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4426 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4427 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4428 Remove decls.
4429 (x_mouse_leave): Declare only if WINDOWSNT.
4430 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4431 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4432 USE_X_TOOLKIT.
4433
1675728f
PE
4434 * ftxfont.c: Make symbols static if they're not exported.
4435 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4436 HAVE_FREETYPE.
4437 * font.h (ftxfont_driver): Likewise.
4438
e4cebfca
PE
4439 * xfns.c: Make symbols static if they're not exported.
4440 (x_last_font_name, x_display_info_for_name):
4441 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4442 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4443 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4444 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4445 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4446 (last_show_tip_args): Now static.
4447 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4448 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4449 (x_screen_planes): Remove; unused.
4450 * dispextern.h (x_screen_planes): Remove decl.
4451
5bf46f05
PE
4452 * dispnew.c: Make symbols static if they're not exported.
4453 * dispextern.h (redraw_garbaged_frames, scrolling):
4454 (increment_row_positions): Remove.
4455 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4456 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4457 Now static.
4458 (redraw_garbaged_frames): Remove; unused.
4459
435f4c28
PE
4460 * xfaces.c: Make symbols static if they're not exported.
4461 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4462 Remove decls.
4463 * xterm.h (defined_color): Remove decls.
4464 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4465 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4466 (menu_face_changed_default, defined_color, free_realized_face):
4467 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4468 (ascii_face_of_lisp_face): Remove; unused.
4469
8524aef3
PE
4470 * xdisp.c: Make symbols static if they're not exported.
4471 * dispextern.h (scratch_glyph_row, window_box_edges):
4472 (glyph_to_pixel_coords, set_cursor_from_row):
4473 (get_next_display_element, set_iterator_to_next):
4474 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4475 (show_mouse_face): Remove decls
4476 * frame.h (message_buf_print): Likewise.
4477 * lisp.h (pop_message, set_message, check_point_in_composition):
4478 Likewise.
4479 * xterm.h (set_vertical_scroll_bar): Likewise.
4480 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4481 (message_buf_print, scratch_glyph_row, displayed_buffer):
4482 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4483 (get_next_display_element, show_mouse_face, window_box_edges):
4484 (frame_to_window_pixel_xy, check_point_in_composition):
4485 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4486 (glyph_to_pixel_coords): Remove; unused.
4487
16390cd2
PE
4488 * dired.c (file_name_completion): Now static.
4489
4490 * dbusbind.c (xd_in_read_queued_messages): Now static.
4491
a25f4dfa
PE
4492 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4493 * data.c (circular_list_error): Remove.
4494
14a9c8df
PE
4495 * commands.h (last_point_position, last_point_position_buffer):
4496 (last_point_position_window): Remove decls.
4497 * keyboard.c: Make these variables static.
4498
04f2d78b
CB
4499 * coding.h (coding, code_convert_region, encode_coding_gap):
4500 Remove decls.
74ab6df5
PE
4501 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4502 (iso_code_class, detect_coding, code_convert_region): Now static.
4503 (encode_coding_gap): Remove; unused.
4504
38dfbee1
PE
4505 * chartab.c (chartab_chars, chartab_bits): Now static.
4506
a2cb4e63
PE
4507 * charset.h (charset_iso_8859_1): Remove decl.
4508 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4509 Now static.
4510
127198fd
PE
4511 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4512 * ccl.c (Vccl_program_table): Now static.
4513 (check_ccl_update): Remove; unused.
4514
d85b608f
PE
4515 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4516 * category.h: ... from here.
4517 * category.c (check_category_table, set_category_set): Now static.
4518
31cd66f3
PE
4519 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4520 * lisp.h: Remove these decls.
4521
c358e587
PE
4522 * buffer.c (buffer_count): Remove unused var.
4523
e78aecca
PE
4524 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4525 so that it's not optimized away.
4526 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4527 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4528 exported only to the debugger.
4529
e192d7d3 4530 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4531 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4532
92470028
PE
4533 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4534 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4535 was inaccessible from Lisp.
4536 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4537 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4538
244ed907
PE
4539 alloc.c: Import and export fewer symbols, and remove unused items.
4540 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4541 is defined.
4542 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4543 it's not optimized away by whole-program optimization.
4544 (message_enable_multibyte, free_misc): Remove.
4545 (catchlist, handlerlist, mark_backtrace):
4546 Declare only if BYTE_MARK_STACK.
4547 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4548 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4549 (message_enable_multibyte): Remove decl.
4550 (free_misc, interval_free_list, float_block, float_block_index):
4551 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4552 (cons_free_list, last_marked_index):
4553 Now static.
4554 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4555 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4556 (mark_backtrace): Define only if BYTE_MARK_STACK.
4557 * xdisp.c (message_enable_multibyte): Now static.
4558
61c2b50e 4559 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4560 This makes it easier for human readers (and static analyzers)
4561 to see whether these variables are used from other modules.
4562 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4563 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4564 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4565 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4566 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4567 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4568 * xmenu.c, xselect.c:
4569 Declare Q* vars static if they are not used in other modules.
4570 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4571 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4572 Remove decls of unexported vars.
4573 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4574
95c82688
PE
4575 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4576
16a97296
PE
4577 Make Emacs functions such as Fatom 'static' by default.
4578 This makes it easier for human readers (and static analyzers)
4579 to see whether these functions can be called from other modules.
4580 DEFUN now defines a static function. To make the function external
4581 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4582 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4583 (Finit_image_library):
16a97296
PE
4584 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4585 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4586 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4587 Remove decls, since these functions are now static.
4588 (Funintern, Fget_internal_run_time): New decls, since these functions
4589 were already external.
95c82688 4590
16a97296
PE
4591 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4592 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4593 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4594 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4595 * keyboard.c, keymap.c, lread.c:
4596 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4597 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4598 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4599 Mark functions with DEFUE instead of DEFUN,
4600 if they are used in other modules.
4601 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4602 decls for now-static functions.
4603 * buffer.h (Fdelete_overlay): Remove decl.
4604 * callproc.c (Fgetenv_internal): Mark as internal.
4605 * composite.c (Fremove_list_of_text_properties): Remove decl.
4606 (Fcomposition_get_gstring): New forward static decl.
4607 * composite.h (Fcomposite_get_gstring): Remove decl.
4608 * dired.c (Ffile_attributes): New forward static decl.
4609 * doc.c (Fdocumntation_property): New forward static decl.
4610 * eval.c (Ffetch_bytecode): New forward static decl.
4611 (Funintern): Remove extern decl; now in .h file where it belongs.
4612 * fileio.c (Fmake_symbolic_link): New forward static decl.
4613 * image.c (Finit_image_library): New forward static decl.
4614 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4615 * intervals.h (Fprevious_property_change):
4616 (Fremove_list_of_text_properties): Remove decls.
4617 * keyboard.c (Fthis_command_keys): Remove decl.
4618 (Fcommand_execute): New forward static decl.
4619 * keymap.c (Flookup_key): New forward static decl.
4620 (Fcopy_keymap): Now static.
4621 * keymap.h (Flookup_key): Remove decl.
4622 * process.c (Fget_process): New forward static decl.
4623 (Fprocess_datagram_address): Mark as internal.
4624 * syntax.c (Fsyntax_table_p): New forward static decl.
4625 (skip_chars): Remove duplicate decl.
4626 * textprop.c (Fprevious_property_change): New forward static decl.
4627 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4628 Now internal.
4629 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4630 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4631
785bbd42
PE
4632 * editfns.c (Fformat): Remove unreachable code.
4633
8b913b57
AS
46342011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4635
4636 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4637 change. (Bug#8496)
4638
a6744a35
EZ
46392011-04-13 Eli Zaretskii <eliz@gnu.org>
4640
4641 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4642 when at ZV. (Bug#8487)
4643
e7974947
AS
46442011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4645
baad03f0
AS
4646 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4647 (Bug#8437)
4648 * keyboard.c (parse_tool_bar_item): Likewise.
4649 * sound.c (sound_cleanup, alsa_close): Likewise.
4650 * termcap.c (tgetent): Likewise.
4651 * xfns.c (x_default_font_parameter): Likewise.
4652 * xsettings.c (read_and_apply_settings): Likewise.
4653
e7974947
AS
4654 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4655 (overrun_check_free): Protoize.
4656
28272684
PE
46572011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4658
4659 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4660 since callers should never pass a negative size.
4661 Change the signature to match that of plain 'read' and 'write'; see
4662 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4663 * lisp.h: Update prototypes of emacs_write and emacs_read.
4664
11997c76
EZ
46652011-04-11 Eli Zaretskii <eliz@gnu.org>
4666
4667 * xdisp.c (redisplay_window): Don't try to determine the character
4668 position of the scroll margin if the window start point w->startp
e896f03c 4669 is outside the buffer's accessible region. (Bug#8468)
11997c76 4670
8a2cbd72
EZ
46712011-04-10 Eli Zaretskii <eliz@gnu.org>
4672
4673 Fix write-region and its subroutines for buffers > 2GB.
4674 * fileio.c (a_write, e_write): Modify declaration of arguments and
4675 local variables to support buffers larger than 2GB.
4676 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4677
4678 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4679 argument, local variables, and return value.
4680
4681 * lisp.h: Update prototypes of emacs_write and emacs_read.
4682
4683 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4684
4073e537 46852011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4686
1ebfdcb6
PE
4687 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4688
b2ded58d
PE
4689 Fix more problems found by GCC 4.6.0's static checks.
4690
7d66342c
PE
4691 * xdisp.c (vmessage): Use a better test for character truncation.
4692
bbf47d44
PE
4693 * charset.c (load_charset_map): <, not <=, for optimization,
4694 and to avoid potential problems with integer overflow.
9248994d 4695 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4696 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4697 * editfns.c (Fformat): Likewise.
1e69125e 4698 * syntax.c (skip_chars): Likewise.
3befa583 4699
e3019616
PE
4700 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4701 This also lets GCC 4.6.0 generate slightly better loop code.
4702
becfa255
PE
4703 * callint.c (Fcall_interactively): <, not <=, for optimization.
4704 (Fcall_interactively): Count the number of arguments produced,
4705 not the number of arguments given. This is simpler and lets GCC
4706 4.6.0 generate slightly better code.
4707
dae0cd48
PE
4708 * ftfont.c: Distingish more carefully between FcChar8 and char.
4709 The previous code passed unsigned char * to a functions like
4710 strlen and xstrcasecmp that expect char *, which does not
4711 conform to the C standard.
4712 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4713 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4714 char * when the C standard requires it.
4715
76032d70
PE
4716 * keyboard.c (read_char): Remove unused var.
4717
eb3f1cc8
PE
4718 * eval.c: Port to Windows vsnprintf (Bug#8435).
4719 Include <limits.h>.
4720 (SIZE_MAX): Define if the headers do not.
4721 (verror): Do not give up if vsnprintf returns a negative count.
4722 Instead, grow the buffer. This ports to Windows vsnprintf, which
4723 does not conform to C99. Problem reported by Eli Zaretskii.
4724 Also, simplify the allocation scheme, by avoiding the need for
4725 calling realloc, and removing the ALLOCATED variable.
4726
70476b54
PE
4727 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4728
12020a9e
PE
4729 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4730 But keep the doprint source code for now, as we might revamp it
4731 and use it again (Bug#8435).
ea6c7ae6
PE
4732 * lisp.h (doprnt): Remove.
4733 * Makefile.in (base_obj): Remove doprnt.o.
4734 * deps.mk (doprnt.o): Remove.
4735
5fdb398c
PE
4736 error: Print 32- and 64-bit integers portably (Bug#8435).
4737 Without this change, on typical 64-bit hosts error ("...%d...", N)
4738 was used to print both 32- and 64-bit integers N, which relied on
4739 undefined behavior.
4740 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4741 New macro.
4742 * lisp.h (error, verror): Mark as printf-like functions.
4743 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4744 Report overflow in size calculations when allocating printf buffer.
4745 Do not truncate output string at its first null byte.
4746 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4747 Truncate the output at a character boundary, since vsnprintf does not
4748 do that.
4749 * charset.c (check_iso_charset_parameter): Convert internal
4750 character to string before calling 'error', since %c now has the
4751 printf meaning.
4752 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4753 overflow when computing char to be passed to 'error'. Do not
4754 pass Lisp_Object to 'error'; pass the integer instead.
4755 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4756 formatted with plain %d.
4757
b189fa66
PE
4758 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4759
bff87ef0
PE
4760 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4761
7e2cac20
PE
4762 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4763
ce4d90b5
PE
4764 * xterm.c (x_catch_errors): Remove duplicate declaration.
4765
266c9547
PE
4766 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4767
79c49ad2
PE
4768 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4769
368f4090
JM
47702011-04-10 Jim Meyering <meyering@redhat.com>
4771
4772 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4773 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4774 return ssize_t not "int", and use size_t as the buffer length.
4775 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4776 * gnutls.h: Update declarations.
4777 * process.c (read_process_output): Use ssize_t, to match.
4778 (send_process): Likewise.
4779
a32d4040
CY
47802011-04-09 Chong Yidong <cyd@stupidchicken.com>
4781
4782 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4783
8546720e 47842011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4785
04f2d78b
CB
4786 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4787 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4788
8546720e
GM
4789 * xterm.c (handle_one_xevent):
4790 * xmenu.c (create_and_show_popup_menu):
4791 * xselect.c (x_decline_selection_request)
4792 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4793
0a2f5c1a 47942011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4795
4796 Fix some uses of `int' instead of EMACS_INT.
4797 * search.c (string_match_1, fast_string_match)
4798 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4799 (scan_buffer, find_next_newline_no_quit)
4800 (find_before_next_newline, search_command, Freplace_match)
4801 (Fmatch_data): Make some `int' variables be EMACS_INT.
4802
4803 * xdisp.c (display_count_lines): 3rd argument and return value now
4804 EMACS_INT. All callers changed.
4805 (pint2hrstr): Last argument is now EMACS_INT.
4806
4807 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4808 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4809 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4810 (decode_coding_utf_16, decode_coding_emacs_mule)
4811 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4812 (decode_coding_ccl, decode_coding_charset)
4813 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4814 (decode_coding_iso_2022, decode_coding_emacs_mule)
4815 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4816 <char_offset, last_offset>: Declare EMACS_INT.
4817 (encode_coding_utf_8, encode_coding_utf_16)
4818 (encode_coding_emacs_mule, encode_invocation_designation)
4819 (encode_designation_at_bol, encode_coding_iso_2022)
4820 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4821 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4822 Declare EMACS_INT.
4823 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4824 (encode_invocation_designation): Last argument P_NCHARS is now
4825 EMACS_INT.
4826 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4827 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4828
4829 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4830 All users changed.
4831
4832 * ccl.c (Fccl_execute_on_string): Declare some variables
4833 EMACS_INT.
4834
8546720e 48352011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4836
4837 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4838
4e19a977
CS
48392011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4840
4841 * process.c (Fformat_network_address): Doc fix.
4842
87302331
R
48432011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4844
4845 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4846
cbb59342
CY
48472011-04-08 Chong Yidong <cyd@stupidchicken.com>
4848
4849 * keyboard.c (read_char): Call Lisp function help-form-show,
4850 instead of using internal_with_output_to_temp_buffer.
4851 (Qhelp_form_show): New var.
e0d38eeb 4852 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4853
4854 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4855
4856 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4857
e67a13ab
CY
48582011-04-06 Chong Yidong <cyd@stupidchicken.com>
4859
04f2d78b
CB
4860 * process.c (Flist_processes): Remove to Lisp.
4861 (list_processes_1): Delete.
e67a13ab 4862
973f782d
EZ
48632011-04-06 Eli Zaretskii <eliz@gnu.org>
4864
7c106b1e
EZ
4865 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4866
973f782d
EZ
4867 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4868
41cf7d1a 48692011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4870
ca23cc88
PE
4871 Fix more problems found by GCC 4.6.0's static checks.
4872
f390e2d5
PE
4873 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4874
42eea0d0
PE
4875 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4876
b69769da 4877 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4878
f9541e84
PE
4879 * xdisp.c (vmessage): Mark as a printf-like function.
4880
13841b55
PE
4881 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4882
c136c10f
PE
4883 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4884
5e2d4a30
PE
4885 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4886 printf-like functions.
4887 (tiff_load): Add casts to remove these marks before passing them
4888 to system-supplied API.
4889
583f48b9
PE
4890 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4891
b25d760e
PE
4892 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4893 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4894 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4895 directly, rather than having caller test rule sign. This avoids
4896 some unnecessary tests.
4897 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4898 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4899 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4900
bc7b6697 4901 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4902 (xfont_open): Avoid unnecessary tests.
bc7b6697 4903
27ccc379
PE
4904 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4905
dcd5c89a
PE
4906 * composite.h, composite.c (composition_gstring_put_cache):
4907 Use EMACS_INT, not int, for length.
4908
b13a45c6
PE
4909 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4910 breaking out part of COMPOSITION_DECODE_RULE.
4911 (COMPOSITION_DECODE_RULE): Use it.
4912 * composite.c (get_composition_id): Remove unused local vars,
4913 by using the new macro.
4914
1e792e4d
PE
4915 * textprop.c (set_text_properties_1): Change while to do-while,
4916 since the condition is always true at first.
4917
dc6c6455 4918 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4919 (interval_deletion_adjustment): Return unsigned value.
4920 All uses changed.
dc6c6455 4921
aba7731a
PE
4922 * process.c (list_processes_1, create_pty, read_process_output):
4923 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4924 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4925 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4926 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4927 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4928
fdfc4bf3
PE
4929 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4930
fca8fe46 4931 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4932 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4933
06a0259a 4934 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4935 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4936 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4937
e7b9e80f
PE
4938 * print.c (print_error_message): Avoid int overflow.
4939
56201685
PE
4940 * font.c (font_list_entities): Redo for clarity,
4941 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4942
78834453 4943 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4944 (font_score): Avoid potential overflow in diff calculation.
78834453 4945
0bc0b309 4946 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4947 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4948
e610eaca
PE
4949 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4950
b895abce
PE
4951 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4952 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4953 can always succeed if overflow has undefined behavior.
4954
1f1d9321 4955 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4956 (wordify): Omit three unnecessary tests.
1f1d9321 4957
c59478bc
PE
4958 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4959 All callers changed. This avoids the need for an unused var.
4960
79b73827
PE
4961 * casefiddle.c (casify_region): Remove var that is set but not used.
4962
a4db5dfe
PE
4963 * dired.c (file_name_completion): Remove var that is set but not used.
4964
43aae36e
PE
4965 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4966
2a47c44d 4967 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4968 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4969
a37c69bf
PE
4970 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4971 Check for integer overflow on size calculations.
4972
328ab8e7
PE
4973 * buffer.c (Fprevious_overlay_change): Remove var that is set
4974 but not used.
4975
e5a2a5cb
PE
4976 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4977 Remove vars that are set but not used.
8d84a6eb 4978 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4979 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4980
a60e5f68
PE
4981 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4982
f661cb61 4983 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4984 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4985
f0397f5a
PE
4986 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4987 that are set but not used.
4988
8664db06 4989 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4990 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4991
6abdaa4a
PE
4992 * xselect.c (x_get_local_selection, x_handle_property_notify):
4993 Remove vars that are set but not used.
4994
0ce7538d 4995 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4996 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4997
9ae848fc
PE
4998 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4999 Remove var that is set but not used.
0b918413
PE
5000 (scroll_bar_windows_size): Now size_t, not int.
5001 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5002 Check for overflow.
9ae848fc 5003
a5a62657
PE
5004 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5005 (map_tty_color) [!defined MSDOS]: Likewise.
5006
5c5cdd39
PE
5007 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5008
66ebf983
PE
5009 * coding.c: Remove vars that are set but not used.
5010 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5011 All callers changed.
5012 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5013 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5014 (decode_coding_charset): Remove vars that are set but not used.
5015
1be4d761
PE
5016 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5017 that is set but not used.
5018
47553fa8
PE
5019 * print.c (print_object): Remove var that is set but not used.
5020
1f7196bf 5021 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5022 The gnulib version avoids calling malloc in the usual case,
5023 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5024 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5025 * filelock.c (current_lock_owner): Likewise.
5026 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5027 * sysdep.c: Include allocator.h, careadlinkat.h.
5028 (emacs_no_realloc_allocator): New static constant.
5029 (emacs_readlink): New function.
fdb61804
PE
5030 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5031 ../lib/careadlinkat.h.
d1fdcab7 5032
f84c17c7
SM
50332011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5034
5035 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5036 first non-nil return value).
5037
ef3862ad
JD
50382011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5039
5040 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5041 if not defined (Bug#8403).
5042
376a7006
JB
50432011-04-02 Juanma Barranquero <lekktu@gmail.com>
5044
5045 * xdisp.c (display_count_lines): Remove parameter `start',
5046 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5047 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5048 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5049 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5050 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5051 and thereabouts. All callers changed.
5052 (get_per_char_metric): Remove parameter `f', unused since
5053 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5054
6ca3801d
JM
50552011-04-02 Jim Meyering <meyering@redhat.com>
5056
5057 do not dereference NULL upon failed strdup
5058 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5059 (ns_get_family): Likewise.
5060
d8e2b5ba
JB
50612011-04-02 Juanma Barranquero <lekktu@gmail.com>
5062
5063 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5064
8c74fcbd
JD
50652011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5066
5067 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5068 later (Bug#8403).
5069
7200d79c
SM
50702011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5071
03408648 5072 Add lexical binding.
7200d79c 5073
03408648
SM
5074 * window.c (Ftemp_output_buffer_show): New fun.
5075 (Fsave_window_excursion):
5076 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5077
5078 * lread.c (lisp_file_lexically_bound_p): New function.
5079 (Fload): Bind Qlexical_binding.
5080 (readevalloop): Remove `evalfun' arg.
5081 Bind Qinternal_interpreter_environment.
5082 (Feval_buffer): Bind Qlexical_binding.
5083 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5084 Mark as dynamic.
5085 (syms_of_lread): Declare `lexical-binding'.
5086
5087 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5088
5089 * keyboard.c (eval_dyn): New fun.
5090 (menu_item_eval_property): Use it.
ca105506
SM
5091
5092 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5093
03408648
SM
5094 * fns.c (concat, mapcar1): Accept byte-code-functions.
5095
5096 * eval.c (Fsetq): Handle lexical vars.
5097 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5098 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5099 (FletX, Flet): Obey lexical binding.
5100 (Fcommandp): Handle closures.
5101 (Feval): New `lexical' arg.
5102 (eval_sub): New function extracted from Feval. Use it almost
5103 everywhere where Feval was used. Look up vars in lexical env.
5104 Handle closures.
5105 (Ffunctionp): Move from subr.el.
5106 (Ffuncall): Handle closures.
5107 (apply_lambda): Remove `eval_flags'.
5108 (funcall_lambda): Handle closures and new byte-code-functions.
5109 (Fspecial_variable_p): New function.
5110 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5111 but without exporting it to Lisp.
23aba0ea 5112
23aba0ea 5113 * doc.c (Fdocumentation, store_function_docstring):
03408648 5114 * data.c (Finteractive_form): Handle closures.
23aba0ea 5115
03408648
SM
5116 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5117 interactive spec.
ba83908c 5118
04f2d78b
CB
5119 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5120 New byte-codes.
03408648
SM
5121 (exec_byte_code): New function extracted from Fbyte_code to handle new
5122 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5123
03408648 5124 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5125
03408648 5126 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5127
e2abce01
JB
51282011-03-31 Juanma Barranquero <lekktu@gmail.com>
5129
5130 * xdisp.c (redisplay_internal): Fix prototype.
5131
63696a73 51322011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5133
63696a73 5134 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5135 (try_scrolling): Use it when setting scroll_limit.
5136 Limit scrolling to 100 screen lines.
63696a73
EZ
5137 (redisplay_window): Even when falling back on "recentering",
5138 position point in the window according to scroll-conservatively,
5139 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5140
5141 (try_scrolling): When point is above the window, allow searching
5142 as far as scroll_max, or one screenful, to compute vertical
5143 distance from PT to the scroll margin position. This prevents
5144 try_scrolling from unnecessarily failing when
5145 scroll-conservatively is set to a value slightly larger than the
5146 window height. Clean up the case of PT below the margin at bottom
5147 of window: scroll_max can no longer be INT_MAX. When aggressive
5148 scrolling is in use, don't let point enter the opposite scroll
5149 margin as result of the scroll.
5150 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5151 threshold of 100 lines for never-recentering scrolling.
5152
e4cc2dfc
JB
51532011-03-31 Juanma Barranquero <lekktu@gmail.com>
5154
5155 * dispextern.h (move_it_by_lines):
5156 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5157 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5158 (message_log_check_duplicate): Remove parameters `prev_bol' and
5159 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5160 (redisplay_internal): Remove parameter `preserve_echo_area',
5161 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5162
5163 * indent.c (Fvertical_motion):
5164 * window.c (window_scroll_pixel_based, Frecenter):
5165 Don't pass `need_y_p' to `move_it_by_lines'.
5166
1c470562
SM
51672011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5168
44f230aa
SM
5169 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5170 steal a few bits to be more compact.
5171 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5172 Remove unneeded casts.
5173
1c470562
SM
5174 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5175
888adce9
ZK
51762011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5177
5178 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5179 binding" message (bug#7967).
5180
f838ed7b
PE
51812011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5182
77861b95
PE
5183 Fix more problems found by GCC 4.6.0's static checks.
5184
de6dbc14
PE
5185 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5186 Remove unused local var.
5187
f838ed7b
PE
5188 * editfns.c (Fmessage_box): Remove unused local var.
5189
792c7b2b
PE
5190 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5191 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5192 Omit unused local vars.
c499e557 5193 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5194 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5195 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5196 Omit unused local var.
5197
ba0165e1
PE
5198 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5199 Don't assume string length fits in int.
32ad8845 5200 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5201 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5202
3c59b4c9
PE
5203 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5204 instead of alloca (Bug#8344).
5205
a3eed478 5206 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5207 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5208
eb4d412d
PE
5209 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5210
1658b401
PE
5211 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5212 concerns.
5213
5214 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5215
5216 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5217
9a2c6e05
PE
5218 * keyboard.c (syms_of_keyboard): Use the same style as later
5219 in this function when indexing through an array. This also
5220 works around GCC bug 48267.
5221
03d0a109
PE
5222 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5223
44f730c8
PE
5224 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5225
fe75f926
PE
5226 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5227 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5228
ffa8c828
PE
5229 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5230 This avoids undefined behavior on integer overflow, and is a bit
5231 more convenient anyway since it is compared to a size_t variable.
5232
c5101a77
PE
5233 Variadic C functions now count arguments with size_t, not int.
5234 This avoids an unnecessary limitation on 64-bit machines, which
5235 caused (substring ...) to crash on large vectors (Bug#8344).
5236 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5237 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5238 All variadic functions and their callers changed accordingly.
c5101a77
PE
5239 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5240 * data.c (arith_driver, float_arith_driver): Likewise.
5241 * editfns.c (general_insert_function): Likewise.
5242 * eval.c (struct backtrace.nargs, interactive_p)
5243 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5244 (funcall_lambda, mark_backtrace): Likewise.
5245 * fns.c (concat): Likewise.
5246 * frame.c (x_set_frame_parameters): Likewise.
5247 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5248 0 if not found, not -1. All callers changed.
5249
dd3f25f7
PE
5250 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5251 (stack_copy_size): Now size_t, not int.
5252 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5253
461c2ab9
JB
52542011-03-28 Juanma Barranquero <lekktu@gmail.com>
5255
5256 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5257 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5258 All callers changed.
5259
5260 * lisp.h (multibyte_char_to_unibyte):
5261 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5262 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5263 * character.h (CHAR_TO_BYTE8):
5264 * cmds.c (internal_self_insert):
5265 * editfns.c (general_insert_function):
5266 * keymap.c (push_key_description):
5267 * search.c (Freplace_match):
5268 * xdisp.c (message_dolog, set_message_1): All callers changed.
5269
f6d62986
SM
52702011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5271
5272 * keyboard.c (safe_run_hook_funcall): New function.
5273 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5274 don't set the hook to nil, but remove the offending function instead.
5275 (Qcommand_hook_internal): Remove, unused.
5276 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5277 Vcommand_hook_internal.
5278
5279 * eval.c (enum run_hooks_condition): Remove.
5280 (funcall_nil, funcall_not): New functions.
5281 (run_hook_with_args): Call each function through a `funcall' argument.
5282 Remove `cond' argument, now redundant.
5283 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5284 (Frun_hook_with_args_until_failure): Adjust accordingly.
5285 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5286
1db5b1ad
JB
52872011-03-28 Juanma Barranquero <lekktu@gmail.com>
5288
5289 * dispextern.h (string_buffer_position): Remove declaration.
5290
5291 * print.c (strout): Remove parameter `multibyte', unused since
5292 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5293
5294 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5295 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5296 All callers changed.
5297
5298 * w32.c (_wsa_errlist): Use braces for struct initializers.
5299
5300 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5301 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5302 All callers changed.
5303 (string_buffer_position): Likewise. Also, make static (it's never
5304 used outside xdisp.c).
5305 (cursor_row_p): Remove parameter `w', unused since
5306 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5307 (decode_mode_spec): Remove parameter `precision', introduced during
5308 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5309 All callers changed.
5310
5ffb62aa
JD
53112011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5312
5313 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5314
461c2ab9 53152011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5316
5317 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5318 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5319 (ns_update_auto_hide_menu_bar): New functions.
5320 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5321 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5322 ns_constrain_all_frames.
5323 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5324 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5325
5c380ffb
JD
53262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5327
5328 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5329
9af30bdf
GM
53302011-03-27 Glenn Morris <rgm@gnu.org>
5331
5332 * syssignal.h: Replace RETSIGTYPE with void.
5333 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5334 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5335 Replace SIGTYPE with void everywhere.
5336 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5337 * s/template.h (SIGTYPE): Remove commented out definition.
5338
e2abce01
JB
53392011-03-26 Eli Zaretskii <eliz@gnu.org>
5340
5341 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5342 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5343
f868cd8a
JB
53442011-03-26 Juanma Barranquero <lekktu@gmail.com>
5345
59eb0929
JB
5346 * w32.c (read_unc_volume): Use parameter `henum', instead of
5347 global variable `wget_enum_handle'.
5348
5349 * keymap.c (describe_vector): Remove parameters `indices' and
5350 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5351 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5352
f868cd8a
JB
5353 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5354
5355 * keyboard.c (timer_check): Remove parameter `do_it_now',
5356 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5357 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5358 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5359
5360 * keyboard.c (read_char):
5361 * w32menu.c (w32_menu_display_help):
5362 * xmenu.c (show_help_event, menu_help_callback):
5363 Adjust calls to `show_help_echo'.
5364
5365 * gtkutil.c (xg_maybe_add_timer):
5366 * keyboard.c (readable_events):
5367 * process.c (wait_reading_process_output):
5368 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5369
5370 * insdel.c (adjust_markers_gap_motion):
5371 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5372 (gap_left, gap_right): Don't call it.
5373
2ecf6fdb
CY
53742011-03-25 Chong Yidong <cyd@stupidchicken.com>
5375
5376 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5377 incurred during fontification.
5378
6b1f9ba4
JB
53792011-03-25 Juanma Barranquero <lekktu@gmail.com>
5380
5381 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5382 (DEFVAR_PER_BUFFER): Don't pass it.
5383
5384 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5385 (scrolling_window): Don't pass it.
5386
0f4a96b5
JB
53872011-03-25 Juanma Barranquero <lekktu@gmail.com>
5388
5389 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5390
5391 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5392 and `suffix'.
5393 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5394 of variables specific to SELinux and computation of `encoded_absname'.
5395
5396 * image.c (XPutPixel): Remove unused variable `height'.
5397
5398 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5399
5400 * unexw32.c (get_section_info): Remove unused variable `section'.
5401
5402 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5403 (system_process_attributes): Remove unused variable `sess'.
5404 (sys_read): Remove unused variable `err'.
5405
5406 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5407 (w32_wnd_proc): Remove unused variable `isdead'.
5408 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5409 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5410 (x_create_tip_frame): Remove unused variable `tem'.
5411
5412 * w32inevt.c (w32_console_read_socket):
5413 Remove unused variable `no_events'.
5414
5415 * w32term.c (x_draw_composite_glyph_string_foreground):
5416 Remove unused variable `width'.
5417
1149507c
JB
54182011-03-24 Juanma Barranquero <lekktu@gmail.com>
5419
5420 * w32term.c (x_set_glyph_string_clipping):
5421 Don't pass uninitialized region to CombineRgn.
5422
9c88f339
JB
54232011-03-23 Juanma Barranquero <lekktu@gmail.com>
5424
5425 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5426 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5427 (Fx_close_connection): Remove unused variable `i'.
5428
5429 * w32font.c (w32font_draw): Return number of glyphs.
5430 (w32font_open_internal): Remove unused variable `i'.
5431 (w32font_driver): Add missing initializer.
5432
5433 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5434 (fill_in_menu): Remove unused variable `items_added'.
5435
5436 * w32term.c (last_mouse_press_frame): Remove static global variable.
5437 (w32_clip_to_row): Remove unused variable `f'.
5438 (x_delete_terminal): Remove unused variable `i'.
5439
5440 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5441 (NOTHING): Remove unused static global variable.
5442 (uniscribe_check_otf): Remove unused variable `table'.
5443 (uniscribe_font_driver): Add missing initializers.
5444
dee091a3
JD
54452011-03-23 Julien Danjou <julien@danjou.info>
5446
5447 * term.c (Fsuspend_tty, Fresume_tty):
5448 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5449 * window.c (temp_output_buffer_show):
5450 * insdel.c (signal_before_change):
5451 * frame.c (Fhandle_switch_frame):
5452 * fileio.c (Fdo_auto_save):
5453 * emacs.c (Fkill_emacs):
5454 * editfns.c (save_excursion_restore):
5455 * cmds.c (internal_self_insert):
5456 * callint.c (Fcall_interactively):
5457 * buffer.c (Fkill_all_local_variables):
5458 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5459 Use Frun_hooks.
0f4a96b5 5460 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5461 unconditionnaly since it does the check itself.
5462
2c520ab5 54632011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5464
c9c49752
PE
5465 Fix more problems found by GCC 4.5.2's static checks.
5466
8abc3f12
PE
5467 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5468 the first time through the loop, since we know p0 < p1 then.
5469 This also avoids a gcc -Wstrict-overflow warning.
5470
a2d26660
PE
5471 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5472 leading to a memory leak, possible in functions like
5473 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5474 of objects (Bug#8318).
a2d26660 5475
916c72e9
PE
5476 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5477 that could (at least in theory) be that large.
5478
19ab8a18
PE
5479 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5480 This is less likely to overflow, and avoids undefined behavior if
5481 overflow does occur. All callers changed. Use strtoul to scan
5482 for the unsigned long integer.
b7cbbd6f
PE
5483 (pint2hrstr): Simplify and tune code slightly.
5484 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5485
f0641eff
PE
5486 * scroll.c (do_scrolling): Work around GCC bug 48228.
5487 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5488
7f650bb9
PE
5489 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5490 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5491 (validate_x_resource_name): Simplify count usage.
5492 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5493
37dd57d1
PE
5494 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5495 fail (Bug#8306).
81e56e61 5496
699979fc 5497 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5498
401bf9b4
PE
5499 * process.c (Fmake_network_process): Use socklen_t, not int,
5500 where POSIX says socklen_t is required in portable programs.
5501 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5502 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5503 (Fmake_network_process, server_accept_connection):
5504 (wait_reading_process_output, read_process_output):
5505 Likewise.
5506
b93aacde
PE
5507 * process.c: Rename or move locals to avoid shadowing.
5508 (list_processes_1, Fmake_network_process):
5509 (read_process_output_error_handler, exec_sentinel_error_handler):
5510 Rename or move locals.
4dc343ee 5511 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5512 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5513 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5514 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5515 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5516
af8a867c 5517 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5518 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5519 Include tparam.h instead, since it declares them.
af8a867c
PE
5520 * cm.h (PC): Remove extern decl; tparam.h now does this.
5521 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5522 * terminfo.c: Include tparam.h, to check interfaces.
5523 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5524 (tparam): Adjust signature to match interface in tparam.h;
5525 this removes some undefined behavior. Check that outstring and len
5526 are zero, which they always are with Emacs.
5527 * tparam.h (PC, BC, UP): New extern decls.
5528
0248044d 5529 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5530 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5531
8ff096c1 5532 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5533 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5534 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5535 (ftfont_list): Remove unused local.
49eaafba
PE
5536 (get_adstyle_property, ftfont_pattern_entity):
5537 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5538 Rename locals to avoid shadowing.
8ff096c1 5539
e2be39f6
PE
5540 * xfont.c (xfont_list_family): Mark var as initialized.
5541
c9735e30
PE
5542 * xml.c (make_dom): Now static.
5543
8f5201ae
PE
5544 * composite.c (composition_compute_stop_pos): Rename local to
5545 avoid shadowing.
b246f932
PE
5546 (composition_reseat_it): Remove unused locals.
5547 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5548 (composition_update_it): Mark var as initialized.
11b61122
PE
5549 (find_automatic_composition): Mark vars as initialized,
5550 with a FIXME (Bug#8290).
8f5201ae 5551
760fbc2c
PE
5552 character.h: Rename locals to avoid shadowing.
5553 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5554 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5555 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5556 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5557 to avoid shadowing.
5558
ff08eb85
PE
5559 * textprop.c (property_change_between_p): Remove; unused.
5560
fc7bf025
PE
5561 * intervals.c (interval_start_pos): Now static.
5562
235d7abc
PE
5563 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5564
44f230aa
SM
5565 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5566 Rename locals to avoid shadowing.
3e7d6594 5567
50060332
PE
5568 * sound.c (wav_play, au_play, Fplay_sound_internal):
5569 Fix pointer signedness.
d01f234b 5570 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5571 (wav_play): Initialize a variable to 0, to prevent undefined
5572 behavior (Bug#8278).
50060332 5573
c4fc4e30
PE
5574 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5575
918436ed
PE
5576 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5577
c939f91b
PE
5578 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5579 clobbering (Bug#8298).
b9c7f648
PE
5580 * sysdep.c (sys_subshell): Likewise.
5581 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5582
6bd8c144
PE
5583 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5584 This should get cleaned up, so that child_setup has the
5585 same signature on all platforms.
5586
7710357c 5587 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5588 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5589
c59da222
CY
55902011-03-22 Chong Yidong <cyd@stupidchicken.com>
5591
5592 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5593 not to be necessary, and produces flickering.
5594
66b87493
GM
55952011-03-20 Glenn Morris <rgm@gnu.org>
5596
5597 * config.in: Remove file.
5598
45b6f6d5
JB
55992011-03-20 Juanma Barranquero <lekktu@gmail.com>
5600
5601 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5602 are now in src/globals.h.
5603 (syms_of_minibuf): Remove spurious & from previous change.
5604
3ec03f7e
LL
56052011-03-20 Leo <sdl.web@gmail.com>
5606
5607 * minibuf.c (completing-read-function): New variable.
5608 (completing-read-default): Rename from completing-read.
5609 (completing-read): Call completing-read-function.
5610
b14e3e21
CY
56112011-03-19 Juanma Barranquero <lekktu@gmail.com>
5612
5613 * xfaces.c (Fx_load_color_file):
5614 Read color file from absolute filename (bug#8250).
5615
f2b726e6
JB
56162011-03-19 Juanma Barranquero <lekktu@gmail.com>
5617
5618 * makefile.w32-in: Update dependencies.
5619
09f6ff02
EZ
56202011-03-17 Eli Zaretskii <eliz@gnu.org>
5621
5622 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5623
29a6015a
PE
56242011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5625
a3a6c54e
PE
5626 Fix more problems found by GCC 4.5.2's static checks.
5627
b766f867
PE
5628 * process.c (make_serial_process_unwind, send_process_trap):
5629 (sigchld_handler): Now static.
5630
be02381c
PE
5631 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5632 That way, the code declares only the vars that it needs.
5633 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5634 * s/cygwin.h (PTY_ITERATION): Likewise.
5635 * s/darwin.h (PTY_ITERATION): Likewise.
5636 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5637
57048744
PE
5638 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5639 * process.c (allocate_pty): Don't declare stb unless it's needed.
5640
7914961c 5641 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5642 (CONSTANTLIM): Remove; unused.
5643 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5644 Define only if needed.
7914961c 5645
b3967b18
PE
5646 * unexelf.c (unexec): Name an expression,
5647 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5648 Use a different way to cause a compilation error if anyone uses
5649 n rather than nn, a way that does not involve shadowing.
73366a00 5650 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5651
29a6015a
PE
5652 * deps.mk (unexalpha.o): Remove; unused.
5653
43cfc33e 5654 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5655 * unexec.h: New file.
ce701a33
PE
5656 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5657 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5658 Depend on unexec.h.
5659 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5660 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5661 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5662 Change as necessary to match prototype in unexec.h.
ce701a33 5663
01f44d5a
PE
5664 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5665 shadowing.
4f63c6bb 5666 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5667
a6670b0b
PE
5668 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5669 Rename locals to avoid shadowing.
5670
cef2010d 5671 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5672 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5673
d4d7173a
PE
5674 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5675
f08b802a
PE
5676 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5677 warning when compiling print.c.
5678
3ddb0639
PE
5679 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5680 instead of using an uninitialized var.
5ad03b97 5681 (font_sort_entities): Mark var as initialized.
3ddb0639 5682
170a2692
PE
5683 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5684
e663c700
PE
5685 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5686 pointers to constants.
89bc529a 5687 (font_parse_fcname): Remove unused vars.
7b81e2d0 5688 (font_delete_unmatched): Now static.
ea838e10 5689 (font_get_spec): Remove; unused.
13a547c6
PE
5690 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5691 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5692 Rename or move locals to avoid shadowing.
e663c700 5693
2a80c887 5694 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5695 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5696
1384fa33 5697 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5698 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5699
8b2c52e9
PE
5700 * alloc.c (mark_backtrace): Move decl from here ...
5701 * lisp.h: ... to here, so that it can be checked.
5702
475545b5 5703 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5704 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5705 (lisp_indirect_variable): Name an expression,
5706 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5707 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5708
b1349114 5709 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5710 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5711 Use const pointer when appropriate.
b1349114 5712
a2928364
PE
5713 * lisp.h (get_system_name, get_operating_system_release):
5714 Move decls here, to check interfaces.
5715 * process.c (get_operating_system_release): Move decl to lisp.h.
5716 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5717 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5718 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5719 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5720 (Fformat_time_string, Fencode_time, Finsert_char):
5721 (Ftranslate_region_internal, Fformat):
5722 Rename or remove local vars to avoid shadowing.
9710023e 5723 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5724
a415e694
PE
5725 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5726 avoid shadowing.
5727
8ef4622d
PE
5728 * lisp.h (eassert): Check that the argument compiles, even if
5729 ENABLE_CHECKING is not defined.
5730
946f9a5b
PE
5731 * data.c (Findirect_variable): Name an expression, to avoid
5732 gcc -Wbad-function-cast warning.
112396d6 5733 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5734 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5735 (Fmake_variable_buffer_local, Fmake_local_variable):
5736 Mark variables as initialized.
52746918 5737 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5738
e5aab7e7 5739 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5740 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5741 Rename locals to avoid shadowing.
dff45157
PE
5742 (mark_stack): Move local variables into the #ifdef region where
5743 they're used.
7bc26fdb
PE
5744 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5745 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5746 needed otherwise.
5747 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5748 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5749 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5750
e5aab7e7
PE
5751 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5752 avoids undefined behavior in theory.
5753
4da60324
PE
5754 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5755
88043301
PE
5756 Use functions, not macros, for up- and down-casing (Bug#8254).
5757 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5758 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5759 to use the following functions instead of these macros.
5760 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5761 EMACS_INT, since callers assume the returned value fits in int.
5762 (upcase1): Likewise, for UPCASE_TABLE.
5763 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5764 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5765 the race-condition problem in the old DOWNCASE.
88043301 5766
19ed5445
PE
5767 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5768 Rename locals to avoid shadowing.
5769 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5770 (regex_compile, re_search_2, re_match_2_internal):
5771 Remove unused local vars.
952db0d7
PE
5772 (FREE_VAR): Rewrite so as not to use empty "else",
5773 which gcc can warn about.
da053e48 5774 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5775 (RETALLOC_IF): Define only if needed.
5776 (WORDCHAR_P): Likewise. This one is never needed, but is used
5777 only in a comment talking about a compiler bug, so put inside
5778 the #if 0 of that comment.
5779 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5780 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5781 Remove; unused.
19ed5445 5782
1f3561e4 5783 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5784 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5785 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5786
ded6f8f7
PE
5787 * search.c (simple_search): Remove unused var.
5788
dbd37a95
PE
5789 * dired.c (compile_pattern): Move decl from here ...
5790 * lisp.h: ... to here, so that it can be checked.
5791 (struct re_registers): New forward decl.
5792
7e47afad
PE
5793 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5794
85f24f61
PE
5795 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5796 All uses changed.
5797 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5798 Rename locals to avoid shadowing.
5671df8f 5799 (Fvertical_motion): Mark locals as initialized.
85f24f61 5800
181aa2be 5801 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5802 (casify_region): Mark local as initialized.
181aa2be 5803
930d429c
PE
5804 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5805
7082eac6
PE
5806 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5807 New macros, so that the caller can use some names other than
5808 gcpro1, gcpro2, etc.
5809 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5810 of the new macros.
5811 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5812 argument, for consistency with GCPRO2_VAR, etc: it is now the
5813 prefix of the variable, not the variable itself. All uses
5814 changed.
38b2c076
PE
5815 * dired.c (directory_files_internal, file_name_completion):
5816 Rename locals to avoid shadowing.
5817
15206ed9
PE
5818 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5819 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5820 dired.c's scmp function, had undefined behavior.
5821 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5822 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5823 * buffer.h: ... to here, because these macros use current_buffer,
5824 and the new implementation with inline functions needs to have
5825 current_buffer in scope now, rather than later when the macros
5826 are used.
5827 (downcase, upcase1): New static inline functions.
5828 (DOWNCASE, UPCASE1): Reimplement using these functions.
5829 This avoids undefined behavior in expressions like
5830 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5831 from race conditions in accessing the global variables
5832 case_temp1 and case_temp2.
5833 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5834 * lisp.h (case_temp1, case_temp2): Remove their decls.
5835 * character.h (ASCII_CHAR_P): Move from here ...
5836 * lisp.h: ... to here, so that the inline functions mentioned
5837 above can use them.
5838
4a6bea26
PE
5839 * dired.c (directory_files_internal_unwind): Now static.
5840
f14b7e14
PE
5841 * fileio.c (file_name_as_directory, directory_file_name):
5842 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5843 Now static.
2893f146
PE
5844 (file_name_as_directory): Use const pointers when appropriate.
5845 (Fexpand_file_name): Likewise. In particular, newdir might
5846 point at constant storage, so make it a const pointer.
fd4ead52 5847 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5848 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5849 signedness issues.
f839df0c
PE
5850 (Fset_file_times, Finsert_file_contents, auto_save_error):
5851 Rename locals to avoid shadowing.
f14b7e14 5852
5716756e 5853 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5854 (Ftry_completion, Fall_completions): Rename or remove locals
5855 to avoid shadowing.
5716756e 5856
b4c3046a
PE
5857 * marker.c (bytepos_to_charpos): Remove; unused.
5858
b45db522
PE
5859 * lisp.h (verify_bytepos, count_markers): New decls,
5860 so that gcc does not warn that these functions aren't declared.
5861
85876d07
PE
5862 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5863 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5864 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5865 (copy_text): Remove unused local var.
85876d07 5866
03d78a21 5867 * filelock.c (within_one_second): Now static.
b3dd38ab 5868 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5869
5df8f01b
PE
5870 * buffer.c (fix_overlays_before): Mark locals as initialized.
5871 (fix_start_end_in_overlays): Likewise. This function should be
5872 simplified by using pointers-to-pointers, but that's a different
5873 matter.
b1d876f1 5874 (switch_to_buffer_1): Now static.
8f54f30a
PE
5875 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5876 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5877
a70072c9 5878 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5879 Fix pointer signedness issue.
edced198
PE
5880 (sys_subshell): Mark local as volatile if checking for lint,
5881 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5882 (MAXPATHLEN): Define only if needed.
a70072c9 5883
a0977c44
PE
5884 * process.c (serial_open, serial_configure): Move decls from here ...
5885 * systty.h: ... to here, so that they can be checked.
5886
a884fdcc
PE
5887 * fns.c (get_random, seed_random): Move extern decls from here ...
5888 * lisp.h: ... to here, so that they can be checked.
5889
604efe86 5890 * sysdep.c (reset_io): Now static.
b8950c94 5891 (wait_for_termination_signal): Remove; unused.
604efe86 5892
38fc62d9
PE
5893 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5894 (copy_keymap_item, append_key, push_text_char_description):
5895 Now static.
1004a21a 5896 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5897 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5898 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5899 (describe_map_tree):
5900 Rename locals to avoid shadowing.
38fc62d9 5901
2f2650da
PE
5902 * keyboard.c: Declare functions static if they are not used elsewhere.
5903 (echo_char, echo_dash, cmd_error, top_level_2):
5904 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5905 (read_char, kbd_buffer_get_event, make_lispy_position):
5906 (make_lispy_event, make_lispy_movement, apply_modifiers):
5907 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5908 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5909 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5910 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5911 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5912
a053e86c 5913 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5914 (mark_kboards): Move decl here ...
5915 * alloc.c (mark_kboards): ... from here.
a053e86c 5916
4752793e
PE
5917 * lisp.h (force_auto_save_soon): New decl.
5918
74f10ca7 5919 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5920 (DEFINE_DUMMY_FUNCTION): New macro.
5921 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5922 Use it.
c03cd23f
PE
5923 (main): Add casts to avoid warnings
5924 if GCC considers string literals to be constants.
74f10ca7 5925
022e70d4
PE
5926 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5927
59d6fe83
PE
5928 * dbusbind.c: Pointer signedness fixes.
5929 (xd_signature, xd_append_arg, xd_initialize):
5930 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5931 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5932 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5933 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5934
78320123
PE
5935 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5936 if GCC considers string literals to be constants.
49cebcca 5937 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5938
35ac2a97
SM
59392011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5940
fb103ca9
SM
5941 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5942 (print_preprocess, print_object): New macro to fix last change.
5943
35ac2a97
SM
5944 * print.c (print_preprocess): Don't forget font objects.
5945
62973b41
JB
59462011-03-16 Juanma Barranquero <lekktu@gmail.com>
5947
5948 * emacs.c (USAGE3): Doc fixes.
5949
0e48bb22
AS
59502011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5951
5952 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5953 structure.
5954
7684e57b
JB
59552011-03-14 Juanma Barranquero <lekktu@gmail.com>
5956
5957 * lisp.h (VWindow_system, Qfile_name_history):
5958 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5959 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5960 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5961
5962 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5963 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5964
5965 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5966 * w32console.c (detect_input_pending, read_input_pending)
5967 (encode_terminal_code):
5968 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5969 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5970 (w32_system_caret_y, Qfile_name_history):
5971 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5972 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5973 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5974 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5975 * w32proc.c (Qlocal, report_file_error):
5976 * w32term.c (Vwindow_system, updating_frame):
5977 * w32uniscribe.c (initialized, uniscribe_font_driver):
5978 Remove unneeded extern declarations.
5979
2aa46d6c
CY
59802011-03-14 Chong Yidong <cyd@stupidchicken.com>
5981
c96bbc66 5982 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5983
cffc6f3b
CY
59842011-03-13 Chong Yidong <cyd@stupidchicken.com>
5985
5986 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5987 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5988 These macros can no longer be used for assignment.
5989
44f230aa
SM
5990 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5991 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5992 (record_buffer_markers, fetch_buffer_markers): New functions for
5993 recording and fetching special buffer markers.
5994 (set_buffer_internal_1, set_buffer_temp): Use them.
5995
5996 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5997
5998 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5999
6000 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6001 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6002
6003 * xdisp.c (hscroll_window_tree):
6004 (reconsider_clip_changes): Use PT instead of BUF_PT.
6005
d251f04b
EZ
60062011-03-13 Eli Zaretskii <eliz@gnu.org>
6007
6008 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6009 $(EMACS_ROOT)/lib/intprops.h.
6010
f0c77cd1
PE
60112011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6012
3eca4629
PE
6013 Fix more problems found by GCC 4.5.2's static checks.
6014
7c86ee98
PE
6015 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6016 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6017 (xg_free_frame_widgets): Make it clear that a local variable is
6018 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6019 (gdk_window_get_screen): Make it clear that this macro is needed
6020 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6021 (int_gtk_range_get_value): New function, which avoids a diagnostic
6022 from gcc -Wbad-function-cast.
6023 (xg_set_toolkit_scroll_bar_thumb): Use it.
6024 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6025 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6026 (get_utf8_string, xg_get_file_with_chooser):
6027 Rename locals to avoid shadowing.
6028 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6029
41729b81
PE
6030 * xgselect.c (xg_select): Remove unused var.
6031
f0c77cd1
PE
6032 * image.c (four_corners_best): Mark locals as initialized.
6033 (gif_load): Initialize transparent_p to zero (Bug#8238).
6034 Mark another local as initialized.
ec6cf4c6 6035 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6036
ce0ad53d 6037 * image.c (clear_image_cache): Now static.
d5d5a617 6038 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6039 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6040 (x_edge_detection): Remove unnecessary cast that
6041 gcc -Wbad-function-cast diagnoses.
2037898d 6042 (gif_load): Fix pointer signedness.
6ae141d6
PE
6043 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6044 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6045
33383987 60462011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6047
d32df629
PE
6048 Improve quality of tests for time stamp overflow.
6049 For example, without this patch (encode-time 0 0 0 1 1
6050 1152921504606846976) returns the obviously-bogus value (-948597
6051 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6052 reports time overflow. See
6053 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6054 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6055 * editfns.c: Include limits.h and intprops.h.
6056 (TIME_T_MIN, TIME_T_MAX): New macros.
6057 (time_overflow): Move earlier, to before first use.
6058 (hi_time, lo_time): New functions, for an accurate test for
6059 out-of-range times.
6060 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6061 (Fget_internal_run_time): Don't assume time_t fits in int.
6062 (make_time): Use list2 instead of Fcons twice.
6063 (Fdecode_time): More accurate test for out-of-range times.
6064 (check_tm_member): New function.
6065 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6066 (lisp_time_argument): Don't rely on undefined left-shift and
6067 right-shift behavior when checking for time stamp overflow.
8be6f318 6068
fe31d94c
PE
6069 * editfns.c (time_overflow): New function, refactoring common code.
6070 (Fformat_time_string, Fdecode_time, Fencode_time):
6071 (Fcurrent_time_string): Use it.
6072
8be6f318
PE
6073 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6074 * dired.c (make_time): Move to ...
6075 * editfns.c (make_time): ... here.
6076 * systime.h: Note the move.
6077
09d9db2c 60782011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6079
126bc0dc
YM
6080 * fringe.c (update_window_fringes): Remove unused variables.
6081
c47cbdfd
YM
6082 * unexmacosx.c (copy_data_segment): Also copy __got section.
6083 (Bug#8223)
6084
7ac80be9
EZ
60852011-03-12 Eli Zaretskii <eliz@gnu.org>
6086
c96bbc66 6087 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6088 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6089 Constify `char *' arguments and their references according to
6090 prototypes in tparam.h.
6091
ecb0f94d 6092 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6093
7ac80be9
EZ
6094 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6095 Adapt all references accordingly.
6096
6097 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6098
ef1fd07e
TT
60992011-03-11 Tom Tromey <tromey@redhat.com>
6100
6101 * buffer.c (syms_of_buffer): Remove obsolete comment.
6102
7ef4b50c
EZ
61032011-03-11 Eli Zaretskii <eliz@gnu.org>
6104
6105 * termhooks.h (encode_terminal_code): Declare prototype.
6106
6107 * msdos.c (encode_terminal_code): Don't declare prototype.
6108
6109 * term.c (encode_terminal_code): Now external again, used by
6110 w32console.c and msdos.c.
6111
44f230aa
SM
6112 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6113 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6114
4b1ec863 61152011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6116
1714f52b 6117 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6118
4b1ec863
PE
6119 * fringe.c (update_window_fringes): Mark locals as initialized
6120 (Bug#8227).
6121 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6122
524c7aa6
PE
6123 * alloc.c (mark_fringe_data): Move decl from here ...
6124 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6125 to check its interface.
6126 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6127
a5c0af81 6128 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6129 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6130 (fontset_font): Mark local as initialized.
a9a06e0b 6131 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6132
b4716021
PE
6133 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6134
811e9bac 6135 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6136 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6137 (x_own_selection, Fx_disown_selection_internal): Rename locals
6138 to avoid shadowing.
6139 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6140
7e3ab302
PE
6141 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6142 so that the caller can use some name other than gcpro1.
6143 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6144 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6145 (Fx_backspace_delete_keys_p):
6146 Use them to avoid shadowing, and rename vars to avoid shadowing.
6147 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6148 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6149 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6150 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6151 Remove unused locals.
7e3ab302
PE
6152 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6153 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6154 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6155 macros.
f78faa98 6156
e2b13473
PE
6157 * xterm.h (x_mouse_leave): New decl.
6158
77f23912
PE
6159 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6160 Remove unused functions.
cdf4ba58
PE
6161 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6162 (x_calc_absolute_position): Now static.
7411c686 6163 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6164 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6165 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6166 unless they are used.
38d0b34a
PE
6167 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6168 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6169 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6170 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6171 (x_error_catcher, x_connection_closed, x_error_handler):
6172 (x_error_quitter, xembed_send_message, x_iconify_frame):
6173 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6174 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6175 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6176
44f230aa
SM
6177 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6178 Rename or move locals to avoid shadowing.
6b463e58 6179 (tty_defined_color, merge_face_heights): Now static.
5967d051 6180 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6181 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6182 does not deduce is never used uninitialized.
73719eba
PE
6183 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6184 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6185
426994c3 6186 * terminal.c (store_terminal_param): Now static.
5489860b 6187
032f1620 6188 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6189 (set_frame_menubar): Remove unused local.
d4323972 6190 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6191 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6192 since they might point to immutable storage.
281585b0
PE
6193 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6194 since it's unused otherwise.
032f1620 6195
367c19e5 6196 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6197 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6198 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6199 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6200 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6201 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6202 does not deduce are never used uninitialized.
70739cbe 6203
07b48fa9
PE
6204 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6205
8868a238 6206 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6207 * window.c (window_loop, size_window):
6208 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6209
7e5cf297 6210 * window.c (display_buffer): Now static.
d6550a9f
PE
6211 (size_window): Mark variables that gcc -Wuninitialized
6212 does not deduce are never used uninitialized.
a586633d
PE
6213 * window.h (check_all_windows): New decl, to forestall
6214 gcc -Wmissing-prototypes diagnostic.
5b555da1 6215 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6216
f6095868
PE
6217 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6218 shadowing.
6219 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6220 Include <limits.h>.
6221 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6222 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6223 (load_charset_map): Mark variables that gcc -Wuninitialized
6224 does not deduce are never used uninitialized.
53df7c11 6225 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6226
f38b440c
PE
6227 * coding.c (coding_set_source, coding_set_destination):
6228 Use "else { /* comment */ }" rather than "else /* comment */;"
6229 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6230 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6231 a block, when the outer 'i' will do.
6232 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6233 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6234 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6235 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6236 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6237 Rename locals to avoid shadowing.
6238 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6239 * coding.c (emacs_mule_char, encode_invocation_designation):
6240 Now static, since they're not used elsewhere.
413bb2db 6241 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6242 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6243 (decode_coding_emacs_mule): Mark variables that gcc
6244 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6245 (detect_coding_iso_2022): Initialize a local variable that might
6246 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6247 this initialization is needed. (Bug#8211)
5f58e762
PE
6248 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6249 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6250 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6251 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6252 Remove unused macros.
f38b440c 6253
232b38b9 6254 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6255 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6256 * character.c (string_count_byte8): Likewise.
232b38b9 6257
fb90da1b
PE
6258 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6259 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6260
fb93dbc2
PE
6261 * chartab.c (copy_sub_char_table): Now static, since it's not used
6262 elsewhere.
5c156ace
PE
6263 (sub_char_table_ref_and_range, char_table_ref_and_range):
6264 Rename locals to avoid shadowing.
bbcd0949 6265 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6266
7d3b3862 6267 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6268 (BIDI_BOB): Remove unused macro.
7d3b3862 6269
6be7d3da
PE
6270 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6271 deduce are never used uninitialized.
c2ed9c8b 6272 * term.c (encode_terminal_code): Likewise.
6be7d3da 6273
75f8807f 6274 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6275
50938595
PE
6276 * tparam.h: New file.
6277 * term.c, tparam.h: Include it.
6278 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6279 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6280 Move these decls to tparam.h, and make them agree with what
6281 is actually in tparam.c. The previous trick of using incompatible
6282 decls in different modules does not conform to the C standard.
6283 All callers of tparam changed to use tparam's actual API.
6284 * tparam.c (tparam1, tparam, tgoto):
6285 Use const pointers where appropriate.
6286
fbceeba2
PE
6287 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6288 * cm.h (struct cm): Likewise.
6289 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6290 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6291 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6292 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6293 (turn_on_face, init_tty): Likewise.
6294 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6295
7f3f1250
PE
6296 * term.c (term_mouse_position): Rename local to avoid shadowing.
6297
e6ca6543
PE
6298 * alloc.c (mark_ttys): Move decl from here ...
6299 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6300
c40f8d15
AS
63012011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6302
6303 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6304
cfe0661d
JB
63052011-03-09 Juanma Barranquero <lekktu@gmail.com>
6306
6307 * search.c (compile_pattern_1): Remove argument regp, unused since
6308 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6309 (compile_pattern): Don't pass it.
6310
0afb4571
J
63112011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6312
6313 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6314 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6315 for ! HAVE_GTK3.
6316 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6317
6318 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6319
6320 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6321 gdk_window_get_screen, gdk_window_get_geometry,
6322 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6323 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6324 (xg_get_pixbuf_from_pixmap): New function.
6325 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6326 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6327 Call xg_get_pixbuf_from_pixmap instead of
6328 gdk_pixbuf_get_from_drawable.
6329 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6330 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6331 (xg_check_special_colors): Use GtkStyleContext and its functions
6332 for HAVE_GTK3.
6333 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6334 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6335 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6336 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6337 Call gtk_widget_get_preferred_size.
0afb4571
J
6338 (xg_frame_resized): gdk_window_get_geometry only takes 5
6339 parameters.
44f230aa
SM
6340 (xg_win_to_widget, xg_event_is_for_menubar):
6341 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6342 (xg_set_widget_bg): New function.
6343 (delete_cb): New function.
895009e1 6344 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6345 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6346 (xg_set_background_color): Call xg_set_widget_bg.
6347 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6348 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6349 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6350 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6351 if ! HAVE_GTK3.
6352 (update_frame_tool_bar): Call gtk_widget_hide.
6353 (xg_initialize): Use GDK_KEY_g.
6354
6355 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6356 if ! HAVE_GTK3
6357 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6358
6359 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6360 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6361 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6362
1c2cc4ef
JB
63632011-03-08 Juanma Barranquero <lekktu@gmail.com>
6364
6365 * w32xfns.c (select_palette): Check success of RealizePalette against
6366 GDI_ERROR, not zero.
6367
33383987 6368See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6369
6370;; Local Variables:
6371;; coding: utf-8
aac0c6e3
MR
6372;; End:
6373
33383987 6374 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6375
6376 This file is part of GNU Emacs.
6377
6378 GNU Emacs is free software: you can redistribute it and/or modify
6379 it under the terms of the GNU General Public License as published by
6380 the Free Software Foundation, either version 3 of the License, or
6381 (at your option) any later version.
6382
6383 GNU Emacs is distributed in the hope that it will be useful,
6384 but WITHOUT ANY WARRANTY; without even the implied warranty of
6385 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6386 GNU General Public License for more details.
6387
6388 You should have received a copy of the GNU General Public License
6389 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.