gnus-art.el (gnus-kill-sticky-article-buffers): Reintroduce
[bpt/emacs.git] / src / ChangeLog
CommitLineData
57ec3034
JD
12012-07-25 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsterm.m (ns_read_socket): Return early if there is a modal
4 window (Bug#12043).
5
8137e7b3
MR
62012-07-25 Martin Rudalics <rudalics@gmx.at>
7
8 * frame.c (Fredirect_frame_focus): In doc-string don't mention
9 that FOCUS-FRAME can be omitted.
10
04e9897c
DA
112012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
12
13 Adjust buffer text indirection counters at the end of Fkill_buffer.
14 * buffer.c (Fkill_buffer): Adjust indirection counters when the
15 buffer is definitely dead. This should really fix an issue reported
16 by Christoph Scholtes again. (Bug#12007).
17 (init_buffer_once): Initialize indirection counters of
18 buffer_defaults and buffer_local_symbols (for sanity and safety).
19
8a0484e1
EZ
202012-07-24 Eli Zaretskii <eliz@gnu.org>
21
22 * xdisp.c (init_iterator): Don't compute dimensions of truncation
23 and continuation glyphs on tooltip frames, leave them at zero.
24 Avoids continued lines in tooltips. (Bug#11832)
25
fa691a83
DA
262012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
27
28 Simplify copy_overlay.
04e9897c 29 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
30 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
31
436bc8e0
EZ
322012-07-23 Eli Zaretskii <eliz@gnu.org>
33
34 * print.c (print_object): Don't crash when a frame's name is nil
35 or invalid. (Bug#12025)
36
37 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
38 it signals an error when a tooltip frame is being created.
39
d7a7fda3
DA
402012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
41
42 Cleanup miscellaneous objects allocation and initialization.
43 * alloc.c (allocate_misc): Change to static. Add argument to
44 specify the subtype. Adjust comment and users.
45 (build_overlay): New function.
46 * buffer.c (copy_overlays, Fmake_overlay): Use it.
47 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
48 (allocate_misc): Remove prototype.
49 (build_overlay): Add prototype.
50
512012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
52
53 Swap buffer text indirection counters in Fbuffer_swap_text.
54 * buffer.c (Fbuffer_swap_text): Swap indirections too.
55 This avoids crash reported by Christoph Scholtes at
56 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
57
9d7fa573
JD
582012-07-22 Jan Djärv <jan.h.d@swipnet.se>
59
60 * nsmenu.m (Popdown_data): New struct.
61 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
62 free Popdown_data.
63 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
64 (initWithContentRect): Make imgView and contentView non-static
65 and autorelease them. Also autorelease img and matrix (Bug#12005).
66 (dealloc): Remove (Bug#12005).
67
0dd6d66d
DA
682012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
69
70 Adjust consing_since_gc when objects are explicitly freed.
71 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
72 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
73 (free_cons, free_misc): Subtract object size from consing_since_gc.
74
d36d71df
DA
752012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
76
77 Simplify and cleanup markers positioning code.
78 * marker.c (attach_marker): More useful eassert.
79 (live_buffer, set_marker_internal): New function.
80 (Fset_marker, set_marker_restricted): Use set_marker_internal.
81 (set_marker_both, set_marker_restricted_both): Use live_buffer.
82
fb9ea40f
PE
832012-07-22 Paul Eggert <eggert@cs.ucla.edu>
84
85 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
86 as it's limited by the amount of memory, not by INT_MAX.
87
2d5c5f7d
EZ
882012-07-21 Eli Zaretskii <eliz@gnu.org>
89
07fb592e
EZ
90 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
91 in special-event-map. See the discussion at
92 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
93 for the reasons.
94
37a9eac8 95 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
96 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
97 Fabrice Popineau <fabrice.popineau@supelec.fr>.
98
c4328746
JD
992012-07-21 Jan Djärv <jan.h.d@swipnet.se>
100
101 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 102 (conversationIdentifier): Return value is NSInteger.
784051c4 103 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 104
6e5d1c12
CY
1052012-07-21 Chong Yidong <cyd@gnu.org>
106
107 * window.c (decode_any_window): Signal an error if the window is
108 on a dead frame (Bug#11984).
109
9928463d
DA
1102012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
111
112 Add indirection counting to speed up Fkill_buffer.
113 * buffer.h (struct buffer): New member.
114 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
115 (Fmake_indirect_buffer): Set indirection counter to -1, increment
116 base buffer indirection counter.
117 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
118 (Fkill_buffer): Adjust indirection counters as needed, don't walk
119 through buffer list if indirection counter is 0.
120
f8643a6b
DA
1212012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
122
123 Extend the value returned by Fgarbage_collect with heap statistics.
124 * alloc.c (Qheap): New symbol.
125 (syms_of_alloc): DEFSYM it.
126 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
127 (Fmemory_free): Remove.
128 (syms_of_alloc): Don't defsubr it.
129 * buffer.c (Fcompact_buffer): Remove.
130 (syms_of_buffer): Don't defsubr it.
131
dac616ff
DA
1322012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
133
134 Make maybe_gc inline.
135 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
136 * lisp.h (consing_since_gc, gc_relative_threshold)
137 (memory_full_cons_threshold): Revert declaration.
138 (maybe_gc): Remove prototype, define as inline.
139 * alloc.c: Remove old commented-out code.
140 (consing_since_gc, gc_relative_threshold)
141 (memory_full_cons_threshold): Revert to global.
142 (maybe_gc): Remove.
143
d7ea76b4
DA
1442012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
145
146 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
147 * lisp.h (build_unibyte_string): New function.
148 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
149 * sysdep.c, w32fns.c, xfns.c: Use it.
150 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
151 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
152 Adjust users accordingly.
153 * font.h (font_open_by_name): Adjust prototype.
154
765e61e3
DA
1552012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
156
157 Cleanup calls to Fgarbage_collect.
158 * lisp.h (maybe_gc): New prototype.
159 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
160 Remove declarations.
161 * alloc.c (maybe_gc): New function.
162 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
163 Make them static.
164 * bytecode.c (MAYBE_GC): Use maybe_gc.
165 * eval.c (eval_sub, Ffuncall): Likewise.
166 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
167 to avoid dependency from auto-save feature.
168
52b852c7
PE
1692012-07-19 Paul Eggert <eggert@cs.ucla.edu>
170
171 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
172 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
173 'for_each_per_buffer_object_at'.
174 All uses changed. It's better to use upper-case for macros that
175 cannot be implemented as functions, to give the reader a clue
176 that they're special.
177
5db81e33
SM
1782012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
179
180 * alloc.c (Fgarbage_collect): Tweak docstring.
181
5b835e1d
DA
1822012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
183
184 Tweak the value returned from Fgarbage_collect again.
185 * alloc.c (Fgarbage_collect): New return value, as confirmed in
186 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
187 Adjust documentation.
188 (total_vector_bytes): Rename to total_vector_slots, adjust
189 accounting.
190 (total_free_vector_bytes): Rename to total_free_vector_slots,
191 adjust accounting.
192 (Qstring_bytes, Qvector_slots): New symbols.
193 (syms_of_alloc): DEFSYM them.
194
9cd47b72
DA
1952012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
196
197 Buffer compaction primitive which may be used from Lisp.
198 * buffer.c (compact_buffer, Fcompact_buffer): New function.
199 (syms_of_buffer): Register Fcompact_buffer.
200 * alloc.c (Fgarbage_collect): Use compact_buffer.
201 * buffer.h (compact_buffer): New prototype.
202 (struct buffer_text): New member.
203
d17337e5
DA
2042012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
205
206 New macro to iterate over all buffers, miscellaneous cleanups.
207 * lisp.h (all_buffers): Remove declaration.
208 * buffer.h (all_buffers): Add declaration, with comment.
209 (for_each_buffer): New macro.
210 * alloc.c (Fgarbage_collect, mark_object): Use it.
211 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
212 (init_buffer): Likewise.
213 * data.c (Fset_default): Likewise.
214 * coding.c (code_conversion_restore): Remove redundant check
215 for dead buffer.
216 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
217
60cfd278
AS
2182012-07-18 Andreas Schwab <schwab@linux-m68k.org>
219
220 Fix bug that created negative-length intervals.
221 * intervals.c (merge_interval_right, merge_interval_left):
222 Do not zero out this interval if it is absorbed by its children,
223 as this interval's total length doesn't change in that case. See
224 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
225
d06714cb
PE
2262012-07-18 Paul Eggert <eggert@cs.ucla.edu>
227
83713154
PE
228 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
229 when invoking (make-bool-vector N t) and N is a positive
230 multiple of 8 -- the last 8 bits were mistakenly cleared.
231
d06714cb
PE
232 Remove some struct layout assumptions in bool vectors.
233 * alloc.c (bool_header_size): New constant.
234 (header_size, word_size): Move earlier, as they're now used earlier.
235 Use 'word_size' in a few more places, where it's appropriate.
236 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
237 padding before the data member of a bool vector.
238 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
239 than doing the check by hand with an abort ().
240
464d5a5e
SM
2412012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
242
5fbc0409
SM
243 * eval.c (Fdefvar): Don't check constants since we only set the var if
244 it's not yet defined anyway (bug#11904).
245
464d5a5e
SM
246 * lisp.h (last_undo_boundary): Declare new var.
247 * keyboard.c (command_loop_1): Set it.
248 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
249 were auto-added by the command loop (bug#11774).
250
8dc2e44a
AS
2512012-07-18 Andreas Schwab <schwab@linux-m68k.org>
252
253 * w32font.c (Qsymbol): Remove local definition.
254 (syms_of_w32font): Don't DEFSYM it.
255
169925ec
DA
2562012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
257
258 Fix sweep_vectors to handle large bool vectors correctly.
259 * alloc.c (sweep_vectors): Account total_vector_bytes for
260 bool vectors larger than VBLOCK_BYTES_MAX.
261
5fbfb018
CY
2622012-07-18 Chong Yidong <cyd@gnu.org>
263
264 * frame.c (x_set_frame_parameters): Revert bogus change introduced
265 in 2012-05-25 commit by Paul Eggert (Bug#11738).
266
3ab6e069
DA
2672012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
268
269 Return more descriptive data from Fgarbage_collect.
270 Suggested by Stefan Monnier in
271 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
272 * alloc.c (bounded_number): New function.
273 (total_buffers, total_vectors): New variable.
274 (total_string_size): Rename to total_string_bytes, adjust users.
275 (total_vector_size): Rename to total_vector_bytes, adjust users.
276 (sweep_vectors): Account total_vectors and total_vector_bytes.
277 (Fgarbage_collect): New return value. Adjust documentation.
278 (gc_sweep): Account total_buffers.
279 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
280 (VECTOR_SIZE): Remove.
281 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
282 (Qinterval, Qmisc): New symbols.
283 (syms_of_data): Initialize them.
284 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
285 (Qcons, Qbuffer): New declarations.
286
6d02fe5b
PE
2872012-07-17 Paul Eggert <eggert@cs.ucla.edu>
288
289 * alloc.c (Fmemory_free): Account for memory-free's own storage.
290 Round up, not down. Improve doc.
291
b7ffe040
DA
2922012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
293
294 Restore old code in allocate_string_data to avoid Faset breakage.
295 Reported by Julien Danjou <julien@danjou.info> in
296 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
297 * alloc.c (allocate_string_data): Restore old code with minor
298 adjustments, fix comment to explain this subtle issue.
299
4dc7c8d5
SM
3002012-07-17 Eli Zaretskii <eliz@gnu.org>
301
302 Remove FILE_SYSTEM_CASE.
303 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
304
305 * fileio.c (FILE_SYSTEM_CASE): Don't define.
306 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
307 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
308 call-process-region passes it through expand-file-name.
309
310 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
311
3122012-07-17 Andreas Schwab <schwab@linux-m68k.org>
313
314 Fix crash when creating indirect buffer (Bug#11917)
315 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
316 Don't handle unbound variables specially if non-zero.
317 (Fbuffer_local_variables): Pass zero.
318 (clone_per_buffer_values): Pass non-zero.
319
3202012-07-17 Andreas Schwab <schwab@linux-m68k.org>
321
322 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
323 to make the loop interruptible.
324
3252012-07-17 Andreas Schwab <schwab@linux-m68k.org>
326
327 * gnutls.c (emacs_gnutls_handshake): Only retry if
328 GNUTLS_E_INTERRUPTED.
329
cce7fefc
DA
3302012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
331
332 Cleanup and convert miscellaneous checks to eassert.
333 * alloc.c (mark_interval): Fix comment, partially rephrase
334 old comment from intervals.h (see below).
335 * intervals.c (find_interval, adjust_intervals_for_insertion)
336 (delete_interval, adjust_intervals_for_deletion)
337 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
338 Convert to eassert.
339 (adjust_intervals_for_insertion, make_new_interval):
340 Remove obsolete and unused code.
341 * intervals.h (struct interval): Remove obsolete comment.
342 * textprotp.c (erase_properties): Remove unused code.
343 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
344 (Fremove_list_of_text_properties): Convert to eassert.
345
9ea10cc3
CY
3462012-07-17 Chong Yidong <cyd@gnu.org>
347
348 * editfns.c (Finsert_char): Doc fix.
349
3900d5de
DA
3502012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
351
352 Fix previous change to make Fmemory_free always accurate.
353 * alloc.c (make_interval): Update total_free_intervals.
354 (make_float): Likewise for total_free_floats.
355 (free_cons, Fcons): Likewise for total_free_conses.
356 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
357 Likewise for total_free_vector_bytes.
358 (Fmake_symbol): Likewise for total_free_symbols.
359 (bytes_free): Remove.
360
7098646f
DA
3612012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
362
363 Simple free memory accounting feature.
364 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
365 (sweep_vectors): Accumulate size of free vectors.
366 (Fgarbage_collect): Setup bytes_free.
367 (Fmemory_free): New function.
368 (syms_of_alloc): Register it.
369
22657b40
DA
3702012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
371
372 Cleanup overlays checking.
373 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
374 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
375 eassert and OVERLAYP.
376 (sort_overlays): Change to use OVERLAYP.
377
ddfc8813
RK
3782012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
379
380 * editfns.c (Finsert_char): Make it interactive, and make the
381 second arg optional. Copy interactive spec and docstring from
382 ucs-insert.
383
7c26cf3c
PE
3842012-07-17 Paul Eggert <eggert@cs.ucla.edu>
385
386 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
387 Unlike the other wrapped functions, fabs has an unspecified
388 effect on errno.
389
5d127af9
JD
3902012-07-16 Jan Djärv <jan.h.d@swipnet.se>
391
392 * nsterm.m (keyDown): Interpret flags without left/right bits
393 as the left key (Bug#11670).
394
6a0dd1d7
DA
3952012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
396
397 Remove empty and useless init functions.
398 * lisp.h (init_character_once, init_fns, init_image)
399 (init_filelock, init_sound): Remove prototype.
400 * character.c (init_character_once): Remove.
401 * filelock.c (init_filelock): Likewise.
402 * fns.c (init_fns): Likewise.
403 * image.c (init_image): Likewise.
404 * sound.c (init_sound): Likewise.
405 * emacs.c (main): Adjust accordingly.
406
7a6136fd
DA
4072012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
408
409 * gtkutil.h: Tiny cleanups.
410 (use_old_gtk_file_dialog): Remove useless declaration.
411 (xg_uses_old_file_dialog): Add suggested const attribute.
412
ce811ad9
EZ
4132012-07-15 Eli Zaretskii <eliz@gnu.org>
414
415 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
416 (bidi_paragraph_init): Use it to limit search forward for a strong
417 directional character in abnormally large paragraphs full of
418 neutral or weak characters. (Bug#11943)
419
c9adfeaa
SF
4202012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
421
422 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
423 the toolbar (Bug#9451).
424 (xg_make_tool_item): Give the widget event box a transparent
425 background.
426
fff62aa9
DA
4272012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
428
429 Cleanup basic allocation variables and functions.
430 * alloc.c (ignore_warnings, init_intervals, init_float)
431 (init_cons, init_symbol, init_marker): Remove.
432 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
433 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
434 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
435 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
436 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
437 (staticidx, init_alloc_once, init_strings, free_ablock):
438 Remove redundant initialization.
439 * fns.c (init_weak_hash_tables): Remove.
440 * lisp.h (init_weak_hash_tables): Remove prototype.
441
9730daca
DA
4422012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
443
444 Use zero_vector where appropriate.
445 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
446 accordingly.
447 * lisp.h (zero_vector): New declaration.
448 * font.c (null_vector): Remove.
449 (syms_of_font): Remove initialization and staticpro.
450 (font_list_entities, font_find_for_lface): Change to use zero_vector.
451 * keymap.c (Faccessible_keymaps): Likewise.
452
2e2d2a13
LL
4532012-07-15 Leo Liu <sdl.web@gmail.com>
454
455 * fringe.c: Fix typo in comments.
456
cd276f6e
LL
4572012-07-14 Leo Liu <sdl.web@gmail.com>
458
459 * fringe.c: Add a new bitmap exclamation-mark.
460
5a1131d9
EZ
4612012-07-14 Eli Zaretskii <eliz@gnu.org>
462
463 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
464
465 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
466 (HAVE_MENUS): Don't define, defined by editing config.in with
467 msdos/sed2v2.inp.
468 (GMALLOC_INHIBIT_VALLOC): Don't define.
469 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
470
22e983b7
JB
4712012-07-14 Juanma Barranquero <lekktu@gmail.com>
472
473 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
474
5b3f250f
GM
4752012-07-14 Glenn Morris <rgm@gnu.org>
476
477 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
478 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
479 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
480
33d63ff4
GM
4812012-07-13 Glenn Morris <rgm@gnu.org>
482
5b633342
GM
483 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
484
33d63ff4
GM
485 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
486 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
487
b55b9f85
JD
4882012-07-13 Jan Djärv <jan.h.d@swipnet.se>
489
0dc8cf50
JD
490 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
491 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
492 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
493 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
494 where appropriate.
495 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
496 as boolean expression.
497 (x_set_window_size): Remove unused variable toolbar.
498 (ns_get_color_default, ns_mod_to_lisp): Remove.
499 (ns_mouse_position): Remove unused variables xchar and ychar.
500 (ns_compute_glyph_string_overhangs): Remove unused variable face.
501 (ns_set_vertical_scroll_bar): Remove unused variable count.
502 (ns_delete_terminal): Remove unused variable i.
503 (ns_term_init): Remove unused variables r, g and b.
504 (mouseDown): Remove unused variable window.
505 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
506 (initFrameFromEmacs): Remove unused variable vbextra.
507 (mouseEntered): Remove unused variables p and dpyinfo.
508 (mouseExited): Remove unused variables p and r.
509 (ns_define_frame_cursor, ns_clear_frame_area)
510 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
511 (menuDown): Assign [sender tag] to variable and cast the variable.
512
513 * nsterm.h (menuDown): Add id as type to argument sender.
514 (ns_display_info_for_name): Add Lisp_Object argument.
515 (ns_term_init): Add Lisp_Object argument.
516 (ns_map_event_to_object): Add void argument.
517 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
518 prototype with arguments and only declare if __OBJC__.
519 (nxatoms_of_nsselect): Add void argument.
520 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
521 (ns_alloc_autorelease_pool): Add void argument.
522 (ns_release_autorelease_pool): Add void* argument.
523 (ns_get_defaults_value): Add const char* argument.
524
525 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
526 (initFromContents): Use SSDATA where appropriate.
527 (ns_update_menubar): Add braces to ambigous if-else.
528 (initWithTitle): Put () around assignment in if statement.
529 (ns_menu_show): Remove unused variables window and keymap.
530 (update_frame_tool_bar): Remove unused variable selected_p.
531 (initWithContentRect): Remove unused variable this_cmd_name.
532
533 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
534 appropriate.
535 (setXBMColor): Remove unused variable len.
536 (setPixmapData): Put () around assignment in loop statement.
537
538 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
539 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
540 where appropriate.
541 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
542 around assignment in loop statement.
543 (nsfont_open): Remove unused variable i.
544 (nsfont_open): Remove unused variable len.
545 (nsfont_draw): Remove unused variable cs.
546
547 * nsfns.m (x_set_icon_name, ns_set_name_internal)
548 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
549 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
550 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
551 (Fns_font_name, Fns_perform_service)
552 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
553 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
554 (ns_set_name): Remove unused variable view.
555 (x_set_menu_bar_lines): Remove unused variable olines.
556 (x_set_tool_bar_lines): Remove unused variable root_window.
557 (Fns_list_colors): Put () around assignment in while statement.
558 (Fns_perform_service): Remove unused variable len.
559 (Fns_display_usable_bounds): Remove unused variable top.
560 (syms_of_nsfns): Remove unused variable i.
561
b55b9f85
JD
562 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
563 memcpy (Bug#11907).
564
ed9265fc 5652012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
566
567 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
568 and free it with DestroyExceptionInfo (Bug#11558).
569
ef099b57
JB
5702012-07-13 Juanma Barranquero <lekktu@gmail.com>
571
572 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
573 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
574 Set here, not in nt/config.nt.
575
ea814a5d
EZ
5762012-07-13 Eli Zaretskii <eliz@gnu.org>
577
578 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
579 cursor overflow into the last glyph on display line when the right
580 fringe is off. (Bug#11832)
581
1a952767
PE
5822012-07-13 Paul Eggert <eggert@cs.ucla.edu>
583
584 * xdisp.c (produce_special_glyphs): Now static.
585 * dispextern.h (produce_special_glyphs): Remove decl.
586
983188fd
GM
5872012-07-13 Glenn Morris <rgm@gnu.org>
588
32fb4bb6
GM
589 * s/bsd-common, s/cygwin.h: Remove empty files.
590 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
591
983188fd
GM
592 * s/usg5-4-common.h (USG, USG5):
593 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
594 * s/sol2-6.h (SOLARIS2):
595 * s/irix6-5.h (IRIX6_5):
596 * s/hpux10-20.h (USG, USG5, HPUX):
597 * s/gnu-linux.h (USG, GNU_LINUX):
598 * s/freebsd.h (BSD_SYSTEM):
599 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
600 * s/cygwin.h (CYGWIN):
601 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
602 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
603
d1e68667 6042012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
605
606 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 607
6de0e799
GM
6082012-07-13 Glenn Morris <rgm@gnu.org>
609
739ae010
GM
610 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
611
dbee5793
GM
612 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
613
6de0e799
GM
614 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
615 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
616
b82da769
GM
6172012-07-12 Glenn Morris <rgm@gnu.org>
618
4fae5a7a 619 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
620
621 * process.c (init_process_emacs): Rename from init_process.
622 The old name is also the name of a Mach system call.
623 * lisp.h, emacs.c: Update for this name change.
624 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
625 longer needed.
626
5a979817
EZ
6272012-07-12 Eli Zaretskii <eliz@gnu.org>
628
629 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
630 memmove call that removes glyphs covered by the left truncation
631 glyph. Improve commentary.
632 (display_line): Fix display of continuation glyphs on GUI frames
633 when the right fringe is turned off and variable-size fonts are
634 used in the window. Move the code that appends a stretch glyph to
635 produce_special_glyphs, so that it could be used for truncation
636 and continuation glyphs alike.
637 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
638 glyph of a suitably computed width, to align the special glyphs at
639 the window margin. Code moved from display_line. (Bug#11832)
640
3e91a053
GM
6412012-07-12 Glenn Morris <rgm@gnu.org>
642
ba9e4b84
GM
643 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
644
645 * s/gnu-linux.h, s/hpux10-20.h:
646 Do not unconditionally define HAVE_XRMSETDATABASE.
647
3e91a053
GM
648 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
649
b300b1f4
PE
6502012-07-12 Paul Eggert <eggert@cs.ucla.edu>
651
652 Fix typos that broke OS X build.
653 Reported by Randal L. Schwartz in
654 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
655 * nsterm.m (ns_timeout): Add missing local decl.
656 (ns_get_color): snprintf -> sprintf, to fix typo.
657
6e777848
GM
6582012-07-12 Glenn Morris <rgm@gnu.org>
659
3f922c37
GM
660 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
661 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
662 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
663 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
664
0ab7b23a
GM
665 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
666 Move PTY_OPEN to configure.
667
6e777848
GM
668 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
669 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
670 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
671
4a7edc24
DA
6722012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
673
674 Use empty_unibyte_string where applicable.
675 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
676 * lread.c (read1): Likewise.
677 * xsettings.c (syms_of_xsettings): Likewise.
678
308aab79
GM
6792012-07-12 Glenn Morris <rgm@gnu.org>
680
42bd1719
GM
681 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
682 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
683 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
684 * s/hpux10-20.h (RUN_TIME_REMAP):
685 * s/bsd-common.h (TABDLY): Move to configure.
686
687 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
688
689 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
690
ea0bbd17 691 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 692 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
693
694 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 695
308aab79
GM
696 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
697 * s/template.h: Move NARROWPROTO to configure.
698
ee1cf5cf
GM
6992012-07-11 Glenn Morris <rgm@gnu.org>
700
30fe9bf4
GM
701 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
702 unused since 2011-01-17 change to systty.h.
703
ee1cf5cf
GM
704 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
705 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
706 Move HAVE_PTYS and HAVE_SOCKETS to configure.
707
63e47e07
PE
7082012-07-11 Paul Eggert <eggert@cs.ucla.edu>
709
710 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
711
c43fb4c3
GM
7122012-07-11 Glenn Morris <rgm@gnu.org>
713
714 * s/darwin.h, s/gnu-linux.h, s/template.h:
715 Move INTERRUPT_INPUT to configure.
716
e8df9267
DA
7172012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
718
719 Minor adjustments to interning code.
720 * lisp.h (intern, intern_c_string): Redefine as static inline
721 wrappers for intern_1 and intern_c_string_1, respectively.
722 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
723 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
724 Vobarray checking.
e8df9267
DA
725 * font.c (font_intern_prop): Likewise. Adjust comment.
726 * w32font.c (intern_font_name): Likewise.
727
34348bd4
AS
7282012-07-11 Andreas Schwab <schwab@linux-m68k.org>
729
d96a1e0c
AS
730 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
731
34348bd4
AS
732 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
733 of Fcar/Fcdr if possible.
734 * font.c (check_otf_features): Likewise.
735 * fontset.c (Fnew_fontset): Likewise.
736 * gnutls.c (Fgnutls_boot): Likewise.
737 * minibuf.c (read_minibuf): Likewise.
738 * msdos.c (IT_set_frame_parameters): Likewise.
739 * xmenu.c (Fx_popup_dialog): Likewise.
740 * w32menu.c (Fx_popup_dialog): Likewise.
741
c8add24e
GM
7422012-07-11 Glenn Morris <rgm@gnu.org>
743
4b575b3c
GM
744 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
745 since nothing has defined it on these platforms.
746
09f4e3b0
GM
747 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
748 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
749
172bedef
GM
750 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
751 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
752 Move CLASH_DETECTION to configure.
753
249685df
GM
754 * s/gnu.h: Remove file, which is now empty.
755
c8add24e
GM
756 * s/gnu.h, s/gnu-linux.h:
757 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
758
b41253a3
JW
7592012-07-11 John Wiegley <johnw@newartisans.com>
760
761 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
762 function attribute, so we only use it if it exists in the
763 compiler.
764
d923b542
DA
7652012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
766
767 Avoid call to strlen in fast_c_string_match_ignore_case.
768 * search.c (fast_c_string_match_ignore_case): Change to use
769 length argument. Adjust users accordingly.
770 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
771
5ebbef1d
PE
7722012-07-11 Paul Eggert <eggert@cs.ucla.edu>
773
bb352260
PE
774 Assume mkdir, rmdir.
775 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
776 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
777
57054ddd
PE
778 Assume rename.
779 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
780
b747d3f7
PE
781 Assume perror.
782 * s/hpux10-20.h (HAVE_PERROR): Remove.
783 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
784 Remove dummy definition, as this problem was obsolete long ago.
785
5ebbef1d
PE
786 Assume strerror.
787 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
788
984e7f30
DA
7892012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
790
791 Avoid calls to strlen in font processing functions.
792 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 793 (font_open_by_name): Change to use length argument. Adjust
984e7f30 794 users accordingly.
d923b542
DA
795 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
796 Adjust prototypes.
797 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
798 Change to return ptrdiff_t.
984e7f30
DA
799 (xfont_list_pattern, xfont_match): Use length returned by
800 xfont_decode_coding_xlfd.
801 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
802
20e94fdd
GM
8032012-07-11 Glenn Morris <rgm@gnu.org>
804
9d596af3
GM
805 * s/darwin.h, s/freebsd.h, s/netbsd.h:
806 Move DONT_REOPEN_PTY to configure.
807
20e94fdd
GM
808 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
809 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
810
e99a530f
PE
8112012-07-10 Paul Eggert <eggert@cs.ucla.edu>
812
22ffb973
PE
813 Remove "#define unix" that is no longer needed (Bug#11905).
814 * s/aix4-2.h (unix): Remove; no longer needed.
815
e9a9ae03
PE
816 EMACS_TIME simplification (Bug#11875).
817 This replaces macros (which typically do not work in GDB)
818 with functions, typedefs and enums, making the code easier to debug.
819 The functional style also makes code easier to read and maintain.
820 * systime.h: Include <sys/time.h> on all hosts, not just if
821 WINDOWSNT, since 'struct timeval' is needed in general.
822 (EMACS_TIME): Now a typedef, not a macro.
823 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
824 not macros.
825 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
826 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
827 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
828 (EMACS_TIME_LE): Now functions, not macros.
829 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
830 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
831 which are not functions. All uses rewritten to use:
832 (make_emacs_time): New function.
833 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
834 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
835 not functions. All uses rewritten to use the following, respectively:
836 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
837 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 838 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
839 * fileio.c (Fcopy_file):
840 * xterm.c (XTflash): Get the current time closer to when it's used.
841 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
842
ffacb126
PE
843 * bytecode.c (targets): Suppress -Woverride-init warnings.
844
e99a530f
PE
845 Simplify by avoiding confusing use of strncpy etc.
846 * doc.c (Fsnarf_documentation):
847 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
848 * frame.c (Fmake_terminal_frame):
849 * gtkutil.c (get_utf8_string):
850 * lread.c (openp):
851 * nsmenu.m (ns_update_menubar):
852 * regex.c (regerror):
853 Prefer memcpy to strncpy and strncat when either will do.
854 * fileio.c (Fsubstitute_in_file_name):
855 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
856 (menu_separator_name_p):
857 * nsmenu.m (ns_update_menubar):
858 Prefer memcmp to strncmp when either will do.
859 * nsterm.m: Include <ftoastr.h>.
860 (ns_get_color):
861 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
862 Prefer snprintf to strncpy.
863 * nsterm.m (ns_term_init):
864 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
865 * nsterm.m (ns_term_init):
866 Avoid the need for strncpy, by using build_string or
867 make_unibyte_string directly. Use dtoastr, not snprintf.
868 * process.c (Fmake_network_process): Diagnose service names that
869 are too long, rather than silently truncating them or creating
870 non-null-terminated names.
871 (Fnetwork_interface_info): Likewise, for interface names.
872 * sysdep.c (system_process_attributes) [GNU_LINUX]:
873 Prefer sprintf to strncat.
874 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
875 Prefer vsnprintf to vsprintf + strncpy.
876
c59592b3
GM
8772012-07-10 Glenn Morris <rgm@gnu.org>
878
879 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
880 Clarify fallback case.
881
7d7bbefd
DA
8822012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
883
884 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
885 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
886 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 887 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
888 where argument type is known to be a Lisp_Cons.
889
3a4c8000
TT
8902012-07-10 Tom Tromey <tromey@redhat.com>
891
892 * bytecode.c (BYTE_CODE_THREADED): New macro.
893 (BYTE_CODES): New macro. Replaces all old byte-code defines.
894 (enum byte_code_op): New type.
895 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
896 (exec_byte_code): Use them. Use token threading when applicable.
897
2a0213a6
DA
8982012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
899
900 Optimize pure C strings initialization.
901 * lisp.h (make_pure_string): Fix prototype.
902 (build_pure_c_string): New function, defined as static inline. This
903 provides a better opportunity to optimize away calls to strlen when
904 the function is called with compile-time constant argument.
905 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
906 argument, adjust users accordingly. Use build_pure_c_string where
907 appropriate.
908 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
909 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
910 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
911
cb1caeaf
DA
9122012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
913
914 Avoid calls to strlen in miscellaneous functions.
915 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
916 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
917 * lread.c (openp): Likewise.
918
c293e30c
DA
9192012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
920
921 Avoid calls to strlen in path processing functions.
922 * fileio.c (file_name_as_directory): Add comment. Change to add
923 srclen argument and return the length of result. Adjust users
924 accordingly.
925 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 926 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
927 users accordingly.
928 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
929
9e059e3f
GM
9302012-07-10 Glenn Morris <rgm@gnu.org>
931
d02eb359
GM
932 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
933 Move PENDING_OUTPUT_COUNT definition to configure.
934
882cf227
GM
935 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
936 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
937 * s/gnu.h (DATA_START): Move definitions to configure.
938
af6e839f
GM
939 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
940 We include usg5-4-common.h, which defines them both.
941
40289a12
GM
942 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
943 O_RDONLY already includes it).
944
9e059e3f
GM
945 Stop ns builds setting the EMACSLOADPATH environment variable.
946 * nsterm.m (ns_load_path): Rename from ns_init_paths.
947 Now it does not set EMACSLOADPATH, just returns the load-path string.
948 * nsterm.h: Update accordingly.
949 * lread.c [HAVE_NS]: Include nsterm.h.
950 (init_lread) [HAVE_NS]: Use ns_load_path.
951 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
952
7c4e8ec0
GM
9532012-07-09 Glenn Morris <rgm@gnu.org>
954
d4f600ff
GM
955 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
956 since the included bsd-common.h does so.
957
cbb31951
GM
958 Stop ns builds setting the EMACSPATH environment variable.
959 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
960 (ns_init_paths): Do not set EMACSPATH.
961 * nsterm.h (ns_exec_path): Add it.
962 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
963 Use ns_exec_path.
964
7c4e8ec0
GM
965 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
966
26bccfae
PE
9672012-07-09 Paul Eggert <eggert@cs.ucla.edu>
968
a0bee46f
PE
969 * process.c (wait_reading_process_output): 'waitchannels' was unset
970 when read_kbd || !NILP (wait_for_cell); fix this.
971
5994c183
PE
972 Add GCC-style 'const' attribute to functions that can use it.
973 * character.h (char_resolve_modifier_mask):
974 * keyboard.h (make_ctrl_char):
975 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
976 (init_character_once, next_almost_prime, init_fns, init_image)
977 (flush_pending_output, init_sound):
978 * mem-limits.h (start_of_data):
979 * menu.h (finish_menu_items):
980 Add ATTRIBUTE_CONST.
981 * emacs.c (DEFINE_DUMMY_FUNCTION):
982 Declare the dummy function with ATTRIBUTE_CONST.
983 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
984 Add decls with ATTRIBUTE_CONST.
985
26bccfae
PE
986 Minor improvements to make_formatted_string.
987 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
988 where int is good enough, as vsprintf returns an int.
989 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
990
a8290ec3
DA
9912012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
992
993 Use make_formatted_string to avoid double length calculation.
994 * lisp.h (make_formatted_string): New prototype.
995 * alloc.c (make_formatted_string): New function.
996 * buffer.c (Fgenerate_new_buffer_name): Use it.
997 * dbus.c (syms_of_dbusbind): Likewise.
998 * editfns.c (Fcurrent_time_zone): Likewise.
999 * filelock.c (get_boot_time): Likewise.
1000 * frame.c (make_terminal_frame, set_term_frame_name)
1001 (x_report_frame_params): Likewise.
1002 * image.c (gs_load): Likewise.
1003 * minibuf.c (get_minibuffer): Likewise.
1004 * msdos.c (dos_set_window_size): Likewise.
1005 * process.c (make_process): Likewise.
1006 * xdisp.c (ensure_echo_area_buffers): Likewise.
1007 * xsettings.c (apply_xft_settings): Likewise.
1008
d01ba2f1
GM
10092012-07-09 Glenn Morris <rgm@gnu.org>
1010
1011 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1012 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1013 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1014 * nsterm.h (ns_etc_directory): Add it.
1015 * callproc.c [HAVE_NS]: Include nsterm.h.
1016 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1017
f1f924b6
DA
10182012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1019
1020 Move marker debugging code under MARKER_DEBUG.
1021 * marker.c (MARKER_DEBUG): Move marker debugging code under
1022 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1023 for bootstrap with --enable-checking (~3x slowdown reported
1024 by Juanma Barranquero <lekktu@gmail.com>).
1025 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1026
ab531b66
PE
10272012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1028
1029 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1030 See <http://bugs.gnu.org/11825#29>.
1031
c4b3bc8a
EZ
10322012-07-08 Eli Zaretskii <eliz@gnu.org>
1033
1034 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1035 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1036 (display_line): Add commentary about displaying truncation glyphs
1037 on GUI frames.
1038 (produce_special_glyphs): Move here from term.c.
1039
1040 * term.c (produce_special_glyphs): Move to xdisp.c.
1041
1042 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1043 section.
c4b3bc8a 1044
b676b881
AS
10452012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1046
f17c5273
AS
1047 * xdisp.c (display_line): Avoid warning about implicit declaration
1048 of FRAME_FONT.
1049
298819b9
AS
1050 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1051
b676b881
AS
1052 * lisp.h: Remove empty conditional.
1053
6045c4fd
PE
10542012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1055
b3350bf9
PE
1056 * lread.c (load_path_check): Now static.
1057
6045c4fd
PE
1058 Fix some minor --with-ns problems found by static checking.
1059 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1060 (x_set_font) [!HAVE_X_WINDOWS]:
1061 * image.c (xpm_load_image) [HAVE_NS]:
1062 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1063 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1064 Remove unused local.
1065 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1066 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1067 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1068 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1069 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1070 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1071 Fix pointer signedness problem.
1072 * xfaces.c (FRAME_X_FONT_TABLE):
1073 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1074
929e7845
GM
10752012-07-07 Glenn Morris <rgm@gnu.org>
1076
1077 * lread.c (load_path_check): New function, split from init_lread.
1078 (init_lread): Reorganize. Motivation:
1079 If EMACSLOADPATH is set, check/warn about that rather than the
1080 defaults, which we are not going to use. Hence we can remove
1081 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1082 Don't warn if site-lisp directories are missing.
1083 If not installed, start from a blank load-path, since
1084 PATH_LOADSEARCH refers to the eventual installation directories.
1085
58dd0aa4
EZ
10862012-07-07 Eli Zaretskii <eliz@gnu.org>
1087
1088 Support truncation and continuation glyphs on GUI frames, when
1089 fringes are disabled. (Bug#11832)
1090 * xdisp.c (init_iterator): Get dimensions of truncation and
1091 continuation glyphs even if on GUI frames. Adjust
1092 it->last_visible_x on GUI frames when the left or right fringes,
1093 or both, are absent.
1094 (start_display, move_it_in_display_line_to): Handle the case of a
1095 GUI frame without a fringe to display continuation or truncation
1096 glyphs.
1097 (insert_left_trunc_glyphs): Support GUI frames: make sure
1098 truncation glyphs overwrite enough glyphs from the current line to
1099 have sufficient space in pixels.
1100 (display_line): Support truncation and continuation glyphs on GUI
1101 frames. If some spare pixels are left on the line after inserting
1102 the truncation glyphs, fill that space with a stretch glyph of a
1103 suitably computed width.
1104
1105 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1106 produce_glyphs, to support GUI sessions.
1107
31571fd7
PE
11082012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1109
5a16b9bc
PE
1110 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1111
f3047c75
PE
1112 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1113
31571fd7
PE
1114 Do not require float-time's arg to fit in time_t (Bug#11825).
1115 This works better on hosts where time_t is unsigned, and where
1116 float-time is applied to the (negative) difference between two times.
1117 * editfns.c (decode_time_components): Last arg is now double *,
1118 not int *, and means to store all the result as a double, without
1119 worrying about whether the seconds part fits in time_t.
1120 All callers changed.
1121 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1122 All callers changed.
1123 (Ffloat_time): Do not fail merely because the specified time falls
1124 outside of time_t range.
1125
4516fbef
GM
11262012-07-07 Glenn Morris <rgm@gnu.org>
1127
1128 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1129 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1130 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1131
07adc2c6
JB
11322012-07-07 Juanma Barranquero <lekktu@gmail.com>
1133
1134 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1135 Update dependencies.
1136
1137 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1138
fd573f31
PE
11392012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1140
fee5959d
PE
1141 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1142 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1143 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1144 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1145 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1146 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1147
fd573f31
PE
1148 * xfont.c (compare_font_names): Redo to omit the need for casts.
1149
ddadbc0e
AS
11502012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1151
fca8d6b6
AS
1152 * xfns.c (Fx_change_window_property): Doc fix.
1153 * w32fns.c (Fx_change_window_property): Doc fix.
1154
ddadbc0e
AS
1155 * w32fns.c (Fx_window_property): Accept the same arguments as the
1156 X Windows version. Doc fix.
1157 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1158
ed9265fc 11592012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1160 Eli Zaretskii <eliz@gnu.org>
1161
1162 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1163 Windows-specific code from nt/config.nt moved here.
1164 Obsolete settings removed.
1165
216ee680
PE
11662012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1167
1168 * process.c: Avoid unnecessary calls to gettime.
1169 (wait_reading_process_output): Don't get the time of day
1170 when gobbling data immediately and not waiting, as there's no need
1171 for it in that case. This removes a FIXME.
1172
bdd091e4
JD
11732012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1174
1175 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1176 is defined (Bug#11768).
1177
9d44f8ce
DA
11782012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1179
1180 Fix marker debugging code.
1181 * marker.c (byte_char_debug_check): Do not perform the check
1182 if buffer is not multibyte.
090bd7cb
JB
1183 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1184 Call byte_char_debug_check with correct arguments.
9d44f8ce 1185
90fc4786
DA
11862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1187
1188 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1189 * marker.c (byte_char_debug_check, count_markers):
1190 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1191 (byte_debug_flag): Remove.
1192 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1193 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1194
7b7ae965
DA
11952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1196
4e57b342
DA
1197 Avoid code repetition in marker-related functions.
1198 * marker.c (attach_marker): New function.
1199 (Fset_marker, set_marker_restricted, set_marker_both)
1200 (set_marker_restricted_both): Use it.
1201 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1202 Consistently rename charno to charpos.
1203 (marker_position): Add eassert.
1204 (marker_byte_position): Convert to eassert.
1205
12062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1207
1208 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1209 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1210 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1211
657924ff
DA
12122012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1213
1214 Introduce fast path for the widely used marker operation.
1215 * alloc.c (build_marker): New function.
1216 * lisp.h (build_marker): New prototype.
1217 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1218 * composite.c (autocmp_chars): Likewise.
1219 * editfns.c (buildmark): Remove.
1220 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1221 (save_restriction_save): Use build_marker.
1222 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1223 * window.c (save_window_save): Likewise.
1224
041a49a6
DA
12252012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1226
1227 Do not use Fdelete_overlay in delete_all_overlays
1228 to avoid redundant calls to unchain_overlay.
1229 * buffer.c (drop_overlay): New function.
1230 (delete_all_overlays, Fdelete_overlay): Use it.
1231 * minibuf.c (get_minibuffer): Fix comment.
1232
7dca65a4
PE
12332012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1234
1235 Port to OpenBSD 5.1 amd64.
1236 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1237 This is needed for OpenBSD, and should be harmless on all BSD systems.
1238 Also, include <sys/sysctl.h>, as it should be available on all
1239 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1240 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1241 use p_pid member, not kp_proc.pid.
1242
8eb876e2
GM
12432012-07-06 Glenn Morris <rgm@gnu.org>
1244
1245 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1246
38182d90
PE
12472012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 More xmalloc and related cleanup.
1250 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1251 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1252 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1253 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1254 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1255 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1256 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1257 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1258 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1259 * xterm.c:
1260 Omit needless casts involving void * pointers and allocation.
1261 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1262 as the former is more robust if P's type is changed.
1263 Prefer xzalloc to xmalloc + memset 0.
1264 Simplify malloc-or-realloc to realloc.
1265 Don't worry about xmalloc returning a null pointer.
1266 Prefer xstrdup to xmalloc + strcpy.
1267 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1268 growing it.
1269 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1270 alloca of a constant.
1271
6dd5a677
EZ
12722012-07-05 Eli Zaretskii <eliz@gnu.org>
1273
1274 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1275 hscroll is larger than the line width. Fixes long and futile
1276 looping inside extend_face_to_end_of_line (on a TTY) producing
1277 glyphs that are not needed and thrown away.
1278
6b312f0f
DA
12792012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1280
1281 * marker.c (set_marker_restricted_both): Simplify by using
1282 clip_to_bounds.
1283
f520ef9b
PE
12842012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1287
383b7c95
JD
12882012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1289
1290 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1291 not defined (Bug#11768).
1292 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1293 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1294 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1295 followed by gtk_box_set_homogeneous (Bug#11768).
1296 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1297 (update_theme_scrollbar_width, xg_create_scroll_bar):
1298 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1299 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1300 (is_box_type): New function (Bug#11768).
1301 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1302 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1303 with default display (Bug#11768).
1304
d6e7bf45
EZ
13052012-07-05 Eli Zaretskii <eliz@gnu.org>
1306
1307 * xdisp.c (window_hscroll_limited): New function.
1308 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1309 coordinates when window's hscroll is set to insanely large
1310 values. (Bug#11857)
1311
431391ec
JB
13122012-07-05 Juanma Barranquero <lekktu@gmail.com>
1313
1314 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1315 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1316
23f86fce
DA
13172012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1318
1319 Cleanup xmalloc.
1320 * lisp.h (xzalloc): New prototype. Omit needless casts.
1321 * alloc.c (xzalloc): New function. Omit needless casts.
1322 * charset.c: Omit needless casts. Convert all calls to
1323 xmalloc with following memset to xzalloc.
1324 * dispnew.c: Likewise.
1325 * fringe.c: Likewise.
1326 * image.c: Likewise.
1327 * sound.c: Likewise.
1328 * term.c: Likewise.
1329 * w32fns.c: Likewise.
1330 * w32font.c: Likewise.
1331 * w32term.c: Likewise.
1332 * xfaces.c: Likewise.
1333 * xfns.c: Likewise.
1334 * xterm.c: Likewise.
1335 * atimer.c: Omit needless casts.
1336 * buffer.c: Likewise.
1337 * callproc.c: Likewise.
1338 * ccl.c: Likewise.
1339 * coding.c: Likewise.
1340 * composite.c: Likewise.
1341 * doc.c: Likewise.
1342 * doprnt.c: Likewise.
1343 * editfns.c: Likewise.
1344 * emacs.c: Likewise.
1345 * eval.c: Likewise.
1346 * filelock.c: Likewise.
1347 * fns.c: Likewise.
1348 * gtkutil.c: Likewise.
1349 * keyboard.c: Likewise.
1350 * lisp.h: Likewise.
1351 * lread.c: Likewise.
1352 * minibuf.c: Likewise.
1353 * msdos.c: Likewise.
1354 * print.c: Likewise.
1355 * process.c: Likewise.
1356 * region-cache.c: Likewise.
1357 * search.c: Likewise.
1358 * sysdep.c: Likewise.
1359 * termcap.c: Likewise.
1360 * terminal.c: Likewise.
1361 * tparam.c: Likewise.
1362 * w16select.c: Likewise.
1363 * w32.c: Likewise.
1364 * w32reg.c: Likewise.
1365 * w32select.c: Likewise.
1366 * w32uniscribe.c: Likewise.
1367 * widget.c: Likewise.
1368 * xdisp.c: Likewise.
1369 * xmenu.c: Likewise.
1370 * xrdb.c: Likewise.
1371 * xselect.c: Likewise.
1372
0497dc44
PE
13732012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 * fileio.c (time_error_value): Check the right error number.
1376 Problem reported by Troels Nielsen in
1377 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1378
356e7178
PE
13792012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1380
4e71fd89
PE
1381 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1382 This should be fixed in a better way; see Eli Zaretskii in
1383 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1384 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1385
f0941253
PE
1386 * fileio.c (time_error_value): Rename from special_mtime.
1387 The old name's problems were noted by Eli Zaretskii in
1388 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1389
065c9eb4
PE
1390 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1391 This variable's comment says Emacs needs at least one GDB-visible
1392 symbol of type enum pvec_type, to work around GDB problems.
1393 The symbol's value doesn't matter.
1394
356e7178
PE
1395 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1396 that causes compilation to fail on pre-C99 compilers.
1397
ed9265fc 13982012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1399
1400 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1401 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1402
3884d954
DA
14032012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1404
d209e2fb 1405 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1406 headers for buffer_defaults and buffer_local_symbols.
1407 Reported by Juanma Barranquero <lekktu@gmail.com>.
1408
ee28be33
SM
14092012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1410
1411 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1412 * lisp.h (enum pvec_type): Use fewer bits.
1413 (PSEUDOVECTOR_SIZE_BITS): New constant.
1414 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1415 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1416 change in pvec_type.
1417 (PSEUDOVECTOR_TYPEP): New macro.
1418 (TYPED_PSEUDOVECTORP): Use it.
1419 * fns.c (internal_equal): Adapt code to extract pvectype.
1420 * emacs.c (gdb_pvec_type): Update type.
1421 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1422 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1423 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1424 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1425 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1426 abusing vector->header.next.nbytes.
1427 (live_vector_p): Use PVEC_TYPE.
1428 (mark_object): Adapt code to extract pvectype. Use switch.
1429
c7f2cd7f
PE
14302012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1433 Tighten new eassert a bit.
1434
8ce70ed2
DA
14352012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1436
1437 Fix compilation with --enable-gcc-warnings and -O1
1438 optimization level.
1439 * doprnt.c (doprnt): Change type of tem to int, initialize
1440 to avoid compiler warning. Add eassert.
1441 * search.c (simple_search): Initialize match_byte to avoid
1442 compiler warning. Add eassert.
1443
dea7f1e5
PE
14442012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1445
24a212eb
PE
1446 Avoid weird behavior with large horizontal scrolls.
1447 Without this change, for example, large hscroll values would
1448 mess up Emacs's display on Fedora 15 x86, presumably due to
1449 overflows in int calculations in the display code.
1450 Also, if buffers had long lines, Emacs would freeze.
1451 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1452 (set_window_hscroll): New function, containing the old guts of
1453 Fset_window_hscroll. Return the clipped value.
1454 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1455 This avoids the need to check against PTRDIFF_MAX.
1456
dea7f1e5
PE
1457 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1458
76046526
DA
14592012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1460
1461 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1462
39adff0d
PE
14632012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1464
63807d47
PE
1465 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1466 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1467 since GCC 4.4.6 issues a bogus warning for them.
1468
39adff0d
PE
1469 Fix bugs in file timestamp newness comparisons.
1470 * fileio.c (Ffile_newer_than_file_p):
1471 * lread.c (Fload): Use full timestamp resolution of files,
1472 not just the 1-second resolution, so that files that are only
1473 slightly newer still count as newer.
1474 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1475 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1476
dbeed9a6
PE
14772012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1478
1479 * fileio.c: Improve handling of file time marker. (Bug#11852)
1480 (special_mtime): New function.
1481 (Finsert_file_contents, Fverify_visited_file_modtime):
1482 Use it to set special mtime values consistently.
1483
636334d6
AS
14842012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1485
1486 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1487 marker for non-existing file. (Bug#11852)
1488
e2017fe2
GM
14892012-07-03 Glenn Morris <rgm@gnu.org>
1490
1491 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1492 and did not make it into globals.h).
1493
404dbd37
TT
14942012-07-03 Tom Tromey <tromey@redhat.com>
1495
1496 * window.c (Fset_window_margins, Fset_window_fringes)
1497 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1498 * textprop.c (Fprevious_property_change): No longer static.
1499 * syntax.c (Fsyntax_table_p): No longer static.
1500 * process.c (Fget_process, Fprocess_datagram_address): No longer
1501 static.
1502 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1503 * keyboard.c (Fcommand_execute): No longer static.
1504 Remove EXFUN.
1505 * insdel.c (Fcombine_after_change_execute): No longer static.
1506 * image.c (Finit_image_library): No longer static.
1507 * fileio.c (Fmake_symbolic_link): No longer static.
1508 * eval.c (Ffetch_bytecode): No longer static.
1509 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1510 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1511 No longer static.
404dbd37
TT
1512 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1513 static.
1514 * dired.c (Ffile_attributes): No longer static.
1515 * composite.c (Fcomposition_get_gstring): No longer static.
1516 * callproc.c (Fgetenv_internal): No longer static.
1517
1518 * ccl.h: Remove EXFUNs.
1519 * buffer.h: Remove EXFUNs.
1520 * dispextern.h: Remove EXFUNs.
1521 * intervals.h: Remove EXFUNs.
1522 * fontset.h: Remove EXFUN.
1523 * font.h: Remove EXFUNs.
1524 * dosfns.c (system_process_attributes): Remove EXFUN.
1525 * keymap.h: Remove EXFUNs.
1526 * lisp.h: Remove EXFUNs.
1527 * w32term.h: Remove EXFUNs.
1528 * window.h: Remove EXFUNs.
1529 * xsettings.h: Remove EXFUN.
1530 * xterm.h: Remove EXFUN.
1531
8e4fd1e1
GM
15322012-07-03 Glenn Morris <rgm@gnu.org>
1533
1534 * lisp.h (Frandom): Make it visible to C.
1535 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1536 buffer for invisible buffers. (Bug#1229)
1537
ca95b3eb
DA
15382012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1539
1540 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1541 values which aren't power of 2.
1542 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1543 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1544 accordingly.
1545
7555c33f
SM
15462012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1547
1548 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1549
1550 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1551
d12e8f5a
DA
15522012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1553
1554 * alloc.c (allocate_vector_block): Remove redundant
1555 calls to mallopt if DOUG_LEA_MALLOC is defined.
1556 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1557 avoid calls to mallopt if zero_vector is returned.
1558
296094c3
DA
15592012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1560
1561 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1562 is enabled, avoid dereferencing NULL current_sblock if
1563 running undumped.
1564
36429c89
DA
15652012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1566
1567 Cleanup basic buffer management.
1568 * buffer.h (struct buffer): Change layout to use generic vector
1569 marking code. Fix some comments. Change type of 'clip_changed'
1570 to bitfield. Remove unused #ifndef old.
1571 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1572 (GET_OVERLAYS_AT): Fix indentation.
1573 (for_each_per_buffer_object_at): New macro.
1574 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1575 (Fbuffer_local_variables): Use it.
1576 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1577 * alloc.c (allocate_buffer): Adjust to match new layout of
1578 struct buffer. Fix comment.
1579 (mark_overlay): New function.
1580 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1581 Lisp area of struct buffer.
1582 (mark_object): Use it. Adjust marking of misc objects
1583 and related comments.
1584
3b3e4cac
PE
15852012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1588 wrapper that is not needed because the wrapped code is a no-op (zero
1589 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1590 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1591
cf5c0175
DA
15922012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1593
1594 * alloc.c (mark_buffer): Simplify. Remove prototype.
1595 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1596 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1597 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1598 redundant calls to mark_vectorlike for bool vectors.
1599
ca26824c
GM
16002012-06-30 Glenn Morris <rgm@gnu.org>
1601
2e4c5312
GM
1602 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1603
ca26824c
GM
1604 * epaths.in (PATH_SITELOADSEARCH): New.
1605 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1606 This is rather than relying on --enable-locallisppath elements
1607 having "site-lisp" in their names. (Bug#10208#25, 11658)
1608
0d23c240
EZ
16092012-06-30 Eli Zaretskii <eliz@gnu.org>
1610
c9240d7a
EZ
1611 * w32proc.c (sys_select): Accept and ignore one more argument.
1612
1613 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1614
0d23c240 1615 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1616 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1617
1618 * sysdep.c: Don't include dos.h and dosfns.h.
1619
1620 * process.c (sys_select):
1621 * msdos.c (sys_select): Accept one more argument and ignore it.
1622
1623 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1624 adapt data types and code to that.
1625
1626 * dosfns.c:
1627 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1628 which clashes with the gnulib function of the same name.
1629
af5a5a98
AS
16302012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1631
c5e4379c
AS
1632 * font.c (font_style_to_value, font_style_symbolic)
1633 (font_prop_validate_style): Add type checks for values in
1634 font_style_table.
1635
af5a5a98
AS
1636 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1637 argument.
1638 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1639 uses.
1640
8d38f461
EZ
16412012-06-29 Eli Zaretskii <eliz@gnu.org>
1642
2e5a6631
EZ
1643 * xdisp.c (try_window_id): Undo last change.
1644
8d38f461
EZ
1645 * w32.c (getwd): Adjust commentary about startup_dir.
1646 (init_environment): Always call sys_access, even in non-MSVC
1647 builds. Don't chdir to the directory of the Emacs executable.
1648 This undoes code from 1997 which was justified by the need to
1649 "avoid conflicts when removing and renaming directories". But its
1650 downside was that every relative file name was being interpreted
1651 relative to the directory of the Emacs executable, which can never
1652 be TRT. In particular, it broke sys_access when called with
1653 relative file names.
1654 (sys_access): Map GetLastError to errno.
1655
2af3565e
DA
16562012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1657
1658 * window.h (struct window): Change type of 'fringes_outside_margins'
1659 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1660 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1661 Adjust comment.
1662 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1663 to ptrdiff_t.
1664
c8d3a25c 16652012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1666
c8d3a25c
GM
1667 * gnutls.c (emacs_gnutls_handshake):
1668 Add QUIT to make the loop interruptible.
57570cd3 1669
c8d3a25c 16702012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1671
c8d3a25c
GM
1672 * charset.c (init_charset): Make lack of etc/charsets fatal.
1673
3e984ee8
DA
16742012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1675
1676 * editfns.c (region_limit): Fix type mismatch.
1677
ef884f23
DA
16782012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1679
1680 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1681 undefined. Convert from xassert to eassert.
1682 * nsmenu.m: Convert from xassert to eassert.
1683 * nsterm.m: Likewise.
1684
7d7e0027
SM
16852012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1686
1687 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1688
aa754e6a
PE
16892012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1690
1691 Avoid integer overflow on scroll-left and scroll-right.
1692 * window.c (HSCROLL_MAX): New macro.
1693 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1694 overflow when requested scroll falls outside ptrdiff_t range.
1695
80b00b08
DA
16962012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1697
1698 * window.h (struct window): Change type of 'hscroll',
1699 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1700 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1701 Adjust users accordingly.
1702 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1703 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1704 from EMACS_INT to ptrdiff_t.
1705 (make_window): Omit redundant initialization.
1706
62b2bcf6
JB
17072012-06-28 Juanma Barranquero <lekktu@gmail.com>
1708
1709 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1710
45942c7d
DA
17112012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1712
1713 * window.h (struct window): Change type of 'use_time' and
1714 'sequence_number' from Lisp_Object to int.
1715 * frame.c (make_frame): Adjust users accordingly.
1716 * print.c (print_object): Likewise.
1717 * window.c (select_window, Fwindow_use_time, make_parent_window)
1718 (make_window): Likewise.
1719
e509cfa6
DA
17202012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1721
1722 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1723 enabled with --enable-checking=[all,glyphs] configure option.
1724 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1725 adjust comments accordingly.
1726 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1727 undefined, adjust comments accordingly.
1728 * image.c: Likewise.
1729 * scroll.c: Likewise.
1730 * w32fns.c: Likewise.
1731 * w32term.c: Likewise.
1732 * xdisp.c: Likewise.
1733 * xfaces.c: Likewise.
1734 * xfns.c: Likewise.
1735 * xterm.c: Likewise.
1736
a54e2c05
DA
17372012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1738
1739 Generalize run-time debugging checks.
1740 * dispextern.h (XASSERTS): Remove.
1741 * fontset.c (xassert): Remove.
1742 Convert from xassert to eassert.
1743 * alloc.c: Convert from xassert to eassert.
1744 * bidi.c: Likewise.
1745 * dispnew.c: Likewise.
1746 * fns.c: Likewise.
1747 * fringe.c: Likewise.
1748 * ftfont.c: Likewise.
1749 * gtkutil.c: Likewise.
1750 * image.c: Likewise.
1751 * keyboard.c: Likewise.
1752 * menu.c: Likewise.
1753 * process.c: Likewise.
1754 * scroll.c: Likewise.
1755 * sound.c: Likewise.
1756 * term.c: Likewise.
1757 * w32console.c: Likewise.
1758 * w32fns.c: Likewise.
1759 * w32term.c: Likewise.
1760 * window.c: Likewise.
1761 * xdisp.c: Likewise.
1762 * xfaces.c: Likewise.
1763 * xfns.c: Likewise.
1764 * xselect.c: Likewise.
1765 * xterm.c: Likewise.
1766
1ec4b7b2
SM
17672012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1768
1769 * fns.c (maybe_resize_hash_table): Output message when growing the
1770 purify-hashtable.
1771
2014308a
DA
17722012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1773
1774 * alloc.c (allocate_string_data): Remove dead code.
1775 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1776 avoid GCC warning about unused macro.
1777
246155eb
DA
17782012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1779
1780 * alloc.c (allocate_string): Omit intervals initialization.
1781 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1782 as in make_pure_string and make_pure_c_string.
1783
43184b7b
DA
17842012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1785
d209e2fb 1786 * alloc.c (allocate_string): Fix last change.
43184b7b 1787
3fe6dd74
DA
17882012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1789
d209e2fb 1790 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1791 to memset, add explicit initialization where appropriate.
1792
1ba6038a
GM
17932012-06-27 Glenn Morris <rgm@gnu.org>
1794
1795 * lisp.mk (lisp): Remove paths.elc.
1796
c89926a5
CY
17972012-06-27 Chong Yidong <cyd@gnu.org>
1798
1799 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1800
ed6b3510
JW
18012012-06-26 John Wiegley <johnw@newartisans.com>
1802
1ec4b7b2 1803 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1804 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1805
ed6b3510
JW
1806 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1807 when building with Clang.
1808
8edd4a2b
SM
18092012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1810
1811 * eval.c (Fapply): Allow calling it with a single argument.
1812
f6f62d1b
EZ
18132012-06-26 Eli Zaretskii <eliz@gnu.org>
1814
1815 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1816 _stricmp and _strnicmp.
1817 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1818
62efea5e
DA
18192012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1820
1821 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1822 allocated window.
1823 (allocate_process): Likewise for new process.
8edd4a2b 1824 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1825 (allocate_frame): Likewise.
1826 * frame.c (make_frame): Omit redundant initialization.
1827 * window.c (make_parent_window): Use memset.
1828 (make_window): Omit redundant initialization.
1829 * process.c (make_process): Omit redundant initialization.
1830 * terminal.c (create_terminal): Likewise.
1831
42997f4d
DA
18322012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1833
1834 * term.c (delete_tty): Remove redundant call to memset.
1835
1130ecfc
DA
18362012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1837
1838 * alloc.c: Remove build_string.
1839 * lisp.h: Define build_string as static inline. This provides
1840 a better opportunity to optimize away calls to strlen when the
1841 function is called with compile-time constant argument.
1842 * image.c (imagemagick_error): Convert to build_string.
1843 * w32proc.c (sys_spawnve): Likewise.
1844 * xterm.c (x_term_init): Likewise.
1845
cf38a720
PE
18462012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1847
99027bdd
PE
1848 Use sprintf return value instead of invoking strlen on result.
1849 In the old days this wasn't portable, since some sprintf
1850 implementations returned char *. But they died out years ago and
1851 Emacs already assumes sprintf returns int.
1852 Similarly for float_to_string.
1853 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1854 * ccl.c (ccl_driver):
1855 * character.c (string_escape_byte8):
1856 * data.c (Fnumber_to_string):
1857 * doprnt.c (doprnt):
1858 * print.c (print_object):
1859 * xdisp.c (message_dolog):
1860 * xfns.c (syms_of_xfns):
1861 Use sprintf or float_to_string result to avoid need to call strlen.
1862 * data.c (Fnumber_to_string):
1863 Use make_unibyte_string, since the string must be ASCII.
1864 * lisp.h, print.c (float_to_string): Now returns int length.
1865 * term.c (produce_glyphless_glyph):
1866 Use sprintf result rather than recomputing it.
1867
cf38a720
PE
1868 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1869 * Makefile.in (ALL_CFLAGS):
1870 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1871 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1872
3511c784
DA
18732012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1874
0a08eb21 1875 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1876 strcasecmp if available.
1877 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1878
fb7da12e
AS
18792012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1880
1881 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1882 Avoid comma operator.
1883 * menu.c (push_submenu_start, push_submenu_end)
1884 (push_left_right_boundary, push_menu_pane): Likewise.
1885 * msdos.c (dos_rawgetc): Likewise.
1886
afa2ffd8
DA
18872012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1888
1889 * xfns.c (xic_create_fontsetname): Remove redundant calls
1890 to memset.
1891
b3b4476b
PE
18922012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1893
4495ff38
PE
1894 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1895 sprintf already null-terminates its output.
1896
b3b4476b
PE
1897 * xfns.c (x_window): Remove redundant cast.
1898
b00876c9
DA
18992012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1900
1901 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1902 `const char *' to `char *' to avoid compiler warning.
1903
d188e26b
PE
19042012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1905
885d1d74
PE
1906 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1907 instead of truncating it to 63 (admittedly a generous limit).
1908
d188e26b
PE
1909 * process.c: Fix spelling and caps in comments.
1910
e2f560b1
DN
19112012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1912
e86db54b 1913 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1914 * sysdep.c (setpgrp): Remove definition, not used in this file.
1915
7583a3a1
JB
19162012-06-24 Juanma Barranquero <lekktu@gmail.com>
1917
1918 * makefile.w32-in: Update dependencies.
1919
696056c2
EZ
19202012-06-24 Eli Zaretskii <eliz@gnu.org>
1921
1922 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1923 (SYSTIME_H): Add nt/inc/sys/time.h.
1924
1925 * systime.h [WINDOWSNT]: Include sys/time.h.
1926
1927 * s/ms-w32.h (struct timespec): Definition moved from
1928 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1929
845ca893
PE
19302012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1931
1932 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1933 * buffer.h (buffer_slot_type_mismatch):
1934 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1935 * eval.c (unwind_to_catch):
1936 * image.c (my_png_error, my_error_exit):
1937 * keyboard.c (quit_throw_to_read_char, user_error)
1938 (Fexit_recursive_edit, Fabort_recursive_edit):
1939 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1940 (wrong_type_argument, buffer_overflow, __executable_start)
1941 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1942 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1943 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1944 (fatal):
1945 (child_setup) [!DOS_NT]:
1946 * lread.c (end_of_file_error, invalid_syntax):
1947 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1948 * puresize.h (pure_write_error):
1949 * search.c (matcher_overflow):
1950 * sound.c (sound_perror, alsa_sound_perror):
1951 * sysdep.c, syssignal.h (croak):
1952 * term.c (maybe_fatal, vfatal):
1953 * textprop.c (text_read_only):
1954 * undo.c (user_error):
1955 * unexmacosx.c (unexec_error):
1956 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1957 Use _Noreturn rather than NO_RETURN.
1958 No need for separate decl merely because of _Noreturn.
1959 * sound.c (sound_warning, parse_sound):
1960 Remove unnecessary forward decls.
1961
f1dd8073
PE
19622012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1963
1964 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1965 * lisp.h (WAIT_READING_MAX): New macro.
1966 * dispnew.c (Fsleep_for, sit_for):
1967 * keyboard.c (kbd_buffer_get_event):
1968 * process.c (Faccept_process_output):
1969 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1970 This improves on the previous patch, which introduced a bug
1971 when time_t is unsigned and as wide as intmax_t.
1972 See <http://bugs.gnu.org/9000#51>.
1973
b82c1755
EZ
19742012-06-23 Eli Zaretskii <eliz@gnu.org>
1975
1976 * dispnew.c (sit_for, Fsleep_for):
1977 * keyboard.c (kbd_buffer_get_event):
1978 * process.c (Faccept_process_output): Avoid compiler warnings when
1979 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1980
ca300656
JB
19812012-06-23 Juanma Barranquero <lekktu@gmail.com>
1982
049ec95b
JB
1983 * makefile.w32-in: Update dependencies.
1984
ca300656
JB
1985 * w32.c (ltime): Add return type and declare static.
1986 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1987
db7b8d06
PE
19882012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1989
1990 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1991 Privately reported by Herbert J. Skuhra.
1992 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1993 All uses changed.
1994 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1995 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1996
0bd8297f
EZ
19972012-06-23 Eli Zaretskii <eliz@gnu.org>
1998
96512555
EZ
1999 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2000 last argument of make_unibyte_string.
2001
0bd8297f
EZ
2002 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2003 language ID in the event parameters.
2004
2005 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2006 event.code, not the obscure "character set ID".
2007
63def6b6
CY
20082012-06-23 Chong Yidong <cyd@gnu.org>
2009
2010 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2011
e8a02204
EZ
20122012-06-23 Eli Zaretskii <eliz@gnu.org>
2013
388cdec0
EZ
2014 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2015 * w32.c (fdutimens): New function.
2016
2017 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2018
2019 * s/ms-w32.h (pselect): Redirect to sys_select.
2020
2021 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2022
e8a02204
EZ
2023 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2024 in the logic of incrementing and decrementing the value of
2025 use_relocatable_buffers.
2026
d054f3fb
PE
20272012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2028
2029 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2030 Privately reported by Herbert J. Skuhra.
2031 [__FreeBSD__]: Remove "*/" typo after "#include".
2032 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2033 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2034 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2035 Don't assume EMACS_TIME and struct timeval are the same type.
2036
d35af63c
PE
20372012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2038
2039 Support higher-resolution time stamps (Bug#9000).
2040 The time stamps are only nanosecond-resolution at the C level,
2041 since that's the best that any real-world system supports now.
2042 But they are picosecond-resolution at the Lisp level, as that's
2043 easy, and leaves room for future OS improvements.
2044
2045 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2046 (LIBES): Use it.
2047
2048 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2049 Don't get current time unless it's needed.
2050
2051 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2052 now provides it if it's absent.
2053 (start_atimer): Port to higher-res time stamps.
2054 Check for time stamp overflow. Don't get current time more
2055 often than is needed.
2056
2057 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2058 Include systime.h, not time.h.
2059 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2060
2061 * dired.c: Include stat-time.h.
2062 (Ffile-attributes): File times now have higher resolution.
2063
2064 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2065 (struct image): Timestamp now has higher resolution.
2066
2067 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2068 has at least microseconds now. All uses removed.
2069 (update_frame, update_single_window, update_window, update_frame_1)
2070 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2071
2072 * editfns.c (time_overflow): Now extern.
2073 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2074 (float-time, Fformat_time_string, Fcurrent_time_string)
2075 (Fcurrent_time_zone): Accept and generate higher-resolution
2076 time stamps.
2077 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2078 (decode_time_components, lisp_seconds_argument): New functions.
2079 (make_time): Now static.
2080 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2081 Report an error if the time is invalid, rather than having the caller
2082 do that.
2083
2084 * fileio.c: Include <stat-time.h>
2085 (Fcopy_file): Copy higher-resolution time stamps.
2086 Prefer to set the time stamp via a file descriptor if that works.
2087 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2088 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2089 (Fvisited_file_modtime, Fset_visited_file_modtime):
2090 Support higher-resolution time stamps.
2091
2092 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2093
2094 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2095
2096 * image.c (prepare_image_for_display, clear_image_cache)
2097 (lookup_image): Port to higer-resolution time stamps.
2098
2099 * keyboard.c (start_polling, bind_polling_period):
2100 Check for time stamp overflow.
2101 (read_char, kbd_buffer_get_event, timer_start_idle)
2102 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2103 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2104 Port to higher-resolution time stamps. Do not assume time_t is signed.
2105 (decode_timer): New function. Timers are now vectors of length 9,
2106 not 8, to accommodate the picosecond component.
2107 (timer_check_2): Use it.
2108
2109 * nsterm.m (select_timeout, timeval_subtract): Remove.
2110 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2111 as they're a bit more accurate and handle overflow better.
2112 (ns_select): Change prototype to be compatible with pselect.
2113 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2114 * nsterm.h (ns_select): Adjust prototype.
2115
2116 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2117 us-resolution time stamps.
2118 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2119
2120 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2121
2122 * lisp.h (time_overflow): New decl.
2123 (wait_reading_process_output): First arg is now intmax_t, not int,
2124 to accommodate larger waits.
2125
2126 * process.h (struct Lisp_Process.read_output_delay):
2127 Now counts nanoseconds, not microseconds.
2128 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2129 EMACS_HAS_USECS.
2130 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2131 (wait_reading_process_output):
2132 Port to ns-resolution time stamps.
2133 (Faccept_process_output, wait_reading_process_output):
2134 Check for time stamp overflow. Do not assume time_t is signed.
2135 (select_wrapper): Remove; we now use pselect.
2136 (Fprocess_attributes): Now generates ns-resolution time stamps.
2137
2138 * sysdep.c: Include utimens.h. Don't include utime.h
2139 or worry about struct utimbuf; gnulib does that for us now.
2140 (gettimeofday): Remove; gnulib provides a substitute.
2141 (make_timeval): New function.
2142 (set_file_times): Now sets ns-resolution time stamps.
2143 New arg FD; all uses changed.
2144 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2145 (system_process_attributes):
2146 Now returns ns-resolution time stamp. All uses changed.
2147 Check for time stamp overflow.
2148
2149 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2150 provides a substitute now.
2151
2152 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2153 since it guarantees struct timespec.
2154 (EMACS_TIME): Now struct timespec, so that we can support
2155 ns-resolution time stamps.
2156 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2157 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2158 (EMACS_USECS): Remove.
2159 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2160 so multiply the arg by 1000 before storing it.
2161 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2162 New macros.
2163 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2164 Port to ns-resolution time stamps.
2165 (EMACS_TIME_NEG_P): Remove; replaced by....
2166 (EMACS_TIME_SIGN): New macro.
2167 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2168 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2169 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2170 (make_timeval, make_lisp_time, decode_time_components): New decls.
2171 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2172 that it mishandled time_t overflow. You can't compare by subtracting!
2173 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2174 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2175
2176 * term.c: Include <sys/time.h>.
2177 (timeval_to_Time): New function, for proper overflow wraparound.
2178 (term_mouse_position, term_mouse_click): Use it.
2179
2180 * undo.c (record_first_change): Support higher-resolution time stamps
2181 in the undo buffer.
2182 (Fprimitive_undo): Use them when restoring time stamps.
2183
2184 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2185 (w32_get_internal_run_time):
2186 Port to higher-resolution Emacs time stamps.
2187 (ltime): Now accepts single 64-bit integer, as that's more convenient
2188 for callers.
2189
2190 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2191
2192 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2193 for compatibility with pselect. Support ns-resolution time stamps.
2194
2195 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2196
2197 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2198 Check for time stamp overflow, and support ns-resolution time stamps.
2199
2200 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2201 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2202 (timeval_subtract): Remove; no longer needed.
2203 (XTflash, XTring_bell, x_wait_for_event):
2204 Port to ns-resolution time stamps. Don't assume time_t is signed.
2205
b6a92dfe
CY
22062012-06-22 Chong Yidong <cyd@gnu.org>
2207
2208 * xdisp.c (x_consider_frame_title): Revert last change.
2209
d251c37c
EZ
22102012-06-22 Eli Zaretskii <eliz@gnu.org>
2211
2212 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2213 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2214 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2215 staticidx goes up to 1597 out of 1600 = 0x640.)
2216
f10deafb
PE
22172012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2218
2219 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2220 Otherwise, the umask might be mistakenly 0 while handling input signals.
2221
ec6de1e2
SM
22222012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2223
2224 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2225
28be1ada
DA
22262012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2227
2228 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2229 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2230 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2231 access to `contents' member of Lisp_Vector objects with AREF and ASET
2232 where appropriate.
2233
c6bf3022
CY
22342012-06-19 Chong Yidong <cyd@gnu.org>
2235
2236 * frame.c (delete_frame): When selecting a frame on a different
2237 text terminal, do not alter the terminal's top-frame.
2238
2239 * xdisp.c (format_mode_line_unwind_data): Record the target
2240 frame's selected window and its terminal's top-frame.
2241 (unwind_format_mode_line): Restore them.
2242 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2243 Callers changed.
2244 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2245 since tty frames can be explicitly named.
2246 (prepare_menu_bars): Likewise.
2247
2248 * term.c (Ftty_top_frame): New function.
2249
defd4196
PE
22502012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2251
2252 Port byte-code-meter to modern targets.
2253 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2254 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2255 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2256 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2257 (METER_1, METER_2): Simplify.
2258
1053a871
SM
22592012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2260
2261 * data.c (Fdefalias): Return `symbol' (bug#11686).
2262
b7e8d081
MR
22632012-06-18 Martin Rudalics <rudalics@gmx.at>
2264
2265 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2266 gets killed during executing of this function (Bug#11665).
2267 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2268 (Vkill_buffer_query_functions): In doc-string say that functions
2269 run by this hook should not change the current buffer.
2270
7ea2b339
PE
22712012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2272
2273 Fix recently-introduced process.c problems found by static checking.
2274 * process.c (write_queue_push, write_queue_pop, send_process):
2275 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2276 (write_queue_pop): Fix pointer signedness problem.
2277 (send_process): Remove unused local.
2278
96a313a1
CY
22792012-06-17 Chong Yidong <cyd@gnu.org>
2280
2281 * xdisp.c (redisplay_internal): No need to redisplay terminal
2282 frames that are not on top.
2283
20ca2e94
TN
22842012-06-17 Troels Nielsen <bn.troels@gmail.com>
2285
2286 * process.c (make_process): Initialize write_queue.
2287 (write_queue_push, write_queue_pop): New functions.
2288 (send_process): Use them to maintain correct ordering of process
2289 writes (Bug#10815).
2290
9a900ca9
PE
22912012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2292
310fbfa8
PE
2293 * lisp.h (eassert): Assume C89 or later.
2294 This removes the need for CHECK.
2295 (CHECK): Remove. Its comments about always evaluating its
2296 argument were confusing, as 'eassert' typically does not evaluate
2297 its argument.
2298
27bb1ca4
PE
2299 * coding.c (produce_chars): Use ptrdiff_t, not int.
2300
9a900ca9
PE
2301 * xterm.c (x_draw_underwave): Check for integer overflow.
2302 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2303
41b7f8bc 23042012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2305
2306 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2307 referenced (Bug#11583).
2308
9b0e3eba
AA
23092012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2310
2311 Implement wave-style variant of underlining.
2312 * dispextern.h (face_underline_type): New enum.
2313 (face): Add field for underline type.
2314 * nsterm.m (ns_draw_underwave): New function.
2315 (ns_draw_text_decoration): Use it.
2316 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2317 New functions.
2318 (x_draw_glyph_string): Use them.
2319 * xfaces.c (Qline, Qwave): New Lisp objects.
2320 (check_lface_attrs, merge_face_ref)
1053a871
SM
2321 (Finternal_set_lisp_face_attribute, realize_x_face):
2322 Handle wave-style underline face attributes.
9b0e3eba
AA
2323 * xterm.c (x_draw_underwave): New function.
2324 (x_draw_glyph_string): Use it.
2325
0fb52f11
JB
23262012-06-16 Juanma Barranquero <lekktu@gmail.com>
2327
2328 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2329 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2330 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2331 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2332 ($(BLD)/w32select.$(O)): Update dependencies.
2333
e5560ff7
AS
23342012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2335
2336 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2337 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2338 * character.c (_fetch_multibyte_char_p): Remove.
2339 * alloc.c: Include "character.h" before "buffer.h".
2340 * bidi.c: Likewise.
2341 * buffer.c: Likewise.
2342 * bytecode.c: Likewise.
2343 * callint.c: Likewise.
2344 * callproc.c: Likewise.
2345 * casefiddle.c: Likewise.
2346 * casetab.c: Likewise.
2347 * category.c: Likewise.
2348 * cmds.c: Likewise.
2349 * coding.c: Likewise.
2350 * composite.c: Likewise.
2351 * dired.c: Likewise.
2352 * dispnew.c: Likewise.
2353 * doc.c: Likewise.
2354 * dosfns.c: Likewise.
2355 * editfns.c: Likewise.
2356 * emacs.c: Likewise.
2357 * fileio.c: Likewise.
2358 * filelock.c: Likewise.
2359 * font.c: Likewise.
2360 * fontset.c: Likewise.
2361 * fringe.c: Likewise.
2362 * indent.c: Likewise.
2363 * insdel.c: Likewise.
2364 * intervals.c: Likewise.
2365 * keyboard.c: Likewise.
2366 * keymap.c: Likewise.
2367 * lread.c: Likewise.
2368 * macros.c: Likewise.
2369 * marker.c: Likewise.
2370 * minibuf.c: Likewise.
2371 * nsfns.m: Likewise.
2372 * nsmenu.m: Likewise.
2373 * print.c: Likewise.
2374 * process.c: Likewise.
2375 * regex.c: Likewise.
2376 * region-cache.c: Likewise.
2377 * search.c: Likewise.
2378 * syntax.c: Likewise.
2379 * term.c: Likewise.
2380 * textprop.c: Likewise.
2381 * undo.c: Likewise.
2382 * unexsol.c: Likewise.
2383 * w16select.c: Likewise.
2384 * w32fns.c: Likewise.
2385 * w32menu.c: Likewise.
2386 * window.c: Likewise.
2387 * xdisp.c: Likewise.
2388 * xfns.c: Likewise.
2389 * xmenu.c: Likewise.
2390 * xml.c: Likewise.
2391 * xselect.c: Likewise.
2392
2f07e6af
EZ
23932012-06-16 Eli Zaretskii <eliz@gnu.org>
2394
1053a871
SM
2395 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2396 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2397 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2398 row.
2399 (handle_face_prop): Use chunk-relative overlay string index when
2400 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2401 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2402 the rightmost. (Bug#11720)
2f07e6af 2403
29b83cec
AS
24042012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2405
2406 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2407 (CATEGORY_MEMBER): Enforce 1/0 value.
2408 * category.c (_temp_category_set): Remove.
2409
4c5501e9
EZ
24102012-06-16 Eli Zaretskii <eliz@gnu.org>
2411
2412 * window.c (Fdelete_other_windows_internal)
2413 (Fdelete_window_internal): Don't access frame's mouse highlight
2414 info of the initial frame. (Bug#11677)
2415
2b570124
PE
24162012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2417
e93864f9
PE
2418 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2419 Assume USE_2_TAGS_FOR_INTS.
2420 (xreload): Adjust $tagmask width to match recent lisp.h change.
2421
2b570124
PE
2422 Simplify lisp.h in minor ways that should not affect code.
2423 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2424 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2425 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2426 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2427 (INTTYPEBITS): New macro, for clarity.
2428 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2429 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2430 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2431 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2432 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2433
81755f69
JB
24342012-06-13 Juanma Barranquero <lekktu@gmail.com>
2435
2436 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2437
16192a57
GM
24382012-06-13 Glenn Morris <rgm@gnu.org>
2439
2440 * s/bsd-common.h (BSD4_3):
2441 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2442
646b5f55
AS
24432012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2444
2445 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2446 instead of union.
2447 (XLI, XIL): Define.
1053a871
SM
2448 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2449 Use them.
2450 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2451 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2452 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2453 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2454 * frame.c (delete_frame): Remove outdated comment.
2455 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2456 USE_LISP_UNION_TYPE.
2457 (Fw32_unregister_hot_key): Likewise.
2458 (Fw32_toggle_lock_key): Likewise.
2459 * w32menu.c (add_menu_item): Likewise.
2460 (w32_menu_display_help): Use XIL instead of checking
2461 USE_LISP_UNION_TYPE.
2462 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2463 (init_heap): Likewise.
2464 * w32term.c (w32_read_socket): Update comment.
2465
1d3823c9
GM
24662012-06-13 Glenn Morris <rgm@gnu.org>
2467
c62ff706
GM
2468 * s/usg5-4-common.h, src/s/unixware.h:
2469 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2470
1d3823c9
GM
2471 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2472
bfe3e0a2
PE
24732012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2476 * alloc.c (make_number) [!defined make_number]:
2477 Remove, as lisp.h always defines this now.
2478 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2479 (roundup_size): Verify that it is a power of 2.
2480 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2481 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2482 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2483 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2484 USE_LSB_TAG now is always defined to be either 0 or 1.
2485 All uses changed.
2486 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2487 code works fine either way, and efficiency is not a concern here,
2488 as the union type is for debugging, not for production.
2489 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2490 Use an inline function on all platforms when using the union type,
2491 since this is simpler and 'static inline' can be used portably
2492 within Emacs now.
2493 (LISP_INITIALLY_ZERO): New macro.
2494 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2495 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2496
45fa9c0f
GM
24972012-06-12 Glenn Morris <rgm@gnu.org>
2498
b4492cba
GM
2499 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2500
2501 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2502
45fa9c0f
GM
2503 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2504 Move BROKEN_SIGIO to configure.
2505
2506 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2507 Move NO_TERMIO to configure.
2508
0e25d334
CY
25092012-06-12 Chong Yidong <cyd@gnu.org>
2510
2511 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2512 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2513 MagickExportImagePixels is undefined.
2514
43682bb6
PE
25152012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2516
2517 * image.c (imagemagick_load_image): Remove unused label.
2518
a9be7d2b
GM
25192012-06-11 Glenn Morris <rgm@gnu.org>
2520
2521 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2522 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2523 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2524 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2525
3017f87f
SM
25262012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2527
2528 * alloc.c (make_byte_code): New function.
2529 (Fmake_byte_code): Use it. Don't purify here.
2530 * lread.c (read1): Use it as well to avoid extra allocation.
2531
1b9b4cf4
CY
25322012-06-11 Chong Yidong <cyd@gnu.org>
2533
2534 * image.c (imagemagick_load_image): Implement transparency.
2535
95988fcf
AS
25362012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2537
2538 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2539 account for preceding backslashes. (Bug#11663)
2540
cd4eb164
CY
25412012-06-09 Chong Yidong <cyd@gnu.org>
2542
2543 * term.c: Support italics in capable terminals (Bug#9652).
2544 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2545 (turn_on_face): Output using TS_enter_italic_mode if available.
2546 Don't handle unused blinking and alt-charset cases.
2547 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2548 and tty_alt_charset_p cases.
2549 (tty_capable_p, init_tty): Support italics.
2550
2551 * termchar.h (struct tty_display_info): Add field for italics.
2552 Remove unused blink field.
2553
2554 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2555 Handle slant.
2556
2557 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2558 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2559 tty_alt_charset_p. Add tty_italic_p.
2560
ff88beb8
MA
25612012-06-09 Michael Albinus <michael.albinus@gmx.de>
2562
2563 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2564 dbus_type_is_basic if available.
2565 (xd_extract_signed, xd_extract_unsigned): Rename from
2566 extract_signed and extract_unsigned, respectively. Adapt callers.
2567
44286096
CY
25682012-06-09 Chong Yidong <cyd@gnu.org>
2569
1682701f
CY
2570 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2571
44286096
CY
2572 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2573 case (Bug#9752).
2574
d86feb17
PE
25752012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2576
2577 * xdisp.c (vmessage): Treat frame message as multibyte.
2578 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2579 would generate the diagnostic "Making \302\247 buffer-local while
2580 let-bound!".
2581
d5c20fe8
EZ
25822012-06-08 Eli Zaretskii <eliz@gnu.org>
2583
2584 * dispnew.c (showing_window_margins_p): Undo last change, which
2585 was done due to an inadvertent commit.
2586 (adjust_frame_glyphs_for_frame_redisplay): Do call
2587 showing_window_margins_p.
2588
513749ee
SM
25892012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2590
2591 * eval.c (Fmake_var_non_special): New primitive.
2592 (syms_of_eval): Defsubr it.
2593 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2594
d4a8f5c1
JB
25952012-06-08 Juanma Barranquero <lekktu@gmail.com>
2596
2597 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2598 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2599
8bbbc977
EZ
26002012-06-08 Eli Zaretskii <eliz@gnu.org>
2601
2602 * alloc.c (allocate_vectorlike): Fix last change.
2603
f3372c87
DA
26042012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2605
2606 Block-based vector allocation of small vectors.
2607 * lisp.h (struct vectorlike_header): New field `nbytes',
2608 adjust comment accordingly.
2609 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2610 to denote vector blocks. Adjust users (live_vector_p,
2611 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2612 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2613 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2614 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2615 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2616 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2617 (roundup_size): New constant.
2618 (struct vector_block): New data type.
2619 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2620 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2621 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2622 (sweep_vectors): New functions.
2623 (allocate_vectorlike): Return `zero_vector' as the only vector of
2624 0 items. Allocate new vector from block if vector size is less than
2625 or equal to VBLOCK_BYTES_MAX.
2626 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2627 (init_alloc_once): Add call to init_vectors.
2628
4f18a4ed
SM
26292012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2630
2631 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2632
86f158bc
PE
26332012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2634
2635 * doprnt.c (doprnt): Truncate multibyte char correctly.
2636 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2637 would mishandle a string argument "Xc" if X was a multibyte
2638 character of length 2: it would truncate after X's first byte
2639 rather than including all of X.
2640
c5cfcbe0
CY
26412012-06-06 Chong Yidong <cyd@gnu.org>
2642
2643 * buffer.c (word_wrap): Doc fix.
2644
c05cf390
PE
26452012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2646
2647 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2648
0c3461de
GM
26492012-06-03 Glenn Morris <rgm@gnu.org>
2650
2651 * xdisp.c (tool-bar-style): Doc fix.
2652
c71232db
UM
26532012-06-03 Ulrich Müller <ulm@gentoo.org>
2654
2655 * Makefile.in (PAXCTL): Define.
2656 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2657 binary via PaX flags if the paxctl utility is available.
2658 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2659 Restore PaX flags to their default. (Bug#11398)
2660
383f7350
CY
26612012-06-03 Chong Yidong <cyd@gnu.org>
2662
2663 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2664 buffer (Bug#11226).
2665
5f2c76c6
CY
26662012-06-03 Chong Yidong <cyd@gnu.org>
2667
2668 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2669 (note_mode_line_or_margin_highlight): If there is no help echo,
2670 use mode-line-default-help-echo. Handle the case where the mouse
2671 position is past the end of the mode line string.
2672
2673 * buffer.c (buffer_local_value_1): New function, split from
2674 Fbuffer_local_value; can return Qunbound.
2675 (Fbuffer_local_value): Use it.
2676 (Vmode_line_format): Docstring tweaks.
2677
773d47f6
PE
26782012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 * sysdep.c (system_process_attributes): Improve comment.
2681
f2d6a3df
SM
26822012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2683
2684 * keyboard.c: Export real-this-command to Elisp.
2685 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2686 and DEFVAR it. Update all users.
2687
63810350
PE
26882012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2689
7bd5c1f4
PE
2690 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2691
63810350
PE
2692 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2693 Convert pctcpu and pctmem to Lisp float properly.
2694 Let the compiler fold better, as 100.0/0x8000 is exact.
2695
a2821611
AS
26962012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2697
2698 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2699 cons_block.
2700
5fceba1d
PE
27012012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2702
2703 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2704
c98ff5dd
DA
27052012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2706
2707 For a 'struct window', replace some Lisp_Object fields to
2708 bitfields where appropriate, remove unused fields.
2709 * window.h (struct window): Remove unused 'last_mark_x' and
2710 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2711 change it's type from Lisp_Object to bitfield.
2712 Change type of 'force_start', 'optional_new_start',
2713 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2714 fields from Lisp_Object to bitfield. Adjust users accordingly.
2715
ca34e0be
PE
27162012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2717
2718 Pacify gcc -Wdouble-precision when using Xaw.
2719 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2720 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2721 Use 'float' consistently, rather than 'float' in most places
2722 and 'double' in a couple of places.
2723
efc00ab1 27242012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2725
2726 * xdisp.c (handle_stop): Detect whether we have overlay strings
2727 loaded by testing it->current.overlay_string_index to be
2728 non-negative, instead of checking whether n_overlay_strings is
2729 positive. (Bug#11587)
2730
efc00ab1 27312012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2732
2733 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2734
2735 * doc.c (Fsubstitute_command_keys): Doc fix.
2736
efc00ab1 27372012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2738
2739 * search.c (search_buffer): Remove calls to
2740 r_alloc_inhibit_buffer_relocation, as it is now called by
2741 maybe_unify_char, which was the cause of relocation of buffer text
2742 in bug#11519.
2743
efc00ab1 27442012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2745
2746 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2747 for the duration of call to load_charset, to avoid problems with
2748 callers of maybe_unify_char that access buffer text through C
2749 pointers.
2750
2751 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2752 decrement the inhibition flag, instead of just setting or
2753 resetting it.
2754
ba93a187
PE
27552012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2756
2757 Remove obsolete '#define static' cruft.
2758 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2759 This #undef was "temporary" in 2000; it is no longer needed
2760 now that '#define static' has gone away.
2761 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2762 (gray_bitmap_bits): Remove; no longer needed.
2763 All uses replaced with definiens.
2764 * xterm.c: Include "bitmaps/gray.xbm".
2765
9e4bf381
PE
27662012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 Clean up __executable_start, monstartup when --enable-profiling.
2769 The following changes affect the code only when profiling.
2770 * dispnew.c (__executable_start): Rename from safe_bcopy.
2771 Define only on platforms that need it.
2772 * emacs.c: Include <sys/gmon.h> when profiling.
2773 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2774 (__executable_start): Remove decl, since lisp.h does it now.
2775 (safe_bcopy): Remove decl; no longer has that name.
2776 (main): Coalesce #if into single bit of code, for simplicity.
2777 Cast pointers to uintptr_t, since standard libraries want integers
2778 and not pointers.
2779 * lisp.h (__executable_start): New decl.
2780
32d72c2f
GM
27812012-05-31 Glenn Morris <rgm@gnu.org>
2782
2783 * image.c (Fimagemagick_types): Doc fix.
2784
baac5bc7
JM
27852012-05-30 Jim Meyering <meyering@redhat.com>
2786
2787 * callproc.c (Fcall_process_region): Include directory component
2788 in mkstemp error message (Bug#11586).
2789
72cb32cf
PE
27902012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2791
2792 * alloc.c, lisp.h (make_pure_vector): Now static.
2793
61b108cc
SM
27942012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2795
2796 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2797 Move to byte-run.el.
2798 (Fautoload): Do the hash-doc more carefully.
2799 * data.c (Fdefalias): Purify definition, except for keymaps.
2800 (Qdefun): Move from eval.c.
2801 * lisp.h (Qdefun): Remove.
2802 * lread.c (read1): Tiny simplification.
2803
471fe23d
TN
28042012-05-29 Troels Nielsen <bn.troels@gmail.com>
2805
934f3f58 2806 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2807 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2808 Bug#9642, but explicitly check that the buffer the overlay would
2809 be moved to is live and rearrange lines to make sure that errors
2810 will not put the overlay in an inconsistent state.
2811 (Fdelete_overlay): Cosmetics.
2812
85d0efd1
EZ
28132012-05-28 Eli Zaretskii <eliz@gnu.org>
2814
2815 * w32term.c (my_bring_window_to_top): New function.
2816 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2817 could be different from the original one.
2818 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2819 (Bug#11513)
2820
2821 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2822 by calling BringWindowToTop.
2823
2824 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2825 (WM_EMACS_END): Increase by one.
2826
da92a98c
PE
28272012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2828
2829 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2830 This avoids undefined behavior that might cause the eassert
2831 to not catch an out-of-range value.
2832
74d1f848
JB
28332012-05-28 Juanma Barranquero <lekktu@gmail.com>
2834
2835 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2836 Update dependencies.
2837
9e1a06fc
EZ
28382012-05-27 Eli Zaretskii <eliz@gnu.org>
2839
2840 * bidi.c (bidi_mirror_char): Fix last change.
2841
f3dd7312
AS
28422012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2843
2844 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2845 when referring to sectname field in printf format.
2846
81899c91
PE
28472012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2848
57b81a9f
PE
2849 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2850 Only r_alloc_inhibit_buffer_relocation needed to be added;
2851 the others were already declared.
2852
81899c91
PE
2853 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2854 before checking whether it's out of range. Put the check inside
2855 eassert. See
2856 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2857
33017faf 28582012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2859
2860 * callproc.c (Fcall_process): Restore a line that was accidentally
2861 commented out in the 2011-02-13 change (bug#11547).
2862
33017faf 28632012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2864
2865 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2866 defined on ralloc.c.
2867
2868 * buffer.c [REL_ALLOC]: Remove prototypes of
2869 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2870 they are now on lisp.h.
2871
2872 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2873
2874 * search.c (search_buffer): Use it to inhibit relocation of buffer
2875 text while re_search_2 is doing its job, because re_search_2 is
2876 passed C pointers to buffer text. (Bug#11519)
2877
23415acf
EZ
2878 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2879 Update value to 24.
2880
44e27368
EZ
2881 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2882 state after an additional call to move_it_in_display_line_to, keep
2883 the values of it->max_ascent and it->max_descent found for the
2884 entire line.
2885 (pos_visible_p): Revert the comparison against bottom_y to what it
2886 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2887 (Bug#11464)
2888
c1892f11
PE
28892012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 Fix coding-related core dumps with gcc -ftrapv.
2892 The code was computing A - B, where A and B are pointers, and B is
2893 random garbage. This can lead to core dumps on platforms that
2894 have special pointer registers, and it also leads to core dumps on
2895 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2896 A - B only when B is initialized properly.
2897 * coding.c (coding_set_source, coding_set_destination): Return void.
2898 (coding_change_source, coding_change_destinations): New functions,
2899 with the old behaviors of coding_set_source and coding_set_destination.
2900 All callers that need an offset changed to use these new functions.
2901
eb7afdad
GM
29022012-05-26 Glenn Morris <rgm@gnu.org>
2903
2904 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2905
f12fdf02
EZ
29062012-05-26 Eli Zaretskii <eliz@gnu.org>
2907
53a63be6 2908 Extend mouse support on W32 text-mode console.
61b108cc
SM
2909 * xdisp.c (draw_row_with_mouse_face):
2910 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2911
eb3f6f01 2912 * w32console.c: Include window.h.
61b108cc
SM
2913 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2914 New functions.
eb3f6f01
EZ
2915 (initialize_w32_display): Initialize mouse-highlight data.
2916
53a63be6
EZ
2917 * w32inevt.c: Include termchar.h and window.h.
2918 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2919 moves, call note_mouse_highlight. If help_echo changed, call
2920 gen_help_event to produce help-echo message in the echo area.
2921 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2922 highlight info.
2923
4cfd81f6
PE
29242012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2925
2926 * lread.c (read1): Simplify slightly to avoid an overflow warning
2927 with GCC 4.7.0 on x86-64.
2928
4446092a
EZ
29292012-05-26 Eli Zaretskii <eliz@gnu.org>
2930
2931 * bidi.c (bidi_mirror_char): Revert last change: an int is
2932 definitely wide enough here.
2933
42b2a986 29342012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2935
42b2a986 2936 Fix integer width and related bugs (Bug#9874).
eb106a49 2937 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2938 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2939 (string_bytes, check_sblock, allocate_string_data):
2940 (compact_small_strings, Fmake_bool_vector, make_string)
2941 (make_unibyte_string, make_multibyte_string)
2942 (make_string_from_bytes, make_specified_string)
2943 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2944 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2945 (mark_vectorlike):
2946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2947 (allocate_pseudovector):
2948 Use int, not EMACS_INT, where int is wide enough.
2949 (inhibit_garbage_collection, Fgarbage_collect):
2950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2951 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2952 int might not be wide enough.
2953 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2954 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2955 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2956 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2957 (bidi_level_of_next_char, bidi_move_to_visually_next):
2958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2959 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2960 (Fkill_buffer, Fset_buffer_major_mode)
2961 (advance_to_char_boundary, Fbuffer_swap_text)
2962 (Fset_buffer_multibyte, overlays_at, overlays_in)
2963 (overlay_touches_p, struct sortvec, record_overlay_string)
2964 (overlay_strings, recenter_overlay_lists)
2965 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2966 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2967 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2968 (Foverlay_recenter, last_overlay_modification_hooks_used)
2969 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2971 (validate_region): Omit unnecessary test for b <= e,
2972 since that's guaranteed by the previous test.
d311d28c
PE
2973 (adjust_overlays_for_delete): Avoid pos + length overflow.
2974 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2975 (report_overlay_modification):
2976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2977 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2978 Omit pointer cast, which isn't needed anyway, and doesn't work
2979 after the EMACS_INT -> ptrdiff_t change.
02481186 2980 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2981 * buffer.h: Adjust decls to match defn changes elsewhere.
2982 (struct buffer_text, struct buffer):
2983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2984 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2985 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2986 not int, to avoid needless 32-bit limit on 64-bit hosts.
2987 (exec_byte_code): Use tighter memory-full test, one that checks
2988 for alloca overflow. Don't compute the address of the object just
2989 before an array, as that's not portable. Use EMACS_INT, not
2990 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2991 * callint.c (Fcall_interactively):
2992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2993 * callproc.c (call_process_kill, Fcall_process):
2994 Don't assume pid_t fits into an Emacs fixnum.
2995 (call_process_cleanup, Fcall_process, child_setup):
2996 Don't assume pid_t fits into int.
2997 (call_process_cleanup, Fcall_process, delete_temp_file)
2998 (Fcall_process_region):
2999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3000 (Fcall_process): Simplify handling of volatile integers.
3001 Use int, not EMACS_INT, where int will do.
3002 * casefiddle.c (casify_object, casify_region, operate_on_word)
3003 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3005 (casify_object): Avoid integer overflow when overallocating buffer.
3006 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3007 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3008 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3009 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3010 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3011 integers are now checked earlier. All uses replaced with XINT.
3012 (ccl_driver):
3013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3014 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3015 (ccl_driver, Fregister_code_conversion_map):
3016 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3017 (resolve_symbol_ccl_program): Check that vector header is in range.
3018 Always copy the vector, so that we can check its contents reliably
3019 now rather than having to recheck each instruction as it's being
3020 executed. Check that vector words fit in 'int'.
3021 (ccl_get_compiled_code, Fregister_ccl_program)
3022 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3023 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3024 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3025 contents are in range.
3026 (Fccl_execute_on_string): Check that status is in range.
3027 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3028 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3029 Accept and return EMACS_INT, not int, because callers can pass values
3030 out of 'int' range.
3031 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3032 (multibyte_chars_in_text, parse_str_as_multibyte)
3033 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3034 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3035 (string_escape_byte8, Fget_byte):
3036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3037 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3038 avoid mishandling large integers.
3039 * character.h: Adjust decls to match defn changes elsewhere.
3040 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3041 (Ffind_charset_region):
3042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3043 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3044 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3045 Don't assume fixnum fits in int.
d311d28c
PE
3046 (load_charset_map_from_vector, Fmap_charset_chars):
3047 Remove now-unnecessary CHECK_NATNUMs.
3048 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3049 Don't rely on undefined behavior with signed left shift overflow.
3050 Don't assume unsigned int fits into fixnum, or that fixnum fits
3051 into unsigned int. Don't require max_code to be a valid fixnum;
3052 that's not true for gb10830 4-byte on a 32-bit host. Allow
3053 invalid_code to be a cons, for the same reason. Require code_offset
3054 to be a character. Avoid int overflow if max_char is close
3055 to INT_MAX.
3056 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3057 this is intended anyway and avoids some undefined behavior.
3058 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3059 INDEX_TO_CODE_POINT, as that's what it expects.
3060 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3061 * charset.h (DECODE_CHAR): Return int, not unsigned;
3062 this is what was intended anyway, and it avoids undefined behavior.
3063 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3064 integer-overflow issues.
3065 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3066 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3067 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3068 * chartab.c (Fmake_char_table, Fset_char_table_range)
3069 (uniprop_get_decoder, uniprop_get_encoder):
3070 Don't assume fixnum fits in int.
3071 * cmds.c (move_point): New function, that does the gist of
3072 Fforward_char and Fbackward_char, but does so while checking
3073 for integer overflow more accurately.
c96e5d6a 3074 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3075 (Fforward_line, Fend_of_line, internal_self_insert)
3076 (internal_self_insert):
3077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3078 Fix a FIXME, by checking for integer overflow when calculating
3079 target_clm and actual_clm.
3080 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3081 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3082 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3083 (coding_alloc_by_making_gap, alloc_destination)
3084 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3085 (encode_coding_utf_16, detect_coding_emacs_mule)
3086 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3087 (detect_coding_iso_2022, decode_coding_iso_2022)
3088 (encode_invocation_designation, encode_designation_at_bol)
3089 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3090 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3091 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3092 (encode_coding_ccl, encode_coding_raw_text)
3093 (detect_coding_charset, decode_coding_charset)
3094 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3095 (produce_composition, produce_charset, produce_annotation)
3096 (decode_coding, handle_composition_annotation)
3097 (handle_charset_annotation, consume_chars, decode_coding_gap)
3098 (decode_coding_object, encode_coding_object, detect_coding_system)
3099 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3100 (code_convert_region, code_convert_string)
8f50130c
PE
3101 (Fdefine_coding_system_internal)
3102 (coding_set_source, coding_set_destination):
d311d28c
PE
3103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3104 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3105 (Fdefine_coding_system_internal):
3106 Don't assume fixnums fit in int.
3107 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3108 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3109 (Funencodable_char_position, Fcheck_coding_systems_region)
3110 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3112 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3113 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3114 Don't access memory outside of the args array.
d311d28c 3115 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3116 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3117 result of ENCODE_CHAR.
d311d28c
PE
3118 * coding.h: Adjust decls to match defn changes elsewhere.
3119 (struct coding_system):
3120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3121 * composite.c (get_composition_id, find_composition)
3122 (run_composition_function, update_compositions)
3123 (compose_text, composition_gstring_put_cache)
3124 (composition_gstring_p, composition_gstring_width)
3125 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3126 (composition_compute_stop_pos, composition_reseat_it)
3127 (composition_update_it, struct position_record)
3128 (find_automatic_composition, composition_adjust_point)
3129 (Fcomposition_get_gstring, Ffind_composition_internal):
3130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3131 (update_compositions):
3132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3133 * composite.h: Adjust decls to match defn changes elsewhere.
3134 (struct composition):
3135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3136 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3137 Do not attempt to compute the address of the object just before a
3138 buffer; this is not portable.
3139 (Faref, Faset):
3140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3141 (Faset): Use int, not EMACS_INT, where int is wide enough.
3142 (Fstring_to_number): Don't assume fixnums fit in int.
3143 (Frem): Don't assume arg is nonnegative.
3144 * dbusbind.c (xd_append_arg): Check for integers out of range.
3145 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3146 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3147 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3148 (xd_get_connection_references): Return ptrdiff_t, not int.
3149 All uses changed.
3150 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3151 (xd_read_message_1):
3152 Use int, not unsigned, where the dbus API uses int.
3153 (Fdbus_message_internal): Don't overflow mtype.
3154 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3155 * dired.c (directory_files_internal, file_name_completion, scmp)
3156 (file_name_completion_stat):
3157 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3158 (file_name_completion): Don't overflow matchcount.
3159 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3160 * dispextern.h: Adjust decls to match defn changes elsewhere.
3161 (struct text_pos, struct glyph, struct bidi_saved_info)
3162 (struct bidi_string_data, struct bidi_it, struct composition_it)
3163 (struct it):
3164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3165 (struct display_pos, struct composition_it, struct it):
3166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3167 * dispnew.c (increment_matrix_positions)
3168 (increment_row_positions, mode_line_string)
3169 (marginal_area_string):
3170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3171 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3173 (duration_to_sec_usec): New function, to check for overflow better.
3174 (Fsleep_for, sit_for): Use it.
3175 * doc.c (get_doc_string, store_function_docstring):
3176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3177 (get_doc_string, Fsnarf_documentation):
3178 Use int, not EMACS_INT, where int is wide enough.
3179 (get_doc_string):
3180 Use SAFE_ALLOCA, not alloca.
3181 Check for overflow when converting EMACS_INT to off_t.
3182 * doprnt.c (doprnt):
3183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3184 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3185 Don't assume uid_t fits into fixnum.
3186 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3187 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3188 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3189 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3190 (general_insert_function)
3191 (Finsert_char, make_buffer_string, make_buffer_string_both)
3192 (update_buffer_properties, Fbuffer_substring)
3193 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3194 (Fsubst_char_in_region, check_translation)
3195 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3196 (transpose_markers, Ftranspose_regions):
3197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3198 (clip_to_bounds): Move to lisp.h as an inline function).
3199 (Fconstrain_to_field): Don't assume integers are nonnegative.
3200 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3201 (Fsubst_char_in_region, Fsave_restriction):
3202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3203 (Femacs_pid): Don't assume pid_t fits into fixnum.
3204 (lo_time): Use int, not EMACS_INT, when int suffices.
3205 (lisp_time_argument): Check for usec out of range.
3206 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3207 (Fuser_login_name, Fuser_full_name): Signal an error
3208 if a uid argument is out of range, rather than relying on
3209 undefined behavior.
c8d5c857
PE
3210 (Fformat_time_string): Remove now-unnecessary check.
3211 lisp_time_argument checks for out-of-range usec now.
243e0530 3212 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3213 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3214 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3215 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3216 (init_cmdargs, Fdump_emacs):
3217 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3218 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3219 the bottom (typically) 32 bits of the fixnum.
3220 * eval.c (specpdl_size, call_debugger):
3221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3222 (when_entered_debugger, Fbacktrace_debug):
3223 Don't assume fixnum can fit in int.
3224 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3225 the object just before a buffer; this is not portable.
3226 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3227 (grow_specpdl, unbind_to):
3228 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3229 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3230 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3231 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3232 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3233 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3235 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3236 (a_write, e_write):
3237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3238 (Fcopy_file, non_regular_nbytes, read_non_regular)
3239 (Finsert_file_contents):
3240 Use int, not EMACS_INT, where int is wide enough.
3241 (READ_BUF_SIZE): Verify that it fits in int.
3242 (Finsert_file_contents): Check that counts are in proper range,
3243 rather than assuming fixnums fit into ptrdiff_t etc.
3244 Don't assume fixnums fit into int.
125b3835 3245 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3246 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3247 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3248 (string_char_to_byte, string_byte_to_char)
3249 (string_make_multibyte, string_to_multibyte)
3250 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3251 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3252 (substring_both, Fdelete, internal_equal, Ffillarray)
3253 (Fclear_string, mapcar1)
3254 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3255 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3256 (larger_vector, make_hash_table, maybe_resize_hash_table)
3257 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3258 (Fmaphash, secure_hash):
3259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3260 (concat): Check for string index and length overflow.
3261 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3262 (Frequire):
3263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3264 (larger_vector): New API (vec, incr_min, size_max) replaces old
3265 one (vec, new_size, init). This catches size overflow.
3266 INIT was removed because it was always Qnil.
3267 All callers changed.
3268 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3269 the upper bound on a hash table index size.
3270 (make_hash_table, maybe_resize_hash_table): Use it.
3271 (secure_hash): Computer start_byte and end_byte only after
3272 they're known to be in ptrdiff_t range.
3273 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3274 (Ffont_get_glyphs, Ffont_at):
3275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3276 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3277 (Flist_fonts, Fopen_font):
3278 Don't assume fixnum can fit in int.
3279 (check_gstring): Don't assume index can fit in int.
3280 (font_match_p): Check that fixnum is a character, not a nonnegative
3281 fixnum, since the later code needs to stuff it into an int.
3282 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3283 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3284 conversion overflow issues.
3285 (Fopen_font): Check for integer out of range.
3286 (Ffont_get_glyphs): Don't assume index can fit in int.
3287 * font.h: Adjust decls to match defn changes elsewhere.
3288 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3289 integer overflow.
3290 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3291 printmax_t, where ptrdiff_t is wide enough.
3292 (Finternal_char_font):
3293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3294 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3295 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3296 (Fset_frame_position, x_set_frame_parameters)
3297 (x_set_line_spacing, x_set_border_width)
3298 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3299 Check that fixnums are in proper range for system types.
3300 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3302 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3303 Use SAFE_ALLOCA_LISP, not alloca.
3304 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3305 intptr_t is wide enough.
3306 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3307 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3308 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3309 Check for fixnum out of range.
3310 * ftfont.c (ftfont_list): Don't assume index fits in int.
3311 Check that fixnums are in proper range for system types.
3312 (ftfont_shape_by_flt):
3313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3314 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3316 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3317 Check that fixnums are in proper range for system types.
3318 * gnutls.h: Adjust decls to match defn changes elsewhere.
3319 * gtkutil.c (xg_dialog_run):
3320 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3321 (update_frame_tool_bar):
3322 Check that fixnums are in proper range for system types.
3323 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3324 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3325 * indent.c (last_known_column, last_known_column_point):
3326 (current_column_bol_cache):
3327 (skip_invisible, current_column, check_display_width):
3328 (check_display_width, scan_for_column, current_column_1)
3329 (Findent_to, Fcurrent_indentation, position_indentation)
3330 (indented_beyond_p, Fmove_to_column, compute_motion):
3331 (Fcompute_motion, Fvertical_motion):
3332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3333 (last_known_column_modified): Use EMACS_INT, not int.
3334 (check_display_width):
3335 (Fcompute_motion):
3336 Check that fixnums and floats are in proper range for system types.
3337 (compute_motion): Don't assume index or fixnum fits in int.
3338 (compute_motion, Fcompute_motion):
3339 Use int, not EMACS_INT, when it is wide enough.
3340 (vmotion): Omit local var start_hpos that is always 0; that way
3341 we don't need to worry about overflow in expressions involving it.
3342 * indent.h: Adjust decls to match defn changes elsewhere.
3343 (struct position):
3344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3345 Use int, not EMACS_INT, where int is wide enough.
3346 Remove unused members ovstring_chars_done and tab_offset;
3347 all uses removed.
3348 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3349 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3350 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3351 (make_gap, copy_text, insert, insert_and_inherit)
3352 (insert_before_markers, insert_before_markers_and_inherit)
3353 (insert_1, count_combining_before, count_combining_after)
3354 (insert_1_both, insert_from_string)
3355 (insert_from_string_before_markers, insert_from_string_1)
3356 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3357 (adjust_after_replace, adjust_after_insert, replace_range)
3358 (replace_range_2, del_range, del_range_1, del_range_byte)
3359 (del_range_both, del_range_2, modify_region)
3360 (prepare_to_modify_buffer, signal_before_change)
3361 (signal_after_change, Fcombine_after_change_execute):
3362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3363 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3364 (balance_an_interval, split_interval_right, split_interval_left)
3365 (find_interval, next_interval, update_interval)
3366 (adjust_intervals_for_insertion, delete_node, delete_interval)
3367 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3368 (static_offset_intervals, offset_intervals)
3369 (merge_interval_right, merge_interval_left, make_new_interval)
3370 (graft_intervals_into_buffer, temp_set_point_both)
3371 (temp_set_point, set_point, adjust_for_invis_intang)
3372 (set_point_both, move_if_not_intangible, get_property_and_range)
3373 (get_local_map, copy_intervals, copy_intervals_to_string)
3374 (compare_string_intervals, set_intervals_multibyte_1):
3375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3376 * intervals.h: Adjust decls to match defn changes elsewhere.
3377 (struct interval):
3378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3379 * keyboard.c (this_command_key_count, this_single_command_key_start)
3380 (before_command_key_count, before_command_echo_length, echo_now)
3381 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3382 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3383 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3384 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3386 (last_non_minibuf_size, last_point_position, echo_truncate)
3387 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3388 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3389 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3390 (stuff_buffered_input):
3391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3392 (last_auto_save, command_loop_1, read_char):
3393 Use EMACS_INT, not int, to avoid integer overflow.
3394 (record_char): Avoid overflow in total_keys computation.
3395 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3396 * keyboard.h: Adjust decls to match defn changes elsewhere.
3397 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3398 (Fkey_description, Fdescribe_vector, Flookup_key):
3399 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3400 (click_position): New function, to check that positions are in range.
3401 (Fcurrent_active_maps):
3402 (describe_command):
3403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3404 (Faccessible_keymaps, Fkey_description):
3405 (preferred_sequence_p):
3406 Don't assume fixnum can fit into int.
3407 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3408 Check for integer overflow in size calculations.
3409 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3410 avoid mishandling large integers.
3411 * lisp.h: Adjust decls to match defn changes elsewhere.
3412 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3413 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3414 (struct Lisp_Marker):
3415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3416 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3417 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3418 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3419 All callers changed.
3420 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3421 Assume the arg has valid form, since it always does.
3422 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3423 unsigned integer system type.
3424 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3425 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3426 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3427 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3428 (duration_to_sec_usec): New decl.
3429 * lread.c (read_from_string_index, read_from_string_index_byte)
3430 (read_from_string_limit, readchar, unreadchar, openp)
3431 (read_internal_start, read1, oblookup):
3432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3433 (Fload, readevalloop, Feval_buffer, Feval_region):
3434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3435 (openp): Check for out-of-range argument to 'access'.
3436 (read1): Use int, not EMACS_INT, where int is wide enough.
3437 Don't assume fixnum fits into int.
6efdadfd 3438 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3439 (read_filtered_event): Use duration_to_sec_usec
3440 to do proper overflow checking on durations.
d311d28c
PE
3441 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3442 in size calculation.
3443 (Fexecute_kbd_macro):
3444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3445 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3446 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3447 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3448 (set_marker_both, set_marker_restricted_both, marker_position)
3449 (marker_byte_position, Fbuffer_has_markers_at):
3450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3451 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3452 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3453 It now merely ensures that the menu is large enough, without
3454 necessarily growing it, as this avoids some integer overflow issues.
3455 All callers changed.
3456 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3458 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3459 Use SAFE_ALLOCA_LISP, not alloca.
3460 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3461 to EMACS_INT. Check that fixnums are in proper range for system types.
3462 * minibuf.c (minibuf_prompt_width, string_to_object)
3463 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3464 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3466 (get_minibuffer, read_minibuf_unwind):
3467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3468 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3469 this simplifies overflow checking. All callers changed.
3470 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3471 (Ftest_completion):
3472 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3473 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3474 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3475 Check that fixnums are in proper range for system types.
3476 (Fx_create_frame, Fx_show_tip):
3477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3478 * nsfont.m (ns_findfonts, nsfont_list_family):
3479 Don't assume fixnum fits in long.
3480 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3482 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3483 wide enough.
17fdb222 3484 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3486 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3487 (PRINTDECLARE, PRINTPREPARE):
3488 (strout, print_string):
3489 (print, print_preprocess, print_check_string_charset_prop)
3490 (print_object):
3491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3492 (PRINTDECLARE):
3493 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3495 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3496 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3497 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3498 (print_error_message): Use SAFE_ALLOCA, not alloca.
3499 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3500 (print_depth, new_backquote_output, print_number_index):
3501 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3502 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3503 (Fset_process_window_size, Fformat_network_address)
3504 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3505 (sigchld_handler):
d311d28c 3506 Check that fixnums are in proper range for system types.
d44287d4 3507 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3508 Check for process-ids out of pid_t range rather than relying on
3509 undefined behavior.
e4d81efc 3510 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3511 (Fformat_network_address, read_process_output, send_process)
3512 (Fprocess_send_region, status_notify):
3513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3514 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3515 (wait_reading_process_output, read_process_output, exec_sentinel):
3516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3517 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3518 (Faccept_process_output): Use duration_to_sec_usec to do proper
3519 overflow checking on durations.
dde14581
PE
3520 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3521 Don't assume pid_t fits in int.
02481186
PE
3522 * process.h (struct Lisp_Process): Members tick and update_tick
3523 are now of type EMACS_INT, not int.
b62b53e8
PE
3524 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3525 configured --with-wide-int.
d311d28c
PE
3526 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3527 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3528 * search.c (looking_at_1, string_match_1):
3529 (fast_string_match, fast_c_string_match_ignore_case)
3530 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3531 (scan_newline, find_before_next_newline, search_command)
3532 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3533 (set_search_regs, wordify):
3534 (Freplace_match):
3535 (Fmatch_data):
3536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3537 (string_match_1, search_buffer, set_search_regs):
3538 (Fmatch_data):
3539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3540 (wordify): Check for overflow in size calculation.
3541 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3542 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3543 Check that fixnums are in proper range for system types.
3544 * sound.c (struct sound_device)
3545 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3547 (Fplay_sound_internal):
3548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3549 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3550 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3551 (Fparse_partial_sexp):
3552 Don't assume fixnums can fit in int.
3553 (struct lisp_parse_state, find_start_pos, find_start_value)
3554 (find_start_value_byte, find_start_begv)
3555 (update_syntax_table, char_quoted, dec_bytepos)
3556 (find_defun_start, prev_char_comend_first, back_comment):
3557 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3558 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3560 (Finternal_describe_syntax_value): Check that match_lisp is a
3561 character, not an integer, since the code stuffs it into int.
3562 (scan_words, scan_sexps_forward):
3563 Check that fixnums are in proper range for system types.
3564 (Fforward_word):
3565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3566 (scan_sexps_forward):
3567 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3568 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3569 * syntax.h: Adjust decls to match defn changes elsewhere.
3570 (struct gl_state_s):
3571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3572 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3573 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3574 * sysdep.c (wait_for_termination_1, wait_for_termination)
3575 (interruptible_wait_for_termination, mkdir):
3576 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3577 (emacs_read, emacs_write):
3578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3579 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3580 and double all fit in int.
d311d28c
PE
3581 * term.c (set_tty_color_mode):
3582 Check that fixnums are in proper range for system types.
3583 * termhooks.h (struct input_event):
3584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3585 * textprop.c (validate_interval_range, interval_of)
3586 (Fadd_text_properties, set_text_properties_1)
3587 (Fremove_text_properties, Fremove_list_of_text_properties)
3588 (Ftext_property_any, Ftext_property_not_all)
3589 (copy_text_properties, text_property_list, extend_property_ranges)
3590 (verify_interval_modification):
3591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3592 (Fnext_single_char_property_change)
3593 (Fprevious_single_char_property_change):
3594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3595 (copy_text_properties):
3596 Check for integer overflow in index calculation.
d311d28c
PE
3597 * undo.c (last_boundary_position, record_point, record_insert)
3598 (record_delete, record_marker_adjustment, record_change)
3599 (record_property_change):
3600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3601 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3603 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3604 (Fx_hide_tip, Fx_file_dialog):
3605 * w32menu.c (set_frame_menubar):
3606 Use ptrdiff_t, not int, for consistency with rest of code.
3607 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3608 (select_window, Fdelete_other_windows_internal)
3609 (window_scroll_pixel_based, window_scroll_line_based)
3610 (Frecenter, Fset_window_configuration):
3611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3612 (Fset_window_hscroll, run_window_configuration_change_hook)
3613 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3614 (Fscroll_other_window, Frecenter):
d311d28c
PE
3615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3616 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3617 Don't assume fixnum fits in int.
3618 (Fset_window_scroll_bars):
3619 Check that fixnums are in proper range for system types.
3620 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3621 (string_pos, c_string_pos, number_of_chars, init_iterator)
3622 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3623 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3624 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3625 (face_before_or_after_it_pos, handle_invisible_prop)
3626 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3627 (display_prop_intangible_p, string_buffer_position_lim)
3628 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3629 (get_overlay_strings_1, get_overlay_strings)
3630 (iterate_out_of_display_property, forward_to_next_line_start)
3631 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3632 (get_next_display_element, set_iterator_to_next)
3633 (get_visually_first_element, compute_stop_pos_backwards)
3634 (handle_stop_backwards, next_element_from_buffer)
3635 (move_it_in_display_line_to, move_it_in_display_line)
3636 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3637 (add_to_log, message_dolog, message_log_check_duplicate)
3638 (message2, message2_nolog, message3, message3_nolog
3639 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3640 (current_message_1, truncate_echo_area, truncate_message_1)
3641 (set_message, set_message_1, store_mode_line_noprop)
3642 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3643 (text_outside_line_unchanged_p, check_point_in_composition)
3644 (reconsider_clip_changes)
3645 (redisplay_internal, set_cursor_from_row, try_scrolling)
3646 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3647 (redisplay_window, find_last_unchanged_at_beg_row)
3648 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3649 (trailing_whitespace_p, find_row_edges, display_line)
3650 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3651 (display_mode_element, store_mode_line_string)
3652 (pint2str, pint2hrstr, decode_mode_spec)
3653 (display_count_lines, display_string, draw_glyphs)
3654 (x_produce_glyphs, x_insert_glyphs)
3655 (rows_from_pos_range, mouse_face_from_buffer_pos)
3656 (fast_find_string_pos, mouse_face_from_string_pos)
3657 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3659 (safe_call, init_from_display_pos, handle_fontified_prop)
3660 (handle_single_display_spec, load_overlay_strings)
3661 (with_echo_area_buffer, setup_echo_area_for_printing)
3662 (display_echo_area, echo_area_display)
3663 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3664 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3665 (redisplay_window, dump_glyph_row, display_mode_line)
3666 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3667 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3669 (handle_single_display_spec, build_desired_tool_bar_string)
3670 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3671 (get_specified_cursor_type):
3672 Check that fixnums are in proper range for system types.
3673 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3674 (Flookup_image_map):
3675 Don't assume fixnums fit in int.
3676 (compare_overlay_entries):
3677 Avoid mishandling comparisons due to subtraction overflow.
3678 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3679 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3680 (handle_tool_bar_click):
3681 Use int, not unsigned, since we prefer signed and the signedness
3682 doesn't matter here.
3683 (get_next_display_element, next_element_from_display_vector):
3684 Use int, not EMACS_INT, when int is wide enough.
3685 (start_hourglass): Use duration_to_sec_usec to do proper
3686 overflow checking on durations.
3687 * xfaces.c (Fbitmap_spec_p):
3688 Check that fixnums are in proper range for system types.
3689 (compare_fonts_by_sort_order):
3690 Avoid mishandling comparisons due to subtraction overflow.
3691 (Fx_family_fonts, realize_basic_faces):
3692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3693 (Fx_family_fonts):
3694 Don't assume fixnum fits in int.
3695 Use SAFE_ALLOCA_LISP, not alloca.
3696 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3697 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3698 (face_at_buffer_position, face_for_overlay_string)
3699 (face_at_string_position):
3700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3701 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3702 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3703 (Fx_show_tip):
3704 Check that fixnums are in proper range for system types.
3705 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3706 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3707 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3708 (Fx_change_window_property): Don't assume fixnums fit in int.
3709 * xfont.c (xfont_chars_supported):
3710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3711 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3712 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3714 * xml.c (parse_region):
3715 * xrdb.c (magic_file_p):
3716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3717 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3718 (x_get_local_selection, x_reply_selection_request)
3719 (x_handle_selection_request, wait_for_property_change):
3720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3721 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3722 short is wide enough.
3723 (x_send_client_event): Don't assume fixnum fits in int.
3724 * xterm.c (x_x_to_emacs_modifiers):
3725 Don't assume EMACS_INT overflows nicely into int.
3726 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3727 may come from Lisp.
3728 (handle_one_xevent): NATNUMP can eval its arg twice.
3729 (x_connection_closed):
3730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3731 * xterm.h: Adjust decls to match defn changes elsewhere.
3732 (struct scroll_bar): Use struct vectorlike_header
3733 rather than rolling our own approximation.
3734 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3735
c6574eb5
GM
37362012-05-25 Glenn Morris <rgm@gnu.org>
3737
3738 * lisp.mk (lisp): Update for more files being compiled now.
3739
e8d32c7e
SM
37402012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3741
48def666
SM
3742 * lread.c: Remove `read_pure' which makes no difference.
3743 (read_pure): Remove var.
3744 (unreadpure): Remove function.
3745 (readevalloop): Don't call read_list with -1 flag.
3746 (read1, read_vector): Don't test read_pure any more.
3747 (read_list): Simplify.
3748
e8d32c7e
SM
3749 * fileio.c, character.h: Minor style tweaks.
3750
4b2addb7
DA
37512012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3752
3753 * window.h (clip_changed): Remove useless declaration.
3754
584461b2
JB
37552012-05-22 Juanma Barranquero <lekktu@gmail.com>
3756
3757 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3758 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3759
34374650
PE
37602012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3761
3762 Remove src/m/*.
3763 This directory predates autoconf and is no longer needed nowadays.
3764 Move its few remaining bits of functionality to where they're needed.
3765 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3766 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3767 * m/template.h: Remove.
3768 * Makefile.in (M_FILE): Remove. All uses removed.
3769 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3770 * lisp.h (USE_LSB_TAG):
3771 * mem-limits.h (EXCEEDS_LISP_PTR):
3772 Use VAL_MAX, not VALBITS, in #if.
3773 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3774 (EMACS_UINT): Define unconditionally now.
3775 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3776 (BITS_PER_EMACS_INT): New constants, replacing
3777 what used to be in config.h, but not useful in #if.
3778 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3779 define them any more.
3780 (VAL_MAX): New macro.
3781 (VALMASK): Use it.
3782 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3783 BITS_PER_EMACS_INT, in #if.
3784 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3785 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3786 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3787 * s/ms-w32.h (DATA_START):
3788 Move here from removed file m/intel386.h.
3789 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3790 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3791
261cb4bb
PE
37922012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3793
3794 Assume C89 or later.
3795 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3796 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3797 (xrealloc):
3798 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3799 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3800 * textprop.c, tparam.c (NULL): Remove.
3801 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3802 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3803 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3804 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3805 * xterm.c (input_signal_count): Assume volatile works.
3806
ff23cd9f
KB
38072012-05-21 Ken Brown <kbrown@cornell.edu>
3808
3809 * xgselect.c (xg_select): Fix first argument in call to 'select'
3810 (bug#11508).
3811
1b170bc6
KB
38122012-05-20 Ken Brown <kbrown@cornell.edu>
3813
3814 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3815 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3816
b2f4d39f
KB
38172012-05-19 Ken Brown <kbrown@cornell.edu>
3818
3819 * xfns.c (x_in_use): Remove `static' qualifier.
3820 * xterm.h (x_in_use): Declare.
3821 * xgselect.c: Include xterm.h.
3822 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3823 and `display_arg' (bug#9754).
3824
003fdae2
PE
38252012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3826
9232a6d9
PE
3827 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3828
003fdae2
PE
3829 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3830 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3831
784b56e2
EZ
38322012-05-18 Eli Zaretskii <eliz@gnu.org>
3833
3834 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3835
3836 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3837 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3838
3839 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3840 reference to image_cache->refcount.
3841 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3842
a0a79cde
JL
38432012-05-17 Juri Linkov <juri@jurta.org>
3844
3845 * search.c (Fword_search_regexp, Fword_search_backward)
3846 (Fword_search_forward, Fword_search_backward_lax)
3847 (Fword_search_forward_lax): Move functions to isearch.el
3848 (bug#10145, bug#11381).
3849
b0572523
PE
38502012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3851
3852 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3853
9660f5fc
SM
38542012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3855
3856 * lread.c (init_obarray): Declare Qt and Qnil as special.
3857
4374de83
GM
38582012-05-14 Glenn Morris <rgm@gnu.org>
3859
3860 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3861 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3862
dc44c39a
PE
38632012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3864
078c97cb
PE
3865 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3866
dc44c39a
PE
3867 * unexaix.c: Port to more-recent AIX compilers.
3868 (report_error, report_error_1, make_hdr, copy_sym)
3869 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3870 Make arguments const char *, not char *, to avoid violations of C
3871 standard and to fix some AIX warnings reported by Gilles Pion.
3872
e18afed7 38732012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3874
3875 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3876 already have overlays loaded.
3877 (handle_single_display_spec): Before returning without displaying
3878 fringe bitmap, synchronize the bidi iterator with the main display
3879 iterator, by calling iterate_out_of_display_property.
3880 (iterate_out_of_display_property): Detect buffer iteration by
3881 testing that it->string is a Lisp string.
3882 (get_next_display_element): When the current object is exhausted,
3883 and there's something on it->stack, call set_iterator_to_next to
3884 proceed with what's on the stack, instead of returning zero.
3885 (set_iterator_to_next): If called at the end of a Lisp string,
3886 proceed to consider_string_end without incrementing string
3887 position. Don't increment display vector index past the end of
3888 the display vector. (Bug#11417)
c8fb9dc6
EZ
3889 (pos_visible_p): Don't report a position visible when move_it_to
3890 stopped at the last line of window, which happens to be scanned
3891 backwards by the bidi iteration. (Bug#11464)
ac268e67 3892
e18afed7 38932012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3894
3895 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3896 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3897 are on a TTY, and thus unable to display on the fringes.
3898 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3899 so we need to signal to the caller that this is a "replacing"
3900 display spec. This fixes display when the spec is invalid or we
3901 are on a TTY.
3902
e18afed7 39032012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3904
3905 * unexaix.c (make_hdr): Fix typo in prototype.
3906 This bug broke the build on AIX. Problem reported by Gilles Pion.
3907
9d0a235a
MA
39082012-05-14 Michael Albinus <michael.albinus@gmx.de>
3909
3910 * keyboard.c (kbd_buffer_get_event): Read special events also in
3911 batch mode. (Bug#11415)
3912
9e6b06ed
GM
39132012-05-12 Glenn Morris <rgm@gnu.org>
3914
3915 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3916
c1a1d7a3
EZ
39172012-05-12 Eli Zaretskii <eliz@gnu.org>
3918
3919 * lisp.mk (lisp): Add newcomment.elc.
3920
3fe7cdc8
GM
39212012-05-12 Glenn Morris <rgm@gnu.org>
3922
3923 * Makefile.in (MKDIR_P): New, set by configure.
3924 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3925
53f7d2c0
PE
39262012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3927
3928 Remove unused function hourglass_started.
3929 * dispextern.h (hourglass_started):
3930 * w32fns.c (hourglass_started):
3931 * xdisp.c (hourglass_started): Remove.
3932
75aafb17
JB
39332012-05-10 Juanma Barranquero <lekktu@gmail.com>
3934
3935 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3936 Update dependencies.
3937
12959e8e
PE
39382012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3939
97107e2e
PE
3940 * xgselect.c (xg_select): Put maxfds+1 into a var.
3941 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3942
12959e8e
PE
3943 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3944
836d29b3
DA
39452012-05-10 Dave Abrahams <dave@boostpro.com>
3946
3947 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3948 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3949
5cb67954
MA
39502012-05-09 Michael Albinus <michael.albinus@gmx.de>
3951
3952 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3953 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3954 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3955 Initialize xd_registered_buses.
3956
3478ec45
PE
39572012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3958
b263a6b0
PE
3959 Untag more efficiently if USE_LSB_TAG.
3960 This is based on a proposal by YAMAMOTO Mitsuharu in
3961 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3962 For an admittedly artificial (nth 8000 longlist) benchmark on
3963 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3964 Emacs's overall text size by 1%.
3965 * lisp.h (XUNTAG): New macro.
3966 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3967 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3968 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3969 * eval.c (Fautoload):
3970 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3971 * frame.h (XFRAME): Use XUNTAG.
3972
3478ec45
PE
3973 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3974 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3975 Remove unportable assumptions about print widths of types like
3976 dbus_uint32_t.
3977 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3978 intptr_t when converting between pointer and integer, to avoid GCC
3979 warnings about wrong width.
3980
666b903b 39812012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3982
3983 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3984 stack for each reader_thread, instead of defaulting to 8MB
3985 determined by the linker. This avoids failures in creating
3986 subprocesses on Windows 7, see the discussion in this thread:
3987 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3988
b120cc17
JC
39892012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3990
3991 Fix up display of the *Minibuf-0* buffer in the mini window.
3992 * keyboard.c (read_char): Don't clear the echo area if there's no
3993 message to clear.
3994 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3995 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3996
9a4b36f8
MA
39972012-05-07 Michael Albinus <michael.albinus@gmx.de>
3998
3999 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4000 batch mode.
4001
e5f9458f
CY
40022012-05-06 Chong Yidong <cyd@gnu.org>
4003
4004 * lisp.mk (lisp): Update.
4005
eceeb5fc 40062012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4007
4008 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4009
71873e2b
SM
40102012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4011
4012 * data.c (PUT_ERROR): New macro.
4013 (syms_of_data): Use it. Add new error type `user-error'.
4014 * undo.c (user_error): New function.
4015 (Fprimitive_undo): Use it.
4016 * print.c (print_error_message): Adjust print style for `user-error'.
4017 * keyboard.c (user_error): New function.
4018 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4019
ab0fa4e4
PE
40202012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 Do not limit current-time-string to years 1000..9999.
4023 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4024 (Fcurrent_time_string): Support any year that is supported by the
4025 underlying localtime representation. Don't use asctime, as it
4026 has undefined behavior for years outside the range -999..9999.
4027
7ed806a7
PE
40282012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4029
4030 Fix race conditions involving setenv, gmtime, localtime, asctime.
4031 Without this fix, interrupts could mess up code that uses these
4032 nonreentrant functions, since setting TZ invalidates existing
4033 tm_zone or tzname values, and since most of these functions return
4034 pointers to static storage.
4035 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4036 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4037 Grow the critical sections to include not just invoking
4038 localtime/gmtime, but also accessing these functions' results
4039 including their tm_zone values if any, and any related TZ setting.
4040 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4041 so that the struct tm is saved in the critical section.
4042 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4043 motivated by the fact that memory allocation needs to be outside
4044 the critical section.
4045
0c16dfed
DA
40462012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4047
4048 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4049 with RESET_INTERVAL.
4050
4051 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4052 Remove duplicated buffer name initialization.
4053
3f83ace8
JM
40542012-05-02 Jim Meyering <jim@meyering.net>
4055
4056 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4057
c7b8541e
JM
4058 * xfns.c (x_window): Use xstrdup (Bug#11375).
4059
90207a15 40602012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4061
4062 * xdisp.c (pos_visible_p): If already at a newline from the
4063 display string before the 'while' loop, don't walk back the glyphs
4064 from it3.glyph_row. Solves assertion violation when the display
4065 string begins with a newline (egg.el). (Bug#11367)
4066
b593d6a9
AH
40672012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4068
4069 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4070 Move to simple.el.
4071
4737362e
GM
40722012-05-01 Glenn Morris <rgm@gnu.org>
4073
99cf43f9
GM
4074 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4075 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4076 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4077 All were removed before 23.1.
4078
9311dcff
GM
4079 * dispnew.c: Remove HAVE_LIBNCURSES test;
4080 it is always true on relevant platforms.
4081
4d5c6349
GM
4082 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4083 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4084
4737362e
GM
4085 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4086
74dd3a6b
AS
40872012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4088
4089 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4090 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4091 Remove.
4092
13c379ee
PE
40932012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4094
4095 Do not avoid creating empty evaporating overlays (Bug#9642).
4096 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4097 That is, do not delete an evaporating overlay if it becomes
4098 empty after its bounds are adjusted to fit within its buffer.
4099 This fix caused other problems, and I'm reverting it until we get
4100 to the bottom of them.
4101
a8e7d6d7 41022012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4103
4104 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4105
a8e7d6d7 41062012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4107
4108 * xdisp.c (pos_visible_p): If the window start position is beyond
4109 ZV, start the display from buffer beginning. Prevents assertion
4110 violation in init_iterator when the minibuffer window is scrolled
4111 via the scroll bar.
4112
4113 * window.c (window_scroll_pixel_based): Likewise.
4114
a8e7d6d7 41152012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4116
4117 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4118
a8e7d6d7 41192012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4120
4121 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4122 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4123
a8e7d6d7 41242012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4125
b593d6a9
AH
4126 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4127 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4128
1c6900d9
EZ
41292012-04-26 Eli Zaretskii <eliz@gnu.org>
4130
4c3fa1d9
EZ
4131 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4132 display element, check also the underlying string or buffer
4133 character. (Bug#11341)
4134
1c6900d9
EZ
4135 * w32menu.c: Include w32heap.h.
4136 (add_menu_item): If the call to AppendMenuW (via
4137 unicode_append_menu) fails, disable Unicode menus only if we are
4138 running on Windows 9X/Me.
4139
42bf8205
AS
41402012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4141
4142 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4143 (xgetint): Add missing shift for LSB tags.
4144
b1bac16e
MR
41452012-04-24 Martin Rudalics <rudalics@gmx.at>
4146
4147 * keyboard.c (read_char): Don't wipe echo area for select window
4148 events: These might get delayed via `mouse-autoselect-window'
4149 (Bug#11304).
4150
d69621cc
JB
41512012-04-24 Juanma Barranquero <lekktu@gmail.com>
4152
4153 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4154 manipulation of :loaded-from data.
4155
02fd101b
JB
41562012-04-23 Juanma Barranquero <lekktu@gmail.com>
4157
4158 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4159 now a cons (bug#11311).
4160
888bec30
PE
41612012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4162
89a438bd
PE
4163 Do not create empty overlays with the evaporate property (Bug#9642).
4164 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4165 if it becomes empty after its bounds are adjusted to fit within
4166 its buffer. Without this fix, in a nonempty buffer (let ((o
4167 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4168 yields an empty overlay that has the evaporate property, which is
4169 not supposed to happen.
4170
1068fe4d
PE
4171 Fix minor GTK3 problems found by static checking.
4172 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4173 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4174 (struct _EmacsFixedClass, emacs_fixed_get_type):
4175 Move decls here from emacsgtkfixed.h, since they needn't be public.
4176 (emacs_fixed_get_type): Now static.
4177 (emacs_fixed_class_init): Omit unused local.
4178 (emacs_fixed_child_type): Remove; unused.
4179 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4180 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4181 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4182 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4183 (EMACS_FIXED_GET_CLASS): Remove; unused.
4184 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4185
888bec30
PE
4186 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4187 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4188
de85e130
PE
41892012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4190
d0baac98 4191 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4192 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4193 (__malloc_size_t, __malloc_ptrdiff_t):
4194 Remove. All uses removed, replaced by the definiens if needed,
4195 since we can assume C89 or better now.
4196 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4197 (protect_malloc_state, align, get_contiguous_space)
4198 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4199 (malloc_atfork_handler_child, malloc_enable_thread)
4200 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4201 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4202 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4203 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4204 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4205 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4206 Define using prototypes, not old style.
4207 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4208 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4209 (align): Don't assume that signed integer overflow wraps around.
4210 Omit unused local var.
4211 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4212 (_free_internal_nolock, memalign, mallochook, reallochook):
4213 Omit no-longer-needed casts.
4214 (valloc): Use getpagesize, not __getpagesize.
4215 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4216 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4217
de85e130
PE
4218 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4219
dcbf5805
MA
42202012-04-22 Michael Albinus <michael.albinus@gmx.de>
4221
4222 Move functions from C to Lisp. Make non-blocking method calls
4223 the default. Implement further D-Bus standard interfaces.
4224
4225 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4226 (QCdbus_request_name_allow_replacement)
4227 (QCdbus_request_name_replace_existing)
4228 (QCdbus_request_name_do_not_queue)
4229 (QCdbus_request_name_reply_primary_owner)
4230 (QCdbus_request_name_reply_in_queue)
4231 (QCdbus_request_name_reply_exists)
4232 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4233 (QCdbus_registered_serial, QCdbus_registered_method)
4234 (QCdbus_registered_signal): New Lisp objects.
4235 (XD_DEBUG_MESSAGE): Use sizeof.
4236 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4237 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4238 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4239 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4240 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4241 (xd_signature, xd_append_arg): Allow float for integer types.
4242 (xd_get_connection_references): New function.
b593d6a9
AH
4243 (xd_get_connection_address): Rename from xd_initialize.
4244 Return cached address.
dcbf5805
MA
4245 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4246 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4247 level.
4248 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4249 Return number of refcounts.
dcbf5805
MA
4250 (Fdbus_get_unique_name): Make stronger parameter check.
4251 (Fdbus_message_internal): New defun.
4252 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4253 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4254 (Fdbus_send_signal, Fdbus_register_service)
4255 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4256 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4257 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4258 (Vdbus_compiled_version, Vdbus_runtime_version)
4259 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4260 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4261 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4262 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4263 Adapt docstring.
dcbf5805 4264
52828e02
PE
42652012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4266
da05bc4c
PE
4267 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4268 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4269 Do not assume ptrdiff_t is the same width as 'int'.
4270
52828e02
PE
4271 * alloc.c: Handle unusual debugging option combinations.
4272 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4273 since the two debugging options are incompatible.
4274 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4275 is defined.
4276 (mem_init, mem_insert, mem_insert_fixup):
4277 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4278 (NEED_MEM_INSERT): Remove; no longer needed.
4279
f01769f9
LL
42802012-04-22 Leo Liu <sdl.web@gmail.com>
4281
4282 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4283
5790543d
PE
42842012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4285
4286 * sysdep.c [__FreeBSD__]: Minor cleanups.
4287 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4288 Use Emacs indenting style more consistently. Avoid some casts.
4289 Use 'double' consistently rather than mixing 'float' and 'double'.
4290
b91b7e4d
EW
42912012-04-21 Eduard Wiebe <usenet@pusto.de>
4292
b593d6a9
AH
4293 * sysdep.c (list_system_processes, system_process_attributes):
4294 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4295
6114eb15
AS
42962012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4297
4298 * lisp.mk (lisp): Update.
4299
2f38dff7
PE
43002012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4301
4302 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4303 It is never used otherwise.
4304
4ae29f89
SM
43052012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4306
4307 * print.c (print_preprocess): Only check print_depth if print-circle
4308 is nil.
4309 (print_object): Check for cycles even when print-circle is nil and
4310 print-gensym is t, but only check print_depth if print-circle is nil.
4311
f30d612a
CY
43122012-04-20 Chong Yidong <cyd@gnu.org>
4313
4314 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4315 set the status to "failed" and ensure that sentinel is run.
4316
c07a4c0b 43172012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4318
4319 * process.c (Fset_process_inherit_coding_system_flag)
4320 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4321 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4322
c07a4c0b 43232012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4324
4325 * xdisp.c (string_buffer_position_lim): Limit starting position to
4326 BEGV.
4327 (set_cursor_from_row): If called for a mode-line or header-line
4328 row, return zero immediately.
4329 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4330 farther than the first row after the header line, if any.
4331 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4332 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4333
c07a4c0b 43342012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4335
4ae29f89
SM
4336 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4337 (bug#11238).
ad3a2b41 4338
c07a4c0b 43392012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 43402012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4341
4342 configure: new option --enable-gcc-warnings (Bug#11207)
4343 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4344 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4345 (ALL_CFLAGS): Use new macros rather than old.
4346 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4347 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4348 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4349 -Wunused-result, -Wunused-variable. This should go away once
4350 the Emacs and Gnulib regex code is merged.
4351 (xmalloc, xrealloc): Now static.
4352
aba027e8
PE
43532012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4354
4355 * dired.c (Fsystem_groups): Remove unused local.
4356
e5a36063
GM
43572012-04-17 Glenn Morris <rgm@gnu.org>
4358
4359 * dired.c (Fsystem_users): Doc fix.
4360
316411f0
DA
43612012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4362
4363 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4364 (syms_of_dired): Add them.
4365
9426aba4
PE
43662012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4367
b62a57be
PE
4368 Fix minor alloc.c problems found by static checking.
4369 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4370 New extern decls, to avoid calling undeclared functions.
4371 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4372 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4373 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4374 (NEED_MEM_INSERT): New macro.
4375 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4376 Remove one incorrect comment and fix another.
b62a57be 4377
3539f31f
PE
4378 Fix minor ralloc.c problems found by static checking.
4379 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4380 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4381 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4382 (r_alloc_sbrk): Now static.
4383
a041960a
PE
4384 Improve ralloc.c interface checking.
4385 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4386 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4387 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4388 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4389 [REL_ALLOC]: ... to here, to check interface.
4390 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4391 Remove decls. This fixes an "It stinks!".
4392
9426aba4
PE
4393 * alloc.c (which_symbols): Fix alignment issue / type clash.
4394
d55c12ed
AS
43952012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4396
4397 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4398 (struct Lisp_Misc_Any): Likewise.
4399 (struct Lisp_Free): Likewise.
4400 * alloc.c (union aligned_Lisp_Symbol): Define.
4401 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4402 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4403 (union aligned_Lisp_Misc): Define.
4404 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4405 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4406 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4407
b948ce8b
PE
44082012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4409
4410 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4411 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4412 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4413 * s/netbsd.h, s/sol2-6.h:
4414 Remove definition of GC_MARK_STACK, since the default now works.
4415 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4416 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4417 no longer the default.
4418 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4419
35dc09a1 44202012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4421
35dc09a1
GM
4422 * lread.c (lisp_file_lexically_bound_p):
4423 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4424
35dc09a1
GM
44252012-04-14 Eli Zaretskii <eliz@gnu.org>
4426
4427 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4428 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4429
44302012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4431
4432 * nsterm.m (constrainFrameRect): Always constrain when there is only
4433 one screen (Bug#10962).
4434
bcd86815
KB
44352012-04-13 Ken Brown <kbrown@cornell.edu>
4436
4437 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4438
c25df26e
RT
44392012-04-13 Reuben Thomas <rrt@sc3d.org>
4440
4441 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4442
0fc59f1e
DC
44432012-04-11 Daniel Colascione <dancol@dancol.org>
4444
4445 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4446 against is gone. It's better to use vfork now so that when Cygwin
4447 gains a new, working vfork, we use it automatically (bug#10398).
4448
de8c03dc
SM
44492012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4450
4451 * window.c (save_window_save): Obey window-point-insertion-type.
4452
2f097256
GM
44532012-04-11 Glenn Morris <rgm@gnu.org>
4454
4455 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4456
453b951e
SM
44572012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4458
4459 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4460
75f1671a 44612012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4462
4463 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4464 (force_quit_count): New var.
4465 (handle_interrupt): Use it.
4466
2a8ce227
JB
44672012-04-10 Juanma Barranquero <lekktu@gmail.com>
4468
4469 * w32.c (w32_delayed_load): Record the full path of the library
4470 being loaded (bug#10424).
4471
935396c0
GM
44722012-04-09 Glenn Morris <rgm@gnu.org>
4473
05920a43
GM
4474 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4475 not just in the obarray, before snarfing them. (Bug#11036)
4476
935396c0
GM
4477 * Makefile.in ($(leimdir)/leim-list.el):
4478 Pass EMACS rather than BUILT_EMACS.
4479
a18ecafa
TZ
44802012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4481
4482 * process.c (make_process):
4483 * process.h: Add integer `gnutls_handshakes_tried' member to
4484 process struct.
4485
6bbef4e5
JC
4486 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4487 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4488
4489 * gnutls.c (gnutls_log_function2i): Convenience log function.
4490 (emacs_gnutls_read): Use new log functions,
4491 `gnutls_handshakes_tried' process member, and
4492 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4493 attempts per process (connection).
4494
b4d3bc10
CY
44952012-04-09 Chong Yidong <cyd@gnu.org>
4496
4497 * eval.c (Fuser_variable_p, user_variable_p_eh)
4498 (lisp_indirect_variable): Functions deleted.
4499 (Fdefvar): Caller changed.
4500
4501 * callint.c (Finteractive, Fcall_interactively):
4502 * minibuf.c (Fread_variable): Callers changed.
4503
70f4d973
EZ
45042012-04-09 Eli Zaretskii <eliz@gnu.org>
4505
4506 * xdisp.c (set_cursor_from_row): If the display string appears in
4507 the buffer at position that is closer to point than the position
4508 after the display string, display the cursor on the first glyph of
4509 the display string. Fixes cursor display when a 'display' text
4510 property immediately follows invisible text. (Bug#11094)
4511
cb3c2e3e
PE
45122012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4513
4514 composite.c: use 'double' consistently
4515 * composite.c (get_composition_id): Use 'double' consistently
4516 instead of converting 'float' to 'double' and vice versa; this is
4517 easier to understand and avoids a GCC warning.
4518
fd06db5d
GM
45192012-04-09 Glenn Morris <rgm@gnu.org>
4520
50fe702a
GM
4521 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4522 preparation for dumping it with emacs. (Bug#4789)
4523 (leimdir): New variable.
4524 ($(leimdir)/leim-list.el): New rule.
4525 (emacs$(EXEEXT)): Depend on leim-list.el.
4526
fd06db5d
GM
4527 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4528 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4529 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4530
55c131ee
AS
45312012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4532
4533 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4534 proper alignment.
4535
9209588f
JB
45362012-04-07 Juanma Barranquero <lekktu@gmail.com>
4537
4538 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4539 Remove unused local variable.
4540
e3fb2efb
PE
45412012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4542
4543 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4544 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4545 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4546 objects, as mark_maybe_pointer will catch them otherwise.
4547 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4548 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4549
b5385551
PE
45502012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4551
4552 Fix typo that broke non-Windows builds.
4553 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4554
9078ead6
EZ
45552012-04-07 Eli Zaretskii <eliz@gnu.org>
4556
4557 Support building on MS-Windows with libxml2.
4558
4559 * makefile.w32-in (OBJ2): Add xml.$(O).
4560 (GLOBAL_SOURCES): Add xml.c.
4561 ($(BLD)/xml.$(O)): New dependency list.
4562
4563 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4564 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4565 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4566 [!WINDOWSNT]: New macros.
4567 (init_libxml2_functions, libxml2_loaded_p): New functions.
4568 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4569 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4570 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4571 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4572 linked in).
6bbef4e5
JC
4573 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4574 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4575 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4576
4577 * emacs.c: Don't include libxml/parser.h.
4578 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4579 xmlCleanupParser directly.
4580
4581 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4582
3811fdf3
EZ
45832012-04-07 Eli Zaretskii <eliz@gnu.org>
4584
4585 * indent.c (Fvertical_motion): If there is a display string at
4586 point, use it.vpos to compute how many lines to backtrack after
4587 move_it_to point. (Bug#11133)
4588
2f8e16b2
EZ
45892012-04-06 Eli Zaretskii <eliz@gnu.org>
4590
4591 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4592 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4593 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4594 macros related to unification of CJK characters. For the details,
4595 see the discussion following the message here:
4596 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4597
3d439cd1
CY
45982012-04-04 Chong Yidong <cyd@gnu.org>
4599
4600 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4601
8bc53d00
EZ
46022012-04-01 Eli Zaretskii <eliz@gnu.org>
4603
4604 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4605 instead of alloca. (Bug#11138)
4606
3b0512a3
AS
46072012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4608
4609 * w32menu.c (is_simple_dialog): Properly check lisp types.
4610 (Bug#11141)
4611
8427ddd2
EZ
46122012-03-31 Eli Zaretskii <eliz@gnu.org>
4613
979022ef
EZ
4614 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4615 position we get to after a call to move_it_to fails the
4616 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4617 only if we wind up in a string from display property. (Bug#11063)
4618
a6b1c7cc
EZ
4619 * window.c (Fdelete_other_windows_internal): Invalidate the row
4620 and column information about mouse highlight, so that redisplay
4621 restores it after reallocating the glyph matrices. (Bug#7464)
4622
8427ddd2
EZ
4623 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4624 string comes from a `display' text property, use the buffer
4625 position of that property as if we actually saw that position in
4626 the row's glyphs.
697ba24b
EZ
4627 (move_it_by_lines): Remove the assertion that
4628 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4629 violated when there's a before-string at the beginning of a line.
4630 (Bug#11063)
8427ddd2 4631
65a0a738
EZ
46322012-03-30 Eli Zaretskii <eliz@gnu.org>
4633
4634 * xdisp.c (append_space_for_newline): If the default face was
4635 remapped, use the remapped face for the appended newline.
4636 (extend_face_to_end_of_line): Use the remapped default face for
4637 extending the face to the end of the line.
4638 (display_line): Call extend_face_to_end_of_line when the default
4639 face was remapped. (Bug#11068)
4640
581355cc
EZ
46412012-03-29 Eli Zaretskii <eliz@gnu.org>
4642
4643 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4644
e8fc049f
SM
46452012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4646
4647 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4648
4fb9a543
GM
46492012-03-27 Glenn Morris <rgm@gnu.org>
4650
4651 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4652 Doc fixes.
4653
679910f1
KH
46542012-03-26 Kenichi Handa <handa@m17n.org>
4655
4656 * dispextern.h (struct glyph): Fix previous change. Change the
4657 bit length of glyphless.ch to 25 (Bug#11082).
4658
90d49b7f
CY
46592012-03-26 Chong Yidong <cyd@gnu.org>
4660
4661 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4662 (command_loop_1): Use it; inhibit selection update for
4663 handle-select-window too (Bug#8996).
4664
f514f6f0
FP
46652012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4666
e8fc049f 4667 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4668
bf43fa51
KH
46692012-03-25 Kenichi Handa <handa@m17n.org>
4670
4671 * dispextern.h (struct glyph): Change the bit length of
4672 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4673
8a0c01dd
EZ
46742012-03-24 Eli Zaretskii <eliz@gnu.org>
4675
4676 * s/ms-w32.h (tzname): Include time.h before redirecting to
4677 _tzname. Fixes the MSVC build. (Bug#9960)
4678
7d1c3a76
AS
46792012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4680
8ed79523
AS
4681 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4682 characters.
4683
7d1c3a76
AS
4684 * xterm.c (XTread_socket): Only modify handling_signal if
4685 !SYNC_INPUT. (Bug#11080)
4686
e99a9b8b
EZ
46872012-03-23 Eli Zaretskii <eliz@gnu.org>
4688
4689 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4690 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4691 when fetching a multibyte character consumes more bytes than
4692 CHAR_BYTES returns, due to unification of CJK characters in
4693 string_char. (Bug#11073)
4694
5063c0e1
TN
46952012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4696
4697 * process.c (wait_reading_process_output): Handle pty disconnect
4698 by refraining from sending oneself a SIGCHLD (bug#10933).
4699
9f851fbd
CY
47002012-03-22 Chong Yidong <cyd@gnu.org>
4701
4702 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4703
5063c0e1 4704 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4705 Mark string as coming from a prefix property.
4706 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4707 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4708
fb5b8aca
CY
47092012-03-21 Chong Yidong <cyd@gnu.org>
4710
4711 * xfaces.c (Vface_remapping_alist): Doc fix.
4712
62356a1b
EZ
47132012-03-20 Eli Zaretskii <eliz@gnu.org>
4714
4715 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4716 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4717 Doc fixes.
62356a1b 4718
025de85b
CY
47192012-03-20 Chong Yidong <cyd@gnu.org>
4720
4721 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4722 to reflect default non-nil value of redisplay-dont-pause.
4723
4827f94e
KH
47242012-03-19 Kenichi Handa <handa@m17n.org>
4725
4726 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4727 it fit in a valid range (Bug#11003).
4728
e50a24a2
EZ
47292012-03-18 Eli Zaretskii <eliz@gnu.org>
4730
4731 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4732 that is not from display property, accept the row as a "cursor
4733 row" if one of the string's character has a non-nil `cursor'
4734 property. Fixes cursor positioning when there are newlines in
4735 overlay strings, e.g. in icomplete.el. (Bug#11035)
4736
9af5ed87
PE
47372012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4738
4739 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4740
d1f55f16
CY
47412012-03-12 Chong Yidong <cyd@gnu.org>
4742
4743 * eval.c (inhibit_lisp_code): Rename from
4744 inhibit_window_configuration_change_hook; move from window.c.
4745
4746 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4747 * window.c (run_window_configuration_change_hook)
4748 (syms_of_window): Callers changed.
4749
66c5eebd
CY
47502012-03-11 Chong Yidong <cyd@gnu.org>
4751
413df973
CY
4752 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4753
66c5eebd
CY
4754 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4755
1de11f56
CY
47562012-03-10 Chong Yidong <cyd@gnu.org>
4757
4758 * frame.c (other_visible_frames): Don't assume the selected frame
4759 is visible (Bug#10955).
4760
cae07000
SM
47612012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4762
4763 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4764
89c94350
JD
47652012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4766
4767 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4768 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4769 zero (Bug#10954).
4770
999dd333
GM
47712012-03-03 Glenn Morris <rgm@gnu.org>
4772
01a6dcc8 4773 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4774
de0100f2
EZ
47752012-03-02 Eli Zaretskii <eliz@gnu.org>
4776
4777 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4778 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4779 (redisplay_window, next_element_from_string): Fix typos in
4780 comments.
3e441275
EZ
4781 (redisplay_window): Pass to move_it_vertically the margin in
4782 pixels, not in screen lines.
de0100f2 4783
96a72ee9
GM
47842012-03-02 Glenn Morris <rgm@gnu.org>
4785
4786 * buffer.c (buffer-list-update-hook): Doc fix.
4787
312508d7
EZ
47882012-02-29 Eli Zaretskii <eliz@gnu.org>
4789
4790 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4791 push_it before setting up the iterator for the first overlay
4792 string, even if we have an empty string loaded.
4793 (next_overlay_string): If there's an empty string on the iterator
4794 stack, pop the stack. (Bug#10903)
4795
27f3c637
PE
47962012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4797
4798 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4799 Suggested by Stefan Monnier in
4800 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4801 * alloc.c (widen_to_Lisp_Object): New static function.
4802 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4803 and widening them to Lisp_Objects. This would work even if
4804 USE_LSB_TAG is defined and wide integers are used, which might
4805 happen in a future version of Emacs.
4806
3c9dfce6
CY
48072012-02-25 Chong Yidong <cyd@gnu.org>
4808
fa74b241
CY
4809 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4810 Doc fix.
4811
3c9dfce6
CY
4812 * xselect.c (Fx_selection_exists_p): Doc fix.
4813 (x_clipboard_manager_save_all): Print an informative message
4814 before saving to clipboard manager.
4815
9486df08
CY
48162012-02-24 Chong Yidong <cyd@gnu.org>
4817
4818 * keyboard.c (process_special_events): Handle all X selection
4819 requests in kbd_buffer, not just the next one (Bug#8869).
4820
f01d3321
CY
48212012-02-23 Chong Yidong <cyd@gnu.org>
4822
4823 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4824 call when setting menu-bar-lines and tool-bar-lines parameters.
4825 (unwind_create_frame_1): New helper function.
4826
4827 * window.c (inhibit_window_configuration_change_hook): New var.
4828 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4829 (syms_of_window): Initialize it.
f01d3321 4830
86b847b6
CY
48312012-02-22 Chong Yidong <cyd@gnu.org>
4832
4833 * xterm.c (x_draw_image_relief): Add missing type check for
4834 Vtool_bar_button_margin (Bug#10743).
4835
a59225b1
CY
48362012-02-21 Chong Yidong <cyd@gnu.org>
4837
4838 * fileio.c (Vfile_name_handler_alist): Doc fix.
4839
4840 * buffer.c (Fget_file_buffer): Protect against invalid file
4841 handler return value.
4842
310f5bd4
PE
48432012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4844
cb3a28cc
PE
4845 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4846 when computing $valmask.
4847
310f5bd4
PE
4848 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4849 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4850 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4851 It's useless in that case, and it can cause problems on hosts
4852 that allocate halves of EMACS_INT values separately.
4853 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4854 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4855 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4856 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4857 it avoids undefined behavior on hosts where shifting right by more
4858 than the word width has undefined behavior.
4859
2375c96a
CY
48602012-02-19 Chong Yidong <cyd@gnu.org>
4861
4862 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4863 (Funhandled_file_name_directory, Ffile_name_as_directory)
4864 (Fdirectory_file_name, Fexpand_file_name)
4865 (Fsubstitute_in_file_name): Protect against invalid file handler
4866 return values (Bug#10845).
4867
3eb49e71
EZ
48682012-02-18 Eli Zaretskii <eliz@gnu.org>
4869
4870 * .gdbinit (pitx): Fix incorrect references to fields of the
4871 iterator stack.
4872
7b926f3f
CY
48732012-02-17 Chong Yidong <cyd@gnu.org>
4874
4875 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4876
11273115
PE
48772012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4878
4879 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4880 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4881
c3a70e2b
CY
48822012-02-15 Chong Yidong <cyd@gnu.org>
4883
4884 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4885 marked as special. Also, starting docstrings with * is obsolete.
4886
0ca43699
AS
48872012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4888
4889 * gnutls.c (emacs_gnutls_write): Fix last change.
4890
2e8f3c56
LI
48912012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4892
4893 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4894 send_process.
4895
af70074f
SM
48962012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4897
4898 * keymap.c (Fsingle_key_description): Handle char ranges.
4899
95986d52
CY
49002012-02-12 Chong Yidong <cyd@gnu.org>
4901
afd83bd1
CY
4902 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4903 as that creates a dangerous corner case.
4904
95986d52
CY
4905 * window.c (Fdelete_window_internal): Invalidate the mouse
4906 highlight (Bug#9904).
4907
bd7da63e
GM
49082012-02-12 Glenn Morris <rgm@gnu.org>
4909
4910 * xselect.c (Fx_own_selection_internal)
4911 (Fx_get_selection_internal, Fx_disown_selection_internal)
4912 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4913 * nsselect.m (Fx_own_selection_internal)
4914 (Fx_disown_selection_internal, Fx_selection_exists_p)
4915 (Fx_selection_owner_p, Fx_get_selection_internal):
4916 Sync docs and argument specs with the xselect.c versions.
4917
77abcbc2
LI
49182012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4919
4920 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4921
90b671e2
EZ
49222012-02-11 Eli Zaretskii <eliz@gnu.org>
4923
1c0ca0b7
EZ
4924 * w32select.c (Fx_selection_exists_p): Sync doc string and
4925 argument list with xselect.c. (Bug#10783)
4926
4927 * w16select.c (Fx_selection_exists_p): Sync doc string and
4928 argument list with xselect.c. (Bug#10783)
90b671e2 4929
49241268
GM
49302012-02-10 Glenn Morris <rgm@gnu.org>
4931
4932 * fns.c (Fsecure_hash): Doc fix.
4933
f998bbe7 49342012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4935
4936 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4937
0992bd9c
CY
49382012-02-07 Chong Yidong <cyd@gnu.org>
4939
4940 * buffer.c (Fbuffer_local_variables)
4941 (buffer_lisp_local_variables): Handle unbound vars correctly;
4942 don't let Qunbound leak into Lisp.
4943
af008560
GM
49442012-02-07 Glenn Morris <rgm@gnu.org>
4945
dd605cc4
GM
4946 * image.c (Fimagemagick_types): Doc fix.
4947
af008560
GM
4948 * image.c (imagemagick-render-type): Change it from a lisp object
4949 to an integer. Move the doc here from the lisp manual.
4950 Treat all values not equal to 0 the same.
4951
1449fa1d
CY
49522012-02-06 Chong Yidong <cyd@gnu.org>
4953
4954 * doc.c (store_function_docstring): Avoid applying docstring of
4955 alias to base function (Bug#2603).
4956
3723ec07
AS
49572012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4958
4959 * .gdbinit (pp1, pv1): Remove redundant defines.
4960 (pr): Use pp.
4961
79c1cc1e
CY
49622012-02-04 Chong Yidong <cyd@gnu.org>
4963
4964 * nsterm.m: Declare a global (Bug#10694).
4965
d7f29f8e
EZ
49662012-02-04 Eli Zaretskii <eliz@gnu.org>
4967
cae07000
SM
4968 * w32.c (get_emacs_configuration_options):
4969 Include --enable-checking, if specified, in the return value.
d7f29f8e 4970
3b95a6f9
MR
49712012-02-04 Martin Rudalics <rudalics@gmx.at>
4972
4973 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4974 after rounding frame sizes. (Bug#9723)
4975
d6fa96a6
EZ
49762012-02-04 Eli Zaretskii <eliz@gnu.org>
4977
4978 * keyboard.c (adjust_point_for_property): Don't position point
4979 before BEGV. (Bug#10696)
4980
df0b2940
PE
49812012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4982
4983 Handle overflow when computing char display width (Bug#9496).
4984 * character.c (char_width): Return EMACS_INT, not int.
4985 (char_width, c_string_width): Check for overflow when
4986 computing the width; this is possible now that individual
4987 characters can have unbounded width. Problem introduced
4988 by merge from Emacs 23 on 2012-01-19.
4989
6bee44d6
MA
49902012-02-02 Michael Albinus <michael.albinus@gmx.de>
4991
4992 * dbusbind.c (Fdbus_register_method): Mention the return value
4993 :ignore in the docstring.
4994
44f92739
GM
49952012-02-02 Glenn Morris <rgm@gnu.org>
4996
1b9f60cc
GM
4997 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4998
44f92739
GM
4999 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5000 Unconditionally set to t. (Bug#10673)
5001 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5002 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5003 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5004
c5d3843c
KH
50052012-02-02 Kenichi Handa <handa@m17n.org>
5006
5007 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5008 0, do not call append_composite_glyph.
5009
159462d4 50102012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5011
5012 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5013 NULL (Bug#6988).
5014 (x_produce_glyphs): If the component of a composition is a null
5015 string, set it->pixel_width to 1 to avoid zero-width glyph.
5016
78cef877
EZ
50172012-02-01 Eli Zaretskii <eliz@gnu.org>
5018
5019 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5020 first 2 arguments are identical. This makes inserting large
5021 output from a subprocess an order of magnitude faster on
5022 MS-Windows, where all sbrk'ed memory is always contiguous.
5023
97897668
GM
50242012-01-31 Glenn Morris <rgm@gnu.org>
5025
5026 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5027 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5028 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5029
31fd3586
GM
50302012-01-29 Glenn Morris <rgm@gnu.org>
5031
5032 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5033
0e24a8b2
CY
50342012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5035
5036 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5037
cc0adcb0
CY
50382012-01-28 Chong Yidong <cyd@gnu.org>
5039
5040 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5041
acc28cb9
CY
50422012-01-26 Chong Yidong <cyd@gnu.org>
5043
9c69cfb7
CY
5044 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5045
acc28cb9
CY
5046 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5047 repeat counts (Bug#10507).
5048
48da7392
GM
50492012-01-26 Glenn Morris <rgm@gnu.org>
5050
5051 * lread.c (syms_of_lread): Doc fix.
5052
14af5f7f
CY
50532012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5054
5055 * coding.c (encode_designation_at_bol): Change return value to
5056 EMACS_INT.
5057
0b21c100
CY
50582012-01-25 Chong Yidong <cyd@gnu.org>
5059
5060 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5061
3c2907f7
CY
50622012-01-21 Chong Yidong <cyd@gnu.org>
5063
5064 * floatfns.c (Fcopysign): Make the second argument non-optional,
5065 since nil is not allowed anyway.
5066
959ad23f
AS
50672012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5068
5069 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5070 (send_process): Likewise.
5071
34a02f46
MR
50722012-01-19 Martin Rudalics <rudalics@gmx.at>
5073
5074 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5075 (Vwindow_persistent_parameters): Do not use Qstate.
5076 Rewrite doc-strings.
34a02f46 5077
1259009a 50782012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5079
5080 * character.c (char_width): New function.
70d4fdf6
GM
5081 (Fchar_width, c_string_width, lisp_string_width):
5082 Use char_width (Bug#9496).
25ed9e61 5083
6a6ee00d
MR
50842012-01-16 Martin Rudalics <rudalics@gmx.at>
5085
5086 * window.c (Vwindow_persistent_parameters): New variable.
5087 (Fset_window_configuration, save_window_save): Handle persistent
5088 window parameters.
5089
c85efaf7
EZ
50902012-01-14 Eli Zaretskii <eliz@gnu.org>
5091
5092 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5093 thrashing the stack of the thread. (Bug#9087)
5094
5944709e
PE
50952012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5096
5097 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5098
e71f5d99
EZ
50992012-01-11 Eli Zaretskii <eliz@gnu.org>
5100
5101 * xdisp.c (rows_from_pos_range): Handle the case where the
5102 highlight ends on a newline. (Bug#10464)
5103 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5104 he end column for display of highlight that ends on a newline
5105 before a R2L line.
5106
ce316182
GM
51072012-01-11 Glenn Morris <rgm@gnu.org>
5108
5109 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5110 from load-path also when installation-directory is nil. (Bug#10208)
5111
5b43da69
GM
51122012-01-10 Glenn Morris <rgm@gnu.org>
5113
74cc8ff9
GM
5114 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5115
7d8d6e4e
GM
5116 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5117 Update template values to be closer to their typical values these days.
5b43da69 5118
a0db8d43
EZ
51192012-01-09 Eli Zaretskii <eliz@gnu.org>
5120
5121 * xdisp.c (rows_from_pos_range): Accept additional argument
5122 DISP_STRING, and accept any glyph in a row whose object is that
5123 string as eligible for mouse highlight. Fixes mouse highlight of
5124 display strings from overlays. (Bug#10464)
5125
9a0115ab 51262012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5127
b9110d6a 5128 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5129 * fileio.c (auto_saving_dir_umask): New static var.
5130 (Fmake_directory_internal): Use it.
5131 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5132 creating the directory. The old code temporarily assigns
5133 too-generous permissions to the directory.
5134 (do_auto_save_eh): Clear it.
b9110d6a 5135 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5136 that the var is always cleared.
5137
6c1bd3f3
EZ
51382012-01-07 Eli Zaretskii <eliz@gnu.org>
5139
5140 * search.c (scan_buffer): Pass character positions to
5141 know_region_cache, not byte positions. (Bug#6540)
5142
069d2b50
L
51432012-01-07 LynX <_LynX@bk.ru> (tiny change)
5144
5145 * w32.c (sys_rename): Report EXDEV when rename of a directory
5146 fails because the target is on another logical disk. (Bug#10284)
5147
75bf0d33
DB
51482012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5149
5150 * xterm.c (x_embed_request_focus): New function.
5151
5152 * xterm.h: Add prototype.
5153
5154 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5155
1c6e5a32
GM
51562012-01-05 Glenn Morris <rgm@gnu.org>
5157
5158 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5159
651e947e
EZ
51602012-01-01 Eli Zaretskii <eliz@gnu.org>
5161
5162 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5163 Load gnutls_transport_set_lowat only if GnuTLS version is below
5164 2.11.1.
5165 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5166 GnuTLS versions below 2.11.1.
5167
3778cdd8
AL
51682011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5169
5170 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5171 to the doc string advising against its use for altering the way
5172 windows are scrolled.
5173
0e5317f7
KH
51742011-12-28 Kenichi Handa <handa@m17n.org>
5175
5176 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5177 coding-system ASCII compatible only when it does not produce BOM
5178 on encoding (Bug#10383).
5179
93d5ca1f
JD
51802011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5181
5182 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5183 can scroll.
5184 (create_and_show_popup_menu): Always use menu_position_func for
5185 Gtk3 (Bug#10361).
5186
ca22b785
AS
51872011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5188
5189 * callint.c (Fcall_interactively): Don't truncate prompt string.
5190
d048e1e6
EZ
51912011-12-23 Eli Zaretskii <eliz@gnu.org>
5192
5193 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5194 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5195 resumed from there (after widening). (Bug#10360)
d048e1e6 5196
5ccaba1f
JD
51972011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5198
5199 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5200
204ee57f
JD
52012011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5202
b81d40f0
JB
5203 * nsterm.m (x_free_frame_resources):
5204 Release f->output_data.ns->miniimage.
204ee57f
JD
5205 (ns_index_color): Fix indentation. Do not retain
5206 color_table->colors[i].
5207
5208 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5209 before returning.
5210
5211 * nsfns.m (x_set_background_color): Assign return value from
5212 ns_index_color to face-background instead of NSColor*.
5213 (ns_implicitly_set_icon_type): Fix indentation.
5214 Change assignment in for loop to comparison.
5215
5216 * emacs.c (ns_pool): New variable.
5217 (main): Assign ns_pool.
5218 (Fkill_emacs): Call ns_release_autorelease_pool.
5219
5220 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5221 autorelease fdesc, release fdAttrs and tdict.
5222 (ns_get_covering_families): Release charset.
5223 (ns_findfonts): Release NSFontDescriptor created with new.
5224 (ns_uni_to_glyphs): Fix indentation.
5225 (setString): Release attrStr before assigning new value.
5226
c803b2b7
JD
52272011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5228
678f4426
JD
5229 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5230 and NS_IMPL_COCOA.
5231 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5232 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5233
cd394be1 52342011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5235
5fecd5fc
JD
5236 * nsterm.m (ns_term_init): Subscribe for notifications
5237 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5238 to method trackingNotification in EmacsMenu.
5239
5240 * nsmenu.m (trackingMenu): New variable.
3771cb17 5241 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5242 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5243 from Aquamacs (Bug#7030).
678f4426
JD
5244
52452011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5246
c803b2b7
JD
5247 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5248 (symbol_to_nsstring): Fix indentation.
5249 (ns_symbol_to_pb): New function.
cae07000
SM
5250 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5251 (Fns_rotate_cut_buffers_internal): Remove.
5252 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5253 Fns_store_cut_buffer_internal.
5254 (ns_get_foreign_selection, Fx_own_selection_internal)
5255 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5256 (Fns_get_selection_internal, Fns_store_selection_internal):
5257 Use ns_symbol_to_pb and check if return value is nil.
5258 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5259 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5260 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5261 renamed to Sns_store_selection_internal.
5262 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5263 and remove this function.
5264 (ns_handle_selection_clear): Remove, never used.
5265 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5266 here.
5267
e1b01a3a
KB
52682011-12-17 Ken Brown <kbrown@cornell.edu>
5269
5270 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5271 GID is unknown (Bug#10257).
5272
2adb6e85
PE
52732011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5274
5275 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5276 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5277 which caused a build failure on GNU/Linux IA-64. This problem was
5278 introduced by my 2011-10-07 patch.
5279
d1d7b339
JL
52802011-12-15 Juri Linkov <juri@jurta.org>
5281
5282 * image.c (imagemagick_error): New function. (Bug#10112)
5283 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5284 Use `imagemagick_error' where ImageMagick functions return
5285 `MagickFalse'.
5286 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5287 proper order.
5288
100d5755
KH
52892011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5290
5291 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5292 fill background (Bug#8992).
5293
454592a6
MR
52942011-12-13 Martin Rudalics <rudalics@gmx.at>
5295
5296 * window.c (Vwindow_combination_resize)
5297 (Vwindow_combination_limit): Use t instead of non-nil in
5298 doc-strings.
61d4b438
MR
5299 (Vrecenter_redisplay): Add first sentence of doc-string on
5300 separate line.
53524d93 5301 (Frecenter): Fix doc-string typo.
454592a6 5302
3633e3aa
KH
53032011-12-11 Kenichi Handa <handa@m17n.org>
5304
5305 * coding.c (Funencodable_char_position): Pay attention to the
5306 buffer text relocation (Bug#9389).
5307
7b9d523a 53082011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5309
7b9d523a
JD
5310 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5311 gtk_init (Bug#10100).
5312
b73189c6
EZ
53132011-12-10 Eli Zaretskii <eliz@gnu.org>
5314
5315 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5316 IT->string is nil. (Bug#10263)
5317
f7dfe5d6
JD
53182011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5319
83faebb4
JD
5320 * nsterm.h (x_free_frame_resources): Declare.
5321
f7dfe5d6
JD
5322 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5323 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5324
5325 * nsterm.h (ns_get_defaults_value): Declare.
5326
5327 * nsterm.m (ns_default): Call ns_get_defaults_value.
5328
7cd4e72c
EZ
53292011-12-09 Eli Zaretskii <eliz@gnu.org>
5330
5331 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5332 (Bug#10170)
5333
b34d7317
YM
53342011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5335
5336 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5337 that where the value of an _OBJC_* symbol points to is in the .bss
5338 section (Bug#10240).
5339
76470ad1
KH
53402011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5341
5342 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5343 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5344
745fff94
KH
53452011-12-08 Kenichi Handa <handa@m17n.org>
5346
5347 * ftfont.c (get_adstyle_property): Fix previous change
5348 (Bug#10233).
5349
6e44397c
JB
53502011-12-07 Juanma Barranquero <lekktu@gmail.com>
5351
5352 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5353 dirs from the default value of EMACSLOADPATH (bug#10208).
5354
7efa6272
GM
53552011-12-07 Glenn Morris <rgm@gnu.org>
5356
5357 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5358 installation and source directories as well. (Bug#10208)
5359
f6fc4d87
CY
53602011-12-06 Chong Yidong <cyd@gnu.org>
5361
5362 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5363
2bf26180
GM
53642011-12-06 Glenn Morris <rgm@gnu.org>
5365
5366 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5367 as an error, not just -1. (Bug#10217)
5368
3a6ad4f0
CY
53692011-12-05 Chong Yidong <cyd@gnu.org>
5370
5371 * keyboard.c (process_special_events): New function.
5372 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5373
75a3b399
PE
53742011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5375
5376 * coding.c (encode_designation_at_bol): Don't use uninitialized
5377 local variable (Bug#9318).
5378
c3c9e25e
KH
53792011-12-05 Kenichi Handa <handa@m17n.org>
5380
5381 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5382 return Qnil (Bug#8046, Bug#10193).
5383
5eb05ea3
KH
53842011-12-05 Kenichi Handa <handa@m17n.org>
5385
5386 * coding.c (encode_designation_at_bol): New args charbuf_end and
5387 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5388 (coding_set_source): Return how many bytes coding->source was
5389 relocated.
5390 (coding_set_destination): Return how many bytes
5391 coding->destination was relocated.
5392 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5393 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5394
53952011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5396
5397 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5398 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5399 macro (Bug#9318).
5400
54012011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5402
5403 The following changes are to fix Bug#9318.
5404
a79703f5 5405 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5406 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5407 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5408 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5409
7dbda6df
JB
54102011-12-05 Juanma Barranquero <lekktu@gmail.com>
5411
5412 * lisp.h (process_quit_flag): Fix external declaration.
5413
6d5eb5b0
SM
54142011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5415
5416 Don't macro-inline non-performance-critical code.
5417 * eval.c (process_quit_flag): New function.
5418 * lisp.h (QUIT): Use it.
5419
a0c3fad0
JD
54202011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5421
5422 * nsfns.m (get_geometry_from_preferences): New function.
5423 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5424
6c07aac2
AS
54252011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5426
5427 * emacs.c (Qkill_emacs): Define.
5428 (syms_of_emacs): Initialize it.
5429 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5430 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5431 (quit_throw_to_read_char): Add parameter `from_signal'.
5432 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5433 * lisp.h (QUIT): Call Fkill_emacs if requested.
5434
c052ead4
JD
54352011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5436
5437 * widget.c (update_wm_hints): Return if wmshell is null.
5438 (widget_update_wm_size_hints): New function.
5439
5440 * widget.h (widget_update_wm_size_hints): Declare.
5441
5442 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5443 widget_update_wm_size_hints (Bug#10104).
5444
9e49252b
EZ
54452011-12-03 Eli Zaretskii <eliz@gnu.org>
5446
5447 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5448 before a newline, prepare the bidi iterator for consuming the
5449 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5450 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5451
02b16839
JL
54522011-12-02 Juri Linkov <juri@jurta.org>
5453
5454 * search.c (Fword_search_regexp): New Lisp function created from
5455 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5456 (Fword_search_backward, Fword_search_forward)
5457 (Fword_search_backward_lax, Fword_search_forward_lax):
5458 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5459 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5460
0068070e
SM
54612011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5462
5463 * fileio.c (Finsert_file_contents): Move after-change-function call
5464 to before the "handled:" label, since all "goto handled" appear in
5465 cases where the *-change-functions have already been properly called
5466 (bug#10117).
5467
3360a3fc
AS
54682011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5469
5470 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5471 waiting for input. (Bug#10169)
5472
73d6c093
EZ
54732011-11-30 Eli Zaretskii <eliz@gnu.org>
5474
5475 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5476 verifies glyph row's hash code--we have just reallocated the
5477 glyphs, so their contents can be complete garbage. (Bug#10164)
5478
febe6bea
JB
54792011-11-30 Juanma Barranquero <lekktu@gmail.com>
5480
5481 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5482
801a4313
EZ
54832011-11-30 Eli Zaretskii <eliz@gnu.org>
5484
5485 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5486 attributes are tested _before_ calling verify_row_hash, to protect
5487 against GCC re-ordering of the tests. (Bug#10164)
5488
2b56b87e
JD
54892011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5490
5491 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5492
5493 * xterm.c (handle_one_xevent): Only set async_visible and friends
5494 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5495 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5496 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5497
dbf31225
PE
54982011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5499
5500 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5501 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5502 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5503 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5504 All uses changed to use GCPRO1 etc.
5505 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5506 Revert to old implementation (i.e., before 2011-03-11).
5507
1305621b
YM
55082011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5509
5510 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5511 of scroll runs so as to avoid assigning disabled bogus rows and
5512 unnecessary graphics copy operations.
5513
8c9afb46
EZ
55142011-11-27 Eli Zaretskii <eliz@gnu.org>
5515
5516 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5517 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5518 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5519 (malloc, free, realloc, calloc): Redirect to e_* only when
5520 compiling Emacs.
5521
5522 * lisp.h (GCTYPEBITS): Move before first use.
5523 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5524 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5525 this macro definition.
5526
5527 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5528 _MSC_VER.
5529
54e9e3bf
JD
55302011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5531
6d5eb5b0
SM
5532 * gtkutil.c (xg_create_frame_widgets):
5533 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5534 present with Gtk+ 2.0.
5535
83aca1cb
PE
55362011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5537
5538 * fileio.c (Finsert_file_contents): Undo previous change; see
5539 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5540
5b76caa4
PE
55412011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5542
5543 Rename locals to avoid shadowing.
5544 * fileio.c (Finsert_file_contents):
5545 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5546 * process.c (wait_reading_process_output):
5547 Rename inner 'proc' to 'p' to avoid shadowing.
5548 Indent for consistency with usual Emacs style.
5549
8c535114
EZ
55502011-11-25 Eli Zaretskii <eliz@gnu.org>
5551
5552 * xdisp.c (redisplay_window): If cursor row is not fully visible
5553 after recentering, and scroll-conservatively is set to a large
5554 number, scroll window by a few more lines to make the cursor fully
5555 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5556 (start_display): Don't move to the next line if the display should
5557 start at a newline that is part of a display vector or an overlay
5558 string. (Bug#10119)
8c535114 5559
fa4fdb5c
JL
55602011-11-24 Juri Linkov <juri@jurta.org>
5561
5562 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5563 after the `MagickPingImage' call. (Bug#10112)
5564
90ec88df
CY
55652011-11-23 Chong Yidong <cyd@gnu.org>
5566
5567 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5568
56e2e794
MR
55692011-11-23 Martin Rudalics <rudalics@gmx.at>
5570
5571 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5572 making another buffer current. (Bug#10114)
5573
b6e64c41
GM
55742011-11-23 Glenn Morris <rgm@gnu.org>
5575
5576 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5577
6b21de18
CY
55782011-11-23 Chong Yidong <cyd@gnu.org>
5579
5580 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5581 using it (Bug#5984).
5582
b12cd789
EZ
55832011-11-22 Eli Zaretskii <eliz@gnu.org>
5584
5585 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5586 and header-lines, as they don't have one computed for them.
5587 (Bug#10098)
5588
5589 * .gdbinit (prow): Make displayed values more self-explaining.
5590 Add row's hash code.
5591
261b6fd4
LMI
55922011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5593
5594 * process.c (wait_reading_process_output): Fix asynchrounous
5595 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5596 (wait_reading_process_output): Add comment and URL.
261b6fd4 5597
e7cfd277
JD
55982011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5599
5600 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5601
a9b9b7f5
CY
56022011-11-21 Chong Yidong <cyd@gnu.org>
5603
5604 * window.c (Fnext_window, Fprevious_window): Doc fix.
5605
b0d15b4f
SM
56062011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5607
5608 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5609
fe7a3057
JB
56102011-11-20 Juanma Barranquero <lekktu@gmail.com>
5611
5612 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5613
d2999b1a
MR
56142011-11-20 Martin Rudalics <rudalics@gmx.at>
5615
5616 * window.c (Fset_window_combination_limit): Rename argument
5617 STATUS to LIMIT.
5618 (Vwindow_combination_limit): Remove "status" from doc-string.
5619
d5ff9cd0
AS
56202011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5621
5622 * m/ibms390.h: Remove.
5623 * m/ibms390x.h: Don't include "ibms390.h".
5624
a5bb9bd3
SM
56252011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5626
5627 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5628 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5629
cd1181db
JB
56302011-11-20 Juanma Barranquero <lekktu@gmail.com>
5631
5632 * casetab.c (Fset_case_table):
5633 * charset.c (Fcharset_after): Fix typos.
5634
615a3b8d 56352011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5636
17e845af
PE
5637 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5638 Otherwise, valgrind does not work on some platforms.
5639 Problem reported by Andreas Schwab in
6a0bf43d
PE
5640 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5641 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5642 is set, removing the need for VIRT_ADDRESS_VARIES.
5643 (PURE_P): Use a more-efficient implementation that needs just one
5644 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5645 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5646 to 4 (xorl, subq, cmpq, setbe).
5647 * alloc.c (pure): Always extern now, since that's the
5648 VIRT_ADDR_VARIES behavior.
5649 (PURE_POINTER_P): Use a single comparison, not two, for
5650 consistency with the new puresize.h.
5651 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5652 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5653 Remove VIRT_ADDR_VARIES no longer needed.
5654
f8fe6f96
EZ
56552011-11-19 Eli Zaretskii <eliz@gnu.org>
5656
5657 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5658 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5659 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5660 behave as if the cursor position were at the window margin.
5661
5662 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5663 and the cursor position is out of bounds, behave as if the cursor
5664 position were at the window margin. (Bug#10075)
5665
df05a53c
CY
56662011-11-18 Chong Yidong <cyd@gnu.org>
5667
5668 * window.c (Fwindow_combination_limit): Make first argument
5669 non-optional, since it is meaningless for live windows like the
5670 selected window.
61ccba97 5671
2071918e
DA
56722011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5673
5674 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5675
b50a28de
SM
56762011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5677
5678 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5679 (graft_intervals_into_buffer): Simplify.
5680
015137db
EZ
56812011-11-18 Eli Zaretskii <eliz@gnu.org>
5682
5683 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5684 hash values of the two rows.
5685 (copy_row_except_pointers): Preserve the used[] arrays and the
5686 hash values of the two rows. (Bug#10035)
68c95424 5687 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5688
5689 * xdisp.c (row_hash): New function, body extracted from
5690 compute_line_metrics.
5691 (compute_line_metrics): Call row_hash, instead of computing the
5692 hash code inline.
5693
5694 * dispnew.c (verify_row_hash): Call row_hash for computing the
5695 hash code of a row, instead of duplicating code from xdisp.c.
5696
5697 * dispextern.h (row_hash): Add prototype.
5698
a2addb04
TH
56992011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5700
5701 * frame.c (delete_frame): Don't delete the terminal when the last
5702 X frame is closed if emacs is built with GTK toolkit.
5703
df85d315
JB
57042011-11-17 Juanma Barranquero <lekktu@gmail.com>
5705
5706 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5707
a0c2d0ae
MR
57082011-11-17 Martin Rudalics <rudalics@gmx.at>
5709
5710 * window.c (Vwindow_splits): Rename to
5711 Vwindow_combination_resize. Suggested by Juri Linkov.
5712 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5713 of Vwindow_splits.
5714
58179cce
JB
57152011-11-16 Juanma Barranquero <lekktu@gmail.com>
5716
7877f373
JB
5717 * nsfns.m (Fns_font_name):
5718 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5719
b6f67890
MR
57202011-11-16 Martin Rudalics <rudalics@gmx.at>
5721
5722 * window.h (window): Rename slot "nest" to "combination_limit".
5723 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5724 (Fset_window_nest): Rename to Fset_window_combination_limit.
5725 (Vwindow_nest): Rename to Vwindow_combination_limit.
5726 (recombine_windows, make_parent_window, make_window)
5727 (Fsplit_window_internal, saved_window)
5728 (Fset_window_configuration, save_window_save): Rename all
5729 occurrences of window_nest to window_combination_limit.
5730
c7015153
JB
57312011-11-15 Juanma Barranquero <lekktu@gmail.com>
5732
5733 * image.c (imagemagick_load_image): Fix typo.
5734
322ad6ec
EZ
57352011-11-14 Eli Zaretskii <eliz@gnu.org>
5736
5737 * xdisp.c (display_line): Move the call to
5738 highlight_trailing_whitespace before the call to
5739 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5740 faces of all the glyphs to compute ROW's hash value.
5741 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5742
f067b8ec
JB
57432011-11-14 Juanma Barranquero <lekktu@gmail.com>
5744
5745 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5746 just return (bug#10044).
5747
1e5b2111
EZ
57482011-11-12 Eli Zaretskii <eliz@gnu.org>
5749
7ef3cbd5
EZ
5750 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5751 with user-defined heap size. Bump the default size of the temacs
5752 heap to 27MB, to avoid memory warning when running temacs.
5753 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5754
1e5b2111
EZ
5755 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5756 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5757 (verify_row_hash) [XASSERTS]: New function.
5758 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5759 that the hash value of glyph rows is correct.
1e5b2111 5760
89d61221
MR
57612011-11-12 Martin Rudalics <rudalics@gmx.at>
5762
5763 * window.h (window): Remove splits slot.
5764 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5765 (Fdelete_other_windows_internal, make_parent_window)
5766 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5767 (Fset_window_configuration, save_window_save): Don't deal with
5768 split status of windows.
5769 (saved_window): Remove splits slot.
5770 (Vwindow_splits): Rewrite doc-string.
5771
97f18cc8
JD
57722011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5773
5774 * xfns.c (unwind_create_frame):
5775 * nsfns.m (unwind_create_frame):
5776 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5777 Vframe_list (Bug#9999).
5778
22a648b4
DA
57792011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5780
0b381c7e 5781 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5782
659afede
KH
57832011-11-11 Kenichi Handa <handa@m17n.org>
5784
5785 * callproc.c (Fcall_process): Set the member dst_multibyte of
5786 process_coding.
5787
9ac0394b
KH
57882011-11-11 Johan Bockgård <bojohan@gnu.org>
5789
5790 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5791 avoid a crash (bug#9496).
5792
2fbdc249
CY
57932011-11-09 Chong Yidong <cyd@gnu.org>
5794
5795 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5796 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5797
ac6b1f81
PE
57982011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5799
5800 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5801
09db192c
PE
58022011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5803
5804 Avoid some portability problems by eschewing 'extern inline' functions.
5805 The trivial performance wins aren't worth the portability hassles; see
5806 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5807 et seq.
5808 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5809 (window_box_width, window_box_left, window_box_left_offset)
5810 (window_box_right, window_box_right_offset): Undo previous change,
5811 by removing the "extern"s.
5812 * intervals.c (adjust_intervals_for_insertion)
5813 (adjust_intervals_for_deletion): Undo previous change,
5814 making these static again.
5815 (offset_intervals, temp_set_point_both, temp_set_point)
5816 (copy_intervals_to_string): No longer inline.
5817 * xdisp.c (window_text_bottom_y, window_box_width)
5818 (window_box_height, window_box_left_offset)
5819 (window_box_right_offset, window_box_left, window_box_right)
5820 (window_box): No longer inline.
5821
105216ed
CY
58222011-11-08 Chong Yidong <cyd@gnu.org>
5823
5824 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5825 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5826 Signal an error if not a live window.
105216ed
CY
5827 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5828 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5829
ae9e237f
JB
58302011-11-07 Juanma Barranquero <lekktu@gmail.com>
5831
5832 * lisp.h (syms_of_abbrev): Remove declaration.
5833 Reported by CHENG Gao <chenggao@royau.me>.
5834
c7aa8333
EZ
58352011-11-07 Eli Zaretskii <eliz@gnu.org>
5836
5837 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5838 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5839 of temacs in GUI mode.
5840
be7f5545
MR
58412011-11-07 Martin Rudalics <rudalics@gmx.at>
5842
5843 * window.h: Declare delete_all_child_windows instead of
5844 delete_all_subwindows.
5845 * window.c (Fwindow_nest, Fset_window_nest)
5846 (Fset_window_new_total, Fset_window_new_normal)
5847 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5848 (delete_all_subwindows): Rename to delete_all_child_windows.
5849 (Fdelete_other_windows_internal, Fset_window_configuration):
5850 Call delete_all_child_windows instead of delete_all_subwindows.
5851 * frame.c (delete_frame): Call delete_all_child_windows instead
5852 of delete_all_subwindows.
5853
ca78dc43
PE
58542011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5855
5856 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5857 This is also needed for porting to any host where GC_MARK_STACK is
5858 not GC_MAKE_GCPROS_NOOPS.
5859 (which_symbols): Use it.
5860
a0241d01
KH
58612011-11-07 Kenichi Handa <handa@m17n.org>
5862
5863 * coding.c (coding_set_destination): Check coding->src_pos only
5864 when coding->src_object is a buffer (bug#9910).
5865
5866 * process.c (send_process): Set the member src_multibyte of coding
5867 to 0 (bug#9911) when sending a unibyte text.
5868
5869 * callproc.c (Fcall_process): Set the member src_multibyte of
5870 process_coding to 0 (bug#9912).
5871
a64bfdfa 58722011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5873
5874 * xmenu.c (cleanup_widget_value_tree): New function.
5875 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5876 calling free_menubar_widget_value_tree directly (Bug#9830).
5877
cb41b32a
PE
58782011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5879
5880 Fix some portability problems with 'inline'.
5881 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5882 (window_box_width, window_box_left, window_box_left_offset)
5883 (window_box_right, window_box_right_offset): Declare extern.
5884 Otherwise, these inline functions do not conform to C99 and
5885 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5886 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5887 * intervals.c (adjust_intervals_for_insertion)
5888 (adjust_intervals_for_deletion): Now extern, because otherwise the
5889 extern inline functions 'offset_intervals' couldn't refer to it.
5890 (static_offset_intervals): Remove.
5891 (offset_intervals): Rewrite using the old contents of
5892 static_offset_intervals. The old version didn't conform to C99
5893 because an extern inline function contained a reference to an
5894 identifier with static linkage.
5895
b7041366
AS
58962011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5897
5898 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5899 GC.
5900
88a37c4d
EZ
59012011-11-06 Eli Zaretskii <eliz@gnu.org>
5902
5903 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5904 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5905 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5906 return Qleft_to_right.
5907
49745b39
CY
59082011-11-06 Chong Yidong <cyd@gnu.org>
5909
5910 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5911 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5912 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5913 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5914 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5915 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5916 (Fwindow_vscroll): Doc fix.
5917 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5918 argument, since it makes no sense to pass a live window and for
5919 consistency with window-child.
5920
1f05cd82
CS
59212011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5922
5923 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5924 support MSVC.
5925
22610910
JR
59262011-11-05 Jason Rumney <jasonr@gnu.org>
5927
5928 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5929 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5930 fonts (Bug#6029).
5931 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5932 bitwise arithmetic preventing use of unicode-sip and non-truetype
5933 opentype fonts.
5934
a06776b2
EZ
59352011-11-05 Eli Zaretskii <eliz@gnu.org>
5936
3ad924ba
EZ
5937 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5938 "emacs"-only part.
5939
a06776b2
EZ
5940 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5941 initialization code to keep similarity to xfns.c after changes
5942 from 2011-11-05.
5943
c9e7db78
JD
59442011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5945
a97f8f3f
JD
5946 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5947 (unwind_create_frame): New function (Bug#9943).
5948 (Fx_create_frame): Restructure code to be more similar to the one in
5949 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5950 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5951 Move terminal->reference_count++ just before making the frame official
5952 (Bug#9943).
5953
5954 * nsterm.m (x_free_frame_resources): New function.
5955 (x_destroy_window): Move code to x_free_frame_resources.
5956
c9e7db78 5957 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5958 (Fx_create_frame, x_create_tip_frame):
5959 Move terminal->reference_count++ just before making the frame
75f1671a 5960 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5961 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5962
a6fc3b5c
EZ
59632011-11-05 Eli Zaretskii <eliz@gnu.org>
5964
5965 Support MSVC build with newer versions of Visual Studio.
5966 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5967 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5968 nt/gmake.defs.
5969
5970 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5971 which are not supported by MSVC.
5972 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5973 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5974 bitfields.
5975 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5976 types in bitfields.
5977 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5978
5979 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5980
58179cce 59812011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5982
5983 Support MSVC build with newer versions of Visual Studio.
5984 * w32.c: Don't include w32api.h for MSVC.
5985 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5986
5987 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5988 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5989 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5990 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5991 e_* cousins.
5992 (alloca) [_MSC_VER]: Define to _alloca.
5993
5994 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5995
5996 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5997
a58c13ed
EZ
59982011-11-04 Eli Zaretskii <eliz@gnu.org>
5999
6000 * xdisp.c (note_mouse_highlight): If either of
6001 previous/next-single-property-change returns nil, treat that as
6002 the beginning or the end of the buffer. (Bug#9955)
6003
fe0b6370
JD
60042011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6005
a58c13ed 6006 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6007 label is not null (Bug#9951).
6008 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6009 may be NULL.
6010
89bd5ee1
EZ
60112011-11-04 Eli Zaretskii <eliz@gnu.org>
6012
6013 * window.c (Fwindow_body_size): Mention in the doc string that the
6014 return value is in frame's canonical units. (Bug#9949)
6015
84c3edb9
EZ
60162011-11-03 Eli Zaretskii <eliz@gnu.org>
6017
4e2fb5c7
EZ
6018 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6019
84c3edb9 6020 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6021 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6022 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6023
bc17a887
EZ
60242011-11-01 Eli Zaretskii <eliz@gnu.org>
6025
6026 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6027 Don't stop backward scan on the continuation glyph, even though
6028 its CHARPOS is positive.
6d5eb5b0
SM
6029 (mouse_face_from_buffer_pos, note_mouse_highlight):
6030 Rename cover_string to disp_string.
bc17a887 6031
4ee88440
MR
60322011-11-01 Martin Rudalics <rudalics@gmx.at>
6033
6034 * window.c (temp_output_buffer_show): Don't use
6035 Vtemp_buffer_show_specifiers.
6036 (Vtemp_buffer_show_specifiers): Remove unused variable.
6037
c2ff3c02
EZ
60382011-10-30 Eli Zaretskii <eliz@gnu.org>
6039
6040 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6041 past the beginning of the current glyph matrix.
6042
58179cce 60432011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6044
6045 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6046 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6047 HAVE_GTK3 (Bug#9869).
b77a6a7f 6048
3b574623
JD
6049 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6050 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6051
b77a6a7f
JD
6052 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6053
6054 * xterm.c: Declare x_handle_net_wm_state to return int.
6055 (handle_one_xevent): Check if we are iconified but don't have
6056 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6057 (get_current_wm_state): Return non-zero if not hidden,
6058 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6059 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6060 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6061 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6062
196e41e4
PE
60632011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6066 so that this new function doesn't get optimized away by a
6067 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6068
021f2e1a
AS
60692011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6070
6071 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6072
8b058d44
EZ
60732011-10-29 Eli Zaretskii <eliz@gnu.org>
6074
6075 Fix the `xbytecode' command.
6076 * .gdbinit (xprintbytestr): New command.
b50a28de 6077 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6078 (xbytecode): Print the byte-code string as well.
6079
4452fb80
EZ
60802011-10-29 Kim Storm <storm@cua.dk>
6081
8b058d44
EZ
6082 * alloc.c (which_symbols): New function.
6083
21b72067
AS
60842011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6085
6086 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6087 line. (Bug#9903)
6088
83ed7b5c
GM
60892011-10-29 Glenn Morris <rgm@gnu.org>
6090
6091 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6092 Not clear what it was for, and it causes various bugs. (Bug#9839)
6093
5a7a728b
EZ
60942011-10-28 Eli Zaretskii <eliz@gnu.org>
6095
6096 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6097 possible random value that matches one of those tested as
6098 condition to clear the mouse face.
6099
d3d0842f
CY
61002011-10-28 Chong Yidong <cyd@gnu.org>
6101
6102 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6103
31b39d13
DN
61042011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6105
6106 * window.c (make_window): Initialize phys_cursor_on_p.
6107
9aba6043
SM
61082011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6109
6110 * lisp.h (struct Lisp_Symbol): Update comments.
6111
c20992f4
JB
61122011-10-28 Juanma Barranquero <lekktu@gmail.com>
6113
6114 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6115
db4f02f2
EZ
61162011-10-28 Eli Zaretskii <eliz@gnu.org>
6117
6118 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6119 <oslsachem@gmail.com> for helping to debug this.
6120
6121 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6122 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6123 (g_b_init_get_glyph_outline_w): New static variables.
6124 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6125 (GetGlyphOutlineW_Proc): New typedefs.
6126 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6127 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6128 New functions.
6129 (w32font_open_internal, compute_metrics):
6130 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6131 instead of calling the "wide" APIs directly.
6132
6133 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6134
6135 * w32.h (syms_of_w32font): Add prototype.
6136
87e68db4
JB
61372011-10-27 Juanma Barranquero <lekktu@gmail.com>
6138
6139 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6140 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6141 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6142 (Fmove_to_window_line): Doc fix.
6143
435c1d67
CY
61442011-10-27 Chong Yidong <cyd@gnu.org>
6145
6146 * process.c (make_process): Set gnutls_state to NULL.
6147
6148 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6149 non-NULL, regardless of GNUTLS_INITSTAGE.
6150 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6151 an error. Set process slots as soon as we allocate them.
6152
6153 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6154
9c6c6f49
CY
61552011-10-27 Chong Yidong <cyd@gnu.org>
6156
9aba6043
SM
6157 * gnutls.c (emacs_gnutls_deinit): New function.
6158 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6159 (Fgnutls_deinit, Fgnutls_boot): Use it.
6160
6161 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6162 (deactivate_process): Call emacs_gnutls_deinit.
6163
657d08d3
JB
61642011-10-27 Juanma Barranquero <lekktu@gmail.com>
6165
6166 * image.c (x_create_x_image_and_pixmap):
6167 * w32.c (sys_rename, w32_delayed_load):
6168 * w32font.c (fill_in_logfont):
6169 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6170
5430d399
JB
61712011-10-26 Juanma Barranquero <lekktu@gmail.com>
6172
6173 * w32fns.c (w32_default_color_map): New function,
6174 extracted from Fw32_default_color_map.
a7ef684b 6175 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6176
fe0055fa
PE
61772011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6178
6179 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6180
e6346438
SM
61812011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6182
6183 * keyboard.c (test_undefined): New function (bug#9751).
6184 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6185
e112cc37
ET
61862011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6187
6188 * sysdep.c (init_sys_modes): Fix the check for the controlling
6189 terminal (Bug#6649).
6190
7b5d6677
EZ
61912011-10-20 Eli Zaretskii <eliz@gnu.org>
6192
6193 * dispextern.h (struct bidi_it): New member next_en_type.
6194
6195 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6196 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6197 current character, check also for next_en_type being WEAK_EN.
6198 (bidi_resolve_weak): Don't enter the expensive loop if the current
6199 position is before next_en_pos. Record the bidi type of the first
6200 non-ET, non-BN character we find, in addition to its position.
6201 (bidi_level_of_next_char): Invalidate next_en_type when
6202 next_en_pos is over-stepped.
6203
7da0b018
PE
62042011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6205
6206 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6207 * editfns.c: Rewrite current-time-zone so that it invokes
6208 the equivalent of (format-time-string "%Z") to get the time zone name.
6209 This fixes a bug when the time zone name contains characters that
6210 need converting from the system time locale to Emacs internal format.
6211 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6212 that patch fixed format-time-string to do the conversion, but
6213 I forgot to fix current-time-zone.
6214 (format_time_string): New function, containing most of
6215 what Fformat_time_string used to contain.
6216 (Fformat_time_string): Rewrite in terms of format_time_string.
6217 This doesn't change this function's behavior.
6218 (current-time-zone): Rewrite to use format_time_string.
6219 This fixes the bug reported by Michael Schierl in
6220 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6221 Jason Rumney's 2007-06-07 change worked around this bug, but
6222 didn't fix it.
6223 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6224
8547b010
EZ
62252011-10-19 Eli Zaretskii <eliz@gnu.org>
6226
6227 * xdisp.c (start_display): If the character at POS is displayed
6228 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6229 (try_window_reusing_current_matrix): If a line ends in a display
6230 vector or the next line starts in a display vector, continue
6231 redrawing the window even though the character position of
6232 start_row was reached.
8547b010
EZ
6233 (Bug#9771, part 2)
6234
4e948d15
CY
62352011-10-18 Chong Yidong <cyd@gnu.org>
6236
6237 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6238 with nobreak-char-display too.
6239
4787455f
EZ
62402011-10-18 Eli Zaretskii <eliz@gnu.org>
6241
6242 Fix part 3 of bug#9771.
6243 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6244 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6245 non-neutral characters if the current character is a paragraph
6246 separator (a.k.a. Newline). This avoids running the same
6247 expensive loop twice, once when we consume the preceding newline
6248 and the other time when the line actually needs to be displayed.
6249 Avoid the loop when we see neutrals on the base embedding level
6250 following a character whose directionality is the same as the
6251 paragraph's. This avoids running the expensive loop when a line
6252 ends in a long sequence of neutrals, like control characters.
6253 Add assertion against STRONG_AL type. Slightly rearrange code
6254 that determines the type of a neutral given the first non-neutral
6255 that follows it.
6256 (bidi_level_of_next_char): Set next_en_pos to zero when
6257 invalidating its info.
6258
2c91f553
EZ
62592011-10-17 Eli Zaretskii <eliz@gnu.org>
6260
6261 * xdisp.c (push_display_prop): Determine whether to record string
6262 or buffer position by IT->string, not by IT->method. Allow
6263 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6264 (move_it_vertically_backward): Don't look for character position
6265 immediately after the newline when in a continuation line.
6266 (Bug#9771, part 1)
2c91f553 6267
c7b08b0d
MR
62682011-10-15 Martin Rudalics <rudalics@gmx.at>
6269
6270 * window.c (coordinates_in_window): Rewrite and delabelize
6271 vertical border check. (Bug#5357) (Bug#9618)
6272
6b02f655
SM
62732011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6274
6275 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6276 errors in XSetWindowBorder (bug#9310).
6277
81d40c92
DA
62782011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6279
6280 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6281 avoid crash when xmalloc overrun checking is enabled.
6282
d4172c3b
EZ
62832011-10-13 Eli Zaretskii <eliz@gnu.org>
6284
6285 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6286 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6287 cursor motion with <left> and <right> arrow keys.
6288
6289 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6290 some callers set that themselves.
6291
b00eea75
EZ
62922011-10-12 Eli Zaretskii <eliz@gnu.org>
6293
6294 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6295 display string and the previous row comes from the same string and
6296 is empty. (Bug#9739) (Bug#9738)
6297
8fe012c4
SM
62982011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6299
6300 * doc.c (get_doc_string): Encode file name (bug#9735).
6301
0074aef2
EZ
63022011-10-12 Eli Zaretskii <eliz@gnu.org>
6303
79beb178
EZ
6304 * bidi.c (bidi_level_of_next_char):
6305 * xdisp.c (get_visually_first_element): Remove old incorrect
6306 comments regarding the Unicode Line Separator character.
6307
0074aef2
EZ
6308 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6309
6e4b3fbe
DA
63102011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6311
6312 * alloc.c (Fgc_status): Do not access beyond zombies array
6313 boundary if nzombies > MAX_ZOMBIES.
6314 * alloc.c (dump_zombies): Add missing format specifier.
6315
0324f3af
PE
63162011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6317
b5525cac
PE
6318 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6319 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6320
0324f3af
PE
6321 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6322 Some packages use them to denote characters with modifiers.
6323
e9b5f888
AS
63242011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6325
6326 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6327 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6328 matching a pp-number. Rename parameter var to var1.
6329
127827c0
SM
63302011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6331
6332 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6333
c8fd3bd0
GM
63342011-10-08 Glenn Morris <rgm@gnu.org>
6335
6336 * callint.c (Fcall_interactively): Give a more explicit error for the
6337 'c' case with a non-character input. (Bug#8479)
6338
352ec8ff
EZ
63392011-10-08 Eli Zaretskii <eliz@gnu.org>
6340
03669ccb
EZ
6341 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6342 lines.
7061c986
EZ
6343 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6344 lines that are hscrolled on the left.
03669ccb 6345
352ec8ff
EZ
6346 * dispnew.c (buffer_posn_from_coords): Account for a possible
6347 presence of header-line. (Bug#4426)
6348
a66cfb1c
SM
63492011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6350
6b02f655
SM
6351 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6352 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6353
7c5ee88e
PE
63542011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6355
6356 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6357 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6358 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6359 this makes Emacs dump core during garbage collection on rare
6360 occasions. sizeof is obviously inferior to offsetof here, so
6361 stick with offsetof.
6362 (GC_POINTER_ALIGNMENT): New macro.
6363 (mark_memory): Omit 3rd (offset) arg; caller changed.
6364 Don't assume EMACS_INT alignment is the same as pointer alignment.
6365
df1bbe5b
SM
63662011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6367
6368 * keyboard.c (read_key_sequence_remapped): New var.
6369 (read_key_sequence): Compute remapping in the right buffer.
6370 (command_loop_1): Use read_key_sequence's remapping directly.
6371
51553db6
SM
63722011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6373
32c1fffd
SM
6374 * dired.c (file_name_completion): Don't expand file name.
6375 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6376 before checking file name handler.
6377
51553db6
SM
6378 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6379 they've been requested explicitly (bug#9591).
6380
b6bd1599 63812011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6382
6383 * keymap.c (Fsingle_key_description): Use make_specified_string
6384 instead of build_string to build string from push_key_description.
6385 (Bug#5193)
6386
f701dc2a
PE
63872011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6388
4222c55d
PE
6389 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6390 This fixes a Y2038 bug on 64-bit hosts.
6391 * buffer.c (reset_buffer):
6392 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6393 (Fclear_buffer_auto_save_failure):
6394 Use 0, not -1, to represent an unset failure time, since time_t
6395 might not be signed.
6396
f701dc2a
PE
6397 Remove dependency on glibc malloc internals.
6398 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6399 Move back here from lisp.h, but with their new implementations.
6400 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6401 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6402 * charset.c (charset_table_init): New static var.
6403 (syms_of_charset): Use it instead of xmalloc. This removes a
6404 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6405 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6406 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6407 Move back to alloc.c.
6408 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6409 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6410
9ceebf39
JD
64112011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6412
6413 * nsterm.m (windowDidResize): Call x_set_window_size only when
6414 ns_in_resize is true. Otherwise set pixelwidth/height and
6415 call change_frame_size (Bug#9628).
6416
cb993c58
PE
64172011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6418
3930c88b
PE
6419 Port --enable-checking=all to Fedora 14 x86-64.
6420 * charset.c (syms_of_charset): Also account for glibc malloc's
6421 internal overhead when calculating the initial malloc maximum.
6422
cb993c58
PE
6423 Port --enable-checking=all to Fedora 14 x86.
6424 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6425 Move to lisp.h.
6426 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6427 (overrun_check_realloc, overrun_check_free):
6428 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6429 That way, xmalloc returns a properly-aligned pointer even if
6430 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6431 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6432 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6433 into account when calculating the initial malloc maximum.
6434 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6435 Move here from alloc.c, so that charset.c can use it too.
6436 Properly align; the old code wasn't right for common 32-bit hosts
6437 when configured with --enable-checking=all.
6438 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6439 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6440
31bed486
EZ
64412011-09-29 Eli Zaretskii <eliz@gnu.org>
6442
04c70788 6443 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6444 use EDOM.
6445
fbcaa2f3
EZ
64462011-09-28 Eli Zaretskii <eliz@gnu.org>
6447
6448 * xdisp.c (compute_display_string_end): If there's no display
6449 string at CHARPOS, return -1.
6450
6451 * bidi.c (bidi_fetch_char): When compute_display_string_end
6452 returns a negative value, treat the character as a normal
6453 character not covered by a display string. (Bug#9624)
6454
a239d4e9
JB
64552011-09-28 Juanma Barranquero <lekktu@gmail.com>
6456
6457 * lread.c (Fread_from_string): Fix typo in docstring.
6458
88652fd5
EZ
64592011-09-27 Eli Zaretskii <eliz@gnu.org>
6460
6461 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6462 newline, reseat the iterator instead of bidi-iterating there one
6463 character at a time. (Bug#9610)
32c1fffd
SM
6464 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6465 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6466
ed497dd4
AS
64672011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6468
6469 * lread.c (readevalloop): Use correct code for NBSP.
6470 (read1): Likewise. (Bug#9608)
6471
b2bf61aa
MA
64722011-09-25 Michael Albinus <michael.albinus@gmx.de>
6473
6474 * dbusbind.c (Fdbus_register_signal): When service is not
6475 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6476
32bbb17c
GM
64772011-09-25 Glenn Morris <rgm@gnu.org>
6478
6479 * buffer.c (truncate-lines): Doc fix.
6480
94e0933e
CY
64812011-09-24 Chong Yidong <cyd@stupidchicken.com>
6482
6483 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6484 (Fset_window_next_buffers): Doc fix.
6485
cddde921
GM
64862011-09-24 Glenn Morris <rgm@gnu.org>
6487
6488 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6489
1260aef1
PE
64902011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6491
25b4bfa0
PE
6492 Fix minor problems found by static checking.
6493 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6494 * indent.c (Fvertical_motion): Fix == vs = typo.
6495
e3cbd34b
EZ
64962011-09-24 Eli Zaretskii <eliz@gnu.org>
6497
a66cfb1c
SM
6498 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6499 Default value is now t. Doc fix.
6bf7006f 6500
e3cbd34b 6501 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6502 logic when moving up, not only when moving down. Fix the
e3cbd34b 6503 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6504 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6505
6506 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6507 CHARPOS is covered by a display string which includes newlines.
6508 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6509 is covered by a display string with embedded newlines.
6510
a3de0cbd
MA
65112011-09-24 Michael Albinus <michael.albinus@gmx.de>
6512
6513 * dbusbind.c (Fdbus_register_signal): Add match rule to
6514 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6515 (Fdbus_register_method, Vdbus_registered_objects_table):
6516 Fix docstring.
a3de0cbd 6517
b260039d
JM
65182011-09-24 Jim Meyering <meyering@redhat.com>
6519
32c1fffd 6520 do not ignore write error for any output size
b260039d
JM
6521 The previous change was incomplete.
6522 While it makes emacs --batch detect the vast majority of stdout
6523 write failures, errors were still ignored whenever the output size is
6524 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6525 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6526 && echo FAIL: ignored write error
6527 FAIL: ignored write error
6528 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6529 && echo FAIL: ignored write error
6530 FAIL: ignored write error
6531 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6532
8eca8a7c
AS
65332011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6534
6535 * emacs.c (Fkill_emacs): In noninteractive mode exit
6536 non-successfully if a write error occurred on stdout. (Bug#9574)
6537
3341db62
EZ
65382011-09-21 Eli Zaretskii <eliz@gnu.org>
6539
6540 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6541 the xassert test.
6542
6543 * dispextern.h (struct it): Update the comment documenting what
6544 can it->OBJECT be.
6545
8c203dbf
EZ
65462011-09-20 Eli Zaretskii <eliz@gnu.org>
6547
6548 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6549 a display string, extend search for cursor position to end of row.
6550 (find_row_edges): If the row ends in a newline from a display
6551 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6552 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6553 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6554 non-empty line. Fixes confusing cursor motion with arrow keys at
6555 the beginning of a line that starts with whitespace.
8c203dbf 6556
a4824228
LMI
65572011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6558
6559 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6560 (bug#9493).
6561
33ed493b
CY
65622011-09-18 Chong Yidong <cyd@stupidchicken.com>
6563
6564 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6565 boolean (Bug#9154).
6566
56cd55c8
EZ
65672011-09-18 Eli Zaretskii <eliz@gnu.org>
6568
6569 * xdisp.c (display_line): Record maximum and minimum buffer
6570 positions even if no glyphs were produced (e.g., by a zero-width
6571 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6572 buffer positions that will be removed from the glyph row because
6573 they don't fit.
c02dcedf
EZ
6574 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6575 column is beyond frame width: don't subtract 1 "pixel" when
6576 computing width of the stretch.
3e62b7e0
EZ
6577 (reseat_at_next_visible_line_start): Undo the change made on
6578 2011-09-17 that saved paragraph information and restored it after
6579 the call to `reseat'. (Bug#9545)
56cd55c8 6580
5ed99d36 65812011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6582
6583 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6584 and turn window cursor on if cleared (Bug#9415).
6585
5ed99d36 65862011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6587
6588 * search.c (boyer_moore): Take unibyte characters from pattern
6589 literally. (Bug#9458)
6590
9bade7b2
EZ
65912011-09-18 Eli Zaretskii <eliz@gnu.org>
6592
6593 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6594
e5e9d610
PE
65952011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6596
87e4427a
PE
6597 Fix minor problem found by static checking.
6598 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6599 initialized, to pacify gcc -Wuninitialized.
6600
e5e9d610
PE
6601 * fileio.c: Report proper errno when syscall falls.
6602 (Finsert_file_contents): Save and restore errno,
6603 so that report_file_error outputs the correct diagnostic.
6604 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6605
a1674f0b
EZ
66062011-09-18 Eli Zaretskii <eliz@gnu.org>
6607
6608 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6609
fbfb6dd4
EZ
66102011-09-17 Eli Zaretskii <eliz@gnu.org>
6611
6612 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6613 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6614
bb187662
EZ
66152011-09-17 Eli Zaretskii <eliz@gnu.org>
6616
1137e8b8 6617 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6618 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6619
6620 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6621 (bidi_find_paragraph_start): Search back for paragraph beginning
6622 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6623 (bidi_move_to_visually_next): Only trigger paragraph-related
6624 computations when the last character is a newline or at EOB, not
6625 just any NEUTRAL_B. (Bug#9470)
6626
bb187662
EZ
6627 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6628 truncated lines if point is covered by a display string. (Bug#9524)
6629
2e621251
PE
66302011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6631
6632 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6633 (cons_to_x_long): New function.
6634 (lisp_data_to_selection_data): Use it. Correct the test for
6635 short-versus-long data; it was negated. Break out of vector
6636 loop, for efficiency, when a long datum is discovered.
6637
91a15bc6
SM
66382011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6639
6640 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6641
b41c3a35
EZ
66422011-09-16 Eli Zaretskii <eliz@gnu.org>
6643
6644 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6645 GCC PR/17406) by declaring this function with external scope.
6646
7812ba2d
PE
66472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6648
6649 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6650 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6651
cf7edc2a
AS
66522011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6653
6654 * editfns.c (Fformat): Correctly handle text properties on "%%".
6655
bd01620e
EZ
66562011-09-15 Eli Zaretskii <eliz@gnu.org>
6657
6658 * xterm.c (x_draw_composite_glyph_string_foreground):
6659 * w32term.c (x_draw_composite_glyph_string_foreground):
6660 * term.c (encode_terminal_code):
6661 * composite.c (composition_update_it, get_composition_id):
6662 * xdisp.c (get_next_display_element)
6663 (fill_composite_glyph_string): Add comments about special meaning
6664 of TAB characters in a composition.
6665
a02719a3
PE
66662011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6667
6668 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6669 This occurs when processing a multibyte format.
6670 Problem reported by Wolfgang Jenker.
a02719a3 6671
72589a3c
JB
66722011-09-15 Johan Bockgård <bojohan@gnu.org>
6673
6674 * xdisp.c (try_cursor_movement): Only check for exact match if
6675 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6676
1c14176c
PE
66772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6678
6679 Remove unused external symbols.
6680 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6681 * xdisp.c (calc_pixel_width_or_height): Now static.
6682 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6683 * indent.c (check_display_width):
6684 * w32term.c: Fix comment to match code.
6685 * xterm.c, xterm.h (x_catching_errors): Remove.
6686
d2eea5b5
PE
66872011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6688
6689 * xselect.c: Use signed conversions more consistently (Bug#9498).
6690 (selection_data_to_lisp_data): Assume incoming selection data are
6691 signed integers, not unsigned. This is to be consistent with
6692 outgoing selection data, which was modified to use signed integers
6693 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6694 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6695 expects long, not unsigned long.
6696
46888499
EZ
66972011-09-14 Eli Zaretskii <eliz@gnu.org>
6698
6699 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6700 computation of loop end. Reported by Johan Bockgård
6701 <bojohan@gnu.org>.
6702
ef8ef9fb
CY
67032011-09-13 Chong Yidong <cyd@stupidchicken.com>
6704
6705 * frame.c (Fother_visible_frames_p): Function deleted.
6706
fa819fed
EZ
67072011-09-12 Eli Zaretskii <eliz@gnu.org>
6708
6709 * indent.c (compute_motion): Process display vector front to back
6710 rather than the other way around. (Bug#2496)
6711
2ba8e008
SM
67122011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6713
6714 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6715
20f53c69
CY
67162011-09-11 Chong Yidong <cyd@stupidchicken.com>
6717
6718 * minibuf.c (Fread_from_minibuffer): Doc fix.
6719
d562d7a4
EZ
67202011-09-11 Eli Zaretskii <eliz@gnu.org>
6721
6722 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6723 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6724
1c4d7f3d
LMI
67252011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6726
6727 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6728 value for non-existent files.
6729
b885bf36
EZ
67302011-09-11 Eli Zaretskii <eliz@gnu.org>
6731
6732 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6733 set its "size" to -1. This will set the modtime_size field of
6734 the corresponding buffer to -1, which is what
6735 verify-visited-file-modtime expects for files that do not exist.
6736 (Bug#9139)
6737
6612f0bf
PE
67382011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6739
6740 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6741 here ...
6742 * lisp.h: ... from here. push_key_description is no longer
6743 defined in keyboard.c, so its declaration should not be in
6744 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6745 logically belongs with push_key_description.
6746
dfb3f755
PE
67472011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6748
6749 * buffer.h: Include <sys/types.h> instead of <time.h>.
6750 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6751 Problem reported by Herbert J. Skuhra.
6752
3134906c
LMI
67532011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6754
6755 * xml.c (parse_region): Make the parsing work for
6756 non-comment-starting XML files again (bug#9144).
6757
8d903f4e
AS
67582011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6759
6760 * image.c (gif_load): Fix calculation of bottom and right corner.
6761 (Bug#9468)
6762
80ad64f4
EZ
67632011-09-10 Eli Zaretskii <eliz@gnu.org>
6764
6765 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6766 redisplay in small windows.
6767
208a048d
EZ
67682011-09-09 Eli Zaretskii <eliz@gnu.org>
6769
6770 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6771
9b1c252e
MR
67722011-09-08 Martin Rudalics <rudalics@gmx.at>
6773
6774 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6775 Operate on live windows only.
6776
2949f33b
JB
67772011-09-08 Juanma Barranquero <lekktu@gmail.com>
6778
6779 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6780
e08dcafd
EZ
67812011-09-07 Eli Zaretskii <eliz@gnu.org>
6782
6783 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6784 only under bidi iteration.
6785
115b96bd
JD
67862011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6787
6788 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6789
c8199d0f
PE
67902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6791
6792 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6793 Without this fix, the command to link temacs failed due to an
6794 undefined symbol __builtin_isnan. This is because
6795 /usr/include/iso/math_c99.h #defines isnan(x) to
6796 __builtin_isnan(x), but the bundled gcc, which identifies itself
6797 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6798 a __builtin_isnan.
6799 * floatfns.c (isnan): #undef, and then #define to a clone of
6800 what's in data.c.
6801 (Fisnan): Always define, since it's always available now.
6802 (syms_of_floatfns): Always define isnan at the Lisp level.
6803
e39b275c 68042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6805
6806 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6807
b2db44d9 68082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6809
f4af5137 6810 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6811 The previous code assumed that file offsets (off_t values) fit in
6812 EMACS_INT variables, which is not true on typical 32-bit hosts.
6813 The code messed up by falsely reporting buffer overflow in cases
6814 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6815 when "big" contains more than 2**29 bytes, even though this
6816 inserts just one byte and does not overflow the buffer.
6817 (Finsert_file_contents): Store file offsets as off_t
6818 values, not as EMACS_INT values. Check for overflow when
6819 converting between EMACS_INT and off_t. When checking for
6820 buffer overflow or for overlap, take the offsets into account.
6821 Don't use EMACS_INT for small values where int suffices.
6822 When checking for overlap, fix a typo: ZV was used where
6823 ZV_BYTE was intended.
6824 (Fwrite_region): Don't assume off_t fits into 'long'.
6825 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6826
ecfc0a49
MA
68272011-09-05 Michael Albinus <michael.albinus@gmx.de>
6828
6829 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6830
6511acf2 68312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6832
0999621a 6833 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6834
6835 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6836 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6837 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6838 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6839 (modify_event_symbol): Do not assume that the length of
6840 name_alist_or_stem is safe to alloca and fits in int.
6841 (Fexecute_extended_command): Likewise for function name and binding.
6842 (Frecursion_depth): Wrap around reliably on integer overflow.
6843 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6844 since some callers pass EMACS_INT values.
6845 (Fsingle_key_description): Don't crash if symbol name contains more
6846 than MAX_ALLOCA bytes.
6847 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6848 (get_minibuffer): Arg is now EMACS_INT, not int.
6849 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6850 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6851 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6852
2be7d702
PE
6853 * dbusbind.c (signature_cat): New function.
6854 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6855 Do not overrun buffer; instead, report string overflow.
6856
9d1df220
PE
6857 * dispnew.c (add_window_display_history): Don't overrun buffer.
6858 Truncate instead; this is OK since it's just a log.
6859
33ef5c64
PE
6860 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6861 even if the time zone offset is outlandishly large.
6862 Don't mishandle offset == INT_MIN.
6863
66c6fdd5
PE
6864 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6865 when creating daemon; the previous buffer-overflow check was incorrect.
6866
d749b01b
PE
6867 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6868 which has the guts of the old verror function.
6869
b5cd1905
PE
6870 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6871 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6872
6e1a67fb
PE
6873 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6874 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6875 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6876 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6877 length of string rather than counting it via multiple sprintfs;
6878 that's simpler and more reliable.
c21721cc
PE
6879 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6880 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6881 sprintf, in case result does not fit in int.
6882
c57b67fc
PE
6883 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6884 (fontset_from_font): Print it.
6885
8a401434
PE
6886 * frame.c (tty_frame_count): Now printmax_t, not int.
6887 (make_terminal_frame, set_term_frame_name): Print it.
6888 (x_report_frame_params): In X, window IDs are unsigned long,
6889 not signed long, so print them as unsigned.
6890 (validate_x_resource_name): Check for implausibly long names,
6891 and don't assume name length fits in 'int'.
6892 (x_get_resource_string): Don't blindly alloca invocation name;
6893 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6894 not fit in int.
6895
6e1a67fb
PE
6896 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6897 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6898 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6899
0df02bf3
PE
6900 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6901 Use esprintf, not sprintf, in case result does not fit in int.
6902
48e30793
PE
6903 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6904 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6905 it as a large positive number.
6906 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6907 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6908
a66ff6d8
PE
6909 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6910 in case result does not fit in int.
6911
aca216ff
PE
6912 * print.c (float_to_string): Detect width overflow more reliably.
6913 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6914 buffer overrun. Don't assume list length fits in 'int'. Treat
6915 print length of 0 as 0, not as infinity; to be consistent with other
6916 uses of print length in this function. Don't overflow print length
6917 index. Don't assume hash table size fits in 'long', or that
6918 vectorlike size fits in 'unsigned long'.
6919
31c286f7
PE
6920 * process.c (make_process): Use printmax_t, not int, to format
6921 process-name gensyms.
6922
55e5faa1
PE
6923 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6924
80f2e268
PE
6925 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6926 to avoid potential buffer overrun.
6927
670741ab
PE
6928 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6929 if X resource line is longer than 512 bytes.
6930
b7163a50
PE
6931 * xfns.c (x_window): Make sprintf buffer a bit bigger
6932 to avoid potential buffer overrun.
6933
ae58ff1f
PE
6934 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6935
c43c8a6a
PE
6936 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6937
3f8236f4
PE
69382011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6939
53e9fe90 6940 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6941 Without these, Emacs silently mishandles large integers sometimes.
6942 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6943 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6944
6511acf2
PE
6945 * xdisp.c (try_window_id): Check Emacs fixnum range before
6946 converting to 'int'.
806add1d 6947
6511acf2 6948 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6949 Check that an Emacs fixnum is in range before assigning it to 'int'.
6950 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6951 values converted from Emacs fixnums.
6952 (Frecenter): Don't wrap around a line count if it is out of 'int'
6953 range; instead, treat it as an extreme value.
6954 (Fset_window_configuration, compare_window_configurations):
6955 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6956
6511acf2
PE
6957 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6958 that can exceed INT_MAX. Check that EMACS_INT value is in range
6959 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6960 (match_limit): Don't assume that a fixnum can fit in 'int'.
6961
6511acf2 6962 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6963 exceed INT_MAX.
6964
6511acf2 6965 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6966 (Fvertical_motion): Don't wrap around LINES values that don't fit
6967 in 'int'. Instead, treat them as extreme values. This is good
6968 enough for windows, which can't have more than INT_MAX lines anyway.
6969
fcb901a7
LMI
69702011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6971
0f2f6b6d
LMI
6972 * Require libxml/parser.h to avoid compilation warning.
6973
fcb901a7
LMI
6974 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6975
6976 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6977 since this reportedly can destroy thread storage.
6978
6e20a0d4
CY
69792011-08-30 Chong Yidong <cyd@stupidchicken.com>
6980
6981 * syntax.c (find_defun_start): Update all cache variables if
6982 exiting early (Bug#9401).
6983
148ae00e
EZ
69842011-08-30 Eli Zaretskii <eliz@gnu.org>
6985
f6cfbd8f
EZ
6986 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6987
148ae00e
EZ
6988 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6989 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6990 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6991
6992 * term.c (tty_append_glyph): New function.
6993 (produce_stretch_glyph): Static function and its prototype deleted.
6994
a66cfb1c
SM
6995 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6996 Add prototypes.
148ae00e 6997
c4a07a4c
PE
69982011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6999
7000 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7001 when checking :margin (Bug#9390).
7002 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7003 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7004 so that the name doesn't mislead. All uses changed.
7005
6bc8cd65
JB
70062011-08-28 Johan Bockgård <bojohan@gnu.org>
7007
7008 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7009 set_tty_hooks.
7010
dca4927e
EZ
70112011-08-27 Eli Zaretskii <eliz@gnu.org>
7012
7013 * xdisp.c (move_it_to): Don't bail out early when reaching
7014 position beyond to_charpos, if we are scanning backwards.
7015 (move_it_vertically_backward): When DY == 0, make sure we get to
7016 the first character in the line after the newline.
7017
f2cad773
PE
70182011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7019
7020 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7021 (ccl_driver): Do not generate an out-of-range pointer.
7022 (Fccl_execute_on_string): Remove unnecessary check for
7023 integer overflow, noted by Stefan Monnier in
7024 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7025 Remove a FIXME that didn't need fixing.
7026 Simplify the newly-introduced buffer reallocation code.
7027
0cae2cdb
JB
70282011-08-27 Juanma Barranquero <lekktu@gmail.com>
7029
7030 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7031
5fc295a4 70322011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7033
70c60eb2 7034 Integer and memory overflow issues (Bug#9196).
726e0ab1 7035
d31850da
PE
7036 * doc.c (get_doc_string): Rework so that
7037 get_doc_string_buffer_size is the actual buffer size, rather than
7038 being 1 less than the actual buffer size; this makes xpalloc more
7039 convenient.
7040
a69fbedb
PE
7041 * image.c (x_allocate_bitmap_record, cache_image):
7042 * xselect.c (Fx_register_dnd_atom):
7043 Simplify previous changes by using xpalloc.
7044
fe5c5d37
PE
7045 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7046 since either will do and ptrdiff_t is convenient with xpalloc.
7047
0065d054
PE
7048 * charset.c (charset_table_size)
7049 (struct charset_sort_data.priority): Now ptrdiff_t.
7050 (charset_compare): Don't overflow if priorities differ greatly.
7051 (Fsort_charsets): Don't assume list length fits in int.
7052 Check for size-calculation overflow when allocating sort data.
7053 (syms_of_charset): Allocate an initial charset table that is
7054 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7055
7056 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7057
7058 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7059 The actual value is always <= INT_MAX, and leaving it unsigned made
7060 overflow checking harder.
7061
7062 * dispextern.h (struct glyph_matrix.rows_allocated)
7063 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7064 with xpalloc. The values are still always <= INT_MAX.
7065
7066 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7067
7068 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7069 (SAFE_NALLOCA): New macro.
7070
7071 * region-cache.c (struct boundary.pos, find_cache_boundary)
7072 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7073 (set_cache_region, invalidate_region_cache)
7074 (revalidate_region_cache, know_region_cache, region_cache_forward)
7075 (region_cache_backward, pp_cache):
7076 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7077 so that ptrdiff_t * can be passed to xpalloc.
7078 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7079 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7080 (pp_cache): Don't assume cache_len fits in int.
7081 * region-cache.h: Adjust extern decls to match.
7082
7083 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7084 EMACS_INT, since either will do, for xpalloc.
7085
7086 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7087 (xnmalloc, xnrealloc, xpalloc): New functions.
7088
726e0ab1
PE
7089 * bidi.c (bidi_shelve_header_size): New constant.
7090 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7091 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7092
51f30bc5 7093 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7094 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7095 (overlay_strings):
7096 Don't update size of array until after memory allocation succeeds,
7097 because xmalloc/xrealloc may not return.
0065d054
PE
7098 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7099 now that we have proper integer overflow checking.
7100 (record_overlay_string, overlay_strings): Catch overflows when
7101 calculating size of overlay_str_buf.
726e0ab1 7102
0065d054
PE
7103 * callproc.c (Fcall_process): Check for size overflow when
7104 calculating size of args2.
7105 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7106 Normally we prefer signed values, but sticking with ptrdiff_t would
7107 require adding more-complicated checks.
726e0ab1
PE
7108
7109 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7110 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7111 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7112 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7113
7114 * character.c (Fstring): Check for size-calculation overflow.
7115
7116 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7117 unnecessary integer overflow. Check for size overflow.
7118 (encode_coding_object): Don't update size until xmalloc succeeds.
7119
7120 * composite.c (get_composition_id): Check for overflow in glyph
7121 length calculations.
7122
7123 Integer and memory overflow fixes for display code.
7124 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7125 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7126 (scrolling_window): Check for overflow in size calculations.
7127 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7128 Don't assume glyph table len fits in int.
7129 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7130 (row_table_size): Now ptrdiff_t, not int.
7131 (scrolling_window): Avoid overflow in size calculations.
7132 Don't update size until allocation succeeds.
7133 * fns.c (concat): Check for overflow in size calculations.
7134 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7135 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7136 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7137
7138 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7139 (get_doc_string): Check for size calculation overflow.
7140 Don't update size until allocation succeeds.
7141 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7142 EMACS_INT, where ptrdiff_t will do.
7143 (Fsubstitute_command_keys): Check for string overflow.
7144
7145 * editfns.c (set_time_zone_rule): Don't assume environment length
7146 fits in int.
7147 (message_length): Now ptrdiff_t, not int.
7148 (Fmessage_box): Don't update size until allocation succeeds.
7149 Don't assume message length fits in int.
7150 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7151
0065d054
PE
7152 * emacs.c (main): Do not reallocate argv, since there is a null at
7153 the end that can be overwritten, and this way there's no need to
7154 worry about size-calculation overflow.
7155 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7156
7157 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7158 alloc succeeds.
7159 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7160
7161 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7162 (x_set_scroll_bar_width, x_figure_window_size):
7163 Check for integer overflow.
7164 (x_set_alpha): Do not assume XINT fits in int.
7165
7166 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7167 This is for the members text_lines, text_cols, total_lines, total_cols,
7168 where the system imposes an 'int' limit.
7169
7170 * fringe.c (Fdefine_fringe_bitmap):
7171 Don't update size until alloc works.
7172
7173 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7174 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7175
7176 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7177 Check for size-calculation overflow.
7178 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7179 do, as we prefer signed integers.
7180 (id_to_widget.max_size, id_to_widget.used)
7181 (xg_store_widget_in_map, xg_remove_widget_from_map)
7182 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7183 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7184 Use and return ptrdiff_t, not int.
7185 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7186 * gtkutil.h: Change prototypes to match the above.
7187
7188 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7189 are duplicate now that they've been promoted to lisp.h.
7190 (x_allocate_bitmap_record, x_alloc_image_color)
7191 (make_image_cache, cache_image, xpm_load):
7192 Don't update size until alloc is done.
7193 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7194 (x_detect_edges):
3256efce 7195 Check for size calculation overflow.
726e0ab1
PE
7196 (ct_colors_allocated_max): New constant.
7197 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7198 overflow.
3256efce 7199
726e0ab1
PE
7200 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7201 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7202 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7203 Use ptrdiff_t, not int, to count maps.
7204 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7205 calculations. Don't update size until allocation succeeds.
7206 Redo calculations to avoid overflow.
726e0ab1
PE
7207 * keyboard.h: Change prototypes to match the above.
7208
7209 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7210 to count maps.
7211 (current_minor_maps): Check for size calculation overflow.
7212 * keymap.h: Change prototypes to match the above.
7213
7214 * lread.c (read1, init_obarray): Don't update size until alloc done.
7215
7216 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7217 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7218
726e0ab1
PE
7219 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7220 Now ptrdiff_t, not int.
7221 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7222 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7223
7224 * process.c (Fnetwork_interface_list): Check for overflow
7225 in size calculation.
7226
7227 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7228
7229 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7230 overflow. Don't bother calling xmalloc when xrealloc will do.
7231
7232 * search.c (Freplace_match): Check for size calculation overflow.
7233 (Fset_match_data): Don't assume list lengths fit in 'int'.
7234
7235 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7236 for command line length. Do not attempt to address one before the
7237 beginning of an array, as that's not portable.
7238
7239 * term.c (max_frame_lines): Remove; unused.
7240 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7241 not int.
7242 (encode_terminal_code, calculate_costs): Check for size
7243 calculation overflow.
7244 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7245 table lengths and related sizes. Don't update size until alloc
7246 done. Redo calculations to avoid overflow.
7247 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7248
7249 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7250 subtracting pointers.
7251 (gobble_line): Check for overflow more carefully. Don't update size
7252 until alloc done.
7253
7254 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7255 Don't update size until alloc done.
7256 Redo size calculations to avoid overflow.
7257 Check for size calculation overflow.
0065d054 7258 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7259
7260 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7261 Use ptrdiff_t, not int, for sizes.
7262 (store_mode_line_noprop_char): Don't update size until alloc done.
7263
0065d054
PE
7264 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7265 Use ptrdiff_t, not int, for sizes.
7266 (Finternal_make_lisp_face, cache_face):
7267 Check for size calculation overflow.
7268 (cache_face): Treat size calculation overflows as if they were
7269 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7270
7271 * xfns.c (x_encode_text, x_set_name_internal)
7272 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7273 sizes, since they can exceed INT_MAX in size. Check for size
7274 calculation overflow.
7275
0065d054
PE
7276 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7277 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7278 Don't update size until alloc done.
7279
0065d054 7280 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7281 as sprintf is limited to int lengths.
1d526e2f 7282
252c5ee1
PE
7283 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7284 (X_LONG_MIN): New macros.
864d7ce7
PE
7285 Use them to make the following changes clearer.
7286 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7287 This change doesn't affect the value now, but it may help remind
7288 future maintainers not to raise the value too much later.
7289 (SELECTION_QUANTUM): Remove, replacing with ...
7290 (selection_quantum): ... new function, which avoids overflow.
7291 All uses changed.
7292 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7293 assumption that selection length fits in 'int'.
7294 (x_reply_selection_request, x_handle_selection_request)
7295 (x_get_window_property, receive_incremental_selection)
7296 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7297 (lisp_data_to_selection_data, clean_local_selection_data):
7298 Use ptrdiff_t, not int, to record length of selection.
7299 (x_reply_selection_request, x_get_window_property)
7300 (receive_incremental_selection, x_property_data_to_lisp):
7301 Redo calculations to avoid overflow.
7302 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7303 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7304 something.
7305 (x_get_window_property, receive_incremental_selection)
7306 (lisp_data_to_selection_data, x_property_data_to_lisp):
7307 Check for size-calculation overflow.
7308 (x_get_window_property, receive_incremental_selection)
7309 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7310 Don't store size until memory allocation succeeds.
7311 (x_get_window_property): Plug memory leak on memory exhaustion.
7312 Don't double-block input; malloc is safe here. Don't assume 2**34
7313 - 4 fits in unsigned long. Add an xassert to check
7314 XGetWindowProperty overflow. Be more careful about overflow
7315 calculations, and distinguish size from memory overflow better.
7316 (receive_incremental_selection): When tracing, don't assume
7317 unsigned int is less than INT_MAX.
7318 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7319 harmful) conversions of unsigned short to int.
7320 (lisp_data_to_selection_data): Don't assume that integers
7321 in the range -65535 through -1 fit in an X unsigned short.
7322 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7323 result parameters unless successful. Rely on cons_to_unsigned
7324 to report problems with elements; the old code wasn't right anyway.
7325 (x_check_property_data): Check for int overflow; we cannot use
7326 a wider type due to X limits.
7327 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7328
726e0ab1 7329 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7330
0065d054
PE
7331 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7332 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7333 (x_color_cells): Don't store size until memory allocation succeeds.
7334 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7335 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7336 (x_term_init): Don't assume length fits in int (sprintf is limited
7337 to int size).
bc18e09d 7338
ebfa62c0
PE
7339 Use ptrdiff_t for composition IDs.
7340 * character.c (lisp_string_width):
7341 * composite.c (composition_table_size, n_compositions)
7342 (get_composition_id, composition_gstring_from_id):
7343 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7344 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7345 * window.c (Frecenter):
7346 Use ptrdiff_t, not int, for composition IDs.
7347 * composite.c (get_composition_id): Check for integer overflow.
7348 * composite.h: Adjust prototypes to match the above changes.
7349
d3411f89
PE
7350 Use ptrdiff_t for hash table indexes.
7351 * category.c (hash_get_category_set):
7352 * ccl.c (ccl_driver):
7353 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7354 * coding.c (coding_system_charset_list, detect_coding_system):
7355 * coding.h (struct coding_system.id):
7356 * composite.c (get_composition_id, gstring_lookup_cache):
7357 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7358 * image.c (xpm_get_color_table_h):
7359 * lisp.h (hash_lookup, hash_put):
7360 * minibuf.c (Ftest_completion):
7361 Use ptrdiff_t for hash table indexes, not int (which is too
7362 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7363 32-bit --with-wide-int hosts).
7364
e097a6fa
PE
7365 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7366 Add a FIXME comment about memory leaks.
7367 (syms_of_charset): Don't assume xmalloc returns.
7368
5637687f
PE
7369 Don't assume that stated character widths fit in int.
7370 * character.c (Fchar_width, c_string_width, lisp_string_width):
7371 * character.h (CHAR_WIDTH):
7372 * indent.c (MULTIBYTE_BYTES_WIDTH):
7373 Use sanitize_char_width to avoid undefined and/or bad behavior
7374 with outlandish widths.
a66cfb1c 7375 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7376 now that we have two such functions. All uses changed.
7377 (sanitize_char_width): New inline function.
7378
a2271ba2
PE
7379 Don't assume that tab-width fits in int.
7380 * character.h (sanitize_width): New inline function.
7381 (SANE_TAB_WIDTH): New macro.
7382 (ASCII_CHAR_WIDTH): Use it.
7383 * indent.c (sane_tab_width): Remove. All uses replaced by
7384 SANE_TAB_WIDTH (current_buffer).
7385 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7386
18c52557
PE
7387 * fileio.c: Integer overflow issues with file modes.
7388 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7389
caeeedc1
PE
7390 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7391 Remove unreachable code.
7392 (read_hex, load_charset_map_from_file): Check for integer overflow.
7393
6df6ae42 7394 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7395 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7396 (x_send_scroll_bar_event): Likewise. Check that the size does not
7397 exceed limits imposed by XClientMessageEvent, as well as the usual
7398 ptrdiff_t and size_t limits.
7399
b13995db
PE
7400 * keyboard.c: Overflow, signedness and related fixes.
7401 (make_lispy_movement): Use same integer type in forward decl
7402 that is used in the definition.
7403 (read_key_sequence, keyremap_step):
7404 Change bufsize argument back to int, undoing my 2011-03-30 change.
7405 We prefer signed types, and int is wide enough here.
7406 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7407 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7408 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7409 length, not size_t. Use ptrdiff_t for index, not int.
7410 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7411 possibility of integer overflow.
7412
13464394
PE
7413 Overflow, signedness and related fixes for images.
7414
7415 * dispextern.h (struct it.stack[0].u.image.image_id)
7416 (struct_it.image_id, struct image.id, struct image_cache.size)
7417 (struct image_cache.used, struct image_cache.ref_count):
7418 * gtkutil.c (update_frame_tool_bar):
7419 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7420 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7421 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7422 * nsmenu.m (update_frame_tool_bar):
7423 * xdisp.c (calc_pixel_width_or_height):
7424 * xfns.c (image_cache_refcount):
7425 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7426 on typical 64-bit hosts.
7427
7428 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7429 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7430 Omit unnecessary casts to int.
7431 (parse_image_spec): Check that integers fall into 'int' range
7432 when the callers expect that.
7433 (image_ascent): Redo ascent calculation to avoid int overflow.
7434 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7435 (lookup_image): Remove unnecessary tests.
7436 (xbm_image_p): Locals are now of int, not EMACS_INT,
7437 since parse_image_check makes sure they fit into int.
7438 (png_load, gif_load, svg_load_image):
7439 Prefer int to unsigned where either will do.
7440 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7441 old tiff_error_handler and tiff_warning_handler.
7442 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7443 stack buffer overflows. It uses only the features of vsnprintf
7444 that are common to both POSIX and native Microsoft.
7445 (tiff_error_handler, tiff_warning_handler): Use it.
7446 (tiff_load, gif_load, imagemagick_load_image):
7447 Don't assume :index value fits in 'int'.
7448 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7449 (imagemagick_load_image): Check that crop parameters fit into
7450 the integer types that MagickCropImage accepts. Don't assume
7451 Vimagemagick_render_type has a nonnegative value. Don't assume
7452 size_t fits in 'long'.
7453 (gs_load): Use printmax_t to print the widest integers possible.
7454 Check for integer overflow when computing image height and width.
7455
c11821d4
EZ
74562011-08-26 Eli Zaretskii <eliz@gnu.org>
7457
7458 * xdisp.c (redisplay_window): Don't force window start if point
7459 will be invisible in the resulting window. (Bug#9324)
7460
0c95fcf7
EZ
74612011-08-25 Eli Zaretskii <eliz@gnu.org>
7462
7463 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7464 the display spec is of the form `(space ...)'.
7465 (handle_display_spec): Return the value returned by
7466 handle_single_display_spec, not just 1 or zero.
7467 (handle_single_display_spec): If the display spec is of the form
7468 `(space ...)', and specifies display in the text area, return 2
7469 rather than 1.
fee65a97 7470 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7471 accurately, and prefer exact match for point under bidi.
7472 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7473
7474 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7475 into disp_prop; all users changed.
7476
7477 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7478 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7479 for the text covered by the display property.
7480
e4ed06f1
CY
74812011-08-25 Chong Yidong <cyd@stupidchicken.com>
7482
7483 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7484 Change return value to nil.
7485 (Frecord_buffer): Delete unused function.
7486
f67cdd7f
EZ
74872011-08-24 Eli Zaretskii <eliz@gnu.org>
7488
5980d4c6
EZ
7489 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7490 buffers, return left-to-right.
8610fe8b
EZ
7491 (set_cursor_from_row): Consider candidate row a win if its glyph
7492 represents a newline and point is on that newline. Fixes cursor
7493 positioning on the newline at EOL of R2L text within L2R
7494 paragraph, and vice versa.
7495 (try_cursor_movement): Check continued rows, in addition to
7496 continuation rows. Fixes unwarranted scroll when point enters a
7497 continued line of R2L text within an L2R paragraph, or vice versa.
7498 (cursor_row_p): Consider the case of point being equal to
7499 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7500 from the end of a short line to the beginning of a continued line
7501 of R2L text within L2R paragraph.
7502 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7503 composed characters.
5980d4c6 7504
f67cdd7f
EZ
7505 * bidi.c (bidi_check_type): Use xassert.
7506 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7507 members.
7508
bca633fb
EZ
75092011-08-23 Eli Zaretskii <eliz@gnu.org>
7510
7511 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7512 a character.
7513
4a5885a7
CY
75142011-08-23 Chong Yidong <cyd@stupidchicken.com>
7515
7516 * nsfont.m (ns_otf_to_script): Fix typo.
7517
0902a04e
KH
75182011-08-22 Kenichi Handa <handa@m17n.org>
7519
7520 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7521 extra slot even if the purpose is char-code-property-table.
7522
1a2e6670
EZ
75232011-08-23 Eli Zaretskii <eliz@gnu.org>
7524
8ddde651
EZ
7525 * xdisp.c (redisplay_window): When computing centering_position,
7526 account for the height of the header line. (Bug#8874)
7527
425cc014
EZ
7528 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7529 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7530 candidate is selected by the mouse, and that candidate has a
7531 composed character under the mouse.
7532
1a2e6670
EZ
7533 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7534 coordinates reported by pos-visible-in-window-p for a composed
7535 character in column zero.
7536
8b76d6f8
SM
75372011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7538
7539 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7540
dac347dd
EZ
75412011-08-22 Eli Zaretskii <eliz@gnu.org>
7542
7543 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7544 consider it a hit if to_charpos is anywhere in the range of the
7545 composed buffer positions.
7546
e013fb34
CY
75472011-08-22 Chong Yidong <cyd@stupidchicken.com>
7548
7549 * image.c (gif_load): Don't assume that each subimage has the same
7550 dimensions as the base image. Handle disposal method that is
7551 "undefined" by the gif spec (Bug#9335).
7552
bd1ba3e8
CY
75532011-08-20 Chong Yidong <cyd@stupidchicken.com>
7554
7555 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7556 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7557
54a1215b
EZ
75582011-08-19 Eli Zaretskii <eliz@gnu.org>
7559
823564e5
EZ
7560 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7561 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7562 from an Org mode buffer to a Speedbar frame.
7563
54a1215b
EZ
7564 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7565 a composition, take its buffer position from IT->cmp_it.charpos.
7566 Fixes cursor positioning at the beginning of a line that begins
7567 with a composed character.
7568
9778ebcc
EZ
75692011-08-18 Eli Zaretskii <eliz@gnu.org>
7570
0be6ee06
EZ
7571 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7572 character bidirectional type, use STRONG_L instead. Fixes crashes
7573 in a buffer produced by `describe-categories'.
7574
9778ebcc
EZ
7575 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7576 members before the level stack, so they would be saved and
7577 restored when copying iterator state. Fixes incorrect reordering
7578 around TABs covered by display properties.
7579
156bffbe
AS
75802011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7581
6b02f655 7582 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7583
72ad093b
CY
75842011-08-17 Chong Yidong <cyd@stupidchicken.com>
7585
7586 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7587 (internal_condition_case_2, internal_condition_case_n):
7588 Remove unnecessary aborts (Bug#9081).
72ad093b 7589
35774242
EZ
75902011-08-17 Eli Zaretskii <eliz@gnu.org>
7591
7592 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7593 has no `load' handler, try opening the file locally. (Bug#9311)
7594
db76dd85
KB
75952011-08-16 Ken Brown <kbrown@cornell.edu>
7596
7597 * gmalloc.c: Expand comment.
7598
b215eee5
EZ
75992011-08-16 Eli Zaretskii <eliz@gnu.org>
7600
7601 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7602 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7603
a4579d33
KB
76042011-08-16 Ken Brown <kbrown@cornell.edu>
7605
7606 Fix memory allocation problems in Cygwin build (Bug#9273).
7607
7608 * unexcw.c ( __malloc_initialized): Declare external variable.
7609 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7610
8b76d6f8
SM
7611 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7612 New variables.
a4579d33
KB
7613 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7614 dumped emacs.
7615 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7616 in the static heap.
7617 [CYGWIN] (special_realloc): New function.
7618 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7619 requests to realloc storage in the static heap.
7620
3ebec551
PE
76212011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7622
7623 * bidi.c (bidi_initialize): Remove unused local.
7624
9fd8be00
EZ
76252011-08-15 Eli Zaretskii <eliz@gnu.org>
7626
6b02f655
SM
7627 * bidimirror.h:
7628 * biditype.h: Remove file.
7629 * makefile.w32-in ($(BLD)/bidi.$(O)):
7630 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7631
7632 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7633
7634 * chartab.c: Improve commentary for the uniprop_table API.
7635
32413314
EZ
7636 * bidi.c (bidi_paragraph_init): Support zero value of
7637 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7638 (bidi_initialize): Use uniprop_table instead of including
7639 biditype.h and bidimirror.h.
32413314 7640
9fd8be00
EZ
7641 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7642 coordinates of the iterator when restoring from ppos_it.
7643 (Bug#9296)
7644
5cf2b69b
KH
76452011-08-14 Kenichi Handa <handa@m17n.org>
7646
7647 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7648 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7649
daf17d00
EZ
76502011-08-14 Eli Zaretskii <eliz@gnu.org>
7651
7652 * xdisp.c (move_it_in_display_line_to): Don't invoke
7653 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7654 ppos_it. Fixes vertical cursor motion when line beginning is
7655 covered by an image. (Bug#9296)
7656
08e3161a
JD
76572011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7658
7659 * nsterm.h (ns_run_ascript): Declare.
7660 (NSAPP_DATA2_RUNASSCRIPT): Define.
7661
7662 * nsfns.m (as_script, as_result, as_status): New static variables.
7663 (ns_run_ascript): New function.
5e617bc2 7664 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7665 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7666 the event loop. Get status from as_status (Bug#7276).
7667
7668 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7669 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7670 the event loop (Bug#7276).
7671
a3720aa2
AS
76722011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7673
7674 * gnutls.c (QCgnutls_bootprop_priority)
7675 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7676 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7677 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7678 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7679 (QCgnutls_bootprop_verify_hostname_error)
7680 (QCgnutls_bootprop_callbacks_verify): Rename from
7681 Qgnutls_bootprop_..., all uses changed.
7682
7683 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7684 uses changed.
7685
0a0d27fb
PE
76862011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7687
19d5c50c
PE
7688 * xfaces.c (Qframe_set_background_mode): Now static.
7689 * dispextern.h (Qframe_set_background_mode): Remove decl.
7690
0a0d27fb
PE
7691 * process.c (Fnetwork_interface_info): Declare local only if needed.
7692
377538cb
JD
76932011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7694
7695 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7696 (Fnetwork_interface_list): Allocate in increments of bytes instead
7697 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7698 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7699 sockaddr.
7700 (struct ifflag_def): notrailers is smart on OSX.
7701 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7702 Get hardware address with getifaddrs if available.
7703
08fff70c
EZ
77042011-08-12 Eli Zaretskii <eliz@gnu.org>
7705
7706 * xdisp.c (iterate_out_of_display_property): xassert that
7707 IT->position is set to within IT->object's boundaries. Break from
7708 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7709 when IT->position is set up wrongly due to some bug.
7710 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7711 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7712 entry. Force push_it to save on the stack the current
7713 buffer/string position, to be restored by pop_it. Fix flags in
7714 the iterator structure wrt the object coming from a display
7715 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7716 properties. (Bug#9284)
7717
7be1c708 77182011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7719
7be1c708
CY
7720 * fontset.c (fontset_get_font_group): Add proper type checks.
7721 (Bug#9172)
aac0c6e3 7722
7be1c708 77232011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7724
7be1c708
CY
7725 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7726 and LC_VERSION_MIN_MACOSX.
7727 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7728 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7729
97bb72a6
EZ
77302011-08-08 Eli Zaretskii <eliz@gnu.org>
7731
7732 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7733 no-display-properties-and-no-overlays under bidi display.
7734 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7735 properties and overlays.
97bb72a6 7736
d5617611
CY
77372011-08-08 Chong Yidong <cyd@stupidchicken.com>
7738
37e11a63
CY
7739 * editfns.c (Fset_time_zone_rule): Document relationship with the
7740 setenv function.
7741
d5617611
CY
7742 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7743 the font entity extracted from the cache (Bug#8109).
7744
58872834
CY
77452011-08-07 Chong Yidong <cyd@stupidchicken.com>
7746
7747 * composite.c (autocmp_chars): Don't reset point. That is done by
7748 restore_point_unwind (Bug#5984).
7749
75bfc667
JL
77502011-08-07 Juri Linkov <juri@jurta.org>
7751
7752 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7753 to show the arg `TIME' instead of `TIMEVAL'.
7754
d1410150
EZ
77552011-08-06 Eli Zaretskii <eliz@gnu.org>
7756
7757 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7758 display property strides EOL and includes a newline, as in
7759 longlines-mode. (Bug#9254)
75b771e4
EZ
7760 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7761 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7762
7763 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7764 is non-zero, even if the data buffer is NULL. Fixes a crash in
7765 vertical-motion with longlines-mode. (Bug#9254)
7766
35928349
EZ
77672011-08-05 Eli Zaretskii <eliz@gnu.org>
7768
ec7cc85b
EZ
7769 * bidi.c <bidi_cache_total_alloc>: Now static.
7770 (bidi_initialize): Initialize bidi_cache_total_alloc.
7771
8b76d6f8 7772 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7773 cache. (Bug#9221)
7774
7775 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7776 amount allocated this far in `bidi_cache_total_alloc'.
7777 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7778 non-zero, only free the data buffer without restoring the cache
7779 contents. All callers changed.
7780
7781 * dispextern.h (bidi_unshelve_cache): Update prototype.
7782
7783 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7784 (move_it_in_display_line, move_it_to)
7785 (move_it_vertically_backward, move_it_by_lines): Replace the call
7786 to xfree to an equivalent call to bidi_unshelve_cache.
7787 (move_it_in_display_line_to): Fix logic of returning
412b6358 7788 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7789
e2e2423b
EZ
77902011-08-05 Eli Zaretskii <eliz@gnu.org>
7791
7792 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7793 came from a string character with a `cursor' property. (Bug#9229)
7794
ae9e757a
JD
77952011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7796
7797 * Makefile.in (LIB_PTHREAD): New variable.
7798 (LIBES): Add LIB_PTHREAD (Bug#9216).
7799
7800 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7801 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7802
213bd7f2
AS
78032011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7804
6b02f655 7805 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7806
99aaf75f
JD
78072011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7808
7809 * xterm.c (x_find_topmost_parent): New function.
7810 (x_set_frame_alpha): Find topmost parent window with
7811 x_find_topmost_parent and set the property there also (bug#9181).
7812 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7813
c74e9d86
PE
78142011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7815
7816 * callproc.c (Fcall_process): Avoid vfork clobbering
7817 the local vars buffer, coding_systems, current_dir.
7818
640c8776
SM
78192011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7820
7821 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7822
f26d0e4c
PE
78232011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7824
8a10d76c
PE
7825 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7826 so that it is not optimized away.
7827
f26d0e4c
PE
7828 * xdisp.c (compute_display_string_pos): Remove unused local.
7829
55439c61
EZ
78302011-08-02 Eli Zaretskii <eliz@gnu.org>
7831
7832 Fix slow cursor motion and scrolling in large buffers with
7833 selective display, like Org Mode buffers. (Bug#9218)
7834
7835 * dispextern.h (struct bidi_it): New member disp_prop_p.
7836
7837 * xdisp.c: Remove one-slot cache of display string positions.
7838 (compute_display_string_pos): Accept an additional argument
5e617bc2 7839 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7840 for a display string or property. If found, set DISP_PROP_P
7841 non-zero.
7842
7843 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7844 DISP_PROP_P, and pass it to compute_display_string_pos.
7845 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7846 non-zero. All callers of bidi_fetch_char changed.
7847
fb33fa43
SM
78482011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7849
7850 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7851
b099e063
DM
78522010-12-03 Don March <don@ohspite.net>
7853
7854 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7855 last character M-[char] is translated to ESC [char] (bug#7541).
7856
5cc7f7af
KH
78572011-08-02 Kenichi Handa <handa@m17n.org>
7858
d0fffa3f 7859 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7860
7861 * chartab.c (uniprop_table): Make it non-static.
7862
525d5e6e
EZ
78632011-08-01 Eli Zaretskii <eliz@gnu.org>
7864
7865 * xdisp.c (forward_to_next_line_start): Accept additional argument
7866 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7867 on the newline.
7868 (reseat_at_next_visible_line_start): Use the bidi iterator state
7869 returned by forward_to_next_line_start to restore the state of
7870 it->bidi_it after backing up to previous newline. (Bug#9212)
7871
31011111
AS
78722011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7873
7874 * regex.c (re_comp): Protoize.
7875 (re_exec): Fix return type.
7876 (regexec): Fix type of `ret'. (Bug#9203)
7877
476371c4
PE
78782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7879
e5d76069
PE
7880 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7881 This is needed if max-image-size is a floating-point number.
7882
9a79b20c
AS
78832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7884
7885 * print.c (print_object): Print empty symbol as ##.
7886
7887 * lread.c (read1): Read ## as empty symbol.
7888
d8c2fa78
AA
78892011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7890
7891 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7892 setting frame foreground color (Bug#9175).
7893 (x_set_background_color): Likewise.
7894
ffe57a7a
AA
7895 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7896 contents (Bug#9176).
7897 (EmacsTooltip -init): Remove bezels and add shadows to
7898 tooltip windows.
7899
bf3492a5
AA
7900 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7901 or scroll bar (Bug#8470).
7902
d55e9c53
AA
7903 * nsfont.m (nsfont_open): Remove assignment to voffset and
7904 unnecessary vars hshink, expand, hd, full_height, min_height.
7905 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7906
7907 * nsterm.h (nsfont_info): Remove voffset field.
7908
d8c2fa78 79092011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7910
7911 Implement strike-through and overline on NextStep (Bug#8863).
7912
7913 * nsfont.m (nsfont_open): Use underline position provided by font,
7914 instead of hard-coded value of 2.
7915 (nsfont_draw): Call ns_draw_text_decoration instead.
7916
7917 * nsterm.h: Add declaration for ns_draw_text_decoration.
7918
7919 * nsterm.m (ns_draw_text_decoration): New function for drawing
7920 underline, overline, and strike-through.
7921 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7922 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7923 accommodate underlining, etc.
4843aac3 7924
4cc60b9b
EZ
79252011-07-28 Eli Zaretskii <eliz@gnu.org>
7926
bc7ece87
EZ
7927 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7928 default.
4cc60b9b 7929
476371c4
PE
79302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7931
66606eea
PE
7932 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7933 Without this fix, if a signal arrives just after memory fills up,
7934 'malloc' might be invoked reentrantly.
7935
476371c4
PE
7936 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7937 In other words, assume that every image size is allowed, on non-X
7938 hosts. This assumption is probably wrong, but it lets Emacs compile.
7939
f3fcc40d
AS
79402011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7941
7942 * regex.c (re_iswctype): Convert return values to boolean.
7943
350c992f
EZ
79442011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7945
7946 * xdisp.c (compute_display_string_pos): Don't use cached display
7947 string position if the buffer had its restriction changed.
7948 (Bug#9184)
7949
5266b4bb
PE
79502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7951
7952 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7953
2573a837 79542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7955
41f55ccd 7956 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7957
39e378da
PE
7958 * bidi.c: Integer size and overflow fixes.
7959 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7960 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7961 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7962 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7963 (bidi_find_other_level_edge):
7964 Use ptrdiff_t instead of EMACS_INT where either will do.
7965 This works better on 32-bit hosts configured --with-wide-int.
7966 (bidi_cache_ensure_space): Check for size-calculation overflow.
7967 Use % rather than repeated addition, for better worst-case speed.
7968 Don't set bidi_cache_size until after xrealloc returns, because it
7969 might not return.
7970 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7971 (bidi_cache_ensure_space): Also check that the bidi cache size
7972 does not exceed that of the largest Lisp string or buffer. See Eli
7973 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7974
5e927815
PE
7975 * alloc.c (__malloc_size_t): Remove.
7976 All uses replaced by size_t. See Andreas Schwab's note
7977 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7978
ca4aa935
PE
7979 * image.c: Improve checking for integer overflow.
7980 (check_image_size): Assume that f is nonnull, since
7981 it is always nonnull in practice. This is one less thing to
7982 worry about when checking for integer overflow later.
7983 (x_check_image_size): New function, which checks for integer
7984 overflow issues inside X.
7985 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7986 This removes the need for a memory_full check.
7987 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7988 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7989 (xbm_read_bitmap_data): Change locals back to 'int', since
7990 their values must fit in 'int'.
7991 (xpm_load_image, png_load, tiff_load):
7992 Invoke x_create_x_image_and_pixmap earlier,
7993 to avoid much needless work if the image is too large.
7994 (tiff_load): Treat overly large images as if
7995 x_create_x_image_and_pixmap failed, not as malloc failures.
7996 (gs_load): Use x_check_image_size.
7997
5f8f9cc2
PE
7998 * gtkutil.c: Omit integer casts.
7999 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8000 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8001
5adf60bc
PE
8002 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8003
c8907a93
PE
8004 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8005 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8006 would wrongly return t on a 64-bit host.
8007
e3c25c68
PE
8008 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8009 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8010 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8011 and therefore cause GCC to emit a bogus diagnostic in some cases.
8012
3f791afe
PE
8013 * image.c: Integer signedness and overflow and related fixes.
8014 This is not an exhaustive set of fixes, but it's time to
8015 record what I've got.
8016 (lookup_pixel_color, check_image_size): Remove redundant decls.
8017 (check_image_size): Don't assume that arbitrary EMACS_INT values
8018 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8019 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8020 (tiff_load, imagemagick_load_image):
8021 Check for overflow in size calculations.
8022 (x_create_x_image_and_pixmap): Remove unnecessary test for
8023 xmalloc returning NULL; that can't happen.
8024 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8025 (xpm_color_bucket): Use better integer hashing function.
8026 (xpm_cache_color): Don't possibly over-allocate memory.
8027 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8028 (gif_memory_source):
8029 Use ptrdiff_t, not int or size_t, to record sizes.
8030 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8031 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8032 either works, as we prefer signed integers.
8033 (tiff_read_from_memory, tiff_write_from_memory):
8034 Return tsize_t, not size_t, since that's what the TIFF API wants.
8035 (tiff_read_from_memory): Don't fail simply because the read would
8036 go past EOF; instead, return a short read.
8037 (tiff_load): Omit no-longer-needed casts.
8038 (Fimagemagick_types): Don't assume size fits into 'int'.
8039
3cc5a532
PE
8040 Improve hashing quality when configured --with-wide-int.
8041 * fns.c (hash_string): New function, taken from sxhash_string.
8042 Do not discard information about ASCII character case; this
8043 discarding is no longer needed.
8044 (sxhash-string): Use it. Change sig to match it. Caller changed.
8045 * lisp.h: Declare it.
8046 * lread.c (hash_string): Remove, since we now use fns.c's version.
8047 The fns.c version returns a wider integer if --with-wide-int is
8048 specified, so this should help the quality of the hashing a bit.
8049
b312a492
PE
8050 * emacs.c: Integer overflow minor fix.
8051 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8052 Define only if GNU_LINUX.
8053 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8054
dfd153ae
PE
8055 * dispnew.c: Integer signedness and overflow fixes.
8056 Remove unnecessary forward decls, that were a maintenance hassle.
8057 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8058 All uses changed.
8059 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8060 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8061 (prepare_desired_row, line_draw_cost):
8062 Use int, not unsigned, where either works.
8063 (save_current_matrix, restore_current_matrix):
8064 Use ptrdiff_t, not size_t, where either works.
8065 (init_display): Check for overflow more accurately, and without
8066 relying on undefined behavior.
8067
a81d11a3
PE
8068 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8069 Remove, replacing with the new symbols in lisp.h. All uses changed.
8070 * fileio.c (make_temp_name):
8071 * filelock.c (lock_file_1, lock_file):
8072 * xdisp.c (message_dolog):
8073 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8074 Use pMd etc. instead.
8075 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8076 replacing the pWIDE etc. symbols removed from editfns.c.
8077
3300e6fd
PE
8078 * keyboard.h (num_input_events): Now uintmax_t.
8079 This is (very slightly) less likely to mess up due to wraparound.
8080 All uses changed.
8081
fd05c7e9
PE
8082 * buffer.c: Integer signedness fixes.
8083 (alloc_buffer_text, enlarge_buffer_text):
8084 Use ptrdiff_t rather than size_t when either will do, as we prefer
8085 signed integers.
8086
903fe15d
PE
8087 * alloc.c: Integer signedness and overflow fixes.
8088 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8089 (__malloc_size_t): Default to size_t, not to int.
8090 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8091 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8092 Prefer ptrdiff_t to size_t when either would do, as we prefer
8093 signed integers.
8094 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8095 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8096 Now const. Initialize with values that are in range even if char
8097 is signed.
8098 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8099 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8100 These functions do the right thing with sizes > 2**32.
8101 (check_depth): Now ptrdiff_t, not int.
8102 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8103 Adjust to new way of storing sizes. Check for size overflow bugs
8104 in rest of code.
8105 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8106 slightly wrong anyway, as it missed one instance of
8107 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8108 (refill_memory_reserve): Omit needless cast to size_t.
8109 (mark_object_loop_halt): Mark as externally visible.
8110
ac82cc6a
PE
8111 * xselect.c: Integer signedness and overflow fixes.
8112 (Fx_register_dnd_atom, x_handle_dnd_message):
8113 Use ptrdiff_t, not size_t, since we prefer signed.
8114 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8115 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8116 x_dnd_atoms_size and x_dnd_atoms_length.
8117
c2d1e36d
PE
8118 * doprnt.c: Prefer signed to unsigned when either works.
8119 * eval.c (verror):
8120 * doprnt.c (doprnt):
8121 * lisp.h (doprnt):
8122 * xdisp.c (vmessage):
8123 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8124 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8125 prefer signed arithmetic to avoid comparison confusion.
8126 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8127 but is a bit tricky.
8128
0e926e56
PE
8129 Assume freestanding C89 headers, string.h, stdlib.h.
8130 * data.c, doprnt.c, floatfns.c, print.c:
8131 Include float.h unconditionally.
8132 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8133 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8134 * regex.c: Likewise for stddef.h, string.h.
8135 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8136 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8137 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8138 (STDC_HEADERS): Remove obsolete defines.
8139 * sysdep.c: Include limits.h unconditionally.
8140
9cfdb3ec
PE
8141 Assume support for memcmp, memcpy, memmove, memset.
8142 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8143 * regex.c (memcmp, memcpy):
8144 Remove; we assume C89 now.
8145
8146 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8147 (__malloc_safe_bcopy): Remove; no longer needed.
8148
cf950e6b 8149 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8150 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8151 well either way, and we prefer signed to unsigned.
8152
dbf38e02
LMI
81532011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8154
8155 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8156 closes the connection while we're reading (bug#9182).
8157
d6f0886c 81582011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8159
d6f0886c
JD
8160 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8161 are specified (Bug#9168).
24e0f6b1 8162
2eb1f9e6
PE
81632011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8164
8165 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8166 Found by GCC static checking and --with-wide-int on a 32-bit host.
8167
22381272 81682011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8169
8170 * xdisp.c (compute_display_string_pos): Fix logic of caching
8171 previous display string position. Initialize cached_prev_pos to
8172 -1. Fixes slow-down at the beginning of a buffer.
8173
f25e39b4
EZ
81742011-07-24 Eli Zaretskii <eliz@gnu.org>
8175
8176 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8177 for attrs[LFACE_FONTSET_INDEX].
8178
04c4b52e
PE
81792011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8180
8181 * xml.c (parse_region): Remove unused local
8182 that was recently introduced.
8183
c1734fbd
EZ
81842011-07-23 Eli Zaretskii <eliz@gnu.org>
8185
be18c5a5
EZ
8186 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8187 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8188
c1734fbd
EZ
8189 * xdisp.c (move_it_in_display_line_to): Record the best matching
8190 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8191 exit if none of the characters scanned was an exact match.
8192 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8193 when exact match is impossible due to invisible text, and the
8194 lines are truncated.
8195
a258d627
JD
81962011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8197
8198 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8199 for OSX >= 10.7.
8200
b6d5a689
EZ
82012011-07-22 Eli Zaretskii <eliz@gnu.org>
8202
0f74f785
EZ
8203 Fix a significant slow-down of cursor motion with C-n, C-p,
8204 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8205 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8206 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8207 (next_element_from_buffer): Call compute_stop_pos_backwards to
8208 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8209 base_level_stop.
8210 (reseat): Don't look for prev_stop, as that could mean a very long
8211 run.
8212 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8213 <cached_disp_overlay_modiff>: Cache for last found display string
8214 position.
551918c1 8215 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8216 about the same buffer in the same area of character positions, and
8217 the buffer wasn't changed since the time the display string
8218 position was cached.
551918c1 8219
b2d0c91a
EZ
82202011-07-22 Eli Zaretskii <eliz@gnu.org>
8221
8222 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8223 is an integer, which is important for empty lines. (Bug#9149)
8224
043604ee
CY
82252011-07-22 Chong Yidong <cyd@stupidchicken.com>
8226
8227 * frame.c (Fmodify_frame_parameters): In tty case, update the
8228 default face if necessary (Bug#4238).
8229
da4adb04
CY
82302011-07-21 Chong Yidong <cyd@stupidchicken.com>
8231
8232 * editfns.c (Fstring_to_char): No need to explain what a character
8233 is in the docstring (Bug#6576).
8234
9abd0532
LMI
82352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8236
8237 * xml.c (parse_region): Make sure we always return a tree.
8238
36881d16
HK
82392011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8240
8241 * xml.c (parse_region): If a document contains only comments,
8242 return that, too.
8243
1e98674d
LMI
82442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8245
8246 * xml.c (make_dom): Return comments, too.
8247
590bd467
PE
82482011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8249
8250 Port to OpenBSD.
8251 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8252 and the surrounding thread.
8253 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8254 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8255 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8256 timer goes off.
8257 * s/openbsd.h (BROKEN_SIGIO): Define.
8258 * unexelf.c (unexec) [__OpenBSD__]:
8259 Don't update the .mdebug section of the Alpha COFF symbol table.
8260
f41628b2
LMI
82612011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8262
8263 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8264 (bug#8460).
8265
b59b67c5
PE
82662011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8267
15e3a074
PE
8268 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8269 This fixes some race conditions on the permissions of any newly
8270 created file.
8271
41bed37d
PE
8272 * alloc.c (valid_pointer_p): Use pipe, not open.
8273 This fixes some permissions issues when debugging.
8274
b59b67c5
PE
8275 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8276 If fchown fails to set both uid and gid, try to set just gid,
8277 as that is sometimes allowed. Adjust the file's mode to eliminate
8278 setuid or setgid bits that are inappropriate if fchown fails.
8279
925a6be7
SM
82802011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8281
8282 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8283 to compare Lisp_Objects.
8284 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8285 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8286 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8287
52968808
AS
82882011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8289
0a6a104b
AS
8290 * lread.c (read_integer): Unread even EOF character.
8291 (read1): Likewise. Properly record start position of symbol.
8292
52968808
AS
8293 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8294 symbol character follows.
8295
9e381cdd
PE
82962011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8297
8298 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8299 This works around a problem with the previous change to Fcopy_file.
8300 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8301 and without this change, GCC might complain about discarding
8302 fchown's return value.
8303
b5641435
JB
83042011-07-16 Juanma Barranquero <lekktu@gmail.com>
8305
8306 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8307
a8031457
PE
83082011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8309
8310 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8311
dd889327
LMI
83122011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8313
750c33f7
LMI
8314 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8315 it's used from the C level.
8316
dd889327
LMI
8317 * process.c: Use the same condition for POLL_FOR_INPUT in both
8318 keyboard.c and process.c (bug#1858).
8319
87e86684
LM
83202011-07-09 Lawrence Mitchell <wence@gmx.li>
8321
8322 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8323 (Fgnutls_boot): Use it.
8324
64348f40
AS
83252011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8326
8327 * doc.c (Fsubstitute_command_keys): Revert last change.
8328
1d698799
LMI
83292011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8330
f863868c
LMI
8331 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8332 quotes the next character, and doesn't affect other longer
8333 sequences (bug#8935).
8334
1d698799
LMI
8335 * lread.c (syms_of_lread): Clarify that is isn't only
8336 `eval-buffer' and `eval-defun' that's affected by
8337 `lexical-binding' (bug#8460).
8338
aa4b6df6
EZ
83392011-07-15 Eli Zaretskii <eliz@gnu.org>
8340
8341 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8342 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8343
5d856da6
PE
83442011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8345
ad6042bb
PE
8346 Fix minor problems found by static checking.
8347 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8348 (elsz): Now a signed constant, not a size_t var. We prefer signed
8349 types to unsigned, to avoid integer comparison confusion. Without
8350 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8351 "cannot optimize loop, the loop counter may overflow", a symptom
8352 of the confusion.
f00bbb22 8353 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8354 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8355
6468f31c
LMI
83562011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8357
49080b10
LMI
8358 * search.c (Fre_search_backward): Mention `case-fold-search' in
8359 all the re_search_* functions (bug#8138).
8360
6468f31c
LMI
8361 * keyboard.c (Fopen_dribble_file): Document when the file is
8362 closed (bug#8056).
8363
c965adc5
EZ
83642011-07-14 Eli Zaretskii <eliz@gnu.org>
8365
df9733bf
EZ
8366 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8367 bidi_cache_idx.
8368
0bb23927
EZ
8369 Support bidi reordering of display and overlay strings.
8370 * xdisp.c (compute_display_string_pos)
8371 (compute_display_string_end): Accept additional argument STRING.
8372 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8373 (reseat_to_string): Initialize bidi_it->string.s and
8374 bidi_it->string.schars.
8375 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8376 NULL (avoids a crash in bidi_paragraph_init).
8377 Initialize itb.string.lstring.
0bb23927
EZ
8378 (init_iterator): Call bidi_init_it only of a valid
8379 buffer position was specified. Initialize paragraph_embedding to
8380 L2R.
8381 (reseat_to_string): Initialize the bidi iterator.
8382 (display_string): If we need to ignore text properties of
8383 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8384 original value of -1 will not work with bidi.)
8385 (compute_display_string_pos): First arg is now struct
8386 `text_pos *'; all callers changed. Support display properties on
8387 Lisp strings.
8388 (compute_display_string_end): Support display properties on Lisp
8389 strings.
8390 (init_iterator, reseat_1, reseat_to_string): Initialize the
8391 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8392 when iterating on a string not from display properties).
640c8776
SM
8393 (compute_display_string_pos, compute_display_string_end):
8394 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8395 arrow keys.
8396 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8397 base_level_stop; instead, set base_level_stop to BEGV.
8398 Fixes crashes in vertical-motion.
0bb23927
EZ
8399 (next_element_from_buffer): Improve commentary for when
8400 the iterator is before prev_stop.
8401 (init_iterator): Initialize bidi_p from the default value of
8402 bidi-display-reordering, not from buffer-local value. Use the
8403 buffer-local value only if initializing for buffer iteration.
8404 (handle_invisible_prop): Support invisible properties on strings
8405 that are being bidi-reordered.
8406 (set_iterator_to_next): Support bidi reordering of C strings and
8407 Lisp strings.
8408 (next_element_from_string): Support bidi reordering of Lisp
8409 strings.
8410 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8411 (display_string): Support display of R2L glyph rows.
8412 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8413 (init_iterator): Don't initialize it->bidi_p for strings
8414 here.
8415 (reseat_to_string): Initialize it->bidi_p for strings here.
8416 (next_element_from_string, next_element_from_c_string)
8417 (next_element_from_buffer): Add xassert's for correspondence
8418 between IT's object being iterated and it->bidi_it.string
8419 structure.
8420 (face_before_or_after_it_pos): Support bidi iteration.
8421 (next_element_from_c_string): Handle the case of the first string
8422 character that is not the first one in the visual order.
8423 (get_visually_first_element): New function, refactored from common
8424 parts of next_element_from_buffer, next_element_from_string, and
8425 next_element_from_c_string.
8426 (tool_bar_lines_needed, redisplay_tool_bar)
8427 (display_menu_bar): Force left-to-right direction. Add a FIXME
8428 comment for making that be controlled by a user option.
8429 (push_it, pop_it): Save and restore the state of the
8430 bidi iterator. Save and restore the bidi_p flag.
8431 (pop_it): Iterate out of display property for string iteration as
8432 well.
8433 (iterate_out_of_display_property): Support iteration over strings.
8434 (handle_single_display_spec): Set up it->bidi_it for iteration
8435 over a display string, and call bidi_init_it.
8436 (handle_single_display_spec, next_overlay_string)
8437 (get_overlay_strings_1, push_display_prop): Set up the bidi
8438 iterator for displaying display or overlay strings.
8439 (forward_to_next_line_start): Don't use the shortcut if
8440 bidi-iterating.
8441 (back_to_previous_visible_line_start): If handle_display_prop
8442 pushed the iterator stack, restore the internal state of the bidi
8443 iterator by calling bidi_pop_it same number of times.
8444 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8445 and we are bidi-iterating, don't decrement the iterator position;
8446 instead, set the first_elt flag in the bidi iterator, to produce
8447 the same effect.
8448 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8449 (push_display_prop): xassert that we are iterating a buffer.
8450 (push_it, pop_it): Save and restore paragraph_embedding member.
8451 (handle_single_display_spec, next_overlay_string)
8452 (get_overlay_strings_1, reseat_1, reseat_to_string)
8453 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8454 correctly. Don't assume unibyte strings are not bidi-reordered.
8455 (compute_display_string_pos)
8456 (compute_display_string_end): Fix handling the case of C string.
8457 (push_it, pop_it): Save and restore from_disp_prop_p.
8458 (handle_single_display_spec, push_display_prop): Set the
8459 from_disp_prop_p flag.
8460 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8461 (pop_it): Call iterate_out_of_display_property only if we are
8462 popping after iteration over a string that came from a display
8463 property. Fix a typo in popping stretch info. Add an assertion
8464 for verifying that the iterator position is in sync with the bidi
8465 iterator.
8466 (handle_single_display_spec, get_overlay_strings_1)
8467 (push_display_prop): Fix initialization of paragraph direction for
8468 string when that of the parent object is not yet determined.
8469 (reseat_1): Call bidi_init_it to resync the bidi
8470 iterator with IT's position. (Bug#7616)
8471 (find_row_edges): If ROW->start.pos gives position
8472 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8473 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8474 Reset the from_disp_prop_p flag.
8475 (SAVE_IT, RESTORE_IT): New macros.
8476 (pos_visible_p, face_before_or_after_it_pos)
8477 (back_to_previous_visible_line_start)
8478 (move_it_in_display_line_to, move_it_in_display_line)
8479 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8480 (try_scrolling, redisplay_window, display_line): Use them when
8481 saving a temporary copy of the iterator and restoring it back.
8482 (back_to_previous_visible_line_start, reseat_1)
8483 (init_iterator): Empty the bidi cache "stack".
8484 (move_it_in_display_line_to): If iterator ended up at
8485 EOL, but we never saw any buffer positions smaller than
8486 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8487 motion in bidi-reordered lines.
8488 (move_it_in_display_line_to): Record prev_method and prev_pos
8489 immediately before the call to set_iterator_to_next. Fixes cursor
8490 motion in bidi-reordered lines with stretch glyphs and strings
8491 displayed in margins. (Bug#8133) (Bug#8867)
8492 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8493 TO_CHARPOS.
640c8776
SM
8494 (pos_visible_p): Support positions in bidi-reordered lines.
8495 Save and restore bidi cache.
0bb23927
EZ
8496
8497 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8498 (bidi_paragraph_info): Delete unused struct.
8499 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8500 (bidi_cache_start): New variable.
8501 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8502 to zero.
8503 (bidi_cache_fetch_state, bidi_cache_search)
8504 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8505 (bidi_cache_find, bidi_peek_at_next_level)
8506 (bidi_level_of_next_char, bidi_find_other_level_edge)
8507 (bidi_move_to_visually_next): Compare cache index with
8508 bidi_cache_start rather than with zero.
8509 (bidi_fetch_char): Accept new argument STRING; all callers
8510 changed. Support iteration over a string. Support strings with
8511 display properties. Support unibyte strings. Fix the type of
8512 `len' according to what STRING_CHAR_AND_LENGTH expects.
8513 (bidi_paragraph_init, bidi_resolve_explicit_1)
8514 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8515 (bidi_level_of_next_char, bidi_move_to_visually_next):
8516 Support iteration over a string.
0bb23927
EZ
8517 (bidi_set_sor_type, bidi_resolve_explicit_1)
8518 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8519 can now be zero (for strings); special values 0 and -1 were
8520 changed to -1 and -2, respectively.
8521 (bidi_char_at_pos): New function.
8522 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8523 Call it instead of FETCH_MULTIBYTE_CHAR.
8524 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8525 initialized to valid values.
8526 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8527 values.
8528 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8529 the test for valid cached positions. Fix the logic for looking up
8530 the sentinel state in the cache. GCPRO the Lisp string we are
8531 iterating.
8532 (bidi_push_it, bidi_pop_it): New functions.
8533 (bidi_initialize): Initialize the bidi cache start stack pointer.
8534 (bidi_cache_ensure_space): New function, refactored from part of
8535 bidi_cache_iterator_state. Don't assume the required size is just
8536 one BIDI_CACHE_CHUNK away.
8537 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8538 (bidi_count_bytes, bidi_char_at_pos): New functions.
8539 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8540 always valid if bidi_cache_idx is valid.
8541 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8542 is valid if it's going to be used.
8543 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8544 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8545 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8546 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8547 (bidi_find_other_level_edge, bidi_cache_start_stack):
8548 All variables related to cache indices are now EMACS_INT.
c965adc5 8549
0bb23927
EZ
8550 * dispextern.h (struct bidi_string_data): New structure.
8551 (struct bidi_it): New member `string'. Make flag members be 1-bit
8552 fields, and put them last in the struct.
640c8776
SM
8553 (compute_display_string_pos, compute_display_string_end):
8554 Update prototypes.
0bb23927
EZ
8555 (bidi_push_it, bidi_pop_it): Add prototypes.
8556 (struct iterator_stack_entry): New members bidi_p,
8557 paragraph_embedding, and from_disp_prop_p.
8558 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8559 (bidi_shelve_cache, bidi_unshelve_cache):
8560 Declare prototypes.
0bb23927
EZ
8561
8562 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8563 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8564 and vector-like objects.
8565
8566 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8567 cache around display iteration.
8568
8569 * window.c (Fwindow_end, window_scroll_pixel_based)
8570 (displayed_window_lines, Frecenter): Save and restore the bidi
8571 cache around display iteration.
8572
3bbd2265
LMI
85732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8574
8575 * editfns.c (Fdelete_region): Clarify the use of the named
8576 parameters (bug#6788).
8577
adc47434
MR
85782011-07-14 Martin Rudalics <rudalics@gmx.at>
8579
8580 * indent.c (Fvertical_motion): Set and restore w->pointm when
8581 saving and restoring the window's buffer (Bug#9006).
8582
837c31f8
LMI
85832011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8584
8585 * editfns.c (Fstring_to_char): Clarify just what is returned
8586 (bug#6576). Text by Eli Zaretskii.
8587
ac389d0c
JB
85882011-07-13 Juanma Barranquero <lekktu@gmail.com>
8589
8590 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8591
0be0ce47
EZ
85922011-07-13 Eli Zaretskii <eliz@gnu.org>
8593
8594 * buffer.c (mmap_find): Fix a typo.
8595
cd18e7e3
JB
85962011-07-13 Johan Bockgård <bojohan@gnu.org>
8597
8598 Fix execution of x selection hooks.
8599 * xselect.c (Qx_lost_selection_functions)
8600 (Qx_sent_selection_functions): New vars.
8601 (syms_of_xselect): DEFSYM them.
8602 (x_handle_selection_request): Pass Qx_sent_selection_functions
8603 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8604 (x_handle_selection_clear,x_clear_frame_selections):
8605 Pass Qx_lost_selection_functions rather than
8606 Vx_lost_selection_functions to Frun_hook_with_args.
8607
47ea7f44
PE
86082011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8609
ac389d0c 8610 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8611 The old code sometimes used this field without initializing it.
8612
47ea7f44
PE
8613 * alloc.c (gc_sweep): Don't read past end of array.
8614 In theory, the old code could also have corrupted Emacs internals,
8615 though it'd be very unlikely.
8616
bc985c87
AS
86172011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8618
8619 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8620 argument. (Bug#4026)
bc985c87 8621
0cf34688
LMI
86222011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8623
b3dadd76
LMI
8624 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8625 key" (bug#4257).
8626
0cf34688
LMI
8627 * window.c (Fset_window_start): Doc fix (bug#4199).
8628 (Fset_window_hscroll): Ditto.
8629
270768cd
PE
86302011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8631
077e3dda 8632 Fix minor new problems caught by GCC 4.6.1.
270768cd 8633 * term.c (init_tty): Remove unused local.
490011a6 8634 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8635 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8636 not used otherwise.
270768cd 8637
b1f58454
CY
86382011-07-12 Chong Yidong <cyd@stupidchicken.com>
8639
8640 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8641
22b9578d
LMI
86422011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8643
6e70ab07
LMI
8644 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8645 are the mini-buffer and the echo area (bug#3320).
8646
22b9578d
LMI
8647 * term.c (init_tty): Remove support for supdup, c10 and perq
8648 terminals, which are no longer supported (bug#1482).
8649
8974cc9f
JB
86502011-07-10 Johan Bockgård <bojohan@gnu.org>
8651
8652 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8653
a560d974
JD
86542011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8655
8656 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8657 for non-popups (Bug#3642).
8658
1dae0f0a
AS
86592011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8660
268c2c36 8661 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8662 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8663 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8664 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8665 * data.c (fmod): Likewise.
8666 * dispnew.c (swap_glyphs_in_rows): Likewise.
8667 * emacs.c (memory_warning_signal): Likewise.
8668 * floatfns.c (float_error): Likewise.
8669 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8670 (otf_open, font_otf_capability, generate_otf_features)
8671 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8672 Likewise.
8673 * image.c (pbm_read_file): Likewise.
8674 * indent.c (string_display_width): Likewise.
8675 * intervals.c (check_for_interval, search_for_interval)
8676 (inc_interval_count, count_intervals, root_interval)
8677 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8678 * lread.c (defalias): Likewise.
268c2c36 8679 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8680 * regex.c (set_image_of_range_1, set_image_of_range)
8681 (regex_grow_registers): Likewise.
8682 * sysdep.c (strerror): Likewise.
8683 * termcap.c (valid_filename_p, tprint, main): Likewise.
8684 * tparam.c (main): Likewise.
8685 * unexhp9k800.c (run_time_remap, save_data_space)
8686 (update_file_ptrs, read_header, write_header, calculate_checksum)
8687 (copy_file, copy_rest, display_header): Likewise.
8688 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8689 Likewise.
8690 * xdisp.c (check_it): Likewise.
8691 * xfaces.c (register_color, unregister_color, unregister_colors):
8692 Likewise.
8693 * xfns.c (print_fontset_result): Likewise.
8694 * xrdb.c (member, fatal, main): Likewise.
8695
99033785
PE
86962011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8697
8698 Fix minor problems found by static checking (Bug#9031).
8699 * chartab.c (char_table_set_range, map_sub_char_table):
8700 Remove unused locals.
8701 (uniprop_table): Now static.
8702 * composite.c (_work_char): Remove unused static var.
8703
9cb2ac56
JB
87042011-07-09 Juanma Barranquero <lekktu@gmail.com>
8705
8706 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8707
f25661f0
JD
87082011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8709
8710 * gtkutil.c (qttip_cb): Remove code without function.
8711
8278c4fe
EZ
87122011-07-09 Eli Zaretskii <eliz@gnu.org>
8713
8714 * w32.c (pthread_sigmask): New stub.
8715
1692ae2d 87162011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8717
8a6ebd58 8718 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8719 sigprocmask is portable only for single-threaded applications, and
8720 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8721 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8722 (LIBES): Use it.
8723 * callproc.c (Fcall_process):
8724 * process.c (create_process):
8725 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8726 Use pthread_sigmask, not sigprocmask.
123403e4 8727
1b854618
JD
87282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8729
8730 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8731 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8732 wrong (Bug#8591).
8733
3fe4b549
JD
87342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8735
0ce7e563
JD
8736 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8737 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8738 (xg_hide_tooltip): Fix comment.
8739
3fe4b549
JD
8740 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8741 in registerServicesMenuSendTypes.
8742 (validRequestorForSendType): Don't check ns_return_types.
8743
8744 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8745 ns_return_type.
8746
5df75e47
JR
87472011-07-08 Jason Rumney <jasonr@gnu.org>
8748
22610910
JR
8749 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8750 SH_SHOW for hidden windows (Bug#5482).
8751
5df75e47
JR
8752 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8753 frame struct members of non-existent frames (Bug#6284).
8754
699c10bd
JD
87552011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8756
4393663b
JD
8757 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8758 variable firstTime not needed on OSX >= 10.6.
8759 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8760 >= 10.5. Use setKnobProportion, setDoubleValue.
8761
8762 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8763 (MAC_OS_X_VERSION_10_5): Define if not defined.
8764 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8765 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8766 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8767
8768 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8769 cString and lossyCString on OSX >= 10.4.
4393663b 8770
58179cce 8771 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8772 sizeToFit on OSX >= 10.2.
8773
8774 * nsimage.m (allocInitFromFile): Don't use deprecated method
8775 bestRepresentationForDevice on OSX >= 10.6.
8776
8777 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8778 to avoid warning.
8779
8780 * emacs.c: Declare unexec_init_emacs_zone.
8781
a63e0781
JD
8782 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8783
699c10bd
JD
8784 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8785
8786 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8787 on svcsMenu (Bug#8842).
8788
8789 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8790 ns_return_types.
8791 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8792
8793 * nsterm.m (QUTF8_STRING): Declare.
8794 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8795 (validRequestorForSendType): Return type is (id).
8796 Change indexOfObjectIdenticalTo to indexOfObject.
8797 Check if we have local selection before returning self (Bug#8842).
8798 (writeSelectionToPasteboard): Put local selection into paste board
8799 if we have a local selection (Bug#8842).
8800 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8801
8802 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8803 (ns_get_local_selection): Declare.
8804
54e10184
LMI
88052011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8806
9888ff71
LMI
8807 * keymap.c (describe_map_tree): Don't insert a double newline at
8808 the end of the buffer (bug#1169) and return whether we inserted
8809 something.
8810
54e10184
LMI
8811 * callint.c (Fcall_interactively): Change "reading args" to
8812 "providing args" to try to clarify what it does (bug#1010).
8813
15fa4783
KH
88142011-07-07 Kenichi Handa <handa@m17n.org>
8815
8816 * composite.c (composition_compute_stop_pos): Ignore a static
8817 composition starting before CHARPOS (Bug#8915).
8818
8819 * xdisp.c (handle_composition_prop): Likewise.
8820
a8815b00
EZ
88212011-07-07 Eli Zaretskii <eliz@gnu.org>
8822
8823 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8824 (Bug#9015)
8825
ef7b981d 88262011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8827
8828 * character.h (unicode_category_t): New enum type.
8829
8830 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8831 (Qchar_code_property_table): New variable.
8832 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8833 (UNIPROP_COMPRESSED_FORM_P): New macros.
8834 (char_table_ascii): Uncompress the compressed values.
8835 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8836 Uncompress the compressed values.
ac389d0c 8837 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8838 (char_table_ref_and_range): Uncompress the compressed values.
8839 (sub_char_table_set): New arg is_uniprop. Callers changed.
8840 Uncompress the compressed values.
8841 (sub_char_table_set_range): Args changed. Callers changed.
8842 (char_table_set_range): Adjuted for the above change.
8843 (map_sub_char_table): Delete args default_val and parent. Add arg
8844 top. Give decoded values to a Lisp function.
640c8776 8845 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8846 values to a Lisp function. Gcpro more variables.
8847 (uniprop_table_uncompress)
8848 (uniprop_decode_value_run_length): New functions.
8849 (uniprop_decoder, uniprop_decoder_count): New variables.
8850 (uniprop_get_decoder, uniprop_encode_value_character)
8851 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8852 New functions.
8853 (uniprop_encoder, uniprop_encoder_count): New variables.
8854 (uniprop_get_encoder, uniprop_table)
8855 (Funicode_property_table_internal, Fget_unicode_property_internal)
8856 (Fput_unicode_property_internal): New functions.
8857 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8858 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8859 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8860 char-code-property-alist.
8861
640c8776 8862 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8863 Vunicode_category_table.
8864
640c8776 8865 * font.c (font_range): Adjust for the change of
c805dec0
KH
8866 Vunicode_category_table.
8867
76b397fb
DN
88682011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8869
8870 * m/iris4d.h: Remove file, move contents ...
8871 * s/irix6-5.h: ... here.
8872
22b4128e
PE
88732011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8874
8875 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8876 * alloc.c (mark_buffer):
8877 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8878 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8879 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8880 This isn't true in general, and it's particularly not true
8881 if Emacs is configured with --with-wide-int.
8882 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8883 New macros, used in the buffer.c change.
8884
869795d6
JD
88852011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8886
8887 * xsettings.c: Use both GConf and GSettings if both are available.
8888 (store_config_changed_event): Add comment.
8889 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8890 (store_tool_bar_style_changed): New functions.
5e617bc2 8891 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8892 (struct xsettings): Move font inside HAVE_XFT.
8893 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8894 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8895 Move inside HAVE_XFT.
640c8776 8896 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8897 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8898 also.
8899 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8900 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8901 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8902 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8903 (parse_settings): Move check for font inside HAVE_XFT.
8904 (read_settings, apply_xft_settings): Add comment.
8905 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8906 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8907 call store_font_name_changed.
8908 (xft_settings_event): Add comment.
8909 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8910 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8911 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8912 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8913 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8914 (xsettings_get_system_font, xsettings_get_system_normal_font):
8915 Add comment.
869795d6 8916
d8ed26bd
PE
89172011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8918
8919 Random fixes. E.g., (random) never returned negative values.
8920 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8921 subseconds part to the entropy, as that's a bit more random.
8922 Prefer signed to unsigned, since the signedness doesn't matter and
8923 in general we prefer signed. When given a limit, use a
8924 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8925 latter isn't right if USE_2_TAGS_FOR_INTS.
8926 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8927 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8928
cabf1cac
SM
89292011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8930
8931 * textprop.c (text_property_stickiness):
8932 Obey Vtext_property_default_nonsticky.
8933 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8934 * w32fns.c (syms_of_w32fns):
8935 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8936
6e9b2be9
PE
89372011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8938
8939 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8940 This is more efficient than Ffile_directory_p and avoids a minor race.
8941
90186c68
LMI
89422011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8943
7c301272
LMI
8944 * buffer.c (Foverlay_put): Say what the return value is
8945 (bug#7835).
8946
c4f2d8d4
LMI
8947 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8948 is a directory before asking whether to use the file name
8949 (bug#7564).
ad637907
LMI
8950 (barf_or_query_if_file_exists): Make the "File is a directory"
8951 error be more correct.
c4f2d8d4 8952
90186c68
LMI
8953 * fns.c (Frequire): Remove the mention of the .gz files, since
8954 that's installation-specific, but keep the mention of
8955 `get-load-suffixes'.
8956
da64016e
PE
89572011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8958
8959 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8960 Report string overflow if the output is too long.
8961
7d47b580
JB
89622011-07-04 Juanma Barranquero <lekktu@gmail.com>
8963
a555cb87
JB
8964 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8965 (syms_of_gnutls): Remove duplicate DEFSYM for
8966 Qgnutls_bootprop_verify_hostname_error, an error for
8967 Qgnutls_bootprop_verify_error (which is no longer used).
8968
7d47b580
JB
8969 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8970 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8971 Also (re)move comments that are misplaced or no longer relevant.
8972
1e49bfab
LMI
89732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8974
8975 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8976
1485f4c0
CY
89772011-07-03 Chong Yidong <cyd@stupidchicken.com>
8978
8979 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8980 and background color parameters if they have been changed.
8981
a9ab721e
LMI
89822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8983
8984 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8985
cf7cff57
PE
89862011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8987
2e13213d
PE
8988 * xsettings.c (SYSTEM_FONT): Define only when used.
8989 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8990
cf7cff57
PE
8991 * keymap.c (access_keymap_1): Now static.
8992
7a8e04f7
CY
89932011-07-02 Chong Yidong <cyd@stupidchicken.com>
8994
8995 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8996 leave any prefix arg for the up event (Bug#1586).
8997
61352f62
LMI
89982011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8999
69bb1ef7
LMI
9000 * lread.c (syms_of_lread): Mention single symbols defined by
9001 `defvar' or `defconst' (bug#7154).
9002
61352f62 9003 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9004 (Frequire): Mention get-load-suffixes.
61352f62 9005
28545e04
MR
90062011-07-02 Martin Rudalics <rudalics@gmx.at>
9007
9008 * window.h (window): Remove clone_number slot.
9009 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9010 Remove.
9011 (make_parent_window, make_window, saved_window)
9012 (Fset_window_configuration, save_window_save): Don't deal with
9013 clone numbers.
9014 * buffer.c (Qclone_number): Remove declaration.
9015 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9016
3349e122
SM
90172011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9018
9019 Add multiple inheritance to keymaps.
9020 * keymap.c (Fmake_composed_keymap): New function.
9021 (Fset_keymap_parent): Simplify.
9022 (fix_submap_inheritance): Remove.
9023 (access_keymap_1): New function extracted from access_keymap to handle
9024 embedded parents and handle lists of maps.
9025 (access_keymap): Use it.
9026 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9027 (Fcopy_keymap): Handle embedded parents.
9028 (Fcommand_remapping, define_as_prefix): Simplify.
9029 (Fkey_binding): Simplify.
9030 (syms_of_keymap): Move minibuffer-local-completion-map,
9031 minibuffer-local-filename-completion-map,
9032 minibuffer-local-must-match-map, and
9033 minibuffer-local-filename-must-match-map to Elisp.
9034 (syms_of_keymap): Defsubr make-composed-keymap.
9035 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9036 (parse_menu_item): Trivial simplification.
9037
3279eb87
GM
90382011-07-01 Glenn Morris <rgm@gnu.org>
9039
9040 * Makefile.in (SETTINGS_LIBS): Fix typo.
9041
4550efdf
KI
90422011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9043
9044 * coding.c (Fencode_coding_string): Record the last coding system
9045 used, as the function doc string says (bug#8738).
9046
0949d2b6
JD
90472011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9048
9049 * xsettings.c (store_monospaced_changed): Take new font as arg and
9050 check for change against current_mono_font.
9051 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9052 (emacs_settings_constructor, emacs_settings_get_property)
9053 (emacs_settings_set_property, emacs_settings_class_init)
9054 (emacs_settings_init, gsettings_obj): Remove.
9055 (something_changedCB): New function for HAVE_GSETTINGS.
9056 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9057 with value as argument.
9058 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9059 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9060 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9061 "changed".
9062
9063 * xgselect.c: Add defined (HAVE_GSETTINGS).
9064 (xgselect_initialize): Ditto.
9065
9066 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9067 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9068 xg_select.
9069
bbc6b304
PE
90702011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9071
9072 * eval.c (struct backtrace): Simplify and port the data structure.
9073 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9074 signed bit field, as this assumption is not portable and it makes
9075 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9076 "char debug_on_exit : 1" as this is not portable either; instead,
9077 use the portable "unsigned int debug_on_exit : 1". Remove unused
9078 member evalargs. Remove obsolete comments about cc bombing out.
9079
9851bfc5
JD
90802011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9081
51bb811f 9082 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9083 Let HAVE_GSETTINGS override HAVE_GCONF.
9084 (store_monospaced_changed): New function.
9085 (EMACS_SETTINGS): A new type derived from GObject to handle
9086 GSettings notifications.
9087 (emacs_settings_constructor, emacs_settings_get_property)
9088 (emacs_settings_set_property, emacs_settings_class_init):
9089 New functions.
9090 (gsettings_client, gsettings_obj): New variables.
9091 (GSETTINGS_SCHEMA): New define.
9092 (something_changedCB): Call store_monospaced_changed.
9093 (init_gsettings): New function.
9094 (xsettings_initialize): Call init_gsettings.
9095 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9096 to NULL.
9097
640c8776 9098 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9099 GCONF_CFLAGS/LIBS.
9100
5386012d
MR
91012011-06-29 Martin Rudalics <rudalics@gmx.at>
9102
9103 * window.c (resize_root_window, grow_mini_window)
9104 (shrink_mini_window): Rename Qresize_root_window to
9105 Qwindow_resize_root_window and Qresize_root_window_vertically to
9106 Qwindow_resize_root_window_vertically.
9107
f13e0b08
PE
91082011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9109
9110 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9111
94515237
JB
91122011-06-27 Juanma Barranquero <lekktu@gmail.com>
9113
9114 * makefile.w32-in: Redesign dependencies so they reflect more
9115 clearly which files are directly included by each source file,
9116 and not through other includes.
9117
e43b6e43
MR
91182011-06-27 Martin Rudalics <rudalics@gmx.at>
9119
9120 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9121 (sort_overlays, overlay_strings): When an overlay's clone number
9122 matches the window's clone number process the overlay even if
9123 the overlay's window property doesn't match the current window.
9124
d68443dc
MR
9125 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9126 (Fwindow_hchild): Rename to Fwindow_left_child.
9127 (Fwindow_next): Rename to Fwindow_next_sibling.
9128 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9129 (resize_window_check): Rename to window_resize_check.
9130 (resize_window_apply): Rename to window_resize_apply.
9131 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9132 (Fdelete_other_windows_internal, resize_frame_windows)
9133 (Fsplit_window_internal, Fdelete_window_internal)
9134 (grow_mini_window, shrink_mini_window)
9135 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9136
c7e73be5
JD
91372011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9138
9139 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9140 (emacs_fixed_set_min_size): Remove.
9141 (emacs_fixed_new): Take frame as argument.
9142
9143 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9144 (_EmacsFixedPrivate): Remove minwidth/height.
9145 Add struct frame *f.
9146 (emacs_fixed_init): Initialize priv->f.
9147 (get_parent_class, emacs_fixed_set_min_size): Remove.
9148 (emacs_fixed_new): Set priv->f to argument.
9149 (emacs_fixed_get_preferred_width)
9150 (emacs_fixed_get_preferred_height): Use min_width/height from
9151 frames size_hint to set minimum and natural (Bug#8919).
9152 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9153 and use min_width/height from frames size_hint to set
9154 min_width/height (Bug#8919).
9155
9156 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9157 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9158 Fix indentation.
c7e73be5 9159
cf99dcf8
EZ
91602011-06-26 Eli Zaretskii <eliz@gnu.org>
9161
9162 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9163 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9164 called at ZV.
9165
029529ac
CY
91662011-06-26 Chong Yidong <cyd@stupidchicken.com>
9167
9168 * process.c (wait_reading_process_output): Bypass select if
9169 waiting for a cell while ignoring keyboard input, and input is
9170 pending. Suggested by Jan Djärv (Bug#8869).
9171
7a7ef429
PE
91722011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9173
9174 Use gnulib's dup2 module instead of rolling our own.
9175 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9176
11fdef7d 91772011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9178
9179 * dispnew.c (scrolling_window): Before scrolling, turn off a
9180 mouse-highlight in the window being scrolled.
9181
cd3520a4
JB
91822011-06-24 Juanma Barranquero <lekktu@gmail.com>
9183
9184 Move DEFSYM to lisp.h and use everywhere.
9185
9186 * character.h (DEFSYM): Move declaration...
9187 * lisp.h (DEFSYM): ...here.
9188
9189 * gnutls.c:
9190 * minibuf.c:
9191 * w32menu.c:
9192 * w32proc.c:
9193 * w32select.c: Don't include character.h.
9194
9195 * alloc.c (syms_of_alloc):
9196 * buffer.c (syms_of_buffer):
9197 * bytecode.c (syms_of_bytecode):
9198 * callint.c (syms_of_callint):
9199 * casefiddle.c (syms_of_casefiddle):
9200 * casetab.c (init_casetab_once):
9201 * category.c (init_category_once, syms_of_category):
9202 * ccl.c (syms_of_ccl):
9203 * cmds.c (syms_of_cmds):
9204 * composite.c (syms_of_composite):
9205 * dbusbind.c (syms_of_dbusbind):
9206 * dired.c (syms_of_dired):
9207 * dispnew.c (syms_of_display):
9208 * doc.c (syms_of_doc):
9209 * editfns.c (syms_of_editfns):
9210 * emacs.c (syms_of_emacs):
9211 * eval.c (syms_of_eval):
9212 * fileio.c (syms_of_fileio):
9213 * fns.c (syms_of_fns):
9214 * frame.c (syms_of_frame):
9215 * fringe.c (syms_of_fringe):
9216 * insdel.c (syms_of_insdel):
9217 * keymap.c (syms_of_keymap):
9218 * lread.c (init_obarray, syms_of_lread):
9219 * macros.c (syms_of_macros):
9220 * msdos.c (syms_of_msdos):
9221 * print.c (syms_of_print):
9222 * process.c (syms_of_process):
9223 * search.c (syms_of_search):
9224 * sound.c (syms_of_sound):
9225 * syntax.c (init_syntax_once, syms_of_syntax):
9226 * terminal.c (syms_of_terminal):
9227 * textprop.c (syms_of_textprop):
9228 * undo.c (syms_of_undo):
9229 * w32.c (globals_of_w32):
9230 * window.c (syms_of_window):
9231 * xdisp.c (syms_of_xdisp):
9232 * xfaces.c (syms_of_xfaces):
9233 * xfns.c (syms_of_xfns):
9234 * xmenu.c (syms_of_xmenu):
9235 * xsettings.c (syms_of_xsettings):
9236 * xterm.c (syms_of_xterm): Use DEFSYM.
9237
4228cf16
TZ
92382011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9239
cd3520a4 9240 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9241
7fcccf1e
PE
92422011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9243
7efb4e0e
PE
9244 Integer and buffer overflow fixes (Bug#8873).
9245
ff5844ad
PE
9246 * print.c (printchar, strout): Check for string overflow.
9247 (PRINTPREPARE, printchar, strout):
9248 Don't set size unless allocation succeeds.
9249
90532f02
PE
9250 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9251 for sizes. Check for string overflow more accurately.
9252 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9253
6d84508d
PE
9254 * macros.c: Integer and buffer overflow fixes.
9255 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9256 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9257 Use ptrdiff_t, not int, for sizes.
9258 Don't increment bufsize until after realloc succeeds.
9259 Check for size-calculation overflow.
9260 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9261
437b2cb4
PE
9262 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9263
8b9ac8b4
PE
9264 * lread.c: Integer overflow fixes.
9265 (read_integer): Radix is now EMACS_INT, not int,
9266 to improve quality of diagnostics for out-of-range radices.
9267 Calculate buffer size correctly for out-of-range radices.
9268 (read1): Check for integer overflow in radices, and in
9269 read-circle numbers.
82cb60d3
PE
9270 (read_escape): Avoid int overflow.
9271 (Fload, openp, read_buffer_size, read1)
9272 (substitute_object_recurse, read_vector, read_list, map_obarray):
9273 Use ptrdiff_t, not int, for sizes.
9274 (read1): Use EMACS_INT, not int, for sizes.
20270765 9275 Check for size overflow.
8b9ac8b4 9276
7fcccf1e
PE
9277 * image.c (cache_image): Check for size arithmetic overflow.
9278
bfbbd7e7
PE
9279 * lread.c: Integer overflow issues.
9280 (saved_doc_string_size, saved_doc_string_length)
9281 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9282 Now ptrdiff_t, not int.
9283 (read1): Don't assume doc string length fits in int. Check for
9284 out-of-range doc string lengths.
9285 (read_list): Don't assume file position fits in int.
39019e54 9286 (read_escape): Check for hex character overflow.
bfbbd7e7 9287
4e323265
LL
92882011-06-22 Leo Liu <sdl.web@gmail.com>
9289
9290 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9291 Move to minibuffer.el.
9292
85fece3e
PE
92932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9294
20b84ce9 9295 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9296 The following patches are for when GLYPH_DEBUG && !XASSERT.
9297 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9298 * dispnew.c (flush_stdout):
9299 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9300 Mark as externally visible.
9301 * dispnew.c (check_window_matrix_pointers): Now static.
9302 * dispnew.c (window_to_frame_vpos):
9303 * xfns.c (unwind_create_frame):
9304 * xterm.c (x_check_font): Remove unused local.
9305 * scroll.c (CHECK_BOUNDS):
9306 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9307 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9308 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9309 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9310 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9311 Now static.
9312 (debug_method_add): Use va_list and vsprintf rather than relying
9313 on undefined behavior with wrong number of arguments.
9314 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9315 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9316 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9317 since we're not interested in debugging glyphs with old libraries.
9318 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9319 GCC 4.6.0's static checking.
9320
0766b489
PE
93212011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9322
31fd4b32
PE
9323 Integer overflow and signedness fixes (Bug#8873).
9324 A few related buffer overrun fixes, too.
9325
b79e8648
PE
9326 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9327
0766b489
PE
9328 * dispextern.h (struct face.stipple):
9329 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9330 (x_bitmap_mask, x_allocate_bitmap_record)
9331 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9332 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9333 (x_create_bitmap_from_xpm_data):
9334 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9335 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9336 (.bitmaps_last):
9337 * xfaces.c (load_pixmap):
9338 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9339 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9340 (.bitmaps_last, struct x_output.icon_bitmap):
9341 Use ptrdiff_t, not int, for bitmap indexes.
9342 (x_allocate_bitmap_record): Check for size overflow.
9343 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9344
b081724f
PE
9345 Use ptrdiff_t, not int, for overlay counts.
9346 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9347 * editfns.c (overlays_around, get_pos_property):
9348 * textprop.c (get_char_property_and_overlay):
9349 * xdisp.c (next_overlay_change, note_mouse_highlight):
9350 * xfaces.c (face_at_buffer_position):
21514da7
PE
9351 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9352 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9353 (Fnext_overlay_change, Fprevious_overlay_change)
9354 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9355 Use ptrdiff_t, not int, for sizes.
21514da7 9356 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9357
3de73e5e
PE
9358 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9359
2606c57b
PE
9360 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9361 (x_session_initialize): Do not assume string length fits in int.
9362
aaafe47a
PE
9363 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9364 This is unlikely, but can occur if DPI is outlandish.
9365
2674ddc8 9366 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9367 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9368
28154962
PE
9369 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9370 * xrdb.c (magic_file_p, search_magic_path):
9371 Omit last arg SUFFIX; it was always 0. All callers changed.
9372 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9373
7de51af5
PE
9374 * xfont.c (xfont_match): Avoid need for strlen.
9375
25ed6cc3
PE
9376 * xfns.c: Don't assume strlen fits in int.
9377 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9378
4eab31dd
PE
9379 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9380 not unsigned long, as we prefer signed integers. All callers changed.
9381 Detect integer overflow in repeat count.
9382 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9383 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9384
171e2a58
PE
9385 * termcap.c: Don't assume sizes fit in int and never overflow.
9386 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9387 (gobble_line): Check for size-calculation overflow.
9388
ad39faca 9389 * minibuf.c (Fread_buffer):
6e5bb2dc 9390 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9391 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9392 Don't assume string length fits in int.
9393
52c61c22 9394 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9395 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9396
b5b8c9e5
PE
9397 * font.c: Don't assume string length fits in int.
9398 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9399 Use ptrdiff_t, not int.
ccd6111c
PE
9400 (font_intern_prop): Don't assume string length fits in int.
9401 Don't assume integer property fits in fixnum.
9402 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9403
882f0d81 9404 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9405 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9406 Reformulate so as not to need the command string.
9407 Invoke gzip -cd rather than gunzip, as it's more portable.
9408 (lock_info_type, lock_file_1, lock_file):
9409 Don't assume pid_t and time_t fit in unsigned long.
9410 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9411 (current_lock_owner): Prefer signed type for sizes.
9412 Use memcpy, not strncpy, where memcpy is what is really wanted.
9413 Don't assume (via atoi) that time_t and pid_t fit in int.
9414 Check for time_t and/or pid_t out of range, e.g., via a network share.
9415 Don't alloca where an auto var works fine.
9416
93f4cf88
PE
9417 * fileio.c: Fix some integer overflow issues.
9418 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9419 Don't assume string length fits in int.
9420 (directory_file_name): Don't assume string length fits in long.
9421 (make_temp_name): Don't assume pid fits in int, or that its print
9422 length is less than 20.
9423
f3e92b69
PE
9424 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9425
1bfdaf10
PE
9426 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9427
35016e9a
PE
9428 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9429
3d1e65a1
PE
9430 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9431 We prefer signed integers, even for size calculations.
9432
0b963a93
PE
9433 * emacs.c: Don't assume string length fits in 'int'.
9434 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9435 (main): Don't invoke strlen when not needed.
9436
573f4b54
PE
9437 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9438 (XD_DEBUG_MESSAGE): Don't waste a byte.
9439
989f33ba
PE
9440 * callproc.c (getenv_internal_1, getenv_internal)
9441 (Fgetenv_internal):
965d34eb
PE
9442 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9443
e4d29b33
PE
9444 * lread.c (invalid_syntax): Omit length argument.
9445 All uses changed. This doesn't fix a bug, but it simplifies the
9446 code away from its former Hollerith-constant appearance, and it's
9447 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9448 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9449
eb49b136
PE
9450 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9451 This didn't break anything, but it didn't help either.
9452 It's confusing to put a bogus integer in a place where the actual
9453 value does not matter.
9f62aeb1 9454 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9455 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9456
15375a22
PE
9457 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9458 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9459 implementation.
b61cc01c
PE
9460 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9461 We prefer signed types, and the value cannot exceed the EMACS_INT
9462 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9463 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9464 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9465 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9466
53b2623d
PE
9467 * indent.c (sane_tab_width): New function.
9468 (current_column, scan_for_column, Findent_to, position_indentation)
9469 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9470 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9471
51cab52b 9472 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9473
f2ed8a70
PE
9474 * lisp.h (lint_assume): New macro.
9475 * composite.c (composition_gstring_put_cache):
9476 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9477
abe80cc6
PE
9478 * editfns.c, insdel.c:
9479 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9480
b02c740e
PE
9481 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9482
ebc96716
PE
9483 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9484
b4e50fa0 9485 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9486 Use much-faster test for byte-length change.
311d5d7c 9487 Don't assume string byte-length fits in 'int'.
a4cf38e4 9488 Check that character arg fits in 'int'.
85461888 9489 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9490
c0c1ee9f
PE
9491 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9492
a498d7f4
PE
9493 * fns.c (concat): Catch string overflow earlier.
9494 Do not rely on integer wraparound.
9495
51cab52b
PE
9496 * dispextern.h (struct it.overlay_strings_charpos)
9497 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9498 * xdisp.c (forward_to_next_line_start)
9499 (back_to_previous_visible_line_start)
9500 (reseat_at_next_visible_line_start, next_element_from_buffer):
9501 Don't arbitrarily truncate the value of 'selective' to int.
9502
76031fad
PE
9503 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9504
5eb55db9
PE
9505 * composite.c: Don't truncate sizes to 'int'.
9506 (composition_gstring_p, composition_reseat_it)
9507 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9508 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9509 not EMACS_UINT, for indexes.
5eb55db9 9510
0703a717
PE
9511 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9512
d6202519
PE
9513 * buffer.c: Include <verify.h>.
9514 (struct sortvec.priority, struct sortstr.priority):
8961a454 9515 Now EMACS_INT, not int.
c20998a7 9516 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9517 (struct sortstr.size, record_overlay_string)
9518 (struct sortstrlist.size, struct sortlist.used):
9519 Don't truncate size to int.
9520 (record_overlay_string): Check for size-calculation overflow.
d6202519 9521 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9522
d5a19415
JM
95232011-06-22 Jim Meyering <meyering@redhat.com>
9524
029529ac 9525 Don't leak an XBM-image-sized buffer
d5a19415
JM
9526 * image.c (xbm_load): Free the image buffer after using it.
9527
a9041e6c
PE
95282011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9529
9530 Port to Sun C.
9531 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9532 that Sun C diagnosed.
9533 * fns.c (secure_hash): Fix pointer signedness issue.
9534 * intervals.c (static_offset_intervals): New function.
9535 (offset_intervals): Use it.
9536
7f3f739f
LL
95372011-06-21 Leo Liu <sdl.web@gmail.com>
9538
9539 * deps.mk (fns.o):
9540 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9541 sha512.h.
9542
9543 * fns.c (secure_hash): Rename from crypto_hash_function and change
9544 the first arg to accept symbols.
5b66d427 9545 (Fsecure_hash): New primitive.
7f3f739f
LL
9546 (syms_of_fns): New symbols.
9547
76147d94
DD
95482011-06-20 Deniz Dogan <deniz@dogan.se>
9549
9550 * process.c (Fset_process_buffer): Clarify return value in
9551 docstring.
9552
7d7d0045
CY
95532011-06-18 Chong Yidong <cyd@stupidchicken.com>
9554
9555 * dispnew.c (add_window_display_history): Use BVAR.
9556
9557 * xdisp.c (debug_method_add): Use BVAR.
9558 (check_window_end, dump_glyph_matrix, dump_glyph)
9559 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9560
9561 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9562 Likewise.
9563
9564 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9565 check till after the cache is created in init_frame_faces.
9566
ff2bc410
SM
95672011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9568
9569 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9570
28177add
PE
95712011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9572
dd3482fe
PE
9573 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9574 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9575 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9576
393d71f3 9577 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9578 * fileio.c (Finsert_file_contents):
9579 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9580 Remove the old (too-loose) buffer overflow checks.
9581 They weren't needed, since make_gap checks for buffer overflow.
9582 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9583 The old code merely checked for Emacs fixnum overflow, and relied
9584 on undefined (wraparound) behavior. The new code avoids undefined
9585 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9586
2e6813b0 9587 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9588 Tune. Don't use wider integers than needed. Don't use alloca.
9589 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9590
599a9e4f
PE
9591 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9592
99561444
PE
9593 * insdel.c, lisp.h (buffer_overflow): New function.
9594 (insert_from_buffer_1, replace_range, replace_range_2):
9595 * insdel.c (make_gap_larger):
9596 * editfns.c (Finsert_char):
9597 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9598
28177add
PE
9599 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9600
e69dafad
PE
96012011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9602
4baa020d 9603 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9604
b1c46f02
PE
9605 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9606 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9607
e69dafad
PE
9608 * fileio.c: Don't assume EMACS_INT fits in off_t.
9609 (emacs_lseek): New static function.
9610 (Finsert_file_contents, Fwrite_region): Use it.
9611 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9612
566684ea
PE
9613 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9614
e6966cd6
PE
9615 * fns.c: Don't overflow int when computing a list length.
9616 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9617 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9618 truncation on 64-bit hosts. Check for QUIT every
9619 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9620 faster and is responsive enough.
9621 (Flength): Report an error instead of overflowing an integer.
9622 (Fsafe_length): Return a float if the value is not representable
9623 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9624 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9625 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9626
dd0b0efb
PE
9627 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9628 (header_size, word_size): New constants.
9629 (allocate_vectorlike): Don't check size overflow here.
9630 (allocate_vector): Check it here instead, since this is the only
9631 caller of allocate_vectorlike that could cause overflow.
9632 Check that the new vector's length is representable as a fixnum.
9633
86fe5cfe
PE
9634 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9635 The previous code was bogus. For example, next_almost_prime (32)
9636 returned 39, which is undesirable as it is a multiple of 3; and
9637 next_almost_prime (24) returned 25, which is a multiple of 5 so
9638 why was the code bothering to check for multiples of 7?
9639
80e88859
PE
9640 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9641
4a2f0ad6
PE
9642 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9643
f66c7cf8
PE
9644 Variadic C functions now count arguments with ptrdiff_t.
9645 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9646 Back then I didn't know that the Emacs coding style prefers signed int.
9647 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9648 were being counted with int, which may truncate counts on 64-bit
9649 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9650 * lisp.h (struct Lisp_Subr.function.aMANY)
9651 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9652 Arg counts are now ptrdiff_t, not size_t.
9653 All variadic functions and their callers changed accordingly.
9654 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9655 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9656 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9657 * callint.c (Fcall_interactively): Check arg count for overflow,
9658 to avoid potential buffer overrun. Use signed char, not 'int',
9659 for 'varies' array, so that we needn't bother to check its size
9660 calculation for overflow.
9661 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9662 * eval.c (apply_lambda):
9663 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9664 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9665 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9666
a1759b76
PE
9667 * callint.c (Fcall_interactively): Don't use index var as event count.
9668
d96be9fc
PE
9669 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9670 * mem-limits.h (SIZE): Remove; no longer used.
9671
a690a978 9672 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9673
578c21e6
PE
9674 Remove unnecessary casts.
9675 * xterm.c (x_term_init):
9676 * xfns.c (x_set_border_pixel):
9677 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9678 These aren't needed now that we assume ANSI C.
9679
96f53c6c
PE
9680 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9681 It's more likely to cause problems (due to unsigned overflow)
9682 than to cure them.
9683
83c77d31
PE
9684 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9685
ee2079f1
PE
9686 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9687
6da65536
PE
9688 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9689
7147c4a4
PE
9690 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9691
193e32d9
PE
9692 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9693
e5533da6
PE
9694 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9695
9910e595
PE
9696 GLYPH_CODE_FACE returns EMACS_INT, not int.
9697 * dispextern.h (merge_faces):
9698 * xfaces.c (merge_faces):
01103c44
PE
9699 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9700 Don't assume EMACS_INT fits in int.
9910e595 9701
2638320e
PE
9702 * character.h (CHAR_VALID_P): Remove unused parameter.
9703 * fontset.c, lisp.h, xdisp.c: All uses changed.
9704
045eb8d9
PE
9705 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9706
c1f134b5
PE
9707 * fns.c (concat): Minor tuning based on overflow analysis.
9708 This doesn't fix any bugs. Use int to hold character, instead
9709 of constantly refetching from Emacs object. Use XFASTINT, not
9710 XINT, for value known to be a character. Don't bother comparing
9711 a single byte to 0400, as it's always less.
9712
395fcb93 9713 * floatfns.c (Fexpt):
327eeec8
PE
9714 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9715
abbd3d23
PE
9716 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9717 for characters.
9718
684a03ef
PE
9719 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9720
0fed43f3
PE
9721 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9722 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9723 incorrectly succeed when S was a string, because 4294967386 was
9724 truncated before it was used.
9725
8fd02eb7
PE
9726 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9727 Otherwise, an out-of-range integer could cause undefined behavior
9728 on a 64-bit host.
9729
f8c86b69
PE
9730 * composite.c: Use int, not EMACS_INT, for characters.
9731 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9732 EMACS_INT, for values that are known to be in character range.
9733 This doesn't fix any bugs but is the usual style inside Emacs and
9734 may generate better code on 32-bit machines.
9735
34206dd2
PE
9736 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9737 This is for reasons similar to the recent CHAR_STRING fix.
9738 * charset.c (Fencode_char): Check that character arg is actually
9739 a character. Pass an int to ENCODE_CHAR.
9740 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9741 wider than 'int', as a compile-time check to prevent future regressions
9742 in this area.
9743
c5958d4c 9744 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9745
9746 Make sure a 64-bit char is never passed to CHAR_STRING.
9747 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9748 by silently ignoring the top 32 bits, allowing some values
9749 that were far too large to be valid characters.
9750 * character.h: Include <verify.h>.
9751 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9752 arguments are no wider than unsigned, as a compile-time check
9753 to prevent future regressions in this area.
9754 * data.c (Faset):
01103c44 9755 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9756 (Fsubst_char_in_region):
9757 * fns.c (concat):
9758 * xdisp.c (decode_mode_spec_coding):
9759 Adjust to CHAR_STRING's new requirement.
9760 * editfns.c (Finsert_char, Fsubst_char_in_region):
9761 * fns.c (concat): Check that character args are actually
9762 characters. Without this test, these functions did the wrong
9763 thing with wildly out-of-range values on 64-bit hosts.
9764
d37ca623
PE
9765 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9766 These casts should not be needed on 32-bit hosts, either.
9767 * keyboard.c (read_char):
9768 * lread.c (Fload): Remove casts to unsigned.
9769
ea204efb
PE
9770 * lisp.h (UNSIGNED_CMP): New macro.
9771 This fixes comparison bugs on 64-bit hosts.
9772 (ASCII_CHAR_P): Use it.
9773 * casefiddle.c (casify_object):
01103c44 9774 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9775 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9776 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9777 * dispextern.h (FACE_FROM_ID):
9778 * keyboard.c (read_char): Use UNSIGNED_CMP.
9779
41cb286c
PE
9780 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9781 not to EMACS_INT, to avoid GCC warning.
9782
4a1b9832
PE
9783 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9784
55daad71
PE
9785 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9786 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9787 isn't needed on 32-bit machines.
8f95c75c 9788
01103c44
PE
9789 * buffer.c (Fgenerate_new_buffer_name):
9790 Use EMACS_INT for count, not int.
0ceccced 9791 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9792
9793 * data.c (Qcompiled_function): Now static.
9794
c6f072e7
PE
9795 * window.c (window_body_lines): Now static.
9796
20ce5912
PE
9797 * image.c (gif_load): Rename local to avoid shadowing.
9798
9c4c5f81
PE
9799 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9800 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9801 * alloc.c (make_save_value): Integer argument is now of type
9802 ptrdiff_t, not int.
9803 (mark_object): Use ptrdiff_t, not int.
9804 * lisp.h (pD): New macro.
9805 * print.c (print_object): Use it.
9806
c0c5c8ae
PE
9807 * alloc.c: Use EMACS_INT, not int, to count objects.
9808 (total_conses, total_markers, total_symbols, total_vector_size)
9809 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9810 (total_free_floats, total_floats, total_free_intervals)
9811 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9812 Now EMACS_INT, not int. All uses changed.
9813 (Fgarbage_collect): Compute overall total using a double, so that
9814 integer overflow is less likely to be a problem. Check for overflow
9815 when converting back to an integer.
5a25e253
PE
9816 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9817 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9818 These were 'int' variables that could overflow on 64-bit hosts;
9819 they were never used, so remove them instead of repairing them.
211a0b2a 9820 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9821 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9822 Previously, this ceilinged at INT_MAX, but that doesn't work on
9823 64-bit machines.
e46bb31a 9824 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9825
c78baabf 9826 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9827 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9828 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9829 when a (possibly-narrower) signed value would do just as well.
9830 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9831
c9d624c6
PE
9832 * alloc.c: Catch some string size overflows that we were missing.
9833 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9834 for convenience in STRING_BYTES_MAX.
9835 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9836 The definition here is exact; the one in lisp.h was approximate.
9837 (allocate_string_data): Check for string overflow. This catches
9838 some instances we weren't catching before. Also, it catches
9839 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9840 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9841 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9842
c9d624c6
PE
9843 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9844 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9845 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9846
353032ce
PE
9847 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9848
2bccce07
PE
9849 * alloc.c (Fmake_string): Check for out-of-range init.
9850
0ac30604
SM
98512011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9852
9853 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9854
c195f2de
JD
98552011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9856
9857 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9858 xg_get_default_scrollbar_width.
9859
9860 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9861 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9862 (style_changed_cb): Call update_theme_scrollbar_width and call
9863 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9864 all frames (Bug#8505).
9865 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9866 Call gtk_window_set_resizable if HAVE_GTK3.
9867 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9868 and height if HAVE_GTK3 (Bug#8505).
9869 (scroll_bar_width_for_theme): New variable.
9870 (update_theme_scrollbar_width): New function.
9871 (xg_get_default_scrollbar_width): Move code to
9872 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9873 (xg_initialize): Call update_theme_scrollbar_width.
9874
9875 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9876
9877 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9878
e10ac9f1
MR
98792011-06-12 Martin Rudalics <rudalics@gmx.at>
9880
9881 * frame.c (make_frame): Call other_buffer_safely instead of
9882 other_buffer.
9883
9884 * window.c (temp_output_buffer_show): Call display_buffer with
9885 second argument Vtemp_buffer_show_specifiers and reset latter
9886 immediately after the call.
9887 (Vtemp_buffer_show_specifiers): New variable.
9888 (auto_window_vscroll_p, next_screen_context_lines)
9889 (Vscroll_preserve_screen_position): Remove leading asterisks from
9890 doc-strings.
9891
2d3c217e 98922011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9893
7b7f97e8 9894 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9895 * buffer.c (Qclone_number): Remove for now, as it's unused.
9896 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9897 (record_buffer): Remove unused local.
9898 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9899 (set_frame_buffer_list): Remove; unused.
9900 * frame.h (other_visible_frames): Remove decl.
9901 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9902 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9903 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9904 if HAVE_GPM.
9905 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9906 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9907 Define only if HAVE_GPM.
9908 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9909 (update_hints_inhibit): Remove; never set. All uses removed.
9910 * widgetprv.h (emacsFrameClassRec): Remove decl.
9911 * window.c (delete_deletable_window): Now returns void, since it
9912 wasn't returning anything.
9913 (compare_window_configurations): Remove unused locals.
9914 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9915 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9916 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9917 the same widths as pointers. This follows up on the 2011-05-06 patch.
9918 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9919 * xterm.h: Likewise.
9920 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9921
1384b89e
JB
99222011-06-12 Juanma Barranquero <lekktu@gmail.com>
9923
9924 * makefile.w32-in: Update dependencies.
9925 (LISP_H): Add lib/intprops.h.
9926
1100a63c
CY
99272011-06-11 Chong Yidong <cyd@stupidchicken.com>
9928
9929 * image.c (gif_load): Add animation frame delay to the metadata.
9930 (syms_of_image): Use DEFSYM. New symbol `delay'.
9931
6198ccd0
MR
99322011-06-11 Martin Rudalics <rudalics@gmx.at>
9933
9934 * window.c (delete_deletable_window): Re-add.
9935 (Fset_window_configuration): Rewrite to handle dead buffers and
9936 consequently deletable windows.
9937 (window_tree, Fwindow_tree): Remove. Supply functionality in
9938 window.el.
9939 (compare_window_configurations): Simplify code.
9940
b6e3633c
AS
99412011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9942
1ab0dee5
AS
9943 * image.c (imagemagick_load_image): Fix type mismatch.
9944 (Fimagemagick_types): Likewise.
9945
b6e3633c
AS
9946 * window.h (replace_buffer_in_windows): Declare.
9947
9397e56f
MR
99482011-06-11 Martin Rudalics <rudalics@gmx.at>
9949
9950 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9951 Qclone_number. Remove external declaration of Qdelete_window.
9952 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9953 code.
640c8776
SM
9954 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9955 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9956 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9957 buffer list implementation.
9958 (other_buffer_safely): New function.
9959 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9960 calls to replace_buffer_in_windows and
9961 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9962 if allowed.
9963 (record_buffer): Inhibit quitting and rewrite using quittable
9964 functions. Run Qbuffer_list_update_hook if allowed.
9965 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9966 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9967 Move switch-to-buffer to window.el.
9397e56f
MR
9968 (bury-buffer): Move to window.el.
9969 (Vbuffer_list_update_hook): New variable.
9970
9971 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9972 section.
9973
9974 * window.h (resize_frame_windows): Move up in code.
9975 (Fwindow_frame): Remove EXFUN.
9976 (replace_buffer_in_all_windows): Remove prototype.
9977 (replace_buffer_in_windows_safely): Add prototype.
9978
9979 * window.c: Declare Qdelete_window static again. Move down
9980 declaration of select_count.
9981 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9982 (Fother_window): Move to window.el.
9983 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9984 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9985 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9986 window.el.
9987 (replace_buffer_in_windows): Implement by calling
9988 Qreplace_buffer_in_windows.
9989 (replace_buffer_in_all_windows): Remove with some functionality
9990 moved into replace_buffer_in_windows_safely.
9991 (replace_buffer_in_windows_safely): New function.
9992 (select_window_norecord, select_frame_norecord): Move in front
9993 of run_window_configuration_change_hook. Remove now obsolete
9994 declarations.
640c8776
SM
9995 (Fset_window_buffer): Rewrite doc-string.
9996 Call Qrecord_window_buffer.
9397e56f
MR
9997 (keys_of_window): Move binding for other-window to window.el.
9998
b50691aa
CY
99992011-06-11 Chong Yidong <cyd@stupidchicken.com>
10000
10001 * dispextern.h (struct image): Replace data member, whose int_val
10002 and ptr_val fields were not used by anything, with a single
10003 lisp_val object.
10004
10005 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10006 (gif_clear_image, gif_load, imagemagick_load_image)
10007 (gs_clear_image, gs_load): Callers changed.
10008
3f754b86
PE
100092011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10010
cca69397
PE
10011 * buffer.h: Include <time.h>, for time_t.
10012 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10013
109e28d0
PE
10014 Fix minor problems found by static checking.
10015
60737f02
PE
10016 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10017
4b66faf3
PE
10018 Make identifiers static if they are not used in other modules.
10019 * data.c (Qcompiled_function, Qframe, Qvector):
10020 * image.c (QimageMagick, Qsvg):
10021 * minibuf.c (Qmetadata):
10022 * window.c (resize_window_check, resize_root_window): Now static.
10023 * window.h (resize_window_check, resize_root_window): Remove decls.
10024
109e28d0
PE
10025 * window.c (window_deletion_count, delete_deletable_window):
10026 Remove; unused.
46a4ce9e
PE
10027 (window_body_lines): Now static.
10028 (Fdelete_other_windows_internal): Mark vars as initialized.
10029 Make sure 'resize_failed' is initialized.
10030 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10031 (resize_window_apply): Remove unused local.
10032 * window.h (delete_deletable_window): Remove decl.
10033
109e28d0 10034 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10035 (imagemagick_load_image): Fix pointer signedness problem by changing
10036 last arg from unsigned char * to char *. All uses changed.
10037 Also, fix a local for similar reasons.
10038 Remove unused locals. Remove locals to avoid shadowing.
10039 (fn_rsvg_handle_free): Remove; unused.
10040 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10041 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10042
3f754b86
PE
10043 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10044
2547adb1
CY
100452011-06-10 Chong Yidong <cyd@stupidchicken.com>
10046
10047 * image.c (gif_load): Fix omitted cast error introduced by
10048 2011-06-06 change.
10049
2c8e37d4
MR
100502011-06-10 Martin Rudalics <rudalics@gmx.at>
10051
10052 * window.h (resize_proportionally, orig_total_lines)
10053 (orig_top_line): Remove from window structure.
10054 (set_window_height, set_window_width, change_window_heights)
10055 (Fdelete_window): Remove prototypes.
10056 (resize_frame_windows): Remove duplicate declaration.
10057
440a42e3
EZ
100582011-06-10 Eli Zaretskii <eliz@gnu.org>
10059
10060 * window.h (resize_frame_windows, resize_window_check)
10061 (delete_deletable_window, resize_root_window)
10062 (resize_frame_windows): Declare prototypes.
10063
10064 * window.c (resize_window_apply): Make definition be "static" to
10065 match the prototype.
10066
562dd5e9
MR
100672011-06-10 Martin Rudalics <rudalics@gmx.at>
10068
10069 * window.c: Remove declarations of Qwindow_size_fixed,
10070 window_min_size_1, window_min_size_2, window_min_size,
10071 size_window, window_fixed_size_p, enlarge_window, delete_window.
10072 Remove static from declaration of Qdelete_window, it's
10073 temporarily needed by Fbury_buffer.
10074 (replace_window): Don't assign orig_top_line and
10075 orig_total_lines.
10076 (Fdelete_window, delete_window): Remove. Window deletion is
10077 handled by window.el.
640c8776
SM
10078 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10079 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10080 (Fdelete_other_windows): Remove. Deleting other windows is
10081 handled by window.el.
10082 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10083 handled in window.el.
10084 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10085 Window minimum sizes are handled in window.el.
10086 (shrink_windows, size_window, set_window_height)
10087 (set_window_width, change_window_heights, window_height)
10088 (window_width, CURBEG, CURSIZE, enlarge_window)
10089 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10090 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10091 handled in window.el.
10092 (make_dummy_parent): Rename to make_parent_window and give it a
10093 second argument horflag.
10094 (make_window): Don't set resize_proportionally any more.
10095 (Fsplit_window): Remove. Windows are split in window.el.
10096 (save_restore_action, save_restore_orig_size)
10097 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10098 Resize mini windows in window.el.
10099 (grow_mini_window, shrink_mini_window): Implement by calling
10100 Qresize_root_window_vertically, resize_window_check and
10101 resize_window_apply.
640c8776
SM
10102 (saved_window, Fset_window_configuration, save_window_save):
10103 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10104 resize_proportionally.
10105 (window_min_height, window_min_width): Move to window.el.
10106 (keys_of_window): Move bindings for delete-other-windows,
10107 split-window, delete-window and enlarge-window to window.el.
10108
10109 * buffer.c: Temporarily extern Qdelete_window.
10110 (Fbury_buffer): Temporarily call Qdelete_window instead of
10111 Fdelete_window (Fbury_buffer will move to window.el soon).
10112
10113 * frame.c (set_menu_bar_lines_1): Remove code handling
10114 orig_top_line and orig_total_lines.
10115
10116 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10117 set_window_height but set heights directly.
10118 (change_frame_size_1): Use resize_frame_windows.
10119
10120 * xdisp.c (init_xdisp): Don't use set_window_height but set
10121 heights directly.
10122
640c8776
SM
10123 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10124 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10125 run_window_configuration_change_hook.
10126
10127 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10128 instead of change_window_heights and run
10129 run_window_configuration_change_hook.
10130
1a13852e
MR
101312011-06-09 Martin Rudalics <rudalics@gmx.at>
10132
10133 * window.c (replace_window): Rename second argument REPLACEMENT to
10134 NEW. New third argument SETFLAG. Rewrite.
10135 (delete_window, make_dummy_parent): Call replace_window with
10136 third argument 1.
10137 (window_list_1): Move down in code.
10138 (run_window_configuration_change_hook): Move set_buffer part
10139 before select_frame_norecord part in order to unwind correctly.
10140 Rename count1 to count.
10141 (recombine_windows, delete_deletable_window, resize_root_window)
10142 (Fdelete_other_windows_internal)
10143 (Frun_window_configuration_change_hook, make_parent_window)
10144 (resize_window_check, resize_window_apply, Fresize_window_apply)
10145 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10146 (Fdelete_window_internal, Fresize_mini_window_internal):
10147 New functions.
1a13852e
MR
10148 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10149
f3d1777e
MR
101502011-06-08 Martin Rudalics <rudalics@gmx.at>
10151
496e208e
MR
10152 * window.h (window): Add some new members to window structure -
10153 normal_lines, normal_cols, new_total, new_normal, clone_number,
10154 splits, nest, prev_buffers, next_buffers.
10155 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10156 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10157
f3d1777e
MR
10158 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10159 Remove.
496e208e
MR
10160 (make_dummy_parent): Set new members of windows structure.
10161 (make_window): Move down in code. Handle new members of window
10162 structure.
10163 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10164 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10165 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10166 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10167 (Fset_window_next_buffers, Fset_window_clone_number):
10168 New functions.
496e208e
MR
10169 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10170 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10171 Doc-string fixes.
10172 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10173 Argument WINDOW can be now internal window too.
10174 (Fwindow_use_time): Move up in code.
10175 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10176 Rewrite doc-string.
10177 (Fset_window_configuration, saved_window)
10178 (Fcurrent_window_configuration, save_window_save): Handle new
10179 members of window structure.
b9e809c2
MR
10180 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10181 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10182 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10183 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10184 Qget_mru_window, Qresize_root_window,
10185 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10186 Qauto_buffer_name; staticpro them.
f3d1777e 10187
abde8f8c
MR
101882011-06-07 Martin Rudalics <rudalics@gmx.at>
10189
10190 * window.c (Fwindow_total_size, Fwindow_left_column)
10191 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10192 (Fwindow_list_1): New functions.
10193 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10194 (Fwindow_width, Fscroll_left, Fscroll_right):
10195 Use window_body_cols instead of window_box_text_cols.
10196 (delete_window, Fset_window_configuration):
10197 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10198 (delete_all_subwindows): Take a window as argument and not a
10199 structure. Rewrite.
190b47e6
MR
10200 (window_loop): Remove handling of GET_LRU_WINDOW and
10201 GET_LARGEST_WINDOW.
10202 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10203
10204 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10205 window_box_text_cols. delete_all_subwindows now takes a
10206 Lisp_Object as argument.
abde8f8c 10207
640c8776
SM
10208 * indent.c (compute_motion, Fcompute_motion):
10209 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10210
fa8a67e6
MR
10211 * frame.c (delete_frame): Call delete_all_subwindows with root
10212 window as argument.
10213
a54e3482
DC
102142011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10215
10216 * fns.c (Fputhash): Document return value.
10217
60002bf5
CY
102182011-06-06 Chong Yidong <cyd@stupidchicken.com>
10219
10220 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10221
0c671da6 102222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10223
b862a52a 10224 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10225
be44ca6c
PE
10226 Check for overflow when converting integer to cons and back.
10227 * charset.c (Fdefine_charset_internal, Fdecode_char):
10228 Use cons_to_unsigned to catch overflow.
10229 (Fencode_char): Use INTEGER_TO_CONS.
10230 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10231 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10232 * data.c (long_to_cons, cons_to_long): Remove.
10233 (cons_to_unsigned, cons_to_signed): New functions.
10234 These signal an error for invalid or out-of-range values.
10235 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10236 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10237 * font.c (Ffont_variation_glyphs):
10238 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10239 * lisp.h: Include <intprops.h>.
10240 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10241 (cons_to_signed, cons_to_unsigned): New decls.
10242 (long_to_cons, cons_to_long): Remove decls.
10243 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10244 (Fprimitive_undo): Use CONS_TO_INTEGER.
10245 * xfns.c (Fx_window_property): Likewise.
10246 * xselect.c: Include <limits.h>.
10247 (x_own_selection, selection_data_to_lisp_data):
10248 Use INTEGER_TO_CONS.
10249 (x_handle_selection_request, x_handle_selection_clear)
10250 (x_get_foreign_selection, Fx_disown_selection_internal)
10251 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10252 (lisp_data_to_selection_data): Use cons_to_unsigned.
10253 (x_fill_property_data): Use cons_to_signed.
10254 Report values out of range.
10255
d1f3d2af
PE
10256 Check for buffer and string overflow more precisely.
10257 * buffer.h (BUF_BYTES_MAX): New macro.
10258 * lisp.h (STRING_BYTES_MAX): New macro.
10259 * alloc.c (Fmake_string):
10260 * character.c (string_escape_byte8):
10261 * coding.c (coding_alloc_by_realloc):
10262 * doprnt.c (doprnt):
10263 * editfns.c (Fformat):
10264 * eval.c (verror):
10265 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10266 since they may not be the same number.
10267 * editfns.c (Finsert_char):
10268 * fileio.c (Finsert_file_contents):
10269 Likewise for BUF_BYTES_MAX.
10270
dd52fcea
PE
10271 * image.c: Use ptrdiff_t, not int, for sizes.
10272 (slurp_file): Switch from int to ptrdiff_t.
10273 All uses changed.
10274 (slurp_file): Check that file size fits in both size_t (for
10275 malloc) and ptrdiff_t (for sanity and safety).
10276
7f9bbdbb
PE
10277 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10278 if b->modtime has its maximal value.
10279
dfe18f82
PE
10280 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10281
84acfcf0
PE
10282 Don't assume time_t can fit into int.
10283 * buffer.h (struct buffer.modtime): Now time_t, not int.
10284 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10285 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10286
ccd9a01a
PE
10287 Minor fixes for signed vs unsigned integers.
10288 * character.h (MAYBE_UNIFY_CHAR):
10289 * charset.c (maybe_unify_char):
10290 * keyboard.c (read_char, reorder_modifiers):
10291 XINT -> XFASTINT, since the integer must be nonnegative.
10292 * ftfont.c (ftfont_spec_pattern):
10293 * keymap.c (access_keymap, silly_event_symbol_error):
10294 XUINT -> XFASTINT, since the integer must be nonnegative.
10295 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10296 since it makes no difference and we prefer signed.
10297 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10298 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10299 nonnegative.
10300
d6d100dd
SM
103012011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10302
10303 * window.h (Fwindow_frame): Declare.
10304
2b6148e4
PE
103052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10306
10307 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10308 (SPARE_MEMORY): Always define.
10309 (LARGE_REQUEST): Remove.
10310 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10311
f230ecc9
MR
103122011-06-06 Martin Rudalics <rudalics@gmx.at>
10313
727e958e
MR
10314 * lisp.h: Move EXFUNS for Fframe_root_window,
10315 Fframe_first_window and Fset_frame_selected_window to window.h.
10316
10317 * window.h: Move EXFUNS for Fframe_root_window,
10318 Fframe_first_window and Fset_frame_selected_window here from
10319 lisp.h.
10320
10321 * frame.c (Fwindow_frame, Fframe_first_window)
10322 (Fframe_root_window, Fframe_selected_window)
10323 (Fset_frame_selected_window): Move to window.c.
10324 (Factive_minibuffer_window): Move to minibuf.c.
10325 (Fother_visible_frames_p): New function.
10326
10327 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10328
f230ecc9
MR
10329 * window.c (decode_window, decode_any_window): Move up in code.
10330 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10331 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10332 (Fwindow_buffer): Move up and rewrite doc-string.
10333 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10334 (Fwindow_prev): New functions.
727e958e
MR
10335 (Fwindow_frame): Move here from frame.c. Accept any window as
10336 argument.
10337 (Fframe_root_window, Fframe_first_window)
10338 (Fframe_selected_window): Move here from frame.c. Accept frame
10339 or arbitrary window as argument. Update doc-strings.
10340 (Fminibuffer_window): Move up in code.
10341 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10342 (Fset_frame_selected_window): Move here from frame.c.
10343 Marginal rewrite.
727e958e
MR
10344 (Fselected_window, select_window, Fselect_window): Move up in
10345 code. Minor doc-string fixes.
f230ecc9 10346
4d09bcf6
PE
103472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10348
10349 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10350 Do not assume that spare memory exists; that assumption is valid
10351 only if SYSTEM_MALLOC.
10352 (LARGE_REQUEST): New macro, so that the issue of large requests
10353 is separated from the issue of spare memory.
10354
810928a2
AS
103552011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10356
172418ad
AS
10357 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10358 format. (Bug#8806)
10359
43f862f7
AS
10360 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10361
810928a2
AS
10362 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10363 before statements.
10364
a059fe24
JD
103652011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10366
10367 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10368
10369 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10370
10371 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10372 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10373
989bf368
JB
103742011-06-05 Juanma Barranquero <lekktu@gmail.com>
10375
10376 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10377
4b80f674
CY
103782011-06-04 Chong Yidong <cyd@stupidchicken.com>
10379
10380 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10381 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10382 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10383 New error handlers.
4b80f674
CY
10384 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10385 Obey Vx_select_enable_clipboard_manager. Catch errors in
10386 x_clipboard_manager_save (Bug#8779).
10387 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10388 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10389
99a33b77 103902011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10391
10392 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10393
99a33b77 103942011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10395
10396 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10397 in the current matrix if keep_current_p is non-zero.
10398
8264569d
EZ
103992011-06-04 Eli Zaretskii <eliz@gnu.org>
10400
10401 * bidi.c (bidi_level_of_next_char): Fix last change.
10402
57f97249
EZ
104032011-06-03 Eli Zaretskii <eliz@gnu.org>
10404
fec2107c 10405 Support bidi reordering of text covered by display properties.
57f97249 10406
fec2107c
EZ
10407 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10408 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10409 (bidi_cache_search, bidi_cache_iterator_state)
10410 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10411 (bidi_level_of_next_char, bidi_move_to_visually_next):
10412 Support character positions inside a run of characters covered by a
fec2107c
EZ
10413 display string.
10414 (bidi_paragraph_init, bidi_resolve_explicit_1)
10415 (bidi_level_of_next_char): Call bidi_fetch_char and
10416 bidi_fetch_char_advance instead of FETCH_CHAR and
10417 FETCH_CHAR_ADVANCE.
10418 (bidi_init_it): Initialize new members.
10419 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10420 definitions.
10421 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10422 instead of using explicit *_CHAR codes.
d6d100dd
SM
10423 (bidi_resolve_explicit, bidi_resolve_weak):
10424 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10425 bidirectional text is supported only in multibyte buffers.
10426 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10427 it to initialize the frame_window_p member of struct bidi_it.
10428 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10429 (bidi_resolve_explicit, bidi_resolve_weak)
10430 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10431 bidi_it->nchars is non-positive.
10432 (bidi_level_of_next_char): Don't try to lookup the cache for the
10433 next/previous character if nothing is cached there yet, or if we
10434 were just reseat()'ed to a new position.
c40e2fb2 10435
0e14fe90
EZ
10436 * xdisp.c (set_cursor_from_row): Set start and stop points
10437 according to the row's direction when priming the loop that looks
10438 for the glyph on which to display cursor.
10439 (single_display_spec_intangible_p): Function deleted.
10440 (display_prop_intangible_p): Reimplement to call
10441 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10442 Accept 3 additional arguments needed by handle_display_spec.
10443 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10444 values: lists, `(when COND...)' forms, etc.
10445 (single_display_spec_string_p): Support property values that are
10446 lists with the argument STRING its top-level element.
10447 (display_prop_string_p): Fix the condition for processing a
10448 property that is a list to be consistent with handle_display_spec.
fec2107c 10449 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10450 last portion of handle_display_prop.
10451 (compute_display_string_pos): Accept additional argument
10452 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10453 value of a `display' property is a "replacing spec".
10454 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10455 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10456 the display property, but just return a value indicating whether
10457 the display property will replace the characters it covers.
10458 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10459 frame_window_p members of struct bidi_it.
d6d100dd
SM
10460 (compute_display_string_pos, compute_display_string_end):
10461 New functions.
fec2107c
EZ
10462 (push_it): Accept second argument POSITION, where pop_it should
10463 jump to continue iteration.
10464 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10465
fec2107c
EZ
10466 * keyboard.c (adjust_point_for_property): Adjust the call to
10467 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10468
10469 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10470 (bidi_init_it): Update prototypes.
10471 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10472 (compute_display_string_pos, compute_display_string_end):
10473 Declare prototypes.
fec2107c
EZ
10474 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10475 EMACS_INT.
fc6f18ce 10476
40087514 104772011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10478
57f53182
PE
10479 Malloc failure behavior now depends on size of allocation.
10480 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10481 * lisp.h: Change signatures accordingly.
10482 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10483 All callers changed. (Bug#8762)
10484
10485 * gnutls.c: Use Emacs's memory allocators.
10486 Without this change, the gnutls library would invoke malloc etc.
10487 directly, which causes problems on non-SYNC_INPUT hosts, and which
10488 runs afoul of improving memory_full behavior. (Bug#8761)
10489 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10490 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10491 xfree instead of the default malloc, realloc, free.
10492 (Fgnutls_boot): No need to check for memory allocation failure,
10493 since xmalloc does that for us.
10494
ac32cd99 10495 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10496 * category.c (hash_get_category_set):
10497 * ccl.c (ccl_driver):
10498 * charset.c (Fdefine_charset_internal):
10499 * charset.h (struct charset.hash_index):
10500 * composite.c (get_composition_id, gstring_lookup_cache)
10501 (composition_gstring_put_cache):
10502 * composite.h (struct composition.hash_index):
10503 * dispextern.h (struct image.hash):
10504 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10505 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10506 (hashfn_equal, hashfn_user_defined, make_hash_table)
10507 (maybe_resize_hash_table, hash_lookup, hash_put)
10508 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10509 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10510 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10511 * image.c (make_image, search_image_cache, lookup_image)
10512 (xpm_put_color_table_h):
10513 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10514 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10515 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10516 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10517 * alloc.c (allocate_vectorlike):
10518 Check for overflow in vector size calculations.
10519 * ccl.c (ccl_driver):
10520 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10521 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10522 need to be updated by these changes.
40087514
PE
10523 * fns.c (make_hash_table, maybe_resize_hash_table):
10524 Check for integer overflow with large hash tables.
0de4bb68
PE
10525 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10526 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10527 (SXHASH_REDUCE): New macro.
10528 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10529 Use it instead of discarding useful hash info with large hash values.
10530 (sxhash_float): New function.
10531 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10532 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10533 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10534 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10535 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10536 Adjust signatures to match updated version of code.
10537 (consing_since_gc): Now EMACS_INT, since a single hash table can
10538 use more than INT_MAX bytes.
10539
698d32e2
DN
105402011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10541
10542 Make it possible to build with GCC-4.6+ -O2 -flto.
10543
10544 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10545
fd6fa53f
SM
105462011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10547
10548 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10549 Call minibuffer-inactive-mode.
10550
864db017
JB
105512011-05-31 Juanma Barranquero <lekktu@gmail.com>
10552
10553 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10554 Update dependencies.
10555
2ad0baf4
DN
105562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10557
10558 * data.c (init_data): Remove code for UTS, this system is not
10559 supported anymore.
10560
4fcc2638
DN
105612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10562
10563 Don't force ./temacs to start in terminal mode.
10564
10565 * frame.c (make_initial_frame): Initialize faces in all cases, not
10566 only when CANNOT_DUMP is defined.
10567 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10568
c56e0fd5
DN
105692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10570
10571 * dispnew.c (add_window_display_history): Use const for the string
10572 pointer. Remove declaration, not needed.
10573
333d54da 105742011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10575
55d4c1b2 10576 Use 'inline', not 'INLINE'.
333d54da 10577 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10578 * alloc.c, fontset.c (INLINE): Remove.
10579 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10580 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10581 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10582 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10583 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10584
738db178
DN
105852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10586
10587 Make it possible to run ./temacs.
10588
10589 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10590 syms_of_callproc does the same thing. Remove test for
10591 "initialized", do it in the caller.
10592 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10593
620c53a6
SM
105942011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10595
10596 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10597 (read_minibuf): Use get_minibuffer.
10598 (syms_of_minibuf): Use DEFSYM.
10599 (Qmetadata): New var.
10600 * data.c (Qbuffer): Don't make it static.
10601 (syms_of_data): Use DEFSYM.
10602
e003a292
PE
106032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10604
10605 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10606 (CCL_CODE_MIN): New macro.
10607
ed008a6d
PE
106082011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10609
3687c2ef
PE
10610 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10611
ed008a6d
PE
10612 * eval.c (Qdebug): Now static.
10613 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10614 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10615 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10616
d66c4c7c
CY
106172011-05-29 Chong Yidong <cyd@stupidchicken.com>
10618
10619 * image.c: Various fixes to ImageMagick code comments.
10620 (Fimagemagick_types): Doc fix.
10621
5fbc2025
PE
106222011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10623
0196f88a
PE
10624 Minor fixes prompted by GCC 4.6.0 warnings.
10625
10626 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10627
5fbc2025
PE
10628 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10629 (x_clipboard_manager_save_all): Move extern decl to ...
10630 * xterm.h: ... here, so that it can be checked for consistency.
10631
1dd3c2d9
CY
106322011-05-29 Chong Yidong <cyd@stupidchicken.com>
10633
10634 * xselect.c (x_clipboard_manager_save_frame)
10635 (x_clipboard_manager_save_all): New functions.
10636 (Fx_clipboard_manager_save): Lisp function deleted.
10637
10638 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10639 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10640
10641 * xterm.h: Update prototype.
10642
5ba6571d
WX
106432011-05-28 William Xu <william.xwl@gmail.com>
10644
10645 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10646 exiting (Bug#8239).
10647
3eaff834
JM
106482011-05-28 Jim Meyering <meyering@redhat.com>
10649
e1900994 10650 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10651 * fns.c (to_uchar): Define.
10652 (crypto_hash_function): Use it to convert some newly-signed
10653 variables to unsigned, to avoid sign-extension bugs. For example,
10654 without this change, (md5 "truc") would evaluate to
10655 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10656 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10657 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10658
0f6990a7
PE
106592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10660
10661 Integer overflow fixes.
c8a9ca5a 10662
08686060
PE
10663 * dbusbind.c: Serial number integer overflow fixes.
10664 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10665 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10666 to hold a serial number that is too large for a fixnum.
10667 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10668 Check for serial numbers out of range. Decode any serial number
59568bf0 10669 that was so large that it became a float. (Bug#8722)
08686060 10670
2d1fc3c7
PE
10671 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10672 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10673 Use XFASTINT rather than XUINT when numbers are nonnegative.
10674 (xd_append_arg, Fdbus_method_return_internal):
10675 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10676 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10677 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10678 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10679 (Bug#8722)
2d1fc3c7 10680
c8a9ca5a
PE
10681 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10682
519e1d69
PE
10683 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10684
6df6ae42 10685 ccl: Add integer overflow checks.
30569699
PE
10686 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10687 (IN_INT_RANGE): New macros.
10688 (ccl_driver): Use them to check for integer overflow when
10689 decoding a CCL program. Many of the new checks are whether XINT (x)
10690 fits in int; it doesn't always, on 64-bit hosts. The new version
10691 doesn't catch all possible integer overflows, but it's an
847044ea 10692 improvement. (Bug#8719)
30569699 10693
c11285dc
PE
10694 * alloc.c (make_event_array): Use XINT, not XUINT.
10695 There's no need for unsigned here.
10696
fdccd48e
PE
10697 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10698 This follows up to the 2011-05-06 change that substituted uintptr_t
10699 for EMACS_INT. This case wasn't caught back then.
10700
37910ab2
PE
10701 Rework Fformat to avoid integer overflow issues.
10702 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10703 now (part of C89). Include <verify.h>.
10704 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10705 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10706 (Fformat): Avoid the prepass trying to compute sizes; it was only
10707 approximate and thus did not catch overflow reliably. Instead, walk
10708 through the format just once, formatting and computing sizes as we go,
10709 checking for integer overflow at every step, and allocating a larger
10710 buffer as needed. Keep track separately whether the format is
10711 multibyte. Keep only the most-recently calculated precision, rather
10712 than them all. Record whether each argument has been converted to
10713 string. Use EMACS_INT, not int, for byte and char and arg counts.
10714 Support field widths and precisions larger than INT_MAX. Avoid
10715 sprintf's undefined behavior with conversion specifications such as %#d
10716 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10717 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10718 formatting out-of-range floating point numbers with int
9173deec 10719 formats. (Bug#8668)
37910ab2 10720
2e6578fb
PE
10721 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10722
0ae6bdee
PE
10723 * data.c: Avoid integer truncation in expressions involving floats.
10724 * data.c: Include <intprops.h>.
10725 (arith_driver): When there's an integer overflow in an expression
10726 involving floating point, convert the integers to floating point
10727 so that the resulting value does not suffer from catastrophic
10728 integer truncation. For example, on a 64-bit host (* 4
10729 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10730 Do not rely on undefined behavior after integer overflow.
10731
de883a70
PE
10732 merge count_size_as_multibyte, parse_str_to_multibyte
10733 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10734 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10735 Check for integer overflow.
10736 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10737 since it's now a duplicate of the other. This is more of
10738 a character than a buffer op, so better that it's in character.c.
10739 * fns.c, print.c: Adjust to above changes.
10740
2ff916cb
PE
107412011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10742
10743 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10744
f1b54466
PE
107452011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10746
fb1ac845
PE
10747 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10748 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10749 (x_clipboard_manager_save): Now static.
10750 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10751
f1b54466
PE
10752 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10753 (crypto_hash_function): Now static.
10754 Fix pointer signedness problems. Avoid unnecessary initializations.
10755
a9f737ee
CY
107562011-05-27 Chong Yidong <cyd@stupidchicken.com>
10757
10758 * termhooks.h (Vselection_alist): Make it terminal-local.
10759
10760 * terminal.c (create_terminal): Initialize it.
10761
10762 * xselect.c: Support for clipboard managers.
10763 (Vselection_alist): Move to termhooks.h as terminal-local var.
10764 (LOCAL_SELECTION): New macro.
10765 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10766 (symbol_to_x_atom): Remove gratuitous arg.
10767 (x_handle_selection_request, lisp_data_to_selection_data)
10768 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10769 (x_own_selection, x_get_local_selection, x_convert_selection):
10770 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10771 (some_frame_on_display): Delete unused function.
10772 (Fx_own_selection_internal, Fx_get_selection_internal)
10773 (Fx_disown_selection_internal, Fx_selection_owner_p)
10774 (Fx_selection_exists_p): New optional frame arg.
10775 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10776 (x_handle_selection_clear): Don't treat other terminals with the
10777 same keyboard specially. Use the terminal-local Vselection_alist.
10778 (x_clear_frame_selections): Use Frun_hook_with_args.
10779
10780 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10781
10782 * xterm.h: Add support for those atoms.
10783
e067f0c1
CY
107842011-05-26 Chong Yidong <cyd@stupidchicken.com>
10785
10786 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10787 (converted_selections, conversion_fail_tag): New global variables.
10788 (x_selection_request_lisp_error): Free the above.
10789 (x_get_local_selection): Remove unnecessary code.
10790 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10791 of converted selections stored in converted_selections.
10792 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10793 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10794 (x_convert_selection): New function.
10795 (x_handle_selection_event): Simplify.
10796 (x_get_foreign_selection): Don't ignore incoming requests while
10797 waiting for an answer; this will fail when we implement
10798 SAVE_TARGETS, and seems unnecessary anyway.
10799 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10800 (Vx_sent_selection_functions): Doc fix.
10801
0f4aebc0
LL
108022011-05-26 Leo Liu <sdl.web@gmail.com>
10803
10804 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10805
e61124cd
YM
108062011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10807
10808 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10809
10810 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10811 for fringe update if it has periodic bitmap.
ac389d0c 10812 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10813 and fringe_bitmap_periodic_p.
10814
10815 * fringe.c (get_fringe_bitmap_data): New function.
10816 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10817 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10818 row. Mark glyph row for fringe update if periodicity changed.
10819
10820 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10821 for fringe update unless it has periodic bitmap.
10822
f16d9837
KH
108232011-05-25 Kenichi Handa <handa@m17n.org>
10824
10825 * xdisp.c (get_next_display_element): Set correct it->face_id for
10826 a static composition.
10827
e1b90ef6
LL
108282011-05-24 Leo Liu <sdl.web@gmail.com>
10829
10830 * deps.mk (fns.o):
10831 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10832
10833 * fns.c (crypto_hash_function, Fsha1): New function.
10834 (Fmd5): Use crypto_hash_function.
10835 (syms_of_fns): Add Ssha1.
10836
7400048f
PE
108372011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10838
10839 * gnutls.c: Remove unused macros.
10840 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10841 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10842 Remove macros that are defined and never used.
10843 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10844
abb71cf4
CY
108452011-05-22 Chong Yidong <cyd@stupidchicken.com>
10846
10847 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10848 (Fx_get_selection_internal): Minor cleanup.
10849 (Fx_own_selection_internal): Rename arguments for consistency with
10850 select.el.
10851
6307db39
PE
108522011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10853
10854 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10855
f3d4e0a4
CY
108562011-05-22 Chong Yidong <cyd@stupidchicken.com>
10857
10858 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10859
4d8ade89
YM
108602011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10861
10862 * dispnew.c (scrolling_window): Don't exclude the case that the
10863 last enabled row in the desired matrix touches the bottom boundary.
10864
32078c8d
GM
108652011-05-21 Glenn Morris <rgm@gnu.org>
10866
10867 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10868 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10869 and add some more files.
32078c8d 10870
7285dc67
EZ
108712011-05-20 Eli Zaretskii <eliz@gnu.org>
10872
10873 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10874 report_file_error introduced by the change from 2011-05-07.
10875
89d1bd22
PE
108762011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10877
10878 * systime.h (Time): Define only if emacs is defined.
10879 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10880 where the include path doesn't have X11/X.h by default. See
10881 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10882
cd394be1 108832011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10884
10885 * composite.c (find_automatic_composition): Fix previous change.
10886
b9704ad9
GM
108872011-05-20 Glenn Morris <rgm@gnu.org>
10888
10889 * lisp.mk: New file, split from Makefile.in.
10890 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10891 (shortlisp): Remove.
10892 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10893
4a720484
GM
108942011-05-19 Glenn Morris <rgm@gnu.org>
10895
10896 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10897 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10898 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10899 (lisp): Set the order to that of loadup.el.
10900 (shortlisp): Make it a copy of $lisp.
10901 (SOME_MACHINE_LISP): Remove.
10902 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10903 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10904
a28d4396
KH
109052011-05-18 Kenichi Handa <handa@m17n.org>
10906
10907 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10908 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10909 (find_automatic_composition): Mostly rewrite for efficiency.
10910
a2b1fa8e
JB
109112011-05-18 Juanma Barranquero <lekktu@gmail.com>
10912
10913 * makefile.w32-in: Update dependencies.
10914
8e1f5610
CS
109152011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10916
10917 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10918 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10919
7025ee00 109202011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10921
cdfa6eab
PE
10922 Fix some integer overflow issues, such as string length overflow.
10923
06d6db33
PE
10924 * insdel.c (count_size_as_multibyte): Check for string overflow.
10925
2b4560a8
PE
10926 * character.c (lisp_string_width): Check for string overflow.
10927 Use EMACS_INT, not int, for string indexes and lengths; in
10928 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10929 the resulting string length overflows an EMACS_INT; instead,
10930 report a string overflow if no precision given. When checking for
10931 precision exhaustion, use a check that cannot possibly have
10932 integer overflow. (Bug#8675)
10933 * character.h (lisp_string_width): Adjust to new signature.
10934
cb93f9be
PE
10935 * alloc.c (string_overflow): New function.
10936 (Fmake_string): Use it. This doesn't change behavior, but saves
10937 a few bytes and will simplify future changes.
10938 * character.c (string_escape_byte8): Likewise.
10939 * lisp.h (string_overflow): New decl.
10940
1a1f3366
PE
10941 Fixups, following up to the user-interface timestamp change.
10942 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10943 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10944 * msdos.c (mouse_get_pos): Likewise.
10945 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10946 * w32gui.h (Time): Define by including "systime.h" rather than by
10947 declaring it ourselves. (Bug#8664)
10948
d4e3e4d3
PE
10949 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10950 * image.c (clear_image_cache): Likewise.
10951
f6a24d19
PE
10952 * term.c (term_mouse_position): Don't assume time_t wraparound.
10953
08dc5ae6
PE
10954 Be more systematic about user-interface timestamps.
10955 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10956 and sometimes 'EMACS_UINT', to represent these timestamps.
10957 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10958 This makes the code easier to follow, and makes it easier to catch
10959 integer overflow bugs such as Bug#8664.
10960 * frame.c (Fmouse_position, Fmouse_pixel_position):
10961 Use Time, not unsigned long, for user-interface timestamps.
10962 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10963 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10964 * keyboard.h (last_event_timestamp): Likewise.
10965 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10966 * menu.h (xmenu_show): Likewise.
10967 * term.c (term_mouse_position): Likewise.
10968 * termhooks.h (struct input_event.timestamp): Likewise.
10969 (struct terminal.mouse_position_hook): Likewise.
10970 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10971 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10972 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10973 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10974 what it was before.
10975 * menu.h, termhooks.h: Include "systime.h", for Time.
10976
8e55734a
PE
10977 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10978 Don't assume that the difference between two unsigned long values
10979 can fit into an integer. At this point, we know button_down_time
10980 <= event->timestamp, so the difference must be nonnegative, so
10981 there's no need to cast the result if double-click-time is
10982 nonnegative, as it should be; check that it's nonnegative, just in
10983 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10984 apart (about 25 days). (Bug#8664)
8e55734a 10985
841f1b75 10986 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10987 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10988
3e26f69c
PE
10989 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10990 that always fit in int. Use a sentinel instead of a counter, to
10991 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10992 * frame.h (struct frame): Use int for menu_bar_items_used
10993 instead of EMACS_INT, since it always fits in int.
3e26f69c 10994
5cc152c0
PE
10995 * menu.c (grow_menu_items): Check for int overflow.
10996
d89eb65e
PE
10997 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10998
5235bd3e
PE
10999 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11000 Before, the code was not consistent. These values cannot exceed
11001 2**31 - 1 so there's no need to make them unsigned.
11002 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11003 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11004 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11005 as modifiers.
11006 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11007
bc827e23
PE
11008 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11009 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11010 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11011 presumably because the widths might not match.
11012
78eb494e
PE
11013 * window.c (size_window): Avoid needless test at loop start.
11014
04f2d78b
CB
110152011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11016
11017 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11018
d2fc7e3d 110192011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11020
11021 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11022
d2fc7e3d 110232011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11024
11025 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11026 `width' to `bar_area_x' and `bar_area_width', respectively.
11027 (x_scroll_run): Take account of fringe background extension.
11028
04f2d78b
CB
11029 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11030 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11031 `bar_area_width', respectively.
11032 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11033 background extension.
11034
79b70037
GM
110352011-05-10 Jim Meyering <meyering@redhat.com>
11036
11037 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11038
2f142cc5
JB
110392011-05-10 Juanma Barranquero <lekktu@gmail.com>
11040
11041 * image.c (Finit_image_library): Return t for built-in image types,
11042 like pbm and xbm. (Bug#8640)
11043
57679c86
AS
110442011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11045
11046 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11047
888c9e86
EZ
110482011-05-07 Eli Zaretskii <eliz@gnu.org>
11049
b0512a1d
EZ
11050 * w32console.c (Fset_screen_color): Doc fix.
11051 (Fget_screen_color): New function.
11052 (syms_of_ntterm): Defsubr it.
11053
7285dc67
EZ
11054 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11055 unlink the temporary file if Fcall_process didn't create it in the
11056 first place.
11057 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11058 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11059 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11060 cue to call_process_cleanup not to close that handle.
11061
4d3fcc8e
BK
110622011-05-07 Ben Key <bkey76@gmail.com>
11063
11064 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11065 one of two shell specific rules, either bootstrap-temacs-CMD or
11066 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11067 to the previous implementation of the bootstrap-temacs rule.
11068 The bootstrap-temacs-CMD rule is similar to the previous
11069 implementation of the bootstrap-temacs rule except that it
11070 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11071 variable.
11072
11073 These changes, along with some changes to nt/configure.bat,
11074 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11075 earlier fix to add support for --cflags and --ldflags options
11076 that include quotes so that it works whether make uses cmd or
11077 sh as the shell.
11078
b4289b64
MA
110792011-05-06 Michael Albinus <michael.albinus@gmx.de>
11080
11081 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11082 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11083 is a constant.
11084 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11085 a string. Handle both cases.
11086 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11087 (Fdbus_register_method): Use Qinvalid_function.
11088
af4c0e28
JB
110892011-05-06 Juanma Barranquero <lekktu@gmail.com>
11090
11091 * makefile.w32-in: Update dependencies.
11092 (LISP_H): Add inttypes.h and stdin.h.
11093 (PROCESS_H): Add unistd.h.
11094
c51453d9
EZ
110952011-05-06 Eli Zaretskii <eliz@gnu.org>
11096
11097 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11098 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11099
8ff0ac3c 111002011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11101
4c4b566b
PE
11102 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11103
aab2b9b5
PE
11104 * term.c (vfatal): Remove stray call to va_end.
11105 It's not needed and the C Standard doesn't allow it here anyway.
11106
c378da0b
PE
11107 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11108 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11109
288b08c7
PE
11110 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11111 bytes.
11112
e3601888
PE
11113 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11114
db6c0e74
PE
11115 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11116
dd5963ea
PE
11117 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11118
88c9450f
PE
11119 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11120
2f9442b8
PE
11121 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11122
c032b5f8
PE
11123 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11124 * charset.c (Fdefine_charset_internal): Don't initialize
11125 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11126 32-bit int (Bug#8600).
a108c10b
PE
11127
11128 * lread.c (read_integer): Be more consistent with string-to-number.
11129 Use string_to_number to do the actual conversion; this avoids
11130 rounding errors and fixes some other screwups. Without this fix,
11131 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11132 (digit_to_number): Move earlier, for benefit of read_integer.
11133 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11134 not a digit in any supported base. (Bug#8602)
a108c10b 11135
ad5f9eea
PE
11136 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11137
aec1708a
PE
11138 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11139 to match comment at start of function. This also removes a
11140 GCC warning about overflow in a 32+64-bit port.
11141
47be4ab5
PE
11142 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11143
371cac43
PE
11144 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11145 Reported by Stefan Monnier in
11146 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11147 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11148 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11149
d01a7826
PE
11150 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11151 (EMACS_UINTPTR): Likewise, with uintptr_t.
11152
7fd47d5c
PE
11153 * lisp.h: Prefer 64-bit EMACS_INT if available.
11154 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11155 on 32-bit hosts that have 64-bit int, so that they can access
11156 large files.
122b0c86
PE
11157 However, temporarily disable this change unless the temporary
11158 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11159
8727937b
PE
11160 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11161
8ac068ac
PE
11162 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11163 This removes an assumption that EMACS_INT and long are the same
11164 width as pointers. The assumption is true for Emacs porting targets
11165 now, but we want to make other targets possible.
11166 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11167 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11168 In the rest of the code, change types of integers that hold casted
11169 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11170 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11171 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11172 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11173 No need to cast type when ORing.
11174 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11175 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11176 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11177 assume EMACS_INT is the same width as char *.
11178 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11179 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11180 Remove no-longer-needed casts.
11181 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11182 (xg_tool_bar_help_callback, xg_make_tool_item):
11183 Use EMACS_INTPTR to hold an integer
11184 that will be cast to void *; this can avoid a GCC warning
11185 if EMACS_INT is not the same width as void *.
11186 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11187 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11188 (current_message_1, set_message_1):
11189 Use a local to convert to proper width without a cast.
11190 * xmenu.c (dialog_selection_callback): Likewise.
11191
ede49d71
PE
11192 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11193 Also, don't assume VALBITS / RAND_BITS is less than 5,
11194 and don't rely on undefined behavior when shifting a 1 left into
11195 the sign bit.
11196 * lisp.h (get_random): Change signature to match.
11197
2f30ecd0
PE
11198 * lread.c (hash_string): Use size_t, not int, for hash computation.
11199 Normally we prefer signed values; but hashing is special, because
11200 it's better to use unsigned division on hash table sizes so that
11201 the remainder is nonnegative. Also, size_t is the natural width
11202 for hashing into memory. The previous code used 'int', which doesn't
11203 retain enough info to hash well into very large tables.
11204 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11205
2a866e7b
PE
11206 * dbusbind.c: Don't possibly lose pointer info when converting.
11207 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11208 Use XPNTR rather than XHASH, so that the high-order bits of
11209 the pointer aren't lost when converting through void *.
11210
51639eac
PE
11211 * eval.c (Fautoload): Don't double-shift a pointer.
11212
92394119
PE
11213 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11214
dbdb9a7c
JB
112152011-05-06 Juanma Barranquero <lekktu@gmail.com>
11216
11217 * gnutls.c (DEF_GNUTLS_FN):
11218 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11219
db7a0b4f
AS
112202011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11221
11222 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11223 marker. (Bug#8610)
11224
cd394be1 112252011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11226
11227 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11228 New version that can reserve upto 2GB of heap space.
11229
f7ff1b0f 112302011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11231
11232 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11233
639c109b
TZ
112342011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11235
11236 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11237 `gnutls_certificate_set_x509_key_file'.
11238
d2127135
JB
112392011-05-05 Juanma Barranquero <lekktu@gmail.com>
11240
11241 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11242 Update dependencies.
11243
e968f4f3
JB
112442011-05-04 Juanma Barranquero <lekktu@gmail.com>
11245
11246 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11247 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11248 Remove unused parameter `fildes'.
11249 * process.c (read_process_output, send_process): Don't pass it.
11250
84d358f0
JB
112512011-05-04 Juanma Barranquero <lekktu@gmail.com>
11252
11253 Fix previous change: the library cache is defined in w32.c.
11254 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11255 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11256
0898ca10
JB
112572011-05-04 Juanma Barranquero <lekktu@gmail.com>
11258
11259 Implement dynamic loading of GnuTLS on Windows.
11260
11261 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11262 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11263 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11264 Declare.
11265
11266 * gnutls.c (Qgnutls_dll): Define.
11267 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11268 (gnutls_*): Declare function pointers.
11269 (init_gnutls_functions): New function to initialize function pointers.
11270 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11271 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11272 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11273 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11274 (emacs_gnutls_write, emacs_gnutls_read)
11275 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11276 (Fgnutls_available_p): New function.
11277 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11278 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11279 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11280
11281 * image.c: Include w32.h.
11282 (Vimage_type_cache): Delete.
11283 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11284 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11285 (w32_delayed_load): Move to w32.c.
11286
11287 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11288
11289 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11290 (w32_delayed_load): Move from image.c. When loading a library, record
11291 its filename in the :loaded-from property of the library id.
11292 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11293 Initialize and staticpro them.
11294 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11295
11296 * process.c: Include lisp.h before w32.h, not after.
11297 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11298 instead of gnutls_record_check_pending.
11299
11300 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11301
ff4de4aa
TZ
113022011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11303
11304 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11305 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11306 as passed in.
11307
abe95abb
JD
113082011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11309
11310 * xterm.c (x_set_frame_alpha): Do not set property on anything
11311 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11312
e16e55d4
JB
113132011-05-02 Juanma Barranquero <lekktu@gmail.com>
11314
11315 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11316
bafcf6a5
JB
113172011-05-02 Juanma Barranquero <lekktu@gmail.com>
11318
11319 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11320 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11321 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11322 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11323 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11324 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11325 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11326 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11327 (Qgnutls_bootprop_callbacks_verify): Make static.
11328
e7a6747f
AS
113292011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11330
19ed11ba
AS
11331 * callproc.c: Indentation fixup.
11332
e7a6747f 11333 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11334 (wait_for_termination, interruptible_wait_for_termination):
11335 Move after wait_for_termination_1.
e7a6747f 11336
1ef14cb4
LMI
113372011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11338
11339 * sysdep.c (interruptible_wait_for_termination): New function
11340 which is like wait_for_termination, but allows keyboard
11341 interruptions.
11342
11343 * callproc.c (Fcall_process): Add (:file "file") as an option for
11344 the STDOUT buffer.
11345 (Fcall_process_region): Ditto.
11346
330d880c
EZ
113472011-04-30 Eli Zaretskii <eliz@gnu.org>
11348
8db90b73
EZ
11349 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11350 rather than `XVECTOR (FOO)->size'.
11351
330d880c
EZ
11352 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11353 inttypes.h, as a gnulib replacement is used if it not available in
11354 system headers.
11355
15cbd324
EZ
113562011-04-21 Eli Zaretskii <eliz@gnu.org>
11357
11358 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11359 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11360 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11361
11362 * coding.c (coding_alloc_by_realloc): Error out if destination
11363 will grow beyond MOST_POSITIVE_FIXNUM.
11364 (decode_coding_emacs_mule): Abort if there isn't enough place in
11365 charbuf for the composition carryover bytes. Reserve an extra
11366 space for up to 2 characters produced in a loop.
11367 (decode_coding_iso_2022): Abort if there isn't enough place in
11368 charbuf for the composition carryover bytes.
11369
113702011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11371
ae940cca
EZ
11372 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11373 aborting when %lld or %lll format is passed.
11374 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11375 %llo or %llx format is passed. (Bug#8545)
11376
03ab8921
EZ
11377 * window.c (window_scroll_line_based): Use a marker instead of
11378 simple variables to record original value of point. (Bug#7952)
11379
afda1437
EZ
11380 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11381 produced by %s or %c overflows available buffer space. (Bug#8545)
11382
f76dee0c
PE
113832011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11384
11385 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11386 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11387
fdc5744d
JB
113882011-04-28 Juanma Barranquero <lekktu@gmail.com>
11389
11390 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11391
638f053a
JB
113922011-04-28 Juanma Barranquero <lekktu@gmail.com>
11393
11394 * keyboard.c (Qdelayed_warnings_hook): Define.
11395 (command_loop_1): Run `delayed-warnings-hook'
11396 if Vdelayed_warnings_list is non-nil.
11397 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11398 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11399
d178f871
EZ
114002011-04-28 Eli Zaretskii <eliz@gnu.org>
11401
11402 * doprnt.c (doprnt): Don't return value smaller than the buffer
11403 size if the message was truncated. (Bug#8545).
11404
b124fd93
JB
114052011-04-28 Juanma Barranquero <lekktu@gmail.com>
11406
11407 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11408 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11409
e810457d
PE
114102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11411
11412 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11413
ea51cceb
JB
114142011-04-27 Juanma Barranquero <lekktu@gmail.com>
11415
11416 * makefile.w32-in: Update dependencies.
11417
94dcfacf
EZ
114182011-04-27 Eli Zaretskii <eliz@gnu.org>
11419
11420 Improve `doprnt' and its usage. (Bug#8545)
11421 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11422 `format_end'. Remove support for %l as a conversion specifier.
11423 Don't use xrealloc. Improve diagnostics when the %l size modifier
11424 is used. Update the commentary.
11425
11426 * eval.c (verror): Simplify calculation of size_t.
11427
11428 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11429 messages.
11430
f61f41d7
PE
114312011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11432
11433 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11434 change.
11435
96fb4434
PE
114362011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11437
11438 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11439 This makes this file independent of the recent pseudovector change.
11440
671875da 114412011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11442
69e9b5a3
PE
11443 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11444
b5f869a7 11445 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11446 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11447 Remove unused local.
c8926152 11448 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11449
841a1577 11450 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11451 GCC 4.6.0 optimizes based on type-based alias analysis.
11452 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11453 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11454 != &v->size, and therefore "v->size = 1; b->size = 2; return
11455 v->size;" must therefore return 1. This assumption is incorrect
11456 for Emacs, since it type-puns struct Lisp_Vector * with many other
11457 types. To fix this problem, this patch adds a new type struct
f904488f 11458 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11459 and pseudovectors, and helps optimizing compilers not get fooled
11460 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11461 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11462 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11463 the size member.
eab3844f
PE
11464 (XSETPVECTYPE): Rewrite in terms of new macro.
11465 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11466 This is a bit clearer, and further avoids the possibility of
11467 undesirable aliasing.
11468 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11469 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11470 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11471 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11472 (ASIZE): Now uses header.size rather than size.
11473 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11474 to avoid the hassle of writing XVECTOR (foo)->header.size.
11475 (struct vectorlike_header): New type.
eab3844f
PE
11476 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11477 object, to help avoid aliasing.
11478 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11479 (SUBRP): Likewise, since Lisp_Subr is a special case.
11480 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11481 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11482 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11483 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11484 changed to be "header.size" and "header.next".
11485 * buffer.h (struct buffer): Likewise.
11486 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11487 * frame.h (struct frame): Likewise.
11488 * process.h (struct Lisp_Process): Likewise.
11489 * termhooks.h (struct terminal): Likewise.
11490 * window.c (struct save_window_data, struct saved_window): Likewise.
11491 * window.h (struct window): Likewise.
11492 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11493 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11494 * buffer.c (init_buffer_once): Likewise.
11495 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11496 special case.
11497 * process.c (Fformat_network_address): Use local var for size,
11498 for brevity.
11499
0df1eac5
PE
11500 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11501
847ab9d1 11502 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11503 * data.c (atof): Remove decl; no longer used or needed.
11504 (digit_to_number): Move to lread.c.
11505 (Fstring_to_number): Use new string_to_number function, to be
11506 consistent with how the Lisp reader treats infinities and NaNs.
11507 Do not assume that floating-point numbers represent EMACS_INT
11508 without losing information; this is not true on most 64-bit hosts.
11509 Avoid double-rounding errors, by insisting on integers when
11510 parsing non-base-10 numbers, as the documentation specifies.
11511 * lisp.h (string_to_number): New decl, replacing ...
11512 (isfloat_string): Remove.
bc0a5c13 11513 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11514 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11515 appears to have been a coding error. Similarly, do not accept
11516 strings like +-1e0 as floating point numbers. Do not report
11517 overflow for integer overflows unless the base is not 10 which
11518 means we have no simple and reliable way to continue.
11519 Break out the floating-point parsing into a new
11520 function string_to_number, so that Fstring_to_number parses
11521 floating point numbers consistently with the Lisp reader.
04f2d78b 11522 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11523 (E_CHAR, EXP_INT): Remove, replacing with ...
11524 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11525 (string_to_number): New function, replacing isfloat_string.
11526 This function checks for valid syntax and produces the resulting
11527 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11528 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11529 so that overflow for non-base-10 numbers is reported only when
11530 there's no portable and simple way to convert to floating point.
452f4150 11531
67769ffc
PE
11532 * textprop.c (set_text_properties_1): Rewrite for clarity,
11533 and to avoid GCC warning about integer overflow.
11534
c20db43f
PE
11535 * intervals.h (struct interval): Use EMACS_INT for members
11536 where EMACS_UINT might cause problems. See
11537 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11538 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11539 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11540 All uses changed.
37aa2f85
PE
11541 (offset_intervals): Tell GCC not to worry about length overflow
11542 when negating a negative length.
c20db43f 11543
2538aa2f
PE
11544 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11545 (overrun_check_free): Likewise.
11546
f2d3008d
PE
11547 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11548 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11549 word size.
11550
ec8df744
PE
11551 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11552 (gnutls_make_error): Rename local to avoid shadowing.
11553 (gnutls_emacs_global_deinit): ifdef out; not used.
11554 (Fgnutls_boot): Use const for pointer to readonly storage.
11555 Comment out unused local. Fix pointer signedness problems.
11556
640ee02d
PE
11557 * lread.c (openp): Don't stuff size_t into an 'int'.
11558 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11559 about possible signed overflow.
11560
6048fb2a
PE
11561 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11562 (GDK_KEY_g): Don't define if already defined.
11563 (xg_prepare_tooltip): Avoid pointer signedness problem.
11564 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11565
fa3c87e1
PE
11566 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11567 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11568
2172544b
PE
11569 * xfns.c (Fx_window_property): Simplify a bit,
11570 to make a bit faster and to avoid GCC 4.6.0 warning.
11571 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11572
9b821a21
PE
11573 * fns.c (internal_equal): Don't assume size_t fits in int.
11574
3c616cfa
PE
11575 * alloc.c (compact_small_strings): Tighten assertion a little.
11576
c2982e87
PE
11577 Replace pEd with more-general pI, and fix some printf arg casts.
11578 * lisp.h (pI): New macro, generalizing old pEd macro to other
11579 conversion specifiers. For example, use "...%"pI"d..." rather
11580 than "...%"pEd"...".
11581 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11582 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11583 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11584 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11585 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11586 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11587 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11588 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11589 64-bit hosts.
11590 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11591 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11592 * print.c (safe_debug_print, print_object): Likewise.
11593 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11594 to int.
6f04d126
PE
11595 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11596 avoiding the 0 flag, which is not portable.
c2982e87
PE
11597 * process.c (Fmake_network_process): Use pI to avoid cast.
11598 * region-cache.c (pp_cache): Likewise.
11599 * xdisp.c (decode_mode_spec): Likewise.
11600 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11601 behavior on 64-bit hosts with printf arg.
6f04d126 11602 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11603 (x_stop_queuing_selection_requests): Likewise.
11604 (x_get_window_property): Don't truncate byte count to an 'int'
11605 when tracing.
0b432f21 11606
5e073ec7
PE
11607 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11608 here, since it parses constructs like leading '-' and spaces,
11609 which are not wanted; and it overflows with large numbers.
11610 Instead, simply match F[0-9]+, which is what is wanted anyway.
11611
36372bf9
PE
11612 * alloc.c: Remove unportable assumptions about struct layout.
11613 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11614 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11615 (allocate_vectorlike, make_pure_vector): Use the new macros,
11616 plus offsetof, to remove unportable assumptions about struct layout.
11617 These assumptions hold on all porting targets that I know of, but
11618 they are not guaranteed, they're easy to remove, and removing them
11619 makes further changes easier.
11620
0b432f21
PE
11621 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11622 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11623 (string_overrun_cookie): Now const. Use initializers that
11624 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11625 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11626 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11627 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11628 multiple of sizeof (EMACS_INT); it need not be, if
11629 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11630 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11631
895009e1
JB
116322011-04-26 Juanma Barranquero <lekktu@gmail.com>
11633
11634 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11635
6a7a1b0b
TZ
116362011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11637
11638 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11639 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11640 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11641
841a1577 116422011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11643
11644 * lisp.h (Qdebug): List symbol.
895009e1 11645 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11646 * keyboard.c (debug-on-event): New variable.
11647 (handle_user_signal): Break into debugger when debug-on-event
11648 matches the current signal symbol.
11649
f2d3ba6f
DN
116502011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11651
11652 * alloc.c (check_sblock, check_string_bytes)
11653 (check_string_free_list): Convert to standard C.
11654
42ce4c63
TZ
116552011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11656
11657 * w32.c (emacs_gnutls_push): Fix typo.
11658
825cd63c
EZ
116592011-04-25 Eli Zaretskii <eliz@gnu.org>
11660
fb11d64d
EZ
11661 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11662 "cast to pointer from integer of different size".
11663
825cd63c
EZ
11664 Improve doprnt and its use in verror. (Bug#8545)
11665 * doprnt.c (doprnt): Document the set of format control sequences
11666 supported by the function. Use SAFE_ALLOCA instead of always
11667 using `alloca'.
11668
11669 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11670 is one byte too soon. Don't use xrealloc; instead xfree and
11671 xmalloc anew.
11672
e061a11b
TZ
116732011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11674
11675 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11676 callbacks stage.
11677
11678 * gnutls.c: Renamed global_initialized to
11679 gnutls_global_initialized. Added internals for the
11680 :verify-hostname-error, :verify-error, and :verify-flags
11681 parameters of `gnutls-boot' and documented those parameters in the
11682 docstring. Start callback support.
9173deec
JB
11683 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11684 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11685 on error. Return error code.
e061a11b
TZ
11686 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11687 (emacs_gnutls_read): Likewise.
11688 (Fgnutls_boot): Return handshake error code.
11689 (emacs_gnutls_handle_error): New function.
11690 (wsaerror_to_errno): Likewise.
11691
11692 * w32.h (emacs_gnutls_pull): Add prototype.
11693 (emacs_gnutls_push): Likewise.
11694
11695 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11696 (emacs_gnutls_push): Likewise.
11697
116982011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11699
11700 * process.c (wait_reading_process_output): Check if GnuTLS
11701 buffered some data internally if no FDs are set for TLS
11702 connections.
11703
11704 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11705 (LIBS): Link to USER_LIBS.
11706 ($(BLD)/gnutls.$(0)): New target.
11707
fa6996bc
EZ
117082011-04-24 Eli Zaretskii <eliz@gnu.org>
11709
eb35682e
EZ
11710 * xdisp.c (handle_single_display_spec): Rename the
11711 display_replaced_before_p argument into display_replaced_p, to
11712 make it consistent with the commentary. Fix typos in the
11713 commentary.
11714
e2ad650c
EZ
11715 * textprop.c (syms_of_textprop): Remove dead code.
11716 (copy_text_properties): Delete obsolete commentary about an
11717 interface that was deleted long ago. Fix typos in the description
11718 of arguments.
11719
1b2de274
EZ
11720 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11721 to changes in oldXMenu/XMenu.h from 2011-04-16.
11722 <menu_help_message, prev_menu_help_message>: Constify.
11723 (IT_menu_make_room): menu->help_text is now `const char **';
11724 adjust.
11725
11726 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11727 to changes in oldXMenu/XMenu.h from 2011-04-16.
11728 (struct XMenu): Declare `help_text' `const char **'.
11729
11730 * xfaces.c <Qunspecified>: Make extern again.
11731
11732 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11733 required by POSIX.
1b2de274 11734
762b15be
EZ
11735 * doc.c (get_doc_string): Improve the format passed to `error'.
11736
11737 * doprnt.c (doprnt): Improve commentary.
11738
11739 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11740
11741 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11742 them with etags.
11743
f1052e5d
EZ
11744 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11745 changes in globals.h immediately force recompilation.
762b15be
EZ
11746 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11747 $(CURDIR)/s/ms-w32.h.
11748 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11749
fa6996bc
EZ
11750 * character.c (Fchar_direction): Function deleted.
11751 (syms_of_character): Don't defsubr it.
11752 <char-direction-table>: Deleted.
11753
e6c3da20
EZ
117542011-04-23 Eli Zaretskii <eliz@gnu.org>
11755
11756 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11757 * doprnt.c: Include limits.h.
11758 (SIZE_MAX): New macro.
04f2d78b
CB
11759 (doprnt): Return a size_t value. 2nd arg is now size_t.
11760 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11761 Improve overflow protection. Support `l' modifier for integer
11762 conversions. Support %l conversion. Don't assume an EMACS_INT
11763 argument for integer conversions and for %c.
11764
11765 * lisp.h (doprnt): Restore prototype.
11766
11767 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11768 $(SRC)/character.h.
11769
11770 * Makefile.in (base_obj): Add back doprnt.o.
11771
11772 * deps.mk (doprnt.o): Add back prerequisites.
11773 (callint.o): Depend on character.h.
11774
11775 * eval.c (internal_lisp_condition_case): Include the handler
11776 representation in the error message.
11777 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11778 when breaking from the loop.
11779
11780 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11781
11782 * callint.c (Fcall_interactively): When displaying error message
11783 about invalid control letter, pass the character's codepoint, not
11784 a pointer to its multibyte form. Improve display of the character
11785 in octal and display also its hex code.
11786
11787 * character.c (char_string): Use %x to display the (unsigned)
11788 codepoint of an invalid character, to avoid displaying a bogus
11789 negative value.
11790
11791 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11792 `error', not SYMBOL_NAME itself.
11793
11794 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11795 character arguments to `error'.
11796
11797 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11798 to `error' in error message about FINAL_CHAR argument. Make sure
11799 FINAL_CHAR is a character, and use %c when it is passed as
11800 argument to `error'.
11801
4ffd0d6b 118022011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11803
11804 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11805
11806 * w32.c: Include <time.h>.
11807 (sys_localtime): New function.
11808
4ffd0d6b 118092011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11810
11811 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11812
4ffd0d6b 11813 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11814
4ffd0d6b 118152011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11816
4ffd0d6b
GM
11817 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11818 zombies (Bug#8467).
aac0c6e3 11819
04c56954
EZ
118202011-04-19 Eli Zaretskii <eliz@gnu.org>
11821
11822 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11823 gl_state.e_property when gl_state.object is Qt.
11824
11825 * insdel.c (make_gap_larger): Remove limitation of buffer size
11826 to <= INT_MAX.
11827
16a43933
CY
118282011-04-18 Chong Yidong <cyd@stupidchicken.com>
11829
11830 * xdisp.c (lookup_glyphless_char_display)
11831 (produce_glyphless_glyph): Handle cons cell entry in
11832 glyphless-char-display.
11833 (Vglyphless_char_display): Document it.
11834
11835 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11836 glyphless-char-display.
11837
4581706e
CY
118382011-04-17 Chong Yidong <cyd@stupidchicken.com>
11839
11840 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11841
11842 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11843
11844 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11845 definition for no-X builds.
11846
4887c6e2 118472011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11848
fd35b6f9
PE
11849 Static checks with GCC 4.6.0 and non-default toolkits.
11850
5c1ccb01
PE
11851 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11852
006c5daa
PE
11853 * process.c (keyboard_bit_set): Define only if SIGIO.
11854 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11855 (send_process): Repair possible setjmp clobbering.
11856
efc736d3
PE
11857 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11858
4e2fe2e6
PE
11859 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11860
f97334a2
PE
11861 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11862
4e75f29d
PE
11863 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11864 Define only if needed.
11865
90efadd1
PE
11866 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11867 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11868 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11869
3c647824
PE
11870 * dispextern.h (struct redisplay_interface): Rename param
11871 to avoid shadowing.
e264f262 11872 * termhooks.h (struct terminal): Likewise.
761383f4 11873 * xterm.c (xembed_send_message): Likewise.
3c647824 11874
b58c5c4a
PE
11875 * insdel.c (make_gap_smaller): Define only if
11876 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11877
cad59032
PE
11878 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11879 it.
11880
c339dc2e
PE
11881 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11882 so that we aren't warned about unused symbols.
11883
91a3e27b
PE
11884 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11885
399c71d3 11886 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11887
8ffc96f5
PE
11888 * xfns.c (x_real_positions): Mark locals as initialized.
11889
eef9bc79
PE
11890 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11891
098db9dd
PE
11892 * xterm.c: Fix problems found by static analysis with other toolkits.
11893 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11894 (x_dispatch_event): Declare static if USE_GTK, and
11895 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11896 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11897 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11898 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11899 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11900
eb18f6cc
PE
11901 * xmenu.c (menu_help_callback): Pointer type fixes.
11902 Use const pointers when pointing at readonly data. Avoid pointer
11903 signedness clashes.
11904 (FALSE): Remove unused macro.
11905 (update_frame_menubar): Remove unused decl.
11906
1fe72bf8
PE
11907 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11908
60d9e1db
PE
11909 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11910 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11911 (single_menu_item): Rename local to avoid shadowing.
11912
39261c26
PE
11913 * keyboard.c (make_lispy_event): Remove unused local var.
11914
018c5e19
PE
11915 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11916 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11917
63d2b86e
PE
11918 * bitmaps: Change bitmaps from unsigned char back to the X11
11919 compatible char. Avoid the old compiler warnings about
11920 out-of-range initializers by using, for example, '\xab' rather
11921 than 0xab.
11922
aefd87e1
PE
11923 * xgselect.c (xgselect_initialize): Check vs interface
11924 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11925
bf501fb9
PE
11926 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11927
e9829fdf
PE
11928 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11929 to read-only memory.
11930
1086c095
PE
11931 * fns.c (vector): Remove; this old hack is no longer needed.
11932
2baccd04 11933 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11934 Remove unused var.
dde42981 11935 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11936
72391843 11937 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11938
436c16df 11939 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11940 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11941 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11942
92bb796d 11943 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11944 (x_term_init): Remove local to avoid shadowing.
92bb796d 11945
764430a3 11946 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11947
11948 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11949 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11950
d1dfb56c
EZ
119512011-04-16 Eli Zaretskii <eliz@gnu.org>
11952
c4354cb4
EZ
11953 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11954
d1dfb56c
EZ
11955 Fix regex.c, syntax.c and friends for buffers > 2GB.
11956 * syntax.h (struct gl_state_s): Declare character position members
11957 EMACS_INT.
11958
11959 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11960
04f2d78b
CB
11961 * textprop.c (verify_interval_modification, interval_of):
11962 Declare arguments EMACS_INT.
d1dfb56c
EZ
11963
11964 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11965 EMACS_INT.
11966
11967 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11968
11969 * indent.c (Fvertical_motion): Local variable it_start is now
11970 EMACS_INT.
11971
11972 * regex.c (re_match, re_match_2, re_match_2_internal)
11973 (bcmp_translate, regcomp, regexec, print_double_string)
11974 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11975 (re_compile_pattern, re_exec): Declare arguments and local
11976 variables `size_t' and `ssize_t' and return values `regoff_t', as
11977 appropriate.
11978 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11979 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11980 <compile_stack_type>: `size' and `avail' are now `size_t'.
11981
11982 * regex.h <regoff_t>: Use ssize_t, not int.
11983 (re_search, re_search_2, re_match, re_match_2): Arguments that
11984 specify buffer/string position and length are now ssize_t and
11985 size_t. Return type is regoff_t.
11986
613052cd
BK
119872011-04-16 Ben Key <bkey76@gmail.com>
11988
11989 * nsfont.m: Fixed bugs in ns_get_family and
11990 ns_descriptor_to_entity that were caused by using free to
11991 deallocate memory blocks that were allocated by xmalloc (via
11992 xstrdup). This caused Emacs to crash when compiled with
11993 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11994 --enable-checking=xmallocoverrun). xfree is now used to
11995 deallocate these memory blocks.
11996
4170f62f 119972011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11998
71b41406
PE
11999 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12000
9587a89d
PE
12001 emacs_write: Accept and return EMACS_INT for sizes.
12002 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12003 et seq.
12004 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12005 Accept and return EMACS_INT.
12006 (emacs_gnutls_write): Return the number of bytes written on
12007 partial writes.
12008 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12009 (emacs_read, emacs_write): Remove check for negative size, as the
12010 Emacs source code has been audited now.
9587a89d
PE
12011 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12012 (emacs_read, emacs_write): Use it.
273a5f82
PE
12013 * process.c (send_process): Adjust to the new signatures of
12014 emacs_write and emacs_gnutls_write. Do not attempt to store
12015 a byte offset into an 'int'; it might overflow.
9587a89d 12016 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12017
3e047f51
PE
12018 * sound.c: Don't assume sizes fit in 'int'.
12019 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12020 Return EMACS_INT, not int.
3e047f51 12021 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12022 Accept EMACS_INT, not int.
12023 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12024 record read return values.
12025
cc39a9db
BK
120262011-04-15 Ben Key <bkey76@gmail.com>
12027
c9d0ec6d
JB
12028 * keyboard.c (Qundefined): Don't declare static since it is used
12029 in nsfns.m.
12030 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12031 static since they are used in nsfont.m.
cc39a9db 12032
6c60eb9f
SM
120332011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12034
12035 * process.c (Qprocessp): Don't declare static.
12036 * lisp.h (Qprocessp): Declare again.
12037
7990b61a
JB
120382011-04-15 Juanma Barranquero <lekktu@gmail.com>
12039
12040 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12041
5d4cb038
PE
120422011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12043
8bd7b830 12044 Improve C-level modularity by making more things 'static'.
cd64ea1d 12045
e3b27b31
PE
12046 Don't publish debugger-only interfaces to other modules.
12047 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12048 (verify_bytepos, count_markers): Move decls to the only modules
12049 that need them.
12050 * region-cache.h (pp_cache): Likewise.
12051 * window.h (check_all_windows): Likewise.
12052 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12053
5d4cb038
PE
12054 * sysdep.c (croak): Now static, if
12055 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12056 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12057
12058 * alloc.c (refill_memory_reserve): Now static if
12059 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12060 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12061
e87b6180
PE
12062 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12063 Define only if USE_LUCID.
12064
ac64929e
PE
12065 * xrdb.c (x_customization_string, x_rm_string): Now static.
12066
6f37259d
PE
12067 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12068 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12069
1683e3ab
PE
12070 * xdisp.c (draw_row_with_mouse_face): Now static.
12071 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12072
de9c2632
PE
12073 * window.h (check_all_windows): Mark externally visible.
12074
2b96acb7
PE
12075 * window.c (window_deletion_count): Now static.
12076
12077 * undo.c: Make symbols static if they're not exported.
12078 (last_undo_buffer, last_boundary_position, pending_boundary):
12079 Now static.
12080
50436f33
PE
12081 * textprop.c (interval_insert_behind_hooks): Now static.
12082 (interval_insert_in_front_hooks): Likewise.
12083
64520e5c
PE
12084 * term.c: Make symbols static if they're not exported.
12085 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12086 (max_frame_lines, tty_set_terminal_modes):
12087 (tty_reset_terminal_modes, tty_turn_off_highlight):
12088 (get_tty_terminal): Now static.
12089 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12090 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12091 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12092 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12093 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12094
1fa53021
PE
12095 * sysdep.c: Make symbols static if they're not exported.
12096 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12097 Now static.
12098 (sigprocmask_set, full_mask): Remove; unused.
12099 (wait_debugging): Mark as visible.
12100 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12101 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12102
d4b43b22
PE
12103 * syntax.c (syntax_temp): Define only if !__GNUC__.
12104
b7c513d0
PE
12105 * sound.c (current_sound_device, current_sound): Now static.
12106
989b29ad
PE
12107 * search.c (searchbufs, searchbuf_head): Now static.
12108
13a55a78
PE
12109 * scroll.c (scroll_cost): Remove; unused.
12110 * dispextern.h (scroll_cost): Remove decl.
12111
de68a1fc
PE
12112 * region-cache.h (pp_cache): Mark as externally visible.
12113
40ccffa6
PE
12114 * process.c: Make symbols static if they're not exported.
12115 (process_tick, update_tick, create_process, chan_process):
12116 (Vprocess_alist, proc_buffered_char, datagram_access):
12117 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12118 (deactivate_process): Mark defn as static, as well as decl.
12119 * lisp.h (create_process): Remove decl.
12120 * process.h (chan_process, Vprocess_alist): Remove decls.
12121
ad64fc97
PE
12122 * print.c: Make symbols static if they're not exported.
12123 (print_depth, new_backquote_output, being_printed, print_buffer):
12124 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12125 (print_interval, print_number_index, initial_stderr_stream):
12126 Now static.
12127 * lisp.h (Fprinc): Remove decl.
12128 (debug_output_compilation_hack): Mark as externally visible.
12129
adddb265
PE
12130 * sysdep.c (croak): Move decl from here to syssignal.h.
12131 * syssignal.h (croak): Put it here, so the API can be checked when
12132 'croak' is called from dissociate_if_controlling_tty.
12133
1717ede2
PE
12134 * minibuf.c: Make symbols static if they're not exported.
12135 (minibuf_save_list, choose_minibuf_frame): Now static.
12136 * lisp.h (choose_minibuf_frame): Remove decl.
12137
fa5fb2bc
PE
12138 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12139
1e3890d1
PE
12140 * lread.c: Make symbols static if they're not exported.
12141 (read_objects, initial_obarray, oblookup_last_bucket_number):
12142 Now static.
12143 (make_symbol): Remove; unused.
12144 * lisp.h (initial_obarray, make_symbol): Remove decls.
12145
8a1414fa
PE
12146 * keyboard.c: Make symbols static if they're not exported.
12147 (single_kboard, recent_keys_index, total_keys, recent_keys):
12148 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12149 (this_single_command_key_start, echoing, last_auto_save):
12150 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12151 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12152 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12153 (Vlispy_mouse_stem, double_click_count):
12154 Now static.
12155 (force_auto_save_soon): Define only if SIGDANGER.
12156 (ignore_mouse_drag_p): Now static if
12157 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12158 (print_help): Remove; unused.
12159 (stop_character, last_timer_event): Mark as externally visible.
12160 * keyboard.h (ignore_mouse_drag_p): Declare only if
12161 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12162 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12163 * lisp.h (echoing): Remove decl.
12164 (force_auto_save_soon): Declare only if SIGDANGER.
12165 * xdisp.c (redisplay_window): Simplify code, to make it more
12166 obvious that ignore_mouse_drag_p is not accessed if !defined
12167 USE_GTK && !defined HAVE_NS.
12168
93ea6e8f
PE
12169 * intervals.c: Make symbols static if they're not exported.
12170 (merge_properties_sticky, merge_interval_right, delete_interval):
12171 Now static.
12172 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12173
77382fcc
PE
12174 * insdel.c: Make symbols static if they're not exported.
12175 However, leave prepare_to_modify_buffer alone. It's never
12176 called from outside this function, but that appears to be a bug.
12177 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12178 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12179 (adjust_after_replace_noundo): Remove; unused.
12180 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12181 (signal_before_change): Remove decls.
77382fcc 12182
9306c32e
PE
12183 * indent.c (val_compute_motion, val_vmotion): Now static.
12184
cd44d2eb
PE
12185 * image.c: Make symbols static if they're not exported.
12186 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12187 if USE_GTK.
12188 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12189 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12190
ad9a7a06
PE
12191 * fringe.c (standard_bitmaps): Now static.
12192 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12193
81626931
PE
12194 * frame.c: Make symbols static if they're not exported.
12195 (x_report_frame_params, make_terminal_frame): Now static.
12196 (get_frame_param): Now static, unless HAVE_NS.
12197 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12198 (x_get_resource_string): Remove; not used.
12199 * frame.h (make_terminal_frame, x_report_frame_params):
12200 (x_get_resource_string); Remove decls.
12201 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12202 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12203
239f9db9
PE
12204 * font.c, fontset.c: Make symbols static if they're not exported.
12205 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12206 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12207 * font.c (font_close_object): Now static.
12208 * font.h (font_close_object): Remove.
12209 * fontset.c (FONTSET_OBJLIST): Remove.
12210 (free_realized_fontset) #if-0 the body, which does nothing.
12211 (face_suitable_for_char_p): #if-0, as it's never called.
12212 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12213 * xfaces.c (face_at_string_position):
12214 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12215 since 0 is always ASCII.
12216
dfcf3579
PE
12217 * fns.c (weak_hash_tables): Now static.
12218
5045092b
PE
12219 * fileio.c: Make symbols static if they're not exported.
12220 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12221 (Vwrite_region_annotation_buffers): Now static.
12222
57a96f5c
PE
12223 * eval.c: Make symbols static if they're not exported.
12224 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12225 * lisp.h (backtrace_list): Remove decl.
12226
35f08c38
PE
12227 * emacs.c: Make symbols static if they're not exported.
12228 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12229 (fatal_error_code, fatal_error_signal_hook, standard_args):
12230 Now static.
12231 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12232 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12233 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12234 * lisp.h (fatal_error_signal_hook): Remove decl.
12235 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12236
f44bd759
PE
12237 * editfns.c: Move a (normally-unused) function to its only use.
12238 * editfns.c, lisp.h (get_operating_system_release): Remove.
12239 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12240 worth the hassle of breaking this out.
12241
b532497d
PE
12242 * xterm.c: Make symbols static if they're not exported.
12243 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12244 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12245 (x_destroy_window, x_delete_display):
12246 Now static.
12247 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12248 (x_mouse_leave): Remove; unused.
12249 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12250 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12251 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12252 Remove decls.
12253 (x_mouse_leave): Declare only if WINDOWSNT.
12254 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12255 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12256 USE_X_TOOLKIT.
12257
1675728f
PE
12258 * ftxfont.c: Make symbols static if they're not exported.
12259 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12260 HAVE_FREETYPE.
12261 * font.h (ftxfont_driver): Likewise.
12262
e4cebfca
PE
12263 * xfns.c: Make symbols static if they're not exported.
12264 (x_last_font_name, x_display_info_for_name):
12265 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12266 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12267 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12268 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12269 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12270 (last_show_tip_args): Now static.
12271 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12272 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12273 (x_screen_planes): Remove; unused.
12274 * dispextern.h (x_screen_planes): Remove decl.
12275
5bf46f05
PE
12276 * dispnew.c: Make symbols static if they're not exported.
12277 * dispextern.h (redraw_garbaged_frames, scrolling):
12278 (increment_row_positions): Remove.
12279 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12280 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12281 Now static.
12282 (redraw_garbaged_frames): Remove; unused.
12283
435f4c28
PE
12284 * xfaces.c: Make symbols static if they're not exported.
12285 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12286 Remove decls.
12287 * xterm.h (defined_color): Remove decls.
12288 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12289 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12290 (menu_face_changed_default, defined_color, free_realized_face):
12291 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12292 (ascii_face_of_lisp_face): Remove; unused.
12293
8524aef3
PE
12294 * xdisp.c: Make symbols static if they're not exported.
12295 * dispextern.h (scratch_glyph_row, window_box_edges):
12296 (glyph_to_pixel_coords, set_cursor_from_row):
12297 (get_next_display_element, set_iterator_to_next):
12298 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12299 (show_mouse_face): Remove decls
12300 * frame.h (message_buf_print): Likewise.
12301 * lisp.h (pop_message, set_message, check_point_in_composition):
12302 Likewise.
12303 * xterm.h (set_vertical_scroll_bar): Likewise.
12304 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12305 (message_buf_print, scratch_glyph_row, displayed_buffer):
12306 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12307 (get_next_display_element, show_mouse_face, window_box_edges):
12308 (frame_to_window_pixel_xy, check_point_in_composition):
12309 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12310 (glyph_to_pixel_coords): Remove; unused.
12311
16390cd2
PE
12312 * dired.c (file_name_completion): Now static.
12313
12314 * dbusbind.c (xd_in_read_queued_messages): Now static.
12315
a25f4dfa
PE
12316 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12317 * data.c (circular_list_error): Remove.
12318
14a9c8df
PE
12319 * commands.h (last_point_position, last_point_position_buffer):
12320 (last_point_position_window): Remove decls.
12321 * keyboard.c: Make these variables static.
12322
04f2d78b
CB
12323 * coding.h (coding, code_convert_region, encode_coding_gap):
12324 Remove decls.
74ab6df5
PE
12325 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12326 (iso_code_class, detect_coding, code_convert_region): Now static.
12327 (encode_coding_gap): Remove; unused.
12328
38dfbee1
PE
12329 * chartab.c (chartab_chars, chartab_bits): Now static.
12330
a2cb4e63
PE
12331 * charset.h (charset_iso_8859_1): Remove decl.
12332 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12333 Now static.
12334
127198fd
PE
12335 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12336 * ccl.c (Vccl_program_table): Now static.
12337 (check_ccl_update): Remove; unused.
12338
d85b608f
PE
12339 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12340 * category.h: ... from here.
12341 * category.c (check_category_table, set_category_set): Now static.
12342
31cd66f3
PE
12343 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12344 * lisp.h: Remove these decls.
12345
c358e587
PE
12346 * buffer.c (buffer_count): Remove unused var.
12347
e78aecca
PE
12348 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12349 so that it's not optimized away.
12350 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12351 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12352 exported only to the debugger.
12353
e192d7d3 12354 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12355 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12356
92470028
PE
12357 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12358 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12359 was inaccessible from Lisp.
12360 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12361 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12362
244ed907
PE
12363 alloc.c: Import and export fewer symbols, and remove unused items.
12364 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12365 is defined.
12366 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12367 it's not optimized away by whole-program optimization.
12368 (message_enable_multibyte, free_misc): Remove.
12369 (catchlist, handlerlist, mark_backtrace):
12370 Declare only if BYTE_MARK_STACK.
12371 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12372 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12373 (message_enable_multibyte): Remove decl.
12374 (free_misc, interval_free_list, float_block, float_block_index):
12375 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12376 (cons_free_list, last_marked_index):
12377 Now static.
12378 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12379 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12380 (mark_backtrace): Define only if BYTE_MARK_STACK.
12381 * xdisp.c (message_enable_multibyte): Now static.
12382
61c2b50e 12383 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12384 This makes it easier for human readers (and static analyzers)
12385 to see whether these variables are used from other modules.
12386 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12387 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12388 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12389 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12390 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12391 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12392 * xmenu.c, xselect.c:
12393 Declare Q* vars static if they are not used in other modules.
12394 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12395 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12396 Remove decls of unexported vars.
12397 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12398
95c82688
PE
12399 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12400
16a97296
PE
12401 Make Emacs functions such as Fatom 'static' by default.
12402 This makes it easier for human readers (and static analyzers)
12403 to see whether these functions can be called from other modules.
12404 DEFUN now defines a static function. To make the function external
12405 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12406 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12407 (Finit_image_library):
16a97296
PE
12408 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12409 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12410 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12411 Remove decls, since these functions are now static.
12412 (Funintern, Fget_internal_run_time): New decls, since these functions
12413 were already external.
95c82688 12414
16a97296
PE
12415 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12416 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12417 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12418 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12419 * keyboard.c, keymap.c, lread.c:
12420 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12421 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12422 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12423 Mark functions with DEFUE instead of DEFUN,
12424 if they are used in other modules.
12425 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12426 decls for now-static functions.
12427 * buffer.h (Fdelete_overlay): Remove decl.
12428 * callproc.c (Fgetenv_internal): Mark as internal.
12429 * composite.c (Fremove_list_of_text_properties): Remove decl.
12430 (Fcomposition_get_gstring): New forward static decl.
12431 * composite.h (Fcomposite_get_gstring): Remove decl.
12432 * dired.c (Ffile_attributes): New forward static decl.
12433 * doc.c (Fdocumntation_property): New forward static decl.
12434 * eval.c (Ffetch_bytecode): New forward static decl.
12435 (Funintern): Remove extern decl; now in .h file where it belongs.
12436 * fileio.c (Fmake_symbolic_link): New forward static decl.
12437 * image.c (Finit_image_library): New forward static decl.
12438 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12439 * intervals.h (Fprevious_property_change):
12440 (Fremove_list_of_text_properties): Remove decls.
12441 * keyboard.c (Fthis_command_keys): Remove decl.
12442 (Fcommand_execute): New forward static decl.
12443 * keymap.c (Flookup_key): New forward static decl.
12444 (Fcopy_keymap): Now static.
12445 * keymap.h (Flookup_key): Remove decl.
12446 * process.c (Fget_process): New forward static decl.
12447 (Fprocess_datagram_address): Mark as internal.
12448 * syntax.c (Fsyntax_table_p): New forward static decl.
12449 (skip_chars): Remove duplicate decl.
12450 * textprop.c (Fprevious_property_change): New forward static decl.
12451 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12452 Now internal.
12453 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12454 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12455
785bbd42
PE
12456 * editfns.c (Fformat): Remove unreachable code.
12457
8b913b57
AS
124582011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12459
12460 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12461 change. (Bug#8496)
12462
a6744a35
EZ
124632011-04-13 Eli Zaretskii <eliz@gnu.org>
12464
12465 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12466 when at ZV. (Bug#8487)
12467
e7974947
AS
124682011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12469
baad03f0
AS
12470 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12471 (Bug#8437)
12472 * keyboard.c (parse_tool_bar_item): Likewise.
12473 * sound.c (sound_cleanup, alsa_close): Likewise.
12474 * termcap.c (tgetent): Likewise.
12475 * xfns.c (x_default_font_parameter): Likewise.
12476 * xsettings.c (read_and_apply_settings): Likewise.
12477
e7974947
AS
12478 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12479 (overrun_check_free): Protoize.
12480
28272684
PE
124812011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12482
12483 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12484 since callers should never pass a negative size.
12485 Change the signature to match that of plain 'read' and 'write'; see
12486 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12487 * lisp.h: Update prototypes of emacs_write and emacs_read.
12488
11997c76
EZ
124892011-04-11 Eli Zaretskii <eliz@gnu.org>
12490
12491 * xdisp.c (redisplay_window): Don't try to determine the character
12492 position of the scroll margin if the window start point w->startp
e896f03c 12493 is outside the buffer's accessible region. (Bug#8468)
11997c76 12494
8a2cbd72
EZ
124952011-04-10 Eli Zaretskii <eliz@gnu.org>
12496
12497 Fix write-region and its subroutines for buffers > 2GB.
12498 * fileio.c (a_write, e_write): Modify declaration of arguments and
12499 local variables to support buffers larger than 2GB.
12500 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12501
12502 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12503 argument, local variables, and return value.
12504
12505 * lisp.h: Update prototypes of emacs_write and emacs_read.
12506
12507 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12508
4073e537 125092011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12510
1ebfdcb6
PE
12511 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12512
b2ded58d
PE
12513 Fix more problems found by GCC 4.6.0's static checks.
12514
7d66342c
PE
12515 * xdisp.c (vmessage): Use a better test for character truncation.
12516
bbf47d44
PE
12517 * charset.c (load_charset_map): <, not <=, for optimization,
12518 and to avoid potential problems with integer overflow.
9248994d 12519 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12520 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12521 * editfns.c (Fformat): Likewise.
1e69125e 12522 * syntax.c (skip_chars): Likewise.
3befa583 12523
e3019616
PE
12524 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12525 This also lets GCC 4.6.0 generate slightly better loop code.
12526
becfa255
PE
12527 * callint.c (Fcall_interactively): <, not <=, for optimization.
12528 (Fcall_interactively): Count the number of arguments produced,
12529 not the number of arguments given. This is simpler and lets GCC
12530 4.6.0 generate slightly better code.
12531
dae0cd48
PE
12532 * ftfont.c: Distingish more carefully between FcChar8 and char.
12533 The previous code passed unsigned char * to a functions like
12534 strlen and xstrcasecmp that expect char *, which does not
12535 conform to the C standard.
12536 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12537 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12538 char * when the C standard requires it.
12539
76032d70
PE
12540 * keyboard.c (read_char): Remove unused var.
12541
eb3f1cc8
PE
12542 * eval.c: Port to Windows vsnprintf (Bug#8435).
12543 Include <limits.h>.
12544 (SIZE_MAX): Define if the headers do not.
12545 (verror): Do not give up if vsnprintf returns a negative count.
12546 Instead, grow the buffer. This ports to Windows vsnprintf, which
12547 does not conform to C99. Problem reported by Eli Zaretskii.
12548 Also, simplify the allocation scheme, by avoiding the need for
12549 calling realloc, and removing the ALLOCATED variable.
12550
70476b54
PE
12551 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12552
12020a9e
PE
12553 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12554 But keep the doprint source code for now, as we might revamp it
12555 and use it again (Bug#8435).
ea6c7ae6
PE
12556 * lisp.h (doprnt): Remove.
12557 * Makefile.in (base_obj): Remove doprnt.o.
12558 * deps.mk (doprnt.o): Remove.
12559
5fdb398c
PE
12560 error: Print 32- and 64-bit integers portably (Bug#8435).
12561 Without this change, on typical 64-bit hosts error ("...%d...", N)
12562 was used to print both 32- and 64-bit integers N, which relied on
12563 undefined behavior.
61bdb816 12564 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12565 * lisp.h (error, verror): Mark as printf-like functions.
12566 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12567 Report overflow in size calculations when allocating printf buffer.
12568 Do not truncate output string at its first null byte.
12569 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12570 Truncate the output at a character boundary, since vsnprintf does not
12571 do that.
12572 * charset.c (check_iso_charset_parameter): Convert internal
12573 character to string before calling 'error', since %c now has the
12574 printf meaning.
12575 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12576 overflow when computing char to be passed to 'error'. Do not
12577 pass Lisp_Object to 'error'; pass the integer instead.
12578 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12579 formatted with plain %d.
12580
b189fa66
PE
12581 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12582
bff87ef0
PE
12583 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12584
7e2cac20
PE
12585 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12586
ce4d90b5
PE
12587 * xterm.c (x_catch_errors): Remove duplicate declaration.
12588
266c9547
PE
12589 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12590
79c49ad2
PE
12591 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12592
368f4090
JM
125932011-04-10 Jim Meyering <meyering@redhat.com>
12594
12595 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12596 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12597 return ssize_t not "int", and use size_t as the buffer length.
12598 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12599 * gnutls.h: Update declarations.
12600 * process.c (read_process_output): Use ssize_t, to match.
12601 (send_process): Likewise.
12602
a32d4040
CY
126032011-04-09 Chong Yidong <cyd@stupidchicken.com>
12604
12605 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12606
8546720e 126072011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12608
04f2d78b
CB
12609 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12610 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12611
8546720e
GM
12612 * xterm.c (handle_one_xevent):
12613 * xmenu.c (create_and_show_popup_menu):
12614 * xselect.c (x_decline_selection_request)
12615 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12616
0a2f5c1a 126172011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12618
12619 Fix some uses of `int' instead of EMACS_INT.
12620 * search.c (string_match_1, fast_string_match)
12621 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12622 (scan_buffer, find_next_newline_no_quit)
12623 (find_before_next_newline, search_command, Freplace_match)
12624 (Fmatch_data): Make some `int' variables be EMACS_INT.
12625
12626 * xdisp.c (display_count_lines): 3rd argument and return value now
12627 EMACS_INT. All callers changed.
12628 (pint2hrstr): Last argument is now EMACS_INT.
12629
12630 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12631 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12632 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12633 (decode_coding_utf_16, decode_coding_emacs_mule)
12634 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12635 (decode_coding_ccl, decode_coding_charset)
12636 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12637 (decode_coding_iso_2022, decode_coding_emacs_mule)
12638 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12639 <char_offset, last_offset>: Declare EMACS_INT.
12640 (encode_coding_utf_8, encode_coding_utf_16)
12641 (encode_coding_emacs_mule, encode_invocation_designation)
12642 (encode_designation_at_bol, encode_coding_iso_2022)
12643 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12644 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12645 Declare EMACS_INT.
12646 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12647 (encode_invocation_designation): Last argument P_NCHARS is now
12648 EMACS_INT.
12649 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12650 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12651
12652 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12653 All users changed.
12654
12655 * ccl.c (Fccl_execute_on_string): Declare some variables
12656 EMACS_INT.
12657
8546720e 126582011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12659
12660 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12661
4e19a977
CS
126622011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12663
12664 * process.c (Fformat_network_address): Doc fix.
12665
87302331
R
126662011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12667
ee7683eb 12668 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12669
cbb59342
CY
126702011-04-08 Chong Yidong <cyd@stupidchicken.com>
12671
12672 * keyboard.c (read_char): Call Lisp function help-form-show,
12673 instead of using internal_with_output_to_temp_buffer.
12674 (Qhelp_form_show): New var.
e0d38eeb 12675 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12676
12677 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12678
12679 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12680
e67a13ab
CY
126812011-04-06 Chong Yidong <cyd@stupidchicken.com>
12682
04f2d78b
CB
12683 * process.c (Flist_processes): Remove to Lisp.
12684 (list_processes_1): Delete.
e67a13ab 12685
973f782d
EZ
126862011-04-06 Eli Zaretskii <eliz@gnu.org>
12687
7c106b1e
EZ
12688 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12689
973f782d
EZ
12690 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12691
41cf7d1a 126922011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12693
ca23cc88
PE
12694 Fix more problems found by GCC 4.6.0's static checks.
12695
f390e2d5
PE
12696 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12697
42eea0d0
PE
12698 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12699
b69769da 12700 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12701
f9541e84
PE
12702 * xdisp.c (vmessage): Mark as a printf-like function.
12703
13841b55
PE
12704 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12705
c136c10f
PE
12706 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12707
5e2d4a30
PE
12708 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12709 printf-like functions.
12710 (tiff_load): Add casts to remove these marks before passing them
12711 to system-supplied API.
12712
583f48b9
PE
12713 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12714
b25d760e
PE
12715 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12716 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12717 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12718 directly, rather than having caller test rule sign. This avoids
12719 some unnecessary tests.
12720 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12721 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12722 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12723
bc7b6697 12724 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12725 (xfont_open): Avoid unnecessary tests.
bc7b6697 12726
27ccc379
PE
12727 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12728
dcd5c89a
PE
12729 * composite.h, composite.c (composition_gstring_put_cache):
12730 Use EMACS_INT, not int, for length.
12731
b13a45c6
PE
12732 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12733 breaking out part of COMPOSITION_DECODE_RULE.
12734 (COMPOSITION_DECODE_RULE): Use it.
12735 * composite.c (get_composition_id): Remove unused local vars,
12736 by using the new macro.
12737
1e792e4d
PE
12738 * textprop.c (set_text_properties_1): Change while to do-while,
12739 since the condition is always true at first.
12740
dc6c6455 12741 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12742 (interval_deletion_adjustment): Return unsigned value.
12743 All uses changed.
dc6c6455 12744
aba7731a
PE
12745 * process.c (list_processes_1, create_pty, read_process_output):
12746 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12747 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12748 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12749 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12750 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12751
fdfc4bf3
PE
12752 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12753
fca8fe46 12754 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12755 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12756
06a0259a 12757 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12758 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12759 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12760
e7b9e80f
PE
12761 * print.c (print_error_message): Avoid int overflow.
12762
56201685
PE
12763 * font.c (font_list_entities): Redo for clarity,
12764 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12765
78834453 12766 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12767 (font_score): Avoid potential overflow in diff calculation.
78834453 12768
0bc0b309 12769 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12770 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12771
e610eaca
PE
12772 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12773
b895abce
PE
12774 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12775 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12776 can always succeed if overflow has undefined behavior.
12777
1f1d9321 12778 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12779 (wordify): Omit three unnecessary tests.
1f1d9321 12780
c59478bc
PE
12781 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12782 All callers changed. This avoids the need for an unused var.
12783
79b73827
PE
12784 * casefiddle.c (casify_region): Remove var that is set but not used.
12785
a4db5dfe
PE
12786 * dired.c (file_name_completion): Remove var that is set but not used.
12787
43aae36e
PE
12788 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12789
2a47c44d 12790 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12791 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12792
a37c69bf
PE
12793 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12794 Check for integer overflow on size calculations.
12795
328ab8e7
PE
12796 * buffer.c (Fprevious_overlay_change): Remove var that is set
12797 but not used.
12798
e5a2a5cb
PE
12799 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12800 Remove vars that are set but not used.
8d84a6eb 12801 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12802 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12803
a60e5f68
PE
12804 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12805
f661cb61 12806 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12807 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12808
f0397f5a
PE
12809 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12810 that are set but not used.
12811
8664db06 12812 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12813 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12814
6abdaa4a
PE
12815 * xselect.c (x_get_local_selection, x_handle_property_notify):
12816 Remove vars that are set but not used.
12817
0ce7538d 12818 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12819 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12820
9ae848fc
PE
12821 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12822 Remove var that is set but not used.
0b918413
PE
12823 (scroll_bar_windows_size): Now size_t, not int.
12824 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12825 Check for overflow.
9ae848fc 12826
a5a62657
PE
12827 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12828 (map_tty_color) [!defined MSDOS]: Likewise.
12829
5c5cdd39
PE
12830 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12831
66ebf983
PE
12832 * coding.c: Remove vars that are set but not used.
12833 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12834 All callers changed.
12835 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12836 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12837 (decode_coding_charset): Remove vars that are set but not used.
12838
1be4d761
PE
12839 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12840 that is set but not used.
12841
47553fa8
PE
12842 * print.c (print_object): Remove var that is set but not used.
12843
1f7196bf 12844 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12845 The gnulib version avoids calling malloc in the usual case,
12846 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12847 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12848 * filelock.c (current_lock_owner): Likewise.
12849 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12850 * sysdep.c: Include allocator.h, careadlinkat.h.
12851 (emacs_no_realloc_allocator): New static constant.
12852 (emacs_readlink): New function.
fdb61804
PE
12853 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12854 ../lib/careadlinkat.h.
d1fdcab7 12855
f84c17c7
SM
128562011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12857
12858 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12859 first non-nil return value).
12860
ef3862ad
JD
128612011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12862
12863 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12864 if not defined (Bug#8403).
12865
376a7006
JB
128662011-04-02 Juanma Barranquero <lekktu@gmail.com>
12867
12868 * xdisp.c (display_count_lines): Remove parameter `start',
12869 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12870 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12871 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12872 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12873 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12874 and thereabouts. All callers changed.
12875 (get_per_char_metric): Remove parameter `f', unused since
12876 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12877
6ca3801d
JM
128782011-04-02 Jim Meyering <meyering@redhat.com>
12879
12880 do not dereference NULL upon failed strdup
12881 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12882 (ns_get_family): Likewise.
12883
d8e2b5ba
JB
128842011-04-02 Juanma Barranquero <lekktu@gmail.com>
12885
12886 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12887
8c74fcbd
JD
128882011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12889
12890 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12891 later (Bug#8403).
12892
7200d79c
SM
128932011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12894
03408648 12895 Add lexical binding.
7200d79c 12896
03408648
SM
12897 * window.c (Ftemp_output_buffer_show): New fun.
12898 (Fsave_window_excursion):
12899 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12900
12901 * lread.c (lisp_file_lexically_bound_p): New function.
12902 (Fload): Bind Qlexical_binding.
12903 (readevalloop): Remove `evalfun' arg.
12904 Bind Qinternal_interpreter_environment.
12905 (Feval_buffer): Bind Qlexical_binding.
12906 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12907 Mark as dynamic.
12908 (syms_of_lread): Declare `lexical-binding'.
12909
12910 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12911
12912 * keyboard.c (eval_dyn): New fun.
12913 (menu_item_eval_property): Use it.
ca105506
SM
12914
12915 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12916
03408648
SM
12917 * fns.c (concat, mapcar1): Accept byte-code-functions.
12918
12919 * eval.c (Fsetq): Handle lexical vars.
12920 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12921 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12922 (FletX, Flet): Obey lexical binding.
12923 (Fcommandp): Handle closures.
12924 (Feval): New `lexical' arg.
12925 (eval_sub): New function extracted from Feval. Use it almost
12926 everywhere where Feval was used. Look up vars in lexical env.
12927 Handle closures.
12928 (Ffunctionp): Move from subr.el.
12929 (Ffuncall): Handle closures.
12930 (apply_lambda): Remove `eval_flags'.
12931 (funcall_lambda): Handle closures and new byte-code-functions.
12932 (Fspecial_variable_p): New function.
12933 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12934 but without exporting it to Lisp.
23aba0ea 12935
23aba0ea 12936 * doc.c (Fdocumentation, store_function_docstring):
03408648 12937 * data.c (Finteractive_form): Handle closures.
23aba0ea 12938
03408648
SM
12939 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12940 interactive spec.
ba83908c 12941
04f2d78b
CB
12942 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12943 New byte-codes.
03408648
SM
12944 (exec_byte_code): New function extracted from Fbyte_code to handle new
12945 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12946
03408648 12947 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12948
03408648 12949 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12950
e2abce01
JB
129512011-03-31 Juanma Barranquero <lekktu@gmail.com>
12952
12953 * xdisp.c (redisplay_internal): Fix prototype.
12954
63696a73 129552011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12956
63696a73 12957 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12958 (try_scrolling): Use it when setting scroll_limit.
12959 Limit scrolling to 100 screen lines.
63696a73
EZ
12960 (redisplay_window): Even when falling back on "recentering",
12961 position point in the window according to scroll-conservatively,
12962 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12963
12964 (try_scrolling): When point is above the window, allow searching
12965 as far as scroll_max, or one screenful, to compute vertical
12966 distance from PT to the scroll margin position. This prevents
12967 try_scrolling from unnecessarily failing when
12968 scroll-conservatively is set to a value slightly larger than the
12969 window height. Clean up the case of PT below the margin at bottom
12970 of window: scroll_max can no longer be INT_MAX. When aggressive
12971 scrolling is in use, don't let point enter the opposite scroll
12972 margin as result of the scroll.
12973 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12974 threshold of 100 lines for never-recentering scrolling.
12975
e4cc2dfc
JB
129762011-03-31 Juanma Barranquero <lekktu@gmail.com>
12977
12978 * dispextern.h (move_it_by_lines):
12979 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12980 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12981 (message_log_check_duplicate): Remove parameters `prev_bol' and
12982 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12983 (redisplay_internal): Remove parameter `preserve_echo_area',
12984 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12985
12986 * indent.c (Fvertical_motion):
12987 * window.c (window_scroll_pixel_based, Frecenter):
12988 Don't pass `need_y_p' to `move_it_by_lines'.
12989
1c470562
SM
129902011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12991
44f230aa
SM
12992 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12993 steal a few bits to be more compact.
12994 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12995 Remove unneeded casts.
12996
1c470562
SM
12997 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12998
888adce9
ZK
129992011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13000
13001 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13002 binding" message (bug#7967).
13003
f838ed7b
PE
130042011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13005
77861b95
PE
13006 Fix more problems found by GCC 4.6.0's static checks.
13007
de6dbc14
PE
13008 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13009 Remove unused local var.
13010
f838ed7b
PE
13011 * editfns.c (Fmessage_box): Remove unused local var.
13012
792c7b2b
PE
13013 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13014 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13015 Omit unused local vars.
c499e557 13016 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13017 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13018 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13019 Omit unused local var.
13020
ba0165e1
PE
13021 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13022 Don't assume string length fits in int.
32ad8845 13023 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13024 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13025
3c59b4c9
PE
13026 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13027 instead of alloca (Bug#8344).
13028
a3eed478 13029 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13030 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13031
eb4d412d
PE
13032 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13033
1658b401
PE
13034 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13035 concerns.
13036
13037 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13038
13039 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13040
9a2c6e05
PE
13041 * keyboard.c (syms_of_keyboard): Use the same style as later
13042 in this function when indexing through an array. This also
13043 works around GCC bug 48267.
13044
03d0a109
PE
13045 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13046
44f730c8
PE
13047 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13048
fe75f926
PE
13049 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13050 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13051
ffa8c828
PE
13052 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13053 This avoids undefined behavior on integer overflow, and is a bit
13054 more convenient anyway since it is compared to a size_t variable.
13055
c5101a77
PE
13056 Variadic C functions now count arguments with size_t, not int.
13057 This avoids an unnecessary limitation on 64-bit machines, which
13058 caused (substring ...) to crash on large vectors (Bug#8344).
13059 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13060 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13061 All variadic functions and their callers changed accordingly.
c5101a77
PE
13062 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13063 * data.c (arith_driver, float_arith_driver): Likewise.
13064 * editfns.c (general_insert_function): Likewise.
13065 * eval.c (struct backtrace.nargs, interactive_p)
13066 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13067 (funcall_lambda, mark_backtrace): Likewise.
13068 * fns.c (concat): Likewise.
13069 * frame.c (x_set_frame_parameters): Likewise.
13070 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13071 0 if not found, not -1. All callers changed.
13072
dd3f25f7
PE
13073 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13074 (stack_copy_size): Now size_t, not int.
13075 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13076
461c2ab9
JB
130772011-03-28 Juanma Barranquero <lekktu@gmail.com>
13078
13079 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13080 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13081 All callers changed.
13082
13083 * lisp.h (multibyte_char_to_unibyte):
13084 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13085 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13086 * character.h (CHAR_TO_BYTE8):
13087 * cmds.c (internal_self_insert):
13088 * editfns.c (general_insert_function):
13089 * keymap.c (push_key_description):
13090 * search.c (Freplace_match):
13091 * xdisp.c (message_dolog, set_message_1): All callers changed.
13092
f6d62986
SM
130932011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13094
13095 * keyboard.c (safe_run_hook_funcall): New function.
13096 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13097 don't set the hook to nil, but remove the offending function instead.
13098 (Qcommand_hook_internal): Remove, unused.
13099 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13100 Vcommand_hook_internal.
13101
13102 * eval.c (enum run_hooks_condition): Remove.
13103 (funcall_nil, funcall_not): New functions.
13104 (run_hook_with_args): Call each function through a `funcall' argument.
13105 Remove `cond' argument, now redundant.
13106 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13107 (Frun_hook_with_args_until_failure): Adjust accordingly.
13108 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13109
1db5b1ad
JB
131102011-03-28 Juanma Barranquero <lekktu@gmail.com>
13111
13112 * dispextern.h (string_buffer_position): Remove declaration.
13113
13114 * print.c (strout): Remove parameter `multibyte', unused since
13115 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13116
13117 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13118 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13119 All callers changed.
13120
13121 * w32.c (_wsa_errlist): Use braces for struct initializers.
13122
13123 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13124 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13125 All callers changed.
13126 (string_buffer_position): Likewise. Also, make static (it's never
13127 used outside xdisp.c).
13128 (cursor_row_p): Remove parameter `w', unused since
13129 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13130 (decode_mode_spec): Remove parameter `precision', introduced during
13131 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13132 All callers changed.
13133
5ffb62aa
JD
131342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13135
13136 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13137
461c2ab9 131382011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13139
13140 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13141 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13142 (ns_update_auto_hide_menu_bar): New functions.
13143 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13144 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13145 ns_constrain_all_frames.
13146 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13147 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13148
5c380ffb
JD
131492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13150
13151 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13152
9af30bdf
GM
131532011-03-27 Glenn Morris <rgm@gnu.org>
13154
13155 * syssignal.h: Replace RETSIGTYPE with void.
13156 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13157 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13158 Replace SIGTYPE with void everywhere.
13159 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13160 * s/template.h (SIGTYPE): Remove commented out definition.
13161
e2abce01
JB
131622011-03-26 Eli Zaretskii <eliz@gnu.org>
13163
13164 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13165 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13166
f868cd8a
JB
131672011-03-26 Juanma Barranquero <lekktu@gmail.com>
13168
59eb0929
JB
13169 * w32.c (read_unc_volume): Use parameter `henum', instead of
13170 global variable `wget_enum_handle'.
13171
13172 * keymap.c (describe_vector): Remove parameters `indices' and
13173 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13174 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13175
f868cd8a
JB
13176 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13177
13178 * keyboard.c (timer_check): Remove parameter `do_it_now',
13179 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13180 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13181 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13182
13183 * keyboard.c (read_char):
13184 * w32menu.c (w32_menu_display_help):
13185 * xmenu.c (show_help_event, menu_help_callback):
13186 Adjust calls to `show_help_echo'.
13187
13188 * gtkutil.c (xg_maybe_add_timer):
13189 * keyboard.c (readable_events):
13190 * process.c (wait_reading_process_output):
13191 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13192
13193 * insdel.c (adjust_markers_gap_motion):
13194 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13195 (gap_left, gap_right): Don't call it.
13196
2ecf6fdb
CY
131972011-03-25 Chong Yidong <cyd@stupidchicken.com>
13198
13199 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13200 incurred during fontification.
13201
6b1f9ba4
JB
132022011-03-25 Juanma Barranquero <lekktu@gmail.com>
13203
13204 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13205 (DEFVAR_PER_BUFFER): Don't pass it.
13206
13207 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13208 (scrolling_window): Don't pass it.
13209
0f4a96b5
JB
132102011-03-25 Juanma Barranquero <lekktu@gmail.com>
13211
13212 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13213
13214 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13215 and `suffix'.
13216 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13217 of variables specific to SELinux and computation of `encoded_absname'.
13218
13219 * image.c (XPutPixel): Remove unused variable `height'.
13220
13221 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13222
13223 * unexw32.c (get_section_info): Remove unused variable `section'.
13224
13225 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13226 (system_process_attributes): Remove unused variable `sess'.
13227 (sys_read): Remove unused variable `err'.
13228
13229 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13230 (w32_wnd_proc): Remove unused variable `isdead'.
13231 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13232 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13233 (x_create_tip_frame): Remove unused variable `tem'.
13234
13235 * w32inevt.c (w32_console_read_socket):
13236 Remove unused variable `no_events'.
13237
13238 * w32term.c (x_draw_composite_glyph_string_foreground):
13239 Remove unused variable `width'.
13240
1149507c
JB
132412011-03-24 Juanma Barranquero <lekktu@gmail.com>
13242
13243 * w32term.c (x_set_glyph_string_clipping):
13244 Don't pass uninitialized region to CombineRgn.
13245
9c88f339
JB
132462011-03-23 Juanma Barranquero <lekktu@gmail.com>
13247
13248 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13249 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13250 (Fx_close_connection): Remove unused variable `i'.
13251
13252 * w32font.c (w32font_draw): Return number of glyphs.
13253 (w32font_open_internal): Remove unused variable `i'.
13254 (w32font_driver): Add missing initializer.
13255
13256 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13257 (fill_in_menu): Remove unused variable `items_added'.
13258
13259 * w32term.c (last_mouse_press_frame): Remove static global variable.
13260 (w32_clip_to_row): Remove unused variable `f'.
13261 (x_delete_terminal): Remove unused variable `i'.
13262
13263 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13264 (NOTHING): Remove unused static global variable.
13265 (uniscribe_check_otf): Remove unused variable `table'.
13266 (uniscribe_font_driver): Add missing initializers.
13267
dee091a3
JD
132682011-03-23 Julien Danjou <julien@danjou.info>
13269
13270 * term.c (Fsuspend_tty, Fresume_tty):
13271 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13272 * window.c (temp_output_buffer_show):
13273 * insdel.c (signal_before_change):
13274 * frame.c (Fhandle_switch_frame):
13275 * fileio.c (Fdo_auto_save):
13276 * emacs.c (Fkill_emacs):
13277 * editfns.c (save_excursion_restore):
13278 * cmds.c (internal_self_insert):
13279 * callint.c (Fcall_interactively):
13280 * buffer.c (Fkill_all_local_variables):
13281 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13282 Use Frun_hooks.
0f4a96b5 13283 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13284 unconditionally since it does the check itself.
dee091a3 13285
2c520ab5 132862011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13287
c9c49752
PE
13288 Fix more problems found by GCC 4.5.2's static checks.
13289
8abc3f12
PE
13290 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13291 the first time through the loop, since we know p0 < p1 then.
13292 This also avoids a gcc -Wstrict-overflow warning.
13293
a2d26660
PE
13294 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13295 leading to a memory leak, possible in functions like
13296 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13297 of objects (Bug#8318).
a2d26660 13298
916c72e9
PE
13299 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13300 that could (at least in theory) be that large.
13301
19ab8a18
PE
13302 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13303 This is less likely to overflow, and avoids undefined behavior if
13304 overflow does occur. All callers changed. Use strtoul to scan
13305 for the unsigned long integer.
b7cbbd6f
PE
13306 (pint2hrstr): Simplify and tune code slightly.
13307 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13308
f0641eff
PE
13309 * scroll.c (do_scrolling): Work around GCC bug 48228.
13310 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13311
7f650bb9
PE
13312 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13313 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13314 (validate_x_resource_name): Simplify count usage.
13315 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13316
37dd57d1
PE
13317 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13318 fail (Bug#8306).
81e56e61 13319
699979fc 13320 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13321
401bf9b4
PE
13322 * process.c (Fmake_network_process): Use socklen_t, not int,
13323 where POSIX says socklen_t is required in portable programs.
13324 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13325 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13326 (Fmake_network_process, server_accept_connection):
13327 (wait_reading_process_output, read_process_output):
13328 Likewise.
13329
b93aacde
PE
13330 * process.c: Rename or move locals to avoid shadowing.
13331 (list_processes_1, Fmake_network_process):
13332 (read_process_output_error_handler, exec_sentinel_error_handler):
13333 Rename or move locals.
4dc343ee 13334 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13335 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13336 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13337 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13338 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13339
af8a867c 13340 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13341 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13342 Include tparam.h instead, since it declares them.
af8a867c
PE
13343 * cm.h (PC): Remove extern decl; tparam.h now does this.
13344 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13345 * terminfo.c: Include tparam.h, to check interfaces.
13346 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13347 (tparam): Adjust signature to match interface in tparam.h;
13348 this removes some undefined behavior. Check that outstring and len
13349 are zero, which they always are with Emacs.
13350 * tparam.h (PC, BC, UP): New extern decls.
13351
0248044d 13352 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13353 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13354
8ff096c1 13355 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13356 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13357 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13358 (ftfont_list): Remove unused local.
49eaafba
PE
13359 (get_adstyle_property, ftfont_pattern_entity):
13360 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13361 Rename locals to avoid shadowing.
8ff096c1 13362
e2be39f6
PE
13363 * xfont.c (xfont_list_family): Mark var as initialized.
13364
c9735e30
PE
13365 * xml.c (make_dom): Now static.
13366
8f5201ae
PE
13367 * composite.c (composition_compute_stop_pos): Rename local to
13368 avoid shadowing.
b246f932
PE
13369 (composition_reseat_it): Remove unused locals.
13370 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13371 (composition_update_it): Mark var as initialized.
11b61122
PE
13372 (find_automatic_composition): Mark vars as initialized,
13373 with a FIXME (Bug#8290).
8f5201ae 13374
760fbc2c
PE
13375 character.h: Rename locals to avoid shadowing.
13376 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13377 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13378 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13379 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13380 to avoid shadowing.
13381
ff08eb85
PE
13382 * textprop.c (property_change_between_p): Remove; unused.
13383
fc7bf025
PE
13384 * intervals.c (interval_start_pos): Now static.
13385
235d7abc
PE
13386 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13387
44f230aa
SM
13388 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13389 Rename locals to avoid shadowing.
3e7d6594 13390
50060332
PE
13391 * sound.c (wav_play, au_play, Fplay_sound_internal):
13392 Fix pointer signedness.
d01f234b 13393 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13394 (wav_play): Initialize a variable to 0, to prevent undefined
13395 behavior (Bug#8278).
50060332 13396
c4fc4e30
PE
13397 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13398
918436ed
PE
13399 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13400
c939f91b
PE
13401 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13402 clobbering (Bug#8298).
b9c7f648
PE
13403 * sysdep.c (sys_subshell): Likewise.
13404 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13405
6bd8c144
PE
13406 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13407 This should get cleaned up, so that child_setup has the
13408 same signature on all platforms.
13409
7710357c 13410 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13411 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13412
c59da222
CY
134132011-03-22 Chong Yidong <cyd@stupidchicken.com>
13414
13415 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13416 not to be necessary, and produces flickering.
13417
66b87493
GM
134182011-03-20 Glenn Morris <rgm@gnu.org>
13419
13420 * config.in: Remove file.
13421
45b6f6d5
JB
134222011-03-20 Juanma Barranquero <lekktu@gmail.com>
13423
13424 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13425 are now in src/globals.h.
13426 (syms_of_minibuf): Remove spurious & from previous change.
13427
cd394be1 134282011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13429
13430 * minibuf.c (completing-read-function): New variable.
13431 (completing-read-default): Rename from completing-read.
13432 (completing-read): Call completing-read-function.
13433
b14e3e21
CY
134342011-03-19 Juanma Barranquero <lekktu@gmail.com>
13435
13436 * xfaces.c (Fx_load_color_file):
13437 Read color file from absolute filename (bug#8250).
13438
f2b726e6
JB
134392011-03-19 Juanma Barranquero <lekktu@gmail.com>
13440
13441 * makefile.w32-in: Update dependencies.
13442
09f6ff02
EZ
134432011-03-17 Eli Zaretskii <eliz@gnu.org>
13444
13445 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13446
29a6015a
PE
134472011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13448
a3a6c54e
PE
13449 Fix more problems found by GCC 4.5.2's static checks.
13450
b766f867
PE
13451 * process.c (make_serial_process_unwind, send_process_trap):
13452 (sigchld_handler): Now static.
13453
be02381c
PE
13454 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13455 That way, the code declares only the vars that it needs.
13456 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13457 * s/cygwin.h (PTY_ITERATION): Likewise.
13458 * s/darwin.h (PTY_ITERATION): Likewise.
13459 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13460
57048744
PE
13461 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13462 * process.c (allocate_pty): Don't declare stb unless it's needed.
13463
7914961c 13464 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13465 (CONSTANTLIM): Remove; unused.
13466 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13467 Define only if needed.
7914961c 13468
b3967b18
PE
13469 * unexelf.c (unexec): Name an expression,
13470 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13471 Use a different way to cause a compilation error if anyone uses
13472 n rather than nn, a way that does not involve shadowing.
73366a00 13473 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13474
29a6015a
PE
13475 * deps.mk (unexalpha.o): Remove; unused.
13476
43cfc33e 13477 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13478 * unexec.h: New file.
ce701a33
PE
13479 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13480 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13481 Depend on unexec.h.
13482 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13483 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13484 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13485 Change as necessary to match prototype in unexec.h.
ce701a33 13486
01f44d5a
PE
13487 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13488 shadowing.
4f63c6bb 13489 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13490
a6670b0b
PE
13491 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13492 Rename locals to avoid shadowing.
13493
cef2010d 13494 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13495 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13496
d4d7173a
PE
13497 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13498
f08b802a
PE
13499 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13500 warning when compiling print.c.
13501
3ddb0639
PE
13502 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13503 instead of using an uninitialized var.
5ad03b97 13504 (font_sort_entities): Mark var as initialized.
3ddb0639 13505
170a2692
PE
13506 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13507
e663c700
PE
13508 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13509 pointers to constants.
89bc529a 13510 (font_parse_fcname): Remove unused vars.
7b81e2d0 13511 (font_delete_unmatched): Now static.
ea838e10 13512 (font_get_spec): Remove; unused.
13a547c6
PE
13513 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13514 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13515 Rename or move locals to avoid shadowing.
e663c700 13516
2a80c887 13517 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13518 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13519
1384fa33 13520 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13521 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13522
8b2c52e9
PE
13523 * alloc.c (mark_backtrace): Move decl from here ...
13524 * lisp.h: ... to here, so that it can be checked.
13525
475545b5 13526 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13527 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13528 (lisp_indirect_variable): Name an expression,
13529 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13530 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13531
b1349114 13532 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13533 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13534 Use const pointer when appropriate.
b1349114 13535
a2928364
PE
13536 * lisp.h (get_system_name, get_operating_system_release):
13537 Move decls here, to check interfaces.
13538 * process.c (get_operating_system_release): Move decl to lisp.h.
13539 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13540 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13541 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13542 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13543 (Fformat_time_string, Fencode_time, Finsert_char):
13544 (Ftranslate_region_internal, Fformat):
13545 Rename or remove local vars to avoid shadowing.
9710023e 13546 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13547
a415e694
PE
13548 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13549 avoid shadowing.
13550
8ef4622d
PE
13551 * lisp.h (eassert): Check that the argument compiles, even if
13552 ENABLE_CHECKING is not defined.
13553
946f9a5b
PE
13554 * data.c (Findirect_variable): Name an expression, to avoid
13555 gcc -Wbad-function-cast warning.
112396d6 13556 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13557 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13558 (Fmake_variable_buffer_local, Fmake_local_variable):
13559 Mark variables as initialized.
52746918 13560 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13561
e5aab7e7 13562 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13563 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13564 Rename locals to avoid shadowing.
dff45157
PE
13565 (mark_stack): Move local variables into the #ifdef region where
13566 they're used.
7bc26fdb
PE
13567 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13568 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13569 needed otherwise.
13570 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13571 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13572 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13573
e5aab7e7
PE
13574 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13575 avoids undefined behavior in theory.
13576
4da60324
PE
13577 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13578
88043301
PE
13579 Use functions, not macros, for up- and down-casing (Bug#8254).
13580 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13581 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13582 to use the following functions instead of these macros.
13583 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13584 EMACS_INT, since callers assume the returned value fits in int.
13585 (upcase1): Likewise, for UPCASE_TABLE.
13586 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13587 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13588 the race-condition problem in the old DOWNCASE.
88043301 13589
19ed5445
PE
13590 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13591 Rename locals to avoid shadowing.
13592 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13593 (regex_compile, re_search_2, re_match_2_internal):
13594 Remove unused local vars.
952db0d7
PE
13595 (FREE_VAR): Rewrite so as not to use empty "else",
13596 which gcc can warn about.
da053e48 13597 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13598 (RETALLOC_IF): Define only if needed.
13599 (WORDCHAR_P): Likewise. This one is never needed, but is used
13600 only in a comment talking about a compiler bug, so put inside
13601 the #if 0 of that comment.
13602 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13603 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13604 Remove; unused.
19ed5445 13605
1f3561e4 13606 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13607 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13608 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13609
ded6f8f7
PE
13610 * search.c (simple_search): Remove unused var.
13611
dbd37a95
PE
13612 * dired.c (compile_pattern): Move decl from here ...
13613 * lisp.h: ... to here, so that it can be checked.
13614 (struct re_registers): New forward decl.
13615
7e47afad
PE
13616 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13617
85f24f61
PE
13618 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13619 All uses changed.
13620 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13621 Rename locals to avoid shadowing.
5671df8f 13622 (Fvertical_motion): Mark locals as initialized.
85f24f61 13623
181aa2be 13624 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13625 (casify_region): Mark local as initialized.
181aa2be 13626
930d429c
PE
13627 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13628
7082eac6
PE
13629 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13630 New macros, so that the caller can use some names other than
13631 gcpro1, gcpro2, etc.
13632 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13633 of the new macros.
13634 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13635 argument, for consistency with GCPRO2_VAR, etc: it is now the
13636 prefix of the variable, not the variable itself. All uses
13637 changed.
38b2c076
PE
13638 * dired.c (directory_files_internal, file_name_completion):
13639 Rename locals to avoid shadowing.
13640
15206ed9
PE
13641 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13642 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13643 dired.c's scmp function, had undefined behavior.
13644 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13645 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13646 * buffer.h: ... to here, because these macros use current_buffer,
13647 and the new implementation with inline functions needs to have
13648 current_buffer in scope now, rather than later when the macros
13649 are used.
13650 (downcase, upcase1): New static inline functions.
13651 (DOWNCASE, UPCASE1): Reimplement using these functions.
13652 This avoids undefined behavior in expressions like
13653 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13654 from race conditions in accessing the global variables
13655 case_temp1 and case_temp2.
13656 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13657 * lisp.h (case_temp1, case_temp2): Remove their decls.
13658 * character.h (ASCII_CHAR_P): Move from here ...
13659 * lisp.h: ... to here, so that the inline functions mentioned
13660 above can use them.
13661
4a6bea26
PE
13662 * dired.c (directory_files_internal_unwind): Now static.
13663
f14b7e14
PE
13664 * fileio.c (file_name_as_directory, directory_file_name):
13665 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13666 Now static.
2893f146
PE
13667 (file_name_as_directory): Use const pointers when appropriate.
13668 (Fexpand_file_name): Likewise. In particular, newdir might
13669 point at constant storage, so make it a const pointer.
fd4ead52 13670 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13671 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13672 signedness issues.
f839df0c
PE
13673 (Fset_file_times, Finsert_file_contents, auto_save_error):
13674 Rename locals to avoid shadowing.
f14b7e14 13675
5716756e 13676 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13677 (Ftry_completion, Fall_completions): Rename or remove locals
13678 to avoid shadowing.
5716756e 13679
b4c3046a
PE
13680 * marker.c (bytepos_to_charpos): Remove; unused.
13681
b45db522
PE
13682 * lisp.h (verify_bytepos, count_markers): New decls,
13683 so that gcc does not warn that these functions aren't declared.
13684
85876d07
PE
13685 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13686 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13687 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13688 (copy_text): Remove unused local var.
85876d07 13689
03d78a21 13690 * filelock.c (within_one_second): Now static.
b3dd38ab 13691 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13692
5df8f01b
PE
13693 * buffer.c (fix_overlays_before): Mark locals as initialized.
13694 (fix_start_end_in_overlays): Likewise. This function should be
13695 simplified by using pointers-to-pointers, but that's a different
13696 matter.
b1d876f1 13697 (switch_to_buffer_1): Now static.
8f54f30a
PE
13698 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13699 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13700
a70072c9 13701 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13702 Fix pointer signedness issue.
edced198
PE
13703 (sys_subshell): Mark local as volatile if checking for lint,
13704 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13705 (MAXPATHLEN): Define only if needed.
a70072c9 13706
a0977c44
PE
13707 * process.c (serial_open, serial_configure): Move decls from here ...
13708 * systty.h: ... to here, so that they can be checked.
13709
a884fdcc
PE
13710 * fns.c (get_random, seed_random): Move extern decls from here ...
13711 * lisp.h: ... to here, so that they can be checked.
13712
604efe86 13713 * sysdep.c (reset_io): Now static.
b8950c94 13714 (wait_for_termination_signal): Remove; unused.
604efe86 13715
38fc62d9
PE
13716 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13717 (copy_keymap_item, append_key, push_text_char_description):
13718 Now static.
1004a21a 13719 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13720 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13721 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13722 (describe_map_tree):
13723 Rename locals to avoid shadowing.
38fc62d9 13724
2f2650da
PE
13725 * keyboard.c: Declare functions static if they are not used elsewhere.
13726 (echo_char, echo_dash, cmd_error, top_level_2):
13727 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13728 (read_char, kbd_buffer_get_event, make_lispy_position):
13729 (make_lispy_event, make_lispy_movement, apply_modifiers):
13730 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13731 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13732 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13733 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13734 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13735
a053e86c 13736 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13737 (mark_kboards): Move decl here ...
13738 * alloc.c (mark_kboards): ... from here.
a053e86c 13739
4752793e
PE
13740 * lisp.h (force_auto_save_soon): New decl.
13741
74f10ca7 13742 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13743 (DEFINE_DUMMY_FUNCTION): New macro.
13744 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13745 Use it.
c03cd23f
PE
13746 (main): Add casts to avoid warnings
13747 if GCC considers string literals to be constants.
74f10ca7 13748
022e70d4
PE
13749 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13750
59d6fe83
PE
13751 * dbusbind.c: Pointer signedness fixes.
13752 (xd_signature, xd_append_arg, xd_initialize):
13753 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13754 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13755 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13756 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13757
78320123
PE
13758 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13759 if GCC considers string literals to be constants.
49cebcca 13760 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13761
35ac2a97
SM
137622011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13763
fb103ca9
SM
13764 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13765 (print_preprocess, print_object): New macro to fix last change.
13766
35ac2a97
SM
13767 * print.c (print_preprocess): Don't forget font objects.
13768
62973b41
JB
137692011-03-16 Juanma Barranquero <lekktu@gmail.com>
13770
13771 * emacs.c (USAGE3): Doc fixes.
13772
0e48bb22
AS
137732011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13774
13775 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13776 structure.
13777
7684e57b
JB
137782011-03-14 Juanma Barranquero <lekktu@gmail.com>
13779
13780 * lisp.h (VWindow_system, Qfile_name_history):
13781 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13782 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13783 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13784
13785 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13786 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13787
13788 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13789 * w32console.c (detect_input_pending, read_input_pending)
13790 (encode_terminal_code):
13791 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13792 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13793 (w32_system_caret_y, Qfile_name_history):
13794 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13795 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13796 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13797 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13798 * w32proc.c (Qlocal, report_file_error):
13799 * w32term.c (Vwindow_system, updating_frame):
13800 * w32uniscribe.c (initialized, uniscribe_font_driver):
13801 Remove unneeded extern declarations.
13802
2aa46d6c
CY
138032011-03-14 Chong Yidong <cyd@stupidchicken.com>
13804
c96bbc66 13805 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13806
cffc6f3b
CY
138072011-03-13 Chong Yidong <cyd@stupidchicken.com>
13808
13809 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13810 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13811 These macros can no longer be used for assignment.
13812
44f230aa
SM
13813 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13814 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13815 (record_buffer_markers, fetch_buffer_markers): New functions for
13816 recording and fetching special buffer markers.
13817 (set_buffer_internal_1, set_buffer_temp): Use them.
13818
13819 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13820
13821 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13822
13823 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13824 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13825
13826 * xdisp.c (hscroll_window_tree):
13827 (reconsider_clip_changes): Use PT instead of BUF_PT.
13828
d251f04b
EZ
138292011-03-13 Eli Zaretskii <eliz@gnu.org>
13830
13831 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13832 $(EMACS_ROOT)/lib/intprops.h.
13833
f0c77cd1
PE
138342011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13835
3eca4629
PE
13836 Fix more problems found by GCC 4.5.2's static checks.
13837
7c86ee98
PE
13838 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13839 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13840 (xg_free_frame_widgets): Make it clear that a local variable is
13841 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13842 (gdk_window_get_screen): Make it clear that this macro is needed
13843 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13844 (int_gtk_range_get_value): New function, which avoids a diagnostic
13845 from gcc -Wbad-function-cast.
13846 (xg_set_toolkit_scroll_bar_thumb): Use it.
13847 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13848 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13849 (get_utf8_string, xg_get_file_with_chooser):
13850 Rename locals to avoid shadowing.
13851 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13852
41729b81
PE
13853 * xgselect.c (xg_select): Remove unused var.
13854
f0c77cd1
PE
13855 * image.c (four_corners_best): Mark locals as initialized.
13856 (gif_load): Initialize transparent_p to zero (Bug#8238).
13857 Mark another local as initialized.
ec6cf4c6 13858 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13859
ce0ad53d 13860 * image.c (clear_image_cache): Now static.
d5d5a617 13861 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13862 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13863 (x_edge_detection): Remove unnecessary cast that
13864 gcc -Wbad-function-cast diagnoses.
2037898d 13865 (gif_load): Fix pointer signedness.
6ae141d6
PE
13866 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13867 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13868
33383987 138692011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13870
d32df629
PE
13871 Improve quality of tests for time stamp overflow.
13872 For example, without this patch (encode-time 0 0 0 1 1
13873 1152921504606846976) returns the obviously-bogus value (-948597
13874 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13875 reports time overflow. See
13876 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13877 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13878 * editfns.c: Include limits.h and intprops.h.
13879 (TIME_T_MIN, TIME_T_MAX): New macros.
13880 (time_overflow): Move earlier, to before first use.
13881 (hi_time, lo_time): New functions, for an accurate test for
13882 out-of-range times.
13883 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13884 (Fget_internal_run_time): Don't assume time_t fits in int.
13885 (make_time): Use list2 instead of Fcons twice.
13886 (Fdecode_time): More accurate test for out-of-range times.
13887 (check_tm_member): New function.
13888 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13889 (lisp_time_argument): Don't rely on undefined left-shift and
13890 right-shift behavior when checking for time stamp overflow.
8be6f318 13891
fe31d94c
PE
13892 * editfns.c (time_overflow): New function, refactoring common code.
13893 (Fformat_time_string, Fdecode_time, Fencode_time):
13894 (Fcurrent_time_string): Use it.
13895
8be6f318
PE
13896 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13897 * dired.c (make_time): Move to ...
13898 * editfns.c (make_time): ... here.
13899 * systime.h: Note the move.
13900
09d9db2c 139012011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13902
126bc0dc
YM
13903 * fringe.c (update_window_fringes): Remove unused variables.
13904
c47cbdfd
YM
13905 * unexmacosx.c (copy_data_segment): Also copy __got section.
13906 (Bug#8223)
13907
7ac80be9
EZ
139082011-03-12 Eli Zaretskii <eliz@gnu.org>
13909
c96bbc66 13910 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13911 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13912 Constify `char *' arguments and their references according to
13913 prototypes in tparam.h.
13914
ecb0f94d 13915 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13916
7ac80be9
EZ
13917 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13918 Adapt all references accordingly.
13919
13920 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13921
ef1fd07e
TT
139222011-03-11 Tom Tromey <tromey@redhat.com>
13923
13924 * buffer.c (syms_of_buffer): Remove obsolete comment.
13925
7ef4b50c
EZ
139262011-03-11 Eli Zaretskii <eliz@gnu.org>
13927
13928 * termhooks.h (encode_terminal_code): Declare prototype.
13929
13930 * msdos.c (encode_terminal_code): Don't declare prototype.
13931
13932 * term.c (encode_terminal_code): Now external again, used by
13933 w32console.c and msdos.c.
13934
44f230aa
SM
13935 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13936 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13937
4b1ec863 139382011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13939
1714f52b 13940 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13941
4b1ec863
PE
13942 * fringe.c (update_window_fringes): Mark locals as initialized
13943 (Bug#8227).
13944 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13945
524c7aa6
PE
13946 * alloc.c (mark_fringe_data): Move decl from here ...
13947 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13948 to check its interface.
13949 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13950
a5c0af81 13951 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13952 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13953 (fontset_font): Mark local as initialized.
a9a06e0b 13954 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13955
b4716021
PE
13956 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13957
811e9bac 13958 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13959 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13960 (x_own_selection, Fx_disown_selection_internal): Rename locals
13961 to avoid shadowing.
13962 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13963
7e3ab302
PE
13964 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13965 so that the caller can use some name other than gcpro1.
13966 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13967 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13968 (Fx_backspace_delete_keys_p):
13969 Use them to avoid shadowing, and rename vars to avoid shadowing.
13970 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13971 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13972 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13973 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13974 Remove unused locals.
7e3ab302
PE
13975 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13976 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13977 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13978 macros.
f78faa98 13979
e2b13473
PE
13980 * xterm.h (x_mouse_leave): New decl.
13981
77f23912
PE
13982 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13983 Remove unused functions.
cdf4ba58
PE
13984 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13985 (x_calc_absolute_position): Now static.
7411c686 13986 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13987 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13988 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13989 unless they are used.
38d0b34a
PE
13990 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13991 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13992 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13993 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13994 (x_error_catcher, x_connection_closed, x_error_handler):
13995 (x_error_quitter, xembed_send_message, x_iconify_frame):
13996 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13997 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13998 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13999
44f230aa
SM
14000 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14001 Rename or move locals to avoid shadowing.
6b463e58 14002 (tty_defined_color, merge_face_heights): Now static.
5967d051 14003 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14004 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14005 does not deduce is never used uninitialized.
73719eba
PE
14006 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14007 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14008
426994c3 14009 * terminal.c (store_terminal_param): Now static.
5489860b 14010
032f1620 14011 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14012 (set_frame_menubar): Remove unused local.
d4323972 14013 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14014 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14015 since they might point to immutable storage.
281585b0
PE
14016 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14017 since it's unused otherwise.
032f1620 14018
367c19e5 14019 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14020 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14021 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14022 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14023 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14024 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14025 does not deduce are never used uninitialized.
70739cbe 14026
07b48fa9
PE
14027 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14028
8868a238 14029 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14030 * window.c (window_loop, size_window):
14031 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14032
7e5cf297 14033 * window.c (display_buffer): Now static.
d6550a9f
PE
14034 (size_window): Mark variables that gcc -Wuninitialized
14035 does not deduce are never used uninitialized.
a586633d
PE
14036 * window.h (check_all_windows): New decl, to forestall
14037 gcc -Wmissing-prototypes diagnostic.
5b555da1 14038 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14039
f6095868
PE
14040 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14041 shadowing.
14042 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14043 Include <limits.h>.
14044 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14045 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14046 (load_charset_map): Mark variables that gcc -Wuninitialized
14047 does not deduce are never used uninitialized.
53df7c11 14048 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14049
f38b440c
PE
14050 * coding.c (coding_set_source, coding_set_destination):
14051 Use "else { /* comment */ }" rather than "else /* comment */;"
14052 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14053 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14054 a block, when the outer 'i' will do.
14055 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14056 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14057 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14058 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14059 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14060 Rename locals to avoid shadowing.
14061 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14062 * coding.c (emacs_mule_char, encode_invocation_designation):
14063 Now static, since they're not used elsewhere.
413bb2db 14064 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14065 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14066 (decode_coding_emacs_mule): Mark variables that gcc
14067 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14068 (detect_coding_iso_2022): Initialize a local variable that might
14069 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14070 this initialization is needed. (Bug#8211)
5f58e762
PE
14071 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14072 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14073 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14074 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14075 Remove unused macros.
f38b440c 14076
232b38b9 14077 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14078 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14079 * character.c (string_count_byte8): Likewise.
232b38b9 14080
fb90da1b
PE
14081 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14082 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14083
fb93dbc2
PE
14084 * chartab.c (copy_sub_char_table): Now static, since it's not used
14085 elsewhere.
5c156ace
PE
14086 (sub_char_table_ref_and_range, char_table_ref_and_range):
14087 Rename locals to avoid shadowing.
bbcd0949 14088 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14089
7d3b3862 14090 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14091 (BIDI_BOB): Remove unused macro.
7d3b3862 14092
6be7d3da
PE
14093 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14094 deduce are never used uninitialized.
c2ed9c8b 14095 * term.c (encode_terminal_code): Likewise.
6be7d3da 14096
75f8807f 14097 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14098
50938595
PE
14099 * tparam.h: New file.
14100 * term.c, tparam.h: Include it.
14101 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14102 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14103 Move these decls to tparam.h, and make them agree with what
14104 is actually in tparam.c. The previous trick of using incompatible
14105 decls in different modules does not conform to the C standard.
14106 All callers of tparam changed to use tparam's actual API.
14107 * tparam.c (tparam1, tparam, tgoto):
14108 Use const pointers where appropriate.
14109
fbceeba2
PE
14110 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14111 * cm.h (struct cm): Likewise.
14112 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14113 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14114 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14115 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14116 (turn_on_face, init_tty): Likewise.
14117 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14118
7f3f1250
PE
14119 * term.c (term_mouse_position): Rename local to avoid shadowing.
14120
e6ca6543
PE
14121 * alloc.c (mark_ttys): Move decl from here ...
14122 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14123
c40f8d15
AS
141242011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14125
14126 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14127
cfe0661d
JB
141282011-03-09 Juanma Barranquero <lekktu@gmail.com>
14129
14130 * search.c (compile_pattern_1): Remove argument regp, unused since
14131 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14132 (compile_pattern): Don't pass it.
14133
0afb4571
J
141342011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14135
14136 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14137 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14138 for ! HAVE_GTK3.
14139 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14140
14141 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14142
14143 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14144 gdk_window_get_screen, gdk_window_get_geometry,
14145 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14146 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14147 (xg_get_pixbuf_from_pixmap): New function.
14148 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14149 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14150 Call xg_get_pixbuf_from_pixmap instead of
14151 gdk_pixbuf_get_from_drawable.
14152 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14153 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14154 (xg_check_special_colors): Use GtkStyleContext and its functions
14155 for HAVE_GTK3.
14156 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14157 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14158 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14159 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14160 Call gtk_widget_get_preferred_size.
0afb4571
J
14161 (xg_frame_resized): gdk_window_get_geometry only takes 5
14162 parameters.
44f230aa
SM
14163 (xg_win_to_widget, xg_event_is_for_menubar):
14164 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14165 (xg_set_widget_bg): New function.
14166 (delete_cb): New function.
895009e1 14167 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14168 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14169 (xg_set_background_color): Call xg_set_widget_bg.
14170 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14171 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14172 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14173 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14174 if ! HAVE_GTK3.
14175 (update_frame_tool_bar): Call gtk_widget_hide.
14176 (xg_initialize): Use GDK_KEY_g.
14177
14178 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14179 if ! HAVE_GTK3
14180 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14181
14182 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14183 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14184 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14185
1c2cc4ef
JB
141862011-03-08 Juanma Barranquero <lekktu@gmail.com>
14187
14188 * w32xfns.c (select_palette): Check success of RealizePalette against
14189 GDI_ERROR, not zero.
14190
33383987 14191See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14192
14193;; Local Variables:
14194;; coding: utf-8
aac0c6e3
MR
14195;; End:
14196
2f097256 14197 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14198
14199 This file is part of GNU Emacs.
14200
14201 GNU Emacs is free software: you can redistribute it and/or modify
14202 it under the terms of the GNU General Public License as published by
14203 the Free Software Foundation, either version 3 of the License, or
14204 (at your option) any later version.
14205
14206 GNU Emacs is distributed in the hope that it will be useful,
14207 but WITHOUT ANY WARRANTY; without even the implied warranty of
14208 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14209 GNU General Public License for more details.
14210
14211 You should have received a copy of the GNU General Public License
14212 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.