* coding.c (make_subsidiaries): Don't assume string length fits in int.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
eb49b136
PE
12011-06-19 Paul Eggert <eggert@cs.ucla.edu>
2
1bfdaf10
PE
3 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4
35016e9a
PE
5 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6
3d1e65a1
PE
7 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8 We prefer signed integers, even for size calculations.
9
0b963a93
PE
10 * emacs.c: Don't assume string length fits in 'int'.
11 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
12 (main): Don't invoke strlen when not needed.
13
573f4b54
PE
14 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
15 (XD_DEBUG_MESSAGE): Don't waste a byte.
16
989f33ba
PE
17 * callproc.c (getenv_internal_1, getenv_internal)
18 (Fgetenv_internal):
965d34eb
PE
19 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
20
e4d29b33
PE
21 * lread.c (invalid_syntax): Omit length argument.
22 All uses changed. This doesn't fix a bug, but it simplifies the
23 code away from its former Hollerith-constant appearance, and it's
24 one less 'int' to worry about when looking at integer-overflow issues.
f14ed477 25 (string_to_number): Simplify the 2011-04-26 change by invoking xsignal1.
e4d29b33 26
eb49b136
PE
27 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
28 This didn't break anything, but it didn't help either.
29 It's confusing to put a bogus integer in a place where the actual
30 value does not matter.
9f62aeb1 31 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 32 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 33
e39e811e
PE
342011-06-18 Paul Eggert <eggert@cs.ucla.edu>
35
15375a22
PE
36 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
37 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
38 implementation.
b61cc01c
PE
39 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
40 We prefer signed types, and the value cannot exceed the EMACS_INT
41 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
42 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
43 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
44 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 45
53b2623d
PE
46 * indent.c (sane_tab_width): New function.
47 (current_column, scan_for_column, Findent_to, position_indentation)
48 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 49 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 50
45aebb64
PE
51 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
52
f2ed8a70
PE
53 * lisp.h (lint_assume): New macro.
54 * composite.c (composition_gstring_put_cache):
55 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
56
abe80cc6
PE
57 * editfns.c, insdel.c:
58 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 59
b02c740e
PE
60 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
61
ebc96716
PE
62 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
63
b4e50fa0 64 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 65 Use much-faster test for byte-length change.
311d5d7c 66 Don't assume string byte-length fits in 'int'.
a4cf38e4 67 Check that character arg fits in 'int'.
85461888 68 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 69
c0c1ee9f
PE
70 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
71
a498d7f4
PE
72 * fns.c (concat): Catch string overflow earlier.
73 Do not rely on integer wraparound.
74
e39e811e
PE
75 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
76
fadf4e30
PE
772011-06-17 Paul Eggert <eggert@cs.ucla.edu>
78
87830974
PE
79 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
80 * xdisp.c (forward_to_next_line_start)
81 (back_to_previous_visible_line_start)
82 (reseat_at_next_visible_line_start, next_element_from_buffer):
83 Don't arbitrarily truncate the value of 'selective' to int.
84
76031fad
PE
85 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
86
5eb55db9
PE
87 * composite.c: Don't truncate sizes to 'int'.
88 (composition_gstring_p, composition_reseat_it)
89 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
90 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
91 not EMACS_UINT, for indexes.
5eb55db9 92
0703a717
PE
93 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
94
d6202519
PE
95 * buffer.c: Include <verify.h>.
96 (struct sortvec.priority, struct sortstr.priority):
8961a454 97 Now EMACS_INT, not int.
c20998a7 98 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
99 (struct sortstr.size, record_overlay_string)
100 (struct sortstrlist.size, struct sortlist.used):
101 Don't truncate size to int.
102 (record_overlay_string): Check for size-calculation overflow.
d6202519 103 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 104
28177add
PE
1052011-06-16 Paul Eggert <eggert@cs.ucla.edu>
106
dd3482fe
PE
107 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
108 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
109 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
110
393d71f3 111 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
112 * fileio.c (Finsert_file_contents):
113 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
114 Remove the old (too-loose) buffer overflow checks.
115 They weren't needed, since make_gap checks for buffer overflow.
116 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
117 The old code merely checked for Emacs fixnum overflow, and relied
118 on undefined (wraparound) behavior. The new code avoids undefined
119 behavior, and also checks for ptrdiff_t and/or size_t overflow.
120
2e6813b0 121 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
122 Tune. Don't use wider integers than needed. Don't use alloca.
123 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 124
599a9e4f
PE
125 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
126
99561444
PE
127 * insdel.c, lisp.h (buffer_overflow): New function.
128 (insert_from_buffer_1, replace_range, replace_range_2):
129 * insdel.c (make_gap_larger):
130 * editfns.c (Finsert_char):
131 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
132
28177add
PE
133 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
134
e69dafad
PE
1352011-06-15 Paul Eggert <eggert@cs.ucla.edu>
136
a7af7fde 137 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 138
b1c46f02
PE
139 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
140 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
141
e69dafad
PE
142 * fileio.c: Don't assume EMACS_INT fits in off_t.
143 (emacs_lseek): New static function.
144 (Finsert_file_contents, Fwrite_region): Use it.
145 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
146
566684ea
PE
147 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
148
e6966cd6
PE
149 * fns.c: Don't overflow int when computing a list length.
150 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
151 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
152 truncation on 64-bit hosts. Check for QUIT every
153 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
154 faster and is responsive enough.
155 (Flength): Report an error instead of overflowing an integer.
156 (Fsafe_length): Return a float if the value is not representable
157 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 158 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 159 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 160
dd0b0efb
PE
161 * alloc.c: Check that resized vectors' lengths fit in fixnums.
162 (header_size, word_size): New constants.
163 (allocate_vectorlike): Don't check size overflow here.
164 (allocate_vector): Check it here instead, since this is the only
165 caller of allocate_vectorlike that could cause overflow.
166 Check that the new vector's length is representable as a fixnum.
167
86fe5cfe
PE
168 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
169 The previous code was bogus. For example, next_almost_prime (32)
170 returned 39, which is undesirable as it is a multiple of 3; and
171 next_almost_prime (24) returned 25, which is a multiple of 5 so
172 why was the code bothering to check for multiples of 7?
173
80e88859
PE
174 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
175
4a2f0ad6
PE
176 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
177
f66c7cf8
PE
178 Variadic C functions now count arguments with ptrdiff_t.
179 This partly undoes my 2011-03-30 change, which replaced int with size_t.
180 Back then I didn't know that the Emacs coding style prefers signed int.
181 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
182 were being counted with int, which may truncate counts on 64-bit
183 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
184 * lisp.h (struct Lisp_Subr.function.aMANY)
185 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
186 Arg counts are now ptrdiff_t, not size_t.
187 All variadic functions and their callers changed accordingly.
188 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
189 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
190 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
191 * callint.c (Fcall_interactively): Check arg count for overflow,
192 to avoid potential buffer overrun. Use signed char, not 'int',
193 for 'varies' array, so that we needn't bother to check its size
194 calculation for overflow.
195 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
196 * eval.c (apply_lambda):
197 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
198 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
199 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
200
a1759b76
PE
201 * callint.c (Fcall_interactively): Don't use index var as event count.
202
d96be9fc
PE
203 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
204 * mem-limits.h (SIZE): Remove; no longer used.
205
a690a978 206 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 207
578c21e6
PE
208 Remove unnecessary casts.
209 * xterm.c (x_term_init):
210 * xfns.c (x_set_border_pixel):
211 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
212 These aren't needed now that we assume ANSI C.
213
96f53c6c
PE
214 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
215 It's more likely to cause problems (due to unsigned overflow)
216 than to cure them.
217
83c77d31
PE
218 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
219
ee2079f1
PE
220 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
221
6da65536
PE
222 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
223
7147c4a4
PE
224 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
225
193e32d9
PE
226 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
227
e5533da6
PE
228 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
229
9910e595
PE
230 GLYPH_CODE_FACE returns EMACS_INT, not int.
231 * dispextern.h (merge_faces):
232 * xfaces.c (merge_faces):
01103c44
PE
233 * xdisp.c (get_next_display_element, next_element_from_display_vector):
234 Don't assume EMACS_INT fits in int.
9910e595 235
2638320e
PE
236 * character.h (CHAR_VALID_P): Remove unused parameter.
237 * fontset.c, lisp.h, xdisp.c: All uses changed.
238
045eb8d9
PE
239 * editfns.c (Ftranslate_region_internal): Omit redundant test.
240
c1f134b5
PE
241 * fns.c (concat): Minor tuning based on overflow analysis.
242 This doesn't fix any bugs. Use int to hold character, instead
243 of constantly refetching from Emacs object. Use XFASTINT, not
244 XINT, for value known to be a character. Don't bother comparing
245 a single byte to 0400, as it's always less.
246
395fcb93 247 * floatfns.c (Fexpt):
327eeec8
PE
248 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
249
abbd3d23
PE
250 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
251 for characters.
252
684a03ef
PE
253 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
254
0fed43f3
PE
255 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
256 Without this fix, on a 64-bit host (aset S 0 4294967386) would
257 incorrectly succeed when S was a string, because 4294967386 was
258 truncated before it was used.
259
8fd02eb7
PE
260 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
261 Otherwise, an out-of-range integer could cause undefined behavior
262 on a 64-bit host.
263
f8c86b69
PE
264 * composite.c: Use int, not EMACS_INT, for characters.
265 (fill_gstring_body, composition_compute_stop_pos): Use int, not
266 EMACS_INT, for values that are known to be in character range.
267 This doesn't fix any bugs but is the usual style inside Emacs and
268 may generate better code on 32-bit machines.
269
34206dd2
PE
270 Make sure a 64-bit char is never passed to ENCODE_CHAR.
271 This is for reasons similar to the recent CHAR_STRING fix.
272 * charset.c (Fencode_char): Check that character arg is actually
273 a character. Pass an int to ENCODE_CHAR.
274 * charset.h (ENCODE_CHAR): Verify that the character argument is no
275 wider than 'int', as a compile-time check to prevent future regressions
276 in this area.
277
c5958d4c 278 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
279
280 Make sure a 64-bit char is never passed to CHAR_STRING.
281 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
282 by silently ignoring the top 32 bits, allowing some values
283 that were far too large to be valid characters.
284 * character.h: Include <verify.h>.
285 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
286 arguments are no wider than unsigned, as a compile-time check
287 to prevent future regressions in this area.
288 * data.c (Faset):
01103c44 289 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
290 (Fsubst_char_in_region):
291 * fns.c (concat):
292 * xdisp.c (decode_mode_spec_coding):
293 Adjust to CHAR_STRING's new requirement.
294 * editfns.c (Finsert_char, Fsubst_char_in_region):
295 * fns.c (concat): Check that character args are actually
296 characters. Without this test, these functions did the wrong
297 thing with wildly out-of-range values on 64-bit hosts.
298
d37ca623
PE
299 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
300 These casts should not be needed on 32-bit hosts, either.
301 * keyboard.c (read_char):
302 * lread.c (Fload): Remove casts to unsigned.
303
ea204efb
PE
304 * lisp.h (UNSIGNED_CMP): New macro.
305 This fixes comparison bugs on 64-bit hosts.
306 (ASCII_CHAR_P): Use it.
307 * casefiddle.c (casify_object):
01103c44 308 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
309 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
310 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
311 * dispextern.h (FACE_FROM_ID):
312 * keyboard.c (read_char): Use UNSIGNED_CMP.
313
41cb286c
PE
314 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
315 not to EMACS_INT, to avoid GCC warning.
316
4a1b9832
PE
317 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
318
55daad71
PE
319 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
320 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
321 isn't needed on 32-bit machines.
8f95c75c 322
01103c44
PE
323 * buffer.c (Fgenerate_new_buffer_name):
324 Use EMACS_INT for count, not int.
0ceccced 325 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
326
327 * data.c (Qcompiled_function): Now static.
328
c6f072e7
PE
329 * window.c (window_body_lines): Now static.
330
20ce5912
PE
331 * image.c (gif_load): Rename local to avoid shadowing.
332
9c4c5f81
PE
333 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
334 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
335 * alloc.c (make_save_value): Integer argument is now of type
336 ptrdiff_t, not int.
337 (mark_object): Use ptrdiff_t, not int.
338 * lisp.h (pD): New macro.
339 * print.c (print_object): Use it.
340
c0c5c8ae
PE
341 * alloc.c: Use EMACS_INT, not int, to count objects.
342 (total_conses, total_markers, total_symbols, total_vector_size)
343 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
344 (total_free_floats, total_floats, total_free_intervals)
345 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
346 Now EMACS_INT, not int. All uses changed.
347 (Fgarbage_collect): Compute overall total using a double, so that
348 integer overflow is less likely to be a problem. Check for overflow
349 when converting back to an integer.
5a25e253
PE
350 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
351 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
352 These were 'int' variables that could overflow on 64-bit hosts;
353 they were never used, so remove them instead of repairing them.
211a0b2a 354 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
355 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
356 Previously, this ceilinged at INT_MAX, but that doesn't work on
357 64-bit machines.
e46bb31a 358 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 359
c78baabf 360 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 361 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
362 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
363 when a (possibly-narrower) signed value would do just as well.
364 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 365
c9d624c6
PE
366 * alloc.c: Catch some string size overflows that we were missing.
367 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
368 for convenience in STRING_BYTES_MAX.
369 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
370 The definition here is exact; the one in lisp.h was approximate.
371 (allocate_string_data): Check for string overflow. This catches
372 some instances we weren't catching before. Also, it catches
373 size_t overflow on (unusual) hosts where SIZE_MAX <= min
374 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
375 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 376
c9d624c6
PE
377 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
378 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
379 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
380
353032ce
PE
381 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
382
2bccce07
PE
383 * alloc.c (Fmake_string): Check for out-of-range init.
384
0ac30604
SM
3852011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
386
387 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
388
c195f2de
JD
3892011-06-14 Jan Djärv <jan.h.d@swipnet.se>
390
391 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
392 xg_get_default_scrollbar_width.
393
394 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
395 (int_gtk_range_get_value): Move to the scroll bar part of the file.
396 (style_changed_cb): Call update_theme_scrollbar_width and call
397 x_set_scroll_bar_default_width and xg_frame_set_char_size for
398 all frames (Bug#8505).
399 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
400 Call gtk_window_set_resizable if HAVE_GTK3.
401 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
402 and height if HAVE_GTK3 (Bug#8505).
403 (scroll_bar_width_for_theme): New variable.
404 (update_theme_scrollbar_width): New function.
405 (xg_get_default_scrollbar_width): Move code to
406 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
407 (xg_initialize): Call update_theme_scrollbar_width.
408
409 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
410
411 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
412
e10ac9f1
MR
4132011-06-12 Martin Rudalics <rudalics@gmx.at>
414
415 * frame.c (make_frame): Call other_buffer_safely instead of
416 other_buffer.
417
418 * window.c (temp_output_buffer_show): Call display_buffer with
419 second argument Vtemp_buffer_show_specifiers and reset latter
420 immediately after the call.
421 (Vtemp_buffer_show_specifiers): New variable.
422 (auto_window_vscroll_p, next_screen_context_lines)
423 (Vscroll_preserve_screen_position): Remove leading asterisks from
424 doc-strings.
425
2d3c217e 4262011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 427
7b7f97e8 428 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
429 * buffer.c (Qclone_number): Remove for now, as it's unused.
430 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
431 (record_buffer): Remove unused local.
432 * frame.c (other_visible_frames, frame_buffer_list): Now static.
433 (set_frame_buffer_list): Remove; unused.
434 * frame.h (other_visible_frames): Remove decl.
435 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
436 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
437 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
438 if HAVE_GPM.
439 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
440 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
441 Define only if HAVE_GPM.
442 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
443 (update_hints_inhibit): Remove; never set. All uses removed.
444 * widgetprv.h (emacsFrameClassRec): Remove decl.
445 * window.c (delete_deletable_window): Now returns void, since it
446 wasn't returning anything.
447 (compare_window_configurations): Remove unused locals.
448 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
449 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
450 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
451 the same widths as pointers. This follows up on the 2011-05-06 patch.
452 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
453 * xterm.h: Likewise.
454 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
455
1384b89e
JB
4562011-06-12 Juanma Barranquero <lekktu@gmail.com>
457
458 * makefile.w32-in: Update dependencies.
459 (LISP_H): Add lib/intprops.h.
460
1100a63c
CY
4612011-06-11 Chong Yidong <cyd@stupidchicken.com>
462
463 * image.c (gif_load): Add animation frame delay to the metadata.
464 (syms_of_image): Use DEFSYM. New symbol `delay'.
465
6198ccd0
MR
4662011-06-11 Martin Rudalics <rudalics@gmx.at>
467
468 * window.c (delete_deletable_window): Re-add.
469 (Fset_window_configuration): Rewrite to handle dead buffers and
470 consequently deletable windows.
471 (window_tree, Fwindow_tree): Remove. Supply functionality in
472 window.el.
473 (compare_window_configurations): Simplify code.
474
b6e3633c
AS
4752011-06-11 Andreas Schwab <schwab@linux-m68k.org>
476
1ab0dee5
AS
477 * image.c (imagemagick_load_image): Fix type mismatch.
478 (Fimagemagick_types): Likewise.
479
b6e3633c
AS
480 * window.h (replace_buffer_in_windows): Declare.
481
9397e56f
MR
4822011-06-11 Martin Rudalics <rudalics@gmx.at>
483
484 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
485 Qclone_number. Remove external declaration of Qdelete_window.
486 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
487 code.
488 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
489 Qbuffer_list_update_hook if allowed.
490 (Fother_buffer): Rewrite doc-string. Major rewrite for new
491 buffer list implementation.
492 (other_buffer_safely): New function.
493 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
494 calls to replace_buffer_in_windows and
495 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
496 if allowed.
497 (record_buffer): Inhibit quitting and rewrite using quittable
498 functions. Run Qbuffer_list_update_hook if allowed.
499 (Frecord_buffer, Funrecord_buffer): New functions.
500 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
501 switch-to-buffer to window.el.
502 (bury-buffer): Move to window.el.
503 (Vbuffer_list_update_hook): New variable.
504
505 * lisp.h (other_buffer_safely): Add prototype in buffer.c
506 section.
507
508 * window.h (resize_frame_windows): Move up in code.
509 (Fwindow_frame): Remove EXFUN.
510 (replace_buffer_in_all_windows): Remove prototype.
511 (replace_buffer_in_windows_safely): Add prototype.
512
513 * window.c: Declare Qdelete_window static again. Move down
514 declaration of select_count.
515 (Fnext_window, Fprevious_window): Rewrite doc-strings.
516 (Fother_window): Move to window.el.
517 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
518 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
519 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
520 window.el.
521 (replace_buffer_in_windows): Implement by calling
522 Qreplace_buffer_in_windows.
523 (replace_buffer_in_all_windows): Remove with some functionality
524 moved into replace_buffer_in_windows_safely.
525 (replace_buffer_in_windows_safely): New function.
526 (select_window_norecord, select_frame_norecord): Move in front
527 of run_window_configuration_change_hook. Remove now obsolete
528 declarations.
529 (Fset_window_buffer): Rewrite doc-string. Call
530 Qrecord_window_buffer.
531 (keys_of_window): Move binding for other-window to window.el.
532
b50691aa
CY
5332011-06-11 Chong Yidong <cyd@stupidchicken.com>
534
535 * dispextern.h (struct image): Replace data member, whose int_val
536 and ptr_val fields were not used by anything, with a single
537 lisp_val object.
538
539 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
540 (gif_clear_image, gif_load, imagemagick_load_image)
541 (gs_clear_image, gs_load): Callers changed.
542
3f754b86
PE
5432011-06-10 Paul Eggert <eggert@cs.ucla.edu>
544
cca69397
PE
545 * buffer.h: Include <time.h>, for time_t.
546 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
547
109e28d0
PE
548 Fix minor problems found by static checking.
549
60737f02
PE
550 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
551
4b66faf3
PE
552 Make identifiers static if they are not used in other modules.
553 * data.c (Qcompiled_function, Qframe, Qvector):
554 * image.c (QimageMagick, Qsvg):
555 * minibuf.c (Qmetadata):
556 * window.c (resize_window_check, resize_root_window): Now static.
557 * window.h (resize_window_check, resize_root_window): Remove decls.
558
109e28d0
PE
559 * window.c (window_deletion_count, delete_deletable_window):
560 Remove; unused.
46a4ce9e
PE
561 (window_body_lines): Now static.
562 (Fdelete_other_windows_internal): Mark vars as initialized.
563 Make sure 'resize_failed' is initialized.
564 (run_window_configuration_change_hook): Rename local to avoid shadowing.
565 (resize_window_apply): Remove unused local.
566 * window.h (delete_deletable_window): Remove decl.
567
109e28d0 568 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
569 (imagemagick_load_image): Fix pointer signedness problem by changing
570 last arg from unsigned char * to char *. All uses changed.
571 Also, fix a local for similar reasons.
572 Remove unused locals. Remove locals to avoid shadowing.
573 (fn_rsvg_handle_free): Remove; unused.
574 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 575 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 576
3f754b86
PE
577 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
578
2547adb1
CY
5792011-06-10 Chong Yidong <cyd@stupidchicken.com>
580
581 * image.c (gif_load): Fix omitted cast error introduced by
582 2011-06-06 change.
583
2c8e37d4
MR
5842011-06-10 Martin Rudalics <rudalics@gmx.at>
585
586 * window.h (resize_proportionally, orig_total_lines)
587 (orig_top_line): Remove from window structure.
588 (set_window_height, set_window_width, change_window_heights)
589 (Fdelete_window): Remove prototypes.
590 (resize_frame_windows): Remove duplicate declaration.
591
440a42e3
EZ
5922011-06-10 Eli Zaretskii <eliz@gnu.org>
593
594 * window.h (resize_frame_windows, resize_window_check)
595 (delete_deletable_window, resize_root_window)
596 (resize_frame_windows): Declare prototypes.
597
598 * window.c (resize_window_apply): Make definition be "static" to
599 match the prototype.
600
562dd5e9
MR
6012011-06-10 Martin Rudalics <rudalics@gmx.at>
602
603 * window.c: Remove declarations of Qwindow_size_fixed,
604 window_min_size_1, window_min_size_2, window_min_size,
605 size_window, window_fixed_size_p, enlarge_window, delete_window.
606 Remove static from declaration of Qdelete_window, it's
607 temporarily needed by Fbury_buffer.
608 (replace_window): Don't assign orig_top_line and
609 orig_total_lines.
610 (Fdelete_window, delete_window): Remove. Window deletion is
611 handled by window.el.
612 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
613 Fdelete_window calls with calls to Qdelete_window.
614 (Fdelete_other_windows): Remove. Deleting other windows is
615 handled by window.el.
616 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
617 handled in window.el.
618 (window_min_size_2, window_min_size_1, window_min_size): Remove.
619 Window minimum sizes are handled in window.el.
620 (shrink_windows, size_window, set_window_height)
621 (set_window_width, change_window_heights, window_height)
622 (window_width, CURBEG, CURSIZE, enlarge_window)
623 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
624 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
625 handled in window.el.
626 (make_dummy_parent): Rename to make_parent_window and give it a
627 second argument horflag.
628 (make_window): Don't set resize_proportionally any more.
629 (Fsplit_window): Remove. Windows are split in window.el.
630 (save_restore_action, save_restore_orig_size)
631 (shrink_window_lowest_first, save_restore_orig_size): Remove.
632 Resize mini windows in window.el.
633 (grow_mini_window, shrink_mini_window): Implement by calling
634 Qresize_root_window_vertically, resize_window_check and
635 resize_window_apply.
636 (saved_window, Fset_window_configuration, save_window_save): Do
637 not handle orig_top_line, orig_total_lines, and
638 resize_proportionally.
639 (window_min_height, window_min_width): Move to window.el.
640 (keys_of_window): Move bindings for delete-other-windows,
641 split-window, delete-window and enlarge-window to window.el.
642
643 * buffer.c: Temporarily extern Qdelete_window.
644 (Fbury_buffer): Temporarily call Qdelete_window instead of
645 Fdelete_window (Fbury_buffer will move to window.el soon).
646
647 * frame.c (set_menu_bar_lines_1): Remove code handling
648 orig_top_line and orig_total_lines.
649
650 * dispnew.c (adjust_frame_glyphs_initially): Don't use
651 set_window_height but set heights directly.
652 (change_frame_size_1): Use resize_frame_windows.
653
654 * xdisp.c (init_xdisp): Don't use set_window_height but set
655 heights directly.
656
657 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
658 resize_frame_windows instead of change_window_heights and run
659 run_window_configuration_change_hook.
660
661 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
662 instead of change_window_heights and run
663 run_window_configuration_change_hook.
664
1a13852e
MR
6652011-06-09 Martin Rudalics <rudalics@gmx.at>
666
667 * window.c (replace_window): Rename second argument REPLACEMENT to
668 NEW. New third argument SETFLAG. Rewrite.
669 (delete_window, make_dummy_parent): Call replace_window with
670 third argument 1.
671 (window_list_1): Move down in code.
672 (run_window_configuration_change_hook): Move set_buffer part
673 before select_frame_norecord part in order to unwind correctly.
674 Rename count1 to count.
675 (recombine_windows, delete_deletable_window, resize_root_window)
676 (Fdelete_other_windows_internal)
677 (Frun_window_configuration_change_hook, make_parent_window)
678 (resize_window_check, resize_window_apply, Fresize_window_apply)
679 (resize_frame_windows, Fsplit_window_internal)
680 (Fdelete_window_internal, Fresize_mini_window_internal): New
681 functions.
682 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
683
f3d1777e
MR
6842011-06-08 Martin Rudalics <rudalics@gmx.at>
685
496e208e
MR
686 * window.h (window): Add some new members to window structure -
687 normal_lines, normal_cols, new_total, new_normal, clone_number,
688 splits, nest, prev_buffers, next_buffers.
689 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 690 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 691
f3d1777e
MR
692 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
693 Remove.
496e208e
MR
694 (make_dummy_parent): Set new members of windows structure.
695 (make_window): Move down in code. Handle new members of window
696 structure.
697 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
698 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
699 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
700 (Fset_window_prev_buffers, Fwindow_next_buffers)
701 (Fset_window_next_buffers, Fset_window_clone_number): New
702 functions.
703 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
704 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
705 Doc-string fixes.
706 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
707 Argument WINDOW can be now internal window too.
708 (Fwindow_use_time): Move up in code.
709 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
710 Rewrite doc-string.
711 (Fset_window_configuration, saved_window)
712 (Fcurrent_window_configuration, save_window_save): Handle new
713 members of window structure.
b9e809c2
MR
714 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
715 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
716 (syms_of_window): New Lisp objects Qrecord_window_buffer,
717 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
718 Qget_mru_window, Qresize_root_window,
719 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
720 Qauto_buffer_name; staticpro them.
f3d1777e 721
abde8f8c
MR
7222011-06-07 Martin Rudalics <rudalics@gmx.at>
723
724 * window.c (Fwindow_total_size, Fwindow_left_column)
725 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
726 (Fwindow_list_1): New functions.
727 (window_box_text_cols): Replace with window_body_cols.
728 (Fwindow_width, Fscroll_left, Fscroll_right): Use
729 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
730 (delete_window, Fset_window_configuration): Call
731 delete_all_subwindows with window as argument.
732 (delete_all_subwindows): Take a window as argument and not a
733 structure. Rewrite.
190b47e6
MR
734 (window_loop): Remove handling of GET_LRU_WINDOW and
735 GET_LARGEST_WINDOW.
736 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
737
738 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
739 window_box_text_cols. delete_all_subwindows now takes a
740 Lisp_Object as argument.
abde8f8c
MR
741
742 * indent.c (compute_motion, Fcompute_motion): Use
743 window_body_cols instead of window_box_text_cols.
744
fa8a67e6
MR
745 * frame.c (delete_frame): Call delete_all_subwindows with root
746 window as argument.
747
a54e3482
DC
7482011-06-07 Daniel Colascione <dan.colascione@gmail.com>
749
750 * fns.c (Fputhash): Document return value.
751
60002bf5
CY
7522011-06-06 Chong Yidong <cyd@stupidchicken.com>
753
754 * image.c (gif_load): Implement gif89a spec "no disposal" method.
755
0c671da6 7562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 757
b862a52a 758 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 759
be44ca6c
PE
760 Check for overflow when converting integer to cons and back.
761 * charset.c (Fdefine_charset_internal, Fdecode_char):
762 Use cons_to_unsigned to catch overflow.
763 (Fencode_char): Use INTEGER_TO_CONS.
764 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
765 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
766 * data.c (long_to_cons, cons_to_long): Remove.
767 (cons_to_unsigned, cons_to_signed): New functions.
768 These signal an error for invalid or out-of-range values.
769 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
770 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
771 * font.c (Ffont_variation_glyphs):
772 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
773 * lisp.h: Include <intprops.h>.
774 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
775 (cons_to_signed, cons_to_unsigned): New decls.
776 (long_to_cons, cons_to_long): Remove decls.
777 * undo.c (record_first_change): Use INTEGER_TO_CONS.
778 (Fprimitive_undo): Use CONS_TO_INTEGER.
779 * xfns.c (Fx_window_property): Likewise.
780 * xselect.c: Include <limits.h>.
781 (x_own_selection, selection_data_to_lisp_data):
782 Use INTEGER_TO_CONS.
783 (x_handle_selection_request, x_handle_selection_clear)
784 (x_get_foreign_selection, Fx_disown_selection_internal)
785 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
786 (lisp_data_to_selection_data): Use cons_to_unsigned.
787 (x_fill_property_data): Use cons_to_signed.
788 Report values out of range.
789
d1f3d2af
PE
790 Check for buffer and string overflow more precisely.
791 * buffer.h (BUF_BYTES_MAX): New macro.
792 * lisp.h (STRING_BYTES_MAX): New macro.
793 * alloc.c (Fmake_string):
794 * character.c (string_escape_byte8):
795 * coding.c (coding_alloc_by_realloc):
796 * doprnt.c (doprnt):
797 * editfns.c (Fformat):
798 * eval.c (verror):
799 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
800 since they may not be the same number.
801 * editfns.c (Finsert_char):
802 * fileio.c (Finsert_file_contents):
803 Likewise for BUF_BYTES_MAX.
804
dd52fcea
PE
805 * image.c: Use ptrdiff_t, not int, for sizes.
806 (slurp_file): Switch from int to ptrdiff_t.
807 All uses changed.
808 (slurp_file): Check that file size fits in both size_t (for
809 malloc) and ptrdiff_t (for sanity and safety).
810
7f9bbdbb
PE
811 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
812 if b->modtime has its maximal value.
813
dfe18f82
PE
814 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
815
84acfcf0
PE
816 Don't assume time_t can fit into int.
817 * buffer.h (struct buffer.modtime): Now time_t, not int.
818 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
819 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
820
ccd9a01a
PE
821 Minor fixes for signed vs unsigned integers.
822 * character.h (MAYBE_UNIFY_CHAR):
823 * charset.c (maybe_unify_char):
824 * keyboard.c (read_char, reorder_modifiers):
825 XINT -> XFASTINT, since the integer must be nonnegative.
826 * ftfont.c (ftfont_spec_pattern):
827 * keymap.c (access_keymap, silly_event_symbol_error):
828 XUINT -> XFASTINT, since the integer must be nonnegative.
829 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
830 since it makes no difference and we prefer signed.
831 * keyboard.c (record_char): Use XUINT when all the neighbors do.
832 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
833 nonnegative.
834
d6d100dd
SM
8352011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
836
837 * window.h (Fwindow_frame): Declare.
838
2b6148e4
PE
8392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
840
841 * alloc.c: Simplify handling of large-request failures (Bug#8800).
842 (SPARE_MEMORY): Always define.
843 (LARGE_REQUEST): Remove.
844 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
845
f230ecc9
MR
8462011-06-06 Martin Rudalics <rudalics@gmx.at>
847
727e958e
MR
848 * lisp.h: Move EXFUNS for Fframe_root_window,
849 Fframe_first_window and Fset_frame_selected_window to window.h.
850
851 * window.h: Move EXFUNS for Fframe_root_window,
852 Fframe_first_window and Fset_frame_selected_window here from
853 lisp.h.
854
855 * frame.c (Fwindow_frame, Fframe_first_window)
856 (Fframe_root_window, Fframe_selected_window)
857 (Fset_frame_selected_window): Move to window.c.
858 (Factive_minibuffer_window): Move to minibuf.c.
859 (Fother_visible_frames_p): New function.
860
861 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
862
f230ecc9
MR
863 * window.c (decode_window, decode_any_window): Move up in code.
864 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
865 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
866 (Fwindow_buffer): Move up and rewrite doc-string.
867 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
868 (Fwindow_prev): New functions.
727e958e
MR
869 (Fwindow_frame): Move here from frame.c. Accept any window as
870 argument.
871 (Fframe_root_window, Fframe_first_window)
872 (Fframe_selected_window): Move here from frame.c. Accept frame
873 or arbitrary window as argument. Update doc-strings.
874 (Fminibuffer_window): Move up in code.
875 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
876 (Fset_frame_selected_window): Move here from frame.c.
877 Marginal rewrite.
727e958e
MR
878 (Fselected_window, select_window, Fselect_window): Move up in
879 code. Minor doc-string fixes.
f230ecc9 880
4d09bcf6
PE
8812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
882
883 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
884 Do not assume that spare memory exists; that assumption is valid
885 only if SYSTEM_MALLOC.
886 (LARGE_REQUEST): New macro, so that the issue of large requests
887 is separated from the issue of spare memory.
888
810928a2
AS
8892011-06-05 Andreas Schwab <schwab@linux-m68k.org>
890
172418ad
AS
891 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
892 format. (Bug#8806)
893
43f862f7
AS
894 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
895
810928a2
AS
896 * xfns.c (x_set_scroll_bar_default_width): Move declarations
897 before statements.
898
a059fe24
JD
8992011-06-05 Jan Djärv <jan.h.d@swipnet.se>
900
901 * gtkutil.c (xg_get_default_scrollbar_width): New function.
902
903 * gtkutil.h: Declare xg_get_default_scrollbar_width.
904
905 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
906 min width by calling x_set_scroll_bar_default_width (Bug#8505).
907
989bf368
JB
9082011-06-05 Juanma Barranquero <lekktu@gmail.com>
909
910 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
911
4b80f674
CY
9122011-06-04 Chong Yidong <cyd@stupidchicken.com>
913
914 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
915 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
916 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
917 New error handlers.
4b80f674
CY
918 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
919 Obey Vx_select_enable_clipboard_manager. Catch errors in
920 x_clipboard_manager_save (Bug#8779).
921 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 922 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 923
99a33b77 9242011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
925
926 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
927
99a33b77 9282011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
929
930 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
931 in the current matrix if keep_current_p is non-zero.
932
8264569d
EZ
9332011-06-04 Eli Zaretskii <eliz@gnu.org>
934
935 * bidi.c (bidi_level_of_next_char): Fix last change.
936
57f97249
EZ
9372011-06-03 Eli Zaretskii <eliz@gnu.org>
938
fec2107c 939 Support bidi reordering of text covered by display properties.
57f97249 940
fec2107c
EZ
941 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
942 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
943 (bidi_cache_search, bidi_cache_iterator_state)
944 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
945 (bidi_level_of_next_char, bidi_move_to_visually_next):
946 Support character positions inside a run of characters covered by a
fec2107c
EZ
947 display string.
948 (bidi_paragraph_init, bidi_resolve_explicit_1)
949 (bidi_level_of_next_char): Call bidi_fetch_char and
950 bidi_fetch_char_advance instead of FETCH_CHAR and
951 FETCH_CHAR_ADVANCE.
952 (bidi_init_it): Initialize new members.
953 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
954 definitions.
955 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
956 instead of using explicit *_CHAR codes.
d6d100dd
SM
957 (bidi_resolve_explicit, bidi_resolve_weak):
958 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
959 bidirectional text is supported only in multibyte buffers.
960 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
961 it to initialize the frame_window_p member of struct bidi_it.
962 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
963 (bidi_resolve_explicit, bidi_resolve_weak)
964 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
965 bidi_it->nchars is non-positive.
966 (bidi_level_of_next_char): Don't try to lookup the cache for the
967 next/previous character if nothing is cached there yet, or if we
968 were just reseat()'ed to a new position.
c40e2fb2 969
0e14fe90
EZ
970 * xdisp.c (set_cursor_from_row): Set start and stop points
971 according to the row's direction when priming the loop that looks
972 for the glyph on which to display cursor.
973 (single_display_spec_intangible_p): Function deleted.
974 (display_prop_intangible_p): Reimplement to call
975 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
976 Accept 3 additional arguments needed by handle_display_spec.
977 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
978 values: lists, `(when COND...)' forms, etc.
979 (single_display_spec_string_p): Support property values that are
980 lists with the argument STRING its top-level element.
981 (display_prop_string_p): Fix the condition for processing a
982 property that is a list to be consistent with handle_display_spec.
fec2107c 983 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
984 last portion of handle_display_prop.
985 (compute_display_string_pos): Accept additional argument
986 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
987 value of a `display' property is a "replacing spec".
988 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
989 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
990 the display property, but just return a value indicating whether
991 the display property will replace the characters it covers.
992 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
993 frame_window_p members of struct bidi_it.
d6d100dd
SM
994 (compute_display_string_pos, compute_display_string_end):
995 New functions.
fec2107c
EZ
996 (push_it): Accept second argument POSITION, where pop_it should
997 jump to continue iteration.
998 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 999
fec2107c
EZ
1000 * keyboard.c (adjust_point_for_property): Adjust the call to
1001 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1002
1003 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1004 (bidi_init_it): Update prototypes.
1005 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1006 (compute_display_string_pos, compute_display_string_end):
1007 Declare prototypes.
fec2107c
EZ
1008 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1009 EMACS_INT.
fc6f18ce 1010
40087514 10112011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1012
57f53182
PE
1013 Malloc failure behavior now depends on size of allocation.
1014 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1015 * lisp.h: Change signatures accordingly.
1016 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1017 All callers changed. (Bug#8762)
1018
1019 * gnutls.c: Use Emacs's memory allocators.
1020 Without this change, the gnutls library would invoke malloc etc.
1021 directly, which causes problems on non-SYNC_INPUT hosts, and which
1022 runs afoul of improving memory_full behavior. (Bug#8761)
1023 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1024 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1025 xfree instead of the default malloc, realloc, free.
1026 (Fgnutls_boot): No need to check for memory allocation failure,
1027 since xmalloc does that for us.
1028
ac32cd99 1029 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1030 * category.c (hash_get_category_set):
1031 * ccl.c (ccl_driver):
1032 * charset.c (Fdefine_charset_internal):
1033 * charset.h (struct charset.hash_index):
1034 * composite.c (get_composition_id, gstring_lookup_cache)
1035 (composition_gstring_put_cache):
1036 * composite.h (struct composition.hash_index):
1037 * dispextern.h (struct image.hash):
1038 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1039 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1040 (hashfn_equal, hashfn_user_defined, make_hash_table)
1041 (maybe_resize_hash_table, hash_lookup, hash_put)
1042 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1043 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1044 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1045 * image.c (make_image, search_image_cache, lookup_image)
1046 (xpm_put_color_table_h):
1047 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1048 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1049 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1050 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1051 * alloc.c (allocate_vectorlike):
1052 Check for overflow in vector size calculations.
1053 * ccl.c (ccl_driver):
1054 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1055 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1056 need to be updated by these changes.
40087514
PE
1057 * fns.c (make_hash_table, maybe_resize_hash_table):
1058 Check for integer overflow with large hash tables.
0de4bb68
PE
1059 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1060 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1061 (SXHASH_REDUCE): New macro.
1062 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1063 Use it instead of discarding useful hash info with large hash values.
1064 (sxhash_float): New function.
1065 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1066 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1067 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1068 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1069 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1070 Adjust signatures to match updated version of code.
1071 (consing_since_gc): Now EMACS_INT, since a single hash table can
1072 use more than INT_MAX bytes.
1073
698d32e2
DN
10742011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1075
1076 Make it possible to build with GCC-4.6+ -O2 -flto.
1077
1078 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1079
fd6fa53f
SM
10802011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1081
1082 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1083 Call minibuffer-inactive-mode.
1084
864db017
JB
10852011-05-31 Juanma Barranquero <lekktu@gmail.com>
1086
1087 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1088 Update dependencies.
1089
2ad0baf4
DN
10902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1091
1092 * data.c (init_data): Remove code for UTS, this system is not
1093 supported anymore.
1094
4fcc2638
DN
10952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1096
1097 Don't force ./temacs to start in terminal mode.
1098
1099 * frame.c (make_initial_frame): Initialize faces in all cases, not
1100 only when CANNOT_DUMP is defined.
1101 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1102
c56e0fd5
DN
11032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1104
1105 * dispnew.c (add_window_display_history): Use const for the string
1106 pointer. Remove declaration, not needed.
1107
333d54da 11082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1109
55d4c1b2 1110 Use 'inline', not 'INLINE'.
333d54da 1111 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1112 * alloc.c, fontset.c (INLINE): Remove.
1113 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1114 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1115 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1116 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1117 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1118
738db178
DN
11192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1120
1121 Make it possible to run ./temacs.
1122
1123 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1124 syms_of_callproc does the same thing. Remove test for
1125 "initialized", do it in the caller.
1126 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1127
620c53a6
SM
11282011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1129
1130 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1131 (read_minibuf): Use get_minibuffer.
1132 (syms_of_minibuf): Use DEFSYM.
1133 (Qmetadata): New var.
1134 * data.c (Qbuffer): Don't make it static.
1135 (syms_of_data): Use DEFSYM.
1136
e003a292
PE
11372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1140 (CCL_CODE_MIN): New macro.
1141
ed008a6d
PE
11422011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1143
3687c2ef
PE
1144 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1145
ed008a6d
PE
1146 * eval.c (Qdebug): Now static.
1147 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1148 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1149 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1150
d66c4c7c
CY
11512011-05-29 Chong Yidong <cyd@stupidchicken.com>
1152
1153 * image.c: Various fixes to ImageMagick code comments.
1154 (Fimagemagick_types): Doc fix.
1155
5fbc2025
PE
11562011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1157
0196f88a
PE
1158 Minor fixes prompted by GCC 4.6.0 warnings.
1159
1160 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1161
5fbc2025
PE
1162 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1163 (x_clipboard_manager_save_all): Move extern decl to ...
1164 * xterm.h: ... here, so that it can be checked for consistency.
1165
1dd3c2d9
CY
11662011-05-29 Chong Yidong <cyd@stupidchicken.com>
1167
1168 * xselect.c (x_clipboard_manager_save_frame)
1169 (x_clipboard_manager_save_all): New functions.
1170 (Fx_clipboard_manager_save): Lisp function deleted.
1171
1172 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1173 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1174
1175 * xterm.h: Update prototype.
1176
5ba6571d
WX
11772011-05-28 William Xu <william.xwl@gmail.com>
1178
1179 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1180 exiting (Bug#8239).
1181
3eaff834
JM
11822011-05-28 Jim Meyering <meyering@redhat.com>
1183
e1900994 1184 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1185 * fns.c (to_uchar): Define.
1186 (crypto_hash_function): Use it to convert some newly-signed
1187 variables to unsigned, to avoid sign-extension bugs. For example,
1188 without this change, (md5 "truc") would evaluate to
1189 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1190 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1191 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1192
0f6990a7
PE
11932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1194
1195 Integer overflow fixes.
c8a9ca5a 1196
08686060
PE
1197 * dbusbind.c: Serial number integer overflow fixes.
1198 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1199 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1200 to hold a serial number that is too large for a fixnum.
1201 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1202 Check for serial numbers out of range. Decode any serial number
59568bf0 1203 that was so large that it became a float. (Bug#8722)
08686060 1204
2d1fc3c7
PE
1205 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1206 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1207 Use XFASTINT rather than XUINT when numbers are nonnegative.
1208 (xd_append_arg, Fdbus_method_return_internal):
1209 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1210 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1211 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1212 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1213 (Bug#8722)
2d1fc3c7 1214
c8a9ca5a
PE
1215 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1216
519e1d69
PE
1217 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1218
30569699
PE
1219 ccl: add integer overflow checks
1220 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1221 (IN_INT_RANGE): New macros.
1222 (ccl_driver): Use them to check for integer overflow when
1223 decoding a CCL program. Many of the new checks are whether XINT (x)
1224 fits in int; it doesn't always, on 64-bit hosts. The new version
1225 doesn't catch all possible integer overflows, but it's an
847044ea 1226 improvement. (Bug#8719)
30569699 1227
c11285dc
PE
1228 * alloc.c (make_event_array): Use XINT, not XUINT.
1229 There's no need for unsigned here.
1230
fdccd48e
PE
1231 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1232 This follows up to the 2011-05-06 change that substituted uintptr_t
1233 for EMACS_INT. This case wasn't caught back then.
1234
37910ab2
PE
1235 Rework Fformat to avoid integer overflow issues.
1236 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1237 now (part of C89). Include <verify.h>.
1238 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1239 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1240 (Fformat): Avoid the prepass trying to compute sizes; it was only
1241 approximate and thus did not catch overflow reliably. Instead, walk
1242 through the format just once, formatting and computing sizes as we go,
1243 checking for integer overflow at every step, and allocating a larger
1244 buffer as needed. Keep track separately whether the format is
1245 multibyte. Keep only the most-recently calculated precision, rather
1246 than them all. Record whether each argument has been converted to
1247 string. Use EMACS_INT, not int, for byte and char and arg counts.
1248 Support field widths and precisions larger than INT_MAX. Avoid
1249 sprintf's undefined behavior with conversion specifications such as %#d
1250 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1251 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1252 formatting out-of-range floating point numbers with int
1253 formats. (Bug#8668)
1254
2e6578fb
PE
1255 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1256
0ae6bdee
PE
1257 * data.c: Avoid integer truncation in expressions involving floats.
1258 * data.c: Include <intprops.h>.
1259 (arith_driver): When there's an integer overflow in an expression
1260 involving floating point, convert the integers to floating point
1261 so that the resulting value does not suffer from catastrophic
1262 integer truncation. For example, on a 64-bit host (* 4
1263 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1264 Do not rely on undefined behavior after integer overflow.
1265
de883a70
PE
1266 merge count_size_as_multibyte, parse_str_to_multibyte
1267 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1268 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1269 Check for integer overflow.
1270 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1271 since it's now a duplicate of the other. This is more of
1272 a character than a buffer op, so better that it's in character.c.
1273 * fns.c, print.c: Adjust to above changes.
1274
2ff916cb
PE
12752011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1276
1277 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1278
f1b54466
PE
12792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1280
fb1ac845
PE
1281 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1282 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1283 (x_clipboard_manager_save): Now static.
1284 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1285
f1b54466
PE
1286 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1287 (crypto_hash_function): Now static.
1288 Fix pointer signedness problems. Avoid unnecessary initializations.
1289
a9f737ee
CY
12902011-05-27 Chong Yidong <cyd@stupidchicken.com>
1291
1292 * termhooks.h (Vselection_alist): Make it terminal-local.
1293
1294 * terminal.c (create_terminal): Initialize it.
1295
1296 * xselect.c: Support for clipboard managers.
1297 (Vselection_alist): Move to termhooks.h as terminal-local var.
1298 (LOCAL_SELECTION): New macro.
1299 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1300 (symbol_to_x_atom): Remove gratuitous arg.
1301 (x_handle_selection_request, lisp_data_to_selection_data)
1302 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1303 (x_own_selection, x_get_local_selection, x_convert_selection):
1304 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1305 (some_frame_on_display): Delete unused function.
1306 (Fx_own_selection_internal, Fx_get_selection_internal)
1307 (Fx_disown_selection_internal, Fx_selection_owner_p)
1308 (Fx_selection_exists_p): New optional frame arg.
1309 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1310 (x_handle_selection_clear): Don't treat other terminals with the
1311 same keyboard specially. Use the terminal-local Vselection_alist.
1312 (x_clear_frame_selections): Use Frun_hook_with_args.
1313
1314 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1315
1316 * xterm.h: Add support for those atoms.
1317
e067f0c1
CY
13182011-05-26 Chong Yidong <cyd@stupidchicken.com>
1319
1320 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1321 (converted_selections, conversion_fail_tag): New global variables.
1322 (x_selection_request_lisp_error): Free the above.
1323 (x_get_local_selection): Remove unnecessary code.
1324 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1325 of converted selections stored in converted_selections.
1326 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1327 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1328 (x_convert_selection): New function.
1329 (x_handle_selection_event): Simplify.
1330 (x_get_foreign_selection): Don't ignore incoming requests while
1331 waiting for an answer; this will fail when we implement
1332 SAVE_TARGETS, and seems unnecessary anyway.
1333 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1334 (Vx_sent_selection_functions): Doc fix.
1335
0f4aebc0
LL
13362011-05-26 Leo Liu <sdl.web@gmail.com>
1337
1338 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1339
e61124cd
YM
13402011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1341
1342 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1343
1344 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1345 for fringe update if it has periodic bitmap.
1346 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1347 and fringe_bitmap_periodic_p.
1348
1349 * fringe.c (get_fringe_bitmap_data): New function.
1350 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1351 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1352 row. Mark glyph row for fringe update if periodicity changed.
1353
1354 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1355 for fringe update unless it has periodic bitmap.
1356
f16d9837
KH
13572011-05-25 Kenichi Handa <handa@m17n.org>
1358
1359 * xdisp.c (get_next_display_element): Set correct it->face_id for
1360 a static composition.
1361
e1b90ef6
LL
13622011-05-24 Leo Liu <sdl.web@gmail.com>
1363
1364 * deps.mk (fns.o):
1365 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1366
1367 * fns.c (crypto_hash_function, Fsha1): New function.
1368 (Fmd5): Use crypto_hash_function.
1369 (syms_of_fns): Add Ssha1.
1370
7400048f
PE
13712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1372
1373 * gnutls.c: Remove unused macros.
1374 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1375 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1376 Remove macros that are defined and never used.
1377 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1378
abb71cf4
CY
13792011-05-22 Chong Yidong <cyd@stupidchicken.com>
1380
1381 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1382 (Fx_get_selection_internal): Minor cleanup.
1383 (Fx_own_selection_internal): Rename arguments for consistency with
1384 select.el.
1385
6307db39
PE
13862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1389
f3d4e0a4
CY
13902011-05-22 Chong Yidong <cyd@stupidchicken.com>
1391
1392 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1393
4d8ade89
YM
13942011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1395
1396 * dispnew.c (scrolling_window): Don't exclude the case that the
1397 last enabled row in the desired matrix touches the bottom boundary.
1398
32078c8d
GM
13992011-05-21 Glenn Morris <rgm@gnu.org>
1400
1401 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1402 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1403 and add some more files.
32078c8d 1404
7285dc67
EZ
14052011-05-20 Eli Zaretskii <eliz@gnu.org>
1406
1407 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1408 report_file_error introduced by the change from 2011-05-07.
1409
89d1bd22
PE
14102011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1411
1412 * systime.h (Time): Define only if emacs is defined.
1413 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1414 where the include path doesn't have X11/X.h by default. See
1415 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1416
e23640bb 14172011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1418
1419 * composite.c (find_automatic_composition): Fix previous change.
1420
b9704ad9
GM
14212011-05-20 Glenn Morris <rgm@gnu.org>
1422
1423 * lisp.mk: New file, split from Makefile.in.
1424 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1425 (shortlisp): Remove.
1426 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1427
4a720484
GM
14282011-05-19 Glenn Morris <rgm@gnu.org>
1429
1430 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1431 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1432 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1433 (lisp): Set the order to that of loadup.el.
1434 (shortlisp): Make it a copy of $lisp.
1435 (SOME_MACHINE_LISP): Remove.
1436 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1437 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1438
a28d4396
KH
14392011-05-18 Kenichi Handa <handa@m17n.org>
1440
1441 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1442 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1443 (find_automatic_composition): Mostly rewrite for efficiency.
1444
a2b1fa8e
JB
14452011-05-18 Juanma Barranquero <lekktu@gmail.com>
1446
1447 * makefile.w32-in: Update dependencies.
1448
8e1f5610
CS
14492011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1450
1451 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1452 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1453
7025ee00 14542011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1455
cdfa6eab
PE
1456 Fix some integer overflow issues, such as string length overflow.
1457
06d6db33
PE
1458 * insdel.c (count_size_as_multibyte): Check for string overflow.
1459
2b4560a8
PE
1460 * character.c (lisp_string_width): Check for string overflow.
1461 Use EMACS_INT, not int, for string indexes and lengths; in
1462 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1463 the resulting string length overflows an EMACS_INT; instead,
1464 report a string overflow if no precision given. When checking for
1465 precision exhaustion, use a check that cannot possibly have
1466 integer overflow. (Bug#8675)
1467 * character.h (lisp_string_width): Adjust to new signature.
1468
cb93f9be
PE
1469 * alloc.c (string_overflow): New function.
1470 (Fmake_string): Use it. This doesn't change behavior, but saves
1471 a few bytes and will simplify future changes.
1472 * character.c (string_escape_byte8): Likewise.
1473 * lisp.h (string_overflow): New decl.
1474
1a1f3366
PE
1475 Fixups, following up to the user-interface timestamp change.
1476 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1477 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1478 * msdos.c (mouse_get_pos): Likewise.
1479 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1480 * w32gui.h (Time): Define by including "systime.h" rather than by
1481 declaring it ourselves. (Bug#8664)
1482
d4e3e4d3
PE
1483 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1484 * image.c (clear_image_cache): Likewise.
1485
f6a24d19
PE
1486 * term.c (term_mouse_position): Don't assume time_t wraparound.
1487
08dc5ae6
PE
1488 Be more systematic about user-interface timestamps.
1489 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1490 and sometimes 'EMACS_UINT', to represent these timestamps.
1491 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1492 This makes the code easier to follow, and makes it easier to catch
1493 integer overflow bugs such as Bug#8664.
1494 * frame.c (Fmouse_position, Fmouse_pixel_position):
1495 Use Time, not unsigned long, for user-interface timestamps.
1496 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1497 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1498 * keyboard.h (last_event_timestamp): Likewise.
1499 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1500 * menu.h (xmenu_show): Likewise.
1501 * term.c (term_mouse_position): Likewise.
1502 * termhooks.h (struct input_event.timestamp): Likewise.
1503 (struct terminal.mouse_position_hook): Likewise.
1504 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1505 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1506 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1507 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1508 what it was before.
1509 * menu.h, termhooks.h: Include "systime.h", for Time.
1510
8e55734a
PE
1511 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1512 Don't assume that the difference between two unsigned long values
1513 can fit into an integer. At this point, we know button_down_time
1514 <= event->timestamp, so the difference must be nonnegative, so
1515 there's no need to cast the result if double-click-time is
1516 nonnegative, as it should be; check that it's nonnegative, just in
1517 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1518 apart (about 25 days). (Bug#8664)
8e55734a 1519
841f1b75 1520 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1521 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1522
3e26f69c
PE
1523 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1524 that always fit in int. Use a sentinel instead of a counter, to
1525 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1526 * frame.h (struct frame): Use int for menu_bar_items_used
1527 instead of EMACS_INT, since it always fits in int.
3e26f69c 1528
5cc152c0
PE
1529 * menu.c (grow_menu_items): Check for int overflow.
1530
d89eb65e
PE
1531 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1532
5235bd3e
PE
1533 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1534 Before, the code was not consistent. These values cannot exceed
1535 2**31 - 1 so there's no need to make them unsigned.
1536 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1537 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1538 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1539 as modifiers.
1540 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1541
bc827e23
PE
1542 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1543 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1544 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1545 presumably because the widths might not match.
1546
78eb494e
PE
1547 * window.c (size_window): Avoid needless test at loop start.
1548
04f2d78b
CB
15492011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1550
1551 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1552
d2fc7e3d 15532011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1554
1555 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1556
d2fc7e3d 15572011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1558
1559 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1560 `width' to `bar_area_x' and `bar_area_width', respectively.
1561 (x_scroll_run): Take account of fringe background extension.
1562
04f2d78b
CB
1563 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1564 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1565 `bar_area_width', respectively.
1566 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1567 background extension.
1568
79b70037
GM
15692011-05-10 Jim Meyering <meyering@redhat.com>
1570
1571 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1572
2f142cc5
JB
15732011-05-10 Juanma Barranquero <lekktu@gmail.com>
1574
1575 * image.c (Finit_image_library): Return t for built-in image types,
1576 like pbm and xbm. (Bug#8640)
1577
57679c86
AS
15782011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1579
1580 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1581
888c9e86
EZ
15822011-05-07 Eli Zaretskii <eliz@gnu.org>
1583
b0512a1d
EZ
1584 * w32console.c (Fset_screen_color): Doc fix.
1585 (Fget_screen_color): New function.
1586 (syms_of_ntterm): Defsubr it.
1587
7285dc67
EZ
1588 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1589 unlink the temporary file if Fcall_process didn't create it in the
1590 first place.
1591 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1592 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1593 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1594 cue to call_process_cleanup not to close that handle.
1595
4d3fcc8e
BK
15962011-05-07 Ben Key <bkey76@gmail.com>
1597
1598 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1599 one of two shell specific rules, either bootstrap-temacs-CMD or
1600 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1601 to the previous implementation of the bootstrap-temacs rule.
1602 The bootstrap-temacs-CMD rule is similar to the previous
1603 implementation of the bootstrap-temacs rule except that it
1604 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1605 variable.
1606
1607 These changes, along with some changes to nt/configure.bat,
1608 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1609 earlier fix to add support for --cflags and --ldflags options
1610 that include quotes so that it works whether make uses cmd or
1611 sh as the shell.
1612
b4289b64
MA
16132011-05-06 Michael Albinus <michael.albinus@gmx.de>
1614
1615 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1616 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1617 is a constant.
1618 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1619 a string. Handle both cases.
1620 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1621 (Fdbus_register_method): Use Qinvalid_function.
1622
af4c0e28
JB
16232011-05-06 Juanma Barranquero <lekktu@gmail.com>
1624
1625 * makefile.w32-in: Update dependencies.
1626 (LISP_H): Add inttypes.h and stdin.h.
1627 (PROCESS_H): Add unistd.h.
1628
c51453d9
EZ
16292011-05-06 Eli Zaretskii <eliz@gnu.org>
1630
1631 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1632 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1633
8ff0ac3c 16342011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1635
4c4b566b
PE
1636 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1637
aab2b9b5
PE
1638 * term.c (vfatal): Remove stray call to va_end.
1639 It's not needed and the C Standard doesn't allow it here anyway.
1640
c378da0b
PE
1641 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1642 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1643
288b08c7
PE
1644 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1645 bytes.
1646
e3601888
PE
1647 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1648
db6c0e74
PE
1649 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1650
dd5963ea
PE
1651 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1652
88c9450f
PE
1653 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1654
2f9442b8
PE
1655 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1656
c032b5f8
PE
1657 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1658 * charset.c (Fdefine_charset_internal): Don't initialize
1659 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1660 32-bit int (Bug#8600).
a108c10b
PE
1661
1662 * lread.c (read_integer): Be more consistent with string-to-number.
1663 Use string_to_number to do the actual conversion; this avoids
1664 rounding errors and fixes some other screwups. Without this fix,
1665 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1666 (digit_to_number): Move earlier, for benefit of read_integer.
1667 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1668 not a digit in any supported base. (Bug#8602)
a108c10b 1669
ad5f9eea
PE
1670 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1671
aec1708a
PE
1672 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1673 to match comment at start of function. This also removes a
1674 GCC warning about overflow in a 32+64-bit port.
1675
47be4ab5
PE
1676 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1677
371cac43
PE
1678 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1679 Reported by Stefan Monnier in
1680 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1681 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1682 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1683
d01a7826
PE
1684 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1685 (EMACS_UINTPTR): Likewise, with uintptr_t.
1686
7fd47d5c
PE
1687 * lisp.h: Prefer 64-bit EMACS_INT if available.
1688 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1689 on 32-bit hosts that have 64-bit int, so that they can access
1690 large files.
122b0c86
PE
1691 However, temporarily disable this change unless the temporary
1692 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1693
8727937b
PE
1694 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1695
8ac068ac
PE
1696 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1697 This removes an assumption that EMACS_INT and long are the same
1698 width as pointers. The assumption is true for Emacs porting targets
1699 now, but we want to make other targets possible.
1700 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1701 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1702 In the rest of the code, change types of integers that hold casted
1703 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1704 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1705 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1706 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1707 No need to cast type when ORing.
1708 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1709 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1710 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1711 assume EMACS_INT is the same width as char *.
1712 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1713 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1714 Remove no-longer-needed casts.
1715 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1716 (xg_tool_bar_help_callback, xg_make_tool_item):
1717 Use EMACS_INTPTR to hold an integer
1718 that will be cast to void *; this can avoid a GCC warning
1719 if EMACS_INT is not the same width as void *.
1720 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1721 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1722 (current_message_1, set_message_1):
1723 Use a local to convert to proper width without a cast.
1724 * xmenu.c (dialog_selection_callback): Likewise.
1725
ede49d71
PE
1726 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1727 Also, don't assume VALBITS / RAND_BITS is less than 5,
1728 and don't rely on undefined behavior when shifting a 1 left into
1729 the sign bit.
1730 * lisp.h (get_random): Change signature to match.
1731
2f30ecd0
PE
1732 * lread.c (hash_string): Use size_t, not int, for hash computation.
1733 Normally we prefer signed values; but hashing is special, because
1734 it's better to use unsigned division on hash table sizes so that
1735 the remainder is nonnegative. Also, size_t is the natural width
1736 for hashing into memory. The previous code used 'int', which doesn't
1737 retain enough info to hash well into very large tables.
1738 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1739
2a866e7b
PE
1740 * dbusbind.c: Don't possibly lose pointer info when converting.
1741 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1742 Use XPNTR rather than XHASH, so that the high-order bits of
1743 the pointer aren't lost when converting through void *.
1744
51639eac
PE
1745 * eval.c (Fautoload): Don't double-shift a pointer.
1746
92394119
PE
1747 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1748
dbdb9a7c
JB
17492011-05-06 Juanma Barranquero <lekktu@gmail.com>
1750
1751 * gnutls.c (DEF_GNUTLS_FN):
1752 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1753
db7a0b4f
AS
17542011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1755
1756 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1757 marker. (Bug#8610)
1758
f7ff1b0f 17592011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1760
1761 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1762 New version that can reserve upto 2GB of heap space.
1763
f7ff1b0f 17642011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1765
1766 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1767
639c109b
TZ
17682011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1769
1770 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1771 `gnutls_certificate_set_x509_key_file'.
1772
d2127135
JB
17732011-05-05 Juanma Barranquero <lekktu@gmail.com>
1774
1775 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1776 Update dependencies.
1777
e968f4f3
JB
17782011-05-04 Juanma Barranquero <lekktu@gmail.com>
1779
1780 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1781 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1782 Remove unused parameter `fildes'.
1783 * process.c (read_process_output, send_process): Don't pass it.
1784
84d358f0
JB
17852011-05-04 Juanma Barranquero <lekktu@gmail.com>
1786
1787 Fix previous change: the library cache is defined in w32.c.
1788 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1789 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1790
0898ca10
JB
17912011-05-04 Juanma Barranquero <lekktu@gmail.com>
1792
1793 Implement dynamic loading of GnuTLS on Windows.
1794
1795 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1796 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1797 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1798 Declare.
1799
1800 * gnutls.c (Qgnutls_dll): Define.
1801 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1802 (gnutls_*): Declare function pointers.
1803 (init_gnutls_functions): New function to initialize function pointers.
1804 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1805 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1806 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1807 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1808 (emacs_gnutls_write, emacs_gnutls_read)
1809 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1810 (Fgnutls_available_p): New function.
1811 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1812 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1813 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1814
1815 * image.c: Include w32.h.
1816 (Vimage_type_cache): Delete.
1817 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1818 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1819 (w32_delayed_load): Move to w32.c.
1820
1821 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1822
1823 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1824 (w32_delayed_load): Move from image.c. When loading a library, record
1825 its filename in the :loaded-from property of the library id.
1826 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1827 Initialize and staticpro them.
1828 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1829
1830 * process.c: Include lisp.h before w32.h, not after.
1831 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1832 instead of gnutls_record_check_pending.
1833
1834 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1835
ff4de4aa
TZ
18362011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1837
1838 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1839 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1840 as passed in.
1841
abe95abb
JD
18422011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1843
1844 * xterm.c (x_set_frame_alpha): Do not set property on anything
1845 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1846
e16e55d4
JB
18472011-05-02 Juanma Barranquero <lekktu@gmail.com>
1848
1849 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1850
bafcf6a5
JB
18512011-05-02 Juanma Barranquero <lekktu@gmail.com>
1852
1853 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1854 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1855 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1856 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1857 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1858 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1859 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1860 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1861 (Qgnutls_bootprop_callbacks_verify): Make static.
1862
e7a6747f
AS
18632011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1864
19ed11ba
AS
1865 * callproc.c: Indentation fixup.
1866
e7a6747f 1867 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1868 (wait_for_termination, interruptible_wait_for_termination):
1869 Move after wait_for_termination_1.
e7a6747f 1870
1ef14cb4
LMI
18712011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1872
1873 * sysdep.c (interruptible_wait_for_termination): New function
1874 which is like wait_for_termination, but allows keyboard
1875 interruptions.
1876
1877 * callproc.c (Fcall_process): Add (:file "file") as an option for
1878 the STDOUT buffer.
1879 (Fcall_process_region): Ditto.
1880
330d880c
EZ
18812011-04-30 Eli Zaretskii <eliz@gnu.org>
1882
8db90b73
EZ
1883 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1884 rather than `XVECTOR (FOO)->size'.
1885
330d880c
EZ
1886 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1887 inttypes.h, as a gnulib replacement is used if it not available in
1888 system headers.
1889
15cbd324
EZ
18902011-04-21 Eli Zaretskii <eliz@gnu.org>
1891
1892 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1893 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1894 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1895
1896 * coding.c (coding_alloc_by_realloc): Error out if destination
1897 will grow beyond MOST_POSITIVE_FIXNUM.
1898 (decode_coding_emacs_mule): Abort if there isn't enough place in
1899 charbuf for the composition carryover bytes. Reserve an extra
1900 space for up to 2 characters produced in a loop.
1901 (decode_coding_iso_2022): Abort if there isn't enough place in
1902 charbuf for the composition carryover bytes.
1903
19042011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1905
ae940cca
EZ
1906 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1907 aborting when %lld or %lll format is passed.
1908 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1909 %llo or %llx format is passed. (Bug#8545)
1910
03ab8921
EZ
1911 * window.c (window_scroll_line_based): Use a marker instead of
1912 simple variables to record original value of point. (Bug#7952)
1913
afda1437
EZ
1914 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1915 produced by %s or %c overflows available buffer space. (Bug#8545)
1916
f76dee0c
PE
19172011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1918
1919 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1920 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1921
fdc5744d
JB
19222011-04-28 Juanma Barranquero <lekktu@gmail.com>
1923
1924 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1925
638f053a
JB
19262011-04-28 Juanma Barranquero <lekktu@gmail.com>
1927
1928 * keyboard.c (Qdelayed_warnings_hook): Define.
1929 (command_loop_1): Run `delayed-warnings-hook'
1930 if Vdelayed_warnings_list is non-nil.
1931 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1932 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1933
d178f871
EZ
19342011-04-28 Eli Zaretskii <eliz@gnu.org>
1935
1936 * doprnt.c (doprnt): Don't return value smaller than the buffer
1937 size if the message was truncated. (Bug#8545).
1938
b124fd93
JB
19392011-04-28 Juanma Barranquero <lekktu@gmail.com>
1940
1941 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1942 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1943
e810457d
PE
19442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1945
1946 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1947
ea51cceb
JB
19482011-04-27 Juanma Barranquero <lekktu@gmail.com>
1949
1950 * makefile.w32-in: Update dependencies.
1951
94dcfacf
EZ
19522011-04-27 Eli Zaretskii <eliz@gnu.org>
1953
1954 Improve `doprnt' and its usage. (Bug#8545)
1955 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1956 `format_end'. Remove support for %l as a conversion specifier.
1957 Don't use xrealloc. Improve diagnostics when the %l size modifier
1958 is used. Update the commentary.
1959
1960 * eval.c (verror): Simplify calculation of size_t.
1961
1962 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1963 messages.
1964
f61f41d7
PE
19652011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1966
1967 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1968 change.
1969
96fb4434
PE
19702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1973 This makes this file independent of the recent pseudovector change.
1974
671875da 19752011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1976
69e9b5a3
PE
1977 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1978
b5f869a7 1979 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1980 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1981 Remove unused local.
c8926152 1982 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1983
841a1577 1984 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1985 GCC 4.6.0 optimizes based on type-based alias analysis.
1986 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1987 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1988 != &v->size, and therefore "v->size = 1; b->size = 2; return
1989 v->size;" must therefore return 1. This assumption is incorrect
1990 for Emacs, since it type-puns struct Lisp_Vector * with many other
1991 types. To fix this problem, this patch adds a new type struct
f904488f 1992 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1993 and pseudovectors, and helps optimizing compilers not get fooled
1994 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1995 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1996 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1997 the size member.
eab3844f
PE
1998 (XSETPVECTYPE): Rewrite in terms of new macro.
1999 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2000 This is a bit clearer, and further avoids the possibility of
2001 undesirable aliasing.
2002 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2003 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2004 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2005 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2006 (ASIZE): Now uses header.size rather than size.
2007 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2008 to avoid the hassle of writing XVECTOR (foo)->header.size.
2009 (struct vectorlike_header): New type.
eab3844f
PE
2010 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2011 object, to help avoid aliasing.
2012 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2013 (SUBRP): Likewise, since Lisp_Subr is a special case.
2014 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2015 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2016 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2017 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2018 changed to be "header.size" and "header.next".
2019 * buffer.h (struct buffer): Likewise.
2020 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2021 * frame.h (struct frame): Likewise.
2022 * process.h (struct Lisp_Process): Likewise.
2023 * termhooks.h (struct terminal): Likewise.
2024 * window.c (struct save_window_data, struct saved_window): Likewise.
2025 * window.h (struct window): Likewise.
2026 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2027 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2028 * buffer.c (init_buffer_once): Likewise.
2029 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2030 special case.
2031 * process.c (Fformat_network_address): Use local var for size,
2032 for brevity.
2033
0df1eac5
PE
2034 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2035
847ab9d1 2036 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2037 * data.c (atof): Remove decl; no longer used or needed.
2038 (digit_to_number): Move to lread.c.
2039 (Fstring_to_number): Use new string_to_number function, to be
2040 consistent with how the Lisp reader treats infinities and NaNs.
2041 Do not assume that floating-point numbers represent EMACS_INT
2042 without losing information; this is not true on most 64-bit hosts.
2043 Avoid double-rounding errors, by insisting on integers when
2044 parsing non-base-10 numbers, as the documentation specifies.
2045 * lisp.h (string_to_number): New decl, replacing ...
2046 (isfloat_string): Remove.
bc0a5c13 2047 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2048 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2049 appears to have been a coding error. Similarly, do not accept
2050 strings like +-1e0 as floating point numbers. Do not report
2051 overflow for integer overflows unless the base is not 10 which
2052 means we have no simple and reliable way to continue.
2053 Break out the floating-point parsing into a new
2054 function string_to_number, so that Fstring_to_number parses
2055 floating point numbers consistently with the Lisp reader.
04f2d78b 2056 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2057 (E_CHAR, EXP_INT): Remove, replacing with ...
2058 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2059 (string_to_number): New function, replacing isfloat_string.
2060 This function checks for valid syntax and produces the resulting
2061 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2062 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2063 so that overflow for non-base-10 numbers is reported only when
2064 there's no portable and simple way to convert to floating point.
452f4150 2065
67769ffc
PE
2066 * textprop.c (set_text_properties_1): Rewrite for clarity,
2067 and to avoid GCC warning about integer overflow.
2068
c20db43f
PE
2069 * intervals.h (struct interval): Use EMACS_INT for members
2070 where EMACS_UINT might cause problems. See
2071 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2072 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2073 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2074 All uses changed.
37aa2f85
PE
2075 (offset_intervals): Tell GCC not to worry about length overflow
2076 when negating a negative length.
c20db43f 2077
2538aa2f
PE
2078 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2079 (overrun_check_free): Likewise.
2080
f2d3008d
PE
2081 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2082 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2083 word size.
2084
ec8df744
PE
2085 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2086 (gnutls_make_error): Rename local to avoid shadowing.
2087 (gnutls_emacs_global_deinit): ifdef out; not used.
2088 (Fgnutls_boot): Use const for pointer to readonly storage.
2089 Comment out unused local. Fix pointer signedness problems.
2090
640ee02d
PE
2091 * lread.c (openp): Don't stuff size_t into an 'int'.
2092 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2093 about possible signed overflow.
2094
6048fb2a
PE
2095 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2096 (GDK_KEY_g): Don't define if already defined.
2097 (xg_prepare_tooltip): Avoid pointer signedness problem.
2098 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2099
fa3c87e1
PE
2100 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2101 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2102
2172544b
PE
2103 * xfns.c (Fx_window_property): Simplify a bit,
2104 to make a bit faster and to avoid GCC 4.6.0 warning.
2105 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2106
9b821a21
PE
2107 * fns.c (internal_equal): Don't assume size_t fits in int.
2108
3c616cfa
PE
2109 * alloc.c (compact_small_strings): Tighten assertion a little.
2110
c2982e87
PE
2111 Replace pEd with more-general pI, and fix some printf arg casts.
2112 * lisp.h (pI): New macro, generalizing old pEd macro to other
2113 conversion specifiers. For example, use "...%"pI"d..." rather
2114 than "...%"pEd"...".
2115 (pEd): Remove. All uses replaced with similar uses of pI.
2116 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2117 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2118 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2119 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2120 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2121 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2122 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2123 64-bit hosts.
2124 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2125 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2126 * print.c (safe_debug_print, print_object): Likewise.
2127 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2128 to int.
6f04d126
PE
2129 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2130 avoiding the 0 flag, which is not portable.
c2982e87
PE
2131 * process.c (Fmake_network_process): Use pI to avoid cast.
2132 * region-cache.c (pp_cache): Likewise.
2133 * xdisp.c (decode_mode_spec): Likewise.
2134 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2135 behavior on 64-bit hosts with printf arg.
6f04d126 2136 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2137 (x_stop_queuing_selection_requests): Likewise.
2138 (x_get_window_property): Don't truncate byte count to an 'int'
2139 when tracing.
0b432f21 2140
5e073ec7
PE
2141 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2142 here, since it parses constructs like leading '-' and spaces,
2143 which are not wanted; and it overflows with large numbers.
2144 Instead, simply match F[0-9]+, which is what is wanted anyway.
2145
36372bf9
PE
2146 * alloc.c: Remove unportable assumptions about struct layout.
2147 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2148 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2149 (allocate_vectorlike, make_pure_vector): Use the new macros,
2150 plus offsetof, to remove unportable assumptions about struct layout.
2151 These assumptions hold on all porting targets that I know of, but
2152 they are not guaranteed, they're easy to remove, and removing them
2153 makes further changes easier.
2154
0b432f21
PE
2155 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2156 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2157 (string_overrun_cookie): Now const. Use initializers that
2158 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2159 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2160 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2161 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2162 multiple of sizeof (EMACS_INT); it need not be, if
2163 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2164 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2165
895009e1
JB
21662011-04-26 Juanma Barranquero <lekktu@gmail.com>
2167
2168 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2169
6a7a1b0b
TZ
21702011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2171
2172 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2173 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2174 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2175
841a1577 21762011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2177
2178 * lisp.h (Qdebug): List symbol.
895009e1 2179 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2180 * keyboard.c (debug-on-event): New variable.
2181 (handle_user_signal): Break into debugger when debug-on-event
2182 matches the current signal symbol.
2183
f2d3ba6f
DN
21842011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2185
2186 * alloc.c (check_sblock, check_string_bytes)
2187 (check_string_free_list): Convert to standard C.
2188
42ce4c63
TZ
21892011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2190
2191 * w32.c (emacs_gnutls_push): Fix typo.
2192
825cd63c
EZ
21932011-04-25 Eli Zaretskii <eliz@gnu.org>
2194
fb11d64d
EZ
2195 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2196 "cast to pointer from integer of different size".
2197
825cd63c
EZ
2198 Improve doprnt and its use in verror. (Bug#8545)
2199 * doprnt.c (doprnt): Document the set of format control sequences
2200 supported by the function. Use SAFE_ALLOCA instead of always
2201 using `alloca'.
2202
2203 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2204 is one byte too soon. Don't use xrealloc; instead xfree and
2205 xmalloc anew.
2206
e061a11b
TZ
22072011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2208
2209 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2210 callbacks stage.
2211
2212 * gnutls.c: Renamed global_initialized to
2213 gnutls_global_initialized. Added internals for the
2214 :verify-hostname-error, :verify-error, and :verify-flags
2215 parameters of `gnutls-boot' and documented those parameters in the
2216 docstring. Start callback support.
2217 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2218 unless a fatal error occured. Call gnutls_alert_send_appropriate
2219 on error. Return error code.
2220 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2221 (emacs_gnutls_read): Likewise.
2222 (Fgnutls_boot): Return handshake error code.
2223 (emacs_gnutls_handle_error): New function.
2224 (wsaerror_to_errno): Likewise.
2225
2226 * w32.h (emacs_gnutls_pull): Add prototype.
2227 (emacs_gnutls_push): Likewise.
2228
2229 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2230 (emacs_gnutls_push): Likewise.
2231
22322011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2233
2234 * process.c (wait_reading_process_output): Check if GnuTLS
2235 buffered some data internally if no FDs are set for TLS
2236 connections.
2237
2238 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2239 (LIBS): Link to USER_LIBS.
2240 ($(BLD)/gnutls.$(0)): New target.
2241
fa6996bc
EZ
22422011-04-24 Eli Zaretskii <eliz@gnu.org>
2243
eb35682e
EZ
2244 * xdisp.c (handle_single_display_spec): Rename the
2245 display_replaced_before_p argument into display_replaced_p, to
2246 make it consistent with the commentary. Fix typos in the
2247 commentary.
2248
e2ad650c
EZ
2249 * textprop.c (syms_of_textprop): Remove dead code.
2250 (copy_text_properties): Delete obsolete commentary about an
2251 interface that was deleted long ago. Fix typos in the description
2252 of arguments.
2253
1b2de274
EZ
2254 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2255 to changes in oldXMenu/XMenu.h from 2011-04-16.
2256 <menu_help_message, prev_menu_help_message>: Constify.
2257 (IT_menu_make_room): menu->help_text is now `const char **';
2258 adjust.
2259
2260 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2261 to changes in oldXMenu/XMenu.h from 2011-04-16.
2262 (struct XMenu): Declare `help_text' `const char **'.
2263
2264 * xfaces.c <Qunspecified>: Make extern again.
2265
2266 * syntax.c: Include sys/types.h before including regex.h, as
2267 required by Posix.
2268
762b15be
EZ
2269 * doc.c (get_doc_string): Improve the format passed to `error'.
2270
2271 * doprnt.c (doprnt): Improve commentary.
2272
2273 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2274
2275 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2276 them with etags.
2277
f1052e5d
EZ
2278 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2279 changes in globals.h immediately force recompilation.
762b15be
EZ
2280 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2281 $(CURDIR)/s/ms-w32.h.
2282 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2283
fa6996bc
EZ
2284 * character.c (Fchar_direction): Function deleted.
2285 (syms_of_character): Don't defsubr it.
2286 <char-direction-table>: Deleted.
2287
e6c3da20
EZ
22882011-04-23 Eli Zaretskii <eliz@gnu.org>
2289
2290 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2291 * doprnt.c: Include limits.h.
2292 (SIZE_MAX): New macro.
04f2d78b
CB
2293 (doprnt): Return a size_t value. 2nd arg is now size_t.
2294 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2295 Improve overflow protection. Support `l' modifier for integer
2296 conversions. Support %l conversion. Don't assume an EMACS_INT
2297 argument for integer conversions and for %c.
2298
2299 * lisp.h (doprnt): Restore prototype.
2300
2301 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2302 $(SRC)/character.h.
2303
2304 * Makefile.in (base_obj): Add back doprnt.o.
2305
2306 * deps.mk (doprnt.o): Add back prerequisites.
2307 (callint.o): Depend on character.h.
2308
2309 * eval.c (internal_lisp_condition_case): Include the handler
2310 representation in the error message.
2311 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2312 when breaking from the loop.
2313
2314 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2315
2316 * callint.c (Fcall_interactively): When displaying error message
2317 about invalid control letter, pass the character's codepoint, not
2318 a pointer to its multibyte form. Improve display of the character
2319 in octal and display also its hex code.
2320
2321 * character.c (char_string): Use %x to display the (unsigned)
2322 codepoint of an invalid character, to avoid displaying a bogus
2323 negative value.
2324
2325 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2326 `error', not SYMBOL_NAME itself.
2327
2328 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2329 character arguments to `error'.
2330
2331 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2332 to `error' in error message about FINAL_CHAR argument. Make sure
2333 FINAL_CHAR is a character, and use %c when it is passed as
2334 argument to `error'.
2335
4ffd0d6b 23362011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2337
2338 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2339
2340 * w32.c: Include <time.h>.
2341 (sys_localtime): New function.
2342
4ffd0d6b 23432011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2344
2345 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2346
4ffd0d6b 2347 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2348
4ffd0d6b 23492011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2350
4ffd0d6b
GM
2351 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2352 zombies (Bug#8467).
aac0c6e3 2353
04c56954
EZ
23542011-04-19 Eli Zaretskii <eliz@gnu.org>
2355
2356 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2357 gl_state.e_property when gl_state.object is Qt.
2358
2359 * insdel.c (make_gap_larger): Remove limitation of buffer size
2360 to <= INT_MAX.
2361
16a43933
CY
23622011-04-18 Chong Yidong <cyd@stupidchicken.com>
2363
2364 * xdisp.c (lookup_glyphless_char_display)
2365 (produce_glyphless_glyph): Handle cons cell entry in
2366 glyphless-char-display.
2367 (Vglyphless_char_display): Document it.
2368
2369 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2370 glyphless-char-display.
2371
4581706e
CY
23722011-04-17 Chong Yidong <cyd@stupidchicken.com>
2373
2374 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2375
2376 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2377
2378 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2379 definition for no-X builds.
2380
4887c6e2 23812011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2382
fd35b6f9
PE
2383 Static checks with GCC 4.6.0 and non-default toolkits.
2384
5c1ccb01
PE
2385 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2386
006c5daa
PE
2387 * process.c (keyboard_bit_set): Define only if SIGIO.
2388 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2389 (send_process): Repair possible setjmp clobbering.
2390
efc736d3
PE
2391 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2392
4e2fe2e6
PE
2393 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2394
f97334a2
PE
2395 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2396
4e75f29d
PE
2397 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2398 Define only if needed.
2399
90efadd1
PE
2400 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2401 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2402 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2403
3c647824
PE
2404 * dispextern.h (struct redisplay_interface): Rename param
2405 to avoid shadowing.
e264f262 2406 * termhooks.h (struct terminal): Likewise.
761383f4 2407 * xterm.c (xembed_send_message): Likewise.
3c647824 2408
b58c5c4a
PE
2409 * insdel.c (make_gap_smaller): Define only if
2410 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2411
cad59032
PE
2412 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2413 it.
2414
c339dc2e
PE
2415 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2416 so that we aren't warned about unused symbols.
2417
91a3e27b
PE
2418 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2419
399c71d3 2420 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2421
8ffc96f5
PE
2422 * xfns.c (x_real_positions): Mark locals as initialized.
2423
eef9bc79
PE
2424 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2425
098db9dd
PE
2426 * xterm.c: Fix problems found by static analysis with other toolkits.
2427 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2428 (x_dispatch_event): Declare static if USE_GTK, and
2429 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2430 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2431 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2432 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2433 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2434
eb18f6cc
PE
2435 * xmenu.c (menu_help_callback): Pointer type fixes.
2436 Use const pointers when pointing at readonly data. Avoid pointer
2437 signedness clashes.
2438 (FALSE): Remove unused macro.
2439 (update_frame_menubar): Remove unused decl.
2440
1fe72bf8
PE
2441 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2442
60d9e1db
PE
2443 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2444 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2445 (single_menu_item): Rename local to avoid shadowing.
2446
39261c26
PE
2447 * keyboard.c (make_lispy_event): Remove unused local var.
2448
018c5e19
PE
2449 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2450 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2451
63d2b86e
PE
2452 * bitmaps: Change bitmaps from unsigned char back to the X11
2453 compatible char. Avoid the old compiler warnings about
2454 out-of-range initializers by using, for example, '\xab' rather
2455 than 0xab.
2456
aefd87e1
PE
2457 * xgselect.c (xgselect_initialize): Check vs interface
2458 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2459
bf501fb9
PE
2460 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2461
e9829fdf
PE
2462 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2463 to read-only memory.
2464
1086c095
PE
2465 * fns.c (vector): Remove; this old hack is no longer needed.
2466
2baccd04 2467 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2468 Remove unused var.
dde42981 2469 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2470
72391843 2471 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2472
436c16df 2473 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2474 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2475 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2476
92bb796d 2477 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2478 (x_term_init): Remove local to avoid shadowing.
92bb796d 2479
764430a3 2480 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2481
2482 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2483 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2484
d1dfb56c
EZ
24852011-04-16 Eli Zaretskii <eliz@gnu.org>
2486
c4354cb4
EZ
2487 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2488
d1dfb56c
EZ
2489 Fix regex.c, syntax.c and friends for buffers > 2GB.
2490 * syntax.h (struct gl_state_s): Declare character position members
2491 EMACS_INT.
2492
2493 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2494
04f2d78b
CB
2495 * textprop.c (verify_interval_modification, interval_of):
2496 Declare arguments EMACS_INT.
d1dfb56c
EZ
2497
2498 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2499 EMACS_INT.
2500
2501 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2502
2503 * indent.c (Fvertical_motion): Local variable it_start is now
2504 EMACS_INT.
2505
2506 * regex.c (re_match, re_match_2, re_match_2_internal)
2507 (bcmp_translate, regcomp, regexec, print_double_string)
2508 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2509 (re_compile_pattern, re_exec): Declare arguments and local
2510 variables `size_t' and `ssize_t' and return values `regoff_t', as
2511 appropriate.
2512 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2513 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2514 <compile_stack_type>: `size' and `avail' are now `size_t'.
2515
2516 * regex.h <regoff_t>: Use ssize_t, not int.
2517 (re_search, re_search_2, re_match, re_match_2): Arguments that
2518 specify buffer/string position and length are now ssize_t and
2519 size_t. Return type is regoff_t.
2520
613052cd
BK
25212011-04-16 Ben Key <bkey76@gmail.com>
2522
2523 * nsfont.m: Fixed bugs in ns_get_family and
2524 ns_descriptor_to_entity that were caused by using free to
2525 deallocate memory blocks that were allocated by xmalloc (via
2526 xstrdup). This caused Emacs to crash when compiled with
2527 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2528 --enable-checking=xmallocoverrun). xfree is now used to
2529 deallocate these memory blocks.
2530
4170f62f 25312011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2532
71b41406
PE
2533 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2534
9587a89d
PE
2535 emacs_write: Accept and return EMACS_INT for sizes.
2536 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2537 et seq.
2538 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2539 Accept and return EMACS_INT.
2540 (emacs_gnutls_write): Return the number of bytes written on
2541 partial writes.
2542 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2543 (emacs_read, emacs_write): Remove check for negative size, as the
2544 Emacs source code has been audited now.
9587a89d
PE
2545 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2546 (emacs_read, emacs_write): Use it.
273a5f82
PE
2547 * process.c (send_process): Adjust to the new signatures of
2548 emacs_write and emacs_gnutls_write. Do not attempt to store
2549 a byte offset into an 'int'; it might overflow.
9587a89d 2550 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2551
3e047f51
PE
2552 * sound.c: Don't assume sizes fit in 'int'.
2553 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2554 Return EMACS_INT, not int.
3e047f51 2555 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2556 Accept EMACS_INT, not int.
2557 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2558 record read return values.
2559
cc39a9db
BK
25602011-04-15 Ben Key <bkey76@gmail.com>
2561
c9d0ec6d
JB
2562 * keyboard.c (Qundefined): Don't declare static since it is used
2563 in nsfns.m.
2564 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2565 static since they are used in nsfont.m.
cc39a9db 2566
6c60eb9f
SM
25672011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2568
2569 * process.c (Qprocessp): Don't declare static.
2570 * lisp.h (Qprocessp): Declare again.
2571
7990b61a
JB
25722011-04-15 Juanma Barranquero <lekktu@gmail.com>
2573
2574 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2575
5d4cb038
PE
25762011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2577
8bd7b830 2578 Improve C-level modularity by making more things 'static'.
cd64ea1d 2579
e3b27b31
PE
2580 Don't publish debugger-only interfaces to other modules.
2581 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2582 (verify_bytepos, count_markers): Move decls to the only modules
2583 that need them.
2584 * region-cache.h (pp_cache): Likewise.
2585 * window.h (check_all_windows): Likewise.
2586 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2587
5d4cb038
PE
2588 * sysdep.c (croak): Now static, if
2589 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2590 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2591
2592 * alloc.c (refill_memory_reserve): Now static if
2593 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2594 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2595
e87b6180
PE
2596 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2597 Define only if USE_LUCID.
2598
ac64929e
PE
2599 * xrdb.c (x_customization_string, x_rm_string): Now static.
2600
6f37259d
PE
2601 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2602 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2603
1683e3ab
PE
2604 * xdisp.c (draw_row_with_mouse_face): Now static.
2605 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2606
de9c2632
PE
2607 * window.h (check_all_windows): Mark externally visible.
2608
2b96acb7
PE
2609 * window.c (window_deletion_count): Now static.
2610
2611 * undo.c: Make symbols static if they're not exported.
2612 (last_undo_buffer, last_boundary_position, pending_boundary):
2613 Now static.
2614
50436f33
PE
2615 * textprop.c (interval_insert_behind_hooks): Now static.
2616 (interval_insert_in_front_hooks): Likewise.
2617
64520e5c
PE
2618 * term.c: Make symbols static if they're not exported.
2619 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2620 (max_frame_lines, tty_set_terminal_modes):
2621 (tty_reset_terminal_modes, tty_turn_off_highlight):
2622 (get_tty_terminal): Now static.
2623 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2624 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2625 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2626 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2627 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2628
1fa53021
PE
2629 * sysdep.c: Make symbols static if they're not exported.
2630 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2631 Now static.
2632 (sigprocmask_set, full_mask): Remove; unused.
2633 (wait_debugging): Mark as visible.
2634 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2635 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2636
d4b43b22
PE
2637 * syntax.c (syntax_temp): Define only if !__GNUC__.
2638
b7c513d0
PE
2639 * sound.c (current_sound_device, current_sound): Now static.
2640
989b29ad
PE
2641 * search.c (searchbufs, searchbuf_head): Now static.
2642
13a55a78
PE
2643 * scroll.c (scroll_cost): Remove; unused.
2644 * dispextern.h (scroll_cost): Remove decl.
2645
de68a1fc
PE
2646 * region-cache.h (pp_cache): Mark as externally visible.
2647
40ccffa6
PE
2648 * process.c: Make symbols static if they're not exported.
2649 (process_tick, update_tick, create_process, chan_process):
2650 (Vprocess_alist, proc_buffered_char, datagram_access):
2651 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2652 (deactivate_process): Mark defn as static, as well as decl.
2653 * lisp.h (create_process): Remove decl.
2654 * process.h (chan_process, Vprocess_alist): Remove decls.
2655
ad64fc97
PE
2656 * print.c: Make symbols static if they're not exported.
2657 (print_depth, new_backquote_output, being_printed, print_buffer):
2658 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2659 (print_interval, print_number_index, initial_stderr_stream):
2660 Now static.
2661 * lisp.h (Fprinc): Remove decl.
2662 (debug_output_compilation_hack): Mark as externally visible.
2663
adddb265
PE
2664 * sysdep.c (croak): Move decl from here to syssignal.h.
2665 * syssignal.h (croak): Put it here, so the API can be checked when
2666 'croak' is called from dissociate_if_controlling_tty.
2667
1717ede2
PE
2668 * minibuf.c: Make symbols static if they're not exported.
2669 (minibuf_save_list, choose_minibuf_frame): Now static.
2670 * lisp.h (choose_minibuf_frame): Remove decl.
2671
fa5fb2bc
PE
2672 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2673
1e3890d1
PE
2674 * lread.c: Make symbols static if they're not exported.
2675 (read_objects, initial_obarray, oblookup_last_bucket_number):
2676 Now static.
2677 (make_symbol): Remove; unused.
2678 * lisp.h (initial_obarray, make_symbol): Remove decls.
2679
8a1414fa
PE
2680 * keyboard.c: Make symbols static if they're not exported.
2681 (single_kboard, recent_keys_index, total_keys, recent_keys):
2682 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2683 (this_single_command_key_start, echoing, last_auto_save):
2684 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2685 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2686 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2687 (Vlispy_mouse_stem, double_click_count):
2688 Now static.
2689 (force_auto_save_soon): Define only if SIGDANGER.
2690 (ignore_mouse_drag_p): Now static if
2691 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2692 (print_help): Remove; unused.
2693 (stop_character, last_timer_event): Mark as externally visible.
2694 * keyboard.h (ignore_mouse_drag_p): Declare only if
2695 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2696 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2697 * lisp.h (echoing): Remove decl.
2698 (force_auto_save_soon): Declare only if SIGDANGER.
2699 * xdisp.c (redisplay_window): Simplify code, to make it more
2700 obvious that ignore_mouse_drag_p is not accessed if !defined
2701 USE_GTK && !defined HAVE_NS.
2702
93ea6e8f
PE
2703 * intervals.c: Make symbols static if they're not exported.
2704 (merge_properties_sticky, merge_interval_right, delete_interval):
2705 Now static.
2706 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2707
77382fcc
PE
2708 * insdel.c: Make symbols static if they're not exported.
2709 However, leave prepare_to_modify_buffer alone. It's never
2710 called from outside this function, but that appears to be a bug.
2711 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2712 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2713 (adjust_after_replace_noundo): Remove; unused.
2714 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2715 (signal_before_change): Remove decls.
77382fcc 2716
9306c32e
PE
2717 * indent.c (val_compute_motion, val_vmotion): Now static.
2718
cd44d2eb
PE
2719 * image.c: Make symbols static if they're not exported.
2720 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2721 if USE_GTK.
2722 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2723 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2724
ad9a7a06
PE
2725 * fringe.c (standard_bitmaps): Now static.
2726 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2727
81626931
PE
2728 * frame.c: Make symbols static if they're not exported.
2729 (x_report_frame_params, make_terminal_frame): Now static.
2730 (get_frame_param): Now static, unless HAVE_NS.
2731 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2732 (x_get_resource_string): Remove; not used.
2733 * frame.h (make_terminal_frame, x_report_frame_params):
2734 (x_get_resource_string); Remove decls.
2735 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2736 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2737
239f9db9
PE
2738 * font.c, fontset.c: Make symbols static if they're not exported.
2739 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2740 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2741 * font.c (font_close_object): Now static.
2742 * font.h (font_close_object): Remove.
2743 * fontset.c (FONTSET_OBJLIST): Remove.
2744 (free_realized_fontset) #if-0 the body, which does nothing.
2745 (face_suitable_for_char_p): #if-0, as it's never called.
2746 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2747 * xfaces.c (face_at_string_position):
2748 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2749 since 0 is always ASCII.
2750
dfcf3579
PE
2751 * fns.c (weak_hash_tables): Now static.
2752
5045092b
PE
2753 * fileio.c: Make symbols static if they're not exported.
2754 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2755 (Vwrite_region_annotation_buffers): Now static.
2756
57a96f5c
PE
2757 * eval.c: Make symbols static if they're not exported.
2758 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2759 * lisp.h (backtrace_list): Remove decl.
2760
35f08c38
PE
2761 * emacs.c: Make symbols static if they're not exported.
2762 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2763 (fatal_error_code, fatal_error_signal_hook, standard_args):
2764 Now static.
2765 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2766 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2767 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2768 * lisp.h (fatal_error_signal_hook): Remove decl.
2769 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2770
f44bd759
PE
2771 * editfns.c: Move a (normally-unused) function to its only use.
2772 * editfns.c, lisp.h (get_operating_system_release): Remove.
2773 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2774 worth the hassle of breaking this out.
2775
b532497d
PE
2776 * xterm.c: Make symbols static if they're not exported.
2777 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2778 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2779 (x_destroy_window, x_delete_display):
2780 Now static.
2781 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2782 (x_mouse_leave): Remove; unused.
2783 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2784 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2785 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2786 Remove decls.
2787 (x_mouse_leave): Declare only if WINDOWSNT.
2788 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2789 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2790 USE_X_TOOLKIT.
2791
1675728f
PE
2792 * ftxfont.c: Make symbols static if they're not exported.
2793 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2794 HAVE_FREETYPE.
2795 * font.h (ftxfont_driver): Likewise.
2796
e4cebfca
PE
2797 * xfns.c: Make symbols static if they're not exported.
2798 (x_last_font_name, x_display_info_for_name):
2799 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2800 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2801 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2802 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2803 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2804 (last_show_tip_args): Now static.
2805 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2806 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2807 (x_screen_planes): Remove; unused.
2808 * dispextern.h (x_screen_planes): Remove decl.
2809
5bf46f05
PE
2810 * dispnew.c: Make symbols static if they're not exported.
2811 * dispextern.h (redraw_garbaged_frames, scrolling):
2812 (increment_row_positions): Remove.
2813 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2814 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2815 Now static.
2816 (redraw_garbaged_frames): Remove; unused.
2817
435f4c28
PE
2818 * xfaces.c: Make symbols static if they're not exported.
2819 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2820 Remove decls.
2821 * xterm.h (defined_color): Remove decls.
2822 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2823 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2824 (menu_face_changed_default, defined_color, free_realized_face):
2825 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2826 (ascii_face_of_lisp_face): Remove; unused.
2827
8524aef3
PE
2828 * xdisp.c: Make symbols static if they're not exported.
2829 * dispextern.h (scratch_glyph_row, window_box_edges):
2830 (glyph_to_pixel_coords, set_cursor_from_row):
2831 (get_next_display_element, set_iterator_to_next):
2832 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2833 (show_mouse_face): Remove decls
2834 * frame.h (message_buf_print): Likewise.
2835 * lisp.h (pop_message, set_message, check_point_in_composition):
2836 Likewise.
2837 * xterm.h (set_vertical_scroll_bar): Likewise.
2838 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2839 (message_buf_print, scratch_glyph_row, displayed_buffer):
2840 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2841 (get_next_display_element, show_mouse_face, window_box_edges):
2842 (frame_to_window_pixel_xy, check_point_in_composition):
2843 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2844 (glyph_to_pixel_coords): Remove; unused.
2845
16390cd2
PE
2846 * dired.c (file_name_completion): Now static.
2847
2848 * dbusbind.c (xd_in_read_queued_messages): Now static.
2849
a25f4dfa
PE
2850 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2851 * data.c (circular_list_error): Remove.
2852
14a9c8df
PE
2853 * commands.h (last_point_position, last_point_position_buffer):
2854 (last_point_position_window): Remove decls.
2855 * keyboard.c: Make these variables static.
2856
04f2d78b
CB
2857 * coding.h (coding, code_convert_region, encode_coding_gap):
2858 Remove decls.
74ab6df5
PE
2859 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2860 (iso_code_class, detect_coding, code_convert_region): Now static.
2861 (encode_coding_gap): Remove; unused.
2862
38dfbee1
PE
2863 * chartab.c (chartab_chars, chartab_bits): Now static.
2864
a2cb4e63
PE
2865 * charset.h (charset_iso_8859_1): Remove decl.
2866 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2867 Now static.
2868
127198fd
PE
2869 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2870 * ccl.c (Vccl_program_table): Now static.
2871 (check_ccl_update): Remove; unused.
2872
d85b608f
PE
2873 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2874 * category.h: ... from here.
2875 * category.c (check_category_table, set_category_set): Now static.
2876
31cd66f3
PE
2877 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2878 * lisp.h: Remove these decls.
2879
c358e587
PE
2880 * buffer.c (buffer_count): Remove unused var.
2881
e78aecca
PE
2882 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2883 so that it's not optimized away.
2884 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2885 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2886 exported only to the debugger.
2887
e192d7d3 2888 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2889 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2890
92470028
PE
2891 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2892 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2893 was inaccessible from Lisp.
2894 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2895 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2896
244ed907
PE
2897 alloc.c: Import and export fewer symbols, and remove unused items.
2898 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2899 is defined.
2900 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2901 it's not optimized away by whole-program optimization.
2902 (message_enable_multibyte, free_misc): Remove.
2903 (catchlist, handlerlist, mark_backtrace):
2904 Declare only if BYTE_MARK_STACK.
2905 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2906 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2907 (message_enable_multibyte): Remove decl.
2908 (free_misc, interval_free_list, float_block, float_block_index):
2909 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2910 (cons_free_list, last_marked_index):
2911 Now static.
2912 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2913 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2914 (mark_backtrace): Define only if BYTE_MARK_STACK.
2915 * xdisp.c (message_enable_multibyte): Now static.
2916
61c2b50e 2917 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2918 This makes it easier for human readers (and static analyzers)
2919 to see whether these variables are used from other modules.
2920 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2921 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2922 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2923 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2924 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2925 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2926 * xmenu.c, xselect.c:
2927 Declare Q* vars static if they are not used in other modules.
2928 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2929 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2930 Remove decls of unexported vars.
2931 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2932
95c82688
PE
2933 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2934
16a97296
PE
2935 Make Emacs functions such as Fatom 'static' by default.
2936 This makes it easier for human readers (and static analyzers)
2937 to see whether these functions can be called from other modules.
2938 DEFUN now defines a static function. To make the function external
2939 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2940 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2941 (Finit_image_library):
16a97296
PE
2942 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2943 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2944 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2945 Remove decls, since these functions are now static.
2946 (Funintern, Fget_internal_run_time): New decls, since these functions
2947 were already external.
95c82688 2948
16a97296
PE
2949 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2950 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2951 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2952 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2953 * keyboard.c, keymap.c, lread.c:
2954 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2955 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2956 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2957 Mark functions with DEFUE instead of DEFUN,
2958 if they are used in other modules.
2959 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2960 decls for now-static functions.
2961 * buffer.h (Fdelete_overlay): Remove decl.
2962 * callproc.c (Fgetenv_internal): Mark as internal.
2963 * composite.c (Fremove_list_of_text_properties): Remove decl.
2964 (Fcomposition_get_gstring): New forward static decl.
2965 * composite.h (Fcomposite_get_gstring): Remove decl.
2966 * dired.c (Ffile_attributes): New forward static decl.
2967 * doc.c (Fdocumntation_property): New forward static decl.
2968 * eval.c (Ffetch_bytecode): New forward static decl.
2969 (Funintern): Remove extern decl; now in .h file where it belongs.
2970 * fileio.c (Fmake_symbolic_link): New forward static decl.
2971 * image.c (Finit_image_library): New forward static decl.
2972 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2973 * intervals.h (Fprevious_property_change):
2974 (Fremove_list_of_text_properties): Remove decls.
2975 * keyboard.c (Fthis_command_keys): Remove decl.
2976 (Fcommand_execute): New forward static decl.
2977 * keymap.c (Flookup_key): New forward static decl.
2978 (Fcopy_keymap): Now static.
2979 * keymap.h (Flookup_key): Remove decl.
2980 * process.c (Fget_process): New forward static decl.
2981 (Fprocess_datagram_address): Mark as internal.
2982 * syntax.c (Fsyntax_table_p): New forward static decl.
2983 (skip_chars): Remove duplicate decl.
2984 * textprop.c (Fprevious_property_change): New forward static decl.
2985 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2986 Now internal.
2987 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2988 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2989
785bbd42
PE
2990 * editfns.c (Fformat): Remove unreachable code.
2991
8b913b57
AS
29922011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2993
2994 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2995 change. (Bug#8496)
2996
a6744a35
EZ
29972011-04-13 Eli Zaretskii <eliz@gnu.org>
2998
2999 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3000 when at ZV. (Bug#8487)
3001
e7974947
AS
30022011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3003
baad03f0
AS
3004 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3005 (Bug#8437)
3006 * keyboard.c (parse_tool_bar_item): Likewise.
3007 * sound.c (sound_cleanup, alsa_close): Likewise.
3008 * termcap.c (tgetent): Likewise.
3009 * xfns.c (x_default_font_parameter): Likewise.
3010 * xsettings.c (read_and_apply_settings): Likewise.
3011
e7974947
AS
3012 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3013 (overrun_check_free): Protoize.
3014
28272684
PE
30152011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3016
3017 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3018 since callers should never pass a negative size.
3019 Change the signature to match that of plain 'read' and 'write'; see
3020 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3021 * lisp.h: Update prototypes of emacs_write and emacs_read.
3022
11997c76
EZ
30232011-04-11 Eli Zaretskii <eliz@gnu.org>
3024
3025 * xdisp.c (redisplay_window): Don't try to determine the character
3026 position of the scroll margin if the window start point w->startp
e896f03c 3027 is outside the buffer's accessible region. (Bug#8468)
11997c76 3028
8a2cbd72
EZ
30292011-04-10 Eli Zaretskii <eliz@gnu.org>
3030
3031 Fix write-region and its subroutines for buffers > 2GB.
3032 * fileio.c (a_write, e_write): Modify declaration of arguments and
3033 local variables to support buffers larger than 2GB.
3034 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3035
3036 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3037 argument, local variables, and return value.
3038
3039 * lisp.h: Update prototypes of emacs_write and emacs_read.
3040
3041 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3042
4073e537 30432011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3044
1ebfdcb6
PE
3045 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3046
b2ded58d
PE
3047 Fix more problems found by GCC 4.6.0's static checks.
3048
7d66342c
PE
3049 * xdisp.c (vmessage): Use a better test for character truncation.
3050
bbf47d44
PE
3051 * charset.c (load_charset_map): <, not <=, for optimization,
3052 and to avoid potential problems with integer overflow.
9248994d 3053 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3054 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3055 * editfns.c (Fformat): Likewise.
1e69125e 3056 * syntax.c (skip_chars): Likewise.
3befa583 3057
e3019616
PE
3058 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3059 This also lets GCC 4.6.0 generate slightly better loop code.
3060
becfa255
PE
3061 * callint.c (Fcall_interactively): <, not <=, for optimization.
3062 (Fcall_interactively): Count the number of arguments produced,
3063 not the number of arguments given. This is simpler and lets GCC
3064 4.6.0 generate slightly better code.
3065
dae0cd48
PE
3066 * ftfont.c: Distingish more carefully between FcChar8 and char.
3067 The previous code passed unsigned char * to a functions like
3068 strlen and xstrcasecmp that expect char *, which does not
3069 conform to the C standard.
3070 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3071 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3072 char * when the C standard requires it.
3073
76032d70
PE
3074 * keyboard.c (read_char): Remove unused var.
3075
eb3f1cc8
PE
3076 * eval.c: Port to Windows vsnprintf (Bug#8435).
3077 Include <limits.h>.
3078 (SIZE_MAX): Define if the headers do not.
3079 (verror): Do not give up if vsnprintf returns a negative count.
3080 Instead, grow the buffer. This ports to Windows vsnprintf, which
3081 does not conform to C99. Problem reported by Eli Zaretskii.
3082 Also, simplify the allocation scheme, by avoiding the need for
3083 calling realloc, and removing the ALLOCATED variable.
3084
70476b54
PE
3085 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3086
12020a9e
PE
3087 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3088 But keep the doprint source code for now, as we might revamp it
3089 and use it again (Bug#8435).
ea6c7ae6
PE
3090 * lisp.h (doprnt): Remove.
3091 * Makefile.in (base_obj): Remove doprnt.o.
3092 * deps.mk (doprnt.o): Remove.
3093
5fdb398c
PE
3094 error: Print 32- and 64-bit integers portably (Bug#8435).
3095 Without this change, on typical 64-bit hosts error ("...%d...", N)
3096 was used to print both 32- and 64-bit integers N, which relied on
3097 undefined behavior.
3098 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3099 New macro.
3100 * lisp.h (error, verror): Mark as printf-like functions.
3101 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3102 Report overflow in size calculations when allocating printf buffer.
3103 Do not truncate output string at its first null byte.
3104 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3105 Truncate the output at a character boundary, since vsnprintf does not
3106 do that.
3107 * charset.c (check_iso_charset_parameter): Convert internal
3108 character to string before calling 'error', since %c now has the
3109 printf meaning.
3110 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3111 overflow when computing char to be passed to 'error'. Do not
3112 pass Lisp_Object to 'error'; pass the integer instead.
3113 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3114 formatted with plain %d.
3115
b189fa66
PE
3116 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3117
bff87ef0
PE
3118 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3119
7e2cac20
PE
3120 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3121
ce4d90b5
PE
3122 * xterm.c (x_catch_errors): Remove duplicate declaration.
3123
266c9547
PE
3124 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3125
79c49ad2
PE
3126 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3127
368f4090
JM
31282011-04-10 Jim Meyering <meyering@redhat.com>
3129
3130 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3131 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3132 return ssize_t not "int", and use size_t as the buffer length.
3133 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3134 * gnutls.h: Update declarations.
3135 * process.c (read_process_output): Use ssize_t, to match.
3136 (send_process): Likewise.
3137
a32d4040
CY
31382011-04-09 Chong Yidong <cyd@stupidchicken.com>
3139
3140 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3141
8546720e 31422011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3143
04f2d78b
CB
3144 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3145 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3146
8546720e
GM
3147 * xterm.c (handle_one_xevent):
3148 * xmenu.c (create_and_show_popup_menu):
3149 * xselect.c (x_decline_selection_request)
3150 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3151
0a2f5c1a 31522011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3153
3154 Fix some uses of `int' instead of EMACS_INT.
3155 * search.c (string_match_1, fast_string_match)
3156 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3157 (scan_buffer, find_next_newline_no_quit)
3158 (find_before_next_newline, search_command, Freplace_match)
3159 (Fmatch_data): Make some `int' variables be EMACS_INT.
3160
3161 * xdisp.c (display_count_lines): 3rd argument and return value now
3162 EMACS_INT. All callers changed.
3163 (pint2hrstr): Last argument is now EMACS_INT.
3164
3165 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3166 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3167 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3168 (decode_coding_utf_16, decode_coding_emacs_mule)
3169 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3170 (decode_coding_ccl, decode_coding_charset)
3171 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3172 (decode_coding_iso_2022, decode_coding_emacs_mule)
3173 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3174 <char_offset, last_offset>: Declare EMACS_INT.
3175 (encode_coding_utf_8, encode_coding_utf_16)
3176 (encode_coding_emacs_mule, encode_invocation_designation)
3177 (encode_designation_at_bol, encode_coding_iso_2022)
3178 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3179 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3180 Declare EMACS_INT.
3181 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3182 (encode_invocation_designation): Last argument P_NCHARS is now
3183 EMACS_INT.
3184 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3185 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3186
3187 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3188 All users changed.
3189
3190 * ccl.c (Fccl_execute_on_string): Declare some variables
3191 EMACS_INT.
3192
8546720e 31932011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3194
3195 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3196
4e19a977
CS
31972011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3198
3199 * process.c (Fformat_network_address): Doc fix.
3200
87302331
R
32012011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3202
3203 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3204
cbb59342
CY
32052011-04-08 Chong Yidong <cyd@stupidchicken.com>
3206
3207 * keyboard.c (read_char): Call Lisp function help-form-show,
3208 instead of using internal_with_output_to_temp_buffer.
3209 (Qhelp_form_show): New var.
e0d38eeb 3210 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3211
3212 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3213
3214 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3215
e67a13ab
CY
32162011-04-06 Chong Yidong <cyd@stupidchicken.com>
3217
04f2d78b
CB
3218 * process.c (Flist_processes): Remove to Lisp.
3219 (list_processes_1): Delete.
e67a13ab 3220
973f782d
EZ
32212011-04-06 Eli Zaretskii <eliz@gnu.org>
3222
7c106b1e
EZ
3223 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3224
973f782d
EZ
3225 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3226
41cf7d1a 32272011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3228
ca23cc88
PE
3229 Fix more problems found by GCC 4.6.0's static checks.
3230
f390e2d5
PE
3231 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3232
42eea0d0
PE
3233 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3234
b69769da 3235 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3236
f9541e84
PE
3237 * xdisp.c (vmessage): Mark as a printf-like function.
3238
13841b55
PE
3239 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3240
c136c10f
PE
3241 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3242
5e2d4a30
PE
3243 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3244 printf-like functions.
3245 (tiff_load): Add casts to remove these marks before passing them
3246 to system-supplied API.
3247
583f48b9
PE
3248 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3249
b25d760e
PE
3250 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3251 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3252 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3253 directly, rather than having caller test rule sign. This avoids
3254 some unnecessary tests.
3255 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3256 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3257 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3258
bc7b6697 3259 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3260 (xfont_open): Avoid unnecessary tests.
bc7b6697 3261
27ccc379
PE
3262 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3263
dcd5c89a
PE
3264 * composite.h, composite.c (composition_gstring_put_cache):
3265 Use EMACS_INT, not int, for length.
3266
b13a45c6
PE
3267 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3268 breaking out part of COMPOSITION_DECODE_RULE.
3269 (COMPOSITION_DECODE_RULE): Use it.
3270 * composite.c (get_composition_id): Remove unused local vars,
3271 by using the new macro.
3272
1e792e4d
PE
3273 * textprop.c (set_text_properties_1): Change while to do-while,
3274 since the condition is always true at first.
3275
dc6c6455 3276 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3277 (interval_deletion_adjustment): Return unsigned value.
3278 All uses changed.
dc6c6455 3279
aba7731a
PE
3280 * process.c (list_processes_1, create_pty, read_process_output):
3281 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3282 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3283 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3284 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3285 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3286
fdfc4bf3
PE
3287 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3288
fca8fe46 3289 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3290 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3291
06a0259a 3292 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3293 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3294 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3295
e7b9e80f
PE
3296 * print.c (print_error_message): Avoid int overflow.
3297
56201685
PE
3298 * font.c (font_list_entities): Redo for clarity,
3299 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3300
78834453 3301 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3302 (font_score): Avoid potential overflow in diff calculation.
78834453 3303
0bc0b309 3304 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3305 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3306
e610eaca
PE
3307 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3308
b895abce
PE
3309 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3310 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3311 can always succeed if overflow has undefined behavior.
3312
1f1d9321 3313 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3314 (wordify): Omit three unnecessary tests.
1f1d9321 3315
c59478bc
PE
3316 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3317 All callers changed. This avoids the need for an unused var.
3318
79b73827
PE
3319 * casefiddle.c (casify_region): Remove var that is set but not used.
3320
a4db5dfe
PE
3321 * dired.c (file_name_completion): Remove var that is set but not used.
3322
43aae36e
PE
3323 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3324
2a47c44d 3325 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3326 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3327
a37c69bf
PE
3328 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3329 Check for integer overflow on size calculations.
3330
328ab8e7
PE
3331 * buffer.c (Fprevious_overlay_change): Remove var that is set
3332 but not used.
3333
e5a2a5cb
PE
3334 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3335 Remove vars that are set but not used.
8d84a6eb 3336 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3337 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3338
a60e5f68
PE
3339 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3340
f661cb61 3341 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3342 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3343
f0397f5a
PE
3344 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3345 that are set but not used.
3346
8664db06 3347 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3348 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3349
6abdaa4a
PE
3350 * xselect.c (x_get_local_selection, x_handle_property_notify):
3351 Remove vars that are set but not used.
3352
0ce7538d 3353 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3354 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3355
9ae848fc
PE
3356 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3357 Remove var that is set but not used.
0b918413
PE
3358 (scroll_bar_windows_size): Now size_t, not int.
3359 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3360 Check for overflow.
9ae848fc 3361
a5a62657
PE
3362 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3363 (map_tty_color) [!defined MSDOS]: Likewise.
3364
5c5cdd39
PE
3365 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3366
66ebf983
PE
3367 * coding.c: Remove vars that are set but not used.
3368 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3369 All callers changed.
3370 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3371 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3372 (decode_coding_charset): Remove vars that are set but not used.
3373
1be4d761
PE
3374 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3375 that is set but not used.
3376
47553fa8
PE
3377 * print.c (print_object): Remove var that is set but not used.
3378
1f7196bf 3379 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3380 The gnulib version avoids calling malloc in the usual case,
3381 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3382 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3383 * filelock.c (current_lock_owner): Likewise.
3384 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3385 * sysdep.c: Include allocator.h, careadlinkat.h.
3386 (emacs_no_realloc_allocator): New static constant.
3387 (emacs_readlink): New function.
fdb61804
PE
3388 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3389 ../lib/careadlinkat.h.
d1fdcab7 3390
f84c17c7
SM
33912011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3392
3393 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3394 first non-nil return value).
3395
ef3862ad
JD
33962011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3397
3398 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3399 if not defined (Bug#8403).
3400
376a7006
JB
34012011-04-02 Juanma Barranquero <lekktu@gmail.com>
3402
3403 * xdisp.c (display_count_lines): Remove parameter `start',
3404 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3405 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3406 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3407 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3408 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3409 and thereabouts. All callers changed.
3410 (get_per_char_metric): Remove parameter `f', unused since
3411 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3412
6ca3801d
JM
34132011-04-02 Jim Meyering <meyering@redhat.com>
3414
3415 do not dereference NULL upon failed strdup
3416 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3417 (ns_get_family): Likewise.
3418
d8e2b5ba
JB
34192011-04-02 Juanma Barranquero <lekktu@gmail.com>
3420
3421 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3422
8c74fcbd
JD
34232011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3424
3425 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3426 later (Bug#8403).
3427
7200d79c
SM
34282011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3429
03408648 3430 Add lexical binding.
7200d79c 3431
03408648
SM
3432 * window.c (Ftemp_output_buffer_show): New fun.
3433 (Fsave_window_excursion):
3434 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3435
3436 * lread.c (lisp_file_lexically_bound_p): New function.
3437 (Fload): Bind Qlexical_binding.
3438 (readevalloop): Remove `evalfun' arg.
3439 Bind Qinternal_interpreter_environment.
3440 (Feval_buffer): Bind Qlexical_binding.
3441 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3442 Mark as dynamic.
3443 (syms_of_lread): Declare `lexical-binding'.
3444
3445 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3446
3447 * keyboard.c (eval_dyn): New fun.
3448 (menu_item_eval_property): Use it.
ca105506
SM
3449
3450 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3451
03408648
SM
3452 * fns.c (concat, mapcar1): Accept byte-code-functions.
3453
3454 * eval.c (Fsetq): Handle lexical vars.
3455 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3456 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3457 (FletX, Flet): Obey lexical binding.
3458 (Fcommandp): Handle closures.
3459 (Feval): New `lexical' arg.
3460 (eval_sub): New function extracted from Feval. Use it almost
3461 everywhere where Feval was used. Look up vars in lexical env.
3462 Handle closures.
3463 (Ffunctionp): Move from subr.el.
3464 (Ffuncall): Handle closures.
3465 (apply_lambda): Remove `eval_flags'.
3466 (funcall_lambda): Handle closures and new byte-code-functions.
3467 (Fspecial_variable_p): New function.
3468 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3469 but without exporting it to Lisp.
23aba0ea 3470
23aba0ea 3471 * doc.c (Fdocumentation, store_function_docstring):
03408648 3472 * data.c (Finteractive_form): Handle closures.
23aba0ea 3473
03408648
SM
3474 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3475 interactive spec.
ba83908c 3476
04f2d78b
CB
3477 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3478 New byte-codes.
03408648
SM
3479 (exec_byte_code): New function extracted from Fbyte_code to handle new
3480 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3481
03408648 3482 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3483
03408648 3484 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3485
e2abce01
JB
34862011-03-31 Juanma Barranquero <lekktu@gmail.com>
3487
3488 * xdisp.c (redisplay_internal): Fix prototype.
3489
63696a73 34902011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3491
63696a73 3492 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3493 (try_scrolling): Use it when setting scroll_limit.
3494 Limit scrolling to 100 screen lines.
63696a73
EZ
3495 (redisplay_window): Even when falling back on "recentering",
3496 position point in the window according to scroll-conservatively,
3497 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3498
3499 (try_scrolling): When point is above the window, allow searching
3500 as far as scroll_max, or one screenful, to compute vertical
3501 distance from PT to the scroll margin position. This prevents
3502 try_scrolling from unnecessarily failing when
3503 scroll-conservatively is set to a value slightly larger than the
3504 window height. Clean up the case of PT below the margin at bottom
3505 of window: scroll_max can no longer be INT_MAX. When aggressive
3506 scrolling is in use, don't let point enter the opposite scroll
3507 margin as result of the scroll.
3508 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3509 threshold of 100 lines for never-recentering scrolling.
3510
e4cc2dfc
JB
35112011-03-31 Juanma Barranquero <lekktu@gmail.com>
3512
3513 * dispextern.h (move_it_by_lines):
3514 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3515 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3516 (message_log_check_duplicate): Remove parameters `prev_bol' and
3517 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3518 (redisplay_internal): Remove parameter `preserve_echo_area',
3519 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3520
3521 * indent.c (Fvertical_motion):
3522 * window.c (window_scroll_pixel_based, Frecenter):
3523 Don't pass `need_y_p' to `move_it_by_lines'.
3524
1c470562
SM
35252011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3526
44f230aa
SM
3527 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3528 steal a few bits to be more compact.
3529 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3530 Remove unneeded casts.
3531
1c470562
SM
3532 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3533
888adce9
ZK
35342011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3535
3536 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3537 binding" message (bug#7967).
3538
f838ed7b
PE
35392011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3540
77861b95
PE
3541 Fix more problems found by GCC 4.6.0's static checks.
3542
de6dbc14
PE
3543 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3544 Remove unused local var.
3545
f838ed7b
PE
3546 * editfns.c (Fmessage_box): Remove unused local var.
3547
792c7b2b
PE
3548 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3549 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3550 Omit unused local vars.
c499e557 3551 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3552 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3553 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3554 Omit unused local var.
3555
ba0165e1
PE
3556 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3557 Don't assume string length fits in int.
32ad8845 3558 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3559 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3560
3c59b4c9
PE
3561 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3562 instead of alloca (Bug#8344).
3563
a3eed478 3564 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3565 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3566
eb4d412d
PE
3567 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3568
1658b401
PE
3569 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3570 concerns.
3571
3572 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3573
3574 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3575
9a2c6e05
PE
3576 * keyboard.c (syms_of_keyboard): Use the same style as later
3577 in this function when indexing through an array. This also
3578 works around GCC bug 48267.
3579
03d0a109
PE
3580 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3581
44f730c8
PE
3582 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3583
fe75f926
PE
3584 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3585 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3586
ffa8c828
PE
3587 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3588 This avoids undefined behavior on integer overflow, and is a bit
3589 more convenient anyway since it is compared to a size_t variable.
3590
c5101a77
PE
3591 Variadic C functions now count arguments with size_t, not int.
3592 This avoids an unnecessary limitation on 64-bit machines, which
3593 caused (substring ...) to crash on large vectors (Bug#8344).
3594 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3595 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3596 All variadic functions and their callers changed accordingly.
c5101a77
PE
3597 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3598 * data.c (arith_driver, float_arith_driver): Likewise.
3599 * editfns.c (general_insert_function): Likewise.
3600 * eval.c (struct backtrace.nargs, interactive_p)
3601 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3602 (funcall_lambda, mark_backtrace): Likewise.
3603 * fns.c (concat): Likewise.
3604 * frame.c (x_set_frame_parameters): Likewise.
3605 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3606 0 if not found, not -1. All callers changed.
3607
dd3f25f7
PE
3608 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3609 (stack_copy_size): Now size_t, not int.
3610 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3611
461c2ab9
JB
36122011-03-28 Juanma Barranquero <lekktu@gmail.com>
3613
3614 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3615 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3616 All callers changed.
3617
3618 * lisp.h (multibyte_char_to_unibyte):
3619 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3620 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3621 * character.h (CHAR_TO_BYTE8):
3622 * cmds.c (internal_self_insert):
3623 * editfns.c (general_insert_function):
3624 * keymap.c (push_key_description):
3625 * search.c (Freplace_match):
3626 * xdisp.c (message_dolog, set_message_1): All callers changed.
3627
f6d62986
SM
36282011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3629
3630 * keyboard.c (safe_run_hook_funcall): New function.
3631 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3632 don't set the hook to nil, but remove the offending function instead.
3633 (Qcommand_hook_internal): Remove, unused.
3634 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3635 Vcommand_hook_internal.
3636
3637 * eval.c (enum run_hooks_condition): Remove.
3638 (funcall_nil, funcall_not): New functions.
3639 (run_hook_with_args): Call each function through a `funcall' argument.
3640 Remove `cond' argument, now redundant.
3641 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3642 (Frun_hook_with_args_until_failure): Adjust accordingly.
3643 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3644
1db5b1ad
JB
36452011-03-28 Juanma Barranquero <lekktu@gmail.com>
3646
3647 * dispextern.h (string_buffer_position): Remove declaration.
3648
3649 * print.c (strout): Remove parameter `multibyte', unused since
3650 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3651
3652 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3653 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3654 All callers changed.
3655
3656 * w32.c (_wsa_errlist): Use braces for struct initializers.
3657
3658 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3659 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3660 All callers changed.
3661 (string_buffer_position): Likewise. Also, make static (it's never
3662 used outside xdisp.c).
3663 (cursor_row_p): Remove parameter `w', unused since
3664 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3665 (decode_mode_spec): Remove parameter `precision', introduced during
3666 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3667 All callers changed.
3668
5ffb62aa
JD
36692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3670
3671 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3672
461c2ab9 36732011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3674
3675 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3676 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3677 (ns_update_auto_hide_menu_bar): New functions.
3678 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3679 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3680 ns_constrain_all_frames.
3681 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3682 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3683
5c380ffb
JD
36842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3685
3686 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3687
9af30bdf
GM
36882011-03-27 Glenn Morris <rgm@gnu.org>
3689
3690 * syssignal.h: Replace RETSIGTYPE with void.
3691 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3692 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3693 Replace SIGTYPE with void everywhere.
3694 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3695 * s/template.h (SIGTYPE): Remove commented out definition.
3696
e2abce01
JB
36972011-03-26 Eli Zaretskii <eliz@gnu.org>
3698
3699 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3700 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3701
f868cd8a
JB
37022011-03-26 Juanma Barranquero <lekktu@gmail.com>
3703
59eb0929
JB
3704 * w32.c (read_unc_volume): Use parameter `henum', instead of
3705 global variable `wget_enum_handle'.
3706
3707 * keymap.c (describe_vector): Remove parameters `indices' and
3708 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3709 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3710
f868cd8a
JB
3711 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3712
3713 * keyboard.c (timer_check): Remove parameter `do_it_now',
3714 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3715 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3716 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3717
3718 * keyboard.c (read_char):
3719 * w32menu.c (w32_menu_display_help):
3720 * xmenu.c (show_help_event, menu_help_callback):
3721 Adjust calls to `show_help_echo'.
3722
3723 * gtkutil.c (xg_maybe_add_timer):
3724 * keyboard.c (readable_events):
3725 * process.c (wait_reading_process_output):
3726 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3727
3728 * insdel.c (adjust_markers_gap_motion):
3729 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3730 (gap_left, gap_right): Don't call it.
3731
2ecf6fdb
CY
37322011-03-25 Chong Yidong <cyd@stupidchicken.com>
3733
3734 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3735 incurred during fontification.
3736
6b1f9ba4
JB
37372011-03-25 Juanma Barranquero <lekktu@gmail.com>
3738
3739 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3740 (DEFVAR_PER_BUFFER): Don't pass it.
3741
3742 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3743 (scrolling_window): Don't pass it.
3744
0f4a96b5
JB
37452011-03-25 Juanma Barranquero <lekktu@gmail.com>
3746
3747 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3748
3749 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3750 and `suffix'.
3751 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3752 of variables specific to SELinux and computation of `encoded_absname'.
3753
3754 * image.c (XPutPixel): Remove unused variable `height'.
3755
3756 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3757
3758 * unexw32.c (get_section_info): Remove unused variable `section'.
3759
3760 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3761 (system_process_attributes): Remove unused variable `sess'.
3762 (sys_read): Remove unused variable `err'.
3763
3764 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3765 (w32_wnd_proc): Remove unused variable `isdead'.
3766 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3767 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3768 (x_create_tip_frame): Remove unused variable `tem'.
3769
3770 * w32inevt.c (w32_console_read_socket):
3771 Remove unused variable `no_events'.
3772
3773 * w32term.c (x_draw_composite_glyph_string_foreground):
3774 Remove unused variable `width'.
3775
1149507c
JB
37762011-03-24 Juanma Barranquero <lekktu@gmail.com>
3777
3778 * w32term.c (x_set_glyph_string_clipping):
3779 Don't pass uninitialized region to CombineRgn.
3780
9c88f339
JB
37812011-03-23 Juanma Barranquero <lekktu@gmail.com>
3782
3783 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3784 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3785 (Fx_close_connection): Remove unused variable `i'.
3786
3787 * w32font.c (w32font_draw): Return number of glyphs.
3788 (w32font_open_internal): Remove unused variable `i'.
3789 (w32font_driver): Add missing initializer.
3790
3791 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3792 (fill_in_menu): Remove unused variable `items_added'.
3793
3794 * w32term.c (last_mouse_press_frame): Remove static global variable.
3795 (w32_clip_to_row): Remove unused variable `f'.
3796 (x_delete_terminal): Remove unused variable `i'.
3797
3798 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3799 (NOTHING): Remove unused static global variable.
3800 (uniscribe_check_otf): Remove unused variable `table'.
3801 (uniscribe_font_driver): Add missing initializers.
3802
dee091a3
JD
38032011-03-23 Julien Danjou <julien@danjou.info>
3804
3805 * term.c (Fsuspend_tty, Fresume_tty):
3806 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3807 * window.c (temp_output_buffer_show):
3808 * insdel.c (signal_before_change):
3809 * frame.c (Fhandle_switch_frame):
3810 * fileio.c (Fdo_auto_save):
3811 * emacs.c (Fkill_emacs):
3812 * editfns.c (save_excursion_restore):
3813 * cmds.c (internal_self_insert):
3814 * callint.c (Fcall_interactively):
3815 * buffer.c (Fkill_all_local_variables):
3816 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3817 Use Frun_hooks.
0f4a96b5 3818 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3819 unconditionnaly since it does the check itself.
3820
2c520ab5 38212011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3822
c9c49752
PE
3823 Fix more problems found by GCC 4.5.2's static checks.
3824
8abc3f12
PE
3825 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3826 the first time through the loop, since we know p0 < p1 then.
3827 This also avoids a gcc -Wstrict-overflow warning.
3828
a2d26660
PE
3829 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3830 leading to a memory leak, possible in functions like
3831 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3832 of objects (Bug#8318).
a2d26660 3833
916c72e9
PE
3834 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3835 that could (at least in theory) be that large.
3836
19ab8a18
PE
3837 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3838 This is less likely to overflow, and avoids undefined behavior if
3839 overflow does occur. All callers changed. Use strtoul to scan
3840 for the unsigned long integer.
b7cbbd6f
PE
3841 (pint2hrstr): Simplify and tune code slightly.
3842 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3843
f0641eff
PE
3844 * scroll.c (do_scrolling): Work around GCC bug 48228.
3845 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3846
7f650bb9
PE
3847 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3848 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3849 (validate_x_resource_name): Simplify count usage.
3850 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3851
37dd57d1
PE
3852 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3853 fail (Bug#8306).
81e56e61 3854
699979fc 3855 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3856
401bf9b4
PE
3857 * process.c (Fmake_network_process): Use socklen_t, not int,
3858 where POSIX says socklen_t is required in portable programs.
3859 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3860 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3861 (Fmake_network_process, server_accept_connection):
3862 (wait_reading_process_output, read_process_output):
3863 Likewise.
3864
b93aacde
PE
3865 * process.c: Rename or move locals to avoid shadowing.
3866 (list_processes_1, Fmake_network_process):
3867 (read_process_output_error_handler, exec_sentinel_error_handler):
3868 Rename or move locals.
4dc343ee 3869 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3870 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3871 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3872 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3873 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3874
af8a867c 3875 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3876 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3877 Include tparam.h instead, since it declares them.
af8a867c
PE
3878 * cm.h (PC): Remove extern decl; tparam.h now does this.
3879 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3880 * terminfo.c: Include tparam.h, to check interfaces.
3881 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3882 (tparam): Adjust signature to match interface in tparam.h;
3883 this removes some undefined behavior. Check that outstring and len
3884 are zero, which they always are with Emacs.
3885 * tparam.h (PC, BC, UP): New extern decls.
3886
0248044d 3887 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3888 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3889
8ff096c1 3890 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3891 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3892 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3893 (ftfont_list): Remove unused local.
49eaafba
PE
3894 (get_adstyle_property, ftfont_pattern_entity):
3895 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3896 Rename locals to avoid shadowing.
8ff096c1 3897
e2be39f6
PE
3898 * xfont.c (xfont_list_family): Mark var as initialized.
3899
c9735e30
PE
3900 * xml.c (make_dom): Now static.
3901
8f5201ae
PE
3902 * composite.c (composition_compute_stop_pos): Rename local to
3903 avoid shadowing.
b246f932
PE
3904 (composition_reseat_it): Remove unused locals.
3905 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3906 (composition_update_it): Mark var as initialized.
11b61122
PE
3907 (find_automatic_composition): Mark vars as initialized,
3908 with a FIXME (Bug#8290).
8f5201ae 3909
760fbc2c
PE
3910 character.h: Rename locals to avoid shadowing.
3911 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3912 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3913 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3914 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3915 to avoid shadowing.
3916
ff08eb85
PE
3917 * textprop.c (property_change_between_p): Remove; unused.
3918
fc7bf025
PE
3919 * intervals.c (interval_start_pos): Now static.
3920
235d7abc
PE
3921 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3922
44f230aa
SM
3923 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3924 Rename locals to avoid shadowing.
3e7d6594 3925
50060332
PE
3926 * sound.c (wav_play, au_play, Fplay_sound_internal):
3927 Fix pointer signedness.
d01f234b 3928 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3929 (wav_play): Initialize a variable to 0, to prevent undefined
3930 behavior (Bug#8278).
50060332 3931
c4fc4e30
PE
3932 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3933
918436ed
PE
3934 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3935
c939f91b
PE
3936 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3937 clobbering (Bug#8298).
b9c7f648
PE
3938 * sysdep.c (sys_subshell): Likewise.
3939 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3940
6bd8c144
PE
3941 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3942 This should get cleaned up, so that child_setup has the
3943 same signature on all platforms.
3944
7710357c 3945 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3946 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3947
c59da222
CY
39482011-03-22 Chong Yidong <cyd@stupidchicken.com>
3949
3950 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3951 not to be necessary, and produces flickering.
3952
66b87493
GM
39532011-03-20 Glenn Morris <rgm@gnu.org>
3954
3955 * config.in: Remove file.
3956
45b6f6d5
JB
39572011-03-20 Juanma Barranquero <lekktu@gmail.com>
3958
3959 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3960 are now in src/globals.h.
3961 (syms_of_minibuf): Remove spurious & from previous change.
3962
3ec03f7e
LL
39632011-03-20 Leo <sdl.web@gmail.com>
3964
3965 * minibuf.c (completing-read-function): New variable.
3966 (completing-read-default): Rename from completing-read.
3967 (completing-read): Call completing-read-function.
3968
b14e3e21
CY
39692011-03-19 Juanma Barranquero <lekktu@gmail.com>
3970
3971 * xfaces.c (Fx_load_color_file):
3972 Read color file from absolute filename (bug#8250).
3973
f2b726e6
JB
39742011-03-19 Juanma Barranquero <lekktu@gmail.com>
3975
3976 * makefile.w32-in: Update dependencies.
3977
09f6ff02
EZ
39782011-03-17 Eli Zaretskii <eliz@gnu.org>
3979
3980 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3981
29a6015a
PE
39822011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3983
a3a6c54e
PE
3984 Fix more problems found by GCC 4.5.2's static checks.
3985
b766f867
PE
3986 * process.c (make_serial_process_unwind, send_process_trap):
3987 (sigchld_handler): Now static.
3988
be02381c
PE
3989 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3990 That way, the code declares only the vars that it needs.
3991 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3992 * s/cygwin.h (PTY_ITERATION): Likewise.
3993 * s/darwin.h (PTY_ITERATION): Likewise.
3994 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3995
57048744
PE
3996 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3997 * process.c (allocate_pty): Don't declare stb unless it's needed.
3998
7914961c 3999 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4000 (CONSTANTLIM): Remove; unused.
4001 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4002 Define only if needed.
7914961c 4003
b3967b18
PE
4004 * unexelf.c (unexec): Name an expression,
4005 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4006 Use a different way to cause a compilation error if anyone uses
4007 n rather than nn, a way that does not involve shadowing.
73366a00 4008 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4009
29a6015a
PE
4010 * deps.mk (unexalpha.o): Remove; unused.
4011
43cfc33e 4012 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4013 * unexec.h: New file.
ce701a33
PE
4014 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4015 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4016 Depend on unexec.h.
4017 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4018 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4019 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4020 Change as necessary to match prototype in unexec.h.
ce701a33 4021
01f44d5a
PE
4022 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4023 shadowing.
4f63c6bb 4024 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4025
a6670b0b
PE
4026 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4027 Rename locals to avoid shadowing.
4028
cef2010d 4029 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4030 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4031
d4d7173a
PE
4032 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4033
f08b802a
PE
4034 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4035 warning when compiling print.c.
4036
3ddb0639
PE
4037 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4038 instead of using an uninitialized var.
5ad03b97 4039 (font_sort_entities): Mark var as initialized.
3ddb0639 4040
170a2692
PE
4041 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4042
e663c700
PE
4043 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4044 pointers to constants.
89bc529a 4045 (font_parse_fcname): Remove unused vars.
7b81e2d0 4046 (font_delete_unmatched): Now static.
ea838e10 4047 (font_get_spec): Remove; unused.
13a547c6
PE
4048 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4049 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4050 Rename or move locals to avoid shadowing.
e663c700 4051
2a80c887 4052 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4053 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4054
1384fa33 4055 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4056 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4057
8b2c52e9
PE
4058 * alloc.c (mark_backtrace): Move decl from here ...
4059 * lisp.h: ... to here, so that it can be checked.
4060
475545b5 4061 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4062 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4063 (lisp_indirect_variable): Name an expression,
4064 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4065 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4066
b1349114 4067 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4068 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4069 Use const pointer when appropriate.
b1349114 4070
a2928364
PE
4071 * lisp.h (get_system_name, get_operating_system_release):
4072 Move decls here, to check interfaces.
4073 * process.c (get_operating_system_release): Move decl to lisp.h.
4074 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4075 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4076 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4077 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4078 (Fformat_time_string, Fencode_time, Finsert_char):
4079 (Ftranslate_region_internal, Fformat):
4080 Rename or remove local vars to avoid shadowing.
9710023e 4081 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4082
a415e694
PE
4083 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4084 avoid shadowing.
4085
8ef4622d
PE
4086 * lisp.h (eassert): Check that the argument compiles, even if
4087 ENABLE_CHECKING is not defined.
4088
946f9a5b
PE
4089 * data.c (Findirect_variable): Name an expression, to avoid
4090 gcc -Wbad-function-cast warning.
112396d6 4091 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4092 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4093 (Fmake_variable_buffer_local, Fmake_local_variable):
4094 Mark variables as initialized.
52746918 4095 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4096
e5aab7e7 4097 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4098 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4099 Rename locals to avoid shadowing.
dff45157
PE
4100 (mark_stack): Move local variables into the #ifdef region where
4101 they're used.
7bc26fdb
PE
4102 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4103 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4104 needed otherwise.
4105 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4106 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4107 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4108
e5aab7e7
PE
4109 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4110 avoids undefined behavior in theory.
4111
4da60324
PE
4112 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4113
88043301
PE
4114 Use functions, not macros, for up- and down-casing (Bug#8254).
4115 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4116 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4117 to use the following functions instead of these macros.
4118 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4119 EMACS_INT, since callers assume the returned value fits in int.
4120 (upcase1): Likewise, for UPCASE_TABLE.
4121 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4122 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4123 the race-condition problem in the old DOWNCASE.
88043301 4124
19ed5445
PE
4125 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4126 Rename locals to avoid shadowing.
4127 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4128 (regex_compile, re_search_2, re_match_2_internal):
4129 Remove unused local vars.
952db0d7
PE
4130 (FREE_VAR): Rewrite so as not to use empty "else",
4131 which gcc can warn about.
da053e48 4132 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4133 (RETALLOC_IF): Define only if needed.
4134 (WORDCHAR_P): Likewise. This one is never needed, but is used
4135 only in a comment talking about a compiler bug, so put inside
4136 the #if 0 of that comment.
4137 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4138 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4139 Remove; unused.
19ed5445 4140
1f3561e4 4141 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4142 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4143 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4144
ded6f8f7
PE
4145 * search.c (simple_search): Remove unused var.
4146
dbd37a95
PE
4147 * dired.c (compile_pattern): Move decl from here ...
4148 * lisp.h: ... to here, so that it can be checked.
4149 (struct re_registers): New forward decl.
4150
7e47afad
PE
4151 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4152
85f24f61
PE
4153 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4154 All uses changed.
4155 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4156 Rename locals to avoid shadowing.
5671df8f 4157 (Fvertical_motion): Mark locals as initialized.
85f24f61 4158
181aa2be 4159 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4160 (casify_region): Mark local as initialized.
181aa2be 4161
930d429c
PE
4162 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4163
7082eac6
PE
4164 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4165 New macros, so that the caller can use some names other than
4166 gcpro1, gcpro2, etc.
4167 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4168 of the new macros.
4169 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4170 argument, for consistency with GCPRO2_VAR, etc: it is now the
4171 prefix of the variable, not the variable itself. All uses
4172 changed.
38b2c076
PE
4173 * dired.c (directory_files_internal, file_name_completion):
4174 Rename locals to avoid shadowing.
4175
15206ed9
PE
4176 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4177 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4178 dired.c's scmp function, had undefined behavior.
4179 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4180 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4181 * buffer.h: ... to here, because these macros use current_buffer,
4182 and the new implementation with inline functions needs to have
4183 current_buffer in scope now, rather than later when the macros
4184 are used.
4185 (downcase, upcase1): New static inline functions.
4186 (DOWNCASE, UPCASE1): Reimplement using these functions.
4187 This avoids undefined behavior in expressions like
4188 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4189 from race conditions in accessing the global variables
4190 case_temp1 and case_temp2.
4191 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4192 * lisp.h (case_temp1, case_temp2): Remove their decls.
4193 * character.h (ASCII_CHAR_P): Move from here ...
4194 * lisp.h: ... to here, so that the inline functions mentioned
4195 above can use them.
4196
4a6bea26
PE
4197 * dired.c (directory_files_internal_unwind): Now static.
4198
f14b7e14
PE
4199 * fileio.c (file_name_as_directory, directory_file_name):
4200 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4201 Now static.
2893f146
PE
4202 (file_name_as_directory): Use const pointers when appropriate.
4203 (Fexpand_file_name): Likewise. In particular, newdir might
4204 point at constant storage, so make it a const pointer.
fd4ead52 4205 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4206 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4207 signedness issues.
f839df0c
PE
4208 (Fset_file_times, Finsert_file_contents, auto_save_error):
4209 Rename locals to avoid shadowing.
f14b7e14 4210
5716756e 4211 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4212 (Ftry_completion, Fall_completions): Rename or remove locals
4213 to avoid shadowing.
5716756e 4214
b4c3046a
PE
4215 * marker.c (bytepos_to_charpos): Remove; unused.
4216
b45db522
PE
4217 * lisp.h (verify_bytepos, count_markers): New decls,
4218 so that gcc does not warn that these functions aren't declared.
4219
85876d07
PE
4220 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4221 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4222 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4223 (copy_text): Remove unused local var.
85876d07 4224
03d78a21 4225 * filelock.c (within_one_second): Now static.
b3dd38ab 4226 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4227
5df8f01b
PE
4228 * buffer.c (fix_overlays_before): Mark locals as initialized.
4229 (fix_start_end_in_overlays): Likewise. This function should be
4230 simplified by using pointers-to-pointers, but that's a different
4231 matter.
b1d876f1 4232 (switch_to_buffer_1): Now static.
8f54f30a
PE
4233 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4234 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4235
a70072c9 4236 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4237 Fix pointer signedness issue.
edced198
PE
4238 (sys_subshell): Mark local as volatile if checking for lint,
4239 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4240 (MAXPATHLEN): Define only if needed.
a70072c9 4241
a0977c44
PE
4242 * process.c (serial_open, serial_configure): Move decls from here ...
4243 * systty.h: ... to here, so that they can be checked.
4244
a884fdcc
PE
4245 * fns.c (get_random, seed_random): Move extern decls from here ...
4246 * lisp.h: ... to here, so that they can be checked.
4247
604efe86 4248 * sysdep.c (reset_io): Now static.
b8950c94 4249 (wait_for_termination_signal): Remove; unused.
604efe86 4250
38fc62d9
PE
4251 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4252 (copy_keymap_item, append_key, push_text_char_description):
4253 Now static.
1004a21a 4254 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4255 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4256 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4257 (describe_map_tree):
4258 Rename locals to avoid shadowing.
38fc62d9 4259
2f2650da
PE
4260 * keyboard.c: Declare functions static if they are not used elsewhere.
4261 (echo_char, echo_dash, cmd_error, top_level_2):
4262 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4263 (read_char, kbd_buffer_get_event, make_lispy_position):
4264 (make_lispy_event, make_lispy_movement, apply_modifiers):
4265 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4266 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4267 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4268 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4269 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4270
a053e86c 4271 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4272 (mark_kboards): Move decl here ...
4273 * alloc.c (mark_kboards): ... from here.
a053e86c 4274
4752793e
PE
4275 * lisp.h (force_auto_save_soon): New decl.
4276
74f10ca7 4277 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4278 (DEFINE_DUMMY_FUNCTION): New macro.
4279 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4280 Use it.
c03cd23f
PE
4281 (main): Add casts to avoid warnings
4282 if GCC considers string literals to be constants.
74f10ca7 4283
022e70d4
PE
4284 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4285
59d6fe83
PE
4286 * dbusbind.c: Pointer signedness fixes.
4287 (xd_signature, xd_append_arg, xd_initialize):
4288 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4289 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4290 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4291 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4292
78320123
PE
4293 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4294 if GCC considers string literals to be constants.
49cebcca 4295 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4296
35ac2a97
SM
42972011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4298
fb103ca9
SM
4299 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4300 (print_preprocess, print_object): New macro to fix last change.
4301
35ac2a97
SM
4302 * print.c (print_preprocess): Don't forget font objects.
4303
62973b41
JB
43042011-03-16 Juanma Barranquero <lekktu@gmail.com>
4305
4306 * emacs.c (USAGE3): Doc fixes.
4307
0e48bb22
AS
43082011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4309
4310 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4311 structure.
4312
7684e57b
JB
43132011-03-14 Juanma Barranquero <lekktu@gmail.com>
4314
4315 * lisp.h (VWindow_system, Qfile_name_history):
4316 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4317 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4318 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4319
4320 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4321 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4322
4323 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4324 * w32console.c (detect_input_pending, read_input_pending)
4325 (encode_terminal_code):
4326 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4327 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4328 (w32_system_caret_y, Qfile_name_history):
4329 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4330 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4331 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4332 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4333 * w32proc.c (Qlocal, report_file_error):
4334 * w32term.c (Vwindow_system, updating_frame):
4335 * w32uniscribe.c (initialized, uniscribe_font_driver):
4336 Remove unneeded extern declarations.
4337
2aa46d6c
CY
43382011-03-14 Chong Yidong <cyd@stupidchicken.com>
4339
c96bbc66 4340 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4341
cffc6f3b
CY
43422011-03-13 Chong Yidong <cyd@stupidchicken.com>
4343
4344 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4345 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4346 These macros can no longer be used for assignment.
4347
44f230aa
SM
4348 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4349 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4350 (record_buffer_markers, fetch_buffer_markers): New functions for
4351 recording and fetching special buffer markers.
4352 (set_buffer_internal_1, set_buffer_temp): Use them.
4353
4354 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4355
4356 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4357
4358 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4359 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4360
4361 * xdisp.c (hscroll_window_tree):
4362 (reconsider_clip_changes): Use PT instead of BUF_PT.
4363
d251f04b
EZ
43642011-03-13 Eli Zaretskii <eliz@gnu.org>
4365
4366 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4367 $(EMACS_ROOT)/lib/intprops.h.
4368
f0c77cd1
PE
43692011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4370
3eca4629
PE
4371 Fix more problems found by GCC 4.5.2's static checks.
4372
7c86ee98
PE
4373 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4374 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4375 (xg_free_frame_widgets): Make it clear that a local variable is
4376 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4377 (gdk_window_get_screen): Make it clear that this macro is needed
4378 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4379 (int_gtk_range_get_value): New function, which avoids a diagnostic
4380 from gcc -Wbad-function-cast.
4381 (xg_set_toolkit_scroll_bar_thumb): Use it.
4382 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4383 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4384 (get_utf8_string, xg_get_file_with_chooser):
4385 Rename locals to avoid shadowing.
4386 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4387
41729b81
PE
4388 * xgselect.c (xg_select): Remove unused var.
4389
f0c77cd1
PE
4390 * image.c (four_corners_best): Mark locals as initialized.
4391 (gif_load): Initialize transparent_p to zero (Bug#8238).
4392 Mark another local as initialized.
ec6cf4c6 4393 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4394
ce0ad53d 4395 * image.c (clear_image_cache): Now static.
d5d5a617 4396 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4397 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4398 (x_edge_detection): Remove unnecessary cast that
4399 gcc -Wbad-function-cast diagnoses.
2037898d 4400 (gif_load): Fix pointer signedness.
6ae141d6
PE
4401 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4402 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4403
33383987 44042011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4405
d32df629
PE
4406 Improve quality of tests for time stamp overflow.
4407 For example, without this patch (encode-time 0 0 0 1 1
4408 1152921504606846976) returns the obviously-bogus value (-948597
4409 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4410 reports time overflow. See
4411 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4412 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4413 * editfns.c: Include limits.h and intprops.h.
4414 (TIME_T_MIN, TIME_T_MAX): New macros.
4415 (time_overflow): Move earlier, to before first use.
4416 (hi_time, lo_time): New functions, for an accurate test for
4417 out-of-range times.
4418 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4419 (Fget_internal_run_time): Don't assume time_t fits in int.
4420 (make_time): Use list2 instead of Fcons twice.
4421 (Fdecode_time): More accurate test for out-of-range times.
4422 (check_tm_member): New function.
4423 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4424 (lisp_time_argument): Don't rely on undefined left-shift and
4425 right-shift behavior when checking for time stamp overflow.
8be6f318 4426
fe31d94c
PE
4427 * editfns.c (time_overflow): New function, refactoring common code.
4428 (Fformat_time_string, Fdecode_time, Fencode_time):
4429 (Fcurrent_time_string): Use it.
4430
8be6f318
PE
4431 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4432 * dired.c (make_time): Move to ...
4433 * editfns.c (make_time): ... here.
4434 * systime.h: Note the move.
4435
09d9db2c 44362011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4437
126bc0dc
YM
4438 * fringe.c (update_window_fringes): Remove unused variables.
4439
c47cbdfd
YM
4440 * unexmacosx.c (copy_data_segment): Also copy __got section.
4441 (Bug#8223)
4442
7ac80be9
EZ
44432011-03-12 Eli Zaretskii <eliz@gnu.org>
4444
c96bbc66 4445 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4446 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4447 Constify `char *' arguments and their references according to
4448 prototypes in tparam.h.
4449
ecb0f94d 4450 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4451
7ac80be9
EZ
4452 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4453 Adapt all references accordingly.
4454
4455 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4456
ef1fd07e
TT
44572011-03-11 Tom Tromey <tromey@redhat.com>
4458
4459 * buffer.c (syms_of_buffer): Remove obsolete comment.
4460
7ef4b50c
EZ
44612011-03-11 Eli Zaretskii <eliz@gnu.org>
4462
4463 * termhooks.h (encode_terminal_code): Declare prototype.
4464
4465 * msdos.c (encode_terminal_code): Don't declare prototype.
4466
4467 * term.c (encode_terminal_code): Now external again, used by
4468 w32console.c and msdos.c.
4469
44f230aa
SM
4470 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4471 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4472
4b1ec863 44732011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4474
1714f52b 4475 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4476
4b1ec863
PE
4477 * fringe.c (update_window_fringes): Mark locals as initialized
4478 (Bug#8227).
4479 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4480
524c7aa6
PE
4481 * alloc.c (mark_fringe_data): Move decl from here ...
4482 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4483 to check its interface.
4484 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4485
a5c0af81 4486 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4487 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4488 (fontset_font): Mark local as initialized.
a9a06e0b 4489 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4490
b4716021
PE
4491 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4492
811e9bac 4493 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4494 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4495 (x_own_selection, Fx_disown_selection_internal): Rename locals
4496 to avoid shadowing.
4497 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4498
7e3ab302
PE
4499 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4500 so that the caller can use some name other than gcpro1.
4501 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4502 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4503 (Fx_backspace_delete_keys_p):
4504 Use them to avoid shadowing, and rename vars to avoid shadowing.
4505 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4506 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4507 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4508 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4509 Remove unused locals.
7e3ab302
PE
4510 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4511 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4512 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4513 macros.
f78faa98 4514
e2b13473
PE
4515 * xterm.h (x_mouse_leave): New decl.
4516
77f23912
PE
4517 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4518 Remove unused functions.
cdf4ba58
PE
4519 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4520 (x_calc_absolute_position): Now static.
7411c686 4521 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4522 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4523 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4524 unless they are used.
38d0b34a
PE
4525 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4526 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4527 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4528 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4529 (x_error_catcher, x_connection_closed, x_error_handler):
4530 (x_error_quitter, xembed_send_message, x_iconify_frame):
4531 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4532 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4533 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4534
44f230aa
SM
4535 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4536 Rename or move locals to avoid shadowing.
6b463e58 4537 (tty_defined_color, merge_face_heights): Now static.
5967d051 4538 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4539 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4540 does not deduce is never used uninitialized.
73719eba
PE
4541 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4542 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4543
426994c3 4544 * terminal.c (store_terminal_param): Now static.
5489860b 4545
032f1620 4546 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4547 (set_frame_menubar): Remove unused local.
d4323972 4548 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4549 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4550 since they might point to immutable storage.
281585b0
PE
4551 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4552 since it's unused otherwise.
032f1620 4553
367c19e5 4554 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4555 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4556 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4557 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4558 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4559 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4560 does not deduce are never used uninitialized.
70739cbe 4561
07b48fa9
PE
4562 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4563
8868a238 4564 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4565 * window.c (window_loop, size_window):
4566 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4567
7e5cf297 4568 * window.c (display_buffer): Now static.
d6550a9f
PE
4569 (size_window): Mark variables that gcc -Wuninitialized
4570 does not deduce are never used uninitialized.
a586633d
PE
4571 * window.h (check_all_windows): New decl, to forestall
4572 gcc -Wmissing-prototypes diagnostic.
5b555da1 4573 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4574
f6095868
PE
4575 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4576 shadowing.
4577 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4578 Include <limits.h>.
4579 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4580 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4581 (load_charset_map): Mark variables that gcc -Wuninitialized
4582 does not deduce are never used uninitialized.
53df7c11 4583 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4584
f38b440c
PE
4585 * coding.c (coding_set_source, coding_set_destination):
4586 Use "else { /* comment */ }" rather than "else /* comment */;"
4587 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4588 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4589 a block, when the outer 'i' will do.
4590 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4591 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4592 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4593 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4594 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4595 Rename locals to avoid shadowing.
4596 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4597 * coding.c (emacs_mule_char, encode_invocation_designation):
4598 Now static, since they're not used elsewhere.
413bb2db 4599 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4600 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4601 (decode_coding_emacs_mule): Mark variables that gcc
4602 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4603 (detect_coding_iso_2022): Initialize a local variable that might
4604 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4605 this initialization is needed. (Bug#8211)
5f58e762
PE
4606 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4607 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4608 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4609 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4610 Remove unused macros.
f38b440c 4611
232b38b9 4612 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4613 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4614 * character.c (string_count_byte8): Likewise.
232b38b9 4615
fb90da1b
PE
4616 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4617 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4618
fb93dbc2
PE
4619 * chartab.c (copy_sub_char_table): Now static, since it's not used
4620 elsewhere.
5c156ace
PE
4621 (sub_char_table_ref_and_range, char_table_ref_and_range):
4622 Rename locals to avoid shadowing.
bbcd0949 4623 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4624
7d3b3862 4625 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4626 (BIDI_BOB): Remove unused macro.
7d3b3862 4627
6be7d3da
PE
4628 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4629 deduce are never used uninitialized.
c2ed9c8b 4630 * term.c (encode_terminal_code): Likewise.
6be7d3da 4631
75f8807f 4632 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4633
50938595
PE
4634 * tparam.h: New file.
4635 * term.c, tparam.h: Include it.
4636 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4637 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4638 Move these decls to tparam.h, and make them agree with what
4639 is actually in tparam.c. The previous trick of using incompatible
4640 decls in different modules does not conform to the C standard.
4641 All callers of tparam changed to use tparam's actual API.
4642 * tparam.c (tparam1, tparam, tgoto):
4643 Use const pointers where appropriate.
4644
fbceeba2
PE
4645 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4646 * cm.h (struct cm): Likewise.
4647 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4648 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4649 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4650 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4651 (turn_on_face, init_tty): Likewise.
4652 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4653
7f3f1250
PE
4654 * term.c (term_mouse_position): Rename local to avoid shadowing.
4655
e6ca6543
PE
4656 * alloc.c (mark_ttys): Move decl from here ...
4657 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4658
c40f8d15
AS
46592011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4660
4661 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4662
cfe0661d
JB
46632011-03-09 Juanma Barranquero <lekktu@gmail.com>
4664
4665 * search.c (compile_pattern_1): Remove argument regp, unused since
4666 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4667 (compile_pattern): Don't pass it.
4668
0afb4571
J
46692011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4670
4671 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4672 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4673 for ! HAVE_GTK3.
4674 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4675
4676 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4677
4678 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4679 gdk_window_get_screen, gdk_window_get_geometry,
4680 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4681 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4682 (xg_get_pixbuf_from_pixmap): New function.
4683 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4684 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4685 Call xg_get_pixbuf_from_pixmap instead of
4686 gdk_pixbuf_get_from_drawable.
4687 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4688 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4689 (xg_check_special_colors): Use GtkStyleContext and its functions
4690 for HAVE_GTK3.
4691 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4692 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4693 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4694 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4695 Call gtk_widget_get_preferred_size.
0afb4571
J
4696 (xg_frame_resized): gdk_window_get_geometry only takes 5
4697 parameters.
44f230aa
SM
4698 (xg_win_to_widget, xg_event_is_for_menubar):
4699 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4700 (xg_set_widget_bg): New function.
4701 (delete_cb): New function.
895009e1 4702 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4703 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4704 (xg_set_background_color): Call xg_set_widget_bg.
4705 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4706 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4707 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4708 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4709 if ! HAVE_GTK3.
4710 (update_frame_tool_bar): Call gtk_widget_hide.
4711 (xg_initialize): Use GDK_KEY_g.
4712
4713 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4714 if ! HAVE_GTK3
4715 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4716
4717 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4718 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4719 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4720
1c2cc4ef
JB
47212011-03-08 Juanma Barranquero <lekktu@gmail.com>
4722
4723 * w32xfns.c (select_palette): Check success of RealizePalette against
4724 GDI_ERROR, not zero.
4725
33383987 4726See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4727
4728;; Local Variables:
4729;; coding: utf-8
aac0c6e3
MR
4730;; End:
4731
33383987 4732 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4733
4734 This file is part of GNU Emacs.
4735
4736 GNU Emacs is free software: you can redistribute it and/or modify
4737 it under the terms of the GNU General Public License as published by
4738 the Free Software Foundation, either version 3 of the License, or
4739 (at your option) any later version.
4740
4741 GNU Emacs is distributed in the hope that it will be useful,
4742 but WITHOUT ANY WARRANTY; without even the implied warranty of
4743 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4744 GNU General Public License for more details.
4745
4746 You should have received a copy of the GNU General Public License
4747 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.