Adjust prompt in previous emacsbug.el change.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e61124cd
YM
12011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2
3 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4
5 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6 for fringe update if it has periodic bitmap.
7 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8 and fringe_bitmap_periodic_p.
9
10 * fringe.c (get_fringe_bitmap_data): New function.
11 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12 (update_window_fringes): Record periodicity of fringe bitmap in glyph
13 row. Mark glyph row for fringe update if periodicity changed.
14
15 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
16 for fringe update unless it has periodic bitmap.
17
f16d9837
KH
182011-05-25 Kenichi Handa <handa@m17n.org>
19
20 * xdisp.c (get_next_display_element): Set correct it->face_id for
21 a static composition.
22
e1b90ef6
LL
232011-05-24 Leo Liu <sdl.web@gmail.com>
24
25 * deps.mk (fns.o):
26 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
27
28 * fns.c (crypto_hash_function, Fsha1): New function.
29 (Fmd5): Use crypto_hash_function.
30 (syms_of_fns): Add Ssha1.
31
7400048f
PE
322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
33
34 * gnutls.c: Remove unused macros.
35 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
36 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
37 Remove macros that are defined and never used.
38 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
39
abb71cf4
CY
402011-05-22 Chong Yidong <cyd@stupidchicken.com>
41
42 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
43 (Fx_get_selection_internal): Minor cleanup.
44 (Fx_own_selection_internal): Rename arguments for consistency with
45 select.el.
46
6307db39
PE
472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
48
49 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
50
f3d4e0a4
CY
512011-05-22 Chong Yidong <cyd@stupidchicken.com>
52
53 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
54
4d8ade89
YM
552011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
56
57 * dispnew.c (scrolling_window): Don't exclude the case that the
58 last enabled row in the desired matrix touches the bottom boundary.
59
32078c8d
GM
602011-05-21 Glenn Morris <rgm@gnu.org>
61
62 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
63 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
64 and add some more files.
32078c8d 65
7285dc67
EZ
662011-05-20 Eli Zaretskii <eliz@gnu.org>
67
68 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
69 report_file_error introduced by the change from 2011-05-07.
70
89d1bd22
PE
712011-05-20 Paul Eggert <eggert@cs.ucla.edu>
72
73 * systime.h (Time): Define only if emacs is defined.
74 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
75 where the include path doesn't have X11/X.h by default. See
76 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
77
e23640bb 782011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
79
80 * composite.c (find_automatic_composition): Fix previous change.
81
b9704ad9
GM
822011-05-20 Glenn Morris <rgm@gnu.org>
83
84 * lisp.mk: New file, split from Makefile.in.
85 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
86 (shortlisp): Remove.
87 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
88
4a720484
GM
892011-05-19 Glenn Morris <rgm@gnu.org>
90
91 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
92 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
93 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
94 (lisp): Set the order to that of loadup.el.
95 (shortlisp): Make it a copy of $lisp.
96 (SOME_MACHINE_LISP): Remove.
97 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
98 Use just $shortlisp, not $SOME_MACHINE_LISP too.
99
a28d4396
KH
1002011-05-18 Kenichi Handa <handa@m17n.org>
101
102 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
103 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
104 (find_automatic_composition): Mostly rewrite for efficiency.
105
a2b1fa8e
JB
1062011-05-18 Juanma Barranquero <lekktu@gmail.com>
107
108 * makefile.w32-in: Update dependencies.
109
8e1f5610
CS
1102011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
111
112 * menu.c: Include limits.h (fixes the MS-Windows build broken by
113 revision 104625).
114
7025ee00 1152011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 116
cdfa6eab
PE
117 Fix some integer overflow issues, such as string length overflow.
118
06d6db33
PE
119 * insdel.c (count_size_as_multibyte): Check for string overflow.
120
2b4560a8
PE
121 * character.c (lisp_string_width): Check for string overflow.
122 Use EMACS_INT, not int, for string indexes and lengths; in
123 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
124 the resulting string length overflows an EMACS_INT; instead,
125 report a string overflow if no precision given. When checking for
126 precision exhaustion, use a check that cannot possibly have
127 integer overflow. (Bug#8675)
128 * character.h (lisp_string_width): Adjust to new signature.
129
cb93f9be
PE
130 * alloc.c (string_overflow): New function.
131 (Fmake_string): Use it. This doesn't change behavior, but saves
132 a few bytes and will simplify future changes.
133 * character.c (string_escape_byte8): Likewise.
134 * lisp.h (string_overflow): New decl.
135
1a1f3366
PE
136 Fixups, following up to the user-interface timestamp change.
137 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
138 for UI timestamps, instead of unsigned long.
9fbd6841
PE
139 * msdos.c (mouse_get_pos): Likewise.
140 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
141 * w32gui.h (Time): Define by including "systime.h" rather than by
142 declaring it ourselves. (Bug#8664)
143
d4e3e4d3
PE
144 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
145 * image.c (clear_image_cache): Likewise.
146
f6a24d19
PE
147 * term.c (term_mouse_position): Don't assume time_t wraparound.
148
08dc5ae6
PE
149 Be more systematic about user-interface timestamps.
150 Before, the code sometimes used 'Time', sometimes 'unsigned long',
151 and sometimes 'EMACS_UINT', to represent these timestamps. This
152 change causes it to use 'Time' uniformly, as that's what X uses.
153 This makes the code easier to follow, and makes it easier to catch
154 integer overflow bugs such as Bug#8664.
155 * frame.c (Fmouse_position, Fmouse_pixel_position):
156 Use Time, not unsigned long, for user-interface timestamps.
157 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
158 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
159 * keyboard.h (last_event_timestamp): Likewise.
160 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
161 * menu.h (xmenu_show): Likewise.
162 * term.c (term_mouse_position): Likewise.
163 * termhooks.h (struct input_event.timestamp): Likewise.
164 (struct terminal.mouse_position_hook): Likewise.
165 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
166 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
167 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
168 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
169 what it was before.
170 * menu.h, termhooks.h: Include "systime.h", for Time.
171
8e55734a
PE
172 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
173 Don't assume that the difference between two unsigned long values
174 can fit into an integer. At this point, we know button_down_time
175 <= event->timestamp, so the difference must be nonnegative, so
176 there's no need to cast the result if double-click-time is
177 nonnegative, as it should be; check that it's nonnegative, just in
178 case. This bug is triggered when events are more than 2**31 ms
86db42d2 179 apart (about 25 days). (Bug#8664)
8e55734a 180
841f1b75 181 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 182 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 183
3e26f69c
PE
184 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
185 that always fit in int. Use a sentinel instead of a counter, to
186 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
187 * frame.h (struct frame): Use int for menu_bar_items_used
188 instead of EMACS_INT, since it always fits in int.
3e26f69c 189
5cc152c0
PE
190 * menu.c (grow_menu_items): Check for int overflow.
191
d89eb65e
PE
192 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
193
5235bd3e
PE
194 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
195 Before, the code was not consistent. These values cannot exceed
196 2**31 - 1 so there's no need to make them unsigned.
197 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
198 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
199 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
200 as modifiers.
201 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
202
bc827e23
PE
203 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
204 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
205 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
206 presumably because the widths might not match.
207
78eb494e
PE
208 * window.c (size_window): Avoid needless test at loop start.
209
04f2d78b
CB
2102011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
211
212 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
213
d2fc7e3d 2142011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
215
216 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
217
d2fc7e3d 2182011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
219
220 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
221 `width' to `bar_area_x' and `bar_area_width', respectively.
222 (x_scroll_run): Take account of fringe background extension.
223
04f2d78b
CB
224 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
225 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
226 `bar_area_width', respectively.
227 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
228 background extension.
229
79b70037
GM
2302011-05-10 Jim Meyering <meyering@redhat.com>
231
232 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
233
2f142cc5
JB
2342011-05-10 Juanma Barranquero <lekktu@gmail.com>
235
236 * image.c (Finit_image_library): Return t for built-in image types,
237 like pbm and xbm. (Bug#8640)
238
57679c86
AS
2392011-05-09 Andreas Schwab <schwab@linux-m68k.org>
240
241 * w32menu.c (set_frame_menubar): Fix submenu allocation.
242
888c9e86
EZ
2432011-05-07 Eli Zaretskii <eliz@gnu.org>
244
b0512a1d
EZ
245 * w32console.c (Fset_screen_color): Doc fix.
246 (Fget_screen_color): New function.
247 (syms_of_ntterm): Defsubr it.
248
7285dc67
EZ
249 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
250 unlink the temporary file if Fcall_process didn't create it in the
251 first place.
252 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
253 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
254 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
255 cue to call_process_cleanup not to close that handle.
256
4d3fcc8e
BK
2572011-05-07 Ben Key <bkey76@gmail.com>
258
259 * makefile.w32-in: The bootstrap-temacs rule now makes use of
260 one of two shell specific rules, either bootstrap-temacs-CMD or
261 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
262 to the previous implementation of the bootstrap-temacs rule.
263 The bootstrap-temacs-CMD rule is similar to the previous
264 implementation of the bootstrap-temacs rule except that it
265 makes use of the ESC_CFLAGS variable instead of the CFLAGS
266 variable.
267
268 These changes, along with some changes to nt/configure.bat,
269 nt/gmake.defs, and nt/nmake.defs, are required to extend my
270 earlier fix to add support for --cflags and --ldflags options
271 that include quotes so that it works whether make uses cmd or
272 sh as the shell.
273
b4289b64
MA
2742011-05-06 Michael Albinus <michael.albinus@gmx.de>
275
276 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
277 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
278 is a constant.
279 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
280 a string. Handle both cases.
281 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
282 (Fdbus_register_method): Use Qinvalid_function.
283
af4c0e28
JB
2842011-05-06 Juanma Barranquero <lekktu@gmail.com>
285
286 * makefile.w32-in: Update dependencies.
287 (LISP_H): Add inttypes.h and stdin.h.
288 (PROCESS_H): Add unistd.h.
289
c51453d9
EZ
2902011-05-06 Eli Zaretskii <eliz@gnu.org>
291
292 * lread.c: Include limits.h (fixes the MS-Windows build broken by
293 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
294
8ff0ac3c 2952011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 296
4c4b566b
PE
297 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
298
aab2b9b5
PE
299 * term.c (vfatal): Remove stray call to va_end.
300 It's not needed and the C Standard doesn't allow it here anyway.
301
c378da0b
PE
302 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
303 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
304
288b08c7
PE
305 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
306 bytes.
307
e3601888
PE
308 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
309
db6c0e74
PE
310 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
311
dd5963ea
PE
312 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
313
88c9450f
PE
314 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
315
2f9442b8
PE
316 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
317
c032b5f8
PE
318 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
319 * charset.c (Fdefine_charset_internal): Don't initialize
320 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 321 32-bit int (Bug#8600).
a108c10b
PE
322
323 * lread.c (read_integer): Be more consistent with string-to-number.
324 Use string_to_number to do the actual conversion; this avoids
325 rounding errors and fixes some other screwups. Without this fix,
326 for example, #x1fffffffffffffff was misread as -2305843009213693952.
327 (digit_to_number): Move earlier, for benefit of read_integer.
328 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 329 not a digit in any supported base. (Bug#8602)
a108c10b 330
ad5f9eea
PE
331 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
332
aec1708a
PE
333 * dispnew.c (scrolling_window): Return 1 if we scrolled,
334 to match comment at start of function. This also removes a
335 GCC warning about overflow in a 32+64-bit port.
336
47be4ab5
PE
337 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
338
371cac43
PE
339 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
340 Reported by Stefan Monnier in
341 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
342 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
343 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 344
d01a7826
PE
345 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
346 (EMACS_UINTPTR): Likewise, with uintptr_t.
347
7fd47d5c
PE
348 * lisp.h: Prefer 64-bit EMACS_INT if available.
349 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
350 on 32-bit hosts that have 64-bit int, so that they can access
351 large files.
122b0c86
PE
352 However, temporarily disable this change unless the temporary
353 symbol WIDE_EMACS_INT is defined.
7fd47d5c 354
8727937b
PE
355 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
356
8ac068ac
PE
357 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
358 This removes an assumption that EMACS_INT and long are the same
359 width as pointers. The assumption is true for Emacs porting targets
360 now, but we want to make other targets possible.
361 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
362 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
363 In the rest of the code, change types of integers that hold casted
364 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
365 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
366 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
367 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
368 No need to cast type when ORing.
369 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
370 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
371 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
372 assume EMACS_INT is the same width as char *.
373 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
374 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
375 Remove no-longer-needed casts.
376 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
377 (xg_tool_bar_help_callback, xg_make_tool_item):
378 Use EMACS_INTPTR to hold an integer
379 that will be cast to void *; this can avoid a GCC warning
380 if EMACS_INT is not the same width as void *.
381 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
382 * xdisp.c (display_echo_area_1, resize_mini_window_1):
383 (current_message_1, set_message_1):
384 Use a local to convert to proper width without a cast.
385 * xmenu.c (dialog_selection_callback): Likewise.
386
ede49d71
PE
387 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
388 Also, don't assume VALBITS / RAND_BITS is less than 5,
389 and don't rely on undefined behavior when shifting a 1 left into
390 the sign bit.
391 * lisp.h (get_random): Change signature to match.
392
2f30ecd0
PE
393 * lread.c (hash_string): Use size_t, not int, for hash computation.
394 Normally we prefer signed values; but hashing is special, because
395 it's better to use unsigned division on hash table sizes so that
396 the remainder is nonnegative. Also, size_t is the natural width
397 for hashing into memory. The previous code used 'int', which doesn't
398 retain enough info to hash well into very large tables.
399 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
400
2a866e7b
PE
401 * dbusbind.c: Don't possibly lose pointer info when converting.
402 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
403 Use XPNTR rather than XHASH, so that the high-order bits of
404 the pointer aren't lost when converting through void *.
405
51639eac
PE
406 * eval.c (Fautoload): Don't double-shift a pointer.
407
92394119
PE
408 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
409
dbdb9a7c
JB
4102011-05-06 Juanma Barranquero <lekktu@gmail.com>
411
412 * gnutls.c (DEF_GNUTLS_FN):
413 * image.c (DEF_IMGLIB_FN): Make function pointers static.
414
db7a0b4f
AS
4152011-05-05 Andreas Schwab <schwab@linux-m68k.org>
416
417 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
418 marker. (Bug#8610)
419
f7ff1b0f 4202011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
421
422 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
423 New version that can reserve upto 2GB of heap space.
424
f7ff1b0f 4252011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
426
427 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
428
639c109b
TZ
4292011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
430
431 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
432 `gnutls_certificate_set_x509_key_file'.
433
d2127135
JB
4342011-05-05 Juanma Barranquero <lekktu@gmail.com>
435
436 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
437 Update dependencies.
438
e968f4f3
JB
4392011-05-04 Juanma Barranquero <lekktu@gmail.com>
440
441 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
442 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
443 Remove unused parameter `fildes'.
444 * process.c (read_process_output, send_process): Don't pass it.
445
84d358f0
JB
4462011-05-04 Juanma Barranquero <lekktu@gmail.com>
447
448 Fix previous change: the library cache is defined in w32.c.
449 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
450 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
451
0898ca10
JB
4522011-05-04 Juanma Barranquero <lekktu@gmail.com>
453
454 Implement dynamic loading of GnuTLS on Windows.
455
456 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
457 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
458 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
459 Declare.
460
461 * gnutls.c (Qgnutls_dll): Define.
462 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
463 (gnutls_*): Declare function pointers.
464 (init_gnutls_functions): New function to initialize function pointers.
465 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
466 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
467 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
468 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
469 (emacs_gnutls_write, emacs_gnutls_read)
470 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
471 (Fgnutls_available_p): New function.
472 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
473 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
474 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
475
476 * image.c: Include w32.h.
477 (Vimage_type_cache): Delete.
478 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
479 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
480 (w32_delayed_load): Move to w32.c.
481
482 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
483
484 * w32.c (QCloaded_from, Vlibrary_cache): Define.
485 (w32_delayed_load): Move from image.c. When loading a library, record
486 its filename in the :loaded-from property of the library id.
487 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
488 Initialize and staticpro them.
489 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
490
491 * process.c: Include lisp.h before w32.h, not after.
492 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
493 instead of gnutls_record_check_pending.
494
495 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
496
ff4de4aa
TZ
4972011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
498
499 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
500 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
501 as passed in.
502
abe95abb
JD
5032011-05-03 Jan Djärv <jan.h.d@swipnet.se>
504
505 * xterm.c (x_set_frame_alpha): Do not set property on anything
506 else than FRAME_X_OUTER_WINDOW (Bug#8608).
507
e16e55d4
JB
5082011-05-02 Juanma Barranquero <lekktu@gmail.com>
509
510 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
511
bafcf6a5
JB
5122011-05-02 Juanma Barranquero <lekktu@gmail.com>
513
514 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
515 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
516 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
517 (gnutls_global_initialized, Qgnutls_bootprop_priority)
518 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
519 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
520 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
521 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
522 (Qgnutls_bootprop_callbacks_verify): Make static.
523
e7a6747f
AS
5242011-05-01 Andreas Schwab <schwab@linux-m68k.org>
525
19ed11ba
AS
526 * callproc.c: Indentation fixup.
527
e7a6747f 528 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
529 (wait_for_termination, interruptible_wait_for_termination):
530 Move after wait_for_termination_1.
e7a6747f 531
1ef14cb4
LMI
5322011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
533
534 * sysdep.c (interruptible_wait_for_termination): New function
535 which is like wait_for_termination, but allows keyboard
536 interruptions.
537
538 * callproc.c (Fcall_process): Add (:file "file") as an option for
539 the STDOUT buffer.
540 (Fcall_process_region): Ditto.
541
330d880c
EZ
5422011-04-30 Eli Zaretskii <eliz@gnu.org>
543
8db90b73
EZ
544 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
545 rather than `XVECTOR (FOO)->size'.
546
330d880c
EZ
547 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
548 inttypes.h, as a gnulib replacement is used if it not available in
549 system headers.
550
15cbd324
EZ
5512011-04-21 Eli Zaretskii <eliz@gnu.org>
552
553 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
554 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
555 of MOST_POSITIVE_FIXNUM. (Bug#8528)
556
557 * coding.c (coding_alloc_by_realloc): Error out if destination
558 will grow beyond MOST_POSITIVE_FIXNUM.
559 (decode_coding_emacs_mule): Abort if there isn't enough place in
560 charbuf for the composition carryover bytes. Reserve an extra
561 space for up to 2 characters produced in a loop.
562 (decode_coding_iso_2022): Abort if there isn't enough place in
563 charbuf for the composition carryover bytes.
564
5652011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 566
ae940cca
EZ
567 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
568 aborting when %lld or %lll format is passed.
569 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
570 %llo or %llx format is passed. (Bug#8545)
571
03ab8921
EZ
572 * window.c (window_scroll_line_based): Use a marker instead of
573 simple variables to record original value of point. (Bug#7952)
574
afda1437
EZ
575 * doprnt.c (doprnt): Fix the case where a multibyte sequence
576 produced by %s or %c overflows available buffer space. (Bug#8545)
577
f76dee0c
PE
5782011-04-28 Paul Eggert <eggert@cs.ucla.edu>
579
580 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 581 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 582
fdc5744d
JB
5832011-04-28 Juanma Barranquero <lekktu@gmail.com>
584
585 * w32.c (init_environment): Warn about defaulting HOME to C:\.
586
638f053a
JB
5872011-04-28 Juanma Barranquero <lekktu@gmail.com>
588
589 * keyboard.c (Qdelayed_warnings_hook): Define.
590 (command_loop_1): Run `delayed-warnings-hook'
591 if Vdelayed_warnings_list is non-nil.
592 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
593 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
594
d178f871
EZ
5952011-04-28 Eli Zaretskii <eliz@gnu.org>
596
597 * doprnt.c (doprnt): Don't return value smaller than the buffer
598 size if the message was truncated. (Bug#8545).
599
b124fd93
JB
6002011-04-28 Juanma Barranquero <lekktu@gmail.com>
601
602 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
603 (Fx_window_property): #if-0 the whole functions, not just the bodies.
604
e810457d
PE
6052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
606
607 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
608
ea51cceb
JB
6092011-04-27 Juanma Barranquero <lekktu@gmail.com>
610
611 * makefile.w32-in: Update dependencies.
612
94dcfacf
EZ
6132011-04-27 Eli Zaretskii <eliz@gnu.org>
614
615 Improve `doprnt' and its usage. (Bug#8545)
616 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
617 `format_end'. Remove support for %l as a conversion specifier.
618 Don't use xrealloc. Improve diagnostics when the %l size modifier
619 is used. Update the commentary.
620
621 * eval.c (verror): Simplify calculation of size_t.
622
623 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
624 messages.
625
f61f41d7
PE
6262011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
627
628 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
629 change.
630
96fb4434
PE
6312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
632
633 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
634 This makes this file independent of the recent pseudovector change.
635
671875da 6362011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 637
69e9b5a3
PE
638 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
639
b5f869a7 640 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 641 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 642 Remove unused local.
c8926152 643 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 644
841a1577 645 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
646 GCC 4.6.0 optimizes based on type-based alias analysis.
647 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
648 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
649 != &v->size, and therefore "v->size = 1; b->size = 2; return
650 v->size;" must therefore return 1. This assumption is incorrect
651 for Emacs, since it type-puns struct Lisp_Vector * with many other
652 types. To fix this problem, this patch adds a new type struct
f904488f 653 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
654 and pseudovectors, and helps optimizing compilers not get fooled
655 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
656 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
657 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
658 the size member.
eab3844f
PE
659 (XSETPVECTYPE): Rewrite in terms of new macro.
660 (XSETPVECTYPESIZE): New macro, specifying both type and size.
661 This is a bit clearer, and further avoids the possibility of
662 undesirable aliasing.
663 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 664 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
665 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
666 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
667 (ASIZE): Now uses header.size rather than size.
668 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
669 to avoid the hassle of writing XVECTOR (foo)->header.size.
670 (struct vectorlike_header): New type.
eab3844f
PE
671 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
672 object, to help avoid aliasing.
673 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
674 (SUBRP): Likewise, since Lisp_Subr is a special case.
675 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
676 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
677 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 678 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
679 changed to be "header.size" and "header.next".
680 * buffer.h (struct buffer): Likewise.
681 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
682 * frame.h (struct frame): Likewise.
683 * process.h (struct Lisp_Process): Likewise.
684 * termhooks.h (struct terminal): Likewise.
685 * window.c (struct save_window_data, struct saved_window): Likewise.
686 * window.h (struct window): Likewise.
687 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
688 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
689 * buffer.c (init_buffer_once): Likewise.
690 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
691 special case.
692 * process.c (Fformat_network_address): Use local var for size,
693 for brevity.
694
0df1eac5
PE
695 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
696
847ab9d1 697 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
698 * data.c (atof): Remove decl; no longer used or needed.
699 (digit_to_number): Move to lread.c.
700 (Fstring_to_number): Use new string_to_number function, to be
701 consistent with how the Lisp reader treats infinities and NaNs.
702 Do not assume that floating-point numbers represent EMACS_INT
703 without losing information; this is not true on most 64-bit hosts.
704 Avoid double-rounding errors, by insisting on integers when
705 parsing non-base-10 numbers, as the documentation specifies.
706 * lisp.h (string_to_number): New decl, replacing ...
707 (isfloat_string): Remove.
bc0a5c13 708 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 709 (read1): Do not accept +. and -. as integers; this
452f4150
PE
710 appears to have been a coding error. Similarly, do not accept
711 strings like +-1e0 as floating point numbers. Do not report
712 overflow for integer overflows unless the base is not 10 which
713 means we have no simple and reliable way to continue.
714 Break out the floating-point parsing into a new
715 function string_to_number, so that Fstring_to_number parses
716 floating point numbers consistently with the Lisp reader.
04f2d78b 717 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
718 (E_CHAR, EXP_INT): Remove, replacing with ...
719 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
720 (string_to_number): New function, replacing isfloat_string.
721 This function checks for valid syntax and produces the resulting
722 Lisp float number too. Rework it so that string-to-number
bc0a5c13 723 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
724 so that overflow for non-base-10 numbers is reported only when
725 there's no portable and simple way to convert to floating point.
452f4150 726
67769ffc
PE
727 * textprop.c (set_text_properties_1): Rewrite for clarity,
728 and to avoid GCC warning about integer overflow.
729
c20db43f
PE
730 * intervals.h (struct interval): Use EMACS_INT for members
731 where EMACS_UINT might cause problems. See
732 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
733 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
734 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
735 All uses changed.
37aa2f85
PE
736 (offset_intervals): Tell GCC not to worry about length overflow
737 when negating a negative length.
c20db43f 738
2538aa2f
PE
739 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
740 (overrun_check_free): Likewise.
741
f2d3008d
PE
742 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
743 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
744 word size.
745
ec8df744
PE
746 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
747 (gnutls_make_error): Rename local to avoid shadowing.
748 (gnutls_emacs_global_deinit): ifdef out; not used.
749 (Fgnutls_boot): Use const for pointer to readonly storage.
750 Comment out unused local. Fix pointer signedness problems.
751
640ee02d
PE
752 * lread.c (openp): Don't stuff size_t into an 'int'.
753 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
754 about possible signed overflow.
755
6048fb2a
PE
756 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
757 (GDK_KEY_g): Don't define if already defined.
758 (xg_prepare_tooltip): Avoid pointer signedness problem.
759 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
760
fa3c87e1
PE
761 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
762 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
763
2172544b
PE
764 * xfns.c (Fx_window_property): Simplify a bit,
765 to make a bit faster and to avoid GCC 4.6.0 warning.
766 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
767
9b821a21
PE
768 * fns.c (internal_equal): Don't assume size_t fits in int.
769
3c616cfa
PE
770 * alloc.c (compact_small_strings): Tighten assertion a little.
771
c2982e87
PE
772 Replace pEd with more-general pI, and fix some printf arg casts.
773 * lisp.h (pI): New macro, generalizing old pEd macro to other
774 conversion specifiers. For example, use "...%"pI"d..." rather
775 than "...%"pEd"...".
776 (pEd): Remove. All uses replaced with similar uses of pI.
777 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
778 * alloc.c (check_pure_size): Don't overflow by converting size to int.
779 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
780 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
781 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
782 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
783 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
784 64-bit hosts.
785 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
786 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
787 * print.c (safe_debug_print, print_object): Likewise.
788 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
789 to int.
6f04d126
PE
790 Use pI instead of if-then-else-abort. Use %p to avoid casts,
791 avoiding the 0 flag, which is not portable.
c2982e87
PE
792 * process.c (Fmake_network_process): Use pI to avoid cast.
793 * region-cache.c (pp_cache): Likewise.
794 * xdisp.c (decode_mode_spec): Likewise.
795 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
796 behavior on 64-bit hosts with printf arg.
6f04d126 797 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
798 (x_stop_queuing_selection_requests): Likewise.
799 (x_get_window_property): Don't truncate byte count to an 'int'
800 when tracing.
0b432f21 801
5e073ec7
PE
802 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
803 here, since it parses constructs like leading '-' and spaces,
804 which are not wanted; and it overflows with large numbers.
805 Instead, simply match F[0-9]+, which is what is wanted anyway.
806
36372bf9
PE
807 * alloc.c: Remove unportable assumptions about struct layout.
808 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
809 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
810 (allocate_vectorlike, make_pure_vector): Use the new macros,
811 plus offsetof, to remove unportable assumptions about struct layout.
812 These assumptions hold on all porting targets that I know of, but
813 they are not guaranteed, they're easy to remove, and removing them
814 makes further changes easier.
815
0b432f21
PE
816 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
817 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
818 (string_overrun_cookie): Now const. Use initializers that
819 don't formally overflow signed char, to avoid warnings.
000098c1
PE
820 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
821 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
822 (allocate_buffer): Don't assume sizeof (struct buffer) is a
823 multiple of sizeof (EMACS_INT); it need not be, if
824 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 825 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 826
895009e1
JB
8272011-04-26 Juanma Barranquero <lekktu@gmail.com>
828
829 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
830
6a7a1b0b
TZ
8312011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
832
833 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 834 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
835 Reported by Paul Eggert <eggert@cs.ucla.edu>.
836
841a1577 8372011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
838
839 * lisp.h (Qdebug): List symbol.
895009e1 840 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
841 * keyboard.c (debug-on-event): New variable.
842 (handle_user_signal): Break into debugger when debug-on-event
843 matches the current signal symbol.
844
f2d3ba6f
DN
8452011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
846
847 * alloc.c (check_sblock, check_string_bytes)
848 (check_string_free_list): Convert to standard C.
849
42ce4c63
TZ
8502011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
851
852 * w32.c (emacs_gnutls_push): Fix typo.
853
825cd63c
EZ
8542011-04-25 Eli Zaretskii <eliz@gnu.org>
855
fb11d64d
EZ
856 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
857 "cast to pointer from integer of different size".
858
825cd63c
EZ
859 Improve doprnt and its use in verror. (Bug#8545)
860 * doprnt.c (doprnt): Document the set of format control sequences
861 supported by the function. Use SAFE_ALLOCA instead of always
862 using `alloca'.
863
864 * eval.c (verror): Don't limit the buffer size at size_max-1, that
865 is one byte too soon. Don't use xrealloc; instead xfree and
866 xmalloc anew.
867
e061a11b
TZ
8682011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
869
870 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
871 callbacks stage.
872
873 * gnutls.c: Renamed global_initialized to
874 gnutls_global_initialized. Added internals for the
875 :verify-hostname-error, :verify-error, and :verify-flags
876 parameters of `gnutls-boot' and documented those parameters in the
877 docstring. Start callback support.
878 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
879 unless a fatal error occured. Call gnutls_alert_send_appropriate
880 on error. Return error code.
881 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
882 (emacs_gnutls_read): Likewise.
883 (Fgnutls_boot): Return handshake error code.
884 (emacs_gnutls_handle_error): New function.
885 (wsaerror_to_errno): Likewise.
886
887 * w32.h (emacs_gnutls_pull): Add prototype.
888 (emacs_gnutls_push): Likewise.
889
890 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
891 (emacs_gnutls_push): Likewise.
892
8932011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
894
895 * process.c (wait_reading_process_output): Check if GnuTLS
896 buffered some data internally if no FDs are set for TLS
897 connections.
898
899 * makefile.w32-in (OBJ2): Add gnutls.$(O).
900 (LIBS): Link to USER_LIBS.
901 ($(BLD)/gnutls.$(0)): New target.
902
fa6996bc
EZ
9032011-04-24 Eli Zaretskii <eliz@gnu.org>
904
eb35682e
EZ
905 * xdisp.c (handle_single_display_spec): Rename the
906 display_replaced_before_p argument into display_replaced_p, to
907 make it consistent with the commentary. Fix typos in the
908 commentary.
909
e2ad650c
EZ
910 * textprop.c (syms_of_textprop): Remove dead code.
911 (copy_text_properties): Delete obsolete commentary about an
912 interface that was deleted long ago. Fix typos in the description
913 of arguments.
914
1b2de274
EZ
915 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
916 to changes in oldXMenu/XMenu.h from 2011-04-16.
917 <menu_help_message, prev_menu_help_message>: Constify.
918 (IT_menu_make_room): menu->help_text is now `const char **';
919 adjust.
920
921 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
922 to changes in oldXMenu/XMenu.h from 2011-04-16.
923 (struct XMenu): Declare `help_text' `const char **'.
924
925 * xfaces.c <Qunspecified>: Make extern again.
926
927 * syntax.c: Include sys/types.h before including regex.h, as
928 required by Posix.
929
762b15be
EZ
930 * doc.c (get_doc_string): Improve the format passed to `error'.
931
932 * doprnt.c (doprnt): Improve commentary.
933
934 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
935
936 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
937 them with etags.
938
f1052e5d
EZ
939 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
940 changes in globals.h immediately force recompilation.
762b15be
EZ
941 (TAGS): Depend on $(CURDIR)/m/intel386.h and
942 $(CURDIR)/s/ms-w32.h.
943 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 944
fa6996bc
EZ
945 * character.c (Fchar_direction): Function deleted.
946 (syms_of_character): Don't defsubr it.
947 <char-direction-table>: Deleted.
948
e6c3da20
EZ
9492011-04-23 Eli Zaretskii <eliz@gnu.org>
950
951 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
952 * doprnt.c: Include limits.h.
953 (SIZE_MAX): New macro.
04f2d78b
CB
954 (doprnt): Return a size_t value. 2nd arg is now size_t.
955 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
956 Improve overflow protection. Support `l' modifier for integer
957 conversions. Support %l conversion. Don't assume an EMACS_INT
958 argument for integer conversions and for %c.
959
960 * lisp.h (doprnt): Restore prototype.
961
962 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
963 $(SRC)/character.h.
964
965 * Makefile.in (base_obj): Add back doprnt.o.
966
967 * deps.mk (doprnt.o): Add back prerequisites.
968 (callint.o): Depend on character.h.
969
970 * eval.c (internal_lisp_condition_case): Include the handler
971 representation in the error message.
972 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
973 when breaking from the loop.
974
975 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
976
977 * callint.c (Fcall_interactively): When displaying error message
978 about invalid control letter, pass the character's codepoint, not
979 a pointer to its multibyte form. Improve display of the character
980 in octal and display also its hex code.
981
982 * character.c (char_string): Use %x to display the (unsigned)
983 codepoint of an invalid character, to avoid displaying a bogus
984 negative value.
985
986 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
987 `error', not SYMBOL_NAME itself.
988
989 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
990 character arguments to `error'.
991
992 * charset.c (check_iso_charset_parameter): Fix incorrect argument
993 to `error' in error message about FINAL_CHAR argument. Make sure
994 FINAL_CHAR is a character, and use %c when it is passed as
995 argument to `error'.
996
4ffd0d6b 9972011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
998
999 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1000
1001 * w32.c: Include <time.h>.
1002 (sys_localtime): New function.
1003
4ffd0d6b 10042011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1005
1006 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1007
4ffd0d6b 1008 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1009
4ffd0d6b 10102011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1011
4ffd0d6b
GM
1012 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1013 zombies (Bug#8467).
aac0c6e3 1014
04c56954
EZ
10152011-04-19 Eli Zaretskii <eliz@gnu.org>
1016
1017 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1018 gl_state.e_property when gl_state.object is Qt.
1019
1020 * insdel.c (make_gap_larger): Remove limitation of buffer size
1021 to <= INT_MAX.
1022
16a43933
CY
10232011-04-18 Chong Yidong <cyd@stupidchicken.com>
1024
1025 * xdisp.c (lookup_glyphless_char_display)
1026 (produce_glyphless_glyph): Handle cons cell entry in
1027 glyphless-char-display.
1028 (Vglyphless_char_display): Document it.
1029
1030 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1031 glyphless-char-display.
1032
4581706e
CY
10332011-04-17 Chong Yidong <cyd@stupidchicken.com>
1034
1035 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1036
1037 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1038
1039 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1040 definition for no-X builds.
1041
4887c6e2 10422011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1043
fd35b6f9
PE
1044 Static checks with GCC 4.6.0 and non-default toolkits.
1045
5c1ccb01
PE
1046 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1047
006c5daa
PE
1048 * process.c (keyboard_bit_set): Define only if SIGIO.
1049 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1050 (send_process): Repair possible setjmp clobbering.
1051
efc736d3
PE
1052 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1053
4e2fe2e6
PE
1054 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1055
f97334a2
PE
1056 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1057
4e75f29d
PE
1058 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1059 Define only if needed.
1060
90efadd1
PE
1061 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1062 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1063 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1064
3c647824
PE
1065 * dispextern.h (struct redisplay_interface): Rename param
1066 to avoid shadowing.
e264f262 1067 * termhooks.h (struct terminal): Likewise.
761383f4 1068 * xterm.c (xembed_send_message): Likewise.
3c647824 1069
b58c5c4a
PE
1070 * insdel.c (make_gap_smaller): Define only if
1071 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1072
cad59032
PE
1073 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1074 it.
1075
c339dc2e
PE
1076 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1077 so that we aren't warned about unused symbols.
1078
91a3e27b
PE
1079 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1080
399c71d3 1081 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1082
8ffc96f5
PE
1083 * xfns.c (x_real_positions): Mark locals as initialized.
1084
eef9bc79
PE
1085 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1086
098db9dd
PE
1087 * xterm.c: Fix problems found by static analysis with other toolkits.
1088 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1089 (x_dispatch_event): Declare static if USE_GTK, and
1090 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1091 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1092 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1093 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1094 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1095
eb18f6cc
PE
1096 * xmenu.c (menu_help_callback): Pointer type fixes.
1097 Use const pointers when pointing at readonly data. Avoid pointer
1098 signedness clashes.
1099 (FALSE): Remove unused macro.
1100 (update_frame_menubar): Remove unused decl.
1101
1fe72bf8
PE
1102 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1103
60d9e1db
PE
1104 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1105 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1106 (single_menu_item): Rename local to avoid shadowing.
1107
39261c26
PE
1108 * keyboard.c (make_lispy_event): Remove unused local var.
1109
018c5e19
PE
1110 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1111 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1112
63d2b86e
PE
1113 * bitmaps: Change bitmaps from unsigned char back to the X11
1114 compatible char. Avoid the old compiler warnings about
1115 out-of-range initializers by using, for example, '\xab' rather
1116 than 0xab.
1117
aefd87e1
PE
1118 * xgselect.c (xgselect_initialize): Check vs interface
1119 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1120
bf501fb9
PE
1121 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1122
e9829fdf
PE
1123 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1124 to read-only memory.
1125
1086c095
PE
1126 * fns.c (vector): Remove; this old hack is no longer needed.
1127
2baccd04 1128 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1129 Remove unused var.
dde42981 1130 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1131
72391843 1132 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1133
436c16df 1134 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1135 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1136 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1137
92bb796d 1138 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1139 (x_term_init): Remove local to avoid shadowing.
92bb796d 1140
764430a3 1141 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1142
1143 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1144 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1145
d1dfb56c
EZ
11462011-04-16 Eli Zaretskii <eliz@gnu.org>
1147
c4354cb4
EZ
1148 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1149
d1dfb56c
EZ
1150 Fix regex.c, syntax.c and friends for buffers > 2GB.
1151 * syntax.h (struct gl_state_s): Declare character position members
1152 EMACS_INT.
1153
1154 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1155
04f2d78b
CB
1156 * textprop.c (verify_interval_modification, interval_of):
1157 Declare arguments EMACS_INT.
d1dfb56c
EZ
1158
1159 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1160 EMACS_INT.
1161
1162 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1163
1164 * indent.c (Fvertical_motion): Local variable it_start is now
1165 EMACS_INT.
1166
1167 * regex.c (re_match, re_match_2, re_match_2_internal)
1168 (bcmp_translate, regcomp, regexec, print_double_string)
1169 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1170 (re_compile_pattern, re_exec): Declare arguments and local
1171 variables `size_t' and `ssize_t' and return values `regoff_t', as
1172 appropriate.
1173 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1174 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1175 <compile_stack_type>: `size' and `avail' are now `size_t'.
1176
1177 * regex.h <regoff_t>: Use ssize_t, not int.
1178 (re_search, re_search_2, re_match, re_match_2): Arguments that
1179 specify buffer/string position and length are now ssize_t and
1180 size_t. Return type is regoff_t.
1181
613052cd
BK
11822011-04-16 Ben Key <bkey76@gmail.com>
1183
1184 * nsfont.m: Fixed bugs in ns_get_family and
1185 ns_descriptor_to_entity that were caused by using free to
1186 deallocate memory blocks that were allocated by xmalloc (via
1187 xstrdup). This caused Emacs to crash when compiled with
1188 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1189 --enable-checking=xmallocoverrun). xfree is now used to
1190 deallocate these memory blocks.
1191
4170f62f 11922011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1193
71b41406
PE
1194 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1195
9587a89d
PE
1196 emacs_write: Accept and return EMACS_INT for sizes.
1197 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1198 et seq.
1199 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1200 Accept and return EMACS_INT.
1201 (emacs_gnutls_write): Return the number of bytes written on
1202 partial writes.
1203 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1204 (emacs_read, emacs_write): Remove check for negative size, as the
1205 Emacs source code has been audited now.
9587a89d
PE
1206 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1207 (emacs_read, emacs_write): Use it.
273a5f82
PE
1208 * process.c (send_process): Adjust to the new signatures of
1209 emacs_write and emacs_gnutls_write. Do not attempt to store
1210 a byte offset into an 'int'; it might overflow.
9587a89d 1211 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1212
3e047f51
PE
1213 * sound.c: Don't assume sizes fit in 'int'.
1214 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1215 Return EMACS_INT, not int.
3e047f51 1216 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1217 Accept EMACS_INT, not int.
1218 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1219 record read return values.
1220
cc39a9db
BK
12212011-04-15 Ben Key <bkey76@gmail.com>
1222
c9d0ec6d
JB
1223 * keyboard.c (Qundefined): Don't declare static since it is used
1224 in nsfns.m.
1225 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1226 static since they are used in nsfont.m.
cc39a9db 1227
6c60eb9f
SM
12282011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1229
1230 * process.c (Qprocessp): Don't declare static.
1231 * lisp.h (Qprocessp): Declare again.
1232
7990b61a
JB
12332011-04-15 Juanma Barranquero <lekktu@gmail.com>
1234
1235 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1236
5d4cb038
PE
12372011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1238
8bd7b830 1239 Improve C-level modularity by making more things 'static'.
cd64ea1d 1240
e3b27b31
PE
1241 Don't publish debugger-only interfaces to other modules.
1242 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1243 (verify_bytepos, count_markers): Move decls to the only modules
1244 that need them.
1245 * region-cache.h (pp_cache): Likewise.
1246 * window.h (check_all_windows): Likewise.
1247 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1248
5d4cb038
PE
1249 * sysdep.c (croak): Now static, if
1250 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1251 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1252
1253 * alloc.c (refill_memory_reserve): Now static if
1254 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1255 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1256
e87b6180
PE
1257 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1258 Define only if USE_LUCID.
1259
ac64929e
PE
1260 * xrdb.c (x_customization_string, x_rm_string): Now static.
1261
6f37259d
PE
1262 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1263 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1264
1683e3ab
PE
1265 * xdisp.c (draw_row_with_mouse_face): Now static.
1266 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1267
de9c2632
PE
1268 * window.h (check_all_windows): Mark externally visible.
1269
2b96acb7
PE
1270 * window.c (window_deletion_count): Now static.
1271
1272 * undo.c: Make symbols static if they're not exported.
1273 (last_undo_buffer, last_boundary_position, pending_boundary):
1274 Now static.
1275
50436f33
PE
1276 * textprop.c (interval_insert_behind_hooks): Now static.
1277 (interval_insert_in_front_hooks): Likewise.
1278
64520e5c
PE
1279 * term.c: Make symbols static if they're not exported.
1280 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1281 (max_frame_lines, tty_set_terminal_modes):
1282 (tty_reset_terminal_modes, tty_turn_off_highlight):
1283 (get_tty_terminal): Now static.
1284 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1285 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1286 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1287 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1288 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1289
1fa53021
PE
1290 * sysdep.c: Make symbols static if they're not exported.
1291 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1292 Now static.
1293 (sigprocmask_set, full_mask): Remove; unused.
1294 (wait_debugging): Mark as visible.
1295 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1296 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1297
d4b43b22
PE
1298 * syntax.c (syntax_temp): Define only if !__GNUC__.
1299
b7c513d0
PE
1300 * sound.c (current_sound_device, current_sound): Now static.
1301
989b29ad
PE
1302 * search.c (searchbufs, searchbuf_head): Now static.
1303
13a55a78
PE
1304 * scroll.c (scroll_cost): Remove; unused.
1305 * dispextern.h (scroll_cost): Remove decl.
1306
de68a1fc
PE
1307 * region-cache.h (pp_cache): Mark as externally visible.
1308
40ccffa6
PE
1309 * process.c: Make symbols static if they're not exported.
1310 (process_tick, update_tick, create_process, chan_process):
1311 (Vprocess_alist, proc_buffered_char, datagram_access):
1312 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1313 (deactivate_process): Mark defn as static, as well as decl.
1314 * lisp.h (create_process): Remove decl.
1315 * process.h (chan_process, Vprocess_alist): Remove decls.
1316
ad64fc97
PE
1317 * print.c: Make symbols static if they're not exported.
1318 (print_depth, new_backquote_output, being_printed, print_buffer):
1319 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1320 (print_interval, print_number_index, initial_stderr_stream):
1321 Now static.
1322 * lisp.h (Fprinc): Remove decl.
1323 (debug_output_compilation_hack): Mark as externally visible.
1324
adddb265
PE
1325 * sysdep.c (croak): Move decl from here to syssignal.h.
1326 * syssignal.h (croak): Put it here, so the API can be checked when
1327 'croak' is called from dissociate_if_controlling_tty.
1328
1717ede2
PE
1329 * minibuf.c: Make symbols static if they're not exported.
1330 (minibuf_save_list, choose_minibuf_frame): Now static.
1331 * lisp.h (choose_minibuf_frame): Remove decl.
1332
fa5fb2bc
PE
1333 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1334
1e3890d1
PE
1335 * lread.c: Make symbols static if they're not exported.
1336 (read_objects, initial_obarray, oblookup_last_bucket_number):
1337 Now static.
1338 (make_symbol): Remove; unused.
1339 * lisp.h (initial_obarray, make_symbol): Remove decls.
1340
8a1414fa
PE
1341 * keyboard.c: Make symbols static if they're not exported.
1342 (single_kboard, recent_keys_index, total_keys, recent_keys):
1343 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1344 (this_single_command_key_start, echoing, last_auto_save):
1345 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1346 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1347 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1348 (Vlispy_mouse_stem, double_click_count):
1349 Now static.
1350 (force_auto_save_soon): Define only if SIGDANGER.
1351 (ignore_mouse_drag_p): Now static if
1352 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1353 (print_help): Remove; unused.
1354 (stop_character, last_timer_event): Mark as externally visible.
1355 * keyboard.h (ignore_mouse_drag_p): Declare only if
1356 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1357 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1358 * lisp.h (echoing): Remove decl.
1359 (force_auto_save_soon): Declare only if SIGDANGER.
1360 * xdisp.c (redisplay_window): Simplify code, to make it more
1361 obvious that ignore_mouse_drag_p is not accessed if !defined
1362 USE_GTK && !defined HAVE_NS.
1363
93ea6e8f
PE
1364 * intervals.c: Make symbols static if they're not exported.
1365 (merge_properties_sticky, merge_interval_right, delete_interval):
1366 Now static.
1367 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1368
77382fcc
PE
1369 * insdel.c: Make symbols static if they're not exported.
1370 However, leave prepare_to_modify_buffer alone. It's never
1371 called from outside this function, but that appears to be a bug.
1372 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1373 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1374 (adjust_after_replace_noundo): Remove; unused.
1375 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1376 (signal_before_change): Remove decls.
77382fcc 1377
9306c32e
PE
1378 * indent.c (val_compute_motion, val_vmotion): Now static.
1379
cd44d2eb
PE
1380 * image.c: Make symbols static if they're not exported.
1381 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1382 if USE_GTK.
1383 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1384 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1385
ad9a7a06
PE
1386 * fringe.c (standard_bitmaps): Now static.
1387 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1388
81626931
PE
1389 * frame.c: Make symbols static if they're not exported.
1390 (x_report_frame_params, make_terminal_frame): Now static.
1391 (get_frame_param): Now static, unless HAVE_NS.
1392 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1393 (x_get_resource_string): Remove; not used.
1394 * frame.h (make_terminal_frame, x_report_frame_params):
1395 (x_get_resource_string); Remove decls.
1396 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1397 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1398
239f9db9
PE
1399 * font.c, fontset.c: Make symbols static if they're not exported.
1400 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1401 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1402 * font.c (font_close_object): Now static.
1403 * font.h (font_close_object): Remove.
1404 * fontset.c (FONTSET_OBJLIST): Remove.
1405 (free_realized_fontset) #if-0 the body, which does nothing.
1406 (face_suitable_for_char_p): #if-0, as it's never called.
1407 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1408 * xfaces.c (face_at_string_position):
1409 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1410 since 0 is always ASCII.
1411
dfcf3579
PE
1412 * fns.c (weak_hash_tables): Now static.
1413
5045092b
PE
1414 * fileio.c: Make symbols static if they're not exported.
1415 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1416 (Vwrite_region_annotation_buffers): Now static.
1417
57a96f5c
PE
1418 * eval.c: Make symbols static if they're not exported.
1419 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1420 * lisp.h (backtrace_list): Remove decl.
1421
35f08c38
PE
1422 * emacs.c: Make symbols static if they're not exported.
1423 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1424 (fatal_error_code, fatal_error_signal_hook, standard_args):
1425 Now static.
1426 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1427 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1428 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1429 * lisp.h (fatal_error_signal_hook): Remove decl.
1430 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1431
f44bd759
PE
1432 * editfns.c: Move a (normally-unused) function to its only use.
1433 * editfns.c, lisp.h (get_operating_system_release): Remove.
1434 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1435 worth the hassle of breaking this out.
1436
b532497d
PE
1437 * xterm.c: Make symbols static if they're not exported.
1438 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1439 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1440 (x_destroy_window, x_delete_display):
1441 Now static.
1442 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1443 (x_mouse_leave): Remove; unused.
1444 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1445 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1446 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1447 Remove decls.
1448 (x_mouse_leave): Declare only if WINDOWSNT.
1449 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1450 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1451 USE_X_TOOLKIT.
1452
1675728f
PE
1453 * ftxfont.c: Make symbols static if they're not exported.
1454 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1455 HAVE_FREETYPE.
1456 * font.h (ftxfont_driver): Likewise.
1457
e4cebfca
PE
1458 * xfns.c: Make symbols static if they're not exported.
1459 (x_last_font_name, x_display_info_for_name):
1460 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1461 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1462 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1463 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1464 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1465 (last_show_tip_args): Now static.
1466 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1467 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1468 (x_screen_planes): Remove; unused.
1469 * dispextern.h (x_screen_planes): Remove decl.
1470
5bf46f05
PE
1471 * dispnew.c: Make symbols static if they're not exported.
1472 * dispextern.h (redraw_garbaged_frames, scrolling):
1473 (increment_row_positions): Remove.
1474 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1475 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1476 Now static.
1477 (redraw_garbaged_frames): Remove; unused.
1478
435f4c28
PE
1479 * xfaces.c: Make symbols static if they're not exported.
1480 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1481 Remove decls.
1482 * xterm.h (defined_color): Remove decls.
1483 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1484 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1485 (menu_face_changed_default, defined_color, free_realized_face):
1486 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1487 (ascii_face_of_lisp_face): Remove; unused.
1488
8524aef3
PE
1489 * xdisp.c: Make symbols static if they're not exported.
1490 * dispextern.h (scratch_glyph_row, window_box_edges):
1491 (glyph_to_pixel_coords, set_cursor_from_row):
1492 (get_next_display_element, set_iterator_to_next):
1493 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1494 (show_mouse_face): Remove decls
1495 * frame.h (message_buf_print): Likewise.
1496 * lisp.h (pop_message, set_message, check_point_in_composition):
1497 Likewise.
1498 * xterm.h (set_vertical_scroll_bar): Likewise.
1499 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1500 (message_buf_print, scratch_glyph_row, displayed_buffer):
1501 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1502 (get_next_display_element, show_mouse_face, window_box_edges):
1503 (frame_to_window_pixel_xy, check_point_in_composition):
1504 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1505 (glyph_to_pixel_coords): Remove; unused.
1506
16390cd2
PE
1507 * dired.c (file_name_completion): Now static.
1508
1509 * dbusbind.c (xd_in_read_queued_messages): Now static.
1510
a25f4dfa
PE
1511 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1512 * data.c (circular_list_error): Remove.
1513
14a9c8df
PE
1514 * commands.h (last_point_position, last_point_position_buffer):
1515 (last_point_position_window): Remove decls.
1516 * keyboard.c: Make these variables static.
1517
04f2d78b
CB
1518 * coding.h (coding, code_convert_region, encode_coding_gap):
1519 Remove decls.
74ab6df5
PE
1520 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1521 (iso_code_class, detect_coding, code_convert_region): Now static.
1522 (encode_coding_gap): Remove; unused.
1523
38dfbee1
PE
1524 * chartab.c (chartab_chars, chartab_bits): Now static.
1525
a2cb4e63
PE
1526 * charset.h (charset_iso_8859_1): Remove decl.
1527 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1528 Now static.
1529
127198fd
PE
1530 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1531 * ccl.c (Vccl_program_table): Now static.
1532 (check_ccl_update): Remove; unused.
1533
d85b608f
PE
1534 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1535 * category.h: ... from here.
1536 * category.c (check_category_table, set_category_set): Now static.
1537
31cd66f3
PE
1538 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1539 * lisp.h: Remove these decls.
1540
c358e587
PE
1541 * buffer.c (buffer_count): Remove unused var.
1542
e78aecca
PE
1543 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1544 so that it's not optimized away.
1545 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1546 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1547 exported only to the debugger.
1548
e192d7d3 1549 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1550 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1551
92470028
PE
1552 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1553 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1554 was inaccessible from Lisp.
1555 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1556 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1557
244ed907
PE
1558 alloc.c: Import and export fewer symbols, and remove unused items.
1559 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1560 is defined.
1561 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1562 it's not optimized away by whole-program optimization.
1563 (message_enable_multibyte, free_misc): Remove.
1564 (catchlist, handlerlist, mark_backtrace):
1565 Declare only if BYTE_MARK_STACK.
1566 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1567 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1568 (message_enable_multibyte): Remove decl.
1569 (free_misc, interval_free_list, float_block, float_block_index):
1570 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1571 (cons_free_list, last_marked_index):
1572 Now static.
1573 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1574 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1575 (mark_backtrace): Define only if BYTE_MARK_STACK.
1576 * xdisp.c (message_enable_multibyte): Now static.
1577
61c2b50e 1578 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1579 This makes it easier for human readers (and static analyzers)
1580 to see whether these variables are used from other modules.
1581 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1582 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1583 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1584 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1585 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1586 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1587 * xmenu.c, xselect.c:
1588 Declare Q* vars static if they are not used in other modules.
1589 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1590 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1591 Remove decls of unexported vars.
1592 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1593
95c82688
PE
1594 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1595
16a97296
PE
1596 Make Emacs functions such as Fatom 'static' by default.
1597 This makes it easier for human readers (and static analyzers)
1598 to see whether these functions can be called from other modules.
1599 DEFUN now defines a static function. To make the function external
1600 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1601 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1602 (Finit_image_library):
16a97296
PE
1603 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1604 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1605 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1606 Remove decls, since these functions are now static.
1607 (Funintern, Fget_internal_run_time): New decls, since these functions
1608 were already external.
95c82688 1609
16a97296
PE
1610 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1611 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1612 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1613 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1614 * keyboard.c, keymap.c, lread.c:
1615 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1616 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1617 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1618 Mark functions with DEFUE instead of DEFUN,
1619 if they are used in other modules.
1620 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1621 decls for now-static functions.
1622 * buffer.h (Fdelete_overlay): Remove decl.
1623 * callproc.c (Fgetenv_internal): Mark as internal.
1624 * composite.c (Fremove_list_of_text_properties): Remove decl.
1625 (Fcomposition_get_gstring): New forward static decl.
1626 * composite.h (Fcomposite_get_gstring): Remove decl.
1627 * dired.c (Ffile_attributes): New forward static decl.
1628 * doc.c (Fdocumntation_property): New forward static decl.
1629 * eval.c (Ffetch_bytecode): New forward static decl.
1630 (Funintern): Remove extern decl; now in .h file where it belongs.
1631 * fileio.c (Fmake_symbolic_link): New forward static decl.
1632 * image.c (Finit_image_library): New forward static decl.
1633 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1634 * intervals.h (Fprevious_property_change):
1635 (Fremove_list_of_text_properties): Remove decls.
1636 * keyboard.c (Fthis_command_keys): Remove decl.
1637 (Fcommand_execute): New forward static decl.
1638 * keymap.c (Flookup_key): New forward static decl.
1639 (Fcopy_keymap): Now static.
1640 * keymap.h (Flookup_key): Remove decl.
1641 * process.c (Fget_process): New forward static decl.
1642 (Fprocess_datagram_address): Mark as internal.
1643 * syntax.c (Fsyntax_table_p): New forward static decl.
1644 (skip_chars): Remove duplicate decl.
1645 * textprop.c (Fprevious_property_change): New forward static decl.
1646 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1647 Now internal.
1648 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1649 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1650
785bbd42
PE
1651 * editfns.c (Fformat): Remove unreachable code.
1652
8b913b57
AS
16532011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1654
1655 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1656 change. (Bug#8496)
1657
a6744a35
EZ
16582011-04-13 Eli Zaretskii <eliz@gnu.org>
1659
1660 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1661 when at ZV. (Bug#8487)
1662
e7974947
AS
16632011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1664
baad03f0
AS
1665 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1666 (Bug#8437)
1667 * keyboard.c (parse_tool_bar_item): Likewise.
1668 * sound.c (sound_cleanup, alsa_close): Likewise.
1669 * termcap.c (tgetent): Likewise.
1670 * xfns.c (x_default_font_parameter): Likewise.
1671 * xsettings.c (read_and_apply_settings): Likewise.
1672
e7974947
AS
1673 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1674 (overrun_check_free): Protoize.
1675
28272684
PE
16762011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1679 since callers should never pass a negative size.
1680 Change the signature to match that of plain 'read' and 'write'; see
1681 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1682 * lisp.h: Update prototypes of emacs_write and emacs_read.
1683
11997c76
EZ
16842011-04-11 Eli Zaretskii <eliz@gnu.org>
1685
1686 * xdisp.c (redisplay_window): Don't try to determine the character
1687 position of the scroll margin if the window start point w->startp
e896f03c 1688 is outside the buffer's accessible region. (Bug#8468)
11997c76 1689
8a2cbd72
EZ
16902011-04-10 Eli Zaretskii <eliz@gnu.org>
1691
1692 Fix write-region and its subroutines for buffers > 2GB.
1693 * fileio.c (a_write, e_write): Modify declaration of arguments and
1694 local variables to support buffers larger than 2GB.
1695 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1696
1697 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1698 argument, local variables, and return value.
1699
1700 * lisp.h: Update prototypes of emacs_write and emacs_read.
1701
1702 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1703
4073e537 17042011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1705
1ebfdcb6
PE
1706 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1707
b2ded58d
PE
1708 Fix more problems found by GCC 4.6.0's static checks.
1709
7d66342c
PE
1710 * xdisp.c (vmessage): Use a better test for character truncation.
1711
bbf47d44
PE
1712 * charset.c (load_charset_map): <, not <=, for optimization,
1713 and to avoid potential problems with integer overflow.
9248994d 1714 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1715 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1716 * editfns.c (Fformat): Likewise.
1e69125e 1717 * syntax.c (skip_chars): Likewise.
3befa583 1718
e3019616
PE
1719 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1720 This also lets GCC 4.6.0 generate slightly better loop code.
1721
becfa255
PE
1722 * callint.c (Fcall_interactively): <, not <=, for optimization.
1723 (Fcall_interactively): Count the number of arguments produced,
1724 not the number of arguments given. This is simpler and lets GCC
1725 4.6.0 generate slightly better code.
1726
dae0cd48
PE
1727 * ftfont.c: Distingish more carefully between FcChar8 and char.
1728 The previous code passed unsigned char * to a functions like
1729 strlen and xstrcasecmp that expect char *, which does not
1730 conform to the C standard.
1731 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1732 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1733 char * when the C standard requires it.
1734
76032d70
PE
1735 * keyboard.c (read_char): Remove unused var.
1736
eb3f1cc8
PE
1737 * eval.c: Port to Windows vsnprintf (Bug#8435).
1738 Include <limits.h>.
1739 (SIZE_MAX): Define if the headers do not.
1740 (verror): Do not give up if vsnprintf returns a negative count.
1741 Instead, grow the buffer. This ports to Windows vsnprintf, which
1742 does not conform to C99. Problem reported by Eli Zaretskii.
1743 Also, simplify the allocation scheme, by avoiding the need for
1744 calling realloc, and removing the ALLOCATED variable.
1745
70476b54
PE
1746 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1747
12020a9e
PE
1748 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1749 But keep the doprint source code for now, as we might revamp it
1750 and use it again (Bug#8435).
ea6c7ae6
PE
1751 * lisp.h (doprnt): Remove.
1752 * Makefile.in (base_obj): Remove doprnt.o.
1753 * deps.mk (doprnt.o): Remove.
1754
5fdb398c
PE
1755 error: Print 32- and 64-bit integers portably (Bug#8435).
1756 Without this change, on typical 64-bit hosts error ("...%d...", N)
1757 was used to print both 32- and 64-bit integers N, which relied on
1758 undefined behavior.
1759 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1760 New macro.
1761 * lisp.h (error, verror): Mark as printf-like functions.
1762 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1763 Report overflow in size calculations when allocating printf buffer.
1764 Do not truncate output string at its first null byte.
1765 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1766 Truncate the output at a character boundary, since vsnprintf does not
1767 do that.
1768 * charset.c (check_iso_charset_parameter): Convert internal
1769 character to string before calling 'error', since %c now has the
1770 printf meaning.
1771 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1772 overflow when computing char to be passed to 'error'. Do not
1773 pass Lisp_Object to 'error'; pass the integer instead.
1774 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1775 formatted with plain %d.
1776
b189fa66
PE
1777 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1778
bff87ef0
PE
1779 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1780
7e2cac20
PE
1781 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1782
ce4d90b5
PE
1783 * xterm.c (x_catch_errors): Remove duplicate declaration.
1784
266c9547
PE
1785 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1786
79c49ad2
PE
1787 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1788
368f4090
JM
17892011-04-10 Jim Meyering <meyering@redhat.com>
1790
1791 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1792 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1793 return ssize_t not "int", and use size_t as the buffer length.
1794 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1795 * gnutls.h: Update declarations.
1796 * process.c (read_process_output): Use ssize_t, to match.
1797 (send_process): Likewise.
1798
a32d4040
CY
17992011-04-09 Chong Yidong <cyd@stupidchicken.com>
1800
1801 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1802
8546720e 18032011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1804
04f2d78b
CB
1805 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1806 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1807
8546720e
GM
1808 * xterm.c (handle_one_xevent):
1809 * xmenu.c (create_and_show_popup_menu):
1810 * xselect.c (x_decline_selection_request)
1811 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1812
0a2f5c1a 18132011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1814
1815 Fix some uses of `int' instead of EMACS_INT.
1816 * search.c (string_match_1, fast_string_match)
1817 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1818 (scan_buffer, find_next_newline_no_quit)
1819 (find_before_next_newline, search_command, Freplace_match)
1820 (Fmatch_data): Make some `int' variables be EMACS_INT.
1821
1822 * xdisp.c (display_count_lines): 3rd argument and return value now
1823 EMACS_INT. All callers changed.
1824 (pint2hrstr): Last argument is now EMACS_INT.
1825
1826 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1827 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1828 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1829 (decode_coding_utf_16, decode_coding_emacs_mule)
1830 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1831 (decode_coding_ccl, decode_coding_charset)
1832 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1833 (decode_coding_iso_2022, decode_coding_emacs_mule)
1834 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1835 <char_offset, last_offset>: Declare EMACS_INT.
1836 (encode_coding_utf_8, encode_coding_utf_16)
1837 (encode_coding_emacs_mule, encode_invocation_designation)
1838 (encode_designation_at_bol, encode_coding_iso_2022)
1839 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1840 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1841 Declare EMACS_INT.
1842 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1843 (encode_invocation_designation): Last argument P_NCHARS is now
1844 EMACS_INT.
1845 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1846 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1847
1848 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1849 All users changed.
1850
1851 * ccl.c (Fccl_execute_on_string): Declare some variables
1852 EMACS_INT.
1853
8546720e 18542011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1855
1856 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1857
4e19a977
CS
18582011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1859
1860 * process.c (Fformat_network_address): Doc fix.
1861
87302331
R
18622011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1863
1864 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1865
cbb59342
CY
18662011-04-08 Chong Yidong <cyd@stupidchicken.com>
1867
1868 * keyboard.c (read_char): Call Lisp function help-form-show,
1869 instead of using internal_with_output_to_temp_buffer.
1870 (Qhelp_form_show): New var.
e0d38eeb 1871 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1872
1873 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1874
1875 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1876
e67a13ab
CY
18772011-04-06 Chong Yidong <cyd@stupidchicken.com>
1878
04f2d78b
CB
1879 * process.c (Flist_processes): Remove to Lisp.
1880 (list_processes_1): Delete.
e67a13ab 1881
973f782d
EZ
18822011-04-06 Eli Zaretskii <eliz@gnu.org>
1883
7c106b1e
EZ
1884 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1885
973f782d
EZ
1886 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1887
41cf7d1a 18882011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1889
ca23cc88
PE
1890 Fix more problems found by GCC 4.6.0's static checks.
1891
f390e2d5
PE
1892 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1893
42eea0d0
PE
1894 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1895
b69769da 1896 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1897
f9541e84
PE
1898 * xdisp.c (vmessage): Mark as a printf-like function.
1899
13841b55
PE
1900 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1901
c136c10f
PE
1902 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1903
5e2d4a30
PE
1904 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1905 printf-like functions.
1906 (tiff_load): Add casts to remove these marks before passing them
1907 to system-supplied API.
1908
583f48b9
PE
1909 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1910
b25d760e
PE
1911 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1912 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1913 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1914 directly, rather than having caller test rule sign. This avoids
1915 some unnecessary tests.
1916 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1917 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1918 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1919
bc7b6697 1920 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1921 (xfont_open): Avoid unnecessary tests.
bc7b6697 1922
27ccc379
PE
1923 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1924
dcd5c89a
PE
1925 * composite.h, composite.c (composition_gstring_put_cache):
1926 Use EMACS_INT, not int, for length.
1927
b13a45c6
PE
1928 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1929 breaking out part of COMPOSITION_DECODE_RULE.
1930 (COMPOSITION_DECODE_RULE): Use it.
1931 * composite.c (get_composition_id): Remove unused local vars,
1932 by using the new macro.
1933
1e792e4d
PE
1934 * textprop.c (set_text_properties_1): Change while to do-while,
1935 since the condition is always true at first.
1936
dc6c6455 1937 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1938 (interval_deletion_adjustment): Return unsigned value.
1939 All uses changed.
dc6c6455 1940
aba7731a
PE
1941 * process.c (list_processes_1, create_pty, read_process_output):
1942 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1943 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1944 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1945 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1946 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1947
fdfc4bf3
PE
1948 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1949
fca8fe46 1950 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1951 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1952
06a0259a 1953 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1954 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1955 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1956
e7b9e80f
PE
1957 * print.c (print_error_message): Avoid int overflow.
1958
56201685
PE
1959 * font.c (font_list_entities): Redo for clarity,
1960 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1961
78834453 1962 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1963 (font_score): Avoid potential overflow in diff calculation.
78834453 1964
0bc0b309 1965 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1966 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1967
e610eaca
PE
1968 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1969
b895abce
PE
1970 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1971 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1972 can always succeed if overflow has undefined behavior.
1973
1f1d9321 1974 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1975 (wordify): Omit three unnecessary tests.
1f1d9321 1976
c59478bc
PE
1977 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1978 All callers changed. This avoids the need for an unused var.
1979
79b73827
PE
1980 * casefiddle.c (casify_region): Remove var that is set but not used.
1981
a4db5dfe
PE
1982 * dired.c (file_name_completion): Remove var that is set but not used.
1983
43aae36e
PE
1984 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1985
2a47c44d 1986 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1987 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1988
a37c69bf
PE
1989 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1990 Check for integer overflow on size calculations.
1991
328ab8e7
PE
1992 * buffer.c (Fprevious_overlay_change): Remove var that is set
1993 but not used.
1994
e5a2a5cb
PE
1995 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1996 Remove vars that are set but not used.
8d84a6eb 1997 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1998 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1999
a60e5f68
PE
2000 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2001
f661cb61 2002 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2003 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2004
f0397f5a
PE
2005 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2006 that are set but not used.
2007
8664db06 2008 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2009 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2010
6abdaa4a
PE
2011 * xselect.c (x_get_local_selection, x_handle_property_notify):
2012 Remove vars that are set but not used.
2013
0ce7538d 2014 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2015 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2016
9ae848fc
PE
2017 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2018 Remove var that is set but not used.
0b918413
PE
2019 (scroll_bar_windows_size): Now size_t, not int.
2020 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2021 Check for overflow.
9ae848fc 2022
a5a62657
PE
2023 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2024 (map_tty_color) [!defined MSDOS]: Likewise.
2025
5c5cdd39
PE
2026 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2027
66ebf983
PE
2028 * coding.c: Remove vars that are set but not used.
2029 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2030 All callers changed.
2031 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2032 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2033 (decode_coding_charset): Remove vars that are set but not used.
2034
1be4d761
PE
2035 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2036 that is set but not used.
2037
47553fa8
PE
2038 * print.c (print_object): Remove var that is set but not used.
2039
1f7196bf 2040 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2041 The gnulib version avoids calling malloc in the usual case,
2042 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2043 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2044 * filelock.c (current_lock_owner): Likewise.
2045 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2046 * sysdep.c: Include allocator.h, careadlinkat.h.
2047 (emacs_no_realloc_allocator): New static constant.
2048 (emacs_readlink): New function.
fdb61804
PE
2049 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2050 ../lib/careadlinkat.h.
d1fdcab7 2051
f84c17c7
SM
20522011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2053
2054 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2055 first non-nil return value).
2056
ef3862ad
JD
20572011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2058
2059 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2060 if not defined (Bug#8403).
2061
376a7006
JB
20622011-04-02 Juanma Barranquero <lekktu@gmail.com>
2063
2064 * xdisp.c (display_count_lines): Remove parameter `start',
2065 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2066 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2067 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2068 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2069 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2070 and thereabouts. All callers changed.
2071 (get_per_char_metric): Remove parameter `f', unused since
2072 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2073
6ca3801d
JM
20742011-04-02 Jim Meyering <meyering@redhat.com>
2075
2076 do not dereference NULL upon failed strdup
2077 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2078 (ns_get_family): Likewise.
2079
d8e2b5ba
JB
20802011-04-02 Juanma Barranquero <lekktu@gmail.com>
2081
2082 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2083
8c74fcbd
JD
20842011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2085
2086 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2087 later (Bug#8403).
2088
7200d79c
SM
20892011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2090
03408648 2091 Add lexical binding.
7200d79c 2092
03408648
SM
2093 * window.c (Ftemp_output_buffer_show): New fun.
2094 (Fsave_window_excursion):
2095 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2096
2097 * lread.c (lisp_file_lexically_bound_p): New function.
2098 (Fload): Bind Qlexical_binding.
2099 (readevalloop): Remove `evalfun' arg.
2100 Bind Qinternal_interpreter_environment.
2101 (Feval_buffer): Bind Qlexical_binding.
2102 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2103 Mark as dynamic.
2104 (syms_of_lread): Declare `lexical-binding'.
2105
2106 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2107
2108 * keyboard.c (eval_dyn): New fun.
2109 (menu_item_eval_property): Use it.
ca105506
SM
2110
2111 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2112
03408648
SM
2113 * fns.c (concat, mapcar1): Accept byte-code-functions.
2114
2115 * eval.c (Fsetq): Handle lexical vars.
2116 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2117 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2118 (FletX, Flet): Obey lexical binding.
2119 (Fcommandp): Handle closures.
2120 (Feval): New `lexical' arg.
2121 (eval_sub): New function extracted from Feval. Use it almost
2122 everywhere where Feval was used. Look up vars in lexical env.
2123 Handle closures.
2124 (Ffunctionp): Move from subr.el.
2125 (Ffuncall): Handle closures.
2126 (apply_lambda): Remove `eval_flags'.
2127 (funcall_lambda): Handle closures and new byte-code-functions.
2128 (Fspecial_variable_p): New function.
2129 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2130 but without exporting it to Lisp.
23aba0ea 2131
23aba0ea 2132 * doc.c (Fdocumentation, store_function_docstring):
03408648 2133 * data.c (Finteractive_form): Handle closures.
23aba0ea 2134
03408648
SM
2135 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2136 interactive spec.
ba83908c 2137
04f2d78b
CB
2138 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2139 New byte-codes.
03408648
SM
2140 (exec_byte_code): New function extracted from Fbyte_code to handle new
2141 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2142
03408648 2143 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2144
03408648 2145 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2146
e2abce01
JB
21472011-03-31 Juanma Barranquero <lekktu@gmail.com>
2148
2149 * xdisp.c (redisplay_internal): Fix prototype.
2150
63696a73 21512011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2152
63696a73 2153 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2154 (try_scrolling): Use it when setting scroll_limit.
2155 Limit scrolling to 100 screen lines.
63696a73
EZ
2156 (redisplay_window): Even when falling back on "recentering",
2157 position point in the window according to scroll-conservatively,
2158 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2159
2160 (try_scrolling): When point is above the window, allow searching
2161 as far as scroll_max, or one screenful, to compute vertical
2162 distance from PT to the scroll margin position. This prevents
2163 try_scrolling from unnecessarily failing when
2164 scroll-conservatively is set to a value slightly larger than the
2165 window height. Clean up the case of PT below the margin at bottom
2166 of window: scroll_max can no longer be INT_MAX. When aggressive
2167 scrolling is in use, don't let point enter the opposite scroll
2168 margin as result of the scroll.
2169 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2170 threshold of 100 lines for never-recentering scrolling.
2171
e4cc2dfc
JB
21722011-03-31 Juanma Barranquero <lekktu@gmail.com>
2173
2174 * dispextern.h (move_it_by_lines):
2175 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2176 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2177 (message_log_check_duplicate): Remove parameters `prev_bol' and
2178 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2179 (redisplay_internal): Remove parameter `preserve_echo_area',
2180 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2181
2182 * indent.c (Fvertical_motion):
2183 * window.c (window_scroll_pixel_based, Frecenter):
2184 Don't pass `need_y_p' to `move_it_by_lines'.
2185
1c470562
SM
21862011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2187
44f230aa
SM
2188 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2189 steal a few bits to be more compact.
2190 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2191 Remove unneeded casts.
2192
1c470562
SM
2193 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2194
888adce9
ZK
21952011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2196
2197 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2198 binding" message (bug#7967).
2199
f838ed7b
PE
22002011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2201
77861b95
PE
2202 Fix more problems found by GCC 4.6.0's static checks.
2203
de6dbc14
PE
2204 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2205 Remove unused local var.
2206
f838ed7b
PE
2207 * editfns.c (Fmessage_box): Remove unused local var.
2208
792c7b2b
PE
2209 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2210 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2211 Omit unused local vars.
c499e557 2212 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2213 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2214 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2215 Omit unused local var.
2216
ba0165e1
PE
2217 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2218 Don't assume string length fits in int.
32ad8845 2219 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2220 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2221
3c59b4c9
PE
2222 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2223 instead of alloca (Bug#8344).
2224
a3eed478 2225 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2226 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2227
eb4d412d
PE
2228 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2229
1658b401
PE
2230 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2231 concerns.
2232
2233 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2234
2235 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2236
9a2c6e05
PE
2237 * keyboard.c (syms_of_keyboard): Use the same style as later
2238 in this function when indexing through an array. This also
2239 works around GCC bug 48267.
2240
03d0a109
PE
2241 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2242
44f730c8
PE
2243 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2244
fe75f926
PE
2245 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2246 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2247
ffa8c828
PE
2248 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2249 This avoids undefined behavior on integer overflow, and is a bit
2250 more convenient anyway since it is compared to a size_t variable.
2251
c5101a77
PE
2252 Variadic C functions now count arguments with size_t, not int.
2253 This avoids an unnecessary limitation on 64-bit machines, which
2254 caused (substring ...) to crash on large vectors (Bug#8344).
2255 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2256 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2257 All variadic functions and their callers changed accordingly.
c5101a77
PE
2258 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2259 * data.c (arith_driver, float_arith_driver): Likewise.
2260 * editfns.c (general_insert_function): Likewise.
2261 * eval.c (struct backtrace.nargs, interactive_p)
2262 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2263 (funcall_lambda, mark_backtrace): Likewise.
2264 * fns.c (concat): Likewise.
2265 * frame.c (x_set_frame_parameters): Likewise.
2266 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2267 0 if not found, not -1. All callers changed.
2268
dd3f25f7
PE
2269 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2270 (stack_copy_size): Now size_t, not int.
2271 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2272
461c2ab9
JB
22732011-03-28 Juanma Barranquero <lekktu@gmail.com>
2274
2275 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2276 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2277 All callers changed.
2278
2279 * lisp.h (multibyte_char_to_unibyte):
2280 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2281 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2282 * character.h (CHAR_TO_BYTE8):
2283 * cmds.c (internal_self_insert):
2284 * editfns.c (general_insert_function):
2285 * keymap.c (push_key_description):
2286 * search.c (Freplace_match):
2287 * xdisp.c (message_dolog, set_message_1): All callers changed.
2288
f6d62986
SM
22892011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2290
2291 * keyboard.c (safe_run_hook_funcall): New function.
2292 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2293 don't set the hook to nil, but remove the offending function instead.
2294 (Qcommand_hook_internal): Remove, unused.
2295 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2296 Vcommand_hook_internal.
2297
2298 * eval.c (enum run_hooks_condition): Remove.
2299 (funcall_nil, funcall_not): New functions.
2300 (run_hook_with_args): Call each function through a `funcall' argument.
2301 Remove `cond' argument, now redundant.
2302 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2303 (Frun_hook_with_args_until_failure): Adjust accordingly.
2304 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2305
1db5b1ad
JB
23062011-03-28 Juanma Barranquero <lekktu@gmail.com>
2307
2308 * dispextern.h (string_buffer_position): Remove declaration.
2309
2310 * print.c (strout): Remove parameter `multibyte', unused since
2311 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2312
2313 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2314 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2315 All callers changed.
2316
2317 * w32.c (_wsa_errlist): Use braces for struct initializers.
2318
2319 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2320 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2321 All callers changed.
2322 (string_buffer_position): Likewise. Also, make static (it's never
2323 used outside xdisp.c).
2324 (cursor_row_p): Remove parameter `w', unused since
2325 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2326 (decode_mode_spec): Remove parameter `precision', introduced during
2327 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2328 All callers changed.
2329
5ffb62aa
JD
23302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2331
2332 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2333
461c2ab9 23342011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2335
2336 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2337 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2338 (ns_update_auto_hide_menu_bar): New functions.
2339 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2340 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2341 ns_constrain_all_frames.
2342 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2343 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2344
5c380ffb
JD
23452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2346
2347 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2348
9af30bdf
GM
23492011-03-27 Glenn Morris <rgm@gnu.org>
2350
2351 * syssignal.h: Replace RETSIGTYPE with void.
2352 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2353 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2354 Replace SIGTYPE with void everywhere.
2355 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2356 * s/template.h (SIGTYPE): Remove commented out definition.
2357
e2abce01
JB
23582011-03-26 Eli Zaretskii <eliz@gnu.org>
2359
2360 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2361 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2362
f868cd8a
JB
23632011-03-26 Juanma Barranquero <lekktu@gmail.com>
2364
59eb0929
JB
2365 * w32.c (read_unc_volume): Use parameter `henum', instead of
2366 global variable `wget_enum_handle'.
2367
2368 * keymap.c (describe_vector): Remove parameters `indices' and
2369 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2370 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2371
f868cd8a
JB
2372 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2373
2374 * keyboard.c (timer_check): Remove parameter `do_it_now',
2375 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2376 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2377 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2378
2379 * keyboard.c (read_char):
2380 * w32menu.c (w32_menu_display_help):
2381 * xmenu.c (show_help_event, menu_help_callback):
2382 Adjust calls to `show_help_echo'.
2383
2384 * gtkutil.c (xg_maybe_add_timer):
2385 * keyboard.c (readable_events):
2386 * process.c (wait_reading_process_output):
2387 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2388
2389 * insdel.c (adjust_markers_gap_motion):
2390 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2391 (gap_left, gap_right): Don't call it.
2392
2ecf6fdb
CY
23932011-03-25 Chong Yidong <cyd@stupidchicken.com>
2394
2395 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2396 incurred during fontification.
2397
6b1f9ba4
JB
23982011-03-25 Juanma Barranquero <lekktu@gmail.com>
2399
2400 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2401 (DEFVAR_PER_BUFFER): Don't pass it.
2402
2403 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2404 (scrolling_window): Don't pass it.
2405
0f4a96b5
JB
24062011-03-25 Juanma Barranquero <lekktu@gmail.com>
2407
2408 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2409
2410 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2411 and `suffix'.
2412 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2413 of variables specific to SELinux and computation of `encoded_absname'.
2414
2415 * image.c (XPutPixel): Remove unused variable `height'.
2416
2417 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2418
2419 * unexw32.c (get_section_info): Remove unused variable `section'.
2420
2421 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2422 (system_process_attributes): Remove unused variable `sess'.
2423 (sys_read): Remove unused variable `err'.
2424
2425 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2426 (w32_wnd_proc): Remove unused variable `isdead'.
2427 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2428 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2429 (x_create_tip_frame): Remove unused variable `tem'.
2430
2431 * w32inevt.c (w32_console_read_socket):
2432 Remove unused variable `no_events'.
2433
2434 * w32term.c (x_draw_composite_glyph_string_foreground):
2435 Remove unused variable `width'.
2436
1149507c
JB
24372011-03-24 Juanma Barranquero <lekktu@gmail.com>
2438
2439 * w32term.c (x_set_glyph_string_clipping):
2440 Don't pass uninitialized region to CombineRgn.
2441
9c88f339
JB
24422011-03-23 Juanma Barranquero <lekktu@gmail.com>
2443
2444 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2445 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2446 (Fx_close_connection): Remove unused variable `i'.
2447
2448 * w32font.c (w32font_draw): Return number of glyphs.
2449 (w32font_open_internal): Remove unused variable `i'.
2450 (w32font_driver): Add missing initializer.
2451
2452 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2453 (fill_in_menu): Remove unused variable `items_added'.
2454
2455 * w32term.c (last_mouse_press_frame): Remove static global variable.
2456 (w32_clip_to_row): Remove unused variable `f'.
2457 (x_delete_terminal): Remove unused variable `i'.
2458
2459 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2460 (NOTHING): Remove unused static global variable.
2461 (uniscribe_check_otf): Remove unused variable `table'.
2462 (uniscribe_font_driver): Add missing initializers.
2463
dee091a3
JD
24642011-03-23 Julien Danjou <julien@danjou.info>
2465
2466 * term.c (Fsuspend_tty, Fresume_tty):
2467 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2468 * window.c (temp_output_buffer_show):
2469 * insdel.c (signal_before_change):
2470 * frame.c (Fhandle_switch_frame):
2471 * fileio.c (Fdo_auto_save):
2472 * emacs.c (Fkill_emacs):
2473 * editfns.c (save_excursion_restore):
2474 * cmds.c (internal_self_insert):
2475 * callint.c (Fcall_interactively):
2476 * buffer.c (Fkill_all_local_variables):
2477 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2478 Use Frun_hooks.
0f4a96b5 2479 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2480 unconditionnaly since it does the check itself.
2481
2c520ab5 24822011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2483
c9c49752
PE
2484 Fix more problems found by GCC 4.5.2's static checks.
2485
8abc3f12
PE
2486 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2487 the first time through the loop, since we know p0 < p1 then.
2488 This also avoids a gcc -Wstrict-overflow warning.
2489
a2d26660
PE
2490 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2491 leading to a memory leak, possible in functions like
2492 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2493 of objects (Bug#8318).
a2d26660 2494
916c72e9
PE
2495 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2496 that could (at least in theory) be that large.
2497
19ab8a18
PE
2498 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2499 This is less likely to overflow, and avoids undefined behavior if
2500 overflow does occur. All callers changed. Use strtoul to scan
2501 for the unsigned long integer.
b7cbbd6f
PE
2502 (pint2hrstr): Simplify and tune code slightly.
2503 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2504
f0641eff
PE
2505 * scroll.c (do_scrolling): Work around GCC bug 48228.
2506 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2507
7f650bb9
PE
2508 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2509 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2510 (validate_x_resource_name): Simplify count usage.
2511 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2512
37dd57d1
PE
2513 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2514 fail (Bug#8306).
81e56e61 2515
699979fc 2516 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2517
401bf9b4
PE
2518 * process.c (Fmake_network_process): Use socklen_t, not int,
2519 where POSIX says socklen_t is required in portable programs.
2520 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2521 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2522 (Fmake_network_process, server_accept_connection):
2523 (wait_reading_process_output, read_process_output):
2524 Likewise.
2525
b93aacde
PE
2526 * process.c: Rename or move locals to avoid shadowing.
2527 (list_processes_1, Fmake_network_process):
2528 (read_process_output_error_handler, exec_sentinel_error_handler):
2529 Rename or move locals.
4dc343ee 2530 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2531 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2532 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2533 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2534 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2535
af8a867c 2536 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2537 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2538 Include tparam.h instead, since it declares them.
af8a867c
PE
2539 * cm.h (PC): Remove extern decl; tparam.h now does this.
2540 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2541 * terminfo.c: Include tparam.h, to check interfaces.
2542 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2543 (tparam): Adjust signature to match interface in tparam.h;
2544 this removes some undefined behavior. Check that outstring and len
2545 are zero, which they always are with Emacs.
2546 * tparam.h (PC, BC, UP): New extern decls.
2547
0248044d 2548 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2549 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2550
8ff096c1 2551 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2552 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2553 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2554 (ftfont_list): Remove unused local.
49eaafba
PE
2555 (get_adstyle_property, ftfont_pattern_entity):
2556 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2557 Rename locals to avoid shadowing.
8ff096c1 2558
e2be39f6
PE
2559 * xfont.c (xfont_list_family): Mark var as initialized.
2560
c9735e30
PE
2561 * xml.c (make_dom): Now static.
2562
8f5201ae
PE
2563 * composite.c (composition_compute_stop_pos): Rename local to
2564 avoid shadowing.
b246f932
PE
2565 (composition_reseat_it): Remove unused locals.
2566 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2567 (composition_update_it): Mark var as initialized.
11b61122
PE
2568 (find_automatic_composition): Mark vars as initialized,
2569 with a FIXME (Bug#8290).
8f5201ae 2570
760fbc2c
PE
2571 character.h: Rename locals to avoid shadowing.
2572 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2573 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2574 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2575 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2576 to avoid shadowing.
2577
ff08eb85
PE
2578 * textprop.c (property_change_between_p): Remove; unused.
2579
fc7bf025
PE
2580 * intervals.c (interval_start_pos): Now static.
2581
235d7abc
PE
2582 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2583
44f230aa
SM
2584 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2585 Rename locals to avoid shadowing.
3e7d6594 2586
50060332
PE
2587 * sound.c (wav_play, au_play, Fplay_sound_internal):
2588 Fix pointer signedness.
d01f234b 2589 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2590 (wav_play): Initialize a variable to 0, to prevent undefined
2591 behavior (Bug#8278).
50060332 2592
c4fc4e30
PE
2593 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2594
918436ed
PE
2595 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2596
c939f91b
PE
2597 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2598 clobbering (Bug#8298).
b9c7f648
PE
2599 * sysdep.c (sys_subshell): Likewise.
2600 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2601
6bd8c144
PE
2602 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2603 This should get cleaned up, so that child_setup has the
2604 same signature on all platforms.
2605
7710357c 2606 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2607 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2608
c59da222
CY
26092011-03-22 Chong Yidong <cyd@stupidchicken.com>
2610
2611 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2612 not to be necessary, and produces flickering.
2613
66b87493
GM
26142011-03-20 Glenn Morris <rgm@gnu.org>
2615
2616 * config.in: Remove file.
2617
45b6f6d5
JB
26182011-03-20 Juanma Barranquero <lekktu@gmail.com>
2619
2620 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2621 are now in src/globals.h.
2622 (syms_of_minibuf): Remove spurious & from previous change.
2623
3ec03f7e
LL
26242011-03-20 Leo <sdl.web@gmail.com>
2625
2626 * minibuf.c (completing-read-function): New variable.
2627 (completing-read-default): Rename from completing-read.
2628 (completing-read): Call completing-read-function.
2629
b14e3e21
CY
26302011-03-19 Juanma Barranquero <lekktu@gmail.com>
2631
2632 * xfaces.c (Fx_load_color_file):
2633 Read color file from absolute filename (bug#8250).
2634
f2b726e6
JB
26352011-03-19 Juanma Barranquero <lekktu@gmail.com>
2636
2637 * makefile.w32-in: Update dependencies.
2638
09f6ff02
EZ
26392011-03-17 Eli Zaretskii <eliz@gnu.org>
2640
2641 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2642
29a6015a
PE
26432011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2644
a3a6c54e
PE
2645 Fix more problems found by GCC 4.5.2's static checks.
2646
b766f867
PE
2647 * process.c (make_serial_process_unwind, send_process_trap):
2648 (sigchld_handler): Now static.
2649
be02381c
PE
2650 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2651 That way, the code declares only the vars that it needs.
2652 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2653 * s/cygwin.h (PTY_ITERATION): Likewise.
2654 * s/darwin.h (PTY_ITERATION): Likewise.
2655 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2656
57048744
PE
2657 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2658 * process.c (allocate_pty): Don't declare stb unless it's needed.
2659
7914961c 2660 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2661 (CONSTANTLIM): Remove; unused.
2662 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2663 Define only if needed.
7914961c 2664
b3967b18
PE
2665 * unexelf.c (unexec): Name an expression,
2666 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2667 Use a different way to cause a compilation error if anyone uses
2668 n rather than nn, a way that does not involve shadowing.
73366a00 2669 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2670
29a6015a
PE
2671 * deps.mk (unexalpha.o): Remove; unused.
2672
43cfc33e 2673 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2674 * unexec.h: New file.
ce701a33
PE
2675 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2676 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2677 Depend on unexec.h.
2678 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2679 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2680 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2681 Change as necessary to match prototype in unexec.h.
ce701a33 2682
01f44d5a
PE
2683 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2684 shadowing.
4f63c6bb 2685 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2686
a6670b0b
PE
2687 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2688 Rename locals to avoid shadowing.
2689
cef2010d 2690 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2691 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2692
d4d7173a
PE
2693 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2694
f08b802a
PE
2695 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2696 warning when compiling print.c.
2697
3ddb0639
PE
2698 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2699 instead of using an uninitialized var.
5ad03b97 2700 (font_sort_entities): Mark var as initialized.
3ddb0639 2701
170a2692
PE
2702 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2703
e663c700
PE
2704 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2705 pointers to constants.
89bc529a 2706 (font_parse_fcname): Remove unused vars.
7b81e2d0 2707 (font_delete_unmatched): Now static.
ea838e10 2708 (font_get_spec): Remove; unused.
13a547c6
PE
2709 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2710 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2711 Rename or move locals to avoid shadowing.
e663c700 2712
2a80c887 2713 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2714 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2715
1384fa33 2716 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2717 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2718
8b2c52e9
PE
2719 * alloc.c (mark_backtrace): Move decl from here ...
2720 * lisp.h: ... to here, so that it can be checked.
2721
475545b5 2722 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2723 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2724 (lisp_indirect_variable): Name an expression,
2725 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2726 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2727
b1349114 2728 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2729 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2730 Use const pointer when appropriate.
b1349114 2731
a2928364
PE
2732 * lisp.h (get_system_name, get_operating_system_release):
2733 Move decls here, to check interfaces.
2734 * process.c (get_operating_system_release): Move decl to lisp.h.
2735 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2736 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2737 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2738 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2739 (Fformat_time_string, Fencode_time, Finsert_char):
2740 (Ftranslate_region_internal, Fformat):
2741 Rename or remove local vars to avoid shadowing.
9710023e 2742 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2743
a415e694
PE
2744 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2745 avoid shadowing.
2746
8ef4622d
PE
2747 * lisp.h (eassert): Check that the argument compiles, even if
2748 ENABLE_CHECKING is not defined.
2749
946f9a5b
PE
2750 * data.c (Findirect_variable): Name an expression, to avoid
2751 gcc -Wbad-function-cast warning.
112396d6 2752 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2753 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2754 (Fmake_variable_buffer_local, Fmake_local_variable):
2755 Mark variables as initialized.
52746918 2756 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2757
e5aab7e7 2758 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2759 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2760 Rename locals to avoid shadowing.
dff45157
PE
2761 (mark_stack): Move local variables into the #ifdef region where
2762 they're used.
7bc26fdb
PE
2763 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2764 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2765 needed otherwise.
2766 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2767 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2768 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2769
e5aab7e7
PE
2770 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2771 avoids undefined behavior in theory.
2772
4da60324
PE
2773 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2774
88043301
PE
2775 Use functions, not macros, for up- and down-casing (Bug#8254).
2776 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2777 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2778 to use the following functions instead of these macros.
2779 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2780 EMACS_INT, since callers assume the returned value fits in int.
2781 (upcase1): Likewise, for UPCASE_TABLE.
2782 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2783 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2784 the race-condition problem in the old DOWNCASE.
88043301 2785
19ed5445
PE
2786 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2787 Rename locals to avoid shadowing.
2788 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2789 (regex_compile, re_search_2, re_match_2_internal):
2790 Remove unused local vars.
952db0d7
PE
2791 (FREE_VAR): Rewrite so as not to use empty "else",
2792 which gcc can warn about.
da053e48 2793 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2794 (RETALLOC_IF): Define only if needed.
2795 (WORDCHAR_P): Likewise. This one is never needed, but is used
2796 only in a comment talking about a compiler bug, so put inside
2797 the #if 0 of that comment.
2798 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2799 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2800 Remove; unused.
19ed5445 2801
1f3561e4 2802 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2803 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2804 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2805
ded6f8f7
PE
2806 * search.c (simple_search): Remove unused var.
2807
dbd37a95
PE
2808 * dired.c (compile_pattern): Move decl from here ...
2809 * lisp.h: ... to here, so that it can be checked.
2810 (struct re_registers): New forward decl.
2811
7e47afad
PE
2812 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2813
85f24f61
PE
2814 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2815 All uses changed.
2816 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2817 Rename locals to avoid shadowing.
5671df8f 2818 (Fvertical_motion): Mark locals as initialized.
85f24f61 2819
181aa2be 2820 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2821 (casify_region): Mark local as initialized.
181aa2be 2822
930d429c
PE
2823 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2824
7082eac6
PE
2825 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2826 New macros, so that the caller can use some names other than
2827 gcpro1, gcpro2, etc.
2828 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2829 of the new macros.
2830 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2831 argument, for consistency with GCPRO2_VAR, etc: it is now the
2832 prefix of the variable, not the variable itself. All uses
2833 changed.
38b2c076
PE
2834 * dired.c (directory_files_internal, file_name_completion):
2835 Rename locals to avoid shadowing.
2836
15206ed9
PE
2837 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2838 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2839 dired.c's scmp function, had undefined behavior.
2840 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2841 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2842 * buffer.h: ... to here, because these macros use current_buffer,
2843 and the new implementation with inline functions needs to have
2844 current_buffer in scope now, rather than later when the macros
2845 are used.
2846 (downcase, upcase1): New static inline functions.
2847 (DOWNCASE, UPCASE1): Reimplement using these functions.
2848 This avoids undefined behavior in expressions like
2849 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2850 from race conditions in accessing the global variables
2851 case_temp1 and case_temp2.
2852 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2853 * lisp.h (case_temp1, case_temp2): Remove their decls.
2854 * character.h (ASCII_CHAR_P): Move from here ...
2855 * lisp.h: ... to here, so that the inline functions mentioned
2856 above can use them.
2857
4a6bea26
PE
2858 * dired.c (directory_files_internal_unwind): Now static.
2859
f14b7e14
PE
2860 * fileio.c (file_name_as_directory, directory_file_name):
2861 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2862 Now static.
2893f146
PE
2863 (file_name_as_directory): Use const pointers when appropriate.
2864 (Fexpand_file_name): Likewise. In particular, newdir might
2865 point at constant storage, so make it a const pointer.
fd4ead52 2866 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2867 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2868 signedness issues.
f839df0c
PE
2869 (Fset_file_times, Finsert_file_contents, auto_save_error):
2870 Rename locals to avoid shadowing.
f14b7e14 2871
5716756e 2872 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2873 (Ftry_completion, Fall_completions): Rename or remove locals
2874 to avoid shadowing.
5716756e 2875
b4c3046a
PE
2876 * marker.c (bytepos_to_charpos): Remove; unused.
2877
b45db522
PE
2878 * lisp.h (verify_bytepos, count_markers): New decls,
2879 so that gcc does not warn that these functions aren't declared.
2880
85876d07
PE
2881 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2882 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2883 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2884 (copy_text): Remove unused local var.
85876d07 2885
03d78a21 2886 * filelock.c (within_one_second): Now static.
b3dd38ab 2887 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2888
5df8f01b
PE
2889 * buffer.c (fix_overlays_before): Mark locals as initialized.
2890 (fix_start_end_in_overlays): Likewise. This function should be
2891 simplified by using pointers-to-pointers, but that's a different
2892 matter.
b1d876f1 2893 (switch_to_buffer_1): Now static.
8f54f30a
PE
2894 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2895 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2896
a70072c9 2897 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2898 Fix pointer signedness issue.
edced198
PE
2899 (sys_subshell): Mark local as volatile if checking for lint,
2900 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2901 (MAXPATHLEN): Define only if needed.
a70072c9 2902
a0977c44
PE
2903 * process.c (serial_open, serial_configure): Move decls from here ...
2904 * systty.h: ... to here, so that they can be checked.
2905
a884fdcc
PE
2906 * fns.c (get_random, seed_random): Move extern decls from here ...
2907 * lisp.h: ... to here, so that they can be checked.
2908
604efe86 2909 * sysdep.c (reset_io): Now static.
b8950c94 2910 (wait_for_termination_signal): Remove; unused.
604efe86 2911
38fc62d9
PE
2912 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2913 (copy_keymap_item, append_key, push_text_char_description):
2914 Now static.
1004a21a 2915 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2916 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2917 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2918 (describe_map_tree):
2919 Rename locals to avoid shadowing.
38fc62d9 2920
2f2650da
PE
2921 * keyboard.c: Declare functions static if they are not used elsewhere.
2922 (echo_char, echo_dash, cmd_error, top_level_2):
2923 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2924 (read_char, kbd_buffer_get_event, make_lispy_position):
2925 (make_lispy_event, make_lispy_movement, apply_modifiers):
2926 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2927 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2928 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2929 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2930 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2931
a053e86c 2932 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2933 (mark_kboards): Move decl here ...
2934 * alloc.c (mark_kboards): ... from here.
a053e86c 2935
4752793e
PE
2936 * lisp.h (force_auto_save_soon): New decl.
2937
74f10ca7 2938 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2939 (DEFINE_DUMMY_FUNCTION): New macro.
2940 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2941 Use it.
c03cd23f
PE
2942 (main): Add casts to avoid warnings
2943 if GCC considers string literals to be constants.
74f10ca7 2944
022e70d4
PE
2945 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2946
59d6fe83
PE
2947 * dbusbind.c: Pointer signedness fixes.
2948 (xd_signature, xd_append_arg, xd_initialize):
2949 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2950 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2951 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2952 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2953
78320123
PE
2954 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2955 if GCC considers string literals to be constants.
49cebcca 2956 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2957
35ac2a97
SM
29582011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2959
fb103ca9
SM
2960 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2961 (print_preprocess, print_object): New macro to fix last change.
2962
35ac2a97
SM
2963 * print.c (print_preprocess): Don't forget font objects.
2964
62973b41
JB
29652011-03-16 Juanma Barranquero <lekktu@gmail.com>
2966
2967 * emacs.c (USAGE3): Doc fixes.
2968
0e48bb22
AS
29692011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2970
2971 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2972 structure.
2973
7684e57b
JB
29742011-03-14 Juanma Barranquero <lekktu@gmail.com>
2975
2976 * lisp.h (VWindow_system, Qfile_name_history):
2977 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2978 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2979 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2980
2981 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2982 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2983
2984 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2985 * w32console.c (detect_input_pending, read_input_pending)
2986 (encode_terminal_code):
2987 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2988 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2989 (w32_system_caret_y, Qfile_name_history):
2990 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2991 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2992 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2993 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2994 * w32proc.c (Qlocal, report_file_error):
2995 * w32term.c (Vwindow_system, updating_frame):
2996 * w32uniscribe.c (initialized, uniscribe_font_driver):
2997 Remove unneeded extern declarations.
2998
2aa46d6c
CY
29992011-03-14 Chong Yidong <cyd@stupidchicken.com>
3000
c96bbc66 3001 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3002
cffc6f3b
CY
30032011-03-13 Chong Yidong <cyd@stupidchicken.com>
3004
3005 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3006 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3007 These macros can no longer be used for assignment.
3008
44f230aa
SM
3009 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3010 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3011 (record_buffer_markers, fetch_buffer_markers): New functions for
3012 recording and fetching special buffer markers.
3013 (set_buffer_internal_1, set_buffer_temp): Use them.
3014
3015 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3016
3017 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3018
3019 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3020 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3021
3022 * xdisp.c (hscroll_window_tree):
3023 (reconsider_clip_changes): Use PT instead of BUF_PT.
3024
d251f04b
EZ
30252011-03-13 Eli Zaretskii <eliz@gnu.org>
3026
3027 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3028 $(EMACS_ROOT)/lib/intprops.h.
3029
f0c77cd1
PE
30302011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3031
3eca4629
PE
3032 Fix more problems found by GCC 4.5.2's static checks.
3033
7c86ee98
PE
3034 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3035 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3036 (xg_free_frame_widgets): Make it clear that a local variable is
3037 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3038 (gdk_window_get_screen): Make it clear that this macro is needed
3039 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3040 (int_gtk_range_get_value): New function, which avoids a diagnostic
3041 from gcc -Wbad-function-cast.
3042 (xg_set_toolkit_scroll_bar_thumb): Use it.
3043 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3044 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3045 (get_utf8_string, xg_get_file_with_chooser):
3046 Rename locals to avoid shadowing.
3047 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3048
41729b81
PE
3049 * xgselect.c (xg_select): Remove unused var.
3050
f0c77cd1
PE
3051 * image.c (four_corners_best): Mark locals as initialized.
3052 (gif_load): Initialize transparent_p to zero (Bug#8238).
3053 Mark another local as initialized.
ec6cf4c6 3054 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3055
ce0ad53d 3056 * image.c (clear_image_cache): Now static.
d5d5a617 3057 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3058 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3059 (x_edge_detection): Remove unnecessary cast that
3060 gcc -Wbad-function-cast diagnoses.
2037898d 3061 (gif_load): Fix pointer signedness.
6ae141d6
PE
3062 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3063 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3064
33383987 30652011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3066
d32df629
PE
3067 Improve quality of tests for time stamp overflow.
3068 For example, without this patch (encode-time 0 0 0 1 1
3069 1152921504606846976) returns the obviously-bogus value (-948597
3070 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3071 reports time overflow. See
3072 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3073 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3074 * editfns.c: Include limits.h and intprops.h.
3075 (TIME_T_MIN, TIME_T_MAX): New macros.
3076 (time_overflow): Move earlier, to before first use.
3077 (hi_time, lo_time): New functions, for an accurate test for
3078 out-of-range times.
3079 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3080 (Fget_internal_run_time): Don't assume time_t fits in int.
3081 (make_time): Use list2 instead of Fcons twice.
3082 (Fdecode_time): More accurate test for out-of-range times.
3083 (check_tm_member): New function.
3084 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3085 (lisp_time_argument): Don't rely on undefined left-shift and
3086 right-shift behavior when checking for time stamp overflow.
8be6f318 3087
fe31d94c
PE
3088 * editfns.c (time_overflow): New function, refactoring common code.
3089 (Fformat_time_string, Fdecode_time, Fencode_time):
3090 (Fcurrent_time_string): Use it.
3091
8be6f318
PE
3092 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3093 * dired.c (make_time): Move to ...
3094 * editfns.c (make_time): ... here.
3095 * systime.h: Note the move.
3096
09d9db2c 30972011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3098
126bc0dc
YM
3099 * fringe.c (update_window_fringes): Remove unused variables.
3100
c47cbdfd
YM
3101 * unexmacosx.c (copy_data_segment): Also copy __got section.
3102 (Bug#8223)
3103
7ac80be9
EZ
31042011-03-12 Eli Zaretskii <eliz@gnu.org>
3105
c96bbc66 3106 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3107 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3108 Constify `char *' arguments and their references according to
3109 prototypes in tparam.h.
3110
ecb0f94d 3111 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3112
7ac80be9
EZ
3113 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3114 Adapt all references accordingly.
3115
3116 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3117
ef1fd07e
TT
31182011-03-11 Tom Tromey <tromey@redhat.com>
3119
3120 * buffer.c (syms_of_buffer): Remove obsolete comment.
3121
7ef4b50c
EZ
31222011-03-11 Eli Zaretskii <eliz@gnu.org>
3123
3124 * termhooks.h (encode_terminal_code): Declare prototype.
3125
3126 * msdos.c (encode_terminal_code): Don't declare prototype.
3127
3128 * term.c (encode_terminal_code): Now external again, used by
3129 w32console.c and msdos.c.
3130
44f230aa
SM
3131 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3132 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3133
4b1ec863 31342011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3135
1714f52b 3136 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3137
4b1ec863
PE
3138 * fringe.c (update_window_fringes): Mark locals as initialized
3139 (Bug#8227).
3140 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3141
524c7aa6
PE
3142 * alloc.c (mark_fringe_data): Move decl from here ...
3143 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3144 to check its interface.
3145 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3146
a5c0af81 3147 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3148 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3149 (fontset_font): Mark local as initialized.
a9a06e0b 3150 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3151
b4716021
PE
3152 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3153
811e9bac 3154 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3155 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3156 (x_own_selection, Fx_disown_selection_internal): Rename locals
3157 to avoid shadowing.
3158 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3159
7e3ab302
PE
3160 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3161 so that the caller can use some name other than gcpro1.
3162 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3163 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3164 (Fx_backspace_delete_keys_p):
3165 Use them to avoid shadowing, and rename vars to avoid shadowing.
3166 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3167 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3168 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3169 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3170 Remove unused locals.
7e3ab302
PE
3171 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3172 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3173 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3174 macros.
f78faa98 3175
e2b13473
PE
3176 * xterm.h (x_mouse_leave): New decl.
3177
77f23912
PE
3178 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3179 Remove unused functions.
cdf4ba58
PE
3180 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3181 (x_calc_absolute_position): Now static.
7411c686 3182 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3183 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3184 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3185 unless they are used.
38d0b34a
PE
3186 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3187 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3188 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3189 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3190 (x_error_catcher, x_connection_closed, x_error_handler):
3191 (x_error_quitter, xembed_send_message, x_iconify_frame):
3192 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3193 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3194 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3195
44f230aa
SM
3196 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3197 Rename or move locals to avoid shadowing.
6b463e58 3198 (tty_defined_color, merge_face_heights): Now static.
5967d051 3199 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3200 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3201 does not deduce is never used uninitialized.
73719eba
PE
3202 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3203 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3204
426994c3 3205 * terminal.c (store_terminal_param): Now static.
5489860b 3206
032f1620 3207 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3208 (set_frame_menubar): Remove unused local.
d4323972 3209 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3210 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3211 since they might point to immutable storage.
281585b0
PE
3212 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3213 since it's unused otherwise.
032f1620 3214
367c19e5 3215 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3216 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3217 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3218 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3219 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3220 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3221 does not deduce are never used uninitialized.
70739cbe 3222
07b48fa9
PE
3223 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3224
8868a238 3225 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3226 * window.c (window_loop, size_window):
3227 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3228
7e5cf297 3229 * window.c (display_buffer): Now static.
d6550a9f
PE
3230 (size_window): Mark variables that gcc -Wuninitialized
3231 does not deduce are never used uninitialized.
a586633d
PE
3232 * window.h (check_all_windows): New decl, to forestall
3233 gcc -Wmissing-prototypes diagnostic.
5b555da1 3234 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3235
f6095868
PE
3236 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3237 shadowing.
3238 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3239 Include <limits.h>.
3240 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3241 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3242 (load_charset_map): Mark variables that gcc -Wuninitialized
3243 does not deduce are never used uninitialized.
53df7c11 3244 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3245
f38b440c
PE
3246 * coding.c (coding_set_source, coding_set_destination):
3247 Use "else { /* comment */ }" rather than "else /* comment */;"
3248 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3249 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3250 a block, when the outer 'i' will do.
3251 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3252 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3253 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3254 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3255 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3256 Rename locals to avoid shadowing.
3257 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3258 * coding.c (emacs_mule_char, encode_invocation_designation):
3259 Now static, since they're not used elsewhere.
413bb2db 3260 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3261 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3262 (decode_coding_emacs_mule): Mark variables that gcc
3263 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3264 (detect_coding_iso_2022): Initialize a local variable that might
3265 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3266 this initialization is needed. (Bug#8211)
5f58e762
PE
3267 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3268 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3269 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3270 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3271 Remove unused macros.
f38b440c 3272
232b38b9 3273 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3274 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3275 * character.c (string_count_byte8): Likewise.
232b38b9 3276
fb90da1b
PE
3277 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3278 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3279
fb93dbc2
PE
3280 * chartab.c (copy_sub_char_table): Now static, since it's not used
3281 elsewhere.
5c156ace
PE
3282 (sub_char_table_ref_and_range, char_table_ref_and_range):
3283 Rename locals to avoid shadowing.
bbcd0949 3284 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3285
7d3b3862 3286 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3287 (BIDI_BOB): Remove unused macro.
7d3b3862 3288
6be7d3da
PE
3289 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3290 deduce are never used uninitialized.
c2ed9c8b 3291 * term.c (encode_terminal_code): Likewise.
6be7d3da 3292
75f8807f 3293 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3294
50938595
PE
3295 * tparam.h: New file.
3296 * term.c, tparam.h: Include it.
3297 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3298 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3299 Move these decls to tparam.h, and make them agree with what
3300 is actually in tparam.c. The previous trick of using incompatible
3301 decls in different modules does not conform to the C standard.
3302 All callers of tparam changed to use tparam's actual API.
3303 * tparam.c (tparam1, tparam, tgoto):
3304 Use const pointers where appropriate.
3305
fbceeba2
PE
3306 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3307 * cm.h (struct cm): Likewise.
3308 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3309 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3310 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3311 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3312 (turn_on_face, init_tty): Likewise.
3313 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3314
7f3f1250
PE
3315 * term.c (term_mouse_position): Rename local to avoid shadowing.
3316
e6ca6543
PE
3317 * alloc.c (mark_ttys): Move decl from here ...
3318 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3319
c40f8d15
AS
33202011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3321
3322 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3323
cfe0661d
JB
33242011-03-09 Juanma Barranquero <lekktu@gmail.com>
3325
3326 * search.c (compile_pattern_1): Remove argument regp, unused since
3327 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3328 (compile_pattern): Don't pass it.
3329
0afb4571
J
33302011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3331
3332 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3333 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3334 for ! HAVE_GTK3.
3335 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3336
3337 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3338
3339 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3340 gdk_window_get_screen, gdk_window_get_geometry,
3341 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3342 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3343 (xg_get_pixbuf_from_pixmap): New function.
3344 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3345 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3346 Call xg_get_pixbuf_from_pixmap instead of
3347 gdk_pixbuf_get_from_drawable.
3348 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3349 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3350 (xg_check_special_colors): Use GtkStyleContext and its functions
3351 for HAVE_GTK3.
3352 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3353 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3354 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3355 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3356 Call gtk_widget_get_preferred_size.
0afb4571
J
3357 (xg_frame_resized): gdk_window_get_geometry only takes 5
3358 parameters.
44f230aa
SM
3359 (xg_win_to_widget, xg_event_is_for_menubar):
3360 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3361 (xg_set_widget_bg): New function.
3362 (delete_cb): New function.
895009e1 3363 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3364 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3365 (xg_set_background_color): Call xg_set_widget_bg.
3366 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3367 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3368 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3369 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3370 if ! HAVE_GTK3.
3371 (update_frame_tool_bar): Call gtk_widget_hide.
3372 (xg_initialize): Use GDK_KEY_g.
3373
3374 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3375 if ! HAVE_GTK3
3376 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3377
3378 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3379 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3380 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3381
1c2cc4ef
JB
33822011-03-08 Juanma Barranquero <lekktu@gmail.com>
3383
3384 * w32xfns.c (select_palette): Check success of RealizePalette against
3385 GDI_ERROR, not zero.
3386
33383987 3387See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3388
3389;; Local Variables:
3390;; coding: utf-8
aac0c6e3
MR
3391;; End:
3392
33383987 3393 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3394
3395 This file is part of GNU Emacs.
3396
3397 GNU Emacs is free software: you can redistribute it and/or modify
3398 it under the terms of the GNU General Public License as published by
3399 the Free Software Foundation, either version 3 of the License, or
3400 (at your option) any later version.
3401
3402 GNU Emacs is distributed in the hope that it will be useful,
3403 but WITHOUT ANY WARRANTY; without even the implied warranty of
3404 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3405 GNU General Public License for more details.
3406
3407 You should have received a copy of the GNU General Public License
3408 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.