* keyboard.h (num_input_events): Now uintmax_t.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0e926e56
PE
12011-07-07 Paul Eggert <eggert@cs.ucla.edu>
2
3300e6fd
PE
3 * keyboard.h (num_input_events): Now uintmax_t.
4 This is (very slightly) less likely to mess up due to wraparound.
5 All uses changed.
6
fd05c7e9
PE
7 * buffer.c: Integer signedness fixes.
8 (alloc_buffer_text, enlarge_buffer_text):
9 Use ptrdiff_t rather than size_t when either will do, as we prefer
10 signed integers.
11
5b8ffbdd
PE
12 * bidi.c: Integer signedness and overflow fixes.
13 (bidi_cache_idx, bidi_cache_last_idx, bidi_cache_fetch_state)
14 (bidi_cache_search, bidi_cache_find_level_change)
15 (bidi_cache_iterator_state, bidi_cache_find, bidi_find_other_level_edge)
16 (bidi_dump_cached_states):
17 Don't arbitrarily limit cache indexes to int; use ptrdiff_t instead.
18 (bidi_cache_size): Use ptrdiff_t rather than size_t, as we prefer
19 signed integers.
20 (elsz): Make it a (signed) constant.
21 (bidi_cache_iterator_state): Check for size-calculation overflow.
22
903fe15d
PE
23 * alloc.c: Integer signedness and overflow fixes.
24 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
25 (__malloc_size_t): Default to size_t, not to int.
26 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
27 (Fgarbage_collect, mark_object_loop_halt, mark_object):
28 Prefer ptrdiff_t to size_t when either would do, as we prefer
29 signed integers.
30 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
31 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
32 Now const. Initialize with values that are in range even if char
33 is signed.
34 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
35 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
36 These functions do the right thing with sizes > 2**32.
37 (check_depth): Now ptrdiff_t, not int.
38 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
39 Adjust to new way of storing sizes. Check for size overflow bugs
40 in rest of code.
41 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
42 slightly wrong anyway, as it missed one instance of
43 XMALLOC_OVERRUN_CHECK_OVERHEAD.
44 (refill_memory_reserve): Omit needless cast to size_t.
45 (mark_object_loop_halt): Mark as externally visible.
46
ac82cc6a
PE
47 * xselect.c: Integer signedness and overflow fixes.
48 (Fx_register_dnd_atom, x_handle_dnd_message):
49 Use ptrdiff_t, not size_t, since we prefer signed.
50 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
51 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
52 x_dnd_atoms_size and x_dnd_atoms_length.
53
c2d1e36d
PE
54 * doprnt.c: Prefer signed to unsigned when either works.
55 * eval.c (verror):
56 * doprnt.c (doprnt):
57 * lisp.h (doprnt):
58 * xdisp.c (vmessage):
59 Use ptrdiff_t, not size_t, when using or implementing doprnt,
60 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
61 prefer signed arithmetic to avoid comparison confusion.
62 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
63 but is a bit tricky.
64
0e926e56
PE
65 Assume freestanding C89 headers, string.h, stdlib.h.
66 * data.c, doprnt.c, floatfns.c, print.c:
67 Include float.h unconditionally.
68 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
69 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
70 * regex.c: Likewise for stddef.h, string.h.
71 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
72 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
73 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
74 (STDC_HEADERS): Remove obsolete defines.
75 * sysdep.c: Include limits.h unconditionally.
76
59361254 772011-07-06 Paul Eggert <eggert@cs.ucla.edu>
d8ed26bd 78
9cfdb3ec
PE
79 Assume support for memcmp, memcpy, memmove, memset.
80 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
81 * regex.c (memcmp, memcpy):
82 Remove; we assume C89 now.
83
84 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
85 (__malloc_safe_bcopy): Remove; no longer needed.
86
6089c567
PE
87 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
88 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
89 well either way, and we prefer signed to unsigned.
90
22b4128e
PE
912011-07-06 Paul Eggert <eggert@cs.ucla.edu>
92
93 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
94 * alloc.c (mark_buffer):
95 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
96 (clone_per_buffer_values): Don't assume that
22b4128e
PE
97 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
98 This isn't true in general, and it's particularly not true
99 if Emacs is configured with --with-wide-int.
100 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
101 New macros, used in the buffer.c change.
102
869795d6
JD
1032011-07-05 Jan Djärv <jan.h.d@swipnet.se>
104
105 * xsettings.c: Use both GConf and GSettings if both are available.
106 (store_config_changed_event): Add comment.
107 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
108 (store_tool_bar_style_changed): New functions.
109 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
110 (struct xsettings): Move font inside HAVE_XFT.
111 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
112 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
113 Move inside HAVE_XFT.
114 (something_changed_gsettingsCB): Renamed from something_changedCB.
115 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
116 also.
117 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
118 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
119 (something_changed_gconfCB): Renamed from something_changedCB.
120 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
121 (parse_settings): Move check for font inside HAVE_XFT.
122 (read_settings, apply_xft_settings): Add comment.
123 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
124 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
125 call store_font_name_changed.
126 (xft_settings_event): Add comment.
127 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
128 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
129 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
130 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
131 (xsettings_initialize): Call init_gsettings last.
132 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
133 comment.
134
d8ed26bd
PE
1352011-07-05 Paul Eggert <eggert@cs.ucla.edu>
136
137 Random fixes. E.g., (random) never returned negative values.
138 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
139 subseconds part to the entropy, as that's a bit more random.
140 Prefer signed to unsigned, since the signedness doesn't matter and
141 in general we prefer signed. When given a limit, use a
142 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
143 latter isn't right if USE_2_TAGS_FOR_INTS.
144 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
145 not 0..VALMASK. Don't discard "excess" bits that random () returns.
146
cabf1cac
SM
1472011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
148
149 * textprop.c (text_property_stickiness):
150 Obey Vtext_property_default_nonsticky.
151 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
152 * w32fns.c (syms_of_w32fns):
153 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
154
6e9b2be9
PE
1552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
156
157 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
158 This is more efficient than Ffile_directory_p and avoids a minor race.
159
90186c68
LMI
1602011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
161
7c301272
LMI
162 * buffer.c (Foverlay_put): Say what the return value is
163 (bug#7835).
164
c4f2d8d4
LMI
165 * fileio.c (barf_or_query_if_file_exists): Check first if the file
166 is a directory before asking whether to use the file name
167 (bug#7564).
ad637907
LMI
168 (barf_or_query_if_file_exists): Make the "File is a directory"
169 error be more correct.
c4f2d8d4 170
90186c68
LMI
171 * fns.c (Frequire): Remove the mention of the .gz files, since
172 that's installation-specific, but keep the mention of
173 `get-load-suffixes'.
174
da64016e
PE
1752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
176
177 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
178 Report string overflow if the output is too long.
179
7d47b580
JB
1802011-07-04 Juanma Barranquero <lekktu@gmail.com>
181
a555cb87
JB
182 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
183 (syms_of_gnutls): Remove duplicate DEFSYM for
184 Qgnutls_bootprop_verify_hostname_error, an error for
185 Qgnutls_bootprop_verify_error (which is no longer used).
186
7d47b580
JB
187 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
188 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
189 Also (re)move comments that are misplaced or no longer relevant.
190
1e49bfab
LMI
1912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
192
193 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
194
1485f4c0
CY
1952011-07-03 Chong Yidong <cyd@stupidchicken.com>
196
197 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
198 and background color parameters if they have been changed.
199
a9ab721e
LMI
2002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
201
202 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
203
cf7cff57
PE
2042011-07-03 Paul Eggert <eggert@cs.ucla.edu>
205
2e13213d
PE
206 * xsettings.c (SYSTEM_FONT): Define only when used.
207 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
208
cf7cff57
PE
209 * keymap.c (access_keymap_1): Now static.
210
7a8e04f7
CY
2112011-07-02 Chong Yidong <cyd@stupidchicken.com>
212
213 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
214 leave any prefix arg for the up event (Bug#1586).
215
61352f62
LMI
2162011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
217
69bb1ef7
LMI
218 * lread.c (syms_of_lread): Mention single symbols defined by
219 `defvar' or `defconst' (bug#7154).
220
61352f62 221 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 222 (Frequire): Mention get-load-suffixes.
61352f62 223
28545e04
MR
2242011-07-02 Martin Rudalics <rudalics@gmx.at>
225
226 * window.h (window): Remove clone_number slot.
227 * window.c (Fwindow_clone_number, Fset_window_clone_number):
228 Remove.
229 (make_parent_window, make_window, saved_window)
230 (Fset_window_configuration, save_window_save): Don't deal with
231 clone numbers.
232 * buffer.c (Qclone_number): Remove declaration.
233 (sort_overlays, overlay_strings): Don't deal with clone numbers.
234
3349e122
SM
2352011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
236
237 Add multiple inheritance to keymaps.
238 * keymap.c (Fmake_composed_keymap): New function.
239 (Fset_keymap_parent): Simplify.
240 (fix_submap_inheritance): Remove.
241 (access_keymap_1): New function extracted from access_keymap to handle
242 embedded parents and handle lists of maps.
243 (access_keymap): Use it.
244 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
245 (Fcopy_keymap): Handle embedded parents.
246 (Fcommand_remapping, define_as_prefix): Simplify.
247 (Fkey_binding): Simplify.
248 (syms_of_keymap): Move minibuffer-local-completion-map,
249 minibuffer-local-filename-completion-map,
250 minibuffer-local-must-match-map, and
251 minibuffer-local-filename-must-match-map to Elisp.
252 (syms_of_keymap): Defsubr make-composed-keymap.
253 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
254 (parse_menu_item): Trivial simplification.
255
3279eb87
GM
2562011-07-01 Glenn Morris <rgm@gnu.org>
257
258 * Makefile.in (SETTINGS_LIBS): Fix typo.
259
4550efdf
KI
2602011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
261
262 * coding.c (Fencode_coding_string): Record the last coding system
263 used, as the function doc string says (bug#8738).
264
0949d2b6
JD
2652011-07-01 Jan Djärv <jan.h.d@swipnet.se>
266
267 * xsettings.c (store_monospaced_changed): Take new font as arg and
268 check for change against current_mono_font.
269 (EMACS_TYPE_SETTINGS): Remove this and related defines.
270 (emacs_settings_constructor, emacs_settings_get_property)
271 (emacs_settings_set_property, emacs_settings_class_init)
272 (emacs_settings_init, gsettings_obj): Remove.
273 (something_changedCB): New function for HAVE_GSETTINGS.
274 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
275 with value as argument.
276 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
277 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 278 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
279 "changed".
280
281 * xgselect.c: Add defined (HAVE_GSETTINGS).
282 (xgselect_initialize): Ditto.
283
284 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
285 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
286 xg_select.
287
bbc6b304
PE
2882011-07-01 Paul Eggert <eggert@cs.ucla.edu>
289
290 * eval.c (struct backtrace): Simplify and port the data structure.
291 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
292 signed bit field, as this assumption is not portable and it makes
293 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
294 "char debug_on_exit : 1" as this is not portable either; instead,
295 use the portable "unsigned int debug_on_exit : 1". Remove unused
296 member evalargs. Remove obsolete comments about cc bombing out.
297
9851bfc5
JD
2982011-06-30 Jan Djärv <jan.h.d@swipnet.se>
299
51bb811f 300 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
301 Let HAVE_GSETTINGS override HAVE_GCONF.
302 (store_monospaced_changed): New function.
303 (EMACS_SETTINGS): A new type derived from GObject to handle
304 GSettings notifications.
305 (emacs_settings_constructor, emacs_settings_get_property)
306 (emacs_settings_set_property, emacs_settings_class_init):
307 New functions.
308 (gsettings_client, gsettings_obj): New variables.
309 (GSETTINGS_SCHEMA): New define.
310 (something_changedCB): Call store_monospaced_changed.
311 (init_gsettings): New function.
312 (xsettings_initialize): Call init_gsettings.
313 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
314 to NULL.
315
316 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
317 GCONF_CFLAGS/LIBS.
318
5386012d
MR
3192011-06-29 Martin Rudalics <rudalics@gmx.at>
320
321 * window.c (resize_root_window, grow_mini_window)
322 (shrink_mini_window): Rename Qresize_root_window to
323 Qwindow_resize_root_window and Qresize_root_window_vertically to
324 Qwindow_resize_root_window_vertically.
325
f13e0b08
PE
3262011-06-28 Paul Eggert <eggert@cs.ucla.edu>
327
328 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
329
94515237
JB
3302011-06-27 Juanma Barranquero <lekktu@gmail.com>
331
332 * makefile.w32-in: Redesign dependencies so they reflect more
333 clearly which files are directly included by each source file,
334 and not through other includes.
335
e43b6e43
MR
3362011-06-27 Martin Rudalics <rudalics@gmx.at>
337
338 * buffer.c (Qclone_number): Declare static and DEFSYM it.
339 (sort_overlays, overlay_strings): When an overlay's clone number
340 matches the window's clone number process the overlay even if
341 the overlay's window property doesn't match the current window.
342
d68443dc
MR
343 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
344 (Fwindow_hchild): Rename to Fwindow_left_child.
345 (Fwindow_next): Rename to Fwindow_next_sibling.
346 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
347 (resize_window_check): Rename to window_resize_check.
348 (resize_window_apply): Rename to window_resize_apply.
349 (Fresize_window_apply): Rename to Fwindow_resize_apply.
350 (Fdelete_other_windows_internal, resize_frame_windows)
351 (Fsplit_window_internal, Fdelete_window_internal)
352 (grow_mini_window, shrink_mini_window)
353 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 354
c7e73be5
JD
3552011-06-26 Jan Djärv <jan.h.d@swipnet.se>
356
357 * emacsgtkfixed.h: State that this is only used with Gtk+3.
358 (emacs_fixed_set_min_size): Remove.
359 (emacs_fixed_new): Take frame as argument.
360
361 * emacsgtkfixed.c: State that this is only used with Gtk+3.
362 (_EmacsFixedPrivate): Remove minwidth/height.
363 Add struct frame *f.
364 (emacs_fixed_init): Initialize priv->f.
365 (get_parent_class, emacs_fixed_set_min_size): Remove.
366 (emacs_fixed_new): Set priv->f to argument.
367 (emacs_fixed_get_preferred_width)
368 (emacs_fixed_get_preferred_height): Use min_width/height from
369 frames size_hint to set minimum and natural (Bug#8919).
370 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
371 and use min_width/height from frames size_hint to set
372 min_width/height (Bug#8919).
373
374 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
375 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
376 Fix indentation.
c7e73be5 377
cf99dcf8
EZ
3782011-06-26 Eli Zaretskii <eliz@gnu.org>
379
380 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
381 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
382 called at ZV.
383
029529ac
CY
3842011-06-26 Chong Yidong <cyd@stupidchicken.com>
385
386 * process.c (wait_reading_process_output): Bypass select if
387 waiting for a cell while ignoring keyboard input, and input is
388 pending. Suggested by Jan Djärv (Bug#8869).
389
7a7ef429
PE
3902011-06-25 Paul Eggert <eggert@cs.ucla.edu>
391
392 Use gnulib's dup2 module instead of rolling our own.
393 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
394
11fdef7d 3952011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
396
397 * dispnew.c (scrolling_window): Before scrolling, turn off a
398 mouse-highlight in the window being scrolled.
399
cd3520a4
JB
4002011-06-24 Juanma Barranquero <lekktu@gmail.com>
401
402 Move DEFSYM to lisp.h and use everywhere.
403
404 * character.h (DEFSYM): Move declaration...
405 * lisp.h (DEFSYM): ...here.
406
407 * gnutls.c:
408 * minibuf.c:
409 * w32menu.c:
410 * w32proc.c:
411 * w32select.c: Don't include character.h.
412
413 * alloc.c (syms_of_alloc):
414 * buffer.c (syms_of_buffer):
415 * bytecode.c (syms_of_bytecode):
416 * callint.c (syms_of_callint):
417 * casefiddle.c (syms_of_casefiddle):
418 * casetab.c (init_casetab_once):
419 * category.c (init_category_once, syms_of_category):
420 * ccl.c (syms_of_ccl):
421 * cmds.c (syms_of_cmds):
422 * composite.c (syms_of_composite):
423 * dbusbind.c (syms_of_dbusbind):
424 * dired.c (syms_of_dired):
425 * dispnew.c (syms_of_display):
426 * doc.c (syms_of_doc):
427 * editfns.c (syms_of_editfns):
428 * emacs.c (syms_of_emacs):
429 * eval.c (syms_of_eval):
430 * fileio.c (syms_of_fileio):
431 * fns.c (syms_of_fns):
432 * frame.c (syms_of_frame):
433 * fringe.c (syms_of_fringe):
434 * insdel.c (syms_of_insdel):
435 * keymap.c (syms_of_keymap):
436 * lread.c (init_obarray, syms_of_lread):
437 * macros.c (syms_of_macros):
438 * msdos.c (syms_of_msdos):
439 * print.c (syms_of_print):
440 * process.c (syms_of_process):
441 * search.c (syms_of_search):
442 * sound.c (syms_of_sound):
443 * syntax.c (init_syntax_once, syms_of_syntax):
444 * terminal.c (syms_of_terminal):
445 * textprop.c (syms_of_textprop):
446 * undo.c (syms_of_undo):
447 * w32.c (globals_of_w32):
448 * window.c (syms_of_window):
449 * xdisp.c (syms_of_xdisp):
450 * xfaces.c (syms_of_xfaces):
451 * xfns.c (syms_of_xfns):
452 * xmenu.c (syms_of_xmenu):
453 * xsettings.c (syms_of_xsettings):
454 * xterm.c (syms_of_xterm): Use DEFSYM.
455
4228cf16
TZ
4562011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
457
cd3520a4 458 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 459
7fcccf1e
PE
4602011-06-23 Paul Eggert <eggert@cs.ucla.edu>
461
7efb4e0e
PE
462 Integer and buffer overflow fixes (Bug#8873).
463
ff5844ad
PE
464 * print.c (printchar, strout): Check for string overflow.
465 (PRINTPREPARE, printchar, strout):
466 Don't set size unless allocation succeeds.
467
90532f02
PE
468 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
469 for sizes. Check for string overflow more accurately.
470 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
471
6d84508d
PE
472 * macros.c: Integer and buffer overflow fixes.
473 * keyboard.h (struct keyboard.kbd_macro_bufsize):
474 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
475 Use ptrdiff_t, not int, for sizes.
476 Don't increment bufsize until after realloc succeeds.
477 Check for size-calculation overflow.
478 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
479
437b2cb4
PE
480 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
481
8b9ac8b4
PE
482 * lread.c: Integer overflow fixes.
483 (read_integer): Radix is now EMACS_INT, not int,
484 to improve quality of diagnostics for out-of-range radices.
485 Calculate buffer size correctly for out-of-range radices.
486 (read1): Check for integer overflow in radices, and in
487 read-circle numbers.
82cb60d3
PE
488 (read_escape): Avoid int overflow.
489 (Fload, openp, read_buffer_size, read1)
490 (substitute_object_recurse, read_vector, read_list, map_obarray):
491 Use ptrdiff_t, not int, for sizes.
492 (read1): Use EMACS_INT, not int, for sizes.
20270765 493 Check for size overflow.
8b9ac8b4 494
7fcccf1e
PE
495 * image.c (cache_image): Check for size arithmetic overflow.
496
bfbbd7e7
PE
497 * lread.c: Integer overflow issues.
498 (saved_doc_string_size, saved_doc_string_length)
499 (prev_saved_doc_string_size, prev_saved_doc_string_length):
500 Now ptrdiff_t, not int.
501 (read1): Don't assume doc string length fits in int. Check for
502 out-of-range doc string lengths.
503 (read_list): Don't assume file position fits in int.
39019e54 504 (read_escape): Check for hex character overflow.
bfbbd7e7 505
4e323265
LL
5062011-06-22 Leo Liu <sdl.web@gmail.com>
507
508 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
509 Move to minibuffer.el.
510
85fece3e
PE
5112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
512
20b84ce9 513 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
514 The following patches are for when GLYPH_DEBUG && !XASSERT.
515 * dispextern.h (trace_redisplay_p, dump_glyph_string):
516 * dispnew.c (flush_stdout):
517 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
518 Mark as externally visible.
519 * dispnew.c (check_window_matrix_pointers): Now static.
520 * dispnew.c (window_to_frame_vpos):
521 * xfns.c (unwind_create_frame):
522 * xterm.c (x_check_font): Remove unused local.
523 * scroll.c (CHECK_BOUNDS):
524 * xfaces.c (cache_fache): Rename local to avoid shadowing.
525 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
526 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
527 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
528 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
529 Now static.
530 (debug_method_add): Use va_list and vsprintf rather than relying
531 on undefined behavior with wrong number of arguments.
532 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
533 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
534 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
535 since we're not interested in debugging glyphs with old libraries.
536 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
537 GCC 4.6.0's static checking.
538
0766b489
PE
5392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
540
31fd4b32
PE
541 Integer overflow and signedness fixes (Bug#8873).
542 A few related buffer overrun fixes, too.
543
b79e8648
PE
544 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
545
0766b489
PE
546 * dispextern.h (struct face.stipple):
547 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
548 (x_bitmap_mask, x_allocate_bitmap_record)
549 (x_create_bitmap_from_data, x_create_bitmap_from_file)
550 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
551 (x_create_bitmap_from_xpm_data):
552 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
553 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
554 (.bitmaps_last):
555 * xfaces.c (load_pixmap):
556 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
557 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
558 (.bitmaps_last, struct x_output.icon_bitmap):
559 Use ptrdiff_t, not int, for bitmap indexes.
560 (x_allocate_bitmap_record): Check for size overflow.
561 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
562
b081724f
PE
563 Use ptrdiff_t, not int, for overlay counts.
564 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
565 * editfns.c (overlays_around, get_pos_property):
566 * textprop.c (get_char_property_and_overlay):
567 * xdisp.c (next_overlay_change, note_mouse_highlight):
568 * xfaces.c (face_at_buffer_position):
21514da7
PE
569 * buffer.c (OVERLAY_COUNT_MAX): New macro.
570 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
571 (Fnext_overlay_change, Fprevious_overlay_change)
572 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 573 Use ptrdiff_t, not int, for sizes.
21514da7 574 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 575
3de73e5e
PE
576 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
577
2606c57b
PE
578 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
579 (x_session_initialize): Do not assume string length fits in int.
580
aaafe47a
PE
581 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
582 This is unlikely, but can occur if DPI is outlandish.
583
2674ddc8 584 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
585 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
586
28154962
PE
587 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
588 * xrdb.c (magic_file_p, search_magic_path):
589 Omit last arg SUFFIX; it was always 0. All callers changed.
590 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
591
7de51af5
PE
592 * xfont.c (xfont_match): Avoid need for strlen.
593
25ed6cc3
PE
594 * xfns.c: Don't assume strlen fits in int.
595 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
596
4eab31dd
PE
597 * xdisp.c (message_log_check_duplicate): Return intmax_t,
598 not unsigned long, as we prefer signed integers. All callers changed.
599 Detect integer overflow in repeat count.
600 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 601 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 602
171e2a58
PE
603 * termcap.c: Don't assume sizes fit in int and never overflow.
604 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
605 (gobble_line): Check for size-calculation overflow.
606
ad39faca 607 * minibuf.c (Fread_buffer):
6e5bb2dc 608 * lread.c (intern, intern_c_string):
74ca2eb3
PE
609 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
610 Don't assume string length fits in int.
611
52c61c22 612 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
613 * gtkutil.c (style_changed_cb): Avoid need for strlen.
614
b5b8c9e5
PE
615 * font.c: Don't assume string length fits in int.
616 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
617 Use ptrdiff_t, not int.
ccd6111c
PE
618 (font_intern_prop): Don't assume string length fits in int.
619 Don't assume integer property fits in fixnum.
620 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 621
882f0d81 622 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 623 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
624 Reformulate so as not to need the command string.
625 Invoke gzip -cd rather than gunzip, as it's more portable.
626 (lock_info_type, lock_file_1, lock_file):
627 Don't assume pid_t and time_t fit in unsigned long.
628 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
629 (current_lock_owner): Prefer signed type for sizes.
630 Use memcpy, not strncpy, where memcpy is what is really wanted.
631 Don't assume (via atoi) that time_t and pid_t fit in int.
632 Check for time_t and/or pid_t out of range, e.g., via a network share.
633 Don't alloca where an auto var works fine.
634
93f4cf88
PE
635 * fileio.c: Fix some integer overflow issues.
636 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
637 Don't assume string length fits in int.
638 (directory_file_name): Don't assume string length fits in long.
639 (make_temp_name): Don't assume pid fits in int, or that its print
640 length is less than 20.
641
f3e92b69
PE
642 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
643
1bfdaf10
PE
644 * coding.c (make_subsidiaries): Don't assume string length fits in int.
645
35016e9a
PE
646 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
647
3d1e65a1
PE
648 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
649 We prefer signed integers, even for size calculations.
650
0b963a93
PE
651 * emacs.c: Don't assume string length fits in 'int'.
652 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
653 (main): Don't invoke strlen when not needed.
654
573f4b54
PE
655 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
656 (XD_DEBUG_MESSAGE): Don't waste a byte.
657
989f33ba
PE
658 * callproc.c (getenv_internal_1, getenv_internal)
659 (Fgetenv_internal):
965d34eb
PE
660 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
661
e4d29b33
PE
662 * lread.c (invalid_syntax): Omit length argument.
663 All uses changed. This doesn't fix a bug, but it simplifies the
664 code away from its former Hollerith-constant appearance, and it's
665 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 666 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 667
eb49b136
PE
668 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
669 This didn't break anything, but it didn't help either.
670 It's confusing to put a bogus integer in a place where the actual
671 value does not matter.
9f62aeb1 672 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 673 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 674
15375a22
PE
675 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
676 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
677 implementation.
b61cc01c
PE
678 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
679 We prefer signed types, and the value cannot exceed the EMACS_INT
680 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
681 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
682 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
683 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 684
53b2623d
PE
685 * indent.c (sane_tab_width): New function.
686 (current_column, scan_for_column, Findent_to, position_indentation)
687 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 688 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 689
51cab52b 690 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 691
f2ed8a70
PE
692 * lisp.h (lint_assume): New macro.
693 * composite.c (composition_gstring_put_cache):
694 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
695
abe80cc6
PE
696 * editfns.c, insdel.c:
697 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 698
b02c740e
PE
699 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
700
ebc96716
PE
701 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
702
b4e50fa0 703 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 704 Use much-faster test for byte-length change.
311d5d7c 705 Don't assume string byte-length fits in 'int'.
a4cf38e4 706 Check that character arg fits in 'int'.
85461888 707 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 708
c0c1ee9f
PE
709 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
710
a498d7f4
PE
711 * fns.c (concat): Catch string overflow earlier.
712 Do not rely on integer wraparound.
713
51cab52b
PE
714 * dispextern.h (struct it.overlay_strings_charpos)
715 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
716 * xdisp.c (forward_to_next_line_start)
717 (back_to_previous_visible_line_start)
718 (reseat_at_next_visible_line_start, next_element_from_buffer):
719 Don't arbitrarily truncate the value of 'selective' to int.
720
76031fad
PE
721 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
722
5eb55db9
PE
723 * composite.c: Don't truncate sizes to 'int'.
724 (composition_gstring_p, composition_reseat_it)
725 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
726 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
727 not EMACS_UINT, for indexes.
5eb55db9 728
0703a717
PE
729 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
730
d6202519
PE
731 * buffer.c: Include <verify.h>.
732 (struct sortvec.priority, struct sortstr.priority):
8961a454 733 Now EMACS_INT, not int.
c20998a7 734 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
735 (struct sortstr.size, record_overlay_string)
736 (struct sortstrlist.size, struct sortlist.used):
737 Don't truncate size to int.
738 (record_overlay_string): Check for size-calculation overflow.
d6202519 739 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 740
d5a19415
JM
7412011-06-22 Jim Meyering <meyering@redhat.com>
742
029529ac 743 Don't leak an XBM-image-sized buffer
d5a19415
JM
744 * image.c (xbm_load): Free the image buffer after using it.
745
a9041e6c
PE
7462011-06-21 Paul Eggert <eggert@cs.ucla.edu>
747
748 Port to Sun C.
749 * composite.c (find_automatic_composition): Omit needless 'return 0;'
750 that Sun C diagnosed.
751 * fns.c (secure_hash): Fix pointer signedness issue.
752 * intervals.c (static_offset_intervals): New function.
753 (offset_intervals): Use it.
754
7f3f739f
LL
7552011-06-21 Leo Liu <sdl.web@gmail.com>
756
757 * deps.mk (fns.o):
758 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
759 sha512.h.
760
761 * fns.c (secure_hash): Rename from crypto_hash_function and change
762 the first arg to accept symbols.
5b66d427 763 (Fsecure_hash): New primitive.
7f3f739f
LL
764 (syms_of_fns): New symbols.
765
76147d94
DD
7662011-06-20 Deniz Dogan <deniz@dogan.se>
767
768 * process.c (Fset_process_buffer): Clarify return value in
769 docstring.
770
7d7d0045
CY
7712011-06-18 Chong Yidong <cyd@stupidchicken.com>
772
773 * dispnew.c (add_window_display_history): Use BVAR.
774
775 * xdisp.c (debug_method_add): Use BVAR.
776 (check_window_end, dump_glyph_matrix, dump_glyph)
777 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
778
779 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
780 Likewise.
781
782 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
783 check till after the cache is created in init_frame_faces.
784
ff2bc410
SM
7852011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
786
787 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
788
28177add
PE
7892011-06-16 Paul Eggert <eggert@cs.ucla.edu>
790
dd3482fe
PE
791 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
792 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
793 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
794
393d71f3 795 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
796 * fileio.c (Finsert_file_contents):
797 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
798 Remove the old (too-loose) buffer overflow checks.
799 They weren't needed, since make_gap checks for buffer overflow.
800 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
801 The old code merely checked for Emacs fixnum overflow, and relied
802 on undefined (wraparound) behavior. The new code avoids undefined
803 behavior, and also checks for ptrdiff_t and/or size_t overflow.
804
2e6813b0 805 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
806 Tune. Don't use wider integers than needed. Don't use alloca.
807 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 808
599a9e4f
PE
809 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
810
99561444
PE
811 * insdel.c, lisp.h (buffer_overflow): New function.
812 (insert_from_buffer_1, replace_range, replace_range_2):
813 * insdel.c (make_gap_larger):
814 * editfns.c (Finsert_char):
815 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
816
28177add
PE
817 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
818
e69dafad
PE
8192011-06-15 Paul Eggert <eggert@cs.ucla.edu>
820
a7af7fde 821 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 822
b1c46f02
PE
823 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
824 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
825
e69dafad
PE
826 * fileio.c: Don't assume EMACS_INT fits in off_t.
827 (emacs_lseek): New static function.
828 (Finsert_file_contents, Fwrite_region): Use it.
829 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
830
566684ea
PE
831 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
832
e6966cd6
PE
833 * fns.c: Don't overflow int when computing a list length.
834 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
835 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
836 truncation on 64-bit hosts. Check for QUIT every
837 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
838 faster and is responsive enough.
839 (Flength): Report an error instead of overflowing an integer.
840 (Fsafe_length): Return a float if the value is not representable
841 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 842 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 843 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 844
dd0b0efb
PE
845 * alloc.c: Check that resized vectors' lengths fit in fixnums.
846 (header_size, word_size): New constants.
847 (allocate_vectorlike): Don't check size overflow here.
848 (allocate_vector): Check it here instead, since this is the only
849 caller of allocate_vectorlike that could cause overflow.
850 Check that the new vector's length is representable as a fixnum.
851
86fe5cfe
PE
852 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
853 The previous code was bogus. For example, next_almost_prime (32)
854 returned 39, which is undesirable as it is a multiple of 3; and
855 next_almost_prime (24) returned 25, which is a multiple of 5 so
856 why was the code bothering to check for multiples of 7?
857
80e88859
PE
858 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
859
4a2f0ad6
PE
860 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
861
f66c7cf8
PE
862 Variadic C functions now count arguments with ptrdiff_t.
863 This partly undoes my 2011-03-30 change, which replaced int with size_t.
864 Back then I didn't know that the Emacs coding style prefers signed int.
865 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
866 were being counted with int, which may truncate counts on 64-bit
867 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
868 * lisp.h (struct Lisp_Subr.function.aMANY)
869 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
870 Arg counts are now ptrdiff_t, not size_t.
871 All variadic functions and their callers changed accordingly.
872 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
873 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
874 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
875 * callint.c (Fcall_interactively): Check arg count for overflow,
876 to avoid potential buffer overrun. Use signed char, not 'int',
877 for 'varies' array, so that we needn't bother to check its size
878 calculation for overflow.
879 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
880 * eval.c (apply_lambda):
881 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
882 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
883 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
884
a1759b76
PE
885 * callint.c (Fcall_interactively): Don't use index var as event count.
886
d96be9fc
PE
887 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
888 * mem-limits.h (SIZE): Remove; no longer used.
889
a690a978 890 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 891
578c21e6
PE
892 Remove unnecessary casts.
893 * xterm.c (x_term_init):
894 * xfns.c (x_set_border_pixel):
895 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
896 These aren't needed now that we assume ANSI C.
897
96f53c6c
PE
898 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
899 It's more likely to cause problems (due to unsigned overflow)
900 than to cure them.
901
83c77d31
PE
902 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
903
ee2079f1
PE
904 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
905
6da65536
PE
906 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
907
7147c4a4
PE
908 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
909
193e32d9
PE
910 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
911
e5533da6
PE
912 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
913
9910e595
PE
914 GLYPH_CODE_FACE returns EMACS_INT, not int.
915 * dispextern.h (merge_faces):
916 * xfaces.c (merge_faces):
01103c44
PE
917 * xdisp.c (get_next_display_element, next_element_from_display_vector):
918 Don't assume EMACS_INT fits in int.
9910e595 919
2638320e
PE
920 * character.h (CHAR_VALID_P): Remove unused parameter.
921 * fontset.c, lisp.h, xdisp.c: All uses changed.
922
045eb8d9
PE
923 * editfns.c (Ftranslate_region_internal): Omit redundant test.
924
c1f134b5
PE
925 * fns.c (concat): Minor tuning based on overflow analysis.
926 This doesn't fix any bugs. Use int to hold character, instead
927 of constantly refetching from Emacs object. Use XFASTINT, not
928 XINT, for value known to be a character. Don't bother comparing
929 a single byte to 0400, as it's always less.
930
395fcb93 931 * floatfns.c (Fexpt):
327eeec8
PE
932 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
933
abbd3d23
PE
934 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
935 for characters.
936
684a03ef
PE
937 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
938
0fed43f3
PE
939 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
940 Without this fix, on a 64-bit host (aset S 0 4294967386) would
941 incorrectly succeed when S was a string, because 4294967386 was
942 truncated before it was used.
943
8fd02eb7
PE
944 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
945 Otherwise, an out-of-range integer could cause undefined behavior
946 on a 64-bit host.
947
f8c86b69
PE
948 * composite.c: Use int, not EMACS_INT, for characters.
949 (fill_gstring_body, composition_compute_stop_pos): Use int, not
950 EMACS_INT, for values that are known to be in character range.
951 This doesn't fix any bugs but is the usual style inside Emacs and
952 may generate better code on 32-bit machines.
953
34206dd2
PE
954 Make sure a 64-bit char is never passed to ENCODE_CHAR.
955 This is for reasons similar to the recent CHAR_STRING fix.
956 * charset.c (Fencode_char): Check that character arg is actually
957 a character. Pass an int to ENCODE_CHAR.
958 * charset.h (ENCODE_CHAR): Verify that the character argument is no
959 wider than 'int', as a compile-time check to prevent future regressions
960 in this area.
961
c5958d4c 962 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
963
964 Make sure a 64-bit char is never passed to CHAR_STRING.
965 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
966 by silently ignoring the top 32 bits, allowing some values
967 that were far too large to be valid characters.
968 * character.h: Include <verify.h>.
969 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
970 arguments are no wider than unsigned, as a compile-time check
971 to prevent future regressions in this area.
972 * data.c (Faset):
01103c44 973 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
974 (Fsubst_char_in_region):
975 * fns.c (concat):
976 * xdisp.c (decode_mode_spec_coding):
977 Adjust to CHAR_STRING's new requirement.
978 * editfns.c (Finsert_char, Fsubst_char_in_region):
979 * fns.c (concat): Check that character args are actually
980 characters. Without this test, these functions did the wrong
981 thing with wildly out-of-range values on 64-bit hosts.
982
d37ca623
PE
983 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
984 These casts should not be needed on 32-bit hosts, either.
985 * keyboard.c (read_char):
986 * lread.c (Fload): Remove casts to unsigned.
987
ea204efb
PE
988 * lisp.h (UNSIGNED_CMP): New macro.
989 This fixes comparison bugs on 64-bit hosts.
990 (ASCII_CHAR_P): Use it.
991 * casefiddle.c (casify_object):
01103c44 992 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
993 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
994 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
995 * dispextern.h (FACE_FROM_ID):
996 * keyboard.c (read_char): Use UNSIGNED_CMP.
997
41cb286c
PE
998 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
999 not to EMACS_INT, to avoid GCC warning.
1000
4a1b9832
PE
1001 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1002
55daad71
PE
1003 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1004 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1005 isn't needed on 32-bit machines.
8f95c75c 1006
01103c44
PE
1007 * buffer.c (Fgenerate_new_buffer_name):
1008 Use EMACS_INT for count, not int.
0ceccced 1009 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1010
1011 * data.c (Qcompiled_function): Now static.
1012
c6f072e7
PE
1013 * window.c (window_body_lines): Now static.
1014
20ce5912
PE
1015 * image.c (gif_load): Rename local to avoid shadowing.
1016
9c4c5f81
PE
1017 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1018 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1019 * alloc.c (make_save_value): Integer argument is now of type
1020 ptrdiff_t, not int.
1021 (mark_object): Use ptrdiff_t, not int.
1022 * lisp.h (pD): New macro.
1023 * print.c (print_object): Use it.
1024
c0c5c8ae
PE
1025 * alloc.c: Use EMACS_INT, not int, to count objects.
1026 (total_conses, total_markers, total_symbols, total_vector_size)
1027 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1028 (total_free_floats, total_floats, total_free_intervals)
1029 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1030 Now EMACS_INT, not int. All uses changed.
1031 (Fgarbage_collect): Compute overall total using a double, so that
1032 integer overflow is less likely to be a problem. Check for overflow
1033 when converting back to an integer.
5a25e253
PE
1034 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1035 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1036 These were 'int' variables that could overflow on 64-bit hosts;
1037 they were never used, so remove them instead of repairing them.
211a0b2a 1038 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1039 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1040 Previously, this ceilinged at INT_MAX, but that doesn't work on
1041 64-bit machines.
e46bb31a 1042 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1043
c78baabf 1044 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1045 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1046 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1047 when a (possibly-narrower) signed value would do just as well.
1048 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1049
c9d624c6
PE
1050 * alloc.c: Catch some string size overflows that we were missing.
1051 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1052 for convenience in STRING_BYTES_MAX.
1053 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1054 The definition here is exact; the one in lisp.h was approximate.
1055 (allocate_string_data): Check for string overflow. This catches
1056 some instances we weren't catching before. Also, it catches
1057 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1058 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1059 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1060
c9d624c6
PE
1061 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1062 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1063 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1064
353032ce
PE
1065 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1066
2bccce07
PE
1067 * alloc.c (Fmake_string): Check for out-of-range init.
1068
0ac30604
SM
10692011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1070
1071 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1072
c195f2de
JD
10732011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1074
1075 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1076 xg_get_default_scrollbar_width.
1077
1078 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1079 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1080 (style_changed_cb): Call update_theme_scrollbar_width and call
1081 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1082 all frames (Bug#8505).
1083 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1084 Call gtk_window_set_resizable if HAVE_GTK3.
1085 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1086 and height if HAVE_GTK3 (Bug#8505).
1087 (scroll_bar_width_for_theme): New variable.
1088 (update_theme_scrollbar_width): New function.
1089 (xg_get_default_scrollbar_width): Move code to
1090 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1091 (xg_initialize): Call update_theme_scrollbar_width.
1092
1093 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1094
1095 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1096
e10ac9f1
MR
10972011-06-12 Martin Rudalics <rudalics@gmx.at>
1098
1099 * frame.c (make_frame): Call other_buffer_safely instead of
1100 other_buffer.
1101
1102 * window.c (temp_output_buffer_show): Call display_buffer with
1103 second argument Vtemp_buffer_show_specifiers and reset latter
1104 immediately after the call.
1105 (Vtemp_buffer_show_specifiers): New variable.
1106 (auto_window_vscroll_p, next_screen_context_lines)
1107 (Vscroll_preserve_screen_position): Remove leading asterisks from
1108 doc-strings.
1109
2d3c217e 11102011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1111
7b7f97e8 1112 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1113 * buffer.c (Qclone_number): Remove for now, as it's unused.
1114 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1115 (record_buffer): Remove unused local.
1116 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1117 (set_frame_buffer_list): Remove; unused.
1118 * frame.h (other_visible_frames): Remove decl.
1119 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1120 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1121 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1122 if HAVE_GPM.
1123 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1124 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1125 Define only if HAVE_GPM.
1126 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1127 (update_hints_inhibit): Remove; never set. All uses removed.
1128 * widgetprv.h (emacsFrameClassRec): Remove decl.
1129 * window.c (delete_deletable_window): Now returns void, since it
1130 wasn't returning anything.
1131 (compare_window_configurations): Remove unused locals.
1132 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1133 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1134 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1135 the same widths as pointers. This follows up on the 2011-05-06 patch.
1136 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1137 * xterm.h: Likewise.
1138 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1139
1384b89e
JB
11402011-06-12 Juanma Barranquero <lekktu@gmail.com>
1141
1142 * makefile.w32-in: Update dependencies.
1143 (LISP_H): Add lib/intprops.h.
1144
1100a63c
CY
11452011-06-11 Chong Yidong <cyd@stupidchicken.com>
1146
1147 * image.c (gif_load): Add animation frame delay to the metadata.
1148 (syms_of_image): Use DEFSYM. New symbol `delay'.
1149
6198ccd0
MR
11502011-06-11 Martin Rudalics <rudalics@gmx.at>
1151
1152 * window.c (delete_deletable_window): Re-add.
1153 (Fset_window_configuration): Rewrite to handle dead buffers and
1154 consequently deletable windows.
1155 (window_tree, Fwindow_tree): Remove. Supply functionality in
1156 window.el.
1157 (compare_window_configurations): Simplify code.
1158
b6e3633c
AS
11592011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1160
1ab0dee5
AS
1161 * image.c (imagemagick_load_image): Fix type mismatch.
1162 (Fimagemagick_types): Likewise.
1163
b6e3633c
AS
1164 * window.h (replace_buffer_in_windows): Declare.
1165
9397e56f
MR
11662011-06-11 Martin Rudalics <rudalics@gmx.at>
1167
1168 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1169 Qclone_number. Remove external declaration of Qdelete_window.
1170 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1171 code.
1172 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1173 Qbuffer_list_update_hook if allowed.
1174 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1175 buffer list implementation.
1176 (other_buffer_safely): New function.
1177 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1178 calls to replace_buffer_in_windows and
1179 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1180 if allowed.
1181 (record_buffer): Inhibit quitting and rewrite using quittable
1182 functions. Run Qbuffer_list_update_hook if allowed.
1183 (Frecord_buffer, Funrecord_buffer): New functions.
1184 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1185 switch-to-buffer to window.el.
1186 (bury-buffer): Move to window.el.
1187 (Vbuffer_list_update_hook): New variable.
1188
1189 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1190 section.
1191
1192 * window.h (resize_frame_windows): Move up in code.
1193 (Fwindow_frame): Remove EXFUN.
1194 (replace_buffer_in_all_windows): Remove prototype.
1195 (replace_buffer_in_windows_safely): Add prototype.
1196
1197 * window.c: Declare Qdelete_window static again. Move down
1198 declaration of select_count.
1199 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1200 (Fother_window): Move to window.el.
1201 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1202 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1203 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1204 window.el.
1205 (replace_buffer_in_windows): Implement by calling
1206 Qreplace_buffer_in_windows.
1207 (replace_buffer_in_all_windows): Remove with some functionality
1208 moved into replace_buffer_in_windows_safely.
1209 (replace_buffer_in_windows_safely): New function.
1210 (select_window_norecord, select_frame_norecord): Move in front
1211 of run_window_configuration_change_hook. Remove now obsolete
1212 declarations.
1213 (Fset_window_buffer): Rewrite doc-string. Call
1214 Qrecord_window_buffer.
1215 (keys_of_window): Move binding for other-window to window.el.
1216
b50691aa
CY
12172011-06-11 Chong Yidong <cyd@stupidchicken.com>
1218
1219 * dispextern.h (struct image): Replace data member, whose int_val
1220 and ptr_val fields were not used by anything, with a single
1221 lisp_val object.
1222
1223 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1224 (gif_clear_image, gif_load, imagemagick_load_image)
1225 (gs_clear_image, gs_load): Callers changed.
1226
3f754b86
PE
12272011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1228
cca69397
PE
1229 * buffer.h: Include <time.h>, for time_t.
1230 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1231
109e28d0
PE
1232 Fix minor problems found by static checking.
1233
60737f02
PE
1234 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1235
4b66faf3
PE
1236 Make identifiers static if they are not used in other modules.
1237 * data.c (Qcompiled_function, Qframe, Qvector):
1238 * image.c (QimageMagick, Qsvg):
1239 * minibuf.c (Qmetadata):
1240 * window.c (resize_window_check, resize_root_window): Now static.
1241 * window.h (resize_window_check, resize_root_window): Remove decls.
1242
109e28d0
PE
1243 * window.c (window_deletion_count, delete_deletable_window):
1244 Remove; unused.
46a4ce9e
PE
1245 (window_body_lines): Now static.
1246 (Fdelete_other_windows_internal): Mark vars as initialized.
1247 Make sure 'resize_failed' is initialized.
1248 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1249 (resize_window_apply): Remove unused local.
1250 * window.h (delete_deletable_window): Remove decl.
1251
109e28d0 1252 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1253 (imagemagick_load_image): Fix pointer signedness problem by changing
1254 last arg from unsigned char * to char *. All uses changed.
1255 Also, fix a local for similar reasons.
1256 Remove unused locals. Remove locals to avoid shadowing.
1257 (fn_rsvg_handle_free): Remove; unused.
1258 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1259 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1260
3f754b86
PE
1261 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1262
2547adb1
CY
12632011-06-10 Chong Yidong <cyd@stupidchicken.com>
1264
1265 * image.c (gif_load): Fix omitted cast error introduced by
1266 2011-06-06 change.
1267
2c8e37d4
MR
12682011-06-10 Martin Rudalics <rudalics@gmx.at>
1269
1270 * window.h (resize_proportionally, orig_total_lines)
1271 (orig_top_line): Remove from window structure.
1272 (set_window_height, set_window_width, change_window_heights)
1273 (Fdelete_window): Remove prototypes.
1274 (resize_frame_windows): Remove duplicate declaration.
1275
440a42e3
EZ
12762011-06-10 Eli Zaretskii <eliz@gnu.org>
1277
1278 * window.h (resize_frame_windows, resize_window_check)
1279 (delete_deletable_window, resize_root_window)
1280 (resize_frame_windows): Declare prototypes.
1281
1282 * window.c (resize_window_apply): Make definition be "static" to
1283 match the prototype.
1284
562dd5e9
MR
12852011-06-10 Martin Rudalics <rudalics@gmx.at>
1286
1287 * window.c: Remove declarations of Qwindow_size_fixed,
1288 window_min_size_1, window_min_size_2, window_min_size,
1289 size_window, window_fixed_size_p, enlarge_window, delete_window.
1290 Remove static from declaration of Qdelete_window, it's
1291 temporarily needed by Fbury_buffer.
1292 (replace_window): Don't assign orig_top_line and
1293 orig_total_lines.
1294 (Fdelete_window, delete_window): Remove. Window deletion is
1295 handled by window.el.
1296 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1297 Fdelete_window calls with calls to Qdelete_window.
1298 (Fdelete_other_windows): Remove. Deleting other windows is
1299 handled by window.el.
1300 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1301 handled in window.el.
1302 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1303 Window minimum sizes are handled in window.el.
1304 (shrink_windows, size_window, set_window_height)
1305 (set_window_width, change_window_heights, window_height)
1306 (window_width, CURBEG, CURSIZE, enlarge_window)
1307 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1308 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1309 handled in window.el.
1310 (make_dummy_parent): Rename to make_parent_window and give it a
1311 second argument horflag.
1312 (make_window): Don't set resize_proportionally any more.
1313 (Fsplit_window): Remove. Windows are split in window.el.
1314 (save_restore_action, save_restore_orig_size)
1315 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1316 Resize mini windows in window.el.
1317 (grow_mini_window, shrink_mini_window): Implement by calling
1318 Qresize_root_window_vertically, resize_window_check and
1319 resize_window_apply.
1320 (saved_window, Fset_window_configuration, save_window_save): Do
1321 not handle orig_top_line, orig_total_lines, and
1322 resize_proportionally.
1323 (window_min_height, window_min_width): Move to window.el.
1324 (keys_of_window): Move bindings for delete-other-windows,
1325 split-window, delete-window and enlarge-window to window.el.
1326
1327 * buffer.c: Temporarily extern Qdelete_window.
1328 (Fbury_buffer): Temporarily call Qdelete_window instead of
1329 Fdelete_window (Fbury_buffer will move to window.el soon).
1330
1331 * frame.c (set_menu_bar_lines_1): Remove code handling
1332 orig_top_line and orig_total_lines.
1333
1334 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1335 set_window_height but set heights directly.
1336 (change_frame_size_1): Use resize_frame_windows.
1337
1338 * xdisp.c (init_xdisp): Don't use set_window_height but set
1339 heights directly.
1340
1341 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1342 resize_frame_windows instead of change_window_heights and run
1343 run_window_configuration_change_hook.
1344
1345 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1346 instead of change_window_heights and run
1347 run_window_configuration_change_hook.
1348
1a13852e
MR
13492011-06-09 Martin Rudalics <rudalics@gmx.at>
1350
1351 * window.c (replace_window): Rename second argument REPLACEMENT to
1352 NEW. New third argument SETFLAG. Rewrite.
1353 (delete_window, make_dummy_parent): Call replace_window with
1354 third argument 1.
1355 (window_list_1): Move down in code.
1356 (run_window_configuration_change_hook): Move set_buffer part
1357 before select_frame_norecord part in order to unwind correctly.
1358 Rename count1 to count.
1359 (recombine_windows, delete_deletable_window, resize_root_window)
1360 (Fdelete_other_windows_internal)
1361 (Frun_window_configuration_change_hook, make_parent_window)
1362 (resize_window_check, resize_window_apply, Fresize_window_apply)
1363 (resize_frame_windows, Fsplit_window_internal)
1364 (Fdelete_window_internal, Fresize_mini_window_internal): New
1365 functions.
1366 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1367
f3d1777e
MR
13682011-06-08 Martin Rudalics <rudalics@gmx.at>
1369
496e208e
MR
1370 * window.h (window): Add some new members to window structure -
1371 normal_lines, normal_cols, new_total, new_normal, clone_number,
1372 splits, nest, prev_buffers, next_buffers.
1373 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1374 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1375
f3d1777e
MR
1376 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1377 Remove.
496e208e
MR
1378 (make_dummy_parent): Set new members of windows structure.
1379 (make_window): Move down in code. Handle new members of window
1380 structure.
1381 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1382 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1383 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1384 (Fset_window_prev_buffers, Fwindow_next_buffers)
1385 (Fset_window_next_buffers, Fset_window_clone_number): New
1386 functions.
1387 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1388 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1389 Doc-string fixes.
1390 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1391 Argument WINDOW can be now internal window too.
1392 (Fwindow_use_time): Move up in code.
1393 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1394 Rewrite doc-string.
1395 (Fset_window_configuration, saved_window)
1396 (Fcurrent_window_configuration, save_window_save): Handle new
1397 members of window structure.
b9e809c2
MR
1398 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1399 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1400 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1401 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1402 Qget_mru_window, Qresize_root_window,
1403 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1404 Qauto_buffer_name; staticpro them.
f3d1777e 1405
abde8f8c
MR
14062011-06-07 Martin Rudalics <rudalics@gmx.at>
1407
1408 * window.c (Fwindow_total_size, Fwindow_left_column)
1409 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1410 (Fwindow_list_1): New functions.
1411 (window_box_text_cols): Replace with window_body_cols.
1412 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1413 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1414 (delete_window, Fset_window_configuration): Call
1415 delete_all_subwindows with window as argument.
1416 (delete_all_subwindows): Take a window as argument and not a
1417 structure. Rewrite.
190b47e6
MR
1418 (window_loop): Remove handling of GET_LRU_WINDOW and
1419 GET_LARGEST_WINDOW.
1420 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1421
1422 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1423 window_box_text_cols. delete_all_subwindows now takes a
1424 Lisp_Object as argument.
abde8f8c
MR
1425
1426 * indent.c (compute_motion, Fcompute_motion): Use
1427 window_body_cols instead of window_box_text_cols.
1428
fa8a67e6
MR
1429 * frame.c (delete_frame): Call delete_all_subwindows with root
1430 window as argument.
1431
a54e3482
DC
14322011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1433
1434 * fns.c (Fputhash): Document return value.
1435
60002bf5
CY
14362011-06-06 Chong Yidong <cyd@stupidchicken.com>
1437
1438 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1439
0c671da6 14402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1441
b862a52a 1442 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1443
be44ca6c
PE
1444 Check for overflow when converting integer to cons and back.
1445 * charset.c (Fdefine_charset_internal, Fdecode_char):
1446 Use cons_to_unsigned to catch overflow.
1447 (Fencode_char): Use INTEGER_TO_CONS.
1448 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1449 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1450 * data.c (long_to_cons, cons_to_long): Remove.
1451 (cons_to_unsigned, cons_to_signed): New functions.
1452 These signal an error for invalid or out-of-range values.
1453 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1454 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1455 * font.c (Ffont_variation_glyphs):
1456 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1457 * lisp.h: Include <intprops.h>.
1458 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1459 (cons_to_signed, cons_to_unsigned): New decls.
1460 (long_to_cons, cons_to_long): Remove decls.
1461 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1462 (Fprimitive_undo): Use CONS_TO_INTEGER.
1463 * xfns.c (Fx_window_property): Likewise.
1464 * xselect.c: Include <limits.h>.
1465 (x_own_selection, selection_data_to_lisp_data):
1466 Use INTEGER_TO_CONS.
1467 (x_handle_selection_request, x_handle_selection_clear)
1468 (x_get_foreign_selection, Fx_disown_selection_internal)
1469 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1470 (lisp_data_to_selection_data): Use cons_to_unsigned.
1471 (x_fill_property_data): Use cons_to_signed.
1472 Report values out of range.
1473
d1f3d2af
PE
1474 Check for buffer and string overflow more precisely.
1475 * buffer.h (BUF_BYTES_MAX): New macro.
1476 * lisp.h (STRING_BYTES_MAX): New macro.
1477 * alloc.c (Fmake_string):
1478 * character.c (string_escape_byte8):
1479 * coding.c (coding_alloc_by_realloc):
1480 * doprnt.c (doprnt):
1481 * editfns.c (Fformat):
1482 * eval.c (verror):
1483 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1484 since they may not be the same number.
1485 * editfns.c (Finsert_char):
1486 * fileio.c (Finsert_file_contents):
1487 Likewise for BUF_BYTES_MAX.
1488
dd52fcea
PE
1489 * image.c: Use ptrdiff_t, not int, for sizes.
1490 (slurp_file): Switch from int to ptrdiff_t.
1491 All uses changed.
1492 (slurp_file): Check that file size fits in both size_t (for
1493 malloc) and ptrdiff_t (for sanity and safety).
1494
7f9bbdbb
PE
1495 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1496 if b->modtime has its maximal value.
1497
dfe18f82
PE
1498 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1499
84acfcf0
PE
1500 Don't assume time_t can fit into int.
1501 * buffer.h (struct buffer.modtime): Now time_t, not int.
1502 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1503 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1504
ccd9a01a
PE
1505 Minor fixes for signed vs unsigned integers.
1506 * character.h (MAYBE_UNIFY_CHAR):
1507 * charset.c (maybe_unify_char):
1508 * keyboard.c (read_char, reorder_modifiers):
1509 XINT -> XFASTINT, since the integer must be nonnegative.
1510 * ftfont.c (ftfont_spec_pattern):
1511 * keymap.c (access_keymap, silly_event_symbol_error):
1512 XUINT -> XFASTINT, since the integer must be nonnegative.
1513 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1514 since it makes no difference and we prefer signed.
1515 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1516 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1517 nonnegative.
1518
d6d100dd
SM
15192011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1520
1521 * window.h (Fwindow_frame): Declare.
1522
2b6148e4
PE
15232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1526 (SPARE_MEMORY): Always define.
1527 (LARGE_REQUEST): Remove.
1528 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1529
f230ecc9
MR
15302011-06-06 Martin Rudalics <rudalics@gmx.at>
1531
727e958e
MR
1532 * lisp.h: Move EXFUNS for Fframe_root_window,
1533 Fframe_first_window and Fset_frame_selected_window to window.h.
1534
1535 * window.h: Move EXFUNS for Fframe_root_window,
1536 Fframe_first_window and Fset_frame_selected_window here from
1537 lisp.h.
1538
1539 * frame.c (Fwindow_frame, Fframe_first_window)
1540 (Fframe_root_window, Fframe_selected_window)
1541 (Fset_frame_selected_window): Move to window.c.
1542 (Factive_minibuffer_window): Move to minibuf.c.
1543 (Fother_visible_frames_p): New function.
1544
1545 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1546
f230ecc9
MR
1547 * window.c (decode_window, decode_any_window): Move up in code.
1548 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1549 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1550 (Fwindow_buffer): Move up and rewrite doc-string.
1551 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1552 (Fwindow_prev): New functions.
727e958e
MR
1553 (Fwindow_frame): Move here from frame.c. Accept any window as
1554 argument.
1555 (Fframe_root_window, Fframe_first_window)
1556 (Fframe_selected_window): Move here from frame.c. Accept frame
1557 or arbitrary window as argument. Update doc-strings.
1558 (Fminibuffer_window): Move up in code.
1559 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1560 (Fset_frame_selected_window): Move here from frame.c.
1561 Marginal rewrite.
727e958e
MR
1562 (Fselected_window, select_window, Fselect_window): Move up in
1563 code. Minor doc-string fixes.
f230ecc9 1564
4d09bcf6
PE
15652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1566
1567 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1568 Do not assume that spare memory exists; that assumption is valid
1569 only if SYSTEM_MALLOC.
1570 (LARGE_REQUEST): New macro, so that the issue of large requests
1571 is separated from the issue of spare memory.
1572
810928a2
AS
15732011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1574
172418ad
AS
1575 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1576 format. (Bug#8806)
1577
43f862f7
AS
1578 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1579
810928a2
AS
1580 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1581 before statements.
1582
a059fe24
JD
15832011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1584
1585 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1586
1587 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1588
1589 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1590 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1591
989bf368
JB
15922011-06-05 Juanma Barranquero <lekktu@gmail.com>
1593
1594 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1595
4b80f674
CY
15962011-06-04 Chong Yidong <cyd@stupidchicken.com>
1597
1598 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1599 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1600 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1601 New error handlers.
4b80f674
CY
1602 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1603 Obey Vx_select_enable_clipboard_manager. Catch errors in
1604 x_clipboard_manager_save (Bug#8779).
1605 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1606 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1607
99a33b77 16082011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1609
1610 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1611
99a33b77 16122011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1613
1614 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1615 in the current matrix if keep_current_p is non-zero.
1616
8264569d
EZ
16172011-06-04 Eli Zaretskii <eliz@gnu.org>
1618
1619 * bidi.c (bidi_level_of_next_char): Fix last change.
1620
57f97249
EZ
16212011-06-03 Eli Zaretskii <eliz@gnu.org>
1622
fec2107c 1623 Support bidi reordering of text covered by display properties.
57f97249 1624
fec2107c
EZ
1625 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1626 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1627 (bidi_cache_search, bidi_cache_iterator_state)
1628 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1629 (bidi_level_of_next_char, bidi_move_to_visually_next):
1630 Support character positions inside a run of characters covered by a
fec2107c
EZ
1631 display string.
1632 (bidi_paragraph_init, bidi_resolve_explicit_1)
1633 (bidi_level_of_next_char): Call bidi_fetch_char and
1634 bidi_fetch_char_advance instead of FETCH_CHAR and
1635 FETCH_CHAR_ADVANCE.
1636 (bidi_init_it): Initialize new members.
1637 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1638 definitions.
1639 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1640 instead of using explicit *_CHAR codes.
d6d100dd
SM
1641 (bidi_resolve_explicit, bidi_resolve_weak):
1642 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1643 bidirectional text is supported only in multibyte buffers.
1644 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1645 it to initialize the frame_window_p member of struct bidi_it.
1646 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1647 (bidi_resolve_explicit, bidi_resolve_weak)
1648 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1649 bidi_it->nchars is non-positive.
1650 (bidi_level_of_next_char): Don't try to lookup the cache for the
1651 next/previous character if nothing is cached there yet, or if we
1652 were just reseat()'ed to a new position.
c40e2fb2 1653
0e14fe90
EZ
1654 * xdisp.c (set_cursor_from_row): Set start and stop points
1655 according to the row's direction when priming the loop that looks
1656 for the glyph on which to display cursor.
1657 (single_display_spec_intangible_p): Function deleted.
1658 (display_prop_intangible_p): Reimplement to call
1659 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1660 Accept 3 additional arguments needed by handle_display_spec.
1661 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1662 values: lists, `(when COND...)' forms, etc.
1663 (single_display_spec_string_p): Support property values that are
1664 lists with the argument STRING its top-level element.
1665 (display_prop_string_p): Fix the condition for processing a
1666 property that is a list to be consistent with handle_display_spec.
fec2107c 1667 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1668 last portion of handle_display_prop.
1669 (compute_display_string_pos): Accept additional argument
1670 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1671 value of a `display' property is a "replacing spec".
1672 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1673 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1674 the display property, but just return a value indicating whether
1675 the display property will replace the characters it covers.
1676 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1677 frame_window_p members of struct bidi_it.
d6d100dd
SM
1678 (compute_display_string_pos, compute_display_string_end):
1679 New functions.
fec2107c
EZ
1680 (push_it): Accept second argument POSITION, where pop_it should
1681 jump to continue iteration.
1682 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1683
fec2107c
EZ
1684 * keyboard.c (adjust_point_for_property): Adjust the call to
1685 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1686
1687 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1688 (bidi_init_it): Update prototypes.
1689 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1690 (compute_display_string_pos, compute_display_string_end):
1691 Declare prototypes.
fec2107c
EZ
1692 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1693 EMACS_INT.
fc6f18ce 1694
40087514 16952011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1696
57f53182
PE
1697 Malloc failure behavior now depends on size of allocation.
1698 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1699 * lisp.h: Change signatures accordingly.
1700 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1701 All callers changed. (Bug#8762)
1702
1703 * gnutls.c: Use Emacs's memory allocators.
1704 Without this change, the gnutls library would invoke malloc etc.
1705 directly, which causes problems on non-SYNC_INPUT hosts, and which
1706 runs afoul of improving memory_full behavior. (Bug#8761)
1707 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1708 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1709 xfree instead of the default malloc, realloc, free.
1710 (Fgnutls_boot): No need to check for memory allocation failure,
1711 since xmalloc does that for us.
1712
ac32cd99 1713 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1714 * category.c (hash_get_category_set):
1715 * ccl.c (ccl_driver):
1716 * charset.c (Fdefine_charset_internal):
1717 * charset.h (struct charset.hash_index):
1718 * composite.c (get_composition_id, gstring_lookup_cache)
1719 (composition_gstring_put_cache):
1720 * composite.h (struct composition.hash_index):
1721 * dispextern.h (struct image.hash):
1722 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1723 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1724 (hashfn_equal, hashfn_user_defined, make_hash_table)
1725 (maybe_resize_hash_table, hash_lookup, hash_put)
1726 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1727 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1728 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1729 * image.c (make_image, search_image_cache, lookup_image)
1730 (xpm_put_color_table_h):
1731 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1732 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1733 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1734 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1735 * alloc.c (allocate_vectorlike):
1736 Check for overflow in vector size calculations.
1737 * ccl.c (ccl_driver):
1738 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1739 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1740 need to be updated by these changes.
40087514
PE
1741 * fns.c (make_hash_table, maybe_resize_hash_table):
1742 Check for integer overflow with large hash tables.
0de4bb68
PE
1743 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1744 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1745 (SXHASH_REDUCE): New macro.
1746 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1747 Use it instead of discarding useful hash info with large hash values.
1748 (sxhash_float): New function.
1749 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1750 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1751 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1752 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1753 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1754 Adjust signatures to match updated version of code.
1755 (consing_since_gc): Now EMACS_INT, since a single hash table can
1756 use more than INT_MAX bytes.
1757
698d32e2
DN
17582011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1759
1760 Make it possible to build with GCC-4.6+ -O2 -flto.
1761
1762 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1763
fd6fa53f
SM
17642011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1765
1766 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1767 Call minibuffer-inactive-mode.
1768
864db017
JB
17692011-05-31 Juanma Barranquero <lekktu@gmail.com>
1770
1771 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1772 Update dependencies.
1773
2ad0baf4
DN
17742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1775
1776 * data.c (init_data): Remove code for UTS, this system is not
1777 supported anymore.
1778
4fcc2638
DN
17792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1780
1781 Don't force ./temacs to start in terminal mode.
1782
1783 * frame.c (make_initial_frame): Initialize faces in all cases, not
1784 only when CANNOT_DUMP is defined.
1785 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1786
c56e0fd5
DN
17872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1788
1789 * dispnew.c (add_window_display_history): Use const for the string
1790 pointer. Remove declaration, not needed.
1791
333d54da 17922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1793
55d4c1b2 1794 Use 'inline', not 'INLINE'.
333d54da 1795 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1796 * alloc.c, fontset.c (INLINE): Remove.
1797 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1798 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1799 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1800 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1801 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1802
738db178
DN
18032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1804
1805 Make it possible to run ./temacs.
1806
1807 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1808 syms_of_callproc does the same thing. Remove test for
1809 "initialized", do it in the caller.
1810 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1811
620c53a6
SM
18122011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1813
1814 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1815 (read_minibuf): Use get_minibuffer.
1816 (syms_of_minibuf): Use DEFSYM.
1817 (Qmetadata): New var.
1818 * data.c (Qbuffer): Don't make it static.
1819 (syms_of_data): Use DEFSYM.
1820
e003a292
PE
18212011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1824 (CCL_CODE_MIN): New macro.
1825
ed008a6d
PE
18262011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1827
3687c2ef
PE
1828 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1829
ed008a6d
PE
1830 * eval.c (Qdebug): Now static.
1831 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1832 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1833 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1834
d66c4c7c
CY
18352011-05-29 Chong Yidong <cyd@stupidchicken.com>
1836
1837 * image.c: Various fixes to ImageMagick code comments.
1838 (Fimagemagick_types): Doc fix.
1839
5fbc2025
PE
18402011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1841
0196f88a
PE
1842 Minor fixes prompted by GCC 4.6.0 warnings.
1843
1844 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1845
5fbc2025
PE
1846 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1847 (x_clipboard_manager_save_all): Move extern decl to ...
1848 * xterm.h: ... here, so that it can be checked for consistency.
1849
1dd3c2d9
CY
18502011-05-29 Chong Yidong <cyd@stupidchicken.com>
1851
1852 * xselect.c (x_clipboard_manager_save_frame)
1853 (x_clipboard_manager_save_all): New functions.
1854 (Fx_clipboard_manager_save): Lisp function deleted.
1855
1856 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1857 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1858
1859 * xterm.h: Update prototype.
1860
5ba6571d
WX
18612011-05-28 William Xu <william.xwl@gmail.com>
1862
1863 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1864 exiting (Bug#8239).
1865
3eaff834
JM
18662011-05-28 Jim Meyering <meyering@redhat.com>
1867
e1900994 1868 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1869 * fns.c (to_uchar): Define.
1870 (crypto_hash_function): Use it to convert some newly-signed
1871 variables to unsigned, to avoid sign-extension bugs. For example,
1872 without this change, (md5 "truc") would evaluate to
1873 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1874 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1875 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1876
0f6990a7
PE
18772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1878
1879 Integer overflow fixes.
c8a9ca5a 1880
08686060
PE
1881 * dbusbind.c: Serial number integer overflow fixes.
1882 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1883 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1884 to hold a serial number that is too large for a fixnum.
1885 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1886 Check for serial numbers out of range. Decode any serial number
59568bf0 1887 that was so large that it became a float. (Bug#8722)
08686060 1888
2d1fc3c7
PE
1889 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1890 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1891 Use XFASTINT rather than XUINT when numbers are nonnegative.
1892 (xd_append_arg, Fdbus_method_return_internal):
1893 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1894 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1895 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1896 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1897 (Bug#8722)
2d1fc3c7 1898
c8a9ca5a
PE
1899 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1900
519e1d69
PE
1901 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1902
30569699
PE
1903 ccl: add integer overflow checks
1904 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1905 (IN_INT_RANGE): New macros.
1906 (ccl_driver): Use them to check for integer overflow when
1907 decoding a CCL program. Many of the new checks are whether XINT (x)
1908 fits in int; it doesn't always, on 64-bit hosts. The new version
1909 doesn't catch all possible integer overflows, but it's an
847044ea 1910 improvement. (Bug#8719)
30569699 1911
c11285dc
PE
1912 * alloc.c (make_event_array): Use XINT, not XUINT.
1913 There's no need for unsigned here.
1914
fdccd48e
PE
1915 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1916 This follows up to the 2011-05-06 change that substituted uintptr_t
1917 for EMACS_INT. This case wasn't caught back then.
1918
37910ab2
PE
1919 Rework Fformat to avoid integer overflow issues.
1920 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1921 now (part of C89). Include <verify.h>.
1922 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1923 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1924 (Fformat): Avoid the prepass trying to compute sizes; it was only
1925 approximate and thus did not catch overflow reliably. Instead, walk
1926 through the format just once, formatting and computing sizes as we go,
1927 checking for integer overflow at every step, and allocating a larger
1928 buffer as needed. Keep track separately whether the format is
1929 multibyte. Keep only the most-recently calculated precision, rather
1930 than them all. Record whether each argument has been converted to
1931 string. Use EMACS_INT, not int, for byte and char and arg counts.
1932 Support field widths and precisions larger than INT_MAX. Avoid
1933 sprintf's undefined behavior with conversion specifications such as %#d
1934 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1935 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1936 formatting out-of-range floating point numbers with int
9173deec 1937 formats. (Bug#8668)
37910ab2 1938
2e6578fb
PE
1939 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1940
0ae6bdee
PE
1941 * data.c: Avoid integer truncation in expressions involving floats.
1942 * data.c: Include <intprops.h>.
1943 (arith_driver): When there's an integer overflow in an expression
1944 involving floating point, convert the integers to floating point
1945 so that the resulting value does not suffer from catastrophic
1946 integer truncation. For example, on a 64-bit host (* 4
1947 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1948 Do not rely on undefined behavior after integer overflow.
1949
de883a70
PE
1950 merge count_size_as_multibyte, parse_str_to_multibyte
1951 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1952 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1953 Check for integer overflow.
1954 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1955 since it's now a duplicate of the other. This is more of
1956 a character than a buffer op, so better that it's in character.c.
1957 * fns.c, print.c: Adjust to above changes.
1958
2ff916cb
PE
19592011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1960
1961 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1962
f1b54466
PE
19632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1964
fb1ac845
PE
1965 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1966 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1967 (x_clipboard_manager_save): Now static.
1968 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1969
f1b54466
PE
1970 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1971 (crypto_hash_function): Now static.
1972 Fix pointer signedness problems. Avoid unnecessary initializations.
1973
a9f737ee
CY
19742011-05-27 Chong Yidong <cyd@stupidchicken.com>
1975
1976 * termhooks.h (Vselection_alist): Make it terminal-local.
1977
1978 * terminal.c (create_terminal): Initialize it.
1979
1980 * xselect.c: Support for clipboard managers.
1981 (Vselection_alist): Move to termhooks.h as terminal-local var.
1982 (LOCAL_SELECTION): New macro.
1983 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1984 (symbol_to_x_atom): Remove gratuitous arg.
1985 (x_handle_selection_request, lisp_data_to_selection_data)
1986 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1987 (x_own_selection, x_get_local_selection, x_convert_selection):
1988 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1989 (some_frame_on_display): Delete unused function.
1990 (Fx_own_selection_internal, Fx_get_selection_internal)
1991 (Fx_disown_selection_internal, Fx_selection_owner_p)
1992 (Fx_selection_exists_p): New optional frame arg.
1993 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1994 (x_handle_selection_clear): Don't treat other terminals with the
1995 same keyboard specially. Use the terminal-local Vselection_alist.
1996 (x_clear_frame_selections): Use Frun_hook_with_args.
1997
1998 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1999
2000 * xterm.h: Add support for those atoms.
2001
e067f0c1
CY
20022011-05-26 Chong Yidong <cyd@stupidchicken.com>
2003
2004 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2005 (converted_selections, conversion_fail_tag): New global variables.
2006 (x_selection_request_lisp_error): Free the above.
2007 (x_get_local_selection): Remove unnecessary code.
2008 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2009 of converted selections stored in converted_selections.
2010 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2011 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2012 (x_convert_selection): New function.
2013 (x_handle_selection_event): Simplify.
2014 (x_get_foreign_selection): Don't ignore incoming requests while
2015 waiting for an answer; this will fail when we implement
2016 SAVE_TARGETS, and seems unnecessary anyway.
2017 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2018 (Vx_sent_selection_functions): Doc fix.
2019
0f4aebc0
LL
20202011-05-26 Leo Liu <sdl.web@gmail.com>
2021
2022 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2023
e61124cd
YM
20242011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2025
2026 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2027
2028 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2029 for fringe update if it has periodic bitmap.
2030 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2031 and fringe_bitmap_periodic_p.
2032
2033 * fringe.c (get_fringe_bitmap_data): New function.
2034 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2035 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2036 row. Mark glyph row for fringe update if periodicity changed.
2037
2038 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2039 for fringe update unless it has periodic bitmap.
2040
f16d9837
KH
20412011-05-25 Kenichi Handa <handa@m17n.org>
2042
2043 * xdisp.c (get_next_display_element): Set correct it->face_id for
2044 a static composition.
2045
e1b90ef6
LL
20462011-05-24 Leo Liu <sdl.web@gmail.com>
2047
2048 * deps.mk (fns.o):
2049 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2050
2051 * fns.c (crypto_hash_function, Fsha1): New function.
2052 (Fmd5): Use crypto_hash_function.
2053 (syms_of_fns): Add Ssha1.
2054
7400048f
PE
20552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2056
2057 * gnutls.c: Remove unused macros.
2058 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2059 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2060 Remove macros that are defined and never used.
2061 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2062
abb71cf4
CY
20632011-05-22 Chong Yidong <cyd@stupidchicken.com>
2064
2065 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2066 (Fx_get_selection_internal): Minor cleanup.
2067 (Fx_own_selection_internal): Rename arguments for consistency with
2068 select.el.
2069
6307db39
PE
20702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2073
f3d4e0a4
CY
20742011-05-22 Chong Yidong <cyd@stupidchicken.com>
2075
2076 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2077
4d8ade89
YM
20782011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2079
2080 * dispnew.c (scrolling_window): Don't exclude the case that the
2081 last enabled row in the desired matrix touches the bottom boundary.
2082
32078c8d
GM
20832011-05-21 Glenn Morris <rgm@gnu.org>
2084
2085 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2086 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2087 and add some more files.
32078c8d 2088
7285dc67
EZ
20892011-05-20 Eli Zaretskii <eliz@gnu.org>
2090
2091 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2092 report_file_error introduced by the change from 2011-05-07.
2093
89d1bd22
PE
20942011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2095
2096 * systime.h (Time): Define only if emacs is defined.
2097 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2098 where the include path doesn't have X11/X.h by default. See
2099 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2100
e23640bb 21012011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2102
2103 * composite.c (find_automatic_composition): Fix previous change.
2104
b9704ad9
GM
21052011-05-20 Glenn Morris <rgm@gnu.org>
2106
2107 * lisp.mk: New file, split from Makefile.in.
2108 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2109 (shortlisp): Remove.
2110 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2111
4a720484
GM
21122011-05-19 Glenn Morris <rgm@gnu.org>
2113
2114 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2115 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2116 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2117 (lisp): Set the order to that of loadup.el.
2118 (shortlisp): Make it a copy of $lisp.
2119 (SOME_MACHINE_LISP): Remove.
2120 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2121 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2122
a28d4396
KH
21232011-05-18 Kenichi Handa <handa@m17n.org>
2124
2125 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2126 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2127 (find_automatic_composition): Mostly rewrite for efficiency.
2128
a2b1fa8e
JB
21292011-05-18 Juanma Barranquero <lekktu@gmail.com>
2130
2131 * makefile.w32-in: Update dependencies.
2132
8e1f5610
CS
21332011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2134
2135 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2136 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2137
7025ee00 21382011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2139
cdfa6eab
PE
2140 Fix some integer overflow issues, such as string length overflow.
2141
06d6db33
PE
2142 * insdel.c (count_size_as_multibyte): Check for string overflow.
2143
2b4560a8
PE
2144 * character.c (lisp_string_width): Check for string overflow.
2145 Use EMACS_INT, not int, for string indexes and lengths; in
2146 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2147 the resulting string length overflows an EMACS_INT; instead,
2148 report a string overflow if no precision given. When checking for
2149 precision exhaustion, use a check that cannot possibly have
2150 integer overflow. (Bug#8675)
2151 * character.h (lisp_string_width): Adjust to new signature.
2152
cb93f9be
PE
2153 * alloc.c (string_overflow): New function.
2154 (Fmake_string): Use it. This doesn't change behavior, but saves
2155 a few bytes and will simplify future changes.
2156 * character.c (string_escape_byte8): Likewise.
2157 * lisp.h (string_overflow): New decl.
2158
1a1f3366
PE
2159 Fixups, following up to the user-interface timestamp change.
2160 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2161 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2162 * msdos.c (mouse_get_pos): Likewise.
2163 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2164 * w32gui.h (Time): Define by including "systime.h" rather than by
2165 declaring it ourselves. (Bug#8664)
2166
d4e3e4d3
PE
2167 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2168 * image.c (clear_image_cache): Likewise.
2169
f6a24d19
PE
2170 * term.c (term_mouse_position): Don't assume time_t wraparound.
2171
08dc5ae6
PE
2172 Be more systematic about user-interface timestamps.
2173 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2174 and sometimes 'EMACS_UINT', to represent these timestamps.
2175 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2176 This makes the code easier to follow, and makes it easier to catch
2177 integer overflow bugs such as Bug#8664.
2178 * frame.c (Fmouse_position, Fmouse_pixel_position):
2179 Use Time, not unsigned long, for user-interface timestamps.
2180 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2181 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2182 * keyboard.h (last_event_timestamp): Likewise.
2183 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2184 * menu.h (xmenu_show): Likewise.
2185 * term.c (term_mouse_position): Likewise.
2186 * termhooks.h (struct input_event.timestamp): Likewise.
2187 (struct terminal.mouse_position_hook): Likewise.
2188 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2189 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2190 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2191 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2192 what it was before.
2193 * menu.h, termhooks.h: Include "systime.h", for Time.
2194
8e55734a
PE
2195 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2196 Don't assume that the difference between two unsigned long values
2197 can fit into an integer. At this point, we know button_down_time
2198 <= event->timestamp, so the difference must be nonnegative, so
2199 there's no need to cast the result if double-click-time is
2200 nonnegative, as it should be; check that it's nonnegative, just in
2201 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2202 apart (about 25 days). (Bug#8664)
8e55734a 2203
841f1b75 2204 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2205 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2206
3e26f69c
PE
2207 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2208 that always fit in int. Use a sentinel instead of a counter, to
2209 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2210 * frame.h (struct frame): Use int for menu_bar_items_used
2211 instead of EMACS_INT, since it always fits in int.
3e26f69c 2212
5cc152c0
PE
2213 * menu.c (grow_menu_items): Check for int overflow.
2214
d89eb65e
PE
2215 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2216
5235bd3e
PE
2217 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2218 Before, the code was not consistent. These values cannot exceed
2219 2**31 - 1 so there's no need to make them unsigned.
2220 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2221 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2222 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2223 as modifiers.
2224 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2225
bc827e23
PE
2226 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2227 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2228 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2229 presumably because the widths might not match.
2230
78eb494e
PE
2231 * window.c (size_window): Avoid needless test at loop start.
2232
04f2d78b
CB
22332011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2234
2235 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2236
d2fc7e3d 22372011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2238
2239 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2240
d2fc7e3d 22412011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2242
2243 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2244 `width' to `bar_area_x' and `bar_area_width', respectively.
2245 (x_scroll_run): Take account of fringe background extension.
2246
04f2d78b
CB
2247 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2248 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2249 `bar_area_width', respectively.
2250 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2251 background extension.
2252
79b70037
GM
22532011-05-10 Jim Meyering <meyering@redhat.com>
2254
2255 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2256
2f142cc5
JB
22572011-05-10 Juanma Barranquero <lekktu@gmail.com>
2258
2259 * image.c (Finit_image_library): Return t for built-in image types,
2260 like pbm and xbm. (Bug#8640)
2261
57679c86
AS
22622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2263
2264 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2265
888c9e86
EZ
22662011-05-07 Eli Zaretskii <eliz@gnu.org>
2267
b0512a1d
EZ
2268 * w32console.c (Fset_screen_color): Doc fix.
2269 (Fget_screen_color): New function.
2270 (syms_of_ntterm): Defsubr it.
2271
7285dc67
EZ
2272 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2273 unlink the temporary file if Fcall_process didn't create it in the
2274 first place.
2275 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2276 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2277 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2278 cue to call_process_cleanup not to close that handle.
2279
4d3fcc8e
BK
22802011-05-07 Ben Key <bkey76@gmail.com>
2281
2282 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2283 one of two shell specific rules, either bootstrap-temacs-CMD or
2284 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2285 to the previous implementation of the bootstrap-temacs rule.
2286 The bootstrap-temacs-CMD rule is similar to the previous
2287 implementation of the bootstrap-temacs rule except that it
2288 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2289 variable.
2290
2291 These changes, along with some changes to nt/configure.bat,
2292 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2293 earlier fix to add support for --cflags and --ldflags options
2294 that include quotes so that it works whether make uses cmd or
2295 sh as the shell.
2296
b4289b64
MA
22972011-05-06 Michael Albinus <michael.albinus@gmx.de>
2298
2299 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2300 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2301 is a constant.
2302 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2303 a string. Handle both cases.
2304 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2305 (Fdbus_register_method): Use Qinvalid_function.
2306
af4c0e28
JB
23072011-05-06 Juanma Barranquero <lekktu@gmail.com>
2308
2309 * makefile.w32-in: Update dependencies.
2310 (LISP_H): Add inttypes.h and stdin.h.
2311 (PROCESS_H): Add unistd.h.
2312
c51453d9
EZ
23132011-05-06 Eli Zaretskii <eliz@gnu.org>
2314
2315 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2316 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2317
8ff0ac3c 23182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2319
4c4b566b
PE
2320 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2321
aab2b9b5
PE
2322 * term.c (vfatal): Remove stray call to va_end.
2323 It's not needed and the C Standard doesn't allow it here anyway.
2324
c378da0b
PE
2325 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2326 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2327
288b08c7
PE
2328 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2329 bytes.
2330
e3601888
PE
2331 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2332
db6c0e74
PE
2333 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2334
dd5963ea
PE
2335 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2336
88c9450f
PE
2337 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2338
2f9442b8
PE
2339 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2340
c032b5f8
PE
2341 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2342 * charset.c (Fdefine_charset_internal): Don't initialize
2343 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2344 32-bit int (Bug#8600).
a108c10b
PE
2345
2346 * lread.c (read_integer): Be more consistent with string-to-number.
2347 Use string_to_number to do the actual conversion; this avoids
2348 rounding errors and fixes some other screwups. Without this fix,
2349 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2350 (digit_to_number): Move earlier, for benefit of read_integer.
2351 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2352 not a digit in any supported base. (Bug#8602)
a108c10b 2353
ad5f9eea
PE
2354 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2355
aec1708a
PE
2356 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2357 to match comment at start of function. This also removes a
2358 GCC warning about overflow in a 32+64-bit port.
2359
47be4ab5
PE
2360 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2361
371cac43
PE
2362 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2363 Reported by Stefan Monnier in
2364 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2365 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2366 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2367
d01a7826
PE
2368 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2369 (EMACS_UINTPTR): Likewise, with uintptr_t.
2370
7fd47d5c
PE
2371 * lisp.h: Prefer 64-bit EMACS_INT if available.
2372 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2373 on 32-bit hosts that have 64-bit int, so that they can access
2374 large files.
122b0c86
PE
2375 However, temporarily disable this change unless the temporary
2376 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2377
8727937b
PE
2378 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2379
8ac068ac
PE
2380 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2381 This removes an assumption that EMACS_INT and long are the same
2382 width as pointers. The assumption is true for Emacs porting targets
2383 now, but we want to make other targets possible.
2384 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2385 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2386 In the rest of the code, change types of integers that hold casted
2387 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2388 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2389 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2390 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2391 No need to cast type when ORing.
2392 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2393 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2394 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2395 assume EMACS_INT is the same width as char *.
2396 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2397 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2398 Remove no-longer-needed casts.
2399 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2400 (xg_tool_bar_help_callback, xg_make_tool_item):
2401 Use EMACS_INTPTR to hold an integer
2402 that will be cast to void *; this can avoid a GCC warning
2403 if EMACS_INT is not the same width as void *.
2404 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2405 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2406 (current_message_1, set_message_1):
2407 Use a local to convert to proper width without a cast.
2408 * xmenu.c (dialog_selection_callback): Likewise.
2409
ede49d71
PE
2410 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2411 Also, don't assume VALBITS / RAND_BITS is less than 5,
2412 and don't rely on undefined behavior when shifting a 1 left into
2413 the sign bit.
2414 * lisp.h (get_random): Change signature to match.
2415
2f30ecd0
PE
2416 * lread.c (hash_string): Use size_t, not int, for hash computation.
2417 Normally we prefer signed values; but hashing is special, because
2418 it's better to use unsigned division on hash table sizes so that
2419 the remainder is nonnegative. Also, size_t is the natural width
2420 for hashing into memory. The previous code used 'int', which doesn't
2421 retain enough info to hash well into very large tables.
2422 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2423
2a866e7b
PE
2424 * dbusbind.c: Don't possibly lose pointer info when converting.
2425 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2426 Use XPNTR rather than XHASH, so that the high-order bits of
2427 the pointer aren't lost when converting through void *.
2428
51639eac
PE
2429 * eval.c (Fautoload): Don't double-shift a pointer.
2430
92394119
PE
2431 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2432
dbdb9a7c
JB
24332011-05-06 Juanma Barranquero <lekktu@gmail.com>
2434
2435 * gnutls.c (DEF_GNUTLS_FN):
2436 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2437
db7a0b4f
AS
24382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2439
2440 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2441 marker. (Bug#8610)
2442
f7ff1b0f 24432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2444
2445 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2446 New version that can reserve upto 2GB of heap space.
2447
f7ff1b0f 24482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2449
2450 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2451
639c109b
TZ
24522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2453
2454 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2455 `gnutls_certificate_set_x509_key_file'.
2456
d2127135
JB
24572011-05-05 Juanma Barranquero <lekktu@gmail.com>
2458
2459 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2460 Update dependencies.
2461
e968f4f3
JB
24622011-05-04 Juanma Barranquero <lekktu@gmail.com>
2463
2464 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2465 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2466 Remove unused parameter `fildes'.
2467 * process.c (read_process_output, send_process): Don't pass it.
2468
84d358f0
JB
24692011-05-04 Juanma Barranquero <lekktu@gmail.com>
2470
2471 Fix previous change: the library cache is defined in w32.c.
2472 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2473 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2474
0898ca10
JB
24752011-05-04 Juanma Barranquero <lekktu@gmail.com>
2476
2477 Implement dynamic loading of GnuTLS on Windows.
2478
2479 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2480 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2481 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2482 Declare.
2483
2484 * gnutls.c (Qgnutls_dll): Define.
2485 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2486 (gnutls_*): Declare function pointers.
2487 (init_gnutls_functions): New function to initialize function pointers.
2488 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2489 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2490 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2491 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2492 (emacs_gnutls_write, emacs_gnutls_read)
2493 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2494 (Fgnutls_available_p): New function.
2495 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2496 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2497 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2498
2499 * image.c: Include w32.h.
2500 (Vimage_type_cache): Delete.
2501 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2502 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2503 (w32_delayed_load): Move to w32.c.
2504
2505 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2506
2507 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2508 (w32_delayed_load): Move from image.c. When loading a library, record
2509 its filename in the :loaded-from property of the library id.
2510 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2511 Initialize and staticpro them.
2512 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2513
2514 * process.c: Include lisp.h before w32.h, not after.
2515 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2516 instead of gnutls_record_check_pending.
2517
2518 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2519
ff4de4aa
TZ
25202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2521
2522 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2523 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2524 as passed in.
2525
abe95abb
JD
25262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2527
2528 * xterm.c (x_set_frame_alpha): Do not set property on anything
2529 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2530
e16e55d4
JB
25312011-05-02 Juanma Barranquero <lekktu@gmail.com>
2532
2533 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2534
bafcf6a5
JB
25352011-05-02 Juanma Barranquero <lekktu@gmail.com>
2536
2537 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2538 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2539 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2540 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2541 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2542 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2543 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2544 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2545 (Qgnutls_bootprop_callbacks_verify): Make static.
2546
e7a6747f
AS
25472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2548
19ed11ba
AS
2549 * callproc.c: Indentation fixup.
2550
e7a6747f 2551 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2552 (wait_for_termination, interruptible_wait_for_termination):
2553 Move after wait_for_termination_1.
e7a6747f 2554
1ef14cb4
LMI
25552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2556
2557 * sysdep.c (interruptible_wait_for_termination): New function
2558 which is like wait_for_termination, but allows keyboard
2559 interruptions.
2560
2561 * callproc.c (Fcall_process): Add (:file "file") as an option for
2562 the STDOUT buffer.
2563 (Fcall_process_region): Ditto.
2564
330d880c
EZ
25652011-04-30 Eli Zaretskii <eliz@gnu.org>
2566
8db90b73
EZ
2567 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2568 rather than `XVECTOR (FOO)->size'.
2569
330d880c
EZ
2570 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2571 inttypes.h, as a gnulib replacement is used if it not available in
2572 system headers.
2573
15cbd324
EZ
25742011-04-21 Eli Zaretskii <eliz@gnu.org>
2575
2576 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2577 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2578 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2579
2580 * coding.c (coding_alloc_by_realloc): Error out if destination
2581 will grow beyond MOST_POSITIVE_FIXNUM.
2582 (decode_coding_emacs_mule): Abort if there isn't enough place in
2583 charbuf for the composition carryover bytes. Reserve an extra
2584 space for up to 2 characters produced in a loop.
2585 (decode_coding_iso_2022): Abort if there isn't enough place in
2586 charbuf for the composition carryover bytes.
2587
25882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2589
ae940cca
EZ
2590 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2591 aborting when %lld or %lll format is passed.
2592 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2593 %llo or %llx format is passed. (Bug#8545)
2594
03ab8921
EZ
2595 * window.c (window_scroll_line_based): Use a marker instead of
2596 simple variables to record original value of point. (Bug#7952)
2597
afda1437
EZ
2598 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2599 produced by %s or %c overflows available buffer space. (Bug#8545)
2600
f76dee0c
PE
26012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2604 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2605
fdc5744d
JB
26062011-04-28 Juanma Barranquero <lekktu@gmail.com>
2607
2608 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2609
638f053a
JB
26102011-04-28 Juanma Barranquero <lekktu@gmail.com>
2611
2612 * keyboard.c (Qdelayed_warnings_hook): Define.
2613 (command_loop_1): Run `delayed-warnings-hook'
2614 if Vdelayed_warnings_list is non-nil.
2615 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2616 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2617
d178f871
EZ
26182011-04-28 Eli Zaretskii <eliz@gnu.org>
2619
2620 * doprnt.c (doprnt): Don't return value smaller than the buffer
2621 size if the message was truncated. (Bug#8545).
2622
b124fd93
JB
26232011-04-28 Juanma Barranquero <lekktu@gmail.com>
2624
2625 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2626 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2627
e810457d
PE
26282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2629
2630 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2631
ea51cceb
JB
26322011-04-27 Juanma Barranquero <lekktu@gmail.com>
2633
2634 * makefile.w32-in: Update dependencies.
2635
94dcfacf
EZ
26362011-04-27 Eli Zaretskii <eliz@gnu.org>
2637
2638 Improve `doprnt' and its usage. (Bug#8545)
2639 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2640 `format_end'. Remove support for %l as a conversion specifier.
2641 Don't use xrealloc. Improve diagnostics when the %l size modifier
2642 is used. Update the commentary.
2643
2644 * eval.c (verror): Simplify calculation of size_t.
2645
2646 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2647 messages.
2648
f61f41d7
PE
26492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2650
2651 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2652 change.
2653
96fb4434
PE
26542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2655
2656 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2657 This makes this file independent of the recent pseudovector change.
2658
671875da 26592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2660
69e9b5a3
PE
2661 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2662
b5f869a7 2663 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2664 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2665 Remove unused local.
c8926152 2666 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2667
841a1577 2668 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2669 GCC 4.6.0 optimizes based on type-based alias analysis.
2670 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2671 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2672 != &v->size, and therefore "v->size = 1; b->size = 2; return
2673 v->size;" must therefore return 1. This assumption is incorrect
2674 for Emacs, since it type-puns struct Lisp_Vector * with many other
2675 types. To fix this problem, this patch adds a new type struct
f904488f 2676 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2677 and pseudovectors, and helps optimizing compilers not get fooled
2678 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2679 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2680 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2681 the size member.
eab3844f
PE
2682 (XSETPVECTYPE): Rewrite in terms of new macro.
2683 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2684 This is a bit clearer, and further avoids the possibility of
2685 undesirable aliasing.
2686 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2687 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2688 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2689 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2690 (ASIZE): Now uses header.size rather than size.
2691 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2692 to avoid the hassle of writing XVECTOR (foo)->header.size.
2693 (struct vectorlike_header): New type.
eab3844f
PE
2694 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2695 object, to help avoid aliasing.
2696 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2697 (SUBRP): Likewise, since Lisp_Subr is a special case.
2698 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2699 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2700 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2701 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2702 changed to be "header.size" and "header.next".
2703 * buffer.h (struct buffer): Likewise.
2704 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2705 * frame.h (struct frame): Likewise.
2706 * process.h (struct Lisp_Process): Likewise.
2707 * termhooks.h (struct terminal): Likewise.
2708 * window.c (struct save_window_data, struct saved_window): Likewise.
2709 * window.h (struct window): Likewise.
2710 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2711 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2712 * buffer.c (init_buffer_once): Likewise.
2713 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2714 special case.
2715 * process.c (Fformat_network_address): Use local var for size,
2716 for brevity.
2717
0df1eac5
PE
2718 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2719
847ab9d1 2720 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2721 * data.c (atof): Remove decl; no longer used or needed.
2722 (digit_to_number): Move to lread.c.
2723 (Fstring_to_number): Use new string_to_number function, to be
2724 consistent with how the Lisp reader treats infinities and NaNs.
2725 Do not assume that floating-point numbers represent EMACS_INT
2726 without losing information; this is not true on most 64-bit hosts.
2727 Avoid double-rounding errors, by insisting on integers when
2728 parsing non-base-10 numbers, as the documentation specifies.
2729 * lisp.h (string_to_number): New decl, replacing ...
2730 (isfloat_string): Remove.
bc0a5c13 2731 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2732 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2733 appears to have been a coding error. Similarly, do not accept
2734 strings like +-1e0 as floating point numbers. Do not report
2735 overflow for integer overflows unless the base is not 10 which
2736 means we have no simple and reliable way to continue.
2737 Break out the floating-point parsing into a new
2738 function string_to_number, so that Fstring_to_number parses
2739 floating point numbers consistently with the Lisp reader.
04f2d78b 2740 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2741 (E_CHAR, EXP_INT): Remove, replacing with ...
2742 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2743 (string_to_number): New function, replacing isfloat_string.
2744 This function checks for valid syntax and produces the resulting
2745 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2746 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2747 so that overflow for non-base-10 numbers is reported only when
2748 there's no portable and simple way to convert to floating point.
452f4150 2749
67769ffc
PE
2750 * textprop.c (set_text_properties_1): Rewrite for clarity,
2751 and to avoid GCC warning about integer overflow.
2752
c20db43f
PE
2753 * intervals.h (struct interval): Use EMACS_INT for members
2754 where EMACS_UINT might cause problems. See
2755 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2756 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2757 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2758 All uses changed.
37aa2f85
PE
2759 (offset_intervals): Tell GCC not to worry about length overflow
2760 when negating a negative length.
c20db43f 2761
2538aa2f
PE
2762 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2763 (overrun_check_free): Likewise.
2764
f2d3008d
PE
2765 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2766 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2767 word size.
2768
ec8df744
PE
2769 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2770 (gnutls_make_error): Rename local to avoid shadowing.
2771 (gnutls_emacs_global_deinit): ifdef out; not used.
2772 (Fgnutls_boot): Use const for pointer to readonly storage.
2773 Comment out unused local. Fix pointer signedness problems.
2774
640ee02d
PE
2775 * lread.c (openp): Don't stuff size_t into an 'int'.
2776 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2777 about possible signed overflow.
2778
6048fb2a
PE
2779 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2780 (GDK_KEY_g): Don't define if already defined.
2781 (xg_prepare_tooltip): Avoid pointer signedness problem.
2782 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2783
fa3c87e1
PE
2784 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2785 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2786
2172544b
PE
2787 * xfns.c (Fx_window_property): Simplify a bit,
2788 to make a bit faster and to avoid GCC 4.6.0 warning.
2789 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2790
9b821a21
PE
2791 * fns.c (internal_equal): Don't assume size_t fits in int.
2792
3c616cfa
PE
2793 * alloc.c (compact_small_strings): Tighten assertion a little.
2794
c2982e87
PE
2795 Replace pEd with more-general pI, and fix some printf arg casts.
2796 * lisp.h (pI): New macro, generalizing old pEd macro to other
2797 conversion specifiers. For example, use "...%"pI"d..." rather
2798 than "...%"pEd"...".
2799 (pEd): Remove. All uses replaced with similar uses of pI.
2800 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2801 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2802 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2803 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2804 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2805 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2806 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2807 64-bit hosts.
2808 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2809 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2810 * print.c (safe_debug_print, print_object): Likewise.
2811 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2812 to int.
6f04d126
PE
2813 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2814 avoiding the 0 flag, which is not portable.
c2982e87
PE
2815 * process.c (Fmake_network_process): Use pI to avoid cast.
2816 * region-cache.c (pp_cache): Likewise.
2817 * xdisp.c (decode_mode_spec): Likewise.
2818 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2819 behavior on 64-bit hosts with printf arg.
6f04d126 2820 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2821 (x_stop_queuing_selection_requests): Likewise.
2822 (x_get_window_property): Don't truncate byte count to an 'int'
2823 when tracing.
0b432f21 2824
5e073ec7
PE
2825 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2826 here, since it parses constructs like leading '-' and spaces,
2827 which are not wanted; and it overflows with large numbers.
2828 Instead, simply match F[0-9]+, which is what is wanted anyway.
2829
36372bf9
PE
2830 * alloc.c: Remove unportable assumptions about struct layout.
2831 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2832 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2833 (allocate_vectorlike, make_pure_vector): Use the new macros,
2834 plus offsetof, to remove unportable assumptions about struct layout.
2835 These assumptions hold on all porting targets that I know of, but
2836 they are not guaranteed, they're easy to remove, and removing them
2837 makes further changes easier.
2838
0b432f21
PE
2839 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2840 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2841 (string_overrun_cookie): Now const. Use initializers that
2842 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2843 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2844 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2845 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2846 multiple of sizeof (EMACS_INT); it need not be, if
2847 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2848 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2849
895009e1
JB
28502011-04-26 Juanma Barranquero <lekktu@gmail.com>
2851
2852 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2853
6a7a1b0b
TZ
28542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2855
2856 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2857 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2858 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2859
841a1577 28602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2861
2862 * lisp.h (Qdebug): List symbol.
895009e1 2863 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2864 * keyboard.c (debug-on-event): New variable.
2865 (handle_user_signal): Break into debugger when debug-on-event
2866 matches the current signal symbol.
2867
f2d3ba6f
DN
28682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2869
2870 * alloc.c (check_sblock, check_string_bytes)
2871 (check_string_free_list): Convert to standard C.
2872
42ce4c63
TZ
28732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2874
2875 * w32.c (emacs_gnutls_push): Fix typo.
2876
825cd63c
EZ
28772011-04-25 Eli Zaretskii <eliz@gnu.org>
2878
fb11d64d
EZ
2879 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2880 "cast to pointer from integer of different size".
2881
825cd63c
EZ
2882 Improve doprnt and its use in verror. (Bug#8545)
2883 * doprnt.c (doprnt): Document the set of format control sequences
2884 supported by the function. Use SAFE_ALLOCA instead of always
2885 using `alloca'.
2886
2887 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2888 is one byte too soon. Don't use xrealloc; instead xfree and
2889 xmalloc anew.
2890
e061a11b
TZ
28912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2892
2893 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2894 callbacks stage.
2895
2896 * gnutls.c: Renamed global_initialized to
2897 gnutls_global_initialized. Added internals for the
2898 :verify-hostname-error, :verify-error, and :verify-flags
2899 parameters of `gnutls-boot' and documented those parameters in the
2900 docstring. Start callback support.
9173deec
JB
2901 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2902 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2903 on error. Return error code.
e061a11b
TZ
2904 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2905 (emacs_gnutls_read): Likewise.
2906 (Fgnutls_boot): Return handshake error code.
2907 (emacs_gnutls_handle_error): New function.
2908 (wsaerror_to_errno): Likewise.
2909
2910 * w32.h (emacs_gnutls_pull): Add prototype.
2911 (emacs_gnutls_push): Likewise.
2912
2913 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2914 (emacs_gnutls_push): Likewise.
2915
29162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2917
2918 * process.c (wait_reading_process_output): Check if GnuTLS
2919 buffered some data internally if no FDs are set for TLS
2920 connections.
2921
2922 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2923 (LIBS): Link to USER_LIBS.
2924 ($(BLD)/gnutls.$(0)): New target.
2925
fa6996bc
EZ
29262011-04-24 Eli Zaretskii <eliz@gnu.org>
2927
eb35682e
EZ
2928 * xdisp.c (handle_single_display_spec): Rename the
2929 display_replaced_before_p argument into display_replaced_p, to
2930 make it consistent with the commentary. Fix typos in the
2931 commentary.
2932
e2ad650c
EZ
2933 * textprop.c (syms_of_textprop): Remove dead code.
2934 (copy_text_properties): Delete obsolete commentary about an
2935 interface that was deleted long ago. Fix typos in the description
2936 of arguments.
2937
1b2de274
EZ
2938 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2939 to changes in oldXMenu/XMenu.h from 2011-04-16.
2940 <menu_help_message, prev_menu_help_message>: Constify.
2941 (IT_menu_make_room): menu->help_text is now `const char **';
2942 adjust.
2943
2944 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2945 to changes in oldXMenu/XMenu.h from 2011-04-16.
2946 (struct XMenu): Declare `help_text' `const char **'.
2947
2948 * xfaces.c <Qunspecified>: Make extern again.
2949
2950 * syntax.c: Include sys/types.h before including regex.h, as
2951 required by Posix.
2952
762b15be
EZ
2953 * doc.c (get_doc_string): Improve the format passed to `error'.
2954
2955 * doprnt.c (doprnt): Improve commentary.
2956
2957 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2958
2959 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2960 them with etags.
2961
f1052e5d
EZ
2962 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2963 changes in globals.h immediately force recompilation.
762b15be
EZ
2964 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2965 $(CURDIR)/s/ms-w32.h.
2966 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2967
fa6996bc
EZ
2968 * character.c (Fchar_direction): Function deleted.
2969 (syms_of_character): Don't defsubr it.
2970 <char-direction-table>: Deleted.
2971
e6c3da20
EZ
29722011-04-23 Eli Zaretskii <eliz@gnu.org>
2973
2974 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2975 * doprnt.c: Include limits.h.
2976 (SIZE_MAX): New macro.
04f2d78b
CB
2977 (doprnt): Return a size_t value. 2nd arg is now size_t.
2978 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2979 Improve overflow protection. Support `l' modifier for integer
2980 conversions. Support %l conversion. Don't assume an EMACS_INT
2981 argument for integer conversions and for %c.
2982
2983 * lisp.h (doprnt): Restore prototype.
2984
2985 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2986 $(SRC)/character.h.
2987
2988 * Makefile.in (base_obj): Add back doprnt.o.
2989
2990 * deps.mk (doprnt.o): Add back prerequisites.
2991 (callint.o): Depend on character.h.
2992
2993 * eval.c (internal_lisp_condition_case): Include the handler
2994 representation in the error message.
2995 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2996 when breaking from the loop.
2997
2998 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2999
3000 * callint.c (Fcall_interactively): When displaying error message
3001 about invalid control letter, pass the character's codepoint, not
3002 a pointer to its multibyte form. Improve display of the character
3003 in octal and display also its hex code.
3004
3005 * character.c (char_string): Use %x to display the (unsigned)
3006 codepoint of an invalid character, to avoid displaying a bogus
3007 negative value.
3008
3009 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3010 `error', not SYMBOL_NAME itself.
3011
3012 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3013 character arguments to `error'.
3014
3015 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3016 to `error' in error message about FINAL_CHAR argument. Make sure
3017 FINAL_CHAR is a character, and use %c when it is passed as
3018 argument to `error'.
3019
4ffd0d6b 30202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3021
3022 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3023
3024 * w32.c: Include <time.h>.
3025 (sys_localtime): New function.
3026
4ffd0d6b 30272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3028
3029 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3030
4ffd0d6b 3031 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3032
4ffd0d6b 30332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3034
4ffd0d6b
GM
3035 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3036 zombies (Bug#8467).
aac0c6e3 3037
04c56954
EZ
30382011-04-19 Eli Zaretskii <eliz@gnu.org>
3039
3040 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3041 gl_state.e_property when gl_state.object is Qt.
3042
3043 * insdel.c (make_gap_larger): Remove limitation of buffer size
3044 to <= INT_MAX.
3045
16a43933
CY
30462011-04-18 Chong Yidong <cyd@stupidchicken.com>
3047
3048 * xdisp.c (lookup_glyphless_char_display)
3049 (produce_glyphless_glyph): Handle cons cell entry in
3050 glyphless-char-display.
3051 (Vglyphless_char_display): Document it.
3052
3053 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3054 glyphless-char-display.
3055
4581706e
CY
30562011-04-17 Chong Yidong <cyd@stupidchicken.com>
3057
3058 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3059
3060 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3061
3062 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3063 definition for no-X builds.
3064
4887c6e2 30652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3066
fd35b6f9
PE
3067 Static checks with GCC 4.6.0 and non-default toolkits.
3068
5c1ccb01
PE
3069 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3070
006c5daa
PE
3071 * process.c (keyboard_bit_set): Define only if SIGIO.
3072 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3073 (send_process): Repair possible setjmp clobbering.
3074
efc736d3
PE
3075 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3076
4e2fe2e6
PE
3077 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3078
f97334a2
PE
3079 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3080
4e75f29d
PE
3081 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3082 Define only if needed.
3083
90efadd1
PE
3084 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3085 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3086 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3087
3c647824
PE
3088 * dispextern.h (struct redisplay_interface): Rename param
3089 to avoid shadowing.
e264f262 3090 * termhooks.h (struct terminal): Likewise.
761383f4 3091 * xterm.c (xembed_send_message): Likewise.
3c647824 3092
b58c5c4a
PE
3093 * insdel.c (make_gap_smaller): Define only if
3094 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3095
cad59032
PE
3096 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3097 it.
3098
c339dc2e
PE
3099 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3100 so that we aren't warned about unused symbols.
3101
91a3e27b
PE
3102 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3103
399c71d3 3104 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3105
8ffc96f5
PE
3106 * xfns.c (x_real_positions): Mark locals as initialized.
3107
eef9bc79
PE
3108 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3109
098db9dd
PE
3110 * xterm.c: Fix problems found by static analysis with other toolkits.
3111 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3112 (x_dispatch_event): Declare static if USE_GTK, and
3113 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3114 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3115 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3116 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3117 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3118
eb18f6cc
PE
3119 * xmenu.c (menu_help_callback): Pointer type fixes.
3120 Use const pointers when pointing at readonly data. Avoid pointer
3121 signedness clashes.
3122 (FALSE): Remove unused macro.
3123 (update_frame_menubar): Remove unused decl.
3124
1fe72bf8
PE
3125 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3126
60d9e1db
PE
3127 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3128 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3129 (single_menu_item): Rename local to avoid shadowing.
3130
39261c26
PE
3131 * keyboard.c (make_lispy_event): Remove unused local var.
3132
018c5e19
PE
3133 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3134 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3135
63d2b86e
PE
3136 * bitmaps: Change bitmaps from unsigned char back to the X11
3137 compatible char. Avoid the old compiler warnings about
3138 out-of-range initializers by using, for example, '\xab' rather
3139 than 0xab.
3140
aefd87e1
PE
3141 * xgselect.c (xgselect_initialize): Check vs interface
3142 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3143
bf501fb9
PE
3144 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3145
e9829fdf
PE
3146 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3147 to read-only memory.
3148
1086c095
PE
3149 * fns.c (vector): Remove; this old hack is no longer needed.
3150
2baccd04 3151 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3152 Remove unused var.
dde42981 3153 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3154
72391843 3155 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3156
436c16df 3157 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3158 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3159 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3160
92bb796d 3161 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3162 (x_term_init): Remove local to avoid shadowing.
92bb796d 3163
764430a3 3164 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3165
3166 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3167 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3168
d1dfb56c
EZ
31692011-04-16 Eli Zaretskii <eliz@gnu.org>
3170
c4354cb4
EZ
3171 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3172
d1dfb56c
EZ
3173 Fix regex.c, syntax.c and friends for buffers > 2GB.
3174 * syntax.h (struct gl_state_s): Declare character position members
3175 EMACS_INT.
3176
3177 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3178
04f2d78b
CB
3179 * textprop.c (verify_interval_modification, interval_of):
3180 Declare arguments EMACS_INT.
d1dfb56c
EZ
3181
3182 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3183 EMACS_INT.
3184
3185 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3186
3187 * indent.c (Fvertical_motion): Local variable it_start is now
3188 EMACS_INT.
3189
3190 * regex.c (re_match, re_match_2, re_match_2_internal)
3191 (bcmp_translate, regcomp, regexec, print_double_string)
3192 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3193 (re_compile_pattern, re_exec): Declare arguments and local
3194 variables `size_t' and `ssize_t' and return values `regoff_t', as
3195 appropriate.
3196 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3197 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3198 <compile_stack_type>: `size' and `avail' are now `size_t'.
3199
3200 * regex.h <regoff_t>: Use ssize_t, not int.
3201 (re_search, re_search_2, re_match, re_match_2): Arguments that
3202 specify buffer/string position and length are now ssize_t and
3203 size_t. Return type is regoff_t.
3204
613052cd
BK
32052011-04-16 Ben Key <bkey76@gmail.com>
3206
3207 * nsfont.m: Fixed bugs in ns_get_family and
3208 ns_descriptor_to_entity that were caused by using free to
3209 deallocate memory blocks that were allocated by xmalloc (via
3210 xstrdup). This caused Emacs to crash when compiled with
3211 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3212 --enable-checking=xmallocoverrun). xfree is now used to
3213 deallocate these memory blocks.
3214
4170f62f 32152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3216
71b41406
PE
3217 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3218
9587a89d
PE
3219 emacs_write: Accept and return EMACS_INT for sizes.
3220 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3221 et seq.
3222 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3223 Accept and return EMACS_INT.
3224 (emacs_gnutls_write): Return the number of bytes written on
3225 partial writes.
3226 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3227 (emacs_read, emacs_write): Remove check for negative size, as the
3228 Emacs source code has been audited now.
9587a89d
PE
3229 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3230 (emacs_read, emacs_write): Use it.
273a5f82
PE
3231 * process.c (send_process): Adjust to the new signatures of
3232 emacs_write and emacs_gnutls_write. Do not attempt to store
3233 a byte offset into an 'int'; it might overflow.
9587a89d 3234 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3235
3e047f51
PE
3236 * sound.c: Don't assume sizes fit in 'int'.
3237 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3238 Return EMACS_INT, not int.
3e047f51 3239 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3240 Accept EMACS_INT, not int.
3241 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3242 record read return values.
3243
cc39a9db
BK
32442011-04-15 Ben Key <bkey76@gmail.com>
3245
c9d0ec6d
JB
3246 * keyboard.c (Qundefined): Don't declare static since it is used
3247 in nsfns.m.
3248 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3249 static since they are used in nsfont.m.
cc39a9db 3250
6c60eb9f
SM
32512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3252
3253 * process.c (Qprocessp): Don't declare static.
3254 * lisp.h (Qprocessp): Declare again.
3255
7990b61a
JB
32562011-04-15 Juanma Barranquero <lekktu@gmail.com>
3257
3258 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3259
5d4cb038
PE
32602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3261
8bd7b830 3262 Improve C-level modularity by making more things 'static'.
cd64ea1d 3263
e3b27b31
PE
3264 Don't publish debugger-only interfaces to other modules.
3265 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3266 (verify_bytepos, count_markers): Move decls to the only modules
3267 that need them.
3268 * region-cache.h (pp_cache): Likewise.
3269 * window.h (check_all_windows): Likewise.
3270 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3271
5d4cb038
PE
3272 * sysdep.c (croak): Now static, if
3273 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3274 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3275
3276 * alloc.c (refill_memory_reserve): Now static if
3277 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3278 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3279
e87b6180
PE
3280 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3281 Define only if USE_LUCID.
3282
ac64929e
PE
3283 * xrdb.c (x_customization_string, x_rm_string): Now static.
3284
6f37259d
PE
3285 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3286 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3287
1683e3ab
PE
3288 * xdisp.c (draw_row_with_mouse_face): Now static.
3289 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3290
de9c2632
PE
3291 * window.h (check_all_windows): Mark externally visible.
3292
2b96acb7
PE
3293 * window.c (window_deletion_count): Now static.
3294
3295 * undo.c: Make symbols static if they're not exported.
3296 (last_undo_buffer, last_boundary_position, pending_boundary):
3297 Now static.
3298
50436f33
PE
3299 * textprop.c (interval_insert_behind_hooks): Now static.
3300 (interval_insert_in_front_hooks): Likewise.
3301
64520e5c
PE
3302 * term.c: Make symbols static if they're not exported.
3303 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3304 (max_frame_lines, tty_set_terminal_modes):
3305 (tty_reset_terminal_modes, tty_turn_off_highlight):
3306 (get_tty_terminal): Now static.
3307 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3308 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3309 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3310 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3311 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3312
1fa53021
PE
3313 * sysdep.c: Make symbols static if they're not exported.
3314 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3315 Now static.
3316 (sigprocmask_set, full_mask): Remove; unused.
3317 (wait_debugging): Mark as visible.
3318 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3319 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3320
d4b43b22
PE
3321 * syntax.c (syntax_temp): Define only if !__GNUC__.
3322
b7c513d0
PE
3323 * sound.c (current_sound_device, current_sound): Now static.
3324
989b29ad
PE
3325 * search.c (searchbufs, searchbuf_head): Now static.
3326
13a55a78
PE
3327 * scroll.c (scroll_cost): Remove; unused.
3328 * dispextern.h (scroll_cost): Remove decl.
3329
de68a1fc
PE
3330 * region-cache.h (pp_cache): Mark as externally visible.
3331
40ccffa6
PE
3332 * process.c: Make symbols static if they're not exported.
3333 (process_tick, update_tick, create_process, chan_process):
3334 (Vprocess_alist, proc_buffered_char, datagram_access):
3335 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3336 (deactivate_process): Mark defn as static, as well as decl.
3337 * lisp.h (create_process): Remove decl.
3338 * process.h (chan_process, Vprocess_alist): Remove decls.
3339
ad64fc97
PE
3340 * print.c: Make symbols static if they're not exported.
3341 (print_depth, new_backquote_output, being_printed, print_buffer):
3342 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3343 (print_interval, print_number_index, initial_stderr_stream):
3344 Now static.
3345 * lisp.h (Fprinc): Remove decl.
3346 (debug_output_compilation_hack): Mark as externally visible.
3347
adddb265
PE
3348 * sysdep.c (croak): Move decl from here to syssignal.h.
3349 * syssignal.h (croak): Put it here, so the API can be checked when
3350 'croak' is called from dissociate_if_controlling_tty.
3351
1717ede2
PE
3352 * minibuf.c: Make symbols static if they're not exported.
3353 (minibuf_save_list, choose_minibuf_frame): Now static.
3354 * lisp.h (choose_minibuf_frame): Remove decl.
3355
fa5fb2bc
PE
3356 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3357
1e3890d1
PE
3358 * lread.c: Make symbols static if they're not exported.
3359 (read_objects, initial_obarray, oblookup_last_bucket_number):
3360 Now static.
3361 (make_symbol): Remove; unused.
3362 * lisp.h (initial_obarray, make_symbol): Remove decls.
3363
8a1414fa
PE
3364 * keyboard.c: Make symbols static if they're not exported.
3365 (single_kboard, recent_keys_index, total_keys, recent_keys):
3366 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3367 (this_single_command_key_start, echoing, last_auto_save):
3368 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3369 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3370 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3371 (Vlispy_mouse_stem, double_click_count):
3372 Now static.
3373 (force_auto_save_soon): Define only if SIGDANGER.
3374 (ignore_mouse_drag_p): Now static if
3375 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3376 (print_help): Remove; unused.
3377 (stop_character, last_timer_event): Mark as externally visible.
3378 * keyboard.h (ignore_mouse_drag_p): Declare only if
3379 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3380 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3381 * lisp.h (echoing): Remove decl.
3382 (force_auto_save_soon): Declare only if SIGDANGER.
3383 * xdisp.c (redisplay_window): Simplify code, to make it more
3384 obvious that ignore_mouse_drag_p is not accessed if !defined
3385 USE_GTK && !defined HAVE_NS.
3386
93ea6e8f
PE
3387 * intervals.c: Make symbols static if they're not exported.
3388 (merge_properties_sticky, merge_interval_right, delete_interval):
3389 Now static.
3390 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3391
77382fcc
PE
3392 * insdel.c: Make symbols static if they're not exported.
3393 However, leave prepare_to_modify_buffer alone. It's never
3394 called from outside this function, but that appears to be a bug.
3395 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3396 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3397 (adjust_after_replace_noundo): Remove; unused.
3398 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3399 (signal_before_change): Remove decls.
77382fcc 3400
9306c32e
PE
3401 * indent.c (val_compute_motion, val_vmotion): Now static.
3402
cd44d2eb
PE
3403 * image.c: Make symbols static if they're not exported.
3404 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3405 if USE_GTK.
3406 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3407 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3408
ad9a7a06
PE
3409 * fringe.c (standard_bitmaps): Now static.
3410 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3411
81626931
PE
3412 * frame.c: Make symbols static if they're not exported.
3413 (x_report_frame_params, make_terminal_frame): Now static.
3414 (get_frame_param): Now static, unless HAVE_NS.
3415 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3416 (x_get_resource_string): Remove; not used.
3417 * frame.h (make_terminal_frame, x_report_frame_params):
3418 (x_get_resource_string); Remove decls.
3419 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3420 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3421
239f9db9
PE
3422 * font.c, fontset.c: Make symbols static if they're not exported.
3423 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3424 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3425 * font.c (font_close_object): Now static.
3426 * font.h (font_close_object): Remove.
3427 * fontset.c (FONTSET_OBJLIST): Remove.
3428 (free_realized_fontset) #if-0 the body, which does nothing.
3429 (face_suitable_for_char_p): #if-0, as it's never called.
3430 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3431 * xfaces.c (face_at_string_position):
3432 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3433 since 0 is always ASCII.
3434
dfcf3579
PE
3435 * fns.c (weak_hash_tables): Now static.
3436
5045092b
PE
3437 * fileio.c: Make symbols static if they're not exported.
3438 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3439 (Vwrite_region_annotation_buffers): Now static.
3440
57a96f5c
PE
3441 * eval.c: Make symbols static if they're not exported.
3442 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3443 * lisp.h (backtrace_list): Remove decl.
3444
35f08c38
PE
3445 * emacs.c: Make symbols static if they're not exported.
3446 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3447 (fatal_error_code, fatal_error_signal_hook, standard_args):
3448 Now static.
3449 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3450 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3451 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3452 * lisp.h (fatal_error_signal_hook): Remove decl.
3453 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3454
f44bd759
PE
3455 * editfns.c: Move a (normally-unused) function to its only use.
3456 * editfns.c, lisp.h (get_operating_system_release): Remove.
3457 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3458 worth the hassle of breaking this out.
3459
b532497d
PE
3460 * xterm.c: Make symbols static if they're not exported.
3461 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3462 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3463 (x_destroy_window, x_delete_display):
3464 Now static.
3465 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3466 (x_mouse_leave): Remove; unused.
3467 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3468 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3469 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3470 Remove decls.
3471 (x_mouse_leave): Declare only if WINDOWSNT.
3472 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3473 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3474 USE_X_TOOLKIT.
3475
1675728f
PE
3476 * ftxfont.c: Make symbols static if they're not exported.
3477 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3478 HAVE_FREETYPE.
3479 * font.h (ftxfont_driver): Likewise.
3480
e4cebfca
PE
3481 * xfns.c: Make symbols static if they're not exported.
3482 (x_last_font_name, x_display_info_for_name):
3483 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3484 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3485 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3486 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3487 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3488 (last_show_tip_args): Now static.
3489 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3490 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3491 (x_screen_planes): Remove; unused.
3492 * dispextern.h (x_screen_planes): Remove decl.
3493
5bf46f05
PE
3494 * dispnew.c: Make symbols static if they're not exported.
3495 * dispextern.h (redraw_garbaged_frames, scrolling):
3496 (increment_row_positions): Remove.
3497 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3498 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3499 Now static.
3500 (redraw_garbaged_frames): Remove; unused.
3501
435f4c28
PE
3502 * xfaces.c: Make symbols static if they're not exported.
3503 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3504 Remove decls.
3505 * xterm.h (defined_color): Remove decls.
3506 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3507 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3508 (menu_face_changed_default, defined_color, free_realized_face):
3509 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3510 (ascii_face_of_lisp_face): Remove; unused.
3511
8524aef3
PE
3512 * xdisp.c: Make symbols static if they're not exported.
3513 * dispextern.h (scratch_glyph_row, window_box_edges):
3514 (glyph_to_pixel_coords, set_cursor_from_row):
3515 (get_next_display_element, set_iterator_to_next):
3516 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3517 (show_mouse_face): Remove decls
3518 * frame.h (message_buf_print): Likewise.
3519 * lisp.h (pop_message, set_message, check_point_in_composition):
3520 Likewise.
3521 * xterm.h (set_vertical_scroll_bar): Likewise.
3522 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3523 (message_buf_print, scratch_glyph_row, displayed_buffer):
3524 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3525 (get_next_display_element, show_mouse_face, window_box_edges):
3526 (frame_to_window_pixel_xy, check_point_in_composition):
3527 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3528 (glyph_to_pixel_coords): Remove; unused.
3529
16390cd2
PE
3530 * dired.c (file_name_completion): Now static.
3531
3532 * dbusbind.c (xd_in_read_queued_messages): Now static.
3533
a25f4dfa
PE
3534 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3535 * data.c (circular_list_error): Remove.
3536
14a9c8df
PE
3537 * commands.h (last_point_position, last_point_position_buffer):
3538 (last_point_position_window): Remove decls.
3539 * keyboard.c: Make these variables static.
3540
04f2d78b
CB
3541 * coding.h (coding, code_convert_region, encode_coding_gap):
3542 Remove decls.
74ab6df5
PE
3543 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3544 (iso_code_class, detect_coding, code_convert_region): Now static.
3545 (encode_coding_gap): Remove; unused.
3546
38dfbee1
PE
3547 * chartab.c (chartab_chars, chartab_bits): Now static.
3548
a2cb4e63
PE
3549 * charset.h (charset_iso_8859_1): Remove decl.
3550 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3551 Now static.
3552
127198fd
PE
3553 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3554 * ccl.c (Vccl_program_table): Now static.
3555 (check_ccl_update): Remove; unused.
3556
d85b608f
PE
3557 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3558 * category.h: ... from here.
3559 * category.c (check_category_table, set_category_set): Now static.
3560
31cd66f3
PE
3561 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3562 * lisp.h: Remove these decls.
3563
c358e587
PE
3564 * buffer.c (buffer_count): Remove unused var.
3565
e78aecca
PE
3566 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3567 so that it's not optimized away.
3568 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3569 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3570 exported only to the debugger.
3571
e192d7d3 3572 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3573 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3574
92470028
PE
3575 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3576 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3577 was inaccessible from Lisp.
3578 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3579 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3580
244ed907
PE
3581 alloc.c: Import and export fewer symbols, and remove unused items.
3582 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3583 is defined.
3584 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3585 it's not optimized away by whole-program optimization.
3586 (message_enable_multibyte, free_misc): Remove.
3587 (catchlist, handlerlist, mark_backtrace):
3588 Declare only if BYTE_MARK_STACK.
3589 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3590 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3591 (message_enable_multibyte): Remove decl.
3592 (free_misc, interval_free_list, float_block, float_block_index):
3593 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3594 (cons_free_list, last_marked_index):
3595 Now static.
3596 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3597 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3598 (mark_backtrace): Define only if BYTE_MARK_STACK.
3599 * xdisp.c (message_enable_multibyte): Now static.
3600
61c2b50e 3601 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3602 This makes it easier for human readers (and static analyzers)
3603 to see whether these variables are used from other modules.
3604 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3605 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3606 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3607 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3608 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3609 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3610 * xmenu.c, xselect.c:
3611 Declare Q* vars static if they are not used in other modules.
3612 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3613 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3614 Remove decls of unexported vars.
3615 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3616
95c82688
PE
3617 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3618
16a97296
PE
3619 Make Emacs functions such as Fatom 'static' by default.
3620 This makes it easier for human readers (and static analyzers)
3621 to see whether these functions can be called from other modules.
3622 DEFUN now defines a static function. To make the function external
3623 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3624 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3625 (Finit_image_library):
16a97296
PE
3626 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3627 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3628 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3629 Remove decls, since these functions are now static.
3630 (Funintern, Fget_internal_run_time): New decls, since these functions
3631 were already external.
95c82688 3632
16a97296
PE
3633 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3634 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3635 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3636 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3637 * keyboard.c, keymap.c, lread.c:
3638 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3639 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3640 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3641 Mark functions with DEFUE instead of DEFUN,
3642 if they are used in other modules.
3643 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3644 decls for now-static functions.
3645 * buffer.h (Fdelete_overlay): Remove decl.
3646 * callproc.c (Fgetenv_internal): Mark as internal.
3647 * composite.c (Fremove_list_of_text_properties): Remove decl.
3648 (Fcomposition_get_gstring): New forward static decl.
3649 * composite.h (Fcomposite_get_gstring): Remove decl.
3650 * dired.c (Ffile_attributes): New forward static decl.
3651 * doc.c (Fdocumntation_property): New forward static decl.
3652 * eval.c (Ffetch_bytecode): New forward static decl.
3653 (Funintern): Remove extern decl; now in .h file where it belongs.
3654 * fileio.c (Fmake_symbolic_link): New forward static decl.
3655 * image.c (Finit_image_library): New forward static decl.
3656 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3657 * intervals.h (Fprevious_property_change):
3658 (Fremove_list_of_text_properties): Remove decls.
3659 * keyboard.c (Fthis_command_keys): Remove decl.
3660 (Fcommand_execute): New forward static decl.
3661 * keymap.c (Flookup_key): New forward static decl.
3662 (Fcopy_keymap): Now static.
3663 * keymap.h (Flookup_key): Remove decl.
3664 * process.c (Fget_process): New forward static decl.
3665 (Fprocess_datagram_address): Mark as internal.
3666 * syntax.c (Fsyntax_table_p): New forward static decl.
3667 (skip_chars): Remove duplicate decl.
3668 * textprop.c (Fprevious_property_change): New forward static decl.
3669 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3670 Now internal.
3671 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3672 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3673
785bbd42
PE
3674 * editfns.c (Fformat): Remove unreachable code.
3675
8b913b57
AS
36762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3677
3678 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3679 change. (Bug#8496)
3680
a6744a35
EZ
36812011-04-13 Eli Zaretskii <eliz@gnu.org>
3682
3683 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3684 when at ZV. (Bug#8487)
3685
e7974947
AS
36862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3687
baad03f0
AS
3688 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3689 (Bug#8437)
3690 * keyboard.c (parse_tool_bar_item): Likewise.
3691 * sound.c (sound_cleanup, alsa_close): Likewise.
3692 * termcap.c (tgetent): Likewise.
3693 * xfns.c (x_default_font_parameter): Likewise.
3694 * xsettings.c (read_and_apply_settings): Likewise.
3695
e7974947
AS
3696 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3697 (overrun_check_free): Protoize.
3698
28272684
PE
36992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3700
3701 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3702 since callers should never pass a negative size.
3703 Change the signature to match that of plain 'read' and 'write'; see
3704 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3705 * lisp.h: Update prototypes of emacs_write and emacs_read.
3706
11997c76
EZ
37072011-04-11 Eli Zaretskii <eliz@gnu.org>
3708
3709 * xdisp.c (redisplay_window): Don't try to determine the character
3710 position of the scroll margin if the window start point w->startp
e896f03c 3711 is outside the buffer's accessible region. (Bug#8468)
11997c76 3712
8a2cbd72
EZ
37132011-04-10 Eli Zaretskii <eliz@gnu.org>
3714
3715 Fix write-region and its subroutines for buffers > 2GB.
3716 * fileio.c (a_write, e_write): Modify declaration of arguments and
3717 local variables to support buffers larger than 2GB.
3718 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3719
3720 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3721 argument, local variables, and return value.
3722
3723 * lisp.h: Update prototypes of emacs_write and emacs_read.
3724
3725 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3726
4073e537 37272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3728
1ebfdcb6
PE
3729 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3730
b2ded58d
PE
3731 Fix more problems found by GCC 4.6.0's static checks.
3732
7d66342c
PE
3733 * xdisp.c (vmessage): Use a better test for character truncation.
3734
bbf47d44
PE
3735 * charset.c (load_charset_map): <, not <=, for optimization,
3736 and to avoid potential problems with integer overflow.
9248994d 3737 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3738 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3739 * editfns.c (Fformat): Likewise.
1e69125e 3740 * syntax.c (skip_chars): Likewise.
3befa583 3741
e3019616
PE
3742 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3743 This also lets GCC 4.6.0 generate slightly better loop code.
3744
becfa255
PE
3745 * callint.c (Fcall_interactively): <, not <=, for optimization.
3746 (Fcall_interactively): Count the number of arguments produced,
3747 not the number of arguments given. This is simpler and lets GCC
3748 4.6.0 generate slightly better code.
3749
dae0cd48
PE
3750 * ftfont.c: Distingish more carefully between FcChar8 and char.
3751 The previous code passed unsigned char * to a functions like
3752 strlen and xstrcasecmp that expect char *, which does not
3753 conform to the C standard.
3754 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3755 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3756 char * when the C standard requires it.
3757
76032d70
PE
3758 * keyboard.c (read_char): Remove unused var.
3759
eb3f1cc8
PE
3760 * eval.c: Port to Windows vsnprintf (Bug#8435).
3761 Include <limits.h>.
3762 (SIZE_MAX): Define if the headers do not.
3763 (verror): Do not give up if vsnprintf returns a negative count.
3764 Instead, grow the buffer. This ports to Windows vsnprintf, which
3765 does not conform to C99. Problem reported by Eli Zaretskii.
3766 Also, simplify the allocation scheme, by avoiding the need for
3767 calling realloc, and removing the ALLOCATED variable.
3768
70476b54
PE
3769 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3770
12020a9e
PE
3771 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3772 But keep the doprint source code for now, as we might revamp it
3773 and use it again (Bug#8435).
ea6c7ae6
PE
3774 * lisp.h (doprnt): Remove.
3775 * Makefile.in (base_obj): Remove doprnt.o.
3776 * deps.mk (doprnt.o): Remove.
3777
5fdb398c
PE
3778 error: Print 32- and 64-bit integers portably (Bug#8435).
3779 Without this change, on typical 64-bit hosts error ("...%d...", N)
3780 was used to print both 32- and 64-bit integers N, which relied on
3781 undefined behavior.
3782 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3783 New macro.
3784 * lisp.h (error, verror): Mark as printf-like functions.
3785 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3786 Report overflow in size calculations when allocating printf buffer.
3787 Do not truncate output string at its first null byte.
3788 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3789 Truncate the output at a character boundary, since vsnprintf does not
3790 do that.
3791 * charset.c (check_iso_charset_parameter): Convert internal
3792 character to string before calling 'error', since %c now has the
3793 printf meaning.
3794 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3795 overflow when computing char to be passed to 'error'. Do not
3796 pass Lisp_Object to 'error'; pass the integer instead.
3797 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3798 formatted with plain %d.
3799
b189fa66
PE
3800 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3801
bff87ef0
PE
3802 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3803
7e2cac20
PE
3804 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3805
ce4d90b5
PE
3806 * xterm.c (x_catch_errors): Remove duplicate declaration.
3807
266c9547
PE
3808 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3809
79c49ad2
PE
3810 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3811
368f4090
JM
38122011-04-10 Jim Meyering <meyering@redhat.com>
3813
3814 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3815 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3816 return ssize_t not "int", and use size_t as the buffer length.
3817 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3818 * gnutls.h: Update declarations.
3819 * process.c (read_process_output): Use ssize_t, to match.
3820 (send_process): Likewise.
3821
a32d4040
CY
38222011-04-09 Chong Yidong <cyd@stupidchicken.com>
3823
3824 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3825
8546720e 38262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3827
04f2d78b
CB
3828 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3829 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3830
8546720e
GM
3831 * xterm.c (handle_one_xevent):
3832 * xmenu.c (create_and_show_popup_menu):
3833 * xselect.c (x_decline_selection_request)
3834 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3835
0a2f5c1a 38362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3837
3838 Fix some uses of `int' instead of EMACS_INT.
3839 * search.c (string_match_1, fast_string_match)
3840 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3841 (scan_buffer, find_next_newline_no_quit)
3842 (find_before_next_newline, search_command, Freplace_match)
3843 (Fmatch_data): Make some `int' variables be EMACS_INT.
3844
3845 * xdisp.c (display_count_lines): 3rd argument and return value now
3846 EMACS_INT. All callers changed.
3847 (pint2hrstr): Last argument is now EMACS_INT.
3848
3849 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3850 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3851 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3852 (decode_coding_utf_16, decode_coding_emacs_mule)
3853 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3854 (decode_coding_ccl, decode_coding_charset)
3855 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3856 (decode_coding_iso_2022, decode_coding_emacs_mule)
3857 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3858 <char_offset, last_offset>: Declare EMACS_INT.
3859 (encode_coding_utf_8, encode_coding_utf_16)
3860 (encode_coding_emacs_mule, encode_invocation_designation)
3861 (encode_designation_at_bol, encode_coding_iso_2022)
3862 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3863 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3864 Declare EMACS_INT.
3865 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3866 (encode_invocation_designation): Last argument P_NCHARS is now
3867 EMACS_INT.
3868 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3869 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3870
3871 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3872 All users changed.
3873
3874 * ccl.c (Fccl_execute_on_string): Declare some variables
3875 EMACS_INT.
3876
8546720e 38772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3878
3879 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3880
4e19a977
CS
38812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3882
3883 * process.c (Fformat_network_address): Doc fix.
3884
87302331
R
38852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3886
3887 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3888
cbb59342
CY
38892011-04-08 Chong Yidong <cyd@stupidchicken.com>
3890
3891 * keyboard.c (read_char): Call Lisp function help-form-show,
3892 instead of using internal_with_output_to_temp_buffer.
3893 (Qhelp_form_show): New var.
e0d38eeb 3894 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3895
3896 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3897
3898 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3899
e67a13ab
CY
39002011-04-06 Chong Yidong <cyd@stupidchicken.com>
3901
04f2d78b
CB
3902 * process.c (Flist_processes): Remove to Lisp.
3903 (list_processes_1): Delete.
e67a13ab 3904
973f782d
EZ
39052011-04-06 Eli Zaretskii <eliz@gnu.org>
3906
7c106b1e
EZ
3907 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3908
973f782d
EZ
3909 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3910
41cf7d1a 39112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3912
ca23cc88
PE
3913 Fix more problems found by GCC 4.6.0's static checks.
3914
f390e2d5
PE
3915 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3916
42eea0d0
PE
3917 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3918
b69769da 3919 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3920
f9541e84
PE
3921 * xdisp.c (vmessage): Mark as a printf-like function.
3922
13841b55
PE
3923 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3924
c136c10f
PE
3925 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3926
5e2d4a30
PE
3927 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3928 printf-like functions.
3929 (tiff_load): Add casts to remove these marks before passing them
3930 to system-supplied API.
3931
583f48b9
PE
3932 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3933
b25d760e
PE
3934 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3935 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3936 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3937 directly, rather than having caller test rule sign. This avoids
3938 some unnecessary tests.
3939 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3940 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3941 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3942
bc7b6697 3943 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3944 (xfont_open): Avoid unnecessary tests.
bc7b6697 3945
27ccc379
PE
3946 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3947
dcd5c89a
PE
3948 * composite.h, composite.c (composition_gstring_put_cache):
3949 Use EMACS_INT, not int, for length.
3950
b13a45c6
PE
3951 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3952 breaking out part of COMPOSITION_DECODE_RULE.
3953 (COMPOSITION_DECODE_RULE): Use it.
3954 * composite.c (get_composition_id): Remove unused local vars,
3955 by using the new macro.
3956
1e792e4d
PE
3957 * textprop.c (set_text_properties_1): Change while to do-while,
3958 since the condition is always true at first.
3959
dc6c6455 3960 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3961 (interval_deletion_adjustment): Return unsigned value.
3962 All uses changed.
dc6c6455 3963
aba7731a
PE
3964 * process.c (list_processes_1, create_pty, read_process_output):
3965 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3966 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3967 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3968 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3969 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3970
fdfc4bf3
PE
3971 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3972
fca8fe46 3973 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3974 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3975
06a0259a 3976 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3977 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3978 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3979
e7b9e80f
PE
3980 * print.c (print_error_message): Avoid int overflow.
3981
56201685
PE
3982 * font.c (font_list_entities): Redo for clarity,
3983 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3984
78834453 3985 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3986 (font_score): Avoid potential overflow in diff calculation.
78834453 3987
0bc0b309 3988 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3989 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3990
e610eaca
PE
3991 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3992
b895abce
PE
3993 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3994 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3995 can always succeed if overflow has undefined behavior.
3996
1f1d9321 3997 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3998 (wordify): Omit three unnecessary tests.
1f1d9321 3999
c59478bc
PE
4000 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4001 All callers changed. This avoids the need for an unused var.
4002
79b73827
PE
4003 * casefiddle.c (casify_region): Remove var that is set but not used.
4004
a4db5dfe
PE
4005 * dired.c (file_name_completion): Remove var that is set but not used.
4006
43aae36e
PE
4007 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4008
2a47c44d 4009 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4010 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4011
a37c69bf
PE
4012 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4013 Check for integer overflow on size calculations.
4014
328ab8e7
PE
4015 * buffer.c (Fprevious_overlay_change): Remove var that is set
4016 but not used.
4017
e5a2a5cb
PE
4018 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4019 Remove vars that are set but not used.
8d84a6eb 4020 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4021 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4022
a60e5f68
PE
4023 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4024
f661cb61 4025 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4026 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4027
f0397f5a
PE
4028 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4029 that are set but not used.
4030
8664db06 4031 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4032 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4033
6abdaa4a
PE
4034 * xselect.c (x_get_local_selection, x_handle_property_notify):
4035 Remove vars that are set but not used.
4036
0ce7538d 4037 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4038 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4039
9ae848fc
PE
4040 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4041 Remove var that is set but not used.
0b918413
PE
4042 (scroll_bar_windows_size): Now size_t, not int.
4043 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4044 Check for overflow.
9ae848fc 4045
a5a62657
PE
4046 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4047 (map_tty_color) [!defined MSDOS]: Likewise.
4048
5c5cdd39
PE
4049 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4050
66ebf983
PE
4051 * coding.c: Remove vars that are set but not used.
4052 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4053 All callers changed.
4054 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4055 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4056 (decode_coding_charset): Remove vars that are set but not used.
4057
1be4d761
PE
4058 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4059 that is set but not used.
4060
47553fa8
PE
4061 * print.c (print_object): Remove var that is set but not used.
4062
1f7196bf 4063 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4064 The gnulib version avoids calling malloc in the usual case,
4065 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4066 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4067 * filelock.c (current_lock_owner): Likewise.
4068 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4069 * sysdep.c: Include allocator.h, careadlinkat.h.
4070 (emacs_no_realloc_allocator): New static constant.
4071 (emacs_readlink): New function.
fdb61804
PE
4072 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4073 ../lib/careadlinkat.h.
d1fdcab7 4074
f84c17c7
SM
40752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4076
4077 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4078 first non-nil return value).
4079
ef3862ad
JD
40802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4081
4082 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4083 if not defined (Bug#8403).
4084
376a7006
JB
40852011-04-02 Juanma Barranquero <lekktu@gmail.com>
4086
4087 * xdisp.c (display_count_lines): Remove parameter `start',
4088 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4089 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4090 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4091 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4092 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4093 and thereabouts. All callers changed.
4094 (get_per_char_metric): Remove parameter `f', unused since
4095 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4096
6ca3801d
JM
40972011-04-02 Jim Meyering <meyering@redhat.com>
4098
4099 do not dereference NULL upon failed strdup
4100 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4101 (ns_get_family): Likewise.
4102
d8e2b5ba
JB
41032011-04-02 Juanma Barranquero <lekktu@gmail.com>
4104
4105 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4106
8c74fcbd
JD
41072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4108
4109 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4110 later (Bug#8403).
4111
7200d79c
SM
41122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4113
03408648 4114 Add lexical binding.
7200d79c 4115
03408648
SM
4116 * window.c (Ftemp_output_buffer_show): New fun.
4117 (Fsave_window_excursion):
4118 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4119
4120 * lread.c (lisp_file_lexically_bound_p): New function.
4121 (Fload): Bind Qlexical_binding.
4122 (readevalloop): Remove `evalfun' arg.
4123 Bind Qinternal_interpreter_environment.
4124 (Feval_buffer): Bind Qlexical_binding.
4125 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4126 Mark as dynamic.
4127 (syms_of_lread): Declare `lexical-binding'.
4128
4129 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4130
4131 * keyboard.c (eval_dyn): New fun.
4132 (menu_item_eval_property): Use it.
ca105506
SM
4133
4134 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4135
03408648
SM
4136 * fns.c (concat, mapcar1): Accept byte-code-functions.
4137
4138 * eval.c (Fsetq): Handle lexical vars.
4139 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4140 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4141 (FletX, Flet): Obey lexical binding.
4142 (Fcommandp): Handle closures.
4143 (Feval): New `lexical' arg.
4144 (eval_sub): New function extracted from Feval. Use it almost
4145 everywhere where Feval was used. Look up vars in lexical env.
4146 Handle closures.
4147 (Ffunctionp): Move from subr.el.
4148 (Ffuncall): Handle closures.
4149 (apply_lambda): Remove `eval_flags'.
4150 (funcall_lambda): Handle closures and new byte-code-functions.
4151 (Fspecial_variable_p): New function.
4152 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4153 but without exporting it to Lisp.
23aba0ea 4154
23aba0ea 4155 * doc.c (Fdocumentation, store_function_docstring):
03408648 4156 * data.c (Finteractive_form): Handle closures.
23aba0ea 4157
03408648
SM
4158 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4159 interactive spec.
ba83908c 4160
04f2d78b
CB
4161 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4162 New byte-codes.
03408648
SM
4163 (exec_byte_code): New function extracted from Fbyte_code to handle new
4164 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4165
03408648 4166 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4167
03408648 4168 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4169
e2abce01
JB
41702011-03-31 Juanma Barranquero <lekktu@gmail.com>
4171
4172 * xdisp.c (redisplay_internal): Fix prototype.
4173
63696a73 41742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4175
63696a73 4176 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4177 (try_scrolling): Use it when setting scroll_limit.
4178 Limit scrolling to 100 screen lines.
63696a73
EZ
4179 (redisplay_window): Even when falling back on "recentering",
4180 position point in the window according to scroll-conservatively,
4181 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4182
4183 (try_scrolling): When point is above the window, allow searching
4184 as far as scroll_max, or one screenful, to compute vertical
4185 distance from PT to the scroll margin position. This prevents
4186 try_scrolling from unnecessarily failing when
4187 scroll-conservatively is set to a value slightly larger than the
4188 window height. Clean up the case of PT below the margin at bottom
4189 of window: scroll_max can no longer be INT_MAX. When aggressive
4190 scrolling is in use, don't let point enter the opposite scroll
4191 margin as result of the scroll.
4192 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4193 threshold of 100 lines for never-recentering scrolling.
4194
e4cc2dfc
JB
41952011-03-31 Juanma Barranquero <lekktu@gmail.com>
4196
4197 * dispextern.h (move_it_by_lines):
4198 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4199 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4200 (message_log_check_duplicate): Remove parameters `prev_bol' and
4201 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4202 (redisplay_internal): Remove parameter `preserve_echo_area',
4203 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4204
4205 * indent.c (Fvertical_motion):
4206 * window.c (window_scroll_pixel_based, Frecenter):
4207 Don't pass `need_y_p' to `move_it_by_lines'.
4208
1c470562
SM
42092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4210
44f230aa
SM
4211 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4212 steal a few bits to be more compact.
4213 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4214 Remove unneeded casts.
4215
1c470562
SM
4216 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4217
888adce9
ZK
42182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4219
4220 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4221 binding" message (bug#7967).
4222
f838ed7b
PE
42232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4224
77861b95
PE
4225 Fix more problems found by GCC 4.6.0's static checks.
4226
de6dbc14
PE
4227 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4228 Remove unused local var.
4229
f838ed7b
PE
4230 * editfns.c (Fmessage_box): Remove unused local var.
4231
792c7b2b
PE
4232 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4233 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4234 Omit unused local vars.
c499e557 4235 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4236 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4237 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4238 Omit unused local var.
4239
ba0165e1
PE
4240 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4241 Don't assume string length fits in int.
32ad8845 4242 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4243 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4244
3c59b4c9
PE
4245 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4246 instead of alloca (Bug#8344).
4247
a3eed478 4248 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4249 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4250
eb4d412d
PE
4251 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4252
1658b401
PE
4253 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4254 concerns.
4255
4256 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4257
4258 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4259
9a2c6e05
PE
4260 * keyboard.c (syms_of_keyboard): Use the same style as later
4261 in this function when indexing through an array. This also
4262 works around GCC bug 48267.
4263
03d0a109
PE
4264 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4265
44f730c8
PE
4266 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4267
fe75f926
PE
4268 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4269 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4270
ffa8c828
PE
4271 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4272 This avoids undefined behavior on integer overflow, and is a bit
4273 more convenient anyway since it is compared to a size_t variable.
4274
c5101a77
PE
4275 Variadic C functions now count arguments with size_t, not int.
4276 This avoids an unnecessary limitation on 64-bit machines, which
4277 caused (substring ...) to crash on large vectors (Bug#8344).
4278 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4279 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4280 All variadic functions and their callers changed accordingly.
c5101a77
PE
4281 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4282 * data.c (arith_driver, float_arith_driver): Likewise.
4283 * editfns.c (general_insert_function): Likewise.
4284 * eval.c (struct backtrace.nargs, interactive_p)
4285 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4286 (funcall_lambda, mark_backtrace): Likewise.
4287 * fns.c (concat): Likewise.
4288 * frame.c (x_set_frame_parameters): Likewise.
4289 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4290 0 if not found, not -1. All callers changed.
4291
dd3f25f7
PE
4292 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4293 (stack_copy_size): Now size_t, not int.
4294 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4295
461c2ab9
JB
42962011-03-28 Juanma Barranquero <lekktu@gmail.com>
4297
4298 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4299 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4300 All callers changed.
4301
4302 * lisp.h (multibyte_char_to_unibyte):
4303 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4304 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4305 * character.h (CHAR_TO_BYTE8):
4306 * cmds.c (internal_self_insert):
4307 * editfns.c (general_insert_function):
4308 * keymap.c (push_key_description):
4309 * search.c (Freplace_match):
4310 * xdisp.c (message_dolog, set_message_1): All callers changed.
4311
f6d62986
SM
43122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4313
4314 * keyboard.c (safe_run_hook_funcall): New function.
4315 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4316 don't set the hook to nil, but remove the offending function instead.
4317 (Qcommand_hook_internal): Remove, unused.
4318 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4319 Vcommand_hook_internal.
4320
4321 * eval.c (enum run_hooks_condition): Remove.
4322 (funcall_nil, funcall_not): New functions.
4323 (run_hook_with_args): Call each function through a `funcall' argument.
4324 Remove `cond' argument, now redundant.
4325 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4326 (Frun_hook_with_args_until_failure): Adjust accordingly.
4327 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4328
1db5b1ad
JB
43292011-03-28 Juanma Barranquero <lekktu@gmail.com>
4330
4331 * dispextern.h (string_buffer_position): Remove declaration.
4332
4333 * print.c (strout): Remove parameter `multibyte', unused since
4334 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4335
4336 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4337 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4338 All callers changed.
4339
4340 * w32.c (_wsa_errlist): Use braces for struct initializers.
4341
4342 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4343 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4344 All callers changed.
4345 (string_buffer_position): Likewise. Also, make static (it's never
4346 used outside xdisp.c).
4347 (cursor_row_p): Remove parameter `w', unused since
4348 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4349 (decode_mode_spec): Remove parameter `precision', introduced during
4350 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4351 All callers changed.
4352
5ffb62aa
JD
43532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4354
4355 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4356
461c2ab9 43572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4358
4359 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4360 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4361 (ns_update_auto_hide_menu_bar): New functions.
4362 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4363 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4364 ns_constrain_all_frames.
4365 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4366 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4367
5c380ffb
JD
43682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4369
4370 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4371
9af30bdf
GM
43722011-03-27 Glenn Morris <rgm@gnu.org>
4373
4374 * syssignal.h: Replace RETSIGTYPE with void.
4375 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4376 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4377 Replace SIGTYPE with void everywhere.
4378 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4379 * s/template.h (SIGTYPE): Remove commented out definition.
4380
e2abce01
JB
43812011-03-26 Eli Zaretskii <eliz@gnu.org>
4382
4383 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4384 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4385
f868cd8a
JB
43862011-03-26 Juanma Barranquero <lekktu@gmail.com>
4387
59eb0929
JB
4388 * w32.c (read_unc_volume): Use parameter `henum', instead of
4389 global variable `wget_enum_handle'.
4390
4391 * keymap.c (describe_vector): Remove parameters `indices' and
4392 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4393 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4394
f868cd8a
JB
4395 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4396
4397 * keyboard.c (timer_check): Remove parameter `do_it_now',
4398 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4399 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4400 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4401
4402 * keyboard.c (read_char):
4403 * w32menu.c (w32_menu_display_help):
4404 * xmenu.c (show_help_event, menu_help_callback):
4405 Adjust calls to `show_help_echo'.
4406
4407 * gtkutil.c (xg_maybe_add_timer):
4408 * keyboard.c (readable_events):
4409 * process.c (wait_reading_process_output):
4410 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4411
4412 * insdel.c (adjust_markers_gap_motion):
4413 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4414 (gap_left, gap_right): Don't call it.
4415
2ecf6fdb
CY
44162011-03-25 Chong Yidong <cyd@stupidchicken.com>
4417
4418 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4419 incurred during fontification.
4420
6b1f9ba4
JB
44212011-03-25 Juanma Barranquero <lekktu@gmail.com>
4422
4423 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4424 (DEFVAR_PER_BUFFER): Don't pass it.
4425
4426 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4427 (scrolling_window): Don't pass it.
4428
0f4a96b5
JB
44292011-03-25 Juanma Barranquero <lekktu@gmail.com>
4430
4431 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4432
4433 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4434 and `suffix'.
4435 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4436 of variables specific to SELinux and computation of `encoded_absname'.
4437
4438 * image.c (XPutPixel): Remove unused variable `height'.
4439
4440 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4441
4442 * unexw32.c (get_section_info): Remove unused variable `section'.
4443
4444 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4445 (system_process_attributes): Remove unused variable `sess'.
4446 (sys_read): Remove unused variable `err'.
4447
4448 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4449 (w32_wnd_proc): Remove unused variable `isdead'.
4450 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4451 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4452 (x_create_tip_frame): Remove unused variable `tem'.
4453
4454 * w32inevt.c (w32_console_read_socket):
4455 Remove unused variable `no_events'.
4456
4457 * w32term.c (x_draw_composite_glyph_string_foreground):
4458 Remove unused variable `width'.
4459
1149507c
JB
44602011-03-24 Juanma Barranquero <lekktu@gmail.com>
4461
4462 * w32term.c (x_set_glyph_string_clipping):
4463 Don't pass uninitialized region to CombineRgn.
4464
9c88f339
JB
44652011-03-23 Juanma Barranquero <lekktu@gmail.com>
4466
4467 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4468 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4469 (Fx_close_connection): Remove unused variable `i'.
4470
4471 * w32font.c (w32font_draw): Return number of glyphs.
4472 (w32font_open_internal): Remove unused variable `i'.
4473 (w32font_driver): Add missing initializer.
4474
4475 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4476 (fill_in_menu): Remove unused variable `items_added'.
4477
4478 * w32term.c (last_mouse_press_frame): Remove static global variable.
4479 (w32_clip_to_row): Remove unused variable `f'.
4480 (x_delete_terminal): Remove unused variable `i'.
4481
4482 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4483 (NOTHING): Remove unused static global variable.
4484 (uniscribe_check_otf): Remove unused variable `table'.
4485 (uniscribe_font_driver): Add missing initializers.
4486
dee091a3
JD
44872011-03-23 Julien Danjou <julien@danjou.info>
4488
4489 * term.c (Fsuspend_tty, Fresume_tty):
4490 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4491 * window.c (temp_output_buffer_show):
4492 * insdel.c (signal_before_change):
4493 * frame.c (Fhandle_switch_frame):
4494 * fileio.c (Fdo_auto_save):
4495 * emacs.c (Fkill_emacs):
4496 * editfns.c (save_excursion_restore):
4497 * cmds.c (internal_self_insert):
4498 * callint.c (Fcall_interactively):
4499 * buffer.c (Fkill_all_local_variables):
4500 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4501 Use Frun_hooks.
0f4a96b5 4502 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4503 unconditionnaly since it does the check itself.
4504
2c520ab5 45052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4506
c9c49752
PE
4507 Fix more problems found by GCC 4.5.2's static checks.
4508
8abc3f12
PE
4509 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4510 the first time through the loop, since we know p0 < p1 then.
4511 This also avoids a gcc -Wstrict-overflow warning.
4512
a2d26660
PE
4513 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4514 leading to a memory leak, possible in functions like
4515 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4516 of objects (Bug#8318).
a2d26660 4517
916c72e9
PE
4518 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4519 that could (at least in theory) be that large.
4520
19ab8a18
PE
4521 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4522 This is less likely to overflow, and avoids undefined behavior if
4523 overflow does occur. All callers changed. Use strtoul to scan
4524 for the unsigned long integer.
b7cbbd6f
PE
4525 (pint2hrstr): Simplify and tune code slightly.
4526 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4527
f0641eff
PE
4528 * scroll.c (do_scrolling): Work around GCC bug 48228.
4529 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4530
7f650bb9
PE
4531 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4532 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4533 (validate_x_resource_name): Simplify count usage.
4534 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4535
37dd57d1
PE
4536 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4537 fail (Bug#8306).
81e56e61 4538
699979fc 4539 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4540
401bf9b4
PE
4541 * process.c (Fmake_network_process): Use socklen_t, not int,
4542 where POSIX says socklen_t is required in portable programs.
4543 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4544 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4545 (Fmake_network_process, server_accept_connection):
4546 (wait_reading_process_output, read_process_output):
4547 Likewise.
4548
b93aacde
PE
4549 * process.c: Rename or move locals to avoid shadowing.
4550 (list_processes_1, Fmake_network_process):
4551 (read_process_output_error_handler, exec_sentinel_error_handler):
4552 Rename or move locals.
4dc343ee 4553 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4554 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4555 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4556 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4557 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4558
af8a867c 4559 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4560 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4561 Include tparam.h instead, since it declares them.
af8a867c
PE
4562 * cm.h (PC): Remove extern decl; tparam.h now does this.
4563 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4564 * terminfo.c: Include tparam.h, to check interfaces.
4565 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4566 (tparam): Adjust signature to match interface in tparam.h;
4567 this removes some undefined behavior. Check that outstring and len
4568 are zero, which they always are with Emacs.
4569 * tparam.h (PC, BC, UP): New extern decls.
4570
0248044d 4571 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4572 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4573
8ff096c1 4574 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4575 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4576 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4577 (ftfont_list): Remove unused local.
49eaafba
PE
4578 (get_adstyle_property, ftfont_pattern_entity):
4579 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4580 Rename locals to avoid shadowing.
8ff096c1 4581
e2be39f6
PE
4582 * xfont.c (xfont_list_family): Mark var as initialized.
4583
c9735e30
PE
4584 * xml.c (make_dom): Now static.
4585
8f5201ae
PE
4586 * composite.c (composition_compute_stop_pos): Rename local to
4587 avoid shadowing.
b246f932
PE
4588 (composition_reseat_it): Remove unused locals.
4589 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4590 (composition_update_it): Mark var as initialized.
11b61122
PE
4591 (find_automatic_composition): Mark vars as initialized,
4592 with a FIXME (Bug#8290).
8f5201ae 4593
760fbc2c
PE
4594 character.h: Rename locals to avoid shadowing.
4595 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4596 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4597 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4598 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4599 to avoid shadowing.
4600
ff08eb85
PE
4601 * textprop.c (property_change_between_p): Remove; unused.
4602
fc7bf025
PE
4603 * intervals.c (interval_start_pos): Now static.
4604
235d7abc
PE
4605 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4606
44f230aa
SM
4607 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4608 Rename locals to avoid shadowing.
3e7d6594 4609
50060332
PE
4610 * sound.c (wav_play, au_play, Fplay_sound_internal):
4611 Fix pointer signedness.
d01f234b 4612 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4613 (wav_play): Initialize a variable to 0, to prevent undefined
4614 behavior (Bug#8278).
50060332 4615
c4fc4e30
PE
4616 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4617
918436ed
PE
4618 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4619
c939f91b
PE
4620 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4621 clobbering (Bug#8298).
b9c7f648
PE
4622 * sysdep.c (sys_subshell): Likewise.
4623 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4624
6bd8c144
PE
4625 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4626 This should get cleaned up, so that child_setup has the
4627 same signature on all platforms.
4628
7710357c 4629 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4630 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4631
c59da222
CY
46322011-03-22 Chong Yidong <cyd@stupidchicken.com>
4633
4634 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4635 not to be necessary, and produces flickering.
4636
66b87493
GM
46372011-03-20 Glenn Morris <rgm@gnu.org>
4638
4639 * config.in: Remove file.
4640
45b6f6d5
JB
46412011-03-20 Juanma Barranquero <lekktu@gmail.com>
4642
4643 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4644 are now in src/globals.h.
4645 (syms_of_minibuf): Remove spurious & from previous change.
4646
3ec03f7e
LL
46472011-03-20 Leo <sdl.web@gmail.com>
4648
4649 * minibuf.c (completing-read-function): New variable.
4650 (completing-read-default): Rename from completing-read.
4651 (completing-read): Call completing-read-function.
4652
b14e3e21
CY
46532011-03-19 Juanma Barranquero <lekktu@gmail.com>
4654
4655 * xfaces.c (Fx_load_color_file):
4656 Read color file from absolute filename (bug#8250).
4657
f2b726e6
JB
46582011-03-19 Juanma Barranquero <lekktu@gmail.com>
4659
4660 * makefile.w32-in: Update dependencies.
4661
09f6ff02
EZ
46622011-03-17 Eli Zaretskii <eliz@gnu.org>
4663
4664 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4665
29a6015a
PE
46662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4667
a3a6c54e
PE
4668 Fix more problems found by GCC 4.5.2's static checks.
4669
b766f867
PE
4670 * process.c (make_serial_process_unwind, send_process_trap):
4671 (sigchld_handler): Now static.
4672
be02381c
PE
4673 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4674 That way, the code declares only the vars that it needs.
4675 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4676 * s/cygwin.h (PTY_ITERATION): Likewise.
4677 * s/darwin.h (PTY_ITERATION): Likewise.
4678 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4679
57048744
PE
4680 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4681 * process.c (allocate_pty): Don't declare stb unless it's needed.
4682
7914961c 4683 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4684 (CONSTANTLIM): Remove; unused.
4685 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4686 Define only if needed.
7914961c 4687
b3967b18
PE
4688 * unexelf.c (unexec): Name an expression,
4689 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4690 Use a different way to cause a compilation error if anyone uses
4691 n rather than nn, a way that does not involve shadowing.
73366a00 4692 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4693
29a6015a
PE
4694 * deps.mk (unexalpha.o): Remove; unused.
4695
43cfc33e 4696 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4697 * unexec.h: New file.
ce701a33
PE
4698 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4699 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4700 Depend on unexec.h.
4701 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4702 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4703 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4704 Change as necessary to match prototype in unexec.h.
ce701a33 4705
01f44d5a
PE
4706 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4707 shadowing.
4f63c6bb 4708 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4709
a6670b0b
PE
4710 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4711 Rename locals to avoid shadowing.
4712
cef2010d 4713 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4714 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4715
d4d7173a
PE
4716 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4717
f08b802a
PE
4718 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4719 warning when compiling print.c.
4720
3ddb0639
PE
4721 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4722 instead of using an uninitialized var.
5ad03b97 4723 (font_sort_entities): Mark var as initialized.
3ddb0639 4724
170a2692
PE
4725 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4726
e663c700
PE
4727 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4728 pointers to constants.
89bc529a 4729 (font_parse_fcname): Remove unused vars.
7b81e2d0 4730 (font_delete_unmatched): Now static.
ea838e10 4731 (font_get_spec): Remove; unused.
13a547c6
PE
4732 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4733 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4734 Rename or move locals to avoid shadowing.
e663c700 4735
2a80c887 4736 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4737 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4738
1384fa33 4739 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4740 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4741
8b2c52e9
PE
4742 * alloc.c (mark_backtrace): Move decl from here ...
4743 * lisp.h: ... to here, so that it can be checked.
4744
475545b5 4745 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4746 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4747 (lisp_indirect_variable): Name an expression,
4748 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4749 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4750
b1349114 4751 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4752 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4753 Use const pointer when appropriate.
b1349114 4754
a2928364
PE
4755 * lisp.h (get_system_name, get_operating_system_release):
4756 Move decls here, to check interfaces.
4757 * process.c (get_operating_system_release): Move decl to lisp.h.
4758 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4759 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4760 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4761 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4762 (Fformat_time_string, Fencode_time, Finsert_char):
4763 (Ftranslate_region_internal, Fformat):
4764 Rename or remove local vars to avoid shadowing.
9710023e 4765 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4766
a415e694
PE
4767 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4768 avoid shadowing.
4769
8ef4622d
PE
4770 * lisp.h (eassert): Check that the argument compiles, even if
4771 ENABLE_CHECKING is not defined.
4772
946f9a5b
PE
4773 * data.c (Findirect_variable): Name an expression, to avoid
4774 gcc -Wbad-function-cast warning.
112396d6 4775 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4776 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4777 (Fmake_variable_buffer_local, Fmake_local_variable):
4778 Mark variables as initialized.
52746918 4779 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4780
e5aab7e7 4781 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4782 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4783 Rename locals to avoid shadowing.
dff45157
PE
4784 (mark_stack): Move local variables into the #ifdef region where
4785 they're used.
7bc26fdb
PE
4786 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4787 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4788 needed otherwise.
4789 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4790 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4791 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4792
e5aab7e7
PE
4793 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4794 avoids undefined behavior in theory.
4795
4da60324
PE
4796 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4797
88043301
PE
4798 Use functions, not macros, for up- and down-casing (Bug#8254).
4799 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4800 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4801 to use the following functions instead of these macros.
4802 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4803 EMACS_INT, since callers assume the returned value fits in int.
4804 (upcase1): Likewise, for UPCASE_TABLE.
4805 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4806 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4807 the race-condition problem in the old DOWNCASE.
88043301 4808
19ed5445
PE
4809 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4810 Rename locals to avoid shadowing.
4811 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4812 (regex_compile, re_search_2, re_match_2_internal):
4813 Remove unused local vars.
952db0d7
PE
4814 (FREE_VAR): Rewrite so as not to use empty "else",
4815 which gcc can warn about.
da053e48 4816 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4817 (RETALLOC_IF): Define only if needed.
4818 (WORDCHAR_P): Likewise. This one is never needed, but is used
4819 only in a comment talking about a compiler bug, so put inside
4820 the #if 0 of that comment.
4821 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4822 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4823 Remove; unused.
19ed5445 4824
1f3561e4 4825 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4826 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4827 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4828
ded6f8f7
PE
4829 * search.c (simple_search): Remove unused var.
4830
dbd37a95
PE
4831 * dired.c (compile_pattern): Move decl from here ...
4832 * lisp.h: ... to here, so that it can be checked.
4833 (struct re_registers): New forward decl.
4834
7e47afad
PE
4835 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4836
85f24f61
PE
4837 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4838 All uses changed.
4839 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4840 Rename locals to avoid shadowing.
5671df8f 4841 (Fvertical_motion): Mark locals as initialized.
85f24f61 4842
181aa2be 4843 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4844 (casify_region): Mark local as initialized.
181aa2be 4845
930d429c
PE
4846 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4847
7082eac6
PE
4848 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4849 New macros, so that the caller can use some names other than
4850 gcpro1, gcpro2, etc.
4851 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4852 of the new macros.
4853 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4854 argument, for consistency with GCPRO2_VAR, etc: it is now the
4855 prefix of the variable, not the variable itself. All uses
4856 changed.
38b2c076
PE
4857 * dired.c (directory_files_internal, file_name_completion):
4858 Rename locals to avoid shadowing.
4859
15206ed9
PE
4860 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4861 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4862 dired.c's scmp function, had undefined behavior.
4863 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4864 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4865 * buffer.h: ... to here, because these macros use current_buffer,
4866 and the new implementation with inline functions needs to have
4867 current_buffer in scope now, rather than later when the macros
4868 are used.
4869 (downcase, upcase1): New static inline functions.
4870 (DOWNCASE, UPCASE1): Reimplement using these functions.
4871 This avoids undefined behavior in expressions like
4872 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4873 from race conditions in accessing the global variables
4874 case_temp1 and case_temp2.
4875 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4876 * lisp.h (case_temp1, case_temp2): Remove their decls.
4877 * character.h (ASCII_CHAR_P): Move from here ...
4878 * lisp.h: ... to here, so that the inline functions mentioned
4879 above can use them.
4880
4a6bea26
PE
4881 * dired.c (directory_files_internal_unwind): Now static.
4882
f14b7e14
PE
4883 * fileio.c (file_name_as_directory, directory_file_name):
4884 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4885 Now static.
2893f146
PE
4886 (file_name_as_directory): Use const pointers when appropriate.
4887 (Fexpand_file_name): Likewise. In particular, newdir might
4888 point at constant storage, so make it a const pointer.
fd4ead52 4889 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4890 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4891 signedness issues.
f839df0c
PE
4892 (Fset_file_times, Finsert_file_contents, auto_save_error):
4893 Rename locals to avoid shadowing.
f14b7e14 4894
5716756e 4895 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4896 (Ftry_completion, Fall_completions): Rename or remove locals
4897 to avoid shadowing.
5716756e 4898
b4c3046a
PE
4899 * marker.c (bytepos_to_charpos): Remove; unused.
4900
b45db522
PE
4901 * lisp.h (verify_bytepos, count_markers): New decls,
4902 so that gcc does not warn that these functions aren't declared.
4903
85876d07
PE
4904 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4905 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4906 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4907 (copy_text): Remove unused local var.
85876d07 4908
03d78a21 4909 * filelock.c (within_one_second): Now static.
b3dd38ab 4910 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4911
5df8f01b
PE
4912 * buffer.c (fix_overlays_before): Mark locals as initialized.
4913 (fix_start_end_in_overlays): Likewise. This function should be
4914 simplified by using pointers-to-pointers, but that's a different
4915 matter.
b1d876f1 4916 (switch_to_buffer_1): Now static.
8f54f30a
PE
4917 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4918 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4919
a70072c9 4920 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4921 Fix pointer signedness issue.
edced198
PE
4922 (sys_subshell): Mark local as volatile if checking for lint,
4923 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4924 (MAXPATHLEN): Define only if needed.
a70072c9 4925
a0977c44
PE
4926 * process.c (serial_open, serial_configure): Move decls from here ...
4927 * systty.h: ... to here, so that they can be checked.
4928
a884fdcc
PE
4929 * fns.c (get_random, seed_random): Move extern decls from here ...
4930 * lisp.h: ... to here, so that they can be checked.
4931
604efe86 4932 * sysdep.c (reset_io): Now static.
b8950c94 4933 (wait_for_termination_signal): Remove; unused.
604efe86 4934
38fc62d9
PE
4935 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4936 (copy_keymap_item, append_key, push_text_char_description):
4937 Now static.
1004a21a 4938 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4939 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4940 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4941 (describe_map_tree):
4942 Rename locals to avoid shadowing.
38fc62d9 4943
2f2650da
PE
4944 * keyboard.c: Declare functions static if they are not used elsewhere.
4945 (echo_char, echo_dash, cmd_error, top_level_2):
4946 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4947 (read_char, kbd_buffer_get_event, make_lispy_position):
4948 (make_lispy_event, make_lispy_movement, apply_modifiers):
4949 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4950 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4951 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4952 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4953 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4954
a053e86c 4955 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4956 (mark_kboards): Move decl here ...
4957 * alloc.c (mark_kboards): ... from here.
a053e86c 4958
4752793e
PE
4959 * lisp.h (force_auto_save_soon): New decl.
4960
74f10ca7 4961 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4962 (DEFINE_DUMMY_FUNCTION): New macro.
4963 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4964 Use it.
c03cd23f
PE
4965 (main): Add casts to avoid warnings
4966 if GCC considers string literals to be constants.
74f10ca7 4967
022e70d4
PE
4968 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4969
59d6fe83
PE
4970 * dbusbind.c: Pointer signedness fixes.
4971 (xd_signature, xd_append_arg, xd_initialize):
4972 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4973 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4974 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4975 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4976
78320123
PE
4977 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4978 if GCC considers string literals to be constants.
49cebcca 4979 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4980
35ac2a97
SM
49812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4982
fb103ca9
SM
4983 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4984 (print_preprocess, print_object): New macro to fix last change.
4985
35ac2a97
SM
4986 * print.c (print_preprocess): Don't forget font objects.
4987
62973b41
JB
49882011-03-16 Juanma Barranquero <lekktu@gmail.com>
4989
4990 * emacs.c (USAGE3): Doc fixes.
4991
0e48bb22
AS
49922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4993
4994 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4995 structure.
4996
7684e57b
JB
49972011-03-14 Juanma Barranquero <lekktu@gmail.com>
4998
4999 * lisp.h (VWindow_system, Qfile_name_history):
5000 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5001 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5002 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5003
5004 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5005 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5006
5007 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5008 * w32console.c (detect_input_pending, read_input_pending)
5009 (encode_terminal_code):
5010 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5011 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5012 (w32_system_caret_y, Qfile_name_history):
5013 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5014 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5015 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5016 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5017 * w32proc.c (Qlocal, report_file_error):
5018 * w32term.c (Vwindow_system, updating_frame):
5019 * w32uniscribe.c (initialized, uniscribe_font_driver):
5020 Remove unneeded extern declarations.
5021
2aa46d6c
CY
50222011-03-14 Chong Yidong <cyd@stupidchicken.com>
5023
c96bbc66 5024 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5025
cffc6f3b
CY
50262011-03-13 Chong Yidong <cyd@stupidchicken.com>
5027
5028 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5029 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5030 These macros can no longer be used for assignment.
5031
44f230aa
SM
5032 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5033 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5034 (record_buffer_markers, fetch_buffer_markers): New functions for
5035 recording and fetching special buffer markers.
5036 (set_buffer_internal_1, set_buffer_temp): Use them.
5037
5038 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5039
5040 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5041
5042 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5043 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5044
5045 * xdisp.c (hscroll_window_tree):
5046 (reconsider_clip_changes): Use PT instead of BUF_PT.
5047
d251f04b
EZ
50482011-03-13 Eli Zaretskii <eliz@gnu.org>
5049
5050 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5051 $(EMACS_ROOT)/lib/intprops.h.
5052
f0c77cd1
PE
50532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5054
3eca4629
PE
5055 Fix more problems found by GCC 4.5.2's static checks.
5056
7c86ee98
PE
5057 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5058 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5059 (xg_free_frame_widgets): Make it clear that a local variable is
5060 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5061 (gdk_window_get_screen): Make it clear that this macro is needed
5062 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5063 (int_gtk_range_get_value): New function, which avoids a diagnostic
5064 from gcc -Wbad-function-cast.
5065 (xg_set_toolkit_scroll_bar_thumb): Use it.
5066 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5067 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5068 (get_utf8_string, xg_get_file_with_chooser):
5069 Rename locals to avoid shadowing.
5070 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5071
41729b81
PE
5072 * xgselect.c (xg_select): Remove unused var.
5073
f0c77cd1
PE
5074 * image.c (four_corners_best): Mark locals as initialized.
5075 (gif_load): Initialize transparent_p to zero (Bug#8238).
5076 Mark another local as initialized.
ec6cf4c6 5077 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5078
ce0ad53d 5079 * image.c (clear_image_cache): Now static.
d5d5a617 5080 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5081 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5082 (x_edge_detection): Remove unnecessary cast that
5083 gcc -Wbad-function-cast diagnoses.
2037898d 5084 (gif_load): Fix pointer signedness.
6ae141d6
PE
5085 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5086 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5087
33383987 50882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5089
d32df629
PE
5090 Improve quality of tests for time stamp overflow.
5091 For example, without this patch (encode-time 0 0 0 1 1
5092 1152921504606846976) returns the obviously-bogus value (-948597
5093 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5094 reports time overflow. See
5095 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5096 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5097 * editfns.c: Include limits.h and intprops.h.
5098 (TIME_T_MIN, TIME_T_MAX): New macros.
5099 (time_overflow): Move earlier, to before first use.
5100 (hi_time, lo_time): New functions, for an accurate test for
5101 out-of-range times.
5102 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5103 (Fget_internal_run_time): Don't assume time_t fits in int.
5104 (make_time): Use list2 instead of Fcons twice.
5105 (Fdecode_time): More accurate test for out-of-range times.
5106 (check_tm_member): New function.
5107 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5108 (lisp_time_argument): Don't rely on undefined left-shift and
5109 right-shift behavior when checking for time stamp overflow.
8be6f318 5110
fe31d94c
PE
5111 * editfns.c (time_overflow): New function, refactoring common code.
5112 (Fformat_time_string, Fdecode_time, Fencode_time):
5113 (Fcurrent_time_string): Use it.
5114
8be6f318
PE
5115 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5116 * dired.c (make_time): Move to ...
5117 * editfns.c (make_time): ... here.
5118 * systime.h: Note the move.
5119
09d9db2c 51202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5121
126bc0dc
YM
5122 * fringe.c (update_window_fringes): Remove unused variables.
5123
c47cbdfd
YM
5124 * unexmacosx.c (copy_data_segment): Also copy __got section.
5125 (Bug#8223)
5126
7ac80be9
EZ
51272011-03-12 Eli Zaretskii <eliz@gnu.org>
5128
c96bbc66 5129 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5130 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5131 Constify `char *' arguments and their references according to
5132 prototypes in tparam.h.
5133
ecb0f94d 5134 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5135
7ac80be9
EZ
5136 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5137 Adapt all references accordingly.
5138
5139 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5140
ef1fd07e
TT
51412011-03-11 Tom Tromey <tromey@redhat.com>
5142
5143 * buffer.c (syms_of_buffer): Remove obsolete comment.
5144
7ef4b50c
EZ
51452011-03-11 Eli Zaretskii <eliz@gnu.org>
5146
5147 * termhooks.h (encode_terminal_code): Declare prototype.
5148
5149 * msdos.c (encode_terminal_code): Don't declare prototype.
5150
5151 * term.c (encode_terminal_code): Now external again, used by
5152 w32console.c and msdos.c.
5153
44f230aa
SM
5154 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5155 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5156
4b1ec863 51572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5158
1714f52b 5159 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5160
4b1ec863
PE
5161 * fringe.c (update_window_fringes): Mark locals as initialized
5162 (Bug#8227).
5163 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5164
524c7aa6
PE
5165 * alloc.c (mark_fringe_data): Move decl from here ...
5166 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5167 to check its interface.
5168 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5169
a5c0af81 5170 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5171 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5172 (fontset_font): Mark local as initialized.
a9a06e0b 5173 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5174
b4716021
PE
5175 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5176
811e9bac 5177 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5178 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5179 (x_own_selection, Fx_disown_selection_internal): Rename locals
5180 to avoid shadowing.
5181 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5182
7e3ab302
PE
5183 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5184 so that the caller can use some name other than gcpro1.
5185 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5186 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5187 (Fx_backspace_delete_keys_p):
5188 Use them to avoid shadowing, and rename vars to avoid shadowing.
5189 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5190 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5191 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5192 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5193 Remove unused locals.
7e3ab302
PE
5194 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5195 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5196 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5197 macros.
f78faa98 5198
e2b13473
PE
5199 * xterm.h (x_mouse_leave): New decl.
5200
77f23912
PE
5201 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5202 Remove unused functions.
cdf4ba58
PE
5203 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5204 (x_calc_absolute_position): Now static.
7411c686 5205 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5206 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5207 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5208 unless they are used.
38d0b34a
PE
5209 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5210 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5211 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5212 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5213 (x_error_catcher, x_connection_closed, x_error_handler):
5214 (x_error_quitter, xembed_send_message, x_iconify_frame):
5215 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5216 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5217 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5218
44f230aa
SM
5219 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5220 Rename or move locals to avoid shadowing.
6b463e58 5221 (tty_defined_color, merge_face_heights): Now static.
5967d051 5222 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5223 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5224 does not deduce is never used uninitialized.
73719eba
PE
5225 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5226 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5227
426994c3 5228 * terminal.c (store_terminal_param): Now static.
5489860b 5229
032f1620 5230 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5231 (set_frame_menubar): Remove unused local.
d4323972 5232 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5233 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5234 since they might point to immutable storage.
281585b0
PE
5235 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5236 since it's unused otherwise.
032f1620 5237
367c19e5 5238 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5239 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5240 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5241 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5242 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5243 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5244 does not deduce are never used uninitialized.
70739cbe 5245
07b48fa9
PE
5246 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5247
8868a238 5248 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5249 * window.c (window_loop, size_window):
5250 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5251
7e5cf297 5252 * window.c (display_buffer): Now static.
d6550a9f
PE
5253 (size_window): Mark variables that gcc -Wuninitialized
5254 does not deduce are never used uninitialized.
a586633d
PE
5255 * window.h (check_all_windows): New decl, to forestall
5256 gcc -Wmissing-prototypes diagnostic.
5b555da1 5257 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5258
f6095868
PE
5259 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5260 shadowing.
5261 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5262 Include <limits.h>.
5263 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5264 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5265 (load_charset_map): Mark variables that gcc -Wuninitialized
5266 does not deduce are never used uninitialized.
53df7c11 5267 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5268
f38b440c
PE
5269 * coding.c (coding_set_source, coding_set_destination):
5270 Use "else { /* comment */ }" rather than "else /* comment */;"
5271 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5272 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5273 a block, when the outer 'i' will do.
5274 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5275 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5276 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5277 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5278 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5279 Rename locals to avoid shadowing.
5280 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5281 * coding.c (emacs_mule_char, encode_invocation_designation):
5282 Now static, since they're not used elsewhere.
413bb2db 5283 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5284 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5285 (decode_coding_emacs_mule): Mark variables that gcc
5286 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5287 (detect_coding_iso_2022): Initialize a local variable that might
5288 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5289 this initialization is needed. (Bug#8211)
5f58e762
PE
5290 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5291 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5292 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5293 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5294 Remove unused macros.
f38b440c 5295
232b38b9 5296 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5297 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5298 * character.c (string_count_byte8): Likewise.
232b38b9 5299
fb90da1b
PE
5300 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5301 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5302
fb93dbc2
PE
5303 * chartab.c (copy_sub_char_table): Now static, since it's not used
5304 elsewhere.
5c156ace
PE
5305 (sub_char_table_ref_and_range, char_table_ref_and_range):
5306 Rename locals to avoid shadowing.
bbcd0949 5307 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5308
7d3b3862 5309 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5310 (BIDI_BOB): Remove unused macro.
7d3b3862 5311
6be7d3da
PE
5312 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5313 deduce are never used uninitialized.
c2ed9c8b 5314 * term.c (encode_terminal_code): Likewise.
6be7d3da 5315
75f8807f 5316 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5317
50938595
PE
5318 * tparam.h: New file.
5319 * term.c, tparam.h: Include it.
5320 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5321 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5322 Move these decls to tparam.h, and make them agree with what
5323 is actually in tparam.c. The previous trick of using incompatible
5324 decls in different modules does not conform to the C standard.
5325 All callers of tparam changed to use tparam's actual API.
5326 * tparam.c (tparam1, tparam, tgoto):
5327 Use const pointers where appropriate.
5328
fbceeba2
PE
5329 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5330 * cm.h (struct cm): Likewise.
5331 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5332 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5333 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5334 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5335 (turn_on_face, init_tty): Likewise.
5336 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5337
7f3f1250
PE
5338 * term.c (term_mouse_position): Rename local to avoid shadowing.
5339
e6ca6543
PE
5340 * alloc.c (mark_ttys): Move decl from here ...
5341 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5342
c40f8d15
AS
53432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5344
5345 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5346
cfe0661d
JB
53472011-03-09 Juanma Barranquero <lekktu@gmail.com>
5348
5349 * search.c (compile_pattern_1): Remove argument regp, unused since
5350 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5351 (compile_pattern): Don't pass it.
5352
0afb4571
J
53532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5354
5355 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5356 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5357 for ! HAVE_GTK3.
5358 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5359
5360 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5361
5362 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5363 gdk_window_get_screen, gdk_window_get_geometry,
5364 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5365 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5366 (xg_get_pixbuf_from_pixmap): New function.
5367 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5368 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5369 Call xg_get_pixbuf_from_pixmap instead of
5370 gdk_pixbuf_get_from_drawable.
5371 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5372 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5373 (xg_check_special_colors): Use GtkStyleContext and its functions
5374 for HAVE_GTK3.
5375 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5376 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5377 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5378 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5379 Call gtk_widget_get_preferred_size.
0afb4571
J
5380 (xg_frame_resized): gdk_window_get_geometry only takes 5
5381 parameters.
44f230aa
SM
5382 (xg_win_to_widget, xg_event_is_for_menubar):
5383 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5384 (xg_set_widget_bg): New function.
5385 (delete_cb): New function.
895009e1 5386 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5387 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5388 (xg_set_background_color): Call xg_set_widget_bg.
5389 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5390 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5391 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5392 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5393 if ! HAVE_GTK3.
5394 (update_frame_tool_bar): Call gtk_widget_hide.
5395 (xg_initialize): Use GDK_KEY_g.
5396
5397 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5398 if ! HAVE_GTK3
5399 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5400
5401 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5402 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5403 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5404
1c2cc4ef
JB
54052011-03-08 Juanma Barranquero <lekktu@gmail.com>
5406
5407 * w32xfns.c (select_palette): Check success of RealizePalette against
5408 GDI_ERROR, not zero.
5409
33383987 5410See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5411
5412;; Local Variables:
5413;; coding: utf-8
aac0c6e3
MR
5414;; End:
5415
33383987 5416 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5417
5418 This file is part of GNU Emacs.
5419
5420 GNU Emacs is free software: you can redistribute it and/or modify
5421 it under the terms of the GNU General Public License as published by
5422 the Free Software Foundation, either version 3 of the License, or
5423 (at your option) any later version.
5424
5425 GNU Emacs is distributed in the hope that it will be useful,
5426 but WITHOUT ANY WARRANTY; without even the implied warranty of
5427 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5428 GNU General Public License for more details.
5429
5430 You should have received a copy of the GNU General Public License
5431 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.