More doc fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
55802e4a
CY
12012-08-14 Chong Yidong <cyd@gnu.org>
2
4abcdac8
CY
3 * character.c (Fcharacterp): Doc fix (Bug#12076).
4
5 * data.c (Findirect_variable): Doc fix (Bug#11040).
6
55802e4a
CY
7 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
8
9 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 10 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 11
8e99d072
BR
122012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
13
14 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
15 (bug#12022).
16
08908aca
MR
172012-08-14 Martin Rudalics <rudalics@gmx.at>
18
19 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
20 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
21 * minibuf.c (choose_minibuf_frame, read_minibuf):
22 * w32fns.c (x_create_tip_frame):
23 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
24 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
25
56120d6f
PE
262012-08-14 Paul Eggert <eggert@cs.ucla.edu>
27
28 * intervals.c (offset_intervals): Remove obsolete comment.
29
67b77c0b
AS
302012-08-14 Andreas Schwab <schwab@linux-m68k.org>
31
32 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
33
f48b82fd
GR
342012-08-14 Gergely Risko <gergely@risko.hu>
35
36 * coding.c (decode_coding): Record buffer modification before
37 disabling undo_list (Bug#11773).
38
fd318b54
DA
392012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
40
41 Revert and cleanup some recent overlay changes.
42 * buffer.h (enum overlay_type): Remove.
43 (buffer_get_overlays, buffer_set_overlays): Likewise.
44 (buffer_set_overlays_before, buffer_set_overlays_after):
45 New function. Adjust users.
46 (unchain_both): Add eassert.
47
41a62dd9
DA
482012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
49
50 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
51
5884c324
PE
522012-08-14 Paul Eggert <eggert@cs.ucla.edu>
53
54 * gtkutil.c (xg_mark_data): Don't assume C99.
55
ca06f160
JD
562012-08-13 Jan Djärv <jan.h.d@swipnet.se>
57
58 * gtkutil.c (xg_frame_tb_info): New struct.
59 (TB_INFO_KEY): New define.
60 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
61 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
62 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
63 if not present.
64 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
65 is up to date. Otherwise store new data.
66 (free_frame_tool_bar): Free xg_frame_tb_info if present.
67
7864a3f7
DA
682012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
69
70 Use KSET for write access to Lisp_Object members of struct kboard.
71 * keyboard.h (KSET): New macro.
72 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
73 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
74 * xterm.c: Adjust users.
75
4c31be61
DA
762012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
77
78 Use BSET for write access to Lisp_Object members of struct buffer.
79 * buffer.h (BSET): New macro.
80 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
81 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
82 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
83 * window.c, xdisp.c, xfns.c: Adjust users.
84
14ae4239
BT
852012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
86
87 * lread.c (syms_of_lread): Initialize Vlexical_binding.
88
32bcadb4
JD
892012-08-11 Jan Djärv <jan.h.d@swipnet.se>
90
3d29b2ce
JD
91 * nsterm.m (not_in_argv): New function.
92 (application:openFile, application:openTempFile:):
93 (application:openFileWithoutUI:, application:openFiles:): Open file
94 if not_in_argv returns non-zero (bug#12171).
95
32bcadb4 96 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
97 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
98 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
99 (xg_get_font_name): Use those functions/macros here.
100 Reported by Frans Oilinki <moilinki@gmail.com>.
101
9ff9402d 1022012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
103
104 * unexmacosx.c (copy_data_segment): Copy initialized data in
105 statically linked libraries from input file rather than memory.
106
db74a5fc
YM
107 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
108 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
109 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
110
25e65510
GM
1112012-08-10 Glenn Morris <rgm@gnu.org>
112
113 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
114 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
115
7961135c
DA
1162012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
117
118 Fix last change to allow compilation with low optimization levels.
119 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
120 Reported by Jan Djärv <jan.h.d@swipnet.se>.
121
42b3a444
DA
1222012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
123
124 Use common inline syntax in intervals.h.
125 * intervals.h (INTERVALS_INLINE): New macro.
126 Change all users from LISP_INLINE.
127
9fb0c957
DA
1282012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
129
130 Define Qnone once for all platforms.
131 * frame.c (Qnone): Define here.
132 (syms_of_frame): DEFSYM it.
133 * lisp.h (Qnone): New declaration.
134 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
135 * xfns.c: Remove duplication. Adjust users.
136
65e8ee52
DA
1372012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
138
139 Remove unused macros from intervals.h.
140 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
141 * intervals.c: Adjust comment.
142
9b855fd6
EZ
1432012-08-10 Eli Zaretskii <eliz@gnu.org>
144
145 * w32fns.c <w32_unicode_gui>: New static variable.
146 (globals_of_w32fns): Initialize it according to os_subtype.
147 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
148 testing os_subtype.
149
39cb9e56 1502012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
151 Eli Zaretskii <eliz@gnu.org>
152
153 Fix bug #10299 with Unicode characters sent by customized
154 keyboards created by MSKLC.
155 * w32fns.c (INIT_WINDOW_CLASS): New macro.
156 (w32_init_class): Use it to initialize the Emacs class with either
157 ANSI or Unicode API calls.
158 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
159 later.
160 (w32_wnd_proc): If the character code sent by WM_CHAR or
161 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
162 original message. Call DefWindowProcW on NT and later.
163
9374581a
GM
1642012-08-10 Glenn Morris <rgm@gnu.org>
165
4b94e8cf
GM
166 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
167
9374581a
GM
168 * lisp.h (DIRECTORY_SEP): Let configure set it.
169
a2752828
DA
1702012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
171
172 Use TSET for write access to Lisp_Object slots of struct terminal.
173 * termhooks.h (TSET): New macro.
174 * coding.c, terminal.c, xselect.c: Adjust users.
175
cc92c454
SM
1762012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
177
178 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
179 the failing expression, include them in the error message.
180 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
181 * lisp.h (internal_condition_case_n): Update declaration.
182
4cb3e6b3
DA
1832012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
184
185 Inline functions to examine and change buffer overlays.
186 * buffer.c (unchain_both): New function.
187 * buffer.h (buffer_get_overlays, buffer_set_overlays):
188 (buffer_has_overlays): New function.
189 (enum overlay_type): New enum.
190 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
191 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
192
8707c1e5
DA
1932012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
194
195 Inline functions to examine and change buffer intervals.
196 * alloc.c (mark_interval_tree): Remove.
197 (MARK_INTERVAL_TREE): Simplify.
198 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
199 * intervals.c (buffer_balance_intervals): New function.
200 (graft_intervals_into_buffer): Adjust indentation.
201 (set_intervals_multibyte): Simplify.
202 * buffer.h (BUF_INTERVALS): Remove.
203 (buffer_get_intervals, buffer_set_intervals): New function.
204 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
205 * intervals.c, textprop.c: Adjust users.
206
ad8c997f
DA
2072012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
208
209 Inline functions to examine and change string intervals.
210 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
211 (string_get_intervals, string_set_intervals): New function.
212 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
213 * lread.c, print.c, textprop.c: Adjust users.
214
32ac3a6b
GM
2152012-08-08 Glenn Morris <rgm@gnu.org>
216
217 * lisp.mk (lisp): Remove language/persian.elc.
218
77c7bcb1
DA
2192012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
220
221 Cleanup intervals.
222 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
223 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
224 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
225 Adjust comment. Move under #if 0.
77c7bcb1
DA
226 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
227 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
228
9c08a8d4
DA
2292012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
230
231 Check total length of intervals with eassert.
232 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
233 * intervals.c: Change all users to eassert.
234
26d16b35
EZ
2352012-08-07 Eli Zaretskii <eliz@gnu.org>
236
14ae4239
BT
237 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
238 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
239 INTERNAL_FIELD in Lisp_Cons.
240
c644523b
DA
2412012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
242
243 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
244 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
245 name since all xname users are fixed long time ago. Do not
246 use INTERNAL_FIELD.
247 (set_symbol_name, set_symbol_function, set_symbol_plist):
248 (set_symbol_next, set_overlay_plist): New function.
249 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
250 (struct Lisp_Overlay): Likewise.
251 (CVAR, MVAR, SVAR): Remove.
252 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
253 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
254 * xterm.c: Adjust users.
255 * .gdbinit: Change to use name field of struct Lisp_Symbol
256 where appropriate.
257
6a3d20cc
DA
2582012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
259
260 Basic functions to set Lisp_Object and pointer slots of intervals.
261 * intervals.h (interval_set_parent, interval_set_object):
262 (interval_set_left, interval_set_right, interval_set_plist):
263 (interval_copy_parent): New function.
264 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
265 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
266 Adjust indentation.
6a3d20cc
DA
267 (INTERVAL_SIZE): Remove. Adjust users.
268 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
269
4d2b044c
DA
2702012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
271
272 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
273 * process.h (PGET): Remove.
274 (struct Lisp_Process): Do not use INTERNAL_FIELD.
275 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
276
d3d50620
DA
2772012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
278
279 Drop WGET and revert read access to Lisp_Objects slots of struct window.
280 * window.h (WGET): Remove.
281 (struct window): Do not use INTERNAL_FIELD.
282 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
283 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
284 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
285 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
286 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
287 Adjust users.
288
d10a51dc
CY
2892012-08-07 Chong Yidong <cyd@gnu.org>
290
291 * window.c (Fwindow_edges, Fwindow_pixel_edges)
292 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
293 (Fdelete_window_internal): Signal an error if the window is not on
294 a live frame (Bug#12025).
295
e69b0960
DA
2962012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
297
298 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
299 * frame.h (FGET): Remove.
300 (struct frame): Do not use INTERNAL_FIELD.
301 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
302 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
303 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
304 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
305
25a20a3a
JB
3062012-08-06 Juanma Barranquero <lekktu@gmail.com>
307
308 * w32.c: Silence compiler warnings.
309 (map_w32_filename): Remove unused variable `is_fat'.
310 (chase_symlinks): Add parentheses around expression.
311
1c6f11f4
GM
3122012-08-06 Glenn Morris <rgm@gnu.org>
313
1db4583a
GM
314 * sysdep.c: Respect BROKEN_GETWD.
315
1c6f11f4
GM
316 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
317 Let configure handle it.
318 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
319
2b90362b
DA
3202012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
321
322 Use GCALIGNMENT where appropriate.
323 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
324 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
325 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
326
5f50daf2
EZ
3272012-08-06 Eli Zaretskii <eliz@gnu.org>
328
14ae4239
BT
329 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
330 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 331
cbcc7007
SM
3322012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
333
334 * buffer.h (struct buffer): Revert `indirections' to a simple int;
335 that should be sufficient for everyone.
336
4d365fa4
JD
3372012-08-06 Jan Djärv <jan.h.d@swipnet.se>
338
339 * keyboard.c (timer_check_2): Add break so timer_check returns next
340 timeout.
341
dd86bd82
DA
3422012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
343
344 Fix Windows build errors introduced after converting to WGET and WSET.
345 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
346 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
347
054e1668
JD
3482012-08-06 Jan Djärv <jan.h.d@swipnet.se>
349
350 * nsterm.m (ns_frame_rehighlight): Use FSET.
351
352 * nsmenu.m (ns_update_menubar): Use FSET.
353
21238f11
DA
3542012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
355
356 Separate read and write access to Lisp_Object slots of Lisp_Process.
357 * process.h (PGET, PSET): New macros similar to AREF and ASET.
358 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
359
077288cf
DA
3602012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
361
362 Separate read and write access to Lisp_Object slots of struct window.
363 * window.h (WGET, WSET): New macros similar to AREF and ASET.
364 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
365 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
366 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
367 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
368 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
369 Adjust users.
370
71688bd7
DA
3712012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
372
373 Fix Windows build errors introduced after converting to FGET and FSET.
374 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
375 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
376 (w32_judge_scroll_bars): Change to use FSET.
377 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
378
f99bac93
DA
3792012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
380
381 Fix replacement typo.
382 * window.c (replace_window): Set root_window instead of
383 selected_window. This fixes a total window subsystem
384 malfunction reported by Bastien Guerry <bzg@gnu.org>.
385
8c2a0f2d
GM
3862012-08-06 Glenn Morris <rgm@gnu.org>
387
388 * lisp.mk (lisp): Add language/persian.elc.
389
edd74c35
DA
3902012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
391
392 Separate read and write access to Lisp_Object slots of struct frame.
393 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
394 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
395 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
396 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
397 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
398
8671676c
AS
3992012-08-05 Andreas Schwab <schwab@linux-m68k.org>
400
401 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
402
663e2b3f
DA
4032012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
404
405 Generalize common compile-time constants.
406 * lisp.h (header_size, bool_header_size, word_size): Now here.
407 (struct Lisp_Vector): Add comment.
408 (struct Lisp_Bool_Vector): Move up to define handy constants.
409 (VECSIZE, PSEUDOVECSIZE): Simplify.
410 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
411 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
412 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
413 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
414 * xfont.c, xmenu.c: Use word_size where appropriate.
415
d32e47af
LM
4162012-08-05 Lawrence Mitchell <wence@gmx.li>
417
418 * search.c (Freplace_match): Treat \? in the replacement text
419 literally (Bug#8161).
420
e5d9c0d1
CY
4212012-08-05 Chong Yidong <cyd@gnu.org>
422
423 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
424 * frame.c (Vdelete_frame_functions):
425 * emacs.c (Vkill_emacs_hook): Doc fix.
426
8da0576b
EZ
4272012-08-04 Eli Zaretskii <eliz@gnu.org>
428
429 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
430 --with-x-toolkit=no builds.
431 Reported by Carsten Mattner <carstenmattner@gmail.com>.
432
02676e5d
CY
4332012-08-04 Chong Yidong <cyd@gnu.org>
434
435 * syntax.c (Fmodify_syntax_entry): Doc fix.
436
97147da9
EZ
4372012-08-04 Eli Zaretskii <eliz@gnu.org>
438
76151e2c
EZ
439 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
440 * w32.c (init_environment): Change the default values of many
441 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
442 them into environment when they were not already defined.
443 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 444 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
445 (check_windows_init_file): Now external, not static.
446 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
447 called when Vload_path is already set up.
448
449 * w32.h (check_windows_init_file): Add prototype.
450
451 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
452 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
453 compatibility with Posix platforms.
454 (main): Move the call to check_windows_init_file to here from
455 w32.c.
456 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
457 any, in the DEFALT argument into the root of the Emacs build or
458 installation tree, as appropriate.
459
460 * callproc.c (init_callproc_1): Call decode_env_path instead of
461 doing its equivalent by hand.
462 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
463 the code that sets Vexec_path run on MS-Windows.
464
465 * lread.c (init_lread): Add comments to #ifdef's.
466
97147da9
EZ
467 * msdos.c (dos_set_window_size, IT_update_begin)
468 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
469 instead of direct references.
470
185ee146
PE
4712012-08-04 Paul Eggert <eggert@cs.ucla.edu>
472
473 Export DEFAULT_REHASH_* to GDB.
474 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
475 Now constants, not macros.
476
8834c57a
PE
4772012-08-03 Paul Eggert <eggert@cs.ucla.edu>
478
98c6f1e3
PE
479 Remove unnecessary casts involving pointers.
480 These casts are no longer needed now that we assume C89 or later,
481 since they involve casting to or from void *.
482 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
483 (make_pure_float, make_pure_vector):
484 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
485 * macros.c (Fstart_kbd_macro):
486 * menu.c (find_and_return_menu_selection):
487 * minibuf.c (read_minibuf_noninteractive):
488 * sysdep.c (closedir):
489 * xdisp.c (x_produce_glyphs):
490 * xfaces.c (compare_fonts_by_sort_order):
491 * xfns.c (x_real_positions, select_visual):
492 * xselect.c (x_stop_queuing_selection_requests)
493 (x_get_window_property, x_get_window_property_as_lisp_data):
494 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
495 Remove unnecessary pointer casts.
496 * alloc.c (record_xmalloc): New function.
497 * lisp.h (record_xmalloc): New decl.
498 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
499 more like a function. This is because the pointer cast is not
500 needed. All uses changed.
501 * print.c (print_string, print_error_message): Avoid length recalc.
502
8834c57a
PE
503 Improve fix for macroexp crash with debugging (Bug#12118).
504 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
505 ARRAY_MARK_FLAG when checking subscripts, because ASET is
506 not supposed to be invoked from the garbage collector.
507 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
508 (gc_aset): New function, which is like ASET but can be
509 used in the garbage collector.
510 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
511 (set_hash_index): Use it instead of ASET.
512
6dad7178
EZ
5132012-08-03 Eli Zaretskii <eliz@gnu.org>
514
515 Support symlinks on latest versions of MS-Windows.
516 * w32.c: Include winioctl.h and aclapi.h.
517 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
518 (revert_to_self): Forward declarations of static functions.
519 <static BOOL g_b_init_get_security_info>:
520 <g_b_init_create_symbolic_link>: New static flags.
521 (globals_of_w32): Initialize them to zero.
522 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
523 (map_w32_filename): Improve commentary. Simplify switch.
524 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
525 headers (most versions of MinGW w32api don't).
526 (get_security_info, create_symbolic_link)
527 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
528 New functions.
529 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
530 in the argument file name.
531 (sys_access): Call unc_volume_file_attributes only if
532 GetFileAttributes fails with network-related error codes.
533 (sys_rename): Diagnose renaming of a symlink when the user doesn't
534 have the required privileges.
14ae4239 535 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
536 get_file_security_desc.
537 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
538 with addition of handling of symlinks and support for 'lstat'.
539 If possible, get file's attributes and security information by
6dad7178
EZ
540 handle, not by name. Produce S_IFLNK bit for symlinks, when
541 called from 'lstat'.
542 (stat, lstat): New functions, call 'stat_worker'.
543 (symlink, readlink, careadlinkat): Rewritten to create and resolve
544 symlinks when the underlying filesystem supports them.
545
f162bcc3
PE
5462012-08-02 Paul Eggert <eggert@cs.ucla.edu>
547
79ea6c20
PE
548 Fix macroexp crash on Windows with debugging (Bug#12118).
549 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
550 checking subscripts; problem introduced with the recent
551 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
552 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
553 since it's used in non-static inline functions now.
554
c0ce93fd
PE
555 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
556 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 557
f162bcc3
PE
558 Use C99-style 'extern inline' if available.
559 * buffer.h (BUFFER_INLINE):
560 * category.h (CATEGORY_INLINE):
561 * character.h (CHARACTER_INLINE):
562 * charset.h (CHARSET_INLINE):
563 * composite.h (COMPOSITE_INLINE):
564 * dispextern.h (DISPEXTERN_INLINE):
565 * lisp.h (LISP_INLINE):
566 * systime.h (SYSTIME_INLINE):
567 New macro, replacing 'static inline' in this header.
568 * buffer.h, category.h, character.h, charset.h, composite.h:
569 * dispextern.h, lisp.h, systime.h:
570 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
571 * alloc.c (LISP_INLINE):
572 * buffer.c (BUFFER_INLINE):
573 * category.c (CATEGORY_INLINE):
574 * character.c (CHARACTER_INLINE):
575 * charset.c (CHARSET_INLINE):
576 * composite.c (COMPOSITE_INLINE):
577 * dispnew.c (DISPEXTERN_INLINE):
578 * sysdep.c (SYSTIME_INLINE):
579 Define to EXTERN_INLINE, so that the corresponding functions
580 are compiled into code.
581 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
582 (INLINE_HEADER_END): New macros.
583 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
584 since it's used in non-static inline functions now.
a8333d03 585 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 586
837b365b
GM
5872012-08-02 Glenn Morris <rgm@gnu.org>
588
d66b744d
GM
589 * s/: Remove empty directory.
590
837b365b
GM
591 * s/ms-w32.h: Move to ../nt/inc.
592 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
593 Update for new ms-w32.h location.
594
13294f95
PE
5952012-08-02 Paul Eggert <eggert@cs.ucla.edu>
596
597 Port to Solaris 8.
598 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
599
90df0db3
GM
6002012-08-02 Glenn Morris <rgm@gnu.org>
601
602 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
603 hard-coding the path separator.
604
4939150c
PE
6052012-08-01 Paul Eggert <eggert@cs.ucla.edu>
606
607 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
608 This how ASET and AREF are supposed to work, and makes
609 it easier to think about future improvements. See
610 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
611 * charset.h (set_charset_attr): New function.
612 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
613 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
614 (aref_addr): New function. All uses of &AREF(...) changed.
615 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
616 (set_hash_index): New functions. All lvalue-style uses of
617 HASH_KEY etc. changed.
618 * keyboard.c (set_prop): New function. All lvalue-style uses
619 of PROP changed.
620
947b2afd
AA
6212012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
622
623 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
624 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
625 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
626 * nsfns.m (ns_set_name_as_filename): Likewise.
627 * nsmenu.m (ns_update_menubar): Likewise.
628 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
629
4f5d0325
EZ
6302012-08-01 Eli Zaretskii <eliz@gnu.org>
631
2008beae
EZ
632 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
633 Adapt to latest changes in field names of the corresponding Lisp
288479f6 634 objects.
2008beae 635
4f5d0325
EZ
636 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
637
fe3cc771
GM
6382012-08-01 Glenn Morris <rgm@gnu.org>
639
640 * s/msdos.h: Remove file.
641 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
642 * Makefile.in (S_FILE): Remove.
643 (config_h): Remove S_FILE.
644
c90acc54
JB
6452012-08-01 Juanma Barranquero <lekktu@gmail.com>
646
647 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
648 Remove; moved to nt/config.nt.
649
d8a05828
DA
6502012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
651
652 Use INTERNAL_FIELD for conses and overlays.
653 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
654 Remove obsolete comment.
655 (MVAR): New macro.
656 (struct Lisp_Overlay): Use INTERNAL_FIELD.
657 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
658
8271d590
DA
6592012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
660
661 Use INTERNAL_FIELD for symbols.
662 * lisp.h (SVAR): New macro. Adjust users.
663 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
664 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
665
3193acd2
DA
6662012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
667
668 Use INTERNAL_FIELD for processes.
669 * process.h (PVAR): New macro. Adjust style.
670 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
671 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
672
3a45383a
DA
6732012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
674
675 Use INTERNAL_FIELD for windows.
676 * window.h (WVAR): New macro.
677 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
678 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
679 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
680 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
681 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
682 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
683
c1dbc63c
PE
6842012-08-01 Paul Eggert <eggert@cs.ucla.edu>
685
686 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
687
5c0c0e8a
GM
6882012-08-01 Glenn Morris <rgm@gnu.org>
689
690 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
691 Move to configure.ac.
692
552a99b4
JB
6932012-08-01 Juanma Barranquero <lekktu@gmail.com>
694
695 * makefile.w32-in (CONFIG_H): Update dependencies.
696 (CONF_POST_H): New macro.
697
698 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
699
8d8e2dfe
GM
7002012-07-31 Glenn Morris <rgm@gnu.org>
701
bc96620a
GM
702 * Makefile.in (S_FILE): No longer set by configure.
703
476b1b2d
GM
704 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
705 is available.
706 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
707
b2c7a106
GM
708 * process.h (NULL_DEVICE):
709 * emacs.c (SEPCHAR):
710 * editfns.c (USER_FULL_NAME): Let configure set them.
711
d53d062a
GM
712 * s/README, s/template.h: Remove files.
713
4515017f
GM
714 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
715
8d8e2dfe
GM
716 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
717 Move to configure.ac.
718
5b20b3cc
EZ
7192012-07-31 Eli Zaretskii <eliz@gnu.org>
720
1e0afd9a
EZ
721 * .gdbinit (xframe): Adapt to introduction of FVAR and the
722 resulting renaming of 'struct frame' members.
723
5b20b3cc
EZ
724 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
725
726 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
727 after introduction of FVAR.
728
f1310128
JD
7292012-07-31 Jan Djärv <jan.h.d@swipnet.se>
730
79e721e0
JD
731 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
732
733 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
734 instead of compositeToPoint.
735 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
736
8d7c7eed 737 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 738
e34f7f79
DA
7392012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
740
741 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
742 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 743 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
744 (BVAR): Change to use INTERNAL_FIELD.
745 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
746 (KVAR): Change to use INTERNAL_FIELD.
747 * frame.h (FVAR): New macro.
748 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
749 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
750 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
751 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
752 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
753
c09bfb2f
DA
7542012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
755
756 Miscellaneous fixes for non-default X toolkits.
757 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
758 * xterm.c (x_frame_of_widget): Remove redundant prototype.
759 Move under #ifdef USE_LUCID.
760 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
761 definition and usage to avoid warnings.
762
14c114ae
JD
7632012-07-31 Jan Djärv <jan.h.d@swipnet.se>
764
765 * nsterm.m (openFiles): Fix previous checkin.
766
3bd21e82
PE
7672012-07-31 Paul Eggert <eggert@cs.ucla.edu>
768
769 * indent.c (compute_motion): Remove unused local.
770
c1529ded
GM
7712012-07-31 Glenn Morris <rgm@gnu.org>
772
400d5621
GM
773 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
774
268e2432
GM
775 * conf_post.h [USG5_4]:
776 Move remaining contents of s/usg5-4-common.h here.
777 * s/usg5-4-common.h: Remove file.
778
7552f3ee
GM
779 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
780 * s/irix6-5.h: Remove file.
781
6a381852
GM
782 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
783 * s/darwin.h: Remove file.
784
c1529ded
GM
785 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
786 * s/hpux10-20.h: Remove file, which is now empty.
787
b429a4ee
GM
7882012-07-30 Glenn Morris <rgm@gnu.org>
789
790 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
791 * Makefile.in (config_h): Add conf_post.h.
792 * makefile.w32-in (CONFIG_H): Add conf_post.h.
793
adff3182
JD
7942012-07-30 Jan Djärv <jan.h.d@swipnet.se>
795
796 * nsterm.m (ns_do_open_file): New variable.
b9031d69 797 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
798 (openFile, openTempFile, openFileWithoutUI, openFiles):
799 Open files only if ns_do_open_file.
adff3182 800
c32af1e4
PE
8012012-07-30 Paul Eggert <eggert@cs.ucla.edu>
802
7393bcbb
PE
803 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
804 This no-op macro hasn't been needed for many years.
805 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
806
c32af1e4
PE
807 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
808 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
809 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
810 gdb_make_enums_visible.
811 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
812 (DIRECTORY_SEP): Now a constant, not a macro.
813
302fc036
EZ
8142012-07-30 Eli Zaretskii <eliz@gnu.org>
815
816 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
817 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
818
819 * w32term.c <w32_keyboard_codepage>: Renamed from
820 keyboard_codepage and now external. All users changed.
821
822 * w32term.h: Add declaration of w32_keyboard_codepage.
823
824 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
825 the codepage to translate keys to Unicode. If this argument is
826 -1, use the value returned by GetConsoleCP. All callers changed.
827
88fb40b4
PE
8282012-07-30 Paul Eggert <eggert@cs.ucla.edu>
829
0aee6912
PE
830 Update .PHONY listings in makefiles.
831 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
832 bootstrap-clean, distclean, maintainer-clean, versioclean,
833 extraclean, frc.
834
88fb40b4
PE
835 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
836 This is a bit clearer. Fix some commentary typos.
837
0a763bd1
GM
8382012-07-30 Glenn Morris <rgm@gnu.org>
839
32bac6d6
GM
840 * s/netbsd.h: Let configure include signal.h if needed.
841 Remove file, which is now empty.
842
b65e7c46
GM
843 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
844 Let configure set them.
845 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
846 No more need to undefine.
0a763bd1 847
169304bd
AS
8482012-07-30 Andreas Schwab <schwab@linux-m68k.org>
849
850 * keymap.c (Fkey_description): Don't remove 0x80 bit from
851 non-single-byte char when adding meta modifier. (Bug#12090)
852
6cd7a139
DA
8532012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
854
855 Convert safe_call to use variable number of arguments.
856 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
857 (safe_call2): Fix comment.
858 * lisp.h (safe_call): Adjust prototype.
859 * coding.c (encode_coding_object): Change to use safe_call2.
860 * xfaces.c (merge_face_heights): Change to use safe_call1.
861
d34d6ffc
GM
8622012-07-30 Glenn Morris <rgm@gnu.org>
863
7b8a48e4 864 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 865 does that unconditionally. Remove file, which is now empty.
7b8a48e4 866
d34d6ffc
GM
867 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
868 Remove empty files.
869
03a660a6
PE
8702012-07-30 Paul Eggert <eggert@cs.ucla.edu>
871
872 Export to GDB most of lisp.h's remaining object-like macros.
873 * lisp.h (min, max): Move earlier, because they're used earlier now.
874 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
875 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
876 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
877 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
878 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
879 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
880 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
881 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
882 Now constants, for GDB. They need not be macros.
883 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
884 Now constants, for GDB, as well as macros, for static initializers.
885 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
886 Move to after the definition of struct Lisp_Char_Table,
887 since the former now needs that type defined.
888 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
889 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
890 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
891 New enums, for gdb_make_enums_visible.
892 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 893 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
894 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
895 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
896 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
897 enum maxargs, enum MAX_ALLOCA.
898 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
899 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
900 no longer needed, now that they are done in lisp.h.
901
e499d0ee
DA
9022012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
903
904 Cleanup string bytes checking.
905 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
906 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
907 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
908 (check_sblock, compact_small_strings): Simplify.
909
d5040d2d
PE
9102012-07-29 Paul Eggert <eggert@cs.ucla.edu>
911
912 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
913 These macros are confusing and no longer need to be defined, as
914 the enum values now suffice. All uses replaced with definiens.
915 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
916
7f259ae6
JB
9172012-07-29 Juanma Barranquero <lekktu@gmail.com>
918
919 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
920 ($(BLD)/w32console.$(O)): Update dependencies.
921
7e63e0c3
DA
9222012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
923
924 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
925 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
926 time. Adjust users.
927 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
928
ffd817eb
JD
9292012-07-29 Jan Djärv <jan.h.d@swipnet.se>
930
931 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
932 setting sitelisp (Bug#12010).
933
417a7a0e
EZ
9342012-07-29 Eli Zaretskii <eliz@gnu.org>
935
14ae4239 936 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
937
938 * w32heap.c (cache_system_info):
939 * w32.c (sys_rename):
940 * w32proc.c (find_child_console, sys_kill): All users changed.
941
387d4d92
PE
9422012-07-29 Paul Eggert <eggert@cs.ucla.edu>
943
944 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
945
55a6cca6
EZ
9462012-07-29 Eli Zaretskii <eliz@gnu.org>
947
948 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
949
dbcf001c
DA
9502012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
951
952 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
953 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
954 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 955
e2688e4a
DA
9562012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
957
958 Generalize marker debugging code under MARKER_DEBUG and use eassert.
959 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
960 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
961 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
962 (replace_range, replace_range_2, del_range_2): Change to eassert.
963 * marker.c (byte_char_debug_check): Adjust style.
964
b46a6a83
PE
9652012-07-29 Paul Eggert <eggert@cs.ucla.edu>
966
967 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
968 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
969 long-ago-commented-out code that talks about "WIN32".
970 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
971 All uses changed.
972
e32a5799
PE
9732012-07-28 Paul Eggert <eggert@cs.ucla.edu>
974
975 Use Gnulib stdalign module (Bug#9772, Bug#9960).
976 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
977 Simplify by using alignof.
978 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
979 * lisp.h: Include <stdalign.h>.
980 (GCALIGNMENT): New macro and constant.
981 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
982 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
983 (stdalign): New macro, if not already defined.
984
df81cd29
EZ
9852012-07-28 Eli Zaretskii <eliz@gnu.org>
986
01bd1b0d
EZ
987 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
988 * w32inevt.c: Include w32inevt.h.
989 (w32_read_console_input): New inline function, calls either
990 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
991 w32_console_unicode_input.
992 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
993 (w32_kbd_patch_key, key_event): Use the codepage returned by
994 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
995 (key_event): use uChar.UnicodeChar only if
996 w32_console_unicode_input is non-zero.
997
998 * w32console.c: Include w32heap.h.
999 <w32_console_unicode_input>: New global variable.
1000 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1001 family of Windows, zero otherwise.
1002
1003 * w32inevt.h: Declare w32_console_unicode_input.
1004
df81cd29
EZ
1005 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1006 --without-x. (Bug#11742)
1007
c20fdd9e
PE
10082012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 Adjust GDB to reflect pvec_type changes (Bug#12036).
1011 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1012 2012-07-04 changes to pseudovector representation.
1013 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1014
32770973 10152012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1016
1017 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1018 bus address.
1019 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1020
3438fe21
EZ
10212012-07-27 Eli Zaretskii <eliz@gnu.org>
1022
bcfbc9de
EZ
1023 * alloc.c (listn): Fix the order the arguments are consed onto the
1024 list.
1025
3438fe21
EZ
1026 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1027 enumeration constants, as PURE and HEAP are too general, and clash
1028 with other headers and sources, such as gmalloc.c and the
1029 MS-Windows system headers. All users changed.
1030
eeaea515
DA
10312012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1032
1033 Revert last save_excursion_save and save_excursion_restore changes.
1034 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1035 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1036
073c88c2
DA
10372012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1038
1039 Fix recently-introduced typos in Windows port.
1040 Reported by Martin Rudalics <rudalics@gmx.at>.
1041 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1042 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1043
4706125e
PE
10442012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1045
1046 Improve GDB symbol export (Bug#12036).
1047 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1048 arms of an 'if', not using conditional expressions; otherwise GDB
1049 complains about the types in the unevaluated arm when the argument
1050 is an integer literal.
1051 (xgetint): Simplify expression.
1052 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1053 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1054 Zaretskii in <http://bugs.gnu.org/12036#13>.
1055 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1056 needed now that we have gdb_make_enums_visible.
1057 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1058 (enum enum_USE_LSB_TAG):
1059 New enum types, packaging up enums that need to be exported to GDB.
1060
694b6c97
DA
10612012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1062
1063 Utility function to make a list from specified amount of objects.
1064 * lisp.h (enum constype): New datatype.
1065 (listn): New prototype.
1066 * alloc.c (listn): New function.
1067 (Fmemory_use_count, syms_of_alloc): Use it.
1068 * buffer.c (syms_of_buffer): Likewise.
1069 * callint.c (syms_of_callint): Likewise.
1070 * charset.c (define_charset_internal): Likewise.
1071 * coding.c (syms_of_coding): Likewise.
1072 * keymap.c (syms_of_keymap): Likewise.
1073 * search.c (syms_of_search): Likewise.
1074 * syntax.c (syms_of_syntax): Likewise.
1075 * w32.c (init_environment): Likewise.
1076 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1077 * xdisp.c (syms_of_xdisp): Likewise.
1078 * xfns.c (syms_of_xfns): Likewise.
1079
6195f384
DA
10802012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1081
1082 Fast save_excursion_save and save_excursion_restore.
1083 * lisp.h (struct Lisp_Excursion): New data type.
1084 (PVEC_EXCURSION): New pseudovector type.
1085 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1086 to deal with it. Adjust comments.
1087 (init_marker, attach_marker): New prototype.
1088 (unchain_marker): Adjust prototype.
1089 * marker.c (attach_marker): Change to global.
1090 (init_marker): New function.
1091 * alloc.c (Fmake_marker, build_marker): Use it.
1092 (build_marker): More easserts.
1093 (mark_object): Handle struct Lisp_Excursion.
1094 * editfns.c (save_excursion_save, save_excursion_restore):
1095 Reimplement to use struct Lisp_Excursion. Add comments.
1096
5eceb8fb
PE
10972012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1098
1099 Fix export of symbols to GDB (Bug#12036).
1100 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1101 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1102 emacs.c, as this is a more-suitable home. Had this been done earlier
1103 the fix for 12036 would have avoided some of the problems noted in
1104 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1105 would have been more obvious.
562157c8
PE
1106 * emacs.c: Do not include <verify.h>; no longer needed.
1107 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1108 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1109 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1110 Remove; now done in lisp.h.
1111 * lisp.h (PUBLISH_TO_GDB): New macro.
1112 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1113 (DATA_SEG_BITS): Use it.
1114 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1115 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1116 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1117 not be usable in #if. This simplifies things.
1118
d6749401
JB
11192012-07-26 Juanma Barranquero <lekktu@gmail.com>
1120
1121 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1122
1781b9e9
PE
11232012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1124
d89518db 1125 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1126 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1127 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1128 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1129 Adjust to changes in lisp.h and emacs.c, by using
1130 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1131 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1132 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1133 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1134 instead of gdb_valbits.
1135 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1136 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1137 instead of gdb_array_mark_flag.
1138 (xboolvector): Get size from $->size, not $->header.size.
1139 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1140 (xreload, hook-run, hookpost-run): Remove.
1141 * emacs.c: Include <verify.h>.
1142 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1143 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1144 Remove.
1145 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1146 (gdb_USE_LSB_TAG): New enum constants.
1147 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1148 Also define these as enum constants, so they're visible to GDB.
1149 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1150 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1151 as constants, so they're visible to GDB.
1152 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1153 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1154 Now enum constants, not macros, so they're visible to GDB.
1155 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1156 more convenient now. All uses changed.
1157 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1158 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1159
3628596a
DA
11602012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1161
1162 Explicitly free restriction data that are not needed anymore.
1163 * editfns.c (save_restriction_restore): Free restriction data.
1164
7abaf5cc
SM
11652012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1166
1167 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1168 add argument, tune behavior, and adjust all callers.
1169
71f88e00
PE
11702012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 Use typedef for EMACS_INT, EMACS_UINT.
1173 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1174 than macros. This simplifies debugging in the usual case, since
1175 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1176 and it allows expressions involving EMACS_INT casts.
1177 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1178
57ec3034
JD
11792012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1180
1181 * nsterm.m (ns_read_socket): Return early if there is a modal
1182 window (Bug#12043).
1183
8137e7b3
MR
11842012-07-25 Martin Rudalics <rudalics@gmx.at>
1185
1186 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1187 that FOCUS-FRAME can be omitted.
1188
04e9897c
DA
11892012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1190
1191 Adjust buffer text indirection counters at the end of Fkill_buffer.
1192 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1193 buffer is definitely dead. This should really fix an issue reported
1194 by Christoph Scholtes again. (Bug#12007).
1195 (init_buffer_once): Initialize indirection counters of
1196 buffer_defaults and buffer_local_symbols (for sanity and safety).
1197
8a0484e1
EZ
11982012-07-24 Eli Zaretskii <eliz@gnu.org>
1199
1200 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1201 and continuation glyphs on tooltip frames, leave them at zero.
1202 Avoids continued lines in tooltips. (Bug#11832)
1203
fa691a83
DA
12042012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1205
1206 Simplify copy_overlay.
04e9897c 1207 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1208 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1209
436bc8e0
EZ
12102012-07-23 Eli Zaretskii <eliz@gnu.org>
1211
1212 * print.c (print_object): Don't crash when a frame's name is nil
1213 or invalid. (Bug#12025)
1214
1215 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1216 it signals an error when a tooltip frame is being created.
1217
d7a7fda3
DA
12182012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1219
1220 Cleanup miscellaneous objects allocation and initialization.
1221 * alloc.c (allocate_misc): Change to static. Add argument to
1222 specify the subtype. Adjust comment and users.
1223 (build_overlay): New function.
1224 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1225 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1226 (allocate_misc): Remove prototype.
1227 (build_overlay): Add prototype.
1228
12292012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1230
1231 Swap buffer text indirection counters in Fbuffer_swap_text.
1232 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1233 This avoids crash reported by Christoph Scholtes at
1234 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1235
9d7fa573
JD
12362012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1237
1238 * nsmenu.m (Popdown_data): New struct.
1239 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1240 free Popdown_data.
1241 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1242 (initWithContentRect): Make imgView and contentView non-static
1243 and autorelease them. Also autorelease img and matrix (Bug#12005).
1244 (dealloc): Remove (Bug#12005).
1245
0dd6d66d
DA
12462012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1247
1248 Adjust consing_since_gc when objects are explicitly freed.
1249 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1250 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1251 (free_cons, free_misc): Subtract object size from consing_since_gc.
1252
d36d71df
DA
12532012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1254
1255 Simplify and cleanup markers positioning code.
1256 * marker.c (attach_marker): More useful eassert.
1257 (live_buffer, set_marker_internal): New function.
1258 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1259 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1260
fb9ea40f
PE
12612012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1262
1263 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1264 as it's limited by the amount of memory, not by INT_MAX.
1265
2d5c5f7d
EZ
12662012-07-21 Eli Zaretskii <eliz@gnu.org>
1267
07fb592e
EZ
1268 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1269 in special-event-map. See the discussion at
1270 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1271 for the reasons.
1272
37a9eac8 1273 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1274 info.dwItemData. Fixes crashes on 64-bit Windows.
1275 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1276
c4328746
JD
12772012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1278
1279 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1280 (conversationIdentifier): Return value is NSInteger.
784051c4 1281 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1282
6e5d1c12
CY
12832012-07-21 Chong Yidong <cyd@gnu.org>
1284
1285 * window.c (decode_any_window): Signal an error if the window is
1286 on a dead frame (Bug#11984).
1287
9928463d
DA
12882012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1289
1290 Add indirection counting to speed up Fkill_buffer.
1291 * buffer.h (struct buffer): New member.
1292 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1293 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1294 base buffer indirection counter.
1295 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1296 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1297 through buffer list if indirection counter is 0.
1298
f8643a6b
DA
12992012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1300
1301 Extend the value returned by Fgarbage_collect with heap statistics.
1302 * alloc.c (Qheap): New symbol.
1303 (syms_of_alloc): DEFSYM it.
1304 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1305 (Fmemory_free): Remove.
1306 (syms_of_alloc): Don't defsubr it.
1307 * buffer.c (Fcompact_buffer): Remove.
1308 (syms_of_buffer): Don't defsubr it.
1309
dac616ff
DA
13102012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1311
1312 Make maybe_gc inline.
1313 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1314 * lisp.h (consing_since_gc, gc_relative_threshold)
1315 (memory_full_cons_threshold): Revert declaration.
1316 (maybe_gc): Remove prototype, define as inline.
1317 * alloc.c: Remove old commented-out code.
1318 (consing_since_gc, gc_relative_threshold)
1319 (memory_full_cons_threshold): Revert to global.
1320 (maybe_gc): Remove.
1321
d7ea76b4
DA
13222012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1323
1324 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1325 * lisp.h (build_unibyte_string): New function.
1326 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1327 * sysdep.c, w32fns.c, xfns.c: Use it.
1328 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1329 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1330 Adjust users accordingly.
1331 * font.h (font_open_by_name): Adjust prototype.
1332
765e61e3
DA
13332012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1334
1335 Cleanup calls to Fgarbage_collect.
1336 * lisp.h (maybe_gc): New prototype.
1337 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1338 Remove declarations.
1339 * alloc.c (maybe_gc): New function.
1340 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1341 Make them static.
1342 * bytecode.c (MAYBE_GC): Use maybe_gc.
1343 * eval.c (eval_sub, Ffuncall): Likewise.
1344 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1345 to avoid dependency from auto-save feature.
1346
52b852c7
PE
13472012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1350 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1351 'for_each_per_buffer_object_at'.
1352 All uses changed. It's better to use upper-case for macros that
1353 cannot be implemented as functions, to give the reader a clue
1354 that they're special.
1355
5db81e33
SM
13562012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1357
1358 * alloc.c (Fgarbage_collect): Tweak docstring.
1359
5b835e1d
DA
13602012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1361
1362 Tweak the value returned from Fgarbage_collect again.
1363 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1364 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1365 Adjust documentation.
1366 (total_vector_bytes): Rename to total_vector_slots, adjust
1367 accounting.
1368 (total_free_vector_bytes): Rename to total_free_vector_slots,
1369 adjust accounting.
1370 (Qstring_bytes, Qvector_slots): New symbols.
1371 (syms_of_alloc): DEFSYM them.
1372
9cd47b72
DA
13732012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1374
1375 Buffer compaction primitive which may be used from Lisp.
1376 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1377 (syms_of_buffer): Register Fcompact_buffer.
1378 * alloc.c (Fgarbage_collect): Use compact_buffer.
1379 * buffer.h (compact_buffer): New prototype.
1380 (struct buffer_text): New member.
1381
d17337e5
DA
13822012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1383
1384 New macro to iterate over all buffers, miscellaneous cleanups.
1385 * lisp.h (all_buffers): Remove declaration.
1386 * buffer.h (all_buffers): Add declaration, with comment.
1387 (for_each_buffer): New macro.
1388 * alloc.c (Fgarbage_collect, mark_object): Use it.
1389 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1390 (init_buffer): Likewise.
1391 * data.c (Fset_default): Likewise.
1392 * coding.c (code_conversion_restore): Remove redundant check
1393 for dead buffer.
1394 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1395
60cfd278
AS
13962012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1397
1398 Fix bug that created negative-length intervals.
1399 * intervals.c (merge_interval_right, merge_interval_left):
1400 Do not zero out this interval if it is absorbed by its children,
1401 as this interval's total length doesn't change in that case. See
1402 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1403
d06714cb
PE
14042012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1405
83713154
PE
1406 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1407 when invoking (make-bool-vector N t) and N is a positive
1408 multiple of 8 -- the last 8 bits were mistakenly cleared.
1409
d06714cb
PE
1410 Remove some struct layout assumptions in bool vectors.
1411 * alloc.c (bool_header_size): New constant.
1412 (header_size, word_size): Move earlier, as they're now used earlier.
1413 Use 'word_size' in a few more places, where it's appropriate.
1414 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1415 padding before the data member of a bool vector.
1416 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1417 than doing the check by hand with an abort ().
1418
464d5a5e
SM
14192012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1420
5fbc0409
SM
1421 * eval.c (Fdefvar): Don't check constants since we only set the var if
1422 it's not yet defined anyway (bug#11904).
1423
464d5a5e
SM
1424 * lisp.h (last_undo_boundary): Declare new var.
1425 * keyboard.c (command_loop_1): Set it.
1426 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1427 were auto-added by the command loop (bug#11774).
1428
8dc2e44a
AS
14292012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1430
1431 * w32font.c (Qsymbol): Remove local definition.
1432 (syms_of_w32font): Don't DEFSYM it.
1433
169925ec
DA
14342012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1435
1436 Fix sweep_vectors to handle large bool vectors correctly.
1437 * alloc.c (sweep_vectors): Account total_vector_bytes for
1438 bool vectors larger than VBLOCK_BYTES_MAX.
1439
5fbfb018
CY
14402012-07-18 Chong Yidong <cyd@gnu.org>
1441
1442 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1443 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1444
3ab6e069
DA
14452012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1446
1447 Return more descriptive data from Fgarbage_collect.
1448 Suggested by Stefan Monnier in
1449 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1450 * alloc.c (bounded_number): New function.
1451 (total_buffers, total_vectors): New variable.
1452 (total_string_size): Rename to total_string_bytes, adjust users.
1453 (total_vector_size): Rename to total_vector_bytes, adjust users.
1454 (sweep_vectors): Account total_vectors and total_vector_bytes.
1455 (Fgarbage_collect): New return value. Adjust documentation.
1456 (gc_sweep): Account total_buffers.
1457 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1458 (VECTOR_SIZE): Remove.
1459 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1460 (Qinterval, Qmisc): New symbols.
1461 (syms_of_data): Initialize them.
1462 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1463 (Qcons, Qbuffer): New declarations.
1464
6d02fe5b
PE
14652012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1466
1467 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1468 Round up, not down. Improve doc.
1469
b7ffe040
DA
14702012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1471
1472 Restore old code in allocate_string_data to avoid Faset breakage.
1473 Reported by Julien Danjou <julien@danjou.info> in
1474 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1475 * alloc.c (allocate_string_data): Restore old code with minor
1476 adjustments, fix comment to explain this subtle issue.
1477
4dc7c8d5
SM
14782012-07-17 Eli Zaretskii <eliz@gnu.org>
1479
1480 Remove FILE_SYSTEM_CASE.
1481 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1482
1483 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1484 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1485 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1486 call-process-region passes it through expand-file-name.
1487
1488 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1489
14902012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1491
1492 Fix crash when creating indirect buffer (Bug#11917)
1493 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1494 Don't handle unbound variables specially if non-zero.
1495 (Fbuffer_local_variables): Pass zero.
1496 (clone_per_buffer_values): Pass non-zero.
1497
14982012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1499
1500 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1501 to make the loop interruptible.
1502
15032012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1504
1505 * gnutls.c (emacs_gnutls_handshake): Only retry if
1506 GNUTLS_E_INTERRUPTED.
1507
cce7fefc
DA
15082012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1509
1510 Cleanup and convert miscellaneous checks to eassert.
1511 * alloc.c (mark_interval): Fix comment, partially rephrase
1512 old comment from intervals.h (see below).
1513 * intervals.c (find_interval, adjust_intervals_for_insertion)
1514 (delete_interval, adjust_intervals_for_deletion)
1515 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1516 Convert to eassert.
1517 (adjust_intervals_for_insertion, make_new_interval):
1518 Remove obsolete and unused code.
1519 * intervals.h (struct interval): Remove obsolete comment.
1520 * textprotp.c (erase_properties): Remove unused code.
1521 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1522 (Fremove_list_of_text_properties): Convert to eassert.
1523
9ea10cc3
CY
15242012-07-17 Chong Yidong <cyd@gnu.org>
1525
1526 * editfns.c (Finsert_char): Doc fix.
1527
3900d5de
DA
15282012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1529
1530 Fix previous change to make Fmemory_free always accurate.
1531 * alloc.c (make_interval): Update total_free_intervals.
1532 (make_float): Likewise for total_free_floats.
1533 (free_cons, Fcons): Likewise for total_free_conses.
1534 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1535 Likewise for total_free_vector_bytes.
1536 (Fmake_symbol): Likewise for total_free_symbols.
1537 (bytes_free): Remove.
1538
7098646f
DA
15392012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1540
1541 Simple free memory accounting feature.
1542 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1543 (sweep_vectors): Accumulate size of free vectors.
1544 (Fgarbage_collect): Setup bytes_free.
1545 (Fmemory_free): New function.
1546 (syms_of_alloc): Register it.
1547
22657b40
DA
15482012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1549
1550 Cleanup overlays checking.
1551 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1552 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1553 eassert and OVERLAYP.
1554 (sort_overlays): Change to use OVERLAYP.
1555
ddfc8813
RK
15562012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1557
1558 * editfns.c (Finsert_char): Make it interactive, and make the
1559 second arg optional. Copy interactive spec and docstring from
1560 ucs-insert.
1561
7c26cf3c
PE
15622012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1563
1564 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1565 Unlike the other wrapped functions, fabs has an unspecified
1566 effect on errno.
1567
5d127af9
JD
15682012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1569
1570 * nsterm.m (keyDown): Interpret flags without left/right bits
1571 as the left key (Bug#11670).
1572
6a0dd1d7
DA
15732012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1574
1575 Remove empty and useless init functions.
1576 * lisp.h (init_character_once, init_fns, init_image)
1577 (init_filelock, init_sound): Remove prototype.
1578 * character.c (init_character_once): Remove.
1579 * filelock.c (init_filelock): Likewise.
1580 * fns.c (init_fns): Likewise.
1581 * image.c (init_image): Likewise.
1582 * sound.c (init_sound): Likewise.
1583 * emacs.c (main): Adjust accordingly.
1584
7a6136fd
DA
15852012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1586
1587 * gtkutil.h: Tiny cleanups.
1588 (use_old_gtk_file_dialog): Remove useless declaration.
1589 (xg_uses_old_file_dialog): Add suggested const attribute.
1590
ce811ad9
EZ
15912012-07-15 Eli Zaretskii <eliz@gnu.org>
1592
1593 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1594 (bidi_paragraph_init): Use it to limit search forward for a strong
1595 directional character in abnormally large paragraphs full of
1596 neutral or weak characters. (Bug#11943)
1597
c9adfeaa
SF
15982012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1599
1600 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1601 the toolbar (Bug#9451).
1602 (xg_make_tool_item): Give the widget event box a transparent
1603 background.
1604
fff62aa9
DA
16052012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1606
1607 Cleanup basic allocation variables and functions.
1608 * alloc.c (ignore_warnings, init_intervals, init_float)
1609 (init_cons, init_symbol, init_marker): Remove.
1610 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1611 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1612 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1613 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1614 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1615 (staticidx, init_alloc_once, init_strings, free_ablock):
1616 Remove redundant initialization.
1617 * fns.c (init_weak_hash_tables): Remove.
1618 * lisp.h (init_weak_hash_tables): Remove prototype.
1619
9730daca
DA
16202012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1621
1622 Use zero_vector where appropriate.
1623 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1624 accordingly.
1625 * lisp.h (zero_vector): New declaration.
1626 * font.c (null_vector): Remove.
1627 (syms_of_font): Remove initialization and staticpro.
1628 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1629 * keymap.c (Faccessible_keymaps): Likewise.
1630
2e2d2a13
LL
16312012-07-15 Leo Liu <sdl.web@gmail.com>
1632
1633 * fringe.c: Fix typo in comments.
1634
cd276f6e
LL
16352012-07-14 Leo Liu <sdl.web@gmail.com>
1636
1637 * fringe.c: Add a new bitmap exclamation-mark.
1638
5a1131d9
EZ
16392012-07-14 Eli Zaretskii <eliz@gnu.org>
1640
1641 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1642
1643 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1644 (HAVE_MENUS): Don't define, defined by editing config.in with
1645 msdos/sed2v2.inp.
1646 (GMALLOC_INHIBIT_VALLOC): Don't define.
1647 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1648
22e983b7
JB
16492012-07-14 Juanma Barranquero <lekktu@gmail.com>
1650
1651 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1652
5b3f250f
GM
16532012-07-14 Glenn Morris <rgm@gnu.org>
1654
1655 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1656 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1657 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1658
33d63ff4
GM
16592012-07-13 Glenn Morris <rgm@gnu.org>
1660
5b633342
GM
1661 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1662
33d63ff4
GM
1663 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1664 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1665
b55b9f85
JD
16662012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1667
0dc8cf50
JD
1668 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1669 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1670 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1671 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1672 where appropriate.
1673 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1674 as boolean expression.
1675 (x_set_window_size): Remove unused variable toolbar.
1676 (ns_get_color_default, ns_mod_to_lisp): Remove.
1677 (ns_mouse_position): Remove unused variables xchar and ychar.
1678 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1679 (ns_set_vertical_scroll_bar): Remove unused variable count.
1680 (ns_delete_terminal): Remove unused variable i.
1681 (ns_term_init): Remove unused variables r, g and b.
1682 (mouseDown): Remove unused variable window.
1683 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1684 (initFrameFromEmacs): Remove unused variable vbextra.
1685 (mouseEntered): Remove unused variables p and dpyinfo.
1686 (mouseExited): Remove unused variables p and r.
1687 (ns_define_frame_cursor, ns_clear_frame_area)
1688 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1689 (menuDown): Assign [sender tag] to variable and cast the variable.
1690
1691 * nsterm.h (menuDown): Add id as type to argument sender.
1692 (ns_display_info_for_name): Add Lisp_Object argument.
1693 (ns_term_init): Add Lisp_Object argument.
1694 (ns_map_event_to_object): Add void argument.
1695 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1696 prototype with arguments and only declare if __OBJC__.
1697 (nxatoms_of_nsselect): Add void argument.
1698 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1699 (ns_alloc_autorelease_pool): Add void argument.
1700 (ns_release_autorelease_pool): Add void* argument.
1701 (ns_get_defaults_value): Add const char* argument.
1702
1703 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1704 (initFromContents): Use SSDATA where appropriate.
1705 (ns_update_menubar): Add braces to ambigous if-else.
1706 (initWithTitle): Put () around assignment in if statement.
1707 (ns_menu_show): Remove unused variables window and keymap.
1708 (update_frame_tool_bar): Remove unused variable selected_p.
1709 (initWithContentRect): Remove unused variable this_cmd_name.
1710
1711 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1712 appropriate.
1713 (setXBMColor): Remove unused variable len.
1714 (setPixmapData): Put () around assignment in loop statement.
1715
1716 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1717 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1718 where appropriate.
1719 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1720 around assignment in loop statement.
1721 (nsfont_open): Remove unused variable i.
1722 (nsfont_open): Remove unused variable len.
1723 (nsfont_draw): Remove unused variable cs.
1724
1725 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1726 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1727 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1728 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1729 (Fns_font_name, Fns_perform_service)
1730 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1731 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1732 (ns_set_name): Remove unused variable view.
1733 (x_set_menu_bar_lines): Remove unused variable olines.
1734 (x_set_tool_bar_lines): Remove unused variable root_window.
1735 (Fns_list_colors): Put () around assignment in while statement.
1736 (Fns_perform_service): Remove unused variable len.
1737 (Fns_display_usable_bounds): Remove unused variable top.
1738 (syms_of_nsfns): Remove unused variable i.
1739
b55b9f85
JD
1740 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1741 memcpy (Bug#11907).
1742
ed9265fc 17432012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1744
1745 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1746 and free it with DestroyExceptionInfo (Bug#11558).
1747
ef099b57
JB
17482012-07-13 Juanma Barranquero <lekktu@gmail.com>
1749
1750 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1751 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1752 Set here, not in nt/config.nt.
1753
ea814a5d
EZ
17542012-07-13 Eli Zaretskii <eliz@gnu.org>
1755
1756 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1757 cursor overflow into the last glyph on display line when the right
1758 fringe is off. (Bug#11832)
1759
1a952767
PE
17602012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 * xdisp.c (produce_special_glyphs): Now static.
1763 * dispextern.h (produce_special_glyphs): Remove decl.
1764
983188fd
GM
17652012-07-13 Glenn Morris <rgm@gnu.org>
1766
8d7c7eed 1767 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1768 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1769
983188fd
GM
1770 * s/usg5-4-common.h (USG, USG5):
1771 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1772 * s/sol2-6.h (SOLARIS2):
1773 * s/irix6-5.h (IRIX6_5):
1774 * s/hpux10-20.h (USG, USG5, HPUX):
1775 * s/gnu-linux.h (USG, GNU_LINUX):
1776 * s/freebsd.h (BSD_SYSTEM):
1777 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1778 * s/cygwin.h (CYGWIN):
1779 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1780 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1781
d1e68667 17822012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1783
1784 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1785
6de0e799
GM
17862012-07-13 Glenn Morris <rgm@gnu.org>
1787
739ae010
GM
1788 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1789
dbee5793
GM
1790 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1791
6de0e799
GM
1792 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1793 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1794
b82da769
GM
17952012-07-12 Glenn Morris <rgm@gnu.org>
1796
4fae5a7a 1797 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1798
1799 * process.c (init_process_emacs): Rename from init_process.
1800 The old name is also the name of a Mach system call.
1801 * lisp.h, emacs.c: Update for this name change.
1802 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1803 longer needed.
1804
5a979817
EZ
18052012-07-12 Eli Zaretskii <eliz@gnu.org>
1806
1807 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1808 memmove call that removes glyphs covered by the left truncation
1809 glyph. Improve commentary.
1810 (display_line): Fix display of continuation glyphs on GUI frames
1811 when the right fringe is turned off and variable-size fonts are
1812 used in the window. Move the code that appends a stretch glyph to
1813 produce_special_glyphs, so that it could be used for truncation
1814 and continuation glyphs alike.
1815 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1816 glyph of a suitably computed width, to align the special glyphs at
1817 the window margin. Code moved from display_line. (Bug#11832)
1818
3e91a053
GM
18192012-07-12 Glenn Morris <rgm@gnu.org>
1820
ba9e4b84
GM
1821 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1822
1823 * s/gnu-linux.h, s/hpux10-20.h:
1824 Do not unconditionally define HAVE_XRMSETDATABASE.
1825
3e91a053
GM
1826 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1827
b300b1f4
PE
18282012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1829
1830 Fix typos that broke OS X build.
1831 Reported by Randal L. Schwartz in
1832 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1833 * nsterm.m (ns_timeout): Add missing local decl.
1834 (ns_get_color): snprintf -> sprintf, to fix typo.
1835
6e777848
GM
18362012-07-12 Glenn Morris <rgm@gnu.org>
1837
3f922c37
GM
1838 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1839 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1840 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1841 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1842
0ab7b23a
GM
1843 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1844 Move PTY_OPEN to configure.
1845
6e777848
GM
1846 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1847 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1848 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1849
4a7edc24
DA
18502012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1851
1852 Use empty_unibyte_string where applicable.
1853 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1854 * lread.c (read1): Likewise.
1855 * xsettings.c (syms_of_xsettings): Likewise.
1856
308aab79
GM
18572012-07-12 Glenn Morris <rgm@gnu.org>
1858
42bd1719
GM
1859 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1860 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1861 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1862 * s/hpux10-20.h (RUN_TIME_REMAP):
1863 * s/bsd-common.h (TABDLY): Move to configure.
1864
1865 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1866
1867 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1868
ea0bbd17 1869 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1870 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1871
1872 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1873
308aab79
GM
1874 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1875 * s/template.h: Move NARROWPROTO to configure.
1876
ee1cf5cf
GM
18772012-07-11 Glenn Morris <rgm@gnu.org>
1878
30fe9bf4
GM
1879 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1880 unused since 2011-01-17 change to systty.h.
1881
ee1cf5cf
GM
1882 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1883 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1884 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1885
63e47e07
PE
18862012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1887
1888 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1889
c43fb4c3
GM
18902012-07-11 Glenn Morris <rgm@gnu.org>
1891
1892 * s/darwin.h, s/gnu-linux.h, s/template.h:
1893 Move INTERRUPT_INPUT to configure.
1894
e8df9267
DA
18952012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1896
1897 Minor adjustments to interning code.
1898 * lisp.h (intern, intern_c_string): Redefine as static inline
1899 wrappers for intern_1 and intern_c_string_1, respectively.
1900 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1901 * lread.c (intern_1, intern_c_string_1, oblookup):
1902 Simplify Vobarray checking.
e8df9267
DA
1903 * font.c (font_intern_prop): Likewise. Adjust comment.
1904 * w32font.c (intern_font_name): Likewise.
1905
34348bd4
AS
19062012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1907
d96a1e0c
AS
1908 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1909
34348bd4
AS
1910 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1911 of Fcar/Fcdr if possible.
1912 * font.c (check_otf_features): Likewise.
1913 * fontset.c (Fnew_fontset): Likewise.
1914 * gnutls.c (Fgnutls_boot): Likewise.
1915 * minibuf.c (read_minibuf): Likewise.
1916 * msdos.c (IT_set_frame_parameters): Likewise.
1917 * xmenu.c (Fx_popup_dialog): Likewise.
1918 * w32menu.c (Fx_popup_dialog): Likewise.
1919
c8add24e
GM
19202012-07-11 Glenn Morris <rgm@gnu.org>
1921
4b575b3c
GM
1922 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1923 since nothing has defined it on these platforms.
1924
09f4e3b0
GM
1925 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1926 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1927
172bedef
GM
1928 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1929 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1930 Move CLASH_DETECTION to configure.
1931
249685df
GM
1932 * s/gnu.h: Remove file, which is now empty.
1933
c8add24e
GM
1934 * s/gnu.h, s/gnu-linux.h:
1935 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1936
b41253a3
JW
19372012-07-11 John Wiegley <johnw@newartisans.com>
1938
1939 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1940 function attribute, so we only use it if it exists in the
1941 compiler.
1942
d923b542
DA
19432012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1944
1945 Avoid call to strlen in fast_c_string_match_ignore_case.
1946 * search.c (fast_c_string_match_ignore_case): Change to use
1947 length argument. Adjust users accordingly.
1948 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1949
5ebbef1d
PE
19502012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1951
bb352260
PE
1952 Assume mkdir, rmdir.
1953 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1954 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1955
57054ddd
PE
1956 Assume rename.
1957 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1958
b747d3f7
PE
1959 Assume perror.
1960 * s/hpux10-20.h (HAVE_PERROR): Remove.
1961 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1962 Remove dummy definition, as this problem was obsolete long ago.
1963
5ebbef1d
PE
1964 Assume strerror.
1965 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1966
984e7f30
DA
19672012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1968
1969 Avoid calls to strlen in font processing functions.
1970 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
1971 (font_open_by_name): Change to use length argument.
1972 Adjust users accordingly.
d923b542
DA
1973 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1974 Adjust prototypes.
1975 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1976 Change to return ptrdiff_t.
984e7f30
DA
1977 (xfont_list_pattern, xfont_match): Use length returned by
1978 xfont_decode_coding_xlfd.
1979 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1980
20e94fdd
GM
19812012-07-11 Glenn Morris <rgm@gnu.org>
1982
9d596af3
GM
1983 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1984 Move DONT_REOPEN_PTY to configure.
1985
20e94fdd
GM
1986 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1987 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1988
e99a530f
PE
19892012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1990
22ffb973
PE
1991 Remove "#define unix" that is no longer needed (Bug#11905).
1992 * s/aix4-2.h (unix): Remove; no longer needed.
1993
e9a9ae03
PE
1994 EMACS_TIME simplification (Bug#11875).
1995 This replaces macros (which typically do not work in GDB)
1996 with functions, typedefs and enums, making the code easier to debug.
1997 The functional style also makes code easier to read and maintain.
1998 * systime.h: Include <sys/time.h> on all hosts, not just if
1999 WINDOWSNT, since 'struct timeval' is needed in general.
2000 (EMACS_TIME): Now a typedef, not a macro.
2001 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2002 not macros.
2003 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2004 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2005 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2006 (EMACS_TIME_LE): Now functions, not macros.
2007 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2008 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2009 which are not functions. All uses rewritten to use:
2010 (make_emacs_time): New function.
2011 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2012 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2013 not functions. All uses rewritten to use the following, respectively:
2014 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2015 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2016 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2017 * fileio.c (Fcopy_file):
2018 * xterm.c (XTflash): Get the current time closer to when it's used.
2019 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2020
ffacb126
PE
2021 * bytecode.c (targets): Suppress -Woverride-init warnings.
2022
e99a530f
PE
2023 Simplify by avoiding confusing use of strncpy etc.
2024 * doc.c (Fsnarf_documentation):
2025 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2026 * frame.c (Fmake_terminal_frame):
2027 * gtkutil.c (get_utf8_string):
2028 * lread.c (openp):
2029 * nsmenu.m (ns_update_menubar):
2030 * regex.c (regerror):
2031 Prefer memcpy to strncpy and strncat when either will do.
2032 * fileio.c (Fsubstitute_in_file_name):
2033 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2034 (menu_separator_name_p):
2035 * nsmenu.m (ns_update_menubar):
2036 Prefer memcmp to strncmp when either will do.
2037 * nsterm.m: Include <ftoastr.h>.
2038 (ns_get_color):
2039 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2040 Prefer snprintf to strncpy.
2041 * nsterm.m (ns_term_init):
2042 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2043 * nsterm.m (ns_term_init):
2044 Avoid the need for strncpy, by using build_string or
2045 make_unibyte_string directly. Use dtoastr, not snprintf.
2046 * process.c (Fmake_network_process): Diagnose service names that
2047 are too long, rather than silently truncating them or creating
2048 non-null-terminated names.
2049 (Fnetwork_interface_info): Likewise, for interface names.
2050 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2051 Prefer sprintf to strncat.
2052 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2053 Prefer vsnprintf to vsprintf + strncpy.
2054
c59592b3
GM
20552012-07-10 Glenn Morris <rgm@gnu.org>
2056
2057 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2058 Clarify fallback case.
2059
7d7bbefd
DA
20602012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2061
2062 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2063 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2064 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2065 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2066 where argument type is known to be a Lisp_Cons.
2067
3a4c8000
TT
20682012-07-10 Tom Tromey <tromey@redhat.com>
2069
2070 * bytecode.c (BYTE_CODE_THREADED): New macro.
2071 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2072 (enum byte_code_op): New type.
2073 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2074 (exec_byte_code): Use them. Use token threading when applicable.
2075
2a0213a6
DA
20762012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2077
2078 Optimize pure C strings initialization.
2079 * lisp.h (make_pure_string): Fix prototype.
2080 (build_pure_c_string): New function, defined as static inline. This
2081 provides a better opportunity to optimize away calls to strlen when
2082 the function is called with compile-time constant argument.
2083 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2084 argument, adjust users accordingly. Use build_pure_c_string where
2085 appropriate.
2086 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2087 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2088 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2089
cb1caeaf
DA
20902012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2091
2092 Avoid calls to strlen in miscellaneous functions.
2093 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2094 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2095 * lread.c (openp): Likewise.
2096
c293e30c
DA
20972012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2098
2099 Avoid calls to strlen in path processing functions.
2100 * fileio.c (file_name_as_directory): Add comment. Change to add
2101 srclen argument and return the length of result. Adjust users
2102 accordingly.
2103 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2104 swap 1st and 2nd arguments to obey the common convention.
2105 Adjust users accordingly.
c293e30c
DA
2106 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2107
9e059e3f
GM
21082012-07-10 Glenn Morris <rgm@gnu.org>
2109
d02eb359
GM
2110 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2111 Move PENDING_OUTPUT_COUNT definition to configure.
2112
882cf227
GM
2113 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2114 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2115 * s/gnu.h (DATA_START): Move definitions to configure.
2116
af6e839f
GM
2117 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2118 We include usg5-4-common.h, which defines them both.
2119
40289a12
GM
2120 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2121 O_RDONLY already includes it).
2122
9e059e3f
GM
2123 Stop ns builds setting the EMACSLOADPATH environment variable.
2124 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2125 Now it does not set EMACSLOADPATH, just returns the load-path string.
2126 * nsterm.h: Update accordingly.
2127 * lread.c [HAVE_NS]: Include nsterm.h.
2128 (init_lread) [HAVE_NS]: Use ns_load_path.
2129 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2130
7c4e8ec0
GM
21312012-07-09 Glenn Morris <rgm@gnu.org>
2132
d4f600ff
GM
2133 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2134 since the included bsd-common.h does so.
2135
cbb31951
GM
2136 Stop ns builds setting the EMACSPATH environment variable.
2137 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2138 (ns_init_paths): Do not set EMACSPATH.
2139 * nsterm.h (ns_exec_path): Add it.
2140 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2141 Use ns_exec_path.
2142
7c4e8ec0
GM
2143 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2144
26bccfae
PE
21452012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2146
a0bee46f
PE
2147 * process.c (wait_reading_process_output): 'waitchannels' was unset
2148 when read_kbd || !NILP (wait_for_cell); fix this.
2149
5994c183
PE
2150 Add GCC-style 'const' attribute to functions that can use it.
2151 * character.h (char_resolve_modifier_mask):
2152 * keyboard.h (make_ctrl_char):
2153 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2154 (init_character_once, next_almost_prime, init_fns, init_image)
2155 (flush_pending_output, init_sound):
2156 * mem-limits.h (start_of_data):
2157 * menu.h (finish_menu_items):
2158 Add ATTRIBUTE_CONST.
2159 * emacs.c (DEFINE_DUMMY_FUNCTION):
2160 Declare the dummy function with ATTRIBUTE_CONST.
2161 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2162 Add decls with ATTRIBUTE_CONST.
2163
26bccfae
PE
2164 Minor improvements to make_formatted_string.
2165 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2166 where int is good enough, as vsprintf returns an int.
2167 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2168
a8290ec3
DA
21692012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 Use make_formatted_string to avoid double length calculation.
2172 * lisp.h (make_formatted_string): New prototype.
2173 * alloc.c (make_formatted_string): New function.
2174 * buffer.c (Fgenerate_new_buffer_name): Use it.
2175 * dbus.c (syms_of_dbusbind): Likewise.
2176 * editfns.c (Fcurrent_time_zone): Likewise.
2177 * filelock.c (get_boot_time): Likewise.
2178 * frame.c (make_terminal_frame, set_term_frame_name)
2179 (x_report_frame_params): Likewise.
2180 * image.c (gs_load): Likewise.
2181 * minibuf.c (get_minibuffer): Likewise.
2182 * msdos.c (dos_set_window_size): Likewise.
2183 * process.c (make_process): Likewise.
2184 * xdisp.c (ensure_echo_area_buffers): Likewise.
2185 * xsettings.c (apply_xft_settings): Likewise.
2186
d01ba2f1
GM
21872012-07-09 Glenn Morris <rgm@gnu.org>
2188
2189 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2190 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2191 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2192 * nsterm.h (ns_etc_directory): Add it.
2193 * callproc.c [HAVE_NS]: Include nsterm.h.
2194 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2195
f1f924b6
DA
21962012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2197
2198 Move marker debugging code under MARKER_DEBUG.
2199 * marker.c (MARKER_DEBUG): Move marker debugging code under
2200 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2201 for bootstrap with --enable-checking (~3x slowdown reported
2202 by Juanma Barranquero <lekktu@gmail.com>).
2203 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2204
ab531b66
PE
22052012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2206
2207 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2208 See <http://bugs.gnu.org/11825#29>.
2209
c4b3bc8a
EZ
22102012-07-08 Eli Zaretskii <eliz@gnu.org>
2211
2212 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2213 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2214 (display_line): Add commentary about displaying truncation glyphs
2215 on GUI frames.
2216 (produce_special_glyphs): Move here from term.c.
2217
2218 * term.c (produce_special_glyphs): Move to xdisp.c.
2219
2220 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2221 section.
c4b3bc8a 2222
b676b881
AS
22232012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2224
f17c5273
AS
2225 * xdisp.c (display_line): Avoid warning about implicit declaration
2226 of FRAME_FONT.
2227
298819b9
AS
2228 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2229
b676b881
AS
2230 * lisp.h: Remove empty conditional.
2231
6045c4fd
PE
22322012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2233
b3350bf9
PE
2234 * lread.c (load_path_check): Now static.
2235
6045c4fd
PE
2236 Fix some minor --with-ns problems found by static checking.
2237 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2238 (x_set_font) [!HAVE_X_WINDOWS]:
2239 * image.c (xpm_load_image) [HAVE_NS]:
2240 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2241 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2242 Remove unused local.
2243 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2244 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2245 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2246 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2247 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2248 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2249 Fix pointer signedness problem.
2250 * xfaces.c (FRAME_X_FONT_TABLE):
2251 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2252
929e7845
GM
22532012-07-07 Glenn Morris <rgm@gnu.org>
2254
2255 * lread.c (load_path_check): New function, split from init_lread.
2256 (init_lread): Reorganize. Motivation:
2257 If EMACSLOADPATH is set, check/warn about that rather than the
2258 defaults, which we are not going to use. Hence we can remove
2259 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2260 Don't warn if site-lisp directories are missing.
2261 If not installed, start from a blank load-path, since
2262 PATH_LOADSEARCH refers to the eventual installation directories.
2263
58dd0aa4
EZ
22642012-07-07 Eli Zaretskii <eliz@gnu.org>
2265
2266 Support truncation and continuation glyphs on GUI frames, when
2267 fringes are disabled. (Bug#11832)
2268 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2269 continuation glyphs even if on GUI frames.
2270 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2271 or both, are absent.
2272 (start_display, move_it_in_display_line_to): Handle the case of a
2273 GUI frame without a fringe to display continuation or truncation
2274 glyphs.
2275 (insert_left_trunc_glyphs): Support GUI frames: make sure
2276 truncation glyphs overwrite enough glyphs from the current line to
2277 have sufficient space in pixels.
2278 (display_line): Support truncation and continuation glyphs on GUI
2279 frames. If some spare pixels are left on the line after inserting
2280 the truncation glyphs, fill that space with a stretch glyph of a
2281 suitably computed width.
2282
2283 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2284 produce_glyphs, to support GUI sessions.
2285
31571fd7
PE
22862012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2287
5a16b9bc
PE
2288 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2289
f3047c75
PE
2290 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2291
31571fd7
PE
2292 Do not require float-time's arg to fit in time_t (Bug#11825).
2293 This works better on hosts where time_t is unsigned, and where
2294 float-time is applied to the (negative) difference between two times.
2295 * editfns.c (decode_time_components): Last arg is now double *,
2296 not int *, and means to store all the result as a double, without
2297 worrying about whether the seconds part fits in time_t.
2298 All callers changed.
2299 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2300 All callers changed.
2301 (Ffloat_time): Do not fail merely because the specified time falls
2302 outside of time_t range.
2303
4516fbef
GM
23042012-07-07 Glenn Morris <rgm@gnu.org>
2305
2306 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2307 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2308 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2309
07adc2c6
JB
23102012-07-07 Juanma Barranquero <lekktu@gmail.com>
2311
2312 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2313 Update dependencies.
2314
2315 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2316
fd573f31
PE
23172012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2318
fee5959d
PE
2319 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2320 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2321 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2322 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2323 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2324 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2325
fd573f31
PE
2326 * xfont.c (compare_font_names): Redo to omit the need for casts.
2327
ddadbc0e
AS
23282012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2329
fca8d6b6
AS
2330 * xfns.c (Fx_change_window_property): Doc fix.
2331 * w32fns.c (Fx_change_window_property): Doc fix.
2332
ddadbc0e
AS
2333 * w32fns.c (Fx_window_property): Accept the same arguments as the
2334 X Windows version. Doc fix.
2335 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2336
ed9265fc 23372012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2338 Eli Zaretskii <eliz@gnu.org>
2339
2340 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2341 Windows-specific code from nt/config.nt moved here.
2342 Obsolete settings removed.
2343
216ee680
PE
23442012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2345
2346 * process.c: Avoid unnecessary calls to gettime.
2347 (wait_reading_process_output): Don't get the time of day
2348 when gobbling data immediately and not waiting, as there's no need
2349 for it in that case. This removes a FIXME.
2350
bdd091e4
JD
23512012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2352
2353 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2354 is defined (Bug#11768).
2355
9d44f8ce
DA
23562012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2357
2358 Fix marker debugging code.
2359 * marker.c (byte_char_debug_check): Do not perform the check
2360 if buffer is not multibyte.
090bd7cb
JB
2361 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2362 Call byte_char_debug_check with correct arguments.
9d44f8ce 2363
90fc4786
DA
23642012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2365
2366 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2367 * marker.c (byte_char_debug_check, count_markers):
2368 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2369 (byte_debug_flag): Remove.
2370 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2371 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2372
7b7ae965
DA
23732012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2374
4e57b342
DA
2375 Avoid code repetition in marker-related functions.
2376 * marker.c (attach_marker): New function.
2377 (Fset_marker, set_marker_restricted, set_marker_both)
2378 (set_marker_restricted_both): Use it.
2379 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2380 Consistently rename charno to charpos.
2381 (marker_position): Add eassert.
2382 (marker_byte_position): Convert to eassert.
2383
23842012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2385
2386 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2387 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2388 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2389
657924ff
DA
23902012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2391
2392 Introduce fast path for the widely used marker operation.
2393 * alloc.c (build_marker): New function.
2394 * lisp.h (build_marker): New prototype.
2395 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2396 * composite.c (autocmp_chars): Likewise.
2397 * editfns.c (buildmark): Remove.
2398 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2399 (save_restriction_save): Use build_marker.
2400 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2401 * window.c (save_window_save): Likewise.
2402
041a49a6
DA
24032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2404
2405 Do not use Fdelete_overlay in delete_all_overlays
2406 to avoid redundant calls to unchain_overlay.
2407 * buffer.c (drop_overlay): New function.
2408 (delete_all_overlays, Fdelete_overlay): Use it.
2409 * minibuf.c (get_minibuffer): Fix comment.
2410
7dca65a4
PE
24112012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2412
2413 Port to OpenBSD 5.1 amd64.
2414 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2415 This is needed for OpenBSD, and should be harmless on all BSD systems.
2416 Also, include <sys/sysctl.h>, as it should be available on all
2417 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2418 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2419 use p_pid member, not kp_proc.pid.
2420
8eb876e2
GM
24212012-07-06 Glenn Morris <rgm@gnu.org>
2422
2423 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2424
38182d90
PE
24252012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2426
2427 More xmalloc and related cleanup.
2428 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2429 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2430 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2431 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2432 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2433 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2434 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2435 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2436 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2437 * xterm.c:
2438 Omit needless casts involving void * pointers and allocation.
2439 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2440 as the former is more robust if P's type is changed.
2441 Prefer xzalloc to xmalloc + memset 0.
2442 Simplify malloc-or-realloc to realloc.
2443 Don't worry about xmalloc returning a null pointer.
2444 Prefer xstrdup to xmalloc + strcpy.
2445 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2446 growing it.
2447 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2448 alloca of a constant.
2449
6dd5a677
EZ
24502012-07-05 Eli Zaretskii <eliz@gnu.org>
2451
2452 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2453 hscroll is larger than the line width. Fixes long and futile
2454 looping inside extend_face_to_end_of_line (on a TTY) producing
2455 glyphs that are not needed and thrown away.
2456
6b312f0f
DA
24572012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2458
2459 * marker.c (set_marker_restricted_both): Simplify by using
2460 clip_to_bounds.
2461
f520ef9b
PE
24622012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2465
383b7c95
JD
24662012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2467
2468 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2469 not defined (Bug#11768).
2470 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2471 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2472 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2473 followed by gtk_box_set_homogeneous (Bug#11768).
2474 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2475 (update_theme_scrollbar_width, xg_create_scroll_bar):
2476 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2477 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2478 (is_box_type): New function (Bug#11768).
2479 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2480 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2481 with default display (Bug#11768).
2482
d6e7bf45
EZ
24832012-07-05 Eli Zaretskii <eliz@gnu.org>
2484
2485 * xdisp.c (window_hscroll_limited): New function.
2486 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2487 coordinates when window's hscroll is set to insanely large
2488 values. (Bug#11857)
2489
431391ec
JB
24902012-07-05 Juanma Barranquero <lekktu@gmail.com>
2491
2492 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2493 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2494
23f86fce
DA
24952012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2496
2497 Cleanup xmalloc.
2498 * lisp.h (xzalloc): New prototype. Omit needless casts.
2499 * alloc.c (xzalloc): New function. Omit needless casts.
2500 * charset.c: Omit needless casts. Convert all calls to
2501 xmalloc with following memset to xzalloc.
2502 * dispnew.c: Likewise.
2503 * fringe.c: Likewise.
2504 * image.c: Likewise.
2505 * sound.c: Likewise.
2506 * term.c: Likewise.
2507 * w32fns.c: Likewise.
2508 * w32font.c: Likewise.
2509 * w32term.c: Likewise.
2510 * xfaces.c: Likewise.
2511 * xfns.c: Likewise.
2512 * xterm.c: Likewise.
2513 * atimer.c: Omit needless casts.
2514 * buffer.c: Likewise.
2515 * callproc.c: Likewise.
2516 * ccl.c: Likewise.
2517 * coding.c: Likewise.
2518 * composite.c: Likewise.
2519 * doc.c: Likewise.
2520 * doprnt.c: Likewise.
2521 * editfns.c: Likewise.
2522 * emacs.c: Likewise.
2523 * eval.c: Likewise.
2524 * filelock.c: Likewise.
2525 * fns.c: Likewise.
2526 * gtkutil.c: Likewise.
2527 * keyboard.c: Likewise.
2528 * lisp.h: Likewise.
2529 * lread.c: Likewise.
2530 * minibuf.c: Likewise.
2531 * msdos.c: Likewise.
2532 * print.c: Likewise.
2533 * process.c: Likewise.
2534 * region-cache.c: Likewise.
2535 * search.c: Likewise.
2536 * sysdep.c: Likewise.
2537 * termcap.c: Likewise.
2538 * terminal.c: Likewise.
2539 * tparam.c: Likewise.
2540 * w16select.c: Likewise.
2541 * w32.c: Likewise.
2542 * w32reg.c: Likewise.
2543 * w32select.c: Likewise.
2544 * w32uniscribe.c: Likewise.
2545 * widget.c: Likewise.
2546 * xdisp.c: Likewise.
2547 * xmenu.c: Likewise.
2548 * xrdb.c: Likewise.
2549 * xselect.c: Likewise.
2550
0497dc44
PE
25512012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2552
2553 * fileio.c (time_error_value): Check the right error number.
2554 Problem reported by Troels Nielsen in
2555 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2556
356e7178
PE
25572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2558
4e71fd89
PE
2559 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2560 This should be fixed in a better way; see Eli Zaretskii in
2561 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2562 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2563
f0941253
PE
2564 * fileio.c (time_error_value): Rename from special_mtime.
2565 The old name's problems were noted by Eli Zaretskii in
2566 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2567
065c9eb4
PE
2568 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2569 This variable's comment says Emacs needs at least one GDB-visible
2570 symbol of type enum pvec_type, to work around GDB problems.
2571 The symbol's value doesn't matter.
2572
356e7178
PE
2573 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2574 that causes compilation to fail on pre-C99 compilers.
2575
ed9265fc 25762012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2577
2578 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2579 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2580
3884d954
DA
25812012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2582
d209e2fb 2583 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2584 headers for buffer_defaults and buffer_local_symbols.
2585 Reported by Juanma Barranquero <lekktu@gmail.com>.
2586
ee28be33
SM
25872012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2588
2589 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2590 * lisp.h (enum pvec_type): Use fewer bits.
2591 (PSEUDOVECTOR_SIZE_BITS): New constant.
2592 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2593 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2594 change in pvec_type.
2595 (PSEUDOVECTOR_TYPEP): New macro.
2596 (TYPED_PSEUDOVECTORP): Use it.
2597 * fns.c (internal_equal): Adapt code to extract pvectype.
2598 * emacs.c (gdb_pvec_type): Update type.
2599 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2600 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2601 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2602 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2603 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2604 abusing vector->header.next.nbytes.
2605 (live_vector_p): Use PVEC_TYPE.
2606 (mark_object): Adapt code to extract pvectype. Use switch.
2607
c7f2cd7f
PE
26082012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2611 Tighten new eassert a bit.
2612
8ce70ed2
DA
26132012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2614
2615 Fix compilation with --enable-gcc-warnings and -O1
2616 optimization level.
2617 * doprnt.c (doprnt): Change type of tem to int, initialize
2618 to avoid compiler warning. Add eassert.
2619 * search.c (simple_search): Initialize match_byte to avoid
2620 compiler warning. Add eassert.
2621
dea7f1e5
PE
26222012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2623
24a212eb
PE
2624 Avoid weird behavior with large horizontal scrolls.
2625 Without this change, for example, large hscroll values would
2626 mess up Emacs's display on Fedora 15 x86, presumably due to
2627 overflows in int calculations in the display code.
2628 Also, if buffers had long lines, Emacs would freeze.
2629 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2630 (set_window_hscroll): New function, containing the old guts of
2631 Fset_window_hscroll. Return the clipped value.
2632 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2633 This avoids the need to check against PTRDIFF_MAX.
2634
dea7f1e5
PE
2635 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2636
76046526
DA
26372012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2638
2639 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2640
39adff0d
PE
26412012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2642
63807d47
PE
2643 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2644 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2645 since GCC 4.4.6 issues a bogus warning for them.
2646
39adff0d
PE
2647 Fix bugs in file timestamp newness comparisons.
2648 * fileio.c (Ffile_newer_than_file_p):
2649 * lread.c (Fload): Use full timestamp resolution of files,
2650 not just the 1-second resolution, so that files that are only
2651 slightly newer still count as newer.
2652 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2653 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2654
dbeed9a6
PE
26552012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2656
2657 * fileio.c: Improve handling of file time marker. (Bug#11852)
2658 (special_mtime): New function.
2659 (Finsert_file_contents, Fverify_visited_file_modtime):
2660 Use it to set special mtime values consistently.
2661
636334d6
AS
26622012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2663
2664 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2665 marker for non-existing file. (Bug#11852)
2666
e2017fe2
GM
26672012-07-03 Glenn Morris <rgm@gnu.org>
2668
2669 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2670 and did not make it into globals.h).
2671
404dbd37
TT
26722012-07-03 Tom Tromey <tromey@redhat.com>
2673
2674 * window.c (Fset_window_margins, Fset_window_fringes)
2675 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2676 * textprop.c (Fprevious_property_change): No longer static.
2677 * syntax.c (Fsyntax_table_p): No longer static.
2678 * process.c (Fget_process, Fprocess_datagram_address): No longer
2679 static.
2680 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2681 * keyboard.c (Fcommand_execute): No longer static.
2682 Remove EXFUN.
2683 * insdel.c (Fcombine_after_change_execute): No longer static.
2684 * image.c (Finit_image_library): No longer static.
2685 * fileio.c (Fmake_symbolic_link): No longer static.
2686 * eval.c (Ffetch_bytecode): No longer static.
2687 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2688 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2689 No longer static.
404dbd37
TT
2690 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2691 static.
2692 * dired.c (Ffile_attributes): No longer static.
2693 * composite.c (Fcomposition_get_gstring): No longer static.
2694 * callproc.c (Fgetenv_internal): No longer static.
2695
2696 * ccl.h: Remove EXFUNs.
2697 * buffer.h: Remove EXFUNs.
2698 * dispextern.h: Remove EXFUNs.
2699 * intervals.h: Remove EXFUNs.
2700 * fontset.h: Remove EXFUN.
2701 * font.h: Remove EXFUNs.
2702 * dosfns.c (system_process_attributes): Remove EXFUN.
2703 * keymap.h: Remove EXFUNs.
2704 * lisp.h: Remove EXFUNs.
2705 * w32term.h: Remove EXFUNs.
2706 * window.h: Remove EXFUNs.
2707 * xsettings.h: Remove EXFUN.
2708 * xterm.h: Remove EXFUN.
2709
8e4fd1e1
GM
27102012-07-03 Glenn Morris <rgm@gnu.org>
2711
2712 * lisp.h (Frandom): Make it visible to C.
2713 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2714 buffer for invisible buffers. (Bug#1229)
2715
ca95b3eb
DA
27162012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2717
2718 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2719 values which aren't power of 2.
14ae4239
BT
2720 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2721 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2722 accordingly.
2723
7555c33f
SM
27242012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2725
2726 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2727
2728 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2729
d12e8f5a
DA
27302012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2731
2732 * alloc.c (allocate_vector_block): Remove redundant
2733 calls to mallopt if DOUG_LEA_MALLOC is defined.
2734 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2735 avoid calls to mallopt if zero_vector is returned.
2736
296094c3
DA
27372012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2738
2739 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2740 is enabled, avoid dereferencing NULL current_sblock if
2741 running undumped.
2742
36429c89
DA
27432012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2744
2745 Cleanup basic buffer management.
2746 * buffer.h (struct buffer): Change layout to use generic vector
2747 marking code. Fix some comments. Change type of 'clip_changed'
2748 to bitfield. Remove unused #ifndef old.
2749 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2750 (GET_OVERLAYS_AT): Fix indentation.
2751 (for_each_per_buffer_object_at): New macro.
2752 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2753 (Fbuffer_local_variables): Use it.
2754 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2755 * alloc.c (allocate_buffer): Adjust to match new layout of
2756 struct buffer. Fix comment.
2757 (mark_overlay): New function.
2758 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2759 Lisp area of struct buffer.
2760 (mark_object): Use it. Adjust marking of misc objects
2761 and related comments.
2762
3b3e4cac
PE
27632012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2764
2765 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2766 wrapper that is not needed because the wrapped code is a no-op (zero
2767 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2768 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2769
cf5c0175
DA
27702012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2771
2772 * alloc.c (mark_buffer): Simplify. Remove prototype.
2773 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2774 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2775 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2776 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2777
ca26824c
GM
27782012-06-30 Glenn Morris <rgm@gnu.org>
2779
2e4c5312
GM
2780 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2781
ca26824c
GM
2782 * epaths.in (PATH_SITELOADSEARCH): New.
2783 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2784 This is rather than relying on --enable-locallisppath elements
2785 having "site-lisp" in their names. (Bug#10208#25, 11658)
2786
0d23c240
EZ
27872012-06-30 Eli Zaretskii <eliz@gnu.org>
2788
c9240d7a
EZ
2789 * w32proc.c (sys_select): Accept and ignore one more argument.
2790
2791 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2792
0d23c240 2793 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2794 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2795
2796 * sysdep.c: Don't include dos.h and dosfns.h.
2797
2798 * process.c (sys_select):
2799 * msdos.c (sys_select): Accept one more argument and ignore it.
2800
2801 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2802 adapt data types and code to that.
2803
2804 * dosfns.c:
2805 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2806 which clashes with the gnulib function of the same name.
2807
af5a5a98
AS
28082012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2809
c5e4379c
AS
2810 * font.c (font_style_to_value, font_style_symbolic)
2811 (font_prop_validate_style): Add type checks for values in
2812 font_style_table.
2813
af5a5a98
AS
2814 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2815 argument.
2816 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2817 uses.
2818
8d38f461
EZ
28192012-06-29 Eli Zaretskii <eliz@gnu.org>
2820
2e5a6631
EZ
2821 * xdisp.c (try_window_id): Undo last change.
2822
8d38f461
EZ
2823 * w32.c (getwd): Adjust commentary about startup_dir.
2824 (init_environment): Always call sys_access, even in non-MSVC
2825 builds. Don't chdir to the directory of the Emacs executable.
2826 This undoes code from 1997 which was justified by the need to
2827 "avoid conflicts when removing and renaming directories". But its
2828 downside was that every relative file name was being interpreted
2829 relative to the directory of the Emacs executable, which can never
2830 be TRT. In particular, it broke sys_access when called with
2831 relative file names.
2832 (sys_access): Map GetLastError to errno.
2833
2af3565e
DA
28342012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2835
2836 * window.h (struct window): Change type of 'fringes_outside_margins'
2837 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2838 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2839 Adjust comment.
2840 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2841 to ptrdiff_t.
2842
c8d3a25c 28432012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2844
c8d3a25c
GM
2845 * gnutls.c (emacs_gnutls_handshake):
2846 Add QUIT to make the loop interruptible.
57570cd3 2847
c8d3a25c 28482012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2849
c8d3a25c
GM
2850 * charset.c (init_charset): Make lack of etc/charsets fatal.
2851
3e984ee8
DA
28522012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2853
2854 * editfns.c (region_limit): Fix type mismatch.
2855
ef884f23
DA
28562012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2857
2858 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2859 undefined. Convert from xassert to eassert.
2860 * nsmenu.m: Convert from xassert to eassert.
2861 * nsterm.m: Likewise.
2862
7d7e0027
SM
28632012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2864
2865 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2866
aa754e6a
PE
28672012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2868
2869 Avoid integer overflow on scroll-left and scroll-right.
2870 * window.c (HSCROLL_MAX): New macro.
2871 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2872 overflow when requested scroll falls outside ptrdiff_t range.
2873
80b00b08
DA
28742012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2875
2876 * window.h (struct window): Change type of 'hscroll',
2877 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2878 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2879 Adjust users accordingly.
2880 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2881 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2882 from EMACS_INT to ptrdiff_t.
2883 (make_window): Omit redundant initialization.
2884
62b2bcf6
JB
28852012-06-28 Juanma Barranquero <lekktu@gmail.com>
2886
2887 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2888
45942c7d
DA
28892012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2890
2891 * window.h (struct window): Change type of 'use_time' and
2892 'sequence_number' from Lisp_Object to int.
2893 * frame.c (make_frame): Adjust users accordingly.
2894 * print.c (print_object): Likewise.
2895 * window.c (select_window, Fwindow_use_time, make_parent_window)
2896 (make_window): Likewise.
2897
e509cfa6
DA
28982012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2899
2900 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2901 enabled with --enable-checking=[all,glyphs] configure option.
2902 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2903 adjust comments accordingly.
2904 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2905 undefined, adjust comments accordingly.
2906 * image.c: Likewise.
2907 * scroll.c: Likewise.
2908 * w32fns.c: Likewise.
2909 * w32term.c: Likewise.
2910 * xdisp.c: Likewise.
2911 * xfaces.c: Likewise.
2912 * xfns.c: Likewise.
2913 * xterm.c: Likewise.
2914
a54e2c05
DA
29152012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2916
2917 Generalize run-time debugging checks.
2918 * dispextern.h (XASSERTS): Remove.
2919 * fontset.c (xassert): Remove.
2920 Convert from xassert to eassert.
2921 * alloc.c: Convert from xassert to eassert.
2922 * bidi.c: Likewise.
2923 * dispnew.c: Likewise.
2924 * fns.c: Likewise.
2925 * fringe.c: Likewise.
2926 * ftfont.c: Likewise.
2927 * gtkutil.c: Likewise.
2928 * image.c: Likewise.
2929 * keyboard.c: Likewise.
2930 * menu.c: Likewise.
2931 * process.c: Likewise.
2932 * scroll.c: Likewise.
2933 * sound.c: Likewise.
2934 * term.c: Likewise.
2935 * w32console.c: Likewise.
2936 * w32fns.c: Likewise.
2937 * w32term.c: Likewise.
2938 * window.c: Likewise.
2939 * xdisp.c: Likewise.
2940 * xfaces.c: Likewise.
2941 * xfns.c: Likewise.
2942 * xselect.c: Likewise.
2943 * xterm.c: Likewise.
2944
1ec4b7b2
SM
29452012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2946
2947 * fns.c (maybe_resize_hash_table): Output message when growing the
2948 purify-hashtable.
2949
2014308a
DA
29502012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2951
2952 * alloc.c (allocate_string_data): Remove dead code.
2953 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2954 avoid GCC warning about unused macro.
2955
246155eb
DA
29562012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2957
2958 * alloc.c (allocate_string): Omit intervals initialization.
2959 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2960 as in make_pure_string and make_pure_c_string.
2961
43184b7b
DA
29622012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2963
d209e2fb 2964 * alloc.c (allocate_string): Fix last change.
43184b7b 2965
3fe6dd74
DA
29662012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2967
d209e2fb 2968 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2969 to memset, add explicit initialization where appropriate.
2970
1ba6038a
GM
29712012-06-27 Glenn Morris <rgm@gnu.org>
2972
2973 * lisp.mk (lisp): Remove paths.elc.
2974
c89926a5
CY
29752012-06-27 Chong Yidong <cyd@gnu.org>
2976
2977 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2978
ed6b3510
JW
29792012-06-26 John Wiegley <johnw@newartisans.com>
2980
1ec4b7b2 2981 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2982 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2983
ed6b3510
JW
2984 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2985 when building with Clang.
2986
8edd4a2b
SM
29872012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2988
2989 * eval.c (Fapply): Allow calling it with a single argument.
2990
f6f62d1b
EZ
29912012-06-26 Eli Zaretskii <eliz@gnu.org>
2992
2993 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2994 _stricmp and _strnicmp.
2995 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2996
62efea5e
DA
29972012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2998
2999 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3000 allocated window.
3001 (allocate_process): Likewise for new process.
8edd4a2b 3002 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3003 (allocate_frame): Likewise.
3004 * frame.c (make_frame): Omit redundant initialization.
3005 * window.c (make_parent_window): Use memset.
3006 (make_window): Omit redundant initialization.
3007 * process.c (make_process): Omit redundant initialization.
3008 * terminal.c (create_terminal): Likewise.
3009
42997f4d
DA
30102012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3011
3012 * term.c (delete_tty): Remove redundant call to memset.
3013
1130ecfc
DA
30142012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3015
3016 * alloc.c: Remove build_string.
3017 * lisp.h: Define build_string as static inline. This provides
3018 a better opportunity to optimize away calls to strlen when the
3019 function is called with compile-time constant argument.
3020 * image.c (imagemagick_error): Convert to build_string.
3021 * w32proc.c (sys_spawnve): Likewise.
3022 * xterm.c (x_term_init): Likewise.
3023
cf38a720
PE
30242012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3025
99027bdd
PE
3026 Use sprintf return value instead of invoking strlen on result.
3027 In the old days this wasn't portable, since some sprintf
3028 implementations returned char *. But they died out years ago and
3029 Emacs already assumes sprintf returns int.
3030 Similarly for float_to_string.
3031 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3032 * ccl.c (ccl_driver):
3033 * character.c (string_escape_byte8):
3034 * data.c (Fnumber_to_string):
3035 * doprnt.c (doprnt):
3036 * print.c (print_object):
3037 * xdisp.c (message_dolog):
3038 * xfns.c (syms_of_xfns):
3039 Use sprintf or float_to_string result to avoid need to call strlen.
3040 * data.c (Fnumber_to_string):
3041 Use make_unibyte_string, since the string must be ASCII.
3042 * lisp.h, print.c (float_to_string): Now returns int length.
3043 * term.c (produce_glyphless_glyph):
3044 Use sprintf result rather than recomputing it.
3045
cf38a720
PE
3046 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3047 * Makefile.in (ALL_CFLAGS):
3048 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3049 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3050
3511c784
DA
30512012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3052
0a08eb21 3053 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3054 strcasecmp if available.
3055 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3056
fb7da12e
AS
30572012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3058
3059 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3060 Avoid comma operator.
3061 * menu.c (push_submenu_start, push_submenu_end)
3062 (push_left_right_boundary, push_menu_pane): Likewise.
3063 * msdos.c (dos_rawgetc): Likewise.
3064
afa2ffd8
DA
30652012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3066
3067 * xfns.c (xic_create_fontsetname): Remove redundant calls
3068 to memset.
3069
b3b4476b
PE
30702012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3071
4495ff38
PE
3072 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3073 sprintf already null-terminates its output.
3074
b3b4476b
PE
3075 * xfns.c (x_window): Remove redundant cast.
3076
b00876c9
DA
30772012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3078
3079 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3080 `const char *' to `char *' to avoid compiler warning.
3081
d188e26b
PE
30822012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3083
885d1d74
PE
3084 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3085 instead of truncating it to 63 (admittedly a generous limit).
3086
d188e26b
PE
3087 * process.c: Fix spelling and caps in comments.
3088
e2f560b1
DN
30892012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3090
e86db54b 3091 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3092 * sysdep.c (setpgrp): Remove definition, not used in this file.
3093
7583a3a1
JB
30942012-06-24 Juanma Barranquero <lekktu@gmail.com>
3095
3096 * makefile.w32-in: Update dependencies.
3097
696056c2
EZ
30982012-06-24 Eli Zaretskii <eliz@gnu.org>
3099
3100 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3101 (SYSTIME_H): Add nt/inc/sys/time.h.
3102
3103 * systime.h [WINDOWSNT]: Include sys/time.h.
3104
3105 * s/ms-w32.h (struct timespec): Definition moved from
3106 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3107
845ca893
PE
31082012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3109
3110 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3111 * buffer.h (buffer_slot_type_mismatch):
3112 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3113 * eval.c (unwind_to_catch):
3114 * image.c (my_png_error, my_error_exit):
3115 * keyboard.c (quit_throw_to_read_char, user_error)
3116 (Fexit_recursive_edit, Fabort_recursive_edit):
3117 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3118 (wrong_type_argument, buffer_overflow, __executable_start)
3119 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3120 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3121 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3122 (fatal):
3123 (child_setup) [!DOS_NT]:
3124 * lread.c (end_of_file_error, invalid_syntax):
3125 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3126 * puresize.h (pure_write_error):
3127 * search.c (matcher_overflow):
3128 * sound.c (sound_perror, alsa_sound_perror):
3129 * sysdep.c, syssignal.h (croak):
3130 * term.c (maybe_fatal, vfatal):
3131 * textprop.c (text_read_only):
3132 * undo.c (user_error):
3133 * unexmacosx.c (unexec_error):
3134 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3135 Use _Noreturn rather than NO_RETURN.
3136 No need for separate decl merely because of _Noreturn.
3137 * sound.c (sound_warning, parse_sound):
3138 Remove unnecessary forward decls.
3139
f1dd8073
PE
31402012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3141
3142 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3143 * lisp.h (WAIT_READING_MAX): New macro.
3144 * dispnew.c (Fsleep_for, sit_for):
3145 * keyboard.c (kbd_buffer_get_event):
3146 * process.c (Faccept_process_output):
3147 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3148 This improves on the previous patch, which introduced a bug
3149 when time_t is unsigned and as wide as intmax_t.
3150 See <http://bugs.gnu.org/9000#51>.
3151
b82c1755
EZ
31522012-06-23 Eli Zaretskii <eliz@gnu.org>
3153
3154 * dispnew.c (sit_for, Fsleep_for):
3155 * keyboard.c (kbd_buffer_get_event):
3156 * process.c (Faccept_process_output): Avoid compiler warnings when
3157 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3158
ca300656
JB
31592012-06-23 Juanma Barranquero <lekktu@gmail.com>
3160
049ec95b
JB
3161 * makefile.w32-in: Update dependencies.
3162
ca300656
JB
3163 * w32.c (ltime): Add return type and declare static.
3164 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3165
db7b8d06
PE
31662012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3167
3168 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3169 Privately reported by Herbert J. Skuhra.
3170 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3171 All uses changed.
3172 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3173 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3174
0bd8297f
EZ
31752012-06-23 Eli Zaretskii <eliz@gnu.org>
3176
96512555
EZ
3177 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3178 last argument of make_unibyte_string.
3179
0bd8297f
EZ
3180 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3181 language ID in the event parameters.
3182
3183 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3184 event.code, not the obscure "character set ID".
3185
63def6b6
CY
31862012-06-23 Chong Yidong <cyd@gnu.org>
3187
3188 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3189
e8a02204
EZ
31902012-06-23 Eli Zaretskii <eliz@gnu.org>
3191
388cdec0
EZ
3192 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3193 * w32.c (fdutimens): New function.
3194
3195 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3196
3197 * s/ms-w32.h (pselect): Redirect to sys_select.
3198
3199 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3200
e8a02204
EZ
3201 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3202 in the logic of incrementing and decrementing the value of
3203 use_relocatable_buffers.
3204
d054f3fb
PE
32052012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3206
3207 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3208 Privately reported by Herbert J. Skuhra.
3209 [__FreeBSD__]: Remove "*/" typo after "#include".
3210 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3211 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3212 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3213 Don't assume EMACS_TIME and struct timeval are the same type.
3214
d35af63c
PE
32152012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3216
3217 Support higher-resolution time stamps (Bug#9000).
3218 The time stamps are only nanosecond-resolution at the C level,
3219 since that's the best that any real-world system supports now.
3220 But they are picosecond-resolution at the Lisp level, as that's
3221 easy, and leaves room for future OS improvements.
3222
3223 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3224 (LIBES): Use it.
3225
3226 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3227 Don't get current time unless it's needed.
3228
3229 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3230 now provides it if it's absent.
3231 (start_atimer): Port to higher-res time stamps.
3232 Check for time stamp overflow. Don't get current time more
3233 often than is needed.
3234
3235 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3236 Include systime.h, not time.h.
3237 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3238
3239 * dired.c: Include stat-time.h.
3240 (Ffile-attributes): File times now have higher resolution.
3241
3242 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3243 (struct image): Timestamp now has higher resolution.
3244
3245 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3246 has at least microseconds now. All uses removed.
3247 (update_frame, update_single_window, update_window, update_frame_1)
3248 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3249
3250 * editfns.c (time_overflow): Now extern.
3251 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3252 (float-time, Fformat_time_string, Fcurrent_time_string)
3253 (Fcurrent_time_zone): Accept and generate higher-resolution
3254 time stamps.
3255 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3256 (decode_time_components, lisp_seconds_argument): New functions.
3257 (make_time): Now static.
3258 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3259 Report an error if the time is invalid, rather than having the caller
3260 do that.
3261
3262 * fileio.c: Include <stat-time.h>
3263 (Fcopy_file): Copy higher-resolution time stamps.
3264 Prefer to set the time stamp via a file descriptor if that works.
3265 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3266 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3267 (Fvisited_file_modtime, Fset_visited_file_modtime):
3268 Support higher-resolution time stamps.
3269
3270 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3271
3272 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3273
3274 * image.c (prepare_image_for_display, clear_image_cache)
3275 (lookup_image): Port to higer-resolution time stamps.
3276
3277 * keyboard.c (start_polling, bind_polling_period):
3278 Check for time stamp overflow.
3279 (read_char, kbd_buffer_get_event, timer_start_idle)
3280 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3281 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3282 Port to higher-resolution time stamps. Do not assume time_t is signed.
3283 (decode_timer): New function. Timers are now vectors of length 9,
3284 not 8, to accommodate the picosecond component.
3285 (timer_check_2): Use it.
3286
3287 * nsterm.m (select_timeout, timeval_subtract): Remove.
3288 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3289 as they're a bit more accurate and handle overflow better.
3290 (ns_select): Change prototype to be compatible with pselect.
3291 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3292 * nsterm.h (ns_select): Adjust prototype.
3293
3294 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3295 us-resolution time stamps.
3296 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3297
3298 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3299
3300 * lisp.h (time_overflow): New decl.
3301 (wait_reading_process_output): First arg is now intmax_t, not int,
3302 to accommodate larger waits.
3303
3304 * process.h (struct Lisp_Process.read_output_delay):
3305 Now counts nanoseconds, not microseconds.
3306 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3307 EMACS_HAS_USECS.
3308 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3309 (wait_reading_process_output):
3310 Port to ns-resolution time stamps.
3311 (Faccept_process_output, wait_reading_process_output):
3312 Check for time stamp overflow. Do not assume time_t is signed.
3313 (select_wrapper): Remove; we now use pselect.
3314 (Fprocess_attributes): Now generates ns-resolution time stamps.
3315
3316 * sysdep.c: Include utimens.h. Don't include utime.h
3317 or worry about struct utimbuf; gnulib does that for us now.
3318 (gettimeofday): Remove; gnulib provides a substitute.
3319 (make_timeval): New function.
3320 (set_file_times): Now sets ns-resolution time stamps.
3321 New arg FD; all uses changed.
3322 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3323 (system_process_attributes):
3324 Now returns ns-resolution time stamp. All uses changed.
3325 Check for time stamp overflow.
3326
3327 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3328 provides a substitute now.
3329
3330 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3331 since it guarantees struct timespec.
3332 (EMACS_TIME): Now struct timespec, so that we can support
3333 ns-resolution time stamps.
3334 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3335 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3336 (EMACS_USECS): Remove.
3337 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3338 so multiply the arg by 1000 before storing it.
3339 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3340 New macros.
3341 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3342 Port to ns-resolution time stamps.
3343 (EMACS_TIME_NEG_P): Remove; replaced by....
3344 (EMACS_TIME_SIGN): New macro.
3345 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3346 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3347 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3348 (make_timeval, make_lisp_time, decode_time_components): New decls.
3349 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3350 that it mishandled time_t overflow. You can't compare by subtracting!
3351 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3352 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3353
3354 * term.c: Include <sys/time.h>.
3355 (timeval_to_Time): New function, for proper overflow wraparound.
3356 (term_mouse_position, term_mouse_click): Use it.
3357
3358 * undo.c (record_first_change): Support higher-resolution time stamps
3359 in the undo buffer.
3360 (Fprimitive_undo): Use them when restoring time stamps.
3361
3362 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3363 (w32_get_internal_run_time):
3364 Port to higher-resolution Emacs time stamps.
3365 (ltime): Now accepts single 64-bit integer, as that's more convenient
3366 for callers.
3367
3368 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3369
3370 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3371 for compatibility with pselect. Support ns-resolution time stamps.
3372
3373 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3374
3375 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3376 Check for time stamp overflow, and support ns-resolution time stamps.
3377
3378 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3379 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3380 (timeval_subtract): Remove; no longer needed.
3381 (XTflash, XTring_bell, x_wait_for_event):
3382 Port to ns-resolution time stamps. Don't assume time_t is signed.
3383
b6a92dfe
CY
33842012-06-22 Chong Yidong <cyd@gnu.org>
3385
3386 * xdisp.c (x_consider_frame_title): Revert last change.
3387
d251c37c
EZ
33882012-06-22 Eli Zaretskii <eliz@gnu.org>
3389
3390 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3391 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3392 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3393 staticidx goes up to 1597 out of 1600 = 0x640.)
3394
f10deafb
PE
33952012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3396
3397 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3398 Otherwise, the umask might be mistakenly 0 while handling input signals.
3399
ec6de1e2
SM
34002012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3401
3402 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3403
28be1ada
DA
34042012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3405
3406 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3407 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3408 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3409 access to `contents' member of Lisp_Vector objects with AREF and ASET
3410 where appropriate.
3411
c6bf3022
CY
34122012-06-19 Chong Yidong <cyd@gnu.org>
3413
3414 * frame.c (delete_frame): When selecting a frame on a different
3415 text terminal, do not alter the terminal's top-frame.
3416
3417 * xdisp.c (format_mode_line_unwind_data): Record the target
3418 frame's selected window and its terminal's top-frame.
3419 (unwind_format_mode_line): Restore them.
3420 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3421 Callers changed.
3422 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3423 since tty frames can be explicitly named.
3424 (prepare_menu_bars): Likewise.
3425
3426 * term.c (Ftty_top_frame): New function.
3427
defd4196
PE
34282012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3429
3430 Port byte-code-meter to modern targets.
3431 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3432 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3433 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3434 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3435 (METER_1, METER_2): Simplify.
3436
1053a871
SM
34372012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3438
3439 * data.c (Fdefalias): Return `symbol' (bug#11686).
3440
b7e8d081
MR
34412012-06-18 Martin Rudalics <rudalics@gmx.at>
3442
3443 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3444 gets killed during executing of this function (Bug#11665).
3445 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3446 (Vkill_buffer_query_functions): In doc-string say that functions
3447 run by this hook should not change the current buffer.
3448
7ea2b339
PE
34492012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3450
3451 Fix recently-introduced process.c problems found by static checking.
3452 * process.c (write_queue_push, write_queue_pop, send_process):
3453 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3454 (write_queue_pop): Fix pointer signedness problem.
3455 (send_process): Remove unused local.
3456
96a313a1
CY
34572012-06-17 Chong Yidong <cyd@gnu.org>
3458
3459 * xdisp.c (redisplay_internal): No need to redisplay terminal
3460 frames that are not on top.
3461
20ca2e94
TN
34622012-06-17 Troels Nielsen <bn.troels@gmail.com>
3463
3464 * process.c (make_process): Initialize write_queue.
3465 (write_queue_push, write_queue_pop): New functions.
3466 (send_process): Use them to maintain correct ordering of process
3467 writes (Bug#10815).
3468
9a900ca9
PE
34692012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3470
310fbfa8
PE
3471 * lisp.h (eassert): Assume C89 or later.
3472 This removes the need for CHECK.
3473 (CHECK): Remove. Its comments about always evaluating its
3474 argument were confusing, as 'eassert' typically does not evaluate
3475 its argument.
3476
27bb1ca4
PE
3477 * coding.c (produce_chars): Use ptrdiff_t, not int.
3478
9a900ca9
PE
3479 * xterm.c (x_draw_underwave): Check for integer overflow.
3480 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3481
41b7f8bc 34822012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3483
3484 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3485 referenced (Bug#11583).
3486
9b0e3eba
AA
34872012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3488
3489 Implement wave-style variant of underlining.
3490 * dispextern.h (face_underline_type): New enum.
3491 (face): Add field for underline type.
3492 * nsterm.m (ns_draw_underwave): New function.
3493 (ns_draw_text_decoration): Use it.
3494 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3495 New functions.
3496 (x_draw_glyph_string): Use them.
3497 * xfaces.c (Qline, Qwave): New Lisp objects.
3498 (check_lface_attrs, merge_face_ref)
1053a871
SM
3499 (Finternal_set_lisp_face_attribute, realize_x_face):
3500 Handle wave-style underline face attributes.
9b0e3eba
AA
3501 * xterm.c (x_draw_underwave): New function.
3502 (x_draw_glyph_string): Use it.
3503
0fb52f11
JB
35042012-06-16 Juanma Barranquero <lekktu@gmail.com>
3505
3506 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3507 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3508 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3509 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3510 ($(BLD)/w32select.$(O)): Update dependencies.
3511
e5560ff7
AS
35122012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3513
3514 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3515 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3516 * character.c (_fetch_multibyte_char_p): Remove.
3517 * alloc.c: Include "character.h" before "buffer.h".
3518 * bidi.c: Likewise.
3519 * buffer.c: Likewise.
3520 * bytecode.c: Likewise.
3521 * callint.c: Likewise.
3522 * callproc.c: Likewise.
3523 * casefiddle.c: Likewise.
3524 * casetab.c: Likewise.
3525 * category.c: Likewise.
3526 * cmds.c: Likewise.
3527 * coding.c: Likewise.
3528 * composite.c: Likewise.
3529 * dired.c: Likewise.
3530 * dispnew.c: Likewise.
3531 * doc.c: Likewise.
3532 * dosfns.c: Likewise.
3533 * editfns.c: Likewise.
3534 * emacs.c: Likewise.
3535 * fileio.c: Likewise.
3536 * filelock.c: Likewise.
3537 * font.c: Likewise.
3538 * fontset.c: Likewise.
3539 * fringe.c: Likewise.
3540 * indent.c: Likewise.
3541 * insdel.c: Likewise.
3542 * intervals.c: Likewise.
3543 * keyboard.c: Likewise.
3544 * keymap.c: Likewise.
3545 * lread.c: Likewise.
3546 * macros.c: Likewise.
3547 * marker.c: Likewise.
3548 * minibuf.c: Likewise.
3549 * nsfns.m: Likewise.
3550 * nsmenu.m: Likewise.
3551 * print.c: Likewise.
3552 * process.c: Likewise.
3553 * regex.c: Likewise.
3554 * region-cache.c: Likewise.
3555 * search.c: Likewise.
3556 * syntax.c: Likewise.
3557 * term.c: Likewise.
3558 * textprop.c: Likewise.
3559 * undo.c: Likewise.
3560 * unexsol.c: Likewise.
3561 * w16select.c: Likewise.
3562 * w32fns.c: Likewise.
3563 * w32menu.c: Likewise.
3564 * window.c: Likewise.
3565 * xdisp.c: Likewise.
3566 * xfns.c: Likewise.
3567 * xmenu.c: Likewise.
3568 * xml.c: Likewise.
3569 * xselect.c: Likewise.
3570
2f07e6af
EZ
35712012-06-16 Eli Zaretskii <eliz@gnu.org>
3572
1053a871
SM
3573 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3574 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3575 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3576 row.
3577 (handle_face_prop): Use chunk-relative overlay string index when
3578 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3579 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3580 the rightmost. (Bug#11720)
2f07e6af 3581
29b83cec
AS
35822012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3583
3584 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3585 (CATEGORY_MEMBER): Enforce 1/0 value.
3586 * category.c (_temp_category_set): Remove.
3587
4c5501e9
EZ
35882012-06-16 Eli Zaretskii <eliz@gnu.org>
3589
3590 * window.c (Fdelete_other_windows_internal)
3591 (Fdelete_window_internal): Don't access frame's mouse highlight
3592 info of the initial frame. (Bug#11677)
3593
2b570124
PE
35942012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3595
e93864f9
PE
3596 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3597 Assume USE_2_TAGS_FOR_INTS.
3598 (xreload): Adjust $tagmask width to match recent lisp.h change.
3599
2b570124
PE
3600 Simplify lisp.h in minor ways that should not affect code.
3601 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3602 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3603 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3604 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3605 (INTTYPEBITS): New macro, for clarity.
3606 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3607 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3608 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3609 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3610 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3611
81755f69
JB
36122012-06-13 Juanma Barranquero <lekktu@gmail.com>
3613
3614 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3615
16192a57
GM
36162012-06-13 Glenn Morris <rgm@gnu.org>
3617
3618 * s/bsd-common.h (BSD4_3):
3619 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3620
646b5f55
AS
36212012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3622
3623 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3624 instead of union.
3625 (XLI, XIL): Define.
1053a871
SM
3626 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3627 Use them.
3628 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3629 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3630 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3631 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3632 * frame.c (delete_frame): Remove outdated comment.
3633 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3634 USE_LISP_UNION_TYPE.
3635 (Fw32_unregister_hot_key): Likewise.
3636 (Fw32_toggle_lock_key): Likewise.
3637 * w32menu.c (add_menu_item): Likewise.
3638 (w32_menu_display_help): Use XIL instead of checking
3639 USE_LISP_UNION_TYPE.
3640 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3641 (init_heap): Likewise.
3642 * w32term.c (w32_read_socket): Update comment.
3643
1d3823c9
GM
36442012-06-13 Glenn Morris <rgm@gnu.org>
3645
c62ff706
GM
3646 * s/usg5-4-common.h, src/s/unixware.h:
3647 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3648
1d3823c9
GM
3649 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3650
bfe3e0a2
PE
36512012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3652
3653 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3654 * alloc.c (make_number) [!defined make_number]:
3655 Remove, as lisp.h always defines this now.
3656 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3657 (roundup_size): Verify that it is a power of 2.
3658 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3659 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3660 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3661 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3662 USE_LSB_TAG now is always defined to be either 0 or 1.
3663 All uses changed.
3664 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3665 code works fine either way, and efficiency is not a concern here,
3666 as the union type is for debugging, not for production.
3667 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3668 Use an inline function on all platforms when using the union type,
3669 since this is simpler and 'static inline' can be used portably
3670 within Emacs now.
3671 (LISP_INITIALLY_ZERO): New macro.
3672 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3673 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3674
45fa9c0f
GM
36752012-06-12 Glenn Morris <rgm@gnu.org>
3676
b4492cba
GM
3677 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3678
3679 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3680
45fa9c0f
GM
3681 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3682 Move BROKEN_SIGIO to configure.
3683
3684 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3685 Move NO_TERMIO to configure.
3686
0e25d334
CY
36872012-06-12 Chong Yidong <cyd@gnu.org>
3688
3689 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3690 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3691 MagickExportImagePixels is undefined.
3692
43682bb6
PE
36932012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3694
3695 * image.c (imagemagick_load_image): Remove unused label.
3696
a9be7d2b
GM
36972012-06-11 Glenn Morris <rgm@gnu.org>
3698
3699 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3700 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3701 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3702 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3703
3017f87f
SM
37042012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3705
3706 * alloc.c (make_byte_code): New function.
3707 (Fmake_byte_code): Use it. Don't purify here.
3708 * lread.c (read1): Use it as well to avoid extra allocation.
3709
1b9b4cf4
CY
37102012-06-11 Chong Yidong <cyd@gnu.org>
3711
3712 * image.c (imagemagick_load_image): Implement transparency.
3713
95988fcf
AS
37142012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3715
3716 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3717 account for preceding backslashes. (Bug#11663)
3718
cd4eb164
CY
37192012-06-09 Chong Yidong <cyd@gnu.org>
3720
3721 * term.c: Support italics in capable terminals (Bug#9652).
3722 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3723 (turn_on_face): Output using TS_enter_italic_mode if available.
3724 Don't handle unused blinking and alt-charset cases.
3725 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3726 and tty_alt_charset_p cases.
3727 (tty_capable_p, init_tty): Support italics.
3728
3729 * termchar.h (struct tty_display_info): Add field for italics.
3730 Remove unused blink field.
3731
3732 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3733 Handle slant.
3734
3735 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3736 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3737 tty_alt_charset_p. Add tty_italic_p.
3738
ff88beb8
MA
37392012-06-09 Michael Albinus <michael.albinus@gmx.de>
3740
3741 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3742 dbus_type_is_basic if available.
3743 (xd_extract_signed, xd_extract_unsigned): Rename from
3744 extract_signed and extract_unsigned, respectively. Adapt callers.
3745
44286096
CY
37462012-06-09 Chong Yidong <cyd@gnu.org>
3747
1682701f
CY
3748 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3749
44286096
CY
3750 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3751 case (Bug#9752).
3752
d86feb17
PE
37532012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3754
3755 * xdisp.c (vmessage): Treat frame message as multibyte.
3756 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3757 would generate the diagnostic "Making \302\247 buffer-local while
3758 let-bound!".
3759
d5c20fe8
EZ
37602012-06-08 Eli Zaretskii <eliz@gnu.org>
3761
3762 * dispnew.c (showing_window_margins_p): Undo last change, which
3763 was done due to an inadvertent commit.
3764 (adjust_frame_glyphs_for_frame_redisplay): Do call
3765 showing_window_margins_p.
3766
513749ee
SM
37672012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3768
3769 * eval.c (Fmake_var_non_special): New primitive.
3770 (syms_of_eval): Defsubr it.
3771 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3772
d4a8f5c1
JB
37732012-06-08 Juanma Barranquero <lekktu@gmail.com>
3774
3775 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3776 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3777
8bbbc977
EZ
37782012-06-08 Eli Zaretskii <eliz@gnu.org>
3779
3780 * alloc.c (allocate_vectorlike): Fix last change.
3781
f3372c87
DA
37822012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3783
3784 Block-based vector allocation of small vectors.
3785 * lisp.h (struct vectorlike_header): New field `nbytes',
3786 adjust comment accordingly.
3787 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3788 to denote vector blocks. Adjust users (live_vector_p,
3789 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3790 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3791 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3792 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3793 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3794 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3795 (roundup_size): New constant.
3796 (struct vector_block): New data type.
3797 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3798 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3799 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3800 (sweep_vectors): New functions.
3801 (allocate_vectorlike): Return `zero_vector' as the only vector of
3802 0 items. Allocate new vector from block if vector size is less than
3803 or equal to VBLOCK_BYTES_MAX.
3804 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3805 (init_alloc_once): Add call to init_vectors.
3806
4f18a4ed
SM
38072012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3808
3809 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3810
86f158bc
PE
38112012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3812
3813 * doprnt.c (doprnt): Truncate multibyte char correctly.
3814 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3815 would mishandle a string argument "Xc" if X was a multibyte
3816 character of length 2: it would truncate after X's first byte
3817 rather than including all of X.
3818
c5cfcbe0
CY
38192012-06-06 Chong Yidong <cyd@gnu.org>
3820
3821 * buffer.c (word_wrap): Doc fix.
3822
c05cf390
PE
38232012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3824
3825 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3826
0c3461de
GM
38272012-06-03 Glenn Morris <rgm@gnu.org>
3828
3829 * xdisp.c (tool-bar-style): Doc fix.
3830
c71232db
UM
38312012-06-03 Ulrich Müller <ulm@gentoo.org>
3832
3833 * Makefile.in (PAXCTL): Define.
3834 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3835 binary via PaX flags if the paxctl utility is available.
3836 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3837 Restore PaX flags to their default. (Bug#11398)
3838
383f7350
CY
38392012-06-03 Chong Yidong <cyd@gnu.org>
3840
3841 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3842 buffer (Bug#11226).
3843
5f2c76c6
CY
38442012-06-03 Chong Yidong <cyd@gnu.org>
3845
3846 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3847 (note_mode_line_or_margin_highlight): If there is no help echo,
3848 use mode-line-default-help-echo. Handle the case where the mouse
3849 position is past the end of the mode line string.
3850
3851 * buffer.c (buffer_local_value_1): New function, split from
3852 Fbuffer_local_value; can return Qunbound.
3853 (Fbuffer_local_value): Use it.
3854 (Vmode_line_format): Docstring tweaks.
3855
773d47f6
PE
38562012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3857
3858 * sysdep.c (system_process_attributes): Improve comment.
3859
f2d6a3df
SM
38602012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3861
3862 * keyboard.c: Export real-this-command to Elisp.
3863 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3864 and DEFVAR it. Update all users.
3865
63810350
PE
38662012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3867
7bd5c1f4
PE
3868 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3869
63810350
PE
3870 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3871 Convert pctcpu and pctmem to Lisp float properly.
3872 Let the compiler fold better, as 100.0/0x8000 is exact.
3873
a2821611
AS
38742012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3875
3876 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3877 cons_block.
3878
5fceba1d
PE
38792012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3882
c98ff5dd
DA
38832012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3884
3885 For a 'struct window', replace some Lisp_Object fields to
3886 bitfields where appropriate, remove unused fields.
3887 * window.h (struct window): Remove unused 'last_mark_x' and
3888 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3889 change it's type from Lisp_Object to bitfield.
3890 Change type of 'force_start', 'optional_new_start',
3891 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3892 fields from Lisp_Object to bitfield. Adjust users accordingly.
3893
ca34e0be
PE
38942012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3895
3896 Pacify gcc -Wdouble-precision when using Xaw.
3897 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3898 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3899 Use 'float' consistently, rather than 'float' in most places
3900 and 'double' in a couple of places.
3901
efc00ab1 39022012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3903
3904 * xdisp.c (handle_stop): Detect whether we have overlay strings
3905 loaded by testing it->current.overlay_string_index to be
3906 non-negative, instead of checking whether n_overlay_strings is
3907 positive. (Bug#11587)
3908
efc00ab1 39092012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3910
3911 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3912
3913 * doc.c (Fsubstitute_command_keys): Doc fix.
3914
efc00ab1 39152012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3916
3917 * search.c (search_buffer): Remove calls to
3918 r_alloc_inhibit_buffer_relocation, as it is now called by
3919 maybe_unify_char, which was the cause of relocation of buffer text
3920 in bug#11519.
3921
efc00ab1 39222012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3923
3924 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3925 for the duration of call to load_charset, to avoid problems with
3926 callers of maybe_unify_char that access buffer text through C
3927 pointers.
3928
3929 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3930 decrement the inhibition flag, instead of just setting or
3931 resetting it.
3932
ba93a187
PE
39332012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3934
3935 Remove obsolete '#define static' cruft.
3936 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3937 This #undef was "temporary" in 2000; it is no longer needed
3938 now that '#define static' has gone away.
3939 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3940 (gray_bitmap_bits): Remove; no longer needed.
3941 All uses replaced with definiens.
3942 * xterm.c: Include "bitmaps/gray.xbm".
3943
9e4bf381
PE
39442012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3945
3946 Clean up __executable_start, monstartup when --enable-profiling.
3947 The following changes affect the code only when profiling.
3948 * dispnew.c (__executable_start): Rename from safe_bcopy.
3949 Define only on platforms that need it.
3950 * emacs.c: Include <sys/gmon.h> when profiling.
3951 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3952 (__executable_start): Remove decl, since lisp.h does it now.
3953 (safe_bcopy): Remove decl; no longer has that name.
3954 (main): Coalesce #if into single bit of code, for simplicity.
3955 Cast pointers to uintptr_t, since standard libraries want integers
3956 and not pointers.
3957 * lisp.h (__executable_start): New decl.
3958
32d72c2f
GM
39592012-05-31 Glenn Morris <rgm@gnu.org>
3960
3961 * image.c (Fimagemagick_types): Doc fix.
3962
baac5bc7
JM
39632012-05-30 Jim Meyering <meyering@redhat.com>
3964
3965 * callproc.c (Fcall_process_region): Include directory component
3966 in mkstemp error message (Bug#11586).
3967
72cb32cf
PE
39682012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3969
3970 * alloc.c, lisp.h (make_pure_vector): Now static.
3971
61b108cc
SM
39722012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3973
3974 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3975 Move to byte-run.el.
3976 (Fautoload): Do the hash-doc more carefully.
3977 * data.c (Fdefalias): Purify definition, except for keymaps.
3978 (Qdefun): Move from eval.c.
3979 * lisp.h (Qdefun): Remove.
3980 * lread.c (read1): Tiny simplification.
3981
471fe23d
TN
39822012-05-29 Troels Nielsen <bn.troels@gmail.com>
3983
934f3f58 3984 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3985 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3986 Bug#9642, but explicitly check that the buffer the overlay would
3987 be moved to is live and rearrange lines to make sure that errors
3988 will not put the overlay in an inconsistent state.
3989 (Fdelete_overlay): Cosmetics.
3990
85d0efd1
EZ
39912012-05-28 Eli Zaretskii <eliz@gnu.org>
3992
3993 * w32term.c (my_bring_window_to_top): New function.
3994 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3995 could be different from the original one.
3996 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3997 (Bug#11513)
3998
3999 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4000 by calling BringWindowToTop.
4001
4002 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4003 (WM_EMACS_END): Increase by one.
4004
da92a98c
PE
40052012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4006
4007 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4008 This avoids undefined behavior that might cause the eassert
4009 to not catch an out-of-range value.
4010
74d1f848
JB
40112012-05-28 Juanma Barranquero <lekktu@gmail.com>
4012
4013 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4014 Update dependencies.
4015
9e1a06fc
EZ
40162012-05-27 Eli Zaretskii <eliz@gnu.org>
4017
4018 * bidi.c (bidi_mirror_char): Fix last change.
4019
f3dd7312
AS
40202012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4021
4022 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4023 when referring to sectname field in printf format.
4024
81899c91
PE
40252012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4026
57b81a9f
PE
4027 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4028 Only r_alloc_inhibit_buffer_relocation needed to be added;
4029 the others were already declared.
4030
81899c91
PE
4031 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4032 before checking whether it's out of range. Put the check inside
4033 eassert. See
4034 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4035
33017faf 40362012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4037
4038 * callproc.c (Fcall_process): Restore a line that was accidentally
4039 commented out in the 2011-02-13 change (bug#11547).
4040
33017faf 40412012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4042
4043 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4044 defined on ralloc.c.
4045
4046 * buffer.c [REL_ALLOC]: Remove prototypes of
4047 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4048 they are now on lisp.h.
4049
4050 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4051
4052 * search.c (search_buffer): Use it to inhibit relocation of buffer
4053 text while re_search_2 is doing its job, because re_search_2 is
4054 passed C pointers to buffer text. (Bug#11519)
4055
23415acf
EZ
4056 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4057 Update value to 24.
4058
44e27368
EZ
4059 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4060 state after an additional call to move_it_in_display_line_to, keep
4061 the values of it->max_ascent and it->max_descent found for the
4062 entire line.
4063 (pos_visible_p): Revert the comparison against bottom_y to what it
4064 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4065 (Bug#11464)
4066
c1892f11
PE
40672012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4068
4069 Fix coding-related core dumps with gcc -ftrapv.
4070 The code was computing A - B, where A and B are pointers, and B is
4071 random garbage. This can lead to core dumps on platforms that
4072 have special pointer registers, and it also leads to core dumps on
4073 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4074 A - B only when B is initialized properly.
4075 * coding.c (coding_set_source, coding_set_destination): Return void.
4076 (coding_change_source, coding_change_destinations): New functions,
4077 with the old behaviors of coding_set_source and coding_set_destination.
4078 All callers that need an offset changed to use these new functions.
4079
eb7afdad
GM
40802012-05-26 Glenn Morris <rgm@gnu.org>
4081
4082 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4083
f12fdf02
EZ
40842012-05-26 Eli Zaretskii <eliz@gnu.org>
4085
53a63be6 4086 Extend mouse support on W32 text-mode console.
61b108cc
SM
4087 * xdisp.c (draw_row_with_mouse_face):
4088 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4089
eb3f6f01 4090 * w32console.c: Include window.h.
61b108cc
SM
4091 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4092 New functions.
eb3f6f01
EZ
4093 (initialize_w32_display): Initialize mouse-highlight data.
4094
53a63be6
EZ
4095 * w32inevt.c: Include termchar.h and window.h.
4096 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4097 moves, call note_mouse_highlight. If help_echo changed, call
4098 gen_help_event to produce help-echo message in the echo area.
4099 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4100 highlight info.
4101
4cfd81f6
PE
41022012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4103
4104 * lread.c (read1): Simplify slightly to avoid an overflow warning
4105 with GCC 4.7.0 on x86-64.
4106
4446092a
EZ
41072012-05-26 Eli Zaretskii <eliz@gnu.org>
4108
4109 * bidi.c (bidi_mirror_char): Revert last change: an int is
4110 definitely wide enough here.
4111
42b2a986 41122012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4113
42b2a986 4114 Fix integer width and related bugs (Bug#9874).
eb106a49 4115 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4116 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4117 (string_bytes, check_sblock, allocate_string_data):
4118 (compact_small_strings, Fmake_bool_vector, make_string)
4119 (make_unibyte_string, make_multibyte_string)
4120 (make_string_from_bytes, make_specified_string)
4121 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4122 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4123 (mark_vectorlike):
4124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4125 (allocate_pseudovector):
4126 Use int, not EMACS_INT, where int is wide enough.
4127 (inhibit_garbage_collection, Fgarbage_collect):
4128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4129 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4130 int might not be wide enough.
4131 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4132 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4133 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4134 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4135 (bidi_level_of_next_char, bidi_move_to_visually_next):
4136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4137 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4138 (Fkill_buffer, Fset_buffer_major_mode)
4139 (advance_to_char_boundary, Fbuffer_swap_text)
4140 (Fset_buffer_multibyte, overlays_at, overlays_in)
4141 (overlay_touches_p, struct sortvec, record_overlay_string)
4142 (overlay_strings, recenter_overlay_lists)
4143 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4144 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4145 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4146 (Foverlay_recenter, last_overlay_modification_hooks_used)
4147 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4149 (validate_region): Omit unnecessary test for b <= e,
4150 since that's guaranteed by the previous test.
d311d28c
PE
4151 (adjust_overlays_for_delete): Avoid pos + length overflow.
4152 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4153 (report_overlay_modification):
4154 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4155 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4156 Omit pointer cast, which isn't needed anyway, and doesn't work
4157 after the EMACS_INT -> ptrdiff_t change.
02481186 4158 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4159 * buffer.h: Adjust decls to match defn changes elsewhere.
4160 (struct buffer_text, struct buffer):
4161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4162 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4163 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4164 not int, to avoid needless 32-bit limit on 64-bit hosts.
4165 (exec_byte_code): Use tighter memory-full test, one that checks
4166 for alloca overflow. Don't compute the address of the object just
4167 before an array, as that's not portable. Use EMACS_INT, not
4168 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4169 * callint.c (Fcall_interactively):
4170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4171 * callproc.c (call_process_kill, Fcall_process):
4172 Don't assume pid_t fits into an Emacs fixnum.
4173 (call_process_cleanup, Fcall_process, child_setup):
4174 Don't assume pid_t fits into int.
4175 (call_process_cleanup, Fcall_process, delete_temp_file)
4176 (Fcall_process_region):
4177 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4178 (Fcall_process): Simplify handling of volatile integers.
4179 Use int, not EMACS_INT, where int will do.
4180 * casefiddle.c (casify_object, casify_region, operate_on_word)
4181 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4183 (casify_object): Avoid integer overflow when overallocating buffer.
4184 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4185 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4186 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4187 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4188 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4189 integers are now checked earlier. All uses replaced with XINT.
4190 (ccl_driver):
4191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4192 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4193 (ccl_driver, Fregister_code_conversion_map):
4194 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4195 (resolve_symbol_ccl_program): Check that vector header is in range.
4196 Always copy the vector, so that we can check its contents reliably
4197 now rather than having to recheck each instruction as it's being
4198 executed. Check that vector words fit in 'int'.
4199 (ccl_get_compiled_code, Fregister_ccl_program)
4200 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4201 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4202 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4203 contents are in range.
4204 (Fccl_execute_on_string): Check that status is in range.
4205 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4206 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4207 Accept and return EMACS_INT, not int, because callers can pass values
4208 out of 'int' range.
4209 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4210 (multibyte_chars_in_text, parse_str_as_multibyte)
4211 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4212 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4213 (string_escape_byte8, Fget_byte):
4214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4215 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4216 avoid mishandling large integers.
4217 * character.h: Adjust decls to match defn changes elsewhere.
4218 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4219 (Ffind_charset_region):
4220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4221 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4222 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4223 Don't assume fixnum fits in int.
d311d28c
PE
4224 (load_charset_map_from_vector, Fmap_charset_chars):
4225 Remove now-unnecessary CHECK_NATNUMs.
4226 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4227 Don't rely on undefined behavior with signed left shift overflow.
4228 Don't assume unsigned int fits into fixnum, or that fixnum fits
4229 into unsigned int. Don't require max_code to be a valid fixnum;
4230 that's not true for gb10830 4-byte on a 32-bit host. Allow
4231 invalid_code to be a cons, for the same reason. Require code_offset
4232 to be a character. Avoid int overflow if max_char is close
4233 to INT_MAX.
4234 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4235 this is intended anyway and avoids some undefined behavior.
4236 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4237 INDEX_TO_CODE_POINT, as that's what it expects.
4238 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4239 * charset.h (DECODE_CHAR): Return int, not unsigned;
4240 this is what was intended anyway, and it avoids undefined behavior.
4241 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4242 integer-overflow issues.
4243 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4244 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4245 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4246 * chartab.c (Fmake_char_table, Fset_char_table_range)
4247 (uniprop_get_decoder, uniprop_get_encoder):
4248 Don't assume fixnum fits in int.
4249 * cmds.c (move_point): New function, that does the gist of
4250 Fforward_char and Fbackward_char, but does so while checking
4251 for integer overflow more accurately.
c96e5d6a 4252 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4253 (Fforward_line, Fend_of_line, internal_self_insert)
4254 (internal_self_insert):
4255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4256 Fix a FIXME, by checking for integer overflow when calculating
4257 target_clm and actual_clm.
4258 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4259 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4260 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4261 (coding_alloc_by_making_gap, alloc_destination)
4262 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4263 (encode_coding_utf_16, detect_coding_emacs_mule)
4264 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4265 (detect_coding_iso_2022, decode_coding_iso_2022)
4266 (encode_invocation_designation, encode_designation_at_bol)
4267 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4268 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4269 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4270 (encode_coding_ccl, encode_coding_raw_text)
4271 (detect_coding_charset, decode_coding_charset)
4272 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4273 (produce_composition, produce_charset, produce_annotation)
4274 (decode_coding, handle_composition_annotation)
4275 (handle_charset_annotation, consume_chars, decode_coding_gap)
4276 (decode_coding_object, encode_coding_object, detect_coding_system)
4277 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4278 (code_convert_region, code_convert_string)
8f50130c
PE
4279 (Fdefine_coding_system_internal)
4280 (coding_set_source, coding_set_destination):
d311d28c
PE
4281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4282 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4283 (Fdefine_coding_system_internal):
4284 Don't assume fixnums fit in int.
4285 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4286 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4287 (Funencodable_char_position, Fcheck_coding_systems_region)
4288 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4290 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4291 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4292 Don't access memory outside of the args array.
d311d28c 4293 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4294 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4295 result of ENCODE_CHAR.
d311d28c
PE
4296 * coding.h: Adjust decls to match defn changes elsewhere.
4297 (struct coding_system):
4298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4299 * composite.c (get_composition_id, find_composition)
4300 (run_composition_function, update_compositions)
4301 (compose_text, composition_gstring_put_cache)
4302 (composition_gstring_p, composition_gstring_width)
4303 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4304 (composition_compute_stop_pos, composition_reseat_it)
4305 (composition_update_it, struct position_record)
4306 (find_automatic_composition, composition_adjust_point)
4307 (Fcomposition_get_gstring, Ffind_composition_internal):
4308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4309 (update_compositions):
4310 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4311 * composite.h: Adjust decls to match defn changes elsewhere.
4312 (struct composition):
4313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4314 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4315 Do not attempt to compute the address of the object just before a
4316 buffer; this is not portable.
4317 (Faref, Faset):
4318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4319 (Faset): Use int, not EMACS_INT, where int is wide enough.
4320 (Fstring_to_number): Don't assume fixnums fit in int.
4321 (Frem): Don't assume arg is nonnegative.
4322 * dbusbind.c (xd_append_arg): Check for integers out of range.
4323 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4324 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4325 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4326 (xd_get_connection_references): Return ptrdiff_t, not int.
4327 All uses changed.
4328 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4329 (xd_read_message_1):
4330 Use int, not unsigned, where the dbus API uses int.
4331 (Fdbus_message_internal): Don't overflow mtype.
4332 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4333 * dired.c (directory_files_internal, file_name_completion, scmp)
4334 (file_name_completion_stat):
4335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4336 (file_name_completion): Don't overflow matchcount.
4337 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4338 * dispextern.h: Adjust decls to match defn changes elsewhere.
4339 (struct text_pos, struct glyph, struct bidi_saved_info)
4340 (struct bidi_string_data, struct bidi_it, struct composition_it)
4341 (struct it):
4342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4343 (struct display_pos, struct composition_it, struct it):
4344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4345 * dispnew.c (increment_matrix_positions)
4346 (increment_row_positions, mode_line_string)
4347 (marginal_area_string):
4348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4349 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4350 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4351 (duration_to_sec_usec): New function, to check for overflow better.
4352 (Fsleep_for, sit_for): Use it.
4353 * doc.c (get_doc_string, store_function_docstring):
4354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4355 (get_doc_string, Fsnarf_documentation):
4356 Use int, not EMACS_INT, where int is wide enough.
4357 (get_doc_string):
4358 Use SAFE_ALLOCA, not alloca.
4359 Check for overflow when converting EMACS_INT to off_t.
4360 * doprnt.c (doprnt):
4361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4362 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4363 Don't assume uid_t fits into fixnum.
4364 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4365 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4366 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4367 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4368 (general_insert_function)
4369 (Finsert_char, make_buffer_string, make_buffer_string_both)
4370 (update_buffer_properties, Fbuffer_substring)
4371 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4372 (Fsubst_char_in_region, check_translation)
4373 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4374 (transpose_markers, Ftranspose_regions):
4375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4376 (clip_to_bounds): Move to lisp.h as an inline function).
4377 (Fconstrain_to_field): Don't assume integers are nonnegative.
4378 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4379 (Fsubst_char_in_region, Fsave_restriction):
4380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4381 (Femacs_pid): Don't assume pid_t fits into fixnum.
4382 (lo_time): Use int, not EMACS_INT, when int suffices.
4383 (lisp_time_argument): Check for usec out of range.
4384 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4385 (Fuser_login_name, Fuser_full_name): Signal an error
4386 if a uid argument is out of range, rather than relying on
4387 undefined behavior.
c8d5c857
PE
4388 (Fformat_time_string): Remove now-unnecessary check.
4389 lisp_time_argument checks for out-of-range usec now.
243e0530 4390 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4391 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4392 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4393 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4394 (init_cmdargs, Fdump_emacs):
4395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4396 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4397 the bottom (typically) 32 bits of the fixnum.
4398 * eval.c (specpdl_size, call_debugger):
4399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4400 (when_entered_debugger, Fbacktrace_debug):
4401 Don't assume fixnum can fit in int.
4402 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4403 the object just before a buffer; this is not portable.
4404 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4405 (grow_specpdl, unbind_to):
4406 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4407 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4408 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4409 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4410 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4411 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4413 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4414 (a_write, e_write):
4415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4416 (Fcopy_file, non_regular_nbytes, read_non_regular)
4417 (Finsert_file_contents):
4418 Use int, not EMACS_INT, where int is wide enough.
4419 (READ_BUF_SIZE): Verify that it fits in int.
4420 (Finsert_file_contents): Check that counts are in proper range,
4421 rather than assuming fixnums fit into ptrdiff_t etc.
4422 Don't assume fixnums fit into int.
125b3835 4423 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4424 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4425 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4426 (string_char_to_byte, string_byte_to_char)
4427 (string_make_multibyte, string_to_multibyte)
4428 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4429 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4430 (substring_both, Fdelete, internal_equal, Ffillarray)
4431 (Fclear_string, mapcar1)
4432 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4433 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4434 (larger_vector, make_hash_table, maybe_resize_hash_table)
4435 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4436 (Fmaphash, secure_hash):
4437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4438 (concat): Check for string index and length overflow.
4439 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4440 (Frequire):
4441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4442 (larger_vector): New API (vec, incr_min, size_max) replaces old
4443 one (vec, new_size, init). This catches size overflow.
4444 INIT was removed because it was always Qnil.
4445 All callers changed.
4446 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4447 the upper bound on a hash table index size.
4448 (make_hash_table, maybe_resize_hash_table): Use it.
4449 (secure_hash): Computer start_byte and end_byte only after
4450 they're known to be in ptrdiff_t range.
4451 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4452 (Ffont_get_glyphs, Ffont_at):
4453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4454 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4455 (Flist_fonts, Fopen_font):
4456 Don't assume fixnum can fit in int.
4457 (check_gstring): Don't assume index can fit in int.
4458 (font_match_p): Check that fixnum is a character, not a nonnegative
4459 fixnum, since the later code needs to stuff it into an int.
4460 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4461 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4462 conversion overflow issues.
4463 (Fopen_font): Check for integer out of range.
4464 (Ffont_get_glyphs): Don't assume index can fit in int.
4465 * font.h: Adjust decls to match defn changes elsewhere.
4466 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4467 integer overflow.
4468 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4469 printmax_t, where ptrdiff_t is wide enough.
4470 (Finternal_char_font):
4471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4472 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4473 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4474 (Fset_frame_position, x_set_frame_parameters)
4475 (x_set_line_spacing, x_set_border_width)
4476 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4477 Check that fixnums are in proper range for system types.
4478 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4480 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4481 Use SAFE_ALLOCA_LISP, not alloca.
4482 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4483 intptr_t is wide enough.
4484 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4485 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4486 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4487 Check for fixnum out of range.
4488 * ftfont.c (ftfont_list): Don't assume index fits in int.
4489 Check that fixnums are in proper range for system types.
4490 (ftfont_shape_by_flt):
4491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4492 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4494 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4495 Check that fixnums are in proper range for system types.
4496 * gnutls.h: Adjust decls to match defn changes elsewhere.
4497 * gtkutil.c (xg_dialog_run):
4498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4499 (update_frame_tool_bar):
4500 Check that fixnums are in proper range for system types.
4501 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4502 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4503 * indent.c (last_known_column, last_known_column_point):
4504 (current_column_bol_cache):
4505 (skip_invisible, current_column, check_display_width):
4506 (check_display_width, scan_for_column, current_column_1)
4507 (Findent_to, Fcurrent_indentation, position_indentation)
4508 (indented_beyond_p, Fmove_to_column, compute_motion):
4509 (Fcompute_motion, Fvertical_motion):
4510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4511 (last_known_column_modified): Use EMACS_INT, not int.
4512 (check_display_width):
4513 (Fcompute_motion):
4514 Check that fixnums and floats are in proper range for system types.
4515 (compute_motion): Don't assume index or fixnum fits in int.
4516 (compute_motion, Fcompute_motion):
4517 Use int, not EMACS_INT, when it is wide enough.
4518 (vmotion): Omit local var start_hpos that is always 0; that way
4519 we don't need to worry about overflow in expressions involving it.
4520 * indent.h: Adjust decls to match defn changes elsewhere.
4521 (struct position):
4522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4523 Use int, not EMACS_INT, where int is wide enough.
4524 Remove unused members ovstring_chars_done and tab_offset;
4525 all uses removed.
4526 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4527 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4528 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4529 (make_gap, copy_text, insert, insert_and_inherit)
4530 (insert_before_markers, insert_before_markers_and_inherit)
4531 (insert_1, count_combining_before, count_combining_after)
4532 (insert_1_both, insert_from_string)
4533 (insert_from_string_before_markers, insert_from_string_1)
4534 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4535 (adjust_after_replace, adjust_after_insert, replace_range)
4536 (replace_range_2, del_range, del_range_1, del_range_byte)
4537 (del_range_both, del_range_2, modify_region)
4538 (prepare_to_modify_buffer, signal_before_change)
4539 (signal_after_change, Fcombine_after_change_execute):
4540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4541 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4542 (balance_an_interval, split_interval_right, split_interval_left)
4543 (find_interval, next_interval, update_interval)
4544 (adjust_intervals_for_insertion, delete_node, delete_interval)
4545 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4546 (static_offset_intervals, offset_intervals)
4547 (merge_interval_right, merge_interval_left, make_new_interval)
4548 (graft_intervals_into_buffer, temp_set_point_both)
4549 (temp_set_point, set_point, adjust_for_invis_intang)
4550 (set_point_both, move_if_not_intangible, get_property_and_range)
4551 (get_local_map, copy_intervals, copy_intervals_to_string)
4552 (compare_string_intervals, set_intervals_multibyte_1):
4553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4554 * intervals.h: Adjust decls to match defn changes elsewhere.
4555 (struct interval):
4556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4557 * keyboard.c (this_command_key_count, this_single_command_key_start)
4558 (before_command_key_count, before_command_echo_length, echo_now)
4559 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4560 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4561 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4562 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4564 (last_non_minibuf_size, last_point_position, echo_truncate)
4565 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4566 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4567 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4568 (stuff_buffered_input):
4569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4570 (last_auto_save, command_loop_1, read_char):
4571 Use EMACS_INT, not int, to avoid integer overflow.
4572 (record_char): Avoid overflow in total_keys computation.
4573 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4574 * keyboard.h: Adjust decls to match defn changes elsewhere.
4575 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4576 (Fkey_description, Fdescribe_vector, Flookup_key):
4577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4578 (click_position): New function, to check that positions are in range.
4579 (Fcurrent_active_maps):
4580 (describe_command):
4581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4582 (Faccessible_keymaps, Fkey_description):
4583 (preferred_sequence_p):
4584 Don't assume fixnum can fit into int.
4585 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4586 Check for integer overflow in size calculations.
4587 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4588 avoid mishandling large integers.
4589 * lisp.h: Adjust decls to match defn changes elsewhere.
4590 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4591 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4592 (struct Lisp_Marker):
4593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4594 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4595 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4596 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4597 All callers changed.
4598 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4599 Assume the arg has valid form, since it always does.
4600 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4601 unsigned integer system type.
4602 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4603 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4604 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4605 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4606 (duration_to_sec_usec): New decl.
4607 * lread.c (read_from_string_index, read_from_string_index_byte)
4608 (read_from_string_limit, readchar, unreadchar, openp)
4609 (read_internal_start, read1, oblookup):
4610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4611 (Fload, readevalloop, Feval_buffer, Feval_region):
4612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4613 (openp): Check for out-of-range argument to 'access'.
4614 (read1): Use int, not EMACS_INT, where int is wide enough.
4615 Don't assume fixnum fits into int.
6efdadfd 4616 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4617 (read_filtered_event): Use duration_to_sec_usec
4618 to do proper overflow checking on durations.
d311d28c
PE
4619 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4620 in size calculation.
4621 (Fexecute_kbd_macro):
4622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4623 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4624 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4625 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4626 (set_marker_both, set_marker_restricted_both, marker_position)
4627 (marker_byte_position, Fbuffer_has_markers_at):
4628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4629 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4630 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4631 It now merely ensures that the menu is large enough, without
4632 necessarily growing it, as this avoids some integer overflow issues.
4633 All callers changed.
4634 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4636 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4637 Use SAFE_ALLOCA_LISP, not alloca.
4638 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4639 to EMACS_INT. Check that fixnums are in proper range for system types.
4640 * minibuf.c (minibuf_prompt_width, string_to_object)
4641 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4642 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4644 (get_minibuffer, read_minibuf_unwind):
4645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4646 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4647 this simplifies overflow checking. All callers changed.
4648 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4649 (Ftest_completion):
4650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4651 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4652 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4653 Check that fixnums are in proper range for system types.
4654 (Fx_create_frame, Fx_show_tip):
4655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4656 * nsfont.m (ns_findfonts, nsfont_list_family):
4657 Don't assume fixnum fits in long.
4658 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4660 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4661 wide enough.
17fdb222 4662 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4664 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4665 (PRINTDECLARE, PRINTPREPARE):
4666 (strout, print_string):
4667 (print, print_preprocess, print_check_string_charset_prop)
4668 (print_object):
4669 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4670 (PRINTDECLARE):
4671 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4673 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4674 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4675 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4676 (print_error_message): Use SAFE_ALLOCA, not alloca.
4677 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4678 (print_depth, new_backquote_output, print_number_index):
4679 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4680 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4681 (Fset_process_window_size, Fformat_network_address)
4682 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4683 (sigchld_handler):
d311d28c 4684 Check that fixnums are in proper range for system types.
d44287d4 4685 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4686 Check for process-ids out of pid_t range rather than relying on
4687 undefined behavior.
e4d81efc 4688 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4689 (Fformat_network_address, read_process_output, send_process)
4690 (Fprocess_send_region, status_notify):
4691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4692 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4693 (wait_reading_process_output, read_process_output, exec_sentinel):
4694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4695 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4696 (Faccept_process_output): Use duration_to_sec_usec to do proper
4697 overflow checking on durations.
dde14581
PE
4698 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4699 Don't assume pid_t fits in int.
02481186
PE
4700 * process.h (struct Lisp_Process): Members tick and update_tick
4701 are now of type EMACS_INT, not int.
b62b53e8
PE
4702 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4703 configured --with-wide-int.
d311d28c
PE
4704 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4705 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4706 * search.c (looking_at_1, string_match_1):
4707 (fast_string_match, fast_c_string_match_ignore_case)
4708 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4709 (scan_newline, find_before_next_newline, search_command)
4710 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4711 (set_search_regs, wordify):
4712 (Freplace_match):
4713 (Fmatch_data):
4714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4715 (string_match_1, search_buffer, set_search_regs):
4716 (Fmatch_data):
4717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4718 (wordify): Check for overflow in size calculation.
4719 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4720 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4721 Check that fixnums are in proper range for system types.
4722 * sound.c (struct sound_device)
4723 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4725 (Fplay_sound_internal):
4726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4727 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4728 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4729 (Fparse_partial_sexp):
4730 Don't assume fixnums can fit in int.
4731 (struct lisp_parse_state, find_start_pos, find_start_value)
4732 (find_start_value_byte, find_start_begv)
4733 (update_syntax_table, char_quoted, dec_bytepos)
4734 (find_defun_start, prev_char_comend_first, back_comment):
4735 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4736 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4738 (Finternal_describe_syntax_value): Check that match_lisp is a
4739 character, not an integer, since the code stuffs it into int.
4740 (scan_words, scan_sexps_forward):
4741 Check that fixnums are in proper range for system types.
4742 (Fforward_word):
4743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4744 (scan_sexps_forward):
4745 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4746 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4747 * syntax.h: Adjust decls to match defn changes elsewhere.
4748 (struct gl_state_s):
4749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4750 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4751 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4752 * sysdep.c (wait_for_termination_1, wait_for_termination)
4753 (interruptible_wait_for_termination, mkdir):
4754 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4755 (emacs_read, emacs_write):
4756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4757 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4758 and double all fit in int.
d311d28c
PE
4759 * term.c (set_tty_color_mode):
4760 Check that fixnums are in proper range for system types.
4761 * termhooks.h (struct input_event):
4762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4763 * textprop.c (validate_interval_range, interval_of)
4764 (Fadd_text_properties, set_text_properties_1)
4765 (Fremove_text_properties, Fremove_list_of_text_properties)
4766 (Ftext_property_any, Ftext_property_not_all)
4767 (copy_text_properties, text_property_list, extend_property_ranges)
4768 (verify_interval_modification):
4769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4770 (Fnext_single_char_property_change)
4771 (Fprevious_single_char_property_change):
4772 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4773 (copy_text_properties):
4774 Check for integer overflow in index calculation.
d311d28c
PE
4775 * undo.c (last_boundary_position, record_point, record_insert)
4776 (record_delete, record_marker_adjustment, record_change)
4777 (record_property_change):
4778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4779 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4781 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4782 (Fx_hide_tip, Fx_file_dialog):
4783 * w32menu.c (set_frame_menubar):
4784 Use ptrdiff_t, not int, for consistency with rest of code.
4785 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4786 (select_window, Fdelete_other_windows_internal)
4787 (window_scroll_pixel_based, window_scroll_line_based)
4788 (Frecenter, Fset_window_configuration):
4789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4790 (Fset_window_hscroll, run_window_configuration_change_hook)
4791 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4792 (Fscroll_other_window, Frecenter):
d311d28c
PE
4793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4794 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4795 Don't assume fixnum fits in int.
4796 (Fset_window_scroll_bars):
4797 Check that fixnums are in proper range for system types.
4798 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4799 (string_pos, c_string_pos, number_of_chars, init_iterator)
4800 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4801 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4802 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4803 (face_before_or_after_it_pos, handle_invisible_prop)
4804 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4805 (display_prop_intangible_p, string_buffer_position_lim)
4806 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4807 (get_overlay_strings_1, get_overlay_strings)
4808 (iterate_out_of_display_property, forward_to_next_line_start)
4809 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4810 (get_next_display_element, set_iterator_to_next)
4811 (get_visually_first_element, compute_stop_pos_backwards)
4812 (handle_stop_backwards, next_element_from_buffer)
4813 (move_it_in_display_line_to, move_it_in_display_line)
4814 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4815 (add_to_log, message_dolog, message_log_check_duplicate)
4816 (message2, message2_nolog, message3, message3_nolog
4817 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4818 (current_message_1, truncate_echo_area, truncate_message_1)
4819 (set_message, set_message_1, store_mode_line_noprop)
4820 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4821 (text_outside_line_unchanged_p, check_point_in_composition)
4822 (reconsider_clip_changes)
4823 (redisplay_internal, set_cursor_from_row, try_scrolling)
4824 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4825 (redisplay_window, find_last_unchanged_at_beg_row)
4826 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4827 (trailing_whitespace_p, find_row_edges, display_line)
4828 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4829 (display_mode_element, store_mode_line_string)
4830 (pint2str, pint2hrstr, decode_mode_spec)
4831 (display_count_lines, display_string, draw_glyphs)
4832 (x_produce_glyphs, x_insert_glyphs)
4833 (rows_from_pos_range, mouse_face_from_buffer_pos)
4834 (fast_find_string_pos, mouse_face_from_string_pos)
4835 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4837 (safe_call, init_from_display_pos, handle_fontified_prop)
4838 (handle_single_display_spec, load_overlay_strings)
4839 (with_echo_area_buffer, setup_echo_area_for_printing)
4840 (display_echo_area, echo_area_display)
4841 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4842 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4843 (redisplay_window, dump_glyph_row, display_mode_line)
4844 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4845 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4847 (handle_single_display_spec, build_desired_tool_bar_string)
4848 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4849 (get_specified_cursor_type):
4850 Check that fixnums are in proper range for system types.
4851 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4852 (Flookup_image_map):
4853 Don't assume fixnums fit in int.
4854 (compare_overlay_entries):
4855 Avoid mishandling comparisons due to subtraction overflow.
4856 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4857 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4858 (handle_tool_bar_click):
4859 Use int, not unsigned, since we prefer signed and the signedness
4860 doesn't matter here.
4861 (get_next_display_element, next_element_from_display_vector):
4862 Use int, not EMACS_INT, when int is wide enough.
4863 (start_hourglass): Use duration_to_sec_usec to do proper
4864 overflow checking on durations.
4865 * xfaces.c (Fbitmap_spec_p):
4866 Check that fixnums are in proper range for system types.
4867 (compare_fonts_by_sort_order):
4868 Avoid mishandling comparisons due to subtraction overflow.
4869 (Fx_family_fonts, realize_basic_faces):
4870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4871 (Fx_family_fonts):
4872 Don't assume fixnum fits in int.
4873 Use SAFE_ALLOCA_LISP, not alloca.
4874 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4875 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4876 (face_at_buffer_position, face_for_overlay_string)
4877 (face_at_string_position):
4878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4879 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4880 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4881 (Fx_show_tip):
4882 Check that fixnums are in proper range for system types.
4883 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4884 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4886 (Fx_change_window_property): Don't assume fixnums fit in int.
4887 * xfont.c (xfont_chars_supported):
4888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4889 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4890 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4892 * xml.c (parse_region):
4893 * xrdb.c (magic_file_p):
4894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4895 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4896 (x_get_local_selection, x_reply_selection_request)
4897 (x_handle_selection_request, wait_for_property_change):
4898 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4899 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4900 short is wide enough.
4901 (x_send_client_event): Don't assume fixnum fits in int.
4902 * xterm.c (x_x_to_emacs_modifiers):
4903 Don't assume EMACS_INT overflows nicely into int.
4904 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4905 may come from Lisp.
4906 (handle_one_xevent): NATNUMP can eval its arg twice.
4907 (x_connection_closed):
4908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4909 * xterm.h: Adjust decls to match defn changes elsewhere.
4910 (struct scroll_bar): Use struct vectorlike_header
4911 rather than rolling our own approximation.
4912 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4913
c6574eb5
GM
49142012-05-25 Glenn Morris <rgm@gnu.org>
4915
4916 * lisp.mk (lisp): Update for more files being compiled now.
4917
e8d32c7e
SM
49182012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4919
48def666
SM
4920 * lread.c: Remove `read_pure' which makes no difference.
4921 (read_pure): Remove var.
4922 (unreadpure): Remove function.
4923 (readevalloop): Don't call read_list with -1 flag.
4924 (read1, read_vector): Don't test read_pure any more.
4925 (read_list): Simplify.
4926
e8d32c7e
SM
4927 * fileio.c, character.h: Minor style tweaks.
4928
4b2addb7
DA
49292012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4930
4931 * window.h (clip_changed): Remove useless declaration.
4932
584461b2
JB
49332012-05-22 Juanma Barranquero <lekktu@gmail.com>
4934
4935 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4936 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4937
34374650
PE
49382012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4939
4940 Remove src/m/*.
4941 This directory predates autoconf and is no longer needed nowadays.
4942 Move its few remaining bits of functionality to where they're needed.
4943 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4944 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4945 * m/template.h: Remove.
4946 * Makefile.in (M_FILE): Remove. All uses removed.
4947 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4948 * lisp.h (USE_LSB_TAG):
4949 * mem-limits.h (EXCEEDS_LISP_PTR):
4950 Use VAL_MAX, not VALBITS, in #if.
4951 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4952 (EMACS_UINT): Define unconditionally now.
4953 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4954 (BITS_PER_EMACS_INT): New constants, replacing
4955 what used to be in config.h, but not useful in #if.
4956 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4957 define them any more.
4958 (VAL_MAX): New macro.
4959 (VALMASK): Use it.
4960 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4961 BITS_PER_EMACS_INT, in #if.
4962 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4963 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4964 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4965 * s/ms-w32.h (DATA_START):
4966 Move here from removed file m/intel386.h.
4967 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4968 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4969
261cb4bb
PE
49702012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4971
4972 Assume C89 or later.
4973 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4974 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4975 (xrealloc):
4976 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4977 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4978 * textprop.c, tparam.c (NULL): Remove.
4979 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4980 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4981 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4982 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4983 * xterm.c (input_signal_count): Assume volatile works.
4984
ff23cd9f
KB
49852012-05-21 Ken Brown <kbrown@cornell.edu>
4986
4987 * xgselect.c (xg_select): Fix first argument in call to 'select'
4988 (bug#11508).
4989
1b170bc6
KB
49902012-05-20 Ken Brown <kbrown@cornell.edu>
4991
4992 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4993 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4994
b2f4d39f
KB
49952012-05-19 Ken Brown <kbrown@cornell.edu>
4996
4997 * xfns.c (x_in_use): Remove `static' qualifier.
4998 * xterm.h (x_in_use): Declare.
4999 * xgselect.c: Include xterm.h.
5000 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5001 and `display_arg' (bug#9754).
5002
003fdae2
PE
50032012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5004
9232a6d9
PE
5005 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5006
003fdae2
PE
5007 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5008 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5009
784b56e2
EZ
50102012-05-18 Eli Zaretskii <eliz@gnu.org>
5011
5012 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5013
5014 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5015 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5016
5017 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5018 reference to image_cache->refcount.
5019 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5020
a0a79cde
JL
50212012-05-17 Juri Linkov <juri@jurta.org>
5022
5023 * search.c (Fword_search_regexp, Fword_search_backward)
5024 (Fword_search_forward, Fword_search_backward_lax)
5025 (Fword_search_forward_lax): Move functions to isearch.el
5026 (bug#10145, bug#11381).
5027
b0572523
PE
50282012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5029
5030 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5031
9660f5fc
SM
50322012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5033
5034 * lread.c (init_obarray): Declare Qt and Qnil as special.
5035
4374de83
GM
50362012-05-14 Glenn Morris <rgm@gnu.org>
5037
5038 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5039 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5040
dc44c39a
PE
50412012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5042
078c97cb
PE
5043 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5044
dc44c39a
PE
5045 * unexaix.c: Port to more-recent AIX compilers.
5046 (report_error, report_error_1, make_hdr, copy_sym)
5047 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5048 Make arguments const char *, not char *, to avoid violations of C
5049 standard and to fix some AIX warnings reported by Gilles Pion.
5050
e18afed7 50512012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5052
5053 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5054 already have overlays loaded.
5055 (handle_single_display_spec): Before returning without displaying
5056 fringe bitmap, synchronize the bidi iterator with the main display
5057 iterator, by calling iterate_out_of_display_property.
5058 (iterate_out_of_display_property): Detect buffer iteration by
5059 testing that it->string is a Lisp string.
5060 (get_next_display_element): When the current object is exhausted,
5061 and there's something on it->stack, call set_iterator_to_next to
5062 proceed with what's on the stack, instead of returning zero.
5063 (set_iterator_to_next): If called at the end of a Lisp string,
5064 proceed to consider_string_end without incrementing string
5065 position. Don't increment display vector index past the end of
5066 the display vector. (Bug#11417)
c8fb9dc6
EZ
5067 (pos_visible_p): Don't report a position visible when move_it_to
5068 stopped at the last line of window, which happens to be scanned
5069 backwards by the bidi iteration. (Bug#11464)
ac268e67 5070
e18afed7 50712012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5072
5073 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5074 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5075 are on a TTY, and thus unable to display on the fringes.
5076 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5077 so we need to signal to the caller that this is a "replacing"
5078 display spec. This fixes display when the spec is invalid or we
5079 are on a TTY.
5080
e18afed7 50812012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5082
5083 * unexaix.c (make_hdr): Fix typo in prototype.
5084 This bug broke the build on AIX. Problem reported by Gilles Pion.
5085
9d0a235a
MA
50862012-05-14 Michael Albinus <michael.albinus@gmx.de>
5087
5088 * keyboard.c (kbd_buffer_get_event): Read special events also in
5089 batch mode. (Bug#11415)
5090
9e6b06ed
GM
50912012-05-12 Glenn Morris <rgm@gnu.org>
5092
5093 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5094
c1a1d7a3
EZ
50952012-05-12 Eli Zaretskii <eliz@gnu.org>
5096
5097 * lisp.mk (lisp): Add newcomment.elc.
5098
3fe7cdc8
GM
50992012-05-12 Glenn Morris <rgm@gnu.org>
5100
5101 * Makefile.in (MKDIR_P): New, set by configure.
5102 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5103
53f7d2c0
PE
51042012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5105
5106 Remove unused function hourglass_started.
5107 * dispextern.h (hourglass_started):
5108 * w32fns.c (hourglass_started):
5109 * xdisp.c (hourglass_started): Remove.
5110
75aafb17
JB
51112012-05-10 Juanma Barranquero <lekktu@gmail.com>
5112
5113 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5114 Update dependencies.
5115
12959e8e
PE
51162012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5117
97107e2e
PE
5118 * xgselect.c (xg_select): Put maxfds+1 into a var.
5119 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5120
12959e8e
PE
5121 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5122
836d29b3
DA
51232012-05-10 Dave Abrahams <dave@boostpro.com>
5124
5125 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5126 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5127
5cb67954
MA
51282012-05-09 Michael Albinus <michael.albinus@gmx.de>
5129
5130 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5131 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5132 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5133 Initialize xd_registered_buses.
5134
3478ec45
PE
51352012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5136
b263a6b0
PE
5137 Untag more efficiently if USE_LSB_TAG.
5138 This is based on a proposal by YAMAMOTO Mitsuharu in
5139 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5140 For an admittedly artificial (nth 8000 longlist) benchmark on
5141 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5142 Emacs's overall text size by 1%.
5143 * lisp.h (XUNTAG): New macro.
5144 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5145 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5146 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5147 * eval.c (Fautoload):
5148 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5149 * frame.h (XFRAME): Use XUNTAG.
5150
3478ec45
PE
5151 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5152 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5153 Remove unportable assumptions about print widths of types like
5154 dbus_uint32_t.
5155 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5156 intptr_t when converting between pointer and integer, to avoid GCC
5157 warnings about wrong width.
5158
666b903b 51592012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5160
5161 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5162 stack for each reader_thread, instead of defaulting to 8MB
5163 determined by the linker. This avoids failures in creating
5164 subprocesses on Windows 7, see the discussion in this thread:
5165 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5166
b120cc17
JC
51672012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5168
5169 Fix up display of the *Minibuf-0* buffer in the mini window.
5170 * keyboard.c (read_char): Don't clear the echo area if there's no
5171 message to clear.
5172 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5173 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5174
9a4b36f8
MA
51752012-05-07 Michael Albinus <michael.albinus@gmx.de>
5176
5177 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5178 batch mode.
5179
e5f9458f
CY
51802012-05-06 Chong Yidong <cyd@gnu.org>
5181
5182 * lisp.mk (lisp): Update.
5183
eceeb5fc 51842012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5185
5186 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5187
71873e2b
SM
51882012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5189
5190 * data.c (PUT_ERROR): New macro.
5191 (syms_of_data): Use it. Add new error type `user-error'.
5192 * undo.c (user_error): New function.
5193 (Fprimitive_undo): Use it.
5194 * print.c (print_error_message): Adjust print style for `user-error'.
5195 * keyboard.c (user_error): New function.
5196 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5197
ab0fa4e4
PE
51982012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5199
5200 Do not limit current-time-string to years 1000..9999.
5201 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5202 (Fcurrent_time_string): Support any year that is supported by the
5203 underlying localtime representation. Don't use asctime, as it
5204 has undefined behavior for years outside the range -999..9999.
5205
7ed806a7
PE
52062012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5207
5208 Fix race conditions involving setenv, gmtime, localtime, asctime.
5209 Without this fix, interrupts could mess up code that uses these
5210 nonreentrant functions, since setting TZ invalidates existing
5211 tm_zone or tzname values, and since most of these functions return
5212 pointers to static storage.
5213 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5214 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5215 Grow the critical sections to include not just invoking
5216 localtime/gmtime, but also accessing these functions' results
5217 including their tm_zone values if any, and any related TZ setting.
5218 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5219 so that the struct tm is saved in the critical section.
5220 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5221 motivated by the fact that memory allocation needs to be outside
5222 the critical section.
5223
0c16dfed
DA
52242012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5225
5226 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5227 with RESET_INTERVAL.
5228
5229 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5230 Remove duplicated buffer name initialization.
5231
3f83ace8
JM
52322012-05-02 Jim Meyering <jim@meyering.net>
5233
5234 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5235
c7b8541e
JM
5236 * xfns.c (x_window): Use xstrdup (Bug#11375).
5237
90207a15 52382012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5239
5240 * xdisp.c (pos_visible_p): If already at a newline from the
5241 display string before the 'while' loop, don't walk back the glyphs
5242 from it3.glyph_row. Solves assertion violation when the display
5243 string begins with a newline (egg.el). (Bug#11367)
5244
b593d6a9
AH
52452012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5246
5247 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5248 Move to simple.el.
5249
4737362e
GM
52502012-05-01 Glenn Morris <rgm@gnu.org>
5251
99cf43f9
GM
5252 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5253 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5254 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5255 All were removed before 23.1.
5256
9311dcff
GM
5257 * dispnew.c: Remove HAVE_LIBNCURSES test;
5258 it is always true on relevant platforms.
5259
4d5c6349
GM
5260 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5261 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5262
4737362e
GM
5263 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5264
74dd3a6b
AS
52652012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5266
5267 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5268 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5269 Remove.
5270
13c379ee
PE
52712012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5272
5273 Do not avoid creating empty evaporating overlays (Bug#9642).
5274 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5275 That is, do not delete an evaporating overlay if it becomes
5276 empty after its bounds are adjusted to fit within its buffer.
5277 This fix caused other problems, and I'm reverting it until we get
5278 to the bottom of them.
5279
a8e7d6d7 52802012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5281
5282 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5283
a8e7d6d7 52842012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5285
5286 * xdisp.c (pos_visible_p): If the window start position is beyond
5287 ZV, start the display from buffer beginning. Prevents assertion
5288 violation in init_iterator when the minibuffer window is scrolled
5289 via the scroll bar.
5290
5291 * window.c (window_scroll_pixel_based): Likewise.
5292
a8e7d6d7 52932012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5294
5295 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5296
a8e7d6d7 52972012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5298
5299 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5300 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5301
a8e7d6d7 53022012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5303
b593d6a9
AH
5304 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5305 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5306
1c6900d9
EZ
53072012-04-26 Eli Zaretskii <eliz@gnu.org>
5308
4c3fa1d9
EZ
5309 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5310 display element, check also the underlying string or buffer
5311 character. (Bug#11341)
5312
1c6900d9
EZ
5313 * w32menu.c: Include w32heap.h.
5314 (add_menu_item): If the call to AppendMenuW (via
5315 unicode_append_menu) fails, disable Unicode menus only if we are
5316 running on Windows 9X/Me.
5317
42bf8205
AS
53182012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5319
5320 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5321 (xgetint): Add missing shift for LSB tags.
5322
b1bac16e
MR
53232012-04-24 Martin Rudalics <rudalics@gmx.at>
5324
5325 * keyboard.c (read_char): Don't wipe echo area for select window
5326 events: These might get delayed via `mouse-autoselect-window'
5327 (Bug#11304).
5328
d69621cc
JB
53292012-04-24 Juanma Barranquero <lekktu@gmail.com>
5330
5331 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5332 manipulation of :loaded-from data.
5333
02fd101b
JB
53342012-04-23 Juanma Barranquero <lekktu@gmail.com>
5335
5336 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5337 now a cons (bug#11311).
5338
888bec30
PE
53392012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5340
89a438bd
PE
5341 Do not create empty overlays with the evaporate property (Bug#9642).
5342 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5343 if it becomes empty after its bounds are adjusted to fit within
5344 its buffer. Without this fix, in a nonempty buffer (let ((o
5345 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5346 yields an empty overlay that has the evaporate property, which is
5347 not supposed to happen.
5348
1068fe4d
PE
5349 Fix minor GTK3 problems found by static checking.
5350 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5351 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5352 (struct _EmacsFixedClass, emacs_fixed_get_type):
5353 Move decls here from emacsgtkfixed.h, since they needn't be public.
5354 (emacs_fixed_get_type): Now static.
5355 (emacs_fixed_class_init): Omit unused local.
5356 (emacs_fixed_child_type): Remove; unused.
5357 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5358 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5359 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5360 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5361 (EMACS_FIXED_GET_CLASS): Remove; unused.
5362 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5363
888bec30
PE
5364 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5365 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5366
de85e130
PE
53672012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5368
d0baac98 5369 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5370 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5371 (__malloc_size_t, __malloc_ptrdiff_t):
5372 Remove. All uses removed, replaced by the definiens if needed,
5373 since we can assume C89 or better now.
5374 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5375 (protect_malloc_state, align, get_contiguous_space)
5376 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5377 (malloc_atfork_handler_child, malloc_enable_thread)
5378 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5379 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5380 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5381 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5382 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5383 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5384 Define using prototypes, not old style.
5385 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5386 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5387 (align): Don't assume that signed integer overflow wraps around.
5388 Omit unused local var.
5389 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5390 (_free_internal_nolock, memalign, mallochook, reallochook):
5391 Omit no-longer-needed casts.
5392 (valloc): Use getpagesize, not __getpagesize.
5393 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5394 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5395
de85e130
PE
5396 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5397
dcbf5805
MA
53982012-04-22 Michael Albinus <michael.albinus@gmx.de>
5399
5400 Move functions from C to Lisp. Make non-blocking method calls
5401 the default. Implement further D-Bus standard interfaces.
5402
5403 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5404 (QCdbus_request_name_allow_replacement)
5405 (QCdbus_request_name_replace_existing)
5406 (QCdbus_request_name_do_not_queue)
5407 (QCdbus_request_name_reply_primary_owner)
5408 (QCdbus_request_name_reply_in_queue)
5409 (QCdbus_request_name_reply_exists)
5410 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5411 (QCdbus_registered_serial, QCdbus_registered_method)
5412 (QCdbus_registered_signal): New Lisp objects.
5413 (XD_DEBUG_MESSAGE): Use sizeof.
5414 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5415 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5416 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5417 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5418 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5419 (xd_signature, xd_append_arg): Allow float for integer types.
5420 (xd_get_connection_references): New function.
b593d6a9
AH
5421 (xd_get_connection_address): Rename from xd_initialize.
5422 Return cached address.
dcbf5805
MA
5423 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5424 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5425 level.
5426 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5427 Return number of refcounts.
dcbf5805
MA
5428 (Fdbus_get_unique_name): Make stronger parameter check.
5429 (Fdbus_message_internal): New defun.
5430 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5431 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5432 (Fdbus_send_signal, Fdbus_register_service)
5433 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5434 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5435 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5436 (Vdbus_compiled_version, Vdbus_runtime_version)
5437 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5438 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5439 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5440 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5441 Adapt docstring.
dcbf5805 5442
52828e02
PE
54432012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5444
da05bc4c
PE
5445 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5446 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5447 Do not assume ptrdiff_t is the same width as 'int'.
5448
52828e02
PE
5449 * alloc.c: Handle unusual debugging option combinations.
5450 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5451 since the two debugging options are incompatible.
5452 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5453 is defined.
5454 (mem_init, mem_insert, mem_insert_fixup):
5455 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5456 (NEED_MEM_INSERT): Remove; no longer needed.
5457
f01769f9
LL
54582012-04-22 Leo Liu <sdl.web@gmail.com>
5459
5460 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5461
5790543d
PE
54622012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5463
5464 * sysdep.c [__FreeBSD__]: Minor cleanups.
5465 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5466 Use Emacs indenting style more consistently. Avoid some casts.
5467 Use 'double' consistently rather than mixing 'float' and 'double'.
5468
b91b7e4d
EW
54692012-04-21 Eduard Wiebe <usenet@pusto.de>
5470
b593d6a9
AH
5471 * sysdep.c (list_system_processes, system_process_attributes):
5472 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5473
6114eb15
AS
54742012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5475
5476 * lisp.mk (lisp): Update.
5477
2f38dff7
PE
54782012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5479
5480 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5481 It is never used otherwise.
5482
4ae29f89
SM
54832012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5484
5485 * print.c (print_preprocess): Only check print_depth if print-circle
5486 is nil.
5487 (print_object): Check for cycles even when print-circle is nil and
5488 print-gensym is t, but only check print_depth if print-circle is nil.
5489
f30d612a
CY
54902012-04-20 Chong Yidong <cyd@gnu.org>
5491
5492 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5493 set the status to "failed" and ensure that sentinel is run.
5494
c07a4c0b 54952012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5496
5497 * process.c (Fset_process_inherit_coding_system_flag)
5498 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5499 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5500
c07a4c0b 55012012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5502
5503 * xdisp.c (string_buffer_position_lim): Limit starting position to
5504 BEGV.
5505 (set_cursor_from_row): If called for a mode-line or header-line
5506 row, return zero immediately.
5507 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5508 farther than the first row after the header line, if any.
5509 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5510 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5511
c07a4c0b 55122012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5513
4ae29f89
SM
5514 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5515 (bug#11238).
ad3a2b41 5516
c07a4c0b 55172012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 55182012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5519
5520 configure: new option --enable-gcc-warnings (Bug#11207)
5521 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5522 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5523 (ALL_CFLAGS): Use new macros rather than old.
5524 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5525 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5526 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5527 -Wunused-result, -Wunused-variable. This should go away once
5528 the Emacs and Gnulib regex code is merged.
5529 (xmalloc, xrealloc): Now static.
5530
aba027e8
PE
55312012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5532
5533 * dired.c (Fsystem_groups): Remove unused local.
5534
e5a36063
GM
55352012-04-17 Glenn Morris <rgm@gnu.org>
5536
5537 * dired.c (Fsystem_users): Doc fix.
5538
316411f0
DA
55392012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5540
5541 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5542 (syms_of_dired): Add them.
5543
9426aba4
PE
55442012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5545
b62a57be
PE
5546 Fix minor alloc.c problems found by static checking.
5547 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5548 New extern decls, to avoid calling undeclared functions.
5549 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5550 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5551 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5552 (NEED_MEM_INSERT): New macro.
5553 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5554 Remove one incorrect comment and fix another.
b62a57be 5555
3539f31f
PE
5556 Fix minor ralloc.c problems found by static checking.
5557 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5558 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5559 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5560 (r_alloc_sbrk): Now static.
5561
a041960a
PE
5562 Improve ralloc.c interface checking.
5563 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5564 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5565 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5566 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5567 [REL_ALLOC]: ... to here, to check interface.
5568 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5569 Remove decls. This fixes an "It stinks!".
5570
9426aba4
PE
5571 * alloc.c (which_symbols): Fix alignment issue / type clash.
5572
d55c12ed
AS
55732012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5574
5575 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5576 (struct Lisp_Misc_Any): Likewise.
5577 (struct Lisp_Free): Likewise.
5578 * alloc.c (union aligned_Lisp_Symbol): Define.
5579 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5580 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5581 (union aligned_Lisp_Misc): Define.
5582 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5583 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5584 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5585
b948ce8b
PE
55862012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5587
5588 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5589 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5590 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5591 * s/netbsd.h, s/sol2-6.h:
5592 Remove definition of GC_MARK_STACK, since the default now works.
5593 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5594 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5595 no longer the default.
5596 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5597
35dc09a1 55982012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5599
35dc09a1
GM
5600 * lread.c (lisp_file_lexically_bound_p):
5601 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5602
35dc09a1
GM
56032012-04-14 Eli Zaretskii <eliz@gnu.org>
5604
5605 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5606 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5607
56082012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5609
5610 * nsterm.m (constrainFrameRect): Always constrain when there is only
5611 one screen (Bug#10962).
5612
bcd86815
KB
56132012-04-13 Ken Brown <kbrown@cornell.edu>
5614
5615 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5616
c25df26e
RT
56172012-04-13 Reuben Thomas <rrt@sc3d.org>
5618
5619 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5620
0fc59f1e
DC
56212012-04-11 Daniel Colascione <dancol@dancol.org>
5622
5623 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5624 against is gone. It's better to use vfork now so that when Cygwin
5625 gains a new, working vfork, we use it automatically (bug#10398).
5626
de8c03dc
SM
56272012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5628
5629 * window.c (save_window_save): Obey window-point-insertion-type.
5630
2f097256
GM
56312012-04-11 Glenn Morris <rgm@gnu.org>
5632
5633 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5634
453b951e
SM
56352012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5636
5637 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5638
75f1671a 56392012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5640
5641 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5642 (force_quit_count): New var.
5643 (handle_interrupt): Use it.
5644
2a8ce227
JB
56452012-04-10 Juanma Barranquero <lekktu@gmail.com>
5646
5647 * w32.c (w32_delayed_load): Record the full path of the library
5648 being loaded (bug#10424).
5649
935396c0
GM
56502012-04-09 Glenn Morris <rgm@gnu.org>
5651
05920a43
GM
5652 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5653 not just in the obarray, before snarfing them. (Bug#11036)
5654
935396c0
GM
5655 * Makefile.in ($(leimdir)/leim-list.el):
5656 Pass EMACS rather than BUILT_EMACS.
5657
a18ecafa
TZ
56582012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5659
5660 * process.c (make_process):
5661 * process.h: Add integer `gnutls_handshakes_tried' member to
5662 process struct.
5663
6bbef4e5
JC
5664 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5665 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5666
5667 * gnutls.c (gnutls_log_function2i): Convenience log function.
5668 (emacs_gnutls_read): Use new log functions,
5669 `gnutls_handshakes_tried' process member, and
5670 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5671 attempts per process (connection).
5672
b4d3bc10
CY
56732012-04-09 Chong Yidong <cyd@gnu.org>
5674
5675 * eval.c (Fuser_variable_p, user_variable_p_eh)
5676 (lisp_indirect_variable): Functions deleted.
5677 (Fdefvar): Caller changed.
5678
5679 * callint.c (Finteractive, Fcall_interactively):
5680 * minibuf.c (Fread_variable): Callers changed.
5681
70f4d973
EZ
56822012-04-09 Eli Zaretskii <eliz@gnu.org>
5683
5684 * xdisp.c (set_cursor_from_row): If the display string appears in
5685 the buffer at position that is closer to point than the position
5686 after the display string, display the cursor on the first glyph of
5687 the display string. Fixes cursor display when a 'display' text
5688 property immediately follows invisible text. (Bug#11094)
5689
cb3c2e3e
PE
56902012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5691
5692 composite.c: use 'double' consistently
5693 * composite.c (get_composition_id): Use 'double' consistently
5694 instead of converting 'float' to 'double' and vice versa; this is
5695 easier to understand and avoids a GCC warning.
5696
fd06db5d
GM
56972012-04-09 Glenn Morris <rgm@gnu.org>
5698
50fe702a
GM
5699 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5700 preparation for dumping it with emacs. (Bug#4789)
5701 (leimdir): New variable.
5702 ($(leimdir)/leim-list.el): New rule.
5703 (emacs$(EXEEXT)): Depend on leim-list.el.
5704
fd06db5d
GM
5705 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5706 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5707 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5708
55c131ee
AS
57092012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5710
5711 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5712 proper alignment.
5713
9209588f
JB
57142012-04-07 Juanma Barranquero <lekktu@gmail.com>
5715
5716 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5717 Remove unused local variable.
5718
e3fb2efb
PE
57192012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5720
5721 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5722 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5723 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5724 objects, as mark_maybe_pointer will catch them otherwise.
5725 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5726 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5727
b5385551
PE
57282012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5729
5730 Fix typo that broke non-Windows builds.
5731 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5732
9078ead6
EZ
57332012-04-07 Eli Zaretskii <eliz@gnu.org>
5734
5735 Support building on MS-Windows with libxml2.
5736
5737 * makefile.w32-in (OBJ2): Add xml.$(O).
5738 (GLOBAL_SOURCES): Add xml.c.
5739 ($(BLD)/xml.$(O)): New dependency list.
5740
5741 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5742 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5743 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5744 [!WINDOWSNT]: New macros.
5745 (init_libxml2_functions, libxml2_loaded_p): New functions.
5746 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5747 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5748 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5749 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5750 linked in).
6bbef4e5
JC
5751 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5752 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5753 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5754
5755 * emacs.c: Don't include libxml/parser.h.
5756 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5757 xmlCleanupParser directly.
5758
5759 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5760
3811fdf3
EZ
57612012-04-07 Eli Zaretskii <eliz@gnu.org>
5762
5763 * indent.c (Fvertical_motion): If there is a display string at
5764 point, use it.vpos to compute how many lines to backtrack after
5765 move_it_to point. (Bug#11133)
5766
2f8e16b2
EZ
57672012-04-06 Eli Zaretskii <eliz@gnu.org>
5768
5769 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5770 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5771 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5772 macros related to unification of CJK characters. For the details,
5773 see the discussion following the message here:
5774 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5775
3d439cd1
CY
57762012-04-04 Chong Yidong <cyd@gnu.org>
5777
5778 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5779
8bc53d00
EZ
57802012-04-01 Eli Zaretskii <eliz@gnu.org>
5781
5782 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5783 instead of alloca. (Bug#11138)
5784
3b0512a3
AS
57852012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5786
5787 * w32menu.c (is_simple_dialog): Properly check lisp types.
5788 (Bug#11141)
5789
8427ddd2
EZ
57902012-03-31 Eli Zaretskii <eliz@gnu.org>
5791
979022ef
EZ
5792 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5793 position we get to after a call to move_it_to fails the
5794 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5795 only if we wind up in a string from display property. (Bug#11063)
5796
a6b1c7cc
EZ
5797 * window.c (Fdelete_other_windows_internal): Invalidate the row
5798 and column information about mouse highlight, so that redisplay
5799 restores it after reallocating the glyph matrices. (Bug#7464)
5800
8427ddd2
EZ
5801 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5802 string comes from a `display' text property, use the buffer
5803 position of that property as if we actually saw that position in
5804 the row's glyphs.
697ba24b
EZ
5805 (move_it_by_lines): Remove the assertion that
5806 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5807 violated when there's a before-string at the beginning of a line.
5808 (Bug#11063)
8427ddd2 5809
65a0a738
EZ
58102012-03-30 Eli Zaretskii <eliz@gnu.org>
5811
5812 * xdisp.c (append_space_for_newline): If the default face was
5813 remapped, use the remapped face for the appended newline.
5814 (extend_face_to_end_of_line): Use the remapped default face for
5815 extending the face to the end of the line.
5816 (display_line): Call extend_face_to_end_of_line when the default
5817 face was remapped. (Bug#11068)
5818
581355cc
EZ
58192012-03-29 Eli Zaretskii <eliz@gnu.org>
5820
5821 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5822
e8fc049f
SM
58232012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5824
5825 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5826
4fb9a543
GM
58272012-03-27 Glenn Morris <rgm@gnu.org>
5828
5829 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5830 Doc fixes.
5831
679910f1
KH
58322012-03-26 Kenichi Handa <handa@m17n.org>
5833
5834 * dispextern.h (struct glyph): Fix previous change. Change the
5835 bit length of glyphless.ch to 25 (Bug#11082).
5836
90d49b7f
CY
58372012-03-26 Chong Yidong <cyd@gnu.org>
5838
5839 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5840 (command_loop_1): Use it; inhibit selection update for
5841 handle-select-window too (Bug#8996).
5842
f514f6f0
FP
58432012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5844
e8fc049f 5845 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5846
bf43fa51
KH
58472012-03-25 Kenichi Handa <handa@m17n.org>
5848
5849 * dispextern.h (struct glyph): Change the bit length of
5850 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5851
8a0c01dd
EZ
58522012-03-24 Eli Zaretskii <eliz@gnu.org>
5853
5854 * s/ms-w32.h (tzname): Include time.h before redirecting to
5855 _tzname. Fixes the MSVC build. (Bug#9960)
5856
7d1c3a76
AS
58572012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5858
8ed79523
AS
5859 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5860 characters.
5861
7d1c3a76
AS
5862 * xterm.c (XTread_socket): Only modify handling_signal if
5863 !SYNC_INPUT. (Bug#11080)
5864
e99a9b8b
EZ
58652012-03-23 Eli Zaretskii <eliz@gnu.org>
5866
5867 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5868 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5869 when fetching a multibyte character consumes more bytes than
5870 CHAR_BYTES returns, due to unification of CJK characters in
5871 string_char. (Bug#11073)
5872
5063c0e1
TN
58732012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5874
5875 * process.c (wait_reading_process_output): Handle pty disconnect
5876 by refraining from sending oneself a SIGCHLD (bug#10933).
5877
9f851fbd
CY
58782012-03-22 Chong Yidong <cyd@gnu.org>
5879
5880 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5881
5063c0e1 5882 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5883 Mark string as coming from a prefix property.
5884 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5885 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5886
fb5b8aca
CY
58872012-03-21 Chong Yidong <cyd@gnu.org>
5888
5889 * xfaces.c (Vface_remapping_alist): Doc fix.
5890
62356a1b
EZ
58912012-03-20 Eli Zaretskii <eliz@gnu.org>
5892
5893 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5894 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5895 Doc fixes.
62356a1b 5896
025de85b
CY
58972012-03-20 Chong Yidong <cyd@gnu.org>
5898
5899 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5900 to reflect default non-nil value of redisplay-dont-pause.
5901
4827f94e
KH
59022012-03-19 Kenichi Handa <handa@m17n.org>
5903
5904 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5905 it fit in a valid range (Bug#11003).
5906
e50a24a2
EZ
59072012-03-18 Eli Zaretskii <eliz@gnu.org>
5908
5909 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5910 that is not from display property, accept the row as a "cursor
5911 row" if one of the string's character has a non-nil `cursor'
5912 property. Fixes cursor positioning when there are newlines in
5913 overlay strings, e.g. in icomplete.el. (Bug#11035)
5914
9af5ed87
PE
59152012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5916
5917 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5918
d1f55f16
CY
59192012-03-12 Chong Yidong <cyd@gnu.org>
5920
5921 * eval.c (inhibit_lisp_code): Rename from
5922 inhibit_window_configuration_change_hook; move from window.c.
5923
5924 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5925 * window.c (run_window_configuration_change_hook)
5926 (syms_of_window): Callers changed.
5927
66c5eebd
CY
59282012-03-11 Chong Yidong <cyd@gnu.org>
5929
413df973
CY
5930 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5931
66c5eebd
CY
5932 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5933
1de11f56
CY
59342012-03-10 Chong Yidong <cyd@gnu.org>
5935
5936 * frame.c (other_visible_frames): Don't assume the selected frame
5937 is visible (Bug#10955).
5938
cae07000
SM
59392012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5940
5941 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5942
89c94350
JD
59432012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5944
5945 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5946 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5947 zero (Bug#10954).
5948
999dd333
GM
59492012-03-03 Glenn Morris <rgm@gnu.org>
5950
01a6dcc8 5951 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5952
de0100f2
EZ
59532012-03-02 Eli Zaretskii <eliz@gnu.org>
5954
5955 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5956 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5957 (redisplay_window, next_element_from_string): Fix typos in
5958 comments.
3e441275
EZ
5959 (redisplay_window): Pass to move_it_vertically the margin in
5960 pixels, not in screen lines.
de0100f2 5961
96a72ee9
GM
59622012-03-02 Glenn Morris <rgm@gnu.org>
5963
5964 * buffer.c (buffer-list-update-hook): Doc fix.
5965
312508d7
EZ
59662012-02-29 Eli Zaretskii <eliz@gnu.org>
5967
5968 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5969 push_it before setting up the iterator for the first overlay
5970 string, even if we have an empty string loaded.
5971 (next_overlay_string): If there's an empty string on the iterator
5972 stack, pop the stack. (Bug#10903)
5973
27f3c637
PE
59742012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5975
5976 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5977 Suggested by Stefan Monnier in
5978 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5979 * alloc.c (widen_to_Lisp_Object): New static function.
5980 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5981 and widening them to Lisp_Objects. This would work even if
5982 USE_LSB_TAG is defined and wide integers are used, which might
5983 happen in a future version of Emacs.
5984
3c9dfce6
CY
59852012-02-25 Chong Yidong <cyd@gnu.org>
5986
fa74b241
CY
5987 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5988 Doc fix.
5989
3c9dfce6
CY
5990 * xselect.c (Fx_selection_exists_p): Doc fix.
5991 (x_clipboard_manager_save_all): Print an informative message
5992 before saving to clipboard manager.
5993
9486df08
CY
59942012-02-24 Chong Yidong <cyd@gnu.org>
5995
5996 * keyboard.c (process_special_events): Handle all X selection
5997 requests in kbd_buffer, not just the next one (Bug#8869).
5998
f01d3321
CY
59992012-02-23 Chong Yidong <cyd@gnu.org>
6000
6001 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6002 call when setting menu-bar-lines and tool-bar-lines parameters.
6003 (unwind_create_frame_1): New helper function.
6004
6005 * window.c (inhibit_window_configuration_change_hook): New var.
6006 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6007 (syms_of_window): Initialize it.
f01d3321 6008
86b847b6
CY
60092012-02-22 Chong Yidong <cyd@gnu.org>
6010
6011 * xterm.c (x_draw_image_relief): Add missing type check for
6012 Vtool_bar_button_margin (Bug#10743).
6013
a59225b1
CY
60142012-02-21 Chong Yidong <cyd@gnu.org>
6015
6016 * fileio.c (Vfile_name_handler_alist): Doc fix.
6017
6018 * buffer.c (Fget_file_buffer): Protect against invalid file
6019 handler return value.
6020
310f5bd4
PE
60212012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6022
cb3a28cc
PE
6023 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6024 when computing $valmask.
6025
310f5bd4
PE
6026 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6027 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6028 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6029 It's useless in that case, and it can cause problems on hosts
6030 that allocate halves of EMACS_INT values separately.
6031 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6032 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6033 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6034 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6035 it avoids undefined behavior on hosts where shifting right by more
6036 than the word width has undefined behavior.
6037
2375c96a
CY
60382012-02-19 Chong Yidong <cyd@gnu.org>
6039
6040 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6041 (Funhandled_file_name_directory, Ffile_name_as_directory)
6042 (Fdirectory_file_name, Fexpand_file_name)
6043 (Fsubstitute_in_file_name): Protect against invalid file handler
6044 return values (Bug#10845).
6045
3eb49e71
EZ
60462012-02-18 Eli Zaretskii <eliz@gnu.org>
6047
6048 * .gdbinit (pitx): Fix incorrect references to fields of the
6049 iterator stack.
6050
7b926f3f
CY
60512012-02-17 Chong Yidong <cyd@gnu.org>
6052
6053 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6054
11273115
PE
60552012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6056
6057 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6058 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6059
c3a70e2b
CY
60602012-02-15 Chong Yidong <cyd@gnu.org>
6061
6062 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6063 marked as special. Also, starting docstrings with * is obsolete.
6064
0ca43699
AS
60652012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6066
6067 * gnutls.c (emacs_gnutls_write): Fix last change.
6068
2e8f3c56
LI
60692012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6070
6071 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6072 send_process.
6073
af70074f
SM
60742012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6075
6076 * keymap.c (Fsingle_key_description): Handle char ranges.
6077
95986d52
CY
60782012-02-12 Chong Yidong <cyd@gnu.org>
6079
afd83bd1
CY
6080 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6081 as that creates a dangerous corner case.
6082
95986d52
CY
6083 * window.c (Fdelete_window_internal): Invalidate the mouse
6084 highlight (Bug#9904).
6085
bd7da63e
GM
60862012-02-12 Glenn Morris <rgm@gnu.org>
6087
6088 * xselect.c (Fx_own_selection_internal)
6089 (Fx_get_selection_internal, Fx_disown_selection_internal)
6090 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6091 * nsselect.m (Fx_own_selection_internal)
6092 (Fx_disown_selection_internal, Fx_selection_exists_p)
6093 (Fx_selection_owner_p, Fx_get_selection_internal):
6094 Sync docs and argument specs with the xselect.c versions.
6095
77abcbc2
LI
60962012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6097
6098 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6099
90b671e2
EZ
61002012-02-11 Eli Zaretskii <eliz@gnu.org>
6101
1c0ca0b7
EZ
6102 * w32select.c (Fx_selection_exists_p): Sync doc string and
6103 argument list with xselect.c. (Bug#10783)
6104
6105 * w16select.c (Fx_selection_exists_p): Sync doc string and
6106 argument list with xselect.c. (Bug#10783)
90b671e2 6107
49241268
GM
61082012-02-10 Glenn Morris <rgm@gnu.org>
6109
6110 * fns.c (Fsecure_hash): Doc fix.
6111
f998bbe7 61122012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6113
6114 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6115
0992bd9c
CY
61162012-02-07 Chong Yidong <cyd@gnu.org>
6117
6118 * buffer.c (Fbuffer_local_variables)
6119 (buffer_lisp_local_variables): Handle unbound vars correctly;
6120 don't let Qunbound leak into Lisp.
6121
af008560
GM
61222012-02-07 Glenn Morris <rgm@gnu.org>
6123
dd605cc4
GM
6124 * image.c (Fimagemagick_types): Doc fix.
6125
af008560
GM
6126 * image.c (imagemagick-render-type): Change it from a lisp object
6127 to an integer. Move the doc here from the lisp manual.
6128 Treat all values not equal to 0 the same.
6129
1449fa1d
CY
61302012-02-06 Chong Yidong <cyd@gnu.org>
6131
6132 * doc.c (store_function_docstring): Avoid applying docstring of
6133 alias to base function (Bug#2603).
6134
3723ec07
AS
61352012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6136
6137 * .gdbinit (pp1, pv1): Remove redundant defines.
6138 (pr): Use pp.
6139
79c1cc1e
CY
61402012-02-04 Chong Yidong <cyd@gnu.org>
6141
6142 * nsterm.m: Declare a global (Bug#10694).
6143
d7f29f8e
EZ
61442012-02-04 Eli Zaretskii <eliz@gnu.org>
6145
cae07000
SM
6146 * w32.c (get_emacs_configuration_options):
6147 Include --enable-checking, if specified, in the return value.
d7f29f8e 6148
3b95a6f9
MR
61492012-02-04 Martin Rudalics <rudalics@gmx.at>
6150
6151 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6152 after rounding frame sizes. (Bug#9723)
6153
d6fa96a6
EZ
61542012-02-04 Eli Zaretskii <eliz@gnu.org>
6155
6156 * keyboard.c (adjust_point_for_property): Don't position point
6157 before BEGV. (Bug#10696)
6158
df0b2940
PE
61592012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6160
6161 Handle overflow when computing char display width (Bug#9496).
6162 * character.c (char_width): Return EMACS_INT, not int.
6163 (char_width, c_string_width): Check for overflow when
6164 computing the width; this is possible now that individual
6165 characters can have unbounded width. Problem introduced
6166 by merge from Emacs 23 on 2012-01-19.
6167
6bee44d6
MA
61682012-02-02 Michael Albinus <michael.albinus@gmx.de>
6169
6170 * dbusbind.c (Fdbus_register_method): Mention the return value
6171 :ignore in the docstring.
6172
44f92739
GM
61732012-02-02 Glenn Morris <rgm@gnu.org>
6174
1b9f60cc
GM
6175 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6176
44f92739
GM
6177 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6178 Unconditionally set to t. (Bug#10673)
6179 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6180 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6181 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6182
c5d3843c
KH
61832012-02-02 Kenichi Handa <handa@m17n.org>
6184
6185 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6186 0, do not call append_composite_glyph.
6187
159462d4 61882012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6189
6190 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6191 NULL (Bug#6988).
6192 (x_produce_glyphs): If the component of a composition is a null
6193 string, set it->pixel_width to 1 to avoid zero-width glyph.
6194
78cef877
EZ
61952012-02-01 Eli Zaretskii <eliz@gnu.org>
6196
6197 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6198 first 2 arguments are identical. This makes inserting large
6199 output from a subprocess an order of magnitude faster on
6200 MS-Windows, where all sbrk'ed memory is always contiguous.
6201
97897668
GM
62022012-01-31 Glenn Morris <rgm@gnu.org>
6203
6204 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6205 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6206 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6207
31fd3586
GM
62082012-01-29 Glenn Morris <rgm@gnu.org>
6209
6210 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6211
0e24a8b2
CY
62122012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6213
6214 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6215
cc0adcb0
CY
62162012-01-28 Chong Yidong <cyd@gnu.org>
6217
6218 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6219
acc28cb9
CY
62202012-01-26 Chong Yidong <cyd@gnu.org>
6221
9c69cfb7
CY
6222 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6223
acc28cb9
CY
6224 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6225 repeat counts (Bug#10507).
6226
48da7392
GM
62272012-01-26 Glenn Morris <rgm@gnu.org>
6228
6229 * lread.c (syms_of_lread): Doc fix.
6230
14af5f7f
CY
62312012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6232
6233 * coding.c (encode_designation_at_bol): Change return value to
6234 EMACS_INT.
6235
0b21c100
CY
62362012-01-25 Chong Yidong <cyd@gnu.org>
6237
6238 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6239
3c2907f7
CY
62402012-01-21 Chong Yidong <cyd@gnu.org>
6241
6242 * floatfns.c (Fcopysign): Make the second argument non-optional,
6243 since nil is not allowed anyway.
6244
959ad23f
AS
62452012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6246
6247 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6248 (send_process): Likewise.
6249
34a02f46
MR
62502012-01-19 Martin Rudalics <rudalics@gmx.at>
6251
6252 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6253 (Vwindow_persistent_parameters): Do not use Qstate.
6254 Rewrite doc-strings.
34a02f46 6255
1259009a 62562012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6257
6258 * character.c (char_width): New function.
70d4fdf6
GM
6259 (Fchar_width, c_string_width, lisp_string_width):
6260 Use char_width (Bug#9496).
25ed9e61 6261
6a6ee00d
MR
62622012-01-16 Martin Rudalics <rudalics@gmx.at>
6263
6264 * window.c (Vwindow_persistent_parameters): New variable.
6265 (Fset_window_configuration, save_window_save): Handle persistent
6266 window parameters.
6267
c85efaf7
EZ
62682012-01-14 Eli Zaretskii <eliz@gnu.org>
6269
6270 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6271 thrashing the stack of the thread. (Bug#9087)
6272
5944709e
PE
62732012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6274
6275 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6276
e71f5d99
EZ
62772012-01-11 Eli Zaretskii <eliz@gnu.org>
6278
6279 * xdisp.c (rows_from_pos_range): Handle the case where the
6280 highlight ends on a newline. (Bug#10464)
6281 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6282 he end column for display of highlight that ends on a newline
6283 before a R2L line.
6284
ce316182
GM
62852012-01-11 Glenn Morris <rgm@gnu.org>
6286
6287 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6288 from load-path also when installation-directory is nil. (Bug#10208)
6289
5b43da69
GM
62902012-01-10 Glenn Morris <rgm@gnu.org>
6291
74cc8ff9
GM
6292 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6293
7d8d6e4e
GM
6294 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6295 Update template values to be closer to their typical values these days.
5b43da69 6296
a0db8d43
EZ
62972012-01-09 Eli Zaretskii <eliz@gnu.org>
6298
6299 * xdisp.c (rows_from_pos_range): Accept additional argument
6300 DISP_STRING, and accept any glyph in a row whose object is that
6301 string as eligible for mouse highlight. Fixes mouse highlight of
6302 display strings from overlays. (Bug#10464)
6303
9a0115ab 63042012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6305
b9110d6a 6306 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6307 * fileio.c (auto_saving_dir_umask): New static var.
6308 (Fmake_directory_internal): Use it.
6309 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6310 creating the directory. The old code temporarily assigns
6311 too-generous permissions to the directory.
6312 (do_auto_save_eh): Clear it.
b9110d6a 6313 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6314 that the var is always cleared.
6315
6c1bd3f3
EZ
63162012-01-07 Eli Zaretskii <eliz@gnu.org>
6317
6318 * search.c (scan_buffer): Pass character positions to
6319 know_region_cache, not byte positions. (Bug#6540)
6320
069d2b50
L
63212012-01-07 LynX <_LynX@bk.ru> (tiny change)
6322
6323 * w32.c (sys_rename): Report EXDEV when rename of a directory
6324 fails because the target is on another logical disk. (Bug#10284)
6325
75bf0d33
DB
63262012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6327
6328 * xterm.c (x_embed_request_focus): New function.
6329
6330 * xterm.h: Add prototype.
6331
6332 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6333
1c6e5a32
GM
63342012-01-05 Glenn Morris <rgm@gnu.org>
6335
6336 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6337
651e947e
EZ
63382012-01-01 Eli Zaretskii <eliz@gnu.org>
6339
6340 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6341 Load gnutls_transport_set_lowat only if GnuTLS version is below
6342 2.11.1.
6343 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6344 GnuTLS versions below 2.11.1.
6345
3778cdd8
AL
63462011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6347
6348 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6349 to the doc string advising against its use for altering the way
6350 windows are scrolled.
6351
0e5317f7
KH
63522011-12-28 Kenichi Handa <handa@m17n.org>
6353
6354 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6355 coding-system ASCII compatible only when it does not produce BOM
6356 on encoding (Bug#10383).
6357
93d5ca1f
JD
63582011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6359
6360 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6361 can scroll.
6362 (create_and_show_popup_menu): Always use menu_position_func for
6363 Gtk3 (Bug#10361).
6364
ca22b785
AS
63652011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6366
6367 * callint.c (Fcall_interactively): Don't truncate prompt string.
6368
d048e1e6
EZ
63692011-12-23 Eli Zaretskii <eliz@gnu.org>
6370
6371 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6372 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6373 resumed from there (after widening). (Bug#10360)
d048e1e6 6374
5ccaba1f
JD
63752011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6376
6377 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6378
204ee57f
JD
63792011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6380
b81d40f0
JB
6381 * nsterm.m (x_free_frame_resources):
6382 Release f->output_data.ns->miniimage.
204ee57f
JD
6383 (ns_index_color): Fix indentation. Do not retain
6384 color_table->colors[i].
6385
6386 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6387 before returning.
6388
6389 * nsfns.m (x_set_background_color): Assign return value from
6390 ns_index_color to face-background instead of NSColor*.
6391 (ns_implicitly_set_icon_type): Fix indentation.
6392 Change assignment in for loop to comparison.
6393
6394 * emacs.c (ns_pool): New variable.
6395 (main): Assign ns_pool.
6396 (Fkill_emacs): Call ns_release_autorelease_pool.
6397
6398 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6399 autorelease fdesc, release fdAttrs and tdict.
6400 (ns_get_covering_families): Release charset.
6401 (ns_findfonts): Release NSFontDescriptor created with new.
6402 (ns_uni_to_glyphs): Fix indentation.
6403 (setString): Release attrStr before assigning new value.
6404
c803b2b7
JD
64052011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6406
678f4426
JD
6407 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6408 and NS_IMPL_COCOA.
6409 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6410 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6411
cd394be1 64122011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6413
5fecd5fc
JD
6414 * nsterm.m (ns_term_init): Subscribe for notifications
6415 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6416 to method trackingNotification in EmacsMenu.
6417
6418 * nsmenu.m (trackingMenu): New variable.
3771cb17 6419 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6420 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6421 from Aquamacs (Bug#7030).
678f4426
JD
6422
64232011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6424
c803b2b7
JD
6425 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6426 (symbol_to_nsstring): Fix indentation.
6427 (ns_symbol_to_pb): New function.
cae07000
SM
6428 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6429 (Fns_rotate_cut_buffers_internal): Remove.
6430 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6431 Fns_store_cut_buffer_internal.
6432 (ns_get_foreign_selection, Fx_own_selection_internal)
6433 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6434 (Fns_get_selection_internal, Fns_store_selection_internal):
6435 Use ns_symbol_to_pb and check if return value is nil.
6436 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6437 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6438 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6439 renamed to Sns_store_selection_internal.
6440 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6441 and remove this function.
6442 (ns_handle_selection_clear): Remove, never used.
6443 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6444 here.
6445
e1b01a3a
KB
64462011-12-17 Ken Brown <kbrown@cornell.edu>
6447
6448 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6449 GID is unknown (Bug#10257).
6450
2adb6e85
PE
64512011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6452
6453 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6454 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6455 which caused a build failure on GNU/Linux IA-64. This problem was
6456 introduced by my 2011-10-07 patch.
6457
d1d7b339
JL
64582011-12-15 Juri Linkov <juri@jurta.org>
6459
6460 * image.c (imagemagick_error): New function. (Bug#10112)
6461 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6462 Use `imagemagick_error' where ImageMagick functions return
6463 `MagickFalse'.
6464 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6465 proper order.
6466
100d5755
KH
64672011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6468
6469 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6470 fill background (Bug#8992).
6471
454592a6
MR
64722011-12-13 Martin Rudalics <rudalics@gmx.at>
6473
6474 * window.c (Vwindow_combination_resize)
6475 (Vwindow_combination_limit): Use t instead of non-nil in
6476 doc-strings.
61d4b438
MR
6477 (Vrecenter_redisplay): Add first sentence of doc-string on
6478 separate line.
53524d93 6479 (Frecenter): Fix doc-string typo.
454592a6 6480
3633e3aa
KH
64812011-12-11 Kenichi Handa <handa@m17n.org>
6482
6483 * coding.c (Funencodable_char_position): Pay attention to the
6484 buffer text relocation (Bug#9389).
6485
7b9d523a 64862011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6487
7b9d523a
JD
6488 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6489 gtk_init (Bug#10100).
6490
b73189c6
EZ
64912011-12-10 Eli Zaretskii <eliz@gnu.org>
6492
6493 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6494 IT->string is nil. (Bug#10263)
6495
f7dfe5d6
JD
64962011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6497
83faebb4
JD
6498 * nsterm.h (x_free_frame_resources): Declare.
6499
f7dfe5d6
JD
6500 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6501 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6502
6503 * nsterm.h (ns_get_defaults_value): Declare.
6504
6505 * nsterm.m (ns_default): Call ns_get_defaults_value.
6506
7cd4e72c
EZ
65072011-12-09 Eli Zaretskii <eliz@gnu.org>
6508
6509 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6510 (Bug#10170)
6511
b34d7317
YM
65122011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6513
6514 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6515 that where the value of an _OBJC_* symbol points to is in the .bss
6516 section (Bug#10240).
6517
76470ad1
KH
65182011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6519
6520 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6521 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6522
745fff94
KH
65232011-12-08 Kenichi Handa <handa@m17n.org>
6524
6525 * ftfont.c (get_adstyle_property): Fix previous change
6526 (Bug#10233).
6527
6e44397c
JB
65282011-12-07 Juanma Barranquero <lekktu@gmail.com>
6529
6530 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6531 dirs from the default value of EMACSLOADPATH (bug#10208).
6532
7efa6272
GM
65332011-12-07 Glenn Morris <rgm@gnu.org>
6534
6535 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6536 installation and source directories as well. (Bug#10208)
6537
f6fc4d87
CY
65382011-12-06 Chong Yidong <cyd@gnu.org>
6539
6540 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6541
2bf26180
GM
65422011-12-06 Glenn Morris <rgm@gnu.org>
6543
6544 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6545 as an error, not just -1. (Bug#10217)
6546
3a6ad4f0
CY
65472011-12-05 Chong Yidong <cyd@gnu.org>
6548
6549 * keyboard.c (process_special_events): New function.
6550 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6551
75a3b399
PE
65522011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6553
6554 * coding.c (encode_designation_at_bol): Don't use uninitialized
6555 local variable (Bug#9318).
6556
c3c9e25e
KH
65572011-12-05 Kenichi Handa <handa@m17n.org>
6558
6559 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6560 return Qnil (Bug#8046, Bug#10193).
6561
5eb05ea3
KH
65622011-12-05 Kenichi Handa <handa@m17n.org>
6563
6564 * coding.c (encode_designation_at_bol): New args charbuf_end and
6565 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6566 (coding_set_source): Return how many bytes coding->source was
6567 relocated.
6568 (coding_set_destination): Return how many bytes
6569 coding->destination was relocated.
6570 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6571 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6572
65732011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6574
6575 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6576 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6577 macro (Bug#9318).
6578
65792011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6580
6581 The following changes are to fix Bug#9318.
6582
a79703f5 6583 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6584 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6585 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6586 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6587
7dbda6df
JB
65882011-12-05 Juanma Barranquero <lekktu@gmail.com>
6589
6590 * lisp.h (process_quit_flag): Fix external declaration.
6591
6d5eb5b0
SM
65922011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6593
6594 Don't macro-inline non-performance-critical code.
6595 * eval.c (process_quit_flag): New function.
6596 * lisp.h (QUIT): Use it.
6597
a0c3fad0
JD
65982011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6599
6600 * nsfns.m (get_geometry_from_preferences): New function.
6601 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6602
6c07aac2
AS
66032011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6604
6605 * emacs.c (Qkill_emacs): Define.
6606 (syms_of_emacs): Initialize it.
6607 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6608 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6609 (quit_throw_to_read_char): Add parameter `from_signal'.
6610 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6611 * lisp.h (QUIT): Call Fkill_emacs if requested.
6612
c052ead4
JD
66132011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6614
6615 * widget.c (update_wm_hints): Return if wmshell is null.
6616 (widget_update_wm_size_hints): New function.
6617
6618 * widget.h (widget_update_wm_size_hints): Declare.
6619
6620 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6621 widget_update_wm_size_hints (Bug#10104).
6622
9e49252b
EZ
66232011-12-03 Eli Zaretskii <eliz@gnu.org>
6624
6625 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6626 before a newline, prepare the bidi iterator for consuming the
6627 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6628 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6629
02b16839
JL
66302011-12-02 Juri Linkov <juri@jurta.org>
6631
6632 * search.c (Fword_search_regexp): New Lisp function created from
6633 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6634 (Fword_search_backward, Fword_search_forward)
6635 (Fword_search_backward_lax, Fword_search_forward_lax):
6636 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6637 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6638
0068070e
SM
66392011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6640
6641 * fileio.c (Finsert_file_contents): Move after-change-function call
6642 to before the "handled:" label, since all "goto handled" appear in
6643 cases where the *-change-functions have already been properly called
6644 (bug#10117).
6645
3360a3fc
AS
66462011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6647
6648 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6649 waiting for input. (Bug#10169)
6650
73d6c093
EZ
66512011-11-30 Eli Zaretskii <eliz@gnu.org>
6652
6653 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6654 verifies glyph row's hash code--we have just reallocated the
6655 glyphs, so their contents can be complete garbage. (Bug#10164)
6656
febe6bea
JB
66572011-11-30 Juanma Barranquero <lekktu@gmail.com>
6658
6659 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6660
801a4313
EZ
66612011-11-30 Eli Zaretskii <eliz@gnu.org>
6662
6663 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6664 attributes are tested _before_ calling verify_row_hash, to protect
6665 against GCC re-ordering of the tests. (Bug#10164)
6666
2b56b87e
JD
66672011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6668
6669 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6670
6671 * xterm.c (handle_one_xevent): Only set async_visible and friends
6672 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6673 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6674 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6675
dbf31225
PE
66762011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6677
6678 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6679 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6680 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6681 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6682 All uses changed to use GCPRO1 etc.
6683 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6684 Revert to old implementation (i.e., before 2011-03-11).
6685
1305621b
YM
66862011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6687
6688 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6689 of scroll runs so as to avoid assigning disabled bogus rows and
6690 unnecessary graphics copy operations.
6691
8c9afb46
EZ
66922011-11-27 Eli Zaretskii <eliz@gnu.org>
6693
6694 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6695 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6696 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6697 (malloc, free, realloc, calloc): Redirect to e_* only when
6698 compiling Emacs.
6699
6700 * lisp.h (GCTYPEBITS): Move before first use.
6701 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6702 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6703 this macro definition.
6704
6705 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6706 _MSC_VER.
6707
54e9e3bf
JD
67082011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6709
6d5eb5b0
SM
6710 * gtkutil.c (xg_create_frame_widgets):
6711 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6712 present with Gtk+ 2.0.
6713
83aca1cb
PE
67142011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6715
6716 * fileio.c (Finsert_file_contents): Undo previous change; see
6717 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6718
5b76caa4
PE
67192011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6720
6721 Rename locals to avoid shadowing.
6722 * fileio.c (Finsert_file_contents):
6723 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6724 * process.c (wait_reading_process_output):
6725 Rename inner 'proc' to 'p' to avoid shadowing.
6726 Indent for consistency with usual Emacs style.
6727
8c535114
EZ
67282011-11-25 Eli Zaretskii <eliz@gnu.org>
6729
6730 * xdisp.c (redisplay_window): If cursor row is not fully visible
6731 after recentering, and scroll-conservatively is set to a large
6732 number, scroll window by a few more lines to make the cursor fully
6733 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6734 (start_display): Don't move to the next line if the display should
6735 start at a newline that is part of a display vector or an overlay
6736 string. (Bug#10119)
8c535114 6737
fa4fdb5c
JL
67382011-11-24 Juri Linkov <juri@jurta.org>
6739
6740 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6741 after the `MagickPingImage' call. (Bug#10112)
6742
90ec88df
CY
67432011-11-23 Chong Yidong <cyd@gnu.org>
6744
6745 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6746
56e2e794
MR
67472011-11-23 Martin Rudalics <rudalics@gmx.at>
6748
6749 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6750 making another buffer current. (Bug#10114)
6751
b6e64c41
GM
67522011-11-23 Glenn Morris <rgm@gnu.org>
6753
6754 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6755
6b21de18
CY
67562011-11-23 Chong Yidong <cyd@gnu.org>
6757
6758 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6759 using it (Bug#5984).
6760
b12cd789
EZ
67612011-11-22 Eli Zaretskii <eliz@gnu.org>
6762
6763 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6764 and header-lines, as they don't have one computed for them.
6765 (Bug#10098)
6766
6767 * .gdbinit (prow): Make displayed values more self-explaining.
6768 Add row's hash code.
6769
261b6fd4
LMI
67702011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6771
6772 * process.c (wait_reading_process_output): Fix asynchrounous
6773 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6774 (wait_reading_process_output): Add comment and URL.
261b6fd4 6775
e7cfd277
JD
67762011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6777
6778 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6779
a9b9b7f5
CY
67802011-11-21 Chong Yidong <cyd@gnu.org>
6781
6782 * window.c (Fnext_window, Fprevious_window): Doc fix.
6783
b0d15b4f
SM
67842011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6785
6786 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6787
fe7a3057
JB
67882011-11-20 Juanma Barranquero <lekktu@gmail.com>
6789
6790 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6791
d2999b1a
MR
67922011-11-20 Martin Rudalics <rudalics@gmx.at>
6793
6794 * window.c (Fset_window_combination_limit): Rename argument
6795 STATUS to LIMIT.
6796 (Vwindow_combination_limit): Remove "status" from doc-string.
6797
d5ff9cd0
AS
67982011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6799
6800 * m/ibms390.h: Remove.
6801 * m/ibms390x.h: Don't include "ibms390.h".
6802
a5bb9bd3
SM
68032011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6804
6805 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6806 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6807
cd1181db
JB
68082011-11-20 Juanma Barranquero <lekktu@gmail.com>
6809
6810 * casetab.c (Fset_case_table):
6811 * charset.c (Fcharset_after): Fix typos.
6812
615a3b8d 68132011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6814
17e845af
PE
6815 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6816 Otherwise, valgrind does not work on some platforms.
6817 Problem reported by Andreas Schwab in
6a0bf43d
PE
6818 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6819 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6820 is set, removing the need for VIRT_ADDRESS_VARIES.
6821 (PURE_P): Use a more-efficient implementation that needs just one
6822 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6823 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6824 to 4 (xorl, subq, cmpq, setbe).
6825 * alloc.c (pure): Always extern now, since that's the
6826 VIRT_ADDR_VARIES behavior.
6827 (PURE_POINTER_P): Use a single comparison, not two, for
6828 consistency with the new puresize.h.
6829 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6830 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6831 Remove VIRT_ADDR_VARIES no longer needed.
6832
f8fe6f96
EZ
68332011-11-19 Eli Zaretskii <eliz@gnu.org>
6834
6835 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6836 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6837 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6838 behave as if the cursor position were at the window margin.
6839
6840 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6841 and the cursor position is out of bounds, behave as if the cursor
6842 position were at the window margin. (Bug#10075)
6843
df05a53c
CY
68442011-11-18 Chong Yidong <cyd@gnu.org>
6845
6846 * window.c (Fwindow_combination_limit): Make first argument
6847 non-optional, since it is meaningless for live windows like the
6848 selected window.
61ccba97 6849
2071918e
DA
68502011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6851
6852 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6853
b50a28de
SM
68542011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6855
6856 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6857 (graft_intervals_into_buffer): Simplify.
6858
015137db
EZ
68592011-11-18 Eli Zaretskii <eliz@gnu.org>
6860
6861 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6862 hash values of the two rows.
6863 (copy_row_except_pointers): Preserve the used[] arrays and the
6864 hash values of the two rows. (Bug#10035)
68c95424 6865 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6866
6867 * xdisp.c (row_hash): New function, body extracted from
6868 compute_line_metrics.
6869 (compute_line_metrics): Call row_hash, instead of computing the
6870 hash code inline.
6871
6872 * dispnew.c (verify_row_hash): Call row_hash for computing the
6873 hash code of a row, instead of duplicating code from xdisp.c.
6874
6875 * dispextern.h (row_hash): Add prototype.
6876
a2addb04
TH
68772011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6878
6879 * frame.c (delete_frame): Don't delete the terminal when the last
6880 X frame is closed if emacs is built with GTK toolkit.
6881
df85d315
JB
68822011-11-17 Juanma Barranquero <lekktu@gmail.com>
6883
6884 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6885
a0c2d0ae
MR
68862011-11-17 Martin Rudalics <rudalics@gmx.at>
6887
6888 * window.c (Vwindow_splits): Rename to
6889 Vwindow_combination_resize. Suggested by Juri Linkov.
6890 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6891 of Vwindow_splits.
6892
58179cce
JB
68932011-11-16 Juanma Barranquero <lekktu@gmail.com>
6894
7877f373
JB
6895 * nsfns.m (Fns_font_name):
6896 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6897
b6f67890
MR
68982011-11-16 Martin Rudalics <rudalics@gmx.at>
6899
6900 * window.h (window): Rename slot "nest" to "combination_limit".
6901 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6902 (Fset_window_nest): Rename to Fset_window_combination_limit.
6903 (Vwindow_nest): Rename to Vwindow_combination_limit.
6904 (recombine_windows, make_parent_window, make_window)
6905 (Fsplit_window_internal, saved_window)
6906 (Fset_window_configuration, save_window_save): Rename all
6907 occurrences of window_nest to window_combination_limit.
6908
c7015153
JB
69092011-11-15 Juanma Barranquero <lekktu@gmail.com>
6910
6911 * image.c (imagemagick_load_image): Fix typo.
6912
322ad6ec
EZ
69132011-11-14 Eli Zaretskii <eliz@gnu.org>
6914
6915 * xdisp.c (display_line): Move the call to
6916 highlight_trailing_whitespace before the call to
6917 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6918 faces of all the glyphs to compute ROW's hash value.
6919 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6920
f067b8ec
JB
69212011-11-14 Juanma Barranquero <lekktu@gmail.com>
6922
6923 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6924 just return (bug#10044).
6925
1e5b2111
EZ
69262011-11-12 Eli Zaretskii <eliz@gnu.org>
6927
7ef3cbd5
EZ
6928 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6929 with user-defined heap size. Bump the default size of the temacs
6930 heap to 27MB, to avoid memory warning when running temacs.
6931 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6932
1e5b2111
EZ
6933 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6934 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6935 (verify_row_hash) [XASSERTS]: New function.
6936 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6937 that the hash value of glyph rows is correct.
1e5b2111 6938
89d61221
MR
69392011-11-12 Martin Rudalics <rudalics@gmx.at>
6940
6941 * window.h (window): Remove splits slot.
6942 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6943 (Fdelete_other_windows_internal, make_parent_window)
6944 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6945 (Fset_window_configuration, save_window_save): Don't deal with
6946 split status of windows.
6947 (saved_window): Remove splits slot.
6948 (Vwindow_splits): Rewrite doc-string.
6949
97f18cc8
JD
69502011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6951
6952 * xfns.c (unwind_create_frame):
6953 * nsfns.m (unwind_create_frame):
6954 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6955 Vframe_list (Bug#9999).
6956
22a648b4
DA
69572011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6958
0b381c7e 6959 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6960
659afede
KH
69612011-11-11 Kenichi Handa <handa@m17n.org>
6962
6963 * callproc.c (Fcall_process): Set the member dst_multibyte of
6964 process_coding.
6965
9ac0394b
KH
69662011-11-11 Johan Bockgård <bojohan@gnu.org>
6967
6968 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6969 avoid a crash (bug#9496).
6970
2fbdc249
CY
69712011-11-09 Chong Yidong <cyd@gnu.org>
6972
6973 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6974 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6975
ac6b1f81
PE
69762011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6977
6978 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6979
09db192c
PE
69802011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6981
6982 Avoid some portability problems by eschewing 'extern inline' functions.
6983 The trivial performance wins aren't worth the portability hassles; see
6984 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6985 et seq.
6986 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6987 (window_box_width, window_box_left, window_box_left_offset)
6988 (window_box_right, window_box_right_offset): Undo previous change,
6989 by removing the "extern"s.
6990 * intervals.c (adjust_intervals_for_insertion)
6991 (adjust_intervals_for_deletion): Undo previous change,
6992 making these static again.
6993 (offset_intervals, temp_set_point_both, temp_set_point)
6994 (copy_intervals_to_string): No longer inline.
6995 * xdisp.c (window_text_bottom_y, window_box_width)
6996 (window_box_height, window_box_left_offset)
6997 (window_box_right_offset, window_box_left, window_box_right)
6998 (window_box): No longer inline.
6999
105216ed
CY
70002011-11-08 Chong Yidong <cyd@gnu.org>
7001
7002 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7003 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7004 Signal an error if not a live window.
105216ed
CY
7005 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7006 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7007
ae9e237f
JB
70082011-11-07 Juanma Barranquero <lekktu@gmail.com>
7009
7010 * lisp.h (syms_of_abbrev): Remove declaration.
7011 Reported by CHENG Gao <chenggao@royau.me>.
7012
c7aa8333
EZ
70132011-11-07 Eli Zaretskii <eliz@gnu.org>
7014
7015 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7016 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7017 of temacs in GUI mode.
7018
be7f5545
MR
70192011-11-07 Martin Rudalics <rudalics@gmx.at>
7020
7021 * window.h: Declare delete_all_child_windows instead of
7022 delete_all_subwindows.
7023 * window.c (Fwindow_nest, Fset_window_nest)
7024 (Fset_window_new_total, Fset_window_new_normal)
7025 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7026 (delete_all_subwindows): Rename to delete_all_child_windows.
7027 (Fdelete_other_windows_internal, Fset_window_configuration):
7028 Call delete_all_child_windows instead of delete_all_subwindows.
7029 * frame.c (delete_frame): Call delete_all_child_windows instead
7030 of delete_all_subwindows.
7031
ca78dc43
PE
70322011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7033
7034 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7035 This is also needed for porting to any host where GC_MARK_STACK is
7036 not GC_MAKE_GCPROS_NOOPS.
7037 (which_symbols): Use it.
7038
a0241d01
KH
70392011-11-07 Kenichi Handa <handa@m17n.org>
7040
7041 * coding.c (coding_set_destination): Check coding->src_pos only
7042 when coding->src_object is a buffer (bug#9910).
7043
7044 * process.c (send_process): Set the member src_multibyte of coding
7045 to 0 (bug#9911) when sending a unibyte text.
7046
7047 * callproc.c (Fcall_process): Set the member src_multibyte of
7048 process_coding to 0 (bug#9912).
7049
a64bfdfa 70502011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7051
7052 * xmenu.c (cleanup_widget_value_tree): New function.
7053 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7054 calling free_menubar_widget_value_tree directly (Bug#9830).
7055
cb41b32a
PE
70562011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7057
7058 Fix some portability problems with 'inline'.
7059 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7060 (window_box_width, window_box_left, window_box_left_offset)
7061 (window_box_right, window_box_right_offset): Declare extern.
7062 Otherwise, these inline functions do not conform to C99 and
7063 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7064 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7065 * intervals.c (adjust_intervals_for_insertion)
7066 (adjust_intervals_for_deletion): Now extern, because otherwise the
7067 extern inline functions 'offset_intervals' couldn't refer to it.
7068 (static_offset_intervals): Remove.
7069 (offset_intervals): Rewrite using the old contents of
7070 static_offset_intervals. The old version didn't conform to C99
7071 because an extern inline function contained a reference to an
7072 identifier with static linkage.
7073
b7041366
AS
70742011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7075
7076 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7077 GC.
7078
88a37c4d
EZ
70792011-11-06 Eli Zaretskii <eliz@gnu.org>
7080
7081 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7082 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7083 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7084 return Qleft_to_right.
7085
49745b39
CY
70862011-11-06 Chong Yidong <cyd@gnu.org>
7087
7088 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7089 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7090 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7091 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7092 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7093 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7094 (Fwindow_vscroll): Doc fix.
7095 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7096 argument, since it makes no sense to pass a live window and for
7097 consistency with window-child.
7098
1f05cd82
CS
70992011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7100
7101 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7102 support MSVC.
7103
22610910
JR
71042011-11-05 Jason Rumney <jasonr@gnu.org>
7105
7106 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7107 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7108 fonts (Bug#6029).
7109 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7110 bitwise arithmetic preventing use of unicode-sip and non-truetype
7111 opentype fonts.
7112
a06776b2
EZ
71132011-11-05 Eli Zaretskii <eliz@gnu.org>
7114
3ad924ba
EZ
7115 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7116 "emacs"-only part.
7117
a06776b2
EZ
7118 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7119 initialization code to keep similarity to xfns.c after changes
7120 from 2011-11-05.
7121
c9e7db78
JD
71222011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7123
a97f8f3f
JD
7124 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7125 (unwind_create_frame): New function (Bug#9943).
7126 (Fx_create_frame): Restructure code to be more similar to the one in
7127 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7128 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7129 Move terminal->reference_count++ just before making the frame official
7130 (Bug#9943).
7131
7132 * nsterm.m (x_free_frame_resources): New function.
7133 (x_destroy_window): Move code to x_free_frame_resources.
7134
c9e7db78 7135 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7136 (Fx_create_frame, x_create_tip_frame):
7137 Move terminal->reference_count++ just before making the frame
75f1671a 7138 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7139 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7140
a6fc3b5c
EZ
71412011-11-05 Eli Zaretskii <eliz@gnu.org>
7142
7143 Support MSVC build with newer versions of Visual Studio.
7144 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7145 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7146 nt/gmake.defs.
7147
7148 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7149 which are not supported by MSVC.
7150 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7151 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7152 bitfields.
7153 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7154 types in bitfields.
7155 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7156
7157 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7158
58179cce 71592011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7160
7161 Support MSVC build with newer versions of Visual Studio.
7162 * w32.c: Don't include w32api.h for MSVC.
7163 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7164
7165 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7166 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7167 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7168 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7169 e_* cousins.
7170 (alloca) [_MSC_VER]: Define to _alloca.
7171
7172 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7173
7174 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7175
a58c13ed
EZ
71762011-11-04 Eli Zaretskii <eliz@gnu.org>
7177
7178 * xdisp.c (note_mouse_highlight): If either of
7179 previous/next-single-property-change returns nil, treat that as
7180 the beginning or the end of the buffer. (Bug#9955)
7181
fe0b6370
JD
71822011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7183
a58c13ed 7184 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7185 label is not null (Bug#9951).
7186 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7187 may be NULL.
7188
89bd5ee1
EZ
71892011-11-04 Eli Zaretskii <eliz@gnu.org>
7190
7191 * window.c (Fwindow_body_size): Mention in the doc string that the
7192 return value is in frame's canonical units. (Bug#9949)
7193
84c3edb9
EZ
71942011-11-03 Eli Zaretskii <eliz@gnu.org>
7195
4e2fb5c7
EZ
7196 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7197
84c3edb9 7198 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7199 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7200 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7201
bc17a887
EZ
72022011-11-01 Eli Zaretskii <eliz@gnu.org>
7203
7204 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7205 Don't stop backward scan on the continuation glyph, even though
7206 its CHARPOS is positive.
6d5eb5b0
SM
7207 (mouse_face_from_buffer_pos, note_mouse_highlight):
7208 Rename cover_string to disp_string.
bc17a887 7209
4ee88440
MR
72102011-11-01 Martin Rudalics <rudalics@gmx.at>
7211
7212 * window.c (temp_output_buffer_show): Don't use
7213 Vtemp_buffer_show_specifiers.
7214 (Vtemp_buffer_show_specifiers): Remove unused variable.
7215
c2ff3c02
EZ
72162011-10-30 Eli Zaretskii <eliz@gnu.org>
7217
7218 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7219 past the beginning of the current glyph matrix.
7220
58179cce 72212011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7222
7223 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7224 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7225 HAVE_GTK3 (Bug#9869).
b77a6a7f 7226
3b574623
JD
7227 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7228 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7229
b77a6a7f
JD
7230 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7231
7232 * xterm.c: Declare x_handle_net_wm_state to return int.
7233 (handle_one_xevent): Check if we are iconified but don't have
7234 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7235 (get_current_wm_state): Return non-zero if not hidden,
7236 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7237 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7238 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7239 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7240
196e41e4
PE
72412011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7242
7243 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7244 so that this new function doesn't get optimized away by a
7245 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7246
021f2e1a
AS
72472011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7248
7249 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7250
8b058d44
EZ
72512011-10-29 Eli Zaretskii <eliz@gnu.org>
7252
7253 Fix the `xbytecode' command.
7254 * .gdbinit (xprintbytestr): New command.
b50a28de 7255 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7256 (xbytecode): Print the byte-code string as well.
7257
4452fb80
EZ
72582011-10-29 Kim Storm <storm@cua.dk>
7259
8b058d44
EZ
7260 * alloc.c (which_symbols): New function.
7261
21b72067
AS
72622011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7263
7264 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7265 line. (Bug#9903)
7266
83ed7b5c
GM
72672011-10-29 Glenn Morris <rgm@gnu.org>
7268
7269 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7270 Not clear what it was for, and it causes various bugs. (Bug#9839)
7271
5a7a728b
EZ
72722011-10-28 Eli Zaretskii <eliz@gnu.org>
7273
7274 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7275 possible random value that matches one of those tested as
7276 condition to clear the mouse face.
7277
d3d0842f
CY
72782011-10-28 Chong Yidong <cyd@gnu.org>
7279
7280 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7281
31b39d13
DN
72822011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7283
7284 * window.c (make_window): Initialize phys_cursor_on_p.
7285
9aba6043
SM
72862011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7287
7288 * lisp.h (struct Lisp_Symbol): Update comments.
7289
c20992f4
JB
72902011-10-28 Juanma Barranquero <lekktu@gmail.com>
7291
7292 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7293
db4f02f2
EZ
72942011-10-28 Eli Zaretskii <eliz@gnu.org>
7295
7296 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7297 <oslsachem@gmail.com> for helping to debug this.
7298
7299 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7300 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7301 (g_b_init_get_glyph_outline_w): New static variables.
7302 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7303 (GetGlyphOutlineW_Proc): New typedefs.
7304 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7305 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7306 New functions.
7307 (w32font_open_internal, compute_metrics):
7308 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7309 instead of calling the "wide" APIs directly.
7310
7311 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7312
7313 * w32.h (syms_of_w32font): Add prototype.
7314
87e68db4
JB
73152011-10-27 Juanma Barranquero <lekktu@gmail.com>
7316
7317 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7318 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7319 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7320 (Fmove_to_window_line): Doc fix.
7321
435c1d67
CY
73222011-10-27 Chong Yidong <cyd@gnu.org>
7323
7324 * process.c (make_process): Set gnutls_state to NULL.
7325
7326 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7327 non-NULL, regardless of GNUTLS_INITSTAGE.
7328 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7329 an error. Set process slots as soon as we allocate them.
7330
7331 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7332
9c6c6f49
CY
73332011-10-27 Chong Yidong <cyd@gnu.org>
7334
9aba6043
SM
7335 * gnutls.c (emacs_gnutls_deinit): New function.
7336 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7337 (Fgnutls_deinit, Fgnutls_boot): Use it.
7338
7339 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7340 (deactivate_process): Call emacs_gnutls_deinit.
7341
657d08d3
JB
73422011-10-27 Juanma Barranquero <lekktu@gmail.com>
7343
7344 * image.c (x_create_x_image_and_pixmap):
7345 * w32.c (sys_rename, w32_delayed_load):
7346 * w32font.c (fill_in_logfont):
7347 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7348
5430d399
JB
73492011-10-26 Juanma Barranquero <lekktu@gmail.com>
7350
7351 * w32fns.c (w32_default_color_map): New function,
7352 extracted from Fw32_default_color_map.
a7ef684b 7353 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7354
fe0055fa
PE
73552011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7356
7357 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7358
e6346438
SM
73592011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7360
7361 * keyboard.c (test_undefined): New function (bug#9751).
7362 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7363
e112cc37
ET
73642011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7365
7366 * sysdep.c (init_sys_modes): Fix the check for the controlling
7367 terminal (Bug#6649).
7368
7b5d6677
EZ
73692011-10-20 Eli Zaretskii <eliz@gnu.org>
7370
7371 * dispextern.h (struct bidi_it): New member next_en_type.
7372
7373 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7374 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7375 current character, check also for next_en_type being WEAK_EN.
7376 (bidi_resolve_weak): Don't enter the expensive loop if the current
7377 position is before next_en_pos. Record the bidi type of the first
7378 non-ET, non-BN character we find, in addition to its position.
7379 (bidi_level_of_next_char): Invalidate next_en_type when
7380 next_en_pos is over-stepped.
7381
7da0b018
PE
73822011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7383
7384 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7385 * editfns.c: Rewrite current-time-zone so that it invokes
7386 the equivalent of (format-time-string "%Z") to get the time zone name.
7387 This fixes a bug when the time zone name contains characters that
7388 need converting from the system time locale to Emacs internal format.
7389 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7390 that patch fixed format-time-string to do the conversion, but
7391 I forgot to fix current-time-zone.
7392 (format_time_string): New function, containing most of
7393 what Fformat_time_string used to contain.
7394 (Fformat_time_string): Rewrite in terms of format_time_string.
7395 This doesn't change this function's behavior.
7396 (current-time-zone): Rewrite to use format_time_string.
7397 This fixes the bug reported by Michael Schierl in
7398 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7399 Jason Rumney's 2007-06-07 change worked around this bug, but
7400 didn't fix it.
7401 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7402
8547b010
EZ
74032011-10-19 Eli Zaretskii <eliz@gnu.org>
7404
7405 * xdisp.c (start_display): If the character at POS is displayed
7406 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7407 (try_window_reusing_current_matrix): If a line ends in a display
7408 vector or the next line starts in a display vector, continue
7409 redrawing the window even though the character position of
7410 start_row was reached.
8547b010
EZ
7411 (Bug#9771, part 2)
7412
4e948d15
CY
74132011-10-18 Chong Yidong <cyd@gnu.org>
7414
7415 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7416 with nobreak-char-display too.
7417
4787455f
EZ
74182011-10-18 Eli Zaretskii <eliz@gnu.org>
7419
7420 Fix part 3 of bug#9771.
7421 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7422 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7423 non-neutral characters if the current character is a paragraph
7424 separator (a.k.a. Newline). This avoids running the same
7425 expensive loop twice, once when we consume the preceding newline
7426 and the other time when the line actually needs to be displayed.
7427 Avoid the loop when we see neutrals on the base embedding level
7428 following a character whose directionality is the same as the
7429 paragraph's. This avoids running the expensive loop when a line
7430 ends in a long sequence of neutrals, like control characters.
7431 Add assertion against STRONG_AL type. Slightly rearrange code
7432 that determines the type of a neutral given the first non-neutral
7433 that follows it.
7434 (bidi_level_of_next_char): Set next_en_pos to zero when
7435 invalidating its info.
7436
2c91f553
EZ
74372011-10-17 Eli Zaretskii <eliz@gnu.org>
7438
7439 * xdisp.c (push_display_prop): Determine whether to record string
7440 or buffer position by IT->string, not by IT->method. Allow
7441 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7442 (move_it_vertically_backward): Don't look for character position
7443 immediately after the newline when in a continuation line.
7444 (Bug#9771, part 1)
2c91f553 7445
c7b08b0d
MR
74462011-10-15 Martin Rudalics <rudalics@gmx.at>
7447
7448 * window.c (coordinates_in_window): Rewrite and delabelize
7449 vertical border check. (Bug#5357) (Bug#9618)
7450
6b02f655
SM
74512011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7452
7453 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7454 errors in XSetWindowBorder (bug#9310).
7455
81d40c92
DA
74562011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7457
7458 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7459 avoid crash when xmalloc overrun checking is enabled.
7460
d4172c3b
EZ
74612011-10-13 Eli Zaretskii <eliz@gnu.org>
7462
7463 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7464 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7465 cursor motion with <left> and <right> arrow keys.
7466
7467 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7468 some callers set that themselves.
7469
b00eea75
EZ
74702011-10-12 Eli Zaretskii <eliz@gnu.org>
7471
7472 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7473 display string and the previous row comes from the same string and
7474 is empty. (Bug#9739) (Bug#9738)
7475
8fe012c4
SM
74762011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7477
7478 * doc.c (get_doc_string): Encode file name (bug#9735).
7479
0074aef2
EZ
74802011-10-12 Eli Zaretskii <eliz@gnu.org>
7481
79beb178
EZ
7482 * bidi.c (bidi_level_of_next_char):
7483 * xdisp.c (get_visually_first_element): Remove old incorrect
7484 comments regarding the Unicode Line Separator character.
7485
0074aef2
EZ
7486 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7487
6e4b3fbe
DA
74882011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7489
7490 * alloc.c (Fgc_status): Do not access beyond zombies array
7491 boundary if nzombies > MAX_ZOMBIES.
7492 * alloc.c (dump_zombies): Add missing format specifier.
7493
0324f3af
PE
74942011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7495
b5525cac
PE
7496 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7497 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7498
0324f3af
PE
7499 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7500 Some packages use them to denote characters with modifiers.
7501
e9b5f888
AS
75022011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7503
7504 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7505 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7506 matching a pp-number. Rename parameter var to var1.
7507
127827c0
SM
75082011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7509
7510 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7511
c8fd3bd0
GM
75122011-10-08 Glenn Morris <rgm@gnu.org>
7513
7514 * callint.c (Fcall_interactively): Give a more explicit error for the
7515 'c' case with a non-character input. (Bug#8479)
7516
352ec8ff
EZ
75172011-10-08 Eli Zaretskii <eliz@gnu.org>
7518
03669ccb
EZ
7519 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7520 lines.
7061c986
EZ
7521 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7522 lines that are hscrolled on the left.
03669ccb 7523
352ec8ff
EZ
7524 * dispnew.c (buffer_posn_from_coords): Account for a possible
7525 presence of header-line. (Bug#4426)
7526
a66cfb1c
SM
75272011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7528
6b02f655
SM
7529 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7530 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7531
7c5ee88e
PE
75322011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7533
7534 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7535 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7536 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7537 this makes Emacs dump core during garbage collection on rare
7538 occasions. sizeof is obviously inferior to offsetof here, so
7539 stick with offsetof.
7540 (GC_POINTER_ALIGNMENT): New macro.
7541 (mark_memory): Omit 3rd (offset) arg; caller changed.
7542 Don't assume EMACS_INT alignment is the same as pointer alignment.
7543
df1bbe5b
SM
75442011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7545
7546 * keyboard.c (read_key_sequence_remapped): New var.
7547 (read_key_sequence): Compute remapping in the right buffer.
7548 (command_loop_1): Use read_key_sequence's remapping directly.
7549
51553db6
SM
75502011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7551
32c1fffd
SM
7552 * dired.c (file_name_completion): Don't expand file name.
7553 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7554 before checking file name handler.
7555
51553db6
SM
7556 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7557 they've been requested explicitly (bug#9591).
7558
b6bd1599 75592011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7560
7561 * keymap.c (Fsingle_key_description): Use make_specified_string
7562 instead of build_string to build string from push_key_description.
7563 (Bug#5193)
7564
f701dc2a
PE
75652011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7566
4222c55d
PE
7567 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7568 This fixes a Y2038 bug on 64-bit hosts.
7569 * buffer.c (reset_buffer):
7570 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7571 (Fclear_buffer_auto_save_failure):
7572 Use 0, not -1, to represent an unset failure time, since time_t
7573 might not be signed.
7574
f701dc2a
PE
7575 Remove dependency on glibc malloc internals.
7576 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7577 Move back here from lisp.h, but with their new implementations.
7578 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7579 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7580 * charset.c (charset_table_init): New static var.
7581 (syms_of_charset): Use it instead of xmalloc. This removes a
7582 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7583 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7584 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7585 Move back to alloc.c.
7586 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7587 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7588
9ceebf39
JD
75892011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7590
7591 * nsterm.m (windowDidResize): Call x_set_window_size only when
7592 ns_in_resize is true. Otherwise set pixelwidth/height and
7593 call change_frame_size (Bug#9628).
7594
cb993c58
PE
75952011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7596
3930c88b
PE
7597 Port --enable-checking=all to Fedora 14 x86-64.
7598 * charset.c (syms_of_charset): Also account for glibc malloc's
7599 internal overhead when calculating the initial malloc maximum.
7600
cb993c58
PE
7601 Port --enable-checking=all to Fedora 14 x86.
7602 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7603 Move to lisp.h.
7604 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7605 (overrun_check_realloc, overrun_check_free):
7606 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7607 That way, xmalloc returns a properly-aligned pointer even if
7608 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7609 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7610 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7611 into account when calculating the initial malloc maximum.
7612 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7613 Move here from alloc.c, so that charset.c can use it too.
7614 Properly align; the old code wasn't right for common 32-bit hosts
7615 when configured with --enable-checking=all.
7616 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7617 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7618
31bed486
EZ
76192011-09-29 Eli Zaretskii <eliz@gnu.org>
7620
04c70788 7621 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7622 use EDOM.
7623
fbcaa2f3
EZ
76242011-09-28 Eli Zaretskii <eliz@gnu.org>
7625
7626 * xdisp.c (compute_display_string_end): If there's no display
7627 string at CHARPOS, return -1.
7628
7629 * bidi.c (bidi_fetch_char): When compute_display_string_end
7630 returns a negative value, treat the character as a normal
7631 character not covered by a display string. (Bug#9624)
7632
a239d4e9
JB
76332011-09-28 Juanma Barranquero <lekktu@gmail.com>
7634
7635 * lread.c (Fread_from_string): Fix typo in docstring.
7636
88652fd5
EZ
76372011-09-27 Eli Zaretskii <eliz@gnu.org>
7638
7639 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7640 newline, reseat the iterator instead of bidi-iterating there one
7641 character at a time. (Bug#9610)
32c1fffd
SM
7642 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7643 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7644
ed497dd4
AS
76452011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7646
7647 * lread.c (readevalloop): Use correct code for NBSP.
7648 (read1): Likewise. (Bug#9608)
7649
b2bf61aa
MA
76502011-09-25 Michael Albinus <michael.albinus@gmx.de>
7651
7652 * dbusbind.c (Fdbus_register_signal): When service is not
7653 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7654
32bbb17c
GM
76552011-09-25 Glenn Morris <rgm@gnu.org>
7656
7657 * buffer.c (truncate-lines): Doc fix.
7658
94e0933e
CY
76592011-09-24 Chong Yidong <cyd@stupidchicken.com>
7660
7661 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7662 (Fset_window_next_buffers): Doc fix.
7663
cddde921
GM
76642011-09-24 Glenn Morris <rgm@gnu.org>
7665
7666 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7667
1260aef1
PE
76682011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7669
25b4bfa0
PE
7670 Fix minor problems found by static checking.
7671 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7672 * indent.c (Fvertical_motion): Fix == vs = typo.
7673
e3cbd34b
EZ
76742011-09-24 Eli Zaretskii <eliz@gnu.org>
7675
a66cfb1c
SM
7676 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7677 Default value is now t. Doc fix.
6bf7006f 7678
e3cbd34b 7679 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7680 logic when moving up, not only when moving down. Fix the
e3cbd34b 7681 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7682 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7683
7684 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7685 CHARPOS is covered by a display string which includes newlines.
7686 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7687 is covered by a display string with embedded newlines.
7688
a3de0cbd
MA
76892011-09-24 Michael Albinus <michael.albinus@gmx.de>
7690
7691 * dbusbind.c (Fdbus_register_signal): Add match rule to
7692 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7693 (Fdbus_register_method, Vdbus_registered_objects_table):
7694 Fix docstring.
a3de0cbd 7695
b260039d
JM
76962011-09-24 Jim Meyering <meyering@redhat.com>
7697
32c1fffd 7698 do not ignore write error for any output size
b260039d
JM
7699 The previous change was incomplete.
7700 While it makes emacs --batch detect the vast majority of stdout
7701 write failures, errors were still ignored whenever the output size is
7702 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7703 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7704 && echo FAIL: ignored write error
7705 FAIL: ignored write error
7706 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7707 && echo FAIL: ignored write error
7708 FAIL: ignored write error
7709 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7710
8eca8a7c
AS
77112011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7712
7713 * emacs.c (Fkill_emacs): In noninteractive mode exit
7714 non-successfully if a write error occurred on stdout. (Bug#9574)
7715
3341db62
EZ
77162011-09-21 Eli Zaretskii <eliz@gnu.org>
7717
7718 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7719 the xassert test.
7720
7721 * dispextern.h (struct it): Update the comment documenting what
7722 can it->OBJECT be.
7723
8c203dbf
EZ
77242011-09-20 Eli Zaretskii <eliz@gnu.org>
7725
7726 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7727 a display string, extend search for cursor position to end of row.
7728 (find_row_edges): If the row ends in a newline from a display
7729 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7730 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7731 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7732 non-empty line. Fixes confusing cursor motion with arrow keys at
7733 the beginning of a line that starts with whitespace.
8c203dbf 7734
a4824228
LMI
77352011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7736
7737 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7738 (bug#9493).
7739
33ed493b
CY
77402011-09-18 Chong Yidong <cyd@stupidchicken.com>
7741
7742 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7743 boolean (Bug#9154).
7744
56cd55c8
EZ
77452011-09-18 Eli Zaretskii <eliz@gnu.org>
7746
7747 * xdisp.c (display_line): Record maximum and minimum buffer
7748 positions even if no glyphs were produced (e.g., by a zero-width
7749 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7750 buffer positions that will be removed from the glyph row because
7751 they don't fit.
c02dcedf
EZ
7752 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7753 column is beyond frame width: don't subtract 1 "pixel" when
7754 computing width of the stretch.
3e62b7e0
EZ
7755 (reseat_at_next_visible_line_start): Undo the change made on
7756 2011-09-17 that saved paragraph information and restored it after
7757 the call to `reseat'. (Bug#9545)
56cd55c8 7758
5ed99d36 77592011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7760
7761 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7762 and turn window cursor on if cleared (Bug#9415).
7763
5ed99d36 77642011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7765
7766 * search.c (boyer_moore): Take unibyte characters from pattern
7767 literally. (Bug#9458)
7768
9bade7b2
EZ
77692011-09-18 Eli Zaretskii <eliz@gnu.org>
7770
7771 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7772
e5e9d610
PE
77732011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7774
87e4427a
PE
7775 Fix minor problem found by static checking.
7776 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7777 initialized, to pacify gcc -Wuninitialized.
7778
e5e9d610
PE
7779 * fileio.c: Report proper errno when syscall falls.
7780 (Finsert_file_contents): Save and restore errno,
7781 so that report_file_error outputs the correct diagnostic.
7782 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7783
a1674f0b
EZ
77842011-09-18 Eli Zaretskii <eliz@gnu.org>
7785
7786 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7787
fbfb6dd4
EZ
77882011-09-17 Eli Zaretskii <eliz@gnu.org>
7789
7790 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7791 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7792
bb187662
EZ
77932011-09-17 Eli Zaretskii <eliz@gnu.org>
7794
1137e8b8 7795 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7796 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7797
7798 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7799 (bidi_find_paragraph_start): Search back for paragraph beginning
7800 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7801 (bidi_move_to_visually_next): Only trigger paragraph-related
7802 computations when the last character is a newline or at EOB, not
7803 just any NEUTRAL_B. (Bug#9470)
7804
bb187662
EZ
7805 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7806 truncated lines if point is covered by a display string. (Bug#9524)
7807
2e621251
PE
78082011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7809
7810 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7811 (cons_to_x_long): New function.
7812 (lisp_data_to_selection_data): Use it. Correct the test for
7813 short-versus-long data; it was negated. Break out of vector
7814 loop, for efficiency, when a long datum is discovered.
7815
91a15bc6
SM
78162011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7817
7818 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7819
b41c3a35
EZ
78202011-09-16 Eli Zaretskii <eliz@gnu.org>
7821
7822 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7823 GCC PR/17406) by declaring this function with external scope.
7824
7812ba2d
PE
78252011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7826
7827 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7828 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7829
cf7edc2a
AS
78302011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7831
7832 * editfns.c (Fformat): Correctly handle text properties on "%%".
7833
bd01620e
EZ
78342011-09-15 Eli Zaretskii <eliz@gnu.org>
7835
7836 * xterm.c (x_draw_composite_glyph_string_foreground):
7837 * w32term.c (x_draw_composite_glyph_string_foreground):
7838 * term.c (encode_terminal_code):
7839 * composite.c (composition_update_it, get_composition_id):
7840 * xdisp.c (get_next_display_element)
7841 (fill_composite_glyph_string): Add comments about special meaning
7842 of TAB characters in a composition.
7843
a02719a3
PE
78442011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7845
7846 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7847 This occurs when processing a multibyte format.
7848 Problem reported by Wolfgang Jenker.
a02719a3 7849
72589a3c
JB
78502011-09-15 Johan Bockgård <bojohan@gnu.org>
7851
7852 * xdisp.c (try_cursor_movement): Only check for exact match if
7853 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7854
1c14176c
PE
78552011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7856
7857 Remove unused external symbols.
7858 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7859 * xdisp.c (calc_pixel_width_or_height): Now static.
7860 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7861 * indent.c (check_display_width):
7862 * w32term.c: Fix comment to match code.
7863 * xterm.c, xterm.h (x_catching_errors): Remove.
7864
d2eea5b5
PE
78652011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7866
7867 * xselect.c: Use signed conversions more consistently (Bug#9498).
7868 (selection_data_to_lisp_data): Assume incoming selection data are
7869 signed integers, not unsigned. This is to be consistent with
7870 outgoing selection data, which was modified to use signed integers
7871 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7872 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7873 expects long, not unsigned long.
7874
46888499
EZ
78752011-09-14 Eli Zaretskii <eliz@gnu.org>
7876
7877 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7878 computation of loop end. Reported by Johan Bockgård
7879 <bojohan@gnu.org>.
7880
ef8ef9fb
CY
78812011-09-13 Chong Yidong <cyd@stupidchicken.com>
7882
7883 * frame.c (Fother_visible_frames_p): Function deleted.
7884
fa819fed
EZ
78852011-09-12 Eli Zaretskii <eliz@gnu.org>
7886
7887 * indent.c (compute_motion): Process display vector front to back
7888 rather than the other way around. (Bug#2496)
7889
2ba8e008
SM
78902011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7891
7892 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7893
20f53c69
CY
78942011-09-11 Chong Yidong <cyd@stupidchicken.com>
7895
7896 * minibuf.c (Fread_from_minibuffer): Doc fix.
7897
d562d7a4
EZ
78982011-09-11 Eli Zaretskii <eliz@gnu.org>
7899
7900 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7901 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7902
1c4d7f3d
LMI
79032011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7904
7905 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7906 value for non-existent files.
7907
b885bf36
EZ
79082011-09-11 Eli Zaretskii <eliz@gnu.org>
7909
7910 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7911 set its "size" to -1. This will set the modtime_size field of
7912 the corresponding buffer to -1, which is what
7913 verify-visited-file-modtime expects for files that do not exist.
7914 (Bug#9139)
7915
6612f0bf
PE
79162011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7917
7918 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7919 here ...
7920 * lisp.h: ... from here. push_key_description is no longer
7921 defined in keyboard.c, so its declaration should not be in
7922 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7923 logically belongs with push_key_description.
7924
dfb3f755
PE
79252011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7926
7927 * buffer.h: Include <sys/types.h> instead of <time.h>.
7928 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7929 Problem reported by Herbert J. Skuhra.
7930
3134906c
LMI
79312011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7932
7933 * xml.c (parse_region): Make the parsing work for
7934 non-comment-starting XML files again (bug#9144).
7935
8d903f4e
AS
79362011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7937
7938 * image.c (gif_load): Fix calculation of bottom and right corner.
7939 (Bug#9468)
7940
80ad64f4
EZ
79412011-09-10 Eli Zaretskii <eliz@gnu.org>
7942
7943 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7944 redisplay in small windows.
7945
208a048d
EZ
79462011-09-09 Eli Zaretskii <eliz@gnu.org>
7947
7948 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7949
9b1c252e
MR
79502011-09-08 Martin Rudalics <rudalics@gmx.at>
7951
7952 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7953 Operate on live windows only.
7954
2949f33b
JB
79552011-09-08 Juanma Barranquero <lekktu@gmail.com>
7956
7957 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7958
e08dcafd
EZ
79592011-09-07 Eli Zaretskii <eliz@gnu.org>
7960
7961 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7962 only under bidi iteration.
7963
115b96bd
JD
79642011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7965
7966 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7967
c8199d0f
PE
79682011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7969
7970 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7971 Without this fix, the command to link temacs failed due to an
7972 undefined symbol __builtin_isnan. This is because
7973 /usr/include/iso/math_c99.h #defines isnan(x) to
7974 __builtin_isnan(x), but the bundled gcc, which identifies itself
7975 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7976 a __builtin_isnan.
7977 * floatfns.c (isnan): #undef, and then #define to a clone of
7978 what's in data.c.
7979 (Fisnan): Always define, since it's always available now.
7980 (syms_of_floatfns): Always define isnan at the Lisp level.
7981
e39b275c 79822011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7983
7984 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7985
b2db44d9 79862011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7987
f4af5137 7988 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7989 The previous code assumed that file offsets (off_t values) fit in
7990 EMACS_INT variables, which is not true on typical 32-bit hosts.
7991 The code messed up by falsely reporting buffer overflow in cases
7992 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7993 when "big" contains more than 2**29 bytes, even though this
7994 inserts just one byte and does not overflow the buffer.
7995 (Finsert_file_contents): Store file offsets as off_t
7996 values, not as EMACS_INT values. Check for overflow when
7997 converting between EMACS_INT and off_t. When checking for
7998 buffer overflow or for overlap, take the offsets into account.
7999 Don't use EMACS_INT for small values where int suffices.
8000 When checking for overlap, fix a typo: ZV was used where
8001 ZV_BYTE was intended.
8002 (Fwrite_region): Don't assume off_t fits into 'long'.
8003 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8004
ecfc0a49
MA
80052011-09-05 Michael Albinus <michael.albinus@gmx.de>
8006
8007 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8008
6511acf2 80092011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8010
0999621a 8011 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8012
8013 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8014 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8015 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8016 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8017 (modify_event_symbol): Do not assume that the length of
8018 name_alist_or_stem is safe to alloca and fits in int.
8019 (Fexecute_extended_command): Likewise for function name and binding.
8020 (Frecursion_depth): Wrap around reliably on integer overflow.
8021 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8022 since some callers pass EMACS_INT values.
8023 (Fsingle_key_description): Don't crash if symbol name contains more
8024 than MAX_ALLOCA bytes.
8025 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8026 (get_minibuffer): Arg is now EMACS_INT, not int.
8027 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8028 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8029 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8030
2be7d702
PE
8031 * dbusbind.c (signature_cat): New function.
8032 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8033 Do not overrun buffer; instead, report string overflow.
8034
9d1df220
PE
8035 * dispnew.c (add_window_display_history): Don't overrun buffer.
8036 Truncate instead; this is OK since it's just a log.
8037
33ef5c64
PE
8038 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8039 even if the time zone offset is outlandishly large.
8040 Don't mishandle offset == INT_MIN.
8041
66c6fdd5
PE
8042 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8043 when creating daemon; the previous buffer-overflow check was incorrect.
8044
d749b01b
PE
8045 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8046 which has the guts of the old verror function.
8047
b5cd1905
PE
8048 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8049 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8050
6e1a67fb
PE
8051 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8052 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8053 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8054 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8055 length of string rather than counting it via multiple sprintfs;
8056 that's simpler and more reliable.
c21721cc
PE
8057 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8058 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8059 sprintf, in case result does not fit in int.
8060
c57b67fc
PE
8061 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8062 (fontset_from_font): Print it.
8063
8a401434
PE
8064 * frame.c (tty_frame_count): Now printmax_t, not int.
8065 (make_terminal_frame, set_term_frame_name): Print it.
8066 (x_report_frame_params): In X, window IDs are unsigned long,
8067 not signed long, so print them as unsigned.
8068 (validate_x_resource_name): Check for implausibly long names,
8069 and don't assume name length fits in 'int'.
8070 (x_get_resource_string): Don't blindly alloca invocation name;
8071 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8072 not fit in int.
8073
6e1a67fb
PE
8074 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8075 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8076 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8077
0df02bf3
PE
8078 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8079 Use esprintf, not sprintf, in case result does not fit in int.
8080
48e30793
PE
8081 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8082 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8083 it as a large positive number.
8084 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8085 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8086
a66ff6d8
PE
8087 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8088 in case result does not fit in int.
8089
aca216ff
PE
8090 * print.c (float_to_string): Detect width overflow more reliably.
8091 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8092 buffer overrun. Don't assume list length fits in 'int'. Treat
8093 print length of 0 as 0, not as infinity; to be consistent with other
8094 uses of print length in this function. Don't overflow print length
8095 index. Don't assume hash table size fits in 'long', or that
8096 vectorlike size fits in 'unsigned long'.
8097
31c286f7
PE
8098 * process.c (make_process): Use printmax_t, not int, to format
8099 process-name gensyms.
8100
55e5faa1
PE
8101 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8102
80f2e268
PE
8103 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8104 to avoid potential buffer overrun.
8105
670741ab
PE
8106 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8107 if X resource line is longer than 512 bytes.
8108
b7163a50
PE
8109 * xfns.c (x_window): Make sprintf buffer a bit bigger
8110 to avoid potential buffer overrun.
8111
ae58ff1f
PE
8112 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8113
c43c8a6a
PE
8114 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8115
3f8236f4
PE
81162011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8117
53e9fe90 8118 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8119 Without these, Emacs silently mishandles large integers sometimes.
8120 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8121 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8122
6511acf2
PE
8123 * xdisp.c (try_window_id): Check Emacs fixnum range before
8124 converting to 'int'.
806add1d 8125
6511acf2 8126 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8127 Check that an Emacs fixnum is in range before assigning it to 'int'.
8128 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8129 values converted from Emacs fixnums.
8130 (Frecenter): Don't wrap around a line count if it is out of 'int'
8131 range; instead, treat it as an extreme value.
8132 (Fset_window_configuration, compare_window_configurations):
8133 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8134
6511acf2
PE
8135 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8136 that can exceed INT_MAX. Check that EMACS_INT value is in range
8137 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8138 (match_limit): Don't assume that a fixnum can fit in 'int'.
8139
6511acf2 8140 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8141 exceed INT_MAX.
8142
6511acf2 8143 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8144 (Fvertical_motion): Don't wrap around LINES values that don't fit
8145 in 'int'. Instead, treat them as extreme values. This is good
8146 enough for windows, which can't have more than INT_MAX lines anyway.
8147
fcb901a7
LMI
81482011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8149
0f2f6b6d
LMI
8150 * Require libxml/parser.h to avoid compilation warning.
8151
fcb901a7
LMI
8152 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8153
8154 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8155 since this reportedly can destroy thread storage.
8156
6e20a0d4
CY
81572011-08-30 Chong Yidong <cyd@stupidchicken.com>
8158
8159 * syntax.c (find_defun_start): Update all cache variables if
8160 exiting early (Bug#9401).
8161
148ae00e
EZ
81622011-08-30 Eli Zaretskii <eliz@gnu.org>
8163
f6cfbd8f
EZ
8164 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8165
148ae00e
EZ
8166 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8167 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8168 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8169
8170 * term.c (tty_append_glyph): New function.
8171 (produce_stretch_glyph): Static function and its prototype deleted.
8172
a66cfb1c
SM
8173 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8174 Add prototypes.
148ae00e 8175
c4a07a4c
PE
81762011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8177
8178 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8179 when checking :margin (Bug#9390).
8180 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8181 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8182 so that the name doesn't mislead. All uses changed.
8183
6bc8cd65
JB
81842011-08-28 Johan Bockgård <bojohan@gnu.org>
8185
8186 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8187 set_tty_hooks.
8188
dca4927e
EZ
81892011-08-27 Eli Zaretskii <eliz@gnu.org>
8190
8191 * xdisp.c (move_it_to): Don't bail out early when reaching
8192 position beyond to_charpos, if we are scanning backwards.
8193 (move_it_vertically_backward): When DY == 0, make sure we get to
8194 the first character in the line after the newline.
8195
f2cad773
PE
81962011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8197
8198 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8199 (ccl_driver): Do not generate an out-of-range pointer.
8200 (Fccl_execute_on_string): Remove unnecessary check for
8201 integer overflow, noted by Stefan Monnier in
8202 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8203 Remove a FIXME that didn't need fixing.
8204 Simplify the newly-introduced buffer reallocation code.
8205
0cae2cdb
JB
82062011-08-27 Juanma Barranquero <lekktu@gmail.com>
8207
8208 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8209
5fc295a4 82102011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8211
70c60eb2 8212 Integer and memory overflow issues (Bug#9196).
726e0ab1 8213
d31850da
PE
8214 * doc.c (get_doc_string): Rework so that
8215 get_doc_string_buffer_size is the actual buffer size, rather than
8216 being 1 less than the actual buffer size; this makes xpalloc more
8217 convenient.
8218
a69fbedb
PE
8219 * image.c (x_allocate_bitmap_record, cache_image):
8220 * xselect.c (Fx_register_dnd_atom):
8221 Simplify previous changes by using xpalloc.
8222
fe5c5d37
PE
8223 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8224 since either will do and ptrdiff_t is convenient with xpalloc.
8225
0065d054
PE
8226 * charset.c (charset_table_size)
8227 (struct charset_sort_data.priority): Now ptrdiff_t.
8228 (charset_compare): Don't overflow if priorities differ greatly.
8229 (Fsort_charsets): Don't assume list length fits in int.
8230 Check for size-calculation overflow when allocating sort data.
8231 (syms_of_charset): Allocate an initial charset table that is
8232 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8233
8234 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8235
8236 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8237 The actual value is always <= INT_MAX, and leaving it unsigned made
8238 overflow checking harder.
8239
8240 * dispextern.h (struct glyph_matrix.rows_allocated)
8241 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8242 with xpalloc. The values are still always <= INT_MAX.
8243
8244 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8245
8246 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8247 (SAFE_NALLOCA): New macro.
8248
8249 * region-cache.c (struct boundary.pos, find_cache_boundary)
8250 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8251 (set_cache_region, invalidate_region_cache)
8252 (revalidate_region_cache, know_region_cache, region_cache_forward)
8253 (region_cache_backward, pp_cache):
8254 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8255 so that ptrdiff_t * can be passed to xpalloc.
8256 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8257 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8258 (pp_cache): Don't assume cache_len fits in int.
8259 * region-cache.h: Adjust extern decls to match.
8260
8261 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8262 EMACS_INT, since either will do, for xpalloc.
8263
8264 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8265 (xnmalloc, xnrealloc, xpalloc): New functions.
8266
726e0ab1
PE
8267 * bidi.c (bidi_shelve_header_size): New constant.
8268 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8269 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8270
51f30bc5 8271 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8272 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8273 (overlay_strings):
8274 Don't update size of array until after memory allocation succeeds,
8275 because xmalloc/xrealloc may not return.
0065d054
PE
8276 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8277 now that we have proper integer overflow checking.
8278 (record_overlay_string, overlay_strings): Catch overflows when
8279 calculating size of overlay_str_buf.
726e0ab1 8280
0065d054
PE
8281 * callproc.c (Fcall_process): Check for size overflow when
8282 calculating size of args2.
8283 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8284 Normally we prefer signed values, but sticking with ptrdiff_t would
8285 require adding more-complicated checks.
726e0ab1
PE
8286
8287 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8288 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8289 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8290 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8291
8292 * character.c (Fstring): Check for size-calculation overflow.
8293
8294 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8295 unnecessary integer overflow. Check for size overflow.
8296 (encode_coding_object): Don't update size until xmalloc succeeds.
8297
8298 * composite.c (get_composition_id): Check for overflow in glyph
8299 length calculations.
8300
8301 Integer and memory overflow fixes for display code.
8302 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8303 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8304 (scrolling_window): Check for overflow in size calculations.
8305 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8306 Don't assume glyph table len fits in int.
8307 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8308 (row_table_size): Now ptrdiff_t, not int.
8309 (scrolling_window): Avoid overflow in size calculations.
8310 Don't update size until allocation succeeds.
8311 * fns.c (concat): Check for overflow in size calculations.
8312 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8313 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8314 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8315
8316 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8317 (get_doc_string): Check for size calculation overflow.
8318 Don't update size until allocation succeeds.
8319 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8320 EMACS_INT, where ptrdiff_t will do.
8321 (Fsubstitute_command_keys): Check for string overflow.
8322
8323 * editfns.c (set_time_zone_rule): Don't assume environment length
8324 fits in int.
8325 (message_length): Now ptrdiff_t, not int.
8326 (Fmessage_box): Don't update size until allocation succeeds.
8327 Don't assume message length fits in int.
8328 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8329
0065d054
PE
8330 * emacs.c (main): Do not reallocate argv, since there is a null at
8331 the end that can be overwritten, and this way there's no need to
8332 worry about size-calculation overflow.
8333 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8334
8335 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8336 alloc succeeds.
8337 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8338
8339 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8340 (x_set_scroll_bar_width, x_figure_window_size):
8341 Check for integer overflow.
8342 (x_set_alpha): Do not assume XINT fits in int.
8343
8344 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8345 This is for the members text_lines, text_cols, total_lines, total_cols,
8346 where the system imposes an 'int' limit.
8347
8348 * fringe.c (Fdefine_fringe_bitmap):
8349 Don't update size until alloc works.
8350
8351 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8352 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8353
8354 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8355 Check for size-calculation overflow.
8356 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8357 do, as we prefer signed integers.
8358 (id_to_widget.max_size, id_to_widget.used)
8359 (xg_store_widget_in_map, xg_remove_widget_from_map)
8360 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8361 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8362 Use and return ptrdiff_t, not int.
8363 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8364 * gtkutil.h: Change prototypes to match the above.
8365
8366 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8367 are duplicate now that they've been promoted to lisp.h.
8368 (x_allocate_bitmap_record, x_alloc_image_color)
8369 (make_image_cache, cache_image, xpm_load):
8370 Don't update size until alloc is done.
8371 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8372 (x_detect_edges):
3256efce 8373 Check for size calculation overflow.
726e0ab1
PE
8374 (ct_colors_allocated_max): New constant.
8375 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8376 overflow.
3256efce 8377
726e0ab1
PE
8378 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8379 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8380 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8381 Use ptrdiff_t, not int, to count maps.
8382 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8383 calculations. Don't update size until allocation succeeds.
8384 Redo calculations to avoid overflow.
726e0ab1
PE
8385 * keyboard.h: Change prototypes to match the above.
8386
8387 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8388 to count maps.
8389 (current_minor_maps): Check for size calculation overflow.
8390 * keymap.h: Change prototypes to match the above.
8391
8392 * lread.c (read1, init_obarray): Don't update size until alloc done.
8393
8394 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8395 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8396
726e0ab1
PE
8397 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8398 Now ptrdiff_t, not int.
8399 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8400 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8401
8402 * process.c (Fnetwork_interface_list): Check for overflow
8403 in size calculation.
8404
8405 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8406
8407 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8408 overflow. Don't bother calling xmalloc when xrealloc will do.
8409
8410 * search.c (Freplace_match): Check for size calculation overflow.
8411 (Fset_match_data): Don't assume list lengths fit in 'int'.
8412
8413 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8414 for command line length. Do not attempt to address one before the
8415 beginning of an array, as that's not portable.
8416
8417 * term.c (max_frame_lines): Remove; unused.
8418 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8419 not int.
8420 (encode_terminal_code, calculate_costs): Check for size
8421 calculation overflow.
8422 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8423 table lengths and related sizes. Don't update size until alloc
8424 done. Redo calculations to avoid overflow.
8425 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8426
8427 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8428 subtracting pointers.
8429 (gobble_line): Check for overflow more carefully. Don't update size
8430 until alloc done.
8431
8432 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8433 Don't update size until alloc done.
8434 Redo size calculations to avoid overflow.
8435 Check for size calculation overflow.
0065d054 8436 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8437
8438 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8439 Use ptrdiff_t, not int, for sizes.
8440 (store_mode_line_noprop_char): Don't update size until alloc done.
8441
0065d054
PE
8442 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8443 Use ptrdiff_t, not int, for sizes.
8444 (Finternal_make_lisp_face, cache_face):
8445 Check for size calculation overflow.
8446 (cache_face): Treat size calculation overflows as if they were
8447 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8448
8449 * xfns.c (x_encode_text, x_set_name_internal)
8450 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8451 sizes, since they can exceed INT_MAX in size. Check for size
8452 calculation overflow.
8453
0065d054
PE
8454 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8455 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8456 Don't update size until alloc done.
8457
0065d054 8458 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8459 as sprintf is limited to int lengths.
1d526e2f 8460
252c5ee1
PE
8461 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8462 (X_LONG_MIN): New macros.
864d7ce7
PE
8463 Use them to make the following changes clearer.
8464 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8465 This change doesn't affect the value now, but it may help remind
8466 future maintainers not to raise the value too much later.
8467 (SELECTION_QUANTUM): Remove, replacing with ...
8468 (selection_quantum): ... new function, which avoids overflow.
8469 All uses changed.
8470 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8471 assumption that selection length fits in 'int'.
8472 (x_reply_selection_request, x_handle_selection_request)
8473 (x_get_window_property, receive_incremental_selection)
8474 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8475 (lisp_data_to_selection_data, clean_local_selection_data):
8476 Use ptrdiff_t, not int, to record length of selection.
8477 (x_reply_selection_request, x_get_window_property)
8478 (receive_incremental_selection, x_property_data_to_lisp):
8479 Redo calculations to avoid overflow.
8480 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8481 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8482 something.
8483 (x_get_window_property, receive_incremental_selection)
8484 (lisp_data_to_selection_data, x_property_data_to_lisp):
8485 Check for size-calculation overflow.
8486 (x_get_window_property, receive_incremental_selection)
8487 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8488 Don't store size until memory allocation succeeds.
8489 (x_get_window_property): Plug memory leak on memory exhaustion.
8490 Don't double-block input; malloc is safe here. Don't assume 2**34
8491 - 4 fits in unsigned long. Add an xassert to check
8492 XGetWindowProperty overflow. Be more careful about overflow
8493 calculations, and distinguish size from memory overflow better.
8494 (receive_incremental_selection): When tracing, don't assume
8495 unsigned int is less than INT_MAX.
8496 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8497 harmful) conversions of unsigned short to int.
8498 (lisp_data_to_selection_data): Don't assume that integers
8499 in the range -65535 through -1 fit in an X unsigned short.
8500 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8501 result parameters unless successful. Rely on cons_to_unsigned
8502 to report problems with elements; the old code wasn't right anyway.
8503 (x_check_property_data): Check for int overflow; we cannot use
8504 a wider type due to X limits.
8505 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8506
726e0ab1 8507 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8508
0065d054
PE
8509 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8510 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8511 (x_color_cells): Don't store size until memory allocation succeeds.
8512 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8513 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8514 (x_term_init): Don't assume length fits in int (sprintf is limited
8515 to int size).
bc18e09d 8516
ebfa62c0
PE
8517 Use ptrdiff_t for composition IDs.
8518 * character.c (lisp_string_width):
8519 * composite.c (composition_table_size, n_compositions)
8520 (get_composition_id, composition_gstring_from_id):
8521 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8522 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8523 * window.c (Frecenter):
8524 Use ptrdiff_t, not int, for composition IDs.
8525 * composite.c (get_composition_id): Check for integer overflow.
8526 * composite.h: Adjust prototypes to match the above changes.
8527
d3411f89
PE
8528 Use ptrdiff_t for hash table indexes.
8529 * category.c (hash_get_category_set):
8530 * ccl.c (ccl_driver):
8531 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8532 * coding.c (coding_system_charset_list, detect_coding_system):
8533 * coding.h (struct coding_system.id):
8534 * composite.c (get_composition_id, gstring_lookup_cache):
8535 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8536 * image.c (xpm_get_color_table_h):
8537 * lisp.h (hash_lookup, hash_put):
8538 * minibuf.c (Ftest_completion):
8539 Use ptrdiff_t for hash table indexes, not int (which is too
8540 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8541 32-bit --with-wide-int hosts).
8542
e097a6fa
PE
8543 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8544 Add a FIXME comment about memory leaks.
8545 (syms_of_charset): Don't assume xmalloc returns.
8546
5637687f
PE
8547 Don't assume that stated character widths fit in int.
8548 * character.c (Fchar_width, c_string_width, lisp_string_width):
8549 * character.h (CHAR_WIDTH):
8550 * indent.c (MULTIBYTE_BYTES_WIDTH):
8551 Use sanitize_char_width to avoid undefined and/or bad behavior
8552 with outlandish widths.
a66cfb1c 8553 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8554 now that we have two such functions. All uses changed.
8555 (sanitize_char_width): New inline function.
8556
a2271ba2
PE
8557 Don't assume that tab-width fits in int.
8558 * character.h (sanitize_width): New inline function.
8559 (SANE_TAB_WIDTH): New macro.
8560 (ASCII_CHAR_WIDTH): Use it.
8561 * indent.c (sane_tab_width): Remove. All uses replaced by
8562 SANE_TAB_WIDTH (current_buffer).
8563 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8564
18c52557
PE
8565 * fileio.c: Integer overflow issues with file modes.
8566 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8567
caeeedc1
PE
8568 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8569 Remove unreachable code.
8570 (read_hex, load_charset_map_from_file): Check for integer overflow.
8571
6df6ae42 8572 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8573 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8574 (x_send_scroll_bar_event): Likewise. Check that the size does not
8575 exceed limits imposed by XClientMessageEvent, as well as the usual
8576 ptrdiff_t and size_t limits.
8577
b13995db
PE
8578 * keyboard.c: Overflow, signedness and related fixes.
8579 (make_lispy_movement): Use same integer type in forward decl
8580 that is used in the definition.
8581 (read_key_sequence, keyremap_step):
8582 Change bufsize argument back to int, undoing my 2011-03-30 change.
8583 We prefer signed types, and int is wide enough here.
8584 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8585 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8586 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8587 length, not size_t. Use ptrdiff_t for index, not int.
8588 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8589 possibility of integer overflow.
8590
13464394
PE
8591 Overflow, signedness and related fixes for images.
8592
8593 * dispextern.h (struct it.stack[0].u.image.image_id)
8594 (struct_it.image_id, struct image.id, struct image_cache.size)
8595 (struct image_cache.used, struct image_cache.ref_count):
8596 * gtkutil.c (update_frame_tool_bar):
8597 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8598 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8599 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8600 * nsmenu.m (update_frame_tool_bar):
8601 * xdisp.c (calc_pixel_width_or_height):
8602 * xfns.c (image_cache_refcount):
8603 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8604 on typical 64-bit hosts.
8605
8606 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8607 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8608 Omit unnecessary casts to int.
8609 (parse_image_spec): Check that integers fall into 'int' range
8610 when the callers expect that.
8611 (image_ascent): Redo ascent calculation to avoid int overflow.
8612 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8613 (lookup_image): Remove unnecessary tests.
8614 (xbm_image_p): Locals are now of int, not EMACS_INT,
8615 since parse_image_check makes sure they fit into int.
8616 (png_load, gif_load, svg_load_image):
8617 Prefer int to unsigned where either will do.
8618 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8619 old tiff_error_handler and tiff_warning_handler.
8620 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8621 stack buffer overflows. It uses only the features of vsnprintf
8622 that are common to both POSIX and native Microsoft.
8623 (tiff_error_handler, tiff_warning_handler): Use it.
8624 (tiff_load, gif_load, imagemagick_load_image):
8625 Don't assume :index value fits in 'int'.
8626 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8627 (imagemagick_load_image): Check that crop parameters fit into
8628 the integer types that MagickCropImage accepts. Don't assume
8629 Vimagemagick_render_type has a nonnegative value. Don't assume
8630 size_t fits in 'long'.
8631 (gs_load): Use printmax_t to print the widest integers possible.
8632 Check for integer overflow when computing image height and width.
8633
c11821d4
EZ
86342011-08-26 Eli Zaretskii <eliz@gnu.org>
8635
8636 * xdisp.c (redisplay_window): Don't force window start if point
8637 will be invisible in the resulting window. (Bug#9324)
8638
0c95fcf7
EZ
86392011-08-25 Eli Zaretskii <eliz@gnu.org>
8640
8641 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8642 the display spec is of the form `(space ...)'.
8643 (handle_display_spec): Return the value returned by
8644 handle_single_display_spec, not just 1 or zero.
8645 (handle_single_display_spec): If the display spec is of the form
8646 `(space ...)', and specifies display in the text area, return 2
8647 rather than 1.
fee65a97 8648 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8649 accurately, and prefer exact match for point under bidi.
8650 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8651
8652 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8653 into disp_prop; all users changed.
8654
8655 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8656 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8657 for the text covered by the display property.
8658
e4ed06f1
CY
86592011-08-25 Chong Yidong <cyd@stupidchicken.com>
8660
8661 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8662 Change return value to nil.
8663 (Frecord_buffer): Delete unused function.
8664
f67cdd7f
EZ
86652011-08-24 Eli Zaretskii <eliz@gnu.org>
8666
5980d4c6
EZ
8667 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8668 buffers, return left-to-right.
8610fe8b
EZ
8669 (set_cursor_from_row): Consider candidate row a win if its glyph
8670 represents a newline and point is on that newline. Fixes cursor
8671 positioning on the newline at EOL of R2L text within L2R
8672 paragraph, and vice versa.
8673 (try_cursor_movement): Check continued rows, in addition to
8674 continuation rows. Fixes unwarranted scroll when point enters a
8675 continued line of R2L text within an L2R paragraph, or vice versa.
8676 (cursor_row_p): Consider the case of point being equal to
8677 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8678 from the end of a short line to the beginning of a continued line
8679 of R2L text within L2R paragraph.
8680 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8681 composed characters.
5980d4c6 8682
f67cdd7f
EZ
8683 * bidi.c (bidi_check_type): Use xassert.
8684 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8685 members.
8686
bca633fb
EZ
86872011-08-23 Eli Zaretskii <eliz@gnu.org>
8688
8689 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8690 a character.
8691
4a5885a7
CY
86922011-08-23 Chong Yidong <cyd@stupidchicken.com>
8693
8694 * nsfont.m (ns_otf_to_script): Fix typo.
8695
0902a04e
KH
86962011-08-22 Kenichi Handa <handa@m17n.org>
8697
8698 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8699 extra slot even if the purpose is char-code-property-table.
8700
1a2e6670
EZ
87012011-08-23 Eli Zaretskii <eliz@gnu.org>
8702
8ddde651
EZ
8703 * xdisp.c (redisplay_window): When computing centering_position,
8704 account for the height of the header line. (Bug#8874)
8705
425cc014
EZ
8706 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8707 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8708 candidate is selected by the mouse, and that candidate has a
8709 composed character under the mouse.
8710
1a2e6670
EZ
8711 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8712 coordinates reported by pos-visible-in-window-p for a composed
8713 character in column zero.
8714
8b76d6f8
SM
87152011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8716
8717 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8718
dac347dd
EZ
87192011-08-22 Eli Zaretskii <eliz@gnu.org>
8720
8721 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8722 consider it a hit if to_charpos is anywhere in the range of the
8723 composed buffer positions.
8724
e013fb34
CY
87252011-08-22 Chong Yidong <cyd@stupidchicken.com>
8726
8727 * image.c (gif_load): Don't assume that each subimage has the same
8728 dimensions as the base image. Handle disposal method that is
8729 "undefined" by the gif spec (Bug#9335).
8730
bd1ba3e8
CY
87312011-08-20 Chong Yidong <cyd@stupidchicken.com>
8732
8733 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8734 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8735
54a1215b
EZ
87362011-08-19 Eli Zaretskii <eliz@gnu.org>
8737
823564e5
EZ
8738 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8739 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8740 from an Org mode buffer to a Speedbar frame.
8741
54a1215b
EZ
8742 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8743 a composition, take its buffer position from IT->cmp_it.charpos.
8744 Fixes cursor positioning at the beginning of a line that begins
8745 with a composed character.
8746
9778ebcc
EZ
87472011-08-18 Eli Zaretskii <eliz@gnu.org>
8748
0be6ee06
EZ
8749 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8750 character bidirectional type, use STRONG_L instead. Fixes crashes
8751 in a buffer produced by `describe-categories'.
8752
9778ebcc
EZ
8753 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8754 members before the level stack, so they would be saved and
8755 restored when copying iterator state. Fixes incorrect reordering
8756 around TABs covered by display properties.
8757
156bffbe
AS
87582011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8759
6b02f655 8760 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8761
72ad093b
CY
87622011-08-17 Chong Yidong <cyd@stupidchicken.com>
8763
8764 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8765 (internal_condition_case_2, internal_condition_case_n):
8766 Remove unnecessary aborts (Bug#9081).
72ad093b 8767
35774242
EZ
87682011-08-17 Eli Zaretskii <eliz@gnu.org>
8769
8770 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8771 has no `load' handler, try opening the file locally. (Bug#9311)
8772
db76dd85
KB
87732011-08-16 Ken Brown <kbrown@cornell.edu>
8774
8775 * gmalloc.c: Expand comment.
8776
b215eee5
EZ
87772011-08-16 Eli Zaretskii <eliz@gnu.org>
8778
8779 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8780 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8781
a4579d33
KB
87822011-08-16 Ken Brown <kbrown@cornell.edu>
8783
8784 Fix memory allocation problems in Cygwin build (Bug#9273).
8785
8786 * unexcw.c ( __malloc_initialized): Declare external variable.
8787 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8788
8b76d6f8
SM
8789 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8790 New variables.
a4579d33
KB
8791 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8792 dumped emacs.
8793 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8794 in the static heap.
8795 [CYGWIN] (special_realloc): New function.
8796 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8797 requests to realloc storage in the static heap.
8798
3ebec551
PE
87992011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8800
8801 * bidi.c (bidi_initialize): Remove unused local.
8802
9fd8be00
EZ
88032011-08-15 Eli Zaretskii <eliz@gnu.org>
8804
6b02f655
SM
8805 * bidimirror.h:
8806 * biditype.h: Remove file.
8807 * makefile.w32-in ($(BLD)/bidi.$(O)):
8808 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8809
8810 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8811
8812 * chartab.c: Improve commentary for the uniprop_table API.
8813
32413314
EZ
8814 * bidi.c (bidi_paragraph_init): Support zero value of
8815 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8816 (bidi_initialize): Use uniprop_table instead of including
8817 biditype.h and bidimirror.h.
32413314 8818
9fd8be00
EZ
8819 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8820 coordinates of the iterator when restoring from ppos_it.
8821 (Bug#9296)
8822
5cf2b69b
KH
88232011-08-14 Kenichi Handa <handa@m17n.org>
8824
8825 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8826 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8827
daf17d00
EZ
88282011-08-14 Eli Zaretskii <eliz@gnu.org>
8829
8830 * xdisp.c (move_it_in_display_line_to): Don't invoke
8831 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8832 ppos_it. Fixes vertical cursor motion when line beginning is
8833 covered by an image. (Bug#9296)
8834
08e3161a
JD
88352011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8836
8837 * nsterm.h (ns_run_ascript): Declare.
8838 (NSAPP_DATA2_RUNASSCRIPT): Define.
8839
8840 * nsfns.m (as_script, as_result, as_status): New static variables.
8841 (ns_run_ascript): New function.
5e617bc2 8842 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8843 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8844 the event loop. Get status from as_status (Bug#7276).
8845
8846 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8847 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8848 the event loop (Bug#7276).
8849
a3720aa2
AS
88502011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8851
8852 * gnutls.c (QCgnutls_bootprop_priority)
8853 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8854 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8855 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8856 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8857 (QCgnutls_bootprop_verify_hostname_error)
8858 (QCgnutls_bootprop_callbacks_verify): Rename from
8859 Qgnutls_bootprop_..., all uses changed.
8860
8861 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8862 uses changed.
8863
0a0d27fb
PE
88642011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8865
19d5c50c
PE
8866 * xfaces.c (Qframe_set_background_mode): Now static.
8867 * dispextern.h (Qframe_set_background_mode): Remove decl.
8868
0a0d27fb
PE
8869 * process.c (Fnetwork_interface_info): Declare local only if needed.
8870
377538cb
JD
88712011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8872
8873 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8874 (Fnetwork_interface_list): Allocate in increments of bytes instead
8875 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8876 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8877 sockaddr.
8878 (struct ifflag_def): notrailers is smart on OSX.
8879 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8880 Get hardware address with getifaddrs if available.
8881
08fff70c
EZ
88822011-08-12 Eli Zaretskii <eliz@gnu.org>
8883
8884 * xdisp.c (iterate_out_of_display_property): xassert that
8885 IT->position is set to within IT->object's boundaries. Break from
8886 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8887 when IT->position is set up wrongly due to some bug.
8888 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8889 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8890 entry. Force push_it to save on the stack the current
8891 buffer/string position, to be restored by pop_it. Fix flags in
8892 the iterator structure wrt the object coming from a display
8893 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8894 properties. (Bug#9284)
8895
7be1c708 88962011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8897
7be1c708
CY
8898 * fontset.c (fontset_get_font_group): Add proper type checks.
8899 (Bug#9172)
aac0c6e3 8900
7be1c708 89012011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8902
7be1c708
CY
8903 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8904 and LC_VERSION_MIN_MACOSX.
8905 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8906 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8907
97bb72a6
EZ
89082011-08-08 Eli Zaretskii <eliz@gnu.org>
8909
8910 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8911 no-display-properties-and-no-overlays under bidi display.
8912 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8913 properties and overlays.
97bb72a6 8914
d5617611
CY
89152011-08-08 Chong Yidong <cyd@stupidchicken.com>
8916
37e11a63
CY
8917 * editfns.c (Fset_time_zone_rule): Document relationship with the
8918 setenv function.
8919
d5617611
CY
8920 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8921 the font entity extracted from the cache (Bug#8109).
8922
58872834
CY
89232011-08-07 Chong Yidong <cyd@stupidchicken.com>
8924
8925 * composite.c (autocmp_chars): Don't reset point. That is done by
8926 restore_point_unwind (Bug#5984).
8927
75bfc667
JL
89282011-08-07 Juri Linkov <juri@jurta.org>
8929
8930 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8931 to show the arg `TIME' instead of `TIMEVAL'.
8932
d1410150
EZ
89332011-08-06 Eli Zaretskii <eliz@gnu.org>
8934
8935 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8936 display property strides EOL and includes a newline, as in
8937 longlines-mode. (Bug#9254)
75b771e4
EZ
8938 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8939 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8940
8941 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8942 is non-zero, even if the data buffer is NULL. Fixes a crash in
8943 vertical-motion with longlines-mode. (Bug#9254)
8944
35928349
EZ
89452011-08-05 Eli Zaretskii <eliz@gnu.org>
8946
ec7cc85b
EZ
8947 * bidi.c <bidi_cache_total_alloc>: Now static.
8948 (bidi_initialize): Initialize bidi_cache_total_alloc.
8949
8b76d6f8 8950 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8951 cache. (Bug#9221)
8952
8953 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8954 amount allocated this far in `bidi_cache_total_alloc'.
8955 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8956 non-zero, only free the data buffer without restoring the cache
8957 contents. All callers changed.
8958
8959 * dispextern.h (bidi_unshelve_cache): Update prototype.
8960
8961 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8962 (move_it_in_display_line, move_it_to)
8963 (move_it_vertically_backward, move_it_by_lines): Replace the call
8964 to xfree to an equivalent call to bidi_unshelve_cache.
8965 (move_it_in_display_line_to): Fix logic of returning
412b6358 8966 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8967
e2e2423b
EZ
89682011-08-05 Eli Zaretskii <eliz@gnu.org>
8969
8970 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8971 came from a string character with a `cursor' property. (Bug#9229)
8972
ae9e757a
JD
89732011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8974
8975 * Makefile.in (LIB_PTHREAD): New variable.
8976 (LIBES): Add LIB_PTHREAD (Bug#9216).
8977
8978 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8979 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8980
213bd7f2
AS
89812011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8982
6b02f655 8983 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8984
99aaf75f
JD
89852011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8986
8987 * xterm.c (x_find_topmost_parent): New function.
8988 (x_set_frame_alpha): Find topmost parent window with
8989 x_find_topmost_parent and set the property there also (bug#9181).
8990 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8991
c74e9d86
PE
89922011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8993
8994 * callproc.c (Fcall_process): Avoid vfork clobbering
8995 the local vars buffer, coding_systems, current_dir.
8996
640c8776
SM
89972011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8998
8999 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9000
f26d0e4c
PE
90012011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9002
8a10d76c
PE
9003 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9004 so that it is not optimized away.
9005
f26d0e4c
PE
9006 * xdisp.c (compute_display_string_pos): Remove unused local.
9007
55439c61
EZ
90082011-08-02 Eli Zaretskii <eliz@gnu.org>
9009
9010 Fix slow cursor motion and scrolling in large buffers with
9011 selective display, like Org Mode buffers. (Bug#9218)
9012
9013 * dispextern.h (struct bidi_it): New member disp_prop_p.
9014
9015 * xdisp.c: Remove one-slot cache of display string positions.
9016 (compute_display_string_pos): Accept an additional argument
5e617bc2 9017 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9018 for a display string or property. If found, set DISP_PROP_P
9019 non-zero.
9020
9021 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9022 DISP_PROP_P, and pass it to compute_display_string_pos.
9023 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9024 non-zero. All callers of bidi_fetch_char changed.
9025
fb33fa43
SM
90262011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9027
9028 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9029
b099e063
DM
90302010-12-03 Don March <don@ohspite.net>
9031
9032 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9033 last character M-[char] is translated to ESC [char] (bug#7541).
9034
5cc7f7af
KH
90352011-08-02 Kenichi Handa <handa@m17n.org>
9036
d0fffa3f 9037 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9038
9039 * chartab.c (uniprop_table): Make it non-static.
9040
525d5e6e
EZ
90412011-08-01 Eli Zaretskii <eliz@gnu.org>
9042
9043 * xdisp.c (forward_to_next_line_start): Accept additional argument
9044 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9045 on the newline.
9046 (reseat_at_next_visible_line_start): Use the bidi iterator state
9047 returned by forward_to_next_line_start to restore the state of
9048 it->bidi_it after backing up to previous newline. (Bug#9212)
9049
31011111
AS
90502011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9051
9052 * regex.c (re_comp): Protoize.
9053 (re_exec): Fix return type.
9054 (regexec): Fix type of `ret'. (Bug#9203)
9055
476371c4
PE
90562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9057
e5d76069
PE
9058 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9059 This is needed if max-image-size is a floating-point number.
9060
9a79b20c
AS
90612011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9062
9063 * print.c (print_object): Print empty symbol as ##.
9064
9065 * lread.c (read1): Read ## as empty symbol.
9066
d8c2fa78
AA
90672011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9068
9069 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9070 setting frame foreground color (Bug#9175).
9071 (x_set_background_color): Likewise.
9072
ffe57a7a
AA
9073 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9074 contents (Bug#9176).
9075 (EmacsTooltip -init): Remove bezels and add shadows to
9076 tooltip windows.
9077
bf3492a5
AA
9078 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9079 or scroll bar (Bug#8470).
9080
d55e9c53
AA
9081 * nsfont.m (nsfont_open): Remove assignment to voffset and
9082 unnecessary vars hshink, expand, hd, full_height, min_height.
9083 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9084
9085 * nsterm.h (nsfont_info): Remove voffset field.
9086
d8c2fa78 90872011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9088
9089 Implement strike-through and overline on NextStep (Bug#8863).
9090
9091 * nsfont.m (nsfont_open): Use underline position provided by font,
9092 instead of hard-coded value of 2.
9093 (nsfont_draw): Call ns_draw_text_decoration instead.
9094
9095 * nsterm.h: Add declaration for ns_draw_text_decoration.
9096
9097 * nsterm.m (ns_draw_text_decoration): New function for drawing
9098 underline, overline, and strike-through.
9099 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9100 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9101 accommodate underlining, etc.
4843aac3 9102
4cc60b9b
EZ
91032011-07-28 Eli Zaretskii <eliz@gnu.org>
9104
bc7ece87
EZ
9105 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9106 default.
4cc60b9b 9107
476371c4
PE
91082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9109
66606eea
PE
9110 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9111 Without this fix, if a signal arrives just after memory fills up,
9112 'malloc' might be invoked reentrantly.
9113
476371c4
PE
9114 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9115 In other words, assume that every image size is allowed, on non-X
9116 hosts. This assumption is probably wrong, but it lets Emacs compile.
9117
f3fcc40d
AS
91182011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9119
9120 * regex.c (re_iswctype): Convert return values to boolean.
9121
350c992f
EZ
91222011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9123
9124 * xdisp.c (compute_display_string_pos): Don't use cached display
9125 string position if the buffer had its restriction changed.
9126 (Bug#9184)
9127
5266b4bb
PE
91282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9129
9130 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9131
2573a837 91322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9133
41f55ccd 9134 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9135
39e378da
PE
9136 * bidi.c: Integer size and overflow fixes.
9137 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9138 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9139 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9140 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9141 (bidi_find_other_level_edge):
9142 Use ptrdiff_t instead of EMACS_INT where either will do.
9143 This works better on 32-bit hosts configured --with-wide-int.
9144 (bidi_cache_ensure_space): Check for size-calculation overflow.
9145 Use % rather than repeated addition, for better worst-case speed.
9146 Don't set bidi_cache_size until after xrealloc returns, because it
9147 might not return.
9148 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9149 (bidi_cache_ensure_space): Also check that the bidi cache size
9150 does not exceed that of the largest Lisp string or buffer. See Eli
9151 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9152
5e927815
PE
9153 * alloc.c (__malloc_size_t): Remove.
9154 All uses replaced by size_t. See Andreas Schwab's note
9155 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9156
ca4aa935
PE
9157 * image.c: Improve checking for integer overflow.
9158 (check_image_size): Assume that f is nonnull, since
9159 it is always nonnull in practice. This is one less thing to
9160 worry about when checking for integer overflow later.
9161 (x_check_image_size): New function, which checks for integer
9162 overflow issues inside X.
9163 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9164 This removes the need for a memory_full check.
9165 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9166 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9167 (xbm_read_bitmap_data): Change locals back to 'int', since
9168 their values must fit in 'int'.
9169 (xpm_load_image, png_load, tiff_load):
9170 Invoke x_create_x_image_and_pixmap earlier,
9171 to avoid much needless work if the image is too large.
9172 (tiff_load): Treat overly large images as if
9173 x_create_x_image_and_pixmap failed, not as malloc failures.
9174 (gs_load): Use x_check_image_size.
9175
5f8f9cc2
PE
9176 * gtkutil.c: Omit integer casts.
9177 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9178 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9179
5adf60bc
PE
9180 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9181
c8907a93
PE
9182 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9183 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9184 would wrongly return t on a 64-bit host.
9185
e3c25c68
PE
9186 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9187 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9188 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9189 and therefore cause GCC to emit a bogus diagnostic in some cases.
9190
3f791afe
PE
9191 * image.c: Integer signedness and overflow and related fixes.
9192 This is not an exhaustive set of fixes, but it's time to
9193 record what I've got.
9194 (lookup_pixel_color, check_image_size): Remove redundant decls.
9195 (check_image_size): Don't assume that arbitrary EMACS_INT values
9196 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9197 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9198 (tiff_load, imagemagick_load_image):
9199 Check for overflow in size calculations.
9200 (x_create_x_image_and_pixmap): Remove unnecessary test for
9201 xmalloc returning NULL; that can't happen.
9202 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9203 (xpm_color_bucket): Use better integer hashing function.
9204 (xpm_cache_color): Don't possibly over-allocate memory.
9205 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9206 (gif_memory_source):
9207 Use ptrdiff_t, not int or size_t, to record sizes.
9208 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9209 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9210 either works, as we prefer signed integers.
9211 (tiff_read_from_memory, tiff_write_from_memory):
9212 Return tsize_t, not size_t, since that's what the TIFF API wants.
9213 (tiff_read_from_memory): Don't fail simply because the read would
9214 go past EOF; instead, return a short read.
9215 (tiff_load): Omit no-longer-needed casts.
9216 (Fimagemagick_types): Don't assume size fits into 'int'.
9217
3cc5a532
PE
9218 Improve hashing quality when configured --with-wide-int.
9219 * fns.c (hash_string): New function, taken from sxhash_string.
9220 Do not discard information about ASCII character case; this
9221 discarding is no longer needed.
9222 (sxhash-string): Use it. Change sig to match it. Caller changed.
9223 * lisp.h: Declare it.
9224 * lread.c (hash_string): Remove, since we now use fns.c's version.
9225 The fns.c version returns a wider integer if --with-wide-int is
9226 specified, so this should help the quality of the hashing a bit.
9227
b312a492
PE
9228 * emacs.c: Integer overflow minor fix.
9229 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9230 Define only if GNU_LINUX.
9231 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9232
dfd153ae
PE
9233 * dispnew.c: Integer signedness and overflow fixes.
9234 Remove unnecessary forward decls, that were a maintenance hassle.
9235 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9236 All uses changed.
9237 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9238 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9239 (prepare_desired_row, line_draw_cost):
9240 Use int, not unsigned, where either works.
9241 (save_current_matrix, restore_current_matrix):
9242 Use ptrdiff_t, not size_t, where either works.
9243 (init_display): Check for overflow more accurately, and without
9244 relying on undefined behavior.
9245
a81d11a3
PE
9246 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9247 Remove, replacing with the new symbols in lisp.h. All uses changed.
9248 * fileio.c (make_temp_name):
9249 * filelock.c (lock_file_1, lock_file):
9250 * xdisp.c (message_dolog):
9251 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9252 Use pMd etc. instead.
9253 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9254 replacing the pWIDE etc. symbols removed from editfns.c.
9255
3300e6fd
PE
9256 * keyboard.h (num_input_events): Now uintmax_t.
9257 This is (very slightly) less likely to mess up due to wraparound.
9258 All uses changed.
9259
fd05c7e9
PE
9260 * buffer.c: Integer signedness fixes.
9261 (alloc_buffer_text, enlarge_buffer_text):
9262 Use ptrdiff_t rather than size_t when either will do, as we prefer
9263 signed integers.
9264
903fe15d
PE
9265 * alloc.c: Integer signedness and overflow fixes.
9266 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9267 (__malloc_size_t): Default to size_t, not to int.
9268 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9269 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9270 Prefer ptrdiff_t to size_t when either would do, as we prefer
9271 signed integers.
9272 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9273 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9274 Now const. Initialize with values that are in range even if char
9275 is signed.
9276 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9277 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9278 These functions do the right thing with sizes > 2**32.
9279 (check_depth): Now ptrdiff_t, not int.
9280 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9281 Adjust to new way of storing sizes. Check for size overflow bugs
9282 in rest of code.
9283 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9284 slightly wrong anyway, as it missed one instance of
9285 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9286 (refill_memory_reserve): Omit needless cast to size_t.
9287 (mark_object_loop_halt): Mark as externally visible.
9288
ac82cc6a
PE
9289 * xselect.c: Integer signedness and overflow fixes.
9290 (Fx_register_dnd_atom, x_handle_dnd_message):
9291 Use ptrdiff_t, not size_t, since we prefer signed.
9292 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9293 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9294 x_dnd_atoms_size and x_dnd_atoms_length.
9295
c2d1e36d
PE
9296 * doprnt.c: Prefer signed to unsigned when either works.
9297 * eval.c (verror):
9298 * doprnt.c (doprnt):
9299 * lisp.h (doprnt):
9300 * xdisp.c (vmessage):
9301 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9302 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9303 prefer signed arithmetic to avoid comparison confusion.
9304 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9305 but is a bit tricky.
9306
0e926e56
PE
9307 Assume freestanding C89 headers, string.h, stdlib.h.
9308 * data.c, doprnt.c, floatfns.c, print.c:
9309 Include float.h unconditionally.
9310 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9311 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9312 * regex.c: Likewise for stddef.h, string.h.
9313 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9314 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9315 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9316 (STDC_HEADERS): Remove obsolete defines.
9317 * sysdep.c: Include limits.h unconditionally.
9318
9cfdb3ec
PE
9319 Assume support for memcmp, memcpy, memmove, memset.
9320 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9321 * regex.c (memcmp, memcpy):
9322 Remove; we assume C89 now.
9323
9324 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9325 (__malloc_safe_bcopy): Remove; no longer needed.
9326
cf950e6b 9327 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9328 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9329 well either way, and we prefer signed to unsigned.
9330
dbf38e02
LMI
93312011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9332
9333 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9334 closes the connection while we're reading (bug#9182).
9335
d6f0886c 93362011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9337
d6f0886c
JD
9338 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9339 are specified (Bug#9168).
24e0f6b1 9340
2eb1f9e6
PE
93412011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9342
9343 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9344 Found by GCC static checking and --with-wide-int on a 32-bit host.
9345
22381272 93462011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9347
9348 * xdisp.c (compute_display_string_pos): Fix logic of caching
9349 previous display string position. Initialize cached_prev_pos to
9350 -1. Fixes slow-down at the beginning of a buffer.
9351
f25e39b4
EZ
93522011-07-24 Eli Zaretskii <eliz@gnu.org>
9353
9354 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9355 for attrs[LFACE_FONTSET_INDEX].
9356
04c4b52e
PE
93572011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9358
9359 * xml.c (parse_region): Remove unused local
9360 that was recently introduced.
9361
c1734fbd
EZ
93622011-07-23 Eli Zaretskii <eliz@gnu.org>
9363
be18c5a5
EZ
9364 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9365 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9366
c1734fbd
EZ
9367 * xdisp.c (move_it_in_display_line_to): Record the best matching
9368 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9369 exit if none of the characters scanned was an exact match.
9370 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9371 when exact match is impossible due to invisible text, and the
9372 lines are truncated.
9373
a258d627
JD
93742011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9375
9376 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9377 for OSX >= 10.7.
9378
b6d5a689
EZ
93792011-07-22 Eli Zaretskii <eliz@gnu.org>
9380
0f74f785
EZ
9381 Fix a significant slow-down of cursor motion with C-n, C-p,
9382 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9383 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9384 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9385 (next_element_from_buffer): Call compute_stop_pos_backwards to
9386 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9387 base_level_stop.
9388 (reseat): Don't look for prev_stop, as that could mean a very long
9389 run.
9390 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9391 <cached_disp_overlay_modiff>: Cache for last found display string
9392 position.
551918c1 9393 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9394 about the same buffer in the same area of character positions, and
9395 the buffer wasn't changed since the time the display string
9396 position was cached.
551918c1 9397
b2d0c91a
EZ
93982011-07-22 Eli Zaretskii <eliz@gnu.org>
9399
9400 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9401 is an integer, which is important for empty lines. (Bug#9149)
9402
043604ee
CY
94032011-07-22 Chong Yidong <cyd@stupidchicken.com>
9404
9405 * frame.c (Fmodify_frame_parameters): In tty case, update the
9406 default face if necessary (Bug#4238).
9407
da4adb04
CY
94082011-07-21 Chong Yidong <cyd@stupidchicken.com>
9409
9410 * editfns.c (Fstring_to_char): No need to explain what a character
9411 is in the docstring (Bug#6576).
9412
9abd0532
LMI
94132011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9414
9415 * xml.c (parse_region): Make sure we always return a tree.
9416
36881d16
HK
94172011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9418
9419 * xml.c (parse_region): If a document contains only comments,
9420 return that, too.
9421
1e98674d
LMI
94222011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9423
9424 * xml.c (make_dom): Return comments, too.
9425
590bd467
PE
94262011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9427
9428 Port to OpenBSD.
9429 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9430 and the surrounding thread.
9431 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9432 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9433 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9434 timer goes off.
9435 * s/openbsd.h (BROKEN_SIGIO): Define.
9436 * unexelf.c (unexec) [__OpenBSD__]:
9437 Don't update the .mdebug section of the Alpha COFF symbol table.
9438
f41628b2
LMI
94392011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9440
9441 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9442 (bug#8460).
9443
b59b67c5
PE
94442011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9445
15e3a074
PE
9446 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9447 This fixes some race conditions on the permissions of any newly
9448 created file.
9449
41bed37d
PE
9450 * alloc.c (valid_pointer_p): Use pipe, not open.
9451 This fixes some permissions issues when debugging.
9452
b59b67c5
PE
9453 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9454 If fchown fails to set both uid and gid, try to set just gid,
9455 as that is sometimes allowed. Adjust the file's mode to eliminate
9456 setuid or setgid bits that are inappropriate if fchown fails.
9457
925a6be7
SM
94582011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9459
9460 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9461 to compare Lisp_Objects.
9462 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9463 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9464 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9465
52968808
AS
94662011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9467
0a6a104b
AS
9468 * lread.c (read_integer): Unread even EOF character.
9469 (read1): Likewise. Properly record start position of symbol.
9470
52968808
AS
9471 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9472 symbol character follows.
9473
9e381cdd
PE
94742011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9475
9476 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9477 This works around a problem with the previous change to Fcopy_file.
9478 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9479 and without this change, GCC might complain about discarding
9480 fchown's return value.
9481
b5641435
JB
94822011-07-16 Juanma Barranquero <lekktu@gmail.com>
9483
9484 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9485
a8031457
PE
94862011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9487
9488 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9489
dd889327
LMI
94902011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9491
750c33f7
LMI
9492 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9493 it's used from the C level.
9494
dd889327
LMI
9495 * process.c: Use the same condition for POLL_FOR_INPUT in both
9496 keyboard.c and process.c (bug#1858).
9497
87e86684
LM
94982011-07-09 Lawrence Mitchell <wence@gmx.li>
9499
9500 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9501 (Fgnutls_boot): Use it.
9502
64348f40
AS
95032011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9504
9505 * doc.c (Fsubstitute_command_keys): Revert last change.
9506
1d698799
LMI
95072011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9508
f863868c
LMI
9509 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9510 quotes the next character, and doesn't affect other longer
9511 sequences (bug#8935).
9512
1d698799
LMI
9513 * lread.c (syms_of_lread): Clarify that is isn't only
9514 `eval-buffer' and `eval-defun' that's affected by
9515 `lexical-binding' (bug#8460).
9516
aa4b6df6
EZ
95172011-07-15 Eli Zaretskii <eliz@gnu.org>
9518
9519 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9520 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9521
5d856da6
PE
95222011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9523
ad6042bb
PE
9524 Fix minor problems found by static checking.
9525 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9526 (elsz): Now a signed constant, not a size_t var. We prefer signed
9527 types to unsigned, to avoid integer comparison confusion. Without
9528 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9529 "cannot optimize loop, the loop counter may overflow", a symptom
9530 of the confusion.
f00bbb22 9531 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9532 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9533
6468f31c
LMI
95342011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9535
49080b10
LMI
9536 * search.c (Fre_search_backward): Mention `case-fold-search' in
9537 all the re_search_* functions (bug#8138).
9538
6468f31c
LMI
9539 * keyboard.c (Fopen_dribble_file): Document when the file is
9540 closed (bug#8056).
9541
c965adc5
EZ
95422011-07-14 Eli Zaretskii <eliz@gnu.org>
9543
df9733bf
EZ
9544 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9545 bidi_cache_idx.
9546
0bb23927
EZ
9547 Support bidi reordering of display and overlay strings.
9548 * xdisp.c (compute_display_string_pos)
9549 (compute_display_string_end): Accept additional argument STRING.
9550 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9551 (reseat_to_string): Initialize bidi_it->string.s and
9552 bidi_it->string.schars.
9553 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9554 NULL (avoids a crash in bidi_paragraph_init).
9555 Initialize itb.string.lstring.
0bb23927
EZ
9556 (init_iterator): Call bidi_init_it only of a valid
9557 buffer position was specified. Initialize paragraph_embedding to
9558 L2R.
9559 (reseat_to_string): Initialize the bidi iterator.
9560 (display_string): If we need to ignore text properties of
9561 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9562 original value of -1 will not work with bidi.)
9563 (compute_display_string_pos): First arg is now struct
9564 `text_pos *'; all callers changed. Support display properties on
9565 Lisp strings.
9566 (compute_display_string_end): Support display properties on Lisp
9567 strings.
9568 (init_iterator, reseat_1, reseat_to_string): Initialize the
9569 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9570 when iterating on a string not from display properties).
640c8776
SM
9571 (compute_display_string_pos, compute_display_string_end):
9572 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9573 arrow keys.
9574 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9575 base_level_stop; instead, set base_level_stop to BEGV.
9576 Fixes crashes in vertical-motion.
0bb23927
EZ
9577 (next_element_from_buffer): Improve commentary for when
9578 the iterator is before prev_stop.
9579 (init_iterator): Initialize bidi_p from the default value of
9580 bidi-display-reordering, not from buffer-local value. Use the
9581 buffer-local value only if initializing for buffer iteration.
9582 (handle_invisible_prop): Support invisible properties on strings
9583 that are being bidi-reordered.
9584 (set_iterator_to_next): Support bidi reordering of C strings and
9585 Lisp strings.
9586 (next_element_from_string): Support bidi reordering of Lisp
9587 strings.
9588 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9589 (display_string): Support display of R2L glyph rows.
9590 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9591 (init_iterator): Don't initialize it->bidi_p for strings
9592 here.
9593 (reseat_to_string): Initialize it->bidi_p for strings here.
9594 (next_element_from_string, next_element_from_c_string)
9595 (next_element_from_buffer): Add xassert's for correspondence
9596 between IT's object being iterated and it->bidi_it.string
9597 structure.
9598 (face_before_or_after_it_pos): Support bidi iteration.
9599 (next_element_from_c_string): Handle the case of the first string
9600 character that is not the first one in the visual order.
9601 (get_visually_first_element): New function, refactored from common
9602 parts of next_element_from_buffer, next_element_from_string, and
9603 next_element_from_c_string.
9604 (tool_bar_lines_needed, redisplay_tool_bar)
9605 (display_menu_bar): Force left-to-right direction. Add a FIXME
9606 comment for making that be controlled by a user option.
9607 (push_it, pop_it): Save and restore the state of the
9608 bidi iterator. Save and restore the bidi_p flag.
9609 (pop_it): Iterate out of display property for string iteration as
9610 well.
9611 (iterate_out_of_display_property): Support iteration over strings.
9612 (handle_single_display_spec): Set up it->bidi_it for iteration
9613 over a display string, and call bidi_init_it.
9614 (handle_single_display_spec, next_overlay_string)
9615 (get_overlay_strings_1, push_display_prop): Set up the bidi
9616 iterator for displaying display or overlay strings.
9617 (forward_to_next_line_start): Don't use the shortcut if
9618 bidi-iterating.
9619 (back_to_previous_visible_line_start): If handle_display_prop
9620 pushed the iterator stack, restore the internal state of the bidi
9621 iterator by calling bidi_pop_it same number of times.
9622 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9623 and we are bidi-iterating, don't decrement the iterator position;
9624 instead, set the first_elt flag in the bidi iterator, to produce
9625 the same effect.
9626 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9627 (push_display_prop): xassert that we are iterating a buffer.
9628 (push_it, pop_it): Save and restore paragraph_embedding member.
9629 (handle_single_display_spec, next_overlay_string)
9630 (get_overlay_strings_1, reseat_1, reseat_to_string)
9631 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9632 correctly. Don't assume unibyte strings are not bidi-reordered.
9633 (compute_display_string_pos)
9634 (compute_display_string_end): Fix handling the case of C string.
9635 (push_it, pop_it): Save and restore from_disp_prop_p.
9636 (handle_single_display_spec, push_display_prop): Set the
9637 from_disp_prop_p flag.
9638 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9639 (pop_it): Call iterate_out_of_display_property only if we are
9640 popping after iteration over a string that came from a display
9641 property. Fix a typo in popping stretch info. Add an assertion
9642 for verifying that the iterator position is in sync with the bidi
9643 iterator.
9644 (handle_single_display_spec, get_overlay_strings_1)
9645 (push_display_prop): Fix initialization of paragraph direction for
9646 string when that of the parent object is not yet determined.
9647 (reseat_1): Call bidi_init_it to resync the bidi
9648 iterator with IT's position. (Bug#7616)
9649 (find_row_edges): If ROW->start.pos gives position
9650 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9651 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9652 Reset the from_disp_prop_p flag.
9653 (SAVE_IT, RESTORE_IT): New macros.
9654 (pos_visible_p, face_before_or_after_it_pos)
9655 (back_to_previous_visible_line_start)
9656 (move_it_in_display_line_to, move_it_in_display_line)
9657 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9658 (try_scrolling, redisplay_window, display_line): Use them when
9659 saving a temporary copy of the iterator and restoring it back.
9660 (back_to_previous_visible_line_start, reseat_1)
9661 (init_iterator): Empty the bidi cache "stack".
9662 (move_it_in_display_line_to): If iterator ended up at
9663 EOL, but we never saw any buffer positions smaller than
9664 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9665 motion in bidi-reordered lines.
9666 (move_it_in_display_line_to): Record prev_method and prev_pos
9667 immediately before the call to set_iterator_to_next. Fixes cursor
9668 motion in bidi-reordered lines with stretch glyphs and strings
9669 displayed in margins. (Bug#8133) (Bug#8867)
9670 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9671 TO_CHARPOS.
640c8776
SM
9672 (pos_visible_p): Support positions in bidi-reordered lines.
9673 Save and restore bidi cache.
0bb23927
EZ
9674
9675 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9676 (bidi_paragraph_info): Delete unused struct.
9677 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9678 (bidi_cache_start): New variable.
9679 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9680 to zero.
9681 (bidi_cache_fetch_state, bidi_cache_search)
9682 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9683 (bidi_cache_find, bidi_peek_at_next_level)
9684 (bidi_level_of_next_char, bidi_find_other_level_edge)
9685 (bidi_move_to_visually_next): Compare cache index with
9686 bidi_cache_start rather than with zero.
9687 (bidi_fetch_char): Accept new argument STRING; all callers
9688 changed. Support iteration over a string. Support strings with
9689 display properties. Support unibyte strings. Fix the type of
9690 `len' according to what STRING_CHAR_AND_LENGTH expects.
9691 (bidi_paragraph_init, bidi_resolve_explicit_1)
9692 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9693 (bidi_level_of_next_char, bidi_move_to_visually_next):
9694 Support iteration over a string.
0bb23927
EZ
9695 (bidi_set_sor_type, bidi_resolve_explicit_1)
9696 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9697 can now be zero (for strings); special values 0 and -1 were
9698 changed to -1 and -2, respectively.
9699 (bidi_char_at_pos): New function.
9700 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9701 Call it instead of FETCH_MULTIBYTE_CHAR.
9702 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9703 initialized to valid values.
9704 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9705 values.
9706 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9707 the test for valid cached positions. Fix the logic for looking up
9708 the sentinel state in the cache. GCPRO the Lisp string we are
9709 iterating.
9710 (bidi_push_it, bidi_pop_it): New functions.
9711 (bidi_initialize): Initialize the bidi cache start stack pointer.
9712 (bidi_cache_ensure_space): New function, refactored from part of
9713 bidi_cache_iterator_state. Don't assume the required size is just
9714 one BIDI_CACHE_CHUNK away.
9715 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9716 (bidi_count_bytes, bidi_char_at_pos): New functions.
9717 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9718 always valid if bidi_cache_idx is valid.
9719 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9720 is valid if it's going to be used.
9721 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9722 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9723 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9724 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9725 (bidi_find_other_level_edge, bidi_cache_start_stack):
9726 All variables related to cache indices are now EMACS_INT.
c965adc5 9727
0bb23927
EZ
9728 * dispextern.h (struct bidi_string_data): New structure.
9729 (struct bidi_it): New member `string'. Make flag members be 1-bit
9730 fields, and put them last in the struct.
640c8776
SM
9731 (compute_display_string_pos, compute_display_string_end):
9732 Update prototypes.
0bb23927
EZ
9733 (bidi_push_it, bidi_pop_it): Add prototypes.
9734 (struct iterator_stack_entry): New members bidi_p,
9735 paragraph_embedding, and from_disp_prop_p.
9736 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9737 (bidi_shelve_cache, bidi_unshelve_cache):
9738 Declare prototypes.
0bb23927
EZ
9739
9740 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9741 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9742 and vector-like objects.
9743
9744 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9745 cache around display iteration.
9746
9747 * window.c (Fwindow_end, window_scroll_pixel_based)
9748 (displayed_window_lines, Frecenter): Save and restore the bidi
9749 cache around display iteration.
9750
3bbd2265
LMI
97512011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9752
9753 * editfns.c (Fdelete_region): Clarify the use of the named
9754 parameters (bug#6788).
9755
adc47434
MR
97562011-07-14 Martin Rudalics <rudalics@gmx.at>
9757
9758 * indent.c (Fvertical_motion): Set and restore w->pointm when
9759 saving and restoring the window's buffer (Bug#9006).
9760
837c31f8
LMI
97612011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9762
9763 * editfns.c (Fstring_to_char): Clarify just what is returned
9764 (bug#6576). Text by Eli Zaretskii.
9765
ac389d0c
JB
97662011-07-13 Juanma Barranquero <lekktu@gmail.com>
9767
9768 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9769
0be0ce47
EZ
97702011-07-13 Eli Zaretskii <eliz@gnu.org>
9771
9772 * buffer.c (mmap_find): Fix a typo.
9773
cd18e7e3
JB
97742011-07-13 Johan Bockgård <bojohan@gnu.org>
9775
9776 Fix execution of x selection hooks.
9777 * xselect.c (Qx_lost_selection_functions)
9778 (Qx_sent_selection_functions): New vars.
9779 (syms_of_xselect): DEFSYM them.
9780 (x_handle_selection_request): Pass Qx_sent_selection_functions
9781 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9782 (x_handle_selection_clear,x_clear_frame_selections):
9783 Pass Qx_lost_selection_functions rather than
9784 Vx_lost_selection_functions to Frun_hook_with_args.
9785
47ea7f44
PE
97862011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9787
ac389d0c 9788 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9789 The old code sometimes used this field without initializing it.
9790
47ea7f44
PE
9791 * alloc.c (gc_sweep): Don't read past end of array.
9792 In theory, the old code could also have corrupted Emacs internals,
9793 though it'd be very unlikely.
9794
bc985c87
AS
97952011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9796
9797 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9798 argument. (Bug#4026)
bc985c87 9799
0cf34688
LMI
98002011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9801
b3dadd76
LMI
9802 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9803 key" (bug#4257).
9804
0cf34688
LMI
9805 * window.c (Fset_window_start): Doc fix (bug#4199).
9806 (Fset_window_hscroll): Ditto.
9807
270768cd
PE
98082011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9809
077e3dda 9810 Fix minor new problems caught by GCC 4.6.1.
270768cd 9811 * term.c (init_tty): Remove unused local.
490011a6 9812 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9813 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9814 not used otherwise.
270768cd 9815
b1f58454
CY
98162011-07-12 Chong Yidong <cyd@stupidchicken.com>
9817
9818 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9819
22b9578d
LMI
98202011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9821
6e70ab07
LMI
9822 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9823 are the mini-buffer and the echo area (bug#3320).
9824
22b9578d
LMI
9825 * term.c (init_tty): Remove support for supdup, c10 and perq
9826 terminals, which are no longer supported (bug#1482).
9827
8974cc9f
JB
98282011-07-10 Johan Bockgård <bojohan@gnu.org>
9829
9830 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9831
a560d974
JD
98322011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9833
9834 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9835 for non-popups (Bug#3642).
9836
1dae0f0a
AS
98372011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9838
268c2c36 9839 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9840 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9841 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9842 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9843 * data.c (fmod): Likewise.
9844 * dispnew.c (swap_glyphs_in_rows): Likewise.
9845 * emacs.c (memory_warning_signal): Likewise.
9846 * floatfns.c (float_error): Likewise.
9847 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9848 (otf_open, font_otf_capability, generate_otf_features)
9849 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9850 Likewise.
9851 * image.c (pbm_read_file): Likewise.
9852 * indent.c (string_display_width): Likewise.
9853 * intervals.c (check_for_interval, search_for_interval)
9854 (inc_interval_count, count_intervals, root_interval)
9855 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9856 * lread.c (defalias): Likewise.
268c2c36 9857 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9858 * regex.c (set_image_of_range_1, set_image_of_range)
9859 (regex_grow_registers): Likewise.
9860 * sysdep.c (strerror): Likewise.
9861 * termcap.c (valid_filename_p, tprint, main): Likewise.
9862 * tparam.c (main): Likewise.
9863 * unexhp9k800.c (run_time_remap, save_data_space)
9864 (update_file_ptrs, read_header, write_header, calculate_checksum)
9865 (copy_file, copy_rest, display_header): Likewise.
9866 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9867 Likewise.
9868 * xdisp.c (check_it): Likewise.
9869 * xfaces.c (register_color, unregister_color, unregister_colors):
9870 Likewise.
9871 * xfns.c (print_fontset_result): Likewise.
9872 * xrdb.c (member, fatal, main): Likewise.
9873
99033785
PE
98742011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9875
9876 Fix minor problems found by static checking (Bug#9031).
9877 * chartab.c (char_table_set_range, map_sub_char_table):
9878 Remove unused locals.
9879 (uniprop_table): Now static.
9880 * composite.c (_work_char): Remove unused static var.
9881
9cb2ac56
JB
98822011-07-09 Juanma Barranquero <lekktu@gmail.com>
9883
9884 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9885
f25661f0
JD
98862011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9887
9888 * gtkutil.c (qttip_cb): Remove code without function.
9889
8278c4fe
EZ
98902011-07-09 Eli Zaretskii <eliz@gnu.org>
9891
9892 * w32.c (pthread_sigmask): New stub.
9893
1692ae2d 98942011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9895
8a6ebd58 9896 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9897 sigprocmask is portable only for single-threaded applications, and
9898 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9899 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9900 (LIBES): Use it.
9901 * callproc.c (Fcall_process):
9902 * process.c (create_process):
9903 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9904 Use pthread_sigmask, not sigprocmask.
123403e4 9905
1b854618
JD
99062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9907
9908 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9909 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9910 wrong (Bug#8591).
9911
3fe4b549
JD
99122011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9913
0ce7e563
JD
9914 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9915 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9916 (xg_hide_tooltip): Fix comment.
9917
3fe4b549
JD
9918 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9919 in registerServicesMenuSendTypes.
9920 (validRequestorForSendType): Don't check ns_return_types.
9921
9922 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9923 ns_return_type.
9924
5df75e47
JR
99252011-07-08 Jason Rumney <jasonr@gnu.org>
9926
22610910
JR
9927 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9928 SH_SHOW for hidden windows (Bug#5482).
9929
5df75e47
JR
9930 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9931 frame struct members of non-existent frames (Bug#6284).
9932
699c10bd
JD
99332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9934
4393663b
JD
9935 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9936 variable firstTime not needed on OSX >= 10.6.
9937 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9938 >= 10.5. Use setKnobProportion, setDoubleValue.
9939
9940 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9941 (MAC_OS_X_VERSION_10_5): Define if not defined.
9942 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9943 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9944 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9945
9946 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9947 cString and lossyCString on OSX >= 10.4.
4393663b 9948
58179cce 9949 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9950 sizeToFit on OSX >= 10.2.
9951
9952 * nsimage.m (allocInitFromFile): Don't use deprecated method
9953 bestRepresentationForDevice on OSX >= 10.6.
9954
9955 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9956 to avoid warning.
9957
9958 * emacs.c: Declare unexec_init_emacs_zone.
9959
a63e0781
JD
9960 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9961
699c10bd
JD
9962 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9963
9964 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9965 on svcsMenu (Bug#8842).
9966
9967 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9968 ns_return_types.
9969 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9970
9971 * nsterm.m (QUTF8_STRING): Declare.
9972 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9973 (validRequestorForSendType): Return type is (id).
9974 Change indexOfObjectIdenticalTo to indexOfObject.
9975 Check if we have local selection before returning self (Bug#8842).
9976 (writeSelectionToPasteboard): Put local selection into paste board
9977 if we have a local selection (Bug#8842).
9978 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9979
9980 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9981 (ns_get_local_selection): Declare.
9982
54e10184
LMI
99832011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9984
9888ff71
LMI
9985 * keymap.c (describe_map_tree): Don't insert a double newline at
9986 the end of the buffer (bug#1169) and return whether we inserted
9987 something.
9988
54e10184
LMI
9989 * callint.c (Fcall_interactively): Change "reading args" to
9990 "providing args" to try to clarify what it does (bug#1010).
9991
15fa4783
KH
99922011-07-07 Kenichi Handa <handa@m17n.org>
9993
9994 * composite.c (composition_compute_stop_pos): Ignore a static
9995 composition starting before CHARPOS (Bug#8915).
9996
9997 * xdisp.c (handle_composition_prop): Likewise.
9998
a8815b00
EZ
99992011-07-07 Eli Zaretskii <eliz@gnu.org>
10000
10001 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10002 (Bug#9015)
10003
ef7b981d 100042011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10005
10006 * character.h (unicode_category_t): New enum type.
10007
10008 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10009 (Qchar_code_property_table): New variable.
10010 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10011 (UNIPROP_COMPRESSED_FORM_P): New macros.
10012 (char_table_ascii): Uncompress the compressed values.
10013 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10014 Uncompress the compressed values.
ac389d0c 10015 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10016 (char_table_ref_and_range): Uncompress the compressed values.
10017 (sub_char_table_set): New arg is_uniprop. Callers changed.
10018 Uncompress the compressed values.
10019 (sub_char_table_set_range): Args changed. Callers changed.
10020 (char_table_set_range): Adjuted for the above change.
10021 (map_sub_char_table): Delete args default_val and parent. Add arg
10022 top. Give decoded values to a Lisp function.
640c8776 10023 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10024 values to a Lisp function. Gcpro more variables.
10025 (uniprop_table_uncompress)
10026 (uniprop_decode_value_run_length): New functions.
10027 (uniprop_decoder, uniprop_decoder_count): New variables.
10028 (uniprop_get_decoder, uniprop_encode_value_character)
10029 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10030 New functions.
10031 (uniprop_encoder, uniprop_encoder_count): New variables.
10032 (uniprop_get_encoder, uniprop_table)
10033 (Funicode_property_table_internal, Fget_unicode_property_internal)
10034 (Fput_unicode_property_internal): New functions.
10035 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10036 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10037 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10038 char-code-property-alist.
10039
640c8776 10040 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10041 Vunicode_category_table.
10042
640c8776 10043 * font.c (font_range): Adjust for the change of
c805dec0
KH
10044 Vunicode_category_table.
10045
76b397fb
DN
100462011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10047
10048 * m/iris4d.h: Remove file, move contents ...
10049 * s/irix6-5.h: ... here.
10050
22b4128e
PE
100512011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10052
10053 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10054 * alloc.c (mark_buffer):
10055 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10056 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10057 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10058 This isn't true in general, and it's particularly not true
10059 if Emacs is configured with --with-wide-int.
10060 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10061 New macros, used in the buffer.c change.
10062
869795d6
JD
100632011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10064
10065 * xsettings.c: Use both GConf and GSettings if both are available.
10066 (store_config_changed_event): Add comment.
10067 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10068 (store_tool_bar_style_changed): New functions.
5e617bc2 10069 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10070 (struct xsettings): Move font inside HAVE_XFT.
10071 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10072 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10073 Move inside HAVE_XFT.
640c8776 10074 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10075 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10076 also.
10077 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10078 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10079 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10080 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10081 (parse_settings): Move check for font inside HAVE_XFT.
10082 (read_settings, apply_xft_settings): Add comment.
10083 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10084 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10085 call store_font_name_changed.
10086 (xft_settings_event): Add comment.
10087 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10088 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10089 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10090 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10091 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10092 (xsettings_get_system_font, xsettings_get_system_normal_font):
10093 Add comment.
869795d6 10094
d8ed26bd
PE
100952011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10096
10097 Random fixes. E.g., (random) never returned negative values.
10098 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10099 subseconds part to the entropy, as that's a bit more random.
10100 Prefer signed to unsigned, since the signedness doesn't matter and
10101 in general we prefer signed. When given a limit, use a
10102 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10103 latter isn't right if USE_2_TAGS_FOR_INTS.
10104 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10105 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10106
cabf1cac
SM
101072011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10108
10109 * textprop.c (text_property_stickiness):
10110 Obey Vtext_property_default_nonsticky.
10111 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10112 * w32fns.c (syms_of_w32fns):
10113 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10114
6e9b2be9
PE
101152011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10116
10117 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10118 This is more efficient than Ffile_directory_p and avoids a minor race.
10119
90186c68
LMI
101202011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10121
7c301272
LMI
10122 * buffer.c (Foverlay_put): Say what the return value is
10123 (bug#7835).
10124
c4f2d8d4
LMI
10125 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10126 is a directory before asking whether to use the file name
10127 (bug#7564).
ad637907
LMI
10128 (barf_or_query_if_file_exists): Make the "File is a directory"
10129 error be more correct.
c4f2d8d4 10130
90186c68
LMI
10131 * fns.c (Frequire): Remove the mention of the .gz files, since
10132 that's installation-specific, but keep the mention of
10133 `get-load-suffixes'.
10134
da64016e
PE
101352011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10136
10137 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10138 Report string overflow if the output is too long.
10139
7d47b580
JB
101402011-07-04 Juanma Barranquero <lekktu@gmail.com>
10141
a555cb87
JB
10142 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10143 (syms_of_gnutls): Remove duplicate DEFSYM for
10144 Qgnutls_bootprop_verify_hostname_error, an error for
10145 Qgnutls_bootprop_verify_error (which is no longer used).
10146
7d47b580
JB
10147 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10148 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10149 Also (re)move comments that are misplaced or no longer relevant.
10150
1e49bfab
LMI
101512011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10152
10153 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10154
1485f4c0
CY
101552011-07-03 Chong Yidong <cyd@stupidchicken.com>
10156
10157 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10158 and background color parameters if they have been changed.
10159
a9ab721e
LMI
101602011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10161
10162 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10163
cf7cff57
PE
101642011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10165
2e13213d
PE
10166 * xsettings.c (SYSTEM_FONT): Define only when used.
10167 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10168
cf7cff57
PE
10169 * keymap.c (access_keymap_1): Now static.
10170
7a8e04f7
CY
101712011-07-02 Chong Yidong <cyd@stupidchicken.com>
10172
10173 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10174 leave any prefix arg for the up event (Bug#1586).
10175
61352f62
LMI
101762011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10177
69bb1ef7
LMI
10178 * lread.c (syms_of_lread): Mention single symbols defined by
10179 `defvar' or `defconst' (bug#7154).
10180
61352f62 10181 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10182 (Frequire): Mention get-load-suffixes.
61352f62 10183
28545e04
MR
101842011-07-02 Martin Rudalics <rudalics@gmx.at>
10185
10186 * window.h (window): Remove clone_number slot.
10187 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10188 Remove.
10189 (make_parent_window, make_window, saved_window)
10190 (Fset_window_configuration, save_window_save): Don't deal with
10191 clone numbers.
10192 * buffer.c (Qclone_number): Remove declaration.
10193 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10194
3349e122
SM
101952011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10196
10197 Add multiple inheritance to keymaps.
10198 * keymap.c (Fmake_composed_keymap): New function.
10199 (Fset_keymap_parent): Simplify.
10200 (fix_submap_inheritance): Remove.
10201 (access_keymap_1): New function extracted from access_keymap to handle
10202 embedded parents and handle lists of maps.
10203 (access_keymap): Use it.
10204 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10205 (Fcopy_keymap): Handle embedded parents.
10206 (Fcommand_remapping, define_as_prefix): Simplify.
10207 (Fkey_binding): Simplify.
10208 (syms_of_keymap): Move minibuffer-local-completion-map,
10209 minibuffer-local-filename-completion-map,
10210 minibuffer-local-must-match-map, and
10211 minibuffer-local-filename-must-match-map to Elisp.
10212 (syms_of_keymap): Defsubr make-composed-keymap.
10213 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10214 (parse_menu_item): Trivial simplification.
10215
3279eb87
GM
102162011-07-01 Glenn Morris <rgm@gnu.org>
10217
10218 * Makefile.in (SETTINGS_LIBS): Fix typo.
10219
39cb9e56 102202011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10221
10222 * coding.c (Fencode_coding_string): Record the last coding system
10223 used, as the function doc string says (bug#8738).
10224
0949d2b6
JD
102252011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10226
10227 * xsettings.c (store_monospaced_changed): Take new font as arg and
10228 check for change against current_mono_font.
10229 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10230 (emacs_settings_constructor, emacs_settings_get_property)
10231 (emacs_settings_set_property, emacs_settings_class_init)
10232 (emacs_settings_init, gsettings_obj): Remove.
10233 (something_changedCB): New function for HAVE_GSETTINGS.
10234 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10235 with value as argument.
10236 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10237 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10238 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10239 "changed".
10240
10241 * xgselect.c: Add defined (HAVE_GSETTINGS).
10242 (xgselect_initialize): Ditto.
10243
10244 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10245 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10246 xg_select.
10247
bbc6b304
PE
102482011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10249
10250 * eval.c (struct backtrace): Simplify and port the data structure.
10251 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10252 signed bit field, as this assumption is not portable and it makes
10253 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10254 "char debug_on_exit : 1" as this is not portable either; instead,
10255 use the portable "unsigned int debug_on_exit : 1". Remove unused
10256 member evalargs. Remove obsolete comments about cc bombing out.
10257
9851bfc5
JD
102582011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10259
51bb811f 10260 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10261 Let HAVE_GSETTINGS override HAVE_GCONF.
10262 (store_monospaced_changed): New function.
10263 (EMACS_SETTINGS): A new type derived from GObject to handle
10264 GSettings notifications.
10265 (emacs_settings_constructor, emacs_settings_get_property)
10266 (emacs_settings_set_property, emacs_settings_class_init):
10267 New functions.
10268 (gsettings_client, gsettings_obj): New variables.
10269 (GSETTINGS_SCHEMA): New define.
10270 (something_changedCB): Call store_monospaced_changed.
10271 (init_gsettings): New function.
10272 (xsettings_initialize): Call init_gsettings.
10273 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10274 to NULL.
10275
640c8776 10276 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10277 GCONF_CFLAGS/LIBS.
10278
5386012d
MR
102792011-06-29 Martin Rudalics <rudalics@gmx.at>
10280
10281 * window.c (resize_root_window, grow_mini_window)
10282 (shrink_mini_window): Rename Qresize_root_window to
10283 Qwindow_resize_root_window and Qresize_root_window_vertically to
10284 Qwindow_resize_root_window_vertically.
10285
f13e0b08
PE
102862011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10287
10288 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10289
94515237
JB
102902011-06-27 Juanma Barranquero <lekktu@gmail.com>
10291
10292 * makefile.w32-in: Redesign dependencies so they reflect more
10293 clearly which files are directly included by each source file,
10294 and not through other includes.
10295
e43b6e43
MR
102962011-06-27 Martin Rudalics <rudalics@gmx.at>
10297
10298 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10299 (sort_overlays, overlay_strings): When an overlay's clone number
10300 matches the window's clone number process the overlay even if
10301 the overlay's window property doesn't match the current window.
10302
d68443dc
MR
10303 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10304 (Fwindow_hchild): Rename to Fwindow_left_child.
10305 (Fwindow_next): Rename to Fwindow_next_sibling.
10306 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10307 (resize_window_check): Rename to window_resize_check.
10308 (resize_window_apply): Rename to window_resize_apply.
10309 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10310 (Fdelete_other_windows_internal, resize_frame_windows)
10311 (Fsplit_window_internal, Fdelete_window_internal)
10312 (grow_mini_window, shrink_mini_window)
10313 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10314
c7e73be5
JD
103152011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10316
10317 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10318 (emacs_fixed_set_min_size): Remove.
10319 (emacs_fixed_new): Take frame as argument.
10320
10321 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10322 (_EmacsFixedPrivate): Remove minwidth/height.
10323 Add struct frame *f.
10324 (emacs_fixed_init): Initialize priv->f.
10325 (get_parent_class, emacs_fixed_set_min_size): Remove.
10326 (emacs_fixed_new): Set priv->f to argument.
10327 (emacs_fixed_get_preferred_width)
10328 (emacs_fixed_get_preferred_height): Use min_width/height from
10329 frames size_hint to set minimum and natural (Bug#8919).
10330 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10331 and use min_width/height from frames size_hint to set
10332 min_width/height (Bug#8919).
10333
10334 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10335 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10336 Fix indentation.
c7e73be5 10337
cf99dcf8
EZ
103382011-06-26 Eli Zaretskii <eliz@gnu.org>
10339
10340 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10341 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10342 called at ZV.
10343
029529ac
CY
103442011-06-26 Chong Yidong <cyd@stupidchicken.com>
10345
10346 * process.c (wait_reading_process_output): Bypass select if
10347 waiting for a cell while ignoring keyboard input, and input is
10348 pending. Suggested by Jan Djärv (Bug#8869).
10349
7a7ef429
PE
103502011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10351
10352 Use gnulib's dup2 module instead of rolling our own.
10353 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10354
11fdef7d 103552011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10356
10357 * dispnew.c (scrolling_window): Before scrolling, turn off a
10358 mouse-highlight in the window being scrolled.
10359
cd3520a4
JB
103602011-06-24 Juanma Barranquero <lekktu@gmail.com>
10361
10362 Move DEFSYM to lisp.h and use everywhere.
10363
10364 * character.h (DEFSYM): Move declaration...
10365 * lisp.h (DEFSYM): ...here.
10366
10367 * gnutls.c:
10368 * minibuf.c:
10369 * w32menu.c:
10370 * w32proc.c:
10371 * w32select.c: Don't include character.h.
10372
10373 * alloc.c (syms_of_alloc):
10374 * buffer.c (syms_of_buffer):
10375 * bytecode.c (syms_of_bytecode):
10376 * callint.c (syms_of_callint):
10377 * casefiddle.c (syms_of_casefiddle):
10378 * casetab.c (init_casetab_once):
10379 * category.c (init_category_once, syms_of_category):
10380 * ccl.c (syms_of_ccl):
10381 * cmds.c (syms_of_cmds):
10382 * composite.c (syms_of_composite):
10383 * dbusbind.c (syms_of_dbusbind):
10384 * dired.c (syms_of_dired):
10385 * dispnew.c (syms_of_display):
10386 * doc.c (syms_of_doc):
10387 * editfns.c (syms_of_editfns):
10388 * emacs.c (syms_of_emacs):
10389 * eval.c (syms_of_eval):
10390 * fileio.c (syms_of_fileio):
10391 * fns.c (syms_of_fns):
10392 * frame.c (syms_of_frame):
10393 * fringe.c (syms_of_fringe):
10394 * insdel.c (syms_of_insdel):
10395 * keymap.c (syms_of_keymap):
10396 * lread.c (init_obarray, syms_of_lread):
10397 * macros.c (syms_of_macros):
10398 * msdos.c (syms_of_msdos):
10399 * print.c (syms_of_print):
10400 * process.c (syms_of_process):
10401 * search.c (syms_of_search):
10402 * sound.c (syms_of_sound):
10403 * syntax.c (init_syntax_once, syms_of_syntax):
10404 * terminal.c (syms_of_terminal):
10405 * textprop.c (syms_of_textprop):
10406 * undo.c (syms_of_undo):
10407 * w32.c (globals_of_w32):
10408 * window.c (syms_of_window):
10409 * xdisp.c (syms_of_xdisp):
10410 * xfaces.c (syms_of_xfaces):
10411 * xfns.c (syms_of_xfns):
10412 * xmenu.c (syms_of_xmenu):
10413 * xsettings.c (syms_of_xsettings):
10414 * xterm.c (syms_of_xterm): Use DEFSYM.
10415
4228cf16
TZ
104162011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10417
cd3520a4 10418 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10419
7fcccf1e
PE
104202011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10421
7efb4e0e
PE
10422 Integer and buffer overflow fixes (Bug#8873).
10423
ff5844ad
PE
10424 * print.c (printchar, strout): Check for string overflow.
10425 (PRINTPREPARE, printchar, strout):
10426 Don't set size unless allocation succeeds.
10427
90532f02
PE
10428 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10429 for sizes. Check for string overflow more accurately.
10430 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10431
6d84508d
PE
10432 * macros.c: Integer and buffer overflow fixes.
10433 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10434 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10435 Use ptrdiff_t, not int, for sizes.
10436 Don't increment bufsize until after realloc succeeds.
10437 Check for size-calculation overflow.
10438 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10439
437b2cb4
PE
10440 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10441
8b9ac8b4
PE
10442 * lread.c: Integer overflow fixes.
10443 (read_integer): Radix is now EMACS_INT, not int,
10444 to improve quality of diagnostics for out-of-range radices.
10445 Calculate buffer size correctly for out-of-range radices.
10446 (read1): Check for integer overflow in radices, and in
10447 read-circle numbers.
82cb60d3
PE
10448 (read_escape): Avoid int overflow.
10449 (Fload, openp, read_buffer_size, read1)
10450 (substitute_object_recurse, read_vector, read_list, map_obarray):
10451 Use ptrdiff_t, not int, for sizes.
10452 (read1): Use EMACS_INT, not int, for sizes.
20270765 10453 Check for size overflow.
8b9ac8b4 10454
7fcccf1e
PE
10455 * image.c (cache_image): Check for size arithmetic overflow.
10456
bfbbd7e7
PE
10457 * lread.c: Integer overflow issues.
10458 (saved_doc_string_size, saved_doc_string_length)
10459 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10460 Now ptrdiff_t, not int.
10461 (read1): Don't assume doc string length fits in int. Check for
10462 out-of-range doc string lengths.
10463 (read_list): Don't assume file position fits in int.
39019e54 10464 (read_escape): Check for hex character overflow.
bfbbd7e7 10465
4e323265
LL
104662011-06-22 Leo Liu <sdl.web@gmail.com>
10467
10468 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10469 Move to minibuffer.el.
10470
85fece3e
PE
104712011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10472
20b84ce9 10473 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10474 The following patches are for when GLYPH_DEBUG && !XASSERT.
10475 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10476 * dispnew.c (flush_stdout):
10477 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10478 Mark as externally visible.
10479 * dispnew.c (check_window_matrix_pointers): Now static.
10480 * dispnew.c (window_to_frame_vpos):
10481 * xfns.c (unwind_create_frame):
10482 * xterm.c (x_check_font): Remove unused local.
10483 * scroll.c (CHECK_BOUNDS):
10484 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10485 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10486 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10487 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10488 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10489 Now static.
10490 (debug_method_add): Use va_list and vsprintf rather than relying
10491 on undefined behavior with wrong number of arguments.
10492 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10493 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10494 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10495 since we're not interested in debugging glyphs with old libraries.
10496 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10497 GCC 4.6.0's static checking.
10498
0766b489
PE
104992011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10500
31fd4b32
PE
10501 Integer overflow and signedness fixes (Bug#8873).
10502 A few related buffer overrun fixes, too.
10503
b79e8648
PE
10504 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10505
0766b489
PE
10506 * dispextern.h (struct face.stipple):
10507 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10508 (x_bitmap_mask, x_allocate_bitmap_record)
10509 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10510 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10511 (x_create_bitmap_from_xpm_data):
10512 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10513 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10514 (.bitmaps_last):
10515 * xfaces.c (load_pixmap):
10516 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10517 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10518 (.bitmaps_last, struct x_output.icon_bitmap):
10519 Use ptrdiff_t, not int, for bitmap indexes.
10520 (x_allocate_bitmap_record): Check for size overflow.
10521 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10522
b081724f
PE
10523 Use ptrdiff_t, not int, for overlay counts.
10524 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10525 * editfns.c (overlays_around, get_pos_property):
10526 * textprop.c (get_char_property_and_overlay):
10527 * xdisp.c (next_overlay_change, note_mouse_highlight):
10528 * xfaces.c (face_at_buffer_position):
21514da7
PE
10529 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10530 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10531 (Fnext_overlay_change, Fprevious_overlay_change)
10532 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10533 Use ptrdiff_t, not int, for sizes.
21514da7 10534 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10535
3de73e5e
PE
10536 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10537
2606c57b
PE
10538 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10539 (x_session_initialize): Do not assume string length fits in int.
10540
aaafe47a
PE
10541 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10542 This is unlikely, but can occur if DPI is outlandish.
10543
2674ddc8 10544 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10545 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10546
28154962
PE
10547 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10548 * xrdb.c (magic_file_p, search_magic_path):
10549 Omit last arg SUFFIX; it was always 0. All callers changed.
10550 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10551
7de51af5
PE
10552 * xfont.c (xfont_match): Avoid need for strlen.
10553
25ed6cc3
PE
10554 * xfns.c: Don't assume strlen fits in int.
10555 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10556
4eab31dd
PE
10557 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10558 not unsigned long, as we prefer signed integers. All callers changed.
10559 Detect integer overflow in repeat count.
10560 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10561 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10562
171e2a58
PE
10563 * termcap.c: Don't assume sizes fit in int and never overflow.
10564 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10565 (gobble_line): Check for size-calculation overflow.
10566
ad39faca 10567 * minibuf.c (Fread_buffer):
6e5bb2dc 10568 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10569 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10570 Don't assume string length fits in int.
10571
52c61c22 10572 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10573 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10574
b5b8c9e5
PE
10575 * font.c: Don't assume string length fits in int.
10576 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10577 Use ptrdiff_t, not int.
ccd6111c
PE
10578 (font_intern_prop): Don't assume string length fits in int.
10579 Don't assume integer property fits in fixnum.
10580 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10581
882f0d81 10582 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10583 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10584 Reformulate so as not to need the command string.
10585 Invoke gzip -cd rather than gunzip, as it's more portable.
10586 (lock_info_type, lock_file_1, lock_file):
10587 Don't assume pid_t and time_t fit in unsigned long.
10588 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10589 (current_lock_owner): Prefer signed type for sizes.
10590 Use memcpy, not strncpy, where memcpy is what is really wanted.
10591 Don't assume (via atoi) that time_t and pid_t fit in int.
10592 Check for time_t and/or pid_t out of range, e.g., via a network share.
10593 Don't alloca where an auto var works fine.
10594
93f4cf88
PE
10595 * fileio.c: Fix some integer overflow issues.
10596 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10597 Don't assume string length fits in int.
10598 (directory_file_name): Don't assume string length fits in long.
10599 (make_temp_name): Don't assume pid fits in int, or that its print
10600 length is less than 20.
10601
f3e92b69
PE
10602 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10603
1bfdaf10
PE
10604 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10605
35016e9a
PE
10606 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10607
3d1e65a1
PE
10608 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10609 We prefer signed integers, even for size calculations.
10610
0b963a93
PE
10611 * emacs.c: Don't assume string length fits in 'int'.
10612 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10613 (main): Don't invoke strlen when not needed.
10614
573f4b54
PE
10615 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10616 (XD_DEBUG_MESSAGE): Don't waste a byte.
10617
989f33ba
PE
10618 * callproc.c (getenv_internal_1, getenv_internal)
10619 (Fgetenv_internal):
965d34eb
PE
10620 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10621
e4d29b33
PE
10622 * lread.c (invalid_syntax): Omit length argument.
10623 All uses changed. This doesn't fix a bug, but it simplifies the
10624 code away from its former Hollerith-constant appearance, and it's
10625 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10626 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10627
eb49b136
PE
10628 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10629 This didn't break anything, but it didn't help either.
10630 It's confusing to put a bogus integer in a place where the actual
10631 value does not matter.
9f62aeb1 10632 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10633 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10634
15375a22
PE
10635 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10636 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10637 implementation.
b61cc01c
PE
10638 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10639 We prefer signed types, and the value cannot exceed the EMACS_INT
10640 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10641 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10642 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10643 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10644
53b2623d
PE
10645 * indent.c (sane_tab_width): New function.
10646 (current_column, scan_for_column, Findent_to, position_indentation)
10647 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10648 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10649
51cab52b 10650 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10651
f2ed8a70
PE
10652 * lisp.h (lint_assume): New macro.
10653 * composite.c (composition_gstring_put_cache):
10654 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10655
abe80cc6
PE
10656 * editfns.c, insdel.c:
10657 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10658
b02c740e
PE
10659 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10660
ebc96716
PE
10661 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10662
b4e50fa0 10663 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10664 Use much-faster test for byte-length change.
311d5d7c 10665 Don't assume string byte-length fits in 'int'.
a4cf38e4 10666 Check that character arg fits in 'int'.
85461888 10667 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10668
c0c1ee9f
PE
10669 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10670
a498d7f4
PE
10671 * fns.c (concat): Catch string overflow earlier.
10672 Do not rely on integer wraparound.
10673
51cab52b
PE
10674 * dispextern.h (struct it.overlay_strings_charpos)
10675 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10676 * xdisp.c (forward_to_next_line_start)
10677 (back_to_previous_visible_line_start)
10678 (reseat_at_next_visible_line_start, next_element_from_buffer):
10679 Don't arbitrarily truncate the value of 'selective' to int.
10680
76031fad
PE
10681 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10682
5eb55db9
PE
10683 * composite.c: Don't truncate sizes to 'int'.
10684 (composition_gstring_p, composition_reseat_it)
10685 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10686 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10687 not EMACS_UINT, for indexes.
5eb55db9 10688
0703a717
PE
10689 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10690
d6202519
PE
10691 * buffer.c: Include <verify.h>.
10692 (struct sortvec.priority, struct sortstr.priority):
8961a454 10693 Now EMACS_INT, not int.
c20998a7 10694 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10695 (struct sortstr.size, record_overlay_string)
10696 (struct sortstrlist.size, struct sortlist.used):
10697 Don't truncate size to int.
10698 (record_overlay_string): Check for size-calculation overflow.
d6202519 10699 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10700
d5a19415
JM
107012011-06-22 Jim Meyering <meyering@redhat.com>
10702
029529ac 10703 Don't leak an XBM-image-sized buffer
d5a19415
JM
10704 * image.c (xbm_load): Free the image buffer after using it.
10705
a9041e6c
PE
107062011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10707
10708 Port to Sun C.
10709 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10710 that Sun C diagnosed.
10711 * fns.c (secure_hash): Fix pointer signedness issue.
10712 * intervals.c (static_offset_intervals): New function.
10713 (offset_intervals): Use it.
10714
7f3f739f
LL
107152011-06-21 Leo Liu <sdl.web@gmail.com>
10716
10717 * deps.mk (fns.o):
10718 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10719 sha512.h.
10720
10721 * fns.c (secure_hash): Rename from crypto_hash_function and change
10722 the first arg to accept symbols.
5b66d427 10723 (Fsecure_hash): New primitive.
7f3f739f
LL
10724 (syms_of_fns): New symbols.
10725
76147d94
DD
107262011-06-20 Deniz Dogan <deniz@dogan.se>
10727
10728 * process.c (Fset_process_buffer): Clarify return value in
10729 docstring.
10730
7d7d0045
CY
107312011-06-18 Chong Yidong <cyd@stupidchicken.com>
10732
10733 * dispnew.c (add_window_display_history): Use BVAR.
10734
10735 * xdisp.c (debug_method_add): Use BVAR.
10736 (check_window_end, dump_glyph_matrix, dump_glyph)
10737 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10738
10739 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10740 Likewise.
10741
10742 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10743 check till after the cache is created in init_frame_faces.
10744
ff2bc410
SM
107452011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10746
10747 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10748
28177add
PE
107492011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10750
dd3482fe
PE
10751 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10752 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10753 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10754
393d71f3 10755 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10756 * fileio.c (Finsert_file_contents):
10757 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10758 Remove the old (too-loose) buffer overflow checks.
10759 They weren't needed, since make_gap checks for buffer overflow.
10760 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10761 The old code merely checked for Emacs fixnum overflow, and relied
10762 on undefined (wraparound) behavior. The new code avoids undefined
10763 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10764
2e6813b0 10765 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10766 Tune. Don't use wider integers than needed. Don't use alloca.
10767 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10768
599a9e4f
PE
10769 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10770
99561444
PE
10771 * insdel.c, lisp.h (buffer_overflow): New function.
10772 (insert_from_buffer_1, replace_range, replace_range_2):
10773 * insdel.c (make_gap_larger):
10774 * editfns.c (Finsert_char):
10775 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10776
28177add
PE
10777 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10778
e69dafad
PE
107792011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10780
4baa020d 10781 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10782
b1c46f02
PE
10783 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10784 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10785
e69dafad
PE
10786 * fileio.c: Don't assume EMACS_INT fits in off_t.
10787 (emacs_lseek): New static function.
10788 (Finsert_file_contents, Fwrite_region): Use it.
10789 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10790
566684ea
PE
10791 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10792
e6966cd6
PE
10793 * fns.c: Don't overflow int when computing a list length.
10794 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10795 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10796 truncation on 64-bit hosts. Check for QUIT every
10797 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10798 faster and is responsive enough.
10799 (Flength): Report an error instead of overflowing an integer.
10800 (Fsafe_length): Return a float if the value is not representable
10801 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10802 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10803 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10804
dd0b0efb
PE
10805 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10806 (header_size, word_size): New constants.
10807 (allocate_vectorlike): Don't check size overflow here.
10808 (allocate_vector): Check it here instead, since this is the only
10809 caller of allocate_vectorlike that could cause overflow.
10810 Check that the new vector's length is representable as a fixnum.
10811
86fe5cfe
PE
10812 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10813 The previous code was bogus. For example, next_almost_prime (32)
10814 returned 39, which is undesirable as it is a multiple of 3; and
10815 next_almost_prime (24) returned 25, which is a multiple of 5 so
10816 why was the code bothering to check for multiples of 7?
10817
80e88859
PE
10818 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10819
4a2f0ad6
PE
10820 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10821
f66c7cf8
PE
10822 Variadic C functions now count arguments with ptrdiff_t.
10823 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10824 Back then I didn't know that the Emacs coding style prefers signed int.
10825 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10826 were being counted with int, which may truncate counts on 64-bit
10827 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10828 * lisp.h (struct Lisp_Subr.function.aMANY)
10829 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10830 Arg counts are now ptrdiff_t, not size_t.
10831 All variadic functions and their callers changed accordingly.
10832 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10833 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10834 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10835 * callint.c (Fcall_interactively): Check arg count for overflow,
10836 to avoid potential buffer overrun. Use signed char, not 'int',
10837 for 'varies' array, so that we needn't bother to check its size
10838 calculation for overflow.
10839 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10840 * eval.c (apply_lambda):
10841 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10842 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10843 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10844
a1759b76
PE
10845 * callint.c (Fcall_interactively): Don't use index var as event count.
10846
d96be9fc
PE
10847 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10848 * mem-limits.h (SIZE): Remove; no longer used.
10849
a690a978 10850 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10851
578c21e6
PE
10852 Remove unnecessary casts.
10853 * xterm.c (x_term_init):
10854 * xfns.c (x_set_border_pixel):
10855 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10856 These aren't needed now that we assume ANSI C.
10857
96f53c6c
PE
10858 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10859 It's more likely to cause problems (due to unsigned overflow)
10860 than to cure them.
10861
83c77d31
PE
10862 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10863
ee2079f1
PE
10864 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10865
6da65536
PE
10866 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10867
7147c4a4
PE
10868 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10869
193e32d9
PE
10870 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10871
e5533da6
PE
10872 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10873
9910e595
PE
10874 GLYPH_CODE_FACE returns EMACS_INT, not int.
10875 * dispextern.h (merge_faces):
10876 * xfaces.c (merge_faces):
01103c44
PE
10877 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10878 Don't assume EMACS_INT fits in int.
9910e595 10879
2638320e
PE
10880 * character.h (CHAR_VALID_P): Remove unused parameter.
10881 * fontset.c, lisp.h, xdisp.c: All uses changed.
10882
045eb8d9
PE
10883 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10884
c1f134b5
PE
10885 * fns.c (concat): Minor tuning based on overflow analysis.
10886 This doesn't fix any bugs. Use int to hold character, instead
10887 of constantly refetching from Emacs object. Use XFASTINT, not
10888 XINT, for value known to be a character. Don't bother comparing
10889 a single byte to 0400, as it's always less.
10890
395fcb93 10891 * floatfns.c (Fexpt):
327eeec8
PE
10892 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10893
abbd3d23
PE
10894 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10895 for characters.
10896
684a03ef
PE
10897 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10898
0fed43f3
PE
10899 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10900 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10901 incorrectly succeed when S was a string, because 4294967386 was
10902 truncated before it was used.
10903
8fd02eb7
PE
10904 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10905 Otherwise, an out-of-range integer could cause undefined behavior
10906 on a 64-bit host.
10907
f8c86b69
PE
10908 * composite.c: Use int, not EMACS_INT, for characters.
10909 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10910 EMACS_INT, for values that are known to be in character range.
10911 This doesn't fix any bugs but is the usual style inside Emacs and
10912 may generate better code on 32-bit machines.
10913
34206dd2
PE
10914 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10915 This is for reasons similar to the recent CHAR_STRING fix.
10916 * charset.c (Fencode_char): Check that character arg is actually
10917 a character. Pass an int to ENCODE_CHAR.
10918 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10919 wider than 'int', as a compile-time check to prevent future regressions
10920 in this area.
10921
c5958d4c 10922 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10923
10924 Make sure a 64-bit char is never passed to CHAR_STRING.
10925 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10926 by silently ignoring the top 32 bits, allowing some values
10927 that were far too large to be valid characters.
10928 * character.h: Include <verify.h>.
10929 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10930 arguments are no wider than unsigned, as a compile-time check
10931 to prevent future regressions in this area.
10932 * data.c (Faset):
01103c44 10933 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10934 (Fsubst_char_in_region):
10935 * fns.c (concat):
10936 * xdisp.c (decode_mode_spec_coding):
10937 Adjust to CHAR_STRING's new requirement.
10938 * editfns.c (Finsert_char, Fsubst_char_in_region):
10939 * fns.c (concat): Check that character args are actually
10940 characters. Without this test, these functions did the wrong
10941 thing with wildly out-of-range values on 64-bit hosts.
10942
d37ca623
PE
10943 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10944 These casts should not be needed on 32-bit hosts, either.
10945 * keyboard.c (read_char):
10946 * lread.c (Fload): Remove casts to unsigned.
10947
ea204efb
PE
10948 * lisp.h (UNSIGNED_CMP): New macro.
10949 This fixes comparison bugs on 64-bit hosts.
10950 (ASCII_CHAR_P): Use it.
10951 * casefiddle.c (casify_object):
01103c44 10952 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10953 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10954 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10955 * dispextern.h (FACE_FROM_ID):
10956 * keyboard.c (read_char): Use UNSIGNED_CMP.
10957
41cb286c
PE
10958 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10959 not to EMACS_INT, to avoid GCC warning.
10960
4a1b9832
PE
10961 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10962
55daad71
PE
10963 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10964 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10965 isn't needed on 32-bit machines.
8f95c75c 10966
01103c44
PE
10967 * buffer.c (Fgenerate_new_buffer_name):
10968 Use EMACS_INT for count, not int.
0ceccced 10969 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10970
10971 * data.c (Qcompiled_function): Now static.
10972
c6f072e7
PE
10973 * window.c (window_body_lines): Now static.
10974
20ce5912
PE
10975 * image.c (gif_load): Rename local to avoid shadowing.
10976
9c4c5f81
PE
10977 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10978 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10979 * alloc.c (make_save_value): Integer argument is now of type
10980 ptrdiff_t, not int.
10981 (mark_object): Use ptrdiff_t, not int.
10982 * lisp.h (pD): New macro.
10983 * print.c (print_object): Use it.
10984
c0c5c8ae
PE
10985 * alloc.c: Use EMACS_INT, not int, to count objects.
10986 (total_conses, total_markers, total_symbols, total_vector_size)
10987 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10988 (total_free_floats, total_floats, total_free_intervals)
10989 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10990 Now EMACS_INT, not int. All uses changed.
10991 (Fgarbage_collect): Compute overall total using a double, so that
10992 integer overflow is less likely to be a problem. Check for overflow
10993 when converting back to an integer.
5a25e253
PE
10994 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10995 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10996 These were 'int' variables that could overflow on 64-bit hosts;
10997 they were never used, so remove them instead of repairing them.
211a0b2a 10998 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10999 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11000 Previously, this ceilinged at INT_MAX, but that doesn't work on
11001 64-bit machines.
e46bb31a 11002 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11003
c78baabf 11004 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11005 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11006 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11007 when a (possibly-narrower) signed value would do just as well.
11008 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11009
c9d624c6
PE
11010 * alloc.c: Catch some string size overflows that we were missing.
11011 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11012 for convenience in STRING_BYTES_MAX.
11013 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11014 The definition here is exact; the one in lisp.h was approximate.
11015 (allocate_string_data): Check for string overflow. This catches
11016 some instances we weren't catching before. Also, it catches
11017 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11018 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11019 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11020
c9d624c6
PE
11021 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11022 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11023 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11024
353032ce
PE
11025 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11026
2bccce07
PE
11027 * alloc.c (Fmake_string): Check for out-of-range init.
11028
0ac30604
SM
110292011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11030
11031 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11032
c195f2de
JD
110332011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11034
11035 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11036 xg_get_default_scrollbar_width.
11037
11038 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11039 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11040 (style_changed_cb): Call update_theme_scrollbar_width and call
11041 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11042 all frames (Bug#8505).
11043 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11044 Call gtk_window_set_resizable if HAVE_GTK3.
11045 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11046 and height if HAVE_GTK3 (Bug#8505).
11047 (scroll_bar_width_for_theme): New variable.
11048 (update_theme_scrollbar_width): New function.
11049 (xg_get_default_scrollbar_width): Move code to
11050 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11051 (xg_initialize): Call update_theme_scrollbar_width.
11052
11053 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11054
11055 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11056
e10ac9f1
MR
110572011-06-12 Martin Rudalics <rudalics@gmx.at>
11058
11059 * frame.c (make_frame): Call other_buffer_safely instead of
11060 other_buffer.
11061
11062 * window.c (temp_output_buffer_show): Call display_buffer with
11063 second argument Vtemp_buffer_show_specifiers and reset latter
11064 immediately after the call.
11065 (Vtemp_buffer_show_specifiers): New variable.
11066 (auto_window_vscroll_p, next_screen_context_lines)
11067 (Vscroll_preserve_screen_position): Remove leading asterisks from
11068 doc-strings.
11069
2d3c217e 110702011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11071
7b7f97e8 11072 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11073 * buffer.c (Qclone_number): Remove for now, as it's unused.
11074 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11075 (record_buffer): Remove unused local.
11076 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11077 (set_frame_buffer_list): Remove; unused.
11078 * frame.h (other_visible_frames): Remove decl.
11079 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11080 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11081 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11082 if HAVE_GPM.
11083 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11084 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11085 Define only if HAVE_GPM.
11086 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11087 (update_hints_inhibit): Remove; never set. All uses removed.
11088 * widgetprv.h (emacsFrameClassRec): Remove decl.
11089 * window.c (delete_deletable_window): Now returns void, since it
11090 wasn't returning anything.
11091 (compare_window_configurations): Remove unused locals.
11092 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11093 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11094 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11095 the same widths as pointers. This follows up on the 2011-05-06 patch.
11096 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11097 * xterm.h: Likewise.
11098 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11099
1384b89e
JB
111002011-06-12 Juanma Barranquero <lekktu@gmail.com>
11101
11102 * makefile.w32-in: Update dependencies.
11103 (LISP_H): Add lib/intprops.h.
11104
1100a63c
CY
111052011-06-11 Chong Yidong <cyd@stupidchicken.com>
11106
11107 * image.c (gif_load): Add animation frame delay to the metadata.
11108 (syms_of_image): Use DEFSYM. New symbol `delay'.
11109
6198ccd0
MR
111102011-06-11 Martin Rudalics <rudalics@gmx.at>
11111
11112 * window.c (delete_deletable_window): Re-add.
11113 (Fset_window_configuration): Rewrite to handle dead buffers and
11114 consequently deletable windows.
11115 (window_tree, Fwindow_tree): Remove. Supply functionality in
11116 window.el.
11117 (compare_window_configurations): Simplify code.
11118
b6e3633c
AS
111192011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11120
1ab0dee5
AS
11121 * image.c (imagemagick_load_image): Fix type mismatch.
11122 (Fimagemagick_types): Likewise.
11123
b6e3633c
AS
11124 * window.h (replace_buffer_in_windows): Declare.
11125
9397e56f
MR
111262011-06-11 Martin Rudalics <rudalics@gmx.at>
11127
11128 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11129 Qclone_number. Remove external declaration of Qdelete_window.
11130 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11131 code.
640c8776
SM
11132 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11133 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11134 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11135 buffer list implementation.
11136 (other_buffer_safely): New function.
11137 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11138 calls to replace_buffer_in_windows and
11139 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11140 if allowed.
11141 (record_buffer): Inhibit quitting and rewrite using quittable
11142 functions. Run Qbuffer_list_update_hook if allowed.
11143 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11144 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11145 Move switch-to-buffer to window.el.
9397e56f
MR
11146 (bury-buffer): Move to window.el.
11147 (Vbuffer_list_update_hook): New variable.
11148
11149 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11150 section.
11151
11152 * window.h (resize_frame_windows): Move up in code.
11153 (Fwindow_frame): Remove EXFUN.
11154 (replace_buffer_in_all_windows): Remove prototype.
11155 (replace_buffer_in_windows_safely): Add prototype.
11156
11157 * window.c: Declare Qdelete_window static again. Move down
11158 declaration of select_count.
11159 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11160 (Fother_window): Move to window.el.
11161 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11162 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11163 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11164 window.el.
11165 (replace_buffer_in_windows): Implement by calling
11166 Qreplace_buffer_in_windows.
11167 (replace_buffer_in_all_windows): Remove with some functionality
11168 moved into replace_buffer_in_windows_safely.
11169 (replace_buffer_in_windows_safely): New function.
11170 (select_window_norecord, select_frame_norecord): Move in front
11171 of run_window_configuration_change_hook. Remove now obsolete
11172 declarations.
640c8776
SM
11173 (Fset_window_buffer): Rewrite doc-string.
11174 Call Qrecord_window_buffer.
9397e56f
MR
11175 (keys_of_window): Move binding for other-window to window.el.
11176
b50691aa
CY
111772011-06-11 Chong Yidong <cyd@stupidchicken.com>
11178
11179 * dispextern.h (struct image): Replace data member, whose int_val
11180 and ptr_val fields were not used by anything, with a single
11181 lisp_val object.
11182
11183 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11184 (gif_clear_image, gif_load, imagemagick_load_image)
11185 (gs_clear_image, gs_load): Callers changed.
11186
3f754b86
PE
111872011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11188
cca69397
PE
11189 * buffer.h: Include <time.h>, for time_t.
11190 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11191
109e28d0
PE
11192 Fix minor problems found by static checking.
11193
60737f02
PE
11194 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11195
4b66faf3
PE
11196 Make identifiers static if they are not used in other modules.
11197 * data.c (Qcompiled_function, Qframe, Qvector):
11198 * image.c (QimageMagick, Qsvg):
11199 * minibuf.c (Qmetadata):
11200 * window.c (resize_window_check, resize_root_window): Now static.
11201 * window.h (resize_window_check, resize_root_window): Remove decls.
11202
109e28d0
PE
11203 * window.c (window_deletion_count, delete_deletable_window):
11204 Remove; unused.
46a4ce9e
PE
11205 (window_body_lines): Now static.
11206 (Fdelete_other_windows_internal): Mark vars as initialized.
11207 Make sure 'resize_failed' is initialized.
11208 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11209 (resize_window_apply): Remove unused local.
11210 * window.h (delete_deletable_window): Remove decl.
11211
109e28d0 11212 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11213 (imagemagick_load_image): Fix pointer signedness problem by changing
11214 last arg from unsigned char * to char *. All uses changed.
11215 Also, fix a local for similar reasons.
11216 Remove unused locals. Remove locals to avoid shadowing.
11217 (fn_rsvg_handle_free): Remove; unused.
11218 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11219 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11220
3f754b86
PE
11221 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11222
2547adb1
CY
112232011-06-10 Chong Yidong <cyd@stupidchicken.com>
11224
11225 * image.c (gif_load): Fix omitted cast error introduced by
11226 2011-06-06 change.
11227
2c8e37d4
MR
112282011-06-10 Martin Rudalics <rudalics@gmx.at>
11229
11230 * window.h (resize_proportionally, orig_total_lines)
11231 (orig_top_line): Remove from window structure.
11232 (set_window_height, set_window_width, change_window_heights)
11233 (Fdelete_window): Remove prototypes.
11234 (resize_frame_windows): Remove duplicate declaration.
11235
440a42e3
EZ
112362011-06-10 Eli Zaretskii <eliz@gnu.org>
11237
11238 * window.h (resize_frame_windows, resize_window_check)
11239 (delete_deletable_window, resize_root_window)
11240 (resize_frame_windows): Declare prototypes.
11241
11242 * window.c (resize_window_apply): Make definition be "static" to
11243 match the prototype.
11244
562dd5e9
MR
112452011-06-10 Martin Rudalics <rudalics@gmx.at>
11246
11247 * window.c: Remove declarations of Qwindow_size_fixed,
11248 window_min_size_1, window_min_size_2, window_min_size,
11249 size_window, window_fixed_size_p, enlarge_window, delete_window.
11250 Remove static from declaration of Qdelete_window, it's
11251 temporarily needed by Fbury_buffer.
11252 (replace_window): Don't assign orig_top_line and
11253 orig_total_lines.
11254 (Fdelete_window, delete_window): Remove. Window deletion is
11255 handled by window.el.
640c8776
SM
11256 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11257 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11258 (Fdelete_other_windows): Remove. Deleting other windows is
11259 handled by window.el.
11260 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11261 handled in window.el.
11262 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11263 Window minimum sizes are handled in window.el.
11264 (shrink_windows, size_window, set_window_height)
11265 (set_window_width, change_window_heights, window_height)
11266 (window_width, CURBEG, CURSIZE, enlarge_window)
11267 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11268 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11269 handled in window.el.
11270 (make_dummy_parent): Rename to make_parent_window and give it a
11271 second argument horflag.
11272 (make_window): Don't set resize_proportionally any more.
11273 (Fsplit_window): Remove. Windows are split in window.el.
11274 (save_restore_action, save_restore_orig_size)
11275 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11276 Resize mini windows in window.el.
11277 (grow_mini_window, shrink_mini_window): Implement by calling
11278 Qresize_root_window_vertically, resize_window_check and
11279 resize_window_apply.
640c8776
SM
11280 (saved_window, Fset_window_configuration, save_window_save):
11281 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11282 resize_proportionally.
11283 (window_min_height, window_min_width): Move to window.el.
11284 (keys_of_window): Move bindings for delete-other-windows,
11285 split-window, delete-window and enlarge-window to window.el.
11286
11287 * buffer.c: Temporarily extern Qdelete_window.
11288 (Fbury_buffer): Temporarily call Qdelete_window instead of
11289 Fdelete_window (Fbury_buffer will move to window.el soon).
11290
11291 * frame.c (set_menu_bar_lines_1): Remove code handling
11292 orig_top_line and orig_total_lines.
11293
11294 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11295 set_window_height but set heights directly.
11296 (change_frame_size_1): Use resize_frame_windows.
11297
11298 * xdisp.c (init_xdisp): Don't use set_window_height but set
11299 heights directly.
11300
640c8776
SM
11301 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11302 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11303 run_window_configuration_change_hook.
11304
11305 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11306 instead of change_window_heights and run
11307 run_window_configuration_change_hook.
11308
1a13852e
MR
113092011-06-09 Martin Rudalics <rudalics@gmx.at>
11310
11311 * window.c (replace_window): Rename second argument REPLACEMENT to
11312 NEW. New third argument SETFLAG. Rewrite.
11313 (delete_window, make_dummy_parent): Call replace_window with
11314 third argument 1.
11315 (window_list_1): Move down in code.
11316 (run_window_configuration_change_hook): Move set_buffer part
11317 before select_frame_norecord part in order to unwind correctly.
11318 Rename count1 to count.
11319 (recombine_windows, delete_deletable_window, resize_root_window)
11320 (Fdelete_other_windows_internal)
11321 (Frun_window_configuration_change_hook, make_parent_window)
11322 (resize_window_check, resize_window_apply, Fresize_window_apply)
11323 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11324 (Fdelete_window_internal, Fresize_mini_window_internal):
11325 New functions.
1a13852e
MR
11326 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11327
f3d1777e
MR
113282011-06-08 Martin Rudalics <rudalics@gmx.at>
11329
496e208e
MR
11330 * window.h (window): Add some new members to window structure -
11331 normal_lines, normal_cols, new_total, new_normal, clone_number,
11332 splits, nest, prev_buffers, next_buffers.
11333 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11334 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11335
f3d1777e
MR
11336 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11337 Remove.
496e208e
MR
11338 (make_dummy_parent): Set new members of windows structure.
11339 (make_window): Move down in code. Handle new members of window
11340 structure.
11341 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11342 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11343 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11344 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11345 (Fset_window_next_buffers, Fset_window_clone_number):
11346 New functions.
496e208e
MR
11347 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11348 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11349 Doc-string fixes.
11350 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11351 Argument WINDOW can be now internal window too.
11352 (Fwindow_use_time): Move up in code.
11353 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11354 Rewrite doc-string.
11355 (Fset_window_configuration, saved_window)
11356 (Fcurrent_window_configuration, save_window_save): Handle new
11357 members of window structure.
b9e809c2
MR
11358 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11359 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11360 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11361 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11362 Qget_mru_window, Qresize_root_window,
11363 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11364 Qauto_buffer_name; staticpro them.
f3d1777e 11365
abde8f8c
MR
113662011-06-07 Martin Rudalics <rudalics@gmx.at>
11367
11368 * window.c (Fwindow_total_size, Fwindow_left_column)
11369 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11370 (Fwindow_list_1): New functions.
11371 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11372 (Fwindow_width, Fscroll_left, Fscroll_right):
11373 Use window_body_cols instead of window_box_text_cols.
11374 (delete_window, Fset_window_configuration):
11375 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11376 (delete_all_subwindows): Take a window as argument and not a
11377 structure. Rewrite.
190b47e6
MR
11378 (window_loop): Remove handling of GET_LRU_WINDOW and
11379 GET_LARGEST_WINDOW.
11380 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11381
11382 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11383 window_box_text_cols. delete_all_subwindows now takes a
11384 Lisp_Object as argument.
abde8f8c 11385
640c8776
SM
11386 * indent.c (compute_motion, Fcompute_motion):
11387 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11388
fa8a67e6
MR
11389 * frame.c (delete_frame): Call delete_all_subwindows with root
11390 window as argument.
11391
a54e3482
DC
113922011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11393
11394 * fns.c (Fputhash): Document return value.
11395
60002bf5
CY
113962011-06-06 Chong Yidong <cyd@stupidchicken.com>
11397
11398 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11399
0c671da6 114002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11401
b862a52a 11402 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11403
be44ca6c
PE
11404 Check for overflow when converting integer to cons and back.
11405 * charset.c (Fdefine_charset_internal, Fdecode_char):
11406 Use cons_to_unsigned to catch overflow.
11407 (Fencode_char): Use INTEGER_TO_CONS.
11408 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11409 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11410 * data.c (long_to_cons, cons_to_long): Remove.
11411 (cons_to_unsigned, cons_to_signed): New functions.
11412 These signal an error for invalid or out-of-range values.
11413 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11414 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11415 * font.c (Ffont_variation_glyphs):
11416 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11417 * lisp.h: Include <intprops.h>.
11418 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11419 (cons_to_signed, cons_to_unsigned): New decls.
11420 (long_to_cons, cons_to_long): Remove decls.
11421 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11422 (Fprimitive_undo): Use CONS_TO_INTEGER.
11423 * xfns.c (Fx_window_property): Likewise.
11424 * xselect.c: Include <limits.h>.
11425 (x_own_selection, selection_data_to_lisp_data):
11426 Use INTEGER_TO_CONS.
11427 (x_handle_selection_request, x_handle_selection_clear)
11428 (x_get_foreign_selection, Fx_disown_selection_internal)
11429 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11430 (lisp_data_to_selection_data): Use cons_to_unsigned.
11431 (x_fill_property_data): Use cons_to_signed.
11432 Report values out of range.
11433
d1f3d2af
PE
11434 Check for buffer and string overflow more precisely.
11435 * buffer.h (BUF_BYTES_MAX): New macro.
11436 * lisp.h (STRING_BYTES_MAX): New macro.
11437 * alloc.c (Fmake_string):
11438 * character.c (string_escape_byte8):
11439 * coding.c (coding_alloc_by_realloc):
11440 * doprnt.c (doprnt):
11441 * editfns.c (Fformat):
11442 * eval.c (verror):
11443 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11444 since they may not be the same number.
11445 * editfns.c (Finsert_char):
11446 * fileio.c (Finsert_file_contents):
11447 Likewise for BUF_BYTES_MAX.
11448
dd52fcea
PE
11449 * image.c: Use ptrdiff_t, not int, for sizes.
11450 (slurp_file): Switch from int to ptrdiff_t.
11451 All uses changed.
11452 (slurp_file): Check that file size fits in both size_t (for
11453 malloc) and ptrdiff_t (for sanity and safety).
11454
7f9bbdbb
PE
11455 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11456 if b->modtime has its maximal value.
11457
dfe18f82
PE
11458 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11459
84acfcf0
PE
11460 Don't assume time_t can fit into int.
11461 * buffer.h (struct buffer.modtime): Now time_t, not int.
11462 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11463 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11464
ccd9a01a
PE
11465 Minor fixes for signed vs unsigned integers.
11466 * character.h (MAYBE_UNIFY_CHAR):
11467 * charset.c (maybe_unify_char):
11468 * keyboard.c (read_char, reorder_modifiers):
11469 XINT -> XFASTINT, since the integer must be nonnegative.
11470 * ftfont.c (ftfont_spec_pattern):
11471 * keymap.c (access_keymap, silly_event_symbol_error):
11472 XUINT -> XFASTINT, since the integer must be nonnegative.
11473 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11474 since it makes no difference and we prefer signed.
11475 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11476 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11477 nonnegative.
11478
d6d100dd
SM
114792011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11480
11481 * window.h (Fwindow_frame): Declare.
11482
2b6148e4
PE
114832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11484
11485 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11486 (SPARE_MEMORY): Always define.
11487 (LARGE_REQUEST): Remove.
11488 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11489
f230ecc9
MR
114902011-06-06 Martin Rudalics <rudalics@gmx.at>
11491
727e958e
MR
11492 * lisp.h: Move EXFUNS for Fframe_root_window,
11493 Fframe_first_window and Fset_frame_selected_window to window.h.
11494
11495 * window.h: Move EXFUNS for Fframe_root_window,
11496 Fframe_first_window and Fset_frame_selected_window here from
11497 lisp.h.
11498
11499 * frame.c (Fwindow_frame, Fframe_first_window)
11500 (Fframe_root_window, Fframe_selected_window)
11501 (Fset_frame_selected_window): Move to window.c.
11502 (Factive_minibuffer_window): Move to minibuf.c.
11503 (Fother_visible_frames_p): New function.
11504
11505 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11506
f230ecc9
MR
11507 * window.c (decode_window, decode_any_window): Move up in code.
11508 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11509 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11510 (Fwindow_buffer): Move up and rewrite doc-string.
11511 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11512 (Fwindow_prev): New functions.
727e958e
MR
11513 (Fwindow_frame): Move here from frame.c. Accept any window as
11514 argument.
11515 (Fframe_root_window, Fframe_first_window)
11516 (Fframe_selected_window): Move here from frame.c. Accept frame
11517 or arbitrary window as argument. Update doc-strings.
11518 (Fminibuffer_window): Move up in code.
11519 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11520 (Fset_frame_selected_window): Move here from frame.c.
11521 Marginal rewrite.
727e958e
MR
11522 (Fselected_window, select_window, Fselect_window): Move up in
11523 code. Minor doc-string fixes.
f230ecc9 11524
4d09bcf6
PE
115252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11526
11527 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11528 Do not assume that spare memory exists; that assumption is valid
11529 only if SYSTEM_MALLOC.
11530 (LARGE_REQUEST): New macro, so that the issue of large requests
11531 is separated from the issue of spare memory.
11532
810928a2
AS
115332011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11534
172418ad
AS
11535 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11536 format. (Bug#8806)
11537
43f862f7
AS
11538 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11539
810928a2
AS
11540 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11541 before statements.
11542
a059fe24
JD
115432011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11544
11545 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11546
11547 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11548
11549 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11550 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11551
989bf368
JB
115522011-06-05 Juanma Barranquero <lekktu@gmail.com>
11553
11554 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11555
4b80f674
CY
115562011-06-04 Chong Yidong <cyd@stupidchicken.com>
11557
11558 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11559 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11560 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11561 New error handlers.
4b80f674
CY
11562 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11563 Obey Vx_select_enable_clipboard_manager. Catch errors in
11564 x_clipboard_manager_save (Bug#8779).
11565 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11566 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11567
99a33b77 115682011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11569
11570 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11571
99a33b77 115722011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11573
11574 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11575 in the current matrix if keep_current_p is non-zero.
11576
8264569d
EZ
115772011-06-04 Eli Zaretskii <eliz@gnu.org>
11578
11579 * bidi.c (bidi_level_of_next_char): Fix last change.
11580
57f97249
EZ
115812011-06-03 Eli Zaretskii <eliz@gnu.org>
11582
fec2107c 11583 Support bidi reordering of text covered by display properties.
57f97249 11584
fec2107c
EZ
11585 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11586 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11587 (bidi_cache_search, bidi_cache_iterator_state)
11588 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11589 (bidi_level_of_next_char, bidi_move_to_visually_next):
11590 Support character positions inside a run of characters covered by a
fec2107c
EZ
11591 display string.
11592 (bidi_paragraph_init, bidi_resolve_explicit_1)
11593 (bidi_level_of_next_char): Call bidi_fetch_char and
11594 bidi_fetch_char_advance instead of FETCH_CHAR and
11595 FETCH_CHAR_ADVANCE.
11596 (bidi_init_it): Initialize new members.
11597 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11598 definitions.
11599 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11600 instead of using explicit *_CHAR codes.
d6d100dd
SM
11601 (bidi_resolve_explicit, bidi_resolve_weak):
11602 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11603 bidirectional text is supported only in multibyte buffers.
11604 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11605 it to initialize the frame_window_p member of struct bidi_it.
11606 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11607 (bidi_resolve_explicit, bidi_resolve_weak)
11608 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11609 bidi_it->nchars is non-positive.
11610 (bidi_level_of_next_char): Don't try to lookup the cache for the
11611 next/previous character if nothing is cached there yet, or if we
11612 were just reseat()'ed to a new position.
c40e2fb2 11613
0e14fe90
EZ
11614 * xdisp.c (set_cursor_from_row): Set start and stop points
11615 according to the row's direction when priming the loop that looks
11616 for the glyph on which to display cursor.
11617 (single_display_spec_intangible_p): Function deleted.
11618 (display_prop_intangible_p): Reimplement to call
11619 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11620 Accept 3 additional arguments needed by handle_display_spec.
11621 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11622 values: lists, `(when COND...)' forms, etc.
11623 (single_display_spec_string_p): Support property values that are
11624 lists with the argument STRING its top-level element.
11625 (display_prop_string_p): Fix the condition for processing a
11626 property that is a list to be consistent with handle_display_spec.
fec2107c 11627 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11628 last portion of handle_display_prop.
11629 (compute_display_string_pos): Accept additional argument
11630 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11631 value of a `display' property is a "replacing spec".
11632 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11633 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11634 the display property, but just return a value indicating whether
11635 the display property will replace the characters it covers.
11636 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11637 frame_window_p members of struct bidi_it.
d6d100dd
SM
11638 (compute_display_string_pos, compute_display_string_end):
11639 New functions.
fec2107c
EZ
11640 (push_it): Accept second argument POSITION, where pop_it should
11641 jump to continue iteration.
11642 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11643
fec2107c
EZ
11644 * keyboard.c (adjust_point_for_property): Adjust the call to
11645 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11646
11647 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11648 (bidi_init_it): Update prototypes.
11649 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11650 (compute_display_string_pos, compute_display_string_end):
11651 Declare prototypes.
fec2107c
EZ
11652 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11653 EMACS_INT.
fc6f18ce 11654
40087514 116552011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11656
57f53182
PE
11657 Malloc failure behavior now depends on size of allocation.
11658 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11659 * lisp.h: Change signatures accordingly.
11660 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11661 All callers changed. (Bug#8762)
11662
11663 * gnutls.c: Use Emacs's memory allocators.
11664 Without this change, the gnutls library would invoke malloc etc.
11665 directly, which causes problems on non-SYNC_INPUT hosts, and which
11666 runs afoul of improving memory_full behavior. (Bug#8761)
11667 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11668 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11669 xfree instead of the default malloc, realloc, free.
11670 (Fgnutls_boot): No need to check for memory allocation failure,
11671 since xmalloc does that for us.
11672
ac32cd99 11673 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11674 * category.c (hash_get_category_set):
11675 * ccl.c (ccl_driver):
11676 * charset.c (Fdefine_charset_internal):
11677 * charset.h (struct charset.hash_index):
11678 * composite.c (get_composition_id, gstring_lookup_cache)
11679 (composition_gstring_put_cache):
11680 * composite.h (struct composition.hash_index):
11681 * dispextern.h (struct image.hash):
11682 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11683 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11684 (hashfn_equal, hashfn_user_defined, make_hash_table)
11685 (maybe_resize_hash_table, hash_lookup, hash_put)
11686 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11687 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11688 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11689 * image.c (make_image, search_image_cache, lookup_image)
11690 (xpm_put_color_table_h):
11691 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11692 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11693 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11694 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11695 * alloc.c (allocate_vectorlike):
11696 Check for overflow in vector size calculations.
11697 * ccl.c (ccl_driver):
11698 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11699 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11700 need to be updated by these changes.
40087514
PE
11701 * fns.c (make_hash_table, maybe_resize_hash_table):
11702 Check for integer overflow with large hash tables.
0de4bb68
PE
11703 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11704 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11705 (SXHASH_REDUCE): New macro.
11706 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11707 Use it instead of discarding useful hash info with large hash values.
11708 (sxhash_float): New function.
11709 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11710 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11711 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11712 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11713 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11714 Adjust signatures to match updated version of code.
11715 (consing_since_gc): Now EMACS_INT, since a single hash table can
11716 use more than INT_MAX bytes.
11717
698d32e2
DN
117182011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11719
11720 Make it possible to build with GCC-4.6+ -O2 -flto.
11721
11722 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11723
fd6fa53f
SM
117242011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11725
11726 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11727 Call minibuffer-inactive-mode.
11728
864db017
JB
117292011-05-31 Juanma Barranquero <lekktu@gmail.com>
11730
11731 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11732 Update dependencies.
11733
2ad0baf4
DN
117342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11735
11736 * data.c (init_data): Remove code for UTS, this system is not
11737 supported anymore.
11738
4fcc2638
DN
117392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11740
11741 Don't force ./temacs to start in terminal mode.
11742
11743 * frame.c (make_initial_frame): Initialize faces in all cases, not
11744 only when CANNOT_DUMP is defined.
11745 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11746
c56e0fd5
DN
117472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11748
11749 * dispnew.c (add_window_display_history): Use const for the string
11750 pointer. Remove declaration, not needed.
11751
333d54da 117522011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11753
55d4c1b2 11754 Use 'inline', not 'INLINE'.
333d54da 11755 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11756 * alloc.c, fontset.c (INLINE): Remove.
11757 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11758 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11759 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11760 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11761 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11762
738db178
DN
117632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11764
11765 Make it possible to run ./temacs.
11766
11767 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11768 syms_of_callproc does the same thing. Remove test for
11769 "initialized", do it in the caller.
11770 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11771
620c53a6
SM
117722011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11773
11774 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11775 (read_minibuf): Use get_minibuffer.
11776 (syms_of_minibuf): Use DEFSYM.
11777 (Qmetadata): New var.
11778 * data.c (Qbuffer): Don't make it static.
11779 (syms_of_data): Use DEFSYM.
11780
e003a292
PE
117812011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11782
11783 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11784 (CCL_CODE_MIN): New macro.
11785
ed008a6d
PE
117862011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11787
3687c2ef
PE
11788 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11789
ed008a6d
PE
11790 * eval.c (Qdebug): Now static.
11791 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11792 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11793 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11794
d66c4c7c
CY
117952011-05-29 Chong Yidong <cyd@stupidchicken.com>
11796
11797 * image.c: Various fixes to ImageMagick code comments.
11798 (Fimagemagick_types): Doc fix.
11799
5fbc2025
PE
118002011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11801
0196f88a
PE
11802 Minor fixes prompted by GCC 4.6.0 warnings.
11803
11804 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11805
5fbc2025
PE
11806 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11807 (x_clipboard_manager_save_all): Move extern decl to ...
11808 * xterm.h: ... here, so that it can be checked for consistency.
11809
1dd3c2d9
CY
118102011-05-29 Chong Yidong <cyd@stupidchicken.com>
11811
11812 * xselect.c (x_clipboard_manager_save_frame)
11813 (x_clipboard_manager_save_all): New functions.
11814 (Fx_clipboard_manager_save): Lisp function deleted.
11815
11816 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11817 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11818
11819 * xterm.h: Update prototype.
11820
5ba6571d
WX
118212011-05-28 William Xu <william.xwl@gmail.com>
11822
11823 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11824 exiting (Bug#8239).
11825
3eaff834
JM
118262011-05-28 Jim Meyering <meyering@redhat.com>
11827
e1900994 11828 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11829 * fns.c (to_uchar): Define.
11830 (crypto_hash_function): Use it to convert some newly-signed
11831 variables to unsigned, to avoid sign-extension bugs. For example,
11832 without this change, (md5 "truc") would evaluate to
11833 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11834 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11835 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11836
0f6990a7
PE
118372011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11838
11839 Integer overflow fixes.
c8a9ca5a 11840
08686060
PE
11841 * dbusbind.c: Serial number integer overflow fixes.
11842 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11843 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11844 to hold a serial number that is too large for a fixnum.
11845 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11846 Check for serial numbers out of range. Decode any serial number
59568bf0 11847 that was so large that it became a float. (Bug#8722)
08686060 11848
2d1fc3c7
PE
11849 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11850 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11851 Use XFASTINT rather than XUINT when numbers are nonnegative.
11852 (xd_append_arg, Fdbus_method_return_internal):
11853 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11854 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11855 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11856 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11857 (Bug#8722)
2d1fc3c7 11858
c8a9ca5a
PE
11859 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11860
519e1d69
PE
11861 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11862
6df6ae42 11863 ccl: Add integer overflow checks.
30569699
PE
11864 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11865 (IN_INT_RANGE): New macros.
11866 (ccl_driver): Use them to check for integer overflow when
11867 decoding a CCL program. Many of the new checks are whether XINT (x)
11868 fits in int; it doesn't always, on 64-bit hosts. The new version
11869 doesn't catch all possible integer overflows, but it's an
847044ea 11870 improvement. (Bug#8719)
30569699 11871
c11285dc
PE
11872 * alloc.c (make_event_array): Use XINT, not XUINT.
11873 There's no need for unsigned here.
11874
fdccd48e
PE
11875 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11876 This follows up to the 2011-05-06 change that substituted uintptr_t
11877 for EMACS_INT. This case wasn't caught back then.
11878
37910ab2
PE
11879 Rework Fformat to avoid integer overflow issues.
11880 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11881 now (part of C89). Include <verify.h>.
11882 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11883 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11884 (Fformat): Avoid the prepass trying to compute sizes; it was only
11885 approximate and thus did not catch overflow reliably. Instead, walk
11886 through the format just once, formatting and computing sizes as we go,
11887 checking for integer overflow at every step, and allocating a larger
11888 buffer as needed. Keep track separately whether the format is
11889 multibyte. Keep only the most-recently calculated precision, rather
11890 than them all. Record whether each argument has been converted to
11891 string. Use EMACS_INT, not int, for byte and char and arg counts.
11892 Support field widths and precisions larger than INT_MAX. Avoid
11893 sprintf's undefined behavior with conversion specifications such as %#d
11894 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11895 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11896 formatting out-of-range floating point numbers with int
9173deec 11897 formats. (Bug#8668)
37910ab2 11898
2e6578fb
PE
11899 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11900
0ae6bdee
PE
11901 * data.c: Avoid integer truncation in expressions involving floats.
11902 * data.c: Include <intprops.h>.
11903 (arith_driver): When there's an integer overflow in an expression
11904 involving floating point, convert the integers to floating point
11905 so that the resulting value does not suffer from catastrophic
11906 integer truncation. For example, on a 64-bit host (* 4
11907 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11908 Do not rely on undefined behavior after integer overflow.
11909
de883a70
PE
11910 merge count_size_as_multibyte, parse_str_to_multibyte
11911 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11912 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11913 Check for integer overflow.
11914 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11915 since it's now a duplicate of the other. This is more of
11916 a character than a buffer op, so better that it's in character.c.
11917 * fns.c, print.c: Adjust to above changes.
11918
2ff916cb
PE
119192011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11920
11921 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11922
f1b54466
PE
119232011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11924
fb1ac845
PE
11925 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11926 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11927 (x_clipboard_manager_save): Now static.
11928 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11929
f1b54466
PE
11930 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11931 (crypto_hash_function): Now static.
11932 Fix pointer signedness problems. Avoid unnecessary initializations.
11933
a9f737ee
CY
119342011-05-27 Chong Yidong <cyd@stupidchicken.com>
11935
11936 * termhooks.h (Vselection_alist): Make it terminal-local.
11937
11938 * terminal.c (create_terminal): Initialize it.
11939
11940 * xselect.c: Support for clipboard managers.
11941 (Vselection_alist): Move to termhooks.h as terminal-local var.
11942 (LOCAL_SELECTION): New macro.
11943 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11944 (symbol_to_x_atom): Remove gratuitous arg.
11945 (x_handle_selection_request, lisp_data_to_selection_data)
11946 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11947 (x_own_selection, x_get_local_selection, x_convert_selection):
11948 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11949 (some_frame_on_display): Delete unused function.
11950 (Fx_own_selection_internal, Fx_get_selection_internal)
11951 (Fx_disown_selection_internal, Fx_selection_owner_p)
11952 (Fx_selection_exists_p): New optional frame arg.
11953 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11954 (x_handle_selection_clear): Don't treat other terminals with the
11955 same keyboard specially. Use the terminal-local Vselection_alist.
11956 (x_clear_frame_selections): Use Frun_hook_with_args.
11957
11958 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11959
11960 * xterm.h: Add support for those atoms.
11961
e067f0c1
CY
119622011-05-26 Chong Yidong <cyd@stupidchicken.com>
11963
11964 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11965 (converted_selections, conversion_fail_tag): New global variables.
11966 (x_selection_request_lisp_error): Free the above.
11967 (x_get_local_selection): Remove unnecessary code.
11968 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11969 of converted selections stored in converted_selections.
11970 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11971 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11972 (x_convert_selection): New function.
11973 (x_handle_selection_event): Simplify.
11974 (x_get_foreign_selection): Don't ignore incoming requests while
11975 waiting for an answer; this will fail when we implement
11976 SAVE_TARGETS, and seems unnecessary anyway.
11977 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11978 (Vx_sent_selection_functions): Doc fix.
11979
0f4aebc0
LL
119802011-05-26 Leo Liu <sdl.web@gmail.com>
11981
11982 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11983
e61124cd
YM
119842011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11985
11986 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11987
11988 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11989 for fringe update if it has periodic bitmap.
ac389d0c 11990 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11991 and fringe_bitmap_periodic_p.
11992
11993 * fringe.c (get_fringe_bitmap_data): New function.
11994 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11995 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11996 row. Mark glyph row for fringe update if periodicity changed.
11997
11998 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11999 for fringe update unless it has periodic bitmap.
12000
f16d9837
KH
120012011-05-25 Kenichi Handa <handa@m17n.org>
12002
12003 * xdisp.c (get_next_display_element): Set correct it->face_id for
12004 a static composition.
12005
e1b90ef6
LL
120062011-05-24 Leo Liu <sdl.web@gmail.com>
12007
12008 * deps.mk (fns.o):
12009 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12010
12011 * fns.c (crypto_hash_function, Fsha1): New function.
12012 (Fmd5): Use crypto_hash_function.
12013 (syms_of_fns): Add Ssha1.
12014
7400048f
PE
120152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12016
12017 * gnutls.c: Remove unused macros.
12018 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12019 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12020 Remove macros that are defined and never used.
12021 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12022
abb71cf4
CY
120232011-05-22 Chong Yidong <cyd@stupidchicken.com>
12024
12025 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12026 (Fx_get_selection_internal): Minor cleanup.
12027 (Fx_own_selection_internal): Rename arguments for consistency with
12028 select.el.
12029
6307db39
PE
120302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12031
12032 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12033
f3d4e0a4
CY
120342011-05-22 Chong Yidong <cyd@stupidchicken.com>
12035
12036 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12037
4d8ade89
YM
120382011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12039
12040 * dispnew.c (scrolling_window): Don't exclude the case that the
12041 last enabled row in the desired matrix touches the bottom boundary.
12042
32078c8d
GM
120432011-05-21 Glenn Morris <rgm@gnu.org>
12044
12045 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12046 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12047 and add some more files.
32078c8d 12048
7285dc67
EZ
120492011-05-20 Eli Zaretskii <eliz@gnu.org>
12050
12051 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12052 report_file_error introduced by the change from 2011-05-07.
12053
89d1bd22
PE
120542011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12055
12056 * systime.h (Time): Define only if emacs is defined.
12057 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12058 where the include path doesn't have X11/X.h by default. See
12059 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12060
cd394be1 120612011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12062
12063 * composite.c (find_automatic_composition): Fix previous change.
12064
b9704ad9
GM
120652011-05-20 Glenn Morris <rgm@gnu.org>
12066
12067 * lisp.mk: New file, split from Makefile.in.
12068 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12069 (shortlisp): Remove.
12070 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12071
4a720484
GM
120722011-05-19 Glenn Morris <rgm@gnu.org>
12073
12074 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12075 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12076 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12077 (lisp): Set the order to that of loadup.el.
12078 (shortlisp): Make it a copy of $lisp.
12079 (SOME_MACHINE_LISP): Remove.
12080 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12081 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12082
a28d4396
KH
120832011-05-18 Kenichi Handa <handa@m17n.org>
12084
12085 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12086 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12087 (find_automatic_composition): Mostly rewrite for efficiency.
12088
a2b1fa8e
JB
120892011-05-18 Juanma Barranquero <lekktu@gmail.com>
12090
12091 * makefile.w32-in: Update dependencies.
12092
8e1f5610
CS
120932011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12094
12095 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12096 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12097
7025ee00 120982011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12099
cdfa6eab
PE
12100 Fix some integer overflow issues, such as string length overflow.
12101
06d6db33
PE
12102 * insdel.c (count_size_as_multibyte): Check for string overflow.
12103
2b4560a8
PE
12104 * character.c (lisp_string_width): Check for string overflow.
12105 Use EMACS_INT, not int, for string indexes and lengths; in
12106 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12107 the resulting string length overflows an EMACS_INT; instead,
12108 report a string overflow if no precision given. When checking for
12109 precision exhaustion, use a check that cannot possibly have
12110 integer overflow. (Bug#8675)
12111 * character.h (lisp_string_width): Adjust to new signature.
12112
cb93f9be
PE
12113 * alloc.c (string_overflow): New function.
12114 (Fmake_string): Use it. This doesn't change behavior, but saves
12115 a few bytes and will simplify future changes.
12116 * character.c (string_escape_byte8): Likewise.
12117 * lisp.h (string_overflow): New decl.
12118
1a1f3366
PE
12119 Fixups, following up to the user-interface timestamp change.
12120 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12121 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12122 * msdos.c (mouse_get_pos): Likewise.
12123 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12124 * w32gui.h (Time): Define by including "systime.h" rather than by
12125 declaring it ourselves. (Bug#8664)
12126
d4e3e4d3
PE
12127 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12128 * image.c (clear_image_cache): Likewise.
12129
f6a24d19
PE
12130 * term.c (term_mouse_position): Don't assume time_t wraparound.
12131
08dc5ae6
PE
12132 Be more systematic about user-interface timestamps.
12133 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12134 and sometimes 'EMACS_UINT', to represent these timestamps.
12135 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12136 This makes the code easier to follow, and makes it easier to catch
12137 integer overflow bugs such as Bug#8664.
12138 * frame.c (Fmouse_position, Fmouse_pixel_position):
12139 Use Time, not unsigned long, for user-interface timestamps.
12140 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12141 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12142 * keyboard.h (last_event_timestamp): Likewise.
12143 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12144 * menu.h (xmenu_show): Likewise.
12145 * term.c (term_mouse_position): Likewise.
12146 * termhooks.h (struct input_event.timestamp): Likewise.
12147 (struct terminal.mouse_position_hook): Likewise.
12148 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12149 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12150 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12151 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12152 what it was before.
12153 * menu.h, termhooks.h: Include "systime.h", for Time.
12154
8e55734a
PE
12155 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12156 Don't assume that the difference between two unsigned long values
12157 can fit into an integer. At this point, we know button_down_time
12158 <= event->timestamp, so the difference must be nonnegative, so
12159 there's no need to cast the result if double-click-time is
12160 nonnegative, as it should be; check that it's nonnegative, just in
12161 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12162 apart (about 25 days). (Bug#8664)
8e55734a 12163
841f1b75 12164 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12165 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12166
3e26f69c
PE
12167 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12168 that always fit in int. Use a sentinel instead of a counter, to
12169 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12170 * frame.h (struct frame): Use int for menu_bar_items_used
12171 instead of EMACS_INT, since it always fits in int.
3e26f69c 12172
5cc152c0
PE
12173 * menu.c (grow_menu_items): Check for int overflow.
12174
d89eb65e
PE
12175 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12176
5235bd3e
PE
12177 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12178 Before, the code was not consistent. These values cannot exceed
12179 2**31 - 1 so there's no need to make them unsigned.
12180 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12181 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12182 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12183 as modifiers.
12184 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12185
bc827e23
PE
12186 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12187 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12188 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12189 presumably because the widths might not match.
12190
78eb494e
PE
12191 * window.c (size_window): Avoid needless test at loop start.
12192
04f2d78b
CB
121932011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12194
12195 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12196
d2fc7e3d 121972011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12198
12199 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12200
d2fc7e3d 122012011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12202
12203 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12204 `width' to `bar_area_x' and `bar_area_width', respectively.
12205 (x_scroll_run): Take account of fringe background extension.
12206
04f2d78b
CB
12207 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12208 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12209 `bar_area_width', respectively.
12210 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12211 background extension.
12212
79b70037
GM
122132011-05-10 Jim Meyering <meyering@redhat.com>
12214
12215 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12216
2f142cc5
JB
122172011-05-10 Juanma Barranquero <lekktu@gmail.com>
12218
12219 * image.c (Finit_image_library): Return t for built-in image types,
12220 like pbm and xbm. (Bug#8640)
12221
57679c86
AS
122222011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12223
12224 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12225
888c9e86
EZ
122262011-05-07 Eli Zaretskii <eliz@gnu.org>
12227
b0512a1d
EZ
12228 * w32console.c (Fset_screen_color): Doc fix.
12229 (Fget_screen_color): New function.
12230 (syms_of_ntterm): Defsubr it.
12231
7285dc67
EZ
12232 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12233 unlink the temporary file if Fcall_process didn't create it in the
12234 first place.
12235 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12236 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12237 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12238 cue to call_process_cleanup not to close that handle.
12239
4d3fcc8e
BK
122402011-05-07 Ben Key <bkey76@gmail.com>
12241
12242 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12243 one of two shell specific rules, either bootstrap-temacs-CMD or
12244 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12245 to the previous implementation of the bootstrap-temacs rule.
12246 The bootstrap-temacs-CMD rule is similar to the previous
12247 implementation of the bootstrap-temacs rule except that it
12248 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12249 variable.
12250
12251 These changes, along with some changes to nt/configure.bat,
12252 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12253 earlier fix to add support for --cflags and --ldflags options
12254 that include quotes so that it works whether make uses cmd or
12255 sh as the shell.
12256
b4289b64
MA
122572011-05-06 Michael Albinus <michael.albinus@gmx.de>
12258
12259 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12260 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12261 is a constant.
12262 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12263 a string. Handle both cases.
12264 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12265 (Fdbus_register_method): Use Qinvalid_function.
12266
af4c0e28
JB
122672011-05-06 Juanma Barranquero <lekktu@gmail.com>
12268
12269 * makefile.w32-in: Update dependencies.
12270 (LISP_H): Add inttypes.h and stdin.h.
12271 (PROCESS_H): Add unistd.h.
12272
c51453d9
EZ
122732011-05-06 Eli Zaretskii <eliz@gnu.org>
12274
12275 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12276 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12277
8ff0ac3c 122782011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12279
4c4b566b
PE
12280 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12281
aab2b9b5
PE
12282 * term.c (vfatal): Remove stray call to va_end.
12283 It's not needed and the C Standard doesn't allow it here anyway.
12284
c378da0b
PE
12285 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12286 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12287
288b08c7
PE
12288 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12289 bytes.
12290
e3601888
PE
12291 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12292
db6c0e74
PE
12293 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12294
dd5963ea
PE
12295 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12296
88c9450f
PE
12297 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12298
2f9442b8
PE
12299 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12300
c032b5f8
PE
12301 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12302 * charset.c (Fdefine_charset_internal): Don't initialize
12303 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12304 32-bit int (Bug#8600).
a108c10b
PE
12305
12306 * lread.c (read_integer): Be more consistent with string-to-number.
12307 Use string_to_number to do the actual conversion; this avoids
12308 rounding errors and fixes some other screwups. Without this fix,
12309 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12310 (digit_to_number): Move earlier, for benefit of read_integer.
12311 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12312 not a digit in any supported base. (Bug#8602)
a108c10b 12313
ad5f9eea
PE
12314 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12315
aec1708a
PE
12316 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12317 to match comment at start of function. This also removes a
12318 GCC warning about overflow in a 32+64-bit port.
12319
47be4ab5
PE
12320 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12321
371cac43
PE
12322 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12323 Reported by Stefan Monnier in
12324 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12325 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12326 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12327
d01a7826
PE
12328 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12329 (EMACS_UINTPTR): Likewise, with uintptr_t.
12330
7fd47d5c
PE
12331 * lisp.h: Prefer 64-bit EMACS_INT if available.
12332 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12333 on 32-bit hosts that have 64-bit int, so that they can access
12334 large files.
122b0c86
PE
12335 However, temporarily disable this change unless the temporary
12336 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12337
8727937b
PE
12338 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12339
8ac068ac
PE
12340 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12341 This removes an assumption that EMACS_INT and long are the same
12342 width as pointers. The assumption is true for Emacs porting targets
12343 now, but we want to make other targets possible.
12344 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12345 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12346 In the rest of the code, change types of integers that hold casted
12347 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12348 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12349 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12350 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12351 No need to cast type when ORing.
12352 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12353 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12354 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12355 assume EMACS_INT is the same width as char *.
12356 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12357 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12358 Remove no-longer-needed casts.
12359 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12360 (xg_tool_bar_help_callback, xg_make_tool_item):
12361 Use EMACS_INTPTR to hold an integer
12362 that will be cast to void *; this can avoid a GCC warning
12363 if EMACS_INT is not the same width as void *.
12364 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12365 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12366 (current_message_1, set_message_1):
12367 Use a local to convert to proper width without a cast.
12368 * xmenu.c (dialog_selection_callback): Likewise.
12369
ede49d71
PE
12370 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12371 Also, don't assume VALBITS / RAND_BITS is less than 5,
12372 and don't rely on undefined behavior when shifting a 1 left into
12373 the sign bit.
12374 * lisp.h (get_random): Change signature to match.
12375
2f30ecd0
PE
12376 * lread.c (hash_string): Use size_t, not int, for hash computation.
12377 Normally we prefer signed values; but hashing is special, because
12378 it's better to use unsigned division on hash table sizes so that
12379 the remainder is nonnegative. Also, size_t is the natural width
12380 for hashing into memory. The previous code used 'int', which doesn't
12381 retain enough info to hash well into very large tables.
12382 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12383
2a866e7b
PE
12384 * dbusbind.c: Don't possibly lose pointer info when converting.
12385 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12386 Use XPNTR rather than XHASH, so that the high-order bits of
12387 the pointer aren't lost when converting through void *.
12388
51639eac
PE
12389 * eval.c (Fautoload): Don't double-shift a pointer.
12390
92394119
PE
12391 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12392
dbdb9a7c
JB
123932011-05-06 Juanma Barranquero <lekktu@gmail.com>
12394
12395 * gnutls.c (DEF_GNUTLS_FN):
12396 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12397
db7a0b4f
AS
123982011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12399
12400 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12401 marker. (Bug#8610)
12402
cd394be1 124032011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12404
12405 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12406 New version that can reserve upto 2GB of heap space.
12407
f7ff1b0f 124082011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12409
12410 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12411
639c109b
TZ
124122011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12413
12414 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12415 `gnutls_certificate_set_x509_key_file'.
12416
d2127135
JB
124172011-05-05 Juanma Barranquero <lekktu@gmail.com>
12418
12419 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12420 Update dependencies.
12421
e968f4f3
JB
124222011-05-04 Juanma Barranquero <lekktu@gmail.com>
12423
12424 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12425 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12426 Remove unused parameter `fildes'.
12427 * process.c (read_process_output, send_process): Don't pass it.
12428
84d358f0
JB
124292011-05-04 Juanma Barranquero <lekktu@gmail.com>
12430
12431 Fix previous change: the library cache is defined in w32.c.
12432 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12433 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12434
0898ca10
JB
124352011-05-04 Juanma Barranquero <lekktu@gmail.com>
12436
12437 Implement dynamic loading of GnuTLS on Windows.
12438
12439 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12440 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12441 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12442 Declare.
12443
12444 * gnutls.c (Qgnutls_dll): Define.
12445 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12446 (gnutls_*): Declare function pointers.
12447 (init_gnutls_functions): New function to initialize function pointers.
12448 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12449 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12450 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12451 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12452 (emacs_gnutls_write, emacs_gnutls_read)
12453 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12454 (Fgnutls_available_p): New function.
12455 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12456 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12457 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12458
12459 * image.c: Include w32.h.
12460 (Vimage_type_cache): Delete.
12461 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12462 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12463 (w32_delayed_load): Move to w32.c.
12464
12465 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12466
12467 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12468 (w32_delayed_load): Move from image.c. When loading a library, record
12469 its filename in the :loaded-from property of the library id.
12470 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12471 Initialize and staticpro them.
12472 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12473
12474 * process.c: Include lisp.h before w32.h, not after.
12475 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12476 instead of gnutls_record_check_pending.
12477
12478 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12479
ff4de4aa
TZ
124802011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12481
12482 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12483 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12484 as passed in.
12485
abe95abb
JD
124862011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12487
12488 * xterm.c (x_set_frame_alpha): Do not set property on anything
12489 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12490
e16e55d4
JB
124912011-05-02 Juanma Barranquero <lekktu@gmail.com>
12492
12493 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12494
bafcf6a5
JB
124952011-05-02 Juanma Barranquero <lekktu@gmail.com>
12496
12497 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12498 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12499 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12500 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12501 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12502 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12503 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12504 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12505 (Qgnutls_bootprop_callbacks_verify): Make static.
12506
e7a6747f
AS
125072011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12508
19ed11ba
AS
12509 * callproc.c: Indentation fixup.
12510
e7a6747f 12511 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12512 (wait_for_termination, interruptible_wait_for_termination):
12513 Move after wait_for_termination_1.
e7a6747f 12514
1ef14cb4
LMI
125152011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12516
12517 * sysdep.c (interruptible_wait_for_termination): New function
12518 which is like wait_for_termination, but allows keyboard
12519 interruptions.
12520
12521 * callproc.c (Fcall_process): Add (:file "file") as an option for
12522 the STDOUT buffer.
12523 (Fcall_process_region): Ditto.
12524
330d880c
EZ
125252011-04-30 Eli Zaretskii <eliz@gnu.org>
12526
8db90b73
EZ
12527 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12528 rather than `XVECTOR (FOO)->size'.
12529
330d880c
EZ
12530 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12531 inttypes.h, as a gnulib replacement is used if it not available in
12532 system headers.
12533
15cbd324
EZ
125342011-04-21 Eli Zaretskii <eliz@gnu.org>
12535
12536 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12537 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12538 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12539
12540 * coding.c (coding_alloc_by_realloc): Error out if destination
12541 will grow beyond MOST_POSITIVE_FIXNUM.
12542 (decode_coding_emacs_mule): Abort if there isn't enough place in
12543 charbuf for the composition carryover bytes. Reserve an extra
12544 space for up to 2 characters produced in a loop.
12545 (decode_coding_iso_2022): Abort if there isn't enough place in
12546 charbuf for the composition carryover bytes.
12547
125482011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12549
ae940cca
EZ
12550 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12551 aborting when %lld or %lll format is passed.
12552 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12553 %llo or %llx format is passed. (Bug#8545)
12554
03ab8921
EZ
12555 * window.c (window_scroll_line_based): Use a marker instead of
12556 simple variables to record original value of point. (Bug#7952)
12557
afda1437
EZ
12558 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12559 produced by %s or %c overflows available buffer space. (Bug#8545)
12560
f76dee0c
PE
125612011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12562
12563 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12564 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12565
fdc5744d
JB
125662011-04-28 Juanma Barranquero <lekktu@gmail.com>
12567
12568 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12569
638f053a
JB
125702011-04-28 Juanma Barranquero <lekktu@gmail.com>
12571
12572 * keyboard.c (Qdelayed_warnings_hook): Define.
12573 (command_loop_1): Run `delayed-warnings-hook'
12574 if Vdelayed_warnings_list is non-nil.
12575 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12576 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12577
d178f871
EZ
125782011-04-28 Eli Zaretskii <eliz@gnu.org>
12579
12580 * doprnt.c (doprnt): Don't return value smaller than the buffer
12581 size if the message was truncated. (Bug#8545).
12582
b124fd93
JB
125832011-04-28 Juanma Barranquero <lekktu@gmail.com>
12584
12585 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12586 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12587
e810457d
PE
125882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12589
12590 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12591
ea51cceb
JB
125922011-04-27 Juanma Barranquero <lekktu@gmail.com>
12593
12594 * makefile.w32-in: Update dependencies.
12595
94dcfacf
EZ
125962011-04-27 Eli Zaretskii <eliz@gnu.org>
12597
12598 Improve `doprnt' and its usage. (Bug#8545)
12599 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12600 `format_end'. Remove support for %l as a conversion specifier.
12601 Don't use xrealloc. Improve diagnostics when the %l size modifier
12602 is used. Update the commentary.
12603
12604 * eval.c (verror): Simplify calculation of size_t.
12605
12606 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12607 messages.
12608
f61f41d7
PE
126092011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12610
12611 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12612 change.
12613
96fb4434
PE
126142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12615
12616 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12617 This makes this file independent of the recent pseudovector change.
12618
671875da 126192011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12620
69e9b5a3
PE
12621 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12622
b5f869a7 12623 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12624 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12625 Remove unused local.
c8926152 12626 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12627
841a1577 12628 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12629 GCC 4.6.0 optimizes based on type-based alias analysis.
12630 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12631 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12632 != &v->size, and therefore "v->size = 1; b->size = 2; return
12633 v->size;" must therefore return 1. This assumption is incorrect
12634 for Emacs, since it type-puns struct Lisp_Vector * with many other
12635 types. To fix this problem, this patch adds a new type struct
f904488f 12636 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12637 and pseudovectors, and helps optimizing compilers not get fooled
12638 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12639 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12640 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12641 the size member.
eab3844f
PE
12642 (XSETPVECTYPE): Rewrite in terms of new macro.
12643 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12644 This is a bit clearer, and further avoids the possibility of
12645 undesirable aliasing.
12646 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12647 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12648 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12649 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12650 (ASIZE): Now uses header.size rather than size.
12651 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12652 to avoid the hassle of writing XVECTOR (foo)->header.size.
12653 (struct vectorlike_header): New type.
eab3844f
PE
12654 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12655 object, to help avoid aliasing.
12656 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12657 (SUBRP): Likewise, since Lisp_Subr is a special case.
12658 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12659 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12660 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12661 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12662 changed to be "header.size" and "header.next".
12663 * buffer.h (struct buffer): Likewise.
12664 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12665 * frame.h (struct frame): Likewise.
12666 * process.h (struct Lisp_Process): Likewise.
12667 * termhooks.h (struct terminal): Likewise.
12668 * window.c (struct save_window_data, struct saved_window): Likewise.
12669 * window.h (struct window): Likewise.
12670 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12671 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12672 * buffer.c (init_buffer_once): Likewise.
12673 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12674 special case.
12675 * process.c (Fformat_network_address): Use local var for size,
12676 for brevity.
12677
0df1eac5
PE
12678 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12679
847ab9d1 12680 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12681 * data.c (atof): Remove decl; no longer used or needed.
12682 (digit_to_number): Move to lread.c.
12683 (Fstring_to_number): Use new string_to_number function, to be
12684 consistent with how the Lisp reader treats infinities and NaNs.
12685 Do not assume that floating-point numbers represent EMACS_INT
12686 without losing information; this is not true on most 64-bit hosts.
12687 Avoid double-rounding errors, by insisting on integers when
12688 parsing non-base-10 numbers, as the documentation specifies.
12689 * lisp.h (string_to_number): New decl, replacing ...
12690 (isfloat_string): Remove.
bc0a5c13 12691 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12692 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12693 appears to have been a coding error. Similarly, do not accept
12694 strings like +-1e0 as floating point numbers. Do not report
12695 overflow for integer overflows unless the base is not 10 which
12696 means we have no simple and reliable way to continue.
12697 Break out the floating-point parsing into a new
12698 function string_to_number, so that Fstring_to_number parses
12699 floating point numbers consistently with the Lisp reader.
04f2d78b 12700 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12701 (E_CHAR, EXP_INT): Remove, replacing with ...
12702 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12703 (string_to_number): New function, replacing isfloat_string.
12704 This function checks for valid syntax and produces the resulting
12705 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12706 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12707 so that overflow for non-base-10 numbers is reported only when
12708 there's no portable and simple way to convert to floating point.
452f4150 12709
67769ffc
PE
12710 * textprop.c (set_text_properties_1): Rewrite for clarity,
12711 and to avoid GCC warning about integer overflow.
12712
c20db43f
PE
12713 * intervals.h (struct interval): Use EMACS_INT for members
12714 where EMACS_UINT might cause problems. See
12715 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12716 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12717 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12718 All uses changed.
37aa2f85
PE
12719 (offset_intervals): Tell GCC not to worry about length overflow
12720 when negating a negative length.
c20db43f 12721
2538aa2f
PE
12722 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12723 (overrun_check_free): Likewise.
12724
f2d3008d
PE
12725 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12726 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12727 word size.
12728
ec8df744
PE
12729 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12730 (gnutls_make_error): Rename local to avoid shadowing.
12731 (gnutls_emacs_global_deinit): ifdef out; not used.
12732 (Fgnutls_boot): Use const for pointer to readonly storage.
12733 Comment out unused local. Fix pointer signedness problems.
12734
640ee02d
PE
12735 * lread.c (openp): Don't stuff size_t into an 'int'.
12736 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12737 about possible signed overflow.
12738
6048fb2a
PE
12739 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12740 (GDK_KEY_g): Don't define if already defined.
12741 (xg_prepare_tooltip): Avoid pointer signedness problem.
12742 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12743
fa3c87e1
PE
12744 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12745 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12746
2172544b
PE
12747 * xfns.c (Fx_window_property): Simplify a bit,
12748 to make a bit faster and to avoid GCC 4.6.0 warning.
12749 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12750
9b821a21
PE
12751 * fns.c (internal_equal): Don't assume size_t fits in int.
12752
3c616cfa
PE
12753 * alloc.c (compact_small_strings): Tighten assertion a little.
12754
c2982e87
PE
12755 Replace pEd with more-general pI, and fix some printf arg casts.
12756 * lisp.h (pI): New macro, generalizing old pEd macro to other
12757 conversion specifiers. For example, use "...%"pI"d..." rather
12758 than "...%"pEd"...".
12759 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12760 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12761 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12762 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12763 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12764 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12765 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12766 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12767 64-bit hosts.
12768 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12769 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12770 * print.c (safe_debug_print, print_object): Likewise.
12771 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12772 to int.
6f04d126
PE
12773 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12774 avoiding the 0 flag, which is not portable.
c2982e87
PE
12775 * process.c (Fmake_network_process): Use pI to avoid cast.
12776 * region-cache.c (pp_cache): Likewise.
12777 * xdisp.c (decode_mode_spec): Likewise.
12778 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12779 behavior on 64-bit hosts with printf arg.
6f04d126 12780 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12781 (x_stop_queuing_selection_requests): Likewise.
12782 (x_get_window_property): Don't truncate byte count to an 'int'
12783 when tracing.
0b432f21 12784
5e073ec7
PE
12785 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12786 here, since it parses constructs like leading '-' and spaces,
12787 which are not wanted; and it overflows with large numbers.
12788 Instead, simply match F[0-9]+, which is what is wanted anyway.
12789
36372bf9
PE
12790 * alloc.c: Remove unportable assumptions about struct layout.
12791 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12792 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12793 (allocate_vectorlike, make_pure_vector): Use the new macros,
12794 plus offsetof, to remove unportable assumptions about struct layout.
12795 These assumptions hold on all porting targets that I know of, but
12796 they are not guaranteed, they're easy to remove, and removing them
12797 makes further changes easier.
12798
0b432f21
PE
12799 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12800 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12801 (string_overrun_cookie): Now const. Use initializers that
12802 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12803 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12804 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12805 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12806 multiple of sizeof (EMACS_INT); it need not be, if
12807 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12808 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12809
895009e1
JB
128102011-04-26 Juanma Barranquero <lekktu@gmail.com>
12811
12812 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12813
6a7a1b0b
TZ
128142011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12815
12816 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12817 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12818 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12819
841a1577 128202011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12821
12822 * lisp.h (Qdebug): List symbol.
895009e1 12823 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12824 * keyboard.c (debug-on-event): New variable.
12825 (handle_user_signal): Break into debugger when debug-on-event
12826 matches the current signal symbol.
12827
f2d3ba6f
DN
128282011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12829
12830 * alloc.c (check_sblock, check_string_bytes)
12831 (check_string_free_list): Convert to standard C.
12832
42ce4c63
TZ
128332011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12834
12835 * w32.c (emacs_gnutls_push): Fix typo.
12836
825cd63c
EZ
128372011-04-25 Eli Zaretskii <eliz@gnu.org>
12838
fb11d64d
EZ
12839 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12840 "cast to pointer from integer of different size".
12841
825cd63c
EZ
12842 Improve doprnt and its use in verror. (Bug#8545)
12843 * doprnt.c (doprnt): Document the set of format control sequences
12844 supported by the function. Use SAFE_ALLOCA instead of always
12845 using `alloca'.
12846
12847 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12848 is one byte too soon. Don't use xrealloc; instead xfree and
12849 xmalloc anew.
12850
e061a11b
TZ
128512011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12852
12853 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12854 callbacks stage.
12855
12856 * gnutls.c: Renamed global_initialized to
12857 gnutls_global_initialized. Added internals for the
12858 :verify-hostname-error, :verify-error, and :verify-flags
12859 parameters of `gnutls-boot' and documented those parameters in the
12860 docstring. Start callback support.
9173deec
JB
12861 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12862 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12863 on error. Return error code.
e061a11b
TZ
12864 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12865 (emacs_gnutls_read): Likewise.
12866 (Fgnutls_boot): Return handshake error code.
12867 (emacs_gnutls_handle_error): New function.
12868 (wsaerror_to_errno): Likewise.
12869
12870 * w32.h (emacs_gnutls_pull): Add prototype.
12871 (emacs_gnutls_push): Likewise.
12872
12873 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12874 (emacs_gnutls_push): Likewise.
12875
128762011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12877
12878 * process.c (wait_reading_process_output): Check if GnuTLS
12879 buffered some data internally if no FDs are set for TLS
12880 connections.
12881
12882 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12883 (LIBS): Link to USER_LIBS.
12884 ($(BLD)/gnutls.$(0)): New target.
12885
fa6996bc
EZ
128862011-04-24 Eli Zaretskii <eliz@gnu.org>
12887
eb35682e
EZ
12888 * xdisp.c (handle_single_display_spec): Rename the
12889 display_replaced_before_p argument into display_replaced_p, to
12890 make it consistent with the commentary. Fix typos in the
12891 commentary.
12892
e2ad650c
EZ
12893 * textprop.c (syms_of_textprop): Remove dead code.
12894 (copy_text_properties): Delete obsolete commentary about an
12895 interface that was deleted long ago. Fix typos in the description
12896 of arguments.
12897
1b2de274
EZ
12898 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12899 to changes in oldXMenu/XMenu.h from 2011-04-16.
12900 <menu_help_message, prev_menu_help_message>: Constify.
12901 (IT_menu_make_room): menu->help_text is now `const char **';
12902 adjust.
12903
12904 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12905 to changes in oldXMenu/XMenu.h from 2011-04-16.
12906 (struct XMenu): Declare `help_text' `const char **'.
12907
12908 * xfaces.c <Qunspecified>: Make extern again.
12909
12910 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12911 required by POSIX.
1b2de274 12912
762b15be
EZ
12913 * doc.c (get_doc_string): Improve the format passed to `error'.
12914
12915 * doprnt.c (doprnt): Improve commentary.
12916
12917 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12918
12919 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12920 them with etags.
12921
f1052e5d
EZ
12922 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12923 changes in globals.h immediately force recompilation.
762b15be
EZ
12924 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12925 $(CURDIR)/s/ms-w32.h.
12926 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12927
fa6996bc
EZ
12928 * character.c (Fchar_direction): Function deleted.
12929 (syms_of_character): Don't defsubr it.
12930 <char-direction-table>: Deleted.
12931
e6c3da20
EZ
129322011-04-23 Eli Zaretskii <eliz@gnu.org>
12933
12934 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12935 * doprnt.c: Include limits.h.
12936 (SIZE_MAX): New macro.
04f2d78b
CB
12937 (doprnt): Return a size_t value. 2nd arg is now size_t.
12938 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12939 Improve overflow protection. Support `l' modifier for integer
12940 conversions. Support %l conversion. Don't assume an EMACS_INT
12941 argument for integer conversions and for %c.
12942
12943 * lisp.h (doprnt): Restore prototype.
12944
12945 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12946 $(SRC)/character.h.
12947
12948 * Makefile.in (base_obj): Add back doprnt.o.
12949
12950 * deps.mk (doprnt.o): Add back prerequisites.
12951 (callint.o): Depend on character.h.
12952
12953 * eval.c (internal_lisp_condition_case): Include the handler
12954 representation in the error message.
12955 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12956 when breaking from the loop.
12957
12958 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12959
12960 * callint.c (Fcall_interactively): When displaying error message
12961 about invalid control letter, pass the character's codepoint, not
12962 a pointer to its multibyte form. Improve display of the character
12963 in octal and display also its hex code.
12964
12965 * character.c (char_string): Use %x to display the (unsigned)
12966 codepoint of an invalid character, to avoid displaying a bogus
12967 negative value.
12968
12969 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12970 `error', not SYMBOL_NAME itself.
12971
12972 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12973 character arguments to `error'.
12974
12975 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12976 to `error' in error message about FINAL_CHAR argument. Make sure
12977 FINAL_CHAR is a character, and use %c when it is passed as
12978 argument to `error'.
12979
4ffd0d6b 129802011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12981
12982 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12983
12984 * w32.c: Include <time.h>.
12985 (sys_localtime): New function.
12986
4ffd0d6b 129872011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12988
12989 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12990
4ffd0d6b 12991 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12992
4ffd0d6b 129932011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12994
4ffd0d6b
GM
12995 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12996 zombies (Bug#8467).
aac0c6e3 12997
04c56954
EZ
129982011-04-19 Eli Zaretskii <eliz@gnu.org>
12999
13000 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13001 gl_state.e_property when gl_state.object is Qt.
13002
13003 * insdel.c (make_gap_larger): Remove limitation of buffer size
13004 to <= INT_MAX.
13005
16a43933
CY
130062011-04-18 Chong Yidong <cyd@stupidchicken.com>
13007
13008 * xdisp.c (lookup_glyphless_char_display)
13009 (produce_glyphless_glyph): Handle cons cell entry in
13010 glyphless-char-display.
13011 (Vglyphless_char_display): Document it.
13012
13013 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13014 glyphless-char-display.
13015
4581706e
CY
130162011-04-17 Chong Yidong <cyd@stupidchicken.com>
13017
13018 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13019
13020 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13021
13022 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13023 definition for no-X builds.
13024
4887c6e2 130252011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13026
fd35b6f9
PE
13027 Static checks with GCC 4.6.0 and non-default toolkits.
13028
5c1ccb01
PE
13029 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13030
006c5daa
PE
13031 * process.c (keyboard_bit_set): Define only if SIGIO.
13032 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13033 (send_process): Repair possible setjmp clobbering.
13034
efc736d3
PE
13035 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13036
4e2fe2e6
PE
13037 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13038
f97334a2
PE
13039 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13040
4e75f29d
PE
13041 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13042 Define only if needed.
13043
90efadd1
PE
13044 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13045 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13046 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13047
3c647824
PE
13048 * dispextern.h (struct redisplay_interface): Rename param
13049 to avoid shadowing.
e264f262 13050 * termhooks.h (struct terminal): Likewise.
761383f4 13051 * xterm.c (xembed_send_message): Likewise.
3c647824 13052
b58c5c4a
PE
13053 * insdel.c (make_gap_smaller): Define only if
13054 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13055
cad59032
PE
13056 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13057 it.
13058
c339dc2e
PE
13059 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13060 so that we aren't warned about unused symbols.
13061
91a3e27b
PE
13062 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13063
399c71d3 13064 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13065
8ffc96f5
PE
13066 * xfns.c (x_real_positions): Mark locals as initialized.
13067
eef9bc79
PE
13068 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13069
098db9dd
PE
13070 * xterm.c: Fix problems found by static analysis with other toolkits.
13071 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13072 (x_dispatch_event): Declare static if USE_GTK, and
13073 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13074 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13075 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13076 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13077 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13078
eb18f6cc
PE
13079 * xmenu.c (menu_help_callback): Pointer type fixes.
13080 Use const pointers when pointing at readonly data. Avoid pointer
13081 signedness clashes.
13082 (FALSE): Remove unused macro.
13083 (update_frame_menubar): Remove unused decl.
13084
1fe72bf8
PE
13085 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13086
60d9e1db
PE
13087 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13088 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13089 (single_menu_item): Rename local to avoid shadowing.
13090
39261c26
PE
13091 * keyboard.c (make_lispy_event): Remove unused local var.
13092
018c5e19
PE
13093 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13094 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13095
63d2b86e
PE
13096 * bitmaps: Change bitmaps from unsigned char back to the X11
13097 compatible char. Avoid the old compiler warnings about
13098 out-of-range initializers by using, for example, '\xab' rather
13099 than 0xab.
13100
aefd87e1
PE
13101 * xgselect.c (xgselect_initialize): Check vs interface
13102 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13103
bf501fb9
PE
13104 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13105
e9829fdf
PE
13106 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13107 to read-only memory.
13108
1086c095
PE
13109 * fns.c (vector): Remove; this old hack is no longer needed.
13110
2baccd04 13111 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13112 Remove unused var.
dde42981 13113 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13114
72391843 13115 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13116
436c16df 13117 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13118 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13119 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13120
92bb796d 13121 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13122 (x_term_init): Remove local to avoid shadowing.
92bb796d 13123
764430a3 13124 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13125
13126 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13127 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13128
d1dfb56c
EZ
131292011-04-16 Eli Zaretskii <eliz@gnu.org>
13130
c4354cb4
EZ
13131 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13132
d1dfb56c
EZ
13133 Fix regex.c, syntax.c and friends for buffers > 2GB.
13134 * syntax.h (struct gl_state_s): Declare character position members
13135 EMACS_INT.
13136
13137 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13138
04f2d78b
CB
13139 * textprop.c (verify_interval_modification, interval_of):
13140 Declare arguments EMACS_INT.
d1dfb56c
EZ
13141
13142 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13143 EMACS_INT.
13144
13145 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13146
13147 * indent.c (Fvertical_motion): Local variable it_start is now
13148 EMACS_INT.
13149
13150 * regex.c (re_match, re_match_2, re_match_2_internal)
13151 (bcmp_translate, regcomp, regexec, print_double_string)
13152 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13153 (re_compile_pattern, re_exec): Declare arguments and local
13154 variables `size_t' and `ssize_t' and return values `regoff_t', as
13155 appropriate.
13156 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13157 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13158 <compile_stack_type>: `size' and `avail' are now `size_t'.
13159
13160 * regex.h <regoff_t>: Use ssize_t, not int.
13161 (re_search, re_search_2, re_match, re_match_2): Arguments that
13162 specify buffer/string position and length are now ssize_t and
13163 size_t. Return type is regoff_t.
13164
613052cd
BK
131652011-04-16 Ben Key <bkey76@gmail.com>
13166
13167 * nsfont.m: Fixed bugs in ns_get_family and
13168 ns_descriptor_to_entity that were caused by using free to
13169 deallocate memory blocks that were allocated by xmalloc (via
13170 xstrdup). This caused Emacs to crash when compiled with
13171 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13172 --enable-checking=xmallocoverrun). xfree is now used to
13173 deallocate these memory blocks.
13174
4170f62f 131752011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13176
71b41406
PE
13177 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13178
9587a89d
PE
13179 emacs_write: Accept and return EMACS_INT for sizes.
13180 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13181 et seq.
13182 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13183 Accept and return EMACS_INT.
13184 (emacs_gnutls_write): Return the number of bytes written on
13185 partial writes.
13186 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13187 (emacs_read, emacs_write): Remove check for negative size, as the
13188 Emacs source code has been audited now.
9587a89d
PE
13189 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13190 (emacs_read, emacs_write): Use it.
273a5f82
PE
13191 * process.c (send_process): Adjust to the new signatures of
13192 emacs_write and emacs_gnutls_write. Do not attempt to store
13193 a byte offset into an 'int'; it might overflow.
9587a89d 13194 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13195
3e047f51
PE
13196 * sound.c: Don't assume sizes fit in 'int'.
13197 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13198 Return EMACS_INT, not int.
3e047f51 13199 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13200 Accept EMACS_INT, not int.
13201 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13202 record read return values.
13203
cc39a9db
BK
132042011-04-15 Ben Key <bkey76@gmail.com>
13205
c9d0ec6d
JB
13206 * keyboard.c (Qundefined): Don't declare static since it is used
13207 in nsfns.m.
13208 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13209 static since they are used in nsfont.m.
cc39a9db 13210
6c60eb9f
SM
132112011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13212
13213 * process.c (Qprocessp): Don't declare static.
13214 * lisp.h (Qprocessp): Declare again.
13215
7990b61a
JB
132162011-04-15 Juanma Barranquero <lekktu@gmail.com>
13217
13218 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13219
5d4cb038
PE
132202011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13221
8bd7b830 13222 Improve C-level modularity by making more things 'static'.
cd64ea1d 13223
e3b27b31
PE
13224 Don't publish debugger-only interfaces to other modules.
13225 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13226 (verify_bytepos, count_markers): Move decls to the only modules
13227 that need them.
13228 * region-cache.h (pp_cache): Likewise.
13229 * window.h (check_all_windows): Likewise.
13230 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13231
5d4cb038
PE
13232 * sysdep.c (croak): Now static, if
13233 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13234 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13235
13236 * alloc.c (refill_memory_reserve): Now static if
13237 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13238 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13239
e87b6180
PE
13240 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13241 Define only if USE_LUCID.
13242
ac64929e
PE
13243 * xrdb.c (x_customization_string, x_rm_string): Now static.
13244
6f37259d
PE
13245 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13246 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13247
1683e3ab
PE
13248 * xdisp.c (draw_row_with_mouse_face): Now static.
13249 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13250
de9c2632
PE
13251 * window.h (check_all_windows): Mark externally visible.
13252
2b96acb7
PE
13253 * window.c (window_deletion_count): Now static.
13254
13255 * undo.c: Make symbols static if they're not exported.
13256 (last_undo_buffer, last_boundary_position, pending_boundary):
13257 Now static.
13258
50436f33
PE
13259 * textprop.c (interval_insert_behind_hooks): Now static.
13260 (interval_insert_in_front_hooks): Likewise.
13261
64520e5c
PE
13262 * term.c: Make symbols static if they're not exported.
13263 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13264 (max_frame_lines, tty_set_terminal_modes):
13265 (tty_reset_terminal_modes, tty_turn_off_highlight):
13266 (get_tty_terminal): Now static.
13267 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13268 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13269 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13270 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13271 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13272
1fa53021
PE
13273 * sysdep.c: Make symbols static if they're not exported.
13274 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13275 Now static.
13276 (sigprocmask_set, full_mask): Remove; unused.
13277 (wait_debugging): Mark as visible.
13278 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13279 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13280
d4b43b22
PE
13281 * syntax.c (syntax_temp): Define only if !__GNUC__.
13282
b7c513d0
PE
13283 * sound.c (current_sound_device, current_sound): Now static.
13284
989b29ad
PE
13285 * search.c (searchbufs, searchbuf_head): Now static.
13286
13a55a78
PE
13287 * scroll.c (scroll_cost): Remove; unused.
13288 * dispextern.h (scroll_cost): Remove decl.
13289
de68a1fc
PE
13290 * region-cache.h (pp_cache): Mark as externally visible.
13291
40ccffa6
PE
13292 * process.c: Make symbols static if they're not exported.
13293 (process_tick, update_tick, create_process, chan_process):
13294 (Vprocess_alist, proc_buffered_char, datagram_access):
13295 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13296 (deactivate_process): Mark defn as static, as well as decl.
13297 * lisp.h (create_process): Remove decl.
13298 * process.h (chan_process, Vprocess_alist): Remove decls.
13299
ad64fc97
PE
13300 * print.c: Make symbols static if they're not exported.
13301 (print_depth, new_backquote_output, being_printed, print_buffer):
13302 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13303 (print_interval, print_number_index, initial_stderr_stream):
13304 Now static.
13305 * lisp.h (Fprinc): Remove decl.
13306 (debug_output_compilation_hack): Mark as externally visible.
13307
adddb265
PE
13308 * sysdep.c (croak): Move decl from here to syssignal.h.
13309 * syssignal.h (croak): Put it here, so the API can be checked when
13310 'croak' is called from dissociate_if_controlling_tty.
13311
1717ede2
PE
13312 * minibuf.c: Make symbols static if they're not exported.
13313 (minibuf_save_list, choose_minibuf_frame): Now static.
13314 * lisp.h (choose_minibuf_frame): Remove decl.
13315
fa5fb2bc
PE
13316 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13317
1e3890d1
PE
13318 * lread.c: Make symbols static if they're not exported.
13319 (read_objects, initial_obarray, oblookup_last_bucket_number):
13320 Now static.
13321 (make_symbol): Remove; unused.
13322 * lisp.h (initial_obarray, make_symbol): Remove decls.
13323
8a1414fa
PE
13324 * keyboard.c: Make symbols static if they're not exported.
13325 (single_kboard, recent_keys_index, total_keys, recent_keys):
13326 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13327 (this_single_command_key_start, echoing, last_auto_save):
13328 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13329 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13330 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13331 (Vlispy_mouse_stem, double_click_count):
13332 Now static.
13333 (force_auto_save_soon): Define only if SIGDANGER.
13334 (ignore_mouse_drag_p): Now static if
13335 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13336 (print_help): Remove; unused.
13337 (stop_character, last_timer_event): Mark as externally visible.
13338 * keyboard.h (ignore_mouse_drag_p): Declare only if
13339 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13340 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13341 * lisp.h (echoing): Remove decl.
13342 (force_auto_save_soon): Declare only if SIGDANGER.
13343 * xdisp.c (redisplay_window): Simplify code, to make it more
13344 obvious that ignore_mouse_drag_p is not accessed if !defined
13345 USE_GTK && !defined HAVE_NS.
13346
93ea6e8f
PE
13347 * intervals.c: Make symbols static if they're not exported.
13348 (merge_properties_sticky, merge_interval_right, delete_interval):
13349 Now static.
13350 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13351
77382fcc
PE
13352 * insdel.c: Make symbols static if they're not exported.
13353 However, leave prepare_to_modify_buffer alone. It's never
13354 called from outside this function, but that appears to be a bug.
13355 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13356 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13357 (adjust_after_replace_noundo): Remove; unused.
13358 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13359 (signal_before_change): Remove decls.
77382fcc 13360
9306c32e
PE
13361 * indent.c (val_compute_motion, val_vmotion): Now static.
13362
cd44d2eb
PE
13363 * image.c: Make symbols static if they're not exported.
13364 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13365 if USE_GTK.
13366 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13367 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13368
ad9a7a06
PE
13369 * fringe.c (standard_bitmaps): Now static.
13370 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13371
81626931
PE
13372 * frame.c: Make symbols static if they're not exported.
13373 (x_report_frame_params, make_terminal_frame): Now static.
13374 (get_frame_param): Now static, unless HAVE_NS.
13375 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13376 (x_get_resource_string): Remove; not used.
13377 * frame.h (make_terminal_frame, x_report_frame_params):
13378 (x_get_resource_string); Remove decls.
13379 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13380 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13381
239f9db9
PE
13382 * font.c, fontset.c: Make symbols static if they're not exported.
13383 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13384 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13385 * font.c (font_close_object): Now static.
13386 * font.h (font_close_object): Remove.
13387 * fontset.c (FONTSET_OBJLIST): Remove.
13388 (free_realized_fontset) #if-0 the body, which does nothing.
13389 (face_suitable_for_char_p): #if-0, as it's never called.
13390 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13391 * xfaces.c (face_at_string_position):
13392 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13393 since 0 is always ASCII.
13394
dfcf3579
PE
13395 * fns.c (weak_hash_tables): Now static.
13396
5045092b
PE
13397 * fileio.c: Make symbols static if they're not exported.
13398 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13399 (Vwrite_region_annotation_buffers): Now static.
13400
57a96f5c
PE
13401 * eval.c: Make symbols static if they're not exported.
13402 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13403 * lisp.h (backtrace_list): Remove decl.
13404
35f08c38
PE
13405 * emacs.c: Make symbols static if they're not exported.
13406 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13407 (fatal_error_code, fatal_error_signal_hook, standard_args):
13408 Now static.
13409 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13410 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13411 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13412 * lisp.h (fatal_error_signal_hook): Remove decl.
13413 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13414
f44bd759
PE
13415 * editfns.c: Move a (normally-unused) function to its only use.
13416 * editfns.c, lisp.h (get_operating_system_release): Remove.
13417 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13418 worth the hassle of breaking this out.
13419
b532497d
PE
13420 * xterm.c: Make symbols static if they're not exported.
13421 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13422 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13423 (x_destroy_window, x_delete_display):
13424 Now static.
13425 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13426 (x_mouse_leave): Remove; unused.
13427 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13428 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13429 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13430 Remove decls.
13431 (x_mouse_leave): Declare only if WINDOWSNT.
13432 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13433 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13434 USE_X_TOOLKIT.
13435
1675728f
PE
13436 * ftxfont.c: Make symbols static if they're not exported.
13437 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13438 HAVE_FREETYPE.
13439 * font.h (ftxfont_driver): Likewise.
13440
e4cebfca
PE
13441 * xfns.c: Make symbols static if they're not exported.
13442 (x_last_font_name, x_display_info_for_name):
13443 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13444 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13445 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13446 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13447 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13448 (last_show_tip_args): Now static.
13449 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13450 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13451 (x_screen_planes): Remove; unused.
13452 * dispextern.h (x_screen_planes): Remove decl.
13453
5bf46f05
PE
13454 * dispnew.c: Make symbols static if they're not exported.
13455 * dispextern.h (redraw_garbaged_frames, scrolling):
13456 (increment_row_positions): Remove.
13457 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13458 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13459 Now static.
13460 (redraw_garbaged_frames): Remove; unused.
13461
435f4c28
PE
13462 * xfaces.c: Make symbols static if they're not exported.
13463 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13464 Remove decls.
13465 * xterm.h (defined_color): Remove decls.
13466 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13467 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13468 (menu_face_changed_default, defined_color, free_realized_face):
13469 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13470 (ascii_face_of_lisp_face): Remove; unused.
13471
8524aef3
PE
13472 * xdisp.c: Make symbols static if they're not exported.
13473 * dispextern.h (scratch_glyph_row, window_box_edges):
13474 (glyph_to_pixel_coords, set_cursor_from_row):
13475 (get_next_display_element, set_iterator_to_next):
13476 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13477 (show_mouse_face): Remove decls
13478 * frame.h (message_buf_print): Likewise.
13479 * lisp.h (pop_message, set_message, check_point_in_composition):
13480 Likewise.
13481 * xterm.h (set_vertical_scroll_bar): Likewise.
13482 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13483 (message_buf_print, scratch_glyph_row, displayed_buffer):
13484 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13485 (get_next_display_element, show_mouse_face, window_box_edges):
13486 (frame_to_window_pixel_xy, check_point_in_composition):
13487 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13488 (glyph_to_pixel_coords): Remove; unused.
13489
16390cd2
PE
13490 * dired.c (file_name_completion): Now static.
13491
13492 * dbusbind.c (xd_in_read_queued_messages): Now static.
13493
a25f4dfa
PE
13494 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13495 * data.c (circular_list_error): Remove.
13496
14a9c8df
PE
13497 * commands.h (last_point_position, last_point_position_buffer):
13498 (last_point_position_window): Remove decls.
13499 * keyboard.c: Make these variables static.
13500
04f2d78b
CB
13501 * coding.h (coding, code_convert_region, encode_coding_gap):
13502 Remove decls.
74ab6df5
PE
13503 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13504 (iso_code_class, detect_coding, code_convert_region): Now static.
13505 (encode_coding_gap): Remove; unused.
13506
38dfbee1
PE
13507 * chartab.c (chartab_chars, chartab_bits): Now static.
13508
a2cb4e63
PE
13509 * charset.h (charset_iso_8859_1): Remove decl.
13510 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13511 Now static.
13512
127198fd
PE
13513 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13514 * ccl.c (Vccl_program_table): Now static.
13515 (check_ccl_update): Remove; unused.
13516
d85b608f
PE
13517 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13518 * category.h: ... from here.
13519 * category.c (check_category_table, set_category_set): Now static.
13520
31cd66f3
PE
13521 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13522 * lisp.h: Remove these decls.
13523
c358e587
PE
13524 * buffer.c (buffer_count): Remove unused var.
13525
e78aecca
PE
13526 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13527 so that it's not optimized away.
13528 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13529 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13530 exported only to the debugger.
13531
e192d7d3 13532 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13533 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13534
92470028
PE
13535 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13536 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13537 was inaccessible from Lisp.
13538 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13539 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13540
244ed907
PE
13541 alloc.c: Import and export fewer symbols, and remove unused items.
13542 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13543 is defined.
13544 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13545 it's not optimized away by whole-program optimization.
13546 (message_enable_multibyte, free_misc): Remove.
13547 (catchlist, handlerlist, mark_backtrace):
13548 Declare only if BYTE_MARK_STACK.
13549 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13550 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13551 (message_enable_multibyte): Remove decl.
13552 (free_misc, interval_free_list, float_block, float_block_index):
13553 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13554 (cons_free_list, last_marked_index):
13555 Now static.
13556 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13557 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13558 (mark_backtrace): Define only if BYTE_MARK_STACK.
13559 * xdisp.c (message_enable_multibyte): Now static.
13560
61c2b50e 13561 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13562 This makes it easier for human readers (and static analyzers)
13563 to see whether these variables are used from other modules.
13564 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13565 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13566 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13567 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13568 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13569 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13570 * xmenu.c, xselect.c:
13571 Declare Q* vars static if they are not used in other modules.
13572 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13573 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13574 Remove decls of unexported vars.
13575 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13576
95c82688
PE
13577 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13578
16a97296
PE
13579 Make Emacs functions such as Fatom 'static' by default.
13580 This makes it easier for human readers (and static analyzers)
13581 to see whether these functions can be called from other modules.
13582 DEFUN now defines a static function. To make the function external
13583 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13584 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13585 (Finit_image_library):
16a97296
PE
13586 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13587 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13588 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13589 Remove decls, since these functions are now static.
13590 (Funintern, Fget_internal_run_time): New decls, since these functions
13591 were already external.
95c82688 13592
16a97296
PE
13593 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13594 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13595 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13596 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13597 * keyboard.c, keymap.c, lread.c:
13598 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13599 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13600 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13601 Mark functions with DEFUE instead of DEFUN,
13602 if they are used in other modules.
13603 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13604 decls for now-static functions.
13605 * buffer.h (Fdelete_overlay): Remove decl.
13606 * callproc.c (Fgetenv_internal): Mark as internal.
13607 * composite.c (Fremove_list_of_text_properties): Remove decl.
13608 (Fcomposition_get_gstring): New forward static decl.
13609 * composite.h (Fcomposite_get_gstring): Remove decl.
13610 * dired.c (Ffile_attributes): New forward static decl.
13611 * doc.c (Fdocumntation_property): New forward static decl.
13612 * eval.c (Ffetch_bytecode): New forward static decl.
13613 (Funintern): Remove extern decl; now in .h file where it belongs.
13614 * fileio.c (Fmake_symbolic_link): New forward static decl.
13615 * image.c (Finit_image_library): New forward static decl.
13616 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13617 * intervals.h (Fprevious_property_change):
13618 (Fremove_list_of_text_properties): Remove decls.
13619 * keyboard.c (Fthis_command_keys): Remove decl.
13620 (Fcommand_execute): New forward static decl.
13621 * keymap.c (Flookup_key): New forward static decl.
13622 (Fcopy_keymap): Now static.
13623 * keymap.h (Flookup_key): Remove decl.
13624 * process.c (Fget_process): New forward static decl.
13625 (Fprocess_datagram_address): Mark as internal.
13626 * syntax.c (Fsyntax_table_p): New forward static decl.
13627 (skip_chars): Remove duplicate decl.
13628 * textprop.c (Fprevious_property_change): New forward static decl.
13629 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13630 Now internal.
13631 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13632 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13633
785bbd42
PE
13634 * editfns.c (Fformat): Remove unreachable code.
13635
8b913b57
AS
136362011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13637
13638 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13639 change. (Bug#8496)
13640
a6744a35
EZ
136412011-04-13 Eli Zaretskii <eliz@gnu.org>
13642
13643 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13644 when at ZV. (Bug#8487)
13645
e7974947
AS
136462011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13647
baad03f0
AS
13648 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13649 (Bug#8437)
13650 * keyboard.c (parse_tool_bar_item): Likewise.
13651 * sound.c (sound_cleanup, alsa_close): Likewise.
13652 * termcap.c (tgetent): Likewise.
13653 * xfns.c (x_default_font_parameter): Likewise.
13654 * xsettings.c (read_and_apply_settings): Likewise.
13655
e7974947
AS
13656 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13657 (overrun_check_free): Protoize.
13658
28272684
PE
136592011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13660
13661 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13662 since callers should never pass a negative size.
13663 Change the signature to match that of plain 'read' and 'write'; see
13664 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13665 * lisp.h: Update prototypes of emacs_write and emacs_read.
13666
11997c76
EZ
136672011-04-11 Eli Zaretskii <eliz@gnu.org>
13668
13669 * xdisp.c (redisplay_window): Don't try to determine the character
13670 position of the scroll margin if the window start point w->startp
e896f03c 13671 is outside the buffer's accessible region. (Bug#8468)
11997c76 13672
8a2cbd72
EZ
136732011-04-10 Eli Zaretskii <eliz@gnu.org>
13674
13675 Fix write-region and its subroutines for buffers > 2GB.
13676 * fileio.c (a_write, e_write): Modify declaration of arguments and
13677 local variables to support buffers larger than 2GB.
13678 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13679
13680 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13681 argument, local variables, and return value.
13682
13683 * lisp.h: Update prototypes of emacs_write and emacs_read.
13684
13685 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13686
4073e537 136872011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13688
1ebfdcb6
PE
13689 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13690
b2ded58d
PE
13691 Fix more problems found by GCC 4.6.0's static checks.
13692
7d66342c
PE
13693 * xdisp.c (vmessage): Use a better test for character truncation.
13694
bbf47d44
PE
13695 * charset.c (load_charset_map): <, not <=, for optimization,
13696 and to avoid potential problems with integer overflow.
9248994d 13697 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13698 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13699 * editfns.c (Fformat): Likewise.
1e69125e 13700 * syntax.c (skip_chars): Likewise.
3befa583 13701
e3019616
PE
13702 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13703 This also lets GCC 4.6.0 generate slightly better loop code.
13704
becfa255
PE
13705 * callint.c (Fcall_interactively): <, not <=, for optimization.
13706 (Fcall_interactively): Count the number of arguments produced,
13707 not the number of arguments given. This is simpler and lets GCC
13708 4.6.0 generate slightly better code.
13709
dae0cd48
PE
13710 * ftfont.c: Distingish more carefully between FcChar8 and char.
13711 The previous code passed unsigned char * to a functions like
13712 strlen and xstrcasecmp that expect char *, which does not
13713 conform to the C standard.
13714 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13715 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13716 char * when the C standard requires it.
13717
76032d70
PE
13718 * keyboard.c (read_char): Remove unused var.
13719
eb3f1cc8
PE
13720 * eval.c: Port to Windows vsnprintf (Bug#8435).
13721 Include <limits.h>.
13722 (SIZE_MAX): Define if the headers do not.
13723 (verror): Do not give up if vsnprintf returns a negative count.
13724 Instead, grow the buffer. This ports to Windows vsnprintf, which
13725 does not conform to C99. Problem reported by Eli Zaretskii.
13726 Also, simplify the allocation scheme, by avoiding the need for
13727 calling realloc, and removing the ALLOCATED variable.
13728
70476b54
PE
13729 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13730
12020a9e
PE
13731 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13732 But keep the doprint source code for now, as we might revamp it
13733 and use it again (Bug#8435).
ea6c7ae6
PE
13734 * lisp.h (doprnt): Remove.
13735 * Makefile.in (base_obj): Remove doprnt.o.
13736 * deps.mk (doprnt.o): Remove.
13737
5fdb398c
PE
13738 error: Print 32- and 64-bit integers portably (Bug#8435).
13739 Without this change, on typical 64-bit hosts error ("...%d...", N)
13740 was used to print both 32- and 64-bit integers N, which relied on
13741 undefined behavior.
61bdb816 13742 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13743 * lisp.h (error, verror): Mark as printf-like functions.
13744 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13745 Report overflow in size calculations when allocating printf buffer.
13746 Do not truncate output string at its first null byte.
13747 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13748 Truncate the output at a character boundary, since vsnprintf does not
13749 do that.
13750 * charset.c (check_iso_charset_parameter): Convert internal
13751 character to string before calling 'error', since %c now has the
13752 printf meaning.
13753 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13754 overflow when computing char to be passed to 'error'. Do not
13755 pass Lisp_Object to 'error'; pass the integer instead.
13756 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13757 formatted with plain %d.
13758
b189fa66
PE
13759 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13760
bff87ef0
PE
13761 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13762
7e2cac20
PE
13763 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13764
ce4d90b5
PE
13765 * xterm.c (x_catch_errors): Remove duplicate declaration.
13766
266c9547
PE
13767 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13768
79c49ad2
PE
13769 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13770
368f4090
JM
137712011-04-10 Jim Meyering <meyering@redhat.com>
13772
13773 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13774 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13775 return ssize_t not "int", and use size_t as the buffer length.
13776 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13777 * gnutls.h: Update declarations.
13778 * process.c (read_process_output): Use ssize_t, to match.
13779 (send_process): Likewise.
13780
a32d4040
CY
137812011-04-09 Chong Yidong <cyd@stupidchicken.com>
13782
13783 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13784
8546720e 137852011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13786
04f2d78b
CB
13787 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13788 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13789
8546720e
GM
13790 * xterm.c (handle_one_xevent):
13791 * xmenu.c (create_and_show_popup_menu):
13792 * xselect.c (x_decline_selection_request)
13793 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13794
0a2f5c1a 137952011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13796
13797 Fix some uses of `int' instead of EMACS_INT.
13798 * search.c (string_match_1, fast_string_match)
13799 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13800 (scan_buffer, find_next_newline_no_quit)
13801 (find_before_next_newline, search_command, Freplace_match)
13802 (Fmatch_data): Make some `int' variables be EMACS_INT.
13803
13804 * xdisp.c (display_count_lines): 3rd argument and return value now
13805 EMACS_INT. All callers changed.
13806 (pint2hrstr): Last argument is now EMACS_INT.
13807
13808 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13809 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13810 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13811 (decode_coding_utf_16, decode_coding_emacs_mule)
13812 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13813 (decode_coding_ccl, decode_coding_charset)
13814 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13815 (decode_coding_iso_2022, decode_coding_emacs_mule)
13816 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13817 <char_offset, last_offset>: Declare EMACS_INT.
13818 (encode_coding_utf_8, encode_coding_utf_16)
13819 (encode_coding_emacs_mule, encode_invocation_designation)
13820 (encode_designation_at_bol, encode_coding_iso_2022)
13821 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13822 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13823 Declare EMACS_INT.
13824 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13825 (encode_invocation_designation): Last argument P_NCHARS is now
13826 EMACS_INT.
13827 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13828 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13829
13830 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13831 All users changed.
13832
13833 * ccl.c (Fccl_execute_on_string): Declare some variables
13834 EMACS_INT.
13835
8546720e 138362011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13837
13838 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13839
4e19a977
CS
138402011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13841
13842 * process.c (Fformat_network_address): Doc fix.
13843
87302331
R
138442011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13845
ee7683eb 13846 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13847
cbb59342
CY
138482011-04-08 Chong Yidong <cyd@stupidchicken.com>
13849
13850 * keyboard.c (read_char): Call Lisp function help-form-show,
13851 instead of using internal_with_output_to_temp_buffer.
13852 (Qhelp_form_show): New var.
e0d38eeb 13853 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13854
13855 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13856
13857 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13858
e67a13ab
CY
138592011-04-06 Chong Yidong <cyd@stupidchicken.com>
13860
04f2d78b
CB
13861 * process.c (Flist_processes): Remove to Lisp.
13862 (list_processes_1): Delete.
e67a13ab 13863
973f782d
EZ
138642011-04-06 Eli Zaretskii <eliz@gnu.org>
13865
7c106b1e
EZ
13866 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13867
973f782d
EZ
13868 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13869
41cf7d1a 138702011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13871
ca23cc88
PE
13872 Fix more problems found by GCC 4.6.0's static checks.
13873
f390e2d5
PE
13874 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13875
42eea0d0
PE
13876 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13877
b69769da 13878 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13879
f9541e84
PE
13880 * xdisp.c (vmessage): Mark as a printf-like function.
13881
13841b55
PE
13882 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13883
c136c10f
PE
13884 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13885
5e2d4a30
PE
13886 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13887 printf-like functions.
13888 (tiff_load): Add casts to remove these marks before passing them
13889 to system-supplied API.
13890
583f48b9
PE
13891 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13892
b25d760e
PE
13893 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13894 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13895 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13896 directly, rather than having caller test rule sign. This avoids
13897 some unnecessary tests.
13898 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13899 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13900 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13901
bc7b6697 13902 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13903 (xfont_open): Avoid unnecessary tests.
bc7b6697 13904
27ccc379
PE
13905 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13906
dcd5c89a
PE
13907 * composite.h, composite.c (composition_gstring_put_cache):
13908 Use EMACS_INT, not int, for length.
13909
b13a45c6
PE
13910 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13911 breaking out part of COMPOSITION_DECODE_RULE.
13912 (COMPOSITION_DECODE_RULE): Use it.
13913 * composite.c (get_composition_id): Remove unused local vars,
13914 by using the new macro.
13915
1e792e4d
PE
13916 * textprop.c (set_text_properties_1): Change while to do-while,
13917 since the condition is always true at first.
13918
dc6c6455 13919 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13920 (interval_deletion_adjustment): Return unsigned value.
13921 All uses changed.
dc6c6455 13922
aba7731a
PE
13923 * process.c (list_processes_1, create_pty, read_process_output):
13924 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13925 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13926 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13927 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13928 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13929
fdfc4bf3
PE
13930 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13931
fca8fe46 13932 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13933 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13934
06a0259a 13935 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13936 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13937 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13938
e7b9e80f
PE
13939 * print.c (print_error_message): Avoid int overflow.
13940
56201685
PE
13941 * font.c (font_list_entities): Redo for clarity,
13942 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13943
78834453 13944 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13945 (font_score): Avoid potential overflow in diff calculation.
78834453 13946
0bc0b309 13947 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13948 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13949
e610eaca
PE
13950 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13951
b895abce
PE
13952 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13953 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13954 can always succeed if overflow has undefined behavior.
13955
1f1d9321 13956 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13957 (wordify): Omit three unnecessary tests.
1f1d9321 13958
c59478bc
PE
13959 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13960 All callers changed. This avoids the need for an unused var.
13961
79b73827
PE
13962 * casefiddle.c (casify_region): Remove var that is set but not used.
13963
a4db5dfe
PE
13964 * dired.c (file_name_completion): Remove var that is set but not used.
13965
43aae36e
PE
13966 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13967
2a47c44d 13968 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13969 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13970
a37c69bf
PE
13971 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13972 Check for integer overflow on size calculations.
13973
328ab8e7
PE
13974 * buffer.c (Fprevious_overlay_change): Remove var that is set
13975 but not used.
13976
e5a2a5cb
PE
13977 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13978 Remove vars that are set but not used.
8d84a6eb 13979 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13980 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13981
a60e5f68
PE
13982 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13983
f661cb61 13984 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13985 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13986
f0397f5a
PE
13987 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13988 that are set but not used.
13989
8664db06 13990 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13991 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13992
6abdaa4a
PE
13993 * xselect.c (x_get_local_selection, x_handle_property_notify):
13994 Remove vars that are set but not used.
13995
0ce7538d 13996 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13997 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13998
9ae848fc
PE
13999 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14000 Remove var that is set but not used.
0b918413
PE
14001 (scroll_bar_windows_size): Now size_t, not int.
14002 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14003 Check for overflow.
9ae848fc 14004
a5a62657
PE
14005 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14006 (map_tty_color) [!defined MSDOS]: Likewise.
14007
5c5cdd39
PE
14008 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14009
66ebf983
PE
14010 * coding.c: Remove vars that are set but not used.
14011 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14012 All callers changed.
14013 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14014 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14015 (decode_coding_charset): Remove vars that are set but not used.
14016
1be4d761
PE
14017 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14018 that is set but not used.
14019
47553fa8
PE
14020 * print.c (print_object): Remove var that is set but not used.
14021
1f7196bf 14022 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14023 The gnulib version avoids calling malloc in the usual case,
14024 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14025 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14026 * filelock.c (current_lock_owner): Likewise.
14027 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14028 * sysdep.c: Include allocator.h, careadlinkat.h.
14029 (emacs_no_realloc_allocator): New static constant.
14030 (emacs_readlink): New function.
fdb61804
PE
14031 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14032 ../lib/careadlinkat.h.
d1fdcab7 14033
f84c17c7
SM
140342011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14035
14036 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14037 first non-nil return value).
14038
ef3862ad
JD
140392011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14040
14041 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14042 if not defined (Bug#8403).
14043
376a7006
JB
140442011-04-02 Juanma Barranquero <lekktu@gmail.com>
14045
14046 * xdisp.c (display_count_lines): Remove parameter `start',
14047 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14048 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14049 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14050 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14051 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14052 and thereabouts. All callers changed.
14053 (get_per_char_metric): Remove parameter `f', unused since
14054 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14055
6ca3801d
JM
140562011-04-02 Jim Meyering <meyering@redhat.com>
14057
14058 do not dereference NULL upon failed strdup
14059 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14060 (ns_get_family): Likewise.
14061
d8e2b5ba
JB
140622011-04-02 Juanma Barranquero <lekktu@gmail.com>
14063
14064 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14065
8c74fcbd
JD
140662011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14067
14068 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14069 later (Bug#8403).
14070
7200d79c
SM
140712011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14072
03408648 14073 Add lexical binding.
7200d79c 14074
03408648
SM
14075 * window.c (Ftemp_output_buffer_show): New fun.
14076 (Fsave_window_excursion):
14077 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14078
14079 * lread.c (lisp_file_lexically_bound_p): New function.
14080 (Fload): Bind Qlexical_binding.
14081 (readevalloop): Remove `evalfun' arg.
14082 Bind Qinternal_interpreter_environment.
14083 (Feval_buffer): Bind Qlexical_binding.
14084 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14085 Mark as dynamic.
14086 (syms_of_lread): Declare `lexical-binding'.
14087
14088 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14089
14090 * keyboard.c (eval_dyn): New fun.
14091 (menu_item_eval_property): Use it.
ca105506
SM
14092
14093 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14094
03408648
SM
14095 * fns.c (concat, mapcar1): Accept byte-code-functions.
14096
14097 * eval.c (Fsetq): Handle lexical vars.
14098 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14099 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14100 (FletX, Flet): Obey lexical binding.
14101 (Fcommandp): Handle closures.
14102 (Feval): New `lexical' arg.
14103 (eval_sub): New function extracted from Feval. Use it almost
14104 everywhere where Feval was used. Look up vars in lexical env.
14105 Handle closures.
14106 (Ffunctionp): Move from subr.el.
14107 (Ffuncall): Handle closures.
14108 (apply_lambda): Remove `eval_flags'.
14109 (funcall_lambda): Handle closures and new byte-code-functions.
14110 (Fspecial_variable_p): New function.
14111 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14112 but without exporting it to Lisp.
23aba0ea 14113
23aba0ea 14114 * doc.c (Fdocumentation, store_function_docstring):
03408648 14115 * data.c (Finteractive_form): Handle closures.
23aba0ea 14116
03408648
SM
14117 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14118 interactive spec.
ba83908c 14119
04f2d78b
CB
14120 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14121 New byte-codes.
03408648
SM
14122 (exec_byte_code): New function extracted from Fbyte_code to handle new
14123 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14124
03408648 14125 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14126
03408648 14127 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14128
e2abce01
JB
141292011-03-31 Juanma Barranquero <lekktu@gmail.com>
14130
14131 * xdisp.c (redisplay_internal): Fix prototype.
14132
63696a73 141332011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14134
63696a73 14135 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14136 (try_scrolling): Use it when setting scroll_limit.
14137 Limit scrolling to 100 screen lines.
63696a73
EZ
14138 (redisplay_window): Even when falling back on "recentering",
14139 position point in the window according to scroll-conservatively,
14140 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14141
14142 (try_scrolling): When point is above the window, allow searching
14143 as far as scroll_max, or one screenful, to compute vertical
14144 distance from PT to the scroll margin position. This prevents
14145 try_scrolling from unnecessarily failing when
14146 scroll-conservatively is set to a value slightly larger than the
14147 window height. Clean up the case of PT below the margin at bottom
14148 of window: scroll_max can no longer be INT_MAX. When aggressive
14149 scrolling is in use, don't let point enter the opposite scroll
14150 margin as result of the scroll.
14151 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14152 threshold of 100 lines for never-recentering scrolling.
14153
e4cc2dfc
JB
141542011-03-31 Juanma Barranquero <lekktu@gmail.com>
14155
14156 * dispextern.h (move_it_by_lines):
14157 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14158 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14159 (message_log_check_duplicate): Remove parameters `prev_bol' and
14160 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14161 (redisplay_internal): Remove parameter `preserve_echo_area',
14162 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14163
14164 * indent.c (Fvertical_motion):
14165 * window.c (window_scroll_pixel_based, Frecenter):
14166 Don't pass `need_y_p' to `move_it_by_lines'.
14167
1c470562
SM
141682011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14169
44f230aa
SM
14170 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14171 steal a few bits to be more compact.
14172 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14173 Remove unneeded casts.
14174
1c470562
SM
14175 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14176
888adce9
ZK
141772011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14178
14179 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14180 binding" message (bug#7967).
14181
f838ed7b
PE
141822011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14183
77861b95
PE
14184 Fix more problems found by GCC 4.6.0's static checks.
14185
de6dbc14
PE
14186 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14187 Remove unused local var.
14188
f838ed7b
PE
14189 * editfns.c (Fmessage_box): Remove unused local var.
14190
792c7b2b
PE
14191 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14192 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14193 Omit unused local vars.
c499e557 14194 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14195 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14196 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14197 Omit unused local var.
14198
ba0165e1
PE
14199 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14200 Don't assume string length fits in int.
32ad8845 14201 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14202 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14203
3c59b4c9
PE
14204 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14205 instead of alloca (Bug#8344).
14206
a3eed478 14207 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14208 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14209
eb4d412d
PE
14210 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14211
1658b401
PE
14212 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14213 concerns.
14214
14215 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14216
14217 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14218
9a2c6e05
PE
14219 * keyboard.c (syms_of_keyboard): Use the same style as later
14220 in this function when indexing through an array. This also
14221 works around GCC bug 48267.
14222
03d0a109
PE
14223 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14224
44f730c8
PE
14225 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14226
fe75f926
PE
14227 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14228 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14229
ffa8c828
PE
14230 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14231 This avoids undefined behavior on integer overflow, and is a bit
14232 more convenient anyway since it is compared to a size_t variable.
14233
c5101a77
PE
14234 Variadic C functions now count arguments with size_t, not int.
14235 This avoids an unnecessary limitation on 64-bit machines, which
14236 caused (substring ...) to crash on large vectors (Bug#8344).
14237 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14238 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14239 All variadic functions and their callers changed accordingly.
c5101a77
PE
14240 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14241 * data.c (arith_driver, float_arith_driver): Likewise.
14242 * editfns.c (general_insert_function): Likewise.
14243 * eval.c (struct backtrace.nargs, interactive_p)
14244 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14245 (funcall_lambda, mark_backtrace): Likewise.
14246 * fns.c (concat): Likewise.
14247 * frame.c (x_set_frame_parameters): Likewise.
14248 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14249 0 if not found, not -1. All callers changed.
14250
dd3f25f7
PE
14251 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14252 (stack_copy_size): Now size_t, not int.
14253 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14254
461c2ab9
JB
142552011-03-28 Juanma Barranquero <lekktu@gmail.com>
14256
14257 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14258 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14259 All callers changed.
14260
14261 * lisp.h (multibyte_char_to_unibyte):
14262 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14263 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14264 * character.h (CHAR_TO_BYTE8):
14265 * cmds.c (internal_self_insert):
14266 * editfns.c (general_insert_function):
14267 * keymap.c (push_key_description):
14268 * search.c (Freplace_match):
14269 * xdisp.c (message_dolog, set_message_1): All callers changed.
14270
f6d62986
SM
142712011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14272
14273 * keyboard.c (safe_run_hook_funcall): New function.
14274 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14275 don't set the hook to nil, but remove the offending function instead.
14276 (Qcommand_hook_internal): Remove, unused.
14277 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14278 Vcommand_hook_internal.
14279
14280 * eval.c (enum run_hooks_condition): Remove.
14281 (funcall_nil, funcall_not): New functions.
14282 (run_hook_with_args): Call each function through a `funcall' argument.
14283 Remove `cond' argument, now redundant.
14284 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14285 (Frun_hook_with_args_until_failure): Adjust accordingly.
14286 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14287
1db5b1ad
JB
142882011-03-28 Juanma Barranquero <lekktu@gmail.com>
14289
14290 * dispextern.h (string_buffer_position): Remove declaration.
14291
14292 * print.c (strout): Remove parameter `multibyte', unused since
14293 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14294
14295 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14296 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14297 All callers changed.
14298
14299 * w32.c (_wsa_errlist): Use braces for struct initializers.
14300
14301 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14302 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14303 All callers changed.
14304 (string_buffer_position): Likewise. Also, make static (it's never
14305 used outside xdisp.c).
14306 (cursor_row_p): Remove parameter `w', unused since
14307 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14308 (decode_mode_spec): Remove parameter `precision', introduced during
14309 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14310 All callers changed.
14311
5ffb62aa
JD
143122011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14313
14314 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14315
461c2ab9 143162011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14317
14318 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14319 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14320 (ns_update_auto_hide_menu_bar): New functions.
14321 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14322 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14323 ns_constrain_all_frames.
14324 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14325 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14326
5c380ffb
JD
143272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14328
14329 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14330
9af30bdf
GM
143312011-03-27 Glenn Morris <rgm@gnu.org>
14332
14333 * syssignal.h: Replace RETSIGTYPE with void.
14334 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14335 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14336 Replace SIGTYPE with void everywhere.
14337 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14338 * s/template.h (SIGTYPE): Remove commented out definition.
14339
e2abce01
JB
143402011-03-26 Eli Zaretskii <eliz@gnu.org>
14341
14342 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14343 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14344
f868cd8a
JB
143452011-03-26 Juanma Barranquero <lekktu@gmail.com>
14346
59eb0929
JB
14347 * w32.c (read_unc_volume): Use parameter `henum', instead of
14348 global variable `wget_enum_handle'.
14349
14350 * keymap.c (describe_vector): Remove parameters `indices' and
14351 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14352 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14353
f868cd8a
JB
14354 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14355
14356 * keyboard.c (timer_check): Remove parameter `do_it_now',
14357 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14358 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14359 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14360
14361 * keyboard.c (read_char):
14362 * w32menu.c (w32_menu_display_help):
14363 * xmenu.c (show_help_event, menu_help_callback):
14364 Adjust calls to `show_help_echo'.
14365
14366 * gtkutil.c (xg_maybe_add_timer):
14367 * keyboard.c (readable_events):
14368 * process.c (wait_reading_process_output):
14369 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14370
14371 * insdel.c (adjust_markers_gap_motion):
14372 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14373 (gap_left, gap_right): Don't call it.
14374
2ecf6fdb
CY
143752011-03-25 Chong Yidong <cyd@stupidchicken.com>
14376
14377 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14378 incurred during fontification.
14379
6b1f9ba4
JB
143802011-03-25 Juanma Barranquero <lekktu@gmail.com>
14381
14382 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14383 (DEFVAR_PER_BUFFER): Don't pass it.
14384
14385 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14386 (scrolling_window): Don't pass it.
14387
0f4a96b5
JB
143882011-03-25 Juanma Barranquero <lekktu@gmail.com>
14389
14390 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14391
14392 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14393 and `suffix'.
14394 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14395 of variables specific to SELinux and computation of `encoded_absname'.
14396
14397 * image.c (XPutPixel): Remove unused variable `height'.
14398
14399 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14400
14401 * unexw32.c (get_section_info): Remove unused variable `section'.
14402
14403 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14404 (system_process_attributes): Remove unused variable `sess'.
14405 (sys_read): Remove unused variable `err'.
14406
14407 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14408 (w32_wnd_proc): Remove unused variable `isdead'.
14409 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14410 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14411 (x_create_tip_frame): Remove unused variable `tem'.
14412
14413 * w32inevt.c (w32_console_read_socket):
14414 Remove unused variable `no_events'.
14415
14416 * w32term.c (x_draw_composite_glyph_string_foreground):
14417 Remove unused variable `width'.
14418
1149507c
JB
144192011-03-24 Juanma Barranquero <lekktu@gmail.com>
14420
14421 * w32term.c (x_set_glyph_string_clipping):
14422 Don't pass uninitialized region to CombineRgn.
14423
9c88f339
JB
144242011-03-23 Juanma Barranquero <lekktu@gmail.com>
14425
14426 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14427 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14428 (Fx_close_connection): Remove unused variable `i'.
14429
14430 * w32font.c (w32font_draw): Return number of glyphs.
14431 (w32font_open_internal): Remove unused variable `i'.
14432 (w32font_driver): Add missing initializer.
14433
14434 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14435 (fill_in_menu): Remove unused variable `items_added'.
14436
14437 * w32term.c (last_mouse_press_frame): Remove static global variable.
14438 (w32_clip_to_row): Remove unused variable `f'.
14439 (x_delete_terminal): Remove unused variable `i'.
14440
14441 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14442 (NOTHING): Remove unused static global variable.
14443 (uniscribe_check_otf): Remove unused variable `table'.
14444 (uniscribe_font_driver): Add missing initializers.
14445
dee091a3
JD
144462011-03-23 Julien Danjou <julien@danjou.info>
14447
14448 * term.c (Fsuspend_tty, Fresume_tty):
14449 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14450 * window.c (temp_output_buffer_show):
14451 * insdel.c (signal_before_change):
14452 * frame.c (Fhandle_switch_frame):
14453 * fileio.c (Fdo_auto_save):
14454 * emacs.c (Fkill_emacs):
14455 * editfns.c (save_excursion_restore):
14456 * cmds.c (internal_self_insert):
14457 * callint.c (Fcall_interactively):
14458 * buffer.c (Fkill_all_local_variables):
14459 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14460 Use Frun_hooks.
0f4a96b5 14461 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14462 unconditionally since it does the check itself.
dee091a3 14463
2c520ab5 144642011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14465
c9c49752
PE
14466 Fix more problems found by GCC 4.5.2's static checks.
14467
8abc3f12
PE
14468 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14469 the first time through the loop, since we know p0 < p1 then.
14470 This also avoids a gcc -Wstrict-overflow warning.
14471
a2d26660
PE
14472 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14473 leading to a memory leak, possible in functions like
14474 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14475 of objects (Bug#8318).
a2d26660 14476
916c72e9
PE
14477 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14478 that could (at least in theory) be that large.
14479
19ab8a18
PE
14480 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14481 This is less likely to overflow, and avoids undefined behavior if
14482 overflow does occur. All callers changed. Use strtoul to scan
14483 for the unsigned long integer.
b7cbbd6f
PE
14484 (pint2hrstr): Simplify and tune code slightly.
14485 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14486
f0641eff
PE
14487 * scroll.c (do_scrolling): Work around GCC bug 48228.
14488 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14489
7f650bb9
PE
14490 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14491 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14492 (validate_x_resource_name): Simplify count usage.
14493 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14494
37dd57d1
PE
14495 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14496 fail (Bug#8306).
81e56e61 14497
699979fc 14498 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14499
401bf9b4
PE
14500 * process.c (Fmake_network_process): Use socklen_t, not int,
14501 where POSIX says socklen_t is required in portable programs.
14502 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14503 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14504 (Fmake_network_process, server_accept_connection):
14505 (wait_reading_process_output, read_process_output):
14506 Likewise.
14507
b93aacde
PE
14508 * process.c: Rename or move locals to avoid shadowing.
14509 (list_processes_1, Fmake_network_process):
14510 (read_process_output_error_handler, exec_sentinel_error_handler):
14511 Rename or move locals.
4dc343ee 14512 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14513 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14514 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14515 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14516 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14517
af8a867c 14518 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14519 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14520 Include tparam.h instead, since it declares them.
af8a867c
PE
14521 * cm.h (PC): Remove extern decl; tparam.h now does this.
14522 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14523 * terminfo.c: Include tparam.h, to check interfaces.
14524 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14525 (tparam): Adjust signature to match interface in tparam.h;
14526 this removes some undefined behavior. Check that outstring and len
14527 are zero, which they always are with Emacs.
14528 * tparam.h (PC, BC, UP): New extern decls.
14529
0248044d 14530 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14531 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14532
8ff096c1 14533 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14534 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14535 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14536 (ftfont_list): Remove unused local.
49eaafba
PE
14537 (get_adstyle_property, ftfont_pattern_entity):
14538 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14539 Rename locals to avoid shadowing.
8ff096c1 14540
e2be39f6
PE
14541 * xfont.c (xfont_list_family): Mark var as initialized.
14542
c9735e30
PE
14543 * xml.c (make_dom): Now static.
14544
8f5201ae
PE
14545 * composite.c (composition_compute_stop_pos): Rename local to
14546 avoid shadowing.
b246f932
PE
14547 (composition_reseat_it): Remove unused locals.
14548 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14549 (composition_update_it): Mark var as initialized.
11b61122
PE
14550 (find_automatic_composition): Mark vars as initialized,
14551 with a FIXME (Bug#8290).
8f5201ae 14552
760fbc2c
PE
14553 character.h: Rename locals to avoid shadowing.
14554 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14555 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14556 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14557 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14558 to avoid shadowing.
14559
ff08eb85
PE
14560 * textprop.c (property_change_between_p): Remove; unused.
14561
fc7bf025
PE
14562 * intervals.c (interval_start_pos): Now static.
14563
235d7abc
PE
14564 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14565
44f230aa
SM
14566 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14567 Rename locals to avoid shadowing.
3e7d6594 14568
50060332
PE
14569 * sound.c (wav_play, au_play, Fplay_sound_internal):
14570 Fix pointer signedness.
d01f234b 14571 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14572 (wav_play): Initialize a variable to 0, to prevent undefined
14573 behavior (Bug#8278).
50060332 14574
c4fc4e30
PE
14575 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14576
918436ed
PE
14577 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14578
c939f91b
PE
14579 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14580 clobbering (Bug#8298).
b9c7f648
PE
14581 * sysdep.c (sys_subshell): Likewise.
14582 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14583
6bd8c144
PE
14584 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14585 This should get cleaned up, so that child_setup has the
14586 same signature on all platforms.
14587
7710357c 14588 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14589 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14590
c59da222
CY
145912011-03-22 Chong Yidong <cyd@stupidchicken.com>
14592
14593 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14594 not to be necessary, and produces flickering.
14595
66b87493
GM
145962011-03-20 Glenn Morris <rgm@gnu.org>
14597
14598 * config.in: Remove file.
14599
45b6f6d5
JB
146002011-03-20 Juanma Barranquero <lekktu@gmail.com>
14601
14602 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14603 are now in src/globals.h.
14604 (syms_of_minibuf): Remove spurious & from previous change.
14605
cd394be1 146062011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14607
14608 * minibuf.c (completing-read-function): New variable.
14609 (completing-read-default): Rename from completing-read.
14610 (completing-read): Call completing-read-function.
14611
b14e3e21
CY
146122011-03-19 Juanma Barranquero <lekktu@gmail.com>
14613
14614 * xfaces.c (Fx_load_color_file):
14615 Read color file from absolute filename (bug#8250).
14616
f2b726e6
JB
146172011-03-19 Juanma Barranquero <lekktu@gmail.com>
14618
14619 * makefile.w32-in: Update dependencies.
14620
09f6ff02
EZ
146212011-03-17 Eli Zaretskii <eliz@gnu.org>
14622
14623 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14624
29a6015a
PE
146252011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14626
a3a6c54e
PE
14627 Fix more problems found by GCC 4.5.2's static checks.
14628
b766f867
PE
14629 * process.c (make_serial_process_unwind, send_process_trap):
14630 (sigchld_handler): Now static.
14631
be02381c
PE
14632 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14633 That way, the code declares only the vars that it needs.
14634 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14635 * s/cygwin.h (PTY_ITERATION): Likewise.
14636 * s/darwin.h (PTY_ITERATION): Likewise.
14637 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14638
57048744
PE
14639 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14640 * process.c (allocate_pty): Don't declare stb unless it's needed.
14641
7914961c 14642 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14643 (CONSTANTLIM): Remove; unused.
14644 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14645 Define only if needed.
7914961c 14646
b3967b18
PE
14647 * unexelf.c (unexec): Name an expression,
14648 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14649 Use a different way to cause a compilation error if anyone uses
14650 n rather than nn, a way that does not involve shadowing.
73366a00 14651 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14652
29a6015a
PE
14653 * deps.mk (unexalpha.o): Remove; unused.
14654
43cfc33e 14655 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14656 * unexec.h: New file.
ce701a33
PE
14657 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14658 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14659 Depend on unexec.h.
14660 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14661 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14662 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14663 Change as necessary to match prototype in unexec.h.
ce701a33 14664
01f44d5a
PE
14665 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14666 shadowing.
4f63c6bb 14667 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14668
a6670b0b
PE
14669 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14670 Rename locals to avoid shadowing.
14671
cef2010d 14672 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14673 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14674
d4d7173a
PE
14675 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14676
f08b802a
PE
14677 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14678 warning when compiling print.c.
14679
3ddb0639
PE
14680 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14681 instead of using an uninitialized var.
5ad03b97 14682 (font_sort_entities): Mark var as initialized.
3ddb0639 14683
170a2692
PE
14684 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14685
e663c700
PE
14686 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14687 pointers to constants.
89bc529a 14688 (font_parse_fcname): Remove unused vars.
7b81e2d0 14689 (font_delete_unmatched): Now static.
ea838e10 14690 (font_get_spec): Remove; unused.
13a547c6
PE
14691 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14692 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14693 Rename or move locals to avoid shadowing.
e663c700 14694
2a80c887 14695 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14696 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14697
1384fa33 14698 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14699 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14700
8b2c52e9
PE
14701 * alloc.c (mark_backtrace): Move decl from here ...
14702 * lisp.h: ... to here, so that it can be checked.
14703
475545b5 14704 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14705 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14706 (lisp_indirect_variable): Name an expression,
14707 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14708 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14709
b1349114 14710 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14711 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14712 Use const pointer when appropriate.
b1349114 14713
a2928364
PE
14714 * lisp.h (get_system_name, get_operating_system_release):
14715 Move decls here, to check interfaces.
14716 * process.c (get_operating_system_release): Move decl to lisp.h.
14717 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14718 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14719 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14720 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14721 (Fformat_time_string, Fencode_time, Finsert_char):
14722 (Ftranslate_region_internal, Fformat):
14723 Rename or remove local vars to avoid shadowing.
9710023e 14724 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14725
a415e694
PE
14726 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14727 avoid shadowing.
14728
8ef4622d
PE
14729 * lisp.h (eassert): Check that the argument compiles, even if
14730 ENABLE_CHECKING is not defined.
14731
946f9a5b
PE
14732 * data.c (Findirect_variable): Name an expression, to avoid
14733 gcc -Wbad-function-cast warning.
112396d6 14734 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14735 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14736 (Fmake_variable_buffer_local, Fmake_local_variable):
14737 Mark variables as initialized.
52746918 14738 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14739
e5aab7e7 14740 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14741 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14742 Rename locals to avoid shadowing.
dff45157
PE
14743 (mark_stack): Move local variables into the #ifdef region where
14744 they're used.
7bc26fdb
PE
14745 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14746 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14747 needed otherwise.
14748 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14749 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14750 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14751
e5aab7e7
PE
14752 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14753 avoids undefined behavior in theory.
14754
4da60324
PE
14755 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14756
88043301
PE
14757 Use functions, not macros, for up- and down-casing (Bug#8254).
14758 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14759 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14760 to use the following functions instead of these macros.
14761 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14762 EMACS_INT, since callers assume the returned value fits in int.
14763 (upcase1): Likewise, for UPCASE_TABLE.
14764 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14765 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14766 the race-condition problem in the old DOWNCASE.
88043301 14767
19ed5445
PE
14768 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14769 Rename locals to avoid shadowing.
14770 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14771 (regex_compile, re_search_2, re_match_2_internal):
14772 Remove unused local vars.
952db0d7
PE
14773 (FREE_VAR): Rewrite so as not to use empty "else",
14774 which gcc can warn about.
da053e48 14775 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14776 (RETALLOC_IF): Define only if needed.
14777 (WORDCHAR_P): Likewise. This one is never needed, but is used
14778 only in a comment talking about a compiler bug, so put inside
14779 the #if 0 of that comment.
14780 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14781 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14782 Remove; unused.
19ed5445 14783
1f3561e4 14784 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14785 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14786 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14787
ded6f8f7
PE
14788 * search.c (simple_search): Remove unused var.
14789
dbd37a95
PE
14790 * dired.c (compile_pattern): Move decl from here ...
14791 * lisp.h: ... to here, so that it can be checked.
14792 (struct re_registers): New forward decl.
14793
7e47afad
PE
14794 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14795
85f24f61
PE
14796 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14797 All uses changed.
14798 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14799 Rename locals to avoid shadowing.
5671df8f 14800 (Fvertical_motion): Mark locals as initialized.
85f24f61 14801
181aa2be 14802 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14803 (casify_region): Mark local as initialized.
181aa2be 14804
930d429c
PE
14805 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14806
7082eac6
PE
14807 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14808 New macros, so that the caller can use some names other than
14809 gcpro1, gcpro2, etc.
14810 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14811 of the new macros.
14812 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14813 argument, for consistency with GCPRO2_VAR, etc: it is now the
14814 prefix of the variable, not the variable itself. All uses
14815 changed.
38b2c076
PE
14816 * dired.c (directory_files_internal, file_name_completion):
14817 Rename locals to avoid shadowing.
14818
15206ed9
PE
14819 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14820 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14821 dired.c's scmp function, had undefined behavior.
14822 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14823 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14824 * buffer.h: ... to here, because these macros use current_buffer,
14825 and the new implementation with inline functions needs to have
14826 current_buffer in scope now, rather than later when the macros
14827 are used.
14828 (downcase, upcase1): New static inline functions.
14829 (DOWNCASE, UPCASE1): Reimplement using these functions.
14830 This avoids undefined behavior in expressions like
14831 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14832 from race conditions in accessing the global variables
14833 case_temp1 and case_temp2.
14834 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14835 * lisp.h (case_temp1, case_temp2): Remove their decls.
14836 * character.h (ASCII_CHAR_P): Move from here ...
14837 * lisp.h: ... to here, so that the inline functions mentioned
14838 above can use them.
14839
4a6bea26
PE
14840 * dired.c (directory_files_internal_unwind): Now static.
14841
f14b7e14
PE
14842 * fileio.c (file_name_as_directory, directory_file_name):
14843 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14844 Now static.
2893f146
PE
14845 (file_name_as_directory): Use const pointers when appropriate.
14846 (Fexpand_file_name): Likewise. In particular, newdir might
14847 point at constant storage, so make it a const pointer.
fd4ead52 14848 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14849 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14850 signedness issues.
f839df0c
PE
14851 (Fset_file_times, Finsert_file_contents, auto_save_error):
14852 Rename locals to avoid shadowing.
f14b7e14 14853
5716756e 14854 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14855 (Ftry_completion, Fall_completions): Rename or remove locals
14856 to avoid shadowing.
5716756e 14857
b4c3046a
PE
14858 * marker.c (bytepos_to_charpos): Remove; unused.
14859
b45db522
PE
14860 * lisp.h (verify_bytepos, count_markers): New decls,
14861 so that gcc does not warn that these functions aren't declared.
14862
85876d07
PE
14863 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14864 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14865 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14866 (copy_text): Remove unused local var.
85876d07 14867
03d78a21 14868 * filelock.c (within_one_second): Now static.
b3dd38ab 14869 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14870
5df8f01b
PE
14871 * buffer.c (fix_overlays_before): Mark locals as initialized.
14872 (fix_start_end_in_overlays): Likewise. This function should be
14873 simplified by using pointers-to-pointers, but that's a different
14874 matter.
b1d876f1 14875 (switch_to_buffer_1): Now static.
8f54f30a
PE
14876 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14877 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14878
a70072c9 14879 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14880 Fix pointer signedness issue.
edced198
PE
14881 (sys_subshell): Mark local as volatile if checking for lint,
14882 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14883 (MAXPATHLEN): Define only if needed.
a70072c9 14884
a0977c44
PE
14885 * process.c (serial_open, serial_configure): Move decls from here ...
14886 * systty.h: ... to here, so that they can be checked.
14887
a884fdcc
PE
14888 * fns.c (get_random, seed_random): Move extern decls from here ...
14889 * lisp.h: ... to here, so that they can be checked.
14890
604efe86 14891 * sysdep.c (reset_io): Now static.
b8950c94 14892 (wait_for_termination_signal): Remove; unused.
604efe86 14893
38fc62d9
PE
14894 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14895 (copy_keymap_item, append_key, push_text_char_description):
14896 Now static.
1004a21a 14897 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14898 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14899 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14900 (describe_map_tree):
14901 Rename locals to avoid shadowing.
38fc62d9 14902
2f2650da
PE
14903 * keyboard.c: Declare functions static if they are not used elsewhere.
14904 (echo_char, echo_dash, cmd_error, top_level_2):
14905 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14906 (read_char, kbd_buffer_get_event, make_lispy_position):
14907 (make_lispy_event, make_lispy_movement, apply_modifiers):
14908 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14909 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14910 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14911 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14912 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14913
a053e86c 14914 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14915 (mark_kboards): Move decl here ...
14916 * alloc.c (mark_kboards): ... from here.
a053e86c 14917
4752793e
PE
14918 * lisp.h (force_auto_save_soon): New decl.
14919
74f10ca7 14920 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14921 (DEFINE_DUMMY_FUNCTION): New macro.
14922 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14923 Use it.
c03cd23f
PE
14924 (main): Add casts to avoid warnings
14925 if GCC considers string literals to be constants.
74f10ca7 14926
022e70d4
PE
14927 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14928
59d6fe83
PE
14929 * dbusbind.c: Pointer signedness fixes.
14930 (xd_signature, xd_append_arg, xd_initialize):
14931 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14932 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14933 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14934 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14935
78320123
PE
14936 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14937 if GCC considers string literals to be constants.
49cebcca 14938 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14939
35ac2a97
SM
149402011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14941
fb103ca9
SM
14942 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14943 (print_preprocess, print_object): New macro to fix last change.
14944
35ac2a97
SM
14945 * print.c (print_preprocess): Don't forget font objects.
14946
62973b41
JB
149472011-03-16 Juanma Barranquero <lekktu@gmail.com>
14948
14949 * emacs.c (USAGE3): Doc fixes.
14950
0e48bb22
AS
149512011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14952
14953 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14954 structure.
14955
7684e57b
JB
149562011-03-14 Juanma Barranquero <lekktu@gmail.com>
14957
14958 * lisp.h (VWindow_system, Qfile_name_history):
14959 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14960 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14961 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14962
14963 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14964 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14965
14966 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14967 * w32console.c (detect_input_pending, read_input_pending)
14968 (encode_terminal_code):
14969 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14970 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14971 (w32_system_caret_y, Qfile_name_history):
14972 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14973 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14974 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14975 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14976 * w32proc.c (Qlocal, report_file_error):
14977 * w32term.c (Vwindow_system, updating_frame):
14978 * w32uniscribe.c (initialized, uniscribe_font_driver):
14979 Remove unneeded extern declarations.
14980
2aa46d6c
CY
149812011-03-14 Chong Yidong <cyd@stupidchicken.com>
14982
c96bbc66 14983 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14984
cffc6f3b
CY
149852011-03-13 Chong Yidong <cyd@stupidchicken.com>
14986
14987 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14988 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14989 These macros can no longer be used for assignment.
14990
44f230aa
SM
14991 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14992 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14993 (record_buffer_markers, fetch_buffer_markers): New functions for
14994 recording and fetching special buffer markers.
14995 (set_buffer_internal_1, set_buffer_temp): Use them.
14996
14997 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14998
14999 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15000
15001 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15002 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15003
15004 * xdisp.c (hscroll_window_tree):
15005 (reconsider_clip_changes): Use PT instead of BUF_PT.
15006
d251f04b
EZ
150072011-03-13 Eli Zaretskii <eliz@gnu.org>
15008
15009 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15010 $(EMACS_ROOT)/lib/intprops.h.
15011
f0c77cd1
PE
150122011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15013
3eca4629
PE
15014 Fix more problems found by GCC 4.5.2's static checks.
15015
7c86ee98
PE
15016 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15017 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15018 (xg_free_frame_widgets): Make it clear that a local variable is
15019 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15020 (gdk_window_get_screen): Make it clear that this macro is needed
15021 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15022 (int_gtk_range_get_value): New function, which avoids a diagnostic
15023 from gcc -Wbad-function-cast.
15024 (xg_set_toolkit_scroll_bar_thumb): Use it.
15025 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15026 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15027 (get_utf8_string, xg_get_file_with_chooser):
15028 Rename locals to avoid shadowing.
15029 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15030
41729b81
PE
15031 * xgselect.c (xg_select): Remove unused var.
15032
f0c77cd1
PE
15033 * image.c (four_corners_best): Mark locals as initialized.
15034 (gif_load): Initialize transparent_p to zero (Bug#8238).
15035 Mark another local as initialized.
ec6cf4c6 15036 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15037
ce0ad53d 15038 * image.c (clear_image_cache): Now static.
d5d5a617 15039 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15040 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15041 (x_edge_detection): Remove unnecessary cast that
15042 gcc -Wbad-function-cast diagnoses.
2037898d 15043 (gif_load): Fix pointer signedness.
6ae141d6
PE
15044 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15045 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15046
33383987 150472011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15048
d32df629
PE
15049 Improve quality of tests for time stamp overflow.
15050 For example, without this patch (encode-time 0 0 0 1 1
15051 1152921504606846976) returns the obviously-bogus value (-948597
15052 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15053 reports time overflow. See
15054 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15055 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15056 * editfns.c: Include limits.h and intprops.h.
15057 (TIME_T_MIN, TIME_T_MAX): New macros.
15058 (time_overflow): Move earlier, to before first use.
15059 (hi_time, lo_time): New functions, for an accurate test for
15060 out-of-range times.
15061 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15062 (Fget_internal_run_time): Don't assume time_t fits in int.
15063 (make_time): Use list2 instead of Fcons twice.
15064 (Fdecode_time): More accurate test for out-of-range times.
15065 (check_tm_member): New function.
15066 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15067 (lisp_time_argument): Don't rely on undefined left-shift and
15068 right-shift behavior when checking for time stamp overflow.
8be6f318 15069
fe31d94c
PE
15070 * editfns.c (time_overflow): New function, refactoring common code.
15071 (Fformat_time_string, Fdecode_time, Fencode_time):
15072 (Fcurrent_time_string): Use it.
15073
8be6f318
PE
15074 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15075 * dired.c (make_time): Move to ...
15076 * editfns.c (make_time): ... here.
15077 * systime.h: Note the move.
15078
09d9db2c 150792011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15080
126bc0dc
YM
15081 * fringe.c (update_window_fringes): Remove unused variables.
15082
c47cbdfd
YM
15083 * unexmacosx.c (copy_data_segment): Also copy __got section.
15084 (Bug#8223)
15085
7ac80be9
EZ
150862011-03-12 Eli Zaretskii <eliz@gnu.org>
15087
c96bbc66 15088 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15089 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15090 Constify `char *' arguments and their references according to
15091 prototypes in tparam.h.
15092
ecb0f94d 15093 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15094
7ac80be9
EZ
15095 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15096 Adapt all references accordingly.
15097
15098 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15099
ef1fd07e
TT
151002011-03-11 Tom Tromey <tromey@redhat.com>
15101
15102 * buffer.c (syms_of_buffer): Remove obsolete comment.
15103
7ef4b50c
EZ
151042011-03-11 Eli Zaretskii <eliz@gnu.org>
15105
15106 * termhooks.h (encode_terminal_code): Declare prototype.
15107
15108 * msdos.c (encode_terminal_code): Don't declare prototype.
15109
15110 * term.c (encode_terminal_code): Now external again, used by
15111 w32console.c and msdos.c.
15112
44f230aa
SM
15113 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15114 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15115
4b1ec863 151162011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15117
1714f52b 15118 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15119
4b1ec863
PE
15120 * fringe.c (update_window_fringes): Mark locals as initialized
15121 (Bug#8227).
15122 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15123
524c7aa6
PE
15124 * alloc.c (mark_fringe_data): Move decl from here ...
15125 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15126 to check its interface.
15127 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15128
a5c0af81 15129 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15130 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15131 (fontset_font): Mark local as initialized.
a9a06e0b 15132 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15133
b4716021
PE
15134 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15135
811e9bac 15136 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15137 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15138 (x_own_selection, Fx_disown_selection_internal): Rename locals
15139 to avoid shadowing.
15140 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15141
7e3ab302
PE
15142 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15143 so that the caller can use some name other than gcpro1.
15144 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15145 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15146 (Fx_backspace_delete_keys_p):
15147 Use them to avoid shadowing, and rename vars to avoid shadowing.
15148 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15149 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15150 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15151 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15152 Remove unused locals.
7e3ab302
PE
15153 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15154 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15155 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15156 macros.
f78faa98 15157
e2b13473
PE
15158 * xterm.h (x_mouse_leave): New decl.
15159
77f23912
PE
15160 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15161 Remove unused functions.
cdf4ba58
PE
15162 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15163 (x_calc_absolute_position): Now static.
7411c686 15164 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15165 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15166 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15167 unless they are used.
38d0b34a
PE
15168 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15169 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15170 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15171 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15172 (x_error_catcher, x_connection_closed, x_error_handler):
15173 (x_error_quitter, xembed_send_message, x_iconify_frame):
15174 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15175 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15176 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15177
44f230aa
SM
15178 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15179 Rename or move locals to avoid shadowing.
6b463e58 15180 (tty_defined_color, merge_face_heights): Now static.
5967d051 15181 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15182 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15183 does not deduce is never used uninitialized.
73719eba
PE
15184 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15185 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15186
426994c3 15187 * terminal.c (store_terminal_param): Now static.
5489860b 15188
032f1620 15189 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15190 (set_frame_menubar): Remove unused local.
d4323972 15191 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15192 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15193 since they might point to immutable storage.
281585b0
PE
15194 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15195 since it's unused otherwise.
032f1620 15196
367c19e5 15197 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15198 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15199 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15200 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15201 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15202 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15203 does not deduce are never used uninitialized.
70739cbe 15204
07b48fa9
PE
15205 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15206
8868a238 15207 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15208 * window.c (window_loop, size_window):
15209 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15210
7e5cf297 15211 * window.c (display_buffer): Now static.
d6550a9f
PE
15212 (size_window): Mark variables that gcc -Wuninitialized
15213 does not deduce are never used uninitialized.
a586633d
PE
15214 * window.h (check_all_windows): New decl, to forestall
15215 gcc -Wmissing-prototypes diagnostic.
5b555da1 15216 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15217
f6095868
PE
15218 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15219 shadowing.
15220 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15221 Include <limits.h>.
15222 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15223 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15224 (load_charset_map): Mark variables that gcc -Wuninitialized
15225 does not deduce are never used uninitialized.
53df7c11 15226 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15227
f38b440c
PE
15228 * coding.c (coding_set_source, coding_set_destination):
15229 Use "else { /* comment */ }" rather than "else /* comment */;"
15230 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15231 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15232 a block, when the outer 'i' will do.
15233 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15234 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15235 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15236 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15237 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15238 Rename locals to avoid shadowing.
15239 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15240 * coding.c (emacs_mule_char, encode_invocation_designation):
15241 Now static, since they're not used elsewhere.
413bb2db 15242 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15243 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15244 (decode_coding_emacs_mule): Mark variables that gcc
15245 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15246 (detect_coding_iso_2022): Initialize a local variable that might
15247 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15248 this initialization is needed. (Bug#8211)
5f58e762
PE
15249 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15250 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15251 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15252 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15253 Remove unused macros.
f38b440c 15254
232b38b9 15255 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15256 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15257 * character.c (string_count_byte8): Likewise.
232b38b9 15258
fb90da1b
PE
15259 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15260 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15261
fb93dbc2
PE
15262 * chartab.c (copy_sub_char_table): Now static, since it's not used
15263 elsewhere.
5c156ace
PE
15264 (sub_char_table_ref_and_range, char_table_ref_and_range):
15265 Rename locals to avoid shadowing.
bbcd0949 15266 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15267
7d3b3862 15268 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15269 (BIDI_BOB): Remove unused macro.
7d3b3862 15270
6be7d3da
PE
15271 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15272 deduce are never used uninitialized.
c2ed9c8b 15273 * term.c (encode_terminal_code): Likewise.
6be7d3da 15274
75f8807f 15275 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15276
50938595
PE
15277 * tparam.h: New file.
15278 * term.c, tparam.h: Include it.
15279 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15280 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15281 Move these decls to tparam.h, and make them agree with what
15282 is actually in tparam.c. The previous trick of using incompatible
15283 decls in different modules does not conform to the C standard.
15284 All callers of tparam changed to use tparam's actual API.
15285 * tparam.c (tparam1, tparam, tgoto):
15286 Use const pointers where appropriate.
15287
fbceeba2
PE
15288 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15289 * cm.h (struct cm): Likewise.
15290 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15291 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15292 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15293 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15294 (turn_on_face, init_tty): Likewise.
15295 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15296
7f3f1250
PE
15297 * term.c (term_mouse_position): Rename local to avoid shadowing.
15298
e6ca6543
PE
15299 * alloc.c (mark_ttys): Move decl from here ...
15300 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15301
c40f8d15
AS
153022011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15303
15304 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15305
cfe0661d
JB
153062011-03-09 Juanma Barranquero <lekktu@gmail.com>
15307
15308 * search.c (compile_pattern_1): Remove argument regp, unused since
15309 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15310 (compile_pattern): Don't pass it.
15311
0afb4571
J
153122011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15313
15314 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15315 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15316 for ! HAVE_GTK3.
15317 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15318
15319 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15320
15321 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15322 gdk_window_get_screen, gdk_window_get_geometry,
15323 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15324 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15325 (xg_get_pixbuf_from_pixmap): New function.
15326 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15327 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15328 Call xg_get_pixbuf_from_pixmap instead of
15329 gdk_pixbuf_get_from_drawable.
15330 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15331 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15332 (xg_check_special_colors): Use GtkStyleContext and its functions
15333 for HAVE_GTK3.
15334 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15335 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15336 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15337 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15338 Call gtk_widget_get_preferred_size.
0afb4571
J
15339 (xg_frame_resized): gdk_window_get_geometry only takes 5
15340 parameters.
44f230aa
SM
15341 (xg_win_to_widget, xg_event_is_for_menubar):
15342 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15343 (xg_set_widget_bg): New function.
15344 (delete_cb): New function.
895009e1 15345 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15346 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15347 (xg_set_background_color): Call xg_set_widget_bg.
15348 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15349 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15350 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15351 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15352 if ! HAVE_GTK3.
15353 (update_frame_tool_bar): Call gtk_widget_hide.
15354 (xg_initialize): Use GDK_KEY_g.
15355
15356 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15357 if ! HAVE_GTK3
15358 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15359
15360 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15361 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15362 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15363
1c2cc4ef
JB
153642011-03-08 Juanma Barranquero <lekktu@gmail.com>
15365
15366 * w32xfns.c (select_palette): Check success of RealizePalette against
15367 GDI_ERROR, not zero.
15368
33383987 15369See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15370
15371;; Local Variables:
15372;; coding: utf-8
aac0c6e3
MR
15373;; End:
15374
2f097256 15375 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15376
15377 This file is part of GNU Emacs.
15378
15379 GNU Emacs is free software: you can redistribute it and/or modify
15380 it under the terms of the GNU General Public License as published by
15381 the Free Software Foundation, either version 3 of the License, or
15382 (at your option) any later version.
15383
15384 GNU Emacs is distributed in the hope that it will be useful,
15385 but WITHOUT ANY WARRANTY; without even the implied warranty of
15386 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15387 GNU General Public License for more details.
15388
15389 You should have received a copy of the GNU General Public License
15390 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.