`put-image' doc fix
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3bbd2265
LMI
12011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * editfns.c (Fdelete_region): Clarify the use of the named
4 parameters (bug#6788).
5
adc47434
MR
62011-07-14 Martin Rudalics <rudalics@gmx.at>
7
8 * indent.c (Fvertical_motion): Set and restore w->pointm when
9 saving and restoring the window's buffer (Bug#9006).
10
837c31f8
LMI
112011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
12
13 * editfns.c (Fstring_to_char): Clarify just what is returned
14 (bug#6576). Text by Eli Zaretskii.
15
ac389d0c
JB
162011-07-13 Juanma Barranquero <lekktu@gmail.com>
17
18 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
19
0be0ce47
EZ
202011-07-13 Eli Zaretskii <eliz@gnu.org>
21
22 * buffer.c (mmap_find): Fix a typo.
23
cd18e7e3
JB
242011-07-13 Johan Bockgård <bojohan@gnu.org>
25
26 Fix execution of x selection hooks.
27 * xselect.c (Qx_lost_selection_functions)
28 (Qx_sent_selection_functions): New vars.
29 (syms_of_xselect): DEFSYM them.
30 (x_handle_selection_request): Pass Qx_sent_selection_functions
31 rather than Vx_sent_selection_functions to Frun_hook_with_args.
32 (x_handle_selection_clear,x_clear_frame_selections):
33 Pass Qx_lost_selection_functions rather than
34 Vx_lost_selection_functions to Frun_hook_with_args.
35
47ea7f44
PE
362011-07-13 Paul Eggert <eggert@cs.ucla.edu>
37
ac389d0c 38 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
39 The old code sometimes used this field without initializing it.
40
47ea7f44
PE
41 * alloc.c (gc_sweep): Don't read past end of array.
42 In theory, the old code could also have corrupted Emacs internals,
43 though it'd be very unlikely.
44
bc985c87
AS
452011-07-12 Andreas Schwab <schwab@linux-m68k.org>
46
47 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 48 argument. (Bug#4026)
bc985c87 49
0cf34688
LMI
502011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
51
b3dadd76
LMI
52 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
53 key" (bug#4257).
54
0cf34688
LMI
55 * window.c (Fset_window_start): Doc fix (bug#4199).
56 (Fset_window_hscroll): Ditto.
57
270768cd
PE
582011-07-12 Paul Eggert <eggert@cs.ucla.edu>
59
077e3dda 60 Fix minor new problems caught by GCC 4.6.1.
270768cd 61 * term.c (init_tty): Remove unused local.
490011a6 62 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 63 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 64 not used otherwise.
270768cd 65
b1f58454
CY
662011-07-12 Chong Yidong <cyd@stupidchicken.com>
67
68 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
69
22b9578d
LMI
702011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
71
6e70ab07
LMI
72 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
73 are the mini-buffer and the echo area (bug#3320).
74
22b9578d
LMI
75 * term.c (init_tty): Remove support for supdup, c10 and perq
76 terminals, which are no longer supported (bug#1482).
77
8974cc9f
JB
782011-07-10 Johan Bockgård <bojohan@gnu.org>
79
80 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
81
a560d974
JD
822011-07-10 Jan Djärv <jan.h.d@swipnet.se>
83
84 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
85 for non-popups (Bug#3642).
86
1dae0f0a
AS
872011-07-10 Andreas Schwab <schwab@linux-m68k.org>
88
268c2c36 89 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 90 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
91 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
92 * cm.c (losecursor): Likewise.
1dae0f0a
AS
93 * data.c (fmod): Likewise.
94 * dispnew.c (swap_glyphs_in_rows): Likewise.
95 * emacs.c (memory_warning_signal): Likewise.
96 * floatfns.c (float_error): Likewise.
97 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
98 (otf_open, font_otf_capability, generate_otf_features)
99 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
100 Likewise.
101 * image.c (pbm_read_file): Likewise.
102 * indent.c (string_display_width): Likewise.
103 * intervals.c (check_for_interval, search_for_interval)
104 (inc_interval_count, count_intervals, root_interval)
105 (adjust_intervals_for_insertion, make_new_interval): Likewise.
106 * lread.c (defalias): Likewise.
268c2c36 107 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
108 * regex.c (set_image_of_range_1, set_image_of_range)
109 (regex_grow_registers): Likewise.
110 * sysdep.c (strerror): Likewise.
111 * termcap.c (valid_filename_p, tprint, main): Likewise.
112 * tparam.c (main): Likewise.
113 * unexhp9k800.c (run_time_remap, save_data_space)
114 (update_file_ptrs, read_header, write_header, calculate_checksum)
115 (copy_file, copy_rest, display_header): Likewise.
116 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
117 Likewise.
118 * xdisp.c (check_it): Likewise.
119 * xfaces.c (register_color, unregister_color, unregister_colors):
120 Likewise.
121 * xfns.c (print_fontset_result): Likewise.
122 * xrdb.c (member, fatal, main): Likewise.
123
99033785
PE
1242011-07-10 Paul Eggert <eggert@cs.ucla.edu>
125
126 Fix minor problems found by static checking (Bug#9031).
127 * chartab.c (char_table_set_range, map_sub_char_table):
128 Remove unused locals.
129 (uniprop_table): Now static.
130 * composite.c (_work_char): Remove unused static var.
131
9cb2ac56
JB
1322011-07-09 Juanma Barranquero <lekktu@gmail.com>
133
134 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
135
f25661f0
JD
1362011-07-09 Jan Djärv <jan.h.d@swipnet.se>
137
138 * gtkutil.c (qttip_cb): Remove code without function.
139
8278c4fe
EZ
1402011-07-09 Eli Zaretskii <eliz@gnu.org>
141
142 * w32.c (pthread_sigmask): New stub.
143
1692ae2d 1442011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 145
8a6ebd58 146 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
147 sigprocmask is portable only for single-threaded applications, and
148 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
149 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
150 (LIBES): Use it.
151 * callproc.c (Fcall_process):
152 * process.c (create_process):
153 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
154 Use pthread_sigmask, not sigprocmask.
123403e4 155
1b854618
JD
1562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
157
158 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
159 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
160 wrong (Bug#8591).
161
3fe4b549
JD
1622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
163
0ce7e563
JD
164 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
165 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
166 (xg_hide_tooltip): Fix comment.
167
3fe4b549
JD
168 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
169 in registerServicesMenuSendTypes.
170 (validRequestorForSendType): Don't check ns_return_types.
171
172 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
173 ns_return_type.
174
5df75e47
JR
1752011-07-08 Jason Rumney <jasonr@gnu.org>
176
177 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
178 frame struct members of non-existent frames (Bug#6284).
179
699c10bd
JD
1802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
181
4393663b
JD
182 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
183 variable firstTime not needed on OSX >= 10.6.
184 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
185 >= 10.5. Use setKnobProportion, setDoubleValue.
186
187 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
188 (MAC_OS_X_VERSION_10_5): Define if not defined.
189 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
190 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
191 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
192
193 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
194 cString and lossyCString on OSX >= 10.4
195
196 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
197 sizeToFit on OSX >= 10.2.
198
199 * nsimage.m (allocInitFromFile): Don't use deprecated method
200 bestRepresentationForDevice on OSX >= 10.6.
201
202 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
203 to avoid warning.
204
205 * emacs.c: Declare unexec_init_emacs_zone.
206
a63e0781
JD
207 * nsgui.h: Fix compiler warning about gnulib redefining verify.
208
699c10bd
JD
209 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
210
211 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
212 on svcsMenu (Bug#8842).
213
214 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
215 ns_return_types.
216 (Fns_list_services): Just return Qnil on 10.6, code not working there.
217
218 * nsterm.m (QUTF8_STRING): Declare.
219 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
220 (validRequestorForSendType): Return type is (id).
221 Change indexOfObjectIdenticalTo to indexOfObject.
222 Check if we have local selection before returning self (Bug#8842).
223 (writeSelectionToPasteboard): Put local selection into paste board
224 if we have a local selection (Bug#8842).
225 (syms_of_nsterm): DEFSYM QUTF8_STRING.
226
227 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
228 (ns_get_local_selection): Declare.
229
54e10184
LMI
2302011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
231
9888ff71
LMI
232 * keymap.c (describe_map_tree): Don't insert a double newline at
233 the end of the buffer (bug#1169) and return whether we inserted
234 something.
235
54e10184
LMI
236 * callint.c (Fcall_interactively): Change "reading args" to
237 "providing args" to try to clarify what it does (bug#1010).
238
15fa4783
KH
2392011-07-07 Kenichi Handa <handa@m17n.org>
240
241 * composite.c (composition_compute_stop_pos): Ignore a static
242 composition starting before CHARPOS (Bug#8915).
243
244 * xdisp.c (handle_composition_prop): Likewise.
245
a8815b00
EZ
2462011-07-07 Eli Zaretskii <eliz@gnu.org>
247
248 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
249 (Bug#9015)
250
ef7b981d 2512011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
252
253 * character.h (unicode_category_t): New enum type.
254
255 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
256 (Qchar_code_property_table): New variable.
257 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
258 (UNIPROP_COMPRESSED_FORM_P): New macros.
259 (char_table_ascii): Uncompress the compressed values.
260 (sub_char_table_ref): New arg is_uniprop. Callers changed.
261 Uncompress the compressed values.
ac389d0c 262 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
263 (char_table_ref_and_range): Uncompress the compressed values.
264 (sub_char_table_set): New arg is_uniprop. Callers changed.
265 Uncompress the compressed values.
266 (sub_char_table_set_range): Args changed. Callers changed.
267 (char_table_set_range): Adjuted for the above change.
268 (map_sub_char_table): Delete args default_val and parent. Add arg
269 top. Give decoded values to a Lisp function.
270 (map_char_table): Adjusted for the above change. Give decoded
271 values to a Lisp function. Gcpro more variables.
272 (uniprop_table_uncompress)
273 (uniprop_decode_value_run_length): New functions.
274 (uniprop_decoder, uniprop_decoder_count): New variables.
275 (uniprop_get_decoder, uniprop_encode_value_character)
276 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
277 New functions.
278 (uniprop_encoder, uniprop_encoder_count): New variables.
279 (uniprop_get_encoder, uniprop_table)
280 (Funicode_property_table_internal, Fget_unicode_property_internal)
281 (Fput_unicode_property_internal): New functions.
282 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
283 Sunicode_property_table_internal, Sget_unicode_property_internal,
284 and Sput_unicode_property_internal. Defvar_lisp
285 char-code-property-alist.
286
287 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
288 Vunicode_category_table.
289
290 * font.c (font_range): Adjusted for the change of
291 Vunicode_category_table.
292
76b397fb
DN
2932011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
294
295 * m/iris4d.h: Remove file, move contents ...
296 * s/irix6-5.h: ... here.
297
22b4128e
PE
2982011-07-06 Paul Eggert <eggert@cs.ucla.edu>
299
300 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
301 * alloc.c (mark_buffer):
302 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
303 (clone_per_buffer_values): Don't assume that
22b4128e
PE
304 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
305 This isn't true in general, and it's particularly not true
306 if Emacs is configured with --with-wide-int.
307 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
308 New macros, used in the buffer.c change.
309
869795d6
JD
3102011-07-05 Jan Djärv <jan.h.d@swipnet.se>
311
312 * xsettings.c: Use both GConf and GSettings if both are available.
313 (store_config_changed_event): Add comment.
314 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
315 (store_tool_bar_style_changed): New functions.
316 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
317 (struct xsettings): Move font inside HAVE_XFT.
318 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
319 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
320 Move inside HAVE_XFT.
321 (something_changed_gsettingsCB): Renamed from something_changedCB.
322 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
323 also.
324 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
325 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
326 (something_changed_gconfCB): Renamed from something_changedCB.
327 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
328 (parse_settings): Move check for font inside HAVE_XFT.
329 (read_settings, apply_xft_settings): Add comment.
330 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
331 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
332 call store_font_name_changed.
333 (xft_settings_event): Add comment.
334 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
335 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
336 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
337 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
338 (xsettings_initialize): Call init_gsettings last.
339 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
340 comment.
341
d8ed26bd
PE
3422011-07-05 Paul Eggert <eggert@cs.ucla.edu>
343
344 Random fixes. E.g., (random) never returned negative values.
345 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
346 subseconds part to the entropy, as that's a bit more random.
347 Prefer signed to unsigned, since the signedness doesn't matter and
348 in general we prefer signed. When given a limit, use a
349 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
350 latter isn't right if USE_2_TAGS_FOR_INTS.
351 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
352 not 0..VALMASK. Don't discard "excess" bits that random () returns.
353
cabf1cac
SM
3542011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
355
356 * textprop.c (text_property_stickiness):
357 Obey Vtext_property_default_nonsticky.
358 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
359 * w32fns.c (syms_of_w32fns):
360 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
361
6e9b2be9
PE
3622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
363
364 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
365 This is more efficient than Ffile_directory_p and avoids a minor race.
366
90186c68
LMI
3672011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
368
7c301272
LMI
369 * buffer.c (Foverlay_put): Say what the return value is
370 (bug#7835).
371
c4f2d8d4
LMI
372 * fileio.c (barf_or_query_if_file_exists): Check first if the file
373 is a directory before asking whether to use the file name
374 (bug#7564).
ad637907
LMI
375 (barf_or_query_if_file_exists): Make the "File is a directory"
376 error be more correct.
c4f2d8d4 377
90186c68
LMI
378 * fns.c (Frequire): Remove the mention of the .gz files, since
379 that's installation-specific, but keep the mention of
380 `get-load-suffixes'.
381
da64016e
PE
3822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
383
384 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
385 Report string overflow if the output is too long.
386
7d47b580
JB
3872011-07-04 Juanma Barranquero <lekktu@gmail.com>
388
a555cb87
JB
389 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
390 (syms_of_gnutls): Remove duplicate DEFSYM for
391 Qgnutls_bootprop_verify_hostname_error, an error for
392 Qgnutls_bootprop_verify_error (which is no longer used).
393
7d47b580
JB
394 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
395 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
396 Also (re)move comments that are misplaced or no longer relevant.
397
1e49bfab
LMI
3982011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
399
400 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
401
1485f4c0
CY
4022011-07-03 Chong Yidong <cyd@stupidchicken.com>
403
404 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
405 and background color parameters if they have been changed.
406
a9ab721e
LMI
4072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
408
409 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
410
cf7cff57
PE
4112011-07-03 Paul Eggert <eggert@cs.ucla.edu>
412
2e13213d
PE
413 * xsettings.c (SYSTEM_FONT): Define only when used.
414 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
415
cf7cff57
PE
416 * keymap.c (access_keymap_1): Now static.
417
7a8e04f7
CY
4182011-07-02 Chong Yidong <cyd@stupidchicken.com>
419
420 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
421 leave any prefix arg for the up event (Bug#1586).
422
61352f62
LMI
4232011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
424
69bb1ef7
LMI
425 * lread.c (syms_of_lread): Mention single symbols defined by
426 `defvar' or `defconst' (bug#7154).
427
61352f62 428 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 429 (Frequire): Mention get-load-suffixes.
61352f62 430
28545e04
MR
4312011-07-02 Martin Rudalics <rudalics@gmx.at>
432
433 * window.h (window): Remove clone_number slot.
434 * window.c (Fwindow_clone_number, Fset_window_clone_number):
435 Remove.
436 (make_parent_window, make_window, saved_window)
437 (Fset_window_configuration, save_window_save): Don't deal with
438 clone numbers.
439 * buffer.c (Qclone_number): Remove declaration.
440 (sort_overlays, overlay_strings): Don't deal with clone numbers.
441
3349e122
SM
4422011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
443
444 Add multiple inheritance to keymaps.
445 * keymap.c (Fmake_composed_keymap): New function.
446 (Fset_keymap_parent): Simplify.
447 (fix_submap_inheritance): Remove.
448 (access_keymap_1): New function extracted from access_keymap to handle
449 embedded parents and handle lists of maps.
450 (access_keymap): Use it.
451 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
452 (Fcopy_keymap): Handle embedded parents.
453 (Fcommand_remapping, define_as_prefix): Simplify.
454 (Fkey_binding): Simplify.
455 (syms_of_keymap): Move minibuffer-local-completion-map,
456 minibuffer-local-filename-completion-map,
457 minibuffer-local-must-match-map, and
458 minibuffer-local-filename-must-match-map to Elisp.
459 (syms_of_keymap): Defsubr make-composed-keymap.
460 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
461 (parse_menu_item): Trivial simplification.
462
3279eb87
GM
4632011-07-01 Glenn Morris <rgm@gnu.org>
464
465 * Makefile.in (SETTINGS_LIBS): Fix typo.
466
4550efdf
KI
4672011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
468
469 * coding.c (Fencode_coding_string): Record the last coding system
470 used, as the function doc string says (bug#8738).
471
0949d2b6
JD
4722011-07-01 Jan Djärv <jan.h.d@swipnet.se>
473
474 * xsettings.c (store_monospaced_changed): Take new font as arg and
475 check for change against current_mono_font.
476 (EMACS_TYPE_SETTINGS): Remove this and related defines.
477 (emacs_settings_constructor, emacs_settings_get_property)
478 (emacs_settings_set_property, emacs_settings_class_init)
479 (emacs_settings_init, gsettings_obj): Remove.
480 (something_changedCB): New function for HAVE_GSETTINGS.
481 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
482 with value as argument.
483 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
484 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 485 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
486 "changed".
487
488 * xgselect.c: Add defined (HAVE_GSETTINGS).
489 (xgselect_initialize): Ditto.
490
491 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
492 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
493 xg_select.
494
bbc6b304
PE
4952011-07-01 Paul Eggert <eggert@cs.ucla.edu>
496
497 * eval.c (struct backtrace): Simplify and port the data structure.
498 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
499 signed bit field, as this assumption is not portable and it makes
500 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
501 "char debug_on_exit : 1" as this is not portable either; instead,
502 use the portable "unsigned int debug_on_exit : 1". Remove unused
503 member evalargs. Remove obsolete comments about cc bombing out.
504
9851bfc5
JD
5052011-06-30 Jan Djärv <jan.h.d@swipnet.se>
506
51bb811f 507 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
508 Let HAVE_GSETTINGS override HAVE_GCONF.
509 (store_monospaced_changed): New function.
510 (EMACS_SETTINGS): A new type derived from GObject to handle
511 GSettings notifications.
512 (emacs_settings_constructor, emacs_settings_get_property)
513 (emacs_settings_set_property, emacs_settings_class_init):
514 New functions.
515 (gsettings_client, gsettings_obj): New variables.
516 (GSETTINGS_SCHEMA): New define.
517 (something_changedCB): Call store_monospaced_changed.
518 (init_gsettings): New function.
519 (xsettings_initialize): Call init_gsettings.
520 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
521 to NULL.
522
523 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
524 GCONF_CFLAGS/LIBS.
525
5386012d
MR
5262011-06-29 Martin Rudalics <rudalics@gmx.at>
527
528 * window.c (resize_root_window, grow_mini_window)
529 (shrink_mini_window): Rename Qresize_root_window to
530 Qwindow_resize_root_window and Qresize_root_window_vertically to
531 Qwindow_resize_root_window_vertically.
532
f13e0b08
PE
5332011-06-28 Paul Eggert <eggert@cs.ucla.edu>
534
535 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
536
94515237
JB
5372011-06-27 Juanma Barranquero <lekktu@gmail.com>
538
539 * makefile.w32-in: Redesign dependencies so they reflect more
540 clearly which files are directly included by each source file,
541 and not through other includes.
542
e43b6e43
MR
5432011-06-27 Martin Rudalics <rudalics@gmx.at>
544
545 * buffer.c (Qclone_number): Declare static and DEFSYM it.
546 (sort_overlays, overlay_strings): When an overlay's clone number
547 matches the window's clone number process the overlay even if
548 the overlay's window property doesn't match the current window.
549
d68443dc
MR
550 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
551 (Fwindow_hchild): Rename to Fwindow_left_child.
552 (Fwindow_next): Rename to Fwindow_next_sibling.
553 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
554 (resize_window_check): Rename to window_resize_check.
555 (resize_window_apply): Rename to window_resize_apply.
556 (Fresize_window_apply): Rename to Fwindow_resize_apply.
557 (Fdelete_other_windows_internal, resize_frame_windows)
558 (Fsplit_window_internal, Fdelete_window_internal)
559 (grow_mini_window, shrink_mini_window)
560 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 561
c7e73be5
JD
5622011-06-26 Jan Djärv <jan.h.d@swipnet.se>
563
564 * emacsgtkfixed.h: State that this is only used with Gtk+3.
565 (emacs_fixed_set_min_size): Remove.
566 (emacs_fixed_new): Take frame as argument.
567
568 * emacsgtkfixed.c: State that this is only used with Gtk+3.
569 (_EmacsFixedPrivate): Remove minwidth/height.
570 Add struct frame *f.
571 (emacs_fixed_init): Initialize priv->f.
572 (get_parent_class, emacs_fixed_set_min_size): Remove.
573 (emacs_fixed_new): Set priv->f to argument.
574 (emacs_fixed_get_preferred_width)
575 (emacs_fixed_get_preferred_height): Use min_width/height from
576 frames size_hint to set minimum and natural (Bug#8919).
577 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
578 and use min_width/height from frames size_hint to set
579 min_width/height (Bug#8919).
580
581 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
582 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
583 Fix indentation.
c7e73be5 584
cf99dcf8
EZ
5852011-06-26 Eli Zaretskii <eliz@gnu.org>
586
587 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
588 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
589 called at ZV.
590
029529ac
CY
5912011-06-26 Chong Yidong <cyd@stupidchicken.com>
592
593 * process.c (wait_reading_process_output): Bypass select if
594 waiting for a cell while ignoring keyboard input, and input is
595 pending. Suggested by Jan Djärv (Bug#8869).
596
7a7ef429
PE
5972011-06-25 Paul Eggert <eggert@cs.ucla.edu>
598
599 Use gnulib's dup2 module instead of rolling our own.
600 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
601
11fdef7d 6022011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
603
604 * dispnew.c (scrolling_window): Before scrolling, turn off a
605 mouse-highlight in the window being scrolled.
606
cd3520a4
JB
6072011-06-24 Juanma Barranquero <lekktu@gmail.com>
608
609 Move DEFSYM to lisp.h and use everywhere.
610
611 * character.h (DEFSYM): Move declaration...
612 * lisp.h (DEFSYM): ...here.
613
614 * gnutls.c:
615 * minibuf.c:
616 * w32menu.c:
617 * w32proc.c:
618 * w32select.c: Don't include character.h.
619
620 * alloc.c (syms_of_alloc):
621 * buffer.c (syms_of_buffer):
622 * bytecode.c (syms_of_bytecode):
623 * callint.c (syms_of_callint):
624 * casefiddle.c (syms_of_casefiddle):
625 * casetab.c (init_casetab_once):
626 * category.c (init_category_once, syms_of_category):
627 * ccl.c (syms_of_ccl):
628 * cmds.c (syms_of_cmds):
629 * composite.c (syms_of_composite):
630 * dbusbind.c (syms_of_dbusbind):
631 * dired.c (syms_of_dired):
632 * dispnew.c (syms_of_display):
633 * doc.c (syms_of_doc):
634 * editfns.c (syms_of_editfns):
635 * emacs.c (syms_of_emacs):
636 * eval.c (syms_of_eval):
637 * fileio.c (syms_of_fileio):
638 * fns.c (syms_of_fns):
639 * frame.c (syms_of_frame):
640 * fringe.c (syms_of_fringe):
641 * insdel.c (syms_of_insdel):
642 * keymap.c (syms_of_keymap):
643 * lread.c (init_obarray, syms_of_lread):
644 * macros.c (syms_of_macros):
645 * msdos.c (syms_of_msdos):
646 * print.c (syms_of_print):
647 * process.c (syms_of_process):
648 * search.c (syms_of_search):
649 * sound.c (syms_of_sound):
650 * syntax.c (init_syntax_once, syms_of_syntax):
651 * terminal.c (syms_of_terminal):
652 * textprop.c (syms_of_textprop):
653 * undo.c (syms_of_undo):
654 * w32.c (globals_of_w32):
655 * window.c (syms_of_window):
656 * xdisp.c (syms_of_xdisp):
657 * xfaces.c (syms_of_xfaces):
658 * xfns.c (syms_of_xfns):
659 * xmenu.c (syms_of_xmenu):
660 * xsettings.c (syms_of_xsettings):
661 * xterm.c (syms_of_xterm): Use DEFSYM.
662
4228cf16
TZ
6632011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
664
cd3520a4 665 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 666
7fcccf1e
PE
6672011-06-23 Paul Eggert <eggert@cs.ucla.edu>
668
7efb4e0e
PE
669 Integer and buffer overflow fixes (Bug#8873).
670
ff5844ad
PE
671 * print.c (printchar, strout): Check for string overflow.
672 (PRINTPREPARE, printchar, strout):
673 Don't set size unless allocation succeeds.
674
90532f02
PE
675 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
676 for sizes. Check for string overflow more accurately.
677 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
678
6d84508d
PE
679 * macros.c: Integer and buffer overflow fixes.
680 * keyboard.h (struct keyboard.kbd_macro_bufsize):
681 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
682 Use ptrdiff_t, not int, for sizes.
683 Don't increment bufsize until after realloc succeeds.
684 Check for size-calculation overflow.
685 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
686
437b2cb4
PE
687 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
688
8b9ac8b4
PE
689 * lread.c: Integer overflow fixes.
690 (read_integer): Radix is now EMACS_INT, not int,
691 to improve quality of diagnostics for out-of-range radices.
692 Calculate buffer size correctly for out-of-range radices.
693 (read1): Check for integer overflow in radices, and in
694 read-circle numbers.
82cb60d3
PE
695 (read_escape): Avoid int overflow.
696 (Fload, openp, read_buffer_size, read1)
697 (substitute_object_recurse, read_vector, read_list, map_obarray):
698 Use ptrdiff_t, not int, for sizes.
699 (read1): Use EMACS_INT, not int, for sizes.
20270765 700 Check for size overflow.
8b9ac8b4 701
7fcccf1e
PE
702 * image.c (cache_image): Check for size arithmetic overflow.
703
bfbbd7e7
PE
704 * lread.c: Integer overflow issues.
705 (saved_doc_string_size, saved_doc_string_length)
706 (prev_saved_doc_string_size, prev_saved_doc_string_length):
707 Now ptrdiff_t, not int.
708 (read1): Don't assume doc string length fits in int. Check for
709 out-of-range doc string lengths.
710 (read_list): Don't assume file position fits in int.
39019e54 711 (read_escape): Check for hex character overflow.
bfbbd7e7 712
4e323265
LL
7132011-06-22 Leo Liu <sdl.web@gmail.com>
714
715 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
716 Move to minibuffer.el.
717
85fece3e
PE
7182011-06-22 Paul Eggert <eggert@cs.ucla.edu>
719
20b84ce9 720 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
721 The following patches are for when GLYPH_DEBUG && !XASSERT.
722 * dispextern.h (trace_redisplay_p, dump_glyph_string):
723 * dispnew.c (flush_stdout):
724 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
725 Mark as externally visible.
726 * dispnew.c (check_window_matrix_pointers): Now static.
727 * dispnew.c (window_to_frame_vpos):
728 * xfns.c (unwind_create_frame):
729 * xterm.c (x_check_font): Remove unused local.
730 * scroll.c (CHECK_BOUNDS):
731 * xfaces.c (cache_fache): Rename local to avoid shadowing.
732 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
733 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
734 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
735 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
736 Now static.
737 (debug_method_add): Use va_list and vsprintf rather than relying
738 on undefined behavior with wrong number of arguments.
739 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
740 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
741 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
742 since we're not interested in debugging glyphs with old libraries.
743 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
744 GCC 4.6.0's static checking.
745
0766b489
PE
7462011-06-22 Paul Eggert <eggert@cs.ucla.edu>
747
31fd4b32
PE
748 Integer overflow and signedness fixes (Bug#8873).
749 A few related buffer overrun fixes, too.
750
b79e8648
PE
751 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
752
0766b489
PE
753 * dispextern.h (struct face.stipple):
754 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
755 (x_bitmap_mask, x_allocate_bitmap_record)
756 (x_create_bitmap_from_data, x_create_bitmap_from_file)
757 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
758 (x_create_bitmap_from_xpm_data):
759 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
760 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
761 (.bitmaps_last):
762 * xfaces.c (load_pixmap):
763 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
764 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
765 (.bitmaps_last, struct x_output.icon_bitmap):
766 Use ptrdiff_t, not int, for bitmap indexes.
767 (x_allocate_bitmap_record): Check for size overflow.
768 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
769
b081724f
PE
770 Use ptrdiff_t, not int, for overlay counts.
771 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
772 * editfns.c (overlays_around, get_pos_property):
773 * textprop.c (get_char_property_and_overlay):
774 * xdisp.c (next_overlay_change, note_mouse_highlight):
775 * xfaces.c (face_at_buffer_position):
21514da7
PE
776 * buffer.c (OVERLAY_COUNT_MAX): New macro.
777 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
778 (Fnext_overlay_change, Fprevious_overlay_change)
779 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 780 Use ptrdiff_t, not int, for sizes.
21514da7 781 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 782
3de73e5e
PE
783 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
784
2606c57b
PE
785 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
786 (x_session_initialize): Do not assume string length fits in int.
787
aaafe47a
PE
788 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
789 This is unlikely, but can occur if DPI is outlandish.
790
2674ddc8 791 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
792 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
793
28154962
PE
794 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
795 * xrdb.c (magic_file_p, search_magic_path):
796 Omit last arg SUFFIX; it was always 0. All callers changed.
797 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
798
7de51af5
PE
799 * xfont.c (xfont_match): Avoid need for strlen.
800
25ed6cc3
PE
801 * xfns.c: Don't assume strlen fits in int.
802 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
803
4eab31dd
PE
804 * xdisp.c (message_log_check_duplicate): Return intmax_t,
805 not unsigned long, as we prefer signed integers. All callers changed.
806 Detect integer overflow in repeat count.
807 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 808 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 809
171e2a58
PE
810 * termcap.c: Don't assume sizes fit in int and never overflow.
811 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
812 (gobble_line): Check for size-calculation overflow.
813
ad39faca 814 * minibuf.c (Fread_buffer):
6e5bb2dc 815 * lread.c (intern, intern_c_string):
74ca2eb3
PE
816 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
817 Don't assume string length fits in int.
818
52c61c22 819 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
820 * gtkutil.c (style_changed_cb): Avoid need for strlen.
821
b5b8c9e5
PE
822 * font.c: Don't assume string length fits in int.
823 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
824 Use ptrdiff_t, not int.
ccd6111c
PE
825 (font_intern_prop): Don't assume string length fits in int.
826 Don't assume integer property fits in fixnum.
827 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 828
882f0d81 829 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 830 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
831 Reformulate so as not to need the command string.
832 Invoke gzip -cd rather than gunzip, as it's more portable.
833 (lock_info_type, lock_file_1, lock_file):
834 Don't assume pid_t and time_t fit in unsigned long.
835 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
836 (current_lock_owner): Prefer signed type for sizes.
837 Use memcpy, not strncpy, where memcpy is what is really wanted.
838 Don't assume (via atoi) that time_t and pid_t fit in int.
839 Check for time_t and/or pid_t out of range, e.g., via a network share.
840 Don't alloca where an auto var works fine.
841
93f4cf88
PE
842 * fileio.c: Fix some integer overflow issues.
843 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
844 Don't assume string length fits in int.
845 (directory_file_name): Don't assume string length fits in long.
846 (make_temp_name): Don't assume pid fits in int, or that its print
847 length is less than 20.
848
f3e92b69
PE
849 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
850
1bfdaf10
PE
851 * coding.c (make_subsidiaries): Don't assume string length fits in int.
852
35016e9a
PE
853 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
854
3d1e65a1
PE
855 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
856 We prefer signed integers, even for size calculations.
857
0b963a93
PE
858 * emacs.c: Don't assume string length fits in 'int'.
859 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
860 (main): Don't invoke strlen when not needed.
861
573f4b54
PE
862 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
863 (XD_DEBUG_MESSAGE): Don't waste a byte.
864
989f33ba
PE
865 * callproc.c (getenv_internal_1, getenv_internal)
866 (Fgetenv_internal):
965d34eb
PE
867 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
868
e4d29b33
PE
869 * lread.c (invalid_syntax): Omit length argument.
870 All uses changed. This doesn't fix a bug, but it simplifies the
871 code away from its former Hollerith-constant appearance, and it's
872 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 873 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 874
eb49b136
PE
875 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
876 This didn't break anything, but it didn't help either.
877 It's confusing to put a bogus integer in a place where the actual
878 value does not matter.
9f62aeb1 879 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 880 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 881
15375a22
PE
882 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
883 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
884 implementation.
b61cc01c
PE
885 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
886 We prefer signed types, and the value cannot exceed the EMACS_INT
887 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
888 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
889 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
890 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 891
53b2623d
PE
892 * indent.c (sane_tab_width): New function.
893 (current_column, scan_for_column, Findent_to, position_indentation)
894 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 895 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 896
51cab52b 897 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 898
f2ed8a70
PE
899 * lisp.h (lint_assume): New macro.
900 * composite.c (composition_gstring_put_cache):
901 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
902
abe80cc6
PE
903 * editfns.c, insdel.c:
904 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 905
b02c740e
PE
906 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
907
ebc96716
PE
908 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
909
b4e50fa0 910 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 911 Use much-faster test for byte-length change.
311d5d7c 912 Don't assume string byte-length fits in 'int'.
a4cf38e4 913 Check that character arg fits in 'int'.
85461888 914 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 915
c0c1ee9f
PE
916 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
917
a498d7f4
PE
918 * fns.c (concat): Catch string overflow earlier.
919 Do not rely on integer wraparound.
920
51cab52b
PE
921 * dispextern.h (struct it.overlay_strings_charpos)
922 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
923 * xdisp.c (forward_to_next_line_start)
924 (back_to_previous_visible_line_start)
925 (reseat_at_next_visible_line_start, next_element_from_buffer):
926 Don't arbitrarily truncate the value of 'selective' to int.
927
76031fad
PE
928 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
929
5eb55db9
PE
930 * composite.c: Don't truncate sizes to 'int'.
931 (composition_gstring_p, composition_reseat_it)
932 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
933 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
934 not EMACS_UINT, for indexes.
5eb55db9 935
0703a717
PE
936 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
937
d6202519
PE
938 * buffer.c: Include <verify.h>.
939 (struct sortvec.priority, struct sortstr.priority):
8961a454 940 Now EMACS_INT, not int.
c20998a7 941 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
942 (struct sortstr.size, record_overlay_string)
943 (struct sortstrlist.size, struct sortlist.used):
944 Don't truncate size to int.
945 (record_overlay_string): Check for size-calculation overflow.
d6202519 946 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 947
d5a19415
JM
9482011-06-22 Jim Meyering <meyering@redhat.com>
949
029529ac 950 Don't leak an XBM-image-sized buffer
d5a19415
JM
951 * image.c (xbm_load): Free the image buffer after using it.
952
a9041e6c
PE
9532011-06-21 Paul Eggert <eggert@cs.ucla.edu>
954
955 Port to Sun C.
956 * composite.c (find_automatic_composition): Omit needless 'return 0;'
957 that Sun C diagnosed.
958 * fns.c (secure_hash): Fix pointer signedness issue.
959 * intervals.c (static_offset_intervals): New function.
960 (offset_intervals): Use it.
961
7f3f739f
LL
9622011-06-21 Leo Liu <sdl.web@gmail.com>
963
964 * deps.mk (fns.o):
965 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
966 sha512.h.
967
968 * fns.c (secure_hash): Rename from crypto_hash_function and change
969 the first arg to accept symbols.
5b66d427 970 (Fsecure_hash): New primitive.
7f3f739f
LL
971 (syms_of_fns): New symbols.
972
76147d94
DD
9732011-06-20 Deniz Dogan <deniz@dogan.se>
974
975 * process.c (Fset_process_buffer): Clarify return value in
976 docstring.
977
7d7d0045
CY
9782011-06-18 Chong Yidong <cyd@stupidchicken.com>
979
980 * dispnew.c (add_window_display_history): Use BVAR.
981
982 * xdisp.c (debug_method_add): Use BVAR.
983 (check_window_end, dump_glyph_matrix, dump_glyph)
984 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
985
986 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
987 Likewise.
988
989 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
990 check till after the cache is created in init_frame_faces.
991
ff2bc410
SM
9922011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
993
994 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
995
28177add
PE
9962011-06-16 Paul Eggert <eggert@cs.ucla.edu>
997
dd3482fe
PE
998 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
999 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1000 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1001
393d71f3 1002 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1003 * fileio.c (Finsert_file_contents):
1004 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1005 Remove the old (too-loose) buffer overflow checks.
1006 They weren't needed, since make_gap checks for buffer overflow.
1007 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1008 The old code merely checked for Emacs fixnum overflow, and relied
1009 on undefined (wraparound) behavior. The new code avoids undefined
1010 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1011
2e6813b0 1012 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1013 Tune. Don't use wider integers than needed. Don't use alloca.
1014 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1015
599a9e4f
PE
1016 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1017
99561444
PE
1018 * insdel.c, lisp.h (buffer_overflow): New function.
1019 (insert_from_buffer_1, replace_range, replace_range_2):
1020 * insdel.c (make_gap_larger):
1021 * editfns.c (Finsert_char):
1022 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1023
28177add
PE
1024 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1025
e69dafad
PE
10262011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1027
a7af7fde 1028 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1029
b1c46f02
PE
1030 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1031 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1032
e69dafad
PE
1033 * fileio.c: Don't assume EMACS_INT fits in off_t.
1034 (emacs_lseek): New static function.
1035 (Finsert_file_contents, Fwrite_region): Use it.
1036 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1037
566684ea
PE
1038 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1039
e6966cd6
PE
1040 * fns.c: Don't overflow int when computing a list length.
1041 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1042 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1043 truncation on 64-bit hosts. Check for QUIT every
1044 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1045 faster and is responsive enough.
1046 (Flength): Report an error instead of overflowing an integer.
1047 (Fsafe_length): Return a float if the value is not representable
1048 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1049 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1050 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1051
dd0b0efb
PE
1052 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1053 (header_size, word_size): New constants.
1054 (allocate_vectorlike): Don't check size overflow here.
1055 (allocate_vector): Check it here instead, since this is the only
1056 caller of allocate_vectorlike that could cause overflow.
1057 Check that the new vector's length is representable as a fixnum.
1058
86fe5cfe
PE
1059 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1060 The previous code was bogus. For example, next_almost_prime (32)
1061 returned 39, which is undesirable as it is a multiple of 3; and
1062 next_almost_prime (24) returned 25, which is a multiple of 5 so
1063 why was the code bothering to check for multiples of 7?
1064
80e88859
PE
1065 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1066
4a2f0ad6
PE
1067 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1068
f66c7cf8
PE
1069 Variadic C functions now count arguments with ptrdiff_t.
1070 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1071 Back then I didn't know that the Emacs coding style prefers signed int.
1072 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1073 were being counted with int, which may truncate counts on 64-bit
1074 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1075 * lisp.h (struct Lisp_Subr.function.aMANY)
1076 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1077 Arg counts are now ptrdiff_t, not size_t.
1078 All variadic functions and their callers changed accordingly.
1079 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1080 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1081 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1082 * callint.c (Fcall_interactively): Check arg count for overflow,
1083 to avoid potential buffer overrun. Use signed char, not 'int',
1084 for 'varies' array, so that we needn't bother to check its size
1085 calculation for overflow.
1086 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1087 * eval.c (apply_lambda):
1088 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1089 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1090 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1091
a1759b76
PE
1092 * callint.c (Fcall_interactively): Don't use index var as event count.
1093
d96be9fc
PE
1094 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1095 * mem-limits.h (SIZE): Remove; no longer used.
1096
a690a978 1097 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1098
578c21e6
PE
1099 Remove unnecessary casts.
1100 * xterm.c (x_term_init):
1101 * xfns.c (x_set_border_pixel):
1102 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1103 These aren't needed now that we assume ANSI C.
1104
96f53c6c
PE
1105 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1106 It's more likely to cause problems (due to unsigned overflow)
1107 than to cure them.
1108
83c77d31
PE
1109 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1110
ee2079f1
PE
1111 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1112
6da65536
PE
1113 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1114
7147c4a4
PE
1115 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1116
193e32d9
PE
1117 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1118
e5533da6
PE
1119 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1120
9910e595
PE
1121 GLYPH_CODE_FACE returns EMACS_INT, not int.
1122 * dispextern.h (merge_faces):
1123 * xfaces.c (merge_faces):
01103c44
PE
1124 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1125 Don't assume EMACS_INT fits in int.
9910e595 1126
2638320e
PE
1127 * character.h (CHAR_VALID_P): Remove unused parameter.
1128 * fontset.c, lisp.h, xdisp.c: All uses changed.
1129
045eb8d9
PE
1130 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1131
c1f134b5
PE
1132 * fns.c (concat): Minor tuning based on overflow analysis.
1133 This doesn't fix any bugs. Use int to hold character, instead
1134 of constantly refetching from Emacs object. Use XFASTINT, not
1135 XINT, for value known to be a character. Don't bother comparing
1136 a single byte to 0400, as it's always less.
1137
395fcb93 1138 * floatfns.c (Fexpt):
327eeec8
PE
1139 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1140
abbd3d23
PE
1141 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1142 for characters.
1143
684a03ef
PE
1144 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1145
0fed43f3
PE
1146 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1147 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1148 incorrectly succeed when S was a string, because 4294967386 was
1149 truncated before it was used.
1150
8fd02eb7
PE
1151 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1152 Otherwise, an out-of-range integer could cause undefined behavior
1153 on a 64-bit host.
1154
f8c86b69
PE
1155 * composite.c: Use int, not EMACS_INT, for characters.
1156 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1157 EMACS_INT, for values that are known to be in character range.
1158 This doesn't fix any bugs but is the usual style inside Emacs and
1159 may generate better code on 32-bit machines.
1160
34206dd2
PE
1161 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1162 This is for reasons similar to the recent CHAR_STRING fix.
1163 * charset.c (Fencode_char): Check that character arg is actually
1164 a character. Pass an int to ENCODE_CHAR.
1165 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1166 wider than 'int', as a compile-time check to prevent future regressions
1167 in this area.
1168
c5958d4c 1169 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1170
1171 Make sure a 64-bit char is never passed to CHAR_STRING.
1172 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1173 by silently ignoring the top 32 bits, allowing some values
1174 that were far too large to be valid characters.
1175 * character.h: Include <verify.h>.
1176 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1177 arguments are no wider than unsigned, as a compile-time check
1178 to prevent future regressions in this area.
1179 * data.c (Faset):
01103c44 1180 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1181 (Fsubst_char_in_region):
1182 * fns.c (concat):
1183 * xdisp.c (decode_mode_spec_coding):
1184 Adjust to CHAR_STRING's new requirement.
1185 * editfns.c (Finsert_char, Fsubst_char_in_region):
1186 * fns.c (concat): Check that character args are actually
1187 characters. Without this test, these functions did the wrong
1188 thing with wildly out-of-range values on 64-bit hosts.
1189
d37ca623
PE
1190 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1191 These casts should not be needed on 32-bit hosts, either.
1192 * keyboard.c (read_char):
1193 * lread.c (Fload): Remove casts to unsigned.
1194
ea204efb
PE
1195 * lisp.h (UNSIGNED_CMP): New macro.
1196 This fixes comparison bugs on 64-bit hosts.
1197 (ASCII_CHAR_P): Use it.
1198 * casefiddle.c (casify_object):
01103c44 1199 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1200 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1201 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1202 * dispextern.h (FACE_FROM_ID):
1203 * keyboard.c (read_char): Use UNSIGNED_CMP.
1204
41cb286c
PE
1205 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1206 not to EMACS_INT, to avoid GCC warning.
1207
4a1b9832
PE
1208 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1209
55daad71
PE
1210 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1211 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1212 isn't needed on 32-bit machines.
8f95c75c 1213
01103c44
PE
1214 * buffer.c (Fgenerate_new_buffer_name):
1215 Use EMACS_INT for count, not int.
0ceccced 1216 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1217
1218 * data.c (Qcompiled_function): Now static.
1219
c6f072e7
PE
1220 * window.c (window_body_lines): Now static.
1221
20ce5912
PE
1222 * image.c (gif_load): Rename local to avoid shadowing.
1223
9c4c5f81
PE
1224 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1225 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1226 * alloc.c (make_save_value): Integer argument is now of type
1227 ptrdiff_t, not int.
1228 (mark_object): Use ptrdiff_t, not int.
1229 * lisp.h (pD): New macro.
1230 * print.c (print_object): Use it.
1231
c0c5c8ae
PE
1232 * alloc.c: Use EMACS_INT, not int, to count objects.
1233 (total_conses, total_markers, total_symbols, total_vector_size)
1234 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1235 (total_free_floats, total_floats, total_free_intervals)
1236 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1237 Now EMACS_INT, not int. All uses changed.
1238 (Fgarbage_collect): Compute overall total using a double, so that
1239 integer overflow is less likely to be a problem. Check for overflow
1240 when converting back to an integer.
5a25e253
PE
1241 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1242 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1243 These were 'int' variables that could overflow on 64-bit hosts;
1244 they were never used, so remove them instead of repairing them.
211a0b2a 1245 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1246 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1247 Previously, this ceilinged at INT_MAX, but that doesn't work on
1248 64-bit machines.
e46bb31a 1249 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1250
c78baabf 1251 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1252 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1253 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1254 when a (possibly-narrower) signed value would do just as well.
1255 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1256
c9d624c6
PE
1257 * alloc.c: Catch some string size overflows that we were missing.
1258 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1259 for convenience in STRING_BYTES_MAX.
1260 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1261 The definition here is exact; the one in lisp.h was approximate.
1262 (allocate_string_data): Check for string overflow. This catches
1263 some instances we weren't catching before. Also, it catches
1264 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1265 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1266 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1267
c9d624c6
PE
1268 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1269 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1270 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1271
353032ce
PE
1272 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1273
2bccce07
PE
1274 * alloc.c (Fmake_string): Check for out-of-range init.
1275
0ac30604
SM
12762011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1277
1278 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1279
c195f2de
JD
12802011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1281
1282 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1283 xg_get_default_scrollbar_width.
1284
1285 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1286 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1287 (style_changed_cb): Call update_theme_scrollbar_width and call
1288 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1289 all frames (Bug#8505).
1290 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1291 Call gtk_window_set_resizable if HAVE_GTK3.
1292 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1293 and height if HAVE_GTK3 (Bug#8505).
1294 (scroll_bar_width_for_theme): New variable.
1295 (update_theme_scrollbar_width): New function.
1296 (xg_get_default_scrollbar_width): Move code to
1297 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1298 (xg_initialize): Call update_theme_scrollbar_width.
1299
1300 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1301
1302 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1303
e10ac9f1
MR
13042011-06-12 Martin Rudalics <rudalics@gmx.at>
1305
1306 * frame.c (make_frame): Call other_buffer_safely instead of
1307 other_buffer.
1308
1309 * window.c (temp_output_buffer_show): Call display_buffer with
1310 second argument Vtemp_buffer_show_specifiers and reset latter
1311 immediately after the call.
1312 (Vtemp_buffer_show_specifiers): New variable.
1313 (auto_window_vscroll_p, next_screen_context_lines)
1314 (Vscroll_preserve_screen_position): Remove leading asterisks from
1315 doc-strings.
1316
2d3c217e 13172011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1318
7b7f97e8 1319 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1320 * buffer.c (Qclone_number): Remove for now, as it's unused.
1321 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1322 (record_buffer): Remove unused local.
1323 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1324 (set_frame_buffer_list): Remove; unused.
1325 * frame.h (other_visible_frames): Remove decl.
1326 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1327 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1328 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1329 if HAVE_GPM.
1330 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1331 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1332 Define only if HAVE_GPM.
1333 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1334 (update_hints_inhibit): Remove; never set. All uses removed.
1335 * widgetprv.h (emacsFrameClassRec): Remove decl.
1336 * window.c (delete_deletable_window): Now returns void, since it
1337 wasn't returning anything.
1338 (compare_window_configurations): Remove unused locals.
1339 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1340 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1341 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1342 the same widths as pointers. This follows up on the 2011-05-06 patch.
1343 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1344 * xterm.h: Likewise.
1345 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1346
1384b89e
JB
13472011-06-12 Juanma Barranquero <lekktu@gmail.com>
1348
1349 * makefile.w32-in: Update dependencies.
1350 (LISP_H): Add lib/intprops.h.
1351
1100a63c
CY
13522011-06-11 Chong Yidong <cyd@stupidchicken.com>
1353
1354 * image.c (gif_load): Add animation frame delay to the metadata.
1355 (syms_of_image): Use DEFSYM. New symbol `delay'.
1356
6198ccd0
MR
13572011-06-11 Martin Rudalics <rudalics@gmx.at>
1358
1359 * window.c (delete_deletable_window): Re-add.
1360 (Fset_window_configuration): Rewrite to handle dead buffers and
1361 consequently deletable windows.
1362 (window_tree, Fwindow_tree): Remove. Supply functionality in
1363 window.el.
1364 (compare_window_configurations): Simplify code.
1365
b6e3633c
AS
13662011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1367
1ab0dee5
AS
1368 * image.c (imagemagick_load_image): Fix type mismatch.
1369 (Fimagemagick_types): Likewise.
1370
b6e3633c
AS
1371 * window.h (replace_buffer_in_windows): Declare.
1372
9397e56f
MR
13732011-06-11 Martin Rudalics <rudalics@gmx.at>
1374
1375 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1376 Qclone_number. Remove external declaration of Qdelete_window.
1377 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1378 code.
1379 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1380 Qbuffer_list_update_hook if allowed.
1381 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1382 buffer list implementation.
1383 (other_buffer_safely): New function.
1384 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1385 calls to replace_buffer_in_windows and
1386 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1387 if allowed.
1388 (record_buffer): Inhibit quitting and rewrite using quittable
1389 functions. Run Qbuffer_list_update_hook if allowed.
1390 (Frecord_buffer, Funrecord_buffer): New functions.
1391 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1392 switch-to-buffer to window.el.
1393 (bury-buffer): Move to window.el.
1394 (Vbuffer_list_update_hook): New variable.
1395
1396 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1397 section.
1398
1399 * window.h (resize_frame_windows): Move up in code.
1400 (Fwindow_frame): Remove EXFUN.
1401 (replace_buffer_in_all_windows): Remove prototype.
1402 (replace_buffer_in_windows_safely): Add prototype.
1403
1404 * window.c: Declare Qdelete_window static again. Move down
1405 declaration of select_count.
1406 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1407 (Fother_window): Move to window.el.
1408 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1409 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1410 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1411 window.el.
1412 (replace_buffer_in_windows): Implement by calling
1413 Qreplace_buffer_in_windows.
1414 (replace_buffer_in_all_windows): Remove with some functionality
1415 moved into replace_buffer_in_windows_safely.
1416 (replace_buffer_in_windows_safely): New function.
1417 (select_window_norecord, select_frame_norecord): Move in front
1418 of run_window_configuration_change_hook. Remove now obsolete
1419 declarations.
1420 (Fset_window_buffer): Rewrite doc-string. Call
1421 Qrecord_window_buffer.
1422 (keys_of_window): Move binding for other-window to window.el.
1423
b50691aa
CY
14242011-06-11 Chong Yidong <cyd@stupidchicken.com>
1425
1426 * dispextern.h (struct image): Replace data member, whose int_val
1427 and ptr_val fields were not used by anything, with a single
1428 lisp_val object.
1429
1430 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1431 (gif_clear_image, gif_load, imagemagick_load_image)
1432 (gs_clear_image, gs_load): Callers changed.
1433
3f754b86
PE
14342011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1435
cca69397
PE
1436 * buffer.h: Include <time.h>, for time_t.
1437 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1438
109e28d0
PE
1439 Fix minor problems found by static checking.
1440
60737f02
PE
1441 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1442
4b66faf3
PE
1443 Make identifiers static if they are not used in other modules.
1444 * data.c (Qcompiled_function, Qframe, Qvector):
1445 * image.c (QimageMagick, Qsvg):
1446 * minibuf.c (Qmetadata):
1447 * window.c (resize_window_check, resize_root_window): Now static.
1448 * window.h (resize_window_check, resize_root_window): Remove decls.
1449
109e28d0
PE
1450 * window.c (window_deletion_count, delete_deletable_window):
1451 Remove; unused.
46a4ce9e
PE
1452 (window_body_lines): Now static.
1453 (Fdelete_other_windows_internal): Mark vars as initialized.
1454 Make sure 'resize_failed' is initialized.
1455 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1456 (resize_window_apply): Remove unused local.
1457 * window.h (delete_deletable_window): Remove decl.
1458
109e28d0 1459 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1460 (imagemagick_load_image): Fix pointer signedness problem by changing
1461 last arg from unsigned char * to char *. All uses changed.
1462 Also, fix a local for similar reasons.
1463 Remove unused locals. Remove locals to avoid shadowing.
1464 (fn_rsvg_handle_free): Remove; unused.
1465 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1466 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1467
3f754b86
PE
1468 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1469
2547adb1
CY
14702011-06-10 Chong Yidong <cyd@stupidchicken.com>
1471
1472 * image.c (gif_load): Fix omitted cast error introduced by
1473 2011-06-06 change.
1474
2c8e37d4
MR
14752011-06-10 Martin Rudalics <rudalics@gmx.at>
1476
1477 * window.h (resize_proportionally, orig_total_lines)
1478 (orig_top_line): Remove from window structure.
1479 (set_window_height, set_window_width, change_window_heights)
1480 (Fdelete_window): Remove prototypes.
1481 (resize_frame_windows): Remove duplicate declaration.
1482
440a42e3
EZ
14832011-06-10 Eli Zaretskii <eliz@gnu.org>
1484
1485 * window.h (resize_frame_windows, resize_window_check)
1486 (delete_deletable_window, resize_root_window)
1487 (resize_frame_windows): Declare prototypes.
1488
1489 * window.c (resize_window_apply): Make definition be "static" to
1490 match the prototype.
1491
562dd5e9
MR
14922011-06-10 Martin Rudalics <rudalics@gmx.at>
1493
1494 * window.c: Remove declarations of Qwindow_size_fixed,
1495 window_min_size_1, window_min_size_2, window_min_size,
1496 size_window, window_fixed_size_p, enlarge_window, delete_window.
1497 Remove static from declaration of Qdelete_window, it's
1498 temporarily needed by Fbury_buffer.
1499 (replace_window): Don't assign orig_top_line and
1500 orig_total_lines.
1501 (Fdelete_window, delete_window): Remove. Window deletion is
1502 handled by window.el.
1503 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1504 Fdelete_window calls with calls to Qdelete_window.
1505 (Fdelete_other_windows): Remove. Deleting other windows is
1506 handled by window.el.
1507 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1508 handled in window.el.
1509 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1510 Window minimum sizes are handled in window.el.
1511 (shrink_windows, size_window, set_window_height)
1512 (set_window_width, change_window_heights, window_height)
1513 (window_width, CURBEG, CURSIZE, enlarge_window)
1514 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1515 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1516 handled in window.el.
1517 (make_dummy_parent): Rename to make_parent_window and give it a
1518 second argument horflag.
1519 (make_window): Don't set resize_proportionally any more.
1520 (Fsplit_window): Remove. Windows are split in window.el.
1521 (save_restore_action, save_restore_orig_size)
1522 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1523 Resize mini windows in window.el.
1524 (grow_mini_window, shrink_mini_window): Implement by calling
1525 Qresize_root_window_vertically, resize_window_check and
1526 resize_window_apply.
1527 (saved_window, Fset_window_configuration, save_window_save): Do
1528 not handle orig_top_line, orig_total_lines, and
1529 resize_proportionally.
1530 (window_min_height, window_min_width): Move to window.el.
1531 (keys_of_window): Move bindings for delete-other-windows,
1532 split-window, delete-window and enlarge-window to window.el.
1533
1534 * buffer.c: Temporarily extern Qdelete_window.
1535 (Fbury_buffer): Temporarily call Qdelete_window instead of
1536 Fdelete_window (Fbury_buffer will move to window.el soon).
1537
1538 * frame.c (set_menu_bar_lines_1): Remove code handling
1539 orig_top_line and orig_total_lines.
1540
1541 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1542 set_window_height but set heights directly.
1543 (change_frame_size_1): Use resize_frame_windows.
1544
1545 * xdisp.c (init_xdisp): Don't use set_window_height but set
1546 heights directly.
1547
1548 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1549 resize_frame_windows instead of change_window_heights and run
1550 run_window_configuration_change_hook.
1551
1552 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1553 instead of change_window_heights and run
1554 run_window_configuration_change_hook.
1555
1a13852e
MR
15562011-06-09 Martin Rudalics <rudalics@gmx.at>
1557
1558 * window.c (replace_window): Rename second argument REPLACEMENT to
1559 NEW. New third argument SETFLAG. Rewrite.
1560 (delete_window, make_dummy_parent): Call replace_window with
1561 third argument 1.
1562 (window_list_1): Move down in code.
1563 (run_window_configuration_change_hook): Move set_buffer part
1564 before select_frame_norecord part in order to unwind correctly.
1565 Rename count1 to count.
1566 (recombine_windows, delete_deletable_window, resize_root_window)
1567 (Fdelete_other_windows_internal)
1568 (Frun_window_configuration_change_hook, make_parent_window)
1569 (resize_window_check, resize_window_apply, Fresize_window_apply)
1570 (resize_frame_windows, Fsplit_window_internal)
1571 (Fdelete_window_internal, Fresize_mini_window_internal): New
1572 functions.
1573 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1574
f3d1777e
MR
15752011-06-08 Martin Rudalics <rudalics@gmx.at>
1576
496e208e
MR
1577 * window.h (window): Add some new members to window structure -
1578 normal_lines, normal_cols, new_total, new_normal, clone_number,
1579 splits, nest, prev_buffers, next_buffers.
1580 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1581 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1582
f3d1777e
MR
1583 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1584 Remove.
496e208e
MR
1585 (make_dummy_parent): Set new members of windows structure.
1586 (make_window): Move down in code. Handle new members of window
1587 structure.
1588 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1589 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1590 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1591 (Fset_window_prev_buffers, Fwindow_next_buffers)
1592 (Fset_window_next_buffers, Fset_window_clone_number): New
1593 functions.
1594 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1595 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1596 Doc-string fixes.
1597 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1598 Argument WINDOW can be now internal window too.
1599 (Fwindow_use_time): Move up in code.
1600 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1601 Rewrite doc-string.
1602 (Fset_window_configuration, saved_window)
1603 (Fcurrent_window_configuration, save_window_save): Handle new
1604 members of window structure.
b9e809c2
MR
1605 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1606 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1607 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1608 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1609 Qget_mru_window, Qresize_root_window,
1610 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1611 Qauto_buffer_name; staticpro them.
f3d1777e 1612
abde8f8c
MR
16132011-06-07 Martin Rudalics <rudalics@gmx.at>
1614
1615 * window.c (Fwindow_total_size, Fwindow_left_column)
1616 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1617 (Fwindow_list_1): New functions.
1618 (window_box_text_cols): Replace with window_body_cols.
1619 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1620 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1621 (delete_window, Fset_window_configuration): Call
1622 delete_all_subwindows with window as argument.
1623 (delete_all_subwindows): Take a window as argument and not a
1624 structure. Rewrite.
190b47e6
MR
1625 (window_loop): Remove handling of GET_LRU_WINDOW and
1626 GET_LARGEST_WINDOW.
1627 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1628
1629 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1630 window_box_text_cols. delete_all_subwindows now takes a
1631 Lisp_Object as argument.
abde8f8c
MR
1632
1633 * indent.c (compute_motion, Fcompute_motion): Use
1634 window_body_cols instead of window_box_text_cols.
1635
fa8a67e6
MR
1636 * frame.c (delete_frame): Call delete_all_subwindows with root
1637 window as argument.
1638
a54e3482
DC
16392011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1640
1641 * fns.c (Fputhash): Document return value.
1642
60002bf5
CY
16432011-06-06 Chong Yidong <cyd@stupidchicken.com>
1644
1645 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1646
0c671da6 16472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1648
b862a52a 1649 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1650
be44ca6c
PE
1651 Check for overflow when converting integer to cons and back.
1652 * charset.c (Fdefine_charset_internal, Fdecode_char):
1653 Use cons_to_unsigned to catch overflow.
1654 (Fencode_char): Use INTEGER_TO_CONS.
1655 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1656 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1657 * data.c (long_to_cons, cons_to_long): Remove.
1658 (cons_to_unsigned, cons_to_signed): New functions.
1659 These signal an error for invalid or out-of-range values.
1660 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1661 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1662 * font.c (Ffont_variation_glyphs):
1663 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1664 * lisp.h: Include <intprops.h>.
1665 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1666 (cons_to_signed, cons_to_unsigned): New decls.
1667 (long_to_cons, cons_to_long): Remove decls.
1668 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1669 (Fprimitive_undo): Use CONS_TO_INTEGER.
1670 * xfns.c (Fx_window_property): Likewise.
1671 * xselect.c: Include <limits.h>.
1672 (x_own_selection, selection_data_to_lisp_data):
1673 Use INTEGER_TO_CONS.
1674 (x_handle_selection_request, x_handle_selection_clear)
1675 (x_get_foreign_selection, Fx_disown_selection_internal)
1676 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1677 (lisp_data_to_selection_data): Use cons_to_unsigned.
1678 (x_fill_property_data): Use cons_to_signed.
1679 Report values out of range.
1680
d1f3d2af
PE
1681 Check for buffer and string overflow more precisely.
1682 * buffer.h (BUF_BYTES_MAX): New macro.
1683 * lisp.h (STRING_BYTES_MAX): New macro.
1684 * alloc.c (Fmake_string):
1685 * character.c (string_escape_byte8):
1686 * coding.c (coding_alloc_by_realloc):
1687 * doprnt.c (doprnt):
1688 * editfns.c (Fformat):
1689 * eval.c (verror):
1690 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1691 since they may not be the same number.
1692 * editfns.c (Finsert_char):
1693 * fileio.c (Finsert_file_contents):
1694 Likewise for BUF_BYTES_MAX.
1695
dd52fcea
PE
1696 * image.c: Use ptrdiff_t, not int, for sizes.
1697 (slurp_file): Switch from int to ptrdiff_t.
1698 All uses changed.
1699 (slurp_file): Check that file size fits in both size_t (for
1700 malloc) and ptrdiff_t (for sanity and safety).
1701
7f9bbdbb
PE
1702 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1703 if b->modtime has its maximal value.
1704
dfe18f82
PE
1705 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1706
84acfcf0
PE
1707 Don't assume time_t can fit into int.
1708 * buffer.h (struct buffer.modtime): Now time_t, not int.
1709 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1710 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1711
ccd9a01a
PE
1712 Minor fixes for signed vs unsigned integers.
1713 * character.h (MAYBE_UNIFY_CHAR):
1714 * charset.c (maybe_unify_char):
1715 * keyboard.c (read_char, reorder_modifiers):
1716 XINT -> XFASTINT, since the integer must be nonnegative.
1717 * ftfont.c (ftfont_spec_pattern):
1718 * keymap.c (access_keymap, silly_event_symbol_error):
1719 XUINT -> XFASTINT, since the integer must be nonnegative.
1720 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1721 since it makes no difference and we prefer signed.
1722 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1723 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1724 nonnegative.
1725
d6d100dd
SM
17262011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1727
1728 * window.h (Fwindow_frame): Declare.
1729
2b6148e4
PE
17302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1733 (SPARE_MEMORY): Always define.
1734 (LARGE_REQUEST): Remove.
1735 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1736
f230ecc9
MR
17372011-06-06 Martin Rudalics <rudalics@gmx.at>
1738
727e958e
MR
1739 * lisp.h: Move EXFUNS for Fframe_root_window,
1740 Fframe_first_window and Fset_frame_selected_window to window.h.
1741
1742 * window.h: Move EXFUNS for Fframe_root_window,
1743 Fframe_first_window and Fset_frame_selected_window here from
1744 lisp.h.
1745
1746 * frame.c (Fwindow_frame, Fframe_first_window)
1747 (Fframe_root_window, Fframe_selected_window)
1748 (Fset_frame_selected_window): Move to window.c.
1749 (Factive_minibuffer_window): Move to minibuf.c.
1750 (Fother_visible_frames_p): New function.
1751
1752 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1753
f230ecc9
MR
1754 * window.c (decode_window, decode_any_window): Move up in code.
1755 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1756 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1757 (Fwindow_buffer): Move up and rewrite doc-string.
1758 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1759 (Fwindow_prev): New functions.
727e958e
MR
1760 (Fwindow_frame): Move here from frame.c. Accept any window as
1761 argument.
1762 (Fframe_root_window, Fframe_first_window)
1763 (Fframe_selected_window): Move here from frame.c. Accept frame
1764 or arbitrary window as argument. Update doc-strings.
1765 (Fminibuffer_window): Move up in code.
1766 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1767 (Fset_frame_selected_window): Move here from frame.c.
1768 Marginal rewrite.
727e958e
MR
1769 (Fselected_window, select_window, Fselect_window): Move up in
1770 code. Minor doc-string fixes.
f230ecc9 1771
4d09bcf6
PE
17722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1775 Do not assume that spare memory exists; that assumption is valid
1776 only if SYSTEM_MALLOC.
1777 (LARGE_REQUEST): New macro, so that the issue of large requests
1778 is separated from the issue of spare memory.
1779
810928a2
AS
17802011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1781
172418ad
AS
1782 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1783 format. (Bug#8806)
1784
43f862f7
AS
1785 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1786
810928a2
AS
1787 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1788 before statements.
1789
a059fe24
JD
17902011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1791
1792 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1793
1794 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1795
1796 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1797 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1798
989bf368
JB
17992011-06-05 Juanma Barranquero <lekktu@gmail.com>
1800
1801 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1802
4b80f674
CY
18032011-06-04 Chong Yidong <cyd@stupidchicken.com>
1804
1805 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1806 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1807 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1808 New error handlers.
4b80f674
CY
1809 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1810 Obey Vx_select_enable_clipboard_manager. Catch errors in
1811 x_clipboard_manager_save (Bug#8779).
1812 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1813 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1814
99a33b77 18152011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1816
1817 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1818
99a33b77 18192011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1820
1821 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1822 in the current matrix if keep_current_p is non-zero.
1823
8264569d
EZ
18242011-06-04 Eli Zaretskii <eliz@gnu.org>
1825
1826 * bidi.c (bidi_level_of_next_char): Fix last change.
1827
57f97249
EZ
18282011-06-03 Eli Zaretskii <eliz@gnu.org>
1829
fec2107c 1830 Support bidi reordering of text covered by display properties.
57f97249 1831
fec2107c
EZ
1832 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1833 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1834 (bidi_cache_search, bidi_cache_iterator_state)
1835 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1836 (bidi_level_of_next_char, bidi_move_to_visually_next):
1837 Support character positions inside a run of characters covered by a
fec2107c
EZ
1838 display string.
1839 (bidi_paragraph_init, bidi_resolve_explicit_1)
1840 (bidi_level_of_next_char): Call bidi_fetch_char and
1841 bidi_fetch_char_advance instead of FETCH_CHAR and
1842 FETCH_CHAR_ADVANCE.
1843 (bidi_init_it): Initialize new members.
1844 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1845 definitions.
1846 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1847 instead of using explicit *_CHAR codes.
d6d100dd
SM
1848 (bidi_resolve_explicit, bidi_resolve_weak):
1849 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1850 bidirectional text is supported only in multibyte buffers.
1851 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1852 it to initialize the frame_window_p member of struct bidi_it.
1853 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1854 (bidi_resolve_explicit, bidi_resolve_weak)
1855 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1856 bidi_it->nchars is non-positive.
1857 (bidi_level_of_next_char): Don't try to lookup the cache for the
1858 next/previous character if nothing is cached there yet, or if we
1859 were just reseat()'ed to a new position.
c40e2fb2 1860
0e14fe90
EZ
1861 * xdisp.c (set_cursor_from_row): Set start and stop points
1862 according to the row's direction when priming the loop that looks
1863 for the glyph on which to display cursor.
1864 (single_display_spec_intangible_p): Function deleted.
1865 (display_prop_intangible_p): Reimplement to call
1866 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1867 Accept 3 additional arguments needed by handle_display_spec.
1868 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1869 values: lists, `(when COND...)' forms, etc.
1870 (single_display_spec_string_p): Support property values that are
1871 lists with the argument STRING its top-level element.
1872 (display_prop_string_p): Fix the condition for processing a
1873 property that is a list to be consistent with handle_display_spec.
fec2107c 1874 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1875 last portion of handle_display_prop.
1876 (compute_display_string_pos): Accept additional argument
1877 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1878 value of a `display' property is a "replacing spec".
1879 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1880 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1881 the display property, but just return a value indicating whether
1882 the display property will replace the characters it covers.
1883 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1884 frame_window_p members of struct bidi_it.
d6d100dd
SM
1885 (compute_display_string_pos, compute_display_string_end):
1886 New functions.
fec2107c
EZ
1887 (push_it): Accept second argument POSITION, where pop_it should
1888 jump to continue iteration.
1889 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1890
fec2107c
EZ
1891 * keyboard.c (adjust_point_for_property): Adjust the call to
1892 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1893
1894 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1895 (bidi_init_it): Update prototypes.
1896 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1897 (compute_display_string_pos, compute_display_string_end):
1898 Declare prototypes.
fec2107c
EZ
1899 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1900 EMACS_INT.
fc6f18ce 1901
40087514 19022011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1903
57f53182
PE
1904 Malloc failure behavior now depends on size of allocation.
1905 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1906 * lisp.h: Change signatures accordingly.
1907 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1908 All callers changed. (Bug#8762)
1909
1910 * gnutls.c: Use Emacs's memory allocators.
1911 Without this change, the gnutls library would invoke malloc etc.
1912 directly, which causes problems on non-SYNC_INPUT hosts, and which
1913 runs afoul of improving memory_full behavior. (Bug#8761)
1914 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1915 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1916 xfree instead of the default malloc, realloc, free.
1917 (Fgnutls_boot): No need to check for memory allocation failure,
1918 since xmalloc does that for us.
1919
ac32cd99 1920 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1921 * category.c (hash_get_category_set):
1922 * ccl.c (ccl_driver):
1923 * charset.c (Fdefine_charset_internal):
1924 * charset.h (struct charset.hash_index):
1925 * composite.c (get_composition_id, gstring_lookup_cache)
1926 (composition_gstring_put_cache):
1927 * composite.h (struct composition.hash_index):
1928 * dispextern.h (struct image.hash):
1929 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1930 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1931 (hashfn_equal, hashfn_user_defined, make_hash_table)
1932 (maybe_resize_hash_table, hash_lookup, hash_put)
1933 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1934 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1935 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1936 * image.c (make_image, search_image_cache, lookup_image)
1937 (xpm_put_color_table_h):
1938 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1939 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 1940 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 1941 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1942 * alloc.c (allocate_vectorlike):
1943 Check for overflow in vector size calculations.
1944 * ccl.c (ccl_driver):
1945 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1946 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1947 need to be updated by these changes.
40087514
PE
1948 * fns.c (make_hash_table, maybe_resize_hash_table):
1949 Check for integer overflow with large hash tables.
0de4bb68
PE
1950 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1951 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1952 (SXHASH_REDUCE): New macro.
1953 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1954 Use it instead of discarding useful hash info with large hash values.
1955 (sxhash_float): New function.
1956 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1957 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1958 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1959 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1960 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1961 Adjust signatures to match updated version of code.
1962 (consing_since_gc): Now EMACS_INT, since a single hash table can
1963 use more than INT_MAX bytes.
1964
698d32e2
DN
19652011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1966
1967 Make it possible to build with GCC-4.6+ -O2 -flto.
1968
1969 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1970
fd6fa53f
SM
19712011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1972
1973 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1974 Call minibuffer-inactive-mode.
1975
864db017
JB
19762011-05-31 Juanma Barranquero <lekktu@gmail.com>
1977
1978 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1979 Update dependencies.
1980
2ad0baf4
DN
19812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1982
1983 * data.c (init_data): Remove code for UTS, this system is not
1984 supported anymore.
1985
4fcc2638
DN
19862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1987
1988 Don't force ./temacs to start in terminal mode.
1989
1990 * frame.c (make_initial_frame): Initialize faces in all cases, not
1991 only when CANNOT_DUMP is defined.
1992 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1993
c56e0fd5
DN
19942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1995
1996 * dispnew.c (add_window_display_history): Use const for the string
1997 pointer. Remove declaration, not needed.
1998
333d54da 19992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2000
55d4c1b2 2001 Use 'inline', not 'INLINE'.
333d54da 2002 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2003 * alloc.c, fontset.c (INLINE): Remove.
2004 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2005 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2006 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2007 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2008 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2009
738db178
DN
20102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2011
2012 Make it possible to run ./temacs.
2013
2014 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2015 syms_of_callproc does the same thing. Remove test for
2016 "initialized", do it in the caller.
2017 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2018
620c53a6
SM
20192011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2020
2021 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2022 (read_minibuf): Use get_minibuffer.
2023 (syms_of_minibuf): Use DEFSYM.
2024 (Qmetadata): New var.
2025 * data.c (Qbuffer): Don't make it static.
2026 (syms_of_data): Use DEFSYM.
2027
e003a292
PE
20282011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2029
2030 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2031 (CCL_CODE_MIN): New macro.
2032
ed008a6d
PE
20332011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2034
3687c2ef
PE
2035 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2036
ed008a6d
PE
2037 * eval.c (Qdebug): Now static.
2038 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2039 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2040 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2041
d66c4c7c
CY
20422011-05-29 Chong Yidong <cyd@stupidchicken.com>
2043
2044 * image.c: Various fixes to ImageMagick code comments.
2045 (Fimagemagick_types): Doc fix.
2046
5fbc2025
PE
20472011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2048
0196f88a
PE
2049 Minor fixes prompted by GCC 4.6.0 warnings.
2050
2051 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2052
5fbc2025
PE
2053 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2054 (x_clipboard_manager_save_all): Move extern decl to ...
2055 * xterm.h: ... here, so that it can be checked for consistency.
2056
1dd3c2d9
CY
20572011-05-29 Chong Yidong <cyd@stupidchicken.com>
2058
2059 * xselect.c (x_clipboard_manager_save_frame)
2060 (x_clipboard_manager_save_all): New functions.
2061 (Fx_clipboard_manager_save): Lisp function deleted.
2062
2063 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2064 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2065
2066 * xterm.h: Update prototype.
2067
5ba6571d
WX
20682011-05-28 William Xu <william.xwl@gmail.com>
2069
2070 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2071 exiting (Bug#8239).
2072
3eaff834
JM
20732011-05-28 Jim Meyering <meyering@redhat.com>
2074
e1900994 2075 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2076 * fns.c (to_uchar): Define.
2077 (crypto_hash_function): Use it to convert some newly-signed
2078 variables to unsigned, to avoid sign-extension bugs. For example,
2079 without this change, (md5 "truc") would evaluate to
2080 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2081 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2082 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2083
0f6990a7
PE
20842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2085
2086 Integer overflow fixes.
c8a9ca5a 2087
08686060
PE
2088 * dbusbind.c: Serial number integer overflow fixes.
2089 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2090 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2091 to hold a serial number that is too large for a fixnum.
2092 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2093 Check for serial numbers out of range. Decode any serial number
59568bf0 2094 that was so large that it became a float. (Bug#8722)
08686060 2095
2d1fc3c7
PE
2096 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2097 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2098 Use XFASTINT rather than XUINT when numbers are nonnegative.
2099 (xd_append_arg, Fdbus_method_return_internal):
2100 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2101 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2102 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2103 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2104 (Bug#8722)
2d1fc3c7 2105
c8a9ca5a
PE
2106 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2107
519e1d69
PE
2108 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2109
30569699
PE
2110 ccl: add integer overflow checks
2111 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2112 (IN_INT_RANGE): New macros.
2113 (ccl_driver): Use them to check for integer overflow when
2114 decoding a CCL program. Many of the new checks are whether XINT (x)
2115 fits in int; it doesn't always, on 64-bit hosts. The new version
2116 doesn't catch all possible integer overflows, but it's an
847044ea 2117 improvement. (Bug#8719)
30569699 2118
c11285dc
PE
2119 * alloc.c (make_event_array): Use XINT, not XUINT.
2120 There's no need for unsigned here.
2121
fdccd48e
PE
2122 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2123 This follows up to the 2011-05-06 change that substituted uintptr_t
2124 for EMACS_INT. This case wasn't caught back then.
2125
37910ab2
PE
2126 Rework Fformat to avoid integer overflow issues.
2127 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2128 now (part of C89). Include <verify.h>.
2129 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2130 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2131 (Fformat): Avoid the prepass trying to compute sizes; it was only
2132 approximate and thus did not catch overflow reliably. Instead, walk
2133 through the format just once, formatting and computing sizes as we go,
2134 checking for integer overflow at every step, and allocating a larger
2135 buffer as needed. Keep track separately whether the format is
2136 multibyte. Keep only the most-recently calculated precision, rather
2137 than them all. Record whether each argument has been converted to
2138 string. Use EMACS_INT, not int, for byte and char and arg counts.
2139 Support field widths and precisions larger than INT_MAX. Avoid
2140 sprintf's undefined behavior with conversion specifications such as %#d
2141 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2142 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2143 formatting out-of-range floating point numbers with int
9173deec 2144 formats. (Bug#8668)
37910ab2 2145
2e6578fb
PE
2146 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2147
0ae6bdee
PE
2148 * data.c: Avoid integer truncation in expressions involving floats.
2149 * data.c: Include <intprops.h>.
2150 (arith_driver): When there's an integer overflow in an expression
2151 involving floating point, convert the integers to floating point
2152 so that the resulting value does not suffer from catastrophic
2153 integer truncation. For example, on a 64-bit host (* 4
2154 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2155 Do not rely on undefined behavior after integer overflow.
2156
de883a70
PE
2157 merge count_size_as_multibyte, parse_str_to_multibyte
2158 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2159 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2160 Check for integer overflow.
2161 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2162 since it's now a duplicate of the other. This is more of
2163 a character than a buffer op, so better that it's in character.c.
2164 * fns.c, print.c: Adjust to above changes.
2165
2ff916cb
PE
21662011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2167
2168 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2169
f1b54466
PE
21702011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2171
fb1ac845
PE
2172 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2173 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2174 (x_clipboard_manager_save): Now static.
2175 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2176
f1b54466
PE
2177 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2178 (crypto_hash_function): Now static.
2179 Fix pointer signedness problems. Avoid unnecessary initializations.
2180
a9f737ee
CY
21812011-05-27 Chong Yidong <cyd@stupidchicken.com>
2182
2183 * termhooks.h (Vselection_alist): Make it terminal-local.
2184
2185 * terminal.c (create_terminal): Initialize it.
2186
2187 * xselect.c: Support for clipboard managers.
2188 (Vselection_alist): Move to termhooks.h as terminal-local var.
2189 (LOCAL_SELECTION): New macro.
2190 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2191 (symbol_to_x_atom): Remove gratuitous arg.
2192 (x_handle_selection_request, lisp_data_to_selection_data)
2193 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2194 (x_own_selection, x_get_local_selection, x_convert_selection):
2195 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2196 (some_frame_on_display): Delete unused function.
2197 (Fx_own_selection_internal, Fx_get_selection_internal)
2198 (Fx_disown_selection_internal, Fx_selection_owner_p)
2199 (Fx_selection_exists_p): New optional frame arg.
2200 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2201 (x_handle_selection_clear): Don't treat other terminals with the
2202 same keyboard specially. Use the terminal-local Vselection_alist.
2203 (x_clear_frame_selections): Use Frun_hook_with_args.
2204
2205 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2206
2207 * xterm.h: Add support for those atoms.
2208
e067f0c1
CY
22092011-05-26 Chong Yidong <cyd@stupidchicken.com>
2210
2211 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2212 (converted_selections, conversion_fail_tag): New global variables.
2213 (x_selection_request_lisp_error): Free the above.
2214 (x_get_local_selection): Remove unnecessary code.
2215 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2216 of converted selections stored in converted_selections.
2217 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2218 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2219 (x_convert_selection): New function.
2220 (x_handle_selection_event): Simplify.
2221 (x_get_foreign_selection): Don't ignore incoming requests while
2222 waiting for an answer; this will fail when we implement
2223 SAVE_TARGETS, and seems unnecessary anyway.
2224 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2225 (Vx_sent_selection_functions): Doc fix.
2226
0f4aebc0
LL
22272011-05-26 Leo Liu <sdl.web@gmail.com>
2228
2229 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2230
e61124cd
YM
22312011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2232
2233 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2234
2235 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2236 for fringe update if it has periodic bitmap.
ac389d0c 2237 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2238 and fringe_bitmap_periodic_p.
2239
2240 * fringe.c (get_fringe_bitmap_data): New function.
2241 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2242 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2243 row. Mark glyph row for fringe update if periodicity changed.
2244
2245 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2246 for fringe update unless it has periodic bitmap.
2247
f16d9837
KH
22482011-05-25 Kenichi Handa <handa@m17n.org>
2249
2250 * xdisp.c (get_next_display_element): Set correct it->face_id for
2251 a static composition.
2252
e1b90ef6
LL
22532011-05-24 Leo Liu <sdl.web@gmail.com>
2254
2255 * deps.mk (fns.o):
2256 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2257
2258 * fns.c (crypto_hash_function, Fsha1): New function.
2259 (Fmd5): Use crypto_hash_function.
2260 (syms_of_fns): Add Ssha1.
2261
7400048f
PE
22622011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2263
2264 * gnutls.c: Remove unused macros.
2265 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2266 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2267 Remove macros that are defined and never used.
2268 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2269
abb71cf4
CY
22702011-05-22 Chong Yidong <cyd@stupidchicken.com>
2271
2272 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2273 (Fx_get_selection_internal): Minor cleanup.
2274 (Fx_own_selection_internal): Rename arguments for consistency with
2275 select.el.
2276
6307db39
PE
22772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2280
f3d4e0a4
CY
22812011-05-22 Chong Yidong <cyd@stupidchicken.com>
2282
2283 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2284
4d8ade89
YM
22852011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2286
2287 * dispnew.c (scrolling_window): Don't exclude the case that the
2288 last enabled row in the desired matrix touches the bottom boundary.
2289
32078c8d
GM
22902011-05-21 Glenn Morris <rgm@gnu.org>
2291
2292 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2293 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2294 and add some more files.
32078c8d 2295
7285dc67
EZ
22962011-05-20 Eli Zaretskii <eliz@gnu.org>
2297
2298 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2299 report_file_error introduced by the change from 2011-05-07.
2300
89d1bd22
PE
23012011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2302
2303 * systime.h (Time): Define only if emacs is defined.
2304 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2305 where the include path doesn't have X11/X.h by default. See
2306 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2307
e23640bb 23082011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2309
2310 * composite.c (find_automatic_composition): Fix previous change.
2311
b9704ad9
GM
23122011-05-20 Glenn Morris <rgm@gnu.org>
2313
2314 * lisp.mk: New file, split from Makefile.in.
2315 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2316 (shortlisp): Remove.
2317 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2318
4a720484
GM
23192011-05-19 Glenn Morris <rgm@gnu.org>
2320
2321 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2322 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2323 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2324 (lisp): Set the order to that of loadup.el.
2325 (shortlisp): Make it a copy of $lisp.
2326 (SOME_MACHINE_LISP): Remove.
2327 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2328 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2329
a28d4396
KH
23302011-05-18 Kenichi Handa <handa@m17n.org>
2331
2332 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2333 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2334 (find_automatic_composition): Mostly rewrite for efficiency.
2335
a2b1fa8e
JB
23362011-05-18 Juanma Barranquero <lekktu@gmail.com>
2337
2338 * makefile.w32-in: Update dependencies.
2339
8e1f5610
CS
23402011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2341
2342 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2343 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2344
7025ee00 23452011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2346
cdfa6eab
PE
2347 Fix some integer overflow issues, such as string length overflow.
2348
06d6db33
PE
2349 * insdel.c (count_size_as_multibyte): Check for string overflow.
2350
2b4560a8
PE
2351 * character.c (lisp_string_width): Check for string overflow.
2352 Use EMACS_INT, not int, for string indexes and lengths; in
2353 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2354 the resulting string length overflows an EMACS_INT; instead,
2355 report a string overflow if no precision given. When checking for
2356 precision exhaustion, use a check that cannot possibly have
2357 integer overflow. (Bug#8675)
2358 * character.h (lisp_string_width): Adjust to new signature.
2359
cb93f9be
PE
2360 * alloc.c (string_overflow): New function.
2361 (Fmake_string): Use it. This doesn't change behavior, but saves
2362 a few bytes and will simplify future changes.
2363 * character.c (string_escape_byte8): Likewise.
2364 * lisp.h (string_overflow): New decl.
2365
1a1f3366
PE
2366 Fixups, following up to the user-interface timestamp change.
2367 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2368 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2369 * msdos.c (mouse_get_pos): Likewise.
2370 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2371 * w32gui.h (Time): Define by including "systime.h" rather than by
2372 declaring it ourselves. (Bug#8664)
2373
d4e3e4d3
PE
2374 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2375 * image.c (clear_image_cache): Likewise.
2376
f6a24d19
PE
2377 * term.c (term_mouse_position): Don't assume time_t wraparound.
2378
08dc5ae6
PE
2379 Be more systematic about user-interface timestamps.
2380 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2381 and sometimes 'EMACS_UINT', to represent these timestamps.
2382 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2383 This makes the code easier to follow, and makes it easier to catch
2384 integer overflow bugs such as Bug#8664.
2385 * frame.c (Fmouse_position, Fmouse_pixel_position):
2386 Use Time, not unsigned long, for user-interface timestamps.
2387 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2388 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2389 * keyboard.h (last_event_timestamp): Likewise.
2390 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2391 * menu.h (xmenu_show): Likewise.
2392 * term.c (term_mouse_position): Likewise.
2393 * termhooks.h (struct input_event.timestamp): Likewise.
2394 (struct terminal.mouse_position_hook): Likewise.
2395 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2396 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2397 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2398 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2399 what it was before.
2400 * menu.h, termhooks.h: Include "systime.h", for Time.
2401
8e55734a
PE
2402 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2403 Don't assume that the difference between two unsigned long values
2404 can fit into an integer. At this point, we know button_down_time
2405 <= event->timestamp, so the difference must be nonnegative, so
2406 there's no need to cast the result if double-click-time is
2407 nonnegative, as it should be; check that it's nonnegative, just in
2408 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2409 apart (about 25 days). (Bug#8664)
8e55734a 2410
841f1b75 2411 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2412 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2413
3e26f69c
PE
2414 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2415 that always fit in int. Use a sentinel instead of a counter, to
2416 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2417 * frame.h (struct frame): Use int for menu_bar_items_used
2418 instead of EMACS_INT, since it always fits in int.
3e26f69c 2419
5cc152c0
PE
2420 * menu.c (grow_menu_items): Check for int overflow.
2421
d89eb65e
PE
2422 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2423
5235bd3e
PE
2424 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2425 Before, the code was not consistent. These values cannot exceed
2426 2**31 - 1 so there's no need to make them unsigned.
2427 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2428 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2429 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2430 as modifiers.
2431 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2432
bc827e23
PE
2433 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2434 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2435 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2436 presumably because the widths might not match.
2437
78eb494e
PE
2438 * window.c (size_window): Avoid needless test at loop start.
2439
04f2d78b
CB
24402011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2441
2442 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2443
d2fc7e3d 24442011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2445
2446 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2447
d2fc7e3d 24482011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2449
2450 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2451 `width' to `bar_area_x' and `bar_area_width', respectively.
2452 (x_scroll_run): Take account of fringe background extension.
2453
04f2d78b
CB
2454 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2455 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2456 `bar_area_width', respectively.
2457 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2458 background extension.
2459
79b70037
GM
24602011-05-10 Jim Meyering <meyering@redhat.com>
2461
2462 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2463
2f142cc5
JB
24642011-05-10 Juanma Barranquero <lekktu@gmail.com>
2465
2466 * image.c (Finit_image_library): Return t for built-in image types,
2467 like pbm and xbm. (Bug#8640)
2468
57679c86
AS
24692011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2470
2471 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2472
888c9e86
EZ
24732011-05-07 Eli Zaretskii <eliz@gnu.org>
2474
b0512a1d
EZ
2475 * w32console.c (Fset_screen_color): Doc fix.
2476 (Fget_screen_color): New function.
2477 (syms_of_ntterm): Defsubr it.
2478
7285dc67
EZ
2479 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2480 unlink the temporary file if Fcall_process didn't create it in the
2481 first place.
2482 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2483 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2484 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2485 cue to call_process_cleanup not to close that handle.
2486
4d3fcc8e
BK
24872011-05-07 Ben Key <bkey76@gmail.com>
2488
2489 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2490 one of two shell specific rules, either bootstrap-temacs-CMD or
2491 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2492 to the previous implementation of the bootstrap-temacs rule.
2493 The bootstrap-temacs-CMD rule is similar to the previous
2494 implementation of the bootstrap-temacs rule except that it
2495 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2496 variable.
2497
2498 These changes, along with some changes to nt/configure.bat,
2499 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2500 earlier fix to add support for --cflags and --ldflags options
2501 that include quotes so that it works whether make uses cmd or
2502 sh as the shell.
2503
b4289b64
MA
25042011-05-06 Michael Albinus <michael.albinus@gmx.de>
2505
2506 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2507 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2508 is a constant.
2509 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2510 a string. Handle both cases.
2511 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2512 (Fdbus_register_method): Use Qinvalid_function.
2513
af4c0e28
JB
25142011-05-06 Juanma Barranquero <lekktu@gmail.com>
2515
2516 * makefile.w32-in: Update dependencies.
2517 (LISP_H): Add inttypes.h and stdin.h.
2518 (PROCESS_H): Add unistd.h.
2519
c51453d9
EZ
25202011-05-06 Eli Zaretskii <eliz@gnu.org>
2521
2522 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2523 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2524
8ff0ac3c 25252011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2526
4c4b566b
PE
2527 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2528
aab2b9b5
PE
2529 * term.c (vfatal): Remove stray call to va_end.
2530 It's not needed and the C Standard doesn't allow it here anyway.
2531
c378da0b
PE
2532 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2533 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2534
288b08c7
PE
2535 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2536 bytes.
2537
e3601888
PE
2538 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2539
db6c0e74
PE
2540 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2541
dd5963ea
PE
2542 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2543
88c9450f
PE
2544 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2545
2f9442b8
PE
2546 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2547
c032b5f8
PE
2548 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2549 * charset.c (Fdefine_charset_internal): Don't initialize
2550 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2551 32-bit int (Bug#8600).
a108c10b
PE
2552
2553 * lread.c (read_integer): Be more consistent with string-to-number.
2554 Use string_to_number to do the actual conversion; this avoids
2555 rounding errors and fixes some other screwups. Without this fix,
2556 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2557 (digit_to_number): Move earlier, for benefit of read_integer.
2558 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2559 not a digit in any supported base. (Bug#8602)
a108c10b 2560
ad5f9eea
PE
2561 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2562
aec1708a
PE
2563 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2564 to match comment at start of function. This also removes a
2565 GCC warning about overflow in a 32+64-bit port.
2566
47be4ab5
PE
2567 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2568
371cac43
PE
2569 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2570 Reported by Stefan Monnier in
2571 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2572 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2573 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2574
d01a7826
PE
2575 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2576 (EMACS_UINTPTR): Likewise, with uintptr_t.
2577
7fd47d5c
PE
2578 * lisp.h: Prefer 64-bit EMACS_INT if available.
2579 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2580 on 32-bit hosts that have 64-bit int, so that they can access
2581 large files.
122b0c86
PE
2582 However, temporarily disable this change unless the temporary
2583 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2584
8727937b
PE
2585 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2586
8ac068ac
PE
2587 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2588 This removes an assumption that EMACS_INT and long are the same
2589 width as pointers. The assumption is true for Emacs porting targets
2590 now, but we want to make other targets possible.
2591 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2592 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2593 In the rest of the code, change types of integers that hold casted
2594 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2595 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2596 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2597 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2598 No need to cast type when ORing.
2599 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2600 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2601 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2602 assume EMACS_INT is the same width as char *.
2603 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2604 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2605 Remove no-longer-needed casts.
2606 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2607 (xg_tool_bar_help_callback, xg_make_tool_item):
2608 Use EMACS_INTPTR to hold an integer
2609 that will be cast to void *; this can avoid a GCC warning
2610 if EMACS_INT is not the same width as void *.
2611 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2612 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2613 (current_message_1, set_message_1):
2614 Use a local to convert to proper width without a cast.
2615 * xmenu.c (dialog_selection_callback): Likewise.
2616
ede49d71
PE
2617 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2618 Also, don't assume VALBITS / RAND_BITS is less than 5,
2619 and don't rely on undefined behavior when shifting a 1 left into
2620 the sign bit.
2621 * lisp.h (get_random): Change signature to match.
2622
2f30ecd0
PE
2623 * lread.c (hash_string): Use size_t, not int, for hash computation.
2624 Normally we prefer signed values; but hashing is special, because
2625 it's better to use unsigned division on hash table sizes so that
2626 the remainder is nonnegative. Also, size_t is the natural width
2627 for hashing into memory. The previous code used 'int', which doesn't
2628 retain enough info to hash well into very large tables.
2629 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2630
2a866e7b
PE
2631 * dbusbind.c: Don't possibly lose pointer info when converting.
2632 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2633 Use XPNTR rather than XHASH, so that the high-order bits of
2634 the pointer aren't lost when converting through void *.
2635
51639eac
PE
2636 * eval.c (Fautoload): Don't double-shift a pointer.
2637
92394119
PE
2638 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2639
dbdb9a7c
JB
26402011-05-06 Juanma Barranquero <lekktu@gmail.com>
2641
2642 * gnutls.c (DEF_GNUTLS_FN):
2643 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2644
db7a0b4f
AS
26452011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2646
2647 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2648 marker. (Bug#8610)
2649
f7ff1b0f 26502011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2651
2652 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2653 New version that can reserve upto 2GB of heap space.
2654
f7ff1b0f 26552011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2656
2657 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2658
639c109b
TZ
26592011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2660
2661 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2662 `gnutls_certificate_set_x509_key_file'.
2663
d2127135
JB
26642011-05-05 Juanma Barranquero <lekktu@gmail.com>
2665
2666 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2667 Update dependencies.
2668
e968f4f3
JB
26692011-05-04 Juanma Barranquero <lekktu@gmail.com>
2670
2671 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2672 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2673 Remove unused parameter `fildes'.
2674 * process.c (read_process_output, send_process): Don't pass it.
2675
84d358f0
JB
26762011-05-04 Juanma Barranquero <lekktu@gmail.com>
2677
2678 Fix previous change: the library cache is defined in w32.c.
2679 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2680 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2681
0898ca10
JB
26822011-05-04 Juanma Barranquero <lekktu@gmail.com>
2683
2684 Implement dynamic loading of GnuTLS on Windows.
2685
2686 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2687 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2688 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2689 Declare.
2690
2691 * gnutls.c (Qgnutls_dll): Define.
2692 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2693 (gnutls_*): Declare function pointers.
2694 (init_gnutls_functions): New function to initialize function pointers.
2695 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2696 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2697 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2698 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2699 (emacs_gnutls_write, emacs_gnutls_read)
2700 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2701 (Fgnutls_available_p): New function.
2702 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2703 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2704 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2705
2706 * image.c: Include w32.h.
2707 (Vimage_type_cache): Delete.
2708 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2709 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2710 (w32_delayed_load): Move to w32.c.
2711
2712 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2713
2714 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2715 (w32_delayed_load): Move from image.c. When loading a library, record
2716 its filename in the :loaded-from property of the library id.
2717 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2718 Initialize and staticpro them.
2719 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2720
2721 * process.c: Include lisp.h before w32.h, not after.
2722 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2723 instead of gnutls_record_check_pending.
2724
2725 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2726
ff4de4aa
TZ
27272011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2728
2729 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2730 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2731 as passed in.
2732
abe95abb
JD
27332011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2734
2735 * xterm.c (x_set_frame_alpha): Do not set property on anything
2736 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2737
e16e55d4
JB
27382011-05-02 Juanma Barranquero <lekktu@gmail.com>
2739
2740 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2741
bafcf6a5
JB
27422011-05-02 Juanma Barranquero <lekktu@gmail.com>
2743
2744 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2745 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2746 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2747 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2748 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2749 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2750 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2751 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2752 (Qgnutls_bootprop_callbacks_verify): Make static.
2753
e7a6747f
AS
27542011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2755
19ed11ba
AS
2756 * callproc.c: Indentation fixup.
2757
e7a6747f 2758 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2759 (wait_for_termination, interruptible_wait_for_termination):
2760 Move after wait_for_termination_1.
e7a6747f 2761
1ef14cb4
LMI
27622011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2763
2764 * sysdep.c (interruptible_wait_for_termination): New function
2765 which is like wait_for_termination, but allows keyboard
2766 interruptions.
2767
2768 * callproc.c (Fcall_process): Add (:file "file") as an option for
2769 the STDOUT buffer.
2770 (Fcall_process_region): Ditto.
2771
330d880c
EZ
27722011-04-30 Eli Zaretskii <eliz@gnu.org>
2773
8db90b73
EZ
2774 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2775 rather than `XVECTOR (FOO)->size'.
2776
330d880c
EZ
2777 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2778 inttypes.h, as a gnulib replacement is used if it not available in
2779 system headers.
2780
15cbd324
EZ
27812011-04-21 Eli Zaretskii <eliz@gnu.org>
2782
2783 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2784 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2785 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2786
2787 * coding.c (coding_alloc_by_realloc): Error out if destination
2788 will grow beyond MOST_POSITIVE_FIXNUM.
2789 (decode_coding_emacs_mule): Abort if there isn't enough place in
2790 charbuf for the composition carryover bytes. Reserve an extra
2791 space for up to 2 characters produced in a loop.
2792 (decode_coding_iso_2022): Abort if there isn't enough place in
2793 charbuf for the composition carryover bytes.
2794
27952011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2796
ae940cca
EZ
2797 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2798 aborting when %lld or %lll format is passed.
2799 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2800 %llo or %llx format is passed. (Bug#8545)
2801
03ab8921
EZ
2802 * window.c (window_scroll_line_based): Use a marker instead of
2803 simple variables to record original value of point. (Bug#7952)
2804
afda1437
EZ
2805 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2806 produced by %s or %c overflows available buffer space. (Bug#8545)
2807
f76dee0c
PE
28082011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2811 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2812
fdc5744d
JB
28132011-04-28 Juanma Barranquero <lekktu@gmail.com>
2814
2815 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2816
638f053a
JB
28172011-04-28 Juanma Barranquero <lekktu@gmail.com>
2818
2819 * keyboard.c (Qdelayed_warnings_hook): Define.
2820 (command_loop_1): Run `delayed-warnings-hook'
2821 if Vdelayed_warnings_list is non-nil.
2822 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2823 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2824
d178f871
EZ
28252011-04-28 Eli Zaretskii <eliz@gnu.org>
2826
2827 * doprnt.c (doprnt): Don't return value smaller than the buffer
2828 size if the message was truncated. (Bug#8545).
2829
b124fd93
JB
28302011-04-28 Juanma Barranquero <lekktu@gmail.com>
2831
2832 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2833 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2834
e810457d
PE
28352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2838
ea51cceb
JB
28392011-04-27 Juanma Barranquero <lekktu@gmail.com>
2840
2841 * makefile.w32-in: Update dependencies.
2842
94dcfacf
EZ
28432011-04-27 Eli Zaretskii <eliz@gnu.org>
2844
2845 Improve `doprnt' and its usage. (Bug#8545)
2846 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2847 `format_end'. Remove support for %l as a conversion specifier.
2848 Don't use xrealloc. Improve diagnostics when the %l size modifier
2849 is used. Update the commentary.
2850
2851 * eval.c (verror): Simplify calculation of size_t.
2852
2853 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2854 messages.
2855
f61f41d7
PE
28562011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2857
2858 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2859 change.
2860
96fb4434
PE
28612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2862
2863 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2864 This makes this file independent of the recent pseudovector change.
2865
671875da 28662011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2867
69e9b5a3
PE
2868 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2869
b5f869a7 2870 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2871 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2872 Remove unused local.
c8926152 2873 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2874
841a1577 2875 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2876 GCC 4.6.0 optimizes based on type-based alias analysis.
2877 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2878 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2879 != &v->size, and therefore "v->size = 1; b->size = 2; return
2880 v->size;" must therefore return 1. This assumption is incorrect
2881 for Emacs, since it type-puns struct Lisp_Vector * with many other
2882 types. To fix this problem, this patch adds a new type struct
f904488f 2883 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2884 and pseudovectors, and helps optimizing compilers not get fooled
2885 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2886 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2887 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2888 the size member.
eab3844f
PE
2889 (XSETPVECTYPE): Rewrite in terms of new macro.
2890 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2891 This is a bit clearer, and further avoids the possibility of
2892 undesirable aliasing.
2893 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2894 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2895 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2896 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2897 (ASIZE): Now uses header.size rather than size.
2898 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2899 to avoid the hassle of writing XVECTOR (foo)->header.size.
2900 (struct vectorlike_header): New type.
eab3844f
PE
2901 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2902 object, to help avoid aliasing.
2903 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2904 (SUBRP): Likewise, since Lisp_Subr is a special case.
2905 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2906 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2907 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2908 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2909 changed to be "header.size" and "header.next".
2910 * buffer.h (struct buffer): Likewise.
2911 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2912 * frame.h (struct frame): Likewise.
2913 * process.h (struct Lisp_Process): Likewise.
2914 * termhooks.h (struct terminal): Likewise.
2915 * window.c (struct save_window_data, struct saved_window): Likewise.
2916 * window.h (struct window): Likewise.
2917 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2918 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2919 * buffer.c (init_buffer_once): Likewise.
2920 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2921 special case.
2922 * process.c (Fformat_network_address): Use local var for size,
2923 for brevity.
2924
0df1eac5
PE
2925 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2926
847ab9d1 2927 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2928 * data.c (atof): Remove decl; no longer used or needed.
2929 (digit_to_number): Move to lread.c.
2930 (Fstring_to_number): Use new string_to_number function, to be
2931 consistent with how the Lisp reader treats infinities and NaNs.
2932 Do not assume that floating-point numbers represent EMACS_INT
2933 without losing information; this is not true on most 64-bit hosts.
2934 Avoid double-rounding errors, by insisting on integers when
2935 parsing non-base-10 numbers, as the documentation specifies.
2936 * lisp.h (string_to_number): New decl, replacing ...
2937 (isfloat_string): Remove.
bc0a5c13 2938 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2939 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2940 appears to have been a coding error. Similarly, do not accept
2941 strings like +-1e0 as floating point numbers. Do not report
2942 overflow for integer overflows unless the base is not 10 which
2943 means we have no simple and reliable way to continue.
2944 Break out the floating-point parsing into a new
2945 function string_to_number, so that Fstring_to_number parses
2946 floating point numbers consistently with the Lisp reader.
04f2d78b 2947 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2948 (E_CHAR, EXP_INT): Remove, replacing with ...
2949 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2950 (string_to_number): New function, replacing isfloat_string.
2951 This function checks for valid syntax and produces the resulting
2952 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2953 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2954 so that overflow for non-base-10 numbers is reported only when
2955 there's no portable and simple way to convert to floating point.
452f4150 2956
67769ffc
PE
2957 * textprop.c (set_text_properties_1): Rewrite for clarity,
2958 and to avoid GCC warning about integer overflow.
2959
c20db43f
PE
2960 * intervals.h (struct interval): Use EMACS_INT for members
2961 where EMACS_UINT might cause problems. See
2962 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2963 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2964 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2965 All uses changed.
37aa2f85
PE
2966 (offset_intervals): Tell GCC not to worry about length overflow
2967 when negating a negative length.
c20db43f 2968
2538aa2f
PE
2969 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2970 (overrun_check_free): Likewise.
2971
f2d3008d
PE
2972 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2973 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2974 word size.
2975
ec8df744
PE
2976 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2977 (gnutls_make_error): Rename local to avoid shadowing.
2978 (gnutls_emacs_global_deinit): ifdef out; not used.
2979 (Fgnutls_boot): Use const for pointer to readonly storage.
2980 Comment out unused local. Fix pointer signedness problems.
2981
640ee02d
PE
2982 * lread.c (openp): Don't stuff size_t into an 'int'.
2983 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2984 about possible signed overflow.
2985
6048fb2a
PE
2986 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2987 (GDK_KEY_g): Don't define if already defined.
2988 (xg_prepare_tooltip): Avoid pointer signedness problem.
2989 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2990
fa3c87e1
PE
2991 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2992 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2993
2172544b
PE
2994 * xfns.c (Fx_window_property): Simplify a bit,
2995 to make a bit faster and to avoid GCC 4.6.0 warning.
2996 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2997
9b821a21
PE
2998 * fns.c (internal_equal): Don't assume size_t fits in int.
2999
3c616cfa
PE
3000 * alloc.c (compact_small_strings): Tighten assertion a little.
3001
c2982e87
PE
3002 Replace pEd with more-general pI, and fix some printf arg casts.
3003 * lisp.h (pI): New macro, generalizing old pEd macro to other
3004 conversion specifiers. For example, use "...%"pI"d..." rather
3005 than "...%"pEd"...".
3006 (pEd): Remove. All uses replaced with similar uses of pI.
3007 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3008 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3009 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3010 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3011 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3012 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3013 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3014 64-bit hosts.
3015 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3016 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3017 * print.c (safe_debug_print, print_object): Likewise.
3018 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3019 to int.
6f04d126
PE
3020 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3021 avoiding the 0 flag, which is not portable.
c2982e87
PE
3022 * process.c (Fmake_network_process): Use pI to avoid cast.
3023 * region-cache.c (pp_cache): Likewise.
3024 * xdisp.c (decode_mode_spec): Likewise.
3025 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3026 behavior on 64-bit hosts with printf arg.
6f04d126 3027 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3028 (x_stop_queuing_selection_requests): Likewise.
3029 (x_get_window_property): Don't truncate byte count to an 'int'
3030 when tracing.
0b432f21 3031
5e073ec7
PE
3032 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3033 here, since it parses constructs like leading '-' and spaces,
3034 which are not wanted; and it overflows with large numbers.
3035 Instead, simply match F[0-9]+, which is what is wanted anyway.
3036
36372bf9
PE
3037 * alloc.c: Remove unportable assumptions about struct layout.
3038 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3039 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3040 (allocate_vectorlike, make_pure_vector): Use the new macros,
3041 plus offsetof, to remove unportable assumptions about struct layout.
3042 These assumptions hold on all porting targets that I know of, but
3043 they are not guaranteed, they're easy to remove, and removing them
3044 makes further changes easier.
3045
0b432f21
PE
3046 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3047 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3048 (string_overrun_cookie): Now const. Use initializers that
3049 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3050 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3051 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3052 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3053 multiple of sizeof (EMACS_INT); it need not be, if
3054 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3055 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3056
895009e1
JB
30572011-04-26 Juanma Barranquero <lekktu@gmail.com>
3058
3059 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3060
6a7a1b0b
TZ
30612011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3062
3063 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3064 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3065 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3066
841a1577 30672011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3068
3069 * lisp.h (Qdebug): List symbol.
895009e1 3070 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3071 * keyboard.c (debug-on-event): New variable.
3072 (handle_user_signal): Break into debugger when debug-on-event
3073 matches the current signal symbol.
3074
f2d3ba6f
DN
30752011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3076
3077 * alloc.c (check_sblock, check_string_bytes)
3078 (check_string_free_list): Convert to standard C.
3079
42ce4c63
TZ
30802011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3081
3082 * w32.c (emacs_gnutls_push): Fix typo.
3083
825cd63c
EZ
30842011-04-25 Eli Zaretskii <eliz@gnu.org>
3085
fb11d64d
EZ
3086 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3087 "cast to pointer from integer of different size".
3088
825cd63c
EZ
3089 Improve doprnt and its use in verror. (Bug#8545)
3090 * doprnt.c (doprnt): Document the set of format control sequences
3091 supported by the function. Use SAFE_ALLOCA instead of always
3092 using `alloca'.
3093
3094 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3095 is one byte too soon. Don't use xrealloc; instead xfree and
3096 xmalloc anew.
3097
e061a11b
TZ
30982011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3099
3100 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3101 callbacks stage.
3102
3103 * gnutls.c: Renamed global_initialized to
3104 gnutls_global_initialized. Added internals for the
3105 :verify-hostname-error, :verify-error, and :verify-flags
3106 parameters of `gnutls-boot' and documented those parameters in the
3107 docstring. Start callback support.
9173deec
JB
3108 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3109 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3110 on error. Return error code.
e061a11b
TZ
3111 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3112 (emacs_gnutls_read): Likewise.
3113 (Fgnutls_boot): Return handshake error code.
3114 (emacs_gnutls_handle_error): New function.
3115 (wsaerror_to_errno): Likewise.
3116
3117 * w32.h (emacs_gnutls_pull): Add prototype.
3118 (emacs_gnutls_push): Likewise.
3119
3120 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3121 (emacs_gnutls_push): Likewise.
3122
31232011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3124
3125 * process.c (wait_reading_process_output): Check if GnuTLS
3126 buffered some data internally if no FDs are set for TLS
3127 connections.
3128
3129 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3130 (LIBS): Link to USER_LIBS.
3131 ($(BLD)/gnutls.$(0)): New target.
3132
fa6996bc
EZ
31332011-04-24 Eli Zaretskii <eliz@gnu.org>
3134
eb35682e
EZ
3135 * xdisp.c (handle_single_display_spec): Rename the
3136 display_replaced_before_p argument into display_replaced_p, to
3137 make it consistent with the commentary. Fix typos in the
3138 commentary.
3139
e2ad650c
EZ
3140 * textprop.c (syms_of_textprop): Remove dead code.
3141 (copy_text_properties): Delete obsolete commentary about an
3142 interface that was deleted long ago. Fix typos in the description
3143 of arguments.
3144
1b2de274
EZ
3145 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3146 to changes in oldXMenu/XMenu.h from 2011-04-16.
3147 <menu_help_message, prev_menu_help_message>: Constify.
3148 (IT_menu_make_room): menu->help_text is now `const char **';
3149 adjust.
3150
3151 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3152 to changes in oldXMenu/XMenu.h from 2011-04-16.
3153 (struct XMenu): Declare `help_text' `const char **'.
3154
3155 * xfaces.c <Qunspecified>: Make extern again.
3156
3157 * syntax.c: Include sys/types.h before including regex.h, as
3158 required by Posix.
3159
762b15be
EZ
3160 * doc.c (get_doc_string): Improve the format passed to `error'.
3161
3162 * doprnt.c (doprnt): Improve commentary.
3163
3164 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3165
3166 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3167 them with etags.
3168
f1052e5d
EZ
3169 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3170 changes in globals.h immediately force recompilation.
762b15be
EZ
3171 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3172 $(CURDIR)/s/ms-w32.h.
3173 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3174
fa6996bc
EZ
3175 * character.c (Fchar_direction): Function deleted.
3176 (syms_of_character): Don't defsubr it.
3177 <char-direction-table>: Deleted.
3178
e6c3da20
EZ
31792011-04-23 Eli Zaretskii <eliz@gnu.org>
3180
3181 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3182 * doprnt.c: Include limits.h.
3183 (SIZE_MAX): New macro.
04f2d78b
CB
3184 (doprnt): Return a size_t value. 2nd arg is now size_t.
3185 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3186 Improve overflow protection. Support `l' modifier for integer
3187 conversions. Support %l conversion. Don't assume an EMACS_INT
3188 argument for integer conversions and for %c.
3189
3190 * lisp.h (doprnt): Restore prototype.
3191
3192 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3193 $(SRC)/character.h.
3194
3195 * Makefile.in (base_obj): Add back doprnt.o.
3196
3197 * deps.mk (doprnt.o): Add back prerequisites.
3198 (callint.o): Depend on character.h.
3199
3200 * eval.c (internal_lisp_condition_case): Include the handler
3201 representation in the error message.
3202 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3203 when breaking from the loop.
3204
3205 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3206
3207 * callint.c (Fcall_interactively): When displaying error message
3208 about invalid control letter, pass the character's codepoint, not
3209 a pointer to its multibyte form. Improve display of the character
3210 in octal and display also its hex code.
3211
3212 * character.c (char_string): Use %x to display the (unsigned)
3213 codepoint of an invalid character, to avoid displaying a bogus
3214 negative value.
3215
3216 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3217 `error', not SYMBOL_NAME itself.
3218
3219 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3220 character arguments to `error'.
3221
3222 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3223 to `error' in error message about FINAL_CHAR argument. Make sure
3224 FINAL_CHAR is a character, and use %c when it is passed as
3225 argument to `error'.
3226
4ffd0d6b 32272011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3228
3229 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3230
3231 * w32.c: Include <time.h>.
3232 (sys_localtime): New function.
3233
4ffd0d6b 32342011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3235
3236 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3237
4ffd0d6b 3238 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3239
4ffd0d6b 32402011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3241
4ffd0d6b
GM
3242 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3243 zombies (Bug#8467).
aac0c6e3 3244
04c56954
EZ
32452011-04-19 Eli Zaretskii <eliz@gnu.org>
3246
3247 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3248 gl_state.e_property when gl_state.object is Qt.
3249
3250 * insdel.c (make_gap_larger): Remove limitation of buffer size
3251 to <= INT_MAX.
3252
16a43933
CY
32532011-04-18 Chong Yidong <cyd@stupidchicken.com>
3254
3255 * xdisp.c (lookup_glyphless_char_display)
3256 (produce_glyphless_glyph): Handle cons cell entry in
3257 glyphless-char-display.
3258 (Vglyphless_char_display): Document it.
3259
3260 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3261 glyphless-char-display.
3262
4581706e
CY
32632011-04-17 Chong Yidong <cyd@stupidchicken.com>
3264
3265 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3266
3267 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3268
3269 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3270 definition for no-X builds.
3271
4887c6e2 32722011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3273
fd35b6f9
PE
3274 Static checks with GCC 4.6.0 and non-default toolkits.
3275
5c1ccb01
PE
3276 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3277
006c5daa
PE
3278 * process.c (keyboard_bit_set): Define only if SIGIO.
3279 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3280 (send_process): Repair possible setjmp clobbering.
3281
efc736d3
PE
3282 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3283
4e2fe2e6
PE
3284 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3285
f97334a2
PE
3286 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3287
4e75f29d
PE
3288 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3289 Define only if needed.
3290
90efadd1
PE
3291 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3292 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3293 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3294
3c647824
PE
3295 * dispextern.h (struct redisplay_interface): Rename param
3296 to avoid shadowing.
e264f262 3297 * termhooks.h (struct terminal): Likewise.
761383f4 3298 * xterm.c (xembed_send_message): Likewise.
3c647824 3299
b58c5c4a
PE
3300 * insdel.c (make_gap_smaller): Define only if
3301 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3302
cad59032
PE
3303 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3304 it.
3305
c339dc2e
PE
3306 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3307 so that we aren't warned about unused symbols.
3308
91a3e27b
PE
3309 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3310
399c71d3 3311 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3312
8ffc96f5
PE
3313 * xfns.c (x_real_positions): Mark locals as initialized.
3314
eef9bc79
PE
3315 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3316
098db9dd
PE
3317 * xterm.c: Fix problems found by static analysis with other toolkits.
3318 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3319 (x_dispatch_event): Declare static if USE_GTK, and
3320 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3321 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3322 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3323 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3324 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3325
eb18f6cc
PE
3326 * xmenu.c (menu_help_callback): Pointer type fixes.
3327 Use const pointers when pointing at readonly data. Avoid pointer
3328 signedness clashes.
3329 (FALSE): Remove unused macro.
3330 (update_frame_menubar): Remove unused decl.
3331
1fe72bf8
PE
3332 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3333
60d9e1db
PE
3334 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3335 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3336 (single_menu_item): Rename local to avoid shadowing.
3337
39261c26
PE
3338 * keyboard.c (make_lispy_event): Remove unused local var.
3339
018c5e19
PE
3340 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3341 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3342
63d2b86e
PE
3343 * bitmaps: Change bitmaps from unsigned char back to the X11
3344 compatible char. Avoid the old compiler warnings about
3345 out-of-range initializers by using, for example, '\xab' rather
3346 than 0xab.
3347
aefd87e1
PE
3348 * xgselect.c (xgselect_initialize): Check vs interface
3349 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3350
bf501fb9
PE
3351 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3352
e9829fdf
PE
3353 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3354 to read-only memory.
3355
1086c095
PE
3356 * fns.c (vector): Remove; this old hack is no longer needed.
3357
2baccd04 3358 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3359 Remove unused var.
dde42981 3360 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3361
72391843 3362 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3363
436c16df 3364 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3365 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3366 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3367
92bb796d 3368 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3369 (x_term_init): Remove local to avoid shadowing.
92bb796d 3370
764430a3 3371 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3372
3373 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3374 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3375
d1dfb56c
EZ
33762011-04-16 Eli Zaretskii <eliz@gnu.org>
3377
c4354cb4
EZ
3378 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3379
d1dfb56c
EZ
3380 Fix regex.c, syntax.c and friends for buffers > 2GB.
3381 * syntax.h (struct gl_state_s): Declare character position members
3382 EMACS_INT.
3383
3384 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3385
04f2d78b
CB
3386 * textprop.c (verify_interval_modification, interval_of):
3387 Declare arguments EMACS_INT.
d1dfb56c
EZ
3388
3389 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3390 EMACS_INT.
3391
3392 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3393
3394 * indent.c (Fvertical_motion): Local variable it_start is now
3395 EMACS_INT.
3396
3397 * regex.c (re_match, re_match_2, re_match_2_internal)
3398 (bcmp_translate, regcomp, regexec, print_double_string)
3399 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3400 (re_compile_pattern, re_exec): Declare arguments and local
3401 variables `size_t' and `ssize_t' and return values `regoff_t', as
3402 appropriate.
3403 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3404 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3405 <compile_stack_type>: `size' and `avail' are now `size_t'.
3406
3407 * regex.h <regoff_t>: Use ssize_t, not int.
3408 (re_search, re_search_2, re_match, re_match_2): Arguments that
3409 specify buffer/string position and length are now ssize_t and
3410 size_t. Return type is regoff_t.
3411
613052cd
BK
34122011-04-16 Ben Key <bkey76@gmail.com>
3413
3414 * nsfont.m: Fixed bugs in ns_get_family and
3415 ns_descriptor_to_entity that were caused by using free to
3416 deallocate memory blocks that were allocated by xmalloc (via
3417 xstrdup). This caused Emacs to crash when compiled with
3418 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3419 --enable-checking=xmallocoverrun). xfree is now used to
3420 deallocate these memory blocks.
3421
4170f62f 34222011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3423
71b41406
PE
3424 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3425
9587a89d
PE
3426 emacs_write: Accept and return EMACS_INT for sizes.
3427 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3428 et seq.
3429 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3430 Accept and return EMACS_INT.
3431 (emacs_gnutls_write): Return the number of bytes written on
3432 partial writes.
3433 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3434 (emacs_read, emacs_write): Remove check for negative size, as the
3435 Emacs source code has been audited now.
9587a89d
PE
3436 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3437 (emacs_read, emacs_write): Use it.
273a5f82
PE
3438 * process.c (send_process): Adjust to the new signatures of
3439 emacs_write and emacs_gnutls_write. Do not attempt to store
3440 a byte offset into an 'int'; it might overflow.
9587a89d 3441 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3442
3e047f51
PE
3443 * sound.c: Don't assume sizes fit in 'int'.
3444 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3445 Return EMACS_INT, not int.
3e047f51 3446 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3447 Accept EMACS_INT, not int.
3448 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3449 record read return values.
3450
cc39a9db
BK
34512011-04-15 Ben Key <bkey76@gmail.com>
3452
c9d0ec6d
JB
3453 * keyboard.c (Qundefined): Don't declare static since it is used
3454 in nsfns.m.
3455 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3456 static since they are used in nsfont.m.
cc39a9db 3457
6c60eb9f
SM
34582011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3459
3460 * process.c (Qprocessp): Don't declare static.
3461 * lisp.h (Qprocessp): Declare again.
3462
7990b61a
JB
34632011-04-15 Juanma Barranquero <lekktu@gmail.com>
3464
3465 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3466
5d4cb038
PE
34672011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3468
8bd7b830 3469 Improve C-level modularity by making more things 'static'.
cd64ea1d 3470
e3b27b31
PE
3471 Don't publish debugger-only interfaces to other modules.
3472 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3473 (verify_bytepos, count_markers): Move decls to the only modules
3474 that need them.
3475 * region-cache.h (pp_cache): Likewise.
3476 * window.h (check_all_windows): Likewise.
3477 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3478
5d4cb038
PE
3479 * sysdep.c (croak): Now static, if
3480 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3481 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3482
3483 * alloc.c (refill_memory_reserve): Now static if
3484 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3485 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3486
e87b6180
PE
3487 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3488 Define only if USE_LUCID.
3489
ac64929e
PE
3490 * xrdb.c (x_customization_string, x_rm_string): Now static.
3491
6f37259d
PE
3492 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3493 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3494
1683e3ab
PE
3495 * xdisp.c (draw_row_with_mouse_face): Now static.
3496 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3497
de9c2632
PE
3498 * window.h (check_all_windows): Mark externally visible.
3499
2b96acb7
PE
3500 * window.c (window_deletion_count): Now static.
3501
3502 * undo.c: Make symbols static if they're not exported.
3503 (last_undo_buffer, last_boundary_position, pending_boundary):
3504 Now static.
3505
50436f33
PE
3506 * textprop.c (interval_insert_behind_hooks): Now static.
3507 (interval_insert_in_front_hooks): Likewise.
3508
64520e5c
PE
3509 * term.c: Make symbols static if they're not exported.
3510 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3511 (max_frame_lines, tty_set_terminal_modes):
3512 (tty_reset_terminal_modes, tty_turn_off_highlight):
3513 (get_tty_terminal): Now static.
3514 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3515 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3516 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3517 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3518 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3519
1fa53021
PE
3520 * sysdep.c: Make symbols static if they're not exported.
3521 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3522 Now static.
3523 (sigprocmask_set, full_mask): Remove; unused.
3524 (wait_debugging): Mark as visible.
3525 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3526 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3527
d4b43b22
PE
3528 * syntax.c (syntax_temp): Define only if !__GNUC__.
3529
b7c513d0
PE
3530 * sound.c (current_sound_device, current_sound): Now static.
3531
989b29ad
PE
3532 * search.c (searchbufs, searchbuf_head): Now static.
3533
13a55a78
PE
3534 * scroll.c (scroll_cost): Remove; unused.
3535 * dispextern.h (scroll_cost): Remove decl.
3536
de68a1fc
PE
3537 * region-cache.h (pp_cache): Mark as externally visible.
3538
40ccffa6
PE
3539 * process.c: Make symbols static if they're not exported.
3540 (process_tick, update_tick, create_process, chan_process):
3541 (Vprocess_alist, proc_buffered_char, datagram_access):
3542 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3543 (deactivate_process): Mark defn as static, as well as decl.
3544 * lisp.h (create_process): Remove decl.
3545 * process.h (chan_process, Vprocess_alist): Remove decls.
3546
ad64fc97
PE
3547 * print.c: Make symbols static if they're not exported.
3548 (print_depth, new_backquote_output, being_printed, print_buffer):
3549 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3550 (print_interval, print_number_index, initial_stderr_stream):
3551 Now static.
3552 * lisp.h (Fprinc): Remove decl.
3553 (debug_output_compilation_hack): Mark as externally visible.
3554
adddb265
PE
3555 * sysdep.c (croak): Move decl from here to syssignal.h.
3556 * syssignal.h (croak): Put it here, so the API can be checked when
3557 'croak' is called from dissociate_if_controlling_tty.
3558
1717ede2
PE
3559 * minibuf.c: Make symbols static if they're not exported.
3560 (minibuf_save_list, choose_minibuf_frame): Now static.
3561 * lisp.h (choose_minibuf_frame): Remove decl.
3562
fa5fb2bc
PE
3563 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3564
1e3890d1
PE
3565 * lread.c: Make symbols static if they're not exported.
3566 (read_objects, initial_obarray, oblookup_last_bucket_number):
3567 Now static.
3568 (make_symbol): Remove; unused.
3569 * lisp.h (initial_obarray, make_symbol): Remove decls.
3570
8a1414fa
PE
3571 * keyboard.c: Make symbols static if they're not exported.
3572 (single_kboard, recent_keys_index, total_keys, recent_keys):
3573 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3574 (this_single_command_key_start, echoing, last_auto_save):
3575 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3576 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3577 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3578 (Vlispy_mouse_stem, double_click_count):
3579 Now static.
3580 (force_auto_save_soon): Define only if SIGDANGER.
3581 (ignore_mouse_drag_p): Now static if
3582 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3583 (print_help): Remove; unused.
3584 (stop_character, last_timer_event): Mark as externally visible.
3585 * keyboard.h (ignore_mouse_drag_p): Declare only if
3586 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3587 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3588 * lisp.h (echoing): Remove decl.
3589 (force_auto_save_soon): Declare only if SIGDANGER.
3590 * xdisp.c (redisplay_window): Simplify code, to make it more
3591 obvious that ignore_mouse_drag_p is not accessed if !defined
3592 USE_GTK && !defined HAVE_NS.
3593
93ea6e8f
PE
3594 * intervals.c: Make symbols static if they're not exported.
3595 (merge_properties_sticky, merge_interval_right, delete_interval):
3596 Now static.
3597 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3598
77382fcc
PE
3599 * insdel.c: Make symbols static if they're not exported.
3600 However, leave prepare_to_modify_buffer alone. It's never
3601 called from outside this function, but that appears to be a bug.
3602 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3603 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3604 (adjust_after_replace_noundo): Remove; unused.
3605 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3606 (signal_before_change): Remove decls.
77382fcc 3607
9306c32e
PE
3608 * indent.c (val_compute_motion, val_vmotion): Now static.
3609
cd44d2eb
PE
3610 * image.c: Make symbols static if they're not exported.
3611 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3612 if USE_GTK.
3613 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3614 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3615
ad9a7a06
PE
3616 * fringe.c (standard_bitmaps): Now static.
3617 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3618
81626931
PE
3619 * frame.c: Make symbols static if they're not exported.
3620 (x_report_frame_params, make_terminal_frame): Now static.
3621 (get_frame_param): Now static, unless HAVE_NS.
3622 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3623 (x_get_resource_string): Remove; not used.
3624 * frame.h (make_terminal_frame, x_report_frame_params):
3625 (x_get_resource_string); Remove decls.
3626 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3627 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3628
239f9db9
PE
3629 * font.c, fontset.c: Make symbols static if they're not exported.
3630 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3631 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3632 * font.c (font_close_object): Now static.
3633 * font.h (font_close_object): Remove.
3634 * fontset.c (FONTSET_OBJLIST): Remove.
3635 (free_realized_fontset) #if-0 the body, which does nothing.
3636 (face_suitable_for_char_p): #if-0, as it's never called.
3637 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3638 * xfaces.c (face_at_string_position):
3639 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3640 since 0 is always ASCII.
3641
dfcf3579
PE
3642 * fns.c (weak_hash_tables): Now static.
3643
5045092b
PE
3644 * fileio.c: Make symbols static if they're not exported.
3645 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3646 (Vwrite_region_annotation_buffers): Now static.
3647
57a96f5c
PE
3648 * eval.c: Make symbols static if they're not exported.
3649 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3650 * lisp.h (backtrace_list): Remove decl.
3651
35f08c38
PE
3652 * emacs.c: Make symbols static if they're not exported.
3653 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3654 (fatal_error_code, fatal_error_signal_hook, standard_args):
3655 Now static.
3656 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3657 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3658 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3659 * lisp.h (fatal_error_signal_hook): Remove decl.
3660 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3661
f44bd759
PE
3662 * editfns.c: Move a (normally-unused) function to its only use.
3663 * editfns.c, lisp.h (get_operating_system_release): Remove.
3664 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3665 worth the hassle of breaking this out.
3666
b532497d
PE
3667 * xterm.c: Make symbols static if they're not exported.
3668 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3669 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3670 (x_destroy_window, x_delete_display):
3671 Now static.
3672 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3673 (x_mouse_leave): Remove; unused.
3674 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3675 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3676 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3677 Remove decls.
3678 (x_mouse_leave): Declare only if WINDOWSNT.
3679 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3680 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3681 USE_X_TOOLKIT.
3682
1675728f
PE
3683 * ftxfont.c: Make symbols static if they're not exported.
3684 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3685 HAVE_FREETYPE.
3686 * font.h (ftxfont_driver): Likewise.
3687
e4cebfca
PE
3688 * xfns.c: Make symbols static if they're not exported.
3689 (x_last_font_name, x_display_info_for_name):
3690 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3691 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3692 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3693 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3694 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3695 (last_show_tip_args): Now static.
3696 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3697 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3698 (x_screen_planes): Remove; unused.
3699 * dispextern.h (x_screen_planes): Remove decl.
3700
5bf46f05
PE
3701 * dispnew.c: Make symbols static if they're not exported.
3702 * dispextern.h (redraw_garbaged_frames, scrolling):
3703 (increment_row_positions): Remove.
3704 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3705 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3706 Now static.
3707 (redraw_garbaged_frames): Remove; unused.
3708
435f4c28
PE
3709 * xfaces.c: Make symbols static if they're not exported.
3710 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3711 Remove decls.
3712 * xterm.h (defined_color): Remove decls.
3713 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3714 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3715 (menu_face_changed_default, defined_color, free_realized_face):
3716 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3717 (ascii_face_of_lisp_face): Remove; unused.
3718
8524aef3
PE
3719 * xdisp.c: Make symbols static if they're not exported.
3720 * dispextern.h (scratch_glyph_row, window_box_edges):
3721 (glyph_to_pixel_coords, set_cursor_from_row):
3722 (get_next_display_element, set_iterator_to_next):
3723 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3724 (show_mouse_face): Remove decls
3725 * frame.h (message_buf_print): Likewise.
3726 * lisp.h (pop_message, set_message, check_point_in_composition):
3727 Likewise.
3728 * xterm.h (set_vertical_scroll_bar): Likewise.
3729 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3730 (message_buf_print, scratch_glyph_row, displayed_buffer):
3731 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3732 (get_next_display_element, show_mouse_face, window_box_edges):
3733 (frame_to_window_pixel_xy, check_point_in_composition):
3734 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3735 (glyph_to_pixel_coords): Remove; unused.
3736
16390cd2
PE
3737 * dired.c (file_name_completion): Now static.
3738
3739 * dbusbind.c (xd_in_read_queued_messages): Now static.
3740
a25f4dfa
PE
3741 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3742 * data.c (circular_list_error): Remove.
3743
14a9c8df
PE
3744 * commands.h (last_point_position, last_point_position_buffer):
3745 (last_point_position_window): Remove decls.
3746 * keyboard.c: Make these variables static.
3747
04f2d78b
CB
3748 * coding.h (coding, code_convert_region, encode_coding_gap):
3749 Remove decls.
74ab6df5
PE
3750 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3751 (iso_code_class, detect_coding, code_convert_region): Now static.
3752 (encode_coding_gap): Remove; unused.
3753
38dfbee1
PE
3754 * chartab.c (chartab_chars, chartab_bits): Now static.
3755
a2cb4e63
PE
3756 * charset.h (charset_iso_8859_1): Remove decl.
3757 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3758 Now static.
3759
127198fd
PE
3760 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3761 * ccl.c (Vccl_program_table): Now static.
3762 (check_ccl_update): Remove; unused.
3763
d85b608f
PE
3764 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3765 * category.h: ... from here.
3766 * category.c (check_category_table, set_category_set): Now static.
3767
31cd66f3
PE
3768 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3769 * lisp.h: Remove these decls.
3770
c358e587
PE
3771 * buffer.c (buffer_count): Remove unused var.
3772
e78aecca
PE
3773 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3774 so that it's not optimized away.
3775 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3776 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3777 exported only to the debugger.
3778
e192d7d3 3779 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3780 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3781
92470028
PE
3782 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3783 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3784 was inaccessible from Lisp.
3785 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3786 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3787
244ed907
PE
3788 alloc.c: Import and export fewer symbols, and remove unused items.
3789 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3790 is defined.
3791 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3792 it's not optimized away by whole-program optimization.
3793 (message_enable_multibyte, free_misc): Remove.
3794 (catchlist, handlerlist, mark_backtrace):
3795 Declare only if BYTE_MARK_STACK.
3796 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3797 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3798 (message_enable_multibyte): Remove decl.
3799 (free_misc, interval_free_list, float_block, float_block_index):
3800 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3801 (cons_free_list, last_marked_index):
3802 Now static.
3803 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3804 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3805 (mark_backtrace): Define only if BYTE_MARK_STACK.
3806 * xdisp.c (message_enable_multibyte): Now static.
3807
61c2b50e 3808 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3809 This makes it easier for human readers (and static analyzers)
3810 to see whether these variables are used from other modules.
3811 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3812 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3813 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3814 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3815 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3816 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3817 * xmenu.c, xselect.c:
3818 Declare Q* vars static if they are not used in other modules.
3819 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3820 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3821 Remove decls of unexported vars.
3822 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3823
95c82688
PE
3824 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3825
16a97296
PE
3826 Make Emacs functions such as Fatom 'static' by default.
3827 This makes it easier for human readers (and static analyzers)
3828 to see whether these functions can be called from other modules.
3829 DEFUN now defines a static function. To make the function external
3830 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3831 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3832 (Finit_image_library):
16a97296
PE
3833 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3834 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3835 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3836 Remove decls, since these functions are now static.
3837 (Funintern, Fget_internal_run_time): New decls, since these functions
3838 were already external.
95c82688 3839
16a97296
PE
3840 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3841 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3842 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3843 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3844 * keyboard.c, keymap.c, lread.c:
3845 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3846 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3847 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3848 Mark functions with DEFUE instead of DEFUN,
3849 if they are used in other modules.
3850 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3851 decls for now-static functions.
3852 * buffer.h (Fdelete_overlay): Remove decl.
3853 * callproc.c (Fgetenv_internal): Mark as internal.
3854 * composite.c (Fremove_list_of_text_properties): Remove decl.
3855 (Fcomposition_get_gstring): New forward static decl.
3856 * composite.h (Fcomposite_get_gstring): Remove decl.
3857 * dired.c (Ffile_attributes): New forward static decl.
3858 * doc.c (Fdocumntation_property): New forward static decl.
3859 * eval.c (Ffetch_bytecode): New forward static decl.
3860 (Funintern): Remove extern decl; now in .h file where it belongs.
3861 * fileio.c (Fmake_symbolic_link): New forward static decl.
3862 * image.c (Finit_image_library): New forward static decl.
3863 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3864 * intervals.h (Fprevious_property_change):
3865 (Fremove_list_of_text_properties): Remove decls.
3866 * keyboard.c (Fthis_command_keys): Remove decl.
3867 (Fcommand_execute): New forward static decl.
3868 * keymap.c (Flookup_key): New forward static decl.
3869 (Fcopy_keymap): Now static.
3870 * keymap.h (Flookup_key): Remove decl.
3871 * process.c (Fget_process): New forward static decl.
3872 (Fprocess_datagram_address): Mark as internal.
3873 * syntax.c (Fsyntax_table_p): New forward static decl.
3874 (skip_chars): Remove duplicate decl.
3875 * textprop.c (Fprevious_property_change): New forward static decl.
3876 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3877 Now internal.
3878 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3879 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3880
785bbd42
PE
3881 * editfns.c (Fformat): Remove unreachable code.
3882
8b913b57
AS
38832011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3884
3885 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3886 change. (Bug#8496)
3887
a6744a35
EZ
38882011-04-13 Eli Zaretskii <eliz@gnu.org>
3889
3890 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3891 when at ZV. (Bug#8487)
3892
e7974947
AS
38932011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3894
baad03f0
AS
3895 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3896 (Bug#8437)
3897 * keyboard.c (parse_tool_bar_item): Likewise.
3898 * sound.c (sound_cleanup, alsa_close): Likewise.
3899 * termcap.c (tgetent): Likewise.
3900 * xfns.c (x_default_font_parameter): Likewise.
3901 * xsettings.c (read_and_apply_settings): Likewise.
3902
e7974947
AS
3903 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3904 (overrun_check_free): Protoize.
3905
28272684
PE
39062011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3907
3908 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3909 since callers should never pass a negative size.
3910 Change the signature to match that of plain 'read' and 'write'; see
3911 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3912 * lisp.h: Update prototypes of emacs_write and emacs_read.
3913
11997c76
EZ
39142011-04-11 Eli Zaretskii <eliz@gnu.org>
3915
3916 * xdisp.c (redisplay_window): Don't try to determine the character
3917 position of the scroll margin if the window start point w->startp
e896f03c 3918 is outside the buffer's accessible region. (Bug#8468)
11997c76 3919
8a2cbd72
EZ
39202011-04-10 Eli Zaretskii <eliz@gnu.org>
3921
3922 Fix write-region and its subroutines for buffers > 2GB.
3923 * fileio.c (a_write, e_write): Modify declaration of arguments and
3924 local variables to support buffers larger than 2GB.
3925 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3926
3927 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3928 argument, local variables, and return value.
3929
3930 * lisp.h: Update prototypes of emacs_write and emacs_read.
3931
3932 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3933
4073e537 39342011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3935
1ebfdcb6
PE
3936 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3937
b2ded58d
PE
3938 Fix more problems found by GCC 4.6.0's static checks.
3939
7d66342c
PE
3940 * xdisp.c (vmessage): Use a better test for character truncation.
3941
bbf47d44
PE
3942 * charset.c (load_charset_map): <, not <=, for optimization,
3943 and to avoid potential problems with integer overflow.
9248994d 3944 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3945 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3946 * editfns.c (Fformat): Likewise.
1e69125e 3947 * syntax.c (skip_chars): Likewise.
3befa583 3948
e3019616
PE
3949 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3950 This also lets GCC 4.6.0 generate slightly better loop code.
3951
becfa255
PE
3952 * callint.c (Fcall_interactively): <, not <=, for optimization.
3953 (Fcall_interactively): Count the number of arguments produced,
3954 not the number of arguments given. This is simpler and lets GCC
3955 4.6.0 generate slightly better code.
3956
dae0cd48
PE
3957 * ftfont.c: Distingish more carefully between FcChar8 and char.
3958 The previous code passed unsigned char * to a functions like
3959 strlen and xstrcasecmp that expect char *, which does not
3960 conform to the C standard.
3961 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3962 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3963 char * when the C standard requires it.
3964
76032d70
PE
3965 * keyboard.c (read_char): Remove unused var.
3966
eb3f1cc8
PE
3967 * eval.c: Port to Windows vsnprintf (Bug#8435).
3968 Include <limits.h>.
3969 (SIZE_MAX): Define if the headers do not.
3970 (verror): Do not give up if vsnprintf returns a negative count.
3971 Instead, grow the buffer. This ports to Windows vsnprintf, which
3972 does not conform to C99. Problem reported by Eli Zaretskii.
3973 Also, simplify the allocation scheme, by avoiding the need for
3974 calling realloc, and removing the ALLOCATED variable.
3975
70476b54
PE
3976 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3977
12020a9e
PE
3978 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3979 But keep the doprint source code for now, as we might revamp it
3980 and use it again (Bug#8435).
ea6c7ae6
PE
3981 * lisp.h (doprnt): Remove.
3982 * Makefile.in (base_obj): Remove doprnt.o.
3983 * deps.mk (doprnt.o): Remove.
3984
5fdb398c
PE
3985 error: Print 32- and 64-bit integers portably (Bug#8435).
3986 Without this change, on typical 64-bit hosts error ("...%d...", N)
3987 was used to print both 32- and 64-bit integers N, which relied on
3988 undefined behavior.
3989 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3990 New macro.
3991 * lisp.h (error, verror): Mark as printf-like functions.
3992 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3993 Report overflow in size calculations when allocating printf buffer.
3994 Do not truncate output string at its first null byte.
3995 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3996 Truncate the output at a character boundary, since vsnprintf does not
3997 do that.
3998 * charset.c (check_iso_charset_parameter): Convert internal
3999 character to string before calling 'error', since %c now has the
4000 printf meaning.
4001 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4002 overflow when computing char to be passed to 'error'. Do not
4003 pass Lisp_Object to 'error'; pass the integer instead.
4004 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4005 formatted with plain %d.
4006
b189fa66
PE
4007 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4008
bff87ef0
PE
4009 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4010
7e2cac20
PE
4011 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4012
ce4d90b5
PE
4013 * xterm.c (x_catch_errors): Remove duplicate declaration.
4014
266c9547
PE
4015 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4016
79c49ad2
PE
4017 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4018
368f4090
JM
40192011-04-10 Jim Meyering <meyering@redhat.com>
4020
4021 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4022 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4023 return ssize_t not "int", and use size_t as the buffer length.
4024 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4025 * gnutls.h: Update declarations.
4026 * process.c (read_process_output): Use ssize_t, to match.
4027 (send_process): Likewise.
4028
a32d4040
CY
40292011-04-09 Chong Yidong <cyd@stupidchicken.com>
4030
4031 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4032
8546720e 40332011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4034
04f2d78b
CB
4035 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4036 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4037
8546720e
GM
4038 * xterm.c (handle_one_xevent):
4039 * xmenu.c (create_and_show_popup_menu):
4040 * xselect.c (x_decline_selection_request)
4041 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4042
0a2f5c1a 40432011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4044
4045 Fix some uses of `int' instead of EMACS_INT.
4046 * search.c (string_match_1, fast_string_match)
4047 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4048 (scan_buffer, find_next_newline_no_quit)
4049 (find_before_next_newline, search_command, Freplace_match)
4050 (Fmatch_data): Make some `int' variables be EMACS_INT.
4051
4052 * xdisp.c (display_count_lines): 3rd argument and return value now
4053 EMACS_INT. All callers changed.
4054 (pint2hrstr): Last argument is now EMACS_INT.
4055
4056 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4057 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4058 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4059 (decode_coding_utf_16, decode_coding_emacs_mule)
4060 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4061 (decode_coding_ccl, decode_coding_charset)
4062 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4063 (decode_coding_iso_2022, decode_coding_emacs_mule)
4064 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4065 <char_offset, last_offset>: Declare EMACS_INT.
4066 (encode_coding_utf_8, encode_coding_utf_16)
4067 (encode_coding_emacs_mule, encode_invocation_designation)
4068 (encode_designation_at_bol, encode_coding_iso_2022)
4069 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4070 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4071 Declare EMACS_INT.
4072 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4073 (encode_invocation_designation): Last argument P_NCHARS is now
4074 EMACS_INT.
4075 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4076 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4077
4078 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4079 All users changed.
4080
4081 * ccl.c (Fccl_execute_on_string): Declare some variables
4082 EMACS_INT.
4083
8546720e 40842011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4085
4086 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4087
4e19a977
CS
40882011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4089
4090 * process.c (Fformat_network_address): Doc fix.
4091
87302331
R
40922011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4093
4094 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4095
cbb59342
CY
40962011-04-08 Chong Yidong <cyd@stupidchicken.com>
4097
4098 * keyboard.c (read_char): Call Lisp function help-form-show,
4099 instead of using internal_with_output_to_temp_buffer.
4100 (Qhelp_form_show): New var.
e0d38eeb 4101 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4102
4103 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4104
4105 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4106
e67a13ab
CY
41072011-04-06 Chong Yidong <cyd@stupidchicken.com>
4108
04f2d78b
CB
4109 * process.c (Flist_processes): Remove to Lisp.
4110 (list_processes_1): Delete.
e67a13ab 4111
973f782d
EZ
41122011-04-06 Eli Zaretskii <eliz@gnu.org>
4113
7c106b1e
EZ
4114 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4115
973f782d
EZ
4116 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4117
41cf7d1a 41182011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4119
ca23cc88
PE
4120 Fix more problems found by GCC 4.6.0's static checks.
4121
f390e2d5
PE
4122 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4123
42eea0d0
PE
4124 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4125
b69769da 4126 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4127
f9541e84
PE
4128 * xdisp.c (vmessage): Mark as a printf-like function.
4129
13841b55
PE
4130 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4131
c136c10f
PE
4132 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4133
5e2d4a30
PE
4134 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4135 printf-like functions.
4136 (tiff_load): Add casts to remove these marks before passing them
4137 to system-supplied API.
4138
583f48b9
PE
4139 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4140
b25d760e
PE
4141 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4142 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4143 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4144 directly, rather than having caller test rule sign. This avoids
4145 some unnecessary tests.
4146 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4147 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4148 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4149
bc7b6697 4150 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4151 (xfont_open): Avoid unnecessary tests.
bc7b6697 4152
27ccc379
PE
4153 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4154
dcd5c89a
PE
4155 * composite.h, composite.c (composition_gstring_put_cache):
4156 Use EMACS_INT, not int, for length.
4157
b13a45c6
PE
4158 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4159 breaking out part of COMPOSITION_DECODE_RULE.
4160 (COMPOSITION_DECODE_RULE): Use it.
4161 * composite.c (get_composition_id): Remove unused local vars,
4162 by using the new macro.
4163
1e792e4d
PE
4164 * textprop.c (set_text_properties_1): Change while to do-while,
4165 since the condition is always true at first.
4166
dc6c6455 4167 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4168 (interval_deletion_adjustment): Return unsigned value.
4169 All uses changed.
dc6c6455 4170
aba7731a
PE
4171 * process.c (list_processes_1, create_pty, read_process_output):
4172 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4173 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4174 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4175 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4176 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4177
fdfc4bf3
PE
4178 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4179
fca8fe46 4180 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4181 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4182
06a0259a 4183 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4184 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4185 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4186
e7b9e80f
PE
4187 * print.c (print_error_message): Avoid int overflow.
4188
56201685
PE
4189 * font.c (font_list_entities): Redo for clarity,
4190 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4191
78834453 4192 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4193 (font_score): Avoid potential overflow in diff calculation.
78834453 4194
0bc0b309 4195 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4196 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4197
e610eaca
PE
4198 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4199
b895abce
PE
4200 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4201 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4202 can always succeed if overflow has undefined behavior.
4203
1f1d9321 4204 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4205 (wordify): Omit three unnecessary tests.
1f1d9321 4206
c59478bc
PE
4207 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4208 All callers changed. This avoids the need for an unused var.
4209
79b73827
PE
4210 * casefiddle.c (casify_region): Remove var that is set but not used.
4211
a4db5dfe
PE
4212 * dired.c (file_name_completion): Remove var that is set but not used.
4213
43aae36e
PE
4214 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4215
2a47c44d 4216 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4217 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4218
a37c69bf
PE
4219 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4220 Check for integer overflow on size calculations.
4221
328ab8e7
PE
4222 * buffer.c (Fprevious_overlay_change): Remove var that is set
4223 but not used.
4224
e5a2a5cb
PE
4225 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4226 Remove vars that are set but not used.
8d84a6eb 4227 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4228 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4229
a60e5f68
PE
4230 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4231
f661cb61 4232 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4233 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4234
f0397f5a
PE
4235 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4236 that are set but not used.
4237
8664db06 4238 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4239 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4240
6abdaa4a
PE
4241 * xselect.c (x_get_local_selection, x_handle_property_notify):
4242 Remove vars that are set but not used.
4243
0ce7538d 4244 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4245 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4246
9ae848fc
PE
4247 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4248 Remove var that is set but not used.
0b918413
PE
4249 (scroll_bar_windows_size): Now size_t, not int.
4250 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4251 Check for overflow.
9ae848fc 4252
a5a62657
PE
4253 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4254 (map_tty_color) [!defined MSDOS]: Likewise.
4255
5c5cdd39
PE
4256 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4257
66ebf983
PE
4258 * coding.c: Remove vars that are set but not used.
4259 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4260 All callers changed.
4261 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4262 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4263 (decode_coding_charset): Remove vars that are set but not used.
4264
1be4d761
PE
4265 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4266 that is set but not used.
4267
47553fa8
PE
4268 * print.c (print_object): Remove var that is set but not used.
4269
1f7196bf 4270 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4271 The gnulib version avoids calling malloc in the usual case,
4272 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4273 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4274 * filelock.c (current_lock_owner): Likewise.
4275 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4276 * sysdep.c: Include allocator.h, careadlinkat.h.
4277 (emacs_no_realloc_allocator): New static constant.
4278 (emacs_readlink): New function.
fdb61804
PE
4279 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4280 ../lib/careadlinkat.h.
d1fdcab7 4281
f84c17c7
SM
42822011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4283
4284 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4285 first non-nil return value).
4286
ef3862ad
JD
42872011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4288
4289 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4290 if not defined (Bug#8403).
4291
376a7006
JB
42922011-04-02 Juanma Barranquero <lekktu@gmail.com>
4293
4294 * xdisp.c (display_count_lines): Remove parameter `start',
4295 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4296 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4297 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4298 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4299 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4300 and thereabouts. All callers changed.
4301 (get_per_char_metric): Remove parameter `f', unused since
4302 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4303
6ca3801d
JM
43042011-04-02 Jim Meyering <meyering@redhat.com>
4305
4306 do not dereference NULL upon failed strdup
4307 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4308 (ns_get_family): Likewise.
4309
d8e2b5ba
JB
43102011-04-02 Juanma Barranquero <lekktu@gmail.com>
4311
4312 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4313
8c74fcbd
JD
43142011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4315
4316 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4317 later (Bug#8403).
4318
7200d79c
SM
43192011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4320
03408648 4321 Add lexical binding.
7200d79c 4322
03408648
SM
4323 * window.c (Ftemp_output_buffer_show): New fun.
4324 (Fsave_window_excursion):
4325 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4326
4327 * lread.c (lisp_file_lexically_bound_p): New function.
4328 (Fload): Bind Qlexical_binding.
4329 (readevalloop): Remove `evalfun' arg.
4330 Bind Qinternal_interpreter_environment.
4331 (Feval_buffer): Bind Qlexical_binding.
4332 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4333 Mark as dynamic.
4334 (syms_of_lread): Declare `lexical-binding'.
4335
4336 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4337
4338 * keyboard.c (eval_dyn): New fun.
4339 (menu_item_eval_property): Use it.
ca105506
SM
4340
4341 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4342
03408648
SM
4343 * fns.c (concat, mapcar1): Accept byte-code-functions.
4344
4345 * eval.c (Fsetq): Handle lexical vars.
4346 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4347 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4348 (FletX, Flet): Obey lexical binding.
4349 (Fcommandp): Handle closures.
4350 (Feval): New `lexical' arg.
4351 (eval_sub): New function extracted from Feval. Use it almost
4352 everywhere where Feval was used. Look up vars in lexical env.
4353 Handle closures.
4354 (Ffunctionp): Move from subr.el.
4355 (Ffuncall): Handle closures.
4356 (apply_lambda): Remove `eval_flags'.
4357 (funcall_lambda): Handle closures and new byte-code-functions.
4358 (Fspecial_variable_p): New function.
4359 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4360 but without exporting it to Lisp.
23aba0ea 4361
23aba0ea 4362 * doc.c (Fdocumentation, store_function_docstring):
03408648 4363 * data.c (Finteractive_form): Handle closures.
23aba0ea 4364
03408648
SM
4365 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4366 interactive spec.
ba83908c 4367
04f2d78b
CB
4368 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4369 New byte-codes.
03408648
SM
4370 (exec_byte_code): New function extracted from Fbyte_code to handle new
4371 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4372
03408648 4373 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4374
03408648 4375 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4376
e2abce01
JB
43772011-03-31 Juanma Barranquero <lekktu@gmail.com>
4378
4379 * xdisp.c (redisplay_internal): Fix prototype.
4380
63696a73 43812011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4382
63696a73 4383 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4384 (try_scrolling): Use it when setting scroll_limit.
4385 Limit scrolling to 100 screen lines.
63696a73
EZ
4386 (redisplay_window): Even when falling back on "recentering",
4387 position point in the window according to scroll-conservatively,
4388 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4389
4390 (try_scrolling): When point is above the window, allow searching
4391 as far as scroll_max, or one screenful, to compute vertical
4392 distance from PT to the scroll margin position. This prevents
4393 try_scrolling from unnecessarily failing when
4394 scroll-conservatively is set to a value slightly larger than the
4395 window height. Clean up the case of PT below the margin at bottom
4396 of window: scroll_max can no longer be INT_MAX. When aggressive
4397 scrolling is in use, don't let point enter the opposite scroll
4398 margin as result of the scroll.
4399 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4400 threshold of 100 lines for never-recentering scrolling.
4401
e4cc2dfc
JB
44022011-03-31 Juanma Barranquero <lekktu@gmail.com>
4403
4404 * dispextern.h (move_it_by_lines):
4405 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4406 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4407 (message_log_check_duplicate): Remove parameters `prev_bol' and
4408 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4409 (redisplay_internal): Remove parameter `preserve_echo_area',
4410 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4411
4412 * indent.c (Fvertical_motion):
4413 * window.c (window_scroll_pixel_based, Frecenter):
4414 Don't pass `need_y_p' to `move_it_by_lines'.
4415
1c470562
SM
44162011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4417
44f230aa
SM
4418 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4419 steal a few bits to be more compact.
4420 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4421 Remove unneeded casts.
4422
1c470562
SM
4423 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4424
888adce9
ZK
44252011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4426
4427 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4428 binding" message (bug#7967).
4429
f838ed7b
PE
44302011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4431
77861b95
PE
4432 Fix more problems found by GCC 4.6.0's static checks.
4433
de6dbc14
PE
4434 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4435 Remove unused local var.
4436
f838ed7b
PE
4437 * editfns.c (Fmessage_box): Remove unused local var.
4438
792c7b2b
PE
4439 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4440 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4441 Omit unused local vars.
c499e557 4442 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4443 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4444 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4445 Omit unused local var.
4446
ba0165e1
PE
4447 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4448 Don't assume string length fits in int.
32ad8845 4449 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4450 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4451
3c59b4c9
PE
4452 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4453 instead of alloca (Bug#8344).
4454
a3eed478 4455 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4456 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4457
eb4d412d
PE
4458 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4459
1658b401
PE
4460 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4461 concerns.
4462
4463 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4464
4465 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4466
9a2c6e05
PE
4467 * keyboard.c (syms_of_keyboard): Use the same style as later
4468 in this function when indexing through an array. This also
4469 works around GCC bug 48267.
4470
03d0a109
PE
4471 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4472
44f730c8
PE
4473 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4474
fe75f926
PE
4475 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4476 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4477
ffa8c828
PE
4478 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4479 This avoids undefined behavior on integer overflow, and is a bit
4480 more convenient anyway since it is compared to a size_t variable.
4481
c5101a77
PE
4482 Variadic C functions now count arguments with size_t, not int.
4483 This avoids an unnecessary limitation on 64-bit machines, which
4484 caused (substring ...) to crash on large vectors (Bug#8344).
4485 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4486 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4487 All variadic functions and their callers changed accordingly.
c5101a77
PE
4488 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4489 * data.c (arith_driver, float_arith_driver): Likewise.
4490 * editfns.c (general_insert_function): Likewise.
4491 * eval.c (struct backtrace.nargs, interactive_p)
4492 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4493 (funcall_lambda, mark_backtrace): Likewise.
4494 * fns.c (concat): Likewise.
4495 * frame.c (x_set_frame_parameters): Likewise.
4496 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4497 0 if not found, not -1. All callers changed.
4498
dd3f25f7
PE
4499 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4500 (stack_copy_size): Now size_t, not int.
4501 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4502
461c2ab9
JB
45032011-03-28 Juanma Barranquero <lekktu@gmail.com>
4504
4505 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4506 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4507 All callers changed.
4508
4509 * lisp.h (multibyte_char_to_unibyte):
4510 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4511 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4512 * character.h (CHAR_TO_BYTE8):
4513 * cmds.c (internal_self_insert):
4514 * editfns.c (general_insert_function):
4515 * keymap.c (push_key_description):
4516 * search.c (Freplace_match):
4517 * xdisp.c (message_dolog, set_message_1): All callers changed.
4518
f6d62986
SM
45192011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4520
4521 * keyboard.c (safe_run_hook_funcall): New function.
4522 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4523 don't set the hook to nil, but remove the offending function instead.
4524 (Qcommand_hook_internal): Remove, unused.
4525 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4526 Vcommand_hook_internal.
4527
4528 * eval.c (enum run_hooks_condition): Remove.
4529 (funcall_nil, funcall_not): New functions.
4530 (run_hook_with_args): Call each function through a `funcall' argument.
4531 Remove `cond' argument, now redundant.
4532 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4533 (Frun_hook_with_args_until_failure): Adjust accordingly.
4534 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4535
1db5b1ad
JB
45362011-03-28 Juanma Barranquero <lekktu@gmail.com>
4537
4538 * dispextern.h (string_buffer_position): Remove declaration.
4539
4540 * print.c (strout): Remove parameter `multibyte', unused since
4541 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4542
4543 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4544 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4545 All callers changed.
4546
4547 * w32.c (_wsa_errlist): Use braces for struct initializers.
4548
4549 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4550 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4551 All callers changed.
4552 (string_buffer_position): Likewise. Also, make static (it's never
4553 used outside xdisp.c).
4554 (cursor_row_p): Remove parameter `w', unused since
4555 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4556 (decode_mode_spec): Remove parameter `precision', introduced during
4557 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4558 All callers changed.
4559
5ffb62aa
JD
45602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4561
4562 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4563
461c2ab9 45642011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4565
4566 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4567 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4568 (ns_update_auto_hide_menu_bar): New functions.
4569 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4570 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4571 ns_constrain_all_frames.
4572 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4573 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4574
5c380ffb
JD
45752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4576
4577 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4578
9af30bdf
GM
45792011-03-27 Glenn Morris <rgm@gnu.org>
4580
4581 * syssignal.h: Replace RETSIGTYPE with void.
4582 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4583 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4584 Replace SIGTYPE with void everywhere.
4585 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4586 * s/template.h (SIGTYPE): Remove commented out definition.
4587
e2abce01
JB
45882011-03-26 Eli Zaretskii <eliz@gnu.org>
4589
4590 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4591 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4592
f868cd8a
JB
45932011-03-26 Juanma Barranquero <lekktu@gmail.com>
4594
59eb0929
JB
4595 * w32.c (read_unc_volume): Use parameter `henum', instead of
4596 global variable `wget_enum_handle'.
4597
4598 * keymap.c (describe_vector): Remove parameters `indices' and
4599 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4600 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4601
f868cd8a
JB
4602 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4603
4604 * keyboard.c (timer_check): Remove parameter `do_it_now',
4605 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4606 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4607 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4608
4609 * keyboard.c (read_char):
4610 * w32menu.c (w32_menu_display_help):
4611 * xmenu.c (show_help_event, menu_help_callback):
4612 Adjust calls to `show_help_echo'.
4613
4614 * gtkutil.c (xg_maybe_add_timer):
4615 * keyboard.c (readable_events):
4616 * process.c (wait_reading_process_output):
4617 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4618
4619 * insdel.c (adjust_markers_gap_motion):
4620 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4621 (gap_left, gap_right): Don't call it.
4622
2ecf6fdb
CY
46232011-03-25 Chong Yidong <cyd@stupidchicken.com>
4624
4625 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4626 incurred during fontification.
4627
6b1f9ba4
JB
46282011-03-25 Juanma Barranquero <lekktu@gmail.com>
4629
4630 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4631 (DEFVAR_PER_BUFFER): Don't pass it.
4632
4633 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4634 (scrolling_window): Don't pass it.
4635
0f4a96b5
JB
46362011-03-25 Juanma Barranquero <lekktu@gmail.com>
4637
4638 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4639
4640 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4641 and `suffix'.
4642 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4643 of variables specific to SELinux and computation of `encoded_absname'.
4644
4645 * image.c (XPutPixel): Remove unused variable `height'.
4646
4647 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4648
4649 * unexw32.c (get_section_info): Remove unused variable `section'.
4650
4651 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4652 (system_process_attributes): Remove unused variable `sess'.
4653 (sys_read): Remove unused variable `err'.
4654
4655 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4656 (w32_wnd_proc): Remove unused variable `isdead'.
4657 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4658 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4659 (x_create_tip_frame): Remove unused variable `tem'.
4660
4661 * w32inevt.c (w32_console_read_socket):
4662 Remove unused variable `no_events'.
4663
4664 * w32term.c (x_draw_composite_glyph_string_foreground):
4665 Remove unused variable `width'.
4666
1149507c
JB
46672011-03-24 Juanma Barranquero <lekktu@gmail.com>
4668
4669 * w32term.c (x_set_glyph_string_clipping):
4670 Don't pass uninitialized region to CombineRgn.
4671
9c88f339
JB
46722011-03-23 Juanma Barranquero <lekktu@gmail.com>
4673
4674 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4675 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4676 (Fx_close_connection): Remove unused variable `i'.
4677
4678 * w32font.c (w32font_draw): Return number of glyphs.
4679 (w32font_open_internal): Remove unused variable `i'.
4680 (w32font_driver): Add missing initializer.
4681
4682 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4683 (fill_in_menu): Remove unused variable `items_added'.
4684
4685 * w32term.c (last_mouse_press_frame): Remove static global variable.
4686 (w32_clip_to_row): Remove unused variable `f'.
4687 (x_delete_terminal): Remove unused variable `i'.
4688
4689 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4690 (NOTHING): Remove unused static global variable.
4691 (uniscribe_check_otf): Remove unused variable `table'.
4692 (uniscribe_font_driver): Add missing initializers.
4693
dee091a3
JD
46942011-03-23 Julien Danjou <julien@danjou.info>
4695
4696 * term.c (Fsuspend_tty, Fresume_tty):
4697 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4698 * window.c (temp_output_buffer_show):
4699 * insdel.c (signal_before_change):
4700 * frame.c (Fhandle_switch_frame):
4701 * fileio.c (Fdo_auto_save):
4702 * emacs.c (Fkill_emacs):
4703 * editfns.c (save_excursion_restore):
4704 * cmds.c (internal_self_insert):
4705 * callint.c (Fcall_interactively):
4706 * buffer.c (Fkill_all_local_variables):
4707 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4708 Use Frun_hooks.
0f4a96b5 4709 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4710 unconditionnaly since it does the check itself.
4711
2c520ab5 47122011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4713
c9c49752
PE
4714 Fix more problems found by GCC 4.5.2's static checks.
4715
8abc3f12
PE
4716 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4717 the first time through the loop, since we know p0 < p1 then.
4718 This also avoids a gcc -Wstrict-overflow warning.
4719
a2d26660
PE
4720 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4721 leading to a memory leak, possible in functions like
4722 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4723 of objects (Bug#8318).
a2d26660 4724
916c72e9
PE
4725 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4726 that could (at least in theory) be that large.
4727
19ab8a18
PE
4728 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4729 This is less likely to overflow, and avoids undefined behavior if
4730 overflow does occur. All callers changed. Use strtoul to scan
4731 for the unsigned long integer.
b7cbbd6f
PE
4732 (pint2hrstr): Simplify and tune code slightly.
4733 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4734
f0641eff
PE
4735 * scroll.c (do_scrolling): Work around GCC bug 48228.
4736 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4737
7f650bb9
PE
4738 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4739 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4740 (validate_x_resource_name): Simplify count usage.
4741 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4742
37dd57d1
PE
4743 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4744 fail (Bug#8306).
81e56e61 4745
699979fc 4746 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4747
401bf9b4
PE
4748 * process.c (Fmake_network_process): Use socklen_t, not int,
4749 where POSIX says socklen_t is required in portable programs.
4750 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4751 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4752 (Fmake_network_process, server_accept_connection):
4753 (wait_reading_process_output, read_process_output):
4754 Likewise.
4755
b93aacde
PE
4756 * process.c: Rename or move locals to avoid shadowing.
4757 (list_processes_1, Fmake_network_process):
4758 (read_process_output_error_handler, exec_sentinel_error_handler):
4759 Rename or move locals.
4dc343ee 4760 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4761 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4762 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4763 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4764 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4765
af8a867c 4766 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4767 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4768 Include tparam.h instead, since it declares them.
af8a867c
PE
4769 * cm.h (PC): Remove extern decl; tparam.h now does this.
4770 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4771 * terminfo.c: Include tparam.h, to check interfaces.
4772 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4773 (tparam): Adjust signature to match interface in tparam.h;
4774 this removes some undefined behavior. Check that outstring and len
4775 are zero, which they always are with Emacs.
4776 * tparam.h (PC, BC, UP): New extern decls.
4777
0248044d 4778 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4779 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4780
8ff096c1 4781 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4782 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4783 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4784 (ftfont_list): Remove unused local.
49eaafba
PE
4785 (get_adstyle_property, ftfont_pattern_entity):
4786 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4787 Rename locals to avoid shadowing.
8ff096c1 4788
e2be39f6
PE
4789 * xfont.c (xfont_list_family): Mark var as initialized.
4790
c9735e30
PE
4791 * xml.c (make_dom): Now static.
4792
8f5201ae
PE
4793 * composite.c (composition_compute_stop_pos): Rename local to
4794 avoid shadowing.
b246f932
PE
4795 (composition_reseat_it): Remove unused locals.
4796 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4797 (composition_update_it): Mark var as initialized.
11b61122
PE
4798 (find_automatic_composition): Mark vars as initialized,
4799 with a FIXME (Bug#8290).
8f5201ae 4800
760fbc2c
PE
4801 character.h: Rename locals to avoid shadowing.
4802 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4803 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4804 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4805 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4806 to avoid shadowing.
4807
ff08eb85
PE
4808 * textprop.c (property_change_between_p): Remove; unused.
4809
fc7bf025
PE
4810 * intervals.c (interval_start_pos): Now static.
4811
235d7abc
PE
4812 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4813
44f230aa
SM
4814 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4815 Rename locals to avoid shadowing.
3e7d6594 4816
50060332
PE
4817 * sound.c (wav_play, au_play, Fplay_sound_internal):
4818 Fix pointer signedness.
d01f234b 4819 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4820 (wav_play): Initialize a variable to 0, to prevent undefined
4821 behavior (Bug#8278).
50060332 4822
c4fc4e30
PE
4823 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4824
918436ed
PE
4825 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4826
c939f91b
PE
4827 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4828 clobbering (Bug#8298).
b9c7f648
PE
4829 * sysdep.c (sys_subshell): Likewise.
4830 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4831
6bd8c144
PE
4832 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4833 This should get cleaned up, so that child_setup has the
4834 same signature on all platforms.
4835
7710357c 4836 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4837 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4838
c59da222
CY
48392011-03-22 Chong Yidong <cyd@stupidchicken.com>
4840
4841 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4842 not to be necessary, and produces flickering.
4843
66b87493
GM
48442011-03-20 Glenn Morris <rgm@gnu.org>
4845
4846 * config.in: Remove file.
4847
45b6f6d5
JB
48482011-03-20 Juanma Barranquero <lekktu@gmail.com>
4849
4850 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4851 are now in src/globals.h.
4852 (syms_of_minibuf): Remove spurious & from previous change.
4853
3ec03f7e
LL
48542011-03-20 Leo <sdl.web@gmail.com>
4855
4856 * minibuf.c (completing-read-function): New variable.
4857 (completing-read-default): Rename from completing-read.
4858 (completing-read): Call completing-read-function.
4859
b14e3e21
CY
48602011-03-19 Juanma Barranquero <lekktu@gmail.com>
4861
4862 * xfaces.c (Fx_load_color_file):
4863 Read color file from absolute filename (bug#8250).
4864
f2b726e6
JB
48652011-03-19 Juanma Barranquero <lekktu@gmail.com>
4866
4867 * makefile.w32-in: Update dependencies.
4868
09f6ff02
EZ
48692011-03-17 Eli Zaretskii <eliz@gnu.org>
4870
4871 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4872
29a6015a
PE
48732011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4874
a3a6c54e
PE
4875 Fix more problems found by GCC 4.5.2's static checks.
4876
b766f867
PE
4877 * process.c (make_serial_process_unwind, send_process_trap):
4878 (sigchld_handler): Now static.
4879
be02381c
PE
4880 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4881 That way, the code declares only the vars that it needs.
4882 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4883 * s/cygwin.h (PTY_ITERATION): Likewise.
4884 * s/darwin.h (PTY_ITERATION): Likewise.
4885 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4886
57048744
PE
4887 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4888 * process.c (allocate_pty): Don't declare stb unless it's needed.
4889
7914961c 4890 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4891 (CONSTANTLIM): Remove; unused.
4892 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4893 Define only if needed.
7914961c 4894
b3967b18
PE
4895 * unexelf.c (unexec): Name an expression,
4896 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4897 Use a different way to cause a compilation error if anyone uses
4898 n rather than nn, a way that does not involve shadowing.
73366a00 4899 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4900
29a6015a
PE
4901 * deps.mk (unexalpha.o): Remove; unused.
4902
43cfc33e 4903 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4904 * unexec.h: New file.
ce701a33
PE
4905 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4906 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4907 Depend on unexec.h.
4908 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4909 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4910 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4911 Change as necessary to match prototype in unexec.h.
ce701a33 4912
01f44d5a
PE
4913 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4914 shadowing.
4f63c6bb 4915 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4916
a6670b0b
PE
4917 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4918 Rename locals to avoid shadowing.
4919
cef2010d 4920 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4921 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4922
d4d7173a
PE
4923 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4924
f08b802a
PE
4925 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4926 warning when compiling print.c.
4927
3ddb0639
PE
4928 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4929 instead of using an uninitialized var.
5ad03b97 4930 (font_sort_entities): Mark var as initialized.
3ddb0639 4931
170a2692
PE
4932 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4933
e663c700
PE
4934 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4935 pointers to constants.
89bc529a 4936 (font_parse_fcname): Remove unused vars.
7b81e2d0 4937 (font_delete_unmatched): Now static.
ea838e10 4938 (font_get_spec): Remove; unused.
13a547c6
PE
4939 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4940 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4941 Rename or move locals to avoid shadowing.
e663c700 4942
2a80c887 4943 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4944 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4945
1384fa33 4946 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4947 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4948
8b2c52e9
PE
4949 * alloc.c (mark_backtrace): Move decl from here ...
4950 * lisp.h: ... to here, so that it can be checked.
4951
475545b5 4952 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4953 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4954 (lisp_indirect_variable): Name an expression,
4955 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4956 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4957
b1349114 4958 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4959 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4960 Use const pointer when appropriate.
b1349114 4961
a2928364
PE
4962 * lisp.h (get_system_name, get_operating_system_release):
4963 Move decls here, to check interfaces.
4964 * process.c (get_operating_system_release): Move decl to lisp.h.
4965 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4966 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4967 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4968 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4969 (Fformat_time_string, Fencode_time, Finsert_char):
4970 (Ftranslate_region_internal, Fformat):
4971 Rename or remove local vars to avoid shadowing.
9710023e 4972 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4973
a415e694
PE
4974 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4975 avoid shadowing.
4976
8ef4622d
PE
4977 * lisp.h (eassert): Check that the argument compiles, even if
4978 ENABLE_CHECKING is not defined.
4979
946f9a5b
PE
4980 * data.c (Findirect_variable): Name an expression, to avoid
4981 gcc -Wbad-function-cast warning.
112396d6 4982 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4983 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4984 (Fmake_variable_buffer_local, Fmake_local_variable):
4985 Mark variables as initialized.
52746918 4986 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4987
e5aab7e7 4988 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4989 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4990 Rename locals to avoid shadowing.
dff45157
PE
4991 (mark_stack): Move local variables into the #ifdef region where
4992 they're used.
7bc26fdb
PE
4993 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4994 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4995 needed otherwise.
4996 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4997 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4998 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4999
e5aab7e7
PE
5000 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5001 avoids undefined behavior in theory.
5002
4da60324
PE
5003 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5004
88043301
PE
5005 Use functions, not macros, for up- and down-casing (Bug#8254).
5006 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5007 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5008 to use the following functions instead of these macros.
5009 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5010 EMACS_INT, since callers assume the returned value fits in int.
5011 (upcase1): Likewise, for UPCASE_TABLE.
5012 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5013 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5014 the race-condition problem in the old DOWNCASE.
88043301 5015
19ed5445
PE
5016 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5017 Rename locals to avoid shadowing.
5018 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5019 (regex_compile, re_search_2, re_match_2_internal):
5020 Remove unused local vars.
952db0d7
PE
5021 (FREE_VAR): Rewrite so as not to use empty "else",
5022 which gcc can warn about.
da053e48 5023 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5024 (RETALLOC_IF): Define only if needed.
5025 (WORDCHAR_P): Likewise. This one is never needed, but is used
5026 only in a comment talking about a compiler bug, so put inside
5027 the #if 0 of that comment.
5028 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5029 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5030 Remove; unused.
19ed5445 5031
1f3561e4 5032 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5033 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5034 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5035
ded6f8f7
PE
5036 * search.c (simple_search): Remove unused var.
5037
dbd37a95
PE
5038 * dired.c (compile_pattern): Move decl from here ...
5039 * lisp.h: ... to here, so that it can be checked.
5040 (struct re_registers): New forward decl.
5041
7e47afad
PE
5042 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5043
85f24f61
PE
5044 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5045 All uses changed.
5046 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5047 Rename locals to avoid shadowing.
5671df8f 5048 (Fvertical_motion): Mark locals as initialized.
85f24f61 5049
181aa2be 5050 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5051 (casify_region): Mark local as initialized.
181aa2be 5052
930d429c
PE
5053 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5054
7082eac6
PE
5055 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5056 New macros, so that the caller can use some names other than
5057 gcpro1, gcpro2, etc.
5058 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5059 of the new macros.
5060 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5061 argument, for consistency with GCPRO2_VAR, etc: it is now the
5062 prefix of the variable, not the variable itself. All uses
5063 changed.
38b2c076
PE
5064 * dired.c (directory_files_internal, file_name_completion):
5065 Rename locals to avoid shadowing.
5066
15206ed9
PE
5067 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5068 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5069 dired.c's scmp function, had undefined behavior.
5070 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5071 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5072 * buffer.h: ... to here, because these macros use current_buffer,
5073 and the new implementation with inline functions needs to have
5074 current_buffer in scope now, rather than later when the macros
5075 are used.
5076 (downcase, upcase1): New static inline functions.
5077 (DOWNCASE, UPCASE1): Reimplement using these functions.
5078 This avoids undefined behavior in expressions like
5079 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5080 from race conditions in accessing the global variables
5081 case_temp1 and case_temp2.
5082 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5083 * lisp.h (case_temp1, case_temp2): Remove their decls.
5084 * character.h (ASCII_CHAR_P): Move from here ...
5085 * lisp.h: ... to here, so that the inline functions mentioned
5086 above can use them.
5087
4a6bea26
PE
5088 * dired.c (directory_files_internal_unwind): Now static.
5089
f14b7e14
PE
5090 * fileio.c (file_name_as_directory, directory_file_name):
5091 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5092 Now static.
2893f146
PE
5093 (file_name_as_directory): Use const pointers when appropriate.
5094 (Fexpand_file_name): Likewise. In particular, newdir might
5095 point at constant storage, so make it a const pointer.
fd4ead52 5096 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5097 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5098 signedness issues.
f839df0c
PE
5099 (Fset_file_times, Finsert_file_contents, auto_save_error):
5100 Rename locals to avoid shadowing.
f14b7e14 5101
5716756e 5102 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5103 (Ftry_completion, Fall_completions): Rename or remove locals
5104 to avoid shadowing.
5716756e 5105
b4c3046a
PE
5106 * marker.c (bytepos_to_charpos): Remove; unused.
5107
b45db522
PE
5108 * lisp.h (verify_bytepos, count_markers): New decls,
5109 so that gcc does not warn that these functions aren't declared.
5110
85876d07
PE
5111 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5112 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5113 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5114 (copy_text): Remove unused local var.
85876d07 5115
03d78a21 5116 * filelock.c (within_one_second): Now static.
b3dd38ab 5117 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5118
5df8f01b
PE
5119 * buffer.c (fix_overlays_before): Mark locals as initialized.
5120 (fix_start_end_in_overlays): Likewise. This function should be
5121 simplified by using pointers-to-pointers, but that's a different
5122 matter.
b1d876f1 5123 (switch_to_buffer_1): Now static.
8f54f30a
PE
5124 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5125 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5126
a70072c9 5127 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5128 Fix pointer signedness issue.
edced198
PE
5129 (sys_subshell): Mark local as volatile if checking for lint,
5130 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5131 (MAXPATHLEN): Define only if needed.
a70072c9 5132
a0977c44
PE
5133 * process.c (serial_open, serial_configure): Move decls from here ...
5134 * systty.h: ... to here, so that they can be checked.
5135
a884fdcc
PE
5136 * fns.c (get_random, seed_random): Move extern decls from here ...
5137 * lisp.h: ... to here, so that they can be checked.
5138
604efe86 5139 * sysdep.c (reset_io): Now static.
b8950c94 5140 (wait_for_termination_signal): Remove; unused.
604efe86 5141
38fc62d9
PE
5142 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5143 (copy_keymap_item, append_key, push_text_char_description):
5144 Now static.
1004a21a 5145 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5146 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5147 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5148 (describe_map_tree):
5149 Rename locals to avoid shadowing.
38fc62d9 5150
2f2650da
PE
5151 * keyboard.c: Declare functions static if they are not used elsewhere.
5152 (echo_char, echo_dash, cmd_error, top_level_2):
5153 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5154 (read_char, kbd_buffer_get_event, make_lispy_position):
5155 (make_lispy_event, make_lispy_movement, apply_modifiers):
5156 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5157 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5158 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5159 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5160 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5161
a053e86c 5162 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5163 (mark_kboards): Move decl here ...
5164 * alloc.c (mark_kboards): ... from here.
a053e86c 5165
4752793e
PE
5166 * lisp.h (force_auto_save_soon): New decl.
5167
74f10ca7 5168 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5169 (DEFINE_DUMMY_FUNCTION): New macro.
5170 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5171 Use it.
c03cd23f
PE
5172 (main): Add casts to avoid warnings
5173 if GCC considers string literals to be constants.
74f10ca7 5174
022e70d4
PE
5175 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5176
59d6fe83
PE
5177 * dbusbind.c: Pointer signedness fixes.
5178 (xd_signature, xd_append_arg, xd_initialize):
5179 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5180 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5181 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5182 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5183
78320123
PE
5184 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5185 if GCC considers string literals to be constants.
49cebcca 5186 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5187
35ac2a97
SM
51882011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5189
fb103ca9
SM
5190 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5191 (print_preprocess, print_object): New macro to fix last change.
5192
35ac2a97
SM
5193 * print.c (print_preprocess): Don't forget font objects.
5194
62973b41
JB
51952011-03-16 Juanma Barranquero <lekktu@gmail.com>
5196
5197 * emacs.c (USAGE3): Doc fixes.
5198
0e48bb22
AS
51992011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5200
5201 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5202 structure.
5203
7684e57b
JB
52042011-03-14 Juanma Barranquero <lekktu@gmail.com>
5205
5206 * lisp.h (VWindow_system, Qfile_name_history):
5207 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5208 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5209 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5210
5211 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5212 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5213
5214 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5215 * w32console.c (detect_input_pending, read_input_pending)
5216 (encode_terminal_code):
5217 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5218 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5219 (w32_system_caret_y, Qfile_name_history):
5220 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5221 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5222 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5223 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5224 * w32proc.c (Qlocal, report_file_error):
5225 * w32term.c (Vwindow_system, updating_frame):
5226 * w32uniscribe.c (initialized, uniscribe_font_driver):
5227 Remove unneeded extern declarations.
5228
2aa46d6c
CY
52292011-03-14 Chong Yidong <cyd@stupidchicken.com>
5230
c96bbc66 5231 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5232
cffc6f3b
CY
52332011-03-13 Chong Yidong <cyd@stupidchicken.com>
5234
5235 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5236 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5237 These macros can no longer be used for assignment.
5238
44f230aa
SM
5239 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5240 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5241 (record_buffer_markers, fetch_buffer_markers): New functions for
5242 recording and fetching special buffer markers.
5243 (set_buffer_internal_1, set_buffer_temp): Use them.
5244
5245 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5246
5247 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5248
5249 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5250 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5251
5252 * xdisp.c (hscroll_window_tree):
5253 (reconsider_clip_changes): Use PT instead of BUF_PT.
5254
d251f04b
EZ
52552011-03-13 Eli Zaretskii <eliz@gnu.org>
5256
5257 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5258 $(EMACS_ROOT)/lib/intprops.h.
5259
f0c77cd1
PE
52602011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5261
3eca4629
PE
5262 Fix more problems found by GCC 4.5.2's static checks.
5263
7c86ee98
PE
5264 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5265 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5266 (xg_free_frame_widgets): Make it clear that a local variable is
5267 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5268 (gdk_window_get_screen): Make it clear that this macro is needed
5269 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5270 (int_gtk_range_get_value): New function, which avoids a diagnostic
5271 from gcc -Wbad-function-cast.
5272 (xg_set_toolkit_scroll_bar_thumb): Use it.
5273 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5274 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5275 (get_utf8_string, xg_get_file_with_chooser):
5276 Rename locals to avoid shadowing.
5277 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5278
41729b81
PE
5279 * xgselect.c (xg_select): Remove unused var.
5280
f0c77cd1
PE
5281 * image.c (four_corners_best): Mark locals as initialized.
5282 (gif_load): Initialize transparent_p to zero (Bug#8238).
5283 Mark another local as initialized.
ec6cf4c6 5284 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5285
ce0ad53d 5286 * image.c (clear_image_cache): Now static.
d5d5a617 5287 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5288 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5289 (x_edge_detection): Remove unnecessary cast that
5290 gcc -Wbad-function-cast diagnoses.
2037898d 5291 (gif_load): Fix pointer signedness.
6ae141d6
PE
5292 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5293 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5294
33383987 52952011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5296
d32df629
PE
5297 Improve quality of tests for time stamp overflow.
5298 For example, without this patch (encode-time 0 0 0 1 1
5299 1152921504606846976) returns the obviously-bogus value (-948597
5300 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5301 reports time overflow. See
5302 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5303 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5304 * editfns.c: Include limits.h and intprops.h.
5305 (TIME_T_MIN, TIME_T_MAX): New macros.
5306 (time_overflow): Move earlier, to before first use.
5307 (hi_time, lo_time): New functions, for an accurate test for
5308 out-of-range times.
5309 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5310 (Fget_internal_run_time): Don't assume time_t fits in int.
5311 (make_time): Use list2 instead of Fcons twice.
5312 (Fdecode_time): More accurate test for out-of-range times.
5313 (check_tm_member): New function.
5314 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5315 (lisp_time_argument): Don't rely on undefined left-shift and
5316 right-shift behavior when checking for time stamp overflow.
8be6f318 5317
fe31d94c
PE
5318 * editfns.c (time_overflow): New function, refactoring common code.
5319 (Fformat_time_string, Fdecode_time, Fencode_time):
5320 (Fcurrent_time_string): Use it.
5321
8be6f318
PE
5322 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5323 * dired.c (make_time): Move to ...
5324 * editfns.c (make_time): ... here.
5325 * systime.h: Note the move.
5326
09d9db2c 53272011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5328
126bc0dc
YM
5329 * fringe.c (update_window_fringes): Remove unused variables.
5330
c47cbdfd
YM
5331 * unexmacosx.c (copy_data_segment): Also copy __got section.
5332 (Bug#8223)
5333
7ac80be9
EZ
53342011-03-12 Eli Zaretskii <eliz@gnu.org>
5335
c96bbc66 5336 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5337 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5338 Constify `char *' arguments and their references according to
5339 prototypes in tparam.h.
5340
ecb0f94d 5341 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5342
7ac80be9
EZ
5343 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5344 Adapt all references accordingly.
5345
5346 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5347
ef1fd07e
TT
53482011-03-11 Tom Tromey <tromey@redhat.com>
5349
5350 * buffer.c (syms_of_buffer): Remove obsolete comment.
5351
7ef4b50c
EZ
53522011-03-11 Eli Zaretskii <eliz@gnu.org>
5353
5354 * termhooks.h (encode_terminal_code): Declare prototype.
5355
5356 * msdos.c (encode_terminal_code): Don't declare prototype.
5357
5358 * term.c (encode_terminal_code): Now external again, used by
5359 w32console.c and msdos.c.
5360
44f230aa
SM
5361 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5362 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5363
4b1ec863 53642011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5365
1714f52b 5366 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5367
4b1ec863
PE
5368 * fringe.c (update_window_fringes): Mark locals as initialized
5369 (Bug#8227).
5370 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5371
524c7aa6
PE
5372 * alloc.c (mark_fringe_data): Move decl from here ...
5373 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5374 to check its interface.
5375 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5376
a5c0af81 5377 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5378 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5379 (fontset_font): Mark local as initialized.
a9a06e0b 5380 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5381
b4716021
PE
5382 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5383
811e9bac 5384 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5385 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5386 (x_own_selection, Fx_disown_selection_internal): Rename locals
5387 to avoid shadowing.
5388 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5389
7e3ab302
PE
5390 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5391 so that the caller can use some name other than gcpro1.
5392 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5393 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5394 (Fx_backspace_delete_keys_p):
5395 Use them to avoid shadowing, and rename vars to avoid shadowing.
5396 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5397 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5398 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5399 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5400 Remove unused locals.
7e3ab302
PE
5401 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5402 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5403 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5404 macros.
f78faa98 5405
e2b13473
PE
5406 * xterm.h (x_mouse_leave): New decl.
5407
77f23912
PE
5408 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5409 Remove unused functions.
cdf4ba58
PE
5410 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5411 (x_calc_absolute_position): Now static.
7411c686 5412 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5413 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5414 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5415 unless they are used.
38d0b34a
PE
5416 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5417 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5418 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5419 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5420 (x_error_catcher, x_connection_closed, x_error_handler):
5421 (x_error_quitter, xembed_send_message, x_iconify_frame):
5422 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5423 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5424 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5425
44f230aa
SM
5426 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5427 Rename or move locals to avoid shadowing.
6b463e58 5428 (tty_defined_color, merge_face_heights): Now static.
5967d051 5429 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5430 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5431 does not deduce is never used uninitialized.
73719eba
PE
5432 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5433 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5434
426994c3 5435 * terminal.c (store_terminal_param): Now static.
5489860b 5436
032f1620 5437 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5438 (set_frame_menubar): Remove unused local.
d4323972 5439 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5440 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5441 since they might point to immutable storage.
281585b0
PE
5442 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5443 since it's unused otherwise.
032f1620 5444
367c19e5 5445 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5446 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5447 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5448 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5449 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5450 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5451 does not deduce are never used uninitialized.
70739cbe 5452
07b48fa9
PE
5453 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5454
8868a238 5455 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5456 * window.c (window_loop, size_window):
5457 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5458
7e5cf297 5459 * window.c (display_buffer): Now static.
d6550a9f
PE
5460 (size_window): Mark variables that gcc -Wuninitialized
5461 does not deduce are never used uninitialized.
a586633d
PE
5462 * window.h (check_all_windows): New decl, to forestall
5463 gcc -Wmissing-prototypes diagnostic.
5b555da1 5464 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5465
f6095868
PE
5466 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5467 shadowing.
5468 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5469 Include <limits.h>.
5470 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5471 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5472 (load_charset_map): Mark variables that gcc -Wuninitialized
5473 does not deduce are never used uninitialized.
53df7c11 5474 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5475
f38b440c
PE
5476 * coding.c (coding_set_source, coding_set_destination):
5477 Use "else { /* comment */ }" rather than "else /* comment */;"
5478 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5479 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5480 a block, when the outer 'i' will do.
5481 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5482 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5483 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5484 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5485 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5486 Rename locals to avoid shadowing.
5487 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5488 * coding.c (emacs_mule_char, encode_invocation_designation):
5489 Now static, since they're not used elsewhere.
413bb2db 5490 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5491 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5492 (decode_coding_emacs_mule): Mark variables that gcc
5493 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5494 (detect_coding_iso_2022): Initialize a local variable that might
5495 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5496 this initialization is needed. (Bug#8211)
5f58e762
PE
5497 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5498 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5499 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5500 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5501 Remove unused macros.
f38b440c 5502
232b38b9 5503 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5504 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5505 * character.c (string_count_byte8): Likewise.
232b38b9 5506
fb90da1b
PE
5507 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5508 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5509
fb93dbc2
PE
5510 * chartab.c (copy_sub_char_table): Now static, since it's not used
5511 elsewhere.
5c156ace
PE
5512 (sub_char_table_ref_and_range, char_table_ref_and_range):
5513 Rename locals to avoid shadowing.
bbcd0949 5514 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5515
7d3b3862 5516 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5517 (BIDI_BOB): Remove unused macro.
7d3b3862 5518
6be7d3da
PE
5519 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5520 deduce are never used uninitialized.
c2ed9c8b 5521 * term.c (encode_terminal_code): Likewise.
6be7d3da 5522
75f8807f 5523 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5524
50938595
PE
5525 * tparam.h: New file.
5526 * term.c, tparam.h: Include it.
5527 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5528 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5529 Move these decls to tparam.h, and make them agree with what
5530 is actually in tparam.c. The previous trick of using incompatible
5531 decls in different modules does not conform to the C standard.
5532 All callers of tparam changed to use tparam's actual API.
5533 * tparam.c (tparam1, tparam, tgoto):
5534 Use const pointers where appropriate.
5535
fbceeba2
PE
5536 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5537 * cm.h (struct cm): Likewise.
5538 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5539 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5540 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5541 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5542 (turn_on_face, init_tty): Likewise.
5543 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5544
7f3f1250
PE
5545 * term.c (term_mouse_position): Rename local to avoid shadowing.
5546
e6ca6543
PE
5547 * alloc.c (mark_ttys): Move decl from here ...
5548 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5549
c40f8d15
AS
55502011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5551
5552 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5553
cfe0661d
JB
55542011-03-09 Juanma Barranquero <lekktu@gmail.com>
5555
5556 * search.c (compile_pattern_1): Remove argument regp, unused since
5557 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5558 (compile_pattern): Don't pass it.
5559
0afb4571
J
55602011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5561
5562 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5563 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5564 for ! HAVE_GTK3.
5565 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5566
5567 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5568
5569 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5570 gdk_window_get_screen, gdk_window_get_geometry,
5571 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5572 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5573 (xg_get_pixbuf_from_pixmap): New function.
5574 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5575 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5576 Call xg_get_pixbuf_from_pixmap instead of
5577 gdk_pixbuf_get_from_drawable.
5578 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5579 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5580 (xg_check_special_colors): Use GtkStyleContext and its functions
5581 for HAVE_GTK3.
5582 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5583 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5584 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5585 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5586 Call gtk_widget_get_preferred_size.
0afb4571
J
5587 (xg_frame_resized): gdk_window_get_geometry only takes 5
5588 parameters.
44f230aa
SM
5589 (xg_win_to_widget, xg_event_is_for_menubar):
5590 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5591 (xg_set_widget_bg): New function.
5592 (delete_cb): New function.
895009e1 5593 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5594 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5595 (xg_set_background_color): Call xg_set_widget_bg.
5596 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5597 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5598 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5599 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5600 if ! HAVE_GTK3.
5601 (update_frame_tool_bar): Call gtk_widget_hide.
5602 (xg_initialize): Use GDK_KEY_g.
5603
5604 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5605 if ! HAVE_GTK3
5606 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5607
5608 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5609 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5610 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5611
1c2cc4ef
JB
56122011-03-08 Juanma Barranquero <lekktu@gmail.com>
5613
5614 * w32xfns.c (select_palette): Check success of RealizePalette against
5615 GDI_ERROR, not zero.
5616
33383987 5617See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5618
5619;; Local Variables:
5620;; coding: utf-8
aac0c6e3
MR
5621;; End:
5622
33383987 5623 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5624
5625 This file is part of GNU Emacs.
5626
5627 GNU Emacs is free software: you can redistribute it and/or modify
5628 it under the terms of the GNU General Public License as published by
5629 the Free Software Foundation, either version 3 of the License, or
5630 (at your option) any later version.
5631
5632 GNU Emacs is distributed in the hope that it will be useful,
5633 but WITHOUT ANY WARRANTY; without even the implied warranty of
5634 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5635 GNU General Public License for more details.
5636
5637 You should have received a copy of the GNU General Public License
5638 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.