Speed up cursor motion in large fontified buffers.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e8c17b88
EZ
12011-07-19 Eli Zaretskii <eliz@gnu.org>
2
3 Fix a significant slow-down of vertical-motion when leaning on C-n
4 or C-p in a fontified buffer.
5 * xdisp.c (reseat): Don't look for prev_stop, as that could mean a
6 very long run.
7 (next_element_from_buffer): When iterator oversteps prev_pos
8 backwards, don't search for a new prev_stop more than 1000
9 characters back.
10 (handle_stop_backwards): Don't assume that CHARPOS is necessarily
11 a stop_pos.
12 (compute_display_string_pos): Check also BUF_OVERLAY_MODIFF for a
13 match, when testing the cached display string position for
14 applicability.
15
551918c1
EZ
162011-07-16 Eli Zaretskii <eliz@gnu.org>
17
18 * xdisp.c <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>:
19 Cache for last found display string position.
20 (compute_display_string_pos): Return the cached position if asked
21 about the same buffer.
22
c965adc5
EZ
232011-07-14 Eli Zaretskii <eliz@gnu.org>
24
25 * bidi.c (bidi_cache_fetch_state, bidi_cache_search)
26 (bidi_cache_find_level_change, bidi_cache_ensure_space)
27 (bidi_cache_iterator_state, bidi_cache_find)
28 (bidi_find_other_level_edge, bidi_cache_start_stack): All
29 variables related to cache indices are now EMACS_INT.
30
38556355
EZ
312011-07-09 Eli Zaretskii <eliz@gnu.org>
32
66ff7ddf
EZ
33 * bidi.c (bidi_fetch_char): Fix the type of `len' according to
34 what STRING_CHAR_AND_LENGTH expects.
35
38556355
EZ
36 * xdisp.c (move_it_in_display_line_to): Record prev_method and
37 prev_pos immediately before the call to set_iterator_to_next.
38 Fixes cursor motion in bidi-reordered lines with stretch glyphs
39 and strings displayed in margins. (Bug#8133) (Bug#8867)
40 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
41 TO_CHARPOS.
42 (pos_visible_p): Support positions in bidi-reordered lines. Save
43 and restore bidi cache.
44
452011-07-08 Eli Zaretskii <eliz@gnu.org>
46
47 * xdisp.c (move_it_in_display_line_to): If iterator ended up at
48 EOL, but we never saw any buffer positions smaller than
49 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
50 motion in bidi-reordered lines.
51
ad3c1639
EZ
522011-07-07 Eli Zaretskii <eliz@gnu.org>
53
54 * xdisp.c (find_row_edges): If ROW->start.pos gives position
55 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
56
57b3e30b
EZ
572011-07-05 Eli Zaretskii <eliz@gnu.org>
58
59 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
60 cache around display iteration.
61
62 * window.c (Fwindow_end, window_scroll_pixel_based)
63 (displayed_window_lines, Frecenter): Save and restore the bidi
64 cache around display iteration.
65
66 * bidi.c (bidi_unshelve_cache): Ensure we have enough space before
67 restoring the shelved cache.
68 (bidi_cache_ensure_space): Don't assume the required size is just
69 one BIDI_CACHE_CHUNK away.
70
71 * xdisp.c (back_to_previous_visible_line_start, reseat_1)
72 (init_iterator): Empty the bidi cache "stack".
73
ed94e6d7
EZ
742011-07-03 Eli Zaretskii <eliz@gnu.org>
75
76 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): New functions.
77
78 * dispextern.h (bidi_shelve_cache, bidi_unshelve_cache): Declare
79 prototypes.
80
81 * xdisp.c (SAVE_IT, RESTORE_IT): New macros.
82 (pos_visible_p, face_before_or_after_it_pos)
83 (back_to_previous_visible_line_start)
84 (move_it_in_display_line_to, move_it_in_display_line)
85 (move_it_to, move_it_vertically_backward, move_it_by_lines)
86 (try_scrolling, redisplay_window, display_line): Use them when
87 saving a temporary copy of the iterator and restoring it back.
88
a2eaa31d
EZ
892011-07-02 Eli Zaretskii <eliz@gnu.org>
90
6eec7596 91 * xdisp.c (reseat_1): Call bidi_init_it to resync the bidi
ad3c1639 92 iterator with IT's position. (Bug#7616)
6eec7596
EZ
93 (handle_stop, back_to_previous_visible_line_start, reseat_1):
94 Reset the from_disp_prop_p flag.
95
96 * bidi.c (bidi_cache_search): Don't assume bidi_cache_last_idx is
97 always valid if bidi_cache_idx is valid.
98 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
99 is valid if it's going to be used.
100
a2eaa31d
EZ
101 * dispextern.h (struct iterator_stack_entry, struct it): New
102 member from_disp_prop_p.
103
104 * xdisp.c (push_it, pop_it): Save and restore from_disp_prop_p.
105 (handle_single_display_spec, push_display_prop): Set the
106 from_disp_prop_p flag.
107 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
108 (pop_it): Call iterate_out_of_display_property only if we are
109 popping after iteration over a string that came from a display
110 property. Fix a typo in popping stretch info. Add an assertion
111 for verifying that the iterator position is in sync with the bidi
112 iterator.
113 (handle_single_display_spec, get_overlay_strings_1)
114 (push_display_prop): Fix initialization of paragraph direction for
115 string when that of the parent object is not yet determined.
116
f3014ef5
EZ
1172011-07-01 Eli Zaretskii <eliz@gnu.org>
118
119 * dispextern.h (struct bidi_string_data): New member `unibyte'.
120
121 * xdisp.c (handle_single_display_spec, next_overlay_string)
122 (get_overlay_strings_1, reseat_1, reseat_to_string)
123 (push_display_prop): Set up the `unibyte' member of bidi_it.string
124 correctly. Don't assume unibyte strings are not bidi-reordered.
125 (compute_display_string_pos)
126 (compute_display_string_end): Fix handling the case of C string.
127
128 * bidi.c (bidi_count_bytes, bidi_char_at_pos): Accept an
129 additional argument UNIBYTE, and support unibyte strings. All
130 callers changed.
131 (bidi_fetch_char): Support unibyte strings.
132
0c22566f
EZ
1332011-06-25 Eli Zaretskii <eliz@gnu.org>
134
a1344e7d
EZ
135 * xdisp.c (set_iterator_to_next, get_visually_first_element): Use
136 it->bidi_it.string.schars rather than it->string_nchars when
137 testing whether we're beyond string end, because string_nchars is
138 zero for strings that come from overlays and display properties.
139
140 * bidi.c (bidi_cache_iterator_state): Fix a bug with testing
141 character positions against the cached range, when we use a
142 stacked cache.
143
144 * xdisp.c (push_it, pop_it): Save and restore it.
145
146 * dispextern.h (struct iterator_stack_entry): New member
147 paragraph_embedding.
148
0c22566f
EZ
149 * xdisp.c (handle_single_display_spec, next_overlay_string)
150 (get_overlay_strings_1, push_display_prop): Set up the bidi
151 iterator for displaying display or overlay strings.
152 (forward_to_next_line_start): Don't use the shortcut if
153 bidi-iterating.
154 (back_to_previous_visible_line_start): If handle_display_prop
155 pushed the iterator stack, restore the internal state of the bidi
156 iterator by calling bidi_pop_it same number of times.
157 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
158 and we are bidi-iterating, don't decrement the iterator position;
159 instead, set the first_elt flag in the bidi iterator, to produce
160 the same effect.
161 (reseat_1): Remove redundant setting of string_from_display_prop_p.
162 (push_display_prop): xassert that we are iterating a buffer.
163
164 * bidi.c (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
165
1662011-06-24 Eli Zaretskii <eliz@gnu.org>
167
168 * xdisp.c (push_it, pop_it): Save and restore the state of the
169 bidi iterator. Save and restore the bidi_p flag.
170 (pop_it): Iterate out of display property for string iteration as
171 well.
172 (iterate_out_of_display_property): Support iteration over strings.
173 (handle_single_display_spec): Set up it->bidi_it for iteration
174 over a display string, and call bidi_init_it.
175
176 * dispextern.h (struct iterator_stack_entry): New member bidi_p.
177 (struct it): Member bidi_p is now a bit field 1 bit wide.
178
58b9f433
EZ
1792011-06-23 Eli Zaretskii <eliz@gnu.org>
180
181 * dispextern.h (bidi_push_it, bidi_pop_it): Add prototypes.
182
183 * bidi.c (bidi_push_it, bidi_pop_it): New functions.
184 (bidi_initialize): Initialize the bidi cache start stack pointer.
185 (bidi_cache_ensure_space): New function, refactored from part of
186 bidi_cache_iterator_state.
187
40eb66c4
EZ
1882011-06-18 Eli Zaretskii <eliz@gnu.org>
189
acb28818
EZ
190 * xdisp.c (tool_bar_lines_needed, redisplay_tool_bar)
191 (display_menu_bar): Force left-to-right direction. Add a FIXME
192 comment for making that be controlled by a user option.
193
194 * bidi.c (bidi_move_to_visually_next): GCPRO the Lisp string we
195 are iterating.
196
ca3122a0
EZ
197 * term.c (produce_glyphs): Add IT_GLYPHLESS to the values of
198 it->what accepted by the xassert. Fixes a gratuitous crash in an
199 Emacs built with -DXASSERTS.
200
cc7245e4
EZ
201 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
202 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
203 and vector-like objects.
204
4d3a8bb4 205 * xdisp.c (face_before_or_after_it_pos): Support bidi iteration.
40eb66c4
EZ
206 (next_element_from_c_string): Handle the case of the first string
207 character that is not the first one in the visual order.
1ace7267
EZ
208 (get_visually_first_element): New function, refactored from common
209 parts of next_element_from_buffer, next_element_from_string, and
210 next_element_from_c_string.
40eb66c4 211
578b494e
EZ
2122011-06-16 Eli Zaretskii <eliz@gnu.org>
213
214 * xdisp.c (init_iterator): Don't initialize it->bidi_p for strings
215 here.
216 (reseat_to_string): Initialize it->bidi_p for strings here.
217 (next_element_from_string, next_element_from_c_string)
218 (next_element_from_buffer): Add xassert's for correspondence
219 between IT's object being iterated and it->bidi_it.string
220 structure.
221
222 * bidi.c (bidi_level_of_next_char): Fix the logic for looking up
223 the sentinel state in the cache.
224
9f257352
EZ
2252011-06-13 Eli Zaretskii <eliz@gnu.org>
226
227 * xdisp.c (compute_display_string_pos)
228 (compute_display_string_end, reseat_to_string): Don't assume
229 it->bidi_it.string.s always points to string.lstring's data.
230
231 * bidi.c (bidi_fetch_char, bidi_paragraph_init)
232 (bidi_resolve_explicit_1, bidi_resolve_explicit)
233 (bidi_resolve_weak, bidi_level_of_next_char): Don't assume
234 string.s always points to string.lstring's data.
235
f23590cc
EZ
2362011-06-11 Eli Zaretskii <eliz@gnu.org>
237
238 * xdisp.c (set_iterator_to_next): Advance string position
239 correctly when padding it with blanks.
240
4b988f8b
EZ
2412011-06-11 Eli Zaretskii <eliz@gnu.org>
242
243 * xdisp.c (next_element_from_buffer): Improve commentary for when
244 the iterator is before prev_stop.
34c48e57
EZ
245 (init_iterator): Initialize bidi_p from the default value of
246 bidi-display-reordering, not from buffer-local value. Use the
247 buffer-local value only if initializing for buffer iteration.
248 (handle_invisible_prop): Support invisible properties on strings
249 that are being bidi-reordered.
250 (reseat_to_string): Enable bidi-related code.
251 (set_iterator_to_next): Support bidi reordering of C strings and
252 Lisp strings.
253 (next_element_from_string): Support bidi reordering of Lisp
254 strings.
255 (handle_stop_backwards): Support Lisp strings as well.
256 (display_mode_line, display_mode_element): Temporarily force L2R
257 paragraph direction.
258 (display_string): Support display of R2L glyph rows. Use
259 IT_STRING_CHARPOS when displaying from a Lisp string.
4b988f8b 260
9f4ef500
EZ
2612011-06-10 Eli Zaretskii <eliz@gnu.org>
262
263 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
264 itb.string.lstring.
265 (compute_display_string_pos, compute_display_string_end):
266 Fix calculation of the object to scan. Fixes an error when using
267 arrow keys.
268 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
269 base_level_stop; instead, set base_level_stop to BEGV. Fixes
270 crashes in vertical-motion.
271
6db161be
EZ
2722011-06-09 Eli Zaretskii <eliz@gnu.org>
273
274 * xdisp.c (compute_display_string_pos): First arg is now struct
275 `text_pos *'; all callers changed. Support display properties on
276 Lisp strings.
277 (compute_display_string_end): Support display properties on Lisp
278 strings.
279 (init_iterator, reseat_1, reseat_to_string): Initialize the
280 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
281 when iterating on a string not from display properties).
282
283 * bidi.c (bidi_fetch_char): Support strings with display
284 properties.
285
286 * dispextern.h (struct bidi_string_data): New member bufpos.
287 (compute_display_string_pos): Update prototype.
288
bb269206
EZ
2892011-06-09 Eli Zaretskii <eliz@gnu.org>
290
291 * bidi.c (bidi_level_of_next_char): Allow the sentinel "position"
292 to pass the test for valid cached positions.
293
294 * xdisp.c (init_iterator): Call bidi_init_it only of a valid
295 buffer position was specified. Initialize paragraph_embedding to
296 L2R.
297 (reseat_to_string): Initialize the bidi iterator (for now ifdef'ed
298 out).
299 (display_string): If we need to ignore text properties of
300 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
301 original value of -1 will not work with bidi.)
302
303 * dispextern.h (struct bidi_string_data): New member lstring.
304
d9334cb7
EZ
3052011-06-09 Eli Zaretskii <eliz@gnu.org>
306
307 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
308 itb.string.s to NULL (avoids a crash in bidi_paragraph_init).
309
87e67904
EZ
3102011-06-08 Eli Zaretskii <eliz@gnu.org>
311
312 * bidi.c (bidi_paragraph_info): Delete unused struct.
313 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
314 (bidi_cache_start): New variable.
315 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
316 to zero.
317 (bidi_cache_fetch_state, bidi_cache_search)
318 (bidi_cache_find_level_change, bidi_cache_iterator_state)
319 (bidi_cache_find, bidi_peek_at_next_level)
320 (bidi_level_of_next_char, bidi_find_other_level_edge)
321 (bidi_move_to_visually_next): Compare cache index with
322 bidi_cache_start rather than with zero.
323 (bidi_fetch_char): Accept new argument STRING; all callers
324 changed. Support iteration over a string.
325 (bidi_paragraph_init, bidi_resolve_explicit_1)
326 (bidi_resolve_explicit, bidi_resolve_weak)
327 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
328 iteration over a string.
329 (bidi_set_sor_type, bidi_resolve_explicit_1)
330 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
331 can now be zero (for strings); special values 0 and -1 were
332 changed to -1 and -2, respectively.
333 (bidi_char_at_pos): New function.
334 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
335 Call it instead of FETCH_MULTIBYTE_CHAR.
336 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
337 initialized to valid values.
338 (bidi_init_it): Don't initialize charpos and bytepos with invalid
339 values.
340
341 * xdisp.c (compute_display_string_pos)
342 (compute_display_string_end): Accept additional argument STRING.
343 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
344 (reseat_to_string): Initialize bidi_it->string.s and
345 bidi_it->string.schars.
346
347 * dispextern.h (struct bidi_string_data): New structure.
348 (struct bidi_it): New member `string'. Make flag members be 1-bit
349 fields, and put them last in the struct.
350 (compute_display_string_pos, compute_display_string_end): Update
351 prototypes.
352
9d68c2a9
EZ
3532011-06-04 Eli Zaretskii <eliz@gnu.org>
354
355 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
356
57f97249
EZ
3572011-06-03 Eli Zaretskii <eliz@gnu.org>
358
359 * bidi.c (bidi_fetch_char_advance): Remove unused and
360 unimplemented function.
361
c40e2fb2
EZ
3622011-05-28 Eli Zaretskii <eliz@gnu.org>
363
0e14fe90
EZ
364 * xdisp.c (set_cursor_from_row): Set start and stop points
365 according to the row's direction when priming the loop that looks
366 for the glyph on which to display cursor.
367 (single_display_spec_intangible_p): Function deleted.
368 (display_prop_intangible_p): Reimplement to call
369 handle_display_spec instead of single_display_spec_intangible_p.
370 Accept 3 additional arguments needed by handle_display_spec. This
371 fixes incorrect cursor motion across display property with complex
372 values: lists, `(when COND...)' forms, etc.
373 (single_display_spec_string_p): Support property values that are
374 lists with the argument STRING its top-level element.
375 (display_prop_string_p): Fix the condition for processing a
376 property that is a list to be consistent with handle_display_spec.
377
378 * keyboard.c (adjust_point_for_property): Adjust the call to
379 display_prop_intangible_p to its new signature.
380
381 * dispextern.h (display_prop_intangible_p): Adjust prototype.
c40e2fb2 382
fc6f18ce
EZ
3832011-05-21 Eli Zaretskii <eliz@gnu.org>
384
385 * xdisp.c (handle_display_spec): New function, refactored from the
386 last portion of handle_display_prop.
387 (compute_display_string_pos): Accept additional argument
388 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
389 value of a `display' property is a "replacing spec".
390 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
391 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
392 the display property, but just return a value indicating whether
393 the display property will replace the characters it covers.
394 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
395 frame_window_p members of struct bidi_it.
396
397 * bidi.c (bidi_fetch_char): Accept additional argument
398 FRAME_WINDOW_P and pass it to compute_display_string_pos. All
399 callers changed.
400 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
401 it to initialize the frame_window_p member of struct bidi_it.
402
403 * dispextern.h (struct bidi_it): New member frame_window_p.
404 (bidi_init_it, compute_display_string_pos): Update prototypes.
405
102ebb00
EZ
4062011-05-14 Eli Zaretskii <eliz@gnu.org>
407
7b600102
EZ
408 * xdisp.c (compute_display_string_pos): Non-trivial implementation.
409 (compute_display_string_end): New function.
683a44f7
EZ
410 (push_it): Accept second argument POSITION, where pop_it should
411 jump to continue iteration.
7b600102
EZ
412
413 * dispextern.h (compute_display_string_end): Declare prototype.
414
415 * bidi.c (bidi_resolve_explicit_1): Use ZV for disp_pos.
416 (bidi_fetch_char): Implement support for runs of characters
417 covered by display strings.
418
102ebb00 419 * bidi.c (bidi_fetch_char): Accept also character position
7b600102
EZ
420 corresponding to BYTEPOS. DISP_POS is now a character position,
421 not a byte position. All callers changed.
102ebb00
EZ
422 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
423 (bidi_resolve_explicit, bidi_resolve_weak)
424 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
425 bidi_it->nchars is non-positive.
426 (bidi_level_of_next_char): Don't try to lookup the cache for the
427 next/previous character if nothing is cached there yet, or if we
428 were just reseat()'ed to a new position.
429 (bidi_paragraph_init, bidi_resolve_explicit_1)
430 (bidi_level_of_next_char): Fix arguments in the calls to
431 bidi_fetch_char.
432
182ce2d2
EZ
4332011-05-10 Eli Zaretskii <eliz@gnu.org>
434
435 * xdisp.c (compute_display_string_pos): New function.
436 (reseat_1): Initialize bidi_it.disp_pos.
437
438 * bidi.c (bidi_copy_it): Use offsetof.
439 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
440 (bidi_cache_search, bidi_cache_iterator_state)
441 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
442 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
443 character positions inside a run of characters covered by a
444 display string.
445 (bidi_paragraph_init, bidi_resolve_explicit_1)
446 (bidi_level_of_next_char): Call bidi_fetch_char and
447 bidi_fetch_char_advance instead of FETCH_CHAR and
448 FETCH_CHAR_ADVANCE.
449 (bidi_init_it): Initialize new members.
450 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
451 definitions.
452 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
453 instead of using explicit *_CHAR codes.
454 (bidi_resolve_explicit, bidi_resolve_weak): Use
455 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
456 bidirectional text is supported only in multibyte buffers.
457
458 * dispextern.h (struct bidi_it): New members nchars and disp_pos.
459 ch_len is now EMACS_INT.
460 (compute_display_string_pos): Declare prototype.
461
57679c86
AS
4622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
463
464 * w32menu.c (set_frame_menubar): Fix submenu allocation.
465
888c9e86
EZ
4662011-05-07 Eli Zaretskii <eliz@gnu.org>
467
b0512a1d
EZ
468 * w32console.c (Fset_screen_color): Doc fix.
469 (Fget_screen_color): New function.
470 (syms_of_ntterm): Defsubr it.
471
888c9e86
EZ
472 * callproc.c (call_process_cleanup): Don't close and unlink the
473 temporary file if Fcall_process didn't create it in the first
474 place.
475 (Fcall_process): Don't create tempfile if stdout of the child
476 process will be redirected to a file specified with `:file'.
477 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
478 cue to call_process_cleanup not to close that handle.
479
4d3fcc8e
BK
4802011-05-07 Ben Key <bkey76@gmail.com>
481
482 * makefile.w32-in: The bootstrap-temacs rule now makes use of
483 one of two shell specific rules, either bootstrap-temacs-CMD or
484 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
485 to the previous implementation of the bootstrap-temacs rule.
486 The bootstrap-temacs-CMD rule is similar to the previous
487 implementation of the bootstrap-temacs rule except that it
488 makes use of the ESC_CFLAGS variable instead of the CFLAGS
489 variable.
490
491 These changes, along with some changes to nt/configure.bat,
492 nt/gmake.defs, and nt/nmake.defs, are required to extend my
493 earlier fix to add support for --cflags and --ldflags options
494 that include quotes so that it works whether make uses cmd or
495 sh as the shell.
496
b4289b64
MA
4972011-05-06 Michael Albinus <michael.albinus@gmx.de>
498
499 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
500 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
501 is a constant.
502 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
503 a string. Handle both cases.
504 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
505 (Fdbus_register_method): Use Qinvalid_function.
506
af4c0e28
JB
5072011-05-06 Juanma Barranquero <lekktu@gmail.com>
508
509 * makefile.w32-in: Update dependencies.
510 (LISP_H): Add inttypes.h and stdin.h.
511 (PROCESS_H): Add unistd.h.
512
c51453d9
EZ
5132011-05-06 Eli Zaretskii <eliz@gnu.org>
514
515 * lread.c: Include limits.h (fixes the MS-Windows build broken by
516 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
517
8ff0ac3c 5182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 519
4c4b566b
PE
520 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
521
aab2b9b5
PE
522 * term.c (vfatal): Remove stray call to va_end.
523 It's not needed and the C Standard doesn't allow it here anyway.
524
c378da0b
PE
525 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
526 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
527
288b08c7
PE
528 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
529 bytes.
530
e3601888
PE
531 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
532
db6c0e74
PE
533 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
534
dd5963ea
PE
535 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
536
88c9450f
PE
537 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
538
2f9442b8
PE
539 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
540
c032b5f8
PE
541 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
542 * charset.c (Fdefine_charset_internal): Don't initialize
543 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 544 32-bit int (Bug#8600).
a108c10b
PE
545
546 * lread.c (read_integer): Be more consistent with string-to-number.
547 Use string_to_number to do the actual conversion; this avoids
548 rounding errors and fixes some other screwups. Without this fix,
549 for example, #x1fffffffffffffff was misread as -2305843009213693952.
550 (digit_to_number): Move earlier, for benefit of read_integer.
551 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 552 not a digit in any supported base. (Bug#8602)
a108c10b 553
ad5f9eea
PE
554 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
555
aec1708a
PE
556 * dispnew.c (scrolling_window): Return 1 if we scrolled,
557 to match comment at start of function. This also removes a
558 GCC warning about overflow in a 32+64-bit port.
559
47be4ab5
PE
560 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
561
371cac43
PE
562 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
563 Reported by Stefan Monnier in
564 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
565 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
566 SYMBOLP-guarded XSYMBOL, not XPNTR.
567
d01a7826
PE
568 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
569 (EMACS_UINTPTR): Likewise, with uintptr_t.
570
7fd47d5c
PE
571 * lisp.h: Prefer 64-bit EMACS_INT if available.
572 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
573 on 32-bit hosts that have 64-bit int, so that they can access
574 large files.
122b0c86
PE
575 However, temporarily disable this change unless the temporary
576 symbol WIDE_EMACS_INT is defined.
7fd47d5c 577
8727937b
PE
578 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
579
8ac068ac
PE
580 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
581 This removes an assumption that EMACS_INT and long are the same
582 width as pointers. The assumption is true for Emacs porting targets
583 now, but we want to make other targets possible.
584 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
585 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
586 In the rest of the code, change types of integers that hold casted
587 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
588 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
589 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
590 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
591 No need to cast type when ORing.
592 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
593 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
594 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
595 assume EMACS_INT is the same width as char *.
596 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
597 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
598 Remove no-longer-needed casts.
599 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
600 (xg_tool_bar_help_callback, xg_make_tool_item):
601 Use EMACS_INTPTR to hold an integer
602 that will be cast to void *; this can avoid a GCC warning
603 if EMACS_INT is not the same width as void *.
604 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
605 * xdisp.c (display_echo_area_1, resize_mini_window_1):
606 (current_message_1, set_message_1):
607 Use a local to convert to proper width without a cast.
608 * xmenu.c (dialog_selection_callback): Likewise.
609
ede49d71
PE
610 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
611 Also, don't assume VALBITS / RAND_BITS is less than 5,
612 and don't rely on undefined behavior when shifting a 1 left into
613 the sign bit.
614 * lisp.h (get_random): Change signature to match.
615
2f30ecd0
PE
616 * lread.c (hash_string): Use size_t, not int, for hash computation.
617 Normally we prefer signed values; but hashing is special, because
618 it's better to use unsigned division on hash table sizes so that
619 the remainder is nonnegative. Also, size_t is the natural width
620 for hashing into memory. The previous code used 'int', which doesn't
621 retain enough info to hash well into very large tables.
622 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
623
2a866e7b
PE
624 * dbusbind.c: Don't possibly lose pointer info when converting.
625 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
626 Use XPNTR rather than XHASH, so that the high-order bits of
627 the pointer aren't lost when converting through void *.
628
51639eac
PE
629 * eval.c (Fautoload): Don't double-shift a pointer.
630
92394119
PE
631 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
632
dbdb9a7c
JB
6332011-05-06 Juanma Barranquero <lekktu@gmail.com>
634
635 * gnutls.c (DEF_GNUTLS_FN):
636 * image.c (DEF_IMGLIB_FN): Make function pointers static.
637
db7a0b4f
AS
6382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
639
640 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
641 marker. (Bug#8610)
642
f7ff1b0f 6432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
644
645 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
646 New version that can reserve upto 2GB of heap space.
647
f7ff1b0f 6482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
649
650 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
651
639c109b
TZ
6522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
653
654 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
655 `gnutls_certificate_set_x509_key_file'.
656
d2127135
JB
6572011-05-05 Juanma Barranquero <lekktu@gmail.com>
658
659 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
660 Update dependencies.
661
e968f4f3
JB
6622011-05-04 Juanma Barranquero <lekktu@gmail.com>
663
664 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
665 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
666 Remove unused parameter `fildes'.
667 * process.c (read_process_output, send_process): Don't pass it.
668
84d358f0
JB
6692011-05-04 Juanma Barranquero <lekktu@gmail.com>
670
671 Fix previous change: the library cache is defined in w32.c.
672 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
673 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
674
0898ca10
JB
6752011-05-04 Juanma Barranquero <lekktu@gmail.com>
676
677 Implement dynamic loading of GnuTLS on Windows.
678
679 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
680 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
681 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
682 Declare.
683
684 * gnutls.c (Qgnutls_dll): Define.
685 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
686 (gnutls_*): Declare function pointers.
687 (init_gnutls_functions): New function to initialize function pointers.
688 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
689 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
690 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
691 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
692 (emacs_gnutls_write, emacs_gnutls_read)
693 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
694 (Fgnutls_available_p): New function.
695 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
696 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
697 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
698
699 * image.c: Include w32.h.
700 (Vimage_type_cache): Delete.
701 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
702 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
703 (w32_delayed_load): Move to w32.c.
704
705 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
706
707 * w32.c (QCloaded_from, Vlibrary_cache): Define.
708 (w32_delayed_load): Move from image.c. When loading a library, record
709 its filename in the :loaded-from property of the library id.
710 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
711 Initialize and staticpro them.
712 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
713
714 * process.c: Include lisp.h before w32.h, not after.
715 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
716 instead of gnutls_record_check_pending.
717
718 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
719
ff4de4aa
TZ
7202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
721
722 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
723 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
724 as passed in.
725
abe95abb
JD
7262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
727
728 * xterm.c (x_set_frame_alpha): Do not set property on anything
729 else than FRAME_X_OUTER_WINDOW (Bug#8608).
730
e16e55d4
JB
7312011-05-02 Juanma Barranquero <lekktu@gmail.com>
732
733 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
734
bafcf6a5
JB
7352011-05-02 Juanma Barranquero <lekktu@gmail.com>
736
737 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
738 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
739 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
740 (gnutls_global_initialized, Qgnutls_bootprop_priority)
741 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
742 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
743 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
744 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
745 (Qgnutls_bootprop_callbacks_verify): Make static.
746
e7a6747f
AS
7472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
748
19ed11ba
AS
749 * callproc.c: Indentation fixup.
750
e7a6747f
AS
751 * sysdep.c (wait_for_termination_1): Make static.
752 (wait_for_termination, interruptible_wait_for_termination): Move
753 after wait_for_termination_1.
754
1ef14cb4
LMI
7552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
756
757 * sysdep.c (interruptible_wait_for_termination): New function
758 which is like wait_for_termination, but allows keyboard
759 interruptions.
760
761 * callproc.c (Fcall_process): Add (:file "file") as an option for
762 the STDOUT buffer.
763 (Fcall_process_region): Ditto.
764
330d880c
EZ
7652011-04-30 Eli Zaretskii <eliz@gnu.org>
766
8db90b73
EZ
767 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
768 rather than `XVECTOR (FOO)->size'.
769
330d880c
EZ
770 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
771 inttypes.h, as a gnulib replacement is used if it not available in
772 system headers.
773
15cbd324
EZ
7742011-04-21 Eli Zaretskii <eliz@gnu.org>
775
776 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
777 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
778 of MOST_POSITIVE_FIXNUM. (Bug#8528)
779
780 * coding.c (coding_alloc_by_realloc): Error out if destination
781 will grow beyond MOST_POSITIVE_FIXNUM.
782 (decode_coding_emacs_mule): Abort if there isn't enough place in
783 charbuf for the composition carryover bytes. Reserve an extra
784 space for up to 2 characters produced in a loop.
785 (decode_coding_iso_2022): Abort if there isn't enough place in
786 charbuf for the composition carryover bytes.
787
7882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 789
ae940cca
EZ
790 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
791 aborting when %lld or %lll format is passed.
792 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
793 %llo or %llx format is passed. (Bug#8545)
794
03ab8921
EZ
795 * window.c (window_scroll_line_based): Use a marker instead of
796 simple variables to record original value of point. (Bug#7952)
797
afda1437
EZ
798 * doprnt.c (doprnt): Fix the case where a multibyte sequence
799 produced by %s or %c overflows available buffer space. (Bug#8545)
800
f76dee0c
PE
8012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
802
803 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 804 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 805
fdc5744d
JB
8062011-04-28 Juanma Barranquero <lekktu@gmail.com>
807
808 * w32.c (init_environment): Warn about defaulting HOME to C:\.
809
638f053a
JB
8102011-04-28 Juanma Barranquero <lekktu@gmail.com>
811
812 * keyboard.c (Qdelayed_warnings_hook): Define.
813 (command_loop_1): Run `delayed-warnings-hook'
814 if Vdelayed_warnings_list is non-nil.
815 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
816 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
817
d178f871
EZ
8182011-04-28 Eli Zaretskii <eliz@gnu.org>
819
820 * doprnt.c (doprnt): Don't return value smaller than the buffer
821 size if the message was truncated. (Bug#8545).
822
b124fd93
JB
8232011-04-28 Juanma Barranquero <lekktu@gmail.com>
824
825 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
826 (Fx_window_property): #if-0 the whole functions, not just the bodies.
827
e810457d
PE
8282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
829
830 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
831
ea51cceb
JB
8322011-04-27 Juanma Barranquero <lekktu@gmail.com>
833
834 * makefile.w32-in: Update dependencies.
835
94dcfacf
EZ
8362011-04-27 Eli Zaretskii <eliz@gnu.org>
837
838 Improve `doprnt' and its usage. (Bug#8545)
839 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
840 `format_end'. Remove support for %l as a conversion specifier.
841 Don't use xrealloc. Improve diagnostics when the %l size modifier
842 is used. Update the commentary.
843
844 * eval.c (verror): Simplify calculation of size_t.
845
846 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
847 messages.
848
f61f41d7
PE
8492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
850
851 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
852 change.
853
96fb4434
PE
8542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
855
856 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
857 This makes this file independent of the recent pseudovector change.
858
671875da 8592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 860
69e9b5a3
PE
861 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
862
b5f869a7 863 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 864 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 865 Remove unused local.
c8926152 866 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 867
841a1577 868 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
869 GCC 4.6.0 optimizes based on type-based alias analysis. For
870 example, if b is of type struct buffer * and v of type struct
871 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
872 != &v->size, and therefore "v->size = 1; b->size = 2; return
873 v->size;" must therefore return 1. This assumption is incorrect
874 for Emacs, since it type-puns struct Lisp_Vector * with many other
875 types. To fix this problem, this patch adds a new type struct
f904488f 876 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
877 and pseudovectors, and helps optimizing compilers not get fooled
878 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
879 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
880 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
881 the size member.
eab3844f
PE
882 (XSETPVECTYPE): Rewrite in terms of new macro.
883 (XSETPVECTYPESIZE): New macro, specifying both type and size.
884 This is a bit clearer, and further avoids the possibility of
885 undesirable aliasing.
886 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 887 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
888 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
889 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
890 (ASIZE): Now uses header.size rather than size. All
891 previous uses of XVECTOR (foo)->size replaced to use this macro,
892 to avoid the hassle of writing XVECTOR (foo)->header.size.
893 (struct vectorlike_header): New type.
eab3844f
PE
894 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
895 object, to help avoid aliasing.
896 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
897 (SUBRP): Likewise, since Lisp_Subr is a special case.
898 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
899 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
900 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 901 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
902 changed to be "header.size" and "header.next".
903 * buffer.h (struct buffer): Likewise.
904 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
905 * frame.h (struct frame): Likewise.
906 * process.h (struct Lisp_Process): Likewise.
907 * termhooks.h (struct terminal): Likewise.
908 * window.c (struct save_window_data, struct saved_window): Likewise.
909 * window.h (struct window): Likewise.
910 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
911 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
912 * buffer.c (init_buffer_once): Likewise.
913 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
914 special case.
915 * process.c (Fformat_network_address): Use local var for size,
916 for brevity.
917
0df1eac5
PE
918 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
919
847ab9d1 920 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
921 * data.c (atof): Remove decl; no longer used or needed.
922 (digit_to_number): Move to lread.c.
923 (Fstring_to_number): Use new string_to_number function, to be
924 consistent with how the Lisp reader treats infinities and NaNs.
925 Do not assume that floating-point numbers represent EMACS_INT
926 without losing information; this is not true on most 64-bit hosts.
927 Avoid double-rounding errors, by insisting on integers when
928 parsing non-base-10 numbers, as the documentation specifies.
929 * lisp.h (string_to_number): New decl, replacing ...
930 (isfloat_string): Remove.
bc0a5c13 931 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 932 (read1): Do not accept +. and -. as integers; this
452f4150
PE
933 appears to have been a coding error. Similarly, do not accept
934 strings like +-1e0 as floating point numbers. Do not report
935 overflow for integer overflows unless the base is not 10 which
936 means we have no simple and reliable way to continue.
937 Break out the floating-point parsing into a new
938 function string_to_number, so that Fstring_to_number parses
939 floating point numbers consistently with the Lisp reader.
940 (digit_to_number): Moved here from data.c. Make it static inline.
941 (E_CHAR, EXP_INT): Remove, replacing with ...
942 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
943 (string_to_number): New function, replacing isfloat_string.
944 This function checks for valid syntax and produces the resulting
945 Lisp float number too. Rework it so that string-to-number
bc0a5c13 946 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
947 so that overflow for non-base-10 numbers is reported only when
948 there's no portable and simple way to convert to floating point.
452f4150 949
67769ffc
PE
950 * textprop.c (set_text_properties_1): Rewrite for clarity,
951 and to avoid GCC warning about integer overflow.
952
c20db43f
PE
953 * intervals.h (struct interval): Use EMACS_INT for members
954 where EMACS_UINT might cause problems. See
955 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
956 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
957 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
958 All uses changed.
37aa2f85
PE
959 (offset_intervals): Tell GCC not to worry about length overflow
960 when negating a negative length.
c20db43f 961
2538aa2f
PE
962 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
963 (overrun_check_free): Likewise.
964
f2d3008d
PE
965 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
966 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
967 word size.
968
ec8df744
PE
969 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
970 (gnutls_make_error): Rename local to avoid shadowing.
971 (gnutls_emacs_global_deinit): ifdef out; not used.
972 (Fgnutls_boot): Use const for pointer to readonly storage.
973 Comment out unused local. Fix pointer signedness problems.
974
640ee02d
PE
975 * lread.c (openp): Don't stuff size_t into an 'int'.
976 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
977 about possible signed overflow.
978
6048fb2a
PE
979 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
980 (GDK_KEY_g): Don't define if already defined.
981 (xg_prepare_tooltip): Avoid pointer signedness problem.
982 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
983
fa3c87e1
PE
984 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
985 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
986
2172544b
PE
987 * xfns.c (Fx_window_property): Simplify a bit,
988 to make a bit faster and to avoid GCC 4.6.0 warning.
989 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
990
9b821a21
PE
991 * fns.c (internal_equal): Don't assume size_t fits in int.
992
3c616cfa
PE
993 * alloc.c (compact_small_strings): Tighten assertion a little.
994
c2982e87
PE
995 Replace pEd with more-general pI, and fix some printf arg casts.
996 * lisp.h (pI): New macro, generalizing old pEd macro to other
997 conversion specifiers. For example, use "...%"pI"d..." rather
998 than "...%"pEd"...".
999 (pEd): Remove. All uses replaced with similar uses of pI.
1000 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1001 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1002 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1003 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1004 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1005 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1006 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1007 64-bit hosts.
1008 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1009 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1010 * print.c (safe_debug_print, print_object): Likewise.
1011 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1012 to int.
6f04d126
PE
1013 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1014 avoiding the 0 flag, which is not portable.
c2982e87
PE
1015 * process.c (Fmake_network_process): Use pI to avoid cast.
1016 * region-cache.c (pp_cache): Likewise.
1017 * xdisp.c (decode_mode_spec): Likewise.
1018 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1019 behavior on 64-bit hosts with printf arg.
6f04d126 1020 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1021 (x_stop_queuing_selection_requests): Likewise.
1022 (x_get_window_property): Don't truncate byte count to an 'int'
1023 when tracing.
0b432f21 1024
5e073ec7
PE
1025 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1026 here, since it parses constructs like leading '-' and spaces,
1027 which are not wanted; and it overflows with large numbers.
1028 Instead, simply match F[0-9]+, which is what is wanted anyway.
1029
36372bf9
PE
1030 * alloc.c: Remove unportable assumptions about struct layout.
1031 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1032 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1033 (allocate_vectorlike, make_pure_vector): Use the new macros,
1034 plus offsetof, to remove unportable assumptions about struct layout.
1035 These assumptions hold on all porting targets that I know of, but
1036 they are not guaranteed, they're easy to remove, and removing them
1037 makes further changes easier.
1038
0b432f21
PE
1039 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1040 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1041 (string_overrun_cookie): Now const. Use initializers that
1042 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1043 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1044 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1045 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1046 multiple of sizeof (EMACS_INT); it need not be, if
1047 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1048 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1049
895009e1
JB
10502011-04-26 Juanma Barranquero <lekktu@gmail.com>
1051
1052 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1053
6a7a1b0b
TZ
10542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1055
1056 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1057 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1058 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1059
841a1577 10602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1061
1062 * lisp.h (Qdebug): List symbol.
895009e1 1063 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1064 * keyboard.c (debug-on-event): New variable.
1065 (handle_user_signal): Break into debugger when debug-on-event
1066 matches the current signal symbol.
1067
f2d3ba6f
DN
10682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1069
1070 * alloc.c (check_sblock, check_string_bytes)
1071 (check_string_free_list): Convert to standard C.
1072
42ce4c63
TZ
10732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1074
1075 * w32.c (emacs_gnutls_push): Fix typo.
1076
825cd63c
EZ
10772011-04-25 Eli Zaretskii <eliz@gnu.org>
1078
fb11d64d
EZ
1079 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1080 "cast to pointer from integer of different size".
1081
825cd63c
EZ
1082 Improve doprnt and its use in verror. (Bug#8545)
1083 * doprnt.c (doprnt): Document the set of format control sequences
1084 supported by the function. Use SAFE_ALLOCA instead of always
1085 using `alloca'.
1086
1087 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1088 is one byte too soon. Don't use xrealloc; instead xfree and
1089 xmalloc anew.
1090
e061a11b
TZ
10912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1092
1093 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1094 callbacks stage.
1095
1096 * gnutls.c: Renamed global_initialized to
1097 gnutls_global_initialized. Added internals for the
1098 :verify-hostname-error, :verify-error, and :verify-flags
1099 parameters of `gnutls-boot' and documented those parameters in the
1100 docstring. Start callback support.
1101 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1102 unless a fatal error occured. Call gnutls_alert_send_appropriate
1103 on error. Return error code.
1104 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1105 (emacs_gnutls_read): Likewise.
1106 (Fgnutls_boot): Return handshake error code.
1107 (emacs_gnutls_handle_error): New function.
1108 (wsaerror_to_errno): Likewise.
1109
1110 * w32.h (emacs_gnutls_pull): Add prototype.
1111 (emacs_gnutls_push): Likewise.
1112
1113 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1114 (emacs_gnutls_push): Likewise.
1115
11162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1117
1118 * process.c (wait_reading_process_output): Check if GnuTLS
1119 buffered some data internally if no FDs are set for TLS
1120 connections.
1121
1122 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1123 (LIBS): Link to USER_LIBS.
1124 ($(BLD)/gnutls.$(0)): New target.
1125
fa6996bc
EZ
11262011-04-24 Eli Zaretskii <eliz@gnu.org>
1127
eb35682e
EZ
1128 * xdisp.c (handle_single_display_spec): Rename the
1129 display_replaced_before_p argument into display_replaced_p, to
1130 make it consistent with the commentary. Fix typos in the
1131 commentary.
1132
e2ad650c
EZ
1133 * textprop.c (syms_of_textprop): Remove dead code.
1134 (copy_text_properties): Delete obsolete commentary about an
1135 interface that was deleted long ago. Fix typos in the description
1136 of arguments.
1137
1b2de274
EZ
1138 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1139 to changes in oldXMenu/XMenu.h from 2011-04-16.
1140 <menu_help_message, prev_menu_help_message>: Constify.
1141 (IT_menu_make_room): menu->help_text is now `const char **';
1142 adjust.
1143
1144 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1145 to changes in oldXMenu/XMenu.h from 2011-04-16.
1146 (struct XMenu): Declare `help_text' `const char **'.
1147
1148 * xfaces.c <Qunspecified>: Make extern again.
1149
1150 * syntax.c: Include sys/types.h before including regex.h, as
1151 required by Posix.
1152
762b15be
EZ
1153 * doc.c (get_doc_string): Improve the format passed to `error'.
1154
1155 * doprnt.c (doprnt): Improve commentary.
1156
1157 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1158
1159 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1160 them with etags.
1161
f1052e5d
EZ
1162 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1163 changes in globals.h immediately force recompilation.
762b15be
EZ
1164 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1165 $(CURDIR)/s/ms-w32.h.
1166 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1167
fa6996bc
EZ
1168 * character.c (Fchar_direction): Function deleted.
1169 (syms_of_character): Don't defsubr it.
1170 <char-direction-table>: Deleted.
1171
e6c3da20
EZ
11722011-04-23 Eli Zaretskii <eliz@gnu.org>
1173
1174 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1175 * doprnt.c: Include limits.h.
1176 (SIZE_MAX): New macro.
1177 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
1178 local variables are now size_t instead of int or unsigned.
1179 Improve overflow protection. Support `l' modifier for integer
1180 conversions. Support %l conversion. Don't assume an EMACS_INT
1181 argument for integer conversions and for %c.
1182
1183 * lisp.h (doprnt): Restore prototype.
1184
1185 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1186 $(SRC)/character.h.
1187
1188 * Makefile.in (base_obj): Add back doprnt.o.
1189
1190 * deps.mk (doprnt.o): Add back prerequisites.
1191 (callint.o): Depend on character.h.
1192
1193 * eval.c (internal_lisp_condition_case): Include the handler
1194 representation in the error message.
1195 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1196 when breaking from the loop.
1197
1198 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1199
1200 * callint.c (Fcall_interactively): When displaying error message
1201 about invalid control letter, pass the character's codepoint, not
1202 a pointer to its multibyte form. Improve display of the character
1203 in octal and display also its hex code.
1204
1205 * character.c (char_string): Use %x to display the (unsigned)
1206 codepoint of an invalid character, to avoid displaying a bogus
1207 negative value.
1208
1209 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1210 `error', not SYMBOL_NAME itself.
1211
1212 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1213 character arguments to `error'.
1214
1215 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1216 to `error' in error message about FINAL_CHAR argument. Make sure
1217 FINAL_CHAR is a character, and use %c when it is passed as
1218 argument to `error'.
1219
4ffd0d6b 12202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1221
1222 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1223
1224 * w32.c: Include <time.h>.
1225 (sys_localtime): New function.
1226
4ffd0d6b 12272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1228
1229 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1230
4ffd0d6b 1231 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1232
4ffd0d6b 12332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1234
4ffd0d6b
GM
1235 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1236 zombies (Bug#8467).
aac0c6e3 1237
04c56954
EZ
12382011-04-19 Eli Zaretskii <eliz@gnu.org>
1239
1240 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1241 gl_state.e_property when gl_state.object is Qt.
1242
1243 * insdel.c (make_gap_larger): Remove limitation of buffer size
1244 to <= INT_MAX.
1245
16a43933
CY
12462011-04-18 Chong Yidong <cyd@stupidchicken.com>
1247
1248 * xdisp.c (lookup_glyphless_char_display)
1249 (produce_glyphless_glyph): Handle cons cell entry in
1250 glyphless-char-display.
1251 (Vglyphless_char_display): Document it.
1252
1253 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1254 glyphless-char-display.
1255
4581706e
CY
12562011-04-17 Chong Yidong <cyd@stupidchicken.com>
1257
1258 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1259
1260 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1261
1262 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1263 definition for no-X builds.
1264
4887c6e2 12652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1266
fd35b6f9
PE
1267 Static checks with GCC 4.6.0 and non-default toolkits.
1268
5c1ccb01
PE
1269 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1270
006c5daa
PE
1271 * process.c (keyboard_bit_set): Define only if SIGIO.
1272 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1273 (send_process): Repair possible setjmp clobbering.
1274
efc736d3
PE
1275 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1276
4e2fe2e6
PE
1277 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1278
f97334a2
PE
1279 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1280
4e75f29d
PE
1281 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1282 Define only if needed.
1283
90efadd1
PE
1284 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1285 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1286 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1287
3c647824
PE
1288 * dispextern.h (struct redisplay_interface): Rename param
1289 to avoid shadowing.
e264f262 1290 * termhooks.h (struct terminal): Likewise.
761383f4 1291 * xterm.c (xembed_send_message): Likewise.
3c647824 1292
b58c5c4a
PE
1293 * insdel.c (make_gap_smaller): Define only if
1294 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1295
cad59032
PE
1296 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1297 it.
1298
c339dc2e
PE
1299 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1300 so that we aren't warned about unused symbols.
1301
91a3e27b
PE
1302 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1303
399c71d3 1304 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1305
8ffc96f5
PE
1306 * xfns.c (x_real_positions): Mark locals as initialized.
1307
eef9bc79
PE
1308 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1309
098db9dd
PE
1310 * xterm.c: Fix problems found by static analysis with other toolkits.
1311 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1312 (x_dispatch_event): Declare static if USE_GTK, and
1313 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1314 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1315 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1316 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1317 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1318
eb18f6cc
PE
1319 * xmenu.c (menu_help_callback): Pointer type fixes.
1320 Use const pointers when pointing at readonly data. Avoid pointer
1321 signedness clashes.
1322 (FALSE): Remove unused macro.
1323 (update_frame_menubar): Remove unused decl.
1324
1fe72bf8
PE
1325 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1326
60d9e1db
PE
1327 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1328 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1329 (single_menu_item): Rename local to avoid shadowing.
1330
39261c26
PE
1331 * keyboard.c (make_lispy_event): Remove unused local var.
1332
018c5e19
PE
1333 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1334 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1335
63d2b86e
PE
1336 * bitmaps: Change bitmaps from unsigned char back to the X11
1337 compatible char. Avoid the old compiler warnings about
1338 out-of-range initializers by using, for example, '\xab' rather
1339 than 0xab.
1340
aefd87e1
PE
1341 * xgselect.c (xgselect_initialize): Check vs interface
1342 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1343
bf501fb9
PE
1344 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1345
e9829fdf
PE
1346 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1347 to read-only memory.
1348
1086c095
PE
1349 * fns.c (vector): Remove; this old hack is no longer needed.
1350
2baccd04 1351 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1352 Remove unused var.
dde42981 1353 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1354
72391843 1355 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1356
436c16df 1357 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1358 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1359 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1360
92bb796d 1361 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1362 (x_term_init): Remove local to avoid shadowing.
92bb796d 1363
764430a3 1364 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1365
1366 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1367 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1368
d1dfb56c
EZ
13692011-04-16 Eli Zaretskii <eliz@gnu.org>
1370
c4354cb4
EZ
1371 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1372
d1dfb56c
EZ
1373 Fix regex.c, syntax.c and friends for buffers > 2GB.
1374 * syntax.h (struct gl_state_s): Declare character position members
1375 EMACS_INT.
1376
1377 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1378
1379 * textprop.c (verify_interval_modification, interval_of): Declare
1380 arguments EMACS_INT.
1381
1382 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1383 EMACS_INT.
1384
1385 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1386
1387 * indent.c (Fvertical_motion): Local variable it_start is now
1388 EMACS_INT.
1389
1390 * regex.c (re_match, re_match_2, re_match_2_internal)
1391 (bcmp_translate, regcomp, regexec, print_double_string)
1392 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1393 (re_compile_pattern, re_exec): Declare arguments and local
1394 variables `size_t' and `ssize_t' and return values `regoff_t', as
1395 appropriate.
1396 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1397 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1398 <compile_stack_type>: `size' and `avail' are now `size_t'.
1399
1400 * regex.h <regoff_t>: Use ssize_t, not int.
1401 (re_search, re_search_2, re_match, re_match_2): Arguments that
1402 specify buffer/string position and length are now ssize_t and
1403 size_t. Return type is regoff_t.
1404
613052cd
BK
14052011-04-16 Ben Key <bkey76@gmail.com>
1406
1407 * nsfont.m: Fixed bugs in ns_get_family and
1408 ns_descriptor_to_entity that were caused by using free to
1409 deallocate memory blocks that were allocated by xmalloc (via
1410 xstrdup). This caused Emacs to crash when compiled with
1411 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1412 --enable-checking=xmallocoverrun). xfree is now used to
1413 deallocate these memory blocks.
1414
4170f62f 14152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1416
71b41406
PE
1417 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1418
9587a89d
PE
1419 emacs_write: Accept and return EMACS_INT for sizes.
1420 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1421 et seq.
1422 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1423 Accept and return EMACS_INT.
1424 (emacs_gnutls_write): Return the number of bytes written on
1425 partial writes.
1426 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1427 (emacs_read, emacs_write): Remove check for negative size, as the
1428 Emacs source code has been audited now.
9587a89d
PE
1429 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1430 (emacs_read, emacs_write): Use it.
273a5f82
PE
1431 * process.c (send_process): Adjust to the new signatures of
1432 emacs_write and emacs_gnutls_write. Do not attempt to store
1433 a byte offset into an 'int'; it might overflow.
9587a89d 1434 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1435
3e047f51
PE
1436 * sound.c: Don't assume sizes fit in 'int'.
1437 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1438 Return EMACS_INT, not int.
3e047f51 1439 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1440 Accept EMACS_INT, not int.
1441 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1442 record read return values.
1443
cc39a9db
BK
14442011-04-15 Ben Key <bkey76@gmail.com>
1445
c9d0ec6d
JB
1446 * keyboard.c (Qundefined): Don't declare static since it is used
1447 in nsfns.m.
1448 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1449 static since they are used in nsfont.m.
cc39a9db 1450
6c60eb9f
SM
14512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1452
1453 * process.c (Qprocessp): Don't declare static.
1454 * lisp.h (Qprocessp): Declare again.
1455
7990b61a
JB
14562011-04-15 Juanma Barranquero <lekktu@gmail.com>
1457
1458 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1459
5d4cb038
PE
14602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1461
8bd7b830 1462 Improve C-level modularity by making more things 'static'.
cd64ea1d 1463
e3b27b31
PE
1464 Don't publish debugger-only interfaces to other modules.
1465 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1466 (verify_bytepos, count_markers): Move decls to the only modules
1467 that need them.
1468 * region-cache.h (pp_cache): Likewise.
1469 * window.h (check_all_windows): Likewise.
1470 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1471
5d4cb038
PE
1472 * sysdep.c (croak): Now static, if
1473 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1474 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1475
1476 * alloc.c (refill_memory_reserve): Now static if
1477 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1478 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1479
e87b6180
PE
1480 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1481 Define only if USE_LUCID.
1482
ac64929e
PE
1483 * xrdb.c (x_customization_string, x_rm_string): Now static.
1484
6f37259d
PE
1485 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1486 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1487
1683e3ab
PE
1488 * xdisp.c (draw_row_with_mouse_face): Now static.
1489 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1490
de9c2632
PE
1491 * window.h (check_all_windows): Mark externally visible.
1492
2b96acb7
PE
1493 * window.c (window_deletion_count): Now static.
1494
1495 * undo.c: Make symbols static if they're not exported.
1496 (last_undo_buffer, last_boundary_position, pending_boundary):
1497 Now static.
1498
50436f33
PE
1499 * textprop.c (interval_insert_behind_hooks): Now static.
1500 (interval_insert_in_front_hooks): Likewise.
1501
64520e5c
PE
1502 * term.c: Make symbols static if they're not exported.
1503 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1504 (max_frame_lines, tty_set_terminal_modes):
1505 (tty_reset_terminal_modes, tty_turn_off_highlight):
1506 (get_tty_terminal): Now static.
1507 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1508 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1509 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1510 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1511 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1512
1fa53021
PE
1513 * sysdep.c: Make symbols static if they're not exported.
1514 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1515 Now static.
1516 (sigprocmask_set, full_mask): Remove; unused.
1517 (wait_debugging): Mark as visible.
1518 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1519 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1520
d4b43b22
PE
1521 * syntax.c (syntax_temp): Define only if !__GNUC__.
1522
b7c513d0
PE
1523 * sound.c (current_sound_device, current_sound): Now static.
1524
989b29ad
PE
1525 * search.c (searchbufs, searchbuf_head): Now static.
1526
13a55a78
PE
1527 * scroll.c (scroll_cost): Remove; unused.
1528 * dispextern.h (scroll_cost): Remove decl.
1529
de68a1fc
PE
1530 * region-cache.h (pp_cache): Mark as externally visible.
1531
40ccffa6
PE
1532 * process.c: Make symbols static if they're not exported.
1533 (process_tick, update_tick, create_process, chan_process):
1534 (Vprocess_alist, proc_buffered_char, datagram_access):
1535 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1536 (deactivate_process): Mark defn as static, as well as decl.
1537 * lisp.h (create_process): Remove decl.
1538 * process.h (chan_process, Vprocess_alist): Remove decls.
1539
ad64fc97
PE
1540 * print.c: Make symbols static if they're not exported.
1541 (print_depth, new_backquote_output, being_printed, print_buffer):
1542 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1543 (print_interval, print_number_index, initial_stderr_stream):
1544 Now static.
1545 * lisp.h (Fprinc): Remove decl.
1546 (debug_output_compilation_hack): Mark as externally visible.
1547
adddb265
PE
1548 * sysdep.c (croak): Move decl from here to syssignal.h.
1549 * syssignal.h (croak): Put it here, so the API can be checked when
1550 'croak' is called from dissociate_if_controlling_tty.
1551
1717ede2
PE
1552 * minibuf.c: Make symbols static if they're not exported.
1553 (minibuf_save_list, choose_minibuf_frame): Now static.
1554 * lisp.h (choose_minibuf_frame): Remove decl.
1555
fa5fb2bc
PE
1556 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1557
1e3890d1
PE
1558 * lread.c: Make symbols static if they're not exported.
1559 (read_objects, initial_obarray, oblookup_last_bucket_number):
1560 Now static.
1561 (make_symbol): Remove; unused.
1562 * lisp.h (initial_obarray, make_symbol): Remove decls.
1563
8a1414fa
PE
1564 * keyboard.c: Make symbols static if they're not exported.
1565 (single_kboard, recent_keys_index, total_keys, recent_keys):
1566 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1567 (this_single_command_key_start, echoing, last_auto_save):
1568 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1569 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1570 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1571 (Vlispy_mouse_stem, double_click_count):
1572 Now static.
1573 (force_auto_save_soon): Define only if SIGDANGER.
1574 (ignore_mouse_drag_p): Now static if
1575 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1576 (print_help): Remove; unused.
1577 (stop_character, last_timer_event): Mark as externally visible.
1578 * keyboard.h (ignore_mouse_drag_p): Declare only if
1579 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1580 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1581 * lisp.h (echoing): Remove decl.
1582 (force_auto_save_soon): Declare only if SIGDANGER.
1583 * xdisp.c (redisplay_window): Simplify code, to make it more
1584 obvious that ignore_mouse_drag_p is not accessed if !defined
1585 USE_GTK && !defined HAVE_NS.
1586
93ea6e8f
PE
1587 * intervals.c: Make symbols static if they're not exported.
1588 (merge_properties_sticky, merge_interval_right, delete_interval):
1589 Now static.
1590 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1591
77382fcc
PE
1592 * insdel.c: Make symbols static if they're not exported.
1593 However, leave prepare_to_modify_buffer alone. It's never
1594 called from outside this function, but that appears to be a bug.
1595 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1596 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1597 (adjust_after_replace_noundo): Remove; unused.
1598 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1599 (signal_before_change): Remove decls.
77382fcc 1600
9306c32e
PE
1601 * indent.c (val_compute_motion, val_vmotion): Now static.
1602
cd44d2eb
PE
1603 * image.c: Make symbols static if they're not exported.
1604 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1605 if USE_GTK.
1606 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1607 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1608
ad9a7a06
PE
1609 * fringe.c (standard_bitmaps): Now static.
1610 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1611
81626931
PE
1612 * frame.c: Make symbols static if they're not exported.
1613 (x_report_frame_params, make_terminal_frame): Now static.
1614 (get_frame_param): Now static, unless HAVE_NS.
1615 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1616 (x_get_resource_string): Remove; not used.
1617 * frame.h (make_terminal_frame, x_report_frame_params):
1618 (x_get_resource_string); Remove decls.
1619 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1620 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1621
239f9db9
PE
1622 * font.c, fontset.c: Make symbols static if they're not exported.
1623 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1624 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1625 * font.c (font_close_object): Now static.
1626 * font.h (font_close_object): Remove.
1627 * fontset.c (FONTSET_OBJLIST): Remove.
1628 (free_realized_fontset) #if-0 the body, which does nothing.
1629 (face_suitable_for_char_p): #if-0, as it's never called.
1630 * fontset.h (face_suitable_for_char_p): Remove decl.
1631 * xfaces.c (face_at_string_position): Use
1632 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1633 since 0 is always ASCII.
1634
dfcf3579
PE
1635 * fns.c (weak_hash_tables): Now static.
1636
5045092b
PE
1637 * fileio.c: Make symbols static if they're not exported.
1638 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1639 (Vwrite_region_annotation_buffers): Now static.
1640
57a96f5c
PE
1641 * eval.c: Make symbols static if they're not exported.
1642 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1643 * lisp.h (backtrace_list): Remove decl.
1644
35f08c38
PE
1645 * emacs.c: Make symbols static if they're not exported.
1646 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1647 (fatal_error_code, fatal_error_signal_hook, standard_args):
1648 Now static.
1649 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1650 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1651 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1652 * lisp.h (fatal_error_signal_hook): Remove decl.
1653 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1654
f44bd759
PE
1655 * editfns.c: Move a (normally-unused) function to its only use.
1656 * editfns.c, lisp.h (get_operating_system_release): Remove.
1657 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1658 worth the hassle of breaking this out.
1659
b532497d
PE
1660 * xterm.c: Make symbols static if they're not exported.
1661 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1662 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1663 (x_destroy_window, x_delete_display):
1664 Now static.
1665 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1666 (x_mouse_leave): Remove; unused.
1667 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1668 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1669 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1670 Remove decls.
1671 (x_mouse_leave): Declare only if WINDOWSNT.
1672 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1673 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1674 USE_X_TOOLKIT.
1675
1675728f
PE
1676 * ftxfont.c: Make symbols static if they're not exported.
1677 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1678 HAVE_FREETYPE.
1679 * font.h (ftxfont_driver): Likewise.
1680
e4cebfca
PE
1681 * xfns.c: Make symbols static if they're not exported.
1682 (x_last_font_name, x_display_info_for_name):
1683 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1684 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1685 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1686 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1687 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1688 (last_show_tip_args): Now static.
1689 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1690 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1691 (x_screen_planes): Remove; unused.
1692 * dispextern.h (x_screen_planes): Remove decl.
1693
5bf46f05
PE
1694 * dispnew.c: Make symbols static if they're not exported.
1695 * dispextern.h (redraw_garbaged_frames, scrolling):
1696 (increment_row_positions): Remove.
1697 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1698 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1699 Now static.
1700 (redraw_garbaged_frames): Remove; unused.
1701
435f4c28
PE
1702 * xfaces.c: Make symbols static if they're not exported.
1703 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1704 Remove decls.
1705 * xterm.h (defined_color): Remove decls.
1706 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1707 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1708 (menu_face_changed_default, defined_color, free_realized_face):
1709 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1710 (ascii_face_of_lisp_face): Remove; unused.
1711
8524aef3
PE
1712 * xdisp.c: Make symbols static if they're not exported.
1713 * dispextern.h (scratch_glyph_row, window_box_edges):
1714 (glyph_to_pixel_coords, set_cursor_from_row):
1715 (get_next_display_element, set_iterator_to_next):
1716 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1717 (show_mouse_face): Remove decls
1718 * frame.h (message_buf_print): Likewise.
1719 * lisp.h (pop_message, set_message, check_point_in_composition):
1720 Likewise.
1721 * xterm.h (set_vertical_scroll_bar): Likewise.
1722 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1723 (message_buf_print, scratch_glyph_row, displayed_buffer):
1724 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1725 (get_next_display_element, show_mouse_face, window_box_edges):
1726 (frame_to_window_pixel_xy, check_point_in_composition):
1727 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1728 (glyph_to_pixel_coords): Remove; unused.
1729
16390cd2
PE
1730 * dired.c (file_name_completion): Now static.
1731
1732 * dbusbind.c (xd_in_read_queued_messages): Now static.
1733
a25f4dfa
PE
1734 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1735 * data.c (circular_list_error): Remove.
1736
14a9c8df
PE
1737 * commands.h (last_point_position, last_point_position_buffer):
1738 (last_point_position_window): Remove decls.
1739 * keyboard.c: Make these variables static.
1740
74ab6df5
PE
1741 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1742 decls.
1743 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1744 (iso_code_class, detect_coding, code_convert_region): Now static.
1745 (encode_coding_gap): Remove; unused.
1746
38dfbee1
PE
1747 * chartab.c (chartab_chars, chartab_bits): Now static.
1748
a2cb4e63
PE
1749 * charset.h (charset_iso_8859_1): Remove decl.
1750 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1751 Now static.
1752
127198fd
PE
1753 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1754 * ccl.c (Vccl_program_table): Now static.
1755 (check_ccl_update): Remove; unused.
1756
d85b608f
PE
1757 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1758 * category.h: ... from here.
1759 * category.c (check_category_table, set_category_set): Now static.
1760
31cd66f3
PE
1761 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1762 * lisp.h: Remove these decls.
1763
c358e587
PE
1764 * buffer.c (buffer_count): Remove unused var.
1765
e78aecca
PE
1766 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1767 so that it's not optimized away.
1768 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1769 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1770 exported only to the debugger.
1771
e192d7d3
PE
1772 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1773 * atimer.h (run_all_atimers): Removed; not exported.
1774
92470028
PE
1775 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1776 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1777 was inaccessible from Lisp.
1778 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1779 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1780
244ed907
PE
1781 alloc.c: Import and export fewer symbols, and remove unused items.
1782 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1783 is defined.
1784 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1785 it's not optimized away by whole-program optimization.
1786 (message_enable_multibyte, free_misc): Remove.
1787 (catchlist, handlerlist, mark_backtrace):
1788 Declare only if BYTE_MARK_STACK.
1789 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1790 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1791 (message_enable_multibyte): Remove decl.
1792 (free_misc, interval_free_list, float_block, float_block_index):
1793 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1794 (cons_free_list, last_marked_index):
1795 Now static.
1796 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1797 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1798 (mark_backtrace): Define only if BYTE_MARK_STACK.
1799 * xdisp.c (message_enable_multibyte): Now static.
1800
61c2b50e 1801 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1802 This makes it easier for human readers (and static analyzers)
1803 to see whether these variables are used from other modules.
1804 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1805 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1806 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1807 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1808 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1809 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1810 * xmenu.c, xselect.c:
1811 Declare Q* vars static if they are not used in other modules.
1812 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1813 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1814 Remove decls of unexported vars.
1815 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1816
95c82688
PE
1817 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1818
16a97296
PE
1819 Make Emacs functions such as Fatom 'static' by default.
1820 This makes it easier for human readers (and static analyzers)
1821 to see whether these functions can be called from other modules.
1822 DEFUN now defines a static function. To make the function external
1823 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1824 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1825 (Finit_image_library):
16a97296
PE
1826 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1827 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1828 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1829 Remove decls, since these functions are now static.
1830 (Funintern, Fget_internal_run_time): New decls, since these functions
1831 were already external.
95c82688 1832
16a97296
PE
1833 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1834 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1835 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1836 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1837 * keyboard.c, keymap.c, lread.c:
1838 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1839 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1840 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1841 Mark functions with DEFUE instead of DEFUN,
1842 if they are used in other modules.
1843 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1844 decls for now-static functions.
1845 * buffer.h (Fdelete_overlay): Remove decl.
1846 * callproc.c (Fgetenv_internal): Mark as internal.
1847 * composite.c (Fremove_list_of_text_properties): Remove decl.
1848 (Fcomposition_get_gstring): New forward static decl.
1849 * composite.h (Fcomposite_get_gstring): Remove decl.
1850 * dired.c (Ffile_attributes): New forward static decl.
1851 * doc.c (Fdocumntation_property): New forward static decl.
1852 * eval.c (Ffetch_bytecode): New forward static decl.
1853 (Funintern): Remove extern decl; now in .h file where it belongs.
1854 * fileio.c (Fmake_symbolic_link): New forward static decl.
1855 * image.c (Finit_image_library): New forward static decl.
1856 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1857 * intervals.h (Fprevious_property_change):
1858 (Fremove_list_of_text_properties): Remove decls.
1859 * keyboard.c (Fthis_command_keys): Remove decl.
1860 (Fcommand_execute): New forward static decl.
1861 * keymap.c (Flookup_key): New forward static decl.
1862 (Fcopy_keymap): Now static.
1863 * keymap.h (Flookup_key): Remove decl.
1864 * process.c (Fget_process): New forward static decl.
1865 (Fprocess_datagram_address): Mark as internal.
1866 * syntax.c (Fsyntax_table_p): New forward static decl.
1867 (skip_chars): Remove duplicate decl.
1868 * textprop.c (Fprevious_property_change): New forward static decl.
1869 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1870 Now internal.
1871 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1872 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1873
785bbd42
PE
1874 * editfns.c (Fformat): Remove unreachable code.
1875
8b913b57
AS
18762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1877
1878 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1879 change. (Bug#8496)
1880
a6744a35
EZ
18812011-04-13 Eli Zaretskii <eliz@gnu.org>
1882
1883 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1884 when at ZV. (Bug#8487)
1885
e7974947
AS
18862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1887
baad03f0
AS
1888 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1889 (Bug#8437)
1890 * keyboard.c (parse_tool_bar_item): Likewise.
1891 * sound.c (sound_cleanup, alsa_close): Likewise.
1892 * termcap.c (tgetent): Likewise.
1893 * xfns.c (x_default_font_parameter): Likewise.
1894 * xsettings.c (read_and_apply_settings): Likewise.
1895
e7974947
AS
1896 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1897 (overrun_check_free): Protoize.
1898
28272684
PE
18992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1900
1901 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1902 since callers should never pass a negative size.
1903 Change the signature to match that of plain 'read' and 'write'; see
1904 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1905 * lisp.h: Update prototypes of emacs_write and emacs_read.
1906
11997c76
EZ
19072011-04-11 Eli Zaretskii <eliz@gnu.org>
1908
1909 * xdisp.c (redisplay_window): Don't try to determine the character
1910 position of the scroll margin if the window start point w->startp
e896f03c 1911 is outside the buffer's accessible region. (Bug#8468)
11997c76 1912
8a2cbd72
EZ
19132011-04-10 Eli Zaretskii <eliz@gnu.org>
1914
1915 Fix write-region and its subroutines for buffers > 2GB.
1916 * fileio.c (a_write, e_write): Modify declaration of arguments and
1917 local variables to support buffers larger than 2GB.
1918 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1919
1920 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1921 argument, local variables, and return value.
1922
1923 * lisp.h: Update prototypes of emacs_write and emacs_read.
1924
1925 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1926
4073e537 19272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1928
1ebfdcb6
PE
1929 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1930
b2ded58d
PE
1931 Fix more problems found by GCC 4.6.0's static checks.
1932
7d66342c
PE
1933 * xdisp.c (vmessage): Use a better test for character truncation.
1934
bbf47d44
PE
1935 * charset.c (load_charset_map): <, not <=, for optimization,
1936 and to avoid potential problems with integer overflow.
9248994d 1937 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1938 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1939 * editfns.c (Fformat): Likewise.
1e69125e 1940 * syntax.c (skip_chars): Likewise.
3befa583 1941
e3019616
PE
1942 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1943 This also lets GCC 4.6.0 generate slightly better loop code.
1944
becfa255
PE
1945 * callint.c (Fcall_interactively): <, not <=, for optimization.
1946 (Fcall_interactively): Count the number of arguments produced,
1947 not the number of arguments given. This is simpler and lets GCC
1948 4.6.0 generate slightly better code.
1949
dae0cd48
PE
1950 * ftfont.c: Distingish more carefully between FcChar8 and char.
1951 The previous code passed unsigned char * to a functions like
1952 strlen and xstrcasecmp that expect char *, which does not
1953 conform to the C standard.
1954 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1955 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1956 char * when the C standard requires it.
1957
76032d70
PE
1958 * keyboard.c (read_char): Remove unused var.
1959
eb3f1cc8
PE
1960 * eval.c: Port to Windows vsnprintf (Bug#8435).
1961 Include <limits.h>.
1962 (SIZE_MAX): Define if the headers do not.
1963 (verror): Do not give up if vsnprintf returns a negative count.
1964 Instead, grow the buffer. This ports to Windows vsnprintf, which
1965 does not conform to C99. Problem reported by Eli Zaretskii.
1966 Also, simplify the allocation scheme, by avoiding the need for
1967 calling realloc, and removing the ALLOCATED variable.
1968
70476b54
PE
1969 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1970
12020a9e
PE
1971 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1972 But keep the doprint source code for now, as we might revamp it
1973 and use it again (Bug#8435).
ea6c7ae6
PE
1974 * lisp.h (doprnt): Remove.
1975 * Makefile.in (base_obj): Remove doprnt.o.
1976 * deps.mk (doprnt.o): Remove.
1977
5fdb398c
PE
1978 error: Print 32- and 64-bit integers portably (Bug#8435).
1979 Without this change, on typical 64-bit hosts error ("...%d...", N)
1980 was used to print both 32- and 64-bit integers N, which relied on
1981 undefined behavior.
1982 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1983 New macro.
1984 * lisp.h (error, verror): Mark as printf-like functions.
1985 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1986 Report overflow in size calculations when allocating printf buffer.
1987 Do not truncate output string at its first null byte.
1988 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1989 Truncate the output at a character boundary, since vsnprintf does not
1990 do that.
1991 * charset.c (check_iso_charset_parameter): Convert internal
1992 character to string before calling 'error', since %c now has the
1993 printf meaning.
1994 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1995 overflow when computing char to be passed to 'error'. Do not
1996 pass Lisp_Object to 'error'; pass the integer instead.
1997 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1998 formatted with plain %d.
1999
b189fa66
PE
2000 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2001
bff87ef0
PE
2002 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2003
7e2cac20
PE
2004 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2005
ce4d90b5
PE
2006 * xterm.c (x_catch_errors): Remove duplicate declaration.
2007
266c9547
PE
2008 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2009
79c49ad2
PE
2010 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2011
368f4090
JM
20122011-04-10 Jim Meyering <meyering@redhat.com>
2013
2014 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2015 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2016 return ssize_t not "int", and use size_t as the buffer length.
2017 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2018 * gnutls.h: Update declarations.
2019 * process.c (read_process_output): Use ssize_t, to match.
2020 (send_process): Likewise.
2021
a32d4040
CY
20222011-04-09 Chong Yidong <cyd@stupidchicken.com>
2023
2024 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2025
8546720e 20262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2027
8546720e
GM
2028 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
2029 unsigned char, to match FcChar8 type definition.
aac0c6e3 2030
8546720e
GM
2031 * xterm.c (handle_one_xevent):
2032 * xmenu.c (create_and_show_popup_menu):
2033 * xselect.c (x_decline_selection_request)
2034 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2035
0a2f5c1a 20362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2037
2038 Fix some uses of `int' instead of EMACS_INT.
2039 * search.c (string_match_1, fast_string_match)
2040 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2041 (scan_buffer, find_next_newline_no_quit)
2042 (find_before_next_newline, search_command, Freplace_match)
2043 (Fmatch_data): Make some `int' variables be EMACS_INT.
2044
2045 * xdisp.c (display_count_lines): 3rd argument and return value now
2046 EMACS_INT. All callers changed.
2047 (pint2hrstr): Last argument is now EMACS_INT.
2048
2049 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2050 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2051 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2052 (decode_coding_utf_16, decode_coding_emacs_mule)
2053 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2054 (decode_coding_ccl, decode_coding_charset)
2055 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2056 (decode_coding_iso_2022, decode_coding_emacs_mule)
2057 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2058 <char_offset, last_offset>: Declare EMACS_INT.
2059 (encode_coding_utf_8, encode_coding_utf_16)
2060 (encode_coding_emacs_mule, encode_invocation_designation)
2061 (encode_designation_at_bol, encode_coding_iso_2022)
2062 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2063 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2064 Declare EMACS_INT.
2065 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2066 (encode_invocation_designation): Last argument P_NCHARS is now
2067 EMACS_INT.
2068 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2069 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2070
2071 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2072 All users changed.
2073
2074 * ccl.c (Fccl_execute_on_string): Declare some variables
2075 EMACS_INT.
2076
8546720e 20772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2078
2079 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2080
4e19a977
CS
20812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2082
2083 * process.c (Fformat_network_address): Doc fix.
2084
87302331
R
20852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2086
2087 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2088
cbb59342
CY
20892011-04-08 Chong Yidong <cyd@stupidchicken.com>
2090
2091 * keyboard.c (read_char): Call Lisp function help-form-show,
2092 instead of using internal_with_output_to_temp_buffer.
2093 (Qhelp_form_show): New var.
e0d38eeb 2094 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2095
2096 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2097
2098 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2099
e67a13ab
CY
21002011-04-06 Chong Yidong <cyd@stupidchicken.com>
2101
2102 * process.c (Flist_processes): Removed to Lisp.
2103 (list_processes_1): Deleted.
2104
973f782d
EZ
21052011-04-06 Eli Zaretskii <eliz@gnu.org>
2106
7c106b1e
EZ
2107 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2108
973f782d
EZ
2109 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2110
41cf7d1a 21112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2112
ca23cc88
PE
2113 Fix more problems found by GCC 4.6.0's static checks.
2114
f390e2d5
PE
2115 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2116
42eea0d0
PE
2117 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2118
b69769da 2119 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2120
f9541e84
PE
2121 * xdisp.c (vmessage): Mark as a printf-like function.
2122
13841b55
PE
2123 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2124
c136c10f
PE
2125 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2126
5e2d4a30
PE
2127 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2128 printf-like functions.
2129 (tiff_load): Add casts to remove these marks before passing them
2130 to system-supplied API.
2131
583f48b9
PE
2132 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2133
b25d760e
PE
2134 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2135 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2136 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2137 directly, rather than having caller test rule sign. This avoids
2138 some unnecessary tests.
2139 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2140 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2141 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2142
bc7b6697 2143 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2144 (xfont_open): Avoid unnecessary tests.
bc7b6697 2145
27ccc379
PE
2146 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2147
dcd5c89a
PE
2148 * composite.h, composite.c (composition_gstring_put_cache):
2149 Use EMACS_INT, not int, for length.
2150
b13a45c6
PE
2151 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2152 breaking out part of COMPOSITION_DECODE_RULE.
2153 (COMPOSITION_DECODE_RULE): Use it.
2154 * composite.c (get_composition_id): Remove unused local vars,
2155 by using the new macro.
2156
1e792e4d
PE
2157 * textprop.c (set_text_properties_1): Change while to do-while,
2158 since the condition is always true at first.
2159
dc6c6455 2160 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2161 (interval_deletion_adjustment): Return unsigned value.
2162 All uses changed.
dc6c6455 2163
aba7731a
PE
2164 * process.c (list_processes_1, create_pty, read_process_output):
2165 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2166 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2167 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2168 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2169 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2170
fdfc4bf3
PE
2171 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2172
fca8fe46 2173 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2174 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2175
06a0259a 2176 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2177 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2178 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2179
e7b9e80f
PE
2180 * print.c (print_error_message): Avoid int overflow.
2181
56201685
PE
2182 * font.c (font_list_entities): Redo for clarity,
2183 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2184
78834453 2185 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2186 (font_score): Avoid potential overflow in diff calculation.
78834453 2187
0bc0b309 2188 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2189 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2190
e610eaca
PE
2191 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2192
b895abce
PE
2193 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2194 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2195 can always succeed if overflow has undefined behavior.
2196
1f1d9321 2197 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2198 (wordify): Omit three unnecessary tests.
1f1d9321 2199
c59478bc
PE
2200 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2201 All callers changed. This avoids the need for an unused var.
2202
79b73827
PE
2203 * casefiddle.c (casify_region): Remove var that is set but not used.
2204
a4db5dfe
PE
2205 * dired.c (file_name_completion): Remove var that is set but not used.
2206
43aae36e
PE
2207 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2208
2a47c44d 2209 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2210 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2211
a37c69bf
PE
2212 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2213 Check for integer overflow on size calculations.
2214
328ab8e7
PE
2215 * buffer.c (Fprevious_overlay_change): Remove var that is set
2216 but not used.
2217
e5a2a5cb
PE
2218 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2219 Remove vars that are set but not used.
8d84a6eb 2220 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2221 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2222
a60e5f68
PE
2223 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2224
f661cb61 2225 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2226 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2227
f0397f5a
PE
2228 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2229 that are set but not used.
2230
8664db06 2231 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2232 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2233
6abdaa4a
PE
2234 * xselect.c (x_get_local_selection, x_handle_property_notify):
2235 Remove vars that are set but not used.
2236
0ce7538d 2237 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2238 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2239
9ae848fc
PE
2240 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2241 Remove var that is set but not used.
0b918413
PE
2242 (scroll_bar_windows_size): Now size_t, not int.
2243 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2244 Check for overflow.
9ae848fc 2245
a5a62657
PE
2246 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2247 (map_tty_color) [!defined MSDOS]: Likewise.
2248
5c5cdd39
PE
2249 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2250
66ebf983
PE
2251 * coding.c: Remove vars that are set but not used.
2252 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2253 All callers changed.
2254 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2255 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2256 (decode_coding_charset): Remove vars that are set but not used.
2257
1be4d761
PE
2258 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2259 that is set but not used.
2260
47553fa8
PE
2261 * print.c (print_object): Remove var that is set but not used.
2262
1f7196bf 2263 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2264 The gnulib version avoids calling malloc in the usual case,
2265 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2266 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2267 * filelock.c (current_lock_owner): Likewise.
2268 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2269 * sysdep.c: Include allocator.h, careadlinkat.h.
2270 (emacs_no_realloc_allocator): New static constant.
2271 (emacs_readlink): New function.
fdb61804
PE
2272 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2273 ../lib/careadlinkat.h.
d1fdcab7 2274
f84c17c7
SM
22752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2276
2277 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2278 first non-nil return value).
2279
ef3862ad
JD
22802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2281
2282 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2283 if not defined (Bug#8403).
2284
376a7006
JB
22852011-04-02 Juanma Barranquero <lekktu@gmail.com>
2286
2287 * xdisp.c (display_count_lines): Remove parameter `start',
2288 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2289 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2290 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2291 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2292 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2293 and thereabouts. All callers changed.
2294 (get_per_char_metric): Remove parameter `f', unused since
2295 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2296
6ca3801d
JM
22972011-04-02 Jim Meyering <meyering@redhat.com>
2298
2299 do not dereference NULL upon failed strdup
2300 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2301 (ns_get_family): Likewise.
2302
d8e2b5ba
JB
23032011-04-02 Juanma Barranquero <lekktu@gmail.com>
2304
2305 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2306
8c74fcbd
JD
23072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2308
2309 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2310 later (Bug#8403).
2311
7200d79c
SM
23122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2313
03408648 2314 Add lexical binding.
7200d79c 2315
03408648
SM
2316 * window.c (Ftemp_output_buffer_show): New fun.
2317 (Fsave_window_excursion):
2318 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2319
2320 * lread.c (lisp_file_lexically_bound_p): New function.
2321 (Fload): Bind Qlexical_binding.
2322 (readevalloop): Remove `evalfun' arg.
2323 Bind Qinternal_interpreter_environment.
2324 (Feval_buffer): Bind Qlexical_binding.
2325 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2326 Mark as dynamic.
2327 (syms_of_lread): Declare `lexical-binding'.
2328
2329 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2330
2331 * keyboard.c (eval_dyn): New fun.
2332 (menu_item_eval_property): Use it.
ca105506
SM
2333
2334 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2335
03408648
SM
2336 * fns.c (concat, mapcar1): Accept byte-code-functions.
2337
2338 * eval.c (Fsetq): Handle lexical vars.
2339 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2340 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2341 (FletX, Flet): Obey lexical binding.
2342 (Fcommandp): Handle closures.
2343 (Feval): New `lexical' arg.
2344 (eval_sub): New function extracted from Feval. Use it almost
2345 everywhere where Feval was used. Look up vars in lexical env.
2346 Handle closures.
2347 (Ffunctionp): Move from subr.el.
2348 (Ffuncall): Handle closures.
2349 (apply_lambda): Remove `eval_flags'.
2350 (funcall_lambda): Handle closures and new byte-code-functions.
2351 (Fspecial_variable_p): New function.
2352 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2353 but without exporting it to Lisp.
23aba0ea 2354
23aba0ea 2355 * doc.c (Fdocumentation, store_function_docstring):
03408648 2356 * data.c (Finteractive_form): Handle closures.
23aba0ea 2357
03408648
SM
2358 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2359 interactive spec.
ba83908c 2360
03408648
SM
2361 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
2362 byte-codes.
2363 (exec_byte_code): New function extracted from Fbyte_code to handle new
2364 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2365
03408648 2366 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2367
03408648 2368 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2369
e2abce01
JB
23702011-03-31 Juanma Barranquero <lekktu@gmail.com>
2371
2372 * xdisp.c (redisplay_internal): Fix prototype.
2373
63696a73 23742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2375
63696a73
EZ
2376 * xdisp.c (SCROLL_LIMIT): New macro.
2377 (try_scrolling): Use it when setting scroll_limit. Limit
2378 scrolling to 100 screen lines.
2379 (redisplay_window): Even when falling back on "recentering",
2380 position point in the window according to scroll-conservatively,
2381 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2382
2383 (try_scrolling): When point is above the window, allow searching
2384 as far as scroll_max, or one screenful, to compute vertical
2385 distance from PT to the scroll margin position. This prevents
2386 try_scrolling from unnecessarily failing when
2387 scroll-conservatively is set to a value slightly larger than the
2388 window height. Clean up the case of PT below the margin at bottom
2389 of window: scroll_max can no longer be INT_MAX. When aggressive
2390 scrolling is in use, don't let point enter the opposite scroll
2391 margin as result of the scroll.
2392 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2393 threshold of 100 lines for never-recentering scrolling.
2394
e4cc2dfc
JB
23952011-03-31 Juanma Barranquero <lekktu@gmail.com>
2396
2397 * dispextern.h (move_it_by_lines):
2398 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2399 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2400 (message_log_check_duplicate): Remove parameters `prev_bol' and
2401 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2402 (redisplay_internal): Remove parameter `preserve_echo_area',
2403 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2404
2405 * indent.c (Fvertical_motion):
2406 * window.c (window_scroll_pixel_based, Frecenter):
2407 Don't pass `need_y_p' to `move_it_by_lines'.
2408
1c470562
SM
24092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2410
44f230aa
SM
2411 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2412 steal a few bits to be more compact.
2413 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2414 Remove unneeded casts.
2415
1c470562
SM
2416 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2417
888adce9
ZK
24182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2419
2420 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2421 binding" message (bug#7967).
2422
f838ed7b
PE
24232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2424
77861b95
PE
2425 Fix more problems found by GCC 4.6.0's static checks.
2426
de6dbc14
PE
2427 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2428 Remove unused local var.
2429
f838ed7b
PE
2430 * editfns.c (Fmessage_box): Remove unused local var.
2431
792c7b2b
PE
2432 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2433 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2434 Omit unused local vars.
c499e557 2435 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2436 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2437 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2438 Omit unused local var.
2439
ba0165e1
PE
2440 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2441 Don't assume string length fits in int.
32ad8845 2442 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2443 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2444
3c59b4c9
PE
2445 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2446 instead of alloca (Bug#8344).
2447
a3eed478 2448 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2449 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2450
eb4d412d
PE
2451 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2452
1658b401
PE
2453 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2454 concerns.
2455
2456 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2457
2458 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2459
9a2c6e05
PE
2460 * keyboard.c (syms_of_keyboard): Use the same style as later
2461 in this function when indexing through an array. This also
2462 works around GCC bug 48267.
2463
03d0a109
PE
2464 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2465
44f730c8
PE
2466 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2467
fe75f926
PE
2468 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2469 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2470
ffa8c828
PE
2471 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2472 This avoids undefined behavior on integer overflow, and is a bit
2473 more convenient anyway since it is compared to a size_t variable.
2474
c5101a77
PE
2475 Variadic C functions now count arguments with size_t, not int.
2476 This avoids an unnecessary limitation on 64-bit machines, which
2477 caused (substring ...) to crash on large vectors (Bug#8344).
2478 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2479 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2480 All variadic functions and their callers changed accordingly.
c5101a77
PE
2481 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2482 * data.c (arith_driver, float_arith_driver): Likewise.
2483 * editfns.c (general_insert_function): Likewise.
2484 * eval.c (struct backtrace.nargs, interactive_p)
2485 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2486 (funcall_lambda, mark_backtrace): Likewise.
2487 * fns.c (concat): Likewise.
2488 * frame.c (x_set_frame_parameters): Likewise.
2489 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2490 0 if not found, not -1. All callers changed.
2491
dd3f25f7
PE
2492 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2493 (stack_copy_size): Now size_t, not int.
2494 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2495
461c2ab9
JB
24962011-03-28 Juanma Barranquero <lekktu@gmail.com>
2497
2498 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2499 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2500 All callers changed.
2501
2502 * lisp.h (multibyte_char_to_unibyte):
2503 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2504 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2505 * character.h (CHAR_TO_BYTE8):
2506 * cmds.c (internal_self_insert):
2507 * editfns.c (general_insert_function):
2508 * keymap.c (push_key_description):
2509 * search.c (Freplace_match):
2510 * xdisp.c (message_dolog, set_message_1): All callers changed.
2511
f6d62986
SM
25122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2513
2514 * keyboard.c (safe_run_hook_funcall): New function.
2515 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2516 don't set the hook to nil, but remove the offending function instead.
2517 (Qcommand_hook_internal): Remove, unused.
2518 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2519 Vcommand_hook_internal.
2520
2521 * eval.c (enum run_hooks_condition): Remove.
2522 (funcall_nil, funcall_not): New functions.
2523 (run_hook_with_args): Call each function through a `funcall' argument.
2524 Remove `cond' argument, now redundant.
2525 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2526 (Frun_hook_with_args_until_failure): Adjust accordingly.
2527 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2528
1db5b1ad
JB
25292011-03-28 Juanma Barranquero <lekktu@gmail.com>
2530
2531 * dispextern.h (string_buffer_position): Remove declaration.
2532
2533 * print.c (strout): Remove parameter `multibyte', unused since
2534 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2535
2536 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2537 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2538 All callers changed.
2539
2540 * w32.c (_wsa_errlist): Use braces for struct initializers.
2541
2542 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2543 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2544 All callers changed.
2545 (string_buffer_position): Likewise. Also, make static (it's never
2546 used outside xdisp.c).
2547 (cursor_row_p): Remove parameter `w', unused since
2548 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2549 (decode_mode_spec): Remove parameter `precision', introduced during
2550 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2551 All callers changed.
2552
5ffb62aa
JD
25532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2554
2555 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2556
461c2ab9 25572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2558
2559 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2560 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2561 (ns_update_auto_hide_menu_bar): New functions.
2562 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2563 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2564 ns_constrain_all_frames.
2565 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2566 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2567
5c380ffb
JD
25682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2569
2570 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2571
9af30bdf
GM
25722011-03-27 Glenn Morris <rgm@gnu.org>
2573
2574 * syssignal.h: Replace RETSIGTYPE with void.
2575 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2576 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2577 Replace SIGTYPE with void everywhere.
2578 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2579 * s/template.h (SIGTYPE): Remove commented out definition.
2580
e2abce01
JB
25812011-03-26 Eli Zaretskii <eliz@gnu.org>
2582
2583 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2584 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2585
f868cd8a
JB
25862011-03-26 Juanma Barranquero <lekktu@gmail.com>
2587
59eb0929
JB
2588 * w32.c (read_unc_volume): Use parameter `henum', instead of
2589 global variable `wget_enum_handle'.
2590
2591 * keymap.c (describe_vector): Remove parameters `indices' and
2592 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2593 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2594
f868cd8a
JB
2595 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2596
2597 * keyboard.c (timer_check): Remove parameter `do_it_now',
2598 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2599 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2600 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2601
2602 * keyboard.c (read_char):
2603 * w32menu.c (w32_menu_display_help):
2604 * xmenu.c (show_help_event, menu_help_callback):
2605 Adjust calls to `show_help_echo'.
2606
2607 * gtkutil.c (xg_maybe_add_timer):
2608 * keyboard.c (readable_events):
2609 * process.c (wait_reading_process_output):
2610 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2611
2612 * insdel.c (adjust_markers_gap_motion):
2613 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2614 (gap_left, gap_right): Don't call it.
2615
2ecf6fdb
CY
26162011-03-25 Chong Yidong <cyd@stupidchicken.com>
2617
2618 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2619 incurred during fontification.
2620
6b1f9ba4
JB
26212011-03-25 Juanma Barranquero <lekktu@gmail.com>
2622
2623 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2624 (DEFVAR_PER_BUFFER): Don't pass it.
2625
2626 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2627 (scrolling_window): Don't pass it.
2628
0f4a96b5
JB
26292011-03-25 Juanma Barranquero <lekktu@gmail.com>
2630
2631 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2632
2633 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2634 and `suffix'.
2635 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2636 of variables specific to SELinux and computation of `encoded_absname'.
2637
2638 * image.c (XPutPixel): Remove unused variable `height'.
2639
2640 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2641
2642 * unexw32.c (get_section_info): Remove unused variable `section'.
2643
2644 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2645 (system_process_attributes): Remove unused variable `sess'.
2646 (sys_read): Remove unused variable `err'.
2647
2648 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2649 (w32_wnd_proc): Remove unused variable `isdead'.
2650 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2651 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2652 (x_create_tip_frame): Remove unused variable `tem'.
2653
2654 * w32inevt.c (w32_console_read_socket):
2655 Remove unused variable `no_events'.
2656
2657 * w32term.c (x_draw_composite_glyph_string_foreground):
2658 Remove unused variable `width'.
2659
1149507c
JB
26602011-03-24 Juanma Barranquero <lekktu@gmail.com>
2661
2662 * w32term.c (x_set_glyph_string_clipping):
2663 Don't pass uninitialized region to CombineRgn.
2664
9c88f339
JB
26652011-03-23 Juanma Barranquero <lekktu@gmail.com>
2666
2667 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2668 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2669 (Fx_close_connection): Remove unused variable `i'.
2670
2671 * w32font.c (w32font_draw): Return number of glyphs.
2672 (w32font_open_internal): Remove unused variable `i'.
2673 (w32font_driver): Add missing initializer.
2674
2675 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2676 (fill_in_menu): Remove unused variable `items_added'.
2677
2678 * w32term.c (last_mouse_press_frame): Remove static global variable.
2679 (w32_clip_to_row): Remove unused variable `f'.
2680 (x_delete_terminal): Remove unused variable `i'.
2681
2682 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2683 (NOTHING): Remove unused static global variable.
2684 (uniscribe_check_otf): Remove unused variable `table'.
2685 (uniscribe_font_driver): Add missing initializers.
2686
dee091a3
JD
26872011-03-23 Julien Danjou <julien@danjou.info>
2688
2689 * term.c (Fsuspend_tty, Fresume_tty):
2690 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2691 * window.c (temp_output_buffer_show):
2692 * insdel.c (signal_before_change):
2693 * frame.c (Fhandle_switch_frame):
2694 * fileio.c (Fdo_auto_save):
2695 * emacs.c (Fkill_emacs):
2696 * editfns.c (save_excursion_restore):
2697 * cmds.c (internal_self_insert):
2698 * callint.c (Fcall_interactively):
2699 * buffer.c (Fkill_all_local_variables):
2700 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2701 Use Frun_hooks.
0f4a96b5 2702 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2703 unconditionnaly since it does the check itself.
2704
2c520ab5 27052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2706
c9c49752
PE
2707 Fix more problems found by GCC 4.5.2's static checks.
2708
8abc3f12
PE
2709 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2710 the first time through the loop, since we know p0 < p1 then.
2711 This also avoids a gcc -Wstrict-overflow warning.
2712
a2d26660
PE
2713 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2714 leading to a memory leak, possible in functions like
2715 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2716 of objects (Bug#8318).
a2d26660 2717
916c72e9
PE
2718 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2719 that could (at least in theory) be that large.
2720
19ab8a18
PE
2721 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2722 This is less likely to overflow, and avoids undefined behavior if
2723 overflow does occur. All callers changed. Use strtoul to scan
2724 for the unsigned long integer.
b7cbbd6f
PE
2725 (pint2hrstr): Simplify and tune code slightly.
2726 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2727
f0641eff
PE
2728 * scroll.c (do_scrolling): Work around GCC bug 48228.
2729 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2730
7f650bb9
PE
2731 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2732 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2733 (validate_x_resource_name): Simplify count usage.
2734 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2735
37dd57d1
PE
2736 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2737 fail (Bug#8306).
81e56e61 2738
699979fc 2739 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2740
401bf9b4
PE
2741 * process.c (Fmake_network_process): Use socklen_t, not int,
2742 where POSIX says socklen_t is required in portable programs.
2743 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2744 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2745 (Fmake_network_process, server_accept_connection):
2746 (wait_reading_process_output, read_process_output):
2747 Likewise.
2748
b93aacde
PE
2749 * process.c: Rename or move locals to avoid shadowing.
2750 (list_processes_1, Fmake_network_process):
2751 (read_process_output_error_handler, exec_sentinel_error_handler):
2752 Rename or move locals.
4dc343ee 2753 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2754 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2755 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2756 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2757 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2758
af8a867c 2759 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2760 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2761 Include tparam.h instead, since it declares them.
af8a867c
PE
2762 * cm.h (PC): Remove extern decl; tparam.h now does this.
2763 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2764 * terminfo.c: Include tparam.h, to check interfaces.
2765 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2766 (tparam): Adjust signature to match interface in tparam.h;
2767 this removes some undefined behavior. Check that outstring and len
2768 are zero, which they always are with Emacs.
2769 * tparam.h (PC, BC, UP): New extern decls.
2770
0248044d 2771 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2772 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2773
8ff096c1 2774 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2775 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2776 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2777 (ftfont_list): Remove unused local.
49eaafba
PE
2778 (get_adstyle_property, ftfont_pattern_entity):
2779 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2780 Rename locals to avoid shadowing.
8ff096c1 2781
e2be39f6
PE
2782 * xfont.c (xfont_list_family): Mark var as initialized.
2783
c9735e30
PE
2784 * xml.c (make_dom): Now static.
2785
8f5201ae
PE
2786 * composite.c (composition_compute_stop_pos): Rename local to
2787 avoid shadowing.
b246f932
PE
2788 (composition_reseat_it): Remove unused locals.
2789 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2790 (composition_update_it): Mark var as initialized.
11b61122
PE
2791 (find_automatic_composition): Mark vars as initialized,
2792 with a FIXME (Bug#8290).
8f5201ae 2793
760fbc2c
PE
2794 character.h: Rename locals to avoid shadowing.
2795 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2796 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2797 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2798 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2799 to avoid shadowing.
2800
ff08eb85
PE
2801 * textprop.c (property_change_between_p): Remove; unused.
2802
fc7bf025
PE
2803 * intervals.c (interval_start_pos): Now static.
2804
235d7abc
PE
2805 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2806
44f230aa
SM
2807 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2808 Rename locals to avoid shadowing.
3e7d6594 2809
50060332
PE
2810 * sound.c (wav_play, au_play, Fplay_sound_internal):
2811 Fix pointer signedness.
d01f234b 2812 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2813 (wav_play): Initialize a variable to 0, to prevent undefined
2814 behavior (Bug#8278).
50060332 2815
c4fc4e30
PE
2816 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2817
918436ed
PE
2818 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2819
c939f91b
PE
2820 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2821 clobbering (Bug#8298).
b9c7f648
PE
2822 * sysdep.c (sys_subshell): Likewise.
2823 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2824
6bd8c144
PE
2825 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2826 This should get cleaned up, so that child_setup has the
2827 same signature on all platforms.
2828
7710357c 2829 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2830 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2831
c59da222
CY
28322011-03-22 Chong Yidong <cyd@stupidchicken.com>
2833
2834 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2835 not to be necessary, and produces flickering.
2836
66b87493
GM
28372011-03-20 Glenn Morris <rgm@gnu.org>
2838
2839 * config.in: Remove file.
2840
45b6f6d5
JB
28412011-03-20 Juanma Barranquero <lekktu@gmail.com>
2842
2843 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2844 are now in src/globals.h.
2845 (syms_of_minibuf): Remove spurious & from previous change.
2846
3ec03f7e
LL
28472011-03-20 Leo <sdl.web@gmail.com>
2848
2849 * minibuf.c (completing-read-function): New variable.
2850 (completing-read-default): Rename from completing-read.
2851 (completing-read): Call completing-read-function.
2852
b14e3e21
CY
28532011-03-19 Juanma Barranquero <lekktu@gmail.com>
2854
2855 * xfaces.c (Fx_load_color_file):
2856 Read color file from absolute filename (bug#8250).
2857
f2b726e6
JB
28582011-03-19 Juanma Barranquero <lekktu@gmail.com>
2859
2860 * makefile.w32-in: Update dependencies.
2861
09f6ff02
EZ
28622011-03-17 Eli Zaretskii <eliz@gnu.org>
2863
2864 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2865
29a6015a
PE
28662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2867
a3a6c54e
PE
2868 Fix more problems found by GCC 4.5.2's static checks.
2869
b766f867
PE
2870 * process.c (make_serial_process_unwind, send_process_trap):
2871 (sigchld_handler): Now static.
2872
be02381c
PE
2873 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2874 That way, the code declares only the vars that it needs.
2875 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2876 * s/cygwin.h (PTY_ITERATION): Likewise.
2877 * s/darwin.h (PTY_ITERATION): Likewise.
2878 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2879
57048744
PE
2880 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2881 * process.c (allocate_pty): Don't declare stb unless it's needed.
2882
7914961c 2883 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2884 (CONSTANTLIM): Remove; unused.
2885 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2886 Define only if needed.
7914961c 2887
b3967b18
PE
2888 * unexelf.c (unexec): Name an expression,
2889 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2890 Use a different way to cause a compilation error if anyone uses
2891 n rather than nn, a way that does not involve shadowing.
73366a00 2892 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2893
29a6015a
PE
2894 * deps.mk (unexalpha.o): Remove; unused.
2895
43cfc33e 2896 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2897 * unexec.h: New file.
ce701a33
PE
2898 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2899 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2900 Depend on unexec.h.
2901 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2902 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2903 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2904 Change as necessary to match prototype in unexec.h.
ce701a33 2905
01f44d5a
PE
2906 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2907 shadowing.
4f63c6bb 2908 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2909
a6670b0b
PE
2910 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2911 Rename locals to avoid shadowing.
2912
cef2010d 2913 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2914 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2915
d4d7173a
PE
2916 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2917
f08b802a
PE
2918 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2919 warning when compiling print.c.
2920
3ddb0639
PE
2921 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2922 instead of using an uninitialized var.
5ad03b97 2923 (font_sort_entities): Mark var as initialized.
3ddb0639 2924
170a2692
PE
2925 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2926
e663c700
PE
2927 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2928 pointers to constants.
89bc529a 2929 (font_parse_fcname): Remove unused vars.
7b81e2d0 2930 (font_delete_unmatched): Now static.
ea838e10 2931 (font_get_spec): Remove; unused.
13a547c6
PE
2932 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2933 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2934 Rename or move locals to avoid shadowing.
e663c700 2935
2a80c887 2936 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2937 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2938
1384fa33 2939 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2940 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2941
8b2c52e9
PE
2942 * alloc.c (mark_backtrace): Move decl from here ...
2943 * lisp.h: ... to here, so that it can be checked.
2944
475545b5 2945 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2946 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2947 (lisp_indirect_variable): Name an expression,
2948 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2949 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2950
b1349114 2951 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2952 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2953 Use const pointer when appropriate.
b1349114 2954
a2928364
PE
2955 * lisp.h (get_system_name, get_operating_system_release):
2956 Move decls here, to check interfaces.
2957 * process.c (get_operating_system_release): Move decl to lisp.h.
2958 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2959 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2960 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2961 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2962 (Fformat_time_string, Fencode_time, Finsert_char):
2963 (Ftranslate_region_internal, Fformat):
2964 Rename or remove local vars to avoid shadowing.
9710023e 2965 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2966
a415e694
PE
2967 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2968 avoid shadowing.
2969
8ef4622d
PE
2970 * lisp.h (eassert): Check that the argument compiles, even if
2971 ENABLE_CHECKING is not defined.
2972
946f9a5b
PE
2973 * data.c (Findirect_variable): Name an expression, to avoid
2974 gcc -Wbad-function-cast warning.
112396d6 2975 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2976 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2977 (Fmake_variable_buffer_local, Fmake_local_variable):
2978 Mark variables as initialized.
52746918 2979 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2980
e5aab7e7 2981 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2982 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2983 Rename locals to avoid shadowing.
dff45157
PE
2984 (mark_stack): Move local variables into the #ifdef region where
2985 they're used.
7bc26fdb
PE
2986 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2987 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2988 needed otherwise.
2989 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2990 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2991 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2992
e5aab7e7
PE
2993 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2994 avoids undefined behavior in theory.
2995
4da60324
PE
2996 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2997
88043301
PE
2998 Use functions, not macros, for up- and down-casing (Bug#8254).
2999 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3000 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3001 to use the following functions instead of these macros.
3002 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3003 EMACS_INT, since callers assume the returned value fits in int.
3004 (upcase1): Likewise, for UPCASE_TABLE.
3005 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3006 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3007 the race-condition problem in the old DOWNCASE.
88043301 3008
19ed5445
PE
3009 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3010 Rename locals to avoid shadowing.
3011 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3012 (regex_compile, re_search_2, re_match_2_internal):
3013 Remove unused local vars.
952db0d7
PE
3014 (FREE_VAR): Rewrite so as not to use empty "else",
3015 which gcc can warn about.
da053e48 3016 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3017 (RETALLOC_IF): Define only if needed.
3018 (WORDCHAR_P): Likewise. This one is never needed, but is used
3019 only in a comment talking about a compiler bug, so put inside
3020 the #if 0 of that comment.
3021 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3022 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3023 Remove; unused.
19ed5445 3024
1f3561e4 3025 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3026 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3027 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3028
ded6f8f7
PE
3029 * search.c (simple_search): Remove unused var.
3030
dbd37a95
PE
3031 * dired.c (compile_pattern): Move decl from here ...
3032 * lisp.h: ... to here, so that it can be checked.
3033 (struct re_registers): New forward decl.
3034
7e47afad
PE
3035 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3036
85f24f61
PE
3037 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3038 All uses changed.
3039 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3040 Rename locals to avoid shadowing.
5671df8f 3041 (Fvertical_motion): Mark locals as initialized.
85f24f61 3042
181aa2be 3043 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3044 (casify_region): Mark local as initialized.
181aa2be 3045
930d429c
PE
3046 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3047
7082eac6
PE
3048 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3049 New macros, so that the caller can use some names other than
3050 gcpro1, gcpro2, etc.
3051 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3052 of the new macros.
3053 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3054 argument, for consistency with GCPRO2_VAR, etc: it is now the
3055 prefix of the variable, not the variable itself. All uses
3056 changed.
38b2c076
PE
3057 * dired.c (directory_files_internal, file_name_completion):
3058 Rename locals to avoid shadowing.
3059
15206ed9
PE
3060 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3061 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3062 dired.c's scmp function, had undefined behavior.
3063 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3064 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3065 * buffer.h: ... to here, because these macros use current_buffer,
3066 and the new implementation with inline functions needs to have
3067 current_buffer in scope now, rather than later when the macros
3068 are used.
3069 (downcase, upcase1): New static inline functions.
3070 (DOWNCASE, UPCASE1): Reimplement using these functions.
3071 This avoids undefined behavior in expressions like
3072 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3073 from race conditions in accessing the global variables
3074 case_temp1 and case_temp2.
3075 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3076 * lisp.h (case_temp1, case_temp2): Remove their decls.
3077 * character.h (ASCII_CHAR_P): Move from here ...
3078 * lisp.h: ... to here, so that the inline functions mentioned
3079 above can use them.
3080
4a6bea26
PE
3081 * dired.c (directory_files_internal_unwind): Now static.
3082
f14b7e14
PE
3083 * fileio.c (file_name_as_directory, directory_file_name):
3084 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3085 Now static.
2893f146
PE
3086 (file_name_as_directory): Use const pointers when appropriate.
3087 (Fexpand_file_name): Likewise. In particular, newdir might
3088 point at constant storage, so make it a const pointer.
fd4ead52 3089 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3090 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3091 signedness issues.
f839df0c
PE
3092 (Fset_file_times, Finsert_file_contents, auto_save_error):
3093 Rename locals to avoid shadowing.
f14b7e14 3094
5716756e 3095 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3096 (Ftry_completion, Fall_completions): Rename or remove locals
3097 to avoid shadowing.
5716756e 3098
b4c3046a
PE
3099 * marker.c (bytepos_to_charpos): Remove; unused.
3100
b45db522
PE
3101 * lisp.h (verify_bytepos, count_markers): New decls,
3102 so that gcc does not warn that these functions aren't declared.
3103
85876d07
PE
3104 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3105 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3106 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3107 (copy_text): Remove unused local var.
85876d07 3108
03d78a21 3109 * filelock.c (within_one_second): Now static.
b3dd38ab 3110 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3111
5df8f01b
PE
3112 * buffer.c (fix_overlays_before): Mark locals as initialized.
3113 (fix_start_end_in_overlays): Likewise. This function should be
3114 simplified by using pointers-to-pointers, but that's a different
3115 matter.
b1d876f1 3116 (switch_to_buffer_1): Now static.
8f54f30a
PE
3117 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3118 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3119
a70072c9 3120 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3121 Fix pointer signedness issue.
edced198
PE
3122 (sys_subshell): Mark local as volatile if checking for lint,
3123 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3124 (MAXPATHLEN): Define only if needed.
a70072c9 3125
a0977c44
PE
3126 * process.c (serial_open, serial_configure): Move decls from here ...
3127 * systty.h: ... to here, so that they can be checked.
3128
a884fdcc
PE
3129 * fns.c (get_random, seed_random): Move extern decls from here ...
3130 * lisp.h: ... to here, so that they can be checked.
3131
604efe86 3132 * sysdep.c (reset_io): Now static.
b8950c94 3133 (wait_for_termination_signal): Remove; unused.
604efe86 3134
38fc62d9
PE
3135 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3136 (copy_keymap_item, append_key, push_text_char_description):
3137 Now static.
1004a21a 3138 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3139 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3140 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3141 (describe_map_tree):
3142 Rename locals to avoid shadowing.
38fc62d9 3143
2f2650da
PE
3144 * keyboard.c: Declare functions static if they are not used elsewhere.
3145 (echo_char, echo_dash, cmd_error, top_level_2):
3146 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3147 (read_char, kbd_buffer_get_event, make_lispy_position):
3148 (make_lispy_event, make_lispy_movement, apply_modifiers):
3149 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3150 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3151 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3152 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3153 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3154
a053e86c 3155 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3156 (mark_kboards): Move decl here ...
3157 * alloc.c (mark_kboards): ... from here.
a053e86c 3158
4752793e
PE
3159 * lisp.h (force_auto_save_soon): New decl.
3160
74f10ca7 3161 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3162 (DEFINE_DUMMY_FUNCTION): New macro.
3163 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3164 Use it.
c03cd23f
PE
3165 (main): Add casts to avoid warnings
3166 if GCC considers string literals to be constants.
74f10ca7 3167
022e70d4
PE
3168 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3169
59d6fe83
PE
3170 * dbusbind.c: Pointer signedness fixes.
3171 (xd_signature, xd_append_arg, xd_initialize):
3172 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3173 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3174 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3175 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3176
78320123
PE
3177 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3178 if GCC considers string literals to be constants.
49cebcca 3179 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3180
35ac2a97
SM
31812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3182
fb103ca9
SM
3183 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3184 (print_preprocess, print_object): New macro to fix last change.
3185
35ac2a97
SM
3186 * print.c (print_preprocess): Don't forget font objects.
3187
62973b41
JB
31882011-03-16 Juanma Barranquero <lekktu@gmail.com>
3189
3190 * emacs.c (USAGE3): Doc fixes.
3191
0e48bb22
AS
31922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3193
3194 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3195 structure.
3196
7684e57b
JB
31972011-03-14 Juanma Barranquero <lekktu@gmail.com>
3198
3199 * lisp.h (VWindow_system, Qfile_name_history):
3200 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3201 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3202 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3203
3204 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3205 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3206
3207 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3208 * w32console.c (detect_input_pending, read_input_pending)
3209 (encode_terminal_code):
3210 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3211 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3212 (w32_system_caret_y, Qfile_name_history):
3213 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3214 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3215 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3216 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3217 * w32proc.c (Qlocal, report_file_error):
3218 * w32term.c (Vwindow_system, updating_frame):
3219 * w32uniscribe.c (initialized, uniscribe_font_driver):
3220 Remove unneeded extern declarations.
3221
2aa46d6c
CY
32222011-03-14 Chong Yidong <cyd@stupidchicken.com>
3223
c96bbc66 3224 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3225
cffc6f3b
CY
32262011-03-13 Chong Yidong <cyd@stupidchicken.com>
3227
3228 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3229 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3230 These macros can no longer be used for assignment.
3231
44f230aa
SM
3232 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3233 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3234 (record_buffer_markers, fetch_buffer_markers): New functions for
3235 recording and fetching special buffer markers.
3236 (set_buffer_internal_1, set_buffer_temp): Use them.
3237
3238 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3239
3240 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3241
3242 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3243 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3244
3245 * xdisp.c (hscroll_window_tree):
3246 (reconsider_clip_changes): Use PT instead of BUF_PT.
3247
d251f04b
EZ
32482011-03-13 Eli Zaretskii <eliz@gnu.org>
3249
3250 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3251 $(EMACS_ROOT)/lib/intprops.h.
3252
f0c77cd1
PE
32532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3254
3eca4629
PE
3255 Fix more problems found by GCC 4.5.2's static checks.
3256
7c86ee98
PE
3257 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3258 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3259 (xg_free_frame_widgets): Make it clear that a local variable is
3260 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3261 (gdk_window_get_screen): Make it clear that this macro is needed
3262 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3263 (int_gtk_range_get_value): New function, which avoids a diagnostic
3264 from gcc -Wbad-function-cast.
3265 (xg_set_toolkit_scroll_bar_thumb): Use it.
3266 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3267 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3268 (get_utf8_string, xg_get_file_with_chooser):
3269 Rename locals to avoid shadowing.
3270 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3271
41729b81
PE
3272 * xgselect.c (xg_select): Remove unused var.
3273
f0c77cd1
PE
3274 * image.c (four_corners_best): Mark locals as initialized.
3275 (gif_load): Initialize transparent_p to zero (Bug#8238).
3276 Mark another local as initialized.
ec6cf4c6 3277 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3278
ce0ad53d 3279 * image.c (clear_image_cache): Now static.
d5d5a617 3280 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3281 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3282 (x_edge_detection): Remove unnecessary cast that
3283 gcc -Wbad-function-cast diagnoses.
2037898d 3284 (gif_load): Fix pointer signedness.
6ae141d6
PE
3285 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3286 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3287
33383987 32882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3289
d32df629
PE
3290 Improve quality of tests for time stamp overflow.
3291 For example, without this patch (encode-time 0 0 0 1 1
3292 1152921504606846976) returns the obviously-bogus value (-948597
3293 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3294 reports time overflow. See
3295 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3296 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3297 * editfns.c: Include limits.h and intprops.h.
3298 (TIME_T_MIN, TIME_T_MAX): New macros.
3299 (time_overflow): Move earlier, to before first use.
3300 (hi_time, lo_time): New functions, for an accurate test for
3301 out-of-range times.
3302 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3303 (Fget_internal_run_time): Don't assume time_t fits in int.
3304 (make_time): Use list2 instead of Fcons twice.
3305 (Fdecode_time): More accurate test for out-of-range times.
3306 (check_tm_member): New function.
3307 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3308 (lisp_time_argument): Don't rely on undefined left-shift and
3309 right-shift behavior when checking for time stamp overflow.
8be6f318 3310
fe31d94c
PE
3311 * editfns.c (time_overflow): New function, refactoring common code.
3312 (Fformat_time_string, Fdecode_time, Fencode_time):
3313 (Fcurrent_time_string): Use it.
3314
8be6f318
PE
3315 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3316 * dired.c (make_time): Move to ...
3317 * editfns.c (make_time): ... here.
3318 * systime.h: Note the move.
3319
09d9db2c 33202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3321
126bc0dc
YM
3322 * fringe.c (update_window_fringes): Remove unused variables.
3323
c47cbdfd
YM
3324 * unexmacosx.c (copy_data_segment): Also copy __got section.
3325 (Bug#8223)
3326
7ac80be9
EZ
33272011-03-12 Eli Zaretskii <eliz@gnu.org>
3328
c96bbc66 3329 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3330 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3331 Constify `char *' arguments and their references according to
3332 prototypes in tparam.h.
3333
ecb0f94d 3334 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3335
7ac80be9
EZ
3336 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3337 Adapt all references accordingly.
3338
3339 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3340
ef1fd07e
TT
33412011-03-11 Tom Tromey <tromey@redhat.com>
3342
3343 * buffer.c (syms_of_buffer): Remove obsolete comment.
3344
7ef4b50c
EZ
33452011-03-11 Eli Zaretskii <eliz@gnu.org>
3346
3347 * termhooks.h (encode_terminal_code): Declare prototype.
3348
3349 * msdos.c (encode_terminal_code): Don't declare prototype.
3350
3351 * term.c (encode_terminal_code): Now external again, used by
3352 w32console.c and msdos.c.
3353
44f230aa
SM
3354 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3355 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3356
4b1ec863 33572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3358
1714f52b 3359 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3360
4b1ec863
PE
3361 * fringe.c (update_window_fringes): Mark locals as initialized
3362 (Bug#8227).
3363 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3364
524c7aa6
PE
3365 * alloc.c (mark_fringe_data): Move decl from here ...
3366 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3367 to check its interface.
3368 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3369
a5c0af81 3370 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3371 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3372 (fontset_font): Mark local as initialized.
a9a06e0b 3373 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3374
b4716021
PE
3375 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3376
811e9bac 3377 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3378 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3379 (x_own_selection, Fx_disown_selection_internal): Rename locals
3380 to avoid shadowing.
3381 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3382
7e3ab302
PE
3383 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3384 so that the caller can use some name other than gcpro1.
3385 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3386 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3387 (Fx_backspace_delete_keys_p):
3388 Use them to avoid shadowing, and rename vars to avoid shadowing.
3389 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3390 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3391 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3392 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3393 Remove unused locals.
7e3ab302
PE
3394 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3395 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3396 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3397 macros.
f78faa98 3398
e2b13473
PE
3399 * xterm.h (x_mouse_leave): New decl.
3400
77f23912
PE
3401 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3402 Remove unused functions.
cdf4ba58
PE
3403 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3404 (x_calc_absolute_position): Now static.
7411c686 3405 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3406 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3407 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3408 unless they are used.
38d0b34a
PE
3409 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3410 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3411 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3412 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3413 (x_error_catcher, x_connection_closed, x_error_handler):
3414 (x_error_quitter, xembed_send_message, x_iconify_frame):
3415 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3416 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3417 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3418
44f230aa
SM
3419 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3420 Rename or move locals to avoid shadowing.
6b463e58 3421 (tty_defined_color, merge_face_heights): Now static.
5967d051 3422 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3423 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3424 does not deduce is never used uninitialized.
73719eba
PE
3425 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3426 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3427
426994c3 3428 * terminal.c (store_terminal_param): Now static.
5489860b 3429
032f1620 3430 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3431 (set_frame_menubar): Remove unused local.
d4323972 3432 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3433 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3434 since they might point to immutable storage.
281585b0
PE
3435 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3436 since it's unused otherwise.
032f1620 3437
367c19e5 3438 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3439 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3440 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3441 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3442 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3443 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3444 does not deduce are never used uninitialized.
70739cbe 3445
07b48fa9
PE
3446 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3447
8868a238 3448 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3449 * window.c (window_loop, size_window):
3450 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3451
7e5cf297 3452 * window.c (display_buffer): Now static.
d6550a9f
PE
3453 (size_window): Mark variables that gcc -Wuninitialized
3454 does not deduce are never used uninitialized.
a586633d
PE
3455 * window.h (check_all_windows): New decl, to forestall
3456 gcc -Wmissing-prototypes diagnostic.
5b555da1 3457 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3458
f6095868
PE
3459 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3460 shadowing.
3461 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3462 Include <limits.h>.
3463 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3464 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3465 (load_charset_map): Mark variables that gcc -Wuninitialized
3466 does not deduce are never used uninitialized.
53df7c11 3467 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3468
f38b440c
PE
3469 * coding.c (coding_set_source, coding_set_destination):
3470 Use "else { /* comment */ }" rather than "else /* comment */;"
3471 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3472 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3473 a block, when the outer 'i' will do.
3474 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3475 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3476 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3477 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3478 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3479 Rename locals to avoid shadowing.
3480 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3481 * coding.c (emacs_mule_char, encode_invocation_designation):
3482 Now static, since they're not used elsewhere.
413bb2db 3483 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3484 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3485 (decode_coding_emacs_mule): Mark variables that gcc
3486 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3487 (detect_coding_iso_2022): Initialize a local variable that might
3488 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3489 this initialization is needed. (Bug#8211)
5f58e762
PE
3490 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3491 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3492 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3493 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3494 Remove unused macros.
f38b440c 3495
232b38b9 3496 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3497 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3498 * character.c (string_count_byte8): Likewise.
232b38b9 3499
fb90da1b
PE
3500 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3501 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3502
fb93dbc2
PE
3503 * chartab.c (copy_sub_char_table): Now static, since it's not used
3504 elsewhere.
5c156ace
PE
3505 (sub_char_table_ref_and_range, char_table_ref_and_range):
3506 Rename locals to avoid shadowing.
bbcd0949 3507 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3508
7d3b3862 3509 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3510 (BIDI_BOB): Remove unused macro.
7d3b3862 3511
6be7d3da
PE
3512 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3513 deduce are never used uninitialized.
c2ed9c8b 3514 * term.c (encode_terminal_code): Likewise.
6be7d3da 3515
75f8807f 3516 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3517
50938595
PE
3518 * tparam.h: New file.
3519 * term.c, tparam.h: Include it.
3520 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3521 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3522 Move these decls to tparam.h, and make them agree with what
3523 is actually in tparam.c. The previous trick of using incompatible
3524 decls in different modules does not conform to the C standard.
3525 All callers of tparam changed to use tparam's actual API.
3526 * tparam.c (tparam1, tparam, tgoto):
3527 Use const pointers where appropriate.
3528
fbceeba2
PE
3529 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3530 * cm.h (struct cm): Likewise.
3531 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3532 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3533 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3534 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3535 (turn_on_face, init_tty): Likewise.
3536 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3537
7f3f1250
PE
3538 * term.c (term_mouse_position): Rename local to avoid shadowing.
3539
e6ca6543
PE
3540 * alloc.c (mark_ttys): Move decl from here ...
3541 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3542
c40f8d15
AS
35432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3544
3545 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3546
cfe0661d
JB
35472011-03-09 Juanma Barranquero <lekktu@gmail.com>
3548
3549 * search.c (compile_pattern_1): Remove argument regp, unused since
3550 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3551 (compile_pattern): Don't pass it.
3552
0afb4571
J
35532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3554
3555 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3556 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3557 for ! HAVE_GTK3.
3558 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3559
3560 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3561
3562 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3563 gdk_window_get_screen, gdk_window_get_geometry,
3564 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3565 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3566 (xg_get_pixbuf_from_pixmap): New function.
3567 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3568 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3569 Call xg_get_pixbuf_from_pixmap instead of
3570 gdk_pixbuf_get_from_drawable.
3571 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3572 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3573 (xg_check_special_colors): Use GtkStyleContext and its functions
3574 for HAVE_GTK3.
3575 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3576 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3577 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3578 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3579 Call gtk_widget_get_preferred_size.
0afb4571
J
3580 (xg_frame_resized): gdk_window_get_geometry only takes 5
3581 parameters.
44f230aa
SM
3582 (xg_win_to_widget, xg_event_is_for_menubar):
3583 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3584 (xg_set_widget_bg): New function.
3585 (delete_cb): New function.
895009e1 3586 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3587 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3588 (xg_set_background_color): Call xg_set_widget_bg.
3589 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3590 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3591 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3592 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3593 if ! HAVE_GTK3.
3594 (update_frame_tool_bar): Call gtk_widget_hide.
3595 (xg_initialize): Use GDK_KEY_g.
3596
3597 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3598 if ! HAVE_GTK3
3599 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3600
3601 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3602 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3603 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3604
1c2cc4ef
JB
36052011-03-08 Juanma Barranquero <lekktu@gmail.com>
3606
3607 * w32xfns.c (select_palette): Check success of RealizePalette against
3608 GDI_ERROR, not zero.
3609
33383987 3610See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3611
3612;; Local Variables:
3613;; coding: utf-8
aac0c6e3
MR
3614;; End:
3615
33383987 3616 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3617
3618 This file is part of GNU Emacs.
3619
3620 GNU Emacs is free software: you can redistribute it and/or modify
3621 it under the terms of the GNU General Public License as published by
3622 the Free Software Foundation, either version 3 of the License, or
3623 (at your option) any later version.
3624
3625 GNU Emacs is distributed in the hope that it will be useful,
3626 but WITHOUT ANY WARRANTY; without even the implied warranty of
3627 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3628 GNU General Public License for more details.
3629
3630 You should have received a copy of the GNU General Public License
3631 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.